Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
97147da9
EZ
12012-08-04 Eli Zaretskii <eliz@gnu.org>
2
3 * msdos.c (dos_set_window_size, IT_update_begin)
4 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
5 instead of direct references.
6
185ee146
PE
72012-08-04 Paul Eggert <eggert@cs.ucla.edu>
8
9 Export DEFAULT_REHASH_* to GDB.
10 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
11 Now constants, not macros.
12
8834c57a
PE
132012-08-03 Paul Eggert <eggert@cs.ucla.edu>
14
98c6f1e3
PE
15 Remove unnecessary casts involving pointers.
16 These casts are no longer needed now that we assume C89 or later,
17 since they involve casting to or from void *.
18 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
19 (make_pure_float, make_pure_vector):
20 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
21 * macros.c (Fstart_kbd_macro):
22 * menu.c (find_and_return_menu_selection):
23 * minibuf.c (read_minibuf_noninteractive):
24 * sysdep.c (closedir):
25 * xdisp.c (x_produce_glyphs):
26 * xfaces.c (compare_fonts_by_sort_order):
27 * xfns.c (x_real_positions, select_visual):
28 * xselect.c (x_stop_queuing_selection_requests)
29 (x_get_window_property, x_get_window_property_as_lisp_data):
30 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
31 Remove unnecessary pointer casts.
32 * alloc.c (record_xmalloc): New function.
33 * lisp.h (record_xmalloc): New decl.
34 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
35 more like a function. This is because the pointer cast is not
36 needed. All uses changed.
37 * print.c (print_string, print_error_message): Avoid length recalc.
38
8834c57a
PE
39 Improve fix for macroexp crash with debugging (Bug#12118).
40 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
41 ARRAY_MARK_FLAG when checking subscripts, because ASET is
42 not supposed to be invoked from the garbage collector.
43 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
44 (gc_aset): New function, which is like ASET but can be
45 used in the garbage collector.
46 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
47 (set_hash_index): Use it instead of ASET.
48
6dad7178
EZ
492012-08-03 Eli Zaretskii <eliz@gnu.org>
50
51 Support symlinks on latest versions of MS-Windows.
52 * w32.c: Include winioctl.h and aclapi.h.
53 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
54 (revert_to_self): Forward declarations of static functions.
55 <static BOOL g_b_init_get_security_info>:
56 <g_b_init_create_symbolic_link>: New static flags.
57 (globals_of_w32): Initialize them to zero.
58 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
59 (map_w32_filename): Improve commentary. Simplify switch.
60 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
61 headers (most versions of MinGW w32api don't).
62 (get_security_info, create_symbolic_link)
63 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
64 New functions.
65 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
66 in the argument file name.
67 (sys_access): Call unc_volume_file_attributes only if
68 GetFileAttributes fails with network-related error codes.
69 (sys_rename): Diagnose renaming of a symlink when the user doesn't
70 have the required privileges.
71 (get_file_security_desc_by_name): Renamed from
72 get_file_security_desc.
73 (stat_worker): New function, with most of the guts of 'stat', and
74 with addition of handling of symlinks and support for 'lstat'. If
75 possible, get file's attributes and security information by
76 handle, not by name. Produce S_IFLNK bit for symlinks, when
77 called from 'lstat'.
78 (stat, lstat): New functions, call 'stat_worker'.
79 (symlink, readlink, careadlinkat): Rewritten to create and resolve
80 symlinks when the underlying filesystem supports them.
81
f162bcc3
PE
822012-08-02 Paul Eggert <eggert@cs.ucla.edu>
83
79ea6c20
PE
84 Fix macroexp crash on Windows with debugging (Bug#12118).
85 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
86 checking subscripts; problem introduced with the recent
87 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
88 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
89 since it's used in non-static inline functions now.
90
c0ce93fd
PE
91 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
92 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 93
f162bcc3
PE
94 Use C99-style 'extern inline' if available.
95 * buffer.h (BUFFER_INLINE):
96 * category.h (CATEGORY_INLINE):
97 * character.h (CHARACTER_INLINE):
98 * charset.h (CHARSET_INLINE):
99 * composite.h (COMPOSITE_INLINE):
100 * dispextern.h (DISPEXTERN_INLINE):
101 * lisp.h (LISP_INLINE):
102 * systime.h (SYSTIME_INLINE):
103 New macro, replacing 'static inline' in this header.
104 * buffer.h, category.h, character.h, charset.h, composite.h:
105 * dispextern.h, lisp.h, systime.h:
106 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
107 * alloc.c (LISP_INLINE):
108 * buffer.c (BUFFER_INLINE):
109 * category.c (CATEGORY_INLINE):
110 * character.c (CHARACTER_INLINE):
111 * charset.c (CHARSET_INLINE):
112 * composite.c (COMPOSITE_INLINE):
113 * dispnew.c (DISPEXTERN_INLINE):
114 * sysdep.c (SYSTIME_INLINE):
115 Define to EXTERN_INLINE, so that the corresponding functions
116 are compiled into code.
117 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
118 (INLINE_HEADER_END): New macros.
119 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
120 since it's used in non-static inline functions now.
a8333d03 121 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 122
837b365b
GM
1232012-08-02 Glenn Morris <rgm@gnu.org>
124
d66b744d
GM
125 * s/: Remove empty directory.
126
837b365b
GM
127 * s/ms-w32.h: Move to ../nt/inc.
128 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
129 Update for new ms-w32.h location.
130
13294f95
PE
1312012-08-02 Paul Eggert <eggert@cs.ucla.edu>
132
133 Port to Solaris 8.
134 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
135
90df0db3
GM
1362012-08-02 Glenn Morris <rgm@gnu.org>
137
138 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
139 hard-coding the path separator.
140
4939150c
PE
1412012-08-01 Paul Eggert <eggert@cs.ucla.edu>
142
143 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
144 This how ASET and AREF are supposed to work, and makes
145 it easier to think about future improvements. See
146 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
147 * charset.h (set_charset_attr): New function.
148 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
149 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
150 (aref_addr): New function. All uses of &AREF(...) changed.
151 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
152 (set_hash_index): New functions. All lvalue-style uses of
153 HASH_KEY etc. changed.
154 * keyboard.c (set_prop): New function. All lvalue-style uses
155 of PROP changed.
156
947b2afd
AA
1572012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
158
159 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
160 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
161 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
162 * nsfns.m (ns_set_name_as_filename): Likewise.
163 * nsmenu.m (ns_update_menubar): Likewise.
164 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
165
4f5d0325
EZ
1662012-08-01 Eli Zaretskii <eliz@gnu.org>
167
2008beae
EZ
168 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
169 Adapt to latest changes in field names of the corresponding Lisp
288479f6 170 objects.
2008beae 171
4f5d0325
EZ
172 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
173
fe3cc771
GM
1742012-08-01 Glenn Morris <rgm@gnu.org>
175
176 * s/msdos.h: Remove file.
177 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
178 * Makefile.in (S_FILE): Remove.
179 (config_h): Remove S_FILE.
180
c90acc54
JB
1812012-08-01 Juanma Barranquero <lekktu@gmail.com>
182
183 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
184 Remove; moved to nt/config.nt.
185
d8a05828
DA
1862012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
187
188 Use INTERNAL_FIELD for conses and overlays.
189 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
190 Remove obsolete comment.
191 (MVAR): New macro.
192 (struct Lisp_Overlay): Use INTERNAL_FIELD.
193 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
194
8271d590
DA
1952012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
196
197 Use INTERNAL_FIELD for symbols.
198 * lisp.h (SVAR): New macro. Adjust users.
199 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
200 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
201
3193acd2
DA
2022012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
203
204 Use INTERNAL_FIELD for processes.
205 * process.h (PVAR): New macro. Adjust style.
206 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
207 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
208
3a45383a
DA
2092012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
210
211 Use INTERNAL_FIELD for windows.
212 * window.h (WVAR): New macro.
213 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
214 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
215 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
216 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
217 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
218 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
219
c1dbc63c
PE
2202012-08-01 Paul Eggert <eggert@cs.ucla.edu>
221
222 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
223
5c0c0e8a
GM
2242012-08-01 Glenn Morris <rgm@gnu.org>
225
226 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
227 Move to configure.ac.
228
552a99b4
JB
2292012-08-01 Juanma Barranquero <lekktu@gmail.com>
230
231 * makefile.w32-in (CONFIG_H): Update dependencies.
232 (CONF_POST_H): New macro.
233
234 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
235
8d8e2dfe
GM
2362012-07-31 Glenn Morris <rgm@gnu.org>
237
bc96620a
GM
238 * Makefile.in (S_FILE): No longer set by configure.
239
476b1b2d
GM
240 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
241 is available.
242 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
243
b2c7a106
GM
244 * process.h (NULL_DEVICE):
245 * emacs.c (SEPCHAR):
246 * editfns.c (USER_FULL_NAME): Let configure set them.
247
d53d062a
GM
248 * s/README, s/template.h: Remove files.
249
4515017f
GM
250 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
251
8d8e2dfe
GM
252 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
253 Move to configure.ac.
254
5b20b3cc
EZ
2552012-07-31 Eli Zaretskii <eliz@gnu.org>
256
1e0afd9a
EZ
257 * .gdbinit (xframe): Adapt to introduction of FVAR and the
258 resulting renaming of 'struct frame' members.
259
5b20b3cc
EZ
260 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
261
262 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
263 after introduction of FVAR.
264
f1310128
JD
2652012-07-31 Jan Djärv <jan.h.d@swipnet.se>
266
79e721e0
JD
267 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
268
269 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
270 instead of compositeToPoint.
271 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
272
8d7c7eed 273 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 274
e34f7f79
DA
2752012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
276
277 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
278 * lisp.h (INTERNAL_FIELD): New macro.
279 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
280 (BVAR): Change to use INTERNAL_FIELD.
281 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
282 (KVAR): Change to use INTERNAL_FIELD.
283 * frame.h (FVAR): New macro.
284 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
285 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
286 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
287 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
288 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
289
c09bfb2f
DA
2902012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
291
292 Miscellaneous fixes for non-default X toolkits.
293 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
294 * xterm.c (x_frame_of_widget): Remove redundant prototype.
295 Move under #ifdef USE_LUCID.
296 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
297 definition and usage to avoid warnings.
298
14c114ae
JD
2992012-07-31 Jan Djärv <jan.h.d@swipnet.se>
300
301 * nsterm.m (openFiles): Fix previous checkin.
302
3bd21e82
PE
3032012-07-31 Paul Eggert <eggert@cs.ucla.edu>
304
305 * indent.c (compute_motion): Remove unused local.
306
c1529ded
GM
3072012-07-31 Glenn Morris <rgm@gnu.org>
308
400d5621
GM
309 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
310
268e2432
GM
311 * conf_post.h [USG5_4]:
312 Move remaining contents of s/usg5-4-common.h here.
313 * s/usg5-4-common.h: Remove file.
314
7552f3ee
GM
315 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
316 * s/irix6-5.h: Remove file.
317
6a381852
GM
318 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
319 * s/darwin.h: Remove file.
320
c1529ded
GM
321 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
322 * s/hpux10-20.h: Remove file, which is now empty.
323
b429a4ee
GM
3242012-07-30 Glenn Morris <rgm@gnu.org>
325
326 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
327 * Makefile.in (config_h): Add conf_post.h.
328 * makefile.w32-in (CONFIG_H): Add conf_post.h.
329
adff3182
JD
3302012-07-30 Jan Djärv <jan.h.d@swipnet.se>
331
332 * nsterm.m (ns_do_open_file): New variable.
b9031d69 333 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
334 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
335 files only if ns_do_open_file.
336
c32af1e4
PE
3372012-07-30 Paul Eggert <eggert@cs.ucla.edu>
338
7393bcbb
PE
339 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
340 This no-op macro hasn't been needed for many years.
341 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
342
c32af1e4
PE
343 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
344 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
345 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
346 gdb_make_enums_visible.
347 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
348 (DIRECTORY_SEP): Now a constant, not a macro.
349
302fc036
EZ
3502012-07-30 Eli Zaretskii <eliz@gnu.org>
351
352 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
353 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
354
355 * w32term.c <w32_keyboard_codepage>: Renamed from
356 keyboard_codepage and now external. All users changed.
357
358 * w32term.h: Add declaration of w32_keyboard_codepage.
359
360 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
361 the codepage to translate keys to Unicode. If this argument is
362 -1, use the value returned by GetConsoleCP. All callers changed.
363
88fb40b4
PE
3642012-07-30 Paul Eggert <eggert@cs.ucla.edu>
365
0aee6912
PE
366 Update .PHONY listings in makefiles.
367 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
368 bootstrap-clean, distclean, maintainer-clean, versioclean,
369 extraclean, frc.
370
88fb40b4
PE
371 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
372 This is a bit clearer. Fix some commentary typos.
373
0a763bd1
GM
3742012-07-30 Glenn Morris <rgm@gnu.org>
375
32bac6d6
GM
376 * s/netbsd.h: Let configure include signal.h if needed.
377 Remove file, which is now empty.
378
b65e7c46
GM
379 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
380 Let configure set them.
381 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
382 No more need to undefine.
0a763bd1 383
169304bd
AS
3842012-07-30 Andreas Schwab <schwab@linux-m68k.org>
385
386 * keymap.c (Fkey_description): Don't remove 0x80 bit from
387 non-single-byte char when adding meta modifier. (Bug#12090)
388
6cd7a139
DA
3892012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
390
391 Convert safe_call to use variable number of arguments.
392 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
393 (safe_call2): Fix comment.
394 * lisp.h (safe_call): Adjust prototype.
395 * coding.c (encode_coding_object): Change to use safe_call2.
396 * xfaces.c (merge_face_heights): Change to use safe_call1.
397
d34d6ffc
GM
3982012-07-30 Glenn Morris <rgm@gnu.org>
399
7b8a48e4 400 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 401 does that unconditionally. Remove file, which is now empty.
7b8a48e4 402
d34d6ffc
GM
403 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
404 Remove empty files.
405
03a660a6
PE
4062012-07-30 Paul Eggert <eggert@cs.ucla.edu>
407
408 Export to GDB most of lisp.h's remaining object-like macros.
409 * lisp.h (min, max): Move earlier, because they're used earlier now.
410 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
411 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
412 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
413 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
414 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
415 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
416 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
417 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
418 Now constants, for GDB. They need not be macros.
419 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
420 Now constants, for GDB, as well as macros, for static initializers.
421 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
422 Move to after the definition of struct Lisp_Char_Table,
423 since the former now needs that type defined.
424 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
425 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
426 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
427 New enums, for gdb_make_enums_visible.
428 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 429 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
430 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
431 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
432 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
433 enum maxargs, enum MAX_ALLOCA.
434 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
435 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
436 no longer needed, now that they are done in lisp.h.
437
e499d0ee
DA
4382012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
439
440 Cleanup string bytes checking.
441 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
442 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
443 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
444 (check_sblock, compact_small_strings): Simplify.
445
d5040d2d
PE
4462012-07-29 Paul Eggert <eggert@cs.ucla.edu>
447
448 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
449 These macros are confusing and no longer need to be defined, as
450 the enum values now suffice. All uses replaced with definiens.
451 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
452
7f259ae6
JB
4532012-07-29 Juanma Barranquero <lekktu@gmail.com>
454
455 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
456 ($(BLD)/w32console.$(O)): Update dependencies.
457
7e63e0c3
DA
4582012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
459
460 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
461 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
462 time. Adjust users.
463 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
464
ffd817eb
JD
4652012-07-29 Jan Djärv <jan.h.d@swipnet.se>
466
467 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
468 setting sitelisp (Bug#12010).
469
417a7a0e
EZ
4702012-07-29 Eli Zaretskii <eliz@gnu.org>
471
472 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
473
474 * w32heap.c (cache_system_info):
475 * w32.c (sys_rename):
476 * w32proc.c (find_child_console, sys_kill): All users changed.
477
387d4d92
PE
4782012-07-29 Paul Eggert <eggert@cs.ucla.edu>
479
480 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
481
55a6cca6
EZ
4822012-07-29 Eli Zaretskii <eliz@gnu.org>
483
484 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
485
dbcf001c
DA
4862012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
487
488 Cleanup statistics calculation in Fgarbage_collect.
489 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
490 zombies percentage calculation. Simplify elapsed time calculation.
491
e2688e4a
DA
4922012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
493
494 Generalize marker debugging code under MARKER_DEBUG and use eassert.
495 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
496 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
497 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
498 (replace_range, replace_range_2, del_range_2): Change to eassert.
499 * marker.c (byte_char_debug_check): Adjust style.
500
b46a6a83
PE
5012012-07-29 Paul Eggert <eggert@cs.ucla.edu>
502
503 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
504 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
505 long-ago-commented-out code that talks about "WIN32".
506 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
507 All uses changed.
508
e32a5799
PE
5092012-07-28 Paul Eggert <eggert@cs.ucla.edu>
510
511 Use Gnulib stdalign module (Bug#9772, Bug#9960).
512 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
513 Simplify by using alignof.
514 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
515 * lisp.h: Include <stdalign.h>.
516 (GCALIGNMENT): New macro and constant.
517 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
518 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
519 (stdalign): New macro, if not already defined.
520
df81cd29
EZ
5212012-07-28 Eli Zaretskii <eliz@gnu.org>
522
01bd1b0d
EZ
523 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
524 * w32inevt.c: Include w32inevt.h.
525 (w32_read_console_input): New inline function, calls either
526 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
527 w32_console_unicode_input.
528 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
529 (w32_kbd_patch_key, key_event): Use the codepage returned by
530 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
531 (key_event): use uChar.UnicodeChar only if
532 w32_console_unicode_input is non-zero.
533
534 * w32console.c: Include w32heap.h.
535 <w32_console_unicode_input>: New global variable.
536 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
537 family of Windows, zero otherwise.
538
539 * w32inevt.h: Declare w32_console_unicode_input.
540
df81cd29
EZ
541 * xdisp.c (init_iterator): Don't reference tip_frame in a build
542 --without-x. (Bug#11742)
543
c20fdd9e
PE
5442012-07-27 Paul Eggert <eggert@cs.ucla.edu>
545
546 Adjust GDB to reflect pvec_type changes (Bug#12036).
547 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
548 2012-07-04 changes to pseudovector representation. Problem
549 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
550
32770973 5512012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
552
553 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
554 bus address.
555 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
556
3438fe21
EZ
5572012-07-27 Eli Zaretskii <eliz@gnu.org>
558
bcfbc9de
EZ
559 * alloc.c (listn): Fix the order the arguments are consed onto the
560 list.
561
3438fe21
EZ
562 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
563 enumeration constants, as PURE and HEAP are too general, and clash
564 with other headers and sources, such as gmalloc.c and the
565 MS-Windows system headers. All users changed.
566
eeaea515
DA
5672012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
568
569 Revert last save_excursion_save and save_excursion_restore changes.
570 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
571 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
572
073c88c2
DA
5732012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
574
575 Fix recently-introduced typos in Windows port.
576 Reported by Martin Rudalics <rudalics@gmx.at>.
577 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 578 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 579
4706125e
PE
5802012-07-27 Paul Eggert <eggert@cs.ucla.edu>
581
582 Improve GDB symbol export (Bug#12036).
583 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
584 arms of an 'if', not using conditional expressions; otherwise GDB
585 complains about the types in the unevaluated arm when the argument
586 is an integer literal.
587 (xgetint): Simplify expression.
588 * alloc.c (gdb_make_enums_visible): New constant. This ports to
589 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
590 Zaretskii in <http://bugs.gnu.org/12036#13>.
591 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
592 needed now that we have gdb_make_enums_visible.
593 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
594 (enum enum_USE_LSB_TAG):
595 New enum types, packaging up enums that need to be exported to GDB.
596
694b6c97
DA
5972012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
598
599 Utility function to make a list from specified amount of objects.
600 * lisp.h (enum constype): New datatype.
601 (listn): New prototype.
602 * alloc.c (listn): New function.
603 (Fmemory_use_count, syms_of_alloc): Use it.
604 * buffer.c (syms_of_buffer): Likewise.
605 * callint.c (syms_of_callint): Likewise.
606 * charset.c (define_charset_internal): Likewise.
607 * coding.c (syms_of_coding): Likewise.
608 * keymap.c (syms_of_keymap): Likewise.
609 * search.c (syms_of_search): Likewise.
610 * syntax.c (syms_of_syntax): Likewise.
611 * w32.c (init_environment): Likewise.
612 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
613 * xdisp.c (syms_of_xdisp): Likewise.
614 * xfns.c (syms_of_xfns): Likewise.
615
6195f384
DA
6162012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
617
618 Fast save_excursion_save and save_excursion_restore.
619 * lisp.h (struct Lisp_Excursion): New data type.
620 (PVEC_EXCURSION): New pseudovector type.
621 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
622 to deal with it. Adjust comments.
623 (init_marker, attach_marker): New prototype.
624 (unchain_marker): Adjust prototype.
625 * marker.c (attach_marker): Change to global.
626 (init_marker): New function.
627 * alloc.c (Fmake_marker, build_marker): Use it.
628 (build_marker): More easserts.
629 (mark_object): Handle struct Lisp_Excursion.
630 * editfns.c (save_excursion_save, save_excursion_restore):
631 Reimplement to use struct Lisp_Excursion. Add comments.
632
5eceb8fb
PE
6332012-07-26 Paul Eggert <eggert@cs.ucla.edu>
634
635 Fix export of symbols to GDB (Bug#12036).
636 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
637 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
638 emacs.c, as this is a more-suitable home. Had this been done earlier
639 the fix for 12036 would have avoided some of the problems noted in
640 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
641 would have been more obvious.
562157c8
PE
642 * emacs.c: Do not include <verify.h>; no longer needed.
643 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
644 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
645 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
646 Remove; now done in lisp.h.
647 * lisp.h (PUBLISH_TO_GDB): New macro.
648 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
649 (DATA_SEG_BITS): Use it.
650 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
651 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
652 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
653 not be usable in #if. This simplifies things.
654
d6749401
JB
6552012-07-26 Juanma Barranquero <lekktu@gmail.com>
656
657 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
658
1781b9e9
PE
6592012-07-26 Paul Eggert <eggert@cs.ucla.edu>
660
d89518db 661 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
662 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
663 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
664 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
665 Adjust to changes in lisp.h and emacs.c, by using
666 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
667 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
668 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
669 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
670 instead of gdb_valbits.
671 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
672 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
673 instead of gdb_array_mark_flag.
674 (xboolvector): Get size from $->size, not $->header.size.
675 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
676 (xreload, hook-run, hookpost-run): Remove.
677 * emacs.c: Include <verify.h>.
678 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
679 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
680 Remove.
681 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
682 (gdb_USE_LSB_TAG): New enum constants.
683 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
684 Also define these as enum constants, so they're visible to GDB.
685 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
686 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
687 as constants, so they're visible to GDB.
688 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
689 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
690 Now enum constants, not macros, so they're visible to GDB.
691 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
692 more convenient now. All uses changed.
693 (VALMASK) [USE_LSB_TAG]: Also define in this case.
694 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
695
3628596a
DA
6962012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
697
698 Explicitly free restriction data that are not needed anymore.
699 * editfns.c (save_restriction_restore): Free restriction data.
700
7abaf5cc
SM
7012012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
702
703 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
704 add argument, tune behavior, and adjust all callers.
705
71f88e00
PE
7062012-07-25 Paul Eggert <eggert@cs.ucla.edu>
707
708 Use typedef for EMACS_INT, EMACS_UINT.
709 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
710 than macros. This simplifies debugging in the usual case, since
711 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
712 and it allows expressions involving EMACS_INT casts.
713 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
714
57ec3034
JD
7152012-07-25 Jan Djärv <jan.h.d@swipnet.se>
716
717 * nsterm.m (ns_read_socket): Return early if there is a modal
718 window (Bug#12043).
719
8137e7b3
MR
7202012-07-25 Martin Rudalics <rudalics@gmx.at>
721
722 * frame.c (Fredirect_frame_focus): In doc-string don't mention
723 that FOCUS-FRAME can be omitted.
724
04e9897c
DA
7252012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
726
727 Adjust buffer text indirection counters at the end of Fkill_buffer.
728 * buffer.c (Fkill_buffer): Adjust indirection counters when the
729 buffer is definitely dead. This should really fix an issue reported
730 by Christoph Scholtes again. (Bug#12007).
731 (init_buffer_once): Initialize indirection counters of
732 buffer_defaults and buffer_local_symbols (for sanity and safety).
733
8a0484e1
EZ
7342012-07-24 Eli Zaretskii <eliz@gnu.org>
735
736 * xdisp.c (init_iterator): Don't compute dimensions of truncation
737 and continuation glyphs on tooltip frames, leave them at zero.
738 Avoids continued lines in tooltips. (Bug#11832)
739
fa691a83
DA
7402012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
741
742 Simplify copy_overlay.
04e9897c 743 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
744 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
745
436bc8e0
EZ
7462012-07-23 Eli Zaretskii <eliz@gnu.org>
747
748 * print.c (print_object): Don't crash when a frame's name is nil
749 or invalid. (Bug#12025)
750
751 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
752 it signals an error when a tooltip frame is being created.
753
d7a7fda3
DA
7542012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
755
756 Cleanup miscellaneous objects allocation and initialization.
757 * alloc.c (allocate_misc): Change to static. Add argument to
758 specify the subtype. Adjust comment and users.
759 (build_overlay): New function.
760 * buffer.c (copy_overlays, Fmake_overlay): Use it.
761 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
762 (allocate_misc): Remove prototype.
763 (build_overlay): Add prototype.
764
7652012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
766
767 Swap buffer text indirection counters in Fbuffer_swap_text.
768 * buffer.c (Fbuffer_swap_text): Swap indirections too.
769 This avoids crash reported by Christoph Scholtes at
770 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
771
9d7fa573
JD
7722012-07-22 Jan Djärv <jan.h.d@swipnet.se>
773
774 * nsmenu.m (Popdown_data): New struct.
775 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
776 free Popdown_data.
777 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
778 (initWithContentRect): Make imgView and contentView non-static
779 and autorelease them. Also autorelease img and matrix (Bug#12005).
780 (dealloc): Remove (Bug#12005).
781
0dd6d66d
DA
7822012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
783
784 Adjust consing_since_gc when objects are explicitly freed.
785 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
786 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
787 (free_cons, free_misc): Subtract object size from consing_since_gc.
788
d36d71df
DA
7892012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
790
791 Simplify and cleanup markers positioning code.
792 * marker.c (attach_marker): More useful eassert.
793 (live_buffer, set_marker_internal): New function.
794 (Fset_marker, set_marker_restricted): Use set_marker_internal.
795 (set_marker_both, set_marker_restricted_both): Use live_buffer.
796
fb9ea40f
PE
7972012-07-22 Paul Eggert <eggert@cs.ucla.edu>
798
799 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
800 as it's limited by the amount of memory, not by INT_MAX.
801
2d5c5f7d
EZ
8022012-07-21 Eli Zaretskii <eliz@gnu.org>
803
07fb592e
EZ
804 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
805 in special-event-map. See the discussion at
806 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
807 for the reasons.
808
37a9eac8 809 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
810 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
811 Fabrice Popineau <fabrice.popineau@supelec.fr>.
812
c4328746
JD
8132012-07-21 Jan Djärv <jan.h.d@swipnet.se>
814
815 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 816 (conversationIdentifier): Return value is NSInteger.
784051c4 817 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 818
6e5d1c12
CY
8192012-07-21 Chong Yidong <cyd@gnu.org>
820
821 * window.c (decode_any_window): Signal an error if the window is
822 on a dead frame (Bug#11984).
823
9928463d
DA
8242012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
825
826 Add indirection counting to speed up Fkill_buffer.
827 * buffer.h (struct buffer): New member.
828 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
829 (Fmake_indirect_buffer): Set indirection counter to -1, increment
830 base buffer indirection counter.
831 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
832 (Fkill_buffer): Adjust indirection counters as needed, don't walk
833 through buffer list if indirection counter is 0.
834
f8643a6b
DA
8352012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
836
837 Extend the value returned by Fgarbage_collect with heap statistics.
838 * alloc.c (Qheap): New symbol.
839 (syms_of_alloc): DEFSYM it.
840 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
841 (Fmemory_free): Remove.
842 (syms_of_alloc): Don't defsubr it.
843 * buffer.c (Fcompact_buffer): Remove.
844 (syms_of_buffer): Don't defsubr it.
845
dac616ff
DA
8462012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
847
848 Make maybe_gc inline.
849 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
850 * lisp.h (consing_since_gc, gc_relative_threshold)
851 (memory_full_cons_threshold): Revert declaration.
852 (maybe_gc): Remove prototype, define as inline.
853 * alloc.c: Remove old commented-out code.
854 (consing_since_gc, gc_relative_threshold)
855 (memory_full_cons_threshold): Revert to global.
856 (maybe_gc): Remove.
857
d7ea76b4
DA
8582012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
859
860 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
861 * lisp.h (build_unibyte_string): New function.
862 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
863 * sysdep.c, w32fns.c, xfns.c: Use it.
864 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
865 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
866 Adjust users accordingly.
867 * font.h (font_open_by_name): Adjust prototype.
868
765e61e3
DA
8692012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
870
871 Cleanup calls to Fgarbage_collect.
872 * lisp.h (maybe_gc): New prototype.
873 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
874 Remove declarations.
875 * alloc.c (maybe_gc): New function.
876 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
877 Make them static.
878 * bytecode.c (MAYBE_GC): Use maybe_gc.
879 * eval.c (eval_sub, Ffuncall): Likewise.
880 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
881 to avoid dependency from auto-save feature.
882
52b852c7
PE
8832012-07-19 Paul Eggert <eggert@cs.ucla.edu>
884
885 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
886 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
887 'for_each_per_buffer_object_at'.
888 All uses changed. It's better to use upper-case for macros that
889 cannot be implemented as functions, to give the reader a clue
890 that they're special.
891
5db81e33
SM
8922012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
893
894 * alloc.c (Fgarbage_collect): Tweak docstring.
895
5b835e1d
DA
8962012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
897
898 Tweak the value returned from Fgarbage_collect again.
899 * alloc.c (Fgarbage_collect): New return value, as confirmed in
900 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
901 Adjust documentation.
902 (total_vector_bytes): Rename to total_vector_slots, adjust
903 accounting.
904 (total_free_vector_bytes): Rename to total_free_vector_slots,
905 adjust accounting.
906 (Qstring_bytes, Qvector_slots): New symbols.
907 (syms_of_alloc): DEFSYM them.
908
9cd47b72
DA
9092012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
910
911 Buffer compaction primitive which may be used from Lisp.
912 * buffer.c (compact_buffer, Fcompact_buffer): New function.
913 (syms_of_buffer): Register Fcompact_buffer.
914 * alloc.c (Fgarbage_collect): Use compact_buffer.
915 * buffer.h (compact_buffer): New prototype.
916 (struct buffer_text): New member.
917
d17337e5
DA
9182012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
919
920 New macro to iterate over all buffers, miscellaneous cleanups.
921 * lisp.h (all_buffers): Remove declaration.
922 * buffer.h (all_buffers): Add declaration, with comment.
923 (for_each_buffer): New macro.
924 * alloc.c (Fgarbage_collect, mark_object): Use it.
925 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
926 (init_buffer): Likewise.
927 * data.c (Fset_default): Likewise.
928 * coding.c (code_conversion_restore): Remove redundant check
929 for dead buffer.
930 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
931
60cfd278
AS
9322012-07-18 Andreas Schwab <schwab@linux-m68k.org>
933
934 Fix bug that created negative-length intervals.
935 * intervals.c (merge_interval_right, merge_interval_left):
936 Do not zero out this interval if it is absorbed by its children,
937 as this interval's total length doesn't change in that case. See
938 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
939
d06714cb
PE
9402012-07-18 Paul Eggert <eggert@cs.ucla.edu>
941
83713154
PE
942 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
943 when invoking (make-bool-vector N t) and N is a positive
944 multiple of 8 -- the last 8 bits were mistakenly cleared.
945
d06714cb
PE
946 Remove some struct layout assumptions in bool vectors.
947 * alloc.c (bool_header_size): New constant.
948 (header_size, word_size): Move earlier, as they're now used earlier.
949 Use 'word_size' in a few more places, where it's appropriate.
950 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
951 padding before the data member of a bool vector.
952 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
953 than doing the check by hand with an abort ().
954
464d5a5e
SM
9552012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
956
5fbc0409
SM
957 * eval.c (Fdefvar): Don't check constants since we only set the var if
958 it's not yet defined anyway (bug#11904).
959
464d5a5e
SM
960 * lisp.h (last_undo_boundary): Declare new var.
961 * keyboard.c (command_loop_1): Set it.
962 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
963 were auto-added by the command loop (bug#11774).
964
8dc2e44a
AS
9652012-07-18 Andreas Schwab <schwab@linux-m68k.org>
966
967 * w32font.c (Qsymbol): Remove local definition.
968 (syms_of_w32font): Don't DEFSYM it.
969
169925ec
DA
9702012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
971
972 Fix sweep_vectors to handle large bool vectors correctly.
973 * alloc.c (sweep_vectors): Account total_vector_bytes for
974 bool vectors larger than VBLOCK_BYTES_MAX.
975
5fbfb018
CY
9762012-07-18 Chong Yidong <cyd@gnu.org>
977
978 * frame.c (x_set_frame_parameters): Revert bogus change introduced
979 in 2012-05-25 commit by Paul Eggert (Bug#11738).
980
3ab6e069
DA
9812012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
982
983 Return more descriptive data from Fgarbage_collect.
984 Suggested by Stefan Monnier in
985 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
986 * alloc.c (bounded_number): New function.
987 (total_buffers, total_vectors): New variable.
988 (total_string_size): Rename to total_string_bytes, adjust users.
989 (total_vector_size): Rename to total_vector_bytes, adjust users.
990 (sweep_vectors): Account total_vectors and total_vector_bytes.
991 (Fgarbage_collect): New return value. Adjust documentation.
992 (gc_sweep): Account total_buffers.
993 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
994 (VECTOR_SIZE): Remove.
995 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
996 (Qinterval, Qmisc): New symbols.
997 (syms_of_data): Initialize them.
998 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
999 (Qcons, Qbuffer): New declarations.
1000
6d02fe5b
PE
10012012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1002
1003 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1004 Round up, not down. Improve doc.
1005
b7ffe040
DA
10062012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1007
1008 Restore old code in allocate_string_data to avoid Faset breakage.
1009 Reported by Julien Danjou <julien@danjou.info> in
1010 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1011 * alloc.c (allocate_string_data): Restore old code with minor
1012 adjustments, fix comment to explain this subtle issue.
1013
4dc7c8d5
SM
10142012-07-17 Eli Zaretskii <eliz@gnu.org>
1015
1016 Remove FILE_SYSTEM_CASE.
1017 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1018
1019 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1020 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1021 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1022 call-process-region passes it through expand-file-name.
1023
1024 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1025
10262012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1027
1028 Fix crash when creating indirect buffer (Bug#11917)
1029 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1030 Don't handle unbound variables specially if non-zero.
1031 (Fbuffer_local_variables): Pass zero.
1032 (clone_per_buffer_values): Pass non-zero.
1033
10342012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1035
1036 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1037 to make the loop interruptible.
1038
10392012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1040
1041 * gnutls.c (emacs_gnutls_handshake): Only retry if
1042 GNUTLS_E_INTERRUPTED.
1043
cce7fefc
DA
10442012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1045
1046 Cleanup and convert miscellaneous checks to eassert.
1047 * alloc.c (mark_interval): Fix comment, partially rephrase
1048 old comment from intervals.h (see below).
1049 * intervals.c (find_interval, adjust_intervals_for_insertion)
1050 (delete_interval, adjust_intervals_for_deletion)
1051 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1052 Convert to eassert.
1053 (adjust_intervals_for_insertion, make_new_interval):
1054 Remove obsolete and unused code.
1055 * intervals.h (struct interval): Remove obsolete comment.
1056 * textprotp.c (erase_properties): Remove unused code.
1057 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1058 (Fremove_list_of_text_properties): Convert to eassert.
1059
9ea10cc3
CY
10602012-07-17 Chong Yidong <cyd@gnu.org>
1061
1062 * editfns.c (Finsert_char): Doc fix.
1063
3900d5de
DA
10642012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1065
1066 Fix previous change to make Fmemory_free always accurate.
1067 * alloc.c (make_interval): Update total_free_intervals.
1068 (make_float): Likewise for total_free_floats.
1069 (free_cons, Fcons): Likewise for total_free_conses.
1070 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1071 Likewise for total_free_vector_bytes.
1072 (Fmake_symbol): Likewise for total_free_symbols.
1073 (bytes_free): Remove.
1074
7098646f
DA
10752012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1076
1077 Simple free memory accounting feature.
1078 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1079 (sweep_vectors): Accumulate size of free vectors.
1080 (Fgarbage_collect): Setup bytes_free.
1081 (Fmemory_free): New function.
1082 (syms_of_alloc): Register it.
1083
22657b40
DA
10842012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1085
1086 Cleanup overlays checking.
1087 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1088 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1089 eassert and OVERLAYP.
1090 (sort_overlays): Change to use OVERLAYP.
1091
ddfc8813
RK
10922012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1093
1094 * editfns.c (Finsert_char): Make it interactive, and make the
1095 second arg optional. Copy interactive spec and docstring from
1096 ucs-insert.
1097
7c26cf3c
PE
10982012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1099
1100 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1101 Unlike the other wrapped functions, fabs has an unspecified
1102 effect on errno.
1103
5d127af9
JD
11042012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1105
1106 * nsterm.m (keyDown): Interpret flags without left/right bits
1107 as the left key (Bug#11670).
1108
6a0dd1d7
DA
11092012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1110
1111 Remove empty and useless init functions.
1112 * lisp.h (init_character_once, init_fns, init_image)
1113 (init_filelock, init_sound): Remove prototype.
1114 * character.c (init_character_once): Remove.
1115 * filelock.c (init_filelock): Likewise.
1116 * fns.c (init_fns): Likewise.
1117 * image.c (init_image): Likewise.
1118 * sound.c (init_sound): Likewise.
1119 * emacs.c (main): Adjust accordingly.
1120
7a6136fd
DA
11212012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1122
1123 * gtkutil.h: Tiny cleanups.
1124 (use_old_gtk_file_dialog): Remove useless declaration.
1125 (xg_uses_old_file_dialog): Add suggested const attribute.
1126
ce811ad9
EZ
11272012-07-15 Eli Zaretskii <eliz@gnu.org>
1128
1129 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1130 (bidi_paragraph_init): Use it to limit search forward for a strong
1131 directional character in abnormally large paragraphs full of
1132 neutral or weak characters. (Bug#11943)
1133
c9adfeaa
SF
11342012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1135
1136 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1137 the toolbar (Bug#9451).
1138 (xg_make_tool_item): Give the widget event box a transparent
1139 background.
1140
fff62aa9
DA
11412012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1142
1143 Cleanup basic allocation variables and functions.
1144 * alloc.c (ignore_warnings, init_intervals, init_float)
1145 (init_cons, init_symbol, init_marker): Remove.
1146 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1147 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1148 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1149 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1150 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1151 (staticidx, init_alloc_once, init_strings, free_ablock):
1152 Remove redundant initialization.
1153 * fns.c (init_weak_hash_tables): Remove.
1154 * lisp.h (init_weak_hash_tables): Remove prototype.
1155
9730daca
DA
11562012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1157
1158 Use zero_vector where appropriate.
1159 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1160 accordingly.
1161 * lisp.h (zero_vector): New declaration.
1162 * font.c (null_vector): Remove.
1163 (syms_of_font): Remove initialization and staticpro.
1164 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1165 * keymap.c (Faccessible_keymaps): Likewise.
1166
2e2d2a13
LL
11672012-07-15 Leo Liu <sdl.web@gmail.com>
1168
1169 * fringe.c: Fix typo in comments.
1170
cd276f6e
LL
11712012-07-14 Leo Liu <sdl.web@gmail.com>
1172
1173 * fringe.c: Add a new bitmap exclamation-mark.
1174
5a1131d9
EZ
11752012-07-14 Eli Zaretskii <eliz@gnu.org>
1176
1177 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1178
1179 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1180 (HAVE_MENUS): Don't define, defined by editing config.in with
1181 msdos/sed2v2.inp.
1182 (GMALLOC_INHIBIT_VALLOC): Don't define.
1183 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1184
22e983b7
JB
11852012-07-14 Juanma Barranquero <lekktu@gmail.com>
1186
1187 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1188
5b3f250f
GM
11892012-07-14 Glenn Morris <rgm@gnu.org>
1190
1191 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1192 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1193 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1194
33d63ff4
GM
11952012-07-13 Glenn Morris <rgm@gnu.org>
1196
5b633342
GM
1197 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1198
33d63ff4
GM
1199 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1200 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1201
b55b9f85
JD
12022012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1203
0dc8cf50
JD
1204 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1205 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1206 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1207 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1208 where appropriate.
1209 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1210 as boolean expression.
1211 (x_set_window_size): Remove unused variable toolbar.
1212 (ns_get_color_default, ns_mod_to_lisp): Remove.
1213 (ns_mouse_position): Remove unused variables xchar and ychar.
1214 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1215 (ns_set_vertical_scroll_bar): Remove unused variable count.
1216 (ns_delete_terminal): Remove unused variable i.
1217 (ns_term_init): Remove unused variables r, g and b.
1218 (mouseDown): Remove unused variable window.
1219 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1220 (initFrameFromEmacs): Remove unused variable vbextra.
1221 (mouseEntered): Remove unused variables p and dpyinfo.
1222 (mouseExited): Remove unused variables p and r.
1223 (ns_define_frame_cursor, ns_clear_frame_area)
1224 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1225 (menuDown): Assign [sender tag] to variable and cast the variable.
1226
1227 * nsterm.h (menuDown): Add id as type to argument sender.
1228 (ns_display_info_for_name): Add Lisp_Object argument.
1229 (ns_term_init): Add Lisp_Object argument.
1230 (ns_map_event_to_object): Add void argument.
1231 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1232 prototype with arguments and only declare if __OBJC__.
1233 (nxatoms_of_nsselect): Add void argument.
1234 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1235 (ns_alloc_autorelease_pool): Add void argument.
1236 (ns_release_autorelease_pool): Add void* argument.
1237 (ns_get_defaults_value): Add const char* argument.
1238
1239 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1240 (initFromContents): Use SSDATA where appropriate.
1241 (ns_update_menubar): Add braces to ambigous if-else.
1242 (initWithTitle): Put () around assignment in if statement.
1243 (ns_menu_show): Remove unused variables window and keymap.
1244 (update_frame_tool_bar): Remove unused variable selected_p.
1245 (initWithContentRect): Remove unused variable this_cmd_name.
1246
1247 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1248 appropriate.
1249 (setXBMColor): Remove unused variable len.
1250 (setPixmapData): Put () around assignment in loop statement.
1251
1252 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1253 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1254 where appropriate.
1255 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1256 around assignment in loop statement.
1257 (nsfont_open): Remove unused variable i.
1258 (nsfont_open): Remove unused variable len.
1259 (nsfont_draw): Remove unused variable cs.
1260
1261 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1262 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1263 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1264 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1265 (Fns_font_name, Fns_perform_service)
1266 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1267 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1268 (ns_set_name): Remove unused variable view.
1269 (x_set_menu_bar_lines): Remove unused variable olines.
1270 (x_set_tool_bar_lines): Remove unused variable root_window.
1271 (Fns_list_colors): Put () around assignment in while statement.
1272 (Fns_perform_service): Remove unused variable len.
1273 (Fns_display_usable_bounds): Remove unused variable top.
1274 (syms_of_nsfns): Remove unused variable i.
1275
b55b9f85
JD
1276 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1277 memcpy (Bug#11907).
1278
ed9265fc 12792012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1280
1281 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1282 and free it with DestroyExceptionInfo (Bug#11558).
1283
ef099b57
JB
12842012-07-13 Juanma Barranquero <lekktu@gmail.com>
1285
1286 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1287 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1288 Set here, not in nt/config.nt.
1289
ea814a5d
EZ
12902012-07-13 Eli Zaretskii <eliz@gnu.org>
1291
1292 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1293 cursor overflow into the last glyph on display line when the right
1294 fringe is off. (Bug#11832)
1295
1a952767
PE
12962012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1297
1298 * xdisp.c (produce_special_glyphs): Now static.
1299 * dispextern.h (produce_special_glyphs): Remove decl.
1300
983188fd
GM
13012012-07-13 Glenn Morris <rgm@gnu.org>
1302
8d7c7eed 1303 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1304 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1305
983188fd
GM
1306 * s/usg5-4-common.h (USG, USG5):
1307 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1308 * s/sol2-6.h (SOLARIS2):
1309 * s/irix6-5.h (IRIX6_5):
1310 * s/hpux10-20.h (USG, USG5, HPUX):
1311 * s/gnu-linux.h (USG, GNU_LINUX):
1312 * s/freebsd.h (BSD_SYSTEM):
1313 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1314 * s/cygwin.h (CYGWIN):
1315 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1316 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1317
d1e68667 13182012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1319
1320 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1321
6de0e799
GM
13222012-07-13 Glenn Morris <rgm@gnu.org>
1323
739ae010
GM
1324 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1325
dbee5793
GM
1326 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1327
6de0e799
GM
1328 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1329 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1330
b82da769
GM
13312012-07-12 Glenn Morris <rgm@gnu.org>
1332
4fae5a7a 1333 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1334
1335 * process.c (init_process_emacs): Rename from init_process.
1336 The old name is also the name of a Mach system call.
1337 * lisp.h, emacs.c: Update for this name change.
1338 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1339 longer needed.
1340
5a979817
EZ
13412012-07-12 Eli Zaretskii <eliz@gnu.org>
1342
1343 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1344 memmove call that removes glyphs covered by the left truncation
1345 glyph. Improve commentary.
1346 (display_line): Fix display of continuation glyphs on GUI frames
1347 when the right fringe is turned off and variable-size fonts are
1348 used in the window. Move the code that appends a stretch glyph to
1349 produce_special_glyphs, so that it could be used for truncation
1350 and continuation glyphs alike.
1351 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1352 glyph of a suitably computed width, to align the special glyphs at
1353 the window margin. Code moved from display_line. (Bug#11832)
1354
3e91a053
GM
13552012-07-12 Glenn Morris <rgm@gnu.org>
1356
ba9e4b84
GM
1357 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1358
1359 * s/gnu-linux.h, s/hpux10-20.h:
1360 Do not unconditionally define HAVE_XRMSETDATABASE.
1361
3e91a053
GM
1362 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1363
b300b1f4
PE
13642012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1365
1366 Fix typos that broke OS X build.
1367 Reported by Randal L. Schwartz in
1368 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1369 * nsterm.m (ns_timeout): Add missing local decl.
1370 (ns_get_color): snprintf -> sprintf, to fix typo.
1371
6e777848
GM
13722012-07-12 Glenn Morris <rgm@gnu.org>
1373
3f922c37
GM
1374 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1375 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1376 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1377 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1378
0ab7b23a
GM
1379 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1380 Move PTY_OPEN to configure.
1381
6e777848
GM
1382 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1383 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1384 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1385
4a7edc24
DA
13862012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1387
1388 Use empty_unibyte_string where applicable.
1389 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1390 * lread.c (read1): Likewise.
1391 * xsettings.c (syms_of_xsettings): Likewise.
1392
308aab79
GM
13932012-07-12 Glenn Morris <rgm@gnu.org>
1394
42bd1719
GM
1395 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1396 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1397 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1398 * s/hpux10-20.h (RUN_TIME_REMAP):
1399 * s/bsd-common.h (TABDLY): Move to configure.
1400
1401 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1402
1403 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1404
ea0bbd17 1405 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1406 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1407
1408 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1409
308aab79
GM
1410 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1411 * s/template.h: Move NARROWPROTO to configure.
1412
ee1cf5cf
GM
14132012-07-11 Glenn Morris <rgm@gnu.org>
1414
30fe9bf4
GM
1415 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1416 unused since 2011-01-17 change to systty.h.
1417
ee1cf5cf
GM
1418 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1419 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1420 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1421
63e47e07
PE
14222012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1423
1424 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1425
c43fb4c3
GM
14262012-07-11 Glenn Morris <rgm@gnu.org>
1427
1428 * s/darwin.h, s/gnu-linux.h, s/template.h:
1429 Move INTERRUPT_INPUT to configure.
1430
e8df9267
DA
14312012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1432
1433 Minor adjustments to interning code.
1434 * lisp.h (intern, intern_c_string): Redefine as static inline
1435 wrappers for intern_1 and intern_c_string_1, respectively.
1436 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1437 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1438 Vobarray checking.
e8df9267
DA
1439 * font.c (font_intern_prop): Likewise. Adjust comment.
1440 * w32font.c (intern_font_name): Likewise.
1441
34348bd4
AS
14422012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1443
d96a1e0c
AS
1444 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1445
34348bd4
AS
1446 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1447 of Fcar/Fcdr if possible.
1448 * font.c (check_otf_features): Likewise.
1449 * fontset.c (Fnew_fontset): Likewise.
1450 * gnutls.c (Fgnutls_boot): Likewise.
1451 * minibuf.c (read_minibuf): Likewise.
1452 * msdos.c (IT_set_frame_parameters): Likewise.
1453 * xmenu.c (Fx_popup_dialog): Likewise.
1454 * w32menu.c (Fx_popup_dialog): Likewise.
1455
c8add24e
GM
14562012-07-11 Glenn Morris <rgm@gnu.org>
1457
4b575b3c
GM
1458 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1459 since nothing has defined it on these platforms.
1460
09f4e3b0
GM
1461 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1462 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1463
172bedef
GM
1464 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1465 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1466 Move CLASH_DETECTION to configure.
1467
249685df
GM
1468 * s/gnu.h: Remove file, which is now empty.
1469
c8add24e
GM
1470 * s/gnu.h, s/gnu-linux.h:
1471 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1472
b41253a3
JW
14732012-07-11 John Wiegley <johnw@newartisans.com>
1474
1475 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1476 function attribute, so we only use it if it exists in the
1477 compiler.
1478
d923b542
DA
14792012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1480
1481 Avoid call to strlen in fast_c_string_match_ignore_case.
1482 * search.c (fast_c_string_match_ignore_case): Change to use
1483 length argument. Adjust users accordingly.
1484 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1485
5ebbef1d
PE
14862012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1487
bb352260
PE
1488 Assume mkdir, rmdir.
1489 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1490 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1491
57054ddd
PE
1492 Assume rename.
1493 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1494
b747d3f7
PE
1495 Assume perror.
1496 * s/hpux10-20.h (HAVE_PERROR): Remove.
1497 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1498 Remove dummy definition, as this problem was obsolete long ago.
1499
5ebbef1d
PE
1500 Assume strerror.
1501 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1502
984e7f30
DA
15032012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1504
1505 Avoid calls to strlen in font processing functions.
1506 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1507 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1508 users accordingly.
d923b542
DA
1509 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1510 Adjust prototypes.
1511 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1512 Change to return ptrdiff_t.
984e7f30
DA
1513 (xfont_list_pattern, xfont_match): Use length returned by
1514 xfont_decode_coding_xlfd.
1515 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1516
20e94fdd
GM
15172012-07-11 Glenn Morris <rgm@gnu.org>
1518
9d596af3
GM
1519 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1520 Move DONT_REOPEN_PTY to configure.
1521
20e94fdd
GM
1522 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1523 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1524
e99a530f
PE
15252012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1526
22ffb973
PE
1527 Remove "#define unix" that is no longer needed (Bug#11905).
1528 * s/aix4-2.h (unix): Remove; no longer needed.
1529
e9a9ae03
PE
1530 EMACS_TIME simplification (Bug#11875).
1531 This replaces macros (which typically do not work in GDB)
1532 with functions, typedefs and enums, making the code easier to debug.
1533 The functional style also makes code easier to read and maintain.
1534 * systime.h: Include <sys/time.h> on all hosts, not just if
1535 WINDOWSNT, since 'struct timeval' is needed in general.
1536 (EMACS_TIME): Now a typedef, not a macro.
1537 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1538 not macros.
1539 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1540 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1541 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1542 (EMACS_TIME_LE): Now functions, not macros.
1543 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1544 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1545 which are not functions. All uses rewritten to use:
1546 (make_emacs_time): New function.
1547 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1548 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1549 not functions. All uses rewritten to use the following, respectively:
1550 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1551 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1552 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1553 * fileio.c (Fcopy_file):
1554 * xterm.c (XTflash): Get the current time closer to when it's used.
1555 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1556
ffacb126
PE
1557 * bytecode.c (targets): Suppress -Woverride-init warnings.
1558
e99a530f
PE
1559 Simplify by avoiding confusing use of strncpy etc.
1560 * doc.c (Fsnarf_documentation):
1561 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1562 * frame.c (Fmake_terminal_frame):
1563 * gtkutil.c (get_utf8_string):
1564 * lread.c (openp):
1565 * nsmenu.m (ns_update_menubar):
1566 * regex.c (regerror):
1567 Prefer memcpy to strncpy and strncat when either will do.
1568 * fileio.c (Fsubstitute_in_file_name):
1569 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1570 (menu_separator_name_p):
1571 * nsmenu.m (ns_update_menubar):
1572 Prefer memcmp to strncmp when either will do.
1573 * nsterm.m: Include <ftoastr.h>.
1574 (ns_get_color):
1575 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1576 Prefer snprintf to strncpy.
1577 * nsterm.m (ns_term_init):
1578 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1579 * nsterm.m (ns_term_init):
1580 Avoid the need for strncpy, by using build_string or
1581 make_unibyte_string directly. Use dtoastr, not snprintf.
1582 * process.c (Fmake_network_process): Diagnose service names that
1583 are too long, rather than silently truncating them or creating
1584 non-null-terminated names.
1585 (Fnetwork_interface_info): Likewise, for interface names.
1586 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1587 Prefer sprintf to strncat.
1588 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1589 Prefer vsnprintf to vsprintf + strncpy.
1590
c59592b3
GM
15912012-07-10 Glenn Morris <rgm@gnu.org>
1592
1593 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1594 Clarify fallback case.
1595
7d7bbefd
DA
15962012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1597
1598 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1599 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1600 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1601 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1602 where argument type is known to be a Lisp_Cons.
1603
3a4c8000
TT
16042012-07-10 Tom Tromey <tromey@redhat.com>
1605
1606 * bytecode.c (BYTE_CODE_THREADED): New macro.
1607 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1608 (enum byte_code_op): New type.
1609 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1610 (exec_byte_code): Use them. Use token threading when applicable.
1611
2a0213a6
DA
16122012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1613
1614 Optimize pure C strings initialization.
1615 * lisp.h (make_pure_string): Fix prototype.
1616 (build_pure_c_string): New function, defined as static inline. This
1617 provides a better opportunity to optimize away calls to strlen when
1618 the function is called with compile-time constant argument.
1619 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1620 argument, adjust users accordingly. Use build_pure_c_string where
1621 appropriate.
1622 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1623 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1624 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1625
cb1caeaf
DA
16262012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1627
1628 Avoid calls to strlen in miscellaneous functions.
1629 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1630 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1631 * lread.c (openp): Likewise.
1632
c293e30c
DA
16332012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1634
1635 Avoid calls to strlen in path processing functions.
1636 * fileio.c (file_name_as_directory): Add comment. Change to add
1637 srclen argument and return the length of result. Adjust users
1638 accordingly.
1639 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1640 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1641 users accordingly.
1642 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1643
9e059e3f
GM
16442012-07-10 Glenn Morris <rgm@gnu.org>
1645
d02eb359
GM
1646 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1647 Move PENDING_OUTPUT_COUNT definition to configure.
1648
882cf227
GM
1649 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1650 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1651 * s/gnu.h (DATA_START): Move definitions to configure.
1652
af6e839f
GM
1653 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1654 We include usg5-4-common.h, which defines them both.
1655
40289a12
GM
1656 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1657 O_RDONLY already includes it).
1658
9e059e3f
GM
1659 Stop ns builds setting the EMACSLOADPATH environment variable.
1660 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1661 Now it does not set EMACSLOADPATH, just returns the load-path string.
1662 * nsterm.h: Update accordingly.
1663 * lread.c [HAVE_NS]: Include nsterm.h.
1664 (init_lread) [HAVE_NS]: Use ns_load_path.
1665 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1666
7c4e8ec0
GM
16672012-07-09 Glenn Morris <rgm@gnu.org>
1668
d4f600ff
GM
1669 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1670 since the included bsd-common.h does so.
1671
cbb31951
GM
1672 Stop ns builds setting the EMACSPATH environment variable.
1673 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1674 (ns_init_paths): Do not set EMACSPATH.
1675 * nsterm.h (ns_exec_path): Add it.
1676 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1677 Use ns_exec_path.
1678
7c4e8ec0
GM
1679 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1680
26bccfae
PE
16812012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1682
a0bee46f
PE
1683 * process.c (wait_reading_process_output): 'waitchannels' was unset
1684 when read_kbd || !NILP (wait_for_cell); fix this.
1685
5994c183
PE
1686 Add GCC-style 'const' attribute to functions that can use it.
1687 * character.h (char_resolve_modifier_mask):
1688 * keyboard.h (make_ctrl_char):
1689 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1690 (init_character_once, next_almost_prime, init_fns, init_image)
1691 (flush_pending_output, init_sound):
1692 * mem-limits.h (start_of_data):
1693 * menu.h (finish_menu_items):
1694 Add ATTRIBUTE_CONST.
1695 * emacs.c (DEFINE_DUMMY_FUNCTION):
1696 Declare the dummy function with ATTRIBUTE_CONST.
1697 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1698 Add decls with ATTRIBUTE_CONST.
1699
26bccfae
PE
1700 Minor improvements to make_formatted_string.
1701 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1702 where int is good enough, as vsprintf returns an int.
1703 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1704
a8290ec3
DA
17052012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1706
1707 Use make_formatted_string to avoid double length calculation.
1708 * lisp.h (make_formatted_string): New prototype.
1709 * alloc.c (make_formatted_string): New function.
1710 * buffer.c (Fgenerate_new_buffer_name): Use it.
1711 * dbus.c (syms_of_dbusbind): Likewise.
1712 * editfns.c (Fcurrent_time_zone): Likewise.
1713 * filelock.c (get_boot_time): Likewise.
1714 * frame.c (make_terminal_frame, set_term_frame_name)
1715 (x_report_frame_params): Likewise.
1716 * image.c (gs_load): Likewise.
1717 * minibuf.c (get_minibuffer): Likewise.
1718 * msdos.c (dos_set_window_size): Likewise.
1719 * process.c (make_process): Likewise.
1720 * xdisp.c (ensure_echo_area_buffers): Likewise.
1721 * xsettings.c (apply_xft_settings): Likewise.
1722
d01ba2f1
GM
17232012-07-09 Glenn Morris <rgm@gnu.org>
1724
1725 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1726 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1727 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1728 * nsterm.h (ns_etc_directory): Add it.
1729 * callproc.c [HAVE_NS]: Include nsterm.h.
1730 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1731
f1f924b6
DA
17322012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1733
1734 Move marker debugging code under MARKER_DEBUG.
1735 * marker.c (MARKER_DEBUG): Move marker debugging code under
1736 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1737 for bootstrap with --enable-checking (~3x slowdown reported
1738 by Juanma Barranquero <lekktu@gmail.com>).
1739 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1740
ab531b66
PE
17412012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1742
1743 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1744 See <http://bugs.gnu.org/11825#29>.
1745
c4b3bc8a
EZ
17462012-07-08 Eli Zaretskii <eliz@gnu.org>
1747
1748 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1749 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1750 (display_line): Add commentary about displaying truncation glyphs
1751 on GUI frames.
1752 (produce_special_glyphs): Move here from term.c.
1753
1754 * term.c (produce_special_glyphs): Move to xdisp.c.
1755
1756 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1757 section.
c4b3bc8a 1758
b676b881
AS
17592012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1760
f17c5273
AS
1761 * xdisp.c (display_line): Avoid warning about implicit declaration
1762 of FRAME_FONT.
1763
298819b9
AS
1764 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1765
b676b881
AS
1766 * lisp.h: Remove empty conditional.
1767
6045c4fd
PE
17682012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1769
b3350bf9
PE
1770 * lread.c (load_path_check): Now static.
1771
6045c4fd
PE
1772 Fix some minor --with-ns problems found by static checking.
1773 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1774 (x_set_font) [!HAVE_X_WINDOWS]:
1775 * image.c (xpm_load_image) [HAVE_NS]:
1776 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1777 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1778 Remove unused local.
1779 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1780 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1781 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1782 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1783 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1784 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1785 Fix pointer signedness problem.
1786 * xfaces.c (FRAME_X_FONT_TABLE):
1787 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1788
929e7845
GM
17892012-07-07 Glenn Morris <rgm@gnu.org>
1790
1791 * lread.c (load_path_check): New function, split from init_lread.
1792 (init_lread): Reorganize. Motivation:
1793 If EMACSLOADPATH is set, check/warn about that rather than the
1794 defaults, which we are not going to use. Hence we can remove
1795 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1796 Don't warn if site-lisp directories are missing.
1797 If not installed, start from a blank load-path, since
1798 PATH_LOADSEARCH refers to the eventual installation directories.
1799
58dd0aa4
EZ
18002012-07-07 Eli Zaretskii <eliz@gnu.org>
1801
1802 Support truncation and continuation glyphs on GUI frames, when
1803 fringes are disabled. (Bug#11832)
1804 * xdisp.c (init_iterator): Get dimensions of truncation and
1805 continuation glyphs even if on GUI frames. Adjust
1806 it->last_visible_x on GUI frames when the left or right fringes,
1807 or both, are absent.
1808 (start_display, move_it_in_display_line_to): Handle the case of a
1809 GUI frame without a fringe to display continuation or truncation
1810 glyphs.
1811 (insert_left_trunc_glyphs): Support GUI frames: make sure
1812 truncation glyphs overwrite enough glyphs from the current line to
1813 have sufficient space in pixels.
1814 (display_line): Support truncation and continuation glyphs on GUI
1815 frames. If some spare pixels are left on the line after inserting
1816 the truncation glyphs, fill that space with a stretch glyph of a
1817 suitably computed width.
1818
1819 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1820 produce_glyphs, to support GUI sessions.
1821
31571fd7
PE
18222012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1823
5a16b9bc
PE
1824 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1825
f3047c75
PE
1826 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1827
31571fd7
PE
1828 Do not require float-time's arg to fit in time_t (Bug#11825).
1829 This works better on hosts where time_t is unsigned, and where
1830 float-time is applied to the (negative) difference between two times.
1831 * editfns.c (decode_time_components): Last arg is now double *,
1832 not int *, and means to store all the result as a double, without
1833 worrying about whether the seconds part fits in time_t.
1834 All callers changed.
1835 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1836 All callers changed.
1837 (Ffloat_time): Do not fail merely because the specified time falls
1838 outside of time_t range.
1839
4516fbef
GM
18402012-07-07 Glenn Morris <rgm@gnu.org>
1841
1842 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1843 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1844 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1845
07adc2c6
JB
18462012-07-07 Juanma Barranquero <lekktu@gmail.com>
1847
1848 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1849 Update dependencies.
1850
1851 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1852
fd573f31
PE
18532012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1854
fee5959d
PE
1855 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1856 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1857 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1858 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1859 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1860 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1861
fd573f31
PE
1862 * xfont.c (compare_font_names): Redo to omit the need for casts.
1863
ddadbc0e
AS
18642012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1865
fca8d6b6
AS
1866 * xfns.c (Fx_change_window_property): Doc fix.
1867 * w32fns.c (Fx_change_window_property): Doc fix.
1868
ddadbc0e
AS
1869 * w32fns.c (Fx_window_property): Accept the same arguments as the
1870 X Windows version. Doc fix.
1871 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1872
ed9265fc 18732012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1874 Eli Zaretskii <eliz@gnu.org>
1875
1876 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1877 Windows-specific code from nt/config.nt moved here.
1878 Obsolete settings removed.
1879
216ee680
PE
18802012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1881
1882 * process.c: Avoid unnecessary calls to gettime.
1883 (wait_reading_process_output): Don't get the time of day
1884 when gobbling data immediately and not waiting, as there's no need
1885 for it in that case. This removes a FIXME.
1886
bdd091e4
JD
18872012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1888
1889 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1890 is defined (Bug#11768).
1891
9d44f8ce
DA
18922012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1893
1894 Fix marker debugging code.
1895 * marker.c (byte_char_debug_check): Do not perform the check
1896 if buffer is not multibyte.
090bd7cb
JB
1897 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1898 Call byte_char_debug_check with correct arguments.
9d44f8ce 1899
90fc4786
DA
19002012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1901
1902 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1903 * marker.c (byte_char_debug_check, count_markers):
1904 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1905 (byte_debug_flag): Remove.
1906 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1907 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1908
7b7ae965
DA
19092012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1910
4e57b342
DA
1911 Avoid code repetition in marker-related functions.
1912 * marker.c (attach_marker): New function.
1913 (Fset_marker, set_marker_restricted, set_marker_both)
1914 (set_marker_restricted_both): Use it.
1915 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1916 Consistently rename charno to charpos.
1917 (marker_position): Add eassert.
1918 (marker_byte_position): Convert to eassert.
1919
19202012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1921
1922 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1923 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1924 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1925
657924ff
DA
19262012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1927
1928 Introduce fast path for the widely used marker operation.
1929 * alloc.c (build_marker): New function.
1930 * lisp.h (build_marker): New prototype.
1931 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1932 * composite.c (autocmp_chars): Likewise.
1933 * editfns.c (buildmark): Remove.
1934 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1935 (save_restriction_save): Use build_marker.
1936 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1937 * window.c (save_window_save): Likewise.
1938
041a49a6
DA
19392012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1940
1941 Do not use Fdelete_overlay in delete_all_overlays
1942 to avoid redundant calls to unchain_overlay.
1943 * buffer.c (drop_overlay): New function.
1944 (delete_all_overlays, Fdelete_overlay): Use it.
1945 * minibuf.c (get_minibuffer): Fix comment.
1946
7dca65a4
PE
19472012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1948
1949 Port to OpenBSD 5.1 amd64.
1950 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1951 This is needed for OpenBSD, and should be harmless on all BSD systems.
1952 Also, include <sys/sysctl.h>, as it should be available on all
1953 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1954 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1955 use p_pid member, not kp_proc.pid.
1956
8eb876e2
GM
19572012-07-06 Glenn Morris <rgm@gnu.org>
1958
1959 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1960
38182d90
PE
19612012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1962
1963 More xmalloc and related cleanup.
1964 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1965 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1966 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1967 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1968 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1969 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1970 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1971 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1972 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1973 * xterm.c:
1974 Omit needless casts involving void * pointers and allocation.
1975 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1976 as the former is more robust if P's type is changed.
1977 Prefer xzalloc to xmalloc + memset 0.
1978 Simplify malloc-or-realloc to realloc.
1979 Don't worry about xmalloc returning a null pointer.
1980 Prefer xstrdup to xmalloc + strcpy.
1981 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1982 growing it.
1983 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1984 alloca of a constant.
1985
6dd5a677
EZ
19862012-07-05 Eli Zaretskii <eliz@gnu.org>
1987
1988 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1989 hscroll is larger than the line width. Fixes long and futile
1990 looping inside extend_face_to_end_of_line (on a TTY) producing
1991 glyphs that are not needed and thrown away.
1992
6b312f0f
DA
19932012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1994
1995 * marker.c (set_marker_restricted_both): Simplify by using
1996 clip_to_bounds.
1997
f520ef9b
PE
19982012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1999
2000 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2001
383b7c95
JD
20022012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2003
2004 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2005 not defined (Bug#11768).
2006 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2007 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2008 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2009 followed by gtk_box_set_homogeneous (Bug#11768).
2010 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2011 (update_theme_scrollbar_width, xg_create_scroll_bar):
2012 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2013 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2014 (is_box_type): New function (Bug#11768).
2015 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2016 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2017 with default display (Bug#11768).
2018
d6e7bf45
EZ
20192012-07-05 Eli Zaretskii <eliz@gnu.org>
2020
2021 * xdisp.c (window_hscroll_limited): New function.
2022 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2023 coordinates when window's hscroll is set to insanely large
2024 values. (Bug#11857)
2025
431391ec
JB
20262012-07-05 Juanma Barranquero <lekktu@gmail.com>
2027
2028 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2029 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2030
23f86fce
DA
20312012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2032
2033 Cleanup xmalloc.
2034 * lisp.h (xzalloc): New prototype. Omit needless casts.
2035 * alloc.c (xzalloc): New function. Omit needless casts.
2036 * charset.c: Omit needless casts. Convert all calls to
2037 xmalloc with following memset to xzalloc.
2038 * dispnew.c: Likewise.
2039 * fringe.c: Likewise.
2040 * image.c: Likewise.
2041 * sound.c: Likewise.
2042 * term.c: Likewise.
2043 * w32fns.c: Likewise.
2044 * w32font.c: Likewise.
2045 * w32term.c: Likewise.
2046 * xfaces.c: Likewise.
2047 * xfns.c: Likewise.
2048 * xterm.c: Likewise.
2049 * atimer.c: Omit needless casts.
2050 * buffer.c: Likewise.
2051 * callproc.c: Likewise.
2052 * ccl.c: Likewise.
2053 * coding.c: Likewise.
2054 * composite.c: Likewise.
2055 * doc.c: Likewise.
2056 * doprnt.c: Likewise.
2057 * editfns.c: Likewise.
2058 * emacs.c: Likewise.
2059 * eval.c: Likewise.
2060 * filelock.c: Likewise.
2061 * fns.c: Likewise.
2062 * gtkutil.c: Likewise.
2063 * keyboard.c: Likewise.
2064 * lisp.h: Likewise.
2065 * lread.c: Likewise.
2066 * minibuf.c: Likewise.
2067 * msdos.c: Likewise.
2068 * print.c: Likewise.
2069 * process.c: Likewise.
2070 * region-cache.c: Likewise.
2071 * search.c: Likewise.
2072 * sysdep.c: Likewise.
2073 * termcap.c: Likewise.
2074 * terminal.c: Likewise.
2075 * tparam.c: Likewise.
2076 * w16select.c: Likewise.
2077 * w32.c: Likewise.
2078 * w32reg.c: Likewise.
2079 * w32select.c: Likewise.
2080 * w32uniscribe.c: Likewise.
2081 * widget.c: Likewise.
2082 * xdisp.c: Likewise.
2083 * xmenu.c: Likewise.
2084 * xrdb.c: Likewise.
2085 * xselect.c: Likewise.
2086
0497dc44
PE
20872012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2088
2089 * fileio.c (time_error_value): Check the right error number.
2090 Problem reported by Troels Nielsen in
2091 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2092
356e7178
PE
20932012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2094
4e71fd89
PE
2095 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2096 This should be fixed in a better way; see Eli Zaretskii in
2097 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2098 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2099
f0941253
PE
2100 * fileio.c (time_error_value): Rename from special_mtime.
2101 The old name's problems were noted by Eli Zaretskii in
2102 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2103
065c9eb4
PE
2104 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2105 This variable's comment says Emacs needs at least one GDB-visible
2106 symbol of type enum pvec_type, to work around GDB problems.
2107 The symbol's value doesn't matter.
2108
356e7178
PE
2109 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2110 that causes compilation to fail on pre-C99 compilers.
2111
ed9265fc 21122012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2113
2114 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2115 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2116
3884d954
DA
21172012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2118
d209e2fb 2119 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2120 headers for buffer_defaults and buffer_local_symbols.
2121 Reported by Juanma Barranquero <lekktu@gmail.com>.
2122
ee28be33
SM
21232012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2124
2125 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2126 * lisp.h (enum pvec_type): Use fewer bits.
2127 (PSEUDOVECTOR_SIZE_BITS): New constant.
2128 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2129 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2130 change in pvec_type.
2131 (PSEUDOVECTOR_TYPEP): New macro.
2132 (TYPED_PSEUDOVECTORP): Use it.
2133 * fns.c (internal_equal): Adapt code to extract pvectype.
2134 * emacs.c (gdb_pvec_type): Update type.
2135 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2136 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2137 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2138 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2139 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2140 abusing vector->header.next.nbytes.
2141 (live_vector_p): Use PVEC_TYPE.
2142 (mark_object): Adapt code to extract pvectype. Use switch.
2143
c7f2cd7f
PE
21442012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2145
2146 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2147 Tighten new eassert a bit.
2148
8ce70ed2
DA
21492012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2150
2151 Fix compilation with --enable-gcc-warnings and -O1
2152 optimization level.
2153 * doprnt.c (doprnt): Change type of tem to int, initialize
2154 to avoid compiler warning. Add eassert.
2155 * search.c (simple_search): Initialize match_byte to avoid
2156 compiler warning. Add eassert.
2157
dea7f1e5
PE
21582012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2159
24a212eb
PE
2160 Avoid weird behavior with large horizontal scrolls.
2161 Without this change, for example, large hscroll values would
2162 mess up Emacs's display on Fedora 15 x86, presumably due to
2163 overflows in int calculations in the display code.
2164 Also, if buffers had long lines, Emacs would freeze.
2165 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2166 (set_window_hscroll): New function, containing the old guts of
2167 Fset_window_hscroll. Return the clipped value.
2168 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2169 This avoids the need to check against PTRDIFF_MAX.
2170
dea7f1e5
PE
2171 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2172
76046526
DA
21732012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2174
2175 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2176
39adff0d
PE
21772012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2178
63807d47
PE
2179 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2180 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2181 since GCC 4.4.6 issues a bogus warning for them.
2182
39adff0d
PE
2183 Fix bugs in file timestamp newness comparisons.
2184 * fileio.c (Ffile_newer_than_file_p):
2185 * lread.c (Fload): Use full timestamp resolution of files,
2186 not just the 1-second resolution, so that files that are only
2187 slightly newer still count as newer.
2188 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2189 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2190
dbeed9a6
PE
21912012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2192
2193 * fileio.c: Improve handling of file time marker. (Bug#11852)
2194 (special_mtime): New function.
2195 (Finsert_file_contents, Fverify_visited_file_modtime):
2196 Use it to set special mtime values consistently.
2197
636334d6
AS
21982012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2199
2200 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2201 marker for non-existing file. (Bug#11852)
2202
e2017fe2
GM
22032012-07-03 Glenn Morris <rgm@gnu.org>
2204
2205 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2206 and did not make it into globals.h).
2207
404dbd37
TT
22082012-07-03 Tom Tromey <tromey@redhat.com>
2209
2210 * window.c (Fset_window_margins, Fset_window_fringes)
2211 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2212 * textprop.c (Fprevious_property_change): No longer static.
2213 * syntax.c (Fsyntax_table_p): No longer static.
2214 * process.c (Fget_process, Fprocess_datagram_address): No longer
2215 static.
2216 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2217 * keyboard.c (Fcommand_execute): No longer static.
2218 Remove EXFUN.
2219 * insdel.c (Fcombine_after_change_execute): No longer static.
2220 * image.c (Finit_image_library): No longer static.
2221 * fileio.c (Fmake_symbolic_link): No longer static.
2222 * eval.c (Ffetch_bytecode): No longer static.
2223 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2224 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2225 No longer static.
404dbd37
TT
2226 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2227 static.
2228 * dired.c (Ffile_attributes): No longer static.
2229 * composite.c (Fcomposition_get_gstring): No longer static.
2230 * callproc.c (Fgetenv_internal): No longer static.
2231
2232 * ccl.h: Remove EXFUNs.
2233 * buffer.h: Remove EXFUNs.
2234 * dispextern.h: Remove EXFUNs.
2235 * intervals.h: Remove EXFUNs.
2236 * fontset.h: Remove EXFUN.
2237 * font.h: Remove EXFUNs.
2238 * dosfns.c (system_process_attributes): Remove EXFUN.
2239 * keymap.h: Remove EXFUNs.
2240 * lisp.h: Remove EXFUNs.
2241 * w32term.h: Remove EXFUNs.
2242 * window.h: Remove EXFUNs.
2243 * xsettings.h: Remove EXFUN.
2244 * xterm.h: Remove EXFUN.
2245
8e4fd1e1
GM
22462012-07-03 Glenn Morris <rgm@gnu.org>
2247
2248 * lisp.h (Frandom): Make it visible to C.
2249 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2250 buffer for invisible buffers. (Bug#1229)
2251
ca95b3eb
DA
22522012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2253
2254 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2255 values which aren't power of 2.
2256 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2257 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2258 accordingly.
2259
7555c33f
SM
22602012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2261
2262 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2263
2264 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2265
d12e8f5a
DA
22662012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2267
2268 * alloc.c (allocate_vector_block): Remove redundant
2269 calls to mallopt if DOUG_LEA_MALLOC is defined.
2270 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2271 avoid calls to mallopt if zero_vector is returned.
2272
296094c3
DA
22732012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2274
2275 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2276 is enabled, avoid dereferencing NULL current_sblock if
2277 running undumped.
2278
36429c89
DA
22792012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2280
2281 Cleanup basic buffer management.
2282 * buffer.h (struct buffer): Change layout to use generic vector
2283 marking code. Fix some comments. Change type of 'clip_changed'
2284 to bitfield. Remove unused #ifndef old.
2285 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2286 (GET_OVERLAYS_AT): Fix indentation.
2287 (for_each_per_buffer_object_at): New macro.
2288 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2289 (Fbuffer_local_variables): Use it.
2290 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2291 * alloc.c (allocate_buffer): Adjust to match new layout of
2292 struct buffer. Fix comment.
2293 (mark_overlay): New function.
2294 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2295 Lisp area of struct buffer.
2296 (mark_object): Use it. Adjust marking of misc objects
2297 and related comments.
2298
3b3e4cac
PE
22992012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2300
2301 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2302 wrapper that is not needed because the wrapped code is a no-op (zero
2303 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2304 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2305
cf5c0175
DA
23062012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2307
2308 * alloc.c (mark_buffer): Simplify. Remove prototype.
2309 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2310 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2311 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2312 redundant calls to mark_vectorlike for bool vectors.
2313
ca26824c
GM
23142012-06-30 Glenn Morris <rgm@gnu.org>
2315
2e4c5312
GM
2316 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2317
ca26824c
GM
2318 * epaths.in (PATH_SITELOADSEARCH): New.
2319 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2320 This is rather than relying on --enable-locallisppath elements
2321 having "site-lisp" in their names. (Bug#10208#25, 11658)
2322
0d23c240
EZ
23232012-06-30 Eli Zaretskii <eliz@gnu.org>
2324
c9240d7a
EZ
2325 * w32proc.c (sys_select): Accept and ignore one more argument.
2326
2327 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2328
0d23c240 2329 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2330 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2331
2332 * sysdep.c: Don't include dos.h and dosfns.h.
2333
2334 * process.c (sys_select):
2335 * msdos.c (sys_select): Accept one more argument and ignore it.
2336
2337 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2338 adapt data types and code to that.
2339
2340 * dosfns.c:
2341 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2342 which clashes with the gnulib function of the same name.
2343
af5a5a98
AS
23442012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2345
c5e4379c
AS
2346 * font.c (font_style_to_value, font_style_symbolic)
2347 (font_prop_validate_style): Add type checks for values in
2348 font_style_table.
2349
af5a5a98
AS
2350 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2351 argument.
2352 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2353 uses.
2354
8d38f461
EZ
23552012-06-29 Eli Zaretskii <eliz@gnu.org>
2356
2e5a6631
EZ
2357 * xdisp.c (try_window_id): Undo last change.
2358
8d38f461
EZ
2359 * w32.c (getwd): Adjust commentary about startup_dir.
2360 (init_environment): Always call sys_access, even in non-MSVC
2361 builds. Don't chdir to the directory of the Emacs executable.
2362 This undoes code from 1997 which was justified by the need to
2363 "avoid conflicts when removing and renaming directories". But its
2364 downside was that every relative file name was being interpreted
2365 relative to the directory of the Emacs executable, which can never
2366 be TRT. In particular, it broke sys_access when called with
2367 relative file names.
2368 (sys_access): Map GetLastError to errno.
2369
2af3565e
DA
23702012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2371
2372 * window.h (struct window): Change type of 'fringes_outside_margins'
2373 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2374 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2375 Adjust comment.
2376 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2377 to ptrdiff_t.
2378
c8d3a25c 23792012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2380
c8d3a25c
GM
2381 * gnutls.c (emacs_gnutls_handshake):
2382 Add QUIT to make the loop interruptible.
57570cd3 2383
c8d3a25c 23842012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2385
c8d3a25c
GM
2386 * charset.c (init_charset): Make lack of etc/charsets fatal.
2387
3e984ee8
DA
23882012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2389
2390 * editfns.c (region_limit): Fix type mismatch.
2391
ef884f23
DA
23922012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2393
2394 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2395 undefined. Convert from xassert to eassert.
2396 * nsmenu.m: Convert from xassert to eassert.
2397 * nsterm.m: Likewise.
2398
7d7e0027
SM
23992012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2400
2401 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2402
aa754e6a
PE
24032012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2404
2405 Avoid integer overflow on scroll-left and scroll-right.
2406 * window.c (HSCROLL_MAX): New macro.
2407 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2408 overflow when requested scroll falls outside ptrdiff_t range.
2409
80b00b08
DA
24102012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2411
2412 * window.h (struct window): Change type of 'hscroll',
2413 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2414 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2415 Adjust users accordingly.
2416 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2417 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2418 from EMACS_INT to ptrdiff_t.
2419 (make_window): Omit redundant initialization.
2420
62b2bcf6
JB
24212012-06-28 Juanma Barranquero <lekktu@gmail.com>
2422
2423 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2424
45942c7d
DA
24252012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2426
2427 * window.h (struct window): Change type of 'use_time' and
2428 'sequence_number' from Lisp_Object to int.
2429 * frame.c (make_frame): Adjust users accordingly.
2430 * print.c (print_object): Likewise.
2431 * window.c (select_window, Fwindow_use_time, make_parent_window)
2432 (make_window): Likewise.
2433
e509cfa6
DA
24342012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2435
2436 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2437 enabled with --enable-checking=[all,glyphs] configure option.
2438 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2439 adjust comments accordingly.
2440 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2441 undefined, adjust comments accordingly.
2442 * image.c: Likewise.
2443 * scroll.c: Likewise.
2444 * w32fns.c: Likewise.
2445 * w32term.c: Likewise.
2446 * xdisp.c: Likewise.
2447 * xfaces.c: Likewise.
2448 * xfns.c: Likewise.
2449 * xterm.c: Likewise.
2450
a54e2c05
DA
24512012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2452
2453 Generalize run-time debugging checks.
2454 * dispextern.h (XASSERTS): Remove.
2455 * fontset.c (xassert): Remove.
2456 Convert from xassert to eassert.
2457 * alloc.c: Convert from xassert to eassert.
2458 * bidi.c: Likewise.
2459 * dispnew.c: Likewise.
2460 * fns.c: Likewise.
2461 * fringe.c: Likewise.
2462 * ftfont.c: Likewise.
2463 * gtkutil.c: Likewise.
2464 * image.c: Likewise.
2465 * keyboard.c: Likewise.
2466 * menu.c: Likewise.
2467 * process.c: Likewise.
2468 * scroll.c: Likewise.
2469 * sound.c: Likewise.
2470 * term.c: Likewise.
2471 * w32console.c: Likewise.
2472 * w32fns.c: Likewise.
2473 * w32term.c: Likewise.
2474 * window.c: Likewise.
2475 * xdisp.c: Likewise.
2476 * xfaces.c: Likewise.
2477 * xfns.c: Likewise.
2478 * xselect.c: Likewise.
2479 * xterm.c: Likewise.
2480
1ec4b7b2
SM
24812012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2482
2483 * fns.c (maybe_resize_hash_table): Output message when growing the
2484 purify-hashtable.
2485
2014308a
DA
24862012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2487
2488 * alloc.c (allocate_string_data): Remove dead code.
2489 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2490 avoid GCC warning about unused macro.
2491
246155eb
DA
24922012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2493
2494 * alloc.c (allocate_string): Omit intervals initialization.
2495 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2496 as in make_pure_string and make_pure_c_string.
2497
43184b7b
DA
24982012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2499
d209e2fb 2500 * alloc.c (allocate_string): Fix last change.
43184b7b 2501
3fe6dd74
DA
25022012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2503
d209e2fb 2504 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2505 to memset, add explicit initialization where appropriate.
2506
1ba6038a
GM
25072012-06-27 Glenn Morris <rgm@gnu.org>
2508
2509 * lisp.mk (lisp): Remove paths.elc.
2510
c89926a5
CY
25112012-06-27 Chong Yidong <cyd@gnu.org>
2512
2513 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2514
ed6b3510
JW
25152012-06-26 John Wiegley <johnw@newartisans.com>
2516
1ec4b7b2 2517 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2518 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2519
ed6b3510
JW
2520 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2521 when building with Clang.
2522
8edd4a2b
SM
25232012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2524
2525 * eval.c (Fapply): Allow calling it with a single argument.
2526
f6f62d1b
EZ
25272012-06-26 Eli Zaretskii <eliz@gnu.org>
2528
2529 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2530 _stricmp and _strnicmp.
2531 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2532
62efea5e
DA
25332012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2534
2535 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2536 allocated window.
2537 (allocate_process): Likewise for new process.
8edd4a2b 2538 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2539 (allocate_frame): Likewise.
2540 * frame.c (make_frame): Omit redundant initialization.
2541 * window.c (make_parent_window): Use memset.
2542 (make_window): Omit redundant initialization.
2543 * process.c (make_process): Omit redundant initialization.
2544 * terminal.c (create_terminal): Likewise.
2545
42997f4d
DA
25462012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2547
2548 * term.c (delete_tty): Remove redundant call to memset.
2549
1130ecfc
DA
25502012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2551
2552 * alloc.c: Remove build_string.
2553 * lisp.h: Define build_string as static inline. This provides
2554 a better opportunity to optimize away calls to strlen when the
2555 function is called with compile-time constant argument.
2556 * image.c (imagemagick_error): Convert to build_string.
2557 * w32proc.c (sys_spawnve): Likewise.
2558 * xterm.c (x_term_init): Likewise.
2559
cf38a720
PE
25602012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2561
99027bdd
PE
2562 Use sprintf return value instead of invoking strlen on result.
2563 In the old days this wasn't portable, since some sprintf
2564 implementations returned char *. But they died out years ago and
2565 Emacs already assumes sprintf returns int.
2566 Similarly for float_to_string.
2567 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2568 * ccl.c (ccl_driver):
2569 * character.c (string_escape_byte8):
2570 * data.c (Fnumber_to_string):
2571 * doprnt.c (doprnt):
2572 * print.c (print_object):
2573 * xdisp.c (message_dolog):
2574 * xfns.c (syms_of_xfns):
2575 Use sprintf or float_to_string result to avoid need to call strlen.
2576 * data.c (Fnumber_to_string):
2577 Use make_unibyte_string, since the string must be ASCII.
2578 * lisp.h, print.c (float_to_string): Now returns int length.
2579 * term.c (produce_glyphless_glyph):
2580 Use sprintf result rather than recomputing it.
2581
cf38a720
PE
2582 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2583 * Makefile.in (ALL_CFLAGS):
2584 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2585 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2586
3511c784
DA
25872012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2588
0a08eb21 2589 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2590 strcasecmp if available.
2591 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2592
fb7da12e
AS
25932012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2594
2595 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2596 Avoid comma operator.
2597 * menu.c (push_submenu_start, push_submenu_end)
2598 (push_left_right_boundary, push_menu_pane): Likewise.
2599 * msdos.c (dos_rawgetc): Likewise.
2600
afa2ffd8
DA
26012012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2602
2603 * xfns.c (xic_create_fontsetname): Remove redundant calls
2604 to memset.
2605
b3b4476b
PE
26062012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2607
4495ff38
PE
2608 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2609 sprintf already null-terminates its output.
2610
b3b4476b
PE
2611 * xfns.c (x_window): Remove redundant cast.
2612
b00876c9
DA
26132012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2614
2615 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2616 `const char *' to `char *' to avoid compiler warning.
2617
d188e26b
PE
26182012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2619
885d1d74
PE
2620 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2621 instead of truncating it to 63 (admittedly a generous limit).
2622
d188e26b
PE
2623 * process.c: Fix spelling and caps in comments.
2624
e2f560b1
DN
26252012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2626
e86db54b 2627 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2628 * sysdep.c (setpgrp): Remove definition, not used in this file.
2629
7583a3a1
JB
26302012-06-24 Juanma Barranquero <lekktu@gmail.com>
2631
2632 * makefile.w32-in: Update dependencies.
2633
696056c2
EZ
26342012-06-24 Eli Zaretskii <eliz@gnu.org>
2635
2636 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2637 (SYSTIME_H): Add nt/inc/sys/time.h.
2638
2639 * systime.h [WINDOWSNT]: Include sys/time.h.
2640
2641 * s/ms-w32.h (struct timespec): Definition moved from
2642 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2643
845ca893
PE
26442012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2645
2646 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2647 * buffer.h (buffer_slot_type_mismatch):
2648 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2649 * eval.c (unwind_to_catch):
2650 * image.c (my_png_error, my_error_exit):
2651 * keyboard.c (quit_throw_to_read_char, user_error)
2652 (Fexit_recursive_edit, Fabort_recursive_edit):
2653 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2654 (wrong_type_argument, buffer_overflow, __executable_start)
2655 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2656 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2657 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2658 (fatal):
2659 (child_setup) [!DOS_NT]:
2660 * lread.c (end_of_file_error, invalid_syntax):
2661 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2662 * puresize.h (pure_write_error):
2663 * search.c (matcher_overflow):
2664 * sound.c (sound_perror, alsa_sound_perror):
2665 * sysdep.c, syssignal.h (croak):
2666 * term.c (maybe_fatal, vfatal):
2667 * textprop.c (text_read_only):
2668 * undo.c (user_error):
2669 * unexmacosx.c (unexec_error):
2670 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2671 Use _Noreturn rather than NO_RETURN.
2672 No need for separate decl merely because of _Noreturn.
2673 * sound.c (sound_warning, parse_sound):
2674 Remove unnecessary forward decls.
2675
f1dd8073
PE
26762012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2677
2678 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2679 * lisp.h (WAIT_READING_MAX): New macro.
2680 * dispnew.c (Fsleep_for, sit_for):
2681 * keyboard.c (kbd_buffer_get_event):
2682 * process.c (Faccept_process_output):
2683 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2684 This improves on the previous patch, which introduced a bug
2685 when time_t is unsigned and as wide as intmax_t.
2686 See <http://bugs.gnu.org/9000#51>.
2687
b82c1755
EZ
26882012-06-23 Eli Zaretskii <eliz@gnu.org>
2689
2690 * dispnew.c (sit_for, Fsleep_for):
2691 * keyboard.c (kbd_buffer_get_event):
2692 * process.c (Faccept_process_output): Avoid compiler warnings when
2693 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2694
ca300656
JB
26952012-06-23 Juanma Barranquero <lekktu@gmail.com>
2696
049ec95b
JB
2697 * makefile.w32-in: Update dependencies.
2698
ca300656
JB
2699 * w32.c (ltime): Add return type and declare static.
2700 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2701
db7b8d06
PE
27022012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2703
2704 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2705 Privately reported by Herbert J. Skuhra.
2706 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2707 All uses changed.
2708 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2709 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2710
0bd8297f
EZ
27112012-06-23 Eli Zaretskii <eliz@gnu.org>
2712
96512555
EZ
2713 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2714 last argument of make_unibyte_string.
2715
0bd8297f
EZ
2716 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2717 language ID in the event parameters.
2718
2719 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2720 event.code, not the obscure "character set ID".
2721
63def6b6
CY
27222012-06-23 Chong Yidong <cyd@gnu.org>
2723
2724 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2725
e8a02204
EZ
27262012-06-23 Eli Zaretskii <eliz@gnu.org>
2727
388cdec0
EZ
2728 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2729 * w32.c (fdutimens): New function.
2730
2731 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2732
2733 * s/ms-w32.h (pselect): Redirect to sys_select.
2734
2735 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2736
e8a02204
EZ
2737 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2738 in the logic of incrementing and decrementing the value of
2739 use_relocatable_buffers.
2740
d054f3fb
PE
27412012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2742
2743 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2744 Privately reported by Herbert J. Skuhra.
2745 [__FreeBSD__]: Remove "*/" typo after "#include".
2746 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2747 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2748 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2749 Don't assume EMACS_TIME and struct timeval are the same type.
2750
d35af63c
PE
27512012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2752
2753 Support higher-resolution time stamps (Bug#9000).
2754 The time stamps are only nanosecond-resolution at the C level,
2755 since that's the best that any real-world system supports now.
2756 But they are picosecond-resolution at the Lisp level, as that's
2757 easy, and leaves room for future OS improvements.
2758
2759 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2760 (LIBES): Use it.
2761
2762 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2763 Don't get current time unless it's needed.
2764
2765 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2766 now provides it if it's absent.
2767 (start_atimer): Port to higher-res time stamps.
2768 Check for time stamp overflow. Don't get current time more
2769 often than is needed.
2770
2771 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2772 Include systime.h, not time.h.
2773 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2774
2775 * dired.c: Include stat-time.h.
2776 (Ffile-attributes): File times now have higher resolution.
2777
2778 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2779 (struct image): Timestamp now has higher resolution.
2780
2781 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2782 has at least microseconds now. All uses removed.
2783 (update_frame, update_single_window, update_window, update_frame_1)
2784 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2785
2786 * editfns.c (time_overflow): Now extern.
2787 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2788 (float-time, Fformat_time_string, Fcurrent_time_string)
2789 (Fcurrent_time_zone): Accept and generate higher-resolution
2790 time stamps.
2791 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2792 (decode_time_components, lisp_seconds_argument): New functions.
2793 (make_time): Now static.
2794 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2795 Report an error if the time is invalid, rather than having the caller
2796 do that.
2797
2798 * fileio.c: Include <stat-time.h>
2799 (Fcopy_file): Copy higher-resolution time stamps.
2800 Prefer to set the time stamp via a file descriptor if that works.
2801 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2802 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2803 (Fvisited_file_modtime, Fset_visited_file_modtime):
2804 Support higher-resolution time stamps.
2805
2806 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2807
2808 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2809
2810 * image.c (prepare_image_for_display, clear_image_cache)
2811 (lookup_image): Port to higer-resolution time stamps.
2812
2813 * keyboard.c (start_polling, bind_polling_period):
2814 Check for time stamp overflow.
2815 (read_char, kbd_buffer_get_event, timer_start_idle)
2816 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2817 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2818 Port to higher-resolution time stamps. Do not assume time_t is signed.
2819 (decode_timer): New function. Timers are now vectors of length 9,
2820 not 8, to accommodate the picosecond component.
2821 (timer_check_2): Use it.
2822
2823 * nsterm.m (select_timeout, timeval_subtract): Remove.
2824 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2825 as they're a bit more accurate and handle overflow better.
2826 (ns_select): Change prototype to be compatible with pselect.
2827 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2828 * nsterm.h (ns_select): Adjust prototype.
2829
2830 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2831 us-resolution time stamps.
2832 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2833
2834 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2835
2836 * lisp.h (time_overflow): New decl.
2837 (wait_reading_process_output): First arg is now intmax_t, not int,
2838 to accommodate larger waits.
2839
2840 * process.h (struct Lisp_Process.read_output_delay):
2841 Now counts nanoseconds, not microseconds.
2842 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2843 EMACS_HAS_USECS.
2844 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2845 (wait_reading_process_output):
2846 Port to ns-resolution time stamps.
2847 (Faccept_process_output, wait_reading_process_output):
2848 Check for time stamp overflow. Do not assume time_t is signed.
2849 (select_wrapper): Remove; we now use pselect.
2850 (Fprocess_attributes): Now generates ns-resolution time stamps.
2851
2852 * sysdep.c: Include utimens.h. Don't include utime.h
2853 or worry about struct utimbuf; gnulib does that for us now.
2854 (gettimeofday): Remove; gnulib provides a substitute.
2855 (make_timeval): New function.
2856 (set_file_times): Now sets ns-resolution time stamps.
2857 New arg FD; all uses changed.
2858 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2859 (system_process_attributes):
2860 Now returns ns-resolution time stamp. All uses changed.
2861 Check for time stamp overflow.
2862
2863 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2864 provides a substitute now.
2865
2866 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2867 since it guarantees struct timespec.
2868 (EMACS_TIME): Now struct timespec, so that we can support
2869 ns-resolution time stamps.
2870 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2871 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2872 (EMACS_USECS): Remove.
2873 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2874 so multiply the arg by 1000 before storing it.
2875 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2876 New macros.
2877 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2878 Port to ns-resolution time stamps.
2879 (EMACS_TIME_NEG_P): Remove; replaced by....
2880 (EMACS_TIME_SIGN): New macro.
2881 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2882 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2883 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2884 (make_timeval, make_lisp_time, decode_time_components): New decls.
2885 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2886 that it mishandled time_t overflow. You can't compare by subtracting!
2887 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2888 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2889
2890 * term.c: Include <sys/time.h>.
2891 (timeval_to_Time): New function, for proper overflow wraparound.
2892 (term_mouse_position, term_mouse_click): Use it.
2893
2894 * undo.c (record_first_change): Support higher-resolution time stamps
2895 in the undo buffer.
2896 (Fprimitive_undo): Use them when restoring time stamps.
2897
2898 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2899 (w32_get_internal_run_time):
2900 Port to higher-resolution Emacs time stamps.
2901 (ltime): Now accepts single 64-bit integer, as that's more convenient
2902 for callers.
2903
2904 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2905
2906 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2907 for compatibility with pselect. Support ns-resolution time stamps.
2908
2909 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2910
2911 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2912 Check for time stamp overflow, and support ns-resolution time stamps.
2913
2914 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2915 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2916 (timeval_subtract): Remove; no longer needed.
2917 (XTflash, XTring_bell, x_wait_for_event):
2918 Port to ns-resolution time stamps. Don't assume time_t is signed.
2919
b6a92dfe
CY
29202012-06-22 Chong Yidong <cyd@gnu.org>
2921
2922 * xdisp.c (x_consider_frame_title): Revert last change.
2923
d251c37c
EZ
29242012-06-22 Eli Zaretskii <eliz@gnu.org>
2925
2926 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2927 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2928 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2929 staticidx goes up to 1597 out of 1600 = 0x640.)
2930
f10deafb
PE
29312012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2932
2933 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2934 Otherwise, the umask might be mistakenly 0 while handling input signals.
2935
ec6de1e2
SM
29362012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2937
2938 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2939
28be1ada
DA
29402012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2941
2942 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2943 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2944 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2945 access to `contents' member of Lisp_Vector objects with AREF and ASET
2946 where appropriate.
2947
c6bf3022
CY
29482012-06-19 Chong Yidong <cyd@gnu.org>
2949
2950 * frame.c (delete_frame): When selecting a frame on a different
2951 text terminal, do not alter the terminal's top-frame.
2952
2953 * xdisp.c (format_mode_line_unwind_data): Record the target
2954 frame's selected window and its terminal's top-frame.
2955 (unwind_format_mode_line): Restore them.
2956 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2957 Callers changed.
2958 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2959 since tty frames can be explicitly named.
2960 (prepare_menu_bars): Likewise.
2961
2962 * term.c (Ftty_top_frame): New function.
2963
defd4196
PE
29642012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2965
2966 Port byte-code-meter to modern targets.
2967 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2968 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2969 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2970 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2971 (METER_1, METER_2): Simplify.
2972
1053a871
SM
29732012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2974
2975 * data.c (Fdefalias): Return `symbol' (bug#11686).
2976
b7e8d081
MR
29772012-06-18 Martin Rudalics <rudalics@gmx.at>
2978
2979 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2980 gets killed during executing of this function (Bug#11665).
2981 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2982 (Vkill_buffer_query_functions): In doc-string say that functions
2983 run by this hook should not change the current buffer.
2984
7ea2b339
PE
29852012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2986
2987 Fix recently-introduced process.c problems found by static checking.
2988 * process.c (write_queue_push, write_queue_pop, send_process):
2989 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2990 (write_queue_pop): Fix pointer signedness problem.
2991 (send_process): Remove unused local.
2992
96a313a1
CY
29932012-06-17 Chong Yidong <cyd@gnu.org>
2994
2995 * xdisp.c (redisplay_internal): No need to redisplay terminal
2996 frames that are not on top.
2997
20ca2e94
TN
29982012-06-17 Troels Nielsen <bn.troels@gmail.com>
2999
3000 * process.c (make_process): Initialize write_queue.
3001 (write_queue_push, write_queue_pop): New functions.
3002 (send_process): Use them to maintain correct ordering of process
3003 writes (Bug#10815).
3004
9a900ca9
PE
30052012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3006
310fbfa8
PE
3007 * lisp.h (eassert): Assume C89 or later.
3008 This removes the need for CHECK.
3009 (CHECK): Remove. Its comments about always evaluating its
3010 argument were confusing, as 'eassert' typically does not evaluate
3011 its argument.
3012
27bb1ca4
PE
3013 * coding.c (produce_chars): Use ptrdiff_t, not int.
3014
9a900ca9
PE
3015 * xterm.c (x_draw_underwave): Check for integer overflow.
3016 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3017
41b7f8bc 30182012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3019
3020 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3021 referenced (Bug#11583).
3022
9b0e3eba
AA
30232012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3024
3025 Implement wave-style variant of underlining.
3026 * dispextern.h (face_underline_type): New enum.
3027 (face): Add field for underline type.
3028 * nsterm.m (ns_draw_underwave): New function.
3029 (ns_draw_text_decoration): Use it.
3030 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3031 New functions.
3032 (x_draw_glyph_string): Use them.
3033 * xfaces.c (Qline, Qwave): New Lisp objects.
3034 (check_lface_attrs, merge_face_ref)
1053a871
SM
3035 (Finternal_set_lisp_face_attribute, realize_x_face):
3036 Handle wave-style underline face attributes.
9b0e3eba
AA
3037 * xterm.c (x_draw_underwave): New function.
3038 (x_draw_glyph_string): Use it.
3039
0fb52f11
JB
30402012-06-16 Juanma Barranquero <lekktu@gmail.com>
3041
3042 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3043 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3044 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3045 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3046 ($(BLD)/w32select.$(O)): Update dependencies.
3047
e5560ff7
AS
30482012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3049
3050 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3051 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3052 * character.c (_fetch_multibyte_char_p): Remove.
3053 * alloc.c: Include "character.h" before "buffer.h".
3054 * bidi.c: Likewise.
3055 * buffer.c: Likewise.
3056 * bytecode.c: Likewise.
3057 * callint.c: Likewise.
3058 * callproc.c: Likewise.
3059 * casefiddle.c: Likewise.
3060 * casetab.c: Likewise.
3061 * category.c: Likewise.
3062 * cmds.c: Likewise.
3063 * coding.c: Likewise.
3064 * composite.c: Likewise.
3065 * dired.c: Likewise.
3066 * dispnew.c: Likewise.
3067 * doc.c: Likewise.
3068 * dosfns.c: Likewise.
3069 * editfns.c: Likewise.
3070 * emacs.c: Likewise.
3071 * fileio.c: Likewise.
3072 * filelock.c: Likewise.
3073 * font.c: Likewise.
3074 * fontset.c: Likewise.
3075 * fringe.c: Likewise.
3076 * indent.c: Likewise.
3077 * insdel.c: Likewise.
3078 * intervals.c: Likewise.
3079 * keyboard.c: Likewise.
3080 * keymap.c: Likewise.
3081 * lread.c: Likewise.
3082 * macros.c: Likewise.
3083 * marker.c: Likewise.
3084 * minibuf.c: Likewise.
3085 * nsfns.m: Likewise.
3086 * nsmenu.m: Likewise.
3087 * print.c: Likewise.
3088 * process.c: Likewise.
3089 * regex.c: Likewise.
3090 * region-cache.c: Likewise.
3091 * search.c: Likewise.
3092 * syntax.c: Likewise.
3093 * term.c: Likewise.
3094 * textprop.c: Likewise.
3095 * undo.c: Likewise.
3096 * unexsol.c: Likewise.
3097 * w16select.c: Likewise.
3098 * w32fns.c: Likewise.
3099 * w32menu.c: Likewise.
3100 * window.c: Likewise.
3101 * xdisp.c: Likewise.
3102 * xfns.c: Likewise.
3103 * xmenu.c: Likewise.
3104 * xml.c: Likewise.
3105 * xselect.c: Likewise.
3106
2f07e6af
EZ
31072012-06-16 Eli Zaretskii <eliz@gnu.org>
3108
1053a871
SM
3109 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3110 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3111 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3112 row.
3113 (handle_face_prop): Use chunk-relative overlay string index when
3114 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3115 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3116 the rightmost. (Bug#11720)
2f07e6af 3117
29b83cec
AS
31182012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3119
3120 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3121 (CATEGORY_MEMBER): Enforce 1/0 value.
3122 * category.c (_temp_category_set): Remove.
3123
4c5501e9
EZ
31242012-06-16 Eli Zaretskii <eliz@gnu.org>
3125
3126 * window.c (Fdelete_other_windows_internal)
3127 (Fdelete_window_internal): Don't access frame's mouse highlight
3128 info of the initial frame. (Bug#11677)
3129
2b570124
PE
31302012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3131
e93864f9
PE
3132 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3133 Assume USE_2_TAGS_FOR_INTS.
3134 (xreload): Adjust $tagmask width to match recent lisp.h change.
3135
2b570124
PE
3136 Simplify lisp.h in minor ways that should not affect code.
3137 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3138 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3139 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3140 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3141 (INTTYPEBITS): New macro, for clarity.
3142 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3143 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3144 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3145 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3146 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3147
81755f69
JB
31482012-06-13 Juanma Barranquero <lekktu@gmail.com>
3149
3150 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3151
16192a57
GM
31522012-06-13 Glenn Morris <rgm@gnu.org>
3153
3154 * s/bsd-common.h (BSD4_3):
3155 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3156
646b5f55
AS
31572012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3158
3159 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3160 instead of union.
3161 (XLI, XIL): Define.
1053a871
SM
3162 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3163 Use them.
3164 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3165 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3166 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3167 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3168 * frame.c (delete_frame): Remove outdated comment.
3169 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3170 USE_LISP_UNION_TYPE.
3171 (Fw32_unregister_hot_key): Likewise.
3172 (Fw32_toggle_lock_key): Likewise.
3173 * w32menu.c (add_menu_item): Likewise.
3174 (w32_menu_display_help): Use XIL instead of checking
3175 USE_LISP_UNION_TYPE.
3176 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3177 (init_heap): Likewise.
3178 * w32term.c (w32_read_socket): Update comment.
3179
1d3823c9
GM
31802012-06-13 Glenn Morris <rgm@gnu.org>
3181
c62ff706
GM
3182 * s/usg5-4-common.h, src/s/unixware.h:
3183 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3184
1d3823c9
GM
3185 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3186
bfe3e0a2
PE
31872012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3188
3189 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3190 * alloc.c (make_number) [!defined make_number]:
3191 Remove, as lisp.h always defines this now.
3192 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3193 (roundup_size): Verify that it is a power of 2.
3194 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3195 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3196 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3197 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3198 USE_LSB_TAG now is always defined to be either 0 or 1.
3199 All uses changed.
3200 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3201 code works fine either way, and efficiency is not a concern here,
3202 as the union type is for debugging, not for production.
3203 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3204 Use an inline function on all platforms when using the union type,
3205 since this is simpler and 'static inline' can be used portably
3206 within Emacs now.
3207 (LISP_INITIALLY_ZERO): New macro.
3208 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3209 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3210
45fa9c0f
GM
32112012-06-12 Glenn Morris <rgm@gnu.org>
3212
b4492cba
GM
3213 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3214
3215 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3216
45fa9c0f
GM
3217 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3218 Move BROKEN_SIGIO to configure.
3219
3220 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3221 Move NO_TERMIO to configure.
3222
0e25d334
CY
32232012-06-12 Chong Yidong <cyd@gnu.org>
3224
3225 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3226 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3227 MagickExportImagePixels is undefined.
3228
43682bb6
PE
32292012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3230
3231 * image.c (imagemagick_load_image): Remove unused label.
3232
a9be7d2b
GM
32332012-06-11 Glenn Morris <rgm@gnu.org>
3234
3235 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3236 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3237 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3238 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3239
3017f87f
SM
32402012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3241
3242 * alloc.c (make_byte_code): New function.
3243 (Fmake_byte_code): Use it. Don't purify here.
3244 * lread.c (read1): Use it as well to avoid extra allocation.
3245
1b9b4cf4
CY
32462012-06-11 Chong Yidong <cyd@gnu.org>
3247
3248 * image.c (imagemagick_load_image): Implement transparency.
3249
95988fcf
AS
32502012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3251
3252 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3253 account for preceding backslashes. (Bug#11663)
3254
cd4eb164
CY
32552012-06-09 Chong Yidong <cyd@gnu.org>
3256
3257 * term.c: Support italics in capable terminals (Bug#9652).
3258 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3259 (turn_on_face): Output using TS_enter_italic_mode if available.
3260 Don't handle unused blinking and alt-charset cases.
3261 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3262 and tty_alt_charset_p cases.
3263 (tty_capable_p, init_tty): Support italics.
3264
3265 * termchar.h (struct tty_display_info): Add field for italics.
3266 Remove unused blink field.
3267
3268 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3269 Handle slant.
3270
3271 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3272 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3273 tty_alt_charset_p. Add tty_italic_p.
3274
ff88beb8
MA
32752012-06-09 Michael Albinus <michael.albinus@gmx.de>
3276
3277 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3278 dbus_type_is_basic if available.
3279 (xd_extract_signed, xd_extract_unsigned): Rename from
3280 extract_signed and extract_unsigned, respectively. Adapt callers.
3281
44286096
CY
32822012-06-09 Chong Yidong <cyd@gnu.org>
3283
1682701f
CY
3284 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3285
44286096
CY
3286 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3287 case (Bug#9752).
3288
d86feb17
PE
32892012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3290
3291 * xdisp.c (vmessage): Treat frame message as multibyte.
3292 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3293 would generate the diagnostic "Making \302\247 buffer-local while
3294 let-bound!".
3295
d5c20fe8
EZ
32962012-06-08 Eli Zaretskii <eliz@gnu.org>
3297
3298 * dispnew.c (showing_window_margins_p): Undo last change, which
3299 was done due to an inadvertent commit.
3300 (adjust_frame_glyphs_for_frame_redisplay): Do call
3301 showing_window_margins_p.
3302
513749ee
SM
33032012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3304
3305 * eval.c (Fmake_var_non_special): New primitive.
3306 (syms_of_eval): Defsubr it.
3307 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3308
d4a8f5c1
JB
33092012-06-08 Juanma Barranquero <lekktu@gmail.com>
3310
3311 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3312 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3313
8bbbc977
EZ
33142012-06-08 Eli Zaretskii <eliz@gnu.org>
3315
3316 * alloc.c (allocate_vectorlike): Fix last change.
3317
f3372c87
DA
33182012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3319
3320 Block-based vector allocation of small vectors.
3321 * lisp.h (struct vectorlike_header): New field `nbytes',
3322 adjust comment accordingly.
3323 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3324 to denote vector blocks. Adjust users (live_vector_p,
3325 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3326 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3327 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3328 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3329 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3330 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3331 (roundup_size): New constant.
3332 (struct vector_block): New data type.
3333 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3334 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3335 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3336 (sweep_vectors): New functions.
3337 (allocate_vectorlike): Return `zero_vector' as the only vector of
3338 0 items. Allocate new vector from block if vector size is less than
3339 or equal to VBLOCK_BYTES_MAX.
3340 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3341 (init_alloc_once): Add call to init_vectors.
3342
4f18a4ed
SM
33432012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3344
3345 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3346
86f158bc
PE
33472012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3348
3349 * doprnt.c (doprnt): Truncate multibyte char correctly.
3350 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3351 would mishandle a string argument "Xc" if X was a multibyte
3352 character of length 2: it would truncate after X's first byte
3353 rather than including all of X.
3354
c5cfcbe0
CY
33552012-06-06 Chong Yidong <cyd@gnu.org>
3356
3357 * buffer.c (word_wrap): Doc fix.
3358
c05cf390
PE
33592012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3360
3361 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3362
0c3461de
GM
33632012-06-03 Glenn Morris <rgm@gnu.org>
3364
3365 * xdisp.c (tool-bar-style): Doc fix.
3366
c71232db
UM
33672012-06-03 Ulrich Müller <ulm@gentoo.org>
3368
3369 * Makefile.in (PAXCTL): Define.
3370 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3371 binary via PaX flags if the paxctl utility is available.
3372 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3373 Restore PaX flags to their default. (Bug#11398)
3374
383f7350
CY
33752012-06-03 Chong Yidong <cyd@gnu.org>
3376
3377 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3378 buffer (Bug#11226).
3379
5f2c76c6
CY
33802012-06-03 Chong Yidong <cyd@gnu.org>
3381
3382 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3383 (note_mode_line_or_margin_highlight): If there is no help echo,
3384 use mode-line-default-help-echo. Handle the case where the mouse
3385 position is past the end of the mode line string.
3386
3387 * buffer.c (buffer_local_value_1): New function, split from
3388 Fbuffer_local_value; can return Qunbound.
3389 (Fbuffer_local_value): Use it.
3390 (Vmode_line_format): Docstring tweaks.
3391
773d47f6
PE
33922012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3393
3394 * sysdep.c (system_process_attributes): Improve comment.
3395
f2d6a3df
SM
33962012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3397
3398 * keyboard.c: Export real-this-command to Elisp.
3399 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3400 and DEFVAR it. Update all users.
3401
63810350
PE
34022012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3403
7bd5c1f4
PE
3404 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3405
63810350
PE
3406 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3407 Convert pctcpu and pctmem to Lisp float properly.
3408 Let the compiler fold better, as 100.0/0x8000 is exact.
3409
a2821611
AS
34102012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3411
3412 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3413 cons_block.
3414
5fceba1d
PE
34152012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3416
3417 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3418
c98ff5dd
DA
34192012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3420
3421 For a 'struct window', replace some Lisp_Object fields to
3422 bitfields where appropriate, remove unused fields.
3423 * window.h (struct window): Remove unused 'last_mark_x' and
3424 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3425 change it's type from Lisp_Object to bitfield.
3426 Change type of 'force_start', 'optional_new_start',
3427 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3428 fields from Lisp_Object to bitfield. Adjust users accordingly.
3429
ca34e0be
PE
34302012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3431
3432 Pacify gcc -Wdouble-precision when using Xaw.
3433 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3434 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3435 Use 'float' consistently, rather than 'float' in most places
3436 and 'double' in a couple of places.
3437
efc00ab1 34382012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3439
3440 * xdisp.c (handle_stop): Detect whether we have overlay strings
3441 loaded by testing it->current.overlay_string_index to be
3442 non-negative, instead of checking whether n_overlay_strings is
3443 positive. (Bug#11587)
3444
efc00ab1 34452012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3446
3447 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3448
3449 * doc.c (Fsubstitute_command_keys): Doc fix.
3450
efc00ab1 34512012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3452
3453 * search.c (search_buffer): Remove calls to
3454 r_alloc_inhibit_buffer_relocation, as it is now called by
3455 maybe_unify_char, which was the cause of relocation of buffer text
3456 in bug#11519.
3457
efc00ab1 34582012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3459
3460 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3461 for the duration of call to load_charset, to avoid problems with
3462 callers of maybe_unify_char that access buffer text through C
3463 pointers.
3464
3465 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3466 decrement the inhibition flag, instead of just setting or
3467 resetting it.
3468
ba93a187
PE
34692012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3470
3471 Remove obsolete '#define static' cruft.
3472 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3473 This #undef was "temporary" in 2000; it is no longer needed
3474 now that '#define static' has gone away.
3475 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3476 (gray_bitmap_bits): Remove; no longer needed.
3477 All uses replaced with definiens.
3478 * xterm.c: Include "bitmaps/gray.xbm".
3479
9e4bf381
PE
34802012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3481
3482 Clean up __executable_start, monstartup when --enable-profiling.
3483 The following changes affect the code only when profiling.
3484 * dispnew.c (__executable_start): Rename from safe_bcopy.
3485 Define only on platforms that need it.
3486 * emacs.c: Include <sys/gmon.h> when profiling.
3487 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3488 (__executable_start): Remove decl, since lisp.h does it now.
3489 (safe_bcopy): Remove decl; no longer has that name.
3490 (main): Coalesce #if into single bit of code, for simplicity.
3491 Cast pointers to uintptr_t, since standard libraries want integers
3492 and not pointers.
3493 * lisp.h (__executable_start): New decl.
3494
32d72c2f
GM
34952012-05-31 Glenn Morris <rgm@gnu.org>
3496
3497 * image.c (Fimagemagick_types): Doc fix.
3498
baac5bc7
JM
34992012-05-30 Jim Meyering <meyering@redhat.com>
3500
3501 * callproc.c (Fcall_process_region): Include directory component
3502 in mkstemp error message (Bug#11586).
3503
72cb32cf
PE
35042012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3505
3506 * alloc.c, lisp.h (make_pure_vector): Now static.
3507
61b108cc
SM
35082012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3509
3510 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3511 Move to byte-run.el.
3512 (Fautoload): Do the hash-doc more carefully.
3513 * data.c (Fdefalias): Purify definition, except for keymaps.
3514 (Qdefun): Move from eval.c.
3515 * lisp.h (Qdefun): Remove.
3516 * lread.c (read1): Tiny simplification.
3517
471fe23d
TN
35182012-05-29 Troels Nielsen <bn.troels@gmail.com>
3519
934f3f58 3520 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3521 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3522 Bug#9642, but explicitly check that the buffer the overlay would
3523 be moved to is live and rearrange lines to make sure that errors
3524 will not put the overlay in an inconsistent state.
3525 (Fdelete_overlay): Cosmetics.
3526
85d0efd1
EZ
35272012-05-28 Eli Zaretskii <eliz@gnu.org>
3528
3529 * w32term.c (my_bring_window_to_top): New function.
3530 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3531 could be different from the original one.
3532 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3533 (Bug#11513)
3534
3535 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3536 by calling BringWindowToTop.
3537
3538 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3539 (WM_EMACS_END): Increase by one.
3540
da92a98c
PE
35412012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3542
3543 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3544 This avoids undefined behavior that might cause the eassert
3545 to not catch an out-of-range value.
3546
74d1f848
JB
35472012-05-28 Juanma Barranquero <lekktu@gmail.com>
3548
3549 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3550 Update dependencies.
3551
9e1a06fc
EZ
35522012-05-27 Eli Zaretskii <eliz@gnu.org>
3553
3554 * bidi.c (bidi_mirror_char): Fix last change.
3555
f3dd7312
AS
35562012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3557
3558 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3559 when referring to sectname field in printf format.
3560
81899c91
PE
35612012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3562
57b81a9f
PE
3563 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3564 Only r_alloc_inhibit_buffer_relocation needed to be added;
3565 the others were already declared.
3566
81899c91
PE
3567 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3568 before checking whether it's out of range. Put the check inside
3569 eassert. See
3570 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3571
33017faf 35722012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3573
3574 * callproc.c (Fcall_process): Restore a line that was accidentally
3575 commented out in the 2011-02-13 change (bug#11547).
3576
33017faf 35772012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3578
3579 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3580 defined on ralloc.c.
3581
3582 * buffer.c [REL_ALLOC]: Remove prototypes of
3583 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3584 they are now on lisp.h.
3585
3586 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3587
3588 * search.c (search_buffer): Use it to inhibit relocation of buffer
3589 text while re_search_2 is doing its job, because re_search_2 is
3590 passed C pointers to buffer text. (Bug#11519)
3591
23415acf
EZ
3592 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3593 Update value to 24.
3594
44e27368
EZ
3595 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3596 state after an additional call to move_it_in_display_line_to, keep
3597 the values of it->max_ascent and it->max_descent found for the
3598 entire line.
3599 (pos_visible_p): Revert the comparison against bottom_y to what it
3600 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3601 (Bug#11464)
3602
c1892f11
PE
36032012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3604
3605 Fix coding-related core dumps with gcc -ftrapv.
3606 The code was computing A - B, where A and B are pointers, and B is
3607 random garbage. This can lead to core dumps on platforms that
3608 have special pointer registers, and it also leads to core dumps on
3609 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3610 A - B only when B is initialized properly.
3611 * coding.c (coding_set_source, coding_set_destination): Return void.
3612 (coding_change_source, coding_change_destinations): New functions,
3613 with the old behaviors of coding_set_source and coding_set_destination.
3614 All callers that need an offset changed to use these new functions.
3615
eb7afdad
GM
36162012-05-26 Glenn Morris <rgm@gnu.org>
3617
3618 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3619
f12fdf02
EZ
36202012-05-26 Eli Zaretskii <eliz@gnu.org>
3621
53a63be6 3622 Extend mouse support on W32 text-mode console.
61b108cc
SM
3623 * xdisp.c (draw_row_with_mouse_face):
3624 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3625
eb3f6f01 3626 * w32console.c: Include window.h.
61b108cc
SM
3627 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3628 New functions.
eb3f6f01
EZ
3629 (initialize_w32_display): Initialize mouse-highlight data.
3630
53a63be6
EZ
3631 * w32inevt.c: Include termchar.h and window.h.
3632 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3633 moves, call note_mouse_highlight. If help_echo changed, call
3634 gen_help_event to produce help-echo message in the echo area.
3635 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3636 highlight info.
3637
4cfd81f6
PE
36382012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3639
3640 * lread.c (read1): Simplify slightly to avoid an overflow warning
3641 with GCC 4.7.0 on x86-64.
3642
4446092a
EZ
36432012-05-26 Eli Zaretskii <eliz@gnu.org>
3644
3645 * bidi.c (bidi_mirror_char): Revert last change: an int is
3646 definitely wide enough here.
3647
42b2a986 36482012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3649
42b2a986 3650 Fix integer width and related bugs (Bug#9874).
eb106a49 3651 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3652 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3653 (string_bytes, check_sblock, allocate_string_data):
3654 (compact_small_strings, Fmake_bool_vector, make_string)
3655 (make_unibyte_string, make_multibyte_string)
3656 (make_string_from_bytes, make_specified_string)
3657 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3658 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3659 (mark_vectorlike):
3660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3661 (allocate_pseudovector):
3662 Use int, not EMACS_INT, where int is wide enough.
3663 (inhibit_garbage_collection, Fgarbage_collect):
3664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3665 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3666 int might not be wide enough.
3667 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3668 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3669 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3670 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3671 (bidi_level_of_next_char, bidi_move_to_visually_next):
3672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3673 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3674 (Fkill_buffer, Fset_buffer_major_mode)
3675 (advance_to_char_boundary, Fbuffer_swap_text)
3676 (Fset_buffer_multibyte, overlays_at, overlays_in)
3677 (overlay_touches_p, struct sortvec, record_overlay_string)
3678 (overlay_strings, recenter_overlay_lists)
3679 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3680 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3681 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3682 (Foverlay_recenter, last_overlay_modification_hooks_used)
3683 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3685 (validate_region): Omit unnecessary test for b <= e,
3686 since that's guaranteed by the previous test.
d311d28c
PE
3687 (adjust_overlays_for_delete): Avoid pos + length overflow.
3688 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3689 (report_overlay_modification):
3690 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3691 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3692 Omit pointer cast, which isn't needed anyway, and doesn't work
3693 after the EMACS_INT -> ptrdiff_t change.
02481186 3694 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3695 * buffer.h: Adjust decls to match defn changes elsewhere.
3696 (struct buffer_text, struct buffer):
3697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3698 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3699 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3700 not int, to avoid needless 32-bit limit on 64-bit hosts.
3701 (exec_byte_code): Use tighter memory-full test, one that checks
3702 for alloca overflow. Don't compute the address of the object just
3703 before an array, as that's not portable. Use EMACS_INT, not
3704 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3705 * callint.c (Fcall_interactively):
3706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3707 * callproc.c (call_process_kill, Fcall_process):
3708 Don't assume pid_t fits into an Emacs fixnum.
3709 (call_process_cleanup, Fcall_process, child_setup):
3710 Don't assume pid_t fits into int.
3711 (call_process_cleanup, Fcall_process, delete_temp_file)
3712 (Fcall_process_region):
3713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3714 (Fcall_process): Simplify handling of volatile integers.
3715 Use int, not EMACS_INT, where int will do.
3716 * casefiddle.c (casify_object, casify_region, operate_on_word)
3717 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3719 (casify_object): Avoid integer overflow when overallocating buffer.
3720 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3721 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3722 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3723 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3724 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3725 integers are now checked earlier. All uses replaced with XINT.
3726 (ccl_driver):
3727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3728 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3729 (ccl_driver, Fregister_code_conversion_map):
3730 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3731 (resolve_symbol_ccl_program): Check that vector header is in range.
3732 Always copy the vector, so that we can check its contents reliably
3733 now rather than having to recheck each instruction as it's being
3734 executed. Check that vector words fit in 'int'.
3735 (ccl_get_compiled_code, Fregister_ccl_program)
3736 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3737 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3738 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3739 contents are in range.
3740 (Fccl_execute_on_string): Check that status is in range.
3741 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3742 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3743 Accept and return EMACS_INT, not int, because callers can pass values
3744 out of 'int' range.
3745 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3746 (multibyte_chars_in_text, parse_str_as_multibyte)
3747 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3748 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3749 (string_escape_byte8, Fget_byte):
3750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3751 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3752 avoid mishandling large integers.
3753 * character.h: Adjust decls to match defn changes elsewhere.
3754 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3755 (Ffind_charset_region):
3756 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3757 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3758 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3759 Don't assume fixnum fits in int.
d311d28c
PE
3760 (load_charset_map_from_vector, Fmap_charset_chars):
3761 Remove now-unnecessary CHECK_NATNUMs.
3762 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3763 Don't rely on undefined behavior with signed left shift overflow.
3764 Don't assume unsigned int fits into fixnum, or that fixnum fits
3765 into unsigned int. Don't require max_code to be a valid fixnum;
3766 that's not true for gb10830 4-byte on a 32-bit host. Allow
3767 invalid_code to be a cons, for the same reason. Require code_offset
3768 to be a character. Avoid int overflow if max_char is close
3769 to INT_MAX.
3770 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3771 this is intended anyway and avoids some undefined behavior.
3772 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3773 INDEX_TO_CODE_POINT, as that's what it expects.
3774 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3775 * charset.h (DECODE_CHAR): Return int, not unsigned;
3776 this is what was intended anyway, and it avoids undefined behavior.
3777 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3778 integer-overflow issues.
3779 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3780 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3781 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3782 * chartab.c (Fmake_char_table, Fset_char_table_range)
3783 (uniprop_get_decoder, uniprop_get_encoder):
3784 Don't assume fixnum fits in int.
3785 * cmds.c (move_point): New function, that does the gist of
3786 Fforward_char and Fbackward_char, but does so while checking
3787 for integer overflow more accurately.
c96e5d6a 3788 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3789 (Fforward_line, Fend_of_line, internal_self_insert)
3790 (internal_self_insert):
3791 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3792 Fix a FIXME, by checking for integer overflow when calculating
3793 target_clm and actual_clm.
3794 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3795 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3796 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3797 (coding_alloc_by_making_gap, alloc_destination)
3798 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3799 (encode_coding_utf_16, detect_coding_emacs_mule)
3800 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3801 (detect_coding_iso_2022, decode_coding_iso_2022)
3802 (encode_invocation_designation, encode_designation_at_bol)
3803 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3804 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3805 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3806 (encode_coding_ccl, encode_coding_raw_text)
3807 (detect_coding_charset, decode_coding_charset)
3808 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3809 (produce_composition, produce_charset, produce_annotation)
3810 (decode_coding, handle_composition_annotation)
3811 (handle_charset_annotation, consume_chars, decode_coding_gap)
3812 (decode_coding_object, encode_coding_object, detect_coding_system)
3813 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3814 (code_convert_region, code_convert_string)
8f50130c
PE
3815 (Fdefine_coding_system_internal)
3816 (coding_set_source, coding_set_destination):
d311d28c
PE
3817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3818 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3819 (Fdefine_coding_system_internal):
3820 Don't assume fixnums fit in int.
3821 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3822 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3823 (Funencodable_char_position, Fcheck_coding_systems_region)
3824 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3826 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3827 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3828 Don't access memory outside of the args array.
d311d28c 3829 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3830 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3831 result of ENCODE_CHAR.
d311d28c
PE
3832 * coding.h: Adjust decls to match defn changes elsewhere.
3833 (struct coding_system):
3834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3835 * composite.c (get_composition_id, find_composition)
3836 (run_composition_function, update_compositions)
3837 (compose_text, composition_gstring_put_cache)
3838 (composition_gstring_p, composition_gstring_width)
3839 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3840 (composition_compute_stop_pos, composition_reseat_it)
3841 (composition_update_it, struct position_record)
3842 (find_automatic_composition, composition_adjust_point)
3843 (Fcomposition_get_gstring, Ffind_composition_internal):
3844 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3845 (update_compositions):
3846 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3847 * composite.h: Adjust decls to match defn changes elsewhere.
3848 (struct composition):
3849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3850 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3851 Do not attempt to compute the address of the object just before a
3852 buffer; this is not portable.
3853 (Faref, Faset):
3854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3855 (Faset): Use int, not EMACS_INT, where int is wide enough.
3856 (Fstring_to_number): Don't assume fixnums fit in int.
3857 (Frem): Don't assume arg is nonnegative.
3858 * dbusbind.c (xd_append_arg): Check for integers out of range.
3859 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3860 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3861 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3862 (xd_get_connection_references): Return ptrdiff_t, not int.
3863 All uses changed.
3864 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3865 (xd_read_message_1):
3866 Use int, not unsigned, where the dbus API uses int.
3867 (Fdbus_message_internal): Don't overflow mtype.
3868 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3869 * dired.c (directory_files_internal, file_name_completion, scmp)
3870 (file_name_completion_stat):
3871 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3872 (file_name_completion): Don't overflow matchcount.
3873 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3874 * dispextern.h: Adjust decls to match defn changes elsewhere.
3875 (struct text_pos, struct glyph, struct bidi_saved_info)
3876 (struct bidi_string_data, struct bidi_it, struct composition_it)
3877 (struct it):
3878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3879 (struct display_pos, struct composition_it, struct it):
3880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3881 * dispnew.c (increment_matrix_positions)
3882 (increment_row_positions, mode_line_string)
3883 (marginal_area_string):
3884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3885 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3886 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3887 (duration_to_sec_usec): New function, to check for overflow better.
3888 (Fsleep_for, sit_for): Use it.
3889 * doc.c (get_doc_string, store_function_docstring):
3890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3891 (get_doc_string, Fsnarf_documentation):
3892 Use int, not EMACS_INT, where int is wide enough.
3893 (get_doc_string):
3894 Use SAFE_ALLOCA, not alloca.
3895 Check for overflow when converting EMACS_INT to off_t.
3896 * doprnt.c (doprnt):
3897 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3898 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3899 Don't assume uid_t fits into fixnum.
3900 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3901 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3902 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3903 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3904 (general_insert_function)
3905 (Finsert_char, make_buffer_string, make_buffer_string_both)
3906 (update_buffer_properties, Fbuffer_substring)
3907 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3908 (Fsubst_char_in_region, check_translation)
3909 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3910 (transpose_markers, Ftranspose_regions):
3911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3912 (clip_to_bounds): Move to lisp.h as an inline function).
3913 (Fconstrain_to_field): Don't assume integers are nonnegative.
3914 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3915 (Fsubst_char_in_region, Fsave_restriction):
3916 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3917 (Femacs_pid): Don't assume pid_t fits into fixnum.
3918 (lo_time): Use int, not EMACS_INT, when int suffices.
3919 (lisp_time_argument): Check for usec out of range.
3920 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3921 (Fuser_login_name, Fuser_full_name): Signal an error
3922 if a uid argument is out of range, rather than relying on
3923 undefined behavior.
c8d5c857
PE
3924 (Fformat_time_string): Remove now-unnecessary check.
3925 lisp_time_argument checks for out-of-range usec now.
243e0530 3926 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3927 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3928 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3929 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3930 (init_cmdargs, Fdump_emacs):
3931 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3932 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3933 the bottom (typically) 32 bits of the fixnum.
3934 * eval.c (specpdl_size, call_debugger):
3935 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3936 (when_entered_debugger, Fbacktrace_debug):
3937 Don't assume fixnum can fit in int.
3938 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3939 the object just before a buffer; this is not portable.
3940 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3941 (grow_specpdl, unbind_to):
3942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3943 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3944 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3945 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3946 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3947 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3948 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3949 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3950 (a_write, e_write):
3951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3952 (Fcopy_file, non_regular_nbytes, read_non_regular)
3953 (Finsert_file_contents):
3954 Use int, not EMACS_INT, where int is wide enough.
3955 (READ_BUF_SIZE): Verify that it fits in int.
3956 (Finsert_file_contents): Check that counts are in proper range,
3957 rather than assuming fixnums fit into ptrdiff_t etc.
3958 Don't assume fixnums fit into int.
125b3835 3959 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3960 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3961 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3962 (string_char_to_byte, string_byte_to_char)
3963 (string_make_multibyte, string_to_multibyte)
3964 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3965 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3966 (substring_both, Fdelete, internal_equal, Ffillarray)
3967 (Fclear_string, mapcar1)
3968 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3969 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3970 (larger_vector, make_hash_table, maybe_resize_hash_table)
3971 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3972 (Fmaphash, secure_hash):
3973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3974 (concat): Check for string index and length overflow.
3975 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3976 (Frequire):
3977 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3978 (larger_vector): New API (vec, incr_min, size_max) replaces old
3979 one (vec, new_size, init). This catches size overflow.
3980 INIT was removed because it was always Qnil.
3981 All callers changed.
3982 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3983 the upper bound on a hash table index size.
3984 (make_hash_table, maybe_resize_hash_table): Use it.
3985 (secure_hash): Computer start_byte and end_byte only after
3986 they're known to be in ptrdiff_t range.
3987 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3988 (Ffont_get_glyphs, Ffont_at):
3989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3990 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3991 (Flist_fonts, Fopen_font):
3992 Don't assume fixnum can fit in int.
3993 (check_gstring): Don't assume index can fit in int.
3994 (font_match_p): Check that fixnum is a character, not a nonnegative
3995 fixnum, since the later code needs to stuff it into an int.
3996 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3997 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3998 conversion overflow issues.
3999 (Fopen_font): Check for integer out of range.
4000 (Ffont_get_glyphs): Don't assume index can fit in int.
4001 * font.h: Adjust decls to match defn changes elsewhere.
4002 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4003 integer overflow.
4004 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4005 printmax_t, where ptrdiff_t is wide enough.
4006 (Finternal_char_font):
4007 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4008 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4009 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4010 (Fset_frame_position, x_set_frame_parameters)
4011 (x_set_line_spacing, x_set_border_width)
4012 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4013 Check that fixnums are in proper range for system types.
4014 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4016 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4017 Use SAFE_ALLOCA_LISP, not alloca.
4018 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4019 intptr_t is wide enough.
4020 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4021 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4022 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4023 Check for fixnum out of range.
4024 * ftfont.c (ftfont_list): Don't assume index fits in int.
4025 Check that fixnums are in proper range for system types.
4026 (ftfont_shape_by_flt):
4027 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4028 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4029 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4030 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4031 Check that fixnums are in proper range for system types.
4032 * gnutls.h: Adjust decls to match defn changes elsewhere.
4033 * gtkutil.c (xg_dialog_run):
4034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4035 (update_frame_tool_bar):
4036 Check that fixnums are in proper range for system types.
4037 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4038 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4039 * indent.c (last_known_column, last_known_column_point):
4040 (current_column_bol_cache):
4041 (skip_invisible, current_column, check_display_width):
4042 (check_display_width, scan_for_column, current_column_1)
4043 (Findent_to, Fcurrent_indentation, position_indentation)
4044 (indented_beyond_p, Fmove_to_column, compute_motion):
4045 (Fcompute_motion, Fvertical_motion):
4046 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4047 (last_known_column_modified): Use EMACS_INT, not int.
4048 (check_display_width):
4049 (Fcompute_motion):
4050 Check that fixnums and floats are in proper range for system types.
4051 (compute_motion): Don't assume index or fixnum fits in int.
4052 (compute_motion, Fcompute_motion):
4053 Use int, not EMACS_INT, when it is wide enough.
4054 (vmotion): Omit local var start_hpos that is always 0; that way
4055 we don't need to worry about overflow in expressions involving it.
4056 * indent.h: Adjust decls to match defn changes elsewhere.
4057 (struct position):
4058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4059 Use int, not EMACS_INT, where int is wide enough.
4060 Remove unused members ovstring_chars_done and tab_offset;
4061 all uses removed.
4062 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4063 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4064 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4065 (make_gap, copy_text, insert, insert_and_inherit)
4066 (insert_before_markers, insert_before_markers_and_inherit)
4067 (insert_1, count_combining_before, count_combining_after)
4068 (insert_1_both, insert_from_string)
4069 (insert_from_string_before_markers, insert_from_string_1)
4070 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4071 (adjust_after_replace, adjust_after_insert, replace_range)
4072 (replace_range_2, del_range, del_range_1, del_range_byte)
4073 (del_range_both, del_range_2, modify_region)
4074 (prepare_to_modify_buffer, signal_before_change)
4075 (signal_after_change, Fcombine_after_change_execute):
4076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4077 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4078 (balance_an_interval, split_interval_right, split_interval_left)
4079 (find_interval, next_interval, update_interval)
4080 (adjust_intervals_for_insertion, delete_node, delete_interval)
4081 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4082 (static_offset_intervals, offset_intervals)
4083 (merge_interval_right, merge_interval_left, make_new_interval)
4084 (graft_intervals_into_buffer, temp_set_point_both)
4085 (temp_set_point, set_point, adjust_for_invis_intang)
4086 (set_point_both, move_if_not_intangible, get_property_and_range)
4087 (get_local_map, copy_intervals, copy_intervals_to_string)
4088 (compare_string_intervals, set_intervals_multibyte_1):
4089 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4090 * intervals.h: Adjust decls to match defn changes elsewhere.
4091 (struct interval):
4092 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4093 * keyboard.c (this_command_key_count, this_single_command_key_start)
4094 (before_command_key_count, before_command_echo_length, echo_now)
4095 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4096 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4097 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4098 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4099 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4100 (last_non_minibuf_size, last_point_position, echo_truncate)
4101 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4102 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4103 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4104 (stuff_buffered_input):
4105 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4106 (last_auto_save, command_loop_1, read_char):
4107 Use EMACS_INT, not int, to avoid integer overflow.
4108 (record_char): Avoid overflow in total_keys computation.
4109 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4110 * keyboard.h: Adjust decls to match defn changes elsewhere.
4111 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4112 (Fkey_description, Fdescribe_vector, Flookup_key):
4113 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4114 (click_position): New function, to check that positions are in range.
4115 (Fcurrent_active_maps):
4116 (describe_command):
4117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4118 (Faccessible_keymaps, Fkey_description):
4119 (preferred_sequence_p):
4120 Don't assume fixnum can fit into int.
4121 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4122 Check for integer overflow in size calculations.
4123 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4124 avoid mishandling large integers.
4125 * lisp.h: Adjust decls to match defn changes elsewhere.
4126 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4127 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4128 (struct Lisp_Marker):
4129 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4130 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4131 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4132 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4133 All callers changed.
4134 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4135 Assume the arg has valid form, since it always does.
4136 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4137 unsigned integer system type.
4138 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4139 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4140 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4141 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4142 (duration_to_sec_usec): New decl.
4143 * lread.c (read_from_string_index, read_from_string_index_byte)
4144 (read_from_string_limit, readchar, unreadchar, openp)
4145 (read_internal_start, read1, oblookup):
4146 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4147 (Fload, readevalloop, Feval_buffer, Feval_region):
4148 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4149 (openp): Check for out-of-range argument to 'access'.
4150 (read1): Use int, not EMACS_INT, where int is wide enough.
4151 Don't assume fixnum fits into int.
6efdadfd 4152 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4153 (read_filtered_event): Use duration_to_sec_usec
4154 to do proper overflow checking on durations.
d311d28c
PE
4155 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4156 in size calculation.
4157 (Fexecute_kbd_macro):
4158 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4159 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4160 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4161 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4162 (set_marker_both, set_marker_restricted_both, marker_position)
4163 (marker_byte_position, Fbuffer_has_markers_at):
4164 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4165 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4166 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4167 It now merely ensures that the menu is large enough, without
4168 necessarily growing it, as this avoids some integer overflow issues.
4169 All callers changed.
4170 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4171 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4172 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4173 Use SAFE_ALLOCA_LISP, not alloca.
4174 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4175 to EMACS_INT. Check that fixnums are in proper range for system types.
4176 * minibuf.c (minibuf_prompt_width, string_to_object)
4177 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4178 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4179 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4180 (get_minibuffer, read_minibuf_unwind):
4181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4182 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4183 this simplifies overflow checking. All callers changed.
4184 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4185 (Ftest_completion):
4186 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4187 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4188 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4189 Check that fixnums are in proper range for system types.
4190 (Fx_create_frame, Fx_show_tip):
4191 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4192 * nsfont.m (ns_findfonts, nsfont_list_family):
4193 Don't assume fixnum fits in long.
4194 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4195 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4196 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4197 wide enough.
17fdb222 4198 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4199 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4200 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4201 (PRINTDECLARE, PRINTPREPARE):
4202 (strout, print_string):
4203 (print, print_preprocess, print_check_string_charset_prop)
4204 (print_object):
4205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4206 (PRINTDECLARE):
4207 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4208 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4209 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4210 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4211 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4212 (print_error_message): Use SAFE_ALLOCA, not alloca.
4213 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4214 (print_depth, new_backquote_output, print_number_index):
4215 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4216 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4217 (Fset_process_window_size, Fformat_network_address)
4218 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4219 (sigchld_handler):
d311d28c 4220 Check that fixnums are in proper range for system types.
d44287d4 4221 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4222 Check for process-ids out of pid_t range rather than relying on
4223 undefined behavior.
e4d81efc 4224 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4225 (Fformat_network_address, read_process_output, send_process)
4226 (Fprocess_send_region, status_notify):
4227 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4228 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4229 (wait_reading_process_output, read_process_output, exec_sentinel):
4230 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4231 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4232 (Faccept_process_output): Use duration_to_sec_usec to do proper
4233 overflow checking on durations.
dde14581
PE
4234 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4235 Don't assume pid_t fits in int.
02481186
PE
4236 * process.h (struct Lisp_Process): Members tick and update_tick
4237 are now of type EMACS_INT, not int.
b62b53e8
PE
4238 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4239 configured --with-wide-int.
d311d28c
PE
4240 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4241 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4242 * search.c (looking_at_1, string_match_1):
4243 (fast_string_match, fast_c_string_match_ignore_case)
4244 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4245 (scan_newline, find_before_next_newline, search_command)
4246 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4247 (set_search_regs, wordify):
4248 (Freplace_match):
4249 (Fmatch_data):
4250 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4251 (string_match_1, search_buffer, set_search_regs):
4252 (Fmatch_data):
4253 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4254 (wordify): Check for overflow in size calculation.
4255 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4256 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4257 Check that fixnums are in proper range for system types.
4258 * sound.c (struct sound_device)
4259 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4260 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4261 (Fplay_sound_internal):
4262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4263 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4264 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4265 (Fparse_partial_sexp):
4266 Don't assume fixnums can fit in int.
4267 (struct lisp_parse_state, find_start_pos, find_start_value)
4268 (find_start_value_byte, find_start_begv)
4269 (update_syntax_table, char_quoted, dec_bytepos)
4270 (find_defun_start, prev_char_comend_first, back_comment):
4271 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4272 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4274 (Finternal_describe_syntax_value): Check that match_lisp is a
4275 character, not an integer, since the code stuffs it into int.
4276 (scan_words, scan_sexps_forward):
4277 Check that fixnums are in proper range for system types.
4278 (Fforward_word):
4279 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4280 (scan_sexps_forward):
4281 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4282 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4283 * syntax.h: Adjust decls to match defn changes elsewhere.
4284 (struct gl_state_s):
4285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4286 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4287 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4288 * sysdep.c (wait_for_termination_1, wait_for_termination)
4289 (interruptible_wait_for_termination, mkdir):
4290 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4291 (emacs_read, emacs_write):
4292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4293 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4294 and double all fit in int.
d311d28c
PE
4295 * term.c (set_tty_color_mode):
4296 Check that fixnums are in proper range for system types.
4297 * termhooks.h (struct input_event):
4298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4299 * textprop.c (validate_interval_range, interval_of)
4300 (Fadd_text_properties, set_text_properties_1)
4301 (Fremove_text_properties, Fremove_list_of_text_properties)
4302 (Ftext_property_any, Ftext_property_not_all)
4303 (copy_text_properties, text_property_list, extend_property_ranges)
4304 (verify_interval_modification):
4305 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4306 (Fnext_single_char_property_change)
4307 (Fprevious_single_char_property_change):
4308 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4309 (copy_text_properties):
4310 Check for integer overflow in index calculation.
d311d28c
PE
4311 * undo.c (last_boundary_position, record_point, record_insert)
4312 (record_delete, record_marker_adjustment, record_change)
4313 (record_property_change):
4314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4315 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4317 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4318 (Fx_hide_tip, Fx_file_dialog):
4319 * w32menu.c (set_frame_menubar):
4320 Use ptrdiff_t, not int, for consistency with rest of code.
4321 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4322 (select_window, Fdelete_other_windows_internal)
4323 (window_scroll_pixel_based, window_scroll_line_based)
4324 (Frecenter, Fset_window_configuration):
4325 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4326 (Fset_window_hscroll, run_window_configuration_change_hook)
4327 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4328 (Fscroll_other_window, Frecenter):
d311d28c
PE
4329 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4330 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4331 Don't assume fixnum fits in int.
4332 (Fset_window_scroll_bars):
4333 Check that fixnums are in proper range for system types.
4334 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4335 (string_pos, c_string_pos, number_of_chars, init_iterator)
4336 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4337 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4338 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4339 (face_before_or_after_it_pos, handle_invisible_prop)
4340 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4341 (display_prop_intangible_p, string_buffer_position_lim)
4342 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4343 (get_overlay_strings_1, get_overlay_strings)
4344 (iterate_out_of_display_property, forward_to_next_line_start)
4345 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4346 (get_next_display_element, set_iterator_to_next)
4347 (get_visually_first_element, compute_stop_pos_backwards)
4348 (handle_stop_backwards, next_element_from_buffer)
4349 (move_it_in_display_line_to, move_it_in_display_line)
4350 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4351 (add_to_log, message_dolog, message_log_check_duplicate)
4352 (message2, message2_nolog, message3, message3_nolog
4353 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4354 (current_message_1, truncate_echo_area, truncate_message_1)
4355 (set_message, set_message_1, store_mode_line_noprop)
4356 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4357 (text_outside_line_unchanged_p, check_point_in_composition)
4358 (reconsider_clip_changes)
4359 (redisplay_internal, set_cursor_from_row, try_scrolling)
4360 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4361 (redisplay_window, find_last_unchanged_at_beg_row)
4362 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4363 (trailing_whitespace_p, find_row_edges, display_line)
4364 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4365 (display_mode_element, store_mode_line_string)
4366 (pint2str, pint2hrstr, decode_mode_spec)
4367 (display_count_lines, display_string, draw_glyphs)
4368 (x_produce_glyphs, x_insert_glyphs)
4369 (rows_from_pos_range, mouse_face_from_buffer_pos)
4370 (fast_find_string_pos, mouse_face_from_string_pos)
4371 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4373 (safe_call, init_from_display_pos, handle_fontified_prop)
4374 (handle_single_display_spec, load_overlay_strings)
4375 (with_echo_area_buffer, setup_echo_area_for_printing)
4376 (display_echo_area, echo_area_display)
4377 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4378 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4379 (redisplay_window, dump_glyph_row, display_mode_line)
4380 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4381 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4382 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4383 (handle_single_display_spec, build_desired_tool_bar_string)
4384 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4385 (get_specified_cursor_type):
4386 Check that fixnums are in proper range for system types.
4387 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4388 (Flookup_image_map):
4389 Don't assume fixnums fit in int.
4390 (compare_overlay_entries):
4391 Avoid mishandling comparisons due to subtraction overflow.
4392 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4393 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4394 (handle_tool_bar_click):
4395 Use int, not unsigned, since we prefer signed and the signedness
4396 doesn't matter here.
4397 (get_next_display_element, next_element_from_display_vector):
4398 Use int, not EMACS_INT, when int is wide enough.
4399 (start_hourglass): Use duration_to_sec_usec to do proper
4400 overflow checking on durations.
4401 * xfaces.c (Fbitmap_spec_p):
4402 Check that fixnums are in proper range for system types.
4403 (compare_fonts_by_sort_order):
4404 Avoid mishandling comparisons due to subtraction overflow.
4405 (Fx_family_fonts, realize_basic_faces):
4406 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4407 (Fx_family_fonts):
4408 Don't assume fixnum fits in int.
4409 Use SAFE_ALLOCA_LISP, not alloca.
4410 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4411 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4412 (face_at_buffer_position, face_for_overlay_string)
4413 (face_at_string_position):
4414 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4415 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4416 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4417 (Fx_show_tip):
4418 Check that fixnums are in proper range for system types.
4419 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4420 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4421 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4422 (Fx_change_window_property): Don't assume fixnums fit in int.
4423 * xfont.c (xfont_chars_supported):
4424 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4425 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4426 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4428 * xml.c (parse_region):
4429 * xrdb.c (magic_file_p):
4430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4431 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4432 (x_get_local_selection, x_reply_selection_request)
4433 (x_handle_selection_request, wait_for_property_change):
4434 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4435 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4436 short is wide enough.
4437 (x_send_client_event): Don't assume fixnum fits in int.
4438 * xterm.c (x_x_to_emacs_modifiers):
4439 Don't assume EMACS_INT overflows nicely into int.
4440 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4441 may come from Lisp.
4442 (handle_one_xevent): NATNUMP can eval its arg twice.
4443 (x_connection_closed):
4444 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4445 * xterm.h: Adjust decls to match defn changes elsewhere.
4446 (struct scroll_bar): Use struct vectorlike_header
4447 rather than rolling our own approximation.
4448 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4449
c6574eb5
GM
44502012-05-25 Glenn Morris <rgm@gnu.org>
4451
4452 * lisp.mk (lisp): Update for more files being compiled now.
4453
e8d32c7e
SM
44542012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4455
48def666
SM
4456 * lread.c: Remove `read_pure' which makes no difference.
4457 (read_pure): Remove var.
4458 (unreadpure): Remove function.
4459 (readevalloop): Don't call read_list with -1 flag.
4460 (read1, read_vector): Don't test read_pure any more.
4461 (read_list): Simplify.
4462
e8d32c7e
SM
4463 * fileio.c, character.h: Minor style tweaks.
4464
4b2addb7
DA
44652012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4466
4467 * window.h (clip_changed): Remove useless declaration.
4468
584461b2
JB
44692012-05-22 Juanma Barranquero <lekktu@gmail.com>
4470
4471 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4472 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4473
34374650
PE
44742012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4475
4476 Remove src/m/*.
4477 This directory predates autoconf and is no longer needed nowadays.
4478 Move its few remaining bits of functionality to where they're needed.
4479 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4480 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4481 * m/template.h: Remove.
4482 * Makefile.in (M_FILE): Remove. All uses removed.
4483 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4484 * lisp.h (USE_LSB_TAG):
4485 * mem-limits.h (EXCEEDS_LISP_PTR):
4486 Use VAL_MAX, not VALBITS, in #if.
4487 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4488 (EMACS_UINT): Define unconditionally now.
4489 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4490 (BITS_PER_EMACS_INT): New constants, replacing
4491 what used to be in config.h, but not useful in #if.
4492 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4493 define them any more.
4494 (VAL_MAX): New macro.
4495 (VALMASK): Use it.
4496 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4497 BITS_PER_EMACS_INT, in #if.
4498 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4499 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4500 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4501 * s/ms-w32.h (DATA_START):
4502 Move here from removed file m/intel386.h.
4503 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4504 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4505
261cb4bb
PE
45062012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4507
4508 Assume C89 or later.
4509 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4510 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4511 (xrealloc):
4512 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4513 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4514 * textprop.c, tparam.c (NULL): Remove.
4515 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4516 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4517 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4518 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4519 * xterm.c (input_signal_count): Assume volatile works.
4520
ff23cd9f
KB
45212012-05-21 Ken Brown <kbrown@cornell.edu>
4522
4523 * xgselect.c (xg_select): Fix first argument in call to 'select'
4524 (bug#11508).
4525
1b170bc6
KB
45262012-05-20 Ken Brown <kbrown@cornell.edu>
4527
4528 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4529 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4530
b2f4d39f
KB
45312012-05-19 Ken Brown <kbrown@cornell.edu>
4532
4533 * xfns.c (x_in_use): Remove `static' qualifier.
4534 * xterm.h (x_in_use): Declare.
4535 * xgselect.c: Include xterm.h.
4536 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4537 and `display_arg' (bug#9754).
4538
003fdae2
PE
45392012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4540
9232a6d9
PE
4541 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4542
003fdae2
PE
4543 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4544 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4545
784b56e2
EZ
45462012-05-18 Eli Zaretskii <eliz@gnu.org>
4547
4548 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4549
4550 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4551 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4552
4553 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4554 reference to image_cache->refcount.
4555 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4556
a0a79cde
JL
45572012-05-17 Juri Linkov <juri@jurta.org>
4558
4559 * search.c (Fword_search_regexp, Fword_search_backward)
4560 (Fword_search_forward, Fword_search_backward_lax)
4561 (Fword_search_forward_lax): Move functions to isearch.el
4562 (bug#10145, bug#11381).
4563
b0572523
PE
45642012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4565
4566 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4567
9660f5fc
SM
45682012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4569
4570 * lread.c (init_obarray): Declare Qt and Qnil as special.
4571
4374de83
GM
45722012-05-14 Glenn Morris <rgm@gnu.org>
4573
4574 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4575 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4576
dc44c39a
PE
45772012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4578
078c97cb
PE
4579 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4580
dc44c39a
PE
4581 * unexaix.c: Port to more-recent AIX compilers.
4582 (report_error, report_error_1, make_hdr, copy_sym)
4583 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4584 Make arguments const char *, not char *, to avoid violations of C
4585 standard and to fix some AIX warnings reported by Gilles Pion.
4586
e18afed7 45872012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4588
4589 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4590 already have overlays loaded.
4591 (handle_single_display_spec): Before returning without displaying
4592 fringe bitmap, synchronize the bidi iterator with the main display
4593 iterator, by calling iterate_out_of_display_property.
4594 (iterate_out_of_display_property): Detect buffer iteration by
4595 testing that it->string is a Lisp string.
4596 (get_next_display_element): When the current object is exhausted,
4597 and there's something on it->stack, call set_iterator_to_next to
4598 proceed with what's on the stack, instead of returning zero.
4599 (set_iterator_to_next): If called at the end of a Lisp string,
4600 proceed to consider_string_end without incrementing string
4601 position. Don't increment display vector index past the end of
4602 the display vector. (Bug#11417)
c8fb9dc6
EZ
4603 (pos_visible_p): Don't report a position visible when move_it_to
4604 stopped at the last line of window, which happens to be scanned
4605 backwards by the bidi iteration. (Bug#11464)
ac268e67 4606
e18afed7 46072012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4608
4609 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4610 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4611 are on a TTY, and thus unable to display on the fringes.
4612 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4613 so we need to signal to the caller that this is a "replacing"
4614 display spec. This fixes display when the spec is invalid or we
4615 are on a TTY.
4616
e18afed7 46172012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4618
4619 * unexaix.c (make_hdr): Fix typo in prototype.
4620 This bug broke the build on AIX. Problem reported by Gilles Pion.
4621
9d0a235a
MA
46222012-05-14 Michael Albinus <michael.albinus@gmx.de>
4623
4624 * keyboard.c (kbd_buffer_get_event): Read special events also in
4625 batch mode. (Bug#11415)
4626
9e6b06ed
GM
46272012-05-12 Glenn Morris <rgm@gnu.org>
4628
4629 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4630
c1a1d7a3
EZ
46312012-05-12 Eli Zaretskii <eliz@gnu.org>
4632
4633 * lisp.mk (lisp): Add newcomment.elc.
4634
3fe7cdc8
GM
46352012-05-12 Glenn Morris <rgm@gnu.org>
4636
4637 * Makefile.in (MKDIR_P): New, set by configure.
4638 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4639
53f7d2c0
PE
46402012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4641
4642 Remove unused function hourglass_started.
4643 * dispextern.h (hourglass_started):
4644 * w32fns.c (hourglass_started):
4645 * xdisp.c (hourglass_started): Remove.
4646
75aafb17
JB
46472012-05-10 Juanma Barranquero <lekktu@gmail.com>
4648
4649 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4650 Update dependencies.
4651
12959e8e
PE
46522012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4653
97107e2e
PE
4654 * xgselect.c (xg_select): Put maxfds+1 into a var.
4655 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4656
12959e8e
PE
4657 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4658
836d29b3
DA
46592012-05-10 Dave Abrahams <dave@boostpro.com>
4660
4661 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4662 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4663
5cb67954
MA
46642012-05-09 Michael Albinus <michael.albinus@gmx.de>
4665
4666 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4667 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4668 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4669 Initialize xd_registered_buses.
4670
3478ec45
PE
46712012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4672
b263a6b0
PE
4673 Untag more efficiently if USE_LSB_TAG.
4674 This is based on a proposal by YAMAMOTO Mitsuharu in
4675 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4676 For an admittedly artificial (nth 8000 longlist) benchmark on
4677 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4678 Emacs's overall text size by 1%.
4679 * lisp.h (XUNTAG): New macro.
4680 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4681 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4682 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4683 * eval.c (Fautoload):
4684 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4685 * frame.h (XFRAME): Use XUNTAG.
4686
3478ec45
PE
4687 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4688 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4689 Remove unportable assumptions about print widths of types like
4690 dbus_uint32_t.
4691 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4692 intptr_t when converting between pointer and integer, to avoid GCC
4693 warnings about wrong width.
4694
666b903b 46952012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4696
4697 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4698 stack for each reader_thread, instead of defaulting to 8MB
4699 determined by the linker. This avoids failures in creating
4700 subprocesses on Windows 7, see the discussion in this thread:
4701 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4702
b120cc17
JC
47032012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4704
4705 Fix up display of the *Minibuf-0* buffer in the mini window.
4706 * keyboard.c (read_char): Don't clear the echo area if there's no
4707 message to clear.
4708 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4709 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4710
9a4b36f8
MA
47112012-05-07 Michael Albinus <michael.albinus@gmx.de>
4712
4713 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4714 batch mode.
4715
e5f9458f
CY
47162012-05-06 Chong Yidong <cyd@gnu.org>
4717
4718 * lisp.mk (lisp): Update.
4719
eceeb5fc 47202012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4721
4722 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4723
71873e2b
SM
47242012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4725
4726 * data.c (PUT_ERROR): New macro.
4727 (syms_of_data): Use it. Add new error type `user-error'.
4728 * undo.c (user_error): New function.
4729 (Fprimitive_undo): Use it.
4730 * print.c (print_error_message): Adjust print style for `user-error'.
4731 * keyboard.c (user_error): New function.
4732 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4733
ab0fa4e4
PE
47342012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4735
4736 Do not limit current-time-string to years 1000..9999.
4737 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4738 (Fcurrent_time_string): Support any year that is supported by the
4739 underlying localtime representation. Don't use asctime, as it
4740 has undefined behavior for years outside the range -999..9999.
4741
7ed806a7
PE
47422012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4743
4744 Fix race conditions involving setenv, gmtime, localtime, asctime.
4745 Without this fix, interrupts could mess up code that uses these
4746 nonreentrant functions, since setting TZ invalidates existing
4747 tm_zone or tzname values, and since most of these functions return
4748 pointers to static storage.
4749 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4750 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4751 Grow the critical sections to include not just invoking
4752 localtime/gmtime, but also accessing these functions' results
4753 including their tm_zone values if any, and any related TZ setting.
4754 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4755 so that the struct tm is saved in the critical section.
4756 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4757 motivated by the fact that memory allocation needs to be outside
4758 the critical section.
4759
0c16dfed
DA
47602012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4761
4762 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4763 with RESET_INTERVAL.
4764
4765 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4766 Remove duplicated buffer name initialization.
4767
3f83ace8
JM
47682012-05-02 Jim Meyering <jim@meyering.net>
4769
4770 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4771
c7b8541e
JM
4772 * xfns.c (x_window): Use xstrdup (Bug#11375).
4773
90207a15 47742012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4775
4776 * xdisp.c (pos_visible_p): If already at a newline from the
4777 display string before the 'while' loop, don't walk back the glyphs
4778 from it3.glyph_row. Solves assertion violation when the display
4779 string begins with a newline (egg.el). (Bug#11367)
4780
b593d6a9
AH
47812012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4782
4783 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4784 Move to simple.el.
4785
4737362e
GM
47862012-05-01 Glenn Morris <rgm@gnu.org>
4787
99cf43f9
GM
4788 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4789 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4790 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4791 All were removed before 23.1.
4792
9311dcff
GM
4793 * dispnew.c: Remove HAVE_LIBNCURSES test;
4794 it is always true on relevant platforms.
4795
4d5c6349
GM
4796 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4797 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4798
4737362e
GM
4799 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4800
74dd3a6b
AS
48012012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4802
4803 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4804 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4805 Remove.
4806
13c379ee
PE
48072012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4808
4809 Do not avoid creating empty evaporating overlays (Bug#9642).
4810 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4811 That is, do not delete an evaporating overlay if it becomes
4812 empty after its bounds are adjusted to fit within its buffer.
4813 This fix caused other problems, and I'm reverting it until we get
4814 to the bottom of them.
4815
a8e7d6d7 48162012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4817
4818 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4819
a8e7d6d7 48202012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4821
4822 * xdisp.c (pos_visible_p): If the window start position is beyond
4823 ZV, start the display from buffer beginning. Prevents assertion
4824 violation in init_iterator when the minibuffer window is scrolled
4825 via the scroll bar.
4826
4827 * window.c (window_scroll_pixel_based): Likewise.
4828
a8e7d6d7 48292012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4830
4831 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4832
a8e7d6d7 48332012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4834
4835 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4836 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4837
a8e7d6d7 48382012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4839
b593d6a9
AH
4840 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4841 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4842
1c6900d9
EZ
48432012-04-26 Eli Zaretskii <eliz@gnu.org>
4844
4c3fa1d9
EZ
4845 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4846 display element, check also the underlying string or buffer
4847 character. (Bug#11341)
4848
1c6900d9
EZ
4849 * w32menu.c: Include w32heap.h.
4850 (add_menu_item): If the call to AppendMenuW (via
4851 unicode_append_menu) fails, disable Unicode menus only if we are
4852 running on Windows 9X/Me.
4853
42bf8205
AS
48542012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4855
4856 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4857 (xgetint): Add missing shift for LSB tags.
4858
b1bac16e
MR
48592012-04-24 Martin Rudalics <rudalics@gmx.at>
4860
4861 * keyboard.c (read_char): Don't wipe echo area for select window
4862 events: These might get delayed via `mouse-autoselect-window'
4863 (Bug#11304).
4864
d69621cc
JB
48652012-04-24 Juanma Barranquero <lekktu@gmail.com>
4866
4867 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4868 manipulation of :loaded-from data.
4869
02fd101b
JB
48702012-04-23 Juanma Barranquero <lekktu@gmail.com>
4871
4872 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4873 now a cons (bug#11311).
4874
888bec30
PE
48752012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4876
89a438bd
PE
4877 Do not create empty overlays with the evaporate property (Bug#9642).
4878 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4879 if it becomes empty after its bounds are adjusted to fit within
4880 its buffer. Without this fix, in a nonempty buffer (let ((o
4881 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4882 yields an empty overlay that has the evaporate property, which is
4883 not supposed to happen.
4884
1068fe4d
PE
4885 Fix minor GTK3 problems found by static checking.
4886 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4887 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4888 (struct _EmacsFixedClass, emacs_fixed_get_type):
4889 Move decls here from emacsgtkfixed.h, since they needn't be public.
4890 (emacs_fixed_get_type): Now static.
4891 (emacs_fixed_class_init): Omit unused local.
4892 (emacs_fixed_child_type): Remove; unused.
4893 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4894 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4895 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4896 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4897 (EMACS_FIXED_GET_CLASS): Remove; unused.
4898 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4899
888bec30
PE
4900 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4901 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4902
de85e130
PE
49032012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4904
d0baac98 4905 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4906 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4907 (__malloc_size_t, __malloc_ptrdiff_t):
4908 Remove. All uses removed, replaced by the definiens if needed,
4909 since we can assume C89 or better now.
4910 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4911 (protect_malloc_state, align, get_contiguous_space)
4912 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4913 (malloc_atfork_handler_child, malloc_enable_thread)
4914 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4915 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4916 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4917 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4918 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4919 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4920 Define using prototypes, not old style.
4921 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4922 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4923 (align): Don't assume that signed integer overflow wraps around.
4924 Omit unused local var.
4925 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4926 (_free_internal_nolock, memalign, mallochook, reallochook):
4927 Omit no-longer-needed casts.
4928 (valloc): Use getpagesize, not __getpagesize.
4929 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4930 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4931
de85e130
PE
4932 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4933
dcbf5805
MA
49342012-04-22 Michael Albinus <michael.albinus@gmx.de>
4935
4936 Move functions from C to Lisp. Make non-blocking method calls
4937 the default. Implement further D-Bus standard interfaces.
4938
4939 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4940 (QCdbus_request_name_allow_replacement)
4941 (QCdbus_request_name_replace_existing)
4942 (QCdbus_request_name_do_not_queue)
4943 (QCdbus_request_name_reply_primary_owner)
4944 (QCdbus_request_name_reply_in_queue)
4945 (QCdbus_request_name_reply_exists)
4946 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4947 (QCdbus_registered_serial, QCdbus_registered_method)
4948 (QCdbus_registered_signal): New Lisp objects.
4949 (XD_DEBUG_MESSAGE): Use sizeof.
4950 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4951 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4952 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4953 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4954 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4955 (xd_signature, xd_append_arg): Allow float for integer types.
4956 (xd_get_connection_references): New function.
b593d6a9
AH
4957 (xd_get_connection_address): Rename from xd_initialize.
4958 Return cached address.
dcbf5805
MA
4959 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4960 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4961 level.
4962 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4963 Return number of refcounts.
dcbf5805
MA
4964 (Fdbus_get_unique_name): Make stronger parameter check.
4965 (Fdbus_message_internal): New defun.
4966 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4967 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4968 (Fdbus_send_signal, Fdbus_register_service)
4969 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4970 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4971 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4972 (Vdbus_compiled_version, Vdbus_runtime_version)
4973 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4974 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4975 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4976 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4977 Adapt docstring.
dcbf5805 4978
52828e02
PE
49792012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4980
da05bc4c
PE
4981 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4982 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4983 Do not assume ptrdiff_t is the same width as 'int'.
4984
52828e02
PE
4985 * alloc.c: Handle unusual debugging option combinations.
4986 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4987 since the two debugging options are incompatible.
4988 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4989 is defined.
4990 (mem_init, mem_insert, mem_insert_fixup):
4991 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4992 (NEED_MEM_INSERT): Remove; no longer needed.
4993
f01769f9
LL
49942012-04-22 Leo Liu <sdl.web@gmail.com>
4995
4996 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4997
5790543d
PE
49982012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4999
5000 * sysdep.c [__FreeBSD__]: Minor cleanups.
5001 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5002 Use Emacs indenting style more consistently. Avoid some casts.
5003 Use 'double' consistently rather than mixing 'float' and 'double'.
5004
b91b7e4d
EW
50052012-04-21 Eduard Wiebe <usenet@pusto.de>
5006
b593d6a9
AH
5007 * sysdep.c (list_system_processes, system_process_attributes):
5008 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5009
6114eb15
AS
50102012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5011
5012 * lisp.mk (lisp): Update.
5013
2f38dff7
PE
50142012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5015
5016 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5017 It is never used otherwise.
5018
4ae29f89
SM
50192012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5020
5021 * print.c (print_preprocess): Only check print_depth if print-circle
5022 is nil.
5023 (print_object): Check for cycles even when print-circle is nil and
5024 print-gensym is t, but only check print_depth if print-circle is nil.
5025
f30d612a
CY
50262012-04-20 Chong Yidong <cyd@gnu.org>
5027
5028 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5029 set the status to "failed" and ensure that sentinel is run.
5030
c07a4c0b 50312012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5032
5033 * process.c (Fset_process_inherit_coding_system_flag)
5034 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5035 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5036
c07a4c0b 50372012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5038
5039 * xdisp.c (string_buffer_position_lim): Limit starting position to
5040 BEGV.
5041 (set_cursor_from_row): If called for a mode-line or header-line
5042 row, return zero immediately.
5043 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5044 farther than the first row after the header line, if any.
5045 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5046 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5047
c07a4c0b 50482012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5049
4ae29f89
SM
5050 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5051 (bug#11238).
ad3a2b41 5052
c07a4c0b 50532012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 50542012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5055
5056 configure: new option --enable-gcc-warnings (Bug#11207)
5057 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5058 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5059 (ALL_CFLAGS): Use new macros rather than old.
5060 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5061 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5062 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5063 -Wunused-result, -Wunused-variable. This should go away once
5064 the Emacs and Gnulib regex code is merged.
5065 (xmalloc, xrealloc): Now static.
5066
aba027e8
PE
50672012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5068
5069 * dired.c (Fsystem_groups): Remove unused local.
5070
e5a36063
GM
50712012-04-17 Glenn Morris <rgm@gnu.org>
5072
5073 * dired.c (Fsystem_users): Doc fix.
5074
316411f0
DA
50752012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5076
5077 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5078 (syms_of_dired): Add them.
5079
9426aba4
PE
50802012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5081
b62a57be
PE
5082 Fix minor alloc.c problems found by static checking.
5083 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5084 New extern decls, to avoid calling undeclared functions.
5085 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5086 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5087 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5088 (NEED_MEM_INSERT): New macro.
5089 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5090 Remove one incorrect comment and fix another.
b62a57be 5091
3539f31f
PE
5092 Fix minor ralloc.c problems found by static checking.
5093 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5094 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5095 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5096 (r_alloc_sbrk): Now static.
5097
a041960a
PE
5098 Improve ralloc.c interface checking.
5099 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5100 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5101 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5102 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5103 [REL_ALLOC]: ... to here, to check interface.
5104 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5105 Remove decls. This fixes an "It stinks!".
5106
9426aba4
PE
5107 * alloc.c (which_symbols): Fix alignment issue / type clash.
5108
d55c12ed
AS
51092012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5110
5111 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5112 (struct Lisp_Misc_Any): Likewise.
5113 (struct Lisp_Free): Likewise.
5114 * alloc.c (union aligned_Lisp_Symbol): Define.
5115 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5116 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5117 (union aligned_Lisp_Misc): Define.
5118 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5119 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5120 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5121
b948ce8b
PE
51222012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5123
5124 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5125 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5126 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5127 * s/netbsd.h, s/sol2-6.h:
5128 Remove definition of GC_MARK_STACK, since the default now works.
5129 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5130 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5131 no longer the default.
5132 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5133
35dc09a1 51342012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5135
35dc09a1
GM
5136 * lread.c (lisp_file_lexically_bound_p):
5137 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5138
35dc09a1
GM
51392012-04-14 Eli Zaretskii <eliz@gnu.org>
5140
5141 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5142 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5143
51442012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5145
5146 * nsterm.m (constrainFrameRect): Always constrain when there is only
5147 one screen (Bug#10962).
5148
bcd86815
KB
51492012-04-13 Ken Brown <kbrown@cornell.edu>
5150
5151 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5152
c25df26e
RT
51532012-04-13 Reuben Thomas <rrt@sc3d.org>
5154
5155 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5156
0fc59f1e
DC
51572012-04-11 Daniel Colascione <dancol@dancol.org>
5158
5159 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5160 against is gone. It's better to use vfork now so that when Cygwin
5161 gains a new, working vfork, we use it automatically (bug#10398).
5162
de8c03dc
SM
51632012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5164
5165 * window.c (save_window_save): Obey window-point-insertion-type.
5166
2f097256
GM
51672012-04-11 Glenn Morris <rgm@gnu.org>
5168
5169 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5170
453b951e
SM
51712012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5172
5173 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5174
75f1671a 51752012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5176
5177 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5178 (force_quit_count): New var.
5179 (handle_interrupt): Use it.
5180
2a8ce227
JB
51812012-04-10 Juanma Barranquero <lekktu@gmail.com>
5182
5183 * w32.c (w32_delayed_load): Record the full path of the library
5184 being loaded (bug#10424).
5185
935396c0
GM
51862012-04-09 Glenn Morris <rgm@gnu.org>
5187
05920a43
GM
5188 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5189 not just in the obarray, before snarfing them. (Bug#11036)
5190
935396c0
GM
5191 * Makefile.in ($(leimdir)/leim-list.el):
5192 Pass EMACS rather than BUILT_EMACS.
5193
a18ecafa
TZ
51942012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5195
5196 * process.c (make_process):
5197 * process.h: Add integer `gnutls_handshakes_tried' member to
5198 process struct.
5199
6bbef4e5
JC
5200 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5201 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5202
5203 * gnutls.c (gnutls_log_function2i): Convenience log function.
5204 (emacs_gnutls_read): Use new log functions,
5205 `gnutls_handshakes_tried' process member, and
5206 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5207 attempts per process (connection).
5208
b4d3bc10
CY
52092012-04-09 Chong Yidong <cyd@gnu.org>
5210
5211 * eval.c (Fuser_variable_p, user_variable_p_eh)
5212 (lisp_indirect_variable): Functions deleted.
5213 (Fdefvar): Caller changed.
5214
5215 * callint.c (Finteractive, Fcall_interactively):
5216 * minibuf.c (Fread_variable): Callers changed.
5217
70f4d973
EZ
52182012-04-09 Eli Zaretskii <eliz@gnu.org>
5219
5220 * xdisp.c (set_cursor_from_row): If the display string appears in
5221 the buffer at position that is closer to point than the position
5222 after the display string, display the cursor on the first glyph of
5223 the display string. Fixes cursor display when a 'display' text
5224 property immediately follows invisible text. (Bug#11094)
5225
cb3c2e3e
PE
52262012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5227
5228 composite.c: use 'double' consistently
5229 * composite.c (get_composition_id): Use 'double' consistently
5230 instead of converting 'float' to 'double' and vice versa; this is
5231 easier to understand and avoids a GCC warning.
5232
fd06db5d
GM
52332012-04-09 Glenn Morris <rgm@gnu.org>
5234
50fe702a
GM
5235 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5236 preparation for dumping it with emacs. (Bug#4789)
5237 (leimdir): New variable.
5238 ($(leimdir)/leim-list.el): New rule.
5239 (emacs$(EXEEXT)): Depend on leim-list.el.
5240
fd06db5d
GM
5241 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5242 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5243 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5244
55c131ee
AS
52452012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5246
5247 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5248 proper alignment.
5249
9209588f
JB
52502012-04-07 Juanma Barranquero <lekktu@gmail.com>
5251
5252 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5253 Remove unused local variable.
5254
e3fb2efb
PE
52552012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5256
5257 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5258 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5259 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5260 objects, as mark_maybe_pointer will catch them otherwise.
5261 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5262 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5263
b5385551
PE
52642012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5265
5266 Fix typo that broke non-Windows builds.
5267 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5268
9078ead6
EZ
52692012-04-07 Eli Zaretskii <eliz@gnu.org>
5270
5271 Support building on MS-Windows with libxml2.
5272
5273 * makefile.w32-in (OBJ2): Add xml.$(O).
5274 (GLOBAL_SOURCES): Add xml.c.
5275 ($(BLD)/xml.$(O)): New dependency list.
5276
5277 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5278 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5279 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5280 [!WINDOWSNT]: New macros.
5281 (init_libxml2_functions, libxml2_loaded_p): New functions.
5282 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5283 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5284 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5285 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5286 linked in).
6bbef4e5
JC
5287 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5288 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5289 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5290
5291 * emacs.c: Don't include libxml/parser.h.
5292 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5293 xmlCleanupParser directly.
5294
5295 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5296
3811fdf3
EZ
52972012-04-07 Eli Zaretskii <eliz@gnu.org>
5298
5299 * indent.c (Fvertical_motion): If there is a display string at
5300 point, use it.vpos to compute how many lines to backtrack after
5301 move_it_to point. (Bug#11133)
5302
2f8e16b2
EZ
53032012-04-06 Eli Zaretskii <eliz@gnu.org>
5304
5305 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5306 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5307 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5308 macros related to unification of CJK characters. For the details,
5309 see the discussion following the message here:
5310 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5311
3d439cd1
CY
53122012-04-04 Chong Yidong <cyd@gnu.org>
5313
5314 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5315
8bc53d00
EZ
53162012-04-01 Eli Zaretskii <eliz@gnu.org>
5317
5318 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5319 instead of alloca. (Bug#11138)
5320
3b0512a3
AS
53212012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5322
5323 * w32menu.c (is_simple_dialog): Properly check lisp types.
5324 (Bug#11141)
5325
8427ddd2
EZ
53262012-03-31 Eli Zaretskii <eliz@gnu.org>
5327
979022ef
EZ
5328 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5329 position we get to after a call to move_it_to fails the
5330 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5331 only if we wind up in a string from display property. (Bug#11063)
5332
a6b1c7cc
EZ
5333 * window.c (Fdelete_other_windows_internal): Invalidate the row
5334 and column information about mouse highlight, so that redisplay
5335 restores it after reallocating the glyph matrices. (Bug#7464)
5336
8427ddd2
EZ
5337 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5338 string comes from a `display' text property, use the buffer
5339 position of that property as if we actually saw that position in
5340 the row's glyphs.
697ba24b
EZ
5341 (move_it_by_lines): Remove the assertion that
5342 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5343 violated when there's a before-string at the beginning of a line.
5344 (Bug#11063)
8427ddd2 5345
65a0a738
EZ
53462012-03-30 Eli Zaretskii <eliz@gnu.org>
5347
5348 * xdisp.c (append_space_for_newline): If the default face was
5349 remapped, use the remapped face for the appended newline.
5350 (extend_face_to_end_of_line): Use the remapped default face for
5351 extending the face to the end of the line.
5352 (display_line): Call extend_face_to_end_of_line when the default
5353 face was remapped. (Bug#11068)
5354
581355cc
EZ
53552012-03-29 Eli Zaretskii <eliz@gnu.org>
5356
5357 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5358
e8fc049f
SM
53592012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5360
5361 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5362
4fb9a543
GM
53632012-03-27 Glenn Morris <rgm@gnu.org>
5364
5365 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5366 Doc fixes.
5367
679910f1
KH
53682012-03-26 Kenichi Handa <handa@m17n.org>
5369
5370 * dispextern.h (struct glyph): Fix previous change. Change the
5371 bit length of glyphless.ch to 25 (Bug#11082).
5372
90d49b7f
CY
53732012-03-26 Chong Yidong <cyd@gnu.org>
5374
5375 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5376 (command_loop_1): Use it; inhibit selection update for
5377 handle-select-window too (Bug#8996).
5378
f514f6f0
FP
53792012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5380
e8fc049f 5381 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5382
bf43fa51
KH
53832012-03-25 Kenichi Handa <handa@m17n.org>
5384
5385 * dispextern.h (struct glyph): Change the bit length of
5386 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5387
8a0c01dd
EZ
53882012-03-24 Eli Zaretskii <eliz@gnu.org>
5389
5390 * s/ms-w32.h (tzname): Include time.h before redirecting to
5391 _tzname. Fixes the MSVC build. (Bug#9960)
5392
7d1c3a76
AS
53932012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5394
8ed79523
AS
5395 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5396 characters.
5397
7d1c3a76
AS
5398 * xterm.c (XTread_socket): Only modify handling_signal if
5399 !SYNC_INPUT. (Bug#11080)
5400
e99a9b8b
EZ
54012012-03-23 Eli Zaretskii <eliz@gnu.org>
5402
5403 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5404 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5405 when fetching a multibyte character consumes more bytes than
5406 CHAR_BYTES returns, due to unification of CJK characters in
5407 string_char. (Bug#11073)
5408
5063c0e1
TN
54092012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5410
5411 * process.c (wait_reading_process_output): Handle pty disconnect
5412 by refraining from sending oneself a SIGCHLD (bug#10933).
5413
9f851fbd
CY
54142012-03-22 Chong Yidong <cyd@gnu.org>
5415
5416 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5417
5063c0e1 5418 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5419 Mark string as coming from a prefix property.
5420 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5421 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5422
fb5b8aca
CY
54232012-03-21 Chong Yidong <cyd@gnu.org>
5424
5425 * xfaces.c (Vface_remapping_alist): Doc fix.
5426
62356a1b
EZ
54272012-03-20 Eli Zaretskii <eliz@gnu.org>
5428
5429 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5430 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5431 Doc fixes.
62356a1b 5432
025de85b
CY
54332012-03-20 Chong Yidong <cyd@gnu.org>
5434
5435 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5436 to reflect default non-nil value of redisplay-dont-pause.
5437
4827f94e
KH
54382012-03-19 Kenichi Handa <handa@m17n.org>
5439
5440 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5441 it fit in a valid range (Bug#11003).
5442
e50a24a2
EZ
54432012-03-18 Eli Zaretskii <eliz@gnu.org>
5444
5445 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5446 that is not from display property, accept the row as a "cursor
5447 row" if one of the string's character has a non-nil `cursor'
5448 property. Fixes cursor positioning when there are newlines in
5449 overlay strings, e.g. in icomplete.el. (Bug#11035)
5450
9af5ed87
PE
54512012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5452
5453 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5454
d1f55f16
CY
54552012-03-12 Chong Yidong <cyd@gnu.org>
5456
5457 * eval.c (inhibit_lisp_code): Rename from
5458 inhibit_window_configuration_change_hook; move from window.c.
5459
5460 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5461 * window.c (run_window_configuration_change_hook)
5462 (syms_of_window): Callers changed.
5463
66c5eebd
CY
54642012-03-11 Chong Yidong <cyd@gnu.org>
5465
413df973
CY
5466 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5467
66c5eebd
CY
5468 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5469
1de11f56
CY
54702012-03-10 Chong Yidong <cyd@gnu.org>
5471
5472 * frame.c (other_visible_frames): Don't assume the selected frame
5473 is visible (Bug#10955).
5474
cae07000
SM
54752012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5476
5477 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5478
89c94350
JD
54792012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5480
5481 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5482 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5483 zero (Bug#10954).
5484
999dd333
GM
54852012-03-03 Glenn Morris <rgm@gnu.org>
5486
01a6dcc8 5487 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5488
de0100f2
EZ
54892012-03-02 Eli Zaretskii <eliz@gnu.org>
5490
5491 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5492 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5493 (redisplay_window, next_element_from_string): Fix typos in
5494 comments.
3e441275
EZ
5495 (redisplay_window): Pass to move_it_vertically the margin in
5496 pixels, not in screen lines.
de0100f2 5497
96a72ee9
GM
54982012-03-02 Glenn Morris <rgm@gnu.org>
5499
5500 * buffer.c (buffer-list-update-hook): Doc fix.
5501
312508d7
EZ
55022012-02-29 Eli Zaretskii <eliz@gnu.org>
5503
5504 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5505 push_it before setting up the iterator for the first overlay
5506 string, even if we have an empty string loaded.
5507 (next_overlay_string): If there's an empty string on the iterator
5508 stack, pop the stack. (Bug#10903)
5509
27f3c637
PE
55102012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5511
5512 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5513 Suggested by Stefan Monnier in
5514 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5515 * alloc.c (widen_to_Lisp_Object): New static function.
5516 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5517 and widening them to Lisp_Objects. This would work even if
5518 USE_LSB_TAG is defined and wide integers are used, which might
5519 happen in a future version of Emacs.
5520
3c9dfce6
CY
55212012-02-25 Chong Yidong <cyd@gnu.org>
5522
fa74b241
CY
5523 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5524 Doc fix.
5525
3c9dfce6
CY
5526 * xselect.c (Fx_selection_exists_p): Doc fix.
5527 (x_clipboard_manager_save_all): Print an informative message
5528 before saving to clipboard manager.
5529
9486df08
CY
55302012-02-24 Chong Yidong <cyd@gnu.org>
5531
5532 * keyboard.c (process_special_events): Handle all X selection
5533 requests in kbd_buffer, not just the next one (Bug#8869).
5534
f01d3321
CY
55352012-02-23 Chong Yidong <cyd@gnu.org>
5536
5537 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5538 call when setting menu-bar-lines and tool-bar-lines parameters.
5539 (unwind_create_frame_1): New helper function.
5540
5541 * window.c (inhibit_window_configuration_change_hook): New var.
5542 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5543 (syms_of_window): Initialize it.
f01d3321 5544
86b847b6
CY
55452012-02-22 Chong Yidong <cyd@gnu.org>
5546
5547 * xterm.c (x_draw_image_relief): Add missing type check for
5548 Vtool_bar_button_margin (Bug#10743).
5549
a59225b1
CY
55502012-02-21 Chong Yidong <cyd@gnu.org>
5551
5552 * fileio.c (Vfile_name_handler_alist): Doc fix.
5553
5554 * buffer.c (Fget_file_buffer): Protect against invalid file
5555 handler return value.
5556
310f5bd4
PE
55572012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5558
cb3a28cc
PE
5559 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5560 when computing $valmask.
5561
310f5bd4
PE
5562 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5563 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5564 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5565 It's useless in that case, and it can cause problems on hosts
5566 that allocate halves of EMACS_INT values separately.
5567 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5568 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5569 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5570 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5571 it avoids undefined behavior on hosts where shifting right by more
5572 than the word width has undefined behavior.
5573
2375c96a
CY
55742012-02-19 Chong Yidong <cyd@gnu.org>
5575
5576 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5577 (Funhandled_file_name_directory, Ffile_name_as_directory)
5578 (Fdirectory_file_name, Fexpand_file_name)
5579 (Fsubstitute_in_file_name): Protect against invalid file handler
5580 return values (Bug#10845).
5581
3eb49e71
EZ
55822012-02-18 Eli Zaretskii <eliz@gnu.org>
5583
5584 * .gdbinit (pitx): Fix incorrect references to fields of the
5585 iterator stack.
5586
7b926f3f
CY
55872012-02-17 Chong Yidong <cyd@gnu.org>
5588
5589 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5590
11273115
PE
55912012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5592
5593 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5594 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5595
c3a70e2b
CY
55962012-02-15 Chong Yidong <cyd@gnu.org>
5597
5598 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5599 marked as special. Also, starting docstrings with * is obsolete.
5600
0ca43699
AS
56012012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5602
5603 * gnutls.c (emacs_gnutls_write): Fix last change.
5604
2e8f3c56
LI
56052012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5606
5607 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5608 send_process.
5609
af70074f
SM
56102012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5611
5612 * keymap.c (Fsingle_key_description): Handle char ranges.
5613
95986d52
CY
56142012-02-12 Chong Yidong <cyd@gnu.org>
5615
afd83bd1
CY
5616 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5617 as that creates a dangerous corner case.
5618
95986d52
CY
5619 * window.c (Fdelete_window_internal): Invalidate the mouse
5620 highlight (Bug#9904).
5621
bd7da63e
GM
56222012-02-12 Glenn Morris <rgm@gnu.org>
5623
5624 * xselect.c (Fx_own_selection_internal)
5625 (Fx_get_selection_internal, Fx_disown_selection_internal)
5626 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5627 * nsselect.m (Fx_own_selection_internal)
5628 (Fx_disown_selection_internal, Fx_selection_exists_p)
5629 (Fx_selection_owner_p, Fx_get_selection_internal):
5630 Sync docs and argument specs with the xselect.c versions.
5631
77abcbc2
LI
56322012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5633
5634 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5635
90b671e2
EZ
56362012-02-11 Eli Zaretskii <eliz@gnu.org>
5637
1c0ca0b7
EZ
5638 * w32select.c (Fx_selection_exists_p): Sync doc string and
5639 argument list with xselect.c. (Bug#10783)
5640
5641 * w16select.c (Fx_selection_exists_p): Sync doc string and
5642 argument list with xselect.c. (Bug#10783)
90b671e2 5643
49241268
GM
56442012-02-10 Glenn Morris <rgm@gnu.org>
5645
5646 * fns.c (Fsecure_hash): Doc fix.
5647
f998bbe7 56482012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5649
5650 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5651
0992bd9c
CY
56522012-02-07 Chong Yidong <cyd@gnu.org>
5653
5654 * buffer.c (Fbuffer_local_variables)
5655 (buffer_lisp_local_variables): Handle unbound vars correctly;
5656 don't let Qunbound leak into Lisp.
5657
af008560
GM
56582012-02-07 Glenn Morris <rgm@gnu.org>
5659
dd605cc4
GM
5660 * image.c (Fimagemagick_types): Doc fix.
5661
af008560
GM
5662 * image.c (imagemagick-render-type): Change it from a lisp object
5663 to an integer. Move the doc here from the lisp manual.
5664 Treat all values not equal to 0 the same.
5665
1449fa1d
CY
56662012-02-06 Chong Yidong <cyd@gnu.org>
5667
5668 * doc.c (store_function_docstring): Avoid applying docstring of
5669 alias to base function (Bug#2603).
5670
3723ec07
AS
56712012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5672
5673 * .gdbinit (pp1, pv1): Remove redundant defines.
5674 (pr): Use pp.
5675
79c1cc1e
CY
56762012-02-04 Chong Yidong <cyd@gnu.org>
5677
5678 * nsterm.m: Declare a global (Bug#10694).
5679
d7f29f8e
EZ
56802012-02-04 Eli Zaretskii <eliz@gnu.org>
5681
cae07000
SM
5682 * w32.c (get_emacs_configuration_options):
5683 Include --enable-checking, if specified, in the return value.
d7f29f8e 5684
3b95a6f9
MR
56852012-02-04 Martin Rudalics <rudalics@gmx.at>
5686
5687 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5688 after rounding frame sizes. (Bug#9723)
5689
d6fa96a6
EZ
56902012-02-04 Eli Zaretskii <eliz@gnu.org>
5691
5692 * keyboard.c (adjust_point_for_property): Don't position point
5693 before BEGV. (Bug#10696)
5694
df0b2940
PE
56952012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5696
5697 Handle overflow when computing char display width (Bug#9496).
5698 * character.c (char_width): Return EMACS_INT, not int.
5699 (char_width, c_string_width): Check for overflow when
5700 computing the width; this is possible now that individual
5701 characters can have unbounded width. Problem introduced
5702 by merge from Emacs 23 on 2012-01-19.
5703
6bee44d6
MA
57042012-02-02 Michael Albinus <michael.albinus@gmx.de>
5705
5706 * dbusbind.c (Fdbus_register_method): Mention the return value
5707 :ignore in the docstring.
5708
44f92739
GM
57092012-02-02 Glenn Morris <rgm@gnu.org>
5710
1b9f60cc
GM
5711 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5712
44f92739
GM
5713 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5714 Unconditionally set to t. (Bug#10673)
5715 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5716 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5717 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5718
c5d3843c
KH
57192012-02-02 Kenichi Handa <handa@m17n.org>
5720
5721 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5722 0, do not call append_composite_glyph.
5723
159462d4 57242012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5725
5726 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5727 NULL (Bug#6988).
5728 (x_produce_glyphs): If the component of a composition is a null
5729 string, set it->pixel_width to 1 to avoid zero-width glyph.
5730
78cef877
EZ
57312012-02-01 Eli Zaretskii <eliz@gnu.org>
5732
5733 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5734 first 2 arguments are identical. This makes inserting large
5735 output from a subprocess an order of magnitude faster on
5736 MS-Windows, where all sbrk'ed memory is always contiguous.
5737
97897668
GM
57382012-01-31 Glenn Morris <rgm@gnu.org>
5739
5740 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5741 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5742 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5743
31fd3586
GM
57442012-01-29 Glenn Morris <rgm@gnu.org>
5745
5746 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5747
0e24a8b2
CY
57482012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5749
5750 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5751
cc0adcb0
CY
57522012-01-28 Chong Yidong <cyd@gnu.org>
5753
5754 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5755
acc28cb9
CY
57562012-01-26 Chong Yidong <cyd@gnu.org>
5757
9c69cfb7
CY
5758 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5759
acc28cb9
CY
5760 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5761 repeat counts (Bug#10507).
5762
48da7392
GM
57632012-01-26 Glenn Morris <rgm@gnu.org>
5764
5765 * lread.c (syms_of_lread): Doc fix.
5766
14af5f7f
CY
57672012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5768
5769 * coding.c (encode_designation_at_bol): Change return value to
5770 EMACS_INT.
5771
0b21c100
CY
57722012-01-25 Chong Yidong <cyd@gnu.org>
5773
5774 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5775
3c2907f7
CY
57762012-01-21 Chong Yidong <cyd@gnu.org>
5777
5778 * floatfns.c (Fcopysign): Make the second argument non-optional,
5779 since nil is not allowed anyway.
5780
959ad23f
AS
57812012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5782
5783 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5784 (send_process): Likewise.
5785
34a02f46
MR
57862012-01-19 Martin Rudalics <rudalics@gmx.at>
5787
5788 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5789 (Vwindow_persistent_parameters): Do not use Qstate.
5790 Rewrite doc-strings.
34a02f46 5791
1259009a 57922012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5793
5794 * character.c (char_width): New function.
70d4fdf6
GM
5795 (Fchar_width, c_string_width, lisp_string_width):
5796 Use char_width (Bug#9496).
25ed9e61 5797
6a6ee00d
MR
57982012-01-16 Martin Rudalics <rudalics@gmx.at>
5799
5800 * window.c (Vwindow_persistent_parameters): New variable.
5801 (Fset_window_configuration, save_window_save): Handle persistent
5802 window parameters.
5803
c85efaf7
EZ
58042012-01-14 Eli Zaretskii <eliz@gnu.org>
5805
5806 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5807 thrashing the stack of the thread. (Bug#9087)
5808
5944709e
PE
58092012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5810
5811 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5812
e71f5d99
EZ
58132012-01-11 Eli Zaretskii <eliz@gnu.org>
5814
5815 * xdisp.c (rows_from_pos_range): Handle the case where the
5816 highlight ends on a newline. (Bug#10464)
5817 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5818 he end column for display of highlight that ends on a newline
5819 before a R2L line.
5820
ce316182
GM
58212012-01-11 Glenn Morris <rgm@gnu.org>
5822
5823 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5824 from load-path also when installation-directory is nil. (Bug#10208)
5825
5b43da69
GM
58262012-01-10 Glenn Morris <rgm@gnu.org>
5827
74cc8ff9
GM
5828 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5829
7d8d6e4e
GM
5830 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5831 Update template values to be closer to their typical values these days.
5b43da69 5832
a0db8d43
EZ
58332012-01-09 Eli Zaretskii <eliz@gnu.org>
5834
5835 * xdisp.c (rows_from_pos_range): Accept additional argument
5836 DISP_STRING, and accept any glyph in a row whose object is that
5837 string as eligible for mouse highlight. Fixes mouse highlight of
5838 display strings from overlays. (Bug#10464)
5839
9a0115ab 58402012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5841
b9110d6a 5842 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5843 * fileio.c (auto_saving_dir_umask): New static var.
5844 (Fmake_directory_internal): Use it.
5845 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5846 creating the directory. The old code temporarily assigns
5847 too-generous permissions to the directory.
5848 (do_auto_save_eh): Clear it.
b9110d6a 5849 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5850 that the var is always cleared.
5851
6c1bd3f3
EZ
58522012-01-07 Eli Zaretskii <eliz@gnu.org>
5853
5854 * search.c (scan_buffer): Pass character positions to
5855 know_region_cache, not byte positions. (Bug#6540)
5856
069d2b50
L
58572012-01-07 LynX <_LynX@bk.ru> (tiny change)
5858
5859 * w32.c (sys_rename): Report EXDEV when rename of a directory
5860 fails because the target is on another logical disk. (Bug#10284)
5861
75bf0d33
DB
58622012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5863
5864 * xterm.c (x_embed_request_focus): New function.
5865
5866 * xterm.h: Add prototype.
5867
5868 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5869
1c6e5a32
GM
58702012-01-05 Glenn Morris <rgm@gnu.org>
5871
5872 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5873
651e947e
EZ
58742012-01-01 Eli Zaretskii <eliz@gnu.org>
5875
5876 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5877 Load gnutls_transport_set_lowat only if GnuTLS version is below
5878 2.11.1.
5879 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5880 GnuTLS versions below 2.11.1.
5881
3778cdd8
AL
58822011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5883
5884 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5885 to the doc string advising against its use for altering the way
5886 windows are scrolled.
5887
0e5317f7
KH
58882011-12-28 Kenichi Handa <handa@m17n.org>
5889
5890 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5891 coding-system ASCII compatible only when it does not produce BOM
5892 on encoding (Bug#10383).
5893
93d5ca1f
JD
58942011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5895
5896 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5897 can scroll.
5898 (create_and_show_popup_menu): Always use menu_position_func for
5899 Gtk3 (Bug#10361).
5900
ca22b785
AS
59012011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5902
5903 * callint.c (Fcall_interactively): Don't truncate prompt string.
5904
d048e1e6
EZ
59052011-12-23 Eli Zaretskii <eliz@gnu.org>
5906
5907 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5908 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5909 resumed from there (after widening). (Bug#10360)
d048e1e6 5910
5ccaba1f
JD
59112011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5912
5913 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5914
204ee57f
JD
59152011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5916
b81d40f0
JB
5917 * nsterm.m (x_free_frame_resources):
5918 Release f->output_data.ns->miniimage.
204ee57f
JD
5919 (ns_index_color): Fix indentation. Do not retain
5920 color_table->colors[i].
5921
5922 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5923 before returning.
5924
5925 * nsfns.m (x_set_background_color): Assign return value from
5926 ns_index_color to face-background instead of NSColor*.
5927 (ns_implicitly_set_icon_type): Fix indentation.
5928 Change assignment in for loop to comparison.
5929
5930 * emacs.c (ns_pool): New variable.
5931 (main): Assign ns_pool.
5932 (Fkill_emacs): Call ns_release_autorelease_pool.
5933
5934 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5935 autorelease fdesc, release fdAttrs and tdict.
5936 (ns_get_covering_families): Release charset.
5937 (ns_findfonts): Release NSFontDescriptor created with new.
5938 (ns_uni_to_glyphs): Fix indentation.
5939 (setString): Release attrStr before assigning new value.
5940
c803b2b7
JD
59412011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5942
678f4426
JD
5943 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5944 and NS_IMPL_COCOA.
5945 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5946 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5947
cd394be1 59482011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5949
5fecd5fc
JD
5950 * nsterm.m (ns_term_init): Subscribe for notifications
5951 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5952 to method trackingNotification in EmacsMenu.
5953
5954 * nsmenu.m (trackingMenu): New variable.
3771cb17 5955 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5956 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5957 from Aquamacs (Bug#7030).
678f4426
JD
5958
59592011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5960
c803b2b7
JD
5961 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5962 (symbol_to_nsstring): Fix indentation.
5963 (ns_symbol_to_pb): New function.
cae07000
SM
5964 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5965 (Fns_rotate_cut_buffers_internal): Remove.
5966 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5967 Fns_store_cut_buffer_internal.
5968 (ns_get_foreign_selection, Fx_own_selection_internal)
5969 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5970 (Fns_get_selection_internal, Fns_store_selection_internal):
5971 Use ns_symbol_to_pb and check if return value is nil.
5972 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5973 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5974 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5975 renamed to Sns_store_selection_internal.
5976 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5977 and remove this function.
5978 (ns_handle_selection_clear): Remove, never used.
5979 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5980 here.
5981
e1b01a3a
KB
59822011-12-17 Ken Brown <kbrown@cornell.edu>
5983
5984 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5985 GID is unknown (Bug#10257).
5986
2adb6e85
PE
59872011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5988
5989 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5990 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5991 which caused a build failure on GNU/Linux IA-64. This problem was
5992 introduced by my 2011-10-07 patch.
5993
d1d7b339
JL
59942011-12-15 Juri Linkov <juri@jurta.org>
5995
5996 * image.c (imagemagick_error): New function. (Bug#10112)
5997 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5998 Use `imagemagick_error' where ImageMagick functions return
5999 `MagickFalse'.
6000 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6001 proper order.
6002
100d5755
KH
60032011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6004
6005 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6006 fill background (Bug#8992).
6007
454592a6
MR
60082011-12-13 Martin Rudalics <rudalics@gmx.at>
6009
6010 * window.c (Vwindow_combination_resize)
6011 (Vwindow_combination_limit): Use t instead of non-nil in
6012 doc-strings.
61d4b438
MR
6013 (Vrecenter_redisplay): Add first sentence of doc-string on
6014 separate line.
53524d93 6015 (Frecenter): Fix doc-string typo.
454592a6 6016
3633e3aa
KH
60172011-12-11 Kenichi Handa <handa@m17n.org>
6018
6019 * coding.c (Funencodable_char_position): Pay attention to the
6020 buffer text relocation (Bug#9389).
6021
7b9d523a 60222011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6023
7b9d523a
JD
6024 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6025 gtk_init (Bug#10100).
6026
b73189c6
EZ
60272011-12-10 Eli Zaretskii <eliz@gnu.org>
6028
6029 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6030 IT->string is nil. (Bug#10263)
6031
f7dfe5d6
JD
60322011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6033
83faebb4
JD
6034 * nsterm.h (x_free_frame_resources): Declare.
6035
f7dfe5d6
JD
6036 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6037 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6038
6039 * nsterm.h (ns_get_defaults_value): Declare.
6040
6041 * nsterm.m (ns_default): Call ns_get_defaults_value.
6042
7cd4e72c
EZ
60432011-12-09 Eli Zaretskii <eliz@gnu.org>
6044
6045 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6046 (Bug#10170)
6047
b34d7317
YM
60482011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6049
6050 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6051 that where the value of an _OBJC_* symbol points to is in the .bss
6052 section (Bug#10240).
6053
76470ad1
KH
60542011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6055
6056 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6057 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6058
745fff94
KH
60592011-12-08 Kenichi Handa <handa@m17n.org>
6060
6061 * ftfont.c (get_adstyle_property): Fix previous change
6062 (Bug#10233).
6063
6e44397c
JB
60642011-12-07 Juanma Barranquero <lekktu@gmail.com>
6065
6066 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6067 dirs from the default value of EMACSLOADPATH (bug#10208).
6068
7efa6272
GM
60692011-12-07 Glenn Morris <rgm@gnu.org>
6070
6071 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6072 installation and source directories as well. (Bug#10208)
6073
f6fc4d87
CY
60742011-12-06 Chong Yidong <cyd@gnu.org>
6075
6076 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6077
2bf26180
GM
60782011-12-06 Glenn Morris <rgm@gnu.org>
6079
6080 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6081 as an error, not just -1. (Bug#10217)
6082
3a6ad4f0
CY
60832011-12-05 Chong Yidong <cyd@gnu.org>
6084
6085 * keyboard.c (process_special_events): New function.
6086 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6087
75a3b399
PE
60882011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6089
6090 * coding.c (encode_designation_at_bol): Don't use uninitialized
6091 local variable (Bug#9318).
6092
c3c9e25e
KH
60932011-12-05 Kenichi Handa <handa@m17n.org>
6094
6095 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6096 return Qnil (Bug#8046, Bug#10193).
6097
5eb05ea3
KH
60982011-12-05 Kenichi Handa <handa@m17n.org>
6099
6100 * coding.c (encode_designation_at_bol): New args charbuf_end and
6101 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6102 (coding_set_source): Return how many bytes coding->source was
6103 relocated.
6104 (coding_set_destination): Return how many bytes
6105 coding->destination was relocated.
6106 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6107 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6108
61092011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6110
6111 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6112 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6113 macro (Bug#9318).
6114
61152011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6116
6117 The following changes are to fix Bug#9318.
6118
a79703f5 6119 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6120 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6121 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6122 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6123
7dbda6df
JB
61242011-12-05 Juanma Barranquero <lekktu@gmail.com>
6125
6126 * lisp.h (process_quit_flag): Fix external declaration.
6127
6d5eb5b0
SM
61282011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6129
6130 Don't macro-inline non-performance-critical code.
6131 * eval.c (process_quit_flag): New function.
6132 * lisp.h (QUIT): Use it.
6133
a0c3fad0
JD
61342011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6135
6136 * nsfns.m (get_geometry_from_preferences): New function.
6137 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6138
6c07aac2
AS
61392011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6140
6141 * emacs.c (Qkill_emacs): Define.
6142 (syms_of_emacs): Initialize it.
6143 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6144 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6145 (quit_throw_to_read_char): Add parameter `from_signal'.
6146 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6147 * lisp.h (QUIT): Call Fkill_emacs if requested.
6148
c052ead4
JD
61492011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6150
6151 * widget.c (update_wm_hints): Return if wmshell is null.
6152 (widget_update_wm_size_hints): New function.
6153
6154 * widget.h (widget_update_wm_size_hints): Declare.
6155
6156 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6157 widget_update_wm_size_hints (Bug#10104).
6158
9e49252b
EZ
61592011-12-03 Eli Zaretskii <eliz@gnu.org>
6160
6161 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6162 before a newline, prepare the bidi iterator for consuming the
6163 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6164 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6165
02b16839
JL
61662011-12-02 Juri Linkov <juri@jurta.org>
6167
6168 * search.c (Fword_search_regexp): New Lisp function created from
6169 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6170 (Fword_search_backward, Fword_search_forward)
6171 (Fword_search_backward_lax, Fword_search_forward_lax):
6172 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6173 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6174
0068070e
SM
61752011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6176
6177 * fileio.c (Finsert_file_contents): Move after-change-function call
6178 to before the "handled:" label, since all "goto handled" appear in
6179 cases where the *-change-functions have already been properly called
6180 (bug#10117).
6181
3360a3fc
AS
61822011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6183
6184 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6185 waiting for input. (Bug#10169)
6186
73d6c093
EZ
61872011-11-30 Eli Zaretskii <eliz@gnu.org>
6188
6189 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6190 verifies glyph row's hash code--we have just reallocated the
6191 glyphs, so their contents can be complete garbage. (Bug#10164)
6192
febe6bea
JB
61932011-11-30 Juanma Barranquero <lekktu@gmail.com>
6194
6195 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6196
801a4313
EZ
61972011-11-30 Eli Zaretskii <eliz@gnu.org>
6198
6199 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6200 attributes are tested _before_ calling verify_row_hash, to protect
6201 against GCC re-ordering of the tests. (Bug#10164)
6202
2b56b87e
JD
62032011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6204
6205 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6206
6207 * xterm.c (handle_one_xevent): Only set async_visible and friends
6208 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6209 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6210 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6211
dbf31225
PE
62122011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6213
6214 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6215 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6216 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6217 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6218 All uses changed to use GCPRO1 etc.
6219 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6220 Revert to old implementation (i.e., before 2011-03-11).
6221
1305621b
YM
62222011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6223
6224 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6225 of scroll runs so as to avoid assigning disabled bogus rows and
6226 unnecessary graphics copy operations.
6227
8c9afb46
EZ
62282011-11-27 Eli Zaretskii <eliz@gnu.org>
6229
6230 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6231 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6232 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6233 (malloc, free, realloc, calloc): Redirect to e_* only when
6234 compiling Emacs.
6235
6236 * lisp.h (GCTYPEBITS): Move before first use.
6237 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6238 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6239 this macro definition.
6240
6241 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6242 _MSC_VER.
6243
54e9e3bf
JD
62442011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6245
6d5eb5b0
SM
6246 * gtkutil.c (xg_create_frame_widgets):
6247 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6248 present with Gtk+ 2.0.
6249
83aca1cb
PE
62502011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6251
6252 * fileio.c (Finsert_file_contents): Undo previous change; see
6253 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6254
5b76caa4
PE
62552011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6256
6257 Rename locals to avoid shadowing.
6258 * fileio.c (Finsert_file_contents):
6259 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6260 * process.c (wait_reading_process_output):
6261 Rename inner 'proc' to 'p' to avoid shadowing.
6262 Indent for consistency with usual Emacs style.
6263
8c535114
EZ
62642011-11-25 Eli Zaretskii <eliz@gnu.org>
6265
6266 * xdisp.c (redisplay_window): If cursor row is not fully visible
6267 after recentering, and scroll-conservatively is set to a large
6268 number, scroll window by a few more lines to make the cursor fully
6269 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6270 (start_display): Don't move to the next line if the display should
6271 start at a newline that is part of a display vector or an overlay
6272 string. (Bug#10119)
8c535114 6273
fa4fdb5c
JL
62742011-11-24 Juri Linkov <juri@jurta.org>
6275
6276 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6277 after the `MagickPingImage' call. (Bug#10112)
6278
90ec88df
CY
62792011-11-23 Chong Yidong <cyd@gnu.org>
6280
6281 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6282
56e2e794
MR
62832011-11-23 Martin Rudalics <rudalics@gmx.at>
6284
6285 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6286 making another buffer current. (Bug#10114)
6287
b6e64c41
GM
62882011-11-23 Glenn Morris <rgm@gnu.org>
6289
6290 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6291
6b21de18
CY
62922011-11-23 Chong Yidong <cyd@gnu.org>
6293
6294 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6295 using it (Bug#5984).
6296
b12cd789
EZ
62972011-11-22 Eli Zaretskii <eliz@gnu.org>
6298
6299 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6300 and header-lines, as they don't have one computed for them.
6301 (Bug#10098)
6302
6303 * .gdbinit (prow): Make displayed values more self-explaining.
6304 Add row's hash code.
6305
261b6fd4
LMI
63062011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6307
6308 * process.c (wait_reading_process_output): Fix asynchrounous
6309 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6310 (wait_reading_process_output): Add comment and URL.
261b6fd4 6311
e7cfd277
JD
63122011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6313
6314 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6315
a9b9b7f5
CY
63162011-11-21 Chong Yidong <cyd@gnu.org>
6317
6318 * window.c (Fnext_window, Fprevious_window): Doc fix.
6319
b0d15b4f
SM
63202011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6321
6322 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6323
fe7a3057
JB
63242011-11-20 Juanma Barranquero <lekktu@gmail.com>
6325
6326 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6327
d2999b1a
MR
63282011-11-20 Martin Rudalics <rudalics@gmx.at>
6329
6330 * window.c (Fset_window_combination_limit): Rename argument
6331 STATUS to LIMIT.
6332 (Vwindow_combination_limit): Remove "status" from doc-string.
6333
d5ff9cd0
AS
63342011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6335
6336 * m/ibms390.h: Remove.
6337 * m/ibms390x.h: Don't include "ibms390.h".
6338
a5bb9bd3
SM
63392011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6340
6341 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6342 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6343
cd1181db
JB
63442011-11-20 Juanma Barranquero <lekktu@gmail.com>
6345
6346 * casetab.c (Fset_case_table):
6347 * charset.c (Fcharset_after): Fix typos.
6348
615a3b8d 63492011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6350
17e845af
PE
6351 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6352 Otherwise, valgrind does not work on some platforms.
6353 Problem reported by Andreas Schwab in
6a0bf43d
PE
6354 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6355 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6356 is set, removing the need for VIRT_ADDRESS_VARIES.
6357 (PURE_P): Use a more-efficient implementation that needs just one
6358 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6359 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6360 to 4 (xorl, subq, cmpq, setbe).
6361 * alloc.c (pure): Always extern now, since that's the
6362 VIRT_ADDR_VARIES behavior.
6363 (PURE_POINTER_P): Use a single comparison, not two, for
6364 consistency with the new puresize.h.
6365 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6366 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6367 Remove VIRT_ADDR_VARIES no longer needed.
6368
f8fe6f96
EZ
63692011-11-19 Eli Zaretskii <eliz@gnu.org>
6370
6371 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6372 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6373 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6374 behave as if the cursor position were at the window margin.
6375
6376 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6377 and the cursor position is out of bounds, behave as if the cursor
6378 position were at the window margin. (Bug#10075)
6379
df05a53c
CY
63802011-11-18 Chong Yidong <cyd@gnu.org>
6381
6382 * window.c (Fwindow_combination_limit): Make first argument
6383 non-optional, since it is meaningless for live windows like the
6384 selected window.
61ccba97 6385
2071918e
DA
63862011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6387
6388 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6389
b50a28de
SM
63902011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6391
6392 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6393 (graft_intervals_into_buffer): Simplify.
6394
015137db
EZ
63952011-11-18 Eli Zaretskii <eliz@gnu.org>
6396
6397 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6398 hash values of the two rows.
6399 (copy_row_except_pointers): Preserve the used[] arrays and the
6400 hash values of the two rows. (Bug#10035)
68c95424 6401 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6402
6403 * xdisp.c (row_hash): New function, body extracted from
6404 compute_line_metrics.
6405 (compute_line_metrics): Call row_hash, instead of computing the
6406 hash code inline.
6407
6408 * dispnew.c (verify_row_hash): Call row_hash for computing the
6409 hash code of a row, instead of duplicating code from xdisp.c.
6410
6411 * dispextern.h (row_hash): Add prototype.
6412
a2addb04
TH
64132011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6414
6415 * frame.c (delete_frame): Don't delete the terminal when the last
6416 X frame is closed if emacs is built with GTK toolkit.
6417
df85d315
JB
64182011-11-17 Juanma Barranquero <lekktu@gmail.com>
6419
6420 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6421
a0c2d0ae
MR
64222011-11-17 Martin Rudalics <rudalics@gmx.at>
6423
6424 * window.c (Vwindow_splits): Rename to
6425 Vwindow_combination_resize. Suggested by Juri Linkov.
6426 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6427 of Vwindow_splits.
6428
58179cce
JB
64292011-11-16 Juanma Barranquero <lekktu@gmail.com>
6430
7877f373
JB
6431 * nsfns.m (Fns_font_name):
6432 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6433
b6f67890
MR
64342011-11-16 Martin Rudalics <rudalics@gmx.at>
6435
6436 * window.h (window): Rename slot "nest" to "combination_limit".
6437 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6438 (Fset_window_nest): Rename to Fset_window_combination_limit.
6439 (Vwindow_nest): Rename to Vwindow_combination_limit.
6440 (recombine_windows, make_parent_window, make_window)
6441 (Fsplit_window_internal, saved_window)
6442 (Fset_window_configuration, save_window_save): Rename all
6443 occurrences of window_nest to window_combination_limit.
6444
c7015153
JB
64452011-11-15 Juanma Barranquero <lekktu@gmail.com>
6446
6447 * image.c (imagemagick_load_image): Fix typo.
6448
322ad6ec
EZ
64492011-11-14 Eli Zaretskii <eliz@gnu.org>
6450
6451 * xdisp.c (display_line): Move the call to
6452 highlight_trailing_whitespace before the call to
6453 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6454 faces of all the glyphs to compute ROW's hash value.
6455 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6456
f067b8ec
JB
64572011-11-14 Juanma Barranquero <lekktu@gmail.com>
6458
6459 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6460 just return (bug#10044).
6461
1e5b2111
EZ
64622011-11-12 Eli Zaretskii <eliz@gnu.org>
6463
7ef3cbd5
EZ
6464 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6465 with user-defined heap size. Bump the default size of the temacs
6466 heap to 27MB, to avoid memory warning when running temacs.
6467 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6468
1e5b2111
EZ
6469 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6470 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6471 (verify_row_hash) [XASSERTS]: New function.
6472 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6473 that the hash value of glyph rows is correct.
1e5b2111 6474
89d61221
MR
64752011-11-12 Martin Rudalics <rudalics@gmx.at>
6476
6477 * window.h (window): Remove splits slot.
6478 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6479 (Fdelete_other_windows_internal, make_parent_window)
6480 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6481 (Fset_window_configuration, save_window_save): Don't deal with
6482 split status of windows.
6483 (saved_window): Remove splits slot.
6484 (Vwindow_splits): Rewrite doc-string.
6485
97f18cc8
JD
64862011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6487
6488 * xfns.c (unwind_create_frame):
6489 * nsfns.m (unwind_create_frame):
6490 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6491 Vframe_list (Bug#9999).
6492
22a648b4
DA
64932011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6494
0b381c7e 6495 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6496
659afede
KH
64972011-11-11 Kenichi Handa <handa@m17n.org>
6498
6499 * callproc.c (Fcall_process): Set the member dst_multibyte of
6500 process_coding.
6501
9ac0394b
KH
65022011-11-11 Johan Bockgård <bojohan@gnu.org>
6503
6504 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6505 avoid a crash (bug#9496).
6506
2fbdc249
CY
65072011-11-09 Chong Yidong <cyd@gnu.org>
6508
6509 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6510 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6511
ac6b1f81
PE
65122011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6513
6514 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6515
09db192c
PE
65162011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6517
6518 Avoid some portability problems by eschewing 'extern inline' functions.
6519 The trivial performance wins aren't worth the portability hassles; see
6520 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6521 et seq.
6522 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6523 (window_box_width, window_box_left, window_box_left_offset)
6524 (window_box_right, window_box_right_offset): Undo previous change,
6525 by removing the "extern"s.
6526 * intervals.c (adjust_intervals_for_insertion)
6527 (adjust_intervals_for_deletion): Undo previous change,
6528 making these static again.
6529 (offset_intervals, temp_set_point_both, temp_set_point)
6530 (copy_intervals_to_string): No longer inline.
6531 * xdisp.c (window_text_bottom_y, window_box_width)
6532 (window_box_height, window_box_left_offset)
6533 (window_box_right_offset, window_box_left, window_box_right)
6534 (window_box): No longer inline.
6535
105216ed
CY
65362011-11-08 Chong Yidong <cyd@gnu.org>
6537
6538 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6539 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6540 Signal an error if not a live window.
105216ed
CY
6541 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6542 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6543
ae9e237f
JB
65442011-11-07 Juanma Barranquero <lekktu@gmail.com>
6545
6546 * lisp.h (syms_of_abbrev): Remove declaration.
6547 Reported by CHENG Gao <chenggao@royau.me>.
6548
c7aa8333
EZ
65492011-11-07 Eli Zaretskii <eliz@gnu.org>
6550
6551 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6552 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6553 of temacs in GUI mode.
6554
be7f5545
MR
65552011-11-07 Martin Rudalics <rudalics@gmx.at>
6556
6557 * window.h: Declare delete_all_child_windows instead of
6558 delete_all_subwindows.
6559 * window.c (Fwindow_nest, Fset_window_nest)
6560 (Fset_window_new_total, Fset_window_new_normal)
6561 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6562 (delete_all_subwindows): Rename to delete_all_child_windows.
6563 (Fdelete_other_windows_internal, Fset_window_configuration):
6564 Call delete_all_child_windows instead of delete_all_subwindows.
6565 * frame.c (delete_frame): Call delete_all_child_windows instead
6566 of delete_all_subwindows.
6567
ca78dc43
PE
65682011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6569
6570 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6571 This is also needed for porting to any host where GC_MARK_STACK is
6572 not GC_MAKE_GCPROS_NOOPS.
6573 (which_symbols): Use it.
6574
a0241d01
KH
65752011-11-07 Kenichi Handa <handa@m17n.org>
6576
6577 * coding.c (coding_set_destination): Check coding->src_pos only
6578 when coding->src_object is a buffer (bug#9910).
6579
6580 * process.c (send_process): Set the member src_multibyte of coding
6581 to 0 (bug#9911) when sending a unibyte text.
6582
6583 * callproc.c (Fcall_process): Set the member src_multibyte of
6584 process_coding to 0 (bug#9912).
6585
a64bfdfa 65862011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6587
6588 * xmenu.c (cleanup_widget_value_tree): New function.
6589 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6590 calling free_menubar_widget_value_tree directly (Bug#9830).
6591
cb41b32a
PE
65922011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6593
6594 Fix some portability problems with 'inline'.
6595 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6596 (window_box_width, window_box_left, window_box_left_offset)
6597 (window_box_right, window_box_right_offset): Declare extern.
6598 Otherwise, these inline functions do not conform to C99 and
6599 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6600 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6601 * intervals.c (adjust_intervals_for_insertion)
6602 (adjust_intervals_for_deletion): Now extern, because otherwise the
6603 extern inline functions 'offset_intervals' couldn't refer to it.
6604 (static_offset_intervals): Remove.
6605 (offset_intervals): Rewrite using the old contents of
6606 static_offset_intervals. The old version didn't conform to C99
6607 because an extern inline function contained a reference to an
6608 identifier with static linkage.
6609
b7041366
AS
66102011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6611
6612 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6613 GC.
6614
88a37c4d
EZ
66152011-11-06 Eli Zaretskii <eliz@gnu.org>
6616
6617 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6618 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6619 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6620 return Qleft_to_right.
6621
49745b39
CY
66222011-11-06 Chong Yidong <cyd@gnu.org>
6623
6624 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6625 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6626 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6627 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6628 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6629 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6630 (Fwindow_vscroll): Doc fix.
6631 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6632 argument, since it makes no sense to pass a live window and for
6633 consistency with window-child.
6634
1f05cd82
CS
66352011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6636
6637 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6638 support MSVC.
6639
22610910
JR
66402011-11-05 Jason Rumney <jasonr@gnu.org>
6641
6642 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6643 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6644 fonts (Bug#6029).
6645 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6646 bitwise arithmetic preventing use of unicode-sip and non-truetype
6647 opentype fonts.
6648
a06776b2
EZ
66492011-11-05 Eli Zaretskii <eliz@gnu.org>
6650
3ad924ba
EZ
6651 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6652 "emacs"-only part.
6653
a06776b2
EZ
6654 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6655 initialization code to keep similarity to xfns.c after changes
6656 from 2011-11-05.
6657
c9e7db78
JD
66582011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6659
a97f8f3f
JD
6660 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6661 (unwind_create_frame): New function (Bug#9943).
6662 (Fx_create_frame): Restructure code to be more similar to the one in
6663 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6664 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6665 Move terminal->reference_count++ just before making the frame official
6666 (Bug#9943).
6667
6668 * nsterm.m (x_free_frame_resources): New function.
6669 (x_destroy_window): Move code to x_free_frame_resources.
6670
c9e7db78 6671 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6672 (Fx_create_frame, x_create_tip_frame):
6673 Move terminal->reference_count++ just before making the frame
75f1671a 6674 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6675 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6676
a6fc3b5c
EZ
66772011-11-05 Eli Zaretskii <eliz@gnu.org>
6678
6679 Support MSVC build with newer versions of Visual Studio.
6680 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6681 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6682 nt/gmake.defs.
6683
6684 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6685 which are not supported by MSVC.
6686 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6687 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6688 bitfields.
6689 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6690 types in bitfields.
6691 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6692
6693 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6694
58179cce 66952011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6696
6697 Support MSVC build with newer versions of Visual Studio.
6698 * w32.c: Don't include w32api.h for MSVC.
6699 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6700
6701 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6702 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6703 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6704 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6705 e_* cousins.
6706 (alloca) [_MSC_VER]: Define to _alloca.
6707
6708 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6709
6710 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6711
a58c13ed
EZ
67122011-11-04 Eli Zaretskii <eliz@gnu.org>
6713
6714 * xdisp.c (note_mouse_highlight): If either of
6715 previous/next-single-property-change returns nil, treat that as
6716 the beginning or the end of the buffer. (Bug#9955)
6717
fe0b6370
JD
67182011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6719
a58c13ed 6720 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6721 label is not null (Bug#9951).
6722 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6723 may be NULL.
6724
89bd5ee1
EZ
67252011-11-04 Eli Zaretskii <eliz@gnu.org>
6726
6727 * window.c (Fwindow_body_size): Mention in the doc string that the
6728 return value is in frame's canonical units. (Bug#9949)
6729
84c3edb9
EZ
67302011-11-03 Eli Zaretskii <eliz@gnu.org>
6731
4e2fb5c7
EZ
6732 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6733
84c3edb9 6734 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6735 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6736 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6737
bc17a887
EZ
67382011-11-01 Eli Zaretskii <eliz@gnu.org>
6739
6740 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6741 Don't stop backward scan on the continuation glyph, even though
6742 its CHARPOS is positive.
6d5eb5b0
SM
6743 (mouse_face_from_buffer_pos, note_mouse_highlight):
6744 Rename cover_string to disp_string.
bc17a887 6745
4ee88440
MR
67462011-11-01 Martin Rudalics <rudalics@gmx.at>
6747
6748 * window.c (temp_output_buffer_show): Don't use
6749 Vtemp_buffer_show_specifiers.
6750 (Vtemp_buffer_show_specifiers): Remove unused variable.
6751
c2ff3c02
EZ
67522011-10-30 Eli Zaretskii <eliz@gnu.org>
6753
6754 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6755 past the beginning of the current glyph matrix.
6756
58179cce 67572011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6758
6759 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6760 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6761 HAVE_GTK3 (Bug#9869).
b77a6a7f 6762
3b574623
JD
6763 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6764 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6765
b77a6a7f
JD
6766 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6767
6768 * xterm.c: Declare x_handle_net_wm_state to return int.
6769 (handle_one_xevent): Check if we are iconified but don't have
6770 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6771 (get_current_wm_state): Return non-zero if not hidden,
6772 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6773 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6774 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6775 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6776
196e41e4
PE
67772011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6778
6779 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6780 so that this new function doesn't get optimized away by a
6781 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6782
021f2e1a
AS
67832011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6784
6785 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6786
8b058d44
EZ
67872011-10-29 Eli Zaretskii <eliz@gnu.org>
6788
6789 Fix the `xbytecode' command.
6790 * .gdbinit (xprintbytestr): New command.
b50a28de 6791 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6792 (xbytecode): Print the byte-code string as well.
6793
4452fb80
EZ
67942011-10-29 Kim Storm <storm@cua.dk>
6795
8b058d44
EZ
6796 * alloc.c (which_symbols): New function.
6797
21b72067
AS
67982011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6799
6800 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6801 line. (Bug#9903)
6802
83ed7b5c
GM
68032011-10-29 Glenn Morris <rgm@gnu.org>
6804
6805 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6806 Not clear what it was for, and it causes various bugs. (Bug#9839)
6807
5a7a728b
EZ
68082011-10-28 Eli Zaretskii <eliz@gnu.org>
6809
6810 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6811 possible random value that matches one of those tested as
6812 condition to clear the mouse face.
6813
d3d0842f
CY
68142011-10-28 Chong Yidong <cyd@gnu.org>
6815
6816 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6817
31b39d13
DN
68182011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6819
6820 * window.c (make_window): Initialize phys_cursor_on_p.
6821
9aba6043
SM
68222011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6823
6824 * lisp.h (struct Lisp_Symbol): Update comments.
6825
c20992f4
JB
68262011-10-28 Juanma Barranquero <lekktu@gmail.com>
6827
6828 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6829
db4f02f2
EZ
68302011-10-28 Eli Zaretskii <eliz@gnu.org>
6831
6832 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6833 <oslsachem@gmail.com> for helping to debug this.
6834
6835 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6836 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6837 (g_b_init_get_glyph_outline_w): New static variables.
6838 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6839 (GetGlyphOutlineW_Proc): New typedefs.
6840 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6841 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6842 New functions.
6843 (w32font_open_internal, compute_metrics):
6844 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6845 instead of calling the "wide" APIs directly.
6846
6847 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6848
6849 * w32.h (syms_of_w32font): Add prototype.
6850
87e68db4
JB
68512011-10-27 Juanma Barranquero <lekktu@gmail.com>
6852
6853 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6854 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6855 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6856 (Fmove_to_window_line): Doc fix.
6857
435c1d67
CY
68582011-10-27 Chong Yidong <cyd@gnu.org>
6859
6860 * process.c (make_process): Set gnutls_state to NULL.
6861
6862 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6863 non-NULL, regardless of GNUTLS_INITSTAGE.
6864 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6865 an error. Set process slots as soon as we allocate them.
6866
6867 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6868
9c6c6f49
CY
68692011-10-27 Chong Yidong <cyd@gnu.org>
6870
9aba6043
SM
6871 * gnutls.c (emacs_gnutls_deinit): New function.
6872 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6873 (Fgnutls_deinit, Fgnutls_boot): Use it.
6874
6875 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6876 (deactivate_process): Call emacs_gnutls_deinit.
6877
657d08d3
JB
68782011-10-27 Juanma Barranquero <lekktu@gmail.com>
6879
6880 * image.c (x_create_x_image_and_pixmap):
6881 * w32.c (sys_rename, w32_delayed_load):
6882 * w32font.c (fill_in_logfont):
6883 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6884
5430d399
JB
68852011-10-26 Juanma Barranquero <lekktu@gmail.com>
6886
6887 * w32fns.c (w32_default_color_map): New function,
6888 extracted from Fw32_default_color_map.
a7ef684b 6889 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6890
fe0055fa
PE
68912011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6892
6893 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6894
e6346438
SM
68952011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6896
6897 * keyboard.c (test_undefined): New function (bug#9751).
6898 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6899
e112cc37
ET
69002011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6901
6902 * sysdep.c (init_sys_modes): Fix the check for the controlling
6903 terminal (Bug#6649).
6904
7b5d6677
EZ
69052011-10-20 Eli Zaretskii <eliz@gnu.org>
6906
6907 * dispextern.h (struct bidi_it): New member next_en_type.
6908
6909 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6910 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6911 current character, check also for next_en_type being WEAK_EN.
6912 (bidi_resolve_weak): Don't enter the expensive loop if the current
6913 position is before next_en_pos. Record the bidi type of the first
6914 non-ET, non-BN character we find, in addition to its position.
6915 (bidi_level_of_next_char): Invalidate next_en_type when
6916 next_en_pos is over-stepped.
6917
7da0b018
PE
69182011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6919
6920 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6921 * editfns.c: Rewrite current-time-zone so that it invokes
6922 the equivalent of (format-time-string "%Z") to get the time zone name.
6923 This fixes a bug when the time zone name contains characters that
6924 need converting from the system time locale to Emacs internal format.
6925 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6926 that patch fixed format-time-string to do the conversion, but
6927 I forgot to fix current-time-zone.
6928 (format_time_string): New function, containing most of
6929 what Fformat_time_string used to contain.
6930 (Fformat_time_string): Rewrite in terms of format_time_string.
6931 This doesn't change this function's behavior.
6932 (current-time-zone): Rewrite to use format_time_string.
6933 This fixes the bug reported by Michael Schierl in
6934 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6935 Jason Rumney's 2007-06-07 change worked around this bug, but
6936 didn't fix it.
6937 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6938
8547b010
EZ
69392011-10-19 Eli Zaretskii <eliz@gnu.org>
6940
6941 * xdisp.c (start_display): If the character at POS is displayed
6942 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6943 (try_window_reusing_current_matrix): If a line ends in a display
6944 vector or the next line starts in a display vector, continue
6945 redrawing the window even though the character position of
6946 start_row was reached.
8547b010
EZ
6947 (Bug#9771, part 2)
6948
4e948d15
CY
69492011-10-18 Chong Yidong <cyd@gnu.org>
6950
6951 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6952 with nobreak-char-display too.
6953
4787455f
EZ
69542011-10-18 Eli Zaretskii <eliz@gnu.org>
6955
6956 Fix part 3 of bug#9771.
6957 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6958 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6959 non-neutral characters if the current character is a paragraph
6960 separator (a.k.a. Newline). This avoids running the same
6961 expensive loop twice, once when we consume the preceding newline
6962 and the other time when the line actually needs to be displayed.
6963 Avoid the loop when we see neutrals on the base embedding level
6964 following a character whose directionality is the same as the
6965 paragraph's. This avoids running the expensive loop when a line
6966 ends in a long sequence of neutrals, like control characters.
6967 Add assertion against STRONG_AL type. Slightly rearrange code
6968 that determines the type of a neutral given the first non-neutral
6969 that follows it.
6970 (bidi_level_of_next_char): Set next_en_pos to zero when
6971 invalidating its info.
6972
2c91f553
EZ
69732011-10-17 Eli Zaretskii <eliz@gnu.org>
6974
6975 * xdisp.c (push_display_prop): Determine whether to record string
6976 or buffer position by IT->string, not by IT->method. Allow
6977 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6978 (move_it_vertically_backward): Don't look for character position
6979 immediately after the newline when in a continuation line.
6980 (Bug#9771, part 1)
2c91f553 6981
c7b08b0d
MR
69822011-10-15 Martin Rudalics <rudalics@gmx.at>
6983
6984 * window.c (coordinates_in_window): Rewrite and delabelize
6985 vertical border check. (Bug#5357) (Bug#9618)
6986
6b02f655
SM
69872011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6988
6989 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6990 errors in XSetWindowBorder (bug#9310).
6991
81d40c92
DA
69922011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6993
6994 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6995 avoid crash when xmalloc overrun checking is enabled.
6996
d4172c3b
EZ
69972011-10-13 Eli Zaretskii <eliz@gnu.org>
6998
6999 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7000 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7001 cursor motion with <left> and <right> arrow keys.
7002
7003 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7004 some callers set that themselves.
7005
b00eea75
EZ
70062011-10-12 Eli Zaretskii <eliz@gnu.org>
7007
7008 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7009 display string and the previous row comes from the same string and
7010 is empty. (Bug#9739) (Bug#9738)
7011
8fe012c4
SM
70122011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7013
7014 * doc.c (get_doc_string): Encode file name (bug#9735).
7015
0074aef2
EZ
70162011-10-12 Eli Zaretskii <eliz@gnu.org>
7017
79beb178
EZ
7018 * bidi.c (bidi_level_of_next_char):
7019 * xdisp.c (get_visually_first_element): Remove old incorrect
7020 comments regarding the Unicode Line Separator character.
7021
0074aef2
EZ
7022 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7023
6e4b3fbe
DA
70242011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7025
7026 * alloc.c (Fgc_status): Do not access beyond zombies array
7027 boundary if nzombies > MAX_ZOMBIES.
7028 * alloc.c (dump_zombies): Add missing format specifier.
7029
0324f3af
PE
70302011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7031
b5525cac
PE
7032 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7033 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7034
0324f3af
PE
7035 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7036 Some packages use them to denote characters with modifiers.
7037
e9b5f888
AS
70382011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7039
7040 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7041 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7042 matching a pp-number. Rename parameter var to var1.
7043
127827c0
SM
70442011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7045
7046 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7047
c8fd3bd0
GM
70482011-10-08 Glenn Morris <rgm@gnu.org>
7049
7050 * callint.c (Fcall_interactively): Give a more explicit error for the
7051 'c' case with a non-character input. (Bug#8479)
7052
352ec8ff
EZ
70532011-10-08 Eli Zaretskii <eliz@gnu.org>
7054
03669ccb
EZ
7055 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7056 lines.
7061c986
EZ
7057 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7058 lines that are hscrolled on the left.
03669ccb 7059
352ec8ff
EZ
7060 * dispnew.c (buffer_posn_from_coords): Account for a possible
7061 presence of header-line. (Bug#4426)
7062
a66cfb1c
SM
70632011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7064
6b02f655
SM
7065 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7066 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7067
7c5ee88e
PE
70682011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7069
7070 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7071 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7072 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7073 this makes Emacs dump core during garbage collection on rare
7074 occasions. sizeof is obviously inferior to offsetof here, so
7075 stick with offsetof.
7076 (GC_POINTER_ALIGNMENT): New macro.
7077 (mark_memory): Omit 3rd (offset) arg; caller changed.
7078 Don't assume EMACS_INT alignment is the same as pointer alignment.
7079
df1bbe5b
SM
70802011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7081
7082 * keyboard.c (read_key_sequence_remapped): New var.
7083 (read_key_sequence): Compute remapping in the right buffer.
7084 (command_loop_1): Use read_key_sequence's remapping directly.
7085
51553db6
SM
70862011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7087
32c1fffd
SM
7088 * dired.c (file_name_completion): Don't expand file name.
7089 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7090 before checking file name handler.
7091
51553db6
SM
7092 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7093 they've been requested explicitly (bug#9591).
7094
b6bd1599 70952011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7096
7097 * keymap.c (Fsingle_key_description): Use make_specified_string
7098 instead of build_string to build string from push_key_description.
7099 (Bug#5193)
7100
f701dc2a
PE
71012011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7102
4222c55d
PE
7103 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7104 This fixes a Y2038 bug on 64-bit hosts.
7105 * buffer.c (reset_buffer):
7106 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7107 (Fclear_buffer_auto_save_failure):
7108 Use 0, not -1, to represent an unset failure time, since time_t
7109 might not be signed.
7110
f701dc2a
PE
7111 Remove dependency on glibc malloc internals.
7112 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7113 Move back here from lisp.h, but with their new implementations.
7114 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7115 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7116 * charset.c (charset_table_init): New static var.
7117 (syms_of_charset): Use it instead of xmalloc. This removes a
7118 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7119 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7120 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7121 Move back to alloc.c.
7122 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7123 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7124
9ceebf39
JD
71252011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7126
7127 * nsterm.m (windowDidResize): Call x_set_window_size only when
7128 ns_in_resize is true. Otherwise set pixelwidth/height and
7129 call change_frame_size (Bug#9628).
7130
cb993c58
PE
71312011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7132
3930c88b
PE
7133 Port --enable-checking=all to Fedora 14 x86-64.
7134 * charset.c (syms_of_charset): Also account for glibc malloc's
7135 internal overhead when calculating the initial malloc maximum.
7136
cb993c58
PE
7137 Port --enable-checking=all to Fedora 14 x86.
7138 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7139 Move to lisp.h.
7140 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7141 (overrun_check_realloc, overrun_check_free):
7142 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7143 That way, xmalloc returns a properly-aligned pointer even if
7144 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7145 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7146 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7147 into account when calculating the initial malloc maximum.
7148 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7149 Move here from alloc.c, so that charset.c can use it too.
7150 Properly align; the old code wasn't right for common 32-bit hosts
7151 when configured with --enable-checking=all.
7152 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7153 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7154
31bed486
EZ
71552011-09-29 Eli Zaretskii <eliz@gnu.org>
7156
04c70788 7157 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7158 use EDOM.
7159
fbcaa2f3
EZ
71602011-09-28 Eli Zaretskii <eliz@gnu.org>
7161
7162 * xdisp.c (compute_display_string_end): If there's no display
7163 string at CHARPOS, return -1.
7164
7165 * bidi.c (bidi_fetch_char): When compute_display_string_end
7166 returns a negative value, treat the character as a normal
7167 character not covered by a display string. (Bug#9624)
7168
a239d4e9
JB
71692011-09-28 Juanma Barranquero <lekktu@gmail.com>
7170
7171 * lread.c (Fread_from_string): Fix typo in docstring.
7172
88652fd5
EZ
71732011-09-27 Eli Zaretskii <eliz@gnu.org>
7174
7175 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7176 newline, reseat the iterator instead of bidi-iterating there one
7177 character at a time. (Bug#9610)
32c1fffd
SM
7178 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7179 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7180
ed497dd4
AS
71812011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7182
7183 * lread.c (readevalloop): Use correct code for NBSP.
7184 (read1): Likewise. (Bug#9608)
7185
b2bf61aa
MA
71862011-09-25 Michael Albinus <michael.albinus@gmx.de>
7187
7188 * dbusbind.c (Fdbus_register_signal): When service is not
7189 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7190
32bbb17c
GM
71912011-09-25 Glenn Morris <rgm@gnu.org>
7192
7193 * buffer.c (truncate-lines): Doc fix.
7194
94e0933e
CY
71952011-09-24 Chong Yidong <cyd@stupidchicken.com>
7196
7197 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7198 (Fset_window_next_buffers): Doc fix.
7199
cddde921
GM
72002011-09-24 Glenn Morris <rgm@gnu.org>
7201
7202 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7203
1260aef1
PE
72042011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7205
25b4bfa0
PE
7206 Fix minor problems found by static checking.
7207 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7208 * indent.c (Fvertical_motion): Fix == vs = typo.
7209
e3cbd34b
EZ
72102011-09-24 Eli Zaretskii <eliz@gnu.org>
7211
a66cfb1c
SM
7212 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7213 Default value is now t. Doc fix.
6bf7006f 7214
e3cbd34b 7215 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7216 logic when moving up, not only when moving down. Fix the
e3cbd34b 7217 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7218 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7219
7220 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7221 CHARPOS is covered by a display string which includes newlines.
7222 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7223 is covered by a display string with embedded newlines.
7224
a3de0cbd
MA
72252011-09-24 Michael Albinus <michael.albinus@gmx.de>
7226
7227 * dbusbind.c (Fdbus_register_signal): Add match rule to
7228 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7229 (Fdbus_register_method, Vdbus_registered_objects_table):
7230 Fix docstring.
a3de0cbd 7231
b260039d
JM
72322011-09-24 Jim Meyering <meyering@redhat.com>
7233
32c1fffd 7234 do not ignore write error for any output size
b260039d
JM
7235 The previous change was incomplete.
7236 While it makes emacs --batch detect the vast majority of stdout
7237 write failures, errors were still ignored whenever the output size is
7238 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7239 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7240 && echo FAIL: ignored write error
7241 FAIL: ignored write error
7242 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7243 && echo FAIL: ignored write error
7244 FAIL: ignored write error
7245 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7246
8eca8a7c
AS
72472011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7248
7249 * emacs.c (Fkill_emacs): In noninteractive mode exit
7250 non-successfully if a write error occurred on stdout. (Bug#9574)
7251
3341db62
EZ
72522011-09-21 Eli Zaretskii <eliz@gnu.org>
7253
7254 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7255 the xassert test.
7256
7257 * dispextern.h (struct it): Update the comment documenting what
7258 can it->OBJECT be.
7259
8c203dbf
EZ
72602011-09-20 Eli Zaretskii <eliz@gnu.org>
7261
7262 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7263 a display string, extend search for cursor position to end of row.
7264 (find_row_edges): If the row ends in a newline from a display
7265 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7266 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7267 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7268 non-empty line. Fixes confusing cursor motion with arrow keys at
7269 the beginning of a line that starts with whitespace.
8c203dbf 7270
a4824228
LMI
72712011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7272
7273 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7274 (bug#9493).
7275
33ed493b
CY
72762011-09-18 Chong Yidong <cyd@stupidchicken.com>
7277
7278 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7279 boolean (Bug#9154).
7280
56cd55c8
EZ
72812011-09-18 Eli Zaretskii <eliz@gnu.org>
7282
7283 * xdisp.c (display_line): Record maximum and minimum buffer
7284 positions even if no glyphs were produced (e.g., by a zero-width
7285 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7286 buffer positions that will be removed from the glyph row because
7287 they don't fit.
c02dcedf
EZ
7288 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7289 column is beyond frame width: don't subtract 1 "pixel" when
7290 computing width of the stretch.
3e62b7e0
EZ
7291 (reseat_at_next_visible_line_start): Undo the change made on
7292 2011-09-17 that saved paragraph information and restored it after
7293 the call to `reseat'. (Bug#9545)
56cd55c8 7294
5ed99d36 72952011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7296
7297 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7298 and turn window cursor on if cleared (Bug#9415).
7299
5ed99d36 73002011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7301
7302 * search.c (boyer_moore): Take unibyte characters from pattern
7303 literally. (Bug#9458)
7304
9bade7b2
EZ
73052011-09-18 Eli Zaretskii <eliz@gnu.org>
7306
7307 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7308
e5e9d610
PE
73092011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7310
87e4427a
PE
7311 Fix minor problem found by static checking.
7312 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7313 initialized, to pacify gcc -Wuninitialized.
7314
e5e9d610
PE
7315 * fileio.c: Report proper errno when syscall falls.
7316 (Finsert_file_contents): Save and restore errno,
7317 so that report_file_error outputs the correct diagnostic.
7318 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7319
a1674f0b
EZ
73202011-09-18 Eli Zaretskii <eliz@gnu.org>
7321
7322 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7323
fbfb6dd4
EZ
73242011-09-17 Eli Zaretskii <eliz@gnu.org>
7325
7326 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7327 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7328
bb187662
EZ
73292011-09-17 Eli Zaretskii <eliz@gnu.org>
7330
1137e8b8 7331 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7332 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7333
7334 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7335 (bidi_find_paragraph_start): Search back for paragraph beginning
7336 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7337 (bidi_move_to_visually_next): Only trigger paragraph-related
7338 computations when the last character is a newline or at EOB, not
7339 just any NEUTRAL_B. (Bug#9470)
7340
bb187662
EZ
7341 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7342 truncated lines if point is covered by a display string. (Bug#9524)
7343
2e621251
PE
73442011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7345
7346 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7347 (cons_to_x_long): New function.
7348 (lisp_data_to_selection_data): Use it. Correct the test for
7349 short-versus-long data; it was negated. Break out of vector
7350 loop, for efficiency, when a long datum is discovered.
7351
91a15bc6
SM
73522011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7353
7354 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7355
b41c3a35
EZ
73562011-09-16 Eli Zaretskii <eliz@gnu.org>
7357
7358 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7359 GCC PR/17406) by declaring this function with external scope.
7360
7812ba2d
PE
73612011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7362
7363 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7364 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7365
cf7edc2a
AS
73662011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7367
7368 * editfns.c (Fformat): Correctly handle text properties on "%%".
7369
bd01620e
EZ
73702011-09-15 Eli Zaretskii <eliz@gnu.org>
7371
7372 * xterm.c (x_draw_composite_glyph_string_foreground):
7373 * w32term.c (x_draw_composite_glyph_string_foreground):
7374 * term.c (encode_terminal_code):
7375 * composite.c (composition_update_it, get_composition_id):
7376 * xdisp.c (get_next_display_element)
7377 (fill_composite_glyph_string): Add comments about special meaning
7378 of TAB characters in a composition.
7379
a02719a3
PE
73802011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7381
7382 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7383 This occurs when processing a multibyte format.
7384 Problem reported by Wolfgang Jenker.
a02719a3 7385
72589a3c
JB
73862011-09-15 Johan Bockgård <bojohan@gnu.org>
7387
7388 * xdisp.c (try_cursor_movement): Only check for exact match if
7389 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7390
1c14176c
PE
73912011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7392
7393 Remove unused external symbols.
7394 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7395 * xdisp.c (calc_pixel_width_or_height): Now static.
7396 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7397 * indent.c (check_display_width):
7398 * w32term.c: Fix comment to match code.
7399 * xterm.c, xterm.h (x_catching_errors): Remove.
7400
d2eea5b5
PE
74012011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7402
7403 * xselect.c: Use signed conversions more consistently (Bug#9498).
7404 (selection_data_to_lisp_data): Assume incoming selection data are
7405 signed integers, not unsigned. This is to be consistent with
7406 outgoing selection data, which was modified to use signed integers
7407 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7408 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7409 expects long, not unsigned long.
7410
46888499
EZ
74112011-09-14 Eli Zaretskii <eliz@gnu.org>
7412
7413 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7414 computation of loop end. Reported by Johan Bockgård
7415 <bojohan@gnu.org>.
7416
ef8ef9fb
CY
74172011-09-13 Chong Yidong <cyd@stupidchicken.com>
7418
7419 * frame.c (Fother_visible_frames_p): Function deleted.
7420
fa819fed
EZ
74212011-09-12 Eli Zaretskii <eliz@gnu.org>
7422
7423 * indent.c (compute_motion): Process display vector front to back
7424 rather than the other way around. (Bug#2496)
7425
2ba8e008
SM
74262011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7427
7428 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7429
20f53c69
CY
74302011-09-11 Chong Yidong <cyd@stupidchicken.com>
7431
7432 * minibuf.c (Fread_from_minibuffer): Doc fix.
7433
d562d7a4
EZ
74342011-09-11 Eli Zaretskii <eliz@gnu.org>
7435
7436 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7437 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7438
1c4d7f3d
LMI
74392011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7440
7441 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7442 value for non-existent files.
7443
b885bf36
EZ
74442011-09-11 Eli Zaretskii <eliz@gnu.org>
7445
7446 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7447 set its "size" to -1. This will set the modtime_size field of
7448 the corresponding buffer to -1, which is what
7449 verify-visited-file-modtime expects for files that do not exist.
7450 (Bug#9139)
7451
6612f0bf
PE
74522011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7453
7454 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7455 here ...
7456 * lisp.h: ... from here. push_key_description is no longer
7457 defined in keyboard.c, so its declaration should not be in
7458 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7459 logically belongs with push_key_description.
7460
dfb3f755
PE
74612011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7462
7463 * buffer.h: Include <sys/types.h> instead of <time.h>.
7464 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7465 Problem reported by Herbert J. Skuhra.
7466
3134906c
LMI
74672011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7468
7469 * xml.c (parse_region): Make the parsing work for
7470 non-comment-starting XML files again (bug#9144).
7471
8d903f4e
AS
74722011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7473
7474 * image.c (gif_load): Fix calculation of bottom and right corner.
7475 (Bug#9468)
7476
80ad64f4
EZ
74772011-09-10 Eli Zaretskii <eliz@gnu.org>
7478
7479 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7480 redisplay in small windows.
7481
208a048d
EZ
74822011-09-09 Eli Zaretskii <eliz@gnu.org>
7483
7484 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7485
9b1c252e
MR
74862011-09-08 Martin Rudalics <rudalics@gmx.at>
7487
7488 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7489 Operate on live windows only.
7490
2949f33b
JB
74912011-09-08 Juanma Barranquero <lekktu@gmail.com>
7492
7493 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7494
e08dcafd
EZ
74952011-09-07 Eli Zaretskii <eliz@gnu.org>
7496
7497 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7498 only under bidi iteration.
7499
115b96bd
JD
75002011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7501
7502 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7503
c8199d0f
PE
75042011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7505
7506 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7507 Without this fix, the command to link temacs failed due to an
7508 undefined symbol __builtin_isnan. This is because
7509 /usr/include/iso/math_c99.h #defines isnan(x) to
7510 __builtin_isnan(x), but the bundled gcc, which identifies itself
7511 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7512 a __builtin_isnan.
7513 * floatfns.c (isnan): #undef, and then #define to a clone of
7514 what's in data.c.
7515 (Fisnan): Always define, since it's always available now.
7516 (syms_of_floatfns): Always define isnan at the Lisp level.
7517
e39b275c 75182011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7519
7520 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7521
b2db44d9 75222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7523
f4af5137 7524 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7525 The previous code assumed that file offsets (off_t values) fit in
7526 EMACS_INT variables, which is not true on typical 32-bit hosts.
7527 The code messed up by falsely reporting buffer overflow in cases
7528 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7529 when "big" contains more than 2**29 bytes, even though this
7530 inserts just one byte and does not overflow the buffer.
7531 (Finsert_file_contents): Store file offsets as off_t
7532 values, not as EMACS_INT values. Check for overflow when
7533 converting between EMACS_INT and off_t. When checking for
7534 buffer overflow or for overlap, take the offsets into account.
7535 Don't use EMACS_INT for small values where int suffices.
7536 When checking for overlap, fix a typo: ZV was used where
7537 ZV_BYTE was intended.
7538 (Fwrite_region): Don't assume off_t fits into 'long'.
7539 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7540
ecfc0a49
MA
75412011-09-05 Michael Albinus <michael.albinus@gmx.de>
7542
7543 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7544
6511acf2 75452011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7546
0999621a 7547 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7548
7549 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7550 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7551 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7552 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7553 (modify_event_symbol): Do not assume that the length of
7554 name_alist_or_stem is safe to alloca and fits in int.
7555 (Fexecute_extended_command): Likewise for function name and binding.
7556 (Frecursion_depth): Wrap around reliably on integer overflow.
7557 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7558 since some callers pass EMACS_INT values.
7559 (Fsingle_key_description): Don't crash if symbol name contains more
7560 than MAX_ALLOCA bytes.
7561 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7562 (get_minibuffer): Arg is now EMACS_INT, not int.
7563 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7564 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7565 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7566
2be7d702
PE
7567 * dbusbind.c (signature_cat): New function.
7568 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7569 Do not overrun buffer; instead, report string overflow.
7570
9d1df220
PE
7571 * dispnew.c (add_window_display_history): Don't overrun buffer.
7572 Truncate instead; this is OK since it's just a log.
7573
33ef5c64
PE
7574 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7575 even if the time zone offset is outlandishly large.
7576 Don't mishandle offset == INT_MIN.
7577
66c6fdd5
PE
7578 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7579 when creating daemon; the previous buffer-overflow check was incorrect.
7580
d749b01b
PE
7581 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7582 which has the guts of the old verror function.
7583
b5cd1905
PE
7584 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7585 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7586
6e1a67fb
PE
7587 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7588 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7589 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7590 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7591 length of string rather than counting it via multiple sprintfs;
7592 that's simpler and more reliable.
c21721cc
PE
7593 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7594 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7595 sprintf, in case result does not fit in int.
7596
c57b67fc
PE
7597 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7598 (fontset_from_font): Print it.
7599
8a401434
PE
7600 * frame.c (tty_frame_count): Now printmax_t, not int.
7601 (make_terminal_frame, set_term_frame_name): Print it.
7602 (x_report_frame_params): In X, window IDs are unsigned long,
7603 not signed long, so print them as unsigned.
7604 (validate_x_resource_name): Check for implausibly long names,
7605 and don't assume name length fits in 'int'.
7606 (x_get_resource_string): Don't blindly alloca invocation name;
7607 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7608 not fit in int.
7609
6e1a67fb
PE
7610 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7611 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7612 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7613
0df02bf3
PE
7614 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7615 Use esprintf, not sprintf, in case result does not fit in int.
7616
48e30793
PE
7617 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7618 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7619 it as a large positive number.
7620 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7621 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7622
a66ff6d8
PE
7623 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7624 in case result does not fit in int.
7625
aca216ff
PE
7626 * print.c (float_to_string): Detect width overflow more reliably.
7627 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7628 buffer overrun. Don't assume list length fits in 'int'. Treat
7629 print length of 0 as 0, not as infinity; to be consistent with other
7630 uses of print length in this function. Don't overflow print length
7631 index. Don't assume hash table size fits in 'long', or that
7632 vectorlike size fits in 'unsigned long'.
7633
31c286f7
PE
7634 * process.c (make_process): Use printmax_t, not int, to format
7635 process-name gensyms.
7636
55e5faa1
PE
7637 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7638
80f2e268
PE
7639 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7640 to avoid potential buffer overrun.
7641
670741ab
PE
7642 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7643 if X resource line is longer than 512 bytes.
7644
b7163a50
PE
7645 * xfns.c (x_window): Make sprintf buffer a bit bigger
7646 to avoid potential buffer overrun.
7647
ae58ff1f
PE
7648 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7649
c43c8a6a
PE
7650 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7651
3f8236f4
PE
76522011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7653
53e9fe90 7654 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7655 Without these, Emacs silently mishandles large integers sometimes.
7656 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7657 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7658
6511acf2
PE
7659 * xdisp.c (try_window_id): Check Emacs fixnum range before
7660 converting to 'int'.
806add1d 7661
6511acf2 7662 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7663 Check that an Emacs fixnum is in range before assigning it to 'int'.
7664 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7665 values converted from Emacs fixnums.
7666 (Frecenter): Don't wrap around a line count if it is out of 'int'
7667 range; instead, treat it as an extreme value.
7668 (Fset_window_configuration, compare_window_configurations):
7669 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7670
6511acf2
PE
7671 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7672 that can exceed INT_MAX. Check that EMACS_INT value is in range
7673 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7674 (match_limit): Don't assume that a fixnum can fit in 'int'.
7675
6511acf2 7676 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7677 exceed INT_MAX.
7678
6511acf2 7679 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7680 (Fvertical_motion): Don't wrap around LINES values that don't fit
7681 in 'int'. Instead, treat them as extreme values. This is good
7682 enough for windows, which can't have more than INT_MAX lines anyway.
7683
fcb901a7
LMI
76842011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7685
0f2f6b6d
LMI
7686 * Require libxml/parser.h to avoid compilation warning.
7687
fcb901a7
LMI
7688 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7689
7690 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7691 since this reportedly can destroy thread storage.
7692
6e20a0d4
CY
76932011-08-30 Chong Yidong <cyd@stupidchicken.com>
7694
7695 * syntax.c (find_defun_start): Update all cache variables if
7696 exiting early (Bug#9401).
7697
148ae00e
EZ
76982011-08-30 Eli Zaretskii <eliz@gnu.org>
7699
f6cfbd8f
EZ
7700 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7701
148ae00e
EZ
7702 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7703 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7704 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7705
7706 * term.c (tty_append_glyph): New function.
7707 (produce_stretch_glyph): Static function and its prototype deleted.
7708
a66cfb1c
SM
7709 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7710 Add prototypes.
148ae00e 7711
c4a07a4c
PE
77122011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7713
7714 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7715 when checking :margin (Bug#9390).
7716 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7717 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7718 so that the name doesn't mislead. All uses changed.
7719
6bc8cd65
JB
77202011-08-28 Johan Bockgård <bojohan@gnu.org>
7721
7722 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7723 set_tty_hooks.
7724
dca4927e
EZ
77252011-08-27 Eli Zaretskii <eliz@gnu.org>
7726
7727 * xdisp.c (move_it_to): Don't bail out early when reaching
7728 position beyond to_charpos, if we are scanning backwards.
7729 (move_it_vertically_backward): When DY == 0, make sure we get to
7730 the first character in the line after the newline.
7731
f2cad773
PE
77322011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7733
7734 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7735 (ccl_driver): Do not generate an out-of-range pointer.
7736 (Fccl_execute_on_string): Remove unnecessary check for
7737 integer overflow, noted by Stefan Monnier in
7738 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7739 Remove a FIXME that didn't need fixing.
7740 Simplify the newly-introduced buffer reallocation code.
7741
0cae2cdb
JB
77422011-08-27 Juanma Barranquero <lekktu@gmail.com>
7743
7744 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7745
5fc295a4 77462011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7747
70c60eb2 7748 Integer and memory overflow issues (Bug#9196).
726e0ab1 7749
d31850da
PE
7750 * doc.c (get_doc_string): Rework so that
7751 get_doc_string_buffer_size is the actual buffer size, rather than
7752 being 1 less than the actual buffer size; this makes xpalloc more
7753 convenient.
7754
a69fbedb
PE
7755 * image.c (x_allocate_bitmap_record, cache_image):
7756 * xselect.c (Fx_register_dnd_atom):
7757 Simplify previous changes by using xpalloc.
7758
fe5c5d37
PE
7759 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7760 since either will do and ptrdiff_t is convenient with xpalloc.
7761
0065d054
PE
7762 * charset.c (charset_table_size)
7763 (struct charset_sort_data.priority): Now ptrdiff_t.
7764 (charset_compare): Don't overflow if priorities differ greatly.
7765 (Fsort_charsets): Don't assume list length fits in int.
7766 Check for size-calculation overflow when allocating sort data.
7767 (syms_of_charset): Allocate an initial charset table that is
7768 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7769
7770 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7771
7772 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7773 The actual value is always <= INT_MAX, and leaving it unsigned made
7774 overflow checking harder.
7775
7776 * dispextern.h (struct glyph_matrix.rows_allocated)
7777 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7778 with xpalloc. The values are still always <= INT_MAX.
7779
7780 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7781
7782 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7783 (SAFE_NALLOCA): New macro.
7784
7785 * region-cache.c (struct boundary.pos, find_cache_boundary)
7786 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7787 (set_cache_region, invalidate_region_cache)
7788 (revalidate_region_cache, know_region_cache, region_cache_forward)
7789 (region_cache_backward, pp_cache):
7790 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7791 so that ptrdiff_t * can be passed to xpalloc.
7792 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7793 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7794 (pp_cache): Don't assume cache_len fits in int.
7795 * region-cache.h: Adjust extern decls to match.
7796
7797 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7798 EMACS_INT, since either will do, for xpalloc.
7799
7800 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7801 (xnmalloc, xnrealloc, xpalloc): New functions.
7802
726e0ab1
PE
7803 * bidi.c (bidi_shelve_header_size): New constant.
7804 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7805 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7806
51f30bc5 7807 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7808 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7809 (overlay_strings):
7810 Don't update size of array until after memory allocation succeeds,
7811 because xmalloc/xrealloc may not return.
0065d054
PE
7812 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7813 now that we have proper integer overflow checking.
7814 (record_overlay_string, overlay_strings): Catch overflows when
7815 calculating size of overlay_str_buf.
726e0ab1 7816
0065d054
PE
7817 * callproc.c (Fcall_process): Check for size overflow when
7818 calculating size of args2.
7819 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7820 Normally we prefer signed values, but sticking with ptrdiff_t would
7821 require adding more-complicated checks.
726e0ab1
PE
7822
7823 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7824 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7825 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7826 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7827
7828 * character.c (Fstring): Check for size-calculation overflow.
7829
7830 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7831 unnecessary integer overflow. Check for size overflow.
7832 (encode_coding_object): Don't update size until xmalloc succeeds.
7833
7834 * composite.c (get_composition_id): Check for overflow in glyph
7835 length calculations.
7836
7837 Integer and memory overflow fixes for display code.
7838 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7839 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7840 (scrolling_window): Check for overflow in size calculations.
7841 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7842 Don't assume glyph table len fits in int.
7843 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7844 (row_table_size): Now ptrdiff_t, not int.
7845 (scrolling_window): Avoid overflow in size calculations.
7846 Don't update size until allocation succeeds.
7847 * fns.c (concat): Check for overflow in size calculations.
7848 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7849 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7850 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7851
7852 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7853 (get_doc_string): Check for size calculation overflow.
7854 Don't update size until allocation succeeds.
7855 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7856 EMACS_INT, where ptrdiff_t will do.
7857 (Fsubstitute_command_keys): Check for string overflow.
7858
7859 * editfns.c (set_time_zone_rule): Don't assume environment length
7860 fits in int.
7861 (message_length): Now ptrdiff_t, not int.
7862 (Fmessage_box): Don't update size until allocation succeeds.
7863 Don't assume message length fits in int.
7864 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7865
0065d054
PE
7866 * emacs.c (main): Do not reallocate argv, since there is a null at
7867 the end that can be overwritten, and this way there's no need to
7868 worry about size-calculation overflow.
7869 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7870
7871 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7872 alloc succeeds.
7873 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7874
7875 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7876 (x_set_scroll_bar_width, x_figure_window_size):
7877 Check for integer overflow.
7878 (x_set_alpha): Do not assume XINT fits in int.
7879
7880 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7881 This is for the members text_lines, text_cols, total_lines, total_cols,
7882 where the system imposes an 'int' limit.
7883
7884 * fringe.c (Fdefine_fringe_bitmap):
7885 Don't update size until alloc works.
7886
7887 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7888 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7889
7890 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7891 Check for size-calculation overflow.
7892 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7893 do, as we prefer signed integers.
7894 (id_to_widget.max_size, id_to_widget.used)
7895 (xg_store_widget_in_map, xg_remove_widget_from_map)
7896 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7897 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7898 Use and return ptrdiff_t, not int.
7899 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7900 * gtkutil.h: Change prototypes to match the above.
7901
7902 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7903 are duplicate now that they've been promoted to lisp.h.
7904 (x_allocate_bitmap_record, x_alloc_image_color)
7905 (make_image_cache, cache_image, xpm_load):
7906 Don't update size until alloc is done.
7907 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7908 (x_detect_edges):
3256efce 7909 Check for size calculation overflow.
726e0ab1
PE
7910 (ct_colors_allocated_max): New constant.
7911 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7912 overflow.
3256efce 7913
726e0ab1
PE
7914 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7915 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7916 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7917 Use ptrdiff_t, not int, to count maps.
7918 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7919 calculations. Don't update size until allocation succeeds.
7920 Redo calculations to avoid overflow.
726e0ab1
PE
7921 * keyboard.h: Change prototypes to match the above.
7922
7923 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7924 to count maps.
7925 (current_minor_maps): Check for size calculation overflow.
7926 * keymap.h: Change prototypes to match the above.
7927
7928 * lread.c (read1, init_obarray): Don't update size until alloc done.
7929
7930 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7931 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7932
726e0ab1
PE
7933 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7934 Now ptrdiff_t, not int.
7935 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7936 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7937
7938 * process.c (Fnetwork_interface_list): Check for overflow
7939 in size calculation.
7940
7941 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7942
7943 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7944 overflow. Don't bother calling xmalloc when xrealloc will do.
7945
7946 * search.c (Freplace_match): Check for size calculation overflow.
7947 (Fset_match_data): Don't assume list lengths fit in 'int'.
7948
7949 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7950 for command line length. Do not attempt to address one before the
7951 beginning of an array, as that's not portable.
7952
7953 * term.c (max_frame_lines): Remove; unused.
7954 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7955 not int.
7956 (encode_terminal_code, calculate_costs): Check for size
7957 calculation overflow.
7958 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7959 table lengths and related sizes. Don't update size until alloc
7960 done. Redo calculations to avoid overflow.
7961 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7962
7963 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7964 subtracting pointers.
7965 (gobble_line): Check for overflow more carefully. Don't update size
7966 until alloc done.
7967
7968 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7969 Don't update size until alloc done.
7970 Redo size calculations to avoid overflow.
7971 Check for size calculation overflow.
0065d054 7972 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7973
7974 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7975 Use ptrdiff_t, not int, for sizes.
7976 (store_mode_line_noprop_char): Don't update size until alloc done.
7977
0065d054
PE
7978 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7979 Use ptrdiff_t, not int, for sizes.
7980 (Finternal_make_lisp_face, cache_face):
7981 Check for size calculation overflow.
7982 (cache_face): Treat size calculation overflows as if they were
7983 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7984
7985 * xfns.c (x_encode_text, x_set_name_internal)
7986 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7987 sizes, since they can exceed INT_MAX in size. Check for size
7988 calculation overflow.
7989
0065d054
PE
7990 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7991 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7992 Don't update size until alloc done.
7993
0065d054 7994 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7995 as sprintf is limited to int lengths.
1d526e2f 7996
252c5ee1
PE
7997 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7998 (X_LONG_MIN): New macros.
864d7ce7
PE
7999 Use them to make the following changes clearer.
8000 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8001 This change doesn't affect the value now, but it may help remind
8002 future maintainers not to raise the value too much later.
8003 (SELECTION_QUANTUM): Remove, replacing with ...
8004 (selection_quantum): ... new function, which avoids overflow.
8005 All uses changed.
8006 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8007 assumption that selection length fits in 'int'.
8008 (x_reply_selection_request, x_handle_selection_request)
8009 (x_get_window_property, receive_incremental_selection)
8010 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8011 (lisp_data_to_selection_data, clean_local_selection_data):
8012 Use ptrdiff_t, not int, to record length of selection.
8013 (x_reply_selection_request, x_get_window_property)
8014 (receive_incremental_selection, x_property_data_to_lisp):
8015 Redo calculations to avoid overflow.
8016 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8017 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8018 something.
8019 (x_get_window_property, receive_incremental_selection)
8020 (lisp_data_to_selection_data, x_property_data_to_lisp):
8021 Check for size-calculation overflow.
8022 (x_get_window_property, receive_incremental_selection)
8023 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8024 Don't store size until memory allocation succeeds.
8025 (x_get_window_property): Plug memory leak on memory exhaustion.
8026 Don't double-block input; malloc is safe here. Don't assume 2**34
8027 - 4 fits in unsigned long. Add an xassert to check
8028 XGetWindowProperty overflow. Be more careful about overflow
8029 calculations, and distinguish size from memory overflow better.
8030 (receive_incremental_selection): When tracing, don't assume
8031 unsigned int is less than INT_MAX.
8032 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8033 harmful) conversions of unsigned short to int.
8034 (lisp_data_to_selection_data): Don't assume that integers
8035 in the range -65535 through -1 fit in an X unsigned short.
8036 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8037 result parameters unless successful. Rely on cons_to_unsigned
8038 to report problems with elements; the old code wasn't right anyway.
8039 (x_check_property_data): Check for int overflow; we cannot use
8040 a wider type due to X limits.
8041 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8042
726e0ab1 8043 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8044
0065d054
PE
8045 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8046 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8047 (x_color_cells): Don't store size until memory allocation succeeds.
8048 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8049 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8050 (x_term_init): Don't assume length fits in int (sprintf is limited
8051 to int size).
bc18e09d 8052
ebfa62c0
PE
8053 Use ptrdiff_t for composition IDs.
8054 * character.c (lisp_string_width):
8055 * composite.c (composition_table_size, n_compositions)
8056 (get_composition_id, composition_gstring_from_id):
8057 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8058 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8059 * window.c (Frecenter):
8060 Use ptrdiff_t, not int, for composition IDs.
8061 * composite.c (get_composition_id): Check for integer overflow.
8062 * composite.h: Adjust prototypes to match the above changes.
8063
d3411f89
PE
8064 Use ptrdiff_t for hash table indexes.
8065 * category.c (hash_get_category_set):
8066 * ccl.c (ccl_driver):
8067 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8068 * coding.c (coding_system_charset_list, detect_coding_system):
8069 * coding.h (struct coding_system.id):
8070 * composite.c (get_composition_id, gstring_lookup_cache):
8071 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8072 * image.c (xpm_get_color_table_h):
8073 * lisp.h (hash_lookup, hash_put):
8074 * minibuf.c (Ftest_completion):
8075 Use ptrdiff_t for hash table indexes, not int (which is too
8076 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8077 32-bit --with-wide-int hosts).
8078
e097a6fa
PE
8079 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8080 Add a FIXME comment about memory leaks.
8081 (syms_of_charset): Don't assume xmalloc returns.
8082
5637687f
PE
8083 Don't assume that stated character widths fit in int.
8084 * character.c (Fchar_width, c_string_width, lisp_string_width):
8085 * character.h (CHAR_WIDTH):
8086 * indent.c (MULTIBYTE_BYTES_WIDTH):
8087 Use sanitize_char_width to avoid undefined and/or bad behavior
8088 with outlandish widths.
a66cfb1c 8089 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8090 now that we have two such functions. All uses changed.
8091 (sanitize_char_width): New inline function.
8092
a2271ba2
PE
8093 Don't assume that tab-width fits in int.
8094 * character.h (sanitize_width): New inline function.
8095 (SANE_TAB_WIDTH): New macro.
8096 (ASCII_CHAR_WIDTH): Use it.
8097 * indent.c (sane_tab_width): Remove. All uses replaced by
8098 SANE_TAB_WIDTH (current_buffer).
8099 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8100
18c52557
PE
8101 * fileio.c: Integer overflow issues with file modes.
8102 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8103
caeeedc1
PE
8104 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8105 Remove unreachable code.
8106 (read_hex, load_charset_map_from_file): Check for integer overflow.
8107
6df6ae42 8108 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8109 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8110 (x_send_scroll_bar_event): Likewise. Check that the size does not
8111 exceed limits imposed by XClientMessageEvent, as well as the usual
8112 ptrdiff_t and size_t limits.
8113
b13995db
PE
8114 * keyboard.c: Overflow, signedness and related fixes.
8115 (make_lispy_movement): Use same integer type in forward decl
8116 that is used in the definition.
8117 (read_key_sequence, keyremap_step):
8118 Change bufsize argument back to int, undoing my 2011-03-30 change.
8119 We prefer signed types, and int is wide enough here.
8120 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8121 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8122 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8123 length, not size_t. Use ptrdiff_t for index, not int.
8124 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8125 possibility of integer overflow.
8126
13464394
PE
8127 Overflow, signedness and related fixes for images.
8128
8129 * dispextern.h (struct it.stack[0].u.image.image_id)
8130 (struct_it.image_id, struct image.id, struct image_cache.size)
8131 (struct image_cache.used, struct image_cache.ref_count):
8132 * gtkutil.c (update_frame_tool_bar):
8133 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8134 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8135 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8136 * nsmenu.m (update_frame_tool_bar):
8137 * xdisp.c (calc_pixel_width_or_height):
8138 * xfns.c (image_cache_refcount):
8139 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8140 on typical 64-bit hosts.
8141
8142 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8143 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8144 Omit unnecessary casts to int.
8145 (parse_image_spec): Check that integers fall into 'int' range
8146 when the callers expect that.
8147 (image_ascent): Redo ascent calculation to avoid int overflow.
8148 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8149 (lookup_image): Remove unnecessary tests.
8150 (xbm_image_p): Locals are now of int, not EMACS_INT,
8151 since parse_image_check makes sure they fit into int.
8152 (png_load, gif_load, svg_load_image):
8153 Prefer int to unsigned where either will do.
8154 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8155 old tiff_error_handler and tiff_warning_handler.
8156 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8157 stack buffer overflows. It uses only the features of vsnprintf
8158 that are common to both POSIX and native Microsoft.
8159 (tiff_error_handler, tiff_warning_handler): Use it.
8160 (tiff_load, gif_load, imagemagick_load_image):
8161 Don't assume :index value fits in 'int'.
8162 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8163 (imagemagick_load_image): Check that crop parameters fit into
8164 the integer types that MagickCropImage accepts. Don't assume
8165 Vimagemagick_render_type has a nonnegative value. Don't assume
8166 size_t fits in 'long'.
8167 (gs_load): Use printmax_t to print the widest integers possible.
8168 Check for integer overflow when computing image height and width.
8169
c11821d4
EZ
81702011-08-26 Eli Zaretskii <eliz@gnu.org>
8171
8172 * xdisp.c (redisplay_window): Don't force window start if point
8173 will be invisible in the resulting window. (Bug#9324)
8174
0c95fcf7
EZ
81752011-08-25 Eli Zaretskii <eliz@gnu.org>
8176
8177 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8178 the display spec is of the form `(space ...)'.
8179 (handle_display_spec): Return the value returned by
8180 handle_single_display_spec, not just 1 or zero.
8181 (handle_single_display_spec): If the display spec is of the form
8182 `(space ...)', and specifies display in the text area, return 2
8183 rather than 1.
fee65a97 8184 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8185 accurately, and prefer exact match for point under bidi.
8186 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8187
8188 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8189 into disp_prop; all users changed.
8190
8191 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8192 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8193 for the text covered by the display property.
8194
e4ed06f1
CY
81952011-08-25 Chong Yidong <cyd@stupidchicken.com>
8196
8197 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8198 Change return value to nil.
8199 (Frecord_buffer): Delete unused function.
8200
f67cdd7f
EZ
82012011-08-24 Eli Zaretskii <eliz@gnu.org>
8202
5980d4c6
EZ
8203 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8204 buffers, return left-to-right.
8610fe8b
EZ
8205 (set_cursor_from_row): Consider candidate row a win if its glyph
8206 represents a newline and point is on that newline. Fixes cursor
8207 positioning on the newline at EOL of R2L text within L2R
8208 paragraph, and vice versa.
8209 (try_cursor_movement): Check continued rows, in addition to
8210 continuation rows. Fixes unwarranted scroll when point enters a
8211 continued line of R2L text within an L2R paragraph, or vice versa.
8212 (cursor_row_p): Consider the case of point being equal to
8213 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8214 from the end of a short line to the beginning of a continued line
8215 of R2L text within L2R paragraph.
8216 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8217 composed characters.
5980d4c6 8218
f67cdd7f
EZ
8219 * bidi.c (bidi_check_type): Use xassert.
8220 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8221 members.
8222
bca633fb
EZ
82232011-08-23 Eli Zaretskii <eliz@gnu.org>
8224
8225 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8226 a character.
8227
4a5885a7
CY
82282011-08-23 Chong Yidong <cyd@stupidchicken.com>
8229
8230 * nsfont.m (ns_otf_to_script): Fix typo.
8231
0902a04e
KH
82322011-08-22 Kenichi Handa <handa@m17n.org>
8233
8234 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8235 extra slot even if the purpose is char-code-property-table.
8236
1a2e6670
EZ
82372011-08-23 Eli Zaretskii <eliz@gnu.org>
8238
8ddde651
EZ
8239 * xdisp.c (redisplay_window): When computing centering_position,
8240 account for the height of the header line. (Bug#8874)
8241
425cc014
EZ
8242 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8243 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8244 candidate is selected by the mouse, and that candidate has a
8245 composed character under the mouse.
8246
1a2e6670
EZ
8247 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8248 coordinates reported by pos-visible-in-window-p for a composed
8249 character in column zero.
8250
8b76d6f8
SM
82512011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8252
8253 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8254
dac347dd
EZ
82552011-08-22 Eli Zaretskii <eliz@gnu.org>
8256
8257 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8258 consider it a hit if to_charpos is anywhere in the range of the
8259 composed buffer positions.
8260
e013fb34
CY
82612011-08-22 Chong Yidong <cyd@stupidchicken.com>
8262
8263 * image.c (gif_load): Don't assume that each subimage has the same
8264 dimensions as the base image. Handle disposal method that is
8265 "undefined" by the gif spec (Bug#9335).
8266
bd1ba3e8
CY
82672011-08-20 Chong Yidong <cyd@stupidchicken.com>
8268
8269 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8270 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8271
54a1215b
EZ
82722011-08-19 Eli Zaretskii <eliz@gnu.org>
8273
823564e5
EZ
8274 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8275 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8276 from an Org mode buffer to a Speedbar frame.
8277
54a1215b
EZ
8278 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8279 a composition, take its buffer position from IT->cmp_it.charpos.
8280 Fixes cursor positioning at the beginning of a line that begins
8281 with a composed character.
8282
9778ebcc
EZ
82832011-08-18 Eli Zaretskii <eliz@gnu.org>
8284
0be6ee06
EZ
8285 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8286 character bidirectional type, use STRONG_L instead. Fixes crashes
8287 in a buffer produced by `describe-categories'.
8288
9778ebcc
EZ
8289 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8290 members before the level stack, so they would be saved and
8291 restored when copying iterator state. Fixes incorrect reordering
8292 around TABs covered by display properties.
8293
156bffbe
AS
82942011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8295
6b02f655 8296 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8297
72ad093b
CY
82982011-08-17 Chong Yidong <cyd@stupidchicken.com>
8299
8300 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8301 (internal_condition_case_2, internal_condition_case_n):
8302 Remove unnecessary aborts (Bug#9081).
72ad093b 8303
35774242
EZ
83042011-08-17 Eli Zaretskii <eliz@gnu.org>
8305
8306 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8307 has no `load' handler, try opening the file locally. (Bug#9311)
8308
db76dd85
KB
83092011-08-16 Ken Brown <kbrown@cornell.edu>
8310
8311 * gmalloc.c: Expand comment.
8312
b215eee5
EZ
83132011-08-16 Eli Zaretskii <eliz@gnu.org>
8314
8315 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8316 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8317
a4579d33
KB
83182011-08-16 Ken Brown <kbrown@cornell.edu>
8319
8320 Fix memory allocation problems in Cygwin build (Bug#9273).
8321
8322 * unexcw.c ( __malloc_initialized): Declare external variable.
8323 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8324
8b76d6f8
SM
8325 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8326 New variables.
a4579d33
KB
8327 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8328 dumped emacs.
8329 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8330 in the static heap.
8331 [CYGWIN] (special_realloc): New function.
8332 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8333 requests to realloc storage in the static heap.
8334
3ebec551
PE
83352011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8336
8337 * bidi.c (bidi_initialize): Remove unused local.
8338
9fd8be00
EZ
83392011-08-15 Eli Zaretskii <eliz@gnu.org>
8340
6b02f655
SM
8341 * bidimirror.h:
8342 * biditype.h: Remove file.
8343 * makefile.w32-in ($(BLD)/bidi.$(O)):
8344 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8345
8346 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8347
8348 * chartab.c: Improve commentary for the uniprop_table API.
8349
32413314
EZ
8350 * bidi.c (bidi_paragraph_init): Support zero value of
8351 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8352 (bidi_initialize): Use uniprop_table instead of including
8353 biditype.h and bidimirror.h.
32413314 8354
9fd8be00
EZ
8355 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8356 coordinates of the iterator when restoring from ppos_it.
8357 (Bug#9296)
8358
5cf2b69b
KH
83592011-08-14 Kenichi Handa <handa@m17n.org>
8360
8361 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8362 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8363
daf17d00
EZ
83642011-08-14 Eli Zaretskii <eliz@gnu.org>
8365
8366 * xdisp.c (move_it_in_display_line_to): Don't invoke
8367 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8368 ppos_it. Fixes vertical cursor motion when line beginning is
8369 covered by an image. (Bug#9296)
8370
08e3161a
JD
83712011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8372
8373 * nsterm.h (ns_run_ascript): Declare.
8374 (NSAPP_DATA2_RUNASSCRIPT): Define.
8375
8376 * nsfns.m (as_script, as_result, as_status): New static variables.
8377 (ns_run_ascript): New function.
5e617bc2 8378 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8379 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8380 the event loop. Get status from as_status (Bug#7276).
8381
8382 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8383 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8384 the event loop (Bug#7276).
8385
a3720aa2
AS
83862011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8387
8388 * gnutls.c (QCgnutls_bootprop_priority)
8389 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8390 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8391 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8392 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8393 (QCgnutls_bootprop_verify_hostname_error)
8394 (QCgnutls_bootprop_callbacks_verify): Rename from
8395 Qgnutls_bootprop_..., all uses changed.
8396
8397 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8398 uses changed.
8399
0a0d27fb
PE
84002011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8401
19d5c50c
PE
8402 * xfaces.c (Qframe_set_background_mode): Now static.
8403 * dispextern.h (Qframe_set_background_mode): Remove decl.
8404
0a0d27fb
PE
8405 * process.c (Fnetwork_interface_info): Declare local only if needed.
8406
377538cb
JD
84072011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8408
8409 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8410 (Fnetwork_interface_list): Allocate in increments of bytes instead
8411 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8412 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8413 sockaddr.
8414 (struct ifflag_def): notrailers is smart on OSX.
8415 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8416 Get hardware address with getifaddrs if available.
8417
08fff70c
EZ
84182011-08-12 Eli Zaretskii <eliz@gnu.org>
8419
8420 * xdisp.c (iterate_out_of_display_property): xassert that
8421 IT->position is set to within IT->object's boundaries. Break from
8422 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8423 when IT->position is set up wrongly due to some bug.
8424 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8425 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8426 entry. Force push_it to save on the stack the current
8427 buffer/string position, to be restored by pop_it. Fix flags in
8428 the iterator structure wrt the object coming from a display
8429 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8430 properties. (Bug#9284)
8431
7be1c708 84322011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8433
7be1c708
CY
8434 * fontset.c (fontset_get_font_group): Add proper type checks.
8435 (Bug#9172)
aac0c6e3 8436
7be1c708 84372011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8438
7be1c708
CY
8439 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8440 and LC_VERSION_MIN_MACOSX.
8441 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8442 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8443
97bb72a6
EZ
84442011-08-08 Eli Zaretskii <eliz@gnu.org>
8445
8446 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8447 no-display-properties-and-no-overlays under bidi display.
8448 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8449 properties and overlays.
97bb72a6 8450
d5617611
CY
84512011-08-08 Chong Yidong <cyd@stupidchicken.com>
8452
37e11a63
CY
8453 * editfns.c (Fset_time_zone_rule): Document relationship with the
8454 setenv function.
8455
d5617611
CY
8456 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8457 the font entity extracted from the cache (Bug#8109).
8458
58872834
CY
84592011-08-07 Chong Yidong <cyd@stupidchicken.com>
8460
8461 * composite.c (autocmp_chars): Don't reset point. That is done by
8462 restore_point_unwind (Bug#5984).
8463
75bfc667
JL
84642011-08-07 Juri Linkov <juri@jurta.org>
8465
8466 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8467 to show the arg `TIME' instead of `TIMEVAL'.
8468
d1410150
EZ
84692011-08-06 Eli Zaretskii <eliz@gnu.org>
8470
8471 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8472 display property strides EOL and includes a newline, as in
8473 longlines-mode. (Bug#9254)
75b771e4
EZ
8474 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8475 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8476
8477 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8478 is non-zero, even if the data buffer is NULL. Fixes a crash in
8479 vertical-motion with longlines-mode. (Bug#9254)
8480
35928349
EZ
84812011-08-05 Eli Zaretskii <eliz@gnu.org>
8482
ec7cc85b
EZ
8483 * bidi.c <bidi_cache_total_alloc>: Now static.
8484 (bidi_initialize): Initialize bidi_cache_total_alloc.
8485
8b76d6f8 8486 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8487 cache. (Bug#9221)
8488
8489 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8490 amount allocated this far in `bidi_cache_total_alloc'.
8491 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8492 non-zero, only free the data buffer without restoring the cache
8493 contents. All callers changed.
8494
8495 * dispextern.h (bidi_unshelve_cache): Update prototype.
8496
8497 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8498 (move_it_in_display_line, move_it_to)
8499 (move_it_vertically_backward, move_it_by_lines): Replace the call
8500 to xfree to an equivalent call to bidi_unshelve_cache.
8501 (move_it_in_display_line_to): Fix logic of returning
412b6358 8502 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8503
e2e2423b
EZ
85042011-08-05 Eli Zaretskii <eliz@gnu.org>
8505
8506 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8507 came from a string character with a `cursor' property. (Bug#9229)
8508
ae9e757a
JD
85092011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8510
8511 * Makefile.in (LIB_PTHREAD): New variable.
8512 (LIBES): Add LIB_PTHREAD (Bug#9216).
8513
8514 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8515 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8516
213bd7f2
AS
85172011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8518
6b02f655 8519 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8520
99aaf75f
JD
85212011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8522
8523 * xterm.c (x_find_topmost_parent): New function.
8524 (x_set_frame_alpha): Find topmost parent window with
8525 x_find_topmost_parent and set the property there also (bug#9181).
8526 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8527
c74e9d86
PE
85282011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8529
8530 * callproc.c (Fcall_process): Avoid vfork clobbering
8531 the local vars buffer, coding_systems, current_dir.
8532
640c8776
SM
85332011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8534
8535 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8536
f26d0e4c
PE
85372011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8538
8a10d76c
PE
8539 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8540 so that it is not optimized away.
8541
f26d0e4c
PE
8542 * xdisp.c (compute_display_string_pos): Remove unused local.
8543
55439c61
EZ
85442011-08-02 Eli Zaretskii <eliz@gnu.org>
8545
8546 Fix slow cursor motion and scrolling in large buffers with
8547 selective display, like Org Mode buffers. (Bug#9218)
8548
8549 * dispextern.h (struct bidi_it): New member disp_prop_p.
8550
8551 * xdisp.c: Remove one-slot cache of display string positions.
8552 (compute_display_string_pos): Accept an additional argument
5e617bc2 8553 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8554 for a display string or property. If found, set DISP_PROP_P
8555 non-zero.
8556
8557 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8558 DISP_PROP_P, and pass it to compute_display_string_pos.
8559 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8560 non-zero. All callers of bidi_fetch_char changed.
8561
fb33fa43
SM
85622011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8563
8564 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8565
b099e063
DM
85662010-12-03 Don March <don@ohspite.net>
8567
8568 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8569 last character M-[char] is translated to ESC [char] (bug#7541).
8570
5cc7f7af
KH
85712011-08-02 Kenichi Handa <handa@m17n.org>
8572
d0fffa3f 8573 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8574
8575 * chartab.c (uniprop_table): Make it non-static.
8576
525d5e6e
EZ
85772011-08-01 Eli Zaretskii <eliz@gnu.org>
8578
8579 * xdisp.c (forward_to_next_line_start): Accept additional argument
8580 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8581 on the newline.
8582 (reseat_at_next_visible_line_start): Use the bidi iterator state
8583 returned by forward_to_next_line_start to restore the state of
8584 it->bidi_it after backing up to previous newline. (Bug#9212)
8585
31011111
AS
85862011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8587
8588 * regex.c (re_comp): Protoize.
8589 (re_exec): Fix return type.
8590 (regexec): Fix type of `ret'. (Bug#9203)
8591
476371c4
PE
85922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8593
e5d76069
PE
8594 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8595 This is needed if max-image-size is a floating-point number.
8596
9a79b20c
AS
85972011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8598
8599 * print.c (print_object): Print empty symbol as ##.
8600
8601 * lread.c (read1): Read ## as empty symbol.
8602
d8c2fa78
AA
86032011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8604
8605 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8606 setting frame foreground color (Bug#9175).
8607 (x_set_background_color): Likewise.
8608
ffe57a7a
AA
8609 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8610 contents (Bug#9176).
8611 (EmacsTooltip -init): Remove bezels and add shadows to
8612 tooltip windows.
8613
bf3492a5
AA
8614 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8615 or scroll bar (Bug#8470).
8616
d55e9c53
AA
8617 * nsfont.m (nsfont_open): Remove assignment to voffset and
8618 unnecessary vars hshink, expand, hd, full_height, min_height.
8619 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8620
8621 * nsterm.h (nsfont_info): Remove voffset field.
8622
d8c2fa78 86232011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8624
8625 Implement strike-through and overline on NextStep (Bug#8863).
8626
8627 * nsfont.m (nsfont_open): Use underline position provided by font,
8628 instead of hard-coded value of 2.
8629 (nsfont_draw): Call ns_draw_text_decoration instead.
8630
8631 * nsterm.h: Add declaration for ns_draw_text_decoration.
8632
8633 * nsterm.m (ns_draw_text_decoration): New function for drawing
8634 underline, overline, and strike-through.
8635 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8636 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8637 accommodate underlining, etc.
4843aac3 8638
4cc60b9b
EZ
86392011-07-28 Eli Zaretskii <eliz@gnu.org>
8640
bc7ece87
EZ
8641 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8642 default.
4cc60b9b 8643
476371c4
PE
86442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8645
66606eea
PE
8646 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8647 Without this fix, if a signal arrives just after memory fills up,
8648 'malloc' might be invoked reentrantly.
8649
476371c4
PE
8650 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8651 In other words, assume that every image size is allowed, on non-X
8652 hosts. This assumption is probably wrong, but it lets Emacs compile.
8653
f3fcc40d
AS
86542011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8655
8656 * regex.c (re_iswctype): Convert return values to boolean.
8657
350c992f
EZ
86582011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8659
8660 * xdisp.c (compute_display_string_pos): Don't use cached display
8661 string position if the buffer had its restriction changed.
8662 (Bug#9184)
8663
5266b4bb
PE
86642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8665
8666 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8667
2573a837 86682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8669
41f55ccd 8670 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8671
39e378da
PE
8672 * bidi.c: Integer size and overflow fixes.
8673 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8674 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8675 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8676 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8677 (bidi_find_other_level_edge):
8678 Use ptrdiff_t instead of EMACS_INT where either will do.
8679 This works better on 32-bit hosts configured --with-wide-int.
8680 (bidi_cache_ensure_space): Check for size-calculation overflow.
8681 Use % rather than repeated addition, for better worst-case speed.
8682 Don't set bidi_cache_size until after xrealloc returns, because it
8683 might not return.
8684 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8685 (bidi_cache_ensure_space): Also check that the bidi cache size
8686 does not exceed that of the largest Lisp string or buffer. See Eli
8687 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8688
5e927815
PE
8689 * alloc.c (__malloc_size_t): Remove.
8690 All uses replaced by size_t. See Andreas Schwab's note
8691 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8692
ca4aa935
PE
8693 * image.c: Improve checking for integer overflow.
8694 (check_image_size): Assume that f is nonnull, since
8695 it is always nonnull in practice. This is one less thing to
8696 worry about when checking for integer overflow later.
8697 (x_check_image_size): New function, which checks for integer
8698 overflow issues inside X.
8699 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8700 This removes the need for a memory_full check.
8701 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8702 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8703 (xbm_read_bitmap_data): Change locals back to 'int', since
8704 their values must fit in 'int'.
8705 (xpm_load_image, png_load, tiff_load):
8706 Invoke x_create_x_image_and_pixmap earlier,
8707 to avoid much needless work if the image is too large.
8708 (tiff_load): Treat overly large images as if
8709 x_create_x_image_and_pixmap failed, not as malloc failures.
8710 (gs_load): Use x_check_image_size.
8711
5f8f9cc2
PE
8712 * gtkutil.c: Omit integer casts.
8713 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8714 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8715
5adf60bc
PE
8716 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8717
c8907a93
PE
8718 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8719 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8720 would wrongly return t on a 64-bit host.
8721
e3c25c68
PE
8722 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8723 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8724 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8725 and therefore cause GCC to emit a bogus diagnostic in some cases.
8726
3f791afe
PE
8727 * image.c: Integer signedness and overflow and related fixes.
8728 This is not an exhaustive set of fixes, but it's time to
8729 record what I've got.
8730 (lookup_pixel_color, check_image_size): Remove redundant decls.
8731 (check_image_size): Don't assume that arbitrary EMACS_INT values
8732 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8733 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8734 (tiff_load, imagemagick_load_image):
8735 Check for overflow in size calculations.
8736 (x_create_x_image_and_pixmap): Remove unnecessary test for
8737 xmalloc returning NULL; that can't happen.
8738 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8739 (xpm_color_bucket): Use better integer hashing function.
8740 (xpm_cache_color): Don't possibly over-allocate memory.
8741 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8742 (gif_memory_source):
8743 Use ptrdiff_t, not int or size_t, to record sizes.
8744 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8745 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8746 either works, as we prefer signed integers.
8747 (tiff_read_from_memory, tiff_write_from_memory):
8748 Return tsize_t, not size_t, since that's what the TIFF API wants.
8749 (tiff_read_from_memory): Don't fail simply because the read would
8750 go past EOF; instead, return a short read.
8751 (tiff_load): Omit no-longer-needed casts.
8752 (Fimagemagick_types): Don't assume size fits into 'int'.
8753
3cc5a532
PE
8754 Improve hashing quality when configured --with-wide-int.
8755 * fns.c (hash_string): New function, taken from sxhash_string.
8756 Do not discard information about ASCII character case; this
8757 discarding is no longer needed.
8758 (sxhash-string): Use it. Change sig to match it. Caller changed.
8759 * lisp.h: Declare it.
8760 * lread.c (hash_string): Remove, since we now use fns.c's version.
8761 The fns.c version returns a wider integer if --with-wide-int is
8762 specified, so this should help the quality of the hashing a bit.
8763
b312a492
PE
8764 * emacs.c: Integer overflow minor fix.
8765 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8766 Define only if GNU_LINUX.
8767 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8768
dfd153ae
PE
8769 * dispnew.c: Integer signedness and overflow fixes.
8770 Remove unnecessary forward decls, that were a maintenance hassle.
8771 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8772 All uses changed.
8773 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8774 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8775 (prepare_desired_row, line_draw_cost):
8776 Use int, not unsigned, where either works.
8777 (save_current_matrix, restore_current_matrix):
8778 Use ptrdiff_t, not size_t, where either works.
8779 (init_display): Check for overflow more accurately, and without
8780 relying on undefined behavior.
8781
a81d11a3
PE
8782 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8783 Remove, replacing with the new symbols in lisp.h. All uses changed.
8784 * fileio.c (make_temp_name):
8785 * filelock.c (lock_file_1, lock_file):
8786 * xdisp.c (message_dolog):
8787 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8788 Use pMd etc. instead.
8789 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8790 replacing the pWIDE etc. symbols removed from editfns.c.
8791
3300e6fd
PE
8792 * keyboard.h (num_input_events): Now uintmax_t.
8793 This is (very slightly) less likely to mess up due to wraparound.
8794 All uses changed.
8795
fd05c7e9
PE
8796 * buffer.c: Integer signedness fixes.
8797 (alloc_buffer_text, enlarge_buffer_text):
8798 Use ptrdiff_t rather than size_t when either will do, as we prefer
8799 signed integers.
8800
903fe15d
PE
8801 * alloc.c: Integer signedness and overflow fixes.
8802 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8803 (__malloc_size_t): Default to size_t, not to int.
8804 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8805 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8806 Prefer ptrdiff_t to size_t when either would do, as we prefer
8807 signed integers.
8808 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8809 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8810 Now const. Initialize with values that are in range even if char
8811 is signed.
8812 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8813 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8814 These functions do the right thing with sizes > 2**32.
8815 (check_depth): Now ptrdiff_t, not int.
8816 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8817 Adjust to new way of storing sizes. Check for size overflow bugs
8818 in rest of code.
8819 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8820 slightly wrong anyway, as it missed one instance of
8821 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8822 (refill_memory_reserve): Omit needless cast to size_t.
8823 (mark_object_loop_halt): Mark as externally visible.
8824
ac82cc6a
PE
8825 * xselect.c: Integer signedness and overflow fixes.
8826 (Fx_register_dnd_atom, x_handle_dnd_message):
8827 Use ptrdiff_t, not size_t, since we prefer signed.
8828 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8829 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8830 x_dnd_atoms_size and x_dnd_atoms_length.
8831
c2d1e36d
PE
8832 * doprnt.c: Prefer signed to unsigned when either works.
8833 * eval.c (verror):
8834 * doprnt.c (doprnt):
8835 * lisp.h (doprnt):
8836 * xdisp.c (vmessage):
8837 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8838 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8839 prefer signed arithmetic to avoid comparison confusion.
8840 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8841 but is a bit tricky.
8842
0e926e56
PE
8843 Assume freestanding C89 headers, string.h, stdlib.h.
8844 * data.c, doprnt.c, floatfns.c, print.c:
8845 Include float.h unconditionally.
8846 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8847 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8848 * regex.c: Likewise for stddef.h, string.h.
8849 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8850 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8851 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8852 (STDC_HEADERS): Remove obsolete defines.
8853 * sysdep.c: Include limits.h unconditionally.
8854
9cfdb3ec
PE
8855 Assume support for memcmp, memcpy, memmove, memset.
8856 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8857 * regex.c (memcmp, memcpy):
8858 Remove; we assume C89 now.
8859
8860 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8861 (__malloc_safe_bcopy): Remove; no longer needed.
8862
cf950e6b 8863 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8864 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8865 well either way, and we prefer signed to unsigned.
8866
dbf38e02
LMI
88672011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8868
8869 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8870 closes the connection while we're reading (bug#9182).
8871
d6f0886c 88722011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8873
d6f0886c
JD
8874 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8875 are specified (Bug#9168).
24e0f6b1 8876
2eb1f9e6
PE
88772011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8878
8879 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8880 Found by GCC static checking and --with-wide-int on a 32-bit host.
8881
22381272 88822011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8883
8884 * xdisp.c (compute_display_string_pos): Fix logic of caching
8885 previous display string position. Initialize cached_prev_pos to
8886 -1. Fixes slow-down at the beginning of a buffer.
8887
f25e39b4
EZ
88882011-07-24 Eli Zaretskii <eliz@gnu.org>
8889
8890 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8891 for attrs[LFACE_FONTSET_INDEX].
8892
04c4b52e
PE
88932011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8894
8895 * xml.c (parse_region): Remove unused local
8896 that was recently introduced.
8897
c1734fbd
EZ
88982011-07-23 Eli Zaretskii <eliz@gnu.org>
8899
be18c5a5
EZ
8900 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8901 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8902
c1734fbd
EZ
8903 * xdisp.c (move_it_in_display_line_to): Record the best matching
8904 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8905 exit if none of the characters scanned was an exact match.
8906 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8907 when exact match is impossible due to invisible text, and the
8908 lines are truncated.
8909
a258d627
JD
89102011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8911
8912 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8913 for OSX >= 10.7.
8914
b6d5a689
EZ
89152011-07-22 Eli Zaretskii <eliz@gnu.org>
8916
0f74f785
EZ
8917 Fix a significant slow-down of cursor motion with C-n, C-p,
8918 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8919 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8920 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8921 (next_element_from_buffer): Call compute_stop_pos_backwards to
8922 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8923 base_level_stop.
8924 (reseat): Don't look for prev_stop, as that could mean a very long
8925 run.
8926 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8927 <cached_disp_overlay_modiff>: Cache for last found display string
8928 position.
551918c1 8929 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8930 about the same buffer in the same area of character positions, and
8931 the buffer wasn't changed since the time the display string
8932 position was cached.
551918c1 8933
b2d0c91a
EZ
89342011-07-22 Eli Zaretskii <eliz@gnu.org>
8935
8936 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8937 is an integer, which is important for empty lines. (Bug#9149)
8938
043604ee
CY
89392011-07-22 Chong Yidong <cyd@stupidchicken.com>
8940
8941 * frame.c (Fmodify_frame_parameters): In tty case, update the
8942 default face if necessary (Bug#4238).
8943
da4adb04
CY
89442011-07-21 Chong Yidong <cyd@stupidchicken.com>
8945
8946 * editfns.c (Fstring_to_char): No need to explain what a character
8947 is in the docstring (Bug#6576).
8948
9abd0532
LMI
89492011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8950
8951 * xml.c (parse_region): Make sure we always return a tree.
8952
36881d16
HK
89532011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8954
8955 * xml.c (parse_region): If a document contains only comments,
8956 return that, too.
8957
1e98674d
LMI
89582011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8959
8960 * xml.c (make_dom): Return comments, too.
8961
590bd467
PE
89622011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8963
8964 Port to OpenBSD.
8965 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8966 and the surrounding thread.
8967 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8968 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8969 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8970 timer goes off.
8971 * s/openbsd.h (BROKEN_SIGIO): Define.
8972 * unexelf.c (unexec) [__OpenBSD__]:
8973 Don't update the .mdebug section of the Alpha COFF symbol table.
8974
f41628b2
LMI
89752011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8976
8977 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8978 (bug#8460).
8979
b59b67c5
PE
89802011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8981
15e3a074
PE
8982 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8983 This fixes some race conditions on the permissions of any newly
8984 created file.
8985
41bed37d
PE
8986 * alloc.c (valid_pointer_p): Use pipe, not open.
8987 This fixes some permissions issues when debugging.
8988
b59b67c5
PE
8989 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8990 If fchown fails to set both uid and gid, try to set just gid,
8991 as that is sometimes allowed. Adjust the file's mode to eliminate
8992 setuid or setgid bits that are inappropriate if fchown fails.
8993
925a6be7
SM
89942011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8995
8996 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8997 to compare Lisp_Objects.
8998 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8999 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9000 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9001
52968808
AS
90022011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9003
0a6a104b
AS
9004 * lread.c (read_integer): Unread even EOF character.
9005 (read1): Likewise. Properly record start position of symbol.
9006
52968808
AS
9007 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9008 symbol character follows.
9009
9e381cdd
PE
90102011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9011
9012 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9013 This works around a problem with the previous change to Fcopy_file.
9014 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9015 and without this change, GCC might complain about discarding
9016 fchown's return value.
9017
b5641435
JB
90182011-07-16 Juanma Barranquero <lekktu@gmail.com>
9019
9020 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9021
a8031457
PE
90222011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9023
9024 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9025
dd889327
LMI
90262011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9027
750c33f7
LMI
9028 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9029 it's used from the C level.
9030
dd889327
LMI
9031 * process.c: Use the same condition for POLL_FOR_INPUT in both
9032 keyboard.c and process.c (bug#1858).
9033
87e86684
LM
90342011-07-09 Lawrence Mitchell <wence@gmx.li>
9035
9036 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9037 (Fgnutls_boot): Use it.
9038
64348f40
AS
90392011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9040
9041 * doc.c (Fsubstitute_command_keys): Revert last change.
9042
1d698799
LMI
90432011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9044
f863868c
LMI
9045 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9046 quotes the next character, and doesn't affect other longer
9047 sequences (bug#8935).
9048
1d698799
LMI
9049 * lread.c (syms_of_lread): Clarify that is isn't only
9050 `eval-buffer' and `eval-defun' that's affected by
9051 `lexical-binding' (bug#8460).
9052
aa4b6df6
EZ
90532011-07-15 Eli Zaretskii <eliz@gnu.org>
9054
9055 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9056 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9057
5d856da6
PE
90582011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9059
ad6042bb
PE
9060 Fix minor problems found by static checking.
9061 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9062 (elsz): Now a signed constant, not a size_t var. We prefer signed
9063 types to unsigned, to avoid integer comparison confusion. Without
9064 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9065 "cannot optimize loop, the loop counter may overflow", a symptom
9066 of the confusion.
f00bbb22 9067 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9068 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9069
6468f31c
LMI
90702011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9071
49080b10
LMI
9072 * search.c (Fre_search_backward): Mention `case-fold-search' in
9073 all the re_search_* functions (bug#8138).
9074
6468f31c
LMI
9075 * keyboard.c (Fopen_dribble_file): Document when the file is
9076 closed (bug#8056).
9077
c965adc5
EZ
90782011-07-14 Eli Zaretskii <eliz@gnu.org>
9079
df9733bf
EZ
9080 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9081 bidi_cache_idx.
9082
0bb23927
EZ
9083 Support bidi reordering of display and overlay strings.
9084 * xdisp.c (compute_display_string_pos)
9085 (compute_display_string_end): Accept additional argument STRING.
9086 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9087 (reseat_to_string): Initialize bidi_it->string.s and
9088 bidi_it->string.schars.
9089 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9090 NULL (avoids a crash in bidi_paragraph_init).
9091 Initialize itb.string.lstring.
0bb23927
EZ
9092 (init_iterator): Call bidi_init_it only of a valid
9093 buffer position was specified. Initialize paragraph_embedding to
9094 L2R.
9095 (reseat_to_string): Initialize the bidi iterator.
9096 (display_string): If we need to ignore text properties of
9097 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9098 original value of -1 will not work with bidi.)
9099 (compute_display_string_pos): First arg is now struct
9100 `text_pos *'; all callers changed. Support display properties on
9101 Lisp strings.
9102 (compute_display_string_end): Support display properties on Lisp
9103 strings.
9104 (init_iterator, reseat_1, reseat_to_string): Initialize the
9105 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9106 when iterating on a string not from display properties).
640c8776
SM
9107 (compute_display_string_pos, compute_display_string_end):
9108 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9109 arrow keys.
9110 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9111 base_level_stop; instead, set base_level_stop to BEGV.
9112 Fixes crashes in vertical-motion.
0bb23927
EZ
9113 (next_element_from_buffer): Improve commentary for when
9114 the iterator is before prev_stop.
9115 (init_iterator): Initialize bidi_p from the default value of
9116 bidi-display-reordering, not from buffer-local value. Use the
9117 buffer-local value only if initializing for buffer iteration.
9118 (handle_invisible_prop): Support invisible properties on strings
9119 that are being bidi-reordered.
9120 (set_iterator_to_next): Support bidi reordering of C strings and
9121 Lisp strings.
9122 (next_element_from_string): Support bidi reordering of Lisp
9123 strings.
9124 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9125 (display_string): Support display of R2L glyph rows.
9126 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9127 (init_iterator): Don't initialize it->bidi_p for strings
9128 here.
9129 (reseat_to_string): Initialize it->bidi_p for strings here.
9130 (next_element_from_string, next_element_from_c_string)
9131 (next_element_from_buffer): Add xassert's for correspondence
9132 between IT's object being iterated and it->bidi_it.string
9133 structure.
9134 (face_before_or_after_it_pos): Support bidi iteration.
9135 (next_element_from_c_string): Handle the case of the first string
9136 character that is not the first one in the visual order.
9137 (get_visually_first_element): New function, refactored from common
9138 parts of next_element_from_buffer, next_element_from_string, and
9139 next_element_from_c_string.
9140 (tool_bar_lines_needed, redisplay_tool_bar)
9141 (display_menu_bar): Force left-to-right direction. Add a FIXME
9142 comment for making that be controlled by a user option.
9143 (push_it, pop_it): Save and restore the state of the
9144 bidi iterator. Save and restore the bidi_p flag.
9145 (pop_it): Iterate out of display property for string iteration as
9146 well.
9147 (iterate_out_of_display_property): Support iteration over strings.
9148 (handle_single_display_spec): Set up it->bidi_it for iteration
9149 over a display string, and call bidi_init_it.
9150 (handle_single_display_spec, next_overlay_string)
9151 (get_overlay_strings_1, push_display_prop): Set up the bidi
9152 iterator for displaying display or overlay strings.
9153 (forward_to_next_line_start): Don't use the shortcut if
9154 bidi-iterating.
9155 (back_to_previous_visible_line_start): If handle_display_prop
9156 pushed the iterator stack, restore the internal state of the bidi
9157 iterator by calling bidi_pop_it same number of times.
9158 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9159 and we are bidi-iterating, don't decrement the iterator position;
9160 instead, set the first_elt flag in the bidi iterator, to produce
9161 the same effect.
9162 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9163 (push_display_prop): xassert that we are iterating a buffer.
9164 (push_it, pop_it): Save and restore paragraph_embedding member.
9165 (handle_single_display_spec, next_overlay_string)
9166 (get_overlay_strings_1, reseat_1, reseat_to_string)
9167 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9168 correctly. Don't assume unibyte strings are not bidi-reordered.
9169 (compute_display_string_pos)
9170 (compute_display_string_end): Fix handling the case of C string.
9171 (push_it, pop_it): Save and restore from_disp_prop_p.
9172 (handle_single_display_spec, push_display_prop): Set the
9173 from_disp_prop_p flag.
9174 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9175 (pop_it): Call iterate_out_of_display_property only if we are
9176 popping after iteration over a string that came from a display
9177 property. Fix a typo in popping stretch info. Add an assertion
9178 for verifying that the iterator position is in sync with the bidi
9179 iterator.
9180 (handle_single_display_spec, get_overlay_strings_1)
9181 (push_display_prop): Fix initialization of paragraph direction for
9182 string when that of the parent object is not yet determined.
9183 (reseat_1): Call bidi_init_it to resync the bidi
9184 iterator with IT's position. (Bug#7616)
9185 (find_row_edges): If ROW->start.pos gives position
9186 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9187 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9188 Reset the from_disp_prop_p flag.
9189 (SAVE_IT, RESTORE_IT): New macros.
9190 (pos_visible_p, face_before_or_after_it_pos)
9191 (back_to_previous_visible_line_start)
9192 (move_it_in_display_line_to, move_it_in_display_line)
9193 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9194 (try_scrolling, redisplay_window, display_line): Use them when
9195 saving a temporary copy of the iterator and restoring it back.
9196 (back_to_previous_visible_line_start, reseat_1)
9197 (init_iterator): Empty the bidi cache "stack".
9198 (move_it_in_display_line_to): If iterator ended up at
9199 EOL, but we never saw any buffer positions smaller than
9200 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9201 motion in bidi-reordered lines.
9202 (move_it_in_display_line_to): Record prev_method and prev_pos
9203 immediately before the call to set_iterator_to_next. Fixes cursor
9204 motion in bidi-reordered lines with stretch glyphs and strings
9205 displayed in margins. (Bug#8133) (Bug#8867)
9206 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9207 TO_CHARPOS.
640c8776
SM
9208 (pos_visible_p): Support positions in bidi-reordered lines.
9209 Save and restore bidi cache.
0bb23927
EZ
9210
9211 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9212 (bidi_paragraph_info): Delete unused struct.
9213 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9214 (bidi_cache_start): New variable.
9215 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9216 to zero.
9217 (bidi_cache_fetch_state, bidi_cache_search)
9218 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9219 (bidi_cache_find, bidi_peek_at_next_level)
9220 (bidi_level_of_next_char, bidi_find_other_level_edge)
9221 (bidi_move_to_visually_next): Compare cache index with
9222 bidi_cache_start rather than with zero.
9223 (bidi_fetch_char): Accept new argument STRING; all callers
9224 changed. Support iteration over a string. Support strings with
9225 display properties. Support unibyte strings. Fix the type of
9226 `len' according to what STRING_CHAR_AND_LENGTH expects.
9227 (bidi_paragraph_init, bidi_resolve_explicit_1)
9228 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9229 (bidi_level_of_next_char, bidi_move_to_visually_next):
9230 Support iteration over a string.
0bb23927
EZ
9231 (bidi_set_sor_type, bidi_resolve_explicit_1)
9232 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9233 can now be zero (for strings); special values 0 and -1 were
9234 changed to -1 and -2, respectively.
9235 (bidi_char_at_pos): New function.
9236 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9237 Call it instead of FETCH_MULTIBYTE_CHAR.
9238 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9239 initialized to valid values.
9240 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9241 values.
9242 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9243 the test for valid cached positions. Fix the logic for looking up
9244 the sentinel state in the cache. GCPRO the Lisp string we are
9245 iterating.
9246 (bidi_push_it, bidi_pop_it): New functions.
9247 (bidi_initialize): Initialize the bidi cache start stack pointer.
9248 (bidi_cache_ensure_space): New function, refactored from part of
9249 bidi_cache_iterator_state. Don't assume the required size is just
9250 one BIDI_CACHE_CHUNK away.
9251 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9252 (bidi_count_bytes, bidi_char_at_pos): New functions.
9253 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9254 always valid if bidi_cache_idx is valid.
9255 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9256 is valid if it's going to be used.
9257 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9258 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9259 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9260 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9261 (bidi_find_other_level_edge, bidi_cache_start_stack):
9262 All variables related to cache indices are now EMACS_INT.
c965adc5 9263
0bb23927
EZ
9264 * dispextern.h (struct bidi_string_data): New structure.
9265 (struct bidi_it): New member `string'. Make flag members be 1-bit
9266 fields, and put them last in the struct.
640c8776
SM
9267 (compute_display_string_pos, compute_display_string_end):
9268 Update prototypes.
0bb23927
EZ
9269 (bidi_push_it, bidi_pop_it): Add prototypes.
9270 (struct iterator_stack_entry): New members bidi_p,
9271 paragraph_embedding, and from_disp_prop_p.
9272 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9273 (bidi_shelve_cache, bidi_unshelve_cache):
9274 Declare prototypes.
0bb23927
EZ
9275
9276 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9277 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9278 and vector-like objects.
9279
9280 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9281 cache around display iteration.
9282
9283 * window.c (Fwindow_end, window_scroll_pixel_based)
9284 (displayed_window_lines, Frecenter): Save and restore the bidi
9285 cache around display iteration.
9286
3bbd2265
LMI
92872011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9288
9289 * editfns.c (Fdelete_region): Clarify the use of the named
9290 parameters (bug#6788).
9291
adc47434
MR
92922011-07-14 Martin Rudalics <rudalics@gmx.at>
9293
9294 * indent.c (Fvertical_motion): Set and restore w->pointm when
9295 saving and restoring the window's buffer (Bug#9006).
9296
837c31f8
LMI
92972011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9298
9299 * editfns.c (Fstring_to_char): Clarify just what is returned
9300 (bug#6576). Text by Eli Zaretskii.
9301
ac389d0c
JB
93022011-07-13 Juanma Barranquero <lekktu@gmail.com>
9303
9304 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9305
0be0ce47
EZ
93062011-07-13 Eli Zaretskii <eliz@gnu.org>
9307
9308 * buffer.c (mmap_find): Fix a typo.
9309
cd18e7e3
JB
93102011-07-13 Johan Bockgård <bojohan@gnu.org>
9311
9312 Fix execution of x selection hooks.
9313 * xselect.c (Qx_lost_selection_functions)
9314 (Qx_sent_selection_functions): New vars.
9315 (syms_of_xselect): DEFSYM them.
9316 (x_handle_selection_request): Pass Qx_sent_selection_functions
9317 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9318 (x_handle_selection_clear,x_clear_frame_selections):
9319 Pass Qx_lost_selection_functions rather than
9320 Vx_lost_selection_functions to Frun_hook_with_args.
9321
47ea7f44
PE
93222011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9323
ac389d0c 9324 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9325 The old code sometimes used this field without initializing it.
9326
47ea7f44
PE
9327 * alloc.c (gc_sweep): Don't read past end of array.
9328 In theory, the old code could also have corrupted Emacs internals,
9329 though it'd be very unlikely.
9330
bc985c87
AS
93312011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9332
9333 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9334 argument. (Bug#4026)
bc985c87 9335
0cf34688
LMI
93362011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9337
b3dadd76
LMI
9338 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9339 key" (bug#4257).
9340
0cf34688
LMI
9341 * window.c (Fset_window_start): Doc fix (bug#4199).
9342 (Fset_window_hscroll): Ditto.
9343
270768cd
PE
93442011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9345
077e3dda 9346 Fix minor new problems caught by GCC 4.6.1.
270768cd 9347 * term.c (init_tty): Remove unused local.
490011a6 9348 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9349 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9350 not used otherwise.
270768cd 9351
b1f58454
CY
93522011-07-12 Chong Yidong <cyd@stupidchicken.com>
9353
9354 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9355
22b9578d
LMI
93562011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9357
6e70ab07
LMI
9358 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9359 are the mini-buffer and the echo area (bug#3320).
9360
22b9578d
LMI
9361 * term.c (init_tty): Remove support for supdup, c10 and perq
9362 terminals, which are no longer supported (bug#1482).
9363
8974cc9f
JB
93642011-07-10 Johan Bockgård <bojohan@gnu.org>
9365
9366 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9367
a560d974
JD
93682011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9369
9370 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9371 for non-popups (Bug#3642).
9372
1dae0f0a
AS
93732011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9374
268c2c36 9375 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9376 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9377 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9378 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9379 * data.c (fmod): Likewise.
9380 * dispnew.c (swap_glyphs_in_rows): Likewise.
9381 * emacs.c (memory_warning_signal): Likewise.
9382 * floatfns.c (float_error): Likewise.
9383 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9384 (otf_open, font_otf_capability, generate_otf_features)
9385 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9386 Likewise.
9387 * image.c (pbm_read_file): Likewise.
9388 * indent.c (string_display_width): Likewise.
9389 * intervals.c (check_for_interval, search_for_interval)
9390 (inc_interval_count, count_intervals, root_interval)
9391 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9392 * lread.c (defalias): Likewise.
268c2c36 9393 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9394 * regex.c (set_image_of_range_1, set_image_of_range)
9395 (regex_grow_registers): Likewise.
9396 * sysdep.c (strerror): Likewise.
9397 * termcap.c (valid_filename_p, tprint, main): Likewise.
9398 * tparam.c (main): Likewise.
9399 * unexhp9k800.c (run_time_remap, save_data_space)
9400 (update_file_ptrs, read_header, write_header, calculate_checksum)
9401 (copy_file, copy_rest, display_header): Likewise.
9402 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9403 Likewise.
9404 * xdisp.c (check_it): Likewise.
9405 * xfaces.c (register_color, unregister_color, unregister_colors):
9406 Likewise.
9407 * xfns.c (print_fontset_result): Likewise.
9408 * xrdb.c (member, fatal, main): Likewise.
9409
99033785
PE
94102011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9411
9412 Fix minor problems found by static checking (Bug#9031).
9413 * chartab.c (char_table_set_range, map_sub_char_table):
9414 Remove unused locals.
9415 (uniprop_table): Now static.
9416 * composite.c (_work_char): Remove unused static var.
9417
9cb2ac56
JB
94182011-07-09 Juanma Barranquero <lekktu@gmail.com>
9419
9420 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9421
f25661f0
JD
94222011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9423
9424 * gtkutil.c (qttip_cb): Remove code without function.
9425
8278c4fe
EZ
94262011-07-09 Eli Zaretskii <eliz@gnu.org>
9427
9428 * w32.c (pthread_sigmask): New stub.
9429
1692ae2d 94302011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9431
8a6ebd58 9432 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9433 sigprocmask is portable only for single-threaded applications, and
9434 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9435 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9436 (LIBES): Use it.
9437 * callproc.c (Fcall_process):
9438 * process.c (create_process):
9439 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9440 Use pthread_sigmask, not sigprocmask.
123403e4 9441
1b854618
JD
94422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9443
9444 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9445 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9446 wrong (Bug#8591).
9447
3fe4b549
JD
94482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9449
0ce7e563
JD
9450 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9451 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9452 (xg_hide_tooltip): Fix comment.
9453
3fe4b549
JD
9454 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9455 in registerServicesMenuSendTypes.
9456 (validRequestorForSendType): Don't check ns_return_types.
9457
9458 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9459 ns_return_type.
9460
5df75e47
JR
94612011-07-08 Jason Rumney <jasonr@gnu.org>
9462
22610910
JR
9463 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9464 SH_SHOW for hidden windows (Bug#5482).
9465
5df75e47
JR
9466 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9467 frame struct members of non-existent frames (Bug#6284).
9468
699c10bd
JD
94692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9470
4393663b
JD
9471 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9472 variable firstTime not needed on OSX >= 10.6.
9473 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9474 >= 10.5. Use setKnobProportion, setDoubleValue.
9475
9476 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9477 (MAC_OS_X_VERSION_10_5): Define if not defined.
9478 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9479 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9480 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9481
9482 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9483 cString and lossyCString on OSX >= 10.4.
4393663b 9484
58179cce 9485 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9486 sizeToFit on OSX >= 10.2.
9487
9488 * nsimage.m (allocInitFromFile): Don't use deprecated method
9489 bestRepresentationForDevice on OSX >= 10.6.
9490
9491 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9492 to avoid warning.
9493
9494 * emacs.c: Declare unexec_init_emacs_zone.
9495
a63e0781
JD
9496 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9497
699c10bd
JD
9498 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9499
9500 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9501 on svcsMenu (Bug#8842).
9502
9503 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9504 ns_return_types.
9505 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9506
9507 * nsterm.m (QUTF8_STRING): Declare.
9508 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9509 (validRequestorForSendType): Return type is (id).
9510 Change indexOfObjectIdenticalTo to indexOfObject.
9511 Check if we have local selection before returning self (Bug#8842).
9512 (writeSelectionToPasteboard): Put local selection into paste board
9513 if we have a local selection (Bug#8842).
9514 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9515
9516 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9517 (ns_get_local_selection): Declare.
9518
54e10184
LMI
95192011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9520
9888ff71
LMI
9521 * keymap.c (describe_map_tree): Don't insert a double newline at
9522 the end of the buffer (bug#1169) and return whether we inserted
9523 something.
9524
54e10184
LMI
9525 * callint.c (Fcall_interactively): Change "reading args" to
9526 "providing args" to try to clarify what it does (bug#1010).
9527
15fa4783
KH
95282011-07-07 Kenichi Handa <handa@m17n.org>
9529
9530 * composite.c (composition_compute_stop_pos): Ignore a static
9531 composition starting before CHARPOS (Bug#8915).
9532
9533 * xdisp.c (handle_composition_prop): Likewise.
9534
a8815b00
EZ
95352011-07-07 Eli Zaretskii <eliz@gnu.org>
9536
9537 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9538 (Bug#9015)
9539
ef7b981d 95402011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9541
9542 * character.h (unicode_category_t): New enum type.
9543
9544 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9545 (Qchar_code_property_table): New variable.
9546 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9547 (UNIPROP_COMPRESSED_FORM_P): New macros.
9548 (char_table_ascii): Uncompress the compressed values.
9549 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9550 Uncompress the compressed values.
ac389d0c 9551 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9552 (char_table_ref_and_range): Uncompress the compressed values.
9553 (sub_char_table_set): New arg is_uniprop. Callers changed.
9554 Uncompress the compressed values.
9555 (sub_char_table_set_range): Args changed. Callers changed.
9556 (char_table_set_range): Adjuted for the above change.
9557 (map_sub_char_table): Delete args default_val and parent. Add arg
9558 top. Give decoded values to a Lisp function.
640c8776 9559 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9560 values to a Lisp function. Gcpro more variables.
9561 (uniprop_table_uncompress)
9562 (uniprop_decode_value_run_length): New functions.
9563 (uniprop_decoder, uniprop_decoder_count): New variables.
9564 (uniprop_get_decoder, uniprop_encode_value_character)
9565 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9566 New functions.
9567 (uniprop_encoder, uniprop_encoder_count): New variables.
9568 (uniprop_get_encoder, uniprop_table)
9569 (Funicode_property_table_internal, Fget_unicode_property_internal)
9570 (Fput_unicode_property_internal): New functions.
9571 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9572 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9573 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9574 char-code-property-alist.
9575
640c8776 9576 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9577 Vunicode_category_table.
9578
640c8776 9579 * font.c (font_range): Adjust for the change of
c805dec0
KH
9580 Vunicode_category_table.
9581
76b397fb
DN
95822011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9583
9584 * m/iris4d.h: Remove file, move contents ...
9585 * s/irix6-5.h: ... here.
9586
22b4128e
PE
95872011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9588
9589 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9590 * alloc.c (mark_buffer):
9591 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9592 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9593 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9594 This isn't true in general, and it's particularly not true
9595 if Emacs is configured with --with-wide-int.
9596 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9597 New macros, used in the buffer.c change.
9598
869795d6
JD
95992011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9600
9601 * xsettings.c: Use both GConf and GSettings if both are available.
9602 (store_config_changed_event): Add comment.
9603 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9604 (store_tool_bar_style_changed): New functions.
5e617bc2 9605 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9606 (struct xsettings): Move font inside HAVE_XFT.
9607 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9608 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9609 Move inside HAVE_XFT.
640c8776 9610 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9611 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9612 also.
9613 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9614 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9615 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9616 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9617 (parse_settings): Move check for font inside HAVE_XFT.
9618 (read_settings, apply_xft_settings): Add comment.
9619 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9620 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9621 call store_font_name_changed.
9622 (xft_settings_event): Add comment.
9623 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9624 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9625 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9626 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9627 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9628 (xsettings_get_system_font, xsettings_get_system_normal_font):
9629 Add comment.
869795d6 9630
d8ed26bd
PE
96312011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9632
9633 Random fixes. E.g., (random) never returned negative values.
9634 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9635 subseconds part to the entropy, as that's a bit more random.
9636 Prefer signed to unsigned, since the signedness doesn't matter and
9637 in general we prefer signed. When given a limit, use a
9638 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9639 latter isn't right if USE_2_TAGS_FOR_INTS.
9640 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9641 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9642
cabf1cac
SM
96432011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9644
9645 * textprop.c (text_property_stickiness):
9646 Obey Vtext_property_default_nonsticky.
9647 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9648 * w32fns.c (syms_of_w32fns):
9649 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9650
6e9b2be9
PE
96512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9652
9653 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9654 This is more efficient than Ffile_directory_p and avoids a minor race.
9655
90186c68
LMI
96562011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9657
7c301272
LMI
9658 * buffer.c (Foverlay_put): Say what the return value is
9659 (bug#7835).
9660
c4f2d8d4
LMI
9661 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9662 is a directory before asking whether to use the file name
9663 (bug#7564).
ad637907
LMI
9664 (barf_or_query_if_file_exists): Make the "File is a directory"
9665 error be more correct.
c4f2d8d4 9666
90186c68
LMI
9667 * fns.c (Frequire): Remove the mention of the .gz files, since
9668 that's installation-specific, but keep the mention of
9669 `get-load-suffixes'.
9670
da64016e
PE
96712011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9672
9673 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9674 Report string overflow if the output is too long.
9675
7d47b580
JB
96762011-07-04 Juanma Barranquero <lekktu@gmail.com>
9677
a555cb87
JB
9678 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9679 (syms_of_gnutls): Remove duplicate DEFSYM for
9680 Qgnutls_bootprop_verify_hostname_error, an error for
9681 Qgnutls_bootprop_verify_error (which is no longer used).
9682
7d47b580
JB
9683 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9684 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9685 Also (re)move comments that are misplaced or no longer relevant.
9686
1e49bfab
LMI
96872011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9688
9689 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9690
1485f4c0
CY
96912011-07-03 Chong Yidong <cyd@stupidchicken.com>
9692
9693 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9694 and background color parameters if they have been changed.
9695
a9ab721e
LMI
96962011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9697
9698 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9699
cf7cff57
PE
97002011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9701
2e13213d
PE
9702 * xsettings.c (SYSTEM_FONT): Define only when used.
9703 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9704
cf7cff57
PE
9705 * keymap.c (access_keymap_1): Now static.
9706
7a8e04f7
CY
97072011-07-02 Chong Yidong <cyd@stupidchicken.com>
9708
9709 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9710 leave any prefix arg for the up event (Bug#1586).
9711
61352f62
LMI
97122011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9713
69bb1ef7
LMI
9714 * lread.c (syms_of_lread): Mention single symbols defined by
9715 `defvar' or `defconst' (bug#7154).
9716
61352f62 9717 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9718 (Frequire): Mention get-load-suffixes.
61352f62 9719
28545e04
MR
97202011-07-02 Martin Rudalics <rudalics@gmx.at>
9721
9722 * window.h (window): Remove clone_number slot.
9723 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9724 Remove.
9725 (make_parent_window, make_window, saved_window)
9726 (Fset_window_configuration, save_window_save): Don't deal with
9727 clone numbers.
9728 * buffer.c (Qclone_number): Remove declaration.
9729 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9730
3349e122
SM
97312011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9732
9733 Add multiple inheritance to keymaps.
9734 * keymap.c (Fmake_composed_keymap): New function.
9735 (Fset_keymap_parent): Simplify.
9736 (fix_submap_inheritance): Remove.
9737 (access_keymap_1): New function extracted from access_keymap to handle
9738 embedded parents and handle lists of maps.
9739 (access_keymap): Use it.
9740 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9741 (Fcopy_keymap): Handle embedded parents.
9742 (Fcommand_remapping, define_as_prefix): Simplify.
9743 (Fkey_binding): Simplify.
9744 (syms_of_keymap): Move minibuffer-local-completion-map,
9745 minibuffer-local-filename-completion-map,
9746 minibuffer-local-must-match-map, and
9747 minibuffer-local-filename-must-match-map to Elisp.
9748 (syms_of_keymap): Defsubr make-composed-keymap.
9749 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9750 (parse_menu_item): Trivial simplification.
9751
3279eb87
GM
97522011-07-01 Glenn Morris <rgm@gnu.org>
9753
9754 * Makefile.in (SETTINGS_LIBS): Fix typo.
9755
4550efdf
KI
97562011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9757
9758 * coding.c (Fencode_coding_string): Record the last coding system
9759 used, as the function doc string says (bug#8738).
9760
0949d2b6
JD
97612011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9762
9763 * xsettings.c (store_monospaced_changed): Take new font as arg and
9764 check for change against current_mono_font.
9765 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9766 (emacs_settings_constructor, emacs_settings_get_property)
9767 (emacs_settings_set_property, emacs_settings_class_init)
9768 (emacs_settings_init, gsettings_obj): Remove.
9769 (something_changedCB): New function for HAVE_GSETTINGS.
9770 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9771 with value as argument.
9772 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9773 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9774 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9775 "changed".
9776
9777 * xgselect.c: Add defined (HAVE_GSETTINGS).
9778 (xgselect_initialize): Ditto.
9779
9780 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9781 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9782 xg_select.
9783
bbc6b304
PE
97842011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9785
9786 * eval.c (struct backtrace): Simplify and port the data structure.
9787 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9788 signed bit field, as this assumption is not portable and it makes
9789 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9790 "char debug_on_exit : 1" as this is not portable either; instead,
9791 use the portable "unsigned int debug_on_exit : 1". Remove unused
9792 member evalargs. Remove obsolete comments about cc bombing out.
9793
9851bfc5
JD
97942011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9795
51bb811f 9796 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9797 Let HAVE_GSETTINGS override HAVE_GCONF.
9798 (store_monospaced_changed): New function.
9799 (EMACS_SETTINGS): A new type derived from GObject to handle
9800 GSettings notifications.
9801 (emacs_settings_constructor, emacs_settings_get_property)
9802 (emacs_settings_set_property, emacs_settings_class_init):
9803 New functions.
9804 (gsettings_client, gsettings_obj): New variables.
9805 (GSETTINGS_SCHEMA): New define.
9806 (something_changedCB): Call store_monospaced_changed.
9807 (init_gsettings): New function.
9808 (xsettings_initialize): Call init_gsettings.
9809 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9810 to NULL.
9811
640c8776 9812 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9813 GCONF_CFLAGS/LIBS.
9814
5386012d
MR
98152011-06-29 Martin Rudalics <rudalics@gmx.at>
9816
9817 * window.c (resize_root_window, grow_mini_window)
9818 (shrink_mini_window): Rename Qresize_root_window to
9819 Qwindow_resize_root_window and Qresize_root_window_vertically to
9820 Qwindow_resize_root_window_vertically.
9821
f13e0b08
PE
98222011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9823
9824 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9825
94515237
JB
98262011-06-27 Juanma Barranquero <lekktu@gmail.com>
9827
9828 * makefile.w32-in: Redesign dependencies so they reflect more
9829 clearly which files are directly included by each source file,
9830 and not through other includes.
9831
e43b6e43
MR
98322011-06-27 Martin Rudalics <rudalics@gmx.at>
9833
9834 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9835 (sort_overlays, overlay_strings): When an overlay's clone number
9836 matches the window's clone number process the overlay even if
9837 the overlay's window property doesn't match the current window.
9838
d68443dc
MR
9839 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9840 (Fwindow_hchild): Rename to Fwindow_left_child.
9841 (Fwindow_next): Rename to Fwindow_next_sibling.
9842 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9843 (resize_window_check): Rename to window_resize_check.
9844 (resize_window_apply): Rename to window_resize_apply.
9845 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9846 (Fdelete_other_windows_internal, resize_frame_windows)
9847 (Fsplit_window_internal, Fdelete_window_internal)
9848 (grow_mini_window, shrink_mini_window)
9849 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9850
c7e73be5
JD
98512011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9852
9853 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9854 (emacs_fixed_set_min_size): Remove.
9855 (emacs_fixed_new): Take frame as argument.
9856
9857 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9858 (_EmacsFixedPrivate): Remove minwidth/height.
9859 Add struct frame *f.
9860 (emacs_fixed_init): Initialize priv->f.
9861 (get_parent_class, emacs_fixed_set_min_size): Remove.
9862 (emacs_fixed_new): Set priv->f to argument.
9863 (emacs_fixed_get_preferred_width)
9864 (emacs_fixed_get_preferred_height): Use min_width/height from
9865 frames size_hint to set minimum and natural (Bug#8919).
9866 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9867 and use min_width/height from frames size_hint to set
9868 min_width/height (Bug#8919).
9869
9870 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9871 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9872 Fix indentation.
c7e73be5 9873
cf99dcf8
EZ
98742011-06-26 Eli Zaretskii <eliz@gnu.org>
9875
9876 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9877 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9878 called at ZV.
9879
029529ac
CY
98802011-06-26 Chong Yidong <cyd@stupidchicken.com>
9881
9882 * process.c (wait_reading_process_output): Bypass select if
9883 waiting for a cell while ignoring keyboard input, and input is
9884 pending. Suggested by Jan Djärv (Bug#8869).
9885
7a7ef429
PE
98862011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9887
9888 Use gnulib's dup2 module instead of rolling our own.
9889 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9890
11fdef7d 98912011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9892
9893 * dispnew.c (scrolling_window): Before scrolling, turn off a
9894 mouse-highlight in the window being scrolled.
9895
cd3520a4
JB
98962011-06-24 Juanma Barranquero <lekktu@gmail.com>
9897
9898 Move DEFSYM to lisp.h and use everywhere.
9899
9900 * character.h (DEFSYM): Move declaration...
9901 * lisp.h (DEFSYM): ...here.
9902
9903 * gnutls.c:
9904 * minibuf.c:
9905 * w32menu.c:
9906 * w32proc.c:
9907 * w32select.c: Don't include character.h.
9908
9909 * alloc.c (syms_of_alloc):
9910 * buffer.c (syms_of_buffer):
9911 * bytecode.c (syms_of_bytecode):
9912 * callint.c (syms_of_callint):
9913 * casefiddle.c (syms_of_casefiddle):
9914 * casetab.c (init_casetab_once):
9915 * category.c (init_category_once, syms_of_category):
9916 * ccl.c (syms_of_ccl):
9917 * cmds.c (syms_of_cmds):
9918 * composite.c (syms_of_composite):
9919 * dbusbind.c (syms_of_dbusbind):
9920 * dired.c (syms_of_dired):
9921 * dispnew.c (syms_of_display):
9922 * doc.c (syms_of_doc):
9923 * editfns.c (syms_of_editfns):
9924 * emacs.c (syms_of_emacs):
9925 * eval.c (syms_of_eval):
9926 * fileio.c (syms_of_fileio):
9927 * fns.c (syms_of_fns):
9928 * frame.c (syms_of_frame):
9929 * fringe.c (syms_of_fringe):
9930 * insdel.c (syms_of_insdel):
9931 * keymap.c (syms_of_keymap):
9932 * lread.c (init_obarray, syms_of_lread):
9933 * macros.c (syms_of_macros):
9934 * msdos.c (syms_of_msdos):
9935 * print.c (syms_of_print):
9936 * process.c (syms_of_process):
9937 * search.c (syms_of_search):
9938 * sound.c (syms_of_sound):
9939 * syntax.c (init_syntax_once, syms_of_syntax):
9940 * terminal.c (syms_of_terminal):
9941 * textprop.c (syms_of_textprop):
9942 * undo.c (syms_of_undo):
9943 * w32.c (globals_of_w32):
9944 * window.c (syms_of_window):
9945 * xdisp.c (syms_of_xdisp):
9946 * xfaces.c (syms_of_xfaces):
9947 * xfns.c (syms_of_xfns):
9948 * xmenu.c (syms_of_xmenu):
9949 * xsettings.c (syms_of_xsettings):
9950 * xterm.c (syms_of_xterm): Use DEFSYM.
9951
4228cf16
TZ
99522011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9953
cd3520a4 9954 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9955
7fcccf1e
PE
99562011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9957
7efb4e0e
PE
9958 Integer and buffer overflow fixes (Bug#8873).
9959
ff5844ad
PE
9960 * print.c (printchar, strout): Check for string overflow.
9961 (PRINTPREPARE, printchar, strout):
9962 Don't set size unless allocation succeeds.
9963
90532f02
PE
9964 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9965 for sizes. Check for string overflow more accurately.
9966 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9967
6d84508d
PE
9968 * macros.c: Integer and buffer overflow fixes.
9969 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9970 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9971 Use ptrdiff_t, not int, for sizes.
9972 Don't increment bufsize until after realloc succeeds.
9973 Check for size-calculation overflow.
9974 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9975
437b2cb4
PE
9976 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9977
8b9ac8b4
PE
9978 * lread.c: Integer overflow fixes.
9979 (read_integer): Radix is now EMACS_INT, not int,
9980 to improve quality of diagnostics for out-of-range radices.
9981 Calculate buffer size correctly for out-of-range radices.
9982 (read1): Check for integer overflow in radices, and in
9983 read-circle numbers.
82cb60d3
PE
9984 (read_escape): Avoid int overflow.
9985 (Fload, openp, read_buffer_size, read1)
9986 (substitute_object_recurse, read_vector, read_list, map_obarray):
9987 Use ptrdiff_t, not int, for sizes.
9988 (read1): Use EMACS_INT, not int, for sizes.
20270765 9989 Check for size overflow.
8b9ac8b4 9990
7fcccf1e
PE
9991 * image.c (cache_image): Check for size arithmetic overflow.
9992
bfbbd7e7
PE
9993 * lread.c: Integer overflow issues.
9994 (saved_doc_string_size, saved_doc_string_length)
9995 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9996 Now ptrdiff_t, not int.
9997 (read1): Don't assume doc string length fits in int. Check for
9998 out-of-range doc string lengths.
9999 (read_list): Don't assume file position fits in int.
39019e54 10000 (read_escape): Check for hex character overflow.
bfbbd7e7 10001
4e323265
LL
100022011-06-22 Leo Liu <sdl.web@gmail.com>
10003
10004 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10005 Move to minibuffer.el.
10006
85fece3e
PE
100072011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10008
20b84ce9 10009 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10010 The following patches are for when GLYPH_DEBUG && !XASSERT.
10011 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10012 * dispnew.c (flush_stdout):
10013 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10014 Mark as externally visible.
10015 * dispnew.c (check_window_matrix_pointers): Now static.
10016 * dispnew.c (window_to_frame_vpos):
10017 * xfns.c (unwind_create_frame):
10018 * xterm.c (x_check_font): Remove unused local.
10019 * scroll.c (CHECK_BOUNDS):
10020 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10021 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10022 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10023 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10024 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10025 Now static.
10026 (debug_method_add): Use va_list and vsprintf rather than relying
10027 on undefined behavior with wrong number of arguments.
10028 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10029 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10030 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10031 since we're not interested in debugging glyphs with old libraries.
10032 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10033 GCC 4.6.0's static checking.
10034
0766b489
PE
100352011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10036
31fd4b32
PE
10037 Integer overflow and signedness fixes (Bug#8873).
10038 A few related buffer overrun fixes, too.
10039
b79e8648
PE
10040 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10041
0766b489
PE
10042 * dispextern.h (struct face.stipple):
10043 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10044 (x_bitmap_mask, x_allocate_bitmap_record)
10045 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10046 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10047 (x_create_bitmap_from_xpm_data):
10048 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10049 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10050 (.bitmaps_last):
10051 * xfaces.c (load_pixmap):
10052 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10053 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10054 (.bitmaps_last, struct x_output.icon_bitmap):
10055 Use ptrdiff_t, not int, for bitmap indexes.
10056 (x_allocate_bitmap_record): Check for size overflow.
10057 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10058
b081724f
PE
10059 Use ptrdiff_t, not int, for overlay counts.
10060 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10061 * editfns.c (overlays_around, get_pos_property):
10062 * textprop.c (get_char_property_and_overlay):
10063 * xdisp.c (next_overlay_change, note_mouse_highlight):
10064 * xfaces.c (face_at_buffer_position):
21514da7
PE
10065 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10066 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10067 (Fnext_overlay_change, Fprevious_overlay_change)
10068 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10069 Use ptrdiff_t, not int, for sizes.
21514da7 10070 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10071
3de73e5e
PE
10072 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10073
2606c57b
PE
10074 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10075 (x_session_initialize): Do not assume string length fits in int.
10076
aaafe47a
PE
10077 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10078 This is unlikely, but can occur if DPI is outlandish.
10079
2674ddc8 10080 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10081 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10082
28154962
PE
10083 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10084 * xrdb.c (magic_file_p, search_magic_path):
10085 Omit last arg SUFFIX; it was always 0. All callers changed.
10086 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10087
7de51af5
PE
10088 * xfont.c (xfont_match): Avoid need for strlen.
10089
25ed6cc3
PE
10090 * xfns.c: Don't assume strlen fits in int.
10091 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10092
4eab31dd
PE
10093 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10094 not unsigned long, as we prefer signed integers. All callers changed.
10095 Detect integer overflow in repeat count.
10096 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10097 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10098
171e2a58
PE
10099 * termcap.c: Don't assume sizes fit in int and never overflow.
10100 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10101 (gobble_line): Check for size-calculation overflow.
10102
ad39faca 10103 * minibuf.c (Fread_buffer):
6e5bb2dc 10104 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10105 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10106 Don't assume string length fits in int.
10107
52c61c22 10108 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10109 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10110
b5b8c9e5
PE
10111 * font.c: Don't assume string length fits in int.
10112 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10113 Use ptrdiff_t, not int.
ccd6111c
PE
10114 (font_intern_prop): Don't assume string length fits in int.
10115 Don't assume integer property fits in fixnum.
10116 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10117
882f0d81 10118 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10119 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10120 Reformulate so as not to need the command string.
10121 Invoke gzip -cd rather than gunzip, as it's more portable.
10122 (lock_info_type, lock_file_1, lock_file):
10123 Don't assume pid_t and time_t fit in unsigned long.
10124 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10125 (current_lock_owner): Prefer signed type for sizes.
10126 Use memcpy, not strncpy, where memcpy is what is really wanted.
10127 Don't assume (via atoi) that time_t and pid_t fit in int.
10128 Check for time_t and/or pid_t out of range, e.g., via a network share.
10129 Don't alloca where an auto var works fine.
10130
93f4cf88
PE
10131 * fileio.c: Fix some integer overflow issues.
10132 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10133 Don't assume string length fits in int.
10134 (directory_file_name): Don't assume string length fits in long.
10135 (make_temp_name): Don't assume pid fits in int, or that its print
10136 length is less than 20.
10137
f3e92b69
PE
10138 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10139
1bfdaf10
PE
10140 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10141
35016e9a
PE
10142 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10143
3d1e65a1
PE
10144 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10145 We prefer signed integers, even for size calculations.
10146
0b963a93
PE
10147 * emacs.c: Don't assume string length fits in 'int'.
10148 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10149 (main): Don't invoke strlen when not needed.
10150
573f4b54
PE
10151 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10152 (XD_DEBUG_MESSAGE): Don't waste a byte.
10153
989f33ba
PE
10154 * callproc.c (getenv_internal_1, getenv_internal)
10155 (Fgetenv_internal):
965d34eb
PE
10156 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10157
e4d29b33
PE
10158 * lread.c (invalid_syntax): Omit length argument.
10159 All uses changed. This doesn't fix a bug, but it simplifies the
10160 code away from its former Hollerith-constant appearance, and it's
10161 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10162 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10163
eb49b136
PE
10164 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10165 This didn't break anything, but it didn't help either.
10166 It's confusing to put a bogus integer in a place where the actual
10167 value does not matter.
9f62aeb1 10168 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10169 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10170
15375a22
PE
10171 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10172 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10173 implementation.
b61cc01c
PE
10174 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10175 We prefer signed types, and the value cannot exceed the EMACS_INT
10176 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10177 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10178 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10179 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10180
53b2623d
PE
10181 * indent.c (sane_tab_width): New function.
10182 (current_column, scan_for_column, Findent_to, position_indentation)
10183 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10184 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10185
51cab52b 10186 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10187
f2ed8a70
PE
10188 * lisp.h (lint_assume): New macro.
10189 * composite.c (composition_gstring_put_cache):
10190 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10191
abe80cc6
PE
10192 * editfns.c, insdel.c:
10193 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10194
b02c740e
PE
10195 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10196
ebc96716
PE
10197 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10198
b4e50fa0 10199 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10200 Use much-faster test for byte-length change.
311d5d7c 10201 Don't assume string byte-length fits in 'int'.
a4cf38e4 10202 Check that character arg fits in 'int'.
85461888 10203 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10204
c0c1ee9f
PE
10205 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10206
a498d7f4
PE
10207 * fns.c (concat): Catch string overflow earlier.
10208 Do not rely on integer wraparound.
10209
51cab52b
PE
10210 * dispextern.h (struct it.overlay_strings_charpos)
10211 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10212 * xdisp.c (forward_to_next_line_start)
10213 (back_to_previous_visible_line_start)
10214 (reseat_at_next_visible_line_start, next_element_from_buffer):
10215 Don't arbitrarily truncate the value of 'selective' to int.
10216
76031fad
PE
10217 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10218
5eb55db9
PE
10219 * composite.c: Don't truncate sizes to 'int'.
10220 (composition_gstring_p, composition_reseat_it)
10221 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10222 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10223 not EMACS_UINT, for indexes.
5eb55db9 10224
0703a717
PE
10225 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10226
d6202519
PE
10227 * buffer.c: Include <verify.h>.
10228 (struct sortvec.priority, struct sortstr.priority):
8961a454 10229 Now EMACS_INT, not int.
c20998a7 10230 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10231 (struct sortstr.size, record_overlay_string)
10232 (struct sortstrlist.size, struct sortlist.used):
10233 Don't truncate size to int.
10234 (record_overlay_string): Check for size-calculation overflow.
d6202519 10235 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10236
d5a19415
JM
102372011-06-22 Jim Meyering <meyering@redhat.com>
10238
029529ac 10239 Don't leak an XBM-image-sized buffer
d5a19415
JM
10240 * image.c (xbm_load): Free the image buffer after using it.
10241
a9041e6c
PE
102422011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10243
10244 Port to Sun C.
10245 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10246 that Sun C diagnosed.
10247 * fns.c (secure_hash): Fix pointer signedness issue.
10248 * intervals.c (static_offset_intervals): New function.
10249 (offset_intervals): Use it.
10250
7f3f739f
LL
102512011-06-21 Leo Liu <sdl.web@gmail.com>
10252
10253 * deps.mk (fns.o):
10254 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10255 sha512.h.
10256
10257 * fns.c (secure_hash): Rename from crypto_hash_function and change
10258 the first arg to accept symbols.
5b66d427 10259 (Fsecure_hash): New primitive.
7f3f739f
LL
10260 (syms_of_fns): New symbols.
10261
76147d94
DD
102622011-06-20 Deniz Dogan <deniz@dogan.se>
10263
10264 * process.c (Fset_process_buffer): Clarify return value in
10265 docstring.
10266
7d7d0045
CY
102672011-06-18 Chong Yidong <cyd@stupidchicken.com>
10268
10269 * dispnew.c (add_window_display_history): Use BVAR.
10270
10271 * xdisp.c (debug_method_add): Use BVAR.
10272 (check_window_end, dump_glyph_matrix, dump_glyph)
10273 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10274
10275 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10276 Likewise.
10277
10278 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10279 check till after the cache is created in init_frame_faces.
10280
ff2bc410
SM
102812011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10282
10283 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10284
28177add
PE
102852011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10286
dd3482fe
PE
10287 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10288 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10289 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10290
393d71f3 10291 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10292 * fileio.c (Finsert_file_contents):
10293 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10294 Remove the old (too-loose) buffer overflow checks.
10295 They weren't needed, since make_gap checks for buffer overflow.
10296 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10297 The old code merely checked for Emacs fixnum overflow, and relied
10298 on undefined (wraparound) behavior. The new code avoids undefined
10299 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10300
2e6813b0 10301 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10302 Tune. Don't use wider integers than needed. Don't use alloca.
10303 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10304
599a9e4f
PE
10305 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10306
99561444
PE
10307 * insdel.c, lisp.h (buffer_overflow): New function.
10308 (insert_from_buffer_1, replace_range, replace_range_2):
10309 * insdel.c (make_gap_larger):
10310 * editfns.c (Finsert_char):
10311 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10312
28177add
PE
10313 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10314
e69dafad
PE
103152011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10316
4baa020d 10317 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10318
b1c46f02
PE
10319 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10320 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10321
e69dafad
PE
10322 * fileio.c: Don't assume EMACS_INT fits in off_t.
10323 (emacs_lseek): New static function.
10324 (Finsert_file_contents, Fwrite_region): Use it.
10325 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10326
566684ea
PE
10327 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10328
e6966cd6
PE
10329 * fns.c: Don't overflow int when computing a list length.
10330 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10331 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10332 truncation on 64-bit hosts. Check for QUIT every
10333 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10334 faster and is responsive enough.
10335 (Flength): Report an error instead of overflowing an integer.
10336 (Fsafe_length): Return a float if the value is not representable
10337 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10338 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10339 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10340
dd0b0efb
PE
10341 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10342 (header_size, word_size): New constants.
10343 (allocate_vectorlike): Don't check size overflow here.
10344 (allocate_vector): Check it here instead, since this is the only
10345 caller of allocate_vectorlike that could cause overflow.
10346 Check that the new vector's length is representable as a fixnum.
10347
86fe5cfe
PE
10348 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10349 The previous code was bogus. For example, next_almost_prime (32)
10350 returned 39, which is undesirable as it is a multiple of 3; and
10351 next_almost_prime (24) returned 25, which is a multiple of 5 so
10352 why was the code bothering to check for multiples of 7?
10353
80e88859
PE
10354 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10355
4a2f0ad6
PE
10356 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10357
f66c7cf8
PE
10358 Variadic C functions now count arguments with ptrdiff_t.
10359 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10360 Back then I didn't know that the Emacs coding style prefers signed int.
10361 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10362 were being counted with int, which may truncate counts on 64-bit
10363 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10364 * lisp.h (struct Lisp_Subr.function.aMANY)
10365 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10366 Arg counts are now ptrdiff_t, not size_t.
10367 All variadic functions and their callers changed accordingly.
10368 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10369 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10370 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10371 * callint.c (Fcall_interactively): Check arg count for overflow,
10372 to avoid potential buffer overrun. Use signed char, not 'int',
10373 for 'varies' array, so that we needn't bother to check its size
10374 calculation for overflow.
10375 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10376 * eval.c (apply_lambda):
10377 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10378 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10379 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10380
a1759b76
PE
10381 * callint.c (Fcall_interactively): Don't use index var as event count.
10382
d96be9fc
PE
10383 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10384 * mem-limits.h (SIZE): Remove; no longer used.
10385
a690a978 10386 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10387
578c21e6
PE
10388 Remove unnecessary casts.
10389 * xterm.c (x_term_init):
10390 * xfns.c (x_set_border_pixel):
10391 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10392 These aren't needed now that we assume ANSI C.
10393
96f53c6c
PE
10394 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10395 It's more likely to cause problems (due to unsigned overflow)
10396 than to cure them.
10397
83c77d31
PE
10398 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10399
ee2079f1
PE
10400 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10401
6da65536
PE
10402 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10403
7147c4a4
PE
10404 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10405
193e32d9
PE
10406 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10407
e5533da6
PE
10408 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10409
9910e595
PE
10410 GLYPH_CODE_FACE returns EMACS_INT, not int.
10411 * dispextern.h (merge_faces):
10412 * xfaces.c (merge_faces):
01103c44
PE
10413 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10414 Don't assume EMACS_INT fits in int.
9910e595 10415
2638320e
PE
10416 * character.h (CHAR_VALID_P): Remove unused parameter.
10417 * fontset.c, lisp.h, xdisp.c: All uses changed.
10418
045eb8d9
PE
10419 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10420
c1f134b5
PE
10421 * fns.c (concat): Minor tuning based on overflow analysis.
10422 This doesn't fix any bugs. Use int to hold character, instead
10423 of constantly refetching from Emacs object. Use XFASTINT, not
10424 XINT, for value known to be a character. Don't bother comparing
10425 a single byte to 0400, as it's always less.
10426
395fcb93 10427 * floatfns.c (Fexpt):
327eeec8
PE
10428 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10429
abbd3d23
PE
10430 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10431 for characters.
10432
684a03ef
PE
10433 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10434
0fed43f3
PE
10435 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10436 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10437 incorrectly succeed when S was a string, because 4294967386 was
10438 truncated before it was used.
10439
8fd02eb7
PE
10440 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10441 Otherwise, an out-of-range integer could cause undefined behavior
10442 on a 64-bit host.
10443
f8c86b69
PE
10444 * composite.c: Use int, not EMACS_INT, for characters.
10445 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10446 EMACS_INT, for values that are known to be in character range.
10447 This doesn't fix any bugs but is the usual style inside Emacs and
10448 may generate better code on 32-bit machines.
10449
34206dd2
PE
10450 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10451 This is for reasons similar to the recent CHAR_STRING fix.
10452 * charset.c (Fencode_char): Check that character arg is actually
10453 a character. Pass an int to ENCODE_CHAR.
10454 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10455 wider than 'int', as a compile-time check to prevent future regressions
10456 in this area.
10457
c5958d4c 10458 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10459
10460 Make sure a 64-bit char is never passed to CHAR_STRING.
10461 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10462 by silently ignoring the top 32 bits, allowing some values
10463 that were far too large to be valid characters.
10464 * character.h: Include <verify.h>.
10465 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10466 arguments are no wider than unsigned, as a compile-time check
10467 to prevent future regressions in this area.
10468 * data.c (Faset):
01103c44 10469 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10470 (Fsubst_char_in_region):
10471 * fns.c (concat):
10472 * xdisp.c (decode_mode_spec_coding):
10473 Adjust to CHAR_STRING's new requirement.
10474 * editfns.c (Finsert_char, Fsubst_char_in_region):
10475 * fns.c (concat): Check that character args are actually
10476 characters. Without this test, these functions did the wrong
10477 thing with wildly out-of-range values on 64-bit hosts.
10478
d37ca623
PE
10479 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10480 These casts should not be needed on 32-bit hosts, either.
10481 * keyboard.c (read_char):
10482 * lread.c (Fload): Remove casts to unsigned.
10483
ea204efb
PE
10484 * lisp.h (UNSIGNED_CMP): New macro.
10485 This fixes comparison bugs on 64-bit hosts.
10486 (ASCII_CHAR_P): Use it.
10487 * casefiddle.c (casify_object):
01103c44 10488 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10489 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10490 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10491 * dispextern.h (FACE_FROM_ID):
10492 * keyboard.c (read_char): Use UNSIGNED_CMP.
10493
41cb286c
PE
10494 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10495 not to EMACS_INT, to avoid GCC warning.
10496
4a1b9832
PE
10497 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10498
55daad71
PE
10499 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10500 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10501 isn't needed on 32-bit machines.
8f95c75c 10502
01103c44
PE
10503 * buffer.c (Fgenerate_new_buffer_name):
10504 Use EMACS_INT for count, not int.
0ceccced 10505 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10506
10507 * data.c (Qcompiled_function): Now static.
10508
c6f072e7
PE
10509 * window.c (window_body_lines): Now static.
10510
20ce5912
PE
10511 * image.c (gif_load): Rename local to avoid shadowing.
10512
9c4c5f81
PE
10513 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10514 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10515 * alloc.c (make_save_value): Integer argument is now of type
10516 ptrdiff_t, not int.
10517 (mark_object): Use ptrdiff_t, not int.
10518 * lisp.h (pD): New macro.
10519 * print.c (print_object): Use it.
10520
c0c5c8ae
PE
10521 * alloc.c: Use EMACS_INT, not int, to count objects.
10522 (total_conses, total_markers, total_symbols, total_vector_size)
10523 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10524 (total_free_floats, total_floats, total_free_intervals)
10525 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10526 Now EMACS_INT, not int. All uses changed.
10527 (Fgarbage_collect): Compute overall total using a double, so that
10528 integer overflow is less likely to be a problem. Check for overflow
10529 when converting back to an integer.
5a25e253
PE
10530 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10531 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10532 These were 'int' variables that could overflow on 64-bit hosts;
10533 they were never used, so remove them instead of repairing them.
211a0b2a 10534 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10535 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10536 Previously, this ceilinged at INT_MAX, but that doesn't work on
10537 64-bit machines.
e46bb31a 10538 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10539
c78baabf 10540 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10541 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10542 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10543 when a (possibly-narrower) signed value would do just as well.
10544 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10545
c9d624c6
PE
10546 * alloc.c: Catch some string size overflows that we were missing.
10547 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10548 for convenience in STRING_BYTES_MAX.
10549 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10550 The definition here is exact; the one in lisp.h was approximate.
10551 (allocate_string_data): Check for string overflow. This catches
10552 some instances we weren't catching before. Also, it catches
10553 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10554 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10555 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10556
c9d624c6
PE
10557 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10558 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10559 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10560
353032ce
PE
10561 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10562
2bccce07
PE
10563 * alloc.c (Fmake_string): Check for out-of-range init.
10564
0ac30604
SM
105652011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10566
10567 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10568
c195f2de
JD
105692011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10570
10571 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10572 xg_get_default_scrollbar_width.
10573
10574 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10575 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10576 (style_changed_cb): Call update_theme_scrollbar_width and call
10577 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10578 all frames (Bug#8505).
10579 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10580 Call gtk_window_set_resizable if HAVE_GTK3.
10581 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10582 and height if HAVE_GTK3 (Bug#8505).
10583 (scroll_bar_width_for_theme): New variable.
10584 (update_theme_scrollbar_width): New function.
10585 (xg_get_default_scrollbar_width): Move code to
10586 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10587 (xg_initialize): Call update_theme_scrollbar_width.
10588
10589 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10590
10591 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10592
e10ac9f1
MR
105932011-06-12 Martin Rudalics <rudalics@gmx.at>
10594
10595 * frame.c (make_frame): Call other_buffer_safely instead of
10596 other_buffer.
10597
10598 * window.c (temp_output_buffer_show): Call display_buffer with
10599 second argument Vtemp_buffer_show_specifiers and reset latter
10600 immediately after the call.
10601 (Vtemp_buffer_show_specifiers): New variable.
10602 (auto_window_vscroll_p, next_screen_context_lines)
10603 (Vscroll_preserve_screen_position): Remove leading asterisks from
10604 doc-strings.
10605
2d3c217e 106062011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10607
7b7f97e8 10608 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10609 * buffer.c (Qclone_number): Remove for now, as it's unused.
10610 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10611 (record_buffer): Remove unused local.
10612 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10613 (set_frame_buffer_list): Remove; unused.
10614 * frame.h (other_visible_frames): Remove decl.
10615 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10616 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10617 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10618 if HAVE_GPM.
10619 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10620 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10621 Define only if HAVE_GPM.
10622 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10623 (update_hints_inhibit): Remove; never set. All uses removed.
10624 * widgetprv.h (emacsFrameClassRec): Remove decl.
10625 * window.c (delete_deletable_window): Now returns void, since it
10626 wasn't returning anything.
10627 (compare_window_configurations): Remove unused locals.
10628 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10629 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10630 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10631 the same widths as pointers. This follows up on the 2011-05-06 patch.
10632 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10633 * xterm.h: Likewise.
10634 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10635
1384b89e
JB
106362011-06-12 Juanma Barranquero <lekktu@gmail.com>
10637
10638 * makefile.w32-in: Update dependencies.
10639 (LISP_H): Add lib/intprops.h.
10640
1100a63c
CY
106412011-06-11 Chong Yidong <cyd@stupidchicken.com>
10642
10643 * image.c (gif_load): Add animation frame delay to the metadata.
10644 (syms_of_image): Use DEFSYM. New symbol `delay'.
10645
6198ccd0
MR
106462011-06-11 Martin Rudalics <rudalics@gmx.at>
10647
10648 * window.c (delete_deletable_window): Re-add.
10649 (Fset_window_configuration): Rewrite to handle dead buffers and
10650 consequently deletable windows.
10651 (window_tree, Fwindow_tree): Remove. Supply functionality in
10652 window.el.
10653 (compare_window_configurations): Simplify code.
10654
b6e3633c
AS
106552011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10656
1ab0dee5
AS
10657 * image.c (imagemagick_load_image): Fix type mismatch.
10658 (Fimagemagick_types): Likewise.
10659
b6e3633c
AS
10660 * window.h (replace_buffer_in_windows): Declare.
10661
9397e56f
MR
106622011-06-11 Martin Rudalics <rudalics@gmx.at>
10663
10664 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10665 Qclone_number. Remove external declaration of Qdelete_window.
10666 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10667 code.
640c8776
SM
10668 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10669 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10670 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10671 buffer list implementation.
10672 (other_buffer_safely): New function.
10673 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10674 calls to replace_buffer_in_windows and
10675 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10676 if allowed.
10677 (record_buffer): Inhibit quitting and rewrite using quittable
10678 functions. Run Qbuffer_list_update_hook if allowed.
10679 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10680 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10681 Move switch-to-buffer to window.el.
9397e56f
MR
10682 (bury-buffer): Move to window.el.
10683 (Vbuffer_list_update_hook): New variable.
10684
10685 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10686 section.
10687
10688 * window.h (resize_frame_windows): Move up in code.
10689 (Fwindow_frame): Remove EXFUN.
10690 (replace_buffer_in_all_windows): Remove prototype.
10691 (replace_buffer_in_windows_safely): Add prototype.
10692
10693 * window.c: Declare Qdelete_window static again. Move down
10694 declaration of select_count.
10695 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10696 (Fother_window): Move to window.el.
10697 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10698 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10699 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10700 window.el.
10701 (replace_buffer_in_windows): Implement by calling
10702 Qreplace_buffer_in_windows.
10703 (replace_buffer_in_all_windows): Remove with some functionality
10704 moved into replace_buffer_in_windows_safely.
10705 (replace_buffer_in_windows_safely): New function.
10706 (select_window_norecord, select_frame_norecord): Move in front
10707 of run_window_configuration_change_hook. Remove now obsolete
10708 declarations.
640c8776
SM
10709 (Fset_window_buffer): Rewrite doc-string.
10710 Call Qrecord_window_buffer.
9397e56f
MR
10711 (keys_of_window): Move binding for other-window to window.el.
10712
b50691aa
CY
107132011-06-11 Chong Yidong <cyd@stupidchicken.com>
10714
10715 * dispextern.h (struct image): Replace data member, whose int_val
10716 and ptr_val fields were not used by anything, with a single
10717 lisp_val object.
10718
10719 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10720 (gif_clear_image, gif_load, imagemagick_load_image)
10721 (gs_clear_image, gs_load): Callers changed.
10722
3f754b86
PE
107232011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10724
cca69397
PE
10725 * buffer.h: Include <time.h>, for time_t.
10726 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10727
109e28d0
PE
10728 Fix minor problems found by static checking.
10729
60737f02
PE
10730 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10731
4b66faf3
PE
10732 Make identifiers static if they are not used in other modules.
10733 * data.c (Qcompiled_function, Qframe, Qvector):
10734 * image.c (QimageMagick, Qsvg):
10735 * minibuf.c (Qmetadata):
10736 * window.c (resize_window_check, resize_root_window): Now static.
10737 * window.h (resize_window_check, resize_root_window): Remove decls.
10738
109e28d0
PE
10739 * window.c (window_deletion_count, delete_deletable_window):
10740 Remove; unused.
46a4ce9e
PE
10741 (window_body_lines): Now static.
10742 (Fdelete_other_windows_internal): Mark vars as initialized.
10743 Make sure 'resize_failed' is initialized.
10744 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10745 (resize_window_apply): Remove unused local.
10746 * window.h (delete_deletable_window): Remove decl.
10747
109e28d0 10748 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10749 (imagemagick_load_image): Fix pointer signedness problem by changing
10750 last arg from unsigned char * to char *. All uses changed.
10751 Also, fix a local for similar reasons.
10752 Remove unused locals. Remove locals to avoid shadowing.
10753 (fn_rsvg_handle_free): Remove; unused.
10754 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10755 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10756
3f754b86
PE
10757 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10758
2547adb1
CY
107592011-06-10 Chong Yidong <cyd@stupidchicken.com>
10760
10761 * image.c (gif_load): Fix omitted cast error introduced by
10762 2011-06-06 change.
10763
2c8e37d4
MR
107642011-06-10 Martin Rudalics <rudalics@gmx.at>
10765
10766 * window.h (resize_proportionally, orig_total_lines)
10767 (orig_top_line): Remove from window structure.
10768 (set_window_height, set_window_width, change_window_heights)
10769 (Fdelete_window): Remove prototypes.
10770 (resize_frame_windows): Remove duplicate declaration.
10771
440a42e3
EZ
107722011-06-10 Eli Zaretskii <eliz@gnu.org>
10773
10774 * window.h (resize_frame_windows, resize_window_check)
10775 (delete_deletable_window, resize_root_window)
10776 (resize_frame_windows): Declare prototypes.
10777
10778 * window.c (resize_window_apply): Make definition be "static" to
10779 match the prototype.
10780
562dd5e9
MR
107812011-06-10 Martin Rudalics <rudalics@gmx.at>
10782
10783 * window.c: Remove declarations of Qwindow_size_fixed,
10784 window_min_size_1, window_min_size_2, window_min_size,
10785 size_window, window_fixed_size_p, enlarge_window, delete_window.
10786 Remove static from declaration of Qdelete_window, it's
10787 temporarily needed by Fbury_buffer.
10788 (replace_window): Don't assign orig_top_line and
10789 orig_total_lines.
10790 (Fdelete_window, delete_window): Remove. Window deletion is
10791 handled by window.el.
640c8776
SM
10792 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10793 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10794 (Fdelete_other_windows): Remove. Deleting other windows is
10795 handled by window.el.
10796 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10797 handled in window.el.
10798 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10799 Window minimum sizes are handled in window.el.
10800 (shrink_windows, size_window, set_window_height)
10801 (set_window_width, change_window_heights, window_height)
10802 (window_width, CURBEG, CURSIZE, enlarge_window)
10803 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10804 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10805 handled in window.el.
10806 (make_dummy_parent): Rename to make_parent_window and give it a
10807 second argument horflag.
10808 (make_window): Don't set resize_proportionally any more.
10809 (Fsplit_window): Remove. Windows are split in window.el.
10810 (save_restore_action, save_restore_orig_size)
10811 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10812 Resize mini windows in window.el.
10813 (grow_mini_window, shrink_mini_window): Implement by calling
10814 Qresize_root_window_vertically, resize_window_check and
10815 resize_window_apply.
640c8776
SM
10816 (saved_window, Fset_window_configuration, save_window_save):
10817 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10818 resize_proportionally.
10819 (window_min_height, window_min_width): Move to window.el.
10820 (keys_of_window): Move bindings for delete-other-windows,
10821 split-window, delete-window and enlarge-window to window.el.
10822
10823 * buffer.c: Temporarily extern Qdelete_window.
10824 (Fbury_buffer): Temporarily call Qdelete_window instead of
10825 Fdelete_window (Fbury_buffer will move to window.el soon).
10826
10827 * frame.c (set_menu_bar_lines_1): Remove code handling
10828 orig_top_line and orig_total_lines.
10829
10830 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10831 set_window_height but set heights directly.
10832 (change_frame_size_1): Use resize_frame_windows.
10833
10834 * xdisp.c (init_xdisp): Don't use set_window_height but set
10835 heights directly.
10836
640c8776
SM
10837 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10838 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10839 run_window_configuration_change_hook.
10840
10841 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10842 instead of change_window_heights and run
10843 run_window_configuration_change_hook.
10844
1a13852e
MR
108452011-06-09 Martin Rudalics <rudalics@gmx.at>
10846
10847 * window.c (replace_window): Rename second argument REPLACEMENT to
10848 NEW. New third argument SETFLAG. Rewrite.
10849 (delete_window, make_dummy_parent): Call replace_window with
10850 third argument 1.
10851 (window_list_1): Move down in code.
10852 (run_window_configuration_change_hook): Move set_buffer part
10853 before select_frame_norecord part in order to unwind correctly.
10854 Rename count1 to count.
10855 (recombine_windows, delete_deletable_window, resize_root_window)
10856 (Fdelete_other_windows_internal)
10857 (Frun_window_configuration_change_hook, make_parent_window)
10858 (resize_window_check, resize_window_apply, Fresize_window_apply)
10859 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10860 (Fdelete_window_internal, Fresize_mini_window_internal):
10861 New functions.
1a13852e
MR
10862 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10863
f3d1777e
MR
108642011-06-08 Martin Rudalics <rudalics@gmx.at>
10865
496e208e
MR
10866 * window.h (window): Add some new members to window structure -
10867 normal_lines, normal_cols, new_total, new_normal, clone_number,
10868 splits, nest, prev_buffers, next_buffers.
10869 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10870 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10871
f3d1777e
MR
10872 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10873 Remove.
496e208e
MR
10874 (make_dummy_parent): Set new members of windows structure.
10875 (make_window): Move down in code. Handle new members of window
10876 structure.
10877 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10878 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10879 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10880 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10881 (Fset_window_next_buffers, Fset_window_clone_number):
10882 New functions.
496e208e
MR
10883 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10884 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10885 Doc-string fixes.
10886 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10887 Argument WINDOW can be now internal window too.
10888 (Fwindow_use_time): Move up in code.
10889 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10890 Rewrite doc-string.
10891 (Fset_window_configuration, saved_window)
10892 (Fcurrent_window_configuration, save_window_save): Handle new
10893 members of window structure.
b9e809c2
MR
10894 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10895 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10896 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10897 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10898 Qget_mru_window, Qresize_root_window,
10899 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10900 Qauto_buffer_name; staticpro them.
f3d1777e 10901
abde8f8c
MR
109022011-06-07 Martin Rudalics <rudalics@gmx.at>
10903
10904 * window.c (Fwindow_total_size, Fwindow_left_column)
10905 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10906 (Fwindow_list_1): New functions.
10907 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10908 (Fwindow_width, Fscroll_left, Fscroll_right):
10909 Use window_body_cols instead of window_box_text_cols.
10910 (delete_window, Fset_window_configuration):
10911 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10912 (delete_all_subwindows): Take a window as argument and not a
10913 structure. Rewrite.
190b47e6
MR
10914 (window_loop): Remove handling of GET_LRU_WINDOW and
10915 GET_LARGEST_WINDOW.
10916 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10917
10918 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10919 window_box_text_cols. delete_all_subwindows now takes a
10920 Lisp_Object as argument.
abde8f8c 10921
640c8776
SM
10922 * indent.c (compute_motion, Fcompute_motion):
10923 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10924
fa8a67e6
MR
10925 * frame.c (delete_frame): Call delete_all_subwindows with root
10926 window as argument.
10927
a54e3482
DC
109282011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10929
10930 * fns.c (Fputhash): Document return value.
10931
60002bf5
CY
109322011-06-06 Chong Yidong <cyd@stupidchicken.com>
10933
10934 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10935
0c671da6 109362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10937
b862a52a 10938 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10939
be44ca6c
PE
10940 Check for overflow when converting integer to cons and back.
10941 * charset.c (Fdefine_charset_internal, Fdecode_char):
10942 Use cons_to_unsigned to catch overflow.
10943 (Fencode_char): Use INTEGER_TO_CONS.
10944 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10945 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10946 * data.c (long_to_cons, cons_to_long): Remove.
10947 (cons_to_unsigned, cons_to_signed): New functions.
10948 These signal an error for invalid or out-of-range values.
10949 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10950 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10951 * font.c (Ffont_variation_glyphs):
10952 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10953 * lisp.h: Include <intprops.h>.
10954 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10955 (cons_to_signed, cons_to_unsigned): New decls.
10956 (long_to_cons, cons_to_long): Remove decls.
10957 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10958 (Fprimitive_undo): Use CONS_TO_INTEGER.
10959 * xfns.c (Fx_window_property): Likewise.
10960 * xselect.c: Include <limits.h>.
10961 (x_own_selection, selection_data_to_lisp_data):
10962 Use INTEGER_TO_CONS.
10963 (x_handle_selection_request, x_handle_selection_clear)
10964 (x_get_foreign_selection, Fx_disown_selection_internal)
10965 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10966 (lisp_data_to_selection_data): Use cons_to_unsigned.
10967 (x_fill_property_data): Use cons_to_signed.
10968 Report values out of range.
10969
d1f3d2af
PE
10970 Check for buffer and string overflow more precisely.
10971 * buffer.h (BUF_BYTES_MAX): New macro.
10972 * lisp.h (STRING_BYTES_MAX): New macro.
10973 * alloc.c (Fmake_string):
10974 * character.c (string_escape_byte8):
10975 * coding.c (coding_alloc_by_realloc):
10976 * doprnt.c (doprnt):
10977 * editfns.c (Fformat):
10978 * eval.c (verror):
10979 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10980 since they may not be the same number.
10981 * editfns.c (Finsert_char):
10982 * fileio.c (Finsert_file_contents):
10983 Likewise for BUF_BYTES_MAX.
10984
dd52fcea
PE
10985 * image.c: Use ptrdiff_t, not int, for sizes.
10986 (slurp_file): Switch from int to ptrdiff_t.
10987 All uses changed.
10988 (slurp_file): Check that file size fits in both size_t (for
10989 malloc) and ptrdiff_t (for sanity and safety).
10990
7f9bbdbb
PE
10991 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10992 if b->modtime has its maximal value.
10993
dfe18f82
PE
10994 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10995
84acfcf0
PE
10996 Don't assume time_t can fit into int.
10997 * buffer.h (struct buffer.modtime): Now time_t, not int.
10998 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10999 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11000
ccd9a01a
PE
11001 Minor fixes for signed vs unsigned integers.
11002 * character.h (MAYBE_UNIFY_CHAR):
11003 * charset.c (maybe_unify_char):
11004 * keyboard.c (read_char, reorder_modifiers):
11005 XINT -> XFASTINT, since the integer must be nonnegative.
11006 * ftfont.c (ftfont_spec_pattern):
11007 * keymap.c (access_keymap, silly_event_symbol_error):
11008 XUINT -> XFASTINT, since the integer must be nonnegative.
11009 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11010 since it makes no difference and we prefer signed.
11011 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11012 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11013 nonnegative.
11014
d6d100dd
SM
110152011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11016
11017 * window.h (Fwindow_frame): Declare.
11018
2b6148e4
PE
110192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11020
11021 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11022 (SPARE_MEMORY): Always define.
11023 (LARGE_REQUEST): Remove.
11024 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11025
f230ecc9
MR
110262011-06-06 Martin Rudalics <rudalics@gmx.at>
11027
727e958e
MR
11028 * lisp.h: Move EXFUNS for Fframe_root_window,
11029 Fframe_first_window and Fset_frame_selected_window to window.h.
11030
11031 * window.h: Move EXFUNS for Fframe_root_window,
11032 Fframe_first_window and Fset_frame_selected_window here from
11033 lisp.h.
11034
11035 * frame.c (Fwindow_frame, Fframe_first_window)
11036 (Fframe_root_window, Fframe_selected_window)
11037 (Fset_frame_selected_window): Move to window.c.
11038 (Factive_minibuffer_window): Move to minibuf.c.
11039 (Fother_visible_frames_p): New function.
11040
11041 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11042
f230ecc9
MR
11043 * window.c (decode_window, decode_any_window): Move up in code.
11044 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11045 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11046 (Fwindow_buffer): Move up and rewrite doc-string.
11047 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11048 (Fwindow_prev): New functions.
727e958e
MR
11049 (Fwindow_frame): Move here from frame.c. Accept any window as
11050 argument.
11051 (Fframe_root_window, Fframe_first_window)
11052 (Fframe_selected_window): Move here from frame.c. Accept frame
11053 or arbitrary window as argument. Update doc-strings.
11054 (Fminibuffer_window): Move up in code.
11055 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11056 (Fset_frame_selected_window): Move here from frame.c.
11057 Marginal rewrite.
727e958e
MR
11058 (Fselected_window, select_window, Fselect_window): Move up in
11059 code. Minor doc-string fixes.
f230ecc9 11060
4d09bcf6
PE
110612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11062
11063 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11064 Do not assume that spare memory exists; that assumption is valid
11065 only if SYSTEM_MALLOC.
11066 (LARGE_REQUEST): New macro, so that the issue of large requests
11067 is separated from the issue of spare memory.
11068
810928a2
AS
110692011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11070
172418ad
AS
11071 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11072 format. (Bug#8806)
11073
43f862f7
AS
11074 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11075
810928a2
AS
11076 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11077 before statements.
11078
a059fe24
JD
110792011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11080
11081 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11082
11083 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11084
11085 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11086 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11087
989bf368
JB
110882011-06-05 Juanma Barranquero <lekktu@gmail.com>
11089
11090 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11091
4b80f674
CY
110922011-06-04 Chong Yidong <cyd@stupidchicken.com>
11093
11094 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11095 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11096 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11097 New error handlers.
4b80f674
CY
11098 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11099 Obey Vx_select_enable_clipboard_manager. Catch errors in
11100 x_clipboard_manager_save (Bug#8779).
11101 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11102 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11103
99a33b77 111042011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11105
11106 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11107
99a33b77 111082011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11109
11110 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11111 in the current matrix if keep_current_p is non-zero.
11112
8264569d
EZ
111132011-06-04 Eli Zaretskii <eliz@gnu.org>
11114
11115 * bidi.c (bidi_level_of_next_char): Fix last change.
11116
57f97249
EZ
111172011-06-03 Eli Zaretskii <eliz@gnu.org>
11118
fec2107c 11119 Support bidi reordering of text covered by display properties.
57f97249 11120
fec2107c
EZ
11121 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11122 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11123 (bidi_cache_search, bidi_cache_iterator_state)
11124 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11125 (bidi_level_of_next_char, bidi_move_to_visually_next):
11126 Support character positions inside a run of characters covered by a
fec2107c
EZ
11127 display string.
11128 (bidi_paragraph_init, bidi_resolve_explicit_1)
11129 (bidi_level_of_next_char): Call bidi_fetch_char and
11130 bidi_fetch_char_advance instead of FETCH_CHAR and
11131 FETCH_CHAR_ADVANCE.
11132 (bidi_init_it): Initialize new members.
11133 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11134 definitions.
11135 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11136 instead of using explicit *_CHAR codes.
d6d100dd
SM
11137 (bidi_resolve_explicit, bidi_resolve_weak):
11138 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11139 bidirectional text is supported only in multibyte buffers.
11140 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11141 it to initialize the frame_window_p member of struct bidi_it.
11142 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11143 (bidi_resolve_explicit, bidi_resolve_weak)
11144 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11145 bidi_it->nchars is non-positive.
11146 (bidi_level_of_next_char): Don't try to lookup the cache for the
11147 next/previous character if nothing is cached there yet, or if we
11148 were just reseat()'ed to a new position.
c40e2fb2 11149
0e14fe90
EZ
11150 * xdisp.c (set_cursor_from_row): Set start and stop points
11151 according to the row's direction when priming the loop that looks
11152 for the glyph on which to display cursor.
11153 (single_display_spec_intangible_p): Function deleted.
11154 (display_prop_intangible_p): Reimplement to call
11155 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11156 Accept 3 additional arguments needed by handle_display_spec.
11157 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11158 values: lists, `(when COND...)' forms, etc.
11159 (single_display_spec_string_p): Support property values that are
11160 lists with the argument STRING its top-level element.
11161 (display_prop_string_p): Fix the condition for processing a
11162 property that is a list to be consistent with handle_display_spec.
fec2107c 11163 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11164 last portion of handle_display_prop.
11165 (compute_display_string_pos): Accept additional argument
11166 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11167 value of a `display' property is a "replacing spec".
11168 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11169 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11170 the display property, but just return a value indicating whether
11171 the display property will replace the characters it covers.
11172 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11173 frame_window_p members of struct bidi_it.
d6d100dd
SM
11174 (compute_display_string_pos, compute_display_string_end):
11175 New functions.
fec2107c
EZ
11176 (push_it): Accept second argument POSITION, where pop_it should
11177 jump to continue iteration.
11178 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11179
fec2107c
EZ
11180 * keyboard.c (adjust_point_for_property): Adjust the call to
11181 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11182
11183 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11184 (bidi_init_it): Update prototypes.
11185 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11186 (compute_display_string_pos, compute_display_string_end):
11187 Declare prototypes.
fec2107c
EZ
11188 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11189 EMACS_INT.
fc6f18ce 11190
40087514 111912011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11192
57f53182
PE
11193 Malloc failure behavior now depends on size of allocation.
11194 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11195 * lisp.h: Change signatures accordingly.
11196 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11197 All callers changed. (Bug#8762)
11198
11199 * gnutls.c: Use Emacs's memory allocators.
11200 Without this change, the gnutls library would invoke malloc etc.
11201 directly, which causes problems on non-SYNC_INPUT hosts, and which
11202 runs afoul of improving memory_full behavior. (Bug#8761)
11203 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11204 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11205 xfree instead of the default malloc, realloc, free.
11206 (Fgnutls_boot): No need to check for memory allocation failure,
11207 since xmalloc does that for us.
11208
ac32cd99 11209 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11210 * category.c (hash_get_category_set):
11211 * ccl.c (ccl_driver):
11212 * charset.c (Fdefine_charset_internal):
11213 * charset.h (struct charset.hash_index):
11214 * composite.c (get_composition_id, gstring_lookup_cache)
11215 (composition_gstring_put_cache):
11216 * composite.h (struct composition.hash_index):
11217 * dispextern.h (struct image.hash):
11218 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11219 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11220 (hashfn_equal, hashfn_user_defined, make_hash_table)
11221 (maybe_resize_hash_table, hash_lookup, hash_put)
11222 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11223 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11224 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11225 * image.c (make_image, search_image_cache, lookup_image)
11226 (xpm_put_color_table_h):
11227 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11228 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11229 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11230 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11231 * alloc.c (allocate_vectorlike):
11232 Check for overflow in vector size calculations.
11233 * ccl.c (ccl_driver):
11234 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11235 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11236 need to be updated by these changes.
40087514
PE
11237 * fns.c (make_hash_table, maybe_resize_hash_table):
11238 Check for integer overflow with large hash tables.
0de4bb68
PE
11239 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11240 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11241 (SXHASH_REDUCE): New macro.
11242 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11243 Use it instead of discarding useful hash info with large hash values.
11244 (sxhash_float): New function.
11245 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11246 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11247 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11248 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11249 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11250 Adjust signatures to match updated version of code.
11251 (consing_since_gc): Now EMACS_INT, since a single hash table can
11252 use more than INT_MAX bytes.
11253
698d32e2
DN
112542011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11255
11256 Make it possible to build with GCC-4.6+ -O2 -flto.
11257
11258 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11259
fd6fa53f
SM
112602011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11261
11262 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11263 Call minibuffer-inactive-mode.
11264
864db017
JB
112652011-05-31 Juanma Barranquero <lekktu@gmail.com>
11266
11267 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11268 Update dependencies.
11269
2ad0baf4
DN
112702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11271
11272 * data.c (init_data): Remove code for UTS, this system is not
11273 supported anymore.
11274
4fcc2638
DN
112752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11276
11277 Don't force ./temacs to start in terminal mode.
11278
11279 * frame.c (make_initial_frame): Initialize faces in all cases, not
11280 only when CANNOT_DUMP is defined.
11281 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11282
c56e0fd5
DN
112832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11284
11285 * dispnew.c (add_window_display_history): Use const for the string
11286 pointer. Remove declaration, not needed.
11287
333d54da 112882011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11289
55d4c1b2 11290 Use 'inline', not 'INLINE'.
333d54da 11291 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11292 * alloc.c, fontset.c (INLINE): Remove.
11293 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11294 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11295 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11296 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11297 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11298
738db178
DN
112992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11300
11301 Make it possible to run ./temacs.
11302
11303 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11304 syms_of_callproc does the same thing. Remove test for
11305 "initialized", do it in the caller.
11306 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11307
620c53a6
SM
113082011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11309
11310 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11311 (read_minibuf): Use get_minibuffer.
11312 (syms_of_minibuf): Use DEFSYM.
11313 (Qmetadata): New var.
11314 * data.c (Qbuffer): Don't make it static.
11315 (syms_of_data): Use DEFSYM.
11316
e003a292
PE
113172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11318
11319 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11320 (CCL_CODE_MIN): New macro.
11321
ed008a6d
PE
113222011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11323
3687c2ef
PE
11324 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11325
ed008a6d
PE
11326 * eval.c (Qdebug): Now static.
11327 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11328 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11329 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11330
d66c4c7c
CY
113312011-05-29 Chong Yidong <cyd@stupidchicken.com>
11332
11333 * image.c: Various fixes to ImageMagick code comments.
11334 (Fimagemagick_types): Doc fix.
11335
5fbc2025
PE
113362011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11337
0196f88a
PE
11338 Minor fixes prompted by GCC 4.6.0 warnings.
11339
11340 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11341
5fbc2025
PE
11342 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11343 (x_clipboard_manager_save_all): Move extern decl to ...
11344 * xterm.h: ... here, so that it can be checked for consistency.
11345
1dd3c2d9
CY
113462011-05-29 Chong Yidong <cyd@stupidchicken.com>
11347
11348 * xselect.c (x_clipboard_manager_save_frame)
11349 (x_clipboard_manager_save_all): New functions.
11350 (Fx_clipboard_manager_save): Lisp function deleted.
11351
11352 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11353 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11354
11355 * xterm.h: Update prototype.
11356
5ba6571d
WX
113572011-05-28 William Xu <william.xwl@gmail.com>
11358
11359 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11360 exiting (Bug#8239).
11361
3eaff834
JM
113622011-05-28 Jim Meyering <meyering@redhat.com>
11363
e1900994 11364 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11365 * fns.c (to_uchar): Define.
11366 (crypto_hash_function): Use it to convert some newly-signed
11367 variables to unsigned, to avoid sign-extension bugs. For example,
11368 without this change, (md5 "truc") would evaluate to
11369 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11370 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11371 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11372
0f6990a7
PE
113732011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11374
11375 Integer overflow fixes.
c8a9ca5a 11376
08686060
PE
11377 * dbusbind.c: Serial number integer overflow fixes.
11378 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11379 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11380 to hold a serial number that is too large for a fixnum.
11381 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11382 Check for serial numbers out of range. Decode any serial number
59568bf0 11383 that was so large that it became a float. (Bug#8722)
08686060 11384
2d1fc3c7
PE
11385 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11386 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11387 Use XFASTINT rather than XUINT when numbers are nonnegative.
11388 (xd_append_arg, Fdbus_method_return_internal):
11389 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11390 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11391 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11392 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11393 (Bug#8722)
2d1fc3c7 11394
c8a9ca5a
PE
11395 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11396
519e1d69
PE
11397 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11398
6df6ae42 11399 ccl: Add integer overflow checks.
30569699
PE
11400 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11401 (IN_INT_RANGE): New macros.
11402 (ccl_driver): Use them to check for integer overflow when
11403 decoding a CCL program. Many of the new checks are whether XINT (x)
11404 fits in int; it doesn't always, on 64-bit hosts. The new version
11405 doesn't catch all possible integer overflows, but it's an
847044ea 11406 improvement. (Bug#8719)
30569699 11407
c11285dc
PE
11408 * alloc.c (make_event_array): Use XINT, not XUINT.
11409 There's no need for unsigned here.
11410
fdccd48e
PE
11411 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11412 This follows up to the 2011-05-06 change that substituted uintptr_t
11413 for EMACS_INT. This case wasn't caught back then.
11414
37910ab2
PE
11415 Rework Fformat to avoid integer overflow issues.
11416 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11417 now (part of C89). Include <verify.h>.
11418 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11419 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11420 (Fformat): Avoid the prepass trying to compute sizes; it was only
11421 approximate and thus did not catch overflow reliably. Instead, walk
11422 through the format just once, formatting and computing sizes as we go,
11423 checking for integer overflow at every step, and allocating a larger
11424 buffer as needed. Keep track separately whether the format is
11425 multibyte. Keep only the most-recently calculated precision, rather
11426 than them all. Record whether each argument has been converted to
11427 string. Use EMACS_INT, not int, for byte and char and arg counts.
11428 Support field widths and precisions larger than INT_MAX. Avoid
11429 sprintf's undefined behavior with conversion specifications such as %#d
11430 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11431 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11432 formatting out-of-range floating point numbers with int
9173deec 11433 formats. (Bug#8668)
37910ab2 11434
2e6578fb
PE
11435 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11436
0ae6bdee
PE
11437 * data.c: Avoid integer truncation in expressions involving floats.
11438 * data.c: Include <intprops.h>.
11439 (arith_driver): When there's an integer overflow in an expression
11440 involving floating point, convert the integers to floating point
11441 so that the resulting value does not suffer from catastrophic
11442 integer truncation. For example, on a 64-bit host (* 4
11443 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11444 Do not rely on undefined behavior after integer overflow.
11445
de883a70
PE
11446 merge count_size_as_multibyte, parse_str_to_multibyte
11447 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11448 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11449 Check for integer overflow.
11450 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11451 since it's now a duplicate of the other. This is more of
11452 a character than a buffer op, so better that it's in character.c.
11453 * fns.c, print.c: Adjust to above changes.
11454
2ff916cb
PE
114552011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11456
11457 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11458
f1b54466
PE
114592011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11460
fb1ac845
PE
11461 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11462 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11463 (x_clipboard_manager_save): Now static.
11464 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11465
f1b54466
PE
11466 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11467 (crypto_hash_function): Now static.
11468 Fix pointer signedness problems. Avoid unnecessary initializations.
11469
a9f737ee
CY
114702011-05-27 Chong Yidong <cyd@stupidchicken.com>
11471
11472 * termhooks.h (Vselection_alist): Make it terminal-local.
11473
11474 * terminal.c (create_terminal): Initialize it.
11475
11476 * xselect.c: Support for clipboard managers.
11477 (Vselection_alist): Move to termhooks.h as terminal-local var.
11478 (LOCAL_SELECTION): New macro.
11479 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11480 (symbol_to_x_atom): Remove gratuitous arg.
11481 (x_handle_selection_request, lisp_data_to_selection_data)
11482 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11483 (x_own_selection, x_get_local_selection, x_convert_selection):
11484 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11485 (some_frame_on_display): Delete unused function.
11486 (Fx_own_selection_internal, Fx_get_selection_internal)
11487 (Fx_disown_selection_internal, Fx_selection_owner_p)
11488 (Fx_selection_exists_p): New optional frame arg.
11489 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11490 (x_handle_selection_clear): Don't treat other terminals with the
11491 same keyboard specially. Use the terminal-local Vselection_alist.
11492 (x_clear_frame_selections): Use Frun_hook_with_args.
11493
11494 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11495
11496 * xterm.h: Add support for those atoms.
11497
e067f0c1
CY
114982011-05-26 Chong Yidong <cyd@stupidchicken.com>
11499
11500 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11501 (converted_selections, conversion_fail_tag): New global variables.
11502 (x_selection_request_lisp_error): Free the above.
11503 (x_get_local_selection): Remove unnecessary code.
11504 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11505 of converted selections stored in converted_selections.
11506 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11507 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11508 (x_convert_selection): New function.
11509 (x_handle_selection_event): Simplify.
11510 (x_get_foreign_selection): Don't ignore incoming requests while
11511 waiting for an answer; this will fail when we implement
11512 SAVE_TARGETS, and seems unnecessary anyway.
11513 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11514 (Vx_sent_selection_functions): Doc fix.
11515
0f4aebc0
LL
115162011-05-26 Leo Liu <sdl.web@gmail.com>
11517
11518 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11519
e61124cd
YM
115202011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11521
11522 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11523
11524 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11525 for fringe update if it has periodic bitmap.
ac389d0c 11526 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11527 and fringe_bitmap_periodic_p.
11528
11529 * fringe.c (get_fringe_bitmap_data): New function.
11530 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11531 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11532 row. Mark glyph row for fringe update if periodicity changed.
11533
11534 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11535 for fringe update unless it has periodic bitmap.
11536
f16d9837
KH
115372011-05-25 Kenichi Handa <handa@m17n.org>
11538
11539 * xdisp.c (get_next_display_element): Set correct it->face_id for
11540 a static composition.
11541
e1b90ef6
LL
115422011-05-24 Leo Liu <sdl.web@gmail.com>
11543
11544 * deps.mk (fns.o):
11545 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11546
11547 * fns.c (crypto_hash_function, Fsha1): New function.
11548 (Fmd5): Use crypto_hash_function.
11549 (syms_of_fns): Add Ssha1.
11550
7400048f
PE
115512011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11552
11553 * gnutls.c: Remove unused macros.
11554 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11555 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11556 Remove macros that are defined and never used.
11557 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11558
abb71cf4
CY
115592011-05-22 Chong Yidong <cyd@stupidchicken.com>
11560
11561 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11562 (Fx_get_selection_internal): Minor cleanup.
11563 (Fx_own_selection_internal): Rename arguments for consistency with
11564 select.el.
11565
6307db39
PE
115662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11567
11568 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11569
f3d4e0a4
CY
115702011-05-22 Chong Yidong <cyd@stupidchicken.com>
11571
11572 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11573
4d8ade89
YM
115742011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11575
11576 * dispnew.c (scrolling_window): Don't exclude the case that the
11577 last enabled row in the desired matrix touches the bottom boundary.
11578
32078c8d
GM
115792011-05-21 Glenn Morris <rgm@gnu.org>
11580
11581 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11582 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11583 and add some more files.
32078c8d 11584
7285dc67
EZ
115852011-05-20 Eli Zaretskii <eliz@gnu.org>
11586
11587 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11588 report_file_error introduced by the change from 2011-05-07.
11589
89d1bd22
PE
115902011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11591
11592 * systime.h (Time): Define only if emacs is defined.
11593 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11594 where the include path doesn't have X11/X.h by default. See
11595 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11596
cd394be1 115972011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11598
11599 * composite.c (find_automatic_composition): Fix previous change.
11600
b9704ad9
GM
116012011-05-20 Glenn Morris <rgm@gnu.org>
11602
11603 * lisp.mk: New file, split from Makefile.in.
11604 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11605 (shortlisp): Remove.
11606 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11607
4a720484
GM
116082011-05-19 Glenn Morris <rgm@gnu.org>
11609
11610 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11611 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11612 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11613 (lisp): Set the order to that of loadup.el.
11614 (shortlisp): Make it a copy of $lisp.
11615 (SOME_MACHINE_LISP): Remove.
11616 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11617 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11618
a28d4396
KH
116192011-05-18 Kenichi Handa <handa@m17n.org>
11620
11621 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11622 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11623 (find_automatic_composition): Mostly rewrite for efficiency.
11624
a2b1fa8e
JB
116252011-05-18 Juanma Barranquero <lekktu@gmail.com>
11626
11627 * makefile.w32-in: Update dependencies.
11628
8e1f5610
CS
116292011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11630
11631 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11632 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11633
7025ee00 116342011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11635
cdfa6eab
PE
11636 Fix some integer overflow issues, such as string length overflow.
11637
06d6db33
PE
11638 * insdel.c (count_size_as_multibyte): Check for string overflow.
11639
2b4560a8
PE
11640 * character.c (lisp_string_width): Check for string overflow.
11641 Use EMACS_INT, not int, for string indexes and lengths; in
11642 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11643 the resulting string length overflows an EMACS_INT; instead,
11644 report a string overflow if no precision given. When checking for
11645 precision exhaustion, use a check that cannot possibly have
11646 integer overflow. (Bug#8675)
11647 * character.h (lisp_string_width): Adjust to new signature.
11648
cb93f9be
PE
11649 * alloc.c (string_overflow): New function.
11650 (Fmake_string): Use it. This doesn't change behavior, but saves
11651 a few bytes and will simplify future changes.
11652 * character.c (string_escape_byte8): Likewise.
11653 * lisp.h (string_overflow): New decl.
11654
1a1f3366
PE
11655 Fixups, following up to the user-interface timestamp change.
11656 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11657 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11658 * msdos.c (mouse_get_pos): Likewise.
11659 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11660 * w32gui.h (Time): Define by including "systime.h" rather than by
11661 declaring it ourselves. (Bug#8664)
11662
d4e3e4d3
PE
11663 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11664 * image.c (clear_image_cache): Likewise.
11665
f6a24d19
PE
11666 * term.c (term_mouse_position): Don't assume time_t wraparound.
11667
08dc5ae6
PE
11668 Be more systematic about user-interface timestamps.
11669 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11670 and sometimes 'EMACS_UINT', to represent these timestamps.
11671 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11672 This makes the code easier to follow, and makes it easier to catch
11673 integer overflow bugs such as Bug#8664.
11674 * frame.c (Fmouse_position, Fmouse_pixel_position):
11675 Use Time, not unsigned long, for user-interface timestamps.
11676 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11677 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11678 * keyboard.h (last_event_timestamp): Likewise.
11679 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11680 * menu.h (xmenu_show): Likewise.
11681 * term.c (term_mouse_position): Likewise.
11682 * termhooks.h (struct input_event.timestamp): Likewise.
11683 (struct terminal.mouse_position_hook): Likewise.
11684 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11685 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11686 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11687 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11688 what it was before.
11689 * menu.h, termhooks.h: Include "systime.h", for Time.
11690
8e55734a
PE
11691 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11692 Don't assume that the difference between two unsigned long values
11693 can fit into an integer. At this point, we know button_down_time
11694 <= event->timestamp, so the difference must be nonnegative, so
11695 there's no need to cast the result if double-click-time is
11696 nonnegative, as it should be; check that it's nonnegative, just in
11697 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11698 apart (about 25 days). (Bug#8664)
8e55734a 11699
841f1b75 11700 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11701 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11702
3e26f69c
PE
11703 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11704 that always fit in int. Use a sentinel instead of a counter, to
11705 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11706 * frame.h (struct frame): Use int for menu_bar_items_used
11707 instead of EMACS_INT, since it always fits in int.
3e26f69c 11708
5cc152c0
PE
11709 * menu.c (grow_menu_items): Check for int overflow.
11710
d89eb65e
PE
11711 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11712
5235bd3e
PE
11713 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11714 Before, the code was not consistent. These values cannot exceed
11715 2**31 - 1 so there's no need to make them unsigned.
11716 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11717 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11718 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11719 as modifiers.
11720 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11721
bc827e23
PE
11722 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11723 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11724 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11725 presumably because the widths might not match.
11726
78eb494e
PE
11727 * window.c (size_window): Avoid needless test at loop start.
11728
04f2d78b
CB
117292011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11730
11731 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11732
d2fc7e3d 117332011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11734
11735 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11736
d2fc7e3d 117372011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11738
11739 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11740 `width' to `bar_area_x' and `bar_area_width', respectively.
11741 (x_scroll_run): Take account of fringe background extension.
11742
04f2d78b
CB
11743 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11744 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11745 `bar_area_width', respectively.
11746 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11747 background extension.
11748
79b70037
GM
117492011-05-10 Jim Meyering <meyering@redhat.com>
11750
11751 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11752
2f142cc5
JB
117532011-05-10 Juanma Barranquero <lekktu@gmail.com>
11754
11755 * image.c (Finit_image_library): Return t for built-in image types,
11756 like pbm and xbm. (Bug#8640)
11757
57679c86
AS
117582011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11759
11760 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11761
888c9e86
EZ
117622011-05-07 Eli Zaretskii <eliz@gnu.org>
11763
b0512a1d
EZ
11764 * w32console.c (Fset_screen_color): Doc fix.
11765 (Fget_screen_color): New function.
11766 (syms_of_ntterm): Defsubr it.
11767
7285dc67
EZ
11768 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11769 unlink the temporary file if Fcall_process didn't create it in the
11770 first place.
11771 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11772 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11773 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11774 cue to call_process_cleanup not to close that handle.
11775
4d3fcc8e
BK
117762011-05-07 Ben Key <bkey76@gmail.com>
11777
11778 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11779 one of two shell specific rules, either bootstrap-temacs-CMD or
11780 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11781 to the previous implementation of the bootstrap-temacs rule.
11782 The bootstrap-temacs-CMD rule is similar to the previous
11783 implementation of the bootstrap-temacs rule except that it
11784 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11785 variable.
11786
11787 These changes, along with some changes to nt/configure.bat,
11788 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11789 earlier fix to add support for --cflags and --ldflags options
11790 that include quotes so that it works whether make uses cmd or
11791 sh as the shell.
11792
b4289b64
MA
117932011-05-06 Michael Albinus <michael.albinus@gmx.de>
11794
11795 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11796 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11797 is a constant.
11798 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11799 a string. Handle both cases.
11800 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11801 (Fdbus_register_method): Use Qinvalid_function.
11802
af4c0e28
JB
118032011-05-06 Juanma Barranquero <lekktu@gmail.com>
11804
11805 * makefile.w32-in: Update dependencies.
11806 (LISP_H): Add inttypes.h and stdin.h.
11807 (PROCESS_H): Add unistd.h.
11808
c51453d9
EZ
118092011-05-06 Eli Zaretskii <eliz@gnu.org>
11810
11811 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11812 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11813
8ff0ac3c 118142011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11815
4c4b566b
PE
11816 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11817
aab2b9b5
PE
11818 * term.c (vfatal): Remove stray call to va_end.
11819 It's not needed and the C Standard doesn't allow it here anyway.
11820
c378da0b
PE
11821 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11822 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11823
288b08c7
PE
11824 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11825 bytes.
11826
e3601888
PE
11827 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11828
db6c0e74
PE
11829 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11830
dd5963ea
PE
11831 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11832
88c9450f
PE
11833 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11834
2f9442b8
PE
11835 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11836
c032b5f8
PE
11837 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11838 * charset.c (Fdefine_charset_internal): Don't initialize
11839 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11840 32-bit int (Bug#8600).
a108c10b
PE
11841
11842 * lread.c (read_integer): Be more consistent with string-to-number.
11843 Use string_to_number to do the actual conversion; this avoids
11844 rounding errors and fixes some other screwups. Without this fix,
11845 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11846 (digit_to_number): Move earlier, for benefit of read_integer.
11847 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11848 not a digit in any supported base. (Bug#8602)
a108c10b 11849
ad5f9eea
PE
11850 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11851
aec1708a
PE
11852 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11853 to match comment at start of function. This also removes a
11854 GCC warning about overflow in a 32+64-bit port.
11855
47be4ab5
PE
11856 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11857
371cac43
PE
11858 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11859 Reported by Stefan Monnier in
11860 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11861 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11862 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11863
d01a7826
PE
11864 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11865 (EMACS_UINTPTR): Likewise, with uintptr_t.
11866
7fd47d5c
PE
11867 * lisp.h: Prefer 64-bit EMACS_INT if available.
11868 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11869 on 32-bit hosts that have 64-bit int, so that they can access
11870 large files.
122b0c86
PE
11871 However, temporarily disable this change unless the temporary
11872 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11873
8727937b
PE
11874 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11875
8ac068ac
PE
11876 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11877 This removes an assumption that EMACS_INT and long are the same
11878 width as pointers. The assumption is true for Emacs porting targets
11879 now, but we want to make other targets possible.
11880 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11881 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11882 In the rest of the code, change types of integers that hold casted
11883 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11884 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11885 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11886 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11887 No need to cast type when ORing.
11888 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11889 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11890 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11891 assume EMACS_INT is the same width as char *.
11892 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11893 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11894 Remove no-longer-needed casts.
11895 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11896 (xg_tool_bar_help_callback, xg_make_tool_item):
11897 Use EMACS_INTPTR to hold an integer
11898 that will be cast to void *; this can avoid a GCC warning
11899 if EMACS_INT is not the same width as void *.
11900 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11901 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11902 (current_message_1, set_message_1):
11903 Use a local to convert to proper width without a cast.
11904 * xmenu.c (dialog_selection_callback): Likewise.
11905
ede49d71
PE
11906 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11907 Also, don't assume VALBITS / RAND_BITS is less than 5,
11908 and don't rely on undefined behavior when shifting a 1 left into
11909 the sign bit.
11910 * lisp.h (get_random): Change signature to match.
11911
2f30ecd0
PE
11912 * lread.c (hash_string): Use size_t, not int, for hash computation.
11913 Normally we prefer signed values; but hashing is special, because
11914 it's better to use unsigned division on hash table sizes so that
11915 the remainder is nonnegative. Also, size_t is the natural width
11916 for hashing into memory. The previous code used 'int', which doesn't
11917 retain enough info to hash well into very large tables.
11918 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11919
2a866e7b
PE
11920 * dbusbind.c: Don't possibly lose pointer info when converting.
11921 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11922 Use XPNTR rather than XHASH, so that the high-order bits of
11923 the pointer aren't lost when converting through void *.
11924
51639eac
PE
11925 * eval.c (Fautoload): Don't double-shift a pointer.
11926
92394119
PE
11927 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11928
dbdb9a7c
JB
119292011-05-06 Juanma Barranquero <lekktu@gmail.com>
11930
11931 * gnutls.c (DEF_GNUTLS_FN):
11932 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11933
db7a0b4f
AS
119342011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11935
11936 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11937 marker. (Bug#8610)
11938
cd394be1 119392011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11940
11941 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11942 New version that can reserve upto 2GB of heap space.
11943
f7ff1b0f 119442011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11945
11946 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11947
639c109b
TZ
119482011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11949
11950 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11951 `gnutls_certificate_set_x509_key_file'.
11952
d2127135
JB
119532011-05-05 Juanma Barranquero <lekktu@gmail.com>
11954
11955 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11956 Update dependencies.
11957
e968f4f3
JB
119582011-05-04 Juanma Barranquero <lekktu@gmail.com>
11959
11960 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11961 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11962 Remove unused parameter `fildes'.
11963 * process.c (read_process_output, send_process): Don't pass it.
11964
84d358f0
JB
119652011-05-04 Juanma Barranquero <lekktu@gmail.com>
11966
11967 Fix previous change: the library cache is defined in w32.c.
11968 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11969 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11970
0898ca10
JB
119712011-05-04 Juanma Barranquero <lekktu@gmail.com>
11972
11973 Implement dynamic loading of GnuTLS on Windows.
11974
11975 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11976 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11977 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11978 Declare.
11979
11980 * gnutls.c (Qgnutls_dll): Define.
11981 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11982 (gnutls_*): Declare function pointers.
11983 (init_gnutls_functions): New function to initialize function pointers.
11984 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11985 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11986 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11987 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11988 (emacs_gnutls_write, emacs_gnutls_read)
11989 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11990 (Fgnutls_available_p): New function.
11991 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11992 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11993 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11994
11995 * image.c: Include w32.h.
11996 (Vimage_type_cache): Delete.
11997 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11998 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11999 (w32_delayed_load): Move to w32.c.
12000
12001 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12002
12003 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12004 (w32_delayed_load): Move from image.c. When loading a library, record
12005 its filename in the :loaded-from property of the library id.
12006 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12007 Initialize and staticpro them.
12008 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12009
12010 * process.c: Include lisp.h before w32.h, not after.
12011 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12012 instead of gnutls_record_check_pending.
12013
12014 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12015
ff4de4aa
TZ
120162011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12017
12018 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12019 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12020 as passed in.
12021
abe95abb
JD
120222011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12023
12024 * xterm.c (x_set_frame_alpha): Do not set property on anything
12025 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12026
e16e55d4
JB
120272011-05-02 Juanma Barranquero <lekktu@gmail.com>
12028
12029 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12030
bafcf6a5
JB
120312011-05-02 Juanma Barranquero <lekktu@gmail.com>
12032
12033 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12034 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12035 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12036 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12037 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12038 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12039 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12040 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12041 (Qgnutls_bootprop_callbacks_verify): Make static.
12042
e7a6747f
AS
120432011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12044
19ed11ba
AS
12045 * callproc.c: Indentation fixup.
12046
e7a6747f 12047 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12048 (wait_for_termination, interruptible_wait_for_termination):
12049 Move after wait_for_termination_1.
e7a6747f 12050
1ef14cb4
LMI
120512011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12052
12053 * sysdep.c (interruptible_wait_for_termination): New function
12054 which is like wait_for_termination, but allows keyboard
12055 interruptions.
12056
12057 * callproc.c (Fcall_process): Add (:file "file") as an option for
12058 the STDOUT buffer.
12059 (Fcall_process_region): Ditto.
12060
330d880c
EZ
120612011-04-30 Eli Zaretskii <eliz@gnu.org>
12062
8db90b73
EZ
12063 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12064 rather than `XVECTOR (FOO)->size'.
12065
330d880c
EZ
12066 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12067 inttypes.h, as a gnulib replacement is used if it not available in
12068 system headers.
12069
15cbd324
EZ
120702011-04-21 Eli Zaretskii <eliz@gnu.org>
12071
12072 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12073 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12074 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12075
12076 * coding.c (coding_alloc_by_realloc): Error out if destination
12077 will grow beyond MOST_POSITIVE_FIXNUM.
12078 (decode_coding_emacs_mule): Abort if there isn't enough place in
12079 charbuf for the composition carryover bytes. Reserve an extra
12080 space for up to 2 characters produced in a loop.
12081 (decode_coding_iso_2022): Abort if there isn't enough place in
12082 charbuf for the composition carryover bytes.
12083
120842011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12085
ae940cca
EZ
12086 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12087 aborting when %lld or %lll format is passed.
12088 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12089 %llo or %llx format is passed. (Bug#8545)
12090
03ab8921
EZ
12091 * window.c (window_scroll_line_based): Use a marker instead of
12092 simple variables to record original value of point. (Bug#7952)
12093
afda1437
EZ
12094 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12095 produced by %s or %c overflows available buffer space. (Bug#8545)
12096
f76dee0c
PE
120972011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12098
12099 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12100 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12101
fdc5744d
JB
121022011-04-28 Juanma Barranquero <lekktu@gmail.com>
12103
12104 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12105
638f053a
JB
121062011-04-28 Juanma Barranquero <lekktu@gmail.com>
12107
12108 * keyboard.c (Qdelayed_warnings_hook): Define.
12109 (command_loop_1): Run `delayed-warnings-hook'
12110 if Vdelayed_warnings_list is non-nil.
12111 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12112 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12113
d178f871
EZ
121142011-04-28 Eli Zaretskii <eliz@gnu.org>
12115
12116 * doprnt.c (doprnt): Don't return value smaller than the buffer
12117 size if the message was truncated. (Bug#8545).
12118
b124fd93
JB
121192011-04-28 Juanma Barranquero <lekktu@gmail.com>
12120
12121 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12122 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12123
e810457d
PE
121242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12125
12126 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12127
ea51cceb
JB
121282011-04-27 Juanma Barranquero <lekktu@gmail.com>
12129
12130 * makefile.w32-in: Update dependencies.
12131
94dcfacf
EZ
121322011-04-27 Eli Zaretskii <eliz@gnu.org>
12133
12134 Improve `doprnt' and its usage. (Bug#8545)
12135 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12136 `format_end'. Remove support for %l as a conversion specifier.
12137 Don't use xrealloc. Improve diagnostics when the %l size modifier
12138 is used. Update the commentary.
12139
12140 * eval.c (verror): Simplify calculation of size_t.
12141
12142 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12143 messages.
12144
f61f41d7
PE
121452011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12146
12147 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12148 change.
12149
96fb4434
PE
121502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12151
12152 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12153 This makes this file independent of the recent pseudovector change.
12154
671875da 121552011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12156
69e9b5a3
PE
12157 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12158
b5f869a7 12159 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12160 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12161 Remove unused local.
c8926152 12162 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12163
841a1577 12164 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12165 GCC 4.6.0 optimizes based on type-based alias analysis.
12166 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12167 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12168 != &v->size, and therefore "v->size = 1; b->size = 2; return
12169 v->size;" must therefore return 1. This assumption is incorrect
12170 for Emacs, since it type-puns struct Lisp_Vector * with many other
12171 types. To fix this problem, this patch adds a new type struct
f904488f 12172 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12173 and pseudovectors, and helps optimizing compilers not get fooled
12174 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12175 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12176 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12177 the size member.
eab3844f
PE
12178 (XSETPVECTYPE): Rewrite in terms of new macro.
12179 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12180 This is a bit clearer, and further avoids the possibility of
12181 undesirable aliasing.
12182 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12183 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12184 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12185 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12186 (ASIZE): Now uses header.size rather than size.
12187 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12188 to avoid the hassle of writing XVECTOR (foo)->header.size.
12189 (struct vectorlike_header): New type.
eab3844f
PE
12190 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12191 object, to help avoid aliasing.
12192 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12193 (SUBRP): Likewise, since Lisp_Subr is a special case.
12194 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12195 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12196 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12197 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12198 changed to be "header.size" and "header.next".
12199 * buffer.h (struct buffer): Likewise.
12200 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12201 * frame.h (struct frame): Likewise.
12202 * process.h (struct Lisp_Process): Likewise.
12203 * termhooks.h (struct terminal): Likewise.
12204 * window.c (struct save_window_data, struct saved_window): Likewise.
12205 * window.h (struct window): Likewise.
12206 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12207 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12208 * buffer.c (init_buffer_once): Likewise.
12209 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12210 special case.
12211 * process.c (Fformat_network_address): Use local var for size,
12212 for brevity.
12213
0df1eac5
PE
12214 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12215
847ab9d1 12216 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12217 * data.c (atof): Remove decl; no longer used or needed.
12218 (digit_to_number): Move to lread.c.
12219 (Fstring_to_number): Use new string_to_number function, to be
12220 consistent with how the Lisp reader treats infinities and NaNs.
12221 Do not assume that floating-point numbers represent EMACS_INT
12222 without losing information; this is not true on most 64-bit hosts.
12223 Avoid double-rounding errors, by insisting on integers when
12224 parsing non-base-10 numbers, as the documentation specifies.
12225 * lisp.h (string_to_number): New decl, replacing ...
12226 (isfloat_string): Remove.
bc0a5c13 12227 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12228 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12229 appears to have been a coding error. Similarly, do not accept
12230 strings like +-1e0 as floating point numbers. Do not report
12231 overflow for integer overflows unless the base is not 10 which
12232 means we have no simple and reliable way to continue.
12233 Break out the floating-point parsing into a new
12234 function string_to_number, so that Fstring_to_number parses
12235 floating point numbers consistently with the Lisp reader.
04f2d78b 12236 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12237 (E_CHAR, EXP_INT): Remove, replacing with ...
12238 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12239 (string_to_number): New function, replacing isfloat_string.
12240 This function checks for valid syntax and produces the resulting
12241 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12242 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12243 so that overflow for non-base-10 numbers is reported only when
12244 there's no portable and simple way to convert to floating point.
452f4150 12245
67769ffc
PE
12246 * textprop.c (set_text_properties_1): Rewrite for clarity,
12247 and to avoid GCC warning about integer overflow.
12248
c20db43f
PE
12249 * intervals.h (struct interval): Use EMACS_INT for members
12250 where EMACS_UINT might cause problems. See
12251 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12252 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12253 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12254 All uses changed.
37aa2f85
PE
12255 (offset_intervals): Tell GCC not to worry about length overflow
12256 when negating a negative length.
c20db43f 12257
2538aa2f
PE
12258 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12259 (overrun_check_free): Likewise.
12260
f2d3008d
PE
12261 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12262 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12263 word size.
12264
ec8df744
PE
12265 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12266 (gnutls_make_error): Rename local to avoid shadowing.
12267 (gnutls_emacs_global_deinit): ifdef out; not used.
12268 (Fgnutls_boot): Use const for pointer to readonly storage.
12269 Comment out unused local. Fix pointer signedness problems.
12270
640ee02d
PE
12271 * lread.c (openp): Don't stuff size_t into an 'int'.
12272 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12273 about possible signed overflow.
12274
6048fb2a
PE
12275 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12276 (GDK_KEY_g): Don't define if already defined.
12277 (xg_prepare_tooltip): Avoid pointer signedness problem.
12278 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12279
fa3c87e1
PE
12280 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12281 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12282
2172544b
PE
12283 * xfns.c (Fx_window_property): Simplify a bit,
12284 to make a bit faster and to avoid GCC 4.6.0 warning.
12285 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12286
9b821a21
PE
12287 * fns.c (internal_equal): Don't assume size_t fits in int.
12288
3c616cfa
PE
12289 * alloc.c (compact_small_strings): Tighten assertion a little.
12290
c2982e87
PE
12291 Replace pEd with more-general pI, and fix some printf arg casts.
12292 * lisp.h (pI): New macro, generalizing old pEd macro to other
12293 conversion specifiers. For example, use "...%"pI"d..." rather
12294 than "...%"pEd"...".
12295 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12296 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12297 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12298 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12299 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12300 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12301 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12302 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12303 64-bit hosts.
12304 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12305 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12306 * print.c (safe_debug_print, print_object): Likewise.
12307 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12308 to int.
6f04d126
PE
12309 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12310 avoiding the 0 flag, which is not portable.
c2982e87
PE
12311 * process.c (Fmake_network_process): Use pI to avoid cast.
12312 * region-cache.c (pp_cache): Likewise.
12313 * xdisp.c (decode_mode_spec): Likewise.
12314 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12315 behavior on 64-bit hosts with printf arg.
6f04d126 12316 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12317 (x_stop_queuing_selection_requests): Likewise.
12318 (x_get_window_property): Don't truncate byte count to an 'int'
12319 when tracing.
0b432f21 12320
5e073ec7
PE
12321 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12322 here, since it parses constructs like leading '-' and spaces,
12323 which are not wanted; and it overflows with large numbers.
12324 Instead, simply match F[0-9]+, which is what is wanted anyway.
12325
36372bf9
PE
12326 * alloc.c: Remove unportable assumptions about struct layout.
12327 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12328 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12329 (allocate_vectorlike, make_pure_vector): Use the new macros,
12330 plus offsetof, to remove unportable assumptions about struct layout.
12331 These assumptions hold on all porting targets that I know of, but
12332 they are not guaranteed, they're easy to remove, and removing them
12333 makes further changes easier.
12334
0b432f21
PE
12335 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12336 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12337 (string_overrun_cookie): Now const. Use initializers that
12338 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12339 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12340 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12341 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12342 multiple of sizeof (EMACS_INT); it need not be, if
12343 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12344 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12345
895009e1
JB
123462011-04-26 Juanma Barranquero <lekktu@gmail.com>
12347
12348 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12349
6a7a1b0b
TZ
123502011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12351
12352 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12353 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12354 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12355
841a1577 123562011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12357
12358 * lisp.h (Qdebug): List symbol.
895009e1 12359 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12360 * keyboard.c (debug-on-event): New variable.
12361 (handle_user_signal): Break into debugger when debug-on-event
12362 matches the current signal symbol.
12363
f2d3ba6f
DN
123642011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12365
12366 * alloc.c (check_sblock, check_string_bytes)
12367 (check_string_free_list): Convert to standard C.
12368
42ce4c63
TZ
123692011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12370
12371 * w32.c (emacs_gnutls_push): Fix typo.
12372
825cd63c
EZ
123732011-04-25 Eli Zaretskii <eliz@gnu.org>
12374
fb11d64d
EZ
12375 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12376 "cast to pointer from integer of different size".
12377
825cd63c
EZ
12378 Improve doprnt and its use in verror. (Bug#8545)
12379 * doprnt.c (doprnt): Document the set of format control sequences
12380 supported by the function. Use SAFE_ALLOCA instead of always
12381 using `alloca'.
12382
12383 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12384 is one byte too soon. Don't use xrealloc; instead xfree and
12385 xmalloc anew.
12386
e061a11b
TZ
123872011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12388
12389 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12390 callbacks stage.
12391
12392 * gnutls.c: Renamed global_initialized to
12393 gnutls_global_initialized. Added internals for the
12394 :verify-hostname-error, :verify-error, and :verify-flags
12395 parameters of `gnutls-boot' and documented those parameters in the
12396 docstring. Start callback support.
9173deec
JB
12397 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12398 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12399 on error. Return error code.
e061a11b
TZ
12400 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12401 (emacs_gnutls_read): Likewise.
12402 (Fgnutls_boot): Return handshake error code.
12403 (emacs_gnutls_handle_error): New function.
12404 (wsaerror_to_errno): Likewise.
12405
12406 * w32.h (emacs_gnutls_pull): Add prototype.
12407 (emacs_gnutls_push): Likewise.
12408
12409 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12410 (emacs_gnutls_push): Likewise.
12411
124122011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12413
12414 * process.c (wait_reading_process_output): Check if GnuTLS
12415 buffered some data internally if no FDs are set for TLS
12416 connections.
12417
12418 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12419 (LIBS): Link to USER_LIBS.
12420 ($(BLD)/gnutls.$(0)): New target.
12421
fa6996bc
EZ
124222011-04-24 Eli Zaretskii <eliz@gnu.org>
12423
eb35682e
EZ
12424 * xdisp.c (handle_single_display_spec): Rename the
12425 display_replaced_before_p argument into display_replaced_p, to
12426 make it consistent with the commentary. Fix typos in the
12427 commentary.
12428
e2ad650c
EZ
12429 * textprop.c (syms_of_textprop): Remove dead code.
12430 (copy_text_properties): Delete obsolete commentary about an
12431 interface that was deleted long ago. Fix typos in the description
12432 of arguments.
12433
1b2de274
EZ
12434 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12435 to changes in oldXMenu/XMenu.h from 2011-04-16.
12436 <menu_help_message, prev_menu_help_message>: Constify.
12437 (IT_menu_make_room): menu->help_text is now `const char **';
12438 adjust.
12439
12440 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12441 to changes in oldXMenu/XMenu.h from 2011-04-16.
12442 (struct XMenu): Declare `help_text' `const char **'.
12443
12444 * xfaces.c <Qunspecified>: Make extern again.
12445
12446 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12447 required by POSIX.
1b2de274 12448
762b15be
EZ
12449 * doc.c (get_doc_string): Improve the format passed to `error'.
12450
12451 * doprnt.c (doprnt): Improve commentary.
12452
12453 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12454
12455 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12456 them with etags.
12457
f1052e5d
EZ
12458 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12459 changes in globals.h immediately force recompilation.
762b15be
EZ
12460 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12461 $(CURDIR)/s/ms-w32.h.
12462 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12463
fa6996bc
EZ
12464 * character.c (Fchar_direction): Function deleted.
12465 (syms_of_character): Don't defsubr it.
12466 <char-direction-table>: Deleted.
12467
e6c3da20
EZ
124682011-04-23 Eli Zaretskii <eliz@gnu.org>
12469
12470 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12471 * doprnt.c: Include limits.h.
12472 (SIZE_MAX): New macro.
04f2d78b
CB
12473 (doprnt): Return a size_t value. 2nd arg is now size_t.
12474 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12475 Improve overflow protection. Support `l' modifier for integer
12476 conversions. Support %l conversion. Don't assume an EMACS_INT
12477 argument for integer conversions and for %c.
12478
12479 * lisp.h (doprnt): Restore prototype.
12480
12481 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12482 $(SRC)/character.h.
12483
12484 * Makefile.in (base_obj): Add back doprnt.o.
12485
12486 * deps.mk (doprnt.o): Add back prerequisites.
12487 (callint.o): Depend on character.h.
12488
12489 * eval.c (internal_lisp_condition_case): Include the handler
12490 representation in the error message.
12491 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12492 when breaking from the loop.
12493
12494 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12495
12496 * callint.c (Fcall_interactively): When displaying error message
12497 about invalid control letter, pass the character's codepoint, not
12498 a pointer to its multibyte form. Improve display of the character
12499 in octal and display also its hex code.
12500
12501 * character.c (char_string): Use %x to display the (unsigned)
12502 codepoint of an invalid character, to avoid displaying a bogus
12503 negative value.
12504
12505 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12506 `error', not SYMBOL_NAME itself.
12507
12508 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12509 character arguments to `error'.
12510
12511 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12512 to `error' in error message about FINAL_CHAR argument. Make sure
12513 FINAL_CHAR is a character, and use %c when it is passed as
12514 argument to `error'.
12515
4ffd0d6b 125162011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12517
12518 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12519
12520 * w32.c: Include <time.h>.
12521 (sys_localtime): New function.
12522
4ffd0d6b 125232011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12524
12525 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12526
4ffd0d6b 12527 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12528
4ffd0d6b 125292011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12530
4ffd0d6b
GM
12531 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12532 zombies (Bug#8467).
aac0c6e3 12533
04c56954
EZ
125342011-04-19 Eli Zaretskii <eliz@gnu.org>
12535
12536 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12537 gl_state.e_property when gl_state.object is Qt.
12538
12539 * insdel.c (make_gap_larger): Remove limitation of buffer size
12540 to <= INT_MAX.
12541
16a43933
CY
125422011-04-18 Chong Yidong <cyd@stupidchicken.com>
12543
12544 * xdisp.c (lookup_glyphless_char_display)
12545 (produce_glyphless_glyph): Handle cons cell entry in
12546 glyphless-char-display.
12547 (Vglyphless_char_display): Document it.
12548
12549 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12550 glyphless-char-display.
12551
4581706e
CY
125522011-04-17 Chong Yidong <cyd@stupidchicken.com>
12553
12554 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12555
12556 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12557
12558 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12559 definition for no-X builds.
12560
4887c6e2 125612011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12562
fd35b6f9
PE
12563 Static checks with GCC 4.6.0 and non-default toolkits.
12564
5c1ccb01
PE
12565 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12566
006c5daa
PE
12567 * process.c (keyboard_bit_set): Define only if SIGIO.
12568 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12569 (send_process): Repair possible setjmp clobbering.
12570
efc736d3
PE
12571 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12572
4e2fe2e6
PE
12573 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12574
f97334a2
PE
12575 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12576
4e75f29d
PE
12577 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12578 Define only if needed.
12579
90efadd1
PE
12580 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12581 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12582 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12583
3c647824
PE
12584 * dispextern.h (struct redisplay_interface): Rename param
12585 to avoid shadowing.
e264f262 12586 * termhooks.h (struct terminal): Likewise.
761383f4 12587 * xterm.c (xembed_send_message): Likewise.
3c647824 12588
b58c5c4a
PE
12589 * insdel.c (make_gap_smaller): Define only if
12590 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12591
cad59032
PE
12592 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12593 it.
12594
c339dc2e
PE
12595 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12596 so that we aren't warned about unused symbols.
12597
91a3e27b
PE
12598 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12599
399c71d3 12600 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12601
8ffc96f5
PE
12602 * xfns.c (x_real_positions): Mark locals as initialized.
12603
eef9bc79
PE
12604 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12605
098db9dd
PE
12606 * xterm.c: Fix problems found by static analysis with other toolkits.
12607 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12608 (x_dispatch_event): Declare static if USE_GTK, and
12609 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12610 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12611 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12612 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12613 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12614
eb18f6cc
PE
12615 * xmenu.c (menu_help_callback): Pointer type fixes.
12616 Use const pointers when pointing at readonly data. Avoid pointer
12617 signedness clashes.
12618 (FALSE): Remove unused macro.
12619 (update_frame_menubar): Remove unused decl.
12620
1fe72bf8
PE
12621 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12622
60d9e1db
PE
12623 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12624 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12625 (single_menu_item): Rename local to avoid shadowing.
12626
39261c26
PE
12627 * keyboard.c (make_lispy_event): Remove unused local var.
12628
018c5e19
PE
12629 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12630 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12631
63d2b86e
PE
12632 * bitmaps: Change bitmaps from unsigned char back to the X11
12633 compatible char. Avoid the old compiler warnings about
12634 out-of-range initializers by using, for example, '\xab' rather
12635 than 0xab.
12636
aefd87e1
PE
12637 * xgselect.c (xgselect_initialize): Check vs interface
12638 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12639
bf501fb9
PE
12640 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12641
e9829fdf
PE
12642 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12643 to read-only memory.
12644
1086c095
PE
12645 * fns.c (vector): Remove; this old hack is no longer needed.
12646
2baccd04 12647 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12648 Remove unused var.
dde42981 12649 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12650
72391843 12651 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12652
436c16df 12653 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12654 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12655 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12656
92bb796d 12657 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12658 (x_term_init): Remove local to avoid shadowing.
92bb796d 12659
764430a3 12660 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12661
12662 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12663 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12664
d1dfb56c
EZ
126652011-04-16 Eli Zaretskii <eliz@gnu.org>
12666
c4354cb4
EZ
12667 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12668
d1dfb56c
EZ
12669 Fix regex.c, syntax.c and friends for buffers > 2GB.
12670 * syntax.h (struct gl_state_s): Declare character position members
12671 EMACS_INT.
12672
12673 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12674
04f2d78b
CB
12675 * textprop.c (verify_interval_modification, interval_of):
12676 Declare arguments EMACS_INT.
d1dfb56c
EZ
12677
12678 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12679 EMACS_INT.
12680
12681 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12682
12683 * indent.c (Fvertical_motion): Local variable it_start is now
12684 EMACS_INT.
12685
12686 * regex.c (re_match, re_match_2, re_match_2_internal)
12687 (bcmp_translate, regcomp, regexec, print_double_string)
12688 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12689 (re_compile_pattern, re_exec): Declare arguments and local
12690 variables `size_t' and `ssize_t' and return values `regoff_t', as
12691 appropriate.
12692 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12693 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12694 <compile_stack_type>: `size' and `avail' are now `size_t'.
12695
12696 * regex.h <regoff_t>: Use ssize_t, not int.
12697 (re_search, re_search_2, re_match, re_match_2): Arguments that
12698 specify buffer/string position and length are now ssize_t and
12699 size_t. Return type is regoff_t.
12700
613052cd
BK
127012011-04-16 Ben Key <bkey76@gmail.com>
12702
12703 * nsfont.m: Fixed bugs in ns_get_family and
12704 ns_descriptor_to_entity that were caused by using free to
12705 deallocate memory blocks that were allocated by xmalloc (via
12706 xstrdup). This caused Emacs to crash when compiled with
12707 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12708 --enable-checking=xmallocoverrun). xfree is now used to
12709 deallocate these memory blocks.
12710
4170f62f 127112011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12712
71b41406
PE
12713 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12714
9587a89d
PE
12715 emacs_write: Accept and return EMACS_INT for sizes.
12716 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12717 et seq.
12718 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12719 Accept and return EMACS_INT.
12720 (emacs_gnutls_write): Return the number of bytes written on
12721 partial writes.
12722 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12723 (emacs_read, emacs_write): Remove check for negative size, as the
12724 Emacs source code has been audited now.
9587a89d
PE
12725 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12726 (emacs_read, emacs_write): Use it.
273a5f82
PE
12727 * process.c (send_process): Adjust to the new signatures of
12728 emacs_write and emacs_gnutls_write. Do not attempt to store
12729 a byte offset into an 'int'; it might overflow.
9587a89d 12730 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12731
3e047f51
PE
12732 * sound.c: Don't assume sizes fit in 'int'.
12733 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12734 Return EMACS_INT, not int.
3e047f51 12735 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12736 Accept EMACS_INT, not int.
12737 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12738 record read return values.
12739
cc39a9db
BK
127402011-04-15 Ben Key <bkey76@gmail.com>
12741
c9d0ec6d
JB
12742 * keyboard.c (Qundefined): Don't declare static since it is used
12743 in nsfns.m.
12744 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12745 static since they are used in nsfont.m.
cc39a9db 12746
6c60eb9f
SM
127472011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12748
12749 * process.c (Qprocessp): Don't declare static.
12750 * lisp.h (Qprocessp): Declare again.
12751
7990b61a
JB
127522011-04-15 Juanma Barranquero <lekktu@gmail.com>
12753
12754 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12755
5d4cb038
PE
127562011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12757
8bd7b830 12758 Improve C-level modularity by making more things 'static'.
cd64ea1d 12759
e3b27b31
PE
12760 Don't publish debugger-only interfaces to other modules.
12761 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12762 (verify_bytepos, count_markers): Move decls to the only modules
12763 that need them.
12764 * region-cache.h (pp_cache): Likewise.
12765 * window.h (check_all_windows): Likewise.
12766 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12767
5d4cb038
PE
12768 * sysdep.c (croak): Now static, if
12769 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12770 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12771
12772 * alloc.c (refill_memory_reserve): Now static if
12773 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12774 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12775
e87b6180
PE
12776 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12777 Define only if USE_LUCID.
12778
ac64929e
PE
12779 * xrdb.c (x_customization_string, x_rm_string): Now static.
12780
6f37259d
PE
12781 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12782 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12783
1683e3ab
PE
12784 * xdisp.c (draw_row_with_mouse_face): Now static.
12785 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12786
de9c2632
PE
12787 * window.h (check_all_windows): Mark externally visible.
12788
2b96acb7
PE
12789 * window.c (window_deletion_count): Now static.
12790
12791 * undo.c: Make symbols static if they're not exported.
12792 (last_undo_buffer, last_boundary_position, pending_boundary):
12793 Now static.
12794
50436f33
PE
12795 * textprop.c (interval_insert_behind_hooks): Now static.
12796 (interval_insert_in_front_hooks): Likewise.
12797
64520e5c
PE
12798 * term.c: Make symbols static if they're not exported.
12799 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12800 (max_frame_lines, tty_set_terminal_modes):
12801 (tty_reset_terminal_modes, tty_turn_off_highlight):
12802 (get_tty_terminal): Now static.
12803 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12804 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12805 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12806 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12807 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12808
1fa53021
PE
12809 * sysdep.c: Make symbols static if they're not exported.
12810 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12811 Now static.
12812 (sigprocmask_set, full_mask): Remove; unused.
12813 (wait_debugging): Mark as visible.
12814 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12815 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12816
d4b43b22
PE
12817 * syntax.c (syntax_temp): Define only if !__GNUC__.
12818
b7c513d0
PE
12819 * sound.c (current_sound_device, current_sound): Now static.
12820
989b29ad
PE
12821 * search.c (searchbufs, searchbuf_head): Now static.
12822
13a55a78
PE
12823 * scroll.c (scroll_cost): Remove; unused.
12824 * dispextern.h (scroll_cost): Remove decl.
12825
de68a1fc
PE
12826 * region-cache.h (pp_cache): Mark as externally visible.
12827
40ccffa6
PE
12828 * process.c: Make symbols static if they're not exported.
12829 (process_tick, update_tick, create_process, chan_process):
12830 (Vprocess_alist, proc_buffered_char, datagram_access):
12831 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12832 (deactivate_process): Mark defn as static, as well as decl.
12833 * lisp.h (create_process): Remove decl.
12834 * process.h (chan_process, Vprocess_alist): Remove decls.
12835
ad64fc97
PE
12836 * print.c: Make symbols static if they're not exported.
12837 (print_depth, new_backquote_output, being_printed, print_buffer):
12838 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12839 (print_interval, print_number_index, initial_stderr_stream):
12840 Now static.
12841 * lisp.h (Fprinc): Remove decl.
12842 (debug_output_compilation_hack): Mark as externally visible.
12843
adddb265
PE
12844 * sysdep.c (croak): Move decl from here to syssignal.h.
12845 * syssignal.h (croak): Put it here, so the API can be checked when
12846 'croak' is called from dissociate_if_controlling_tty.
12847
1717ede2
PE
12848 * minibuf.c: Make symbols static if they're not exported.
12849 (minibuf_save_list, choose_minibuf_frame): Now static.
12850 * lisp.h (choose_minibuf_frame): Remove decl.
12851
fa5fb2bc
PE
12852 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12853
1e3890d1
PE
12854 * lread.c: Make symbols static if they're not exported.
12855 (read_objects, initial_obarray, oblookup_last_bucket_number):
12856 Now static.
12857 (make_symbol): Remove; unused.
12858 * lisp.h (initial_obarray, make_symbol): Remove decls.
12859
8a1414fa
PE
12860 * keyboard.c: Make symbols static if they're not exported.
12861 (single_kboard, recent_keys_index, total_keys, recent_keys):
12862 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12863 (this_single_command_key_start, echoing, last_auto_save):
12864 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12865 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12866 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12867 (Vlispy_mouse_stem, double_click_count):
12868 Now static.
12869 (force_auto_save_soon): Define only if SIGDANGER.
12870 (ignore_mouse_drag_p): Now static if
12871 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12872 (print_help): Remove; unused.
12873 (stop_character, last_timer_event): Mark as externally visible.
12874 * keyboard.h (ignore_mouse_drag_p): Declare only if
12875 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12876 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12877 * lisp.h (echoing): Remove decl.
12878 (force_auto_save_soon): Declare only if SIGDANGER.
12879 * xdisp.c (redisplay_window): Simplify code, to make it more
12880 obvious that ignore_mouse_drag_p is not accessed if !defined
12881 USE_GTK && !defined HAVE_NS.
12882
93ea6e8f
PE
12883 * intervals.c: Make symbols static if they're not exported.
12884 (merge_properties_sticky, merge_interval_right, delete_interval):
12885 Now static.
12886 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12887
77382fcc
PE
12888 * insdel.c: Make symbols static if they're not exported.
12889 However, leave prepare_to_modify_buffer alone. It's never
12890 called from outside this function, but that appears to be a bug.
12891 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12892 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12893 (adjust_after_replace_noundo): Remove; unused.
12894 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12895 (signal_before_change): Remove decls.
77382fcc 12896
9306c32e
PE
12897 * indent.c (val_compute_motion, val_vmotion): Now static.
12898
cd44d2eb
PE
12899 * image.c: Make symbols static if they're not exported.
12900 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12901 if USE_GTK.
12902 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12903 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12904
ad9a7a06
PE
12905 * fringe.c (standard_bitmaps): Now static.
12906 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12907
81626931
PE
12908 * frame.c: Make symbols static if they're not exported.
12909 (x_report_frame_params, make_terminal_frame): Now static.
12910 (get_frame_param): Now static, unless HAVE_NS.
12911 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12912 (x_get_resource_string): Remove; not used.
12913 * frame.h (make_terminal_frame, x_report_frame_params):
12914 (x_get_resource_string); Remove decls.
12915 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12916 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12917
239f9db9
PE
12918 * font.c, fontset.c: Make symbols static if they're not exported.
12919 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12920 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12921 * font.c (font_close_object): Now static.
12922 * font.h (font_close_object): Remove.
12923 * fontset.c (FONTSET_OBJLIST): Remove.
12924 (free_realized_fontset) #if-0 the body, which does nothing.
12925 (face_suitable_for_char_p): #if-0, as it's never called.
12926 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12927 * xfaces.c (face_at_string_position):
12928 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12929 since 0 is always ASCII.
12930
dfcf3579
PE
12931 * fns.c (weak_hash_tables): Now static.
12932
5045092b
PE
12933 * fileio.c: Make symbols static if they're not exported.
12934 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12935 (Vwrite_region_annotation_buffers): Now static.
12936
57a96f5c
PE
12937 * eval.c: Make symbols static if they're not exported.
12938 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12939 * lisp.h (backtrace_list): Remove decl.
12940
35f08c38
PE
12941 * emacs.c: Make symbols static if they're not exported.
12942 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12943 (fatal_error_code, fatal_error_signal_hook, standard_args):
12944 Now static.
12945 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12946 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12947 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12948 * lisp.h (fatal_error_signal_hook): Remove decl.
12949 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12950
f44bd759
PE
12951 * editfns.c: Move a (normally-unused) function to its only use.
12952 * editfns.c, lisp.h (get_operating_system_release): Remove.
12953 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12954 worth the hassle of breaking this out.
12955
b532497d
PE
12956 * xterm.c: Make symbols static if they're not exported.
12957 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12958 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12959 (x_destroy_window, x_delete_display):
12960 Now static.
12961 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12962 (x_mouse_leave): Remove; unused.
12963 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12964 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12965 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12966 Remove decls.
12967 (x_mouse_leave): Declare only if WINDOWSNT.
12968 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12969 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12970 USE_X_TOOLKIT.
12971
1675728f
PE
12972 * ftxfont.c: Make symbols static if they're not exported.
12973 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12974 HAVE_FREETYPE.
12975 * font.h (ftxfont_driver): Likewise.
12976
e4cebfca
PE
12977 * xfns.c: Make symbols static if they're not exported.
12978 (x_last_font_name, x_display_info_for_name):
12979 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12980 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12981 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12982 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12983 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12984 (last_show_tip_args): Now static.
12985 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12986 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12987 (x_screen_planes): Remove; unused.
12988 * dispextern.h (x_screen_planes): Remove decl.
12989
5bf46f05
PE
12990 * dispnew.c: Make symbols static if they're not exported.
12991 * dispextern.h (redraw_garbaged_frames, scrolling):
12992 (increment_row_positions): Remove.
12993 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12994 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12995 Now static.
12996 (redraw_garbaged_frames): Remove; unused.
12997
435f4c28
PE
12998 * xfaces.c: Make symbols static if they're not exported.
12999 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13000 Remove decls.
13001 * xterm.h (defined_color): Remove decls.
13002 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13003 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13004 (menu_face_changed_default, defined_color, free_realized_face):
13005 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13006 (ascii_face_of_lisp_face): Remove; unused.
13007
8524aef3
PE
13008 * xdisp.c: Make symbols static if they're not exported.
13009 * dispextern.h (scratch_glyph_row, window_box_edges):
13010 (glyph_to_pixel_coords, set_cursor_from_row):
13011 (get_next_display_element, set_iterator_to_next):
13012 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13013 (show_mouse_face): Remove decls
13014 * frame.h (message_buf_print): Likewise.
13015 * lisp.h (pop_message, set_message, check_point_in_composition):
13016 Likewise.
13017 * xterm.h (set_vertical_scroll_bar): Likewise.
13018 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13019 (message_buf_print, scratch_glyph_row, displayed_buffer):
13020 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13021 (get_next_display_element, show_mouse_face, window_box_edges):
13022 (frame_to_window_pixel_xy, check_point_in_composition):
13023 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13024 (glyph_to_pixel_coords): Remove; unused.
13025
16390cd2
PE
13026 * dired.c (file_name_completion): Now static.
13027
13028 * dbusbind.c (xd_in_read_queued_messages): Now static.
13029
a25f4dfa
PE
13030 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13031 * data.c (circular_list_error): Remove.
13032
14a9c8df
PE
13033 * commands.h (last_point_position, last_point_position_buffer):
13034 (last_point_position_window): Remove decls.
13035 * keyboard.c: Make these variables static.
13036
04f2d78b
CB
13037 * coding.h (coding, code_convert_region, encode_coding_gap):
13038 Remove decls.
74ab6df5
PE
13039 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13040 (iso_code_class, detect_coding, code_convert_region): Now static.
13041 (encode_coding_gap): Remove; unused.
13042
38dfbee1
PE
13043 * chartab.c (chartab_chars, chartab_bits): Now static.
13044
a2cb4e63
PE
13045 * charset.h (charset_iso_8859_1): Remove decl.
13046 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13047 Now static.
13048
127198fd
PE
13049 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13050 * ccl.c (Vccl_program_table): Now static.
13051 (check_ccl_update): Remove; unused.
13052
d85b608f
PE
13053 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13054 * category.h: ... from here.
13055 * category.c (check_category_table, set_category_set): Now static.
13056
31cd66f3
PE
13057 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13058 * lisp.h: Remove these decls.
13059
c358e587
PE
13060 * buffer.c (buffer_count): Remove unused var.
13061
e78aecca
PE
13062 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13063 so that it's not optimized away.
13064 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13065 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13066 exported only to the debugger.
13067
e192d7d3 13068 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13069 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13070
92470028
PE
13071 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13072 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13073 was inaccessible from Lisp.
13074 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13075 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13076
244ed907
PE
13077 alloc.c: Import and export fewer symbols, and remove unused items.
13078 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13079 is defined.
13080 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13081 it's not optimized away by whole-program optimization.
13082 (message_enable_multibyte, free_misc): Remove.
13083 (catchlist, handlerlist, mark_backtrace):
13084 Declare only if BYTE_MARK_STACK.
13085 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13086 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13087 (message_enable_multibyte): Remove decl.
13088 (free_misc, interval_free_list, float_block, float_block_index):
13089 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13090 (cons_free_list, last_marked_index):
13091 Now static.
13092 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13093 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13094 (mark_backtrace): Define only if BYTE_MARK_STACK.
13095 * xdisp.c (message_enable_multibyte): Now static.
13096
61c2b50e 13097 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13098 This makes it easier for human readers (and static analyzers)
13099 to see whether these variables are used from other modules.
13100 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13101 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13102 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13103 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13104 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13105 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13106 * xmenu.c, xselect.c:
13107 Declare Q* vars static if they are not used in other modules.
13108 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13109 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13110 Remove decls of unexported vars.
13111 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13112
95c82688
PE
13113 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13114
16a97296
PE
13115 Make Emacs functions such as Fatom 'static' by default.
13116 This makes it easier for human readers (and static analyzers)
13117 to see whether these functions can be called from other modules.
13118 DEFUN now defines a static function. To make the function external
13119 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13120 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13121 (Finit_image_library):
16a97296
PE
13122 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13123 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13124 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13125 Remove decls, since these functions are now static.
13126 (Funintern, Fget_internal_run_time): New decls, since these functions
13127 were already external.
95c82688 13128
16a97296
PE
13129 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13130 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13131 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13132 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13133 * keyboard.c, keymap.c, lread.c:
13134 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13135 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13136 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13137 Mark functions with DEFUE instead of DEFUN,
13138 if they are used in other modules.
13139 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13140 decls for now-static functions.
13141 * buffer.h (Fdelete_overlay): Remove decl.
13142 * callproc.c (Fgetenv_internal): Mark as internal.
13143 * composite.c (Fremove_list_of_text_properties): Remove decl.
13144 (Fcomposition_get_gstring): New forward static decl.
13145 * composite.h (Fcomposite_get_gstring): Remove decl.
13146 * dired.c (Ffile_attributes): New forward static decl.
13147 * doc.c (Fdocumntation_property): New forward static decl.
13148 * eval.c (Ffetch_bytecode): New forward static decl.
13149 (Funintern): Remove extern decl; now in .h file where it belongs.
13150 * fileio.c (Fmake_symbolic_link): New forward static decl.
13151 * image.c (Finit_image_library): New forward static decl.
13152 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13153 * intervals.h (Fprevious_property_change):
13154 (Fremove_list_of_text_properties): Remove decls.
13155 * keyboard.c (Fthis_command_keys): Remove decl.
13156 (Fcommand_execute): New forward static decl.
13157 * keymap.c (Flookup_key): New forward static decl.
13158 (Fcopy_keymap): Now static.
13159 * keymap.h (Flookup_key): Remove decl.
13160 * process.c (Fget_process): New forward static decl.
13161 (Fprocess_datagram_address): Mark as internal.
13162 * syntax.c (Fsyntax_table_p): New forward static decl.
13163 (skip_chars): Remove duplicate decl.
13164 * textprop.c (Fprevious_property_change): New forward static decl.
13165 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13166 Now internal.
13167 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13168 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13169
785bbd42
PE
13170 * editfns.c (Fformat): Remove unreachable code.
13171
8b913b57
AS
131722011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13173
13174 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13175 change. (Bug#8496)
13176
a6744a35
EZ
131772011-04-13 Eli Zaretskii <eliz@gnu.org>
13178
13179 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13180 when at ZV. (Bug#8487)
13181
e7974947
AS
131822011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13183
baad03f0
AS
13184 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13185 (Bug#8437)
13186 * keyboard.c (parse_tool_bar_item): Likewise.
13187 * sound.c (sound_cleanup, alsa_close): Likewise.
13188 * termcap.c (tgetent): Likewise.
13189 * xfns.c (x_default_font_parameter): Likewise.
13190 * xsettings.c (read_and_apply_settings): Likewise.
13191
e7974947
AS
13192 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13193 (overrun_check_free): Protoize.
13194
28272684
PE
131952011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13196
13197 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13198 since callers should never pass a negative size.
13199 Change the signature to match that of plain 'read' and 'write'; see
13200 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13201 * lisp.h: Update prototypes of emacs_write and emacs_read.
13202
11997c76
EZ
132032011-04-11 Eli Zaretskii <eliz@gnu.org>
13204
13205 * xdisp.c (redisplay_window): Don't try to determine the character
13206 position of the scroll margin if the window start point w->startp
e896f03c 13207 is outside the buffer's accessible region. (Bug#8468)
11997c76 13208
8a2cbd72
EZ
132092011-04-10 Eli Zaretskii <eliz@gnu.org>
13210
13211 Fix write-region and its subroutines for buffers > 2GB.
13212 * fileio.c (a_write, e_write): Modify declaration of arguments and
13213 local variables to support buffers larger than 2GB.
13214 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13215
13216 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13217 argument, local variables, and return value.
13218
13219 * lisp.h: Update prototypes of emacs_write and emacs_read.
13220
13221 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13222
4073e537 132232011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13224
1ebfdcb6
PE
13225 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13226
b2ded58d
PE
13227 Fix more problems found by GCC 4.6.0's static checks.
13228
7d66342c
PE
13229 * xdisp.c (vmessage): Use a better test for character truncation.
13230
bbf47d44
PE
13231 * charset.c (load_charset_map): <, not <=, for optimization,
13232 and to avoid potential problems with integer overflow.
9248994d 13233 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13234 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13235 * editfns.c (Fformat): Likewise.
1e69125e 13236 * syntax.c (skip_chars): Likewise.
3befa583 13237
e3019616
PE
13238 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13239 This also lets GCC 4.6.0 generate slightly better loop code.
13240
becfa255
PE
13241 * callint.c (Fcall_interactively): <, not <=, for optimization.
13242 (Fcall_interactively): Count the number of arguments produced,
13243 not the number of arguments given. This is simpler and lets GCC
13244 4.6.0 generate slightly better code.
13245
dae0cd48
PE
13246 * ftfont.c: Distingish more carefully between FcChar8 and char.
13247 The previous code passed unsigned char * to a functions like
13248 strlen and xstrcasecmp that expect char *, which does not
13249 conform to the C standard.
13250 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13251 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13252 char * when the C standard requires it.
13253
76032d70
PE
13254 * keyboard.c (read_char): Remove unused var.
13255
eb3f1cc8
PE
13256 * eval.c: Port to Windows vsnprintf (Bug#8435).
13257 Include <limits.h>.
13258 (SIZE_MAX): Define if the headers do not.
13259 (verror): Do not give up if vsnprintf returns a negative count.
13260 Instead, grow the buffer. This ports to Windows vsnprintf, which
13261 does not conform to C99. Problem reported by Eli Zaretskii.
13262 Also, simplify the allocation scheme, by avoiding the need for
13263 calling realloc, and removing the ALLOCATED variable.
13264
70476b54
PE
13265 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13266
12020a9e
PE
13267 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13268 But keep the doprint source code for now, as we might revamp it
13269 and use it again (Bug#8435).
ea6c7ae6
PE
13270 * lisp.h (doprnt): Remove.
13271 * Makefile.in (base_obj): Remove doprnt.o.
13272 * deps.mk (doprnt.o): Remove.
13273
5fdb398c
PE
13274 error: Print 32- and 64-bit integers portably (Bug#8435).
13275 Without this change, on typical 64-bit hosts error ("...%d...", N)
13276 was used to print both 32- and 64-bit integers N, which relied on
13277 undefined behavior.
61bdb816 13278 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13279 * lisp.h (error, verror): Mark as printf-like functions.
13280 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13281 Report overflow in size calculations when allocating printf buffer.
13282 Do not truncate output string at its first null byte.
13283 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13284 Truncate the output at a character boundary, since vsnprintf does not
13285 do that.
13286 * charset.c (check_iso_charset_parameter): Convert internal
13287 character to string before calling 'error', since %c now has the
13288 printf meaning.
13289 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13290 overflow when computing char to be passed to 'error'. Do not
13291 pass Lisp_Object to 'error'; pass the integer instead.
13292 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13293 formatted with plain %d.
13294
b189fa66
PE
13295 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13296
bff87ef0
PE
13297 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13298
7e2cac20
PE
13299 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13300
ce4d90b5
PE
13301 * xterm.c (x_catch_errors): Remove duplicate declaration.
13302
266c9547
PE
13303 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13304
79c49ad2
PE
13305 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13306
368f4090
JM
133072011-04-10 Jim Meyering <meyering@redhat.com>
13308
13309 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13310 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13311 return ssize_t not "int", and use size_t as the buffer length.
13312 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13313 * gnutls.h: Update declarations.
13314 * process.c (read_process_output): Use ssize_t, to match.
13315 (send_process): Likewise.
13316
a32d4040
CY
133172011-04-09 Chong Yidong <cyd@stupidchicken.com>
13318
13319 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13320
8546720e 133212011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13322
04f2d78b
CB
13323 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13324 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13325
8546720e
GM
13326 * xterm.c (handle_one_xevent):
13327 * xmenu.c (create_and_show_popup_menu):
13328 * xselect.c (x_decline_selection_request)
13329 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13330
0a2f5c1a 133312011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13332
13333 Fix some uses of `int' instead of EMACS_INT.
13334 * search.c (string_match_1, fast_string_match)
13335 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13336 (scan_buffer, find_next_newline_no_quit)
13337 (find_before_next_newline, search_command, Freplace_match)
13338 (Fmatch_data): Make some `int' variables be EMACS_INT.
13339
13340 * xdisp.c (display_count_lines): 3rd argument and return value now
13341 EMACS_INT. All callers changed.
13342 (pint2hrstr): Last argument is now EMACS_INT.
13343
13344 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13345 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13346 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13347 (decode_coding_utf_16, decode_coding_emacs_mule)
13348 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13349 (decode_coding_ccl, decode_coding_charset)
13350 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13351 (decode_coding_iso_2022, decode_coding_emacs_mule)
13352 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13353 <char_offset, last_offset>: Declare EMACS_INT.
13354 (encode_coding_utf_8, encode_coding_utf_16)
13355 (encode_coding_emacs_mule, encode_invocation_designation)
13356 (encode_designation_at_bol, encode_coding_iso_2022)
13357 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13358 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13359 Declare EMACS_INT.
13360 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13361 (encode_invocation_designation): Last argument P_NCHARS is now
13362 EMACS_INT.
13363 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13364 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13365
13366 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13367 All users changed.
13368
13369 * ccl.c (Fccl_execute_on_string): Declare some variables
13370 EMACS_INT.
13371
8546720e 133722011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13373
13374 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13375
4e19a977
CS
133762011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13377
13378 * process.c (Fformat_network_address): Doc fix.
13379
87302331
R
133802011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13381
ee7683eb 13382 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13383
cbb59342
CY
133842011-04-08 Chong Yidong <cyd@stupidchicken.com>
13385
13386 * keyboard.c (read_char): Call Lisp function help-form-show,
13387 instead of using internal_with_output_to_temp_buffer.
13388 (Qhelp_form_show): New var.
e0d38eeb 13389 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13390
13391 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13392
13393 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13394
e67a13ab
CY
133952011-04-06 Chong Yidong <cyd@stupidchicken.com>
13396
04f2d78b
CB
13397 * process.c (Flist_processes): Remove to Lisp.
13398 (list_processes_1): Delete.
e67a13ab 13399
973f782d
EZ
134002011-04-06 Eli Zaretskii <eliz@gnu.org>
13401
7c106b1e
EZ
13402 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13403
973f782d
EZ
13404 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13405
41cf7d1a 134062011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13407
ca23cc88
PE
13408 Fix more problems found by GCC 4.6.0's static checks.
13409
f390e2d5
PE
13410 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13411
42eea0d0
PE
13412 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13413
b69769da 13414 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13415
f9541e84
PE
13416 * xdisp.c (vmessage): Mark as a printf-like function.
13417
13841b55
PE
13418 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13419
c136c10f
PE
13420 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13421
5e2d4a30
PE
13422 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13423 printf-like functions.
13424 (tiff_load): Add casts to remove these marks before passing them
13425 to system-supplied API.
13426
583f48b9
PE
13427 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13428
b25d760e
PE
13429 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13430 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13431 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13432 directly, rather than having caller test rule sign. This avoids
13433 some unnecessary tests.
13434 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13435 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13436 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13437
bc7b6697 13438 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13439 (xfont_open): Avoid unnecessary tests.
bc7b6697 13440
27ccc379
PE
13441 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13442
dcd5c89a
PE
13443 * composite.h, composite.c (composition_gstring_put_cache):
13444 Use EMACS_INT, not int, for length.
13445
b13a45c6
PE
13446 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13447 breaking out part of COMPOSITION_DECODE_RULE.
13448 (COMPOSITION_DECODE_RULE): Use it.
13449 * composite.c (get_composition_id): Remove unused local vars,
13450 by using the new macro.
13451
1e792e4d
PE
13452 * textprop.c (set_text_properties_1): Change while to do-while,
13453 since the condition is always true at first.
13454
dc6c6455 13455 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13456 (interval_deletion_adjustment): Return unsigned value.
13457 All uses changed.
dc6c6455 13458
aba7731a
PE
13459 * process.c (list_processes_1, create_pty, read_process_output):
13460 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13461 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13462 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13463 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13464 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13465
fdfc4bf3
PE
13466 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13467
fca8fe46 13468 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13469 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13470
06a0259a 13471 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13472 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13473 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13474
e7b9e80f
PE
13475 * print.c (print_error_message): Avoid int overflow.
13476
56201685
PE
13477 * font.c (font_list_entities): Redo for clarity,
13478 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13479
78834453 13480 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13481 (font_score): Avoid potential overflow in diff calculation.
78834453 13482
0bc0b309 13483 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13484 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13485
e610eaca
PE
13486 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13487
b895abce
PE
13488 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13489 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13490 can always succeed if overflow has undefined behavior.
13491
1f1d9321 13492 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13493 (wordify): Omit three unnecessary tests.
1f1d9321 13494
c59478bc
PE
13495 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13496 All callers changed. This avoids the need for an unused var.
13497
79b73827
PE
13498 * casefiddle.c (casify_region): Remove var that is set but not used.
13499
a4db5dfe
PE
13500 * dired.c (file_name_completion): Remove var that is set but not used.
13501
43aae36e
PE
13502 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13503
2a47c44d 13504 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13505 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13506
a37c69bf
PE
13507 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13508 Check for integer overflow on size calculations.
13509
328ab8e7
PE
13510 * buffer.c (Fprevious_overlay_change): Remove var that is set
13511 but not used.
13512
e5a2a5cb
PE
13513 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13514 Remove vars that are set but not used.
8d84a6eb 13515 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13516 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13517
a60e5f68
PE
13518 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13519
f661cb61 13520 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13521 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13522
f0397f5a
PE
13523 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13524 that are set but not used.
13525
8664db06 13526 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13527 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13528
6abdaa4a
PE
13529 * xselect.c (x_get_local_selection, x_handle_property_notify):
13530 Remove vars that are set but not used.
13531
0ce7538d 13532 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13533 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13534
9ae848fc
PE
13535 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13536 Remove var that is set but not used.
0b918413
PE
13537 (scroll_bar_windows_size): Now size_t, not int.
13538 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13539 Check for overflow.
9ae848fc 13540
a5a62657
PE
13541 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13542 (map_tty_color) [!defined MSDOS]: Likewise.
13543
5c5cdd39
PE
13544 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13545
66ebf983
PE
13546 * coding.c: Remove vars that are set but not used.
13547 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13548 All callers changed.
13549 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13550 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13551 (decode_coding_charset): Remove vars that are set but not used.
13552
1be4d761
PE
13553 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13554 that is set but not used.
13555
47553fa8
PE
13556 * print.c (print_object): Remove var that is set but not used.
13557
1f7196bf 13558 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13559 The gnulib version avoids calling malloc in the usual case,
13560 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13561 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13562 * filelock.c (current_lock_owner): Likewise.
13563 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13564 * sysdep.c: Include allocator.h, careadlinkat.h.
13565 (emacs_no_realloc_allocator): New static constant.
13566 (emacs_readlink): New function.
fdb61804
PE
13567 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13568 ../lib/careadlinkat.h.
d1fdcab7 13569
f84c17c7
SM
135702011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13571
13572 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13573 first non-nil return value).
13574
ef3862ad
JD
135752011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13576
13577 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13578 if not defined (Bug#8403).
13579
376a7006
JB
135802011-04-02 Juanma Barranquero <lekktu@gmail.com>
13581
13582 * xdisp.c (display_count_lines): Remove parameter `start',
13583 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13584 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13585 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13586 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13587 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13588 and thereabouts. All callers changed.
13589 (get_per_char_metric): Remove parameter `f', unused since
13590 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13591
6ca3801d
JM
135922011-04-02 Jim Meyering <meyering@redhat.com>
13593
13594 do not dereference NULL upon failed strdup
13595 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13596 (ns_get_family): Likewise.
13597
d8e2b5ba
JB
135982011-04-02 Juanma Barranquero <lekktu@gmail.com>
13599
13600 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13601
8c74fcbd
JD
136022011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13603
13604 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13605 later (Bug#8403).
13606
7200d79c
SM
136072011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13608
03408648 13609 Add lexical binding.
7200d79c 13610
03408648
SM
13611 * window.c (Ftemp_output_buffer_show): New fun.
13612 (Fsave_window_excursion):
13613 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13614
13615 * lread.c (lisp_file_lexically_bound_p): New function.
13616 (Fload): Bind Qlexical_binding.
13617 (readevalloop): Remove `evalfun' arg.
13618 Bind Qinternal_interpreter_environment.
13619 (Feval_buffer): Bind Qlexical_binding.
13620 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13621 Mark as dynamic.
13622 (syms_of_lread): Declare `lexical-binding'.
13623
13624 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13625
13626 * keyboard.c (eval_dyn): New fun.
13627 (menu_item_eval_property): Use it.
ca105506
SM
13628
13629 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13630
03408648
SM
13631 * fns.c (concat, mapcar1): Accept byte-code-functions.
13632
13633 * eval.c (Fsetq): Handle lexical vars.
13634 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13635 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13636 (FletX, Flet): Obey lexical binding.
13637 (Fcommandp): Handle closures.
13638 (Feval): New `lexical' arg.
13639 (eval_sub): New function extracted from Feval. Use it almost
13640 everywhere where Feval was used. Look up vars in lexical env.
13641 Handle closures.
13642 (Ffunctionp): Move from subr.el.
13643 (Ffuncall): Handle closures.
13644 (apply_lambda): Remove `eval_flags'.
13645 (funcall_lambda): Handle closures and new byte-code-functions.
13646 (Fspecial_variable_p): New function.
13647 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13648 but without exporting it to Lisp.
23aba0ea 13649
23aba0ea 13650 * doc.c (Fdocumentation, store_function_docstring):
03408648 13651 * data.c (Finteractive_form): Handle closures.
23aba0ea 13652
03408648
SM
13653 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13654 interactive spec.
ba83908c 13655
04f2d78b
CB
13656 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13657 New byte-codes.
03408648
SM
13658 (exec_byte_code): New function extracted from Fbyte_code to handle new
13659 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13660
03408648 13661 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13662
03408648 13663 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13664
e2abce01
JB
136652011-03-31 Juanma Barranquero <lekktu@gmail.com>
13666
13667 * xdisp.c (redisplay_internal): Fix prototype.
13668
63696a73 136692011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13670
63696a73 13671 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13672 (try_scrolling): Use it when setting scroll_limit.
13673 Limit scrolling to 100 screen lines.
63696a73
EZ
13674 (redisplay_window): Even when falling back on "recentering",
13675 position point in the window according to scroll-conservatively,
13676 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13677
13678 (try_scrolling): When point is above the window, allow searching
13679 as far as scroll_max, or one screenful, to compute vertical
13680 distance from PT to the scroll margin position. This prevents
13681 try_scrolling from unnecessarily failing when
13682 scroll-conservatively is set to a value slightly larger than the
13683 window height. Clean up the case of PT below the margin at bottom
13684 of window: scroll_max can no longer be INT_MAX. When aggressive
13685 scrolling is in use, don't let point enter the opposite scroll
13686 margin as result of the scroll.
13687 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13688 threshold of 100 lines for never-recentering scrolling.
13689
e4cc2dfc
JB
136902011-03-31 Juanma Barranquero <lekktu@gmail.com>
13691
13692 * dispextern.h (move_it_by_lines):
13693 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13694 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13695 (message_log_check_duplicate): Remove parameters `prev_bol' and
13696 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13697 (redisplay_internal): Remove parameter `preserve_echo_area',
13698 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13699
13700 * indent.c (Fvertical_motion):
13701 * window.c (window_scroll_pixel_based, Frecenter):
13702 Don't pass `need_y_p' to `move_it_by_lines'.
13703
1c470562
SM
137042011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13705
44f230aa
SM
13706 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13707 steal a few bits to be more compact.
13708 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13709 Remove unneeded casts.
13710
1c470562
SM
13711 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13712
888adce9
ZK
137132011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13714
13715 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13716 binding" message (bug#7967).
13717
f838ed7b
PE
137182011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13719
77861b95
PE
13720 Fix more problems found by GCC 4.6.0's static checks.
13721
de6dbc14
PE
13722 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13723 Remove unused local var.
13724
f838ed7b
PE
13725 * editfns.c (Fmessage_box): Remove unused local var.
13726
792c7b2b
PE
13727 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13728 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13729 Omit unused local vars.
c499e557 13730 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13731 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13732 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13733 Omit unused local var.
13734
ba0165e1
PE
13735 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13736 Don't assume string length fits in int.
32ad8845 13737 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13738 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13739
3c59b4c9
PE
13740 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13741 instead of alloca (Bug#8344).
13742
a3eed478 13743 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13744 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13745
eb4d412d
PE
13746 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13747
1658b401
PE
13748 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13749 concerns.
13750
13751 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13752
13753 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13754
9a2c6e05
PE
13755 * keyboard.c (syms_of_keyboard): Use the same style as later
13756 in this function when indexing through an array. This also
13757 works around GCC bug 48267.
13758
03d0a109
PE
13759 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13760
44f730c8
PE
13761 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13762
fe75f926
PE
13763 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13764 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13765
ffa8c828
PE
13766 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13767 This avoids undefined behavior on integer overflow, and is a bit
13768 more convenient anyway since it is compared to a size_t variable.
13769
c5101a77
PE
13770 Variadic C functions now count arguments with size_t, not int.
13771 This avoids an unnecessary limitation on 64-bit machines, which
13772 caused (substring ...) to crash on large vectors (Bug#8344).
13773 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13774 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13775 All variadic functions and their callers changed accordingly.
c5101a77
PE
13776 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13777 * data.c (arith_driver, float_arith_driver): Likewise.
13778 * editfns.c (general_insert_function): Likewise.
13779 * eval.c (struct backtrace.nargs, interactive_p)
13780 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13781 (funcall_lambda, mark_backtrace): Likewise.
13782 * fns.c (concat): Likewise.
13783 * frame.c (x_set_frame_parameters): Likewise.
13784 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13785 0 if not found, not -1. All callers changed.
13786
dd3f25f7
PE
13787 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13788 (stack_copy_size): Now size_t, not int.
13789 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13790
461c2ab9
JB
137912011-03-28 Juanma Barranquero <lekktu@gmail.com>
13792
13793 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13794 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13795 All callers changed.
13796
13797 * lisp.h (multibyte_char_to_unibyte):
13798 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13799 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13800 * character.h (CHAR_TO_BYTE8):
13801 * cmds.c (internal_self_insert):
13802 * editfns.c (general_insert_function):
13803 * keymap.c (push_key_description):
13804 * search.c (Freplace_match):
13805 * xdisp.c (message_dolog, set_message_1): All callers changed.
13806
f6d62986
SM
138072011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13808
13809 * keyboard.c (safe_run_hook_funcall): New function.
13810 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13811 don't set the hook to nil, but remove the offending function instead.
13812 (Qcommand_hook_internal): Remove, unused.
13813 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13814 Vcommand_hook_internal.
13815
13816 * eval.c (enum run_hooks_condition): Remove.
13817 (funcall_nil, funcall_not): New functions.
13818 (run_hook_with_args): Call each function through a `funcall' argument.
13819 Remove `cond' argument, now redundant.
13820 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13821 (Frun_hook_with_args_until_failure): Adjust accordingly.
13822 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13823
1db5b1ad
JB
138242011-03-28 Juanma Barranquero <lekktu@gmail.com>
13825
13826 * dispextern.h (string_buffer_position): Remove declaration.
13827
13828 * print.c (strout): Remove parameter `multibyte', unused since
13829 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13830
13831 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13832 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13833 All callers changed.
13834
13835 * w32.c (_wsa_errlist): Use braces for struct initializers.
13836
13837 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13838 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13839 All callers changed.
13840 (string_buffer_position): Likewise. Also, make static (it's never
13841 used outside xdisp.c).
13842 (cursor_row_p): Remove parameter `w', unused since
13843 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13844 (decode_mode_spec): Remove parameter `precision', introduced during
13845 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13846 All callers changed.
13847
5ffb62aa
JD
138482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13849
13850 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13851
461c2ab9 138522011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13853
13854 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13855 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13856 (ns_update_auto_hide_menu_bar): New functions.
13857 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13858 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13859 ns_constrain_all_frames.
13860 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13861 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13862
5c380ffb
JD
138632011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13864
13865 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13866
9af30bdf
GM
138672011-03-27 Glenn Morris <rgm@gnu.org>
13868
13869 * syssignal.h: Replace RETSIGTYPE with void.
13870 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13871 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13872 Replace SIGTYPE with void everywhere.
13873 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13874 * s/template.h (SIGTYPE): Remove commented out definition.
13875
e2abce01
JB
138762011-03-26 Eli Zaretskii <eliz@gnu.org>
13877
13878 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13879 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13880
f868cd8a
JB
138812011-03-26 Juanma Barranquero <lekktu@gmail.com>
13882
59eb0929
JB
13883 * w32.c (read_unc_volume): Use parameter `henum', instead of
13884 global variable `wget_enum_handle'.
13885
13886 * keymap.c (describe_vector): Remove parameters `indices' and
13887 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13888 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13889
f868cd8a
JB
13890 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13891
13892 * keyboard.c (timer_check): Remove parameter `do_it_now',
13893 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13894 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13895 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13896
13897 * keyboard.c (read_char):
13898 * w32menu.c (w32_menu_display_help):
13899 * xmenu.c (show_help_event, menu_help_callback):
13900 Adjust calls to `show_help_echo'.
13901
13902 * gtkutil.c (xg_maybe_add_timer):
13903 * keyboard.c (readable_events):
13904 * process.c (wait_reading_process_output):
13905 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13906
13907 * insdel.c (adjust_markers_gap_motion):
13908 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13909 (gap_left, gap_right): Don't call it.
13910
2ecf6fdb
CY
139112011-03-25 Chong Yidong <cyd@stupidchicken.com>
13912
13913 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13914 incurred during fontification.
13915
6b1f9ba4
JB
139162011-03-25 Juanma Barranquero <lekktu@gmail.com>
13917
13918 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13919 (DEFVAR_PER_BUFFER): Don't pass it.
13920
13921 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13922 (scrolling_window): Don't pass it.
13923
0f4a96b5
JB
139242011-03-25 Juanma Barranquero <lekktu@gmail.com>
13925
13926 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13927
13928 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13929 and `suffix'.
13930 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13931 of variables specific to SELinux and computation of `encoded_absname'.
13932
13933 * image.c (XPutPixel): Remove unused variable `height'.
13934
13935 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13936
13937 * unexw32.c (get_section_info): Remove unused variable `section'.
13938
13939 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13940 (system_process_attributes): Remove unused variable `sess'.
13941 (sys_read): Remove unused variable `err'.
13942
13943 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13944 (w32_wnd_proc): Remove unused variable `isdead'.
13945 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13946 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13947 (x_create_tip_frame): Remove unused variable `tem'.
13948
13949 * w32inevt.c (w32_console_read_socket):
13950 Remove unused variable `no_events'.
13951
13952 * w32term.c (x_draw_composite_glyph_string_foreground):
13953 Remove unused variable `width'.
13954
1149507c
JB
139552011-03-24 Juanma Barranquero <lekktu@gmail.com>
13956
13957 * w32term.c (x_set_glyph_string_clipping):
13958 Don't pass uninitialized region to CombineRgn.
13959
9c88f339
JB
139602011-03-23 Juanma Barranquero <lekktu@gmail.com>
13961
13962 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13963 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13964 (Fx_close_connection): Remove unused variable `i'.
13965
13966 * w32font.c (w32font_draw): Return number of glyphs.
13967 (w32font_open_internal): Remove unused variable `i'.
13968 (w32font_driver): Add missing initializer.
13969
13970 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13971 (fill_in_menu): Remove unused variable `items_added'.
13972
13973 * w32term.c (last_mouse_press_frame): Remove static global variable.
13974 (w32_clip_to_row): Remove unused variable `f'.
13975 (x_delete_terminal): Remove unused variable `i'.
13976
13977 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13978 (NOTHING): Remove unused static global variable.
13979 (uniscribe_check_otf): Remove unused variable `table'.
13980 (uniscribe_font_driver): Add missing initializers.
13981
dee091a3
JD
139822011-03-23 Julien Danjou <julien@danjou.info>
13983
13984 * term.c (Fsuspend_tty, Fresume_tty):
13985 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13986 * window.c (temp_output_buffer_show):
13987 * insdel.c (signal_before_change):
13988 * frame.c (Fhandle_switch_frame):
13989 * fileio.c (Fdo_auto_save):
13990 * emacs.c (Fkill_emacs):
13991 * editfns.c (save_excursion_restore):
13992 * cmds.c (internal_self_insert):
13993 * callint.c (Fcall_interactively):
13994 * buffer.c (Fkill_all_local_variables):
13995 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13996 Use Frun_hooks.
0f4a96b5 13997 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13998 unconditionally since it does the check itself.
dee091a3 13999
2c520ab5 140002011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14001
c9c49752
PE
14002 Fix more problems found by GCC 4.5.2's static checks.
14003
8abc3f12
PE
14004 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14005 the first time through the loop, since we know p0 < p1 then.
14006 This also avoids a gcc -Wstrict-overflow warning.
14007
a2d26660
PE
14008 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14009 leading to a memory leak, possible in functions like
14010 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14011 of objects (Bug#8318).
a2d26660 14012
916c72e9
PE
14013 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14014 that could (at least in theory) be that large.
14015
19ab8a18
PE
14016 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14017 This is less likely to overflow, and avoids undefined behavior if
14018 overflow does occur. All callers changed. Use strtoul to scan
14019 for the unsigned long integer.
b7cbbd6f
PE
14020 (pint2hrstr): Simplify and tune code slightly.
14021 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14022
f0641eff
PE
14023 * scroll.c (do_scrolling): Work around GCC bug 48228.
14024 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14025
7f650bb9
PE
14026 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14027 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14028 (validate_x_resource_name): Simplify count usage.
14029 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14030
37dd57d1
PE
14031 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14032 fail (Bug#8306).
81e56e61 14033
699979fc 14034 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14035
401bf9b4
PE
14036 * process.c (Fmake_network_process): Use socklen_t, not int,
14037 where POSIX says socklen_t is required in portable programs.
14038 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14039 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14040 (Fmake_network_process, server_accept_connection):
14041 (wait_reading_process_output, read_process_output):
14042 Likewise.
14043
b93aacde
PE
14044 * process.c: Rename or move locals to avoid shadowing.
14045 (list_processes_1, Fmake_network_process):
14046 (read_process_output_error_handler, exec_sentinel_error_handler):
14047 Rename or move locals.
4dc343ee 14048 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14049 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14050 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14051 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14052 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14053
af8a867c 14054 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14055 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14056 Include tparam.h instead, since it declares them.
af8a867c
PE
14057 * cm.h (PC): Remove extern decl; tparam.h now does this.
14058 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14059 * terminfo.c: Include tparam.h, to check interfaces.
14060 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14061 (tparam): Adjust signature to match interface in tparam.h;
14062 this removes some undefined behavior. Check that outstring and len
14063 are zero, which they always are with Emacs.
14064 * tparam.h (PC, BC, UP): New extern decls.
14065
0248044d 14066 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14067 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14068
8ff096c1 14069 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14070 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14071 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14072 (ftfont_list): Remove unused local.
49eaafba
PE
14073 (get_adstyle_property, ftfont_pattern_entity):
14074 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14075 Rename locals to avoid shadowing.
8ff096c1 14076
e2be39f6
PE
14077 * xfont.c (xfont_list_family): Mark var as initialized.
14078
c9735e30
PE
14079 * xml.c (make_dom): Now static.
14080
8f5201ae
PE
14081 * composite.c (composition_compute_stop_pos): Rename local to
14082 avoid shadowing.
b246f932
PE
14083 (composition_reseat_it): Remove unused locals.
14084 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14085 (composition_update_it): Mark var as initialized.
11b61122
PE
14086 (find_automatic_composition): Mark vars as initialized,
14087 with a FIXME (Bug#8290).
8f5201ae 14088
760fbc2c
PE
14089 character.h: Rename locals to avoid shadowing.
14090 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14091 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14092 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14093 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14094 to avoid shadowing.
14095
ff08eb85
PE
14096 * textprop.c (property_change_between_p): Remove; unused.
14097
fc7bf025
PE
14098 * intervals.c (interval_start_pos): Now static.
14099
235d7abc
PE
14100 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14101
44f230aa
SM
14102 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14103 Rename locals to avoid shadowing.
3e7d6594 14104
50060332
PE
14105 * sound.c (wav_play, au_play, Fplay_sound_internal):
14106 Fix pointer signedness.
d01f234b 14107 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14108 (wav_play): Initialize a variable to 0, to prevent undefined
14109 behavior (Bug#8278).
50060332 14110
c4fc4e30
PE
14111 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14112
918436ed
PE
14113 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14114
c939f91b
PE
14115 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14116 clobbering (Bug#8298).
b9c7f648
PE
14117 * sysdep.c (sys_subshell): Likewise.
14118 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14119
6bd8c144
PE
14120 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14121 This should get cleaned up, so that child_setup has the
14122 same signature on all platforms.
14123
7710357c 14124 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14125 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14126
c59da222
CY
141272011-03-22 Chong Yidong <cyd@stupidchicken.com>
14128
14129 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14130 not to be necessary, and produces flickering.
14131
66b87493
GM
141322011-03-20 Glenn Morris <rgm@gnu.org>
14133
14134 * config.in: Remove file.
14135
45b6f6d5
JB
141362011-03-20 Juanma Barranquero <lekktu@gmail.com>
14137
14138 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14139 are now in src/globals.h.
14140 (syms_of_minibuf): Remove spurious & from previous change.
14141
cd394be1 141422011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14143
14144 * minibuf.c (completing-read-function): New variable.
14145 (completing-read-default): Rename from completing-read.
14146 (completing-read): Call completing-read-function.
14147
b14e3e21
CY
141482011-03-19 Juanma Barranquero <lekktu@gmail.com>
14149
14150 * xfaces.c (Fx_load_color_file):
14151 Read color file from absolute filename (bug#8250).
14152
f2b726e6
JB
141532011-03-19 Juanma Barranquero <lekktu@gmail.com>
14154
14155 * makefile.w32-in: Update dependencies.
14156
09f6ff02
EZ
141572011-03-17 Eli Zaretskii <eliz@gnu.org>
14158
14159 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14160
29a6015a
PE
141612011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14162
a3a6c54e
PE
14163 Fix more problems found by GCC 4.5.2's static checks.
14164
b766f867
PE
14165 * process.c (make_serial_process_unwind, send_process_trap):
14166 (sigchld_handler): Now static.
14167
be02381c
PE
14168 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14169 That way, the code declares only the vars that it needs.
14170 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14171 * s/cygwin.h (PTY_ITERATION): Likewise.
14172 * s/darwin.h (PTY_ITERATION): Likewise.
14173 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14174
57048744
PE
14175 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14176 * process.c (allocate_pty): Don't declare stb unless it's needed.
14177
7914961c 14178 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14179 (CONSTANTLIM): Remove; unused.
14180 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14181 Define only if needed.
7914961c 14182
b3967b18
PE
14183 * unexelf.c (unexec): Name an expression,
14184 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14185 Use a different way to cause a compilation error if anyone uses
14186 n rather than nn, a way that does not involve shadowing.
73366a00 14187 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14188
29a6015a
PE
14189 * deps.mk (unexalpha.o): Remove; unused.
14190
43cfc33e 14191 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14192 * unexec.h: New file.
ce701a33
PE
14193 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14194 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14195 Depend on unexec.h.
14196 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14197 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14198 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14199 Change as necessary to match prototype in unexec.h.
ce701a33 14200
01f44d5a
PE
14201 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14202 shadowing.
4f63c6bb 14203 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14204
a6670b0b
PE
14205 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14206 Rename locals to avoid shadowing.
14207
cef2010d 14208 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14209 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14210
d4d7173a
PE
14211 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14212
f08b802a
PE
14213 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14214 warning when compiling print.c.
14215
3ddb0639
PE
14216 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14217 instead of using an uninitialized var.
5ad03b97 14218 (font_sort_entities): Mark var as initialized.
3ddb0639 14219
170a2692
PE
14220 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14221
e663c700
PE
14222 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14223 pointers to constants.
89bc529a 14224 (font_parse_fcname): Remove unused vars.
7b81e2d0 14225 (font_delete_unmatched): Now static.
ea838e10 14226 (font_get_spec): Remove; unused.
13a547c6
PE
14227 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14228 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14229 Rename or move locals to avoid shadowing.
e663c700 14230
2a80c887 14231 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14232 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14233
1384fa33 14234 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14235 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14236
8b2c52e9
PE
14237 * alloc.c (mark_backtrace): Move decl from here ...
14238 * lisp.h: ... to here, so that it can be checked.
14239
475545b5 14240 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14241 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14242 (lisp_indirect_variable): Name an expression,
14243 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14244 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14245
b1349114 14246 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14247 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14248 Use const pointer when appropriate.
b1349114 14249
a2928364
PE
14250 * lisp.h (get_system_name, get_operating_system_release):
14251 Move decls here, to check interfaces.
14252 * process.c (get_operating_system_release): Move decl to lisp.h.
14253 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14254 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14255 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14256 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14257 (Fformat_time_string, Fencode_time, Finsert_char):
14258 (Ftranslate_region_internal, Fformat):
14259 Rename or remove local vars to avoid shadowing.
9710023e 14260 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14261
a415e694
PE
14262 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14263 avoid shadowing.
14264
8ef4622d
PE
14265 * lisp.h (eassert): Check that the argument compiles, even if
14266 ENABLE_CHECKING is not defined.
14267
946f9a5b
PE
14268 * data.c (Findirect_variable): Name an expression, to avoid
14269 gcc -Wbad-function-cast warning.
112396d6 14270 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14271 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14272 (Fmake_variable_buffer_local, Fmake_local_variable):
14273 Mark variables as initialized.
52746918 14274 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14275
e5aab7e7 14276 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14277 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14278 Rename locals to avoid shadowing.
dff45157
PE
14279 (mark_stack): Move local variables into the #ifdef region where
14280 they're used.
7bc26fdb
PE
14281 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14282 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14283 needed otherwise.
14284 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14285 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14286 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14287
e5aab7e7
PE
14288 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14289 avoids undefined behavior in theory.
14290
4da60324
PE
14291 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14292
88043301
PE
14293 Use functions, not macros, for up- and down-casing (Bug#8254).
14294 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14295 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14296 to use the following functions instead of these macros.
14297 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14298 EMACS_INT, since callers assume the returned value fits in int.
14299 (upcase1): Likewise, for UPCASE_TABLE.
14300 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14301 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14302 the race-condition problem in the old DOWNCASE.
88043301 14303
19ed5445
PE
14304 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14305 Rename locals to avoid shadowing.
14306 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14307 (regex_compile, re_search_2, re_match_2_internal):
14308 Remove unused local vars.
952db0d7
PE
14309 (FREE_VAR): Rewrite so as not to use empty "else",
14310 which gcc can warn about.
da053e48 14311 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14312 (RETALLOC_IF): Define only if needed.
14313 (WORDCHAR_P): Likewise. This one is never needed, but is used
14314 only in a comment talking about a compiler bug, so put inside
14315 the #if 0 of that comment.
14316 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14317 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14318 Remove; unused.
19ed5445 14319
1f3561e4 14320 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14321 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14322 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14323
ded6f8f7
PE
14324 * search.c (simple_search): Remove unused var.
14325
dbd37a95
PE
14326 * dired.c (compile_pattern): Move decl from here ...
14327 * lisp.h: ... to here, so that it can be checked.
14328 (struct re_registers): New forward decl.
14329
7e47afad
PE
14330 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14331
85f24f61
PE
14332 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14333 All uses changed.
14334 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14335 Rename locals to avoid shadowing.
5671df8f 14336 (Fvertical_motion): Mark locals as initialized.
85f24f61 14337
181aa2be 14338 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14339 (casify_region): Mark local as initialized.
181aa2be 14340
930d429c
PE
14341 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14342
7082eac6
PE
14343 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14344 New macros, so that the caller can use some names other than
14345 gcpro1, gcpro2, etc.
14346 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14347 of the new macros.
14348 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14349 argument, for consistency with GCPRO2_VAR, etc: it is now the
14350 prefix of the variable, not the variable itself. All uses
14351 changed.
38b2c076
PE
14352 * dired.c (directory_files_internal, file_name_completion):
14353 Rename locals to avoid shadowing.
14354
15206ed9
PE
14355 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14356 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14357 dired.c's scmp function, had undefined behavior.
14358 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14359 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14360 * buffer.h: ... to here, because these macros use current_buffer,
14361 and the new implementation with inline functions needs to have
14362 current_buffer in scope now, rather than later when the macros
14363 are used.
14364 (downcase, upcase1): New static inline functions.
14365 (DOWNCASE, UPCASE1): Reimplement using these functions.
14366 This avoids undefined behavior in expressions like
14367 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14368 from race conditions in accessing the global variables
14369 case_temp1 and case_temp2.
14370 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14371 * lisp.h (case_temp1, case_temp2): Remove their decls.
14372 * character.h (ASCII_CHAR_P): Move from here ...
14373 * lisp.h: ... to here, so that the inline functions mentioned
14374 above can use them.
14375
4a6bea26
PE
14376 * dired.c (directory_files_internal_unwind): Now static.
14377
f14b7e14
PE
14378 * fileio.c (file_name_as_directory, directory_file_name):
14379 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14380 Now static.
2893f146
PE
14381 (file_name_as_directory): Use const pointers when appropriate.
14382 (Fexpand_file_name): Likewise. In particular, newdir might
14383 point at constant storage, so make it a const pointer.
fd4ead52 14384 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14385 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14386 signedness issues.
f839df0c
PE
14387 (Fset_file_times, Finsert_file_contents, auto_save_error):
14388 Rename locals to avoid shadowing.
f14b7e14 14389
5716756e 14390 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14391 (Ftry_completion, Fall_completions): Rename or remove locals
14392 to avoid shadowing.
5716756e 14393
b4c3046a
PE
14394 * marker.c (bytepos_to_charpos): Remove; unused.
14395
b45db522
PE
14396 * lisp.h (verify_bytepos, count_markers): New decls,
14397 so that gcc does not warn that these functions aren't declared.
14398
85876d07
PE
14399 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14400 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14401 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14402 (copy_text): Remove unused local var.
85876d07 14403
03d78a21 14404 * filelock.c (within_one_second): Now static.
b3dd38ab 14405 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14406
5df8f01b
PE
14407 * buffer.c (fix_overlays_before): Mark locals as initialized.
14408 (fix_start_end_in_overlays): Likewise. This function should be
14409 simplified by using pointers-to-pointers, but that's a different
14410 matter.
b1d876f1 14411 (switch_to_buffer_1): Now static.
8f54f30a
PE
14412 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14413 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14414
a70072c9 14415 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14416 Fix pointer signedness issue.
edced198
PE
14417 (sys_subshell): Mark local as volatile if checking for lint,
14418 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14419 (MAXPATHLEN): Define only if needed.
a70072c9 14420
a0977c44
PE
14421 * process.c (serial_open, serial_configure): Move decls from here ...
14422 * systty.h: ... to here, so that they can be checked.
14423
a884fdcc
PE
14424 * fns.c (get_random, seed_random): Move extern decls from here ...
14425 * lisp.h: ... to here, so that they can be checked.
14426
604efe86 14427 * sysdep.c (reset_io): Now static.
b8950c94 14428 (wait_for_termination_signal): Remove; unused.
604efe86 14429
38fc62d9
PE
14430 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14431 (copy_keymap_item, append_key, push_text_char_description):
14432 Now static.
1004a21a 14433 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14434 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14435 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14436 (describe_map_tree):
14437 Rename locals to avoid shadowing.
38fc62d9 14438
2f2650da
PE
14439 * keyboard.c: Declare functions static if they are not used elsewhere.
14440 (echo_char, echo_dash, cmd_error, top_level_2):
14441 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14442 (read_char, kbd_buffer_get_event, make_lispy_position):
14443 (make_lispy_event, make_lispy_movement, apply_modifiers):
14444 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14445 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14446 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14447 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14448 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14449
a053e86c 14450 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14451 (mark_kboards): Move decl here ...
14452 * alloc.c (mark_kboards): ... from here.
a053e86c 14453
4752793e
PE
14454 * lisp.h (force_auto_save_soon): New decl.
14455
74f10ca7 14456 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14457 (DEFINE_DUMMY_FUNCTION): New macro.
14458 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14459 Use it.
c03cd23f
PE
14460 (main): Add casts to avoid warnings
14461 if GCC considers string literals to be constants.
74f10ca7 14462
022e70d4
PE
14463 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14464
59d6fe83
PE
14465 * dbusbind.c: Pointer signedness fixes.
14466 (xd_signature, xd_append_arg, xd_initialize):
14467 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14468 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14469 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14470 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14471
78320123
PE
14472 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14473 if GCC considers string literals to be constants.
49cebcca 14474 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14475
35ac2a97
SM
144762011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14477
fb103ca9
SM
14478 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14479 (print_preprocess, print_object): New macro to fix last change.
14480
35ac2a97
SM
14481 * print.c (print_preprocess): Don't forget font objects.
14482
62973b41
JB
144832011-03-16 Juanma Barranquero <lekktu@gmail.com>
14484
14485 * emacs.c (USAGE3): Doc fixes.
14486
0e48bb22
AS
144872011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14488
14489 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14490 structure.
14491
7684e57b
JB
144922011-03-14 Juanma Barranquero <lekktu@gmail.com>
14493
14494 * lisp.h (VWindow_system, Qfile_name_history):
14495 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14496 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14497 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14498
14499 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14500 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14501
14502 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14503 * w32console.c (detect_input_pending, read_input_pending)
14504 (encode_terminal_code):
14505 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14506 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14507 (w32_system_caret_y, Qfile_name_history):
14508 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14509 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14510 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14511 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14512 * w32proc.c (Qlocal, report_file_error):
14513 * w32term.c (Vwindow_system, updating_frame):
14514 * w32uniscribe.c (initialized, uniscribe_font_driver):
14515 Remove unneeded extern declarations.
14516
2aa46d6c
CY
145172011-03-14 Chong Yidong <cyd@stupidchicken.com>
14518
c96bbc66 14519 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14520
cffc6f3b
CY
145212011-03-13 Chong Yidong <cyd@stupidchicken.com>
14522
14523 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14524 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14525 These macros can no longer be used for assignment.
14526
44f230aa
SM
14527 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14528 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14529 (record_buffer_markers, fetch_buffer_markers): New functions for
14530 recording and fetching special buffer markers.
14531 (set_buffer_internal_1, set_buffer_temp): Use them.
14532
14533 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14534
14535 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14536
14537 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14538 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14539
14540 * xdisp.c (hscroll_window_tree):
14541 (reconsider_clip_changes): Use PT instead of BUF_PT.
14542
d251f04b
EZ
145432011-03-13 Eli Zaretskii <eliz@gnu.org>
14544
14545 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14546 $(EMACS_ROOT)/lib/intprops.h.
14547
f0c77cd1
PE
145482011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14549
3eca4629
PE
14550 Fix more problems found by GCC 4.5.2's static checks.
14551
7c86ee98
PE
14552 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14553 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14554 (xg_free_frame_widgets): Make it clear that a local variable is
14555 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14556 (gdk_window_get_screen): Make it clear that this macro is needed
14557 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14558 (int_gtk_range_get_value): New function, which avoids a diagnostic
14559 from gcc -Wbad-function-cast.
14560 (xg_set_toolkit_scroll_bar_thumb): Use it.
14561 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14562 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14563 (get_utf8_string, xg_get_file_with_chooser):
14564 Rename locals to avoid shadowing.
14565 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14566
41729b81
PE
14567 * xgselect.c (xg_select): Remove unused var.
14568
f0c77cd1
PE
14569 * image.c (four_corners_best): Mark locals as initialized.
14570 (gif_load): Initialize transparent_p to zero (Bug#8238).
14571 Mark another local as initialized.
ec6cf4c6 14572 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14573
ce0ad53d 14574 * image.c (clear_image_cache): Now static.
d5d5a617 14575 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14576 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14577 (x_edge_detection): Remove unnecessary cast that
14578 gcc -Wbad-function-cast diagnoses.
2037898d 14579 (gif_load): Fix pointer signedness.
6ae141d6
PE
14580 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14581 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14582
33383987 145832011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14584
d32df629
PE
14585 Improve quality of tests for time stamp overflow.
14586 For example, without this patch (encode-time 0 0 0 1 1
14587 1152921504606846976) returns the obviously-bogus value (-948597
14588 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14589 reports time overflow. See
14590 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14591 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14592 * editfns.c: Include limits.h and intprops.h.
14593 (TIME_T_MIN, TIME_T_MAX): New macros.
14594 (time_overflow): Move earlier, to before first use.
14595 (hi_time, lo_time): New functions, for an accurate test for
14596 out-of-range times.
14597 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14598 (Fget_internal_run_time): Don't assume time_t fits in int.
14599 (make_time): Use list2 instead of Fcons twice.
14600 (Fdecode_time): More accurate test for out-of-range times.
14601 (check_tm_member): New function.
14602 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14603 (lisp_time_argument): Don't rely on undefined left-shift and
14604 right-shift behavior when checking for time stamp overflow.
8be6f318 14605
fe31d94c
PE
14606 * editfns.c (time_overflow): New function, refactoring common code.
14607 (Fformat_time_string, Fdecode_time, Fencode_time):
14608 (Fcurrent_time_string): Use it.
14609
8be6f318
PE
14610 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14611 * dired.c (make_time): Move to ...
14612 * editfns.c (make_time): ... here.
14613 * systime.h: Note the move.
14614
09d9db2c 146152011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14616
126bc0dc
YM
14617 * fringe.c (update_window_fringes): Remove unused variables.
14618
c47cbdfd
YM
14619 * unexmacosx.c (copy_data_segment): Also copy __got section.
14620 (Bug#8223)
14621
7ac80be9
EZ
146222011-03-12 Eli Zaretskii <eliz@gnu.org>
14623
c96bbc66 14624 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14625 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14626 Constify `char *' arguments and their references according to
14627 prototypes in tparam.h.
14628
ecb0f94d 14629 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14630
7ac80be9
EZ
14631 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14632 Adapt all references accordingly.
14633
14634 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14635
ef1fd07e
TT
146362011-03-11 Tom Tromey <tromey@redhat.com>
14637
14638 * buffer.c (syms_of_buffer): Remove obsolete comment.
14639
7ef4b50c
EZ
146402011-03-11 Eli Zaretskii <eliz@gnu.org>
14641
14642 * termhooks.h (encode_terminal_code): Declare prototype.
14643
14644 * msdos.c (encode_terminal_code): Don't declare prototype.
14645
14646 * term.c (encode_terminal_code): Now external again, used by
14647 w32console.c and msdos.c.
14648
44f230aa
SM
14649 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14650 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14651
4b1ec863 146522011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14653
1714f52b 14654 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14655
4b1ec863
PE
14656 * fringe.c (update_window_fringes): Mark locals as initialized
14657 (Bug#8227).
14658 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14659
524c7aa6
PE
14660 * alloc.c (mark_fringe_data): Move decl from here ...
14661 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14662 to check its interface.
14663 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14664
a5c0af81 14665 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14666 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14667 (fontset_font): Mark local as initialized.
a9a06e0b 14668 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14669
b4716021
PE
14670 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14671
811e9bac 14672 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14673 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14674 (x_own_selection, Fx_disown_selection_internal): Rename locals
14675 to avoid shadowing.
14676 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14677
7e3ab302
PE
14678 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14679 so that the caller can use some name other than gcpro1.
14680 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14681 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14682 (Fx_backspace_delete_keys_p):
14683 Use them to avoid shadowing, and rename vars to avoid shadowing.
14684 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14685 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14686 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14687 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14688 Remove unused locals.
7e3ab302
PE
14689 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14690 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14691 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14692 macros.
f78faa98 14693
e2b13473
PE
14694 * xterm.h (x_mouse_leave): New decl.
14695
77f23912
PE
14696 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14697 Remove unused functions.
cdf4ba58
PE
14698 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14699 (x_calc_absolute_position): Now static.
7411c686 14700 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14701 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14702 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14703 unless they are used.
38d0b34a
PE
14704 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14705 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14706 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14707 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14708 (x_error_catcher, x_connection_closed, x_error_handler):
14709 (x_error_quitter, xembed_send_message, x_iconify_frame):
14710 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14711 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14712 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14713
44f230aa
SM
14714 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14715 Rename or move locals to avoid shadowing.
6b463e58 14716 (tty_defined_color, merge_face_heights): Now static.
5967d051 14717 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14718 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14719 does not deduce is never used uninitialized.
73719eba
PE
14720 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14721 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14722
426994c3 14723 * terminal.c (store_terminal_param): Now static.
5489860b 14724
032f1620 14725 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14726 (set_frame_menubar): Remove unused local.
d4323972 14727 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14728 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14729 since they might point to immutable storage.
281585b0
PE
14730 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14731 since it's unused otherwise.
032f1620 14732
367c19e5 14733 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14734 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14735 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14736 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14737 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14738 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14739 does not deduce are never used uninitialized.
70739cbe 14740
07b48fa9
PE
14741 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14742
8868a238 14743 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14744 * window.c (window_loop, size_window):
14745 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14746
7e5cf297 14747 * window.c (display_buffer): Now static.
d6550a9f
PE
14748 (size_window): Mark variables that gcc -Wuninitialized
14749 does not deduce are never used uninitialized.
a586633d
PE
14750 * window.h (check_all_windows): New decl, to forestall
14751 gcc -Wmissing-prototypes diagnostic.
5b555da1 14752 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14753
f6095868
PE
14754 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14755 shadowing.
14756 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14757 Include <limits.h>.
14758 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14759 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14760 (load_charset_map): Mark variables that gcc -Wuninitialized
14761 does not deduce are never used uninitialized.
53df7c11 14762 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14763
f38b440c
PE
14764 * coding.c (coding_set_source, coding_set_destination):
14765 Use "else { /* comment */ }" rather than "else /* comment */;"
14766 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14767 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14768 a block, when the outer 'i' will do.
14769 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14770 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14771 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14772 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14773 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14774 Rename locals to avoid shadowing.
14775 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14776 * coding.c (emacs_mule_char, encode_invocation_designation):
14777 Now static, since they're not used elsewhere.
413bb2db 14778 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14779 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14780 (decode_coding_emacs_mule): Mark variables that gcc
14781 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14782 (detect_coding_iso_2022): Initialize a local variable that might
14783 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14784 this initialization is needed. (Bug#8211)
5f58e762
PE
14785 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14786 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14787 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14788 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14789 Remove unused macros.
f38b440c 14790
232b38b9 14791 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14792 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14793 * character.c (string_count_byte8): Likewise.
232b38b9 14794
fb90da1b
PE
14795 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14796 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14797
fb93dbc2
PE
14798 * chartab.c (copy_sub_char_table): Now static, since it's not used
14799 elsewhere.
5c156ace
PE
14800 (sub_char_table_ref_and_range, char_table_ref_and_range):
14801 Rename locals to avoid shadowing.
bbcd0949 14802 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14803
7d3b3862 14804 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14805 (BIDI_BOB): Remove unused macro.
7d3b3862 14806
6be7d3da
PE
14807 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14808 deduce are never used uninitialized.
c2ed9c8b 14809 * term.c (encode_terminal_code): Likewise.
6be7d3da 14810
75f8807f 14811 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14812
50938595
PE
14813 * tparam.h: New file.
14814 * term.c, tparam.h: Include it.
14815 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14816 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14817 Move these decls to tparam.h, and make them agree with what
14818 is actually in tparam.c. The previous trick of using incompatible
14819 decls in different modules does not conform to the C standard.
14820 All callers of tparam changed to use tparam's actual API.
14821 * tparam.c (tparam1, tparam, tgoto):
14822 Use const pointers where appropriate.
14823
fbceeba2
PE
14824 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14825 * cm.h (struct cm): Likewise.
14826 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14827 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14828 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14829 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14830 (turn_on_face, init_tty): Likewise.
14831 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14832
7f3f1250
PE
14833 * term.c (term_mouse_position): Rename local to avoid shadowing.
14834
e6ca6543
PE
14835 * alloc.c (mark_ttys): Move decl from here ...
14836 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14837
c40f8d15
AS
148382011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14839
14840 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14841
cfe0661d
JB
148422011-03-09 Juanma Barranquero <lekktu@gmail.com>
14843
14844 * search.c (compile_pattern_1): Remove argument regp, unused since
14845 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14846 (compile_pattern): Don't pass it.
14847
0afb4571
J
148482011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14849
14850 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14851 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14852 for ! HAVE_GTK3.
14853 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14854
14855 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14856
14857 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14858 gdk_window_get_screen, gdk_window_get_geometry,
14859 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14860 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14861 (xg_get_pixbuf_from_pixmap): New function.
14862 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14863 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14864 Call xg_get_pixbuf_from_pixmap instead of
14865 gdk_pixbuf_get_from_drawable.
14866 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14867 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14868 (xg_check_special_colors): Use GtkStyleContext and its functions
14869 for HAVE_GTK3.
14870 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14871 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14872 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14873 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14874 Call gtk_widget_get_preferred_size.
0afb4571
J
14875 (xg_frame_resized): gdk_window_get_geometry only takes 5
14876 parameters.
44f230aa
SM
14877 (xg_win_to_widget, xg_event_is_for_menubar):
14878 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14879 (xg_set_widget_bg): New function.
14880 (delete_cb): New function.
895009e1 14881 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14882 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14883 (xg_set_background_color): Call xg_set_widget_bg.
14884 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14885 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14886 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14887 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14888 if ! HAVE_GTK3.
14889 (update_frame_tool_bar): Call gtk_widget_hide.
14890 (xg_initialize): Use GDK_KEY_g.
14891
14892 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14893 if ! HAVE_GTK3
14894 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14895
14896 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14897 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14898 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14899
1c2cc4ef
JB
149002011-03-08 Juanma Barranquero <lekktu@gmail.com>
14901
14902 * w32xfns.c (select_palette): Check success of RealizePalette against
14903 GDI_ERROR, not zero.
14904
33383987 14905See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14906
14907;; Local Variables:
14908;; coding: utf-8
aac0c6e3
MR
14909;; End:
14910
2f097256 14911 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14912
14913 This file is part of GNU Emacs.
14914
14915 GNU Emacs is free software: you can redistribute it and/or modify
14916 it under the terms of the GNU General Public License as published by
14917 the Free Software Foundation, either version 3 of the License, or
14918 (at your option) any later version.
14919
14920 GNU Emacs is distributed in the hope that it will be useful,
14921 but WITHOUT ANY WARRANTY; without even the implied warranty of
14922 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14923 GNU General Public License for more details.
14924
14925 You should have received a copy of the GNU General Public License
14926 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.