Spelling fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f8fe6f96
EZ
12011-11-19 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6 behave as if the cursor position were at the window margin.
7
8 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
9 and the cursor position is out of bounds, behave as if the cursor
10 position were at the window margin. (Bug#10075)
11
df05a53c
CY
122011-11-18 Chong Yidong <cyd@gnu.org>
13
14 * window.c (Fwindow_combination_limit): Make first argument
15 non-optional, since it is meaningless for live windows like the
16 selected window.
17
2071918e
DA
182011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
19
20 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
21
b50a28de
SM
222011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
23
24 * intervals.c: Fix grafting over the whole buffer (bug#10071).
25 (graft_intervals_into_buffer): Simplify.
26
015137db
EZ
272011-11-18 Eli Zaretskii <eliz@gnu.org>
28
29 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
30 hash values of the two rows.
31 (copy_row_except_pointers): Preserve the used[] arrays and the
32 hash values of the two rows. (Bug#10035)
68c95424 33 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
34
35 * xdisp.c (row_hash): New function, body extracted from
36 compute_line_metrics.
37 (compute_line_metrics): Call row_hash, instead of computing the
38 hash code inline.
39
40 * dispnew.c (verify_row_hash): Call row_hash for computing the
41 hash code of a row, instead of duplicating code from xdisp.c.
42
43 * dispextern.h (row_hash): Add prototype.
44
a2addb04
TH
452011-11-18 Tassilo Horn <tassilo@member.fsf.org>
46
47 * frame.c (delete_frame): Don't delete the terminal when the last
48 X frame is closed if emacs is built with GTK toolkit.
49
df85d315
JB
502011-11-17 Juanma Barranquero <lekktu@gmail.com>
51
52 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
53
a0c2d0ae
MR
542011-11-17 Martin Rudalics <rudalics@gmx.at>
55
56 * window.c (Vwindow_splits): Rename to
57 Vwindow_combination_resize. Suggested by Juri Linkov.
58 (Fsplit_window_internal): Use Vwindow_combination_resize instead
59 of Vwindow_splits.
60
58179cce
JB
612011-11-16 Juanma Barranquero <lekktu@gmail.com>
62
7877f373
JB
63 * nsfns.m (Fns_font_name):
64 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 65
b6f67890
MR
662011-11-16 Martin Rudalics <rudalics@gmx.at>
67
68 * window.h (window): Rename slot "nest" to "combination_limit".
69 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
70 (Fset_window_nest): Rename to Fset_window_combination_limit.
71 (Vwindow_nest): Rename to Vwindow_combination_limit.
72 (recombine_windows, make_parent_window, make_window)
73 (Fsplit_window_internal, saved_window)
74 (Fset_window_configuration, save_window_save): Rename all
75 occurrences of window_nest to window_combination_limit.
76
c7015153
JB
772011-11-15 Juanma Barranquero <lekktu@gmail.com>
78
79 * image.c (imagemagick_load_image): Fix typo.
80
322ad6ec
EZ
812011-11-14 Eli Zaretskii <eliz@gnu.org>
82
83 * xdisp.c (display_line): Move the call to
84 highlight_trailing_whitespace before the call to
85 compute_line_metrics, since the latter needs to see the final
86 faces of all the glyphs to compute ROW's hash value. Fixes
87 assertion violations in row_equal_p. (Bug#10035)
88
f067b8ec
JB
892011-11-14 Juanma Barranquero <lekktu@gmail.com>
90
91 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
92 just return (bug#10044).
93
1e5b2111
EZ
942011-11-12 Eli Zaretskii <eliz@gnu.org>
95
7ef3cbd5
EZ
96 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
97 with user-defined heap size. Bump the default size of the temacs
98 heap to 27MB, to avoid memory warning when running temacs.
99 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
100
1e5b2111
EZ
101 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
102 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
103 (verify_row_hash) [XASSERTS]: New function.
104 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
105 that the hash value of glyph rows is correct.
1e5b2111 106
89d61221
MR
1072011-11-12 Martin Rudalics <rudalics@gmx.at>
108
109 * window.h (window): Remove splits slot.
110 * window.c (Fwindow_splits, Fset_window_splits): Remove.
111 (Fdelete_other_windows_internal, make_parent_window)
112 (make_window, Fsplit_window_internal, Fdelete_window_internal)
113 (Fset_window_configuration, save_window_save): Don't deal with
114 split status of windows.
115 (saved_window): Remove splits slot.
116 (Vwindow_splits): Rewrite doc-string.
117
97f18cc8
JD
1182011-11-11 Jan Djärv <jan.h.d@swipnet.se>
119
120 * xfns.c (unwind_create_frame):
121 * nsfns.m (unwind_create_frame):
122 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
123 Vframe_list (Bug#9999).
124
22a648b4
DA
1252011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
126
0b381c7e 127 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 128
659afede
KH
1292011-11-11 Kenichi Handa <handa@m17n.org>
130
131 * callproc.c (Fcall_process): Set the member dst_multibyte of
132 process_coding.
133
9ac0394b
KH
1342011-11-11 Johan Bockgård <bojohan@gnu.org>
135
136 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
137 avoid a crash (bug#9496).
138
2fbdc249
CY
1392011-11-09 Chong Yidong <cyd@gnu.org>
140
141 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
142 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
143
ac6b1f81
PE
1442011-11-08 Paul Eggert <eggert@cs.ucla.edu>
145
146 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
147
09db192c
PE
1482011-11-08 Paul Eggert <eggert@cs.ucla.edu>
149
150 Avoid some portability problems by eschewing 'extern inline' functions.
151 The trivial performance wins aren't worth the portability hassles; see
152 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
153 et seq.
154 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
155 (window_box_width, window_box_left, window_box_left_offset)
156 (window_box_right, window_box_right_offset): Undo previous change,
157 by removing the "extern"s.
158 * intervals.c (adjust_intervals_for_insertion)
159 (adjust_intervals_for_deletion): Undo previous change,
160 making these static again.
161 (offset_intervals, temp_set_point_both, temp_set_point)
162 (copy_intervals_to_string): No longer inline.
163 * xdisp.c (window_text_bottom_y, window_box_width)
164 (window_box_height, window_box_left_offset)
165 (window_box_right_offset, window_box_left, window_box_right)
166 (window_box): No longer inline.
167
105216ed
CY
1682011-11-08 Chong Yidong <cyd@gnu.org>
169
170 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
171 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
172 an error if not a live window.
173 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
174 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
175
ae9e237f
JB
1762011-11-07 Juanma Barranquero <lekktu@gmail.com>
177
178 * lisp.h (syms_of_abbrev): Remove declaration.
179 Reported by CHENG Gao <chenggao@royau.me>.
180
c7aa8333
EZ
1812011-11-07 Eli Zaretskii <eliz@gnu.org>
182
183 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
184 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
185 of temacs in GUI mode.
186
be7f5545
MR
1872011-11-07 Martin Rudalics <rudalics@gmx.at>
188
189 * window.h: Declare delete_all_child_windows instead of
190 delete_all_subwindows.
191 * window.c (Fwindow_nest, Fset_window_nest)
192 (Fset_window_new_total, Fset_window_new_normal)
193 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
194 (delete_all_subwindows): Rename to delete_all_child_windows.
195 (Fdelete_other_windows_internal, Fset_window_configuration):
196 Call delete_all_child_windows instead of delete_all_subwindows.
197 * frame.c (delete_frame): Call delete_all_child_windows instead
198 of delete_all_subwindows.
199
ca78dc43
PE
2002011-11-07 Paul Eggert <eggert@cs.ucla.edu>
201
202 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
203 This is also needed for porting to any host where GC_MARK_STACK is
204 not GC_MAKE_GCPROS_NOOPS.
205 (which_symbols): Use it.
206
a0241d01
KH
2072011-11-07 Kenichi Handa <handa@m17n.org>
208
209 * coding.c (coding_set_destination): Check coding->src_pos only
210 when coding->src_object is a buffer (bug#9910).
211
212 * process.c (send_process): Set the member src_multibyte of coding
213 to 0 (bug#9911) when sending a unibyte text.
214
215 * callproc.c (Fcall_process): Set the member src_multibyte of
216 process_coding to 0 (bug#9912).
217
a64bfdfa 2182011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
219
220 * xmenu.c (cleanup_widget_value_tree): New function.
221 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
222 calling free_menubar_widget_value_tree directly (Bug#9830).
223
cb41b32a
PE
2242011-11-06 Paul Eggert <eggert@cs.ucla.edu>
225
226 Fix some portability problems with 'inline'.
227 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
228 (window_box_width, window_box_left, window_box_left_offset)
229 (window_box_right, window_box_right_offset): Declare extern.
230 Otherwise, these inline functions do not conform to C99 and
231 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
232 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
233 * intervals.c (adjust_intervals_for_insertion)
234 (adjust_intervals_for_deletion): Now extern, because otherwise the
235 extern inline functions 'offset_intervals' couldn't refer to it.
236 (static_offset_intervals): Remove.
237 (offset_intervals): Rewrite using the old contents of
238 static_offset_intervals. The old version didn't conform to C99
239 because an extern inline function contained a reference to an
240 identifier with static linkage.
241
b7041366
AS
2422011-11-06 Andreas Schwab <schwab@linux-m68k.org>
243
244 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
245 GC.
246
88a37c4d
EZ
2472011-11-06 Eli Zaretskii <eliz@gnu.org>
248
249 * xdisp.c (init_iterator, reseat_to_string): Don't set the
250 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
251 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
252 return Qleft_to_right.
253
49745b39
CY
2542011-11-06 Chong Yidong <cyd@gnu.org>
255
256 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
257 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
258 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
259 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
260 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
261 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
262 (Fwindow_vscroll): Doc fix.
263 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
264 argument, since it makes no sense to pass a live window and for
265 consistency with window-child.
266
1f05cd82
CS
2672011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
268
269 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
270 support MSVC.
271
22610910
JR
2722011-11-05 Jason Rumney <jasonr@gnu.org>
273
274 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
275 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
276 fonts (Bug#6029).
277 (add_font_entity_to_list): Fix logic errors in mixed boolean and
278 bitwise arithmetic preventing use of unicode-sip and non-truetype
279 opentype fonts.
280
a06776b2
EZ
2812011-11-05 Eli Zaretskii <eliz@gnu.org>
282
3ad924ba
EZ
283 * s/ms-w32.h (fstat, stat, utime): Move redirections to
284 "emacs"-only part.
285
a06776b2
EZ
286 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
287 initialization code to keep similarity to xfns.c after changes
288 from 2011-11-05.
289
c9e7db78
JD
2902011-11-05 Jan Djärv <jan.h.d@swipnet.se>
291
a97f8f3f
JD
292 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
293 (unwind_create_frame): New function (Bug#9943).
294 (Fx_create_frame): Restructure code to be more similar to the one in
295 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
296 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
297 Move terminal->reference_count++ just before making the frame official
298 (Bug#9943).
299
300 * nsterm.m (x_free_frame_resources): New function.
301 (x_destroy_window): Move code to x_free_frame_resources.
302
c9e7db78
JD
303 * xfns.c (unwind_create_frame): Fix comment.
304 (Fx_create_frame, x_create_tip_frame): Move
305 terminal->reference_count++ just before making the frame
306 official. Move initialization of image_cache_refcount and
307 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
308
a6fc3b5c
EZ
3092011-11-05 Eli Zaretskii <eliz@gnu.org>
310
311 Support MSVC build with newer versions of Visual Studio.
312 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
313 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
314 nt/gmake.defs.
315
316 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
317 which are not supported by MSVC.
318 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
319 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
320 bitfields.
321 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
322 types in bitfields.
323 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
324
325 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
326
58179cce 3272011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
328
329 Support MSVC build with newer versions of Visual Studio.
330 * w32.c: Don't include w32api.h for MSVC.
331 (init_environment) [_MSC_VER]: Call sys_access, not _access.
332
333 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
334 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
335 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
336 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
337 e_* cousins.
338 (alloca) [_MSC_VER]: Define to _alloca.
339
340 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
341
342 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
343
a58c13ed
EZ
3442011-11-04 Eli Zaretskii <eliz@gnu.org>
345
346 * xdisp.c (note_mouse_highlight): If either of
347 previous/next-single-property-change returns nil, treat that as
348 the beginning or the end of the buffer. (Bug#9955)
349
fe0b6370
JD
3502011-11-04 Jan Djärv <jan.h.d@swipnet.se>
351
a58c13ed 352 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
353 label is not null (Bug#9951).
354 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
355 may be NULL.
356
89bd5ee1
EZ
3572011-11-04 Eli Zaretskii <eliz@gnu.org>
358
359 * window.c (Fwindow_body_size): Mention in the doc string that the
360 return value is in frame's canonical units. (Bug#9949)
361
84c3edb9
EZ
3622011-11-03 Eli Zaretskii <eliz@gnu.org>
363
4e2fb5c7
EZ
364 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
365
84c3edb9 366 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 367 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 368 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 369
bc17a887
EZ
3702011-11-01 Eli Zaretskii <eliz@gnu.org>
371
372 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
373 Don't stop backward scan on the continuation glyph, even though
374 its CHARPOS is positive.
26b46e51
EZ
375 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
376 cover_string to disp_string.
bc17a887 377
4ee88440
MR
3782011-11-01 Martin Rudalics <rudalics@gmx.at>
379
380 * window.c (temp_output_buffer_show): Don't use
381 Vtemp_buffer_show_specifiers.
382 (Vtemp_buffer_show_specifiers): Remove unused variable.
383
c2ff3c02
EZ
3842011-10-30 Eli Zaretskii <eliz@gnu.org>
385
386 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
387 past the beginning of the current glyph matrix.
388
58179cce 3892011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
390
391 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
392 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
393 HAVE_GTK3 (Bug#9869).
b77a6a7f 394
3b574623
JD
395 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
396 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
397
b77a6a7f
JD
398 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
399
400 * xterm.c: Declare x_handle_net_wm_state to return int.
401 (handle_one_xevent): Check if we are iconified but don't have
402 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
403 (get_current_wm_state): Return non-zero if not hidden,
404 check for _NET_WM_STATE_HIDDEN (Bug#9893).
405 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
406 (x_handle_net_wm_state): Return what get_current_wm_state returns.
407 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
408
196e41e4
PE
4092011-10-29 Paul Eggert <eggert@cs.ucla.edu>
410
411 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
412 so that this new function doesn't get optimized away by a
413 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
414
021f2e1a
AS
4152011-10-29 Andreas Schwab <schwab@linux-m68k.org>
416
417 * frame.h (MOUSE_HL_INFO): Remove excess parens.
418
8b058d44
EZ
4192011-10-29 Eli Zaretskii <eliz@gnu.org>
420
421 Fix the `xbytecode' command.
422 * .gdbinit (xprintbytestr): New command.
b50a28de 423 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
424 (xbytecode): Print the byte-code string as well.
425
4452fb80
EZ
4262011-10-29 Kim Storm <storm@cua.dk>
427
8b058d44
EZ
428 * alloc.c (which_symbols): New function.
429
21b72067
AS
4302011-10-29 Andreas Schwab <schwab@linux-m68k.org>
431
432 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
433 line. (Bug#9903)
434
83ed7b5c
GM
4352011-10-29 Glenn Morris <rgm@gnu.org>
436
437 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
438 Not clear what it was for, and it causes various bugs. (Bug#9839)
439
5a7a728b
EZ
4402011-10-28 Eli Zaretskii <eliz@gnu.org>
441
442 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
443 possible random value that matches one of those tested as
444 condition to clear the mouse face.
445
d3d0842f
CY
4462011-10-28 Chong Yidong <cyd@gnu.org>
447
448 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
449
31b39d13
DN
4502011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
451
452 * window.c (make_window): Initialize phys_cursor_on_p.
453
9aba6043
SM
4542011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
455
456 * lisp.h (struct Lisp_Symbol): Update comments.
457
c20992f4
JB
4582011-10-28 Juanma Barranquero <lekktu@gmail.com>
459
460 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
461
db4f02f2
EZ
4622011-10-28 Eli Zaretskii <eliz@gnu.org>
463
464 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
465 <oslsachem@gmail.com> for helping to debug this.
466
467 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
468 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
469 (g_b_init_get_glyph_outline_w): New static variables.
470 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
471 (GetGlyphOutlineW_Proc): New typedefs.
472 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
473 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
474 New functions.
475 (w32font_open_internal, compute_metrics):
476 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
477 instead of calling the "wide" APIs directly.
478
479 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
480
481 * w32.h (syms_of_w32font): Add prototype.
482
87e68db4
JB
4832011-10-27 Juanma Barranquero <lekktu@gmail.com>
484
485 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
486 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
487 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
488 (Fmove_to_window_line): Doc fix.
489
435c1d67
CY
4902011-10-27 Chong Yidong <cyd@gnu.org>
491
492 * process.c (make_process): Set gnutls_state to NULL.
493
494 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
495 non-NULL, regardless of GNUTLS_INITSTAGE.
496 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
497 an error. Set process slots as soon as we allocate them.
498
499 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
500
9c6c6f49
CY
5012011-10-27 Chong Yidong <cyd@gnu.org>
502
9aba6043
SM
503 * gnutls.c (emacs_gnutls_deinit): New function.
504 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
505 (Fgnutls_deinit, Fgnutls_boot): Use it.
506
507 * process.c (make_process): Initialize GnuTLS credentials to NULL.
508 (deactivate_process): Call emacs_gnutls_deinit.
509
657d08d3
JB
5102011-10-27 Juanma Barranquero <lekktu@gmail.com>
511
512 * image.c (x_create_x_image_and_pixmap):
513 * w32.c (sys_rename, w32_delayed_load):
514 * w32font.c (fill_in_logfont):
515 * w32reg.c (x_get_string_resource): Silence compiler warnings.
516
5430d399
JB
5172011-10-26 Juanma Barranquero <lekktu@gmail.com>
518
519 * w32fns.c (w32_default_color_map): New function,
520 extracted from Fw32_default_color_map.
a7ef684b 521 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 522
fe0055fa
PE
5232011-10-25 Paul Eggert <eggert@cs.ucla.edu>
524
525 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
526
e6346438
SM
5272011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
528
529 * keyboard.c (test_undefined): New function (bug#9751).
530 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
531
e112cc37
ET
5322011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
533
534 * sysdep.c (init_sys_modes): Fix the check for the controlling
535 terminal (Bug#6649).
536
7b5d6677
EZ
5372011-10-20 Eli Zaretskii <eliz@gnu.org>
538
539 * dispextern.h (struct bidi_it): New member next_en_type.
540
541 * bidi.c (bidi_line_init): Initialize the next_en_type member.
542 (bidi_resolve_explicit_1): When next_en_pos is valid for the
543 current character, check also for next_en_type being WEAK_EN.
544 (bidi_resolve_weak): Don't enter the expensive loop if the current
545 position is before next_en_pos. Record the bidi type of the first
546 non-ET, non-BN character we find, in addition to its position.
547 (bidi_level_of_next_char): Invalidate next_en_type when
548 next_en_pos is over-stepped.
549
7da0b018
PE
5502011-10-20 Paul Eggert <eggert@cs.ucla.edu>
551
552 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
553 * editfns.c: Rewrite current-time-zone so that it invokes
554 the equivalent of (format-time-string "%Z") to get the time zone name.
555 This fixes a bug when the time zone name contains characters that
556 need converting from the system time locale to Emacs internal format.
557 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
558 that patch fixed format-time-string to do the conversion, but
559 I forgot to fix current-time-zone.
560 (format_time_string): New function, containing most of
561 what Fformat_time_string used to contain.
562 (Fformat_time_string): Rewrite in terms of format_time_string.
563 This doesn't change this function's behavior.
564 (current-time-zone): Rewrite to use format_time_string.
565 This fixes the bug reported by Michael Schierl in
566 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
567 Jason Rumney's 2007-06-07 change worked around this bug, but
568 didn't fix it.
569 * systime.h (tzname, timezone): Remove no-longer-used declarations.
570
8547b010
EZ
5712011-10-19 Eli Zaretskii <eliz@gnu.org>
572
573 * xdisp.c (start_display): If the character at POS is displayed
574 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
575 (try_window_reusing_current_matrix): If a line ends in a display
576 vector or the next line starts in a display vector, continue
577 redrawing the window even though the character position of
578 start_row was reached.
8547b010
EZ
579 (Bug#9771, part 2)
580
4e948d15
CY
5812011-10-18 Chong Yidong <cyd@gnu.org>
582
583 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
584 with nobreak-char-display too.
585
4787455f
EZ
5862011-10-18 Eli Zaretskii <eliz@gnu.org>
587
588 Fix part 3 of bug#9771.
589 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
590 (bidi_resolve_neutral): Don't enter the expensive loop looking for
591 non-neutral characters if the current character is a paragraph
592 separator (a.k.a. Newline). This avoids running the same
593 expensive loop twice, once when we consume the preceding newline
594 and the other time when the line actually needs to be displayed.
595 Avoid the loop when we see neutrals on the base embedding level
596 following a character whose directionality is the same as the
597 paragraph's. This avoids running the expensive loop when a line
598 ends in a long sequence of neutrals, like control characters.
599 Add assertion against STRONG_AL type. Slightly rearrange code
600 that determines the type of a neutral given the first non-neutral
601 that follows it.
602 (bidi_level_of_next_char): Set next_en_pos to zero when
603 invalidating its info.
604
2c91f553
EZ
6052011-10-17 Eli Zaretskii <eliz@gnu.org>
606
607 * xdisp.c (push_display_prop): Determine whether to record string
608 or buffer position by IT->string, not by IT->method. Allow
609 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
610 (move_it_vertically_backward): Don't look for character position
611 immediately after the newline when in a continuation line.
612 (Bug#9771, part 1)
2c91f553 613
c7b08b0d
MR
6142011-10-15 Martin Rudalics <rudalics@gmx.at>
615
616 * window.c (coordinates_in_window): Rewrite and delabelize
617 vertical border check. (Bug#5357) (Bug#9618)
618
6b02f655
SM
6192011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
620
621 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
622 errors in XSetWindowBorder (bug#9310).
623
81d40c92
DA
6242011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
625
626 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
627 avoid crash when xmalloc overrun checking is enabled.
628
d4172c3b
EZ
6292011-10-13 Eli Zaretskii <eliz@gnu.org>
630
631 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
632 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
633 cursor motion with <left> and <right> arrow keys.
634
635 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
636 some callers set that themselves.
637
b00eea75
EZ
6382011-10-12 Eli Zaretskii <eliz@gnu.org>
639
640 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
641 display string and the previous row comes from the same string and
642 is empty. (Bug#9739) (Bug#9738)
643
8fe012c4
SM
6442011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
645
646 * doc.c (get_doc_string): Encode file name (bug#9735).
647
0074aef2
EZ
6482011-10-12 Eli Zaretskii <eliz@gnu.org>
649
79beb178
EZ
650 * bidi.c (bidi_level_of_next_char):
651 * xdisp.c (get_visually_first_element): Remove old incorrect
652 comments regarding the Unicode Line Separator character.
653
0074aef2
EZ
654 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
655
6e4b3fbe
DA
6562011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
657
658 * alloc.c (Fgc_status): Do not access beyond zombies array
659 boundary if nzombies > MAX_ZOMBIES.
660 * alloc.c (dump_zombies): Add missing format specifier.
661
0324f3af
PE
6622011-10-12 Paul Eggert <eggert@cs.ucla.edu>
663
b5525cac
PE
664 * xdisp.c (set_cursor_from_row): Simplify conditionals,
665 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
666
0324f3af
PE
667 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
668 Some packages use them to denote characters with modifiers.
669
e9b5f888
AS
6702011-10-11 Andreas Schwab <schwab@linux-m68k.org>
671
672 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
673 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
674 matching a pp-number. Rename parameter var to var1.
675
127827c0
SM
6762011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
677
678 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
679
c8fd3bd0
GM
6802011-10-08 Glenn Morris <rgm@gnu.org>
681
682 * callint.c (Fcall_interactively): Give a more explicit error for the
683 'c' case with a non-character input. (Bug#8479)
684
352ec8ff
EZ
6852011-10-08 Eli Zaretskii <eliz@gnu.org>
686
03669ccb
EZ
687 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
688 lines.
7061c986
EZ
689 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
690 lines that are hscrolled on the left.
03669ccb 691
352ec8ff
EZ
692 * dispnew.c (buffer_posn_from_coords): Account for a possible
693 presence of header-line. (Bug#4426)
694
a66cfb1c
SM
6952011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
696
6b02f655
SM
697 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
698 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 699
7c5ee88e
PE
7002011-10-07 Paul Eggert <eggert@cs.ucla.edu>
701
702 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
703 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
704 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
705 this makes Emacs dump core during garbage collection on rare
706 occasions. sizeof is obviously inferior to offsetof here, so
707 stick with offsetof.
708 (GC_POINTER_ALIGNMENT): New macro.
709 (mark_memory): Omit 3rd (offset) arg; caller changed.
710 Don't assume EMACS_INT alignment is the same as pointer alignment.
711
df1bbe5b
SM
7122011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
713
714 * keyboard.c (read_key_sequence_remapped): New var.
715 (read_key_sequence): Compute remapping in the right buffer.
716 (command_loop_1): Use read_key_sequence's remapping directly.
717
51553db6
SM
7182011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
719
32c1fffd
SM
720 * dired.c (file_name_completion): Don't expand file name.
721 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
722 before checking file name handler.
723
51553db6
SM
724 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
725 they've been requested explicitly (bug#9591).
726
b6bd1599 7272011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
728
729 * keymap.c (Fsingle_key_description): Use make_specified_string
730 instead of build_string to build string from push_key_description.
731 (Bug#5193)
732
f701dc2a
PE
7332011-09-30 Paul Eggert <eggert@cs.ucla.edu>
734
4222c55d
PE
735 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
736 This fixes a Y2038 bug on 64-bit hosts.
737 * buffer.c (reset_buffer):
738 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
739 (Fclear_buffer_auto_save_failure):
740 Use 0, not -1, to represent an unset failure time, since time_t
741 might not be signed.
742
f701dc2a
PE
743 Remove dependency on glibc malloc internals.
744 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
745 Move back here from lisp.h, but with their new implementations.
746 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
747 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
748 * charset.c (charset_table_init): New static var.
749 (syms_of_charset): Use it instead of xmalloc. This removes a
750 dependency on glibc malloc internals. See Eli Zaretskii's comment in
751 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
752 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
753 Move back to alloc.c.
754 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
755 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
756
9ceebf39
JD
7572011-09-30 Jan Djärv <jan.h.d@swipnet.se>
758
759 * nsterm.m (windowDidResize): Call x_set_window_size only when
760 ns_in_resize is true. Otherwise set pixelwidth/height and
761 call change_frame_size (Bug#9628).
762
cb993c58
PE
7632011-09-30 Paul Eggert <eggert@cs.ucla.edu>
764
3930c88b
PE
765 Port --enable-checking=all to Fedora 14 x86-64.
766 * charset.c (syms_of_charset): Also account for glibc malloc's
767 internal overhead when calculating the initial malloc maximum.
768
cb993c58
PE
769 Port --enable-checking=all to Fedora 14 x86.
770 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
771 Move to lisp.h.
772 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
773 (overrun_check_realloc, overrun_check_free):
774 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
775 That way, xmalloc returns a properly-aligned pointer even if
776 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
777 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
778 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
779 into account when calculating the initial malloc maximum.
780 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
781 Move here from alloc.c, so that charset.c can use it too.
782 Properly align; the old code wasn't right for common 32-bit hosts
783 when configured with --enable-checking=all.
784 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
785 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
786
31bed486
EZ
7872011-09-29 Eli Zaretskii <eliz@gnu.org>
788
04c70788 789 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
790 use EDOM.
791
fbcaa2f3
EZ
7922011-09-28 Eli Zaretskii <eliz@gnu.org>
793
794 * xdisp.c (compute_display_string_end): If there's no display
795 string at CHARPOS, return -1.
796
797 * bidi.c (bidi_fetch_char): When compute_display_string_end
798 returns a negative value, treat the character as a normal
799 character not covered by a display string. (Bug#9624)
800
a239d4e9
JB
8012011-09-28 Juanma Barranquero <lekktu@gmail.com>
802
803 * lread.c (Fread_from_string): Fix typo in docstring.
804
88652fd5
EZ
8052011-09-27 Eli Zaretskii <eliz@gnu.org>
806
807 * xdisp.c (handle_invisible_prop): If invisible text ends on a
808 newline, reseat the iterator instead of bidi-iterating there one
809 character at a time. (Bug#9610)
32c1fffd
SM
810 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
811 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 812
ed497dd4
AS
8132011-09-27 Andreas Schwab <schwab@linux-m68k.org>
814
815 * lread.c (readevalloop): Use correct code for NBSP.
816 (read1): Likewise. (Bug#9608)
817
b2bf61aa
MA
8182011-09-25 Michael Albinus <michael.albinus@gmx.de>
819
820 * dbusbind.c (Fdbus_register_signal): When service is not
821 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
822
32bbb17c
GM
8232011-09-25 Glenn Morris <rgm@gnu.org>
824
825 * buffer.c (truncate-lines): Doc fix.
826
94e0933e
CY
8272011-09-24 Chong Yidong <cyd@stupidchicken.com>
828
829 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
830 (Fset_window_next_buffers): Doc fix.
831
cddde921
GM
8322011-09-24 Glenn Morris <rgm@gnu.org>
833
834 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
835
1260aef1
PE
8362011-09-24 Paul Eggert <eggert@cs.ucla.edu>
837
25b4bfa0
PE
838 Fix minor problems found by static checking.
839 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
840 * indent.c (Fvertical_motion): Fix == vs = typo.
841
e3cbd34b
EZ
8422011-09-24 Eli Zaretskii <eliz@gnu.org>
843
a66cfb1c
SM
844 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
845 Default value is now t. Doc fix.
6bf7006f 846
e3cbd34b 847 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 848 logic when moving up, not only when moving down. Fix the
e3cbd34b 849 confusing name and values of the it_overshoot_expected variable;
32c1fffd 850 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
851
852 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
853 CHARPOS is covered by a display string which includes newlines.
854 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
855 is covered by a display string with embedded newlines.
856
a3de0cbd
MA
8572011-09-24 Michael Albinus <michael.albinus@gmx.de>
858
859 * dbusbind.c (Fdbus_register_signal): Add match rule to
860 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
861 (Fdbus_register_method, Vdbus_registered_objects_table):
862 Fix docstring.
a3de0cbd 863
b260039d
JM
8642011-09-24 Jim Meyering <meyering@redhat.com>
865
32c1fffd 866 do not ignore write error for any output size
b260039d
JM
867 The previous change was incomplete.
868 While it makes emacs --batch detect the vast majority of stdout
869 write failures, errors were still ignored whenever the output size is
870 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
871 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
872 && echo FAIL: ignored write error
873 FAIL: ignored write error
874 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
875 && echo FAIL: ignored write error
876 FAIL: ignored write error
877 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
878
8eca8a7c
AS
8792011-09-23 Andreas Schwab <schwab@linux-m68k.org>
880
881 * emacs.c (Fkill_emacs): In noninteractive mode exit
882 non-successfully if a write error occurred on stdout. (Bug#9574)
883
3341db62
EZ
8842011-09-21 Eli Zaretskii <eliz@gnu.org>
885
886 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
887 the xassert test.
888
889 * dispextern.h (struct it): Update the comment documenting what
890 can it->OBJECT be.
891
8c203dbf
EZ
8922011-09-20 Eli Zaretskii <eliz@gnu.org>
893
894 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
895 a display string, extend search for cursor position to end of row.
896 (find_row_edges): If the row ends in a newline from a display
897 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
898 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
899 (Fcurrent_bidi_paragraph_direction): Fix search for previous
900 non-empty line. Fixes confusing cursor motion with arrow keys at
901 the beginning of a line that starts with whitespace.
8c203dbf 902
a4824228
LMI
9032011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
904
905 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
906 (bug#9493).
907
33ed493b
CY
9082011-09-18 Chong Yidong <cyd@stupidchicken.com>
909
910 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
911 boolean (Bug#9154).
912
56cd55c8
EZ
9132011-09-18 Eli Zaretskii <eliz@gnu.org>
914
915 * xdisp.c (display_line): Record maximum and minimum buffer
916 positions even if no glyphs were produced (e.g., by a zero-width
917 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
918 buffer positions that will be removed from the glyph row because
919 they don't fit.
c02dcedf
EZ
920 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
921 column is beyond frame width: don't subtract 1 "pixel" when
922 computing width of the stretch.
3e62b7e0
EZ
923 (reseat_at_next_visible_line_start): Undo the change made on
924 2011-09-17 that saved paragraph information and restored it after
925 the call to `reseat'. (Bug#9545)
56cd55c8 926
5ed99d36 9272011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
928
929 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
930 and turn window cursor on if cleared (Bug#9415).
931
5ed99d36 9322011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
933
934 * search.c (boyer_moore): Take unibyte characters from pattern
935 literally. (Bug#9458)
936
9bade7b2
EZ
9372011-09-18 Eli Zaretskii <eliz@gnu.org>
938
939 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
940
e5e9d610
PE
9412011-09-18 Paul Eggert <eggert@cs.ucla.edu>
942
87e4427a
PE
943 Fix minor problem found by static checking.
944 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
945 initialized, to pacify gcc -Wuninitialized.
946
e5e9d610
PE
947 * fileio.c: Report proper errno when syscall falls.
948 (Finsert_file_contents): Save and restore errno,
949 so that report_file_error outputs the correct diagnostic.
950 (Fwrite_region) [CLASH_DETECTION]: Likewise.
951
a1674f0b
EZ
9522011-09-18 Eli Zaretskii <eliz@gnu.org>
953
954 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
955
fbfb6dd4
EZ
9562011-09-17 Eli Zaretskii <eliz@gnu.org>
957
958 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
959 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
960
bb187662
EZ
9612011-09-17 Eli Zaretskii <eliz@gnu.org>
962
1137e8b8 963 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 964 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
965
966 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
967 (bidi_find_paragraph_start): Search back for paragraph beginning
968 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
969 (bidi_move_to_visually_next): Only trigger paragraph-related
970 computations when the last character is a newline or at EOB, not
971 just any NEUTRAL_B. (Bug#9470)
972
bb187662
EZ
973 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
974 truncated lines if point is covered by a display string. (Bug#9524)
975
2e621251
PE
9762011-09-16 Paul Eggert <eggert@cs.ucla.edu>
977
978 * xselect.c: Relax test for outgoing X longs (Bug#9498).
979 (cons_to_x_long): New function.
980 (lisp_data_to_selection_data): Use it. Correct the test for
981 short-versus-long data; it was negated. Break out of vector
982 loop, for efficiency, when a long datum is discovered.
983
91a15bc6
SM
9842011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
985
986 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
987
b41c3a35
EZ
9882011-09-16 Eli Zaretskii <eliz@gnu.org>
989
990 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
991 GCC PR/17406) by declaring this function with external scope.
992
7812ba2d
PE
9932011-09-15 Paul Eggert <eggert@cs.ucla.edu>
994
995 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
996 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
997
cf7edc2a
AS
9982011-09-15 Andreas Schwab <schwab@linux-m68k.org>
999
1000 * editfns.c (Fformat): Correctly handle text properties on "%%".
1001
bd01620e
EZ
10022011-09-15 Eli Zaretskii <eliz@gnu.org>
1003
1004 * xterm.c (x_draw_composite_glyph_string_foreground):
1005 * w32term.c (x_draw_composite_glyph_string_foreground):
1006 * term.c (encode_terminal_code):
1007 * composite.c (composition_update_it, get_composition_id):
1008 * xdisp.c (get_next_display_element)
1009 (fill_composite_glyph_string): Add comments about special meaning
1010 of TAB characters in a composition.
1011
a02719a3
PE
10122011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1013
1014 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1015 This occurs when processing a multibyte format.
1016 Problem reported by Wolfgang Jenker.
a02719a3 1017
72589a3c
JB
10182011-09-15 Johan Bockgård <bojohan@gnu.org>
1019
1020 * xdisp.c (try_cursor_movement): Only check for exact match if
1021 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1022
1c14176c
PE
10232011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1024
1025 Remove unused external symbols.
1026 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1027 * xdisp.c (calc_pixel_width_or_height): Now static.
1028 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1029 * indent.c (check_display_width):
1030 * w32term.c: Fix comment to match code.
1031 * xterm.c, xterm.h (x_catching_errors): Remove.
1032
d2eea5b5
PE
10332011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 * xselect.c: Use signed conversions more consistently (Bug#9498).
1036 (selection_data_to_lisp_data): Assume incoming selection data are
1037 signed integers, not unsigned. This is to be consistent with
1038 outgoing selection data, which was modified to use signed integers
1039 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1040 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1041 expects long, not unsigned long.
1042
46888499
EZ
10432011-09-14 Eli Zaretskii <eliz@gnu.org>
1044
1045 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1046 computation of loop end. Reported by Johan Bockgård
1047 <bojohan@gnu.org>.
1048
ef8ef9fb
CY
10492011-09-13 Chong Yidong <cyd@stupidchicken.com>
1050
1051 * frame.c (Fother_visible_frames_p): Function deleted.
1052
fa819fed
EZ
10532011-09-12 Eli Zaretskii <eliz@gnu.org>
1054
1055 * indent.c (compute_motion): Process display vector front to back
1056 rather than the other way around. (Bug#2496)
1057
2ba8e008
SM
10582011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1059
1060 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1061
20f53c69
CY
10622011-09-11 Chong Yidong <cyd@stupidchicken.com>
1063
1064 * minibuf.c (Fread_from_minibuffer): Doc fix.
1065
d562d7a4
EZ
10662011-09-11 Eli Zaretskii <eliz@gnu.org>
1067
1068 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1069 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1070
1c4d7f3d
LMI
10712011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1072
1073 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1074 value for non-existent files.
1075
b885bf36
EZ
10762011-09-11 Eli Zaretskii <eliz@gnu.org>
1077
1078 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1079 set its "size" to -1. This will set the modtime_size field of
1080 the corresponding buffer to -1, which is what
1081 verify-visited-file-modtime expects for files that do not exist.
1082 (Bug#9139)
1083
6612f0bf
PE
10842011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1085
1086 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1087 here ...
1088 * lisp.h: ... from here. push_key_description is no longer
1089 defined in keyboard.c, so its declaration should not be in
1090 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1091 logically belongs with push_key_description.
1092
dfb3f755
PE
10932011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1094
1095 * buffer.h: Include <sys/types.h> instead of <time.h>.
1096 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1097 Problem reported by Herbert J. Skuhra.
1098
3134906c
LMI
10992011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1100
1101 * xml.c (parse_region): Make the parsing work for
1102 non-comment-starting XML files again (bug#9144).
1103
8d903f4e
AS
11042011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1105
1106 * image.c (gif_load): Fix calculation of bottom and right corner.
1107 (Bug#9468)
1108
80ad64f4
EZ
11092011-09-10 Eli Zaretskii <eliz@gnu.org>
1110
1111 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1112 redisplay in small windows.
1113
208a048d
EZ
11142011-09-09 Eli Zaretskii <eliz@gnu.org>
1115
1116 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1117
9b1c252e
MR
11182011-09-08 Martin Rudalics <rudalics@gmx.at>
1119
1120 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1121 Operate on live windows only.
1122
2949f33b
JB
11232011-09-08 Juanma Barranquero <lekktu@gmail.com>
1124
1125 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1126
e08dcafd
EZ
11272011-09-07 Eli Zaretskii <eliz@gnu.org>
1128
1129 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1130 only under bidi iteration.
1131
115b96bd
JD
11322011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1133
1134 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1135
c8199d0f
PE
11362011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1137
1138 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1139 Without this fix, the command to link temacs failed due to an
1140 undefined symbol __builtin_isnan. This is because
1141 /usr/include/iso/math_c99.h #defines isnan(x) to
1142 __builtin_isnan(x), but the bundled gcc, which identifies itself
1143 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1144 a __builtin_isnan.
1145 * floatfns.c (isnan): #undef, and then #define to a clone of
1146 what's in data.c.
1147 (Fisnan): Always define, since it's always available now.
1148 (syms_of_floatfns): Always define isnan at the Lisp level.
1149
e39b275c 11502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1151
1152 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1153
b2db44d9 11542011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1155
f4af5137 1156 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1157 The previous code assumed that file offsets (off_t values) fit in
1158 EMACS_INT variables, which is not true on typical 32-bit hosts.
1159 The code messed up by falsely reporting buffer overflow in cases
1160 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1161 when "big" contains more than 2**29 bytes, even though this
1162 inserts just one byte and does not overflow the buffer.
1163 (Finsert_file_contents): Store file offsets as off_t
1164 values, not as EMACS_INT values. Check for overflow when
1165 converting between EMACS_INT and off_t. When checking for
1166 buffer overflow or for overlap, take the offsets into account.
1167 Don't use EMACS_INT for small values where int suffices.
1168 When checking for overlap, fix a typo: ZV was used where
1169 ZV_BYTE was intended.
1170 (Fwrite_region): Don't assume off_t fits into 'long'.
1171 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1172
ecfc0a49
MA
11732011-09-05 Michael Albinus <michael.albinus@gmx.de>
1174
1175 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1176
6511acf2 11772011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1178
0999621a 1179 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1180
1181 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1182 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1183 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1184 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1185 (modify_event_symbol): Do not assume that the length of
1186 name_alist_or_stem is safe to alloca and fits in int.
1187 (Fexecute_extended_command): Likewise for function name and binding.
1188 (Frecursion_depth): Wrap around reliably on integer overflow.
1189 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1190 since some callers pass EMACS_INT values.
1191 (Fsingle_key_description): Don't crash if symbol name contains more
1192 than MAX_ALLOCA bytes.
1193 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1194 (get_minibuffer): Arg is now EMACS_INT, not int.
1195 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1196 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1197 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1198
2be7d702
PE
1199 * dbusbind.c (signature_cat): New function.
1200 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1201 Do not overrun buffer; instead, report string overflow.
1202
9d1df220
PE
1203 * dispnew.c (add_window_display_history): Don't overrun buffer.
1204 Truncate instead; this is OK since it's just a log.
1205
33ef5c64
PE
1206 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1207 even if the time zone offset is outlandishly large.
1208 Don't mishandle offset == INT_MIN.
1209
66c6fdd5
PE
1210 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1211 when creating daemon; the previous buffer-overflow check was incorrect.
1212
d749b01b
PE
1213 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1214 which has the guts of the old verror function.
1215
b5cd1905
PE
1216 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1217 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1218
6e1a67fb
PE
1219 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1220 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1221 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1222 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1223 length of string rather than counting it via multiple sprintfs;
1224 that's simpler and more reliable.
c21721cc
PE
1225 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1226 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1227 sprintf, in case result does not fit in int.
1228
c57b67fc
PE
1229 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1230 (fontset_from_font): Print it.
1231
8a401434
PE
1232 * frame.c (tty_frame_count): Now printmax_t, not int.
1233 (make_terminal_frame, set_term_frame_name): Print it.
1234 (x_report_frame_params): In X, window IDs are unsigned long,
1235 not signed long, so print them as unsigned.
1236 (validate_x_resource_name): Check for implausibly long names,
1237 and don't assume name length fits in 'int'.
1238 (x_get_resource_string): Don't blindly alloca invocation name;
1239 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1240 not fit in int.
1241
6e1a67fb
PE
1242 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1243 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1244 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1245
0df02bf3
PE
1246 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1247 Use esprintf, not sprintf, in case result does not fit in int.
1248
48e30793
PE
1249 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1250 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1251 it as a large positive number.
1252 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1253 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1254
a66ff6d8
PE
1255 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1256 in case result does not fit in int.
1257
aca216ff
PE
1258 * print.c (float_to_string): Detect width overflow more reliably.
1259 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1260 buffer overrun. Don't assume list length fits in 'int'. Treat
1261 print length of 0 as 0, not as infinity; to be consistent with other
1262 uses of print length in this function. Don't overflow print length
1263 index. Don't assume hash table size fits in 'long', or that
1264 vectorlike size fits in 'unsigned long'.
1265
31c286f7
PE
1266 * process.c (make_process): Use printmax_t, not int, to format
1267 process-name gensyms.
1268
55e5faa1
PE
1269 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1270
80f2e268
PE
1271 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1272 to avoid potential buffer overrun.
1273
670741ab
PE
1274 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1275 if X resource line is longer than 512 bytes.
1276
b7163a50
PE
1277 * xfns.c (x_window): Make sprintf buffer a bit bigger
1278 to avoid potential buffer overrun.
1279
ae58ff1f
PE
1280 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1281
c43c8a6a
PE
1282 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1283
3f8236f4
PE
12842011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1285
53e9fe90 1286 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1287 Without these, Emacs silently mishandles large integers sometimes.
1288 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1289 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1290
6511acf2
PE
1291 * xdisp.c (try_window_id): Check Emacs fixnum range before
1292 converting to 'int'.
806add1d 1293
6511acf2 1294 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1295 Check that an Emacs fixnum is in range before assigning it to 'int'.
1296 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1297 values converted from Emacs fixnums.
1298 (Frecenter): Don't wrap around a line count if it is out of 'int'
1299 range; instead, treat it as an extreme value.
1300 (Fset_window_configuration, compare_window_configurations):
1301 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1302
6511acf2
PE
1303 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1304 that can exceed INT_MAX. Check that EMACS_INT value is in range
1305 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1306 (match_limit): Don't assume that a fixnum can fit in 'int'.
1307
6511acf2 1308 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1309 exceed INT_MAX.
1310
6511acf2 1311 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1312 (Fvertical_motion): Don't wrap around LINES values that don't fit
1313 in 'int'. Instead, treat them as extreme values. This is good
1314 enough for windows, which can't have more than INT_MAX lines anyway.
1315
fcb901a7
LMI
13162011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1317
0f2f6b6d
LMI
1318 * Require libxml/parser.h to avoid compilation warning.
1319
fcb901a7
LMI
1320 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1321
1322 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1323 since this reportedly can destroy thread storage.
1324
6e20a0d4
CY
13252011-08-30 Chong Yidong <cyd@stupidchicken.com>
1326
1327 * syntax.c (find_defun_start): Update all cache variables if
1328 exiting early (Bug#9401).
1329
148ae00e
EZ
13302011-08-30 Eli Zaretskii <eliz@gnu.org>
1331
f6cfbd8f
EZ
1332 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1333
148ae00e
EZ
1334 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1335 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1336 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1337
1338 * term.c (tty_append_glyph): New function.
1339 (produce_stretch_glyph): Static function and its prototype deleted.
1340
a66cfb1c
SM
1341 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1342 Add prototypes.
148ae00e 1343
c4a07a4c
PE
13442011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1345
1346 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1347 when checking :margin (Bug#9390).
1348 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1349 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1350 so that the name doesn't mislead. All uses changed.
1351
6bc8cd65
JB
13522011-08-28 Johan Bockgård <bojohan@gnu.org>
1353
1354 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1355 set_tty_hooks.
1356
dca4927e
EZ
13572011-08-27 Eli Zaretskii <eliz@gnu.org>
1358
1359 * xdisp.c (move_it_to): Don't bail out early when reaching
1360 position beyond to_charpos, if we are scanning backwards.
1361 (move_it_vertically_backward): When DY == 0, make sure we get to
1362 the first character in the line after the newline.
1363
f2cad773
PE
13642011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1365
1366 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1367 (ccl_driver): Do not generate an out-of-range pointer.
1368 (Fccl_execute_on_string): Remove unnecessary check for
1369 integer overflow, noted by Stefan Monnier in
1370 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1371 Remove a FIXME that didn't need fixing.
1372 Simplify the newly-introduced buffer reallocation code.
1373
0cae2cdb
JB
13742011-08-27 Juanma Barranquero <lekktu@gmail.com>
1375
1376 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1377
5fc295a4 13782011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1379
70c60eb2 1380 Integer and memory overflow issues (Bug#9196).
726e0ab1 1381
d31850da
PE
1382 * doc.c (get_doc_string): Rework so that
1383 get_doc_string_buffer_size is the actual buffer size, rather than
1384 being 1 less than the actual buffer size; this makes xpalloc more
1385 convenient.
1386
a69fbedb
PE
1387 * image.c (x_allocate_bitmap_record, cache_image):
1388 * xselect.c (Fx_register_dnd_atom):
1389 Simplify previous changes by using xpalloc.
1390
fe5c5d37
PE
1391 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1392 since either will do and ptrdiff_t is convenient with xpalloc.
1393
0065d054
PE
1394 * charset.c (charset_table_size)
1395 (struct charset_sort_data.priority): Now ptrdiff_t.
1396 (charset_compare): Don't overflow if priorities differ greatly.
1397 (Fsort_charsets): Don't assume list length fits in int.
1398 Check for size-calculation overflow when allocating sort data.
1399 (syms_of_charset): Allocate an initial charset table that is
1400 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1401
1402 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1403
1404 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1405 The actual value is always <= INT_MAX, and leaving it unsigned made
1406 overflow checking harder.
1407
1408 * dispextern.h (struct glyph_matrix.rows_allocated)
1409 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1410 with xpalloc. The values are still always <= INT_MAX.
1411
1412 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1413
1414 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1415 (SAFE_NALLOCA): New macro.
1416
1417 * region-cache.c (struct boundary.pos, find_cache_boundary)
1418 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1419 (set_cache_region, invalidate_region_cache)
1420 (revalidate_region_cache, know_region_cache, region_cache_forward)
1421 (region_cache_backward, pp_cache):
1422 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1423 so that ptrdiff_t * can be passed to xpalloc.
1424 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1425 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1426 (pp_cache): Don't assume cache_len fits in int.
1427 * region-cache.h: Adjust extern decls to match.
1428
1429 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1430 EMACS_INT, since either will do, for xpalloc.
1431
1432 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1433 (xnmalloc, xnrealloc, xpalloc): New functions.
1434
726e0ab1
PE
1435 * bidi.c (bidi_shelve_header_size): New constant.
1436 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1437 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1438
51f30bc5 1439 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1440 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1441 (overlay_strings):
1442 Don't update size of array until after memory allocation succeeds,
1443 because xmalloc/xrealloc may not return.
0065d054
PE
1444 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1445 now that we have proper integer overflow checking.
1446 (record_overlay_string, overlay_strings): Catch overflows when
1447 calculating size of overlay_str_buf.
726e0ab1 1448
0065d054
PE
1449 * callproc.c (Fcall_process): Check for size overflow when
1450 calculating size of args2.
1451 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1452 Normally we prefer signed values, but sticking with ptrdiff_t would
1453 require adding more-complicated checks.
726e0ab1
PE
1454
1455 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1456 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1457 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1458 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1459
1460 * character.c (Fstring): Check for size-calculation overflow.
1461
1462 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1463 unnecessary integer overflow. Check for size overflow.
1464 (encode_coding_object): Don't update size until xmalloc succeeds.
1465
1466 * composite.c (get_composition_id): Check for overflow in glyph
1467 length calculations.
1468
1469 Integer and memory overflow fixes for display code.
1470 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1471 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1472 (scrolling_window): Check for overflow in size calculations.
1473 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1474 Don't assume glyph table len fits in int.
1475 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1476 (row_table_size): Now ptrdiff_t, not int.
1477 (scrolling_window): Avoid overflow in size calculations.
1478 Don't update size until allocation succeeds.
1479 * fns.c (concat): Check for overflow in size calculations.
1480 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1481 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1482 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1483
1484 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1485 (get_doc_string): Check for size calculation overflow.
1486 Don't update size until allocation succeeds.
1487 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1488 EMACS_INT, where ptrdiff_t will do.
1489 (Fsubstitute_command_keys): Check for string overflow.
1490
1491 * editfns.c (set_time_zone_rule): Don't assume environment length
1492 fits in int.
1493 (message_length): Now ptrdiff_t, not int.
1494 (Fmessage_box): Don't update size until allocation succeeds.
1495 Don't assume message length fits in int.
1496 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1497
0065d054
PE
1498 * emacs.c (main): Do not reallocate argv, since there is a null at
1499 the end that can be overwritten, and this way there's no need to
1500 worry about size-calculation overflow.
1501 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1502
1503 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1504 alloc succeeds.
1505 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1506
1507 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1508 (x_set_scroll_bar_width, x_figure_window_size):
1509 Check for integer overflow.
1510 (x_set_alpha): Do not assume XINT fits in int.
1511
1512 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1513 This is for the members text_lines, text_cols, total_lines, total_cols,
1514 where the system imposes an 'int' limit.
1515
1516 * fringe.c (Fdefine_fringe_bitmap):
1517 Don't update size until alloc works.
1518
1519 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1520 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1521
1522 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1523 Check for size-calculation overflow.
1524 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1525 do, as we prefer signed integers.
1526 (id_to_widget.max_size, id_to_widget.used)
1527 (xg_store_widget_in_map, xg_remove_widget_from_map)
1528 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1529 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1530 Use and return ptrdiff_t, not int.
1531 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1532 * gtkutil.h: Change prototypes to match the above.
1533
1534 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1535 are duplicate now that they've been promoted to lisp.h.
1536 (x_allocate_bitmap_record, x_alloc_image_color)
1537 (make_image_cache, cache_image, xpm_load):
1538 Don't update size until alloc is done.
1539 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1540 (x_detect_edges):
3256efce 1541 Check for size calculation overflow.
726e0ab1
PE
1542 (ct_colors_allocated_max): New constant.
1543 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1544 overflow.
3256efce 1545
726e0ab1
PE
1546 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1547 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1548 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1549 Use ptrdiff_t, not int, to count maps.
1550 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1551 calculations. Don't update size until allocation succeeds.
1552 Redo calculations to avoid overflow.
726e0ab1
PE
1553 * keyboard.h: Change prototypes to match the above.
1554
1555 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1556 to count maps.
1557 (current_minor_maps): Check for size calculation overflow.
1558 * keymap.h: Change prototypes to match the above.
1559
1560 * lread.c (read1, init_obarray): Don't update size until alloc done.
1561
1562 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1563 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1564
726e0ab1
PE
1565 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1566 Now ptrdiff_t, not int.
1567 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1568 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1569
1570 * process.c (Fnetwork_interface_list): Check for overflow
1571 in size calculation.
1572
1573 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1574
1575 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1576 overflow. Don't bother calling xmalloc when xrealloc will do.
1577
1578 * search.c (Freplace_match): Check for size calculation overflow.
1579 (Fset_match_data): Don't assume list lengths fit in 'int'.
1580
1581 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1582 for command line length. Do not attempt to address one before the
1583 beginning of an array, as that's not portable.
1584
1585 * term.c (max_frame_lines): Remove; unused.
1586 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1587 not int.
1588 (encode_terminal_code, calculate_costs): Check for size
1589 calculation overflow.
1590 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1591 table lengths and related sizes. Don't update size until alloc
1592 done. Redo calculations to avoid overflow.
1593 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1594
1595 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1596 subtracting pointers.
1597 (gobble_line): Check for overflow more carefully. Don't update size
1598 until alloc done.
1599
1600 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1601 Don't update size until alloc done.
1602 Redo size calculations to avoid overflow.
1603 Check for size calculation overflow.
0065d054 1604 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1605
1606 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1607 Use ptrdiff_t, not int, for sizes.
1608 (store_mode_line_noprop_char): Don't update size until alloc done.
1609
0065d054
PE
1610 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1611 Use ptrdiff_t, not int, for sizes.
1612 (Finternal_make_lisp_face, cache_face):
1613 Check for size calculation overflow.
1614 (cache_face): Treat size calculation overflows as if they were
1615 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1616
1617 * xfns.c (x_encode_text, x_set_name_internal)
1618 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1619 sizes, since they can exceed INT_MAX in size. Check for size
1620 calculation overflow.
1621
0065d054
PE
1622 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1623 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1624 Don't update size until alloc done.
1625
0065d054 1626 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1627 as sprintf is limited to int lengths.
1d526e2f 1628
252c5ee1
PE
1629 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1630 (X_LONG_MIN): New macros.
864d7ce7
PE
1631 Use them to make the following changes clearer.
1632 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1633 This change doesn't affect the value now, but it may help remind
1634 future maintainers not to raise the value too much later.
1635 (SELECTION_QUANTUM): Remove, replacing with ...
1636 (selection_quantum): ... new function, which avoids overflow.
1637 All uses changed.
1638 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1639 assumption that selection length fits in 'int'.
1640 (x_reply_selection_request, x_handle_selection_request)
1641 (x_get_window_property, receive_incremental_selection)
1642 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1643 (lisp_data_to_selection_data, clean_local_selection_data):
1644 Use ptrdiff_t, not int, to record length of selection.
1645 (x_reply_selection_request, x_get_window_property)
1646 (receive_incremental_selection, x_property_data_to_lisp):
1647 Redo calculations to avoid overflow.
1648 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1649 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1650 something.
1651 (x_get_window_property, receive_incremental_selection)
1652 (lisp_data_to_selection_data, x_property_data_to_lisp):
1653 Check for size-calculation overflow.
1654 (x_get_window_property, receive_incremental_selection)
1655 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1656 Don't store size until memory allocation succeeds.
1657 (x_get_window_property): Plug memory leak on memory exhaustion.
1658 Don't double-block input; malloc is safe here. Don't assume 2**34
1659 - 4 fits in unsigned long. Add an xassert to check
1660 XGetWindowProperty overflow. Be more careful about overflow
1661 calculations, and distinguish size from memory overflow better.
1662 (receive_incremental_selection): When tracing, don't assume
1663 unsigned int is less than INT_MAX.
1664 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1665 harmful) conversions of unsigned short to int.
1666 (lisp_data_to_selection_data): Don't assume that integers
1667 in the range -65535 through -1 fit in an X unsigned short.
1668 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1669 result parameters unless successful. Rely on cons_to_unsigned
1670 to report problems with elements; the old code wasn't right anyway.
1671 (x_check_property_data): Check for int overflow; we cannot use
1672 a wider type due to X limits.
1673 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1674
726e0ab1 1675 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1676
0065d054
PE
1677 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1678 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1679 (x_color_cells): Don't store size until memory allocation succeeds.
1680 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1681 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1682 (x_term_init): Don't assume length fits in int (sprintf is limited
1683 to int size).
bc18e09d 1684
ebfa62c0
PE
1685 Use ptrdiff_t for composition IDs.
1686 * character.c (lisp_string_width):
1687 * composite.c (composition_table_size, n_compositions)
1688 (get_composition_id, composition_gstring_from_id):
1689 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1690 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1691 * window.c (Frecenter):
1692 Use ptrdiff_t, not int, for composition IDs.
1693 * composite.c (get_composition_id): Check for integer overflow.
1694 * composite.h: Adjust prototypes to match the above changes.
1695
d3411f89
PE
1696 Use ptrdiff_t for hash table indexes.
1697 * category.c (hash_get_category_set):
1698 * ccl.c (ccl_driver):
1699 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1700 * coding.c (coding_system_charset_list, detect_coding_system):
1701 * coding.h (struct coding_system.id):
1702 * composite.c (get_composition_id, gstring_lookup_cache):
1703 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1704 * image.c (xpm_get_color_table_h):
1705 * lisp.h (hash_lookup, hash_put):
1706 * minibuf.c (Ftest_completion):
1707 Use ptrdiff_t for hash table indexes, not int (which is too
1708 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1709 32-bit --with-wide-int hosts).
1710
e097a6fa
PE
1711 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1712 Add a FIXME comment about memory leaks.
1713 (syms_of_charset): Don't assume xmalloc returns.
1714
5637687f
PE
1715 Don't assume that stated character widths fit in int.
1716 * character.c (Fchar_width, c_string_width, lisp_string_width):
1717 * character.h (CHAR_WIDTH):
1718 * indent.c (MULTIBYTE_BYTES_WIDTH):
1719 Use sanitize_char_width to avoid undefined and/or bad behavior
1720 with outlandish widths.
a66cfb1c 1721 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1722 now that we have two such functions. All uses changed.
1723 (sanitize_char_width): New inline function.
1724
a2271ba2
PE
1725 Don't assume that tab-width fits in int.
1726 * character.h (sanitize_width): New inline function.
1727 (SANE_TAB_WIDTH): New macro.
1728 (ASCII_CHAR_WIDTH): Use it.
1729 * indent.c (sane_tab_width): Remove. All uses replaced by
1730 SANE_TAB_WIDTH (current_buffer).
1731 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1732
18c52557
PE
1733 * fileio.c: Integer overflow issues with file modes.
1734 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1735
caeeedc1
PE
1736 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1737 Remove unreachable code.
1738 (read_hex, load_charset_map_from_file): Check for integer overflow.
1739
50849c52
PE
1740 * xterm.c: don't go over XClientMessageEvent limit
1741 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1742 (x_send_scroll_bar_event): Likewise. Check that the size does not
1743 exceed limits imposed by XClientMessageEvent, as well as the usual
1744 ptrdiff_t and size_t limits.
1745
b13995db
PE
1746 * keyboard.c: Overflow, signedness and related fixes.
1747 (make_lispy_movement): Use same integer type in forward decl
1748 that is used in the definition.
1749 (read_key_sequence, keyremap_step):
1750 Change bufsize argument back to int, undoing my 2011-03-30 change.
1751 We prefer signed types, and int is wide enough here.
1752 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1753 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1754 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1755 length, not size_t. Use ptrdiff_t for index, not int.
1756 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1757 possibility of integer overflow.
1758
13464394
PE
1759 Overflow, signedness and related fixes for images.
1760
1761 * dispextern.h (struct it.stack[0].u.image.image_id)
1762 (struct_it.image_id, struct image.id, struct image_cache.size)
1763 (struct image_cache.used, struct image_cache.ref_count):
1764 * gtkutil.c (update_frame_tool_bar):
1765 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1766 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1767 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1768 * nsmenu.m (update_frame_tool_bar):
1769 * xdisp.c (calc_pixel_width_or_height):
1770 * xfns.c (image_cache_refcount):
1771 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1772 on typical 64-bit hosts.
1773
1774 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1775 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1776 Omit unnecessary casts to int.
1777 (parse_image_spec): Check that integers fall into 'int' range
1778 when the callers expect that.
1779 (image_ascent): Redo ascent calculation to avoid int overflow.
1780 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1781 (lookup_image): Remove unnecessary tests.
1782 (xbm_image_p): Locals are now of int, not EMACS_INT,
1783 since parse_image_check makes sure they fit into int.
1784 (png_load, gif_load, svg_load_image):
1785 Prefer int to unsigned where either will do.
1786 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1787 old tiff_error_handler and tiff_warning_handler.
1788 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1789 stack buffer overflows. It uses only the features of vsnprintf
1790 that are common to both POSIX and native Microsoft.
1791 (tiff_error_handler, tiff_warning_handler): Use it.
1792 (tiff_load, gif_load, imagemagick_load_image):
1793 Don't assume :index value fits in 'int'.
1794 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1795 (imagemagick_load_image): Check that crop parameters fit into
1796 the integer types that MagickCropImage accepts. Don't assume
1797 Vimagemagick_render_type has a nonnegative value. Don't assume
1798 size_t fits in 'long'.
1799 (gs_load): Use printmax_t to print the widest integers possible.
1800 Check for integer overflow when computing image height and width.
1801
c11821d4
EZ
18022011-08-26 Eli Zaretskii <eliz@gnu.org>
1803
1804 * xdisp.c (redisplay_window): Don't force window start if point
1805 will be invisible in the resulting window. (Bug#9324)
1806
0c95fcf7
EZ
18072011-08-25 Eli Zaretskii <eliz@gnu.org>
1808
1809 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1810 the display spec is of the form `(space ...)'.
1811 (handle_display_spec): Return the value returned by
1812 handle_single_display_spec, not just 1 or zero.
1813 (handle_single_display_spec): If the display spec is of the form
1814 `(space ...)', and specifies display in the text area, return 2
1815 rather than 1.
fee65a97 1816 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1817 accurately, and prefer exact match for point under bidi.
1818 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1819
1820 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1821 into disp_prop; all users changed.
1822
1823 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1824 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1825 for the text covered by the display property.
1826
e4ed06f1
CY
18272011-08-25 Chong Yidong <cyd@stupidchicken.com>
1828
1829 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1830 Change return value to nil.
1831 (Frecord_buffer): Delete unused function.
1832
f67cdd7f
EZ
18332011-08-24 Eli Zaretskii <eliz@gnu.org>
1834
5980d4c6
EZ
1835 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1836 buffers, return left-to-right.
8610fe8b
EZ
1837 (set_cursor_from_row): Consider candidate row a win if its glyph
1838 represents a newline and point is on that newline. Fixes cursor
1839 positioning on the newline at EOL of R2L text within L2R
1840 paragraph, and vice versa.
1841 (try_cursor_movement): Check continued rows, in addition to
1842 continuation rows. Fixes unwarranted scroll when point enters a
1843 continued line of R2L text within an L2R paragraph, or vice versa.
1844 (cursor_row_p): Consider the case of point being equal to
1845 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1846 from the end of a short line to the beginning of a continued line
1847 of R2L text within L2R paragraph.
1848 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1849 composed characters.
5980d4c6 1850
f67cdd7f
EZ
1851 * bidi.c (bidi_check_type): Use xassert.
1852 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1853 members.
1854
bca633fb
EZ
18552011-08-23 Eli Zaretskii <eliz@gnu.org>
1856
1857 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1858 a character.
1859
4a5885a7
CY
18602011-08-23 Chong Yidong <cyd@stupidchicken.com>
1861
1862 * nsfont.m (ns_otf_to_script): Fix typo.
1863
0902a04e
KH
18642011-08-22 Kenichi Handa <handa@m17n.org>
1865
1866 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1867 extra slot even if the purpose is char-code-property-table.
1868
1a2e6670
EZ
18692011-08-23 Eli Zaretskii <eliz@gnu.org>
1870
8ddde651
EZ
1871 * xdisp.c (redisplay_window): When computing centering_position,
1872 account for the height of the header line. (Bug#8874)
1873
425cc014
EZ
1874 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1875 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1876 candidate is selected by the mouse, and that candidate has a
1877 composed character under the mouse.
1878
1a2e6670
EZ
1879 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1880 coordinates reported by pos-visible-in-window-p for a composed
1881 character in column zero.
1882
8b76d6f8
SM
18832011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1884
1885 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1886
dac347dd
EZ
18872011-08-22 Eli Zaretskii <eliz@gnu.org>
1888
1889 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1890 consider it a hit if to_charpos is anywhere in the range of the
1891 composed buffer positions.
1892
e013fb34
CY
18932011-08-22 Chong Yidong <cyd@stupidchicken.com>
1894
1895 * image.c (gif_load): Don't assume that each subimage has the same
1896 dimensions as the base image. Handle disposal method that is
1897 "undefined" by the gif spec (Bug#9335).
1898
bd1ba3e8
CY
18992011-08-20 Chong Yidong <cyd@stupidchicken.com>
1900
1901 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1902 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1903
54a1215b
EZ
19042011-08-19 Eli Zaretskii <eliz@gnu.org>
1905
823564e5
EZ
1906 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1907 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1908 from an Org mode buffer to a Speedbar frame.
1909
54a1215b
EZ
1910 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1911 a composition, take its buffer position from IT->cmp_it.charpos.
1912 Fixes cursor positioning at the beginning of a line that begins
1913 with a composed character.
1914
9778ebcc
EZ
19152011-08-18 Eli Zaretskii <eliz@gnu.org>
1916
0be6ee06
EZ
1917 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1918 character bidirectional type, use STRONG_L instead. Fixes crashes
1919 in a buffer produced by `describe-categories'.
1920
9778ebcc
EZ
1921 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1922 members before the level stack, so they would be saved and
1923 restored when copying iterator state. Fixes incorrect reordering
1924 around TABs covered by display properties.
1925
156bffbe
AS
19262011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1927
6b02f655 1928 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1929
72ad093b
CY
19302011-08-17 Chong Yidong <cyd@stupidchicken.com>
1931
1932 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1933 (internal_condition_case_2, internal_condition_case_n):
1934 Remove unnecessary aborts (Bug#9081).
72ad093b 1935
35774242
EZ
19362011-08-17 Eli Zaretskii <eliz@gnu.org>
1937
1938 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1939 has no `load' handler, try opening the file locally. (Bug#9311)
1940
db76dd85
KB
19412011-08-16 Ken Brown <kbrown@cornell.edu>
1942
1943 * gmalloc.c: Expand comment.
1944
b215eee5
EZ
19452011-08-16 Eli Zaretskii <eliz@gnu.org>
1946
1947 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1948 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1949
a4579d33
KB
19502011-08-16 Ken Brown <kbrown@cornell.edu>
1951
1952 Fix memory allocation problems in Cygwin build (Bug#9273).
1953
1954 * unexcw.c ( __malloc_initialized): Declare external variable.
1955 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1956
8b76d6f8
SM
1957 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1958 New variables.
a4579d33
KB
1959 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1960 dumped emacs.
1961 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1962 in the static heap.
1963 [CYGWIN] (special_realloc): New function.
1964 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1965 requests to realloc storage in the static heap.
1966
3ebec551
PE
19672011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1968
1969 * bidi.c (bidi_initialize): Remove unused local.
1970
9fd8be00
EZ
19712011-08-15 Eli Zaretskii <eliz@gnu.org>
1972
6b02f655
SM
1973 * bidimirror.h:
1974 * biditype.h: Remove file.
1975 * makefile.w32-in ($(BLD)/bidi.$(O)):
1976 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1977
1978 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1979
1980 * chartab.c: Improve commentary for the uniprop_table API.
1981
32413314
EZ
1982 * bidi.c (bidi_paragraph_init): Support zero value of
1983 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1984 (bidi_initialize): Use uniprop_table instead of including
1985 biditype.h and bidimirror.h.
32413314 1986
9fd8be00
EZ
1987 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1988 coordinates of the iterator when restoring from ppos_it.
1989 (Bug#9296)
1990
5cf2b69b
KH
19912011-08-14 Kenichi Handa <handa@m17n.org>
1992
1993 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1994 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1995
daf17d00
EZ
19962011-08-14 Eli Zaretskii <eliz@gnu.org>
1997
1998 * xdisp.c (move_it_in_display_line_to): Don't invoke
1999 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2000 ppos_it. Fixes vertical cursor motion when line beginning is
2001 covered by an image. (Bug#9296)
2002
08e3161a
JD
20032011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2004
2005 * nsterm.h (ns_run_ascript): Declare.
2006 (NSAPP_DATA2_RUNASSCRIPT): Define.
2007
2008 * nsfns.m (as_script, as_result, as_status): New static variables.
2009 (ns_run_ascript): New function.
5e617bc2 2010 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2011 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2012 the event loop. Get status from as_status (Bug#7276).
2013
2014 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2015 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2016 the event loop (Bug#7276).
2017
a3720aa2
AS
20182011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2019
2020 * gnutls.c (QCgnutls_bootprop_priority)
2021 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2022 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2023 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2024 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2025 (QCgnutls_bootprop_verify_hostname_error)
2026 (QCgnutls_bootprop_callbacks_verify): Rename from
2027 Qgnutls_bootprop_..., all uses changed.
2028
2029 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2030 uses changed.
2031
0a0d27fb
PE
20322011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2033
19d5c50c
PE
2034 * xfaces.c (Qframe_set_background_mode): Now static.
2035 * dispextern.h (Qframe_set_background_mode): Remove decl.
2036
0a0d27fb
PE
2037 * process.c (Fnetwork_interface_info): Declare local only if needed.
2038
377538cb
JD
20392011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2040
2041 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2042 (Fnetwork_interface_list): Allocate in increments of bytes instead
2043 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2044 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2045 sockaddr.
2046 (struct ifflag_def): notrailers is smart on OSX.
2047 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2048 Get hardware address with getifaddrs if available.
2049
08fff70c
EZ
20502011-08-12 Eli Zaretskii <eliz@gnu.org>
2051
2052 * xdisp.c (iterate_out_of_display_property): xassert that
2053 IT->position is set to within IT->object's boundaries. Break from
2054 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2055 when IT->position is set up wrongly due to some bug.
2056 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2057 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2058 entry. Force push_it to save on the stack the current
2059 buffer/string position, to be restored by pop_it. Fix flags in
2060 the iterator structure wrt the object coming from a display
2061 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2062 properties. (Bug#9284)
2063
7be1c708 20642011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2065
7be1c708
CY
2066 * fontset.c (fontset_get_font_group): Add proper type checks.
2067 (Bug#9172)
aac0c6e3 2068
7be1c708 20692011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2070
7be1c708
CY
2071 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2072 and LC_VERSION_MIN_MACOSX.
2073 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2074 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2075
97bb72a6
EZ
20762011-08-08 Eli Zaretskii <eliz@gnu.org>
2077
2078 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2079 no-display-properties-and-no-overlays under bidi display.
2080 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2081 properties and overlays.
97bb72a6 2082
d5617611
CY
20832011-08-08 Chong Yidong <cyd@stupidchicken.com>
2084
37e11a63
CY
2085 * editfns.c (Fset_time_zone_rule): Document relationship with the
2086 setenv function.
2087
d5617611
CY
2088 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2089 the font entity extracted from the cache (Bug#8109).
2090
58872834
CY
20912011-08-07 Chong Yidong <cyd@stupidchicken.com>
2092
2093 * composite.c (autocmp_chars): Don't reset point. That is done by
2094 restore_point_unwind (Bug#5984).
2095
75bfc667
JL
20962011-08-07 Juri Linkov <juri@jurta.org>
2097
2098 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2099 to show the arg `TIME' instead of `TIMEVAL'.
2100
d1410150
EZ
21012011-08-06 Eli Zaretskii <eliz@gnu.org>
2102
2103 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2104 display property strides EOL and includes a newline, as in
2105 longlines-mode. (Bug#9254)
75b771e4
EZ
2106 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2107 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2108
2109 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2110 is non-zero, even if the data buffer is NULL. Fixes a crash in
2111 vertical-motion with longlines-mode. (Bug#9254)
2112
35928349
EZ
21132011-08-05 Eli Zaretskii <eliz@gnu.org>
2114
ec7cc85b
EZ
2115 * bidi.c <bidi_cache_total_alloc>: Now static.
2116 (bidi_initialize): Initialize bidi_cache_total_alloc.
2117
8b76d6f8 2118 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2119 cache. (Bug#9221)
2120
2121 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2122 amount allocated this far in `bidi_cache_total_alloc'.
2123 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2124 non-zero, only free the data buffer without restoring the cache
2125 contents. All callers changed.
2126
2127 * dispextern.h (bidi_unshelve_cache): Update prototype.
2128
2129 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2130 (move_it_in_display_line, move_it_to)
2131 (move_it_vertically_backward, move_it_by_lines): Replace the call
2132 to xfree to an equivalent call to bidi_unshelve_cache.
2133 (move_it_in_display_line_to): Fix logic of returning
412b6358 2134 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2135
e2e2423b
EZ
21362011-08-05 Eli Zaretskii <eliz@gnu.org>
2137
2138 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2139 came from a string character with a `cursor' property. (Bug#9229)
2140
ae9e757a
JD
21412011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2142
2143 * Makefile.in (LIB_PTHREAD): New variable.
2144 (LIBES): Add LIB_PTHREAD (Bug#9216).
2145
2146 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2147 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2148
213bd7f2
AS
21492011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2150
6b02f655 2151 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2152
99aaf75f
JD
21532011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2154
2155 * xterm.c (x_find_topmost_parent): New function.
2156 (x_set_frame_alpha): Find topmost parent window with
2157 x_find_topmost_parent and set the property there also (bug#9181).
2158 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2159
c74e9d86
PE
21602011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2161
2162 * callproc.c (Fcall_process): Avoid vfork clobbering
2163 the local vars buffer, coding_systems, current_dir.
2164
640c8776
SM
21652011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2166
2167 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2168
f26d0e4c
PE
21692011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2170
8a10d76c
PE
2171 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2172 so that it is not optimized away.
2173
f26d0e4c
PE
2174 * xdisp.c (compute_display_string_pos): Remove unused local.
2175
55439c61
EZ
21762011-08-02 Eli Zaretskii <eliz@gnu.org>
2177
2178 Fix slow cursor motion and scrolling in large buffers with
2179 selective display, like Org Mode buffers. (Bug#9218)
2180
2181 * dispextern.h (struct bidi_it): New member disp_prop_p.
2182
2183 * xdisp.c: Remove one-slot cache of display string positions.
2184 (compute_display_string_pos): Accept an additional argument
5e617bc2 2185 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2186 for a display string or property. If found, set DISP_PROP_P
2187 non-zero.
2188
2189 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2190 DISP_PROP_P, and pass it to compute_display_string_pos.
2191 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2192 non-zero. All callers of bidi_fetch_char changed.
2193
fb33fa43
SM
21942011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2195
2196 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2197
b099e063
DM
21982010-12-03 Don March <don@ohspite.net>
2199
2200 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2201 last character M-[char] is translated to ESC [char] (bug#7541).
2202
5cc7f7af
KH
22032011-08-02 Kenichi Handa <handa@m17n.org>
2204
d0fffa3f 2205 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2206
2207 * chartab.c (uniprop_table): Make it non-static.
2208
525d5e6e
EZ
22092011-08-01 Eli Zaretskii <eliz@gnu.org>
2210
2211 * xdisp.c (forward_to_next_line_start): Accept additional argument
2212 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2213 on the newline.
2214 (reseat_at_next_visible_line_start): Use the bidi iterator state
2215 returned by forward_to_next_line_start to restore the state of
2216 it->bidi_it after backing up to previous newline. (Bug#9212)
2217
31011111
AS
22182011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2219
2220 * regex.c (re_comp): Protoize.
2221 (re_exec): Fix return type.
2222 (regexec): Fix type of `ret'. (Bug#9203)
2223
476371c4
PE
22242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2225
e5d76069
PE
2226 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2227 This is needed if max-image-size is a floating-point number.
2228
9a79b20c
AS
22292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2230
2231 * print.c (print_object): Print empty symbol as ##.
2232
2233 * lread.c (read1): Read ## as empty symbol.
2234
d8c2fa78
AA
22352011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2236
2237 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2238 setting frame foreground color (Bug#9175).
2239 (x_set_background_color): Likewise.
2240
ffe57a7a
AA
2241 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2242 contents (Bug#9176).
2243 (EmacsTooltip -init): Remove bezels and add shadows to
2244 tooltip windows.
2245
bf3492a5
AA
2246 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2247 or scroll bar (Bug#8470).
2248
d55e9c53
AA
2249 * nsfont.m (nsfont_open): Remove assignment to voffset and
2250 unnecessary vars hshink, expand, hd, full_height, min_height.
2251 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2252
2253 * nsterm.h (nsfont_info): Remove voffset field.
2254
d8c2fa78 22552011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2256
2257 Implement strike-through and overline on NextStep (Bug#8863).
2258
2259 * nsfont.m (nsfont_open): Use underline position provided by font,
2260 instead of hard-coded value of 2.
2261 (nsfont_draw): Call ns_draw_text_decoration instead.
2262
2263 * nsterm.h: Add declaration for ns_draw_text_decoration.
2264
2265 * nsterm.m (ns_draw_text_decoration): New function for drawing
2266 underline, overline, and strike-through.
2267 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2268 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2269 accommodate underlining, etc.
4843aac3 2270
4cc60b9b
EZ
22712011-07-28 Eli Zaretskii <eliz@gnu.org>
2272
bc7ece87
EZ
2273 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2274 default.
4cc60b9b 2275
476371c4
PE
22762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2277
66606eea
PE
2278 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2279 Without this fix, if a signal arrives just after memory fills up,
2280 'malloc' might be invoked reentrantly.
2281
476371c4
PE
2282 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2283 In other words, assume that every image size is allowed, on non-X
2284 hosts. This assumption is probably wrong, but it lets Emacs compile.
2285
f3fcc40d
AS
22862011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2287
2288 * regex.c (re_iswctype): Convert return values to boolean.
2289
350c992f
EZ
22902011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2291
2292 * xdisp.c (compute_display_string_pos): Don't use cached display
2293 string position if the buffer had its restriction changed.
2294 (Bug#9184)
2295
5266b4bb
PE
22962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2297
2298 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2299
2573a837 23002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2301
41f55ccd 2302 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2303
39e378da
PE
2304 * bidi.c: Integer size and overflow fixes.
2305 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2306 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2307 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2308 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2309 (bidi_find_other_level_edge):
2310 Use ptrdiff_t instead of EMACS_INT where either will do.
2311 This works better on 32-bit hosts configured --with-wide-int.
2312 (bidi_cache_ensure_space): Check for size-calculation overflow.
2313 Use % rather than repeated addition, for better worst-case speed.
2314 Don't set bidi_cache_size until after xrealloc returns, because it
2315 might not return.
2316 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2317 (bidi_cache_ensure_space): Also check that the bidi cache size
2318 does not exceed that of the largest Lisp string or buffer. See Eli
2319 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2320
5e927815
PE
2321 * alloc.c (__malloc_size_t): Remove.
2322 All uses replaced by size_t. See Andreas Schwab's note
2323 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2324
ca4aa935
PE
2325 * image.c: Improve checking for integer overflow.
2326 (check_image_size): Assume that f is nonnull, since
2327 it is always nonnull in practice. This is one less thing to
2328 worry about when checking for integer overflow later.
2329 (x_check_image_size): New function, which checks for integer
2330 overflow issues inside X.
2331 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2332 This removes the need for a memory_full check.
2333 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2334 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2335 (xbm_read_bitmap_data): Change locals back to 'int', since
2336 their values must fit in 'int'.
2337 (xpm_load_image, png_load, tiff_load):
2338 Invoke x_create_x_image_and_pixmap earlier,
2339 to avoid much needless work if the image is too large.
2340 (tiff_load): Treat overly large images as if
2341 x_create_x_image_and_pixmap failed, not as malloc failures.
2342 (gs_load): Use x_check_image_size.
2343
5f8f9cc2
PE
2344 * gtkutil.c: Omit integer casts.
2345 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2346 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2347
5adf60bc
PE
2348 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2349
c8907a93
PE
2350 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2351 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2352 would wrongly return t on a 64-bit host.
2353
e3c25c68
PE
2354 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2355 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2356 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2357 and therefore cause GCC to emit a bogus diagnostic in some cases.
2358
3f791afe
PE
2359 * image.c: Integer signedness and overflow and related fixes.
2360 This is not an exhaustive set of fixes, but it's time to
2361 record what I've got.
2362 (lookup_pixel_color, check_image_size): Remove redundant decls.
2363 (check_image_size): Don't assume that arbitrary EMACS_INT values
2364 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2365 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2366 (tiff_load, imagemagick_load_image):
2367 Check for overflow in size calculations.
2368 (x_create_x_image_and_pixmap): Remove unnecessary test for
2369 xmalloc returning NULL; that can't happen.
2370 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2371 (xpm_color_bucket): Use better integer hashing function.
2372 (xpm_cache_color): Don't possibly over-allocate memory.
2373 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2374 (gif_memory_source):
2375 Use ptrdiff_t, not int or size_t, to record sizes.
2376 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2377 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2378 either works, as we prefer signed integers.
2379 (tiff_read_from_memory, tiff_write_from_memory):
2380 Return tsize_t, not size_t, since that's what the TIFF API wants.
2381 (tiff_read_from_memory): Don't fail simply because the read would
2382 go past EOF; instead, return a short read.
2383 (tiff_load): Omit no-longer-needed casts.
2384 (Fimagemagick_types): Don't assume size fits into 'int'.
2385
3cc5a532
PE
2386 Improve hashing quality when configured --with-wide-int.
2387 * fns.c (hash_string): New function, taken from sxhash_string.
2388 Do not discard information about ASCII character case; this
2389 discarding is no longer needed.
2390 (sxhash-string): Use it. Change sig to match it. Caller changed.
2391 * lisp.h: Declare it.
2392 * lread.c (hash_string): Remove, since we now use fns.c's version.
2393 The fns.c version returns a wider integer if --with-wide-int is
2394 specified, so this should help the quality of the hashing a bit.
2395
b312a492
PE
2396 * emacs.c: Integer overflow minor fix.
2397 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2398 Define only if GNU_LINUX.
2399 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2400
dfd153ae
PE
2401 * dispnew.c: Integer signedness and overflow fixes.
2402 Remove unnecessary forward decls, that were a maintenance hassle.
2403 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2404 All uses changed.
2405 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2406 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2407 (prepare_desired_row, line_draw_cost):
2408 Use int, not unsigned, where either works.
2409 (save_current_matrix, restore_current_matrix):
2410 Use ptrdiff_t, not size_t, where either works.
2411 (init_display): Check for overflow more accurately, and without
2412 relying on undefined behavior.
2413
a81d11a3
PE
2414 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2415 Remove, replacing with the new symbols in lisp.h. All uses changed.
2416 * fileio.c (make_temp_name):
2417 * filelock.c (lock_file_1, lock_file):
2418 * xdisp.c (message_dolog):
2419 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2420 Use pMd etc. instead.
2421 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2422 replacing the pWIDE etc. symbols removed from editfns.c.
2423
3300e6fd
PE
2424 * keyboard.h (num_input_events): Now uintmax_t.
2425 This is (very slightly) less likely to mess up due to wraparound.
2426 All uses changed.
2427
fd05c7e9
PE
2428 * buffer.c: Integer signedness fixes.
2429 (alloc_buffer_text, enlarge_buffer_text):
2430 Use ptrdiff_t rather than size_t when either will do, as we prefer
2431 signed integers.
2432
903fe15d
PE
2433 * alloc.c: Integer signedness and overflow fixes.
2434 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2435 (__malloc_size_t): Default to size_t, not to int.
2436 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2437 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2438 Prefer ptrdiff_t to size_t when either would do, as we prefer
2439 signed integers.
2440 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2441 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2442 Now const. Initialize with values that are in range even if char
2443 is signed.
2444 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2445 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2446 These functions do the right thing with sizes > 2**32.
2447 (check_depth): Now ptrdiff_t, not int.
2448 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2449 Adjust to new way of storing sizes. Check for size overflow bugs
2450 in rest of code.
2451 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2452 slightly wrong anyway, as it missed one instance of
2453 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2454 (refill_memory_reserve): Omit needless cast to size_t.
2455 (mark_object_loop_halt): Mark as externally visible.
2456
ac82cc6a
PE
2457 * xselect.c: Integer signedness and overflow fixes.
2458 (Fx_register_dnd_atom, x_handle_dnd_message):
2459 Use ptrdiff_t, not size_t, since we prefer signed.
2460 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2461 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2462 x_dnd_atoms_size and x_dnd_atoms_length.
2463
c2d1e36d
PE
2464 * doprnt.c: Prefer signed to unsigned when either works.
2465 * eval.c (verror):
2466 * doprnt.c (doprnt):
2467 * lisp.h (doprnt):
2468 * xdisp.c (vmessage):
2469 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2470 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2471 prefer signed arithmetic to avoid comparison confusion.
2472 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2473 but is a bit tricky.
2474
0e926e56
PE
2475 Assume freestanding C89 headers, string.h, stdlib.h.
2476 * data.c, doprnt.c, floatfns.c, print.c:
2477 Include float.h unconditionally.
2478 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2479 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2480 * regex.c: Likewise for stddef.h, string.h.
2481 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2482 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2483 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2484 (STDC_HEADERS): Remove obsolete defines.
2485 * sysdep.c: Include limits.h unconditionally.
2486
9cfdb3ec
PE
2487 Assume support for memcmp, memcpy, memmove, memset.
2488 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2489 * regex.c (memcmp, memcpy):
2490 Remove; we assume C89 now.
2491
2492 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2493 (__malloc_safe_bcopy): Remove; no longer needed.
2494
cf950e6b 2495 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2496 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2497 well either way, and we prefer signed to unsigned.
2498
dbf38e02
LMI
24992011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2500
2501 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2502 closes the connection while we're reading (bug#9182).
2503
d6f0886c 25042011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2505
d6f0886c
JD
2506 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2507 are specified (Bug#9168).
24e0f6b1 2508
2eb1f9e6
PE
25092011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2510
2511 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2512 Found by GCC static checking and --with-wide-int on a 32-bit host.
2513
22381272 25142011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2515
2516 * xdisp.c (compute_display_string_pos): Fix logic of caching
2517 previous display string position. Initialize cached_prev_pos to
2518 -1. Fixes slow-down at the beginning of a buffer.
2519
f25e39b4
EZ
25202011-07-24 Eli Zaretskii <eliz@gnu.org>
2521
2522 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2523 for attrs[LFACE_FONTSET_INDEX].
2524
04c4b52e
PE
25252011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2526
2527 * xml.c (parse_region): Remove unused local
2528 that was recently introduced.
2529
c1734fbd
EZ
25302011-07-23 Eli Zaretskii <eliz@gnu.org>
2531
be18c5a5
EZ
2532 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2533 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2534
c1734fbd
EZ
2535 * xdisp.c (move_it_in_display_line_to): Record the best matching
2536 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2537 exit if none of the characters scanned was an exact match.
2538 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2539 when exact match is impossible due to invisible text, and the
2540 lines are truncated.
2541
a258d627
JD
25422011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2543
2544 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2545 for OSX >= 10.7.
2546
b6d5a689
EZ
25472011-07-22 Eli Zaretskii <eliz@gnu.org>
2548
0f74f785
EZ
2549 Fix a significant slow-down of cursor motion with C-n, C-p,
2550 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2551 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2552 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2553 (next_element_from_buffer): Call compute_stop_pos_backwards to
2554 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2555 base_level_stop.
2556 (reseat): Don't look for prev_stop, as that could mean a very long
2557 run.
2558 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2559 <cached_disp_overlay_modiff>: Cache for last found display string
2560 position.
551918c1 2561 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2562 about the same buffer in the same area of character positions, and
2563 the buffer wasn't changed since the time the display string
2564 position was cached.
551918c1 2565
b2d0c91a
EZ
25662011-07-22 Eli Zaretskii <eliz@gnu.org>
2567
2568 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2569 is an integer, which is important for empty lines. (Bug#9149)
2570
043604ee
CY
25712011-07-22 Chong Yidong <cyd@stupidchicken.com>
2572
2573 * frame.c (Fmodify_frame_parameters): In tty case, update the
2574 default face if necessary (Bug#4238).
2575
da4adb04
CY
25762011-07-21 Chong Yidong <cyd@stupidchicken.com>
2577
2578 * editfns.c (Fstring_to_char): No need to explain what a character
2579 is in the docstring (Bug#6576).
2580
9abd0532
LMI
25812011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2582
2583 * xml.c (parse_region): Make sure we always return a tree.
2584
36881d16
HK
25852011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2586
2587 * xml.c (parse_region): If a document contains only comments,
2588 return that, too.
2589
1e98674d
LMI
25902011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2591
2592 * xml.c (make_dom): Return comments, too.
2593
590bd467
PE
25942011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2595
2596 Port to OpenBSD.
2597 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2598 and the surrounding thread.
2599 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2600 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2601 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2602 timer goes off.
2603 * s/openbsd.h (BROKEN_SIGIO): Define.
2604 * unexelf.c (unexec) [__OpenBSD__]:
2605 Don't update the .mdebug section of the Alpha COFF symbol table.
2606
f41628b2
LMI
26072011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2608
2609 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2610 (bug#8460).
2611
b59b67c5
PE
26122011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2613
15e3a074
PE
2614 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2615 This fixes some race conditions on the permissions of any newly
2616 created file.
2617
41bed37d
PE
2618 * alloc.c (valid_pointer_p): Use pipe, not open.
2619 This fixes some permissions issues when debugging.
2620
b59b67c5
PE
2621 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2622 If fchown fails to set both uid and gid, try to set just gid,
2623 as that is sometimes allowed. Adjust the file's mode to eliminate
2624 setuid or setgid bits that are inappropriate if fchown fails.
2625
925a6be7
SM
26262011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2627
2628 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2629 to compare Lisp_Objects.
2630 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2631 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2632 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2633
52968808
AS
26342011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2635
0a6a104b
AS
2636 * lread.c (read_integer): Unread even EOF character.
2637 (read1): Likewise. Properly record start position of symbol.
2638
52968808
AS
2639 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2640 symbol character follows.
2641
9e381cdd
PE
26422011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2643
2644 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2645 This works around a problem with the previous change to Fcopy_file.
2646 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2647 and without this change, GCC might complain about discarding
2648 fchown's return value.
2649
b5641435
JB
26502011-07-16 Juanma Barranquero <lekktu@gmail.com>
2651
2652 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2653
a8031457
PE
26542011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2655
2656 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2657
dd889327
LMI
26582011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2659
750c33f7
LMI
2660 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2661 it's used from the C level.
2662
dd889327
LMI
2663 * process.c: Use the same condition for POLL_FOR_INPUT in both
2664 keyboard.c and process.c (bug#1858).
2665
87e86684
LM
26662011-07-09 Lawrence Mitchell <wence@gmx.li>
2667
2668 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2669 (Fgnutls_boot): Use it.
2670
64348f40
AS
26712011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2672
2673 * doc.c (Fsubstitute_command_keys): Revert last change.
2674
1d698799
LMI
26752011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2676
f863868c
LMI
2677 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2678 quotes the next character, and doesn't affect other longer
2679 sequences (bug#8935).
2680
1d698799
LMI
2681 * lread.c (syms_of_lread): Clarify that is isn't only
2682 `eval-buffer' and `eval-defun' that's affected by
2683 `lexical-binding' (bug#8460).
2684
aa4b6df6
EZ
26852011-07-15 Eli Zaretskii <eliz@gnu.org>
2686
2687 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2688 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2689
5d856da6
PE
26902011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2691
ad6042bb
PE
2692 Fix minor problems found by static checking.
2693 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2694 (elsz): Now a signed constant, not a size_t var. We prefer signed
2695 types to unsigned, to avoid integer comparison confusion. Without
2696 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2697 "cannot optimize loop, the loop counter may overflow", a symptom
2698 of the confusion.
f00bbb22 2699 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2700 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2701
6468f31c
LMI
27022011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2703
49080b10
LMI
2704 * search.c (Fre_search_backward): Mention `case-fold-search' in
2705 all the re_search_* functions (bug#8138).
2706
6468f31c
LMI
2707 * keyboard.c (Fopen_dribble_file): Document when the file is
2708 closed (bug#8056).
2709
c965adc5
EZ
27102011-07-14 Eli Zaretskii <eliz@gnu.org>
2711
df9733bf
EZ
2712 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2713 bidi_cache_idx.
2714
0bb23927
EZ
2715 Support bidi reordering of display and overlay strings.
2716 * xdisp.c (compute_display_string_pos)
2717 (compute_display_string_end): Accept additional argument STRING.
2718 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2719 (reseat_to_string): Initialize bidi_it->string.s and
2720 bidi_it->string.schars.
2721 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2722 NULL (avoids a crash in bidi_paragraph_init).
2723 Initialize itb.string.lstring.
0bb23927
EZ
2724 (init_iterator): Call bidi_init_it only of a valid
2725 buffer position was specified. Initialize paragraph_embedding to
2726 L2R.
2727 (reseat_to_string): Initialize the bidi iterator.
2728 (display_string): If we need to ignore text properties of
2729 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2730 original value of -1 will not work with bidi.)
2731 (compute_display_string_pos): First arg is now struct
2732 `text_pos *'; all callers changed. Support display properties on
2733 Lisp strings.
2734 (compute_display_string_end): Support display properties on Lisp
2735 strings.
2736 (init_iterator, reseat_1, reseat_to_string): Initialize the
2737 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2738 when iterating on a string not from display properties).
640c8776
SM
2739 (compute_display_string_pos, compute_display_string_end):
2740 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2741 arrow keys.
2742 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2743 base_level_stop; instead, set base_level_stop to BEGV.
2744 Fixes crashes in vertical-motion.
0bb23927
EZ
2745 (next_element_from_buffer): Improve commentary for when
2746 the iterator is before prev_stop.
2747 (init_iterator): Initialize bidi_p from the default value of
2748 bidi-display-reordering, not from buffer-local value. Use the
2749 buffer-local value only if initializing for buffer iteration.
2750 (handle_invisible_prop): Support invisible properties on strings
2751 that are being bidi-reordered.
2752 (set_iterator_to_next): Support bidi reordering of C strings and
2753 Lisp strings.
2754 (next_element_from_string): Support bidi reordering of Lisp
2755 strings.
2756 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2757 (display_string): Support display of R2L glyph rows.
2758 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2759 (init_iterator): Don't initialize it->bidi_p for strings
2760 here.
2761 (reseat_to_string): Initialize it->bidi_p for strings here.
2762 (next_element_from_string, next_element_from_c_string)
2763 (next_element_from_buffer): Add xassert's for correspondence
2764 between IT's object being iterated and it->bidi_it.string
2765 structure.
2766 (face_before_or_after_it_pos): Support bidi iteration.
2767 (next_element_from_c_string): Handle the case of the first string
2768 character that is not the first one in the visual order.
2769 (get_visually_first_element): New function, refactored from common
2770 parts of next_element_from_buffer, next_element_from_string, and
2771 next_element_from_c_string.
2772 (tool_bar_lines_needed, redisplay_tool_bar)
2773 (display_menu_bar): Force left-to-right direction. Add a FIXME
2774 comment for making that be controlled by a user option.
2775 (push_it, pop_it): Save and restore the state of the
2776 bidi iterator. Save and restore the bidi_p flag.
2777 (pop_it): Iterate out of display property for string iteration as
2778 well.
2779 (iterate_out_of_display_property): Support iteration over strings.
2780 (handle_single_display_spec): Set up it->bidi_it for iteration
2781 over a display string, and call bidi_init_it.
2782 (handle_single_display_spec, next_overlay_string)
2783 (get_overlay_strings_1, push_display_prop): Set up the bidi
2784 iterator for displaying display or overlay strings.
2785 (forward_to_next_line_start): Don't use the shortcut if
2786 bidi-iterating.
2787 (back_to_previous_visible_line_start): If handle_display_prop
2788 pushed the iterator stack, restore the internal state of the bidi
2789 iterator by calling bidi_pop_it same number of times.
2790 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2791 and we are bidi-iterating, don't decrement the iterator position;
2792 instead, set the first_elt flag in the bidi iterator, to produce
2793 the same effect.
2794 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2795 (push_display_prop): xassert that we are iterating a buffer.
2796 (push_it, pop_it): Save and restore paragraph_embedding member.
2797 (handle_single_display_spec, next_overlay_string)
2798 (get_overlay_strings_1, reseat_1, reseat_to_string)
2799 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2800 correctly. Don't assume unibyte strings are not bidi-reordered.
2801 (compute_display_string_pos)
2802 (compute_display_string_end): Fix handling the case of C string.
2803 (push_it, pop_it): Save and restore from_disp_prop_p.
2804 (handle_single_display_spec, push_display_prop): Set the
2805 from_disp_prop_p flag.
2806 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2807 (pop_it): Call iterate_out_of_display_property only if we are
2808 popping after iteration over a string that came from a display
2809 property. Fix a typo in popping stretch info. Add an assertion
2810 for verifying that the iterator position is in sync with the bidi
2811 iterator.
2812 (handle_single_display_spec, get_overlay_strings_1)
2813 (push_display_prop): Fix initialization of paragraph direction for
2814 string when that of the parent object is not yet determined.
2815 (reseat_1): Call bidi_init_it to resync the bidi
2816 iterator with IT's position. (Bug#7616)
2817 (find_row_edges): If ROW->start.pos gives position
2818 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2819 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2820 Reset the from_disp_prop_p flag.
2821 (SAVE_IT, RESTORE_IT): New macros.
2822 (pos_visible_p, face_before_or_after_it_pos)
2823 (back_to_previous_visible_line_start)
2824 (move_it_in_display_line_to, move_it_in_display_line)
2825 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2826 (try_scrolling, redisplay_window, display_line): Use them when
2827 saving a temporary copy of the iterator and restoring it back.
2828 (back_to_previous_visible_line_start, reseat_1)
2829 (init_iterator): Empty the bidi cache "stack".
2830 (move_it_in_display_line_to): If iterator ended up at
2831 EOL, but we never saw any buffer positions smaller than
2832 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2833 motion in bidi-reordered lines.
2834 (move_it_in_display_line_to): Record prev_method and prev_pos
2835 immediately before the call to set_iterator_to_next. Fixes cursor
2836 motion in bidi-reordered lines with stretch glyphs and strings
2837 displayed in margins. (Bug#8133) (Bug#8867)
2838 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2839 TO_CHARPOS.
640c8776
SM
2840 (pos_visible_p): Support positions in bidi-reordered lines.
2841 Save and restore bidi cache.
0bb23927
EZ
2842
2843 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2844 (bidi_paragraph_info): Delete unused struct.
2845 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2846 (bidi_cache_start): New variable.
2847 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2848 to zero.
2849 (bidi_cache_fetch_state, bidi_cache_search)
2850 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2851 (bidi_cache_find, bidi_peek_at_next_level)
2852 (bidi_level_of_next_char, bidi_find_other_level_edge)
2853 (bidi_move_to_visually_next): Compare cache index with
2854 bidi_cache_start rather than with zero.
2855 (bidi_fetch_char): Accept new argument STRING; all callers
2856 changed. Support iteration over a string. Support strings with
2857 display properties. Support unibyte strings. Fix the type of
2858 `len' according to what STRING_CHAR_AND_LENGTH expects.
2859 (bidi_paragraph_init, bidi_resolve_explicit_1)
2860 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2861 (bidi_level_of_next_char, bidi_move_to_visually_next):
2862 Support iteration over a string.
0bb23927
EZ
2863 (bidi_set_sor_type, bidi_resolve_explicit_1)
2864 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2865 can now be zero (for strings); special values 0 and -1 were
2866 changed to -1 and -2, respectively.
2867 (bidi_char_at_pos): New function.
2868 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2869 Call it instead of FETCH_MULTIBYTE_CHAR.
2870 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2871 initialized to valid values.
2872 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2873 values.
2874 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2875 the test for valid cached positions. Fix the logic for looking up
2876 the sentinel state in the cache. GCPRO the Lisp string we are
2877 iterating.
2878 (bidi_push_it, bidi_pop_it): New functions.
2879 (bidi_initialize): Initialize the bidi cache start stack pointer.
2880 (bidi_cache_ensure_space): New function, refactored from part of
2881 bidi_cache_iterator_state. Don't assume the required size is just
2882 one BIDI_CACHE_CHUNK away.
2883 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2884 (bidi_count_bytes, bidi_char_at_pos): New functions.
2885 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2886 always valid if bidi_cache_idx is valid.
2887 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2888 is valid if it's going to be used.
2889 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2890 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2891 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2892 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2893 (bidi_find_other_level_edge, bidi_cache_start_stack):
2894 All variables related to cache indices are now EMACS_INT.
c965adc5 2895
0bb23927
EZ
2896 * dispextern.h (struct bidi_string_data): New structure.
2897 (struct bidi_it): New member `string'. Make flag members be 1-bit
2898 fields, and put them last in the struct.
640c8776
SM
2899 (compute_display_string_pos, compute_display_string_end):
2900 Update prototypes.
0bb23927
EZ
2901 (bidi_push_it, bidi_pop_it): Add prototypes.
2902 (struct iterator_stack_entry): New members bidi_p,
2903 paragraph_embedding, and from_disp_prop_p.
2904 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2905 (bidi_shelve_cache, bidi_unshelve_cache):
2906 Declare prototypes.
0bb23927
EZ
2907
2908 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2909 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2910 and vector-like objects.
2911
2912 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2913 cache around display iteration.
2914
2915 * window.c (Fwindow_end, window_scroll_pixel_based)
2916 (displayed_window_lines, Frecenter): Save and restore the bidi
2917 cache around display iteration.
2918
3bbd2265
LMI
29192011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2920
2921 * editfns.c (Fdelete_region): Clarify the use of the named
2922 parameters (bug#6788).
2923
adc47434
MR
29242011-07-14 Martin Rudalics <rudalics@gmx.at>
2925
2926 * indent.c (Fvertical_motion): Set and restore w->pointm when
2927 saving and restoring the window's buffer (Bug#9006).
2928
837c31f8
LMI
29292011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2930
2931 * editfns.c (Fstring_to_char): Clarify just what is returned
2932 (bug#6576). Text by Eli Zaretskii.
2933
ac389d0c
JB
29342011-07-13 Juanma Barranquero <lekktu@gmail.com>
2935
2936 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2937
0be0ce47
EZ
29382011-07-13 Eli Zaretskii <eliz@gnu.org>
2939
2940 * buffer.c (mmap_find): Fix a typo.
2941
cd18e7e3
JB
29422011-07-13 Johan Bockgård <bojohan@gnu.org>
2943
2944 Fix execution of x selection hooks.
2945 * xselect.c (Qx_lost_selection_functions)
2946 (Qx_sent_selection_functions): New vars.
2947 (syms_of_xselect): DEFSYM them.
2948 (x_handle_selection_request): Pass Qx_sent_selection_functions
2949 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2950 (x_handle_selection_clear,x_clear_frame_selections):
2951 Pass Qx_lost_selection_functions rather than
2952 Vx_lost_selection_functions to Frun_hook_with_args.
2953
47ea7f44
PE
29542011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2955
ac389d0c 2956 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2957 The old code sometimes used this field without initializing it.
2958
47ea7f44
PE
2959 * alloc.c (gc_sweep): Don't read past end of array.
2960 In theory, the old code could also have corrupted Emacs internals,
2961 though it'd be very unlikely.
2962
bc985c87
AS
29632011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2964
2965 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2966 argument. (Bug#4026)
bc985c87 2967
0cf34688
LMI
29682011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2969
b3dadd76
LMI
2970 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2971 key" (bug#4257).
2972
0cf34688
LMI
2973 * window.c (Fset_window_start): Doc fix (bug#4199).
2974 (Fset_window_hscroll): Ditto.
2975
270768cd
PE
29762011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2977
077e3dda 2978 Fix minor new problems caught by GCC 4.6.1.
270768cd 2979 * term.c (init_tty): Remove unused local.
490011a6 2980 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2981 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2982 not used otherwise.
270768cd 2983
b1f58454
CY
29842011-07-12 Chong Yidong <cyd@stupidchicken.com>
2985
2986 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2987
22b9578d
LMI
29882011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2989
6e70ab07
LMI
2990 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2991 are the mini-buffer and the echo area (bug#3320).
2992
22b9578d
LMI
2993 * term.c (init_tty): Remove support for supdup, c10 and perq
2994 terminals, which are no longer supported (bug#1482).
2995
8974cc9f
JB
29962011-07-10 Johan Bockgård <bojohan@gnu.org>
2997
2998 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2999
a560d974
JD
30002011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3001
3002 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3003 for non-popups (Bug#3642).
3004
1dae0f0a
AS
30052011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3006
268c2c36 3007 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3008 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3009 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3010 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3011 * data.c (fmod): Likewise.
3012 * dispnew.c (swap_glyphs_in_rows): Likewise.
3013 * emacs.c (memory_warning_signal): Likewise.
3014 * floatfns.c (float_error): Likewise.
3015 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3016 (otf_open, font_otf_capability, generate_otf_features)
3017 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3018 Likewise.
3019 * image.c (pbm_read_file): Likewise.
3020 * indent.c (string_display_width): Likewise.
3021 * intervals.c (check_for_interval, search_for_interval)
3022 (inc_interval_count, count_intervals, root_interval)
3023 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3024 * lread.c (defalias): Likewise.
268c2c36 3025 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3026 * regex.c (set_image_of_range_1, set_image_of_range)
3027 (regex_grow_registers): Likewise.
3028 * sysdep.c (strerror): Likewise.
3029 * termcap.c (valid_filename_p, tprint, main): Likewise.
3030 * tparam.c (main): Likewise.
3031 * unexhp9k800.c (run_time_remap, save_data_space)
3032 (update_file_ptrs, read_header, write_header, calculate_checksum)
3033 (copy_file, copy_rest, display_header): Likewise.
3034 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3035 Likewise.
3036 * xdisp.c (check_it): Likewise.
3037 * xfaces.c (register_color, unregister_color, unregister_colors):
3038 Likewise.
3039 * xfns.c (print_fontset_result): Likewise.
3040 * xrdb.c (member, fatal, main): Likewise.
3041
99033785
PE
30422011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3043
3044 Fix minor problems found by static checking (Bug#9031).
3045 * chartab.c (char_table_set_range, map_sub_char_table):
3046 Remove unused locals.
3047 (uniprop_table): Now static.
3048 * composite.c (_work_char): Remove unused static var.
3049
9cb2ac56
JB
30502011-07-09 Juanma Barranquero <lekktu@gmail.com>
3051
3052 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3053
f25661f0
JD
30542011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3055
3056 * gtkutil.c (qttip_cb): Remove code without function.
3057
8278c4fe
EZ
30582011-07-09 Eli Zaretskii <eliz@gnu.org>
3059
3060 * w32.c (pthread_sigmask): New stub.
3061
1692ae2d 30622011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3063
8a6ebd58 3064 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3065 sigprocmask is portable only for single-threaded applications, and
3066 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3067 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3068 (LIBES): Use it.
3069 * callproc.c (Fcall_process):
3070 * process.c (create_process):
3071 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3072 Use pthread_sigmask, not sigprocmask.
123403e4 3073
1b854618
JD
30742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3075
3076 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3077 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3078 wrong (Bug#8591).
3079
3fe4b549
JD
30802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3081
0ce7e563
JD
3082 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3083 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3084 (xg_hide_tooltip): Fix comment.
3085
3fe4b549
JD
3086 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3087 in registerServicesMenuSendTypes.
3088 (validRequestorForSendType): Don't check ns_return_types.
3089
3090 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3091 ns_return_type.
3092
5df75e47
JR
30932011-07-08 Jason Rumney <jasonr@gnu.org>
3094
22610910
JR
3095 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3096 SH_SHOW for hidden windows (Bug#5482).
3097
5df75e47
JR
3098 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3099 frame struct members of non-existent frames (Bug#6284).
3100
699c10bd
JD
31012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3102
4393663b
JD
3103 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3104 variable firstTime not needed on OSX >= 10.6.
3105 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3106 >= 10.5. Use setKnobProportion, setDoubleValue.
3107
3108 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3109 (MAC_OS_X_VERSION_10_5): Define if not defined.
3110 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3111 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3112 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3113
3114 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3115 cString and lossyCString on OSX >= 10.4
3116
58179cce 3117 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3118 sizeToFit on OSX >= 10.2.
3119
3120 * nsimage.m (allocInitFromFile): Don't use deprecated method
3121 bestRepresentationForDevice on OSX >= 10.6.
3122
3123 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3124 to avoid warning.
3125
3126 * emacs.c: Declare unexec_init_emacs_zone.
3127
a63e0781
JD
3128 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3129
699c10bd
JD
3130 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3131
3132 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3133 on svcsMenu (Bug#8842).
3134
3135 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3136 ns_return_types.
3137 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3138
3139 * nsterm.m (QUTF8_STRING): Declare.
3140 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3141 (validRequestorForSendType): Return type is (id).
3142 Change indexOfObjectIdenticalTo to indexOfObject.
3143 Check if we have local selection before returning self (Bug#8842).
3144 (writeSelectionToPasteboard): Put local selection into paste board
3145 if we have a local selection (Bug#8842).
3146 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3147
3148 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3149 (ns_get_local_selection): Declare.
3150
54e10184
LMI
31512011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3152
9888ff71
LMI
3153 * keymap.c (describe_map_tree): Don't insert a double newline at
3154 the end of the buffer (bug#1169) and return whether we inserted
3155 something.
3156
54e10184
LMI
3157 * callint.c (Fcall_interactively): Change "reading args" to
3158 "providing args" to try to clarify what it does (bug#1010).
3159
15fa4783
KH
31602011-07-07 Kenichi Handa <handa@m17n.org>
3161
3162 * composite.c (composition_compute_stop_pos): Ignore a static
3163 composition starting before CHARPOS (Bug#8915).
3164
3165 * xdisp.c (handle_composition_prop): Likewise.
3166
a8815b00
EZ
31672011-07-07 Eli Zaretskii <eliz@gnu.org>
3168
3169 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3170 (Bug#9015)
3171
ef7b981d 31722011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3173
3174 * character.h (unicode_category_t): New enum type.
3175
3176 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3177 (Qchar_code_property_table): New variable.
3178 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3179 (UNIPROP_COMPRESSED_FORM_P): New macros.
3180 (char_table_ascii): Uncompress the compressed values.
3181 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3182 Uncompress the compressed values.
ac389d0c 3183 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3184 (char_table_ref_and_range): Uncompress the compressed values.
3185 (sub_char_table_set): New arg is_uniprop. Callers changed.
3186 Uncompress the compressed values.
3187 (sub_char_table_set_range): Args changed. Callers changed.
3188 (char_table_set_range): Adjuted for the above change.
3189 (map_sub_char_table): Delete args default_val and parent. Add arg
3190 top. Give decoded values to a Lisp function.
640c8776 3191 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3192 values to a Lisp function. Gcpro more variables.
3193 (uniprop_table_uncompress)
3194 (uniprop_decode_value_run_length): New functions.
3195 (uniprop_decoder, uniprop_decoder_count): New variables.
3196 (uniprop_get_decoder, uniprop_encode_value_character)
3197 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3198 New functions.
3199 (uniprop_encoder, uniprop_encoder_count): New variables.
3200 (uniprop_get_encoder, uniprop_table)
3201 (Funicode_property_table_internal, Fget_unicode_property_internal)
3202 (Fput_unicode_property_internal): New functions.
3203 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3204 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3205 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3206 char-code-property-alist.
3207
640c8776 3208 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3209 Vunicode_category_table.
3210
640c8776 3211 * font.c (font_range): Adjust for the change of
c805dec0
KH
3212 Vunicode_category_table.
3213
76b397fb
DN
32142011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3215
3216 * m/iris4d.h: Remove file, move contents ...
3217 * s/irix6-5.h: ... here.
3218
22b4128e
PE
32192011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3220
3221 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3222 * alloc.c (mark_buffer):
3223 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3224 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3225 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3226 This isn't true in general, and it's particularly not true
3227 if Emacs is configured with --with-wide-int.
3228 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3229 New macros, used in the buffer.c change.
3230
869795d6
JD
32312011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3232
3233 * xsettings.c: Use both GConf and GSettings if both are available.
3234 (store_config_changed_event): Add comment.
3235 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3236 (store_tool_bar_style_changed): New functions.
5e617bc2 3237 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3238 (struct xsettings): Move font inside HAVE_XFT.
3239 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3240 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3241 Move inside HAVE_XFT.
640c8776 3242 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3243 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3244 also.
3245 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3246 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3247 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3248 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3249 (parse_settings): Move check for font inside HAVE_XFT.
3250 (read_settings, apply_xft_settings): Add comment.
3251 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3252 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3253 call store_font_name_changed.
3254 (xft_settings_event): Add comment.
3255 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3256 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3257 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3258 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3259 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3260 (xsettings_get_system_font, xsettings_get_system_normal_font):
3261 Add comment.
869795d6 3262
d8ed26bd
PE
32632011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3264
3265 Random fixes. E.g., (random) never returned negative values.
3266 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3267 subseconds part to the entropy, as that's a bit more random.
3268 Prefer signed to unsigned, since the signedness doesn't matter and
3269 in general we prefer signed. When given a limit, use a
3270 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3271 latter isn't right if USE_2_TAGS_FOR_INTS.
3272 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3273 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3274
cabf1cac
SM
32752011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3276
3277 * textprop.c (text_property_stickiness):
3278 Obey Vtext_property_default_nonsticky.
3279 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3280 * w32fns.c (syms_of_w32fns):
3281 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3282
6e9b2be9
PE
32832011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3284
3285 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3286 This is more efficient than Ffile_directory_p and avoids a minor race.
3287
90186c68
LMI
32882011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3289
7c301272
LMI
3290 * buffer.c (Foverlay_put): Say what the return value is
3291 (bug#7835).
3292
c4f2d8d4
LMI
3293 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3294 is a directory before asking whether to use the file name
3295 (bug#7564).
ad637907
LMI
3296 (barf_or_query_if_file_exists): Make the "File is a directory"
3297 error be more correct.
c4f2d8d4 3298
90186c68
LMI
3299 * fns.c (Frequire): Remove the mention of the .gz files, since
3300 that's installation-specific, but keep the mention of
3301 `get-load-suffixes'.
3302
da64016e
PE
33032011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3304
3305 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3306 Report string overflow if the output is too long.
3307
7d47b580
JB
33082011-07-04 Juanma Barranquero <lekktu@gmail.com>
3309
a555cb87
JB
3310 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3311 (syms_of_gnutls): Remove duplicate DEFSYM for
3312 Qgnutls_bootprop_verify_hostname_error, an error for
3313 Qgnutls_bootprop_verify_error (which is no longer used).
3314
7d47b580
JB
3315 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3316 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3317 Also (re)move comments that are misplaced or no longer relevant.
3318
1e49bfab
LMI
33192011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3320
3321 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3322
1485f4c0
CY
33232011-07-03 Chong Yidong <cyd@stupidchicken.com>
3324
3325 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3326 and background color parameters if they have been changed.
3327
a9ab721e
LMI
33282011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3329
3330 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3331
cf7cff57
PE
33322011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3333
2e13213d
PE
3334 * xsettings.c (SYSTEM_FONT): Define only when used.
3335 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3336
cf7cff57
PE
3337 * keymap.c (access_keymap_1): Now static.
3338
7a8e04f7
CY
33392011-07-02 Chong Yidong <cyd@stupidchicken.com>
3340
3341 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3342 leave any prefix arg for the up event (Bug#1586).
3343
61352f62
LMI
33442011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3345
69bb1ef7
LMI
3346 * lread.c (syms_of_lread): Mention single symbols defined by
3347 `defvar' or `defconst' (bug#7154).
3348
61352f62 3349 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3350 (Frequire): Mention get-load-suffixes.
61352f62 3351
28545e04
MR
33522011-07-02 Martin Rudalics <rudalics@gmx.at>
3353
3354 * window.h (window): Remove clone_number slot.
3355 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3356 Remove.
3357 (make_parent_window, make_window, saved_window)
3358 (Fset_window_configuration, save_window_save): Don't deal with
3359 clone numbers.
3360 * buffer.c (Qclone_number): Remove declaration.
3361 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3362
3349e122
SM
33632011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3364
3365 Add multiple inheritance to keymaps.
3366 * keymap.c (Fmake_composed_keymap): New function.
3367 (Fset_keymap_parent): Simplify.
3368 (fix_submap_inheritance): Remove.
3369 (access_keymap_1): New function extracted from access_keymap to handle
3370 embedded parents and handle lists of maps.
3371 (access_keymap): Use it.
3372 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3373 (Fcopy_keymap): Handle embedded parents.
3374 (Fcommand_remapping, define_as_prefix): Simplify.
3375 (Fkey_binding): Simplify.
3376 (syms_of_keymap): Move minibuffer-local-completion-map,
3377 minibuffer-local-filename-completion-map,
3378 minibuffer-local-must-match-map, and
3379 minibuffer-local-filename-must-match-map to Elisp.
3380 (syms_of_keymap): Defsubr make-composed-keymap.
3381 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3382 (parse_menu_item): Trivial simplification.
3383
3279eb87
GM
33842011-07-01 Glenn Morris <rgm@gnu.org>
3385
3386 * Makefile.in (SETTINGS_LIBS): Fix typo.
3387
4550efdf
KI
33882011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3389
3390 * coding.c (Fencode_coding_string): Record the last coding system
3391 used, as the function doc string says (bug#8738).
3392
0949d2b6
JD
33932011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3394
3395 * xsettings.c (store_monospaced_changed): Take new font as arg and
3396 check for change against current_mono_font.
3397 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3398 (emacs_settings_constructor, emacs_settings_get_property)
3399 (emacs_settings_set_property, emacs_settings_class_init)
3400 (emacs_settings_init, gsettings_obj): Remove.
3401 (something_changedCB): New function for HAVE_GSETTINGS.
3402 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3403 with value as argument.
3404 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3405 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3406 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3407 "changed".
3408
3409 * xgselect.c: Add defined (HAVE_GSETTINGS).
3410 (xgselect_initialize): Ditto.
3411
3412 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3413 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3414 xg_select.
3415
bbc6b304
PE
34162011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3417
3418 * eval.c (struct backtrace): Simplify and port the data structure.
3419 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3420 signed bit field, as this assumption is not portable and it makes
3421 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3422 "char debug_on_exit : 1" as this is not portable either; instead,
3423 use the portable "unsigned int debug_on_exit : 1". Remove unused
3424 member evalargs. Remove obsolete comments about cc bombing out.
3425
9851bfc5
JD
34262011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3427
51bb811f 3428 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3429 Let HAVE_GSETTINGS override HAVE_GCONF.
3430 (store_monospaced_changed): New function.
3431 (EMACS_SETTINGS): A new type derived from GObject to handle
3432 GSettings notifications.
3433 (emacs_settings_constructor, emacs_settings_get_property)
3434 (emacs_settings_set_property, emacs_settings_class_init):
3435 New functions.
3436 (gsettings_client, gsettings_obj): New variables.
3437 (GSETTINGS_SCHEMA): New define.
3438 (something_changedCB): Call store_monospaced_changed.
3439 (init_gsettings): New function.
3440 (xsettings_initialize): Call init_gsettings.
3441 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3442 to NULL.
3443
640c8776 3444 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3445 GCONF_CFLAGS/LIBS.
3446
5386012d
MR
34472011-06-29 Martin Rudalics <rudalics@gmx.at>
3448
3449 * window.c (resize_root_window, grow_mini_window)
3450 (shrink_mini_window): Rename Qresize_root_window to
3451 Qwindow_resize_root_window and Qresize_root_window_vertically to
3452 Qwindow_resize_root_window_vertically.
3453
f13e0b08
PE
34542011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3455
3456 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3457
94515237
JB
34582011-06-27 Juanma Barranquero <lekktu@gmail.com>
3459
3460 * makefile.w32-in: Redesign dependencies so they reflect more
3461 clearly which files are directly included by each source file,
3462 and not through other includes.
3463
e43b6e43
MR
34642011-06-27 Martin Rudalics <rudalics@gmx.at>
3465
3466 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3467 (sort_overlays, overlay_strings): When an overlay's clone number
3468 matches the window's clone number process the overlay even if
3469 the overlay's window property doesn't match the current window.
3470
d68443dc
MR
3471 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3472 (Fwindow_hchild): Rename to Fwindow_left_child.
3473 (Fwindow_next): Rename to Fwindow_next_sibling.
3474 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3475 (resize_window_check): Rename to window_resize_check.
3476 (resize_window_apply): Rename to window_resize_apply.
3477 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3478 (Fdelete_other_windows_internal, resize_frame_windows)
3479 (Fsplit_window_internal, Fdelete_window_internal)
3480 (grow_mini_window, shrink_mini_window)
3481 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3482
c7e73be5
JD
34832011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3484
3485 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3486 (emacs_fixed_set_min_size): Remove.
3487 (emacs_fixed_new): Take frame as argument.
3488
3489 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3490 (_EmacsFixedPrivate): Remove minwidth/height.
3491 Add struct frame *f.
3492 (emacs_fixed_init): Initialize priv->f.
3493 (get_parent_class, emacs_fixed_set_min_size): Remove.
3494 (emacs_fixed_new): Set priv->f to argument.
3495 (emacs_fixed_get_preferred_width)
3496 (emacs_fixed_get_preferred_height): Use min_width/height from
3497 frames size_hint to set minimum and natural (Bug#8919).
3498 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3499 and use min_width/height from frames size_hint to set
3500 min_width/height (Bug#8919).
3501
3502 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3503 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3504 Fix indentation.
c7e73be5 3505
cf99dcf8
EZ
35062011-06-26 Eli Zaretskii <eliz@gnu.org>
3507
3508 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3509 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3510 called at ZV.
3511
029529ac
CY
35122011-06-26 Chong Yidong <cyd@stupidchicken.com>
3513
3514 * process.c (wait_reading_process_output): Bypass select if
3515 waiting for a cell while ignoring keyboard input, and input is
3516 pending. Suggested by Jan Djärv (Bug#8869).
3517
7a7ef429
PE
35182011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3519
3520 Use gnulib's dup2 module instead of rolling our own.
3521 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3522
11fdef7d 35232011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3524
3525 * dispnew.c (scrolling_window): Before scrolling, turn off a
3526 mouse-highlight in the window being scrolled.
3527
cd3520a4
JB
35282011-06-24 Juanma Barranquero <lekktu@gmail.com>
3529
3530 Move DEFSYM to lisp.h and use everywhere.
3531
3532 * character.h (DEFSYM): Move declaration...
3533 * lisp.h (DEFSYM): ...here.
3534
3535 * gnutls.c:
3536 * minibuf.c:
3537 * w32menu.c:
3538 * w32proc.c:
3539 * w32select.c: Don't include character.h.
3540
3541 * alloc.c (syms_of_alloc):
3542 * buffer.c (syms_of_buffer):
3543 * bytecode.c (syms_of_bytecode):
3544 * callint.c (syms_of_callint):
3545 * casefiddle.c (syms_of_casefiddle):
3546 * casetab.c (init_casetab_once):
3547 * category.c (init_category_once, syms_of_category):
3548 * ccl.c (syms_of_ccl):
3549 * cmds.c (syms_of_cmds):
3550 * composite.c (syms_of_composite):
3551 * dbusbind.c (syms_of_dbusbind):
3552 * dired.c (syms_of_dired):
3553 * dispnew.c (syms_of_display):
3554 * doc.c (syms_of_doc):
3555 * editfns.c (syms_of_editfns):
3556 * emacs.c (syms_of_emacs):
3557 * eval.c (syms_of_eval):
3558 * fileio.c (syms_of_fileio):
3559 * fns.c (syms_of_fns):
3560 * frame.c (syms_of_frame):
3561 * fringe.c (syms_of_fringe):
3562 * insdel.c (syms_of_insdel):
3563 * keymap.c (syms_of_keymap):
3564 * lread.c (init_obarray, syms_of_lread):
3565 * macros.c (syms_of_macros):
3566 * msdos.c (syms_of_msdos):
3567 * print.c (syms_of_print):
3568 * process.c (syms_of_process):
3569 * search.c (syms_of_search):
3570 * sound.c (syms_of_sound):
3571 * syntax.c (init_syntax_once, syms_of_syntax):
3572 * terminal.c (syms_of_terminal):
3573 * textprop.c (syms_of_textprop):
3574 * undo.c (syms_of_undo):
3575 * w32.c (globals_of_w32):
3576 * window.c (syms_of_window):
3577 * xdisp.c (syms_of_xdisp):
3578 * xfaces.c (syms_of_xfaces):
3579 * xfns.c (syms_of_xfns):
3580 * xmenu.c (syms_of_xmenu):
3581 * xsettings.c (syms_of_xsettings):
3582 * xterm.c (syms_of_xterm): Use DEFSYM.
3583
4228cf16
TZ
35842011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3585
cd3520a4 3586 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3587
7fcccf1e
PE
35882011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3589
7efb4e0e
PE
3590 Integer and buffer overflow fixes (Bug#8873).
3591
ff5844ad
PE
3592 * print.c (printchar, strout): Check for string overflow.
3593 (PRINTPREPARE, printchar, strout):
3594 Don't set size unless allocation succeeds.
3595
90532f02
PE
3596 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3597 for sizes. Check for string overflow more accurately.
3598 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3599
6d84508d
PE
3600 * macros.c: Integer and buffer overflow fixes.
3601 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3602 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3603 Use ptrdiff_t, not int, for sizes.
3604 Don't increment bufsize until after realloc succeeds.
3605 Check for size-calculation overflow.
3606 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3607
437b2cb4
PE
3608 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3609
8b9ac8b4
PE
3610 * lread.c: Integer overflow fixes.
3611 (read_integer): Radix is now EMACS_INT, not int,
3612 to improve quality of diagnostics for out-of-range radices.
3613 Calculate buffer size correctly for out-of-range radices.
3614 (read1): Check for integer overflow in radices, and in
3615 read-circle numbers.
82cb60d3
PE
3616 (read_escape): Avoid int overflow.
3617 (Fload, openp, read_buffer_size, read1)
3618 (substitute_object_recurse, read_vector, read_list, map_obarray):
3619 Use ptrdiff_t, not int, for sizes.
3620 (read1): Use EMACS_INT, not int, for sizes.
20270765 3621 Check for size overflow.
8b9ac8b4 3622
7fcccf1e
PE
3623 * image.c (cache_image): Check for size arithmetic overflow.
3624
bfbbd7e7
PE
3625 * lread.c: Integer overflow issues.
3626 (saved_doc_string_size, saved_doc_string_length)
3627 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3628 Now ptrdiff_t, not int.
3629 (read1): Don't assume doc string length fits in int. Check for
3630 out-of-range doc string lengths.
3631 (read_list): Don't assume file position fits in int.
39019e54 3632 (read_escape): Check for hex character overflow.
bfbbd7e7 3633
4e323265
LL
36342011-06-22 Leo Liu <sdl.web@gmail.com>
3635
3636 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3637 Move to minibuffer.el.
3638
85fece3e
PE
36392011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3640
20b84ce9 3641 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3642 The following patches are for when GLYPH_DEBUG && !XASSERT.
3643 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3644 * dispnew.c (flush_stdout):
3645 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3646 Mark as externally visible.
3647 * dispnew.c (check_window_matrix_pointers): Now static.
3648 * dispnew.c (window_to_frame_vpos):
3649 * xfns.c (unwind_create_frame):
3650 * xterm.c (x_check_font): Remove unused local.
3651 * scroll.c (CHECK_BOUNDS):
3652 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3653 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3654 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3655 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3656 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3657 Now static.
3658 (debug_method_add): Use va_list and vsprintf rather than relying
3659 on undefined behavior with wrong number of arguments.
3660 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3661 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3662 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3663 since we're not interested in debugging glyphs with old libraries.
3664 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3665 GCC 4.6.0's static checking.
3666
0766b489
PE
36672011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3668
31fd4b32
PE
3669 Integer overflow and signedness fixes (Bug#8873).
3670 A few related buffer overrun fixes, too.
3671
b79e8648
PE
3672 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3673
0766b489
PE
3674 * dispextern.h (struct face.stipple):
3675 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3676 (x_bitmap_mask, x_allocate_bitmap_record)
3677 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3678 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3679 (x_create_bitmap_from_xpm_data):
3680 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3681 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3682 (.bitmaps_last):
3683 * xfaces.c (load_pixmap):
3684 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3685 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3686 (.bitmaps_last, struct x_output.icon_bitmap):
3687 Use ptrdiff_t, not int, for bitmap indexes.
3688 (x_allocate_bitmap_record): Check for size overflow.
3689 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3690
b081724f
PE
3691 Use ptrdiff_t, not int, for overlay counts.
3692 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3693 * editfns.c (overlays_around, get_pos_property):
3694 * textprop.c (get_char_property_and_overlay):
3695 * xdisp.c (next_overlay_change, note_mouse_highlight):
3696 * xfaces.c (face_at_buffer_position):
21514da7
PE
3697 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3698 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3699 (Fnext_overlay_change, Fprevious_overlay_change)
3700 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3701 Use ptrdiff_t, not int, for sizes.
21514da7 3702 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3703
3de73e5e
PE
3704 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3705
2606c57b
PE
3706 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3707 (x_session_initialize): Do not assume string length fits in int.
3708
aaafe47a
PE
3709 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3710 This is unlikely, but can occur if DPI is outlandish.
3711
2674ddc8 3712 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3713 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3714
28154962
PE
3715 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3716 * xrdb.c (magic_file_p, search_magic_path):
3717 Omit last arg SUFFIX; it was always 0. All callers changed.
3718 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3719
7de51af5
PE
3720 * xfont.c (xfont_match): Avoid need for strlen.
3721
25ed6cc3
PE
3722 * xfns.c: Don't assume strlen fits in int.
3723 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3724
4eab31dd
PE
3725 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3726 not unsigned long, as we prefer signed integers. All callers changed.
3727 Detect integer overflow in repeat count.
3728 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3729 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3730
171e2a58
PE
3731 * termcap.c: Don't assume sizes fit in int and never overflow.
3732 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3733 (gobble_line): Check for size-calculation overflow.
3734
ad39faca 3735 * minibuf.c (Fread_buffer):
6e5bb2dc 3736 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3737 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3738 Don't assume string length fits in int.
3739
52c61c22 3740 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3741 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3742
b5b8c9e5
PE
3743 * font.c: Don't assume string length fits in int.
3744 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3745 Use ptrdiff_t, not int.
ccd6111c
PE
3746 (font_intern_prop): Don't assume string length fits in int.
3747 Don't assume integer property fits in fixnum.
3748 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3749
882f0d81 3750 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3751 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3752 Reformulate so as not to need the command string.
3753 Invoke gzip -cd rather than gunzip, as it's more portable.
3754 (lock_info_type, lock_file_1, lock_file):
3755 Don't assume pid_t and time_t fit in unsigned long.
3756 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3757 (current_lock_owner): Prefer signed type for sizes.
3758 Use memcpy, not strncpy, where memcpy is what is really wanted.
3759 Don't assume (via atoi) that time_t and pid_t fit in int.
3760 Check for time_t and/or pid_t out of range, e.g., via a network share.
3761 Don't alloca where an auto var works fine.
3762
93f4cf88
PE
3763 * fileio.c: Fix some integer overflow issues.
3764 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3765 Don't assume string length fits in int.
3766 (directory_file_name): Don't assume string length fits in long.
3767 (make_temp_name): Don't assume pid fits in int, or that its print
3768 length is less than 20.
3769
f3e92b69
PE
3770 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3771
1bfdaf10
PE
3772 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3773
35016e9a
PE
3774 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3775
3d1e65a1
PE
3776 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3777 We prefer signed integers, even for size calculations.
3778
0b963a93
PE
3779 * emacs.c: Don't assume string length fits in 'int'.
3780 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3781 (main): Don't invoke strlen when not needed.
3782
573f4b54
PE
3783 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3784 (XD_DEBUG_MESSAGE): Don't waste a byte.
3785
989f33ba
PE
3786 * callproc.c (getenv_internal_1, getenv_internal)
3787 (Fgetenv_internal):
965d34eb
PE
3788 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3789
e4d29b33
PE
3790 * lread.c (invalid_syntax): Omit length argument.
3791 All uses changed. This doesn't fix a bug, but it simplifies the
3792 code away from its former Hollerith-constant appearance, and it's
3793 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3794 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3795
eb49b136
PE
3796 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3797 This didn't break anything, but it didn't help either.
3798 It's confusing to put a bogus integer in a place where the actual
3799 value does not matter.
9f62aeb1 3800 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3801 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3802
15375a22
PE
3803 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3804 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3805 implementation.
b61cc01c
PE
3806 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3807 We prefer signed types, and the value cannot exceed the EMACS_INT
3808 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3809 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3810 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3811 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3812
53b2623d
PE
3813 * indent.c (sane_tab_width): New function.
3814 (current_column, scan_for_column, Findent_to, position_indentation)
3815 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3816 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3817
51cab52b 3818 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3819
f2ed8a70
PE
3820 * lisp.h (lint_assume): New macro.
3821 * composite.c (composition_gstring_put_cache):
3822 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3823
abe80cc6
PE
3824 * editfns.c, insdel.c:
3825 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3826
b02c740e
PE
3827 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3828
ebc96716
PE
3829 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3830
b4e50fa0 3831 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3832 Use much-faster test for byte-length change.
311d5d7c 3833 Don't assume string byte-length fits in 'int'.
a4cf38e4 3834 Check that character arg fits in 'int'.
85461888 3835 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3836
c0c1ee9f
PE
3837 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3838
a498d7f4
PE
3839 * fns.c (concat): Catch string overflow earlier.
3840 Do not rely on integer wraparound.
3841
51cab52b
PE
3842 * dispextern.h (struct it.overlay_strings_charpos)
3843 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3844 * xdisp.c (forward_to_next_line_start)
3845 (back_to_previous_visible_line_start)
3846 (reseat_at_next_visible_line_start, next_element_from_buffer):
3847 Don't arbitrarily truncate the value of 'selective' to int.
3848
76031fad
PE
3849 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3850
5eb55db9
PE
3851 * composite.c: Don't truncate sizes to 'int'.
3852 (composition_gstring_p, composition_reseat_it)
3853 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3854 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3855 not EMACS_UINT, for indexes.
5eb55db9 3856
0703a717
PE
3857 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3858
d6202519
PE
3859 * buffer.c: Include <verify.h>.
3860 (struct sortvec.priority, struct sortstr.priority):
8961a454 3861 Now EMACS_INT, not int.
c20998a7 3862 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3863 (struct sortstr.size, record_overlay_string)
3864 (struct sortstrlist.size, struct sortlist.used):
3865 Don't truncate size to int.
3866 (record_overlay_string): Check for size-calculation overflow.
d6202519 3867 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3868
d5a19415
JM
38692011-06-22 Jim Meyering <meyering@redhat.com>
3870
029529ac 3871 Don't leak an XBM-image-sized buffer
d5a19415
JM
3872 * image.c (xbm_load): Free the image buffer after using it.
3873
a9041e6c
PE
38742011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3875
3876 Port to Sun C.
3877 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3878 that Sun C diagnosed.
3879 * fns.c (secure_hash): Fix pointer signedness issue.
3880 * intervals.c (static_offset_intervals): New function.
3881 (offset_intervals): Use it.
3882
7f3f739f
LL
38832011-06-21 Leo Liu <sdl.web@gmail.com>
3884
3885 * deps.mk (fns.o):
3886 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3887 sha512.h.
3888
3889 * fns.c (secure_hash): Rename from crypto_hash_function and change
3890 the first arg to accept symbols.
5b66d427 3891 (Fsecure_hash): New primitive.
7f3f739f
LL
3892 (syms_of_fns): New symbols.
3893
76147d94
DD
38942011-06-20 Deniz Dogan <deniz@dogan.se>
3895
3896 * process.c (Fset_process_buffer): Clarify return value in
3897 docstring.
3898
7d7d0045
CY
38992011-06-18 Chong Yidong <cyd@stupidchicken.com>
3900
3901 * dispnew.c (add_window_display_history): Use BVAR.
3902
3903 * xdisp.c (debug_method_add): Use BVAR.
3904 (check_window_end, dump_glyph_matrix, dump_glyph)
3905 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3906
3907 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3908 Likewise.
3909
3910 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3911 check till after the cache is created in init_frame_faces.
3912
ff2bc410
SM
39132011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3914
3915 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3916
28177add
PE
39172011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3918
dd3482fe
PE
3919 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3920 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3921 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3922
393d71f3 3923 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3924 * fileio.c (Finsert_file_contents):
3925 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3926 Remove the old (too-loose) buffer overflow checks.
3927 They weren't needed, since make_gap checks for buffer overflow.
3928 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3929 The old code merely checked for Emacs fixnum overflow, and relied
3930 on undefined (wraparound) behavior. The new code avoids undefined
3931 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3932
2e6813b0 3933 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3934 Tune. Don't use wider integers than needed. Don't use alloca.
3935 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3936
599a9e4f
PE
3937 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3938
99561444
PE
3939 * insdel.c, lisp.h (buffer_overflow): New function.
3940 (insert_from_buffer_1, replace_range, replace_range_2):
3941 * insdel.c (make_gap_larger):
3942 * editfns.c (Finsert_char):
3943 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3944
28177add
PE
3945 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3946
e69dafad
PE
39472011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3948
a7af7fde 3949 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3950
b1c46f02
PE
3951 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3952 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3953
e69dafad
PE
3954 * fileio.c: Don't assume EMACS_INT fits in off_t.
3955 (emacs_lseek): New static function.
3956 (Finsert_file_contents, Fwrite_region): Use it.
3957 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3958
566684ea
PE
3959 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3960
e6966cd6
PE
3961 * fns.c: Don't overflow int when computing a list length.
3962 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3963 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3964 truncation on 64-bit hosts. Check for QUIT every
3965 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3966 faster and is responsive enough.
3967 (Flength): Report an error instead of overflowing an integer.
3968 (Fsafe_length): Return a float if the value is not representable
3969 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3970 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3971 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3972
dd0b0efb
PE
3973 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3974 (header_size, word_size): New constants.
3975 (allocate_vectorlike): Don't check size overflow here.
3976 (allocate_vector): Check it here instead, since this is the only
3977 caller of allocate_vectorlike that could cause overflow.
3978 Check that the new vector's length is representable as a fixnum.
3979
86fe5cfe
PE
3980 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3981 The previous code was bogus. For example, next_almost_prime (32)
3982 returned 39, which is undesirable as it is a multiple of 3; and
3983 next_almost_prime (24) returned 25, which is a multiple of 5 so
3984 why was the code bothering to check for multiples of 7?
3985
80e88859
PE
3986 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3987
4a2f0ad6
PE
3988 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3989
f66c7cf8
PE
3990 Variadic C functions now count arguments with ptrdiff_t.
3991 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3992 Back then I didn't know that the Emacs coding style prefers signed int.
3993 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3994 were being counted with int, which may truncate counts on 64-bit
3995 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3996 * lisp.h (struct Lisp_Subr.function.aMANY)
3997 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3998 Arg counts are now ptrdiff_t, not size_t.
3999 All variadic functions and their callers changed accordingly.
4000 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4001 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4002 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4003 * callint.c (Fcall_interactively): Check arg count for overflow,
4004 to avoid potential buffer overrun. Use signed char, not 'int',
4005 for 'varies' array, so that we needn't bother to check its size
4006 calculation for overflow.
4007 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4008 * eval.c (apply_lambda):
4009 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4010 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4011 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4012
a1759b76
PE
4013 * callint.c (Fcall_interactively): Don't use index var as event count.
4014
d96be9fc
PE
4015 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4016 * mem-limits.h (SIZE): Remove; no longer used.
4017
a690a978 4018 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4019
578c21e6
PE
4020 Remove unnecessary casts.
4021 * xterm.c (x_term_init):
4022 * xfns.c (x_set_border_pixel):
4023 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4024 These aren't needed now that we assume ANSI C.
4025
96f53c6c
PE
4026 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4027 It's more likely to cause problems (due to unsigned overflow)
4028 than to cure them.
4029
83c77d31
PE
4030 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4031
ee2079f1
PE
4032 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4033
6da65536
PE
4034 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4035
7147c4a4
PE
4036 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4037
193e32d9
PE
4038 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4039
e5533da6
PE
4040 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4041
9910e595
PE
4042 GLYPH_CODE_FACE returns EMACS_INT, not int.
4043 * dispextern.h (merge_faces):
4044 * xfaces.c (merge_faces):
01103c44
PE
4045 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4046 Don't assume EMACS_INT fits in int.
9910e595 4047
2638320e
PE
4048 * character.h (CHAR_VALID_P): Remove unused parameter.
4049 * fontset.c, lisp.h, xdisp.c: All uses changed.
4050
045eb8d9
PE
4051 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4052
c1f134b5
PE
4053 * fns.c (concat): Minor tuning based on overflow analysis.
4054 This doesn't fix any bugs. Use int to hold character, instead
4055 of constantly refetching from Emacs object. Use XFASTINT, not
4056 XINT, for value known to be a character. Don't bother comparing
4057 a single byte to 0400, as it's always less.
4058
395fcb93 4059 * floatfns.c (Fexpt):
327eeec8
PE
4060 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4061
abbd3d23
PE
4062 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4063 for characters.
4064
684a03ef
PE
4065 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4066
0fed43f3
PE
4067 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4068 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4069 incorrectly succeed when S was a string, because 4294967386 was
4070 truncated before it was used.
4071
8fd02eb7
PE
4072 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4073 Otherwise, an out-of-range integer could cause undefined behavior
4074 on a 64-bit host.
4075
f8c86b69
PE
4076 * composite.c: Use int, not EMACS_INT, for characters.
4077 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4078 EMACS_INT, for values that are known to be in character range.
4079 This doesn't fix any bugs but is the usual style inside Emacs and
4080 may generate better code on 32-bit machines.
4081
34206dd2
PE
4082 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4083 This is for reasons similar to the recent CHAR_STRING fix.
4084 * charset.c (Fencode_char): Check that character arg is actually
4085 a character. Pass an int to ENCODE_CHAR.
4086 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4087 wider than 'int', as a compile-time check to prevent future regressions
4088 in this area.
4089
c5958d4c 4090 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4091
4092 Make sure a 64-bit char is never passed to CHAR_STRING.
4093 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4094 by silently ignoring the top 32 bits, allowing some values
4095 that were far too large to be valid characters.
4096 * character.h: Include <verify.h>.
4097 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4098 arguments are no wider than unsigned, as a compile-time check
4099 to prevent future regressions in this area.
4100 * data.c (Faset):
01103c44 4101 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4102 (Fsubst_char_in_region):
4103 * fns.c (concat):
4104 * xdisp.c (decode_mode_spec_coding):
4105 Adjust to CHAR_STRING's new requirement.
4106 * editfns.c (Finsert_char, Fsubst_char_in_region):
4107 * fns.c (concat): Check that character args are actually
4108 characters. Without this test, these functions did the wrong
4109 thing with wildly out-of-range values on 64-bit hosts.
4110
d37ca623
PE
4111 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4112 These casts should not be needed on 32-bit hosts, either.
4113 * keyboard.c (read_char):
4114 * lread.c (Fload): Remove casts to unsigned.
4115
ea204efb
PE
4116 * lisp.h (UNSIGNED_CMP): New macro.
4117 This fixes comparison bugs on 64-bit hosts.
4118 (ASCII_CHAR_P): Use it.
4119 * casefiddle.c (casify_object):
01103c44 4120 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4121 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4122 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4123 * dispextern.h (FACE_FROM_ID):
4124 * keyboard.c (read_char): Use UNSIGNED_CMP.
4125
41cb286c
PE
4126 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4127 not to EMACS_INT, to avoid GCC warning.
4128
4a1b9832
PE
4129 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4130
55daad71
PE
4131 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4132 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4133 isn't needed on 32-bit machines.
8f95c75c 4134
01103c44
PE
4135 * buffer.c (Fgenerate_new_buffer_name):
4136 Use EMACS_INT for count, not int.
0ceccced 4137 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4138
4139 * data.c (Qcompiled_function): Now static.
4140
c6f072e7
PE
4141 * window.c (window_body_lines): Now static.
4142
20ce5912
PE
4143 * image.c (gif_load): Rename local to avoid shadowing.
4144
9c4c5f81
PE
4145 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4146 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4147 * alloc.c (make_save_value): Integer argument is now of type
4148 ptrdiff_t, not int.
4149 (mark_object): Use ptrdiff_t, not int.
4150 * lisp.h (pD): New macro.
4151 * print.c (print_object): Use it.
4152
c0c5c8ae
PE
4153 * alloc.c: Use EMACS_INT, not int, to count objects.
4154 (total_conses, total_markers, total_symbols, total_vector_size)
4155 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4156 (total_free_floats, total_floats, total_free_intervals)
4157 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4158 Now EMACS_INT, not int. All uses changed.
4159 (Fgarbage_collect): Compute overall total using a double, so that
4160 integer overflow is less likely to be a problem. Check for overflow
4161 when converting back to an integer.
5a25e253
PE
4162 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4163 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4164 These were 'int' variables that could overflow on 64-bit hosts;
4165 they were never used, so remove them instead of repairing them.
211a0b2a 4166 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4167 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4168 Previously, this ceilinged at INT_MAX, but that doesn't work on
4169 64-bit machines.
e46bb31a 4170 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4171
c78baabf 4172 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4173 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4174 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4175 when a (possibly-narrower) signed value would do just as well.
4176 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4177
c9d624c6
PE
4178 * alloc.c: Catch some string size overflows that we were missing.
4179 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4180 for convenience in STRING_BYTES_MAX.
4181 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4182 The definition here is exact; the one in lisp.h was approximate.
4183 (allocate_string_data): Check for string overflow. This catches
4184 some instances we weren't catching before. Also, it catches
4185 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4186 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4187 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4188
c9d624c6
PE
4189 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4190 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4191 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4192
353032ce
PE
4193 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4194
2bccce07
PE
4195 * alloc.c (Fmake_string): Check for out-of-range init.
4196
0ac30604
SM
41972011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4198
4199 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4200
c195f2de
JD
42012011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4202
4203 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4204 xg_get_default_scrollbar_width.
4205
4206 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4207 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4208 (style_changed_cb): Call update_theme_scrollbar_width and call
4209 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4210 all frames (Bug#8505).
4211 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4212 Call gtk_window_set_resizable if HAVE_GTK3.
4213 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4214 and height if HAVE_GTK3 (Bug#8505).
4215 (scroll_bar_width_for_theme): New variable.
4216 (update_theme_scrollbar_width): New function.
4217 (xg_get_default_scrollbar_width): Move code to
4218 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4219 (xg_initialize): Call update_theme_scrollbar_width.
4220
4221 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4222
4223 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4224
e10ac9f1
MR
42252011-06-12 Martin Rudalics <rudalics@gmx.at>
4226
4227 * frame.c (make_frame): Call other_buffer_safely instead of
4228 other_buffer.
4229
4230 * window.c (temp_output_buffer_show): Call display_buffer with
4231 second argument Vtemp_buffer_show_specifiers and reset latter
4232 immediately after the call.
4233 (Vtemp_buffer_show_specifiers): New variable.
4234 (auto_window_vscroll_p, next_screen_context_lines)
4235 (Vscroll_preserve_screen_position): Remove leading asterisks from
4236 doc-strings.
4237
2d3c217e 42382011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4239
7b7f97e8 4240 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4241 * buffer.c (Qclone_number): Remove for now, as it's unused.
4242 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4243 (record_buffer): Remove unused local.
4244 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4245 (set_frame_buffer_list): Remove; unused.
4246 * frame.h (other_visible_frames): Remove decl.
4247 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4248 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4249 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4250 if HAVE_GPM.
4251 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4252 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4253 Define only if HAVE_GPM.
4254 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4255 (update_hints_inhibit): Remove; never set. All uses removed.
4256 * widgetprv.h (emacsFrameClassRec): Remove decl.
4257 * window.c (delete_deletable_window): Now returns void, since it
4258 wasn't returning anything.
4259 (compare_window_configurations): Remove unused locals.
4260 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4261 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4262 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4263 the same widths as pointers. This follows up on the 2011-05-06 patch.
4264 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4265 * xterm.h: Likewise.
4266 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4267
1384b89e
JB
42682011-06-12 Juanma Barranquero <lekktu@gmail.com>
4269
4270 * makefile.w32-in: Update dependencies.
4271 (LISP_H): Add lib/intprops.h.
4272
1100a63c
CY
42732011-06-11 Chong Yidong <cyd@stupidchicken.com>
4274
4275 * image.c (gif_load): Add animation frame delay to the metadata.
4276 (syms_of_image): Use DEFSYM. New symbol `delay'.
4277
6198ccd0
MR
42782011-06-11 Martin Rudalics <rudalics@gmx.at>
4279
4280 * window.c (delete_deletable_window): Re-add.
4281 (Fset_window_configuration): Rewrite to handle dead buffers and
4282 consequently deletable windows.
4283 (window_tree, Fwindow_tree): Remove. Supply functionality in
4284 window.el.
4285 (compare_window_configurations): Simplify code.
4286
b6e3633c
AS
42872011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4288
1ab0dee5
AS
4289 * image.c (imagemagick_load_image): Fix type mismatch.
4290 (Fimagemagick_types): Likewise.
4291
b6e3633c
AS
4292 * window.h (replace_buffer_in_windows): Declare.
4293
9397e56f
MR
42942011-06-11 Martin Rudalics <rudalics@gmx.at>
4295
4296 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4297 Qclone_number. Remove external declaration of Qdelete_window.
4298 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4299 code.
640c8776
SM
4300 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4301 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4302 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4303 buffer list implementation.
4304 (other_buffer_safely): New function.
4305 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4306 calls to replace_buffer_in_windows and
4307 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4308 if allowed.
4309 (record_buffer): Inhibit quitting and rewrite using quittable
4310 functions. Run Qbuffer_list_update_hook if allowed.
4311 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4312 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4313 Move switch-to-buffer to window.el.
9397e56f
MR
4314 (bury-buffer): Move to window.el.
4315 (Vbuffer_list_update_hook): New variable.
4316
4317 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4318 section.
4319
4320 * window.h (resize_frame_windows): Move up in code.
4321 (Fwindow_frame): Remove EXFUN.
4322 (replace_buffer_in_all_windows): Remove prototype.
4323 (replace_buffer_in_windows_safely): Add prototype.
4324
4325 * window.c: Declare Qdelete_window static again. Move down
4326 declaration of select_count.
4327 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4328 (Fother_window): Move to window.el.
4329 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4330 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4331 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4332 window.el.
4333 (replace_buffer_in_windows): Implement by calling
4334 Qreplace_buffer_in_windows.
4335 (replace_buffer_in_all_windows): Remove with some functionality
4336 moved into replace_buffer_in_windows_safely.
4337 (replace_buffer_in_windows_safely): New function.
4338 (select_window_norecord, select_frame_norecord): Move in front
4339 of run_window_configuration_change_hook. Remove now obsolete
4340 declarations.
640c8776
SM
4341 (Fset_window_buffer): Rewrite doc-string.
4342 Call Qrecord_window_buffer.
9397e56f
MR
4343 (keys_of_window): Move binding for other-window to window.el.
4344
b50691aa
CY
43452011-06-11 Chong Yidong <cyd@stupidchicken.com>
4346
4347 * dispextern.h (struct image): Replace data member, whose int_val
4348 and ptr_val fields were not used by anything, with a single
4349 lisp_val object.
4350
4351 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4352 (gif_clear_image, gif_load, imagemagick_load_image)
4353 (gs_clear_image, gs_load): Callers changed.
4354
3f754b86
PE
43552011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4356
cca69397
PE
4357 * buffer.h: Include <time.h>, for time_t.
4358 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4359
109e28d0
PE
4360 Fix minor problems found by static checking.
4361
60737f02
PE
4362 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4363
4b66faf3
PE
4364 Make identifiers static if they are not used in other modules.
4365 * data.c (Qcompiled_function, Qframe, Qvector):
4366 * image.c (QimageMagick, Qsvg):
4367 * minibuf.c (Qmetadata):
4368 * window.c (resize_window_check, resize_root_window): Now static.
4369 * window.h (resize_window_check, resize_root_window): Remove decls.
4370
109e28d0
PE
4371 * window.c (window_deletion_count, delete_deletable_window):
4372 Remove; unused.
46a4ce9e
PE
4373 (window_body_lines): Now static.
4374 (Fdelete_other_windows_internal): Mark vars as initialized.
4375 Make sure 'resize_failed' is initialized.
4376 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4377 (resize_window_apply): Remove unused local.
4378 * window.h (delete_deletable_window): Remove decl.
4379
109e28d0 4380 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4381 (imagemagick_load_image): Fix pointer signedness problem by changing
4382 last arg from unsigned char * to char *. All uses changed.
4383 Also, fix a local for similar reasons.
4384 Remove unused locals. Remove locals to avoid shadowing.
4385 (fn_rsvg_handle_free): Remove; unused.
4386 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4387 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4388
3f754b86
PE
4389 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4390
2547adb1
CY
43912011-06-10 Chong Yidong <cyd@stupidchicken.com>
4392
4393 * image.c (gif_load): Fix omitted cast error introduced by
4394 2011-06-06 change.
4395
2c8e37d4
MR
43962011-06-10 Martin Rudalics <rudalics@gmx.at>
4397
4398 * window.h (resize_proportionally, orig_total_lines)
4399 (orig_top_line): Remove from window structure.
4400 (set_window_height, set_window_width, change_window_heights)
4401 (Fdelete_window): Remove prototypes.
4402 (resize_frame_windows): Remove duplicate declaration.
4403
440a42e3
EZ
44042011-06-10 Eli Zaretskii <eliz@gnu.org>
4405
4406 * window.h (resize_frame_windows, resize_window_check)
4407 (delete_deletable_window, resize_root_window)
4408 (resize_frame_windows): Declare prototypes.
4409
4410 * window.c (resize_window_apply): Make definition be "static" to
4411 match the prototype.
4412
562dd5e9
MR
44132011-06-10 Martin Rudalics <rudalics@gmx.at>
4414
4415 * window.c: Remove declarations of Qwindow_size_fixed,
4416 window_min_size_1, window_min_size_2, window_min_size,
4417 size_window, window_fixed_size_p, enlarge_window, delete_window.
4418 Remove static from declaration of Qdelete_window, it's
4419 temporarily needed by Fbury_buffer.
4420 (replace_window): Don't assign orig_top_line and
4421 orig_total_lines.
4422 (Fdelete_window, delete_window): Remove. Window deletion is
4423 handled by window.el.
640c8776
SM
4424 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4425 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4426 (Fdelete_other_windows): Remove. Deleting other windows is
4427 handled by window.el.
4428 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4429 handled in window.el.
4430 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4431 Window minimum sizes are handled in window.el.
4432 (shrink_windows, size_window, set_window_height)
4433 (set_window_width, change_window_heights, window_height)
4434 (window_width, CURBEG, CURSIZE, enlarge_window)
4435 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4436 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4437 handled in window.el.
4438 (make_dummy_parent): Rename to make_parent_window and give it a
4439 second argument horflag.
4440 (make_window): Don't set resize_proportionally any more.
4441 (Fsplit_window): Remove. Windows are split in window.el.
4442 (save_restore_action, save_restore_orig_size)
4443 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4444 Resize mini windows in window.el.
4445 (grow_mini_window, shrink_mini_window): Implement by calling
4446 Qresize_root_window_vertically, resize_window_check and
4447 resize_window_apply.
640c8776
SM
4448 (saved_window, Fset_window_configuration, save_window_save):
4449 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4450 resize_proportionally.
4451 (window_min_height, window_min_width): Move to window.el.
4452 (keys_of_window): Move bindings for delete-other-windows,
4453 split-window, delete-window and enlarge-window to window.el.
4454
4455 * buffer.c: Temporarily extern Qdelete_window.
4456 (Fbury_buffer): Temporarily call Qdelete_window instead of
4457 Fdelete_window (Fbury_buffer will move to window.el soon).
4458
4459 * frame.c (set_menu_bar_lines_1): Remove code handling
4460 orig_top_line and orig_total_lines.
4461
4462 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4463 set_window_height but set heights directly.
4464 (change_frame_size_1): Use resize_frame_windows.
4465
4466 * xdisp.c (init_xdisp): Don't use set_window_height but set
4467 heights directly.
4468
640c8776
SM
4469 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4470 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4471 run_window_configuration_change_hook.
4472
4473 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4474 instead of change_window_heights and run
4475 run_window_configuration_change_hook.
4476
1a13852e
MR
44772011-06-09 Martin Rudalics <rudalics@gmx.at>
4478
4479 * window.c (replace_window): Rename second argument REPLACEMENT to
4480 NEW. New third argument SETFLAG. Rewrite.
4481 (delete_window, make_dummy_parent): Call replace_window with
4482 third argument 1.
4483 (window_list_1): Move down in code.
4484 (run_window_configuration_change_hook): Move set_buffer part
4485 before select_frame_norecord part in order to unwind correctly.
4486 Rename count1 to count.
4487 (recombine_windows, delete_deletable_window, resize_root_window)
4488 (Fdelete_other_windows_internal)
4489 (Frun_window_configuration_change_hook, make_parent_window)
4490 (resize_window_check, resize_window_apply, Fresize_window_apply)
4491 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4492 (Fdelete_window_internal, Fresize_mini_window_internal):
4493 New functions.
1a13852e
MR
4494 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4495
f3d1777e
MR
44962011-06-08 Martin Rudalics <rudalics@gmx.at>
4497
496e208e
MR
4498 * window.h (window): Add some new members to window structure -
4499 normal_lines, normal_cols, new_total, new_normal, clone_number,
4500 splits, nest, prev_buffers, next_buffers.
4501 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4502 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4503
f3d1777e
MR
4504 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4505 Remove.
496e208e
MR
4506 (make_dummy_parent): Set new members of windows structure.
4507 (make_window): Move down in code. Handle new members of window
4508 structure.
4509 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4510 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4511 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4512 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4513 (Fset_window_next_buffers, Fset_window_clone_number):
4514 New functions.
496e208e
MR
4515 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4516 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4517 Doc-string fixes.
4518 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4519 Argument WINDOW can be now internal window too.
4520 (Fwindow_use_time): Move up in code.
4521 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4522 Rewrite doc-string.
4523 (Fset_window_configuration, saved_window)
4524 (Fcurrent_window_configuration, save_window_save): Handle new
4525 members of window structure.
b9e809c2
MR
4526 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4527 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4528 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4529 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4530 Qget_mru_window, Qresize_root_window,
4531 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4532 Qauto_buffer_name; staticpro them.
f3d1777e 4533
abde8f8c
MR
45342011-06-07 Martin Rudalics <rudalics@gmx.at>
4535
4536 * window.c (Fwindow_total_size, Fwindow_left_column)
4537 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4538 (Fwindow_list_1): New functions.
4539 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4540 (Fwindow_width, Fscroll_left, Fscroll_right):
4541 Use window_body_cols instead of window_box_text_cols.
4542 (delete_window, Fset_window_configuration):
4543 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4544 (delete_all_subwindows): Take a window as argument and not a
4545 structure. Rewrite.
190b47e6
MR
4546 (window_loop): Remove handling of GET_LRU_WINDOW and
4547 GET_LARGEST_WINDOW.
4548 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4549
4550 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4551 window_box_text_cols. delete_all_subwindows now takes a
4552 Lisp_Object as argument.
abde8f8c 4553
640c8776
SM
4554 * indent.c (compute_motion, Fcompute_motion):
4555 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4556
fa8a67e6
MR
4557 * frame.c (delete_frame): Call delete_all_subwindows with root
4558 window as argument.
4559
a54e3482
DC
45602011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4561
4562 * fns.c (Fputhash): Document return value.
4563
60002bf5
CY
45642011-06-06 Chong Yidong <cyd@stupidchicken.com>
4565
4566 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4567
0c671da6 45682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4569
b862a52a 4570 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4571
be44ca6c
PE
4572 Check for overflow when converting integer to cons and back.
4573 * charset.c (Fdefine_charset_internal, Fdecode_char):
4574 Use cons_to_unsigned to catch overflow.
4575 (Fencode_char): Use INTEGER_TO_CONS.
4576 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4577 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4578 * data.c (long_to_cons, cons_to_long): Remove.
4579 (cons_to_unsigned, cons_to_signed): New functions.
4580 These signal an error for invalid or out-of-range values.
4581 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4582 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4583 * font.c (Ffont_variation_glyphs):
4584 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4585 * lisp.h: Include <intprops.h>.
4586 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4587 (cons_to_signed, cons_to_unsigned): New decls.
4588 (long_to_cons, cons_to_long): Remove decls.
4589 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4590 (Fprimitive_undo): Use CONS_TO_INTEGER.
4591 * xfns.c (Fx_window_property): Likewise.
4592 * xselect.c: Include <limits.h>.
4593 (x_own_selection, selection_data_to_lisp_data):
4594 Use INTEGER_TO_CONS.
4595 (x_handle_selection_request, x_handle_selection_clear)
4596 (x_get_foreign_selection, Fx_disown_selection_internal)
4597 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4598 (lisp_data_to_selection_data): Use cons_to_unsigned.
4599 (x_fill_property_data): Use cons_to_signed.
4600 Report values out of range.
4601
d1f3d2af
PE
4602 Check for buffer and string overflow more precisely.
4603 * buffer.h (BUF_BYTES_MAX): New macro.
4604 * lisp.h (STRING_BYTES_MAX): New macro.
4605 * alloc.c (Fmake_string):
4606 * character.c (string_escape_byte8):
4607 * coding.c (coding_alloc_by_realloc):
4608 * doprnt.c (doprnt):
4609 * editfns.c (Fformat):
4610 * eval.c (verror):
4611 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4612 since they may not be the same number.
4613 * editfns.c (Finsert_char):
4614 * fileio.c (Finsert_file_contents):
4615 Likewise for BUF_BYTES_MAX.
4616
dd52fcea
PE
4617 * image.c: Use ptrdiff_t, not int, for sizes.
4618 (slurp_file): Switch from int to ptrdiff_t.
4619 All uses changed.
4620 (slurp_file): Check that file size fits in both size_t (for
4621 malloc) and ptrdiff_t (for sanity and safety).
4622
7f9bbdbb
PE
4623 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4624 if b->modtime has its maximal value.
4625
dfe18f82
PE
4626 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4627
84acfcf0
PE
4628 Don't assume time_t can fit into int.
4629 * buffer.h (struct buffer.modtime): Now time_t, not int.
4630 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4631 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4632
ccd9a01a
PE
4633 Minor fixes for signed vs unsigned integers.
4634 * character.h (MAYBE_UNIFY_CHAR):
4635 * charset.c (maybe_unify_char):
4636 * keyboard.c (read_char, reorder_modifiers):
4637 XINT -> XFASTINT, since the integer must be nonnegative.
4638 * ftfont.c (ftfont_spec_pattern):
4639 * keymap.c (access_keymap, silly_event_symbol_error):
4640 XUINT -> XFASTINT, since the integer must be nonnegative.
4641 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4642 since it makes no difference and we prefer signed.
4643 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4644 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4645 nonnegative.
4646
d6d100dd
SM
46472011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4648
4649 * window.h (Fwindow_frame): Declare.
4650
2b6148e4
PE
46512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4652
4653 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4654 (SPARE_MEMORY): Always define.
4655 (LARGE_REQUEST): Remove.
4656 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4657
f230ecc9
MR
46582011-06-06 Martin Rudalics <rudalics@gmx.at>
4659
727e958e
MR
4660 * lisp.h: Move EXFUNS for Fframe_root_window,
4661 Fframe_first_window and Fset_frame_selected_window to window.h.
4662
4663 * window.h: Move EXFUNS for Fframe_root_window,
4664 Fframe_first_window and Fset_frame_selected_window here from
4665 lisp.h.
4666
4667 * frame.c (Fwindow_frame, Fframe_first_window)
4668 (Fframe_root_window, Fframe_selected_window)
4669 (Fset_frame_selected_window): Move to window.c.
4670 (Factive_minibuffer_window): Move to minibuf.c.
4671 (Fother_visible_frames_p): New function.
4672
4673 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4674
f230ecc9
MR
4675 * window.c (decode_window, decode_any_window): Move up in code.
4676 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4677 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4678 (Fwindow_buffer): Move up and rewrite doc-string.
4679 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4680 (Fwindow_prev): New functions.
727e958e
MR
4681 (Fwindow_frame): Move here from frame.c. Accept any window as
4682 argument.
4683 (Fframe_root_window, Fframe_first_window)
4684 (Fframe_selected_window): Move here from frame.c. Accept frame
4685 or arbitrary window as argument. Update doc-strings.
4686 (Fminibuffer_window): Move up in code.
4687 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4688 (Fset_frame_selected_window): Move here from frame.c.
4689 Marginal rewrite.
727e958e
MR
4690 (Fselected_window, select_window, Fselect_window): Move up in
4691 code. Minor doc-string fixes.
f230ecc9 4692
4d09bcf6
PE
46932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4694
4695 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4696 Do not assume that spare memory exists; that assumption is valid
4697 only if SYSTEM_MALLOC.
4698 (LARGE_REQUEST): New macro, so that the issue of large requests
4699 is separated from the issue of spare memory.
4700
810928a2
AS
47012011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4702
172418ad
AS
4703 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4704 format. (Bug#8806)
4705
43f862f7
AS
4706 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4707
810928a2
AS
4708 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4709 before statements.
4710
a059fe24
JD
47112011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4712
4713 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4714
4715 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4716
4717 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4718 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4719
989bf368
JB
47202011-06-05 Juanma Barranquero <lekktu@gmail.com>
4721
4722 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4723
4b80f674
CY
47242011-06-04 Chong Yidong <cyd@stupidchicken.com>
4725
4726 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4727 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4728 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4729 New error handlers.
4b80f674
CY
4730 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4731 Obey Vx_select_enable_clipboard_manager. Catch errors in
4732 x_clipboard_manager_save (Bug#8779).
4733 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4734 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4735
99a33b77 47362011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4737
4738 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4739
99a33b77 47402011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4741
4742 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4743 in the current matrix if keep_current_p is non-zero.
4744
8264569d
EZ
47452011-06-04 Eli Zaretskii <eliz@gnu.org>
4746
4747 * bidi.c (bidi_level_of_next_char): Fix last change.
4748
57f97249
EZ
47492011-06-03 Eli Zaretskii <eliz@gnu.org>
4750
fec2107c 4751 Support bidi reordering of text covered by display properties.
57f97249 4752
fec2107c
EZ
4753 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4754 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4755 (bidi_cache_search, bidi_cache_iterator_state)
4756 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4757 (bidi_level_of_next_char, bidi_move_to_visually_next):
4758 Support character positions inside a run of characters covered by a
fec2107c
EZ
4759 display string.
4760 (bidi_paragraph_init, bidi_resolve_explicit_1)
4761 (bidi_level_of_next_char): Call bidi_fetch_char and
4762 bidi_fetch_char_advance instead of FETCH_CHAR and
4763 FETCH_CHAR_ADVANCE.
4764 (bidi_init_it): Initialize new members.
4765 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4766 definitions.
4767 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4768 instead of using explicit *_CHAR codes.
d6d100dd
SM
4769 (bidi_resolve_explicit, bidi_resolve_weak):
4770 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4771 bidirectional text is supported only in multibyte buffers.
4772 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4773 it to initialize the frame_window_p member of struct bidi_it.
4774 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4775 (bidi_resolve_explicit, bidi_resolve_weak)
4776 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4777 bidi_it->nchars is non-positive.
4778 (bidi_level_of_next_char): Don't try to lookup the cache for the
4779 next/previous character if nothing is cached there yet, or if we
4780 were just reseat()'ed to a new position.
c40e2fb2 4781
0e14fe90
EZ
4782 * xdisp.c (set_cursor_from_row): Set start and stop points
4783 according to the row's direction when priming the loop that looks
4784 for the glyph on which to display cursor.
4785 (single_display_spec_intangible_p): Function deleted.
4786 (display_prop_intangible_p): Reimplement to call
4787 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4788 Accept 3 additional arguments needed by handle_display_spec.
4789 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4790 values: lists, `(when COND...)' forms, etc.
4791 (single_display_spec_string_p): Support property values that are
4792 lists with the argument STRING its top-level element.
4793 (display_prop_string_p): Fix the condition for processing a
4794 property that is a list to be consistent with handle_display_spec.
fec2107c 4795 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4796 last portion of handle_display_prop.
4797 (compute_display_string_pos): Accept additional argument
4798 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4799 value of a `display' property is a "replacing spec".
4800 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4801 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4802 the display property, but just return a value indicating whether
4803 the display property will replace the characters it covers.
4804 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4805 frame_window_p members of struct bidi_it.
d6d100dd
SM
4806 (compute_display_string_pos, compute_display_string_end):
4807 New functions.
fec2107c
EZ
4808 (push_it): Accept second argument POSITION, where pop_it should
4809 jump to continue iteration.
4810 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4811
fec2107c
EZ
4812 * keyboard.c (adjust_point_for_property): Adjust the call to
4813 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4814
4815 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4816 (bidi_init_it): Update prototypes.
4817 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4818 (compute_display_string_pos, compute_display_string_end):
4819 Declare prototypes.
fec2107c
EZ
4820 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4821 EMACS_INT.
fc6f18ce 4822
40087514 48232011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4824
57f53182
PE
4825 Malloc failure behavior now depends on size of allocation.
4826 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4827 * lisp.h: Change signatures accordingly.
4828 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4829 All callers changed. (Bug#8762)
4830
4831 * gnutls.c: Use Emacs's memory allocators.
4832 Without this change, the gnutls library would invoke malloc etc.
4833 directly, which causes problems on non-SYNC_INPUT hosts, and which
4834 runs afoul of improving memory_full behavior. (Bug#8761)
4835 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4836 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4837 xfree instead of the default malloc, realloc, free.
4838 (Fgnutls_boot): No need to check for memory allocation failure,
4839 since xmalloc does that for us.
4840
ac32cd99 4841 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4842 * category.c (hash_get_category_set):
4843 * ccl.c (ccl_driver):
4844 * charset.c (Fdefine_charset_internal):
4845 * charset.h (struct charset.hash_index):
4846 * composite.c (get_composition_id, gstring_lookup_cache)
4847 (composition_gstring_put_cache):
4848 * composite.h (struct composition.hash_index):
4849 * dispextern.h (struct image.hash):
4850 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4851 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4852 (hashfn_equal, hashfn_user_defined, make_hash_table)
4853 (maybe_resize_hash_table, hash_lookup, hash_put)
4854 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4855 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4856 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4857 * image.c (make_image, search_image_cache, lookup_image)
4858 (xpm_put_color_table_h):
4859 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4860 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4861 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4862 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4863 * alloc.c (allocate_vectorlike):
4864 Check for overflow in vector size calculations.
4865 * ccl.c (ccl_driver):
4866 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4867 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4868 need to be updated by these changes.
40087514
PE
4869 * fns.c (make_hash_table, maybe_resize_hash_table):
4870 Check for integer overflow with large hash tables.
0de4bb68
PE
4871 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4872 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4873 (SXHASH_REDUCE): New macro.
4874 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4875 Use it instead of discarding useful hash info with large hash values.
4876 (sxhash_float): New function.
4877 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4878 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4879 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4880 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4881 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4882 Adjust signatures to match updated version of code.
4883 (consing_since_gc): Now EMACS_INT, since a single hash table can
4884 use more than INT_MAX bytes.
4885
698d32e2
DN
48862011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4887
4888 Make it possible to build with GCC-4.6+ -O2 -flto.
4889
4890 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4891
fd6fa53f
SM
48922011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4893
4894 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4895 Call minibuffer-inactive-mode.
4896
864db017
JB
48972011-05-31 Juanma Barranquero <lekktu@gmail.com>
4898
4899 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4900 Update dependencies.
4901
2ad0baf4
DN
49022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4903
4904 * data.c (init_data): Remove code for UTS, this system is not
4905 supported anymore.
4906
4fcc2638
DN
49072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4908
4909 Don't force ./temacs to start in terminal mode.
4910
4911 * frame.c (make_initial_frame): Initialize faces in all cases, not
4912 only when CANNOT_DUMP is defined.
4913 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4914
c56e0fd5
DN
49152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4916
4917 * dispnew.c (add_window_display_history): Use const for the string
4918 pointer. Remove declaration, not needed.
4919
333d54da 49202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4921
55d4c1b2 4922 Use 'inline', not 'INLINE'.
333d54da 4923 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4924 * alloc.c, fontset.c (INLINE): Remove.
4925 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4926 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4927 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4928 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4929 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4930
738db178
DN
49312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4932
4933 Make it possible to run ./temacs.
4934
4935 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4936 syms_of_callproc does the same thing. Remove test for
4937 "initialized", do it in the caller.
4938 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4939
620c53a6
SM
49402011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4941
4942 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4943 (read_minibuf): Use get_minibuffer.
4944 (syms_of_minibuf): Use DEFSYM.
4945 (Qmetadata): New var.
4946 * data.c (Qbuffer): Don't make it static.
4947 (syms_of_data): Use DEFSYM.
4948
e003a292
PE
49492011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4950
4951 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4952 (CCL_CODE_MIN): New macro.
4953
ed008a6d
PE
49542011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4955
3687c2ef
PE
4956 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4957
ed008a6d
PE
4958 * eval.c (Qdebug): Now static.
4959 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4960 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4961 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4962
d66c4c7c
CY
49632011-05-29 Chong Yidong <cyd@stupidchicken.com>
4964
4965 * image.c: Various fixes to ImageMagick code comments.
4966 (Fimagemagick_types): Doc fix.
4967
5fbc2025
PE
49682011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4969
0196f88a
PE
4970 Minor fixes prompted by GCC 4.6.0 warnings.
4971
4972 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4973
5fbc2025
PE
4974 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4975 (x_clipboard_manager_save_all): Move extern decl to ...
4976 * xterm.h: ... here, so that it can be checked for consistency.
4977
1dd3c2d9
CY
49782011-05-29 Chong Yidong <cyd@stupidchicken.com>
4979
4980 * xselect.c (x_clipboard_manager_save_frame)
4981 (x_clipboard_manager_save_all): New functions.
4982 (Fx_clipboard_manager_save): Lisp function deleted.
4983
4984 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4985 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4986
4987 * xterm.h: Update prototype.
4988
5ba6571d
WX
49892011-05-28 William Xu <william.xwl@gmail.com>
4990
4991 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4992 exiting (Bug#8239).
4993
3eaff834
JM
49942011-05-28 Jim Meyering <meyering@redhat.com>
4995
e1900994 4996 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4997 * fns.c (to_uchar): Define.
4998 (crypto_hash_function): Use it to convert some newly-signed
4999 variables to unsigned, to avoid sign-extension bugs. For example,
5000 without this change, (md5 "truc") would evaluate to
5001 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5002 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5003 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5004
0f6990a7
PE
50052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5006
5007 Integer overflow fixes.
c8a9ca5a 5008
08686060
PE
5009 * dbusbind.c: Serial number integer overflow fixes.
5010 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5011 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5012 to hold a serial number that is too large for a fixnum.
5013 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5014 Check for serial numbers out of range. Decode any serial number
59568bf0 5015 that was so large that it became a float. (Bug#8722)
08686060 5016
2d1fc3c7
PE
5017 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5018 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5019 Use XFASTINT rather than XUINT when numbers are nonnegative.
5020 (xd_append_arg, Fdbus_method_return_internal):
5021 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5022 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5023 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5024 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5025 (Bug#8722)
2d1fc3c7 5026
c8a9ca5a
PE
5027 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5028
519e1d69
PE
5029 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5030
30569699
PE
5031 ccl: add integer overflow checks
5032 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5033 (IN_INT_RANGE): New macros.
5034 (ccl_driver): Use them to check for integer overflow when
5035 decoding a CCL program. Many of the new checks are whether XINT (x)
5036 fits in int; it doesn't always, on 64-bit hosts. The new version
5037 doesn't catch all possible integer overflows, but it's an
847044ea 5038 improvement. (Bug#8719)
30569699 5039
c11285dc
PE
5040 * alloc.c (make_event_array): Use XINT, not XUINT.
5041 There's no need for unsigned here.
5042
fdccd48e
PE
5043 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5044 This follows up to the 2011-05-06 change that substituted uintptr_t
5045 for EMACS_INT. This case wasn't caught back then.
5046
37910ab2
PE
5047 Rework Fformat to avoid integer overflow issues.
5048 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5049 now (part of C89). Include <verify.h>.
5050 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5051 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5052 (Fformat): Avoid the prepass trying to compute sizes; it was only
5053 approximate and thus did not catch overflow reliably. Instead, walk
5054 through the format just once, formatting and computing sizes as we go,
5055 checking for integer overflow at every step, and allocating a larger
5056 buffer as needed. Keep track separately whether the format is
5057 multibyte. Keep only the most-recently calculated precision, rather
5058 than them all. Record whether each argument has been converted to
5059 string. Use EMACS_INT, not int, for byte and char and arg counts.
5060 Support field widths and precisions larger than INT_MAX. Avoid
5061 sprintf's undefined behavior with conversion specifications such as %#d
5062 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5063 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5064 formatting out-of-range floating point numbers with int
9173deec 5065 formats. (Bug#8668)
37910ab2 5066
2e6578fb
PE
5067 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5068
0ae6bdee
PE
5069 * data.c: Avoid integer truncation in expressions involving floats.
5070 * data.c: Include <intprops.h>.
5071 (arith_driver): When there's an integer overflow in an expression
5072 involving floating point, convert the integers to floating point
5073 so that the resulting value does not suffer from catastrophic
5074 integer truncation. For example, on a 64-bit host (* 4
5075 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5076 Do not rely on undefined behavior after integer overflow.
5077
de883a70
PE
5078 merge count_size_as_multibyte, parse_str_to_multibyte
5079 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5080 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5081 Check for integer overflow.
5082 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5083 since it's now a duplicate of the other. This is more of
5084 a character than a buffer op, so better that it's in character.c.
5085 * fns.c, print.c: Adjust to above changes.
5086
2ff916cb
PE
50872011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5088
5089 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5090
f1b54466
PE
50912011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5092
fb1ac845
PE
5093 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5094 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5095 (x_clipboard_manager_save): Now static.
5096 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5097
f1b54466
PE
5098 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5099 (crypto_hash_function): Now static.
5100 Fix pointer signedness problems. Avoid unnecessary initializations.
5101
a9f737ee
CY
51022011-05-27 Chong Yidong <cyd@stupidchicken.com>
5103
5104 * termhooks.h (Vselection_alist): Make it terminal-local.
5105
5106 * terminal.c (create_terminal): Initialize it.
5107
5108 * xselect.c: Support for clipboard managers.
5109 (Vselection_alist): Move to termhooks.h as terminal-local var.
5110 (LOCAL_SELECTION): New macro.
5111 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5112 (symbol_to_x_atom): Remove gratuitous arg.
5113 (x_handle_selection_request, lisp_data_to_selection_data)
5114 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5115 (x_own_selection, x_get_local_selection, x_convert_selection):
5116 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5117 (some_frame_on_display): Delete unused function.
5118 (Fx_own_selection_internal, Fx_get_selection_internal)
5119 (Fx_disown_selection_internal, Fx_selection_owner_p)
5120 (Fx_selection_exists_p): New optional frame arg.
5121 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5122 (x_handle_selection_clear): Don't treat other terminals with the
5123 same keyboard specially. Use the terminal-local Vselection_alist.
5124 (x_clear_frame_selections): Use Frun_hook_with_args.
5125
5126 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5127
5128 * xterm.h: Add support for those atoms.
5129
e067f0c1
CY
51302011-05-26 Chong Yidong <cyd@stupidchicken.com>
5131
5132 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5133 (converted_selections, conversion_fail_tag): New global variables.
5134 (x_selection_request_lisp_error): Free the above.
5135 (x_get_local_selection): Remove unnecessary code.
5136 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5137 of converted selections stored in converted_selections.
5138 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5139 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5140 (x_convert_selection): New function.
5141 (x_handle_selection_event): Simplify.
5142 (x_get_foreign_selection): Don't ignore incoming requests while
5143 waiting for an answer; this will fail when we implement
5144 SAVE_TARGETS, and seems unnecessary anyway.
5145 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5146 (Vx_sent_selection_functions): Doc fix.
5147
0f4aebc0
LL
51482011-05-26 Leo Liu <sdl.web@gmail.com>
5149
5150 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5151
e61124cd
YM
51522011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5153
5154 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5155
5156 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5157 for fringe update if it has periodic bitmap.
ac389d0c 5158 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5159 and fringe_bitmap_periodic_p.
5160
5161 * fringe.c (get_fringe_bitmap_data): New function.
5162 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5163 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5164 row. Mark glyph row for fringe update if periodicity changed.
5165
5166 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5167 for fringe update unless it has periodic bitmap.
5168
f16d9837
KH
51692011-05-25 Kenichi Handa <handa@m17n.org>
5170
5171 * xdisp.c (get_next_display_element): Set correct it->face_id for
5172 a static composition.
5173
e1b90ef6
LL
51742011-05-24 Leo Liu <sdl.web@gmail.com>
5175
5176 * deps.mk (fns.o):
5177 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5178
5179 * fns.c (crypto_hash_function, Fsha1): New function.
5180 (Fmd5): Use crypto_hash_function.
5181 (syms_of_fns): Add Ssha1.
5182
7400048f
PE
51832011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5184
5185 * gnutls.c: Remove unused macros.
5186 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5187 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5188 Remove macros that are defined and never used.
5189 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5190
abb71cf4
CY
51912011-05-22 Chong Yidong <cyd@stupidchicken.com>
5192
5193 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5194 (Fx_get_selection_internal): Minor cleanup.
5195 (Fx_own_selection_internal): Rename arguments for consistency with
5196 select.el.
5197
6307db39
PE
51982011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5199
5200 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5201
f3d4e0a4
CY
52022011-05-22 Chong Yidong <cyd@stupidchicken.com>
5203
5204 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5205
4d8ade89
YM
52062011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5207
5208 * dispnew.c (scrolling_window): Don't exclude the case that the
5209 last enabled row in the desired matrix touches the bottom boundary.
5210
32078c8d
GM
52112011-05-21 Glenn Morris <rgm@gnu.org>
5212
5213 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5214 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5215 and add some more files.
32078c8d 5216
7285dc67
EZ
52172011-05-20 Eli Zaretskii <eliz@gnu.org>
5218
5219 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5220 report_file_error introduced by the change from 2011-05-07.
5221
89d1bd22
PE
52222011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5223
5224 * systime.h (Time): Define only if emacs is defined.
5225 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5226 where the include path doesn't have X11/X.h by default. See
5227 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5228
e23640bb 52292011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5230
5231 * composite.c (find_automatic_composition): Fix previous change.
5232
b9704ad9
GM
52332011-05-20 Glenn Morris <rgm@gnu.org>
5234
5235 * lisp.mk: New file, split from Makefile.in.
5236 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5237 (shortlisp): Remove.
5238 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5239
4a720484
GM
52402011-05-19 Glenn Morris <rgm@gnu.org>
5241
5242 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5243 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5244 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5245 (lisp): Set the order to that of loadup.el.
5246 (shortlisp): Make it a copy of $lisp.
5247 (SOME_MACHINE_LISP): Remove.
5248 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5249 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5250
a28d4396
KH
52512011-05-18 Kenichi Handa <handa@m17n.org>
5252
5253 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5254 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5255 (find_automatic_composition): Mostly rewrite for efficiency.
5256
a2b1fa8e
JB
52572011-05-18 Juanma Barranquero <lekktu@gmail.com>
5258
5259 * makefile.w32-in: Update dependencies.
5260
8e1f5610
CS
52612011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5262
5263 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5264 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5265
7025ee00 52662011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5267
cdfa6eab
PE
5268 Fix some integer overflow issues, such as string length overflow.
5269
06d6db33
PE
5270 * insdel.c (count_size_as_multibyte): Check for string overflow.
5271
2b4560a8
PE
5272 * character.c (lisp_string_width): Check for string overflow.
5273 Use EMACS_INT, not int, for string indexes and lengths; in
5274 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5275 the resulting string length overflows an EMACS_INT; instead,
5276 report a string overflow if no precision given. When checking for
5277 precision exhaustion, use a check that cannot possibly have
5278 integer overflow. (Bug#8675)
5279 * character.h (lisp_string_width): Adjust to new signature.
5280
cb93f9be
PE
5281 * alloc.c (string_overflow): New function.
5282 (Fmake_string): Use it. This doesn't change behavior, but saves
5283 a few bytes and will simplify future changes.
5284 * character.c (string_escape_byte8): Likewise.
5285 * lisp.h (string_overflow): New decl.
5286
1a1f3366
PE
5287 Fixups, following up to the user-interface timestamp change.
5288 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5289 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5290 * msdos.c (mouse_get_pos): Likewise.
5291 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5292 * w32gui.h (Time): Define by including "systime.h" rather than by
5293 declaring it ourselves. (Bug#8664)
5294
d4e3e4d3
PE
5295 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5296 * image.c (clear_image_cache): Likewise.
5297
f6a24d19
PE
5298 * term.c (term_mouse_position): Don't assume time_t wraparound.
5299
08dc5ae6
PE
5300 Be more systematic about user-interface timestamps.
5301 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5302 and sometimes 'EMACS_UINT', to represent these timestamps.
5303 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5304 This makes the code easier to follow, and makes it easier to catch
5305 integer overflow bugs such as Bug#8664.
5306 * frame.c (Fmouse_position, Fmouse_pixel_position):
5307 Use Time, not unsigned long, for user-interface timestamps.
5308 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5309 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5310 * keyboard.h (last_event_timestamp): Likewise.
5311 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5312 * menu.h (xmenu_show): Likewise.
5313 * term.c (term_mouse_position): Likewise.
5314 * termhooks.h (struct input_event.timestamp): Likewise.
5315 (struct terminal.mouse_position_hook): Likewise.
5316 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5317 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5318 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5319 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5320 what it was before.
5321 * menu.h, termhooks.h: Include "systime.h", for Time.
5322
8e55734a
PE
5323 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5324 Don't assume that the difference between two unsigned long values
5325 can fit into an integer. At this point, we know button_down_time
5326 <= event->timestamp, so the difference must be nonnegative, so
5327 there's no need to cast the result if double-click-time is
5328 nonnegative, as it should be; check that it's nonnegative, just in
5329 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5330 apart (about 25 days). (Bug#8664)
8e55734a 5331
841f1b75 5332 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5333 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5334
3e26f69c
PE
5335 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5336 that always fit in int. Use a sentinel instead of a counter, to
5337 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5338 * frame.h (struct frame): Use int for menu_bar_items_used
5339 instead of EMACS_INT, since it always fits in int.
3e26f69c 5340
5cc152c0
PE
5341 * menu.c (grow_menu_items): Check for int overflow.
5342
d89eb65e
PE
5343 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5344
5235bd3e
PE
5345 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5346 Before, the code was not consistent. These values cannot exceed
5347 2**31 - 1 so there's no need to make them unsigned.
5348 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5349 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5350 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5351 as modifiers.
5352 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5353
bc827e23
PE
5354 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5355 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5356 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5357 presumably because the widths might not match.
5358
78eb494e
PE
5359 * window.c (size_window): Avoid needless test at loop start.
5360
04f2d78b
CB
53612011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5362
5363 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5364
d2fc7e3d 53652011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5366
5367 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5368
d2fc7e3d 53692011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5370
5371 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5372 `width' to `bar_area_x' and `bar_area_width', respectively.
5373 (x_scroll_run): Take account of fringe background extension.
5374
04f2d78b
CB
5375 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5376 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5377 `bar_area_width', respectively.
5378 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5379 background extension.
5380
79b70037
GM
53812011-05-10 Jim Meyering <meyering@redhat.com>
5382
5383 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5384
2f142cc5
JB
53852011-05-10 Juanma Barranquero <lekktu@gmail.com>
5386
5387 * image.c (Finit_image_library): Return t for built-in image types,
5388 like pbm and xbm. (Bug#8640)
5389
57679c86
AS
53902011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5391
5392 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5393
888c9e86
EZ
53942011-05-07 Eli Zaretskii <eliz@gnu.org>
5395
b0512a1d
EZ
5396 * w32console.c (Fset_screen_color): Doc fix.
5397 (Fget_screen_color): New function.
5398 (syms_of_ntterm): Defsubr it.
5399
7285dc67
EZ
5400 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5401 unlink the temporary file if Fcall_process didn't create it in the
5402 first place.
5403 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5404 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5405 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5406 cue to call_process_cleanup not to close that handle.
5407
4d3fcc8e
BK
54082011-05-07 Ben Key <bkey76@gmail.com>
5409
5410 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5411 one of two shell specific rules, either bootstrap-temacs-CMD or
5412 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5413 to the previous implementation of the bootstrap-temacs rule.
5414 The bootstrap-temacs-CMD rule is similar to the previous
5415 implementation of the bootstrap-temacs rule except that it
5416 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5417 variable.
5418
5419 These changes, along with some changes to nt/configure.bat,
5420 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5421 earlier fix to add support for --cflags and --ldflags options
5422 that include quotes so that it works whether make uses cmd or
5423 sh as the shell.
5424
b4289b64
MA
54252011-05-06 Michael Albinus <michael.albinus@gmx.de>
5426
5427 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5428 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5429 is a constant.
5430 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5431 a string. Handle both cases.
5432 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5433 (Fdbus_register_method): Use Qinvalid_function.
5434
af4c0e28
JB
54352011-05-06 Juanma Barranquero <lekktu@gmail.com>
5436
5437 * makefile.w32-in: Update dependencies.
5438 (LISP_H): Add inttypes.h and stdin.h.
5439 (PROCESS_H): Add unistd.h.
5440
c51453d9
EZ
54412011-05-06 Eli Zaretskii <eliz@gnu.org>
5442
5443 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5444 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5445
8ff0ac3c 54462011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5447
4c4b566b
PE
5448 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5449
aab2b9b5
PE
5450 * term.c (vfatal): Remove stray call to va_end.
5451 It's not needed and the C Standard doesn't allow it here anyway.
5452
c378da0b
PE
5453 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5454 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5455
288b08c7
PE
5456 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5457 bytes.
5458
e3601888
PE
5459 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5460
db6c0e74
PE
5461 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5462
dd5963ea
PE
5463 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5464
88c9450f
PE
5465 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5466
2f9442b8
PE
5467 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5468
c032b5f8
PE
5469 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5470 * charset.c (Fdefine_charset_internal): Don't initialize
5471 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5472 32-bit int (Bug#8600).
a108c10b
PE
5473
5474 * lread.c (read_integer): Be more consistent with string-to-number.
5475 Use string_to_number to do the actual conversion; this avoids
5476 rounding errors and fixes some other screwups. Without this fix,
5477 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5478 (digit_to_number): Move earlier, for benefit of read_integer.
5479 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5480 not a digit in any supported base. (Bug#8602)
a108c10b 5481
ad5f9eea
PE
5482 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5483
aec1708a
PE
5484 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5485 to match comment at start of function. This also removes a
5486 GCC warning about overflow in a 32+64-bit port.
5487
47be4ab5
PE
5488 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5489
371cac43
PE
5490 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5491 Reported by Stefan Monnier in
5492 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5493 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5494 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5495
d01a7826
PE
5496 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5497 (EMACS_UINTPTR): Likewise, with uintptr_t.
5498
7fd47d5c
PE
5499 * lisp.h: Prefer 64-bit EMACS_INT if available.
5500 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5501 on 32-bit hosts that have 64-bit int, so that they can access
5502 large files.
122b0c86
PE
5503 However, temporarily disable this change unless the temporary
5504 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5505
8727937b
PE
5506 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5507
8ac068ac
PE
5508 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5509 This removes an assumption that EMACS_INT and long are the same
5510 width as pointers. The assumption is true for Emacs porting targets
5511 now, but we want to make other targets possible.
5512 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5513 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5514 In the rest of the code, change types of integers that hold casted
5515 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5516 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5517 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5518 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5519 No need to cast type when ORing.
5520 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5521 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5522 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5523 assume EMACS_INT is the same width as char *.
5524 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5525 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5526 Remove no-longer-needed casts.
5527 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5528 (xg_tool_bar_help_callback, xg_make_tool_item):
5529 Use EMACS_INTPTR to hold an integer
5530 that will be cast to void *; this can avoid a GCC warning
5531 if EMACS_INT is not the same width as void *.
5532 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5533 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5534 (current_message_1, set_message_1):
5535 Use a local to convert to proper width without a cast.
5536 * xmenu.c (dialog_selection_callback): Likewise.
5537
ede49d71
PE
5538 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5539 Also, don't assume VALBITS / RAND_BITS is less than 5,
5540 and don't rely on undefined behavior when shifting a 1 left into
5541 the sign bit.
5542 * lisp.h (get_random): Change signature to match.
5543
2f30ecd0
PE
5544 * lread.c (hash_string): Use size_t, not int, for hash computation.
5545 Normally we prefer signed values; but hashing is special, because
5546 it's better to use unsigned division on hash table sizes so that
5547 the remainder is nonnegative. Also, size_t is the natural width
5548 for hashing into memory. The previous code used 'int', which doesn't
5549 retain enough info to hash well into very large tables.
5550 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5551
2a866e7b
PE
5552 * dbusbind.c: Don't possibly lose pointer info when converting.
5553 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5554 Use XPNTR rather than XHASH, so that the high-order bits of
5555 the pointer aren't lost when converting through void *.
5556
51639eac
PE
5557 * eval.c (Fautoload): Don't double-shift a pointer.
5558
92394119
PE
5559 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5560
dbdb9a7c
JB
55612011-05-06 Juanma Barranquero <lekktu@gmail.com>
5562
5563 * gnutls.c (DEF_GNUTLS_FN):
5564 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5565
db7a0b4f
AS
55662011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5567
5568 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5569 marker. (Bug#8610)
5570
f7ff1b0f 55712011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5572
5573 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5574 New version that can reserve upto 2GB of heap space.
5575
f7ff1b0f 55762011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5577
5578 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5579
639c109b
TZ
55802011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5581
5582 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5583 `gnutls_certificate_set_x509_key_file'.
5584
d2127135
JB
55852011-05-05 Juanma Barranquero <lekktu@gmail.com>
5586
5587 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5588 Update dependencies.
5589
e968f4f3
JB
55902011-05-04 Juanma Barranquero <lekktu@gmail.com>
5591
5592 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5593 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5594 Remove unused parameter `fildes'.
5595 * process.c (read_process_output, send_process): Don't pass it.
5596
84d358f0
JB
55972011-05-04 Juanma Barranquero <lekktu@gmail.com>
5598
5599 Fix previous change: the library cache is defined in w32.c.
5600 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5601 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5602
0898ca10
JB
56032011-05-04 Juanma Barranquero <lekktu@gmail.com>
5604
5605 Implement dynamic loading of GnuTLS on Windows.
5606
5607 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5608 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5609 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5610 Declare.
5611
5612 * gnutls.c (Qgnutls_dll): Define.
5613 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5614 (gnutls_*): Declare function pointers.
5615 (init_gnutls_functions): New function to initialize function pointers.
5616 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5617 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5618 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5619 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5620 (emacs_gnutls_write, emacs_gnutls_read)
5621 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5622 (Fgnutls_available_p): New function.
5623 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5624 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5625 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5626
5627 * image.c: Include w32.h.
5628 (Vimage_type_cache): Delete.
5629 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5630 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5631 (w32_delayed_load): Move to w32.c.
5632
5633 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5634
5635 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5636 (w32_delayed_load): Move from image.c. When loading a library, record
5637 its filename in the :loaded-from property of the library id.
5638 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5639 Initialize and staticpro them.
5640 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5641
5642 * process.c: Include lisp.h before w32.h, not after.
5643 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5644 instead of gnutls_record_check_pending.
5645
5646 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5647
ff4de4aa
TZ
56482011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5649
5650 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5651 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5652 as passed in.
5653
abe95abb
JD
56542011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5655
5656 * xterm.c (x_set_frame_alpha): Do not set property on anything
5657 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5658
e16e55d4
JB
56592011-05-02 Juanma Barranquero <lekktu@gmail.com>
5660
5661 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5662
bafcf6a5
JB
56632011-05-02 Juanma Barranquero <lekktu@gmail.com>
5664
5665 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5666 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5667 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5668 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5669 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5670 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5671 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5672 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5673 (Qgnutls_bootprop_callbacks_verify): Make static.
5674
e7a6747f
AS
56752011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5676
19ed11ba
AS
5677 * callproc.c: Indentation fixup.
5678
e7a6747f 5679 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5680 (wait_for_termination, interruptible_wait_for_termination):
5681 Move after wait_for_termination_1.
e7a6747f 5682
1ef14cb4
LMI
56832011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5684
5685 * sysdep.c (interruptible_wait_for_termination): New function
5686 which is like wait_for_termination, but allows keyboard
5687 interruptions.
5688
5689 * callproc.c (Fcall_process): Add (:file "file") as an option for
5690 the STDOUT buffer.
5691 (Fcall_process_region): Ditto.
5692
330d880c
EZ
56932011-04-30 Eli Zaretskii <eliz@gnu.org>
5694
8db90b73
EZ
5695 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5696 rather than `XVECTOR (FOO)->size'.
5697
330d880c
EZ
5698 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5699 inttypes.h, as a gnulib replacement is used if it not available in
5700 system headers.
5701
15cbd324
EZ
57022011-04-21 Eli Zaretskii <eliz@gnu.org>
5703
5704 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5705 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5706 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5707
5708 * coding.c (coding_alloc_by_realloc): Error out if destination
5709 will grow beyond MOST_POSITIVE_FIXNUM.
5710 (decode_coding_emacs_mule): Abort if there isn't enough place in
5711 charbuf for the composition carryover bytes. Reserve an extra
5712 space for up to 2 characters produced in a loop.
5713 (decode_coding_iso_2022): Abort if there isn't enough place in
5714 charbuf for the composition carryover bytes.
5715
57162011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5717
ae940cca
EZ
5718 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5719 aborting when %lld or %lll format is passed.
5720 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5721 %llo or %llx format is passed. (Bug#8545)
5722
03ab8921
EZ
5723 * window.c (window_scroll_line_based): Use a marker instead of
5724 simple variables to record original value of point. (Bug#7952)
5725
afda1437
EZ
5726 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5727 produced by %s or %c overflows available buffer space. (Bug#8545)
5728
f76dee0c
PE
57292011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5730
5731 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5732 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5733
fdc5744d
JB
57342011-04-28 Juanma Barranquero <lekktu@gmail.com>
5735
5736 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5737
638f053a
JB
57382011-04-28 Juanma Barranquero <lekktu@gmail.com>
5739
5740 * keyboard.c (Qdelayed_warnings_hook): Define.
5741 (command_loop_1): Run `delayed-warnings-hook'
5742 if Vdelayed_warnings_list is non-nil.
5743 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5744 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5745
d178f871
EZ
57462011-04-28 Eli Zaretskii <eliz@gnu.org>
5747
5748 * doprnt.c (doprnt): Don't return value smaller than the buffer
5749 size if the message was truncated. (Bug#8545).
5750
b124fd93
JB
57512011-04-28 Juanma Barranquero <lekktu@gmail.com>
5752
5753 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5754 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5755
e810457d
PE
57562011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5757
5758 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5759
ea51cceb
JB
57602011-04-27 Juanma Barranquero <lekktu@gmail.com>
5761
5762 * makefile.w32-in: Update dependencies.
5763
94dcfacf
EZ
57642011-04-27 Eli Zaretskii <eliz@gnu.org>
5765
5766 Improve `doprnt' and its usage. (Bug#8545)
5767 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5768 `format_end'. Remove support for %l as a conversion specifier.
5769 Don't use xrealloc. Improve diagnostics when the %l size modifier
5770 is used. Update the commentary.
5771
5772 * eval.c (verror): Simplify calculation of size_t.
5773
5774 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5775 messages.
5776
f61f41d7
PE
57772011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5778
5779 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5780 change.
5781
96fb4434
PE
57822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5783
5784 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5785 This makes this file independent of the recent pseudovector change.
5786
671875da 57872011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5788
69e9b5a3
PE
5789 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5790
b5f869a7 5791 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5792 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5793 Remove unused local.
c8926152 5794 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5795
841a1577 5796 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5797 GCC 4.6.0 optimizes based on type-based alias analysis.
5798 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5799 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5800 != &v->size, and therefore "v->size = 1; b->size = 2; return
5801 v->size;" must therefore return 1. This assumption is incorrect
5802 for Emacs, since it type-puns struct Lisp_Vector * with many other
5803 types. To fix this problem, this patch adds a new type struct
f904488f 5804 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5805 and pseudovectors, and helps optimizing compilers not get fooled
5806 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5807 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5808 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5809 the size member.
eab3844f
PE
5810 (XSETPVECTYPE): Rewrite in terms of new macro.
5811 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5812 This is a bit clearer, and further avoids the possibility of
5813 undesirable aliasing.
5814 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5815 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5816 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5817 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5818 (ASIZE): Now uses header.size rather than size.
5819 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5820 to avoid the hassle of writing XVECTOR (foo)->header.size.
5821 (struct vectorlike_header): New type.
eab3844f
PE
5822 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5823 object, to help avoid aliasing.
5824 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5825 (SUBRP): Likewise, since Lisp_Subr is a special case.
5826 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5827 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5828 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5829 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5830 changed to be "header.size" and "header.next".
5831 * buffer.h (struct buffer): Likewise.
5832 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5833 * frame.h (struct frame): Likewise.
5834 * process.h (struct Lisp_Process): Likewise.
5835 * termhooks.h (struct terminal): Likewise.
5836 * window.c (struct save_window_data, struct saved_window): Likewise.
5837 * window.h (struct window): Likewise.
5838 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5839 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5840 * buffer.c (init_buffer_once): Likewise.
5841 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5842 special case.
5843 * process.c (Fformat_network_address): Use local var for size,
5844 for brevity.
5845
0df1eac5
PE
5846 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5847
847ab9d1 5848 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5849 * data.c (atof): Remove decl; no longer used or needed.
5850 (digit_to_number): Move to lread.c.
5851 (Fstring_to_number): Use new string_to_number function, to be
5852 consistent with how the Lisp reader treats infinities and NaNs.
5853 Do not assume that floating-point numbers represent EMACS_INT
5854 without losing information; this is not true on most 64-bit hosts.
5855 Avoid double-rounding errors, by insisting on integers when
5856 parsing non-base-10 numbers, as the documentation specifies.
5857 * lisp.h (string_to_number): New decl, replacing ...
5858 (isfloat_string): Remove.
bc0a5c13 5859 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5860 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5861 appears to have been a coding error. Similarly, do not accept
5862 strings like +-1e0 as floating point numbers. Do not report
5863 overflow for integer overflows unless the base is not 10 which
5864 means we have no simple and reliable way to continue.
5865 Break out the floating-point parsing into a new
5866 function string_to_number, so that Fstring_to_number parses
5867 floating point numbers consistently with the Lisp reader.
04f2d78b 5868 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5869 (E_CHAR, EXP_INT): Remove, replacing with ...
5870 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5871 (string_to_number): New function, replacing isfloat_string.
5872 This function checks for valid syntax and produces the resulting
5873 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5874 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5875 so that overflow for non-base-10 numbers is reported only when
5876 there's no portable and simple way to convert to floating point.
452f4150 5877
67769ffc
PE
5878 * textprop.c (set_text_properties_1): Rewrite for clarity,
5879 and to avoid GCC warning about integer overflow.
5880
c20db43f
PE
5881 * intervals.h (struct interval): Use EMACS_INT for members
5882 where EMACS_UINT might cause problems. See
5883 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5884 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5885 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5886 All uses changed.
37aa2f85
PE
5887 (offset_intervals): Tell GCC not to worry about length overflow
5888 when negating a negative length.
c20db43f 5889
2538aa2f
PE
5890 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5891 (overrun_check_free): Likewise.
5892
f2d3008d
PE
5893 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5894 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5895 word size.
5896
ec8df744
PE
5897 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5898 (gnutls_make_error): Rename local to avoid shadowing.
5899 (gnutls_emacs_global_deinit): ifdef out; not used.
5900 (Fgnutls_boot): Use const for pointer to readonly storage.
5901 Comment out unused local. Fix pointer signedness problems.
5902
640ee02d
PE
5903 * lread.c (openp): Don't stuff size_t into an 'int'.
5904 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5905 about possible signed overflow.
5906
6048fb2a
PE
5907 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5908 (GDK_KEY_g): Don't define if already defined.
5909 (xg_prepare_tooltip): Avoid pointer signedness problem.
5910 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5911
fa3c87e1
PE
5912 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5913 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5914
2172544b
PE
5915 * xfns.c (Fx_window_property): Simplify a bit,
5916 to make a bit faster and to avoid GCC 4.6.0 warning.
5917 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5918
9b821a21
PE
5919 * fns.c (internal_equal): Don't assume size_t fits in int.
5920
3c616cfa
PE
5921 * alloc.c (compact_small_strings): Tighten assertion a little.
5922
c2982e87
PE
5923 Replace pEd with more-general pI, and fix some printf arg casts.
5924 * lisp.h (pI): New macro, generalizing old pEd macro to other
5925 conversion specifiers. For example, use "...%"pI"d..." rather
5926 than "...%"pEd"...".
5927 (pEd): Remove. All uses replaced with similar uses of pI.
5928 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5929 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5930 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5931 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5932 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5933 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5934 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5935 64-bit hosts.
5936 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5937 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5938 * print.c (safe_debug_print, print_object): Likewise.
5939 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5940 to int.
6f04d126
PE
5941 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5942 avoiding the 0 flag, which is not portable.
c2982e87
PE
5943 * process.c (Fmake_network_process): Use pI to avoid cast.
5944 * region-cache.c (pp_cache): Likewise.
5945 * xdisp.c (decode_mode_spec): Likewise.
5946 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5947 behavior on 64-bit hosts with printf arg.
6f04d126 5948 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5949 (x_stop_queuing_selection_requests): Likewise.
5950 (x_get_window_property): Don't truncate byte count to an 'int'
5951 when tracing.
0b432f21 5952
5e073ec7
PE
5953 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5954 here, since it parses constructs like leading '-' and spaces,
5955 which are not wanted; and it overflows with large numbers.
5956 Instead, simply match F[0-9]+, which is what is wanted anyway.
5957
36372bf9
PE
5958 * alloc.c: Remove unportable assumptions about struct layout.
5959 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5960 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5961 (allocate_vectorlike, make_pure_vector): Use the new macros,
5962 plus offsetof, to remove unportable assumptions about struct layout.
5963 These assumptions hold on all porting targets that I know of, but
5964 they are not guaranteed, they're easy to remove, and removing them
5965 makes further changes easier.
5966
0b432f21
PE
5967 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5968 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5969 (string_overrun_cookie): Now const. Use initializers that
5970 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5971 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5972 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5973 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5974 multiple of sizeof (EMACS_INT); it need not be, if
5975 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5976 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5977
895009e1
JB
59782011-04-26 Juanma Barranquero <lekktu@gmail.com>
5979
5980 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5981
6a7a1b0b
TZ
59822011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5983
5984 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5985 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5986 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5987
841a1577 59882011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5989
5990 * lisp.h (Qdebug): List symbol.
895009e1 5991 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5992 * keyboard.c (debug-on-event): New variable.
5993 (handle_user_signal): Break into debugger when debug-on-event
5994 matches the current signal symbol.
5995
f2d3ba6f
DN
59962011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5997
5998 * alloc.c (check_sblock, check_string_bytes)
5999 (check_string_free_list): Convert to standard C.
6000
42ce4c63
TZ
60012011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6002
6003 * w32.c (emacs_gnutls_push): Fix typo.
6004
825cd63c
EZ
60052011-04-25 Eli Zaretskii <eliz@gnu.org>
6006
fb11d64d
EZ
6007 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6008 "cast to pointer from integer of different size".
6009
825cd63c
EZ
6010 Improve doprnt and its use in verror. (Bug#8545)
6011 * doprnt.c (doprnt): Document the set of format control sequences
6012 supported by the function. Use SAFE_ALLOCA instead of always
6013 using `alloca'.
6014
6015 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6016 is one byte too soon. Don't use xrealloc; instead xfree and
6017 xmalloc anew.
6018
e061a11b
TZ
60192011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6020
6021 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6022 callbacks stage.
6023
6024 * gnutls.c: Renamed global_initialized to
6025 gnutls_global_initialized. Added internals for the
6026 :verify-hostname-error, :verify-error, and :verify-flags
6027 parameters of `gnutls-boot' and documented those parameters in the
6028 docstring. Start callback support.
9173deec
JB
6029 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6030 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6031 on error. Return error code.
e061a11b
TZ
6032 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6033 (emacs_gnutls_read): Likewise.
6034 (Fgnutls_boot): Return handshake error code.
6035 (emacs_gnutls_handle_error): New function.
6036 (wsaerror_to_errno): Likewise.
6037
6038 * w32.h (emacs_gnutls_pull): Add prototype.
6039 (emacs_gnutls_push): Likewise.
6040
6041 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6042 (emacs_gnutls_push): Likewise.
6043
60442011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6045
6046 * process.c (wait_reading_process_output): Check if GnuTLS
6047 buffered some data internally if no FDs are set for TLS
6048 connections.
6049
6050 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6051 (LIBS): Link to USER_LIBS.
6052 ($(BLD)/gnutls.$(0)): New target.
6053
fa6996bc
EZ
60542011-04-24 Eli Zaretskii <eliz@gnu.org>
6055
eb35682e
EZ
6056 * xdisp.c (handle_single_display_spec): Rename the
6057 display_replaced_before_p argument into display_replaced_p, to
6058 make it consistent with the commentary. Fix typos in the
6059 commentary.
6060
e2ad650c
EZ
6061 * textprop.c (syms_of_textprop): Remove dead code.
6062 (copy_text_properties): Delete obsolete commentary about an
6063 interface that was deleted long ago. Fix typos in the description
6064 of arguments.
6065
1b2de274
EZ
6066 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6067 to changes in oldXMenu/XMenu.h from 2011-04-16.
6068 <menu_help_message, prev_menu_help_message>: Constify.
6069 (IT_menu_make_room): menu->help_text is now `const char **';
6070 adjust.
6071
6072 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6073 to changes in oldXMenu/XMenu.h from 2011-04-16.
6074 (struct XMenu): Declare `help_text' `const char **'.
6075
6076 * xfaces.c <Qunspecified>: Make extern again.
6077
6078 * syntax.c: Include sys/types.h before including regex.h, as
6079 required by Posix.
6080
762b15be
EZ
6081 * doc.c (get_doc_string): Improve the format passed to `error'.
6082
6083 * doprnt.c (doprnt): Improve commentary.
6084
6085 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6086
6087 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6088 them with etags.
6089
f1052e5d
EZ
6090 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6091 changes in globals.h immediately force recompilation.
762b15be
EZ
6092 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6093 $(CURDIR)/s/ms-w32.h.
6094 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6095
fa6996bc
EZ
6096 * character.c (Fchar_direction): Function deleted.
6097 (syms_of_character): Don't defsubr it.
6098 <char-direction-table>: Deleted.
6099
e6c3da20
EZ
61002011-04-23 Eli Zaretskii <eliz@gnu.org>
6101
6102 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6103 * doprnt.c: Include limits.h.
6104 (SIZE_MAX): New macro.
04f2d78b
CB
6105 (doprnt): Return a size_t value. 2nd arg is now size_t.
6106 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6107 Improve overflow protection. Support `l' modifier for integer
6108 conversions. Support %l conversion. Don't assume an EMACS_INT
6109 argument for integer conversions and for %c.
6110
6111 * lisp.h (doprnt): Restore prototype.
6112
6113 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6114 $(SRC)/character.h.
6115
6116 * Makefile.in (base_obj): Add back doprnt.o.
6117
6118 * deps.mk (doprnt.o): Add back prerequisites.
6119 (callint.o): Depend on character.h.
6120
6121 * eval.c (internal_lisp_condition_case): Include the handler
6122 representation in the error message.
6123 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6124 when breaking from the loop.
6125
6126 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6127
6128 * callint.c (Fcall_interactively): When displaying error message
6129 about invalid control letter, pass the character's codepoint, not
6130 a pointer to its multibyte form. Improve display of the character
6131 in octal and display also its hex code.
6132
6133 * character.c (char_string): Use %x to display the (unsigned)
6134 codepoint of an invalid character, to avoid displaying a bogus
6135 negative value.
6136
6137 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6138 `error', not SYMBOL_NAME itself.
6139
6140 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6141 character arguments to `error'.
6142
6143 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6144 to `error' in error message about FINAL_CHAR argument. Make sure
6145 FINAL_CHAR is a character, and use %c when it is passed as
6146 argument to `error'.
6147
4ffd0d6b 61482011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6149
6150 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6151
6152 * w32.c: Include <time.h>.
6153 (sys_localtime): New function.
6154
4ffd0d6b 61552011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6156
6157 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6158
4ffd0d6b 6159 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6160
4ffd0d6b 61612011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6162
4ffd0d6b
GM
6163 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6164 zombies (Bug#8467).
aac0c6e3 6165
04c56954
EZ
61662011-04-19 Eli Zaretskii <eliz@gnu.org>
6167
6168 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6169 gl_state.e_property when gl_state.object is Qt.
6170
6171 * insdel.c (make_gap_larger): Remove limitation of buffer size
6172 to <= INT_MAX.
6173
16a43933
CY
61742011-04-18 Chong Yidong <cyd@stupidchicken.com>
6175
6176 * xdisp.c (lookup_glyphless_char_display)
6177 (produce_glyphless_glyph): Handle cons cell entry in
6178 glyphless-char-display.
6179 (Vglyphless_char_display): Document it.
6180
6181 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6182 glyphless-char-display.
6183
4581706e
CY
61842011-04-17 Chong Yidong <cyd@stupidchicken.com>
6185
6186 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6187
6188 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6189
6190 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6191 definition for no-X builds.
6192
4887c6e2 61932011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6194
fd35b6f9
PE
6195 Static checks with GCC 4.6.0 and non-default toolkits.
6196
5c1ccb01
PE
6197 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6198
006c5daa
PE
6199 * process.c (keyboard_bit_set): Define only if SIGIO.
6200 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6201 (send_process): Repair possible setjmp clobbering.
6202
efc736d3
PE
6203 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6204
4e2fe2e6
PE
6205 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6206
f97334a2
PE
6207 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6208
4e75f29d
PE
6209 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6210 Define only if needed.
6211
90efadd1
PE
6212 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6213 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6214 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6215
3c647824
PE
6216 * dispextern.h (struct redisplay_interface): Rename param
6217 to avoid shadowing.
e264f262 6218 * termhooks.h (struct terminal): Likewise.
761383f4 6219 * xterm.c (xembed_send_message): Likewise.
3c647824 6220
b58c5c4a
PE
6221 * insdel.c (make_gap_smaller): Define only if
6222 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6223
cad59032
PE
6224 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6225 it.
6226
c339dc2e
PE
6227 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6228 so that we aren't warned about unused symbols.
6229
91a3e27b
PE
6230 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6231
399c71d3 6232 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6233
8ffc96f5
PE
6234 * xfns.c (x_real_positions): Mark locals as initialized.
6235
eef9bc79
PE
6236 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6237
098db9dd
PE
6238 * xterm.c: Fix problems found by static analysis with other toolkits.
6239 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6240 (x_dispatch_event): Declare static if USE_GTK, and
6241 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6242 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6243 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6244 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6245 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6246
eb18f6cc
PE
6247 * xmenu.c (menu_help_callback): Pointer type fixes.
6248 Use const pointers when pointing at readonly data. Avoid pointer
6249 signedness clashes.
6250 (FALSE): Remove unused macro.
6251 (update_frame_menubar): Remove unused decl.
6252
1fe72bf8
PE
6253 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6254
60d9e1db
PE
6255 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6256 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6257 (single_menu_item): Rename local to avoid shadowing.
6258
39261c26
PE
6259 * keyboard.c (make_lispy_event): Remove unused local var.
6260
018c5e19
PE
6261 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6262 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6263
63d2b86e
PE
6264 * bitmaps: Change bitmaps from unsigned char back to the X11
6265 compatible char. Avoid the old compiler warnings about
6266 out-of-range initializers by using, for example, '\xab' rather
6267 than 0xab.
6268
aefd87e1
PE
6269 * xgselect.c (xgselect_initialize): Check vs interface
6270 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6271
bf501fb9
PE
6272 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6273
e9829fdf
PE
6274 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6275 to read-only memory.
6276
1086c095
PE
6277 * fns.c (vector): Remove; this old hack is no longer needed.
6278
2baccd04 6279 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6280 Remove unused var.
dde42981 6281 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6282
72391843 6283 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6284
436c16df 6285 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6286 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6287 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6288
92bb796d 6289 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6290 (x_term_init): Remove local to avoid shadowing.
92bb796d 6291
764430a3 6292 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6293
6294 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6295 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6296
d1dfb56c
EZ
62972011-04-16 Eli Zaretskii <eliz@gnu.org>
6298
c4354cb4
EZ
6299 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6300
d1dfb56c
EZ
6301 Fix regex.c, syntax.c and friends for buffers > 2GB.
6302 * syntax.h (struct gl_state_s): Declare character position members
6303 EMACS_INT.
6304
6305 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6306
04f2d78b
CB
6307 * textprop.c (verify_interval_modification, interval_of):
6308 Declare arguments EMACS_INT.
d1dfb56c
EZ
6309
6310 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6311 EMACS_INT.
6312
6313 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6314
6315 * indent.c (Fvertical_motion): Local variable it_start is now
6316 EMACS_INT.
6317
6318 * regex.c (re_match, re_match_2, re_match_2_internal)
6319 (bcmp_translate, regcomp, regexec, print_double_string)
6320 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6321 (re_compile_pattern, re_exec): Declare arguments and local
6322 variables `size_t' and `ssize_t' and return values `regoff_t', as
6323 appropriate.
6324 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6325 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6326 <compile_stack_type>: `size' and `avail' are now `size_t'.
6327
6328 * regex.h <regoff_t>: Use ssize_t, not int.
6329 (re_search, re_search_2, re_match, re_match_2): Arguments that
6330 specify buffer/string position and length are now ssize_t and
6331 size_t. Return type is regoff_t.
6332
613052cd
BK
63332011-04-16 Ben Key <bkey76@gmail.com>
6334
6335 * nsfont.m: Fixed bugs in ns_get_family and
6336 ns_descriptor_to_entity that were caused by using free to
6337 deallocate memory blocks that were allocated by xmalloc (via
6338 xstrdup). This caused Emacs to crash when compiled with
6339 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6340 --enable-checking=xmallocoverrun). xfree is now used to
6341 deallocate these memory blocks.
6342
4170f62f 63432011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6344
71b41406
PE
6345 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6346
9587a89d
PE
6347 emacs_write: Accept and return EMACS_INT for sizes.
6348 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6349 et seq.
6350 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6351 Accept and return EMACS_INT.
6352 (emacs_gnutls_write): Return the number of bytes written on
6353 partial writes.
6354 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6355 (emacs_read, emacs_write): Remove check for negative size, as the
6356 Emacs source code has been audited now.
9587a89d
PE
6357 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6358 (emacs_read, emacs_write): Use it.
273a5f82
PE
6359 * process.c (send_process): Adjust to the new signatures of
6360 emacs_write and emacs_gnutls_write. Do not attempt to store
6361 a byte offset into an 'int'; it might overflow.
9587a89d 6362 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6363
3e047f51
PE
6364 * sound.c: Don't assume sizes fit in 'int'.
6365 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6366 Return EMACS_INT, not int.
3e047f51 6367 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6368 Accept EMACS_INT, not int.
6369 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6370 record read return values.
6371
cc39a9db
BK
63722011-04-15 Ben Key <bkey76@gmail.com>
6373
c9d0ec6d
JB
6374 * keyboard.c (Qundefined): Don't declare static since it is used
6375 in nsfns.m.
6376 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6377 static since they are used in nsfont.m.
cc39a9db 6378
6c60eb9f
SM
63792011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6380
6381 * process.c (Qprocessp): Don't declare static.
6382 * lisp.h (Qprocessp): Declare again.
6383
7990b61a
JB
63842011-04-15 Juanma Barranquero <lekktu@gmail.com>
6385
6386 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6387
5d4cb038
PE
63882011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6389
8bd7b830 6390 Improve C-level modularity by making more things 'static'.
cd64ea1d 6391
e3b27b31
PE
6392 Don't publish debugger-only interfaces to other modules.
6393 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6394 (verify_bytepos, count_markers): Move decls to the only modules
6395 that need them.
6396 * region-cache.h (pp_cache): Likewise.
6397 * window.h (check_all_windows): Likewise.
6398 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6399
5d4cb038
PE
6400 * sysdep.c (croak): Now static, if
6401 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6402 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6403
6404 * alloc.c (refill_memory_reserve): Now static if
6405 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6406 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6407
e87b6180
PE
6408 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6409 Define only if USE_LUCID.
6410
ac64929e
PE
6411 * xrdb.c (x_customization_string, x_rm_string): Now static.
6412
6f37259d
PE
6413 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6414 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6415
1683e3ab
PE
6416 * xdisp.c (draw_row_with_mouse_face): Now static.
6417 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6418
de9c2632
PE
6419 * window.h (check_all_windows): Mark externally visible.
6420
2b96acb7
PE
6421 * window.c (window_deletion_count): Now static.
6422
6423 * undo.c: Make symbols static if they're not exported.
6424 (last_undo_buffer, last_boundary_position, pending_boundary):
6425 Now static.
6426
50436f33
PE
6427 * textprop.c (interval_insert_behind_hooks): Now static.
6428 (interval_insert_in_front_hooks): Likewise.
6429
64520e5c
PE
6430 * term.c: Make symbols static if they're not exported.
6431 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6432 (max_frame_lines, tty_set_terminal_modes):
6433 (tty_reset_terminal_modes, tty_turn_off_highlight):
6434 (get_tty_terminal): Now static.
6435 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6436 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6437 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6438 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6439 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6440
1fa53021
PE
6441 * sysdep.c: Make symbols static if they're not exported.
6442 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6443 Now static.
6444 (sigprocmask_set, full_mask): Remove; unused.
6445 (wait_debugging): Mark as visible.
6446 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6447 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6448
d4b43b22
PE
6449 * syntax.c (syntax_temp): Define only if !__GNUC__.
6450
b7c513d0
PE
6451 * sound.c (current_sound_device, current_sound): Now static.
6452
989b29ad
PE
6453 * search.c (searchbufs, searchbuf_head): Now static.
6454
13a55a78
PE
6455 * scroll.c (scroll_cost): Remove; unused.
6456 * dispextern.h (scroll_cost): Remove decl.
6457
de68a1fc
PE
6458 * region-cache.h (pp_cache): Mark as externally visible.
6459
40ccffa6
PE
6460 * process.c: Make symbols static if they're not exported.
6461 (process_tick, update_tick, create_process, chan_process):
6462 (Vprocess_alist, proc_buffered_char, datagram_access):
6463 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6464 (deactivate_process): Mark defn as static, as well as decl.
6465 * lisp.h (create_process): Remove decl.
6466 * process.h (chan_process, Vprocess_alist): Remove decls.
6467
ad64fc97
PE
6468 * print.c: Make symbols static if they're not exported.
6469 (print_depth, new_backquote_output, being_printed, print_buffer):
6470 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6471 (print_interval, print_number_index, initial_stderr_stream):
6472 Now static.
6473 * lisp.h (Fprinc): Remove decl.
6474 (debug_output_compilation_hack): Mark as externally visible.
6475
adddb265
PE
6476 * sysdep.c (croak): Move decl from here to syssignal.h.
6477 * syssignal.h (croak): Put it here, so the API can be checked when
6478 'croak' is called from dissociate_if_controlling_tty.
6479
1717ede2
PE
6480 * minibuf.c: Make symbols static if they're not exported.
6481 (minibuf_save_list, choose_minibuf_frame): Now static.
6482 * lisp.h (choose_minibuf_frame): Remove decl.
6483
fa5fb2bc
PE
6484 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6485
1e3890d1
PE
6486 * lread.c: Make symbols static if they're not exported.
6487 (read_objects, initial_obarray, oblookup_last_bucket_number):
6488 Now static.
6489 (make_symbol): Remove; unused.
6490 * lisp.h (initial_obarray, make_symbol): Remove decls.
6491
8a1414fa
PE
6492 * keyboard.c: Make symbols static if they're not exported.
6493 (single_kboard, recent_keys_index, total_keys, recent_keys):
6494 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6495 (this_single_command_key_start, echoing, last_auto_save):
6496 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6497 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6498 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6499 (Vlispy_mouse_stem, double_click_count):
6500 Now static.
6501 (force_auto_save_soon): Define only if SIGDANGER.
6502 (ignore_mouse_drag_p): Now static if
6503 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6504 (print_help): Remove; unused.
6505 (stop_character, last_timer_event): Mark as externally visible.
6506 * keyboard.h (ignore_mouse_drag_p): Declare only if
6507 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6508 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6509 * lisp.h (echoing): Remove decl.
6510 (force_auto_save_soon): Declare only if SIGDANGER.
6511 * xdisp.c (redisplay_window): Simplify code, to make it more
6512 obvious that ignore_mouse_drag_p is not accessed if !defined
6513 USE_GTK && !defined HAVE_NS.
6514
93ea6e8f
PE
6515 * intervals.c: Make symbols static if they're not exported.
6516 (merge_properties_sticky, merge_interval_right, delete_interval):
6517 Now static.
6518 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6519
77382fcc
PE
6520 * insdel.c: Make symbols static if they're not exported.
6521 However, leave prepare_to_modify_buffer alone. It's never
6522 called from outside this function, but that appears to be a bug.
6523 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6524 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6525 (adjust_after_replace_noundo): Remove; unused.
6526 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6527 (signal_before_change): Remove decls.
77382fcc 6528
9306c32e
PE
6529 * indent.c (val_compute_motion, val_vmotion): Now static.
6530
cd44d2eb
PE
6531 * image.c: Make symbols static if they're not exported.
6532 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6533 if USE_GTK.
6534 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6535 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6536
ad9a7a06
PE
6537 * fringe.c (standard_bitmaps): Now static.
6538 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6539
81626931
PE
6540 * frame.c: Make symbols static if they're not exported.
6541 (x_report_frame_params, make_terminal_frame): Now static.
6542 (get_frame_param): Now static, unless HAVE_NS.
6543 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6544 (x_get_resource_string): Remove; not used.
6545 * frame.h (make_terminal_frame, x_report_frame_params):
6546 (x_get_resource_string); Remove decls.
6547 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6548 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6549
239f9db9
PE
6550 * font.c, fontset.c: Make symbols static if they're not exported.
6551 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6552 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6553 * font.c (font_close_object): Now static.
6554 * font.h (font_close_object): Remove.
6555 * fontset.c (FONTSET_OBJLIST): Remove.
6556 (free_realized_fontset) #if-0 the body, which does nothing.
6557 (face_suitable_for_char_p): #if-0, as it's never called.
6558 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6559 * xfaces.c (face_at_string_position):
6560 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6561 since 0 is always ASCII.
6562
dfcf3579
PE
6563 * fns.c (weak_hash_tables): Now static.
6564
5045092b
PE
6565 * fileio.c: Make symbols static if they're not exported.
6566 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6567 (Vwrite_region_annotation_buffers): Now static.
6568
57a96f5c
PE
6569 * eval.c: Make symbols static if they're not exported.
6570 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6571 * lisp.h (backtrace_list): Remove decl.
6572
35f08c38
PE
6573 * emacs.c: Make symbols static if they're not exported.
6574 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6575 (fatal_error_code, fatal_error_signal_hook, standard_args):
6576 Now static.
6577 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6578 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6579 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6580 * lisp.h (fatal_error_signal_hook): Remove decl.
6581 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6582
f44bd759
PE
6583 * editfns.c: Move a (normally-unused) function to its only use.
6584 * editfns.c, lisp.h (get_operating_system_release): Remove.
6585 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6586 worth the hassle of breaking this out.
6587
b532497d
PE
6588 * xterm.c: Make symbols static if they're not exported.
6589 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6590 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6591 (x_destroy_window, x_delete_display):
6592 Now static.
6593 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6594 (x_mouse_leave): Remove; unused.
6595 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6596 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6597 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6598 Remove decls.
6599 (x_mouse_leave): Declare only if WINDOWSNT.
6600 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6601 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6602 USE_X_TOOLKIT.
6603
1675728f
PE
6604 * ftxfont.c: Make symbols static if they're not exported.
6605 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6606 HAVE_FREETYPE.
6607 * font.h (ftxfont_driver): Likewise.
6608
e4cebfca
PE
6609 * xfns.c: Make symbols static if they're not exported.
6610 (x_last_font_name, x_display_info_for_name):
6611 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6612 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6613 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6614 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6615 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6616 (last_show_tip_args): Now static.
6617 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6618 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6619 (x_screen_planes): Remove; unused.
6620 * dispextern.h (x_screen_planes): Remove decl.
6621
5bf46f05
PE
6622 * dispnew.c: Make symbols static if they're not exported.
6623 * dispextern.h (redraw_garbaged_frames, scrolling):
6624 (increment_row_positions): Remove.
6625 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6626 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6627 Now static.
6628 (redraw_garbaged_frames): Remove; unused.
6629
435f4c28
PE
6630 * xfaces.c: Make symbols static if they're not exported.
6631 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6632 Remove decls.
6633 * xterm.h (defined_color): Remove decls.
6634 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6635 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6636 (menu_face_changed_default, defined_color, free_realized_face):
6637 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6638 (ascii_face_of_lisp_face): Remove; unused.
6639
8524aef3
PE
6640 * xdisp.c: Make symbols static if they're not exported.
6641 * dispextern.h (scratch_glyph_row, window_box_edges):
6642 (glyph_to_pixel_coords, set_cursor_from_row):
6643 (get_next_display_element, set_iterator_to_next):
6644 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6645 (show_mouse_face): Remove decls
6646 * frame.h (message_buf_print): Likewise.
6647 * lisp.h (pop_message, set_message, check_point_in_composition):
6648 Likewise.
6649 * xterm.h (set_vertical_scroll_bar): Likewise.
6650 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6651 (message_buf_print, scratch_glyph_row, displayed_buffer):
6652 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6653 (get_next_display_element, show_mouse_face, window_box_edges):
6654 (frame_to_window_pixel_xy, check_point_in_composition):
6655 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6656 (glyph_to_pixel_coords): Remove; unused.
6657
16390cd2
PE
6658 * dired.c (file_name_completion): Now static.
6659
6660 * dbusbind.c (xd_in_read_queued_messages): Now static.
6661
a25f4dfa
PE
6662 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6663 * data.c (circular_list_error): Remove.
6664
14a9c8df
PE
6665 * commands.h (last_point_position, last_point_position_buffer):
6666 (last_point_position_window): Remove decls.
6667 * keyboard.c: Make these variables static.
6668
04f2d78b
CB
6669 * coding.h (coding, code_convert_region, encode_coding_gap):
6670 Remove decls.
74ab6df5
PE
6671 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6672 (iso_code_class, detect_coding, code_convert_region): Now static.
6673 (encode_coding_gap): Remove; unused.
6674
38dfbee1
PE
6675 * chartab.c (chartab_chars, chartab_bits): Now static.
6676
a2cb4e63
PE
6677 * charset.h (charset_iso_8859_1): Remove decl.
6678 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6679 Now static.
6680
127198fd
PE
6681 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6682 * ccl.c (Vccl_program_table): Now static.
6683 (check_ccl_update): Remove; unused.
6684
d85b608f
PE
6685 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6686 * category.h: ... from here.
6687 * category.c (check_category_table, set_category_set): Now static.
6688
31cd66f3
PE
6689 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6690 * lisp.h: Remove these decls.
6691
c358e587
PE
6692 * buffer.c (buffer_count): Remove unused var.
6693
e78aecca
PE
6694 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6695 so that it's not optimized away.
6696 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6697 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6698 exported only to the debugger.
6699
e192d7d3 6700 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6701 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6702
92470028
PE
6703 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6704 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6705 was inaccessible from Lisp.
6706 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6707 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6708
244ed907
PE
6709 alloc.c: Import and export fewer symbols, and remove unused items.
6710 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6711 is defined.
6712 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6713 it's not optimized away by whole-program optimization.
6714 (message_enable_multibyte, free_misc): Remove.
6715 (catchlist, handlerlist, mark_backtrace):
6716 Declare only if BYTE_MARK_STACK.
6717 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6718 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6719 (message_enable_multibyte): Remove decl.
6720 (free_misc, interval_free_list, float_block, float_block_index):
6721 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6722 (cons_free_list, last_marked_index):
6723 Now static.
6724 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6725 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6726 (mark_backtrace): Define only if BYTE_MARK_STACK.
6727 * xdisp.c (message_enable_multibyte): Now static.
6728
61c2b50e 6729 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6730 This makes it easier for human readers (and static analyzers)
6731 to see whether these variables are used from other modules.
6732 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6733 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6734 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6735 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6736 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6737 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6738 * xmenu.c, xselect.c:
6739 Declare Q* vars static if they are not used in other modules.
6740 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6741 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6742 Remove decls of unexported vars.
6743 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6744
95c82688
PE
6745 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6746
16a97296
PE
6747 Make Emacs functions such as Fatom 'static' by default.
6748 This makes it easier for human readers (and static analyzers)
6749 to see whether these functions can be called from other modules.
6750 DEFUN now defines a static function. To make the function external
6751 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6752 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6753 (Finit_image_library):
16a97296
PE
6754 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6755 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6756 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6757 Remove decls, since these functions are now static.
6758 (Funintern, Fget_internal_run_time): New decls, since these functions
6759 were already external.
95c82688 6760
16a97296
PE
6761 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6762 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6763 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6764 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6765 * keyboard.c, keymap.c, lread.c:
6766 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6767 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6768 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6769 Mark functions with DEFUE instead of DEFUN,
6770 if they are used in other modules.
6771 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6772 decls for now-static functions.
6773 * buffer.h (Fdelete_overlay): Remove decl.
6774 * callproc.c (Fgetenv_internal): Mark as internal.
6775 * composite.c (Fremove_list_of_text_properties): Remove decl.
6776 (Fcomposition_get_gstring): New forward static decl.
6777 * composite.h (Fcomposite_get_gstring): Remove decl.
6778 * dired.c (Ffile_attributes): New forward static decl.
6779 * doc.c (Fdocumntation_property): New forward static decl.
6780 * eval.c (Ffetch_bytecode): New forward static decl.
6781 (Funintern): Remove extern decl; now in .h file where it belongs.
6782 * fileio.c (Fmake_symbolic_link): New forward static decl.
6783 * image.c (Finit_image_library): New forward static decl.
6784 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6785 * intervals.h (Fprevious_property_change):
6786 (Fremove_list_of_text_properties): Remove decls.
6787 * keyboard.c (Fthis_command_keys): Remove decl.
6788 (Fcommand_execute): New forward static decl.
6789 * keymap.c (Flookup_key): New forward static decl.
6790 (Fcopy_keymap): Now static.
6791 * keymap.h (Flookup_key): Remove decl.
6792 * process.c (Fget_process): New forward static decl.
6793 (Fprocess_datagram_address): Mark as internal.
6794 * syntax.c (Fsyntax_table_p): New forward static decl.
6795 (skip_chars): Remove duplicate decl.
6796 * textprop.c (Fprevious_property_change): New forward static decl.
6797 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6798 Now internal.
6799 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6800 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6801
785bbd42
PE
6802 * editfns.c (Fformat): Remove unreachable code.
6803
8b913b57
AS
68042011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6805
6806 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6807 change. (Bug#8496)
6808
a6744a35
EZ
68092011-04-13 Eli Zaretskii <eliz@gnu.org>
6810
6811 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6812 when at ZV. (Bug#8487)
6813
e7974947
AS
68142011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6815
baad03f0
AS
6816 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6817 (Bug#8437)
6818 * keyboard.c (parse_tool_bar_item): Likewise.
6819 * sound.c (sound_cleanup, alsa_close): Likewise.
6820 * termcap.c (tgetent): Likewise.
6821 * xfns.c (x_default_font_parameter): Likewise.
6822 * xsettings.c (read_and_apply_settings): Likewise.
6823
e7974947
AS
6824 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6825 (overrun_check_free): Protoize.
6826
28272684
PE
68272011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6828
6829 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6830 since callers should never pass a negative size.
6831 Change the signature to match that of plain 'read' and 'write'; see
6832 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6833 * lisp.h: Update prototypes of emacs_write and emacs_read.
6834
11997c76
EZ
68352011-04-11 Eli Zaretskii <eliz@gnu.org>
6836
6837 * xdisp.c (redisplay_window): Don't try to determine the character
6838 position of the scroll margin if the window start point w->startp
e896f03c 6839 is outside the buffer's accessible region. (Bug#8468)
11997c76 6840
8a2cbd72
EZ
68412011-04-10 Eli Zaretskii <eliz@gnu.org>
6842
6843 Fix write-region and its subroutines for buffers > 2GB.
6844 * fileio.c (a_write, e_write): Modify declaration of arguments and
6845 local variables to support buffers larger than 2GB.
6846 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6847
6848 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6849 argument, local variables, and return value.
6850
6851 * lisp.h: Update prototypes of emacs_write and emacs_read.
6852
6853 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6854
4073e537 68552011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6856
1ebfdcb6
PE
6857 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6858
b2ded58d
PE
6859 Fix more problems found by GCC 4.6.0's static checks.
6860
7d66342c
PE
6861 * xdisp.c (vmessage): Use a better test for character truncation.
6862
bbf47d44
PE
6863 * charset.c (load_charset_map): <, not <=, for optimization,
6864 and to avoid potential problems with integer overflow.
9248994d 6865 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6866 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6867 * editfns.c (Fformat): Likewise.
1e69125e 6868 * syntax.c (skip_chars): Likewise.
3befa583 6869
e3019616
PE
6870 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6871 This also lets GCC 4.6.0 generate slightly better loop code.
6872
becfa255
PE
6873 * callint.c (Fcall_interactively): <, not <=, for optimization.
6874 (Fcall_interactively): Count the number of arguments produced,
6875 not the number of arguments given. This is simpler and lets GCC
6876 4.6.0 generate slightly better code.
6877
dae0cd48
PE
6878 * ftfont.c: Distingish more carefully between FcChar8 and char.
6879 The previous code passed unsigned char * to a functions like
6880 strlen and xstrcasecmp that expect char *, which does not
6881 conform to the C standard.
6882 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6883 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6884 char * when the C standard requires it.
6885
76032d70
PE
6886 * keyboard.c (read_char): Remove unused var.
6887
eb3f1cc8
PE
6888 * eval.c: Port to Windows vsnprintf (Bug#8435).
6889 Include <limits.h>.
6890 (SIZE_MAX): Define if the headers do not.
6891 (verror): Do not give up if vsnprintf returns a negative count.
6892 Instead, grow the buffer. This ports to Windows vsnprintf, which
6893 does not conform to C99. Problem reported by Eli Zaretskii.
6894 Also, simplify the allocation scheme, by avoiding the need for
6895 calling realloc, and removing the ALLOCATED variable.
6896
70476b54
PE
6897 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6898
12020a9e
PE
6899 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6900 But keep the doprint source code for now, as we might revamp it
6901 and use it again (Bug#8435).
ea6c7ae6
PE
6902 * lisp.h (doprnt): Remove.
6903 * Makefile.in (base_obj): Remove doprnt.o.
6904 * deps.mk (doprnt.o): Remove.
6905
5fdb398c
PE
6906 error: Print 32- and 64-bit integers portably (Bug#8435).
6907 Without this change, on typical 64-bit hosts error ("...%d...", N)
6908 was used to print both 32- and 64-bit integers N, which relied on
6909 undefined behavior.
6910 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6911 New macro.
6912 * lisp.h (error, verror): Mark as printf-like functions.
6913 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6914 Report overflow in size calculations when allocating printf buffer.
6915 Do not truncate output string at its first null byte.
6916 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6917 Truncate the output at a character boundary, since vsnprintf does not
6918 do that.
6919 * charset.c (check_iso_charset_parameter): Convert internal
6920 character to string before calling 'error', since %c now has the
6921 printf meaning.
6922 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6923 overflow when computing char to be passed to 'error'. Do not
6924 pass Lisp_Object to 'error'; pass the integer instead.
6925 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6926 formatted with plain %d.
6927
b189fa66
PE
6928 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6929
bff87ef0
PE
6930 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6931
7e2cac20
PE
6932 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6933
ce4d90b5
PE
6934 * xterm.c (x_catch_errors): Remove duplicate declaration.
6935
266c9547
PE
6936 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6937
79c49ad2
PE
6938 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6939
368f4090
JM
69402011-04-10 Jim Meyering <meyering@redhat.com>
6941
6942 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6943 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6944 return ssize_t not "int", and use size_t as the buffer length.
6945 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6946 * gnutls.h: Update declarations.
6947 * process.c (read_process_output): Use ssize_t, to match.
6948 (send_process): Likewise.
6949
a32d4040
CY
69502011-04-09 Chong Yidong <cyd@stupidchicken.com>
6951
6952 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6953
8546720e 69542011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6955
04f2d78b
CB
6956 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6957 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6958
8546720e
GM
6959 * xterm.c (handle_one_xevent):
6960 * xmenu.c (create_and_show_popup_menu):
6961 * xselect.c (x_decline_selection_request)
6962 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6963
0a2f5c1a 69642011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6965
6966 Fix some uses of `int' instead of EMACS_INT.
6967 * search.c (string_match_1, fast_string_match)
6968 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6969 (scan_buffer, find_next_newline_no_quit)
6970 (find_before_next_newline, search_command, Freplace_match)
6971 (Fmatch_data): Make some `int' variables be EMACS_INT.
6972
6973 * xdisp.c (display_count_lines): 3rd argument and return value now
6974 EMACS_INT. All callers changed.
6975 (pint2hrstr): Last argument is now EMACS_INT.
6976
6977 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6978 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6979 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6980 (decode_coding_utf_16, decode_coding_emacs_mule)
6981 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6982 (decode_coding_ccl, decode_coding_charset)
6983 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6984 (decode_coding_iso_2022, decode_coding_emacs_mule)
6985 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6986 <char_offset, last_offset>: Declare EMACS_INT.
6987 (encode_coding_utf_8, encode_coding_utf_16)
6988 (encode_coding_emacs_mule, encode_invocation_designation)
6989 (encode_designation_at_bol, encode_coding_iso_2022)
6990 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6991 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6992 Declare EMACS_INT.
6993 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6994 (encode_invocation_designation): Last argument P_NCHARS is now
6995 EMACS_INT.
6996 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6997 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6998
6999 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7000 All users changed.
7001
7002 * ccl.c (Fccl_execute_on_string): Declare some variables
7003 EMACS_INT.
7004
8546720e 70052011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7006
7007 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7008
4e19a977
CS
70092011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7010
7011 * process.c (Fformat_network_address): Doc fix.
7012
87302331
R
70132011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7014
7015 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7016
cbb59342
CY
70172011-04-08 Chong Yidong <cyd@stupidchicken.com>
7018
7019 * keyboard.c (read_char): Call Lisp function help-form-show,
7020 instead of using internal_with_output_to_temp_buffer.
7021 (Qhelp_form_show): New var.
e0d38eeb 7022 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7023
7024 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7025
7026 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7027
e67a13ab
CY
70282011-04-06 Chong Yidong <cyd@stupidchicken.com>
7029
04f2d78b
CB
7030 * process.c (Flist_processes): Remove to Lisp.
7031 (list_processes_1): Delete.
e67a13ab 7032
973f782d
EZ
70332011-04-06 Eli Zaretskii <eliz@gnu.org>
7034
7c106b1e
EZ
7035 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7036
973f782d
EZ
7037 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7038
41cf7d1a 70392011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7040
ca23cc88
PE
7041 Fix more problems found by GCC 4.6.0's static checks.
7042
f390e2d5
PE
7043 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7044
42eea0d0
PE
7045 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7046
b69769da 7047 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7048
f9541e84
PE
7049 * xdisp.c (vmessage): Mark as a printf-like function.
7050
13841b55
PE
7051 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7052
c136c10f
PE
7053 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7054
5e2d4a30
PE
7055 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7056 printf-like functions.
7057 (tiff_load): Add casts to remove these marks before passing them
7058 to system-supplied API.
7059
583f48b9
PE
7060 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7061
b25d760e
PE
7062 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7063 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7064 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7065 directly, rather than having caller test rule sign. This avoids
7066 some unnecessary tests.
7067 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7068 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7069 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7070
bc7b6697 7071 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7072 (xfont_open): Avoid unnecessary tests.
bc7b6697 7073
27ccc379
PE
7074 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7075
dcd5c89a
PE
7076 * composite.h, composite.c (composition_gstring_put_cache):
7077 Use EMACS_INT, not int, for length.
7078
b13a45c6
PE
7079 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7080 breaking out part of COMPOSITION_DECODE_RULE.
7081 (COMPOSITION_DECODE_RULE): Use it.
7082 * composite.c (get_composition_id): Remove unused local vars,
7083 by using the new macro.
7084
1e792e4d
PE
7085 * textprop.c (set_text_properties_1): Change while to do-while,
7086 since the condition is always true at first.
7087
dc6c6455 7088 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7089 (interval_deletion_adjustment): Return unsigned value.
7090 All uses changed.
dc6c6455 7091
aba7731a
PE
7092 * process.c (list_processes_1, create_pty, read_process_output):
7093 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7094 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7095 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7096 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7097 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7098
fdfc4bf3
PE
7099 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7100
fca8fe46 7101 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7102 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7103
06a0259a 7104 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7105 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7106 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7107
e7b9e80f
PE
7108 * print.c (print_error_message): Avoid int overflow.
7109
56201685
PE
7110 * font.c (font_list_entities): Redo for clarity,
7111 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7112
78834453 7113 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7114 (font_score): Avoid potential overflow in diff calculation.
78834453 7115
0bc0b309 7116 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7117 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7118
e610eaca
PE
7119 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7120
b895abce
PE
7121 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7122 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7123 can always succeed if overflow has undefined behavior.
7124
1f1d9321 7125 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7126 (wordify): Omit three unnecessary tests.
1f1d9321 7127
c59478bc
PE
7128 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7129 All callers changed. This avoids the need for an unused var.
7130
79b73827
PE
7131 * casefiddle.c (casify_region): Remove var that is set but not used.
7132
a4db5dfe
PE
7133 * dired.c (file_name_completion): Remove var that is set but not used.
7134
43aae36e
PE
7135 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7136
2a47c44d 7137 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7138 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7139
a37c69bf
PE
7140 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7141 Check for integer overflow on size calculations.
7142
328ab8e7
PE
7143 * buffer.c (Fprevious_overlay_change): Remove var that is set
7144 but not used.
7145
e5a2a5cb
PE
7146 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7147 Remove vars that are set but not used.
8d84a6eb 7148 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7149 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7150
a60e5f68
PE
7151 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7152
f661cb61 7153 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7154 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7155
f0397f5a
PE
7156 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7157 that are set but not used.
7158
8664db06 7159 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7160 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7161
6abdaa4a
PE
7162 * xselect.c (x_get_local_selection, x_handle_property_notify):
7163 Remove vars that are set but not used.
7164
0ce7538d 7165 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7166 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7167
9ae848fc
PE
7168 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7169 Remove var that is set but not used.
0b918413
PE
7170 (scroll_bar_windows_size): Now size_t, not int.
7171 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7172 Check for overflow.
9ae848fc 7173
a5a62657
PE
7174 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7175 (map_tty_color) [!defined MSDOS]: Likewise.
7176
5c5cdd39
PE
7177 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7178
66ebf983
PE
7179 * coding.c: Remove vars that are set but not used.
7180 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7181 All callers changed.
7182 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7183 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7184 (decode_coding_charset): Remove vars that are set but not used.
7185
1be4d761
PE
7186 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7187 that is set but not used.
7188
47553fa8
PE
7189 * print.c (print_object): Remove var that is set but not used.
7190
1f7196bf 7191 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7192 The gnulib version avoids calling malloc in the usual case,
7193 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7194 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7195 * filelock.c (current_lock_owner): Likewise.
7196 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7197 * sysdep.c: Include allocator.h, careadlinkat.h.
7198 (emacs_no_realloc_allocator): New static constant.
7199 (emacs_readlink): New function.
fdb61804
PE
7200 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7201 ../lib/careadlinkat.h.
d1fdcab7 7202
f84c17c7
SM
72032011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7204
7205 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7206 first non-nil return value).
7207
ef3862ad
JD
72082011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7209
7210 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7211 if not defined (Bug#8403).
7212
376a7006
JB
72132011-04-02 Juanma Barranquero <lekktu@gmail.com>
7214
7215 * xdisp.c (display_count_lines): Remove parameter `start',
7216 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7217 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7218 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7219 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7220 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7221 and thereabouts. All callers changed.
7222 (get_per_char_metric): Remove parameter `f', unused since
7223 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7224
6ca3801d
JM
72252011-04-02 Jim Meyering <meyering@redhat.com>
7226
7227 do not dereference NULL upon failed strdup
7228 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7229 (ns_get_family): Likewise.
7230
d8e2b5ba
JB
72312011-04-02 Juanma Barranquero <lekktu@gmail.com>
7232
7233 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7234
8c74fcbd
JD
72352011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7236
7237 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7238 later (Bug#8403).
7239
7200d79c
SM
72402011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7241
03408648 7242 Add lexical binding.
7200d79c 7243
03408648
SM
7244 * window.c (Ftemp_output_buffer_show): New fun.
7245 (Fsave_window_excursion):
7246 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7247
7248 * lread.c (lisp_file_lexically_bound_p): New function.
7249 (Fload): Bind Qlexical_binding.
7250 (readevalloop): Remove `evalfun' arg.
7251 Bind Qinternal_interpreter_environment.
7252 (Feval_buffer): Bind Qlexical_binding.
7253 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7254 Mark as dynamic.
7255 (syms_of_lread): Declare `lexical-binding'.
7256
7257 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7258
7259 * keyboard.c (eval_dyn): New fun.
7260 (menu_item_eval_property): Use it.
ca105506
SM
7261
7262 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7263
03408648
SM
7264 * fns.c (concat, mapcar1): Accept byte-code-functions.
7265
7266 * eval.c (Fsetq): Handle lexical vars.
7267 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7268 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7269 (FletX, Flet): Obey lexical binding.
7270 (Fcommandp): Handle closures.
7271 (Feval): New `lexical' arg.
7272 (eval_sub): New function extracted from Feval. Use it almost
7273 everywhere where Feval was used. Look up vars in lexical env.
7274 Handle closures.
7275 (Ffunctionp): Move from subr.el.
7276 (Ffuncall): Handle closures.
7277 (apply_lambda): Remove `eval_flags'.
7278 (funcall_lambda): Handle closures and new byte-code-functions.
7279 (Fspecial_variable_p): New function.
7280 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7281 but without exporting it to Lisp.
23aba0ea 7282
23aba0ea 7283 * doc.c (Fdocumentation, store_function_docstring):
03408648 7284 * data.c (Finteractive_form): Handle closures.
23aba0ea 7285
03408648
SM
7286 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7287 interactive spec.
ba83908c 7288
04f2d78b
CB
7289 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7290 New byte-codes.
03408648
SM
7291 (exec_byte_code): New function extracted from Fbyte_code to handle new
7292 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7293
03408648 7294 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7295
03408648 7296 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7297
e2abce01
JB
72982011-03-31 Juanma Barranquero <lekktu@gmail.com>
7299
7300 * xdisp.c (redisplay_internal): Fix prototype.
7301
63696a73 73022011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7303
63696a73 7304 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7305 (try_scrolling): Use it when setting scroll_limit.
7306 Limit scrolling to 100 screen lines.
63696a73
EZ
7307 (redisplay_window): Even when falling back on "recentering",
7308 position point in the window according to scroll-conservatively,
7309 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7310
7311 (try_scrolling): When point is above the window, allow searching
7312 as far as scroll_max, or one screenful, to compute vertical
7313 distance from PT to the scroll margin position. This prevents
7314 try_scrolling from unnecessarily failing when
7315 scroll-conservatively is set to a value slightly larger than the
7316 window height. Clean up the case of PT below the margin at bottom
7317 of window: scroll_max can no longer be INT_MAX. When aggressive
7318 scrolling is in use, don't let point enter the opposite scroll
7319 margin as result of the scroll.
7320 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7321 threshold of 100 lines for never-recentering scrolling.
7322
e4cc2dfc
JB
73232011-03-31 Juanma Barranquero <lekktu@gmail.com>
7324
7325 * dispextern.h (move_it_by_lines):
7326 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7327 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7328 (message_log_check_duplicate): Remove parameters `prev_bol' and
7329 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7330 (redisplay_internal): Remove parameter `preserve_echo_area',
7331 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7332
7333 * indent.c (Fvertical_motion):
7334 * window.c (window_scroll_pixel_based, Frecenter):
7335 Don't pass `need_y_p' to `move_it_by_lines'.
7336
1c470562
SM
73372011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7338
44f230aa
SM
7339 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7340 steal a few bits to be more compact.
7341 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7342 Remove unneeded casts.
7343
1c470562
SM
7344 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7345
888adce9
ZK
73462011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7347
7348 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7349 binding" message (bug#7967).
7350
f838ed7b
PE
73512011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7352
77861b95
PE
7353 Fix more problems found by GCC 4.6.0's static checks.
7354
de6dbc14
PE
7355 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7356 Remove unused local var.
7357
f838ed7b
PE
7358 * editfns.c (Fmessage_box): Remove unused local var.
7359
792c7b2b
PE
7360 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7361 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7362 Omit unused local vars.
c499e557 7363 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7364 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7365 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7366 Omit unused local var.
7367
ba0165e1
PE
7368 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7369 Don't assume string length fits in int.
32ad8845 7370 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7371 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7372
3c59b4c9
PE
7373 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7374 instead of alloca (Bug#8344).
7375
a3eed478 7376 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7377 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7378
eb4d412d
PE
7379 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7380
1658b401
PE
7381 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7382 concerns.
7383
7384 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7385
7386 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7387
9a2c6e05
PE
7388 * keyboard.c (syms_of_keyboard): Use the same style as later
7389 in this function when indexing through an array. This also
7390 works around GCC bug 48267.
7391
03d0a109
PE
7392 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7393
44f730c8
PE
7394 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7395
fe75f926
PE
7396 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7397 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7398
ffa8c828
PE
7399 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7400 This avoids undefined behavior on integer overflow, and is a bit
7401 more convenient anyway since it is compared to a size_t variable.
7402
c5101a77
PE
7403 Variadic C functions now count arguments with size_t, not int.
7404 This avoids an unnecessary limitation on 64-bit machines, which
7405 caused (substring ...) to crash on large vectors (Bug#8344).
7406 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7407 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7408 All variadic functions and their callers changed accordingly.
c5101a77
PE
7409 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7410 * data.c (arith_driver, float_arith_driver): Likewise.
7411 * editfns.c (general_insert_function): Likewise.
7412 * eval.c (struct backtrace.nargs, interactive_p)
7413 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7414 (funcall_lambda, mark_backtrace): Likewise.
7415 * fns.c (concat): Likewise.
7416 * frame.c (x_set_frame_parameters): Likewise.
7417 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7418 0 if not found, not -1. All callers changed.
7419
dd3f25f7
PE
7420 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7421 (stack_copy_size): Now size_t, not int.
7422 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7423
461c2ab9
JB
74242011-03-28 Juanma Barranquero <lekktu@gmail.com>
7425
7426 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7427 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7428 All callers changed.
7429
7430 * lisp.h (multibyte_char_to_unibyte):
7431 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7432 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7433 * character.h (CHAR_TO_BYTE8):
7434 * cmds.c (internal_self_insert):
7435 * editfns.c (general_insert_function):
7436 * keymap.c (push_key_description):
7437 * search.c (Freplace_match):
7438 * xdisp.c (message_dolog, set_message_1): All callers changed.
7439
f6d62986
SM
74402011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7441
7442 * keyboard.c (safe_run_hook_funcall): New function.
7443 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7444 don't set the hook to nil, but remove the offending function instead.
7445 (Qcommand_hook_internal): Remove, unused.
7446 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7447 Vcommand_hook_internal.
7448
7449 * eval.c (enum run_hooks_condition): Remove.
7450 (funcall_nil, funcall_not): New functions.
7451 (run_hook_with_args): Call each function through a `funcall' argument.
7452 Remove `cond' argument, now redundant.
7453 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7454 (Frun_hook_with_args_until_failure): Adjust accordingly.
7455 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7456
1db5b1ad
JB
74572011-03-28 Juanma Barranquero <lekktu@gmail.com>
7458
7459 * dispextern.h (string_buffer_position): Remove declaration.
7460
7461 * print.c (strout): Remove parameter `multibyte', unused since
7462 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7463
7464 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7465 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7466 All callers changed.
7467
7468 * w32.c (_wsa_errlist): Use braces for struct initializers.
7469
7470 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7471 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7472 All callers changed.
7473 (string_buffer_position): Likewise. Also, make static (it's never
7474 used outside xdisp.c).
7475 (cursor_row_p): Remove parameter `w', unused since
7476 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7477 (decode_mode_spec): Remove parameter `precision', introduced during
7478 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7479 All callers changed.
7480
5ffb62aa
JD
74812011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7482
7483 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7484
461c2ab9 74852011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7486
7487 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7488 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7489 (ns_update_auto_hide_menu_bar): New functions.
7490 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7491 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7492 ns_constrain_all_frames.
7493 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7494 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7495
5c380ffb
JD
74962011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7497
7498 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7499
9af30bdf
GM
75002011-03-27 Glenn Morris <rgm@gnu.org>
7501
7502 * syssignal.h: Replace RETSIGTYPE with void.
7503 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7504 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7505 Replace SIGTYPE with void everywhere.
7506 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7507 * s/template.h (SIGTYPE): Remove commented out definition.
7508
e2abce01
JB
75092011-03-26 Eli Zaretskii <eliz@gnu.org>
7510
7511 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7512 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7513
f868cd8a
JB
75142011-03-26 Juanma Barranquero <lekktu@gmail.com>
7515
59eb0929
JB
7516 * w32.c (read_unc_volume): Use parameter `henum', instead of
7517 global variable `wget_enum_handle'.
7518
7519 * keymap.c (describe_vector): Remove parameters `indices' and
7520 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7521 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7522
f868cd8a
JB
7523 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7524
7525 * keyboard.c (timer_check): Remove parameter `do_it_now',
7526 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7527 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7528 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7529
7530 * keyboard.c (read_char):
7531 * w32menu.c (w32_menu_display_help):
7532 * xmenu.c (show_help_event, menu_help_callback):
7533 Adjust calls to `show_help_echo'.
7534
7535 * gtkutil.c (xg_maybe_add_timer):
7536 * keyboard.c (readable_events):
7537 * process.c (wait_reading_process_output):
7538 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7539
7540 * insdel.c (adjust_markers_gap_motion):
7541 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7542 (gap_left, gap_right): Don't call it.
7543
2ecf6fdb
CY
75442011-03-25 Chong Yidong <cyd@stupidchicken.com>
7545
7546 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7547 incurred during fontification.
7548
6b1f9ba4
JB
75492011-03-25 Juanma Barranquero <lekktu@gmail.com>
7550
7551 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7552 (DEFVAR_PER_BUFFER): Don't pass it.
7553
7554 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7555 (scrolling_window): Don't pass it.
7556
0f4a96b5
JB
75572011-03-25 Juanma Barranquero <lekktu@gmail.com>
7558
7559 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7560
7561 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7562 and `suffix'.
7563 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7564 of variables specific to SELinux and computation of `encoded_absname'.
7565
7566 * image.c (XPutPixel): Remove unused variable `height'.
7567
7568 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7569
7570 * unexw32.c (get_section_info): Remove unused variable `section'.
7571
7572 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7573 (system_process_attributes): Remove unused variable `sess'.
7574 (sys_read): Remove unused variable `err'.
7575
7576 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7577 (w32_wnd_proc): Remove unused variable `isdead'.
7578 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7579 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7580 (x_create_tip_frame): Remove unused variable `tem'.
7581
7582 * w32inevt.c (w32_console_read_socket):
7583 Remove unused variable `no_events'.
7584
7585 * w32term.c (x_draw_composite_glyph_string_foreground):
7586 Remove unused variable `width'.
7587
1149507c
JB
75882011-03-24 Juanma Barranquero <lekktu@gmail.com>
7589
7590 * w32term.c (x_set_glyph_string_clipping):
7591 Don't pass uninitialized region to CombineRgn.
7592
9c88f339
JB
75932011-03-23 Juanma Barranquero <lekktu@gmail.com>
7594
7595 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7596 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7597 (Fx_close_connection): Remove unused variable `i'.
7598
7599 * w32font.c (w32font_draw): Return number of glyphs.
7600 (w32font_open_internal): Remove unused variable `i'.
7601 (w32font_driver): Add missing initializer.
7602
7603 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7604 (fill_in_menu): Remove unused variable `items_added'.
7605
7606 * w32term.c (last_mouse_press_frame): Remove static global variable.
7607 (w32_clip_to_row): Remove unused variable `f'.
7608 (x_delete_terminal): Remove unused variable `i'.
7609
7610 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7611 (NOTHING): Remove unused static global variable.
7612 (uniscribe_check_otf): Remove unused variable `table'.
7613 (uniscribe_font_driver): Add missing initializers.
7614
dee091a3
JD
76152011-03-23 Julien Danjou <julien@danjou.info>
7616
7617 * term.c (Fsuspend_tty, Fresume_tty):
7618 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7619 * window.c (temp_output_buffer_show):
7620 * insdel.c (signal_before_change):
7621 * frame.c (Fhandle_switch_frame):
7622 * fileio.c (Fdo_auto_save):
7623 * emacs.c (Fkill_emacs):
7624 * editfns.c (save_excursion_restore):
7625 * cmds.c (internal_self_insert):
7626 * callint.c (Fcall_interactively):
7627 * buffer.c (Fkill_all_local_variables):
7628 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7629 Use Frun_hooks.
0f4a96b5 7630 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7631 unconditionnaly since it does the check itself.
7632
2c520ab5 76332011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7634
c9c49752
PE
7635 Fix more problems found by GCC 4.5.2's static checks.
7636
8abc3f12
PE
7637 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7638 the first time through the loop, since we know p0 < p1 then.
7639 This also avoids a gcc -Wstrict-overflow warning.
7640
a2d26660
PE
7641 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7642 leading to a memory leak, possible in functions like
7643 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7644 of objects (Bug#8318).
a2d26660 7645
916c72e9
PE
7646 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7647 that could (at least in theory) be that large.
7648
19ab8a18
PE
7649 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7650 This is less likely to overflow, and avoids undefined behavior if
7651 overflow does occur. All callers changed. Use strtoul to scan
7652 for the unsigned long integer.
b7cbbd6f
PE
7653 (pint2hrstr): Simplify and tune code slightly.
7654 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7655
f0641eff
PE
7656 * scroll.c (do_scrolling): Work around GCC bug 48228.
7657 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7658
7f650bb9
PE
7659 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7660 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7661 (validate_x_resource_name): Simplify count usage.
7662 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7663
37dd57d1
PE
7664 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7665 fail (Bug#8306).
81e56e61 7666
699979fc 7667 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7668
401bf9b4
PE
7669 * process.c (Fmake_network_process): Use socklen_t, not int,
7670 where POSIX says socklen_t is required in portable programs.
7671 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7672 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7673 (Fmake_network_process, server_accept_connection):
7674 (wait_reading_process_output, read_process_output):
7675 Likewise.
7676
b93aacde
PE
7677 * process.c: Rename or move locals to avoid shadowing.
7678 (list_processes_1, Fmake_network_process):
7679 (read_process_output_error_handler, exec_sentinel_error_handler):
7680 Rename or move locals.
4dc343ee 7681 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7682 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7683 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7684 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7685 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7686
af8a867c 7687 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7688 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7689 Include tparam.h instead, since it declares them.
af8a867c
PE
7690 * cm.h (PC): Remove extern decl; tparam.h now does this.
7691 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7692 * terminfo.c: Include tparam.h, to check interfaces.
7693 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7694 (tparam): Adjust signature to match interface in tparam.h;
7695 this removes some undefined behavior. Check that outstring and len
7696 are zero, which they always are with Emacs.
7697 * tparam.h (PC, BC, UP): New extern decls.
7698
0248044d 7699 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7700 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7701
8ff096c1 7702 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7703 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7704 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7705 (ftfont_list): Remove unused local.
49eaafba
PE
7706 (get_adstyle_property, ftfont_pattern_entity):
7707 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7708 Rename locals to avoid shadowing.
8ff096c1 7709
e2be39f6
PE
7710 * xfont.c (xfont_list_family): Mark var as initialized.
7711
c9735e30
PE
7712 * xml.c (make_dom): Now static.
7713
8f5201ae
PE
7714 * composite.c (composition_compute_stop_pos): Rename local to
7715 avoid shadowing.
b246f932
PE
7716 (composition_reseat_it): Remove unused locals.
7717 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7718 (composition_update_it): Mark var as initialized.
11b61122
PE
7719 (find_automatic_composition): Mark vars as initialized,
7720 with a FIXME (Bug#8290).
8f5201ae 7721
760fbc2c
PE
7722 character.h: Rename locals to avoid shadowing.
7723 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7724 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7725 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7726 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7727 to avoid shadowing.
7728
ff08eb85
PE
7729 * textprop.c (property_change_between_p): Remove; unused.
7730
fc7bf025
PE
7731 * intervals.c (interval_start_pos): Now static.
7732
235d7abc
PE
7733 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7734
44f230aa
SM
7735 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7736 Rename locals to avoid shadowing.
3e7d6594 7737
50060332
PE
7738 * sound.c (wav_play, au_play, Fplay_sound_internal):
7739 Fix pointer signedness.
d01f234b 7740 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7741 (wav_play): Initialize a variable to 0, to prevent undefined
7742 behavior (Bug#8278).
50060332 7743
c4fc4e30
PE
7744 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7745
918436ed
PE
7746 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7747
c939f91b
PE
7748 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7749 clobbering (Bug#8298).
b9c7f648
PE
7750 * sysdep.c (sys_subshell): Likewise.
7751 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7752
6bd8c144
PE
7753 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7754 This should get cleaned up, so that child_setup has the
7755 same signature on all platforms.
7756
7710357c 7757 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7758 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7759
c59da222
CY
77602011-03-22 Chong Yidong <cyd@stupidchicken.com>
7761
7762 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7763 not to be necessary, and produces flickering.
7764
66b87493
GM
77652011-03-20 Glenn Morris <rgm@gnu.org>
7766
7767 * config.in: Remove file.
7768
45b6f6d5
JB
77692011-03-20 Juanma Barranquero <lekktu@gmail.com>
7770
7771 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7772 are now in src/globals.h.
7773 (syms_of_minibuf): Remove spurious & from previous change.
7774
3ec03f7e
LL
77752011-03-20 Leo <sdl.web@gmail.com>
7776
7777 * minibuf.c (completing-read-function): New variable.
7778 (completing-read-default): Rename from completing-read.
7779 (completing-read): Call completing-read-function.
7780
b14e3e21
CY
77812011-03-19 Juanma Barranquero <lekktu@gmail.com>
7782
7783 * xfaces.c (Fx_load_color_file):
7784 Read color file from absolute filename (bug#8250).
7785
f2b726e6
JB
77862011-03-19 Juanma Barranquero <lekktu@gmail.com>
7787
7788 * makefile.w32-in: Update dependencies.
7789
09f6ff02
EZ
77902011-03-17 Eli Zaretskii <eliz@gnu.org>
7791
7792 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7793
29a6015a
PE
77942011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7795
a3a6c54e
PE
7796 Fix more problems found by GCC 4.5.2's static checks.
7797
b766f867
PE
7798 * process.c (make_serial_process_unwind, send_process_trap):
7799 (sigchld_handler): Now static.
7800
be02381c
PE
7801 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7802 That way, the code declares only the vars that it needs.
7803 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7804 * s/cygwin.h (PTY_ITERATION): Likewise.
7805 * s/darwin.h (PTY_ITERATION): Likewise.
7806 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7807
57048744
PE
7808 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7809 * process.c (allocate_pty): Don't declare stb unless it's needed.
7810
7914961c 7811 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7812 (CONSTANTLIM): Remove; unused.
7813 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7814 Define only if needed.
7914961c 7815
b3967b18
PE
7816 * unexelf.c (unexec): Name an expression,
7817 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7818 Use a different way to cause a compilation error if anyone uses
7819 n rather than nn, a way that does not involve shadowing.
73366a00 7820 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7821
29a6015a
PE
7822 * deps.mk (unexalpha.o): Remove; unused.
7823
43cfc33e 7824 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7825 * unexec.h: New file.
ce701a33
PE
7826 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7827 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7828 Depend on unexec.h.
7829 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7830 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7831 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7832 Change as necessary to match prototype in unexec.h.
ce701a33 7833
01f44d5a
PE
7834 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7835 shadowing.
4f63c6bb 7836 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7837
a6670b0b
PE
7838 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7839 Rename locals to avoid shadowing.
7840
cef2010d 7841 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7842 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7843
d4d7173a
PE
7844 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7845
f08b802a
PE
7846 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7847 warning when compiling print.c.
7848
3ddb0639
PE
7849 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7850 instead of using an uninitialized var.
5ad03b97 7851 (font_sort_entities): Mark var as initialized.
3ddb0639 7852
170a2692
PE
7853 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7854
e663c700
PE
7855 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7856 pointers to constants.
89bc529a 7857 (font_parse_fcname): Remove unused vars.
7b81e2d0 7858 (font_delete_unmatched): Now static.
ea838e10 7859 (font_get_spec): Remove; unused.
13a547c6
PE
7860 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7861 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7862 Rename or move locals to avoid shadowing.
e663c700 7863
2a80c887 7864 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7865 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7866
1384fa33 7867 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7868 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7869
8b2c52e9
PE
7870 * alloc.c (mark_backtrace): Move decl from here ...
7871 * lisp.h: ... to here, so that it can be checked.
7872
475545b5 7873 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7874 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7875 (lisp_indirect_variable): Name an expression,
7876 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7877 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7878
b1349114 7879 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7880 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7881 Use const pointer when appropriate.
b1349114 7882
a2928364
PE
7883 * lisp.h (get_system_name, get_operating_system_release):
7884 Move decls here, to check interfaces.
7885 * process.c (get_operating_system_release): Move decl to lisp.h.
7886 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7887 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7888 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7889 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7890 (Fformat_time_string, Fencode_time, Finsert_char):
7891 (Ftranslate_region_internal, Fformat):
7892 Rename or remove local vars to avoid shadowing.
9710023e 7893 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7894
a415e694
PE
7895 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7896 avoid shadowing.
7897
8ef4622d
PE
7898 * lisp.h (eassert): Check that the argument compiles, even if
7899 ENABLE_CHECKING is not defined.
7900
946f9a5b
PE
7901 * data.c (Findirect_variable): Name an expression, to avoid
7902 gcc -Wbad-function-cast warning.
112396d6 7903 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7904 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7905 (Fmake_variable_buffer_local, Fmake_local_variable):
7906 Mark variables as initialized.
52746918 7907 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7908
e5aab7e7 7909 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7910 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7911 Rename locals to avoid shadowing.
dff45157
PE
7912 (mark_stack): Move local variables into the #ifdef region where
7913 they're used.
7bc26fdb
PE
7914 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7915 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7916 needed otherwise.
7917 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7918 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7919 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7920
e5aab7e7
PE
7921 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7922 avoids undefined behavior in theory.
7923
4da60324
PE
7924 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7925
88043301
PE
7926 Use functions, not macros, for up- and down-casing (Bug#8254).
7927 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7928 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7929 to use the following functions instead of these macros.
7930 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7931 EMACS_INT, since callers assume the returned value fits in int.
7932 (upcase1): Likewise, for UPCASE_TABLE.
7933 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7934 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7935 the race-condition problem in the old DOWNCASE.
88043301 7936
19ed5445
PE
7937 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7938 Rename locals to avoid shadowing.
7939 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7940 (regex_compile, re_search_2, re_match_2_internal):
7941 Remove unused local vars.
952db0d7
PE
7942 (FREE_VAR): Rewrite so as not to use empty "else",
7943 which gcc can warn about.
da053e48 7944 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7945 (RETALLOC_IF): Define only if needed.
7946 (WORDCHAR_P): Likewise. This one is never needed, but is used
7947 only in a comment talking about a compiler bug, so put inside
7948 the #if 0 of that comment.
7949 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7950 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7951 Remove; unused.
19ed5445 7952
1f3561e4 7953 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7954 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7955 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7956
ded6f8f7
PE
7957 * search.c (simple_search): Remove unused var.
7958
dbd37a95
PE
7959 * dired.c (compile_pattern): Move decl from here ...
7960 * lisp.h: ... to here, so that it can be checked.
7961 (struct re_registers): New forward decl.
7962
7e47afad
PE
7963 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7964
85f24f61
PE
7965 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7966 All uses changed.
7967 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7968 Rename locals to avoid shadowing.
5671df8f 7969 (Fvertical_motion): Mark locals as initialized.
85f24f61 7970
181aa2be 7971 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7972 (casify_region): Mark local as initialized.
181aa2be 7973
930d429c
PE
7974 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7975
7082eac6
PE
7976 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7977 New macros, so that the caller can use some names other than
7978 gcpro1, gcpro2, etc.
7979 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7980 of the new macros.
7981 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7982 argument, for consistency with GCPRO2_VAR, etc: it is now the
7983 prefix of the variable, not the variable itself. All uses
7984 changed.
38b2c076
PE
7985 * dired.c (directory_files_internal, file_name_completion):
7986 Rename locals to avoid shadowing.
7987
15206ed9
PE
7988 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7989 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7990 dired.c's scmp function, had undefined behavior.
7991 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7992 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7993 * buffer.h: ... to here, because these macros use current_buffer,
7994 and the new implementation with inline functions needs to have
7995 current_buffer in scope now, rather than later when the macros
7996 are used.
7997 (downcase, upcase1): New static inline functions.
7998 (DOWNCASE, UPCASE1): Reimplement using these functions.
7999 This avoids undefined behavior in expressions like
8000 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8001 from race conditions in accessing the global variables
8002 case_temp1 and case_temp2.
8003 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8004 * lisp.h (case_temp1, case_temp2): Remove their decls.
8005 * character.h (ASCII_CHAR_P): Move from here ...
8006 * lisp.h: ... to here, so that the inline functions mentioned
8007 above can use them.
8008
4a6bea26
PE
8009 * dired.c (directory_files_internal_unwind): Now static.
8010
f14b7e14
PE
8011 * fileio.c (file_name_as_directory, directory_file_name):
8012 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8013 Now static.
2893f146
PE
8014 (file_name_as_directory): Use const pointers when appropriate.
8015 (Fexpand_file_name): Likewise. In particular, newdir might
8016 point at constant storage, so make it a const pointer.
fd4ead52 8017 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8018 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8019 signedness issues.
f839df0c
PE
8020 (Fset_file_times, Finsert_file_contents, auto_save_error):
8021 Rename locals to avoid shadowing.
f14b7e14 8022
5716756e 8023 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8024 (Ftry_completion, Fall_completions): Rename or remove locals
8025 to avoid shadowing.
5716756e 8026
b4c3046a
PE
8027 * marker.c (bytepos_to_charpos): Remove; unused.
8028
b45db522
PE
8029 * lisp.h (verify_bytepos, count_markers): New decls,
8030 so that gcc does not warn that these functions aren't declared.
8031
85876d07
PE
8032 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8033 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8034 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8035 (copy_text): Remove unused local var.
85876d07 8036
03d78a21 8037 * filelock.c (within_one_second): Now static.
b3dd38ab 8038 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8039
5df8f01b
PE
8040 * buffer.c (fix_overlays_before): Mark locals as initialized.
8041 (fix_start_end_in_overlays): Likewise. This function should be
8042 simplified by using pointers-to-pointers, but that's a different
8043 matter.
b1d876f1 8044 (switch_to_buffer_1): Now static.
8f54f30a
PE
8045 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8046 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8047
a70072c9 8048 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8049 Fix pointer signedness issue.
edced198
PE
8050 (sys_subshell): Mark local as volatile if checking for lint,
8051 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8052 (MAXPATHLEN): Define only if needed.
a70072c9 8053
a0977c44
PE
8054 * process.c (serial_open, serial_configure): Move decls from here ...
8055 * systty.h: ... to here, so that they can be checked.
8056
a884fdcc
PE
8057 * fns.c (get_random, seed_random): Move extern decls from here ...
8058 * lisp.h: ... to here, so that they can be checked.
8059
604efe86 8060 * sysdep.c (reset_io): Now static.
b8950c94 8061 (wait_for_termination_signal): Remove; unused.
604efe86 8062
38fc62d9
PE
8063 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8064 (copy_keymap_item, append_key, push_text_char_description):
8065 Now static.
1004a21a 8066 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8067 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8068 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8069 (describe_map_tree):
8070 Rename locals to avoid shadowing.
38fc62d9 8071
2f2650da
PE
8072 * keyboard.c: Declare functions static if they are not used elsewhere.
8073 (echo_char, echo_dash, cmd_error, top_level_2):
8074 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8075 (read_char, kbd_buffer_get_event, make_lispy_position):
8076 (make_lispy_event, make_lispy_movement, apply_modifiers):
8077 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8078 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8079 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8080 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8081 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8082
a053e86c 8083 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8084 (mark_kboards): Move decl here ...
8085 * alloc.c (mark_kboards): ... from here.
a053e86c 8086
4752793e
PE
8087 * lisp.h (force_auto_save_soon): New decl.
8088
74f10ca7 8089 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8090 (DEFINE_DUMMY_FUNCTION): New macro.
8091 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8092 Use it.
c03cd23f
PE
8093 (main): Add casts to avoid warnings
8094 if GCC considers string literals to be constants.
74f10ca7 8095
022e70d4
PE
8096 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8097
59d6fe83
PE
8098 * dbusbind.c: Pointer signedness fixes.
8099 (xd_signature, xd_append_arg, xd_initialize):
8100 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8101 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8102 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8103 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8104
78320123
PE
8105 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8106 if GCC considers string literals to be constants.
49cebcca 8107 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8108
35ac2a97
SM
81092011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8110
fb103ca9
SM
8111 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8112 (print_preprocess, print_object): New macro to fix last change.
8113
35ac2a97
SM
8114 * print.c (print_preprocess): Don't forget font objects.
8115
62973b41
JB
81162011-03-16 Juanma Barranquero <lekktu@gmail.com>
8117
8118 * emacs.c (USAGE3): Doc fixes.
8119
0e48bb22
AS
81202011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8121
8122 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8123 structure.
8124
7684e57b
JB
81252011-03-14 Juanma Barranquero <lekktu@gmail.com>
8126
8127 * lisp.h (VWindow_system, Qfile_name_history):
8128 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8129 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8130 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8131
8132 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8133 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8134
8135 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8136 * w32console.c (detect_input_pending, read_input_pending)
8137 (encode_terminal_code):
8138 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8139 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8140 (w32_system_caret_y, Qfile_name_history):
8141 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8142 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8143 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8144 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8145 * w32proc.c (Qlocal, report_file_error):
8146 * w32term.c (Vwindow_system, updating_frame):
8147 * w32uniscribe.c (initialized, uniscribe_font_driver):
8148 Remove unneeded extern declarations.
8149
2aa46d6c
CY
81502011-03-14 Chong Yidong <cyd@stupidchicken.com>
8151
c96bbc66 8152 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8153
cffc6f3b
CY
81542011-03-13 Chong Yidong <cyd@stupidchicken.com>
8155
8156 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8157 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8158 These macros can no longer be used for assignment.
8159
44f230aa
SM
8160 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8161 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8162 (record_buffer_markers, fetch_buffer_markers): New functions for
8163 recording and fetching special buffer markers.
8164 (set_buffer_internal_1, set_buffer_temp): Use them.
8165
8166 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8167
8168 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8169
8170 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8171 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8172
8173 * xdisp.c (hscroll_window_tree):
8174 (reconsider_clip_changes): Use PT instead of BUF_PT.
8175
d251f04b
EZ
81762011-03-13 Eli Zaretskii <eliz@gnu.org>
8177
8178 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8179 $(EMACS_ROOT)/lib/intprops.h.
8180
f0c77cd1
PE
81812011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8182
3eca4629
PE
8183 Fix more problems found by GCC 4.5.2's static checks.
8184
7c86ee98
PE
8185 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8186 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8187 (xg_free_frame_widgets): Make it clear that a local variable is
8188 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8189 (gdk_window_get_screen): Make it clear that this macro is needed
8190 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8191 (int_gtk_range_get_value): New function, which avoids a diagnostic
8192 from gcc -Wbad-function-cast.
8193 (xg_set_toolkit_scroll_bar_thumb): Use it.
8194 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8195 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8196 (get_utf8_string, xg_get_file_with_chooser):
8197 Rename locals to avoid shadowing.
8198 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8199
41729b81
PE
8200 * xgselect.c (xg_select): Remove unused var.
8201
f0c77cd1
PE
8202 * image.c (four_corners_best): Mark locals as initialized.
8203 (gif_load): Initialize transparent_p to zero (Bug#8238).
8204 Mark another local as initialized.
ec6cf4c6 8205 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8206
ce0ad53d 8207 * image.c (clear_image_cache): Now static.
d5d5a617 8208 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8209 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8210 (x_edge_detection): Remove unnecessary cast that
8211 gcc -Wbad-function-cast diagnoses.
2037898d 8212 (gif_load): Fix pointer signedness.
6ae141d6
PE
8213 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8214 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8215
33383987 82162011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8217
d32df629
PE
8218 Improve quality of tests for time stamp overflow.
8219 For example, without this patch (encode-time 0 0 0 1 1
8220 1152921504606846976) returns the obviously-bogus value (-948597
8221 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8222 reports time overflow. See
8223 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8224 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8225 * editfns.c: Include limits.h and intprops.h.
8226 (TIME_T_MIN, TIME_T_MAX): New macros.
8227 (time_overflow): Move earlier, to before first use.
8228 (hi_time, lo_time): New functions, for an accurate test for
8229 out-of-range times.
8230 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8231 (Fget_internal_run_time): Don't assume time_t fits in int.
8232 (make_time): Use list2 instead of Fcons twice.
8233 (Fdecode_time): More accurate test for out-of-range times.
8234 (check_tm_member): New function.
8235 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8236 (lisp_time_argument): Don't rely on undefined left-shift and
8237 right-shift behavior when checking for time stamp overflow.
8be6f318 8238
fe31d94c
PE
8239 * editfns.c (time_overflow): New function, refactoring common code.
8240 (Fformat_time_string, Fdecode_time, Fencode_time):
8241 (Fcurrent_time_string): Use it.
8242
8be6f318
PE
8243 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8244 * dired.c (make_time): Move to ...
8245 * editfns.c (make_time): ... here.
8246 * systime.h: Note the move.
8247
09d9db2c 82482011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8249
126bc0dc
YM
8250 * fringe.c (update_window_fringes): Remove unused variables.
8251
c47cbdfd
YM
8252 * unexmacosx.c (copy_data_segment): Also copy __got section.
8253 (Bug#8223)
8254
7ac80be9
EZ
82552011-03-12 Eli Zaretskii <eliz@gnu.org>
8256
c96bbc66 8257 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8258 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8259 Constify `char *' arguments and their references according to
8260 prototypes in tparam.h.
8261
ecb0f94d 8262 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8263
7ac80be9
EZ
8264 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8265 Adapt all references accordingly.
8266
8267 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8268
ef1fd07e
TT
82692011-03-11 Tom Tromey <tromey@redhat.com>
8270
8271 * buffer.c (syms_of_buffer): Remove obsolete comment.
8272
7ef4b50c
EZ
82732011-03-11 Eli Zaretskii <eliz@gnu.org>
8274
8275 * termhooks.h (encode_terminal_code): Declare prototype.
8276
8277 * msdos.c (encode_terminal_code): Don't declare prototype.
8278
8279 * term.c (encode_terminal_code): Now external again, used by
8280 w32console.c and msdos.c.
8281
44f230aa
SM
8282 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8283 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8284
4b1ec863 82852011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8286
1714f52b 8287 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8288
4b1ec863
PE
8289 * fringe.c (update_window_fringes): Mark locals as initialized
8290 (Bug#8227).
8291 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8292
524c7aa6
PE
8293 * alloc.c (mark_fringe_data): Move decl from here ...
8294 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8295 to check its interface.
8296 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8297
a5c0af81 8298 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8299 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8300 (fontset_font): Mark local as initialized.
a9a06e0b 8301 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8302
b4716021
PE
8303 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8304
811e9bac 8305 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8306 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8307 (x_own_selection, Fx_disown_selection_internal): Rename locals
8308 to avoid shadowing.
8309 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8310
7e3ab302
PE
8311 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8312 so that the caller can use some name other than gcpro1.
8313 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8314 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8315 (Fx_backspace_delete_keys_p):
8316 Use them to avoid shadowing, and rename vars to avoid shadowing.
8317 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8318 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8319 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8320 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8321 Remove unused locals.
7e3ab302
PE
8322 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8323 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8324 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8325 macros.
f78faa98 8326
e2b13473
PE
8327 * xterm.h (x_mouse_leave): New decl.
8328
77f23912
PE
8329 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8330 Remove unused functions.
cdf4ba58
PE
8331 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8332 (x_calc_absolute_position): Now static.
7411c686 8333 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8334 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8335 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8336 unless they are used.
38d0b34a
PE
8337 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8338 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8339 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8340 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8341 (x_error_catcher, x_connection_closed, x_error_handler):
8342 (x_error_quitter, xembed_send_message, x_iconify_frame):
8343 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8344 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8345 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8346
44f230aa
SM
8347 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8348 Rename or move locals to avoid shadowing.
6b463e58 8349 (tty_defined_color, merge_face_heights): Now static.
5967d051 8350 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8351 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8352 does not deduce is never used uninitialized.
73719eba
PE
8353 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8354 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8355
426994c3 8356 * terminal.c (store_terminal_param): Now static.
5489860b 8357
032f1620 8358 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8359 (set_frame_menubar): Remove unused local.
d4323972 8360 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8361 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8362 since they might point to immutable storage.
281585b0
PE
8363 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8364 since it's unused otherwise.
032f1620 8365
367c19e5 8366 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8367 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8368 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8369 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8370 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8371 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8372 does not deduce are never used uninitialized.
70739cbe 8373
07b48fa9
PE
8374 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8375
8868a238 8376 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8377 * window.c (window_loop, size_window):
8378 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8379
7e5cf297 8380 * window.c (display_buffer): Now static.
d6550a9f
PE
8381 (size_window): Mark variables that gcc -Wuninitialized
8382 does not deduce are never used uninitialized.
a586633d
PE
8383 * window.h (check_all_windows): New decl, to forestall
8384 gcc -Wmissing-prototypes diagnostic.
5b555da1 8385 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8386
f6095868
PE
8387 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8388 shadowing.
8389 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8390 Include <limits.h>.
8391 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8392 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8393 (load_charset_map): Mark variables that gcc -Wuninitialized
8394 does not deduce are never used uninitialized.
53df7c11 8395 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8396
f38b440c
PE
8397 * coding.c (coding_set_source, coding_set_destination):
8398 Use "else { /* comment */ }" rather than "else /* comment */;"
8399 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8400 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8401 a block, when the outer 'i' will do.
8402 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8403 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8404 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8405 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8406 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8407 Rename locals to avoid shadowing.
8408 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8409 * coding.c (emacs_mule_char, encode_invocation_designation):
8410 Now static, since they're not used elsewhere.
413bb2db 8411 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8412 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8413 (decode_coding_emacs_mule): Mark variables that gcc
8414 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8415 (detect_coding_iso_2022): Initialize a local variable that might
8416 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8417 this initialization is needed. (Bug#8211)
5f58e762
PE
8418 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8419 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8420 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8421 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8422 Remove unused macros.
f38b440c 8423
232b38b9 8424 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8425 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8426 * character.c (string_count_byte8): Likewise.
232b38b9 8427
fb90da1b
PE
8428 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8429 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8430
fb93dbc2
PE
8431 * chartab.c (copy_sub_char_table): Now static, since it's not used
8432 elsewhere.
5c156ace
PE
8433 (sub_char_table_ref_and_range, char_table_ref_and_range):
8434 Rename locals to avoid shadowing.
bbcd0949 8435 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8436
7d3b3862 8437 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8438 (BIDI_BOB): Remove unused macro.
7d3b3862 8439
6be7d3da
PE
8440 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8441 deduce are never used uninitialized.
c2ed9c8b 8442 * term.c (encode_terminal_code): Likewise.
6be7d3da 8443
75f8807f 8444 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8445
50938595
PE
8446 * tparam.h: New file.
8447 * term.c, tparam.h: Include it.
8448 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8449 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8450 Move these decls to tparam.h, and make them agree with what
8451 is actually in tparam.c. The previous trick of using incompatible
8452 decls in different modules does not conform to the C standard.
8453 All callers of tparam changed to use tparam's actual API.
8454 * tparam.c (tparam1, tparam, tgoto):
8455 Use const pointers where appropriate.
8456
fbceeba2
PE
8457 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8458 * cm.h (struct cm): Likewise.
8459 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8460 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8461 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8462 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8463 (turn_on_face, init_tty): Likewise.
8464 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8465
7f3f1250
PE
8466 * term.c (term_mouse_position): Rename local to avoid shadowing.
8467
e6ca6543
PE
8468 * alloc.c (mark_ttys): Move decl from here ...
8469 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8470
c40f8d15
AS
84712011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8472
8473 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8474
cfe0661d
JB
84752011-03-09 Juanma Barranquero <lekktu@gmail.com>
8476
8477 * search.c (compile_pattern_1): Remove argument regp, unused since
8478 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8479 (compile_pattern): Don't pass it.
8480
0afb4571
J
84812011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8482
8483 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8484 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8485 for ! HAVE_GTK3.
8486 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8487
8488 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8489
8490 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8491 gdk_window_get_screen, gdk_window_get_geometry,
8492 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8493 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8494 (xg_get_pixbuf_from_pixmap): New function.
8495 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8496 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8497 Call xg_get_pixbuf_from_pixmap instead of
8498 gdk_pixbuf_get_from_drawable.
8499 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8500 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8501 (xg_check_special_colors): Use GtkStyleContext and its functions
8502 for HAVE_GTK3.
8503 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8504 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8505 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8506 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8507 Call gtk_widget_get_preferred_size.
0afb4571
J
8508 (xg_frame_resized): gdk_window_get_geometry only takes 5
8509 parameters.
44f230aa
SM
8510 (xg_win_to_widget, xg_event_is_for_menubar):
8511 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8512 (xg_set_widget_bg): New function.
8513 (delete_cb): New function.
895009e1 8514 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8515 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8516 (xg_set_background_color): Call xg_set_widget_bg.
8517 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8518 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8519 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8520 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8521 if ! HAVE_GTK3.
8522 (update_frame_tool_bar): Call gtk_widget_hide.
8523 (xg_initialize): Use GDK_KEY_g.
8524
8525 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8526 if ! HAVE_GTK3
8527 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8528
8529 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8530 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8531 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8532
1c2cc4ef
JB
85332011-03-08 Juanma Barranquero <lekktu@gmail.com>
8534
8535 * w32xfns.c (select_palette): Check success of RealizePalette against
8536 GDI_ERROR, not zero.
8537
33383987 8538See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8539
8540;; Local Variables:
8541;; coding: utf-8
aac0c6e3
MR
8542;; End:
8543
33383987 8544 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8545
8546 This file is part of GNU Emacs.
8547
8548 GNU Emacs is free software: you can redistribute it and/or modify
8549 it under the terms of the GNU General Public License as published by
8550 the Free Software Foundation, either version 3 of the License, or
8551 (at your option) any later version.
8552
8553 GNU Emacs is distributed in the hope that it will be useful,
8554 but WITHOUT ANY WARRANTY; without even the implied warranty of
8555 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8556 GNU General Public License for more details.
8557
8558 You should have received a copy of the GNU General Public License
8559 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.