Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
57679c86
AS
12011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2
3 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4
888c9e86
EZ
52011-05-07 Eli Zaretskii <eliz@gnu.org>
6
b0512a1d
EZ
7 * w32console.c (Fset_screen_color): Doc fix.
8 (Fget_screen_color): New function.
9 (syms_of_ntterm): Defsubr it.
10
888c9e86
EZ
11 * callproc.c (call_process_cleanup): Don't close and unlink the
12 temporary file if Fcall_process didn't create it in the first
13 place.
14 (Fcall_process): Don't create tempfile if stdout of the child
15 process will be redirected to a file specified with `:file'.
16 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
17 cue to call_process_cleanup not to close that handle.
18
4d3fcc8e
BK
192011-05-07 Ben Key <bkey76@gmail.com>
20
21 * makefile.w32-in: The bootstrap-temacs rule now makes use of
22 one of two shell specific rules, either bootstrap-temacs-CMD or
23 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
24 to the previous implementation of the bootstrap-temacs rule.
25 The bootstrap-temacs-CMD rule is similar to the previous
26 implementation of the bootstrap-temacs rule except that it
27 makes use of the ESC_CFLAGS variable instead of the CFLAGS
28 variable.
29
30 These changes, along with some changes to nt/configure.bat,
31 nt/gmake.defs, and nt/nmake.defs, are required to extend my
32 earlier fix to add support for --cflags and --ldflags options
33 that include quotes so that it works whether make uses cmd or
34 sh as the shell.
35
b4289b64
MA
362011-05-06 Michael Albinus <michael.albinus@gmx.de>
37
38 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
39 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
40 is a constant.
41 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
42 a string. Handle both cases.
43 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
44 (Fdbus_register_method): Use Qinvalid_function.
45
af4c0e28
JB
462011-05-06 Juanma Barranquero <lekktu@gmail.com>
47
48 * makefile.w32-in: Update dependencies.
49 (LISP_H): Add inttypes.h and stdin.h.
50 (PROCESS_H): Add unistd.h.
51
c51453d9
EZ
522011-05-06 Eli Zaretskii <eliz@gnu.org>
53
54 * lread.c: Include limits.h (fixes the MS-Windows build broken by
55 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
56
8ff0ac3c 572011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 58
4c4b566b
PE
59 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
60
aab2b9b5
PE
61 * term.c (vfatal): Remove stray call to va_end.
62 It's not needed and the C Standard doesn't allow it here anyway.
63
c378da0b
PE
64 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
65 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
66
288b08c7
PE
67 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
68 bytes.
69
e3601888
PE
70 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
71
db6c0e74
PE
72 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
73
dd5963ea
PE
74 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
75
88c9450f
PE
76 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
77
2f9442b8
PE
78 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
79
c032b5f8
PE
80 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
81 * charset.c (Fdefine_charset_internal): Don't initialize
82 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 83 32-bit int (Bug#8600).
a108c10b
PE
84
85 * lread.c (read_integer): Be more consistent with string-to-number.
86 Use string_to_number to do the actual conversion; this avoids
87 rounding errors and fixes some other screwups. Without this fix,
88 for example, #x1fffffffffffffff was misread as -2305843009213693952.
89 (digit_to_number): Move earlier, for benefit of read_integer.
90 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 91 not a digit in any supported base. (Bug#8602)
a108c10b 92
ad5f9eea
PE
93 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
94
aec1708a
PE
95 * dispnew.c (scrolling_window): Return 1 if we scrolled,
96 to match comment at start of function. This also removes a
97 GCC warning about overflow in a 32+64-bit port.
98
47be4ab5
PE
99 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
100
371cac43
PE
101 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
102 Reported by Stefan Monnier in
103 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
104 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
105 SYMBOLP-guarded XSYMBOL, not XPNTR.
106
d01a7826
PE
107 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
108 (EMACS_UINTPTR): Likewise, with uintptr_t.
109
7fd47d5c
PE
110 * lisp.h: Prefer 64-bit EMACS_INT if available.
111 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
112 on 32-bit hosts that have 64-bit int, so that they can access
113 large files.
122b0c86
PE
114 However, temporarily disable this change unless the temporary
115 symbol WIDE_EMACS_INT is defined.
7fd47d5c 116
8727937b
PE
117 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
118
8ac068ac
PE
119 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
120 This removes an assumption that EMACS_INT and long are the same
121 width as pointers. The assumption is true for Emacs porting targets
122 now, but we want to make other targets possible.
123 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
124 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
125 In the rest of the code, change types of integers that hold casted
126 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
127 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
128 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
129 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
130 No need to cast type when ORing.
131 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
132 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
133 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
134 assume EMACS_INT is the same width as char *.
135 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
136 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
137 Remove no-longer-needed casts.
138 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
139 (xg_tool_bar_help_callback, xg_make_tool_item):
140 Use EMACS_INTPTR to hold an integer
141 that will be cast to void *; this can avoid a GCC warning
142 if EMACS_INT is not the same width as void *.
143 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
144 * xdisp.c (display_echo_area_1, resize_mini_window_1):
145 (current_message_1, set_message_1):
146 Use a local to convert to proper width without a cast.
147 * xmenu.c (dialog_selection_callback): Likewise.
148
ede49d71
PE
149 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
150 Also, don't assume VALBITS / RAND_BITS is less than 5,
151 and don't rely on undefined behavior when shifting a 1 left into
152 the sign bit.
153 * lisp.h (get_random): Change signature to match.
154
2f30ecd0
PE
155 * lread.c (hash_string): Use size_t, not int, for hash computation.
156 Normally we prefer signed values; but hashing is special, because
157 it's better to use unsigned division on hash table sizes so that
158 the remainder is nonnegative. Also, size_t is the natural width
159 for hashing into memory. The previous code used 'int', which doesn't
160 retain enough info to hash well into very large tables.
161 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
162
2a866e7b
PE
163 * dbusbind.c: Don't possibly lose pointer info when converting.
164 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
165 Use XPNTR rather than XHASH, so that the high-order bits of
166 the pointer aren't lost when converting through void *.
167
51639eac
PE
168 * eval.c (Fautoload): Don't double-shift a pointer.
169
92394119
PE
170 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
171
dbdb9a7c
JB
1722011-05-06 Juanma Barranquero <lekktu@gmail.com>
173
174 * gnutls.c (DEF_GNUTLS_FN):
175 * image.c (DEF_IMGLIB_FN): Make function pointers static.
176
db7a0b4f
AS
1772011-05-05 Andreas Schwab <schwab@linux-m68k.org>
178
179 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
180 marker. (Bug#8610)
181
f7ff1b0f 1822011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
183
184 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
185 New version that can reserve upto 2GB of heap space.
186
f7ff1b0f 1872011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
188
189 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
190
639c109b
TZ
1912011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
192
193 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
194 `gnutls_certificate_set_x509_key_file'.
195
d2127135
JB
1962011-05-05 Juanma Barranquero <lekktu@gmail.com>
197
198 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
199 Update dependencies.
200
e968f4f3
JB
2012011-05-04 Juanma Barranquero <lekktu@gmail.com>
202
203 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
204 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
205 Remove unused parameter `fildes'.
206 * process.c (read_process_output, send_process): Don't pass it.
207
84d358f0
JB
2082011-05-04 Juanma Barranquero <lekktu@gmail.com>
209
210 Fix previous change: the library cache is defined in w32.c.
211 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
212 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
213
0898ca10
JB
2142011-05-04 Juanma Barranquero <lekktu@gmail.com>
215
216 Implement dynamic loading of GnuTLS on Windows.
217
218 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
219 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
220 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
221 Declare.
222
223 * gnutls.c (Qgnutls_dll): Define.
224 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
225 (gnutls_*): Declare function pointers.
226 (init_gnutls_functions): New function to initialize function pointers.
227 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
228 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
229 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
230 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
231 (emacs_gnutls_write, emacs_gnutls_read)
232 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
233 (Fgnutls_available_p): New function.
234 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
235 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
236 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
237
238 * image.c: Include w32.h.
239 (Vimage_type_cache): Delete.
240 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
241 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
242 (w32_delayed_load): Move to w32.c.
243
244 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
245
246 * w32.c (QCloaded_from, Vlibrary_cache): Define.
247 (w32_delayed_load): Move from image.c. When loading a library, record
248 its filename in the :loaded-from property of the library id.
249 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
250 Initialize and staticpro them.
251 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
252
253 * process.c: Include lisp.h before w32.h, not after.
254 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
255 instead of gnutls_record_check_pending.
256
257 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
258
ff4de4aa
TZ
2592011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
260
261 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
262 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
263 as passed in.
264
abe95abb
JD
2652011-05-03 Jan Djärv <jan.h.d@swipnet.se>
266
267 * xterm.c (x_set_frame_alpha): Do not set property on anything
268 else than FRAME_X_OUTER_WINDOW (Bug#8608).
269
e16e55d4
JB
2702011-05-02 Juanma Barranquero <lekktu@gmail.com>
271
272 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
273
bafcf6a5
JB
2742011-05-02 Juanma Barranquero <lekktu@gmail.com>
275
276 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
277 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
278 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
279 (gnutls_global_initialized, Qgnutls_bootprop_priority)
280 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
281 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
282 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
283 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
284 (Qgnutls_bootprop_callbacks_verify): Make static.
285
e7a6747f
AS
2862011-05-01 Andreas Schwab <schwab@linux-m68k.org>
287
19ed11ba
AS
288 * callproc.c: Indentation fixup.
289
e7a6747f
AS
290 * sysdep.c (wait_for_termination_1): Make static.
291 (wait_for_termination, interruptible_wait_for_termination): Move
292 after wait_for_termination_1.
293
1ef14cb4
LMI
2942011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
295
296 * sysdep.c (interruptible_wait_for_termination): New function
297 which is like wait_for_termination, but allows keyboard
298 interruptions.
299
300 * callproc.c (Fcall_process): Add (:file "file") as an option for
301 the STDOUT buffer.
302 (Fcall_process_region): Ditto.
303
330d880c
EZ
3042011-04-30 Eli Zaretskii <eliz@gnu.org>
305
8db90b73
EZ
306 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
307 rather than `XVECTOR (FOO)->size'.
308
330d880c
EZ
309 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
310 inttypes.h, as a gnulib replacement is used if it not available in
311 system headers.
312
15cbd324
EZ
3132011-04-21 Eli Zaretskii <eliz@gnu.org>
314
315 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
316 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
317 of MOST_POSITIVE_FIXNUM. (Bug#8528)
318
319 * coding.c (coding_alloc_by_realloc): Error out if destination
320 will grow beyond MOST_POSITIVE_FIXNUM.
321 (decode_coding_emacs_mule): Abort if there isn't enough place in
322 charbuf for the composition carryover bytes. Reserve an extra
323 space for up to 2 characters produced in a loop.
324 (decode_coding_iso_2022): Abort if there isn't enough place in
325 charbuf for the composition carryover bytes.
326
3272011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 328
ae940cca
EZ
329 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
330 aborting when %lld or %lll format is passed.
331 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
332 %llo or %llx format is passed. (Bug#8545)
333
03ab8921
EZ
334 * window.c (window_scroll_line_based): Use a marker instead of
335 simple variables to record original value of point. (Bug#7952)
336
afda1437
EZ
337 * doprnt.c (doprnt): Fix the case where a multibyte sequence
338 produced by %s or %c overflows available buffer space. (Bug#8545)
339
f76dee0c
PE
3402011-04-28 Paul Eggert <eggert@cs.ucla.edu>
341
342 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 343 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 344
fdc5744d
JB
3452011-04-28 Juanma Barranquero <lekktu@gmail.com>
346
347 * w32.c (init_environment): Warn about defaulting HOME to C:\.
348
638f053a
JB
3492011-04-28 Juanma Barranquero <lekktu@gmail.com>
350
351 * keyboard.c (Qdelayed_warnings_hook): Define.
352 (command_loop_1): Run `delayed-warnings-hook'
353 if Vdelayed_warnings_list is non-nil.
354 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
355 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
356
d178f871
EZ
3572011-04-28 Eli Zaretskii <eliz@gnu.org>
358
359 * doprnt.c (doprnt): Don't return value smaller than the buffer
360 size if the message was truncated. (Bug#8545).
361
b124fd93
JB
3622011-04-28 Juanma Barranquero <lekktu@gmail.com>
363
364 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
365 (Fx_window_property): #if-0 the whole functions, not just the bodies.
366
e810457d
PE
3672011-04-27 Paul Eggert <eggert@cs.ucla.edu>
368
369 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
370
ea51cceb
JB
3712011-04-27 Juanma Barranquero <lekktu@gmail.com>
372
373 * makefile.w32-in: Update dependencies.
374
94dcfacf
EZ
3752011-04-27 Eli Zaretskii <eliz@gnu.org>
376
377 Improve `doprnt' and its usage. (Bug#8545)
378 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
379 `format_end'. Remove support for %l as a conversion specifier.
380 Don't use xrealloc. Improve diagnostics when the %l size modifier
381 is used. Update the commentary.
382
383 * eval.c (verror): Simplify calculation of size_t.
384
385 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
386 messages.
387
f61f41d7
PE
3882011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
389
390 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
391 change.
392
96fb4434
PE
3932011-04-27 Paul Eggert <eggert@cs.ucla.edu>
394
395 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
396 This makes this file independent of the recent pseudovector change.
397
671875da 3982011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 399
69e9b5a3
PE
400 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
401
b5f869a7 402 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 403 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 404 Remove unused local.
c8926152 405 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 406
841a1577 407 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
408 GCC 4.6.0 optimizes based on type-based alias analysis. For
409 example, if b is of type struct buffer * and v of type struct
410 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
411 != &v->size, and therefore "v->size = 1; b->size = 2; return
412 v->size;" must therefore return 1. This assumption is incorrect
413 for Emacs, since it type-puns struct Lisp_Vector * with many other
414 types. To fix this problem, this patch adds a new type struct
f904488f 415 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
416 and pseudovectors, and helps optimizing compilers not get fooled
417 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
418 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
419 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
420 the size member.
eab3844f
PE
421 (XSETPVECTYPE): Rewrite in terms of new macro.
422 (XSETPVECTYPESIZE): New macro, specifying both type and size.
423 This is a bit clearer, and further avoids the possibility of
424 undesirable aliasing.
425 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 426 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
427 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
428 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
429 (ASIZE): Now uses header.size rather than size. All
430 previous uses of XVECTOR (foo)->size replaced to use this macro,
431 to avoid the hassle of writing XVECTOR (foo)->header.size.
432 (struct vectorlike_header): New type.
eab3844f
PE
433 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
434 object, to help avoid aliasing.
435 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
436 (SUBRP): Likewise, since Lisp_Subr is a special case.
437 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
438 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
439 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 440 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
441 changed to be "header.size" and "header.next".
442 * buffer.h (struct buffer): Likewise.
443 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
444 * frame.h (struct frame): Likewise.
445 * process.h (struct Lisp_Process): Likewise.
446 * termhooks.h (struct terminal): Likewise.
447 * window.c (struct save_window_data, struct saved_window): Likewise.
448 * window.h (struct window): Likewise.
449 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
450 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
451 * buffer.c (init_buffer_once): Likewise.
452 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
453 special case.
454 * process.c (Fformat_network_address): Use local var for size,
455 for brevity.
456
0df1eac5
PE
457 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
458
847ab9d1 459 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
460 * data.c (atof): Remove decl; no longer used or needed.
461 (digit_to_number): Move to lread.c.
462 (Fstring_to_number): Use new string_to_number function, to be
463 consistent with how the Lisp reader treats infinities and NaNs.
464 Do not assume that floating-point numbers represent EMACS_INT
465 without losing information; this is not true on most 64-bit hosts.
466 Avoid double-rounding errors, by insisting on integers when
467 parsing non-base-10 numbers, as the documentation specifies.
468 * lisp.h (string_to_number): New decl, replacing ...
469 (isfloat_string): Remove.
bc0a5c13 470 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 471 (read1): Do not accept +. and -. as integers; this
452f4150
PE
472 appears to have been a coding error. Similarly, do not accept
473 strings like +-1e0 as floating point numbers. Do not report
474 overflow for integer overflows unless the base is not 10 which
475 means we have no simple and reliable way to continue.
476 Break out the floating-point parsing into a new
477 function string_to_number, so that Fstring_to_number parses
478 floating point numbers consistently with the Lisp reader.
479 (digit_to_number): Moved here from data.c. Make it static inline.
480 (E_CHAR, EXP_INT): Remove, replacing with ...
481 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
482 (string_to_number): New function, replacing isfloat_string.
483 This function checks for valid syntax and produces the resulting
484 Lisp float number too. Rework it so that string-to-number
bc0a5c13 485 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
486 so that overflow for non-base-10 numbers is reported only when
487 there's no portable and simple way to convert to floating point.
452f4150 488
67769ffc
PE
489 * textprop.c (set_text_properties_1): Rewrite for clarity,
490 and to avoid GCC warning about integer overflow.
491
c20db43f
PE
492 * intervals.h (struct interval): Use EMACS_INT for members
493 where EMACS_UINT might cause problems. See
494 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
495 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
496 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
497 All uses changed.
37aa2f85
PE
498 (offset_intervals): Tell GCC not to worry about length overflow
499 when negating a negative length.
c20db43f 500
2538aa2f
PE
501 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
502 (overrun_check_free): Likewise.
503
f2d3008d
PE
504 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
505 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
506 word size.
507
ec8df744
PE
508 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
509 (gnutls_make_error): Rename local to avoid shadowing.
510 (gnutls_emacs_global_deinit): ifdef out; not used.
511 (Fgnutls_boot): Use const for pointer to readonly storage.
512 Comment out unused local. Fix pointer signedness problems.
513
640ee02d
PE
514 * lread.c (openp): Don't stuff size_t into an 'int'.
515 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
516 about possible signed overflow.
517
6048fb2a
PE
518 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
519 (GDK_KEY_g): Don't define if already defined.
520 (xg_prepare_tooltip): Avoid pointer signedness problem.
521 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
522
fa3c87e1
PE
523 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
524 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
525
2172544b
PE
526 * xfns.c (Fx_window_property): Simplify a bit,
527 to make a bit faster and to avoid GCC 4.6.0 warning.
528 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
529
9b821a21
PE
530 * fns.c (internal_equal): Don't assume size_t fits in int.
531
3c616cfa
PE
532 * alloc.c (compact_small_strings): Tighten assertion a little.
533
c2982e87
PE
534 Replace pEd with more-general pI, and fix some printf arg casts.
535 * lisp.h (pI): New macro, generalizing old pEd macro to other
536 conversion specifiers. For example, use "...%"pI"d..." rather
537 than "...%"pEd"...".
538 (pEd): Remove. All uses replaced with similar uses of pI.
539 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
540 * alloc.c (check_pure_size): Don't overflow by converting size to int.
541 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
542 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
543 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
544 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
545 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
546 64-bit hosts.
547 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
548 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
549 * print.c (safe_debug_print, print_object): Likewise.
550 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
551 to int.
6f04d126
PE
552 Use pI instead of if-then-else-abort. Use %p to avoid casts,
553 avoiding the 0 flag, which is not portable.
c2982e87
PE
554 * process.c (Fmake_network_process): Use pI to avoid cast.
555 * region-cache.c (pp_cache): Likewise.
556 * xdisp.c (decode_mode_spec): Likewise.
557 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
558 behavior on 64-bit hosts with printf arg.
6f04d126 559 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
560 (x_stop_queuing_selection_requests): Likewise.
561 (x_get_window_property): Don't truncate byte count to an 'int'
562 when tracing.
0b432f21 563
5e073ec7
PE
564 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
565 here, since it parses constructs like leading '-' and spaces,
566 which are not wanted; and it overflows with large numbers.
567 Instead, simply match F[0-9]+, which is what is wanted anyway.
568
36372bf9
PE
569 * alloc.c: Remove unportable assumptions about struct layout.
570 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
571 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
572 (allocate_vectorlike, make_pure_vector): Use the new macros,
573 plus offsetof, to remove unportable assumptions about struct layout.
574 These assumptions hold on all porting targets that I know of, but
575 they are not guaranteed, they're easy to remove, and removing them
576 makes further changes easier.
577
0b432f21
PE
578 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
579 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
580 (string_overrun_cookie): Now const. Use initializers that
581 don't formally overflow signed char, to avoid warnings.
000098c1
PE
582 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
583 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
584 (allocate_buffer): Don't assume sizeof (struct buffer) is a
585 multiple of sizeof (EMACS_INT); it need not be, if
586 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 587 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 588
895009e1
JB
5892011-04-26 Juanma Barranquero <lekktu@gmail.com>
590
591 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
592
6a7a1b0b
TZ
5932011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
594
595 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 596 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
597 Reported by Paul Eggert <eggert@cs.ucla.edu>.
598
841a1577 5992011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
600
601 * lisp.h (Qdebug): List symbol.
895009e1 602 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
603 * keyboard.c (debug-on-event): New variable.
604 (handle_user_signal): Break into debugger when debug-on-event
605 matches the current signal symbol.
606
f2d3ba6f
DN
6072011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
608
609 * alloc.c (check_sblock, check_string_bytes)
610 (check_string_free_list): Convert to standard C.
611
42ce4c63
TZ
6122011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
613
614 * w32.c (emacs_gnutls_push): Fix typo.
615
825cd63c
EZ
6162011-04-25 Eli Zaretskii <eliz@gnu.org>
617
fb11d64d
EZ
618 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
619 "cast to pointer from integer of different size".
620
825cd63c
EZ
621 Improve doprnt and its use in verror. (Bug#8545)
622 * doprnt.c (doprnt): Document the set of format control sequences
623 supported by the function. Use SAFE_ALLOCA instead of always
624 using `alloca'.
625
626 * eval.c (verror): Don't limit the buffer size at size_max-1, that
627 is one byte too soon. Don't use xrealloc; instead xfree and
628 xmalloc anew.
629
e061a11b
TZ
6302011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
631
632 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
633 callbacks stage.
634
635 * gnutls.c: Renamed global_initialized to
636 gnutls_global_initialized. Added internals for the
637 :verify-hostname-error, :verify-error, and :verify-flags
638 parameters of `gnutls-boot' and documented those parameters in the
639 docstring. Start callback support.
640 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
641 unless a fatal error occured. Call gnutls_alert_send_appropriate
642 on error. Return error code.
643 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
644 (emacs_gnutls_read): Likewise.
645 (Fgnutls_boot): Return handshake error code.
646 (emacs_gnutls_handle_error): New function.
647 (wsaerror_to_errno): Likewise.
648
649 * w32.h (emacs_gnutls_pull): Add prototype.
650 (emacs_gnutls_push): Likewise.
651
652 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
653 (emacs_gnutls_push): Likewise.
654
6552011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
656
657 * process.c (wait_reading_process_output): Check if GnuTLS
658 buffered some data internally if no FDs are set for TLS
659 connections.
660
661 * makefile.w32-in (OBJ2): Add gnutls.$(O).
662 (LIBS): Link to USER_LIBS.
663 ($(BLD)/gnutls.$(0)): New target.
664
fa6996bc
EZ
6652011-04-24 Eli Zaretskii <eliz@gnu.org>
666
eb35682e
EZ
667 * xdisp.c (handle_single_display_spec): Rename the
668 display_replaced_before_p argument into display_replaced_p, to
669 make it consistent with the commentary. Fix typos in the
670 commentary.
671
e2ad650c
EZ
672 * textprop.c (syms_of_textprop): Remove dead code.
673 (copy_text_properties): Delete obsolete commentary about an
674 interface that was deleted long ago. Fix typos in the description
675 of arguments.
676
1b2de274
EZ
677 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
678 to changes in oldXMenu/XMenu.h from 2011-04-16.
679 <menu_help_message, prev_menu_help_message>: Constify.
680 (IT_menu_make_room): menu->help_text is now `const char **';
681 adjust.
682
683 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
684 to changes in oldXMenu/XMenu.h from 2011-04-16.
685 (struct XMenu): Declare `help_text' `const char **'.
686
687 * xfaces.c <Qunspecified>: Make extern again.
688
689 * syntax.c: Include sys/types.h before including regex.h, as
690 required by Posix.
691
762b15be
EZ
692 * doc.c (get_doc_string): Improve the format passed to `error'.
693
694 * doprnt.c (doprnt): Improve commentary.
695
696 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
697
698 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
699 them with etags.
700
f1052e5d
EZ
701 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
702 changes in globals.h immediately force recompilation.
762b15be
EZ
703 (TAGS): Depend on $(CURDIR)/m/intel386.h and
704 $(CURDIR)/s/ms-w32.h.
705 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 706
fa6996bc
EZ
707 * character.c (Fchar_direction): Function deleted.
708 (syms_of_character): Don't defsubr it.
709 <char-direction-table>: Deleted.
710
e6c3da20
EZ
7112011-04-23 Eli Zaretskii <eliz@gnu.org>
712
713 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
714 * doprnt.c: Include limits.h.
715 (SIZE_MAX): New macro.
716 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
717 local variables are now size_t instead of int or unsigned.
718 Improve overflow protection. Support `l' modifier for integer
719 conversions. Support %l conversion. Don't assume an EMACS_INT
720 argument for integer conversions and for %c.
721
722 * lisp.h (doprnt): Restore prototype.
723
724 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
725 $(SRC)/character.h.
726
727 * Makefile.in (base_obj): Add back doprnt.o.
728
729 * deps.mk (doprnt.o): Add back prerequisites.
730 (callint.o): Depend on character.h.
731
732 * eval.c (internal_lisp_condition_case): Include the handler
733 representation in the error message.
734 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
735 when breaking from the loop.
736
737 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
738
739 * callint.c (Fcall_interactively): When displaying error message
740 about invalid control letter, pass the character's codepoint, not
741 a pointer to its multibyte form. Improve display of the character
742 in octal and display also its hex code.
743
744 * character.c (char_string): Use %x to display the (unsigned)
745 codepoint of an invalid character, to avoid displaying a bogus
746 negative value.
747
748 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
749 `error', not SYMBOL_NAME itself.
750
751 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
752 character arguments to `error'.
753
754 * charset.c (check_iso_charset_parameter): Fix incorrect argument
755 to `error' in error message about FINAL_CHAR argument. Make sure
756 FINAL_CHAR is a character, and use %c when it is passed as
757 argument to `error'.
758
4ffd0d6b 7592011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
760
761 * s/ms-w32.h (localtime): Redirect to sys_localtime.
762
763 * w32.c: Include <time.h>.
764 (sys_localtime): New function.
765
4ffd0d6b 7662011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
767
768 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
769
4ffd0d6b 770 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 771
4ffd0d6b 7722011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 773
4ffd0d6b
GM
774 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
775 zombies (Bug#8467).
aac0c6e3 776
04c56954
EZ
7772011-04-19 Eli Zaretskii <eliz@gnu.org>
778
779 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
780 gl_state.e_property when gl_state.object is Qt.
781
782 * insdel.c (make_gap_larger): Remove limitation of buffer size
783 to <= INT_MAX.
784
16a43933
CY
7852011-04-18 Chong Yidong <cyd@stupidchicken.com>
786
787 * xdisp.c (lookup_glyphless_char_display)
788 (produce_glyphless_glyph): Handle cons cell entry in
789 glyphless-char-display.
790 (Vglyphless_char_display): Document it.
791
792 * term.c (produce_glyphless_glyph): Handle cons cell entry in
793 glyphless-char-display.
794
4581706e
CY
7952011-04-17 Chong Yidong <cyd@stupidchicken.com>
796
797 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
798
799 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
800
801 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
802 definition for no-X builds.
803
4887c6e2 8042011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 805
fd35b6f9
PE
806 Static checks with GCC 4.6.0 and non-default toolkits.
807
5c1ccb01
PE
808 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
809
006c5daa
PE
810 * process.c (keyboard_bit_set): Define only if SIGIO.
811 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
812 (send_process): Repair possible setjmp clobbering.
813
efc736d3
PE
814 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
815
4e2fe2e6
PE
816 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
817
f97334a2
PE
818 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
819
4e75f29d
PE
820 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
821 Define only if needed.
822
90efadd1
PE
823 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
824 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 825 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 826
3c647824
PE
827 * dispextern.h (struct redisplay_interface): Rename param
828 to avoid shadowing.
e264f262 829 * termhooks.h (struct terminal): Likewise.
761383f4 830 * xterm.c (xembed_send_message): Likewise.
3c647824 831
b58c5c4a
PE
832 * insdel.c (make_gap_smaller): Define only if
833 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
834
cad59032
PE
835 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
836 it.
837
c339dc2e
PE
838 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
839 so that we aren't warned about unused symbols.
840
91a3e27b
PE
841 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
842
399c71d3 843 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 844
8ffc96f5
PE
845 * xfns.c (x_real_positions): Mark locals as initialized.
846
eef9bc79
PE
847 * xmenu.c (xmenu_show): Don't use uninitialized vars.
848
098db9dd
PE
849 * xterm.c: Fix problems found by static analysis with other toolkits.
850 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
851 (x_dispatch_event): Declare static if USE_GTK, and
852 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 853 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 854 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
855 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
856 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 857
eb18f6cc
PE
858 * xmenu.c (menu_help_callback): Pointer type fixes.
859 Use const pointers when pointing at readonly data. Avoid pointer
860 signedness clashes.
861 (FALSE): Remove unused macro.
862 (update_frame_menubar): Remove unused decl.
863
1fe72bf8
PE
864 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
865
60d9e1db
PE
866 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
867 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
868 (single_menu_item): Rename local to avoid shadowing.
869
39261c26
PE
870 * keyboard.c (make_lispy_event): Remove unused local var.
871
018c5e19
PE
872 * frame.c, frame.h (x_get_resource_string): Bring this back, but
873 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
874
63d2b86e
PE
875 * bitmaps: Change bitmaps from unsigned char back to the X11
876 compatible char. Avoid the old compiler warnings about
877 out-of-range initializers by using, for example, '\xab' rather
878 than 0xab.
879
aefd87e1
PE
880 * xgselect.c (xgselect_initialize): Check vs interface
881 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
882
bf501fb9
PE
883 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
884
e9829fdf
PE
885 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
886 to read-only memory.
887
1086c095
PE
888 * fns.c (vector): Remove; this old hack is no longer needed.
889
2baccd04 890 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 891 Remove unused var.
dde42981 892 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 893
72391843 894 * xrdb.c (x_load_resources): Omit unused local.
3565b346 895
436c16df 896 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 897 (x_window): Rename locals to avoid shadowing.
dc5ddd85 898 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 899
92bb796d 900 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 901 (x_term_init): Remove local to avoid shadowing.
92bb796d 902
764430a3 903 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
904
905 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
906 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
907
d1dfb56c
EZ
9082011-04-16 Eli Zaretskii <eliz@gnu.org>
909
c4354cb4
EZ
910 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
911
d1dfb56c
EZ
912 Fix regex.c, syntax.c and friends for buffers > 2GB.
913 * syntax.h (struct gl_state_s): Declare character position members
914 EMACS_INT.
915
916 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
917
918 * textprop.c (verify_interval_modification, interval_of): Declare
919 arguments EMACS_INT.
920
921 * intervals.c (adjust_intervals_for_insertion): Declare arguments
922 EMACS_INT.
923
924 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
925
926 * indent.c (Fvertical_motion): Local variable it_start is now
927 EMACS_INT.
928
929 * regex.c (re_match, re_match_2, re_match_2_internal)
930 (bcmp_translate, regcomp, regexec, print_double_string)
931 (group_in_compile_stack, re_search, re_search_2, regex_compile)
932 (re_compile_pattern, re_exec): Declare arguments and local
933 variables `size_t' and `ssize_t' and return values `regoff_t', as
934 appropriate.
935 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
936 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
937 <compile_stack_type>: `size' and `avail' are now `size_t'.
938
939 * regex.h <regoff_t>: Use ssize_t, not int.
940 (re_search, re_search_2, re_match, re_match_2): Arguments that
941 specify buffer/string position and length are now ssize_t and
942 size_t. Return type is regoff_t.
943
613052cd
BK
9442011-04-16 Ben Key <bkey76@gmail.com>
945
946 * nsfont.m: Fixed bugs in ns_get_family and
947 ns_descriptor_to_entity that were caused by using free to
948 deallocate memory blocks that were allocated by xmalloc (via
949 xstrdup). This caused Emacs to crash when compiled with
950 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
951 --enable-checking=xmallocoverrun). xfree is now used to
952 deallocate these memory blocks.
953
4170f62f 9542011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 955
71b41406
PE
956 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
957
9587a89d
PE
958 emacs_write: Accept and return EMACS_INT for sizes.
959 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
960 et seq.
961 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
962 Accept and return EMACS_INT.
963 (emacs_gnutls_write): Return the number of bytes written on
964 partial writes.
965 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
966 (emacs_read, emacs_write): Remove check for negative size, as the
967 Emacs source code has been audited now.
9587a89d
PE
968 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
969 (emacs_read, emacs_write): Use it.
273a5f82
PE
970 * process.c (send_process): Adjust to the new signatures of
971 emacs_write and emacs_gnutls_write. Do not attempt to store
972 a byte offset into an 'int'; it might overflow.
9587a89d 973 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 974
3e047f51
PE
975 * sound.c: Don't assume sizes fit in 'int'.
976 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 977 Return EMACS_INT, not int.
3e047f51 978 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
979 Accept EMACS_INT, not int.
980 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
981 record read return values.
982
cc39a9db
BK
9832011-04-15 Ben Key <bkey76@gmail.com>
984
c9d0ec6d
JB
985 * keyboard.c (Qundefined): Don't declare static since it is used
986 in nsfns.m.
987 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
988 static since they are used in nsfont.m.
cc39a9db 989
6c60eb9f
SM
9902011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
991
992 * process.c (Qprocessp): Don't declare static.
993 * lisp.h (Qprocessp): Declare again.
994
7990b61a
JB
9952011-04-15 Juanma Barranquero <lekktu@gmail.com>
996
997 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
998
5d4cb038
PE
9992011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1000
8bd7b830 1001 Improve C-level modularity by making more things 'static'.
cd64ea1d 1002
e3b27b31
PE
1003 Don't publish debugger-only interfaces to other modules.
1004 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1005 (verify_bytepos, count_markers): Move decls to the only modules
1006 that need them.
1007 * region-cache.h (pp_cache): Likewise.
1008 * window.h (check_all_windows): Likewise.
1009 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1010
5d4cb038
PE
1011 * sysdep.c (croak): Now static, if
1012 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1013 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1014
1015 * alloc.c (refill_memory_reserve): Now static if
1016 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1017 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1018
e87b6180
PE
1019 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1020 Define only if USE_LUCID.
1021
ac64929e
PE
1022 * xrdb.c (x_customization_string, x_rm_string): Now static.
1023
6f37259d
PE
1024 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1025 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1026
1683e3ab
PE
1027 * xdisp.c (draw_row_with_mouse_face): Now static.
1028 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1029
de9c2632
PE
1030 * window.h (check_all_windows): Mark externally visible.
1031
2b96acb7
PE
1032 * window.c (window_deletion_count): Now static.
1033
1034 * undo.c: Make symbols static if they're not exported.
1035 (last_undo_buffer, last_boundary_position, pending_boundary):
1036 Now static.
1037
50436f33
PE
1038 * textprop.c (interval_insert_behind_hooks): Now static.
1039 (interval_insert_in_front_hooks): Likewise.
1040
64520e5c
PE
1041 * term.c: Make symbols static if they're not exported.
1042 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1043 (max_frame_lines, tty_set_terminal_modes):
1044 (tty_reset_terminal_modes, tty_turn_off_highlight):
1045 (get_tty_terminal): Now static.
1046 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1047 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1048 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1049 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1050 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1051
1fa53021
PE
1052 * sysdep.c: Make symbols static if they're not exported.
1053 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1054 Now static.
1055 (sigprocmask_set, full_mask): Remove; unused.
1056 (wait_debugging): Mark as visible.
1057 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1058 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1059
d4b43b22
PE
1060 * syntax.c (syntax_temp): Define only if !__GNUC__.
1061
b7c513d0
PE
1062 * sound.c (current_sound_device, current_sound): Now static.
1063
989b29ad
PE
1064 * search.c (searchbufs, searchbuf_head): Now static.
1065
13a55a78
PE
1066 * scroll.c (scroll_cost): Remove; unused.
1067 * dispextern.h (scroll_cost): Remove decl.
1068
de68a1fc
PE
1069 * region-cache.h (pp_cache): Mark as externally visible.
1070
40ccffa6
PE
1071 * process.c: Make symbols static if they're not exported.
1072 (process_tick, update_tick, create_process, chan_process):
1073 (Vprocess_alist, proc_buffered_char, datagram_access):
1074 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1075 (deactivate_process): Mark defn as static, as well as decl.
1076 * lisp.h (create_process): Remove decl.
1077 * process.h (chan_process, Vprocess_alist): Remove decls.
1078
ad64fc97
PE
1079 * print.c: Make symbols static if they're not exported.
1080 (print_depth, new_backquote_output, being_printed, print_buffer):
1081 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1082 (print_interval, print_number_index, initial_stderr_stream):
1083 Now static.
1084 * lisp.h (Fprinc): Remove decl.
1085 (debug_output_compilation_hack): Mark as externally visible.
1086
adddb265
PE
1087 * sysdep.c (croak): Move decl from here to syssignal.h.
1088 * syssignal.h (croak): Put it here, so the API can be checked when
1089 'croak' is called from dissociate_if_controlling_tty.
1090
1717ede2
PE
1091 * minibuf.c: Make symbols static if they're not exported.
1092 (minibuf_save_list, choose_minibuf_frame): Now static.
1093 * lisp.h (choose_minibuf_frame): Remove decl.
1094
fa5fb2bc
PE
1095 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1096
1e3890d1
PE
1097 * lread.c: Make symbols static if they're not exported.
1098 (read_objects, initial_obarray, oblookup_last_bucket_number):
1099 Now static.
1100 (make_symbol): Remove; unused.
1101 * lisp.h (initial_obarray, make_symbol): Remove decls.
1102
8a1414fa
PE
1103 * keyboard.c: Make symbols static if they're not exported.
1104 (single_kboard, recent_keys_index, total_keys, recent_keys):
1105 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1106 (this_single_command_key_start, echoing, last_auto_save):
1107 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1108 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1109 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1110 (Vlispy_mouse_stem, double_click_count):
1111 Now static.
1112 (force_auto_save_soon): Define only if SIGDANGER.
1113 (ignore_mouse_drag_p): Now static if
1114 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1115 (print_help): Remove; unused.
1116 (stop_character, last_timer_event): Mark as externally visible.
1117 * keyboard.h (ignore_mouse_drag_p): Declare only if
1118 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1119 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1120 * lisp.h (echoing): Remove decl.
1121 (force_auto_save_soon): Declare only if SIGDANGER.
1122 * xdisp.c (redisplay_window): Simplify code, to make it more
1123 obvious that ignore_mouse_drag_p is not accessed if !defined
1124 USE_GTK && !defined HAVE_NS.
1125
93ea6e8f
PE
1126 * intervals.c: Make symbols static if they're not exported.
1127 (merge_properties_sticky, merge_interval_right, delete_interval):
1128 Now static.
1129 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1130
77382fcc
PE
1131 * insdel.c: Make symbols static if they're not exported.
1132 However, leave prepare_to_modify_buffer alone. It's never
1133 called from outside this function, but that appears to be a bug.
1134 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1135 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1136 (adjust_after_replace_noundo): Remove; unused.
1137 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1138 (signal_before_change): Remove decls.
77382fcc 1139
9306c32e
PE
1140 * indent.c (val_compute_motion, val_vmotion): Now static.
1141
cd44d2eb
PE
1142 * image.c: Make symbols static if they're not exported.
1143 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1144 if USE_GTK.
1145 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1146 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1147
ad9a7a06
PE
1148 * fringe.c (standard_bitmaps): Now static.
1149 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1150
81626931
PE
1151 * frame.c: Make symbols static if they're not exported.
1152 (x_report_frame_params, make_terminal_frame): Now static.
1153 (get_frame_param): Now static, unless HAVE_NS.
1154 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1155 (x_get_resource_string): Remove; not used.
1156 * frame.h (make_terminal_frame, x_report_frame_params):
1157 (x_get_resource_string); Remove decls.
1158 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1159 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1160
239f9db9
PE
1161 * font.c, fontset.c: Make symbols static if they're not exported.
1162 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1163 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1164 * font.c (font_close_object): Now static.
1165 * font.h (font_close_object): Remove.
1166 * fontset.c (FONTSET_OBJLIST): Remove.
1167 (free_realized_fontset) #if-0 the body, which does nothing.
1168 (face_suitable_for_char_p): #if-0, as it's never called.
1169 * fontset.h (face_suitable_for_char_p): Remove decl.
1170 * xfaces.c (face_at_string_position): Use
1171 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1172 since 0 is always ASCII.
1173
dfcf3579
PE
1174 * fns.c (weak_hash_tables): Now static.
1175
5045092b
PE
1176 * fileio.c: Make symbols static if they're not exported.
1177 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1178 (Vwrite_region_annotation_buffers): Now static.
1179
57a96f5c
PE
1180 * eval.c: Make symbols static if they're not exported.
1181 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1182 * lisp.h (backtrace_list): Remove decl.
1183
35f08c38
PE
1184 * emacs.c: Make symbols static if they're not exported.
1185 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1186 (fatal_error_code, fatal_error_signal_hook, standard_args):
1187 Now static.
1188 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1189 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1190 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1191 * lisp.h (fatal_error_signal_hook): Remove decl.
1192 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1193
f44bd759
PE
1194 * editfns.c: Move a (normally-unused) function to its only use.
1195 * editfns.c, lisp.h (get_operating_system_release): Remove.
1196 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1197 worth the hassle of breaking this out.
1198
b532497d
PE
1199 * xterm.c: Make symbols static if they're not exported.
1200 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1201 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1202 (x_destroy_window, x_delete_display):
1203 Now static.
1204 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1205 (x_mouse_leave): Remove; unused.
1206 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1207 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1208 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1209 Remove decls.
1210 (x_mouse_leave): Declare only if WINDOWSNT.
1211 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1212 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1213 USE_X_TOOLKIT.
1214
1675728f
PE
1215 * ftxfont.c: Make symbols static if they're not exported.
1216 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1217 HAVE_FREETYPE.
1218 * font.h (ftxfont_driver): Likewise.
1219
e4cebfca
PE
1220 * xfns.c: Make symbols static if they're not exported.
1221 (x_last_font_name, x_display_info_for_name):
1222 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1223 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1224 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1225 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1226 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1227 (last_show_tip_args): Now static.
1228 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1229 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1230 (x_screen_planes): Remove; unused.
1231 * dispextern.h (x_screen_planes): Remove decl.
1232
5bf46f05
PE
1233 * dispnew.c: Make symbols static if they're not exported.
1234 * dispextern.h (redraw_garbaged_frames, scrolling):
1235 (increment_row_positions): Remove.
1236 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1237 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1238 Now static.
1239 (redraw_garbaged_frames): Remove; unused.
1240
435f4c28
PE
1241 * xfaces.c: Make symbols static if they're not exported.
1242 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1243 Remove decls.
1244 * xterm.h (defined_color): Remove decls.
1245 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1246 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1247 (menu_face_changed_default, defined_color, free_realized_face):
1248 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1249 (ascii_face_of_lisp_face): Remove; unused.
1250
8524aef3
PE
1251 * xdisp.c: Make symbols static if they're not exported.
1252 * dispextern.h (scratch_glyph_row, window_box_edges):
1253 (glyph_to_pixel_coords, set_cursor_from_row):
1254 (get_next_display_element, set_iterator_to_next):
1255 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1256 (show_mouse_face): Remove decls
1257 * frame.h (message_buf_print): Likewise.
1258 * lisp.h (pop_message, set_message, check_point_in_composition):
1259 Likewise.
1260 * xterm.h (set_vertical_scroll_bar): Likewise.
1261 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1262 (message_buf_print, scratch_glyph_row, displayed_buffer):
1263 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1264 (get_next_display_element, show_mouse_face, window_box_edges):
1265 (frame_to_window_pixel_xy, check_point_in_composition):
1266 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1267 (glyph_to_pixel_coords): Remove; unused.
1268
16390cd2
PE
1269 * dired.c (file_name_completion): Now static.
1270
1271 * dbusbind.c (xd_in_read_queued_messages): Now static.
1272
a25f4dfa
PE
1273 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1274 * data.c (circular_list_error): Remove.
1275
14a9c8df
PE
1276 * commands.h (last_point_position, last_point_position_buffer):
1277 (last_point_position_window): Remove decls.
1278 * keyboard.c: Make these variables static.
1279
74ab6df5
PE
1280 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1281 decls.
1282 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1283 (iso_code_class, detect_coding, code_convert_region): Now static.
1284 (encode_coding_gap): Remove; unused.
1285
38dfbee1
PE
1286 * chartab.c (chartab_chars, chartab_bits): Now static.
1287
a2cb4e63
PE
1288 * charset.h (charset_iso_8859_1): Remove decl.
1289 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1290 Now static.
1291
127198fd
PE
1292 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1293 * ccl.c (Vccl_program_table): Now static.
1294 (check_ccl_update): Remove; unused.
1295
d85b608f
PE
1296 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1297 * category.h: ... from here.
1298 * category.c (check_category_table, set_category_set): Now static.
1299
31cd66f3
PE
1300 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1301 * lisp.h: Remove these decls.
1302
c358e587
PE
1303 * buffer.c (buffer_count): Remove unused var.
1304
e78aecca
PE
1305 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1306 so that it's not optimized away.
1307 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1308 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1309 exported only to the debugger.
1310
e192d7d3
PE
1311 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1312 * atimer.h (run_all_atimers): Removed; not exported.
1313
92470028
PE
1314 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1315 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1316 was inaccessible from Lisp.
1317 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1318 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1319
244ed907
PE
1320 alloc.c: Import and export fewer symbols, and remove unused items.
1321 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1322 is defined.
1323 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1324 it's not optimized away by whole-program optimization.
1325 (message_enable_multibyte, free_misc): Remove.
1326 (catchlist, handlerlist, mark_backtrace):
1327 Declare only if BYTE_MARK_STACK.
1328 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1329 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1330 (message_enable_multibyte): Remove decl.
1331 (free_misc, interval_free_list, float_block, float_block_index):
1332 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1333 (cons_free_list, last_marked_index):
1334 Now static.
1335 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1336 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1337 (mark_backtrace): Define only if BYTE_MARK_STACK.
1338 * xdisp.c (message_enable_multibyte): Now static.
1339
61c2b50e 1340 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1341 This makes it easier for human readers (and static analyzers)
1342 to see whether these variables are used from other modules.
1343 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1344 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1345 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1346 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1347 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1348 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1349 * xmenu.c, xselect.c:
1350 Declare Q* vars static if they are not used in other modules.
1351 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1352 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1353 Remove decls of unexported vars.
1354 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1355
95c82688
PE
1356 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1357
16a97296
PE
1358 Make Emacs functions such as Fatom 'static' by default.
1359 This makes it easier for human readers (and static analyzers)
1360 to see whether these functions can be called from other modules.
1361 DEFUN now defines a static function. To make the function external
1362 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1363 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1364 (Finit_image_library):
16a97296
PE
1365 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1366 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1367 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1368 Remove decls, since these functions are now static.
1369 (Funintern, Fget_internal_run_time): New decls, since these functions
1370 were already external.
95c82688 1371
16a97296
PE
1372 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1373 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1374 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1375 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1376 * keyboard.c, keymap.c, lread.c:
1377 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1378 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1379 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1380 Mark functions with DEFUE instead of DEFUN,
1381 if they are used in other modules.
1382 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1383 decls for now-static functions.
1384 * buffer.h (Fdelete_overlay): Remove decl.
1385 * callproc.c (Fgetenv_internal): Mark as internal.
1386 * composite.c (Fremove_list_of_text_properties): Remove decl.
1387 (Fcomposition_get_gstring): New forward static decl.
1388 * composite.h (Fcomposite_get_gstring): Remove decl.
1389 * dired.c (Ffile_attributes): New forward static decl.
1390 * doc.c (Fdocumntation_property): New forward static decl.
1391 * eval.c (Ffetch_bytecode): New forward static decl.
1392 (Funintern): Remove extern decl; now in .h file where it belongs.
1393 * fileio.c (Fmake_symbolic_link): New forward static decl.
1394 * image.c (Finit_image_library): New forward static decl.
1395 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1396 * intervals.h (Fprevious_property_change):
1397 (Fremove_list_of_text_properties): Remove decls.
1398 * keyboard.c (Fthis_command_keys): Remove decl.
1399 (Fcommand_execute): New forward static decl.
1400 * keymap.c (Flookup_key): New forward static decl.
1401 (Fcopy_keymap): Now static.
1402 * keymap.h (Flookup_key): Remove decl.
1403 * process.c (Fget_process): New forward static decl.
1404 (Fprocess_datagram_address): Mark as internal.
1405 * syntax.c (Fsyntax_table_p): New forward static decl.
1406 (skip_chars): Remove duplicate decl.
1407 * textprop.c (Fprevious_property_change): New forward static decl.
1408 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1409 Now internal.
1410 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1411 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1412
785bbd42
PE
1413 * editfns.c (Fformat): Remove unreachable code.
1414
8b913b57
AS
14152011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1416
1417 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1418 change. (Bug#8496)
1419
a6744a35
EZ
14202011-04-13 Eli Zaretskii <eliz@gnu.org>
1421
1422 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1423 when at ZV. (Bug#8487)
1424
e7974947
AS
14252011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1426
baad03f0
AS
1427 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1428 (Bug#8437)
1429 * keyboard.c (parse_tool_bar_item): Likewise.
1430 * sound.c (sound_cleanup, alsa_close): Likewise.
1431 * termcap.c (tgetent): Likewise.
1432 * xfns.c (x_default_font_parameter): Likewise.
1433 * xsettings.c (read_and_apply_settings): Likewise.
1434
e7974947
AS
1435 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1436 (overrun_check_free): Protoize.
1437
28272684
PE
14382011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1439
1440 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1441 since callers should never pass a negative size.
1442 Change the signature to match that of plain 'read' and 'write'; see
1443 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1444 * lisp.h: Update prototypes of emacs_write and emacs_read.
1445
11997c76
EZ
14462011-04-11 Eli Zaretskii <eliz@gnu.org>
1447
1448 * xdisp.c (redisplay_window): Don't try to determine the character
1449 position of the scroll margin if the window start point w->startp
e896f03c 1450 is outside the buffer's accessible region. (Bug#8468)
11997c76 1451
8a2cbd72
EZ
14522011-04-10 Eli Zaretskii <eliz@gnu.org>
1453
1454 Fix write-region and its subroutines for buffers > 2GB.
1455 * fileio.c (a_write, e_write): Modify declaration of arguments and
1456 local variables to support buffers larger than 2GB.
1457 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1458
1459 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1460 argument, local variables, and return value.
1461
1462 * lisp.h: Update prototypes of emacs_write and emacs_read.
1463
1464 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1465
4073e537 14662011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1467
1ebfdcb6
PE
1468 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1469
b2ded58d
PE
1470 Fix more problems found by GCC 4.6.0's static checks.
1471
7d66342c
PE
1472 * xdisp.c (vmessage): Use a better test for character truncation.
1473
bbf47d44
PE
1474 * charset.c (load_charset_map): <, not <=, for optimization,
1475 and to avoid potential problems with integer overflow.
9248994d 1476 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1477 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1478 * editfns.c (Fformat): Likewise.
1e69125e 1479 * syntax.c (skip_chars): Likewise.
3befa583 1480
e3019616
PE
1481 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1482 This also lets GCC 4.6.0 generate slightly better loop code.
1483
becfa255
PE
1484 * callint.c (Fcall_interactively): <, not <=, for optimization.
1485 (Fcall_interactively): Count the number of arguments produced,
1486 not the number of arguments given. This is simpler and lets GCC
1487 4.6.0 generate slightly better code.
1488
dae0cd48
PE
1489 * ftfont.c: Distingish more carefully between FcChar8 and char.
1490 The previous code passed unsigned char * to a functions like
1491 strlen and xstrcasecmp that expect char *, which does not
1492 conform to the C standard.
1493 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1494 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1495 char * when the C standard requires it.
1496
76032d70
PE
1497 * keyboard.c (read_char): Remove unused var.
1498
eb3f1cc8
PE
1499 * eval.c: Port to Windows vsnprintf (Bug#8435).
1500 Include <limits.h>.
1501 (SIZE_MAX): Define if the headers do not.
1502 (verror): Do not give up if vsnprintf returns a negative count.
1503 Instead, grow the buffer. This ports to Windows vsnprintf, which
1504 does not conform to C99. Problem reported by Eli Zaretskii.
1505 Also, simplify the allocation scheme, by avoiding the need for
1506 calling realloc, and removing the ALLOCATED variable.
1507
70476b54
PE
1508 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1509
12020a9e
PE
1510 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1511 But keep the doprint source code for now, as we might revamp it
1512 and use it again (Bug#8435).
ea6c7ae6
PE
1513 * lisp.h (doprnt): Remove.
1514 * Makefile.in (base_obj): Remove doprnt.o.
1515 * deps.mk (doprnt.o): Remove.
1516
5fdb398c
PE
1517 error: Print 32- and 64-bit integers portably (Bug#8435).
1518 Without this change, on typical 64-bit hosts error ("...%d...", N)
1519 was used to print both 32- and 64-bit integers N, which relied on
1520 undefined behavior.
1521 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1522 New macro.
1523 * lisp.h (error, verror): Mark as printf-like functions.
1524 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1525 Report overflow in size calculations when allocating printf buffer.
1526 Do not truncate output string at its first null byte.
1527 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1528 Truncate the output at a character boundary, since vsnprintf does not
1529 do that.
1530 * charset.c (check_iso_charset_parameter): Convert internal
1531 character to string before calling 'error', since %c now has the
1532 printf meaning.
1533 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1534 overflow when computing char to be passed to 'error'. Do not
1535 pass Lisp_Object to 'error'; pass the integer instead.
1536 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1537 formatted with plain %d.
1538
b189fa66
PE
1539 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1540
bff87ef0
PE
1541 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1542
7e2cac20
PE
1543 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1544
ce4d90b5
PE
1545 * xterm.c (x_catch_errors): Remove duplicate declaration.
1546
266c9547
PE
1547 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1548
79c49ad2
PE
1549 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1550
368f4090
JM
15512011-04-10 Jim Meyering <meyering@redhat.com>
1552
1553 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1554 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1555 return ssize_t not "int", and use size_t as the buffer length.
1556 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1557 * gnutls.h: Update declarations.
1558 * process.c (read_process_output): Use ssize_t, to match.
1559 (send_process): Likewise.
1560
a32d4040
CY
15612011-04-09 Chong Yidong <cyd@stupidchicken.com>
1562
1563 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1564
8546720e 15652011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1566
8546720e
GM
1567 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1568 unsigned char, to match FcChar8 type definition.
aac0c6e3 1569
8546720e
GM
1570 * xterm.c (handle_one_xevent):
1571 * xmenu.c (create_and_show_popup_menu):
1572 * xselect.c (x_decline_selection_request)
1573 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1574
0a2f5c1a 15752011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1576
1577 Fix some uses of `int' instead of EMACS_INT.
1578 * search.c (string_match_1, fast_string_match)
1579 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1580 (scan_buffer, find_next_newline_no_quit)
1581 (find_before_next_newline, search_command, Freplace_match)
1582 (Fmatch_data): Make some `int' variables be EMACS_INT.
1583
1584 * xdisp.c (display_count_lines): 3rd argument and return value now
1585 EMACS_INT. All callers changed.
1586 (pint2hrstr): Last argument is now EMACS_INT.
1587
1588 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1589 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1590 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1591 (decode_coding_utf_16, decode_coding_emacs_mule)
1592 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1593 (decode_coding_ccl, decode_coding_charset)
1594 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1595 (decode_coding_iso_2022, decode_coding_emacs_mule)
1596 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1597 <char_offset, last_offset>: Declare EMACS_INT.
1598 (encode_coding_utf_8, encode_coding_utf_16)
1599 (encode_coding_emacs_mule, encode_invocation_designation)
1600 (encode_designation_at_bol, encode_coding_iso_2022)
1601 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1602 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1603 Declare EMACS_INT.
1604 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1605 (encode_invocation_designation): Last argument P_NCHARS is now
1606 EMACS_INT.
1607 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1608 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1609
1610 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1611 All users changed.
1612
1613 * ccl.c (Fccl_execute_on_string): Declare some variables
1614 EMACS_INT.
1615
8546720e 16162011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1617
1618 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1619
4e19a977
CS
16202011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1621
1622 * process.c (Fformat_network_address): Doc fix.
1623
87302331
R
16242011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1625
1626 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1627
cbb59342
CY
16282011-04-08 Chong Yidong <cyd@stupidchicken.com>
1629
1630 * keyboard.c (read_char): Call Lisp function help-form-show,
1631 instead of using internal_with_output_to_temp_buffer.
1632 (Qhelp_form_show): New var.
e0d38eeb 1633 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1634
1635 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1636
1637 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1638
e67a13ab
CY
16392011-04-06 Chong Yidong <cyd@stupidchicken.com>
1640
1641 * process.c (Flist_processes): Removed to Lisp.
1642 (list_processes_1): Deleted.
1643
973f782d
EZ
16442011-04-06 Eli Zaretskii <eliz@gnu.org>
1645
7c106b1e
EZ
1646 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1647
973f782d
EZ
1648 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1649
41cf7d1a 16502011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1651
ca23cc88
PE
1652 Fix more problems found by GCC 4.6.0's static checks.
1653
f390e2d5
PE
1654 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1655
42eea0d0
PE
1656 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1657
b69769da 1658 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1659
f9541e84
PE
1660 * xdisp.c (vmessage): Mark as a printf-like function.
1661
13841b55
PE
1662 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1663
c136c10f
PE
1664 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1665
5e2d4a30
PE
1666 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1667 printf-like functions.
1668 (tiff_load): Add casts to remove these marks before passing them
1669 to system-supplied API.
1670
583f48b9
PE
1671 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1672
b25d760e
PE
1673 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1674 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1675 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1676 directly, rather than having caller test rule sign. This avoids
1677 some unnecessary tests.
1678 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1679 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1680 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1681
bc7b6697 1682 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1683 (xfont_open): Avoid unnecessary tests.
bc7b6697 1684
27ccc379
PE
1685 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1686
dcd5c89a
PE
1687 * composite.h, composite.c (composition_gstring_put_cache):
1688 Use EMACS_INT, not int, for length.
1689
b13a45c6
PE
1690 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1691 breaking out part of COMPOSITION_DECODE_RULE.
1692 (COMPOSITION_DECODE_RULE): Use it.
1693 * composite.c (get_composition_id): Remove unused local vars,
1694 by using the new macro.
1695
1e792e4d
PE
1696 * textprop.c (set_text_properties_1): Change while to do-while,
1697 since the condition is always true at first.
1698
dc6c6455 1699 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1700 (interval_deletion_adjustment): Return unsigned value.
1701 All uses changed.
dc6c6455 1702
aba7731a
PE
1703 * process.c (list_processes_1, create_pty, read_process_output):
1704 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1705 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1706 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1707 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1708 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1709
fdfc4bf3
PE
1710 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1711
fca8fe46 1712 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1713 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1714
06a0259a 1715 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1716 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1717 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1718
e7b9e80f
PE
1719 * print.c (print_error_message): Avoid int overflow.
1720
56201685
PE
1721 * font.c (font_list_entities): Redo for clarity,
1722 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1723
78834453 1724 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1725 (font_score): Avoid potential overflow in diff calculation.
78834453 1726
0bc0b309 1727 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1728 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1729
e610eaca
PE
1730 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1731
b895abce
PE
1732 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1733 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1734 can always succeed if overflow has undefined behavior.
1735
1f1d9321 1736 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1737 (wordify): Omit three unnecessary tests.
1f1d9321 1738
c59478bc
PE
1739 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1740 All callers changed. This avoids the need for an unused var.
1741
79b73827
PE
1742 * casefiddle.c (casify_region): Remove var that is set but not used.
1743
a4db5dfe
PE
1744 * dired.c (file_name_completion): Remove var that is set but not used.
1745
43aae36e
PE
1746 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1747
2a47c44d 1748 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1749 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1750
a37c69bf
PE
1751 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1752 Check for integer overflow on size calculations.
1753
328ab8e7
PE
1754 * buffer.c (Fprevious_overlay_change): Remove var that is set
1755 but not used.
1756
e5a2a5cb
PE
1757 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1758 Remove vars that are set but not used.
8d84a6eb 1759 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1760 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1761
a60e5f68
PE
1762 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1763
f661cb61 1764 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1765 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1766
f0397f5a
PE
1767 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1768 that are set but not used.
1769
8664db06 1770 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1771 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1772
6abdaa4a
PE
1773 * xselect.c (x_get_local_selection, x_handle_property_notify):
1774 Remove vars that are set but not used.
1775
0ce7538d 1776 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1777 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1778
9ae848fc
PE
1779 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1780 Remove var that is set but not used.
0b918413
PE
1781 (scroll_bar_windows_size): Now size_t, not int.
1782 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1783 Check for overflow.
9ae848fc 1784
a5a62657
PE
1785 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1786 (map_tty_color) [!defined MSDOS]: Likewise.
1787
5c5cdd39
PE
1788 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1789
66ebf983
PE
1790 * coding.c: Remove vars that are set but not used.
1791 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1792 All callers changed.
1793 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1794 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1795 (decode_coding_charset): Remove vars that are set but not used.
1796
1be4d761
PE
1797 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1798 that is set but not used.
1799
47553fa8
PE
1800 * print.c (print_object): Remove var that is set but not used.
1801
1f7196bf 1802 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1803 The gnulib version avoids calling malloc in the usual case,
1804 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1805 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1806 * filelock.c (current_lock_owner): Likewise.
1807 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1808 * sysdep.c: Include allocator.h, careadlinkat.h.
1809 (emacs_no_realloc_allocator): New static constant.
1810 (emacs_readlink): New function.
fdb61804
PE
1811 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1812 ../lib/careadlinkat.h.
d1fdcab7 1813
f84c17c7
SM
18142011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1815
1816 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1817 first non-nil return value).
1818
ef3862ad
JD
18192011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1820
1821 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1822 if not defined (Bug#8403).
1823
376a7006
JB
18242011-04-02 Juanma Barranquero <lekktu@gmail.com>
1825
1826 * xdisp.c (display_count_lines): Remove parameter `start',
1827 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1828 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1829 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1830 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1831 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1832 and thereabouts. All callers changed.
1833 (get_per_char_metric): Remove parameter `f', unused since
1834 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1835
6ca3801d
JM
18362011-04-02 Jim Meyering <meyering@redhat.com>
1837
1838 do not dereference NULL upon failed strdup
1839 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1840 (ns_get_family): Likewise.
1841
d8e2b5ba
JB
18422011-04-02 Juanma Barranquero <lekktu@gmail.com>
1843
1844 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1845
8c74fcbd
JD
18462011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1847
1848 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1849 later (Bug#8403).
1850
7200d79c
SM
18512011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1852
03408648 1853 Add lexical binding.
7200d79c 1854
03408648
SM
1855 * window.c (Ftemp_output_buffer_show): New fun.
1856 (Fsave_window_excursion):
1857 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1858
1859 * lread.c (lisp_file_lexically_bound_p): New function.
1860 (Fload): Bind Qlexical_binding.
1861 (readevalloop): Remove `evalfun' arg.
1862 Bind Qinternal_interpreter_environment.
1863 (Feval_buffer): Bind Qlexical_binding.
1864 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1865 Mark as dynamic.
1866 (syms_of_lread): Declare `lexical-binding'.
1867
1868 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1869
1870 * keyboard.c (eval_dyn): New fun.
1871 (menu_item_eval_property): Use it.
ca105506
SM
1872
1873 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1874
03408648
SM
1875 * fns.c (concat, mapcar1): Accept byte-code-functions.
1876
1877 * eval.c (Fsetq): Handle lexical vars.
1878 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1879 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1880 (FletX, Flet): Obey lexical binding.
1881 (Fcommandp): Handle closures.
1882 (Feval): New `lexical' arg.
1883 (eval_sub): New function extracted from Feval. Use it almost
1884 everywhere where Feval was used. Look up vars in lexical env.
1885 Handle closures.
1886 (Ffunctionp): Move from subr.el.
1887 (Ffuncall): Handle closures.
1888 (apply_lambda): Remove `eval_flags'.
1889 (funcall_lambda): Handle closures and new byte-code-functions.
1890 (Fspecial_variable_p): New function.
1891 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1892 but without exporting it to Lisp.
23aba0ea 1893
23aba0ea 1894 * doc.c (Fdocumentation, store_function_docstring):
03408648 1895 * data.c (Finteractive_form): Handle closures.
23aba0ea 1896
03408648
SM
1897 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1898 interactive spec.
ba83908c 1899
03408648
SM
1900 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1901 byte-codes.
1902 (exec_byte_code): New function extracted from Fbyte_code to handle new
1903 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1904
03408648 1905 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1906
03408648 1907 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1908
e2abce01
JB
19092011-03-31 Juanma Barranquero <lekktu@gmail.com>
1910
1911 * xdisp.c (redisplay_internal): Fix prototype.
1912
63696a73 19132011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1914
63696a73
EZ
1915 * xdisp.c (SCROLL_LIMIT): New macro.
1916 (try_scrolling): Use it when setting scroll_limit. Limit
1917 scrolling to 100 screen lines.
1918 (redisplay_window): Even when falling back on "recentering",
1919 position point in the window according to scroll-conservatively,
1920 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1921
1922 (try_scrolling): When point is above the window, allow searching
1923 as far as scroll_max, or one screenful, to compute vertical
1924 distance from PT to the scroll margin position. This prevents
1925 try_scrolling from unnecessarily failing when
1926 scroll-conservatively is set to a value slightly larger than the
1927 window height. Clean up the case of PT below the margin at bottom
1928 of window: scroll_max can no longer be INT_MAX. When aggressive
1929 scrolling is in use, don't let point enter the opposite scroll
1930 margin as result of the scroll.
1931 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1932 threshold of 100 lines for never-recentering scrolling.
1933
e4cc2dfc
JB
19342011-03-31 Juanma Barranquero <lekktu@gmail.com>
1935
1936 * dispextern.h (move_it_by_lines):
1937 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1938 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1939 (message_log_check_duplicate): Remove parameters `prev_bol' and
1940 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1941 (redisplay_internal): Remove parameter `preserve_echo_area',
1942 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1943
1944 * indent.c (Fvertical_motion):
1945 * window.c (window_scroll_pixel_based, Frecenter):
1946 Don't pass `need_y_p' to `move_it_by_lines'.
1947
1c470562
SM
19482011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1949
44f230aa
SM
1950 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1951 steal a few bits to be more compact.
1952 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1953 Remove unneeded casts.
1954
1c470562
SM
1955 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1956
888adce9
ZK
19572011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1958
1959 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1960 binding" message (bug#7967).
1961
f838ed7b
PE
19622011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1963
77861b95
PE
1964 Fix more problems found by GCC 4.6.0's static checks.
1965
de6dbc14
PE
1966 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1967 Remove unused local var.
1968
f838ed7b
PE
1969 * editfns.c (Fmessage_box): Remove unused local var.
1970
792c7b2b
PE
1971 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1972 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1973 Omit unused local vars.
c499e557 1974 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1975 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1976 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1977 Omit unused local var.
1978
ba0165e1
PE
1979 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1980 Don't assume string length fits in int.
32ad8845 1981 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1982 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1983
3c59b4c9
PE
1984 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1985 instead of alloca (Bug#8344).
1986
a3eed478 1987 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1988 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1989
eb4d412d
PE
1990 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1991
1658b401
PE
1992 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1993 concerns.
1994
1995 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1996
1997 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1998
9a2c6e05
PE
1999 * keyboard.c (syms_of_keyboard): Use the same style as later
2000 in this function when indexing through an array. This also
2001 works around GCC bug 48267.
2002
03d0a109
PE
2003 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2004
44f730c8
PE
2005 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2006
fe75f926
PE
2007 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2008 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2009
ffa8c828
PE
2010 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2011 This avoids undefined behavior on integer overflow, and is a bit
2012 more convenient anyway since it is compared to a size_t variable.
2013
c5101a77
PE
2014 Variadic C functions now count arguments with size_t, not int.
2015 This avoids an unnecessary limitation on 64-bit machines, which
2016 caused (substring ...) to crash on large vectors (Bug#8344).
2017 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2018 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2019 All variadic functions and their callers changed accordingly.
c5101a77
PE
2020 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2021 * data.c (arith_driver, float_arith_driver): Likewise.
2022 * editfns.c (general_insert_function): Likewise.
2023 * eval.c (struct backtrace.nargs, interactive_p)
2024 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2025 (funcall_lambda, mark_backtrace): Likewise.
2026 * fns.c (concat): Likewise.
2027 * frame.c (x_set_frame_parameters): Likewise.
2028 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2029 0 if not found, not -1. All callers changed.
2030
dd3f25f7
PE
2031 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2032 (stack_copy_size): Now size_t, not int.
2033 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2034
461c2ab9
JB
20352011-03-28 Juanma Barranquero <lekktu@gmail.com>
2036
2037 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2038 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2039 All callers changed.
2040
2041 * lisp.h (multibyte_char_to_unibyte):
2042 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2043 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2044 * character.h (CHAR_TO_BYTE8):
2045 * cmds.c (internal_self_insert):
2046 * editfns.c (general_insert_function):
2047 * keymap.c (push_key_description):
2048 * search.c (Freplace_match):
2049 * xdisp.c (message_dolog, set_message_1): All callers changed.
2050
f6d62986
SM
20512011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2052
2053 * keyboard.c (safe_run_hook_funcall): New function.
2054 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2055 don't set the hook to nil, but remove the offending function instead.
2056 (Qcommand_hook_internal): Remove, unused.
2057 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2058 Vcommand_hook_internal.
2059
2060 * eval.c (enum run_hooks_condition): Remove.
2061 (funcall_nil, funcall_not): New functions.
2062 (run_hook_with_args): Call each function through a `funcall' argument.
2063 Remove `cond' argument, now redundant.
2064 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2065 (Frun_hook_with_args_until_failure): Adjust accordingly.
2066 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2067
1db5b1ad
JB
20682011-03-28 Juanma Barranquero <lekktu@gmail.com>
2069
2070 * dispextern.h (string_buffer_position): Remove declaration.
2071
2072 * print.c (strout): Remove parameter `multibyte', unused since
2073 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2074
2075 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2076 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2077 All callers changed.
2078
2079 * w32.c (_wsa_errlist): Use braces for struct initializers.
2080
2081 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2082 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2083 All callers changed.
2084 (string_buffer_position): Likewise. Also, make static (it's never
2085 used outside xdisp.c).
2086 (cursor_row_p): Remove parameter `w', unused since
2087 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2088 (decode_mode_spec): Remove parameter `precision', introduced during
2089 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2090 All callers changed.
2091
5ffb62aa
JD
20922011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2093
2094 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2095
461c2ab9 20962011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2097
2098 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2099 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2100 (ns_update_auto_hide_menu_bar): New functions.
2101 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2102 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2103 ns_constrain_all_frames.
2104 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2105 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2106
5c380ffb
JD
21072011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2108
2109 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2110
9af30bdf
GM
21112011-03-27 Glenn Morris <rgm@gnu.org>
2112
2113 * syssignal.h: Replace RETSIGTYPE with void.
2114 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2115 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2116 Replace SIGTYPE with void everywhere.
2117 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2118 * s/template.h (SIGTYPE): Remove commented out definition.
2119
e2abce01
JB
21202011-03-26 Eli Zaretskii <eliz@gnu.org>
2121
2122 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2123 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2124
f868cd8a
JB
21252011-03-26 Juanma Barranquero <lekktu@gmail.com>
2126
59eb0929
JB
2127 * w32.c (read_unc_volume): Use parameter `henum', instead of
2128 global variable `wget_enum_handle'.
2129
2130 * keymap.c (describe_vector): Remove parameters `indices' and
2131 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2132 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2133
f868cd8a
JB
2134 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2135
2136 * keyboard.c (timer_check): Remove parameter `do_it_now',
2137 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2138 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2139 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2140
2141 * keyboard.c (read_char):
2142 * w32menu.c (w32_menu_display_help):
2143 * xmenu.c (show_help_event, menu_help_callback):
2144 Adjust calls to `show_help_echo'.
2145
2146 * gtkutil.c (xg_maybe_add_timer):
2147 * keyboard.c (readable_events):
2148 * process.c (wait_reading_process_output):
2149 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2150
2151 * insdel.c (adjust_markers_gap_motion):
2152 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2153 (gap_left, gap_right): Don't call it.
2154
2ecf6fdb
CY
21552011-03-25 Chong Yidong <cyd@stupidchicken.com>
2156
2157 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2158 incurred during fontification.
2159
6b1f9ba4
JB
21602011-03-25 Juanma Barranquero <lekktu@gmail.com>
2161
2162 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2163 (DEFVAR_PER_BUFFER): Don't pass it.
2164
2165 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2166 (scrolling_window): Don't pass it.
2167
0f4a96b5
JB
21682011-03-25 Juanma Barranquero <lekktu@gmail.com>
2169
2170 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2171
2172 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2173 and `suffix'.
2174 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2175 of variables specific to SELinux and computation of `encoded_absname'.
2176
2177 * image.c (XPutPixel): Remove unused variable `height'.
2178
2179 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2180
2181 * unexw32.c (get_section_info): Remove unused variable `section'.
2182
2183 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2184 (system_process_attributes): Remove unused variable `sess'.
2185 (sys_read): Remove unused variable `err'.
2186
2187 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2188 (w32_wnd_proc): Remove unused variable `isdead'.
2189 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2190 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2191 (x_create_tip_frame): Remove unused variable `tem'.
2192
2193 * w32inevt.c (w32_console_read_socket):
2194 Remove unused variable `no_events'.
2195
2196 * w32term.c (x_draw_composite_glyph_string_foreground):
2197 Remove unused variable `width'.
2198
1149507c
JB
21992011-03-24 Juanma Barranquero <lekktu@gmail.com>
2200
2201 * w32term.c (x_set_glyph_string_clipping):
2202 Don't pass uninitialized region to CombineRgn.
2203
9c88f339
JB
22042011-03-23 Juanma Barranquero <lekktu@gmail.com>
2205
2206 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2207 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2208 (Fx_close_connection): Remove unused variable `i'.
2209
2210 * w32font.c (w32font_draw): Return number of glyphs.
2211 (w32font_open_internal): Remove unused variable `i'.
2212 (w32font_driver): Add missing initializer.
2213
2214 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2215 (fill_in_menu): Remove unused variable `items_added'.
2216
2217 * w32term.c (last_mouse_press_frame): Remove static global variable.
2218 (w32_clip_to_row): Remove unused variable `f'.
2219 (x_delete_terminal): Remove unused variable `i'.
2220
2221 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2222 (NOTHING): Remove unused static global variable.
2223 (uniscribe_check_otf): Remove unused variable `table'.
2224 (uniscribe_font_driver): Add missing initializers.
2225
dee091a3
JD
22262011-03-23 Julien Danjou <julien@danjou.info>
2227
2228 * term.c (Fsuspend_tty, Fresume_tty):
2229 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2230 * window.c (temp_output_buffer_show):
2231 * insdel.c (signal_before_change):
2232 * frame.c (Fhandle_switch_frame):
2233 * fileio.c (Fdo_auto_save):
2234 * emacs.c (Fkill_emacs):
2235 * editfns.c (save_excursion_restore):
2236 * cmds.c (internal_self_insert):
2237 * callint.c (Fcall_interactively):
2238 * buffer.c (Fkill_all_local_variables):
2239 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2240 Use Frun_hooks.
0f4a96b5 2241 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2242 unconditionnaly since it does the check itself.
2243
2c520ab5 22442011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2245
c9c49752
PE
2246 Fix more problems found by GCC 4.5.2's static checks.
2247
8abc3f12
PE
2248 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2249 the first time through the loop, since we know p0 < p1 then.
2250 This also avoids a gcc -Wstrict-overflow warning.
2251
a2d26660
PE
2252 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2253 leading to a memory leak, possible in functions like
2254 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2255 of objects (Bug#8318).
a2d26660 2256
916c72e9
PE
2257 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2258 that could (at least in theory) be that large.
2259
19ab8a18
PE
2260 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2261 This is less likely to overflow, and avoids undefined behavior if
2262 overflow does occur. All callers changed. Use strtoul to scan
2263 for the unsigned long integer.
b7cbbd6f
PE
2264 (pint2hrstr): Simplify and tune code slightly.
2265 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2266
f0641eff
PE
2267 * scroll.c (do_scrolling): Work around GCC bug 48228.
2268 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2269
7f650bb9
PE
2270 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2271 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2272 (validate_x_resource_name): Simplify count usage.
2273 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2274
37dd57d1
PE
2275 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2276 fail (Bug#8306).
81e56e61 2277
699979fc 2278 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2279
401bf9b4
PE
2280 * process.c (Fmake_network_process): Use socklen_t, not int,
2281 where POSIX says socklen_t is required in portable programs.
2282 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2283 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2284 (Fmake_network_process, server_accept_connection):
2285 (wait_reading_process_output, read_process_output):
2286 Likewise.
2287
b93aacde
PE
2288 * process.c: Rename or move locals to avoid shadowing.
2289 (list_processes_1, Fmake_network_process):
2290 (read_process_output_error_handler, exec_sentinel_error_handler):
2291 Rename or move locals.
4dc343ee 2292 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2293 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2294 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2295 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2296 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2297
af8a867c 2298 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2299 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2300 Include tparam.h instead, since it declares them.
af8a867c
PE
2301 * cm.h (PC): Remove extern decl; tparam.h now does this.
2302 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2303 * terminfo.c: Include tparam.h, to check interfaces.
2304 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2305 (tparam): Adjust signature to match interface in tparam.h;
2306 this removes some undefined behavior. Check that outstring and len
2307 are zero, which they always are with Emacs.
2308 * tparam.h (PC, BC, UP): New extern decls.
2309
0248044d 2310 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2311 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2312
8ff096c1 2313 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2314 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2315 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2316 (ftfont_list): Remove unused local.
49eaafba
PE
2317 (get_adstyle_property, ftfont_pattern_entity):
2318 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2319 Rename locals to avoid shadowing.
8ff096c1 2320
e2be39f6
PE
2321 * xfont.c (xfont_list_family): Mark var as initialized.
2322
c9735e30
PE
2323 * xml.c (make_dom): Now static.
2324
8f5201ae
PE
2325 * composite.c (composition_compute_stop_pos): Rename local to
2326 avoid shadowing.
b246f932
PE
2327 (composition_reseat_it): Remove unused locals.
2328 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2329 (composition_update_it): Mark var as initialized.
11b61122
PE
2330 (find_automatic_composition): Mark vars as initialized,
2331 with a FIXME (Bug#8290).
8f5201ae 2332
760fbc2c
PE
2333 character.h: Rename locals to avoid shadowing.
2334 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2335 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2336 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2337 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2338 to avoid shadowing.
2339
ff08eb85
PE
2340 * textprop.c (property_change_between_p): Remove; unused.
2341
fc7bf025
PE
2342 * intervals.c (interval_start_pos): Now static.
2343
235d7abc
PE
2344 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2345
44f230aa
SM
2346 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2347 Rename locals to avoid shadowing.
3e7d6594 2348
50060332
PE
2349 * sound.c (wav_play, au_play, Fplay_sound_internal):
2350 Fix pointer signedness.
d01f234b 2351 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2352 (wav_play): Initialize a variable to 0, to prevent undefined
2353 behavior (Bug#8278).
50060332 2354
c4fc4e30
PE
2355 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2356
918436ed
PE
2357 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2358
c939f91b
PE
2359 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2360 clobbering (Bug#8298).
b9c7f648
PE
2361 * sysdep.c (sys_subshell): Likewise.
2362 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2363
6bd8c144
PE
2364 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2365 This should get cleaned up, so that child_setup has the
2366 same signature on all platforms.
2367
7710357c 2368 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2369 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2370
c59da222
CY
23712011-03-22 Chong Yidong <cyd@stupidchicken.com>
2372
2373 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2374 not to be necessary, and produces flickering.
2375
66b87493
GM
23762011-03-20 Glenn Morris <rgm@gnu.org>
2377
2378 * config.in: Remove file.
2379
45b6f6d5
JB
23802011-03-20 Juanma Barranquero <lekktu@gmail.com>
2381
2382 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2383 are now in src/globals.h.
2384 (syms_of_minibuf): Remove spurious & from previous change.
2385
3ec03f7e
LL
23862011-03-20 Leo <sdl.web@gmail.com>
2387
2388 * minibuf.c (completing-read-function): New variable.
2389 (completing-read-default): Rename from completing-read.
2390 (completing-read): Call completing-read-function.
2391
b14e3e21
CY
23922011-03-19 Juanma Barranquero <lekktu@gmail.com>
2393
2394 * xfaces.c (Fx_load_color_file):
2395 Read color file from absolute filename (bug#8250).
2396
f2b726e6
JB
23972011-03-19 Juanma Barranquero <lekktu@gmail.com>
2398
2399 * makefile.w32-in: Update dependencies.
2400
09f6ff02
EZ
24012011-03-17 Eli Zaretskii <eliz@gnu.org>
2402
2403 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2404
29a6015a
PE
24052011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2406
a3a6c54e
PE
2407 Fix more problems found by GCC 4.5.2's static checks.
2408
b766f867
PE
2409 * process.c (make_serial_process_unwind, send_process_trap):
2410 (sigchld_handler): Now static.
2411
be02381c
PE
2412 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2413 That way, the code declares only the vars that it needs.
2414 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2415 * s/cygwin.h (PTY_ITERATION): Likewise.
2416 * s/darwin.h (PTY_ITERATION): Likewise.
2417 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2418
57048744
PE
2419 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2420 * process.c (allocate_pty): Don't declare stb unless it's needed.
2421
7914961c 2422 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2423 (CONSTANTLIM): Remove; unused.
2424 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2425 Define only if needed.
7914961c 2426
b3967b18
PE
2427 * unexelf.c (unexec): Name an expression,
2428 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2429 Use a different way to cause a compilation error if anyone uses
2430 n rather than nn, a way that does not involve shadowing.
73366a00 2431 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2432
29a6015a
PE
2433 * deps.mk (unexalpha.o): Remove; unused.
2434
43cfc33e 2435 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2436 * unexec.h: New file.
ce701a33
PE
2437 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2438 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2439 Depend on unexec.h.
2440 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2441 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2442 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2443 Change as necessary to match prototype in unexec.h.
ce701a33 2444
01f44d5a
PE
2445 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2446 shadowing.
4f63c6bb 2447 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2448
a6670b0b
PE
2449 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2450 Rename locals to avoid shadowing.
2451
cef2010d 2452 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2453 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2454
d4d7173a
PE
2455 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2456
f08b802a
PE
2457 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2458 warning when compiling print.c.
2459
3ddb0639
PE
2460 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2461 instead of using an uninitialized var.
5ad03b97 2462 (font_sort_entities): Mark var as initialized.
3ddb0639 2463
170a2692
PE
2464 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2465
e663c700
PE
2466 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2467 pointers to constants.
89bc529a 2468 (font_parse_fcname): Remove unused vars.
7b81e2d0 2469 (font_delete_unmatched): Now static.
ea838e10 2470 (font_get_spec): Remove; unused.
13a547c6
PE
2471 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2472 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2473 Rename or move locals to avoid shadowing.
e663c700 2474
2a80c887 2475 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2476 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2477
1384fa33 2478 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2479 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2480
8b2c52e9
PE
2481 * alloc.c (mark_backtrace): Move decl from here ...
2482 * lisp.h: ... to here, so that it can be checked.
2483
475545b5 2484 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2485 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2486 (lisp_indirect_variable): Name an expression,
2487 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2488 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2489
b1349114 2490 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2491 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2492 Use const pointer when appropriate.
b1349114 2493
a2928364
PE
2494 * lisp.h (get_system_name, get_operating_system_release):
2495 Move decls here, to check interfaces.
2496 * process.c (get_operating_system_release): Move decl to lisp.h.
2497 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2498 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2499 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2500 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2501 (Fformat_time_string, Fencode_time, Finsert_char):
2502 (Ftranslate_region_internal, Fformat):
2503 Rename or remove local vars to avoid shadowing.
9710023e 2504 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2505
a415e694
PE
2506 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2507 avoid shadowing.
2508
8ef4622d
PE
2509 * lisp.h (eassert): Check that the argument compiles, even if
2510 ENABLE_CHECKING is not defined.
2511
946f9a5b
PE
2512 * data.c (Findirect_variable): Name an expression, to avoid
2513 gcc -Wbad-function-cast warning.
112396d6 2514 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2515 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2516 (Fmake_variable_buffer_local, Fmake_local_variable):
2517 Mark variables as initialized.
52746918 2518 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2519
e5aab7e7 2520 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2521 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2522 Rename locals to avoid shadowing.
dff45157
PE
2523 (mark_stack): Move local variables into the #ifdef region where
2524 they're used.
7bc26fdb
PE
2525 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2526 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2527 needed otherwise.
2528 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2529 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2530 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2531
e5aab7e7
PE
2532 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2533 avoids undefined behavior in theory.
2534
4da60324
PE
2535 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2536
88043301
PE
2537 Use functions, not macros, for up- and down-casing (Bug#8254).
2538 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2539 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2540 to use the following functions instead of these macros.
2541 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2542 EMACS_INT, since callers assume the returned value fits in int.
2543 (upcase1): Likewise, for UPCASE_TABLE.
2544 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2545 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2546 the race-condition problem in the old DOWNCASE.
88043301 2547
19ed5445
PE
2548 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2549 Rename locals to avoid shadowing.
2550 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2551 (regex_compile, re_search_2, re_match_2_internal):
2552 Remove unused local vars.
952db0d7
PE
2553 (FREE_VAR): Rewrite so as not to use empty "else",
2554 which gcc can warn about.
da053e48 2555 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2556 (RETALLOC_IF): Define only if needed.
2557 (WORDCHAR_P): Likewise. This one is never needed, but is used
2558 only in a comment talking about a compiler bug, so put inside
2559 the #if 0 of that comment.
2560 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2561 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2562 Remove; unused.
19ed5445 2563
1f3561e4 2564 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2565 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2566 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2567
ded6f8f7
PE
2568 * search.c (simple_search): Remove unused var.
2569
dbd37a95
PE
2570 * dired.c (compile_pattern): Move decl from here ...
2571 * lisp.h: ... to here, so that it can be checked.
2572 (struct re_registers): New forward decl.
2573
7e47afad
PE
2574 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2575
85f24f61
PE
2576 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2577 All uses changed.
2578 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2579 Rename locals to avoid shadowing.
5671df8f 2580 (Fvertical_motion): Mark locals as initialized.
85f24f61 2581
181aa2be 2582 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2583 (casify_region): Mark local as initialized.
181aa2be 2584
930d429c
PE
2585 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2586
7082eac6
PE
2587 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2588 New macros, so that the caller can use some names other than
2589 gcpro1, gcpro2, etc.
2590 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2591 of the new macros.
2592 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2593 argument, for consistency with GCPRO2_VAR, etc: it is now the
2594 prefix of the variable, not the variable itself. All uses
2595 changed.
38b2c076
PE
2596 * dired.c (directory_files_internal, file_name_completion):
2597 Rename locals to avoid shadowing.
2598
15206ed9
PE
2599 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2600 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2601 dired.c's scmp function, had undefined behavior.
2602 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2603 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2604 * buffer.h: ... to here, because these macros use current_buffer,
2605 and the new implementation with inline functions needs to have
2606 current_buffer in scope now, rather than later when the macros
2607 are used.
2608 (downcase, upcase1): New static inline functions.
2609 (DOWNCASE, UPCASE1): Reimplement using these functions.
2610 This avoids undefined behavior in expressions like
2611 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2612 from race conditions in accessing the global variables
2613 case_temp1 and case_temp2.
2614 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2615 * lisp.h (case_temp1, case_temp2): Remove their decls.
2616 * character.h (ASCII_CHAR_P): Move from here ...
2617 * lisp.h: ... to here, so that the inline functions mentioned
2618 above can use them.
2619
4a6bea26
PE
2620 * dired.c (directory_files_internal_unwind): Now static.
2621
f14b7e14
PE
2622 * fileio.c (file_name_as_directory, directory_file_name):
2623 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2624 Now static.
2893f146
PE
2625 (file_name_as_directory): Use const pointers when appropriate.
2626 (Fexpand_file_name): Likewise. In particular, newdir might
2627 point at constant storage, so make it a const pointer.
fd4ead52 2628 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2629 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2630 signedness issues.
f839df0c
PE
2631 (Fset_file_times, Finsert_file_contents, auto_save_error):
2632 Rename locals to avoid shadowing.
f14b7e14 2633
5716756e 2634 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2635 (Ftry_completion, Fall_completions): Rename or remove locals
2636 to avoid shadowing.
5716756e 2637
b4c3046a
PE
2638 * marker.c (bytepos_to_charpos): Remove; unused.
2639
b45db522
PE
2640 * lisp.h (verify_bytepos, count_markers): New decls,
2641 so that gcc does not warn that these functions aren't declared.
2642
85876d07
PE
2643 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2644 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2645 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2646 (copy_text): Remove unused local var.
85876d07 2647
03d78a21 2648 * filelock.c (within_one_second): Now static.
b3dd38ab 2649 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2650
5df8f01b
PE
2651 * buffer.c (fix_overlays_before): Mark locals as initialized.
2652 (fix_start_end_in_overlays): Likewise. This function should be
2653 simplified by using pointers-to-pointers, but that's a different
2654 matter.
b1d876f1 2655 (switch_to_buffer_1): Now static.
8f54f30a
PE
2656 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2657 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2658
a70072c9 2659 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2660 Fix pointer signedness issue.
edced198
PE
2661 (sys_subshell): Mark local as volatile if checking for lint,
2662 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2663 (MAXPATHLEN): Define only if needed.
a70072c9 2664
a0977c44
PE
2665 * process.c (serial_open, serial_configure): Move decls from here ...
2666 * systty.h: ... to here, so that they can be checked.
2667
a884fdcc
PE
2668 * fns.c (get_random, seed_random): Move extern decls from here ...
2669 * lisp.h: ... to here, so that they can be checked.
2670
604efe86 2671 * sysdep.c (reset_io): Now static.
b8950c94 2672 (wait_for_termination_signal): Remove; unused.
604efe86 2673
38fc62d9
PE
2674 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2675 (copy_keymap_item, append_key, push_text_char_description):
2676 Now static.
1004a21a 2677 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2678 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2679 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2680 (describe_map_tree):
2681 Rename locals to avoid shadowing.
38fc62d9 2682
2f2650da
PE
2683 * keyboard.c: Declare functions static if they are not used elsewhere.
2684 (echo_char, echo_dash, cmd_error, top_level_2):
2685 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2686 (read_char, kbd_buffer_get_event, make_lispy_position):
2687 (make_lispy_event, make_lispy_movement, apply_modifiers):
2688 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2689 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2690 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2691 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2692 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2693
a053e86c 2694 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2695 (mark_kboards): Move decl here ...
2696 * alloc.c (mark_kboards): ... from here.
a053e86c 2697
4752793e
PE
2698 * lisp.h (force_auto_save_soon): New decl.
2699
74f10ca7 2700 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2701 (DEFINE_DUMMY_FUNCTION): New macro.
2702 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2703 Use it.
c03cd23f
PE
2704 (main): Add casts to avoid warnings
2705 if GCC considers string literals to be constants.
74f10ca7 2706
022e70d4
PE
2707 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2708
59d6fe83
PE
2709 * dbusbind.c: Pointer signedness fixes.
2710 (xd_signature, xd_append_arg, xd_initialize):
2711 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2712 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2713 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2714 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2715
78320123
PE
2716 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2717 if GCC considers string literals to be constants.
49cebcca 2718 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2719
35ac2a97
SM
27202011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2721
fb103ca9
SM
2722 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2723 (print_preprocess, print_object): New macro to fix last change.
2724
35ac2a97
SM
2725 * print.c (print_preprocess): Don't forget font objects.
2726
62973b41
JB
27272011-03-16 Juanma Barranquero <lekktu@gmail.com>
2728
2729 * emacs.c (USAGE3): Doc fixes.
2730
0e48bb22
AS
27312011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2732
2733 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2734 structure.
2735
7684e57b
JB
27362011-03-14 Juanma Barranquero <lekktu@gmail.com>
2737
2738 * lisp.h (VWindow_system, Qfile_name_history):
2739 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2740 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2741 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2742
2743 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2744 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2745
2746 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2747 * w32console.c (detect_input_pending, read_input_pending)
2748 (encode_terminal_code):
2749 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2750 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2751 (w32_system_caret_y, Qfile_name_history):
2752 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2753 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2754 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2755 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2756 * w32proc.c (Qlocal, report_file_error):
2757 * w32term.c (Vwindow_system, updating_frame):
2758 * w32uniscribe.c (initialized, uniscribe_font_driver):
2759 Remove unneeded extern declarations.
2760
2aa46d6c
CY
27612011-03-14 Chong Yidong <cyd@stupidchicken.com>
2762
c96bbc66 2763 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2764
cffc6f3b
CY
27652011-03-13 Chong Yidong <cyd@stupidchicken.com>
2766
2767 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2768 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2769 These macros can no longer be used for assignment.
2770
44f230aa
SM
2771 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2772 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2773 (record_buffer_markers, fetch_buffer_markers): New functions for
2774 recording and fetching special buffer markers.
2775 (set_buffer_internal_1, set_buffer_temp): Use them.
2776
2777 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2778
2779 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2780
2781 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2782 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2783
2784 * xdisp.c (hscroll_window_tree):
2785 (reconsider_clip_changes): Use PT instead of BUF_PT.
2786
d251f04b
EZ
27872011-03-13 Eli Zaretskii <eliz@gnu.org>
2788
2789 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2790 $(EMACS_ROOT)/lib/intprops.h.
2791
f0c77cd1
PE
27922011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2793
3eca4629
PE
2794 Fix more problems found by GCC 4.5.2's static checks.
2795
7c86ee98
PE
2796 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2797 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2798 (xg_free_frame_widgets): Make it clear that a local variable is
2799 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2800 (gdk_window_get_screen): Make it clear that this macro is needed
2801 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2802 (int_gtk_range_get_value): New function, which avoids a diagnostic
2803 from gcc -Wbad-function-cast.
2804 (xg_set_toolkit_scroll_bar_thumb): Use it.
2805 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2806 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2807 (get_utf8_string, xg_get_file_with_chooser):
2808 Rename locals to avoid shadowing.
2809 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2810
41729b81
PE
2811 * xgselect.c (xg_select): Remove unused var.
2812
f0c77cd1
PE
2813 * image.c (four_corners_best): Mark locals as initialized.
2814 (gif_load): Initialize transparent_p to zero (Bug#8238).
2815 Mark another local as initialized.
ec6cf4c6 2816 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2817
ce0ad53d 2818 * image.c (clear_image_cache): Now static.
d5d5a617 2819 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2820 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2821 (x_edge_detection): Remove unnecessary cast that
2822 gcc -Wbad-function-cast diagnoses.
2037898d 2823 (gif_load): Fix pointer signedness.
6ae141d6
PE
2824 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2825 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2826
33383987 28272011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2828
d32df629
PE
2829 Improve quality of tests for time stamp overflow.
2830 For example, without this patch (encode-time 0 0 0 1 1
2831 1152921504606846976) returns the obviously-bogus value (-948597
2832 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2833 reports time overflow. See
2834 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2835 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2836 * editfns.c: Include limits.h and intprops.h.
2837 (TIME_T_MIN, TIME_T_MAX): New macros.
2838 (time_overflow): Move earlier, to before first use.
2839 (hi_time, lo_time): New functions, for an accurate test for
2840 out-of-range times.
2841 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2842 (Fget_internal_run_time): Don't assume time_t fits in int.
2843 (make_time): Use list2 instead of Fcons twice.
2844 (Fdecode_time): More accurate test for out-of-range times.
2845 (check_tm_member): New function.
2846 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2847 (lisp_time_argument): Don't rely on undefined left-shift and
2848 right-shift behavior when checking for time stamp overflow.
8be6f318 2849
fe31d94c
PE
2850 * editfns.c (time_overflow): New function, refactoring common code.
2851 (Fformat_time_string, Fdecode_time, Fencode_time):
2852 (Fcurrent_time_string): Use it.
2853
8be6f318
PE
2854 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2855 * dired.c (make_time): Move to ...
2856 * editfns.c (make_time): ... here.
2857 * systime.h: Note the move.
2858
09d9db2c 28592011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2860
126bc0dc
YM
2861 * fringe.c (update_window_fringes): Remove unused variables.
2862
c47cbdfd
YM
2863 * unexmacosx.c (copy_data_segment): Also copy __got section.
2864 (Bug#8223)
2865
7ac80be9
EZ
28662011-03-12 Eli Zaretskii <eliz@gnu.org>
2867
c96bbc66 2868 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2869 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2870 Constify `char *' arguments and their references according to
2871 prototypes in tparam.h.
2872
ecb0f94d 2873 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2874
7ac80be9
EZ
2875 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2876 Adapt all references accordingly.
2877
2878 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2879
ef1fd07e
TT
28802011-03-11 Tom Tromey <tromey@redhat.com>
2881
2882 * buffer.c (syms_of_buffer): Remove obsolete comment.
2883
7ef4b50c
EZ
28842011-03-11 Eli Zaretskii <eliz@gnu.org>
2885
2886 * termhooks.h (encode_terminal_code): Declare prototype.
2887
2888 * msdos.c (encode_terminal_code): Don't declare prototype.
2889
2890 * term.c (encode_terminal_code): Now external again, used by
2891 w32console.c and msdos.c.
2892
44f230aa
SM
2893 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2894 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2895
4b1ec863 28962011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2897
1714f52b 2898 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2899
4b1ec863
PE
2900 * fringe.c (update_window_fringes): Mark locals as initialized
2901 (Bug#8227).
2902 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2903
524c7aa6
PE
2904 * alloc.c (mark_fringe_data): Move decl from here ...
2905 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2906 to check its interface.
2907 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2908
a5c0af81 2909 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2910 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2911 (fontset_font): Mark local as initialized.
a9a06e0b 2912 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2913
b4716021
PE
2914 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2915
811e9bac 2916 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2917 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2918 (x_own_selection, Fx_disown_selection_internal): Rename locals
2919 to avoid shadowing.
2920 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2921
7e3ab302
PE
2922 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2923 so that the caller can use some name other than gcpro1.
2924 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2925 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2926 (Fx_backspace_delete_keys_p):
2927 Use them to avoid shadowing, and rename vars to avoid shadowing.
2928 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2929 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2930 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2931 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2932 Remove unused locals.
7e3ab302
PE
2933 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2934 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2935 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2936 macros.
f78faa98 2937
e2b13473
PE
2938 * xterm.h (x_mouse_leave): New decl.
2939
77f23912
PE
2940 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2941 Remove unused functions.
cdf4ba58
PE
2942 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2943 (x_calc_absolute_position): Now static.
7411c686 2944 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2945 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2946 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2947 unless they are used.
38d0b34a
PE
2948 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2949 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2950 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2951 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2952 (x_error_catcher, x_connection_closed, x_error_handler):
2953 (x_error_quitter, xembed_send_message, x_iconify_frame):
2954 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2955 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2956 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2957
44f230aa
SM
2958 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2959 Rename or move locals to avoid shadowing.
6b463e58 2960 (tty_defined_color, merge_face_heights): Now static.
5967d051 2961 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2962 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2963 does not deduce is never used uninitialized.
73719eba
PE
2964 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2965 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2966
426994c3 2967 * terminal.c (store_terminal_param): Now static.
5489860b 2968
032f1620 2969 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2970 (set_frame_menubar): Remove unused local.
d4323972 2971 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2972 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2973 since they might point to immutable storage.
281585b0
PE
2974 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2975 since it's unused otherwise.
032f1620 2976
367c19e5 2977 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2978 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2979 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2980 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2981 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2982 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2983 does not deduce are never used uninitialized.
70739cbe 2984
07b48fa9
PE
2985 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2986
8868a238 2987 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2988 * window.c (window_loop, size_window):
2989 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2990
7e5cf297 2991 * window.c (display_buffer): Now static.
d6550a9f
PE
2992 (size_window): Mark variables that gcc -Wuninitialized
2993 does not deduce are never used uninitialized.
a586633d
PE
2994 * window.h (check_all_windows): New decl, to forestall
2995 gcc -Wmissing-prototypes diagnostic.
5b555da1 2996 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2997
f6095868
PE
2998 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2999 shadowing.
3000 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3001 Include <limits.h>.
3002 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3003 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3004 (load_charset_map): Mark variables that gcc -Wuninitialized
3005 does not deduce are never used uninitialized.
53df7c11 3006 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3007
f38b440c
PE
3008 * coding.c (coding_set_source, coding_set_destination):
3009 Use "else { /* comment */ }" rather than "else /* comment */;"
3010 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3011 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3012 a block, when the outer 'i' will do.
3013 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3014 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3015 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3016 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3017 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3018 Rename locals to avoid shadowing.
3019 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3020 * coding.c (emacs_mule_char, encode_invocation_designation):
3021 Now static, since they're not used elsewhere.
413bb2db 3022 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3023 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3024 (decode_coding_emacs_mule): Mark variables that gcc
3025 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3026 (detect_coding_iso_2022): Initialize a local variable that might
3027 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3028 this initialization is needed. (Bug#8211)
5f58e762
PE
3029 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3030 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3031 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3032 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3033 Remove unused macros.
f38b440c 3034
232b38b9 3035 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3036 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3037 * character.c (string_count_byte8): Likewise.
232b38b9 3038
fb90da1b
PE
3039 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3040 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3041
fb93dbc2
PE
3042 * chartab.c (copy_sub_char_table): Now static, since it's not used
3043 elsewhere.
5c156ace
PE
3044 (sub_char_table_ref_and_range, char_table_ref_and_range):
3045 Rename locals to avoid shadowing.
bbcd0949 3046 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3047
7d3b3862 3048 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3049 (BIDI_BOB): Remove unused macro.
7d3b3862 3050
6be7d3da
PE
3051 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3052 deduce are never used uninitialized.
c2ed9c8b 3053 * term.c (encode_terminal_code): Likewise.
6be7d3da 3054
75f8807f 3055 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3056
50938595
PE
3057 * tparam.h: New file.
3058 * term.c, tparam.h: Include it.
3059 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3060 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3061 Move these decls to tparam.h, and make them agree with what
3062 is actually in tparam.c. The previous trick of using incompatible
3063 decls in different modules does not conform to the C standard.
3064 All callers of tparam changed to use tparam's actual API.
3065 * tparam.c (tparam1, tparam, tgoto):
3066 Use const pointers where appropriate.
3067
fbceeba2
PE
3068 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3069 * cm.h (struct cm): Likewise.
3070 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3071 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3072 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3073 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3074 (turn_on_face, init_tty): Likewise.
3075 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3076
7f3f1250
PE
3077 * term.c (term_mouse_position): Rename local to avoid shadowing.
3078
e6ca6543
PE
3079 * alloc.c (mark_ttys): Move decl from here ...
3080 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3081
c40f8d15
AS
30822011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3083
3084 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3085
cfe0661d
JB
30862011-03-09 Juanma Barranquero <lekktu@gmail.com>
3087
3088 * search.c (compile_pattern_1): Remove argument regp, unused since
3089 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3090 (compile_pattern): Don't pass it.
3091
0afb4571
J
30922011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3093
3094 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3095 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3096 for ! HAVE_GTK3.
3097 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3098
3099 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3100
3101 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3102 gdk_window_get_screen, gdk_window_get_geometry,
3103 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3104 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3105 (xg_get_pixbuf_from_pixmap): New function.
3106 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3107 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3108 Call xg_get_pixbuf_from_pixmap instead of
3109 gdk_pixbuf_get_from_drawable.
3110 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3111 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3112 (xg_check_special_colors): Use GtkStyleContext and its functions
3113 for HAVE_GTK3.
3114 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3115 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3116 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3117 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3118 Call gtk_widget_get_preferred_size.
0afb4571
J
3119 (xg_frame_resized): gdk_window_get_geometry only takes 5
3120 parameters.
44f230aa
SM
3121 (xg_win_to_widget, xg_event_is_for_menubar):
3122 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3123 (xg_set_widget_bg): New function.
3124 (delete_cb): New function.
895009e1 3125 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3126 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3127 (xg_set_background_color): Call xg_set_widget_bg.
3128 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3129 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3130 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3131 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3132 if ! HAVE_GTK3.
3133 (update_frame_tool_bar): Call gtk_widget_hide.
3134 (xg_initialize): Use GDK_KEY_g.
3135
3136 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3137 if ! HAVE_GTK3
3138 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3139
3140 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3141 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3142 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3143
1c2cc4ef
JB
31442011-03-08 Juanma Barranquero <lekktu@gmail.com>
3145
3146 * w32xfns.c (select_palette): Check success of RealizePalette against
3147 GDI_ERROR, not zero.
3148
33383987 3149See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3150
3151;; Local Variables:
3152;; coding: utf-8
aac0c6e3
MR
3153;; End:
3154
33383987 3155 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3156
3157 This file is part of GNU Emacs.
3158
3159 GNU Emacs is free software: you can redistribute it and/or modify
3160 it under the terms of the GNU General Public License as published by
3161 the Free Software Foundation, either version 3 of the License, or
3162 (at your option) any later version.
3163
3164 GNU Emacs is distributed in the hope that it will be useful,
3165 but WITHOUT ANY WARRANTY; without even the implied warranty of
3166 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3167 GNU General Public License for more details.
3168
3169 You should have received a copy of the GNU General Public License
3170 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.