* replace.el (occur-mode-goto-occurrence): Don't force using other window.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
46888499
EZ
12011-09-14 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4 computation of loop end. Reported by Johan Bockgård
5 <bojohan@gnu.org>.
6
ef8ef9fb
CY
72011-09-13 Chong Yidong <cyd@stupidchicken.com>
8
9 * frame.c (Fother_visible_frames_p): Function deleted.
10
fa819fed
EZ
112011-09-12 Eli Zaretskii <eliz@gnu.org>
12
13 * indent.c (compute_motion): Process display vector front to back
14 rather than the other way around. (Bug#2496)
15
2ba8e008
SM
162011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
17
18 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
19
20f53c69
CY
202011-09-11 Chong Yidong <cyd@stupidchicken.com>
21
22 * minibuf.c (Fread_from_minibuffer): Doc fix.
23
d562d7a4
EZ
242011-09-11 Eli Zaretskii <eliz@gnu.org>
25
26 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
27 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
28
1c4d7f3d
LMI
292011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
30
31 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
32 value for non-existent files.
33
b885bf36
EZ
342011-09-11 Eli Zaretskii <eliz@gnu.org>
35
36 * fileio.c (Finsert_file_contents): If the file cannot be opened,
37 set its "size" to -1. This will set the modtime_size field of
38 the corresponding buffer to -1, which is what
39 verify-visited-file-modtime expects for files that do not exist.
40 (Bug#9139)
41
6612f0bf
PE
422011-09-11 Paul Eggert <eggert@cs.ucla.edu>
43
44 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
45 here ...
46 * lisp.h: ... from here. push_key_description is no longer
47 defined in keyboard.c, so its declaration should not be in
48 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
49 logically belongs with push_key_description.
50
dfb3f755
PE
512011-09-10 Paul Eggert <eggert@cs.ucla.edu>
52
53 * buffer.h: Include <sys/types.h> instead of <time.h>.
54 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
55 Problem reported by Herbert J. Skuhra.
56
3134906c
LMI
572011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
58
59 * xml.c (parse_region): Make the parsing work for
60 non-comment-starting XML files again (bug#9144).
61
8d903f4e
AS
622011-09-10 Andreas Schwab <schwab@linux-m68k.org>
63
64 * image.c (gif_load): Fix calculation of bottom and right corner.
65 (Bug#9468)
66
80ad64f4
EZ
672011-09-10 Eli Zaretskii <eliz@gnu.org>
68
69 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
70 redisplay in small windows.
71
208a048d
EZ
722011-09-09 Eli Zaretskii <eliz@gnu.org>
73
74 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
75
9b1c252e
MR
762011-09-08 Martin Rudalics <rudalics@gmx.at>
77
78 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
79 Operate on live windows only.
80
2949f33b
JB
812011-09-08 Juanma Barranquero <lekktu@gmail.com>
82
83 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
84
e08dcafd
EZ
852011-09-07 Eli Zaretskii <eliz@gnu.org>
86
87 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
88 only under bidi iteration.
89
115b96bd
JD
902011-09-07 Jan Djärv <jan.h.d@swipnet.se>
91
92 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
93
c8199d0f
PE
942011-09-06 Paul Eggert <eggert@cs.ucla.edu>
95
96 isnan: Fix porting problem to Solaris 10 with bundled gcc.
97 Without this fix, the command to link temacs failed due to an
98 undefined symbol __builtin_isnan. This is because
99 /usr/include/iso/math_c99.h #defines isnan(x) to
100 __builtin_isnan(x), but the bundled gcc, which identifies itself
101 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
102 a __builtin_isnan.
103 * floatfns.c (isnan): #undef, and then #define to a clone of
104 what's in data.c.
105 (Fisnan): Always define, since it's always available now.
106 (syms_of_floatfns): Always define isnan at the Lisp level.
107
e39b275c 1082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
109
110 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
111
b2db44d9 1122011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 113
f4af5137 114 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
115 The previous code assumed that file offsets (off_t values) fit in
116 EMACS_INT variables, which is not true on typical 32-bit hosts.
117 The code messed up by falsely reporting buffer overflow in cases
118 such as (insert-file-contents "big" nil 1 2) into an empty buffer
119 when "big" contains more than 2**29 bytes, even though this
120 inserts just one byte and does not overflow the buffer.
121 (Finsert_file_contents): Store file offsets as off_t
122 values, not as EMACS_INT values. Check for overflow when
123 converting between EMACS_INT and off_t. When checking for
124 buffer overflow or for overlap, take the offsets into account.
125 Don't use EMACS_INT for small values where int suffices.
126 When checking for overlap, fix a typo: ZV was used where
127 ZV_BYTE was intended.
128 (Fwrite_region): Don't assume off_t fits into 'long'.
129 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
130
ecfc0a49
MA
1312011-09-05 Michael Albinus <michael.albinus@gmx.de>
132
133 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
134
6511acf2 1352011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 136
0999621a 137 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
138
139 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 140 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
141 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
142 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
143 (modify_event_symbol): Do not assume that the length of
144 name_alist_or_stem is safe to alloca and fits in int.
145 (Fexecute_extended_command): Likewise for function name and binding.
146 (Frecursion_depth): Wrap around reliably on integer overflow.
147 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
148 since some callers pass EMACS_INT values.
149 (Fsingle_key_description): Don't crash if symbol name contains more
150 than MAX_ALLOCA bytes.
151 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
152 (get_minibuffer): Arg is now EMACS_INT, not int.
153 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 154 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
155 * window.h (command_loop_level, minibuf_level): Reflect API changes.
156
2be7d702
PE
157 * dbusbind.c (signature_cat): New function.
158 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
159 Do not overrun buffer; instead, report string overflow.
160
9d1df220
PE
161 * dispnew.c (add_window_display_history): Don't overrun buffer.
162 Truncate instead; this is OK since it's just a log.
163
33ef5c64
PE
164 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
165 even if the time zone offset is outlandishly large.
166 Don't mishandle offset == INT_MIN.
167
66c6fdd5
PE
168 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
169 when creating daemon; the previous buffer-overflow check was incorrect.
170
d749b01b
PE
171 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
172 which has the guts of the old verror function.
173
b5cd1905
PE
174 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
175 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
176
6e1a67fb
PE
177 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
178 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 179 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 180 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
181 length of string rather than counting it via multiple sprintfs;
182 that's simpler and more reliable.
c21721cc
PE
183 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
184 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
185 sprintf, in case result does not fit in int.
186
c57b67fc
PE
187 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
188 (fontset_from_font): Print it.
189
8a401434
PE
190 * frame.c (tty_frame_count): Now printmax_t, not int.
191 (make_terminal_frame, set_term_frame_name): Print it.
192 (x_report_frame_params): In X, window IDs are unsigned long,
193 not signed long, so print them as unsigned.
194 (validate_x_resource_name): Check for implausibly long names,
195 and don't assume name length fits in 'int'.
196 (x_get_resource_string): Don't blindly alloca invocation name;
197 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
198 not fit in int.
199
6e1a67fb
PE
200 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
201 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
202 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
203
0df02bf3
PE
204 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
205 Use esprintf, not sprintf, in case result does not fit in int.
206
48e30793
PE
207 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
208 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
209 it as a large positive number.
210 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
211 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
212
a66ff6d8
PE
213 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
214 in case result does not fit in int.
215
aca216ff
PE
216 * print.c (float_to_string): Detect width overflow more reliably.
217 (print_object): Make sprintf buffer a bit bigger, to avoid potential
218 buffer overrun. Don't assume list length fits in 'int'. Treat
219 print length of 0 as 0, not as infinity; to be consistent with other
220 uses of print length in this function. Don't overflow print length
221 index. Don't assume hash table size fits in 'long', or that
222 vectorlike size fits in 'unsigned long'.
223
31c286f7
PE
224 * process.c (make_process): Use printmax_t, not int, to format
225 process-name gensyms.
226
55e5faa1
PE
227 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
228
80f2e268
PE
229 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
230 to avoid potential buffer overrun.
231
670741ab
PE
232 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
233 if X resource line is longer than 512 bytes.
234
b7163a50
PE
235 * xfns.c (x_window): Make sprintf buffer a bit bigger
236 to avoid potential buffer overrun.
237
ae58ff1f
PE
238 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
239
c43c8a6a
PE
240 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
241
3f8236f4
PE
2422011-09-04 Paul Eggert <eggert@cs.ucla.edu>
243
53e9fe90 244 Integer overflow fixes for scrolling, etc.
6511acf2
PE
245 Without these, Emacs silently mishandles large integers sometimes.
246 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
247 it were "C-u 1 M-x recenter" on a typical 64-bit host.
248
6511acf2
PE
249 * xdisp.c (try_window_id): Check Emacs fixnum range before
250 converting to 'int'.
806add1d 251
6511acf2 252 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
253 Check that an Emacs fixnum is in range before assigning it to 'int'.
254 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
255 values converted from Emacs fixnums.
256 (Frecenter): Don't wrap around a line count if it is out of 'int'
257 range; instead, treat it as an extreme value.
258 (Fset_window_configuration, compare_window_configurations):
259 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
260
6511acf2
PE
261 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
262 that can exceed INT_MAX. Check that EMACS_INT value is in range
263 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
264 (match_limit): Don't assume that a fixnum can fit in 'int'.
265
6511acf2 266 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
267 exceed INT_MAX.
268
6511acf2 269 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
270 (Fvertical_motion): Don't wrap around LINES values that don't fit
271 in 'int'. Instead, treat them as extreme values. This is good
272 enough for windows, which can't have more than INT_MAX lines anyway.
273
fcb901a7
LMI
2742011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
275
0f2f6b6d
LMI
276 * Require libxml/parser.h to avoid compilation warning.
277
fcb901a7
LMI
278 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
279
280 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
281 since this reportedly can destroy thread storage.
282
6e20a0d4
CY
2832011-08-30 Chong Yidong <cyd@stupidchicken.com>
284
285 * syntax.c (find_defun_start): Update all cache variables if
286 exiting early (Bug#9401).
287
148ae00e
EZ
2882011-08-30 Eli Zaretskii <eliz@gnu.org>
289
f6cfbd8f
EZ
290 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
291
148ae00e
EZ
292 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
293 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
294 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
295
296 * term.c (tty_append_glyph): New function.
297 (produce_stretch_glyph): Static function and its prototype deleted.
298
299 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
300 prototypes.
301
c4a07a4c
PE
3022011-08-29 Paul Eggert <eggert@cs.ucla.edu>
303
304 * image.c (parse_image_spec): Check for nonnegative, not for positive,
305 when checking :margin (Bug#9390).
306 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
307 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
308 so that the name doesn't mislead. All uses changed.
309
6bc8cd65
JB
3102011-08-28 Johan Bockgård <bojohan@gnu.org>
311
312 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
313 set_tty_hooks.
314
dca4927e
EZ
3152011-08-27 Eli Zaretskii <eliz@gnu.org>
316
317 * xdisp.c (move_it_to): Don't bail out early when reaching
318 position beyond to_charpos, if we are scanning backwards.
319 (move_it_vertically_backward): When DY == 0, make sure we get to
320 the first character in the line after the newline.
321
f2cad773
PE
3222011-08-27 Paul Eggert <eggert@cs.ucla.edu>
323
324 * ccl.c: Improve and simplify overflow checking (Bug#9196).
325 (ccl_driver): Do not generate an out-of-range pointer.
326 (Fccl_execute_on_string): Remove unnecessary check for
327 integer overflow, noted by Stefan Monnier in
328 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
329 Remove a FIXME that didn't need fixing.
330 Simplify the newly-introduced buffer reallocation code.
331
0cae2cdb
JB
3322011-08-27 Juanma Barranquero <lekktu@gmail.com>
333
334 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
335
5fc295a4 3362011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 337
70c60eb2 338 Integer and memory overflow issues (Bug#9196).
726e0ab1 339
d31850da
PE
340 * doc.c (get_doc_string): Rework so that
341 get_doc_string_buffer_size is the actual buffer size, rather than
342 being 1 less than the actual buffer size; this makes xpalloc more
343 convenient.
344
a69fbedb
PE
345 * image.c (x_allocate_bitmap_record, cache_image):
346 * xselect.c (Fx_register_dnd_atom):
347 Simplify previous changes by using xpalloc.
348
fe5c5d37
PE
349 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
350 since either will do and ptrdiff_t is convenient with xpalloc.
351
0065d054
PE
352 * charset.c (charset_table_size)
353 (struct charset_sort_data.priority): Now ptrdiff_t.
354 (charset_compare): Don't overflow if priorities differ greatly.
355 (Fsort_charsets): Don't assume list length fits in int.
356 Check for size-calculation overflow when allocating sort data.
357 (syms_of_charset): Allocate an initial charset table that is
358 just under 64 KiB, to avoid problems with glibc malloc and mmap.
359
360 * cmds.c (internal_self_insert): Check for size-calculation overflow.
361
362 * composite.h (struct composition.glyph_len): Now int, not unsigned.
363 The actual value is always <= INT_MAX, and leaving it unsigned made
364 overflow checking harder.
365
366 * dispextern.h (struct glyph_matrix.rows_allocated)
367 (struct face_cache.size): Now ptrdiff_t, for convenience in use
368 with xpalloc. The values are still always <= INT_MAX.
369
370 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
371
372 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
373 (SAFE_NALLOCA): New macro.
374
375 * region-cache.c (struct boundary.pos, find_cache_boundary)
376 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
377 (set_cache_region, invalidate_region_cache)
378 (revalidate_region_cache, know_region_cache, region_cache_forward)
379 (region_cache_backward, pp_cache):
380 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
381 so that ptrdiff_t * can be passed to xpalloc.
382 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
383 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
384 (pp_cache): Don't assume cache_len fits in int.
385 * region-cache.h: Adjust extern decls to match.
386
387 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
388 EMACS_INT, since either will do, for xpalloc.
389
390 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
391 (xnmalloc, xnrealloc, xpalloc): New functions.
392
726e0ab1
PE
393 * bidi.c (bidi_shelve_header_size): New constant.
394 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
395 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
396
51f30bc5 397 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
398 * buffer.c (overlays_at, overlays_in, record_overlay_string)
399 (overlay_strings):
400 Don't update size of array until after memory allocation succeeds,
401 because xmalloc/xrealloc may not return.
0065d054
PE
402 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
403 now that we have proper integer overflow checking.
404 (record_overlay_string, overlay_strings): Catch overflows when
405 calculating size of overlay_str_buf.
726e0ab1 406
0065d054
PE
407 * callproc.c (Fcall_process): Check for size overflow when
408 calculating size of args2.
409 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
410 Normally we prefer signed values, but sticking with ptrdiff_t would
411 require adding more-complicated checks.
726e0ab1
PE
412
413 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
414 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
415 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 416 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
417
418 * character.c (Fstring): Check for size-calculation overflow.
419
420 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
421 unnecessary integer overflow. Check for size overflow.
422 (encode_coding_object): Don't update size until xmalloc succeeds.
423
424 * composite.c (get_composition_id): Check for overflow in glyph
425 length calculations.
426
427 Integer and memory overflow fixes for display code.
428 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
429 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
430 (scrolling_window): Check for overflow in size calculations.
431 (line_draw_cost, realloc_glyph_pool, add_row_entry):
432 Don't assume glyph table len fits in int.
433 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
434 (row_table_size): Now ptrdiff_t, not int.
435 (scrolling_window): Avoid overflow in size calculations.
436 Don't update size until allocation succeeds.
437 * fns.c (concat): Check for overflow in size calculations.
438 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
439 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
440 (NEXT_ALMOST_PRIME_LIMIT): New constant.
441
442 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
443 (get_doc_string): Check for size calculation overflow.
444 Don't update size until allocation succeeds.
445 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
446 EMACS_INT, where ptrdiff_t will do.
447 (Fsubstitute_command_keys): Check for string overflow.
448
449 * editfns.c (set_time_zone_rule): Don't assume environment length
450 fits in int.
451 (message_length): Now ptrdiff_t, not int.
452 (Fmessage_box): Don't update size until allocation succeeds.
453 Don't assume message length fits in int.
454 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
455
0065d054
PE
456 * emacs.c (main): Do not reallocate argv, since there is a null at
457 the end that can be overwritten, and this way there's no need to
458 worry about size-calculation overflow.
459 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
460
461 * eval.c (init_eval_once, grow_specpdl): Don't update size until
462 alloc succeeds.
463 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
464
465 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
466 (x_set_scroll_bar_width, x_figure_window_size):
467 Check for integer overflow.
468 (x_set_alpha): Do not assume XINT fits in int.
469
470 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
471 This is for the members text_lines, text_cols, total_lines, total_cols,
472 where the system imposes an 'int' limit.
473
474 * fringe.c (Fdefine_fringe_bitmap):
475 Don't update size until alloc works.
476
477 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
478 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
479
480 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
481 Check for size-calculation overflow.
482 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
483 do, as we prefer signed integers.
484 (id_to_widget.max_size, id_to_widget.used)
485 (xg_store_widget_in_map, xg_remove_widget_from_map)
486 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
487 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
488 Use and return ptrdiff_t, not int.
489 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
490 * gtkutil.h: Change prototypes to match the above.
491
492 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
493 are duplicate now that they've been promoted to lisp.h.
494 (x_allocate_bitmap_record, x_alloc_image_color)
495 (make_image_cache, cache_image, xpm_load):
496 Don't update size until alloc is done.
497 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
498 (x_detect_edges):
3256efce 499 Check for size calculation overflow.
726e0ab1
PE
500 (ct_colors_allocated_max): New constant.
501 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
502 overflow.
3256efce 503
726e0ab1
PE
504 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
505 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
506 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
507 Use ptrdiff_t, not int, to count maps.
508 (read_char_minibuf_menu_prompt): Check for overflow in size
509 calculations. Don't update size until allocation succeeds. Redo
510 calculations to avoid overflow.
511 * keyboard.h: Change prototypes to match the above.
512
513 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
514 to count maps.
515 (current_minor_maps): Check for size calculation overflow.
516 * keymap.h: Change prototypes to match the above.
517
518 * lread.c (read1, init_obarray): Don't update size until alloc done.
519
520 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
521 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
522
726e0ab1
PE
523 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
524 Now ptrdiff_t, not int.
525 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
526 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
527
528 * process.c (Fnetwork_interface_list): Check for overflow
529 in size calculation.
530
531 * region-cache.c (move_cache_gap): Check for size calculation overflow.
532
533 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
534 overflow. Don't bother calling xmalloc when xrealloc will do.
535
536 * search.c (Freplace_match): Check for size calculation overflow.
537 (Fset_match_data): Don't assume list lengths fit in 'int'.
538
539 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
540 for command line length. Do not attempt to address one before the
541 beginning of an array, as that's not portable.
542
543 * term.c (max_frame_lines): Remove; unused.
544 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
545 not int.
546 (encode_terminal_code, calculate_costs): Check for size
547 calculation overflow.
548 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
549 table lengths and related sizes. Don't update size until alloc
550 done. Redo calculations to avoid overflow.
551 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
552
553 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
554 subtracting pointers.
555 (gobble_line): Check for overflow more carefully. Don't update size
556 until alloc done.
557
558 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
559 Don't update size until alloc done.
560 Redo size calculations to avoid overflow.
561 Check for size calculation overflow.
0065d054 562 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
563
564 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
565 Use ptrdiff_t, not int, for sizes.
566 (store_mode_line_noprop_char): Don't update size until alloc done.
567
0065d054
PE
568 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
569 Use ptrdiff_t, not int, for sizes.
570 (Finternal_make_lisp_face, cache_face):
571 Check for size calculation overflow.
572 (cache_face): Treat size calculation overflows as if they were
573 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
574
575 * xfns.c (x_encode_text, x_set_name_internal)
576 (Fx_change_window_property): Use ptrdiff_t, not int, to count
577 sizes, since they can exceed INT_MAX in size. Check for size
578 calculation overflow.
579
0065d054
PE
580 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
581 (xg_select): Check for size calculation overflow.
726e0ab1
PE
582 Don't update size until alloc done.
583
0065d054 584 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 585 as sprintf is limited to int lengths.
1d526e2f 586
252c5ee1
PE
587 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
588 (X_LONG_MIN): New macros.
864d7ce7
PE
589 Use them to make the following changes clearer.
590 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
591 This change doesn't affect the value now, but it may help remind
592 future maintainers not to raise the value too much later.
593 (SELECTION_QUANTUM): Remove, replacing with ...
594 (selection_quantum): ... new function, which avoids overflow.
595 All uses changed.
596 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
597 assumption that selection length fits in 'int'.
598 (x_reply_selection_request, x_handle_selection_request)
599 (x_get_window_property, receive_incremental_selection)
600 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
601 (lisp_data_to_selection_data, clean_local_selection_data):
602 Use ptrdiff_t, not int, to record length of selection.
603 (x_reply_selection_request, x_get_window_property)
604 (receive_incremental_selection, x_property_data_to_lisp):
605 Redo calculations to avoid overflow.
606 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 607 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
608 something.
609 (x_get_window_property, receive_incremental_selection)
610 (lisp_data_to_selection_data, x_property_data_to_lisp):
611 Check for size-calculation overflow.
612 (x_get_window_property, receive_incremental_selection)
613 (lisp_data_to_selection_data, Fx_register_dnd_atom):
614 Don't store size until memory allocation succeeds.
615 (x_get_window_property): Plug memory leak on memory exhaustion.
616 Don't double-block input; malloc is safe here. Don't assume 2**34
617 - 4 fits in unsigned long. Add an xassert to check
618 XGetWindowProperty overflow. Be more careful about overflow
619 calculations, and distinguish size from memory overflow better.
620 (receive_incremental_selection): When tracing, don't assume
621 unsigned int is less than INT_MAX.
622 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
623 harmful) conversions of unsigned short to int.
624 (lisp_data_to_selection_data): Don't assume that integers
625 in the range -65535 through -1 fit in an X unsigned short.
626 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
627 result parameters unless successful. Rely on cons_to_unsigned
628 to report problems with elements; the old code wasn't right anyway.
629 (x_check_property_data): Check for int overflow; we cannot use
630 a wider type due to X limits.
631 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
632
726e0ab1 633 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 634
0065d054
PE
635 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
636 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
637 (x_color_cells): Don't store size until memory allocation succeeds.
638 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 639 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
640 (x_term_init): Don't assume length fits in int (sprintf is limited
641 to int size).
bc18e09d 642
ebfa62c0
PE
643 Use ptrdiff_t for composition IDs.
644 * character.c (lisp_string_width):
645 * composite.c (composition_table_size, n_compositions)
646 (get_composition_id, composition_gstring_from_id):
647 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
648 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
649 * window.c (Frecenter):
650 Use ptrdiff_t, not int, for composition IDs.
651 * composite.c (get_composition_id): Check for integer overflow.
652 * composite.h: Adjust prototypes to match the above changes.
653
d3411f89
PE
654 Use ptrdiff_t for hash table indexes.
655 * category.c (hash_get_category_set):
656 * ccl.c (ccl_driver):
657 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
658 * coding.c (coding_system_charset_list, detect_coding_system):
659 * coding.h (struct coding_system.id):
660 * composite.c (get_composition_id, gstring_lookup_cache):
661 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
662 * image.c (xpm_get_color_table_h):
663 * lisp.h (hash_lookup, hash_put):
664 * minibuf.c (Ftest_completion):
665 Use ptrdiff_t for hash table indexes, not int (which is too
666 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
667 32-bit --with-wide-int hosts).
668
e097a6fa
PE
669 * charset.c (Fdefine_charset_internal): Check for integer overflow.
670 Add a FIXME comment about memory leaks.
671 (syms_of_charset): Don't assume xmalloc returns.
672
5637687f
PE
673 Don't assume that stated character widths fit in int.
674 * character.c (Fchar_width, c_string_width, lisp_string_width):
675 * character.h (CHAR_WIDTH):
676 * indent.c (MULTIBYTE_BYTES_WIDTH):
677 Use sanitize_char_width to avoid undefined and/or bad behavior
678 with outlandish widths.
679 * character.h (sanitize_tab_width): Renamed from sanitize_width,
680 now that we have two such functions. All uses changed.
681 (sanitize_char_width): New inline function.
682
a2271ba2
PE
683 Don't assume that tab-width fits in int.
684 * character.h (sanitize_width): New inline function.
685 (SANE_TAB_WIDTH): New macro.
686 (ASCII_CHAR_WIDTH): Use it.
687 * indent.c (sane_tab_width): Remove. All uses replaced by
688 SANE_TAB_WIDTH (current_buffer).
689 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
690
18c52557
PE
691 * fileio.c: Integer overflow issues with file modes.
692 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
693
caeeedc1
PE
694 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
695 Remove unreachable code.
696 (read_hex, load_charset_map_from_file): Check for integer overflow.
697
50849c52
PE
698 * xterm.c: don't go over XClientMessageEvent limit
699 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
700 (x_send_scroll_bar_event): Likewise. Check that the size does not
701 exceed limits imposed by XClientMessageEvent, as well as the usual
702 ptrdiff_t and size_t limits.
703
b13995db
PE
704 * keyboard.c: Overflow, signedness and related fixes.
705 (make_lispy_movement): Use same integer type in forward decl
706 that is used in the definition.
707 (read_key_sequence, keyremap_step):
708 Change bufsize argument back to int, undoing my 2011-03-30 change.
709 We prefer signed types, and int is wide enough here.
710 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
711 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
712 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
713 length, not size_t. Use ptrdiff_t for index, not int.
714 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
715 possibility of integer overflow.
716
13464394
PE
717 Overflow, signedness and related fixes for images.
718
719 * dispextern.h (struct it.stack[0].u.image.image_id)
720 (struct_it.image_id, struct image.id, struct image_cache.size)
721 (struct image_cache.used, struct image_cache.ref_count):
722 * gtkutil.c (update_frame_tool_bar):
723 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
724 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
725 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
726 * nsmenu.m (update_frame_tool_bar):
727 * xdisp.c (calc_pixel_width_or_height):
728 * xfns.c (image_cache_refcount):
729 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
730 on typical 64-bit hosts.
731
732 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
733 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
734 Omit unnecessary casts to int.
735 (parse_image_spec): Check that integers fall into 'int' range
736 when the callers expect that.
737 (image_ascent): Redo ascent calculation to avoid int overflow.
738 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
739 (lookup_image): Remove unnecessary tests.
740 (xbm_image_p): Locals are now of int, not EMACS_INT,
741 since parse_image_check makes sure they fit into int.
742 (png_load, gif_load, svg_load_image):
743 Prefer int to unsigned where either will do.
744 (tiff_handler): New function, combining the cores of the
745 old tiff_error_handler and tiff_warning_handler. This
746 function is rewritten to use vsnprintf and thereby avoid
747 stack buffer overflows. It uses only the features of vsnprintf
748 that are common to both POSIX and native Microsoft.
749 (tiff_error_handler, tiff_warning_handler): Use it.
750 (tiff_load, gif_load, imagemagick_load_image):
751 Don't assume :index value fits in 'int'.
752 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
753 (imagemagick_load_image): Check that crop parameters fit into
754 the integer types that MagickCropImage accepts. Don't assume
755 Vimagemagick_render_type has a nonnegative value. Don't assume
756 size_t fits in 'long'.
757 (gs_load): Use printmax_t to print the widest integers possible.
758 Check for integer overflow when computing image height and width.
759
c11821d4
EZ
7602011-08-26 Eli Zaretskii <eliz@gnu.org>
761
762 * xdisp.c (redisplay_window): Don't force window start if point
763 will be invisible in the resulting window. (Bug#9324)
764
0c95fcf7
EZ
7652011-08-25 Eli Zaretskii <eliz@gnu.org>
766
767 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
768 the display spec is of the form `(space ...)'.
769 (handle_display_spec): Return the value returned by
770 handle_single_display_spec, not just 1 or zero.
771 (handle_single_display_spec): If the display spec is of the form
772 `(space ...)', and specifies display in the text area, return 2
773 rather than 1.
fee65a97 774 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
775 accurately, and prefer exact match for point under bidi. Don't
776 advance `row' beyond the last row of the window.
0c95fcf7
EZ
777
778 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
779 into disp_prop; all users changed.
780
781 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
782 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
783 for the text covered by the display property.
784
e4ed06f1
CY
7852011-08-25 Chong Yidong <cyd@stupidchicken.com>
786
787 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
788 Change return value to nil.
789 (Frecord_buffer): Delete unused function.
790
f67cdd7f
EZ
7912011-08-24 Eli Zaretskii <eliz@gnu.org>
792
5980d4c6
EZ
793 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
794 buffers, return left-to-right.
8610fe8b
EZ
795 (set_cursor_from_row): Consider candidate row a win if its glyph
796 represents a newline and point is on that newline. Fixes cursor
797 positioning on the newline at EOL of R2L text within L2R
798 paragraph, and vice versa.
799 (try_cursor_movement): Check continued rows, in addition to
800 continuation rows. Fixes unwarranted scroll when point enters a
801 continued line of R2L text within an L2R paragraph, or vice versa.
802 (cursor_row_p): Consider the case of point being equal to
803 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
804 from the end of a short line to the beginning of a continued line
805 of R2L text within L2R paragraph.
806 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
807 composed characters.
5980d4c6 808
f67cdd7f
EZ
809 * bidi.c (bidi_check_type): Use xassert.
810 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
811 members.
812
bca633fb
EZ
8132011-08-23 Eli Zaretskii <eliz@gnu.org>
814
815 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
816 a character.
817
4a5885a7
CY
8182011-08-23 Chong Yidong <cyd@stupidchicken.com>
819
820 * nsfont.m (ns_otf_to_script): Fix typo.
821
0902a04e
KH
8222011-08-22 Kenichi Handa <handa@m17n.org>
823
824 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
825 extra slot even if the purpose is char-code-property-table.
826
1a2e6670
EZ
8272011-08-23 Eli Zaretskii <eliz@gnu.org>
828
8ddde651
EZ
829 * xdisp.c (redisplay_window): When computing centering_position,
830 account for the height of the header line. (Bug#8874)
831
425cc014
EZ
832 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
833 instead of CHAR_TO_BYTE. Fixes a crash when a completion
834 candidate is selected by the mouse, and that candidate has a
835 composed character under the mouse.
836
1a2e6670
EZ
837 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
838 coordinates reported by pos-visible-in-window-p for a composed
839 character in column zero.
840
8b76d6f8
SM
8412011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
842
843 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
844
dac347dd
EZ
8452011-08-22 Eli Zaretskii <eliz@gnu.org>
846
847 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
848 consider it a hit if to_charpos is anywhere in the range of the
849 composed buffer positions.
850
e013fb34
CY
8512011-08-22 Chong Yidong <cyd@stupidchicken.com>
852
853 * image.c (gif_load): Don't assume that each subimage has the same
854 dimensions as the base image. Handle disposal method that is
855 "undefined" by the gif spec (Bug#9335).
856
bd1ba3e8
CY
8572011-08-20 Chong Yidong <cyd@stupidchicken.com>
858
859 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 860 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 861
54a1215b
EZ
8622011-08-19 Eli Zaretskii <eliz@gnu.org>
863
823564e5
EZ
864 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
865 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
866 from an Org mode buffer to a Speedbar frame.
867
54a1215b
EZ
868 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
869 a composition, take its buffer position from IT->cmp_it.charpos.
870 Fixes cursor positioning at the beginning of a line that begins
871 with a composed character.
872
9778ebcc
EZ
8732011-08-18 Eli Zaretskii <eliz@gnu.org>
874
0be6ee06
EZ
875 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
876 character bidirectional type, use STRONG_L instead. Fixes crashes
877 in a buffer produced by `describe-categories'.
878
9778ebcc
EZ
879 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
880 members before the level stack, so they would be saved and
881 restored when copying iterator state. Fixes incorrect reordering
882 around TABs covered by display properties.
883
156bffbe
AS
8842011-08-18 Andreas Schwab <schwab@linux-m68k.org>
885
886 * process.c (Fnetwork_interface_list): Correctly determine buffer
887 size.
888
72ad093b
CY
8892011-08-17 Chong Yidong <cyd@stupidchicken.com>
890
891 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
892 (internal_condition_case_2, internal_condition_case_n):
893 Remove unnecessary aborts (Bug#9081).
72ad093b 894
35774242
EZ
8952011-08-17 Eli Zaretskii <eliz@gnu.org>
896
897 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
898 has no `load' handler, try opening the file locally. (Bug#9311)
899
db76dd85
KB
9002011-08-16 Ken Brown <kbrown@cornell.edu>
901
902 * gmalloc.c: Expand comment.
903
b215eee5
EZ
9042011-08-16 Eli Zaretskii <eliz@gnu.org>
905
906 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
907 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
908
a4579d33
KB
9092011-08-16 Ken Brown <kbrown@cornell.edu>
910
911 Fix memory allocation problems in Cygwin build (Bug#9273).
912
913 * unexcw.c ( __malloc_initialized): Declare external variable.
914 (fixup_executable): Force the dumped emacs to reinitialize malloc.
915
8b76d6f8
SM
916 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
917 New variables.
a4579d33
KB
918 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
919 dumped emacs.
920 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
921 in the static heap.
922 [CYGWIN] (special_realloc): New function.
923 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
924 requests to realloc storage in the static heap.
925
3ebec551
PE
9262011-08-15 Paul Eggert <eggert@cs.ucla.edu>
927
928 * bidi.c (bidi_initialize): Remove unused local.
929
9fd8be00
EZ
9302011-08-15 Eli Zaretskii <eliz@gnu.org>
931
474a8465
EZ
932 * biditype.h: File removed.
933
934 * bidimirror.h: File removed.
935
936 * deps.mk (bidi.o): Remove biditype.h and
937 bidimirror.h.
938
939 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
940 bidimirror.h.
941
942 * dispextern.h: Fix a typo in the comment to bidi_type_t.
943
944 * chartab.c: Improve commentary for the uniprop_table API.
945
32413314
EZ
946 * bidi.c (bidi_paragraph_init): Support zero value of
947 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
948 (bidi_initialize): Use uniprop_table instead of including
949 biditype.h and bidimirror.h.
32413314 950
9fd8be00
EZ
951 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
952 coordinates of the iterator when restoring from ppos_it.
953 (Bug#9296)
954
5cf2b69b
KH
9552011-08-14 Kenichi Handa <handa@m17n.org>
956
957 * process.c (create_process): Call setup_process_coding_systems
72ad093b 958 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 959
daf17d00
EZ
9602011-08-14 Eli Zaretskii <eliz@gnu.org>
961
962 * xdisp.c (move_it_in_display_line_to): Don't invoke
963 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
964 ppos_it. Fixes vertical cursor motion when line beginning is
965 covered by an image. (Bug#9296)
966
08e3161a
JD
9672011-08-14 Jan Djärv <jan.h.d@swipnet.se>
968
969 * nsterm.h (ns_run_ascript): Declare.
970 (NSAPP_DATA2_RUNASSCRIPT): Define.
971
972 * nsfns.m (as_script, as_result, as_status): New static variables.
973 (ns_run_ascript): New function.
5e617bc2 974 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
975 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
976 the event loop. Get status from as_status (Bug#7276).
977
978 * nsterm.m (sendEvent): If event is NSApplicationDefined and
979 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
980 the event loop (Bug#7276).
981
a3720aa2
AS
9822011-08-14 Andreas Schwab <schwab@linux-m68k.org>
983
984 * gnutls.c (QCgnutls_bootprop_priority)
985 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
986 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
987 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
988 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
989 (QCgnutls_bootprop_verify_hostname_error)
990 (QCgnutls_bootprop_callbacks_verify): Rename from
991 Qgnutls_bootprop_..., all uses changed.
992
993 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
994 uses changed.
995
0a0d27fb
PE
9962011-08-14 Paul Eggert <eggert@cs.ucla.edu>
997
19d5c50c
PE
998 * xfaces.c (Qframe_set_background_mode): Now static.
999 * dispextern.h (Qframe_set_background_mode): Remove decl.
1000
0a0d27fb
PE
1001 * process.c (Fnetwork_interface_info): Declare local only if needed.
1002
377538cb
JD
10032011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1004
1005 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1006 (Fnetwork_interface_list): Allocate in increments of bytes instead
1007 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1008 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1009 sockaddr.
1010 (struct ifflag_def): notrailers is smart on OSX.
1011 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1012 Get hardware address with getifaddrs if available.
1013
08fff70c
EZ
10142011-08-12 Eli Zaretskii <eliz@gnu.org>
1015
1016 * xdisp.c (iterate_out_of_display_property): xassert that
1017 IT->position is set to within IT->object's boundaries. Break from
1018 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1019 when IT->position is set up wrongly due to some bug.
1020 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1021 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1022 entry. Force push_it to save on the stack the current
1023 buffer/string position, to be restored by pop_it. Fix flags in
1024 the iterator structure wrt the object coming from a display
1025 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1026 properties. (Bug#9284)
1027
7be1c708 10282011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1029
7be1c708
CY
1030 * fontset.c (fontset_get_font_group): Add proper type checks.
1031 (Bug#9172)
aac0c6e3 1032
7be1c708 10332011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1034
7be1c708
CY
1035 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1036 and LC_VERSION_MIN_MACOSX.
1037 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1038 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1039
97bb72a6
EZ
10402011-08-08 Eli Zaretskii <eliz@gnu.org>
1041
1042 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1043 no-display-properties-and-no-overlays under bidi display.
1044 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1045 properties and overlays.
97bb72a6 1046
d5617611
CY
10472011-08-08 Chong Yidong <cyd@stupidchicken.com>
1048
37e11a63
CY
1049 * editfns.c (Fset_time_zone_rule): Document relationship with the
1050 setenv function.
1051
d5617611
CY
1052 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1053 the font entity extracted from the cache (Bug#8109).
1054
58872834
CY
10552011-08-07 Chong Yidong <cyd@stupidchicken.com>
1056
1057 * composite.c (autocmp_chars): Don't reset point. That is done by
1058 restore_point_unwind (Bug#5984).
1059
75bfc667
JL
10602011-08-07 Juri Linkov <juri@jurta.org>
1061
1062 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1063 to show the arg `TIME' instead of `TIMEVAL'.
1064
d1410150
EZ
10652011-08-06 Eli Zaretskii <eliz@gnu.org>
1066
1067 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1068 display property strides EOL and includes a newline, as in
1069 longlines-mode. (Bug#9254)
75b771e4
EZ
1070 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1071 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1072
1073 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1074 is non-zero, even if the data buffer is NULL. Fixes a crash in
1075 vertical-motion with longlines-mode. (Bug#9254)
1076
35928349
EZ
10772011-08-05 Eli Zaretskii <eliz@gnu.org>
1078
ec7cc85b
EZ
1079 * bidi.c <bidi_cache_total_alloc>: Now static.
1080 (bidi_initialize): Initialize bidi_cache_total_alloc.
1081
8b76d6f8 1082 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1083 cache. (Bug#9221)
1084
1085 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1086 amount allocated this far in `bidi_cache_total_alloc'.
1087 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1088 non-zero, only free the data buffer without restoring the cache
1089 contents. All callers changed.
1090
1091 * dispextern.h (bidi_unshelve_cache): Update prototype.
1092
1093 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1094 (move_it_in_display_line, move_it_to)
1095 (move_it_vertically_backward, move_it_by_lines): Replace the call
1096 to xfree to an equivalent call to bidi_unshelve_cache.
1097 (move_it_in_display_line_to): Fix logic of returning
412b6358 1098 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1099
e2e2423b
EZ
11002011-08-05 Eli Zaretskii <eliz@gnu.org>
1101
1102 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1103 came from a string character with a `cursor' property. (Bug#9229)
1104
ae9e757a
JD
11052011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1106
1107 * Makefile.in (LIB_PTHREAD): New variable.
1108 (LIBES): Add LIB_PTHREAD (Bug#9216).
1109
1110 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1111 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1112
213bd7f2
AS
11132011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1114
1115 * regex.c (re_iswctype): Remove some redundant boolean
1116 conversions.
1117
99aaf75f
JD
11182011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1119
1120 * xterm.c (x_find_topmost_parent): New function.
1121 (x_set_frame_alpha): Find topmost parent window with
1122 x_find_topmost_parent and set the property there also (bug#9181).
1123 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1124
c74e9d86
PE
11252011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1126
1127 * callproc.c (Fcall_process): Avoid vfork clobbering
1128 the local vars buffer, coding_systems, current_dir.
1129
640c8776
SM
11302011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1131
1132 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1133
f26d0e4c
PE
11342011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1135
8a10d76c
PE
1136 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1137 so that it is not optimized away.
1138
f26d0e4c
PE
1139 * xdisp.c (compute_display_string_pos): Remove unused local.
1140
55439c61
EZ
11412011-08-02 Eli Zaretskii <eliz@gnu.org>
1142
1143 Fix slow cursor motion and scrolling in large buffers with
1144 selective display, like Org Mode buffers. (Bug#9218)
1145
1146 * dispextern.h (struct bidi_it): New member disp_prop_p.
1147
1148 * xdisp.c: Remove one-slot cache of display string positions.
1149 (compute_display_string_pos): Accept an additional argument
5e617bc2 1150 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1151 for a display string or property. If found, set DISP_PROP_P
1152 non-zero.
1153
1154 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1155 DISP_PROP_P, and pass it to compute_display_string_pos.
1156 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1157 non-zero. All callers of bidi_fetch_char changed.
1158
fb33fa43
SM
11592011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1160
1161 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1162
b099e063
DM
11632010-12-03 Don March <don@ohspite.net>
1164
1165 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1166 last character M-[char] is translated to ESC [char] (bug#7541).
1167
5cc7f7af
KH
11682011-08-02 Kenichi Handa <handa@m17n.org>
1169
d0fffa3f 1170 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1171
1172 * chartab.c (uniprop_table): Make it non-static.
1173
525d5e6e
EZ
11742011-08-01 Eli Zaretskii <eliz@gnu.org>
1175
1176 * xdisp.c (forward_to_next_line_start): Accept additional argument
1177 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1178 on the newline.
1179 (reseat_at_next_visible_line_start): Use the bidi iterator state
1180 returned by forward_to_next_line_start to restore the state of
1181 it->bidi_it after backing up to previous newline. (Bug#9212)
1182
31011111
AS
11832011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1184
1185 * regex.c (re_comp): Protoize.
1186 (re_exec): Fix return type.
1187 (regexec): Fix type of `ret'. (Bug#9203)
1188
476371c4
PE
11892011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1190
e5d76069
PE
1191 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1192 This is needed if max-image-size is a floating-point number.
1193
9a79b20c
AS
11942011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1195
1196 * print.c (print_object): Print empty symbol as ##.
1197
1198 * lread.c (read1): Read ## as empty symbol.
1199
d8c2fa78
AA
12002011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1201
1202 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1203 setting frame foreground color (Bug#9175).
1204 (x_set_background_color): Likewise.
1205
ffe57a7a
AA
1206 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1207 contents (Bug#9176).
1208 (EmacsTooltip -init): Remove bezels and add shadows to
1209 tooltip windows.
1210
bf3492a5
AA
1211 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1212 or scroll bar (Bug#8470).
1213
d55e9c53
AA
1214 * nsfont.m (nsfont_open): Remove assignment to voffset and
1215 unnecessary vars hshink, expand, hd, full_height, min_height.
1216 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1217
1218 * nsterm.h (nsfont_info): Remove voffset field.
1219
d8c2fa78 12202011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1221
1222 Implement strike-through and overline on NextStep (Bug#8863).
1223
1224 * nsfont.m (nsfont_open): Use underline position provided by font,
1225 instead of hard-coded value of 2.
1226 (nsfont_draw): Call ns_draw_text_decoration instead.
1227
1228 * nsterm.h: Add declaration for ns_draw_text_decoration.
1229
1230 * nsterm.m (ns_draw_text_decoration): New function for drawing
1231 underline, overline, and strike-through.
1232 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1233 ns_draw_text_decoration. Change treatment of cursor drawing to
1234 accomodate underlining, etc.
1235
4cc60b9b
EZ
12362011-07-28 Eli Zaretskii <eliz@gnu.org>
1237
bc7ece87
EZ
1238 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1239 default.
4cc60b9b 1240
476371c4
PE
12412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1242
66606eea
PE
1243 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1244 Without this fix, if a signal arrives just after memory fills up,
1245 'malloc' might be invoked reentrantly.
1246
476371c4
PE
1247 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1248 In other words, assume that every image size is allowed, on non-X
1249 hosts. This assumption is probably wrong, but it lets Emacs compile.
1250
f3fcc40d
AS
12512011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1252
1253 * regex.c (re_iswctype): Convert return values to boolean.
1254
350c992f
EZ
12552011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1256
1257 * xdisp.c (compute_display_string_pos): Don't use cached display
1258 string position if the buffer had its restriction changed.
1259 (Bug#9184)
1260
5266b4bb
PE
12612011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1262
1263 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1264
2573a837 12652011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1266
41f55ccd 1267 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1268
39e378da
PE
1269 * bidi.c: Integer size and overflow fixes.
1270 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1271 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1272 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1273 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1274 (bidi_find_other_level_edge):
1275 Use ptrdiff_t instead of EMACS_INT where either will do.
1276 This works better on 32-bit hosts configured --with-wide-int.
1277 (bidi_cache_ensure_space): Check for size-calculation overflow.
1278 Use % rather than repeated addition, for better worst-case speed.
1279 Don't set bidi_cache_size until after xrealloc returns, because it
1280 might not return.
1281 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1282 (bidi_cache_ensure_space): Also check that the bidi cache size
1283 does not exceed that of the largest Lisp string or buffer. See Eli
1284 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1285
5e927815
PE
1286 * alloc.c (__malloc_size_t): Remove.
1287 All uses replaced by size_t. See Andreas Schwab's note
1288 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1289
ca4aa935
PE
1290 * image.c: Improve checking for integer overflow.
1291 (check_image_size): Assume that f is nonnull, since
1292 it is always nonnull in practice. This is one less thing to
1293 worry about when checking for integer overflow later.
1294 (x_check_image_size): New function, which checks for integer
1295 overflow issues inside X.
1296 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1297 This removes the need for a memory_full check.
1298 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1299 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1300 (xbm_read_bitmap_data): Change locals back to 'int', since
1301 their values must fit in 'int'.
1302 (xpm_load_image, png_load, tiff_load):
1303 Invoke x_create_x_image_and_pixmap earlier,
1304 to avoid much needless work if the image is too large.
1305 (tiff_load): Treat overly large images as if
1306 x_create_x_image_and_pixmap failed, not as malloc failures.
1307 (gs_load): Use x_check_image_size.
1308
5f8f9cc2
PE
1309 * gtkutil.c: Omit integer casts.
1310 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1311 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1312
5adf60bc
PE
1313 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1314
c8907a93
PE
1315 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1316 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1317 would wrongly return t on a 64-bit host.
1318
e3c25c68
PE
1319 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1320 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1321 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1322 and therefore cause GCC to emit a bogus diagnostic in some cases.
1323
3f791afe
PE
1324 * image.c: Integer signedness and overflow and related fixes.
1325 This is not an exhaustive set of fixes, but it's time to
1326 record what I've got.
1327 (lookup_pixel_color, check_image_size): Remove redundant decls.
1328 (check_image_size): Don't assume that arbitrary EMACS_INT values
1329 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1330 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1331 (tiff_load, imagemagick_load_image):
1332 Check for overflow in size calculations.
1333 (x_create_x_image_and_pixmap): Remove unnecessary test for
1334 xmalloc returning NULL; that can't happen.
1335 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1336 (xpm_color_bucket): Use better integer hashing function.
1337 (xpm_cache_color): Don't possibly over-allocate memory.
1338 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1339 (gif_memory_source):
1340 Use ptrdiff_t, not int or size_t, to record sizes.
1341 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1342 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1343 either works, as we prefer signed integers.
1344 (tiff_read_from_memory, tiff_write_from_memory):
1345 Return tsize_t, not size_t, since that's what the TIFF API wants.
1346 (tiff_read_from_memory): Don't fail simply because the read would
1347 go past EOF; instead, return a short read.
1348 (tiff_load): Omit no-longer-needed casts.
1349 (Fimagemagick_types): Don't assume size fits into 'int'.
1350
3cc5a532
PE
1351 Improve hashing quality when configured --with-wide-int.
1352 * fns.c (hash_string): New function, taken from sxhash_string.
1353 Do not discard information about ASCII character case; this
1354 discarding is no longer needed.
1355 (sxhash-string): Use it. Change sig to match it. Caller changed.
1356 * lisp.h: Declare it.
1357 * lread.c (hash_string): Remove, since we now use fns.c's version.
1358 The fns.c version returns a wider integer if --with-wide-int is
1359 specified, so this should help the quality of the hashing a bit.
1360
b312a492
PE
1361 * emacs.c: Integer overflow minor fix.
1362 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1363 Define only if GNU_LINUX.
1364 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1365
dfd153ae
PE
1366 * dispnew.c: Integer signedness and overflow fixes.
1367 Remove unnecessary forward decls, that were a maintenance hassle.
1368 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1369 All uses changed.
1370 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1371 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1372 (prepare_desired_row, line_draw_cost):
1373 Use int, not unsigned, where either works.
1374 (save_current_matrix, restore_current_matrix):
1375 Use ptrdiff_t, not size_t, where either works.
1376 (init_display): Check for overflow more accurately, and without
1377 relying on undefined behavior.
1378
a81d11a3
PE
1379 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1380 Remove, replacing with the new symbols in lisp.h. All uses changed.
1381 * fileio.c (make_temp_name):
1382 * filelock.c (lock_file_1, lock_file):
1383 * xdisp.c (message_dolog):
1384 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1385 Use pMd etc. instead.
1386 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1387 replacing the pWIDE etc. symbols removed from editfns.c.
1388
3300e6fd
PE
1389 * keyboard.h (num_input_events): Now uintmax_t.
1390 This is (very slightly) less likely to mess up due to wraparound.
1391 All uses changed.
1392
fd05c7e9
PE
1393 * buffer.c: Integer signedness fixes.
1394 (alloc_buffer_text, enlarge_buffer_text):
1395 Use ptrdiff_t rather than size_t when either will do, as we prefer
1396 signed integers.
1397
903fe15d
PE
1398 * alloc.c: Integer signedness and overflow fixes.
1399 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1400 (__malloc_size_t): Default to size_t, not to int.
1401 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1402 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1403 Prefer ptrdiff_t to size_t when either would do, as we prefer
1404 signed integers.
1405 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1406 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1407 Now const. Initialize with values that are in range even if char
1408 is signed.
1409 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1410 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1411 These functions do the right thing with sizes > 2**32.
1412 (check_depth): Now ptrdiff_t, not int.
1413 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1414 Adjust to new way of storing sizes. Check for size overflow bugs
1415 in rest of code.
1416 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1417 slightly wrong anyway, as it missed one instance of
1418 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1419 (refill_memory_reserve): Omit needless cast to size_t.
1420 (mark_object_loop_halt): Mark as externally visible.
1421
ac82cc6a
PE
1422 * xselect.c: Integer signedness and overflow fixes.
1423 (Fx_register_dnd_atom, x_handle_dnd_message):
1424 Use ptrdiff_t, not size_t, since we prefer signed.
1425 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1426 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1427 x_dnd_atoms_size and x_dnd_atoms_length.
1428
c2d1e36d
PE
1429 * doprnt.c: Prefer signed to unsigned when either works.
1430 * eval.c (verror):
1431 * doprnt.c (doprnt):
1432 * lisp.h (doprnt):
1433 * xdisp.c (vmessage):
1434 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1435 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1436 prefer signed arithmetic to avoid comparison confusion.
1437 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1438 but is a bit tricky.
1439
0e926e56
PE
1440 Assume freestanding C89 headers, string.h, stdlib.h.
1441 * data.c, doprnt.c, floatfns.c, print.c:
1442 Include float.h unconditionally.
1443 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1444 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1445 * regex.c: Likewise for stddef.h, string.h.
1446 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1447 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1448 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1449 (STDC_HEADERS): Remove obsolete defines.
1450 * sysdep.c: Include limits.h unconditionally.
1451
9cfdb3ec
PE
1452 Assume support for memcmp, memcpy, memmove, memset.
1453 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1454 * regex.c (memcmp, memcpy):
1455 Remove; we assume C89 now.
1456
1457 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1458 (__malloc_safe_bcopy): Remove; no longer needed.
1459
cf950e6b 1460 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1461 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1462 well either way, and we prefer signed to unsigned.
1463
dbf38e02
LMI
14642011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1465
1466 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1467 closes the connection while we're reading (bug#9182).
1468
d6f0886c 14692011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1470
d6f0886c
JD
1471 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1472 are specified (Bug#9168).
24e0f6b1 1473
2eb1f9e6
PE
14742011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1475
1476 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1477 Found by GCC static checking and --with-wide-int on a 32-bit host.
1478
22381272 14792011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1480
1481 * xdisp.c (compute_display_string_pos): Fix logic of caching
1482 previous display string position. Initialize cached_prev_pos to
1483 -1. Fixes slow-down at the beginning of a buffer.
1484
f25e39b4
EZ
14852011-07-24 Eli Zaretskii <eliz@gnu.org>
1486
1487 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1488 for attrs[LFACE_FONTSET_INDEX].
1489
04c4b52e
PE
14902011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1491
1492 * xml.c (parse_region): Remove unused local
1493 that was recently introduced.
1494
c1734fbd
EZ
14952011-07-23 Eli Zaretskii <eliz@gnu.org>
1496
be18c5a5
EZ
1497 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1498 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1499
c1734fbd
EZ
1500 * xdisp.c (move_it_in_display_line_to): Record the best matching
1501 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1502 exit if none of the characters scanned was an exact match.
1503 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1504 when exact match is impossible due to invisible text, and the
1505 lines are truncated.
1506
a258d627
JD
15072011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1508
1509 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1510 for OSX >= 10.7.
1511
b6d5a689
EZ
15122011-07-22 Eli Zaretskii <eliz@gnu.org>
1513
0f74f785
EZ
1514 Fix a significant slow-down of cursor motion with C-n, C-p,
1515 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1516 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1517 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1518 (next_element_from_buffer): Call compute_stop_pos_backwards to
1519 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1520 base_level_stop.
1521 (reseat): Don't look for prev_stop, as that could mean a very long
1522 run.
1523 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1524 <cached_disp_overlay_modiff>: Cache for last found display string
1525 position.
551918c1 1526 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1527 about the same buffer in the same area of character positions, and
1528 the buffer wasn't changed since the time the display string
1529 position was cached.
551918c1 1530
b2d0c91a
EZ
15312011-07-22 Eli Zaretskii <eliz@gnu.org>
1532
1533 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1534 is an integer, which is important for empty lines. (Bug#9149)
1535
043604ee
CY
15362011-07-22 Chong Yidong <cyd@stupidchicken.com>
1537
1538 * frame.c (Fmodify_frame_parameters): In tty case, update the
1539 default face if necessary (Bug#4238).
1540
da4adb04
CY
15412011-07-21 Chong Yidong <cyd@stupidchicken.com>
1542
1543 * editfns.c (Fstring_to_char): No need to explain what a character
1544 is in the docstring (Bug#6576).
1545
9abd0532
LMI
15462011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1547
1548 * xml.c (parse_region): Make sure we always return a tree.
1549
36881d16
HK
15502011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1551
1552 * xml.c (parse_region): If a document contains only comments,
1553 return that, too.
1554
1e98674d
LMI
15552011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1556
1557 * xml.c (make_dom): Return comments, too.
1558
590bd467
PE
15592011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1560
1561 Port to OpenBSD.
1562 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1563 and the surrounding thread.
1564 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1565 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1566 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1567 timer goes off.
1568 * s/openbsd.h (BROKEN_SIGIO): Define.
1569 * unexelf.c (unexec) [__OpenBSD__]:
1570 Don't update the .mdebug section of the Alpha COFF symbol table.
1571
f41628b2
LMI
15722011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1573
1574 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1575 (bug#8460).
1576
b59b67c5
PE
15772011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1578
15e3a074
PE
1579 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1580 This fixes some race conditions on the permissions of any newly
1581 created file.
1582
41bed37d
PE
1583 * alloc.c (valid_pointer_p): Use pipe, not open.
1584 This fixes some permissions issues when debugging.
1585
b59b67c5
PE
1586 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1587 If fchown fails to set both uid and gid, try to set just gid,
1588 as that is sometimes allowed. Adjust the file's mode to eliminate
1589 setuid or setgid bits that are inappropriate if fchown fails.
1590
925a6be7
SM
15912011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1592
1593 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1594 to compare Lisp_Objects.
1595 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1596 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1597 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1598
52968808
AS
15992011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1600
0a6a104b
AS
1601 * lread.c (read_integer): Unread even EOF character.
1602 (read1): Likewise. Properly record start position of symbol.
1603
52968808
AS
1604 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1605 symbol character follows.
1606
9e381cdd
PE
16072011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1608
1609 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1610 This works around a problem with the previous change to Fcopy_file.
1611 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1612 and without this change, GCC might complain about discarding
1613 fchown's return value.
1614
b5641435
JB
16152011-07-16 Juanma Barranquero <lekktu@gmail.com>
1616
1617 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1618
a8031457
PE
16192011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1620
1621 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1622
dd889327
LMI
16232011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1624
750c33f7
LMI
1625 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1626 it's used from the C level.
1627
dd889327
LMI
1628 * process.c: Use the same condition for POLL_FOR_INPUT in both
1629 keyboard.c and process.c (bug#1858).
1630
87e86684
LM
16312011-07-09 Lawrence Mitchell <wence@gmx.li>
1632
1633 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1634 (Fgnutls_boot): Use it.
1635
64348f40
AS
16362011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1637
1638 * doc.c (Fsubstitute_command_keys): Revert last change.
1639
1d698799
LMI
16402011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1641
f863868c
LMI
1642 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1643 quotes the next character, and doesn't affect other longer
1644 sequences (bug#8935).
1645
1d698799
LMI
1646 * lread.c (syms_of_lread): Clarify that is isn't only
1647 `eval-buffer' and `eval-defun' that's affected by
1648 `lexical-binding' (bug#8460).
1649
aa4b6df6
EZ
16502011-07-15 Eli Zaretskii <eliz@gnu.org>
1651
1652 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1653 bidi redisplay when a line includes both an image and is
1654 truncated.
1655
5d856da6
PE
16562011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1657
ad6042bb
PE
1658 Fix minor problems found by static checking.
1659 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1660 (elsz): Now a signed constant, not a size_t var. We prefer signed
1661 types to unsigned, to avoid integer comparison confusion. Without
1662 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1663 "cannot optimize loop, the loop counter may overflow", a symptom
1664 of the confusion.
f00bbb22 1665 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1666 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1667
6468f31c
LMI
16682011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1669
49080b10
LMI
1670 * search.c (Fre_search_backward): Mention `case-fold-search' in
1671 all the re_search_* functions (bug#8138).
1672
6468f31c
LMI
1673 * keyboard.c (Fopen_dribble_file): Document when the file is
1674 closed (bug#8056).
1675
c965adc5
EZ
16762011-07-14 Eli Zaretskii <eliz@gnu.org>
1677
df9733bf
EZ
1678 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1679 bidi_cache_idx.
1680
0bb23927
EZ
1681 Support bidi reordering of display and overlay strings.
1682 * xdisp.c (compute_display_string_pos)
1683 (compute_display_string_end): Accept additional argument STRING.
1684 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1685 (reseat_to_string): Initialize bidi_it->string.s and
1686 bidi_it->string.schars.
1687 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1688 NULL (avoids a crash in bidi_paragraph_init).
1689 Initialize itb.string.lstring.
0bb23927
EZ
1690 (init_iterator): Call bidi_init_it only of a valid
1691 buffer position was specified. Initialize paragraph_embedding to
1692 L2R.
1693 (reseat_to_string): Initialize the bidi iterator.
1694 (display_string): If we need to ignore text properties of
1695 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1696 original value of -1 will not work with bidi.)
1697 (compute_display_string_pos): First arg is now struct
1698 `text_pos *'; all callers changed. Support display properties on
1699 Lisp strings.
1700 (compute_display_string_end): Support display properties on Lisp
1701 strings.
1702 (init_iterator, reseat_1, reseat_to_string): Initialize the
1703 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1704 when iterating on a string not from display properties).
640c8776
SM
1705 (compute_display_string_pos, compute_display_string_end):
1706 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1707 arrow keys.
1708 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1709 base_level_stop; instead, set base_level_stop to BEGV.
1710 Fixes crashes in vertical-motion.
0bb23927
EZ
1711 (next_element_from_buffer): Improve commentary for when
1712 the iterator is before prev_stop.
1713 (init_iterator): Initialize bidi_p from the default value of
1714 bidi-display-reordering, not from buffer-local value. Use the
1715 buffer-local value only if initializing for buffer iteration.
1716 (handle_invisible_prop): Support invisible properties on strings
1717 that are being bidi-reordered.
1718 (set_iterator_to_next): Support bidi reordering of C strings and
1719 Lisp strings.
1720 (next_element_from_string): Support bidi reordering of Lisp
1721 strings.
1722 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1723 (display_string): Support display of R2L glyph rows.
1724 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1725 (init_iterator): Don't initialize it->bidi_p for strings
1726 here.
1727 (reseat_to_string): Initialize it->bidi_p for strings here.
1728 (next_element_from_string, next_element_from_c_string)
1729 (next_element_from_buffer): Add xassert's for correspondence
1730 between IT's object being iterated and it->bidi_it.string
1731 structure.
1732 (face_before_or_after_it_pos): Support bidi iteration.
1733 (next_element_from_c_string): Handle the case of the first string
1734 character that is not the first one in the visual order.
1735 (get_visually_first_element): New function, refactored from common
1736 parts of next_element_from_buffer, next_element_from_string, and
1737 next_element_from_c_string.
1738 (tool_bar_lines_needed, redisplay_tool_bar)
1739 (display_menu_bar): Force left-to-right direction. Add a FIXME
1740 comment for making that be controlled by a user option.
1741 (push_it, pop_it): Save and restore the state of the
1742 bidi iterator. Save and restore the bidi_p flag.
1743 (pop_it): Iterate out of display property for string iteration as
1744 well.
1745 (iterate_out_of_display_property): Support iteration over strings.
1746 (handle_single_display_spec): Set up it->bidi_it for iteration
1747 over a display string, and call bidi_init_it.
1748 (handle_single_display_spec, next_overlay_string)
1749 (get_overlay_strings_1, push_display_prop): Set up the bidi
1750 iterator for displaying display or overlay strings.
1751 (forward_to_next_line_start): Don't use the shortcut if
1752 bidi-iterating.
1753 (back_to_previous_visible_line_start): If handle_display_prop
1754 pushed the iterator stack, restore the internal state of the bidi
1755 iterator by calling bidi_pop_it same number of times.
1756 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1757 and we are bidi-iterating, don't decrement the iterator position;
1758 instead, set the first_elt flag in the bidi iterator, to produce
1759 the same effect.
1760 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1761 (push_display_prop): xassert that we are iterating a buffer.
1762 (push_it, pop_it): Save and restore paragraph_embedding member.
1763 (handle_single_display_spec, next_overlay_string)
1764 (get_overlay_strings_1, reseat_1, reseat_to_string)
1765 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1766 correctly. Don't assume unibyte strings are not bidi-reordered.
1767 (compute_display_string_pos)
1768 (compute_display_string_end): Fix handling the case of C string.
1769 (push_it, pop_it): Save and restore from_disp_prop_p.
1770 (handle_single_display_spec, push_display_prop): Set the
1771 from_disp_prop_p flag.
1772 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1773 (pop_it): Call iterate_out_of_display_property only if we are
1774 popping after iteration over a string that came from a display
1775 property. Fix a typo in popping stretch info. Add an assertion
1776 for verifying that the iterator position is in sync with the bidi
1777 iterator.
1778 (handle_single_display_spec, get_overlay_strings_1)
1779 (push_display_prop): Fix initialization of paragraph direction for
1780 string when that of the parent object is not yet determined.
1781 (reseat_1): Call bidi_init_it to resync the bidi
1782 iterator with IT's position. (Bug#7616)
1783 (find_row_edges): If ROW->start.pos gives position
1784 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1785 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1786 Reset the from_disp_prop_p flag.
1787 (SAVE_IT, RESTORE_IT): New macros.
1788 (pos_visible_p, face_before_or_after_it_pos)
1789 (back_to_previous_visible_line_start)
1790 (move_it_in_display_line_to, move_it_in_display_line)
1791 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1792 (try_scrolling, redisplay_window, display_line): Use them when
1793 saving a temporary copy of the iterator and restoring it back.
1794 (back_to_previous_visible_line_start, reseat_1)
1795 (init_iterator): Empty the bidi cache "stack".
1796 (move_it_in_display_line_to): If iterator ended up at
1797 EOL, but we never saw any buffer positions smaller than
1798 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1799 motion in bidi-reordered lines.
1800 (move_it_in_display_line_to): Record prev_method and prev_pos
1801 immediately before the call to set_iterator_to_next. Fixes cursor
1802 motion in bidi-reordered lines with stretch glyphs and strings
1803 displayed in margins. (Bug#8133) (Bug#8867)
1804 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1805 TO_CHARPOS.
640c8776
SM
1806 (pos_visible_p): Support positions in bidi-reordered lines.
1807 Save and restore bidi cache.
0bb23927
EZ
1808
1809 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1810 (bidi_paragraph_info): Delete unused struct.
1811 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1812 (bidi_cache_start): New variable.
1813 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1814 to zero.
1815 (bidi_cache_fetch_state, bidi_cache_search)
1816 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1817 (bidi_cache_find, bidi_peek_at_next_level)
1818 (bidi_level_of_next_char, bidi_find_other_level_edge)
1819 (bidi_move_to_visually_next): Compare cache index with
1820 bidi_cache_start rather than with zero.
1821 (bidi_fetch_char): Accept new argument STRING; all callers
1822 changed. Support iteration over a string. Support strings with
1823 display properties. Support unibyte strings. Fix the type of
1824 `len' according to what STRING_CHAR_AND_LENGTH expects.
1825 (bidi_paragraph_init, bidi_resolve_explicit_1)
1826 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1827 (bidi_level_of_next_char, bidi_move_to_visually_next):
1828 Support iteration over a string.
0bb23927
EZ
1829 (bidi_set_sor_type, bidi_resolve_explicit_1)
1830 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1831 can now be zero (for strings); special values 0 and -1 were
1832 changed to -1 and -2, respectively.
1833 (bidi_char_at_pos): New function.
1834 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1835 Call it instead of FETCH_MULTIBYTE_CHAR.
1836 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1837 initialized to valid values.
1838 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1839 values.
1840 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1841 the test for valid cached positions. Fix the logic for looking up
1842 the sentinel state in the cache. GCPRO the Lisp string we are
1843 iterating.
1844 (bidi_push_it, bidi_pop_it): New functions.
1845 (bidi_initialize): Initialize the bidi cache start stack pointer.
1846 (bidi_cache_ensure_space): New function, refactored from part of
1847 bidi_cache_iterator_state. Don't assume the required size is just
1848 one BIDI_CACHE_CHUNK away.
1849 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1850 (bidi_count_bytes, bidi_char_at_pos): New functions.
1851 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1852 always valid if bidi_cache_idx is valid.
1853 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1854 is valid if it's going to be used.
1855 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1856 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1857 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1858 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1859 (bidi_find_other_level_edge, bidi_cache_start_stack):
1860 All variables related to cache indices are now EMACS_INT.
c965adc5 1861
0bb23927
EZ
1862 * dispextern.h (struct bidi_string_data): New structure.
1863 (struct bidi_it): New member `string'. Make flag members be 1-bit
1864 fields, and put them last in the struct.
640c8776
SM
1865 (compute_display_string_pos, compute_display_string_end):
1866 Update prototypes.
0bb23927
EZ
1867 (bidi_push_it, bidi_pop_it): Add prototypes.
1868 (struct iterator_stack_entry): New members bidi_p,
1869 paragraph_embedding, and from_disp_prop_p.
1870 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1871 (bidi_shelve_cache, bidi_unshelve_cache):
1872 Declare prototypes.
0bb23927
EZ
1873
1874 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1875 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1876 and vector-like objects.
1877
1878 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1879 cache around display iteration.
1880
1881 * window.c (Fwindow_end, window_scroll_pixel_based)
1882 (displayed_window_lines, Frecenter): Save and restore the bidi
1883 cache around display iteration.
1884
3bbd2265
LMI
18852011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1886
1887 * editfns.c (Fdelete_region): Clarify the use of the named
1888 parameters (bug#6788).
1889
adc47434
MR
18902011-07-14 Martin Rudalics <rudalics@gmx.at>
1891
1892 * indent.c (Fvertical_motion): Set and restore w->pointm when
1893 saving and restoring the window's buffer (Bug#9006).
1894
837c31f8
LMI
18952011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1896
1897 * editfns.c (Fstring_to_char): Clarify just what is returned
1898 (bug#6576). Text by Eli Zaretskii.
1899
ac389d0c
JB
19002011-07-13 Juanma Barranquero <lekktu@gmail.com>
1901
1902 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1903
0be0ce47
EZ
19042011-07-13 Eli Zaretskii <eliz@gnu.org>
1905
1906 * buffer.c (mmap_find): Fix a typo.
1907
cd18e7e3
JB
19082011-07-13 Johan Bockgård <bojohan@gnu.org>
1909
1910 Fix execution of x selection hooks.
1911 * xselect.c (Qx_lost_selection_functions)
1912 (Qx_sent_selection_functions): New vars.
1913 (syms_of_xselect): DEFSYM them.
1914 (x_handle_selection_request): Pass Qx_sent_selection_functions
1915 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1916 (x_handle_selection_clear,x_clear_frame_selections):
1917 Pass Qx_lost_selection_functions rather than
1918 Vx_lost_selection_functions to Frun_hook_with_args.
1919
47ea7f44
PE
19202011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1921
ac389d0c 1922 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1923 The old code sometimes used this field without initializing it.
1924
47ea7f44
PE
1925 * alloc.c (gc_sweep): Don't read past end of array.
1926 In theory, the old code could also have corrupted Emacs internals,
1927 though it'd be very unlikely.
1928
bc985c87
AS
19292011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1930
1931 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1932 argument. (Bug#4026)
bc985c87 1933
0cf34688
LMI
19342011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1935
b3dadd76
LMI
1936 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1937 key" (bug#4257).
1938
0cf34688
LMI
1939 * window.c (Fset_window_start): Doc fix (bug#4199).
1940 (Fset_window_hscroll): Ditto.
1941
270768cd
PE
19422011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1943
077e3dda 1944 Fix minor new problems caught by GCC 4.6.1.
270768cd 1945 * term.c (init_tty): Remove unused local.
490011a6 1946 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1947 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1948 not used otherwise.
270768cd 1949
b1f58454
CY
19502011-07-12 Chong Yidong <cyd@stupidchicken.com>
1951
1952 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1953
22b9578d
LMI
19542011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1955
6e70ab07
LMI
1956 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1957 are the mini-buffer and the echo area (bug#3320).
1958
22b9578d
LMI
1959 * term.c (init_tty): Remove support for supdup, c10 and perq
1960 terminals, which are no longer supported (bug#1482).
1961
8974cc9f
JB
19622011-07-10 Johan Bockgård <bojohan@gnu.org>
1963
1964 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1965
a560d974
JD
19662011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1967
1968 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1969 for non-popups (Bug#3642).
1970
1dae0f0a
AS
19712011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1972
268c2c36 1973 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1974 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1975 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1976 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1977 * data.c (fmod): Likewise.
1978 * dispnew.c (swap_glyphs_in_rows): Likewise.
1979 * emacs.c (memory_warning_signal): Likewise.
1980 * floatfns.c (float_error): Likewise.
1981 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1982 (otf_open, font_otf_capability, generate_otf_features)
1983 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1984 Likewise.
1985 * image.c (pbm_read_file): Likewise.
1986 * indent.c (string_display_width): Likewise.
1987 * intervals.c (check_for_interval, search_for_interval)
1988 (inc_interval_count, count_intervals, root_interval)
1989 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1990 * lread.c (defalias): Likewise.
268c2c36 1991 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1992 * regex.c (set_image_of_range_1, set_image_of_range)
1993 (regex_grow_registers): Likewise.
1994 * sysdep.c (strerror): Likewise.
1995 * termcap.c (valid_filename_p, tprint, main): Likewise.
1996 * tparam.c (main): Likewise.
1997 * unexhp9k800.c (run_time_remap, save_data_space)
1998 (update_file_ptrs, read_header, write_header, calculate_checksum)
1999 (copy_file, copy_rest, display_header): Likewise.
2000 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2001 Likewise.
2002 * xdisp.c (check_it): Likewise.
2003 * xfaces.c (register_color, unregister_color, unregister_colors):
2004 Likewise.
2005 * xfns.c (print_fontset_result): Likewise.
2006 * xrdb.c (member, fatal, main): Likewise.
2007
99033785
PE
20082011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2009
2010 Fix minor problems found by static checking (Bug#9031).
2011 * chartab.c (char_table_set_range, map_sub_char_table):
2012 Remove unused locals.
2013 (uniprop_table): Now static.
2014 * composite.c (_work_char): Remove unused static var.
2015
9cb2ac56
JB
20162011-07-09 Juanma Barranquero <lekktu@gmail.com>
2017
2018 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2019
f25661f0
JD
20202011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2021
2022 * gtkutil.c (qttip_cb): Remove code without function.
2023
8278c4fe
EZ
20242011-07-09 Eli Zaretskii <eliz@gnu.org>
2025
2026 * w32.c (pthread_sigmask): New stub.
2027
1692ae2d 20282011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2029
8a6ebd58 2030 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2031 sigprocmask is portable only for single-threaded applications, and
2032 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2033 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2034 (LIBES): Use it.
2035 * callproc.c (Fcall_process):
2036 * process.c (create_process):
2037 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2038 Use pthread_sigmask, not sigprocmask.
123403e4 2039
1b854618
JD
20402011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2041
2042 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2043 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2044 wrong (Bug#8591).
2045
3fe4b549
JD
20462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2047
0ce7e563
JD
2048 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2049 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2050 (xg_hide_tooltip): Fix comment.
2051
3fe4b549
JD
2052 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2053 in registerServicesMenuSendTypes.
2054 (validRequestorForSendType): Don't check ns_return_types.
2055
2056 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2057 ns_return_type.
2058
5df75e47
JR
20592011-07-08 Jason Rumney <jasonr@gnu.org>
2060
2061 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2062 frame struct members of non-existent frames (Bug#6284).
2063
699c10bd
JD
20642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2065
4393663b
JD
2066 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2067 variable firstTime not needed on OSX >= 10.6.
2068 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2069 >= 10.5. Use setKnobProportion, setDoubleValue.
2070
2071 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2072 (MAC_OS_X_VERSION_10_5): Define if not defined.
2073 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2074 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2075 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2076
2077 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2078 cString and lossyCString on OSX >= 10.4
2079
2080 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2081 sizeToFit on OSX >= 10.2.
2082
2083 * nsimage.m (allocInitFromFile): Don't use deprecated method
2084 bestRepresentationForDevice on OSX >= 10.6.
2085
2086 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2087 to avoid warning.
2088
2089 * emacs.c: Declare unexec_init_emacs_zone.
2090
a63e0781
JD
2091 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2092
699c10bd
JD
2093 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2094
2095 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2096 on svcsMenu (Bug#8842).
2097
2098 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2099 ns_return_types.
2100 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2101
2102 * nsterm.m (QUTF8_STRING): Declare.
2103 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2104 (validRequestorForSendType): Return type is (id).
2105 Change indexOfObjectIdenticalTo to indexOfObject.
2106 Check if we have local selection before returning self (Bug#8842).
2107 (writeSelectionToPasteboard): Put local selection into paste board
2108 if we have a local selection (Bug#8842).
2109 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2110
2111 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2112 (ns_get_local_selection): Declare.
2113
54e10184
LMI
21142011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2115
9888ff71
LMI
2116 * keymap.c (describe_map_tree): Don't insert a double newline at
2117 the end of the buffer (bug#1169) and return whether we inserted
2118 something.
2119
54e10184
LMI
2120 * callint.c (Fcall_interactively): Change "reading args" to
2121 "providing args" to try to clarify what it does (bug#1010).
2122
15fa4783
KH
21232011-07-07 Kenichi Handa <handa@m17n.org>
2124
2125 * composite.c (composition_compute_stop_pos): Ignore a static
2126 composition starting before CHARPOS (Bug#8915).
2127
2128 * xdisp.c (handle_composition_prop): Likewise.
2129
a8815b00
EZ
21302011-07-07 Eli Zaretskii <eliz@gnu.org>
2131
2132 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2133 (Bug#9015)
2134
ef7b981d 21352011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2136
2137 * character.h (unicode_category_t): New enum type.
2138
2139 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2140 (Qchar_code_property_table): New variable.
2141 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2142 (UNIPROP_COMPRESSED_FORM_P): New macros.
2143 (char_table_ascii): Uncompress the compressed values.
2144 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2145 Uncompress the compressed values.
ac389d0c 2146 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2147 (char_table_ref_and_range): Uncompress the compressed values.
2148 (sub_char_table_set): New arg is_uniprop. Callers changed.
2149 Uncompress the compressed values.
2150 (sub_char_table_set_range): Args changed. Callers changed.
2151 (char_table_set_range): Adjuted for the above change.
2152 (map_sub_char_table): Delete args default_val and parent. Add arg
2153 top. Give decoded values to a Lisp function.
640c8776 2154 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2155 values to a Lisp function. Gcpro more variables.
2156 (uniprop_table_uncompress)
2157 (uniprop_decode_value_run_length): New functions.
2158 (uniprop_decoder, uniprop_decoder_count): New variables.
2159 (uniprop_get_decoder, uniprop_encode_value_character)
2160 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2161 New functions.
2162 (uniprop_encoder, uniprop_encoder_count): New variables.
2163 (uniprop_get_encoder, uniprop_table)
2164 (Funicode_property_table_internal, Fget_unicode_property_internal)
2165 (Fput_unicode_property_internal): New functions.
2166 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2167 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2168 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2169 char-code-property-alist.
2170
640c8776 2171 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2172 Vunicode_category_table.
2173
640c8776 2174 * font.c (font_range): Adjust for the change of
c805dec0
KH
2175 Vunicode_category_table.
2176
76b397fb
DN
21772011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2178
2179 * m/iris4d.h: Remove file, move contents ...
2180 * s/irix6-5.h: ... here.
2181
22b4128e
PE
21822011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2183
2184 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2185 * alloc.c (mark_buffer):
2186 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2187 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2188 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2189 This isn't true in general, and it's particularly not true
2190 if Emacs is configured with --with-wide-int.
2191 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2192 New macros, used in the buffer.c change.
2193
869795d6
JD
21942011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2195
2196 * xsettings.c: Use both GConf and GSettings if both are available.
2197 (store_config_changed_event): Add comment.
2198 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2199 (store_tool_bar_style_changed): New functions.
5e617bc2 2200 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2201 (struct xsettings): Move font inside HAVE_XFT.
2202 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2203 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2204 Move inside HAVE_XFT.
640c8776 2205 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2206 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2207 also.
2208 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2209 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2210 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2211 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2212 (parse_settings): Move check for font inside HAVE_XFT.
2213 (read_settings, apply_xft_settings): Add comment.
2214 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2215 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2216 call store_font_name_changed.
2217 (xft_settings_event): Add comment.
2218 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2219 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2220 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2221 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2222 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2223 (xsettings_get_system_font, xsettings_get_system_normal_font):
2224 Add comment.
869795d6 2225
d8ed26bd
PE
22262011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2227
2228 Random fixes. E.g., (random) never returned negative values.
2229 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2230 subseconds part to the entropy, as that's a bit more random.
2231 Prefer signed to unsigned, since the signedness doesn't matter and
2232 in general we prefer signed. When given a limit, use a
2233 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2234 latter isn't right if USE_2_TAGS_FOR_INTS.
2235 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2236 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2237
cabf1cac
SM
22382011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2239
2240 * textprop.c (text_property_stickiness):
2241 Obey Vtext_property_default_nonsticky.
2242 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2243 * w32fns.c (syms_of_w32fns):
2244 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2245
6e9b2be9
PE
22462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2247
2248 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2249 This is more efficient than Ffile_directory_p and avoids a minor race.
2250
90186c68
LMI
22512011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2252
7c301272
LMI
2253 * buffer.c (Foverlay_put): Say what the return value is
2254 (bug#7835).
2255
c4f2d8d4
LMI
2256 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2257 is a directory before asking whether to use the file name
2258 (bug#7564).
ad637907
LMI
2259 (barf_or_query_if_file_exists): Make the "File is a directory"
2260 error be more correct.
c4f2d8d4 2261
90186c68
LMI
2262 * fns.c (Frequire): Remove the mention of the .gz files, since
2263 that's installation-specific, but keep the mention of
2264 `get-load-suffixes'.
2265
da64016e
PE
22662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2267
2268 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2269 Report string overflow if the output is too long.
2270
7d47b580
JB
22712011-07-04 Juanma Barranquero <lekktu@gmail.com>
2272
a555cb87
JB
2273 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2274 (syms_of_gnutls): Remove duplicate DEFSYM for
2275 Qgnutls_bootprop_verify_hostname_error, an error for
2276 Qgnutls_bootprop_verify_error (which is no longer used).
2277
7d47b580
JB
2278 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2279 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2280 Also (re)move comments that are misplaced or no longer relevant.
2281
1e49bfab
LMI
22822011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2283
2284 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2285
1485f4c0
CY
22862011-07-03 Chong Yidong <cyd@stupidchicken.com>
2287
2288 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2289 and background color parameters if they have been changed.
2290
a9ab721e
LMI
22912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2292
2293 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2294
cf7cff57
PE
22952011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2296
2e13213d
PE
2297 * xsettings.c (SYSTEM_FONT): Define only when used.
2298 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2299
cf7cff57
PE
2300 * keymap.c (access_keymap_1): Now static.
2301
7a8e04f7
CY
23022011-07-02 Chong Yidong <cyd@stupidchicken.com>
2303
2304 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2305 leave any prefix arg for the up event (Bug#1586).
2306
61352f62
LMI
23072011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2308
69bb1ef7
LMI
2309 * lread.c (syms_of_lread): Mention single symbols defined by
2310 `defvar' or `defconst' (bug#7154).
2311
61352f62 2312 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2313 (Frequire): Mention get-load-suffixes.
61352f62 2314
28545e04
MR
23152011-07-02 Martin Rudalics <rudalics@gmx.at>
2316
2317 * window.h (window): Remove clone_number slot.
2318 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2319 Remove.
2320 (make_parent_window, make_window, saved_window)
2321 (Fset_window_configuration, save_window_save): Don't deal with
2322 clone numbers.
2323 * buffer.c (Qclone_number): Remove declaration.
2324 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2325
3349e122
SM
23262011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2327
2328 Add multiple inheritance to keymaps.
2329 * keymap.c (Fmake_composed_keymap): New function.
2330 (Fset_keymap_parent): Simplify.
2331 (fix_submap_inheritance): Remove.
2332 (access_keymap_1): New function extracted from access_keymap to handle
2333 embedded parents and handle lists of maps.
2334 (access_keymap): Use it.
2335 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2336 (Fcopy_keymap): Handle embedded parents.
2337 (Fcommand_remapping, define_as_prefix): Simplify.
2338 (Fkey_binding): Simplify.
2339 (syms_of_keymap): Move minibuffer-local-completion-map,
2340 minibuffer-local-filename-completion-map,
2341 minibuffer-local-must-match-map, and
2342 minibuffer-local-filename-must-match-map to Elisp.
2343 (syms_of_keymap): Defsubr make-composed-keymap.
2344 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2345 (parse_menu_item): Trivial simplification.
2346
3279eb87
GM
23472011-07-01 Glenn Morris <rgm@gnu.org>
2348
2349 * Makefile.in (SETTINGS_LIBS): Fix typo.
2350
4550efdf
KI
23512011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2352
2353 * coding.c (Fencode_coding_string): Record the last coding system
2354 used, as the function doc string says (bug#8738).
2355
0949d2b6
JD
23562011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2357
2358 * xsettings.c (store_monospaced_changed): Take new font as arg and
2359 check for change against current_mono_font.
2360 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2361 (emacs_settings_constructor, emacs_settings_get_property)
2362 (emacs_settings_set_property, emacs_settings_class_init)
2363 (emacs_settings_init, gsettings_obj): Remove.
2364 (something_changedCB): New function for HAVE_GSETTINGS.
2365 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2366 with value as argument.
2367 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2368 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2369 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2370 "changed".
2371
2372 * xgselect.c: Add defined (HAVE_GSETTINGS).
2373 (xgselect_initialize): Ditto.
2374
2375 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2376 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2377 xg_select.
2378
bbc6b304
PE
23792011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2380
2381 * eval.c (struct backtrace): Simplify and port the data structure.
2382 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2383 signed bit field, as this assumption is not portable and it makes
2384 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2385 "char debug_on_exit : 1" as this is not portable either; instead,
2386 use the portable "unsigned int debug_on_exit : 1". Remove unused
2387 member evalargs. Remove obsolete comments about cc bombing out.
2388
9851bfc5
JD
23892011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2390
51bb811f 2391 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2392 Let HAVE_GSETTINGS override HAVE_GCONF.
2393 (store_monospaced_changed): New function.
2394 (EMACS_SETTINGS): A new type derived from GObject to handle
2395 GSettings notifications.
2396 (emacs_settings_constructor, emacs_settings_get_property)
2397 (emacs_settings_set_property, emacs_settings_class_init):
2398 New functions.
2399 (gsettings_client, gsettings_obj): New variables.
2400 (GSETTINGS_SCHEMA): New define.
2401 (something_changedCB): Call store_monospaced_changed.
2402 (init_gsettings): New function.
2403 (xsettings_initialize): Call init_gsettings.
2404 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2405 to NULL.
2406
640c8776 2407 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2408 GCONF_CFLAGS/LIBS.
2409
5386012d
MR
24102011-06-29 Martin Rudalics <rudalics@gmx.at>
2411
2412 * window.c (resize_root_window, grow_mini_window)
2413 (shrink_mini_window): Rename Qresize_root_window to
2414 Qwindow_resize_root_window and Qresize_root_window_vertically to
2415 Qwindow_resize_root_window_vertically.
2416
f13e0b08
PE
24172011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2418
2419 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2420
94515237
JB
24212011-06-27 Juanma Barranquero <lekktu@gmail.com>
2422
2423 * makefile.w32-in: Redesign dependencies so they reflect more
2424 clearly which files are directly included by each source file,
2425 and not through other includes.
2426
e43b6e43
MR
24272011-06-27 Martin Rudalics <rudalics@gmx.at>
2428
2429 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2430 (sort_overlays, overlay_strings): When an overlay's clone number
2431 matches the window's clone number process the overlay even if
2432 the overlay's window property doesn't match the current window.
2433
d68443dc
MR
2434 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2435 (Fwindow_hchild): Rename to Fwindow_left_child.
2436 (Fwindow_next): Rename to Fwindow_next_sibling.
2437 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2438 (resize_window_check): Rename to window_resize_check.
2439 (resize_window_apply): Rename to window_resize_apply.
2440 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2441 (Fdelete_other_windows_internal, resize_frame_windows)
2442 (Fsplit_window_internal, Fdelete_window_internal)
2443 (grow_mini_window, shrink_mini_window)
2444 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2445
c7e73be5
JD
24462011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2447
2448 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2449 (emacs_fixed_set_min_size): Remove.
2450 (emacs_fixed_new): Take frame as argument.
2451
2452 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2453 (_EmacsFixedPrivate): Remove minwidth/height.
2454 Add struct frame *f.
2455 (emacs_fixed_init): Initialize priv->f.
2456 (get_parent_class, emacs_fixed_set_min_size): Remove.
2457 (emacs_fixed_new): Set priv->f to argument.
2458 (emacs_fixed_get_preferred_width)
2459 (emacs_fixed_get_preferred_height): Use min_width/height from
2460 frames size_hint to set minimum and natural (Bug#8919).
2461 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2462 and use min_width/height from frames size_hint to set
2463 min_width/height (Bug#8919).
2464
2465 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2466 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2467 Fix indentation.
c7e73be5 2468
cf99dcf8
EZ
24692011-06-26 Eli Zaretskii <eliz@gnu.org>
2470
2471 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2472 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2473 called at ZV.
2474
029529ac
CY
24752011-06-26 Chong Yidong <cyd@stupidchicken.com>
2476
2477 * process.c (wait_reading_process_output): Bypass select if
2478 waiting for a cell while ignoring keyboard input, and input is
2479 pending. Suggested by Jan Djärv (Bug#8869).
2480
7a7ef429
PE
24812011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2482
2483 Use gnulib's dup2 module instead of rolling our own.
2484 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2485
11fdef7d 24862011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2487
2488 * dispnew.c (scrolling_window): Before scrolling, turn off a
2489 mouse-highlight in the window being scrolled.
2490
cd3520a4
JB
24912011-06-24 Juanma Barranquero <lekktu@gmail.com>
2492
2493 Move DEFSYM to lisp.h and use everywhere.
2494
2495 * character.h (DEFSYM): Move declaration...
2496 * lisp.h (DEFSYM): ...here.
2497
2498 * gnutls.c:
2499 * minibuf.c:
2500 * w32menu.c:
2501 * w32proc.c:
2502 * w32select.c: Don't include character.h.
2503
2504 * alloc.c (syms_of_alloc):
2505 * buffer.c (syms_of_buffer):
2506 * bytecode.c (syms_of_bytecode):
2507 * callint.c (syms_of_callint):
2508 * casefiddle.c (syms_of_casefiddle):
2509 * casetab.c (init_casetab_once):
2510 * category.c (init_category_once, syms_of_category):
2511 * ccl.c (syms_of_ccl):
2512 * cmds.c (syms_of_cmds):
2513 * composite.c (syms_of_composite):
2514 * dbusbind.c (syms_of_dbusbind):
2515 * dired.c (syms_of_dired):
2516 * dispnew.c (syms_of_display):
2517 * doc.c (syms_of_doc):
2518 * editfns.c (syms_of_editfns):
2519 * emacs.c (syms_of_emacs):
2520 * eval.c (syms_of_eval):
2521 * fileio.c (syms_of_fileio):
2522 * fns.c (syms_of_fns):
2523 * frame.c (syms_of_frame):
2524 * fringe.c (syms_of_fringe):
2525 * insdel.c (syms_of_insdel):
2526 * keymap.c (syms_of_keymap):
2527 * lread.c (init_obarray, syms_of_lread):
2528 * macros.c (syms_of_macros):
2529 * msdos.c (syms_of_msdos):
2530 * print.c (syms_of_print):
2531 * process.c (syms_of_process):
2532 * search.c (syms_of_search):
2533 * sound.c (syms_of_sound):
2534 * syntax.c (init_syntax_once, syms_of_syntax):
2535 * terminal.c (syms_of_terminal):
2536 * textprop.c (syms_of_textprop):
2537 * undo.c (syms_of_undo):
2538 * w32.c (globals_of_w32):
2539 * window.c (syms_of_window):
2540 * xdisp.c (syms_of_xdisp):
2541 * xfaces.c (syms_of_xfaces):
2542 * xfns.c (syms_of_xfns):
2543 * xmenu.c (syms_of_xmenu):
2544 * xsettings.c (syms_of_xsettings):
2545 * xterm.c (syms_of_xterm): Use DEFSYM.
2546
4228cf16
TZ
25472011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2548
cd3520a4 2549 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2550
7fcccf1e
PE
25512011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2552
7efb4e0e
PE
2553 Integer and buffer overflow fixes (Bug#8873).
2554
ff5844ad
PE
2555 * print.c (printchar, strout): Check for string overflow.
2556 (PRINTPREPARE, printchar, strout):
2557 Don't set size unless allocation succeeds.
2558
90532f02
PE
2559 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2560 for sizes. Check for string overflow more accurately.
2561 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2562
6d84508d
PE
2563 * macros.c: Integer and buffer overflow fixes.
2564 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2565 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2566 Use ptrdiff_t, not int, for sizes.
2567 Don't increment bufsize until after realloc succeeds.
2568 Check for size-calculation overflow.
2569 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2570
437b2cb4
PE
2571 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2572
8b9ac8b4
PE
2573 * lread.c: Integer overflow fixes.
2574 (read_integer): Radix is now EMACS_INT, not int,
2575 to improve quality of diagnostics for out-of-range radices.
2576 Calculate buffer size correctly for out-of-range radices.
2577 (read1): Check for integer overflow in radices, and in
2578 read-circle numbers.
82cb60d3
PE
2579 (read_escape): Avoid int overflow.
2580 (Fload, openp, read_buffer_size, read1)
2581 (substitute_object_recurse, read_vector, read_list, map_obarray):
2582 Use ptrdiff_t, not int, for sizes.
2583 (read1): Use EMACS_INT, not int, for sizes.
20270765 2584 Check for size overflow.
8b9ac8b4 2585
7fcccf1e
PE
2586 * image.c (cache_image): Check for size arithmetic overflow.
2587
bfbbd7e7
PE
2588 * lread.c: Integer overflow issues.
2589 (saved_doc_string_size, saved_doc_string_length)
2590 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2591 Now ptrdiff_t, not int.
2592 (read1): Don't assume doc string length fits in int. Check for
2593 out-of-range doc string lengths.
2594 (read_list): Don't assume file position fits in int.
39019e54 2595 (read_escape): Check for hex character overflow.
bfbbd7e7 2596
4e323265
LL
25972011-06-22 Leo Liu <sdl.web@gmail.com>
2598
2599 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2600 Move to minibuffer.el.
2601
85fece3e
PE
26022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2603
20b84ce9 2604 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2605 The following patches are for when GLYPH_DEBUG && !XASSERT.
2606 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2607 * dispnew.c (flush_stdout):
2608 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2609 Mark as externally visible.
2610 * dispnew.c (check_window_matrix_pointers): Now static.
2611 * dispnew.c (window_to_frame_vpos):
2612 * xfns.c (unwind_create_frame):
2613 * xterm.c (x_check_font): Remove unused local.
2614 * scroll.c (CHECK_BOUNDS):
2615 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2616 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2617 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2618 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2619 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2620 Now static.
2621 (debug_method_add): Use va_list and vsprintf rather than relying
2622 on undefined behavior with wrong number of arguments.
2623 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2624 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2625 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2626 since we're not interested in debugging glyphs with old libraries.
2627 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2628 GCC 4.6.0's static checking.
2629
0766b489
PE
26302011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2631
31fd4b32
PE
2632 Integer overflow and signedness fixes (Bug#8873).
2633 A few related buffer overrun fixes, too.
2634
b79e8648
PE
2635 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2636
0766b489
PE
2637 * dispextern.h (struct face.stipple):
2638 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2639 (x_bitmap_mask, x_allocate_bitmap_record)
2640 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2641 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2642 (x_create_bitmap_from_xpm_data):
2643 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2644 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2645 (.bitmaps_last):
2646 * xfaces.c (load_pixmap):
2647 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2648 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2649 (.bitmaps_last, struct x_output.icon_bitmap):
2650 Use ptrdiff_t, not int, for bitmap indexes.
2651 (x_allocate_bitmap_record): Check for size overflow.
2652 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2653
b081724f
PE
2654 Use ptrdiff_t, not int, for overlay counts.
2655 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2656 * editfns.c (overlays_around, get_pos_property):
2657 * textprop.c (get_char_property_and_overlay):
2658 * xdisp.c (next_overlay_change, note_mouse_highlight):
2659 * xfaces.c (face_at_buffer_position):
21514da7
PE
2660 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2661 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2662 (Fnext_overlay_change, Fprevious_overlay_change)
2663 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2664 Use ptrdiff_t, not int, for sizes.
21514da7 2665 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2666
3de73e5e
PE
2667 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2668
2606c57b
PE
2669 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2670 (x_session_initialize): Do not assume string length fits in int.
2671
aaafe47a
PE
2672 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2673 This is unlikely, but can occur if DPI is outlandish.
2674
2674ddc8 2675 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2676 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2677
28154962
PE
2678 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2679 * xrdb.c (magic_file_p, search_magic_path):
2680 Omit last arg SUFFIX; it was always 0. All callers changed.
2681 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2682
7de51af5
PE
2683 * xfont.c (xfont_match): Avoid need for strlen.
2684
25ed6cc3
PE
2685 * xfns.c: Don't assume strlen fits in int.
2686 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2687
4eab31dd
PE
2688 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2689 not unsigned long, as we prefer signed integers. All callers changed.
2690 Detect integer overflow in repeat count.
2691 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2692 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2693
171e2a58
PE
2694 * termcap.c: Don't assume sizes fit in int and never overflow.
2695 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2696 (gobble_line): Check for size-calculation overflow.
2697
ad39faca 2698 * minibuf.c (Fread_buffer):
6e5bb2dc 2699 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2700 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2701 Don't assume string length fits in int.
2702
52c61c22 2703 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2704 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2705
b5b8c9e5
PE
2706 * font.c: Don't assume string length fits in int.
2707 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2708 Use ptrdiff_t, not int.
ccd6111c
PE
2709 (font_intern_prop): Don't assume string length fits in int.
2710 Don't assume integer property fits in fixnum.
2711 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2712
882f0d81 2713 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2714 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2715 Reformulate so as not to need the command string.
2716 Invoke gzip -cd rather than gunzip, as it's more portable.
2717 (lock_info_type, lock_file_1, lock_file):
2718 Don't assume pid_t and time_t fit in unsigned long.
2719 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2720 (current_lock_owner): Prefer signed type for sizes.
2721 Use memcpy, not strncpy, where memcpy is what is really wanted.
2722 Don't assume (via atoi) that time_t and pid_t fit in int.
2723 Check for time_t and/or pid_t out of range, e.g., via a network share.
2724 Don't alloca where an auto var works fine.
2725
93f4cf88
PE
2726 * fileio.c: Fix some integer overflow issues.
2727 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2728 Don't assume string length fits in int.
2729 (directory_file_name): Don't assume string length fits in long.
2730 (make_temp_name): Don't assume pid fits in int, or that its print
2731 length is less than 20.
2732
f3e92b69
PE
2733 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2734
1bfdaf10
PE
2735 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2736
35016e9a
PE
2737 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2738
3d1e65a1
PE
2739 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2740 We prefer signed integers, even for size calculations.
2741
0b963a93
PE
2742 * emacs.c: Don't assume string length fits in 'int'.
2743 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2744 (main): Don't invoke strlen when not needed.
2745
573f4b54
PE
2746 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2747 (XD_DEBUG_MESSAGE): Don't waste a byte.
2748
989f33ba
PE
2749 * callproc.c (getenv_internal_1, getenv_internal)
2750 (Fgetenv_internal):
965d34eb
PE
2751 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2752
e4d29b33
PE
2753 * lread.c (invalid_syntax): Omit length argument.
2754 All uses changed. This doesn't fix a bug, but it simplifies the
2755 code away from its former Hollerith-constant appearance, and it's
2756 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2757 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2758
eb49b136
PE
2759 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2760 This didn't break anything, but it didn't help either.
2761 It's confusing to put a bogus integer in a place where the actual
2762 value does not matter.
9f62aeb1 2763 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2764 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2765
15375a22
PE
2766 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2767 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2768 implementation.
b61cc01c
PE
2769 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2770 We prefer signed types, and the value cannot exceed the EMACS_INT
2771 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2772 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2773 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2774 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2775
53b2623d
PE
2776 * indent.c (sane_tab_width): New function.
2777 (current_column, scan_for_column, Findent_to, position_indentation)
2778 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2779 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2780
51cab52b 2781 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2782
f2ed8a70
PE
2783 * lisp.h (lint_assume): New macro.
2784 * composite.c (composition_gstring_put_cache):
2785 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2786
abe80cc6
PE
2787 * editfns.c, insdel.c:
2788 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2789
b02c740e
PE
2790 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2791
ebc96716
PE
2792 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2793
b4e50fa0 2794 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2795 Use much-faster test for byte-length change.
311d5d7c 2796 Don't assume string byte-length fits in 'int'.
a4cf38e4 2797 Check that character arg fits in 'int'.
85461888 2798 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2799
c0c1ee9f
PE
2800 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2801
a498d7f4
PE
2802 * fns.c (concat): Catch string overflow earlier.
2803 Do not rely on integer wraparound.
2804
51cab52b
PE
2805 * dispextern.h (struct it.overlay_strings_charpos)
2806 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2807 * xdisp.c (forward_to_next_line_start)
2808 (back_to_previous_visible_line_start)
2809 (reseat_at_next_visible_line_start, next_element_from_buffer):
2810 Don't arbitrarily truncate the value of 'selective' to int.
2811
76031fad
PE
2812 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2813
5eb55db9
PE
2814 * composite.c: Don't truncate sizes to 'int'.
2815 (composition_gstring_p, composition_reseat_it)
2816 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2817 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2818 not EMACS_UINT, for indexes.
5eb55db9 2819
0703a717
PE
2820 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2821
d6202519
PE
2822 * buffer.c: Include <verify.h>.
2823 (struct sortvec.priority, struct sortstr.priority):
8961a454 2824 Now EMACS_INT, not int.
c20998a7 2825 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2826 (struct sortstr.size, record_overlay_string)
2827 (struct sortstrlist.size, struct sortlist.used):
2828 Don't truncate size to int.
2829 (record_overlay_string): Check for size-calculation overflow.
d6202519 2830 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2831
d5a19415
JM
28322011-06-22 Jim Meyering <meyering@redhat.com>
2833
029529ac 2834 Don't leak an XBM-image-sized buffer
d5a19415
JM
2835 * image.c (xbm_load): Free the image buffer after using it.
2836
a9041e6c
PE
28372011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2838
2839 Port to Sun C.
2840 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2841 that Sun C diagnosed.
2842 * fns.c (secure_hash): Fix pointer signedness issue.
2843 * intervals.c (static_offset_intervals): New function.
2844 (offset_intervals): Use it.
2845
7f3f739f
LL
28462011-06-21 Leo Liu <sdl.web@gmail.com>
2847
2848 * deps.mk (fns.o):
2849 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2850 sha512.h.
2851
2852 * fns.c (secure_hash): Rename from crypto_hash_function and change
2853 the first arg to accept symbols.
5b66d427 2854 (Fsecure_hash): New primitive.
7f3f739f
LL
2855 (syms_of_fns): New symbols.
2856
76147d94
DD
28572011-06-20 Deniz Dogan <deniz@dogan.se>
2858
2859 * process.c (Fset_process_buffer): Clarify return value in
2860 docstring.
2861
7d7d0045
CY
28622011-06-18 Chong Yidong <cyd@stupidchicken.com>
2863
2864 * dispnew.c (add_window_display_history): Use BVAR.
2865
2866 * xdisp.c (debug_method_add): Use BVAR.
2867 (check_window_end, dump_glyph_matrix, dump_glyph)
2868 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2869
2870 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2871 Likewise.
2872
2873 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2874 check till after the cache is created in init_frame_faces.
2875
ff2bc410
SM
28762011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2877
2878 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2879
28177add
PE
28802011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2881
dd3482fe
PE
2882 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2883 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2884 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2885
393d71f3 2886 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2887 * fileio.c (Finsert_file_contents):
2888 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2889 Remove the old (too-loose) buffer overflow checks.
2890 They weren't needed, since make_gap checks for buffer overflow.
2891 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2892 The old code merely checked for Emacs fixnum overflow, and relied
2893 on undefined (wraparound) behavior. The new code avoids undefined
2894 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2895
2e6813b0 2896 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2897 Tune. Don't use wider integers than needed. Don't use alloca.
2898 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2899
599a9e4f
PE
2900 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2901
99561444
PE
2902 * insdel.c, lisp.h (buffer_overflow): New function.
2903 (insert_from_buffer_1, replace_range, replace_range_2):
2904 * insdel.c (make_gap_larger):
2905 * editfns.c (Finsert_char):
2906 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2907
28177add
PE
2908 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2909
e69dafad
PE
29102011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2911
a7af7fde 2912 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2913
b1c46f02
PE
2914 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2915 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2916
e69dafad
PE
2917 * fileio.c: Don't assume EMACS_INT fits in off_t.
2918 (emacs_lseek): New static function.
2919 (Finsert_file_contents, Fwrite_region): Use it.
2920 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2921
566684ea
PE
2922 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2923
e6966cd6
PE
2924 * fns.c: Don't overflow int when computing a list length.
2925 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2926 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2927 truncation on 64-bit hosts. Check for QUIT every
2928 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2929 faster and is responsive enough.
2930 (Flength): Report an error instead of overflowing an integer.
2931 (Fsafe_length): Return a float if the value is not representable
2932 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2933 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2934 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2935
dd0b0efb
PE
2936 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2937 (header_size, word_size): New constants.
2938 (allocate_vectorlike): Don't check size overflow here.
2939 (allocate_vector): Check it here instead, since this is the only
2940 caller of allocate_vectorlike that could cause overflow.
2941 Check that the new vector's length is representable as a fixnum.
2942
86fe5cfe
PE
2943 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2944 The previous code was bogus. For example, next_almost_prime (32)
2945 returned 39, which is undesirable as it is a multiple of 3; and
2946 next_almost_prime (24) returned 25, which is a multiple of 5 so
2947 why was the code bothering to check for multiples of 7?
2948
80e88859
PE
2949 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2950
4a2f0ad6
PE
2951 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2952
f66c7cf8
PE
2953 Variadic C functions now count arguments with ptrdiff_t.
2954 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2955 Back then I didn't know that the Emacs coding style prefers signed int.
2956 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2957 were being counted with int, which may truncate counts on 64-bit
2958 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2959 * lisp.h (struct Lisp_Subr.function.aMANY)
2960 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2961 Arg counts are now ptrdiff_t, not size_t.
2962 All variadic functions and their callers changed accordingly.
2963 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2964 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2965 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2966 * callint.c (Fcall_interactively): Check arg count for overflow,
2967 to avoid potential buffer overrun. Use signed char, not 'int',
2968 for 'varies' array, so that we needn't bother to check its size
2969 calculation for overflow.
2970 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2971 * eval.c (apply_lambda):
2972 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2973 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2974 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2975
a1759b76
PE
2976 * callint.c (Fcall_interactively): Don't use index var as event count.
2977
d96be9fc
PE
2978 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2979 * mem-limits.h (SIZE): Remove; no longer used.
2980
a690a978 2981 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2982
578c21e6
PE
2983 Remove unnecessary casts.
2984 * xterm.c (x_term_init):
2985 * xfns.c (x_set_border_pixel):
2986 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2987 These aren't needed now that we assume ANSI C.
2988
96f53c6c
PE
2989 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2990 It's more likely to cause problems (due to unsigned overflow)
2991 than to cure them.
2992
83c77d31
PE
2993 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2994
ee2079f1
PE
2995 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2996
6da65536
PE
2997 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2998
7147c4a4
PE
2999 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3000
193e32d9
PE
3001 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3002
e5533da6
PE
3003 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3004
9910e595
PE
3005 GLYPH_CODE_FACE returns EMACS_INT, not int.
3006 * dispextern.h (merge_faces):
3007 * xfaces.c (merge_faces):
01103c44
PE
3008 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3009 Don't assume EMACS_INT fits in int.
9910e595 3010
2638320e
PE
3011 * character.h (CHAR_VALID_P): Remove unused parameter.
3012 * fontset.c, lisp.h, xdisp.c: All uses changed.
3013
045eb8d9
PE
3014 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3015
c1f134b5
PE
3016 * fns.c (concat): Minor tuning based on overflow analysis.
3017 This doesn't fix any bugs. Use int to hold character, instead
3018 of constantly refetching from Emacs object. Use XFASTINT, not
3019 XINT, for value known to be a character. Don't bother comparing
3020 a single byte to 0400, as it's always less.
3021
395fcb93 3022 * floatfns.c (Fexpt):
327eeec8
PE
3023 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3024
abbd3d23
PE
3025 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3026 for characters.
3027
684a03ef
PE
3028 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3029
0fed43f3
PE
3030 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3031 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3032 incorrectly succeed when S was a string, because 4294967386 was
3033 truncated before it was used.
3034
8fd02eb7
PE
3035 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3036 Otherwise, an out-of-range integer could cause undefined behavior
3037 on a 64-bit host.
3038
f8c86b69
PE
3039 * composite.c: Use int, not EMACS_INT, for characters.
3040 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3041 EMACS_INT, for values that are known to be in character range.
3042 This doesn't fix any bugs but is the usual style inside Emacs and
3043 may generate better code on 32-bit machines.
3044
34206dd2
PE
3045 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3046 This is for reasons similar to the recent CHAR_STRING fix.
3047 * charset.c (Fencode_char): Check that character arg is actually
3048 a character. Pass an int to ENCODE_CHAR.
3049 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3050 wider than 'int', as a compile-time check to prevent future regressions
3051 in this area.
3052
c5958d4c 3053 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3054
3055 Make sure a 64-bit char is never passed to CHAR_STRING.
3056 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3057 by silently ignoring the top 32 bits, allowing some values
3058 that were far too large to be valid characters.
3059 * character.h: Include <verify.h>.
3060 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3061 arguments are no wider than unsigned, as a compile-time check
3062 to prevent future regressions in this area.
3063 * data.c (Faset):
01103c44 3064 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3065 (Fsubst_char_in_region):
3066 * fns.c (concat):
3067 * xdisp.c (decode_mode_spec_coding):
3068 Adjust to CHAR_STRING's new requirement.
3069 * editfns.c (Finsert_char, Fsubst_char_in_region):
3070 * fns.c (concat): Check that character args are actually
3071 characters. Without this test, these functions did the wrong
3072 thing with wildly out-of-range values on 64-bit hosts.
3073
d37ca623
PE
3074 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3075 These casts should not be needed on 32-bit hosts, either.
3076 * keyboard.c (read_char):
3077 * lread.c (Fload): Remove casts to unsigned.
3078
ea204efb
PE
3079 * lisp.h (UNSIGNED_CMP): New macro.
3080 This fixes comparison bugs on 64-bit hosts.
3081 (ASCII_CHAR_P): Use it.
3082 * casefiddle.c (casify_object):
01103c44 3083 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3084 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3085 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3086 * dispextern.h (FACE_FROM_ID):
3087 * keyboard.c (read_char): Use UNSIGNED_CMP.
3088
41cb286c
PE
3089 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3090 not to EMACS_INT, to avoid GCC warning.
3091
4a1b9832
PE
3092 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3093
55daad71
PE
3094 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3095 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3096 isn't needed on 32-bit machines.
8f95c75c 3097
01103c44
PE
3098 * buffer.c (Fgenerate_new_buffer_name):
3099 Use EMACS_INT for count, not int.
0ceccced 3100 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3101
3102 * data.c (Qcompiled_function): Now static.
3103
c6f072e7
PE
3104 * window.c (window_body_lines): Now static.
3105
20ce5912
PE
3106 * image.c (gif_load): Rename local to avoid shadowing.
3107
9c4c5f81
PE
3108 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3109 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3110 * alloc.c (make_save_value): Integer argument is now of type
3111 ptrdiff_t, not int.
3112 (mark_object): Use ptrdiff_t, not int.
3113 * lisp.h (pD): New macro.
3114 * print.c (print_object): Use it.
3115
c0c5c8ae
PE
3116 * alloc.c: Use EMACS_INT, not int, to count objects.
3117 (total_conses, total_markers, total_symbols, total_vector_size)
3118 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3119 (total_free_floats, total_floats, total_free_intervals)
3120 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3121 Now EMACS_INT, not int. All uses changed.
3122 (Fgarbage_collect): Compute overall total using a double, so that
3123 integer overflow is less likely to be a problem. Check for overflow
3124 when converting back to an integer.
5a25e253
PE
3125 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3126 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3127 These were 'int' variables that could overflow on 64-bit hosts;
3128 they were never used, so remove them instead of repairing them.
211a0b2a 3129 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3130 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3131 Previously, this ceilinged at INT_MAX, but that doesn't work on
3132 64-bit machines.
e46bb31a 3133 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3134
c78baabf 3135 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3136 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3137 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3138 when a (possibly-narrower) signed value would do just as well.
3139 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3140
c9d624c6
PE
3141 * alloc.c: Catch some string size overflows that we were missing.
3142 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3143 for convenience in STRING_BYTES_MAX.
3144 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3145 The definition here is exact; the one in lisp.h was approximate.
3146 (allocate_string_data): Check for string overflow. This catches
3147 some instances we weren't catching before. Also, it catches
3148 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3149 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3150 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3151
c9d624c6
PE
3152 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3153 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3154 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3155
353032ce
PE
3156 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3157
2bccce07
PE
3158 * alloc.c (Fmake_string): Check for out-of-range init.
3159
0ac30604
SM
31602011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3161
3162 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3163
c195f2de
JD
31642011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3165
3166 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3167 xg_get_default_scrollbar_width.
3168
3169 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3170 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3171 (style_changed_cb): Call update_theme_scrollbar_width and call
3172 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3173 all frames (Bug#8505).
3174 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3175 Call gtk_window_set_resizable if HAVE_GTK3.
3176 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3177 and height if HAVE_GTK3 (Bug#8505).
3178 (scroll_bar_width_for_theme): New variable.
3179 (update_theme_scrollbar_width): New function.
3180 (xg_get_default_scrollbar_width): Move code to
3181 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3182 (xg_initialize): Call update_theme_scrollbar_width.
3183
3184 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3185
3186 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3187
e10ac9f1
MR
31882011-06-12 Martin Rudalics <rudalics@gmx.at>
3189
3190 * frame.c (make_frame): Call other_buffer_safely instead of
3191 other_buffer.
3192
3193 * window.c (temp_output_buffer_show): Call display_buffer with
3194 second argument Vtemp_buffer_show_specifiers and reset latter
3195 immediately after the call.
3196 (Vtemp_buffer_show_specifiers): New variable.
3197 (auto_window_vscroll_p, next_screen_context_lines)
3198 (Vscroll_preserve_screen_position): Remove leading asterisks from
3199 doc-strings.
3200
2d3c217e 32012011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3202
7b7f97e8 3203 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3204 * buffer.c (Qclone_number): Remove for now, as it's unused.
3205 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3206 (record_buffer): Remove unused local.
3207 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3208 (set_frame_buffer_list): Remove; unused.
3209 * frame.h (other_visible_frames): Remove decl.
3210 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3211 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3212 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3213 if HAVE_GPM.
3214 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3215 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3216 Define only if HAVE_GPM.
3217 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3218 (update_hints_inhibit): Remove; never set. All uses removed.
3219 * widgetprv.h (emacsFrameClassRec): Remove decl.
3220 * window.c (delete_deletable_window): Now returns void, since it
3221 wasn't returning anything.
3222 (compare_window_configurations): Remove unused locals.
3223 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3224 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3225 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3226 the same widths as pointers. This follows up on the 2011-05-06 patch.
3227 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3228 * xterm.h: Likewise.
3229 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3230
1384b89e
JB
32312011-06-12 Juanma Barranquero <lekktu@gmail.com>
3232
3233 * makefile.w32-in: Update dependencies.
3234 (LISP_H): Add lib/intprops.h.
3235
1100a63c
CY
32362011-06-11 Chong Yidong <cyd@stupidchicken.com>
3237
3238 * image.c (gif_load): Add animation frame delay to the metadata.
3239 (syms_of_image): Use DEFSYM. New symbol `delay'.
3240
6198ccd0
MR
32412011-06-11 Martin Rudalics <rudalics@gmx.at>
3242
3243 * window.c (delete_deletable_window): Re-add.
3244 (Fset_window_configuration): Rewrite to handle dead buffers and
3245 consequently deletable windows.
3246 (window_tree, Fwindow_tree): Remove. Supply functionality in
3247 window.el.
3248 (compare_window_configurations): Simplify code.
3249
b6e3633c
AS
32502011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3251
1ab0dee5
AS
3252 * image.c (imagemagick_load_image): Fix type mismatch.
3253 (Fimagemagick_types): Likewise.
3254
b6e3633c
AS
3255 * window.h (replace_buffer_in_windows): Declare.
3256
9397e56f
MR
32572011-06-11 Martin Rudalics <rudalics@gmx.at>
3258
3259 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3260 Qclone_number. Remove external declaration of Qdelete_window.
3261 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3262 code.
640c8776
SM
3263 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3264 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3265 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3266 buffer list implementation.
3267 (other_buffer_safely): New function.
3268 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3269 calls to replace_buffer_in_windows and
3270 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3271 if allowed.
3272 (record_buffer): Inhibit quitting and rewrite using quittable
3273 functions. Run Qbuffer_list_update_hook if allowed.
3274 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3275 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3276 Move switch-to-buffer to window.el.
9397e56f
MR
3277 (bury-buffer): Move to window.el.
3278 (Vbuffer_list_update_hook): New variable.
3279
3280 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3281 section.
3282
3283 * window.h (resize_frame_windows): Move up in code.
3284 (Fwindow_frame): Remove EXFUN.
3285 (replace_buffer_in_all_windows): Remove prototype.
3286 (replace_buffer_in_windows_safely): Add prototype.
3287
3288 * window.c: Declare Qdelete_window static again. Move down
3289 declaration of select_count.
3290 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3291 (Fother_window): Move to window.el.
3292 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3293 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3294 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3295 window.el.
3296 (replace_buffer_in_windows): Implement by calling
3297 Qreplace_buffer_in_windows.
3298 (replace_buffer_in_all_windows): Remove with some functionality
3299 moved into replace_buffer_in_windows_safely.
3300 (replace_buffer_in_windows_safely): New function.
3301 (select_window_norecord, select_frame_norecord): Move in front
3302 of run_window_configuration_change_hook. Remove now obsolete
3303 declarations.
640c8776
SM
3304 (Fset_window_buffer): Rewrite doc-string.
3305 Call Qrecord_window_buffer.
9397e56f
MR
3306 (keys_of_window): Move binding for other-window to window.el.
3307
b50691aa
CY
33082011-06-11 Chong Yidong <cyd@stupidchicken.com>
3309
3310 * dispextern.h (struct image): Replace data member, whose int_val
3311 and ptr_val fields were not used by anything, with a single
3312 lisp_val object.
3313
3314 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3315 (gif_clear_image, gif_load, imagemagick_load_image)
3316 (gs_clear_image, gs_load): Callers changed.
3317
3f754b86
PE
33182011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3319
cca69397
PE
3320 * buffer.h: Include <time.h>, for time_t.
3321 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3322
109e28d0
PE
3323 Fix minor problems found by static checking.
3324
60737f02
PE
3325 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3326
4b66faf3
PE
3327 Make identifiers static if they are not used in other modules.
3328 * data.c (Qcompiled_function, Qframe, Qvector):
3329 * image.c (QimageMagick, Qsvg):
3330 * minibuf.c (Qmetadata):
3331 * window.c (resize_window_check, resize_root_window): Now static.
3332 * window.h (resize_window_check, resize_root_window): Remove decls.
3333
109e28d0
PE
3334 * window.c (window_deletion_count, delete_deletable_window):
3335 Remove; unused.
46a4ce9e
PE
3336 (window_body_lines): Now static.
3337 (Fdelete_other_windows_internal): Mark vars as initialized.
3338 Make sure 'resize_failed' is initialized.
3339 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3340 (resize_window_apply): Remove unused local.
3341 * window.h (delete_deletable_window): Remove decl.
3342
109e28d0 3343 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3344 (imagemagick_load_image): Fix pointer signedness problem by changing
3345 last arg from unsigned char * to char *. All uses changed.
3346 Also, fix a local for similar reasons.
3347 Remove unused locals. Remove locals to avoid shadowing.
3348 (fn_rsvg_handle_free): Remove; unused.
3349 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3350 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3351
3f754b86
PE
3352 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3353
2547adb1
CY
33542011-06-10 Chong Yidong <cyd@stupidchicken.com>
3355
3356 * image.c (gif_load): Fix omitted cast error introduced by
3357 2011-06-06 change.
3358
2c8e37d4
MR
33592011-06-10 Martin Rudalics <rudalics@gmx.at>
3360
3361 * window.h (resize_proportionally, orig_total_lines)
3362 (orig_top_line): Remove from window structure.
3363 (set_window_height, set_window_width, change_window_heights)
3364 (Fdelete_window): Remove prototypes.
3365 (resize_frame_windows): Remove duplicate declaration.
3366
440a42e3
EZ
33672011-06-10 Eli Zaretskii <eliz@gnu.org>
3368
3369 * window.h (resize_frame_windows, resize_window_check)
3370 (delete_deletable_window, resize_root_window)
3371 (resize_frame_windows): Declare prototypes.
3372
3373 * window.c (resize_window_apply): Make definition be "static" to
3374 match the prototype.
3375
562dd5e9
MR
33762011-06-10 Martin Rudalics <rudalics@gmx.at>
3377
3378 * window.c: Remove declarations of Qwindow_size_fixed,
3379 window_min_size_1, window_min_size_2, window_min_size,
3380 size_window, window_fixed_size_p, enlarge_window, delete_window.
3381 Remove static from declaration of Qdelete_window, it's
3382 temporarily needed by Fbury_buffer.
3383 (replace_window): Don't assign orig_top_line and
3384 orig_total_lines.
3385 (Fdelete_window, delete_window): Remove. Window deletion is
3386 handled by window.el.
640c8776
SM
3387 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3388 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3389 (Fdelete_other_windows): Remove. Deleting other windows is
3390 handled by window.el.
3391 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3392 handled in window.el.
3393 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3394 Window minimum sizes are handled in window.el.
3395 (shrink_windows, size_window, set_window_height)
3396 (set_window_width, change_window_heights, window_height)
3397 (window_width, CURBEG, CURSIZE, enlarge_window)
3398 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3399 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3400 handled in window.el.
3401 (make_dummy_parent): Rename to make_parent_window and give it a
3402 second argument horflag.
3403 (make_window): Don't set resize_proportionally any more.
3404 (Fsplit_window): Remove. Windows are split in window.el.
3405 (save_restore_action, save_restore_orig_size)
3406 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3407 Resize mini windows in window.el.
3408 (grow_mini_window, shrink_mini_window): Implement by calling
3409 Qresize_root_window_vertically, resize_window_check and
3410 resize_window_apply.
640c8776
SM
3411 (saved_window, Fset_window_configuration, save_window_save):
3412 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3413 resize_proportionally.
3414 (window_min_height, window_min_width): Move to window.el.
3415 (keys_of_window): Move bindings for delete-other-windows,
3416 split-window, delete-window and enlarge-window to window.el.
3417
3418 * buffer.c: Temporarily extern Qdelete_window.
3419 (Fbury_buffer): Temporarily call Qdelete_window instead of
3420 Fdelete_window (Fbury_buffer will move to window.el soon).
3421
3422 * frame.c (set_menu_bar_lines_1): Remove code handling
3423 orig_top_line and orig_total_lines.
3424
3425 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3426 set_window_height but set heights directly.
3427 (change_frame_size_1): Use resize_frame_windows.
3428
3429 * xdisp.c (init_xdisp): Don't use set_window_height but set
3430 heights directly.
3431
640c8776
SM
3432 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3433 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3434 run_window_configuration_change_hook.
3435
3436 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3437 instead of change_window_heights and run
3438 run_window_configuration_change_hook.
3439
1a13852e
MR
34402011-06-09 Martin Rudalics <rudalics@gmx.at>
3441
3442 * window.c (replace_window): Rename second argument REPLACEMENT to
3443 NEW. New third argument SETFLAG. Rewrite.
3444 (delete_window, make_dummy_parent): Call replace_window with
3445 third argument 1.
3446 (window_list_1): Move down in code.
3447 (run_window_configuration_change_hook): Move set_buffer part
3448 before select_frame_norecord part in order to unwind correctly.
3449 Rename count1 to count.
3450 (recombine_windows, delete_deletable_window, resize_root_window)
3451 (Fdelete_other_windows_internal)
3452 (Frun_window_configuration_change_hook, make_parent_window)
3453 (resize_window_check, resize_window_apply, Fresize_window_apply)
3454 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3455 (Fdelete_window_internal, Fresize_mini_window_internal):
3456 New functions.
1a13852e
MR
3457 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3458
f3d1777e
MR
34592011-06-08 Martin Rudalics <rudalics@gmx.at>
3460
496e208e
MR
3461 * window.h (window): Add some new members to window structure -
3462 normal_lines, normal_cols, new_total, new_normal, clone_number,
3463 splits, nest, prev_buffers, next_buffers.
3464 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3465 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3466
f3d1777e
MR
3467 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3468 Remove.
496e208e
MR
3469 (make_dummy_parent): Set new members of windows structure.
3470 (make_window): Move down in code. Handle new members of window
3471 structure.
3472 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3473 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3474 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3475 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3476 (Fset_window_next_buffers, Fset_window_clone_number):
3477 New functions.
496e208e
MR
3478 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3479 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3480 Doc-string fixes.
3481 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3482 Argument WINDOW can be now internal window too.
3483 (Fwindow_use_time): Move up in code.
3484 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3485 Rewrite doc-string.
3486 (Fset_window_configuration, saved_window)
3487 (Fcurrent_window_configuration, save_window_save): Handle new
3488 members of window structure.
b9e809c2
MR
3489 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3490 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3491 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3492 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3493 Qget_mru_window, Qresize_root_window,
3494 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3495 Qauto_buffer_name; staticpro them.
f3d1777e 3496
abde8f8c
MR
34972011-06-07 Martin Rudalics <rudalics@gmx.at>
3498
3499 * window.c (Fwindow_total_size, Fwindow_left_column)
3500 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3501 (Fwindow_list_1): New functions.
3502 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3503 (Fwindow_width, Fscroll_left, Fscroll_right):
3504 Use window_body_cols instead of window_box_text_cols.
3505 (delete_window, Fset_window_configuration):
3506 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3507 (delete_all_subwindows): Take a window as argument and not a
3508 structure. Rewrite.
190b47e6
MR
3509 (window_loop): Remove handling of GET_LRU_WINDOW and
3510 GET_LARGEST_WINDOW.
3511 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3512
3513 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3514 window_box_text_cols. delete_all_subwindows now takes a
3515 Lisp_Object as argument.
abde8f8c 3516
640c8776
SM
3517 * indent.c (compute_motion, Fcompute_motion):
3518 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3519
fa8a67e6
MR
3520 * frame.c (delete_frame): Call delete_all_subwindows with root
3521 window as argument.
3522
a54e3482
DC
35232011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3524
3525 * fns.c (Fputhash): Document return value.
3526
60002bf5
CY
35272011-06-06 Chong Yidong <cyd@stupidchicken.com>
3528
3529 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3530
0c671da6 35312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3532
b862a52a 3533 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3534
be44ca6c
PE
3535 Check for overflow when converting integer to cons and back.
3536 * charset.c (Fdefine_charset_internal, Fdecode_char):
3537 Use cons_to_unsigned to catch overflow.
3538 (Fencode_char): Use INTEGER_TO_CONS.
3539 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3540 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3541 * data.c (long_to_cons, cons_to_long): Remove.
3542 (cons_to_unsigned, cons_to_signed): New functions.
3543 These signal an error for invalid or out-of-range values.
3544 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3545 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3546 * font.c (Ffont_variation_glyphs):
3547 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3548 * lisp.h: Include <intprops.h>.
3549 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3550 (cons_to_signed, cons_to_unsigned): New decls.
3551 (long_to_cons, cons_to_long): Remove decls.
3552 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3553 (Fprimitive_undo): Use CONS_TO_INTEGER.
3554 * xfns.c (Fx_window_property): Likewise.
3555 * xselect.c: Include <limits.h>.
3556 (x_own_selection, selection_data_to_lisp_data):
3557 Use INTEGER_TO_CONS.
3558 (x_handle_selection_request, x_handle_selection_clear)
3559 (x_get_foreign_selection, Fx_disown_selection_internal)
3560 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3561 (lisp_data_to_selection_data): Use cons_to_unsigned.
3562 (x_fill_property_data): Use cons_to_signed.
3563 Report values out of range.
3564
d1f3d2af
PE
3565 Check for buffer and string overflow more precisely.
3566 * buffer.h (BUF_BYTES_MAX): New macro.
3567 * lisp.h (STRING_BYTES_MAX): New macro.
3568 * alloc.c (Fmake_string):
3569 * character.c (string_escape_byte8):
3570 * coding.c (coding_alloc_by_realloc):
3571 * doprnt.c (doprnt):
3572 * editfns.c (Fformat):
3573 * eval.c (verror):
3574 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3575 since they may not be the same number.
3576 * editfns.c (Finsert_char):
3577 * fileio.c (Finsert_file_contents):
3578 Likewise for BUF_BYTES_MAX.
3579
dd52fcea
PE
3580 * image.c: Use ptrdiff_t, not int, for sizes.
3581 (slurp_file): Switch from int to ptrdiff_t.
3582 All uses changed.
3583 (slurp_file): Check that file size fits in both size_t (for
3584 malloc) and ptrdiff_t (for sanity and safety).
3585
7f9bbdbb
PE
3586 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3587 if b->modtime has its maximal value.
3588
dfe18f82
PE
3589 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3590
84acfcf0
PE
3591 Don't assume time_t can fit into int.
3592 * buffer.h (struct buffer.modtime): Now time_t, not int.
3593 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3594 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3595
ccd9a01a
PE
3596 Minor fixes for signed vs unsigned integers.
3597 * character.h (MAYBE_UNIFY_CHAR):
3598 * charset.c (maybe_unify_char):
3599 * keyboard.c (read_char, reorder_modifiers):
3600 XINT -> XFASTINT, since the integer must be nonnegative.
3601 * ftfont.c (ftfont_spec_pattern):
3602 * keymap.c (access_keymap, silly_event_symbol_error):
3603 XUINT -> XFASTINT, since the integer must be nonnegative.
3604 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3605 since it makes no difference and we prefer signed.
3606 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3607 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3608 nonnegative.
3609
d6d100dd
SM
36102011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3611
3612 * window.h (Fwindow_frame): Declare.
3613
2b6148e4
PE
36142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3615
3616 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3617 (SPARE_MEMORY): Always define.
3618 (LARGE_REQUEST): Remove.
3619 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3620
f230ecc9
MR
36212011-06-06 Martin Rudalics <rudalics@gmx.at>
3622
727e958e
MR
3623 * lisp.h: Move EXFUNS for Fframe_root_window,
3624 Fframe_first_window and Fset_frame_selected_window to window.h.
3625
3626 * window.h: Move EXFUNS for Fframe_root_window,
3627 Fframe_first_window and Fset_frame_selected_window here from
3628 lisp.h.
3629
3630 * frame.c (Fwindow_frame, Fframe_first_window)
3631 (Fframe_root_window, Fframe_selected_window)
3632 (Fset_frame_selected_window): Move to window.c.
3633 (Factive_minibuffer_window): Move to minibuf.c.
3634 (Fother_visible_frames_p): New function.
3635
3636 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3637
f230ecc9
MR
3638 * window.c (decode_window, decode_any_window): Move up in code.
3639 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3640 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3641 (Fwindow_buffer): Move up and rewrite doc-string.
3642 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3643 (Fwindow_prev): New functions.
727e958e
MR
3644 (Fwindow_frame): Move here from frame.c. Accept any window as
3645 argument.
3646 (Fframe_root_window, Fframe_first_window)
3647 (Fframe_selected_window): Move here from frame.c. Accept frame
3648 or arbitrary window as argument. Update doc-strings.
3649 (Fminibuffer_window): Move up in code.
3650 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3651 (Fset_frame_selected_window): Move here from frame.c.
3652 Marginal rewrite.
727e958e
MR
3653 (Fselected_window, select_window, Fselect_window): Move up in
3654 code. Minor doc-string fixes.
f230ecc9 3655
4d09bcf6
PE
36562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3657
3658 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3659 Do not assume that spare memory exists; that assumption is valid
3660 only if SYSTEM_MALLOC.
3661 (LARGE_REQUEST): New macro, so that the issue of large requests
3662 is separated from the issue of spare memory.
3663
810928a2
AS
36642011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3665
172418ad
AS
3666 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3667 format. (Bug#8806)
3668
43f862f7
AS
3669 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3670
810928a2
AS
3671 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3672 before statements.
3673
a059fe24
JD
36742011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3675
3676 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3677
3678 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3679
3680 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3681 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3682
989bf368
JB
36832011-06-05 Juanma Barranquero <lekktu@gmail.com>
3684
3685 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3686
4b80f674
CY
36872011-06-04 Chong Yidong <cyd@stupidchicken.com>
3688
3689 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3690 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3691 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3692 New error handlers.
4b80f674
CY
3693 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3694 Obey Vx_select_enable_clipboard_manager. Catch errors in
3695 x_clipboard_manager_save (Bug#8779).
3696 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3697 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3698
99a33b77 36992011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3700
3701 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3702
99a33b77 37032011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3704
3705 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3706 in the current matrix if keep_current_p is non-zero.
3707
8264569d
EZ
37082011-06-04 Eli Zaretskii <eliz@gnu.org>
3709
3710 * bidi.c (bidi_level_of_next_char): Fix last change.
3711
57f97249
EZ
37122011-06-03 Eli Zaretskii <eliz@gnu.org>
3713
fec2107c 3714 Support bidi reordering of text covered by display properties.
57f97249 3715
fec2107c
EZ
3716 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3717 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3718 (bidi_cache_search, bidi_cache_iterator_state)
3719 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3720 (bidi_level_of_next_char, bidi_move_to_visually_next):
3721 Support character positions inside a run of characters covered by a
fec2107c
EZ
3722 display string.
3723 (bidi_paragraph_init, bidi_resolve_explicit_1)
3724 (bidi_level_of_next_char): Call bidi_fetch_char and
3725 bidi_fetch_char_advance instead of FETCH_CHAR and
3726 FETCH_CHAR_ADVANCE.
3727 (bidi_init_it): Initialize new members.
3728 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3729 definitions.
3730 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3731 instead of using explicit *_CHAR codes.
d6d100dd
SM
3732 (bidi_resolve_explicit, bidi_resolve_weak):
3733 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3734 bidirectional text is supported only in multibyte buffers.
3735 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3736 it to initialize the frame_window_p member of struct bidi_it.
3737 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3738 (bidi_resolve_explicit, bidi_resolve_weak)
3739 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3740 bidi_it->nchars is non-positive.
3741 (bidi_level_of_next_char): Don't try to lookup the cache for the
3742 next/previous character if nothing is cached there yet, or if we
3743 were just reseat()'ed to a new position.
c40e2fb2 3744
0e14fe90
EZ
3745 * xdisp.c (set_cursor_from_row): Set start and stop points
3746 according to the row's direction when priming the loop that looks
3747 for the glyph on which to display cursor.
3748 (single_display_spec_intangible_p): Function deleted.
3749 (display_prop_intangible_p): Reimplement to call
3750 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3751 Accept 3 additional arguments needed by handle_display_spec.
3752 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3753 values: lists, `(when COND...)' forms, etc.
3754 (single_display_spec_string_p): Support property values that are
3755 lists with the argument STRING its top-level element.
3756 (display_prop_string_p): Fix the condition for processing a
3757 property that is a list to be consistent with handle_display_spec.
fec2107c 3758 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3759 last portion of handle_display_prop.
3760 (compute_display_string_pos): Accept additional argument
3761 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3762 value of a `display' property is a "replacing spec".
3763 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3764 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3765 the display property, but just return a value indicating whether
3766 the display property will replace the characters it covers.
3767 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3768 frame_window_p members of struct bidi_it.
d6d100dd
SM
3769 (compute_display_string_pos, compute_display_string_end):
3770 New functions.
fec2107c
EZ
3771 (push_it): Accept second argument POSITION, where pop_it should
3772 jump to continue iteration.
3773 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3774
fec2107c
EZ
3775 * keyboard.c (adjust_point_for_property): Adjust the call to
3776 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3777
3778 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3779 (bidi_init_it): Update prototypes.
3780 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3781 (compute_display_string_pos, compute_display_string_end):
3782 Declare prototypes.
fec2107c
EZ
3783 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3784 EMACS_INT.
fc6f18ce 3785
40087514 37862011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3787
57f53182
PE
3788 Malloc failure behavior now depends on size of allocation.
3789 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3790 * lisp.h: Change signatures accordingly.
3791 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3792 All callers changed. (Bug#8762)
3793
3794 * gnutls.c: Use Emacs's memory allocators.
3795 Without this change, the gnutls library would invoke malloc etc.
3796 directly, which causes problems on non-SYNC_INPUT hosts, and which
3797 runs afoul of improving memory_full behavior. (Bug#8761)
3798 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3799 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3800 xfree instead of the default malloc, realloc, free.
3801 (Fgnutls_boot): No need to check for memory allocation failure,
3802 since xmalloc does that for us.
3803
ac32cd99 3804 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3805 * category.c (hash_get_category_set):
3806 * ccl.c (ccl_driver):
3807 * charset.c (Fdefine_charset_internal):
3808 * charset.h (struct charset.hash_index):
3809 * composite.c (get_composition_id, gstring_lookup_cache)
3810 (composition_gstring_put_cache):
3811 * composite.h (struct composition.hash_index):
3812 * dispextern.h (struct image.hash):
3813 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3814 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3815 (hashfn_equal, hashfn_user_defined, make_hash_table)
3816 (maybe_resize_hash_table, hash_lookup, hash_put)
3817 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3818 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3819 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3820 * image.c (make_image, search_image_cache, lookup_image)
3821 (xpm_put_color_table_h):
3822 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3823 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3824 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3825 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3826 * alloc.c (allocate_vectorlike):
3827 Check for overflow in vector size calculations.
3828 * ccl.c (ccl_driver):
3829 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3830 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3831 need to be updated by these changes.
40087514
PE
3832 * fns.c (make_hash_table, maybe_resize_hash_table):
3833 Check for integer overflow with large hash tables.
0de4bb68
PE
3834 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3835 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3836 (SXHASH_REDUCE): New macro.
3837 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3838 Use it instead of discarding useful hash info with large hash values.
3839 (sxhash_float): New function.
3840 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3841 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3842 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3843 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3844 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3845 Adjust signatures to match updated version of code.
3846 (consing_since_gc): Now EMACS_INT, since a single hash table can
3847 use more than INT_MAX bytes.
3848
698d32e2
DN
38492011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3850
3851 Make it possible to build with GCC-4.6+ -O2 -flto.
3852
3853 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3854
fd6fa53f
SM
38552011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3856
3857 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3858 Call minibuffer-inactive-mode.
3859
864db017
JB
38602011-05-31 Juanma Barranquero <lekktu@gmail.com>
3861
3862 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3863 Update dependencies.
3864
2ad0baf4
DN
38652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3866
3867 * data.c (init_data): Remove code for UTS, this system is not
3868 supported anymore.
3869
4fcc2638
DN
38702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3871
3872 Don't force ./temacs to start in terminal mode.
3873
3874 * frame.c (make_initial_frame): Initialize faces in all cases, not
3875 only when CANNOT_DUMP is defined.
3876 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3877
c56e0fd5
DN
38782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3879
3880 * dispnew.c (add_window_display_history): Use const for the string
3881 pointer. Remove declaration, not needed.
3882
333d54da 38832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3884
55d4c1b2 3885 Use 'inline', not 'INLINE'.
333d54da 3886 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3887 * alloc.c, fontset.c (INLINE): Remove.
3888 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3889 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3890 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3891 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3892 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3893
738db178
DN
38942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3895
3896 Make it possible to run ./temacs.
3897
3898 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3899 syms_of_callproc does the same thing. Remove test for
3900 "initialized", do it in the caller.
3901 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3902
620c53a6
SM
39032011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3904
3905 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3906 (read_minibuf): Use get_minibuffer.
3907 (syms_of_minibuf): Use DEFSYM.
3908 (Qmetadata): New var.
3909 * data.c (Qbuffer): Don't make it static.
3910 (syms_of_data): Use DEFSYM.
3911
e003a292
PE
39122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3913
3914 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3915 (CCL_CODE_MIN): New macro.
3916
ed008a6d
PE
39172011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3918
3687c2ef
PE
3919 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3920
ed008a6d
PE
3921 * eval.c (Qdebug): Now static.
3922 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3923 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3924 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3925
d66c4c7c
CY
39262011-05-29 Chong Yidong <cyd@stupidchicken.com>
3927
3928 * image.c: Various fixes to ImageMagick code comments.
3929 (Fimagemagick_types): Doc fix.
3930
5fbc2025
PE
39312011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3932
0196f88a
PE
3933 Minor fixes prompted by GCC 4.6.0 warnings.
3934
3935 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3936
5fbc2025
PE
3937 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3938 (x_clipboard_manager_save_all): Move extern decl to ...
3939 * xterm.h: ... here, so that it can be checked for consistency.
3940
1dd3c2d9
CY
39412011-05-29 Chong Yidong <cyd@stupidchicken.com>
3942
3943 * xselect.c (x_clipboard_manager_save_frame)
3944 (x_clipboard_manager_save_all): New functions.
3945 (Fx_clipboard_manager_save): Lisp function deleted.
3946
3947 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3948 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3949
3950 * xterm.h: Update prototype.
3951
5ba6571d
WX
39522011-05-28 William Xu <william.xwl@gmail.com>
3953
3954 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3955 exiting (Bug#8239).
3956
3eaff834
JM
39572011-05-28 Jim Meyering <meyering@redhat.com>
3958
e1900994 3959 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3960 * fns.c (to_uchar): Define.
3961 (crypto_hash_function): Use it to convert some newly-signed
3962 variables to unsigned, to avoid sign-extension bugs. For example,
3963 without this change, (md5 "truc") would evaluate to
3964 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3965 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3966 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3967
0f6990a7
PE
39682011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3969
3970 Integer overflow fixes.
c8a9ca5a 3971
08686060
PE
3972 * dbusbind.c: Serial number integer overflow fixes.
3973 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3974 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3975 to hold a serial number that is too large for a fixnum.
3976 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3977 Check for serial numbers out of range. Decode any serial number
59568bf0 3978 that was so large that it became a float. (Bug#8722)
08686060 3979
2d1fc3c7
PE
3980 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3981 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3982 Use XFASTINT rather than XUINT when numbers are nonnegative.
3983 (xd_append_arg, Fdbus_method_return_internal):
3984 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3985 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3986 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3987 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3988 (Bug#8722)
2d1fc3c7 3989
c8a9ca5a
PE
3990 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3991
519e1d69
PE
3992 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3993
30569699
PE
3994 ccl: add integer overflow checks
3995 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3996 (IN_INT_RANGE): New macros.
3997 (ccl_driver): Use them to check for integer overflow when
3998 decoding a CCL program. Many of the new checks are whether XINT (x)
3999 fits in int; it doesn't always, on 64-bit hosts. The new version
4000 doesn't catch all possible integer overflows, but it's an
847044ea 4001 improvement. (Bug#8719)
30569699 4002
c11285dc
PE
4003 * alloc.c (make_event_array): Use XINT, not XUINT.
4004 There's no need for unsigned here.
4005
fdccd48e
PE
4006 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4007 This follows up to the 2011-05-06 change that substituted uintptr_t
4008 for EMACS_INT. This case wasn't caught back then.
4009
37910ab2
PE
4010 Rework Fformat to avoid integer overflow issues.
4011 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4012 now (part of C89). Include <verify.h>.
4013 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4014 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4015 (Fformat): Avoid the prepass trying to compute sizes; it was only
4016 approximate and thus did not catch overflow reliably. Instead, walk
4017 through the format just once, formatting and computing sizes as we go,
4018 checking for integer overflow at every step, and allocating a larger
4019 buffer as needed. Keep track separately whether the format is
4020 multibyte. Keep only the most-recently calculated precision, rather
4021 than them all. Record whether each argument has been converted to
4022 string. Use EMACS_INT, not int, for byte and char and arg counts.
4023 Support field widths and precisions larger than INT_MAX. Avoid
4024 sprintf's undefined behavior with conversion specifications such as %#d
4025 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4026 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4027 formatting out-of-range floating point numbers with int
9173deec 4028 formats. (Bug#8668)
37910ab2 4029
2e6578fb
PE
4030 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4031
0ae6bdee
PE
4032 * data.c: Avoid integer truncation in expressions involving floats.
4033 * data.c: Include <intprops.h>.
4034 (arith_driver): When there's an integer overflow in an expression
4035 involving floating point, convert the integers to floating point
4036 so that the resulting value does not suffer from catastrophic
4037 integer truncation. For example, on a 64-bit host (* 4
4038 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4039 Do not rely on undefined behavior after integer overflow.
4040
de883a70
PE
4041 merge count_size_as_multibyte, parse_str_to_multibyte
4042 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4043 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4044 Check for integer overflow.
4045 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4046 since it's now a duplicate of the other. This is more of
4047 a character than a buffer op, so better that it's in character.c.
4048 * fns.c, print.c: Adjust to above changes.
4049
2ff916cb
PE
40502011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4051
4052 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4053
f1b54466
PE
40542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4055
fb1ac845
PE
4056 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4057 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4058 (x_clipboard_manager_save): Now static.
4059 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4060
f1b54466
PE
4061 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4062 (crypto_hash_function): Now static.
4063 Fix pointer signedness problems. Avoid unnecessary initializations.
4064
a9f737ee
CY
40652011-05-27 Chong Yidong <cyd@stupidchicken.com>
4066
4067 * termhooks.h (Vselection_alist): Make it terminal-local.
4068
4069 * terminal.c (create_terminal): Initialize it.
4070
4071 * xselect.c: Support for clipboard managers.
4072 (Vselection_alist): Move to termhooks.h as terminal-local var.
4073 (LOCAL_SELECTION): New macro.
4074 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4075 (symbol_to_x_atom): Remove gratuitous arg.
4076 (x_handle_selection_request, lisp_data_to_selection_data)
4077 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4078 (x_own_selection, x_get_local_selection, x_convert_selection):
4079 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4080 (some_frame_on_display): Delete unused function.
4081 (Fx_own_selection_internal, Fx_get_selection_internal)
4082 (Fx_disown_selection_internal, Fx_selection_owner_p)
4083 (Fx_selection_exists_p): New optional frame arg.
4084 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4085 (x_handle_selection_clear): Don't treat other terminals with the
4086 same keyboard specially. Use the terminal-local Vselection_alist.
4087 (x_clear_frame_selections): Use Frun_hook_with_args.
4088
4089 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4090
4091 * xterm.h: Add support for those atoms.
4092
e067f0c1
CY
40932011-05-26 Chong Yidong <cyd@stupidchicken.com>
4094
4095 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4096 (converted_selections, conversion_fail_tag): New global variables.
4097 (x_selection_request_lisp_error): Free the above.
4098 (x_get_local_selection): Remove unnecessary code.
4099 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4100 of converted selections stored in converted_selections.
4101 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4102 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4103 (x_convert_selection): New function.
4104 (x_handle_selection_event): Simplify.
4105 (x_get_foreign_selection): Don't ignore incoming requests while
4106 waiting for an answer; this will fail when we implement
4107 SAVE_TARGETS, and seems unnecessary anyway.
4108 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4109 (Vx_sent_selection_functions): Doc fix.
4110
0f4aebc0
LL
41112011-05-26 Leo Liu <sdl.web@gmail.com>
4112
4113 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4114
e61124cd
YM
41152011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4116
4117 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4118
4119 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4120 for fringe update if it has periodic bitmap.
ac389d0c 4121 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4122 and fringe_bitmap_periodic_p.
4123
4124 * fringe.c (get_fringe_bitmap_data): New function.
4125 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4126 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4127 row. Mark glyph row for fringe update if periodicity changed.
4128
4129 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4130 for fringe update unless it has periodic bitmap.
4131
f16d9837
KH
41322011-05-25 Kenichi Handa <handa@m17n.org>
4133
4134 * xdisp.c (get_next_display_element): Set correct it->face_id for
4135 a static composition.
4136
e1b90ef6
LL
41372011-05-24 Leo Liu <sdl.web@gmail.com>
4138
4139 * deps.mk (fns.o):
4140 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4141
4142 * fns.c (crypto_hash_function, Fsha1): New function.
4143 (Fmd5): Use crypto_hash_function.
4144 (syms_of_fns): Add Ssha1.
4145
7400048f
PE
41462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4147
4148 * gnutls.c: Remove unused macros.
4149 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4150 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4151 Remove macros that are defined and never used.
4152 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4153
abb71cf4
CY
41542011-05-22 Chong Yidong <cyd@stupidchicken.com>
4155
4156 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4157 (Fx_get_selection_internal): Minor cleanup.
4158 (Fx_own_selection_internal): Rename arguments for consistency with
4159 select.el.
4160
6307db39
PE
41612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4162
4163 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4164
f3d4e0a4
CY
41652011-05-22 Chong Yidong <cyd@stupidchicken.com>
4166
4167 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4168
4d8ade89
YM
41692011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4170
4171 * dispnew.c (scrolling_window): Don't exclude the case that the
4172 last enabled row in the desired matrix touches the bottom boundary.
4173
32078c8d
GM
41742011-05-21 Glenn Morris <rgm@gnu.org>
4175
4176 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4177 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4178 and add some more files.
32078c8d 4179
7285dc67
EZ
41802011-05-20 Eli Zaretskii <eliz@gnu.org>
4181
4182 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4183 report_file_error introduced by the change from 2011-05-07.
4184
89d1bd22
PE
41852011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4186
4187 * systime.h (Time): Define only if emacs is defined.
4188 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4189 where the include path doesn't have X11/X.h by default. See
4190 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4191
e23640bb 41922011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4193
4194 * composite.c (find_automatic_composition): Fix previous change.
4195
b9704ad9
GM
41962011-05-20 Glenn Morris <rgm@gnu.org>
4197
4198 * lisp.mk: New file, split from Makefile.in.
4199 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4200 (shortlisp): Remove.
4201 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4202
4a720484
GM
42032011-05-19 Glenn Morris <rgm@gnu.org>
4204
4205 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4206 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4207 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4208 (lisp): Set the order to that of loadup.el.
4209 (shortlisp): Make it a copy of $lisp.
4210 (SOME_MACHINE_LISP): Remove.
4211 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4212 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4213
a28d4396
KH
42142011-05-18 Kenichi Handa <handa@m17n.org>
4215
4216 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4217 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4218 (find_automatic_composition): Mostly rewrite for efficiency.
4219
a2b1fa8e
JB
42202011-05-18 Juanma Barranquero <lekktu@gmail.com>
4221
4222 * makefile.w32-in: Update dependencies.
4223
8e1f5610
CS
42242011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4225
4226 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4227 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4228
7025ee00 42292011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4230
cdfa6eab
PE
4231 Fix some integer overflow issues, such as string length overflow.
4232
06d6db33
PE
4233 * insdel.c (count_size_as_multibyte): Check for string overflow.
4234
2b4560a8
PE
4235 * character.c (lisp_string_width): Check for string overflow.
4236 Use EMACS_INT, not int, for string indexes and lengths; in
4237 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4238 the resulting string length overflows an EMACS_INT; instead,
4239 report a string overflow if no precision given. When checking for
4240 precision exhaustion, use a check that cannot possibly have
4241 integer overflow. (Bug#8675)
4242 * character.h (lisp_string_width): Adjust to new signature.
4243
cb93f9be
PE
4244 * alloc.c (string_overflow): New function.
4245 (Fmake_string): Use it. This doesn't change behavior, but saves
4246 a few bytes and will simplify future changes.
4247 * character.c (string_escape_byte8): Likewise.
4248 * lisp.h (string_overflow): New decl.
4249
1a1f3366
PE
4250 Fixups, following up to the user-interface timestamp change.
4251 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4252 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4253 * msdos.c (mouse_get_pos): Likewise.
4254 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4255 * w32gui.h (Time): Define by including "systime.h" rather than by
4256 declaring it ourselves. (Bug#8664)
4257
d4e3e4d3
PE
4258 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4259 * image.c (clear_image_cache): Likewise.
4260
f6a24d19
PE
4261 * term.c (term_mouse_position): Don't assume time_t wraparound.
4262
08dc5ae6
PE
4263 Be more systematic about user-interface timestamps.
4264 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4265 and sometimes 'EMACS_UINT', to represent these timestamps.
4266 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4267 This makes the code easier to follow, and makes it easier to catch
4268 integer overflow bugs such as Bug#8664.
4269 * frame.c (Fmouse_position, Fmouse_pixel_position):
4270 Use Time, not unsigned long, for user-interface timestamps.
4271 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4272 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4273 * keyboard.h (last_event_timestamp): Likewise.
4274 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4275 * menu.h (xmenu_show): Likewise.
4276 * term.c (term_mouse_position): Likewise.
4277 * termhooks.h (struct input_event.timestamp): Likewise.
4278 (struct terminal.mouse_position_hook): Likewise.
4279 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4280 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4281 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4282 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4283 what it was before.
4284 * menu.h, termhooks.h: Include "systime.h", for Time.
4285
8e55734a
PE
4286 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4287 Don't assume that the difference between two unsigned long values
4288 can fit into an integer. At this point, we know button_down_time
4289 <= event->timestamp, so the difference must be nonnegative, so
4290 there's no need to cast the result if double-click-time is
4291 nonnegative, as it should be; check that it's nonnegative, just in
4292 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4293 apart (about 25 days). (Bug#8664)
8e55734a 4294
841f1b75 4295 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4296 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4297
3e26f69c
PE
4298 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4299 that always fit in int. Use a sentinel instead of a counter, to
4300 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4301 * frame.h (struct frame): Use int for menu_bar_items_used
4302 instead of EMACS_INT, since it always fits in int.
3e26f69c 4303
5cc152c0
PE
4304 * menu.c (grow_menu_items): Check for int overflow.
4305
d89eb65e
PE
4306 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4307
5235bd3e
PE
4308 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4309 Before, the code was not consistent. These values cannot exceed
4310 2**31 - 1 so there's no need to make them unsigned.
4311 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4312 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4313 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4314 as modifiers.
4315 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4316
bc827e23
PE
4317 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4318 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4319 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4320 presumably because the widths might not match.
4321
78eb494e
PE
4322 * window.c (size_window): Avoid needless test at loop start.
4323
04f2d78b
CB
43242011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4325
4326 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4327
d2fc7e3d 43282011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4329
4330 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4331
d2fc7e3d 43322011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4333
4334 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4335 `width' to `bar_area_x' and `bar_area_width', respectively.
4336 (x_scroll_run): Take account of fringe background extension.
4337
04f2d78b
CB
4338 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4339 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4340 `bar_area_width', respectively.
4341 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4342 background extension.
4343
79b70037
GM
43442011-05-10 Jim Meyering <meyering@redhat.com>
4345
4346 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4347
2f142cc5
JB
43482011-05-10 Juanma Barranquero <lekktu@gmail.com>
4349
4350 * image.c (Finit_image_library): Return t for built-in image types,
4351 like pbm and xbm. (Bug#8640)
4352
57679c86
AS
43532011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4354
4355 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4356
888c9e86
EZ
43572011-05-07 Eli Zaretskii <eliz@gnu.org>
4358
b0512a1d
EZ
4359 * w32console.c (Fset_screen_color): Doc fix.
4360 (Fget_screen_color): New function.
4361 (syms_of_ntterm): Defsubr it.
4362
7285dc67
EZ
4363 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4364 unlink the temporary file if Fcall_process didn't create it in the
4365 first place.
4366 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4367 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4368 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4369 cue to call_process_cleanup not to close that handle.
4370
4d3fcc8e
BK
43712011-05-07 Ben Key <bkey76@gmail.com>
4372
4373 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4374 one of two shell specific rules, either bootstrap-temacs-CMD or
4375 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4376 to the previous implementation of the bootstrap-temacs rule.
4377 The bootstrap-temacs-CMD rule is similar to the previous
4378 implementation of the bootstrap-temacs rule except that it
4379 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4380 variable.
4381
4382 These changes, along with some changes to nt/configure.bat,
4383 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4384 earlier fix to add support for --cflags and --ldflags options
4385 that include quotes so that it works whether make uses cmd or
4386 sh as the shell.
4387
b4289b64
MA
43882011-05-06 Michael Albinus <michael.albinus@gmx.de>
4389
4390 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4391 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4392 is a constant.
4393 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4394 a string. Handle both cases.
4395 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4396 (Fdbus_register_method): Use Qinvalid_function.
4397
af4c0e28
JB
43982011-05-06 Juanma Barranquero <lekktu@gmail.com>
4399
4400 * makefile.w32-in: Update dependencies.
4401 (LISP_H): Add inttypes.h and stdin.h.
4402 (PROCESS_H): Add unistd.h.
4403
c51453d9
EZ
44042011-05-06 Eli Zaretskii <eliz@gnu.org>
4405
4406 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4407 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4408
8ff0ac3c 44092011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4410
4c4b566b
PE
4411 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4412
aab2b9b5
PE
4413 * term.c (vfatal): Remove stray call to va_end.
4414 It's not needed and the C Standard doesn't allow it here anyway.
4415
c378da0b
PE
4416 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4417 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4418
288b08c7
PE
4419 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4420 bytes.
4421
e3601888
PE
4422 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4423
db6c0e74
PE
4424 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4425
dd5963ea
PE
4426 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4427
88c9450f
PE
4428 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4429
2f9442b8
PE
4430 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4431
c032b5f8
PE
4432 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4433 * charset.c (Fdefine_charset_internal): Don't initialize
4434 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4435 32-bit int (Bug#8600).
a108c10b
PE
4436
4437 * lread.c (read_integer): Be more consistent with string-to-number.
4438 Use string_to_number to do the actual conversion; this avoids
4439 rounding errors and fixes some other screwups. Without this fix,
4440 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4441 (digit_to_number): Move earlier, for benefit of read_integer.
4442 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4443 not a digit in any supported base. (Bug#8602)
a108c10b 4444
ad5f9eea
PE
4445 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4446
aec1708a
PE
4447 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4448 to match comment at start of function. This also removes a
4449 GCC warning about overflow in a 32+64-bit port.
4450
47be4ab5
PE
4451 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4452
371cac43
PE
4453 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4454 Reported by Stefan Monnier in
4455 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4456 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4457 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4458
d01a7826
PE
4459 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4460 (EMACS_UINTPTR): Likewise, with uintptr_t.
4461
7fd47d5c
PE
4462 * lisp.h: Prefer 64-bit EMACS_INT if available.
4463 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4464 on 32-bit hosts that have 64-bit int, so that they can access
4465 large files.
122b0c86
PE
4466 However, temporarily disable this change unless the temporary
4467 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4468
8727937b
PE
4469 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4470
8ac068ac
PE
4471 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4472 This removes an assumption that EMACS_INT and long are the same
4473 width as pointers. The assumption is true for Emacs porting targets
4474 now, but we want to make other targets possible.
4475 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4476 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4477 In the rest of the code, change types of integers that hold casted
4478 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4479 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4480 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4481 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4482 No need to cast type when ORing.
4483 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4484 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4485 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4486 assume EMACS_INT is the same width as char *.
4487 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4488 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4489 Remove no-longer-needed casts.
4490 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4491 (xg_tool_bar_help_callback, xg_make_tool_item):
4492 Use EMACS_INTPTR to hold an integer
4493 that will be cast to void *; this can avoid a GCC warning
4494 if EMACS_INT is not the same width as void *.
4495 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4496 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4497 (current_message_1, set_message_1):
4498 Use a local to convert to proper width without a cast.
4499 * xmenu.c (dialog_selection_callback): Likewise.
4500
ede49d71
PE
4501 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4502 Also, don't assume VALBITS / RAND_BITS is less than 5,
4503 and don't rely on undefined behavior when shifting a 1 left into
4504 the sign bit.
4505 * lisp.h (get_random): Change signature to match.
4506
2f30ecd0
PE
4507 * lread.c (hash_string): Use size_t, not int, for hash computation.
4508 Normally we prefer signed values; but hashing is special, because
4509 it's better to use unsigned division on hash table sizes so that
4510 the remainder is nonnegative. Also, size_t is the natural width
4511 for hashing into memory. The previous code used 'int', which doesn't
4512 retain enough info to hash well into very large tables.
4513 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4514
2a866e7b
PE
4515 * dbusbind.c: Don't possibly lose pointer info when converting.
4516 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4517 Use XPNTR rather than XHASH, so that the high-order bits of
4518 the pointer aren't lost when converting through void *.
4519
51639eac
PE
4520 * eval.c (Fautoload): Don't double-shift a pointer.
4521
92394119
PE
4522 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4523
dbdb9a7c
JB
45242011-05-06 Juanma Barranquero <lekktu@gmail.com>
4525
4526 * gnutls.c (DEF_GNUTLS_FN):
4527 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4528
db7a0b4f
AS
45292011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4530
4531 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4532 marker. (Bug#8610)
4533
f7ff1b0f 45342011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4535
4536 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4537 New version that can reserve upto 2GB of heap space.
4538
f7ff1b0f 45392011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4540
4541 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4542
639c109b
TZ
45432011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4544
4545 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4546 `gnutls_certificate_set_x509_key_file'.
4547
d2127135
JB
45482011-05-05 Juanma Barranquero <lekktu@gmail.com>
4549
4550 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4551 Update dependencies.
4552
e968f4f3
JB
45532011-05-04 Juanma Barranquero <lekktu@gmail.com>
4554
4555 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4556 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4557 Remove unused parameter `fildes'.
4558 * process.c (read_process_output, send_process): Don't pass it.
4559
84d358f0
JB
45602011-05-04 Juanma Barranquero <lekktu@gmail.com>
4561
4562 Fix previous change: the library cache is defined in w32.c.
4563 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4564 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4565
0898ca10
JB
45662011-05-04 Juanma Barranquero <lekktu@gmail.com>
4567
4568 Implement dynamic loading of GnuTLS on Windows.
4569
4570 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4571 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4572 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4573 Declare.
4574
4575 * gnutls.c (Qgnutls_dll): Define.
4576 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4577 (gnutls_*): Declare function pointers.
4578 (init_gnutls_functions): New function to initialize function pointers.
4579 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4580 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4581 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4582 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4583 (emacs_gnutls_write, emacs_gnutls_read)
4584 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4585 (Fgnutls_available_p): New function.
4586 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4587 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4588 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4589
4590 * image.c: Include w32.h.
4591 (Vimage_type_cache): Delete.
4592 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4593 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4594 (w32_delayed_load): Move to w32.c.
4595
4596 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4597
4598 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4599 (w32_delayed_load): Move from image.c. When loading a library, record
4600 its filename in the :loaded-from property of the library id.
4601 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4602 Initialize and staticpro them.
4603 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4604
4605 * process.c: Include lisp.h before w32.h, not after.
4606 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4607 instead of gnutls_record_check_pending.
4608
4609 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4610
ff4de4aa
TZ
46112011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4612
4613 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4614 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4615 as passed in.
4616
abe95abb
JD
46172011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4618
4619 * xterm.c (x_set_frame_alpha): Do not set property on anything
4620 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4621
e16e55d4
JB
46222011-05-02 Juanma Barranquero <lekktu@gmail.com>
4623
4624 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4625
bafcf6a5
JB
46262011-05-02 Juanma Barranquero <lekktu@gmail.com>
4627
4628 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4629 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4630 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4631 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4632 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4633 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4634 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4635 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4636 (Qgnutls_bootprop_callbacks_verify): Make static.
4637
e7a6747f
AS
46382011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4639
19ed11ba
AS
4640 * callproc.c: Indentation fixup.
4641
e7a6747f 4642 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4643 (wait_for_termination, interruptible_wait_for_termination):
4644 Move after wait_for_termination_1.
e7a6747f 4645
1ef14cb4
LMI
46462011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4647
4648 * sysdep.c (interruptible_wait_for_termination): New function
4649 which is like wait_for_termination, but allows keyboard
4650 interruptions.
4651
4652 * callproc.c (Fcall_process): Add (:file "file") as an option for
4653 the STDOUT buffer.
4654 (Fcall_process_region): Ditto.
4655
330d880c
EZ
46562011-04-30 Eli Zaretskii <eliz@gnu.org>
4657
8db90b73
EZ
4658 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4659 rather than `XVECTOR (FOO)->size'.
4660
330d880c
EZ
4661 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4662 inttypes.h, as a gnulib replacement is used if it not available in
4663 system headers.
4664
15cbd324
EZ
46652011-04-21 Eli Zaretskii <eliz@gnu.org>
4666
4667 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4668 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4669 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4670
4671 * coding.c (coding_alloc_by_realloc): Error out if destination
4672 will grow beyond MOST_POSITIVE_FIXNUM.
4673 (decode_coding_emacs_mule): Abort if there isn't enough place in
4674 charbuf for the composition carryover bytes. Reserve an extra
4675 space for up to 2 characters produced in a loop.
4676 (decode_coding_iso_2022): Abort if there isn't enough place in
4677 charbuf for the composition carryover bytes.
4678
46792011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4680
ae940cca
EZ
4681 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4682 aborting when %lld or %lll format is passed.
4683 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4684 %llo or %llx format is passed. (Bug#8545)
4685
03ab8921
EZ
4686 * window.c (window_scroll_line_based): Use a marker instead of
4687 simple variables to record original value of point. (Bug#7952)
4688
afda1437
EZ
4689 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4690 produced by %s or %c overflows available buffer space. (Bug#8545)
4691
f76dee0c
PE
46922011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4693
4694 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4695 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4696
fdc5744d
JB
46972011-04-28 Juanma Barranquero <lekktu@gmail.com>
4698
4699 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4700
638f053a
JB
47012011-04-28 Juanma Barranquero <lekktu@gmail.com>
4702
4703 * keyboard.c (Qdelayed_warnings_hook): Define.
4704 (command_loop_1): Run `delayed-warnings-hook'
4705 if Vdelayed_warnings_list is non-nil.
4706 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4707 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4708
d178f871
EZ
47092011-04-28 Eli Zaretskii <eliz@gnu.org>
4710
4711 * doprnt.c (doprnt): Don't return value smaller than the buffer
4712 size if the message was truncated. (Bug#8545).
4713
b124fd93
JB
47142011-04-28 Juanma Barranquero <lekktu@gmail.com>
4715
4716 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4717 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4718
e810457d
PE
47192011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4720
4721 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4722
ea51cceb
JB
47232011-04-27 Juanma Barranquero <lekktu@gmail.com>
4724
4725 * makefile.w32-in: Update dependencies.
4726
94dcfacf
EZ
47272011-04-27 Eli Zaretskii <eliz@gnu.org>
4728
4729 Improve `doprnt' and its usage. (Bug#8545)
4730 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4731 `format_end'. Remove support for %l as a conversion specifier.
4732 Don't use xrealloc. Improve diagnostics when the %l size modifier
4733 is used. Update the commentary.
4734
4735 * eval.c (verror): Simplify calculation of size_t.
4736
4737 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4738 messages.
4739
f61f41d7
PE
47402011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4741
4742 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4743 change.
4744
96fb4434
PE
47452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4746
4747 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4748 This makes this file independent of the recent pseudovector change.
4749
671875da 47502011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4751
69e9b5a3
PE
4752 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4753
b5f869a7 4754 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4755 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4756 Remove unused local.
c8926152 4757 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4758
841a1577 4759 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4760 GCC 4.6.0 optimizes based on type-based alias analysis.
4761 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4762 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4763 != &v->size, and therefore "v->size = 1; b->size = 2; return
4764 v->size;" must therefore return 1. This assumption is incorrect
4765 for Emacs, since it type-puns struct Lisp_Vector * with many other
4766 types. To fix this problem, this patch adds a new type struct
f904488f 4767 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4768 and pseudovectors, and helps optimizing compilers not get fooled
4769 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4770 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4771 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4772 the size member.
eab3844f
PE
4773 (XSETPVECTYPE): Rewrite in terms of new macro.
4774 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4775 This is a bit clearer, and further avoids the possibility of
4776 undesirable aliasing.
4777 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4778 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4779 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4780 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4781 (ASIZE): Now uses header.size rather than size.
4782 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4783 to avoid the hassle of writing XVECTOR (foo)->header.size.
4784 (struct vectorlike_header): New type.
eab3844f
PE
4785 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4786 object, to help avoid aliasing.
4787 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4788 (SUBRP): Likewise, since Lisp_Subr is a special case.
4789 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4790 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4791 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4792 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4793 changed to be "header.size" and "header.next".
4794 * buffer.h (struct buffer): Likewise.
4795 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4796 * frame.h (struct frame): Likewise.
4797 * process.h (struct Lisp_Process): Likewise.
4798 * termhooks.h (struct terminal): Likewise.
4799 * window.c (struct save_window_data, struct saved_window): Likewise.
4800 * window.h (struct window): Likewise.
4801 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4802 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4803 * buffer.c (init_buffer_once): Likewise.
4804 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4805 special case.
4806 * process.c (Fformat_network_address): Use local var for size,
4807 for brevity.
4808
0df1eac5
PE
4809 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4810
847ab9d1 4811 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4812 * data.c (atof): Remove decl; no longer used or needed.
4813 (digit_to_number): Move to lread.c.
4814 (Fstring_to_number): Use new string_to_number function, to be
4815 consistent with how the Lisp reader treats infinities and NaNs.
4816 Do not assume that floating-point numbers represent EMACS_INT
4817 without losing information; this is not true on most 64-bit hosts.
4818 Avoid double-rounding errors, by insisting on integers when
4819 parsing non-base-10 numbers, as the documentation specifies.
4820 * lisp.h (string_to_number): New decl, replacing ...
4821 (isfloat_string): Remove.
bc0a5c13 4822 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4823 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4824 appears to have been a coding error. Similarly, do not accept
4825 strings like +-1e0 as floating point numbers. Do not report
4826 overflow for integer overflows unless the base is not 10 which
4827 means we have no simple and reliable way to continue.
4828 Break out the floating-point parsing into a new
4829 function string_to_number, so that Fstring_to_number parses
4830 floating point numbers consistently with the Lisp reader.
04f2d78b 4831 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4832 (E_CHAR, EXP_INT): Remove, replacing with ...
4833 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4834 (string_to_number): New function, replacing isfloat_string.
4835 This function checks for valid syntax and produces the resulting
4836 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4837 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4838 so that overflow for non-base-10 numbers is reported only when
4839 there's no portable and simple way to convert to floating point.
452f4150 4840
67769ffc
PE
4841 * textprop.c (set_text_properties_1): Rewrite for clarity,
4842 and to avoid GCC warning about integer overflow.
4843
c20db43f
PE
4844 * intervals.h (struct interval): Use EMACS_INT for members
4845 where EMACS_UINT might cause problems. See
4846 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4847 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4848 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4849 All uses changed.
37aa2f85
PE
4850 (offset_intervals): Tell GCC not to worry about length overflow
4851 when negating a negative length.
c20db43f 4852
2538aa2f
PE
4853 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4854 (overrun_check_free): Likewise.
4855
f2d3008d
PE
4856 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4857 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4858 word size.
4859
ec8df744
PE
4860 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4861 (gnutls_make_error): Rename local to avoid shadowing.
4862 (gnutls_emacs_global_deinit): ifdef out; not used.
4863 (Fgnutls_boot): Use const for pointer to readonly storage.
4864 Comment out unused local. Fix pointer signedness problems.
4865
640ee02d
PE
4866 * lread.c (openp): Don't stuff size_t into an 'int'.
4867 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4868 about possible signed overflow.
4869
6048fb2a
PE
4870 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4871 (GDK_KEY_g): Don't define if already defined.
4872 (xg_prepare_tooltip): Avoid pointer signedness problem.
4873 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4874
fa3c87e1
PE
4875 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4876 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4877
2172544b
PE
4878 * xfns.c (Fx_window_property): Simplify a bit,
4879 to make a bit faster and to avoid GCC 4.6.0 warning.
4880 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4881
9b821a21
PE
4882 * fns.c (internal_equal): Don't assume size_t fits in int.
4883
3c616cfa
PE
4884 * alloc.c (compact_small_strings): Tighten assertion a little.
4885
c2982e87
PE
4886 Replace pEd with more-general pI, and fix some printf arg casts.
4887 * lisp.h (pI): New macro, generalizing old pEd macro to other
4888 conversion specifiers. For example, use "...%"pI"d..." rather
4889 than "...%"pEd"...".
4890 (pEd): Remove. All uses replaced with similar uses of pI.
4891 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4892 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4893 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4894 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4895 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4896 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4897 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4898 64-bit hosts.
4899 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4900 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4901 * print.c (safe_debug_print, print_object): Likewise.
4902 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4903 to int.
6f04d126
PE
4904 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4905 avoiding the 0 flag, which is not portable.
c2982e87
PE
4906 * process.c (Fmake_network_process): Use pI to avoid cast.
4907 * region-cache.c (pp_cache): Likewise.
4908 * xdisp.c (decode_mode_spec): Likewise.
4909 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4910 behavior on 64-bit hosts with printf arg.
6f04d126 4911 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4912 (x_stop_queuing_selection_requests): Likewise.
4913 (x_get_window_property): Don't truncate byte count to an 'int'
4914 when tracing.
0b432f21 4915
5e073ec7
PE
4916 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4917 here, since it parses constructs like leading '-' and spaces,
4918 which are not wanted; and it overflows with large numbers.
4919 Instead, simply match F[0-9]+, which is what is wanted anyway.
4920
36372bf9
PE
4921 * alloc.c: Remove unportable assumptions about struct layout.
4922 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4923 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4924 (allocate_vectorlike, make_pure_vector): Use the new macros,
4925 plus offsetof, to remove unportable assumptions about struct layout.
4926 These assumptions hold on all porting targets that I know of, but
4927 they are not guaranteed, they're easy to remove, and removing them
4928 makes further changes easier.
4929
0b432f21
PE
4930 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4931 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4932 (string_overrun_cookie): Now const. Use initializers that
4933 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4934 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4935 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4936 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4937 multiple of sizeof (EMACS_INT); it need not be, if
4938 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4939 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4940
895009e1
JB
49412011-04-26 Juanma Barranquero <lekktu@gmail.com>
4942
4943 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4944
6a7a1b0b
TZ
49452011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4946
4947 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4948 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4949 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4950
841a1577 49512011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4952
4953 * lisp.h (Qdebug): List symbol.
895009e1 4954 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4955 * keyboard.c (debug-on-event): New variable.
4956 (handle_user_signal): Break into debugger when debug-on-event
4957 matches the current signal symbol.
4958
f2d3ba6f
DN
49592011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4960
4961 * alloc.c (check_sblock, check_string_bytes)
4962 (check_string_free_list): Convert to standard C.
4963
42ce4c63
TZ
49642011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4965
4966 * w32.c (emacs_gnutls_push): Fix typo.
4967
825cd63c
EZ
49682011-04-25 Eli Zaretskii <eliz@gnu.org>
4969
fb11d64d
EZ
4970 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4971 "cast to pointer from integer of different size".
4972
825cd63c
EZ
4973 Improve doprnt and its use in verror. (Bug#8545)
4974 * doprnt.c (doprnt): Document the set of format control sequences
4975 supported by the function. Use SAFE_ALLOCA instead of always
4976 using `alloca'.
4977
4978 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4979 is one byte too soon. Don't use xrealloc; instead xfree and
4980 xmalloc anew.
4981
e061a11b
TZ
49822011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4983
4984 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4985 callbacks stage.
4986
4987 * gnutls.c: Renamed global_initialized to
4988 gnutls_global_initialized. Added internals for the
4989 :verify-hostname-error, :verify-error, and :verify-flags
4990 parameters of `gnutls-boot' and documented those parameters in the
4991 docstring. Start callback support.
9173deec
JB
4992 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4993 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4994 on error. Return error code.
e061a11b
TZ
4995 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4996 (emacs_gnutls_read): Likewise.
4997 (Fgnutls_boot): Return handshake error code.
4998 (emacs_gnutls_handle_error): New function.
4999 (wsaerror_to_errno): Likewise.
5000
5001 * w32.h (emacs_gnutls_pull): Add prototype.
5002 (emacs_gnutls_push): Likewise.
5003
5004 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5005 (emacs_gnutls_push): Likewise.
5006
50072011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5008
5009 * process.c (wait_reading_process_output): Check if GnuTLS
5010 buffered some data internally if no FDs are set for TLS
5011 connections.
5012
5013 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5014 (LIBS): Link to USER_LIBS.
5015 ($(BLD)/gnutls.$(0)): New target.
5016
fa6996bc
EZ
50172011-04-24 Eli Zaretskii <eliz@gnu.org>
5018
eb35682e
EZ
5019 * xdisp.c (handle_single_display_spec): Rename the
5020 display_replaced_before_p argument into display_replaced_p, to
5021 make it consistent with the commentary. Fix typos in the
5022 commentary.
5023
e2ad650c
EZ
5024 * textprop.c (syms_of_textprop): Remove dead code.
5025 (copy_text_properties): Delete obsolete commentary about an
5026 interface that was deleted long ago. Fix typos in the description
5027 of arguments.
5028
1b2de274
EZ
5029 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5030 to changes in oldXMenu/XMenu.h from 2011-04-16.
5031 <menu_help_message, prev_menu_help_message>: Constify.
5032 (IT_menu_make_room): menu->help_text is now `const char **';
5033 adjust.
5034
5035 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5036 to changes in oldXMenu/XMenu.h from 2011-04-16.
5037 (struct XMenu): Declare `help_text' `const char **'.
5038
5039 * xfaces.c <Qunspecified>: Make extern again.
5040
5041 * syntax.c: Include sys/types.h before including regex.h, as
5042 required by Posix.
5043
762b15be
EZ
5044 * doc.c (get_doc_string): Improve the format passed to `error'.
5045
5046 * doprnt.c (doprnt): Improve commentary.
5047
5048 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5049
5050 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5051 them with etags.
5052
f1052e5d
EZ
5053 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5054 changes in globals.h immediately force recompilation.
762b15be
EZ
5055 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5056 $(CURDIR)/s/ms-w32.h.
5057 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5058
fa6996bc
EZ
5059 * character.c (Fchar_direction): Function deleted.
5060 (syms_of_character): Don't defsubr it.
5061 <char-direction-table>: Deleted.
5062
e6c3da20
EZ
50632011-04-23 Eli Zaretskii <eliz@gnu.org>
5064
5065 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5066 * doprnt.c: Include limits.h.
5067 (SIZE_MAX): New macro.
04f2d78b
CB
5068 (doprnt): Return a size_t value. 2nd arg is now size_t.
5069 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5070 Improve overflow protection. Support `l' modifier for integer
5071 conversions. Support %l conversion. Don't assume an EMACS_INT
5072 argument for integer conversions and for %c.
5073
5074 * lisp.h (doprnt): Restore prototype.
5075
5076 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5077 $(SRC)/character.h.
5078
5079 * Makefile.in (base_obj): Add back doprnt.o.
5080
5081 * deps.mk (doprnt.o): Add back prerequisites.
5082 (callint.o): Depend on character.h.
5083
5084 * eval.c (internal_lisp_condition_case): Include the handler
5085 representation in the error message.
5086 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5087 when breaking from the loop.
5088
5089 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5090
5091 * callint.c (Fcall_interactively): When displaying error message
5092 about invalid control letter, pass the character's codepoint, not
5093 a pointer to its multibyte form. Improve display of the character
5094 in octal and display also its hex code.
5095
5096 * character.c (char_string): Use %x to display the (unsigned)
5097 codepoint of an invalid character, to avoid displaying a bogus
5098 negative value.
5099
5100 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5101 `error', not SYMBOL_NAME itself.
5102
5103 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5104 character arguments to `error'.
5105
5106 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5107 to `error' in error message about FINAL_CHAR argument. Make sure
5108 FINAL_CHAR is a character, and use %c when it is passed as
5109 argument to `error'.
5110
4ffd0d6b 51112011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5112
5113 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5114
5115 * w32.c: Include <time.h>.
5116 (sys_localtime): New function.
5117
4ffd0d6b 51182011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5119
5120 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5121
4ffd0d6b 5122 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5123
4ffd0d6b 51242011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5125
4ffd0d6b
GM
5126 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5127 zombies (Bug#8467).
aac0c6e3 5128
04c56954
EZ
51292011-04-19 Eli Zaretskii <eliz@gnu.org>
5130
5131 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5132 gl_state.e_property when gl_state.object is Qt.
5133
5134 * insdel.c (make_gap_larger): Remove limitation of buffer size
5135 to <= INT_MAX.
5136
16a43933
CY
51372011-04-18 Chong Yidong <cyd@stupidchicken.com>
5138
5139 * xdisp.c (lookup_glyphless_char_display)
5140 (produce_glyphless_glyph): Handle cons cell entry in
5141 glyphless-char-display.
5142 (Vglyphless_char_display): Document it.
5143
5144 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5145 glyphless-char-display.
5146
4581706e
CY
51472011-04-17 Chong Yidong <cyd@stupidchicken.com>
5148
5149 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5150
5151 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5152
5153 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5154 definition for no-X builds.
5155
4887c6e2 51562011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5157
fd35b6f9
PE
5158 Static checks with GCC 4.6.0 and non-default toolkits.
5159
5c1ccb01
PE
5160 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5161
006c5daa
PE
5162 * process.c (keyboard_bit_set): Define only if SIGIO.
5163 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5164 (send_process): Repair possible setjmp clobbering.
5165
efc736d3
PE
5166 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5167
4e2fe2e6
PE
5168 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5169
f97334a2
PE
5170 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5171
4e75f29d
PE
5172 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5173 Define only if needed.
5174
90efadd1
PE
5175 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5176 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5177 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5178
3c647824
PE
5179 * dispextern.h (struct redisplay_interface): Rename param
5180 to avoid shadowing.
e264f262 5181 * termhooks.h (struct terminal): Likewise.
761383f4 5182 * xterm.c (xembed_send_message): Likewise.
3c647824 5183
b58c5c4a
PE
5184 * insdel.c (make_gap_smaller): Define only if
5185 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5186
cad59032
PE
5187 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5188 it.
5189
c339dc2e
PE
5190 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5191 so that we aren't warned about unused symbols.
5192
91a3e27b
PE
5193 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5194
399c71d3 5195 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5196
8ffc96f5
PE
5197 * xfns.c (x_real_positions): Mark locals as initialized.
5198
eef9bc79
PE
5199 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5200
098db9dd
PE
5201 * xterm.c: Fix problems found by static analysis with other toolkits.
5202 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5203 (x_dispatch_event): Declare static if USE_GTK, and
5204 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5205 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5206 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5207 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5208 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5209
eb18f6cc
PE
5210 * xmenu.c (menu_help_callback): Pointer type fixes.
5211 Use const pointers when pointing at readonly data. Avoid pointer
5212 signedness clashes.
5213 (FALSE): Remove unused macro.
5214 (update_frame_menubar): Remove unused decl.
5215
1fe72bf8
PE
5216 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5217
60d9e1db
PE
5218 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5219 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5220 (single_menu_item): Rename local to avoid shadowing.
5221
39261c26
PE
5222 * keyboard.c (make_lispy_event): Remove unused local var.
5223
018c5e19
PE
5224 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5225 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5226
63d2b86e
PE
5227 * bitmaps: Change bitmaps from unsigned char back to the X11
5228 compatible char. Avoid the old compiler warnings about
5229 out-of-range initializers by using, for example, '\xab' rather
5230 than 0xab.
5231
aefd87e1
PE
5232 * xgselect.c (xgselect_initialize): Check vs interface
5233 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5234
bf501fb9
PE
5235 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5236
e9829fdf
PE
5237 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5238 to read-only memory.
5239
1086c095
PE
5240 * fns.c (vector): Remove; this old hack is no longer needed.
5241
2baccd04 5242 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5243 Remove unused var.
dde42981 5244 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5245
72391843 5246 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5247
436c16df 5248 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5249 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5250 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5251
92bb796d 5252 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5253 (x_term_init): Remove local to avoid shadowing.
92bb796d 5254
764430a3 5255 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5256
5257 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5258 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5259
d1dfb56c
EZ
52602011-04-16 Eli Zaretskii <eliz@gnu.org>
5261
c4354cb4
EZ
5262 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5263
d1dfb56c
EZ
5264 Fix regex.c, syntax.c and friends for buffers > 2GB.
5265 * syntax.h (struct gl_state_s): Declare character position members
5266 EMACS_INT.
5267
5268 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5269
04f2d78b
CB
5270 * textprop.c (verify_interval_modification, interval_of):
5271 Declare arguments EMACS_INT.
d1dfb56c
EZ
5272
5273 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5274 EMACS_INT.
5275
5276 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5277
5278 * indent.c (Fvertical_motion): Local variable it_start is now
5279 EMACS_INT.
5280
5281 * regex.c (re_match, re_match_2, re_match_2_internal)
5282 (bcmp_translate, regcomp, regexec, print_double_string)
5283 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5284 (re_compile_pattern, re_exec): Declare arguments and local
5285 variables `size_t' and `ssize_t' and return values `regoff_t', as
5286 appropriate.
5287 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5288 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5289 <compile_stack_type>: `size' and `avail' are now `size_t'.
5290
5291 * regex.h <regoff_t>: Use ssize_t, not int.
5292 (re_search, re_search_2, re_match, re_match_2): Arguments that
5293 specify buffer/string position and length are now ssize_t and
5294 size_t. Return type is regoff_t.
5295
613052cd
BK
52962011-04-16 Ben Key <bkey76@gmail.com>
5297
5298 * nsfont.m: Fixed bugs in ns_get_family and
5299 ns_descriptor_to_entity that were caused by using free to
5300 deallocate memory blocks that were allocated by xmalloc (via
5301 xstrdup). This caused Emacs to crash when compiled with
5302 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5303 --enable-checking=xmallocoverrun). xfree is now used to
5304 deallocate these memory blocks.
5305
4170f62f 53062011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5307
71b41406
PE
5308 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5309
9587a89d
PE
5310 emacs_write: Accept and return EMACS_INT for sizes.
5311 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5312 et seq.
5313 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5314 Accept and return EMACS_INT.
5315 (emacs_gnutls_write): Return the number of bytes written on
5316 partial writes.
5317 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5318 (emacs_read, emacs_write): Remove check for negative size, as the
5319 Emacs source code has been audited now.
9587a89d
PE
5320 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5321 (emacs_read, emacs_write): Use it.
273a5f82
PE
5322 * process.c (send_process): Adjust to the new signatures of
5323 emacs_write and emacs_gnutls_write. Do not attempt to store
5324 a byte offset into an 'int'; it might overflow.
9587a89d 5325 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5326
3e047f51
PE
5327 * sound.c: Don't assume sizes fit in 'int'.
5328 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5329 Return EMACS_INT, not int.
3e047f51 5330 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5331 Accept EMACS_INT, not int.
5332 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5333 record read return values.
5334
cc39a9db
BK
53352011-04-15 Ben Key <bkey76@gmail.com>
5336
c9d0ec6d
JB
5337 * keyboard.c (Qundefined): Don't declare static since it is used
5338 in nsfns.m.
5339 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5340 static since they are used in nsfont.m.
cc39a9db 5341
6c60eb9f
SM
53422011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5343
5344 * process.c (Qprocessp): Don't declare static.
5345 * lisp.h (Qprocessp): Declare again.
5346
7990b61a
JB
53472011-04-15 Juanma Barranquero <lekktu@gmail.com>
5348
5349 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5350
5d4cb038
PE
53512011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5352
8bd7b830 5353 Improve C-level modularity by making more things 'static'.
cd64ea1d 5354
e3b27b31
PE
5355 Don't publish debugger-only interfaces to other modules.
5356 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5357 (verify_bytepos, count_markers): Move decls to the only modules
5358 that need them.
5359 * region-cache.h (pp_cache): Likewise.
5360 * window.h (check_all_windows): Likewise.
5361 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5362
5d4cb038
PE
5363 * sysdep.c (croak): Now static, if
5364 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5365 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5366
5367 * alloc.c (refill_memory_reserve): Now static if
5368 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5369 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5370
e87b6180
PE
5371 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5372 Define only if USE_LUCID.
5373
ac64929e
PE
5374 * xrdb.c (x_customization_string, x_rm_string): Now static.
5375
6f37259d
PE
5376 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5377 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5378
1683e3ab
PE
5379 * xdisp.c (draw_row_with_mouse_face): Now static.
5380 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5381
de9c2632
PE
5382 * window.h (check_all_windows): Mark externally visible.
5383
2b96acb7
PE
5384 * window.c (window_deletion_count): Now static.
5385
5386 * undo.c: Make symbols static if they're not exported.
5387 (last_undo_buffer, last_boundary_position, pending_boundary):
5388 Now static.
5389
50436f33
PE
5390 * textprop.c (interval_insert_behind_hooks): Now static.
5391 (interval_insert_in_front_hooks): Likewise.
5392
64520e5c
PE
5393 * term.c: Make symbols static if they're not exported.
5394 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5395 (max_frame_lines, tty_set_terminal_modes):
5396 (tty_reset_terminal_modes, tty_turn_off_highlight):
5397 (get_tty_terminal): Now static.
5398 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5399 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5400 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5401 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5402 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5403
1fa53021
PE
5404 * sysdep.c: Make symbols static if they're not exported.
5405 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5406 Now static.
5407 (sigprocmask_set, full_mask): Remove; unused.
5408 (wait_debugging): Mark as visible.
5409 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5410 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5411
d4b43b22
PE
5412 * syntax.c (syntax_temp): Define only if !__GNUC__.
5413
b7c513d0
PE
5414 * sound.c (current_sound_device, current_sound): Now static.
5415
989b29ad
PE
5416 * search.c (searchbufs, searchbuf_head): Now static.
5417
13a55a78
PE
5418 * scroll.c (scroll_cost): Remove; unused.
5419 * dispextern.h (scroll_cost): Remove decl.
5420
de68a1fc
PE
5421 * region-cache.h (pp_cache): Mark as externally visible.
5422
40ccffa6
PE
5423 * process.c: Make symbols static if they're not exported.
5424 (process_tick, update_tick, create_process, chan_process):
5425 (Vprocess_alist, proc_buffered_char, datagram_access):
5426 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5427 (deactivate_process): Mark defn as static, as well as decl.
5428 * lisp.h (create_process): Remove decl.
5429 * process.h (chan_process, Vprocess_alist): Remove decls.
5430
ad64fc97
PE
5431 * print.c: Make symbols static if they're not exported.
5432 (print_depth, new_backquote_output, being_printed, print_buffer):
5433 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5434 (print_interval, print_number_index, initial_stderr_stream):
5435 Now static.
5436 * lisp.h (Fprinc): Remove decl.
5437 (debug_output_compilation_hack): Mark as externally visible.
5438
adddb265
PE
5439 * sysdep.c (croak): Move decl from here to syssignal.h.
5440 * syssignal.h (croak): Put it here, so the API can be checked when
5441 'croak' is called from dissociate_if_controlling_tty.
5442
1717ede2
PE
5443 * minibuf.c: Make symbols static if they're not exported.
5444 (minibuf_save_list, choose_minibuf_frame): Now static.
5445 * lisp.h (choose_minibuf_frame): Remove decl.
5446
fa5fb2bc
PE
5447 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5448
1e3890d1
PE
5449 * lread.c: Make symbols static if they're not exported.
5450 (read_objects, initial_obarray, oblookup_last_bucket_number):
5451 Now static.
5452 (make_symbol): Remove; unused.
5453 * lisp.h (initial_obarray, make_symbol): Remove decls.
5454
8a1414fa
PE
5455 * keyboard.c: Make symbols static if they're not exported.
5456 (single_kboard, recent_keys_index, total_keys, recent_keys):
5457 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5458 (this_single_command_key_start, echoing, last_auto_save):
5459 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5460 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5461 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5462 (Vlispy_mouse_stem, double_click_count):
5463 Now static.
5464 (force_auto_save_soon): Define only if SIGDANGER.
5465 (ignore_mouse_drag_p): Now static if
5466 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5467 (print_help): Remove; unused.
5468 (stop_character, last_timer_event): Mark as externally visible.
5469 * keyboard.h (ignore_mouse_drag_p): Declare only if
5470 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5471 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5472 * lisp.h (echoing): Remove decl.
5473 (force_auto_save_soon): Declare only if SIGDANGER.
5474 * xdisp.c (redisplay_window): Simplify code, to make it more
5475 obvious that ignore_mouse_drag_p is not accessed if !defined
5476 USE_GTK && !defined HAVE_NS.
5477
93ea6e8f
PE
5478 * intervals.c: Make symbols static if they're not exported.
5479 (merge_properties_sticky, merge_interval_right, delete_interval):
5480 Now static.
5481 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5482
77382fcc
PE
5483 * insdel.c: Make symbols static if they're not exported.
5484 However, leave prepare_to_modify_buffer alone. It's never
5485 called from outside this function, but that appears to be a bug.
5486 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5487 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5488 (adjust_after_replace_noundo): Remove; unused.
5489 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5490 (signal_before_change): Remove decls.
77382fcc 5491
9306c32e
PE
5492 * indent.c (val_compute_motion, val_vmotion): Now static.
5493
cd44d2eb
PE
5494 * image.c: Make symbols static if they're not exported.
5495 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5496 if USE_GTK.
5497 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5498 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5499
ad9a7a06
PE
5500 * fringe.c (standard_bitmaps): Now static.
5501 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5502
81626931
PE
5503 * frame.c: Make symbols static if they're not exported.
5504 (x_report_frame_params, make_terminal_frame): Now static.
5505 (get_frame_param): Now static, unless HAVE_NS.
5506 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5507 (x_get_resource_string): Remove; not used.
5508 * frame.h (make_terminal_frame, x_report_frame_params):
5509 (x_get_resource_string); Remove decls.
5510 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5511 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5512
239f9db9
PE
5513 * font.c, fontset.c: Make symbols static if they're not exported.
5514 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5515 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5516 * font.c (font_close_object): Now static.
5517 * font.h (font_close_object): Remove.
5518 * fontset.c (FONTSET_OBJLIST): Remove.
5519 (free_realized_fontset) #if-0 the body, which does nothing.
5520 (face_suitable_for_char_p): #if-0, as it's never called.
5521 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5522 * xfaces.c (face_at_string_position):
5523 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5524 since 0 is always ASCII.
5525
dfcf3579
PE
5526 * fns.c (weak_hash_tables): Now static.
5527
5045092b
PE
5528 * fileio.c: Make symbols static if they're not exported.
5529 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5530 (Vwrite_region_annotation_buffers): Now static.
5531
57a96f5c
PE
5532 * eval.c: Make symbols static if they're not exported.
5533 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5534 * lisp.h (backtrace_list): Remove decl.
5535
35f08c38
PE
5536 * emacs.c: Make symbols static if they're not exported.
5537 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5538 (fatal_error_code, fatal_error_signal_hook, standard_args):
5539 Now static.
5540 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5541 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5542 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5543 * lisp.h (fatal_error_signal_hook): Remove decl.
5544 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5545
f44bd759
PE
5546 * editfns.c: Move a (normally-unused) function to its only use.
5547 * editfns.c, lisp.h (get_operating_system_release): Remove.
5548 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5549 worth the hassle of breaking this out.
5550
b532497d
PE
5551 * xterm.c: Make symbols static if they're not exported.
5552 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5553 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5554 (x_destroy_window, x_delete_display):
5555 Now static.
5556 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5557 (x_mouse_leave): Remove; unused.
5558 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5559 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5560 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5561 Remove decls.
5562 (x_mouse_leave): Declare only if WINDOWSNT.
5563 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5564 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5565 USE_X_TOOLKIT.
5566
1675728f
PE
5567 * ftxfont.c: Make symbols static if they're not exported.
5568 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5569 HAVE_FREETYPE.
5570 * font.h (ftxfont_driver): Likewise.
5571
e4cebfca
PE
5572 * xfns.c: Make symbols static if they're not exported.
5573 (x_last_font_name, x_display_info_for_name):
5574 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5575 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5576 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5577 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5578 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5579 (last_show_tip_args): Now static.
5580 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5581 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5582 (x_screen_planes): Remove; unused.
5583 * dispextern.h (x_screen_planes): Remove decl.
5584
5bf46f05
PE
5585 * dispnew.c: Make symbols static if they're not exported.
5586 * dispextern.h (redraw_garbaged_frames, scrolling):
5587 (increment_row_positions): Remove.
5588 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5589 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5590 Now static.
5591 (redraw_garbaged_frames): Remove; unused.
5592
435f4c28
PE
5593 * xfaces.c: Make symbols static if they're not exported.
5594 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5595 Remove decls.
5596 * xterm.h (defined_color): Remove decls.
5597 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5598 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5599 (menu_face_changed_default, defined_color, free_realized_face):
5600 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5601 (ascii_face_of_lisp_face): Remove; unused.
5602
8524aef3
PE
5603 * xdisp.c: Make symbols static if they're not exported.
5604 * dispextern.h (scratch_glyph_row, window_box_edges):
5605 (glyph_to_pixel_coords, set_cursor_from_row):
5606 (get_next_display_element, set_iterator_to_next):
5607 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5608 (show_mouse_face): Remove decls
5609 * frame.h (message_buf_print): Likewise.
5610 * lisp.h (pop_message, set_message, check_point_in_composition):
5611 Likewise.
5612 * xterm.h (set_vertical_scroll_bar): Likewise.
5613 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5614 (message_buf_print, scratch_glyph_row, displayed_buffer):
5615 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5616 (get_next_display_element, show_mouse_face, window_box_edges):
5617 (frame_to_window_pixel_xy, check_point_in_composition):
5618 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5619 (glyph_to_pixel_coords): Remove; unused.
5620
16390cd2
PE
5621 * dired.c (file_name_completion): Now static.
5622
5623 * dbusbind.c (xd_in_read_queued_messages): Now static.
5624
a25f4dfa
PE
5625 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5626 * data.c (circular_list_error): Remove.
5627
14a9c8df
PE
5628 * commands.h (last_point_position, last_point_position_buffer):
5629 (last_point_position_window): Remove decls.
5630 * keyboard.c: Make these variables static.
5631
04f2d78b
CB
5632 * coding.h (coding, code_convert_region, encode_coding_gap):
5633 Remove decls.
74ab6df5
PE
5634 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5635 (iso_code_class, detect_coding, code_convert_region): Now static.
5636 (encode_coding_gap): Remove; unused.
5637
38dfbee1
PE
5638 * chartab.c (chartab_chars, chartab_bits): Now static.
5639
a2cb4e63
PE
5640 * charset.h (charset_iso_8859_1): Remove decl.
5641 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5642 Now static.
5643
127198fd
PE
5644 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5645 * ccl.c (Vccl_program_table): Now static.
5646 (check_ccl_update): Remove; unused.
5647
d85b608f
PE
5648 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5649 * category.h: ... from here.
5650 * category.c (check_category_table, set_category_set): Now static.
5651
31cd66f3
PE
5652 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5653 * lisp.h: Remove these decls.
5654
c358e587
PE
5655 * buffer.c (buffer_count): Remove unused var.
5656
e78aecca
PE
5657 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5658 so that it's not optimized away.
5659 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5660 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5661 exported only to the debugger.
5662
e192d7d3 5663 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5664 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5665
92470028
PE
5666 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5667 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5668 was inaccessible from Lisp.
5669 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5670 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5671
244ed907
PE
5672 alloc.c: Import and export fewer symbols, and remove unused items.
5673 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5674 is defined.
5675 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5676 it's not optimized away by whole-program optimization.
5677 (message_enable_multibyte, free_misc): Remove.
5678 (catchlist, handlerlist, mark_backtrace):
5679 Declare only if BYTE_MARK_STACK.
5680 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5681 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5682 (message_enable_multibyte): Remove decl.
5683 (free_misc, interval_free_list, float_block, float_block_index):
5684 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5685 (cons_free_list, last_marked_index):
5686 Now static.
5687 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5688 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5689 (mark_backtrace): Define only if BYTE_MARK_STACK.
5690 * xdisp.c (message_enable_multibyte): Now static.
5691
61c2b50e 5692 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5693 This makes it easier for human readers (and static analyzers)
5694 to see whether these variables are used from other modules.
5695 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5696 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5697 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5698 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5699 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5700 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5701 * xmenu.c, xselect.c:
5702 Declare Q* vars static if they are not used in other modules.
5703 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5704 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5705 Remove decls of unexported vars.
5706 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5707
95c82688
PE
5708 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5709
16a97296
PE
5710 Make Emacs functions such as Fatom 'static' by default.
5711 This makes it easier for human readers (and static analyzers)
5712 to see whether these functions can be called from other modules.
5713 DEFUN now defines a static function. To make the function external
5714 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5715 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5716 (Finit_image_library):
16a97296
PE
5717 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5718 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5719 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5720 Remove decls, since these functions are now static.
5721 (Funintern, Fget_internal_run_time): New decls, since these functions
5722 were already external.
95c82688 5723
16a97296
PE
5724 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5725 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5726 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5727 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5728 * keyboard.c, keymap.c, lread.c:
5729 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5730 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5731 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5732 Mark functions with DEFUE instead of DEFUN,
5733 if they are used in other modules.
5734 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5735 decls for now-static functions.
5736 * buffer.h (Fdelete_overlay): Remove decl.
5737 * callproc.c (Fgetenv_internal): Mark as internal.
5738 * composite.c (Fremove_list_of_text_properties): Remove decl.
5739 (Fcomposition_get_gstring): New forward static decl.
5740 * composite.h (Fcomposite_get_gstring): Remove decl.
5741 * dired.c (Ffile_attributes): New forward static decl.
5742 * doc.c (Fdocumntation_property): New forward static decl.
5743 * eval.c (Ffetch_bytecode): New forward static decl.
5744 (Funintern): Remove extern decl; now in .h file where it belongs.
5745 * fileio.c (Fmake_symbolic_link): New forward static decl.
5746 * image.c (Finit_image_library): New forward static decl.
5747 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5748 * intervals.h (Fprevious_property_change):
5749 (Fremove_list_of_text_properties): Remove decls.
5750 * keyboard.c (Fthis_command_keys): Remove decl.
5751 (Fcommand_execute): New forward static decl.
5752 * keymap.c (Flookup_key): New forward static decl.
5753 (Fcopy_keymap): Now static.
5754 * keymap.h (Flookup_key): Remove decl.
5755 * process.c (Fget_process): New forward static decl.
5756 (Fprocess_datagram_address): Mark as internal.
5757 * syntax.c (Fsyntax_table_p): New forward static decl.
5758 (skip_chars): Remove duplicate decl.
5759 * textprop.c (Fprevious_property_change): New forward static decl.
5760 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5761 Now internal.
5762 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5763 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5764
785bbd42
PE
5765 * editfns.c (Fformat): Remove unreachable code.
5766
8b913b57
AS
57672011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5768
5769 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5770 change. (Bug#8496)
5771
a6744a35
EZ
57722011-04-13 Eli Zaretskii <eliz@gnu.org>
5773
5774 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5775 when at ZV. (Bug#8487)
5776
e7974947
AS
57772011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5778
baad03f0
AS
5779 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5780 (Bug#8437)
5781 * keyboard.c (parse_tool_bar_item): Likewise.
5782 * sound.c (sound_cleanup, alsa_close): Likewise.
5783 * termcap.c (tgetent): Likewise.
5784 * xfns.c (x_default_font_parameter): Likewise.
5785 * xsettings.c (read_and_apply_settings): Likewise.
5786
e7974947
AS
5787 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5788 (overrun_check_free): Protoize.
5789
28272684
PE
57902011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5791
5792 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5793 since callers should never pass a negative size.
5794 Change the signature to match that of plain 'read' and 'write'; see
5795 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5796 * lisp.h: Update prototypes of emacs_write and emacs_read.
5797
11997c76
EZ
57982011-04-11 Eli Zaretskii <eliz@gnu.org>
5799
5800 * xdisp.c (redisplay_window): Don't try to determine the character
5801 position of the scroll margin if the window start point w->startp
e896f03c 5802 is outside the buffer's accessible region. (Bug#8468)
11997c76 5803
8a2cbd72
EZ
58042011-04-10 Eli Zaretskii <eliz@gnu.org>
5805
5806 Fix write-region and its subroutines for buffers > 2GB.
5807 * fileio.c (a_write, e_write): Modify declaration of arguments and
5808 local variables to support buffers larger than 2GB.
5809 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5810
5811 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5812 argument, local variables, and return value.
5813
5814 * lisp.h: Update prototypes of emacs_write and emacs_read.
5815
5816 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5817
4073e537 58182011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5819
1ebfdcb6
PE
5820 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5821
b2ded58d
PE
5822 Fix more problems found by GCC 4.6.0's static checks.
5823
7d66342c
PE
5824 * xdisp.c (vmessage): Use a better test for character truncation.
5825
bbf47d44
PE
5826 * charset.c (load_charset_map): <, not <=, for optimization,
5827 and to avoid potential problems with integer overflow.
9248994d 5828 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5829 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5830 * editfns.c (Fformat): Likewise.
1e69125e 5831 * syntax.c (skip_chars): Likewise.
3befa583 5832
e3019616
PE
5833 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5834 This also lets GCC 4.6.0 generate slightly better loop code.
5835
becfa255
PE
5836 * callint.c (Fcall_interactively): <, not <=, for optimization.
5837 (Fcall_interactively): Count the number of arguments produced,
5838 not the number of arguments given. This is simpler and lets GCC
5839 4.6.0 generate slightly better code.
5840
dae0cd48
PE
5841 * ftfont.c: Distingish more carefully between FcChar8 and char.
5842 The previous code passed unsigned char * to a functions like
5843 strlen and xstrcasecmp that expect char *, which does not
5844 conform to the C standard.
5845 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5846 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5847 char * when the C standard requires it.
5848
76032d70
PE
5849 * keyboard.c (read_char): Remove unused var.
5850
eb3f1cc8
PE
5851 * eval.c: Port to Windows vsnprintf (Bug#8435).
5852 Include <limits.h>.
5853 (SIZE_MAX): Define if the headers do not.
5854 (verror): Do not give up if vsnprintf returns a negative count.
5855 Instead, grow the buffer. This ports to Windows vsnprintf, which
5856 does not conform to C99. Problem reported by Eli Zaretskii.
5857 Also, simplify the allocation scheme, by avoiding the need for
5858 calling realloc, and removing the ALLOCATED variable.
5859
70476b54
PE
5860 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5861
12020a9e
PE
5862 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5863 But keep the doprint source code for now, as we might revamp it
5864 and use it again (Bug#8435).
ea6c7ae6
PE
5865 * lisp.h (doprnt): Remove.
5866 * Makefile.in (base_obj): Remove doprnt.o.
5867 * deps.mk (doprnt.o): Remove.
5868
5fdb398c
PE
5869 error: Print 32- and 64-bit integers portably (Bug#8435).
5870 Without this change, on typical 64-bit hosts error ("...%d...", N)
5871 was used to print both 32- and 64-bit integers N, which relied on
5872 undefined behavior.
5873 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5874 New macro.
5875 * lisp.h (error, verror): Mark as printf-like functions.
5876 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5877 Report overflow in size calculations when allocating printf buffer.
5878 Do not truncate output string at its first null byte.
5879 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5880 Truncate the output at a character boundary, since vsnprintf does not
5881 do that.
5882 * charset.c (check_iso_charset_parameter): Convert internal
5883 character to string before calling 'error', since %c now has the
5884 printf meaning.
5885 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5886 overflow when computing char to be passed to 'error'. Do not
5887 pass Lisp_Object to 'error'; pass the integer instead.
5888 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5889 formatted with plain %d.
5890
b189fa66
PE
5891 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5892
bff87ef0
PE
5893 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5894
7e2cac20
PE
5895 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5896
ce4d90b5
PE
5897 * xterm.c (x_catch_errors): Remove duplicate declaration.
5898
266c9547
PE
5899 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5900
79c49ad2
PE
5901 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5902
368f4090
JM
59032011-04-10 Jim Meyering <meyering@redhat.com>
5904
5905 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5906 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5907 return ssize_t not "int", and use size_t as the buffer length.
5908 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5909 * gnutls.h: Update declarations.
5910 * process.c (read_process_output): Use ssize_t, to match.
5911 (send_process): Likewise.
5912
a32d4040
CY
59132011-04-09 Chong Yidong <cyd@stupidchicken.com>
5914
5915 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5916
8546720e 59172011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5918
04f2d78b
CB
5919 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5920 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5921
8546720e
GM
5922 * xterm.c (handle_one_xevent):
5923 * xmenu.c (create_and_show_popup_menu):
5924 * xselect.c (x_decline_selection_request)
5925 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5926
0a2f5c1a 59272011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5928
5929 Fix some uses of `int' instead of EMACS_INT.
5930 * search.c (string_match_1, fast_string_match)
5931 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5932 (scan_buffer, find_next_newline_no_quit)
5933 (find_before_next_newline, search_command, Freplace_match)
5934 (Fmatch_data): Make some `int' variables be EMACS_INT.
5935
5936 * xdisp.c (display_count_lines): 3rd argument and return value now
5937 EMACS_INT. All callers changed.
5938 (pint2hrstr): Last argument is now EMACS_INT.
5939
5940 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5941 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5942 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5943 (decode_coding_utf_16, decode_coding_emacs_mule)
5944 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5945 (decode_coding_ccl, decode_coding_charset)
5946 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5947 (decode_coding_iso_2022, decode_coding_emacs_mule)
5948 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5949 <char_offset, last_offset>: Declare EMACS_INT.
5950 (encode_coding_utf_8, encode_coding_utf_16)
5951 (encode_coding_emacs_mule, encode_invocation_designation)
5952 (encode_designation_at_bol, encode_coding_iso_2022)
5953 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5954 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5955 Declare EMACS_INT.
5956 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5957 (encode_invocation_designation): Last argument P_NCHARS is now
5958 EMACS_INT.
5959 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5960 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5961
5962 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5963 All users changed.
5964
5965 * ccl.c (Fccl_execute_on_string): Declare some variables
5966 EMACS_INT.
5967
8546720e 59682011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5969
5970 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5971
4e19a977
CS
59722011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5973
5974 * process.c (Fformat_network_address): Doc fix.
5975
87302331
R
59762011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5977
5978 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5979
cbb59342
CY
59802011-04-08 Chong Yidong <cyd@stupidchicken.com>
5981
5982 * keyboard.c (read_char): Call Lisp function help-form-show,
5983 instead of using internal_with_output_to_temp_buffer.
5984 (Qhelp_form_show): New var.
e0d38eeb 5985 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5986
5987 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5988
5989 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5990
e67a13ab
CY
59912011-04-06 Chong Yidong <cyd@stupidchicken.com>
5992
04f2d78b
CB
5993 * process.c (Flist_processes): Remove to Lisp.
5994 (list_processes_1): Delete.
e67a13ab 5995
973f782d
EZ
59962011-04-06 Eli Zaretskii <eliz@gnu.org>
5997
7c106b1e
EZ
5998 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5999
973f782d
EZ
6000 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6001
41cf7d1a 60022011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6003
ca23cc88
PE
6004 Fix more problems found by GCC 4.6.0's static checks.
6005
f390e2d5
PE
6006 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6007
42eea0d0
PE
6008 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6009
b69769da 6010 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6011
f9541e84
PE
6012 * xdisp.c (vmessage): Mark as a printf-like function.
6013
13841b55
PE
6014 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6015
c136c10f
PE
6016 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6017
5e2d4a30
PE
6018 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6019 printf-like functions.
6020 (tiff_load): Add casts to remove these marks before passing them
6021 to system-supplied API.
6022
583f48b9
PE
6023 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6024
b25d760e
PE
6025 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6026 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6027 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6028 directly, rather than having caller test rule sign. This avoids
6029 some unnecessary tests.
6030 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6031 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6032 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6033
bc7b6697 6034 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6035 (xfont_open): Avoid unnecessary tests.
bc7b6697 6036
27ccc379
PE
6037 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6038
dcd5c89a
PE
6039 * composite.h, composite.c (composition_gstring_put_cache):
6040 Use EMACS_INT, not int, for length.
6041
b13a45c6
PE
6042 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6043 breaking out part of COMPOSITION_DECODE_RULE.
6044 (COMPOSITION_DECODE_RULE): Use it.
6045 * composite.c (get_composition_id): Remove unused local vars,
6046 by using the new macro.
6047
1e792e4d
PE
6048 * textprop.c (set_text_properties_1): Change while to do-while,
6049 since the condition is always true at first.
6050
dc6c6455 6051 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6052 (interval_deletion_adjustment): Return unsigned value.
6053 All uses changed.
dc6c6455 6054
aba7731a
PE
6055 * process.c (list_processes_1, create_pty, read_process_output):
6056 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6057 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6058 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6059 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6060 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6061
fdfc4bf3
PE
6062 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6063
fca8fe46 6064 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6065 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6066
06a0259a 6067 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6068 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6069 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6070
e7b9e80f
PE
6071 * print.c (print_error_message): Avoid int overflow.
6072
56201685
PE
6073 * font.c (font_list_entities): Redo for clarity,
6074 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6075
78834453 6076 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6077 (font_score): Avoid potential overflow in diff calculation.
78834453 6078
0bc0b309 6079 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6080 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6081
e610eaca
PE
6082 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6083
b895abce
PE
6084 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6085 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6086 can always succeed if overflow has undefined behavior.
6087
1f1d9321 6088 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6089 (wordify): Omit three unnecessary tests.
1f1d9321 6090
c59478bc
PE
6091 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6092 All callers changed. This avoids the need for an unused var.
6093
79b73827
PE
6094 * casefiddle.c (casify_region): Remove var that is set but not used.
6095
a4db5dfe
PE
6096 * dired.c (file_name_completion): Remove var that is set but not used.
6097
43aae36e
PE
6098 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6099
2a47c44d 6100 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6101 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6102
a37c69bf
PE
6103 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6104 Check for integer overflow on size calculations.
6105
328ab8e7
PE
6106 * buffer.c (Fprevious_overlay_change): Remove var that is set
6107 but not used.
6108
e5a2a5cb
PE
6109 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6110 Remove vars that are set but not used.
8d84a6eb 6111 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6112 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6113
a60e5f68
PE
6114 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6115
f661cb61 6116 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6117 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6118
f0397f5a
PE
6119 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6120 that are set but not used.
6121
8664db06 6122 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6123 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6124
6abdaa4a
PE
6125 * xselect.c (x_get_local_selection, x_handle_property_notify):
6126 Remove vars that are set but not used.
6127
0ce7538d 6128 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6129 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6130
9ae848fc
PE
6131 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6132 Remove var that is set but not used.
0b918413
PE
6133 (scroll_bar_windows_size): Now size_t, not int.
6134 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6135 Check for overflow.
9ae848fc 6136
a5a62657
PE
6137 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6138 (map_tty_color) [!defined MSDOS]: Likewise.
6139
5c5cdd39
PE
6140 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6141
66ebf983
PE
6142 * coding.c: Remove vars that are set but not used.
6143 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6144 All callers changed.
6145 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6146 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6147 (decode_coding_charset): Remove vars that are set but not used.
6148
1be4d761
PE
6149 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6150 that is set but not used.
6151
47553fa8
PE
6152 * print.c (print_object): Remove var that is set but not used.
6153
1f7196bf 6154 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6155 The gnulib version avoids calling malloc in the usual case,
6156 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6157 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6158 * filelock.c (current_lock_owner): Likewise.
6159 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6160 * sysdep.c: Include allocator.h, careadlinkat.h.
6161 (emacs_no_realloc_allocator): New static constant.
6162 (emacs_readlink): New function.
fdb61804
PE
6163 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6164 ../lib/careadlinkat.h.
d1fdcab7 6165
f84c17c7
SM
61662011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6167
6168 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6169 first non-nil return value).
6170
ef3862ad
JD
61712011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6172
6173 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6174 if not defined (Bug#8403).
6175
376a7006
JB
61762011-04-02 Juanma Barranquero <lekktu@gmail.com>
6177
6178 * xdisp.c (display_count_lines): Remove parameter `start',
6179 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6180 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6181 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6182 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6183 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6184 and thereabouts. All callers changed.
6185 (get_per_char_metric): Remove parameter `f', unused since
6186 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6187
6ca3801d
JM
61882011-04-02 Jim Meyering <meyering@redhat.com>
6189
6190 do not dereference NULL upon failed strdup
6191 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6192 (ns_get_family): Likewise.
6193
d8e2b5ba
JB
61942011-04-02 Juanma Barranquero <lekktu@gmail.com>
6195
6196 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6197
8c74fcbd
JD
61982011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6199
6200 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6201 later (Bug#8403).
6202
7200d79c
SM
62032011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6204
03408648 6205 Add lexical binding.
7200d79c 6206
03408648
SM
6207 * window.c (Ftemp_output_buffer_show): New fun.
6208 (Fsave_window_excursion):
6209 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6210
6211 * lread.c (lisp_file_lexically_bound_p): New function.
6212 (Fload): Bind Qlexical_binding.
6213 (readevalloop): Remove `evalfun' arg.
6214 Bind Qinternal_interpreter_environment.
6215 (Feval_buffer): Bind Qlexical_binding.
6216 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6217 Mark as dynamic.
6218 (syms_of_lread): Declare `lexical-binding'.
6219
6220 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6221
6222 * keyboard.c (eval_dyn): New fun.
6223 (menu_item_eval_property): Use it.
ca105506
SM
6224
6225 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6226
03408648
SM
6227 * fns.c (concat, mapcar1): Accept byte-code-functions.
6228
6229 * eval.c (Fsetq): Handle lexical vars.
6230 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6231 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6232 (FletX, Flet): Obey lexical binding.
6233 (Fcommandp): Handle closures.
6234 (Feval): New `lexical' arg.
6235 (eval_sub): New function extracted from Feval. Use it almost
6236 everywhere where Feval was used. Look up vars in lexical env.
6237 Handle closures.
6238 (Ffunctionp): Move from subr.el.
6239 (Ffuncall): Handle closures.
6240 (apply_lambda): Remove `eval_flags'.
6241 (funcall_lambda): Handle closures and new byte-code-functions.
6242 (Fspecial_variable_p): New function.
6243 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6244 but without exporting it to Lisp.
23aba0ea 6245
23aba0ea 6246 * doc.c (Fdocumentation, store_function_docstring):
03408648 6247 * data.c (Finteractive_form): Handle closures.
23aba0ea 6248
03408648
SM
6249 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6250 interactive spec.
ba83908c 6251
04f2d78b
CB
6252 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6253 New byte-codes.
03408648
SM
6254 (exec_byte_code): New function extracted from Fbyte_code to handle new
6255 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6256
03408648 6257 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6258
03408648 6259 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6260
e2abce01
JB
62612011-03-31 Juanma Barranquero <lekktu@gmail.com>
6262
6263 * xdisp.c (redisplay_internal): Fix prototype.
6264
63696a73 62652011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6266
63696a73 6267 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6268 (try_scrolling): Use it when setting scroll_limit.
6269 Limit scrolling to 100 screen lines.
63696a73
EZ
6270 (redisplay_window): Even when falling back on "recentering",
6271 position point in the window according to scroll-conservatively,
6272 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6273
6274 (try_scrolling): When point is above the window, allow searching
6275 as far as scroll_max, or one screenful, to compute vertical
6276 distance from PT to the scroll margin position. This prevents
6277 try_scrolling from unnecessarily failing when
6278 scroll-conservatively is set to a value slightly larger than the
6279 window height. Clean up the case of PT below the margin at bottom
6280 of window: scroll_max can no longer be INT_MAX. When aggressive
6281 scrolling is in use, don't let point enter the opposite scroll
6282 margin as result of the scroll.
6283 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6284 threshold of 100 lines for never-recentering scrolling.
6285
e4cc2dfc
JB
62862011-03-31 Juanma Barranquero <lekktu@gmail.com>
6287
6288 * dispextern.h (move_it_by_lines):
6289 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6290 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6291 (message_log_check_duplicate): Remove parameters `prev_bol' and
6292 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6293 (redisplay_internal): Remove parameter `preserve_echo_area',
6294 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6295
6296 * indent.c (Fvertical_motion):
6297 * window.c (window_scroll_pixel_based, Frecenter):
6298 Don't pass `need_y_p' to `move_it_by_lines'.
6299
1c470562
SM
63002011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6301
44f230aa
SM
6302 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6303 steal a few bits to be more compact.
6304 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6305 Remove unneeded casts.
6306
1c470562
SM
6307 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6308
888adce9
ZK
63092011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6310
6311 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6312 binding" message (bug#7967).
6313
f838ed7b
PE
63142011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6315
77861b95
PE
6316 Fix more problems found by GCC 4.6.0's static checks.
6317
de6dbc14
PE
6318 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6319 Remove unused local var.
6320
f838ed7b
PE
6321 * editfns.c (Fmessage_box): Remove unused local var.
6322
792c7b2b
PE
6323 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6324 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6325 Omit unused local vars.
c499e557 6326 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6327 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6328 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6329 Omit unused local var.
6330
ba0165e1
PE
6331 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6332 Don't assume string length fits in int.
32ad8845 6333 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6334 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6335
3c59b4c9
PE
6336 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6337 instead of alloca (Bug#8344).
6338
a3eed478 6339 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6340 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6341
eb4d412d
PE
6342 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6343
1658b401
PE
6344 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6345 concerns.
6346
6347 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6348
6349 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6350
9a2c6e05
PE
6351 * keyboard.c (syms_of_keyboard): Use the same style as later
6352 in this function when indexing through an array. This also
6353 works around GCC bug 48267.
6354
03d0a109
PE
6355 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6356
44f730c8
PE
6357 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6358
fe75f926
PE
6359 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6360 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6361
ffa8c828
PE
6362 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6363 This avoids undefined behavior on integer overflow, and is a bit
6364 more convenient anyway since it is compared to a size_t variable.
6365
c5101a77
PE
6366 Variadic C functions now count arguments with size_t, not int.
6367 This avoids an unnecessary limitation on 64-bit machines, which
6368 caused (substring ...) to crash on large vectors (Bug#8344).
6369 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6370 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6371 All variadic functions and their callers changed accordingly.
c5101a77
PE
6372 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6373 * data.c (arith_driver, float_arith_driver): Likewise.
6374 * editfns.c (general_insert_function): Likewise.
6375 * eval.c (struct backtrace.nargs, interactive_p)
6376 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6377 (funcall_lambda, mark_backtrace): Likewise.
6378 * fns.c (concat): Likewise.
6379 * frame.c (x_set_frame_parameters): Likewise.
6380 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6381 0 if not found, not -1. All callers changed.
6382
dd3f25f7
PE
6383 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6384 (stack_copy_size): Now size_t, not int.
6385 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6386
461c2ab9
JB
63872011-03-28 Juanma Barranquero <lekktu@gmail.com>
6388
6389 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6390 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6391 All callers changed.
6392
6393 * lisp.h (multibyte_char_to_unibyte):
6394 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6395 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6396 * character.h (CHAR_TO_BYTE8):
6397 * cmds.c (internal_self_insert):
6398 * editfns.c (general_insert_function):
6399 * keymap.c (push_key_description):
6400 * search.c (Freplace_match):
6401 * xdisp.c (message_dolog, set_message_1): All callers changed.
6402
f6d62986
SM
64032011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6404
6405 * keyboard.c (safe_run_hook_funcall): New function.
6406 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6407 don't set the hook to nil, but remove the offending function instead.
6408 (Qcommand_hook_internal): Remove, unused.
6409 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6410 Vcommand_hook_internal.
6411
6412 * eval.c (enum run_hooks_condition): Remove.
6413 (funcall_nil, funcall_not): New functions.
6414 (run_hook_with_args): Call each function through a `funcall' argument.
6415 Remove `cond' argument, now redundant.
6416 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6417 (Frun_hook_with_args_until_failure): Adjust accordingly.
6418 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6419
1db5b1ad
JB
64202011-03-28 Juanma Barranquero <lekktu@gmail.com>
6421
6422 * dispextern.h (string_buffer_position): Remove declaration.
6423
6424 * print.c (strout): Remove parameter `multibyte', unused since
6425 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6426
6427 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6428 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6429 All callers changed.
6430
6431 * w32.c (_wsa_errlist): Use braces for struct initializers.
6432
6433 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6434 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6435 All callers changed.
6436 (string_buffer_position): Likewise. Also, make static (it's never
6437 used outside xdisp.c).
6438 (cursor_row_p): Remove parameter `w', unused since
6439 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6440 (decode_mode_spec): Remove parameter `precision', introduced during
6441 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6442 All callers changed.
6443
5ffb62aa
JD
64442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6445
6446 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6447
461c2ab9 64482011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6449
6450 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6451 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6452 (ns_update_auto_hide_menu_bar): New functions.
6453 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6454 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6455 ns_constrain_all_frames.
6456 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6457 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6458
5c380ffb
JD
64592011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6460
6461 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6462
9af30bdf
GM
64632011-03-27 Glenn Morris <rgm@gnu.org>
6464
6465 * syssignal.h: Replace RETSIGTYPE with void.
6466 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6467 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6468 Replace SIGTYPE with void everywhere.
6469 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6470 * s/template.h (SIGTYPE): Remove commented out definition.
6471
e2abce01
JB
64722011-03-26 Eli Zaretskii <eliz@gnu.org>
6473
6474 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6475 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6476
f868cd8a
JB
64772011-03-26 Juanma Barranquero <lekktu@gmail.com>
6478
59eb0929
JB
6479 * w32.c (read_unc_volume): Use parameter `henum', instead of
6480 global variable `wget_enum_handle'.
6481
6482 * keymap.c (describe_vector): Remove parameters `indices' and
6483 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6484 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6485
f868cd8a
JB
6486 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6487
6488 * keyboard.c (timer_check): Remove parameter `do_it_now',
6489 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6490 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6491 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6492
6493 * keyboard.c (read_char):
6494 * w32menu.c (w32_menu_display_help):
6495 * xmenu.c (show_help_event, menu_help_callback):
6496 Adjust calls to `show_help_echo'.
6497
6498 * gtkutil.c (xg_maybe_add_timer):
6499 * keyboard.c (readable_events):
6500 * process.c (wait_reading_process_output):
6501 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6502
6503 * insdel.c (adjust_markers_gap_motion):
6504 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6505 (gap_left, gap_right): Don't call it.
6506
2ecf6fdb
CY
65072011-03-25 Chong Yidong <cyd@stupidchicken.com>
6508
6509 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6510 incurred during fontification.
6511
6b1f9ba4
JB
65122011-03-25 Juanma Barranquero <lekktu@gmail.com>
6513
6514 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6515 (DEFVAR_PER_BUFFER): Don't pass it.
6516
6517 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6518 (scrolling_window): Don't pass it.
6519
0f4a96b5
JB
65202011-03-25 Juanma Barranquero <lekktu@gmail.com>
6521
6522 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6523
6524 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6525 and `suffix'.
6526 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6527 of variables specific to SELinux and computation of `encoded_absname'.
6528
6529 * image.c (XPutPixel): Remove unused variable `height'.
6530
6531 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6532
6533 * unexw32.c (get_section_info): Remove unused variable `section'.
6534
6535 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6536 (system_process_attributes): Remove unused variable `sess'.
6537 (sys_read): Remove unused variable `err'.
6538
6539 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6540 (w32_wnd_proc): Remove unused variable `isdead'.
6541 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6542 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6543 (x_create_tip_frame): Remove unused variable `tem'.
6544
6545 * w32inevt.c (w32_console_read_socket):
6546 Remove unused variable `no_events'.
6547
6548 * w32term.c (x_draw_composite_glyph_string_foreground):
6549 Remove unused variable `width'.
6550
1149507c
JB
65512011-03-24 Juanma Barranquero <lekktu@gmail.com>
6552
6553 * w32term.c (x_set_glyph_string_clipping):
6554 Don't pass uninitialized region to CombineRgn.
6555
9c88f339
JB
65562011-03-23 Juanma Barranquero <lekktu@gmail.com>
6557
6558 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6559 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6560 (Fx_close_connection): Remove unused variable `i'.
6561
6562 * w32font.c (w32font_draw): Return number of glyphs.
6563 (w32font_open_internal): Remove unused variable `i'.
6564 (w32font_driver): Add missing initializer.
6565
6566 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6567 (fill_in_menu): Remove unused variable `items_added'.
6568
6569 * w32term.c (last_mouse_press_frame): Remove static global variable.
6570 (w32_clip_to_row): Remove unused variable `f'.
6571 (x_delete_terminal): Remove unused variable `i'.
6572
6573 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6574 (NOTHING): Remove unused static global variable.
6575 (uniscribe_check_otf): Remove unused variable `table'.
6576 (uniscribe_font_driver): Add missing initializers.
6577
dee091a3
JD
65782011-03-23 Julien Danjou <julien@danjou.info>
6579
6580 * term.c (Fsuspend_tty, Fresume_tty):
6581 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6582 * window.c (temp_output_buffer_show):
6583 * insdel.c (signal_before_change):
6584 * frame.c (Fhandle_switch_frame):
6585 * fileio.c (Fdo_auto_save):
6586 * emacs.c (Fkill_emacs):
6587 * editfns.c (save_excursion_restore):
6588 * cmds.c (internal_self_insert):
6589 * callint.c (Fcall_interactively):
6590 * buffer.c (Fkill_all_local_variables):
6591 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6592 Use Frun_hooks.
0f4a96b5 6593 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6594 unconditionnaly since it does the check itself.
6595
2c520ab5 65962011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6597
c9c49752
PE
6598 Fix more problems found by GCC 4.5.2's static checks.
6599
8abc3f12
PE
6600 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6601 the first time through the loop, since we know p0 < p1 then.
6602 This also avoids a gcc -Wstrict-overflow warning.
6603
a2d26660
PE
6604 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6605 leading to a memory leak, possible in functions like
6606 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6607 of objects (Bug#8318).
a2d26660 6608
916c72e9
PE
6609 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6610 that could (at least in theory) be that large.
6611
19ab8a18
PE
6612 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6613 This is less likely to overflow, and avoids undefined behavior if
6614 overflow does occur. All callers changed. Use strtoul to scan
6615 for the unsigned long integer.
b7cbbd6f
PE
6616 (pint2hrstr): Simplify and tune code slightly.
6617 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6618
f0641eff
PE
6619 * scroll.c (do_scrolling): Work around GCC bug 48228.
6620 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6621
7f650bb9
PE
6622 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6623 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6624 (validate_x_resource_name): Simplify count usage.
6625 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6626
37dd57d1
PE
6627 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6628 fail (Bug#8306).
81e56e61 6629
699979fc 6630 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6631
401bf9b4
PE
6632 * process.c (Fmake_network_process): Use socklen_t, not int,
6633 where POSIX says socklen_t is required in portable programs.
6634 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6635 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6636 (Fmake_network_process, server_accept_connection):
6637 (wait_reading_process_output, read_process_output):
6638 Likewise.
6639
b93aacde
PE
6640 * process.c: Rename or move locals to avoid shadowing.
6641 (list_processes_1, Fmake_network_process):
6642 (read_process_output_error_handler, exec_sentinel_error_handler):
6643 Rename or move locals.
4dc343ee 6644 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6645 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6646 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6647 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6648 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6649
af8a867c 6650 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6651 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6652 Include tparam.h instead, since it declares them.
af8a867c
PE
6653 * cm.h (PC): Remove extern decl; tparam.h now does this.
6654 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6655 * terminfo.c: Include tparam.h, to check interfaces.
6656 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6657 (tparam): Adjust signature to match interface in tparam.h;
6658 this removes some undefined behavior. Check that outstring and len
6659 are zero, which they always are with Emacs.
6660 * tparam.h (PC, BC, UP): New extern decls.
6661
0248044d 6662 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6663 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6664
8ff096c1 6665 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6666 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6667 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6668 (ftfont_list): Remove unused local.
49eaafba
PE
6669 (get_adstyle_property, ftfont_pattern_entity):
6670 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6671 Rename locals to avoid shadowing.
8ff096c1 6672
e2be39f6
PE
6673 * xfont.c (xfont_list_family): Mark var as initialized.
6674
c9735e30
PE
6675 * xml.c (make_dom): Now static.
6676
8f5201ae
PE
6677 * composite.c (composition_compute_stop_pos): Rename local to
6678 avoid shadowing.
b246f932
PE
6679 (composition_reseat_it): Remove unused locals.
6680 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6681 (composition_update_it): Mark var as initialized.
11b61122
PE
6682 (find_automatic_composition): Mark vars as initialized,
6683 with a FIXME (Bug#8290).
8f5201ae 6684
760fbc2c
PE
6685 character.h: Rename locals to avoid shadowing.
6686 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6687 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6688 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6689 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6690 to avoid shadowing.
6691
ff08eb85
PE
6692 * textprop.c (property_change_between_p): Remove; unused.
6693
fc7bf025
PE
6694 * intervals.c (interval_start_pos): Now static.
6695
235d7abc
PE
6696 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6697
44f230aa
SM
6698 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6699 Rename locals to avoid shadowing.
3e7d6594 6700
50060332
PE
6701 * sound.c (wav_play, au_play, Fplay_sound_internal):
6702 Fix pointer signedness.
d01f234b 6703 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6704 (wav_play): Initialize a variable to 0, to prevent undefined
6705 behavior (Bug#8278).
50060332 6706
c4fc4e30
PE
6707 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6708
918436ed
PE
6709 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6710
c939f91b
PE
6711 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6712 clobbering (Bug#8298).
b9c7f648
PE
6713 * sysdep.c (sys_subshell): Likewise.
6714 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6715
6bd8c144
PE
6716 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6717 This should get cleaned up, so that child_setup has the
6718 same signature on all platforms.
6719
7710357c 6720 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6721 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6722
c59da222
CY
67232011-03-22 Chong Yidong <cyd@stupidchicken.com>
6724
6725 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6726 not to be necessary, and produces flickering.
6727
66b87493
GM
67282011-03-20 Glenn Morris <rgm@gnu.org>
6729
6730 * config.in: Remove file.
6731
45b6f6d5
JB
67322011-03-20 Juanma Barranquero <lekktu@gmail.com>
6733
6734 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6735 are now in src/globals.h.
6736 (syms_of_minibuf): Remove spurious & from previous change.
6737
3ec03f7e
LL
67382011-03-20 Leo <sdl.web@gmail.com>
6739
6740 * minibuf.c (completing-read-function): New variable.
6741 (completing-read-default): Rename from completing-read.
6742 (completing-read): Call completing-read-function.
6743
b14e3e21
CY
67442011-03-19 Juanma Barranquero <lekktu@gmail.com>
6745
6746 * xfaces.c (Fx_load_color_file):
6747 Read color file from absolute filename (bug#8250).
6748
f2b726e6
JB
67492011-03-19 Juanma Barranquero <lekktu@gmail.com>
6750
6751 * makefile.w32-in: Update dependencies.
6752
09f6ff02
EZ
67532011-03-17 Eli Zaretskii <eliz@gnu.org>
6754
6755 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6756
29a6015a
PE
67572011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6758
a3a6c54e
PE
6759 Fix more problems found by GCC 4.5.2's static checks.
6760
b766f867
PE
6761 * process.c (make_serial_process_unwind, send_process_trap):
6762 (sigchld_handler): Now static.
6763
be02381c
PE
6764 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6765 That way, the code declares only the vars that it needs.
6766 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6767 * s/cygwin.h (PTY_ITERATION): Likewise.
6768 * s/darwin.h (PTY_ITERATION): Likewise.
6769 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6770
57048744
PE
6771 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6772 * process.c (allocate_pty): Don't declare stb unless it's needed.
6773
7914961c 6774 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6775 (CONSTANTLIM): Remove; unused.
6776 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6777 Define only if needed.
7914961c 6778
b3967b18
PE
6779 * unexelf.c (unexec): Name an expression,
6780 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6781 Use a different way to cause a compilation error if anyone uses
6782 n rather than nn, a way that does not involve shadowing.
73366a00 6783 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6784
29a6015a
PE
6785 * deps.mk (unexalpha.o): Remove; unused.
6786
43cfc33e 6787 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6788 * unexec.h: New file.
ce701a33
PE
6789 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6790 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6791 Depend on unexec.h.
6792 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6793 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6794 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6795 Change as necessary to match prototype in unexec.h.
ce701a33 6796
01f44d5a
PE
6797 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6798 shadowing.
4f63c6bb 6799 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6800
a6670b0b
PE
6801 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6802 Rename locals to avoid shadowing.
6803
cef2010d 6804 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6805 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6806
d4d7173a
PE
6807 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6808
f08b802a
PE
6809 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6810 warning when compiling print.c.
6811
3ddb0639
PE
6812 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6813 instead of using an uninitialized var.
5ad03b97 6814 (font_sort_entities): Mark var as initialized.
3ddb0639 6815
170a2692
PE
6816 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6817
e663c700
PE
6818 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6819 pointers to constants.
89bc529a 6820 (font_parse_fcname): Remove unused vars.
7b81e2d0 6821 (font_delete_unmatched): Now static.
ea838e10 6822 (font_get_spec): Remove; unused.
13a547c6
PE
6823 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6824 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6825 Rename or move locals to avoid shadowing.
e663c700 6826
2a80c887 6827 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6828 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6829
1384fa33 6830 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6831 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6832
8b2c52e9
PE
6833 * alloc.c (mark_backtrace): Move decl from here ...
6834 * lisp.h: ... to here, so that it can be checked.
6835
475545b5 6836 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6837 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6838 (lisp_indirect_variable): Name an expression,
6839 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6840 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6841
b1349114 6842 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6843 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6844 Use const pointer when appropriate.
b1349114 6845
a2928364
PE
6846 * lisp.h (get_system_name, get_operating_system_release):
6847 Move decls here, to check interfaces.
6848 * process.c (get_operating_system_release): Move decl to lisp.h.
6849 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6850 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6851 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6852 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6853 (Fformat_time_string, Fencode_time, Finsert_char):
6854 (Ftranslate_region_internal, Fformat):
6855 Rename or remove local vars to avoid shadowing.
9710023e 6856 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6857
a415e694
PE
6858 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6859 avoid shadowing.
6860
8ef4622d
PE
6861 * lisp.h (eassert): Check that the argument compiles, even if
6862 ENABLE_CHECKING is not defined.
6863
946f9a5b
PE
6864 * data.c (Findirect_variable): Name an expression, to avoid
6865 gcc -Wbad-function-cast warning.
112396d6 6866 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6867 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6868 (Fmake_variable_buffer_local, Fmake_local_variable):
6869 Mark variables as initialized.
52746918 6870 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6871
e5aab7e7 6872 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6873 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6874 Rename locals to avoid shadowing.
dff45157
PE
6875 (mark_stack): Move local variables into the #ifdef region where
6876 they're used.
7bc26fdb
PE
6877 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6878 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6879 needed otherwise.
6880 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6881 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6882 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6883
e5aab7e7
PE
6884 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6885 avoids undefined behavior in theory.
6886
4da60324
PE
6887 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6888
88043301
PE
6889 Use functions, not macros, for up- and down-casing (Bug#8254).
6890 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6891 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6892 to use the following functions instead of these macros.
6893 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6894 EMACS_INT, since callers assume the returned value fits in int.
6895 (upcase1): Likewise, for UPCASE_TABLE.
6896 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6897 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6898 the race-condition problem in the old DOWNCASE.
88043301 6899
19ed5445
PE
6900 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6901 Rename locals to avoid shadowing.
6902 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6903 (regex_compile, re_search_2, re_match_2_internal):
6904 Remove unused local vars.
952db0d7
PE
6905 (FREE_VAR): Rewrite so as not to use empty "else",
6906 which gcc can warn about.
da053e48 6907 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6908 (RETALLOC_IF): Define only if needed.
6909 (WORDCHAR_P): Likewise. This one is never needed, but is used
6910 only in a comment talking about a compiler bug, so put inside
6911 the #if 0 of that comment.
6912 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6913 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6914 Remove; unused.
19ed5445 6915
1f3561e4 6916 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6917 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6918 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6919
ded6f8f7
PE
6920 * search.c (simple_search): Remove unused var.
6921
dbd37a95
PE
6922 * dired.c (compile_pattern): Move decl from here ...
6923 * lisp.h: ... to here, so that it can be checked.
6924 (struct re_registers): New forward decl.
6925
7e47afad
PE
6926 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6927
85f24f61
PE
6928 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6929 All uses changed.
6930 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6931 Rename locals to avoid shadowing.
5671df8f 6932 (Fvertical_motion): Mark locals as initialized.
85f24f61 6933
181aa2be 6934 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6935 (casify_region): Mark local as initialized.
181aa2be 6936
930d429c
PE
6937 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6938
7082eac6
PE
6939 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6940 New macros, so that the caller can use some names other than
6941 gcpro1, gcpro2, etc.
6942 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6943 of the new macros.
6944 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6945 argument, for consistency with GCPRO2_VAR, etc: it is now the
6946 prefix of the variable, not the variable itself. All uses
6947 changed.
38b2c076
PE
6948 * dired.c (directory_files_internal, file_name_completion):
6949 Rename locals to avoid shadowing.
6950
15206ed9
PE
6951 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6952 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6953 dired.c's scmp function, had undefined behavior.
6954 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6955 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6956 * buffer.h: ... to here, because these macros use current_buffer,
6957 and the new implementation with inline functions needs to have
6958 current_buffer in scope now, rather than later when the macros
6959 are used.
6960 (downcase, upcase1): New static inline functions.
6961 (DOWNCASE, UPCASE1): Reimplement using these functions.
6962 This avoids undefined behavior in expressions like
6963 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6964 from race conditions in accessing the global variables
6965 case_temp1 and case_temp2.
6966 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6967 * lisp.h (case_temp1, case_temp2): Remove their decls.
6968 * character.h (ASCII_CHAR_P): Move from here ...
6969 * lisp.h: ... to here, so that the inline functions mentioned
6970 above can use them.
6971
4a6bea26
PE
6972 * dired.c (directory_files_internal_unwind): Now static.
6973
f14b7e14
PE
6974 * fileio.c (file_name_as_directory, directory_file_name):
6975 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6976 Now static.
2893f146
PE
6977 (file_name_as_directory): Use const pointers when appropriate.
6978 (Fexpand_file_name): Likewise. In particular, newdir might
6979 point at constant storage, so make it a const pointer.
fd4ead52 6980 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6981 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6982 signedness issues.
f839df0c
PE
6983 (Fset_file_times, Finsert_file_contents, auto_save_error):
6984 Rename locals to avoid shadowing.
f14b7e14 6985
5716756e 6986 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6987 (Ftry_completion, Fall_completions): Rename or remove locals
6988 to avoid shadowing.
5716756e 6989
b4c3046a
PE
6990 * marker.c (bytepos_to_charpos): Remove; unused.
6991
b45db522
PE
6992 * lisp.h (verify_bytepos, count_markers): New decls,
6993 so that gcc does not warn that these functions aren't declared.
6994
85876d07
PE
6995 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6996 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6997 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6998 (copy_text): Remove unused local var.
85876d07 6999
03d78a21 7000 * filelock.c (within_one_second): Now static.
b3dd38ab 7001 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7002
5df8f01b
PE
7003 * buffer.c (fix_overlays_before): Mark locals as initialized.
7004 (fix_start_end_in_overlays): Likewise. This function should be
7005 simplified by using pointers-to-pointers, but that's a different
7006 matter.
b1d876f1 7007 (switch_to_buffer_1): Now static.
8f54f30a
PE
7008 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7009 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7010
a70072c9 7011 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7012 Fix pointer signedness issue.
edced198
PE
7013 (sys_subshell): Mark local as volatile if checking for lint,
7014 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7015 (MAXPATHLEN): Define only if needed.
a70072c9 7016
a0977c44
PE
7017 * process.c (serial_open, serial_configure): Move decls from here ...
7018 * systty.h: ... to here, so that they can be checked.
7019
a884fdcc
PE
7020 * fns.c (get_random, seed_random): Move extern decls from here ...
7021 * lisp.h: ... to here, so that they can be checked.
7022
604efe86 7023 * sysdep.c (reset_io): Now static.
b8950c94 7024 (wait_for_termination_signal): Remove; unused.
604efe86 7025
38fc62d9
PE
7026 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7027 (copy_keymap_item, append_key, push_text_char_description):
7028 Now static.
1004a21a 7029 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7030 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7031 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7032 (describe_map_tree):
7033 Rename locals to avoid shadowing.
38fc62d9 7034
2f2650da
PE
7035 * keyboard.c: Declare functions static if they are not used elsewhere.
7036 (echo_char, echo_dash, cmd_error, top_level_2):
7037 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7038 (read_char, kbd_buffer_get_event, make_lispy_position):
7039 (make_lispy_event, make_lispy_movement, apply_modifiers):
7040 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7041 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7042 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7043 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7044 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7045
a053e86c 7046 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7047 (mark_kboards): Move decl here ...
7048 * alloc.c (mark_kboards): ... from here.
a053e86c 7049
4752793e
PE
7050 * lisp.h (force_auto_save_soon): New decl.
7051
74f10ca7 7052 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7053 (DEFINE_DUMMY_FUNCTION): New macro.
7054 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7055 Use it.
c03cd23f
PE
7056 (main): Add casts to avoid warnings
7057 if GCC considers string literals to be constants.
74f10ca7 7058
022e70d4
PE
7059 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7060
59d6fe83
PE
7061 * dbusbind.c: Pointer signedness fixes.
7062 (xd_signature, xd_append_arg, xd_initialize):
7063 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7064 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7065 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7066 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7067
78320123
PE
7068 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7069 if GCC considers string literals to be constants.
49cebcca 7070 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7071
35ac2a97
SM
70722011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7073
fb103ca9
SM
7074 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7075 (print_preprocess, print_object): New macro to fix last change.
7076
35ac2a97
SM
7077 * print.c (print_preprocess): Don't forget font objects.
7078
62973b41
JB
70792011-03-16 Juanma Barranquero <lekktu@gmail.com>
7080
7081 * emacs.c (USAGE3): Doc fixes.
7082
0e48bb22
AS
70832011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7084
7085 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7086 structure.
7087
7684e57b
JB
70882011-03-14 Juanma Barranquero <lekktu@gmail.com>
7089
7090 * lisp.h (VWindow_system, Qfile_name_history):
7091 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7092 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7093 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7094
7095 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7096 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7097
7098 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7099 * w32console.c (detect_input_pending, read_input_pending)
7100 (encode_terminal_code):
7101 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7102 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7103 (w32_system_caret_y, Qfile_name_history):
7104 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7105 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7106 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7107 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7108 * w32proc.c (Qlocal, report_file_error):
7109 * w32term.c (Vwindow_system, updating_frame):
7110 * w32uniscribe.c (initialized, uniscribe_font_driver):
7111 Remove unneeded extern declarations.
7112
2aa46d6c
CY
71132011-03-14 Chong Yidong <cyd@stupidchicken.com>
7114
c96bbc66 7115 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7116
cffc6f3b
CY
71172011-03-13 Chong Yidong <cyd@stupidchicken.com>
7118
7119 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7120 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7121 These macros can no longer be used for assignment.
7122
44f230aa
SM
7123 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7124 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7125 (record_buffer_markers, fetch_buffer_markers): New functions for
7126 recording and fetching special buffer markers.
7127 (set_buffer_internal_1, set_buffer_temp): Use them.
7128
7129 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7130
7131 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7132
7133 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7134 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7135
7136 * xdisp.c (hscroll_window_tree):
7137 (reconsider_clip_changes): Use PT instead of BUF_PT.
7138
d251f04b
EZ
71392011-03-13 Eli Zaretskii <eliz@gnu.org>
7140
7141 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7142 $(EMACS_ROOT)/lib/intprops.h.
7143
f0c77cd1
PE
71442011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7145
3eca4629
PE
7146 Fix more problems found by GCC 4.5.2's static checks.
7147
7c86ee98
PE
7148 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7149 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7150 (xg_free_frame_widgets): Make it clear that a local variable is
7151 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7152 (gdk_window_get_screen): Make it clear that this macro is needed
7153 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7154 (int_gtk_range_get_value): New function, which avoids a diagnostic
7155 from gcc -Wbad-function-cast.
7156 (xg_set_toolkit_scroll_bar_thumb): Use it.
7157 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7158 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7159 (get_utf8_string, xg_get_file_with_chooser):
7160 Rename locals to avoid shadowing.
7161 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7162
41729b81
PE
7163 * xgselect.c (xg_select): Remove unused var.
7164
f0c77cd1
PE
7165 * image.c (four_corners_best): Mark locals as initialized.
7166 (gif_load): Initialize transparent_p to zero (Bug#8238).
7167 Mark another local as initialized.
ec6cf4c6 7168 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7169
ce0ad53d 7170 * image.c (clear_image_cache): Now static.
d5d5a617 7171 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7172 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7173 (x_edge_detection): Remove unnecessary cast that
7174 gcc -Wbad-function-cast diagnoses.
2037898d 7175 (gif_load): Fix pointer signedness.
6ae141d6
PE
7176 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7177 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7178
33383987 71792011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7180
d32df629
PE
7181 Improve quality of tests for time stamp overflow.
7182 For example, without this patch (encode-time 0 0 0 1 1
7183 1152921504606846976) returns the obviously-bogus value (-948597
7184 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7185 reports time overflow. See
7186 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7187 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7188 * editfns.c: Include limits.h and intprops.h.
7189 (TIME_T_MIN, TIME_T_MAX): New macros.
7190 (time_overflow): Move earlier, to before first use.
7191 (hi_time, lo_time): New functions, for an accurate test for
7192 out-of-range times.
7193 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7194 (Fget_internal_run_time): Don't assume time_t fits in int.
7195 (make_time): Use list2 instead of Fcons twice.
7196 (Fdecode_time): More accurate test for out-of-range times.
7197 (check_tm_member): New function.
7198 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7199 (lisp_time_argument): Don't rely on undefined left-shift and
7200 right-shift behavior when checking for time stamp overflow.
8be6f318 7201
fe31d94c
PE
7202 * editfns.c (time_overflow): New function, refactoring common code.
7203 (Fformat_time_string, Fdecode_time, Fencode_time):
7204 (Fcurrent_time_string): Use it.
7205
8be6f318
PE
7206 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7207 * dired.c (make_time): Move to ...
7208 * editfns.c (make_time): ... here.
7209 * systime.h: Note the move.
7210
09d9db2c 72112011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7212
126bc0dc
YM
7213 * fringe.c (update_window_fringes): Remove unused variables.
7214
c47cbdfd
YM
7215 * unexmacosx.c (copy_data_segment): Also copy __got section.
7216 (Bug#8223)
7217
7ac80be9
EZ
72182011-03-12 Eli Zaretskii <eliz@gnu.org>
7219
c96bbc66 7220 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7221 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7222 Constify `char *' arguments and their references according to
7223 prototypes in tparam.h.
7224
ecb0f94d 7225 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7226
7ac80be9
EZ
7227 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7228 Adapt all references accordingly.
7229
7230 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7231
ef1fd07e
TT
72322011-03-11 Tom Tromey <tromey@redhat.com>
7233
7234 * buffer.c (syms_of_buffer): Remove obsolete comment.
7235
7ef4b50c
EZ
72362011-03-11 Eli Zaretskii <eliz@gnu.org>
7237
7238 * termhooks.h (encode_terminal_code): Declare prototype.
7239
7240 * msdos.c (encode_terminal_code): Don't declare prototype.
7241
7242 * term.c (encode_terminal_code): Now external again, used by
7243 w32console.c and msdos.c.
7244
44f230aa
SM
7245 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7246 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7247
4b1ec863 72482011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7249
1714f52b 7250 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7251
4b1ec863
PE
7252 * fringe.c (update_window_fringes): Mark locals as initialized
7253 (Bug#8227).
7254 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7255
524c7aa6
PE
7256 * alloc.c (mark_fringe_data): Move decl from here ...
7257 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7258 to check its interface.
7259 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7260
a5c0af81 7261 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7262 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7263 (fontset_font): Mark local as initialized.
a9a06e0b 7264 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7265
b4716021
PE
7266 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7267
811e9bac 7268 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7269 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7270 (x_own_selection, Fx_disown_selection_internal): Rename locals
7271 to avoid shadowing.
7272 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7273
7e3ab302
PE
7274 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7275 so that the caller can use some name other than gcpro1.
7276 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7277 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7278 (Fx_backspace_delete_keys_p):
7279 Use them to avoid shadowing, and rename vars to avoid shadowing.
7280 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7281 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7282 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7283 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7284 Remove unused locals.
7e3ab302
PE
7285 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7286 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7287 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7288 macros.
f78faa98 7289
e2b13473
PE
7290 * xterm.h (x_mouse_leave): New decl.
7291
77f23912
PE
7292 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7293 Remove unused functions.
cdf4ba58
PE
7294 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7295 (x_calc_absolute_position): Now static.
7411c686 7296 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7297 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7298 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7299 unless they are used.
38d0b34a
PE
7300 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7301 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7302 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7303 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7304 (x_error_catcher, x_connection_closed, x_error_handler):
7305 (x_error_quitter, xembed_send_message, x_iconify_frame):
7306 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7307 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7308 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7309
44f230aa
SM
7310 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7311 Rename or move locals to avoid shadowing.
6b463e58 7312 (tty_defined_color, merge_face_heights): Now static.
5967d051 7313 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7314 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7315 does not deduce is never used uninitialized.
73719eba
PE
7316 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7317 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7318
426994c3 7319 * terminal.c (store_terminal_param): Now static.
5489860b 7320
032f1620 7321 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7322 (set_frame_menubar): Remove unused local.
d4323972 7323 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7324 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7325 since they might point to immutable storage.
281585b0
PE
7326 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7327 since it's unused otherwise.
032f1620 7328
367c19e5 7329 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7330 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7331 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7332 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7333 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7334 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7335 does not deduce are never used uninitialized.
70739cbe 7336
07b48fa9
PE
7337 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7338
8868a238 7339 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7340 * window.c (window_loop, size_window):
7341 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7342
7e5cf297 7343 * window.c (display_buffer): Now static.
d6550a9f
PE
7344 (size_window): Mark variables that gcc -Wuninitialized
7345 does not deduce are never used uninitialized.
a586633d
PE
7346 * window.h (check_all_windows): New decl, to forestall
7347 gcc -Wmissing-prototypes diagnostic.
5b555da1 7348 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7349
f6095868
PE
7350 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7351 shadowing.
7352 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7353 Include <limits.h>.
7354 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7355 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7356 (load_charset_map): Mark variables that gcc -Wuninitialized
7357 does not deduce are never used uninitialized.
53df7c11 7358 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7359
f38b440c
PE
7360 * coding.c (coding_set_source, coding_set_destination):
7361 Use "else { /* comment */ }" rather than "else /* comment */;"
7362 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7363 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7364 a block, when the outer 'i' will do.
7365 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7366 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7367 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7368 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7369 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7370 Rename locals to avoid shadowing.
7371 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7372 * coding.c (emacs_mule_char, encode_invocation_designation):
7373 Now static, since they're not used elsewhere.
413bb2db 7374 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7375 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7376 (decode_coding_emacs_mule): Mark variables that gcc
7377 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7378 (detect_coding_iso_2022): Initialize a local variable that might
7379 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7380 this initialization is needed. (Bug#8211)
5f58e762
PE
7381 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7382 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7383 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7384 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7385 Remove unused macros.
f38b440c 7386
232b38b9 7387 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7388 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7389 * character.c (string_count_byte8): Likewise.
232b38b9 7390
fb90da1b
PE
7391 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7392 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7393
fb93dbc2
PE
7394 * chartab.c (copy_sub_char_table): Now static, since it's not used
7395 elsewhere.
5c156ace
PE
7396 (sub_char_table_ref_and_range, char_table_ref_and_range):
7397 Rename locals to avoid shadowing.
bbcd0949 7398 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7399
7d3b3862 7400 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7401 (BIDI_BOB): Remove unused macro.
7d3b3862 7402
6be7d3da
PE
7403 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7404 deduce are never used uninitialized.
c2ed9c8b 7405 * term.c (encode_terminal_code): Likewise.
6be7d3da 7406
75f8807f 7407 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7408
50938595
PE
7409 * tparam.h: New file.
7410 * term.c, tparam.h: Include it.
7411 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7412 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7413 Move these decls to tparam.h, and make them agree with what
7414 is actually in tparam.c. The previous trick of using incompatible
7415 decls in different modules does not conform to the C standard.
7416 All callers of tparam changed to use tparam's actual API.
7417 * tparam.c (tparam1, tparam, tgoto):
7418 Use const pointers where appropriate.
7419
fbceeba2
PE
7420 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7421 * cm.h (struct cm): Likewise.
7422 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7423 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7424 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7425 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7426 (turn_on_face, init_tty): Likewise.
7427 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7428
7f3f1250
PE
7429 * term.c (term_mouse_position): Rename local to avoid shadowing.
7430
e6ca6543
PE
7431 * alloc.c (mark_ttys): Move decl from here ...
7432 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7433
c40f8d15
AS
74342011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7435
7436 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7437
cfe0661d
JB
74382011-03-09 Juanma Barranquero <lekktu@gmail.com>
7439
7440 * search.c (compile_pattern_1): Remove argument regp, unused since
7441 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7442 (compile_pattern): Don't pass it.
7443
0afb4571
J
74442011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7445
7446 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7447 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7448 for ! HAVE_GTK3.
7449 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7450
7451 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7452
7453 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7454 gdk_window_get_screen, gdk_window_get_geometry,
7455 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7456 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7457 (xg_get_pixbuf_from_pixmap): New function.
7458 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7459 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7460 Call xg_get_pixbuf_from_pixmap instead of
7461 gdk_pixbuf_get_from_drawable.
7462 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7463 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7464 (xg_check_special_colors): Use GtkStyleContext and its functions
7465 for HAVE_GTK3.
7466 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7467 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7468 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7469 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7470 Call gtk_widget_get_preferred_size.
0afb4571
J
7471 (xg_frame_resized): gdk_window_get_geometry only takes 5
7472 parameters.
44f230aa
SM
7473 (xg_win_to_widget, xg_event_is_for_menubar):
7474 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7475 (xg_set_widget_bg): New function.
7476 (delete_cb): New function.
895009e1 7477 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7478 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7479 (xg_set_background_color): Call xg_set_widget_bg.
7480 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7481 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7482 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7483 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7484 if ! HAVE_GTK3.
7485 (update_frame_tool_bar): Call gtk_widget_hide.
7486 (xg_initialize): Use GDK_KEY_g.
7487
7488 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7489 if ! HAVE_GTK3
7490 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7491
7492 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7493 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7494 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7495
1c2cc4ef
JB
74962011-03-08 Juanma Barranquero <lekktu@gmail.com>
7497
7498 * w32xfns.c (select_palette): Check success of RealizePalette against
7499 GDI_ERROR, not zero.
7500
33383987 7501See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7502
7503;; Local Variables:
7504;; coding: utf-8
aac0c6e3
MR
7505;; End:
7506
33383987 7507 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7508
7509 This file is part of GNU Emacs.
7510
7511 GNU Emacs is free software: you can redistribute it and/or modify
7512 it under the terms of the GNU General Public License as published by
7513 the Free Software Foundation, either version 3 of the License, or
7514 (at your option) any later version.
7515
7516 GNU Emacs is distributed in the hope that it will be useful,
7517 but WITHOUT ANY WARRANTY; without even the implied warranty of
7518 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7519 GNU General Public License for more details.
7520
7521 You should have received a copy of the GNU General Public License
7522 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.