* nsterm.h (x_free_frame_resources): Declare.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f7dfe5d6
JD
12011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2
83faebb4
JD
3 * nsterm.h (x_free_frame_resources): Declare.
4
f7dfe5d6
JD
5 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
7
8 * nsterm.h (ns_get_defaults_value): Declare.
9
10 * nsterm.m (ns_default): Call ns_get_defaults_value.
11
7cd4e72c
EZ
122011-12-09 Eli Zaretskii <eliz@gnu.org>
13
14 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
15 (Bug#10170)
16
b34d7317
YM
172011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
18
19 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
20 that where the value of an _OBJC_* symbol points to is in the .bss
21 section (Bug#10240).
22
76470ad1
KH
232011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
24
25 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 26 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 27
745fff94
KH
282011-12-08 Kenichi Handa <handa@m17n.org>
29
30 * ftfont.c (get_adstyle_property): Fix previous change
31 (Bug#10233).
32
6e44397c
JB
332011-12-07 Juanma Barranquero <lekktu@gmail.com>
34
35 * w32.c (init_environment): If no_site_lisp, remove site-lisp
36 dirs from the default value of EMACSLOADPATH (bug#10208).
37
7efa6272
GM
382011-12-07 Glenn Morris <rgm@gnu.org>
39
40 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
41 installation and source directories as well. (Bug#10208)
42
f6fc4d87
CY
432011-12-06 Chong Yidong <cyd@gnu.org>
44
45 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
46
2bf26180
GM
472011-12-06 Glenn Morris <rgm@gnu.org>
48
49 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
50 as an error, not just -1. (Bug#10217)
51
3a6ad4f0
CY
522011-12-05 Chong Yidong <cyd@gnu.org>
53
54 * keyboard.c (process_special_events): New function.
55 (swallow_events, Finput_pending_p): Use it (Bug#10195).
56
75a3b399
PE
572011-12-05 Paul Eggert <eggert@cs.ucla.edu>
58
59 * coding.c (encode_designation_at_bol): Don't use uninitialized
60 local variable (Bug#9318).
61
c3c9e25e
KH
622011-12-05 Kenichi Handa <handa@m17n.org>
63
64 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
65 return Qnil (Bug#8046, Bug#10193).
66
5eb05ea3
KH
672011-12-05 Kenichi Handa <handa@m17n.org>
68
69 * coding.c (encode_designation_at_bol): New args charbuf_end and
70 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
71 (coding_set_source): Return how many bytes coding->source was
72 relocated.
73 (coding_set_destination): Return how many bytes
74 coding->destination was relocated.
75 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
76 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
77
782011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
79
80 * coding.c (CODING_CHAR_CHARSET_P): New macro.
81 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
82 macro (Bug#9318).
83
842011-12-05 Andreas Schwab <schwab@linux-m68k.org>
85
86 The following changes are to fix Bug#9318.
87
a79703f5 88 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
89 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
90 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 91 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 92
7dbda6df
JB
932011-12-05 Juanma Barranquero <lekktu@gmail.com>
94
95 * lisp.h (process_quit_flag): Fix external declaration.
96
6d5eb5b0
SM
972011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
98
99 Don't macro-inline non-performance-critical code.
100 * eval.c (process_quit_flag): New function.
101 * lisp.h (QUIT): Use it.
102
a0c3fad0
JD
1032011-12-04 Jan Djärv <jan.h.d@swipnet.se>
104
105 * nsfns.m (get_geometry_from_preferences): New function.
106 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
107
6c07aac2
AS
1082011-12-04 Andreas Schwab <schwab@linux-m68k.org>
109
110 * emacs.c (Qkill_emacs): Define.
111 (syms_of_emacs): Initialize it.
112 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
113 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
114 (quit_throw_to_read_char): Add parameter `from_signal'.
115 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
116 * lisp.h (QUIT): Call Fkill_emacs if requested.
117
c052ead4
JD
1182011-12-03 Jan Djärv <jan.h.d@swipnet.se>
119
120 * widget.c (update_wm_hints): Return if wmshell is null.
121 (widget_update_wm_size_hints): New function.
122
123 * widget.h (widget_update_wm_size_hints): Declare.
124
125 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
126 widget_update_wm_size_hints (Bug#10104).
127
9e49252b
EZ
1282011-12-03 Eli Zaretskii <eliz@gnu.org>
129
130 * xdisp.c (handle_invisible_prop): If the invisible text ends just
131 before a newline, prepare the bidi iterator for consuming the
132 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 133 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 134
02b16839
JL
1352011-12-02 Juri Linkov <juri@jurta.org>
136
137 * search.c (Fword_search_regexp): New Lisp function created from
138 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
139 (Fword_search_backward, Fword_search_forward)
140 (Fword_search_backward_lax, Fword_search_forward_lax):
141 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
142 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
143
0068070e
SM
1442011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
145
146 * fileio.c (Finsert_file_contents): Move after-change-function call
147 to before the "handled:" label, since all "goto handled" appear in
148 cases where the *-change-functions have already been properly called
149 (bug#10117).
150
3360a3fc
AS
1512011-12-01 Andreas Schwab <schwab@linux-m68k.org>
152
153 * keyboard.c (interrupt_signal): Don't call kill-emacs when
154 waiting for input. (Bug#10169)
155
73d6c093
EZ
1562011-11-30 Eli Zaretskii <eliz@gnu.org>
157
158 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
159 verifies glyph row's hash code--we have just reallocated the
160 glyphs, so their contents can be complete garbage. (Bug#10164)
161
febe6bea
JB
1622011-11-30 Juanma Barranquero <lekktu@gmail.com>
163
164 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
165
801a4313
EZ
1662011-11-30 Eli Zaretskii <eliz@gnu.org>
167
168 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
169 attributes are tested _before_ calling verify_row_hash, to protect
170 against GCC re-ordering of the tests. (Bug#10164)
171
2b56b87e
JD
1722011-11-29 Jan Djärv <jan.h.d@swipnet.se>
173
174 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
175
176 * xterm.c (handle_one_xevent): Only set async_visible and friends
177 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 178 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
179 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
180
dbf31225
PE
1812011-11-28 Paul Eggert <eggert@cs.ucla.edu>
182
183 Remove GCPRO-related macros that exist only to avoid shadowing locals.
184 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
185 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
186 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
187 All uses changed to use GCPRO1 etc.
188 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
189 Revert to old implementation (i.e., before 2011-03-11).
190
1305621b
YM
1912011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
192
193 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
194 of scroll runs so as to avoid assigning disabled bogus rows and
195 unnecessary graphics copy operations.
196
8c9afb46
EZ
1972011-11-27 Eli Zaretskii <eliz@gnu.org>
198
199 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
200 (snprintf) [_MSC_VER]: Redirect to _snprintf.
201 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
202 (malloc, free, realloc, calloc): Redirect to e_* only when
203 compiling Emacs.
204
205 * lisp.h (GCTYPEBITS): Move before first use.
206 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
207 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
208 this macro definition.
209
210 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
211 _MSC_VER.
212
54e9e3bf
JD
2132011-11-27 Jan Djärv <jan.h.d@swipnet.se>
214
6d5eb5b0
SM
215 * gtkutil.c (xg_create_frame_widgets):
216 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
217 present with Gtk+ 2.0.
218
83aca1cb
PE
2192011-11-26 Paul Eggert <eggert@cs.ucla.edu>
220
221 * fileio.c (Finsert_file_contents): Undo previous change; see
222 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
223
5b76caa4
PE
2242011-11-26 Paul Eggert <eggert@cs.ucla.edu>
225
226 Rename locals to avoid shadowing.
227 * fileio.c (Finsert_file_contents):
228 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
229 * process.c (wait_reading_process_output):
230 Rename inner 'proc' to 'p' to avoid shadowing.
231 Indent for consistency with usual Emacs style.
232
8c535114
EZ
2332011-11-25 Eli Zaretskii <eliz@gnu.org>
234
235 * xdisp.c (redisplay_window): If cursor row is not fully visible
236 after recentering, and scroll-conservatively is set to a large
237 number, scroll window by a few more lines to make the cursor fully
238 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
239 (start_display): Don't move to the next line if the display should
240 start at a newline that is part of a display vector or an overlay
241 string. (Bug#10119)
8c535114 242
fa4fdb5c
JL
2432011-11-24 Juri Linkov <juri@jurta.org>
244
245 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
246 after the `MagickPingImage' call. (Bug#10112)
247
90ec88df
CY
2482011-11-23 Chong Yidong <cyd@gnu.org>
249
250 * window.c (Fcoordinates_in_window_p): Accept only live windows.
251
56e2e794
MR
2522011-11-23 Martin Rudalics <rudalics@gmx.at>
253
254 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
255 making another buffer current. (Bug#10114)
256
b6e64c41
GM
2572011-11-23 Glenn Morris <rgm@gnu.org>
258
259 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
260
6b21de18
CY
2612011-11-23 Chong Yidong <cyd@gnu.org>
262
263 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
264 using it (Bug#5984).
265
b12cd789
EZ
2662011-11-22 Eli Zaretskii <eliz@gnu.org>
267
268 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
269 and header-lines, as they don't have one computed for them.
270 (Bug#10098)
271
272 * .gdbinit (prow): Make displayed values more self-explaining.
273 Add row's hash code.
274
261b6fd4
LMI
2752011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
276
277 * process.c (wait_reading_process_output): Fix asynchrounous
278 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 279 (wait_reading_process_output): Add comment and URL.
261b6fd4 280
e7cfd277
JD
2812011-11-21 Jan Djärv <jan.h.d@swipnet.se>
282
283 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
284
a9b9b7f5
CY
2852011-11-21 Chong Yidong <cyd@gnu.org>
286
287 * window.c (Fnext_window, Fprevious_window): Doc fix.
288
b0d15b4f
SM
2892011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
290
291 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
292
fe7a3057
JB
2932011-11-20 Juanma Barranquero <lekktu@gmail.com>
294
295 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
296
d2999b1a
MR
2972011-11-20 Martin Rudalics <rudalics@gmx.at>
298
299 * window.c (Fset_window_combination_limit): Rename argument
300 STATUS to LIMIT.
301 (Vwindow_combination_limit): Remove "status" from doc-string.
302
d5ff9cd0
AS
3032011-11-20 Andreas Schwab <schwab@linux-m68k.org>
304
305 * m/ibms390.h: Remove.
306 * m/ibms390x.h: Don't include "ibms390.h".
307
a5bb9bd3
SM
3082011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
309
310 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
311 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
312
cd1181db
JB
3132011-11-20 Juanma Barranquero <lekktu@gmail.com>
314
315 * casetab.c (Fset_case_table):
316 * charset.c (Fcharset_after): Fix typos.
317
615a3b8d 3182011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 319
17e845af
PE
320 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
321 Otherwise, valgrind does not work on some platforms.
322 Problem reported by Andreas Schwab in
6a0bf43d
PE
323 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
324 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
325 is set, removing the need for VIRT_ADDRESS_VARIES.
326 (PURE_P): Use a more-efficient implementation that needs just one
327 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
328 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
329 to 4 (xorl, subq, cmpq, setbe).
330 * alloc.c (pure): Always extern now, since that's the
331 VIRT_ADDR_VARIES behavior.
332 (PURE_POINTER_P): Use a single comparison, not two, for
333 consistency with the new puresize.h.
334 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
335 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
336 Remove VIRT_ADDR_VARIES no longer needed.
337
f8fe6f96
EZ
3382011-11-19 Eli Zaretskii <eliz@gnu.org>
339
340 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
341 (erase_phys_cursor, update_window_cursor, show_mouse_face)
342 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
343 behave as if the cursor position were at the window margin.
344
345 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
346 and the cursor position is out of bounds, behave as if the cursor
347 position were at the window margin. (Bug#10075)
348
df05a53c
CY
3492011-11-18 Chong Yidong <cyd@gnu.org>
350
351 * window.c (Fwindow_combination_limit): Make first argument
352 non-optional, since it is meaningless for live windows like the
353 selected window.
354
2071918e
DA
3552011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
356
357 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
358
b50a28de
SM
3592011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
360
361 * intervals.c: Fix grafting over the whole buffer (bug#10071).
362 (graft_intervals_into_buffer): Simplify.
363
015137db
EZ
3642011-11-18 Eli Zaretskii <eliz@gnu.org>
365
366 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
367 hash values of the two rows.
368 (copy_row_except_pointers): Preserve the used[] arrays and the
369 hash values of the two rows. (Bug#10035)
68c95424 370 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
371
372 * xdisp.c (row_hash): New function, body extracted from
373 compute_line_metrics.
374 (compute_line_metrics): Call row_hash, instead of computing the
375 hash code inline.
376
377 * dispnew.c (verify_row_hash): Call row_hash for computing the
378 hash code of a row, instead of duplicating code from xdisp.c.
379
380 * dispextern.h (row_hash): Add prototype.
381
a2addb04
TH
3822011-11-18 Tassilo Horn <tassilo@member.fsf.org>
383
384 * frame.c (delete_frame): Don't delete the terminal when the last
385 X frame is closed if emacs is built with GTK toolkit.
386
df85d315
JB
3872011-11-17 Juanma Barranquero <lekktu@gmail.com>
388
389 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
390
a0c2d0ae
MR
3912011-11-17 Martin Rudalics <rudalics@gmx.at>
392
393 * window.c (Vwindow_splits): Rename to
394 Vwindow_combination_resize. Suggested by Juri Linkov.
395 (Fsplit_window_internal): Use Vwindow_combination_resize instead
396 of Vwindow_splits.
397
58179cce
JB
3982011-11-16 Juanma Barranquero <lekktu@gmail.com>
399
7877f373
JB
400 * nsfns.m (Fns_font_name):
401 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 402
b6f67890
MR
4032011-11-16 Martin Rudalics <rudalics@gmx.at>
404
405 * window.h (window): Rename slot "nest" to "combination_limit".
406 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
407 (Fset_window_nest): Rename to Fset_window_combination_limit.
408 (Vwindow_nest): Rename to Vwindow_combination_limit.
409 (recombine_windows, make_parent_window, make_window)
410 (Fsplit_window_internal, saved_window)
411 (Fset_window_configuration, save_window_save): Rename all
412 occurrences of window_nest to window_combination_limit.
413
c7015153
JB
4142011-11-15 Juanma Barranquero <lekktu@gmail.com>
415
416 * image.c (imagemagick_load_image): Fix typo.
417
322ad6ec
EZ
4182011-11-14 Eli Zaretskii <eliz@gnu.org>
419
420 * xdisp.c (display_line): Move the call to
421 highlight_trailing_whitespace before the call to
422 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
423 faces of all the glyphs to compute ROW's hash value.
424 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 425
f067b8ec
JB
4262011-11-14 Juanma Barranquero <lekktu@gmail.com>
427
428 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
429 just return (bug#10044).
430
1e5b2111
EZ
4312011-11-12 Eli Zaretskii <eliz@gnu.org>
432
7ef3cbd5
EZ
433 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
434 with user-defined heap size. Bump the default size of the temacs
435 heap to 27MB, to avoid memory warning when running temacs.
436 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
437
1e5b2111
EZ
438 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
439 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
440 (verify_row_hash) [XASSERTS]: New function.
441 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
442 that the hash value of glyph rows is correct.
1e5b2111 443
89d61221
MR
4442011-11-12 Martin Rudalics <rudalics@gmx.at>
445
446 * window.h (window): Remove splits slot.
447 * window.c (Fwindow_splits, Fset_window_splits): Remove.
448 (Fdelete_other_windows_internal, make_parent_window)
449 (make_window, Fsplit_window_internal, Fdelete_window_internal)
450 (Fset_window_configuration, save_window_save): Don't deal with
451 split status of windows.
452 (saved_window): Remove splits slot.
453 (Vwindow_splits): Rewrite doc-string.
454
97f18cc8
JD
4552011-11-11 Jan Djärv <jan.h.d@swipnet.se>
456
457 * xfns.c (unwind_create_frame):
458 * nsfns.m (unwind_create_frame):
459 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
460 Vframe_list (Bug#9999).
461
22a648b4
DA
4622011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
463
0b381c7e 464 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 465
659afede
KH
4662011-11-11 Kenichi Handa <handa@m17n.org>
467
468 * callproc.c (Fcall_process): Set the member dst_multibyte of
469 process_coding.
470
9ac0394b
KH
4712011-11-11 Johan Bockgård <bojohan@gnu.org>
472
473 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
474 avoid a crash (bug#9496).
475
2fbdc249
CY
4762011-11-09 Chong Yidong <cyd@gnu.org>
477
478 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
479 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
480
ac6b1f81
PE
4812011-11-08 Paul Eggert <eggert@cs.ucla.edu>
482
483 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
484
09db192c
PE
4852011-11-08 Paul Eggert <eggert@cs.ucla.edu>
486
487 Avoid some portability problems by eschewing 'extern inline' functions.
488 The trivial performance wins aren't worth the portability hassles; see
489 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
490 et seq.
491 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
492 (window_box_width, window_box_left, window_box_left_offset)
493 (window_box_right, window_box_right_offset): Undo previous change,
494 by removing the "extern"s.
495 * intervals.c (adjust_intervals_for_insertion)
496 (adjust_intervals_for_deletion): Undo previous change,
497 making these static again.
498 (offset_intervals, temp_set_point_both, temp_set_point)
499 (copy_intervals_to_string): No longer inline.
500 * xdisp.c (window_text_bottom_y, window_box_width)
501 (window_box_height, window_box_left_offset)
502 (window_box_right_offset, window_box_left, window_box_right)
503 (window_box): No longer inline.
504
105216ed
CY
5052011-11-08 Chong Yidong <cyd@gnu.org>
506
507 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
508 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
509 Signal an error if not a live window.
105216ed
CY
510 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
511 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
512
ae9e237f
JB
5132011-11-07 Juanma Barranquero <lekktu@gmail.com>
514
515 * lisp.h (syms_of_abbrev): Remove declaration.
516 Reported by CHENG Gao <chenggao@royau.me>.
517
c7aa8333
EZ
5182011-11-07 Eli Zaretskii <eliz@gnu.org>
519
520 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
521 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
522 of temacs in GUI mode.
523
be7f5545
MR
5242011-11-07 Martin Rudalics <rudalics@gmx.at>
525
526 * window.h: Declare delete_all_child_windows instead of
527 delete_all_subwindows.
528 * window.c (Fwindow_nest, Fset_window_nest)
529 (Fset_window_new_total, Fset_window_new_normal)
530 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
531 (delete_all_subwindows): Rename to delete_all_child_windows.
532 (Fdelete_other_windows_internal, Fset_window_configuration):
533 Call delete_all_child_windows instead of delete_all_subwindows.
534 * frame.c (delete_frame): Call delete_all_child_windows instead
535 of delete_all_subwindows.
536
ca78dc43
PE
5372011-11-07 Paul Eggert <eggert@cs.ucla.edu>
538
539 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
540 This is also needed for porting to any host where GC_MARK_STACK is
541 not GC_MAKE_GCPROS_NOOPS.
542 (which_symbols): Use it.
543
a0241d01
KH
5442011-11-07 Kenichi Handa <handa@m17n.org>
545
546 * coding.c (coding_set_destination): Check coding->src_pos only
547 when coding->src_object is a buffer (bug#9910).
548
549 * process.c (send_process): Set the member src_multibyte of coding
550 to 0 (bug#9911) when sending a unibyte text.
551
552 * callproc.c (Fcall_process): Set the member src_multibyte of
553 process_coding to 0 (bug#9912).
554
a64bfdfa 5552011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
556
557 * xmenu.c (cleanup_widget_value_tree): New function.
558 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
559 calling free_menubar_widget_value_tree directly (Bug#9830).
560
cb41b32a
PE
5612011-11-06 Paul Eggert <eggert@cs.ucla.edu>
562
563 Fix some portability problems with 'inline'.
564 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
565 (window_box_width, window_box_left, window_box_left_offset)
566 (window_box_right, window_box_right_offset): Declare extern.
567 Otherwise, these inline functions do not conform to C99 and
568 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
569 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
570 * intervals.c (adjust_intervals_for_insertion)
571 (adjust_intervals_for_deletion): Now extern, because otherwise the
572 extern inline functions 'offset_intervals' couldn't refer to it.
573 (static_offset_intervals): Remove.
574 (offset_intervals): Rewrite using the old contents of
575 static_offset_intervals. The old version didn't conform to C99
576 because an extern inline function contained a reference to an
577 identifier with static linkage.
578
b7041366
AS
5792011-11-06 Andreas Schwab <schwab@linux-m68k.org>
580
581 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
582 GC.
583
88a37c4d
EZ
5842011-11-06 Eli Zaretskii <eliz@gnu.org>
585
586 * xdisp.c (init_iterator, reseat_to_string): Don't set the
587 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
588 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
589 return Qleft_to_right.
590
49745b39
CY
5912011-11-06 Chong Yidong <cyd@gnu.org>
592
593 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
594 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
595 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
596 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
597 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
598 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
599 (Fwindow_vscroll): Doc fix.
600 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
601 argument, since it makes no sense to pass a live window and for
602 consistency with window-child.
603
1f05cd82
CS
6042011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
605
606 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
607 support MSVC.
608
22610910
JR
6092011-11-05 Jason Rumney <jasonr@gnu.org>
610
611 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
612 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
613 fonts (Bug#6029).
614 (add_font_entity_to_list): Fix logic errors in mixed boolean and
615 bitwise arithmetic preventing use of unicode-sip and non-truetype
616 opentype fonts.
617
a06776b2
EZ
6182011-11-05 Eli Zaretskii <eliz@gnu.org>
619
3ad924ba
EZ
620 * s/ms-w32.h (fstat, stat, utime): Move redirections to
621 "emacs"-only part.
622
a06776b2
EZ
623 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
624 initialization code to keep similarity to xfns.c after changes
625 from 2011-11-05.
626
c9e7db78
JD
6272011-11-05 Jan Djärv <jan.h.d@swipnet.se>
628
a97f8f3f
JD
629 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
630 (unwind_create_frame): New function (Bug#9943).
631 (Fx_create_frame): Restructure code to be more similar to the one in
632 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
633 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
634 Move terminal->reference_count++ just before making the frame official
635 (Bug#9943).
636
637 * nsterm.m (x_free_frame_resources): New function.
638 (x_destroy_window): Move code to x_free_frame_resources.
639
c9e7db78 640 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
641 (Fx_create_frame, x_create_tip_frame):
642 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
643 official. Move initialization of image_cache_refcount and
644 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
645
a6fc3b5c
EZ
6462011-11-05 Eli Zaretskii <eliz@gnu.org>
647
648 Support MSVC build with newer versions of Visual Studio.
649 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
650 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
651 nt/gmake.defs.
652
653 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
654 which are not supported by MSVC.
655 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
656 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
657 bitfields.
658 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
659 types in bitfields.
660 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
661
662 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
663
58179cce 6642011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
665
666 Support MSVC build with newer versions of Visual Studio.
667 * w32.c: Don't include w32api.h for MSVC.
668 (init_environment) [_MSC_VER]: Call sys_access, not _access.
669
670 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
671 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
672 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
673 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
674 e_* cousins.
675 (alloca) [_MSC_VER]: Define to _alloca.
676
677 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
678
679 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
680
a58c13ed
EZ
6812011-11-04 Eli Zaretskii <eliz@gnu.org>
682
683 * xdisp.c (note_mouse_highlight): If either of
684 previous/next-single-property-change returns nil, treat that as
685 the beginning or the end of the buffer. (Bug#9955)
686
fe0b6370
JD
6872011-11-04 Jan Djärv <jan.h.d@swipnet.se>
688
a58c13ed 689 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
690 label is not null (Bug#9951).
691 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
692 may be NULL.
693
89bd5ee1
EZ
6942011-11-04 Eli Zaretskii <eliz@gnu.org>
695
696 * window.c (Fwindow_body_size): Mention in the doc string that the
697 return value is in frame's canonical units. (Bug#9949)
698
84c3edb9
EZ
6992011-11-03 Eli Zaretskii <eliz@gnu.org>
700
4e2fb5c7
EZ
701 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
702
84c3edb9 703 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 704 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 705 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 706
bc17a887
EZ
7072011-11-01 Eli Zaretskii <eliz@gnu.org>
708
709 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
710 Don't stop backward scan on the continuation glyph, even though
711 its CHARPOS is positive.
6d5eb5b0
SM
712 (mouse_face_from_buffer_pos, note_mouse_highlight):
713 Rename cover_string to disp_string.
bc17a887 714
4ee88440
MR
7152011-11-01 Martin Rudalics <rudalics@gmx.at>
716
717 * window.c (temp_output_buffer_show): Don't use
718 Vtemp_buffer_show_specifiers.
719 (Vtemp_buffer_show_specifiers): Remove unused variable.
720
c2ff3c02
EZ
7212011-10-30 Eli Zaretskii <eliz@gnu.org>
722
723 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
724 past the beginning of the current glyph matrix.
725
58179cce 7262011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
727
728 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
729 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
730 HAVE_GTK3 (Bug#9869).
b77a6a7f 731
3b574623
JD
732 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
733 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
734
b77a6a7f
JD
735 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
736
737 * xterm.c: Declare x_handle_net_wm_state to return int.
738 (handle_one_xevent): Check if we are iconified but don't have
739 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
740 (get_current_wm_state): Return non-zero if not hidden,
741 check for _NET_WM_STATE_HIDDEN (Bug#9893).
742 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
743 (x_handle_net_wm_state): Return what get_current_wm_state returns.
744 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
745
196e41e4
PE
7462011-10-29 Paul Eggert <eggert@cs.ucla.edu>
747
748 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
749 so that this new function doesn't get optimized away by a
750 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
751
021f2e1a
AS
7522011-10-29 Andreas Schwab <schwab@linux-m68k.org>
753
754 * frame.h (MOUSE_HL_INFO): Remove excess parens.
755
8b058d44
EZ
7562011-10-29 Eli Zaretskii <eliz@gnu.org>
757
758 Fix the `xbytecode' command.
759 * .gdbinit (xprintbytestr): New command.
b50a28de 760 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
761 (xbytecode): Print the byte-code string as well.
762
4452fb80
EZ
7632011-10-29 Kim Storm <storm@cua.dk>
764
8b058d44
EZ
765 * alloc.c (which_symbols): New function.
766
21b72067
AS
7672011-10-29 Andreas Schwab <schwab@linux-m68k.org>
768
769 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
770 line. (Bug#9903)
771
83ed7b5c
GM
7722011-10-29 Glenn Morris <rgm@gnu.org>
773
774 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
775 Not clear what it was for, and it causes various bugs. (Bug#9839)
776
5a7a728b
EZ
7772011-10-28 Eli Zaretskii <eliz@gnu.org>
778
779 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
780 possible random value that matches one of those tested as
781 condition to clear the mouse face.
782
d3d0842f
CY
7832011-10-28 Chong Yidong <cyd@gnu.org>
784
785 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
786
31b39d13
DN
7872011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
788
789 * window.c (make_window): Initialize phys_cursor_on_p.
790
9aba6043
SM
7912011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
792
793 * lisp.h (struct Lisp_Symbol): Update comments.
794
c20992f4
JB
7952011-10-28 Juanma Barranquero <lekktu@gmail.com>
796
797 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
798
db4f02f2
EZ
7992011-10-28 Eli Zaretskii <eliz@gnu.org>
800
801 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
802 <oslsachem@gmail.com> for helping to debug this.
803
804 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
805 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
806 (g_b_init_get_glyph_outline_w): New static variables.
807 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
808 (GetGlyphOutlineW_Proc): New typedefs.
809 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
810 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
811 New functions.
812 (w32font_open_internal, compute_metrics):
813 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
814 instead of calling the "wide" APIs directly.
815
816 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
817
818 * w32.h (syms_of_w32font): Add prototype.
819
87e68db4
JB
8202011-10-27 Juanma Barranquero <lekktu@gmail.com>
821
822 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
823 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
824 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
825 (Fmove_to_window_line): Doc fix.
826
435c1d67
CY
8272011-10-27 Chong Yidong <cyd@gnu.org>
828
829 * process.c (make_process): Set gnutls_state to NULL.
830
831 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
832 non-NULL, regardless of GNUTLS_INITSTAGE.
833 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
834 an error. Set process slots as soon as we allocate them.
835
836 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
837
9c6c6f49
CY
8382011-10-27 Chong Yidong <cyd@gnu.org>
839
9aba6043
SM
840 * gnutls.c (emacs_gnutls_deinit): New function.
841 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
842 (Fgnutls_deinit, Fgnutls_boot): Use it.
843
844 * process.c (make_process): Initialize GnuTLS credentials to NULL.
845 (deactivate_process): Call emacs_gnutls_deinit.
846
657d08d3
JB
8472011-10-27 Juanma Barranquero <lekktu@gmail.com>
848
849 * image.c (x_create_x_image_and_pixmap):
850 * w32.c (sys_rename, w32_delayed_load):
851 * w32font.c (fill_in_logfont):
852 * w32reg.c (x_get_string_resource): Silence compiler warnings.
853
5430d399
JB
8542011-10-26 Juanma Barranquero <lekktu@gmail.com>
855
856 * w32fns.c (w32_default_color_map): New function,
857 extracted from Fw32_default_color_map.
a7ef684b 858 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 859
fe0055fa
PE
8602011-10-25 Paul Eggert <eggert@cs.ucla.edu>
861
862 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
863
e6346438
SM
8642011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
865
866 * keyboard.c (test_undefined): New function (bug#9751).
867 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
868
e112cc37
ET
8692011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
870
871 * sysdep.c (init_sys_modes): Fix the check for the controlling
872 terminal (Bug#6649).
873
7b5d6677
EZ
8742011-10-20 Eli Zaretskii <eliz@gnu.org>
875
876 * dispextern.h (struct bidi_it): New member next_en_type.
877
878 * bidi.c (bidi_line_init): Initialize the next_en_type member.
879 (bidi_resolve_explicit_1): When next_en_pos is valid for the
880 current character, check also for next_en_type being WEAK_EN.
881 (bidi_resolve_weak): Don't enter the expensive loop if the current
882 position is before next_en_pos. Record the bidi type of the first
883 non-ET, non-BN character we find, in addition to its position.
884 (bidi_level_of_next_char): Invalidate next_en_type when
885 next_en_pos is over-stepped.
886
7da0b018
PE
8872011-10-20 Paul Eggert <eggert@cs.ucla.edu>
888
889 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
890 * editfns.c: Rewrite current-time-zone so that it invokes
891 the equivalent of (format-time-string "%Z") to get the time zone name.
892 This fixes a bug when the time zone name contains characters that
893 need converting from the system time locale to Emacs internal format.
894 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
895 that patch fixed format-time-string to do the conversion, but
896 I forgot to fix current-time-zone.
897 (format_time_string): New function, containing most of
898 what Fformat_time_string used to contain.
899 (Fformat_time_string): Rewrite in terms of format_time_string.
900 This doesn't change this function's behavior.
901 (current-time-zone): Rewrite to use format_time_string.
902 This fixes the bug reported by Michael Schierl in
903 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
904 Jason Rumney's 2007-06-07 change worked around this bug, but
905 didn't fix it.
906 * systime.h (tzname, timezone): Remove no-longer-used declarations.
907
8547b010
EZ
9082011-10-19 Eli Zaretskii <eliz@gnu.org>
909
910 * xdisp.c (start_display): If the character at POS is displayed
911 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
912 (try_window_reusing_current_matrix): If a line ends in a display
913 vector or the next line starts in a display vector, continue
914 redrawing the window even though the character position of
915 start_row was reached.
8547b010
EZ
916 (Bug#9771, part 2)
917
4e948d15
CY
9182011-10-18 Chong Yidong <cyd@gnu.org>
919
920 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
921 with nobreak-char-display too.
922
4787455f
EZ
9232011-10-18 Eli Zaretskii <eliz@gnu.org>
924
925 Fix part 3 of bug#9771.
926 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
927 (bidi_resolve_neutral): Don't enter the expensive loop looking for
928 non-neutral characters if the current character is a paragraph
929 separator (a.k.a. Newline). This avoids running the same
930 expensive loop twice, once when we consume the preceding newline
931 and the other time when the line actually needs to be displayed.
932 Avoid the loop when we see neutrals on the base embedding level
933 following a character whose directionality is the same as the
934 paragraph's. This avoids running the expensive loop when a line
935 ends in a long sequence of neutrals, like control characters.
936 Add assertion against STRONG_AL type. Slightly rearrange code
937 that determines the type of a neutral given the first non-neutral
938 that follows it.
939 (bidi_level_of_next_char): Set next_en_pos to zero when
940 invalidating its info.
941
2c91f553
EZ
9422011-10-17 Eli Zaretskii <eliz@gnu.org>
943
944 * xdisp.c (push_display_prop): Determine whether to record string
945 or buffer position by IT->string, not by IT->method. Allow
946 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
947 (move_it_vertically_backward): Don't look for character position
948 immediately after the newline when in a continuation line.
949 (Bug#9771, part 1)
2c91f553 950
c7b08b0d
MR
9512011-10-15 Martin Rudalics <rudalics@gmx.at>
952
953 * window.c (coordinates_in_window): Rewrite and delabelize
954 vertical border check. (Bug#5357) (Bug#9618)
955
6b02f655
SM
9562011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
957
958 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
959 errors in XSetWindowBorder (bug#9310).
960
81d40c92
DA
9612011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
962
963 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
964 avoid crash when xmalloc overrun checking is enabled.
965
d4172c3b
EZ
9662011-10-13 Eli Zaretskii <eliz@gnu.org>
967
968 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
969 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
970 cursor motion with <left> and <right> arrow keys.
971
972 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
973 some callers set that themselves.
974
b00eea75
EZ
9752011-10-12 Eli Zaretskii <eliz@gnu.org>
976
977 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
978 display string and the previous row comes from the same string and
979 is empty. (Bug#9739) (Bug#9738)
980
8fe012c4
SM
9812011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
982
983 * doc.c (get_doc_string): Encode file name (bug#9735).
984
0074aef2
EZ
9852011-10-12 Eli Zaretskii <eliz@gnu.org>
986
79beb178
EZ
987 * bidi.c (bidi_level_of_next_char):
988 * xdisp.c (get_visually_first_element): Remove old incorrect
989 comments regarding the Unicode Line Separator character.
990
0074aef2
EZ
991 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
992
6e4b3fbe
DA
9932011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
994
995 * alloc.c (Fgc_status): Do not access beyond zombies array
996 boundary if nzombies > MAX_ZOMBIES.
997 * alloc.c (dump_zombies): Add missing format specifier.
998
0324f3af
PE
9992011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1000
b5525cac
PE
1001 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1002 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1003
0324f3af
PE
1004 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1005 Some packages use them to denote characters with modifiers.
1006
e9b5f888
AS
10072011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1008
1009 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1010 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1011 matching a pp-number. Rename parameter var to var1.
1012
127827c0
SM
10132011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1014
1015 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1016
c8fd3bd0
GM
10172011-10-08 Glenn Morris <rgm@gnu.org>
1018
1019 * callint.c (Fcall_interactively): Give a more explicit error for the
1020 'c' case with a non-character input. (Bug#8479)
1021
352ec8ff
EZ
10222011-10-08 Eli Zaretskii <eliz@gnu.org>
1023
03669ccb
EZ
1024 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1025 lines.
7061c986
EZ
1026 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1027 lines that are hscrolled on the left.
03669ccb 1028
352ec8ff
EZ
1029 * dispnew.c (buffer_posn_from_coords): Account for a possible
1030 presence of header-line. (Bug#4426)
1031
a66cfb1c
SM
10322011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1033
6b02f655
SM
1034 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1035 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1036
7c5ee88e
PE
10372011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1038
1039 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1040 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1041 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1042 this makes Emacs dump core during garbage collection on rare
1043 occasions. sizeof is obviously inferior to offsetof here, so
1044 stick with offsetof.
1045 (GC_POINTER_ALIGNMENT): New macro.
1046 (mark_memory): Omit 3rd (offset) arg; caller changed.
1047 Don't assume EMACS_INT alignment is the same as pointer alignment.
1048
df1bbe5b
SM
10492011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1050
1051 * keyboard.c (read_key_sequence_remapped): New var.
1052 (read_key_sequence): Compute remapping in the right buffer.
1053 (command_loop_1): Use read_key_sequence's remapping directly.
1054
51553db6
SM
10552011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1056
32c1fffd
SM
1057 * dired.c (file_name_completion): Don't expand file name.
1058 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1059 before checking file name handler.
1060
51553db6
SM
1061 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1062 they've been requested explicitly (bug#9591).
1063
b6bd1599 10642011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1065
1066 * keymap.c (Fsingle_key_description): Use make_specified_string
1067 instead of build_string to build string from push_key_description.
1068 (Bug#5193)
1069
f701dc2a
PE
10702011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1071
4222c55d
PE
1072 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1073 This fixes a Y2038 bug on 64-bit hosts.
1074 * buffer.c (reset_buffer):
1075 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1076 (Fclear_buffer_auto_save_failure):
1077 Use 0, not -1, to represent an unset failure time, since time_t
1078 might not be signed.
1079
f701dc2a
PE
1080 Remove dependency on glibc malloc internals.
1081 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1082 Move back here from lisp.h, but with their new implementations.
1083 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1084 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1085 * charset.c (charset_table_init): New static var.
1086 (syms_of_charset): Use it instead of xmalloc. This removes a
1087 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1088 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1089 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1090 Move back to alloc.c.
1091 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1092 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1093
9ceebf39
JD
10942011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1095
1096 * nsterm.m (windowDidResize): Call x_set_window_size only when
1097 ns_in_resize is true. Otherwise set pixelwidth/height and
1098 call change_frame_size (Bug#9628).
1099
cb993c58
PE
11002011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1101
3930c88b
PE
1102 Port --enable-checking=all to Fedora 14 x86-64.
1103 * charset.c (syms_of_charset): Also account for glibc malloc's
1104 internal overhead when calculating the initial malloc maximum.
1105
cb993c58
PE
1106 Port --enable-checking=all to Fedora 14 x86.
1107 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1108 Move to lisp.h.
1109 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1110 (overrun_check_realloc, overrun_check_free):
1111 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1112 That way, xmalloc returns a properly-aligned pointer even if
1113 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1114 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1115 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1116 into account when calculating the initial malloc maximum.
1117 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1118 Move here from alloc.c, so that charset.c can use it too.
1119 Properly align; the old code wasn't right for common 32-bit hosts
1120 when configured with --enable-checking=all.
1121 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1122 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1123
31bed486
EZ
11242011-09-29 Eli Zaretskii <eliz@gnu.org>
1125
04c70788 1126 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1127 use EDOM.
1128
fbcaa2f3
EZ
11292011-09-28 Eli Zaretskii <eliz@gnu.org>
1130
1131 * xdisp.c (compute_display_string_end): If there's no display
1132 string at CHARPOS, return -1.
1133
1134 * bidi.c (bidi_fetch_char): When compute_display_string_end
1135 returns a negative value, treat the character as a normal
1136 character not covered by a display string. (Bug#9624)
1137
a239d4e9
JB
11382011-09-28 Juanma Barranquero <lekktu@gmail.com>
1139
1140 * lread.c (Fread_from_string): Fix typo in docstring.
1141
88652fd5
EZ
11422011-09-27 Eli Zaretskii <eliz@gnu.org>
1143
1144 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1145 newline, reseat the iterator instead of bidi-iterating there one
1146 character at a time. (Bug#9610)
32c1fffd
SM
1147 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1148 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1149
ed497dd4
AS
11502011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1151
1152 * lread.c (readevalloop): Use correct code for NBSP.
1153 (read1): Likewise. (Bug#9608)
1154
b2bf61aa
MA
11552011-09-25 Michael Albinus <michael.albinus@gmx.de>
1156
1157 * dbusbind.c (Fdbus_register_signal): When service is not
1158 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1159
32bbb17c
GM
11602011-09-25 Glenn Morris <rgm@gnu.org>
1161
1162 * buffer.c (truncate-lines): Doc fix.
1163
94e0933e
CY
11642011-09-24 Chong Yidong <cyd@stupidchicken.com>
1165
1166 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1167 (Fset_window_next_buffers): Doc fix.
1168
cddde921
GM
11692011-09-24 Glenn Morris <rgm@gnu.org>
1170
1171 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1172
1260aef1
PE
11732011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1174
25b4bfa0
PE
1175 Fix minor problems found by static checking.
1176 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1177 * indent.c (Fvertical_motion): Fix == vs = typo.
1178
e3cbd34b
EZ
11792011-09-24 Eli Zaretskii <eliz@gnu.org>
1180
a66cfb1c
SM
1181 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1182 Default value is now t. Doc fix.
6bf7006f 1183
e3cbd34b 1184 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1185 logic when moving up, not only when moving down. Fix the
e3cbd34b 1186 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1187 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1188
1189 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1190 CHARPOS is covered by a display string which includes newlines.
1191 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1192 is covered by a display string with embedded newlines.
1193
a3de0cbd
MA
11942011-09-24 Michael Albinus <michael.albinus@gmx.de>
1195
1196 * dbusbind.c (Fdbus_register_signal): Add match rule to
1197 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1198 (Fdbus_register_method, Vdbus_registered_objects_table):
1199 Fix docstring.
a3de0cbd 1200
b260039d
JM
12012011-09-24 Jim Meyering <meyering@redhat.com>
1202
32c1fffd 1203 do not ignore write error for any output size
b260039d
JM
1204 The previous change was incomplete.
1205 While it makes emacs --batch detect the vast majority of stdout
1206 write failures, errors were still ignored whenever the output size is
1207 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1208 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1209 && echo FAIL: ignored write error
1210 FAIL: ignored write error
1211 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1212 && echo FAIL: ignored write error
1213 FAIL: ignored write error
1214 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1215
8eca8a7c
AS
12162011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1217
1218 * emacs.c (Fkill_emacs): In noninteractive mode exit
1219 non-successfully if a write error occurred on stdout. (Bug#9574)
1220
3341db62
EZ
12212011-09-21 Eli Zaretskii <eliz@gnu.org>
1222
1223 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1224 the xassert test.
1225
1226 * dispextern.h (struct it): Update the comment documenting what
1227 can it->OBJECT be.
1228
8c203dbf
EZ
12292011-09-20 Eli Zaretskii <eliz@gnu.org>
1230
1231 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1232 a display string, extend search for cursor position to end of row.
1233 (find_row_edges): If the row ends in a newline from a display
1234 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1235 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1236 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1237 non-empty line. Fixes confusing cursor motion with arrow keys at
1238 the beginning of a line that starts with whitespace.
8c203dbf 1239
a4824228
LMI
12402011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1241
1242 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1243 (bug#9493).
1244
33ed493b
CY
12452011-09-18 Chong Yidong <cyd@stupidchicken.com>
1246
1247 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1248 boolean (Bug#9154).
1249
56cd55c8
EZ
12502011-09-18 Eli Zaretskii <eliz@gnu.org>
1251
1252 * xdisp.c (display_line): Record maximum and minimum buffer
1253 positions even if no glyphs were produced (e.g., by a zero-width
1254 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1255 buffer positions that will be removed from the glyph row because
1256 they don't fit.
c02dcedf
EZ
1257 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1258 column is beyond frame width: don't subtract 1 "pixel" when
1259 computing width of the stretch.
3e62b7e0
EZ
1260 (reseat_at_next_visible_line_start): Undo the change made on
1261 2011-09-17 that saved paragraph information and restored it after
1262 the call to `reseat'. (Bug#9545)
56cd55c8 1263
5ed99d36 12642011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1265
1266 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1267 and turn window cursor on if cleared (Bug#9415).
1268
5ed99d36 12692011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1270
1271 * search.c (boyer_moore): Take unibyte characters from pattern
1272 literally. (Bug#9458)
1273
9bade7b2
EZ
12742011-09-18 Eli Zaretskii <eliz@gnu.org>
1275
1276 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1277
e5e9d610
PE
12782011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1279
87e4427a
PE
1280 Fix minor problem found by static checking.
1281 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1282 initialized, to pacify gcc -Wuninitialized.
1283
e5e9d610
PE
1284 * fileio.c: Report proper errno when syscall falls.
1285 (Finsert_file_contents): Save and restore errno,
1286 so that report_file_error outputs the correct diagnostic.
1287 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1288
a1674f0b
EZ
12892011-09-18 Eli Zaretskii <eliz@gnu.org>
1290
1291 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1292
fbfb6dd4
EZ
12932011-09-17 Eli Zaretskii <eliz@gnu.org>
1294
1295 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1296 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1297
bb187662
EZ
12982011-09-17 Eli Zaretskii <eliz@gnu.org>
1299
1137e8b8 1300 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1301 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1302
1303 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1304 (bidi_find_paragraph_start): Search back for paragraph beginning
1305 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1306 (bidi_move_to_visually_next): Only trigger paragraph-related
1307 computations when the last character is a newline or at EOB, not
1308 just any NEUTRAL_B. (Bug#9470)
1309
bb187662
EZ
1310 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1311 truncated lines if point is covered by a display string. (Bug#9524)
1312
2e621251
PE
13132011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1314
1315 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1316 (cons_to_x_long): New function.
1317 (lisp_data_to_selection_data): Use it. Correct the test for
1318 short-versus-long data; it was negated. Break out of vector
1319 loop, for efficiency, when a long datum is discovered.
1320
91a15bc6
SM
13212011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1322
1323 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1324
b41c3a35
EZ
13252011-09-16 Eli Zaretskii <eliz@gnu.org>
1326
1327 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1328 GCC PR/17406) by declaring this function with external scope.
1329
7812ba2d
PE
13302011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1331
1332 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1333 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1334
cf7edc2a
AS
13352011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1336
1337 * editfns.c (Fformat): Correctly handle text properties on "%%".
1338
bd01620e
EZ
13392011-09-15 Eli Zaretskii <eliz@gnu.org>
1340
1341 * xterm.c (x_draw_composite_glyph_string_foreground):
1342 * w32term.c (x_draw_composite_glyph_string_foreground):
1343 * term.c (encode_terminal_code):
1344 * composite.c (composition_update_it, get_composition_id):
1345 * xdisp.c (get_next_display_element)
1346 (fill_composite_glyph_string): Add comments about special meaning
1347 of TAB characters in a composition.
1348
a02719a3
PE
13492011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1350
1351 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1352 This occurs when processing a multibyte format.
1353 Problem reported by Wolfgang Jenker.
a02719a3 1354
72589a3c
JB
13552011-09-15 Johan Bockgård <bojohan@gnu.org>
1356
1357 * xdisp.c (try_cursor_movement): Only check for exact match if
1358 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1359
1c14176c
PE
13602011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1361
1362 Remove unused external symbols.
1363 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1364 * xdisp.c (calc_pixel_width_or_height): Now static.
1365 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1366 * indent.c (check_display_width):
1367 * w32term.c: Fix comment to match code.
1368 * xterm.c, xterm.h (x_catching_errors): Remove.
1369
d2eea5b5
PE
13702011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1371
1372 * xselect.c: Use signed conversions more consistently (Bug#9498).
1373 (selection_data_to_lisp_data): Assume incoming selection data are
1374 signed integers, not unsigned. This is to be consistent with
1375 outgoing selection data, which was modified to use signed integers
1376 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1377 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1378 expects long, not unsigned long.
1379
46888499
EZ
13802011-09-14 Eli Zaretskii <eliz@gnu.org>
1381
1382 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1383 computation of loop end. Reported by Johan Bockgård
1384 <bojohan@gnu.org>.
1385
ef8ef9fb
CY
13862011-09-13 Chong Yidong <cyd@stupidchicken.com>
1387
1388 * frame.c (Fother_visible_frames_p): Function deleted.
1389
fa819fed
EZ
13902011-09-12 Eli Zaretskii <eliz@gnu.org>
1391
1392 * indent.c (compute_motion): Process display vector front to back
1393 rather than the other way around. (Bug#2496)
1394
2ba8e008
SM
13952011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1396
1397 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1398
20f53c69
CY
13992011-09-11 Chong Yidong <cyd@stupidchicken.com>
1400
1401 * minibuf.c (Fread_from_minibuffer): Doc fix.
1402
d562d7a4
EZ
14032011-09-11 Eli Zaretskii <eliz@gnu.org>
1404
1405 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1406 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1407
1c4d7f3d
LMI
14082011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1409
1410 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1411 value for non-existent files.
1412
b885bf36
EZ
14132011-09-11 Eli Zaretskii <eliz@gnu.org>
1414
1415 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1416 set its "size" to -1. This will set the modtime_size field of
1417 the corresponding buffer to -1, which is what
1418 verify-visited-file-modtime expects for files that do not exist.
1419 (Bug#9139)
1420
6612f0bf
PE
14212011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1422
1423 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1424 here ...
1425 * lisp.h: ... from here. push_key_description is no longer
1426 defined in keyboard.c, so its declaration should not be in
1427 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1428 logically belongs with push_key_description.
1429
dfb3f755
PE
14302011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1431
1432 * buffer.h: Include <sys/types.h> instead of <time.h>.
1433 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1434 Problem reported by Herbert J. Skuhra.
1435
3134906c
LMI
14362011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1437
1438 * xml.c (parse_region): Make the parsing work for
1439 non-comment-starting XML files again (bug#9144).
1440
8d903f4e
AS
14412011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1442
1443 * image.c (gif_load): Fix calculation of bottom and right corner.
1444 (Bug#9468)
1445
80ad64f4
EZ
14462011-09-10 Eli Zaretskii <eliz@gnu.org>
1447
1448 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1449 redisplay in small windows.
1450
208a048d
EZ
14512011-09-09 Eli Zaretskii <eliz@gnu.org>
1452
1453 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1454
9b1c252e
MR
14552011-09-08 Martin Rudalics <rudalics@gmx.at>
1456
1457 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1458 Operate on live windows only.
1459
2949f33b
JB
14602011-09-08 Juanma Barranquero <lekktu@gmail.com>
1461
1462 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1463
e08dcafd
EZ
14642011-09-07 Eli Zaretskii <eliz@gnu.org>
1465
1466 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1467 only under bidi iteration.
1468
115b96bd
JD
14692011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1470
1471 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1472
c8199d0f
PE
14732011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1474
1475 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1476 Without this fix, the command to link temacs failed due to an
1477 undefined symbol __builtin_isnan. This is because
1478 /usr/include/iso/math_c99.h #defines isnan(x) to
1479 __builtin_isnan(x), but the bundled gcc, which identifies itself
1480 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1481 a __builtin_isnan.
1482 * floatfns.c (isnan): #undef, and then #define to a clone of
1483 what's in data.c.
1484 (Fisnan): Always define, since it's always available now.
1485 (syms_of_floatfns): Always define isnan at the Lisp level.
1486
e39b275c 14872011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1488
1489 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1490
b2db44d9 14912011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1492
f4af5137 1493 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1494 The previous code assumed that file offsets (off_t values) fit in
1495 EMACS_INT variables, which is not true on typical 32-bit hosts.
1496 The code messed up by falsely reporting buffer overflow in cases
1497 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1498 when "big" contains more than 2**29 bytes, even though this
1499 inserts just one byte and does not overflow the buffer.
1500 (Finsert_file_contents): Store file offsets as off_t
1501 values, not as EMACS_INT values. Check for overflow when
1502 converting between EMACS_INT and off_t. When checking for
1503 buffer overflow or for overlap, take the offsets into account.
1504 Don't use EMACS_INT for small values where int suffices.
1505 When checking for overlap, fix a typo: ZV was used where
1506 ZV_BYTE was intended.
1507 (Fwrite_region): Don't assume off_t fits into 'long'.
1508 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1509
ecfc0a49
MA
15102011-09-05 Michael Albinus <michael.albinus@gmx.de>
1511
1512 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1513
6511acf2 15142011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1515
0999621a 1516 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1517
1518 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1519 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1520 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1521 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1522 (modify_event_symbol): Do not assume that the length of
1523 name_alist_or_stem is safe to alloca and fits in int.
1524 (Fexecute_extended_command): Likewise for function name and binding.
1525 (Frecursion_depth): Wrap around reliably on integer overflow.
1526 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1527 since some callers pass EMACS_INT values.
1528 (Fsingle_key_description): Don't crash if symbol name contains more
1529 than MAX_ALLOCA bytes.
1530 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1531 (get_minibuffer): Arg is now EMACS_INT, not int.
1532 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1533 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1534 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1535
2be7d702
PE
1536 * dbusbind.c (signature_cat): New function.
1537 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1538 Do not overrun buffer; instead, report string overflow.
1539
9d1df220
PE
1540 * dispnew.c (add_window_display_history): Don't overrun buffer.
1541 Truncate instead; this is OK since it's just a log.
1542
33ef5c64
PE
1543 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1544 even if the time zone offset is outlandishly large.
1545 Don't mishandle offset == INT_MIN.
1546
66c6fdd5
PE
1547 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1548 when creating daemon; the previous buffer-overflow check was incorrect.
1549
d749b01b
PE
1550 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1551 which has the guts of the old verror function.
1552
b5cd1905
PE
1553 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1554 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1555
6e1a67fb
PE
1556 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1557 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1558 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1559 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1560 length of string rather than counting it via multiple sprintfs;
1561 that's simpler and more reliable.
c21721cc
PE
1562 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1563 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1564 sprintf, in case result does not fit in int.
1565
c57b67fc
PE
1566 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1567 (fontset_from_font): Print it.
1568
8a401434
PE
1569 * frame.c (tty_frame_count): Now printmax_t, not int.
1570 (make_terminal_frame, set_term_frame_name): Print it.
1571 (x_report_frame_params): In X, window IDs are unsigned long,
1572 not signed long, so print them as unsigned.
1573 (validate_x_resource_name): Check for implausibly long names,
1574 and don't assume name length fits in 'int'.
1575 (x_get_resource_string): Don't blindly alloca invocation name;
1576 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1577 not fit in int.
1578
6e1a67fb
PE
1579 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1580 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1581 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1582
0df02bf3
PE
1583 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1584 Use esprintf, not sprintf, in case result does not fit in int.
1585
48e30793
PE
1586 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1587 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1588 it as a large positive number.
1589 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1590 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1591
a66ff6d8
PE
1592 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1593 in case result does not fit in int.
1594
aca216ff
PE
1595 * print.c (float_to_string): Detect width overflow more reliably.
1596 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1597 buffer overrun. Don't assume list length fits in 'int'. Treat
1598 print length of 0 as 0, not as infinity; to be consistent with other
1599 uses of print length in this function. Don't overflow print length
1600 index. Don't assume hash table size fits in 'long', or that
1601 vectorlike size fits in 'unsigned long'.
1602
31c286f7
PE
1603 * process.c (make_process): Use printmax_t, not int, to format
1604 process-name gensyms.
1605
55e5faa1
PE
1606 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1607
80f2e268
PE
1608 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1609 to avoid potential buffer overrun.
1610
670741ab
PE
1611 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1612 if X resource line is longer than 512 bytes.
1613
b7163a50
PE
1614 * xfns.c (x_window): Make sprintf buffer a bit bigger
1615 to avoid potential buffer overrun.
1616
ae58ff1f
PE
1617 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1618
c43c8a6a
PE
1619 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1620
3f8236f4
PE
16212011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1622
53e9fe90 1623 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1624 Without these, Emacs silently mishandles large integers sometimes.
1625 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1626 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1627
6511acf2
PE
1628 * xdisp.c (try_window_id): Check Emacs fixnum range before
1629 converting to 'int'.
806add1d 1630
6511acf2 1631 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1632 Check that an Emacs fixnum is in range before assigning it to 'int'.
1633 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1634 values converted from Emacs fixnums.
1635 (Frecenter): Don't wrap around a line count if it is out of 'int'
1636 range; instead, treat it as an extreme value.
1637 (Fset_window_configuration, compare_window_configurations):
1638 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1639
6511acf2
PE
1640 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1641 that can exceed INT_MAX. Check that EMACS_INT value is in range
1642 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1643 (match_limit): Don't assume that a fixnum can fit in 'int'.
1644
6511acf2 1645 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1646 exceed INT_MAX.
1647
6511acf2 1648 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1649 (Fvertical_motion): Don't wrap around LINES values that don't fit
1650 in 'int'. Instead, treat them as extreme values. This is good
1651 enough for windows, which can't have more than INT_MAX lines anyway.
1652
fcb901a7
LMI
16532011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1654
0f2f6b6d
LMI
1655 * Require libxml/parser.h to avoid compilation warning.
1656
fcb901a7
LMI
1657 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1658
1659 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1660 since this reportedly can destroy thread storage.
1661
6e20a0d4
CY
16622011-08-30 Chong Yidong <cyd@stupidchicken.com>
1663
1664 * syntax.c (find_defun_start): Update all cache variables if
1665 exiting early (Bug#9401).
1666
148ae00e
EZ
16672011-08-30 Eli Zaretskii <eliz@gnu.org>
1668
f6cfbd8f
EZ
1669 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1670
148ae00e
EZ
1671 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1672 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1673 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1674
1675 * term.c (tty_append_glyph): New function.
1676 (produce_stretch_glyph): Static function and its prototype deleted.
1677
a66cfb1c
SM
1678 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1679 Add prototypes.
148ae00e 1680
c4a07a4c
PE
16812011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1682
1683 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1684 when checking :margin (Bug#9390).
1685 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1686 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1687 so that the name doesn't mislead. All uses changed.
1688
6bc8cd65
JB
16892011-08-28 Johan Bockgård <bojohan@gnu.org>
1690
1691 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1692 set_tty_hooks.
1693
dca4927e
EZ
16942011-08-27 Eli Zaretskii <eliz@gnu.org>
1695
1696 * xdisp.c (move_it_to): Don't bail out early when reaching
1697 position beyond to_charpos, if we are scanning backwards.
1698 (move_it_vertically_backward): When DY == 0, make sure we get to
1699 the first character in the line after the newline.
1700
f2cad773
PE
17012011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1702
1703 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1704 (ccl_driver): Do not generate an out-of-range pointer.
1705 (Fccl_execute_on_string): Remove unnecessary check for
1706 integer overflow, noted by Stefan Monnier in
1707 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1708 Remove a FIXME that didn't need fixing.
1709 Simplify the newly-introduced buffer reallocation code.
1710
0cae2cdb
JB
17112011-08-27 Juanma Barranquero <lekktu@gmail.com>
1712
1713 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1714
5fc295a4 17152011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1716
70c60eb2 1717 Integer and memory overflow issues (Bug#9196).
726e0ab1 1718
d31850da
PE
1719 * doc.c (get_doc_string): Rework so that
1720 get_doc_string_buffer_size is the actual buffer size, rather than
1721 being 1 less than the actual buffer size; this makes xpalloc more
1722 convenient.
1723
a69fbedb
PE
1724 * image.c (x_allocate_bitmap_record, cache_image):
1725 * xselect.c (Fx_register_dnd_atom):
1726 Simplify previous changes by using xpalloc.
1727
fe5c5d37
PE
1728 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1729 since either will do and ptrdiff_t is convenient with xpalloc.
1730
0065d054
PE
1731 * charset.c (charset_table_size)
1732 (struct charset_sort_data.priority): Now ptrdiff_t.
1733 (charset_compare): Don't overflow if priorities differ greatly.
1734 (Fsort_charsets): Don't assume list length fits in int.
1735 Check for size-calculation overflow when allocating sort data.
1736 (syms_of_charset): Allocate an initial charset table that is
1737 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1738
1739 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1740
1741 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1742 The actual value is always <= INT_MAX, and leaving it unsigned made
1743 overflow checking harder.
1744
1745 * dispextern.h (struct glyph_matrix.rows_allocated)
1746 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1747 with xpalloc. The values are still always <= INT_MAX.
1748
1749 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1750
1751 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1752 (SAFE_NALLOCA): New macro.
1753
1754 * region-cache.c (struct boundary.pos, find_cache_boundary)
1755 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1756 (set_cache_region, invalidate_region_cache)
1757 (revalidate_region_cache, know_region_cache, region_cache_forward)
1758 (region_cache_backward, pp_cache):
1759 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1760 so that ptrdiff_t * can be passed to xpalloc.
1761 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1762 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1763 (pp_cache): Don't assume cache_len fits in int.
1764 * region-cache.h: Adjust extern decls to match.
1765
1766 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1767 EMACS_INT, since either will do, for xpalloc.
1768
1769 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1770 (xnmalloc, xnrealloc, xpalloc): New functions.
1771
726e0ab1
PE
1772 * bidi.c (bidi_shelve_header_size): New constant.
1773 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1774 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1775
51f30bc5 1776 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1777 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1778 (overlay_strings):
1779 Don't update size of array until after memory allocation succeeds,
1780 because xmalloc/xrealloc may not return.
0065d054
PE
1781 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1782 now that we have proper integer overflow checking.
1783 (record_overlay_string, overlay_strings): Catch overflows when
1784 calculating size of overlay_str_buf.
726e0ab1 1785
0065d054
PE
1786 * callproc.c (Fcall_process): Check for size overflow when
1787 calculating size of args2.
1788 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1789 Normally we prefer signed values, but sticking with ptrdiff_t would
1790 require adding more-complicated checks.
726e0ab1
PE
1791
1792 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1793 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1794 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1795 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1796
1797 * character.c (Fstring): Check for size-calculation overflow.
1798
1799 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1800 unnecessary integer overflow. Check for size overflow.
1801 (encode_coding_object): Don't update size until xmalloc succeeds.
1802
1803 * composite.c (get_composition_id): Check for overflow in glyph
1804 length calculations.
1805
1806 Integer and memory overflow fixes for display code.
1807 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1808 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1809 (scrolling_window): Check for overflow in size calculations.
1810 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1811 Don't assume glyph table len fits in int.
1812 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1813 (row_table_size): Now ptrdiff_t, not int.
1814 (scrolling_window): Avoid overflow in size calculations.
1815 Don't update size until allocation succeeds.
1816 * fns.c (concat): Check for overflow in size calculations.
1817 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1818 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1819 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1820
1821 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1822 (get_doc_string): Check for size calculation overflow.
1823 Don't update size until allocation succeeds.
1824 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1825 EMACS_INT, where ptrdiff_t will do.
1826 (Fsubstitute_command_keys): Check for string overflow.
1827
1828 * editfns.c (set_time_zone_rule): Don't assume environment length
1829 fits in int.
1830 (message_length): Now ptrdiff_t, not int.
1831 (Fmessage_box): Don't update size until allocation succeeds.
1832 Don't assume message length fits in int.
1833 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1834
0065d054
PE
1835 * emacs.c (main): Do not reallocate argv, since there is a null at
1836 the end that can be overwritten, and this way there's no need to
1837 worry about size-calculation overflow.
1838 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1839
1840 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1841 alloc succeeds.
1842 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1843
1844 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1845 (x_set_scroll_bar_width, x_figure_window_size):
1846 Check for integer overflow.
1847 (x_set_alpha): Do not assume XINT fits in int.
1848
1849 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1850 This is for the members text_lines, text_cols, total_lines, total_cols,
1851 where the system imposes an 'int' limit.
1852
1853 * fringe.c (Fdefine_fringe_bitmap):
1854 Don't update size until alloc works.
1855
1856 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1857 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1858
1859 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1860 Check for size-calculation overflow.
1861 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1862 do, as we prefer signed integers.
1863 (id_to_widget.max_size, id_to_widget.used)
1864 (xg_store_widget_in_map, xg_remove_widget_from_map)
1865 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1866 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1867 Use and return ptrdiff_t, not int.
1868 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1869 * gtkutil.h: Change prototypes to match the above.
1870
1871 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1872 are duplicate now that they've been promoted to lisp.h.
1873 (x_allocate_bitmap_record, x_alloc_image_color)
1874 (make_image_cache, cache_image, xpm_load):
1875 Don't update size until alloc is done.
1876 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1877 (x_detect_edges):
3256efce 1878 Check for size calculation overflow.
726e0ab1
PE
1879 (ct_colors_allocated_max): New constant.
1880 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1881 overflow.
3256efce 1882
726e0ab1
PE
1883 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1884 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1885 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1886 Use ptrdiff_t, not int, to count maps.
1887 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1888 calculations. Don't update size until allocation succeeds.
1889 Redo calculations to avoid overflow.
726e0ab1
PE
1890 * keyboard.h: Change prototypes to match the above.
1891
1892 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1893 to count maps.
1894 (current_minor_maps): Check for size calculation overflow.
1895 * keymap.h: Change prototypes to match the above.
1896
1897 * lread.c (read1, init_obarray): Don't update size until alloc done.
1898
1899 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1900 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1901
726e0ab1
PE
1902 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1903 Now ptrdiff_t, not int.
1904 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1905 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1906
1907 * process.c (Fnetwork_interface_list): Check for overflow
1908 in size calculation.
1909
1910 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1911
1912 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1913 overflow. Don't bother calling xmalloc when xrealloc will do.
1914
1915 * search.c (Freplace_match): Check for size calculation overflow.
1916 (Fset_match_data): Don't assume list lengths fit in 'int'.
1917
1918 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1919 for command line length. Do not attempt to address one before the
1920 beginning of an array, as that's not portable.
1921
1922 * term.c (max_frame_lines): Remove; unused.
1923 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1924 not int.
1925 (encode_terminal_code, calculate_costs): Check for size
1926 calculation overflow.
1927 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1928 table lengths and related sizes. Don't update size until alloc
1929 done. Redo calculations to avoid overflow.
1930 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1931
1932 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1933 subtracting pointers.
1934 (gobble_line): Check for overflow more carefully. Don't update size
1935 until alloc done.
1936
1937 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1938 Don't update size until alloc done.
1939 Redo size calculations to avoid overflow.
1940 Check for size calculation overflow.
0065d054 1941 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1942
1943 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1944 Use ptrdiff_t, not int, for sizes.
1945 (store_mode_line_noprop_char): Don't update size until alloc done.
1946
0065d054
PE
1947 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1948 Use ptrdiff_t, not int, for sizes.
1949 (Finternal_make_lisp_face, cache_face):
1950 Check for size calculation overflow.
1951 (cache_face): Treat size calculation overflows as if they were
1952 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1953
1954 * xfns.c (x_encode_text, x_set_name_internal)
1955 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1956 sizes, since they can exceed INT_MAX in size. Check for size
1957 calculation overflow.
1958
0065d054
PE
1959 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1960 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1961 Don't update size until alloc done.
1962
0065d054 1963 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1964 as sprintf is limited to int lengths.
1d526e2f 1965
252c5ee1
PE
1966 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1967 (X_LONG_MIN): New macros.
864d7ce7
PE
1968 Use them to make the following changes clearer.
1969 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1970 This change doesn't affect the value now, but it may help remind
1971 future maintainers not to raise the value too much later.
1972 (SELECTION_QUANTUM): Remove, replacing with ...
1973 (selection_quantum): ... new function, which avoids overflow.
1974 All uses changed.
1975 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1976 assumption that selection length fits in 'int'.
1977 (x_reply_selection_request, x_handle_selection_request)
1978 (x_get_window_property, receive_incremental_selection)
1979 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1980 (lisp_data_to_selection_data, clean_local_selection_data):
1981 Use ptrdiff_t, not int, to record length of selection.
1982 (x_reply_selection_request, x_get_window_property)
1983 (receive_incremental_selection, x_property_data_to_lisp):
1984 Redo calculations to avoid overflow.
1985 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1986 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1987 something.
1988 (x_get_window_property, receive_incremental_selection)
1989 (lisp_data_to_selection_data, x_property_data_to_lisp):
1990 Check for size-calculation overflow.
1991 (x_get_window_property, receive_incremental_selection)
1992 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1993 Don't store size until memory allocation succeeds.
1994 (x_get_window_property): Plug memory leak on memory exhaustion.
1995 Don't double-block input; malloc is safe here. Don't assume 2**34
1996 - 4 fits in unsigned long. Add an xassert to check
1997 XGetWindowProperty overflow. Be more careful about overflow
1998 calculations, and distinguish size from memory overflow better.
1999 (receive_incremental_selection): When tracing, don't assume
2000 unsigned int is less than INT_MAX.
2001 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2002 harmful) conversions of unsigned short to int.
2003 (lisp_data_to_selection_data): Don't assume that integers
2004 in the range -65535 through -1 fit in an X unsigned short.
2005 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2006 result parameters unless successful. Rely on cons_to_unsigned
2007 to report problems with elements; the old code wasn't right anyway.
2008 (x_check_property_data): Check for int overflow; we cannot use
2009 a wider type due to X limits.
2010 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2011
726e0ab1 2012 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2013
0065d054
PE
2014 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2015 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2016 (x_color_cells): Don't store size until memory allocation succeeds.
2017 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2018 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2019 (x_term_init): Don't assume length fits in int (sprintf is limited
2020 to int size).
bc18e09d 2021
ebfa62c0
PE
2022 Use ptrdiff_t for composition IDs.
2023 * character.c (lisp_string_width):
2024 * composite.c (composition_table_size, n_compositions)
2025 (get_composition_id, composition_gstring_from_id):
2026 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2027 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2028 * window.c (Frecenter):
2029 Use ptrdiff_t, not int, for composition IDs.
2030 * composite.c (get_composition_id): Check for integer overflow.
2031 * composite.h: Adjust prototypes to match the above changes.
2032
d3411f89
PE
2033 Use ptrdiff_t for hash table indexes.
2034 * category.c (hash_get_category_set):
2035 * ccl.c (ccl_driver):
2036 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2037 * coding.c (coding_system_charset_list, detect_coding_system):
2038 * coding.h (struct coding_system.id):
2039 * composite.c (get_composition_id, gstring_lookup_cache):
2040 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2041 * image.c (xpm_get_color_table_h):
2042 * lisp.h (hash_lookup, hash_put):
2043 * minibuf.c (Ftest_completion):
2044 Use ptrdiff_t for hash table indexes, not int (which is too
2045 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2046 32-bit --with-wide-int hosts).
2047
e097a6fa
PE
2048 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2049 Add a FIXME comment about memory leaks.
2050 (syms_of_charset): Don't assume xmalloc returns.
2051
5637687f
PE
2052 Don't assume that stated character widths fit in int.
2053 * character.c (Fchar_width, c_string_width, lisp_string_width):
2054 * character.h (CHAR_WIDTH):
2055 * indent.c (MULTIBYTE_BYTES_WIDTH):
2056 Use sanitize_char_width to avoid undefined and/or bad behavior
2057 with outlandish widths.
a66cfb1c 2058 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2059 now that we have two such functions. All uses changed.
2060 (sanitize_char_width): New inline function.
2061
a2271ba2
PE
2062 Don't assume that tab-width fits in int.
2063 * character.h (sanitize_width): New inline function.
2064 (SANE_TAB_WIDTH): New macro.
2065 (ASCII_CHAR_WIDTH): Use it.
2066 * indent.c (sane_tab_width): Remove. All uses replaced by
2067 SANE_TAB_WIDTH (current_buffer).
2068 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2069
18c52557
PE
2070 * fileio.c: Integer overflow issues with file modes.
2071 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2072
caeeedc1
PE
2073 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2074 Remove unreachable code.
2075 (read_hex, load_charset_map_from_file): Check for integer overflow.
2076
50849c52
PE
2077 * xterm.c: don't go over XClientMessageEvent limit
2078 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2079 (x_send_scroll_bar_event): Likewise. Check that the size does not
2080 exceed limits imposed by XClientMessageEvent, as well as the usual
2081 ptrdiff_t and size_t limits.
2082
b13995db
PE
2083 * keyboard.c: Overflow, signedness and related fixes.
2084 (make_lispy_movement): Use same integer type in forward decl
2085 that is used in the definition.
2086 (read_key_sequence, keyremap_step):
2087 Change bufsize argument back to int, undoing my 2011-03-30 change.
2088 We prefer signed types, and int is wide enough here.
2089 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2090 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2091 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2092 length, not size_t. Use ptrdiff_t for index, not int.
2093 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2094 possibility of integer overflow.
2095
13464394
PE
2096 Overflow, signedness and related fixes for images.
2097
2098 * dispextern.h (struct it.stack[0].u.image.image_id)
2099 (struct_it.image_id, struct image.id, struct image_cache.size)
2100 (struct image_cache.used, struct image_cache.ref_count):
2101 * gtkutil.c (update_frame_tool_bar):
2102 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2103 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2104 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2105 * nsmenu.m (update_frame_tool_bar):
2106 * xdisp.c (calc_pixel_width_or_height):
2107 * xfns.c (image_cache_refcount):
2108 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2109 on typical 64-bit hosts.
2110
2111 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2112 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2113 Omit unnecessary casts to int.
2114 (parse_image_spec): Check that integers fall into 'int' range
2115 when the callers expect that.
2116 (image_ascent): Redo ascent calculation to avoid int overflow.
2117 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2118 (lookup_image): Remove unnecessary tests.
2119 (xbm_image_p): Locals are now of int, not EMACS_INT,
2120 since parse_image_check makes sure they fit into int.
2121 (png_load, gif_load, svg_load_image):
2122 Prefer int to unsigned where either will do.
2123 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2124 old tiff_error_handler and tiff_warning_handler.
2125 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2126 stack buffer overflows. It uses only the features of vsnprintf
2127 that are common to both POSIX and native Microsoft.
2128 (tiff_error_handler, tiff_warning_handler): Use it.
2129 (tiff_load, gif_load, imagemagick_load_image):
2130 Don't assume :index value fits in 'int'.
2131 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2132 (imagemagick_load_image): Check that crop parameters fit into
2133 the integer types that MagickCropImage accepts. Don't assume
2134 Vimagemagick_render_type has a nonnegative value. Don't assume
2135 size_t fits in 'long'.
2136 (gs_load): Use printmax_t to print the widest integers possible.
2137 Check for integer overflow when computing image height and width.
2138
c11821d4
EZ
21392011-08-26 Eli Zaretskii <eliz@gnu.org>
2140
2141 * xdisp.c (redisplay_window): Don't force window start if point
2142 will be invisible in the resulting window. (Bug#9324)
2143
0c95fcf7
EZ
21442011-08-25 Eli Zaretskii <eliz@gnu.org>
2145
2146 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2147 the display spec is of the form `(space ...)'.
2148 (handle_display_spec): Return the value returned by
2149 handle_single_display_spec, not just 1 or zero.
2150 (handle_single_display_spec): If the display spec is of the form
2151 `(space ...)', and specifies display in the text area, return 2
2152 rather than 1.
fee65a97 2153 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2154 accurately, and prefer exact match for point under bidi.
2155 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2156
2157 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2158 into disp_prop; all users changed.
2159
2160 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2161 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2162 for the text covered by the display property.
2163
e4ed06f1
CY
21642011-08-25 Chong Yidong <cyd@stupidchicken.com>
2165
2166 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2167 Change return value to nil.
2168 (Frecord_buffer): Delete unused function.
2169
f67cdd7f
EZ
21702011-08-24 Eli Zaretskii <eliz@gnu.org>
2171
5980d4c6
EZ
2172 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2173 buffers, return left-to-right.
8610fe8b
EZ
2174 (set_cursor_from_row): Consider candidate row a win if its glyph
2175 represents a newline and point is on that newline. Fixes cursor
2176 positioning on the newline at EOL of R2L text within L2R
2177 paragraph, and vice versa.
2178 (try_cursor_movement): Check continued rows, in addition to
2179 continuation rows. Fixes unwarranted scroll when point enters a
2180 continued line of R2L text within an L2R paragraph, or vice versa.
2181 (cursor_row_p): Consider the case of point being equal to
2182 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2183 from the end of a short line to the beginning of a continued line
2184 of R2L text within L2R paragraph.
2185 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2186 composed characters.
5980d4c6 2187
f67cdd7f
EZ
2188 * bidi.c (bidi_check_type): Use xassert.
2189 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2190 members.
2191
bca633fb
EZ
21922011-08-23 Eli Zaretskii <eliz@gnu.org>
2193
2194 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2195 a character.
2196
4a5885a7
CY
21972011-08-23 Chong Yidong <cyd@stupidchicken.com>
2198
2199 * nsfont.m (ns_otf_to_script): Fix typo.
2200
0902a04e
KH
22012011-08-22 Kenichi Handa <handa@m17n.org>
2202
2203 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2204 extra slot even if the purpose is char-code-property-table.
2205
1a2e6670
EZ
22062011-08-23 Eli Zaretskii <eliz@gnu.org>
2207
8ddde651
EZ
2208 * xdisp.c (redisplay_window): When computing centering_position,
2209 account for the height of the header line. (Bug#8874)
2210
425cc014
EZ
2211 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2212 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2213 candidate is selected by the mouse, and that candidate has a
2214 composed character under the mouse.
2215
1a2e6670
EZ
2216 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2217 coordinates reported by pos-visible-in-window-p for a composed
2218 character in column zero.
2219
8b76d6f8
SM
22202011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2221
2222 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2223
dac347dd
EZ
22242011-08-22 Eli Zaretskii <eliz@gnu.org>
2225
2226 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2227 consider it a hit if to_charpos is anywhere in the range of the
2228 composed buffer positions.
2229
e013fb34
CY
22302011-08-22 Chong Yidong <cyd@stupidchicken.com>
2231
2232 * image.c (gif_load): Don't assume that each subimage has the same
2233 dimensions as the base image. Handle disposal method that is
2234 "undefined" by the gif spec (Bug#9335).
2235
bd1ba3e8
CY
22362011-08-20 Chong Yidong <cyd@stupidchicken.com>
2237
2238 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2239 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2240
54a1215b
EZ
22412011-08-19 Eli Zaretskii <eliz@gnu.org>
2242
823564e5
EZ
2243 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2244 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2245 from an Org mode buffer to a Speedbar frame.
2246
54a1215b
EZ
2247 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2248 a composition, take its buffer position from IT->cmp_it.charpos.
2249 Fixes cursor positioning at the beginning of a line that begins
2250 with a composed character.
2251
9778ebcc
EZ
22522011-08-18 Eli Zaretskii <eliz@gnu.org>
2253
0be6ee06
EZ
2254 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2255 character bidirectional type, use STRONG_L instead. Fixes crashes
2256 in a buffer produced by `describe-categories'.
2257
9778ebcc
EZ
2258 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2259 members before the level stack, so they would be saved and
2260 restored when copying iterator state. Fixes incorrect reordering
2261 around TABs covered by display properties.
2262
156bffbe
AS
22632011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2264
6b02f655 2265 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2266
72ad093b
CY
22672011-08-17 Chong Yidong <cyd@stupidchicken.com>
2268
2269 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2270 (internal_condition_case_2, internal_condition_case_n):
2271 Remove unnecessary aborts (Bug#9081).
72ad093b 2272
35774242
EZ
22732011-08-17 Eli Zaretskii <eliz@gnu.org>
2274
2275 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2276 has no `load' handler, try opening the file locally. (Bug#9311)
2277
db76dd85
KB
22782011-08-16 Ken Brown <kbrown@cornell.edu>
2279
2280 * gmalloc.c: Expand comment.
2281
b215eee5
EZ
22822011-08-16 Eli Zaretskii <eliz@gnu.org>
2283
2284 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2285 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2286
a4579d33
KB
22872011-08-16 Ken Brown <kbrown@cornell.edu>
2288
2289 Fix memory allocation problems in Cygwin build (Bug#9273).
2290
2291 * unexcw.c ( __malloc_initialized): Declare external variable.
2292 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2293
8b76d6f8
SM
2294 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2295 New variables.
a4579d33
KB
2296 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2297 dumped emacs.
2298 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2299 in the static heap.
2300 [CYGWIN] (special_realloc): New function.
2301 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2302 requests to realloc storage in the static heap.
2303
3ebec551
PE
23042011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2305
2306 * bidi.c (bidi_initialize): Remove unused local.
2307
9fd8be00
EZ
23082011-08-15 Eli Zaretskii <eliz@gnu.org>
2309
6b02f655
SM
2310 * bidimirror.h:
2311 * biditype.h: Remove file.
2312 * makefile.w32-in ($(BLD)/bidi.$(O)):
2313 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2314
2315 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2316
2317 * chartab.c: Improve commentary for the uniprop_table API.
2318
32413314
EZ
2319 * bidi.c (bidi_paragraph_init): Support zero value of
2320 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2321 (bidi_initialize): Use uniprop_table instead of including
2322 biditype.h and bidimirror.h.
32413314 2323
9fd8be00
EZ
2324 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2325 coordinates of the iterator when restoring from ppos_it.
2326 (Bug#9296)
2327
5cf2b69b
KH
23282011-08-14 Kenichi Handa <handa@m17n.org>
2329
2330 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2331 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2332
daf17d00
EZ
23332011-08-14 Eli Zaretskii <eliz@gnu.org>
2334
2335 * xdisp.c (move_it_in_display_line_to): Don't invoke
2336 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2337 ppos_it. Fixes vertical cursor motion when line beginning is
2338 covered by an image. (Bug#9296)
2339
08e3161a
JD
23402011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2341
2342 * nsterm.h (ns_run_ascript): Declare.
2343 (NSAPP_DATA2_RUNASSCRIPT): Define.
2344
2345 * nsfns.m (as_script, as_result, as_status): New static variables.
2346 (ns_run_ascript): New function.
5e617bc2 2347 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2348 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2349 the event loop. Get status from as_status (Bug#7276).
2350
2351 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2352 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2353 the event loop (Bug#7276).
2354
a3720aa2
AS
23552011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2356
2357 * gnutls.c (QCgnutls_bootprop_priority)
2358 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2359 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2360 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2361 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2362 (QCgnutls_bootprop_verify_hostname_error)
2363 (QCgnutls_bootprop_callbacks_verify): Rename from
2364 Qgnutls_bootprop_..., all uses changed.
2365
2366 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2367 uses changed.
2368
0a0d27fb
PE
23692011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2370
19d5c50c
PE
2371 * xfaces.c (Qframe_set_background_mode): Now static.
2372 * dispextern.h (Qframe_set_background_mode): Remove decl.
2373
0a0d27fb
PE
2374 * process.c (Fnetwork_interface_info): Declare local only if needed.
2375
377538cb
JD
23762011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2377
2378 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2379 (Fnetwork_interface_list): Allocate in increments of bytes instead
2380 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2381 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2382 sockaddr.
2383 (struct ifflag_def): notrailers is smart on OSX.
2384 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2385 Get hardware address with getifaddrs if available.
2386
08fff70c
EZ
23872011-08-12 Eli Zaretskii <eliz@gnu.org>
2388
2389 * xdisp.c (iterate_out_of_display_property): xassert that
2390 IT->position is set to within IT->object's boundaries. Break from
2391 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2392 when IT->position is set up wrongly due to some bug.
2393 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2394 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2395 entry. Force push_it to save on the stack the current
2396 buffer/string position, to be restored by pop_it. Fix flags in
2397 the iterator structure wrt the object coming from a display
2398 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2399 properties. (Bug#9284)
2400
7be1c708 24012011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2402
7be1c708
CY
2403 * fontset.c (fontset_get_font_group): Add proper type checks.
2404 (Bug#9172)
aac0c6e3 2405
7be1c708 24062011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2407
7be1c708
CY
2408 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2409 and LC_VERSION_MIN_MACOSX.
2410 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2411 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2412
97bb72a6
EZ
24132011-08-08 Eli Zaretskii <eliz@gnu.org>
2414
2415 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2416 no-display-properties-and-no-overlays under bidi display.
2417 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2418 properties and overlays.
97bb72a6 2419
d5617611
CY
24202011-08-08 Chong Yidong <cyd@stupidchicken.com>
2421
37e11a63
CY
2422 * editfns.c (Fset_time_zone_rule): Document relationship with the
2423 setenv function.
2424
d5617611
CY
2425 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2426 the font entity extracted from the cache (Bug#8109).
2427
58872834
CY
24282011-08-07 Chong Yidong <cyd@stupidchicken.com>
2429
2430 * composite.c (autocmp_chars): Don't reset point. That is done by
2431 restore_point_unwind (Bug#5984).
2432
75bfc667
JL
24332011-08-07 Juri Linkov <juri@jurta.org>
2434
2435 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2436 to show the arg `TIME' instead of `TIMEVAL'.
2437
d1410150
EZ
24382011-08-06 Eli Zaretskii <eliz@gnu.org>
2439
2440 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2441 display property strides EOL and includes a newline, as in
2442 longlines-mode. (Bug#9254)
75b771e4
EZ
2443 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2444 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2445
2446 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2447 is non-zero, even if the data buffer is NULL. Fixes a crash in
2448 vertical-motion with longlines-mode. (Bug#9254)
2449
35928349
EZ
24502011-08-05 Eli Zaretskii <eliz@gnu.org>
2451
ec7cc85b
EZ
2452 * bidi.c <bidi_cache_total_alloc>: Now static.
2453 (bidi_initialize): Initialize bidi_cache_total_alloc.
2454
8b76d6f8 2455 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2456 cache. (Bug#9221)
2457
2458 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2459 amount allocated this far in `bidi_cache_total_alloc'.
2460 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2461 non-zero, only free the data buffer without restoring the cache
2462 contents. All callers changed.
2463
2464 * dispextern.h (bidi_unshelve_cache): Update prototype.
2465
2466 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2467 (move_it_in_display_line, move_it_to)
2468 (move_it_vertically_backward, move_it_by_lines): Replace the call
2469 to xfree to an equivalent call to bidi_unshelve_cache.
2470 (move_it_in_display_line_to): Fix logic of returning
412b6358 2471 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2472
e2e2423b
EZ
24732011-08-05 Eli Zaretskii <eliz@gnu.org>
2474
2475 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2476 came from a string character with a `cursor' property. (Bug#9229)
2477
ae9e757a
JD
24782011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2479
2480 * Makefile.in (LIB_PTHREAD): New variable.
2481 (LIBES): Add LIB_PTHREAD (Bug#9216).
2482
2483 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2484 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2485
213bd7f2
AS
24862011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2487
6b02f655 2488 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2489
99aaf75f
JD
24902011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2491
2492 * xterm.c (x_find_topmost_parent): New function.
2493 (x_set_frame_alpha): Find topmost parent window with
2494 x_find_topmost_parent and set the property there also (bug#9181).
2495 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2496
c74e9d86
PE
24972011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2498
2499 * callproc.c (Fcall_process): Avoid vfork clobbering
2500 the local vars buffer, coding_systems, current_dir.
2501
640c8776
SM
25022011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2503
2504 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2505
f26d0e4c
PE
25062011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2507
8a10d76c
PE
2508 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2509 so that it is not optimized away.
2510
f26d0e4c
PE
2511 * xdisp.c (compute_display_string_pos): Remove unused local.
2512
55439c61
EZ
25132011-08-02 Eli Zaretskii <eliz@gnu.org>
2514
2515 Fix slow cursor motion and scrolling in large buffers with
2516 selective display, like Org Mode buffers. (Bug#9218)
2517
2518 * dispextern.h (struct bidi_it): New member disp_prop_p.
2519
2520 * xdisp.c: Remove one-slot cache of display string positions.
2521 (compute_display_string_pos): Accept an additional argument
5e617bc2 2522 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2523 for a display string or property. If found, set DISP_PROP_P
2524 non-zero.
2525
2526 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2527 DISP_PROP_P, and pass it to compute_display_string_pos.
2528 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2529 non-zero. All callers of bidi_fetch_char changed.
2530
fb33fa43
SM
25312011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2532
2533 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2534
b099e063
DM
25352010-12-03 Don March <don@ohspite.net>
2536
2537 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2538 last character M-[char] is translated to ESC [char] (bug#7541).
2539
5cc7f7af
KH
25402011-08-02 Kenichi Handa <handa@m17n.org>
2541
d0fffa3f 2542 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2543
2544 * chartab.c (uniprop_table): Make it non-static.
2545
525d5e6e
EZ
25462011-08-01 Eli Zaretskii <eliz@gnu.org>
2547
2548 * xdisp.c (forward_to_next_line_start): Accept additional argument
2549 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2550 on the newline.
2551 (reseat_at_next_visible_line_start): Use the bidi iterator state
2552 returned by forward_to_next_line_start to restore the state of
2553 it->bidi_it after backing up to previous newline. (Bug#9212)
2554
31011111
AS
25552011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2556
2557 * regex.c (re_comp): Protoize.
2558 (re_exec): Fix return type.
2559 (regexec): Fix type of `ret'. (Bug#9203)
2560
476371c4
PE
25612011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2562
e5d76069
PE
2563 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2564 This is needed if max-image-size is a floating-point number.
2565
9a79b20c
AS
25662011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2567
2568 * print.c (print_object): Print empty symbol as ##.
2569
2570 * lread.c (read1): Read ## as empty symbol.
2571
d8c2fa78
AA
25722011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2573
2574 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2575 setting frame foreground color (Bug#9175).
2576 (x_set_background_color): Likewise.
2577
ffe57a7a
AA
2578 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2579 contents (Bug#9176).
2580 (EmacsTooltip -init): Remove bezels and add shadows to
2581 tooltip windows.
2582
bf3492a5
AA
2583 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2584 or scroll bar (Bug#8470).
2585
d55e9c53
AA
2586 * nsfont.m (nsfont_open): Remove assignment to voffset and
2587 unnecessary vars hshink, expand, hd, full_height, min_height.
2588 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2589
2590 * nsterm.h (nsfont_info): Remove voffset field.
2591
d8c2fa78 25922011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2593
2594 Implement strike-through and overline on NextStep (Bug#8863).
2595
2596 * nsfont.m (nsfont_open): Use underline position provided by font,
2597 instead of hard-coded value of 2.
2598 (nsfont_draw): Call ns_draw_text_decoration instead.
2599
2600 * nsterm.h: Add declaration for ns_draw_text_decoration.
2601
2602 * nsterm.m (ns_draw_text_decoration): New function for drawing
2603 underline, overline, and strike-through.
2604 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2605 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2606 accommodate underlining, etc.
4843aac3 2607
4cc60b9b
EZ
26082011-07-28 Eli Zaretskii <eliz@gnu.org>
2609
bc7ece87
EZ
2610 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2611 default.
4cc60b9b 2612
476371c4
PE
26132011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2614
66606eea
PE
2615 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2616 Without this fix, if a signal arrives just after memory fills up,
2617 'malloc' might be invoked reentrantly.
2618
476371c4
PE
2619 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2620 In other words, assume that every image size is allowed, on non-X
2621 hosts. This assumption is probably wrong, but it lets Emacs compile.
2622
f3fcc40d
AS
26232011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2624
2625 * regex.c (re_iswctype): Convert return values to boolean.
2626
350c992f
EZ
26272011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2628
2629 * xdisp.c (compute_display_string_pos): Don't use cached display
2630 string position if the buffer had its restriction changed.
2631 (Bug#9184)
2632
5266b4bb
PE
26332011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2634
2635 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2636
2573a837 26372011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2638
41f55ccd 2639 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2640
39e378da
PE
2641 * bidi.c: Integer size and overflow fixes.
2642 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2643 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2644 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2645 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2646 (bidi_find_other_level_edge):
2647 Use ptrdiff_t instead of EMACS_INT where either will do.
2648 This works better on 32-bit hosts configured --with-wide-int.
2649 (bidi_cache_ensure_space): Check for size-calculation overflow.
2650 Use % rather than repeated addition, for better worst-case speed.
2651 Don't set bidi_cache_size until after xrealloc returns, because it
2652 might not return.
2653 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2654 (bidi_cache_ensure_space): Also check that the bidi cache size
2655 does not exceed that of the largest Lisp string or buffer. See Eli
2656 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2657
5e927815
PE
2658 * alloc.c (__malloc_size_t): Remove.
2659 All uses replaced by size_t. See Andreas Schwab's note
2660 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2661
ca4aa935
PE
2662 * image.c: Improve checking for integer overflow.
2663 (check_image_size): Assume that f is nonnull, since
2664 it is always nonnull in practice. This is one less thing to
2665 worry about when checking for integer overflow later.
2666 (x_check_image_size): New function, which checks for integer
2667 overflow issues inside X.
2668 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2669 This removes the need for a memory_full check.
2670 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2671 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2672 (xbm_read_bitmap_data): Change locals back to 'int', since
2673 their values must fit in 'int'.
2674 (xpm_load_image, png_load, tiff_load):
2675 Invoke x_create_x_image_and_pixmap earlier,
2676 to avoid much needless work if the image is too large.
2677 (tiff_load): Treat overly large images as if
2678 x_create_x_image_and_pixmap failed, not as malloc failures.
2679 (gs_load): Use x_check_image_size.
2680
5f8f9cc2
PE
2681 * gtkutil.c: Omit integer casts.
2682 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2683 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2684
5adf60bc
PE
2685 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2686
c8907a93
PE
2687 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2688 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2689 would wrongly return t on a 64-bit host.
2690
e3c25c68
PE
2691 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2692 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2693 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2694 and therefore cause GCC to emit a bogus diagnostic in some cases.
2695
3f791afe
PE
2696 * image.c: Integer signedness and overflow and related fixes.
2697 This is not an exhaustive set of fixes, but it's time to
2698 record what I've got.
2699 (lookup_pixel_color, check_image_size): Remove redundant decls.
2700 (check_image_size): Don't assume that arbitrary EMACS_INT values
2701 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2702 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2703 (tiff_load, imagemagick_load_image):
2704 Check for overflow in size calculations.
2705 (x_create_x_image_and_pixmap): Remove unnecessary test for
2706 xmalloc returning NULL; that can't happen.
2707 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2708 (xpm_color_bucket): Use better integer hashing function.
2709 (xpm_cache_color): Don't possibly over-allocate memory.
2710 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2711 (gif_memory_source):
2712 Use ptrdiff_t, not int or size_t, to record sizes.
2713 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2714 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2715 either works, as we prefer signed integers.
2716 (tiff_read_from_memory, tiff_write_from_memory):
2717 Return tsize_t, not size_t, since that's what the TIFF API wants.
2718 (tiff_read_from_memory): Don't fail simply because the read would
2719 go past EOF; instead, return a short read.
2720 (tiff_load): Omit no-longer-needed casts.
2721 (Fimagemagick_types): Don't assume size fits into 'int'.
2722
3cc5a532
PE
2723 Improve hashing quality when configured --with-wide-int.
2724 * fns.c (hash_string): New function, taken from sxhash_string.
2725 Do not discard information about ASCII character case; this
2726 discarding is no longer needed.
2727 (sxhash-string): Use it. Change sig to match it. Caller changed.
2728 * lisp.h: Declare it.
2729 * lread.c (hash_string): Remove, since we now use fns.c's version.
2730 The fns.c version returns a wider integer if --with-wide-int is
2731 specified, so this should help the quality of the hashing a bit.
2732
b312a492
PE
2733 * emacs.c: Integer overflow minor fix.
2734 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2735 Define only if GNU_LINUX.
2736 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2737
dfd153ae
PE
2738 * dispnew.c: Integer signedness and overflow fixes.
2739 Remove unnecessary forward decls, that were a maintenance hassle.
2740 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2741 All uses changed.
2742 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2743 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2744 (prepare_desired_row, line_draw_cost):
2745 Use int, not unsigned, where either works.
2746 (save_current_matrix, restore_current_matrix):
2747 Use ptrdiff_t, not size_t, where either works.
2748 (init_display): Check for overflow more accurately, and without
2749 relying on undefined behavior.
2750
a81d11a3
PE
2751 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2752 Remove, replacing with the new symbols in lisp.h. All uses changed.
2753 * fileio.c (make_temp_name):
2754 * filelock.c (lock_file_1, lock_file):
2755 * xdisp.c (message_dolog):
2756 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2757 Use pMd etc. instead.
2758 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2759 replacing the pWIDE etc. symbols removed from editfns.c.
2760
3300e6fd
PE
2761 * keyboard.h (num_input_events): Now uintmax_t.
2762 This is (very slightly) less likely to mess up due to wraparound.
2763 All uses changed.
2764
fd05c7e9
PE
2765 * buffer.c: Integer signedness fixes.
2766 (alloc_buffer_text, enlarge_buffer_text):
2767 Use ptrdiff_t rather than size_t when either will do, as we prefer
2768 signed integers.
2769
903fe15d
PE
2770 * alloc.c: Integer signedness and overflow fixes.
2771 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2772 (__malloc_size_t): Default to size_t, not to int.
2773 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2774 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2775 Prefer ptrdiff_t to size_t when either would do, as we prefer
2776 signed integers.
2777 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2778 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2779 Now const. Initialize with values that are in range even if char
2780 is signed.
2781 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2782 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2783 These functions do the right thing with sizes > 2**32.
2784 (check_depth): Now ptrdiff_t, not int.
2785 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2786 Adjust to new way of storing sizes. Check for size overflow bugs
2787 in rest of code.
2788 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2789 slightly wrong anyway, as it missed one instance of
2790 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2791 (refill_memory_reserve): Omit needless cast to size_t.
2792 (mark_object_loop_halt): Mark as externally visible.
2793
ac82cc6a
PE
2794 * xselect.c: Integer signedness and overflow fixes.
2795 (Fx_register_dnd_atom, x_handle_dnd_message):
2796 Use ptrdiff_t, not size_t, since we prefer signed.
2797 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2798 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2799 x_dnd_atoms_size and x_dnd_atoms_length.
2800
c2d1e36d
PE
2801 * doprnt.c: Prefer signed to unsigned when either works.
2802 * eval.c (verror):
2803 * doprnt.c (doprnt):
2804 * lisp.h (doprnt):
2805 * xdisp.c (vmessage):
2806 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2807 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2808 prefer signed arithmetic to avoid comparison confusion.
2809 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2810 but is a bit tricky.
2811
0e926e56
PE
2812 Assume freestanding C89 headers, string.h, stdlib.h.
2813 * data.c, doprnt.c, floatfns.c, print.c:
2814 Include float.h unconditionally.
2815 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2816 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2817 * regex.c: Likewise for stddef.h, string.h.
2818 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2819 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2820 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2821 (STDC_HEADERS): Remove obsolete defines.
2822 * sysdep.c: Include limits.h unconditionally.
2823
9cfdb3ec
PE
2824 Assume support for memcmp, memcpy, memmove, memset.
2825 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2826 * regex.c (memcmp, memcpy):
2827 Remove; we assume C89 now.
2828
2829 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2830 (__malloc_safe_bcopy): Remove; no longer needed.
2831
cf950e6b 2832 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2833 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2834 well either way, and we prefer signed to unsigned.
2835
dbf38e02
LMI
28362011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2837
2838 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2839 closes the connection while we're reading (bug#9182).
2840
d6f0886c 28412011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2842
d6f0886c
JD
2843 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2844 are specified (Bug#9168).
24e0f6b1 2845
2eb1f9e6
PE
28462011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2849 Found by GCC static checking and --with-wide-int on a 32-bit host.
2850
22381272 28512011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2852
2853 * xdisp.c (compute_display_string_pos): Fix logic of caching
2854 previous display string position. Initialize cached_prev_pos to
2855 -1. Fixes slow-down at the beginning of a buffer.
2856
f25e39b4
EZ
28572011-07-24 Eli Zaretskii <eliz@gnu.org>
2858
2859 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2860 for attrs[LFACE_FONTSET_INDEX].
2861
04c4b52e
PE
28622011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2863
2864 * xml.c (parse_region): Remove unused local
2865 that was recently introduced.
2866
c1734fbd
EZ
28672011-07-23 Eli Zaretskii <eliz@gnu.org>
2868
be18c5a5
EZ
2869 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2870 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2871
c1734fbd
EZ
2872 * xdisp.c (move_it_in_display_line_to): Record the best matching
2873 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2874 exit if none of the characters scanned was an exact match.
2875 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2876 when exact match is impossible due to invisible text, and the
2877 lines are truncated.
2878
a258d627
JD
28792011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2880
2881 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2882 for OSX >= 10.7.
2883
b6d5a689
EZ
28842011-07-22 Eli Zaretskii <eliz@gnu.org>
2885
0f74f785
EZ
2886 Fix a significant slow-down of cursor motion with C-n, C-p,
2887 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2888 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2889 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2890 (next_element_from_buffer): Call compute_stop_pos_backwards to
2891 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2892 base_level_stop.
2893 (reseat): Don't look for prev_stop, as that could mean a very long
2894 run.
2895 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2896 <cached_disp_overlay_modiff>: Cache for last found display string
2897 position.
551918c1 2898 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2899 about the same buffer in the same area of character positions, and
2900 the buffer wasn't changed since the time the display string
2901 position was cached.
551918c1 2902
b2d0c91a
EZ
29032011-07-22 Eli Zaretskii <eliz@gnu.org>
2904
2905 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2906 is an integer, which is important for empty lines. (Bug#9149)
2907
043604ee
CY
29082011-07-22 Chong Yidong <cyd@stupidchicken.com>
2909
2910 * frame.c (Fmodify_frame_parameters): In tty case, update the
2911 default face if necessary (Bug#4238).
2912
da4adb04
CY
29132011-07-21 Chong Yidong <cyd@stupidchicken.com>
2914
2915 * editfns.c (Fstring_to_char): No need to explain what a character
2916 is in the docstring (Bug#6576).
2917
9abd0532
LMI
29182011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2919
2920 * xml.c (parse_region): Make sure we always return a tree.
2921
36881d16
HK
29222011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2923
2924 * xml.c (parse_region): If a document contains only comments,
2925 return that, too.
2926
1e98674d
LMI
29272011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2928
2929 * xml.c (make_dom): Return comments, too.
2930
590bd467
PE
29312011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2932
2933 Port to OpenBSD.
2934 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2935 and the surrounding thread.
2936 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2937 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2938 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2939 timer goes off.
2940 * s/openbsd.h (BROKEN_SIGIO): Define.
2941 * unexelf.c (unexec) [__OpenBSD__]:
2942 Don't update the .mdebug section of the Alpha COFF symbol table.
2943
f41628b2
LMI
29442011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2945
2946 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2947 (bug#8460).
2948
b59b67c5
PE
29492011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2950
15e3a074
PE
2951 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2952 This fixes some race conditions on the permissions of any newly
2953 created file.
2954
41bed37d
PE
2955 * alloc.c (valid_pointer_p): Use pipe, not open.
2956 This fixes some permissions issues when debugging.
2957
b59b67c5
PE
2958 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2959 If fchown fails to set both uid and gid, try to set just gid,
2960 as that is sometimes allowed. Adjust the file's mode to eliminate
2961 setuid or setgid bits that are inappropriate if fchown fails.
2962
925a6be7
SM
29632011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2964
2965 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2966 to compare Lisp_Objects.
2967 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2968 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2969 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2970
52968808
AS
29712011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2972
0a6a104b
AS
2973 * lread.c (read_integer): Unread even EOF character.
2974 (read1): Likewise. Properly record start position of symbol.
2975
52968808
AS
2976 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2977 symbol character follows.
2978
9e381cdd
PE
29792011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2980
2981 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2982 This works around a problem with the previous change to Fcopy_file.
2983 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2984 and without this change, GCC might complain about discarding
2985 fchown's return value.
2986
b5641435
JB
29872011-07-16 Juanma Barranquero <lekktu@gmail.com>
2988
2989 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2990
a8031457
PE
29912011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2992
2993 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2994
dd889327
LMI
29952011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2996
750c33f7
LMI
2997 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2998 it's used from the C level.
2999
dd889327
LMI
3000 * process.c: Use the same condition for POLL_FOR_INPUT in both
3001 keyboard.c and process.c (bug#1858).
3002
87e86684
LM
30032011-07-09 Lawrence Mitchell <wence@gmx.li>
3004
3005 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3006 (Fgnutls_boot): Use it.
3007
64348f40
AS
30082011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3009
3010 * doc.c (Fsubstitute_command_keys): Revert last change.
3011
1d698799
LMI
30122011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3013
f863868c
LMI
3014 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3015 quotes the next character, and doesn't affect other longer
3016 sequences (bug#8935).
3017
1d698799
LMI
3018 * lread.c (syms_of_lread): Clarify that is isn't only
3019 `eval-buffer' and `eval-defun' that's affected by
3020 `lexical-binding' (bug#8460).
3021
aa4b6df6
EZ
30222011-07-15 Eli Zaretskii <eliz@gnu.org>
3023
3024 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3025 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3026
5d856da6
PE
30272011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3028
ad6042bb
PE
3029 Fix minor problems found by static checking.
3030 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3031 (elsz): Now a signed constant, not a size_t var. We prefer signed
3032 types to unsigned, to avoid integer comparison confusion. Without
3033 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3034 "cannot optimize loop, the loop counter may overflow", a symptom
3035 of the confusion.
f00bbb22 3036 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3037 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3038
6468f31c
LMI
30392011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3040
49080b10
LMI
3041 * search.c (Fre_search_backward): Mention `case-fold-search' in
3042 all the re_search_* functions (bug#8138).
3043
6468f31c
LMI
3044 * keyboard.c (Fopen_dribble_file): Document when the file is
3045 closed (bug#8056).
3046
c965adc5
EZ
30472011-07-14 Eli Zaretskii <eliz@gnu.org>
3048
df9733bf
EZ
3049 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3050 bidi_cache_idx.
3051
0bb23927
EZ
3052 Support bidi reordering of display and overlay strings.
3053 * xdisp.c (compute_display_string_pos)
3054 (compute_display_string_end): Accept additional argument STRING.
3055 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3056 (reseat_to_string): Initialize bidi_it->string.s and
3057 bidi_it->string.schars.
3058 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3059 NULL (avoids a crash in bidi_paragraph_init).
3060 Initialize itb.string.lstring.
0bb23927
EZ
3061 (init_iterator): Call bidi_init_it only of a valid
3062 buffer position was specified. Initialize paragraph_embedding to
3063 L2R.
3064 (reseat_to_string): Initialize the bidi iterator.
3065 (display_string): If we need to ignore text properties of
3066 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3067 original value of -1 will not work with bidi.)
3068 (compute_display_string_pos): First arg is now struct
3069 `text_pos *'; all callers changed. Support display properties on
3070 Lisp strings.
3071 (compute_display_string_end): Support display properties on Lisp
3072 strings.
3073 (init_iterator, reseat_1, reseat_to_string): Initialize the
3074 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3075 when iterating on a string not from display properties).
640c8776
SM
3076 (compute_display_string_pos, compute_display_string_end):
3077 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3078 arrow keys.
3079 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3080 base_level_stop; instead, set base_level_stop to BEGV.
3081 Fixes crashes in vertical-motion.
0bb23927
EZ
3082 (next_element_from_buffer): Improve commentary for when
3083 the iterator is before prev_stop.
3084 (init_iterator): Initialize bidi_p from the default value of
3085 bidi-display-reordering, not from buffer-local value. Use the
3086 buffer-local value only if initializing for buffer iteration.
3087 (handle_invisible_prop): Support invisible properties on strings
3088 that are being bidi-reordered.
3089 (set_iterator_to_next): Support bidi reordering of C strings and
3090 Lisp strings.
3091 (next_element_from_string): Support bidi reordering of Lisp
3092 strings.
3093 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3094 (display_string): Support display of R2L glyph rows.
3095 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3096 (init_iterator): Don't initialize it->bidi_p for strings
3097 here.
3098 (reseat_to_string): Initialize it->bidi_p for strings here.
3099 (next_element_from_string, next_element_from_c_string)
3100 (next_element_from_buffer): Add xassert's for correspondence
3101 between IT's object being iterated and it->bidi_it.string
3102 structure.
3103 (face_before_or_after_it_pos): Support bidi iteration.
3104 (next_element_from_c_string): Handle the case of the first string
3105 character that is not the first one in the visual order.
3106 (get_visually_first_element): New function, refactored from common
3107 parts of next_element_from_buffer, next_element_from_string, and
3108 next_element_from_c_string.
3109 (tool_bar_lines_needed, redisplay_tool_bar)
3110 (display_menu_bar): Force left-to-right direction. Add a FIXME
3111 comment for making that be controlled by a user option.
3112 (push_it, pop_it): Save and restore the state of the
3113 bidi iterator. Save and restore the bidi_p flag.
3114 (pop_it): Iterate out of display property for string iteration as
3115 well.
3116 (iterate_out_of_display_property): Support iteration over strings.
3117 (handle_single_display_spec): Set up it->bidi_it for iteration
3118 over a display string, and call bidi_init_it.
3119 (handle_single_display_spec, next_overlay_string)
3120 (get_overlay_strings_1, push_display_prop): Set up the bidi
3121 iterator for displaying display or overlay strings.
3122 (forward_to_next_line_start): Don't use the shortcut if
3123 bidi-iterating.
3124 (back_to_previous_visible_line_start): If handle_display_prop
3125 pushed the iterator stack, restore the internal state of the bidi
3126 iterator by calling bidi_pop_it same number of times.
3127 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3128 and we are bidi-iterating, don't decrement the iterator position;
3129 instead, set the first_elt flag in the bidi iterator, to produce
3130 the same effect.
3131 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3132 (push_display_prop): xassert that we are iterating a buffer.
3133 (push_it, pop_it): Save and restore paragraph_embedding member.
3134 (handle_single_display_spec, next_overlay_string)
3135 (get_overlay_strings_1, reseat_1, reseat_to_string)
3136 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3137 correctly. Don't assume unibyte strings are not bidi-reordered.
3138 (compute_display_string_pos)
3139 (compute_display_string_end): Fix handling the case of C string.
3140 (push_it, pop_it): Save and restore from_disp_prop_p.
3141 (handle_single_display_spec, push_display_prop): Set the
3142 from_disp_prop_p flag.
3143 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3144 (pop_it): Call iterate_out_of_display_property only if we are
3145 popping after iteration over a string that came from a display
3146 property. Fix a typo in popping stretch info. Add an assertion
3147 for verifying that the iterator position is in sync with the bidi
3148 iterator.
3149 (handle_single_display_spec, get_overlay_strings_1)
3150 (push_display_prop): Fix initialization of paragraph direction for
3151 string when that of the parent object is not yet determined.
3152 (reseat_1): Call bidi_init_it to resync the bidi
3153 iterator with IT's position. (Bug#7616)
3154 (find_row_edges): If ROW->start.pos gives position
3155 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3156 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3157 Reset the from_disp_prop_p flag.
3158 (SAVE_IT, RESTORE_IT): New macros.
3159 (pos_visible_p, face_before_or_after_it_pos)
3160 (back_to_previous_visible_line_start)
3161 (move_it_in_display_line_to, move_it_in_display_line)
3162 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3163 (try_scrolling, redisplay_window, display_line): Use them when
3164 saving a temporary copy of the iterator and restoring it back.
3165 (back_to_previous_visible_line_start, reseat_1)
3166 (init_iterator): Empty the bidi cache "stack".
3167 (move_it_in_display_line_to): If iterator ended up at
3168 EOL, but we never saw any buffer positions smaller than
3169 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3170 motion in bidi-reordered lines.
3171 (move_it_in_display_line_to): Record prev_method and prev_pos
3172 immediately before the call to set_iterator_to_next. Fixes cursor
3173 motion in bidi-reordered lines with stretch glyphs and strings
3174 displayed in margins. (Bug#8133) (Bug#8867)
3175 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3176 TO_CHARPOS.
640c8776
SM
3177 (pos_visible_p): Support positions in bidi-reordered lines.
3178 Save and restore bidi cache.
0bb23927
EZ
3179
3180 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3181 (bidi_paragraph_info): Delete unused struct.
3182 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3183 (bidi_cache_start): New variable.
3184 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3185 to zero.
3186 (bidi_cache_fetch_state, bidi_cache_search)
3187 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3188 (bidi_cache_find, bidi_peek_at_next_level)
3189 (bidi_level_of_next_char, bidi_find_other_level_edge)
3190 (bidi_move_to_visually_next): Compare cache index with
3191 bidi_cache_start rather than with zero.
3192 (bidi_fetch_char): Accept new argument STRING; all callers
3193 changed. Support iteration over a string. Support strings with
3194 display properties. Support unibyte strings. Fix the type of
3195 `len' according to what STRING_CHAR_AND_LENGTH expects.
3196 (bidi_paragraph_init, bidi_resolve_explicit_1)
3197 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3198 (bidi_level_of_next_char, bidi_move_to_visually_next):
3199 Support iteration over a string.
0bb23927
EZ
3200 (bidi_set_sor_type, bidi_resolve_explicit_1)
3201 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3202 can now be zero (for strings); special values 0 and -1 were
3203 changed to -1 and -2, respectively.
3204 (bidi_char_at_pos): New function.
3205 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3206 Call it instead of FETCH_MULTIBYTE_CHAR.
3207 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3208 initialized to valid values.
3209 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3210 values.
3211 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3212 the test for valid cached positions. Fix the logic for looking up
3213 the sentinel state in the cache. GCPRO the Lisp string we are
3214 iterating.
3215 (bidi_push_it, bidi_pop_it): New functions.
3216 (bidi_initialize): Initialize the bidi cache start stack pointer.
3217 (bidi_cache_ensure_space): New function, refactored from part of
3218 bidi_cache_iterator_state. Don't assume the required size is just
3219 one BIDI_CACHE_CHUNK away.
3220 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3221 (bidi_count_bytes, bidi_char_at_pos): New functions.
3222 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3223 always valid if bidi_cache_idx is valid.
3224 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3225 is valid if it's going to be used.
3226 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3227 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3228 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3229 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3230 (bidi_find_other_level_edge, bidi_cache_start_stack):
3231 All variables related to cache indices are now EMACS_INT.
c965adc5 3232
0bb23927
EZ
3233 * dispextern.h (struct bidi_string_data): New structure.
3234 (struct bidi_it): New member `string'. Make flag members be 1-bit
3235 fields, and put them last in the struct.
640c8776
SM
3236 (compute_display_string_pos, compute_display_string_end):
3237 Update prototypes.
0bb23927
EZ
3238 (bidi_push_it, bidi_pop_it): Add prototypes.
3239 (struct iterator_stack_entry): New members bidi_p,
3240 paragraph_embedding, and from_disp_prop_p.
3241 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3242 (bidi_shelve_cache, bidi_unshelve_cache):
3243 Declare prototypes.
0bb23927
EZ
3244
3245 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3246 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3247 and vector-like objects.
3248
3249 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3250 cache around display iteration.
3251
3252 * window.c (Fwindow_end, window_scroll_pixel_based)
3253 (displayed_window_lines, Frecenter): Save and restore the bidi
3254 cache around display iteration.
3255
3bbd2265
LMI
32562011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3257
3258 * editfns.c (Fdelete_region): Clarify the use of the named
3259 parameters (bug#6788).
3260
adc47434
MR
32612011-07-14 Martin Rudalics <rudalics@gmx.at>
3262
3263 * indent.c (Fvertical_motion): Set and restore w->pointm when
3264 saving and restoring the window's buffer (Bug#9006).
3265
837c31f8
LMI
32662011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3267
3268 * editfns.c (Fstring_to_char): Clarify just what is returned
3269 (bug#6576). Text by Eli Zaretskii.
3270
ac389d0c
JB
32712011-07-13 Juanma Barranquero <lekktu@gmail.com>
3272
3273 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3274
0be0ce47
EZ
32752011-07-13 Eli Zaretskii <eliz@gnu.org>
3276
3277 * buffer.c (mmap_find): Fix a typo.
3278
cd18e7e3
JB
32792011-07-13 Johan Bockgård <bojohan@gnu.org>
3280
3281 Fix execution of x selection hooks.
3282 * xselect.c (Qx_lost_selection_functions)
3283 (Qx_sent_selection_functions): New vars.
3284 (syms_of_xselect): DEFSYM them.
3285 (x_handle_selection_request): Pass Qx_sent_selection_functions
3286 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3287 (x_handle_selection_clear,x_clear_frame_selections):
3288 Pass Qx_lost_selection_functions rather than
3289 Vx_lost_selection_functions to Frun_hook_with_args.
3290
47ea7f44
PE
32912011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3292
ac389d0c 3293 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3294 The old code sometimes used this field without initializing it.
3295
47ea7f44
PE
3296 * alloc.c (gc_sweep): Don't read past end of array.
3297 In theory, the old code could also have corrupted Emacs internals,
3298 though it'd be very unlikely.
3299
bc985c87
AS
33002011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3301
3302 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3303 argument. (Bug#4026)
bc985c87 3304
0cf34688
LMI
33052011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3306
b3dadd76
LMI
3307 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3308 key" (bug#4257).
3309
0cf34688
LMI
3310 * window.c (Fset_window_start): Doc fix (bug#4199).
3311 (Fset_window_hscroll): Ditto.
3312
270768cd
PE
33132011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3314
077e3dda 3315 Fix minor new problems caught by GCC 4.6.1.
270768cd 3316 * term.c (init_tty): Remove unused local.
490011a6 3317 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3318 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3319 not used otherwise.
270768cd 3320
b1f58454
CY
33212011-07-12 Chong Yidong <cyd@stupidchicken.com>
3322
3323 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3324
22b9578d
LMI
33252011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3326
6e70ab07
LMI
3327 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3328 are the mini-buffer and the echo area (bug#3320).
3329
22b9578d
LMI
3330 * term.c (init_tty): Remove support for supdup, c10 and perq
3331 terminals, which are no longer supported (bug#1482).
3332
8974cc9f
JB
33332011-07-10 Johan Bockgård <bojohan@gnu.org>
3334
3335 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3336
a560d974
JD
33372011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3338
3339 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3340 for non-popups (Bug#3642).
3341
1dae0f0a
AS
33422011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3343
268c2c36 3344 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3345 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3346 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3347 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3348 * data.c (fmod): Likewise.
3349 * dispnew.c (swap_glyphs_in_rows): Likewise.
3350 * emacs.c (memory_warning_signal): Likewise.
3351 * floatfns.c (float_error): Likewise.
3352 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3353 (otf_open, font_otf_capability, generate_otf_features)
3354 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3355 Likewise.
3356 * image.c (pbm_read_file): Likewise.
3357 * indent.c (string_display_width): Likewise.
3358 * intervals.c (check_for_interval, search_for_interval)
3359 (inc_interval_count, count_intervals, root_interval)
3360 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3361 * lread.c (defalias): Likewise.
268c2c36 3362 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3363 * regex.c (set_image_of_range_1, set_image_of_range)
3364 (regex_grow_registers): Likewise.
3365 * sysdep.c (strerror): Likewise.
3366 * termcap.c (valid_filename_p, tprint, main): Likewise.
3367 * tparam.c (main): Likewise.
3368 * unexhp9k800.c (run_time_remap, save_data_space)
3369 (update_file_ptrs, read_header, write_header, calculate_checksum)
3370 (copy_file, copy_rest, display_header): Likewise.
3371 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3372 Likewise.
3373 * xdisp.c (check_it): Likewise.
3374 * xfaces.c (register_color, unregister_color, unregister_colors):
3375 Likewise.
3376 * xfns.c (print_fontset_result): Likewise.
3377 * xrdb.c (member, fatal, main): Likewise.
3378
99033785
PE
33792011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3380
3381 Fix minor problems found by static checking (Bug#9031).
3382 * chartab.c (char_table_set_range, map_sub_char_table):
3383 Remove unused locals.
3384 (uniprop_table): Now static.
3385 * composite.c (_work_char): Remove unused static var.
3386
9cb2ac56
JB
33872011-07-09 Juanma Barranquero <lekktu@gmail.com>
3388
3389 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3390
f25661f0
JD
33912011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3392
3393 * gtkutil.c (qttip_cb): Remove code without function.
3394
8278c4fe
EZ
33952011-07-09 Eli Zaretskii <eliz@gnu.org>
3396
3397 * w32.c (pthread_sigmask): New stub.
3398
1692ae2d 33992011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3400
8a6ebd58 3401 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3402 sigprocmask is portable only for single-threaded applications, and
3403 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3404 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3405 (LIBES): Use it.
3406 * callproc.c (Fcall_process):
3407 * process.c (create_process):
3408 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3409 Use pthread_sigmask, not sigprocmask.
123403e4 3410
1b854618
JD
34112011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3412
3413 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3414 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3415 wrong (Bug#8591).
3416
3fe4b549
JD
34172011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3418
0ce7e563
JD
3419 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3420 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3421 (xg_hide_tooltip): Fix comment.
3422
3fe4b549
JD
3423 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3424 in registerServicesMenuSendTypes.
3425 (validRequestorForSendType): Don't check ns_return_types.
3426
3427 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3428 ns_return_type.
3429
5df75e47
JR
34302011-07-08 Jason Rumney <jasonr@gnu.org>
3431
22610910
JR
3432 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3433 SH_SHOW for hidden windows (Bug#5482).
3434
5df75e47
JR
3435 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3436 frame struct members of non-existent frames (Bug#6284).
3437
699c10bd
JD
34382011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3439
4393663b
JD
3440 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3441 variable firstTime not needed on OSX >= 10.6.
3442 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3443 >= 10.5. Use setKnobProportion, setDoubleValue.
3444
3445 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3446 (MAC_OS_X_VERSION_10_5): Define if not defined.
3447 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3448 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3449 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3450
3451 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3452 cString and lossyCString on OSX >= 10.4
3453
58179cce 3454 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3455 sizeToFit on OSX >= 10.2.
3456
3457 * nsimage.m (allocInitFromFile): Don't use deprecated method
3458 bestRepresentationForDevice on OSX >= 10.6.
3459
3460 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3461 to avoid warning.
3462
3463 * emacs.c: Declare unexec_init_emacs_zone.
3464
a63e0781
JD
3465 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3466
699c10bd
JD
3467 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3468
3469 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3470 on svcsMenu (Bug#8842).
3471
3472 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3473 ns_return_types.
3474 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3475
3476 * nsterm.m (QUTF8_STRING): Declare.
3477 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3478 (validRequestorForSendType): Return type is (id).
3479 Change indexOfObjectIdenticalTo to indexOfObject.
3480 Check if we have local selection before returning self (Bug#8842).
3481 (writeSelectionToPasteboard): Put local selection into paste board
3482 if we have a local selection (Bug#8842).
3483 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3484
3485 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3486 (ns_get_local_selection): Declare.
3487
54e10184
LMI
34882011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3489
9888ff71
LMI
3490 * keymap.c (describe_map_tree): Don't insert a double newline at
3491 the end of the buffer (bug#1169) and return whether we inserted
3492 something.
3493
54e10184
LMI
3494 * callint.c (Fcall_interactively): Change "reading args" to
3495 "providing args" to try to clarify what it does (bug#1010).
3496
15fa4783
KH
34972011-07-07 Kenichi Handa <handa@m17n.org>
3498
3499 * composite.c (composition_compute_stop_pos): Ignore a static
3500 composition starting before CHARPOS (Bug#8915).
3501
3502 * xdisp.c (handle_composition_prop): Likewise.
3503
a8815b00
EZ
35042011-07-07 Eli Zaretskii <eliz@gnu.org>
3505
3506 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3507 (Bug#9015)
3508
ef7b981d 35092011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3510
3511 * character.h (unicode_category_t): New enum type.
3512
3513 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3514 (Qchar_code_property_table): New variable.
3515 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3516 (UNIPROP_COMPRESSED_FORM_P): New macros.
3517 (char_table_ascii): Uncompress the compressed values.
3518 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3519 Uncompress the compressed values.
ac389d0c 3520 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3521 (char_table_ref_and_range): Uncompress the compressed values.
3522 (sub_char_table_set): New arg is_uniprop. Callers changed.
3523 Uncompress the compressed values.
3524 (sub_char_table_set_range): Args changed. Callers changed.
3525 (char_table_set_range): Adjuted for the above change.
3526 (map_sub_char_table): Delete args default_val and parent. Add arg
3527 top. Give decoded values to a Lisp function.
640c8776 3528 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3529 values to a Lisp function. Gcpro more variables.
3530 (uniprop_table_uncompress)
3531 (uniprop_decode_value_run_length): New functions.
3532 (uniprop_decoder, uniprop_decoder_count): New variables.
3533 (uniprop_get_decoder, uniprop_encode_value_character)
3534 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3535 New functions.
3536 (uniprop_encoder, uniprop_encoder_count): New variables.
3537 (uniprop_get_encoder, uniprop_table)
3538 (Funicode_property_table_internal, Fget_unicode_property_internal)
3539 (Fput_unicode_property_internal): New functions.
3540 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3541 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3542 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3543 char-code-property-alist.
3544
640c8776 3545 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3546 Vunicode_category_table.
3547
640c8776 3548 * font.c (font_range): Adjust for the change of
c805dec0
KH
3549 Vunicode_category_table.
3550
76b397fb
DN
35512011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3552
3553 * m/iris4d.h: Remove file, move contents ...
3554 * s/irix6-5.h: ... here.
3555
22b4128e
PE
35562011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3557
3558 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3559 * alloc.c (mark_buffer):
3560 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3561 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3562 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3563 This isn't true in general, and it's particularly not true
3564 if Emacs is configured with --with-wide-int.
3565 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3566 New macros, used in the buffer.c change.
3567
869795d6
JD
35682011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3569
3570 * xsettings.c: Use both GConf and GSettings if both are available.
3571 (store_config_changed_event): Add comment.
3572 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3573 (store_tool_bar_style_changed): New functions.
5e617bc2 3574 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3575 (struct xsettings): Move font inside HAVE_XFT.
3576 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3577 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3578 Move inside HAVE_XFT.
640c8776 3579 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3580 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3581 also.
3582 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3583 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3584 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3585 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3586 (parse_settings): Move check for font inside HAVE_XFT.
3587 (read_settings, apply_xft_settings): Add comment.
3588 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3589 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3590 call store_font_name_changed.
3591 (xft_settings_event): Add comment.
3592 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3593 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3594 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3595 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3596 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3597 (xsettings_get_system_font, xsettings_get_system_normal_font):
3598 Add comment.
869795d6 3599
d8ed26bd
PE
36002011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3601
3602 Random fixes. E.g., (random) never returned negative values.
3603 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3604 subseconds part to the entropy, as that's a bit more random.
3605 Prefer signed to unsigned, since the signedness doesn't matter and
3606 in general we prefer signed. When given a limit, use a
3607 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3608 latter isn't right if USE_2_TAGS_FOR_INTS.
3609 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3610 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3611
cabf1cac
SM
36122011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3613
3614 * textprop.c (text_property_stickiness):
3615 Obey Vtext_property_default_nonsticky.
3616 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3617 * w32fns.c (syms_of_w32fns):
3618 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3619
6e9b2be9
PE
36202011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3621
3622 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3623 This is more efficient than Ffile_directory_p and avoids a minor race.
3624
90186c68
LMI
36252011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3626
7c301272
LMI
3627 * buffer.c (Foverlay_put): Say what the return value is
3628 (bug#7835).
3629
c4f2d8d4
LMI
3630 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3631 is a directory before asking whether to use the file name
3632 (bug#7564).
ad637907
LMI
3633 (barf_or_query_if_file_exists): Make the "File is a directory"
3634 error be more correct.
c4f2d8d4 3635
90186c68
LMI
3636 * fns.c (Frequire): Remove the mention of the .gz files, since
3637 that's installation-specific, but keep the mention of
3638 `get-load-suffixes'.
3639
da64016e
PE
36402011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3641
3642 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3643 Report string overflow if the output is too long.
3644
7d47b580
JB
36452011-07-04 Juanma Barranquero <lekktu@gmail.com>
3646
a555cb87
JB
3647 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3648 (syms_of_gnutls): Remove duplicate DEFSYM for
3649 Qgnutls_bootprop_verify_hostname_error, an error for
3650 Qgnutls_bootprop_verify_error (which is no longer used).
3651
7d47b580
JB
3652 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3653 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3654 Also (re)move comments that are misplaced or no longer relevant.
3655
1e49bfab
LMI
36562011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3657
3658 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3659
1485f4c0
CY
36602011-07-03 Chong Yidong <cyd@stupidchicken.com>
3661
3662 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3663 and background color parameters if they have been changed.
3664
a9ab721e
LMI
36652011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3666
3667 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3668
cf7cff57
PE
36692011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3670
2e13213d
PE
3671 * xsettings.c (SYSTEM_FONT): Define only when used.
3672 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3673
cf7cff57
PE
3674 * keymap.c (access_keymap_1): Now static.
3675
7a8e04f7
CY
36762011-07-02 Chong Yidong <cyd@stupidchicken.com>
3677
3678 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3679 leave any prefix arg for the up event (Bug#1586).
3680
61352f62
LMI
36812011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3682
69bb1ef7
LMI
3683 * lread.c (syms_of_lread): Mention single symbols defined by
3684 `defvar' or `defconst' (bug#7154).
3685
61352f62 3686 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3687 (Frequire): Mention get-load-suffixes.
61352f62 3688
28545e04
MR
36892011-07-02 Martin Rudalics <rudalics@gmx.at>
3690
3691 * window.h (window): Remove clone_number slot.
3692 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3693 Remove.
3694 (make_parent_window, make_window, saved_window)
3695 (Fset_window_configuration, save_window_save): Don't deal with
3696 clone numbers.
3697 * buffer.c (Qclone_number): Remove declaration.
3698 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3699
3349e122
SM
37002011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3701
3702 Add multiple inheritance to keymaps.
3703 * keymap.c (Fmake_composed_keymap): New function.
3704 (Fset_keymap_parent): Simplify.
3705 (fix_submap_inheritance): Remove.
3706 (access_keymap_1): New function extracted from access_keymap to handle
3707 embedded parents and handle lists of maps.
3708 (access_keymap): Use it.
3709 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3710 (Fcopy_keymap): Handle embedded parents.
3711 (Fcommand_remapping, define_as_prefix): Simplify.
3712 (Fkey_binding): Simplify.
3713 (syms_of_keymap): Move minibuffer-local-completion-map,
3714 minibuffer-local-filename-completion-map,
3715 minibuffer-local-must-match-map, and
3716 minibuffer-local-filename-must-match-map to Elisp.
3717 (syms_of_keymap): Defsubr make-composed-keymap.
3718 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3719 (parse_menu_item): Trivial simplification.
3720
3279eb87
GM
37212011-07-01 Glenn Morris <rgm@gnu.org>
3722
3723 * Makefile.in (SETTINGS_LIBS): Fix typo.
3724
4550efdf
KI
37252011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3726
3727 * coding.c (Fencode_coding_string): Record the last coding system
3728 used, as the function doc string says (bug#8738).
3729
0949d2b6
JD
37302011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3731
3732 * xsettings.c (store_monospaced_changed): Take new font as arg and
3733 check for change against current_mono_font.
3734 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3735 (emacs_settings_constructor, emacs_settings_get_property)
3736 (emacs_settings_set_property, emacs_settings_class_init)
3737 (emacs_settings_init, gsettings_obj): Remove.
3738 (something_changedCB): New function for HAVE_GSETTINGS.
3739 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3740 with value as argument.
3741 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3742 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3743 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3744 "changed".
3745
3746 * xgselect.c: Add defined (HAVE_GSETTINGS).
3747 (xgselect_initialize): Ditto.
3748
3749 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3750 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3751 xg_select.
3752
bbc6b304
PE
37532011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3754
3755 * eval.c (struct backtrace): Simplify and port the data structure.
3756 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3757 signed bit field, as this assumption is not portable and it makes
3758 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3759 "char debug_on_exit : 1" as this is not portable either; instead,
3760 use the portable "unsigned int debug_on_exit : 1". Remove unused
3761 member evalargs. Remove obsolete comments about cc bombing out.
3762
9851bfc5
JD
37632011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3764
51bb811f 3765 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3766 Let HAVE_GSETTINGS override HAVE_GCONF.
3767 (store_monospaced_changed): New function.
3768 (EMACS_SETTINGS): A new type derived from GObject to handle
3769 GSettings notifications.
3770 (emacs_settings_constructor, emacs_settings_get_property)
3771 (emacs_settings_set_property, emacs_settings_class_init):
3772 New functions.
3773 (gsettings_client, gsettings_obj): New variables.
3774 (GSETTINGS_SCHEMA): New define.
3775 (something_changedCB): Call store_monospaced_changed.
3776 (init_gsettings): New function.
3777 (xsettings_initialize): Call init_gsettings.
3778 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3779 to NULL.
3780
640c8776 3781 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3782 GCONF_CFLAGS/LIBS.
3783
5386012d
MR
37842011-06-29 Martin Rudalics <rudalics@gmx.at>
3785
3786 * window.c (resize_root_window, grow_mini_window)
3787 (shrink_mini_window): Rename Qresize_root_window to
3788 Qwindow_resize_root_window and Qresize_root_window_vertically to
3789 Qwindow_resize_root_window_vertically.
3790
f13e0b08
PE
37912011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3792
3793 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3794
94515237
JB
37952011-06-27 Juanma Barranquero <lekktu@gmail.com>
3796
3797 * makefile.w32-in: Redesign dependencies so they reflect more
3798 clearly which files are directly included by each source file,
3799 and not through other includes.
3800
e43b6e43
MR
38012011-06-27 Martin Rudalics <rudalics@gmx.at>
3802
3803 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3804 (sort_overlays, overlay_strings): When an overlay's clone number
3805 matches the window's clone number process the overlay even if
3806 the overlay's window property doesn't match the current window.
3807
d68443dc
MR
3808 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3809 (Fwindow_hchild): Rename to Fwindow_left_child.
3810 (Fwindow_next): Rename to Fwindow_next_sibling.
3811 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3812 (resize_window_check): Rename to window_resize_check.
3813 (resize_window_apply): Rename to window_resize_apply.
3814 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3815 (Fdelete_other_windows_internal, resize_frame_windows)
3816 (Fsplit_window_internal, Fdelete_window_internal)
3817 (grow_mini_window, shrink_mini_window)
3818 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3819
c7e73be5
JD
38202011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3821
3822 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3823 (emacs_fixed_set_min_size): Remove.
3824 (emacs_fixed_new): Take frame as argument.
3825
3826 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3827 (_EmacsFixedPrivate): Remove minwidth/height.
3828 Add struct frame *f.
3829 (emacs_fixed_init): Initialize priv->f.
3830 (get_parent_class, emacs_fixed_set_min_size): Remove.
3831 (emacs_fixed_new): Set priv->f to argument.
3832 (emacs_fixed_get_preferred_width)
3833 (emacs_fixed_get_preferred_height): Use min_width/height from
3834 frames size_hint to set minimum and natural (Bug#8919).
3835 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3836 and use min_width/height from frames size_hint to set
3837 min_width/height (Bug#8919).
3838
3839 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3840 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3841 Fix indentation.
c7e73be5 3842
cf99dcf8
EZ
38432011-06-26 Eli Zaretskii <eliz@gnu.org>
3844
3845 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3846 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3847 called at ZV.
3848
029529ac
CY
38492011-06-26 Chong Yidong <cyd@stupidchicken.com>
3850
3851 * process.c (wait_reading_process_output): Bypass select if
3852 waiting for a cell while ignoring keyboard input, and input is
3853 pending. Suggested by Jan Djärv (Bug#8869).
3854
7a7ef429
PE
38552011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3856
3857 Use gnulib's dup2 module instead of rolling our own.
3858 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3859
11fdef7d 38602011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3861
3862 * dispnew.c (scrolling_window): Before scrolling, turn off a
3863 mouse-highlight in the window being scrolled.
3864
cd3520a4
JB
38652011-06-24 Juanma Barranquero <lekktu@gmail.com>
3866
3867 Move DEFSYM to lisp.h and use everywhere.
3868
3869 * character.h (DEFSYM): Move declaration...
3870 * lisp.h (DEFSYM): ...here.
3871
3872 * gnutls.c:
3873 * minibuf.c:
3874 * w32menu.c:
3875 * w32proc.c:
3876 * w32select.c: Don't include character.h.
3877
3878 * alloc.c (syms_of_alloc):
3879 * buffer.c (syms_of_buffer):
3880 * bytecode.c (syms_of_bytecode):
3881 * callint.c (syms_of_callint):
3882 * casefiddle.c (syms_of_casefiddle):
3883 * casetab.c (init_casetab_once):
3884 * category.c (init_category_once, syms_of_category):
3885 * ccl.c (syms_of_ccl):
3886 * cmds.c (syms_of_cmds):
3887 * composite.c (syms_of_composite):
3888 * dbusbind.c (syms_of_dbusbind):
3889 * dired.c (syms_of_dired):
3890 * dispnew.c (syms_of_display):
3891 * doc.c (syms_of_doc):
3892 * editfns.c (syms_of_editfns):
3893 * emacs.c (syms_of_emacs):
3894 * eval.c (syms_of_eval):
3895 * fileio.c (syms_of_fileio):
3896 * fns.c (syms_of_fns):
3897 * frame.c (syms_of_frame):
3898 * fringe.c (syms_of_fringe):
3899 * insdel.c (syms_of_insdel):
3900 * keymap.c (syms_of_keymap):
3901 * lread.c (init_obarray, syms_of_lread):
3902 * macros.c (syms_of_macros):
3903 * msdos.c (syms_of_msdos):
3904 * print.c (syms_of_print):
3905 * process.c (syms_of_process):
3906 * search.c (syms_of_search):
3907 * sound.c (syms_of_sound):
3908 * syntax.c (init_syntax_once, syms_of_syntax):
3909 * terminal.c (syms_of_terminal):
3910 * textprop.c (syms_of_textprop):
3911 * undo.c (syms_of_undo):
3912 * w32.c (globals_of_w32):
3913 * window.c (syms_of_window):
3914 * xdisp.c (syms_of_xdisp):
3915 * xfaces.c (syms_of_xfaces):
3916 * xfns.c (syms_of_xfns):
3917 * xmenu.c (syms_of_xmenu):
3918 * xsettings.c (syms_of_xsettings):
3919 * xterm.c (syms_of_xterm): Use DEFSYM.
3920
4228cf16
TZ
39212011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3922
cd3520a4 3923 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3924
7fcccf1e
PE
39252011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3926
7efb4e0e
PE
3927 Integer and buffer overflow fixes (Bug#8873).
3928
ff5844ad
PE
3929 * print.c (printchar, strout): Check for string overflow.
3930 (PRINTPREPARE, printchar, strout):
3931 Don't set size unless allocation succeeds.
3932
90532f02
PE
3933 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3934 for sizes. Check for string overflow more accurately.
3935 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3936
6d84508d
PE
3937 * macros.c: Integer and buffer overflow fixes.
3938 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3939 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3940 Use ptrdiff_t, not int, for sizes.
3941 Don't increment bufsize until after realloc succeeds.
3942 Check for size-calculation overflow.
3943 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3944
437b2cb4
PE
3945 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3946
8b9ac8b4
PE
3947 * lread.c: Integer overflow fixes.
3948 (read_integer): Radix is now EMACS_INT, not int,
3949 to improve quality of diagnostics for out-of-range radices.
3950 Calculate buffer size correctly for out-of-range radices.
3951 (read1): Check for integer overflow in radices, and in
3952 read-circle numbers.
82cb60d3
PE
3953 (read_escape): Avoid int overflow.
3954 (Fload, openp, read_buffer_size, read1)
3955 (substitute_object_recurse, read_vector, read_list, map_obarray):
3956 Use ptrdiff_t, not int, for sizes.
3957 (read1): Use EMACS_INT, not int, for sizes.
20270765 3958 Check for size overflow.
8b9ac8b4 3959
7fcccf1e
PE
3960 * image.c (cache_image): Check for size arithmetic overflow.
3961
bfbbd7e7
PE
3962 * lread.c: Integer overflow issues.
3963 (saved_doc_string_size, saved_doc_string_length)
3964 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3965 Now ptrdiff_t, not int.
3966 (read1): Don't assume doc string length fits in int. Check for
3967 out-of-range doc string lengths.
3968 (read_list): Don't assume file position fits in int.
39019e54 3969 (read_escape): Check for hex character overflow.
bfbbd7e7 3970
4e323265
LL
39712011-06-22 Leo Liu <sdl.web@gmail.com>
3972
3973 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3974 Move to minibuffer.el.
3975
85fece3e
PE
39762011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3977
20b84ce9 3978 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3979 The following patches are for when GLYPH_DEBUG && !XASSERT.
3980 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3981 * dispnew.c (flush_stdout):
3982 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3983 Mark as externally visible.
3984 * dispnew.c (check_window_matrix_pointers): Now static.
3985 * dispnew.c (window_to_frame_vpos):
3986 * xfns.c (unwind_create_frame):
3987 * xterm.c (x_check_font): Remove unused local.
3988 * scroll.c (CHECK_BOUNDS):
3989 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3990 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3991 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3992 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3993 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3994 Now static.
3995 (debug_method_add): Use va_list and vsprintf rather than relying
3996 on undefined behavior with wrong number of arguments.
3997 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3998 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3999 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4000 since we're not interested in debugging glyphs with old libraries.
4001 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4002 GCC 4.6.0's static checking.
4003
0766b489
PE
40042011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4005
31fd4b32
PE
4006 Integer overflow and signedness fixes (Bug#8873).
4007 A few related buffer overrun fixes, too.
4008
b79e8648
PE
4009 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4010
0766b489
PE
4011 * dispextern.h (struct face.stipple):
4012 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4013 (x_bitmap_mask, x_allocate_bitmap_record)
4014 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4015 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4016 (x_create_bitmap_from_xpm_data):
4017 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4018 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4019 (.bitmaps_last):
4020 * xfaces.c (load_pixmap):
4021 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4022 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4023 (.bitmaps_last, struct x_output.icon_bitmap):
4024 Use ptrdiff_t, not int, for bitmap indexes.
4025 (x_allocate_bitmap_record): Check for size overflow.
4026 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4027
b081724f
PE
4028 Use ptrdiff_t, not int, for overlay counts.
4029 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4030 * editfns.c (overlays_around, get_pos_property):
4031 * textprop.c (get_char_property_and_overlay):
4032 * xdisp.c (next_overlay_change, note_mouse_highlight):
4033 * xfaces.c (face_at_buffer_position):
21514da7
PE
4034 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4035 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4036 (Fnext_overlay_change, Fprevious_overlay_change)
4037 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4038 Use ptrdiff_t, not int, for sizes.
21514da7 4039 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4040
3de73e5e
PE
4041 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4042
2606c57b
PE
4043 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4044 (x_session_initialize): Do not assume string length fits in int.
4045
aaafe47a
PE
4046 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4047 This is unlikely, but can occur if DPI is outlandish.
4048
2674ddc8 4049 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4050 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4051
28154962
PE
4052 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4053 * xrdb.c (magic_file_p, search_magic_path):
4054 Omit last arg SUFFIX; it was always 0. All callers changed.
4055 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4056
7de51af5
PE
4057 * xfont.c (xfont_match): Avoid need for strlen.
4058
25ed6cc3
PE
4059 * xfns.c: Don't assume strlen fits in int.
4060 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4061
4eab31dd
PE
4062 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4063 not unsigned long, as we prefer signed integers. All callers changed.
4064 Detect integer overflow in repeat count.
4065 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4066 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4067
171e2a58
PE
4068 * termcap.c: Don't assume sizes fit in int and never overflow.
4069 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4070 (gobble_line): Check for size-calculation overflow.
4071
ad39faca 4072 * minibuf.c (Fread_buffer):
6e5bb2dc 4073 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4074 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4075 Don't assume string length fits in int.
4076
52c61c22 4077 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4078 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4079
b5b8c9e5
PE
4080 * font.c: Don't assume string length fits in int.
4081 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4082 Use ptrdiff_t, not int.
ccd6111c
PE
4083 (font_intern_prop): Don't assume string length fits in int.
4084 Don't assume integer property fits in fixnum.
4085 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4086
882f0d81 4087 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4088 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4089 Reformulate so as not to need the command string.
4090 Invoke gzip -cd rather than gunzip, as it's more portable.
4091 (lock_info_type, lock_file_1, lock_file):
4092 Don't assume pid_t and time_t fit in unsigned long.
4093 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4094 (current_lock_owner): Prefer signed type for sizes.
4095 Use memcpy, not strncpy, where memcpy is what is really wanted.
4096 Don't assume (via atoi) that time_t and pid_t fit in int.
4097 Check for time_t and/or pid_t out of range, e.g., via a network share.
4098 Don't alloca where an auto var works fine.
4099
93f4cf88
PE
4100 * fileio.c: Fix some integer overflow issues.
4101 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4102 Don't assume string length fits in int.
4103 (directory_file_name): Don't assume string length fits in long.
4104 (make_temp_name): Don't assume pid fits in int, or that its print
4105 length is less than 20.
4106
f3e92b69
PE
4107 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4108
1bfdaf10
PE
4109 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4110
35016e9a
PE
4111 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4112
3d1e65a1
PE
4113 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4114 We prefer signed integers, even for size calculations.
4115
0b963a93
PE
4116 * emacs.c: Don't assume string length fits in 'int'.
4117 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4118 (main): Don't invoke strlen when not needed.
4119
573f4b54
PE
4120 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4121 (XD_DEBUG_MESSAGE): Don't waste a byte.
4122
989f33ba
PE
4123 * callproc.c (getenv_internal_1, getenv_internal)
4124 (Fgetenv_internal):
965d34eb
PE
4125 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4126
e4d29b33
PE
4127 * lread.c (invalid_syntax): Omit length argument.
4128 All uses changed. This doesn't fix a bug, but it simplifies the
4129 code away from its former Hollerith-constant appearance, and it's
4130 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4131 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4132
eb49b136
PE
4133 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4134 This didn't break anything, but it didn't help either.
4135 It's confusing to put a bogus integer in a place where the actual
4136 value does not matter.
9f62aeb1 4137 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4138 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4139
15375a22
PE
4140 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4141 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4142 implementation.
b61cc01c
PE
4143 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4144 We prefer signed types, and the value cannot exceed the EMACS_INT
4145 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4146 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4147 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4148 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4149
53b2623d
PE
4150 * indent.c (sane_tab_width): New function.
4151 (current_column, scan_for_column, Findent_to, position_indentation)
4152 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4153 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4154
51cab52b 4155 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4156
f2ed8a70
PE
4157 * lisp.h (lint_assume): New macro.
4158 * composite.c (composition_gstring_put_cache):
4159 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4160
abe80cc6
PE
4161 * editfns.c, insdel.c:
4162 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4163
b02c740e
PE
4164 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4165
ebc96716
PE
4166 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4167
b4e50fa0 4168 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4169 Use much-faster test for byte-length change.
311d5d7c 4170 Don't assume string byte-length fits in 'int'.
a4cf38e4 4171 Check that character arg fits in 'int'.
85461888 4172 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4173
c0c1ee9f
PE
4174 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4175
a498d7f4
PE
4176 * fns.c (concat): Catch string overflow earlier.
4177 Do not rely on integer wraparound.
4178
51cab52b
PE
4179 * dispextern.h (struct it.overlay_strings_charpos)
4180 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4181 * xdisp.c (forward_to_next_line_start)
4182 (back_to_previous_visible_line_start)
4183 (reseat_at_next_visible_line_start, next_element_from_buffer):
4184 Don't arbitrarily truncate the value of 'selective' to int.
4185
76031fad
PE
4186 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4187
5eb55db9
PE
4188 * composite.c: Don't truncate sizes to 'int'.
4189 (composition_gstring_p, composition_reseat_it)
4190 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4191 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4192 not EMACS_UINT, for indexes.
5eb55db9 4193
0703a717
PE
4194 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4195
d6202519
PE
4196 * buffer.c: Include <verify.h>.
4197 (struct sortvec.priority, struct sortstr.priority):
8961a454 4198 Now EMACS_INT, not int.
c20998a7 4199 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4200 (struct sortstr.size, record_overlay_string)
4201 (struct sortstrlist.size, struct sortlist.used):
4202 Don't truncate size to int.
4203 (record_overlay_string): Check for size-calculation overflow.
d6202519 4204 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4205
d5a19415
JM
42062011-06-22 Jim Meyering <meyering@redhat.com>
4207
029529ac 4208 Don't leak an XBM-image-sized buffer
d5a19415
JM
4209 * image.c (xbm_load): Free the image buffer after using it.
4210
a9041e6c
PE
42112011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4212
4213 Port to Sun C.
4214 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4215 that Sun C diagnosed.
4216 * fns.c (secure_hash): Fix pointer signedness issue.
4217 * intervals.c (static_offset_intervals): New function.
4218 (offset_intervals): Use it.
4219
7f3f739f
LL
42202011-06-21 Leo Liu <sdl.web@gmail.com>
4221
4222 * deps.mk (fns.o):
4223 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4224 sha512.h.
4225
4226 * fns.c (secure_hash): Rename from crypto_hash_function and change
4227 the first arg to accept symbols.
5b66d427 4228 (Fsecure_hash): New primitive.
7f3f739f
LL
4229 (syms_of_fns): New symbols.
4230
76147d94
DD
42312011-06-20 Deniz Dogan <deniz@dogan.se>
4232
4233 * process.c (Fset_process_buffer): Clarify return value in
4234 docstring.
4235
7d7d0045
CY
42362011-06-18 Chong Yidong <cyd@stupidchicken.com>
4237
4238 * dispnew.c (add_window_display_history): Use BVAR.
4239
4240 * xdisp.c (debug_method_add): Use BVAR.
4241 (check_window_end, dump_glyph_matrix, dump_glyph)
4242 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4243
4244 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4245 Likewise.
4246
4247 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4248 check till after the cache is created in init_frame_faces.
4249
ff2bc410
SM
42502011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4251
4252 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4253
28177add
PE
42542011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4255
dd3482fe
PE
4256 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4257 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4258 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4259
393d71f3 4260 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4261 * fileio.c (Finsert_file_contents):
4262 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4263 Remove the old (too-loose) buffer overflow checks.
4264 They weren't needed, since make_gap checks for buffer overflow.
4265 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4266 The old code merely checked for Emacs fixnum overflow, and relied
4267 on undefined (wraparound) behavior. The new code avoids undefined
4268 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4269
2e6813b0 4270 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4271 Tune. Don't use wider integers than needed. Don't use alloca.
4272 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4273
599a9e4f
PE
4274 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4275
99561444
PE
4276 * insdel.c, lisp.h (buffer_overflow): New function.
4277 (insert_from_buffer_1, replace_range, replace_range_2):
4278 * insdel.c (make_gap_larger):
4279 * editfns.c (Finsert_char):
4280 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4281
28177add
PE
4282 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4283
e69dafad
PE
42842011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4285
a7af7fde 4286 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4287
b1c46f02
PE
4288 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4289 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4290
e69dafad
PE
4291 * fileio.c: Don't assume EMACS_INT fits in off_t.
4292 (emacs_lseek): New static function.
4293 (Finsert_file_contents, Fwrite_region): Use it.
4294 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4295
566684ea
PE
4296 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4297
e6966cd6
PE
4298 * fns.c: Don't overflow int when computing a list length.
4299 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4300 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4301 truncation on 64-bit hosts. Check for QUIT every
4302 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4303 faster and is responsive enough.
4304 (Flength): Report an error instead of overflowing an integer.
4305 (Fsafe_length): Return a float if the value is not representable
4306 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4307 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4308 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4309
dd0b0efb
PE
4310 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4311 (header_size, word_size): New constants.
4312 (allocate_vectorlike): Don't check size overflow here.
4313 (allocate_vector): Check it here instead, since this is the only
4314 caller of allocate_vectorlike that could cause overflow.
4315 Check that the new vector's length is representable as a fixnum.
4316
86fe5cfe
PE
4317 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4318 The previous code was bogus. For example, next_almost_prime (32)
4319 returned 39, which is undesirable as it is a multiple of 3; and
4320 next_almost_prime (24) returned 25, which is a multiple of 5 so
4321 why was the code bothering to check for multiples of 7?
4322
80e88859
PE
4323 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4324
4a2f0ad6
PE
4325 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4326
f66c7cf8
PE
4327 Variadic C functions now count arguments with ptrdiff_t.
4328 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4329 Back then I didn't know that the Emacs coding style prefers signed int.
4330 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4331 were being counted with int, which may truncate counts on 64-bit
4332 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4333 * lisp.h (struct Lisp_Subr.function.aMANY)
4334 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4335 Arg counts are now ptrdiff_t, not size_t.
4336 All variadic functions and their callers changed accordingly.
4337 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4338 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4339 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4340 * callint.c (Fcall_interactively): Check arg count for overflow,
4341 to avoid potential buffer overrun. Use signed char, not 'int',
4342 for 'varies' array, so that we needn't bother to check its size
4343 calculation for overflow.
4344 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4345 * eval.c (apply_lambda):
4346 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4347 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4348 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4349
a1759b76
PE
4350 * callint.c (Fcall_interactively): Don't use index var as event count.
4351
d96be9fc
PE
4352 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4353 * mem-limits.h (SIZE): Remove; no longer used.
4354
a690a978 4355 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4356
578c21e6
PE
4357 Remove unnecessary casts.
4358 * xterm.c (x_term_init):
4359 * xfns.c (x_set_border_pixel):
4360 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4361 These aren't needed now that we assume ANSI C.
4362
96f53c6c
PE
4363 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4364 It's more likely to cause problems (due to unsigned overflow)
4365 than to cure them.
4366
83c77d31
PE
4367 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4368
ee2079f1
PE
4369 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4370
6da65536
PE
4371 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4372
7147c4a4
PE
4373 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4374
193e32d9
PE
4375 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4376
e5533da6
PE
4377 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4378
9910e595
PE
4379 GLYPH_CODE_FACE returns EMACS_INT, not int.
4380 * dispextern.h (merge_faces):
4381 * xfaces.c (merge_faces):
01103c44
PE
4382 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4383 Don't assume EMACS_INT fits in int.
9910e595 4384
2638320e
PE
4385 * character.h (CHAR_VALID_P): Remove unused parameter.
4386 * fontset.c, lisp.h, xdisp.c: All uses changed.
4387
045eb8d9
PE
4388 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4389
c1f134b5
PE
4390 * fns.c (concat): Minor tuning based on overflow analysis.
4391 This doesn't fix any bugs. Use int to hold character, instead
4392 of constantly refetching from Emacs object. Use XFASTINT, not
4393 XINT, for value known to be a character. Don't bother comparing
4394 a single byte to 0400, as it's always less.
4395
395fcb93 4396 * floatfns.c (Fexpt):
327eeec8
PE
4397 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4398
abbd3d23
PE
4399 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4400 for characters.
4401
684a03ef
PE
4402 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4403
0fed43f3
PE
4404 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4405 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4406 incorrectly succeed when S was a string, because 4294967386 was
4407 truncated before it was used.
4408
8fd02eb7
PE
4409 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4410 Otherwise, an out-of-range integer could cause undefined behavior
4411 on a 64-bit host.
4412
f8c86b69
PE
4413 * composite.c: Use int, not EMACS_INT, for characters.
4414 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4415 EMACS_INT, for values that are known to be in character range.
4416 This doesn't fix any bugs but is the usual style inside Emacs and
4417 may generate better code on 32-bit machines.
4418
34206dd2
PE
4419 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4420 This is for reasons similar to the recent CHAR_STRING fix.
4421 * charset.c (Fencode_char): Check that character arg is actually
4422 a character. Pass an int to ENCODE_CHAR.
4423 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4424 wider than 'int', as a compile-time check to prevent future regressions
4425 in this area.
4426
c5958d4c 4427 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4428
4429 Make sure a 64-bit char is never passed to CHAR_STRING.
4430 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4431 by silently ignoring the top 32 bits, allowing some values
4432 that were far too large to be valid characters.
4433 * character.h: Include <verify.h>.
4434 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4435 arguments are no wider than unsigned, as a compile-time check
4436 to prevent future regressions in this area.
4437 * data.c (Faset):
01103c44 4438 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4439 (Fsubst_char_in_region):
4440 * fns.c (concat):
4441 * xdisp.c (decode_mode_spec_coding):
4442 Adjust to CHAR_STRING's new requirement.
4443 * editfns.c (Finsert_char, Fsubst_char_in_region):
4444 * fns.c (concat): Check that character args are actually
4445 characters. Without this test, these functions did the wrong
4446 thing with wildly out-of-range values on 64-bit hosts.
4447
d37ca623
PE
4448 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4449 These casts should not be needed on 32-bit hosts, either.
4450 * keyboard.c (read_char):
4451 * lread.c (Fload): Remove casts to unsigned.
4452
ea204efb
PE
4453 * lisp.h (UNSIGNED_CMP): New macro.
4454 This fixes comparison bugs on 64-bit hosts.
4455 (ASCII_CHAR_P): Use it.
4456 * casefiddle.c (casify_object):
01103c44 4457 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4458 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4459 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4460 * dispextern.h (FACE_FROM_ID):
4461 * keyboard.c (read_char): Use UNSIGNED_CMP.
4462
41cb286c
PE
4463 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4464 not to EMACS_INT, to avoid GCC warning.
4465
4a1b9832
PE
4466 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4467
55daad71
PE
4468 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4469 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4470 isn't needed on 32-bit machines.
8f95c75c 4471
01103c44
PE
4472 * buffer.c (Fgenerate_new_buffer_name):
4473 Use EMACS_INT for count, not int.
0ceccced 4474 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4475
4476 * data.c (Qcompiled_function): Now static.
4477
c6f072e7
PE
4478 * window.c (window_body_lines): Now static.
4479
20ce5912
PE
4480 * image.c (gif_load): Rename local to avoid shadowing.
4481
9c4c5f81
PE
4482 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4483 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4484 * alloc.c (make_save_value): Integer argument is now of type
4485 ptrdiff_t, not int.
4486 (mark_object): Use ptrdiff_t, not int.
4487 * lisp.h (pD): New macro.
4488 * print.c (print_object): Use it.
4489
c0c5c8ae
PE
4490 * alloc.c: Use EMACS_INT, not int, to count objects.
4491 (total_conses, total_markers, total_symbols, total_vector_size)
4492 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4493 (total_free_floats, total_floats, total_free_intervals)
4494 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4495 Now EMACS_INT, not int. All uses changed.
4496 (Fgarbage_collect): Compute overall total using a double, so that
4497 integer overflow is less likely to be a problem. Check for overflow
4498 when converting back to an integer.
5a25e253
PE
4499 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4500 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4501 These were 'int' variables that could overflow on 64-bit hosts;
4502 they were never used, so remove them instead of repairing them.
211a0b2a 4503 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4504 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4505 Previously, this ceilinged at INT_MAX, but that doesn't work on
4506 64-bit machines.
e46bb31a 4507 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4508
c78baabf 4509 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4510 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4511 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4512 when a (possibly-narrower) signed value would do just as well.
4513 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4514
c9d624c6
PE
4515 * alloc.c: Catch some string size overflows that we were missing.
4516 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4517 for convenience in STRING_BYTES_MAX.
4518 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4519 The definition here is exact; the one in lisp.h was approximate.
4520 (allocate_string_data): Check for string overflow. This catches
4521 some instances we weren't catching before. Also, it catches
4522 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4523 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4524 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4525
c9d624c6
PE
4526 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4527 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4528 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4529
353032ce
PE
4530 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4531
2bccce07
PE
4532 * alloc.c (Fmake_string): Check for out-of-range init.
4533
0ac30604
SM
45342011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4535
4536 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4537
c195f2de
JD
45382011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4539
4540 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4541 xg_get_default_scrollbar_width.
4542
4543 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4544 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4545 (style_changed_cb): Call update_theme_scrollbar_width and call
4546 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4547 all frames (Bug#8505).
4548 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4549 Call gtk_window_set_resizable if HAVE_GTK3.
4550 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4551 and height if HAVE_GTK3 (Bug#8505).
4552 (scroll_bar_width_for_theme): New variable.
4553 (update_theme_scrollbar_width): New function.
4554 (xg_get_default_scrollbar_width): Move code to
4555 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4556 (xg_initialize): Call update_theme_scrollbar_width.
4557
4558 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4559
4560 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4561
e10ac9f1
MR
45622011-06-12 Martin Rudalics <rudalics@gmx.at>
4563
4564 * frame.c (make_frame): Call other_buffer_safely instead of
4565 other_buffer.
4566
4567 * window.c (temp_output_buffer_show): Call display_buffer with
4568 second argument Vtemp_buffer_show_specifiers and reset latter
4569 immediately after the call.
4570 (Vtemp_buffer_show_specifiers): New variable.
4571 (auto_window_vscroll_p, next_screen_context_lines)
4572 (Vscroll_preserve_screen_position): Remove leading asterisks from
4573 doc-strings.
4574
2d3c217e 45752011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4576
7b7f97e8 4577 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4578 * buffer.c (Qclone_number): Remove for now, as it's unused.
4579 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4580 (record_buffer): Remove unused local.
4581 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4582 (set_frame_buffer_list): Remove; unused.
4583 * frame.h (other_visible_frames): Remove decl.
4584 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4585 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4586 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4587 if HAVE_GPM.
4588 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4589 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4590 Define only if HAVE_GPM.
4591 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4592 (update_hints_inhibit): Remove; never set. All uses removed.
4593 * widgetprv.h (emacsFrameClassRec): Remove decl.
4594 * window.c (delete_deletable_window): Now returns void, since it
4595 wasn't returning anything.
4596 (compare_window_configurations): Remove unused locals.
4597 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4598 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4599 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4600 the same widths as pointers. This follows up on the 2011-05-06 patch.
4601 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4602 * xterm.h: Likewise.
4603 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4604
1384b89e
JB
46052011-06-12 Juanma Barranquero <lekktu@gmail.com>
4606
4607 * makefile.w32-in: Update dependencies.
4608 (LISP_H): Add lib/intprops.h.
4609
1100a63c
CY
46102011-06-11 Chong Yidong <cyd@stupidchicken.com>
4611
4612 * image.c (gif_load): Add animation frame delay to the metadata.
4613 (syms_of_image): Use DEFSYM. New symbol `delay'.
4614
6198ccd0
MR
46152011-06-11 Martin Rudalics <rudalics@gmx.at>
4616
4617 * window.c (delete_deletable_window): Re-add.
4618 (Fset_window_configuration): Rewrite to handle dead buffers and
4619 consequently deletable windows.
4620 (window_tree, Fwindow_tree): Remove. Supply functionality in
4621 window.el.
4622 (compare_window_configurations): Simplify code.
4623
b6e3633c
AS
46242011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4625
1ab0dee5
AS
4626 * image.c (imagemagick_load_image): Fix type mismatch.
4627 (Fimagemagick_types): Likewise.
4628
b6e3633c
AS
4629 * window.h (replace_buffer_in_windows): Declare.
4630
9397e56f
MR
46312011-06-11 Martin Rudalics <rudalics@gmx.at>
4632
4633 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4634 Qclone_number. Remove external declaration of Qdelete_window.
4635 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4636 code.
640c8776
SM
4637 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4638 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4639 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4640 buffer list implementation.
4641 (other_buffer_safely): New function.
4642 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4643 calls to replace_buffer_in_windows and
4644 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4645 if allowed.
4646 (record_buffer): Inhibit quitting and rewrite using quittable
4647 functions. Run Qbuffer_list_update_hook if allowed.
4648 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4649 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4650 Move switch-to-buffer to window.el.
9397e56f
MR
4651 (bury-buffer): Move to window.el.
4652 (Vbuffer_list_update_hook): New variable.
4653
4654 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4655 section.
4656
4657 * window.h (resize_frame_windows): Move up in code.
4658 (Fwindow_frame): Remove EXFUN.
4659 (replace_buffer_in_all_windows): Remove prototype.
4660 (replace_buffer_in_windows_safely): Add prototype.
4661
4662 * window.c: Declare Qdelete_window static again. Move down
4663 declaration of select_count.
4664 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4665 (Fother_window): Move to window.el.
4666 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4667 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4668 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4669 window.el.
4670 (replace_buffer_in_windows): Implement by calling
4671 Qreplace_buffer_in_windows.
4672 (replace_buffer_in_all_windows): Remove with some functionality
4673 moved into replace_buffer_in_windows_safely.
4674 (replace_buffer_in_windows_safely): New function.
4675 (select_window_norecord, select_frame_norecord): Move in front
4676 of run_window_configuration_change_hook. Remove now obsolete
4677 declarations.
640c8776
SM
4678 (Fset_window_buffer): Rewrite doc-string.
4679 Call Qrecord_window_buffer.
9397e56f
MR
4680 (keys_of_window): Move binding for other-window to window.el.
4681
b50691aa
CY
46822011-06-11 Chong Yidong <cyd@stupidchicken.com>
4683
4684 * dispextern.h (struct image): Replace data member, whose int_val
4685 and ptr_val fields were not used by anything, with a single
4686 lisp_val object.
4687
4688 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4689 (gif_clear_image, gif_load, imagemagick_load_image)
4690 (gs_clear_image, gs_load): Callers changed.
4691
3f754b86
PE
46922011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4693
cca69397
PE
4694 * buffer.h: Include <time.h>, for time_t.
4695 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4696
109e28d0
PE
4697 Fix minor problems found by static checking.
4698
60737f02
PE
4699 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4700
4b66faf3
PE
4701 Make identifiers static if they are not used in other modules.
4702 * data.c (Qcompiled_function, Qframe, Qvector):
4703 * image.c (QimageMagick, Qsvg):
4704 * minibuf.c (Qmetadata):
4705 * window.c (resize_window_check, resize_root_window): Now static.
4706 * window.h (resize_window_check, resize_root_window): Remove decls.
4707
109e28d0
PE
4708 * window.c (window_deletion_count, delete_deletable_window):
4709 Remove; unused.
46a4ce9e
PE
4710 (window_body_lines): Now static.
4711 (Fdelete_other_windows_internal): Mark vars as initialized.
4712 Make sure 'resize_failed' is initialized.
4713 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4714 (resize_window_apply): Remove unused local.
4715 * window.h (delete_deletable_window): Remove decl.
4716
109e28d0 4717 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4718 (imagemagick_load_image): Fix pointer signedness problem by changing
4719 last arg from unsigned char * to char *. All uses changed.
4720 Also, fix a local for similar reasons.
4721 Remove unused locals. Remove locals to avoid shadowing.
4722 (fn_rsvg_handle_free): Remove; unused.
4723 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4724 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4725
3f754b86
PE
4726 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4727
2547adb1
CY
47282011-06-10 Chong Yidong <cyd@stupidchicken.com>
4729
4730 * image.c (gif_load): Fix omitted cast error introduced by
4731 2011-06-06 change.
4732
2c8e37d4
MR
47332011-06-10 Martin Rudalics <rudalics@gmx.at>
4734
4735 * window.h (resize_proportionally, orig_total_lines)
4736 (orig_top_line): Remove from window structure.
4737 (set_window_height, set_window_width, change_window_heights)
4738 (Fdelete_window): Remove prototypes.
4739 (resize_frame_windows): Remove duplicate declaration.
4740
440a42e3
EZ
47412011-06-10 Eli Zaretskii <eliz@gnu.org>
4742
4743 * window.h (resize_frame_windows, resize_window_check)
4744 (delete_deletable_window, resize_root_window)
4745 (resize_frame_windows): Declare prototypes.
4746
4747 * window.c (resize_window_apply): Make definition be "static" to
4748 match the prototype.
4749
562dd5e9
MR
47502011-06-10 Martin Rudalics <rudalics@gmx.at>
4751
4752 * window.c: Remove declarations of Qwindow_size_fixed,
4753 window_min_size_1, window_min_size_2, window_min_size,
4754 size_window, window_fixed_size_p, enlarge_window, delete_window.
4755 Remove static from declaration of Qdelete_window, it's
4756 temporarily needed by Fbury_buffer.
4757 (replace_window): Don't assign orig_top_line and
4758 orig_total_lines.
4759 (Fdelete_window, delete_window): Remove. Window deletion is
4760 handled by window.el.
640c8776
SM
4761 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4762 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4763 (Fdelete_other_windows): Remove. Deleting other windows is
4764 handled by window.el.
4765 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4766 handled in window.el.
4767 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4768 Window minimum sizes are handled in window.el.
4769 (shrink_windows, size_window, set_window_height)
4770 (set_window_width, change_window_heights, window_height)
4771 (window_width, CURBEG, CURSIZE, enlarge_window)
4772 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4773 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4774 handled in window.el.
4775 (make_dummy_parent): Rename to make_parent_window and give it a
4776 second argument horflag.
4777 (make_window): Don't set resize_proportionally any more.
4778 (Fsplit_window): Remove. Windows are split in window.el.
4779 (save_restore_action, save_restore_orig_size)
4780 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4781 Resize mini windows in window.el.
4782 (grow_mini_window, shrink_mini_window): Implement by calling
4783 Qresize_root_window_vertically, resize_window_check and
4784 resize_window_apply.
640c8776
SM
4785 (saved_window, Fset_window_configuration, save_window_save):
4786 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4787 resize_proportionally.
4788 (window_min_height, window_min_width): Move to window.el.
4789 (keys_of_window): Move bindings for delete-other-windows,
4790 split-window, delete-window and enlarge-window to window.el.
4791
4792 * buffer.c: Temporarily extern Qdelete_window.
4793 (Fbury_buffer): Temporarily call Qdelete_window instead of
4794 Fdelete_window (Fbury_buffer will move to window.el soon).
4795
4796 * frame.c (set_menu_bar_lines_1): Remove code handling
4797 orig_top_line and orig_total_lines.
4798
4799 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4800 set_window_height but set heights directly.
4801 (change_frame_size_1): Use resize_frame_windows.
4802
4803 * xdisp.c (init_xdisp): Don't use set_window_height but set
4804 heights directly.
4805
640c8776
SM
4806 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4807 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4808 run_window_configuration_change_hook.
4809
4810 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4811 instead of change_window_heights and run
4812 run_window_configuration_change_hook.
4813
1a13852e
MR
48142011-06-09 Martin Rudalics <rudalics@gmx.at>
4815
4816 * window.c (replace_window): Rename second argument REPLACEMENT to
4817 NEW. New third argument SETFLAG. Rewrite.
4818 (delete_window, make_dummy_parent): Call replace_window with
4819 third argument 1.
4820 (window_list_1): Move down in code.
4821 (run_window_configuration_change_hook): Move set_buffer part
4822 before select_frame_norecord part in order to unwind correctly.
4823 Rename count1 to count.
4824 (recombine_windows, delete_deletable_window, resize_root_window)
4825 (Fdelete_other_windows_internal)
4826 (Frun_window_configuration_change_hook, make_parent_window)
4827 (resize_window_check, resize_window_apply, Fresize_window_apply)
4828 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4829 (Fdelete_window_internal, Fresize_mini_window_internal):
4830 New functions.
1a13852e
MR
4831 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4832
f3d1777e
MR
48332011-06-08 Martin Rudalics <rudalics@gmx.at>
4834
496e208e
MR
4835 * window.h (window): Add some new members to window structure -
4836 normal_lines, normal_cols, new_total, new_normal, clone_number,
4837 splits, nest, prev_buffers, next_buffers.
4838 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4839 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4840
f3d1777e
MR
4841 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4842 Remove.
496e208e
MR
4843 (make_dummy_parent): Set new members of windows structure.
4844 (make_window): Move down in code. Handle new members of window
4845 structure.
4846 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4847 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4848 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4849 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4850 (Fset_window_next_buffers, Fset_window_clone_number):
4851 New functions.
496e208e
MR
4852 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4853 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4854 Doc-string fixes.
4855 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4856 Argument WINDOW can be now internal window too.
4857 (Fwindow_use_time): Move up in code.
4858 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4859 Rewrite doc-string.
4860 (Fset_window_configuration, saved_window)
4861 (Fcurrent_window_configuration, save_window_save): Handle new
4862 members of window structure.
b9e809c2
MR
4863 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4864 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4865 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4866 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4867 Qget_mru_window, Qresize_root_window,
4868 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4869 Qauto_buffer_name; staticpro them.
f3d1777e 4870
abde8f8c
MR
48712011-06-07 Martin Rudalics <rudalics@gmx.at>
4872
4873 * window.c (Fwindow_total_size, Fwindow_left_column)
4874 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4875 (Fwindow_list_1): New functions.
4876 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4877 (Fwindow_width, Fscroll_left, Fscroll_right):
4878 Use window_body_cols instead of window_box_text_cols.
4879 (delete_window, Fset_window_configuration):
4880 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4881 (delete_all_subwindows): Take a window as argument and not a
4882 structure. Rewrite.
190b47e6
MR
4883 (window_loop): Remove handling of GET_LRU_WINDOW and
4884 GET_LARGEST_WINDOW.
4885 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4886
4887 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4888 window_box_text_cols. delete_all_subwindows now takes a
4889 Lisp_Object as argument.
abde8f8c 4890
640c8776
SM
4891 * indent.c (compute_motion, Fcompute_motion):
4892 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4893
fa8a67e6
MR
4894 * frame.c (delete_frame): Call delete_all_subwindows with root
4895 window as argument.
4896
a54e3482
DC
48972011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4898
4899 * fns.c (Fputhash): Document return value.
4900
60002bf5
CY
49012011-06-06 Chong Yidong <cyd@stupidchicken.com>
4902
4903 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4904
0c671da6 49052011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4906
b862a52a 4907 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4908
be44ca6c
PE
4909 Check for overflow when converting integer to cons and back.
4910 * charset.c (Fdefine_charset_internal, Fdecode_char):
4911 Use cons_to_unsigned to catch overflow.
4912 (Fencode_char): Use INTEGER_TO_CONS.
4913 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4914 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4915 * data.c (long_to_cons, cons_to_long): Remove.
4916 (cons_to_unsigned, cons_to_signed): New functions.
4917 These signal an error for invalid or out-of-range values.
4918 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4919 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4920 * font.c (Ffont_variation_glyphs):
4921 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4922 * lisp.h: Include <intprops.h>.
4923 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4924 (cons_to_signed, cons_to_unsigned): New decls.
4925 (long_to_cons, cons_to_long): Remove decls.
4926 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4927 (Fprimitive_undo): Use CONS_TO_INTEGER.
4928 * xfns.c (Fx_window_property): Likewise.
4929 * xselect.c: Include <limits.h>.
4930 (x_own_selection, selection_data_to_lisp_data):
4931 Use INTEGER_TO_CONS.
4932 (x_handle_selection_request, x_handle_selection_clear)
4933 (x_get_foreign_selection, Fx_disown_selection_internal)
4934 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4935 (lisp_data_to_selection_data): Use cons_to_unsigned.
4936 (x_fill_property_data): Use cons_to_signed.
4937 Report values out of range.
4938
d1f3d2af
PE
4939 Check for buffer and string overflow more precisely.
4940 * buffer.h (BUF_BYTES_MAX): New macro.
4941 * lisp.h (STRING_BYTES_MAX): New macro.
4942 * alloc.c (Fmake_string):
4943 * character.c (string_escape_byte8):
4944 * coding.c (coding_alloc_by_realloc):
4945 * doprnt.c (doprnt):
4946 * editfns.c (Fformat):
4947 * eval.c (verror):
4948 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4949 since they may not be the same number.
4950 * editfns.c (Finsert_char):
4951 * fileio.c (Finsert_file_contents):
4952 Likewise for BUF_BYTES_MAX.
4953
dd52fcea
PE
4954 * image.c: Use ptrdiff_t, not int, for sizes.
4955 (slurp_file): Switch from int to ptrdiff_t.
4956 All uses changed.
4957 (slurp_file): Check that file size fits in both size_t (for
4958 malloc) and ptrdiff_t (for sanity and safety).
4959
7f9bbdbb
PE
4960 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4961 if b->modtime has its maximal value.
4962
dfe18f82
PE
4963 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4964
84acfcf0
PE
4965 Don't assume time_t can fit into int.
4966 * buffer.h (struct buffer.modtime): Now time_t, not int.
4967 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4968 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4969
ccd9a01a
PE
4970 Minor fixes for signed vs unsigned integers.
4971 * character.h (MAYBE_UNIFY_CHAR):
4972 * charset.c (maybe_unify_char):
4973 * keyboard.c (read_char, reorder_modifiers):
4974 XINT -> XFASTINT, since the integer must be nonnegative.
4975 * ftfont.c (ftfont_spec_pattern):
4976 * keymap.c (access_keymap, silly_event_symbol_error):
4977 XUINT -> XFASTINT, since the integer must be nonnegative.
4978 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4979 since it makes no difference and we prefer signed.
4980 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4981 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4982 nonnegative.
4983
d6d100dd
SM
49842011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4985
4986 * window.h (Fwindow_frame): Declare.
4987
2b6148e4
PE
49882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4989
4990 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4991 (SPARE_MEMORY): Always define.
4992 (LARGE_REQUEST): Remove.
4993 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4994
f230ecc9
MR
49952011-06-06 Martin Rudalics <rudalics@gmx.at>
4996
727e958e
MR
4997 * lisp.h: Move EXFUNS for Fframe_root_window,
4998 Fframe_first_window and Fset_frame_selected_window to window.h.
4999
5000 * window.h: Move EXFUNS for Fframe_root_window,
5001 Fframe_first_window and Fset_frame_selected_window here from
5002 lisp.h.
5003
5004 * frame.c (Fwindow_frame, Fframe_first_window)
5005 (Fframe_root_window, Fframe_selected_window)
5006 (Fset_frame_selected_window): Move to window.c.
5007 (Factive_minibuffer_window): Move to minibuf.c.
5008 (Fother_visible_frames_p): New function.
5009
5010 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5011
f230ecc9
MR
5012 * window.c (decode_window, decode_any_window): Move up in code.
5013 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5014 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5015 (Fwindow_buffer): Move up and rewrite doc-string.
5016 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5017 (Fwindow_prev): New functions.
727e958e
MR
5018 (Fwindow_frame): Move here from frame.c. Accept any window as
5019 argument.
5020 (Fframe_root_window, Fframe_first_window)
5021 (Fframe_selected_window): Move here from frame.c. Accept frame
5022 or arbitrary window as argument. Update doc-strings.
5023 (Fminibuffer_window): Move up in code.
5024 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5025 (Fset_frame_selected_window): Move here from frame.c.
5026 Marginal rewrite.
727e958e
MR
5027 (Fselected_window, select_window, Fselect_window): Move up in
5028 code. Minor doc-string fixes.
f230ecc9 5029
4d09bcf6
PE
50302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5031
5032 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5033 Do not assume that spare memory exists; that assumption is valid
5034 only if SYSTEM_MALLOC.
5035 (LARGE_REQUEST): New macro, so that the issue of large requests
5036 is separated from the issue of spare memory.
5037
810928a2
AS
50382011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5039
172418ad
AS
5040 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5041 format. (Bug#8806)
5042
43f862f7
AS
5043 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5044
810928a2
AS
5045 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5046 before statements.
5047
a059fe24
JD
50482011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5049
5050 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5051
5052 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5053
5054 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5055 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5056
989bf368
JB
50572011-06-05 Juanma Barranquero <lekktu@gmail.com>
5058
5059 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5060
4b80f674
CY
50612011-06-04 Chong Yidong <cyd@stupidchicken.com>
5062
5063 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5064 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5065 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5066 New error handlers.
4b80f674
CY
5067 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5068 Obey Vx_select_enable_clipboard_manager. Catch errors in
5069 x_clipboard_manager_save (Bug#8779).
5070 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5071 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5072
99a33b77 50732011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5074
5075 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5076
99a33b77 50772011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5078
5079 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5080 in the current matrix if keep_current_p is non-zero.
5081
8264569d
EZ
50822011-06-04 Eli Zaretskii <eliz@gnu.org>
5083
5084 * bidi.c (bidi_level_of_next_char): Fix last change.
5085
57f97249
EZ
50862011-06-03 Eli Zaretskii <eliz@gnu.org>
5087
fec2107c 5088 Support bidi reordering of text covered by display properties.
57f97249 5089
fec2107c
EZ
5090 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5091 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5092 (bidi_cache_search, bidi_cache_iterator_state)
5093 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5094 (bidi_level_of_next_char, bidi_move_to_visually_next):
5095 Support character positions inside a run of characters covered by a
fec2107c
EZ
5096 display string.
5097 (bidi_paragraph_init, bidi_resolve_explicit_1)
5098 (bidi_level_of_next_char): Call bidi_fetch_char and
5099 bidi_fetch_char_advance instead of FETCH_CHAR and
5100 FETCH_CHAR_ADVANCE.
5101 (bidi_init_it): Initialize new members.
5102 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5103 definitions.
5104 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5105 instead of using explicit *_CHAR codes.
d6d100dd
SM
5106 (bidi_resolve_explicit, bidi_resolve_weak):
5107 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5108 bidirectional text is supported only in multibyte buffers.
5109 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5110 it to initialize the frame_window_p member of struct bidi_it.
5111 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5112 (bidi_resolve_explicit, bidi_resolve_weak)
5113 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5114 bidi_it->nchars is non-positive.
5115 (bidi_level_of_next_char): Don't try to lookup the cache for the
5116 next/previous character if nothing is cached there yet, or if we
5117 were just reseat()'ed to a new position.
c40e2fb2 5118
0e14fe90
EZ
5119 * xdisp.c (set_cursor_from_row): Set start and stop points
5120 according to the row's direction when priming the loop that looks
5121 for the glyph on which to display cursor.
5122 (single_display_spec_intangible_p): Function deleted.
5123 (display_prop_intangible_p): Reimplement to call
5124 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5125 Accept 3 additional arguments needed by handle_display_spec.
5126 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5127 values: lists, `(when COND...)' forms, etc.
5128 (single_display_spec_string_p): Support property values that are
5129 lists with the argument STRING its top-level element.
5130 (display_prop_string_p): Fix the condition for processing a
5131 property that is a list to be consistent with handle_display_spec.
fec2107c 5132 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5133 last portion of handle_display_prop.
5134 (compute_display_string_pos): Accept additional argument
5135 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5136 value of a `display' property is a "replacing spec".
5137 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5138 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5139 the display property, but just return a value indicating whether
5140 the display property will replace the characters it covers.
5141 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5142 frame_window_p members of struct bidi_it.
d6d100dd
SM
5143 (compute_display_string_pos, compute_display_string_end):
5144 New functions.
fec2107c
EZ
5145 (push_it): Accept second argument POSITION, where pop_it should
5146 jump to continue iteration.
5147 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5148
fec2107c
EZ
5149 * keyboard.c (adjust_point_for_property): Adjust the call to
5150 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5151
5152 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5153 (bidi_init_it): Update prototypes.
5154 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5155 (compute_display_string_pos, compute_display_string_end):
5156 Declare prototypes.
fec2107c
EZ
5157 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5158 EMACS_INT.
fc6f18ce 5159
40087514 51602011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5161
57f53182
PE
5162 Malloc failure behavior now depends on size of allocation.
5163 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5164 * lisp.h: Change signatures accordingly.
5165 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5166 All callers changed. (Bug#8762)
5167
5168 * gnutls.c: Use Emacs's memory allocators.
5169 Without this change, the gnutls library would invoke malloc etc.
5170 directly, which causes problems on non-SYNC_INPUT hosts, and which
5171 runs afoul of improving memory_full behavior. (Bug#8761)
5172 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5173 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5174 xfree instead of the default malloc, realloc, free.
5175 (Fgnutls_boot): No need to check for memory allocation failure,
5176 since xmalloc does that for us.
5177
ac32cd99 5178 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5179 * category.c (hash_get_category_set):
5180 * ccl.c (ccl_driver):
5181 * charset.c (Fdefine_charset_internal):
5182 * charset.h (struct charset.hash_index):
5183 * composite.c (get_composition_id, gstring_lookup_cache)
5184 (composition_gstring_put_cache):
5185 * composite.h (struct composition.hash_index):
5186 * dispextern.h (struct image.hash):
5187 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5188 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5189 (hashfn_equal, hashfn_user_defined, make_hash_table)
5190 (maybe_resize_hash_table, hash_lookup, hash_put)
5191 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5192 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5193 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5194 * image.c (make_image, search_image_cache, lookup_image)
5195 (xpm_put_color_table_h):
5196 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5197 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5198 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5199 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5200 * alloc.c (allocate_vectorlike):
5201 Check for overflow in vector size calculations.
5202 * ccl.c (ccl_driver):
5203 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5204 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5205 need to be updated by these changes.
40087514
PE
5206 * fns.c (make_hash_table, maybe_resize_hash_table):
5207 Check for integer overflow with large hash tables.
0de4bb68
PE
5208 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5209 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5210 (SXHASH_REDUCE): New macro.
5211 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5212 Use it instead of discarding useful hash info with large hash values.
5213 (sxhash_float): New function.
5214 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5215 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5216 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5217 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5218 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5219 Adjust signatures to match updated version of code.
5220 (consing_since_gc): Now EMACS_INT, since a single hash table can
5221 use more than INT_MAX bytes.
5222
698d32e2
DN
52232011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5224
5225 Make it possible to build with GCC-4.6+ -O2 -flto.
5226
5227 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5228
fd6fa53f
SM
52292011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5230
5231 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5232 Call minibuffer-inactive-mode.
5233
864db017
JB
52342011-05-31 Juanma Barranquero <lekktu@gmail.com>
5235
5236 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5237 Update dependencies.
5238
2ad0baf4
DN
52392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5240
5241 * data.c (init_data): Remove code for UTS, this system is not
5242 supported anymore.
5243
4fcc2638
DN
52442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5245
5246 Don't force ./temacs to start in terminal mode.
5247
5248 * frame.c (make_initial_frame): Initialize faces in all cases, not
5249 only when CANNOT_DUMP is defined.
5250 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5251
c56e0fd5
DN
52522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5253
5254 * dispnew.c (add_window_display_history): Use const for the string
5255 pointer. Remove declaration, not needed.
5256
333d54da 52572011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5258
55d4c1b2 5259 Use 'inline', not 'INLINE'.
333d54da 5260 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5261 * alloc.c, fontset.c (INLINE): Remove.
5262 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5263 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5264 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5265 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5266 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5267
738db178
DN
52682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5269
5270 Make it possible to run ./temacs.
5271
5272 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5273 syms_of_callproc does the same thing. Remove test for
5274 "initialized", do it in the caller.
5275 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5276
620c53a6
SM
52772011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5278
5279 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5280 (read_minibuf): Use get_minibuffer.
5281 (syms_of_minibuf): Use DEFSYM.
5282 (Qmetadata): New var.
5283 * data.c (Qbuffer): Don't make it static.
5284 (syms_of_data): Use DEFSYM.
5285
e003a292
PE
52862011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5287
5288 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5289 (CCL_CODE_MIN): New macro.
5290
ed008a6d
PE
52912011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5292
3687c2ef
PE
5293 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5294
ed008a6d
PE
5295 * eval.c (Qdebug): Now static.
5296 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5297 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5298 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5299
d66c4c7c
CY
53002011-05-29 Chong Yidong <cyd@stupidchicken.com>
5301
5302 * image.c: Various fixes to ImageMagick code comments.
5303 (Fimagemagick_types): Doc fix.
5304
5fbc2025
PE
53052011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5306
0196f88a
PE
5307 Minor fixes prompted by GCC 4.6.0 warnings.
5308
5309 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5310
5fbc2025
PE
5311 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5312 (x_clipboard_manager_save_all): Move extern decl to ...
5313 * xterm.h: ... here, so that it can be checked for consistency.
5314
1dd3c2d9
CY
53152011-05-29 Chong Yidong <cyd@stupidchicken.com>
5316
5317 * xselect.c (x_clipboard_manager_save_frame)
5318 (x_clipboard_manager_save_all): New functions.
5319 (Fx_clipboard_manager_save): Lisp function deleted.
5320
5321 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5322 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5323
5324 * xterm.h: Update prototype.
5325
5ba6571d
WX
53262011-05-28 William Xu <william.xwl@gmail.com>
5327
5328 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5329 exiting (Bug#8239).
5330
3eaff834
JM
53312011-05-28 Jim Meyering <meyering@redhat.com>
5332
e1900994 5333 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5334 * fns.c (to_uchar): Define.
5335 (crypto_hash_function): Use it to convert some newly-signed
5336 variables to unsigned, to avoid sign-extension bugs. For example,
5337 without this change, (md5 "truc") would evaluate to
5338 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5339 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5340 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5341
0f6990a7
PE
53422011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5343
5344 Integer overflow fixes.
c8a9ca5a 5345
08686060
PE
5346 * dbusbind.c: Serial number integer overflow fixes.
5347 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5348 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5349 to hold a serial number that is too large for a fixnum.
5350 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5351 Check for serial numbers out of range. Decode any serial number
59568bf0 5352 that was so large that it became a float. (Bug#8722)
08686060 5353
2d1fc3c7
PE
5354 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5355 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5356 Use XFASTINT rather than XUINT when numbers are nonnegative.
5357 (xd_append_arg, Fdbus_method_return_internal):
5358 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5359 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5360 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5361 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5362 (Bug#8722)
2d1fc3c7 5363
c8a9ca5a
PE
5364 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5365
519e1d69
PE
5366 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5367
30569699
PE
5368 ccl: add integer overflow checks
5369 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5370 (IN_INT_RANGE): New macros.
5371 (ccl_driver): Use them to check for integer overflow when
5372 decoding a CCL program. Many of the new checks are whether XINT (x)
5373 fits in int; it doesn't always, on 64-bit hosts. The new version
5374 doesn't catch all possible integer overflows, but it's an
847044ea 5375 improvement. (Bug#8719)
30569699 5376
c11285dc
PE
5377 * alloc.c (make_event_array): Use XINT, not XUINT.
5378 There's no need for unsigned here.
5379
fdccd48e
PE
5380 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5381 This follows up to the 2011-05-06 change that substituted uintptr_t
5382 for EMACS_INT. This case wasn't caught back then.
5383
37910ab2
PE
5384 Rework Fformat to avoid integer overflow issues.
5385 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5386 now (part of C89). Include <verify.h>.
5387 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5388 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5389 (Fformat): Avoid the prepass trying to compute sizes; it was only
5390 approximate and thus did not catch overflow reliably. Instead, walk
5391 through the format just once, formatting and computing sizes as we go,
5392 checking for integer overflow at every step, and allocating a larger
5393 buffer as needed. Keep track separately whether the format is
5394 multibyte. Keep only the most-recently calculated precision, rather
5395 than them all. Record whether each argument has been converted to
5396 string. Use EMACS_INT, not int, for byte and char and arg counts.
5397 Support field widths and precisions larger than INT_MAX. Avoid
5398 sprintf's undefined behavior with conversion specifications such as %#d
5399 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5400 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5401 formatting out-of-range floating point numbers with int
9173deec 5402 formats. (Bug#8668)
37910ab2 5403
2e6578fb
PE
5404 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5405
0ae6bdee
PE
5406 * data.c: Avoid integer truncation in expressions involving floats.
5407 * data.c: Include <intprops.h>.
5408 (arith_driver): When there's an integer overflow in an expression
5409 involving floating point, convert the integers to floating point
5410 so that the resulting value does not suffer from catastrophic
5411 integer truncation. For example, on a 64-bit host (* 4
5412 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5413 Do not rely on undefined behavior after integer overflow.
5414
de883a70
PE
5415 merge count_size_as_multibyte, parse_str_to_multibyte
5416 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5417 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5418 Check for integer overflow.
5419 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5420 since it's now a duplicate of the other. This is more of
5421 a character than a buffer op, so better that it's in character.c.
5422 * fns.c, print.c: Adjust to above changes.
5423
2ff916cb
PE
54242011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5425
5426 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5427
f1b54466
PE
54282011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5429
fb1ac845
PE
5430 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5431 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5432 (x_clipboard_manager_save): Now static.
5433 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5434
f1b54466
PE
5435 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5436 (crypto_hash_function): Now static.
5437 Fix pointer signedness problems. Avoid unnecessary initializations.
5438
a9f737ee
CY
54392011-05-27 Chong Yidong <cyd@stupidchicken.com>
5440
5441 * termhooks.h (Vselection_alist): Make it terminal-local.
5442
5443 * terminal.c (create_terminal): Initialize it.
5444
5445 * xselect.c: Support for clipboard managers.
5446 (Vselection_alist): Move to termhooks.h as terminal-local var.
5447 (LOCAL_SELECTION): New macro.
5448 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5449 (symbol_to_x_atom): Remove gratuitous arg.
5450 (x_handle_selection_request, lisp_data_to_selection_data)
5451 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5452 (x_own_selection, x_get_local_selection, x_convert_selection):
5453 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5454 (some_frame_on_display): Delete unused function.
5455 (Fx_own_selection_internal, Fx_get_selection_internal)
5456 (Fx_disown_selection_internal, Fx_selection_owner_p)
5457 (Fx_selection_exists_p): New optional frame arg.
5458 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5459 (x_handle_selection_clear): Don't treat other terminals with the
5460 same keyboard specially. Use the terminal-local Vselection_alist.
5461 (x_clear_frame_selections): Use Frun_hook_with_args.
5462
5463 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5464
5465 * xterm.h: Add support for those atoms.
5466
e067f0c1
CY
54672011-05-26 Chong Yidong <cyd@stupidchicken.com>
5468
5469 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5470 (converted_selections, conversion_fail_tag): New global variables.
5471 (x_selection_request_lisp_error): Free the above.
5472 (x_get_local_selection): Remove unnecessary code.
5473 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5474 of converted selections stored in converted_selections.
5475 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5476 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5477 (x_convert_selection): New function.
5478 (x_handle_selection_event): Simplify.
5479 (x_get_foreign_selection): Don't ignore incoming requests while
5480 waiting for an answer; this will fail when we implement
5481 SAVE_TARGETS, and seems unnecessary anyway.
5482 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5483 (Vx_sent_selection_functions): Doc fix.
5484
0f4aebc0
LL
54852011-05-26 Leo Liu <sdl.web@gmail.com>
5486
5487 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5488
e61124cd
YM
54892011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5490
5491 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5492
5493 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5494 for fringe update if it has periodic bitmap.
ac389d0c 5495 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5496 and fringe_bitmap_periodic_p.
5497
5498 * fringe.c (get_fringe_bitmap_data): New function.
5499 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5500 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5501 row. Mark glyph row for fringe update if periodicity changed.
5502
5503 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5504 for fringe update unless it has periodic bitmap.
5505
f16d9837
KH
55062011-05-25 Kenichi Handa <handa@m17n.org>
5507
5508 * xdisp.c (get_next_display_element): Set correct it->face_id for
5509 a static composition.
5510
e1b90ef6
LL
55112011-05-24 Leo Liu <sdl.web@gmail.com>
5512
5513 * deps.mk (fns.o):
5514 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5515
5516 * fns.c (crypto_hash_function, Fsha1): New function.
5517 (Fmd5): Use crypto_hash_function.
5518 (syms_of_fns): Add Ssha1.
5519
7400048f
PE
55202011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5521
5522 * gnutls.c: Remove unused macros.
5523 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5524 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5525 Remove macros that are defined and never used.
5526 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5527
abb71cf4
CY
55282011-05-22 Chong Yidong <cyd@stupidchicken.com>
5529
5530 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5531 (Fx_get_selection_internal): Minor cleanup.
5532 (Fx_own_selection_internal): Rename arguments for consistency with
5533 select.el.
5534
6307db39
PE
55352011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5536
5537 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5538
f3d4e0a4
CY
55392011-05-22 Chong Yidong <cyd@stupidchicken.com>
5540
5541 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5542
4d8ade89
YM
55432011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5544
5545 * dispnew.c (scrolling_window): Don't exclude the case that the
5546 last enabled row in the desired matrix touches the bottom boundary.
5547
32078c8d
GM
55482011-05-21 Glenn Morris <rgm@gnu.org>
5549
5550 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5551 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5552 and add some more files.
32078c8d 5553
7285dc67
EZ
55542011-05-20 Eli Zaretskii <eliz@gnu.org>
5555
5556 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5557 report_file_error introduced by the change from 2011-05-07.
5558
89d1bd22
PE
55592011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5560
5561 * systime.h (Time): Define only if emacs is defined.
5562 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5563 where the include path doesn't have X11/X.h by default. See
5564 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5565
e23640bb 55662011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5567
5568 * composite.c (find_automatic_composition): Fix previous change.
5569
b9704ad9
GM
55702011-05-20 Glenn Morris <rgm@gnu.org>
5571
5572 * lisp.mk: New file, split from Makefile.in.
5573 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5574 (shortlisp): Remove.
5575 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5576
4a720484
GM
55772011-05-19 Glenn Morris <rgm@gnu.org>
5578
5579 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5580 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5581 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5582 (lisp): Set the order to that of loadup.el.
5583 (shortlisp): Make it a copy of $lisp.
5584 (SOME_MACHINE_LISP): Remove.
5585 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5586 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5587
a28d4396
KH
55882011-05-18 Kenichi Handa <handa@m17n.org>
5589
5590 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5591 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5592 (find_automatic_composition): Mostly rewrite for efficiency.
5593
a2b1fa8e
JB
55942011-05-18 Juanma Barranquero <lekktu@gmail.com>
5595
5596 * makefile.w32-in: Update dependencies.
5597
8e1f5610
CS
55982011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5599
5600 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5601 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5602
7025ee00 56032011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5604
cdfa6eab
PE
5605 Fix some integer overflow issues, such as string length overflow.
5606
06d6db33
PE
5607 * insdel.c (count_size_as_multibyte): Check for string overflow.
5608
2b4560a8
PE
5609 * character.c (lisp_string_width): Check for string overflow.
5610 Use EMACS_INT, not int, for string indexes and lengths; in
5611 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5612 the resulting string length overflows an EMACS_INT; instead,
5613 report a string overflow if no precision given. When checking for
5614 precision exhaustion, use a check that cannot possibly have
5615 integer overflow. (Bug#8675)
5616 * character.h (lisp_string_width): Adjust to new signature.
5617
cb93f9be
PE
5618 * alloc.c (string_overflow): New function.
5619 (Fmake_string): Use it. This doesn't change behavior, but saves
5620 a few bytes and will simplify future changes.
5621 * character.c (string_escape_byte8): Likewise.
5622 * lisp.h (string_overflow): New decl.
5623
1a1f3366
PE
5624 Fixups, following up to the user-interface timestamp change.
5625 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5626 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5627 * msdos.c (mouse_get_pos): Likewise.
5628 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5629 * w32gui.h (Time): Define by including "systime.h" rather than by
5630 declaring it ourselves. (Bug#8664)
5631
d4e3e4d3
PE
5632 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5633 * image.c (clear_image_cache): Likewise.
5634
f6a24d19
PE
5635 * term.c (term_mouse_position): Don't assume time_t wraparound.
5636
08dc5ae6
PE
5637 Be more systematic about user-interface timestamps.
5638 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5639 and sometimes 'EMACS_UINT', to represent these timestamps.
5640 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5641 This makes the code easier to follow, and makes it easier to catch
5642 integer overflow bugs such as Bug#8664.
5643 * frame.c (Fmouse_position, Fmouse_pixel_position):
5644 Use Time, not unsigned long, for user-interface timestamps.
5645 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5646 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5647 * keyboard.h (last_event_timestamp): Likewise.
5648 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5649 * menu.h (xmenu_show): Likewise.
5650 * term.c (term_mouse_position): Likewise.
5651 * termhooks.h (struct input_event.timestamp): Likewise.
5652 (struct terminal.mouse_position_hook): Likewise.
5653 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5654 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5655 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5656 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5657 what it was before.
5658 * menu.h, termhooks.h: Include "systime.h", for Time.
5659
8e55734a
PE
5660 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5661 Don't assume that the difference between two unsigned long values
5662 can fit into an integer. At this point, we know button_down_time
5663 <= event->timestamp, so the difference must be nonnegative, so
5664 there's no need to cast the result if double-click-time is
5665 nonnegative, as it should be; check that it's nonnegative, just in
5666 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5667 apart (about 25 days). (Bug#8664)
8e55734a 5668
841f1b75 5669 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5670 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5671
3e26f69c
PE
5672 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5673 that always fit in int. Use a sentinel instead of a counter, to
5674 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5675 * frame.h (struct frame): Use int for menu_bar_items_used
5676 instead of EMACS_INT, since it always fits in int.
3e26f69c 5677
5cc152c0
PE
5678 * menu.c (grow_menu_items): Check for int overflow.
5679
d89eb65e
PE
5680 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5681
5235bd3e
PE
5682 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5683 Before, the code was not consistent. These values cannot exceed
5684 2**31 - 1 so there's no need to make them unsigned.
5685 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5686 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5687 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5688 as modifiers.
5689 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5690
bc827e23
PE
5691 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5692 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5693 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5694 presumably because the widths might not match.
5695
78eb494e
PE
5696 * window.c (size_window): Avoid needless test at loop start.
5697
04f2d78b
CB
56982011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5699
5700 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5701
d2fc7e3d 57022011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5703
5704 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5705
d2fc7e3d 57062011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5707
5708 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5709 `width' to `bar_area_x' and `bar_area_width', respectively.
5710 (x_scroll_run): Take account of fringe background extension.
5711
04f2d78b
CB
5712 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5713 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5714 `bar_area_width', respectively.
5715 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5716 background extension.
5717
79b70037
GM
57182011-05-10 Jim Meyering <meyering@redhat.com>
5719
5720 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5721
2f142cc5
JB
57222011-05-10 Juanma Barranquero <lekktu@gmail.com>
5723
5724 * image.c (Finit_image_library): Return t for built-in image types,
5725 like pbm and xbm. (Bug#8640)
5726
57679c86
AS
57272011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5728
5729 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5730
888c9e86
EZ
57312011-05-07 Eli Zaretskii <eliz@gnu.org>
5732
b0512a1d
EZ
5733 * w32console.c (Fset_screen_color): Doc fix.
5734 (Fget_screen_color): New function.
5735 (syms_of_ntterm): Defsubr it.
5736
7285dc67
EZ
5737 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5738 unlink the temporary file if Fcall_process didn't create it in the
5739 first place.
5740 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5741 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5742 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5743 cue to call_process_cleanup not to close that handle.
5744
4d3fcc8e
BK
57452011-05-07 Ben Key <bkey76@gmail.com>
5746
5747 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5748 one of two shell specific rules, either bootstrap-temacs-CMD or
5749 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5750 to the previous implementation of the bootstrap-temacs rule.
5751 The bootstrap-temacs-CMD rule is similar to the previous
5752 implementation of the bootstrap-temacs rule except that it
5753 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5754 variable.
5755
5756 These changes, along with some changes to nt/configure.bat,
5757 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5758 earlier fix to add support for --cflags and --ldflags options
5759 that include quotes so that it works whether make uses cmd or
5760 sh as the shell.
5761
b4289b64
MA
57622011-05-06 Michael Albinus <michael.albinus@gmx.de>
5763
5764 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5765 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5766 is a constant.
5767 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5768 a string. Handle both cases.
5769 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5770 (Fdbus_register_method): Use Qinvalid_function.
5771
af4c0e28
JB
57722011-05-06 Juanma Barranquero <lekktu@gmail.com>
5773
5774 * makefile.w32-in: Update dependencies.
5775 (LISP_H): Add inttypes.h and stdin.h.
5776 (PROCESS_H): Add unistd.h.
5777
c51453d9
EZ
57782011-05-06 Eli Zaretskii <eliz@gnu.org>
5779
5780 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5781 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5782
8ff0ac3c 57832011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5784
4c4b566b
PE
5785 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5786
aab2b9b5
PE
5787 * term.c (vfatal): Remove stray call to va_end.
5788 It's not needed and the C Standard doesn't allow it here anyway.
5789
c378da0b
PE
5790 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5791 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5792
288b08c7
PE
5793 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5794 bytes.
5795
e3601888
PE
5796 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5797
db6c0e74
PE
5798 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5799
dd5963ea
PE
5800 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5801
88c9450f
PE
5802 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5803
2f9442b8
PE
5804 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5805
c032b5f8
PE
5806 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5807 * charset.c (Fdefine_charset_internal): Don't initialize
5808 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5809 32-bit int (Bug#8600).
a108c10b
PE
5810
5811 * lread.c (read_integer): Be more consistent with string-to-number.
5812 Use string_to_number to do the actual conversion; this avoids
5813 rounding errors and fixes some other screwups. Without this fix,
5814 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5815 (digit_to_number): Move earlier, for benefit of read_integer.
5816 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5817 not a digit in any supported base. (Bug#8602)
a108c10b 5818
ad5f9eea
PE
5819 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5820
aec1708a
PE
5821 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5822 to match comment at start of function. This also removes a
5823 GCC warning about overflow in a 32+64-bit port.
5824
47be4ab5
PE
5825 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5826
371cac43
PE
5827 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5828 Reported by Stefan Monnier in
5829 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5830 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5831 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5832
d01a7826
PE
5833 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5834 (EMACS_UINTPTR): Likewise, with uintptr_t.
5835
7fd47d5c
PE
5836 * lisp.h: Prefer 64-bit EMACS_INT if available.
5837 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5838 on 32-bit hosts that have 64-bit int, so that they can access
5839 large files.
122b0c86
PE
5840 However, temporarily disable this change unless the temporary
5841 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5842
8727937b
PE
5843 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5844
8ac068ac
PE
5845 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5846 This removes an assumption that EMACS_INT and long are the same
5847 width as pointers. The assumption is true for Emacs porting targets
5848 now, but we want to make other targets possible.
5849 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5850 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5851 In the rest of the code, change types of integers that hold casted
5852 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5853 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5854 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5855 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5856 No need to cast type when ORing.
5857 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5858 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5859 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5860 assume EMACS_INT is the same width as char *.
5861 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5862 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5863 Remove no-longer-needed casts.
5864 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5865 (xg_tool_bar_help_callback, xg_make_tool_item):
5866 Use EMACS_INTPTR to hold an integer
5867 that will be cast to void *; this can avoid a GCC warning
5868 if EMACS_INT is not the same width as void *.
5869 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5870 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5871 (current_message_1, set_message_1):
5872 Use a local to convert to proper width without a cast.
5873 * xmenu.c (dialog_selection_callback): Likewise.
5874
ede49d71
PE
5875 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5876 Also, don't assume VALBITS / RAND_BITS is less than 5,
5877 and don't rely on undefined behavior when shifting a 1 left into
5878 the sign bit.
5879 * lisp.h (get_random): Change signature to match.
5880
2f30ecd0
PE
5881 * lread.c (hash_string): Use size_t, not int, for hash computation.
5882 Normally we prefer signed values; but hashing is special, because
5883 it's better to use unsigned division on hash table sizes so that
5884 the remainder is nonnegative. Also, size_t is the natural width
5885 for hashing into memory. The previous code used 'int', which doesn't
5886 retain enough info to hash well into very large tables.
5887 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5888
2a866e7b
PE
5889 * dbusbind.c: Don't possibly lose pointer info when converting.
5890 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5891 Use XPNTR rather than XHASH, so that the high-order bits of
5892 the pointer aren't lost when converting through void *.
5893
51639eac
PE
5894 * eval.c (Fautoload): Don't double-shift a pointer.
5895
92394119
PE
5896 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5897
dbdb9a7c
JB
58982011-05-06 Juanma Barranquero <lekktu@gmail.com>
5899
5900 * gnutls.c (DEF_GNUTLS_FN):
5901 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5902
db7a0b4f
AS
59032011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5904
5905 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5906 marker. (Bug#8610)
5907
f7ff1b0f 59082011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5909
5910 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5911 New version that can reserve upto 2GB of heap space.
5912
f7ff1b0f 59132011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5914
5915 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5916
639c109b
TZ
59172011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5918
5919 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5920 `gnutls_certificate_set_x509_key_file'.
5921
d2127135
JB
59222011-05-05 Juanma Barranquero <lekktu@gmail.com>
5923
5924 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5925 Update dependencies.
5926
e968f4f3
JB
59272011-05-04 Juanma Barranquero <lekktu@gmail.com>
5928
5929 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5930 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5931 Remove unused parameter `fildes'.
5932 * process.c (read_process_output, send_process): Don't pass it.
5933
84d358f0
JB
59342011-05-04 Juanma Barranquero <lekktu@gmail.com>
5935
5936 Fix previous change: the library cache is defined in w32.c.
5937 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5938 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5939
0898ca10
JB
59402011-05-04 Juanma Barranquero <lekktu@gmail.com>
5941
5942 Implement dynamic loading of GnuTLS on Windows.
5943
5944 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5945 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5946 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5947 Declare.
5948
5949 * gnutls.c (Qgnutls_dll): Define.
5950 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5951 (gnutls_*): Declare function pointers.
5952 (init_gnutls_functions): New function to initialize function pointers.
5953 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5954 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5955 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5956 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5957 (emacs_gnutls_write, emacs_gnutls_read)
5958 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5959 (Fgnutls_available_p): New function.
5960 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5961 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5962 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5963
5964 * image.c: Include w32.h.
5965 (Vimage_type_cache): Delete.
5966 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5967 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5968 (w32_delayed_load): Move to w32.c.
5969
5970 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5971
5972 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5973 (w32_delayed_load): Move from image.c. When loading a library, record
5974 its filename in the :loaded-from property of the library id.
5975 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5976 Initialize and staticpro them.
5977 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5978
5979 * process.c: Include lisp.h before w32.h, not after.
5980 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5981 instead of gnutls_record_check_pending.
5982
5983 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5984
ff4de4aa
TZ
59852011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5986
5987 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5988 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5989 as passed in.
5990
abe95abb
JD
59912011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5992
5993 * xterm.c (x_set_frame_alpha): Do not set property on anything
5994 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5995
e16e55d4
JB
59962011-05-02 Juanma Barranquero <lekktu@gmail.com>
5997
5998 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5999
bafcf6a5
JB
60002011-05-02 Juanma Barranquero <lekktu@gmail.com>
6001
6002 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6003 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6004 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6005 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6006 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6007 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6008 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6009 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6010 (Qgnutls_bootprop_callbacks_verify): Make static.
6011
e7a6747f
AS
60122011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6013
19ed11ba
AS
6014 * callproc.c: Indentation fixup.
6015
e7a6747f 6016 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6017 (wait_for_termination, interruptible_wait_for_termination):
6018 Move after wait_for_termination_1.
e7a6747f 6019
1ef14cb4
LMI
60202011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6021
6022 * sysdep.c (interruptible_wait_for_termination): New function
6023 which is like wait_for_termination, but allows keyboard
6024 interruptions.
6025
6026 * callproc.c (Fcall_process): Add (:file "file") as an option for
6027 the STDOUT buffer.
6028 (Fcall_process_region): Ditto.
6029
330d880c
EZ
60302011-04-30 Eli Zaretskii <eliz@gnu.org>
6031
8db90b73
EZ
6032 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6033 rather than `XVECTOR (FOO)->size'.
6034
330d880c
EZ
6035 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6036 inttypes.h, as a gnulib replacement is used if it not available in
6037 system headers.
6038
15cbd324
EZ
60392011-04-21 Eli Zaretskii <eliz@gnu.org>
6040
6041 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6042 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6043 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6044
6045 * coding.c (coding_alloc_by_realloc): Error out if destination
6046 will grow beyond MOST_POSITIVE_FIXNUM.
6047 (decode_coding_emacs_mule): Abort if there isn't enough place in
6048 charbuf for the composition carryover bytes. Reserve an extra
6049 space for up to 2 characters produced in a loop.
6050 (decode_coding_iso_2022): Abort if there isn't enough place in
6051 charbuf for the composition carryover bytes.
6052
60532011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6054
ae940cca
EZ
6055 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6056 aborting when %lld or %lll format is passed.
6057 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6058 %llo or %llx format is passed. (Bug#8545)
6059
03ab8921
EZ
6060 * window.c (window_scroll_line_based): Use a marker instead of
6061 simple variables to record original value of point. (Bug#7952)
6062
afda1437
EZ
6063 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6064 produced by %s or %c overflows available buffer space. (Bug#8545)
6065
f76dee0c
PE
60662011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6067
6068 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6069 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6070
fdc5744d
JB
60712011-04-28 Juanma Barranquero <lekktu@gmail.com>
6072
6073 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6074
638f053a
JB
60752011-04-28 Juanma Barranquero <lekktu@gmail.com>
6076
6077 * keyboard.c (Qdelayed_warnings_hook): Define.
6078 (command_loop_1): Run `delayed-warnings-hook'
6079 if Vdelayed_warnings_list is non-nil.
6080 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6081 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6082
d178f871
EZ
60832011-04-28 Eli Zaretskii <eliz@gnu.org>
6084
6085 * doprnt.c (doprnt): Don't return value smaller than the buffer
6086 size if the message was truncated. (Bug#8545).
6087
b124fd93
JB
60882011-04-28 Juanma Barranquero <lekktu@gmail.com>
6089
6090 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6091 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6092
e810457d
PE
60932011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6094
6095 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6096
ea51cceb
JB
60972011-04-27 Juanma Barranquero <lekktu@gmail.com>
6098
6099 * makefile.w32-in: Update dependencies.
6100
94dcfacf
EZ
61012011-04-27 Eli Zaretskii <eliz@gnu.org>
6102
6103 Improve `doprnt' and its usage. (Bug#8545)
6104 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6105 `format_end'. Remove support for %l as a conversion specifier.
6106 Don't use xrealloc. Improve diagnostics when the %l size modifier
6107 is used. Update the commentary.
6108
6109 * eval.c (verror): Simplify calculation of size_t.
6110
6111 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6112 messages.
6113
f61f41d7
PE
61142011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6115
6116 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6117 change.
6118
96fb4434
PE
61192011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6120
6121 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6122 This makes this file independent of the recent pseudovector change.
6123
671875da 61242011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6125
69e9b5a3
PE
6126 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6127
b5f869a7 6128 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6129 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6130 Remove unused local.
c8926152 6131 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6132
841a1577 6133 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6134 GCC 4.6.0 optimizes based on type-based alias analysis.
6135 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6136 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6137 != &v->size, and therefore "v->size = 1; b->size = 2; return
6138 v->size;" must therefore return 1. This assumption is incorrect
6139 for Emacs, since it type-puns struct Lisp_Vector * with many other
6140 types. To fix this problem, this patch adds a new type struct
f904488f 6141 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6142 and pseudovectors, and helps optimizing compilers not get fooled
6143 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6144 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6145 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6146 the size member.
eab3844f
PE
6147 (XSETPVECTYPE): Rewrite in terms of new macro.
6148 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6149 This is a bit clearer, and further avoids the possibility of
6150 undesirable aliasing.
6151 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6152 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6153 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6154 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6155 (ASIZE): Now uses header.size rather than size.
6156 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6157 to avoid the hassle of writing XVECTOR (foo)->header.size.
6158 (struct vectorlike_header): New type.
eab3844f
PE
6159 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6160 object, to help avoid aliasing.
6161 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6162 (SUBRP): Likewise, since Lisp_Subr is a special case.
6163 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6164 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6165 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6166 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6167 changed to be "header.size" and "header.next".
6168 * buffer.h (struct buffer): Likewise.
6169 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6170 * frame.h (struct frame): Likewise.
6171 * process.h (struct Lisp_Process): Likewise.
6172 * termhooks.h (struct terminal): Likewise.
6173 * window.c (struct save_window_data, struct saved_window): Likewise.
6174 * window.h (struct window): Likewise.
6175 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6176 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6177 * buffer.c (init_buffer_once): Likewise.
6178 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6179 special case.
6180 * process.c (Fformat_network_address): Use local var for size,
6181 for brevity.
6182
0df1eac5
PE
6183 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6184
847ab9d1 6185 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6186 * data.c (atof): Remove decl; no longer used or needed.
6187 (digit_to_number): Move to lread.c.
6188 (Fstring_to_number): Use new string_to_number function, to be
6189 consistent with how the Lisp reader treats infinities and NaNs.
6190 Do not assume that floating-point numbers represent EMACS_INT
6191 without losing information; this is not true on most 64-bit hosts.
6192 Avoid double-rounding errors, by insisting on integers when
6193 parsing non-base-10 numbers, as the documentation specifies.
6194 * lisp.h (string_to_number): New decl, replacing ...
6195 (isfloat_string): Remove.
bc0a5c13 6196 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6197 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6198 appears to have been a coding error. Similarly, do not accept
6199 strings like +-1e0 as floating point numbers. Do not report
6200 overflow for integer overflows unless the base is not 10 which
6201 means we have no simple and reliable way to continue.
6202 Break out the floating-point parsing into a new
6203 function string_to_number, so that Fstring_to_number parses
6204 floating point numbers consistently with the Lisp reader.
04f2d78b 6205 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6206 (E_CHAR, EXP_INT): Remove, replacing with ...
6207 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6208 (string_to_number): New function, replacing isfloat_string.
6209 This function checks for valid syntax and produces the resulting
6210 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6211 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6212 so that overflow for non-base-10 numbers is reported only when
6213 there's no portable and simple way to convert to floating point.
452f4150 6214
67769ffc
PE
6215 * textprop.c (set_text_properties_1): Rewrite for clarity,
6216 and to avoid GCC warning about integer overflow.
6217
c20db43f
PE
6218 * intervals.h (struct interval): Use EMACS_INT for members
6219 where EMACS_UINT might cause problems. See
6220 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6221 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6222 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6223 All uses changed.
37aa2f85
PE
6224 (offset_intervals): Tell GCC not to worry about length overflow
6225 when negating a negative length.
c20db43f 6226
2538aa2f
PE
6227 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6228 (overrun_check_free): Likewise.
6229
f2d3008d
PE
6230 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6231 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6232 word size.
6233
ec8df744
PE
6234 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6235 (gnutls_make_error): Rename local to avoid shadowing.
6236 (gnutls_emacs_global_deinit): ifdef out; not used.
6237 (Fgnutls_boot): Use const for pointer to readonly storage.
6238 Comment out unused local. Fix pointer signedness problems.
6239
640ee02d
PE
6240 * lread.c (openp): Don't stuff size_t into an 'int'.
6241 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6242 about possible signed overflow.
6243
6048fb2a
PE
6244 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6245 (GDK_KEY_g): Don't define if already defined.
6246 (xg_prepare_tooltip): Avoid pointer signedness problem.
6247 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6248
fa3c87e1
PE
6249 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6250 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6251
2172544b
PE
6252 * xfns.c (Fx_window_property): Simplify a bit,
6253 to make a bit faster and to avoid GCC 4.6.0 warning.
6254 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6255
9b821a21
PE
6256 * fns.c (internal_equal): Don't assume size_t fits in int.
6257
3c616cfa
PE
6258 * alloc.c (compact_small_strings): Tighten assertion a little.
6259
c2982e87
PE
6260 Replace pEd with more-general pI, and fix some printf arg casts.
6261 * lisp.h (pI): New macro, generalizing old pEd macro to other
6262 conversion specifiers. For example, use "...%"pI"d..." rather
6263 than "...%"pEd"...".
6264 (pEd): Remove. All uses replaced with similar uses of pI.
6265 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6266 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6267 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6268 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6269 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6270 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6271 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6272 64-bit hosts.
6273 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6274 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6275 * print.c (safe_debug_print, print_object): Likewise.
6276 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6277 to int.
6f04d126
PE
6278 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6279 avoiding the 0 flag, which is not portable.
c2982e87
PE
6280 * process.c (Fmake_network_process): Use pI to avoid cast.
6281 * region-cache.c (pp_cache): Likewise.
6282 * xdisp.c (decode_mode_spec): Likewise.
6283 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6284 behavior on 64-bit hosts with printf arg.
6f04d126 6285 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6286 (x_stop_queuing_selection_requests): Likewise.
6287 (x_get_window_property): Don't truncate byte count to an 'int'
6288 when tracing.
0b432f21 6289
5e073ec7
PE
6290 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6291 here, since it parses constructs like leading '-' and spaces,
6292 which are not wanted; and it overflows with large numbers.
6293 Instead, simply match F[0-9]+, which is what is wanted anyway.
6294
36372bf9
PE
6295 * alloc.c: Remove unportable assumptions about struct layout.
6296 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6297 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6298 (allocate_vectorlike, make_pure_vector): Use the new macros,
6299 plus offsetof, to remove unportable assumptions about struct layout.
6300 These assumptions hold on all porting targets that I know of, but
6301 they are not guaranteed, they're easy to remove, and removing them
6302 makes further changes easier.
6303
0b432f21
PE
6304 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6305 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6306 (string_overrun_cookie): Now const. Use initializers that
6307 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6308 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6309 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6310 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6311 multiple of sizeof (EMACS_INT); it need not be, if
6312 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6313 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6314
895009e1
JB
63152011-04-26 Juanma Barranquero <lekktu@gmail.com>
6316
6317 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6318
6a7a1b0b
TZ
63192011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6320
6321 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6322 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6323 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6324
841a1577 63252011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6326
6327 * lisp.h (Qdebug): List symbol.
895009e1 6328 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6329 * keyboard.c (debug-on-event): New variable.
6330 (handle_user_signal): Break into debugger when debug-on-event
6331 matches the current signal symbol.
6332
f2d3ba6f
DN
63332011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6334
6335 * alloc.c (check_sblock, check_string_bytes)
6336 (check_string_free_list): Convert to standard C.
6337
42ce4c63
TZ
63382011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6339
6340 * w32.c (emacs_gnutls_push): Fix typo.
6341
825cd63c
EZ
63422011-04-25 Eli Zaretskii <eliz@gnu.org>
6343
fb11d64d
EZ
6344 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6345 "cast to pointer from integer of different size".
6346
825cd63c
EZ
6347 Improve doprnt and its use in verror. (Bug#8545)
6348 * doprnt.c (doprnt): Document the set of format control sequences
6349 supported by the function. Use SAFE_ALLOCA instead of always
6350 using `alloca'.
6351
6352 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6353 is one byte too soon. Don't use xrealloc; instead xfree and
6354 xmalloc anew.
6355
e061a11b
TZ
63562011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6357
6358 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6359 callbacks stage.
6360
6361 * gnutls.c: Renamed global_initialized to
6362 gnutls_global_initialized. Added internals for the
6363 :verify-hostname-error, :verify-error, and :verify-flags
6364 parameters of `gnutls-boot' and documented those parameters in the
6365 docstring. Start callback support.
9173deec
JB
6366 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6367 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6368 on error. Return error code.
e061a11b
TZ
6369 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6370 (emacs_gnutls_read): Likewise.
6371 (Fgnutls_boot): Return handshake error code.
6372 (emacs_gnutls_handle_error): New function.
6373 (wsaerror_to_errno): Likewise.
6374
6375 * w32.h (emacs_gnutls_pull): Add prototype.
6376 (emacs_gnutls_push): Likewise.
6377
6378 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6379 (emacs_gnutls_push): Likewise.
6380
63812011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6382
6383 * process.c (wait_reading_process_output): Check if GnuTLS
6384 buffered some data internally if no FDs are set for TLS
6385 connections.
6386
6387 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6388 (LIBS): Link to USER_LIBS.
6389 ($(BLD)/gnutls.$(0)): New target.
6390
fa6996bc
EZ
63912011-04-24 Eli Zaretskii <eliz@gnu.org>
6392
eb35682e
EZ
6393 * xdisp.c (handle_single_display_spec): Rename the
6394 display_replaced_before_p argument into display_replaced_p, to
6395 make it consistent with the commentary. Fix typos in the
6396 commentary.
6397
e2ad650c
EZ
6398 * textprop.c (syms_of_textprop): Remove dead code.
6399 (copy_text_properties): Delete obsolete commentary about an
6400 interface that was deleted long ago. Fix typos in the description
6401 of arguments.
6402
1b2de274
EZ
6403 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6404 to changes in oldXMenu/XMenu.h from 2011-04-16.
6405 <menu_help_message, prev_menu_help_message>: Constify.
6406 (IT_menu_make_room): menu->help_text is now `const char **';
6407 adjust.
6408
6409 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6410 to changes in oldXMenu/XMenu.h from 2011-04-16.
6411 (struct XMenu): Declare `help_text' `const char **'.
6412
6413 * xfaces.c <Qunspecified>: Make extern again.
6414
6415 * syntax.c: Include sys/types.h before including regex.h, as
6416 required by Posix.
6417
762b15be
EZ
6418 * doc.c (get_doc_string): Improve the format passed to `error'.
6419
6420 * doprnt.c (doprnt): Improve commentary.
6421
6422 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6423
6424 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6425 them with etags.
6426
f1052e5d
EZ
6427 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6428 changes in globals.h immediately force recompilation.
762b15be
EZ
6429 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6430 $(CURDIR)/s/ms-w32.h.
6431 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6432
fa6996bc
EZ
6433 * character.c (Fchar_direction): Function deleted.
6434 (syms_of_character): Don't defsubr it.
6435 <char-direction-table>: Deleted.
6436
e6c3da20
EZ
64372011-04-23 Eli Zaretskii <eliz@gnu.org>
6438
6439 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6440 * doprnt.c: Include limits.h.
6441 (SIZE_MAX): New macro.
04f2d78b
CB
6442 (doprnt): Return a size_t value. 2nd arg is now size_t.
6443 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6444 Improve overflow protection. Support `l' modifier for integer
6445 conversions. Support %l conversion. Don't assume an EMACS_INT
6446 argument for integer conversions and for %c.
6447
6448 * lisp.h (doprnt): Restore prototype.
6449
6450 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6451 $(SRC)/character.h.
6452
6453 * Makefile.in (base_obj): Add back doprnt.o.
6454
6455 * deps.mk (doprnt.o): Add back prerequisites.
6456 (callint.o): Depend on character.h.
6457
6458 * eval.c (internal_lisp_condition_case): Include the handler
6459 representation in the error message.
6460 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6461 when breaking from the loop.
6462
6463 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6464
6465 * callint.c (Fcall_interactively): When displaying error message
6466 about invalid control letter, pass the character's codepoint, not
6467 a pointer to its multibyte form. Improve display of the character
6468 in octal and display also its hex code.
6469
6470 * character.c (char_string): Use %x to display the (unsigned)
6471 codepoint of an invalid character, to avoid displaying a bogus
6472 negative value.
6473
6474 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6475 `error', not SYMBOL_NAME itself.
6476
6477 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6478 character arguments to `error'.
6479
6480 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6481 to `error' in error message about FINAL_CHAR argument. Make sure
6482 FINAL_CHAR is a character, and use %c when it is passed as
6483 argument to `error'.
6484
4ffd0d6b 64852011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6486
6487 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6488
6489 * w32.c: Include <time.h>.
6490 (sys_localtime): New function.
6491
4ffd0d6b 64922011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6493
6494 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6495
4ffd0d6b 6496 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6497
4ffd0d6b 64982011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6499
4ffd0d6b
GM
6500 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6501 zombies (Bug#8467).
aac0c6e3 6502
04c56954
EZ
65032011-04-19 Eli Zaretskii <eliz@gnu.org>
6504
6505 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6506 gl_state.e_property when gl_state.object is Qt.
6507
6508 * insdel.c (make_gap_larger): Remove limitation of buffer size
6509 to <= INT_MAX.
6510
16a43933
CY
65112011-04-18 Chong Yidong <cyd@stupidchicken.com>
6512
6513 * xdisp.c (lookup_glyphless_char_display)
6514 (produce_glyphless_glyph): Handle cons cell entry in
6515 glyphless-char-display.
6516 (Vglyphless_char_display): Document it.
6517
6518 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6519 glyphless-char-display.
6520
4581706e
CY
65212011-04-17 Chong Yidong <cyd@stupidchicken.com>
6522
6523 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6524
6525 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6526
6527 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6528 definition for no-X builds.
6529
4887c6e2 65302011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6531
fd35b6f9
PE
6532 Static checks with GCC 4.6.0 and non-default toolkits.
6533
5c1ccb01
PE
6534 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6535
006c5daa
PE
6536 * process.c (keyboard_bit_set): Define only if SIGIO.
6537 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6538 (send_process): Repair possible setjmp clobbering.
6539
efc736d3
PE
6540 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6541
4e2fe2e6
PE
6542 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6543
f97334a2
PE
6544 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6545
4e75f29d
PE
6546 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6547 Define only if needed.
6548
90efadd1
PE
6549 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6550 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6551 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6552
3c647824
PE
6553 * dispextern.h (struct redisplay_interface): Rename param
6554 to avoid shadowing.
e264f262 6555 * termhooks.h (struct terminal): Likewise.
761383f4 6556 * xterm.c (xembed_send_message): Likewise.
3c647824 6557
b58c5c4a
PE
6558 * insdel.c (make_gap_smaller): Define only if
6559 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6560
cad59032
PE
6561 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6562 it.
6563
c339dc2e
PE
6564 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6565 so that we aren't warned about unused symbols.
6566
91a3e27b
PE
6567 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6568
399c71d3 6569 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6570
8ffc96f5
PE
6571 * xfns.c (x_real_positions): Mark locals as initialized.
6572
eef9bc79
PE
6573 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6574
098db9dd
PE
6575 * xterm.c: Fix problems found by static analysis with other toolkits.
6576 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6577 (x_dispatch_event): Declare static if USE_GTK, and
6578 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6579 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6580 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6581 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6582 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6583
eb18f6cc
PE
6584 * xmenu.c (menu_help_callback): Pointer type fixes.
6585 Use const pointers when pointing at readonly data. Avoid pointer
6586 signedness clashes.
6587 (FALSE): Remove unused macro.
6588 (update_frame_menubar): Remove unused decl.
6589
1fe72bf8
PE
6590 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6591
60d9e1db
PE
6592 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6593 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6594 (single_menu_item): Rename local to avoid shadowing.
6595
39261c26
PE
6596 * keyboard.c (make_lispy_event): Remove unused local var.
6597
018c5e19
PE
6598 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6599 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6600
63d2b86e
PE
6601 * bitmaps: Change bitmaps from unsigned char back to the X11
6602 compatible char. Avoid the old compiler warnings about
6603 out-of-range initializers by using, for example, '\xab' rather
6604 than 0xab.
6605
aefd87e1
PE
6606 * xgselect.c (xgselect_initialize): Check vs interface
6607 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6608
bf501fb9
PE
6609 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6610
e9829fdf
PE
6611 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6612 to read-only memory.
6613
1086c095
PE
6614 * fns.c (vector): Remove; this old hack is no longer needed.
6615
2baccd04 6616 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6617 Remove unused var.
dde42981 6618 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6619
72391843 6620 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6621
436c16df 6622 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6623 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6624 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6625
92bb796d 6626 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6627 (x_term_init): Remove local to avoid shadowing.
92bb796d 6628
764430a3 6629 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6630
6631 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6632 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6633
d1dfb56c
EZ
66342011-04-16 Eli Zaretskii <eliz@gnu.org>
6635
c4354cb4
EZ
6636 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6637
d1dfb56c
EZ
6638 Fix regex.c, syntax.c and friends for buffers > 2GB.
6639 * syntax.h (struct gl_state_s): Declare character position members
6640 EMACS_INT.
6641
6642 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6643
04f2d78b
CB
6644 * textprop.c (verify_interval_modification, interval_of):
6645 Declare arguments EMACS_INT.
d1dfb56c
EZ
6646
6647 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6648 EMACS_INT.
6649
6650 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6651
6652 * indent.c (Fvertical_motion): Local variable it_start is now
6653 EMACS_INT.
6654
6655 * regex.c (re_match, re_match_2, re_match_2_internal)
6656 (bcmp_translate, regcomp, regexec, print_double_string)
6657 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6658 (re_compile_pattern, re_exec): Declare arguments and local
6659 variables `size_t' and `ssize_t' and return values `regoff_t', as
6660 appropriate.
6661 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6662 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6663 <compile_stack_type>: `size' and `avail' are now `size_t'.
6664
6665 * regex.h <regoff_t>: Use ssize_t, not int.
6666 (re_search, re_search_2, re_match, re_match_2): Arguments that
6667 specify buffer/string position and length are now ssize_t and
6668 size_t. Return type is regoff_t.
6669
613052cd
BK
66702011-04-16 Ben Key <bkey76@gmail.com>
6671
6672 * nsfont.m: Fixed bugs in ns_get_family and
6673 ns_descriptor_to_entity that were caused by using free to
6674 deallocate memory blocks that were allocated by xmalloc (via
6675 xstrdup). This caused Emacs to crash when compiled with
6676 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6677 --enable-checking=xmallocoverrun). xfree is now used to
6678 deallocate these memory blocks.
6679
4170f62f 66802011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6681
71b41406
PE
6682 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6683
9587a89d
PE
6684 emacs_write: Accept and return EMACS_INT for sizes.
6685 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6686 et seq.
6687 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6688 Accept and return EMACS_INT.
6689 (emacs_gnutls_write): Return the number of bytes written on
6690 partial writes.
6691 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6692 (emacs_read, emacs_write): Remove check for negative size, as the
6693 Emacs source code has been audited now.
9587a89d
PE
6694 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6695 (emacs_read, emacs_write): Use it.
273a5f82
PE
6696 * process.c (send_process): Adjust to the new signatures of
6697 emacs_write and emacs_gnutls_write. Do not attempt to store
6698 a byte offset into an 'int'; it might overflow.
9587a89d 6699 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6700
3e047f51
PE
6701 * sound.c: Don't assume sizes fit in 'int'.
6702 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6703 Return EMACS_INT, not int.
3e047f51 6704 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6705 Accept EMACS_INT, not int.
6706 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6707 record read return values.
6708
cc39a9db
BK
67092011-04-15 Ben Key <bkey76@gmail.com>
6710
c9d0ec6d
JB
6711 * keyboard.c (Qundefined): Don't declare static since it is used
6712 in nsfns.m.
6713 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6714 static since they are used in nsfont.m.
cc39a9db 6715
6c60eb9f
SM
67162011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6717
6718 * process.c (Qprocessp): Don't declare static.
6719 * lisp.h (Qprocessp): Declare again.
6720
7990b61a
JB
67212011-04-15 Juanma Barranquero <lekktu@gmail.com>
6722
6723 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6724
5d4cb038
PE
67252011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6726
8bd7b830 6727 Improve C-level modularity by making more things 'static'.
cd64ea1d 6728
e3b27b31
PE
6729 Don't publish debugger-only interfaces to other modules.
6730 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6731 (verify_bytepos, count_markers): Move decls to the only modules
6732 that need them.
6733 * region-cache.h (pp_cache): Likewise.
6734 * window.h (check_all_windows): Likewise.
6735 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6736
5d4cb038
PE
6737 * sysdep.c (croak): Now static, if
6738 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6739 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6740
6741 * alloc.c (refill_memory_reserve): Now static if
6742 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6743 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6744
e87b6180
PE
6745 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6746 Define only if USE_LUCID.
6747
ac64929e
PE
6748 * xrdb.c (x_customization_string, x_rm_string): Now static.
6749
6f37259d
PE
6750 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6751 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6752
1683e3ab
PE
6753 * xdisp.c (draw_row_with_mouse_face): Now static.
6754 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6755
de9c2632
PE
6756 * window.h (check_all_windows): Mark externally visible.
6757
2b96acb7
PE
6758 * window.c (window_deletion_count): Now static.
6759
6760 * undo.c: Make symbols static if they're not exported.
6761 (last_undo_buffer, last_boundary_position, pending_boundary):
6762 Now static.
6763
50436f33
PE
6764 * textprop.c (interval_insert_behind_hooks): Now static.
6765 (interval_insert_in_front_hooks): Likewise.
6766
64520e5c
PE
6767 * term.c: Make symbols static if they're not exported.
6768 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6769 (max_frame_lines, tty_set_terminal_modes):
6770 (tty_reset_terminal_modes, tty_turn_off_highlight):
6771 (get_tty_terminal): Now static.
6772 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6773 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6774 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6775 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6776 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6777
1fa53021
PE
6778 * sysdep.c: Make symbols static if they're not exported.
6779 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6780 Now static.
6781 (sigprocmask_set, full_mask): Remove; unused.
6782 (wait_debugging): Mark as visible.
6783 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6784 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6785
d4b43b22
PE
6786 * syntax.c (syntax_temp): Define only if !__GNUC__.
6787
b7c513d0
PE
6788 * sound.c (current_sound_device, current_sound): Now static.
6789
989b29ad
PE
6790 * search.c (searchbufs, searchbuf_head): Now static.
6791
13a55a78
PE
6792 * scroll.c (scroll_cost): Remove; unused.
6793 * dispextern.h (scroll_cost): Remove decl.
6794
de68a1fc
PE
6795 * region-cache.h (pp_cache): Mark as externally visible.
6796
40ccffa6
PE
6797 * process.c: Make symbols static if they're not exported.
6798 (process_tick, update_tick, create_process, chan_process):
6799 (Vprocess_alist, proc_buffered_char, datagram_access):
6800 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6801 (deactivate_process): Mark defn as static, as well as decl.
6802 * lisp.h (create_process): Remove decl.
6803 * process.h (chan_process, Vprocess_alist): Remove decls.
6804
ad64fc97
PE
6805 * print.c: Make symbols static if they're not exported.
6806 (print_depth, new_backquote_output, being_printed, print_buffer):
6807 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6808 (print_interval, print_number_index, initial_stderr_stream):
6809 Now static.
6810 * lisp.h (Fprinc): Remove decl.
6811 (debug_output_compilation_hack): Mark as externally visible.
6812
adddb265
PE
6813 * sysdep.c (croak): Move decl from here to syssignal.h.
6814 * syssignal.h (croak): Put it here, so the API can be checked when
6815 'croak' is called from dissociate_if_controlling_tty.
6816
1717ede2
PE
6817 * minibuf.c: Make symbols static if they're not exported.
6818 (minibuf_save_list, choose_minibuf_frame): Now static.
6819 * lisp.h (choose_minibuf_frame): Remove decl.
6820
fa5fb2bc
PE
6821 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6822
1e3890d1
PE
6823 * lread.c: Make symbols static if they're not exported.
6824 (read_objects, initial_obarray, oblookup_last_bucket_number):
6825 Now static.
6826 (make_symbol): Remove; unused.
6827 * lisp.h (initial_obarray, make_symbol): Remove decls.
6828
8a1414fa
PE
6829 * keyboard.c: Make symbols static if they're not exported.
6830 (single_kboard, recent_keys_index, total_keys, recent_keys):
6831 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6832 (this_single_command_key_start, echoing, last_auto_save):
6833 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6834 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6835 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6836 (Vlispy_mouse_stem, double_click_count):
6837 Now static.
6838 (force_auto_save_soon): Define only if SIGDANGER.
6839 (ignore_mouse_drag_p): Now static if
6840 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6841 (print_help): Remove; unused.
6842 (stop_character, last_timer_event): Mark as externally visible.
6843 * keyboard.h (ignore_mouse_drag_p): Declare only if
6844 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6845 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6846 * lisp.h (echoing): Remove decl.
6847 (force_auto_save_soon): Declare only if SIGDANGER.
6848 * xdisp.c (redisplay_window): Simplify code, to make it more
6849 obvious that ignore_mouse_drag_p is not accessed if !defined
6850 USE_GTK && !defined HAVE_NS.
6851
93ea6e8f
PE
6852 * intervals.c: Make symbols static if they're not exported.
6853 (merge_properties_sticky, merge_interval_right, delete_interval):
6854 Now static.
6855 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6856
77382fcc
PE
6857 * insdel.c: Make symbols static if they're not exported.
6858 However, leave prepare_to_modify_buffer alone. It's never
6859 called from outside this function, but that appears to be a bug.
6860 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6861 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6862 (adjust_after_replace_noundo): Remove; unused.
6863 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6864 (signal_before_change): Remove decls.
77382fcc 6865
9306c32e
PE
6866 * indent.c (val_compute_motion, val_vmotion): Now static.
6867
cd44d2eb
PE
6868 * image.c: Make symbols static if they're not exported.
6869 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6870 if USE_GTK.
6871 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6872 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6873
ad9a7a06
PE
6874 * fringe.c (standard_bitmaps): Now static.
6875 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6876
81626931
PE
6877 * frame.c: Make symbols static if they're not exported.
6878 (x_report_frame_params, make_terminal_frame): Now static.
6879 (get_frame_param): Now static, unless HAVE_NS.
6880 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6881 (x_get_resource_string): Remove; not used.
6882 * frame.h (make_terminal_frame, x_report_frame_params):
6883 (x_get_resource_string); Remove decls.
6884 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6885 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6886
239f9db9
PE
6887 * font.c, fontset.c: Make symbols static if they're not exported.
6888 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6889 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6890 * font.c (font_close_object): Now static.
6891 * font.h (font_close_object): Remove.
6892 * fontset.c (FONTSET_OBJLIST): Remove.
6893 (free_realized_fontset) #if-0 the body, which does nothing.
6894 (face_suitable_for_char_p): #if-0, as it's never called.
6895 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6896 * xfaces.c (face_at_string_position):
6897 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6898 since 0 is always ASCII.
6899
dfcf3579
PE
6900 * fns.c (weak_hash_tables): Now static.
6901
5045092b
PE
6902 * fileio.c: Make symbols static if they're not exported.
6903 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6904 (Vwrite_region_annotation_buffers): Now static.
6905
57a96f5c
PE
6906 * eval.c: Make symbols static if they're not exported.
6907 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6908 * lisp.h (backtrace_list): Remove decl.
6909
35f08c38
PE
6910 * emacs.c: Make symbols static if they're not exported.
6911 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6912 (fatal_error_code, fatal_error_signal_hook, standard_args):
6913 Now static.
6914 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6915 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6916 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6917 * lisp.h (fatal_error_signal_hook): Remove decl.
6918 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6919
f44bd759
PE
6920 * editfns.c: Move a (normally-unused) function to its only use.
6921 * editfns.c, lisp.h (get_operating_system_release): Remove.
6922 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6923 worth the hassle of breaking this out.
6924
b532497d
PE
6925 * xterm.c: Make symbols static if they're not exported.
6926 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6927 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6928 (x_destroy_window, x_delete_display):
6929 Now static.
6930 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6931 (x_mouse_leave): Remove; unused.
6932 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6933 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6934 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6935 Remove decls.
6936 (x_mouse_leave): Declare only if WINDOWSNT.
6937 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6938 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6939 USE_X_TOOLKIT.
6940
1675728f
PE
6941 * ftxfont.c: Make symbols static if they're not exported.
6942 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6943 HAVE_FREETYPE.
6944 * font.h (ftxfont_driver): Likewise.
6945
e4cebfca
PE
6946 * xfns.c: Make symbols static if they're not exported.
6947 (x_last_font_name, x_display_info_for_name):
6948 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6949 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6950 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6951 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6952 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6953 (last_show_tip_args): Now static.
6954 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6955 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6956 (x_screen_planes): Remove; unused.
6957 * dispextern.h (x_screen_planes): Remove decl.
6958
5bf46f05
PE
6959 * dispnew.c: Make symbols static if they're not exported.
6960 * dispextern.h (redraw_garbaged_frames, scrolling):
6961 (increment_row_positions): Remove.
6962 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6963 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6964 Now static.
6965 (redraw_garbaged_frames): Remove; unused.
6966
435f4c28
PE
6967 * xfaces.c: Make symbols static if they're not exported.
6968 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6969 Remove decls.
6970 * xterm.h (defined_color): Remove decls.
6971 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6972 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6973 (menu_face_changed_default, defined_color, free_realized_face):
6974 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6975 (ascii_face_of_lisp_face): Remove; unused.
6976
8524aef3
PE
6977 * xdisp.c: Make symbols static if they're not exported.
6978 * dispextern.h (scratch_glyph_row, window_box_edges):
6979 (glyph_to_pixel_coords, set_cursor_from_row):
6980 (get_next_display_element, set_iterator_to_next):
6981 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6982 (show_mouse_face): Remove decls
6983 * frame.h (message_buf_print): Likewise.
6984 * lisp.h (pop_message, set_message, check_point_in_composition):
6985 Likewise.
6986 * xterm.h (set_vertical_scroll_bar): Likewise.
6987 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6988 (message_buf_print, scratch_glyph_row, displayed_buffer):
6989 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6990 (get_next_display_element, show_mouse_face, window_box_edges):
6991 (frame_to_window_pixel_xy, check_point_in_composition):
6992 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6993 (glyph_to_pixel_coords): Remove; unused.
6994
16390cd2
PE
6995 * dired.c (file_name_completion): Now static.
6996
6997 * dbusbind.c (xd_in_read_queued_messages): Now static.
6998
a25f4dfa
PE
6999 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7000 * data.c (circular_list_error): Remove.
7001
14a9c8df
PE
7002 * commands.h (last_point_position, last_point_position_buffer):
7003 (last_point_position_window): Remove decls.
7004 * keyboard.c: Make these variables static.
7005
04f2d78b
CB
7006 * coding.h (coding, code_convert_region, encode_coding_gap):
7007 Remove decls.
74ab6df5
PE
7008 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7009 (iso_code_class, detect_coding, code_convert_region): Now static.
7010 (encode_coding_gap): Remove; unused.
7011
38dfbee1
PE
7012 * chartab.c (chartab_chars, chartab_bits): Now static.
7013
a2cb4e63
PE
7014 * charset.h (charset_iso_8859_1): Remove decl.
7015 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7016 Now static.
7017
127198fd
PE
7018 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7019 * ccl.c (Vccl_program_table): Now static.
7020 (check_ccl_update): Remove; unused.
7021
d85b608f
PE
7022 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7023 * category.h: ... from here.
7024 * category.c (check_category_table, set_category_set): Now static.
7025
31cd66f3
PE
7026 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7027 * lisp.h: Remove these decls.
7028
c358e587
PE
7029 * buffer.c (buffer_count): Remove unused var.
7030
e78aecca
PE
7031 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7032 so that it's not optimized away.
7033 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7034 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7035 exported only to the debugger.
7036
e192d7d3 7037 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7038 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7039
92470028
PE
7040 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7041 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7042 was inaccessible from Lisp.
7043 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7044 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7045
244ed907
PE
7046 alloc.c: Import and export fewer symbols, and remove unused items.
7047 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7048 is defined.
7049 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7050 it's not optimized away by whole-program optimization.
7051 (message_enable_multibyte, free_misc): Remove.
7052 (catchlist, handlerlist, mark_backtrace):
7053 Declare only if BYTE_MARK_STACK.
7054 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7055 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7056 (message_enable_multibyte): Remove decl.
7057 (free_misc, interval_free_list, float_block, float_block_index):
7058 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7059 (cons_free_list, last_marked_index):
7060 Now static.
7061 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7062 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7063 (mark_backtrace): Define only if BYTE_MARK_STACK.
7064 * xdisp.c (message_enable_multibyte): Now static.
7065
61c2b50e 7066 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7067 This makes it easier for human readers (and static analyzers)
7068 to see whether these variables are used from other modules.
7069 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7070 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7071 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7072 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7073 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7074 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7075 * xmenu.c, xselect.c:
7076 Declare Q* vars static if they are not used in other modules.
7077 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7078 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7079 Remove decls of unexported vars.
7080 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7081
95c82688
PE
7082 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7083
16a97296
PE
7084 Make Emacs functions such as Fatom 'static' by default.
7085 This makes it easier for human readers (and static analyzers)
7086 to see whether these functions can be called from other modules.
7087 DEFUN now defines a static function. To make the function external
7088 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7089 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7090 (Finit_image_library):
16a97296
PE
7091 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7092 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7093 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7094 Remove decls, since these functions are now static.
7095 (Funintern, Fget_internal_run_time): New decls, since these functions
7096 were already external.
95c82688 7097
16a97296
PE
7098 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7099 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7100 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7101 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7102 * keyboard.c, keymap.c, lread.c:
7103 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7104 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7105 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7106 Mark functions with DEFUE instead of DEFUN,
7107 if they are used in other modules.
7108 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7109 decls for now-static functions.
7110 * buffer.h (Fdelete_overlay): Remove decl.
7111 * callproc.c (Fgetenv_internal): Mark as internal.
7112 * composite.c (Fremove_list_of_text_properties): Remove decl.
7113 (Fcomposition_get_gstring): New forward static decl.
7114 * composite.h (Fcomposite_get_gstring): Remove decl.
7115 * dired.c (Ffile_attributes): New forward static decl.
7116 * doc.c (Fdocumntation_property): New forward static decl.
7117 * eval.c (Ffetch_bytecode): New forward static decl.
7118 (Funintern): Remove extern decl; now in .h file where it belongs.
7119 * fileio.c (Fmake_symbolic_link): New forward static decl.
7120 * image.c (Finit_image_library): New forward static decl.
7121 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7122 * intervals.h (Fprevious_property_change):
7123 (Fremove_list_of_text_properties): Remove decls.
7124 * keyboard.c (Fthis_command_keys): Remove decl.
7125 (Fcommand_execute): New forward static decl.
7126 * keymap.c (Flookup_key): New forward static decl.
7127 (Fcopy_keymap): Now static.
7128 * keymap.h (Flookup_key): Remove decl.
7129 * process.c (Fget_process): New forward static decl.
7130 (Fprocess_datagram_address): Mark as internal.
7131 * syntax.c (Fsyntax_table_p): New forward static decl.
7132 (skip_chars): Remove duplicate decl.
7133 * textprop.c (Fprevious_property_change): New forward static decl.
7134 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7135 Now internal.
7136 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7137 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7138
785bbd42
PE
7139 * editfns.c (Fformat): Remove unreachable code.
7140
8b913b57
AS
71412011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7142
7143 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7144 change. (Bug#8496)
7145
a6744a35
EZ
71462011-04-13 Eli Zaretskii <eliz@gnu.org>
7147
7148 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7149 when at ZV. (Bug#8487)
7150
e7974947
AS
71512011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7152
baad03f0
AS
7153 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7154 (Bug#8437)
7155 * keyboard.c (parse_tool_bar_item): Likewise.
7156 * sound.c (sound_cleanup, alsa_close): Likewise.
7157 * termcap.c (tgetent): Likewise.
7158 * xfns.c (x_default_font_parameter): Likewise.
7159 * xsettings.c (read_and_apply_settings): Likewise.
7160
e7974947
AS
7161 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7162 (overrun_check_free): Protoize.
7163
28272684
PE
71642011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7165
7166 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7167 since callers should never pass a negative size.
7168 Change the signature to match that of plain 'read' and 'write'; see
7169 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7170 * lisp.h: Update prototypes of emacs_write and emacs_read.
7171
11997c76
EZ
71722011-04-11 Eli Zaretskii <eliz@gnu.org>
7173
7174 * xdisp.c (redisplay_window): Don't try to determine the character
7175 position of the scroll margin if the window start point w->startp
e896f03c 7176 is outside the buffer's accessible region. (Bug#8468)
11997c76 7177
8a2cbd72
EZ
71782011-04-10 Eli Zaretskii <eliz@gnu.org>
7179
7180 Fix write-region and its subroutines for buffers > 2GB.
7181 * fileio.c (a_write, e_write): Modify declaration of arguments and
7182 local variables to support buffers larger than 2GB.
7183 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7184
7185 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7186 argument, local variables, and return value.
7187
7188 * lisp.h: Update prototypes of emacs_write and emacs_read.
7189
7190 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7191
4073e537 71922011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7193
1ebfdcb6
PE
7194 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7195
b2ded58d
PE
7196 Fix more problems found by GCC 4.6.0's static checks.
7197
7d66342c
PE
7198 * xdisp.c (vmessage): Use a better test for character truncation.
7199
bbf47d44
PE
7200 * charset.c (load_charset_map): <, not <=, for optimization,
7201 and to avoid potential problems with integer overflow.
9248994d 7202 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7203 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7204 * editfns.c (Fformat): Likewise.
1e69125e 7205 * syntax.c (skip_chars): Likewise.
3befa583 7206
e3019616
PE
7207 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7208 This also lets GCC 4.6.0 generate slightly better loop code.
7209
becfa255
PE
7210 * callint.c (Fcall_interactively): <, not <=, for optimization.
7211 (Fcall_interactively): Count the number of arguments produced,
7212 not the number of arguments given. This is simpler and lets GCC
7213 4.6.0 generate slightly better code.
7214
dae0cd48
PE
7215 * ftfont.c: Distingish more carefully between FcChar8 and char.
7216 The previous code passed unsigned char * to a functions like
7217 strlen and xstrcasecmp that expect char *, which does not
7218 conform to the C standard.
7219 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7220 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7221 char * when the C standard requires it.
7222
76032d70
PE
7223 * keyboard.c (read_char): Remove unused var.
7224
eb3f1cc8
PE
7225 * eval.c: Port to Windows vsnprintf (Bug#8435).
7226 Include <limits.h>.
7227 (SIZE_MAX): Define if the headers do not.
7228 (verror): Do not give up if vsnprintf returns a negative count.
7229 Instead, grow the buffer. This ports to Windows vsnprintf, which
7230 does not conform to C99. Problem reported by Eli Zaretskii.
7231 Also, simplify the allocation scheme, by avoiding the need for
7232 calling realloc, and removing the ALLOCATED variable.
7233
70476b54
PE
7234 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7235
12020a9e
PE
7236 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7237 But keep the doprint source code for now, as we might revamp it
7238 and use it again (Bug#8435).
ea6c7ae6
PE
7239 * lisp.h (doprnt): Remove.
7240 * Makefile.in (base_obj): Remove doprnt.o.
7241 * deps.mk (doprnt.o): Remove.
7242
5fdb398c
PE
7243 error: Print 32- and 64-bit integers portably (Bug#8435).
7244 Without this change, on typical 64-bit hosts error ("...%d...", N)
7245 was used to print both 32- and 64-bit integers N, which relied on
7246 undefined behavior.
7247 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7248 New macro.
7249 * lisp.h (error, verror): Mark as printf-like functions.
7250 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7251 Report overflow in size calculations when allocating printf buffer.
7252 Do not truncate output string at its first null byte.
7253 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7254 Truncate the output at a character boundary, since vsnprintf does not
7255 do that.
7256 * charset.c (check_iso_charset_parameter): Convert internal
7257 character to string before calling 'error', since %c now has the
7258 printf meaning.
7259 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7260 overflow when computing char to be passed to 'error'. Do not
7261 pass Lisp_Object to 'error'; pass the integer instead.
7262 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7263 formatted with plain %d.
7264
b189fa66
PE
7265 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7266
bff87ef0
PE
7267 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7268
7e2cac20
PE
7269 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7270
ce4d90b5
PE
7271 * xterm.c (x_catch_errors): Remove duplicate declaration.
7272
266c9547
PE
7273 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7274
79c49ad2
PE
7275 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7276
368f4090
JM
72772011-04-10 Jim Meyering <meyering@redhat.com>
7278
7279 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7280 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7281 return ssize_t not "int", and use size_t as the buffer length.
7282 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7283 * gnutls.h: Update declarations.
7284 * process.c (read_process_output): Use ssize_t, to match.
7285 (send_process): Likewise.
7286
a32d4040
CY
72872011-04-09 Chong Yidong <cyd@stupidchicken.com>
7288
7289 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7290
8546720e 72912011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7292
04f2d78b
CB
7293 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7294 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7295
8546720e
GM
7296 * xterm.c (handle_one_xevent):
7297 * xmenu.c (create_and_show_popup_menu):
7298 * xselect.c (x_decline_selection_request)
7299 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7300
0a2f5c1a 73012011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7302
7303 Fix some uses of `int' instead of EMACS_INT.
7304 * search.c (string_match_1, fast_string_match)
7305 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7306 (scan_buffer, find_next_newline_no_quit)
7307 (find_before_next_newline, search_command, Freplace_match)
7308 (Fmatch_data): Make some `int' variables be EMACS_INT.
7309
7310 * xdisp.c (display_count_lines): 3rd argument and return value now
7311 EMACS_INT. All callers changed.
7312 (pint2hrstr): Last argument is now EMACS_INT.
7313
7314 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7315 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7316 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7317 (decode_coding_utf_16, decode_coding_emacs_mule)
7318 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7319 (decode_coding_ccl, decode_coding_charset)
7320 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7321 (decode_coding_iso_2022, decode_coding_emacs_mule)
7322 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7323 <char_offset, last_offset>: Declare EMACS_INT.
7324 (encode_coding_utf_8, encode_coding_utf_16)
7325 (encode_coding_emacs_mule, encode_invocation_designation)
7326 (encode_designation_at_bol, encode_coding_iso_2022)
7327 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7328 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7329 Declare EMACS_INT.
7330 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7331 (encode_invocation_designation): Last argument P_NCHARS is now
7332 EMACS_INT.
7333 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7334 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7335
7336 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7337 All users changed.
7338
7339 * ccl.c (Fccl_execute_on_string): Declare some variables
7340 EMACS_INT.
7341
8546720e 73422011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7343
7344 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7345
4e19a977
CS
73462011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7347
7348 * process.c (Fformat_network_address): Doc fix.
7349
87302331
R
73502011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7351
ee7683eb 7352 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7353
cbb59342
CY
73542011-04-08 Chong Yidong <cyd@stupidchicken.com>
7355
7356 * keyboard.c (read_char): Call Lisp function help-form-show,
7357 instead of using internal_with_output_to_temp_buffer.
7358 (Qhelp_form_show): New var.
e0d38eeb 7359 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7360
7361 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7362
7363 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7364
e67a13ab
CY
73652011-04-06 Chong Yidong <cyd@stupidchicken.com>
7366
04f2d78b
CB
7367 * process.c (Flist_processes): Remove to Lisp.
7368 (list_processes_1): Delete.
e67a13ab 7369
973f782d
EZ
73702011-04-06 Eli Zaretskii <eliz@gnu.org>
7371
7c106b1e
EZ
7372 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7373
973f782d
EZ
7374 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7375
41cf7d1a 73762011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7377
ca23cc88
PE
7378 Fix more problems found by GCC 4.6.0's static checks.
7379
f390e2d5
PE
7380 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7381
42eea0d0
PE
7382 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7383
b69769da 7384 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7385
f9541e84
PE
7386 * xdisp.c (vmessage): Mark as a printf-like function.
7387
13841b55
PE
7388 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7389
c136c10f
PE
7390 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7391
5e2d4a30
PE
7392 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7393 printf-like functions.
7394 (tiff_load): Add casts to remove these marks before passing them
7395 to system-supplied API.
7396
583f48b9
PE
7397 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7398
b25d760e
PE
7399 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7400 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7401 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7402 directly, rather than having caller test rule sign. This avoids
7403 some unnecessary tests.
7404 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7405 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7406 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7407
bc7b6697 7408 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7409 (xfont_open): Avoid unnecessary tests.
bc7b6697 7410
27ccc379
PE
7411 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7412
dcd5c89a
PE
7413 * composite.h, composite.c (composition_gstring_put_cache):
7414 Use EMACS_INT, not int, for length.
7415
b13a45c6
PE
7416 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7417 breaking out part of COMPOSITION_DECODE_RULE.
7418 (COMPOSITION_DECODE_RULE): Use it.
7419 * composite.c (get_composition_id): Remove unused local vars,
7420 by using the new macro.
7421
1e792e4d
PE
7422 * textprop.c (set_text_properties_1): Change while to do-while,
7423 since the condition is always true at first.
7424
dc6c6455 7425 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7426 (interval_deletion_adjustment): Return unsigned value.
7427 All uses changed.
dc6c6455 7428
aba7731a
PE
7429 * process.c (list_processes_1, create_pty, read_process_output):
7430 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7431 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7432 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7433 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7434 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7435
fdfc4bf3
PE
7436 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7437
fca8fe46 7438 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7439 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7440
06a0259a 7441 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7442 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7443 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7444
e7b9e80f
PE
7445 * print.c (print_error_message): Avoid int overflow.
7446
56201685
PE
7447 * font.c (font_list_entities): Redo for clarity,
7448 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7449
78834453 7450 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7451 (font_score): Avoid potential overflow in diff calculation.
78834453 7452
0bc0b309 7453 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7454 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7455
e610eaca
PE
7456 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7457
b895abce
PE
7458 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7459 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7460 can always succeed if overflow has undefined behavior.
7461
1f1d9321 7462 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7463 (wordify): Omit three unnecessary tests.
1f1d9321 7464
c59478bc
PE
7465 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7466 All callers changed. This avoids the need for an unused var.
7467
79b73827
PE
7468 * casefiddle.c (casify_region): Remove var that is set but not used.
7469
a4db5dfe
PE
7470 * dired.c (file_name_completion): Remove var that is set but not used.
7471
43aae36e
PE
7472 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7473
2a47c44d 7474 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7475 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7476
a37c69bf
PE
7477 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7478 Check for integer overflow on size calculations.
7479
328ab8e7
PE
7480 * buffer.c (Fprevious_overlay_change): Remove var that is set
7481 but not used.
7482
e5a2a5cb
PE
7483 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7484 Remove vars that are set but not used.
8d84a6eb 7485 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7486 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7487
a60e5f68
PE
7488 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7489
f661cb61 7490 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7491 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7492
f0397f5a
PE
7493 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7494 that are set but not used.
7495
8664db06 7496 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7497 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7498
6abdaa4a
PE
7499 * xselect.c (x_get_local_selection, x_handle_property_notify):
7500 Remove vars that are set but not used.
7501
0ce7538d 7502 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7503 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7504
9ae848fc
PE
7505 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7506 Remove var that is set but not used.
0b918413
PE
7507 (scroll_bar_windows_size): Now size_t, not int.
7508 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7509 Check for overflow.
9ae848fc 7510
a5a62657
PE
7511 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7512 (map_tty_color) [!defined MSDOS]: Likewise.
7513
5c5cdd39
PE
7514 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7515
66ebf983
PE
7516 * coding.c: Remove vars that are set but not used.
7517 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7518 All callers changed.
7519 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7520 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7521 (decode_coding_charset): Remove vars that are set but not used.
7522
1be4d761
PE
7523 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7524 that is set but not used.
7525
47553fa8
PE
7526 * print.c (print_object): Remove var that is set but not used.
7527
1f7196bf 7528 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7529 The gnulib version avoids calling malloc in the usual case,
7530 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7531 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7532 * filelock.c (current_lock_owner): Likewise.
7533 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7534 * sysdep.c: Include allocator.h, careadlinkat.h.
7535 (emacs_no_realloc_allocator): New static constant.
7536 (emacs_readlink): New function.
fdb61804
PE
7537 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7538 ../lib/careadlinkat.h.
d1fdcab7 7539
f84c17c7
SM
75402011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7541
7542 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7543 first non-nil return value).
7544
ef3862ad
JD
75452011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7546
7547 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7548 if not defined (Bug#8403).
7549
376a7006
JB
75502011-04-02 Juanma Barranquero <lekktu@gmail.com>
7551
7552 * xdisp.c (display_count_lines): Remove parameter `start',
7553 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7554 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7555 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7556 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7557 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7558 and thereabouts. All callers changed.
7559 (get_per_char_metric): Remove parameter `f', unused since
7560 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7561
6ca3801d
JM
75622011-04-02 Jim Meyering <meyering@redhat.com>
7563
7564 do not dereference NULL upon failed strdup
7565 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7566 (ns_get_family): Likewise.
7567
d8e2b5ba
JB
75682011-04-02 Juanma Barranquero <lekktu@gmail.com>
7569
7570 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7571
8c74fcbd
JD
75722011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7573
7574 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7575 later (Bug#8403).
7576
7200d79c
SM
75772011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7578
03408648 7579 Add lexical binding.
7200d79c 7580
03408648
SM
7581 * window.c (Ftemp_output_buffer_show): New fun.
7582 (Fsave_window_excursion):
7583 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7584
7585 * lread.c (lisp_file_lexically_bound_p): New function.
7586 (Fload): Bind Qlexical_binding.
7587 (readevalloop): Remove `evalfun' arg.
7588 Bind Qinternal_interpreter_environment.
7589 (Feval_buffer): Bind Qlexical_binding.
7590 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7591 Mark as dynamic.
7592 (syms_of_lread): Declare `lexical-binding'.
7593
7594 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7595
7596 * keyboard.c (eval_dyn): New fun.
7597 (menu_item_eval_property): Use it.
ca105506
SM
7598
7599 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7600
03408648
SM
7601 * fns.c (concat, mapcar1): Accept byte-code-functions.
7602
7603 * eval.c (Fsetq): Handle lexical vars.
7604 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7605 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7606 (FletX, Flet): Obey lexical binding.
7607 (Fcommandp): Handle closures.
7608 (Feval): New `lexical' arg.
7609 (eval_sub): New function extracted from Feval. Use it almost
7610 everywhere where Feval was used. Look up vars in lexical env.
7611 Handle closures.
7612 (Ffunctionp): Move from subr.el.
7613 (Ffuncall): Handle closures.
7614 (apply_lambda): Remove `eval_flags'.
7615 (funcall_lambda): Handle closures and new byte-code-functions.
7616 (Fspecial_variable_p): New function.
7617 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7618 but without exporting it to Lisp.
23aba0ea 7619
23aba0ea 7620 * doc.c (Fdocumentation, store_function_docstring):
03408648 7621 * data.c (Finteractive_form): Handle closures.
23aba0ea 7622
03408648
SM
7623 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7624 interactive spec.
ba83908c 7625
04f2d78b
CB
7626 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7627 New byte-codes.
03408648
SM
7628 (exec_byte_code): New function extracted from Fbyte_code to handle new
7629 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7630
03408648 7631 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7632
03408648 7633 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7634
e2abce01
JB
76352011-03-31 Juanma Barranquero <lekktu@gmail.com>
7636
7637 * xdisp.c (redisplay_internal): Fix prototype.
7638
63696a73 76392011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7640
63696a73 7641 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7642 (try_scrolling): Use it when setting scroll_limit.
7643 Limit scrolling to 100 screen lines.
63696a73
EZ
7644 (redisplay_window): Even when falling back on "recentering",
7645 position point in the window according to scroll-conservatively,
7646 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7647
7648 (try_scrolling): When point is above the window, allow searching
7649 as far as scroll_max, or one screenful, to compute vertical
7650 distance from PT to the scroll margin position. This prevents
7651 try_scrolling from unnecessarily failing when
7652 scroll-conservatively is set to a value slightly larger than the
7653 window height. Clean up the case of PT below the margin at bottom
7654 of window: scroll_max can no longer be INT_MAX. When aggressive
7655 scrolling is in use, don't let point enter the opposite scroll
7656 margin as result of the scroll.
7657 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7658 threshold of 100 lines for never-recentering scrolling.
7659
e4cc2dfc
JB
76602011-03-31 Juanma Barranquero <lekktu@gmail.com>
7661
7662 * dispextern.h (move_it_by_lines):
7663 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7664 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7665 (message_log_check_duplicate): Remove parameters `prev_bol' and
7666 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7667 (redisplay_internal): Remove parameter `preserve_echo_area',
7668 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7669
7670 * indent.c (Fvertical_motion):
7671 * window.c (window_scroll_pixel_based, Frecenter):
7672 Don't pass `need_y_p' to `move_it_by_lines'.
7673
1c470562
SM
76742011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7675
44f230aa
SM
7676 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7677 steal a few bits to be more compact.
7678 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7679 Remove unneeded casts.
7680
1c470562
SM
7681 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7682
888adce9
ZK
76832011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7684
7685 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7686 binding" message (bug#7967).
7687
f838ed7b
PE
76882011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7689
77861b95
PE
7690 Fix more problems found by GCC 4.6.0's static checks.
7691
de6dbc14
PE
7692 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7693 Remove unused local var.
7694
f838ed7b
PE
7695 * editfns.c (Fmessage_box): Remove unused local var.
7696
792c7b2b
PE
7697 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7698 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7699 Omit unused local vars.
c499e557 7700 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7701 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7702 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7703 Omit unused local var.
7704
ba0165e1
PE
7705 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7706 Don't assume string length fits in int.
32ad8845 7707 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7708 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7709
3c59b4c9
PE
7710 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7711 instead of alloca (Bug#8344).
7712
a3eed478 7713 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7714 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7715
eb4d412d
PE
7716 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7717
1658b401
PE
7718 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7719 concerns.
7720
7721 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7722
7723 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7724
9a2c6e05
PE
7725 * keyboard.c (syms_of_keyboard): Use the same style as later
7726 in this function when indexing through an array. This also
7727 works around GCC bug 48267.
7728
03d0a109
PE
7729 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7730
44f730c8
PE
7731 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7732
fe75f926
PE
7733 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7734 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7735
ffa8c828
PE
7736 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7737 This avoids undefined behavior on integer overflow, and is a bit
7738 more convenient anyway since it is compared to a size_t variable.
7739
c5101a77
PE
7740 Variadic C functions now count arguments with size_t, not int.
7741 This avoids an unnecessary limitation on 64-bit machines, which
7742 caused (substring ...) to crash on large vectors (Bug#8344).
7743 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7744 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7745 All variadic functions and their callers changed accordingly.
c5101a77
PE
7746 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7747 * data.c (arith_driver, float_arith_driver): Likewise.
7748 * editfns.c (general_insert_function): Likewise.
7749 * eval.c (struct backtrace.nargs, interactive_p)
7750 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7751 (funcall_lambda, mark_backtrace): Likewise.
7752 * fns.c (concat): Likewise.
7753 * frame.c (x_set_frame_parameters): Likewise.
7754 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7755 0 if not found, not -1. All callers changed.
7756
dd3f25f7
PE
7757 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7758 (stack_copy_size): Now size_t, not int.
7759 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7760
461c2ab9
JB
77612011-03-28 Juanma Barranquero <lekktu@gmail.com>
7762
7763 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7764 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7765 All callers changed.
7766
7767 * lisp.h (multibyte_char_to_unibyte):
7768 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7769 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7770 * character.h (CHAR_TO_BYTE8):
7771 * cmds.c (internal_self_insert):
7772 * editfns.c (general_insert_function):
7773 * keymap.c (push_key_description):
7774 * search.c (Freplace_match):
7775 * xdisp.c (message_dolog, set_message_1): All callers changed.
7776
f6d62986
SM
77772011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7778
7779 * keyboard.c (safe_run_hook_funcall): New function.
7780 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7781 don't set the hook to nil, but remove the offending function instead.
7782 (Qcommand_hook_internal): Remove, unused.
7783 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7784 Vcommand_hook_internal.
7785
7786 * eval.c (enum run_hooks_condition): Remove.
7787 (funcall_nil, funcall_not): New functions.
7788 (run_hook_with_args): Call each function through a `funcall' argument.
7789 Remove `cond' argument, now redundant.
7790 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7791 (Frun_hook_with_args_until_failure): Adjust accordingly.
7792 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7793
1db5b1ad
JB
77942011-03-28 Juanma Barranquero <lekktu@gmail.com>
7795
7796 * dispextern.h (string_buffer_position): Remove declaration.
7797
7798 * print.c (strout): Remove parameter `multibyte', unused since
7799 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7800
7801 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7802 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7803 All callers changed.
7804
7805 * w32.c (_wsa_errlist): Use braces for struct initializers.
7806
7807 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7808 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7809 All callers changed.
7810 (string_buffer_position): Likewise. Also, make static (it's never
7811 used outside xdisp.c).
7812 (cursor_row_p): Remove parameter `w', unused since
7813 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7814 (decode_mode_spec): Remove parameter `precision', introduced during
7815 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7816 All callers changed.
7817
5ffb62aa
JD
78182011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7819
7820 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7821
461c2ab9 78222011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7823
7824 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7825 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7826 (ns_update_auto_hide_menu_bar): New functions.
7827 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7828 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7829 ns_constrain_all_frames.
7830 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7831 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7832
5c380ffb
JD
78332011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7834
7835 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7836
9af30bdf
GM
78372011-03-27 Glenn Morris <rgm@gnu.org>
7838
7839 * syssignal.h: Replace RETSIGTYPE with void.
7840 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7841 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7842 Replace SIGTYPE with void everywhere.
7843 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7844 * s/template.h (SIGTYPE): Remove commented out definition.
7845
e2abce01
JB
78462011-03-26 Eli Zaretskii <eliz@gnu.org>
7847
7848 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7849 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7850
f868cd8a
JB
78512011-03-26 Juanma Barranquero <lekktu@gmail.com>
7852
59eb0929
JB
7853 * w32.c (read_unc_volume): Use parameter `henum', instead of
7854 global variable `wget_enum_handle'.
7855
7856 * keymap.c (describe_vector): Remove parameters `indices' and
7857 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7858 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7859
f868cd8a
JB
7860 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7861
7862 * keyboard.c (timer_check): Remove parameter `do_it_now',
7863 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7864 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7865 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7866
7867 * keyboard.c (read_char):
7868 * w32menu.c (w32_menu_display_help):
7869 * xmenu.c (show_help_event, menu_help_callback):
7870 Adjust calls to `show_help_echo'.
7871
7872 * gtkutil.c (xg_maybe_add_timer):
7873 * keyboard.c (readable_events):
7874 * process.c (wait_reading_process_output):
7875 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7876
7877 * insdel.c (adjust_markers_gap_motion):
7878 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7879 (gap_left, gap_right): Don't call it.
7880
2ecf6fdb
CY
78812011-03-25 Chong Yidong <cyd@stupidchicken.com>
7882
7883 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7884 incurred during fontification.
7885
6b1f9ba4
JB
78862011-03-25 Juanma Barranquero <lekktu@gmail.com>
7887
7888 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7889 (DEFVAR_PER_BUFFER): Don't pass it.
7890
7891 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7892 (scrolling_window): Don't pass it.
7893
0f4a96b5
JB
78942011-03-25 Juanma Barranquero <lekktu@gmail.com>
7895
7896 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7897
7898 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7899 and `suffix'.
7900 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7901 of variables specific to SELinux and computation of `encoded_absname'.
7902
7903 * image.c (XPutPixel): Remove unused variable `height'.
7904
7905 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7906
7907 * unexw32.c (get_section_info): Remove unused variable `section'.
7908
7909 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7910 (system_process_attributes): Remove unused variable `sess'.
7911 (sys_read): Remove unused variable `err'.
7912
7913 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7914 (w32_wnd_proc): Remove unused variable `isdead'.
7915 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7916 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7917 (x_create_tip_frame): Remove unused variable `tem'.
7918
7919 * w32inevt.c (w32_console_read_socket):
7920 Remove unused variable `no_events'.
7921
7922 * w32term.c (x_draw_composite_glyph_string_foreground):
7923 Remove unused variable `width'.
7924
1149507c
JB
79252011-03-24 Juanma Barranquero <lekktu@gmail.com>
7926
7927 * w32term.c (x_set_glyph_string_clipping):
7928 Don't pass uninitialized region to CombineRgn.
7929
9c88f339
JB
79302011-03-23 Juanma Barranquero <lekktu@gmail.com>
7931
7932 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7933 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7934 (Fx_close_connection): Remove unused variable `i'.
7935
7936 * w32font.c (w32font_draw): Return number of glyphs.
7937 (w32font_open_internal): Remove unused variable `i'.
7938 (w32font_driver): Add missing initializer.
7939
7940 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7941 (fill_in_menu): Remove unused variable `items_added'.
7942
7943 * w32term.c (last_mouse_press_frame): Remove static global variable.
7944 (w32_clip_to_row): Remove unused variable `f'.
7945 (x_delete_terminal): Remove unused variable `i'.
7946
7947 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7948 (NOTHING): Remove unused static global variable.
7949 (uniscribe_check_otf): Remove unused variable `table'.
7950 (uniscribe_font_driver): Add missing initializers.
7951
dee091a3
JD
79522011-03-23 Julien Danjou <julien@danjou.info>
7953
7954 * term.c (Fsuspend_tty, Fresume_tty):
7955 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7956 * window.c (temp_output_buffer_show):
7957 * insdel.c (signal_before_change):
7958 * frame.c (Fhandle_switch_frame):
7959 * fileio.c (Fdo_auto_save):
7960 * emacs.c (Fkill_emacs):
7961 * editfns.c (save_excursion_restore):
7962 * cmds.c (internal_self_insert):
7963 * callint.c (Fcall_interactively):
7964 * buffer.c (Fkill_all_local_variables):
7965 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7966 Use Frun_hooks.
0f4a96b5 7967 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7968 unconditionally since it does the check itself.
dee091a3 7969
2c520ab5 79702011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7971
c9c49752
PE
7972 Fix more problems found by GCC 4.5.2's static checks.
7973
8abc3f12
PE
7974 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7975 the first time through the loop, since we know p0 < p1 then.
7976 This also avoids a gcc -Wstrict-overflow warning.
7977
a2d26660
PE
7978 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7979 leading to a memory leak, possible in functions like
7980 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7981 of objects (Bug#8318).
a2d26660 7982
916c72e9
PE
7983 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7984 that could (at least in theory) be that large.
7985
19ab8a18
PE
7986 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7987 This is less likely to overflow, and avoids undefined behavior if
7988 overflow does occur. All callers changed. Use strtoul to scan
7989 for the unsigned long integer.
b7cbbd6f
PE
7990 (pint2hrstr): Simplify and tune code slightly.
7991 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7992
f0641eff
PE
7993 * scroll.c (do_scrolling): Work around GCC bug 48228.
7994 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7995
7f650bb9
PE
7996 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7997 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7998 (validate_x_resource_name): Simplify count usage.
7999 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8000
37dd57d1
PE
8001 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8002 fail (Bug#8306).
81e56e61 8003
699979fc 8004 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8005
401bf9b4
PE
8006 * process.c (Fmake_network_process): Use socklen_t, not int,
8007 where POSIX says socklen_t is required in portable programs.
8008 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8009 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8010 (Fmake_network_process, server_accept_connection):
8011 (wait_reading_process_output, read_process_output):
8012 Likewise.
8013
b93aacde
PE
8014 * process.c: Rename or move locals to avoid shadowing.
8015 (list_processes_1, Fmake_network_process):
8016 (read_process_output_error_handler, exec_sentinel_error_handler):
8017 Rename or move locals.
4dc343ee 8018 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8019 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8020 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8021 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8022 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8023
af8a867c 8024 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8025 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8026 Include tparam.h instead, since it declares them.
af8a867c
PE
8027 * cm.h (PC): Remove extern decl; tparam.h now does this.
8028 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8029 * terminfo.c: Include tparam.h, to check interfaces.
8030 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8031 (tparam): Adjust signature to match interface in tparam.h;
8032 this removes some undefined behavior. Check that outstring and len
8033 are zero, which they always are with Emacs.
8034 * tparam.h (PC, BC, UP): New extern decls.
8035
0248044d 8036 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8037 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8038
8ff096c1 8039 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8040 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8041 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8042 (ftfont_list): Remove unused local.
49eaafba
PE
8043 (get_adstyle_property, ftfont_pattern_entity):
8044 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8045 Rename locals to avoid shadowing.
8ff096c1 8046
e2be39f6
PE
8047 * xfont.c (xfont_list_family): Mark var as initialized.
8048
c9735e30
PE
8049 * xml.c (make_dom): Now static.
8050
8f5201ae
PE
8051 * composite.c (composition_compute_stop_pos): Rename local to
8052 avoid shadowing.
b246f932
PE
8053 (composition_reseat_it): Remove unused locals.
8054 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8055 (composition_update_it): Mark var as initialized.
11b61122
PE
8056 (find_automatic_composition): Mark vars as initialized,
8057 with a FIXME (Bug#8290).
8f5201ae 8058
760fbc2c
PE
8059 character.h: Rename locals to avoid shadowing.
8060 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8061 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8062 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8063 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8064 to avoid shadowing.
8065
ff08eb85
PE
8066 * textprop.c (property_change_between_p): Remove; unused.
8067
fc7bf025
PE
8068 * intervals.c (interval_start_pos): Now static.
8069
235d7abc
PE
8070 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8071
44f230aa
SM
8072 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8073 Rename locals to avoid shadowing.
3e7d6594 8074
50060332
PE
8075 * sound.c (wav_play, au_play, Fplay_sound_internal):
8076 Fix pointer signedness.
d01f234b 8077 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8078 (wav_play): Initialize a variable to 0, to prevent undefined
8079 behavior (Bug#8278).
50060332 8080
c4fc4e30
PE
8081 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8082
918436ed
PE
8083 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8084
c939f91b
PE
8085 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8086 clobbering (Bug#8298).
b9c7f648
PE
8087 * sysdep.c (sys_subshell): Likewise.
8088 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8089
6bd8c144
PE
8090 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8091 This should get cleaned up, so that child_setup has the
8092 same signature on all platforms.
8093
7710357c 8094 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8095 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8096
c59da222
CY
80972011-03-22 Chong Yidong <cyd@stupidchicken.com>
8098
8099 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8100 not to be necessary, and produces flickering.
8101
66b87493
GM
81022011-03-20 Glenn Morris <rgm@gnu.org>
8103
8104 * config.in: Remove file.
8105
45b6f6d5
JB
81062011-03-20 Juanma Barranquero <lekktu@gmail.com>
8107
8108 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8109 are now in src/globals.h.
8110 (syms_of_minibuf): Remove spurious & from previous change.
8111
3ec03f7e
LL
81122011-03-20 Leo <sdl.web@gmail.com>
8113
8114 * minibuf.c (completing-read-function): New variable.
8115 (completing-read-default): Rename from completing-read.
8116 (completing-read): Call completing-read-function.
8117
b14e3e21
CY
81182011-03-19 Juanma Barranquero <lekktu@gmail.com>
8119
8120 * xfaces.c (Fx_load_color_file):
8121 Read color file from absolute filename (bug#8250).
8122
f2b726e6
JB
81232011-03-19 Juanma Barranquero <lekktu@gmail.com>
8124
8125 * makefile.w32-in: Update dependencies.
8126
09f6ff02
EZ
81272011-03-17 Eli Zaretskii <eliz@gnu.org>
8128
8129 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8130
29a6015a
PE
81312011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8132
a3a6c54e
PE
8133 Fix more problems found by GCC 4.5.2's static checks.
8134
b766f867
PE
8135 * process.c (make_serial_process_unwind, send_process_trap):
8136 (sigchld_handler): Now static.
8137
be02381c
PE
8138 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8139 That way, the code declares only the vars that it needs.
8140 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8141 * s/cygwin.h (PTY_ITERATION): Likewise.
8142 * s/darwin.h (PTY_ITERATION): Likewise.
8143 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8144
57048744
PE
8145 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8146 * process.c (allocate_pty): Don't declare stb unless it's needed.
8147
7914961c 8148 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8149 (CONSTANTLIM): Remove; unused.
8150 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8151 Define only if needed.
7914961c 8152
b3967b18
PE
8153 * unexelf.c (unexec): Name an expression,
8154 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8155 Use a different way to cause a compilation error if anyone uses
8156 n rather than nn, a way that does not involve shadowing.
73366a00 8157 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8158
29a6015a
PE
8159 * deps.mk (unexalpha.o): Remove; unused.
8160
43cfc33e 8161 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8162 * unexec.h: New file.
ce701a33
PE
8163 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8164 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8165 Depend on unexec.h.
8166 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8167 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8168 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8169 Change as necessary to match prototype in unexec.h.
ce701a33 8170
01f44d5a
PE
8171 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8172 shadowing.
4f63c6bb 8173 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8174
a6670b0b
PE
8175 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8176 Rename locals to avoid shadowing.
8177
cef2010d 8178 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8179 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8180
d4d7173a
PE
8181 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8182
f08b802a
PE
8183 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8184 warning when compiling print.c.
8185
3ddb0639
PE
8186 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8187 instead of using an uninitialized var.
5ad03b97 8188 (font_sort_entities): Mark var as initialized.
3ddb0639 8189
170a2692
PE
8190 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8191
e663c700
PE
8192 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8193 pointers to constants.
89bc529a 8194 (font_parse_fcname): Remove unused vars.
7b81e2d0 8195 (font_delete_unmatched): Now static.
ea838e10 8196 (font_get_spec): Remove; unused.
13a547c6
PE
8197 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8198 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8199 Rename or move locals to avoid shadowing.
e663c700 8200
2a80c887 8201 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8202 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8203
1384fa33 8204 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8205 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8206
8b2c52e9
PE
8207 * alloc.c (mark_backtrace): Move decl from here ...
8208 * lisp.h: ... to here, so that it can be checked.
8209
475545b5 8210 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8211 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8212 (lisp_indirect_variable): Name an expression,
8213 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8214 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8215
b1349114 8216 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8217 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8218 Use const pointer when appropriate.
b1349114 8219
a2928364
PE
8220 * lisp.h (get_system_name, get_operating_system_release):
8221 Move decls here, to check interfaces.
8222 * process.c (get_operating_system_release): Move decl to lisp.h.
8223 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8224 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8225 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8226 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8227 (Fformat_time_string, Fencode_time, Finsert_char):
8228 (Ftranslate_region_internal, Fformat):
8229 Rename or remove local vars to avoid shadowing.
9710023e 8230 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8231
a415e694
PE
8232 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8233 avoid shadowing.
8234
8ef4622d
PE
8235 * lisp.h (eassert): Check that the argument compiles, even if
8236 ENABLE_CHECKING is not defined.
8237
946f9a5b
PE
8238 * data.c (Findirect_variable): Name an expression, to avoid
8239 gcc -Wbad-function-cast warning.
112396d6 8240 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8241 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8242 (Fmake_variable_buffer_local, Fmake_local_variable):
8243 Mark variables as initialized.
52746918 8244 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8245
e5aab7e7 8246 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8247 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8248 Rename locals to avoid shadowing.
dff45157
PE
8249 (mark_stack): Move local variables into the #ifdef region where
8250 they're used.
7bc26fdb
PE
8251 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8252 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8253 needed otherwise.
8254 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8255 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8256 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8257
e5aab7e7
PE
8258 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8259 avoids undefined behavior in theory.
8260
4da60324
PE
8261 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8262
88043301
PE
8263 Use functions, not macros, for up- and down-casing (Bug#8254).
8264 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8265 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8266 to use the following functions instead of these macros.
8267 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8268 EMACS_INT, since callers assume the returned value fits in int.
8269 (upcase1): Likewise, for UPCASE_TABLE.
8270 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8271 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8272 the race-condition problem in the old DOWNCASE.
88043301 8273
19ed5445
PE
8274 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8275 Rename locals to avoid shadowing.
8276 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8277 (regex_compile, re_search_2, re_match_2_internal):
8278 Remove unused local vars.
952db0d7
PE
8279 (FREE_VAR): Rewrite so as not to use empty "else",
8280 which gcc can warn about.
da053e48 8281 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8282 (RETALLOC_IF): Define only if needed.
8283 (WORDCHAR_P): Likewise. This one is never needed, but is used
8284 only in a comment talking about a compiler bug, so put inside
8285 the #if 0 of that comment.
8286 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8287 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8288 Remove; unused.
19ed5445 8289
1f3561e4 8290 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8291 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8292 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8293
ded6f8f7
PE
8294 * search.c (simple_search): Remove unused var.
8295
dbd37a95
PE
8296 * dired.c (compile_pattern): Move decl from here ...
8297 * lisp.h: ... to here, so that it can be checked.
8298 (struct re_registers): New forward decl.
8299
7e47afad
PE
8300 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8301
85f24f61
PE
8302 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8303 All uses changed.
8304 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8305 Rename locals to avoid shadowing.
5671df8f 8306 (Fvertical_motion): Mark locals as initialized.
85f24f61 8307
181aa2be 8308 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8309 (casify_region): Mark local as initialized.
181aa2be 8310
930d429c
PE
8311 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8312
7082eac6
PE
8313 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8314 New macros, so that the caller can use some names other than
8315 gcpro1, gcpro2, etc.
8316 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8317 of the new macros.
8318 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8319 argument, for consistency with GCPRO2_VAR, etc: it is now the
8320 prefix of the variable, not the variable itself. All uses
8321 changed.
38b2c076
PE
8322 * dired.c (directory_files_internal, file_name_completion):
8323 Rename locals to avoid shadowing.
8324
15206ed9
PE
8325 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8326 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8327 dired.c's scmp function, had undefined behavior.
8328 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8329 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8330 * buffer.h: ... to here, because these macros use current_buffer,
8331 and the new implementation with inline functions needs to have
8332 current_buffer in scope now, rather than later when the macros
8333 are used.
8334 (downcase, upcase1): New static inline functions.
8335 (DOWNCASE, UPCASE1): Reimplement using these functions.
8336 This avoids undefined behavior in expressions like
8337 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8338 from race conditions in accessing the global variables
8339 case_temp1 and case_temp2.
8340 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8341 * lisp.h (case_temp1, case_temp2): Remove their decls.
8342 * character.h (ASCII_CHAR_P): Move from here ...
8343 * lisp.h: ... to here, so that the inline functions mentioned
8344 above can use them.
8345
4a6bea26
PE
8346 * dired.c (directory_files_internal_unwind): Now static.
8347
f14b7e14
PE
8348 * fileio.c (file_name_as_directory, directory_file_name):
8349 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8350 Now static.
2893f146
PE
8351 (file_name_as_directory): Use const pointers when appropriate.
8352 (Fexpand_file_name): Likewise. In particular, newdir might
8353 point at constant storage, so make it a const pointer.
fd4ead52 8354 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8355 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8356 signedness issues.
f839df0c
PE
8357 (Fset_file_times, Finsert_file_contents, auto_save_error):
8358 Rename locals to avoid shadowing.
f14b7e14 8359
5716756e 8360 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8361 (Ftry_completion, Fall_completions): Rename or remove locals
8362 to avoid shadowing.
5716756e 8363
b4c3046a
PE
8364 * marker.c (bytepos_to_charpos): Remove; unused.
8365
b45db522
PE
8366 * lisp.h (verify_bytepos, count_markers): New decls,
8367 so that gcc does not warn that these functions aren't declared.
8368
85876d07
PE
8369 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8370 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8371 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8372 (copy_text): Remove unused local var.
85876d07 8373
03d78a21 8374 * filelock.c (within_one_second): Now static.
b3dd38ab 8375 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8376
5df8f01b
PE
8377 * buffer.c (fix_overlays_before): Mark locals as initialized.
8378 (fix_start_end_in_overlays): Likewise. This function should be
8379 simplified by using pointers-to-pointers, but that's a different
8380 matter.
b1d876f1 8381 (switch_to_buffer_1): Now static.
8f54f30a
PE
8382 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8383 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8384
a70072c9 8385 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8386 Fix pointer signedness issue.
edced198
PE
8387 (sys_subshell): Mark local as volatile if checking for lint,
8388 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8389 (MAXPATHLEN): Define only if needed.
a70072c9 8390
a0977c44
PE
8391 * process.c (serial_open, serial_configure): Move decls from here ...
8392 * systty.h: ... to here, so that they can be checked.
8393
a884fdcc
PE
8394 * fns.c (get_random, seed_random): Move extern decls from here ...
8395 * lisp.h: ... to here, so that they can be checked.
8396
604efe86 8397 * sysdep.c (reset_io): Now static.
b8950c94 8398 (wait_for_termination_signal): Remove; unused.
604efe86 8399
38fc62d9
PE
8400 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8401 (copy_keymap_item, append_key, push_text_char_description):
8402 Now static.
1004a21a 8403 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8404 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8405 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8406 (describe_map_tree):
8407 Rename locals to avoid shadowing.
38fc62d9 8408
2f2650da
PE
8409 * keyboard.c: Declare functions static if they are not used elsewhere.
8410 (echo_char, echo_dash, cmd_error, top_level_2):
8411 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8412 (read_char, kbd_buffer_get_event, make_lispy_position):
8413 (make_lispy_event, make_lispy_movement, apply_modifiers):
8414 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8415 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8416 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8417 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8418 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8419
a053e86c 8420 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8421 (mark_kboards): Move decl here ...
8422 * alloc.c (mark_kboards): ... from here.
a053e86c 8423
4752793e
PE
8424 * lisp.h (force_auto_save_soon): New decl.
8425
74f10ca7 8426 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8427 (DEFINE_DUMMY_FUNCTION): New macro.
8428 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8429 Use it.
c03cd23f
PE
8430 (main): Add casts to avoid warnings
8431 if GCC considers string literals to be constants.
74f10ca7 8432
022e70d4
PE
8433 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8434
59d6fe83
PE
8435 * dbusbind.c: Pointer signedness fixes.
8436 (xd_signature, xd_append_arg, xd_initialize):
8437 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8438 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8439 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8440 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8441
78320123
PE
8442 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8443 if GCC considers string literals to be constants.
49cebcca 8444 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8445
35ac2a97
SM
84462011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8447
fb103ca9
SM
8448 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8449 (print_preprocess, print_object): New macro to fix last change.
8450
35ac2a97
SM
8451 * print.c (print_preprocess): Don't forget font objects.
8452
62973b41
JB
84532011-03-16 Juanma Barranquero <lekktu@gmail.com>
8454
8455 * emacs.c (USAGE3): Doc fixes.
8456
0e48bb22
AS
84572011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8458
8459 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8460 structure.
8461
7684e57b
JB
84622011-03-14 Juanma Barranquero <lekktu@gmail.com>
8463
8464 * lisp.h (VWindow_system, Qfile_name_history):
8465 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8466 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8467 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8468
8469 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8470 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8471
8472 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8473 * w32console.c (detect_input_pending, read_input_pending)
8474 (encode_terminal_code):
8475 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8476 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8477 (w32_system_caret_y, Qfile_name_history):
8478 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8479 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8480 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8481 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8482 * w32proc.c (Qlocal, report_file_error):
8483 * w32term.c (Vwindow_system, updating_frame):
8484 * w32uniscribe.c (initialized, uniscribe_font_driver):
8485 Remove unneeded extern declarations.
8486
2aa46d6c
CY
84872011-03-14 Chong Yidong <cyd@stupidchicken.com>
8488
c96bbc66 8489 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8490
cffc6f3b
CY
84912011-03-13 Chong Yidong <cyd@stupidchicken.com>
8492
8493 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8494 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8495 These macros can no longer be used for assignment.
8496
44f230aa
SM
8497 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8498 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8499 (record_buffer_markers, fetch_buffer_markers): New functions for
8500 recording and fetching special buffer markers.
8501 (set_buffer_internal_1, set_buffer_temp): Use them.
8502
8503 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8504
8505 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8506
8507 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8508 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8509
8510 * xdisp.c (hscroll_window_tree):
8511 (reconsider_clip_changes): Use PT instead of BUF_PT.
8512
d251f04b
EZ
85132011-03-13 Eli Zaretskii <eliz@gnu.org>
8514
8515 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8516 $(EMACS_ROOT)/lib/intprops.h.
8517
f0c77cd1
PE
85182011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8519
3eca4629
PE
8520 Fix more problems found by GCC 4.5.2's static checks.
8521
7c86ee98
PE
8522 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8523 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8524 (xg_free_frame_widgets): Make it clear that a local variable is
8525 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8526 (gdk_window_get_screen): Make it clear that this macro is needed
8527 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8528 (int_gtk_range_get_value): New function, which avoids a diagnostic
8529 from gcc -Wbad-function-cast.
8530 (xg_set_toolkit_scroll_bar_thumb): Use it.
8531 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8532 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8533 (get_utf8_string, xg_get_file_with_chooser):
8534 Rename locals to avoid shadowing.
8535 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8536
41729b81
PE
8537 * xgselect.c (xg_select): Remove unused var.
8538
f0c77cd1
PE
8539 * image.c (four_corners_best): Mark locals as initialized.
8540 (gif_load): Initialize transparent_p to zero (Bug#8238).
8541 Mark another local as initialized.
ec6cf4c6 8542 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8543
ce0ad53d 8544 * image.c (clear_image_cache): Now static.
d5d5a617 8545 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8546 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8547 (x_edge_detection): Remove unnecessary cast that
8548 gcc -Wbad-function-cast diagnoses.
2037898d 8549 (gif_load): Fix pointer signedness.
6ae141d6
PE
8550 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8551 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8552
33383987 85532011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8554
d32df629
PE
8555 Improve quality of tests for time stamp overflow.
8556 For example, without this patch (encode-time 0 0 0 1 1
8557 1152921504606846976) returns the obviously-bogus value (-948597
8558 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8559 reports time overflow. See
8560 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8561 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8562 * editfns.c: Include limits.h and intprops.h.
8563 (TIME_T_MIN, TIME_T_MAX): New macros.
8564 (time_overflow): Move earlier, to before first use.
8565 (hi_time, lo_time): New functions, for an accurate test for
8566 out-of-range times.
8567 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8568 (Fget_internal_run_time): Don't assume time_t fits in int.
8569 (make_time): Use list2 instead of Fcons twice.
8570 (Fdecode_time): More accurate test for out-of-range times.
8571 (check_tm_member): New function.
8572 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8573 (lisp_time_argument): Don't rely on undefined left-shift and
8574 right-shift behavior when checking for time stamp overflow.
8be6f318 8575
fe31d94c
PE
8576 * editfns.c (time_overflow): New function, refactoring common code.
8577 (Fformat_time_string, Fdecode_time, Fencode_time):
8578 (Fcurrent_time_string): Use it.
8579
8be6f318
PE
8580 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8581 * dired.c (make_time): Move to ...
8582 * editfns.c (make_time): ... here.
8583 * systime.h: Note the move.
8584
09d9db2c 85852011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8586
126bc0dc
YM
8587 * fringe.c (update_window_fringes): Remove unused variables.
8588
c47cbdfd
YM
8589 * unexmacosx.c (copy_data_segment): Also copy __got section.
8590 (Bug#8223)
8591
7ac80be9
EZ
85922011-03-12 Eli Zaretskii <eliz@gnu.org>
8593
c96bbc66 8594 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8595 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8596 Constify `char *' arguments and their references according to
8597 prototypes in tparam.h.
8598
ecb0f94d 8599 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8600
7ac80be9
EZ
8601 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8602 Adapt all references accordingly.
8603
8604 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8605
ef1fd07e
TT
86062011-03-11 Tom Tromey <tromey@redhat.com>
8607
8608 * buffer.c (syms_of_buffer): Remove obsolete comment.
8609
7ef4b50c
EZ
86102011-03-11 Eli Zaretskii <eliz@gnu.org>
8611
8612 * termhooks.h (encode_terminal_code): Declare prototype.
8613
8614 * msdos.c (encode_terminal_code): Don't declare prototype.
8615
8616 * term.c (encode_terminal_code): Now external again, used by
8617 w32console.c and msdos.c.
8618
44f230aa
SM
8619 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8620 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8621
4b1ec863 86222011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8623
1714f52b 8624 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8625
4b1ec863
PE
8626 * fringe.c (update_window_fringes): Mark locals as initialized
8627 (Bug#8227).
8628 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8629
524c7aa6
PE
8630 * alloc.c (mark_fringe_data): Move decl from here ...
8631 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8632 to check its interface.
8633 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8634
a5c0af81 8635 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8636 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8637 (fontset_font): Mark local as initialized.
a9a06e0b 8638 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8639
b4716021
PE
8640 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8641
811e9bac 8642 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8643 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8644 (x_own_selection, Fx_disown_selection_internal): Rename locals
8645 to avoid shadowing.
8646 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8647
7e3ab302
PE
8648 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8649 so that the caller can use some name other than gcpro1.
8650 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8651 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8652 (Fx_backspace_delete_keys_p):
8653 Use them to avoid shadowing, and rename vars to avoid shadowing.
8654 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8655 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8656 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8657 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8658 Remove unused locals.
7e3ab302
PE
8659 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8660 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8661 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8662 macros.
f78faa98 8663
e2b13473
PE
8664 * xterm.h (x_mouse_leave): New decl.
8665
77f23912
PE
8666 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8667 Remove unused functions.
cdf4ba58
PE
8668 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8669 (x_calc_absolute_position): Now static.
7411c686 8670 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8671 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8672 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8673 unless they are used.
38d0b34a
PE
8674 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8675 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8676 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8677 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8678 (x_error_catcher, x_connection_closed, x_error_handler):
8679 (x_error_quitter, xembed_send_message, x_iconify_frame):
8680 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8681 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8682 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8683
44f230aa
SM
8684 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8685 Rename or move locals to avoid shadowing.
6b463e58 8686 (tty_defined_color, merge_face_heights): Now static.
5967d051 8687 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8688 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8689 does not deduce is never used uninitialized.
73719eba
PE
8690 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8691 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8692
426994c3 8693 * terminal.c (store_terminal_param): Now static.
5489860b 8694
032f1620 8695 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8696 (set_frame_menubar): Remove unused local.
d4323972 8697 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8698 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8699 since they might point to immutable storage.
281585b0
PE
8700 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8701 since it's unused otherwise.
032f1620 8702
367c19e5 8703 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8704 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8705 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8706 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8707 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8708 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8709 does not deduce are never used uninitialized.
70739cbe 8710
07b48fa9
PE
8711 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8712
8868a238 8713 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8714 * window.c (window_loop, size_window):
8715 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8716
7e5cf297 8717 * window.c (display_buffer): Now static.
d6550a9f
PE
8718 (size_window): Mark variables that gcc -Wuninitialized
8719 does not deduce are never used uninitialized.
a586633d
PE
8720 * window.h (check_all_windows): New decl, to forestall
8721 gcc -Wmissing-prototypes diagnostic.
5b555da1 8722 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8723
f6095868
PE
8724 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8725 shadowing.
8726 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8727 Include <limits.h>.
8728 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8729 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8730 (load_charset_map): Mark variables that gcc -Wuninitialized
8731 does not deduce are never used uninitialized.
53df7c11 8732 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8733
f38b440c
PE
8734 * coding.c (coding_set_source, coding_set_destination):
8735 Use "else { /* comment */ }" rather than "else /* comment */;"
8736 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8737 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8738 a block, when the outer 'i' will do.
8739 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8740 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8741 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8742 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8743 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8744 Rename locals to avoid shadowing.
8745 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8746 * coding.c (emacs_mule_char, encode_invocation_designation):
8747 Now static, since they're not used elsewhere.
413bb2db 8748 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8749 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8750 (decode_coding_emacs_mule): Mark variables that gcc
8751 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8752 (detect_coding_iso_2022): Initialize a local variable that might
8753 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8754 this initialization is needed. (Bug#8211)
5f58e762
PE
8755 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8756 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8757 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8758 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8759 Remove unused macros.
f38b440c 8760
232b38b9 8761 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8762 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8763 * character.c (string_count_byte8): Likewise.
232b38b9 8764
fb90da1b
PE
8765 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8766 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8767
fb93dbc2
PE
8768 * chartab.c (copy_sub_char_table): Now static, since it's not used
8769 elsewhere.
5c156ace
PE
8770 (sub_char_table_ref_and_range, char_table_ref_and_range):
8771 Rename locals to avoid shadowing.
bbcd0949 8772 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8773
7d3b3862 8774 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8775 (BIDI_BOB): Remove unused macro.
7d3b3862 8776
6be7d3da
PE
8777 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8778 deduce are never used uninitialized.
c2ed9c8b 8779 * term.c (encode_terminal_code): Likewise.
6be7d3da 8780
75f8807f 8781 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8782
50938595
PE
8783 * tparam.h: New file.
8784 * term.c, tparam.h: Include it.
8785 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8786 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8787 Move these decls to tparam.h, and make them agree with what
8788 is actually in tparam.c. The previous trick of using incompatible
8789 decls in different modules does not conform to the C standard.
8790 All callers of tparam changed to use tparam's actual API.
8791 * tparam.c (tparam1, tparam, tgoto):
8792 Use const pointers where appropriate.
8793
fbceeba2
PE
8794 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8795 * cm.h (struct cm): Likewise.
8796 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8797 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8798 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8799 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8800 (turn_on_face, init_tty): Likewise.
8801 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8802
7f3f1250
PE
8803 * term.c (term_mouse_position): Rename local to avoid shadowing.
8804
e6ca6543
PE
8805 * alloc.c (mark_ttys): Move decl from here ...
8806 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8807
c40f8d15
AS
88082011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8809
8810 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8811
cfe0661d
JB
88122011-03-09 Juanma Barranquero <lekktu@gmail.com>
8813
8814 * search.c (compile_pattern_1): Remove argument regp, unused since
8815 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8816 (compile_pattern): Don't pass it.
8817
0afb4571
J
88182011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8819
8820 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8821 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8822 for ! HAVE_GTK3.
8823 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8824
8825 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8826
8827 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8828 gdk_window_get_screen, gdk_window_get_geometry,
8829 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8830 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8831 (xg_get_pixbuf_from_pixmap): New function.
8832 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8833 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8834 Call xg_get_pixbuf_from_pixmap instead of
8835 gdk_pixbuf_get_from_drawable.
8836 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8837 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8838 (xg_check_special_colors): Use GtkStyleContext and its functions
8839 for HAVE_GTK3.
8840 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8841 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8842 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8843 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8844 Call gtk_widget_get_preferred_size.
0afb4571
J
8845 (xg_frame_resized): gdk_window_get_geometry only takes 5
8846 parameters.
44f230aa
SM
8847 (xg_win_to_widget, xg_event_is_for_menubar):
8848 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8849 (xg_set_widget_bg): New function.
8850 (delete_cb): New function.
895009e1 8851 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8852 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8853 (xg_set_background_color): Call xg_set_widget_bg.
8854 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8855 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8856 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8857 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8858 if ! HAVE_GTK3.
8859 (update_frame_tool_bar): Call gtk_widget_hide.
8860 (xg_initialize): Use GDK_KEY_g.
8861
8862 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8863 if ! HAVE_GTK3
8864 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8865
8866 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8867 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8868 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8869
1c2cc4ef
JB
88702011-03-08 Juanma Barranquero <lekktu@gmail.com>
8871
8872 * w32xfns.c (select_palette): Check success of RealizePalette against
8873 GDI_ERROR, not zero.
8874
33383987 8875See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8876
8877;; Local Variables:
8878;; coding: utf-8
aac0c6e3
MR
8879;; End:
8880
33383987 8881 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8882
8883 This file is part of GNU Emacs.
8884
8885 GNU Emacs is free software: you can redistribute it and/or modify
8886 it under the terms of the GNU General Public License as published by
8887 the Free Software Foundation, either version 3 of the License, or
8888 (at your option) any later version.
8889
8890 GNU Emacs is distributed in the hope that it will be useful,
8891 but WITHOUT ANY WARRANTY; without even the implied warranty of
8892 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8893 GNU General Public License for more details.
8894
8895 You should have received a copy of the GNU General Public License
8896 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.