* xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4887c6e2 12011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2
e9829fdf
PE
3 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4 to read-only memory.
5
1086c095
PE
6 * fns.c (vector): Remove; this old hack is no longer needed.
7
2baccd04 8 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9 Remove unused var.
dde42981 10 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11
3565b346
PE
12 * xrdb.c (x_load_resources) [!USE_MOTIF]: Omit unused local.
13
436c16df 14 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 15 (x_window): Rename locals to avoid shadowing.
dc5ddd85 16 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 17
92bb796d 18 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 19 (x_term_init): Remove local to avoid shadowing.
92bb796d 20
764430a3 21 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
22
23 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
24 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
25
4170f62f 262011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 27
71b41406
PE
28 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
29
9587a89d
PE
30 emacs_write: Accept and return EMACS_INT for sizes.
31 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
32 et seq.
33 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
34 Accept and return EMACS_INT.
35 (emacs_gnutls_write): Return the number of bytes written on
36 partial writes.
37 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
38 (emacs_read, emacs_write): Remove check for negative size, as the
39 Emacs source code has been audited now.
9587a89d
PE
40 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
41 (emacs_read, emacs_write): Use it.
273a5f82
PE
42 * process.c (send_process): Adjust to the new signatures of
43 emacs_write and emacs_gnutls_write. Do not attempt to store
44 a byte offset into an 'int'; it might overflow.
9587a89d 45 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 46
3e047f51
PE
47 * sound.c: Don't assume sizes fit in 'int'.
48 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 49 Return EMACS_INT, not int.
3e047f51 50 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
51 Accept EMACS_INT, not int.
52 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
53 record read return values.
54
cc39a9db
BK
552011-04-15 Ben Key <bkey76@gmail.com>
56
57 * keyboard.c (Qundefined): Don't declare static since it is
58 used in nsfns.m.
59 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
60 declare static since they are used in nsfont.m.
61
6c60eb9f
SM
622011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
63
64 * process.c (Qprocessp): Don't declare static.
65 * lisp.h (Qprocessp): Declare again.
66
7990b61a
JB
672011-04-15 Juanma Barranquero <lekktu@gmail.com>
68
69 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
70
5d4cb038
PE
712011-04-14 Paul Eggert <eggert@cs.ucla.edu>
72
8bd7b830 73 Improve C-level modularity by making more things 'static'.
cd64ea1d 74
e3b27b31
PE
75 Don't publish debugger-only interfaces to other modules.
76 * lisp.h (safe_debug_print, debug_output_compilation_hack):
77 (verify_bytepos, count_markers): Move decls to the only modules
78 that need them.
79 * region-cache.h (pp_cache): Likewise.
80 * window.h (check_all_windows): Likewise.
81 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
82
5d4cb038
PE
83 * sysdep.c (croak): Now static, if
84 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
85 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
86
87 * alloc.c (refill_memory_reserve): Now static if
88 !defined REL_ALLOC || defined SYSTEM_MALLOC.
89 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 90
e87b6180
PE
91 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
92 Define only if USE_LUCID.
93
ac64929e
PE
94 * xrdb.c (x_customization_string, x_rm_string): Now static.
95
6f37259d
PE
96 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
97 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
98
1683e3ab
PE
99 * xdisp.c (draw_row_with_mouse_face): Now static.
100 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
101
de9c2632
PE
102 * window.h (check_all_windows): Mark externally visible.
103
2b96acb7
PE
104 * window.c (window_deletion_count): Now static.
105
106 * undo.c: Make symbols static if they're not exported.
107 (last_undo_buffer, last_boundary_position, pending_boundary):
108 Now static.
109
50436f33
PE
110 * textprop.c (interval_insert_behind_hooks): Now static.
111 (interval_insert_in_front_hooks): Likewise.
112
64520e5c
PE
113 * term.c: Make symbols static if they're not exported.
114 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
115 (max_frame_lines, tty_set_terminal_modes):
116 (tty_reset_terminal_modes, tty_turn_off_highlight):
117 (get_tty_terminal): Now static.
118 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
119 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 120 HAVE_WINDOW_SYSTEM.
64520e5c
PE
121 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
122 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
123
1fa53021
PE
124 * sysdep.c: Make symbols static if they're not exported.
125 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
126 Now static.
127 (sigprocmask_set, full_mask): Remove; unused.
128 (wait_debugging): Mark as visible.
129 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
130 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
131
d4b43b22
PE
132 * syntax.c (syntax_temp): Define only if !__GNUC__.
133
b7c513d0
PE
134 * sound.c (current_sound_device, current_sound): Now static.
135
989b29ad
PE
136 * search.c (searchbufs, searchbuf_head): Now static.
137
13a55a78
PE
138 * scroll.c (scroll_cost): Remove; unused.
139 * dispextern.h (scroll_cost): Remove decl.
140
de68a1fc
PE
141 * region-cache.h (pp_cache): Mark as externally visible.
142
40ccffa6
PE
143 * process.c: Make symbols static if they're not exported.
144 (process_tick, update_tick, create_process, chan_process):
145 (Vprocess_alist, proc_buffered_char, datagram_access):
146 (fd_callback_data, send_process_frame, process_sent_to): Now static.
147 (deactivate_process): Mark defn as static, as well as decl.
148 * lisp.h (create_process): Remove decl.
149 * process.h (chan_process, Vprocess_alist): Remove decls.
150
ad64fc97
PE
151 * print.c: Make symbols static if they're not exported.
152 (print_depth, new_backquote_output, being_printed, print_buffer):
153 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
154 (print_interval, print_number_index, initial_stderr_stream):
155 Now static.
156 * lisp.h (Fprinc): Remove decl.
157 (debug_output_compilation_hack): Mark as externally visible.
158
adddb265
PE
159 * sysdep.c (croak): Move decl from here to syssignal.h.
160 * syssignal.h (croak): Put it here, so the API can be checked when
161 'croak' is called from dissociate_if_controlling_tty.
162
1717ede2
PE
163 * minibuf.c: Make symbols static if they're not exported.
164 (minibuf_save_list, choose_minibuf_frame): Now static.
165 * lisp.h (choose_minibuf_frame): Remove decl.
166
fa5fb2bc
PE
167 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
168
1e3890d1
PE
169 * lread.c: Make symbols static if they're not exported.
170 (read_objects, initial_obarray, oblookup_last_bucket_number):
171 Now static.
172 (make_symbol): Remove; unused.
173 * lisp.h (initial_obarray, make_symbol): Remove decls.
174
8a1414fa
PE
175 * keyboard.c: Make symbols static if they're not exported.
176 (single_kboard, recent_keys_index, total_keys, recent_keys):
177 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
178 (this_single_command_key_start, echoing, last_auto_save):
179 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
180 (command_loop, echo_now, keyboard_init_hook, help_char_p):
181 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
182 (Vlispy_mouse_stem, double_click_count):
183 Now static.
184 (force_auto_save_soon): Define only if SIGDANGER.
185 (ignore_mouse_drag_p): Now static if
186 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
187 (print_help): Remove; unused.
188 (stop_character, last_timer_event): Mark as externally visible.
189 * keyboard.h (ignore_mouse_drag_p): Declare only if
190 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
191 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
192 * lisp.h (echoing): Remove decl.
193 (force_auto_save_soon): Declare only if SIGDANGER.
194 * xdisp.c (redisplay_window): Simplify code, to make it more
195 obvious that ignore_mouse_drag_p is not accessed if !defined
196 USE_GTK && !defined HAVE_NS.
197
93ea6e8f
PE
198 * intervals.c: Make symbols static if they're not exported.
199 (merge_properties_sticky, merge_interval_right, delete_interval):
200 Now static.
201 * intervals.h (merge_interval_right, delete_interval): Remove decls.
202
77382fcc
PE
203 * insdel.c: Make symbols static if they're not exported.
204 However, leave prepare_to_modify_buffer alone. It's never
205 called from outside this function, but that appears to be a bug.
206 (combine_after_change_list, combine_after_change_buffer):
4889fc82 207 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
208 (adjust_after_replace_noundo): Remove; unused.
209 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 210 (signal_before_change): Remove decls.
77382fcc 211
9306c32e
PE
212 * indent.c (val_compute_motion, val_vmotion): Now static.
213
cd44d2eb
PE
214 * image.c: Make symbols static if they're not exported.
215 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
216 if USE_GTK.
217 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
218 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
219
ad9a7a06
PE
220 * fringe.c (standard_bitmaps): Now static.
221 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
222
81626931
PE
223 * frame.c: Make symbols static if they're not exported.
224 (x_report_frame_params, make_terminal_frame): Now static.
225 (get_frame_param): Now static, unless HAVE_NS.
226 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
227 (x_get_resource_string): Remove; not used.
228 * frame.h (make_terminal_frame, x_report_frame_params):
229 (x_get_resource_string); Remove decls.
230 (x_fullscreen_adjust): Declare only if WINDOWSNT.
231 * lisp.h (get_frame_param): Declare only if HAVE_NS.
232
239f9db9
PE
233 * font.c, fontset.c: Make symbols static if they're not exported.
234 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
235 (FACE_SUITABLE_FOR_CHAR_P): Use it.
236 * font.c (font_close_object): Now static.
237 * font.h (font_close_object): Remove.
238 * fontset.c (FONTSET_OBJLIST): Remove.
239 (free_realized_fontset) #if-0 the body, which does nothing.
240 (face_suitable_for_char_p): #if-0, as it's never called.
241 * fontset.h (face_suitable_for_char_p): Remove decl.
242 * xfaces.c (face_at_string_position): Use
243 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
244 since 0 is always ASCII.
245
dfcf3579
PE
246 * fns.c (weak_hash_tables): Now static.
247
5045092b
PE
248 * fileio.c: Make symbols static if they're not exported.
249 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
250 (Vwrite_region_annotation_buffers): Now static.
251
57a96f5c
PE
252 * eval.c: Make symbols static if they're not exported.
253 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
254 * lisp.h (backtrace_list): Remove decl.
255
35f08c38
PE
256 * emacs.c: Make symbols static if they're not exported.
257 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
258 (fatal_error_code, fatal_error_signal_hook, standard_args):
259 Now static.
260 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
261 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
262 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
263 * lisp.h (fatal_error_signal_hook): Remove decl.
264 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
265
f44bd759
PE
266 * editfns.c: Move a (normally-unused) function to its only use.
267 * editfns.c, lisp.h (get_operating_system_release): Remove.
268 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
269 worth the hassle of breaking this out.
270
b532497d
PE
271 * xterm.c: Make symbols static if they're not exported.
272 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
273 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
274 (x_destroy_window, x_delete_display):
275 Now static.
276 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
277 (x_mouse_leave): Remove; unused.
278 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
279 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
280 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
281 Remove decls.
282 (x_mouse_leave): Declare only if WINDOWSNT.
283 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
284 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
285 USE_X_TOOLKIT.
286
1675728f
PE
287 * ftxfont.c: Make symbols static if they're not exported.
288 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
289 HAVE_FREETYPE.
290 * font.h (ftxfont_driver): Likewise.
291
e4cebfca
PE
292 * xfns.c: Make symbols static if they're not exported.
293 (x_last_font_name, x_display_info_for_name):
294 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
295 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
296 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
297 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
298 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
299 (last_show_tip_args): Now static.
300 (xic_defaut_fontset, xic_create_fontsetname): Define only if
301 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
302 (x_screen_planes): Remove; unused.
303 * dispextern.h (x_screen_planes): Remove decl.
304
5bf46f05
PE
305 * dispnew.c: Make symbols static if they're not exported.
306 * dispextern.h (redraw_garbaged_frames, scrolling):
307 (increment_row_positions): Remove.
308 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
309 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
310 Now static.
311 (redraw_garbaged_frames): Remove; unused.
312
435f4c28
PE
313 * xfaces.c: Make symbols static if they're not exported.
314 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
315 Remove decls.
316 * xterm.h (defined_color): Remove decls.
317 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
318 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
319 (menu_face_changed_default, defined_color, free_realized_face):
320 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
321 (ascii_face_of_lisp_face): Remove; unused.
322
8524aef3
PE
323 * xdisp.c: Make symbols static if they're not exported.
324 * dispextern.h (scratch_glyph_row, window_box_edges):
325 (glyph_to_pixel_coords, set_cursor_from_row):
326 (get_next_display_element, set_iterator_to_next):
327 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
328 (show_mouse_face): Remove decls
329 * frame.h (message_buf_print): Likewise.
330 * lisp.h (pop_message, set_message, check_point_in_composition):
331 Likewise.
332 * xterm.h (set_vertical_scroll_bar): Likewise.
333 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
334 (message_buf_print, scratch_glyph_row, displayed_buffer):
335 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
336 (get_next_display_element, show_mouse_face, window_box_edges):
337 (frame_to_window_pixel_xy, check_point_in_composition):
338 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
339 (glyph_to_pixel_coords): Remove; unused.
340
16390cd2
PE
341 * dired.c (file_name_completion): Now static.
342
343 * dbusbind.c (xd_in_read_queued_messages): Now static.
344
a25f4dfa
PE
345 * lisp.h (circular_list_error, FOREACH): Remove; unused.
346 * data.c (circular_list_error): Remove.
347
14a9c8df
PE
348 * commands.h (last_point_position, last_point_position_buffer):
349 (last_point_position_window): Remove decls.
350 * keyboard.c: Make these variables static.
351
74ab6df5
PE
352 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
353 decls.
354 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
355 (iso_code_class, detect_coding, code_convert_region): Now static.
356 (encode_coding_gap): Remove; unused.
357
38dfbee1
PE
358 * chartab.c (chartab_chars, chartab_bits): Now static.
359
a2cb4e63
PE
360 * charset.h (charset_iso_8859_1): Remove decl.
361 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
362 Now static.
363
127198fd
PE
364 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
365 * ccl.c (Vccl_program_table): Now static.
366 (check_ccl_update): Remove; unused.
367
d85b608f
PE
368 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
369 * category.h: ... from here.
370 * category.c (check_category_table, set_category_set): Now static.
371
31cd66f3
PE
372 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
373 * lisp.h: Remove these decls.
374
c358e587
PE
375 * buffer.c (buffer_count): Remove unused var.
376
e78aecca
PE
377 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
378 so that it's not optimized away.
379 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
380 * dispextern.h (bidi_dump_cached_states): Remove, since it's
381 exported only to the debugger.
382
e192d7d3
PE
383 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
384 * atimer.h (run_all_atimers): Removed; not exported.
385
92470028
PE
386 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
387 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
388 was inaccessible from Lisp.
389 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
390 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
391
244ed907
PE
392 alloc.c: Import and export fewer symbols, and remove unused items.
393 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
394 is defined.
395 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
396 it's not optimized away by whole-program optimization.
397 (message_enable_multibyte, free_misc): Remove.
398 (catchlist, handlerlist, mark_backtrace):
399 Declare only if BYTE_MARK_STACK.
400 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
401 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
402 (message_enable_multibyte): Remove decl.
403 (free_misc, interval_free_list, float_block, float_block_index):
404 (n_float_blocks, float_free_list, cons_block, cons_block_index):
405 (cons_free_list, last_marked_index):
406 Now static.
407 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
408 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
409 (mark_backtrace): Define only if BYTE_MARK_STACK.
410 * xdisp.c (message_enable_multibyte): Now static.
411
955cbe7b
PE
412 Declare Lisp_Object Q* variables to be 'static' if not exproted.
413 This makes it easier for human readers (and static analyzers)
414 to see whether these variables are used from other modules.
415 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
416 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
417 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
418 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
419 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
420 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
421 * xmenu.c, xselect.c:
422 Declare Q* vars static if they are not used in other modules.
423 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
424 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
425 Remove decls of unexported vars.
426 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
427
95c82688
PE
428 * lisp.h (DEFINE_FUNC): Make sname 'static'.
429
16a97296
PE
430 Make Emacs functions such as Fatom 'static' by default.
431 This makes it easier for human readers (and static analyzers)
432 to see whether these functions can be called from other modules.
433 DEFUN now defines a static function. To make the function external
434 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
435 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
436 (Finit_image_library):
16a97296
PE
437 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
438 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
439 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
440 Remove decls, since these functions are now static.
441 (Funintern, Fget_internal_run_time): New decls, since these functions
442 were already external.
95c82688 443
16a97296
PE
444 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
445 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
446 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
447 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
448 * keyboard.c, keymap.c, lread.c:
449 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
450 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
451 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
452 Mark functions with DEFUE instead of DEFUN,
453 if they are used in other modules.
454 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
455 decls for now-static functions.
456 * buffer.h (Fdelete_overlay): Remove decl.
457 * callproc.c (Fgetenv_internal): Mark as internal.
458 * composite.c (Fremove_list_of_text_properties): Remove decl.
459 (Fcomposition_get_gstring): New forward static decl.
460 * composite.h (Fcomposite_get_gstring): Remove decl.
461 * dired.c (Ffile_attributes): New forward static decl.
462 * doc.c (Fdocumntation_property): New forward static decl.
463 * eval.c (Ffetch_bytecode): New forward static decl.
464 (Funintern): Remove extern decl; now in .h file where it belongs.
465 * fileio.c (Fmake_symbolic_link): New forward static decl.
466 * image.c (Finit_image_library): New forward static decl.
467 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
468 * intervals.h (Fprevious_property_change):
469 (Fremove_list_of_text_properties): Remove decls.
470 * keyboard.c (Fthis_command_keys): Remove decl.
471 (Fcommand_execute): New forward static decl.
472 * keymap.c (Flookup_key): New forward static decl.
473 (Fcopy_keymap): Now static.
474 * keymap.h (Flookup_key): Remove decl.
475 * process.c (Fget_process): New forward static decl.
476 (Fprocess_datagram_address): Mark as internal.
477 * syntax.c (Fsyntax_table_p): New forward static decl.
478 (skip_chars): Remove duplicate decl.
479 * textprop.c (Fprevious_property_change): New forward static decl.
480 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
481 Now internal.
482 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
483 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
484
785bbd42
PE
485 * editfns.c (Fformat): Remove unreachable code.
486
8b913b57
AS
4872011-04-14 Andreas Schwab <schwab@linux-m68k.org>
488
489 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
490 change. (Bug#8496)
491
a6744a35
EZ
4922011-04-13 Eli Zaretskii <eliz@gnu.org>
493
494 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
495 when at ZV. (Bug#8487)
496
e7974947
AS
4972011-04-12 Andreas Schwab <schwab@linux-m68k.org>
498
baad03f0
AS
499 * charset.c (Fclear_charset_maps): Use xfree instead of free.
500 (Bug#8437)
501 * keyboard.c (parse_tool_bar_item): Likewise.
502 * sound.c (sound_cleanup, alsa_close): Likewise.
503 * termcap.c (tgetent): Likewise.
504 * xfns.c (x_default_font_parameter): Likewise.
505 * xsettings.c (read_and_apply_settings): Likewise.
506
e7974947
AS
507 * alloc.c (overrun_check_malloc, overrun_check_realloc)
508 (overrun_check_free): Protoize.
509
28272684
PE
5102011-04-12 Paul Eggert <eggert@cs.ucla.edu>
511
512 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
513 since callers should never pass a negative size.
514 Change the signature to match that of plain 'read' and 'write'; see
515 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
516 * lisp.h: Update prototypes of emacs_write and emacs_read.
517
11997c76
EZ
5182011-04-11 Eli Zaretskii <eliz@gnu.org>
519
520 * xdisp.c (redisplay_window): Don't try to determine the character
521 position of the scroll margin if the window start point w->startp
e896f03c 522 is outside the buffer's accessible region. (Bug#8468)
11997c76 523
8a2cbd72
EZ
5242011-04-10 Eli Zaretskii <eliz@gnu.org>
525
526 Fix write-region and its subroutines for buffers > 2GB.
527 * fileio.c (a_write, e_write): Modify declaration of arguments and
528 local variables to support buffers larger than 2GB.
529 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
530
531 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
532 argument, local variables, and return value.
533
534 * lisp.h: Update prototypes of emacs_write and emacs_read.
535
536 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
537
4073e537 5382011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 539
1ebfdcb6
PE
540 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
541
b2ded58d
PE
542 Fix more problems found by GCC 4.6.0's static checks.
543
7d66342c
PE
544 * xdisp.c (vmessage): Use a better test for character truncation.
545
bbf47d44
PE
546 * charset.c (load_charset_map): <, not <=, for optimization,
547 and to avoid potential problems with integer overflow.
9248994d 548 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 549 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 550 * editfns.c (Fformat): Likewise.
1e69125e 551 * syntax.c (skip_chars): Likewise.
3befa583 552
e3019616
PE
553 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
554 This also lets GCC 4.6.0 generate slightly better loop code.
555
becfa255
PE
556 * callint.c (Fcall_interactively): <, not <=, for optimization.
557 (Fcall_interactively): Count the number of arguments produced,
558 not the number of arguments given. This is simpler and lets GCC
559 4.6.0 generate slightly better code.
560
dae0cd48
PE
561 * ftfont.c: Distingish more carefully between FcChar8 and char.
562 The previous code passed unsigned char * to a functions like
563 strlen and xstrcasecmp that expect char *, which does not
564 conform to the C standard.
565 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
566 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
567 char * when the C standard requires it.
568
76032d70
PE
569 * keyboard.c (read_char): Remove unused var.
570
eb3f1cc8
PE
571 * eval.c: Port to Windows vsnprintf (Bug#8435).
572 Include <limits.h>.
573 (SIZE_MAX): Define if the headers do not.
574 (verror): Do not give up if vsnprintf returns a negative count.
575 Instead, grow the buffer. This ports to Windows vsnprintf, which
576 does not conform to C99. Problem reported by Eli Zaretskii.
577 Also, simplify the allocation scheme, by avoiding the need for
578 calling realloc, and removing the ALLOCATED variable.
579
70476b54
PE
580 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
581
12020a9e
PE
582 Remove invocations of doprnt, as Emacs now uses vsnprintf.
583 But keep the doprint source code for now, as we might revamp it
584 and use it again (Bug#8435).
ea6c7ae6
PE
585 * lisp.h (doprnt): Remove.
586 * Makefile.in (base_obj): Remove doprnt.o.
587 * deps.mk (doprnt.o): Remove.
588
5fdb398c
PE
589 error: Print 32- and 64-bit integers portably (Bug#8435).
590 Without this change, on typical 64-bit hosts error ("...%d...", N)
591 was used to print both 32- and 64-bit integers N, which relied on
592 undefined behavior.
593 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
594 New macro.
595 * lisp.h (error, verror): Mark as printf-like functions.
596 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
597 Report overflow in size calculations when allocating printf buffer.
598 Do not truncate output string at its first null byte.
599 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
600 Truncate the output at a character boundary, since vsnprintf does not
601 do that.
602 * charset.c (check_iso_charset_parameter): Convert internal
603 character to string before calling 'error', since %c now has the
604 printf meaning.
605 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
606 overflow when computing char to be passed to 'error'. Do not
607 pass Lisp_Object to 'error'; pass the integer instead.
608 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
609 formatted with plain %d.
610
b189fa66
PE
611 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
612
bff87ef0
PE
613 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
614
7e2cac20
PE
615 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
616
ce4d90b5
PE
617 * xterm.c (x_catch_errors): Remove duplicate declaration.
618
266c9547
PE
619 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
620
79c49ad2
PE
621 * xdisp.c, lisp.h (message_nolog): Remove; unused.
622
368f4090
JM
6232011-04-10 Jim Meyering <meyering@redhat.com>
624
625 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
626 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
627 return ssize_t not "int", and use size_t as the buffer length.
628 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
629 * gnutls.h: Update declarations.
630 * process.c (read_process_output): Use ssize_t, to match.
631 (send_process): Likewise.
632
a32d4040
CY
6332011-04-09 Chong Yidong <cyd@stupidchicken.com>
634
635 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
636
8546720e 6372011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 638
8546720e
GM
639 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
640 unsigned char, to match FcChar8 type definition.
aac0c6e3 641
8546720e
GM
642 * xterm.c (handle_one_xevent):
643 * xmenu.c (create_and_show_popup_menu):
644 * xselect.c (x_decline_selection_request)
645 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 646
0a2f5c1a 6472011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
648
649 Fix some uses of `int' instead of EMACS_INT.
650 * search.c (string_match_1, fast_string_match)
651 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
652 (scan_buffer, find_next_newline_no_quit)
653 (find_before_next_newline, search_command, Freplace_match)
654 (Fmatch_data): Make some `int' variables be EMACS_INT.
655
656 * xdisp.c (display_count_lines): 3rd argument and return value now
657 EMACS_INT. All callers changed.
658 (pint2hrstr): Last argument is now EMACS_INT.
659
660 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
661 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
662 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
663 (decode_coding_utf_16, decode_coding_emacs_mule)
664 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
665 (decode_coding_ccl, decode_coding_charset)
666 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
667 (decode_coding_iso_2022, decode_coding_emacs_mule)
668 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
669 <char_offset, last_offset>: Declare EMACS_INT.
670 (encode_coding_utf_8, encode_coding_utf_16)
671 (encode_coding_emacs_mule, encode_invocation_designation)
672 (encode_designation_at_bol, encode_coding_iso_2022)
673 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
674 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
675 Declare EMACS_INT.
676 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
677 (encode_invocation_designation): Last argument P_NCHARS is now
678 EMACS_INT.
679 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
680 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
681
682 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
683 All users changed.
684
685 * ccl.c (Fccl_execute_on_string): Declare some variables
686 EMACS_INT.
687
8546720e 6882011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
689
690 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
691
4e19a977
CS
6922011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
693
694 * process.c (Fformat_network_address): Doc fix.
695
87302331
R
6962011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
697
698 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
699
cbb59342
CY
7002011-04-08 Chong Yidong <cyd@stupidchicken.com>
701
702 * keyboard.c (read_char): Call Lisp function help-form-show,
703 instead of using internal_with_output_to_temp_buffer.
704 (Qhelp_form_show): New var.
e0d38eeb 705 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
706
707 * print.c (internal_with_output_to_temp_buffer): Function deleted.
708
709 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
710
e67a13ab
CY
7112011-04-06 Chong Yidong <cyd@stupidchicken.com>
712
713 * process.c (Flist_processes): Removed to Lisp.
714 (list_processes_1): Deleted.
715
973f782d
EZ
7162011-04-06 Eli Zaretskii <eliz@gnu.org>
717
7c106b1e
EZ
718 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
719
973f782d
EZ
720 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
721
41cf7d1a 7222011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 723
ca23cc88
PE
724 Fix more problems found by GCC 4.6.0's static checks.
725
f390e2d5
PE
726 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
727
42eea0d0
PE
728 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
729
b69769da 730 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 731
f9541e84
PE
732 * xdisp.c (vmessage): Mark as a printf-like function.
733
13841b55
PE
734 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
735
c136c10f
PE
736 * sound.c (sound_warning): Don't crash if arg contains a printf format.
737
5e2d4a30
PE
738 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
739 printf-like functions.
740 (tiff_load): Add casts to remove these marks before passing them
741 to system-supplied API.
742
583f48b9
PE
743 * eval.c (Fsignal): Remove excess argument to 'fatal'.
744
b25d760e
PE
745 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
746 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
747 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
748 directly, rather than having caller test rule sign. This avoids
749 some unnecessary tests.
750 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
751 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
752 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 753
bc7b6697 754 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 755 (xfont_open): Avoid unnecessary tests.
bc7b6697 756
27ccc379
PE
757 * composite.c (composition_gstring_put_cache): Use unsigned integer.
758
dcd5c89a
PE
759 * composite.h, composite.c (composition_gstring_put_cache):
760 Use EMACS_INT, not int, for length.
761
b13a45c6
PE
762 * composite.h (COMPOSITION_DECODE_REFS): New macro,
763 breaking out part of COMPOSITION_DECODE_RULE.
764 (COMPOSITION_DECODE_RULE): Use it.
765 * composite.c (get_composition_id): Remove unused local vars,
766 by using the new macro.
767
1e792e4d
PE
768 * textprop.c (set_text_properties_1): Change while to do-while,
769 since the condition is always true at first.
770
dc6c6455 771 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
772 (interval_deletion_adjustment): Return unsigned value.
773 All uses changed.
dc6c6455 774
aba7731a
PE
775 * process.c (list_processes_1, create_pty, read_process_output):
776 (exec_sentinel): Remove vars that were set but not used.
afd4052b 777 (create_pty): Remove unnecessary "volatile"s.
bc57d757 778 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 779 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 780 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 781
fdfc4bf3
PE
782 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
783
fca8fe46 784 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 785 (update_syntax_table): Use unsigned instead of int.
fca8fe46 786
06a0259a 787 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 788 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 789 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 790
e7b9e80f
PE
791 * print.c (print_error_message): Avoid int overflow.
792
56201685
PE
793 * font.c (font_list_entities): Redo for clarity,
794 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
795
78834453 796 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 797 (font_score): Avoid potential overflow in diff calculation.
78834453 798
0bc0b309 799 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 800 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 801
e610eaca
PE
802 * eval.c (funcall_lambda): Rename local to avoid shadowing.
803
b895abce
PE
804 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
805 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
806 can always succeed if overflow has undefined behavior.
807
1f1d9321 808 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 809 (wordify): Omit three unnecessary tests.
1f1d9321 810
c59478bc
PE
811 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
812 All callers changed. This avoids the need for an unused var.
813
79b73827
PE
814 * casefiddle.c (casify_region): Remove var that is set but not used.
815
a4db5dfe
PE
816 * dired.c (file_name_completion): Remove var that is set but not used.
817
43aae36e
PE
818 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
819
2a47c44d 820 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 821 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 822
a37c69bf
PE
823 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
824 Check for integer overflow on size calculations.
825
328ab8e7
PE
826 * buffer.c (Fprevious_overlay_change): Remove var that is set
827 but not used.
828
e5a2a5cb
PE
829 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
830 Remove vars that are set but not used.
8d84a6eb 831 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 832 (timer_check_2): Mark vars as initialized.
e5a2a5cb 833
a60e5f68
PE
834 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
835
f661cb61 836 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 837 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 838
f0397f5a
PE
839 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
840 that are set but not used.
841
8664db06 842 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 843 if XCreateBitmapFromData fails (Bug#8410).
8664db06 844
6abdaa4a
PE
845 * xselect.c (x_get_local_selection, x_handle_property_notify):
846 Remove vars that are set but not used.
847
0ce7538d 848 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 849 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 850
9ae848fc
PE
851 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
852 Remove var that is set but not used.
0b918413
PE
853 (scroll_bar_windows_size): Now size_t, not int.
854 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
855 Check for overflow.
9ae848fc 856
a5a62657
PE
857 * xfaces.c (realize_named_face): Remove vars that are set but not used.
858 (map_tty_color) [!defined MSDOS]: Likewise.
859
5c5cdd39
PE
860 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
861
66ebf983
PE
862 * coding.c: Remove vars that are set but not used.
863 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
864 All callers changed.
865 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
866 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
867 (decode_coding_charset): Remove vars that are set but not used.
868
1be4d761
PE
869 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
870 that is set but not used.
871
47553fa8
PE
872 * print.c (print_object): Remove var that is set but not used.
873
1f7196bf 874 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
875 The gnulib version avoids calling malloc in the usual case,
876 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
877 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
878 * filelock.c (current_lock_owner): Likewise.
879 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
880 * sysdep.c: Include allocator.h, careadlinkat.h.
881 (emacs_no_realloc_allocator): New static constant.
882 (emacs_readlink): New function.
fdb61804
PE
883 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
884 ../lib/careadlinkat.h.
d1fdcab7 885
f84c17c7
SM
8862011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
887
888 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
889 first non-nil return value).
890
ef3862ad
JD
8912011-04-03 Jan Djärv <jan.h.d@swipnet.se>
892
893 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
894 if not defined (Bug#8403).
895
376a7006
JB
8962011-04-02 Juanma Barranquero <lekktu@gmail.com>
897
898 * xdisp.c (display_count_lines): Remove parameter `start',
899 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
900 (get_char_face_and_encoding): Remove parameter `multibyte_p',
901 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
902 (fill_stretch_glyph_string): Remove parameters `row' and `area',
903 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
904 and thereabouts. All callers changed.
905 (get_per_char_metric): Remove parameter `f', unused since
906 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
907
6ca3801d
JM
9082011-04-02 Jim Meyering <meyering@redhat.com>
909
910 do not dereference NULL upon failed strdup
911 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
912 (ns_get_family): Likewise.
913
d8e2b5ba
JB
9142011-04-02 Juanma Barranquero <lekktu@gmail.com>
915
916 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
917
8c74fcbd
JD
9182011-04-02 Jan Djärv <jan.h.d@swipnet.se>
919
920 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
921 later (Bug#8403).
922
7200d79c
SM
9232011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
924
03408648 925 Add lexical binding.
7200d79c 926
03408648
SM
927 * window.c (Ftemp_output_buffer_show): New fun.
928 (Fsave_window_excursion):
929 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
930
931 * lread.c (lisp_file_lexically_bound_p): New function.
932 (Fload): Bind Qlexical_binding.
933 (readevalloop): Remove `evalfun' arg.
934 Bind Qinternal_interpreter_environment.
935 (Feval_buffer): Bind Qlexical_binding.
936 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
937 Mark as dynamic.
938 (syms_of_lread): Declare `lexical-binding'.
939
940 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
941
942 * keyboard.c (eval_dyn): New fun.
943 (menu_item_eval_property): Use it.
ca105506
SM
944
945 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 946
03408648
SM
947 * fns.c (concat, mapcar1): Accept byte-code-functions.
948
949 * eval.c (Fsetq): Handle lexical vars.
950 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
951 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
952 (FletX, Flet): Obey lexical binding.
953 (Fcommandp): Handle closures.
954 (Feval): New `lexical' arg.
955 (eval_sub): New function extracted from Feval. Use it almost
956 everywhere where Feval was used. Look up vars in lexical env.
957 Handle closures.
958 (Ffunctionp): Move from subr.el.
959 (Ffuncall): Handle closures.
960 (apply_lambda): Remove `eval_flags'.
961 (funcall_lambda): Handle closures and new byte-code-functions.
962 (Fspecial_variable_p): New function.
963 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
964 but without exporting it to Lisp.
23aba0ea 965
23aba0ea 966 * doc.c (Fdocumentation, store_function_docstring):
03408648 967 * data.c (Finteractive_form): Handle closures.
23aba0ea 968
03408648
SM
969 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
970 interactive spec.
ba83908c 971
03408648
SM
972 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
973 byte-codes.
974 (exec_byte_code): New function extracted from Fbyte_code to handle new
975 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 976
03408648 977 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 978
03408648 979 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 980
e2abce01
JB
9812011-03-31 Juanma Barranquero <lekktu@gmail.com>
982
983 * xdisp.c (redisplay_internal): Fix prototype.
984
63696a73 9852011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 986
63696a73
EZ
987 * xdisp.c (SCROLL_LIMIT): New macro.
988 (try_scrolling): Use it when setting scroll_limit. Limit
989 scrolling to 100 screen lines.
990 (redisplay_window): Even when falling back on "recentering",
991 position point in the window according to scroll-conservatively,
992 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
993
994 (try_scrolling): When point is above the window, allow searching
995 as far as scroll_max, or one screenful, to compute vertical
996 distance from PT to the scroll margin position. This prevents
997 try_scrolling from unnecessarily failing when
998 scroll-conservatively is set to a value slightly larger than the
999 window height. Clean up the case of PT below the margin at bottom
1000 of window: scroll_max can no longer be INT_MAX. When aggressive
1001 scrolling is in use, don't let point enter the opposite scroll
1002 margin as result of the scroll.
1003 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1004 threshold of 100 lines for never-recentering scrolling.
1005
e4cc2dfc
JB
10062011-03-31 Juanma Barranquero <lekktu@gmail.com>
1007
1008 * dispextern.h (move_it_by_lines):
1009 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1010 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1011 (message_log_check_duplicate): Remove parameters `prev_bol' and
1012 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1013 (redisplay_internal): Remove parameter `preserve_echo_area',
1014 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1015
1016 * indent.c (Fvertical_motion):
1017 * window.c (window_scroll_pixel_based, Frecenter):
1018 Don't pass `need_y_p' to `move_it_by_lines'.
1019
1c470562
SM
10202011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1021
44f230aa
SM
1022 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1023 steal a few bits to be more compact.
1024 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1025 Remove unneeded casts.
1026
1c470562
SM
1027 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1028
888adce9
ZK
10292011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1030
1031 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1032 binding" message (bug#7967).
1033
f838ed7b
PE
10342011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1035
77861b95
PE
1036 Fix more problems found by GCC 4.6.0's static checks.
1037
de6dbc14
PE
1038 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1039 Remove unused local var.
1040
f838ed7b
PE
1041 * editfns.c (Fmessage_box): Remove unused local var.
1042
792c7b2b
PE
1043 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1044 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1045 Omit unused local vars.
c499e557 1046 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1047 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1048 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1049 Omit unused local var.
1050
ba0165e1
PE
1051 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1052 Don't assume string length fits in int.
32ad8845 1053 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1054 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1055
3c59b4c9
PE
1056 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1057 instead of alloca (Bug#8344).
1058
a3eed478 1059 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1060 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1061
eb4d412d
PE
1062 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1063
1658b401
PE
1064 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1065 concerns.
1066
1067 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1068
1069 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1070
9a2c6e05
PE
1071 * keyboard.c (syms_of_keyboard): Use the same style as later
1072 in this function when indexing through an array. This also
1073 works around GCC bug 48267.
1074
03d0a109
PE
1075 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1076
44f730c8
PE
1077 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1078
fe75f926
PE
1079 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1080 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1081
ffa8c828
PE
1082 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1083 This avoids undefined behavior on integer overflow, and is a bit
1084 more convenient anyway since it is compared to a size_t variable.
1085
c5101a77
PE
1086 Variadic C functions now count arguments with size_t, not int.
1087 This avoids an unnecessary limitation on 64-bit machines, which
1088 caused (substring ...) to crash on large vectors (Bug#8344).
1089 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1090 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1091 All variadic functions and their callers changed accordingly.
c5101a77
PE
1092 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1093 * data.c (arith_driver, float_arith_driver): Likewise.
1094 * editfns.c (general_insert_function): Likewise.
1095 * eval.c (struct backtrace.nargs, interactive_p)
1096 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1097 (funcall_lambda, mark_backtrace): Likewise.
1098 * fns.c (concat): Likewise.
1099 * frame.c (x_set_frame_parameters): Likewise.
1100 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1101 0 if not found, not -1. All callers changed.
1102
dd3f25f7
PE
1103 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1104 (stack_copy_size): Now size_t, not int.
1105 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1106
461c2ab9
JB
11072011-03-28 Juanma Barranquero <lekktu@gmail.com>
1108
1109 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1110 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1111 All callers changed.
1112
1113 * lisp.h (multibyte_char_to_unibyte):
1114 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1115 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1116 * character.h (CHAR_TO_BYTE8):
1117 * cmds.c (internal_self_insert):
1118 * editfns.c (general_insert_function):
1119 * keymap.c (push_key_description):
1120 * search.c (Freplace_match):
1121 * xdisp.c (message_dolog, set_message_1): All callers changed.
1122
f6d62986
SM
11232011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1124
1125 * keyboard.c (safe_run_hook_funcall): New function.
1126 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1127 don't set the hook to nil, but remove the offending function instead.
1128 (Qcommand_hook_internal): Remove, unused.
1129 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1130 Vcommand_hook_internal.
1131
1132 * eval.c (enum run_hooks_condition): Remove.
1133 (funcall_nil, funcall_not): New functions.
1134 (run_hook_with_args): Call each function through a `funcall' argument.
1135 Remove `cond' argument, now redundant.
1136 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1137 (Frun_hook_with_args_until_failure): Adjust accordingly.
1138 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1139
1db5b1ad
JB
11402011-03-28 Juanma Barranquero <lekktu@gmail.com>
1141
1142 * dispextern.h (string_buffer_position): Remove declaration.
1143
1144 * print.c (strout): Remove parameter `multibyte', unused since
1145 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1146
1147 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1148 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1149 All callers changed.
1150
1151 * w32.c (_wsa_errlist): Use braces for struct initializers.
1152
1153 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1154 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1155 All callers changed.
1156 (string_buffer_position): Likewise. Also, make static (it's never
1157 used outside xdisp.c).
1158 (cursor_row_p): Remove parameter `w', unused since
1159 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1160 (decode_mode_spec): Remove parameter `precision', introduced during
1161 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1162 All callers changed.
1163
5ffb62aa
JD
11642011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1165
1166 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1167
461c2ab9 11682011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1169
1170 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1171 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1172 (ns_update_auto_hide_menu_bar): New functions.
1173 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1174 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1175 ns_constrain_all_frames.
1176 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1177 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1178
5c380ffb
JD
11792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1180
1181 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1182
9af30bdf
GM
11832011-03-27 Glenn Morris <rgm@gnu.org>
1184
1185 * syssignal.h: Replace RETSIGTYPE with void.
1186 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1187 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1188 Replace SIGTYPE with void everywhere.
1189 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1190 * s/template.h (SIGTYPE): Remove commented out definition.
1191
e2abce01
JB
11922011-03-26 Eli Zaretskii <eliz@gnu.org>
1193
1194 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1195 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1196
f868cd8a
JB
11972011-03-26 Juanma Barranquero <lekktu@gmail.com>
1198
59eb0929
JB
1199 * w32.c (read_unc_volume): Use parameter `henum', instead of
1200 global variable `wget_enum_handle'.
1201
1202 * keymap.c (describe_vector): Remove parameters `indices' and
1203 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1204 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1205
f868cd8a
JB
1206 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1207
1208 * keyboard.c (timer_check): Remove parameter `do_it_now',
1209 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1210 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1211 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1212
1213 * keyboard.c (read_char):
1214 * w32menu.c (w32_menu_display_help):
1215 * xmenu.c (show_help_event, menu_help_callback):
1216 Adjust calls to `show_help_echo'.
1217
1218 * gtkutil.c (xg_maybe_add_timer):
1219 * keyboard.c (readable_events):
1220 * process.c (wait_reading_process_output):
1221 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1222
1223 * insdel.c (adjust_markers_gap_motion):
1224 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1225 (gap_left, gap_right): Don't call it.
1226
2ecf6fdb
CY
12272011-03-25 Chong Yidong <cyd@stupidchicken.com>
1228
1229 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1230 incurred during fontification.
1231
6b1f9ba4
JB
12322011-03-25 Juanma Barranquero <lekktu@gmail.com>
1233
1234 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1235 (DEFVAR_PER_BUFFER): Don't pass it.
1236
1237 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1238 (scrolling_window): Don't pass it.
1239
0f4a96b5
JB
12402011-03-25 Juanma Barranquero <lekktu@gmail.com>
1241
1242 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1243
1244 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1245 and `suffix'.
1246 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1247 of variables specific to SELinux and computation of `encoded_absname'.
1248
1249 * image.c (XPutPixel): Remove unused variable `height'.
1250
1251 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1252
1253 * unexw32.c (get_section_info): Remove unused variable `section'.
1254
1255 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1256 (system_process_attributes): Remove unused variable `sess'.
1257 (sys_read): Remove unused variable `err'.
1258
1259 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1260 (w32_wnd_proc): Remove unused variable `isdead'.
1261 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1262 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1263 (x_create_tip_frame): Remove unused variable `tem'.
1264
1265 * w32inevt.c (w32_console_read_socket):
1266 Remove unused variable `no_events'.
1267
1268 * w32term.c (x_draw_composite_glyph_string_foreground):
1269 Remove unused variable `width'.
1270
1149507c
JB
12712011-03-24 Juanma Barranquero <lekktu@gmail.com>
1272
1273 * w32term.c (x_set_glyph_string_clipping):
1274 Don't pass uninitialized region to CombineRgn.
1275
9c88f339
JB
12762011-03-23 Juanma Barranquero <lekktu@gmail.com>
1277
1278 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1279 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1280 (Fx_close_connection): Remove unused variable `i'.
1281
1282 * w32font.c (w32font_draw): Return number of glyphs.
1283 (w32font_open_internal): Remove unused variable `i'.
1284 (w32font_driver): Add missing initializer.
1285
1286 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1287 (fill_in_menu): Remove unused variable `items_added'.
1288
1289 * w32term.c (last_mouse_press_frame): Remove static global variable.
1290 (w32_clip_to_row): Remove unused variable `f'.
1291 (x_delete_terminal): Remove unused variable `i'.
1292
1293 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1294 (NOTHING): Remove unused static global variable.
1295 (uniscribe_check_otf): Remove unused variable `table'.
1296 (uniscribe_font_driver): Add missing initializers.
1297
dee091a3
JD
12982011-03-23 Julien Danjou <julien@danjou.info>
1299
1300 * term.c (Fsuspend_tty, Fresume_tty):
1301 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1302 * window.c (temp_output_buffer_show):
1303 * insdel.c (signal_before_change):
1304 * frame.c (Fhandle_switch_frame):
1305 * fileio.c (Fdo_auto_save):
1306 * emacs.c (Fkill_emacs):
1307 * editfns.c (save_excursion_restore):
1308 * cmds.c (internal_self_insert):
1309 * callint.c (Fcall_interactively):
1310 * buffer.c (Fkill_all_local_variables):
1311 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1312 Use Frun_hooks.
0f4a96b5 1313 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1314 unconditionnaly since it does the check itself.
1315
2c520ab5 13162011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1317
c9c49752
PE
1318 Fix more problems found by GCC 4.5.2's static checks.
1319
8abc3f12
PE
1320 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1321 the first time through the loop, since we know p0 < p1 then.
1322 This also avoids a gcc -Wstrict-overflow warning.
1323
a2d26660
PE
1324 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1325 leading to a memory leak, possible in functions like
1326 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1327 of objects (Bug#8318).
a2d26660 1328
916c72e9
PE
1329 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1330 that could (at least in theory) be that large.
1331
19ab8a18
PE
1332 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1333 This is less likely to overflow, and avoids undefined behavior if
1334 overflow does occur. All callers changed. Use strtoul to scan
1335 for the unsigned long integer.
b7cbbd6f
PE
1336 (pint2hrstr): Simplify and tune code slightly.
1337 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1338
f0641eff
PE
1339 * scroll.c (do_scrolling): Work around GCC bug 48228.
1340 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1341
7f650bb9
PE
1342 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1343 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1344 (validate_x_resource_name): Simplify count usage.
1345 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1346
37dd57d1
PE
1347 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1348 fail (Bug#8306).
81e56e61 1349
699979fc 1350 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1351
401bf9b4
PE
1352 * process.c (Fmake_network_process): Use socklen_t, not int,
1353 where POSIX says socklen_t is required in portable programs.
1354 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1355 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1356 (Fmake_network_process, server_accept_connection):
1357 (wait_reading_process_output, read_process_output):
1358 Likewise.
1359
b93aacde
PE
1360 * process.c: Rename or move locals to avoid shadowing.
1361 (list_processes_1, Fmake_network_process):
1362 (read_process_output_error_handler, exec_sentinel_error_handler):
1363 Rename or move locals.
4dc343ee 1364 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1365 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1366 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1367 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1368 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1369
af8a867c 1370 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1371 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1372 Include tparam.h instead, since it declares them.
af8a867c
PE
1373 * cm.h (PC): Remove extern decl; tparam.h now does this.
1374 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1375 * terminfo.c: Include tparam.h, to check interfaces.
1376 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1377 (tparam): Adjust signature to match interface in tparam.h;
1378 this removes some undefined behavior. Check that outstring and len
1379 are zero, which they always are with Emacs.
1380 * tparam.h (PC, BC, UP): New extern decls.
1381
0248044d 1382 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1383 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1384
8ff096c1 1385 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1386 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1387 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1388 (ftfont_list): Remove unused local.
49eaafba
PE
1389 (get_adstyle_property, ftfont_pattern_entity):
1390 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1391 Rename locals to avoid shadowing.
8ff096c1 1392
e2be39f6
PE
1393 * xfont.c (xfont_list_family): Mark var as initialized.
1394
c9735e30
PE
1395 * xml.c (make_dom): Now static.
1396
8f5201ae
PE
1397 * composite.c (composition_compute_stop_pos): Rename local to
1398 avoid shadowing.
b246f932
PE
1399 (composition_reseat_it): Remove unused locals.
1400 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1401 (composition_update_it): Mark var as initialized.
11b61122
PE
1402 (find_automatic_composition): Mark vars as initialized,
1403 with a FIXME (Bug#8290).
8f5201ae 1404
760fbc2c
PE
1405 character.h: Rename locals to avoid shadowing.
1406 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1407 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1408 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1409 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1410 to avoid shadowing.
1411
ff08eb85
PE
1412 * textprop.c (property_change_between_p): Remove; unused.
1413
fc7bf025
PE
1414 * intervals.c (interval_start_pos): Now static.
1415
235d7abc
PE
1416 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1417
44f230aa
SM
1418 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1419 Rename locals to avoid shadowing.
3e7d6594 1420
50060332
PE
1421 * sound.c (wav_play, au_play, Fplay_sound_internal):
1422 Fix pointer signedness.
d01f234b 1423 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1424 (wav_play): Initialize a variable to 0, to prevent undefined
1425 behavior (Bug#8278).
50060332 1426
c4fc4e30
PE
1427 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1428
918436ed
PE
1429 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1430
c939f91b
PE
1431 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1432 clobbering (Bug#8298).
b9c7f648
PE
1433 * sysdep.c (sys_subshell): Likewise.
1434 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1435
6bd8c144
PE
1436 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1437 This should get cleaned up, so that child_setup has the
1438 same signature on all platforms.
1439
7710357c 1440 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1441 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1442
c59da222
CY
14432011-03-22 Chong Yidong <cyd@stupidchicken.com>
1444
1445 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1446 not to be necessary, and produces flickering.
1447
66b87493
GM
14482011-03-20 Glenn Morris <rgm@gnu.org>
1449
1450 * config.in: Remove file.
1451
45b6f6d5
JB
14522011-03-20 Juanma Barranquero <lekktu@gmail.com>
1453
1454 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1455 are now in src/globals.h.
1456 (syms_of_minibuf): Remove spurious & from previous change.
1457
3ec03f7e
LL
14582011-03-20 Leo <sdl.web@gmail.com>
1459
1460 * minibuf.c (completing-read-function): New variable.
1461 (completing-read-default): Rename from completing-read.
1462 (completing-read): Call completing-read-function.
1463
b14e3e21
CY
14642011-03-19 Juanma Barranquero <lekktu@gmail.com>
1465
1466 * xfaces.c (Fx_load_color_file):
1467 Read color file from absolute filename (bug#8250).
1468
f2b726e6
JB
14692011-03-19 Juanma Barranquero <lekktu@gmail.com>
1470
1471 * makefile.w32-in: Update dependencies.
1472
09f6ff02
EZ
14732011-03-17 Eli Zaretskii <eliz@gnu.org>
1474
1475 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1476
29a6015a
PE
14772011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1478
a3a6c54e
PE
1479 Fix more problems found by GCC 4.5.2's static checks.
1480
b766f867
PE
1481 * process.c (make_serial_process_unwind, send_process_trap):
1482 (sigchld_handler): Now static.
1483
be02381c
PE
1484 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1485 That way, the code declares only the vars that it needs.
1486 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1487 * s/cygwin.h (PTY_ITERATION): Likewise.
1488 * s/darwin.h (PTY_ITERATION): Likewise.
1489 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1490
57048744
PE
1491 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1492 * process.c (allocate_pty): Don't declare stb unless it's needed.
1493
7914961c 1494 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1495 (CONSTANTLIM): Remove; unused.
1496 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1497 Define only if needed.
7914961c 1498
b3967b18
PE
1499 * unexelf.c (unexec): Name an expression,
1500 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1501 Use a different way to cause a compilation error if anyone uses
1502 n rather than nn, a way that does not involve shadowing.
73366a00 1503 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1504
29a6015a
PE
1505 * deps.mk (unexalpha.o): Remove; unused.
1506
43cfc33e 1507 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1508 * unexec.h: New file.
ce701a33
PE
1509 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1510 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1511 Depend on unexec.h.
1512 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1513 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1514 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1515 Change as necessary to match prototype in unexec.h.
ce701a33 1516
01f44d5a
PE
1517 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1518 shadowing.
4f63c6bb 1519 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1520
a6670b0b
PE
1521 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1522 Rename locals to avoid shadowing.
1523
cef2010d 1524 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1525 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1526
d4d7173a
PE
1527 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1528
f08b802a
PE
1529 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1530 warning when compiling print.c.
1531
3ddb0639
PE
1532 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1533 instead of using an uninitialized var.
5ad03b97 1534 (font_sort_entities): Mark var as initialized.
3ddb0639 1535
170a2692
PE
1536 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1537
e663c700
PE
1538 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1539 pointers to constants.
89bc529a 1540 (font_parse_fcname): Remove unused vars.
7b81e2d0 1541 (font_delete_unmatched): Now static.
ea838e10 1542 (font_get_spec): Remove; unused.
13a547c6
PE
1543 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1544 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1545 Rename or move locals to avoid shadowing.
e663c700 1546
2a80c887 1547 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1548 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1549
1384fa33 1550 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1551 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1552
8b2c52e9
PE
1553 * alloc.c (mark_backtrace): Move decl from here ...
1554 * lisp.h: ... to here, so that it can be checked.
1555
475545b5 1556 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1557 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1558 (lisp_indirect_variable): Name an expression,
1559 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1560 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1561
b1349114 1562 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1563 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1564 Use const pointer when appropriate.
b1349114 1565
a2928364
PE
1566 * lisp.h (get_system_name, get_operating_system_release):
1567 Move decls here, to check interfaces.
1568 * process.c (get_operating_system_release): Move decl to lisp.h.
1569 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1570 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1571 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1572 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1573 (Fformat_time_string, Fencode_time, Finsert_char):
1574 (Ftranslate_region_internal, Fformat):
1575 Rename or remove local vars to avoid shadowing.
9710023e 1576 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1577
a415e694
PE
1578 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1579 avoid shadowing.
1580
8ef4622d
PE
1581 * lisp.h (eassert): Check that the argument compiles, even if
1582 ENABLE_CHECKING is not defined.
1583
946f9a5b
PE
1584 * data.c (Findirect_variable): Name an expression, to avoid
1585 gcc -Wbad-function-cast warning.
112396d6 1586 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1587 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1588 (Fmake_variable_buffer_local, Fmake_local_variable):
1589 Mark variables as initialized.
52746918 1590 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1591
e5aab7e7 1592 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1593 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1594 Rename locals to avoid shadowing.
dff45157
PE
1595 (mark_stack): Move local variables into the #ifdef region where
1596 they're used.
7bc26fdb
PE
1597 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1598 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1599 needed otherwise.
1600 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1601 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1602 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1603
e5aab7e7
PE
1604 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1605 avoids undefined behavior in theory.
1606
4da60324
PE
1607 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1608
88043301
PE
1609 Use functions, not macros, for up- and down-casing (Bug#8254).
1610 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1611 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1612 to use the following functions instead of these macros.
1613 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1614 EMACS_INT, since callers assume the returned value fits in int.
1615 (upcase1): Likewise, for UPCASE_TABLE.
1616 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1617 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1618 the race-condition problem in the old DOWNCASE.
88043301 1619
19ed5445
PE
1620 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1621 Rename locals to avoid shadowing.
1622 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1623 (regex_compile, re_search_2, re_match_2_internal):
1624 Remove unused local vars.
952db0d7
PE
1625 (FREE_VAR): Rewrite so as not to use empty "else",
1626 which gcc can warn about.
da053e48 1627 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1628 (RETALLOC_IF): Define only if needed.
1629 (WORDCHAR_P): Likewise. This one is never needed, but is used
1630 only in a comment talking about a compiler bug, so put inside
1631 the #if 0 of that comment.
1632 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1633 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1634 Remove; unused.
19ed5445 1635
1f3561e4 1636 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1637 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1638 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1639
ded6f8f7
PE
1640 * search.c (simple_search): Remove unused var.
1641
dbd37a95
PE
1642 * dired.c (compile_pattern): Move decl from here ...
1643 * lisp.h: ... to here, so that it can be checked.
1644 (struct re_registers): New forward decl.
1645
7e47afad
PE
1646 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1647
85f24f61
PE
1648 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1649 All uses changed.
1650 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1651 Rename locals to avoid shadowing.
5671df8f 1652 (Fvertical_motion): Mark locals as initialized.
85f24f61 1653
181aa2be 1654 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1655 (casify_region): Mark local as initialized.
181aa2be 1656
930d429c
PE
1657 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1658
7082eac6
PE
1659 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1660 New macros, so that the caller can use some names other than
1661 gcpro1, gcpro2, etc.
1662 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1663 of the new macros.
1664 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1665 argument, for consistency with GCPRO2_VAR, etc: it is now the
1666 prefix of the variable, not the variable itself. All uses
1667 changed.
38b2c076
PE
1668 * dired.c (directory_files_internal, file_name_completion):
1669 Rename locals to avoid shadowing.
1670
15206ed9
PE
1671 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1672 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1673 dired.c's scmp function, had undefined behavior.
1674 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1675 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1676 * buffer.h: ... to here, because these macros use current_buffer,
1677 and the new implementation with inline functions needs to have
1678 current_buffer in scope now, rather than later when the macros
1679 are used.
1680 (downcase, upcase1): New static inline functions.
1681 (DOWNCASE, UPCASE1): Reimplement using these functions.
1682 This avoids undefined behavior in expressions like
1683 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1684 from race conditions in accessing the global variables
1685 case_temp1 and case_temp2.
1686 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1687 * lisp.h (case_temp1, case_temp2): Remove their decls.
1688 * character.h (ASCII_CHAR_P): Move from here ...
1689 * lisp.h: ... to here, so that the inline functions mentioned
1690 above can use them.
1691
4a6bea26
PE
1692 * dired.c (directory_files_internal_unwind): Now static.
1693
f14b7e14
PE
1694 * fileio.c (file_name_as_directory, directory_file_name):
1695 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1696 Now static.
2893f146
PE
1697 (file_name_as_directory): Use const pointers when appropriate.
1698 (Fexpand_file_name): Likewise. In particular, newdir might
1699 point at constant storage, so make it a const pointer.
fd4ead52 1700 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1701 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1702 signedness issues.
f839df0c
PE
1703 (Fset_file_times, Finsert_file_contents, auto_save_error):
1704 Rename locals to avoid shadowing.
f14b7e14 1705
5716756e 1706 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1707 (Ftry_completion, Fall_completions): Rename or remove locals
1708 to avoid shadowing.
5716756e 1709
b4c3046a
PE
1710 * marker.c (bytepos_to_charpos): Remove; unused.
1711
b45db522
PE
1712 * lisp.h (verify_bytepos, count_markers): New decls,
1713 so that gcc does not warn that these functions aren't declared.
1714
85876d07
PE
1715 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1716 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1717 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1718 (copy_text): Remove unused local var.
85876d07 1719
03d78a21 1720 * filelock.c (within_one_second): Now static.
b3dd38ab 1721 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1722
5df8f01b
PE
1723 * buffer.c (fix_overlays_before): Mark locals as initialized.
1724 (fix_start_end_in_overlays): Likewise. This function should be
1725 simplified by using pointers-to-pointers, but that's a different
1726 matter.
b1d876f1 1727 (switch_to_buffer_1): Now static.
8f54f30a
PE
1728 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1729 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1730
a70072c9 1731 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1732 Fix pointer signedness issue.
edced198
PE
1733 (sys_subshell): Mark local as volatile if checking for lint,
1734 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1735 (MAXPATHLEN): Define only if needed.
a70072c9 1736
a0977c44
PE
1737 * process.c (serial_open, serial_configure): Move decls from here ...
1738 * systty.h: ... to here, so that they can be checked.
1739
a884fdcc
PE
1740 * fns.c (get_random, seed_random): Move extern decls from here ...
1741 * lisp.h: ... to here, so that they can be checked.
1742
604efe86 1743 * sysdep.c (reset_io): Now static.
b8950c94 1744 (wait_for_termination_signal): Remove; unused.
604efe86 1745
38fc62d9
PE
1746 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1747 (copy_keymap_item, append_key, push_text_char_description):
1748 Now static.
1004a21a 1749 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1750 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1751 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1752 (describe_map_tree):
1753 Rename locals to avoid shadowing.
38fc62d9 1754
2f2650da
PE
1755 * keyboard.c: Declare functions static if they are not used elsewhere.
1756 (echo_char, echo_dash, cmd_error, top_level_2):
1757 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1758 (read_char, kbd_buffer_get_event, make_lispy_position):
1759 (make_lispy_event, make_lispy_movement, apply_modifiers):
1760 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1761 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1762 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1763 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1764 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1765
a053e86c 1766 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1767 (mark_kboards): Move decl here ...
1768 * alloc.c (mark_kboards): ... from here.
a053e86c 1769
4752793e
PE
1770 * lisp.h (force_auto_save_soon): New decl.
1771
74f10ca7 1772 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1773 (DEFINE_DUMMY_FUNCTION): New macro.
1774 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1775 Use it.
c03cd23f
PE
1776 (main): Add casts to avoid warnings
1777 if GCC considers string literals to be constants.
74f10ca7 1778
022e70d4
PE
1779 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1780
59d6fe83
PE
1781 * dbusbind.c: Pointer signedness fixes.
1782 (xd_signature, xd_append_arg, xd_initialize):
1783 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1784 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1785 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1786 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1787
78320123
PE
1788 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1789 if GCC considers string literals to be constants.
49cebcca 1790 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1791
35ac2a97
SM
17922011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1793
fb103ca9
SM
1794 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1795 (print_preprocess, print_object): New macro to fix last change.
1796
35ac2a97
SM
1797 * print.c (print_preprocess): Don't forget font objects.
1798
62973b41
JB
17992011-03-16 Juanma Barranquero <lekktu@gmail.com>
1800
1801 * emacs.c (USAGE3): Doc fixes.
1802
0e48bb22
AS
18032011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1804
1805 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1806 structure.
1807
7684e57b
JB
18082011-03-14 Juanma Barranquero <lekktu@gmail.com>
1809
1810 * lisp.h (VWindow_system, Qfile_name_history):
1811 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1812 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1813 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1814
1815 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1816 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1817
1818 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1819 * w32console.c (detect_input_pending, read_input_pending)
1820 (encode_terminal_code):
1821 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1822 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1823 (w32_system_caret_y, Qfile_name_history):
1824 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1825 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1826 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1827 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1828 * w32proc.c (Qlocal, report_file_error):
1829 * w32term.c (Vwindow_system, updating_frame):
1830 * w32uniscribe.c (initialized, uniscribe_font_driver):
1831 Remove unneeded extern declarations.
1832
2aa46d6c
CY
18332011-03-14 Chong Yidong <cyd@stupidchicken.com>
1834
c96bbc66 1835 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1836
cffc6f3b
CY
18372011-03-13 Chong Yidong <cyd@stupidchicken.com>
1838
1839 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1840 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1841 These macros can no longer be used for assignment.
1842
44f230aa
SM
1843 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1844 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1845 (record_buffer_markers, fetch_buffer_markers): New functions for
1846 recording and fetching special buffer markers.
1847 (set_buffer_internal_1, set_buffer_temp): Use them.
1848
1849 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1850
1851 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1852
1853 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1854 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1855
1856 * xdisp.c (hscroll_window_tree):
1857 (reconsider_clip_changes): Use PT instead of BUF_PT.
1858
d251f04b
EZ
18592011-03-13 Eli Zaretskii <eliz@gnu.org>
1860
1861 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1862 $(EMACS_ROOT)/lib/intprops.h.
1863
f0c77cd1
PE
18642011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1865
3eca4629
PE
1866 Fix more problems found by GCC 4.5.2's static checks.
1867
7c86ee98
PE
1868 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1869 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1870 (xg_free_frame_widgets): Make it clear that a local variable is
1871 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1872 (gdk_window_get_screen): Make it clear that this macro is needed
1873 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1874 (int_gtk_range_get_value): New function, which avoids a diagnostic
1875 from gcc -Wbad-function-cast.
1876 (xg_set_toolkit_scroll_bar_thumb): Use it.
1877 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1878 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1879 (get_utf8_string, xg_get_file_with_chooser):
1880 Rename locals to avoid shadowing.
1881 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1882
41729b81
PE
1883 * xgselect.c (xg_select): Remove unused var.
1884
f0c77cd1
PE
1885 * image.c (four_corners_best): Mark locals as initialized.
1886 (gif_load): Initialize transparent_p to zero (Bug#8238).
1887 Mark another local as initialized.
ec6cf4c6 1888 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1889
ce0ad53d 1890 * image.c (clear_image_cache): Now static.
d5d5a617 1891 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1892 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1893 (x_edge_detection): Remove unnecessary cast that
1894 gcc -Wbad-function-cast diagnoses.
2037898d 1895 (gif_load): Fix pointer signedness.
6ae141d6
PE
1896 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1897 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1898
33383987 18992011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1900
d32df629
PE
1901 Improve quality of tests for time stamp overflow.
1902 For example, without this patch (encode-time 0 0 0 1 1
1903 1152921504606846976) returns the obviously-bogus value (-948597
1904 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1905 reports time overflow. See
1906 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1907 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1908 * editfns.c: Include limits.h and intprops.h.
1909 (TIME_T_MIN, TIME_T_MAX): New macros.
1910 (time_overflow): Move earlier, to before first use.
1911 (hi_time, lo_time): New functions, for an accurate test for
1912 out-of-range times.
1913 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1914 (Fget_internal_run_time): Don't assume time_t fits in int.
1915 (make_time): Use list2 instead of Fcons twice.
1916 (Fdecode_time): More accurate test for out-of-range times.
1917 (check_tm_member): New function.
1918 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1919 (lisp_time_argument): Don't rely on undefined left-shift and
1920 right-shift behavior when checking for time stamp overflow.
8be6f318 1921
fe31d94c
PE
1922 * editfns.c (time_overflow): New function, refactoring common code.
1923 (Fformat_time_string, Fdecode_time, Fencode_time):
1924 (Fcurrent_time_string): Use it.
1925
8be6f318
PE
1926 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1927 * dired.c (make_time): Move to ...
1928 * editfns.c (make_time): ... here.
1929 * systime.h: Note the move.
1930
09d9db2c 19312011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1932
126bc0dc
YM
1933 * fringe.c (update_window_fringes): Remove unused variables.
1934
c47cbdfd
YM
1935 * unexmacosx.c (copy_data_segment): Also copy __got section.
1936 (Bug#8223)
1937
7ac80be9
EZ
19382011-03-12 Eli Zaretskii <eliz@gnu.org>
1939
c96bbc66 1940 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1941 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1942 Constify `char *' arguments and their references according to
1943 prototypes in tparam.h.
1944
ecb0f94d 1945 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1946
7ac80be9
EZ
1947 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1948 Adapt all references accordingly.
1949
1950 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1951
ef1fd07e
TT
19522011-03-11 Tom Tromey <tromey@redhat.com>
1953
1954 * buffer.c (syms_of_buffer): Remove obsolete comment.
1955
7ef4b50c
EZ
19562011-03-11 Eli Zaretskii <eliz@gnu.org>
1957
1958 * termhooks.h (encode_terminal_code): Declare prototype.
1959
1960 * msdos.c (encode_terminal_code): Don't declare prototype.
1961
1962 * term.c (encode_terminal_code): Now external again, used by
1963 w32console.c and msdos.c.
1964
44f230aa
SM
1965 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1966 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1967
4b1ec863 19682011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1969
1714f52b 1970 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1971
4b1ec863
PE
1972 * fringe.c (update_window_fringes): Mark locals as initialized
1973 (Bug#8227).
1974 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1975
524c7aa6
PE
1976 * alloc.c (mark_fringe_data): Move decl from here ...
1977 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1978 to check its interface.
1979 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1980
a5c0af81 1981 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1982 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1983 (fontset_font): Mark local as initialized.
a9a06e0b 1984 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1985
b4716021
PE
1986 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1987
811e9bac 1988 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1989 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1990 (x_own_selection, Fx_disown_selection_internal): Rename locals
1991 to avoid shadowing.
1992 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1993
7e3ab302
PE
1994 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1995 so that the caller can use some name other than gcpro1.
1996 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1997 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1998 (Fx_backspace_delete_keys_p):
1999 Use them to avoid shadowing, and rename vars to avoid shadowing.
2000 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2001 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2002 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2003 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2004 Remove unused locals.
7e3ab302
PE
2005 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2006 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2007 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2008 macros.
f78faa98 2009
e2b13473
PE
2010 * xterm.h (x_mouse_leave): New decl.
2011
77f23912
PE
2012 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2013 Remove unused functions.
cdf4ba58
PE
2014 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2015 (x_calc_absolute_position): Now static.
7411c686 2016 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2017 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2018 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2019 unless they are used.
38d0b34a
PE
2020 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2021 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2022 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2023 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2024 (x_error_catcher, x_connection_closed, x_error_handler):
2025 (x_error_quitter, xembed_send_message, x_iconify_frame):
2026 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2027 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2028 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2029
44f230aa
SM
2030 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2031 Rename or move locals to avoid shadowing.
6b463e58 2032 (tty_defined_color, merge_face_heights): Now static.
5967d051 2033 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2034 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2035 does not deduce is never used uninitialized.
73719eba
PE
2036 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2037 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2038
426994c3 2039 * terminal.c (store_terminal_param): Now static.
5489860b 2040
032f1620 2041 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2042 (set_frame_menubar): Remove unused local.
d4323972 2043 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2044 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2045 since they might point to immutable storage.
281585b0
PE
2046 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2047 since it's unused otherwise.
032f1620 2048
367c19e5 2049 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2050 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2051 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2052 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2053 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2054 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2055 does not deduce are never used uninitialized.
70739cbe 2056
07b48fa9
PE
2057 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2058
8868a238 2059 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2060 * window.c (window_loop, size_window):
2061 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2062
7e5cf297 2063 * window.c (display_buffer): Now static.
d6550a9f
PE
2064 (size_window): Mark variables that gcc -Wuninitialized
2065 does not deduce are never used uninitialized.
a586633d
PE
2066 * window.h (check_all_windows): New decl, to forestall
2067 gcc -Wmissing-prototypes diagnostic.
5b555da1 2068 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2069
f6095868
PE
2070 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2071 shadowing.
2072 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2073 Include <limits.h>.
2074 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2075 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2076 (load_charset_map): Mark variables that gcc -Wuninitialized
2077 does not deduce are never used uninitialized.
53df7c11 2078 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2079
f38b440c
PE
2080 * coding.c (coding_set_source, coding_set_destination):
2081 Use "else { /* comment */ }" rather than "else /* comment */;"
2082 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2083 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2084 a block, when the outer 'i' will do.
2085 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2086 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2087 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2088 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2089 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2090 Rename locals to avoid shadowing.
2091 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2092 * coding.c (emacs_mule_char, encode_invocation_designation):
2093 Now static, since they're not used elsewhere.
413bb2db 2094 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2095 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2096 (decode_coding_emacs_mule): Mark variables that gcc
2097 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2098 (detect_coding_iso_2022): Initialize a local variable that might
2099 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2100 this initialization is needed. (Bug#8211)
5f58e762
PE
2101 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2102 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2103 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2104 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2105 Remove unused macros.
f38b440c 2106
232b38b9 2107 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2108 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2109 * character.c (string_count_byte8): Likewise.
232b38b9 2110
fb90da1b
PE
2111 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2112 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2113
fb93dbc2
PE
2114 * chartab.c (copy_sub_char_table): Now static, since it's not used
2115 elsewhere.
5c156ace
PE
2116 (sub_char_table_ref_and_range, char_table_ref_and_range):
2117 Rename locals to avoid shadowing.
bbcd0949 2118 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2119
7d3b3862 2120 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2121 (BIDI_BOB): Remove unused macro.
7d3b3862 2122
6be7d3da
PE
2123 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2124 deduce are never used uninitialized.
c2ed9c8b 2125 * term.c (encode_terminal_code): Likewise.
6be7d3da 2126
75f8807f 2127 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2128
50938595
PE
2129 * tparam.h: New file.
2130 * term.c, tparam.h: Include it.
2131 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2132 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2133 Move these decls to tparam.h, and make them agree with what
2134 is actually in tparam.c. The previous trick of using incompatible
2135 decls in different modules does not conform to the C standard.
2136 All callers of tparam changed to use tparam's actual API.
2137 * tparam.c (tparam1, tparam, tgoto):
2138 Use const pointers where appropriate.
2139
fbceeba2
PE
2140 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2141 * cm.h (struct cm): Likewise.
2142 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2143 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2144 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2145 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2146 (turn_on_face, init_tty): Likewise.
2147 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2148
7f3f1250
PE
2149 * term.c (term_mouse_position): Rename local to avoid shadowing.
2150
e6ca6543
PE
2151 * alloc.c (mark_ttys): Move decl from here ...
2152 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2153
c40f8d15
AS
21542011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2155
2156 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2157
cfe0661d
JB
21582011-03-09 Juanma Barranquero <lekktu@gmail.com>
2159
2160 * search.c (compile_pattern_1): Remove argument regp, unused since
2161 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2162 (compile_pattern): Don't pass it.
2163
0afb4571
J
21642011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2165
2166 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2167 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2168 for ! HAVE_GTK3.
2169 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2170
2171 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2172
2173 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2174 gdk_window_get_screen, gdk_window_get_geometry,
2175 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2176 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2177 (xg_get_pixbuf_from_pixmap): New function.
2178 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2179 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2180 Call xg_get_pixbuf_from_pixmap instead of
2181 gdk_pixbuf_get_from_drawable.
2182 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2183 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2184 (xg_check_special_colors): Use GtkStyleContext and its functions
2185 for HAVE_GTK3.
2186 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2187 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2188 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2189 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2190 Call gtk_widget_get_preferred_size.
0afb4571
J
2191 (xg_frame_resized): gdk_window_get_geometry only takes 5
2192 parameters.
44f230aa
SM
2193 (xg_win_to_widget, xg_event_is_for_menubar):
2194 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2195 (xg_set_widget_bg): New function.
2196 (delete_cb): New function.
2197 (xg_create_frame_widgets): connect delete-event to delete_cb.
2198 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2199 (xg_set_background_color): Call xg_set_widget_bg.
2200 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2201 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2202 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2203 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2204 if ! HAVE_GTK3.
2205 (update_frame_tool_bar): Call gtk_widget_hide.
2206 (xg_initialize): Use GDK_KEY_g.
2207
2208 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2209 if ! HAVE_GTK3
2210 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2211
2212 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2213 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2214 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2215
1c2cc4ef
JB
22162011-03-08 Juanma Barranquero <lekktu@gmail.com>
2217
2218 * w32xfns.c (select_palette): Check success of RealizePalette against
2219 GDI_ERROR, not zero.
2220
33383987 2221See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2222
2223;; Local Variables:
2224;; coding: utf-8
aac0c6e3
MR
2225;; End:
2226
33383987 2227 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2228
2229 This file is part of GNU Emacs.
2230
2231 GNU Emacs is free software: you can redistribute it and/or modify
2232 it under the terms of the GNU General Public License as published by
2233 the Free Software Foundation, either version 3 of the License, or
2234 (at your option) any later version.
2235
2236 GNU Emacs is distributed in the hope that it will be useful,
2237 but WITHOUT ANY WARRANTY; without even the implied warranty of
2238 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2239 GNU General Public License for more details.
2240
2241 You should have received a copy of the GNU General Public License
2242 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.