Small changes for lispref/errors.texi
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f01d3321
CY
12012-02-23 Chong Yidong <cyd@gnu.org>
2
3 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4 call when setting menu-bar-lines and tool-bar-lines parameters.
5 (unwind_create_frame_1): New helper function.
6
7 * window.c (inhibit_window_configuration_change_hook): New var.
8 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 9 (syms_of_window): Initialize it.
f01d3321 10
86b847b6
CY
112012-02-22 Chong Yidong <cyd@gnu.org>
12
13 * xterm.c (x_draw_image_relief): Add missing type check for
14 Vtool_bar_button_margin (Bug#10743).
15
a59225b1
CY
162012-02-21 Chong Yidong <cyd@gnu.org>
17
18 * fileio.c (Vfile_name_handler_alist): Doc fix.
19
20 * buffer.c (Fget_file_buffer): Protect against invalid file
21 handler return value.
22
310f5bd4
PE
232012-02-20 Paul Eggert <eggert@cs.ucla.edu>
24
cb3a28cc
PE
25 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
26 when computing $valmask.
27
310f5bd4
PE
28 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
29 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
30 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
31 It's useless in that case, and it can cause problems on hosts
32 that allocate halves of EMACS_INT values separately.
33 Reported by Dan Horák. Diagnosed by Andreas Schwab in
34 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
35 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
36 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
37 it avoids undefined behavior on hosts where shifting right by more
38 than the word width has undefined behavior.
39
2375c96a
CY
402012-02-19 Chong Yidong <cyd@gnu.org>
41
42 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
43 (Funhandled_file_name_directory, Ffile_name_as_directory)
44 (Fdirectory_file_name, Fexpand_file_name)
45 (Fsubstitute_in_file_name): Protect against invalid file handler
46 return values (Bug#10845).
47
3eb49e71
EZ
482012-02-18 Eli Zaretskii <eliz@gnu.org>
49
50 * .gdbinit (pitx): Fix incorrect references to fields of the
51 iterator stack.
52
7b926f3f
CY
532012-02-17 Chong Yidong <cyd@gnu.org>
54
55 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
56
11273115
PE
572012-02-15 Paul Eggert <eggert@cs.ucla.edu>
58
59 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
60 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
61
c3a70e2b
CY
622012-02-15 Chong Yidong <cyd@gnu.org>
63
64 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
65 marked as special. Also, starting docstrings with * is obsolete.
66
0ca43699
AS
672012-02-13 Andreas Schwab <schwab@linux-m68k.org>
68
69 * gnutls.c (emacs_gnutls_write): Fix last change.
70
2e8f3c56
LI
712012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
72
73 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
74 send_process.
75
af70074f
SM
762012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
77
78 * keymap.c (Fsingle_key_description): Handle char ranges.
79
95986d52
CY
802012-02-12 Chong Yidong <cyd@gnu.org>
81
afd83bd1
CY
82 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
83 as that creates a dangerous corner case.
84
95986d52
CY
85 * window.c (Fdelete_window_internal): Invalidate the mouse
86 highlight (Bug#9904).
87
bd7da63e
GM
882012-02-12 Glenn Morris <rgm@gnu.org>
89
90 * xselect.c (Fx_own_selection_internal)
91 (Fx_get_selection_internal, Fx_disown_selection_internal)
92 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
93 * nsselect.m (Fx_own_selection_internal)
94 (Fx_disown_selection_internal, Fx_selection_exists_p)
95 (Fx_selection_owner_p, Fx_get_selection_internal):
96 Sync docs and argument specs with the xselect.c versions.
97
77abcbc2
LI
982012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
99
100 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
101
90b671e2
EZ
1022012-02-11 Eli Zaretskii <eliz@gnu.org>
103
1c0ca0b7
EZ
104 * w32select.c (Fx_selection_exists_p): Sync doc string and
105 argument list with xselect.c. (Bug#10783)
106
107 * w16select.c (Fx_selection_exists_p): Sync doc string and
108 argument list with xselect.c. (Bug#10783)
90b671e2 109
49241268
GM
1102012-02-10 Glenn Morris <rgm@gnu.org>
111
112 * fns.c (Fsecure_hash): Doc fix.
113
f998bbe7 1142012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
115
116 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
117
0992bd9c
CY
1182012-02-07 Chong Yidong <cyd@gnu.org>
119
120 * buffer.c (Fbuffer_local_variables)
121 (buffer_lisp_local_variables): Handle unbound vars correctly;
122 don't let Qunbound leak into Lisp.
123
af008560
GM
1242012-02-07 Glenn Morris <rgm@gnu.org>
125
dd605cc4
GM
126 * image.c (Fimagemagick_types): Doc fix.
127
af008560
GM
128 * image.c (imagemagick-render-type): Change it from a lisp object
129 to an integer. Move the doc here from the lisp manual.
130 Treat all values not equal to 0 the same.
131
1449fa1d
CY
1322012-02-06 Chong Yidong <cyd@gnu.org>
133
134 * doc.c (store_function_docstring): Avoid applying docstring of
135 alias to base function (Bug#2603).
136
3723ec07
AS
1372012-02-04 Andreas Schwab <schwab@linux-m68k.org>
138
139 * .gdbinit (pp1, pv1): Remove redundant defines.
140 (pr): Use pp.
141
79c1cc1e
CY
1422012-02-04 Chong Yidong <cyd@gnu.org>
143
144 * nsterm.m: Declare a global (Bug#10694).
145
d7f29f8e
EZ
1462012-02-04 Eli Zaretskii <eliz@gnu.org>
147
148 * w32.c (get_emacs_configuration_options): Include
149 --enable-checking, if specified, in the return value.
150
3b95a6f9
MR
1512012-02-04 Martin Rudalics <rudalics@gmx.at>
152
153 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
154 after rounding frame sizes. (Bug#9723)
155
d6fa96a6
EZ
1562012-02-04 Eli Zaretskii <eliz@gnu.org>
157
158 * keyboard.c (adjust_point_for_property): Don't position point
159 before BEGV. (Bug#10696)
160
df0b2940
PE
1612012-02-03 Paul Eggert <eggert@cs.ucla.edu>
162
163 Handle overflow when computing char display width (Bug#9496).
164 * character.c (char_width): Return EMACS_INT, not int.
165 (char_width, c_string_width): Check for overflow when
166 computing the width; this is possible now that individual
167 characters can have unbounded width. Problem introduced
168 by merge from Emacs 23 on 2012-01-19.
169
6bee44d6
MA
1702012-02-02 Michael Albinus <michael.albinus@gmx.de>
171
172 * dbusbind.c (Fdbus_register_method): Mention the return value
173 :ignore in the docstring.
174
44f92739
GM
1752012-02-02 Glenn Morris <rgm@gnu.org>
176
1b9f60cc
GM
177 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
178
44f92739
GM
179 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
180 Unconditionally set to t. (Bug#10673)
181 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
182 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
183 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
184
c5d3843c
KH
1852012-02-02 Kenichi Handa <handa@m17n.org>
186
187 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
188 0, do not call append_composite_glyph.
189
159462d4 1902012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
191
192 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
193 NULL (Bug#6988).
194 (x_produce_glyphs): If the component of a composition is a null
195 string, set it->pixel_width to 1 to avoid zero-width glyph.
196
78cef877
EZ
1972012-02-01 Eli Zaretskii <eliz@gnu.org>
198
199 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
200 first 2 arguments are identical. This makes inserting large
201 output from a subprocess an order of magnitude faster on
202 MS-Windows, where all sbrk'ed memory is always contiguous.
203
97897668
GM
2042012-01-31 Glenn Morris <rgm@gnu.org>
205
206 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 207 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
208 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
209
31fd3586
GM
2102012-01-29 Glenn Morris <rgm@gnu.org>
211
212 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
213
0e24a8b2
CY
2142012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
215
216 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
217
cc0adcb0
CY
2182012-01-28 Chong Yidong <cyd@gnu.org>
219
220 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
221
acc28cb9
CY
2222012-01-26 Chong Yidong <cyd@gnu.org>
223
9c69cfb7
CY
224 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
225
acc28cb9
CY
226 * search.c (Fsearch_forward, Fsearch_backward): Document negative
227 repeat counts (Bug#10507).
228
48da7392
GM
2292012-01-26 Glenn Morris <rgm@gnu.org>
230
231 * lread.c (syms_of_lread): Doc fix.
232
14af5f7f
CY
2332012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
234
235 * coding.c (encode_designation_at_bol): Change return value to
236 EMACS_INT.
237
0b21c100
CY
2382012-01-25 Chong Yidong <cyd@gnu.org>
239
240 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
241
3c2907f7
CY
2422012-01-21 Chong Yidong <cyd@gnu.org>
243
244 * floatfns.c (Fcopysign): Make the second argument non-optional,
245 since nil is not allowed anyway.
246
959ad23f
AS
2472012-01-21 Andreas Schwab <schwab@linux-m68k.org>
248
249 * process.c (read_process_output): Use p instead of XPROCESS (proc).
250 (send_process): Likewise.
251
34a02f46
MR
2522012-01-19 Martin Rudalics <rudalics@gmx.at>
253
254 * window.c (save_window_save, Fcurrent_window_configuration)
255 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
256 doc-strings.
257
1259009a 2582012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
259
260 * character.c (char_width): New function.
70d4fdf6
GM
261 (Fchar_width, c_string_width, lisp_string_width):
262 Use char_width (Bug#9496).
25ed9e61 263
6a6ee00d
MR
2642012-01-16 Martin Rudalics <rudalics@gmx.at>
265
266 * window.c (Vwindow_persistent_parameters): New variable.
267 (Fset_window_configuration, save_window_save): Handle persistent
268 window parameters.
269
c85efaf7
EZ
2702012-01-14 Eli Zaretskii <eliz@gnu.org>
271
272 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
273 thrashing the stack of the thread. (Bug#9087)
274
5944709e
PE
2752012-01-12 Paul Eggert <eggert@cs.ucla.edu>
276
277 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
278
e71f5d99
EZ
2792012-01-11 Eli Zaretskii <eliz@gnu.org>
280
281 * xdisp.c (rows_from_pos_range): Handle the case where the
282 highlight ends on a newline. (Bug#10464)
283 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
284 he end column for display of highlight that ends on a newline
285 before a R2L line.
286
ce316182
GM
2872012-01-11 Glenn Morris <rgm@gnu.org>
288
289 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
290 from load-path also when installation-directory is nil. (Bug#10208)
291
5b43da69
GM
2922012-01-10 Glenn Morris <rgm@gnu.org>
293
74cc8ff9
GM
294 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
295
7d8d6e4e
GM
296 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
297 Update template values to be closer to their typical values these days.
5b43da69 298
a0db8d43
EZ
2992012-01-09 Eli Zaretskii <eliz@gnu.org>
300
301 * xdisp.c (rows_from_pos_range): Accept additional argument
302 DISP_STRING, and accept any glyph in a row whose object is that
303 string as eligible for mouse highlight. Fixes mouse highlight of
304 display strings from overlays. (Bug#10464)
305
9a0115ab 3062012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 307
b9110d6a 308 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
309 * fileio.c (auto_saving_dir_umask): New static var.
310 (Fmake_directory_internal): Use it.
311 (do_auto_save_make_dir): Set it, instead of invoking chmod after
312 creating the directory. The old code temporarily assigns
313 too-generous permissions to the directory.
314 (do_auto_save_eh): Clear it.
b9110d6a 315 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
316 that the var is always cleared.
317
6c1bd3f3
EZ
3182012-01-07 Eli Zaretskii <eliz@gnu.org>
319
320 * search.c (scan_buffer): Pass character positions to
321 know_region_cache, not byte positions. (Bug#6540)
322
069d2b50
L
3232012-01-07 LynX <_LynX@bk.ru> (tiny change)
324
325 * w32.c (sys_rename): Report EXDEV when rename of a directory
326 fails because the target is on another logical disk. (Bug#10284)
327
75bf0d33
DB
3282012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
329
330 * xterm.c (x_embed_request_focus): New function.
331
332 * xterm.h: Add prototype.
333
334 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
335
1c6e5a32
GM
3362012-01-05 Glenn Morris <rgm@gnu.org>
337
338 * emacs.c (emacs_copyright): Update short copyright year to 2012.
339
651e947e
EZ
3402012-01-01 Eli Zaretskii <eliz@gnu.org>
341
342 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
343 Load gnutls_transport_set_lowat only if GnuTLS version is below
344 2.11.1.
345 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
346 GnuTLS versions below 2.11.1.
347
3778cdd8
AL
3482011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
349
350 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
351 to the doc string advising against its use for altering the way
352 windows are scrolled.
353
0e5317f7
KH
3542011-12-28 Kenichi Handa <handa@m17n.org>
355
356 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
357 coding-system ASCII compatible only when it does not produce BOM
358 on encoding (Bug#10383).
359
93d5ca1f
JD
3602011-12-26 Jan Djärv <jan.h.d@swipnet.se>
361
362 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
363 can scroll.
364 (create_and_show_popup_menu): Always use menu_position_func for
365 Gtk3 (Bug#10361).
366
ca22b785
AS
3672011-12-24 Andreas Schwab <schwab@linux-m68k.org>
368
369 * callint.c (Fcall_interactively): Don't truncate prompt string.
370
d048e1e6
EZ
3712011-12-23 Eli Zaretskii <eliz@gnu.org>
372
373 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
374 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 375 resumed from there (after widening). (Bug#10360)
d048e1e6 376
5ccaba1f
JD
3772011-12-22 Jan Djärv <jan.h.d@swipnet.se>
378
379 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
380
204ee57f
JD
3812011-12-21 Jan Djärv <jan.h.d@swipnet.se>
382
b81d40f0
JB
383 * nsterm.m (x_free_frame_resources):
384 Release f->output_data.ns->miniimage.
204ee57f
JD
385 (ns_index_color): Fix indentation. Do not retain
386 color_table->colors[i].
387
388 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
389 before returning.
390
391 * nsfns.m (x_set_background_color): Assign return value from
392 ns_index_color to face-background instead of NSColor*.
393 (ns_implicitly_set_icon_type): Fix indentation.
394 Change assignment in for loop to comparison.
395
396 * emacs.c (ns_pool): New variable.
397 (main): Assign ns_pool.
398 (Fkill_emacs): Call ns_release_autorelease_pool.
399
400 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
401 autorelease fdesc, release fdAttrs and tdict.
402 (ns_get_covering_families): Release charset.
403 (ns_findfonts): Release NSFontDescriptor created with new.
404 (ns_uni_to_glyphs): Fix indentation.
405 (setString): Release attrStr before assigning new value.
406
c803b2b7
JD
4072011-12-18 Jan Djärv <jan.h.d@swipnet.se>
408
678f4426
JD
409 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
410 and NS_IMPL_COCOA.
411 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
412 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
413
cd394be1 4142011-12-18 David Reitter <reitter@cmu.edu>
678f4426 415
5fecd5fc
JD
416 * nsterm.m (ns_term_init): Subscribe for notifications
417 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
418 to method trackingNotification in EmacsMenu.
419
420 * nsmenu.m (trackingMenu): New variable.
3771cb17 421 (trackingNotification): New method (from Aquamacs).
5fecd5fc 422 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 423 from Aquamacs (Bug#7030).
678f4426
JD
424
4252011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 426
c803b2b7
JD
427 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
428 (symbol_to_nsstring): Fix indentation.
429 (ns_symbol_to_pb): New function.
430 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
431 (Fns_rotate_cut_buffers_internal): Removed.
432 (Fns_store_selection_internal): Renamed from
433 Fns_store_cut_buffer_internal.
434 (ns_get_foreign_selection, Fx_own_selection_internal)
435 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
436 (Fns_get_selection_internal, Fns_store_selection_internal):
437 Use ns_symbol_to_pb and check if return value is nil.
438 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
439 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
440 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
441 renamed to Sns_store_selection_internal.
442 (ns_handle_selection_request): Move code to Fx_own_selection_internal
443 and remove this function.
444 (ns_handle_selection_clear): Remove, never used.
445 (Fx_own_selection_internal): Move code from ns_handle_selection_request
446 here.
447
e1b01a3a
KB
4482011-12-17 Ken Brown <kbrown@cornell.edu>
449
450 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
451 GID is unknown (Bug#10257).
452
2adb6e85
PE
4532011-12-17 Paul Eggert <eggert@cs.ucla.edu>
454
455 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
456 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
457 which caused a build failure on GNU/Linux IA-64. This problem was
458 introduced by my 2011-10-07 patch.
459
d1d7b339
JL
4602011-12-15 Juri Linkov <juri@jurta.org>
461
462 * image.c (imagemagick_error): New function. (Bug#10112)
463 (imagemagick_load_image): Comment out `MagickSetResolution' call.
464 Use `imagemagick_error' where ImageMagick functions return
465 `MagickFalse'.
466 (Fimagemagick_types): Add `Fnreverse' to return the list in the
467 proper order.
468
100d5755
KH
4692011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
470
471 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
472 fill background (Bug#8992).
473
454592a6
MR
4742011-12-13 Martin Rudalics <rudalics@gmx.at>
475
476 * window.c (Vwindow_combination_resize)
477 (Vwindow_combination_limit): Use t instead of non-nil in
478 doc-strings.
61d4b438
MR
479 (Vrecenter_redisplay): Add first sentence of doc-string on
480 separate line.
53524d93 481 (Frecenter): Fix doc-string typo.
454592a6 482
3633e3aa
KH
4832011-12-11 Kenichi Handa <handa@m17n.org>
484
485 * coding.c (Funencodable_char_position): Pay attention to the
486 buffer text relocation (Bug#9389).
487
7b9d523a
JD
4882011-12-10 Jan Djärv <jan.h.d@swipnet.se>
489
490 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
491 gtk_init (Bug#10100).
492
b73189c6
EZ
4932011-12-10 Eli Zaretskii <eliz@gnu.org>
494
495 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
496 IT->string is nil. (Bug#10263)
497
f7dfe5d6
JD
4982011-12-10 Jan Djärv <jan.h.d@swipnet.se>
499
83faebb4
JD
500 * nsterm.h (x_free_frame_resources): Declare.
501
f7dfe5d6
JD
502 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
503 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
504
505 * nsterm.h (ns_get_defaults_value): Declare.
506
507 * nsterm.m (ns_default): Call ns_get_defaults_value.
508
7cd4e72c
EZ
5092011-12-09 Eli Zaretskii <eliz@gnu.org>
510
511 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
512 (Bug#10170)
513
b34d7317
YM
5142011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
515
516 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
517 that where the value of an _OBJC_* symbol points to is in the .bss
518 section (Bug#10240).
519
76470ad1
KH
5202011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
521
522 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 523 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 524
745fff94
KH
5252011-12-08 Kenichi Handa <handa@m17n.org>
526
527 * ftfont.c (get_adstyle_property): Fix previous change
528 (Bug#10233).
529
6e44397c
JB
5302011-12-07 Juanma Barranquero <lekktu@gmail.com>
531
532 * w32.c (init_environment): If no_site_lisp, remove site-lisp
533 dirs from the default value of EMACSLOADPATH (bug#10208).
534
7efa6272
GM
5352011-12-07 Glenn Morris <rgm@gnu.org>
536
537 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
538 installation and source directories as well. (Bug#10208)
539
f6fc4d87
CY
5402011-12-06 Chong Yidong <cyd@gnu.org>
541
542 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
543
2bf26180
GM
5442011-12-06 Glenn Morris <rgm@gnu.org>
545
546 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
547 as an error, not just -1. (Bug#10217)
548
3a6ad4f0
CY
5492011-12-05 Chong Yidong <cyd@gnu.org>
550
551 * keyboard.c (process_special_events): New function.
552 (swallow_events, Finput_pending_p): Use it (Bug#10195).
553
75a3b399
PE
5542011-12-05 Paul Eggert <eggert@cs.ucla.edu>
555
556 * coding.c (encode_designation_at_bol): Don't use uninitialized
557 local variable (Bug#9318).
558
c3c9e25e
KH
5592011-12-05 Kenichi Handa <handa@m17n.org>
560
561 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
562 return Qnil (Bug#8046, Bug#10193).
563
5eb05ea3
KH
5642011-12-05 Kenichi Handa <handa@m17n.org>
565
566 * coding.c (encode_designation_at_bol): New args charbuf_end and
567 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
568 (coding_set_source): Return how many bytes coding->source was
569 relocated.
570 (coding_set_destination): Return how many bytes
571 coding->destination was relocated.
572 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
573 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
574
5752011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
576
577 * coding.c (CODING_CHAR_CHARSET_P): New macro.
578 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
579 macro (Bug#9318).
580
5812011-12-05 Andreas Schwab <schwab@linux-m68k.org>
582
583 The following changes are to fix Bug#9318.
584
a79703f5 585 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
586 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
587 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 588 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 589
7dbda6df
JB
5902011-12-05 Juanma Barranquero <lekktu@gmail.com>
591
592 * lisp.h (process_quit_flag): Fix external declaration.
593
6d5eb5b0
SM
5942011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
595
596 Don't macro-inline non-performance-critical code.
597 * eval.c (process_quit_flag): New function.
598 * lisp.h (QUIT): Use it.
599
a0c3fad0
JD
6002011-12-04 Jan Djärv <jan.h.d@swipnet.se>
601
602 * nsfns.m (get_geometry_from_preferences): New function.
603 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
604
6c07aac2
AS
6052011-12-04 Andreas Schwab <schwab@linux-m68k.org>
606
607 * emacs.c (Qkill_emacs): Define.
608 (syms_of_emacs): Initialize it.
609 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
610 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
611 (quit_throw_to_read_char): Add parameter `from_signal'.
612 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
613 * lisp.h (QUIT): Call Fkill_emacs if requested.
614
c052ead4
JD
6152011-12-03 Jan Djärv <jan.h.d@swipnet.se>
616
617 * widget.c (update_wm_hints): Return if wmshell is null.
618 (widget_update_wm_size_hints): New function.
619
620 * widget.h (widget_update_wm_size_hints): Declare.
621
622 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
623 widget_update_wm_size_hints (Bug#10104).
624
9e49252b
EZ
6252011-12-03 Eli Zaretskii <eliz@gnu.org>
626
627 * xdisp.c (handle_invisible_prop): If the invisible text ends just
628 before a newline, prepare the bidi iterator for consuming the
629 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 630 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 631
02b16839
JL
6322011-12-02 Juri Linkov <juri@jurta.org>
633
634 * search.c (Fword_search_regexp): New Lisp function created from
635 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
636 (Fword_search_backward, Fword_search_forward)
637 (Fword_search_backward_lax, Fword_search_forward_lax):
638 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
639 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
640
0068070e
SM
6412011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
642
643 * fileio.c (Finsert_file_contents): Move after-change-function call
644 to before the "handled:" label, since all "goto handled" appear in
645 cases where the *-change-functions have already been properly called
646 (bug#10117).
647
3360a3fc
AS
6482011-12-01 Andreas Schwab <schwab@linux-m68k.org>
649
650 * keyboard.c (interrupt_signal): Don't call kill-emacs when
651 waiting for input. (Bug#10169)
652
73d6c093
EZ
6532011-11-30 Eli Zaretskii <eliz@gnu.org>
654
655 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
656 verifies glyph row's hash code--we have just reallocated the
657 glyphs, so their contents can be complete garbage. (Bug#10164)
658
febe6bea
JB
6592011-11-30 Juanma Barranquero <lekktu@gmail.com>
660
661 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
662
801a4313
EZ
6632011-11-30 Eli Zaretskii <eliz@gnu.org>
664
665 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
666 attributes are tested _before_ calling verify_row_hash, to protect
667 against GCC re-ordering of the tests. (Bug#10164)
668
2b56b87e
JD
6692011-11-29 Jan Djärv <jan.h.d@swipnet.se>
670
671 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
672
673 * xterm.c (handle_one_xevent): Only set async_visible and friends
674 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 675 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
676 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
677
dbf31225
PE
6782011-11-28 Paul Eggert <eggert@cs.ucla.edu>
679
680 Remove GCPRO-related macros that exist only to avoid shadowing locals.
681 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
682 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
683 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
684 All uses changed to use GCPRO1 etc.
685 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
686 Revert to old implementation (i.e., before 2011-03-11).
687
1305621b
YM
6882011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
689
690 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
691 of scroll runs so as to avoid assigning disabled bogus rows and
692 unnecessary graphics copy operations.
693
8c9afb46
EZ
6942011-11-27 Eli Zaretskii <eliz@gnu.org>
695
696 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
697 (snprintf) [_MSC_VER]: Redirect to _snprintf.
698 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
699 (malloc, free, realloc, calloc): Redirect to e_* only when
700 compiling Emacs.
701
702 * lisp.h (GCTYPEBITS): Move before first use.
703 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
704 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
705 this macro definition.
706
707 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
708 _MSC_VER.
709
54e9e3bf
JD
7102011-11-27 Jan Djärv <jan.h.d@swipnet.se>
711
6d5eb5b0
SM
712 * gtkutil.c (xg_create_frame_widgets):
713 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
714 present with Gtk+ 2.0.
715
83aca1cb
PE
7162011-11-26 Paul Eggert <eggert@cs.ucla.edu>
717
718 * fileio.c (Finsert_file_contents): Undo previous change; see
719 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
720
5b76caa4
PE
7212011-11-26 Paul Eggert <eggert@cs.ucla.edu>
722
723 Rename locals to avoid shadowing.
724 * fileio.c (Finsert_file_contents):
725 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
726 * process.c (wait_reading_process_output):
727 Rename inner 'proc' to 'p' to avoid shadowing.
728 Indent for consistency with usual Emacs style.
729
8c535114
EZ
7302011-11-25 Eli Zaretskii <eliz@gnu.org>
731
732 * xdisp.c (redisplay_window): If cursor row is not fully visible
733 after recentering, and scroll-conservatively is set to a large
734 number, scroll window by a few more lines to make the cursor fully
735 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
736 (start_display): Don't move to the next line if the display should
737 start at a newline that is part of a display vector or an overlay
738 string. (Bug#10119)
8c535114 739
fa4fdb5c
JL
7402011-11-24 Juri Linkov <juri@jurta.org>
741
742 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
743 after the `MagickPingImage' call. (Bug#10112)
744
90ec88df
CY
7452011-11-23 Chong Yidong <cyd@gnu.org>
746
747 * window.c (Fcoordinates_in_window_p): Accept only live windows.
748
56e2e794
MR
7492011-11-23 Martin Rudalics <rudalics@gmx.at>
750
751 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
752 making another buffer current. (Bug#10114)
753
b6e64c41
GM
7542011-11-23 Glenn Morris <rgm@gnu.org>
755
756 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
757
6b21de18
CY
7582011-11-23 Chong Yidong <cyd@gnu.org>
759
760 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
761 using it (Bug#5984).
762
b12cd789
EZ
7632011-11-22 Eli Zaretskii <eliz@gnu.org>
764
765 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
766 and header-lines, as they don't have one computed for them.
767 (Bug#10098)
768
769 * .gdbinit (prow): Make displayed values more self-explaining.
770 Add row's hash code.
771
261b6fd4
LMI
7722011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
773
774 * process.c (wait_reading_process_output): Fix asynchrounous
775 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 776 (wait_reading_process_output): Add comment and URL.
261b6fd4 777
e7cfd277
JD
7782011-11-21 Jan Djärv <jan.h.d@swipnet.se>
779
780 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
781
a9b9b7f5
CY
7822011-11-21 Chong Yidong <cyd@gnu.org>
783
784 * window.c (Fnext_window, Fprevious_window): Doc fix.
785
b0d15b4f
SM
7862011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
787
788 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
789
fe7a3057
JB
7902011-11-20 Juanma Barranquero <lekktu@gmail.com>
791
792 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
793
d2999b1a
MR
7942011-11-20 Martin Rudalics <rudalics@gmx.at>
795
796 * window.c (Fset_window_combination_limit): Rename argument
797 STATUS to LIMIT.
798 (Vwindow_combination_limit): Remove "status" from doc-string.
799
d5ff9cd0
AS
8002011-11-20 Andreas Schwab <schwab@linux-m68k.org>
801
802 * m/ibms390.h: Remove.
803 * m/ibms390x.h: Don't include "ibms390.h".
804
a5bb9bd3
SM
8052011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
806
807 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
808 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
809
cd1181db
JB
8102011-11-20 Juanma Barranquero <lekktu@gmail.com>
811
812 * casetab.c (Fset_case_table):
813 * charset.c (Fcharset_after): Fix typos.
814
615a3b8d 8152011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 816
17e845af
PE
817 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
818 Otherwise, valgrind does not work on some platforms.
819 Problem reported by Andreas Schwab in
6a0bf43d
PE
820 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
821 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
822 is set, removing the need for VIRT_ADDRESS_VARIES.
823 (PURE_P): Use a more-efficient implementation that needs just one
824 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
825 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
826 to 4 (xorl, subq, cmpq, setbe).
827 * alloc.c (pure): Always extern now, since that's the
828 VIRT_ADDR_VARIES behavior.
829 (PURE_POINTER_P): Use a single comparison, not two, for
830 consistency with the new puresize.h.
831 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
832 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
833 Remove VIRT_ADDR_VARIES no longer needed.
834
f8fe6f96
EZ
8352011-11-19 Eli Zaretskii <eliz@gnu.org>
836
837 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
838 (erase_phys_cursor, update_window_cursor, show_mouse_face)
839 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
840 behave as if the cursor position were at the window margin.
841
842 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
843 and the cursor position is out of bounds, behave as if the cursor
844 position were at the window margin. (Bug#10075)
845
df05a53c
CY
8462011-11-18 Chong Yidong <cyd@gnu.org>
847
848 * window.c (Fwindow_combination_limit): Make first argument
849 non-optional, since it is meaningless for live windows like the
850 selected window.
851
2071918e
DA
8522011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
853
854 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
855
b50a28de
SM
8562011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
857
858 * intervals.c: Fix grafting over the whole buffer (bug#10071).
859 (graft_intervals_into_buffer): Simplify.
860
015137db
EZ
8612011-11-18 Eli Zaretskii <eliz@gnu.org>
862
863 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
864 hash values of the two rows.
865 (copy_row_except_pointers): Preserve the used[] arrays and the
866 hash values of the two rows. (Bug#10035)
68c95424 867 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
868
869 * xdisp.c (row_hash): New function, body extracted from
870 compute_line_metrics.
871 (compute_line_metrics): Call row_hash, instead of computing the
872 hash code inline.
873
874 * dispnew.c (verify_row_hash): Call row_hash for computing the
875 hash code of a row, instead of duplicating code from xdisp.c.
876
877 * dispextern.h (row_hash): Add prototype.
878
a2addb04
TH
8792011-11-18 Tassilo Horn <tassilo@member.fsf.org>
880
881 * frame.c (delete_frame): Don't delete the terminal when the last
882 X frame is closed if emacs is built with GTK toolkit.
883
df85d315
JB
8842011-11-17 Juanma Barranquero <lekktu@gmail.com>
885
886 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
887
a0c2d0ae
MR
8882011-11-17 Martin Rudalics <rudalics@gmx.at>
889
890 * window.c (Vwindow_splits): Rename to
891 Vwindow_combination_resize. Suggested by Juri Linkov.
892 (Fsplit_window_internal): Use Vwindow_combination_resize instead
893 of Vwindow_splits.
894
58179cce
JB
8952011-11-16 Juanma Barranquero <lekktu@gmail.com>
896
7877f373
JB
897 * nsfns.m (Fns_font_name):
898 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 899
b6f67890
MR
9002011-11-16 Martin Rudalics <rudalics@gmx.at>
901
902 * window.h (window): Rename slot "nest" to "combination_limit".
903 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
904 (Fset_window_nest): Rename to Fset_window_combination_limit.
905 (Vwindow_nest): Rename to Vwindow_combination_limit.
906 (recombine_windows, make_parent_window, make_window)
907 (Fsplit_window_internal, saved_window)
908 (Fset_window_configuration, save_window_save): Rename all
909 occurrences of window_nest to window_combination_limit.
910
c7015153
JB
9112011-11-15 Juanma Barranquero <lekktu@gmail.com>
912
913 * image.c (imagemagick_load_image): Fix typo.
914
322ad6ec
EZ
9152011-11-14 Eli Zaretskii <eliz@gnu.org>
916
917 * xdisp.c (display_line): Move the call to
918 highlight_trailing_whitespace before the call to
919 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
920 faces of all the glyphs to compute ROW's hash value.
921 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 922
f067b8ec
JB
9232011-11-14 Juanma Barranquero <lekktu@gmail.com>
924
925 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
926 just return (bug#10044).
927
1e5b2111
EZ
9282011-11-12 Eli Zaretskii <eliz@gnu.org>
929
7ef3cbd5
EZ
930 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
931 with user-defined heap size. Bump the default size of the temacs
932 heap to 27MB, to avoid memory warning when running temacs.
933 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
934
1e5b2111
EZ
935 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
936 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
937 (verify_row_hash) [XASSERTS]: New function.
938 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
939 that the hash value of glyph rows is correct.
1e5b2111 940
89d61221
MR
9412011-11-12 Martin Rudalics <rudalics@gmx.at>
942
943 * window.h (window): Remove splits slot.
944 * window.c (Fwindow_splits, Fset_window_splits): Remove.
945 (Fdelete_other_windows_internal, make_parent_window)
946 (make_window, Fsplit_window_internal, Fdelete_window_internal)
947 (Fset_window_configuration, save_window_save): Don't deal with
948 split status of windows.
949 (saved_window): Remove splits slot.
950 (Vwindow_splits): Rewrite doc-string.
951
97f18cc8
JD
9522011-11-11 Jan Djärv <jan.h.d@swipnet.se>
953
954 * xfns.c (unwind_create_frame):
955 * nsfns.m (unwind_create_frame):
956 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
957 Vframe_list (Bug#9999).
958
22a648b4
DA
9592011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
960
0b381c7e 961 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 962
659afede
KH
9632011-11-11 Kenichi Handa <handa@m17n.org>
964
965 * callproc.c (Fcall_process): Set the member dst_multibyte of
966 process_coding.
967
9ac0394b
KH
9682011-11-11 Johan Bockgård <bojohan@gnu.org>
969
970 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
971 avoid a crash (bug#9496).
972
2fbdc249
CY
9732011-11-09 Chong Yidong <cyd@gnu.org>
974
975 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
976 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
977
ac6b1f81
PE
9782011-11-08 Paul Eggert <eggert@cs.ucla.edu>
979
980 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
981
09db192c
PE
9822011-11-08 Paul Eggert <eggert@cs.ucla.edu>
983
984 Avoid some portability problems by eschewing 'extern inline' functions.
985 The trivial performance wins aren't worth the portability hassles; see
986 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
987 et seq.
988 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
989 (window_box_width, window_box_left, window_box_left_offset)
990 (window_box_right, window_box_right_offset): Undo previous change,
991 by removing the "extern"s.
992 * intervals.c (adjust_intervals_for_insertion)
993 (adjust_intervals_for_deletion): Undo previous change,
994 making these static again.
995 (offset_intervals, temp_set_point_both, temp_set_point)
996 (copy_intervals_to_string): No longer inline.
997 * xdisp.c (window_text_bottom_y, window_box_width)
998 (window_box_height, window_box_left_offset)
999 (window_box_right_offset, window_box_left, window_box_right)
1000 (window_box): No longer inline.
1001
105216ed
CY
10022011-11-08 Chong Yidong <cyd@gnu.org>
1003
1004 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1005 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1006 Signal an error if not a live window.
105216ed
CY
1007 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1008 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1009
ae9e237f
JB
10102011-11-07 Juanma Barranquero <lekktu@gmail.com>
1011
1012 * lisp.h (syms_of_abbrev): Remove declaration.
1013 Reported by CHENG Gao <chenggao@royau.me>.
1014
c7aa8333
EZ
10152011-11-07 Eli Zaretskii <eliz@gnu.org>
1016
1017 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1018 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1019 of temacs in GUI mode.
1020
be7f5545
MR
10212011-11-07 Martin Rudalics <rudalics@gmx.at>
1022
1023 * window.h: Declare delete_all_child_windows instead of
1024 delete_all_subwindows.
1025 * window.c (Fwindow_nest, Fset_window_nest)
1026 (Fset_window_new_total, Fset_window_new_normal)
1027 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1028 (delete_all_subwindows): Rename to delete_all_child_windows.
1029 (Fdelete_other_windows_internal, Fset_window_configuration):
1030 Call delete_all_child_windows instead of delete_all_subwindows.
1031 * frame.c (delete_frame): Call delete_all_child_windows instead
1032 of delete_all_subwindows.
1033
ca78dc43
PE
10342011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1035
1036 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1037 This is also needed for porting to any host where GC_MARK_STACK is
1038 not GC_MAKE_GCPROS_NOOPS.
1039 (which_symbols): Use it.
1040
a0241d01
KH
10412011-11-07 Kenichi Handa <handa@m17n.org>
1042
1043 * coding.c (coding_set_destination): Check coding->src_pos only
1044 when coding->src_object is a buffer (bug#9910).
1045
1046 * process.c (send_process): Set the member src_multibyte of coding
1047 to 0 (bug#9911) when sending a unibyte text.
1048
1049 * callproc.c (Fcall_process): Set the member src_multibyte of
1050 process_coding to 0 (bug#9912).
1051
a64bfdfa 10522011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1053
1054 * xmenu.c (cleanup_widget_value_tree): New function.
1055 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1056 calling free_menubar_widget_value_tree directly (Bug#9830).
1057
cb41b32a
PE
10582011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1059
1060 Fix some portability problems with 'inline'.
1061 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1062 (window_box_width, window_box_left, window_box_left_offset)
1063 (window_box_right, window_box_right_offset): Declare extern.
1064 Otherwise, these inline functions do not conform to C99 and
1065 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1066 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1067 * intervals.c (adjust_intervals_for_insertion)
1068 (adjust_intervals_for_deletion): Now extern, because otherwise the
1069 extern inline functions 'offset_intervals' couldn't refer to it.
1070 (static_offset_intervals): Remove.
1071 (offset_intervals): Rewrite using the old contents of
1072 static_offset_intervals. The old version didn't conform to C99
1073 because an extern inline function contained a reference to an
1074 identifier with static linkage.
1075
b7041366
AS
10762011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1077
1078 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1079 GC.
1080
88a37c4d
EZ
10812011-11-06 Eli Zaretskii <eliz@gnu.org>
1082
1083 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1084 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1085 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1086 return Qleft_to_right.
1087
49745b39
CY
10882011-11-06 Chong Yidong <cyd@gnu.org>
1089
1090 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1091 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1092 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1093 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1094 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1095 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1096 (Fwindow_vscroll): Doc fix.
1097 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1098 argument, since it makes no sense to pass a live window and for
1099 consistency with window-child.
1100
1f05cd82
CS
11012011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1102
1103 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1104 support MSVC.
1105
22610910
JR
11062011-11-05 Jason Rumney <jasonr@gnu.org>
1107
1108 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1109 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1110 fonts (Bug#6029).
1111 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1112 bitwise arithmetic preventing use of unicode-sip and non-truetype
1113 opentype fonts.
1114
a06776b2
EZ
11152011-11-05 Eli Zaretskii <eliz@gnu.org>
1116
3ad924ba
EZ
1117 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1118 "emacs"-only part.
1119
a06776b2
EZ
1120 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1121 initialization code to keep similarity to xfns.c after changes
1122 from 2011-11-05.
1123
c9e7db78
JD
11242011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1125
a97f8f3f
JD
1126 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1127 (unwind_create_frame): New function (Bug#9943).
1128 (Fx_create_frame): Restructure code to be more similar to the one in
1129 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1130 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1131 Move terminal->reference_count++ just before making the frame official
1132 (Bug#9943).
1133
1134 * nsterm.m (x_free_frame_resources): New function.
1135 (x_destroy_window): Move code to x_free_frame_resources.
1136
c9e7db78 1137 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1138 (Fx_create_frame, x_create_tip_frame):
1139 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1140 official. Move initialization of image_cache_refcount and
1141 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1142
a6fc3b5c
EZ
11432011-11-05 Eli Zaretskii <eliz@gnu.org>
1144
1145 Support MSVC build with newer versions of Visual Studio.
1146 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1147 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1148 nt/gmake.defs.
1149
1150 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1151 which are not supported by MSVC.
1152 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1153 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1154 bitfields.
1155 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1156 types in bitfields.
1157 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1158
1159 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1160
58179cce 11612011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1162
1163 Support MSVC build with newer versions of Visual Studio.
1164 * w32.c: Don't include w32api.h for MSVC.
1165 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1166
1167 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1168 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1169 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1170 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1171 e_* cousins.
1172 (alloca) [_MSC_VER]: Define to _alloca.
1173
1174 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1175
1176 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1177
a58c13ed
EZ
11782011-11-04 Eli Zaretskii <eliz@gnu.org>
1179
1180 * xdisp.c (note_mouse_highlight): If either of
1181 previous/next-single-property-change returns nil, treat that as
1182 the beginning or the end of the buffer. (Bug#9955)
1183
fe0b6370
JD
11842011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1185
a58c13ed 1186 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1187 label is not null (Bug#9951).
1188 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1189 may be NULL.
1190
89bd5ee1
EZ
11912011-11-04 Eli Zaretskii <eliz@gnu.org>
1192
1193 * window.c (Fwindow_body_size): Mention in the doc string that the
1194 return value is in frame's canonical units. (Bug#9949)
1195
84c3edb9
EZ
11962011-11-03 Eli Zaretskii <eliz@gnu.org>
1197
4e2fb5c7
EZ
1198 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1199
84c3edb9 1200 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1201 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1202 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1203
bc17a887
EZ
12042011-11-01 Eli Zaretskii <eliz@gnu.org>
1205
1206 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1207 Don't stop backward scan on the continuation glyph, even though
1208 its CHARPOS is positive.
6d5eb5b0
SM
1209 (mouse_face_from_buffer_pos, note_mouse_highlight):
1210 Rename cover_string to disp_string.
bc17a887 1211
4ee88440
MR
12122011-11-01 Martin Rudalics <rudalics@gmx.at>
1213
1214 * window.c (temp_output_buffer_show): Don't use
1215 Vtemp_buffer_show_specifiers.
1216 (Vtemp_buffer_show_specifiers): Remove unused variable.
1217
c2ff3c02
EZ
12182011-10-30 Eli Zaretskii <eliz@gnu.org>
1219
1220 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1221 past the beginning of the current glyph matrix.
1222
58179cce 12232011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1224
1225 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1226 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1227 HAVE_GTK3 (Bug#9869).
b77a6a7f 1228
3b574623
JD
1229 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1230 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1231
b77a6a7f
JD
1232 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1233
1234 * xterm.c: Declare x_handle_net_wm_state to return int.
1235 (handle_one_xevent): Check if we are iconified but don't have
1236 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1237 (get_current_wm_state): Return non-zero if not hidden,
1238 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1239 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1240 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1241 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1242
196e41e4
PE
12432011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1244
1245 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1246 so that this new function doesn't get optimized away by a
1247 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1248
021f2e1a
AS
12492011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1250
1251 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1252
8b058d44
EZ
12532011-10-29 Eli Zaretskii <eliz@gnu.org>
1254
1255 Fix the `xbytecode' command.
1256 * .gdbinit (xprintbytestr): New command.
b50a28de 1257 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1258 (xbytecode): Print the byte-code string as well.
1259
4452fb80
EZ
12602011-10-29 Kim Storm <storm@cua.dk>
1261
8b058d44
EZ
1262 * alloc.c (which_symbols): New function.
1263
21b72067
AS
12642011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1265
1266 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1267 line. (Bug#9903)
1268
83ed7b5c
GM
12692011-10-29 Glenn Morris <rgm@gnu.org>
1270
1271 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1272 Not clear what it was for, and it causes various bugs. (Bug#9839)
1273
5a7a728b
EZ
12742011-10-28 Eli Zaretskii <eliz@gnu.org>
1275
1276 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1277 possible random value that matches one of those tested as
1278 condition to clear the mouse face.
1279
d3d0842f
CY
12802011-10-28 Chong Yidong <cyd@gnu.org>
1281
1282 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1283
31b39d13
DN
12842011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1285
1286 * window.c (make_window): Initialize phys_cursor_on_p.
1287
9aba6043
SM
12882011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1289
1290 * lisp.h (struct Lisp_Symbol): Update comments.
1291
c20992f4
JB
12922011-10-28 Juanma Barranquero <lekktu@gmail.com>
1293
1294 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1295
db4f02f2
EZ
12962011-10-28 Eli Zaretskii <eliz@gnu.org>
1297
1298 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1299 <oslsachem@gmail.com> for helping to debug this.
1300
1301 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1302 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1303 (g_b_init_get_glyph_outline_w): New static variables.
1304 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1305 (GetGlyphOutlineW_Proc): New typedefs.
1306 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1307 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1308 New functions.
1309 (w32font_open_internal, compute_metrics):
1310 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1311 instead of calling the "wide" APIs directly.
1312
1313 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1314
1315 * w32.h (syms_of_w32font): Add prototype.
1316
87e68db4
JB
13172011-10-27 Juanma Barranquero <lekktu@gmail.com>
1318
1319 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1320 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1321 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1322 (Fmove_to_window_line): Doc fix.
1323
435c1d67
CY
13242011-10-27 Chong Yidong <cyd@gnu.org>
1325
1326 * process.c (make_process): Set gnutls_state to NULL.
1327
1328 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1329 non-NULL, regardless of GNUTLS_INITSTAGE.
1330 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1331 an error. Set process slots as soon as we allocate them.
1332
1333 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1334
9c6c6f49
CY
13352011-10-27 Chong Yidong <cyd@gnu.org>
1336
9aba6043
SM
1337 * gnutls.c (emacs_gnutls_deinit): New function.
1338 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1339 (Fgnutls_deinit, Fgnutls_boot): Use it.
1340
1341 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1342 (deactivate_process): Call emacs_gnutls_deinit.
1343
657d08d3
JB
13442011-10-27 Juanma Barranquero <lekktu@gmail.com>
1345
1346 * image.c (x_create_x_image_and_pixmap):
1347 * w32.c (sys_rename, w32_delayed_load):
1348 * w32font.c (fill_in_logfont):
1349 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1350
5430d399
JB
13512011-10-26 Juanma Barranquero <lekktu@gmail.com>
1352
1353 * w32fns.c (w32_default_color_map): New function,
1354 extracted from Fw32_default_color_map.
a7ef684b 1355 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1356
fe0055fa
PE
13572011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1358
1359 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1360
e6346438
SM
13612011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1362
1363 * keyboard.c (test_undefined): New function (bug#9751).
1364 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1365
e112cc37
ET
13662011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1367
1368 * sysdep.c (init_sys_modes): Fix the check for the controlling
1369 terminal (Bug#6649).
1370
7b5d6677
EZ
13712011-10-20 Eli Zaretskii <eliz@gnu.org>
1372
1373 * dispextern.h (struct bidi_it): New member next_en_type.
1374
1375 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1376 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1377 current character, check also for next_en_type being WEAK_EN.
1378 (bidi_resolve_weak): Don't enter the expensive loop if the current
1379 position is before next_en_pos. Record the bidi type of the first
1380 non-ET, non-BN character we find, in addition to its position.
1381 (bidi_level_of_next_char): Invalidate next_en_type when
1382 next_en_pos is over-stepped.
1383
7da0b018
PE
13842011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1385
1386 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1387 * editfns.c: Rewrite current-time-zone so that it invokes
1388 the equivalent of (format-time-string "%Z") to get the time zone name.
1389 This fixes a bug when the time zone name contains characters that
1390 need converting from the system time locale to Emacs internal format.
1391 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1392 that patch fixed format-time-string to do the conversion, but
1393 I forgot to fix current-time-zone.
1394 (format_time_string): New function, containing most of
1395 what Fformat_time_string used to contain.
1396 (Fformat_time_string): Rewrite in terms of format_time_string.
1397 This doesn't change this function's behavior.
1398 (current-time-zone): Rewrite to use format_time_string.
1399 This fixes the bug reported by Michael Schierl in
1400 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1401 Jason Rumney's 2007-06-07 change worked around this bug, but
1402 didn't fix it.
1403 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1404
8547b010
EZ
14052011-10-19 Eli Zaretskii <eliz@gnu.org>
1406
1407 * xdisp.c (start_display): If the character at POS is displayed
1408 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1409 (try_window_reusing_current_matrix): If a line ends in a display
1410 vector or the next line starts in a display vector, continue
1411 redrawing the window even though the character position of
1412 start_row was reached.
8547b010
EZ
1413 (Bug#9771, part 2)
1414
4e948d15
CY
14152011-10-18 Chong Yidong <cyd@gnu.org>
1416
1417 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1418 with nobreak-char-display too.
1419
4787455f
EZ
14202011-10-18 Eli Zaretskii <eliz@gnu.org>
1421
1422 Fix part 3 of bug#9771.
1423 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1424 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1425 non-neutral characters if the current character is a paragraph
1426 separator (a.k.a. Newline). This avoids running the same
1427 expensive loop twice, once when we consume the preceding newline
1428 and the other time when the line actually needs to be displayed.
1429 Avoid the loop when we see neutrals on the base embedding level
1430 following a character whose directionality is the same as the
1431 paragraph's. This avoids running the expensive loop when a line
1432 ends in a long sequence of neutrals, like control characters.
1433 Add assertion against STRONG_AL type. Slightly rearrange code
1434 that determines the type of a neutral given the first non-neutral
1435 that follows it.
1436 (bidi_level_of_next_char): Set next_en_pos to zero when
1437 invalidating its info.
1438
2c91f553
EZ
14392011-10-17 Eli Zaretskii <eliz@gnu.org>
1440
1441 * xdisp.c (push_display_prop): Determine whether to record string
1442 or buffer position by IT->string, not by IT->method. Allow
1443 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1444 (move_it_vertically_backward): Don't look for character position
1445 immediately after the newline when in a continuation line.
1446 (Bug#9771, part 1)
2c91f553 1447
c7b08b0d
MR
14482011-10-15 Martin Rudalics <rudalics@gmx.at>
1449
1450 * window.c (coordinates_in_window): Rewrite and delabelize
1451 vertical border check. (Bug#5357) (Bug#9618)
1452
6b02f655
SM
14532011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1454
1455 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1456 errors in XSetWindowBorder (bug#9310).
1457
81d40c92
DA
14582011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1459
1460 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1461 avoid crash when xmalloc overrun checking is enabled.
1462
d4172c3b
EZ
14632011-10-13 Eli Zaretskii <eliz@gnu.org>
1464
1465 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1466 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1467 cursor motion with <left> and <right> arrow keys.
1468
1469 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1470 some callers set that themselves.
1471
b00eea75
EZ
14722011-10-12 Eli Zaretskii <eliz@gnu.org>
1473
1474 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1475 display string and the previous row comes from the same string and
1476 is empty. (Bug#9739) (Bug#9738)
1477
8fe012c4
SM
14782011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1479
1480 * doc.c (get_doc_string): Encode file name (bug#9735).
1481
0074aef2
EZ
14822011-10-12 Eli Zaretskii <eliz@gnu.org>
1483
79beb178
EZ
1484 * bidi.c (bidi_level_of_next_char):
1485 * xdisp.c (get_visually_first_element): Remove old incorrect
1486 comments regarding the Unicode Line Separator character.
1487
0074aef2
EZ
1488 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1489
6e4b3fbe
DA
14902011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1491
1492 * alloc.c (Fgc_status): Do not access beyond zombies array
1493 boundary if nzombies > MAX_ZOMBIES.
1494 * alloc.c (dump_zombies): Add missing format specifier.
1495
0324f3af
PE
14962011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1497
b5525cac
PE
1498 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1499 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1500
0324f3af
PE
1501 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1502 Some packages use them to denote characters with modifiers.
1503
e9b5f888
AS
15042011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1505
1506 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1507 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1508 matching a pp-number. Rename parameter var to var1.
1509
127827c0
SM
15102011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1511
1512 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1513
c8fd3bd0
GM
15142011-10-08 Glenn Morris <rgm@gnu.org>
1515
1516 * callint.c (Fcall_interactively): Give a more explicit error for the
1517 'c' case with a non-character input. (Bug#8479)
1518
352ec8ff
EZ
15192011-10-08 Eli Zaretskii <eliz@gnu.org>
1520
03669ccb
EZ
1521 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1522 lines.
7061c986
EZ
1523 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1524 lines that are hscrolled on the left.
03669ccb 1525
352ec8ff
EZ
1526 * dispnew.c (buffer_posn_from_coords): Account for a possible
1527 presence of header-line. (Bug#4426)
1528
a66cfb1c
SM
15292011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1530
6b02f655
SM
1531 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1532 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1533
7c5ee88e
PE
15342011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1535
1536 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1537 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1538 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1539 this makes Emacs dump core during garbage collection on rare
1540 occasions. sizeof is obviously inferior to offsetof here, so
1541 stick with offsetof.
1542 (GC_POINTER_ALIGNMENT): New macro.
1543 (mark_memory): Omit 3rd (offset) arg; caller changed.
1544 Don't assume EMACS_INT alignment is the same as pointer alignment.
1545
df1bbe5b
SM
15462011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1547
1548 * keyboard.c (read_key_sequence_remapped): New var.
1549 (read_key_sequence): Compute remapping in the right buffer.
1550 (command_loop_1): Use read_key_sequence's remapping directly.
1551
51553db6
SM
15522011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1553
32c1fffd
SM
1554 * dired.c (file_name_completion): Don't expand file name.
1555 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1556 before checking file name handler.
1557
51553db6
SM
1558 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1559 they've been requested explicitly (bug#9591).
1560
b6bd1599 15612011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1562
1563 * keymap.c (Fsingle_key_description): Use make_specified_string
1564 instead of build_string to build string from push_key_description.
1565 (Bug#5193)
1566
f701dc2a
PE
15672011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1568
4222c55d
PE
1569 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1570 This fixes a Y2038 bug on 64-bit hosts.
1571 * buffer.c (reset_buffer):
1572 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1573 (Fclear_buffer_auto_save_failure):
1574 Use 0, not -1, to represent an unset failure time, since time_t
1575 might not be signed.
1576
f701dc2a
PE
1577 Remove dependency on glibc malloc internals.
1578 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1579 Move back here from lisp.h, but with their new implementations.
1580 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1581 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1582 * charset.c (charset_table_init): New static var.
1583 (syms_of_charset): Use it instead of xmalloc. This removes a
1584 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1585 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1586 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1587 Move back to alloc.c.
1588 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1589 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1590
9ceebf39
JD
15912011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1592
1593 * nsterm.m (windowDidResize): Call x_set_window_size only when
1594 ns_in_resize is true. Otherwise set pixelwidth/height and
1595 call change_frame_size (Bug#9628).
1596
cb993c58
PE
15972011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1598
3930c88b
PE
1599 Port --enable-checking=all to Fedora 14 x86-64.
1600 * charset.c (syms_of_charset): Also account for glibc malloc's
1601 internal overhead when calculating the initial malloc maximum.
1602
cb993c58
PE
1603 Port --enable-checking=all to Fedora 14 x86.
1604 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1605 Move to lisp.h.
1606 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1607 (overrun_check_realloc, overrun_check_free):
1608 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1609 That way, xmalloc returns a properly-aligned pointer even if
1610 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1611 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1612 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1613 into account when calculating the initial malloc maximum.
1614 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1615 Move here from alloc.c, so that charset.c can use it too.
1616 Properly align; the old code wasn't right for common 32-bit hosts
1617 when configured with --enable-checking=all.
1618 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1619 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1620
31bed486
EZ
16212011-09-29 Eli Zaretskii <eliz@gnu.org>
1622
04c70788 1623 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1624 use EDOM.
1625
fbcaa2f3
EZ
16262011-09-28 Eli Zaretskii <eliz@gnu.org>
1627
1628 * xdisp.c (compute_display_string_end): If there's no display
1629 string at CHARPOS, return -1.
1630
1631 * bidi.c (bidi_fetch_char): When compute_display_string_end
1632 returns a negative value, treat the character as a normal
1633 character not covered by a display string. (Bug#9624)
1634
a239d4e9
JB
16352011-09-28 Juanma Barranquero <lekktu@gmail.com>
1636
1637 * lread.c (Fread_from_string): Fix typo in docstring.
1638
88652fd5
EZ
16392011-09-27 Eli Zaretskii <eliz@gnu.org>
1640
1641 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1642 newline, reseat the iterator instead of bidi-iterating there one
1643 character at a time. (Bug#9610)
32c1fffd
SM
1644 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1645 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1646
ed497dd4
AS
16472011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1648
1649 * lread.c (readevalloop): Use correct code for NBSP.
1650 (read1): Likewise. (Bug#9608)
1651
b2bf61aa
MA
16522011-09-25 Michael Albinus <michael.albinus@gmx.de>
1653
1654 * dbusbind.c (Fdbus_register_signal): When service is not
1655 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1656
32bbb17c
GM
16572011-09-25 Glenn Morris <rgm@gnu.org>
1658
1659 * buffer.c (truncate-lines): Doc fix.
1660
94e0933e
CY
16612011-09-24 Chong Yidong <cyd@stupidchicken.com>
1662
1663 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1664 (Fset_window_next_buffers): Doc fix.
1665
cddde921
GM
16662011-09-24 Glenn Morris <rgm@gnu.org>
1667
1668 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1669
1260aef1
PE
16702011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1671
25b4bfa0
PE
1672 Fix minor problems found by static checking.
1673 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1674 * indent.c (Fvertical_motion): Fix == vs = typo.
1675
e3cbd34b
EZ
16762011-09-24 Eli Zaretskii <eliz@gnu.org>
1677
a66cfb1c
SM
1678 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1679 Default value is now t. Doc fix.
6bf7006f 1680
e3cbd34b 1681 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1682 logic when moving up, not only when moving down. Fix the
e3cbd34b 1683 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1684 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1685
1686 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1687 CHARPOS is covered by a display string which includes newlines.
1688 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1689 is covered by a display string with embedded newlines.
1690
a3de0cbd
MA
16912011-09-24 Michael Albinus <michael.albinus@gmx.de>
1692
1693 * dbusbind.c (Fdbus_register_signal): Add match rule to
1694 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1695 (Fdbus_register_method, Vdbus_registered_objects_table):
1696 Fix docstring.
a3de0cbd 1697
b260039d
JM
16982011-09-24 Jim Meyering <meyering@redhat.com>
1699
32c1fffd 1700 do not ignore write error for any output size
b260039d
JM
1701 The previous change was incomplete.
1702 While it makes emacs --batch detect the vast majority of stdout
1703 write failures, errors were still ignored whenever the output size is
1704 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1705 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1706 && echo FAIL: ignored write error
1707 FAIL: ignored write error
1708 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1709 && echo FAIL: ignored write error
1710 FAIL: ignored write error
1711 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1712
8eca8a7c
AS
17132011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1714
1715 * emacs.c (Fkill_emacs): In noninteractive mode exit
1716 non-successfully if a write error occurred on stdout. (Bug#9574)
1717
3341db62
EZ
17182011-09-21 Eli Zaretskii <eliz@gnu.org>
1719
1720 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1721 the xassert test.
1722
1723 * dispextern.h (struct it): Update the comment documenting what
1724 can it->OBJECT be.
1725
8c203dbf
EZ
17262011-09-20 Eli Zaretskii <eliz@gnu.org>
1727
1728 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1729 a display string, extend search for cursor position to end of row.
1730 (find_row_edges): If the row ends in a newline from a display
1731 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1732 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1733 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1734 non-empty line. Fixes confusing cursor motion with arrow keys at
1735 the beginning of a line that starts with whitespace.
8c203dbf 1736
a4824228
LMI
17372011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1738
1739 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1740 (bug#9493).
1741
33ed493b
CY
17422011-09-18 Chong Yidong <cyd@stupidchicken.com>
1743
1744 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1745 boolean (Bug#9154).
1746
56cd55c8
EZ
17472011-09-18 Eli Zaretskii <eliz@gnu.org>
1748
1749 * xdisp.c (display_line): Record maximum and minimum buffer
1750 positions even if no glyphs were produced (e.g., by a zero-width
1751 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1752 buffer positions that will be removed from the glyph row because
1753 they don't fit.
c02dcedf
EZ
1754 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1755 column is beyond frame width: don't subtract 1 "pixel" when
1756 computing width of the stretch.
3e62b7e0
EZ
1757 (reseat_at_next_visible_line_start): Undo the change made on
1758 2011-09-17 that saved paragraph information and restored it after
1759 the call to `reseat'. (Bug#9545)
56cd55c8 1760
5ed99d36 17612011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1762
1763 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1764 and turn window cursor on if cleared (Bug#9415).
1765
5ed99d36 17662011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1767
1768 * search.c (boyer_moore): Take unibyte characters from pattern
1769 literally. (Bug#9458)
1770
9bade7b2
EZ
17712011-09-18 Eli Zaretskii <eliz@gnu.org>
1772
1773 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1774
e5e9d610
PE
17752011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1776
87e4427a
PE
1777 Fix minor problem found by static checking.
1778 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1779 initialized, to pacify gcc -Wuninitialized.
1780
e5e9d610
PE
1781 * fileio.c: Report proper errno when syscall falls.
1782 (Finsert_file_contents): Save and restore errno,
1783 so that report_file_error outputs the correct diagnostic.
1784 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1785
a1674f0b
EZ
17862011-09-18 Eli Zaretskii <eliz@gnu.org>
1787
1788 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1789
fbfb6dd4
EZ
17902011-09-17 Eli Zaretskii <eliz@gnu.org>
1791
1792 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1793 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1794
bb187662
EZ
17952011-09-17 Eli Zaretskii <eliz@gnu.org>
1796
1137e8b8 1797 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1798 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1799
1800 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1801 (bidi_find_paragraph_start): Search back for paragraph beginning
1802 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1803 (bidi_move_to_visually_next): Only trigger paragraph-related
1804 computations when the last character is a newline or at EOB, not
1805 just any NEUTRAL_B. (Bug#9470)
1806
bb187662
EZ
1807 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1808 truncated lines if point is covered by a display string. (Bug#9524)
1809
2e621251
PE
18102011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1811
1812 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1813 (cons_to_x_long): New function.
1814 (lisp_data_to_selection_data): Use it. Correct the test for
1815 short-versus-long data; it was negated. Break out of vector
1816 loop, for efficiency, when a long datum is discovered.
1817
91a15bc6
SM
18182011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1819
1820 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1821
b41c3a35
EZ
18222011-09-16 Eli Zaretskii <eliz@gnu.org>
1823
1824 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1825 GCC PR/17406) by declaring this function with external scope.
1826
7812ba2d
PE
18272011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1828
1829 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1830 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1831
cf7edc2a
AS
18322011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1833
1834 * editfns.c (Fformat): Correctly handle text properties on "%%".
1835
bd01620e
EZ
18362011-09-15 Eli Zaretskii <eliz@gnu.org>
1837
1838 * xterm.c (x_draw_composite_glyph_string_foreground):
1839 * w32term.c (x_draw_composite_glyph_string_foreground):
1840 * term.c (encode_terminal_code):
1841 * composite.c (composition_update_it, get_composition_id):
1842 * xdisp.c (get_next_display_element)
1843 (fill_composite_glyph_string): Add comments about special meaning
1844 of TAB characters in a composition.
1845
a02719a3
PE
18462011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1847
1848 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1849 This occurs when processing a multibyte format.
1850 Problem reported by Wolfgang Jenker.
a02719a3 1851
72589a3c
JB
18522011-09-15 Johan Bockgård <bojohan@gnu.org>
1853
1854 * xdisp.c (try_cursor_movement): Only check for exact match if
1855 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1856
1c14176c
PE
18572011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1858
1859 Remove unused external symbols.
1860 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1861 * xdisp.c (calc_pixel_width_or_height): Now static.
1862 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1863 * indent.c (check_display_width):
1864 * w32term.c: Fix comment to match code.
1865 * xterm.c, xterm.h (x_catching_errors): Remove.
1866
d2eea5b5
PE
18672011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1868
1869 * xselect.c: Use signed conversions more consistently (Bug#9498).
1870 (selection_data_to_lisp_data): Assume incoming selection data are
1871 signed integers, not unsigned. This is to be consistent with
1872 outgoing selection data, which was modified to use signed integers
1873 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1874 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1875 expects long, not unsigned long.
1876
46888499
EZ
18772011-09-14 Eli Zaretskii <eliz@gnu.org>
1878
1879 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1880 computation of loop end. Reported by Johan Bockgård
1881 <bojohan@gnu.org>.
1882
ef8ef9fb
CY
18832011-09-13 Chong Yidong <cyd@stupidchicken.com>
1884
1885 * frame.c (Fother_visible_frames_p): Function deleted.
1886
fa819fed
EZ
18872011-09-12 Eli Zaretskii <eliz@gnu.org>
1888
1889 * indent.c (compute_motion): Process display vector front to back
1890 rather than the other way around. (Bug#2496)
1891
2ba8e008
SM
18922011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1893
1894 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1895
20f53c69
CY
18962011-09-11 Chong Yidong <cyd@stupidchicken.com>
1897
1898 * minibuf.c (Fread_from_minibuffer): Doc fix.
1899
d562d7a4
EZ
19002011-09-11 Eli Zaretskii <eliz@gnu.org>
1901
1902 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1903 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1904
1c4d7f3d
LMI
19052011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1906
1907 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1908 value for non-existent files.
1909
b885bf36
EZ
19102011-09-11 Eli Zaretskii <eliz@gnu.org>
1911
1912 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1913 set its "size" to -1. This will set the modtime_size field of
1914 the corresponding buffer to -1, which is what
1915 verify-visited-file-modtime expects for files that do not exist.
1916 (Bug#9139)
1917
6612f0bf
PE
19182011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1919
1920 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1921 here ...
1922 * lisp.h: ... from here. push_key_description is no longer
1923 defined in keyboard.c, so its declaration should not be in
1924 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1925 logically belongs with push_key_description.
1926
dfb3f755
PE
19272011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1928
1929 * buffer.h: Include <sys/types.h> instead of <time.h>.
1930 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1931 Problem reported by Herbert J. Skuhra.
1932
3134906c
LMI
19332011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1934
1935 * xml.c (parse_region): Make the parsing work for
1936 non-comment-starting XML files again (bug#9144).
1937
8d903f4e
AS
19382011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1939
1940 * image.c (gif_load): Fix calculation of bottom and right corner.
1941 (Bug#9468)
1942
80ad64f4
EZ
19432011-09-10 Eli Zaretskii <eliz@gnu.org>
1944
1945 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1946 redisplay in small windows.
1947
208a048d
EZ
19482011-09-09 Eli Zaretskii <eliz@gnu.org>
1949
1950 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1951
9b1c252e
MR
19522011-09-08 Martin Rudalics <rudalics@gmx.at>
1953
1954 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1955 Operate on live windows only.
1956
2949f33b
JB
19572011-09-08 Juanma Barranquero <lekktu@gmail.com>
1958
1959 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1960
e08dcafd
EZ
19612011-09-07 Eli Zaretskii <eliz@gnu.org>
1962
1963 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1964 only under bidi iteration.
1965
115b96bd
JD
19662011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1967
1968 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1969
c8199d0f
PE
19702011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1971
1972 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1973 Without this fix, the command to link temacs failed due to an
1974 undefined symbol __builtin_isnan. This is because
1975 /usr/include/iso/math_c99.h #defines isnan(x) to
1976 __builtin_isnan(x), but the bundled gcc, which identifies itself
1977 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1978 a __builtin_isnan.
1979 * floatfns.c (isnan): #undef, and then #define to a clone of
1980 what's in data.c.
1981 (Fisnan): Always define, since it's always available now.
1982 (syms_of_floatfns): Always define isnan at the Lisp level.
1983
e39b275c 19842011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1985
1986 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1987
b2db44d9 19882011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1989
f4af5137 1990 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1991 The previous code assumed that file offsets (off_t values) fit in
1992 EMACS_INT variables, which is not true on typical 32-bit hosts.
1993 The code messed up by falsely reporting buffer overflow in cases
1994 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1995 when "big" contains more than 2**29 bytes, even though this
1996 inserts just one byte and does not overflow the buffer.
1997 (Finsert_file_contents): Store file offsets as off_t
1998 values, not as EMACS_INT values. Check for overflow when
1999 converting between EMACS_INT and off_t. When checking for
2000 buffer overflow or for overlap, take the offsets into account.
2001 Don't use EMACS_INT for small values where int suffices.
2002 When checking for overlap, fix a typo: ZV was used where
2003 ZV_BYTE was intended.
2004 (Fwrite_region): Don't assume off_t fits into 'long'.
2005 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2006
ecfc0a49
MA
20072011-09-05 Michael Albinus <michael.albinus@gmx.de>
2008
2009 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2010
6511acf2 20112011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2012
0999621a 2013 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2014
2015 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2016 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2017 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2018 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2019 (modify_event_symbol): Do not assume that the length of
2020 name_alist_or_stem is safe to alloca and fits in int.
2021 (Fexecute_extended_command): Likewise for function name and binding.
2022 (Frecursion_depth): Wrap around reliably on integer overflow.
2023 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2024 since some callers pass EMACS_INT values.
2025 (Fsingle_key_description): Don't crash if symbol name contains more
2026 than MAX_ALLOCA bytes.
2027 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2028 (get_minibuffer): Arg is now EMACS_INT, not int.
2029 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2030 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2031 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2032
2be7d702
PE
2033 * dbusbind.c (signature_cat): New function.
2034 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2035 Do not overrun buffer; instead, report string overflow.
2036
9d1df220
PE
2037 * dispnew.c (add_window_display_history): Don't overrun buffer.
2038 Truncate instead; this is OK since it's just a log.
2039
33ef5c64
PE
2040 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2041 even if the time zone offset is outlandishly large.
2042 Don't mishandle offset == INT_MIN.
2043
66c6fdd5
PE
2044 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2045 when creating daemon; the previous buffer-overflow check was incorrect.
2046
d749b01b
PE
2047 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2048 which has the guts of the old verror function.
2049
b5cd1905
PE
2050 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2051 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2052
6e1a67fb
PE
2053 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2054 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2055 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2056 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2057 length of string rather than counting it via multiple sprintfs;
2058 that's simpler and more reliable.
c21721cc
PE
2059 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2060 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2061 sprintf, in case result does not fit in int.
2062
c57b67fc
PE
2063 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2064 (fontset_from_font): Print it.
2065
8a401434
PE
2066 * frame.c (tty_frame_count): Now printmax_t, not int.
2067 (make_terminal_frame, set_term_frame_name): Print it.
2068 (x_report_frame_params): In X, window IDs are unsigned long,
2069 not signed long, so print them as unsigned.
2070 (validate_x_resource_name): Check for implausibly long names,
2071 and don't assume name length fits in 'int'.
2072 (x_get_resource_string): Don't blindly alloca invocation name;
2073 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2074 not fit in int.
2075
6e1a67fb
PE
2076 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2077 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2078 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2079
0df02bf3
PE
2080 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2081 Use esprintf, not sprintf, in case result does not fit in int.
2082
48e30793
PE
2083 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2084 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2085 it as a large positive number.
2086 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2087 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2088
a66ff6d8
PE
2089 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2090 in case result does not fit in int.
2091
aca216ff
PE
2092 * print.c (float_to_string): Detect width overflow more reliably.
2093 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2094 buffer overrun. Don't assume list length fits in 'int'. Treat
2095 print length of 0 as 0, not as infinity; to be consistent with other
2096 uses of print length in this function. Don't overflow print length
2097 index. Don't assume hash table size fits in 'long', or that
2098 vectorlike size fits in 'unsigned long'.
2099
31c286f7
PE
2100 * process.c (make_process): Use printmax_t, not int, to format
2101 process-name gensyms.
2102
55e5faa1
PE
2103 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2104
80f2e268
PE
2105 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2106 to avoid potential buffer overrun.
2107
670741ab
PE
2108 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2109 if X resource line is longer than 512 bytes.
2110
b7163a50
PE
2111 * xfns.c (x_window): Make sprintf buffer a bit bigger
2112 to avoid potential buffer overrun.
2113
ae58ff1f
PE
2114 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2115
c43c8a6a
PE
2116 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2117
3f8236f4
PE
21182011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2119
53e9fe90 2120 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2121 Without these, Emacs silently mishandles large integers sometimes.
2122 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2123 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2124
6511acf2
PE
2125 * xdisp.c (try_window_id): Check Emacs fixnum range before
2126 converting to 'int'.
806add1d 2127
6511acf2 2128 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2129 Check that an Emacs fixnum is in range before assigning it to 'int'.
2130 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2131 values converted from Emacs fixnums.
2132 (Frecenter): Don't wrap around a line count if it is out of 'int'
2133 range; instead, treat it as an extreme value.
2134 (Fset_window_configuration, compare_window_configurations):
2135 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2136
6511acf2
PE
2137 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2138 that can exceed INT_MAX. Check that EMACS_INT value is in range
2139 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2140 (match_limit): Don't assume that a fixnum can fit in 'int'.
2141
6511acf2 2142 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2143 exceed INT_MAX.
2144
6511acf2 2145 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2146 (Fvertical_motion): Don't wrap around LINES values that don't fit
2147 in 'int'. Instead, treat them as extreme values. This is good
2148 enough for windows, which can't have more than INT_MAX lines anyway.
2149
fcb901a7
LMI
21502011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2151
0f2f6b6d
LMI
2152 * Require libxml/parser.h to avoid compilation warning.
2153
fcb901a7
LMI
2154 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2155
2156 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2157 since this reportedly can destroy thread storage.
2158
6e20a0d4
CY
21592011-08-30 Chong Yidong <cyd@stupidchicken.com>
2160
2161 * syntax.c (find_defun_start): Update all cache variables if
2162 exiting early (Bug#9401).
2163
148ae00e
EZ
21642011-08-30 Eli Zaretskii <eliz@gnu.org>
2165
f6cfbd8f
EZ
2166 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2167
148ae00e
EZ
2168 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2169 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2170 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2171
2172 * term.c (tty_append_glyph): New function.
2173 (produce_stretch_glyph): Static function and its prototype deleted.
2174
a66cfb1c
SM
2175 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2176 Add prototypes.
148ae00e 2177
c4a07a4c
PE
21782011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2179
2180 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2181 when checking :margin (Bug#9390).
2182 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2183 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2184 so that the name doesn't mislead. All uses changed.
2185
6bc8cd65
JB
21862011-08-28 Johan Bockgård <bojohan@gnu.org>
2187
2188 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2189 set_tty_hooks.
2190
dca4927e
EZ
21912011-08-27 Eli Zaretskii <eliz@gnu.org>
2192
2193 * xdisp.c (move_it_to): Don't bail out early when reaching
2194 position beyond to_charpos, if we are scanning backwards.
2195 (move_it_vertically_backward): When DY == 0, make sure we get to
2196 the first character in the line after the newline.
2197
f2cad773
PE
21982011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2199
2200 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2201 (ccl_driver): Do not generate an out-of-range pointer.
2202 (Fccl_execute_on_string): Remove unnecessary check for
2203 integer overflow, noted by Stefan Monnier in
2204 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2205 Remove a FIXME that didn't need fixing.
2206 Simplify the newly-introduced buffer reallocation code.
2207
0cae2cdb
JB
22082011-08-27 Juanma Barranquero <lekktu@gmail.com>
2209
2210 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2211
5fc295a4 22122011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2213
70c60eb2 2214 Integer and memory overflow issues (Bug#9196).
726e0ab1 2215
d31850da
PE
2216 * doc.c (get_doc_string): Rework so that
2217 get_doc_string_buffer_size is the actual buffer size, rather than
2218 being 1 less than the actual buffer size; this makes xpalloc more
2219 convenient.
2220
a69fbedb
PE
2221 * image.c (x_allocate_bitmap_record, cache_image):
2222 * xselect.c (Fx_register_dnd_atom):
2223 Simplify previous changes by using xpalloc.
2224
fe5c5d37
PE
2225 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2226 since either will do and ptrdiff_t is convenient with xpalloc.
2227
0065d054
PE
2228 * charset.c (charset_table_size)
2229 (struct charset_sort_data.priority): Now ptrdiff_t.
2230 (charset_compare): Don't overflow if priorities differ greatly.
2231 (Fsort_charsets): Don't assume list length fits in int.
2232 Check for size-calculation overflow when allocating sort data.
2233 (syms_of_charset): Allocate an initial charset table that is
2234 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2235
2236 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2237
2238 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2239 The actual value is always <= INT_MAX, and leaving it unsigned made
2240 overflow checking harder.
2241
2242 * dispextern.h (struct glyph_matrix.rows_allocated)
2243 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2244 with xpalloc. The values are still always <= INT_MAX.
2245
2246 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2247
2248 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2249 (SAFE_NALLOCA): New macro.
2250
2251 * region-cache.c (struct boundary.pos, find_cache_boundary)
2252 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2253 (set_cache_region, invalidate_region_cache)
2254 (revalidate_region_cache, know_region_cache, region_cache_forward)
2255 (region_cache_backward, pp_cache):
2256 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2257 so that ptrdiff_t * can be passed to xpalloc.
2258 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2259 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2260 (pp_cache): Don't assume cache_len fits in int.
2261 * region-cache.h: Adjust extern decls to match.
2262
2263 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2264 EMACS_INT, since either will do, for xpalloc.
2265
2266 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2267 (xnmalloc, xnrealloc, xpalloc): New functions.
2268
726e0ab1
PE
2269 * bidi.c (bidi_shelve_header_size): New constant.
2270 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2271 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2272
51f30bc5 2273 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2274 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2275 (overlay_strings):
2276 Don't update size of array until after memory allocation succeeds,
2277 because xmalloc/xrealloc may not return.
0065d054
PE
2278 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2279 now that we have proper integer overflow checking.
2280 (record_overlay_string, overlay_strings): Catch overflows when
2281 calculating size of overlay_str_buf.
726e0ab1 2282
0065d054
PE
2283 * callproc.c (Fcall_process): Check for size overflow when
2284 calculating size of args2.
2285 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2286 Normally we prefer signed values, but sticking with ptrdiff_t would
2287 require adding more-complicated checks.
726e0ab1
PE
2288
2289 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2290 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2291 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2292 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2293
2294 * character.c (Fstring): Check for size-calculation overflow.
2295
2296 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2297 unnecessary integer overflow. Check for size overflow.
2298 (encode_coding_object): Don't update size until xmalloc succeeds.
2299
2300 * composite.c (get_composition_id): Check for overflow in glyph
2301 length calculations.
2302
2303 Integer and memory overflow fixes for display code.
2304 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2305 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2306 (scrolling_window): Check for overflow in size calculations.
2307 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2308 Don't assume glyph table len fits in int.
2309 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2310 (row_table_size): Now ptrdiff_t, not int.
2311 (scrolling_window): Avoid overflow in size calculations.
2312 Don't update size until allocation succeeds.
2313 * fns.c (concat): Check for overflow in size calculations.
2314 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2315 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2316 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2317
2318 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2319 (get_doc_string): Check for size calculation overflow.
2320 Don't update size until allocation succeeds.
2321 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2322 EMACS_INT, where ptrdiff_t will do.
2323 (Fsubstitute_command_keys): Check for string overflow.
2324
2325 * editfns.c (set_time_zone_rule): Don't assume environment length
2326 fits in int.
2327 (message_length): Now ptrdiff_t, not int.
2328 (Fmessage_box): Don't update size until allocation succeeds.
2329 Don't assume message length fits in int.
2330 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2331
0065d054
PE
2332 * emacs.c (main): Do not reallocate argv, since there is a null at
2333 the end that can be overwritten, and this way there's no need to
2334 worry about size-calculation overflow.
2335 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2336
2337 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2338 alloc succeeds.
2339 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2340
2341 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2342 (x_set_scroll_bar_width, x_figure_window_size):
2343 Check for integer overflow.
2344 (x_set_alpha): Do not assume XINT fits in int.
2345
2346 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2347 This is for the members text_lines, text_cols, total_lines, total_cols,
2348 where the system imposes an 'int' limit.
2349
2350 * fringe.c (Fdefine_fringe_bitmap):
2351 Don't update size until alloc works.
2352
2353 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2354 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2355
2356 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2357 Check for size-calculation overflow.
2358 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2359 do, as we prefer signed integers.
2360 (id_to_widget.max_size, id_to_widget.used)
2361 (xg_store_widget_in_map, xg_remove_widget_from_map)
2362 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2363 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2364 Use and return ptrdiff_t, not int.
2365 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2366 * gtkutil.h: Change prototypes to match the above.
2367
2368 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2369 are duplicate now that they've been promoted to lisp.h.
2370 (x_allocate_bitmap_record, x_alloc_image_color)
2371 (make_image_cache, cache_image, xpm_load):
2372 Don't update size until alloc is done.
2373 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2374 (x_detect_edges):
3256efce 2375 Check for size calculation overflow.
726e0ab1
PE
2376 (ct_colors_allocated_max): New constant.
2377 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2378 overflow.
3256efce 2379
726e0ab1
PE
2380 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2381 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2382 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2383 Use ptrdiff_t, not int, to count maps.
2384 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2385 calculations. Don't update size until allocation succeeds.
2386 Redo calculations to avoid overflow.
726e0ab1
PE
2387 * keyboard.h: Change prototypes to match the above.
2388
2389 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2390 to count maps.
2391 (current_minor_maps): Check for size calculation overflow.
2392 * keymap.h: Change prototypes to match the above.
2393
2394 * lread.c (read1, init_obarray): Don't update size until alloc done.
2395
2396 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2397 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2398
726e0ab1
PE
2399 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2400 Now ptrdiff_t, not int.
2401 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2402 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2403
2404 * process.c (Fnetwork_interface_list): Check for overflow
2405 in size calculation.
2406
2407 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2408
2409 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2410 overflow. Don't bother calling xmalloc when xrealloc will do.
2411
2412 * search.c (Freplace_match): Check for size calculation overflow.
2413 (Fset_match_data): Don't assume list lengths fit in 'int'.
2414
2415 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2416 for command line length. Do not attempt to address one before the
2417 beginning of an array, as that's not portable.
2418
2419 * term.c (max_frame_lines): Remove; unused.
2420 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2421 not int.
2422 (encode_terminal_code, calculate_costs): Check for size
2423 calculation overflow.
2424 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2425 table lengths and related sizes. Don't update size until alloc
2426 done. Redo calculations to avoid overflow.
2427 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2428
2429 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2430 subtracting pointers.
2431 (gobble_line): Check for overflow more carefully. Don't update size
2432 until alloc done.
2433
2434 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2435 Don't update size until alloc done.
2436 Redo size calculations to avoid overflow.
2437 Check for size calculation overflow.
0065d054 2438 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2439
2440 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2441 Use ptrdiff_t, not int, for sizes.
2442 (store_mode_line_noprop_char): Don't update size until alloc done.
2443
0065d054
PE
2444 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2445 Use ptrdiff_t, not int, for sizes.
2446 (Finternal_make_lisp_face, cache_face):
2447 Check for size calculation overflow.
2448 (cache_face): Treat size calculation overflows as if they were
2449 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2450
2451 * xfns.c (x_encode_text, x_set_name_internal)
2452 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2453 sizes, since they can exceed INT_MAX in size. Check for size
2454 calculation overflow.
2455
0065d054
PE
2456 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2457 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2458 Don't update size until alloc done.
2459
0065d054 2460 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2461 as sprintf is limited to int lengths.
1d526e2f 2462
252c5ee1
PE
2463 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2464 (X_LONG_MIN): New macros.
864d7ce7
PE
2465 Use them to make the following changes clearer.
2466 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2467 This change doesn't affect the value now, but it may help remind
2468 future maintainers not to raise the value too much later.
2469 (SELECTION_QUANTUM): Remove, replacing with ...
2470 (selection_quantum): ... new function, which avoids overflow.
2471 All uses changed.
2472 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2473 assumption that selection length fits in 'int'.
2474 (x_reply_selection_request, x_handle_selection_request)
2475 (x_get_window_property, receive_incremental_selection)
2476 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2477 (lisp_data_to_selection_data, clean_local_selection_data):
2478 Use ptrdiff_t, not int, to record length of selection.
2479 (x_reply_selection_request, x_get_window_property)
2480 (receive_incremental_selection, x_property_data_to_lisp):
2481 Redo calculations to avoid overflow.
2482 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2483 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2484 something.
2485 (x_get_window_property, receive_incremental_selection)
2486 (lisp_data_to_selection_data, x_property_data_to_lisp):
2487 Check for size-calculation overflow.
2488 (x_get_window_property, receive_incremental_selection)
2489 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2490 Don't store size until memory allocation succeeds.
2491 (x_get_window_property): Plug memory leak on memory exhaustion.
2492 Don't double-block input; malloc is safe here. Don't assume 2**34
2493 - 4 fits in unsigned long. Add an xassert to check
2494 XGetWindowProperty overflow. Be more careful about overflow
2495 calculations, and distinguish size from memory overflow better.
2496 (receive_incremental_selection): When tracing, don't assume
2497 unsigned int is less than INT_MAX.
2498 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2499 harmful) conversions of unsigned short to int.
2500 (lisp_data_to_selection_data): Don't assume that integers
2501 in the range -65535 through -1 fit in an X unsigned short.
2502 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2503 result parameters unless successful. Rely on cons_to_unsigned
2504 to report problems with elements; the old code wasn't right anyway.
2505 (x_check_property_data): Check for int overflow; we cannot use
2506 a wider type due to X limits.
2507 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2508
726e0ab1 2509 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2510
0065d054
PE
2511 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2512 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2513 (x_color_cells): Don't store size until memory allocation succeeds.
2514 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2515 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2516 (x_term_init): Don't assume length fits in int (sprintf is limited
2517 to int size).
bc18e09d 2518
ebfa62c0
PE
2519 Use ptrdiff_t for composition IDs.
2520 * character.c (lisp_string_width):
2521 * composite.c (composition_table_size, n_compositions)
2522 (get_composition_id, composition_gstring_from_id):
2523 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2524 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2525 * window.c (Frecenter):
2526 Use ptrdiff_t, not int, for composition IDs.
2527 * composite.c (get_composition_id): Check for integer overflow.
2528 * composite.h: Adjust prototypes to match the above changes.
2529
d3411f89
PE
2530 Use ptrdiff_t for hash table indexes.
2531 * category.c (hash_get_category_set):
2532 * ccl.c (ccl_driver):
2533 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2534 * coding.c (coding_system_charset_list, detect_coding_system):
2535 * coding.h (struct coding_system.id):
2536 * composite.c (get_composition_id, gstring_lookup_cache):
2537 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2538 * image.c (xpm_get_color_table_h):
2539 * lisp.h (hash_lookup, hash_put):
2540 * minibuf.c (Ftest_completion):
2541 Use ptrdiff_t for hash table indexes, not int (which is too
2542 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2543 32-bit --with-wide-int hosts).
2544
e097a6fa
PE
2545 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2546 Add a FIXME comment about memory leaks.
2547 (syms_of_charset): Don't assume xmalloc returns.
2548
5637687f
PE
2549 Don't assume that stated character widths fit in int.
2550 * character.c (Fchar_width, c_string_width, lisp_string_width):
2551 * character.h (CHAR_WIDTH):
2552 * indent.c (MULTIBYTE_BYTES_WIDTH):
2553 Use sanitize_char_width to avoid undefined and/or bad behavior
2554 with outlandish widths.
a66cfb1c 2555 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2556 now that we have two such functions. All uses changed.
2557 (sanitize_char_width): New inline function.
2558
a2271ba2
PE
2559 Don't assume that tab-width fits in int.
2560 * character.h (sanitize_width): New inline function.
2561 (SANE_TAB_WIDTH): New macro.
2562 (ASCII_CHAR_WIDTH): Use it.
2563 * indent.c (sane_tab_width): Remove. All uses replaced by
2564 SANE_TAB_WIDTH (current_buffer).
2565 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2566
18c52557
PE
2567 * fileio.c: Integer overflow issues with file modes.
2568 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2569
caeeedc1
PE
2570 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2571 Remove unreachable code.
2572 (read_hex, load_charset_map_from_file): Check for integer overflow.
2573
6df6ae42 2574 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2575 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2576 (x_send_scroll_bar_event): Likewise. Check that the size does not
2577 exceed limits imposed by XClientMessageEvent, as well as the usual
2578 ptrdiff_t and size_t limits.
2579
b13995db
PE
2580 * keyboard.c: Overflow, signedness and related fixes.
2581 (make_lispy_movement): Use same integer type in forward decl
2582 that is used in the definition.
2583 (read_key_sequence, keyremap_step):
2584 Change bufsize argument back to int, undoing my 2011-03-30 change.
2585 We prefer signed types, and int is wide enough here.
2586 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2587 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2588 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2589 length, not size_t. Use ptrdiff_t for index, not int.
2590 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2591 possibility of integer overflow.
2592
13464394
PE
2593 Overflow, signedness and related fixes for images.
2594
2595 * dispextern.h (struct it.stack[0].u.image.image_id)
2596 (struct_it.image_id, struct image.id, struct image_cache.size)
2597 (struct image_cache.used, struct image_cache.ref_count):
2598 * gtkutil.c (update_frame_tool_bar):
2599 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2600 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2601 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2602 * nsmenu.m (update_frame_tool_bar):
2603 * xdisp.c (calc_pixel_width_or_height):
2604 * xfns.c (image_cache_refcount):
2605 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2606 on typical 64-bit hosts.
2607
2608 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2609 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2610 Omit unnecessary casts to int.
2611 (parse_image_spec): Check that integers fall into 'int' range
2612 when the callers expect that.
2613 (image_ascent): Redo ascent calculation to avoid int overflow.
2614 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2615 (lookup_image): Remove unnecessary tests.
2616 (xbm_image_p): Locals are now of int, not EMACS_INT,
2617 since parse_image_check makes sure they fit into int.
2618 (png_load, gif_load, svg_load_image):
2619 Prefer int to unsigned where either will do.
2620 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2621 old tiff_error_handler and tiff_warning_handler.
2622 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2623 stack buffer overflows. It uses only the features of vsnprintf
2624 that are common to both POSIX and native Microsoft.
2625 (tiff_error_handler, tiff_warning_handler): Use it.
2626 (tiff_load, gif_load, imagemagick_load_image):
2627 Don't assume :index value fits in 'int'.
2628 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2629 (imagemagick_load_image): Check that crop parameters fit into
2630 the integer types that MagickCropImage accepts. Don't assume
2631 Vimagemagick_render_type has a nonnegative value. Don't assume
2632 size_t fits in 'long'.
2633 (gs_load): Use printmax_t to print the widest integers possible.
2634 Check for integer overflow when computing image height and width.
2635
c11821d4
EZ
26362011-08-26 Eli Zaretskii <eliz@gnu.org>
2637
2638 * xdisp.c (redisplay_window): Don't force window start if point
2639 will be invisible in the resulting window. (Bug#9324)
2640
0c95fcf7
EZ
26412011-08-25 Eli Zaretskii <eliz@gnu.org>
2642
2643 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2644 the display spec is of the form `(space ...)'.
2645 (handle_display_spec): Return the value returned by
2646 handle_single_display_spec, not just 1 or zero.
2647 (handle_single_display_spec): If the display spec is of the form
2648 `(space ...)', and specifies display in the text area, return 2
2649 rather than 1.
fee65a97 2650 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2651 accurately, and prefer exact match for point under bidi.
2652 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2653
2654 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2655 into disp_prop; all users changed.
2656
2657 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2658 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2659 for the text covered by the display property.
2660
e4ed06f1
CY
26612011-08-25 Chong Yidong <cyd@stupidchicken.com>
2662
2663 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2664 Change return value to nil.
2665 (Frecord_buffer): Delete unused function.
2666
f67cdd7f
EZ
26672011-08-24 Eli Zaretskii <eliz@gnu.org>
2668
5980d4c6
EZ
2669 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2670 buffers, return left-to-right.
8610fe8b
EZ
2671 (set_cursor_from_row): Consider candidate row a win if its glyph
2672 represents a newline and point is on that newline. Fixes cursor
2673 positioning on the newline at EOL of R2L text within L2R
2674 paragraph, and vice versa.
2675 (try_cursor_movement): Check continued rows, in addition to
2676 continuation rows. Fixes unwarranted scroll when point enters a
2677 continued line of R2L text within an L2R paragraph, or vice versa.
2678 (cursor_row_p): Consider the case of point being equal to
2679 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2680 from the end of a short line to the beginning of a continued line
2681 of R2L text within L2R paragraph.
2682 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2683 composed characters.
5980d4c6 2684
f67cdd7f
EZ
2685 * bidi.c (bidi_check_type): Use xassert.
2686 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2687 members.
2688
bca633fb
EZ
26892011-08-23 Eli Zaretskii <eliz@gnu.org>
2690
2691 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2692 a character.
2693
4a5885a7
CY
26942011-08-23 Chong Yidong <cyd@stupidchicken.com>
2695
2696 * nsfont.m (ns_otf_to_script): Fix typo.
2697
0902a04e
KH
26982011-08-22 Kenichi Handa <handa@m17n.org>
2699
2700 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2701 extra slot even if the purpose is char-code-property-table.
2702
1a2e6670
EZ
27032011-08-23 Eli Zaretskii <eliz@gnu.org>
2704
8ddde651
EZ
2705 * xdisp.c (redisplay_window): When computing centering_position,
2706 account for the height of the header line. (Bug#8874)
2707
425cc014
EZ
2708 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2709 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2710 candidate is selected by the mouse, and that candidate has a
2711 composed character under the mouse.
2712
1a2e6670
EZ
2713 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2714 coordinates reported by pos-visible-in-window-p for a composed
2715 character in column zero.
2716
8b76d6f8
SM
27172011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2718
2719 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2720
dac347dd
EZ
27212011-08-22 Eli Zaretskii <eliz@gnu.org>
2722
2723 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2724 consider it a hit if to_charpos is anywhere in the range of the
2725 composed buffer positions.
2726
e013fb34
CY
27272011-08-22 Chong Yidong <cyd@stupidchicken.com>
2728
2729 * image.c (gif_load): Don't assume that each subimage has the same
2730 dimensions as the base image. Handle disposal method that is
2731 "undefined" by the gif spec (Bug#9335).
2732
bd1ba3e8
CY
27332011-08-20 Chong Yidong <cyd@stupidchicken.com>
2734
2735 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2736 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2737
54a1215b
EZ
27382011-08-19 Eli Zaretskii <eliz@gnu.org>
2739
823564e5
EZ
2740 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2741 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2742 from an Org mode buffer to a Speedbar frame.
2743
54a1215b
EZ
2744 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2745 a composition, take its buffer position from IT->cmp_it.charpos.
2746 Fixes cursor positioning at the beginning of a line that begins
2747 with a composed character.
2748
9778ebcc
EZ
27492011-08-18 Eli Zaretskii <eliz@gnu.org>
2750
0be6ee06
EZ
2751 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2752 character bidirectional type, use STRONG_L instead. Fixes crashes
2753 in a buffer produced by `describe-categories'.
2754
9778ebcc
EZ
2755 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2756 members before the level stack, so they would be saved and
2757 restored when copying iterator state. Fixes incorrect reordering
2758 around TABs covered by display properties.
2759
156bffbe
AS
27602011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2761
6b02f655 2762 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2763
72ad093b
CY
27642011-08-17 Chong Yidong <cyd@stupidchicken.com>
2765
2766 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2767 (internal_condition_case_2, internal_condition_case_n):
2768 Remove unnecessary aborts (Bug#9081).
72ad093b 2769
35774242
EZ
27702011-08-17 Eli Zaretskii <eliz@gnu.org>
2771
2772 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2773 has no `load' handler, try opening the file locally. (Bug#9311)
2774
db76dd85
KB
27752011-08-16 Ken Brown <kbrown@cornell.edu>
2776
2777 * gmalloc.c: Expand comment.
2778
b215eee5
EZ
27792011-08-16 Eli Zaretskii <eliz@gnu.org>
2780
2781 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2782 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2783
a4579d33
KB
27842011-08-16 Ken Brown <kbrown@cornell.edu>
2785
2786 Fix memory allocation problems in Cygwin build (Bug#9273).
2787
2788 * unexcw.c ( __malloc_initialized): Declare external variable.
2789 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2790
8b76d6f8
SM
2791 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2792 New variables.
a4579d33
KB
2793 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2794 dumped emacs.
2795 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2796 in the static heap.
2797 [CYGWIN] (special_realloc): New function.
2798 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2799 requests to realloc storage in the static heap.
2800
3ebec551
PE
28012011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2802
2803 * bidi.c (bidi_initialize): Remove unused local.
2804
9fd8be00
EZ
28052011-08-15 Eli Zaretskii <eliz@gnu.org>
2806
6b02f655
SM
2807 * bidimirror.h:
2808 * biditype.h: Remove file.
2809 * makefile.w32-in ($(BLD)/bidi.$(O)):
2810 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2811
2812 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2813
2814 * chartab.c: Improve commentary for the uniprop_table API.
2815
32413314
EZ
2816 * bidi.c (bidi_paragraph_init): Support zero value of
2817 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2818 (bidi_initialize): Use uniprop_table instead of including
2819 biditype.h and bidimirror.h.
32413314 2820
9fd8be00
EZ
2821 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2822 coordinates of the iterator when restoring from ppos_it.
2823 (Bug#9296)
2824
5cf2b69b
KH
28252011-08-14 Kenichi Handa <handa@m17n.org>
2826
2827 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2828 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2829
daf17d00
EZ
28302011-08-14 Eli Zaretskii <eliz@gnu.org>
2831
2832 * xdisp.c (move_it_in_display_line_to): Don't invoke
2833 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2834 ppos_it. Fixes vertical cursor motion when line beginning is
2835 covered by an image. (Bug#9296)
2836
08e3161a
JD
28372011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2838
2839 * nsterm.h (ns_run_ascript): Declare.
2840 (NSAPP_DATA2_RUNASSCRIPT): Define.
2841
2842 * nsfns.m (as_script, as_result, as_status): New static variables.
2843 (ns_run_ascript): New function.
5e617bc2 2844 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2845 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2846 the event loop. Get status from as_status (Bug#7276).
2847
2848 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2849 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2850 the event loop (Bug#7276).
2851
a3720aa2
AS
28522011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2853
2854 * gnutls.c (QCgnutls_bootprop_priority)
2855 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2856 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2857 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2858 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2859 (QCgnutls_bootprop_verify_hostname_error)
2860 (QCgnutls_bootprop_callbacks_verify): Rename from
2861 Qgnutls_bootprop_..., all uses changed.
2862
2863 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2864 uses changed.
2865
0a0d27fb
PE
28662011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2867
19d5c50c
PE
2868 * xfaces.c (Qframe_set_background_mode): Now static.
2869 * dispextern.h (Qframe_set_background_mode): Remove decl.
2870
0a0d27fb
PE
2871 * process.c (Fnetwork_interface_info): Declare local only if needed.
2872
377538cb
JD
28732011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2874
2875 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2876 (Fnetwork_interface_list): Allocate in increments of bytes instead
2877 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2878 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2879 sockaddr.
2880 (struct ifflag_def): notrailers is smart on OSX.
2881 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2882 Get hardware address with getifaddrs if available.
2883
08fff70c
EZ
28842011-08-12 Eli Zaretskii <eliz@gnu.org>
2885
2886 * xdisp.c (iterate_out_of_display_property): xassert that
2887 IT->position is set to within IT->object's boundaries. Break from
2888 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2889 when IT->position is set up wrongly due to some bug.
2890 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2891 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2892 entry. Force push_it to save on the stack the current
2893 buffer/string position, to be restored by pop_it. Fix flags in
2894 the iterator structure wrt the object coming from a display
2895 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2896 properties. (Bug#9284)
2897
7be1c708 28982011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2899
7be1c708
CY
2900 * fontset.c (fontset_get_font_group): Add proper type checks.
2901 (Bug#9172)
aac0c6e3 2902
7be1c708 29032011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2904
7be1c708
CY
2905 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2906 and LC_VERSION_MIN_MACOSX.
2907 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2908 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2909
97bb72a6
EZ
29102011-08-08 Eli Zaretskii <eliz@gnu.org>
2911
2912 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2913 no-display-properties-and-no-overlays under bidi display.
2914 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2915 properties and overlays.
97bb72a6 2916
d5617611
CY
29172011-08-08 Chong Yidong <cyd@stupidchicken.com>
2918
37e11a63
CY
2919 * editfns.c (Fset_time_zone_rule): Document relationship with the
2920 setenv function.
2921
d5617611
CY
2922 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2923 the font entity extracted from the cache (Bug#8109).
2924
58872834
CY
29252011-08-07 Chong Yidong <cyd@stupidchicken.com>
2926
2927 * composite.c (autocmp_chars): Don't reset point. That is done by
2928 restore_point_unwind (Bug#5984).
2929
75bfc667
JL
29302011-08-07 Juri Linkov <juri@jurta.org>
2931
2932 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2933 to show the arg `TIME' instead of `TIMEVAL'.
2934
d1410150
EZ
29352011-08-06 Eli Zaretskii <eliz@gnu.org>
2936
2937 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2938 display property strides EOL and includes a newline, as in
2939 longlines-mode. (Bug#9254)
75b771e4
EZ
2940 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2941 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2942
2943 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2944 is non-zero, even if the data buffer is NULL. Fixes a crash in
2945 vertical-motion with longlines-mode. (Bug#9254)
2946
35928349
EZ
29472011-08-05 Eli Zaretskii <eliz@gnu.org>
2948
ec7cc85b
EZ
2949 * bidi.c <bidi_cache_total_alloc>: Now static.
2950 (bidi_initialize): Initialize bidi_cache_total_alloc.
2951
8b76d6f8 2952 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2953 cache. (Bug#9221)
2954
2955 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2956 amount allocated this far in `bidi_cache_total_alloc'.
2957 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2958 non-zero, only free the data buffer without restoring the cache
2959 contents. All callers changed.
2960
2961 * dispextern.h (bidi_unshelve_cache): Update prototype.
2962
2963 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2964 (move_it_in_display_line, move_it_to)
2965 (move_it_vertically_backward, move_it_by_lines): Replace the call
2966 to xfree to an equivalent call to bidi_unshelve_cache.
2967 (move_it_in_display_line_to): Fix logic of returning
412b6358 2968 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2969
e2e2423b
EZ
29702011-08-05 Eli Zaretskii <eliz@gnu.org>
2971
2972 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2973 came from a string character with a `cursor' property. (Bug#9229)
2974
ae9e757a
JD
29752011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2976
2977 * Makefile.in (LIB_PTHREAD): New variable.
2978 (LIBES): Add LIB_PTHREAD (Bug#9216).
2979
2980 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2981 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2982
213bd7f2
AS
29832011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2984
6b02f655 2985 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2986
99aaf75f
JD
29872011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2988
2989 * xterm.c (x_find_topmost_parent): New function.
2990 (x_set_frame_alpha): Find topmost parent window with
2991 x_find_topmost_parent and set the property there also (bug#9181).
2992 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2993
c74e9d86
PE
29942011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2995
2996 * callproc.c (Fcall_process): Avoid vfork clobbering
2997 the local vars buffer, coding_systems, current_dir.
2998
640c8776
SM
29992011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3000
3001 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3002
f26d0e4c
PE
30032011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3004
8a10d76c
PE
3005 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3006 so that it is not optimized away.
3007
f26d0e4c
PE
3008 * xdisp.c (compute_display_string_pos): Remove unused local.
3009
55439c61
EZ
30102011-08-02 Eli Zaretskii <eliz@gnu.org>
3011
3012 Fix slow cursor motion and scrolling in large buffers with
3013 selective display, like Org Mode buffers. (Bug#9218)
3014
3015 * dispextern.h (struct bidi_it): New member disp_prop_p.
3016
3017 * xdisp.c: Remove one-slot cache of display string positions.
3018 (compute_display_string_pos): Accept an additional argument
5e617bc2 3019 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3020 for a display string or property. If found, set DISP_PROP_P
3021 non-zero.
3022
3023 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3024 DISP_PROP_P, and pass it to compute_display_string_pos.
3025 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3026 non-zero. All callers of bidi_fetch_char changed.
3027
fb33fa43
SM
30282011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3029
3030 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3031
b099e063
DM
30322010-12-03 Don March <don@ohspite.net>
3033
3034 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3035 last character M-[char] is translated to ESC [char] (bug#7541).
3036
5cc7f7af
KH
30372011-08-02 Kenichi Handa <handa@m17n.org>
3038
d0fffa3f 3039 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3040
3041 * chartab.c (uniprop_table): Make it non-static.
3042
525d5e6e
EZ
30432011-08-01 Eli Zaretskii <eliz@gnu.org>
3044
3045 * xdisp.c (forward_to_next_line_start): Accept additional argument
3046 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3047 on the newline.
3048 (reseat_at_next_visible_line_start): Use the bidi iterator state
3049 returned by forward_to_next_line_start to restore the state of
3050 it->bidi_it after backing up to previous newline. (Bug#9212)
3051
31011111
AS
30522011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3053
3054 * regex.c (re_comp): Protoize.
3055 (re_exec): Fix return type.
3056 (regexec): Fix type of `ret'. (Bug#9203)
3057
476371c4
PE
30582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3059
e5d76069
PE
3060 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3061 This is needed if max-image-size is a floating-point number.
3062
9a79b20c
AS
30632011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3064
3065 * print.c (print_object): Print empty symbol as ##.
3066
3067 * lread.c (read1): Read ## as empty symbol.
3068
d8c2fa78
AA
30692011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3070
3071 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3072 setting frame foreground color (Bug#9175).
3073 (x_set_background_color): Likewise.
3074
ffe57a7a
AA
3075 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3076 contents (Bug#9176).
3077 (EmacsTooltip -init): Remove bezels and add shadows to
3078 tooltip windows.
3079
bf3492a5
AA
3080 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3081 or scroll bar (Bug#8470).
3082
d55e9c53
AA
3083 * nsfont.m (nsfont_open): Remove assignment to voffset and
3084 unnecessary vars hshink, expand, hd, full_height, min_height.
3085 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3086
3087 * nsterm.h (nsfont_info): Remove voffset field.
3088
d8c2fa78 30892011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3090
3091 Implement strike-through and overline on NextStep (Bug#8863).
3092
3093 * nsfont.m (nsfont_open): Use underline position provided by font,
3094 instead of hard-coded value of 2.
3095 (nsfont_draw): Call ns_draw_text_decoration instead.
3096
3097 * nsterm.h: Add declaration for ns_draw_text_decoration.
3098
3099 * nsterm.m (ns_draw_text_decoration): New function for drawing
3100 underline, overline, and strike-through.
3101 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3102 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3103 accommodate underlining, etc.
4843aac3 3104
4cc60b9b
EZ
31052011-07-28 Eli Zaretskii <eliz@gnu.org>
3106
bc7ece87
EZ
3107 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3108 default.
4cc60b9b 3109
476371c4
PE
31102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3111
66606eea
PE
3112 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3113 Without this fix, if a signal arrives just after memory fills up,
3114 'malloc' might be invoked reentrantly.
3115
476371c4
PE
3116 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3117 In other words, assume that every image size is allowed, on non-X
3118 hosts. This assumption is probably wrong, but it lets Emacs compile.
3119
f3fcc40d
AS
31202011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3121
3122 * regex.c (re_iswctype): Convert return values to boolean.
3123
350c992f
EZ
31242011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3125
3126 * xdisp.c (compute_display_string_pos): Don't use cached display
3127 string position if the buffer had its restriction changed.
3128 (Bug#9184)
3129
5266b4bb
PE
31302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3131
3132 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3133
2573a837 31342011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3135
41f55ccd 3136 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3137
39e378da
PE
3138 * bidi.c: Integer size and overflow fixes.
3139 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3140 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3141 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3142 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3143 (bidi_find_other_level_edge):
3144 Use ptrdiff_t instead of EMACS_INT where either will do.
3145 This works better on 32-bit hosts configured --with-wide-int.
3146 (bidi_cache_ensure_space): Check for size-calculation overflow.
3147 Use % rather than repeated addition, for better worst-case speed.
3148 Don't set bidi_cache_size until after xrealloc returns, because it
3149 might not return.
3150 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3151 (bidi_cache_ensure_space): Also check that the bidi cache size
3152 does not exceed that of the largest Lisp string or buffer. See Eli
3153 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3154
5e927815
PE
3155 * alloc.c (__malloc_size_t): Remove.
3156 All uses replaced by size_t. See Andreas Schwab's note
3157 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3158
ca4aa935
PE
3159 * image.c: Improve checking for integer overflow.
3160 (check_image_size): Assume that f is nonnull, since
3161 it is always nonnull in practice. This is one less thing to
3162 worry about when checking for integer overflow later.
3163 (x_check_image_size): New function, which checks for integer
3164 overflow issues inside X.
3165 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3166 This removes the need for a memory_full check.
3167 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3168 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3169 (xbm_read_bitmap_data): Change locals back to 'int', since
3170 their values must fit in 'int'.
3171 (xpm_load_image, png_load, tiff_load):
3172 Invoke x_create_x_image_and_pixmap earlier,
3173 to avoid much needless work if the image is too large.
3174 (tiff_load): Treat overly large images as if
3175 x_create_x_image_and_pixmap failed, not as malloc failures.
3176 (gs_load): Use x_check_image_size.
3177
5f8f9cc2
PE
3178 * gtkutil.c: Omit integer casts.
3179 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3180 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3181
5adf60bc
PE
3182 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3183
c8907a93
PE
3184 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3185 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3186 would wrongly return t on a 64-bit host.
3187
e3c25c68
PE
3188 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3189 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3190 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3191 and therefore cause GCC to emit a bogus diagnostic in some cases.
3192
3f791afe
PE
3193 * image.c: Integer signedness and overflow and related fixes.
3194 This is not an exhaustive set of fixes, but it's time to
3195 record what I've got.
3196 (lookup_pixel_color, check_image_size): Remove redundant decls.
3197 (check_image_size): Don't assume that arbitrary EMACS_INT values
3198 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3199 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3200 (tiff_load, imagemagick_load_image):
3201 Check for overflow in size calculations.
3202 (x_create_x_image_and_pixmap): Remove unnecessary test for
3203 xmalloc returning NULL; that can't happen.
3204 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3205 (xpm_color_bucket): Use better integer hashing function.
3206 (xpm_cache_color): Don't possibly over-allocate memory.
3207 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3208 (gif_memory_source):
3209 Use ptrdiff_t, not int or size_t, to record sizes.
3210 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3211 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3212 either works, as we prefer signed integers.
3213 (tiff_read_from_memory, tiff_write_from_memory):
3214 Return tsize_t, not size_t, since that's what the TIFF API wants.
3215 (tiff_read_from_memory): Don't fail simply because the read would
3216 go past EOF; instead, return a short read.
3217 (tiff_load): Omit no-longer-needed casts.
3218 (Fimagemagick_types): Don't assume size fits into 'int'.
3219
3cc5a532
PE
3220 Improve hashing quality when configured --with-wide-int.
3221 * fns.c (hash_string): New function, taken from sxhash_string.
3222 Do not discard information about ASCII character case; this
3223 discarding is no longer needed.
3224 (sxhash-string): Use it. Change sig to match it. Caller changed.
3225 * lisp.h: Declare it.
3226 * lread.c (hash_string): Remove, since we now use fns.c's version.
3227 The fns.c version returns a wider integer if --with-wide-int is
3228 specified, so this should help the quality of the hashing a bit.
3229
b312a492
PE
3230 * emacs.c: Integer overflow minor fix.
3231 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3232 Define only if GNU_LINUX.
3233 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3234
dfd153ae
PE
3235 * dispnew.c: Integer signedness and overflow fixes.
3236 Remove unnecessary forward decls, that were a maintenance hassle.
3237 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3238 All uses changed.
3239 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3240 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3241 (prepare_desired_row, line_draw_cost):
3242 Use int, not unsigned, where either works.
3243 (save_current_matrix, restore_current_matrix):
3244 Use ptrdiff_t, not size_t, where either works.
3245 (init_display): Check for overflow more accurately, and without
3246 relying on undefined behavior.
3247
a81d11a3
PE
3248 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3249 Remove, replacing with the new symbols in lisp.h. All uses changed.
3250 * fileio.c (make_temp_name):
3251 * filelock.c (lock_file_1, lock_file):
3252 * xdisp.c (message_dolog):
3253 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3254 Use pMd etc. instead.
3255 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3256 replacing the pWIDE etc. symbols removed from editfns.c.
3257
3300e6fd
PE
3258 * keyboard.h (num_input_events): Now uintmax_t.
3259 This is (very slightly) less likely to mess up due to wraparound.
3260 All uses changed.
3261
fd05c7e9
PE
3262 * buffer.c: Integer signedness fixes.
3263 (alloc_buffer_text, enlarge_buffer_text):
3264 Use ptrdiff_t rather than size_t when either will do, as we prefer
3265 signed integers.
3266
903fe15d
PE
3267 * alloc.c: Integer signedness and overflow fixes.
3268 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3269 (__malloc_size_t): Default to size_t, not to int.
3270 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3271 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3272 Prefer ptrdiff_t to size_t when either would do, as we prefer
3273 signed integers.
3274 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3275 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3276 Now const. Initialize with values that are in range even if char
3277 is signed.
3278 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3279 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3280 These functions do the right thing with sizes > 2**32.
3281 (check_depth): Now ptrdiff_t, not int.
3282 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3283 Adjust to new way of storing sizes. Check for size overflow bugs
3284 in rest of code.
3285 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3286 slightly wrong anyway, as it missed one instance of
3287 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3288 (refill_memory_reserve): Omit needless cast to size_t.
3289 (mark_object_loop_halt): Mark as externally visible.
3290
ac82cc6a
PE
3291 * xselect.c: Integer signedness and overflow fixes.
3292 (Fx_register_dnd_atom, x_handle_dnd_message):
3293 Use ptrdiff_t, not size_t, since we prefer signed.
3294 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3295 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3296 x_dnd_atoms_size and x_dnd_atoms_length.
3297
c2d1e36d
PE
3298 * doprnt.c: Prefer signed to unsigned when either works.
3299 * eval.c (verror):
3300 * doprnt.c (doprnt):
3301 * lisp.h (doprnt):
3302 * xdisp.c (vmessage):
3303 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3304 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3305 prefer signed arithmetic to avoid comparison confusion.
3306 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3307 but is a bit tricky.
3308
0e926e56
PE
3309 Assume freestanding C89 headers, string.h, stdlib.h.
3310 * data.c, doprnt.c, floatfns.c, print.c:
3311 Include float.h unconditionally.
3312 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3313 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3314 * regex.c: Likewise for stddef.h, string.h.
3315 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3316 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3317 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3318 (STDC_HEADERS): Remove obsolete defines.
3319 * sysdep.c: Include limits.h unconditionally.
3320
9cfdb3ec
PE
3321 Assume support for memcmp, memcpy, memmove, memset.
3322 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3323 * regex.c (memcmp, memcpy):
3324 Remove; we assume C89 now.
3325
3326 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3327 (__malloc_safe_bcopy): Remove; no longer needed.
3328
cf950e6b 3329 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3330 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3331 well either way, and we prefer signed to unsigned.
3332
dbf38e02
LMI
33332011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3334
3335 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3336 closes the connection while we're reading (bug#9182).
3337
d6f0886c 33382011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3339
d6f0886c
JD
3340 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3341 are specified (Bug#9168).
24e0f6b1 3342
2eb1f9e6
PE
33432011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3344
3345 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3346 Found by GCC static checking and --with-wide-int on a 32-bit host.
3347
22381272 33482011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3349
3350 * xdisp.c (compute_display_string_pos): Fix logic of caching
3351 previous display string position. Initialize cached_prev_pos to
3352 -1. Fixes slow-down at the beginning of a buffer.
3353
f25e39b4
EZ
33542011-07-24 Eli Zaretskii <eliz@gnu.org>
3355
3356 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3357 for attrs[LFACE_FONTSET_INDEX].
3358
04c4b52e
PE
33592011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3360
3361 * xml.c (parse_region): Remove unused local
3362 that was recently introduced.
3363
c1734fbd
EZ
33642011-07-23 Eli Zaretskii <eliz@gnu.org>
3365
be18c5a5
EZ
3366 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3367 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3368
c1734fbd
EZ
3369 * xdisp.c (move_it_in_display_line_to): Record the best matching
3370 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3371 exit if none of the characters scanned was an exact match.
3372 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3373 when exact match is impossible due to invisible text, and the
3374 lines are truncated.
3375
a258d627
JD
33762011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3377
3378 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3379 for OSX >= 10.7.
3380
b6d5a689
EZ
33812011-07-22 Eli Zaretskii <eliz@gnu.org>
3382
0f74f785
EZ
3383 Fix a significant slow-down of cursor motion with C-n, C-p,
3384 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3385 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3386 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3387 (next_element_from_buffer): Call compute_stop_pos_backwards to
3388 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3389 base_level_stop.
3390 (reseat): Don't look for prev_stop, as that could mean a very long
3391 run.
3392 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3393 <cached_disp_overlay_modiff>: Cache for last found display string
3394 position.
551918c1 3395 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3396 about the same buffer in the same area of character positions, and
3397 the buffer wasn't changed since the time the display string
3398 position was cached.
551918c1 3399
b2d0c91a
EZ
34002011-07-22 Eli Zaretskii <eliz@gnu.org>
3401
3402 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3403 is an integer, which is important for empty lines. (Bug#9149)
3404
043604ee
CY
34052011-07-22 Chong Yidong <cyd@stupidchicken.com>
3406
3407 * frame.c (Fmodify_frame_parameters): In tty case, update the
3408 default face if necessary (Bug#4238).
3409
da4adb04
CY
34102011-07-21 Chong Yidong <cyd@stupidchicken.com>
3411
3412 * editfns.c (Fstring_to_char): No need to explain what a character
3413 is in the docstring (Bug#6576).
3414
9abd0532
LMI
34152011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3416
3417 * xml.c (parse_region): Make sure we always return a tree.
3418
36881d16
HK
34192011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3420
3421 * xml.c (parse_region): If a document contains only comments,
3422 return that, too.
3423
1e98674d
LMI
34242011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3425
3426 * xml.c (make_dom): Return comments, too.
3427
590bd467
PE
34282011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3429
3430 Port to OpenBSD.
3431 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3432 and the surrounding thread.
3433 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3434 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3435 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3436 timer goes off.
3437 * s/openbsd.h (BROKEN_SIGIO): Define.
3438 * unexelf.c (unexec) [__OpenBSD__]:
3439 Don't update the .mdebug section of the Alpha COFF symbol table.
3440
f41628b2
LMI
34412011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3442
3443 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3444 (bug#8460).
3445
b59b67c5
PE
34462011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3447
15e3a074
PE
3448 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3449 This fixes some race conditions on the permissions of any newly
3450 created file.
3451
41bed37d
PE
3452 * alloc.c (valid_pointer_p): Use pipe, not open.
3453 This fixes some permissions issues when debugging.
3454
b59b67c5
PE
3455 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3456 If fchown fails to set both uid and gid, try to set just gid,
3457 as that is sometimes allowed. Adjust the file's mode to eliminate
3458 setuid or setgid bits that are inappropriate if fchown fails.
3459
925a6be7
SM
34602011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3461
3462 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3463 to compare Lisp_Objects.
3464 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3465 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3466 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3467
52968808
AS
34682011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3469
0a6a104b
AS
3470 * lread.c (read_integer): Unread even EOF character.
3471 (read1): Likewise. Properly record start position of symbol.
3472
52968808
AS
3473 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3474 symbol character follows.
3475
9e381cdd
PE
34762011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3477
3478 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3479 This works around a problem with the previous change to Fcopy_file.
3480 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3481 and without this change, GCC might complain about discarding
3482 fchown's return value.
3483
b5641435
JB
34842011-07-16 Juanma Barranquero <lekktu@gmail.com>
3485
3486 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3487
a8031457
PE
34882011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3489
3490 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3491
dd889327
LMI
34922011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3493
750c33f7
LMI
3494 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3495 it's used from the C level.
3496
dd889327
LMI
3497 * process.c: Use the same condition for POLL_FOR_INPUT in both
3498 keyboard.c and process.c (bug#1858).
3499
87e86684
LM
35002011-07-09 Lawrence Mitchell <wence@gmx.li>
3501
3502 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3503 (Fgnutls_boot): Use it.
3504
64348f40
AS
35052011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3506
3507 * doc.c (Fsubstitute_command_keys): Revert last change.
3508
1d698799
LMI
35092011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3510
f863868c
LMI
3511 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3512 quotes the next character, and doesn't affect other longer
3513 sequences (bug#8935).
3514
1d698799
LMI
3515 * lread.c (syms_of_lread): Clarify that is isn't only
3516 `eval-buffer' and `eval-defun' that's affected by
3517 `lexical-binding' (bug#8460).
3518
aa4b6df6
EZ
35192011-07-15 Eli Zaretskii <eliz@gnu.org>
3520
3521 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3522 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3523
5d856da6
PE
35242011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3525
ad6042bb
PE
3526 Fix minor problems found by static checking.
3527 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3528 (elsz): Now a signed constant, not a size_t var. We prefer signed
3529 types to unsigned, to avoid integer comparison confusion. Without
3530 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3531 "cannot optimize loop, the loop counter may overflow", a symptom
3532 of the confusion.
f00bbb22 3533 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3534 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3535
6468f31c
LMI
35362011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3537
49080b10
LMI
3538 * search.c (Fre_search_backward): Mention `case-fold-search' in
3539 all the re_search_* functions (bug#8138).
3540
6468f31c
LMI
3541 * keyboard.c (Fopen_dribble_file): Document when the file is
3542 closed (bug#8056).
3543
c965adc5
EZ
35442011-07-14 Eli Zaretskii <eliz@gnu.org>
3545
df9733bf
EZ
3546 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3547 bidi_cache_idx.
3548
0bb23927
EZ
3549 Support bidi reordering of display and overlay strings.
3550 * xdisp.c (compute_display_string_pos)
3551 (compute_display_string_end): Accept additional argument STRING.
3552 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3553 (reseat_to_string): Initialize bidi_it->string.s and
3554 bidi_it->string.schars.
3555 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3556 NULL (avoids a crash in bidi_paragraph_init).
3557 Initialize itb.string.lstring.
0bb23927
EZ
3558 (init_iterator): Call bidi_init_it only of a valid
3559 buffer position was specified. Initialize paragraph_embedding to
3560 L2R.
3561 (reseat_to_string): Initialize the bidi iterator.
3562 (display_string): If we need to ignore text properties of
3563 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3564 original value of -1 will not work with bidi.)
3565 (compute_display_string_pos): First arg is now struct
3566 `text_pos *'; all callers changed. Support display properties on
3567 Lisp strings.
3568 (compute_display_string_end): Support display properties on Lisp
3569 strings.
3570 (init_iterator, reseat_1, reseat_to_string): Initialize the
3571 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3572 when iterating on a string not from display properties).
640c8776
SM
3573 (compute_display_string_pos, compute_display_string_end):
3574 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3575 arrow keys.
3576 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3577 base_level_stop; instead, set base_level_stop to BEGV.
3578 Fixes crashes in vertical-motion.
0bb23927
EZ
3579 (next_element_from_buffer): Improve commentary for when
3580 the iterator is before prev_stop.
3581 (init_iterator): Initialize bidi_p from the default value of
3582 bidi-display-reordering, not from buffer-local value. Use the
3583 buffer-local value only if initializing for buffer iteration.
3584 (handle_invisible_prop): Support invisible properties on strings
3585 that are being bidi-reordered.
3586 (set_iterator_to_next): Support bidi reordering of C strings and
3587 Lisp strings.
3588 (next_element_from_string): Support bidi reordering of Lisp
3589 strings.
3590 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3591 (display_string): Support display of R2L glyph rows.
3592 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3593 (init_iterator): Don't initialize it->bidi_p for strings
3594 here.
3595 (reseat_to_string): Initialize it->bidi_p for strings here.
3596 (next_element_from_string, next_element_from_c_string)
3597 (next_element_from_buffer): Add xassert's for correspondence
3598 between IT's object being iterated and it->bidi_it.string
3599 structure.
3600 (face_before_or_after_it_pos): Support bidi iteration.
3601 (next_element_from_c_string): Handle the case of the first string
3602 character that is not the first one in the visual order.
3603 (get_visually_first_element): New function, refactored from common
3604 parts of next_element_from_buffer, next_element_from_string, and
3605 next_element_from_c_string.
3606 (tool_bar_lines_needed, redisplay_tool_bar)
3607 (display_menu_bar): Force left-to-right direction. Add a FIXME
3608 comment for making that be controlled by a user option.
3609 (push_it, pop_it): Save and restore the state of the
3610 bidi iterator. Save and restore the bidi_p flag.
3611 (pop_it): Iterate out of display property for string iteration as
3612 well.
3613 (iterate_out_of_display_property): Support iteration over strings.
3614 (handle_single_display_spec): Set up it->bidi_it for iteration
3615 over a display string, and call bidi_init_it.
3616 (handle_single_display_spec, next_overlay_string)
3617 (get_overlay_strings_1, push_display_prop): Set up the bidi
3618 iterator for displaying display or overlay strings.
3619 (forward_to_next_line_start): Don't use the shortcut if
3620 bidi-iterating.
3621 (back_to_previous_visible_line_start): If handle_display_prop
3622 pushed the iterator stack, restore the internal state of the bidi
3623 iterator by calling bidi_pop_it same number of times.
3624 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3625 and we are bidi-iterating, don't decrement the iterator position;
3626 instead, set the first_elt flag in the bidi iterator, to produce
3627 the same effect.
3628 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3629 (push_display_prop): xassert that we are iterating a buffer.
3630 (push_it, pop_it): Save and restore paragraph_embedding member.
3631 (handle_single_display_spec, next_overlay_string)
3632 (get_overlay_strings_1, reseat_1, reseat_to_string)
3633 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3634 correctly. Don't assume unibyte strings are not bidi-reordered.
3635 (compute_display_string_pos)
3636 (compute_display_string_end): Fix handling the case of C string.
3637 (push_it, pop_it): Save and restore from_disp_prop_p.
3638 (handle_single_display_spec, push_display_prop): Set the
3639 from_disp_prop_p flag.
3640 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3641 (pop_it): Call iterate_out_of_display_property only if we are
3642 popping after iteration over a string that came from a display
3643 property. Fix a typo in popping stretch info. Add an assertion
3644 for verifying that the iterator position is in sync with the bidi
3645 iterator.
3646 (handle_single_display_spec, get_overlay_strings_1)
3647 (push_display_prop): Fix initialization of paragraph direction for
3648 string when that of the parent object is not yet determined.
3649 (reseat_1): Call bidi_init_it to resync the bidi
3650 iterator with IT's position. (Bug#7616)
3651 (find_row_edges): If ROW->start.pos gives position
3652 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3653 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3654 Reset the from_disp_prop_p flag.
3655 (SAVE_IT, RESTORE_IT): New macros.
3656 (pos_visible_p, face_before_or_after_it_pos)
3657 (back_to_previous_visible_line_start)
3658 (move_it_in_display_line_to, move_it_in_display_line)
3659 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3660 (try_scrolling, redisplay_window, display_line): Use them when
3661 saving a temporary copy of the iterator and restoring it back.
3662 (back_to_previous_visible_line_start, reseat_1)
3663 (init_iterator): Empty the bidi cache "stack".
3664 (move_it_in_display_line_to): If iterator ended up at
3665 EOL, but we never saw any buffer positions smaller than
3666 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3667 motion in bidi-reordered lines.
3668 (move_it_in_display_line_to): Record prev_method and prev_pos
3669 immediately before the call to set_iterator_to_next. Fixes cursor
3670 motion in bidi-reordered lines with stretch glyphs and strings
3671 displayed in margins. (Bug#8133) (Bug#8867)
3672 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3673 TO_CHARPOS.
640c8776
SM
3674 (pos_visible_p): Support positions in bidi-reordered lines.
3675 Save and restore bidi cache.
0bb23927
EZ
3676
3677 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3678 (bidi_paragraph_info): Delete unused struct.
3679 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3680 (bidi_cache_start): New variable.
3681 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3682 to zero.
3683 (bidi_cache_fetch_state, bidi_cache_search)
3684 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3685 (bidi_cache_find, bidi_peek_at_next_level)
3686 (bidi_level_of_next_char, bidi_find_other_level_edge)
3687 (bidi_move_to_visually_next): Compare cache index with
3688 bidi_cache_start rather than with zero.
3689 (bidi_fetch_char): Accept new argument STRING; all callers
3690 changed. Support iteration over a string. Support strings with
3691 display properties. Support unibyte strings. Fix the type of
3692 `len' according to what STRING_CHAR_AND_LENGTH expects.
3693 (bidi_paragraph_init, bidi_resolve_explicit_1)
3694 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3695 (bidi_level_of_next_char, bidi_move_to_visually_next):
3696 Support iteration over a string.
0bb23927
EZ
3697 (bidi_set_sor_type, bidi_resolve_explicit_1)
3698 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3699 can now be zero (for strings); special values 0 and -1 were
3700 changed to -1 and -2, respectively.
3701 (bidi_char_at_pos): New function.
3702 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3703 Call it instead of FETCH_MULTIBYTE_CHAR.
3704 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3705 initialized to valid values.
3706 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3707 values.
3708 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3709 the test for valid cached positions. Fix the logic for looking up
3710 the sentinel state in the cache. GCPRO the Lisp string we are
3711 iterating.
3712 (bidi_push_it, bidi_pop_it): New functions.
3713 (bidi_initialize): Initialize the bidi cache start stack pointer.
3714 (bidi_cache_ensure_space): New function, refactored from part of
3715 bidi_cache_iterator_state. Don't assume the required size is just
3716 one BIDI_CACHE_CHUNK away.
3717 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3718 (bidi_count_bytes, bidi_char_at_pos): New functions.
3719 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3720 always valid if bidi_cache_idx is valid.
3721 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3722 is valid if it's going to be used.
3723 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3724 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3725 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3726 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3727 (bidi_find_other_level_edge, bidi_cache_start_stack):
3728 All variables related to cache indices are now EMACS_INT.
c965adc5 3729
0bb23927
EZ
3730 * dispextern.h (struct bidi_string_data): New structure.
3731 (struct bidi_it): New member `string'. Make flag members be 1-bit
3732 fields, and put them last in the struct.
640c8776
SM
3733 (compute_display_string_pos, compute_display_string_end):
3734 Update prototypes.
0bb23927
EZ
3735 (bidi_push_it, bidi_pop_it): Add prototypes.
3736 (struct iterator_stack_entry): New members bidi_p,
3737 paragraph_embedding, and from_disp_prop_p.
3738 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3739 (bidi_shelve_cache, bidi_unshelve_cache):
3740 Declare prototypes.
0bb23927
EZ
3741
3742 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3743 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3744 and vector-like objects.
3745
3746 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3747 cache around display iteration.
3748
3749 * window.c (Fwindow_end, window_scroll_pixel_based)
3750 (displayed_window_lines, Frecenter): Save and restore the bidi
3751 cache around display iteration.
3752
3bbd2265
LMI
37532011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3754
3755 * editfns.c (Fdelete_region): Clarify the use of the named
3756 parameters (bug#6788).
3757
adc47434
MR
37582011-07-14 Martin Rudalics <rudalics@gmx.at>
3759
3760 * indent.c (Fvertical_motion): Set and restore w->pointm when
3761 saving and restoring the window's buffer (Bug#9006).
3762
837c31f8
LMI
37632011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3764
3765 * editfns.c (Fstring_to_char): Clarify just what is returned
3766 (bug#6576). Text by Eli Zaretskii.
3767
ac389d0c
JB
37682011-07-13 Juanma Barranquero <lekktu@gmail.com>
3769
3770 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3771
0be0ce47
EZ
37722011-07-13 Eli Zaretskii <eliz@gnu.org>
3773
3774 * buffer.c (mmap_find): Fix a typo.
3775
cd18e7e3
JB
37762011-07-13 Johan Bockgård <bojohan@gnu.org>
3777
3778 Fix execution of x selection hooks.
3779 * xselect.c (Qx_lost_selection_functions)
3780 (Qx_sent_selection_functions): New vars.
3781 (syms_of_xselect): DEFSYM them.
3782 (x_handle_selection_request): Pass Qx_sent_selection_functions
3783 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3784 (x_handle_selection_clear,x_clear_frame_selections):
3785 Pass Qx_lost_selection_functions rather than
3786 Vx_lost_selection_functions to Frun_hook_with_args.
3787
47ea7f44
PE
37882011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3789
ac389d0c 3790 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3791 The old code sometimes used this field without initializing it.
3792
47ea7f44
PE
3793 * alloc.c (gc_sweep): Don't read past end of array.
3794 In theory, the old code could also have corrupted Emacs internals,
3795 though it'd be very unlikely.
3796
bc985c87
AS
37972011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3798
3799 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3800 argument. (Bug#4026)
bc985c87 3801
0cf34688
LMI
38022011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3803
b3dadd76
LMI
3804 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3805 key" (bug#4257).
3806
0cf34688
LMI
3807 * window.c (Fset_window_start): Doc fix (bug#4199).
3808 (Fset_window_hscroll): Ditto.
3809
270768cd
PE
38102011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3811
077e3dda 3812 Fix minor new problems caught by GCC 4.6.1.
270768cd 3813 * term.c (init_tty): Remove unused local.
490011a6 3814 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3815 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3816 not used otherwise.
270768cd 3817
b1f58454
CY
38182011-07-12 Chong Yidong <cyd@stupidchicken.com>
3819
3820 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3821
22b9578d
LMI
38222011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3823
6e70ab07
LMI
3824 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3825 are the mini-buffer and the echo area (bug#3320).
3826
22b9578d
LMI
3827 * term.c (init_tty): Remove support for supdup, c10 and perq
3828 terminals, which are no longer supported (bug#1482).
3829
8974cc9f
JB
38302011-07-10 Johan Bockgård <bojohan@gnu.org>
3831
3832 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3833
a560d974
JD
38342011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3835
3836 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3837 for non-popups (Bug#3642).
3838
1dae0f0a
AS
38392011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3840
268c2c36 3841 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3842 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3843 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3844 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3845 * data.c (fmod): Likewise.
3846 * dispnew.c (swap_glyphs_in_rows): Likewise.
3847 * emacs.c (memory_warning_signal): Likewise.
3848 * floatfns.c (float_error): Likewise.
3849 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3850 (otf_open, font_otf_capability, generate_otf_features)
3851 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3852 Likewise.
3853 * image.c (pbm_read_file): Likewise.
3854 * indent.c (string_display_width): Likewise.
3855 * intervals.c (check_for_interval, search_for_interval)
3856 (inc_interval_count, count_intervals, root_interval)
3857 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3858 * lread.c (defalias): Likewise.
268c2c36 3859 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3860 * regex.c (set_image_of_range_1, set_image_of_range)
3861 (regex_grow_registers): Likewise.
3862 * sysdep.c (strerror): Likewise.
3863 * termcap.c (valid_filename_p, tprint, main): Likewise.
3864 * tparam.c (main): Likewise.
3865 * unexhp9k800.c (run_time_remap, save_data_space)
3866 (update_file_ptrs, read_header, write_header, calculate_checksum)
3867 (copy_file, copy_rest, display_header): Likewise.
3868 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3869 Likewise.
3870 * xdisp.c (check_it): Likewise.
3871 * xfaces.c (register_color, unregister_color, unregister_colors):
3872 Likewise.
3873 * xfns.c (print_fontset_result): Likewise.
3874 * xrdb.c (member, fatal, main): Likewise.
3875
99033785
PE
38762011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3877
3878 Fix minor problems found by static checking (Bug#9031).
3879 * chartab.c (char_table_set_range, map_sub_char_table):
3880 Remove unused locals.
3881 (uniprop_table): Now static.
3882 * composite.c (_work_char): Remove unused static var.
3883
9cb2ac56
JB
38842011-07-09 Juanma Barranquero <lekktu@gmail.com>
3885
3886 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3887
f25661f0
JD
38882011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3889
3890 * gtkutil.c (qttip_cb): Remove code without function.
3891
8278c4fe
EZ
38922011-07-09 Eli Zaretskii <eliz@gnu.org>
3893
3894 * w32.c (pthread_sigmask): New stub.
3895
1692ae2d 38962011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3897
8a6ebd58 3898 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3899 sigprocmask is portable only for single-threaded applications, and
3900 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3901 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3902 (LIBES): Use it.
3903 * callproc.c (Fcall_process):
3904 * process.c (create_process):
3905 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3906 Use pthread_sigmask, not sigprocmask.
123403e4 3907
1b854618
JD
39082011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3909
3910 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3911 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3912 wrong (Bug#8591).
3913
3fe4b549
JD
39142011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3915
0ce7e563
JD
3916 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3917 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3918 (xg_hide_tooltip): Fix comment.
3919
3fe4b549
JD
3920 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3921 in registerServicesMenuSendTypes.
3922 (validRequestorForSendType): Don't check ns_return_types.
3923
3924 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3925 ns_return_type.
3926
5df75e47
JR
39272011-07-08 Jason Rumney <jasonr@gnu.org>
3928
22610910
JR
3929 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3930 SH_SHOW for hidden windows (Bug#5482).
3931
5df75e47
JR
3932 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3933 frame struct members of non-existent frames (Bug#6284).
3934
699c10bd
JD
39352011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3936
4393663b
JD
3937 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3938 variable firstTime not needed on OSX >= 10.6.
3939 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3940 >= 10.5. Use setKnobProportion, setDoubleValue.
3941
3942 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3943 (MAC_OS_X_VERSION_10_5): Define if not defined.
3944 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3945 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3946 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3947
3948 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3949 cString and lossyCString on OSX >= 10.4
3950
58179cce 3951 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3952 sizeToFit on OSX >= 10.2.
3953
3954 * nsimage.m (allocInitFromFile): Don't use deprecated method
3955 bestRepresentationForDevice on OSX >= 10.6.
3956
3957 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3958 to avoid warning.
3959
3960 * emacs.c: Declare unexec_init_emacs_zone.
3961
a63e0781
JD
3962 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3963
699c10bd
JD
3964 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3965
3966 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3967 on svcsMenu (Bug#8842).
3968
3969 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3970 ns_return_types.
3971 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3972
3973 * nsterm.m (QUTF8_STRING): Declare.
3974 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3975 (validRequestorForSendType): Return type is (id).
3976 Change indexOfObjectIdenticalTo to indexOfObject.
3977 Check if we have local selection before returning self (Bug#8842).
3978 (writeSelectionToPasteboard): Put local selection into paste board
3979 if we have a local selection (Bug#8842).
3980 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3981
3982 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3983 (ns_get_local_selection): Declare.
3984
54e10184
LMI
39852011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3986
9888ff71
LMI
3987 * keymap.c (describe_map_tree): Don't insert a double newline at
3988 the end of the buffer (bug#1169) and return whether we inserted
3989 something.
3990
54e10184
LMI
3991 * callint.c (Fcall_interactively): Change "reading args" to
3992 "providing args" to try to clarify what it does (bug#1010).
3993
15fa4783
KH
39942011-07-07 Kenichi Handa <handa@m17n.org>
3995
3996 * composite.c (composition_compute_stop_pos): Ignore a static
3997 composition starting before CHARPOS (Bug#8915).
3998
3999 * xdisp.c (handle_composition_prop): Likewise.
4000
a8815b00
EZ
40012011-07-07 Eli Zaretskii <eliz@gnu.org>
4002
4003 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4004 (Bug#9015)
4005
ef7b981d 40062011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4007
4008 * character.h (unicode_category_t): New enum type.
4009
4010 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4011 (Qchar_code_property_table): New variable.
4012 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4013 (UNIPROP_COMPRESSED_FORM_P): New macros.
4014 (char_table_ascii): Uncompress the compressed values.
4015 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4016 Uncompress the compressed values.
ac389d0c 4017 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4018 (char_table_ref_and_range): Uncompress the compressed values.
4019 (sub_char_table_set): New arg is_uniprop. Callers changed.
4020 Uncompress the compressed values.
4021 (sub_char_table_set_range): Args changed. Callers changed.
4022 (char_table_set_range): Adjuted for the above change.
4023 (map_sub_char_table): Delete args default_val and parent. Add arg
4024 top. Give decoded values to a Lisp function.
640c8776 4025 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4026 values to a Lisp function. Gcpro more variables.
4027 (uniprop_table_uncompress)
4028 (uniprop_decode_value_run_length): New functions.
4029 (uniprop_decoder, uniprop_decoder_count): New variables.
4030 (uniprop_get_decoder, uniprop_encode_value_character)
4031 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4032 New functions.
4033 (uniprop_encoder, uniprop_encoder_count): New variables.
4034 (uniprop_get_encoder, uniprop_table)
4035 (Funicode_property_table_internal, Fget_unicode_property_internal)
4036 (Fput_unicode_property_internal): New functions.
4037 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4038 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4039 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4040 char-code-property-alist.
4041
640c8776 4042 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4043 Vunicode_category_table.
4044
640c8776 4045 * font.c (font_range): Adjust for the change of
c805dec0
KH
4046 Vunicode_category_table.
4047
76b397fb
DN
40482011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4049
4050 * m/iris4d.h: Remove file, move contents ...
4051 * s/irix6-5.h: ... here.
4052
22b4128e
PE
40532011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4054
4055 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4056 * alloc.c (mark_buffer):
4057 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4058 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4059 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4060 This isn't true in general, and it's particularly not true
4061 if Emacs is configured with --with-wide-int.
4062 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4063 New macros, used in the buffer.c change.
4064
869795d6
JD
40652011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4066
4067 * xsettings.c: Use both GConf and GSettings if both are available.
4068 (store_config_changed_event): Add comment.
4069 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4070 (store_tool_bar_style_changed): New functions.
5e617bc2 4071 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4072 (struct xsettings): Move font inside HAVE_XFT.
4073 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4074 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4075 Move inside HAVE_XFT.
640c8776 4076 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4077 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4078 also.
4079 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4080 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4081 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4082 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4083 (parse_settings): Move check for font inside HAVE_XFT.
4084 (read_settings, apply_xft_settings): Add comment.
4085 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4086 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4087 call store_font_name_changed.
4088 (xft_settings_event): Add comment.
4089 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4090 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4091 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4092 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4093 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4094 (xsettings_get_system_font, xsettings_get_system_normal_font):
4095 Add comment.
869795d6 4096
d8ed26bd
PE
40972011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4098
4099 Random fixes. E.g., (random) never returned negative values.
4100 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4101 subseconds part to the entropy, as that's a bit more random.
4102 Prefer signed to unsigned, since the signedness doesn't matter and
4103 in general we prefer signed. When given a limit, use a
4104 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4105 latter isn't right if USE_2_TAGS_FOR_INTS.
4106 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4107 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4108
cabf1cac
SM
41092011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4110
4111 * textprop.c (text_property_stickiness):
4112 Obey Vtext_property_default_nonsticky.
4113 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4114 * w32fns.c (syms_of_w32fns):
4115 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4116
6e9b2be9
PE
41172011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4118
4119 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4120 This is more efficient than Ffile_directory_p and avoids a minor race.
4121
90186c68
LMI
41222011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4123
7c301272
LMI
4124 * buffer.c (Foverlay_put): Say what the return value is
4125 (bug#7835).
4126
c4f2d8d4
LMI
4127 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4128 is a directory before asking whether to use the file name
4129 (bug#7564).
ad637907
LMI
4130 (barf_or_query_if_file_exists): Make the "File is a directory"
4131 error be more correct.
c4f2d8d4 4132
90186c68
LMI
4133 * fns.c (Frequire): Remove the mention of the .gz files, since
4134 that's installation-specific, but keep the mention of
4135 `get-load-suffixes'.
4136
da64016e
PE
41372011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4138
4139 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4140 Report string overflow if the output is too long.
4141
7d47b580
JB
41422011-07-04 Juanma Barranquero <lekktu@gmail.com>
4143
a555cb87
JB
4144 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4145 (syms_of_gnutls): Remove duplicate DEFSYM for
4146 Qgnutls_bootprop_verify_hostname_error, an error for
4147 Qgnutls_bootprop_verify_error (which is no longer used).
4148
7d47b580
JB
4149 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4150 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4151 Also (re)move comments that are misplaced or no longer relevant.
4152
1e49bfab
LMI
41532011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4154
4155 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4156
1485f4c0
CY
41572011-07-03 Chong Yidong <cyd@stupidchicken.com>
4158
4159 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4160 and background color parameters if they have been changed.
4161
a9ab721e
LMI
41622011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4163
4164 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4165
cf7cff57
PE
41662011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4167
2e13213d
PE
4168 * xsettings.c (SYSTEM_FONT): Define only when used.
4169 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4170
cf7cff57
PE
4171 * keymap.c (access_keymap_1): Now static.
4172
7a8e04f7
CY
41732011-07-02 Chong Yidong <cyd@stupidchicken.com>
4174
4175 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4176 leave any prefix arg for the up event (Bug#1586).
4177
61352f62
LMI
41782011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4179
69bb1ef7
LMI
4180 * lread.c (syms_of_lread): Mention single symbols defined by
4181 `defvar' or `defconst' (bug#7154).
4182
61352f62 4183 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4184 (Frequire): Mention get-load-suffixes.
61352f62 4185
28545e04
MR
41862011-07-02 Martin Rudalics <rudalics@gmx.at>
4187
4188 * window.h (window): Remove clone_number slot.
4189 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4190 Remove.
4191 (make_parent_window, make_window, saved_window)
4192 (Fset_window_configuration, save_window_save): Don't deal with
4193 clone numbers.
4194 * buffer.c (Qclone_number): Remove declaration.
4195 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4196
3349e122
SM
41972011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4198
4199 Add multiple inheritance to keymaps.
4200 * keymap.c (Fmake_composed_keymap): New function.
4201 (Fset_keymap_parent): Simplify.
4202 (fix_submap_inheritance): Remove.
4203 (access_keymap_1): New function extracted from access_keymap to handle
4204 embedded parents and handle lists of maps.
4205 (access_keymap): Use it.
4206 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4207 (Fcopy_keymap): Handle embedded parents.
4208 (Fcommand_remapping, define_as_prefix): Simplify.
4209 (Fkey_binding): Simplify.
4210 (syms_of_keymap): Move minibuffer-local-completion-map,
4211 minibuffer-local-filename-completion-map,
4212 minibuffer-local-must-match-map, and
4213 minibuffer-local-filename-must-match-map to Elisp.
4214 (syms_of_keymap): Defsubr make-composed-keymap.
4215 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4216 (parse_menu_item): Trivial simplification.
4217
3279eb87
GM
42182011-07-01 Glenn Morris <rgm@gnu.org>
4219
4220 * Makefile.in (SETTINGS_LIBS): Fix typo.
4221
4550efdf
KI
42222011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4223
4224 * coding.c (Fencode_coding_string): Record the last coding system
4225 used, as the function doc string says (bug#8738).
4226
0949d2b6
JD
42272011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4228
4229 * xsettings.c (store_monospaced_changed): Take new font as arg and
4230 check for change against current_mono_font.
4231 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4232 (emacs_settings_constructor, emacs_settings_get_property)
4233 (emacs_settings_set_property, emacs_settings_class_init)
4234 (emacs_settings_init, gsettings_obj): Remove.
4235 (something_changedCB): New function for HAVE_GSETTINGS.
4236 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4237 with value as argument.
4238 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4239 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4240 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4241 "changed".
4242
4243 * xgselect.c: Add defined (HAVE_GSETTINGS).
4244 (xgselect_initialize): Ditto.
4245
4246 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4247 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4248 xg_select.
4249
bbc6b304
PE
42502011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4251
4252 * eval.c (struct backtrace): Simplify and port the data structure.
4253 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4254 signed bit field, as this assumption is not portable and it makes
4255 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4256 "char debug_on_exit : 1" as this is not portable either; instead,
4257 use the portable "unsigned int debug_on_exit : 1". Remove unused
4258 member evalargs. Remove obsolete comments about cc bombing out.
4259
9851bfc5
JD
42602011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4261
51bb811f 4262 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4263 Let HAVE_GSETTINGS override HAVE_GCONF.
4264 (store_monospaced_changed): New function.
4265 (EMACS_SETTINGS): A new type derived from GObject to handle
4266 GSettings notifications.
4267 (emacs_settings_constructor, emacs_settings_get_property)
4268 (emacs_settings_set_property, emacs_settings_class_init):
4269 New functions.
4270 (gsettings_client, gsettings_obj): New variables.
4271 (GSETTINGS_SCHEMA): New define.
4272 (something_changedCB): Call store_monospaced_changed.
4273 (init_gsettings): New function.
4274 (xsettings_initialize): Call init_gsettings.
4275 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4276 to NULL.
4277
640c8776 4278 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4279 GCONF_CFLAGS/LIBS.
4280
5386012d
MR
42812011-06-29 Martin Rudalics <rudalics@gmx.at>
4282
4283 * window.c (resize_root_window, grow_mini_window)
4284 (shrink_mini_window): Rename Qresize_root_window to
4285 Qwindow_resize_root_window and Qresize_root_window_vertically to
4286 Qwindow_resize_root_window_vertically.
4287
f13e0b08
PE
42882011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4289
4290 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4291
94515237
JB
42922011-06-27 Juanma Barranquero <lekktu@gmail.com>
4293
4294 * makefile.w32-in: Redesign dependencies so they reflect more
4295 clearly which files are directly included by each source file,
4296 and not through other includes.
4297
e43b6e43
MR
42982011-06-27 Martin Rudalics <rudalics@gmx.at>
4299
4300 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4301 (sort_overlays, overlay_strings): When an overlay's clone number
4302 matches the window's clone number process the overlay even if
4303 the overlay's window property doesn't match the current window.
4304
d68443dc
MR
4305 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4306 (Fwindow_hchild): Rename to Fwindow_left_child.
4307 (Fwindow_next): Rename to Fwindow_next_sibling.
4308 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4309 (resize_window_check): Rename to window_resize_check.
4310 (resize_window_apply): Rename to window_resize_apply.
4311 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4312 (Fdelete_other_windows_internal, resize_frame_windows)
4313 (Fsplit_window_internal, Fdelete_window_internal)
4314 (grow_mini_window, shrink_mini_window)
4315 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4316
c7e73be5
JD
43172011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4318
4319 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4320 (emacs_fixed_set_min_size): Remove.
4321 (emacs_fixed_new): Take frame as argument.
4322
4323 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4324 (_EmacsFixedPrivate): Remove minwidth/height.
4325 Add struct frame *f.
4326 (emacs_fixed_init): Initialize priv->f.
4327 (get_parent_class, emacs_fixed_set_min_size): Remove.
4328 (emacs_fixed_new): Set priv->f to argument.
4329 (emacs_fixed_get_preferred_width)
4330 (emacs_fixed_get_preferred_height): Use min_width/height from
4331 frames size_hint to set minimum and natural (Bug#8919).
4332 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4333 and use min_width/height from frames size_hint to set
4334 min_width/height (Bug#8919).
4335
4336 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4337 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4338 Fix indentation.
c7e73be5 4339
cf99dcf8
EZ
43402011-06-26 Eli Zaretskii <eliz@gnu.org>
4341
4342 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4343 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4344 called at ZV.
4345
029529ac
CY
43462011-06-26 Chong Yidong <cyd@stupidchicken.com>
4347
4348 * process.c (wait_reading_process_output): Bypass select if
4349 waiting for a cell while ignoring keyboard input, and input is
4350 pending. Suggested by Jan Djärv (Bug#8869).
4351
7a7ef429
PE
43522011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4353
4354 Use gnulib's dup2 module instead of rolling our own.
4355 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4356
11fdef7d 43572011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4358
4359 * dispnew.c (scrolling_window): Before scrolling, turn off a
4360 mouse-highlight in the window being scrolled.
4361
cd3520a4
JB
43622011-06-24 Juanma Barranquero <lekktu@gmail.com>
4363
4364 Move DEFSYM to lisp.h and use everywhere.
4365
4366 * character.h (DEFSYM): Move declaration...
4367 * lisp.h (DEFSYM): ...here.
4368
4369 * gnutls.c:
4370 * minibuf.c:
4371 * w32menu.c:
4372 * w32proc.c:
4373 * w32select.c: Don't include character.h.
4374
4375 * alloc.c (syms_of_alloc):
4376 * buffer.c (syms_of_buffer):
4377 * bytecode.c (syms_of_bytecode):
4378 * callint.c (syms_of_callint):
4379 * casefiddle.c (syms_of_casefiddle):
4380 * casetab.c (init_casetab_once):
4381 * category.c (init_category_once, syms_of_category):
4382 * ccl.c (syms_of_ccl):
4383 * cmds.c (syms_of_cmds):
4384 * composite.c (syms_of_composite):
4385 * dbusbind.c (syms_of_dbusbind):
4386 * dired.c (syms_of_dired):
4387 * dispnew.c (syms_of_display):
4388 * doc.c (syms_of_doc):
4389 * editfns.c (syms_of_editfns):
4390 * emacs.c (syms_of_emacs):
4391 * eval.c (syms_of_eval):
4392 * fileio.c (syms_of_fileio):
4393 * fns.c (syms_of_fns):
4394 * frame.c (syms_of_frame):
4395 * fringe.c (syms_of_fringe):
4396 * insdel.c (syms_of_insdel):
4397 * keymap.c (syms_of_keymap):
4398 * lread.c (init_obarray, syms_of_lread):
4399 * macros.c (syms_of_macros):
4400 * msdos.c (syms_of_msdos):
4401 * print.c (syms_of_print):
4402 * process.c (syms_of_process):
4403 * search.c (syms_of_search):
4404 * sound.c (syms_of_sound):
4405 * syntax.c (init_syntax_once, syms_of_syntax):
4406 * terminal.c (syms_of_terminal):
4407 * textprop.c (syms_of_textprop):
4408 * undo.c (syms_of_undo):
4409 * w32.c (globals_of_w32):
4410 * window.c (syms_of_window):
4411 * xdisp.c (syms_of_xdisp):
4412 * xfaces.c (syms_of_xfaces):
4413 * xfns.c (syms_of_xfns):
4414 * xmenu.c (syms_of_xmenu):
4415 * xsettings.c (syms_of_xsettings):
4416 * xterm.c (syms_of_xterm): Use DEFSYM.
4417
4228cf16
TZ
44182011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4419
cd3520a4 4420 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4421
7fcccf1e
PE
44222011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4423
7efb4e0e
PE
4424 Integer and buffer overflow fixes (Bug#8873).
4425
ff5844ad
PE
4426 * print.c (printchar, strout): Check for string overflow.
4427 (PRINTPREPARE, printchar, strout):
4428 Don't set size unless allocation succeeds.
4429
90532f02
PE
4430 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4431 for sizes. Check for string overflow more accurately.
4432 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4433
6d84508d
PE
4434 * macros.c: Integer and buffer overflow fixes.
4435 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4436 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4437 Use ptrdiff_t, not int, for sizes.
4438 Don't increment bufsize until after realloc succeeds.
4439 Check for size-calculation overflow.
4440 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4441
437b2cb4
PE
4442 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4443
8b9ac8b4
PE
4444 * lread.c: Integer overflow fixes.
4445 (read_integer): Radix is now EMACS_INT, not int,
4446 to improve quality of diagnostics for out-of-range radices.
4447 Calculate buffer size correctly for out-of-range radices.
4448 (read1): Check for integer overflow in radices, and in
4449 read-circle numbers.
82cb60d3
PE
4450 (read_escape): Avoid int overflow.
4451 (Fload, openp, read_buffer_size, read1)
4452 (substitute_object_recurse, read_vector, read_list, map_obarray):
4453 Use ptrdiff_t, not int, for sizes.
4454 (read1): Use EMACS_INT, not int, for sizes.
20270765 4455 Check for size overflow.
8b9ac8b4 4456
7fcccf1e
PE
4457 * image.c (cache_image): Check for size arithmetic overflow.
4458
bfbbd7e7
PE
4459 * lread.c: Integer overflow issues.
4460 (saved_doc_string_size, saved_doc_string_length)
4461 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4462 Now ptrdiff_t, not int.
4463 (read1): Don't assume doc string length fits in int. Check for
4464 out-of-range doc string lengths.
4465 (read_list): Don't assume file position fits in int.
39019e54 4466 (read_escape): Check for hex character overflow.
bfbbd7e7 4467
4e323265
LL
44682011-06-22 Leo Liu <sdl.web@gmail.com>
4469
4470 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4471 Move to minibuffer.el.
4472
85fece3e
PE
44732011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4474
20b84ce9 4475 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4476 The following patches are for when GLYPH_DEBUG && !XASSERT.
4477 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4478 * dispnew.c (flush_stdout):
4479 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4480 Mark as externally visible.
4481 * dispnew.c (check_window_matrix_pointers): Now static.
4482 * dispnew.c (window_to_frame_vpos):
4483 * xfns.c (unwind_create_frame):
4484 * xterm.c (x_check_font): Remove unused local.
4485 * scroll.c (CHECK_BOUNDS):
4486 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4487 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4488 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4489 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4490 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4491 Now static.
4492 (debug_method_add): Use va_list and vsprintf rather than relying
4493 on undefined behavior with wrong number of arguments.
4494 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4495 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4496 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4497 since we're not interested in debugging glyphs with old libraries.
4498 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4499 GCC 4.6.0's static checking.
4500
0766b489
PE
45012011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4502
31fd4b32
PE
4503 Integer overflow and signedness fixes (Bug#8873).
4504 A few related buffer overrun fixes, too.
4505
b79e8648
PE
4506 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4507
0766b489
PE
4508 * dispextern.h (struct face.stipple):
4509 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4510 (x_bitmap_mask, x_allocate_bitmap_record)
4511 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4512 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4513 (x_create_bitmap_from_xpm_data):
4514 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4515 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4516 (.bitmaps_last):
4517 * xfaces.c (load_pixmap):
4518 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4519 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4520 (.bitmaps_last, struct x_output.icon_bitmap):
4521 Use ptrdiff_t, not int, for bitmap indexes.
4522 (x_allocate_bitmap_record): Check for size overflow.
4523 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4524
b081724f
PE
4525 Use ptrdiff_t, not int, for overlay counts.
4526 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4527 * editfns.c (overlays_around, get_pos_property):
4528 * textprop.c (get_char_property_and_overlay):
4529 * xdisp.c (next_overlay_change, note_mouse_highlight):
4530 * xfaces.c (face_at_buffer_position):
21514da7
PE
4531 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4532 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4533 (Fnext_overlay_change, Fprevious_overlay_change)
4534 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4535 Use ptrdiff_t, not int, for sizes.
21514da7 4536 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4537
3de73e5e
PE
4538 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4539
2606c57b
PE
4540 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4541 (x_session_initialize): Do not assume string length fits in int.
4542
aaafe47a
PE
4543 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4544 This is unlikely, but can occur if DPI is outlandish.
4545
2674ddc8 4546 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4547 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4548
28154962
PE
4549 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4550 * xrdb.c (magic_file_p, search_magic_path):
4551 Omit last arg SUFFIX; it was always 0. All callers changed.
4552 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4553
7de51af5
PE
4554 * xfont.c (xfont_match): Avoid need for strlen.
4555
25ed6cc3
PE
4556 * xfns.c: Don't assume strlen fits in int.
4557 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4558
4eab31dd
PE
4559 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4560 not unsigned long, as we prefer signed integers. All callers changed.
4561 Detect integer overflow in repeat count.
4562 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4563 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4564
171e2a58
PE
4565 * termcap.c: Don't assume sizes fit in int and never overflow.
4566 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4567 (gobble_line): Check for size-calculation overflow.
4568
ad39faca 4569 * minibuf.c (Fread_buffer):
6e5bb2dc 4570 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4571 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4572 Don't assume string length fits in int.
4573
52c61c22 4574 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4575 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4576
b5b8c9e5
PE
4577 * font.c: Don't assume string length fits in int.
4578 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4579 Use ptrdiff_t, not int.
ccd6111c
PE
4580 (font_intern_prop): Don't assume string length fits in int.
4581 Don't assume integer property fits in fixnum.
4582 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4583
882f0d81 4584 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4585 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4586 Reformulate so as not to need the command string.
4587 Invoke gzip -cd rather than gunzip, as it's more portable.
4588 (lock_info_type, lock_file_1, lock_file):
4589 Don't assume pid_t and time_t fit in unsigned long.
4590 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4591 (current_lock_owner): Prefer signed type for sizes.
4592 Use memcpy, not strncpy, where memcpy is what is really wanted.
4593 Don't assume (via atoi) that time_t and pid_t fit in int.
4594 Check for time_t and/or pid_t out of range, e.g., via a network share.
4595 Don't alloca where an auto var works fine.
4596
93f4cf88
PE
4597 * fileio.c: Fix some integer overflow issues.
4598 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4599 Don't assume string length fits in int.
4600 (directory_file_name): Don't assume string length fits in long.
4601 (make_temp_name): Don't assume pid fits in int, or that its print
4602 length is less than 20.
4603
f3e92b69
PE
4604 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4605
1bfdaf10
PE
4606 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4607
35016e9a
PE
4608 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4609
3d1e65a1
PE
4610 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4611 We prefer signed integers, even for size calculations.
4612
0b963a93
PE
4613 * emacs.c: Don't assume string length fits in 'int'.
4614 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4615 (main): Don't invoke strlen when not needed.
4616
573f4b54
PE
4617 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4618 (XD_DEBUG_MESSAGE): Don't waste a byte.
4619
989f33ba
PE
4620 * callproc.c (getenv_internal_1, getenv_internal)
4621 (Fgetenv_internal):
965d34eb
PE
4622 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4623
e4d29b33
PE
4624 * lread.c (invalid_syntax): Omit length argument.
4625 All uses changed. This doesn't fix a bug, but it simplifies the
4626 code away from its former Hollerith-constant appearance, and it's
4627 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4628 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4629
eb49b136
PE
4630 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4631 This didn't break anything, but it didn't help either.
4632 It's confusing to put a bogus integer in a place where the actual
4633 value does not matter.
9f62aeb1 4634 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4635 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4636
15375a22
PE
4637 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4638 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4639 implementation.
b61cc01c
PE
4640 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4641 We prefer signed types, and the value cannot exceed the EMACS_INT
4642 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4643 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4644 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4645 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4646
53b2623d
PE
4647 * indent.c (sane_tab_width): New function.
4648 (current_column, scan_for_column, Findent_to, position_indentation)
4649 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4650 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4651
51cab52b 4652 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4653
f2ed8a70
PE
4654 * lisp.h (lint_assume): New macro.
4655 * composite.c (composition_gstring_put_cache):
4656 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4657
abe80cc6
PE
4658 * editfns.c, insdel.c:
4659 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4660
b02c740e
PE
4661 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4662
ebc96716
PE
4663 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4664
b4e50fa0 4665 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4666 Use much-faster test for byte-length change.
311d5d7c 4667 Don't assume string byte-length fits in 'int'.
a4cf38e4 4668 Check that character arg fits in 'int'.
85461888 4669 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4670
c0c1ee9f
PE
4671 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4672
a498d7f4
PE
4673 * fns.c (concat): Catch string overflow earlier.
4674 Do not rely on integer wraparound.
4675
51cab52b
PE
4676 * dispextern.h (struct it.overlay_strings_charpos)
4677 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4678 * xdisp.c (forward_to_next_line_start)
4679 (back_to_previous_visible_line_start)
4680 (reseat_at_next_visible_line_start, next_element_from_buffer):
4681 Don't arbitrarily truncate the value of 'selective' to int.
4682
76031fad
PE
4683 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4684
5eb55db9
PE
4685 * composite.c: Don't truncate sizes to 'int'.
4686 (composition_gstring_p, composition_reseat_it)
4687 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4688 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4689 not EMACS_UINT, for indexes.
5eb55db9 4690
0703a717
PE
4691 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4692
d6202519
PE
4693 * buffer.c: Include <verify.h>.
4694 (struct sortvec.priority, struct sortstr.priority):
8961a454 4695 Now EMACS_INT, not int.
c20998a7 4696 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4697 (struct sortstr.size, record_overlay_string)
4698 (struct sortstrlist.size, struct sortlist.used):
4699 Don't truncate size to int.
4700 (record_overlay_string): Check for size-calculation overflow.
d6202519 4701 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4702
d5a19415
JM
47032011-06-22 Jim Meyering <meyering@redhat.com>
4704
029529ac 4705 Don't leak an XBM-image-sized buffer
d5a19415
JM
4706 * image.c (xbm_load): Free the image buffer after using it.
4707
a9041e6c
PE
47082011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4709
4710 Port to Sun C.
4711 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4712 that Sun C diagnosed.
4713 * fns.c (secure_hash): Fix pointer signedness issue.
4714 * intervals.c (static_offset_intervals): New function.
4715 (offset_intervals): Use it.
4716
7f3f739f
LL
47172011-06-21 Leo Liu <sdl.web@gmail.com>
4718
4719 * deps.mk (fns.o):
4720 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4721 sha512.h.
4722
4723 * fns.c (secure_hash): Rename from crypto_hash_function and change
4724 the first arg to accept symbols.
5b66d427 4725 (Fsecure_hash): New primitive.
7f3f739f
LL
4726 (syms_of_fns): New symbols.
4727
76147d94
DD
47282011-06-20 Deniz Dogan <deniz@dogan.se>
4729
4730 * process.c (Fset_process_buffer): Clarify return value in
4731 docstring.
4732
7d7d0045
CY
47332011-06-18 Chong Yidong <cyd@stupidchicken.com>
4734
4735 * dispnew.c (add_window_display_history): Use BVAR.
4736
4737 * xdisp.c (debug_method_add): Use BVAR.
4738 (check_window_end, dump_glyph_matrix, dump_glyph)
4739 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4740
4741 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4742 Likewise.
4743
4744 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4745 check till after the cache is created in init_frame_faces.
4746
ff2bc410
SM
47472011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4748
4749 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4750
28177add
PE
47512011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4752
dd3482fe
PE
4753 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4754 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4755 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4756
393d71f3 4757 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4758 * fileio.c (Finsert_file_contents):
4759 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4760 Remove the old (too-loose) buffer overflow checks.
4761 They weren't needed, since make_gap checks for buffer overflow.
4762 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4763 The old code merely checked for Emacs fixnum overflow, and relied
4764 on undefined (wraparound) behavior. The new code avoids undefined
4765 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4766
2e6813b0 4767 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4768 Tune. Don't use wider integers than needed. Don't use alloca.
4769 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4770
599a9e4f
PE
4771 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4772
99561444
PE
4773 * insdel.c, lisp.h (buffer_overflow): New function.
4774 (insert_from_buffer_1, replace_range, replace_range_2):
4775 * insdel.c (make_gap_larger):
4776 * editfns.c (Finsert_char):
4777 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4778
28177add
PE
4779 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4780
e69dafad
PE
47812011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4782
4baa020d 4783 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4784
b1c46f02
PE
4785 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4786 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4787
e69dafad
PE
4788 * fileio.c: Don't assume EMACS_INT fits in off_t.
4789 (emacs_lseek): New static function.
4790 (Finsert_file_contents, Fwrite_region): Use it.
4791 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4792
566684ea
PE
4793 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4794
e6966cd6
PE
4795 * fns.c: Don't overflow int when computing a list length.
4796 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4797 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4798 truncation on 64-bit hosts. Check for QUIT every
4799 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4800 faster and is responsive enough.
4801 (Flength): Report an error instead of overflowing an integer.
4802 (Fsafe_length): Return a float if the value is not representable
4803 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4804 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4805 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4806
dd0b0efb
PE
4807 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4808 (header_size, word_size): New constants.
4809 (allocate_vectorlike): Don't check size overflow here.
4810 (allocate_vector): Check it here instead, since this is the only
4811 caller of allocate_vectorlike that could cause overflow.
4812 Check that the new vector's length is representable as a fixnum.
4813
86fe5cfe
PE
4814 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4815 The previous code was bogus. For example, next_almost_prime (32)
4816 returned 39, which is undesirable as it is a multiple of 3; and
4817 next_almost_prime (24) returned 25, which is a multiple of 5 so
4818 why was the code bothering to check for multiples of 7?
4819
80e88859
PE
4820 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4821
4a2f0ad6
PE
4822 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4823
f66c7cf8
PE
4824 Variadic C functions now count arguments with ptrdiff_t.
4825 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4826 Back then I didn't know that the Emacs coding style prefers signed int.
4827 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4828 were being counted with int, which may truncate counts on 64-bit
4829 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4830 * lisp.h (struct Lisp_Subr.function.aMANY)
4831 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4832 Arg counts are now ptrdiff_t, not size_t.
4833 All variadic functions and their callers changed accordingly.
4834 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4835 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4836 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4837 * callint.c (Fcall_interactively): Check arg count for overflow,
4838 to avoid potential buffer overrun. Use signed char, not 'int',
4839 for 'varies' array, so that we needn't bother to check its size
4840 calculation for overflow.
4841 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4842 * eval.c (apply_lambda):
4843 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4844 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4845 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4846
a1759b76
PE
4847 * callint.c (Fcall_interactively): Don't use index var as event count.
4848
d96be9fc
PE
4849 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4850 * mem-limits.h (SIZE): Remove; no longer used.
4851
a690a978 4852 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4853
578c21e6
PE
4854 Remove unnecessary casts.
4855 * xterm.c (x_term_init):
4856 * xfns.c (x_set_border_pixel):
4857 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4858 These aren't needed now that we assume ANSI C.
4859
96f53c6c
PE
4860 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4861 It's more likely to cause problems (due to unsigned overflow)
4862 than to cure them.
4863
83c77d31
PE
4864 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4865
ee2079f1
PE
4866 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4867
6da65536
PE
4868 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4869
7147c4a4
PE
4870 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4871
193e32d9
PE
4872 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4873
e5533da6
PE
4874 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4875
9910e595
PE
4876 GLYPH_CODE_FACE returns EMACS_INT, not int.
4877 * dispextern.h (merge_faces):
4878 * xfaces.c (merge_faces):
01103c44
PE
4879 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4880 Don't assume EMACS_INT fits in int.
9910e595 4881
2638320e
PE
4882 * character.h (CHAR_VALID_P): Remove unused parameter.
4883 * fontset.c, lisp.h, xdisp.c: All uses changed.
4884
045eb8d9
PE
4885 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4886
c1f134b5
PE
4887 * fns.c (concat): Minor tuning based on overflow analysis.
4888 This doesn't fix any bugs. Use int to hold character, instead
4889 of constantly refetching from Emacs object. Use XFASTINT, not
4890 XINT, for value known to be a character. Don't bother comparing
4891 a single byte to 0400, as it's always less.
4892
395fcb93 4893 * floatfns.c (Fexpt):
327eeec8
PE
4894 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4895
abbd3d23
PE
4896 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4897 for characters.
4898
684a03ef
PE
4899 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4900
0fed43f3
PE
4901 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4902 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4903 incorrectly succeed when S was a string, because 4294967386 was
4904 truncated before it was used.
4905
8fd02eb7
PE
4906 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4907 Otherwise, an out-of-range integer could cause undefined behavior
4908 on a 64-bit host.
4909
f8c86b69
PE
4910 * composite.c: Use int, not EMACS_INT, for characters.
4911 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4912 EMACS_INT, for values that are known to be in character range.
4913 This doesn't fix any bugs but is the usual style inside Emacs and
4914 may generate better code on 32-bit machines.
4915
34206dd2
PE
4916 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4917 This is for reasons similar to the recent CHAR_STRING fix.
4918 * charset.c (Fencode_char): Check that character arg is actually
4919 a character. Pass an int to ENCODE_CHAR.
4920 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4921 wider than 'int', as a compile-time check to prevent future regressions
4922 in this area.
4923
c5958d4c 4924 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4925
4926 Make sure a 64-bit char is never passed to CHAR_STRING.
4927 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4928 by silently ignoring the top 32 bits, allowing some values
4929 that were far too large to be valid characters.
4930 * character.h: Include <verify.h>.
4931 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4932 arguments are no wider than unsigned, as a compile-time check
4933 to prevent future regressions in this area.
4934 * data.c (Faset):
01103c44 4935 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4936 (Fsubst_char_in_region):
4937 * fns.c (concat):
4938 * xdisp.c (decode_mode_spec_coding):
4939 Adjust to CHAR_STRING's new requirement.
4940 * editfns.c (Finsert_char, Fsubst_char_in_region):
4941 * fns.c (concat): Check that character args are actually
4942 characters. Without this test, these functions did the wrong
4943 thing with wildly out-of-range values on 64-bit hosts.
4944
d37ca623
PE
4945 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4946 These casts should not be needed on 32-bit hosts, either.
4947 * keyboard.c (read_char):
4948 * lread.c (Fload): Remove casts to unsigned.
4949
ea204efb
PE
4950 * lisp.h (UNSIGNED_CMP): New macro.
4951 This fixes comparison bugs on 64-bit hosts.
4952 (ASCII_CHAR_P): Use it.
4953 * casefiddle.c (casify_object):
01103c44 4954 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4955 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4956 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4957 * dispextern.h (FACE_FROM_ID):
4958 * keyboard.c (read_char): Use UNSIGNED_CMP.
4959
41cb286c
PE
4960 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4961 not to EMACS_INT, to avoid GCC warning.
4962
4a1b9832
PE
4963 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4964
55daad71
PE
4965 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4966 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4967 isn't needed on 32-bit machines.
8f95c75c 4968
01103c44
PE
4969 * buffer.c (Fgenerate_new_buffer_name):
4970 Use EMACS_INT for count, not int.
0ceccced 4971 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4972
4973 * data.c (Qcompiled_function): Now static.
4974
c6f072e7
PE
4975 * window.c (window_body_lines): Now static.
4976
20ce5912
PE
4977 * image.c (gif_load): Rename local to avoid shadowing.
4978
9c4c5f81
PE
4979 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4980 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4981 * alloc.c (make_save_value): Integer argument is now of type
4982 ptrdiff_t, not int.
4983 (mark_object): Use ptrdiff_t, not int.
4984 * lisp.h (pD): New macro.
4985 * print.c (print_object): Use it.
4986
c0c5c8ae
PE
4987 * alloc.c: Use EMACS_INT, not int, to count objects.
4988 (total_conses, total_markers, total_symbols, total_vector_size)
4989 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4990 (total_free_floats, total_floats, total_free_intervals)
4991 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4992 Now EMACS_INT, not int. All uses changed.
4993 (Fgarbage_collect): Compute overall total using a double, so that
4994 integer overflow is less likely to be a problem. Check for overflow
4995 when converting back to an integer.
5a25e253
PE
4996 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4997 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4998 These were 'int' variables that could overflow on 64-bit hosts;
4999 they were never used, so remove them instead of repairing them.
211a0b2a 5000 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5001 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5002 Previously, this ceilinged at INT_MAX, but that doesn't work on
5003 64-bit machines.
e46bb31a 5004 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5005
c78baabf 5006 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5007 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5008 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5009 when a (possibly-narrower) signed value would do just as well.
5010 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5011
c9d624c6
PE
5012 * alloc.c: Catch some string size overflows that we were missing.
5013 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5014 for convenience in STRING_BYTES_MAX.
5015 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5016 The definition here is exact; the one in lisp.h was approximate.
5017 (allocate_string_data): Check for string overflow. This catches
5018 some instances we weren't catching before. Also, it catches
5019 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5020 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5021 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5022
c9d624c6
PE
5023 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5024 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5025 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5026
353032ce
PE
5027 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5028
2bccce07
PE
5029 * alloc.c (Fmake_string): Check for out-of-range init.
5030
0ac30604
SM
50312011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5032
5033 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5034
c195f2de
JD
50352011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5036
5037 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5038 xg_get_default_scrollbar_width.
5039
5040 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5041 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5042 (style_changed_cb): Call update_theme_scrollbar_width and call
5043 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5044 all frames (Bug#8505).
5045 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5046 Call gtk_window_set_resizable if HAVE_GTK3.
5047 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5048 and height if HAVE_GTK3 (Bug#8505).
5049 (scroll_bar_width_for_theme): New variable.
5050 (update_theme_scrollbar_width): New function.
5051 (xg_get_default_scrollbar_width): Move code to
5052 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5053 (xg_initialize): Call update_theme_scrollbar_width.
5054
5055 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5056
5057 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5058
e10ac9f1
MR
50592011-06-12 Martin Rudalics <rudalics@gmx.at>
5060
5061 * frame.c (make_frame): Call other_buffer_safely instead of
5062 other_buffer.
5063
5064 * window.c (temp_output_buffer_show): Call display_buffer with
5065 second argument Vtemp_buffer_show_specifiers and reset latter
5066 immediately after the call.
5067 (Vtemp_buffer_show_specifiers): New variable.
5068 (auto_window_vscroll_p, next_screen_context_lines)
5069 (Vscroll_preserve_screen_position): Remove leading asterisks from
5070 doc-strings.
5071
2d3c217e 50722011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5073
7b7f97e8 5074 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5075 * buffer.c (Qclone_number): Remove for now, as it's unused.
5076 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5077 (record_buffer): Remove unused local.
5078 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5079 (set_frame_buffer_list): Remove; unused.
5080 * frame.h (other_visible_frames): Remove decl.
5081 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5082 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5083 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5084 if HAVE_GPM.
5085 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5086 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5087 Define only if HAVE_GPM.
5088 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5089 (update_hints_inhibit): Remove; never set. All uses removed.
5090 * widgetprv.h (emacsFrameClassRec): Remove decl.
5091 * window.c (delete_deletable_window): Now returns void, since it
5092 wasn't returning anything.
5093 (compare_window_configurations): Remove unused locals.
5094 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5095 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5096 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5097 the same widths as pointers. This follows up on the 2011-05-06 patch.
5098 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5099 * xterm.h: Likewise.
5100 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5101
1384b89e
JB
51022011-06-12 Juanma Barranquero <lekktu@gmail.com>
5103
5104 * makefile.w32-in: Update dependencies.
5105 (LISP_H): Add lib/intprops.h.
5106
1100a63c
CY
51072011-06-11 Chong Yidong <cyd@stupidchicken.com>
5108
5109 * image.c (gif_load): Add animation frame delay to the metadata.
5110 (syms_of_image): Use DEFSYM. New symbol `delay'.
5111
6198ccd0
MR
51122011-06-11 Martin Rudalics <rudalics@gmx.at>
5113
5114 * window.c (delete_deletable_window): Re-add.
5115 (Fset_window_configuration): Rewrite to handle dead buffers and
5116 consequently deletable windows.
5117 (window_tree, Fwindow_tree): Remove. Supply functionality in
5118 window.el.
5119 (compare_window_configurations): Simplify code.
5120
b6e3633c
AS
51212011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5122
1ab0dee5
AS
5123 * image.c (imagemagick_load_image): Fix type mismatch.
5124 (Fimagemagick_types): Likewise.
5125
b6e3633c
AS
5126 * window.h (replace_buffer_in_windows): Declare.
5127
9397e56f
MR
51282011-06-11 Martin Rudalics <rudalics@gmx.at>
5129
5130 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5131 Qclone_number. Remove external declaration of Qdelete_window.
5132 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5133 code.
640c8776
SM
5134 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5135 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5136 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5137 buffer list implementation.
5138 (other_buffer_safely): New function.
5139 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5140 calls to replace_buffer_in_windows and
5141 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5142 if allowed.
5143 (record_buffer): Inhibit quitting and rewrite using quittable
5144 functions. Run Qbuffer_list_update_hook if allowed.
5145 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5146 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5147 Move switch-to-buffer to window.el.
9397e56f
MR
5148 (bury-buffer): Move to window.el.
5149 (Vbuffer_list_update_hook): New variable.
5150
5151 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5152 section.
5153
5154 * window.h (resize_frame_windows): Move up in code.
5155 (Fwindow_frame): Remove EXFUN.
5156 (replace_buffer_in_all_windows): Remove prototype.
5157 (replace_buffer_in_windows_safely): Add prototype.
5158
5159 * window.c: Declare Qdelete_window static again. Move down
5160 declaration of select_count.
5161 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5162 (Fother_window): Move to window.el.
5163 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5164 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5165 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5166 window.el.
5167 (replace_buffer_in_windows): Implement by calling
5168 Qreplace_buffer_in_windows.
5169 (replace_buffer_in_all_windows): Remove with some functionality
5170 moved into replace_buffer_in_windows_safely.
5171 (replace_buffer_in_windows_safely): New function.
5172 (select_window_norecord, select_frame_norecord): Move in front
5173 of run_window_configuration_change_hook. Remove now obsolete
5174 declarations.
640c8776
SM
5175 (Fset_window_buffer): Rewrite doc-string.
5176 Call Qrecord_window_buffer.
9397e56f
MR
5177 (keys_of_window): Move binding for other-window to window.el.
5178
b50691aa
CY
51792011-06-11 Chong Yidong <cyd@stupidchicken.com>
5180
5181 * dispextern.h (struct image): Replace data member, whose int_val
5182 and ptr_val fields were not used by anything, with a single
5183 lisp_val object.
5184
5185 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5186 (gif_clear_image, gif_load, imagemagick_load_image)
5187 (gs_clear_image, gs_load): Callers changed.
5188
3f754b86
PE
51892011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5190
cca69397
PE
5191 * buffer.h: Include <time.h>, for time_t.
5192 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5193
109e28d0
PE
5194 Fix minor problems found by static checking.
5195
60737f02
PE
5196 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5197
4b66faf3
PE
5198 Make identifiers static if they are not used in other modules.
5199 * data.c (Qcompiled_function, Qframe, Qvector):
5200 * image.c (QimageMagick, Qsvg):
5201 * minibuf.c (Qmetadata):
5202 * window.c (resize_window_check, resize_root_window): Now static.
5203 * window.h (resize_window_check, resize_root_window): Remove decls.
5204
109e28d0
PE
5205 * window.c (window_deletion_count, delete_deletable_window):
5206 Remove; unused.
46a4ce9e
PE
5207 (window_body_lines): Now static.
5208 (Fdelete_other_windows_internal): Mark vars as initialized.
5209 Make sure 'resize_failed' is initialized.
5210 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5211 (resize_window_apply): Remove unused local.
5212 * window.h (delete_deletable_window): Remove decl.
5213
109e28d0 5214 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5215 (imagemagick_load_image): Fix pointer signedness problem by changing
5216 last arg from unsigned char * to char *. All uses changed.
5217 Also, fix a local for similar reasons.
5218 Remove unused locals. Remove locals to avoid shadowing.
5219 (fn_rsvg_handle_free): Remove; unused.
5220 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5221 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5222
3f754b86
PE
5223 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5224
2547adb1
CY
52252011-06-10 Chong Yidong <cyd@stupidchicken.com>
5226
5227 * image.c (gif_load): Fix omitted cast error introduced by
5228 2011-06-06 change.
5229
2c8e37d4
MR
52302011-06-10 Martin Rudalics <rudalics@gmx.at>
5231
5232 * window.h (resize_proportionally, orig_total_lines)
5233 (orig_top_line): Remove from window structure.
5234 (set_window_height, set_window_width, change_window_heights)
5235 (Fdelete_window): Remove prototypes.
5236 (resize_frame_windows): Remove duplicate declaration.
5237
440a42e3
EZ
52382011-06-10 Eli Zaretskii <eliz@gnu.org>
5239
5240 * window.h (resize_frame_windows, resize_window_check)
5241 (delete_deletable_window, resize_root_window)
5242 (resize_frame_windows): Declare prototypes.
5243
5244 * window.c (resize_window_apply): Make definition be "static" to
5245 match the prototype.
5246
562dd5e9
MR
52472011-06-10 Martin Rudalics <rudalics@gmx.at>
5248
5249 * window.c: Remove declarations of Qwindow_size_fixed,
5250 window_min_size_1, window_min_size_2, window_min_size,
5251 size_window, window_fixed_size_p, enlarge_window, delete_window.
5252 Remove static from declaration of Qdelete_window, it's
5253 temporarily needed by Fbury_buffer.
5254 (replace_window): Don't assign orig_top_line and
5255 orig_total_lines.
5256 (Fdelete_window, delete_window): Remove. Window deletion is
5257 handled by window.el.
640c8776
SM
5258 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5259 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5260 (Fdelete_other_windows): Remove. Deleting other windows is
5261 handled by window.el.
5262 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5263 handled in window.el.
5264 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5265 Window minimum sizes are handled in window.el.
5266 (shrink_windows, size_window, set_window_height)
5267 (set_window_width, change_window_heights, window_height)
5268 (window_width, CURBEG, CURSIZE, enlarge_window)
5269 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5270 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5271 handled in window.el.
5272 (make_dummy_parent): Rename to make_parent_window and give it a
5273 second argument horflag.
5274 (make_window): Don't set resize_proportionally any more.
5275 (Fsplit_window): Remove. Windows are split in window.el.
5276 (save_restore_action, save_restore_orig_size)
5277 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5278 Resize mini windows in window.el.
5279 (grow_mini_window, shrink_mini_window): Implement by calling
5280 Qresize_root_window_vertically, resize_window_check and
5281 resize_window_apply.
640c8776
SM
5282 (saved_window, Fset_window_configuration, save_window_save):
5283 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5284 resize_proportionally.
5285 (window_min_height, window_min_width): Move to window.el.
5286 (keys_of_window): Move bindings for delete-other-windows,
5287 split-window, delete-window and enlarge-window to window.el.
5288
5289 * buffer.c: Temporarily extern Qdelete_window.
5290 (Fbury_buffer): Temporarily call Qdelete_window instead of
5291 Fdelete_window (Fbury_buffer will move to window.el soon).
5292
5293 * frame.c (set_menu_bar_lines_1): Remove code handling
5294 orig_top_line and orig_total_lines.
5295
5296 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5297 set_window_height but set heights directly.
5298 (change_frame_size_1): Use resize_frame_windows.
5299
5300 * xdisp.c (init_xdisp): Don't use set_window_height but set
5301 heights directly.
5302
640c8776
SM
5303 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5304 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5305 run_window_configuration_change_hook.
5306
5307 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5308 instead of change_window_heights and run
5309 run_window_configuration_change_hook.
5310
1a13852e
MR
53112011-06-09 Martin Rudalics <rudalics@gmx.at>
5312
5313 * window.c (replace_window): Rename second argument REPLACEMENT to
5314 NEW. New third argument SETFLAG. Rewrite.
5315 (delete_window, make_dummy_parent): Call replace_window with
5316 third argument 1.
5317 (window_list_1): Move down in code.
5318 (run_window_configuration_change_hook): Move set_buffer part
5319 before select_frame_norecord part in order to unwind correctly.
5320 Rename count1 to count.
5321 (recombine_windows, delete_deletable_window, resize_root_window)
5322 (Fdelete_other_windows_internal)
5323 (Frun_window_configuration_change_hook, make_parent_window)
5324 (resize_window_check, resize_window_apply, Fresize_window_apply)
5325 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5326 (Fdelete_window_internal, Fresize_mini_window_internal):
5327 New functions.
1a13852e
MR
5328 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5329
f3d1777e
MR
53302011-06-08 Martin Rudalics <rudalics@gmx.at>
5331
496e208e
MR
5332 * window.h (window): Add some new members to window structure -
5333 normal_lines, normal_cols, new_total, new_normal, clone_number,
5334 splits, nest, prev_buffers, next_buffers.
5335 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5336 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5337
f3d1777e
MR
5338 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5339 Remove.
496e208e
MR
5340 (make_dummy_parent): Set new members of windows structure.
5341 (make_window): Move down in code. Handle new members of window
5342 structure.
5343 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5344 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5345 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5346 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5347 (Fset_window_next_buffers, Fset_window_clone_number):
5348 New functions.
496e208e
MR
5349 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5350 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5351 Doc-string fixes.
5352 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5353 Argument WINDOW can be now internal window too.
5354 (Fwindow_use_time): Move up in code.
5355 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5356 Rewrite doc-string.
5357 (Fset_window_configuration, saved_window)
5358 (Fcurrent_window_configuration, save_window_save): Handle new
5359 members of window structure.
b9e809c2
MR
5360 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5361 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5362 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5363 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5364 Qget_mru_window, Qresize_root_window,
5365 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5366 Qauto_buffer_name; staticpro them.
f3d1777e 5367
abde8f8c
MR
53682011-06-07 Martin Rudalics <rudalics@gmx.at>
5369
5370 * window.c (Fwindow_total_size, Fwindow_left_column)
5371 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5372 (Fwindow_list_1): New functions.
5373 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5374 (Fwindow_width, Fscroll_left, Fscroll_right):
5375 Use window_body_cols instead of window_box_text_cols.
5376 (delete_window, Fset_window_configuration):
5377 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5378 (delete_all_subwindows): Take a window as argument and not a
5379 structure. Rewrite.
190b47e6
MR
5380 (window_loop): Remove handling of GET_LRU_WINDOW and
5381 GET_LARGEST_WINDOW.
5382 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5383
5384 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5385 window_box_text_cols. delete_all_subwindows now takes a
5386 Lisp_Object as argument.
abde8f8c 5387
640c8776
SM
5388 * indent.c (compute_motion, Fcompute_motion):
5389 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5390
fa8a67e6
MR
5391 * frame.c (delete_frame): Call delete_all_subwindows with root
5392 window as argument.
5393
a54e3482
DC
53942011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5395
5396 * fns.c (Fputhash): Document return value.
5397
60002bf5
CY
53982011-06-06 Chong Yidong <cyd@stupidchicken.com>
5399
5400 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5401
0c671da6 54022011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5403
b862a52a 5404 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5405
be44ca6c
PE
5406 Check for overflow when converting integer to cons and back.
5407 * charset.c (Fdefine_charset_internal, Fdecode_char):
5408 Use cons_to_unsigned to catch overflow.
5409 (Fencode_char): Use INTEGER_TO_CONS.
5410 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5411 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5412 * data.c (long_to_cons, cons_to_long): Remove.
5413 (cons_to_unsigned, cons_to_signed): New functions.
5414 These signal an error for invalid or out-of-range values.
5415 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5416 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5417 * font.c (Ffont_variation_glyphs):
5418 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5419 * lisp.h: Include <intprops.h>.
5420 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5421 (cons_to_signed, cons_to_unsigned): New decls.
5422 (long_to_cons, cons_to_long): Remove decls.
5423 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5424 (Fprimitive_undo): Use CONS_TO_INTEGER.
5425 * xfns.c (Fx_window_property): Likewise.
5426 * xselect.c: Include <limits.h>.
5427 (x_own_selection, selection_data_to_lisp_data):
5428 Use INTEGER_TO_CONS.
5429 (x_handle_selection_request, x_handle_selection_clear)
5430 (x_get_foreign_selection, Fx_disown_selection_internal)
5431 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5432 (lisp_data_to_selection_data): Use cons_to_unsigned.
5433 (x_fill_property_data): Use cons_to_signed.
5434 Report values out of range.
5435
d1f3d2af
PE
5436 Check for buffer and string overflow more precisely.
5437 * buffer.h (BUF_BYTES_MAX): New macro.
5438 * lisp.h (STRING_BYTES_MAX): New macro.
5439 * alloc.c (Fmake_string):
5440 * character.c (string_escape_byte8):
5441 * coding.c (coding_alloc_by_realloc):
5442 * doprnt.c (doprnt):
5443 * editfns.c (Fformat):
5444 * eval.c (verror):
5445 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5446 since they may not be the same number.
5447 * editfns.c (Finsert_char):
5448 * fileio.c (Finsert_file_contents):
5449 Likewise for BUF_BYTES_MAX.
5450
dd52fcea
PE
5451 * image.c: Use ptrdiff_t, not int, for sizes.
5452 (slurp_file): Switch from int to ptrdiff_t.
5453 All uses changed.
5454 (slurp_file): Check that file size fits in both size_t (for
5455 malloc) and ptrdiff_t (for sanity and safety).
5456
7f9bbdbb
PE
5457 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5458 if b->modtime has its maximal value.
5459
dfe18f82
PE
5460 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5461
84acfcf0
PE
5462 Don't assume time_t can fit into int.
5463 * buffer.h (struct buffer.modtime): Now time_t, not int.
5464 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5465 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5466
ccd9a01a
PE
5467 Minor fixes for signed vs unsigned integers.
5468 * character.h (MAYBE_UNIFY_CHAR):
5469 * charset.c (maybe_unify_char):
5470 * keyboard.c (read_char, reorder_modifiers):
5471 XINT -> XFASTINT, since the integer must be nonnegative.
5472 * ftfont.c (ftfont_spec_pattern):
5473 * keymap.c (access_keymap, silly_event_symbol_error):
5474 XUINT -> XFASTINT, since the integer must be nonnegative.
5475 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5476 since it makes no difference and we prefer signed.
5477 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5478 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5479 nonnegative.
5480
d6d100dd
SM
54812011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5482
5483 * window.h (Fwindow_frame): Declare.
5484
2b6148e4
PE
54852011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5486
5487 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5488 (SPARE_MEMORY): Always define.
5489 (LARGE_REQUEST): Remove.
5490 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5491
f230ecc9
MR
54922011-06-06 Martin Rudalics <rudalics@gmx.at>
5493
727e958e
MR
5494 * lisp.h: Move EXFUNS for Fframe_root_window,
5495 Fframe_first_window and Fset_frame_selected_window to window.h.
5496
5497 * window.h: Move EXFUNS for Fframe_root_window,
5498 Fframe_first_window and Fset_frame_selected_window here from
5499 lisp.h.
5500
5501 * frame.c (Fwindow_frame, Fframe_first_window)
5502 (Fframe_root_window, Fframe_selected_window)
5503 (Fset_frame_selected_window): Move to window.c.
5504 (Factive_minibuffer_window): Move to minibuf.c.
5505 (Fother_visible_frames_p): New function.
5506
5507 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5508
f230ecc9
MR
5509 * window.c (decode_window, decode_any_window): Move up in code.
5510 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5511 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5512 (Fwindow_buffer): Move up and rewrite doc-string.
5513 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5514 (Fwindow_prev): New functions.
727e958e
MR
5515 (Fwindow_frame): Move here from frame.c. Accept any window as
5516 argument.
5517 (Fframe_root_window, Fframe_first_window)
5518 (Fframe_selected_window): Move here from frame.c. Accept frame
5519 or arbitrary window as argument. Update doc-strings.
5520 (Fminibuffer_window): Move up in code.
5521 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5522 (Fset_frame_selected_window): Move here from frame.c.
5523 Marginal rewrite.
727e958e
MR
5524 (Fselected_window, select_window, Fselect_window): Move up in
5525 code. Minor doc-string fixes.
f230ecc9 5526
4d09bcf6
PE
55272011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5528
5529 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5530 Do not assume that spare memory exists; that assumption is valid
5531 only if SYSTEM_MALLOC.
5532 (LARGE_REQUEST): New macro, so that the issue of large requests
5533 is separated from the issue of spare memory.
5534
810928a2
AS
55352011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5536
172418ad
AS
5537 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5538 format. (Bug#8806)
5539
43f862f7
AS
5540 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5541
810928a2
AS
5542 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5543 before statements.
5544
a059fe24
JD
55452011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5546
5547 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5548
5549 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5550
5551 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5552 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5553
989bf368
JB
55542011-06-05 Juanma Barranquero <lekktu@gmail.com>
5555
5556 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5557
4b80f674
CY
55582011-06-04 Chong Yidong <cyd@stupidchicken.com>
5559
5560 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5561 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5562 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5563 New error handlers.
4b80f674
CY
5564 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5565 Obey Vx_select_enable_clipboard_manager. Catch errors in
5566 x_clipboard_manager_save (Bug#8779).
5567 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5568 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5569
99a33b77 55702011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5571
5572 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5573
99a33b77 55742011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5575
5576 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5577 in the current matrix if keep_current_p is non-zero.
5578
8264569d
EZ
55792011-06-04 Eli Zaretskii <eliz@gnu.org>
5580
5581 * bidi.c (bidi_level_of_next_char): Fix last change.
5582
57f97249
EZ
55832011-06-03 Eli Zaretskii <eliz@gnu.org>
5584
fec2107c 5585 Support bidi reordering of text covered by display properties.
57f97249 5586
fec2107c
EZ
5587 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5588 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5589 (bidi_cache_search, bidi_cache_iterator_state)
5590 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5591 (bidi_level_of_next_char, bidi_move_to_visually_next):
5592 Support character positions inside a run of characters covered by a
fec2107c
EZ
5593 display string.
5594 (bidi_paragraph_init, bidi_resolve_explicit_1)
5595 (bidi_level_of_next_char): Call bidi_fetch_char and
5596 bidi_fetch_char_advance instead of FETCH_CHAR and
5597 FETCH_CHAR_ADVANCE.
5598 (bidi_init_it): Initialize new members.
5599 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5600 definitions.
5601 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5602 instead of using explicit *_CHAR codes.
d6d100dd
SM
5603 (bidi_resolve_explicit, bidi_resolve_weak):
5604 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5605 bidirectional text is supported only in multibyte buffers.
5606 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5607 it to initialize the frame_window_p member of struct bidi_it.
5608 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5609 (bidi_resolve_explicit, bidi_resolve_weak)
5610 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5611 bidi_it->nchars is non-positive.
5612 (bidi_level_of_next_char): Don't try to lookup the cache for the
5613 next/previous character if nothing is cached there yet, or if we
5614 were just reseat()'ed to a new position.
c40e2fb2 5615
0e14fe90
EZ
5616 * xdisp.c (set_cursor_from_row): Set start and stop points
5617 according to the row's direction when priming the loop that looks
5618 for the glyph on which to display cursor.
5619 (single_display_spec_intangible_p): Function deleted.
5620 (display_prop_intangible_p): Reimplement to call
5621 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5622 Accept 3 additional arguments needed by handle_display_spec.
5623 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5624 values: lists, `(when COND...)' forms, etc.
5625 (single_display_spec_string_p): Support property values that are
5626 lists with the argument STRING its top-level element.
5627 (display_prop_string_p): Fix the condition for processing a
5628 property that is a list to be consistent with handle_display_spec.
fec2107c 5629 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5630 last portion of handle_display_prop.
5631 (compute_display_string_pos): Accept additional argument
5632 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5633 value of a `display' property is a "replacing spec".
5634 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5635 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5636 the display property, but just return a value indicating whether
5637 the display property will replace the characters it covers.
5638 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5639 frame_window_p members of struct bidi_it.
d6d100dd
SM
5640 (compute_display_string_pos, compute_display_string_end):
5641 New functions.
fec2107c
EZ
5642 (push_it): Accept second argument POSITION, where pop_it should
5643 jump to continue iteration.
5644 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5645
fec2107c
EZ
5646 * keyboard.c (adjust_point_for_property): Adjust the call to
5647 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5648
5649 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5650 (bidi_init_it): Update prototypes.
5651 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5652 (compute_display_string_pos, compute_display_string_end):
5653 Declare prototypes.
fec2107c
EZ
5654 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5655 EMACS_INT.
fc6f18ce 5656
40087514 56572011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5658
57f53182
PE
5659 Malloc failure behavior now depends on size of allocation.
5660 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5661 * lisp.h: Change signatures accordingly.
5662 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5663 All callers changed. (Bug#8762)
5664
5665 * gnutls.c: Use Emacs's memory allocators.
5666 Without this change, the gnutls library would invoke malloc etc.
5667 directly, which causes problems on non-SYNC_INPUT hosts, and which
5668 runs afoul of improving memory_full behavior. (Bug#8761)
5669 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5670 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5671 xfree instead of the default malloc, realloc, free.
5672 (Fgnutls_boot): No need to check for memory allocation failure,
5673 since xmalloc does that for us.
5674
ac32cd99 5675 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5676 * category.c (hash_get_category_set):
5677 * ccl.c (ccl_driver):
5678 * charset.c (Fdefine_charset_internal):
5679 * charset.h (struct charset.hash_index):
5680 * composite.c (get_composition_id, gstring_lookup_cache)
5681 (composition_gstring_put_cache):
5682 * composite.h (struct composition.hash_index):
5683 * dispextern.h (struct image.hash):
5684 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5685 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5686 (hashfn_equal, hashfn_user_defined, make_hash_table)
5687 (maybe_resize_hash_table, hash_lookup, hash_put)
5688 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5689 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5690 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5691 * image.c (make_image, search_image_cache, lookup_image)
5692 (xpm_put_color_table_h):
5693 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5694 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5695 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5696 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5697 * alloc.c (allocate_vectorlike):
5698 Check for overflow in vector size calculations.
5699 * ccl.c (ccl_driver):
5700 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5701 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5702 need to be updated by these changes.
40087514
PE
5703 * fns.c (make_hash_table, maybe_resize_hash_table):
5704 Check for integer overflow with large hash tables.
0de4bb68
PE
5705 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5706 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5707 (SXHASH_REDUCE): New macro.
5708 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5709 Use it instead of discarding useful hash info with large hash values.
5710 (sxhash_float): New function.
5711 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5712 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5713 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5714 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5715 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5716 Adjust signatures to match updated version of code.
5717 (consing_since_gc): Now EMACS_INT, since a single hash table can
5718 use more than INT_MAX bytes.
5719
698d32e2
DN
57202011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5721
5722 Make it possible to build with GCC-4.6+ -O2 -flto.
5723
5724 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5725
fd6fa53f
SM
57262011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5727
5728 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5729 Call minibuffer-inactive-mode.
5730
864db017
JB
57312011-05-31 Juanma Barranquero <lekktu@gmail.com>
5732
5733 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5734 Update dependencies.
5735
2ad0baf4
DN
57362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5737
5738 * data.c (init_data): Remove code for UTS, this system is not
5739 supported anymore.
5740
4fcc2638
DN
57412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5742
5743 Don't force ./temacs to start in terminal mode.
5744
5745 * frame.c (make_initial_frame): Initialize faces in all cases, not
5746 only when CANNOT_DUMP is defined.
5747 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5748
c56e0fd5
DN
57492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5750
5751 * dispnew.c (add_window_display_history): Use const for the string
5752 pointer. Remove declaration, not needed.
5753
333d54da 57542011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5755
55d4c1b2 5756 Use 'inline', not 'INLINE'.
333d54da 5757 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5758 * alloc.c, fontset.c (INLINE): Remove.
5759 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5760 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5761 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5762 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5763 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5764
738db178
DN
57652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5766
5767 Make it possible to run ./temacs.
5768
5769 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5770 syms_of_callproc does the same thing. Remove test for
5771 "initialized", do it in the caller.
5772 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5773
620c53a6
SM
57742011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5775
5776 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5777 (read_minibuf): Use get_minibuffer.
5778 (syms_of_minibuf): Use DEFSYM.
5779 (Qmetadata): New var.
5780 * data.c (Qbuffer): Don't make it static.
5781 (syms_of_data): Use DEFSYM.
5782
e003a292
PE
57832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5784
5785 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5786 (CCL_CODE_MIN): New macro.
5787
ed008a6d
PE
57882011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5789
3687c2ef
PE
5790 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5791
ed008a6d
PE
5792 * eval.c (Qdebug): Now static.
5793 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5794 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5795 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5796
d66c4c7c
CY
57972011-05-29 Chong Yidong <cyd@stupidchicken.com>
5798
5799 * image.c: Various fixes to ImageMagick code comments.
5800 (Fimagemagick_types): Doc fix.
5801
5fbc2025
PE
58022011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5803
0196f88a
PE
5804 Minor fixes prompted by GCC 4.6.0 warnings.
5805
5806 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5807
5fbc2025
PE
5808 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5809 (x_clipboard_manager_save_all): Move extern decl to ...
5810 * xterm.h: ... here, so that it can be checked for consistency.
5811
1dd3c2d9
CY
58122011-05-29 Chong Yidong <cyd@stupidchicken.com>
5813
5814 * xselect.c (x_clipboard_manager_save_frame)
5815 (x_clipboard_manager_save_all): New functions.
5816 (Fx_clipboard_manager_save): Lisp function deleted.
5817
5818 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5819 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5820
5821 * xterm.h: Update prototype.
5822
5ba6571d
WX
58232011-05-28 William Xu <william.xwl@gmail.com>
5824
5825 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5826 exiting (Bug#8239).
5827
3eaff834
JM
58282011-05-28 Jim Meyering <meyering@redhat.com>
5829
e1900994 5830 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5831 * fns.c (to_uchar): Define.
5832 (crypto_hash_function): Use it to convert some newly-signed
5833 variables to unsigned, to avoid sign-extension bugs. For example,
5834 without this change, (md5 "truc") would evaluate to
5835 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5836 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5837 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5838
0f6990a7
PE
58392011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5840
5841 Integer overflow fixes.
c8a9ca5a 5842
08686060
PE
5843 * dbusbind.c: Serial number integer overflow fixes.
5844 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5845 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5846 to hold a serial number that is too large for a fixnum.
5847 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5848 Check for serial numbers out of range. Decode any serial number
59568bf0 5849 that was so large that it became a float. (Bug#8722)
08686060 5850
2d1fc3c7
PE
5851 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5852 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5853 Use XFASTINT rather than XUINT when numbers are nonnegative.
5854 (xd_append_arg, Fdbus_method_return_internal):
5855 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5856 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5857 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5858 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5859 (Bug#8722)
2d1fc3c7 5860
c8a9ca5a
PE
5861 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5862
519e1d69
PE
5863 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5864
6df6ae42 5865 ccl: Add integer overflow checks.
30569699
PE
5866 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5867 (IN_INT_RANGE): New macros.
5868 (ccl_driver): Use them to check for integer overflow when
5869 decoding a CCL program. Many of the new checks are whether XINT (x)
5870 fits in int; it doesn't always, on 64-bit hosts. The new version
5871 doesn't catch all possible integer overflows, but it's an
847044ea 5872 improvement. (Bug#8719)
30569699 5873
c11285dc
PE
5874 * alloc.c (make_event_array): Use XINT, not XUINT.
5875 There's no need for unsigned here.
5876
fdccd48e
PE
5877 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5878 This follows up to the 2011-05-06 change that substituted uintptr_t
5879 for EMACS_INT. This case wasn't caught back then.
5880
37910ab2
PE
5881 Rework Fformat to avoid integer overflow issues.
5882 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5883 now (part of C89). Include <verify.h>.
5884 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5885 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5886 (Fformat): Avoid the prepass trying to compute sizes; it was only
5887 approximate and thus did not catch overflow reliably. Instead, walk
5888 through the format just once, formatting and computing sizes as we go,
5889 checking for integer overflow at every step, and allocating a larger
5890 buffer as needed. Keep track separately whether the format is
5891 multibyte. Keep only the most-recently calculated precision, rather
5892 than them all. Record whether each argument has been converted to
5893 string. Use EMACS_INT, not int, for byte and char and arg counts.
5894 Support field widths and precisions larger than INT_MAX. Avoid
5895 sprintf's undefined behavior with conversion specifications such as %#d
5896 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5897 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5898 formatting out-of-range floating point numbers with int
9173deec 5899 formats. (Bug#8668)
37910ab2 5900
2e6578fb
PE
5901 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5902
0ae6bdee
PE
5903 * data.c: Avoid integer truncation in expressions involving floats.
5904 * data.c: Include <intprops.h>.
5905 (arith_driver): When there's an integer overflow in an expression
5906 involving floating point, convert the integers to floating point
5907 so that the resulting value does not suffer from catastrophic
5908 integer truncation. For example, on a 64-bit host (* 4
5909 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5910 Do not rely on undefined behavior after integer overflow.
5911
de883a70
PE
5912 merge count_size_as_multibyte, parse_str_to_multibyte
5913 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5914 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5915 Check for integer overflow.
5916 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5917 since it's now a duplicate of the other. This is more of
5918 a character than a buffer op, so better that it's in character.c.
5919 * fns.c, print.c: Adjust to above changes.
5920
2ff916cb
PE
59212011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5922
5923 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5924
f1b54466
PE
59252011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5926
fb1ac845
PE
5927 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5928 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5929 (x_clipboard_manager_save): Now static.
5930 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5931
f1b54466
PE
5932 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5933 (crypto_hash_function): Now static.
5934 Fix pointer signedness problems. Avoid unnecessary initializations.
5935
a9f737ee
CY
59362011-05-27 Chong Yidong <cyd@stupidchicken.com>
5937
5938 * termhooks.h (Vselection_alist): Make it terminal-local.
5939
5940 * terminal.c (create_terminal): Initialize it.
5941
5942 * xselect.c: Support for clipboard managers.
5943 (Vselection_alist): Move to termhooks.h as terminal-local var.
5944 (LOCAL_SELECTION): New macro.
5945 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5946 (symbol_to_x_atom): Remove gratuitous arg.
5947 (x_handle_selection_request, lisp_data_to_selection_data)
5948 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5949 (x_own_selection, x_get_local_selection, x_convert_selection):
5950 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5951 (some_frame_on_display): Delete unused function.
5952 (Fx_own_selection_internal, Fx_get_selection_internal)
5953 (Fx_disown_selection_internal, Fx_selection_owner_p)
5954 (Fx_selection_exists_p): New optional frame arg.
5955 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5956 (x_handle_selection_clear): Don't treat other terminals with the
5957 same keyboard specially. Use the terminal-local Vselection_alist.
5958 (x_clear_frame_selections): Use Frun_hook_with_args.
5959
5960 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5961
5962 * xterm.h: Add support for those atoms.
5963
e067f0c1
CY
59642011-05-26 Chong Yidong <cyd@stupidchicken.com>
5965
5966 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5967 (converted_selections, conversion_fail_tag): New global variables.
5968 (x_selection_request_lisp_error): Free the above.
5969 (x_get_local_selection): Remove unnecessary code.
5970 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5971 of converted selections stored in converted_selections.
5972 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5973 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5974 (x_convert_selection): New function.
5975 (x_handle_selection_event): Simplify.
5976 (x_get_foreign_selection): Don't ignore incoming requests while
5977 waiting for an answer; this will fail when we implement
5978 SAVE_TARGETS, and seems unnecessary anyway.
5979 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5980 (Vx_sent_selection_functions): Doc fix.
5981
0f4aebc0
LL
59822011-05-26 Leo Liu <sdl.web@gmail.com>
5983
5984 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5985
e61124cd
YM
59862011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5987
5988 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5989
5990 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5991 for fringe update if it has periodic bitmap.
ac389d0c 5992 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5993 and fringe_bitmap_periodic_p.
5994
5995 * fringe.c (get_fringe_bitmap_data): New function.
5996 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5997 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5998 row. Mark glyph row for fringe update if periodicity changed.
5999
6000 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6001 for fringe update unless it has periodic bitmap.
6002
f16d9837
KH
60032011-05-25 Kenichi Handa <handa@m17n.org>
6004
6005 * xdisp.c (get_next_display_element): Set correct it->face_id for
6006 a static composition.
6007
e1b90ef6
LL
60082011-05-24 Leo Liu <sdl.web@gmail.com>
6009
6010 * deps.mk (fns.o):
6011 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6012
6013 * fns.c (crypto_hash_function, Fsha1): New function.
6014 (Fmd5): Use crypto_hash_function.
6015 (syms_of_fns): Add Ssha1.
6016
7400048f
PE
60172011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6018
6019 * gnutls.c: Remove unused macros.
6020 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6021 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6022 Remove macros that are defined and never used.
6023 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6024
abb71cf4
CY
60252011-05-22 Chong Yidong <cyd@stupidchicken.com>
6026
6027 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6028 (Fx_get_selection_internal): Minor cleanup.
6029 (Fx_own_selection_internal): Rename arguments for consistency with
6030 select.el.
6031
6307db39
PE
60322011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6033
6034 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6035
f3d4e0a4
CY
60362011-05-22 Chong Yidong <cyd@stupidchicken.com>
6037
6038 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6039
4d8ade89
YM
60402011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6041
6042 * dispnew.c (scrolling_window): Don't exclude the case that the
6043 last enabled row in the desired matrix touches the bottom boundary.
6044
32078c8d
GM
60452011-05-21 Glenn Morris <rgm@gnu.org>
6046
6047 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6048 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6049 and add some more files.
32078c8d 6050
7285dc67
EZ
60512011-05-20 Eli Zaretskii <eliz@gnu.org>
6052
6053 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6054 report_file_error introduced by the change from 2011-05-07.
6055
89d1bd22
PE
60562011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6057
6058 * systime.h (Time): Define only if emacs is defined.
6059 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6060 where the include path doesn't have X11/X.h by default. See
6061 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6062
cd394be1 60632011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6064
6065 * composite.c (find_automatic_composition): Fix previous change.
6066
b9704ad9
GM
60672011-05-20 Glenn Morris <rgm@gnu.org>
6068
6069 * lisp.mk: New file, split from Makefile.in.
6070 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6071 (shortlisp): Remove.
6072 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6073
4a720484
GM
60742011-05-19 Glenn Morris <rgm@gnu.org>
6075
6076 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6077 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6078 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6079 (lisp): Set the order to that of loadup.el.
6080 (shortlisp): Make it a copy of $lisp.
6081 (SOME_MACHINE_LISP): Remove.
6082 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6083 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6084
a28d4396
KH
60852011-05-18 Kenichi Handa <handa@m17n.org>
6086
6087 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6088 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6089 (find_automatic_composition): Mostly rewrite for efficiency.
6090
a2b1fa8e
JB
60912011-05-18 Juanma Barranquero <lekktu@gmail.com>
6092
6093 * makefile.w32-in: Update dependencies.
6094
8e1f5610
CS
60952011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6096
6097 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6098 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6099
7025ee00 61002011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6101
cdfa6eab
PE
6102 Fix some integer overflow issues, such as string length overflow.
6103
06d6db33
PE
6104 * insdel.c (count_size_as_multibyte): Check for string overflow.
6105
2b4560a8
PE
6106 * character.c (lisp_string_width): Check for string overflow.
6107 Use EMACS_INT, not int, for string indexes and lengths; in
6108 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6109 the resulting string length overflows an EMACS_INT; instead,
6110 report a string overflow if no precision given. When checking for
6111 precision exhaustion, use a check that cannot possibly have
6112 integer overflow. (Bug#8675)
6113 * character.h (lisp_string_width): Adjust to new signature.
6114
cb93f9be
PE
6115 * alloc.c (string_overflow): New function.
6116 (Fmake_string): Use it. This doesn't change behavior, but saves
6117 a few bytes and will simplify future changes.
6118 * character.c (string_escape_byte8): Likewise.
6119 * lisp.h (string_overflow): New decl.
6120
1a1f3366
PE
6121 Fixups, following up to the user-interface timestamp change.
6122 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6123 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6124 * msdos.c (mouse_get_pos): Likewise.
6125 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6126 * w32gui.h (Time): Define by including "systime.h" rather than by
6127 declaring it ourselves. (Bug#8664)
6128
d4e3e4d3
PE
6129 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6130 * image.c (clear_image_cache): Likewise.
6131
f6a24d19
PE
6132 * term.c (term_mouse_position): Don't assume time_t wraparound.
6133
08dc5ae6
PE
6134 Be more systematic about user-interface timestamps.
6135 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6136 and sometimes 'EMACS_UINT', to represent these timestamps.
6137 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6138 This makes the code easier to follow, and makes it easier to catch
6139 integer overflow bugs such as Bug#8664.
6140 * frame.c (Fmouse_position, Fmouse_pixel_position):
6141 Use Time, not unsigned long, for user-interface timestamps.
6142 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6143 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6144 * keyboard.h (last_event_timestamp): Likewise.
6145 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6146 * menu.h (xmenu_show): Likewise.
6147 * term.c (term_mouse_position): Likewise.
6148 * termhooks.h (struct input_event.timestamp): Likewise.
6149 (struct terminal.mouse_position_hook): Likewise.
6150 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6151 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6152 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6153 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6154 what it was before.
6155 * menu.h, termhooks.h: Include "systime.h", for Time.
6156
8e55734a
PE
6157 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6158 Don't assume that the difference between two unsigned long values
6159 can fit into an integer. At this point, we know button_down_time
6160 <= event->timestamp, so the difference must be nonnegative, so
6161 there's no need to cast the result if double-click-time is
6162 nonnegative, as it should be; check that it's nonnegative, just in
6163 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6164 apart (about 25 days). (Bug#8664)
8e55734a 6165
841f1b75 6166 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6167 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6168
3e26f69c
PE
6169 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6170 that always fit in int. Use a sentinel instead of a counter, to
6171 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6172 * frame.h (struct frame): Use int for menu_bar_items_used
6173 instead of EMACS_INT, since it always fits in int.
3e26f69c 6174
5cc152c0
PE
6175 * menu.c (grow_menu_items): Check for int overflow.
6176
d89eb65e
PE
6177 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6178
5235bd3e
PE
6179 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6180 Before, the code was not consistent. These values cannot exceed
6181 2**31 - 1 so there's no need to make them unsigned.
6182 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6183 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6184 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6185 as modifiers.
6186 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6187
bc827e23
PE
6188 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6189 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6190 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6191 presumably because the widths might not match.
6192
78eb494e
PE
6193 * window.c (size_window): Avoid needless test at loop start.
6194
04f2d78b
CB
61952011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6196
6197 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6198
d2fc7e3d 61992011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6200
6201 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6202
d2fc7e3d 62032011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6204
6205 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6206 `width' to `bar_area_x' and `bar_area_width', respectively.
6207 (x_scroll_run): Take account of fringe background extension.
6208
04f2d78b
CB
6209 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6210 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6211 `bar_area_width', respectively.
6212 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6213 background extension.
6214
79b70037
GM
62152011-05-10 Jim Meyering <meyering@redhat.com>
6216
6217 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6218
2f142cc5
JB
62192011-05-10 Juanma Barranquero <lekktu@gmail.com>
6220
6221 * image.c (Finit_image_library): Return t for built-in image types,
6222 like pbm and xbm. (Bug#8640)
6223
57679c86
AS
62242011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6225
6226 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6227
888c9e86
EZ
62282011-05-07 Eli Zaretskii <eliz@gnu.org>
6229
b0512a1d
EZ
6230 * w32console.c (Fset_screen_color): Doc fix.
6231 (Fget_screen_color): New function.
6232 (syms_of_ntterm): Defsubr it.
6233
7285dc67
EZ
6234 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6235 unlink the temporary file if Fcall_process didn't create it in the
6236 first place.
6237 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6238 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6239 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6240 cue to call_process_cleanup not to close that handle.
6241
4d3fcc8e
BK
62422011-05-07 Ben Key <bkey76@gmail.com>
6243
6244 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6245 one of two shell specific rules, either bootstrap-temacs-CMD or
6246 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6247 to the previous implementation of the bootstrap-temacs rule.
6248 The bootstrap-temacs-CMD rule is similar to the previous
6249 implementation of the bootstrap-temacs rule except that it
6250 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6251 variable.
6252
6253 These changes, along with some changes to nt/configure.bat,
6254 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6255 earlier fix to add support for --cflags and --ldflags options
6256 that include quotes so that it works whether make uses cmd or
6257 sh as the shell.
6258
b4289b64
MA
62592011-05-06 Michael Albinus <michael.albinus@gmx.de>
6260
6261 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6262 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6263 is a constant.
6264 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6265 a string. Handle both cases.
6266 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6267 (Fdbus_register_method): Use Qinvalid_function.
6268
af4c0e28
JB
62692011-05-06 Juanma Barranquero <lekktu@gmail.com>
6270
6271 * makefile.w32-in: Update dependencies.
6272 (LISP_H): Add inttypes.h and stdin.h.
6273 (PROCESS_H): Add unistd.h.
6274
c51453d9
EZ
62752011-05-06 Eli Zaretskii <eliz@gnu.org>
6276
6277 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6278 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6279
8ff0ac3c 62802011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6281
4c4b566b
PE
6282 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6283
aab2b9b5
PE
6284 * term.c (vfatal): Remove stray call to va_end.
6285 It's not needed and the C Standard doesn't allow it here anyway.
6286
c378da0b
PE
6287 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6288 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6289
288b08c7
PE
6290 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6291 bytes.
6292
e3601888
PE
6293 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6294
db6c0e74
PE
6295 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6296
dd5963ea
PE
6297 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6298
88c9450f
PE
6299 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6300
2f9442b8
PE
6301 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6302
c032b5f8
PE
6303 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6304 * charset.c (Fdefine_charset_internal): Don't initialize
6305 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6306 32-bit int (Bug#8600).
a108c10b
PE
6307
6308 * lread.c (read_integer): Be more consistent with string-to-number.
6309 Use string_to_number to do the actual conversion; this avoids
6310 rounding errors and fixes some other screwups. Without this fix,
6311 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6312 (digit_to_number): Move earlier, for benefit of read_integer.
6313 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6314 not a digit in any supported base. (Bug#8602)
a108c10b 6315
ad5f9eea
PE
6316 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6317
aec1708a
PE
6318 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6319 to match comment at start of function. This also removes a
6320 GCC warning about overflow in a 32+64-bit port.
6321
47be4ab5
PE
6322 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6323
371cac43
PE
6324 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6325 Reported by Stefan Monnier in
6326 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6327 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6328 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6329
d01a7826
PE
6330 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6331 (EMACS_UINTPTR): Likewise, with uintptr_t.
6332
7fd47d5c
PE
6333 * lisp.h: Prefer 64-bit EMACS_INT if available.
6334 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6335 on 32-bit hosts that have 64-bit int, so that they can access
6336 large files.
122b0c86
PE
6337 However, temporarily disable this change unless the temporary
6338 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6339
8727937b
PE
6340 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6341
8ac068ac
PE
6342 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6343 This removes an assumption that EMACS_INT and long are the same
6344 width as pointers. The assumption is true for Emacs porting targets
6345 now, but we want to make other targets possible.
6346 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6347 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6348 In the rest of the code, change types of integers that hold casted
6349 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6350 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6351 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6352 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6353 No need to cast type when ORing.
6354 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6355 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6356 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6357 assume EMACS_INT is the same width as char *.
6358 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6359 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6360 Remove no-longer-needed casts.
6361 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6362 (xg_tool_bar_help_callback, xg_make_tool_item):
6363 Use EMACS_INTPTR to hold an integer
6364 that will be cast to void *; this can avoid a GCC warning
6365 if EMACS_INT is not the same width as void *.
6366 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6367 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6368 (current_message_1, set_message_1):
6369 Use a local to convert to proper width without a cast.
6370 * xmenu.c (dialog_selection_callback): Likewise.
6371
ede49d71
PE
6372 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6373 Also, don't assume VALBITS / RAND_BITS is less than 5,
6374 and don't rely on undefined behavior when shifting a 1 left into
6375 the sign bit.
6376 * lisp.h (get_random): Change signature to match.
6377
2f30ecd0
PE
6378 * lread.c (hash_string): Use size_t, not int, for hash computation.
6379 Normally we prefer signed values; but hashing is special, because
6380 it's better to use unsigned division on hash table sizes so that
6381 the remainder is nonnegative. Also, size_t is the natural width
6382 for hashing into memory. The previous code used 'int', which doesn't
6383 retain enough info to hash well into very large tables.
6384 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6385
2a866e7b
PE
6386 * dbusbind.c: Don't possibly lose pointer info when converting.
6387 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6388 Use XPNTR rather than XHASH, so that the high-order bits of
6389 the pointer aren't lost when converting through void *.
6390
51639eac
PE
6391 * eval.c (Fautoload): Don't double-shift a pointer.
6392
92394119
PE
6393 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6394
dbdb9a7c
JB
63952011-05-06 Juanma Barranquero <lekktu@gmail.com>
6396
6397 * gnutls.c (DEF_GNUTLS_FN):
6398 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6399
db7a0b4f
AS
64002011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6401
6402 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6403 marker. (Bug#8610)
6404
cd394be1 64052011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6406
6407 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6408 New version that can reserve upto 2GB of heap space.
6409
f7ff1b0f 64102011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6411
6412 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6413
639c109b
TZ
64142011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6415
6416 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6417 `gnutls_certificate_set_x509_key_file'.
6418
d2127135
JB
64192011-05-05 Juanma Barranquero <lekktu@gmail.com>
6420
6421 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6422 Update dependencies.
6423
e968f4f3
JB
64242011-05-04 Juanma Barranquero <lekktu@gmail.com>
6425
6426 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6427 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6428 Remove unused parameter `fildes'.
6429 * process.c (read_process_output, send_process): Don't pass it.
6430
84d358f0
JB
64312011-05-04 Juanma Barranquero <lekktu@gmail.com>
6432
6433 Fix previous change: the library cache is defined in w32.c.
6434 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6435 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6436
0898ca10
JB
64372011-05-04 Juanma Barranquero <lekktu@gmail.com>
6438
6439 Implement dynamic loading of GnuTLS on Windows.
6440
6441 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6442 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6443 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6444 Declare.
6445
6446 * gnutls.c (Qgnutls_dll): Define.
6447 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6448 (gnutls_*): Declare function pointers.
6449 (init_gnutls_functions): New function to initialize function pointers.
6450 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6451 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6452 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6453 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6454 (emacs_gnutls_write, emacs_gnutls_read)
6455 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6456 (Fgnutls_available_p): New function.
6457 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6458 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6459 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6460
6461 * image.c: Include w32.h.
6462 (Vimage_type_cache): Delete.
6463 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6464 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6465 (w32_delayed_load): Move to w32.c.
6466
6467 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6468
6469 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6470 (w32_delayed_load): Move from image.c. When loading a library, record
6471 its filename in the :loaded-from property of the library id.
6472 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6473 Initialize and staticpro them.
6474 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6475
6476 * process.c: Include lisp.h before w32.h, not after.
6477 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6478 instead of gnutls_record_check_pending.
6479
6480 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6481
ff4de4aa
TZ
64822011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6483
6484 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6485 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6486 as passed in.
6487
abe95abb
JD
64882011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6489
6490 * xterm.c (x_set_frame_alpha): Do not set property on anything
6491 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6492
e16e55d4
JB
64932011-05-02 Juanma Barranquero <lekktu@gmail.com>
6494
6495 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6496
bafcf6a5
JB
64972011-05-02 Juanma Barranquero <lekktu@gmail.com>
6498
6499 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6500 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6501 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6502 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6503 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6504 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6505 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6506 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6507 (Qgnutls_bootprop_callbacks_verify): Make static.
6508
e7a6747f
AS
65092011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6510
19ed11ba
AS
6511 * callproc.c: Indentation fixup.
6512
e7a6747f 6513 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6514 (wait_for_termination, interruptible_wait_for_termination):
6515 Move after wait_for_termination_1.
e7a6747f 6516
1ef14cb4
LMI
65172011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6518
6519 * sysdep.c (interruptible_wait_for_termination): New function
6520 which is like wait_for_termination, but allows keyboard
6521 interruptions.
6522
6523 * callproc.c (Fcall_process): Add (:file "file") as an option for
6524 the STDOUT buffer.
6525 (Fcall_process_region): Ditto.
6526
330d880c
EZ
65272011-04-30 Eli Zaretskii <eliz@gnu.org>
6528
8db90b73
EZ
6529 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6530 rather than `XVECTOR (FOO)->size'.
6531
330d880c
EZ
6532 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6533 inttypes.h, as a gnulib replacement is used if it not available in
6534 system headers.
6535
15cbd324
EZ
65362011-04-21 Eli Zaretskii <eliz@gnu.org>
6537
6538 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6539 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6540 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6541
6542 * coding.c (coding_alloc_by_realloc): Error out if destination
6543 will grow beyond MOST_POSITIVE_FIXNUM.
6544 (decode_coding_emacs_mule): Abort if there isn't enough place in
6545 charbuf for the composition carryover bytes. Reserve an extra
6546 space for up to 2 characters produced in a loop.
6547 (decode_coding_iso_2022): Abort if there isn't enough place in
6548 charbuf for the composition carryover bytes.
6549
65502011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6551
ae940cca
EZ
6552 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6553 aborting when %lld or %lll format is passed.
6554 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6555 %llo or %llx format is passed. (Bug#8545)
6556
03ab8921
EZ
6557 * window.c (window_scroll_line_based): Use a marker instead of
6558 simple variables to record original value of point. (Bug#7952)
6559
afda1437
EZ
6560 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6561 produced by %s or %c overflows available buffer space. (Bug#8545)
6562
f76dee0c
PE
65632011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6564
6565 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6566 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6567
fdc5744d
JB
65682011-04-28 Juanma Barranquero <lekktu@gmail.com>
6569
6570 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6571
638f053a
JB
65722011-04-28 Juanma Barranquero <lekktu@gmail.com>
6573
6574 * keyboard.c (Qdelayed_warnings_hook): Define.
6575 (command_loop_1): Run `delayed-warnings-hook'
6576 if Vdelayed_warnings_list is non-nil.
6577 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6578 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6579
d178f871
EZ
65802011-04-28 Eli Zaretskii <eliz@gnu.org>
6581
6582 * doprnt.c (doprnt): Don't return value smaller than the buffer
6583 size if the message was truncated. (Bug#8545).
6584
b124fd93
JB
65852011-04-28 Juanma Barranquero <lekktu@gmail.com>
6586
6587 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6588 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6589
e810457d
PE
65902011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6591
6592 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6593
ea51cceb
JB
65942011-04-27 Juanma Barranquero <lekktu@gmail.com>
6595
6596 * makefile.w32-in: Update dependencies.
6597
94dcfacf
EZ
65982011-04-27 Eli Zaretskii <eliz@gnu.org>
6599
6600 Improve `doprnt' and its usage. (Bug#8545)
6601 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6602 `format_end'. Remove support for %l as a conversion specifier.
6603 Don't use xrealloc. Improve diagnostics when the %l size modifier
6604 is used. Update the commentary.
6605
6606 * eval.c (verror): Simplify calculation of size_t.
6607
6608 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6609 messages.
6610
f61f41d7
PE
66112011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6612
6613 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6614 change.
6615
96fb4434
PE
66162011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6617
6618 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6619 This makes this file independent of the recent pseudovector change.
6620
671875da 66212011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6622
69e9b5a3
PE
6623 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6624
b5f869a7 6625 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6626 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6627 Remove unused local.
c8926152 6628 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6629
841a1577 6630 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6631 GCC 4.6.0 optimizes based on type-based alias analysis.
6632 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6633 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6634 != &v->size, and therefore "v->size = 1; b->size = 2; return
6635 v->size;" must therefore return 1. This assumption is incorrect
6636 for Emacs, since it type-puns struct Lisp_Vector * with many other
6637 types. To fix this problem, this patch adds a new type struct
f904488f 6638 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6639 and pseudovectors, and helps optimizing compilers not get fooled
6640 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6641 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6642 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6643 the size member.
eab3844f
PE
6644 (XSETPVECTYPE): Rewrite in terms of new macro.
6645 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6646 This is a bit clearer, and further avoids the possibility of
6647 undesirable aliasing.
6648 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6649 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6650 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6651 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6652 (ASIZE): Now uses header.size rather than size.
6653 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6654 to avoid the hassle of writing XVECTOR (foo)->header.size.
6655 (struct vectorlike_header): New type.
eab3844f
PE
6656 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6657 object, to help avoid aliasing.
6658 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6659 (SUBRP): Likewise, since Lisp_Subr is a special case.
6660 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6661 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6662 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6663 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6664 changed to be "header.size" and "header.next".
6665 * buffer.h (struct buffer): Likewise.
6666 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6667 * frame.h (struct frame): Likewise.
6668 * process.h (struct Lisp_Process): Likewise.
6669 * termhooks.h (struct terminal): Likewise.
6670 * window.c (struct save_window_data, struct saved_window): Likewise.
6671 * window.h (struct window): Likewise.
6672 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6673 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6674 * buffer.c (init_buffer_once): Likewise.
6675 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6676 special case.
6677 * process.c (Fformat_network_address): Use local var for size,
6678 for brevity.
6679
0df1eac5
PE
6680 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6681
847ab9d1 6682 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6683 * data.c (atof): Remove decl; no longer used or needed.
6684 (digit_to_number): Move to lread.c.
6685 (Fstring_to_number): Use new string_to_number function, to be
6686 consistent with how the Lisp reader treats infinities and NaNs.
6687 Do not assume that floating-point numbers represent EMACS_INT
6688 without losing information; this is not true on most 64-bit hosts.
6689 Avoid double-rounding errors, by insisting on integers when
6690 parsing non-base-10 numbers, as the documentation specifies.
6691 * lisp.h (string_to_number): New decl, replacing ...
6692 (isfloat_string): Remove.
bc0a5c13 6693 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6694 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6695 appears to have been a coding error. Similarly, do not accept
6696 strings like +-1e0 as floating point numbers. Do not report
6697 overflow for integer overflows unless the base is not 10 which
6698 means we have no simple and reliable way to continue.
6699 Break out the floating-point parsing into a new
6700 function string_to_number, so that Fstring_to_number parses
6701 floating point numbers consistently with the Lisp reader.
04f2d78b 6702 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6703 (E_CHAR, EXP_INT): Remove, replacing with ...
6704 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6705 (string_to_number): New function, replacing isfloat_string.
6706 This function checks for valid syntax and produces the resulting
6707 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6708 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6709 so that overflow for non-base-10 numbers is reported only when
6710 there's no portable and simple way to convert to floating point.
452f4150 6711
67769ffc
PE
6712 * textprop.c (set_text_properties_1): Rewrite for clarity,
6713 and to avoid GCC warning about integer overflow.
6714
c20db43f
PE
6715 * intervals.h (struct interval): Use EMACS_INT for members
6716 where EMACS_UINT might cause problems. See
6717 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6718 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6719 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6720 All uses changed.
37aa2f85
PE
6721 (offset_intervals): Tell GCC not to worry about length overflow
6722 when negating a negative length.
c20db43f 6723
2538aa2f
PE
6724 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6725 (overrun_check_free): Likewise.
6726
f2d3008d
PE
6727 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6728 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6729 word size.
6730
ec8df744
PE
6731 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6732 (gnutls_make_error): Rename local to avoid shadowing.
6733 (gnutls_emacs_global_deinit): ifdef out; not used.
6734 (Fgnutls_boot): Use const for pointer to readonly storage.
6735 Comment out unused local. Fix pointer signedness problems.
6736
640ee02d
PE
6737 * lread.c (openp): Don't stuff size_t into an 'int'.
6738 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6739 about possible signed overflow.
6740
6048fb2a
PE
6741 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6742 (GDK_KEY_g): Don't define if already defined.
6743 (xg_prepare_tooltip): Avoid pointer signedness problem.
6744 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6745
fa3c87e1
PE
6746 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6747 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6748
2172544b
PE
6749 * xfns.c (Fx_window_property): Simplify a bit,
6750 to make a bit faster and to avoid GCC 4.6.0 warning.
6751 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6752
9b821a21
PE
6753 * fns.c (internal_equal): Don't assume size_t fits in int.
6754
3c616cfa
PE
6755 * alloc.c (compact_small_strings): Tighten assertion a little.
6756
c2982e87
PE
6757 Replace pEd with more-general pI, and fix some printf arg casts.
6758 * lisp.h (pI): New macro, generalizing old pEd macro to other
6759 conversion specifiers. For example, use "...%"pI"d..." rather
6760 than "...%"pEd"...".
6761 (pEd): Remove. All uses replaced with similar uses of pI.
6762 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6763 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6764 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6765 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6766 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6767 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6768 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6769 64-bit hosts.
6770 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6771 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6772 * print.c (safe_debug_print, print_object): Likewise.
6773 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6774 to int.
6f04d126
PE
6775 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6776 avoiding the 0 flag, which is not portable.
c2982e87
PE
6777 * process.c (Fmake_network_process): Use pI to avoid cast.
6778 * region-cache.c (pp_cache): Likewise.
6779 * xdisp.c (decode_mode_spec): Likewise.
6780 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6781 behavior on 64-bit hosts with printf arg.
6f04d126 6782 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6783 (x_stop_queuing_selection_requests): Likewise.
6784 (x_get_window_property): Don't truncate byte count to an 'int'
6785 when tracing.
0b432f21 6786
5e073ec7
PE
6787 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6788 here, since it parses constructs like leading '-' and spaces,
6789 which are not wanted; and it overflows with large numbers.
6790 Instead, simply match F[0-9]+, which is what is wanted anyway.
6791
36372bf9
PE
6792 * alloc.c: Remove unportable assumptions about struct layout.
6793 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6794 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6795 (allocate_vectorlike, make_pure_vector): Use the new macros,
6796 plus offsetof, to remove unportable assumptions about struct layout.
6797 These assumptions hold on all porting targets that I know of, but
6798 they are not guaranteed, they're easy to remove, and removing them
6799 makes further changes easier.
6800
0b432f21
PE
6801 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6802 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6803 (string_overrun_cookie): Now const. Use initializers that
6804 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6805 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6806 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6807 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6808 multiple of sizeof (EMACS_INT); it need not be, if
6809 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6810 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6811
895009e1
JB
68122011-04-26 Juanma Barranquero <lekktu@gmail.com>
6813
6814 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6815
6a7a1b0b
TZ
68162011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6817
6818 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6819 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6820 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6821
841a1577 68222011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6823
6824 * lisp.h (Qdebug): List symbol.
895009e1 6825 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6826 * keyboard.c (debug-on-event): New variable.
6827 (handle_user_signal): Break into debugger when debug-on-event
6828 matches the current signal symbol.
6829
f2d3ba6f
DN
68302011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6831
6832 * alloc.c (check_sblock, check_string_bytes)
6833 (check_string_free_list): Convert to standard C.
6834
42ce4c63
TZ
68352011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6836
6837 * w32.c (emacs_gnutls_push): Fix typo.
6838
825cd63c
EZ
68392011-04-25 Eli Zaretskii <eliz@gnu.org>
6840
fb11d64d
EZ
6841 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6842 "cast to pointer from integer of different size".
6843
825cd63c
EZ
6844 Improve doprnt and its use in verror. (Bug#8545)
6845 * doprnt.c (doprnt): Document the set of format control sequences
6846 supported by the function. Use SAFE_ALLOCA instead of always
6847 using `alloca'.
6848
6849 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6850 is one byte too soon. Don't use xrealloc; instead xfree and
6851 xmalloc anew.
6852
e061a11b
TZ
68532011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6854
6855 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6856 callbacks stage.
6857
6858 * gnutls.c: Renamed global_initialized to
6859 gnutls_global_initialized. Added internals for the
6860 :verify-hostname-error, :verify-error, and :verify-flags
6861 parameters of `gnutls-boot' and documented those parameters in the
6862 docstring. Start callback support.
9173deec
JB
6863 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6864 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6865 on error. Return error code.
e061a11b
TZ
6866 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6867 (emacs_gnutls_read): Likewise.
6868 (Fgnutls_boot): Return handshake error code.
6869 (emacs_gnutls_handle_error): New function.
6870 (wsaerror_to_errno): Likewise.
6871
6872 * w32.h (emacs_gnutls_pull): Add prototype.
6873 (emacs_gnutls_push): Likewise.
6874
6875 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6876 (emacs_gnutls_push): Likewise.
6877
68782011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6879
6880 * process.c (wait_reading_process_output): Check if GnuTLS
6881 buffered some data internally if no FDs are set for TLS
6882 connections.
6883
6884 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6885 (LIBS): Link to USER_LIBS.
6886 ($(BLD)/gnutls.$(0)): New target.
6887
fa6996bc
EZ
68882011-04-24 Eli Zaretskii <eliz@gnu.org>
6889
eb35682e
EZ
6890 * xdisp.c (handle_single_display_spec): Rename the
6891 display_replaced_before_p argument into display_replaced_p, to
6892 make it consistent with the commentary. Fix typos in the
6893 commentary.
6894
e2ad650c
EZ
6895 * textprop.c (syms_of_textprop): Remove dead code.
6896 (copy_text_properties): Delete obsolete commentary about an
6897 interface that was deleted long ago. Fix typos in the description
6898 of arguments.
6899
1b2de274
EZ
6900 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6901 to changes in oldXMenu/XMenu.h from 2011-04-16.
6902 <menu_help_message, prev_menu_help_message>: Constify.
6903 (IT_menu_make_room): menu->help_text is now `const char **';
6904 adjust.
6905
6906 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6907 to changes in oldXMenu/XMenu.h from 2011-04-16.
6908 (struct XMenu): Declare `help_text' `const char **'.
6909
6910 * xfaces.c <Qunspecified>: Make extern again.
6911
6912 * syntax.c: Include sys/types.h before including regex.h, as
6913 required by Posix.
6914
762b15be
EZ
6915 * doc.c (get_doc_string): Improve the format passed to `error'.
6916
6917 * doprnt.c (doprnt): Improve commentary.
6918
6919 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6920
6921 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6922 them with etags.
6923
f1052e5d
EZ
6924 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6925 changes in globals.h immediately force recompilation.
762b15be
EZ
6926 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6927 $(CURDIR)/s/ms-w32.h.
6928 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6929
fa6996bc
EZ
6930 * character.c (Fchar_direction): Function deleted.
6931 (syms_of_character): Don't defsubr it.
6932 <char-direction-table>: Deleted.
6933
e6c3da20
EZ
69342011-04-23 Eli Zaretskii <eliz@gnu.org>
6935
6936 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6937 * doprnt.c: Include limits.h.
6938 (SIZE_MAX): New macro.
04f2d78b
CB
6939 (doprnt): Return a size_t value. 2nd arg is now size_t.
6940 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6941 Improve overflow protection. Support `l' modifier for integer
6942 conversions. Support %l conversion. Don't assume an EMACS_INT
6943 argument for integer conversions and for %c.
6944
6945 * lisp.h (doprnt): Restore prototype.
6946
6947 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6948 $(SRC)/character.h.
6949
6950 * Makefile.in (base_obj): Add back doprnt.o.
6951
6952 * deps.mk (doprnt.o): Add back prerequisites.
6953 (callint.o): Depend on character.h.
6954
6955 * eval.c (internal_lisp_condition_case): Include the handler
6956 representation in the error message.
6957 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6958 when breaking from the loop.
6959
6960 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6961
6962 * callint.c (Fcall_interactively): When displaying error message
6963 about invalid control letter, pass the character's codepoint, not
6964 a pointer to its multibyte form. Improve display of the character
6965 in octal and display also its hex code.
6966
6967 * character.c (char_string): Use %x to display the (unsigned)
6968 codepoint of an invalid character, to avoid displaying a bogus
6969 negative value.
6970
6971 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6972 `error', not SYMBOL_NAME itself.
6973
6974 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6975 character arguments to `error'.
6976
6977 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6978 to `error' in error message about FINAL_CHAR argument. Make sure
6979 FINAL_CHAR is a character, and use %c when it is passed as
6980 argument to `error'.
6981
4ffd0d6b 69822011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6983
6984 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6985
6986 * w32.c: Include <time.h>.
6987 (sys_localtime): New function.
6988
4ffd0d6b 69892011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6990
6991 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6992
4ffd0d6b 6993 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6994
4ffd0d6b 69952011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6996
4ffd0d6b
GM
6997 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6998 zombies (Bug#8467).
aac0c6e3 6999
04c56954
EZ
70002011-04-19 Eli Zaretskii <eliz@gnu.org>
7001
7002 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7003 gl_state.e_property when gl_state.object is Qt.
7004
7005 * insdel.c (make_gap_larger): Remove limitation of buffer size
7006 to <= INT_MAX.
7007
16a43933
CY
70082011-04-18 Chong Yidong <cyd@stupidchicken.com>
7009
7010 * xdisp.c (lookup_glyphless_char_display)
7011 (produce_glyphless_glyph): Handle cons cell entry in
7012 glyphless-char-display.
7013 (Vglyphless_char_display): Document it.
7014
7015 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7016 glyphless-char-display.
7017
4581706e
CY
70182011-04-17 Chong Yidong <cyd@stupidchicken.com>
7019
7020 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7021
7022 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7023
7024 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7025 definition for no-X builds.
7026
4887c6e2 70272011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7028
fd35b6f9
PE
7029 Static checks with GCC 4.6.0 and non-default toolkits.
7030
5c1ccb01
PE
7031 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7032
006c5daa
PE
7033 * process.c (keyboard_bit_set): Define only if SIGIO.
7034 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7035 (send_process): Repair possible setjmp clobbering.
7036
efc736d3
PE
7037 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7038
4e2fe2e6
PE
7039 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7040
f97334a2
PE
7041 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7042
4e75f29d
PE
7043 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7044 Define only if needed.
7045
90efadd1
PE
7046 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7047 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7048 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7049
3c647824
PE
7050 * dispextern.h (struct redisplay_interface): Rename param
7051 to avoid shadowing.
e264f262 7052 * termhooks.h (struct terminal): Likewise.
761383f4 7053 * xterm.c (xembed_send_message): Likewise.
3c647824 7054
b58c5c4a
PE
7055 * insdel.c (make_gap_smaller): Define only if
7056 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7057
cad59032
PE
7058 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7059 it.
7060
c339dc2e
PE
7061 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7062 so that we aren't warned about unused symbols.
7063
91a3e27b
PE
7064 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7065
399c71d3 7066 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7067
8ffc96f5
PE
7068 * xfns.c (x_real_positions): Mark locals as initialized.
7069
eef9bc79
PE
7070 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7071
098db9dd
PE
7072 * xterm.c: Fix problems found by static analysis with other toolkits.
7073 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7074 (x_dispatch_event): Declare static if USE_GTK, and
7075 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7076 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7077 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7078 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7079 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7080
eb18f6cc
PE
7081 * xmenu.c (menu_help_callback): Pointer type fixes.
7082 Use const pointers when pointing at readonly data. Avoid pointer
7083 signedness clashes.
7084 (FALSE): Remove unused macro.
7085 (update_frame_menubar): Remove unused decl.
7086
1fe72bf8
PE
7087 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7088
60d9e1db
PE
7089 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7090 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7091 (single_menu_item): Rename local to avoid shadowing.
7092
39261c26
PE
7093 * keyboard.c (make_lispy_event): Remove unused local var.
7094
018c5e19
PE
7095 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7096 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7097
63d2b86e
PE
7098 * bitmaps: Change bitmaps from unsigned char back to the X11
7099 compatible char. Avoid the old compiler warnings about
7100 out-of-range initializers by using, for example, '\xab' rather
7101 than 0xab.
7102
aefd87e1
PE
7103 * xgselect.c (xgselect_initialize): Check vs interface
7104 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7105
bf501fb9
PE
7106 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7107
e9829fdf
PE
7108 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7109 to read-only memory.
7110
1086c095
PE
7111 * fns.c (vector): Remove; this old hack is no longer needed.
7112
2baccd04 7113 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7114 Remove unused var.
dde42981 7115 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7116
72391843 7117 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7118
436c16df 7119 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7120 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7121 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7122
92bb796d 7123 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7124 (x_term_init): Remove local to avoid shadowing.
92bb796d 7125
764430a3 7126 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7127
7128 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7129 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7130
d1dfb56c
EZ
71312011-04-16 Eli Zaretskii <eliz@gnu.org>
7132
c4354cb4
EZ
7133 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7134
d1dfb56c
EZ
7135 Fix regex.c, syntax.c and friends for buffers > 2GB.
7136 * syntax.h (struct gl_state_s): Declare character position members
7137 EMACS_INT.
7138
7139 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7140
04f2d78b
CB
7141 * textprop.c (verify_interval_modification, interval_of):
7142 Declare arguments EMACS_INT.
d1dfb56c
EZ
7143
7144 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7145 EMACS_INT.
7146
7147 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7148
7149 * indent.c (Fvertical_motion): Local variable it_start is now
7150 EMACS_INT.
7151
7152 * regex.c (re_match, re_match_2, re_match_2_internal)
7153 (bcmp_translate, regcomp, regexec, print_double_string)
7154 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7155 (re_compile_pattern, re_exec): Declare arguments and local
7156 variables `size_t' and `ssize_t' and return values `regoff_t', as
7157 appropriate.
7158 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7159 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7160 <compile_stack_type>: `size' and `avail' are now `size_t'.
7161
7162 * regex.h <regoff_t>: Use ssize_t, not int.
7163 (re_search, re_search_2, re_match, re_match_2): Arguments that
7164 specify buffer/string position and length are now ssize_t and
7165 size_t. Return type is regoff_t.
7166
613052cd
BK
71672011-04-16 Ben Key <bkey76@gmail.com>
7168
7169 * nsfont.m: Fixed bugs in ns_get_family and
7170 ns_descriptor_to_entity that were caused by using free to
7171 deallocate memory blocks that were allocated by xmalloc (via
7172 xstrdup). This caused Emacs to crash when compiled with
7173 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7174 --enable-checking=xmallocoverrun). xfree is now used to
7175 deallocate these memory blocks.
7176
4170f62f 71772011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7178
71b41406
PE
7179 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7180
9587a89d
PE
7181 emacs_write: Accept and return EMACS_INT for sizes.
7182 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7183 et seq.
7184 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7185 Accept and return EMACS_INT.
7186 (emacs_gnutls_write): Return the number of bytes written on
7187 partial writes.
7188 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7189 (emacs_read, emacs_write): Remove check for negative size, as the
7190 Emacs source code has been audited now.
9587a89d
PE
7191 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7192 (emacs_read, emacs_write): Use it.
273a5f82
PE
7193 * process.c (send_process): Adjust to the new signatures of
7194 emacs_write and emacs_gnutls_write. Do not attempt to store
7195 a byte offset into an 'int'; it might overflow.
9587a89d 7196 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7197
3e047f51
PE
7198 * sound.c: Don't assume sizes fit in 'int'.
7199 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7200 Return EMACS_INT, not int.
3e047f51 7201 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7202 Accept EMACS_INT, not int.
7203 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7204 record read return values.
7205
cc39a9db
BK
72062011-04-15 Ben Key <bkey76@gmail.com>
7207
c9d0ec6d
JB
7208 * keyboard.c (Qundefined): Don't declare static since it is used
7209 in nsfns.m.
7210 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7211 static since they are used in nsfont.m.
cc39a9db 7212
6c60eb9f
SM
72132011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7214
7215 * process.c (Qprocessp): Don't declare static.
7216 * lisp.h (Qprocessp): Declare again.
7217
7990b61a
JB
72182011-04-15 Juanma Barranquero <lekktu@gmail.com>
7219
7220 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7221
5d4cb038
PE
72222011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7223
8bd7b830 7224 Improve C-level modularity by making more things 'static'.
cd64ea1d 7225
e3b27b31
PE
7226 Don't publish debugger-only interfaces to other modules.
7227 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7228 (verify_bytepos, count_markers): Move decls to the only modules
7229 that need them.
7230 * region-cache.h (pp_cache): Likewise.
7231 * window.h (check_all_windows): Likewise.
7232 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7233
5d4cb038
PE
7234 * sysdep.c (croak): Now static, if
7235 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7236 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7237
7238 * alloc.c (refill_memory_reserve): Now static if
7239 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7240 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7241
e87b6180
PE
7242 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7243 Define only if USE_LUCID.
7244
ac64929e
PE
7245 * xrdb.c (x_customization_string, x_rm_string): Now static.
7246
6f37259d
PE
7247 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7248 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7249
1683e3ab
PE
7250 * xdisp.c (draw_row_with_mouse_face): Now static.
7251 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7252
de9c2632
PE
7253 * window.h (check_all_windows): Mark externally visible.
7254
2b96acb7
PE
7255 * window.c (window_deletion_count): Now static.
7256
7257 * undo.c: Make symbols static if they're not exported.
7258 (last_undo_buffer, last_boundary_position, pending_boundary):
7259 Now static.
7260
50436f33
PE
7261 * textprop.c (interval_insert_behind_hooks): Now static.
7262 (interval_insert_in_front_hooks): Likewise.
7263
64520e5c
PE
7264 * term.c: Make symbols static if they're not exported.
7265 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7266 (max_frame_lines, tty_set_terminal_modes):
7267 (tty_reset_terminal_modes, tty_turn_off_highlight):
7268 (get_tty_terminal): Now static.
7269 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7270 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7271 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7272 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7273 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7274
1fa53021
PE
7275 * sysdep.c: Make symbols static if they're not exported.
7276 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7277 Now static.
7278 (sigprocmask_set, full_mask): Remove; unused.
7279 (wait_debugging): Mark as visible.
7280 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7281 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7282
d4b43b22
PE
7283 * syntax.c (syntax_temp): Define only if !__GNUC__.
7284
b7c513d0
PE
7285 * sound.c (current_sound_device, current_sound): Now static.
7286
989b29ad
PE
7287 * search.c (searchbufs, searchbuf_head): Now static.
7288
13a55a78
PE
7289 * scroll.c (scroll_cost): Remove; unused.
7290 * dispextern.h (scroll_cost): Remove decl.
7291
de68a1fc
PE
7292 * region-cache.h (pp_cache): Mark as externally visible.
7293
40ccffa6
PE
7294 * process.c: Make symbols static if they're not exported.
7295 (process_tick, update_tick, create_process, chan_process):
7296 (Vprocess_alist, proc_buffered_char, datagram_access):
7297 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7298 (deactivate_process): Mark defn as static, as well as decl.
7299 * lisp.h (create_process): Remove decl.
7300 * process.h (chan_process, Vprocess_alist): Remove decls.
7301
ad64fc97
PE
7302 * print.c: Make symbols static if they're not exported.
7303 (print_depth, new_backquote_output, being_printed, print_buffer):
7304 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7305 (print_interval, print_number_index, initial_stderr_stream):
7306 Now static.
7307 * lisp.h (Fprinc): Remove decl.
7308 (debug_output_compilation_hack): Mark as externally visible.
7309
adddb265
PE
7310 * sysdep.c (croak): Move decl from here to syssignal.h.
7311 * syssignal.h (croak): Put it here, so the API can be checked when
7312 'croak' is called from dissociate_if_controlling_tty.
7313
1717ede2
PE
7314 * minibuf.c: Make symbols static if they're not exported.
7315 (minibuf_save_list, choose_minibuf_frame): Now static.
7316 * lisp.h (choose_minibuf_frame): Remove decl.
7317
fa5fb2bc
PE
7318 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7319
1e3890d1
PE
7320 * lread.c: Make symbols static if they're not exported.
7321 (read_objects, initial_obarray, oblookup_last_bucket_number):
7322 Now static.
7323 (make_symbol): Remove; unused.
7324 * lisp.h (initial_obarray, make_symbol): Remove decls.
7325
8a1414fa
PE
7326 * keyboard.c: Make symbols static if they're not exported.
7327 (single_kboard, recent_keys_index, total_keys, recent_keys):
7328 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7329 (this_single_command_key_start, echoing, last_auto_save):
7330 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7331 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7332 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7333 (Vlispy_mouse_stem, double_click_count):
7334 Now static.
7335 (force_auto_save_soon): Define only if SIGDANGER.
7336 (ignore_mouse_drag_p): Now static if
7337 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7338 (print_help): Remove; unused.
7339 (stop_character, last_timer_event): Mark as externally visible.
7340 * keyboard.h (ignore_mouse_drag_p): Declare only if
7341 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7342 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7343 * lisp.h (echoing): Remove decl.
7344 (force_auto_save_soon): Declare only if SIGDANGER.
7345 * xdisp.c (redisplay_window): Simplify code, to make it more
7346 obvious that ignore_mouse_drag_p is not accessed if !defined
7347 USE_GTK && !defined HAVE_NS.
7348
93ea6e8f
PE
7349 * intervals.c: Make symbols static if they're not exported.
7350 (merge_properties_sticky, merge_interval_right, delete_interval):
7351 Now static.
7352 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7353
77382fcc
PE
7354 * insdel.c: Make symbols static if they're not exported.
7355 However, leave prepare_to_modify_buffer alone. It's never
7356 called from outside this function, but that appears to be a bug.
7357 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7358 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7359 (adjust_after_replace_noundo): Remove; unused.
7360 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7361 (signal_before_change): Remove decls.
77382fcc 7362
9306c32e
PE
7363 * indent.c (val_compute_motion, val_vmotion): Now static.
7364
cd44d2eb
PE
7365 * image.c: Make symbols static if they're not exported.
7366 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7367 if USE_GTK.
7368 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7369 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7370
ad9a7a06
PE
7371 * fringe.c (standard_bitmaps): Now static.
7372 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7373
81626931
PE
7374 * frame.c: Make symbols static if they're not exported.
7375 (x_report_frame_params, make_terminal_frame): Now static.
7376 (get_frame_param): Now static, unless HAVE_NS.
7377 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7378 (x_get_resource_string): Remove; not used.
7379 * frame.h (make_terminal_frame, x_report_frame_params):
7380 (x_get_resource_string); Remove decls.
7381 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7382 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7383
239f9db9
PE
7384 * font.c, fontset.c: Make symbols static if they're not exported.
7385 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7386 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7387 * font.c (font_close_object): Now static.
7388 * font.h (font_close_object): Remove.
7389 * fontset.c (FONTSET_OBJLIST): Remove.
7390 (free_realized_fontset) #if-0 the body, which does nothing.
7391 (face_suitable_for_char_p): #if-0, as it's never called.
7392 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7393 * xfaces.c (face_at_string_position):
7394 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7395 since 0 is always ASCII.
7396
dfcf3579
PE
7397 * fns.c (weak_hash_tables): Now static.
7398
5045092b
PE
7399 * fileio.c: Make symbols static if they're not exported.
7400 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7401 (Vwrite_region_annotation_buffers): Now static.
7402
57a96f5c
PE
7403 * eval.c: Make symbols static if they're not exported.
7404 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7405 * lisp.h (backtrace_list): Remove decl.
7406
35f08c38
PE
7407 * emacs.c: Make symbols static if they're not exported.
7408 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7409 (fatal_error_code, fatal_error_signal_hook, standard_args):
7410 Now static.
7411 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7412 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7413 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7414 * lisp.h (fatal_error_signal_hook): Remove decl.
7415 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7416
f44bd759
PE
7417 * editfns.c: Move a (normally-unused) function to its only use.
7418 * editfns.c, lisp.h (get_operating_system_release): Remove.
7419 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7420 worth the hassle of breaking this out.
7421
b532497d
PE
7422 * xterm.c: Make symbols static if they're not exported.
7423 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7424 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7425 (x_destroy_window, x_delete_display):
7426 Now static.
7427 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7428 (x_mouse_leave): Remove; unused.
7429 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7430 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7431 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7432 Remove decls.
7433 (x_mouse_leave): Declare only if WINDOWSNT.
7434 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7435 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7436 USE_X_TOOLKIT.
7437
1675728f
PE
7438 * ftxfont.c: Make symbols static if they're not exported.
7439 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7440 HAVE_FREETYPE.
7441 * font.h (ftxfont_driver): Likewise.
7442
e4cebfca
PE
7443 * xfns.c: Make symbols static if they're not exported.
7444 (x_last_font_name, x_display_info_for_name):
7445 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7446 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7447 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7448 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7449 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7450 (last_show_tip_args): Now static.
7451 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7452 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7453 (x_screen_planes): Remove; unused.
7454 * dispextern.h (x_screen_planes): Remove decl.
7455
5bf46f05
PE
7456 * dispnew.c: Make symbols static if they're not exported.
7457 * dispextern.h (redraw_garbaged_frames, scrolling):
7458 (increment_row_positions): Remove.
7459 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7460 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7461 Now static.
7462 (redraw_garbaged_frames): Remove; unused.
7463
435f4c28
PE
7464 * xfaces.c: Make symbols static if they're not exported.
7465 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7466 Remove decls.
7467 * xterm.h (defined_color): Remove decls.
7468 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7469 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7470 (menu_face_changed_default, defined_color, free_realized_face):
7471 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7472 (ascii_face_of_lisp_face): Remove; unused.
7473
8524aef3
PE
7474 * xdisp.c: Make symbols static if they're not exported.
7475 * dispextern.h (scratch_glyph_row, window_box_edges):
7476 (glyph_to_pixel_coords, set_cursor_from_row):
7477 (get_next_display_element, set_iterator_to_next):
7478 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7479 (show_mouse_face): Remove decls
7480 * frame.h (message_buf_print): Likewise.
7481 * lisp.h (pop_message, set_message, check_point_in_composition):
7482 Likewise.
7483 * xterm.h (set_vertical_scroll_bar): Likewise.
7484 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7485 (message_buf_print, scratch_glyph_row, displayed_buffer):
7486 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7487 (get_next_display_element, show_mouse_face, window_box_edges):
7488 (frame_to_window_pixel_xy, check_point_in_composition):
7489 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7490 (glyph_to_pixel_coords): Remove; unused.
7491
16390cd2
PE
7492 * dired.c (file_name_completion): Now static.
7493
7494 * dbusbind.c (xd_in_read_queued_messages): Now static.
7495
a25f4dfa
PE
7496 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7497 * data.c (circular_list_error): Remove.
7498
14a9c8df
PE
7499 * commands.h (last_point_position, last_point_position_buffer):
7500 (last_point_position_window): Remove decls.
7501 * keyboard.c: Make these variables static.
7502
04f2d78b
CB
7503 * coding.h (coding, code_convert_region, encode_coding_gap):
7504 Remove decls.
74ab6df5
PE
7505 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7506 (iso_code_class, detect_coding, code_convert_region): Now static.
7507 (encode_coding_gap): Remove; unused.
7508
38dfbee1
PE
7509 * chartab.c (chartab_chars, chartab_bits): Now static.
7510
a2cb4e63
PE
7511 * charset.h (charset_iso_8859_1): Remove decl.
7512 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7513 Now static.
7514
127198fd
PE
7515 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7516 * ccl.c (Vccl_program_table): Now static.
7517 (check_ccl_update): Remove; unused.
7518
d85b608f
PE
7519 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7520 * category.h: ... from here.
7521 * category.c (check_category_table, set_category_set): Now static.
7522
31cd66f3
PE
7523 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7524 * lisp.h: Remove these decls.
7525
c358e587
PE
7526 * buffer.c (buffer_count): Remove unused var.
7527
e78aecca
PE
7528 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7529 so that it's not optimized away.
7530 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7531 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7532 exported only to the debugger.
7533
e192d7d3 7534 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7535 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7536
92470028
PE
7537 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7538 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7539 was inaccessible from Lisp.
7540 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7541 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7542
244ed907
PE
7543 alloc.c: Import and export fewer symbols, and remove unused items.
7544 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7545 is defined.
7546 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7547 it's not optimized away by whole-program optimization.
7548 (message_enable_multibyte, free_misc): Remove.
7549 (catchlist, handlerlist, mark_backtrace):
7550 Declare only if BYTE_MARK_STACK.
7551 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7552 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7553 (message_enable_multibyte): Remove decl.
7554 (free_misc, interval_free_list, float_block, float_block_index):
7555 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7556 (cons_free_list, last_marked_index):
7557 Now static.
7558 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7559 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7560 (mark_backtrace): Define only if BYTE_MARK_STACK.
7561 * xdisp.c (message_enable_multibyte): Now static.
7562
61c2b50e 7563 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7564 This makes it easier for human readers (and static analyzers)
7565 to see whether these variables are used from other modules.
7566 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7567 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7568 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7569 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7570 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7571 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7572 * xmenu.c, xselect.c:
7573 Declare Q* vars static if they are not used in other modules.
7574 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7575 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7576 Remove decls of unexported vars.
7577 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7578
95c82688
PE
7579 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7580
16a97296
PE
7581 Make Emacs functions such as Fatom 'static' by default.
7582 This makes it easier for human readers (and static analyzers)
7583 to see whether these functions can be called from other modules.
7584 DEFUN now defines a static function. To make the function external
7585 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7586 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7587 (Finit_image_library):
16a97296
PE
7588 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7589 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7590 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7591 Remove decls, since these functions are now static.
7592 (Funintern, Fget_internal_run_time): New decls, since these functions
7593 were already external.
95c82688 7594
16a97296
PE
7595 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7596 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7597 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7598 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7599 * keyboard.c, keymap.c, lread.c:
7600 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7601 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7602 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7603 Mark functions with DEFUE instead of DEFUN,
7604 if they are used in other modules.
7605 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7606 decls for now-static functions.
7607 * buffer.h (Fdelete_overlay): Remove decl.
7608 * callproc.c (Fgetenv_internal): Mark as internal.
7609 * composite.c (Fremove_list_of_text_properties): Remove decl.
7610 (Fcomposition_get_gstring): New forward static decl.
7611 * composite.h (Fcomposite_get_gstring): Remove decl.
7612 * dired.c (Ffile_attributes): New forward static decl.
7613 * doc.c (Fdocumntation_property): New forward static decl.
7614 * eval.c (Ffetch_bytecode): New forward static decl.
7615 (Funintern): Remove extern decl; now in .h file where it belongs.
7616 * fileio.c (Fmake_symbolic_link): New forward static decl.
7617 * image.c (Finit_image_library): New forward static decl.
7618 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7619 * intervals.h (Fprevious_property_change):
7620 (Fremove_list_of_text_properties): Remove decls.
7621 * keyboard.c (Fthis_command_keys): Remove decl.
7622 (Fcommand_execute): New forward static decl.
7623 * keymap.c (Flookup_key): New forward static decl.
7624 (Fcopy_keymap): Now static.
7625 * keymap.h (Flookup_key): Remove decl.
7626 * process.c (Fget_process): New forward static decl.
7627 (Fprocess_datagram_address): Mark as internal.
7628 * syntax.c (Fsyntax_table_p): New forward static decl.
7629 (skip_chars): Remove duplicate decl.
7630 * textprop.c (Fprevious_property_change): New forward static decl.
7631 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7632 Now internal.
7633 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7634 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7635
785bbd42
PE
7636 * editfns.c (Fformat): Remove unreachable code.
7637
8b913b57
AS
76382011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7639
7640 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7641 change. (Bug#8496)
7642
a6744a35
EZ
76432011-04-13 Eli Zaretskii <eliz@gnu.org>
7644
7645 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7646 when at ZV. (Bug#8487)
7647
e7974947
AS
76482011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7649
baad03f0
AS
7650 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7651 (Bug#8437)
7652 * keyboard.c (parse_tool_bar_item): Likewise.
7653 * sound.c (sound_cleanup, alsa_close): Likewise.
7654 * termcap.c (tgetent): Likewise.
7655 * xfns.c (x_default_font_parameter): Likewise.
7656 * xsettings.c (read_and_apply_settings): Likewise.
7657
e7974947
AS
7658 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7659 (overrun_check_free): Protoize.
7660
28272684
PE
76612011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7662
7663 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7664 since callers should never pass a negative size.
7665 Change the signature to match that of plain 'read' and 'write'; see
7666 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7667 * lisp.h: Update prototypes of emacs_write and emacs_read.
7668
11997c76
EZ
76692011-04-11 Eli Zaretskii <eliz@gnu.org>
7670
7671 * xdisp.c (redisplay_window): Don't try to determine the character
7672 position of the scroll margin if the window start point w->startp
e896f03c 7673 is outside the buffer's accessible region. (Bug#8468)
11997c76 7674
8a2cbd72
EZ
76752011-04-10 Eli Zaretskii <eliz@gnu.org>
7676
7677 Fix write-region and its subroutines for buffers > 2GB.
7678 * fileio.c (a_write, e_write): Modify declaration of arguments and
7679 local variables to support buffers larger than 2GB.
7680 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7681
7682 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7683 argument, local variables, and return value.
7684
7685 * lisp.h: Update prototypes of emacs_write and emacs_read.
7686
7687 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7688
4073e537 76892011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7690
1ebfdcb6
PE
7691 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7692
b2ded58d
PE
7693 Fix more problems found by GCC 4.6.0's static checks.
7694
7d66342c
PE
7695 * xdisp.c (vmessage): Use a better test for character truncation.
7696
bbf47d44
PE
7697 * charset.c (load_charset_map): <, not <=, for optimization,
7698 and to avoid potential problems with integer overflow.
9248994d 7699 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7700 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7701 * editfns.c (Fformat): Likewise.
1e69125e 7702 * syntax.c (skip_chars): Likewise.
3befa583 7703
e3019616
PE
7704 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7705 This also lets GCC 4.6.0 generate slightly better loop code.
7706
becfa255
PE
7707 * callint.c (Fcall_interactively): <, not <=, for optimization.
7708 (Fcall_interactively): Count the number of arguments produced,
7709 not the number of arguments given. This is simpler and lets GCC
7710 4.6.0 generate slightly better code.
7711
dae0cd48
PE
7712 * ftfont.c: Distingish more carefully between FcChar8 and char.
7713 The previous code passed unsigned char * to a functions like
7714 strlen and xstrcasecmp that expect char *, which does not
7715 conform to the C standard.
7716 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7717 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7718 char * when the C standard requires it.
7719
76032d70
PE
7720 * keyboard.c (read_char): Remove unused var.
7721
eb3f1cc8
PE
7722 * eval.c: Port to Windows vsnprintf (Bug#8435).
7723 Include <limits.h>.
7724 (SIZE_MAX): Define if the headers do not.
7725 (verror): Do not give up if vsnprintf returns a negative count.
7726 Instead, grow the buffer. This ports to Windows vsnprintf, which
7727 does not conform to C99. Problem reported by Eli Zaretskii.
7728 Also, simplify the allocation scheme, by avoiding the need for
7729 calling realloc, and removing the ALLOCATED variable.
7730
70476b54
PE
7731 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7732
12020a9e
PE
7733 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7734 But keep the doprint source code for now, as we might revamp it
7735 and use it again (Bug#8435).
ea6c7ae6
PE
7736 * lisp.h (doprnt): Remove.
7737 * Makefile.in (base_obj): Remove doprnt.o.
7738 * deps.mk (doprnt.o): Remove.
7739
5fdb398c
PE
7740 error: Print 32- and 64-bit integers portably (Bug#8435).
7741 Without this change, on typical 64-bit hosts error ("...%d...", N)
7742 was used to print both 32- and 64-bit integers N, which relied on
7743 undefined behavior.
7744 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7745 New macro.
7746 * lisp.h (error, verror): Mark as printf-like functions.
7747 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7748 Report overflow in size calculations when allocating printf buffer.
7749 Do not truncate output string at its first null byte.
7750 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7751 Truncate the output at a character boundary, since vsnprintf does not
7752 do that.
7753 * charset.c (check_iso_charset_parameter): Convert internal
7754 character to string before calling 'error', since %c now has the
7755 printf meaning.
7756 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7757 overflow when computing char to be passed to 'error'. Do not
7758 pass Lisp_Object to 'error'; pass the integer instead.
7759 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7760 formatted with plain %d.
7761
b189fa66
PE
7762 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7763
bff87ef0
PE
7764 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7765
7e2cac20
PE
7766 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7767
ce4d90b5
PE
7768 * xterm.c (x_catch_errors): Remove duplicate declaration.
7769
266c9547
PE
7770 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7771
79c49ad2
PE
7772 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7773
368f4090
JM
77742011-04-10 Jim Meyering <meyering@redhat.com>
7775
7776 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7777 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7778 return ssize_t not "int", and use size_t as the buffer length.
7779 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7780 * gnutls.h: Update declarations.
7781 * process.c (read_process_output): Use ssize_t, to match.
7782 (send_process): Likewise.
7783
a32d4040
CY
77842011-04-09 Chong Yidong <cyd@stupidchicken.com>
7785
7786 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7787
8546720e 77882011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7789
04f2d78b
CB
7790 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7791 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7792
8546720e
GM
7793 * xterm.c (handle_one_xevent):
7794 * xmenu.c (create_and_show_popup_menu):
7795 * xselect.c (x_decline_selection_request)
7796 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7797
0a2f5c1a 77982011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7799
7800 Fix some uses of `int' instead of EMACS_INT.
7801 * search.c (string_match_1, fast_string_match)
7802 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7803 (scan_buffer, find_next_newline_no_quit)
7804 (find_before_next_newline, search_command, Freplace_match)
7805 (Fmatch_data): Make some `int' variables be EMACS_INT.
7806
7807 * xdisp.c (display_count_lines): 3rd argument and return value now
7808 EMACS_INT. All callers changed.
7809 (pint2hrstr): Last argument is now EMACS_INT.
7810
7811 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7812 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7813 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7814 (decode_coding_utf_16, decode_coding_emacs_mule)
7815 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7816 (decode_coding_ccl, decode_coding_charset)
7817 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7818 (decode_coding_iso_2022, decode_coding_emacs_mule)
7819 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7820 <char_offset, last_offset>: Declare EMACS_INT.
7821 (encode_coding_utf_8, encode_coding_utf_16)
7822 (encode_coding_emacs_mule, encode_invocation_designation)
7823 (encode_designation_at_bol, encode_coding_iso_2022)
7824 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7825 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7826 Declare EMACS_INT.
7827 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7828 (encode_invocation_designation): Last argument P_NCHARS is now
7829 EMACS_INT.
7830 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7831 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7832
7833 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7834 All users changed.
7835
7836 * ccl.c (Fccl_execute_on_string): Declare some variables
7837 EMACS_INT.
7838
8546720e 78392011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7840
7841 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7842
4e19a977
CS
78432011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7844
7845 * process.c (Fformat_network_address): Doc fix.
7846
87302331
R
78472011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7848
ee7683eb 7849 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7850
cbb59342
CY
78512011-04-08 Chong Yidong <cyd@stupidchicken.com>
7852
7853 * keyboard.c (read_char): Call Lisp function help-form-show,
7854 instead of using internal_with_output_to_temp_buffer.
7855 (Qhelp_form_show): New var.
e0d38eeb 7856 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7857
7858 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7859
7860 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7861
e67a13ab
CY
78622011-04-06 Chong Yidong <cyd@stupidchicken.com>
7863
04f2d78b
CB
7864 * process.c (Flist_processes): Remove to Lisp.
7865 (list_processes_1): Delete.
e67a13ab 7866
973f782d
EZ
78672011-04-06 Eli Zaretskii <eliz@gnu.org>
7868
7c106b1e
EZ
7869 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7870
973f782d
EZ
7871 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7872
41cf7d1a 78732011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7874
ca23cc88
PE
7875 Fix more problems found by GCC 4.6.0's static checks.
7876
f390e2d5
PE
7877 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7878
42eea0d0
PE
7879 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7880
b69769da 7881 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7882
f9541e84
PE
7883 * xdisp.c (vmessage): Mark as a printf-like function.
7884
13841b55
PE
7885 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7886
c136c10f
PE
7887 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7888
5e2d4a30
PE
7889 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7890 printf-like functions.
7891 (tiff_load): Add casts to remove these marks before passing them
7892 to system-supplied API.
7893
583f48b9
PE
7894 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7895
b25d760e
PE
7896 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7897 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7898 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7899 directly, rather than having caller test rule sign. This avoids
7900 some unnecessary tests.
7901 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7902 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7903 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7904
bc7b6697 7905 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7906 (xfont_open): Avoid unnecessary tests.
bc7b6697 7907
27ccc379
PE
7908 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7909
dcd5c89a
PE
7910 * composite.h, composite.c (composition_gstring_put_cache):
7911 Use EMACS_INT, not int, for length.
7912
b13a45c6
PE
7913 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7914 breaking out part of COMPOSITION_DECODE_RULE.
7915 (COMPOSITION_DECODE_RULE): Use it.
7916 * composite.c (get_composition_id): Remove unused local vars,
7917 by using the new macro.
7918
1e792e4d
PE
7919 * textprop.c (set_text_properties_1): Change while to do-while,
7920 since the condition is always true at first.
7921
dc6c6455 7922 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7923 (interval_deletion_adjustment): Return unsigned value.
7924 All uses changed.
dc6c6455 7925
aba7731a
PE
7926 * process.c (list_processes_1, create_pty, read_process_output):
7927 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7928 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7929 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7930 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7931 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7932
fdfc4bf3
PE
7933 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7934
fca8fe46 7935 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7936 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7937
06a0259a 7938 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7939 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7940 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7941
e7b9e80f
PE
7942 * print.c (print_error_message): Avoid int overflow.
7943
56201685
PE
7944 * font.c (font_list_entities): Redo for clarity,
7945 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7946
78834453 7947 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7948 (font_score): Avoid potential overflow in diff calculation.
78834453 7949
0bc0b309 7950 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7951 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7952
e610eaca
PE
7953 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7954
b895abce
PE
7955 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7956 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7957 can always succeed if overflow has undefined behavior.
7958
1f1d9321 7959 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7960 (wordify): Omit three unnecessary tests.
1f1d9321 7961
c59478bc
PE
7962 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7963 All callers changed. This avoids the need for an unused var.
7964
79b73827
PE
7965 * casefiddle.c (casify_region): Remove var that is set but not used.
7966
a4db5dfe
PE
7967 * dired.c (file_name_completion): Remove var that is set but not used.
7968
43aae36e
PE
7969 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7970
2a47c44d 7971 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7972 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7973
a37c69bf
PE
7974 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7975 Check for integer overflow on size calculations.
7976
328ab8e7
PE
7977 * buffer.c (Fprevious_overlay_change): Remove var that is set
7978 but not used.
7979
e5a2a5cb
PE
7980 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7981 Remove vars that are set but not used.
8d84a6eb 7982 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7983 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7984
a60e5f68
PE
7985 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7986
f661cb61 7987 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7988 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7989
f0397f5a
PE
7990 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7991 that are set but not used.
7992
8664db06 7993 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7994 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7995
6abdaa4a
PE
7996 * xselect.c (x_get_local_selection, x_handle_property_notify):
7997 Remove vars that are set but not used.
7998
0ce7538d 7999 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8000 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8001
9ae848fc
PE
8002 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8003 Remove var that is set but not used.
0b918413
PE
8004 (scroll_bar_windows_size): Now size_t, not int.
8005 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8006 Check for overflow.
9ae848fc 8007
a5a62657
PE
8008 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8009 (map_tty_color) [!defined MSDOS]: Likewise.
8010
5c5cdd39
PE
8011 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8012
66ebf983
PE
8013 * coding.c: Remove vars that are set but not used.
8014 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8015 All callers changed.
8016 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8017 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8018 (decode_coding_charset): Remove vars that are set but not used.
8019
1be4d761
PE
8020 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8021 that is set but not used.
8022
47553fa8
PE
8023 * print.c (print_object): Remove var that is set but not used.
8024
1f7196bf 8025 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8026 The gnulib version avoids calling malloc in the usual case,
8027 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8028 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8029 * filelock.c (current_lock_owner): Likewise.
8030 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8031 * sysdep.c: Include allocator.h, careadlinkat.h.
8032 (emacs_no_realloc_allocator): New static constant.
8033 (emacs_readlink): New function.
fdb61804
PE
8034 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8035 ../lib/careadlinkat.h.
d1fdcab7 8036
f84c17c7
SM
80372011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8038
8039 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8040 first non-nil return value).
8041
ef3862ad
JD
80422011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8043
8044 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8045 if not defined (Bug#8403).
8046
376a7006
JB
80472011-04-02 Juanma Barranquero <lekktu@gmail.com>
8048
8049 * xdisp.c (display_count_lines): Remove parameter `start',
8050 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8051 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8052 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8053 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8054 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8055 and thereabouts. All callers changed.
8056 (get_per_char_metric): Remove parameter `f', unused since
8057 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8058
6ca3801d
JM
80592011-04-02 Jim Meyering <meyering@redhat.com>
8060
8061 do not dereference NULL upon failed strdup
8062 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8063 (ns_get_family): Likewise.
8064
d8e2b5ba
JB
80652011-04-02 Juanma Barranquero <lekktu@gmail.com>
8066
8067 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8068
8c74fcbd
JD
80692011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8070
8071 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8072 later (Bug#8403).
8073
7200d79c
SM
80742011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8075
03408648 8076 Add lexical binding.
7200d79c 8077
03408648
SM
8078 * window.c (Ftemp_output_buffer_show): New fun.
8079 (Fsave_window_excursion):
8080 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8081
8082 * lread.c (lisp_file_lexically_bound_p): New function.
8083 (Fload): Bind Qlexical_binding.
8084 (readevalloop): Remove `evalfun' arg.
8085 Bind Qinternal_interpreter_environment.
8086 (Feval_buffer): Bind Qlexical_binding.
8087 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8088 Mark as dynamic.
8089 (syms_of_lread): Declare `lexical-binding'.
8090
8091 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8092
8093 * keyboard.c (eval_dyn): New fun.
8094 (menu_item_eval_property): Use it.
ca105506
SM
8095
8096 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8097
03408648
SM
8098 * fns.c (concat, mapcar1): Accept byte-code-functions.
8099
8100 * eval.c (Fsetq): Handle lexical vars.
8101 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8102 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8103 (FletX, Flet): Obey lexical binding.
8104 (Fcommandp): Handle closures.
8105 (Feval): New `lexical' arg.
8106 (eval_sub): New function extracted from Feval. Use it almost
8107 everywhere where Feval was used. Look up vars in lexical env.
8108 Handle closures.
8109 (Ffunctionp): Move from subr.el.
8110 (Ffuncall): Handle closures.
8111 (apply_lambda): Remove `eval_flags'.
8112 (funcall_lambda): Handle closures and new byte-code-functions.
8113 (Fspecial_variable_p): New function.
8114 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8115 but without exporting it to Lisp.
23aba0ea 8116
23aba0ea 8117 * doc.c (Fdocumentation, store_function_docstring):
03408648 8118 * data.c (Finteractive_form): Handle closures.
23aba0ea 8119
03408648
SM
8120 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8121 interactive spec.
ba83908c 8122
04f2d78b
CB
8123 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8124 New byte-codes.
03408648
SM
8125 (exec_byte_code): New function extracted from Fbyte_code to handle new
8126 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8127
03408648 8128 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8129
03408648 8130 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8131
e2abce01
JB
81322011-03-31 Juanma Barranquero <lekktu@gmail.com>
8133
8134 * xdisp.c (redisplay_internal): Fix prototype.
8135
63696a73 81362011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8137
63696a73 8138 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8139 (try_scrolling): Use it when setting scroll_limit.
8140 Limit scrolling to 100 screen lines.
63696a73
EZ
8141 (redisplay_window): Even when falling back on "recentering",
8142 position point in the window according to scroll-conservatively,
8143 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8144
8145 (try_scrolling): When point is above the window, allow searching
8146 as far as scroll_max, or one screenful, to compute vertical
8147 distance from PT to the scroll margin position. This prevents
8148 try_scrolling from unnecessarily failing when
8149 scroll-conservatively is set to a value slightly larger than the
8150 window height. Clean up the case of PT below the margin at bottom
8151 of window: scroll_max can no longer be INT_MAX. When aggressive
8152 scrolling is in use, don't let point enter the opposite scroll
8153 margin as result of the scroll.
8154 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8155 threshold of 100 lines for never-recentering scrolling.
8156
e4cc2dfc
JB
81572011-03-31 Juanma Barranquero <lekktu@gmail.com>
8158
8159 * dispextern.h (move_it_by_lines):
8160 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8161 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8162 (message_log_check_duplicate): Remove parameters `prev_bol' and
8163 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8164 (redisplay_internal): Remove parameter `preserve_echo_area',
8165 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8166
8167 * indent.c (Fvertical_motion):
8168 * window.c (window_scroll_pixel_based, Frecenter):
8169 Don't pass `need_y_p' to `move_it_by_lines'.
8170
1c470562
SM
81712011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8172
44f230aa
SM
8173 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8174 steal a few bits to be more compact.
8175 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8176 Remove unneeded casts.
8177
1c470562
SM
8178 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8179
888adce9
ZK
81802011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8181
8182 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8183 binding" message (bug#7967).
8184
f838ed7b
PE
81852011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8186
77861b95
PE
8187 Fix more problems found by GCC 4.6.0's static checks.
8188
de6dbc14
PE
8189 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8190 Remove unused local var.
8191
f838ed7b
PE
8192 * editfns.c (Fmessage_box): Remove unused local var.
8193
792c7b2b
PE
8194 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8195 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8196 Omit unused local vars.
c499e557 8197 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8198 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8199 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8200 Omit unused local var.
8201
ba0165e1
PE
8202 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8203 Don't assume string length fits in int.
32ad8845 8204 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8205 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8206
3c59b4c9
PE
8207 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8208 instead of alloca (Bug#8344).
8209
a3eed478 8210 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8211 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8212
eb4d412d
PE
8213 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8214
1658b401
PE
8215 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8216 concerns.
8217
8218 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8219
8220 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8221
9a2c6e05
PE
8222 * keyboard.c (syms_of_keyboard): Use the same style as later
8223 in this function when indexing through an array. This also
8224 works around GCC bug 48267.
8225
03d0a109
PE
8226 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8227
44f730c8
PE
8228 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8229
fe75f926
PE
8230 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8231 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8232
ffa8c828
PE
8233 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8234 This avoids undefined behavior on integer overflow, and is a bit
8235 more convenient anyway since it is compared to a size_t variable.
8236
c5101a77
PE
8237 Variadic C functions now count arguments with size_t, not int.
8238 This avoids an unnecessary limitation on 64-bit machines, which
8239 caused (substring ...) to crash on large vectors (Bug#8344).
8240 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8241 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8242 All variadic functions and their callers changed accordingly.
c5101a77
PE
8243 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8244 * data.c (arith_driver, float_arith_driver): Likewise.
8245 * editfns.c (general_insert_function): Likewise.
8246 * eval.c (struct backtrace.nargs, interactive_p)
8247 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8248 (funcall_lambda, mark_backtrace): Likewise.
8249 * fns.c (concat): Likewise.
8250 * frame.c (x_set_frame_parameters): Likewise.
8251 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8252 0 if not found, not -1. All callers changed.
8253
dd3f25f7
PE
8254 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8255 (stack_copy_size): Now size_t, not int.
8256 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8257
461c2ab9
JB
82582011-03-28 Juanma Barranquero <lekktu@gmail.com>
8259
8260 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8261 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8262 All callers changed.
8263
8264 * lisp.h (multibyte_char_to_unibyte):
8265 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8266 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8267 * character.h (CHAR_TO_BYTE8):
8268 * cmds.c (internal_self_insert):
8269 * editfns.c (general_insert_function):
8270 * keymap.c (push_key_description):
8271 * search.c (Freplace_match):
8272 * xdisp.c (message_dolog, set_message_1): All callers changed.
8273
f6d62986
SM
82742011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8275
8276 * keyboard.c (safe_run_hook_funcall): New function.
8277 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8278 don't set the hook to nil, but remove the offending function instead.
8279 (Qcommand_hook_internal): Remove, unused.
8280 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8281 Vcommand_hook_internal.
8282
8283 * eval.c (enum run_hooks_condition): Remove.
8284 (funcall_nil, funcall_not): New functions.
8285 (run_hook_with_args): Call each function through a `funcall' argument.
8286 Remove `cond' argument, now redundant.
8287 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8288 (Frun_hook_with_args_until_failure): Adjust accordingly.
8289 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8290
1db5b1ad
JB
82912011-03-28 Juanma Barranquero <lekktu@gmail.com>
8292
8293 * dispextern.h (string_buffer_position): Remove declaration.
8294
8295 * print.c (strout): Remove parameter `multibyte', unused since
8296 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8297
8298 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8299 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8300 All callers changed.
8301
8302 * w32.c (_wsa_errlist): Use braces for struct initializers.
8303
8304 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8305 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8306 All callers changed.
8307 (string_buffer_position): Likewise. Also, make static (it's never
8308 used outside xdisp.c).
8309 (cursor_row_p): Remove parameter `w', unused since
8310 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8311 (decode_mode_spec): Remove parameter `precision', introduced during
8312 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8313 All callers changed.
8314
5ffb62aa
JD
83152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8316
8317 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8318
461c2ab9 83192011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8320
8321 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8322 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8323 (ns_update_auto_hide_menu_bar): New functions.
8324 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8325 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8326 ns_constrain_all_frames.
8327 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8328 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8329
5c380ffb
JD
83302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8331
8332 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8333
9af30bdf
GM
83342011-03-27 Glenn Morris <rgm@gnu.org>
8335
8336 * syssignal.h: Replace RETSIGTYPE with void.
8337 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8338 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8339 Replace SIGTYPE with void everywhere.
8340 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8341 * s/template.h (SIGTYPE): Remove commented out definition.
8342
e2abce01
JB
83432011-03-26 Eli Zaretskii <eliz@gnu.org>
8344
8345 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8346 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8347
f868cd8a
JB
83482011-03-26 Juanma Barranquero <lekktu@gmail.com>
8349
59eb0929
JB
8350 * w32.c (read_unc_volume): Use parameter `henum', instead of
8351 global variable `wget_enum_handle'.
8352
8353 * keymap.c (describe_vector): Remove parameters `indices' and
8354 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8355 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8356
f868cd8a
JB
8357 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8358
8359 * keyboard.c (timer_check): Remove parameter `do_it_now',
8360 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8361 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8362 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8363
8364 * keyboard.c (read_char):
8365 * w32menu.c (w32_menu_display_help):
8366 * xmenu.c (show_help_event, menu_help_callback):
8367 Adjust calls to `show_help_echo'.
8368
8369 * gtkutil.c (xg_maybe_add_timer):
8370 * keyboard.c (readable_events):
8371 * process.c (wait_reading_process_output):
8372 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8373
8374 * insdel.c (adjust_markers_gap_motion):
8375 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8376 (gap_left, gap_right): Don't call it.
8377
2ecf6fdb
CY
83782011-03-25 Chong Yidong <cyd@stupidchicken.com>
8379
8380 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8381 incurred during fontification.
8382
6b1f9ba4
JB
83832011-03-25 Juanma Barranquero <lekktu@gmail.com>
8384
8385 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8386 (DEFVAR_PER_BUFFER): Don't pass it.
8387
8388 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8389 (scrolling_window): Don't pass it.
8390
0f4a96b5
JB
83912011-03-25 Juanma Barranquero <lekktu@gmail.com>
8392
8393 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8394
8395 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8396 and `suffix'.
8397 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8398 of variables specific to SELinux and computation of `encoded_absname'.
8399
8400 * image.c (XPutPixel): Remove unused variable `height'.
8401
8402 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8403
8404 * unexw32.c (get_section_info): Remove unused variable `section'.
8405
8406 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8407 (system_process_attributes): Remove unused variable `sess'.
8408 (sys_read): Remove unused variable `err'.
8409
8410 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8411 (w32_wnd_proc): Remove unused variable `isdead'.
8412 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8413 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8414 (x_create_tip_frame): Remove unused variable `tem'.
8415
8416 * w32inevt.c (w32_console_read_socket):
8417 Remove unused variable `no_events'.
8418
8419 * w32term.c (x_draw_composite_glyph_string_foreground):
8420 Remove unused variable `width'.
8421
1149507c
JB
84222011-03-24 Juanma Barranquero <lekktu@gmail.com>
8423
8424 * w32term.c (x_set_glyph_string_clipping):
8425 Don't pass uninitialized region to CombineRgn.
8426
9c88f339
JB
84272011-03-23 Juanma Barranquero <lekktu@gmail.com>
8428
8429 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8430 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8431 (Fx_close_connection): Remove unused variable `i'.
8432
8433 * w32font.c (w32font_draw): Return number of glyphs.
8434 (w32font_open_internal): Remove unused variable `i'.
8435 (w32font_driver): Add missing initializer.
8436
8437 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8438 (fill_in_menu): Remove unused variable `items_added'.
8439
8440 * w32term.c (last_mouse_press_frame): Remove static global variable.
8441 (w32_clip_to_row): Remove unused variable `f'.
8442 (x_delete_terminal): Remove unused variable `i'.
8443
8444 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8445 (NOTHING): Remove unused static global variable.
8446 (uniscribe_check_otf): Remove unused variable `table'.
8447 (uniscribe_font_driver): Add missing initializers.
8448
dee091a3
JD
84492011-03-23 Julien Danjou <julien@danjou.info>
8450
8451 * term.c (Fsuspend_tty, Fresume_tty):
8452 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8453 * window.c (temp_output_buffer_show):
8454 * insdel.c (signal_before_change):
8455 * frame.c (Fhandle_switch_frame):
8456 * fileio.c (Fdo_auto_save):
8457 * emacs.c (Fkill_emacs):
8458 * editfns.c (save_excursion_restore):
8459 * cmds.c (internal_self_insert):
8460 * callint.c (Fcall_interactively):
8461 * buffer.c (Fkill_all_local_variables):
8462 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8463 Use Frun_hooks.
0f4a96b5 8464 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8465 unconditionally since it does the check itself.
dee091a3 8466
2c520ab5 84672011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8468
c9c49752
PE
8469 Fix more problems found by GCC 4.5.2's static checks.
8470
8abc3f12
PE
8471 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8472 the first time through the loop, since we know p0 < p1 then.
8473 This also avoids a gcc -Wstrict-overflow warning.
8474
a2d26660
PE
8475 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8476 leading to a memory leak, possible in functions like
8477 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8478 of objects (Bug#8318).
a2d26660 8479
916c72e9
PE
8480 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8481 that could (at least in theory) be that large.
8482
19ab8a18
PE
8483 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8484 This is less likely to overflow, and avoids undefined behavior if
8485 overflow does occur. All callers changed. Use strtoul to scan
8486 for the unsigned long integer.
b7cbbd6f
PE
8487 (pint2hrstr): Simplify and tune code slightly.
8488 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8489
f0641eff
PE
8490 * scroll.c (do_scrolling): Work around GCC bug 48228.
8491 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8492
7f650bb9
PE
8493 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8494 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8495 (validate_x_resource_name): Simplify count usage.
8496 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8497
37dd57d1
PE
8498 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8499 fail (Bug#8306).
81e56e61 8500
699979fc 8501 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8502
401bf9b4
PE
8503 * process.c (Fmake_network_process): Use socklen_t, not int,
8504 where POSIX says socklen_t is required in portable programs.
8505 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8506 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8507 (Fmake_network_process, server_accept_connection):
8508 (wait_reading_process_output, read_process_output):
8509 Likewise.
8510
b93aacde
PE
8511 * process.c: Rename or move locals to avoid shadowing.
8512 (list_processes_1, Fmake_network_process):
8513 (read_process_output_error_handler, exec_sentinel_error_handler):
8514 Rename or move locals.
4dc343ee 8515 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8516 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8517 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8518 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8519 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8520
af8a867c 8521 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8522 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8523 Include tparam.h instead, since it declares them.
af8a867c
PE
8524 * cm.h (PC): Remove extern decl; tparam.h now does this.
8525 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8526 * terminfo.c: Include tparam.h, to check interfaces.
8527 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8528 (tparam): Adjust signature to match interface in tparam.h;
8529 this removes some undefined behavior. Check that outstring and len
8530 are zero, which they always are with Emacs.
8531 * tparam.h (PC, BC, UP): New extern decls.
8532
0248044d 8533 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8534 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8535
8ff096c1 8536 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8537 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8538 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8539 (ftfont_list): Remove unused local.
49eaafba
PE
8540 (get_adstyle_property, ftfont_pattern_entity):
8541 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8542 Rename locals to avoid shadowing.
8ff096c1 8543
e2be39f6
PE
8544 * xfont.c (xfont_list_family): Mark var as initialized.
8545
c9735e30
PE
8546 * xml.c (make_dom): Now static.
8547
8f5201ae
PE
8548 * composite.c (composition_compute_stop_pos): Rename local to
8549 avoid shadowing.
b246f932
PE
8550 (composition_reseat_it): Remove unused locals.
8551 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8552 (composition_update_it): Mark var as initialized.
11b61122
PE
8553 (find_automatic_composition): Mark vars as initialized,
8554 with a FIXME (Bug#8290).
8f5201ae 8555
760fbc2c
PE
8556 character.h: Rename locals to avoid shadowing.
8557 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8558 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8559 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8560 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8561 to avoid shadowing.
8562
ff08eb85
PE
8563 * textprop.c (property_change_between_p): Remove; unused.
8564
fc7bf025
PE
8565 * intervals.c (interval_start_pos): Now static.
8566
235d7abc
PE
8567 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8568
44f230aa
SM
8569 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8570 Rename locals to avoid shadowing.
3e7d6594 8571
50060332
PE
8572 * sound.c (wav_play, au_play, Fplay_sound_internal):
8573 Fix pointer signedness.
d01f234b 8574 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8575 (wav_play): Initialize a variable to 0, to prevent undefined
8576 behavior (Bug#8278).
50060332 8577
c4fc4e30
PE
8578 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8579
918436ed
PE
8580 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8581
c939f91b
PE
8582 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8583 clobbering (Bug#8298).
b9c7f648
PE
8584 * sysdep.c (sys_subshell): Likewise.
8585 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8586
6bd8c144
PE
8587 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8588 This should get cleaned up, so that child_setup has the
8589 same signature on all platforms.
8590
7710357c 8591 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8592 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8593
c59da222
CY
85942011-03-22 Chong Yidong <cyd@stupidchicken.com>
8595
8596 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8597 not to be necessary, and produces flickering.
8598
66b87493
GM
85992011-03-20 Glenn Morris <rgm@gnu.org>
8600
8601 * config.in: Remove file.
8602
45b6f6d5
JB
86032011-03-20 Juanma Barranquero <lekktu@gmail.com>
8604
8605 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8606 are now in src/globals.h.
8607 (syms_of_minibuf): Remove spurious & from previous change.
8608
cd394be1 86092011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8610
8611 * minibuf.c (completing-read-function): New variable.
8612 (completing-read-default): Rename from completing-read.
8613 (completing-read): Call completing-read-function.
8614
b14e3e21
CY
86152011-03-19 Juanma Barranquero <lekktu@gmail.com>
8616
8617 * xfaces.c (Fx_load_color_file):
8618 Read color file from absolute filename (bug#8250).
8619
f2b726e6
JB
86202011-03-19 Juanma Barranquero <lekktu@gmail.com>
8621
8622 * makefile.w32-in: Update dependencies.
8623
09f6ff02
EZ
86242011-03-17 Eli Zaretskii <eliz@gnu.org>
8625
8626 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8627
29a6015a
PE
86282011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8629
a3a6c54e
PE
8630 Fix more problems found by GCC 4.5.2's static checks.
8631
b766f867
PE
8632 * process.c (make_serial_process_unwind, send_process_trap):
8633 (sigchld_handler): Now static.
8634
be02381c
PE
8635 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8636 That way, the code declares only the vars that it needs.
8637 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8638 * s/cygwin.h (PTY_ITERATION): Likewise.
8639 * s/darwin.h (PTY_ITERATION): Likewise.
8640 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8641
57048744
PE
8642 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8643 * process.c (allocate_pty): Don't declare stb unless it's needed.
8644
7914961c 8645 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8646 (CONSTANTLIM): Remove; unused.
8647 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8648 Define only if needed.
7914961c 8649
b3967b18
PE
8650 * unexelf.c (unexec): Name an expression,
8651 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8652 Use a different way to cause a compilation error if anyone uses
8653 n rather than nn, a way that does not involve shadowing.
73366a00 8654 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8655
29a6015a
PE
8656 * deps.mk (unexalpha.o): Remove; unused.
8657
43cfc33e 8658 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8659 * unexec.h: New file.
ce701a33
PE
8660 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8661 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8662 Depend on unexec.h.
8663 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8664 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8665 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8666 Change as necessary to match prototype in unexec.h.
ce701a33 8667
01f44d5a
PE
8668 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8669 shadowing.
4f63c6bb 8670 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8671
a6670b0b
PE
8672 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8673 Rename locals to avoid shadowing.
8674
cef2010d 8675 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8676 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8677
d4d7173a
PE
8678 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8679
f08b802a
PE
8680 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8681 warning when compiling print.c.
8682
3ddb0639
PE
8683 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8684 instead of using an uninitialized var.
5ad03b97 8685 (font_sort_entities): Mark var as initialized.
3ddb0639 8686
170a2692
PE
8687 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8688
e663c700
PE
8689 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8690 pointers to constants.
89bc529a 8691 (font_parse_fcname): Remove unused vars.
7b81e2d0 8692 (font_delete_unmatched): Now static.
ea838e10 8693 (font_get_spec): Remove; unused.
13a547c6
PE
8694 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8695 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8696 Rename or move locals to avoid shadowing.
e663c700 8697
2a80c887 8698 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8699 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8700
1384fa33 8701 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8702 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8703
8b2c52e9
PE
8704 * alloc.c (mark_backtrace): Move decl from here ...
8705 * lisp.h: ... to here, so that it can be checked.
8706
475545b5 8707 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8708 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8709 (lisp_indirect_variable): Name an expression,
8710 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8711 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8712
b1349114 8713 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8714 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8715 Use const pointer when appropriate.
b1349114 8716
a2928364
PE
8717 * lisp.h (get_system_name, get_operating_system_release):
8718 Move decls here, to check interfaces.
8719 * process.c (get_operating_system_release): Move decl to lisp.h.
8720 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8721 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8722 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8723 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8724 (Fformat_time_string, Fencode_time, Finsert_char):
8725 (Ftranslate_region_internal, Fformat):
8726 Rename or remove local vars to avoid shadowing.
9710023e 8727 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8728
a415e694
PE
8729 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8730 avoid shadowing.
8731
8ef4622d
PE
8732 * lisp.h (eassert): Check that the argument compiles, even if
8733 ENABLE_CHECKING is not defined.
8734
946f9a5b
PE
8735 * data.c (Findirect_variable): Name an expression, to avoid
8736 gcc -Wbad-function-cast warning.
112396d6 8737 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8738 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8739 (Fmake_variable_buffer_local, Fmake_local_variable):
8740 Mark variables as initialized.
52746918 8741 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8742
e5aab7e7 8743 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8744 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8745 Rename locals to avoid shadowing.
dff45157
PE
8746 (mark_stack): Move local variables into the #ifdef region where
8747 they're used.
7bc26fdb
PE
8748 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8749 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8750 needed otherwise.
8751 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8752 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8753 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8754
e5aab7e7
PE
8755 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8756 avoids undefined behavior in theory.
8757
4da60324
PE
8758 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8759
88043301
PE
8760 Use functions, not macros, for up- and down-casing (Bug#8254).
8761 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8762 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8763 to use the following functions instead of these macros.
8764 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8765 EMACS_INT, since callers assume the returned value fits in int.
8766 (upcase1): Likewise, for UPCASE_TABLE.
8767 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8768 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8769 the race-condition problem in the old DOWNCASE.
88043301 8770
19ed5445
PE
8771 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8772 Rename locals to avoid shadowing.
8773 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8774 (regex_compile, re_search_2, re_match_2_internal):
8775 Remove unused local vars.
952db0d7
PE
8776 (FREE_VAR): Rewrite so as not to use empty "else",
8777 which gcc can warn about.
da053e48 8778 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8779 (RETALLOC_IF): Define only if needed.
8780 (WORDCHAR_P): Likewise. This one is never needed, but is used
8781 only in a comment talking about a compiler bug, so put inside
8782 the #if 0 of that comment.
8783 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8784 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8785 Remove; unused.
19ed5445 8786
1f3561e4 8787 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8788 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8789 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8790
ded6f8f7
PE
8791 * search.c (simple_search): Remove unused var.
8792
dbd37a95
PE
8793 * dired.c (compile_pattern): Move decl from here ...
8794 * lisp.h: ... to here, so that it can be checked.
8795 (struct re_registers): New forward decl.
8796
7e47afad
PE
8797 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8798
85f24f61
PE
8799 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8800 All uses changed.
8801 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8802 Rename locals to avoid shadowing.
5671df8f 8803 (Fvertical_motion): Mark locals as initialized.
85f24f61 8804
181aa2be 8805 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8806 (casify_region): Mark local as initialized.
181aa2be 8807
930d429c
PE
8808 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8809
7082eac6
PE
8810 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8811 New macros, so that the caller can use some names other than
8812 gcpro1, gcpro2, etc.
8813 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8814 of the new macros.
8815 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8816 argument, for consistency with GCPRO2_VAR, etc: it is now the
8817 prefix of the variable, not the variable itself. All uses
8818 changed.
38b2c076
PE
8819 * dired.c (directory_files_internal, file_name_completion):
8820 Rename locals to avoid shadowing.
8821
15206ed9
PE
8822 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8823 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8824 dired.c's scmp function, had undefined behavior.
8825 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8826 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8827 * buffer.h: ... to here, because these macros use current_buffer,
8828 and the new implementation with inline functions needs to have
8829 current_buffer in scope now, rather than later when the macros
8830 are used.
8831 (downcase, upcase1): New static inline functions.
8832 (DOWNCASE, UPCASE1): Reimplement using these functions.
8833 This avoids undefined behavior in expressions like
8834 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8835 from race conditions in accessing the global variables
8836 case_temp1 and case_temp2.
8837 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8838 * lisp.h (case_temp1, case_temp2): Remove their decls.
8839 * character.h (ASCII_CHAR_P): Move from here ...
8840 * lisp.h: ... to here, so that the inline functions mentioned
8841 above can use them.
8842
4a6bea26
PE
8843 * dired.c (directory_files_internal_unwind): Now static.
8844
f14b7e14
PE
8845 * fileio.c (file_name_as_directory, directory_file_name):
8846 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8847 Now static.
2893f146
PE
8848 (file_name_as_directory): Use const pointers when appropriate.
8849 (Fexpand_file_name): Likewise. In particular, newdir might
8850 point at constant storage, so make it a const pointer.
fd4ead52 8851 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8852 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8853 signedness issues.
f839df0c
PE
8854 (Fset_file_times, Finsert_file_contents, auto_save_error):
8855 Rename locals to avoid shadowing.
f14b7e14 8856
5716756e 8857 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8858 (Ftry_completion, Fall_completions): Rename or remove locals
8859 to avoid shadowing.
5716756e 8860
b4c3046a
PE
8861 * marker.c (bytepos_to_charpos): Remove; unused.
8862
b45db522
PE
8863 * lisp.h (verify_bytepos, count_markers): New decls,
8864 so that gcc does not warn that these functions aren't declared.
8865
85876d07
PE
8866 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8867 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8868 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8869 (copy_text): Remove unused local var.
85876d07 8870
03d78a21 8871 * filelock.c (within_one_second): Now static.
b3dd38ab 8872 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8873
5df8f01b
PE
8874 * buffer.c (fix_overlays_before): Mark locals as initialized.
8875 (fix_start_end_in_overlays): Likewise. This function should be
8876 simplified by using pointers-to-pointers, but that's a different
8877 matter.
b1d876f1 8878 (switch_to_buffer_1): Now static.
8f54f30a
PE
8879 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8880 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8881
a70072c9 8882 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8883 Fix pointer signedness issue.
edced198
PE
8884 (sys_subshell): Mark local as volatile if checking for lint,
8885 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8886 (MAXPATHLEN): Define only if needed.
a70072c9 8887
a0977c44
PE
8888 * process.c (serial_open, serial_configure): Move decls from here ...
8889 * systty.h: ... to here, so that they can be checked.
8890
a884fdcc
PE
8891 * fns.c (get_random, seed_random): Move extern decls from here ...
8892 * lisp.h: ... to here, so that they can be checked.
8893
604efe86 8894 * sysdep.c (reset_io): Now static.
b8950c94 8895 (wait_for_termination_signal): Remove; unused.
604efe86 8896
38fc62d9
PE
8897 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8898 (copy_keymap_item, append_key, push_text_char_description):
8899 Now static.
1004a21a 8900 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8901 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8902 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8903 (describe_map_tree):
8904 Rename locals to avoid shadowing.
38fc62d9 8905
2f2650da
PE
8906 * keyboard.c: Declare functions static if they are not used elsewhere.
8907 (echo_char, echo_dash, cmd_error, top_level_2):
8908 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8909 (read_char, kbd_buffer_get_event, make_lispy_position):
8910 (make_lispy_event, make_lispy_movement, apply_modifiers):
8911 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8912 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8913 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8914 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8915 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8916
a053e86c 8917 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8918 (mark_kboards): Move decl here ...
8919 * alloc.c (mark_kboards): ... from here.
a053e86c 8920
4752793e
PE
8921 * lisp.h (force_auto_save_soon): New decl.
8922
74f10ca7 8923 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8924 (DEFINE_DUMMY_FUNCTION): New macro.
8925 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8926 Use it.
c03cd23f
PE
8927 (main): Add casts to avoid warnings
8928 if GCC considers string literals to be constants.
74f10ca7 8929
022e70d4
PE
8930 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8931
59d6fe83
PE
8932 * dbusbind.c: Pointer signedness fixes.
8933 (xd_signature, xd_append_arg, xd_initialize):
8934 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8935 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8936 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8937 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8938
78320123
PE
8939 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8940 if GCC considers string literals to be constants.
49cebcca 8941 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8942
35ac2a97
SM
89432011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8944
fb103ca9
SM
8945 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8946 (print_preprocess, print_object): New macro to fix last change.
8947
35ac2a97
SM
8948 * print.c (print_preprocess): Don't forget font objects.
8949
62973b41
JB
89502011-03-16 Juanma Barranquero <lekktu@gmail.com>
8951
8952 * emacs.c (USAGE3): Doc fixes.
8953
0e48bb22
AS
89542011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8955
8956 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8957 structure.
8958
7684e57b
JB
89592011-03-14 Juanma Barranquero <lekktu@gmail.com>
8960
8961 * lisp.h (VWindow_system, Qfile_name_history):
8962 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8963 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8964 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8965
8966 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8967 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8968
8969 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8970 * w32console.c (detect_input_pending, read_input_pending)
8971 (encode_terminal_code):
8972 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8973 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8974 (w32_system_caret_y, Qfile_name_history):
8975 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8976 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8977 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8978 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8979 * w32proc.c (Qlocal, report_file_error):
8980 * w32term.c (Vwindow_system, updating_frame):
8981 * w32uniscribe.c (initialized, uniscribe_font_driver):
8982 Remove unneeded extern declarations.
8983
2aa46d6c
CY
89842011-03-14 Chong Yidong <cyd@stupidchicken.com>
8985
c96bbc66 8986 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8987
cffc6f3b
CY
89882011-03-13 Chong Yidong <cyd@stupidchicken.com>
8989
8990 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8991 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8992 These macros can no longer be used for assignment.
8993
44f230aa
SM
8994 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8995 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8996 (record_buffer_markers, fetch_buffer_markers): New functions for
8997 recording and fetching special buffer markers.
8998 (set_buffer_internal_1, set_buffer_temp): Use them.
8999
9000 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9001
9002 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9003
9004 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9005 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9006
9007 * xdisp.c (hscroll_window_tree):
9008 (reconsider_clip_changes): Use PT instead of BUF_PT.
9009
d251f04b
EZ
90102011-03-13 Eli Zaretskii <eliz@gnu.org>
9011
9012 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9013 $(EMACS_ROOT)/lib/intprops.h.
9014
f0c77cd1
PE
90152011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9016
3eca4629
PE
9017 Fix more problems found by GCC 4.5.2's static checks.
9018
7c86ee98
PE
9019 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9020 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9021 (xg_free_frame_widgets): Make it clear that a local variable is
9022 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9023 (gdk_window_get_screen): Make it clear that this macro is needed
9024 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9025 (int_gtk_range_get_value): New function, which avoids a diagnostic
9026 from gcc -Wbad-function-cast.
9027 (xg_set_toolkit_scroll_bar_thumb): Use it.
9028 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9029 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9030 (get_utf8_string, xg_get_file_with_chooser):
9031 Rename locals to avoid shadowing.
9032 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9033
41729b81
PE
9034 * xgselect.c (xg_select): Remove unused var.
9035
f0c77cd1
PE
9036 * image.c (four_corners_best): Mark locals as initialized.
9037 (gif_load): Initialize transparent_p to zero (Bug#8238).
9038 Mark another local as initialized.
ec6cf4c6 9039 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9040
ce0ad53d 9041 * image.c (clear_image_cache): Now static.
d5d5a617 9042 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9043 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9044 (x_edge_detection): Remove unnecessary cast that
9045 gcc -Wbad-function-cast diagnoses.
2037898d 9046 (gif_load): Fix pointer signedness.
6ae141d6
PE
9047 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9048 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9049
33383987 90502011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9051
d32df629
PE
9052 Improve quality of tests for time stamp overflow.
9053 For example, without this patch (encode-time 0 0 0 1 1
9054 1152921504606846976) returns the obviously-bogus value (-948597
9055 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9056 reports time overflow. See
9057 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9058 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9059 * editfns.c: Include limits.h and intprops.h.
9060 (TIME_T_MIN, TIME_T_MAX): New macros.
9061 (time_overflow): Move earlier, to before first use.
9062 (hi_time, lo_time): New functions, for an accurate test for
9063 out-of-range times.
9064 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9065 (Fget_internal_run_time): Don't assume time_t fits in int.
9066 (make_time): Use list2 instead of Fcons twice.
9067 (Fdecode_time): More accurate test for out-of-range times.
9068 (check_tm_member): New function.
9069 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9070 (lisp_time_argument): Don't rely on undefined left-shift and
9071 right-shift behavior when checking for time stamp overflow.
8be6f318 9072
fe31d94c
PE
9073 * editfns.c (time_overflow): New function, refactoring common code.
9074 (Fformat_time_string, Fdecode_time, Fencode_time):
9075 (Fcurrent_time_string): Use it.
9076
8be6f318
PE
9077 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9078 * dired.c (make_time): Move to ...
9079 * editfns.c (make_time): ... here.
9080 * systime.h: Note the move.
9081
09d9db2c 90822011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9083
126bc0dc
YM
9084 * fringe.c (update_window_fringes): Remove unused variables.
9085
c47cbdfd
YM
9086 * unexmacosx.c (copy_data_segment): Also copy __got section.
9087 (Bug#8223)
9088
7ac80be9
EZ
90892011-03-12 Eli Zaretskii <eliz@gnu.org>
9090
c96bbc66 9091 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9092 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9093 Constify `char *' arguments and their references according to
9094 prototypes in tparam.h.
9095
ecb0f94d 9096 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9097
7ac80be9
EZ
9098 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9099 Adapt all references accordingly.
9100
9101 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9102
ef1fd07e
TT
91032011-03-11 Tom Tromey <tromey@redhat.com>
9104
9105 * buffer.c (syms_of_buffer): Remove obsolete comment.
9106
7ef4b50c
EZ
91072011-03-11 Eli Zaretskii <eliz@gnu.org>
9108
9109 * termhooks.h (encode_terminal_code): Declare prototype.
9110
9111 * msdos.c (encode_terminal_code): Don't declare prototype.
9112
9113 * term.c (encode_terminal_code): Now external again, used by
9114 w32console.c and msdos.c.
9115
44f230aa
SM
9116 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9117 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9118
4b1ec863 91192011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9120
1714f52b 9121 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9122
4b1ec863
PE
9123 * fringe.c (update_window_fringes): Mark locals as initialized
9124 (Bug#8227).
9125 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9126
524c7aa6
PE
9127 * alloc.c (mark_fringe_data): Move decl from here ...
9128 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9129 to check its interface.
9130 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9131
a5c0af81 9132 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9133 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9134 (fontset_font): Mark local as initialized.
a9a06e0b 9135 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9136
b4716021
PE
9137 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9138
811e9bac 9139 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9140 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9141 (x_own_selection, Fx_disown_selection_internal): Rename locals
9142 to avoid shadowing.
9143 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9144
7e3ab302
PE
9145 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9146 so that the caller can use some name other than gcpro1.
9147 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9148 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9149 (Fx_backspace_delete_keys_p):
9150 Use them to avoid shadowing, and rename vars to avoid shadowing.
9151 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9152 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9153 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9154 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9155 Remove unused locals.
7e3ab302
PE
9156 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9157 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9158 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9159 macros.
f78faa98 9160
e2b13473
PE
9161 * xterm.h (x_mouse_leave): New decl.
9162
77f23912
PE
9163 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9164 Remove unused functions.
cdf4ba58
PE
9165 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9166 (x_calc_absolute_position): Now static.
7411c686 9167 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9168 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9169 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9170 unless they are used.
38d0b34a
PE
9171 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9172 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9173 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9174 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9175 (x_error_catcher, x_connection_closed, x_error_handler):
9176 (x_error_quitter, xembed_send_message, x_iconify_frame):
9177 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9178 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9179 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9180
44f230aa
SM
9181 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9182 Rename or move locals to avoid shadowing.
6b463e58 9183 (tty_defined_color, merge_face_heights): Now static.
5967d051 9184 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9185 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9186 does not deduce is never used uninitialized.
73719eba
PE
9187 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9188 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9189
426994c3 9190 * terminal.c (store_terminal_param): Now static.
5489860b 9191
032f1620 9192 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9193 (set_frame_menubar): Remove unused local.
d4323972 9194 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9195 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9196 since they might point to immutable storage.
281585b0
PE
9197 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9198 since it's unused otherwise.
032f1620 9199
367c19e5 9200 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9201 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9202 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9203 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9204 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9205 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9206 does not deduce are never used uninitialized.
70739cbe 9207
07b48fa9
PE
9208 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9209
8868a238 9210 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9211 * window.c (window_loop, size_window):
9212 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9213
7e5cf297 9214 * window.c (display_buffer): Now static.
d6550a9f
PE
9215 (size_window): Mark variables that gcc -Wuninitialized
9216 does not deduce are never used uninitialized.
a586633d
PE
9217 * window.h (check_all_windows): New decl, to forestall
9218 gcc -Wmissing-prototypes diagnostic.
5b555da1 9219 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9220
f6095868
PE
9221 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9222 shadowing.
9223 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9224 Include <limits.h>.
9225 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9226 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9227 (load_charset_map): Mark variables that gcc -Wuninitialized
9228 does not deduce are never used uninitialized.
53df7c11 9229 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9230
f38b440c
PE
9231 * coding.c (coding_set_source, coding_set_destination):
9232 Use "else { /* comment */ }" rather than "else /* comment */;"
9233 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9234 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9235 a block, when the outer 'i' will do.
9236 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9237 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9238 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9239 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9240 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9241 Rename locals to avoid shadowing.
9242 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9243 * coding.c (emacs_mule_char, encode_invocation_designation):
9244 Now static, since they're not used elsewhere.
413bb2db 9245 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9246 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9247 (decode_coding_emacs_mule): Mark variables that gcc
9248 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9249 (detect_coding_iso_2022): Initialize a local variable that might
9250 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9251 this initialization is needed. (Bug#8211)
5f58e762
PE
9252 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9253 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9254 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9255 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9256 Remove unused macros.
f38b440c 9257
232b38b9 9258 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9259 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9260 * character.c (string_count_byte8): Likewise.
232b38b9 9261
fb90da1b
PE
9262 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9263 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9264
fb93dbc2
PE
9265 * chartab.c (copy_sub_char_table): Now static, since it's not used
9266 elsewhere.
5c156ace
PE
9267 (sub_char_table_ref_and_range, char_table_ref_and_range):
9268 Rename locals to avoid shadowing.
bbcd0949 9269 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9270
7d3b3862 9271 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9272 (BIDI_BOB): Remove unused macro.
7d3b3862 9273
6be7d3da
PE
9274 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9275 deduce are never used uninitialized.
c2ed9c8b 9276 * term.c (encode_terminal_code): Likewise.
6be7d3da 9277
75f8807f 9278 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9279
50938595
PE
9280 * tparam.h: New file.
9281 * term.c, tparam.h: Include it.
9282 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9283 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9284 Move these decls to tparam.h, and make them agree with what
9285 is actually in tparam.c. The previous trick of using incompatible
9286 decls in different modules does not conform to the C standard.
9287 All callers of tparam changed to use tparam's actual API.
9288 * tparam.c (tparam1, tparam, tgoto):
9289 Use const pointers where appropriate.
9290
fbceeba2
PE
9291 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9292 * cm.h (struct cm): Likewise.
9293 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9294 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9295 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9296 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9297 (turn_on_face, init_tty): Likewise.
9298 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9299
7f3f1250
PE
9300 * term.c (term_mouse_position): Rename local to avoid shadowing.
9301
e6ca6543
PE
9302 * alloc.c (mark_ttys): Move decl from here ...
9303 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9304
c40f8d15
AS
93052011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9306
9307 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9308
cfe0661d
JB
93092011-03-09 Juanma Barranquero <lekktu@gmail.com>
9310
9311 * search.c (compile_pattern_1): Remove argument regp, unused since
9312 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9313 (compile_pattern): Don't pass it.
9314
0afb4571
J
93152011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9316
9317 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9318 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9319 for ! HAVE_GTK3.
9320 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9321
9322 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9323
9324 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9325 gdk_window_get_screen, gdk_window_get_geometry,
9326 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9327 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9328 (xg_get_pixbuf_from_pixmap): New function.
9329 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9330 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9331 Call xg_get_pixbuf_from_pixmap instead of
9332 gdk_pixbuf_get_from_drawable.
9333 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9334 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9335 (xg_check_special_colors): Use GtkStyleContext and its functions
9336 for HAVE_GTK3.
9337 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9338 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9339 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9340 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9341 Call gtk_widget_get_preferred_size.
0afb4571
J
9342 (xg_frame_resized): gdk_window_get_geometry only takes 5
9343 parameters.
44f230aa
SM
9344 (xg_win_to_widget, xg_event_is_for_menubar):
9345 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9346 (xg_set_widget_bg): New function.
9347 (delete_cb): New function.
895009e1 9348 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9349 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9350 (xg_set_background_color): Call xg_set_widget_bg.
9351 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9352 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9353 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9354 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9355 if ! HAVE_GTK3.
9356 (update_frame_tool_bar): Call gtk_widget_hide.
9357 (xg_initialize): Use GDK_KEY_g.
9358
9359 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9360 if ! HAVE_GTK3
9361 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9362
9363 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9364 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9365 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9366
1c2cc4ef
JB
93672011-03-08 Juanma Barranquero <lekktu@gmail.com>
9368
9369 * w32xfns.c (select_palette): Check success of RealizePalette against
9370 GDI_ERROR, not zero.
9371
33383987 9372See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9373
9374;; Local Variables:
9375;; coding: utf-8
aac0c6e3
MR
9376;; End:
9377
acaf905b 9378 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9379
9380 This file is part of GNU Emacs.
9381
9382 GNU Emacs is free software: you can redistribute it and/or modify
9383 it under the terms of the GNU General Public License as published by
9384 the Free Software Foundation, either version 3 of the License, or
9385 (at your option) any later version.
9386
9387 GNU Emacs is distributed in the hope that it will be useful,
9388 but WITHOUT ANY WARRANTY; without even the implied warranty of
9389 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9390 GNU General Public License for more details.
9391
9392 You should have received a copy of the GNU General Public License
9393 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.