Clean up syntax-table usage in xml.el
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3884d954
DA
12012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * buffer.c (init_buffer_once): Fix initialization of
4 headers for buffer_defaults and buffer_local_symbols.
5 Reported by Juanma Barranquero <lekktu@gmail.com>.
6
ee28be33
SM
72012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8
9 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
10 * lisp.h (enum pvec_type): Use fewer bits.
11 (PSEUDOVECTOR_SIZE_BITS): New constant.
12 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
13 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
14 change in pvec_type.
15 (PSEUDOVECTOR_TYPEP): New macro.
16 (TYPED_PSEUDOVECTORP): Use it.
17 * fns.c (internal_equal): Adapt code to extract pvectype.
18 * emacs.c (gdb_pvec_type): Update type.
19 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
20 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
21 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
22 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
23 (sweep_vectors): Use it. Use local var `total_bytes' instead of
24 abusing vector->header.next.nbytes.
25 (live_vector_p): Use PVEC_TYPE.
26 (mark_object): Adapt code to extract pvectype. Use switch.
27
c7f2cd7f
PE
282012-07-04 Paul Eggert <eggert@cs.ucla.edu>
29
30 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
31 Tighten new eassert a bit.
32
8ce70ed2
DA
332012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
34
35 Fix compilation with --enable-gcc-warnings and -O1
36 optimization level.
37 * doprnt.c (doprnt): Change type of tem to int, initialize
38 to avoid compiler warning. Add eassert.
39 * search.c (simple_search): Initialize match_byte to avoid
40 compiler warning. Add eassert.
41
dea7f1e5
PE
422012-07-04 Paul Eggert <eggert@cs.ucla.edu>
43
24a212eb
PE
44 Avoid weird behavior with large horizontal scrolls.
45 Without this change, for example, large hscroll values would
46 mess up Emacs's display on Fedora 15 x86, presumably due to
47 overflows in int calculations in the display code.
48 Also, if buffers had long lines, Emacs would freeze.
49 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
50 (set_window_hscroll): New function, containing the old guts of
51 Fset_window_hscroll. Return the clipped value.
52 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
53 This avoids the need to check against PTRDIFF_MAX.
54
dea7f1e5
PE
55 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
56
76046526
DA
572012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
58
59 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
60
39adff0d
PE
612012-07-04 Paul Eggert <eggert@cs.ucla.edu>
62
63807d47
PE
63 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
64 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
65 since GCC 4.4.6 issues a bogus warning for them.
66
39adff0d
PE
67 Fix bugs in file timestamp newness comparisons.
68 * fileio.c (Ffile_newer_than_file_p):
69 * lread.c (Fload): Use full timestamp resolution of files,
70 not just the 1-second resolution, so that files that are only
71 slightly newer still count as newer.
72 * fileio.c (Ffile_newer_than_file_p): Don't assume file
73 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
74
dbeed9a6
PE
752012-07-03 Paul Eggert <eggert@cs.ucla.edu>
76
77 * fileio.c: Improve handling of file time marker. (Bug#11852)
78 (special_mtime): New function.
79 (Finsert_file_contents, Fverify_visited_file_modtime):
80 Use it to set special mtime values consistently.
81
636334d6
AS
822012-07-03 Andreas Schwab <schwab@linux-m68k.org>
83
84 * fileio.c (Finsert_file_contents): Properly handle st_mtime
85 marker for non-existing file. (Bug#11852)
86
e2017fe2
GM
872012-07-03 Glenn Morris <rgm@gnu.org>
88
89 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
90 and did not make it into globals.h).
91
404dbd37
TT
922012-07-03 Tom Tromey <tromey@redhat.com>
93
94 * window.c (Fset_window_margins, Fset_window_fringes)
95 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
96 * textprop.c (Fprevious_property_change): No longer static.
97 * syntax.c (Fsyntax_table_p): No longer static.
98 * process.c (Fget_process, Fprocess_datagram_address): No longer
99 static.
100 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
101 * keyboard.c (Fcommand_execute): No longer static.
102 Remove EXFUN.
103 * insdel.c (Fcombine_after_change_execute): No longer static.
104 * image.c (Finit_image_library): No longer static.
105 * fileio.c (Fmake_symbolic_link): No longer static.
106 * eval.c (Ffetch_bytecode): No longer static.
107 * editfns.c (Fuser_full_name): No longer static.
108 * doc.c: (Fdocumentation_property, Fsnarf_documentation): No
109 longer static.
110 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
111 static.
112 * dired.c (Ffile_attributes): No longer static.
113 * composite.c (Fcomposition_get_gstring): No longer static.
114 * callproc.c (Fgetenv_internal): No longer static.
115
116 * ccl.h: Remove EXFUNs.
117 * buffer.h: Remove EXFUNs.
118 * dispextern.h: Remove EXFUNs.
119 * intervals.h: Remove EXFUNs.
120 * fontset.h: Remove EXFUN.
121 * font.h: Remove EXFUNs.
122 * dosfns.c (system_process_attributes): Remove EXFUN.
123 * keymap.h: Remove EXFUNs.
124 * lisp.h: Remove EXFUNs.
125 * w32term.h: Remove EXFUNs.
126 * window.h: Remove EXFUNs.
127 * xsettings.h: Remove EXFUN.
128 * xterm.h: Remove EXFUN.
129
8e4fd1e1
GM
1302012-07-03 Glenn Morris <rgm@gnu.org>
131
132 * lisp.h (Frandom): Make it visible to C.
133 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
134 buffer for invisible buffers. (Bug#1229)
135
ca95b3eb
DA
1362012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
137
138 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
139 values which aren't power of 2.
140 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
141 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
142 accordingly.
143
7555c33f
SM
1442012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
145
146 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
147
148 * alloc.c (mark_object): Revert part of last patch to use `switch'.
149
d12e8f5a
DA
1502012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
151
152 * alloc.c (allocate_vector_block): Remove redundant
153 calls to mallopt if DOUG_LEA_MALLOC is defined.
154 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
155 avoid calls to mallopt if zero_vector is returned.
156
296094c3
DA
1572012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
158
159 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
160 is enabled, avoid dereferencing NULL current_sblock if
161 running undumped.
162
36429c89
DA
1632012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
164
165 Cleanup basic buffer management.
166 * buffer.h (struct buffer): Change layout to use generic vector
167 marking code. Fix some comments. Change type of 'clip_changed'
168 to bitfield. Remove unused #ifndef old.
169 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
170 (GET_OVERLAYS_AT): Fix indentation.
171 (for_each_per_buffer_object_at): New macro.
172 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
173 (Fbuffer_local_variables): Use it.
174 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
175 * alloc.c (allocate_buffer): Adjust to match new layout of
176 struct buffer. Fix comment.
177 (mark_overlay): New function.
178 (mark_buffer): Use it. Use mark_vectorlike to mark normal
179 Lisp area of struct buffer.
180 (mark_object): Use it. Adjust marking of misc objects
181 and related comments.
182
3b3e4cac
PE
1832012-07-02 Paul Eggert <eggert@cs.ucla.edu>
184
185 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
186 wrapper that is not needed because the wrapped code is a no-op (zero
187 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
188 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
189
cf5c0175
DA
1902012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
191
192 * alloc.c (mark_buffer): Simplify. Remove prototype.
193 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 194 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
195 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
196 redundant calls to mark_vectorlike for bool vectors.
197
ca26824c
GM
1982012-06-30 Glenn Morris <rgm@gnu.org>
199
2e4c5312
GM
200 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
201
ca26824c
GM
202 * epaths.in (PATH_SITELOADSEARCH): New.
203 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
204 This is rather than relying on --enable-locallisppath elements
205 having "site-lisp" in their names. (Bug#10208#25, 11658)
206
0d23c240
EZ
2072012-06-30 Eli Zaretskii <eliz@gnu.org>
208
c9240d7a
EZ
209 * w32proc.c (sys_select): Accept and ignore one more argument.
210
211 * w32.c (emacs_gnutls_pull): Call select with one more argument.
212
0d23c240 213 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 214 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
215
216 * sysdep.c: Don't include dos.h and dosfns.h.
217
218 * process.c (sys_select):
219 * msdos.c (sys_select): Accept one more argument and ignore it.
220
221 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
222 adapt data types and code to that.
223
224 * dosfns.c:
225 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
226 which clashes with the gnulib function of the same name.
227
af5a5a98
AS
2282012-06-30 Andreas Schwab <schwab@linux-m68k.org>
229
c5e4379c
AS
230 * font.c (font_style_to_value, font_style_symbolic)
231 (font_prop_validate_style): Add type checks for values in
232 font_style_table.
233
af5a5a98
AS
234 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
235 argument.
236 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
237 uses.
238
8d38f461
EZ
2392012-06-29 Eli Zaretskii <eliz@gnu.org>
240
2e5a6631
EZ
241 * xdisp.c (try_window_id): Undo last change.
242
8d38f461
EZ
243 * w32.c (getwd): Adjust commentary about startup_dir.
244 (init_environment): Always call sys_access, even in non-MSVC
245 builds. Don't chdir to the directory of the Emacs executable.
246 This undoes code from 1997 which was justified by the need to
247 "avoid conflicts when removing and renaming directories". But its
248 downside was that every relative file name was being interpreted
249 relative to the directory of the Emacs executable, which can never
250 be TRT. In particular, it broke sys_access when called with
251 relative file names.
252 (sys_access): Map GetLastError to errno.
253
2af3565e
DA
2542012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
255
256 * window.h (struct window): Change type of 'fringes_outside_margins'
257 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 258 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
259 Adjust comment.
260 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
261 to ptrdiff_t.
262
c8d3a25c 2632012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 264
c8d3a25c
GM
265 * gnutls.c (emacs_gnutls_handshake):
266 Add QUIT to make the loop interruptible.
57570cd3 267
c8d3a25c 2682012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 269
c8d3a25c
GM
270 * charset.c (init_charset): Make lack of etc/charsets fatal.
271
3e984ee8
DA
2722012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
273
274 * editfns.c (region_limit): Fix type mismatch.
275
ef884f23
DA
2762012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
277
278 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
279 undefined. Convert from xassert to eassert.
280 * nsmenu.m: Convert from xassert to eassert.
281 * nsterm.m: Likewise.
282
7d7e0027
SM
2832012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
284
285 * editfns.c (region_limit): Clip to narrowing (bug#11770).
286
aa754e6a
PE
2872012-06-28 Paul Eggert <eggert@cs.ucla.edu>
288
289 Avoid integer overflow on scroll-left and scroll-right.
290 * window.c (HSCROLL_MAX): New macro.
291 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
292 overflow when requested scroll falls outside ptrdiff_t range.
293
80b00b08
DA
2942012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
295
296 * window.h (struct window): Change type of 'hscroll',
297 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
298 'last_modified' and 'last_overlay_modified' to EMACS_INT.
299 Adjust users accordingly.
300 * xdisp.c (try_cursor_movement): Replace type check with eassert.
301 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
302 from EMACS_INT to ptrdiff_t.
303 (make_window): Omit redundant initialization.
304
62b2bcf6
JB
3052012-06-28 Juanma Barranquero <lekktu@gmail.com>
306
307 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
308
45942c7d
DA
3092012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
310
311 * window.h (struct window): Change type of 'use_time' and
312 'sequence_number' from Lisp_Object to int.
313 * frame.c (make_frame): Adjust users accordingly.
314 * print.c (print_object): Likewise.
315 * window.c (select_window, Fwindow_use_time, make_parent_window)
316 (make_window): Likewise.
317
e509cfa6
DA
3182012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
319
320 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
321 enabled with --enable-checking=[all,glyphs] configure option.
322 Fix GLYPH_DEBUG usage assuming that it may be undefined,
323 adjust comments accordingly.
324 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
325 undefined, adjust comments accordingly.
326 * image.c: Likewise.
327 * scroll.c: Likewise.
328 * w32fns.c: Likewise.
329 * w32term.c: Likewise.
330 * xdisp.c: Likewise.
331 * xfaces.c: Likewise.
332 * xfns.c: Likewise.
333 * xterm.c: Likewise.
334
a54e2c05
DA
3352012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
336
337 Generalize run-time debugging checks.
338 * dispextern.h (XASSERTS): Remove.
339 * fontset.c (xassert): Remove.
340 Convert from xassert to eassert.
341 * alloc.c: Convert from xassert to eassert.
342 * bidi.c: Likewise.
343 * dispnew.c: Likewise.
344 * fns.c: Likewise.
345 * fringe.c: Likewise.
346 * ftfont.c: Likewise.
347 * gtkutil.c: Likewise.
348 * image.c: Likewise.
349 * keyboard.c: Likewise.
350 * menu.c: Likewise.
351 * process.c: Likewise.
352 * scroll.c: Likewise.
353 * sound.c: Likewise.
354 * term.c: Likewise.
355 * w32console.c: Likewise.
356 * w32fns.c: Likewise.
357 * w32term.c: Likewise.
358 * window.c: Likewise.
359 * xdisp.c: Likewise.
360 * xfaces.c: Likewise.
361 * xfns.c: Likewise.
362 * xselect.c: Likewise.
363 * xterm.c: Likewise.
364
1ec4b7b2
SM
3652012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
366
367 * fns.c (maybe_resize_hash_table): Output message when growing the
368 purify-hashtable.
369
2014308a
DA
3702012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
371
372 * alloc.c (allocate_string_data): Remove dead code.
373 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
374 avoid GCC warning about unused macro.
375
246155eb
DA
3762012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
377
378 * alloc.c (allocate_string): Omit intervals initialization.
379 * alloc.c (make_uninit_multibyte_string): Initialize intervals
380 as in make_pure_string and make_pure_c_string.
381
43184b7b
DA
3822012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
383
384 * alloc.c (allocate_string): Fix last change.
385
3fe6dd74
DA
3862012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
387
388 * alloc.c (allocate_string): Remove two redundant calls
389 to memset, add explicit initialization where appropriate.
390
1ba6038a
GM
3912012-06-27 Glenn Morris <rgm@gnu.org>
392
393 * lisp.mk (lisp): Remove paths.elc.
394
c89926a5
CY
3952012-06-27 Chong Yidong <cyd@gnu.org>
396
397 * doc.c (Fsubstitute_command_keys): Fix punctuation.
398
ed6b3510
JW
3992012-06-26 John Wiegley <johnw@newartisans.com>
400
1ec4b7b2 401 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
402 on Mac OS X Lion: __mod_init_func and __mod_term_func.
403
ed6b3510
JW
404 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
405 when building with Clang.
406
8edd4a2b
SM
4072012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
408
409 * eval.c (Fapply): Allow calling it with a single argument.
410
f6f62d1b
EZ
4112012-06-26 Eli Zaretskii <eliz@gnu.org>
412
413 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
414 _stricmp and _strnicmp.
415 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
416
62efea5e
DA
4172012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
418
419 * alloc.c (allocate_window): Zero out non-Lisp part of newly
420 allocated window.
421 (allocate_process): Likewise for new process.
8edd4a2b 422 (allocate_terminal): Change to use offsetof.
62efea5e
DA
423 (allocate_frame): Likewise.
424 * frame.c (make_frame): Omit redundant initialization.
425 * window.c (make_parent_window): Use memset.
426 (make_window): Omit redundant initialization.
427 * process.c (make_process): Omit redundant initialization.
428 * terminal.c (create_terminal): Likewise.
429
42997f4d
DA
4302012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
431
432 * term.c (delete_tty): Remove redundant call to memset.
433
1130ecfc
DA
4342012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
435
436 * alloc.c: Remove build_string.
437 * lisp.h: Define build_string as static inline. This provides
438 a better opportunity to optimize away calls to strlen when the
439 function is called with compile-time constant argument.
440 * image.c (imagemagick_error): Convert to build_string.
441 * w32proc.c (sys_spawnve): Likewise.
442 * xterm.c (x_term_init): Likewise.
443
cf38a720
PE
4442012-06-26 Paul Eggert <eggert@cs.ucla.edu>
445
99027bdd
PE
446 Use sprintf return value instead of invoking strlen on result.
447 In the old days this wasn't portable, since some sprintf
448 implementations returned char *. But they died out years ago and
449 Emacs already assumes sprintf returns int.
450 Similarly for float_to_string.
451 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
452 * ccl.c (ccl_driver):
453 * character.c (string_escape_byte8):
454 * data.c (Fnumber_to_string):
455 * doprnt.c (doprnt):
456 * print.c (print_object):
457 * xdisp.c (message_dolog):
458 * xfns.c (syms_of_xfns):
459 Use sprintf or float_to_string result to avoid need to call strlen.
460 * data.c (Fnumber_to_string):
461 Use make_unibyte_string, since the string must be ASCII.
462 * lisp.h, print.c (float_to_string): Now returns int length.
463 * term.c (produce_glyphless_glyph):
464 Use sprintf result rather than recomputing it.
465
cf38a720
PE
466 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
467 * Makefile.in (ALL_CFLAGS):
468 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
469 * gmalloc.c, regex.c: Include <config.h> unconditionally.
470
3511c784
DA
4712012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
472
0a08eb21 473 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
474 strcasecmp if available.
475 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
476
fb7da12e
AS
4772012-06-25 Andreas Schwab <schwab@linux-m68k.org>
478
479 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
480 Avoid comma operator.
481 * menu.c (push_submenu_start, push_submenu_end)
482 (push_left_right_boundary, push_menu_pane): Likewise.
483 * msdos.c (dos_rawgetc): Likewise.
484
afa2ffd8
DA
4852012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
486
487 * xfns.c (xic_create_fontsetname): Remove redundant calls
488 to memset.
489
b3b4476b
PE
4902012-06-25 Paul Eggert <eggert@cs.ucla.edu>
491
4495ff38
PE
492 * gtkutil.c (get_utf8_string): Remove redundant assignment.
493 sprintf already null-terminates its output.
494
b3b4476b
PE
495 * xfns.c (x_window): Remove redundant cast.
496
b00876c9
DA
4972012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
498
499 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
500 `const char *' to `char *' to avoid compiler warning.
501
d188e26b
PE
5022012-06-24 Paul Eggert <eggert@cs.ucla.edu>
503
885d1d74
PE
504 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
505 instead of truncating it to 63 (admittedly a generous limit).
506
d188e26b
PE
507 * process.c: Fix spelling and caps in comments.
508
e2f560b1
DN
5092012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
510
e86db54b 511 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
512 * sysdep.c (setpgrp): Remove definition, not used in this file.
513
7583a3a1
JB
5142012-06-24 Juanma Barranquero <lekktu@gmail.com>
515
516 * makefile.w32-in: Update dependencies.
517
696056c2
EZ
5182012-06-24 Eli Zaretskii <eliz@gnu.org>
519
520 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
521 (SYSTIME_H): Add nt/inc/sys/time.h.
522
523 * systime.h [WINDOWSNT]: Include sys/time.h.
524
525 * s/ms-w32.h (struct timespec): Definition moved from
526 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
527
845ca893
PE
5282012-06-24 Paul Eggert <eggert@cs.ucla.edu>
529
530 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
531 * buffer.h (buffer_slot_type_mismatch):
532 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
533 * eval.c (unwind_to_catch):
534 * image.c (my_png_error, my_error_exit):
535 * keyboard.c (quit_throw_to_read_char, user_error)
536 (Fexit_recursive_edit, Fabort_recursive_edit):
537 * lisp.h (die, args_out_of_range, args_out_of_range_3)
538 (wrong_type_argument, buffer_overflow, __executable_start)
539 (memory_full, buffer_memory_full, string_overflow, Fthrow)
540 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
541 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
542 (fatal):
543 (child_setup) [!DOS_NT]:
544 * lread.c (end_of_file_error, invalid_syntax):
545 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
546 * puresize.h (pure_write_error):
547 * search.c (matcher_overflow):
548 * sound.c (sound_perror, alsa_sound_perror):
549 * sysdep.c, syssignal.h (croak):
550 * term.c (maybe_fatal, vfatal):
551 * textprop.c (text_read_only):
552 * undo.c (user_error):
553 * unexmacosx.c (unexec_error):
554 * xterm.c (x_ins_del_lines, x_delete_glyphs):
555 Use _Noreturn rather than NO_RETURN.
556 No need for separate decl merely because of _Noreturn.
557 * sound.c (sound_warning, parse_sound):
558 Remove unnecessary forward decls.
559
f1dd8073
PE
5602012-06-24 Paul Eggert <eggert@cs.ucla.edu>
561
562 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
563 * lisp.h (WAIT_READING_MAX): New macro.
564 * dispnew.c (Fsleep_for, sit_for):
565 * keyboard.c (kbd_buffer_get_event):
566 * process.c (Faccept_process_output):
567 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
568 This improves on the previous patch, which introduced a bug
569 when time_t is unsigned and as wide as intmax_t.
570 See <http://bugs.gnu.org/9000#51>.
571
b82c1755
EZ
5722012-06-23 Eli Zaretskii <eliz@gnu.org>
573
574 * dispnew.c (sit_for, Fsleep_for):
575 * keyboard.c (kbd_buffer_get_event):
576 * process.c (Faccept_process_output): Avoid compiler warnings when
577 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
578
ca300656
JB
5792012-06-23 Juanma Barranquero <lekktu@gmail.com>
580
049ec95b
JB
581 * makefile.w32-in: Update dependencies.
582
ca300656
JB
583 * w32.c (ltime): Add return type and declare static.
584 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
585
db7b8d06
PE
5862012-06-23 Paul Eggert <eggert@cs.ucla.edu>
587
588 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
589 Privately reported by Herbert J. Skuhra.
590 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
591 All uses changed.
592 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
593 not make_lisp_timeval, when the argument is of type EMACS_TIME.
594
0bd8297f
EZ
5952012-06-23 Eli Zaretskii <eliz@gnu.org>
596
96512555
EZ
597 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
598 last argument of make_unibyte_string.
599
0bd8297f
EZ
600 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
601 language ID in the event parameters.
602
603 * w32term.c (w32_read_socket): Put the new keyboard codepage into
604 event.code, not the obscure "character set ID".
605
63def6b6
CY
6062012-06-23 Chong Yidong <cyd@gnu.org>
607
608 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
609
e8a02204
EZ
6102012-06-23 Eli Zaretskii <eliz@gnu.org>
611
388cdec0
EZ
612 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
613 * w32.c (fdutimens): New function.
614
615 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
616
617 * s/ms-w32.h (pselect): Redirect to sys_select.
618
619 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
620
e8a02204
EZ
621 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
622 in the logic of incrementing and decrementing the value of
623 use_relocatable_buffers.
624
d054f3fb
PE
6252012-06-23 Paul Eggert <eggert@cs.ucla.edu>
626
627 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
628 Privately reported by Herbert J. Skuhra.
629 [__FreeBSD__]: Remove "*/" typo after "#include".
630 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
631 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
632 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
633 Don't assume EMACS_TIME and struct timeval are the same type.
634
d35af63c
PE
6352012-06-22 Paul Eggert <eggert@cs.ucla.edu>
636
637 Support higher-resolution time stamps (Bug#9000).
638 The time stamps are only nanosecond-resolution at the C level,
639 since that's the best that any real-world system supports now.
640 But they are picosecond-resolution at the Lisp level, as that's
641 easy, and leaves room for future OS improvements.
642
643 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
644 (LIBES): Use it.
645
646 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
647 Don't get current time unless it's needed.
648
649 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
650 now provides it if it's absent.
651 (start_atimer): Port to higher-res time stamps.
652 Check for time stamp overflow. Don't get current time more
653 often than is needed.
654
655 * buffer.h (struct buffer): Buffer modtime now has high resolution.
656 Include systime.h, not time.h.
657 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
658
659 * dired.c: Include stat-time.h.
660 (Ffile-attributes): File times now have higher resolution.
661
662 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
663 (struct image): Timestamp now has higher resolution.
664
665 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
666 has at least microseconds now. All uses removed.
667 (update_frame, update_single_window, update_window, update_frame_1)
668 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
669
670 * editfns.c (time_overflow): Now extern.
671 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
672 (float-time, Fformat_time_string, Fcurrent_time_string)
673 (Fcurrent_time_zone): Accept and generate higher-resolution
674 time stamps.
675 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
676 (decode_time_components, lisp_seconds_argument): New functions.
677 (make_time): Now static.
678 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
679 Report an error if the time is invalid, rather than having the caller
680 do that.
681
682 * fileio.c: Include <stat-time.h>
683 (Fcopy_file): Copy higher-resolution time stamps.
684 Prefer to set the time stamp via a file descriptor if that works.
685 (Fset_file_times, Finsert_file_contents, Fwrite_region)
686 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
687 (Fvisited_file_modtime, Fset_visited_file_modtime):
688 Support higher-resolution time stamps.
689
690 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
691
692 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
693
694 * image.c (prepare_image_for_display, clear_image_cache)
695 (lookup_image): Port to higer-resolution time stamps.
696
697 * keyboard.c (start_polling, bind_polling_period):
698 Check for time stamp overflow.
699 (read_char, kbd_buffer_get_event, timer_start_idle)
700 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
701 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
702 Port to higher-resolution time stamps. Do not assume time_t is signed.
703 (decode_timer): New function. Timers are now vectors of length 9,
704 not 8, to accommodate the picosecond component.
705 (timer_check_2): Use it.
706
707 * nsterm.m (select_timeout, timeval_subtract): Remove.
708 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
709 as they're a bit more accurate and handle overflow better.
710 (ns_select): Change prototype to be compatible with pselect.
711 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
712 * nsterm.h (ns_select): Adjust prototype.
713
714 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
715 us-resolution time stamps.
716 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
717
718 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
719
720 * lisp.h (time_overflow): New decl.
721 (wait_reading_process_output): First arg is now intmax_t, not int,
722 to accommodate larger waits.
723
724 * process.h (struct Lisp_Process.read_output_delay):
725 Now counts nanoseconds, not microseconds.
726 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
727 EMACS_HAS_USECS.
728 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
729 (wait_reading_process_output):
730 Port to ns-resolution time stamps.
731 (Faccept_process_output, wait_reading_process_output):
732 Check for time stamp overflow. Do not assume time_t is signed.
733 (select_wrapper): Remove; we now use pselect.
734 (Fprocess_attributes): Now generates ns-resolution time stamps.
735
736 * sysdep.c: Include utimens.h. Don't include utime.h
737 or worry about struct utimbuf; gnulib does that for us now.
738 (gettimeofday): Remove; gnulib provides a substitute.
739 (make_timeval): New function.
740 (set_file_times): Now sets ns-resolution time stamps.
741 New arg FD; all uses changed.
742 (time_from_jiffies, ltime_from_jiffies, get_up_time)
743 (system_process_attributes):
744 Now returns ns-resolution time stamp. All uses changed.
745 Check for time stamp overflow.
746
747 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
748 provides a substitute now.
749
750 * systime.h: Include timespec.h rather than sys/time.h and time.h,
751 since it guarantees struct timespec.
752 (EMACS_TIME): Now struct timespec, so that we can support
753 ns-resolution time stamps.
754 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
755 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
756 (EMACS_USECS): Remove.
757 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
758 so multiply the arg by 1000 before storing it.
759 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
760 New macros.
761 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
762 Port to ns-resolution time stamps.
763 (EMACS_TIME_NEG_P): Remove; replaced by....
764 (EMACS_TIME_SIGN): New macro.
765 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
766 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
767 (set_file_times, make_time, lisp_time_argument): Adjust signature.
768 (make_timeval, make_lisp_time, decode_time_components): New decls.
769 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
770 that it mishandled time_t overflow. You can't compare by subtracting!
771 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
772 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
773
774 * term.c: Include <sys/time.h>.
775 (timeval_to_Time): New function, for proper overflow wraparound.
776 (term_mouse_position, term_mouse_click): Use it.
777
778 * undo.c (record_first_change): Support higher-resolution time stamps
779 in the undo buffer.
780 (Fprimitive_undo): Use them when restoring time stamps.
781
782 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
783 (w32_get_internal_run_time):
784 Port to higher-resolution Emacs time stamps.
785 (ltime): Now accepts single 64-bit integer, as that's more convenient
786 for callers.
787
788 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
789
790 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
791 for compatibility with pselect. Support ns-resolution time stamps.
792
793 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
794
795 * xselect.c (wait_for_property_change, x_get_foreign_selection):
796 Check for time stamp overflow, and support ns-resolution time stamps.
797
798 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
799 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
800 (timeval_subtract): Remove; no longer needed.
801 (XTflash, XTring_bell, x_wait_for_event):
802 Port to ns-resolution time stamps. Don't assume time_t is signed.
803
b6a92dfe
CY
8042012-06-22 Chong Yidong <cyd@gnu.org>
805
806 * xdisp.c (x_consider_frame_title): Revert last change.
807
d251c37c
EZ
8082012-06-22 Eli Zaretskii <eliz@gnu.org>
809
810 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
811 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
812 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
813 staticidx goes up to 1597 out of 1600 = 0x640.)
814
f10deafb
PE
8152012-06-20 Paul Eggert <eggert@cs.ucla.edu>
816
817 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
818 Otherwise, the umask might be mistakenly 0 while handling input signals.
819
ec6de1e2
SM
8202012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
821
822 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
823
28be1ada
DA
8242012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
825
826 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
827 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
828 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
829 access to `contents' member of Lisp_Vector objects with AREF and ASET
830 where appropriate.
831
c6bf3022
CY
8322012-06-19 Chong Yidong <cyd@gnu.org>
833
834 * frame.c (delete_frame): When selecting a frame on a different
835 text terminal, do not alter the terminal's top-frame.
836
837 * xdisp.c (format_mode_line_unwind_data): Record the target
838 frame's selected window and its terminal's top-frame.
839 (unwind_format_mode_line): Restore them.
840 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
841 Callers changed.
842 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
843 since tty frames can be explicitly named.
844 (prepare_menu_bars): Likewise.
845
846 * term.c (Ftty_top_frame): New function.
847
defd4196
PE
8482012-06-18 Paul Eggert <eggert@cs.ucla.edu>
849
850 Port byte-code-meter to modern targets.
851 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
852 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 853 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
854 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
855 (METER_1, METER_2): Simplify.
856
1053a871
SM
8572012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
858
859 * data.c (Fdefalias): Return `symbol' (bug#11686).
860
b7e8d081
MR
8612012-06-18 Martin Rudalics <rudalics@gmx.at>
862
863 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
864 gets killed during executing of this function (Bug#11665).
865 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
866 (Vkill_buffer_query_functions): In doc-string say that functions
867 run by this hook should not change the current buffer.
868
7ea2b339
PE
8692012-06-18 Paul Eggert <eggert@cs.ucla.edu>
870
871 Fix recently-introduced process.c problems found by static checking.
872 * process.c (write_queue_push, write_queue_pop, send_process):
873 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
874 (write_queue_pop): Fix pointer signedness problem.
875 (send_process): Remove unused local.
876
96a313a1
CY
8772012-06-17 Chong Yidong <cyd@gnu.org>
878
879 * xdisp.c (redisplay_internal): No need to redisplay terminal
880 frames that are not on top.
881
20ca2e94
TN
8822012-06-17 Troels Nielsen <bn.troels@gmail.com>
883
884 * process.c (make_process): Initialize write_queue.
885 (write_queue_push, write_queue_pop): New functions.
886 (send_process): Use them to maintain correct ordering of process
887 writes (Bug#10815).
888
9a900ca9
PE
8892012-06-17 Paul Eggert <eggert@cs.ucla.edu>
890
310fbfa8
PE
891 * lisp.h (eassert): Assume C89 or later.
892 This removes the need for CHECK.
893 (CHECK): Remove. Its comments about always evaluating its
894 argument were confusing, as 'eassert' typically does not evaluate
895 its argument.
896
27bb1ca4
PE
897 * coding.c (produce_chars): Use ptrdiff_t, not int.
898
9a900ca9
PE
899 * xterm.c (x_draw_underwave): Check for integer overflow.
900 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
901
41b7f8bc 9022012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
903
904 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
905 referenced (Bug#11583).
906
9b0e3eba
AA
9072012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
908
909 Implement wave-style variant of underlining.
910 * dispextern.h (face_underline_type): New enum.
911 (face): Add field for underline type.
912 * nsterm.m (ns_draw_underwave): New function.
913 (ns_draw_text_decoration): Use it.
914 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
915 New functions.
916 (x_draw_glyph_string): Use them.
917 * xfaces.c (Qline, Qwave): New Lisp objects.
918 (check_lface_attrs, merge_face_ref)
1053a871
SM
919 (Finternal_set_lisp_face_attribute, realize_x_face):
920 Handle wave-style underline face attributes.
9b0e3eba
AA
921 * xterm.c (x_draw_underwave): New function.
922 (x_draw_glyph_string): Use it.
923
0fb52f11
JB
9242012-06-16 Juanma Barranquero <lekktu@gmail.com>
925
926 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
927 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
928 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
929 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
930 ($(BLD)/w32select.$(O)): Update dependencies.
931
e5560ff7
AS
9322012-06-16 Andreas Schwab <schwab@linux-m68k.org>
933
934 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
935 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
936 * character.c (_fetch_multibyte_char_p): Remove.
937 * alloc.c: Include "character.h" before "buffer.h".
938 * bidi.c: Likewise.
939 * buffer.c: Likewise.
940 * bytecode.c: Likewise.
941 * callint.c: Likewise.
942 * callproc.c: Likewise.
943 * casefiddle.c: Likewise.
944 * casetab.c: Likewise.
945 * category.c: Likewise.
946 * cmds.c: Likewise.
947 * coding.c: Likewise.
948 * composite.c: Likewise.
949 * dired.c: Likewise.
950 * dispnew.c: Likewise.
951 * doc.c: Likewise.
952 * dosfns.c: Likewise.
953 * editfns.c: Likewise.
954 * emacs.c: Likewise.
955 * fileio.c: Likewise.
956 * filelock.c: Likewise.
957 * font.c: Likewise.
958 * fontset.c: Likewise.
959 * fringe.c: Likewise.
960 * indent.c: Likewise.
961 * insdel.c: Likewise.
962 * intervals.c: Likewise.
963 * keyboard.c: Likewise.
964 * keymap.c: Likewise.
965 * lread.c: Likewise.
966 * macros.c: Likewise.
967 * marker.c: Likewise.
968 * minibuf.c: Likewise.
969 * nsfns.m: Likewise.
970 * nsmenu.m: Likewise.
971 * print.c: Likewise.
972 * process.c: Likewise.
973 * regex.c: Likewise.
974 * region-cache.c: Likewise.
975 * search.c: Likewise.
976 * syntax.c: Likewise.
977 * term.c: Likewise.
978 * textprop.c: Likewise.
979 * undo.c: Likewise.
980 * unexsol.c: Likewise.
981 * w16select.c: Likewise.
982 * w32fns.c: Likewise.
983 * w32menu.c: Likewise.
984 * window.c: Likewise.
985 * xdisp.c: Likewise.
986 * xfns.c: Likewise.
987 * xmenu.c: Likewise.
988 * xml.c: Likewise.
989 * xselect.c: Likewise.
990
2f07e6af
EZ
9912012-06-16 Eli Zaretskii <eliz@gnu.org>
992
1053a871
SM
993 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
994 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 995 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
996 row.
997 (handle_face_prop): Use chunk-relative overlay string index when
998 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
999 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1000 the rightmost. (Bug#11720)
2f07e6af 1001
29b83cec
AS
10022012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1003
1004 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1005 (CATEGORY_MEMBER): Enforce 1/0 value.
1006 * category.c (_temp_category_set): Remove.
1007
4c5501e9
EZ
10082012-06-16 Eli Zaretskii <eliz@gnu.org>
1009
1010 * window.c (Fdelete_other_windows_internal)
1011 (Fdelete_window_internal): Don't access frame's mouse highlight
1012 info of the initial frame. (Bug#11677)
1013
2b570124
PE
10142012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1015
e93864f9
PE
1016 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1017 Assume USE_2_TAGS_FOR_INTS.
1018 (xreload): Adjust $tagmask width to match recent lisp.h change.
1019
2b570124
PE
1020 Simplify lisp.h in minor ways that should not affect code.
1021 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1022 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1023 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1024 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1025 (INTTYPEBITS): New macro, for clarity.
1026 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1027 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1028 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1029 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1030 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1031
81755f69
JB
10322012-06-13 Juanma Barranquero <lekktu@gmail.com>
1033
1034 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1035
16192a57
GM
10362012-06-13 Glenn Morris <rgm@gnu.org>
1037
1038 * s/bsd-common.h (BSD4_3):
1039 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1040
646b5f55
AS
10412012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1042
1043 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1044 instead of union.
1045 (XLI, XIL): Define.
1053a871
SM
1046 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1047 Use them.
1048 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1049 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1050 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1051 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1052 * frame.c (delete_frame): Remove outdated comment.
1053 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1054 USE_LISP_UNION_TYPE.
1055 (Fw32_unregister_hot_key): Likewise.
1056 (Fw32_toggle_lock_key): Likewise.
1057 * w32menu.c (add_menu_item): Likewise.
1058 (w32_menu_display_help): Use XIL instead of checking
1059 USE_LISP_UNION_TYPE.
1060 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1061 (init_heap): Likewise.
1062 * w32term.c (w32_read_socket): Update comment.
1063
1d3823c9
GM
10642012-06-13 Glenn Morris <rgm@gnu.org>
1065
c62ff706
GM
1066 * s/usg5-4-common.h, src/s/unixware.h:
1067 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1068
1d3823c9
GM
1069 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1070
bfe3e0a2
PE
10712012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1072
1073 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1074 * alloc.c (make_number) [!defined make_number]:
1075 Remove, as lisp.h always defines this now.
1076 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1077 (roundup_size): Verify that it is a power of 2.
1078 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1079 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1080 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1081 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1082 USE_LSB_TAG now is always defined to be either 0 or 1.
1083 All uses changed.
1084 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1085 code works fine either way, and efficiency is not a concern here,
1086 as the union type is for debugging, not for production.
1087 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1088 Use an inline function on all platforms when using the union type,
1089 since this is simpler and 'static inline' can be used portably
1090 within Emacs now.
1091 (LISP_INITIALLY_ZERO): New macro.
1092 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1093 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1094
45fa9c0f
GM
10952012-06-12 Glenn Morris <rgm@gnu.org>
1096
b4492cba
GM
1097 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1098
1099 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1100
45fa9c0f
GM
1101 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1102 Move BROKEN_SIGIO to configure.
1103
1104 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1105 Move NO_TERMIO to configure.
1106
0e25d334
CY
11072012-06-12 Chong Yidong <cyd@gnu.org>
1108
1109 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1110 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1111 MagickExportImagePixels is undefined.
1112
43682bb6
PE
11132012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1114
1115 * image.c (imagemagick_load_image): Remove unused label.
1116
a9be7d2b
GM
11172012-06-11 Glenn Morris <rgm@gnu.org>
1118
1119 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1120 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1121 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1122 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1123
3017f87f
SM
11242012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1125
1126 * alloc.c (make_byte_code): New function.
1127 (Fmake_byte_code): Use it. Don't purify here.
1128 * lread.c (read1): Use it as well to avoid extra allocation.
1129
1b9b4cf4
CY
11302012-06-11 Chong Yidong <cyd@gnu.org>
1131
1132 * image.c (imagemagick_load_image): Implement transparency.
1133
95988fcf
AS
11342012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1135
1136 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1137 account for preceding backslashes. (Bug#11663)
1138
cd4eb164
CY
11392012-06-09 Chong Yidong <cyd@gnu.org>
1140
1141 * term.c: Support italics in capable terminals (Bug#9652).
1142 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1143 (turn_on_face): Output using TS_enter_italic_mode if available.
1144 Don't handle unused blinking and alt-charset cases.
1145 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1146 and tty_alt_charset_p cases.
1147 (tty_capable_p, init_tty): Support italics.
1148
1149 * termchar.h (struct tty_display_info): Add field for italics.
1150 Remove unused blink field.
1151
1152 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1153 Handle slant.
1154
1155 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1156 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1157 tty_alt_charset_p. Add tty_italic_p.
1158
ff88beb8
MA
11592012-06-09 Michael Albinus <michael.albinus@gmx.de>
1160
1161 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1162 dbus_type_is_basic if available.
1163 (xd_extract_signed, xd_extract_unsigned): Rename from
1164 extract_signed and extract_unsigned, respectively. Adapt callers.
1165
44286096
CY
11662012-06-09 Chong Yidong <cyd@gnu.org>
1167
1682701f
CY
1168 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1169
44286096
CY
1170 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1171 case (Bug#9752).
1172
d86feb17
PE
11732012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 * xdisp.c (vmessage): Treat frame message as multibyte.
1176 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1177 would generate the diagnostic "Making \302\247 buffer-local while
1178 let-bound!".
1179
d5c20fe8
EZ
11802012-06-08 Eli Zaretskii <eliz@gnu.org>
1181
1182 * dispnew.c (showing_window_margins_p): Undo last change, which
1183 was done due to an inadvertent commit.
1184 (adjust_frame_glyphs_for_frame_redisplay): Do call
1185 showing_window_margins_p.
1186
513749ee
SM
11872012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1188
1189 * eval.c (Fmake_var_non_special): New primitive.
1190 (syms_of_eval): Defsubr it.
1191 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1192
d4a8f5c1
JB
11932012-06-08 Juanma Barranquero <lekktu@gmail.com>
1194
1195 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1196 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1197
8bbbc977
EZ
11982012-06-08 Eli Zaretskii <eliz@gnu.org>
1199
1200 * alloc.c (allocate_vectorlike): Fix last change.
1201
f3372c87
DA
12022012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1203
1204 Block-based vector allocation of small vectors.
1205 * lisp.h (struct vectorlike_header): New field `nbytes',
1206 adjust comment accordingly.
1207 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1208 to denote vector blocks. Adjust users (live_vector_p,
1209 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1210 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1211 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1212 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1213 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1214 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1215 (roundup_size): New constant.
1216 (struct vector_block): New data type.
1217 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1218 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1219 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1220 (sweep_vectors): New functions.
1221 (allocate_vectorlike): Return `zero_vector' as the only vector of
1222 0 items. Allocate new vector from block if vector size is less than
1223 or equal to VBLOCK_BYTES_MAX.
1224 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1225 (init_alloc_once): Add call to init_vectors.
1226
4f18a4ed
SM
12272012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1228
1229 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1230
86f158bc
PE
12312012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1232
1233 * doprnt.c (doprnt): Truncate multibyte char correctly.
1234 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1235 would mishandle a string argument "Xc" if X was a multibyte
1236 character of length 2: it would truncate after X's first byte
1237 rather than including all of X.
1238
c5cfcbe0
CY
12392012-06-06 Chong Yidong <cyd@gnu.org>
1240
1241 * buffer.c (word_wrap): Doc fix.
1242
c05cf390
PE
12432012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1244
1245 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1246
0c3461de
GM
12472012-06-03 Glenn Morris <rgm@gnu.org>
1248
1249 * xdisp.c (tool-bar-style): Doc fix.
1250
c71232db
UM
12512012-06-03 Ulrich Müller <ulm@gentoo.org>
1252
1253 * Makefile.in (PAXCTL): Define.
1254 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1255 binary via PaX flags if the paxctl utility is available.
1256 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1257 Restore PaX flags to their default. (Bug#11398)
1258
383f7350
CY
12592012-06-03 Chong Yidong <cyd@gnu.org>
1260
1261 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1262 buffer (Bug#11226).
1263
5f2c76c6
CY
12642012-06-03 Chong Yidong <cyd@gnu.org>
1265
1266 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1267 (note_mode_line_or_margin_highlight): If there is no help echo,
1268 use mode-line-default-help-echo. Handle the case where the mouse
1269 position is past the end of the mode line string.
1270
1271 * buffer.c (buffer_local_value_1): New function, split from
1272 Fbuffer_local_value; can return Qunbound.
1273 (Fbuffer_local_value): Use it.
1274 (Vmode_line_format): Docstring tweaks.
1275
773d47f6
PE
12762012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1277
1278 * sysdep.c (system_process_attributes): Improve comment.
1279
f2d6a3df
SM
12802012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1281
1282 * keyboard.c: Export real-this-command to Elisp.
1283 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1284 and DEFVAR it. Update all users.
1285
63810350
PE
12862012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1287
7bd5c1f4
PE
1288 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1289
63810350
PE
1290 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1291 Convert pctcpu and pctmem to Lisp float properly.
1292 Let the compiler fold better, as 100.0/0x8000 is exact.
1293
a2821611
AS
12942012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1295
1296 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1297 cons_block.
1298
5fceba1d
PE
12992012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1300
1301 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1302
c98ff5dd
DA
13032012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1304
1305 For a 'struct window', replace some Lisp_Object fields to
1306 bitfields where appropriate, remove unused fields.
1307 * window.h (struct window): Remove unused 'last_mark_x' and
1308 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1309 change it's type from Lisp_Object to bitfield.
1310 Change type of 'force_start', 'optional_new_start',
1311 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1312 fields from Lisp_Object to bitfield. Adjust users accordingly.
1313
ca34e0be
PE
13142012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1315
1316 Pacify gcc -Wdouble-precision when using Xaw.
1317 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1318 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1319 Use 'float' consistently, rather than 'float' in most places
1320 and 'double' in a couple of places.
1321
efc00ab1 13222012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1323
1324 * xdisp.c (handle_stop): Detect whether we have overlay strings
1325 loaded by testing it->current.overlay_string_index to be
1326 non-negative, instead of checking whether n_overlay_strings is
1327 positive. (Bug#11587)
1328
efc00ab1 13292012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1330
1331 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1332
1333 * doc.c (Fsubstitute_command_keys): Doc fix.
1334
efc00ab1 13352012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1336
1337 * search.c (search_buffer): Remove calls to
1338 r_alloc_inhibit_buffer_relocation, as it is now called by
1339 maybe_unify_char, which was the cause of relocation of buffer text
1340 in bug#11519.
1341
efc00ab1 13422012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1343
1344 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1345 for the duration of call to load_charset, to avoid problems with
1346 callers of maybe_unify_char that access buffer text through C
1347 pointers.
1348
1349 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1350 decrement the inhibition flag, instead of just setting or
1351 resetting it.
1352
ba93a187
PE
13532012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1354
1355 Remove obsolete '#define static' cruft.
1356 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1357 This #undef was "temporary" in 2000; it is no longer needed
1358 now that '#define static' has gone away.
1359 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1360 (gray_bitmap_bits): Remove; no longer needed.
1361 All uses replaced with definiens.
1362 * xterm.c: Include "bitmaps/gray.xbm".
1363
9e4bf381
PE
13642012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1365
1366 Clean up __executable_start, monstartup when --enable-profiling.
1367 The following changes affect the code only when profiling.
1368 * dispnew.c (__executable_start): Rename from safe_bcopy.
1369 Define only on platforms that need it.
1370 * emacs.c: Include <sys/gmon.h> when profiling.
1371 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1372 (__executable_start): Remove decl, since lisp.h does it now.
1373 (safe_bcopy): Remove decl; no longer has that name.
1374 (main): Coalesce #if into single bit of code, for simplicity.
1375 Cast pointers to uintptr_t, since standard libraries want integers
1376 and not pointers.
1377 * lisp.h (__executable_start): New decl.
1378
32d72c2f
GM
13792012-05-31 Glenn Morris <rgm@gnu.org>
1380
1381 * image.c (Fimagemagick_types): Doc fix.
1382
baac5bc7
JM
13832012-05-30 Jim Meyering <meyering@redhat.com>
1384
1385 * callproc.c (Fcall_process_region): Include directory component
1386 in mkstemp error message (Bug#11586).
1387
72cb32cf
PE
13882012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1389
1390 * alloc.c, lisp.h (make_pure_vector): Now static.
1391
61b108cc
SM
13922012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1393
1394 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1395 Move to byte-run.el.
1396 (Fautoload): Do the hash-doc more carefully.
1397 * data.c (Fdefalias): Purify definition, except for keymaps.
1398 (Qdefun): Move from eval.c.
1399 * lisp.h (Qdefun): Remove.
1400 * lread.c (read1): Tiny simplification.
1401
471fe23d
TN
14022012-05-29 Troels Nielsen <bn.troels@gmail.com>
1403
934f3f58 1404 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1405 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1406 Bug#9642, but explicitly check that the buffer the overlay would
1407 be moved to is live and rearrange lines to make sure that errors
1408 will not put the overlay in an inconsistent state.
1409 (Fdelete_overlay): Cosmetics.
1410
85d0efd1
EZ
14112012-05-28 Eli Zaretskii <eliz@gnu.org>
1412
1413 * w32term.c (my_bring_window_to_top): New function.
1414 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1415 could be different from the original one.
1416 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1417 (Bug#11513)
1418
1419 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1420 by calling BringWindowToTop.
1421
1422 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1423 (WM_EMACS_END): Increase by one.
1424
da92a98c
PE
14252012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1426
1427 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1428 This avoids undefined behavior that might cause the eassert
1429 to not catch an out-of-range value.
1430
74d1f848
JB
14312012-05-28 Juanma Barranquero <lekktu@gmail.com>
1432
1433 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1434 Update dependencies.
1435
9e1a06fc
EZ
14362012-05-27 Eli Zaretskii <eliz@gnu.org>
1437
1438 * bidi.c (bidi_mirror_char): Fix last change.
1439
f3dd7312
AS
14402012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1441
1442 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1443 when referring to sectname field in printf format.
1444
81899c91
PE
14452012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1446
57b81a9f
PE
1447 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1448 Only r_alloc_inhibit_buffer_relocation needed to be added;
1449 the others were already declared.
1450
81899c91
PE
1451 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1452 before checking whether it's out of range. Put the check inside
1453 eassert. See
1454 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1455
33017faf 14562012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1457
1458 * callproc.c (Fcall_process): Restore a line that was accidentally
1459 commented out in the 2011-02-13 change (bug#11547).
1460
33017faf 14612012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1462
1463 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1464 defined on ralloc.c.
1465
1466 * buffer.c [REL_ALLOC]: Remove prototypes of
1467 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1468 they are now on lisp.h.
1469
1470 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1471
1472 * search.c (search_buffer): Use it to inhibit relocation of buffer
1473 text while re_search_2 is doing its job, because re_search_2 is
1474 passed C pointers to buffer text. (Bug#11519)
1475
23415acf
EZ
1476 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1477 Update value to 24.
1478
44e27368
EZ
1479 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1480 state after an additional call to move_it_in_display_line_to, keep
1481 the values of it->max_ascent and it->max_descent found for the
1482 entire line.
1483 (pos_visible_p): Revert the comparison against bottom_y to what it
1484 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1485 (Bug#11464)
1486
c1892f11
PE
14872012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1488
1489 Fix coding-related core dumps with gcc -ftrapv.
1490 The code was computing A - B, where A and B are pointers, and B is
1491 random garbage. This can lead to core dumps on platforms that
1492 have special pointer registers, and it also leads to core dumps on
1493 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1494 A - B only when B is initialized properly.
1495 * coding.c (coding_set_source, coding_set_destination): Return void.
1496 (coding_change_source, coding_change_destinations): New functions,
1497 with the old behaviors of coding_set_source and coding_set_destination.
1498 All callers that need an offset changed to use these new functions.
1499
eb7afdad
GM
15002012-05-26 Glenn Morris <rgm@gnu.org>
1501
1502 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1503
f12fdf02
EZ
15042012-05-26 Eli Zaretskii <eliz@gnu.org>
1505
53a63be6 1506 Extend mouse support on W32 text-mode console.
61b108cc
SM
1507 * xdisp.c (draw_row_with_mouse_face):
1508 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1509
eb3f6f01 1510 * w32console.c: Include window.h.
61b108cc
SM
1511 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1512 New functions.
eb3f6f01
EZ
1513 (initialize_w32_display): Initialize mouse-highlight data.
1514
53a63be6
EZ
1515 * w32inevt.c: Include termchar.h and window.h.
1516 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1517 moves, call note_mouse_highlight. If help_echo changed, call
1518 gen_help_event to produce help-echo message in the echo area.
1519 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1520 highlight info.
1521
4cfd81f6
PE
15222012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1523
1524 * lread.c (read1): Simplify slightly to avoid an overflow warning
1525 with GCC 4.7.0 on x86-64.
1526
4446092a
EZ
15272012-05-26 Eli Zaretskii <eliz@gnu.org>
1528
1529 * bidi.c (bidi_mirror_char): Revert last change: an int is
1530 definitely wide enough here.
1531
42b2a986 15322012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1533
42b2a986 1534 Fix integer width and related bugs (Bug#9874).
eb106a49 1535 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1536 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1537 (string_bytes, check_sblock, allocate_string_data):
1538 (compact_small_strings, Fmake_bool_vector, make_string)
1539 (make_unibyte_string, make_multibyte_string)
1540 (make_string_from_bytes, make_specified_string)
1541 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1542 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1543 (mark_vectorlike):
1544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1545 (allocate_pseudovector):
1546 Use int, not EMACS_INT, where int is wide enough.
1547 (inhibit_garbage_collection, Fgarbage_collect):
1548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1549 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1550 int might not be wide enough.
1551 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1552 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1553 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1554 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1555 (bidi_level_of_next_char, bidi_move_to_visually_next):
1556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1557 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1558 (Fkill_buffer, Fset_buffer_major_mode)
1559 (advance_to_char_boundary, Fbuffer_swap_text)
1560 (Fset_buffer_multibyte, overlays_at, overlays_in)
1561 (overlay_touches_p, struct sortvec, record_overlay_string)
1562 (overlay_strings, recenter_overlay_lists)
1563 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1564 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1565 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1566 (Foverlay_recenter, last_overlay_modification_hooks_used)
1567 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1569 (validate_region): Omit unnecessary test for b <= e,
1570 since that's guaranteed by the previous test.
d311d28c
PE
1571 (adjust_overlays_for_delete): Avoid pos + length overflow.
1572 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1573 (report_overlay_modification):
1574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1575 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1576 Omit pointer cast, which isn't needed anyway, and doesn't work
1577 after the EMACS_INT -> ptrdiff_t change.
02481186 1578 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1579 * buffer.h: Adjust decls to match defn changes elsewhere.
1580 (struct buffer_text, struct buffer):
1581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1582 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1583 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1584 not int, to avoid needless 32-bit limit on 64-bit hosts.
1585 (exec_byte_code): Use tighter memory-full test, one that checks
1586 for alloca overflow. Don't compute the address of the object just
1587 before an array, as that's not portable. Use EMACS_INT, not
1588 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1589 * callint.c (Fcall_interactively):
1590 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1591 * callproc.c (call_process_kill, Fcall_process):
1592 Don't assume pid_t fits into an Emacs fixnum.
1593 (call_process_cleanup, Fcall_process, child_setup):
1594 Don't assume pid_t fits into int.
1595 (call_process_cleanup, Fcall_process, delete_temp_file)
1596 (Fcall_process_region):
1597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1598 (Fcall_process): Simplify handling of volatile integers.
1599 Use int, not EMACS_INT, where int will do.
1600 * casefiddle.c (casify_object, casify_region, operate_on_word)
1601 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1603 (casify_object): Avoid integer overflow when overallocating buffer.
1604 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1605 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1606 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1607 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1608 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1609 integers are now checked earlier. All uses replaced with XINT.
1610 (ccl_driver):
1611 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1612 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1613 (ccl_driver, Fregister_code_conversion_map):
1614 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1615 (resolve_symbol_ccl_program): Check that vector header is in range.
1616 Always copy the vector, so that we can check its contents reliably
1617 now rather than having to recheck each instruction as it's being
1618 executed. Check that vector words fit in 'int'.
1619 (ccl_get_compiled_code, Fregister_ccl_program)
1620 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1621 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1622 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1623 contents are in range.
1624 (Fccl_execute_on_string): Check that status is in range.
1625 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1626 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1627 Accept and return EMACS_INT, not int, because callers can pass values
1628 out of 'int' range.
1629 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1630 (multibyte_chars_in_text, parse_str_as_multibyte)
1631 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1632 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1633 (string_escape_byte8, Fget_byte):
1634 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1635 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1636 avoid mishandling large integers.
1637 * character.h: Adjust decls to match defn changes elsewhere.
1638 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1639 (Ffind_charset_region):
1640 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1641 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1642 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1643 Don't assume fixnum fits in int.
d311d28c
PE
1644 (load_charset_map_from_vector, Fmap_charset_chars):
1645 Remove now-unnecessary CHECK_NATNUMs.
1646 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1647 Don't rely on undefined behavior with signed left shift overflow.
1648 Don't assume unsigned int fits into fixnum, or that fixnum fits
1649 into unsigned int. Don't require max_code to be a valid fixnum;
1650 that's not true for gb10830 4-byte on a 32-bit host. Allow
1651 invalid_code to be a cons, for the same reason. Require code_offset
1652 to be a character. Avoid int overflow if max_char is close
1653 to INT_MAX.
1654 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1655 this is intended anyway and avoids some undefined behavior.
1656 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1657 INDEX_TO_CODE_POINT, as that's what it expects.
1658 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1659 * charset.h (DECODE_CHAR): Return int, not unsigned;
1660 this is what was intended anyway, and it avoids undefined behavior.
1661 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1662 integer-overflow issues.
1663 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1664 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1665 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1666 * chartab.c (Fmake_char_table, Fset_char_table_range)
1667 (uniprop_get_decoder, uniprop_get_encoder):
1668 Don't assume fixnum fits in int.
1669 * cmds.c (move_point): New function, that does the gist of
1670 Fforward_char and Fbackward_char, but does so while checking
1671 for integer overflow more accurately.
c96e5d6a 1672 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1673 (Fforward_line, Fend_of_line, internal_self_insert)
1674 (internal_self_insert):
1675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1676 Fix a FIXME, by checking for integer overflow when calculating
1677 target_clm and actual_clm.
1678 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1679 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1680 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1681 (coding_alloc_by_making_gap, alloc_destination)
1682 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1683 (encode_coding_utf_16, detect_coding_emacs_mule)
1684 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1685 (detect_coding_iso_2022, decode_coding_iso_2022)
1686 (encode_invocation_designation, encode_designation_at_bol)
1687 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1688 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1689 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1690 (encode_coding_ccl, encode_coding_raw_text)
1691 (detect_coding_charset, decode_coding_charset)
1692 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1693 (produce_composition, produce_charset, produce_annotation)
1694 (decode_coding, handle_composition_annotation)
1695 (handle_charset_annotation, consume_chars, decode_coding_gap)
1696 (decode_coding_object, encode_coding_object, detect_coding_system)
1697 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1698 (code_convert_region, code_convert_string)
8f50130c
PE
1699 (Fdefine_coding_system_internal)
1700 (coding_set_source, coding_set_destination):
d311d28c
PE
1701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1702 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1703 (Fdefine_coding_system_internal):
1704 Don't assume fixnums fit in int.
1705 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1706 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1707 (Funencodable_char_position, Fcheck_coding_systems_region)
1708 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1710 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1711 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1712 Don't access memory outside of the args array.
d311d28c 1713 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1714 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1715 result of ENCODE_CHAR.
d311d28c
PE
1716 * coding.h: Adjust decls to match defn changes elsewhere.
1717 (struct coding_system):
1718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1719 * composite.c (get_composition_id, find_composition)
1720 (run_composition_function, update_compositions)
1721 (compose_text, composition_gstring_put_cache)
1722 (composition_gstring_p, composition_gstring_width)
1723 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1724 (composition_compute_stop_pos, composition_reseat_it)
1725 (composition_update_it, struct position_record)
1726 (find_automatic_composition, composition_adjust_point)
1727 (Fcomposition_get_gstring, Ffind_composition_internal):
1728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1729 (update_compositions):
1730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1731 * composite.h: Adjust decls to match defn changes elsewhere.
1732 (struct composition):
1733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1734 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1735 Do not attempt to compute the address of the object just before a
1736 buffer; this is not portable.
1737 (Faref, Faset):
1738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1739 (Faset): Use int, not EMACS_INT, where int is wide enough.
1740 (Fstring_to_number): Don't assume fixnums fit in int.
1741 (Frem): Don't assume arg is nonnegative.
1742 * dbusbind.c (xd_append_arg): Check for integers out of range.
1743 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1744 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1745 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1746 (xd_get_connection_references): Return ptrdiff_t, not int.
1747 All uses changed.
1748 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1749 (xd_read_message_1):
1750 Use int, not unsigned, where the dbus API uses int.
1751 (Fdbus_message_internal): Don't overflow mtype.
1752 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1753 * dired.c (directory_files_internal, file_name_completion, scmp)
1754 (file_name_completion_stat):
1755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1756 (file_name_completion): Don't overflow matchcount.
1757 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1758 * dispextern.h: Adjust decls to match defn changes elsewhere.
1759 (struct text_pos, struct glyph, struct bidi_saved_info)
1760 (struct bidi_string_data, struct bidi_it, struct composition_it)
1761 (struct it):
1762 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1763 (struct display_pos, struct composition_it, struct it):
1764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1765 * dispnew.c (increment_matrix_positions)
1766 (increment_row_positions, mode_line_string)
1767 (marginal_area_string):
1768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1769 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1771 (duration_to_sec_usec): New function, to check for overflow better.
1772 (Fsleep_for, sit_for): Use it.
1773 * doc.c (get_doc_string, store_function_docstring):
1774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1775 (get_doc_string, Fsnarf_documentation):
1776 Use int, not EMACS_INT, where int is wide enough.
1777 (get_doc_string):
1778 Use SAFE_ALLOCA, not alloca.
1779 Check for overflow when converting EMACS_INT to off_t.
1780 * doprnt.c (doprnt):
1781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1782 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1783 Don't assume uid_t fits into fixnum.
1784 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1785 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1786 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1787 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1788 (general_insert_function)
1789 (Finsert_char, make_buffer_string, make_buffer_string_both)
1790 (update_buffer_properties, Fbuffer_substring)
1791 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1792 (Fsubst_char_in_region, check_translation)
1793 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1794 (transpose_markers, Ftranspose_regions):
1795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1796 (clip_to_bounds): Move to lisp.h as an inline function).
1797 (Fconstrain_to_field): Don't assume integers are nonnegative.
1798 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1799 (Fsubst_char_in_region, Fsave_restriction):
1800 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1801 (Femacs_pid): Don't assume pid_t fits into fixnum.
1802 (lo_time): Use int, not EMACS_INT, when int suffices.
1803 (lisp_time_argument): Check for usec out of range.
1804 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1805 (Fuser_login_name, Fuser_full_name): Signal an error
1806 if a uid argument is out of range, rather than relying on
1807 undefined behavior.
c8d5c857
PE
1808 (Fformat_time_string): Remove now-unnecessary check.
1809 lisp_time_argument checks for out-of-range usec now.
243e0530 1810 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1811 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1812 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1813 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1814 (init_cmdargs, Fdump_emacs):
1815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1816 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1817 the bottom (typically) 32 bits of the fixnum.
1818 * eval.c (specpdl_size, call_debugger):
1819 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1820 (when_entered_debugger, Fbacktrace_debug):
1821 Don't assume fixnum can fit in int.
1822 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1823 the object just before a buffer; this is not portable.
1824 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1825 (grow_specpdl, unbind_to):
1826 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1827 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1828 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1829 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1830 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1831 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1833 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1834 (a_write, e_write):
1835 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1836 (Fcopy_file, non_regular_nbytes, read_non_regular)
1837 (Finsert_file_contents):
1838 Use int, not EMACS_INT, where int is wide enough.
1839 (READ_BUF_SIZE): Verify that it fits in int.
1840 (Finsert_file_contents): Check that counts are in proper range,
1841 rather than assuming fixnums fit into ptrdiff_t etc.
1842 Don't assume fixnums fit into int.
125b3835 1843 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1844 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1845 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1846 (string_char_to_byte, string_byte_to_char)
1847 (string_make_multibyte, string_to_multibyte)
1848 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1849 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1850 (substring_both, Fdelete, internal_equal, Ffillarray)
1851 (Fclear_string, mapcar1)
1852 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1853 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1854 (larger_vector, make_hash_table, maybe_resize_hash_table)
1855 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1856 (Fmaphash, secure_hash):
1857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1858 (concat): Check for string index and length overflow.
1859 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1860 (Frequire):
1861 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1862 (larger_vector): New API (vec, incr_min, size_max) replaces old
1863 one (vec, new_size, init). This catches size overflow.
1864 INIT was removed because it was always Qnil.
1865 All callers changed.
1866 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1867 the upper bound on a hash table index size.
1868 (make_hash_table, maybe_resize_hash_table): Use it.
1869 (secure_hash): Computer start_byte and end_byte only after
1870 they're known to be in ptrdiff_t range.
1871 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1872 (Ffont_get_glyphs, Ffont_at):
1873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1874 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1875 (Flist_fonts, Fopen_font):
1876 Don't assume fixnum can fit in int.
1877 (check_gstring): Don't assume index can fit in int.
1878 (font_match_p): Check that fixnum is a character, not a nonnegative
1879 fixnum, since the later code needs to stuff it into an int.
1880 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1881 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1882 conversion overflow issues.
1883 (Fopen_font): Check for integer out of range.
1884 (Ffont_get_glyphs): Don't assume index can fit in int.
1885 * font.h: Adjust decls to match defn changes elsewhere.
1886 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1887 integer overflow.
1888 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1889 printmax_t, where ptrdiff_t is wide enough.
1890 (Finternal_char_font):
1891 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1892 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1893 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1894 (Fset_frame_position, x_set_frame_parameters)
1895 (x_set_line_spacing, x_set_border_width)
1896 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1897 Check that fixnums are in proper range for system types.
1898 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1899 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1900 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1901 Use SAFE_ALLOCA_LISP, not alloca.
1902 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1903 intptr_t is wide enough.
1904 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1905 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1906 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1907 Check for fixnum out of range.
1908 * ftfont.c (ftfont_list): Don't assume index fits in int.
1909 Check that fixnums are in proper range for system types.
1910 (ftfont_shape_by_flt):
1911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1912 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1913 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1914 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1915 Check that fixnums are in proper range for system types.
1916 * gnutls.h: Adjust decls to match defn changes elsewhere.
1917 * gtkutil.c (xg_dialog_run):
1918 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1919 (update_frame_tool_bar):
1920 Check that fixnums are in proper range for system types.
1921 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1922 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1923 * indent.c (last_known_column, last_known_column_point):
1924 (current_column_bol_cache):
1925 (skip_invisible, current_column, check_display_width):
1926 (check_display_width, scan_for_column, current_column_1)
1927 (Findent_to, Fcurrent_indentation, position_indentation)
1928 (indented_beyond_p, Fmove_to_column, compute_motion):
1929 (Fcompute_motion, Fvertical_motion):
1930 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1931 (last_known_column_modified): Use EMACS_INT, not int.
1932 (check_display_width):
1933 (Fcompute_motion):
1934 Check that fixnums and floats are in proper range for system types.
1935 (compute_motion): Don't assume index or fixnum fits in int.
1936 (compute_motion, Fcompute_motion):
1937 Use int, not EMACS_INT, when it is wide enough.
1938 (vmotion): Omit local var start_hpos that is always 0; that way
1939 we don't need to worry about overflow in expressions involving it.
1940 * indent.h: Adjust decls to match defn changes elsewhere.
1941 (struct position):
1942 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1943 Use int, not EMACS_INT, where int is wide enough.
1944 Remove unused members ovstring_chars_done and tab_offset;
1945 all uses removed.
1946 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1947 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1948 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1949 (make_gap, copy_text, insert, insert_and_inherit)
1950 (insert_before_markers, insert_before_markers_and_inherit)
1951 (insert_1, count_combining_before, count_combining_after)
1952 (insert_1_both, insert_from_string)
1953 (insert_from_string_before_markers, insert_from_string_1)
1954 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1955 (adjust_after_replace, adjust_after_insert, replace_range)
1956 (replace_range_2, del_range, del_range_1, del_range_byte)
1957 (del_range_both, del_range_2, modify_region)
1958 (prepare_to_modify_buffer, signal_before_change)
1959 (signal_after_change, Fcombine_after_change_execute):
1960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1961 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1962 (balance_an_interval, split_interval_right, split_interval_left)
1963 (find_interval, next_interval, update_interval)
1964 (adjust_intervals_for_insertion, delete_node, delete_interval)
1965 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1966 (static_offset_intervals, offset_intervals)
1967 (merge_interval_right, merge_interval_left, make_new_interval)
1968 (graft_intervals_into_buffer, temp_set_point_both)
1969 (temp_set_point, set_point, adjust_for_invis_intang)
1970 (set_point_both, move_if_not_intangible, get_property_and_range)
1971 (get_local_map, copy_intervals, copy_intervals_to_string)
1972 (compare_string_intervals, set_intervals_multibyte_1):
1973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1974 * intervals.h: Adjust decls to match defn changes elsewhere.
1975 (struct interval):
1976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1977 * keyboard.c (this_command_key_count, this_single_command_key_start)
1978 (before_command_key_count, before_command_echo_length, echo_now)
1979 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1980 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1981 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1982 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1983 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1984 (last_non_minibuf_size, last_point_position, echo_truncate)
1985 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1986 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1987 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1988 (stuff_buffered_input):
1989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1990 (last_auto_save, command_loop_1, read_char):
1991 Use EMACS_INT, not int, to avoid integer overflow.
1992 (record_char): Avoid overflow in total_keys computation.
1993 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1994 * keyboard.h: Adjust decls to match defn changes elsewhere.
1995 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1996 (Fkey_description, Fdescribe_vector, Flookup_key):
1997 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1998 (click_position): New function, to check that positions are in range.
1999 (Fcurrent_active_maps):
2000 (describe_command):
2001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2002 (Faccessible_keymaps, Fkey_description):
2003 (preferred_sequence_p):
2004 Don't assume fixnum can fit into int.
2005 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2006 Check for integer overflow in size calculations.
2007 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2008 avoid mishandling large integers.
2009 * lisp.h: Adjust decls to match defn changes elsewhere.
2010 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2011 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2012 (struct Lisp_Marker):
2013 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2014 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2015 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2016 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2017 All callers changed.
2018 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2019 Assume the arg has valid form, since it always does.
2020 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2021 unsigned integer system type.
2022 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2023 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2025 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2026 (duration_to_sec_usec): New decl.
2027 * lread.c (read_from_string_index, read_from_string_index_byte)
2028 (read_from_string_limit, readchar, unreadchar, openp)
2029 (read_internal_start, read1, oblookup):
2030 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2031 (Fload, readevalloop, Feval_buffer, Feval_region):
2032 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2033 (openp): Check for out-of-range argument to 'access'.
2034 (read1): Use int, not EMACS_INT, where int is wide enough.
2035 Don't assume fixnum fits into int.
6efdadfd 2036 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2037 (read_filtered_event): Use duration_to_sec_usec
2038 to do proper overflow checking on durations.
d311d28c
PE
2039 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2040 in size calculation.
2041 (Fexecute_kbd_macro):
2042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2043 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2044 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2045 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2046 (set_marker_both, set_marker_restricted_both, marker_position)
2047 (marker_byte_position, Fbuffer_has_markers_at):
2048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2049 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2050 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2051 It now merely ensures that the menu is large enough, without
2052 necessarily growing it, as this avoids some integer overflow issues.
2053 All callers changed.
2054 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2055 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2056 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2057 Use SAFE_ALLOCA_LISP, not alloca.
2058 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2059 to EMACS_INT. Check that fixnums are in proper range for system types.
2060 * minibuf.c (minibuf_prompt_width, string_to_object)
2061 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2062 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2063 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2064 (get_minibuffer, read_minibuf_unwind):
2065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2066 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2067 this simplifies overflow checking. All callers changed.
2068 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2069 (Ftest_completion):
2070 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2071 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2072 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2073 Check that fixnums are in proper range for system types.
2074 (Fx_create_frame, Fx_show_tip):
2075 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2076 * nsfont.m (ns_findfonts, nsfont_list_family):
2077 Don't assume fixnum fits in long.
2078 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2079 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2080 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2081 wide enough.
17fdb222 2082 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2083 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2084 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2085 (PRINTDECLARE, PRINTPREPARE):
2086 (strout, print_string):
2087 (print, print_preprocess, print_check_string_charset_prop)
2088 (print_object):
2089 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2090 (PRINTDECLARE):
2091 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2092 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2093 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2094 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2095 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2096 (print_error_message): Use SAFE_ALLOCA, not alloca.
2097 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2098 (print_depth, new_backquote_output, print_number_index):
2099 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2100 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2101 (Fset_process_window_size, Fformat_network_address)
2102 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2103 (sigchld_handler):
d311d28c 2104 Check that fixnums are in proper range for system types.
d44287d4 2105 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2106 Check for process-ids out of pid_t range rather than relying on
2107 undefined behavior.
e4d81efc 2108 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2109 (Fformat_network_address, read_process_output, send_process)
2110 (Fprocess_send_region, status_notify):
2111 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2112 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2113 (wait_reading_process_output, read_process_output, exec_sentinel):
2114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2115 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2116 (Faccept_process_output): Use duration_to_sec_usec to do proper
2117 overflow checking on durations.
dde14581
PE
2118 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2119 Don't assume pid_t fits in int.
02481186
PE
2120 * process.h (struct Lisp_Process): Members tick and update_tick
2121 are now of type EMACS_INT, not int.
b62b53e8
PE
2122 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2123 configured --with-wide-int.
d311d28c
PE
2124 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2125 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2126 * search.c (looking_at_1, string_match_1):
2127 (fast_string_match, fast_c_string_match_ignore_case)
2128 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2129 (scan_newline, find_before_next_newline, search_command)
2130 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2131 (set_search_regs, wordify):
2132 (Freplace_match):
2133 (Fmatch_data):
2134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2135 (string_match_1, search_buffer, set_search_regs):
2136 (Fmatch_data):
2137 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2138 (wordify): Check for overflow in size calculation.
2139 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2140 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2141 Check that fixnums are in proper range for system types.
2142 * sound.c (struct sound_device)
2143 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2145 (Fplay_sound_internal):
2146 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2147 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2148 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2149 (Fparse_partial_sexp):
2150 Don't assume fixnums can fit in int.
2151 (struct lisp_parse_state, find_start_pos, find_start_value)
2152 (find_start_value_byte, find_start_begv)
2153 (update_syntax_table, char_quoted, dec_bytepos)
2154 (find_defun_start, prev_char_comend_first, back_comment):
2155 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2156 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2158 (Finternal_describe_syntax_value): Check that match_lisp is a
2159 character, not an integer, since the code stuffs it into int.
2160 (scan_words, scan_sexps_forward):
2161 Check that fixnums are in proper range for system types.
2162 (Fforward_word):
2163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2164 (scan_sexps_forward):
2165 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2166 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2167 * syntax.h: Adjust decls to match defn changes elsewhere.
2168 (struct gl_state_s):
2169 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2170 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2171 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2172 * sysdep.c (wait_for_termination_1, wait_for_termination)
2173 (interruptible_wait_for_termination, mkdir):
2174 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2175 (emacs_read, emacs_write):
2176 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2177 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2178 and double all fit in int.
d311d28c
PE
2179 * term.c (set_tty_color_mode):
2180 Check that fixnums are in proper range for system types.
2181 * termhooks.h (struct input_event):
2182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2183 * textprop.c (validate_interval_range, interval_of)
2184 (Fadd_text_properties, set_text_properties_1)
2185 (Fremove_text_properties, Fremove_list_of_text_properties)
2186 (Ftext_property_any, Ftext_property_not_all)
2187 (copy_text_properties, text_property_list, extend_property_ranges)
2188 (verify_interval_modification):
2189 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2190 (Fnext_single_char_property_change)
2191 (Fprevious_single_char_property_change):
2192 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2193 (copy_text_properties):
2194 Check for integer overflow in index calculation.
d311d28c
PE
2195 * undo.c (last_boundary_position, record_point, record_insert)
2196 (record_delete, record_marker_adjustment, record_change)
2197 (record_property_change):
2198 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2199 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2200 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2201 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2202 (Fx_hide_tip, Fx_file_dialog):
2203 * w32menu.c (set_frame_menubar):
2204 Use ptrdiff_t, not int, for consistency with rest of code.
2205 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2206 (select_window, Fdelete_other_windows_internal)
2207 (window_scroll_pixel_based, window_scroll_line_based)
2208 (Frecenter, Fset_window_configuration):
2209 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2210 (Fset_window_hscroll, run_window_configuration_change_hook)
2211 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2212 (Fscroll_other_window, Frecenter):
d311d28c
PE
2213 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2214 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2215 Don't assume fixnum fits in int.
2216 (Fset_window_scroll_bars):
2217 Check that fixnums are in proper range for system types.
2218 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2219 (string_pos, c_string_pos, number_of_chars, init_iterator)
2220 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2221 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2222 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2223 (face_before_or_after_it_pos, handle_invisible_prop)
2224 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2225 (display_prop_intangible_p, string_buffer_position_lim)
2226 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2227 (get_overlay_strings_1, get_overlay_strings)
2228 (iterate_out_of_display_property, forward_to_next_line_start)
2229 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2230 (get_next_display_element, set_iterator_to_next)
2231 (get_visually_first_element, compute_stop_pos_backwards)
2232 (handle_stop_backwards, next_element_from_buffer)
2233 (move_it_in_display_line_to, move_it_in_display_line)
2234 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2235 (add_to_log, message_dolog, message_log_check_duplicate)
2236 (message2, message2_nolog, message3, message3_nolog
2237 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2238 (current_message_1, truncate_echo_area, truncate_message_1)
2239 (set_message, set_message_1, store_mode_line_noprop)
2240 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2241 (text_outside_line_unchanged_p, check_point_in_composition)
2242 (reconsider_clip_changes)
2243 (redisplay_internal, set_cursor_from_row, try_scrolling)
2244 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2245 (redisplay_window, find_last_unchanged_at_beg_row)
2246 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2247 (trailing_whitespace_p, find_row_edges, display_line)
2248 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2249 (display_mode_element, store_mode_line_string)
2250 (pint2str, pint2hrstr, decode_mode_spec)
2251 (display_count_lines, display_string, draw_glyphs)
2252 (x_produce_glyphs, x_insert_glyphs)
2253 (rows_from_pos_range, mouse_face_from_buffer_pos)
2254 (fast_find_string_pos, mouse_face_from_string_pos)
2255 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2256 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2257 (safe_call, init_from_display_pos, handle_fontified_prop)
2258 (handle_single_display_spec, load_overlay_strings)
2259 (with_echo_area_buffer, setup_echo_area_for_printing)
2260 (display_echo_area, echo_area_display)
2261 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2262 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2263 (redisplay_window, dump_glyph_row, display_mode_line)
2264 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2265 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2266 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2267 (handle_single_display_spec, build_desired_tool_bar_string)
2268 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2269 (get_specified_cursor_type):
2270 Check that fixnums are in proper range for system types.
2271 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2272 (Flookup_image_map):
2273 Don't assume fixnums fit in int.
2274 (compare_overlay_entries):
2275 Avoid mishandling comparisons due to subtraction overflow.
2276 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2277 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2278 (handle_tool_bar_click):
2279 Use int, not unsigned, since we prefer signed and the signedness
2280 doesn't matter here.
2281 (get_next_display_element, next_element_from_display_vector):
2282 Use int, not EMACS_INT, when int is wide enough.
2283 (start_hourglass): Use duration_to_sec_usec to do proper
2284 overflow checking on durations.
2285 * xfaces.c (Fbitmap_spec_p):
2286 Check that fixnums are in proper range for system types.
2287 (compare_fonts_by_sort_order):
2288 Avoid mishandling comparisons due to subtraction overflow.
2289 (Fx_family_fonts, realize_basic_faces):
2290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2291 (Fx_family_fonts):
2292 Don't assume fixnum fits in int.
2293 Use SAFE_ALLOCA_LISP, not alloca.
2294 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2295 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2296 (face_at_buffer_position, face_for_overlay_string)
2297 (face_at_string_position):
2298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2299 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2300 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2301 (Fx_show_tip):
2302 Check that fixnums are in proper range for system types.
2303 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2304 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2305 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2306 (Fx_change_window_property): Don't assume fixnums fit in int.
2307 * xfont.c (xfont_chars_supported):
2308 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2309 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2310 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2312 * xml.c (parse_region):
2313 * xrdb.c (magic_file_p):
2314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2315 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2316 (x_get_local_selection, x_reply_selection_request)
2317 (x_handle_selection_request, wait_for_property_change):
2318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2319 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2320 short is wide enough.
2321 (x_send_client_event): Don't assume fixnum fits in int.
2322 * xterm.c (x_x_to_emacs_modifiers):
2323 Don't assume EMACS_INT overflows nicely into int.
2324 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2325 may come from Lisp.
2326 (handle_one_xevent): NATNUMP can eval its arg twice.
2327 (x_connection_closed):
2328 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2329 * xterm.h: Adjust decls to match defn changes elsewhere.
2330 (struct scroll_bar): Use struct vectorlike_header
2331 rather than rolling our own approximation.
2332 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2333
c6574eb5
GM
23342012-05-25 Glenn Morris <rgm@gnu.org>
2335
2336 * lisp.mk (lisp): Update for more files being compiled now.
2337
e8d32c7e
SM
23382012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2339
48def666
SM
2340 * lread.c: Remove `read_pure' which makes no difference.
2341 (read_pure): Remove var.
2342 (unreadpure): Remove function.
2343 (readevalloop): Don't call read_list with -1 flag.
2344 (read1, read_vector): Don't test read_pure any more.
2345 (read_list): Simplify.
2346
e8d32c7e
SM
2347 * fileio.c, character.h: Minor style tweaks.
2348
4b2addb7
DA
23492012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2350
2351 * window.h (clip_changed): Remove useless declaration.
2352
584461b2
JB
23532012-05-22 Juanma Barranquero <lekktu@gmail.com>
2354
2355 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2356 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2357
34374650
PE
23582012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2359
2360 Remove src/m/*.
2361 This directory predates autoconf and is no longer needed nowadays.
2362 Move its few remaining bits of functionality to where they're needed.
2363 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2364 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2365 * m/template.h: Remove.
2366 * Makefile.in (M_FILE): Remove. All uses removed.
2367 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2368 * lisp.h (USE_LSB_TAG):
2369 * mem-limits.h (EXCEEDS_LISP_PTR):
2370 Use VAL_MAX, not VALBITS, in #if.
2371 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2372 (EMACS_UINT): Define unconditionally now.
2373 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2374 (BITS_PER_EMACS_INT): New constants, replacing
2375 what used to be in config.h, but not useful in #if.
2376 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2377 define them any more.
2378 (VAL_MAX): New macro.
2379 (VALMASK): Use it.
2380 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2381 BITS_PER_EMACS_INT, in #if.
2382 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2383 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2384 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2385 * s/ms-w32.h (DATA_START):
2386 Move here from removed file m/intel386.h.
2387 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2388 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2389
261cb4bb
PE
23902012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2391
2392 Assume C89 or later.
2393 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2394 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2395 (xrealloc):
2396 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2397 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2398 * textprop.c, tparam.c (NULL): Remove.
2399 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2400 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2401 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2402 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2403 * xterm.c (input_signal_count): Assume volatile works.
2404
ff23cd9f
KB
24052012-05-21 Ken Brown <kbrown@cornell.edu>
2406
2407 * xgselect.c (xg_select): Fix first argument in call to 'select'
2408 (bug#11508).
2409
1b170bc6
KB
24102012-05-20 Ken Brown <kbrown@cornell.edu>
2411
2412 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2413 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2414
b2f4d39f
KB
24152012-05-19 Ken Brown <kbrown@cornell.edu>
2416
2417 * xfns.c (x_in_use): Remove `static' qualifier.
2418 * xterm.h (x_in_use): Declare.
2419 * xgselect.c: Include xterm.h.
2420 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2421 and `display_arg' (bug#9754).
2422
003fdae2
PE
24232012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2424
9232a6d9
PE
2425 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2426
003fdae2
PE
2427 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2428 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2429
784b56e2
EZ
24302012-05-18 Eli Zaretskii <eliz@gnu.org>
2431
2432 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2433
2434 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2435 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2436
2437 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2438 reference to image_cache->refcount.
2439 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2440
a0a79cde
JL
24412012-05-17 Juri Linkov <juri@jurta.org>
2442
2443 * search.c (Fword_search_regexp, Fword_search_backward)
2444 (Fword_search_forward, Fword_search_backward_lax)
2445 (Fword_search_forward_lax): Move functions to isearch.el
2446 (bug#10145, bug#11381).
2447
b0572523
PE
24482012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2449
2450 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2451
9660f5fc
SM
24522012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2453
2454 * lread.c (init_obarray): Declare Qt and Qnil as special.
2455
4374de83
GM
24562012-05-14 Glenn Morris <rgm@gnu.org>
2457
2458 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2459 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2460
dc44c39a
PE
24612012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2462
078c97cb
PE
2463 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2464
dc44c39a
PE
2465 * unexaix.c: Port to more-recent AIX compilers.
2466 (report_error, report_error_1, make_hdr, copy_sym)
2467 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2468 Make arguments const char *, not char *, to avoid violations of C
2469 standard and to fix some AIX warnings reported by Gilles Pion.
2470
e18afed7 24712012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2472
2473 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2474 already have overlays loaded.
2475 (handle_single_display_spec): Before returning without displaying
2476 fringe bitmap, synchronize the bidi iterator with the main display
2477 iterator, by calling iterate_out_of_display_property.
2478 (iterate_out_of_display_property): Detect buffer iteration by
2479 testing that it->string is a Lisp string.
2480 (get_next_display_element): When the current object is exhausted,
2481 and there's something on it->stack, call set_iterator_to_next to
2482 proceed with what's on the stack, instead of returning zero.
2483 (set_iterator_to_next): If called at the end of a Lisp string,
2484 proceed to consider_string_end without incrementing string
2485 position. Don't increment display vector index past the end of
2486 the display vector. (Bug#11417)
c8fb9dc6
EZ
2487 (pos_visible_p): Don't report a position visible when move_it_to
2488 stopped at the last line of window, which happens to be scanned
2489 backwards by the bidi iteration. (Bug#11464)
ac268e67 2490
e18afed7 24912012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2492
2493 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2494 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2495 are on a TTY, and thus unable to display on the fringes.
2496 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2497 so we need to signal to the caller that this is a "replacing"
2498 display spec. This fixes display when the spec is invalid or we
2499 are on a TTY.
2500
e18afed7 25012012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2502
2503 * unexaix.c (make_hdr): Fix typo in prototype.
2504 This bug broke the build on AIX. Problem reported by Gilles Pion.
2505
9d0a235a
MA
25062012-05-14 Michael Albinus <michael.albinus@gmx.de>
2507
2508 * keyboard.c (kbd_buffer_get_event): Read special events also in
2509 batch mode. (Bug#11415)
2510
9e6b06ed
GM
25112012-05-12 Glenn Morris <rgm@gnu.org>
2512
2513 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2514
c1a1d7a3
EZ
25152012-05-12 Eli Zaretskii <eliz@gnu.org>
2516
2517 * lisp.mk (lisp): Add newcomment.elc.
2518
3fe7cdc8
GM
25192012-05-12 Glenn Morris <rgm@gnu.org>
2520
2521 * Makefile.in (MKDIR_P): New, set by configure.
2522 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2523
53f7d2c0
PE
25242012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2525
2526 Remove unused function hourglass_started.
2527 * dispextern.h (hourglass_started):
2528 * w32fns.c (hourglass_started):
2529 * xdisp.c (hourglass_started): Remove.
2530
75aafb17
JB
25312012-05-10 Juanma Barranquero <lekktu@gmail.com>
2532
2533 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2534 Update dependencies.
2535
12959e8e
PE
25362012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2537
97107e2e
PE
2538 * xgselect.c (xg_select): Put maxfds+1 into a var.
2539 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2540
12959e8e
PE
2541 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2542
836d29b3
DA
25432012-05-10 Dave Abrahams <dave@boostpro.com>
2544
2545 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2546 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2547
5cb67954
MA
25482012-05-09 Michael Albinus <michael.albinus@gmx.de>
2549
2550 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2551 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2552 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2553 Initialize xd_registered_buses.
2554
3478ec45
PE
25552012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2556
b263a6b0
PE
2557 Untag more efficiently if USE_LSB_TAG.
2558 This is based on a proposal by YAMAMOTO Mitsuharu in
2559 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2560 For an admittedly artificial (nth 8000 longlist) benchmark on
2561 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2562 Emacs's overall text size by 1%.
2563 * lisp.h (XUNTAG): New macro.
2564 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2565 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2566 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2567 * eval.c (Fautoload):
2568 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2569 * frame.h (XFRAME): Use XUNTAG.
2570
3478ec45
PE
2571 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2572 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2573 Remove unportable assumptions about print widths of types like
2574 dbus_uint32_t.
2575 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2576 intptr_t when converting between pointer and integer, to avoid GCC
2577 warnings about wrong width.
2578
666b903b 25792012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2580
2581 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2582 stack for each reader_thread, instead of defaulting to 8MB
2583 determined by the linker. This avoids failures in creating
2584 subprocesses on Windows 7, see the discussion in this thread:
2585 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2586
b120cc17
JC
25872012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2588
2589 Fix up display of the *Minibuf-0* buffer in the mini window.
2590 * keyboard.c (read_char): Don't clear the echo area if there's no
2591 message to clear.
2592 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2593 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2594
9a4b36f8
MA
25952012-05-07 Michael Albinus <michael.albinus@gmx.de>
2596
2597 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2598 batch mode.
2599
e5f9458f
CY
26002012-05-06 Chong Yidong <cyd@gnu.org>
2601
2602 * lisp.mk (lisp): Update.
2603
eceeb5fc 26042012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2605
2606 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2607
71873e2b
SM
26082012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2609
2610 * data.c (PUT_ERROR): New macro.
2611 (syms_of_data): Use it. Add new error type `user-error'.
2612 * undo.c (user_error): New function.
2613 (Fprimitive_undo): Use it.
2614 * print.c (print_error_message): Adjust print style for `user-error'.
2615 * keyboard.c (user_error): New function.
2616 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2617
ab0fa4e4
PE
26182012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2619
2620 Do not limit current-time-string to years 1000..9999.
2621 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2622 (Fcurrent_time_string): Support any year that is supported by the
2623 underlying localtime representation. Don't use asctime, as it
2624 has undefined behavior for years outside the range -999..9999.
2625
7ed806a7
PE
26262012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2627
2628 Fix race conditions involving setenv, gmtime, localtime, asctime.
2629 Without this fix, interrupts could mess up code that uses these
2630 nonreentrant functions, since setting TZ invalidates existing
2631 tm_zone or tzname values, and since most of these functions return
2632 pointers to static storage.
2633 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2634 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2635 Grow the critical sections to include not just invoking
2636 localtime/gmtime, but also accessing these functions' results
2637 including their tm_zone values if any, and any related TZ setting.
2638 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2639 so that the struct tm is saved in the critical section.
2640 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2641 motivated by the fact that memory allocation needs to be outside
2642 the critical section.
2643
0c16dfed
DA
26442012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2645
2646 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2647 with RESET_INTERVAL.
2648
2649 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2650 Remove duplicated buffer name initialization.
2651
3f83ace8
JM
26522012-05-02 Jim Meyering <jim@meyering.net>
2653
2654 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2655
c7b8541e
JM
2656 * xfns.c (x_window): Use xstrdup (Bug#11375).
2657
90207a15 26582012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2659
2660 * xdisp.c (pos_visible_p): If already at a newline from the
2661 display string before the 'while' loop, don't walk back the glyphs
2662 from it3.glyph_row. Solves assertion violation when the display
2663 string begins with a newline (egg.el). (Bug#11367)
2664
b593d6a9
AH
26652012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2666
2667 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2668 Move to simple.el.
2669
4737362e
GM
26702012-05-01 Glenn Morris <rgm@gnu.org>
2671
99cf43f9
GM
2672 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2673 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2674 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2675 All were removed before 23.1.
2676
9311dcff
GM
2677 * dispnew.c: Remove HAVE_LIBNCURSES test;
2678 it is always true on relevant platforms.
2679
4d5c6349
GM
2680 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2681 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2682
4737362e
GM
2683 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2684
74dd3a6b
AS
26852012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2686
2687 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2688 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2689 Remove.
2690
13c379ee
PE
26912012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2692
2693 Do not avoid creating empty evaporating overlays (Bug#9642).
2694 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2695 That is, do not delete an evaporating overlay if it becomes
2696 empty after its bounds are adjusted to fit within its buffer.
2697 This fix caused other problems, and I'm reverting it until we get
2698 to the bottom of them.
2699
a8e7d6d7 27002012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2701
2702 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2703
a8e7d6d7 27042012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2705
2706 * xdisp.c (pos_visible_p): If the window start position is beyond
2707 ZV, start the display from buffer beginning. Prevents assertion
2708 violation in init_iterator when the minibuffer window is scrolled
2709 via the scroll bar.
2710
2711 * window.c (window_scroll_pixel_based): Likewise.
2712
a8e7d6d7 27132012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2714
2715 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2716
a8e7d6d7 27172012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2718
2719 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2720 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2721
a8e7d6d7 27222012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2723
b593d6a9
AH
2724 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2725 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2726
1c6900d9
EZ
27272012-04-26 Eli Zaretskii <eliz@gnu.org>
2728
4c3fa1d9
EZ
2729 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2730 display element, check also the underlying string or buffer
2731 character. (Bug#11341)
2732
1c6900d9
EZ
2733 * w32menu.c: Include w32heap.h.
2734 (add_menu_item): If the call to AppendMenuW (via
2735 unicode_append_menu) fails, disable Unicode menus only if we are
2736 running on Windows 9X/Me.
2737
42bf8205
AS
27382012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2739
2740 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2741 (xgetint): Add missing shift for LSB tags.
2742
b1bac16e
MR
27432012-04-24 Martin Rudalics <rudalics@gmx.at>
2744
2745 * keyboard.c (read_char): Don't wipe echo area for select window
2746 events: These might get delayed via `mouse-autoselect-window'
2747 (Bug#11304).
2748
d69621cc
JB
27492012-04-24 Juanma Barranquero <lekktu@gmail.com>
2750
2751 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2752 manipulation of :loaded-from data.
2753
02fd101b
JB
27542012-04-23 Juanma Barranquero <lekktu@gmail.com>
2755
2756 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2757 now a cons (bug#11311).
2758
888bec30
PE
27592012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2760
89a438bd
PE
2761 Do not create empty overlays with the evaporate property (Bug#9642).
2762 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2763 if it becomes empty after its bounds are adjusted to fit within
2764 its buffer. Without this fix, in a nonempty buffer (let ((o
2765 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2766 yields an empty overlay that has the evaporate property, which is
2767 not supposed to happen.
2768
1068fe4d
PE
2769 Fix minor GTK3 problems found by static checking.
2770 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2771 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2772 (struct _EmacsFixedClass, emacs_fixed_get_type):
2773 Move decls here from emacsgtkfixed.h, since they needn't be public.
2774 (emacs_fixed_get_type): Now static.
2775 (emacs_fixed_class_init): Omit unused local.
2776 (emacs_fixed_child_type): Remove; unused.
2777 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2778 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2779 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2780 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2781 (EMACS_FIXED_GET_CLASS): Remove; unused.
2782 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2783
888bec30
PE
2784 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2785 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2786
de85e130
PE
27872012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2788
d0baac98 2789 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2790 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2791 (__malloc_size_t, __malloc_ptrdiff_t):
2792 Remove. All uses removed, replaced by the definiens if needed,
2793 since we can assume C89 or better now.
2794 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2795 (protect_malloc_state, align, get_contiguous_space)
2796 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2797 (malloc_atfork_handler_child, malloc_enable_thread)
2798 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2799 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2800 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2801 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2802 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2803 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2804 Define using prototypes, not old style.
2805 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2806 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2807 (align): Don't assume that signed integer overflow wraps around.
2808 Omit unused local var.
2809 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2810 (_free_internal_nolock, memalign, mallochook, reallochook):
2811 Omit no-longer-needed casts.
2812 (valloc): Use getpagesize, not __getpagesize.
2813 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2814 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2815
de85e130
PE
2816 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2817
dcbf5805
MA
28182012-04-22 Michael Albinus <michael.albinus@gmx.de>
2819
2820 Move functions from C to Lisp. Make non-blocking method calls
2821 the default. Implement further D-Bus standard interfaces.
2822
2823 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2824 (QCdbus_request_name_allow_replacement)
2825 (QCdbus_request_name_replace_existing)
2826 (QCdbus_request_name_do_not_queue)
2827 (QCdbus_request_name_reply_primary_owner)
2828 (QCdbus_request_name_reply_in_queue)
2829 (QCdbus_request_name_reply_exists)
2830 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2831 (QCdbus_registered_serial, QCdbus_registered_method)
2832 (QCdbus_registered_signal): New Lisp objects.
2833 (XD_DEBUG_MESSAGE): Use sizeof.
2834 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2835 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2836 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2837 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2838 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2839 (xd_signature, xd_append_arg): Allow float for integer types.
2840 (xd_get_connection_references): New function.
b593d6a9
AH
2841 (xd_get_connection_address): Rename from xd_initialize.
2842 Return cached address.
dcbf5805
MA
2843 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2844 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2845 level.
2846 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2847 Return number of refcounts.
dcbf5805
MA
2848 (Fdbus_get_unique_name): Make stronger parameter check.
2849 (Fdbus_message_internal): New defun.
2850 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2851 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2852 (Fdbus_send_signal, Fdbus_register_service)
2853 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2854 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2855 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2856 (Vdbus_compiled_version, Vdbus_runtime_version)
2857 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2858 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2859 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2860 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2861 Adapt docstring.
dcbf5805 2862
52828e02
PE
28632012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2864
da05bc4c
PE
2865 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2866 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2867 Do not assume ptrdiff_t is the same width as 'int'.
2868
52828e02
PE
2869 * alloc.c: Handle unusual debugging option combinations.
2870 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2871 since the two debugging options are incompatible.
2872 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2873 is defined.
2874 (mem_init, mem_insert, mem_insert_fixup):
2875 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2876 (NEED_MEM_INSERT): Remove; no longer needed.
2877
f01769f9
LL
28782012-04-22 Leo Liu <sdl.web@gmail.com>
2879
2880 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2881
5790543d
PE
28822012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2883
2884 * sysdep.c [__FreeBSD__]: Minor cleanups.
2885 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2886 Use Emacs indenting style more consistently. Avoid some casts.
2887 Use 'double' consistently rather than mixing 'float' and 'double'.
2888
b91b7e4d
EW
28892012-04-21 Eduard Wiebe <usenet@pusto.de>
2890
b593d6a9
AH
2891 * sysdep.c (list_system_processes, system_process_attributes):
2892 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2893
6114eb15
AS
28942012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2895
2896 * lisp.mk (lisp): Update.
2897
2f38dff7
PE
28982012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2899
2900 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2901 It is never used otherwise.
2902
4ae29f89
SM
29032012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2904
2905 * print.c (print_preprocess): Only check print_depth if print-circle
2906 is nil.
2907 (print_object): Check for cycles even when print-circle is nil and
2908 print-gensym is t, but only check print_depth if print-circle is nil.
2909
f30d612a
CY
29102012-04-20 Chong Yidong <cyd@gnu.org>
2911
2912 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2913 set the status to "failed" and ensure that sentinel is run.
2914
c07a4c0b 29152012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2916
2917 * process.c (Fset_process_inherit_coding_system_flag)
2918 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2919 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2920
c07a4c0b 29212012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2922
2923 * xdisp.c (string_buffer_position_lim): Limit starting position to
2924 BEGV.
2925 (set_cursor_from_row): If called for a mode-line or header-line
2926 row, return zero immediately.
2927 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2928 farther than the first row after the header line, if any.
2929 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2930 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2931
c07a4c0b 29322012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2933
4ae29f89
SM
2934 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2935 (bug#11238).
ad3a2b41 2936
c07a4c0b 29372012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 29382012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2939
2940 configure: new option --enable-gcc-warnings (Bug#11207)
2941 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2942 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2943 (ALL_CFLAGS): Use new macros rather than old.
2944 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2945 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2946 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2947 -Wunused-result, -Wunused-variable. This should go away once
2948 the Emacs and Gnulib regex code is merged.
2949 (xmalloc, xrealloc): Now static.
2950
aba027e8
PE
29512012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2952
2953 * dired.c (Fsystem_groups): Remove unused local.
2954
e5a36063
GM
29552012-04-17 Glenn Morris <rgm@gnu.org>
2956
2957 * dired.c (Fsystem_users): Doc fix.
2958
316411f0
DA
29592012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2960
2961 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2962 (syms_of_dired): Add them.
2963
9426aba4
PE
29642012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2965
b62a57be
PE
2966 Fix minor alloc.c problems found by static checking.
2967 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2968 New extern decls, to avoid calling undeclared functions.
2969 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2970 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2971 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2972 (NEED_MEM_INSERT): New macro.
2973 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2974 Remove one incorrect comment and fix another.
b62a57be 2975
3539f31f
PE
2976 Fix minor ralloc.c problems found by static checking.
2977 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2978 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2979 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2980 (r_alloc_sbrk): Now static.
2981
a041960a
PE
2982 Improve ralloc.c interface checking.
2983 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2984 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2985 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2986 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2987 [REL_ALLOC]: ... to here, to check interface.
2988 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2989 Remove decls. This fixes an "It stinks!".
2990
9426aba4
PE
2991 * alloc.c (which_symbols): Fix alignment issue / type clash.
2992
d55c12ed
AS
29932012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2994
2995 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2996 (struct Lisp_Misc_Any): Likewise.
2997 (struct Lisp_Free): Likewise.
2998 * alloc.c (union aligned_Lisp_Symbol): Define.
2999 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3000 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3001 (union aligned_Lisp_Misc): Define.
3002 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3003 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3004 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3005
b948ce8b
PE
30062012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3007
3008 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3009 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3010 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3011 * s/netbsd.h, s/sol2-6.h:
3012 Remove definition of GC_MARK_STACK, since the default now works.
3013 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3014 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3015 no longer the default.
3016 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3017
35dc09a1 30182012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3019
35dc09a1
GM
3020 * lread.c (lisp_file_lexically_bound_p):
3021 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3022
35dc09a1
GM
30232012-04-14 Eli Zaretskii <eliz@gnu.org>
3024
3025 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3026 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3027
30282012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3029
3030 * nsterm.m (constrainFrameRect): Always constrain when there is only
3031 one screen (Bug#10962).
3032
bcd86815
KB
30332012-04-13 Ken Brown <kbrown@cornell.edu>
3034
3035 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3036
c25df26e
RT
30372012-04-13 Reuben Thomas <rrt@sc3d.org>
3038
3039 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3040
0fc59f1e
DC
30412012-04-11 Daniel Colascione <dancol@dancol.org>
3042
3043 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3044 against is gone. It's better to use vfork now so that when Cygwin
3045 gains a new, working vfork, we use it automatically (bug#10398).
3046
de8c03dc
SM
30472012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3048
3049 * window.c (save_window_save): Obey window-point-insertion-type.
3050
2f097256
GM
30512012-04-11 Glenn Morris <rgm@gnu.org>
3052
3053 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3054
453b951e
SM
30552012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3056
3057 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3058
75f1671a 30592012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3060
3061 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3062 (force_quit_count): New var.
3063 (handle_interrupt): Use it.
3064
2a8ce227
JB
30652012-04-10 Juanma Barranquero <lekktu@gmail.com>
3066
3067 * w32.c (w32_delayed_load): Record the full path of the library
3068 being loaded (bug#10424).
3069
935396c0
GM
30702012-04-09 Glenn Morris <rgm@gnu.org>
3071
05920a43
GM
3072 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3073 not just in the obarray, before snarfing them. (Bug#11036)
3074
935396c0
GM
3075 * Makefile.in ($(leimdir)/leim-list.el):
3076 Pass EMACS rather than BUILT_EMACS.
3077
a18ecafa
TZ
30782012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3079
3080 * process.c (make_process):
3081 * process.h: Add integer `gnutls_handshakes_tried' member to
3082 process struct.
3083
6bbef4e5
JC
3084 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3085 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3086
3087 * gnutls.c (gnutls_log_function2i): Convenience log function.
3088 (emacs_gnutls_read): Use new log functions,
3089 `gnutls_handshakes_tried' process member, and
3090 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3091 attempts per process (connection).
3092
b4d3bc10
CY
30932012-04-09 Chong Yidong <cyd@gnu.org>
3094
3095 * eval.c (Fuser_variable_p, user_variable_p_eh)
3096 (lisp_indirect_variable): Functions deleted.
3097 (Fdefvar): Caller changed.
3098
3099 * callint.c (Finteractive, Fcall_interactively):
3100 * minibuf.c (Fread_variable): Callers changed.
3101
70f4d973
EZ
31022012-04-09 Eli Zaretskii <eliz@gnu.org>
3103
3104 * xdisp.c (set_cursor_from_row): If the display string appears in
3105 the buffer at position that is closer to point than the position
3106 after the display string, display the cursor on the first glyph of
3107 the display string. Fixes cursor display when a 'display' text
3108 property immediately follows invisible text. (Bug#11094)
3109
cb3c2e3e
PE
31102012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3111
3112 composite.c: use 'double' consistently
3113 * composite.c (get_composition_id): Use 'double' consistently
3114 instead of converting 'float' to 'double' and vice versa; this is
3115 easier to understand and avoids a GCC warning.
3116
fd06db5d
GM
31172012-04-09 Glenn Morris <rgm@gnu.org>
3118
50fe702a
GM
3119 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3120 preparation for dumping it with emacs. (Bug#4789)
3121 (leimdir): New variable.
3122 ($(leimdir)/leim-list.el): New rule.
3123 (emacs$(EXEEXT)): Depend on leim-list.el.
3124
fd06db5d
GM
3125 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3126 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3127 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3128
55c131ee
AS
31292012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3130
3131 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3132 proper alignment.
3133
9209588f
JB
31342012-04-07 Juanma Barranquero <lekktu@gmail.com>
3135
3136 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3137 Remove unused local variable.
3138
e3fb2efb
PE
31392012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3140
3141 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3142 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3143 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3144 objects, as mark_maybe_pointer will catch them otherwise.
3145 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3146 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3147
b5385551
PE
31482012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3149
3150 Fix typo that broke non-Windows builds.
3151 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3152
9078ead6
EZ
31532012-04-07 Eli Zaretskii <eliz@gnu.org>
3154
3155 Support building on MS-Windows with libxml2.
3156
3157 * makefile.w32-in (OBJ2): Add xml.$(O).
3158 (GLOBAL_SOURCES): Add xml.c.
3159 ($(BLD)/xml.$(O)): New dependency list.
3160
3161 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3162 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3163 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3164 [!WINDOWSNT]: New macros.
3165 (init_libxml2_functions, libxml2_loaded_p): New functions.
3166 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3167 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3168 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3169 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3170 linked in).
6bbef4e5
JC
3171 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3172 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3173 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3174
3175 * emacs.c: Don't include libxml/parser.h.
3176 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3177 xmlCleanupParser directly.
3178
3179 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3180
3811fdf3
EZ
31812012-04-07 Eli Zaretskii <eliz@gnu.org>
3182
3183 * indent.c (Fvertical_motion): If there is a display string at
3184 point, use it.vpos to compute how many lines to backtrack after
3185 move_it_to point. (Bug#11133)
3186
2f8e16b2
EZ
31872012-04-06 Eli Zaretskii <eliz@gnu.org>
3188
3189 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3190 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3191 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3192 macros related to unification of CJK characters. For the details,
3193 see the discussion following the message here:
3194 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3195
3d439cd1
CY
31962012-04-04 Chong Yidong <cyd@gnu.org>
3197
3198 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3199
8bc53d00
EZ
32002012-04-01 Eli Zaretskii <eliz@gnu.org>
3201
3202 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3203 instead of alloca. (Bug#11138)
3204
3b0512a3
AS
32052012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3206
3207 * w32menu.c (is_simple_dialog): Properly check lisp types.
3208 (Bug#11141)
3209
8427ddd2
EZ
32102012-03-31 Eli Zaretskii <eliz@gnu.org>
3211
979022ef
EZ
3212 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3213 position we get to after a call to move_it_to fails the
3214 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3215 only if we wind up in a string from display property. (Bug#11063)
3216
a6b1c7cc
EZ
3217 * window.c (Fdelete_other_windows_internal): Invalidate the row
3218 and column information about mouse highlight, so that redisplay
3219 restores it after reallocating the glyph matrices. (Bug#7464)
3220
8427ddd2
EZ
3221 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3222 string comes from a `display' text property, use the buffer
3223 position of that property as if we actually saw that position in
3224 the row's glyphs.
697ba24b
EZ
3225 (move_it_by_lines): Remove the assertion that
3226 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3227 violated when there's a before-string at the beginning of a line.
3228 (Bug#11063)
8427ddd2 3229
65a0a738
EZ
32302012-03-30 Eli Zaretskii <eliz@gnu.org>
3231
3232 * xdisp.c (append_space_for_newline): If the default face was
3233 remapped, use the remapped face for the appended newline.
3234 (extend_face_to_end_of_line): Use the remapped default face for
3235 extending the face to the end of the line.
3236 (display_line): Call extend_face_to_end_of_line when the default
3237 face was remapped. (Bug#11068)
3238
581355cc
EZ
32392012-03-29 Eli Zaretskii <eliz@gnu.org>
3240
3241 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3242
e8fc049f
SM
32432012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3244
3245 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3246
4fb9a543
GM
32472012-03-27 Glenn Morris <rgm@gnu.org>
3248
3249 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3250 Doc fixes.
3251
679910f1
KH
32522012-03-26 Kenichi Handa <handa@m17n.org>
3253
3254 * dispextern.h (struct glyph): Fix previous change. Change the
3255 bit length of glyphless.ch to 25 (Bug#11082).
3256
90d49b7f
CY
32572012-03-26 Chong Yidong <cyd@gnu.org>
3258
3259 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3260 (command_loop_1): Use it; inhibit selection update for
3261 handle-select-window too (Bug#8996).
3262
f514f6f0
FP
32632012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3264
e8fc049f 3265 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3266
bf43fa51
KH
32672012-03-25 Kenichi Handa <handa@m17n.org>
3268
3269 * dispextern.h (struct glyph): Change the bit length of
3270 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3271
8a0c01dd
EZ
32722012-03-24 Eli Zaretskii <eliz@gnu.org>
3273
3274 * s/ms-w32.h (tzname): Include time.h before redirecting to
3275 _tzname. Fixes the MSVC build. (Bug#9960)
3276
7d1c3a76
AS
32772012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3278
8ed79523
AS
3279 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3280 characters.
3281
7d1c3a76
AS
3282 * xterm.c (XTread_socket): Only modify handling_signal if
3283 !SYNC_INPUT. (Bug#11080)
3284
e99a9b8b
EZ
32852012-03-23 Eli Zaretskii <eliz@gnu.org>
3286
3287 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3288 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3289 when fetching a multibyte character consumes more bytes than
3290 CHAR_BYTES returns, due to unification of CJK characters in
3291 string_char. (Bug#11073)
3292
5063c0e1
TN
32932012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3294
3295 * process.c (wait_reading_process_output): Handle pty disconnect
3296 by refraining from sending oneself a SIGCHLD (bug#10933).
3297
9f851fbd
CY
32982012-03-22 Chong Yidong <cyd@gnu.org>
3299
3300 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3301
5063c0e1 3302 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3303 Mark string as coming from a prefix property.
3304 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3305 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3306
fb5b8aca
CY
33072012-03-21 Chong Yidong <cyd@gnu.org>
3308
3309 * xfaces.c (Vface_remapping_alist): Doc fix.
3310
62356a1b
EZ
33112012-03-20 Eli Zaretskii <eliz@gnu.org>
3312
3313 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3314 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3315 Doc fixes.
62356a1b 3316
025de85b
CY
33172012-03-20 Chong Yidong <cyd@gnu.org>
3318
3319 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3320 to reflect default non-nil value of redisplay-dont-pause.
3321
4827f94e
KH
33222012-03-19 Kenichi Handa <handa@m17n.org>
3323
3324 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3325 it fit in a valid range (Bug#11003).
3326
e50a24a2
EZ
33272012-03-18 Eli Zaretskii <eliz@gnu.org>
3328
3329 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3330 that is not from display property, accept the row as a "cursor
3331 row" if one of the string's character has a non-nil `cursor'
3332 property. Fixes cursor positioning when there are newlines in
3333 overlay strings, e.g. in icomplete.el. (Bug#11035)
3334
9af5ed87
PE
33352012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3336
3337 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3338
d1f55f16
CY
33392012-03-12 Chong Yidong <cyd@gnu.org>
3340
3341 * eval.c (inhibit_lisp_code): Rename from
3342 inhibit_window_configuration_change_hook; move from window.c.
3343
3344 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3345 * window.c (run_window_configuration_change_hook)
3346 (syms_of_window): Callers changed.
3347
66c5eebd
CY
33482012-03-11 Chong Yidong <cyd@gnu.org>
3349
413df973
CY
3350 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3351
66c5eebd
CY
3352 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3353
1de11f56
CY
33542012-03-10 Chong Yidong <cyd@gnu.org>
3355
3356 * frame.c (other_visible_frames): Don't assume the selected frame
3357 is visible (Bug#10955).
3358
cae07000
SM
33592012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3360
3361 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3362
89c94350
JD
33632012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3364
3365 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3366 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3367 zero (Bug#10954).
3368
999dd333
GM
33692012-03-03 Glenn Morris <rgm@gnu.org>
3370
01a6dcc8 3371 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3372
de0100f2
EZ
33732012-03-02 Eli Zaretskii <eliz@gnu.org>
3374
3375 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3376 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3377 (redisplay_window, next_element_from_string): Fix typos in
3378 comments.
3e441275
EZ
3379 (redisplay_window): Pass to move_it_vertically the margin in
3380 pixels, not in screen lines.
de0100f2 3381
96a72ee9
GM
33822012-03-02 Glenn Morris <rgm@gnu.org>
3383
3384 * buffer.c (buffer-list-update-hook): Doc fix.
3385
312508d7
EZ
33862012-02-29 Eli Zaretskii <eliz@gnu.org>
3387
3388 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3389 push_it before setting up the iterator for the first overlay
3390 string, even if we have an empty string loaded.
3391 (next_overlay_string): If there's an empty string on the iterator
3392 stack, pop the stack. (Bug#10903)
3393
27f3c637
PE
33942012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3395
3396 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3397 Suggested by Stefan Monnier in
3398 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3399 * alloc.c (widen_to_Lisp_Object): New static function.
3400 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3401 and widening them to Lisp_Objects. This would work even if
3402 USE_LSB_TAG is defined and wide integers are used, which might
3403 happen in a future version of Emacs.
3404
3c9dfce6
CY
34052012-02-25 Chong Yidong <cyd@gnu.org>
3406
fa74b241
CY
3407 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3408 Doc fix.
3409
3c9dfce6
CY
3410 * xselect.c (Fx_selection_exists_p): Doc fix.
3411 (x_clipboard_manager_save_all): Print an informative message
3412 before saving to clipboard manager.
3413
9486df08
CY
34142012-02-24 Chong Yidong <cyd@gnu.org>
3415
3416 * keyboard.c (process_special_events): Handle all X selection
3417 requests in kbd_buffer, not just the next one (Bug#8869).
3418
f01d3321
CY
34192012-02-23 Chong Yidong <cyd@gnu.org>
3420
3421 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3422 call when setting menu-bar-lines and tool-bar-lines parameters.
3423 (unwind_create_frame_1): New helper function.
3424
3425 * window.c (inhibit_window_configuration_change_hook): New var.
3426 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3427 (syms_of_window): Initialize it.
f01d3321 3428
86b847b6
CY
34292012-02-22 Chong Yidong <cyd@gnu.org>
3430
3431 * xterm.c (x_draw_image_relief): Add missing type check for
3432 Vtool_bar_button_margin (Bug#10743).
3433
a59225b1
CY
34342012-02-21 Chong Yidong <cyd@gnu.org>
3435
3436 * fileio.c (Vfile_name_handler_alist): Doc fix.
3437
3438 * buffer.c (Fget_file_buffer): Protect against invalid file
3439 handler return value.
3440
310f5bd4
PE
34412012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3442
cb3a28cc
PE
3443 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3444 when computing $valmask.
3445
310f5bd4
PE
3446 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3447 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3448 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3449 It's useless in that case, and it can cause problems on hosts
3450 that allocate halves of EMACS_INT values separately.
3451 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3452 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3453 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3454 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3455 it avoids undefined behavior on hosts where shifting right by more
3456 than the word width has undefined behavior.
3457
2375c96a
CY
34582012-02-19 Chong Yidong <cyd@gnu.org>
3459
3460 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3461 (Funhandled_file_name_directory, Ffile_name_as_directory)
3462 (Fdirectory_file_name, Fexpand_file_name)
3463 (Fsubstitute_in_file_name): Protect against invalid file handler
3464 return values (Bug#10845).
3465
3eb49e71
EZ
34662012-02-18 Eli Zaretskii <eliz@gnu.org>
3467
3468 * .gdbinit (pitx): Fix incorrect references to fields of the
3469 iterator stack.
3470
7b926f3f
CY
34712012-02-17 Chong Yidong <cyd@gnu.org>
3472
3473 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3474
11273115
PE
34752012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3476
3477 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3478 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3479
c3a70e2b
CY
34802012-02-15 Chong Yidong <cyd@gnu.org>
3481
3482 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3483 marked as special. Also, starting docstrings with * is obsolete.
3484
0ca43699
AS
34852012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3486
3487 * gnutls.c (emacs_gnutls_write): Fix last change.
3488
2e8f3c56
LI
34892012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3490
3491 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3492 send_process.
3493
af70074f
SM
34942012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3495
3496 * keymap.c (Fsingle_key_description): Handle char ranges.
3497
95986d52
CY
34982012-02-12 Chong Yidong <cyd@gnu.org>
3499
afd83bd1
CY
3500 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3501 as that creates a dangerous corner case.
3502
95986d52
CY
3503 * window.c (Fdelete_window_internal): Invalidate the mouse
3504 highlight (Bug#9904).
3505
bd7da63e
GM
35062012-02-12 Glenn Morris <rgm@gnu.org>
3507
3508 * xselect.c (Fx_own_selection_internal)
3509 (Fx_get_selection_internal, Fx_disown_selection_internal)
3510 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3511 * nsselect.m (Fx_own_selection_internal)
3512 (Fx_disown_selection_internal, Fx_selection_exists_p)
3513 (Fx_selection_owner_p, Fx_get_selection_internal):
3514 Sync docs and argument specs with the xselect.c versions.
3515
77abcbc2
LI
35162012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3517
3518 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3519
90b671e2
EZ
35202012-02-11 Eli Zaretskii <eliz@gnu.org>
3521
1c0ca0b7
EZ
3522 * w32select.c (Fx_selection_exists_p): Sync doc string and
3523 argument list with xselect.c. (Bug#10783)
3524
3525 * w16select.c (Fx_selection_exists_p): Sync doc string and
3526 argument list with xselect.c. (Bug#10783)
90b671e2 3527
49241268
GM
35282012-02-10 Glenn Morris <rgm@gnu.org>
3529
3530 * fns.c (Fsecure_hash): Doc fix.
3531
f998bbe7 35322012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3533
3534 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3535
0992bd9c
CY
35362012-02-07 Chong Yidong <cyd@gnu.org>
3537
3538 * buffer.c (Fbuffer_local_variables)
3539 (buffer_lisp_local_variables): Handle unbound vars correctly;
3540 don't let Qunbound leak into Lisp.
3541
af008560
GM
35422012-02-07 Glenn Morris <rgm@gnu.org>
3543
dd605cc4
GM
3544 * image.c (Fimagemagick_types): Doc fix.
3545
af008560
GM
3546 * image.c (imagemagick-render-type): Change it from a lisp object
3547 to an integer. Move the doc here from the lisp manual.
3548 Treat all values not equal to 0 the same.
3549
1449fa1d
CY
35502012-02-06 Chong Yidong <cyd@gnu.org>
3551
3552 * doc.c (store_function_docstring): Avoid applying docstring of
3553 alias to base function (Bug#2603).
3554
3723ec07
AS
35552012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3556
3557 * .gdbinit (pp1, pv1): Remove redundant defines.
3558 (pr): Use pp.
3559
79c1cc1e
CY
35602012-02-04 Chong Yidong <cyd@gnu.org>
3561
3562 * nsterm.m: Declare a global (Bug#10694).
3563
d7f29f8e
EZ
35642012-02-04 Eli Zaretskii <eliz@gnu.org>
3565
cae07000
SM
3566 * w32.c (get_emacs_configuration_options):
3567 Include --enable-checking, if specified, in the return value.
d7f29f8e 3568
3b95a6f9
MR
35692012-02-04 Martin Rudalics <rudalics@gmx.at>
3570
3571 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3572 after rounding frame sizes. (Bug#9723)
3573
d6fa96a6
EZ
35742012-02-04 Eli Zaretskii <eliz@gnu.org>
3575
3576 * keyboard.c (adjust_point_for_property): Don't position point
3577 before BEGV. (Bug#10696)
3578
df0b2940
PE
35792012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3580
3581 Handle overflow when computing char display width (Bug#9496).
3582 * character.c (char_width): Return EMACS_INT, not int.
3583 (char_width, c_string_width): Check for overflow when
3584 computing the width; this is possible now that individual
3585 characters can have unbounded width. Problem introduced
3586 by merge from Emacs 23 on 2012-01-19.
3587
6bee44d6
MA
35882012-02-02 Michael Albinus <michael.albinus@gmx.de>
3589
3590 * dbusbind.c (Fdbus_register_method): Mention the return value
3591 :ignore in the docstring.
3592
44f92739
GM
35932012-02-02 Glenn Morris <rgm@gnu.org>
3594
1b9f60cc
GM
3595 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3596
44f92739
GM
3597 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3598 Unconditionally set to t. (Bug#10673)
3599 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3600 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3601 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3602
c5d3843c
KH
36032012-02-02 Kenichi Handa <handa@m17n.org>
3604
3605 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3606 0, do not call append_composite_glyph.
3607
159462d4 36082012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3609
3610 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3611 NULL (Bug#6988).
3612 (x_produce_glyphs): If the component of a composition is a null
3613 string, set it->pixel_width to 1 to avoid zero-width glyph.
3614
78cef877
EZ
36152012-02-01 Eli Zaretskii <eliz@gnu.org>
3616
3617 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3618 first 2 arguments are identical. This makes inserting large
3619 output from a subprocess an order of magnitude faster on
3620 MS-Windows, where all sbrk'ed memory is always contiguous.
3621
97897668
GM
36222012-01-31 Glenn Morris <rgm@gnu.org>
3623
3624 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3625 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3626 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3627
31fd3586
GM
36282012-01-29 Glenn Morris <rgm@gnu.org>
3629
3630 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3631
0e24a8b2
CY
36322012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3633
3634 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3635
cc0adcb0
CY
36362012-01-28 Chong Yidong <cyd@gnu.org>
3637
3638 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3639
acc28cb9
CY
36402012-01-26 Chong Yidong <cyd@gnu.org>
3641
9c69cfb7
CY
3642 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3643
acc28cb9
CY
3644 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3645 repeat counts (Bug#10507).
3646
48da7392
GM
36472012-01-26 Glenn Morris <rgm@gnu.org>
3648
3649 * lread.c (syms_of_lread): Doc fix.
3650
14af5f7f
CY
36512012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3652
3653 * coding.c (encode_designation_at_bol): Change return value to
3654 EMACS_INT.
3655
0b21c100
CY
36562012-01-25 Chong Yidong <cyd@gnu.org>
3657
3658 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3659
3c2907f7
CY
36602012-01-21 Chong Yidong <cyd@gnu.org>
3661
3662 * floatfns.c (Fcopysign): Make the second argument non-optional,
3663 since nil is not allowed anyway.
3664
959ad23f
AS
36652012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3666
3667 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3668 (send_process): Likewise.
3669
34a02f46
MR
36702012-01-19 Martin Rudalics <rudalics@gmx.at>
3671
3672 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3673 (Vwindow_persistent_parameters): Do not use Qstate.
3674 Rewrite doc-strings.
34a02f46 3675
1259009a 36762012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3677
3678 * character.c (char_width): New function.
70d4fdf6
GM
3679 (Fchar_width, c_string_width, lisp_string_width):
3680 Use char_width (Bug#9496).
25ed9e61 3681
6a6ee00d
MR
36822012-01-16 Martin Rudalics <rudalics@gmx.at>
3683
3684 * window.c (Vwindow_persistent_parameters): New variable.
3685 (Fset_window_configuration, save_window_save): Handle persistent
3686 window parameters.
3687
c85efaf7
EZ
36882012-01-14 Eli Zaretskii <eliz@gnu.org>
3689
3690 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3691 thrashing the stack of the thread. (Bug#9087)
3692
5944709e
PE
36932012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3694
3695 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3696
e71f5d99
EZ
36972012-01-11 Eli Zaretskii <eliz@gnu.org>
3698
3699 * xdisp.c (rows_from_pos_range): Handle the case where the
3700 highlight ends on a newline. (Bug#10464)
3701 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3702 he end column for display of highlight that ends on a newline
3703 before a R2L line.
3704
ce316182
GM
37052012-01-11 Glenn Morris <rgm@gnu.org>
3706
3707 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3708 from load-path also when installation-directory is nil. (Bug#10208)
3709
5b43da69
GM
37102012-01-10 Glenn Morris <rgm@gnu.org>
3711
74cc8ff9
GM
3712 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3713
7d8d6e4e
GM
3714 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3715 Update template values to be closer to their typical values these days.
5b43da69 3716
a0db8d43
EZ
37172012-01-09 Eli Zaretskii <eliz@gnu.org>
3718
3719 * xdisp.c (rows_from_pos_range): Accept additional argument
3720 DISP_STRING, and accept any glyph in a row whose object is that
3721 string as eligible for mouse highlight. Fixes mouse highlight of
3722 display strings from overlays. (Bug#10464)
3723
9a0115ab 37242012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3725
b9110d6a 3726 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3727 * fileio.c (auto_saving_dir_umask): New static var.
3728 (Fmake_directory_internal): Use it.
3729 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3730 creating the directory. The old code temporarily assigns
3731 too-generous permissions to the directory.
3732 (do_auto_save_eh): Clear it.
b9110d6a 3733 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3734 that the var is always cleared.
3735
6c1bd3f3
EZ
37362012-01-07 Eli Zaretskii <eliz@gnu.org>
3737
3738 * search.c (scan_buffer): Pass character positions to
3739 know_region_cache, not byte positions. (Bug#6540)
3740
069d2b50
L
37412012-01-07 LynX <_LynX@bk.ru> (tiny change)
3742
3743 * w32.c (sys_rename): Report EXDEV when rename of a directory
3744 fails because the target is on another logical disk. (Bug#10284)
3745
75bf0d33
DB
37462012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3747
3748 * xterm.c (x_embed_request_focus): New function.
3749
3750 * xterm.h: Add prototype.
3751
3752 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3753
1c6e5a32
GM
37542012-01-05 Glenn Morris <rgm@gnu.org>
3755
3756 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3757
651e947e
EZ
37582012-01-01 Eli Zaretskii <eliz@gnu.org>
3759
3760 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3761 Load gnutls_transport_set_lowat only if GnuTLS version is below
3762 2.11.1.
3763 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3764 GnuTLS versions below 2.11.1.
3765
3778cdd8
AL
37662011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3767
3768 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3769 to the doc string advising against its use for altering the way
3770 windows are scrolled.
3771
0e5317f7
KH
37722011-12-28 Kenichi Handa <handa@m17n.org>
3773
3774 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3775 coding-system ASCII compatible only when it does not produce BOM
3776 on encoding (Bug#10383).
3777
93d5ca1f
JD
37782011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3779
3780 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3781 can scroll.
3782 (create_and_show_popup_menu): Always use menu_position_func for
3783 Gtk3 (Bug#10361).
3784
ca22b785
AS
37852011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3786
3787 * callint.c (Fcall_interactively): Don't truncate prompt string.
3788
d048e1e6
EZ
37892011-12-23 Eli Zaretskii <eliz@gnu.org>
3790
3791 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3792 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3793 resumed from there (after widening). (Bug#10360)
d048e1e6 3794
5ccaba1f
JD
37952011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3796
3797 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3798
204ee57f
JD
37992011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3800
b81d40f0
JB
3801 * nsterm.m (x_free_frame_resources):
3802 Release f->output_data.ns->miniimage.
204ee57f
JD
3803 (ns_index_color): Fix indentation. Do not retain
3804 color_table->colors[i].
3805
3806 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3807 before returning.
3808
3809 * nsfns.m (x_set_background_color): Assign return value from
3810 ns_index_color to face-background instead of NSColor*.
3811 (ns_implicitly_set_icon_type): Fix indentation.
3812 Change assignment in for loop to comparison.
3813
3814 * emacs.c (ns_pool): New variable.
3815 (main): Assign ns_pool.
3816 (Fkill_emacs): Call ns_release_autorelease_pool.
3817
3818 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3819 autorelease fdesc, release fdAttrs and tdict.
3820 (ns_get_covering_families): Release charset.
3821 (ns_findfonts): Release NSFontDescriptor created with new.
3822 (ns_uni_to_glyphs): Fix indentation.
3823 (setString): Release attrStr before assigning new value.
3824
c803b2b7
JD
38252011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3826
678f4426
JD
3827 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3828 and NS_IMPL_COCOA.
3829 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3830 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3831
cd394be1 38322011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3833
5fecd5fc
JD
3834 * nsterm.m (ns_term_init): Subscribe for notifications
3835 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3836 to method trackingNotification in EmacsMenu.
3837
3838 * nsmenu.m (trackingMenu): New variable.
3771cb17 3839 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3840 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3841 from Aquamacs (Bug#7030).
678f4426
JD
3842
38432011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3844
c803b2b7
JD
3845 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3846 (symbol_to_nsstring): Fix indentation.
3847 (ns_symbol_to_pb): New function.
cae07000
SM
3848 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3849 (Fns_rotate_cut_buffers_internal): Remove.
3850 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3851 Fns_store_cut_buffer_internal.
3852 (ns_get_foreign_selection, Fx_own_selection_internal)
3853 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3854 (Fns_get_selection_internal, Fns_store_selection_internal):
3855 Use ns_symbol_to_pb and check if return value is nil.
3856 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3857 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3858 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3859 renamed to Sns_store_selection_internal.
3860 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3861 and remove this function.
3862 (ns_handle_selection_clear): Remove, never used.
3863 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3864 here.
3865
e1b01a3a
KB
38662011-12-17 Ken Brown <kbrown@cornell.edu>
3867
3868 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3869 GID is unknown (Bug#10257).
3870
2adb6e85
PE
38712011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3872
3873 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3874 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3875 which caused a build failure on GNU/Linux IA-64. This problem was
3876 introduced by my 2011-10-07 patch.
3877
d1d7b339
JL
38782011-12-15 Juri Linkov <juri@jurta.org>
3879
3880 * image.c (imagemagick_error): New function. (Bug#10112)
3881 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3882 Use `imagemagick_error' where ImageMagick functions return
3883 `MagickFalse'.
3884 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3885 proper order.
3886
100d5755
KH
38872011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3888
3889 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3890 fill background (Bug#8992).
3891
454592a6
MR
38922011-12-13 Martin Rudalics <rudalics@gmx.at>
3893
3894 * window.c (Vwindow_combination_resize)
3895 (Vwindow_combination_limit): Use t instead of non-nil in
3896 doc-strings.
61d4b438
MR
3897 (Vrecenter_redisplay): Add first sentence of doc-string on
3898 separate line.
53524d93 3899 (Frecenter): Fix doc-string typo.
454592a6 3900
3633e3aa
KH
39012011-12-11 Kenichi Handa <handa@m17n.org>
3902
3903 * coding.c (Funencodable_char_position): Pay attention to the
3904 buffer text relocation (Bug#9389).
3905
7b9d523a 39062011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3907
7b9d523a
JD
3908 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3909 gtk_init (Bug#10100).
3910
b73189c6
EZ
39112011-12-10 Eli Zaretskii <eliz@gnu.org>
3912
3913 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3914 IT->string is nil. (Bug#10263)
3915
f7dfe5d6
JD
39162011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3917
83faebb4
JD
3918 * nsterm.h (x_free_frame_resources): Declare.
3919
f7dfe5d6
JD
3920 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3921 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3922
3923 * nsterm.h (ns_get_defaults_value): Declare.
3924
3925 * nsterm.m (ns_default): Call ns_get_defaults_value.
3926
7cd4e72c
EZ
39272011-12-09 Eli Zaretskii <eliz@gnu.org>
3928
3929 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3930 (Bug#10170)
3931
b34d7317
YM
39322011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3933
3934 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3935 that where the value of an _OBJC_* symbol points to is in the .bss
3936 section (Bug#10240).
3937
76470ad1
KH
39382011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3939
3940 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3941 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3942
745fff94
KH
39432011-12-08 Kenichi Handa <handa@m17n.org>
3944
3945 * ftfont.c (get_adstyle_property): Fix previous change
3946 (Bug#10233).
3947
6e44397c
JB
39482011-12-07 Juanma Barranquero <lekktu@gmail.com>
3949
3950 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3951 dirs from the default value of EMACSLOADPATH (bug#10208).
3952
7efa6272
GM
39532011-12-07 Glenn Morris <rgm@gnu.org>
3954
3955 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3956 installation and source directories as well. (Bug#10208)
3957
f6fc4d87
CY
39582011-12-06 Chong Yidong <cyd@gnu.org>
3959
3960 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3961
2bf26180
GM
39622011-12-06 Glenn Morris <rgm@gnu.org>
3963
3964 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3965 as an error, not just -1. (Bug#10217)
3966
3a6ad4f0
CY
39672011-12-05 Chong Yidong <cyd@gnu.org>
3968
3969 * keyboard.c (process_special_events): New function.
3970 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3971
75a3b399
PE
39722011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3973
3974 * coding.c (encode_designation_at_bol): Don't use uninitialized
3975 local variable (Bug#9318).
3976
c3c9e25e
KH
39772011-12-05 Kenichi Handa <handa@m17n.org>
3978
3979 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3980 return Qnil (Bug#8046, Bug#10193).
3981
5eb05ea3
KH
39822011-12-05 Kenichi Handa <handa@m17n.org>
3983
3984 * coding.c (encode_designation_at_bol): New args charbuf_end and
3985 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3986 (coding_set_source): Return how many bytes coding->source was
3987 relocated.
3988 (coding_set_destination): Return how many bytes
3989 coding->destination was relocated.
3990 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3991 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3992
39932011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3994
3995 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3996 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3997 macro (Bug#9318).
3998
39992011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4000
4001 The following changes are to fix Bug#9318.
4002
a79703f5 4003 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4004 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4005 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4006 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4007
7dbda6df
JB
40082011-12-05 Juanma Barranquero <lekktu@gmail.com>
4009
4010 * lisp.h (process_quit_flag): Fix external declaration.
4011
6d5eb5b0
SM
40122011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4013
4014 Don't macro-inline non-performance-critical code.
4015 * eval.c (process_quit_flag): New function.
4016 * lisp.h (QUIT): Use it.
4017
a0c3fad0
JD
40182011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4019
4020 * nsfns.m (get_geometry_from_preferences): New function.
4021 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4022
6c07aac2
AS
40232011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4024
4025 * emacs.c (Qkill_emacs): Define.
4026 (syms_of_emacs): Initialize it.
4027 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4028 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4029 (quit_throw_to_read_char): Add parameter `from_signal'.
4030 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4031 * lisp.h (QUIT): Call Fkill_emacs if requested.
4032
c052ead4
JD
40332011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4034
4035 * widget.c (update_wm_hints): Return if wmshell is null.
4036 (widget_update_wm_size_hints): New function.
4037
4038 * widget.h (widget_update_wm_size_hints): Declare.
4039
4040 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4041 widget_update_wm_size_hints (Bug#10104).
4042
9e49252b
EZ
40432011-12-03 Eli Zaretskii <eliz@gnu.org>
4044
4045 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4046 before a newline, prepare the bidi iterator for consuming the
4047 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4048 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4049
02b16839
JL
40502011-12-02 Juri Linkov <juri@jurta.org>
4051
4052 * search.c (Fword_search_regexp): New Lisp function created from
4053 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4054 (Fword_search_backward, Fword_search_forward)
4055 (Fword_search_backward_lax, Fword_search_forward_lax):
4056 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4057 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4058
0068070e
SM
40592011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4060
4061 * fileio.c (Finsert_file_contents): Move after-change-function call
4062 to before the "handled:" label, since all "goto handled" appear in
4063 cases where the *-change-functions have already been properly called
4064 (bug#10117).
4065
3360a3fc
AS
40662011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4067
4068 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4069 waiting for input. (Bug#10169)
4070
73d6c093
EZ
40712011-11-30 Eli Zaretskii <eliz@gnu.org>
4072
4073 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4074 verifies glyph row's hash code--we have just reallocated the
4075 glyphs, so their contents can be complete garbage. (Bug#10164)
4076
febe6bea
JB
40772011-11-30 Juanma Barranquero <lekktu@gmail.com>
4078
4079 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4080
801a4313
EZ
40812011-11-30 Eli Zaretskii <eliz@gnu.org>
4082
4083 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4084 attributes are tested _before_ calling verify_row_hash, to protect
4085 against GCC re-ordering of the tests. (Bug#10164)
4086
2b56b87e
JD
40872011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4088
4089 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4090
4091 * xterm.c (handle_one_xevent): Only set async_visible and friends
4092 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4093 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4094 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4095
dbf31225
PE
40962011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4097
4098 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4099 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4100 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4101 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4102 All uses changed to use GCPRO1 etc.
4103 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4104 Revert to old implementation (i.e., before 2011-03-11).
4105
1305621b
YM
41062011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4107
4108 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4109 of scroll runs so as to avoid assigning disabled bogus rows and
4110 unnecessary graphics copy operations.
4111
8c9afb46
EZ
41122011-11-27 Eli Zaretskii <eliz@gnu.org>
4113
4114 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4115 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4116 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4117 (malloc, free, realloc, calloc): Redirect to e_* only when
4118 compiling Emacs.
4119
4120 * lisp.h (GCTYPEBITS): Move before first use.
4121 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4122 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4123 this macro definition.
4124
4125 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4126 _MSC_VER.
4127
54e9e3bf
JD
41282011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4129
6d5eb5b0
SM
4130 * gtkutil.c (xg_create_frame_widgets):
4131 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4132 present with Gtk+ 2.0.
4133
83aca1cb
PE
41342011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4135
4136 * fileio.c (Finsert_file_contents): Undo previous change; see
4137 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4138
5b76caa4
PE
41392011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4140
4141 Rename locals to avoid shadowing.
4142 * fileio.c (Finsert_file_contents):
4143 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4144 * process.c (wait_reading_process_output):
4145 Rename inner 'proc' to 'p' to avoid shadowing.
4146 Indent for consistency with usual Emacs style.
4147
8c535114
EZ
41482011-11-25 Eli Zaretskii <eliz@gnu.org>
4149
4150 * xdisp.c (redisplay_window): If cursor row is not fully visible
4151 after recentering, and scroll-conservatively is set to a large
4152 number, scroll window by a few more lines to make the cursor fully
4153 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4154 (start_display): Don't move to the next line if the display should
4155 start at a newline that is part of a display vector or an overlay
4156 string. (Bug#10119)
8c535114 4157
fa4fdb5c
JL
41582011-11-24 Juri Linkov <juri@jurta.org>
4159
4160 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4161 after the `MagickPingImage' call. (Bug#10112)
4162
90ec88df
CY
41632011-11-23 Chong Yidong <cyd@gnu.org>
4164
4165 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4166
56e2e794
MR
41672011-11-23 Martin Rudalics <rudalics@gmx.at>
4168
4169 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4170 making another buffer current. (Bug#10114)
4171
b6e64c41
GM
41722011-11-23 Glenn Morris <rgm@gnu.org>
4173
4174 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4175
6b21de18
CY
41762011-11-23 Chong Yidong <cyd@gnu.org>
4177
4178 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4179 using it (Bug#5984).
4180
b12cd789
EZ
41812011-11-22 Eli Zaretskii <eliz@gnu.org>
4182
4183 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4184 and header-lines, as they don't have one computed for them.
4185 (Bug#10098)
4186
4187 * .gdbinit (prow): Make displayed values more self-explaining.
4188 Add row's hash code.
4189
261b6fd4
LMI
41902011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4191
4192 * process.c (wait_reading_process_output): Fix asynchrounous
4193 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4194 (wait_reading_process_output): Add comment and URL.
261b6fd4 4195
e7cfd277
JD
41962011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4197
4198 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4199
a9b9b7f5
CY
42002011-11-21 Chong Yidong <cyd@gnu.org>
4201
4202 * window.c (Fnext_window, Fprevious_window): Doc fix.
4203
b0d15b4f
SM
42042011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4205
4206 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4207
fe7a3057
JB
42082011-11-20 Juanma Barranquero <lekktu@gmail.com>
4209
4210 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4211
d2999b1a
MR
42122011-11-20 Martin Rudalics <rudalics@gmx.at>
4213
4214 * window.c (Fset_window_combination_limit): Rename argument
4215 STATUS to LIMIT.
4216 (Vwindow_combination_limit): Remove "status" from doc-string.
4217
d5ff9cd0
AS
42182011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4219
4220 * m/ibms390.h: Remove.
4221 * m/ibms390x.h: Don't include "ibms390.h".
4222
a5bb9bd3
SM
42232011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4224
4225 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4226 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4227
cd1181db
JB
42282011-11-20 Juanma Barranquero <lekktu@gmail.com>
4229
4230 * casetab.c (Fset_case_table):
4231 * charset.c (Fcharset_after): Fix typos.
4232
615a3b8d 42332011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4234
17e845af
PE
4235 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4236 Otherwise, valgrind does not work on some platforms.
4237 Problem reported by Andreas Schwab in
6a0bf43d
PE
4238 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4239 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4240 is set, removing the need for VIRT_ADDRESS_VARIES.
4241 (PURE_P): Use a more-efficient implementation that needs just one
4242 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4243 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4244 to 4 (xorl, subq, cmpq, setbe).
4245 * alloc.c (pure): Always extern now, since that's the
4246 VIRT_ADDR_VARIES behavior.
4247 (PURE_POINTER_P): Use a single comparison, not two, for
4248 consistency with the new puresize.h.
4249 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4250 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4251 Remove VIRT_ADDR_VARIES no longer needed.
4252
f8fe6f96
EZ
42532011-11-19 Eli Zaretskii <eliz@gnu.org>
4254
4255 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4256 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4257 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4258 behave as if the cursor position were at the window margin.
4259
4260 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4261 and the cursor position is out of bounds, behave as if the cursor
4262 position were at the window margin. (Bug#10075)
4263
df05a53c
CY
42642011-11-18 Chong Yidong <cyd@gnu.org>
4265
4266 * window.c (Fwindow_combination_limit): Make first argument
4267 non-optional, since it is meaningless for live windows like the
4268 selected window.
61ccba97 4269
2071918e
DA
42702011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4271
4272 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4273
b50a28de
SM
42742011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4275
4276 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4277 (graft_intervals_into_buffer): Simplify.
4278
015137db
EZ
42792011-11-18 Eli Zaretskii <eliz@gnu.org>
4280
4281 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4282 hash values of the two rows.
4283 (copy_row_except_pointers): Preserve the used[] arrays and the
4284 hash values of the two rows. (Bug#10035)
68c95424 4285 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4286
4287 * xdisp.c (row_hash): New function, body extracted from
4288 compute_line_metrics.
4289 (compute_line_metrics): Call row_hash, instead of computing the
4290 hash code inline.
4291
4292 * dispnew.c (verify_row_hash): Call row_hash for computing the
4293 hash code of a row, instead of duplicating code from xdisp.c.
4294
4295 * dispextern.h (row_hash): Add prototype.
4296
a2addb04
TH
42972011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4298
4299 * frame.c (delete_frame): Don't delete the terminal when the last
4300 X frame is closed if emacs is built with GTK toolkit.
4301
df85d315
JB
43022011-11-17 Juanma Barranquero <lekktu@gmail.com>
4303
4304 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4305
a0c2d0ae
MR
43062011-11-17 Martin Rudalics <rudalics@gmx.at>
4307
4308 * window.c (Vwindow_splits): Rename to
4309 Vwindow_combination_resize. Suggested by Juri Linkov.
4310 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4311 of Vwindow_splits.
4312
58179cce
JB
43132011-11-16 Juanma Barranquero <lekktu@gmail.com>
4314
7877f373
JB
4315 * nsfns.m (Fns_font_name):
4316 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4317
b6f67890
MR
43182011-11-16 Martin Rudalics <rudalics@gmx.at>
4319
4320 * window.h (window): Rename slot "nest" to "combination_limit".
4321 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4322 (Fset_window_nest): Rename to Fset_window_combination_limit.
4323 (Vwindow_nest): Rename to Vwindow_combination_limit.
4324 (recombine_windows, make_parent_window, make_window)
4325 (Fsplit_window_internal, saved_window)
4326 (Fset_window_configuration, save_window_save): Rename all
4327 occurrences of window_nest to window_combination_limit.
4328
c7015153
JB
43292011-11-15 Juanma Barranquero <lekktu@gmail.com>
4330
4331 * image.c (imagemagick_load_image): Fix typo.
4332
322ad6ec
EZ
43332011-11-14 Eli Zaretskii <eliz@gnu.org>
4334
4335 * xdisp.c (display_line): Move the call to
4336 highlight_trailing_whitespace before the call to
4337 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4338 faces of all the glyphs to compute ROW's hash value.
4339 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4340
f067b8ec
JB
43412011-11-14 Juanma Barranquero <lekktu@gmail.com>
4342
4343 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4344 just return (bug#10044).
4345
1e5b2111
EZ
43462011-11-12 Eli Zaretskii <eliz@gnu.org>
4347
7ef3cbd5
EZ
4348 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4349 with user-defined heap size. Bump the default size of the temacs
4350 heap to 27MB, to avoid memory warning when running temacs.
4351 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4352
1e5b2111
EZ
4353 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4354 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4355 (verify_row_hash) [XASSERTS]: New function.
4356 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4357 that the hash value of glyph rows is correct.
1e5b2111 4358
89d61221
MR
43592011-11-12 Martin Rudalics <rudalics@gmx.at>
4360
4361 * window.h (window): Remove splits slot.
4362 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4363 (Fdelete_other_windows_internal, make_parent_window)
4364 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4365 (Fset_window_configuration, save_window_save): Don't deal with
4366 split status of windows.
4367 (saved_window): Remove splits slot.
4368 (Vwindow_splits): Rewrite doc-string.
4369
97f18cc8
JD
43702011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4371
4372 * xfns.c (unwind_create_frame):
4373 * nsfns.m (unwind_create_frame):
4374 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4375 Vframe_list (Bug#9999).
4376
22a648b4
DA
43772011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4378
0b381c7e 4379 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4380
659afede
KH
43812011-11-11 Kenichi Handa <handa@m17n.org>
4382
4383 * callproc.c (Fcall_process): Set the member dst_multibyte of
4384 process_coding.
4385
9ac0394b
KH
43862011-11-11 Johan Bockgård <bojohan@gnu.org>
4387
4388 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4389 avoid a crash (bug#9496).
4390
2fbdc249
CY
43912011-11-09 Chong Yidong <cyd@gnu.org>
4392
4393 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4394 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4395
ac6b1f81
PE
43962011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4397
4398 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4399
09db192c
PE
44002011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4401
4402 Avoid some portability problems by eschewing 'extern inline' functions.
4403 The trivial performance wins aren't worth the portability hassles; see
4404 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4405 et seq.
4406 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4407 (window_box_width, window_box_left, window_box_left_offset)
4408 (window_box_right, window_box_right_offset): Undo previous change,
4409 by removing the "extern"s.
4410 * intervals.c (adjust_intervals_for_insertion)
4411 (adjust_intervals_for_deletion): Undo previous change,
4412 making these static again.
4413 (offset_intervals, temp_set_point_both, temp_set_point)
4414 (copy_intervals_to_string): No longer inline.
4415 * xdisp.c (window_text_bottom_y, window_box_width)
4416 (window_box_height, window_box_left_offset)
4417 (window_box_right_offset, window_box_left, window_box_right)
4418 (window_box): No longer inline.
4419
105216ed
CY
44202011-11-08 Chong Yidong <cyd@gnu.org>
4421
4422 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4423 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4424 Signal an error if not a live window.
105216ed
CY
4425 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4426 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4427
ae9e237f
JB
44282011-11-07 Juanma Barranquero <lekktu@gmail.com>
4429
4430 * lisp.h (syms_of_abbrev): Remove declaration.
4431 Reported by CHENG Gao <chenggao@royau.me>.
4432
c7aa8333
EZ
44332011-11-07 Eli Zaretskii <eliz@gnu.org>
4434
4435 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4436 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4437 of temacs in GUI mode.
4438
be7f5545
MR
44392011-11-07 Martin Rudalics <rudalics@gmx.at>
4440
4441 * window.h: Declare delete_all_child_windows instead of
4442 delete_all_subwindows.
4443 * window.c (Fwindow_nest, Fset_window_nest)
4444 (Fset_window_new_total, Fset_window_new_normal)
4445 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4446 (delete_all_subwindows): Rename to delete_all_child_windows.
4447 (Fdelete_other_windows_internal, Fset_window_configuration):
4448 Call delete_all_child_windows instead of delete_all_subwindows.
4449 * frame.c (delete_frame): Call delete_all_child_windows instead
4450 of delete_all_subwindows.
4451
ca78dc43
PE
44522011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4453
4454 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4455 This is also needed for porting to any host where GC_MARK_STACK is
4456 not GC_MAKE_GCPROS_NOOPS.
4457 (which_symbols): Use it.
4458
a0241d01
KH
44592011-11-07 Kenichi Handa <handa@m17n.org>
4460
4461 * coding.c (coding_set_destination): Check coding->src_pos only
4462 when coding->src_object is a buffer (bug#9910).
4463
4464 * process.c (send_process): Set the member src_multibyte of coding
4465 to 0 (bug#9911) when sending a unibyte text.
4466
4467 * callproc.c (Fcall_process): Set the member src_multibyte of
4468 process_coding to 0 (bug#9912).
4469
a64bfdfa 44702011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4471
4472 * xmenu.c (cleanup_widget_value_tree): New function.
4473 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4474 calling free_menubar_widget_value_tree directly (Bug#9830).
4475
cb41b32a
PE
44762011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4477
4478 Fix some portability problems with 'inline'.
4479 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4480 (window_box_width, window_box_left, window_box_left_offset)
4481 (window_box_right, window_box_right_offset): Declare extern.
4482 Otherwise, these inline functions do not conform to C99 and
4483 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4484 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4485 * intervals.c (adjust_intervals_for_insertion)
4486 (adjust_intervals_for_deletion): Now extern, because otherwise the
4487 extern inline functions 'offset_intervals' couldn't refer to it.
4488 (static_offset_intervals): Remove.
4489 (offset_intervals): Rewrite using the old contents of
4490 static_offset_intervals. The old version didn't conform to C99
4491 because an extern inline function contained a reference to an
4492 identifier with static linkage.
4493
b7041366
AS
44942011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4495
4496 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4497 GC.
4498
88a37c4d
EZ
44992011-11-06 Eli Zaretskii <eliz@gnu.org>
4500
4501 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4502 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4503 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4504 return Qleft_to_right.
4505
49745b39
CY
45062011-11-06 Chong Yidong <cyd@gnu.org>
4507
4508 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4509 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4510 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4511 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4512 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4513 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4514 (Fwindow_vscroll): Doc fix.
4515 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4516 argument, since it makes no sense to pass a live window and for
4517 consistency with window-child.
4518
1f05cd82
CS
45192011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4520
4521 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4522 support MSVC.
4523
22610910
JR
45242011-11-05 Jason Rumney <jasonr@gnu.org>
4525
4526 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4527 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4528 fonts (Bug#6029).
4529 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4530 bitwise arithmetic preventing use of unicode-sip and non-truetype
4531 opentype fonts.
4532
a06776b2
EZ
45332011-11-05 Eli Zaretskii <eliz@gnu.org>
4534
3ad924ba
EZ
4535 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4536 "emacs"-only part.
4537
a06776b2
EZ
4538 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4539 initialization code to keep similarity to xfns.c after changes
4540 from 2011-11-05.
4541
c9e7db78
JD
45422011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4543
a97f8f3f
JD
4544 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4545 (unwind_create_frame): New function (Bug#9943).
4546 (Fx_create_frame): Restructure code to be more similar to the one in
4547 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4548 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4549 Move terminal->reference_count++ just before making the frame official
4550 (Bug#9943).
4551
4552 * nsterm.m (x_free_frame_resources): New function.
4553 (x_destroy_window): Move code to x_free_frame_resources.
4554
c9e7db78 4555 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4556 (Fx_create_frame, x_create_tip_frame):
4557 Move terminal->reference_count++ just before making the frame
75f1671a 4558 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4559 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4560
a6fc3b5c
EZ
45612011-11-05 Eli Zaretskii <eliz@gnu.org>
4562
4563 Support MSVC build with newer versions of Visual Studio.
4564 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4565 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4566 nt/gmake.defs.
4567
4568 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4569 which are not supported by MSVC.
4570 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4571 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4572 bitfields.
4573 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4574 types in bitfields.
4575 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4576
4577 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4578
58179cce 45792011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4580
4581 Support MSVC build with newer versions of Visual Studio.
4582 * w32.c: Don't include w32api.h for MSVC.
4583 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4584
4585 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4586 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4587 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4588 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4589 e_* cousins.
4590 (alloca) [_MSC_VER]: Define to _alloca.
4591
4592 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4593
4594 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4595
a58c13ed
EZ
45962011-11-04 Eli Zaretskii <eliz@gnu.org>
4597
4598 * xdisp.c (note_mouse_highlight): If either of
4599 previous/next-single-property-change returns nil, treat that as
4600 the beginning or the end of the buffer. (Bug#9955)
4601
fe0b6370
JD
46022011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4603
a58c13ed 4604 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4605 label is not null (Bug#9951).
4606 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4607 may be NULL.
4608
89bd5ee1
EZ
46092011-11-04 Eli Zaretskii <eliz@gnu.org>
4610
4611 * window.c (Fwindow_body_size): Mention in the doc string that the
4612 return value is in frame's canonical units. (Bug#9949)
4613
84c3edb9
EZ
46142011-11-03 Eli Zaretskii <eliz@gnu.org>
4615
4e2fb5c7
EZ
4616 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4617
84c3edb9 4618 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4619 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4620 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4621
bc17a887
EZ
46222011-11-01 Eli Zaretskii <eliz@gnu.org>
4623
4624 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4625 Don't stop backward scan on the continuation glyph, even though
4626 its CHARPOS is positive.
6d5eb5b0
SM
4627 (mouse_face_from_buffer_pos, note_mouse_highlight):
4628 Rename cover_string to disp_string.
bc17a887 4629
4ee88440
MR
46302011-11-01 Martin Rudalics <rudalics@gmx.at>
4631
4632 * window.c (temp_output_buffer_show): Don't use
4633 Vtemp_buffer_show_specifiers.
4634 (Vtemp_buffer_show_specifiers): Remove unused variable.
4635
c2ff3c02
EZ
46362011-10-30 Eli Zaretskii <eliz@gnu.org>
4637
4638 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4639 past the beginning of the current glyph matrix.
4640
58179cce 46412011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4642
4643 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4644 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4645 HAVE_GTK3 (Bug#9869).
b77a6a7f 4646
3b574623
JD
4647 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4648 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4649
b77a6a7f
JD
4650 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4651
4652 * xterm.c: Declare x_handle_net_wm_state to return int.
4653 (handle_one_xevent): Check if we are iconified but don't have
4654 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4655 (get_current_wm_state): Return non-zero if not hidden,
4656 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4657 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4658 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4659 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4660
196e41e4
PE
46612011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4662
4663 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4664 so that this new function doesn't get optimized away by a
4665 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4666
021f2e1a
AS
46672011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4668
4669 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4670
8b058d44
EZ
46712011-10-29 Eli Zaretskii <eliz@gnu.org>
4672
4673 Fix the `xbytecode' command.
4674 * .gdbinit (xprintbytestr): New command.
b50a28de 4675 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4676 (xbytecode): Print the byte-code string as well.
4677
4452fb80
EZ
46782011-10-29 Kim Storm <storm@cua.dk>
4679
8b058d44
EZ
4680 * alloc.c (which_symbols): New function.
4681
21b72067
AS
46822011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4683
4684 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4685 line. (Bug#9903)
4686
83ed7b5c
GM
46872011-10-29 Glenn Morris <rgm@gnu.org>
4688
4689 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4690 Not clear what it was for, and it causes various bugs. (Bug#9839)
4691
5a7a728b
EZ
46922011-10-28 Eli Zaretskii <eliz@gnu.org>
4693
4694 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4695 possible random value that matches one of those tested as
4696 condition to clear the mouse face.
4697
d3d0842f
CY
46982011-10-28 Chong Yidong <cyd@gnu.org>
4699
4700 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4701
31b39d13
DN
47022011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4703
4704 * window.c (make_window): Initialize phys_cursor_on_p.
4705
9aba6043
SM
47062011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4707
4708 * lisp.h (struct Lisp_Symbol): Update comments.
4709
c20992f4
JB
47102011-10-28 Juanma Barranquero <lekktu@gmail.com>
4711
4712 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4713
db4f02f2
EZ
47142011-10-28 Eli Zaretskii <eliz@gnu.org>
4715
4716 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4717 <oslsachem@gmail.com> for helping to debug this.
4718
4719 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4720 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4721 (g_b_init_get_glyph_outline_w): New static variables.
4722 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4723 (GetGlyphOutlineW_Proc): New typedefs.
4724 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4725 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4726 New functions.
4727 (w32font_open_internal, compute_metrics):
4728 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4729 instead of calling the "wide" APIs directly.
4730
4731 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4732
4733 * w32.h (syms_of_w32font): Add prototype.
4734
87e68db4
JB
47352011-10-27 Juanma Barranquero <lekktu@gmail.com>
4736
4737 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4738 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4739 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4740 (Fmove_to_window_line): Doc fix.
4741
435c1d67
CY
47422011-10-27 Chong Yidong <cyd@gnu.org>
4743
4744 * process.c (make_process): Set gnutls_state to NULL.
4745
4746 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4747 non-NULL, regardless of GNUTLS_INITSTAGE.
4748 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4749 an error. Set process slots as soon as we allocate them.
4750
4751 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4752
9c6c6f49
CY
47532011-10-27 Chong Yidong <cyd@gnu.org>
4754
9aba6043
SM
4755 * gnutls.c (emacs_gnutls_deinit): New function.
4756 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4757 (Fgnutls_deinit, Fgnutls_boot): Use it.
4758
4759 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4760 (deactivate_process): Call emacs_gnutls_deinit.
4761
657d08d3
JB
47622011-10-27 Juanma Barranquero <lekktu@gmail.com>
4763
4764 * image.c (x_create_x_image_and_pixmap):
4765 * w32.c (sys_rename, w32_delayed_load):
4766 * w32font.c (fill_in_logfont):
4767 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4768
5430d399
JB
47692011-10-26 Juanma Barranquero <lekktu@gmail.com>
4770
4771 * w32fns.c (w32_default_color_map): New function,
4772 extracted from Fw32_default_color_map.
a7ef684b 4773 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4774
fe0055fa
PE
47752011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4776
4777 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4778
e6346438
SM
47792011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4780
4781 * keyboard.c (test_undefined): New function (bug#9751).
4782 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4783
e112cc37
ET
47842011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4785
4786 * sysdep.c (init_sys_modes): Fix the check for the controlling
4787 terminal (Bug#6649).
4788
7b5d6677
EZ
47892011-10-20 Eli Zaretskii <eliz@gnu.org>
4790
4791 * dispextern.h (struct bidi_it): New member next_en_type.
4792
4793 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4794 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4795 current character, check also for next_en_type being WEAK_EN.
4796 (bidi_resolve_weak): Don't enter the expensive loop if the current
4797 position is before next_en_pos. Record the bidi type of the first
4798 non-ET, non-BN character we find, in addition to its position.
4799 (bidi_level_of_next_char): Invalidate next_en_type when
4800 next_en_pos is over-stepped.
4801
7da0b018
PE
48022011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4803
4804 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4805 * editfns.c: Rewrite current-time-zone so that it invokes
4806 the equivalent of (format-time-string "%Z") to get the time zone name.
4807 This fixes a bug when the time zone name contains characters that
4808 need converting from the system time locale to Emacs internal format.
4809 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4810 that patch fixed format-time-string to do the conversion, but
4811 I forgot to fix current-time-zone.
4812 (format_time_string): New function, containing most of
4813 what Fformat_time_string used to contain.
4814 (Fformat_time_string): Rewrite in terms of format_time_string.
4815 This doesn't change this function's behavior.
4816 (current-time-zone): Rewrite to use format_time_string.
4817 This fixes the bug reported by Michael Schierl in
4818 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4819 Jason Rumney's 2007-06-07 change worked around this bug, but
4820 didn't fix it.
4821 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4822
8547b010
EZ
48232011-10-19 Eli Zaretskii <eliz@gnu.org>
4824
4825 * xdisp.c (start_display): If the character at POS is displayed
4826 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4827 (try_window_reusing_current_matrix): If a line ends in a display
4828 vector or the next line starts in a display vector, continue
4829 redrawing the window even though the character position of
4830 start_row was reached.
8547b010
EZ
4831 (Bug#9771, part 2)
4832
4e948d15
CY
48332011-10-18 Chong Yidong <cyd@gnu.org>
4834
4835 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4836 with nobreak-char-display too.
4837
4787455f
EZ
48382011-10-18 Eli Zaretskii <eliz@gnu.org>
4839
4840 Fix part 3 of bug#9771.
4841 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4842 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4843 non-neutral characters if the current character is a paragraph
4844 separator (a.k.a. Newline). This avoids running the same
4845 expensive loop twice, once when we consume the preceding newline
4846 and the other time when the line actually needs to be displayed.
4847 Avoid the loop when we see neutrals on the base embedding level
4848 following a character whose directionality is the same as the
4849 paragraph's. This avoids running the expensive loop when a line
4850 ends in a long sequence of neutrals, like control characters.
4851 Add assertion against STRONG_AL type. Slightly rearrange code
4852 that determines the type of a neutral given the first non-neutral
4853 that follows it.
4854 (bidi_level_of_next_char): Set next_en_pos to zero when
4855 invalidating its info.
4856
2c91f553
EZ
48572011-10-17 Eli Zaretskii <eliz@gnu.org>
4858
4859 * xdisp.c (push_display_prop): Determine whether to record string
4860 or buffer position by IT->string, not by IT->method. Allow
4861 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4862 (move_it_vertically_backward): Don't look for character position
4863 immediately after the newline when in a continuation line.
4864 (Bug#9771, part 1)
2c91f553 4865
c7b08b0d
MR
48662011-10-15 Martin Rudalics <rudalics@gmx.at>
4867
4868 * window.c (coordinates_in_window): Rewrite and delabelize
4869 vertical border check. (Bug#5357) (Bug#9618)
4870
6b02f655
SM
48712011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4872
4873 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4874 errors in XSetWindowBorder (bug#9310).
4875
81d40c92
DA
48762011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4877
4878 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4879 avoid crash when xmalloc overrun checking is enabled.
4880
d4172c3b
EZ
48812011-10-13 Eli Zaretskii <eliz@gnu.org>
4882
4883 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4884 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4885 cursor motion with <left> and <right> arrow keys.
4886
4887 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4888 some callers set that themselves.
4889
b00eea75
EZ
48902011-10-12 Eli Zaretskii <eliz@gnu.org>
4891
4892 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4893 display string and the previous row comes from the same string and
4894 is empty. (Bug#9739) (Bug#9738)
4895
8fe012c4
SM
48962011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4897
4898 * doc.c (get_doc_string): Encode file name (bug#9735).
4899
0074aef2
EZ
49002011-10-12 Eli Zaretskii <eliz@gnu.org>
4901
79beb178
EZ
4902 * bidi.c (bidi_level_of_next_char):
4903 * xdisp.c (get_visually_first_element): Remove old incorrect
4904 comments regarding the Unicode Line Separator character.
4905
0074aef2
EZ
4906 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4907
6e4b3fbe
DA
49082011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4909
4910 * alloc.c (Fgc_status): Do not access beyond zombies array
4911 boundary if nzombies > MAX_ZOMBIES.
4912 * alloc.c (dump_zombies): Add missing format specifier.
4913
0324f3af
PE
49142011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4915
b5525cac
PE
4916 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4917 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4918
0324f3af
PE
4919 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4920 Some packages use them to denote characters with modifiers.
4921
e9b5f888
AS
49222011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4923
4924 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4925 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4926 matching a pp-number. Rename parameter var to var1.
4927
127827c0
SM
49282011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4929
4930 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4931
c8fd3bd0
GM
49322011-10-08 Glenn Morris <rgm@gnu.org>
4933
4934 * callint.c (Fcall_interactively): Give a more explicit error for the
4935 'c' case with a non-character input. (Bug#8479)
4936
352ec8ff
EZ
49372011-10-08 Eli Zaretskii <eliz@gnu.org>
4938
03669ccb
EZ
4939 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4940 lines.
7061c986
EZ
4941 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4942 lines that are hscrolled on the left.
03669ccb 4943
352ec8ff
EZ
4944 * dispnew.c (buffer_posn_from_coords): Account for a possible
4945 presence of header-line. (Bug#4426)
4946
a66cfb1c
SM
49472011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4948
6b02f655
SM
4949 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4950 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4951
7c5ee88e
PE
49522011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4953
4954 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4955 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4956 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4957 this makes Emacs dump core during garbage collection on rare
4958 occasions. sizeof is obviously inferior to offsetof here, so
4959 stick with offsetof.
4960 (GC_POINTER_ALIGNMENT): New macro.
4961 (mark_memory): Omit 3rd (offset) arg; caller changed.
4962 Don't assume EMACS_INT alignment is the same as pointer alignment.
4963
df1bbe5b
SM
49642011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4965
4966 * keyboard.c (read_key_sequence_remapped): New var.
4967 (read_key_sequence): Compute remapping in the right buffer.
4968 (command_loop_1): Use read_key_sequence's remapping directly.
4969
51553db6
SM
49702011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4971
32c1fffd
SM
4972 * dired.c (file_name_completion): Don't expand file name.
4973 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4974 before checking file name handler.
4975
51553db6
SM
4976 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4977 they've been requested explicitly (bug#9591).
4978
b6bd1599 49792011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4980
4981 * keymap.c (Fsingle_key_description): Use make_specified_string
4982 instead of build_string to build string from push_key_description.
4983 (Bug#5193)
4984
f701dc2a
PE
49852011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4986
4222c55d
PE
4987 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4988 This fixes a Y2038 bug on 64-bit hosts.
4989 * buffer.c (reset_buffer):
4990 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4991 (Fclear_buffer_auto_save_failure):
4992 Use 0, not -1, to represent an unset failure time, since time_t
4993 might not be signed.
4994
f701dc2a
PE
4995 Remove dependency on glibc malloc internals.
4996 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4997 Move back here from lisp.h, but with their new implementations.
4998 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4999 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5000 * charset.c (charset_table_init): New static var.
5001 (syms_of_charset): Use it instead of xmalloc. This removes a
5002 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5003 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5004 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5005 Move back to alloc.c.
5006 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5007 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5008
9ceebf39
JD
50092011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5010
5011 * nsterm.m (windowDidResize): Call x_set_window_size only when
5012 ns_in_resize is true. Otherwise set pixelwidth/height and
5013 call change_frame_size (Bug#9628).
5014
cb993c58
PE
50152011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5016
3930c88b
PE
5017 Port --enable-checking=all to Fedora 14 x86-64.
5018 * charset.c (syms_of_charset): Also account for glibc malloc's
5019 internal overhead when calculating the initial malloc maximum.
5020
cb993c58
PE
5021 Port --enable-checking=all to Fedora 14 x86.
5022 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5023 Move to lisp.h.
5024 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5025 (overrun_check_realloc, overrun_check_free):
5026 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5027 That way, xmalloc returns a properly-aligned pointer even if
5028 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5029 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5030 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5031 into account when calculating the initial malloc maximum.
5032 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5033 Move here from alloc.c, so that charset.c can use it too.
5034 Properly align; the old code wasn't right for common 32-bit hosts
5035 when configured with --enable-checking=all.
5036 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5037 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5038
31bed486
EZ
50392011-09-29 Eli Zaretskii <eliz@gnu.org>
5040
04c70788 5041 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5042 use EDOM.
5043
fbcaa2f3
EZ
50442011-09-28 Eli Zaretskii <eliz@gnu.org>
5045
5046 * xdisp.c (compute_display_string_end): If there's no display
5047 string at CHARPOS, return -1.
5048
5049 * bidi.c (bidi_fetch_char): When compute_display_string_end
5050 returns a negative value, treat the character as a normal
5051 character not covered by a display string. (Bug#9624)
5052
a239d4e9
JB
50532011-09-28 Juanma Barranquero <lekktu@gmail.com>
5054
5055 * lread.c (Fread_from_string): Fix typo in docstring.
5056
88652fd5
EZ
50572011-09-27 Eli Zaretskii <eliz@gnu.org>
5058
5059 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5060 newline, reseat the iterator instead of bidi-iterating there one
5061 character at a time. (Bug#9610)
32c1fffd
SM
5062 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5063 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5064
ed497dd4
AS
50652011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5066
5067 * lread.c (readevalloop): Use correct code for NBSP.
5068 (read1): Likewise. (Bug#9608)
5069
b2bf61aa
MA
50702011-09-25 Michael Albinus <michael.albinus@gmx.de>
5071
5072 * dbusbind.c (Fdbus_register_signal): When service is not
5073 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5074
32bbb17c
GM
50752011-09-25 Glenn Morris <rgm@gnu.org>
5076
5077 * buffer.c (truncate-lines): Doc fix.
5078
94e0933e
CY
50792011-09-24 Chong Yidong <cyd@stupidchicken.com>
5080
5081 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5082 (Fset_window_next_buffers): Doc fix.
5083
cddde921
GM
50842011-09-24 Glenn Morris <rgm@gnu.org>
5085
5086 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5087
1260aef1
PE
50882011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5089
25b4bfa0
PE
5090 Fix minor problems found by static checking.
5091 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5092 * indent.c (Fvertical_motion): Fix == vs = typo.
5093
e3cbd34b
EZ
50942011-09-24 Eli Zaretskii <eliz@gnu.org>
5095
a66cfb1c
SM
5096 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5097 Default value is now t. Doc fix.
6bf7006f 5098
e3cbd34b 5099 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5100 logic when moving up, not only when moving down. Fix the
e3cbd34b 5101 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5102 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5103
5104 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5105 CHARPOS is covered by a display string which includes newlines.
5106 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5107 is covered by a display string with embedded newlines.
5108
a3de0cbd
MA
51092011-09-24 Michael Albinus <michael.albinus@gmx.de>
5110
5111 * dbusbind.c (Fdbus_register_signal): Add match rule to
5112 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5113 (Fdbus_register_method, Vdbus_registered_objects_table):
5114 Fix docstring.
a3de0cbd 5115
b260039d
JM
51162011-09-24 Jim Meyering <meyering@redhat.com>
5117
32c1fffd 5118 do not ignore write error for any output size
b260039d
JM
5119 The previous change was incomplete.
5120 While it makes emacs --batch detect the vast majority of stdout
5121 write failures, errors were still ignored whenever the output size is
5122 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5123 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5124 && echo FAIL: ignored write error
5125 FAIL: ignored write error
5126 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5127 && echo FAIL: ignored write error
5128 FAIL: ignored write error
5129 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5130
8eca8a7c
AS
51312011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5132
5133 * emacs.c (Fkill_emacs): In noninteractive mode exit
5134 non-successfully if a write error occurred on stdout. (Bug#9574)
5135
3341db62
EZ
51362011-09-21 Eli Zaretskii <eliz@gnu.org>
5137
5138 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5139 the xassert test.
5140
5141 * dispextern.h (struct it): Update the comment documenting what
5142 can it->OBJECT be.
5143
8c203dbf
EZ
51442011-09-20 Eli Zaretskii <eliz@gnu.org>
5145
5146 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5147 a display string, extend search for cursor position to end of row.
5148 (find_row_edges): If the row ends in a newline from a display
5149 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5150 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5151 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5152 non-empty line. Fixes confusing cursor motion with arrow keys at
5153 the beginning of a line that starts with whitespace.
8c203dbf 5154
a4824228
LMI
51552011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5156
5157 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5158 (bug#9493).
5159
33ed493b
CY
51602011-09-18 Chong Yidong <cyd@stupidchicken.com>
5161
5162 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5163 boolean (Bug#9154).
5164
56cd55c8
EZ
51652011-09-18 Eli Zaretskii <eliz@gnu.org>
5166
5167 * xdisp.c (display_line): Record maximum and minimum buffer
5168 positions even if no glyphs were produced (e.g., by a zero-width
5169 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5170 buffer positions that will be removed from the glyph row because
5171 they don't fit.
c02dcedf
EZ
5172 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5173 column is beyond frame width: don't subtract 1 "pixel" when
5174 computing width of the stretch.
3e62b7e0
EZ
5175 (reseat_at_next_visible_line_start): Undo the change made on
5176 2011-09-17 that saved paragraph information and restored it after
5177 the call to `reseat'. (Bug#9545)
56cd55c8 5178
5ed99d36 51792011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5180
5181 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5182 and turn window cursor on if cleared (Bug#9415).
5183
5ed99d36 51842011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5185
5186 * search.c (boyer_moore): Take unibyte characters from pattern
5187 literally. (Bug#9458)
5188
9bade7b2
EZ
51892011-09-18 Eli Zaretskii <eliz@gnu.org>
5190
5191 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5192
e5e9d610
PE
51932011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5194
87e4427a
PE
5195 Fix minor problem found by static checking.
5196 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5197 initialized, to pacify gcc -Wuninitialized.
5198
e5e9d610
PE
5199 * fileio.c: Report proper errno when syscall falls.
5200 (Finsert_file_contents): Save and restore errno,
5201 so that report_file_error outputs the correct diagnostic.
5202 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5203
a1674f0b
EZ
52042011-09-18 Eli Zaretskii <eliz@gnu.org>
5205
5206 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5207
fbfb6dd4
EZ
52082011-09-17 Eli Zaretskii <eliz@gnu.org>
5209
5210 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5211 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5212
bb187662
EZ
52132011-09-17 Eli Zaretskii <eliz@gnu.org>
5214
1137e8b8 5215 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5216 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5217
5218 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5219 (bidi_find_paragraph_start): Search back for paragraph beginning
5220 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5221 (bidi_move_to_visually_next): Only trigger paragraph-related
5222 computations when the last character is a newline or at EOB, not
5223 just any NEUTRAL_B. (Bug#9470)
5224
bb187662
EZ
5225 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5226 truncated lines if point is covered by a display string. (Bug#9524)
5227
2e621251
PE
52282011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5229
5230 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5231 (cons_to_x_long): New function.
5232 (lisp_data_to_selection_data): Use it. Correct the test for
5233 short-versus-long data; it was negated. Break out of vector
5234 loop, for efficiency, when a long datum is discovered.
5235
91a15bc6
SM
52362011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5237
5238 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5239
b41c3a35
EZ
52402011-09-16 Eli Zaretskii <eliz@gnu.org>
5241
5242 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5243 GCC PR/17406) by declaring this function with external scope.
5244
7812ba2d
PE
52452011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5246
5247 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5248 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5249
cf7edc2a
AS
52502011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5251
5252 * editfns.c (Fformat): Correctly handle text properties on "%%".
5253
bd01620e
EZ
52542011-09-15 Eli Zaretskii <eliz@gnu.org>
5255
5256 * xterm.c (x_draw_composite_glyph_string_foreground):
5257 * w32term.c (x_draw_composite_glyph_string_foreground):
5258 * term.c (encode_terminal_code):
5259 * composite.c (composition_update_it, get_composition_id):
5260 * xdisp.c (get_next_display_element)
5261 (fill_composite_glyph_string): Add comments about special meaning
5262 of TAB characters in a composition.
5263
a02719a3
PE
52642011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5265
5266 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5267 This occurs when processing a multibyte format.
5268 Problem reported by Wolfgang Jenker.
a02719a3 5269
72589a3c
JB
52702011-09-15 Johan Bockgård <bojohan@gnu.org>
5271
5272 * xdisp.c (try_cursor_movement): Only check for exact match if
5273 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5274
1c14176c
PE
52752011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5276
5277 Remove unused external symbols.
5278 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5279 * xdisp.c (calc_pixel_width_or_height): Now static.
5280 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5281 * indent.c (check_display_width):
5282 * w32term.c: Fix comment to match code.
5283 * xterm.c, xterm.h (x_catching_errors): Remove.
5284
d2eea5b5
PE
52852011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5286
5287 * xselect.c: Use signed conversions more consistently (Bug#9498).
5288 (selection_data_to_lisp_data): Assume incoming selection data are
5289 signed integers, not unsigned. This is to be consistent with
5290 outgoing selection data, which was modified to use signed integers
5291 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5292 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5293 expects long, not unsigned long.
5294
46888499
EZ
52952011-09-14 Eli Zaretskii <eliz@gnu.org>
5296
5297 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5298 computation of loop end. Reported by Johan Bockgård
5299 <bojohan@gnu.org>.
5300
ef8ef9fb
CY
53012011-09-13 Chong Yidong <cyd@stupidchicken.com>
5302
5303 * frame.c (Fother_visible_frames_p): Function deleted.
5304
fa819fed
EZ
53052011-09-12 Eli Zaretskii <eliz@gnu.org>
5306
5307 * indent.c (compute_motion): Process display vector front to back
5308 rather than the other way around. (Bug#2496)
5309
2ba8e008
SM
53102011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5311
5312 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5313
20f53c69
CY
53142011-09-11 Chong Yidong <cyd@stupidchicken.com>
5315
5316 * minibuf.c (Fread_from_minibuffer): Doc fix.
5317
d562d7a4
EZ
53182011-09-11 Eli Zaretskii <eliz@gnu.org>
5319
5320 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5321 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5322
1c4d7f3d
LMI
53232011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5324
5325 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5326 value for non-existent files.
5327
b885bf36
EZ
53282011-09-11 Eli Zaretskii <eliz@gnu.org>
5329
5330 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5331 set its "size" to -1. This will set the modtime_size field of
5332 the corresponding buffer to -1, which is what
5333 verify-visited-file-modtime expects for files that do not exist.
5334 (Bug#9139)
5335
6612f0bf
PE
53362011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5337
5338 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5339 here ...
5340 * lisp.h: ... from here. push_key_description is no longer
5341 defined in keyboard.c, so its declaration should not be in
5342 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5343 logically belongs with push_key_description.
5344
dfb3f755
PE
53452011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5346
5347 * buffer.h: Include <sys/types.h> instead of <time.h>.
5348 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5349 Problem reported by Herbert J. Skuhra.
5350
3134906c
LMI
53512011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5352
5353 * xml.c (parse_region): Make the parsing work for
5354 non-comment-starting XML files again (bug#9144).
5355
8d903f4e
AS
53562011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5357
5358 * image.c (gif_load): Fix calculation of bottom and right corner.
5359 (Bug#9468)
5360
80ad64f4
EZ
53612011-09-10 Eli Zaretskii <eliz@gnu.org>
5362
5363 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5364 redisplay in small windows.
5365
208a048d
EZ
53662011-09-09 Eli Zaretskii <eliz@gnu.org>
5367
5368 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5369
9b1c252e
MR
53702011-09-08 Martin Rudalics <rudalics@gmx.at>
5371
5372 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5373 Operate on live windows only.
5374
2949f33b
JB
53752011-09-08 Juanma Barranquero <lekktu@gmail.com>
5376
5377 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5378
e08dcafd
EZ
53792011-09-07 Eli Zaretskii <eliz@gnu.org>
5380
5381 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5382 only under bidi iteration.
5383
115b96bd
JD
53842011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5385
5386 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5387
c8199d0f
PE
53882011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5389
5390 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5391 Without this fix, the command to link temacs failed due to an
5392 undefined symbol __builtin_isnan. This is because
5393 /usr/include/iso/math_c99.h #defines isnan(x) to
5394 __builtin_isnan(x), but the bundled gcc, which identifies itself
5395 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5396 a __builtin_isnan.
5397 * floatfns.c (isnan): #undef, and then #define to a clone of
5398 what's in data.c.
5399 (Fisnan): Always define, since it's always available now.
5400 (syms_of_floatfns): Always define isnan at the Lisp level.
5401
e39b275c 54022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5403
5404 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5405
b2db44d9 54062011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5407
f4af5137 5408 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5409 The previous code assumed that file offsets (off_t values) fit in
5410 EMACS_INT variables, which is not true on typical 32-bit hosts.
5411 The code messed up by falsely reporting buffer overflow in cases
5412 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5413 when "big" contains more than 2**29 bytes, even though this
5414 inserts just one byte and does not overflow the buffer.
5415 (Finsert_file_contents): Store file offsets as off_t
5416 values, not as EMACS_INT values. Check for overflow when
5417 converting between EMACS_INT and off_t. When checking for
5418 buffer overflow or for overlap, take the offsets into account.
5419 Don't use EMACS_INT for small values where int suffices.
5420 When checking for overlap, fix a typo: ZV was used where
5421 ZV_BYTE was intended.
5422 (Fwrite_region): Don't assume off_t fits into 'long'.
5423 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5424
ecfc0a49
MA
54252011-09-05 Michael Albinus <michael.albinus@gmx.de>
5426
5427 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5428
6511acf2 54292011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5430
0999621a 5431 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5432
5433 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5434 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5435 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5436 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5437 (modify_event_symbol): Do not assume that the length of
5438 name_alist_or_stem is safe to alloca and fits in int.
5439 (Fexecute_extended_command): Likewise for function name and binding.
5440 (Frecursion_depth): Wrap around reliably on integer overflow.
5441 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5442 since some callers pass EMACS_INT values.
5443 (Fsingle_key_description): Don't crash if symbol name contains more
5444 than MAX_ALLOCA bytes.
5445 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5446 (get_minibuffer): Arg is now EMACS_INT, not int.
5447 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5448 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5449 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5450
2be7d702
PE
5451 * dbusbind.c (signature_cat): New function.
5452 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5453 Do not overrun buffer; instead, report string overflow.
5454
9d1df220
PE
5455 * dispnew.c (add_window_display_history): Don't overrun buffer.
5456 Truncate instead; this is OK since it's just a log.
5457
33ef5c64
PE
5458 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5459 even if the time zone offset is outlandishly large.
5460 Don't mishandle offset == INT_MIN.
5461
66c6fdd5
PE
5462 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5463 when creating daemon; the previous buffer-overflow check was incorrect.
5464
d749b01b
PE
5465 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5466 which has the guts of the old verror function.
5467
b5cd1905
PE
5468 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5469 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5470
6e1a67fb
PE
5471 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5472 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5473 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5474 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5475 length of string rather than counting it via multiple sprintfs;
5476 that's simpler and more reliable.
c21721cc
PE
5477 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5478 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5479 sprintf, in case result does not fit in int.
5480
c57b67fc
PE
5481 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5482 (fontset_from_font): Print it.
5483
8a401434
PE
5484 * frame.c (tty_frame_count): Now printmax_t, not int.
5485 (make_terminal_frame, set_term_frame_name): Print it.
5486 (x_report_frame_params): In X, window IDs are unsigned long,
5487 not signed long, so print them as unsigned.
5488 (validate_x_resource_name): Check for implausibly long names,
5489 and don't assume name length fits in 'int'.
5490 (x_get_resource_string): Don't blindly alloca invocation name;
5491 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5492 not fit in int.
5493
6e1a67fb
PE
5494 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5495 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5496 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5497
0df02bf3
PE
5498 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5499 Use esprintf, not sprintf, in case result does not fit in int.
5500
48e30793
PE
5501 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5502 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5503 it as a large positive number.
5504 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5505 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5506
a66ff6d8
PE
5507 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5508 in case result does not fit in int.
5509
aca216ff
PE
5510 * print.c (float_to_string): Detect width overflow more reliably.
5511 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5512 buffer overrun. Don't assume list length fits in 'int'. Treat
5513 print length of 0 as 0, not as infinity; to be consistent with other
5514 uses of print length in this function. Don't overflow print length
5515 index. Don't assume hash table size fits in 'long', or that
5516 vectorlike size fits in 'unsigned long'.
5517
31c286f7
PE
5518 * process.c (make_process): Use printmax_t, not int, to format
5519 process-name gensyms.
5520
55e5faa1
PE
5521 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5522
80f2e268
PE
5523 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5524 to avoid potential buffer overrun.
5525
670741ab
PE
5526 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5527 if X resource line is longer than 512 bytes.
5528
b7163a50
PE
5529 * xfns.c (x_window): Make sprintf buffer a bit bigger
5530 to avoid potential buffer overrun.
5531
ae58ff1f
PE
5532 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5533
c43c8a6a
PE
5534 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5535
3f8236f4
PE
55362011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5537
53e9fe90 5538 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5539 Without these, Emacs silently mishandles large integers sometimes.
5540 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5541 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5542
6511acf2
PE
5543 * xdisp.c (try_window_id): Check Emacs fixnum range before
5544 converting to 'int'.
806add1d 5545
6511acf2 5546 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5547 Check that an Emacs fixnum is in range before assigning it to 'int'.
5548 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5549 values converted from Emacs fixnums.
5550 (Frecenter): Don't wrap around a line count if it is out of 'int'
5551 range; instead, treat it as an extreme value.
5552 (Fset_window_configuration, compare_window_configurations):
5553 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5554
6511acf2
PE
5555 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5556 that can exceed INT_MAX. Check that EMACS_INT value is in range
5557 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5558 (match_limit): Don't assume that a fixnum can fit in 'int'.
5559
6511acf2 5560 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5561 exceed INT_MAX.
5562
6511acf2 5563 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5564 (Fvertical_motion): Don't wrap around LINES values that don't fit
5565 in 'int'. Instead, treat them as extreme values. This is good
5566 enough for windows, which can't have more than INT_MAX lines anyway.
5567
fcb901a7
LMI
55682011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5569
0f2f6b6d
LMI
5570 * Require libxml/parser.h to avoid compilation warning.
5571
fcb901a7
LMI
5572 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5573
5574 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5575 since this reportedly can destroy thread storage.
5576
6e20a0d4
CY
55772011-08-30 Chong Yidong <cyd@stupidchicken.com>
5578
5579 * syntax.c (find_defun_start): Update all cache variables if
5580 exiting early (Bug#9401).
5581
148ae00e
EZ
55822011-08-30 Eli Zaretskii <eliz@gnu.org>
5583
f6cfbd8f
EZ
5584 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5585
148ae00e
EZ
5586 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5587 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5588 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5589
5590 * term.c (tty_append_glyph): New function.
5591 (produce_stretch_glyph): Static function and its prototype deleted.
5592
a66cfb1c
SM
5593 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5594 Add prototypes.
148ae00e 5595
c4a07a4c
PE
55962011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5597
5598 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5599 when checking :margin (Bug#9390).
5600 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5601 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5602 so that the name doesn't mislead. All uses changed.
5603
6bc8cd65
JB
56042011-08-28 Johan Bockgård <bojohan@gnu.org>
5605
5606 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5607 set_tty_hooks.
5608
dca4927e
EZ
56092011-08-27 Eli Zaretskii <eliz@gnu.org>
5610
5611 * xdisp.c (move_it_to): Don't bail out early when reaching
5612 position beyond to_charpos, if we are scanning backwards.
5613 (move_it_vertically_backward): When DY == 0, make sure we get to
5614 the first character in the line after the newline.
5615
f2cad773
PE
56162011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5617
5618 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5619 (ccl_driver): Do not generate an out-of-range pointer.
5620 (Fccl_execute_on_string): Remove unnecessary check for
5621 integer overflow, noted by Stefan Monnier in
5622 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5623 Remove a FIXME that didn't need fixing.
5624 Simplify the newly-introduced buffer reallocation code.
5625
0cae2cdb
JB
56262011-08-27 Juanma Barranquero <lekktu@gmail.com>
5627
5628 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5629
5fc295a4 56302011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5631
70c60eb2 5632 Integer and memory overflow issues (Bug#9196).
726e0ab1 5633
d31850da
PE
5634 * doc.c (get_doc_string): Rework so that
5635 get_doc_string_buffer_size is the actual buffer size, rather than
5636 being 1 less than the actual buffer size; this makes xpalloc more
5637 convenient.
5638
a69fbedb
PE
5639 * image.c (x_allocate_bitmap_record, cache_image):
5640 * xselect.c (Fx_register_dnd_atom):
5641 Simplify previous changes by using xpalloc.
5642
fe5c5d37
PE
5643 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5644 since either will do and ptrdiff_t is convenient with xpalloc.
5645
0065d054
PE
5646 * charset.c (charset_table_size)
5647 (struct charset_sort_data.priority): Now ptrdiff_t.
5648 (charset_compare): Don't overflow if priorities differ greatly.
5649 (Fsort_charsets): Don't assume list length fits in int.
5650 Check for size-calculation overflow when allocating sort data.
5651 (syms_of_charset): Allocate an initial charset table that is
5652 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5653
5654 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5655
5656 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5657 The actual value is always <= INT_MAX, and leaving it unsigned made
5658 overflow checking harder.
5659
5660 * dispextern.h (struct glyph_matrix.rows_allocated)
5661 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5662 with xpalloc. The values are still always <= INT_MAX.
5663
5664 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5665
5666 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5667 (SAFE_NALLOCA): New macro.
5668
5669 * region-cache.c (struct boundary.pos, find_cache_boundary)
5670 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5671 (set_cache_region, invalidate_region_cache)
5672 (revalidate_region_cache, know_region_cache, region_cache_forward)
5673 (region_cache_backward, pp_cache):
5674 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5675 so that ptrdiff_t * can be passed to xpalloc.
5676 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5677 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5678 (pp_cache): Don't assume cache_len fits in int.
5679 * region-cache.h: Adjust extern decls to match.
5680
5681 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5682 EMACS_INT, since either will do, for xpalloc.
5683
5684 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5685 (xnmalloc, xnrealloc, xpalloc): New functions.
5686
726e0ab1
PE
5687 * bidi.c (bidi_shelve_header_size): New constant.
5688 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5689 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5690
51f30bc5 5691 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5692 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5693 (overlay_strings):
5694 Don't update size of array until after memory allocation succeeds,
5695 because xmalloc/xrealloc may not return.
0065d054
PE
5696 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5697 now that we have proper integer overflow checking.
5698 (record_overlay_string, overlay_strings): Catch overflows when
5699 calculating size of overlay_str_buf.
726e0ab1 5700
0065d054
PE
5701 * callproc.c (Fcall_process): Check for size overflow when
5702 calculating size of args2.
5703 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5704 Normally we prefer signed values, but sticking with ptrdiff_t would
5705 require adding more-complicated checks.
726e0ab1
PE
5706
5707 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5708 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5709 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5710 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5711
5712 * character.c (Fstring): Check for size-calculation overflow.
5713
5714 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5715 unnecessary integer overflow. Check for size overflow.
5716 (encode_coding_object): Don't update size until xmalloc succeeds.
5717
5718 * composite.c (get_composition_id): Check for overflow in glyph
5719 length calculations.
5720
5721 Integer and memory overflow fixes for display code.
5722 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5723 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5724 (scrolling_window): Check for overflow in size calculations.
5725 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5726 Don't assume glyph table len fits in int.
5727 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5728 (row_table_size): Now ptrdiff_t, not int.
5729 (scrolling_window): Avoid overflow in size calculations.
5730 Don't update size until allocation succeeds.
5731 * fns.c (concat): Check for overflow in size calculations.
5732 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5733 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5734 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5735
5736 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5737 (get_doc_string): Check for size calculation overflow.
5738 Don't update size until allocation succeeds.
5739 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5740 EMACS_INT, where ptrdiff_t will do.
5741 (Fsubstitute_command_keys): Check for string overflow.
5742
5743 * editfns.c (set_time_zone_rule): Don't assume environment length
5744 fits in int.
5745 (message_length): Now ptrdiff_t, not int.
5746 (Fmessage_box): Don't update size until allocation succeeds.
5747 Don't assume message length fits in int.
5748 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5749
0065d054
PE
5750 * emacs.c (main): Do not reallocate argv, since there is a null at
5751 the end that can be overwritten, and this way there's no need to
5752 worry about size-calculation overflow.
5753 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5754
5755 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5756 alloc succeeds.
5757 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5758
5759 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5760 (x_set_scroll_bar_width, x_figure_window_size):
5761 Check for integer overflow.
5762 (x_set_alpha): Do not assume XINT fits in int.
5763
5764 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5765 This is for the members text_lines, text_cols, total_lines, total_cols,
5766 where the system imposes an 'int' limit.
5767
5768 * fringe.c (Fdefine_fringe_bitmap):
5769 Don't update size until alloc works.
5770
5771 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5772 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5773
5774 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5775 Check for size-calculation overflow.
5776 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5777 do, as we prefer signed integers.
5778 (id_to_widget.max_size, id_to_widget.used)
5779 (xg_store_widget_in_map, xg_remove_widget_from_map)
5780 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5781 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5782 Use and return ptrdiff_t, not int.
5783 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5784 * gtkutil.h: Change prototypes to match the above.
5785
5786 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5787 are duplicate now that they've been promoted to lisp.h.
5788 (x_allocate_bitmap_record, x_alloc_image_color)
5789 (make_image_cache, cache_image, xpm_load):
5790 Don't update size until alloc is done.
5791 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5792 (x_detect_edges):
3256efce 5793 Check for size calculation overflow.
726e0ab1
PE
5794 (ct_colors_allocated_max): New constant.
5795 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5796 overflow.
3256efce 5797
726e0ab1
PE
5798 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5799 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5800 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5801 Use ptrdiff_t, not int, to count maps.
5802 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5803 calculations. Don't update size until allocation succeeds.
5804 Redo calculations to avoid overflow.
726e0ab1
PE
5805 * keyboard.h: Change prototypes to match the above.
5806
5807 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5808 to count maps.
5809 (current_minor_maps): Check for size calculation overflow.
5810 * keymap.h: Change prototypes to match the above.
5811
5812 * lread.c (read1, init_obarray): Don't update size until alloc done.
5813
5814 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5815 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5816
726e0ab1
PE
5817 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5818 Now ptrdiff_t, not int.
5819 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5820 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5821
5822 * process.c (Fnetwork_interface_list): Check for overflow
5823 in size calculation.
5824
5825 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5826
5827 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5828 overflow. Don't bother calling xmalloc when xrealloc will do.
5829
5830 * search.c (Freplace_match): Check for size calculation overflow.
5831 (Fset_match_data): Don't assume list lengths fit in 'int'.
5832
5833 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5834 for command line length. Do not attempt to address one before the
5835 beginning of an array, as that's not portable.
5836
5837 * term.c (max_frame_lines): Remove; unused.
5838 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5839 not int.
5840 (encode_terminal_code, calculate_costs): Check for size
5841 calculation overflow.
5842 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5843 table lengths and related sizes. Don't update size until alloc
5844 done. Redo calculations to avoid overflow.
5845 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5846
5847 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5848 subtracting pointers.
5849 (gobble_line): Check for overflow more carefully. Don't update size
5850 until alloc done.
5851
5852 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5853 Don't update size until alloc done.
5854 Redo size calculations to avoid overflow.
5855 Check for size calculation overflow.
0065d054 5856 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5857
5858 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5859 Use ptrdiff_t, not int, for sizes.
5860 (store_mode_line_noprop_char): Don't update size until alloc done.
5861
0065d054
PE
5862 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5863 Use ptrdiff_t, not int, for sizes.
5864 (Finternal_make_lisp_face, cache_face):
5865 Check for size calculation overflow.
5866 (cache_face): Treat size calculation overflows as if they were
5867 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5868
5869 * xfns.c (x_encode_text, x_set_name_internal)
5870 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5871 sizes, since they can exceed INT_MAX in size. Check for size
5872 calculation overflow.
5873
0065d054
PE
5874 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5875 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5876 Don't update size until alloc done.
5877
0065d054 5878 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5879 as sprintf is limited to int lengths.
1d526e2f 5880
252c5ee1
PE
5881 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5882 (X_LONG_MIN): New macros.
864d7ce7
PE
5883 Use them to make the following changes clearer.
5884 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5885 This change doesn't affect the value now, but it may help remind
5886 future maintainers not to raise the value too much later.
5887 (SELECTION_QUANTUM): Remove, replacing with ...
5888 (selection_quantum): ... new function, which avoids overflow.
5889 All uses changed.
5890 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5891 assumption that selection length fits in 'int'.
5892 (x_reply_selection_request, x_handle_selection_request)
5893 (x_get_window_property, receive_incremental_selection)
5894 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5895 (lisp_data_to_selection_data, clean_local_selection_data):
5896 Use ptrdiff_t, not int, to record length of selection.
5897 (x_reply_selection_request, x_get_window_property)
5898 (receive_incremental_selection, x_property_data_to_lisp):
5899 Redo calculations to avoid overflow.
5900 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5901 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5902 something.
5903 (x_get_window_property, receive_incremental_selection)
5904 (lisp_data_to_selection_data, x_property_data_to_lisp):
5905 Check for size-calculation overflow.
5906 (x_get_window_property, receive_incremental_selection)
5907 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5908 Don't store size until memory allocation succeeds.
5909 (x_get_window_property): Plug memory leak on memory exhaustion.
5910 Don't double-block input; malloc is safe here. Don't assume 2**34
5911 - 4 fits in unsigned long. Add an xassert to check
5912 XGetWindowProperty overflow. Be more careful about overflow
5913 calculations, and distinguish size from memory overflow better.
5914 (receive_incremental_selection): When tracing, don't assume
5915 unsigned int is less than INT_MAX.
5916 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5917 harmful) conversions of unsigned short to int.
5918 (lisp_data_to_selection_data): Don't assume that integers
5919 in the range -65535 through -1 fit in an X unsigned short.
5920 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5921 result parameters unless successful. Rely on cons_to_unsigned
5922 to report problems with elements; the old code wasn't right anyway.
5923 (x_check_property_data): Check for int overflow; we cannot use
5924 a wider type due to X limits.
5925 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5926
726e0ab1 5927 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5928
0065d054
PE
5929 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5930 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5931 (x_color_cells): Don't store size until memory allocation succeeds.
5932 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5933 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5934 (x_term_init): Don't assume length fits in int (sprintf is limited
5935 to int size).
bc18e09d 5936
ebfa62c0
PE
5937 Use ptrdiff_t for composition IDs.
5938 * character.c (lisp_string_width):
5939 * composite.c (composition_table_size, n_compositions)
5940 (get_composition_id, composition_gstring_from_id):
5941 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5942 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5943 * window.c (Frecenter):
5944 Use ptrdiff_t, not int, for composition IDs.
5945 * composite.c (get_composition_id): Check for integer overflow.
5946 * composite.h: Adjust prototypes to match the above changes.
5947
d3411f89
PE
5948 Use ptrdiff_t for hash table indexes.
5949 * category.c (hash_get_category_set):
5950 * ccl.c (ccl_driver):
5951 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5952 * coding.c (coding_system_charset_list, detect_coding_system):
5953 * coding.h (struct coding_system.id):
5954 * composite.c (get_composition_id, gstring_lookup_cache):
5955 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5956 * image.c (xpm_get_color_table_h):
5957 * lisp.h (hash_lookup, hash_put):
5958 * minibuf.c (Ftest_completion):
5959 Use ptrdiff_t for hash table indexes, not int (which is too
5960 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5961 32-bit --with-wide-int hosts).
5962
e097a6fa
PE
5963 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5964 Add a FIXME comment about memory leaks.
5965 (syms_of_charset): Don't assume xmalloc returns.
5966
5637687f
PE
5967 Don't assume that stated character widths fit in int.
5968 * character.c (Fchar_width, c_string_width, lisp_string_width):
5969 * character.h (CHAR_WIDTH):
5970 * indent.c (MULTIBYTE_BYTES_WIDTH):
5971 Use sanitize_char_width to avoid undefined and/or bad behavior
5972 with outlandish widths.
a66cfb1c 5973 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5974 now that we have two such functions. All uses changed.
5975 (sanitize_char_width): New inline function.
5976
a2271ba2
PE
5977 Don't assume that tab-width fits in int.
5978 * character.h (sanitize_width): New inline function.
5979 (SANE_TAB_WIDTH): New macro.
5980 (ASCII_CHAR_WIDTH): Use it.
5981 * indent.c (sane_tab_width): Remove. All uses replaced by
5982 SANE_TAB_WIDTH (current_buffer).
5983 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5984
18c52557
PE
5985 * fileio.c: Integer overflow issues with file modes.
5986 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5987
caeeedc1
PE
5988 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5989 Remove unreachable code.
5990 (read_hex, load_charset_map_from_file): Check for integer overflow.
5991
6df6ae42 5992 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5993 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5994 (x_send_scroll_bar_event): Likewise. Check that the size does not
5995 exceed limits imposed by XClientMessageEvent, as well as the usual
5996 ptrdiff_t and size_t limits.
5997
b13995db
PE
5998 * keyboard.c: Overflow, signedness and related fixes.
5999 (make_lispy_movement): Use same integer type in forward decl
6000 that is used in the definition.
6001 (read_key_sequence, keyremap_step):
6002 Change bufsize argument back to int, undoing my 2011-03-30 change.
6003 We prefer signed types, and int is wide enough here.
6004 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6005 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6006 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6007 length, not size_t. Use ptrdiff_t for index, not int.
6008 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6009 possibility of integer overflow.
6010
13464394
PE
6011 Overflow, signedness and related fixes for images.
6012
6013 * dispextern.h (struct it.stack[0].u.image.image_id)
6014 (struct_it.image_id, struct image.id, struct image_cache.size)
6015 (struct image_cache.used, struct image_cache.ref_count):
6016 * gtkutil.c (update_frame_tool_bar):
6017 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6018 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6019 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6020 * nsmenu.m (update_frame_tool_bar):
6021 * xdisp.c (calc_pixel_width_or_height):
6022 * xfns.c (image_cache_refcount):
6023 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6024 on typical 64-bit hosts.
6025
6026 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6027 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6028 Omit unnecessary casts to int.
6029 (parse_image_spec): Check that integers fall into 'int' range
6030 when the callers expect that.
6031 (image_ascent): Redo ascent calculation to avoid int overflow.
6032 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6033 (lookup_image): Remove unnecessary tests.
6034 (xbm_image_p): Locals are now of int, not EMACS_INT,
6035 since parse_image_check makes sure they fit into int.
6036 (png_load, gif_load, svg_load_image):
6037 Prefer int to unsigned where either will do.
6038 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6039 old tiff_error_handler and tiff_warning_handler.
6040 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6041 stack buffer overflows. It uses only the features of vsnprintf
6042 that are common to both POSIX and native Microsoft.
6043 (tiff_error_handler, tiff_warning_handler): Use it.
6044 (tiff_load, gif_load, imagemagick_load_image):
6045 Don't assume :index value fits in 'int'.
6046 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6047 (imagemagick_load_image): Check that crop parameters fit into
6048 the integer types that MagickCropImage accepts. Don't assume
6049 Vimagemagick_render_type has a nonnegative value. Don't assume
6050 size_t fits in 'long'.
6051 (gs_load): Use printmax_t to print the widest integers possible.
6052 Check for integer overflow when computing image height and width.
6053
c11821d4
EZ
60542011-08-26 Eli Zaretskii <eliz@gnu.org>
6055
6056 * xdisp.c (redisplay_window): Don't force window start if point
6057 will be invisible in the resulting window. (Bug#9324)
6058
0c95fcf7
EZ
60592011-08-25 Eli Zaretskii <eliz@gnu.org>
6060
6061 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6062 the display spec is of the form `(space ...)'.
6063 (handle_display_spec): Return the value returned by
6064 handle_single_display_spec, not just 1 or zero.
6065 (handle_single_display_spec): If the display spec is of the form
6066 `(space ...)', and specifies display in the text area, return 2
6067 rather than 1.
fee65a97 6068 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6069 accurately, and prefer exact match for point under bidi.
6070 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6071
6072 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6073 into disp_prop; all users changed.
6074
6075 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6076 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6077 for the text covered by the display property.
6078
e4ed06f1
CY
60792011-08-25 Chong Yidong <cyd@stupidchicken.com>
6080
6081 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6082 Change return value to nil.
6083 (Frecord_buffer): Delete unused function.
6084
f67cdd7f
EZ
60852011-08-24 Eli Zaretskii <eliz@gnu.org>
6086
5980d4c6
EZ
6087 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6088 buffers, return left-to-right.
8610fe8b
EZ
6089 (set_cursor_from_row): Consider candidate row a win if its glyph
6090 represents a newline and point is on that newline. Fixes cursor
6091 positioning on the newline at EOL of R2L text within L2R
6092 paragraph, and vice versa.
6093 (try_cursor_movement): Check continued rows, in addition to
6094 continuation rows. Fixes unwarranted scroll when point enters a
6095 continued line of R2L text within an L2R paragraph, or vice versa.
6096 (cursor_row_p): Consider the case of point being equal to
6097 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6098 from the end of a short line to the beginning of a continued line
6099 of R2L text within L2R paragraph.
6100 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6101 composed characters.
5980d4c6 6102
f67cdd7f
EZ
6103 * bidi.c (bidi_check_type): Use xassert.
6104 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6105 members.
6106
bca633fb
EZ
61072011-08-23 Eli Zaretskii <eliz@gnu.org>
6108
6109 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6110 a character.
6111
4a5885a7
CY
61122011-08-23 Chong Yidong <cyd@stupidchicken.com>
6113
6114 * nsfont.m (ns_otf_to_script): Fix typo.
6115
0902a04e
KH
61162011-08-22 Kenichi Handa <handa@m17n.org>
6117
6118 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6119 extra slot even if the purpose is char-code-property-table.
6120
1a2e6670
EZ
61212011-08-23 Eli Zaretskii <eliz@gnu.org>
6122
8ddde651
EZ
6123 * xdisp.c (redisplay_window): When computing centering_position,
6124 account for the height of the header line. (Bug#8874)
6125
425cc014
EZ
6126 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6127 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6128 candidate is selected by the mouse, and that candidate has a
6129 composed character under the mouse.
6130
1a2e6670
EZ
6131 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6132 coordinates reported by pos-visible-in-window-p for a composed
6133 character in column zero.
6134
8b76d6f8
SM
61352011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6136
6137 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6138
dac347dd
EZ
61392011-08-22 Eli Zaretskii <eliz@gnu.org>
6140
6141 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6142 consider it a hit if to_charpos is anywhere in the range of the
6143 composed buffer positions.
6144
e013fb34
CY
61452011-08-22 Chong Yidong <cyd@stupidchicken.com>
6146
6147 * image.c (gif_load): Don't assume that each subimage has the same
6148 dimensions as the base image. Handle disposal method that is
6149 "undefined" by the gif spec (Bug#9335).
6150
bd1ba3e8
CY
61512011-08-20 Chong Yidong <cyd@stupidchicken.com>
6152
6153 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6154 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6155
54a1215b
EZ
61562011-08-19 Eli Zaretskii <eliz@gnu.org>
6157
823564e5
EZ
6158 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6159 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6160 from an Org mode buffer to a Speedbar frame.
6161
54a1215b
EZ
6162 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6163 a composition, take its buffer position from IT->cmp_it.charpos.
6164 Fixes cursor positioning at the beginning of a line that begins
6165 with a composed character.
6166
9778ebcc
EZ
61672011-08-18 Eli Zaretskii <eliz@gnu.org>
6168
0be6ee06
EZ
6169 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6170 character bidirectional type, use STRONG_L instead. Fixes crashes
6171 in a buffer produced by `describe-categories'.
6172
9778ebcc
EZ
6173 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6174 members before the level stack, so they would be saved and
6175 restored when copying iterator state. Fixes incorrect reordering
6176 around TABs covered by display properties.
6177
156bffbe
AS
61782011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6179
6b02f655 6180 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6181
72ad093b
CY
61822011-08-17 Chong Yidong <cyd@stupidchicken.com>
6183
6184 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6185 (internal_condition_case_2, internal_condition_case_n):
6186 Remove unnecessary aborts (Bug#9081).
72ad093b 6187
35774242
EZ
61882011-08-17 Eli Zaretskii <eliz@gnu.org>
6189
6190 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6191 has no `load' handler, try opening the file locally. (Bug#9311)
6192
db76dd85
KB
61932011-08-16 Ken Brown <kbrown@cornell.edu>
6194
6195 * gmalloc.c: Expand comment.
6196
b215eee5
EZ
61972011-08-16 Eli Zaretskii <eliz@gnu.org>
6198
6199 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6200 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6201
a4579d33
KB
62022011-08-16 Ken Brown <kbrown@cornell.edu>
6203
6204 Fix memory allocation problems in Cygwin build (Bug#9273).
6205
6206 * unexcw.c ( __malloc_initialized): Declare external variable.
6207 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6208
8b76d6f8
SM
6209 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6210 New variables.
a4579d33
KB
6211 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6212 dumped emacs.
6213 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6214 in the static heap.
6215 [CYGWIN] (special_realloc): New function.
6216 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6217 requests to realloc storage in the static heap.
6218
3ebec551
PE
62192011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6220
6221 * bidi.c (bidi_initialize): Remove unused local.
6222
9fd8be00
EZ
62232011-08-15 Eli Zaretskii <eliz@gnu.org>
6224
6b02f655
SM
6225 * bidimirror.h:
6226 * biditype.h: Remove file.
6227 * makefile.w32-in ($(BLD)/bidi.$(O)):
6228 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6229
6230 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6231
6232 * chartab.c: Improve commentary for the uniprop_table API.
6233
32413314
EZ
6234 * bidi.c (bidi_paragraph_init): Support zero value of
6235 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6236 (bidi_initialize): Use uniprop_table instead of including
6237 biditype.h and bidimirror.h.
32413314 6238
9fd8be00
EZ
6239 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6240 coordinates of the iterator when restoring from ppos_it.
6241 (Bug#9296)
6242
5cf2b69b
KH
62432011-08-14 Kenichi Handa <handa@m17n.org>
6244
6245 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6246 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6247
daf17d00
EZ
62482011-08-14 Eli Zaretskii <eliz@gnu.org>
6249
6250 * xdisp.c (move_it_in_display_line_to): Don't invoke
6251 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6252 ppos_it. Fixes vertical cursor motion when line beginning is
6253 covered by an image. (Bug#9296)
6254
08e3161a
JD
62552011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6256
6257 * nsterm.h (ns_run_ascript): Declare.
6258 (NSAPP_DATA2_RUNASSCRIPT): Define.
6259
6260 * nsfns.m (as_script, as_result, as_status): New static variables.
6261 (ns_run_ascript): New function.
5e617bc2 6262 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6263 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6264 the event loop. Get status from as_status (Bug#7276).
6265
6266 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6267 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6268 the event loop (Bug#7276).
6269
a3720aa2
AS
62702011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6271
6272 * gnutls.c (QCgnutls_bootprop_priority)
6273 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6274 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6275 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6276 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6277 (QCgnutls_bootprop_verify_hostname_error)
6278 (QCgnutls_bootprop_callbacks_verify): Rename from
6279 Qgnutls_bootprop_..., all uses changed.
6280
6281 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6282 uses changed.
6283
0a0d27fb
PE
62842011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6285
19d5c50c
PE
6286 * xfaces.c (Qframe_set_background_mode): Now static.
6287 * dispextern.h (Qframe_set_background_mode): Remove decl.
6288
0a0d27fb
PE
6289 * process.c (Fnetwork_interface_info): Declare local only if needed.
6290
377538cb
JD
62912011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6292
6293 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6294 (Fnetwork_interface_list): Allocate in increments of bytes instead
6295 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6296 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6297 sockaddr.
6298 (struct ifflag_def): notrailers is smart on OSX.
6299 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6300 Get hardware address with getifaddrs if available.
6301
08fff70c
EZ
63022011-08-12 Eli Zaretskii <eliz@gnu.org>
6303
6304 * xdisp.c (iterate_out_of_display_property): xassert that
6305 IT->position is set to within IT->object's boundaries. Break from
6306 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6307 when IT->position is set up wrongly due to some bug.
6308 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6309 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6310 entry. Force push_it to save on the stack the current
6311 buffer/string position, to be restored by pop_it. Fix flags in
6312 the iterator structure wrt the object coming from a display
6313 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6314 properties. (Bug#9284)
6315
7be1c708 63162011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6317
7be1c708
CY
6318 * fontset.c (fontset_get_font_group): Add proper type checks.
6319 (Bug#9172)
aac0c6e3 6320
7be1c708 63212011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6322
7be1c708
CY
6323 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6324 and LC_VERSION_MIN_MACOSX.
6325 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6326 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6327
97bb72a6
EZ
63282011-08-08 Eli Zaretskii <eliz@gnu.org>
6329
6330 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6331 no-display-properties-and-no-overlays under bidi display.
6332 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6333 properties and overlays.
97bb72a6 6334
d5617611
CY
63352011-08-08 Chong Yidong <cyd@stupidchicken.com>
6336
37e11a63
CY
6337 * editfns.c (Fset_time_zone_rule): Document relationship with the
6338 setenv function.
6339
d5617611
CY
6340 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6341 the font entity extracted from the cache (Bug#8109).
6342
58872834
CY
63432011-08-07 Chong Yidong <cyd@stupidchicken.com>
6344
6345 * composite.c (autocmp_chars): Don't reset point. That is done by
6346 restore_point_unwind (Bug#5984).
6347
75bfc667
JL
63482011-08-07 Juri Linkov <juri@jurta.org>
6349
6350 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6351 to show the arg `TIME' instead of `TIMEVAL'.
6352
d1410150
EZ
63532011-08-06 Eli Zaretskii <eliz@gnu.org>
6354
6355 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6356 display property strides EOL and includes a newline, as in
6357 longlines-mode. (Bug#9254)
75b771e4
EZ
6358 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6359 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6360
6361 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6362 is non-zero, even if the data buffer is NULL. Fixes a crash in
6363 vertical-motion with longlines-mode. (Bug#9254)
6364
35928349
EZ
63652011-08-05 Eli Zaretskii <eliz@gnu.org>
6366
ec7cc85b
EZ
6367 * bidi.c <bidi_cache_total_alloc>: Now static.
6368 (bidi_initialize): Initialize bidi_cache_total_alloc.
6369
8b76d6f8 6370 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6371 cache. (Bug#9221)
6372
6373 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6374 amount allocated this far in `bidi_cache_total_alloc'.
6375 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6376 non-zero, only free the data buffer without restoring the cache
6377 contents. All callers changed.
6378
6379 * dispextern.h (bidi_unshelve_cache): Update prototype.
6380
6381 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6382 (move_it_in_display_line, move_it_to)
6383 (move_it_vertically_backward, move_it_by_lines): Replace the call
6384 to xfree to an equivalent call to bidi_unshelve_cache.
6385 (move_it_in_display_line_to): Fix logic of returning
412b6358 6386 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6387
e2e2423b
EZ
63882011-08-05 Eli Zaretskii <eliz@gnu.org>
6389
6390 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6391 came from a string character with a `cursor' property. (Bug#9229)
6392
ae9e757a
JD
63932011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6394
6395 * Makefile.in (LIB_PTHREAD): New variable.
6396 (LIBES): Add LIB_PTHREAD (Bug#9216).
6397
6398 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6399 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6400
213bd7f2
AS
64012011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6402
6b02f655 6403 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6404
99aaf75f
JD
64052011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6406
6407 * xterm.c (x_find_topmost_parent): New function.
6408 (x_set_frame_alpha): Find topmost parent window with
6409 x_find_topmost_parent and set the property there also (bug#9181).
6410 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6411
c74e9d86
PE
64122011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6413
6414 * callproc.c (Fcall_process): Avoid vfork clobbering
6415 the local vars buffer, coding_systems, current_dir.
6416
640c8776
SM
64172011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6418
6419 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6420
f26d0e4c
PE
64212011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6422
8a10d76c
PE
6423 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6424 so that it is not optimized away.
6425
f26d0e4c
PE
6426 * xdisp.c (compute_display_string_pos): Remove unused local.
6427
55439c61
EZ
64282011-08-02 Eli Zaretskii <eliz@gnu.org>
6429
6430 Fix slow cursor motion and scrolling in large buffers with
6431 selective display, like Org Mode buffers. (Bug#9218)
6432
6433 * dispextern.h (struct bidi_it): New member disp_prop_p.
6434
6435 * xdisp.c: Remove one-slot cache of display string positions.
6436 (compute_display_string_pos): Accept an additional argument
5e617bc2 6437 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6438 for a display string or property. If found, set DISP_PROP_P
6439 non-zero.
6440
6441 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6442 DISP_PROP_P, and pass it to compute_display_string_pos.
6443 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6444 non-zero. All callers of bidi_fetch_char changed.
6445
fb33fa43
SM
64462011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6447
6448 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6449
b099e063
DM
64502010-12-03 Don March <don@ohspite.net>
6451
6452 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6453 last character M-[char] is translated to ESC [char] (bug#7541).
6454
5cc7f7af
KH
64552011-08-02 Kenichi Handa <handa@m17n.org>
6456
d0fffa3f 6457 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6458
6459 * chartab.c (uniprop_table): Make it non-static.
6460
525d5e6e
EZ
64612011-08-01 Eli Zaretskii <eliz@gnu.org>
6462
6463 * xdisp.c (forward_to_next_line_start): Accept additional argument
6464 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6465 on the newline.
6466 (reseat_at_next_visible_line_start): Use the bidi iterator state
6467 returned by forward_to_next_line_start to restore the state of
6468 it->bidi_it after backing up to previous newline. (Bug#9212)
6469
31011111
AS
64702011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6471
6472 * regex.c (re_comp): Protoize.
6473 (re_exec): Fix return type.
6474 (regexec): Fix type of `ret'. (Bug#9203)
6475
476371c4
PE
64762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6477
e5d76069
PE
6478 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6479 This is needed if max-image-size is a floating-point number.
6480
9a79b20c
AS
64812011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6482
6483 * print.c (print_object): Print empty symbol as ##.
6484
6485 * lread.c (read1): Read ## as empty symbol.
6486
d8c2fa78
AA
64872011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6488
6489 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6490 setting frame foreground color (Bug#9175).
6491 (x_set_background_color): Likewise.
6492
ffe57a7a
AA
6493 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6494 contents (Bug#9176).
6495 (EmacsTooltip -init): Remove bezels and add shadows to
6496 tooltip windows.
6497
bf3492a5
AA
6498 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6499 or scroll bar (Bug#8470).
6500
d55e9c53
AA
6501 * nsfont.m (nsfont_open): Remove assignment to voffset and
6502 unnecessary vars hshink, expand, hd, full_height, min_height.
6503 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6504
6505 * nsterm.h (nsfont_info): Remove voffset field.
6506
d8c2fa78 65072011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6508
6509 Implement strike-through and overline on NextStep (Bug#8863).
6510
6511 * nsfont.m (nsfont_open): Use underline position provided by font,
6512 instead of hard-coded value of 2.
6513 (nsfont_draw): Call ns_draw_text_decoration instead.
6514
6515 * nsterm.h: Add declaration for ns_draw_text_decoration.
6516
6517 * nsterm.m (ns_draw_text_decoration): New function for drawing
6518 underline, overline, and strike-through.
6519 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6520 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6521 accommodate underlining, etc.
4843aac3 6522
4cc60b9b
EZ
65232011-07-28 Eli Zaretskii <eliz@gnu.org>
6524
bc7ece87
EZ
6525 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6526 default.
4cc60b9b 6527
476371c4
PE
65282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6529
66606eea
PE
6530 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6531 Without this fix, if a signal arrives just after memory fills up,
6532 'malloc' might be invoked reentrantly.
6533
476371c4
PE
6534 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6535 In other words, assume that every image size is allowed, on non-X
6536 hosts. This assumption is probably wrong, but it lets Emacs compile.
6537
f3fcc40d
AS
65382011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6539
6540 * regex.c (re_iswctype): Convert return values to boolean.
6541
350c992f
EZ
65422011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6543
6544 * xdisp.c (compute_display_string_pos): Don't use cached display
6545 string position if the buffer had its restriction changed.
6546 (Bug#9184)
6547
5266b4bb
PE
65482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6549
6550 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6551
2573a837 65522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6553
41f55ccd 6554 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6555
39e378da
PE
6556 * bidi.c: Integer size and overflow fixes.
6557 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6558 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6559 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6560 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6561 (bidi_find_other_level_edge):
6562 Use ptrdiff_t instead of EMACS_INT where either will do.
6563 This works better on 32-bit hosts configured --with-wide-int.
6564 (bidi_cache_ensure_space): Check for size-calculation overflow.
6565 Use % rather than repeated addition, for better worst-case speed.
6566 Don't set bidi_cache_size until after xrealloc returns, because it
6567 might not return.
6568 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6569 (bidi_cache_ensure_space): Also check that the bidi cache size
6570 does not exceed that of the largest Lisp string or buffer. See Eli
6571 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6572
5e927815
PE
6573 * alloc.c (__malloc_size_t): Remove.
6574 All uses replaced by size_t. See Andreas Schwab's note
6575 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6576
ca4aa935
PE
6577 * image.c: Improve checking for integer overflow.
6578 (check_image_size): Assume that f is nonnull, since
6579 it is always nonnull in practice. This is one less thing to
6580 worry about when checking for integer overflow later.
6581 (x_check_image_size): New function, which checks for integer
6582 overflow issues inside X.
6583 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6584 This removes the need for a memory_full check.
6585 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6586 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6587 (xbm_read_bitmap_data): Change locals back to 'int', since
6588 their values must fit in 'int'.
6589 (xpm_load_image, png_load, tiff_load):
6590 Invoke x_create_x_image_and_pixmap earlier,
6591 to avoid much needless work if the image is too large.
6592 (tiff_load): Treat overly large images as if
6593 x_create_x_image_and_pixmap failed, not as malloc failures.
6594 (gs_load): Use x_check_image_size.
6595
5f8f9cc2
PE
6596 * gtkutil.c: Omit integer casts.
6597 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6598 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6599
5adf60bc
PE
6600 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6601
c8907a93
PE
6602 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6603 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6604 would wrongly return t on a 64-bit host.
6605
e3c25c68
PE
6606 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6607 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6608 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6609 and therefore cause GCC to emit a bogus diagnostic in some cases.
6610
3f791afe
PE
6611 * image.c: Integer signedness and overflow and related fixes.
6612 This is not an exhaustive set of fixes, but it's time to
6613 record what I've got.
6614 (lookup_pixel_color, check_image_size): Remove redundant decls.
6615 (check_image_size): Don't assume that arbitrary EMACS_INT values
6616 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6617 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6618 (tiff_load, imagemagick_load_image):
6619 Check for overflow in size calculations.
6620 (x_create_x_image_and_pixmap): Remove unnecessary test for
6621 xmalloc returning NULL; that can't happen.
6622 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6623 (xpm_color_bucket): Use better integer hashing function.
6624 (xpm_cache_color): Don't possibly over-allocate memory.
6625 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6626 (gif_memory_source):
6627 Use ptrdiff_t, not int or size_t, to record sizes.
6628 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6629 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6630 either works, as we prefer signed integers.
6631 (tiff_read_from_memory, tiff_write_from_memory):
6632 Return tsize_t, not size_t, since that's what the TIFF API wants.
6633 (tiff_read_from_memory): Don't fail simply because the read would
6634 go past EOF; instead, return a short read.
6635 (tiff_load): Omit no-longer-needed casts.
6636 (Fimagemagick_types): Don't assume size fits into 'int'.
6637
3cc5a532
PE
6638 Improve hashing quality when configured --with-wide-int.
6639 * fns.c (hash_string): New function, taken from sxhash_string.
6640 Do not discard information about ASCII character case; this
6641 discarding is no longer needed.
6642 (sxhash-string): Use it. Change sig to match it. Caller changed.
6643 * lisp.h: Declare it.
6644 * lread.c (hash_string): Remove, since we now use fns.c's version.
6645 The fns.c version returns a wider integer if --with-wide-int is
6646 specified, so this should help the quality of the hashing a bit.
6647
b312a492
PE
6648 * emacs.c: Integer overflow minor fix.
6649 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6650 Define only if GNU_LINUX.
6651 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6652
dfd153ae
PE
6653 * dispnew.c: Integer signedness and overflow fixes.
6654 Remove unnecessary forward decls, that were a maintenance hassle.
6655 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6656 All uses changed.
6657 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6658 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6659 (prepare_desired_row, line_draw_cost):
6660 Use int, not unsigned, where either works.
6661 (save_current_matrix, restore_current_matrix):
6662 Use ptrdiff_t, not size_t, where either works.
6663 (init_display): Check for overflow more accurately, and without
6664 relying on undefined behavior.
6665
a81d11a3
PE
6666 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6667 Remove, replacing with the new symbols in lisp.h. All uses changed.
6668 * fileio.c (make_temp_name):
6669 * filelock.c (lock_file_1, lock_file):
6670 * xdisp.c (message_dolog):
6671 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6672 Use pMd etc. instead.
6673 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6674 replacing the pWIDE etc. symbols removed from editfns.c.
6675
3300e6fd
PE
6676 * keyboard.h (num_input_events): Now uintmax_t.
6677 This is (very slightly) less likely to mess up due to wraparound.
6678 All uses changed.
6679
fd05c7e9
PE
6680 * buffer.c: Integer signedness fixes.
6681 (alloc_buffer_text, enlarge_buffer_text):
6682 Use ptrdiff_t rather than size_t when either will do, as we prefer
6683 signed integers.
6684
903fe15d
PE
6685 * alloc.c: Integer signedness and overflow fixes.
6686 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6687 (__malloc_size_t): Default to size_t, not to int.
6688 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6689 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6690 Prefer ptrdiff_t to size_t when either would do, as we prefer
6691 signed integers.
6692 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6693 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6694 Now const. Initialize with values that are in range even if char
6695 is signed.
6696 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6697 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6698 These functions do the right thing with sizes > 2**32.
6699 (check_depth): Now ptrdiff_t, not int.
6700 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6701 Adjust to new way of storing sizes. Check for size overflow bugs
6702 in rest of code.
6703 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6704 slightly wrong anyway, as it missed one instance of
6705 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6706 (refill_memory_reserve): Omit needless cast to size_t.
6707 (mark_object_loop_halt): Mark as externally visible.
6708
ac82cc6a
PE
6709 * xselect.c: Integer signedness and overflow fixes.
6710 (Fx_register_dnd_atom, x_handle_dnd_message):
6711 Use ptrdiff_t, not size_t, since we prefer signed.
6712 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6713 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6714 x_dnd_atoms_size and x_dnd_atoms_length.
6715
c2d1e36d
PE
6716 * doprnt.c: Prefer signed to unsigned when either works.
6717 * eval.c (verror):
6718 * doprnt.c (doprnt):
6719 * lisp.h (doprnt):
6720 * xdisp.c (vmessage):
6721 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6722 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6723 prefer signed arithmetic to avoid comparison confusion.
6724 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6725 but is a bit tricky.
6726
0e926e56
PE
6727 Assume freestanding C89 headers, string.h, stdlib.h.
6728 * data.c, doprnt.c, floatfns.c, print.c:
6729 Include float.h unconditionally.
6730 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6731 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6732 * regex.c: Likewise for stddef.h, string.h.
6733 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6734 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6735 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6736 (STDC_HEADERS): Remove obsolete defines.
6737 * sysdep.c: Include limits.h unconditionally.
6738
9cfdb3ec
PE
6739 Assume support for memcmp, memcpy, memmove, memset.
6740 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6741 * regex.c (memcmp, memcpy):
6742 Remove; we assume C89 now.
6743
6744 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6745 (__malloc_safe_bcopy): Remove; no longer needed.
6746
cf950e6b 6747 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6748 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6749 well either way, and we prefer signed to unsigned.
6750
dbf38e02
LMI
67512011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6752
6753 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6754 closes the connection while we're reading (bug#9182).
6755
d6f0886c 67562011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6757
d6f0886c
JD
6758 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6759 are specified (Bug#9168).
24e0f6b1 6760
2eb1f9e6
PE
67612011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6762
6763 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6764 Found by GCC static checking and --with-wide-int on a 32-bit host.
6765
22381272 67662011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6767
6768 * xdisp.c (compute_display_string_pos): Fix logic of caching
6769 previous display string position. Initialize cached_prev_pos to
6770 -1. Fixes slow-down at the beginning of a buffer.
6771
f25e39b4
EZ
67722011-07-24 Eli Zaretskii <eliz@gnu.org>
6773
6774 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6775 for attrs[LFACE_FONTSET_INDEX].
6776
04c4b52e
PE
67772011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6778
6779 * xml.c (parse_region): Remove unused local
6780 that was recently introduced.
6781
c1734fbd
EZ
67822011-07-23 Eli Zaretskii <eliz@gnu.org>
6783
be18c5a5
EZ
6784 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6785 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6786
c1734fbd
EZ
6787 * xdisp.c (move_it_in_display_line_to): Record the best matching
6788 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6789 exit if none of the characters scanned was an exact match.
6790 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6791 when exact match is impossible due to invisible text, and the
6792 lines are truncated.
6793
a258d627
JD
67942011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6795
6796 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6797 for OSX >= 10.7.
6798
b6d5a689
EZ
67992011-07-22 Eli Zaretskii <eliz@gnu.org>
6800
0f74f785
EZ
6801 Fix a significant slow-down of cursor motion with C-n, C-p,
6802 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6803 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6804 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6805 (next_element_from_buffer): Call compute_stop_pos_backwards to
6806 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6807 base_level_stop.
6808 (reseat): Don't look for prev_stop, as that could mean a very long
6809 run.
6810 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6811 <cached_disp_overlay_modiff>: Cache for last found display string
6812 position.
551918c1 6813 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6814 about the same buffer in the same area of character positions, and
6815 the buffer wasn't changed since the time the display string
6816 position was cached.
551918c1 6817
b2d0c91a
EZ
68182011-07-22 Eli Zaretskii <eliz@gnu.org>
6819
6820 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6821 is an integer, which is important for empty lines. (Bug#9149)
6822
043604ee
CY
68232011-07-22 Chong Yidong <cyd@stupidchicken.com>
6824
6825 * frame.c (Fmodify_frame_parameters): In tty case, update the
6826 default face if necessary (Bug#4238).
6827
da4adb04
CY
68282011-07-21 Chong Yidong <cyd@stupidchicken.com>
6829
6830 * editfns.c (Fstring_to_char): No need to explain what a character
6831 is in the docstring (Bug#6576).
6832
9abd0532
LMI
68332011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6834
6835 * xml.c (parse_region): Make sure we always return a tree.
6836
36881d16
HK
68372011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6838
6839 * xml.c (parse_region): If a document contains only comments,
6840 return that, too.
6841
1e98674d
LMI
68422011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6843
6844 * xml.c (make_dom): Return comments, too.
6845
590bd467
PE
68462011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6847
6848 Port to OpenBSD.
6849 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6850 and the surrounding thread.
6851 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6852 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6853 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6854 timer goes off.
6855 * s/openbsd.h (BROKEN_SIGIO): Define.
6856 * unexelf.c (unexec) [__OpenBSD__]:
6857 Don't update the .mdebug section of the Alpha COFF symbol table.
6858
f41628b2
LMI
68592011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6860
6861 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6862 (bug#8460).
6863
b59b67c5
PE
68642011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6865
15e3a074
PE
6866 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6867 This fixes some race conditions on the permissions of any newly
6868 created file.
6869
41bed37d
PE
6870 * alloc.c (valid_pointer_p): Use pipe, not open.
6871 This fixes some permissions issues when debugging.
6872
b59b67c5
PE
6873 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6874 If fchown fails to set both uid and gid, try to set just gid,
6875 as that is sometimes allowed. Adjust the file's mode to eliminate
6876 setuid or setgid bits that are inappropriate if fchown fails.
6877
925a6be7
SM
68782011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6879
6880 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6881 to compare Lisp_Objects.
6882 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6883 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6884 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6885
52968808
AS
68862011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6887
0a6a104b
AS
6888 * lread.c (read_integer): Unread even EOF character.
6889 (read1): Likewise. Properly record start position of symbol.
6890
52968808
AS
6891 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6892 symbol character follows.
6893
9e381cdd
PE
68942011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6895
6896 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6897 This works around a problem with the previous change to Fcopy_file.
6898 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6899 and without this change, GCC might complain about discarding
6900 fchown's return value.
6901
b5641435
JB
69022011-07-16 Juanma Barranquero <lekktu@gmail.com>
6903
6904 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6905
a8031457
PE
69062011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6907
6908 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6909
dd889327
LMI
69102011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6911
750c33f7
LMI
6912 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6913 it's used from the C level.
6914
dd889327
LMI
6915 * process.c: Use the same condition for POLL_FOR_INPUT in both
6916 keyboard.c and process.c (bug#1858).
6917
87e86684
LM
69182011-07-09 Lawrence Mitchell <wence@gmx.li>
6919
6920 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6921 (Fgnutls_boot): Use it.
6922
64348f40
AS
69232011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6924
6925 * doc.c (Fsubstitute_command_keys): Revert last change.
6926
1d698799
LMI
69272011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6928
f863868c
LMI
6929 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6930 quotes the next character, and doesn't affect other longer
6931 sequences (bug#8935).
6932
1d698799
LMI
6933 * lread.c (syms_of_lread): Clarify that is isn't only
6934 `eval-buffer' and `eval-defun' that's affected by
6935 `lexical-binding' (bug#8460).
6936
aa4b6df6
EZ
69372011-07-15 Eli Zaretskii <eliz@gnu.org>
6938
6939 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6940 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6941
5d856da6
PE
69422011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6943
ad6042bb
PE
6944 Fix minor problems found by static checking.
6945 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6946 (elsz): Now a signed constant, not a size_t var. We prefer signed
6947 types to unsigned, to avoid integer comparison confusion. Without
6948 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6949 "cannot optimize loop, the loop counter may overflow", a symptom
6950 of the confusion.
f00bbb22 6951 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6952 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6953
6468f31c
LMI
69542011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6955
49080b10
LMI
6956 * search.c (Fre_search_backward): Mention `case-fold-search' in
6957 all the re_search_* functions (bug#8138).
6958
6468f31c
LMI
6959 * keyboard.c (Fopen_dribble_file): Document when the file is
6960 closed (bug#8056).
6961
c965adc5
EZ
69622011-07-14 Eli Zaretskii <eliz@gnu.org>
6963
df9733bf
EZ
6964 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6965 bidi_cache_idx.
6966
0bb23927
EZ
6967 Support bidi reordering of display and overlay strings.
6968 * xdisp.c (compute_display_string_pos)
6969 (compute_display_string_end): Accept additional argument STRING.
6970 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6971 (reseat_to_string): Initialize bidi_it->string.s and
6972 bidi_it->string.schars.
6973 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6974 NULL (avoids a crash in bidi_paragraph_init).
6975 Initialize itb.string.lstring.
0bb23927
EZ
6976 (init_iterator): Call bidi_init_it only of a valid
6977 buffer position was specified. Initialize paragraph_embedding to
6978 L2R.
6979 (reseat_to_string): Initialize the bidi iterator.
6980 (display_string): If we need to ignore text properties of
6981 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6982 original value of -1 will not work with bidi.)
6983 (compute_display_string_pos): First arg is now struct
6984 `text_pos *'; all callers changed. Support display properties on
6985 Lisp strings.
6986 (compute_display_string_end): Support display properties on Lisp
6987 strings.
6988 (init_iterator, reseat_1, reseat_to_string): Initialize the
6989 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6990 when iterating on a string not from display properties).
640c8776
SM
6991 (compute_display_string_pos, compute_display_string_end):
6992 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6993 arrow keys.
6994 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6995 base_level_stop; instead, set base_level_stop to BEGV.
6996 Fixes crashes in vertical-motion.
0bb23927
EZ
6997 (next_element_from_buffer): Improve commentary for when
6998 the iterator is before prev_stop.
6999 (init_iterator): Initialize bidi_p from the default value of
7000 bidi-display-reordering, not from buffer-local value. Use the
7001 buffer-local value only if initializing for buffer iteration.
7002 (handle_invisible_prop): Support invisible properties on strings
7003 that are being bidi-reordered.
7004 (set_iterator_to_next): Support bidi reordering of C strings and
7005 Lisp strings.
7006 (next_element_from_string): Support bidi reordering of Lisp
7007 strings.
7008 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7009 (display_string): Support display of R2L glyph rows.
7010 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7011 (init_iterator): Don't initialize it->bidi_p for strings
7012 here.
7013 (reseat_to_string): Initialize it->bidi_p for strings here.
7014 (next_element_from_string, next_element_from_c_string)
7015 (next_element_from_buffer): Add xassert's for correspondence
7016 between IT's object being iterated and it->bidi_it.string
7017 structure.
7018 (face_before_or_after_it_pos): Support bidi iteration.
7019 (next_element_from_c_string): Handle the case of the first string
7020 character that is not the first one in the visual order.
7021 (get_visually_first_element): New function, refactored from common
7022 parts of next_element_from_buffer, next_element_from_string, and
7023 next_element_from_c_string.
7024 (tool_bar_lines_needed, redisplay_tool_bar)
7025 (display_menu_bar): Force left-to-right direction. Add a FIXME
7026 comment for making that be controlled by a user option.
7027 (push_it, pop_it): Save and restore the state of the
7028 bidi iterator. Save and restore the bidi_p flag.
7029 (pop_it): Iterate out of display property for string iteration as
7030 well.
7031 (iterate_out_of_display_property): Support iteration over strings.
7032 (handle_single_display_spec): Set up it->bidi_it for iteration
7033 over a display string, and call bidi_init_it.
7034 (handle_single_display_spec, next_overlay_string)
7035 (get_overlay_strings_1, push_display_prop): Set up the bidi
7036 iterator for displaying display or overlay strings.
7037 (forward_to_next_line_start): Don't use the shortcut if
7038 bidi-iterating.
7039 (back_to_previous_visible_line_start): If handle_display_prop
7040 pushed the iterator stack, restore the internal state of the bidi
7041 iterator by calling bidi_pop_it same number of times.
7042 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7043 and we are bidi-iterating, don't decrement the iterator position;
7044 instead, set the first_elt flag in the bidi iterator, to produce
7045 the same effect.
7046 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7047 (push_display_prop): xassert that we are iterating a buffer.
7048 (push_it, pop_it): Save and restore paragraph_embedding member.
7049 (handle_single_display_spec, next_overlay_string)
7050 (get_overlay_strings_1, reseat_1, reseat_to_string)
7051 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7052 correctly. Don't assume unibyte strings are not bidi-reordered.
7053 (compute_display_string_pos)
7054 (compute_display_string_end): Fix handling the case of C string.
7055 (push_it, pop_it): Save and restore from_disp_prop_p.
7056 (handle_single_display_spec, push_display_prop): Set the
7057 from_disp_prop_p flag.
7058 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7059 (pop_it): Call iterate_out_of_display_property only if we are
7060 popping after iteration over a string that came from a display
7061 property. Fix a typo in popping stretch info. Add an assertion
7062 for verifying that the iterator position is in sync with the bidi
7063 iterator.
7064 (handle_single_display_spec, get_overlay_strings_1)
7065 (push_display_prop): Fix initialization of paragraph direction for
7066 string when that of the parent object is not yet determined.
7067 (reseat_1): Call bidi_init_it to resync the bidi
7068 iterator with IT's position. (Bug#7616)
7069 (find_row_edges): If ROW->start.pos gives position
7070 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7071 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7072 Reset the from_disp_prop_p flag.
7073 (SAVE_IT, RESTORE_IT): New macros.
7074 (pos_visible_p, face_before_or_after_it_pos)
7075 (back_to_previous_visible_line_start)
7076 (move_it_in_display_line_to, move_it_in_display_line)
7077 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7078 (try_scrolling, redisplay_window, display_line): Use them when
7079 saving a temporary copy of the iterator and restoring it back.
7080 (back_to_previous_visible_line_start, reseat_1)
7081 (init_iterator): Empty the bidi cache "stack".
7082 (move_it_in_display_line_to): If iterator ended up at
7083 EOL, but we never saw any buffer positions smaller than
7084 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7085 motion in bidi-reordered lines.
7086 (move_it_in_display_line_to): Record prev_method and prev_pos
7087 immediately before the call to set_iterator_to_next. Fixes cursor
7088 motion in bidi-reordered lines with stretch glyphs and strings
7089 displayed in margins. (Bug#8133) (Bug#8867)
7090 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7091 TO_CHARPOS.
640c8776
SM
7092 (pos_visible_p): Support positions in bidi-reordered lines.
7093 Save and restore bidi cache.
0bb23927
EZ
7094
7095 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7096 (bidi_paragraph_info): Delete unused struct.
7097 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7098 (bidi_cache_start): New variable.
7099 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7100 to zero.
7101 (bidi_cache_fetch_state, bidi_cache_search)
7102 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7103 (bidi_cache_find, bidi_peek_at_next_level)
7104 (bidi_level_of_next_char, bidi_find_other_level_edge)
7105 (bidi_move_to_visually_next): Compare cache index with
7106 bidi_cache_start rather than with zero.
7107 (bidi_fetch_char): Accept new argument STRING; all callers
7108 changed. Support iteration over a string. Support strings with
7109 display properties. Support unibyte strings. Fix the type of
7110 `len' according to what STRING_CHAR_AND_LENGTH expects.
7111 (bidi_paragraph_init, bidi_resolve_explicit_1)
7112 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7113 (bidi_level_of_next_char, bidi_move_to_visually_next):
7114 Support iteration over a string.
0bb23927
EZ
7115 (bidi_set_sor_type, bidi_resolve_explicit_1)
7116 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7117 can now be zero (for strings); special values 0 and -1 were
7118 changed to -1 and -2, respectively.
7119 (bidi_char_at_pos): New function.
7120 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7121 Call it instead of FETCH_MULTIBYTE_CHAR.
7122 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7123 initialized to valid values.
7124 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7125 values.
7126 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7127 the test for valid cached positions. Fix the logic for looking up
7128 the sentinel state in the cache. GCPRO the Lisp string we are
7129 iterating.
7130 (bidi_push_it, bidi_pop_it): New functions.
7131 (bidi_initialize): Initialize the bidi cache start stack pointer.
7132 (bidi_cache_ensure_space): New function, refactored from part of
7133 bidi_cache_iterator_state. Don't assume the required size is just
7134 one BIDI_CACHE_CHUNK away.
7135 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7136 (bidi_count_bytes, bidi_char_at_pos): New functions.
7137 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7138 always valid if bidi_cache_idx is valid.
7139 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7140 is valid if it's going to be used.
7141 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7142 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7143 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7144 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7145 (bidi_find_other_level_edge, bidi_cache_start_stack):
7146 All variables related to cache indices are now EMACS_INT.
c965adc5 7147
0bb23927
EZ
7148 * dispextern.h (struct bidi_string_data): New structure.
7149 (struct bidi_it): New member `string'. Make flag members be 1-bit
7150 fields, and put them last in the struct.
640c8776
SM
7151 (compute_display_string_pos, compute_display_string_end):
7152 Update prototypes.
0bb23927
EZ
7153 (bidi_push_it, bidi_pop_it): Add prototypes.
7154 (struct iterator_stack_entry): New members bidi_p,
7155 paragraph_embedding, and from_disp_prop_p.
7156 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7157 (bidi_shelve_cache, bidi_unshelve_cache):
7158 Declare prototypes.
0bb23927
EZ
7159
7160 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7161 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7162 and vector-like objects.
7163
7164 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7165 cache around display iteration.
7166
7167 * window.c (Fwindow_end, window_scroll_pixel_based)
7168 (displayed_window_lines, Frecenter): Save and restore the bidi
7169 cache around display iteration.
7170
3bbd2265
LMI
71712011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7172
7173 * editfns.c (Fdelete_region): Clarify the use of the named
7174 parameters (bug#6788).
7175
adc47434
MR
71762011-07-14 Martin Rudalics <rudalics@gmx.at>
7177
7178 * indent.c (Fvertical_motion): Set and restore w->pointm when
7179 saving and restoring the window's buffer (Bug#9006).
7180
837c31f8
LMI
71812011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7182
7183 * editfns.c (Fstring_to_char): Clarify just what is returned
7184 (bug#6576). Text by Eli Zaretskii.
7185
ac389d0c
JB
71862011-07-13 Juanma Barranquero <lekktu@gmail.com>
7187
7188 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7189
0be0ce47
EZ
71902011-07-13 Eli Zaretskii <eliz@gnu.org>
7191
7192 * buffer.c (mmap_find): Fix a typo.
7193
cd18e7e3
JB
71942011-07-13 Johan Bockgård <bojohan@gnu.org>
7195
7196 Fix execution of x selection hooks.
7197 * xselect.c (Qx_lost_selection_functions)
7198 (Qx_sent_selection_functions): New vars.
7199 (syms_of_xselect): DEFSYM them.
7200 (x_handle_selection_request): Pass Qx_sent_selection_functions
7201 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7202 (x_handle_selection_clear,x_clear_frame_selections):
7203 Pass Qx_lost_selection_functions rather than
7204 Vx_lost_selection_functions to Frun_hook_with_args.
7205
47ea7f44
PE
72062011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7207
ac389d0c 7208 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7209 The old code sometimes used this field without initializing it.
7210
47ea7f44
PE
7211 * alloc.c (gc_sweep): Don't read past end of array.
7212 In theory, the old code could also have corrupted Emacs internals,
7213 though it'd be very unlikely.
7214
bc985c87
AS
72152011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7216
7217 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7218 argument. (Bug#4026)
bc985c87 7219
0cf34688
LMI
72202011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7221
b3dadd76
LMI
7222 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7223 key" (bug#4257).
7224
0cf34688
LMI
7225 * window.c (Fset_window_start): Doc fix (bug#4199).
7226 (Fset_window_hscroll): Ditto.
7227
270768cd
PE
72282011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7229
077e3dda 7230 Fix minor new problems caught by GCC 4.6.1.
270768cd 7231 * term.c (init_tty): Remove unused local.
490011a6 7232 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7233 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7234 not used otherwise.
270768cd 7235
b1f58454
CY
72362011-07-12 Chong Yidong <cyd@stupidchicken.com>
7237
7238 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7239
22b9578d
LMI
72402011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7241
6e70ab07
LMI
7242 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7243 are the mini-buffer and the echo area (bug#3320).
7244
22b9578d
LMI
7245 * term.c (init_tty): Remove support for supdup, c10 and perq
7246 terminals, which are no longer supported (bug#1482).
7247
8974cc9f
JB
72482011-07-10 Johan Bockgård <bojohan@gnu.org>
7249
7250 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7251
a560d974
JD
72522011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7253
7254 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7255 for non-popups (Bug#3642).
7256
1dae0f0a
AS
72572011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7258
268c2c36 7259 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7260 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7261 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7262 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7263 * data.c (fmod): Likewise.
7264 * dispnew.c (swap_glyphs_in_rows): Likewise.
7265 * emacs.c (memory_warning_signal): Likewise.
7266 * floatfns.c (float_error): Likewise.
7267 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7268 (otf_open, font_otf_capability, generate_otf_features)
7269 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7270 Likewise.
7271 * image.c (pbm_read_file): Likewise.
7272 * indent.c (string_display_width): Likewise.
7273 * intervals.c (check_for_interval, search_for_interval)
7274 (inc_interval_count, count_intervals, root_interval)
7275 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7276 * lread.c (defalias): Likewise.
268c2c36 7277 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7278 * regex.c (set_image_of_range_1, set_image_of_range)
7279 (regex_grow_registers): Likewise.
7280 * sysdep.c (strerror): Likewise.
7281 * termcap.c (valid_filename_p, tprint, main): Likewise.
7282 * tparam.c (main): Likewise.
7283 * unexhp9k800.c (run_time_remap, save_data_space)
7284 (update_file_ptrs, read_header, write_header, calculate_checksum)
7285 (copy_file, copy_rest, display_header): Likewise.
7286 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7287 Likewise.
7288 * xdisp.c (check_it): Likewise.
7289 * xfaces.c (register_color, unregister_color, unregister_colors):
7290 Likewise.
7291 * xfns.c (print_fontset_result): Likewise.
7292 * xrdb.c (member, fatal, main): Likewise.
7293
99033785
PE
72942011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7295
7296 Fix minor problems found by static checking (Bug#9031).
7297 * chartab.c (char_table_set_range, map_sub_char_table):
7298 Remove unused locals.
7299 (uniprop_table): Now static.
7300 * composite.c (_work_char): Remove unused static var.
7301
9cb2ac56
JB
73022011-07-09 Juanma Barranquero <lekktu@gmail.com>
7303
7304 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7305
f25661f0
JD
73062011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7307
7308 * gtkutil.c (qttip_cb): Remove code without function.
7309
8278c4fe
EZ
73102011-07-09 Eli Zaretskii <eliz@gnu.org>
7311
7312 * w32.c (pthread_sigmask): New stub.
7313
1692ae2d 73142011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7315
8a6ebd58 7316 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7317 sigprocmask is portable only for single-threaded applications, and
7318 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7319 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7320 (LIBES): Use it.
7321 * callproc.c (Fcall_process):
7322 * process.c (create_process):
7323 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7324 Use pthread_sigmask, not sigprocmask.
123403e4 7325
1b854618
JD
73262011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7327
7328 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7329 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7330 wrong (Bug#8591).
7331
3fe4b549
JD
73322011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7333
0ce7e563
JD
7334 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7335 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7336 (xg_hide_tooltip): Fix comment.
7337
3fe4b549
JD
7338 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7339 in registerServicesMenuSendTypes.
7340 (validRequestorForSendType): Don't check ns_return_types.
7341
7342 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7343 ns_return_type.
7344
5df75e47
JR
73452011-07-08 Jason Rumney <jasonr@gnu.org>
7346
22610910
JR
7347 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7348 SH_SHOW for hidden windows (Bug#5482).
7349
5df75e47
JR
7350 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7351 frame struct members of non-existent frames (Bug#6284).
7352
699c10bd
JD
73532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7354
4393663b
JD
7355 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7356 variable firstTime not needed on OSX >= 10.6.
7357 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7358 >= 10.5. Use setKnobProportion, setDoubleValue.
7359
7360 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7361 (MAC_OS_X_VERSION_10_5): Define if not defined.
7362 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7363 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7364 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7365
7366 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7367 cString and lossyCString on OSX >= 10.4
7368
58179cce 7369 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7370 sizeToFit on OSX >= 10.2.
7371
7372 * nsimage.m (allocInitFromFile): Don't use deprecated method
7373 bestRepresentationForDevice on OSX >= 10.6.
7374
7375 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7376 to avoid warning.
7377
7378 * emacs.c: Declare unexec_init_emacs_zone.
7379
a63e0781
JD
7380 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7381
699c10bd
JD
7382 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7383
7384 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7385 on svcsMenu (Bug#8842).
7386
7387 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7388 ns_return_types.
7389 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7390
7391 * nsterm.m (QUTF8_STRING): Declare.
7392 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7393 (validRequestorForSendType): Return type is (id).
7394 Change indexOfObjectIdenticalTo to indexOfObject.
7395 Check if we have local selection before returning self (Bug#8842).
7396 (writeSelectionToPasteboard): Put local selection into paste board
7397 if we have a local selection (Bug#8842).
7398 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7399
7400 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7401 (ns_get_local_selection): Declare.
7402
54e10184
LMI
74032011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7404
9888ff71
LMI
7405 * keymap.c (describe_map_tree): Don't insert a double newline at
7406 the end of the buffer (bug#1169) and return whether we inserted
7407 something.
7408
54e10184
LMI
7409 * callint.c (Fcall_interactively): Change "reading args" to
7410 "providing args" to try to clarify what it does (bug#1010).
7411
15fa4783
KH
74122011-07-07 Kenichi Handa <handa@m17n.org>
7413
7414 * composite.c (composition_compute_stop_pos): Ignore a static
7415 composition starting before CHARPOS (Bug#8915).
7416
7417 * xdisp.c (handle_composition_prop): Likewise.
7418
a8815b00
EZ
74192011-07-07 Eli Zaretskii <eliz@gnu.org>
7420
7421 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7422 (Bug#9015)
7423
ef7b981d 74242011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7425
7426 * character.h (unicode_category_t): New enum type.
7427
7428 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7429 (Qchar_code_property_table): New variable.
7430 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7431 (UNIPROP_COMPRESSED_FORM_P): New macros.
7432 (char_table_ascii): Uncompress the compressed values.
7433 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7434 Uncompress the compressed values.
ac389d0c 7435 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7436 (char_table_ref_and_range): Uncompress the compressed values.
7437 (sub_char_table_set): New arg is_uniprop. Callers changed.
7438 Uncompress the compressed values.
7439 (sub_char_table_set_range): Args changed. Callers changed.
7440 (char_table_set_range): Adjuted for the above change.
7441 (map_sub_char_table): Delete args default_val and parent. Add arg
7442 top. Give decoded values to a Lisp function.
640c8776 7443 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7444 values to a Lisp function. Gcpro more variables.
7445 (uniprop_table_uncompress)
7446 (uniprop_decode_value_run_length): New functions.
7447 (uniprop_decoder, uniprop_decoder_count): New variables.
7448 (uniprop_get_decoder, uniprop_encode_value_character)
7449 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7450 New functions.
7451 (uniprop_encoder, uniprop_encoder_count): New variables.
7452 (uniprop_get_encoder, uniprop_table)
7453 (Funicode_property_table_internal, Fget_unicode_property_internal)
7454 (Fput_unicode_property_internal): New functions.
7455 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7456 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7457 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7458 char-code-property-alist.
7459
640c8776 7460 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7461 Vunicode_category_table.
7462
640c8776 7463 * font.c (font_range): Adjust for the change of
c805dec0
KH
7464 Vunicode_category_table.
7465
76b397fb
DN
74662011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7467
7468 * m/iris4d.h: Remove file, move contents ...
7469 * s/irix6-5.h: ... here.
7470
22b4128e
PE
74712011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7472
7473 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7474 * alloc.c (mark_buffer):
7475 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7476 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7477 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7478 This isn't true in general, and it's particularly not true
7479 if Emacs is configured with --with-wide-int.
7480 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7481 New macros, used in the buffer.c change.
7482
869795d6
JD
74832011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7484
7485 * xsettings.c: Use both GConf and GSettings if both are available.
7486 (store_config_changed_event): Add comment.
7487 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7488 (store_tool_bar_style_changed): New functions.
5e617bc2 7489 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7490 (struct xsettings): Move font inside HAVE_XFT.
7491 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7492 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7493 Move inside HAVE_XFT.
640c8776 7494 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7495 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7496 also.
7497 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7498 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7499 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7500 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7501 (parse_settings): Move check for font inside HAVE_XFT.
7502 (read_settings, apply_xft_settings): Add comment.
7503 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7504 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7505 call store_font_name_changed.
7506 (xft_settings_event): Add comment.
7507 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7508 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7509 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7510 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7511 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7512 (xsettings_get_system_font, xsettings_get_system_normal_font):
7513 Add comment.
869795d6 7514
d8ed26bd
PE
75152011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7516
7517 Random fixes. E.g., (random) never returned negative values.
7518 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7519 subseconds part to the entropy, as that's a bit more random.
7520 Prefer signed to unsigned, since the signedness doesn't matter and
7521 in general we prefer signed. When given a limit, use a
7522 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7523 latter isn't right if USE_2_TAGS_FOR_INTS.
7524 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7525 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7526
cabf1cac
SM
75272011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7528
7529 * textprop.c (text_property_stickiness):
7530 Obey Vtext_property_default_nonsticky.
7531 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7532 * w32fns.c (syms_of_w32fns):
7533 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7534
6e9b2be9
PE
75352011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7536
7537 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7538 This is more efficient than Ffile_directory_p and avoids a minor race.
7539
90186c68
LMI
75402011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7541
7c301272
LMI
7542 * buffer.c (Foverlay_put): Say what the return value is
7543 (bug#7835).
7544
c4f2d8d4
LMI
7545 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7546 is a directory before asking whether to use the file name
7547 (bug#7564).
ad637907
LMI
7548 (barf_or_query_if_file_exists): Make the "File is a directory"
7549 error be more correct.
c4f2d8d4 7550
90186c68
LMI
7551 * fns.c (Frequire): Remove the mention of the .gz files, since
7552 that's installation-specific, but keep the mention of
7553 `get-load-suffixes'.
7554
da64016e
PE
75552011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7556
7557 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7558 Report string overflow if the output is too long.
7559
7d47b580
JB
75602011-07-04 Juanma Barranquero <lekktu@gmail.com>
7561
a555cb87
JB
7562 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7563 (syms_of_gnutls): Remove duplicate DEFSYM for
7564 Qgnutls_bootprop_verify_hostname_error, an error for
7565 Qgnutls_bootprop_verify_error (which is no longer used).
7566
7d47b580
JB
7567 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7568 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7569 Also (re)move comments that are misplaced or no longer relevant.
7570
1e49bfab
LMI
75712011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7572
7573 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7574
1485f4c0
CY
75752011-07-03 Chong Yidong <cyd@stupidchicken.com>
7576
7577 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7578 and background color parameters if they have been changed.
7579
a9ab721e
LMI
75802011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7581
7582 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7583
cf7cff57
PE
75842011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7585
2e13213d
PE
7586 * xsettings.c (SYSTEM_FONT): Define only when used.
7587 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7588
cf7cff57
PE
7589 * keymap.c (access_keymap_1): Now static.
7590
7a8e04f7
CY
75912011-07-02 Chong Yidong <cyd@stupidchicken.com>
7592
7593 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7594 leave any prefix arg for the up event (Bug#1586).
7595
61352f62
LMI
75962011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7597
69bb1ef7
LMI
7598 * lread.c (syms_of_lread): Mention single symbols defined by
7599 `defvar' or `defconst' (bug#7154).
7600
61352f62 7601 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7602 (Frequire): Mention get-load-suffixes.
61352f62 7603
28545e04
MR
76042011-07-02 Martin Rudalics <rudalics@gmx.at>
7605
7606 * window.h (window): Remove clone_number slot.
7607 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7608 Remove.
7609 (make_parent_window, make_window, saved_window)
7610 (Fset_window_configuration, save_window_save): Don't deal with
7611 clone numbers.
7612 * buffer.c (Qclone_number): Remove declaration.
7613 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7614
3349e122
SM
76152011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7616
7617 Add multiple inheritance to keymaps.
7618 * keymap.c (Fmake_composed_keymap): New function.
7619 (Fset_keymap_parent): Simplify.
7620 (fix_submap_inheritance): Remove.
7621 (access_keymap_1): New function extracted from access_keymap to handle
7622 embedded parents and handle lists of maps.
7623 (access_keymap): Use it.
7624 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7625 (Fcopy_keymap): Handle embedded parents.
7626 (Fcommand_remapping, define_as_prefix): Simplify.
7627 (Fkey_binding): Simplify.
7628 (syms_of_keymap): Move minibuffer-local-completion-map,
7629 minibuffer-local-filename-completion-map,
7630 minibuffer-local-must-match-map, and
7631 minibuffer-local-filename-must-match-map to Elisp.
7632 (syms_of_keymap): Defsubr make-composed-keymap.
7633 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7634 (parse_menu_item): Trivial simplification.
7635
3279eb87
GM
76362011-07-01 Glenn Morris <rgm@gnu.org>
7637
7638 * Makefile.in (SETTINGS_LIBS): Fix typo.
7639
4550efdf
KI
76402011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7641
7642 * coding.c (Fencode_coding_string): Record the last coding system
7643 used, as the function doc string says (bug#8738).
7644
0949d2b6
JD
76452011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7646
7647 * xsettings.c (store_monospaced_changed): Take new font as arg and
7648 check for change against current_mono_font.
7649 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7650 (emacs_settings_constructor, emacs_settings_get_property)
7651 (emacs_settings_set_property, emacs_settings_class_init)
7652 (emacs_settings_init, gsettings_obj): Remove.
7653 (something_changedCB): New function for HAVE_GSETTINGS.
7654 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7655 with value as argument.
7656 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7657 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7658 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7659 "changed".
7660
7661 * xgselect.c: Add defined (HAVE_GSETTINGS).
7662 (xgselect_initialize): Ditto.
7663
7664 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7665 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7666 xg_select.
7667
bbc6b304
PE
76682011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7669
7670 * eval.c (struct backtrace): Simplify and port the data structure.
7671 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7672 signed bit field, as this assumption is not portable and it makes
7673 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7674 "char debug_on_exit : 1" as this is not portable either; instead,
7675 use the portable "unsigned int debug_on_exit : 1". Remove unused
7676 member evalargs. Remove obsolete comments about cc bombing out.
7677
9851bfc5
JD
76782011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7679
51bb811f 7680 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7681 Let HAVE_GSETTINGS override HAVE_GCONF.
7682 (store_monospaced_changed): New function.
7683 (EMACS_SETTINGS): A new type derived from GObject to handle
7684 GSettings notifications.
7685 (emacs_settings_constructor, emacs_settings_get_property)
7686 (emacs_settings_set_property, emacs_settings_class_init):
7687 New functions.
7688 (gsettings_client, gsettings_obj): New variables.
7689 (GSETTINGS_SCHEMA): New define.
7690 (something_changedCB): Call store_monospaced_changed.
7691 (init_gsettings): New function.
7692 (xsettings_initialize): Call init_gsettings.
7693 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7694 to NULL.
7695
640c8776 7696 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7697 GCONF_CFLAGS/LIBS.
7698
5386012d
MR
76992011-06-29 Martin Rudalics <rudalics@gmx.at>
7700
7701 * window.c (resize_root_window, grow_mini_window)
7702 (shrink_mini_window): Rename Qresize_root_window to
7703 Qwindow_resize_root_window and Qresize_root_window_vertically to
7704 Qwindow_resize_root_window_vertically.
7705
f13e0b08
PE
77062011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7707
7708 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7709
94515237
JB
77102011-06-27 Juanma Barranquero <lekktu@gmail.com>
7711
7712 * makefile.w32-in: Redesign dependencies so they reflect more
7713 clearly which files are directly included by each source file,
7714 and not through other includes.
7715
e43b6e43
MR
77162011-06-27 Martin Rudalics <rudalics@gmx.at>
7717
7718 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7719 (sort_overlays, overlay_strings): When an overlay's clone number
7720 matches the window's clone number process the overlay even if
7721 the overlay's window property doesn't match the current window.
7722
d68443dc
MR
7723 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7724 (Fwindow_hchild): Rename to Fwindow_left_child.
7725 (Fwindow_next): Rename to Fwindow_next_sibling.
7726 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7727 (resize_window_check): Rename to window_resize_check.
7728 (resize_window_apply): Rename to window_resize_apply.
7729 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7730 (Fdelete_other_windows_internal, resize_frame_windows)
7731 (Fsplit_window_internal, Fdelete_window_internal)
7732 (grow_mini_window, shrink_mini_window)
7733 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7734
c7e73be5
JD
77352011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7736
7737 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7738 (emacs_fixed_set_min_size): Remove.
7739 (emacs_fixed_new): Take frame as argument.
7740
7741 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7742 (_EmacsFixedPrivate): Remove minwidth/height.
7743 Add struct frame *f.
7744 (emacs_fixed_init): Initialize priv->f.
7745 (get_parent_class, emacs_fixed_set_min_size): Remove.
7746 (emacs_fixed_new): Set priv->f to argument.
7747 (emacs_fixed_get_preferred_width)
7748 (emacs_fixed_get_preferred_height): Use min_width/height from
7749 frames size_hint to set minimum and natural (Bug#8919).
7750 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7751 and use min_width/height from frames size_hint to set
7752 min_width/height (Bug#8919).
7753
7754 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7755 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7756 Fix indentation.
c7e73be5 7757
cf99dcf8
EZ
77582011-06-26 Eli Zaretskii <eliz@gnu.org>
7759
7760 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7761 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7762 called at ZV.
7763
029529ac
CY
77642011-06-26 Chong Yidong <cyd@stupidchicken.com>
7765
7766 * process.c (wait_reading_process_output): Bypass select if
7767 waiting for a cell while ignoring keyboard input, and input is
7768 pending. Suggested by Jan Djärv (Bug#8869).
7769
7a7ef429
PE
77702011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7771
7772 Use gnulib's dup2 module instead of rolling our own.
7773 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7774
11fdef7d 77752011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7776
7777 * dispnew.c (scrolling_window): Before scrolling, turn off a
7778 mouse-highlight in the window being scrolled.
7779
cd3520a4
JB
77802011-06-24 Juanma Barranquero <lekktu@gmail.com>
7781
7782 Move DEFSYM to lisp.h and use everywhere.
7783
7784 * character.h (DEFSYM): Move declaration...
7785 * lisp.h (DEFSYM): ...here.
7786
7787 * gnutls.c:
7788 * minibuf.c:
7789 * w32menu.c:
7790 * w32proc.c:
7791 * w32select.c: Don't include character.h.
7792
7793 * alloc.c (syms_of_alloc):
7794 * buffer.c (syms_of_buffer):
7795 * bytecode.c (syms_of_bytecode):
7796 * callint.c (syms_of_callint):
7797 * casefiddle.c (syms_of_casefiddle):
7798 * casetab.c (init_casetab_once):
7799 * category.c (init_category_once, syms_of_category):
7800 * ccl.c (syms_of_ccl):
7801 * cmds.c (syms_of_cmds):
7802 * composite.c (syms_of_composite):
7803 * dbusbind.c (syms_of_dbusbind):
7804 * dired.c (syms_of_dired):
7805 * dispnew.c (syms_of_display):
7806 * doc.c (syms_of_doc):
7807 * editfns.c (syms_of_editfns):
7808 * emacs.c (syms_of_emacs):
7809 * eval.c (syms_of_eval):
7810 * fileio.c (syms_of_fileio):
7811 * fns.c (syms_of_fns):
7812 * frame.c (syms_of_frame):
7813 * fringe.c (syms_of_fringe):
7814 * insdel.c (syms_of_insdel):
7815 * keymap.c (syms_of_keymap):
7816 * lread.c (init_obarray, syms_of_lread):
7817 * macros.c (syms_of_macros):
7818 * msdos.c (syms_of_msdos):
7819 * print.c (syms_of_print):
7820 * process.c (syms_of_process):
7821 * search.c (syms_of_search):
7822 * sound.c (syms_of_sound):
7823 * syntax.c (init_syntax_once, syms_of_syntax):
7824 * terminal.c (syms_of_terminal):
7825 * textprop.c (syms_of_textprop):
7826 * undo.c (syms_of_undo):
7827 * w32.c (globals_of_w32):
7828 * window.c (syms_of_window):
7829 * xdisp.c (syms_of_xdisp):
7830 * xfaces.c (syms_of_xfaces):
7831 * xfns.c (syms_of_xfns):
7832 * xmenu.c (syms_of_xmenu):
7833 * xsettings.c (syms_of_xsettings):
7834 * xterm.c (syms_of_xterm): Use DEFSYM.
7835
4228cf16
TZ
78362011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7837
cd3520a4 7838 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7839
7fcccf1e
PE
78402011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7841
7efb4e0e
PE
7842 Integer and buffer overflow fixes (Bug#8873).
7843
ff5844ad
PE
7844 * print.c (printchar, strout): Check for string overflow.
7845 (PRINTPREPARE, printchar, strout):
7846 Don't set size unless allocation succeeds.
7847
90532f02
PE
7848 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7849 for sizes. Check for string overflow more accurately.
7850 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7851
6d84508d
PE
7852 * macros.c: Integer and buffer overflow fixes.
7853 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7854 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7855 Use ptrdiff_t, not int, for sizes.
7856 Don't increment bufsize until after realloc succeeds.
7857 Check for size-calculation overflow.
7858 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7859
437b2cb4
PE
7860 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7861
8b9ac8b4
PE
7862 * lread.c: Integer overflow fixes.
7863 (read_integer): Radix is now EMACS_INT, not int,
7864 to improve quality of diagnostics for out-of-range radices.
7865 Calculate buffer size correctly for out-of-range radices.
7866 (read1): Check for integer overflow in radices, and in
7867 read-circle numbers.
82cb60d3
PE
7868 (read_escape): Avoid int overflow.
7869 (Fload, openp, read_buffer_size, read1)
7870 (substitute_object_recurse, read_vector, read_list, map_obarray):
7871 Use ptrdiff_t, not int, for sizes.
7872 (read1): Use EMACS_INT, not int, for sizes.
20270765 7873 Check for size overflow.
8b9ac8b4 7874
7fcccf1e
PE
7875 * image.c (cache_image): Check for size arithmetic overflow.
7876
bfbbd7e7
PE
7877 * lread.c: Integer overflow issues.
7878 (saved_doc_string_size, saved_doc_string_length)
7879 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7880 Now ptrdiff_t, not int.
7881 (read1): Don't assume doc string length fits in int. Check for
7882 out-of-range doc string lengths.
7883 (read_list): Don't assume file position fits in int.
39019e54 7884 (read_escape): Check for hex character overflow.
bfbbd7e7 7885
4e323265
LL
78862011-06-22 Leo Liu <sdl.web@gmail.com>
7887
7888 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7889 Move to minibuffer.el.
7890
85fece3e
PE
78912011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7892
20b84ce9 7893 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7894 The following patches are for when GLYPH_DEBUG && !XASSERT.
7895 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7896 * dispnew.c (flush_stdout):
7897 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7898 Mark as externally visible.
7899 * dispnew.c (check_window_matrix_pointers): Now static.
7900 * dispnew.c (window_to_frame_vpos):
7901 * xfns.c (unwind_create_frame):
7902 * xterm.c (x_check_font): Remove unused local.
7903 * scroll.c (CHECK_BOUNDS):
7904 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7905 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7906 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7907 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7908 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7909 Now static.
7910 (debug_method_add): Use va_list and vsprintf rather than relying
7911 on undefined behavior with wrong number of arguments.
7912 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7913 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7914 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7915 since we're not interested in debugging glyphs with old libraries.
7916 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7917 GCC 4.6.0's static checking.
7918
0766b489
PE
79192011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7920
31fd4b32
PE
7921 Integer overflow and signedness fixes (Bug#8873).
7922 A few related buffer overrun fixes, too.
7923
b79e8648
PE
7924 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7925
0766b489
PE
7926 * dispextern.h (struct face.stipple):
7927 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7928 (x_bitmap_mask, x_allocate_bitmap_record)
7929 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7930 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7931 (x_create_bitmap_from_xpm_data):
7932 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7933 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7934 (.bitmaps_last):
7935 * xfaces.c (load_pixmap):
7936 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7937 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7938 (.bitmaps_last, struct x_output.icon_bitmap):
7939 Use ptrdiff_t, not int, for bitmap indexes.
7940 (x_allocate_bitmap_record): Check for size overflow.
7941 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7942
b081724f
PE
7943 Use ptrdiff_t, not int, for overlay counts.
7944 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7945 * editfns.c (overlays_around, get_pos_property):
7946 * textprop.c (get_char_property_and_overlay):
7947 * xdisp.c (next_overlay_change, note_mouse_highlight):
7948 * xfaces.c (face_at_buffer_position):
21514da7
PE
7949 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7950 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7951 (Fnext_overlay_change, Fprevious_overlay_change)
7952 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7953 Use ptrdiff_t, not int, for sizes.
21514da7 7954 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7955
3de73e5e
PE
7956 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7957
2606c57b
PE
7958 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7959 (x_session_initialize): Do not assume string length fits in int.
7960
aaafe47a
PE
7961 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7962 This is unlikely, but can occur if DPI is outlandish.
7963
2674ddc8 7964 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7965 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7966
28154962
PE
7967 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7968 * xrdb.c (magic_file_p, search_magic_path):
7969 Omit last arg SUFFIX; it was always 0. All callers changed.
7970 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7971
7de51af5
PE
7972 * xfont.c (xfont_match): Avoid need for strlen.
7973
25ed6cc3
PE
7974 * xfns.c: Don't assume strlen fits in int.
7975 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7976
4eab31dd
PE
7977 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7978 not unsigned long, as we prefer signed integers. All callers changed.
7979 Detect integer overflow in repeat count.
7980 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7981 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7982
171e2a58
PE
7983 * termcap.c: Don't assume sizes fit in int and never overflow.
7984 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7985 (gobble_line): Check for size-calculation overflow.
7986
ad39faca 7987 * minibuf.c (Fread_buffer):
6e5bb2dc 7988 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7989 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7990 Don't assume string length fits in int.
7991
52c61c22 7992 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7993 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7994
b5b8c9e5
PE
7995 * font.c: Don't assume string length fits in int.
7996 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7997 Use ptrdiff_t, not int.
ccd6111c
PE
7998 (font_intern_prop): Don't assume string length fits in int.
7999 Don't assume integer property fits in fixnum.
8000 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8001
882f0d81 8002 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8003 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8004 Reformulate so as not to need the command string.
8005 Invoke gzip -cd rather than gunzip, as it's more portable.
8006 (lock_info_type, lock_file_1, lock_file):
8007 Don't assume pid_t and time_t fit in unsigned long.
8008 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8009 (current_lock_owner): Prefer signed type for sizes.
8010 Use memcpy, not strncpy, where memcpy is what is really wanted.
8011 Don't assume (via atoi) that time_t and pid_t fit in int.
8012 Check for time_t and/or pid_t out of range, e.g., via a network share.
8013 Don't alloca where an auto var works fine.
8014
93f4cf88
PE
8015 * fileio.c: Fix some integer overflow issues.
8016 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8017 Don't assume string length fits in int.
8018 (directory_file_name): Don't assume string length fits in long.
8019 (make_temp_name): Don't assume pid fits in int, or that its print
8020 length is less than 20.
8021
f3e92b69
PE
8022 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8023
1bfdaf10
PE
8024 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8025
35016e9a
PE
8026 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8027
3d1e65a1
PE
8028 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8029 We prefer signed integers, even for size calculations.
8030
0b963a93
PE
8031 * emacs.c: Don't assume string length fits in 'int'.
8032 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8033 (main): Don't invoke strlen when not needed.
8034
573f4b54
PE
8035 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8036 (XD_DEBUG_MESSAGE): Don't waste a byte.
8037
989f33ba
PE
8038 * callproc.c (getenv_internal_1, getenv_internal)
8039 (Fgetenv_internal):
965d34eb
PE
8040 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8041
e4d29b33
PE
8042 * lread.c (invalid_syntax): Omit length argument.
8043 All uses changed. This doesn't fix a bug, but it simplifies the
8044 code away from its former Hollerith-constant appearance, and it's
8045 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8046 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8047
eb49b136
PE
8048 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8049 This didn't break anything, but it didn't help either.
8050 It's confusing to put a bogus integer in a place where the actual
8051 value does not matter.
9f62aeb1 8052 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8053 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8054
15375a22
PE
8055 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8056 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8057 implementation.
b61cc01c
PE
8058 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8059 We prefer signed types, and the value cannot exceed the EMACS_INT
8060 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8061 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8062 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8063 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8064
53b2623d
PE
8065 * indent.c (sane_tab_width): New function.
8066 (current_column, scan_for_column, Findent_to, position_indentation)
8067 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8068 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8069
51cab52b 8070 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8071
f2ed8a70
PE
8072 * lisp.h (lint_assume): New macro.
8073 * composite.c (composition_gstring_put_cache):
8074 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8075
abe80cc6
PE
8076 * editfns.c, insdel.c:
8077 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8078
b02c740e
PE
8079 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8080
ebc96716
PE
8081 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8082
b4e50fa0 8083 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8084 Use much-faster test for byte-length change.
311d5d7c 8085 Don't assume string byte-length fits in 'int'.
a4cf38e4 8086 Check that character arg fits in 'int'.
85461888 8087 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8088
c0c1ee9f
PE
8089 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8090
a498d7f4
PE
8091 * fns.c (concat): Catch string overflow earlier.
8092 Do not rely on integer wraparound.
8093
51cab52b
PE
8094 * dispextern.h (struct it.overlay_strings_charpos)
8095 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8096 * xdisp.c (forward_to_next_line_start)
8097 (back_to_previous_visible_line_start)
8098 (reseat_at_next_visible_line_start, next_element_from_buffer):
8099 Don't arbitrarily truncate the value of 'selective' to int.
8100
76031fad
PE
8101 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8102
5eb55db9
PE
8103 * composite.c: Don't truncate sizes to 'int'.
8104 (composition_gstring_p, composition_reseat_it)
8105 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8106 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8107 not EMACS_UINT, for indexes.
5eb55db9 8108
0703a717
PE
8109 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8110
d6202519
PE
8111 * buffer.c: Include <verify.h>.
8112 (struct sortvec.priority, struct sortstr.priority):
8961a454 8113 Now EMACS_INT, not int.
c20998a7 8114 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8115 (struct sortstr.size, record_overlay_string)
8116 (struct sortstrlist.size, struct sortlist.used):
8117 Don't truncate size to int.
8118 (record_overlay_string): Check for size-calculation overflow.
d6202519 8119 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8120
d5a19415
JM
81212011-06-22 Jim Meyering <meyering@redhat.com>
8122
029529ac 8123 Don't leak an XBM-image-sized buffer
d5a19415
JM
8124 * image.c (xbm_load): Free the image buffer after using it.
8125
a9041e6c
PE
81262011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8127
8128 Port to Sun C.
8129 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8130 that Sun C diagnosed.
8131 * fns.c (secure_hash): Fix pointer signedness issue.
8132 * intervals.c (static_offset_intervals): New function.
8133 (offset_intervals): Use it.
8134
7f3f739f
LL
81352011-06-21 Leo Liu <sdl.web@gmail.com>
8136
8137 * deps.mk (fns.o):
8138 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8139 sha512.h.
8140
8141 * fns.c (secure_hash): Rename from crypto_hash_function and change
8142 the first arg to accept symbols.
5b66d427 8143 (Fsecure_hash): New primitive.
7f3f739f
LL
8144 (syms_of_fns): New symbols.
8145
76147d94
DD
81462011-06-20 Deniz Dogan <deniz@dogan.se>
8147
8148 * process.c (Fset_process_buffer): Clarify return value in
8149 docstring.
8150
7d7d0045
CY
81512011-06-18 Chong Yidong <cyd@stupidchicken.com>
8152
8153 * dispnew.c (add_window_display_history): Use BVAR.
8154
8155 * xdisp.c (debug_method_add): Use BVAR.
8156 (check_window_end, dump_glyph_matrix, dump_glyph)
8157 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8158
8159 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8160 Likewise.
8161
8162 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8163 check till after the cache is created in init_frame_faces.
8164
ff2bc410
SM
81652011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8166
8167 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8168
28177add
PE
81692011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8170
dd3482fe
PE
8171 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8172 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8173 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8174
393d71f3 8175 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8176 * fileio.c (Finsert_file_contents):
8177 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8178 Remove the old (too-loose) buffer overflow checks.
8179 They weren't needed, since make_gap checks for buffer overflow.
8180 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8181 The old code merely checked for Emacs fixnum overflow, and relied
8182 on undefined (wraparound) behavior. The new code avoids undefined
8183 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8184
2e6813b0 8185 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8186 Tune. Don't use wider integers than needed. Don't use alloca.
8187 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8188
599a9e4f
PE
8189 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8190
99561444
PE
8191 * insdel.c, lisp.h (buffer_overflow): New function.
8192 (insert_from_buffer_1, replace_range, replace_range_2):
8193 * insdel.c (make_gap_larger):
8194 * editfns.c (Finsert_char):
8195 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8196
28177add
PE
8197 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8198
e69dafad
PE
81992011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8200
4baa020d 8201 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8202
b1c46f02
PE
8203 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8204 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8205
e69dafad
PE
8206 * fileio.c: Don't assume EMACS_INT fits in off_t.
8207 (emacs_lseek): New static function.
8208 (Finsert_file_contents, Fwrite_region): Use it.
8209 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8210
566684ea
PE
8211 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8212
e6966cd6
PE
8213 * fns.c: Don't overflow int when computing a list length.
8214 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8215 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8216 truncation on 64-bit hosts. Check for QUIT every
8217 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8218 faster and is responsive enough.
8219 (Flength): Report an error instead of overflowing an integer.
8220 (Fsafe_length): Return a float if the value is not representable
8221 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8222 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8223 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8224
dd0b0efb
PE
8225 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8226 (header_size, word_size): New constants.
8227 (allocate_vectorlike): Don't check size overflow here.
8228 (allocate_vector): Check it here instead, since this is the only
8229 caller of allocate_vectorlike that could cause overflow.
8230 Check that the new vector's length is representable as a fixnum.
8231
86fe5cfe
PE
8232 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8233 The previous code was bogus. For example, next_almost_prime (32)
8234 returned 39, which is undesirable as it is a multiple of 3; and
8235 next_almost_prime (24) returned 25, which is a multiple of 5 so
8236 why was the code bothering to check for multiples of 7?
8237
80e88859
PE
8238 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8239
4a2f0ad6
PE
8240 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8241
f66c7cf8
PE
8242 Variadic C functions now count arguments with ptrdiff_t.
8243 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8244 Back then I didn't know that the Emacs coding style prefers signed int.
8245 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8246 were being counted with int, which may truncate counts on 64-bit
8247 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8248 * lisp.h (struct Lisp_Subr.function.aMANY)
8249 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8250 Arg counts are now ptrdiff_t, not size_t.
8251 All variadic functions and their callers changed accordingly.
8252 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8253 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8254 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8255 * callint.c (Fcall_interactively): Check arg count for overflow,
8256 to avoid potential buffer overrun. Use signed char, not 'int',
8257 for 'varies' array, so that we needn't bother to check its size
8258 calculation for overflow.
8259 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8260 * eval.c (apply_lambda):
8261 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8262 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8263 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8264
a1759b76
PE
8265 * callint.c (Fcall_interactively): Don't use index var as event count.
8266
d96be9fc
PE
8267 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8268 * mem-limits.h (SIZE): Remove; no longer used.
8269
a690a978 8270 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8271
578c21e6
PE
8272 Remove unnecessary casts.
8273 * xterm.c (x_term_init):
8274 * xfns.c (x_set_border_pixel):
8275 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8276 These aren't needed now that we assume ANSI C.
8277
96f53c6c
PE
8278 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8279 It's more likely to cause problems (due to unsigned overflow)
8280 than to cure them.
8281
83c77d31
PE
8282 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8283
ee2079f1
PE
8284 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8285
6da65536
PE
8286 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8287
7147c4a4
PE
8288 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8289
193e32d9
PE
8290 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8291
e5533da6
PE
8292 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8293
9910e595
PE
8294 GLYPH_CODE_FACE returns EMACS_INT, not int.
8295 * dispextern.h (merge_faces):
8296 * xfaces.c (merge_faces):
01103c44
PE
8297 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8298 Don't assume EMACS_INT fits in int.
9910e595 8299
2638320e
PE
8300 * character.h (CHAR_VALID_P): Remove unused parameter.
8301 * fontset.c, lisp.h, xdisp.c: All uses changed.
8302
045eb8d9
PE
8303 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8304
c1f134b5
PE
8305 * fns.c (concat): Minor tuning based on overflow analysis.
8306 This doesn't fix any bugs. Use int to hold character, instead
8307 of constantly refetching from Emacs object. Use XFASTINT, not
8308 XINT, for value known to be a character. Don't bother comparing
8309 a single byte to 0400, as it's always less.
8310
395fcb93 8311 * floatfns.c (Fexpt):
327eeec8
PE
8312 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8313
abbd3d23
PE
8314 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8315 for characters.
8316
684a03ef
PE
8317 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8318
0fed43f3
PE
8319 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8320 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8321 incorrectly succeed when S was a string, because 4294967386 was
8322 truncated before it was used.
8323
8fd02eb7
PE
8324 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8325 Otherwise, an out-of-range integer could cause undefined behavior
8326 on a 64-bit host.
8327
f8c86b69
PE
8328 * composite.c: Use int, not EMACS_INT, for characters.
8329 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8330 EMACS_INT, for values that are known to be in character range.
8331 This doesn't fix any bugs but is the usual style inside Emacs and
8332 may generate better code on 32-bit machines.
8333
34206dd2
PE
8334 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8335 This is for reasons similar to the recent CHAR_STRING fix.
8336 * charset.c (Fencode_char): Check that character arg is actually
8337 a character. Pass an int to ENCODE_CHAR.
8338 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8339 wider than 'int', as a compile-time check to prevent future regressions
8340 in this area.
8341
c5958d4c 8342 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8343
8344 Make sure a 64-bit char is never passed to CHAR_STRING.
8345 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8346 by silently ignoring the top 32 bits, allowing some values
8347 that were far too large to be valid characters.
8348 * character.h: Include <verify.h>.
8349 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8350 arguments are no wider than unsigned, as a compile-time check
8351 to prevent future regressions in this area.
8352 * data.c (Faset):
01103c44 8353 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8354 (Fsubst_char_in_region):
8355 * fns.c (concat):
8356 * xdisp.c (decode_mode_spec_coding):
8357 Adjust to CHAR_STRING's new requirement.
8358 * editfns.c (Finsert_char, Fsubst_char_in_region):
8359 * fns.c (concat): Check that character args are actually
8360 characters. Without this test, these functions did the wrong
8361 thing with wildly out-of-range values on 64-bit hosts.
8362
d37ca623
PE
8363 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8364 These casts should not be needed on 32-bit hosts, either.
8365 * keyboard.c (read_char):
8366 * lread.c (Fload): Remove casts to unsigned.
8367
ea204efb
PE
8368 * lisp.h (UNSIGNED_CMP): New macro.
8369 This fixes comparison bugs on 64-bit hosts.
8370 (ASCII_CHAR_P): Use it.
8371 * casefiddle.c (casify_object):
01103c44 8372 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8373 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8374 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8375 * dispextern.h (FACE_FROM_ID):
8376 * keyboard.c (read_char): Use UNSIGNED_CMP.
8377
41cb286c
PE
8378 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8379 not to EMACS_INT, to avoid GCC warning.
8380
4a1b9832
PE
8381 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8382
55daad71
PE
8383 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8384 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8385 isn't needed on 32-bit machines.
8f95c75c 8386
01103c44
PE
8387 * buffer.c (Fgenerate_new_buffer_name):
8388 Use EMACS_INT for count, not int.
0ceccced 8389 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8390
8391 * data.c (Qcompiled_function): Now static.
8392
c6f072e7
PE
8393 * window.c (window_body_lines): Now static.
8394
20ce5912
PE
8395 * image.c (gif_load): Rename local to avoid shadowing.
8396
9c4c5f81
PE
8397 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8398 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8399 * alloc.c (make_save_value): Integer argument is now of type
8400 ptrdiff_t, not int.
8401 (mark_object): Use ptrdiff_t, not int.
8402 * lisp.h (pD): New macro.
8403 * print.c (print_object): Use it.
8404
c0c5c8ae
PE
8405 * alloc.c: Use EMACS_INT, not int, to count objects.
8406 (total_conses, total_markers, total_symbols, total_vector_size)
8407 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8408 (total_free_floats, total_floats, total_free_intervals)
8409 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8410 Now EMACS_INT, not int. All uses changed.
8411 (Fgarbage_collect): Compute overall total using a double, so that
8412 integer overflow is less likely to be a problem. Check for overflow
8413 when converting back to an integer.
5a25e253
PE
8414 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8415 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8416 These were 'int' variables that could overflow on 64-bit hosts;
8417 they were never used, so remove them instead of repairing them.
211a0b2a 8418 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8419 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8420 Previously, this ceilinged at INT_MAX, but that doesn't work on
8421 64-bit machines.
e46bb31a 8422 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8423
c78baabf 8424 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8425 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8426 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8427 when a (possibly-narrower) signed value would do just as well.
8428 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8429
c9d624c6
PE
8430 * alloc.c: Catch some string size overflows that we were missing.
8431 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8432 for convenience in STRING_BYTES_MAX.
8433 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8434 The definition here is exact; the one in lisp.h was approximate.
8435 (allocate_string_data): Check for string overflow. This catches
8436 some instances we weren't catching before. Also, it catches
8437 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8438 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8439 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8440
c9d624c6
PE
8441 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8442 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8443 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8444
353032ce
PE
8445 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8446
2bccce07
PE
8447 * alloc.c (Fmake_string): Check for out-of-range init.
8448
0ac30604
SM
84492011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8450
8451 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8452
c195f2de
JD
84532011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8454
8455 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8456 xg_get_default_scrollbar_width.
8457
8458 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8459 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8460 (style_changed_cb): Call update_theme_scrollbar_width and call
8461 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8462 all frames (Bug#8505).
8463 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8464 Call gtk_window_set_resizable if HAVE_GTK3.
8465 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8466 and height if HAVE_GTK3 (Bug#8505).
8467 (scroll_bar_width_for_theme): New variable.
8468 (update_theme_scrollbar_width): New function.
8469 (xg_get_default_scrollbar_width): Move code to
8470 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8471 (xg_initialize): Call update_theme_scrollbar_width.
8472
8473 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8474
8475 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8476
e10ac9f1
MR
84772011-06-12 Martin Rudalics <rudalics@gmx.at>
8478
8479 * frame.c (make_frame): Call other_buffer_safely instead of
8480 other_buffer.
8481
8482 * window.c (temp_output_buffer_show): Call display_buffer with
8483 second argument Vtemp_buffer_show_specifiers and reset latter
8484 immediately after the call.
8485 (Vtemp_buffer_show_specifiers): New variable.
8486 (auto_window_vscroll_p, next_screen_context_lines)
8487 (Vscroll_preserve_screen_position): Remove leading asterisks from
8488 doc-strings.
8489
2d3c217e 84902011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8491
7b7f97e8 8492 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8493 * buffer.c (Qclone_number): Remove for now, as it's unused.
8494 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8495 (record_buffer): Remove unused local.
8496 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8497 (set_frame_buffer_list): Remove; unused.
8498 * frame.h (other_visible_frames): Remove decl.
8499 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8500 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8501 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8502 if HAVE_GPM.
8503 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8504 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8505 Define only if HAVE_GPM.
8506 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8507 (update_hints_inhibit): Remove; never set. All uses removed.
8508 * widgetprv.h (emacsFrameClassRec): Remove decl.
8509 * window.c (delete_deletable_window): Now returns void, since it
8510 wasn't returning anything.
8511 (compare_window_configurations): Remove unused locals.
8512 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8513 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8514 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8515 the same widths as pointers. This follows up on the 2011-05-06 patch.
8516 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8517 * xterm.h: Likewise.
8518 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8519
1384b89e
JB
85202011-06-12 Juanma Barranquero <lekktu@gmail.com>
8521
8522 * makefile.w32-in: Update dependencies.
8523 (LISP_H): Add lib/intprops.h.
8524
1100a63c
CY
85252011-06-11 Chong Yidong <cyd@stupidchicken.com>
8526
8527 * image.c (gif_load): Add animation frame delay to the metadata.
8528 (syms_of_image): Use DEFSYM. New symbol `delay'.
8529
6198ccd0
MR
85302011-06-11 Martin Rudalics <rudalics@gmx.at>
8531
8532 * window.c (delete_deletable_window): Re-add.
8533 (Fset_window_configuration): Rewrite to handle dead buffers and
8534 consequently deletable windows.
8535 (window_tree, Fwindow_tree): Remove. Supply functionality in
8536 window.el.
8537 (compare_window_configurations): Simplify code.
8538
b6e3633c
AS
85392011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8540
1ab0dee5
AS
8541 * image.c (imagemagick_load_image): Fix type mismatch.
8542 (Fimagemagick_types): Likewise.
8543
b6e3633c
AS
8544 * window.h (replace_buffer_in_windows): Declare.
8545
9397e56f
MR
85462011-06-11 Martin Rudalics <rudalics@gmx.at>
8547
8548 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8549 Qclone_number. Remove external declaration of Qdelete_window.
8550 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8551 code.
640c8776
SM
8552 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8553 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8554 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8555 buffer list implementation.
8556 (other_buffer_safely): New function.
8557 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8558 calls to replace_buffer_in_windows and
8559 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8560 if allowed.
8561 (record_buffer): Inhibit quitting and rewrite using quittable
8562 functions. Run Qbuffer_list_update_hook if allowed.
8563 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8564 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8565 Move switch-to-buffer to window.el.
9397e56f
MR
8566 (bury-buffer): Move to window.el.
8567 (Vbuffer_list_update_hook): New variable.
8568
8569 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8570 section.
8571
8572 * window.h (resize_frame_windows): Move up in code.
8573 (Fwindow_frame): Remove EXFUN.
8574 (replace_buffer_in_all_windows): Remove prototype.
8575 (replace_buffer_in_windows_safely): Add prototype.
8576
8577 * window.c: Declare Qdelete_window static again. Move down
8578 declaration of select_count.
8579 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8580 (Fother_window): Move to window.el.
8581 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8582 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8583 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8584 window.el.
8585 (replace_buffer_in_windows): Implement by calling
8586 Qreplace_buffer_in_windows.
8587 (replace_buffer_in_all_windows): Remove with some functionality
8588 moved into replace_buffer_in_windows_safely.
8589 (replace_buffer_in_windows_safely): New function.
8590 (select_window_norecord, select_frame_norecord): Move in front
8591 of run_window_configuration_change_hook. Remove now obsolete
8592 declarations.
640c8776
SM
8593 (Fset_window_buffer): Rewrite doc-string.
8594 Call Qrecord_window_buffer.
9397e56f
MR
8595 (keys_of_window): Move binding for other-window to window.el.
8596
b50691aa
CY
85972011-06-11 Chong Yidong <cyd@stupidchicken.com>
8598
8599 * dispextern.h (struct image): Replace data member, whose int_val
8600 and ptr_val fields were not used by anything, with a single
8601 lisp_val object.
8602
8603 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8604 (gif_clear_image, gif_load, imagemagick_load_image)
8605 (gs_clear_image, gs_load): Callers changed.
8606
3f754b86
PE
86072011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8608
cca69397
PE
8609 * buffer.h: Include <time.h>, for time_t.
8610 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8611
109e28d0
PE
8612 Fix minor problems found by static checking.
8613
60737f02
PE
8614 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8615
4b66faf3
PE
8616 Make identifiers static if they are not used in other modules.
8617 * data.c (Qcompiled_function, Qframe, Qvector):
8618 * image.c (QimageMagick, Qsvg):
8619 * minibuf.c (Qmetadata):
8620 * window.c (resize_window_check, resize_root_window): Now static.
8621 * window.h (resize_window_check, resize_root_window): Remove decls.
8622
109e28d0
PE
8623 * window.c (window_deletion_count, delete_deletable_window):
8624 Remove; unused.
46a4ce9e
PE
8625 (window_body_lines): Now static.
8626 (Fdelete_other_windows_internal): Mark vars as initialized.
8627 Make sure 'resize_failed' is initialized.
8628 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8629 (resize_window_apply): Remove unused local.
8630 * window.h (delete_deletable_window): Remove decl.
8631
109e28d0 8632 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8633 (imagemagick_load_image): Fix pointer signedness problem by changing
8634 last arg from unsigned char * to char *. All uses changed.
8635 Also, fix a local for similar reasons.
8636 Remove unused locals. Remove locals to avoid shadowing.
8637 (fn_rsvg_handle_free): Remove; unused.
8638 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8639 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8640
3f754b86
PE
8641 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8642
2547adb1
CY
86432011-06-10 Chong Yidong <cyd@stupidchicken.com>
8644
8645 * image.c (gif_load): Fix omitted cast error introduced by
8646 2011-06-06 change.
8647
2c8e37d4
MR
86482011-06-10 Martin Rudalics <rudalics@gmx.at>
8649
8650 * window.h (resize_proportionally, orig_total_lines)
8651 (orig_top_line): Remove from window structure.
8652 (set_window_height, set_window_width, change_window_heights)
8653 (Fdelete_window): Remove prototypes.
8654 (resize_frame_windows): Remove duplicate declaration.
8655
440a42e3
EZ
86562011-06-10 Eli Zaretskii <eliz@gnu.org>
8657
8658 * window.h (resize_frame_windows, resize_window_check)
8659 (delete_deletable_window, resize_root_window)
8660 (resize_frame_windows): Declare prototypes.
8661
8662 * window.c (resize_window_apply): Make definition be "static" to
8663 match the prototype.
8664
562dd5e9
MR
86652011-06-10 Martin Rudalics <rudalics@gmx.at>
8666
8667 * window.c: Remove declarations of Qwindow_size_fixed,
8668 window_min_size_1, window_min_size_2, window_min_size,
8669 size_window, window_fixed_size_p, enlarge_window, delete_window.
8670 Remove static from declaration of Qdelete_window, it's
8671 temporarily needed by Fbury_buffer.
8672 (replace_window): Don't assign orig_top_line and
8673 orig_total_lines.
8674 (Fdelete_window, delete_window): Remove. Window deletion is
8675 handled by window.el.
640c8776
SM
8676 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8677 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8678 (Fdelete_other_windows): Remove. Deleting other windows is
8679 handled by window.el.
8680 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8681 handled in window.el.
8682 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8683 Window minimum sizes are handled in window.el.
8684 (shrink_windows, size_window, set_window_height)
8685 (set_window_width, change_window_heights, window_height)
8686 (window_width, CURBEG, CURSIZE, enlarge_window)
8687 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8688 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8689 handled in window.el.
8690 (make_dummy_parent): Rename to make_parent_window and give it a
8691 second argument horflag.
8692 (make_window): Don't set resize_proportionally any more.
8693 (Fsplit_window): Remove. Windows are split in window.el.
8694 (save_restore_action, save_restore_orig_size)
8695 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8696 Resize mini windows in window.el.
8697 (grow_mini_window, shrink_mini_window): Implement by calling
8698 Qresize_root_window_vertically, resize_window_check and
8699 resize_window_apply.
640c8776
SM
8700 (saved_window, Fset_window_configuration, save_window_save):
8701 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8702 resize_proportionally.
8703 (window_min_height, window_min_width): Move to window.el.
8704 (keys_of_window): Move bindings for delete-other-windows,
8705 split-window, delete-window and enlarge-window to window.el.
8706
8707 * buffer.c: Temporarily extern Qdelete_window.
8708 (Fbury_buffer): Temporarily call Qdelete_window instead of
8709 Fdelete_window (Fbury_buffer will move to window.el soon).
8710
8711 * frame.c (set_menu_bar_lines_1): Remove code handling
8712 orig_top_line and orig_total_lines.
8713
8714 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8715 set_window_height but set heights directly.
8716 (change_frame_size_1): Use resize_frame_windows.
8717
8718 * xdisp.c (init_xdisp): Don't use set_window_height but set
8719 heights directly.
8720
640c8776
SM
8721 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8722 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8723 run_window_configuration_change_hook.
8724
8725 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8726 instead of change_window_heights and run
8727 run_window_configuration_change_hook.
8728
1a13852e
MR
87292011-06-09 Martin Rudalics <rudalics@gmx.at>
8730
8731 * window.c (replace_window): Rename second argument REPLACEMENT to
8732 NEW. New third argument SETFLAG. Rewrite.
8733 (delete_window, make_dummy_parent): Call replace_window with
8734 third argument 1.
8735 (window_list_1): Move down in code.
8736 (run_window_configuration_change_hook): Move set_buffer part
8737 before select_frame_norecord part in order to unwind correctly.
8738 Rename count1 to count.
8739 (recombine_windows, delete_deletable_window, resize_root_window)
8740 (Fdelete_other_windows_internal)
8741 (Frun_window_configuration_change_hook, make_parent_window)
8742 (resize_window_check, resize_window_apply, Fresize_window_apply)
8743 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8744 (Fdelete_window_internal, Fresize_mini_window_internal):
8745 New functions.
1a13852e
MR
8746 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8747
f3d1777e
MR
87482011-06-08 Martin Rudalics <rudalics@gmx.at>
8749
496e208e
MR
8750 * window.h (window): Add some new members to window structure -
8751 normal_lines, normal_cols, new_total, new_normal, clone_number,
8752 splits, nest, prev_buffers, next_buffers.
8753 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8754 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8755
f3d1777e
MR
8756 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8757 Remove.
496e208e
MR
8758 (make_dummy_parent): Set new members of windows structure.
8759 (make_window): Move down in code. Handle new members of window
8760 structure.
8761 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8762 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8763 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8764 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8765 (Fset_window_next_buffers, Fset_window_clone_number):
8766 New functions.
496e208e
MR
8767 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8768 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8769 Doc-string fixes.
8770 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8771 Argument WINDOW can be now internal window too.
8772 (Fwindow_use_time): Move up in code.
8773 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8774 Rewrite doc-string.
8775 (Fset_window_configuration, saved_window)
8776 (Fcurrent_window_configuration, save_window_save): Handle new
8777 members of window structure.
b9e809c2
MR
8778 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8779 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8780 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8781 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8782 Qget_mru_window, Qresize_root_window,
8783 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8784 Qauto_buffer_name; staticpro them.
f3d1777e 8785
abde8f8c
MR
87862011-06-07 Martin Rudalics <rudalics@gmx.at>
8787
8788 * window.c (Fwindow_total_size, Fwindow_left_column)
8789 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8790 (Fwindow_list_1): New functions.
8791 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8792 (Fwindow_width, Fscroll_left, Fscroll_right):
8793 Use window_body_cols instead of window_box_text_cols.
8794 (delete_window, Fset_window_configuration):
8795 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8796 (delete_all_subwindows): Take a window as argument and not a
8797 structure. Rewrite.
190b47e6
MR
8798 (window_loop): Remove handling of GET_LRU_WINDOW and
8799 GET_LARGEST_WINDOW.
8800 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8801
8802 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8803 window_box_text_cols. delete_all_subwindows now takes a
8804 Lisp_Object as argument.
abde8f8c 8805
640c8776
SM
8806 * indent.c (compute_motion, Fcompute_motion):
8807 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8808
fa8a67e6
MR
8809 * frame.c (delete_frame): Call delete_all_subwindows with root
8810 window as argument.
8811
a54e3482
DC
88122011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8813
8814 * fns.c (Fputhash): Document return value.
8815
60002bf5
CY
88162011-06-06 Chong Yidong <cyd@stupidchicken.com>
8817
8818 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8819
0c671da6 88202011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8821
b862a52a 8822 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8823
be44ca6c
PE
8824 Check for overflow when converting integer to cons and back.
8825 * charset.c (Fdefine_charset_internal, Fdecode_char):
8826 Use cons_to_unsigned to catch overflow.
8827 (Fencode_char): Use INTEGER_TO_CONS.
8828 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8829 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8830 * data.c (long_to_cons, cons_to_long): Remove.
8831 (cons_to_unsigned, cons_to_signed): New functions.
8832 These signal an error for invalid or out-of-range values.
8833 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8834 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8835 * font.c (Ffont_variation_glyphs):
8836 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8837 * lisp.h: Include <intprops.h>.
8838 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8839 (cons_to_signed, cons_to_unsigned): New decls.
8840 (long_to_cons, cons_to_long): Remove decls.
8841 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8842 (Fprimitive_undo): Use CONS_TO_INTEGER.
8843 * xfns.c (Fx_window_property): Likewise.
8844 * xselect.c: Include <limits.h>.
8845 (x_own_selection, selection_data_to_lisp_data):
8846 Use INTEGER_TO_CONS.
8847 (x_handle_selection_request, x_handle_selection_clear)
8848 (x_get_foreign_selection, Fx_disown_selection_internal)
8849 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8850 (lisp_data_to_selection_data): Use cons_to_unsigned.
8851 (x_fill_property_data): Use cons_to_signed.
8852 Report values out of range.
8853
d1f3d2af
PE
8854 Check for buffer and string overflow more precisely.
8855 * buffer.h (BUF_BYTES_MAX): New macro.
8856 * lisp.h (STRING_BYTES_MAX): New macro.
8857 * alloc.c (Fmake_string):
8858 * character.c (string_escape_byte8):
8859 * coding.c (coding_alloc_by_realloc):
8860 * doprnt.c (doprnt):
8861 * editfns.c (Fformat):
8862 * eval.c (verror):
8863 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8864 since they may not be the same number.
8865 * editfns.c (Finsert_char):
8866 * fileio.c (Finsert_file_contents):
8867 Likewise for BUF_BYTES_MAX.
8868
dd52fcea
PE
8869 * image.c: Use ptrdiff_t, not int, for sizes.
8870 (slurp_file): Switch from int to ptrdiff_t.
8871 All uses changed.
8872 (slurp_file): Check that file size fits in both size_t (for
8873 malloc) and ptrdiff_t (for sanity and safety).
8874
7f9bbdbb
PE
8875 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8876 if b->modtime has its maximal value.
8877
dfe18f82
PE
8878 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8879
84acfcf0
PE
8880 Don't assume time_t can fit into int.
8881 * buffer.h (struct buffer.modtime): Now time_t, not int.
8882 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8883 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8884
ccd9a01a
PE
8885 Minor fixes for signed vs unsigned integers.
8886 * character.h (MAYBE_UNIFY_CHAR):
8887 * charset.c (maybe_unify_char):
8888 * keyboard.c (read_char, reorder_modifiers):
8889 XINT -> XFASTINT, since the integer must be nonnegative.
8890 * ftfont.c (ftfont_spec_pattern):
8891 * keymap.c (access_keymap, silly_event_symbol_error):
8892 XUINT -> XFASTINT, since the integer must be nonnegative.
8893 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8894 since it makes no difference and we prefer signed.
8895 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8896 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8897 nonnegative.
8898
d6d100dd
SM
88992011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8900
8901 * window.h (Fwindow_frame): Declare.
8902
2b6148e4
PE
89032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8904
8905 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8906 (SPARE_MEMORY): Always define.
8907 (LARGE_REQUEST): Remove.
8908 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8909
f230ecc9
MR
89102011-06-06 Martin Rudalics <rudalics@gmx.at>
8911
727e958e
MR
8912 * lisp.h: Move EXFUNS for Fframe_root_window,
8913 Fframe_first_window and Fset_frame_selected_window to window.h.
8914
8915 * window.h: Move EXFUNS for Fframe_root_window,
8916 Fframe_first_window and Fset_frame_selected_window here from
8917 lisp.h.
8918
8919 * frame.c (Fwindow_frame, Fframe_first_window)
8920 (Fframe_root_window, Fframe_selected_window)
8921 (Fset_frame_selected_window): Move to window.c.
8922 (Factive_minibuffer_window): Move to minibuf.c.
8923 (Fother_visible_frames_p): New function.
8924
8925 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8926
f230ecc9
MR
8927 * window.c (decode_window, decode_any_window): Move up in code.
8928 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8929 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8930 (Fwindow_buffer): Move up and rewrite doc-string.
8931 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8932 (Fwindow_prev): New functions.
727e958e
MR
8933 (Fwindow_frame): Move here from frame.c. Accept any window as
8934 argument.
8935 (Fframe_root_window, Fframe_first_window)
8936 (Fframe_selected_window): Move here from frame.c. Accept frame
8937 or arbitrary window as argument. Update doc-strings.
8938 (Fminibuffer_window): Move up in code.
8939 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8940 (Fset_frame_selected_window): Move here from frame.c.
8941 Marginal rewrite.
727e958e
MR
8942 (Fselected_window, select_window, Fselect_window): Move up in
8943 code. Minor doc-string fixes.
f230ecc9 8944
4d09bcf6
PE
89452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8946
8947 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8948 Do not assume that spare memory exists; that assumption is valid
8949 only if SYSTEM_MALLOC.
8950 (LARGE_REQUEST): New macro, so that the issue of large requests
8951 is separated from the issue of spare memory.
8952
810928a2
AS
89532011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8954
172418ad
AS
8955 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8956 format. (Bug#8806)
8957
43f862f7
AS
8958 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8959
810928a2
AS
8960 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8961 before statements.
8962
a059fe24
JD
89632011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8964
8965 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8966
8967 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8968
8969 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8970 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8971
989bf368
JB
89722011-06-05 Juanma Barranquero <lekktu@gmail.com>
8973
8974 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8975
4b80f674
CY
89762011-06-04 Chong Yidong <cyd@stupidchicken.com>
8977
8978 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8979 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8980 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8981 New error handlers.
4b80f674
CY
8982 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8983 Obey Vx_select_enable_clipboard_manager. Catch errors in
8984 x_clipboard_manager_save (Bug#8779).
8985 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8986 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8987
99a33b77 89882011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8989
8990 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8991
99a33b77 89922011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8993
8994 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8995 in the current matrix if keep_current_p is non-zero.
8996
8264569d
EZ
89972011-06-04 Eli Zaretskii <eliz@gnu.org>
8998
8999 * bidi.c (bidi_level_of_next_char): Fix last change.
9000
57f97249
EZ
90012011-06-03 Eli Zaretskii <eliz@gnu.org>
9002
fec2107c 9003 Support bidi reordering of text covered by display properties.
57f97249 9004
fec2107c
EZ
9005 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9006 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9007 (bidi_cache_search, bidi_cache_iterator_state)
9008 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9009 (bidi_level_of_next_char, bidi_move_to_visually_next):
9010 Support character positions inside a run of characters covered by a
fec2107c
EZ
9011 display string.
9012 (bidi_paragraph_init, bidi_resolve_explicit_1)
9013 (bidi_level_of_next_char): Call bidi_fetch_char and
9014 bidi_fetch_char_advance instead of FETCH_CHAR and
9015 FETCH_CHAR_ADVANCE.
9016 (bidi_init_it): Initialize new members.
9017 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9018 definitions.
9019 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9020 instead of using explicit *_CHAR codes.
d6d100dd
SM
9021 (bidi_resolve_explicit, bidi_resolve_weak):
9022 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9023 bidirectional text is supported only in multibyte buffers.
9024 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9025 it to initialize the frame_window_p member of struct bidi_it.
9026 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9027 (bidi_resolve_explicit, bidi_resolve_weak)
9028 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9029 bidi_it->nchars is non-positive.
9030 (bidi_level_of_next_char): Don't try to lookup the cache for the
9031 next/previous character if nothing is cached there yet, or if we
9032 were just reseat()'ed to a new position.
c40e2fb2 9033
0e14fe90
EZ
9034 * xdisp.c (set_cursor_from_row): Set start and stop points
9035 according to the row's direction when priming the loop that looks
9036 for the glyph on which to display cursor.
9037 (single_display_spec_intangible_p): Function deleted.
9038 (display_prop_intangible_p): Reimplement to call
9039 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9040 Accept 3 additional arguments needed by handle_display_spec.
9041 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9042 values: lists, `(when COND...)' forms, etc.
9043 (single_display_spec_string_p): Support property values that are
9044 lists with the argument STRING its top-level element.
9045 (display_prop_string_p): Fix the condition for processing a
9046 property that is a list to be consistent with handle_display_spec.
fec2107c 9047 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9048 last portion of handle_display_prop.
9049 (compute_display_string_pos): Accept additional argument
9050 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9051 value of a `display' property is a "replacing spec".
9052 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9053 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9054 the display property, but just return a value indicating whether
9055 the display property will replace the characters it covers.
9056 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9057 frame_window_p members of struct bidi_it.
d6d100dd
SM
9058 (compute_display_string_pos, compute_display_string_end):
9059 New functions.
fec2107c
EZ
9060 (push_it): Accept second argument POSITION, where pop_it should
9061 jump to continue iteration.
9062 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9063
fec2107c
EZ
9064 * keyboard.c (adjust_point_for_property): Adjust the call to
9065 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9066
9067 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9068 (bidi_init_it): Update prototypes.
9069 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9070 (compute_display_string_pos, compute_display_string_end):
9071 Declare prototypes.
fec2107c
EZ
9072 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9073 EMACS_INT.
fc6f18ce 9074
40087514 90752011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9076
57f53182
PE
9077 Malloc failure behavior now depends on size of allocation.
9078 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9079 * lisp.h: Change signatures accordingly.
9080 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9081 All callers changed. (Bug#8762)
9082
9083 * gnutls.c: Use Emacs's memory allocators.
9084 Without this change, the gnutls library would invoke malloc etc.
9085 directly, which causes problems on non-SYNC_INPUT hosts, and which
9086 runs afoul of improving memory_full behavior. (Bug#8761)
9087 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9088 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9089 xfree instead of the default malloc, realloc, free.
9090 (Fgnutls_boot): No need to check for memory allocation failure,
9091 since xmalloc does that for us.
9092
ac32cd99 9093 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9094 * category.c (hash_get_category_set):
9095 * ccl.c (ccl_driver):
9096 * charset.c (Fdefine_charset_internal):
9097 * charset.h (struct charset.hash_index):
9098 * composite.c (get_composition_id, gstring_lookup_cache)
9099 (composition_gstring_put_cache):
9100 * composite.h (struct composition.hash_index):
9101 * dispextern.h (struct image.hash):
9102 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9103 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9104 (hashfn_equal, hashfn_user_defined, make_hash_table)
9105 (maybe_resize_hash_table, hash_lookup, hash_put)
9106 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9107 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9108 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9109 * image.c (make_image, search_image_cache, lookup_image)
9110 (xpm_put_color_table_h):
9111 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9112 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9113 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9114 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9115 * alloc.c (allocate_vectorlike):
9116 Check for overflow in vector size calculations.
9117 * ccl.c (ccl_driver):
9118 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9119 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9120 need to be updated by these changes.
40087514
PE
9121 * fns.c (make_hash_table, maybe_resize_hash_table):
9122 Check for integer overflow with large hash tables.
0de4bb68
PE
9123 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9124 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9125 (SXHASH_REDUCE): New macro.
9126 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9127 Use it instead of discarding useful hash info with large hash values.
9128 (sxhash_float): New function.
9129 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9130 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9131 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9132 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9133 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9134 Adjust signatures to match updated version of code.
9135 (consing_since_gc): Now EMACS_INT, since a single hash table can
9136 use more than INT_MAX bytes.
9137
698d32e2
DN
91382011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9139
9140 Make it possible to build with GCC-4.6+ -O2 -flto.
9141
9142 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9143
fd6fa53f
SM
91442011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9145
9146 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9147 Call minibuffer-inactive-mode.
9148
864db017
JB
91492011-05-31 Juanma Barranquero <lekktu@gmail.com>
9150
9151 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9152 Update dependencies.
9153
2ad0baf4
DN
91542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9155
9156 * data.c (init_data): Remove code for UTS, this system is not
9157 supported anymore.
9158
4fcc2638
DN
91592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9160
9161 Don't force ./temacs to start in terminal mode.
9162
9163 * frame.c (make_initial_frame): Initialize faces in all cases, not
9164 only when CANNOT_DUMP is defined.
9165 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9166
c56e0fd5
DN
91672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9168
9169 * dispnew.c (add_window_display_history): Use const for the string
9170 pointer. Remove declaration, not needed.
9171
333d54da 91722011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9173
55d4c1b2 9174 Use 'inline', not 'INLINE'.
333d54da 9175 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9176 * alloc.c, fontset.c (INLINE): Remove.
9177 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9178 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9179 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9180 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9181 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9182
738db178
DN
91832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9184
9185 Make it possible to run ./temacs.
9186
9187 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9188 syms_of_callproc does the same thing. Remove test for
9189 "initialized", do it in the caller.
9190 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9191
620c53a6
SM
91922011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9193
9194 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9195 (read_minibuf): Use get_minibuffer.
9196 (syms_of_minibuf): Use DEFSYM.
9197 (Qmetadata): New var.
9198 * data.c (Qbuffer): Don't make it static.
9199 (syms_of_data): Use DEFSYM.
9200
e003a292
PE
92012011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9202
9203 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9204 (CCL_CODE_MIN): New macro.
9205
ed008a6d
PE
92062011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9207
3687c2ef
PE
9208 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9209
ed008a6d
PE
9210 * eval.c (Qdebug): Now static.
9211 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9212 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9213 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9214
d66c4c7c
CY
92152011-05-29 Chong Yidong <cyd@stupidchicken.com>
9216
9217 * image.c: Various fixes to ImageMagick code comments.
9218 (Fimagemagick_types): Doc fix.
9219
5fbc2025
PE
92202011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9221
0196f88a
PE
9222 Minor fixes prompted by GCC 4.6.0 warnings.
9223
9224 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9225
5fbc2025
PE
9226 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9227 (x_clipboard_manager_save_all): Move extern decl to ...
9228 * xterm.h: ... here, so that it can be checked for consistency.
9229
1dd3c2d9
CY
92302011-05-29 Chong Yidong <cyd@stupidchicken.com>
9231
9232 * xselect.c (x_clipboard_manager_save_frame)
9233 (x_clipboard_manager_save_all): New functions.
9234 (Fx_clipboard_manager_save): Lisp function deleted.
9235
9236 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9237 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9238
9239 * xterm.h: Update prototype.
9240
5ba6571d
WX
92412011-05-28 William Xu <william.xwl@gmail.com>
9242
9243 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9244 exiting (Bug#8239).
9245
3eaff834
JM
92462011-05-28 Jim Meyering <meyering@redhat.com>
9247
e1900994 9248 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9249 * fns.c (to_uchar): Define.
9250 (crypto_hash_function): Use it to convert some newly-signed
9251 variables to unsigned, to avoid sign-extension bugs. For example,
9252 without this change, (md5 "truc") would evaluate to
9253 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9254 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9255 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9256
0f6990a7
PE
92572011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9258
9259 Integer overflow fixes.
c8a9ca5a 9260
08686060
PE
9261 * dbusbind.c: Serial number integer overflow fixes.
9262 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9263 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9264 to hold a serial number that is too large for a fixnum.
9265 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9266 Check for serial numbers out of range. Decode any serial number
59568bf0 9267 that was so large that it became a float. (Bug#8722)
08686060 9268
2d1fc3c7
PE
9269 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9270 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9271 Use XFASTINT rather than XUINT when numbers are nonnegative.
9272 (xd_append_arg, Fdbus_method_return_internal):
9273 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9274 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9275 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9276 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9277 (Bug#8722)
2d1fc3c7 9278
c8a9ca5a
PE
9279 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9280
519e1d69
PE
9281 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9282
6df6ae42 9283 ccl: Add integer overflow checks.
30569699
PE
9284 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9285 (IN_INT_RANGE): New macros.
9286 (ccl_driver): Use them to check for integer overflow when
9287 decoding a CCL program. Many of the new checks are whether XINT (x)
9288 fits in int; it doesn't always, on 64-bit hosts. The new version
9289 doesn't catch all possible integer overflows, but it's an
847044ea 9290 improvement. (Bug#8719)
30569699 9291
c11285dc
PE
9292 * alloc.c (make_event_array): Use XINT, not XUINT.
9293 There's no need for unsigned here.
9294
fdccd48e
PE
9295 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9296 This follows up to the 2011-05-06 change that substituted uintptr_t
9297 for EMACS_INT. This case wasn't caught back then.
9298
37910ab2
PE
9299 Rework Fformat to avoid integer overflow issues.
9300 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9301 now (part of C89). Include <verify.h>.
9302 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9303 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9304 (Fformat): Avoid the prepass trying to compute sizes; it was only
9305 approximate and thus did not catch overflow reliably. Instead, walk
9306 through the format just once, formatting and computing sizes as we go,
9307 checking for integer overflow at every step, and allocating a larger
9308 buffer as needed. Keep track separately whether the format is
9309 multibyte. Keep only the most-recently calculated precision, rather
9310 than them all. Record whether each argument has been converted to
9311 string. Use EMACS_INT, not int, for byte and char and arg counts.
9312 Support field widths and precisions larger than INT_MAX. Avoid
9313 sprintf's undefined behavior with conversion specifications such as %#d
9314 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9315 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9316 formatting out-of-range floating point numbers with int
9173deec 9317 formats. (Bug#8668)
37910ab2 9318
2e6578fb
PE
9319 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9320
0ae6bdee
PE
9321 * data.c: Avoid integer truncation in expressions involving floats.
9322 * data.c: Include <intprops.h>.
9323 (arith_driver): When there's an integer overflow in an expression
9324 involving floating point, convert the integers to floating point
9325 so that the resulting value does not suffer from catastrophic
9326 integer truncation. For example, on a 64-bit host (* 4
9327 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9328 Do not rely on undefined behavior after integer overflow.
9329
de883a70
PE
9330 merge count_size_as_multibyte, parse_str_to_multibyte
9331 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9332 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9333 Check for integer overflow.
9334 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9335 since it's now a duplicate of the other. This is more of
9336 a character than a buffer op, so better that it's in character.c.
9337 * fns.c, print.c: Adjust to above changes.
9338
2ff916cb
PE
93392011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9340
9341 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9342
f1b54466
PE
93432011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9344
fb1ac845
PE
9345 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9346 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9347 (x_clipboard_manager_save): Now static.
9348 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9349
f1b54466
PE
9350 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9351 (crypto_hash_function): Now static.
9352 Fix pointer signedness problems. Avoid unnecessary initializations.
9353
a9f737ee
CY
93542011-05-27 Chong Yidong <cyd@stupidchicken.com>
9355
9356 * termhooks.h (Vselection_alist): Make it terminal-local.
9357
9358 * terminal.c (create_terminal): Initialize it.
9359
9360 * xselect.c: Support for clipboard managers.
9361 (Vselection_alist): Move to termhooks.h as terminal-local var.
9362 (LOCAL_SELECTION): New macro.
9363 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9364 (symbol_to_x_atom): Remove gratuitous arg.
9365 (x_handle_selection_request, lisp_data_to_selection_data)
9366 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9367 (x_own_selection, x_get_local_selection, x_convert_selection):
9368 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9369 (some_frame_on_display): Delete unused function.
9370 (Fx_own_selection_internal, Fx_get_selection_internal)
9371 (Fx_disown_selection_internal, Fx_selection_owner_p)
9372 (Fx_selection_exists_p): New optional frame arg.
9373 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9374 (x_handle_selection_clear): Don't treat other terminals with the
9375 same keyboard specially. Use the terminal-local Vselection_alist.
9376 (x_clear_frame_selections): Use Frun_hook_with_args.
9377
9378 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9379
9380 * xterm.h: Add support for those atoms.
9381
e067f0c1
CY
93822011-05-26 Chong Yidong <cyd@stupidchicken.com>
9383
9384 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9385 (converted_selections, conversion_fail_tag): New global variables.
9386 (x_selection_request_lisp_error): Free the above.
9387 (x_get_local_selection): Remove unnecessary code.
9388 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9389 of converted selections stored in converted_selections.
9390 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9391 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9392 (x_convert_selection): New function.
9393 (x_handle_selection_event): Simplify.
9394 (x_get_foreign_selection): Don't ignore incoming requests while
9395 waiting for an answer; this will fail when we implement
9396 SAVE_TARGETS, and seems unnecessary anyway.
9397 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9398 (Vx_sent_selection_functions): Doc fix.
9399
0f4aebc0
LL
94002011-05-26 Leo Liu <sdl.web@gmail.com>
9401
9402 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9403
e61124cd
YM
94042011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9405
9406 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9407
9408 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9409 for fringe update if it has periodic bitmap.
ac389d0c 9410 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9411 and fringe_bitmap_periodic_p.
9412
9413 * fringe.c (get_fringe_bitmap_data): New function.
9414 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9415 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9416 row. Mark glyph row for fringe update if periodicity changed.
9417
9418 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9419 for fringe update unless it has periodic bitmap.
9420
f16d9837
KH
94212011-05-25 Kenichi Handa <handa@m17n.org>
9422
9423 * xdisp.c (get_next_display_element): Set correct it->face_id for
9424 a static composition.
9425
e1b90ef6
LL
94262011-05-24 Leo Liu <sdl.web@gmail.com>
9427
9428 * deps.mk (fns.o):
9429 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9430
9431 * fns.c (crypto_hash_function, Fsha1): New function.
9432 (Fmd5): Use crypto_hash_function.
9433 (syms_of_fns): Add Ssha1.
9434
7400048f
PE
94352011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9436
9437 * gnutls.c: Remove unused macros.
9438 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9439 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9440 Remove macros that are defined and never used.
9441 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9442
abb71cf4
CY
94432011-05-22 Chong Yidong <cyd@stupidchicken.com>
9444
9445 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9446 (Fx_get_selection_internal): Minor cleanup.
9447 (Fx_own_selection_internal): Rename arguments for consistency with
9448 select.el.
9449
6307db39
PE
94502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9451
9452 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9453
f3d4e0a4
CY
94542011-05-22 Chong Yidong <cyd@stupidchicken.com>
9455
9456 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9457
4d8ade89
YM
94582011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9459
9460 * dispnew.c (scrolling_window): Don't exclude the case that the
9461 last enabled row in the desired matrix touches the bottom boundary.
9462
32078c8d
GM
94632011-05-21 Glenn Morris <rgm@gnu.org>
9464
9465 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9466 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9467 and add some more files.
32078c8d 9468
7285dc67
EZ
94692011-05-20 Eli Zaretskii <eliz@gnu.org>
9470
9471 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9472 report_file_error introduced by the change from 2011-05-07.
9473
89d1bd22
PE
94742011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9475
9476 * systime.h (Time): Define only if emacs is defined.
9477 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9478 where the include path doesn't have X11/X.h by default. See
9479 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9480
cd394be1 94812011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9482
9483 * composite.c (find_automatic_composition): Fix previous change.
9484
b9704ad9
GM
94852011-05-20 Glenn Morris <rgm@gnu.org>
9486
9487 * lisp.mk: New file, split from Makefile.in.
9488 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9489 (shortlisp): Remove.
9490 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9491
4a720484
GM
94922011-05-19 Glenn Morris <rgm@gnu.org>
9493
9494 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9495 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9496 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9497 (lisp): Set the order to that of loadup.el.
9498 (shortlisp): Make it a copy of $lisp.
9499 (SOME_MACHINE_LISP): Remove.
9500 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9501 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9502
a28d4396
KH
95032011-05-18 Kenichi Handa <handa@m17n.org>
9504
9505 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9506 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9507 (find_automatic_composition): Mostly rewrite for efficiency.
9508
a2b1fa8e
JB
95092011-05-18 Juanma Barranquero <lekktu@gmail.com>
9510
9511 * makefile.w32-in: Update dependencies.
9512
8e1f5610
CS
95132011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9514
9515 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9516 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9517
7025ee00 95182011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9519
cdfa6eab
PE
9520 Fix some integer overflow issues, such as string length overflow.
9521
06d6db33
PE
9522 * insdel.c (count_size_as_multibyte): Check for string overflow.
9523
2b4560a8
PE
9524 * character.c (lisp_string_width): Check for string overflow.
9525 Use EMACS_INT, not int, for string indexes and lengths; in
9526 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9527 the resulting string length overflows an EMACS_INT; instead,
9528 report a string overflow if no precision given. When checking for
9529 precision exhaustion, use a check that cannot possibly have
9530 integer overflow. (Bug#8675)
9531 * character.h (lisp_string_width): Adjust to new signature.
9532
cb93f9be
PE
9533 * alloc.c (string_overflow): New function.
9534 (Fmake_string): Use it. This doesn't change behavior, but saves
9535 a few bytes and will simplify future changes.
9536 * character.c (string_escape_byte8): Likewise.
9537 * lisp.h (string_overflow): New decl.
9538
1a1f3366
PE
9539 Fixups, following up to the user-interface timestamp change.
9540 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9541 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9542 * msdos.c (mouse_get_pos): Likewise.
9543 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9544 * w32gui.h (Time): Define by including "systime.h" rather than by
9545 declaring it ourselves. (Bug#8664)
9546
d4e3e4d3
PE
9547 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9548 * image.c (clear_image_cache): Likewise.
9549
f6a24d19
PE
9550 * term.c (term_mouse_position): Don't assume time_t wraparound.
9551
08dc5ae6
PE
9552 Be more systematic about user-interface timestamps.
9553 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9554 and sometimes 'EMACS_UINT', to represent these timestamps.
9555 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9556 This makes the code easier to follow, and makes it easier to catch
9557 integer overflow bugs such as Bug#8664.
9558 * frame.c (Fmouse_position, Fmouse_pixel_position):
9559 Use Time, not unsigned long, for user-interface timestamps.
9560 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9561 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9562 * keyboard.h (last_event_timestamp): Likewise.
9563 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9564 * menu.h (xmenu_show): Likewise.
9565 * term.c (term_mouse_position): Likewise.
9566 * termhooks.h (struct input_event.timestamp): Likewise.
9567 (struct terminal.mouse_position_hook): Likewise.
9568 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9569 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9570 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9571 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9572 what it was before.
9573 * menu.h, termhooks.h: Include "systime.h", for Time.
9574
8e55734a
PE
9575 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9576 Don't assume that the difference between two unsigned long values
9577 can fit into an integer. At this point, we know button_down_time
9578 <= event->timestamp, so the difference must be nonnegative, so
9579 there's no need to cast the result if double-click-time is
9580 nonnegative, as it should be; check that it's nonnegative, just in
9581 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9582 apart (about 25 days). (Bug#8664)
8e55734a 9583
841f1b75 9584 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9585 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9586
3e26f69c
PE
9587 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9588 that always fit in int. Use a sentinel instead of a counter, to
9589 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9590 * frame.h (struct frame): Use int for menu_bar_items_used
9591 instead of EMACS_INT, since it always fits in int.
3e26f69c 9592
5cc152c0
PE
9593 * menu.c (grow_menu_items): Check for int overflow.
9594
d89eb65e
PE
9595 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9596
5235bd3e
PE
9597 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9598 Before, the code was not consistent. These values cannot exceed
9599 2**31 - 1 so there's no need to make them unsigned.
9600 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9601 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9602 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9603 as modifiers.
9604 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9605
bc827e23
PE
9606 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9607 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9608 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9609 presumably because the widths might not match.
9610
78eb494e
PE
9611 * window.c (size_window): Avoid needless test at loop start.
9612
04f2d78b
CB
96132011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9614
9615 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9616
d2fc7e3d 96172011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9618
9619 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9620
d2fc7e3d 96212011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9622
9623 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9624 `width' to `bar_area_x' and `bar_area_width', respectively.
9625 (x_scroll_run): Take account of fringe background extension.
9626
04f2d78b
CB
9627 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9628 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9629 `bar_area_width', respectively.
9630 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9631 background extension.
9632
79b70037
GM
96332011-05-10 Jim Meyering <meyering@redhat.com>
9634
9635 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9636
2f142cc5
JB
96372011-05-10 Juanma Barranquero <lekktu@gmail.com>
9638
9639 * image.c (Finit_image_library): Return t for built-in image types,
9640 like pbm and xbm. (Bug#8640)
9641
57679c86
AS
96422011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9643
9644 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9645
888c9e86
EZ
96462011-05-07 Eli Zaretskii <eliz@gnu.org>
9647
b0512a1d
EZ
9648 * w32console.c (Fset_screen_color): Doc fix.
9649 (Fget_screen_color): New function.
9650 (syms_of_ntterm): Defsubr it.
9651
7285dc67
EZ
9652 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9653 unlink the temporary file if Fcall_process didn't create it in the
9654 first place.
9655 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9656 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9657 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9658 cue to call_process_cleanup not to close that handle.
9659
4d3fcc8e
BK
96602011-05-07 Ben Key <bkey76@gmail.com>
9661
9662 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9663 one of two shell specific rules, either bootstrap-temacs-CMD or
9664 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9665 to the previous implementation of the bootstrap-temacs rule.
9666 The bootstrap-temacs-CMD rule is similar to the previous
9667 implementation of the bootstrap-temacs rule except that it
9668 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9669 variable.
9670
9671 These changes, along with some changes to nt/configure.bat,
9672 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9673 earlier fix to add support for --cflags and --ldflags options
9674 that include quotes so that it works whether make uses cmd or
9675 sh as the shell.
9676
b4289b64
MA
96772011-05-06 Michael Albinus <michael.albinus@gmx.de>
9678
9679 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9680 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9681 is a constant.
9682 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9683 a string. Handle both cases.
9684 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9685 (Fdbus_register_method): Use Qinvalid_function.
9686
af4c0e28
JB
96872011-05-06 Juanma Barranquero <lekktu@gmail.com>
9688
9689 * makefile.w32-in: Update dependencies.
9690 (LISP_H): Add inttypes.h and stdin.h.
9691 (PROCESS_H): Add unistd.h.
9692
c51453d9
EZ
96932011-05-06 Eli Zaretskii <eliz@gnu.org>
9694
9695 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9696 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9697
8ff0ac3c 96982011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9699
4c4b566b
PE
9700 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9701
aab2b9b5
PE
9702 * term.c (vfatal): Remove stray call to va_end.
9703 It's not needed and the C Standard doesn't allow it here anyway.
9704
c378da0b
PE
9705 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9706 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9707
288b08c7
PE
9708 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9709 bytes.
9710
e3601888
PE
9711 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9712
db6c0e74
PE
9713 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9714
dd5963ea
PE
9715 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9716
88c9450f
PE
9717 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9718
2f9442b8
PE
9719 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9720
c032b5f8
PE
9721 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9722 * charset.c (Fdefine_charset_internal): Don't initialize
9723 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9724 32-bit int (Bug#8600).
a108c10b
PE
9725
9726 * lread.c (read_integer): Be more consistent with string-to-number.
9727 Use string_to_number to do the actual conversion; this avoids
9728 rounding errors and fixes some other screwups. Without this fix,
9729 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9730 (digit_to_number): Move earlier, for benefit of read_integer.
9731 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9732 not a digit in any supported base. (Bug#8602)
a108c10b 9733
ad5f9eea
PE
9734 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9735
aec1708a
PE
9736 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9737 to match comment at start of function. This also removes a
9738 GCC warning about overflow in a 32+64-bit port.
9739
47be4ab5
PE
9740 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9741
371cac43
PE
9742 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9743 Reported by Stefan Monnier in
9744 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9745 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9746 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9747
d01a7826
PE
9748 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9749 (EMACS_UINTPTR): Likewise, with uintptr_t.
9750
7fd47d5c
PE
9751 * lisp.h: Prefer 64-bit EMACS_INT if available.
9752 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9753 on 32-bit hosts that have 64-bit int, so that they can access
9754 large files.
122b0c86
PE
9755 However, temporarily disable this change unless the temporary
9756 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9757
8727937b
PE
9758 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9759
8ac068ac
PE
9760 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9761 This removes an assumption that EMACS_INT and long are the same
9762 width as pointers. The assumption is true for Emacs porting targets
9763 now, but we want to make other targets possible.
9764 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9765 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9766 In the rest of the code, change types of integers that hold casted
9767 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9768 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9769 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9770 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9771 No need to cast type when ORing.
9772 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9773 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9774 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9775 assume EMACS_INT is the same width as char *.
9776 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9777 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9778 Remove no-longer-needed casts.
9779 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9780 (xg_tool_bar_help_callback, xg_make_tool_item):
9781 Use EMACS_INTPTR to hold an integer
9782 that will be cast to void *; this can avoid a GCC warning
9783 if EMACS_INT is not the same width as void *.
9784 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9785 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9786 (current_message_1, set_message_1):
9787 Use a local to convert to proper width without a cast.
9788 * xmenu.c (dialog_selection_callback): Likewise.
9789
ede49d71
PE
9790 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9791 Also, don't assume VALBITS / RAND_BITS is less than 5,
9792 and don't rely on undefined behavior when shifting a 1 left into
9793 the sign bit.
9794 * lisp.h (get_random): Change signature to match.
9795
2f30ecd0
PE
9796 * lread.c (hash_string): Use size_t, not int, for hash computation.
9797 Normally we prefer signed values; but hashing is special, because
9798 it's better to use unsigned division on hash table sizes so that
9799 the remainder is nonnegative. Also, size_t is the natural width
9800 for hashing into memory. The previous code used 'int', which doesn't
9801 retain enough info to hash well into very large tables.
9802 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9803
2a866e7b
PE
9804 * dbusbind.c: Don't possibly lose pointer info when converting.
9805 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9806 Use XPNTR rather than XHASH, so that the high-order bits of
9807 the pointer aren't lost when converting through void *.
9808
51639eac
PE
9809 * eval.c (Fautoload): Don't double-shift a pointer.
9810
92394119
PE
9811 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9812
dbdb9a7c
JB
98132011-05-06 Juanma Barranquero <lekktu@gmail.com>
9814
9815 * gnutls.c (DEF_GNUTLS_FN):
9816 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9817
db7a0b4f
AS
98182011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9819
9820 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9821 marker. (Bug#8610)
9822
cd394be1 98232011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9824
9825 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9826 New version that can reserve upto 2GB of heap space.
9827
f7ff1b0f 98282011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9829
9830 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9831
639c109b
TZ
98322011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9833
9834 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9835 `gnutls_certificate_set_x509_key_file'.
9836
d2127135
JB
98372011-05-05 Juanma Barranquero <lekktu@gmail.com>
9838
9839 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9840 Update dependencies.
9841
e968f4f3
JB
98422011-05-04 Juanma Barranquero <lekktu@gmail.com>
9843
9844 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9845 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9846 Remove unused parameter `fildes'.
9847 * process.c (read_process_output, send_process): Don't pass it.
9848
84d358f0
JB
98492011-05-04 Juanma Barranquero <lekktu@gmail.com>
9850
9851 Fix previous change: the library cache is defined in w32.c.
9852 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9853 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9854
0898ca10
JB
98552011-05-04 Juanma Barranquero <lekktu@gmail.com>
9856
9857 Implement dynamic loading of GnuTLS on Windows.
9858
9859 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9860 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9861 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9862 Declare.
9863
9864 * gnutls.c (Qgnutls_dll): Define.
9865 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9866 (gnutls_*): Declare function pointers.
9867 (init_gnutls_functions): New function to initialize function pointers.
9868 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9869 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9870 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9871 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9872 (emacs_gnutls_write, emacs_gnutls_read)
9873 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9874 (Fgnutls_available_p): New function.
9875 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9876 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9877 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9878
9879 * image.c: Include w32.h.
9880 (Vimage_type_cache): Delete.
9881 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9882 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9883 (w32_delayed_load): Move to w32.c.
9884
9885 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9886
9887 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9888 (w32_delayed_load): Move from image.c. When loading a library, record
9889 its filename in the :loaded-from property of the library id.
9890 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9891 Initialize and staticpro them.
9892 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9893
9894 * process.c: Include lisp.h before w32.h, not after.
9895 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9896 instead of gnutls_record_check_pending.
9897
9898 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9899
ff4de4aa
TZ
99002011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9901
9902 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9903 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9904 as passed in.
9905
abe95abb
JD
99062011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9907
9908 * xterm.c (x_set_frame_alpha): Do not set property on anything
9909 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9910
e16e55d4
JB
99112011-05-02 Juanma Barranquero <lekktu@gmail.com>
9912
9913 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9914
bafcf6a5
JB
99152011-05-02 Juanma Barranquero <lekktu@gmail.com>
9916
9917 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9918 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9919 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9920 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9921 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9922 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9923 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9924 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9925 (Qgnutls_bootprop_callbacks_verify): Make static.
9926
e7a6747f
AS
99272011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9928
19ed11ba
AS
9929 * callproc.c: Indentation fixup.
9930
e7a6747f 9931 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9932 (wait_for_termination, interruptible_wait_for_termination):
9933 Move after wait_for_termination_1.
e7a6747f 9934
1ef14cb4
LMI
99352011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9936
9937 * sysdep.c (interruptible_wait_for_termination): New function
9938 which is like wait_for_termination, but allows keyboard
9939 interruptions.
9940
9941 * callproc.c (Fcall_process): Add (:file "file") as an option for
9942 the STDOUT buffer.
9943 (Fcall_process_region): Ditto.
9944
330d880c
EZ
99452011-04-30 Eli Zaretskii <eliz@gnu.org>
9946
8db90b73
EZ
9947 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9948 rather than `XVECTOR (FOO)->size'.
9949
330d880c
EZ
9950 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9951 inttypes.h, as a gnulib replacement is used if it not available in
9952 system headers.
9953
15cbd324
EZ
99542011-04-21 Eli Zaretskii <eliz@gnu.org>
9955
9956 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9957 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9958 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9959
9960 * coding.c (coding_alloc_by_realloc): Error out if destination
9961 will grow beyond MOST_POSITIVE_FIXNUM.
9962 (decode_coding_emacs_mule): Abort if there isn't enough place in
9963 charbuf for the composition carryover bytes. Reserve an extra
9964 space for up to 2 characters produced in a loop.
9965 (decode_coding_iso_2022): Abort if there isn't enough place in
9966 charbuf for the composition carryover bytes.
9967
99682011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9969
ae940cca
EZ
9970 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9971 aborting when %lld or %lll format is passed.
9972 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9973 %llo or %llx format is passed. (Bug#8545)
9974
03ab8921
EZ
9975 * window.c (window_scroll_line_based): Use a marker instead of
9976 simple variables to record original value of point. (Bug#7952)
9977
afda1437
EZ
9978 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9979 produced by %s or %c overflows available buffer space. (Bug#8545)
9980
f76dee0c
PE
99812011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9982
9983 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9984 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9985
fdc5744d
JB
99862011-04-28 Juanma Barranquero <lekktu@gmail.com>
9987
9988 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9989
638f053a
JB
99902011-04-28 Juanma Barranquero <lekktu@gmail.com>
9991
9992 * keyboard.c (Qdelayed_warnings_hook): Define.
9993 (command_loop_1): Run `delayed-warnings-hook'
9994 if Vdelayed_warnings_list is non-nil.
9995 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9996 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9997
d178f871
EZ
99982011-04-28 Eli Zaretskii <eliz@gnu.org>
9999
10000 * doprnt.c (doprnt): Don't return value smaller than the buffer
10001 size if the message was truncated. (Bug#8545).
10002
b124fd93
JB
100032011-04-28 Juanma Barranquero <lekktu@gmail.com>
10004
10005 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10006 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10007
e810457d
PE
100082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10009
10010 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10011
ea51cceb
JB
100122011-04-27 Juanma Barranquero <lekktu@gmail.com>
10013
10014 * makefile.w32-in: Update dependencies.
10015
94dcfacf
EZ
100162011-04-27 Eli Zaretskii <eliz@gnu.org>
10017
10018 Improve `doprnt' and its usage. (Bug#8545)
10019 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10020 `format_end'. Remove support for %l as a conversion specifier.
10021 Don't use xrealloc. Improve diagnostics when the %l size modifier
10022 is used. Update the commentary.
10023
10024 * eval.c (verror): Simplify calculation of size_t.
10025
10026 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10027 messages.
10028
f61f41d7
PE
100292011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10030
10031 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10032 change.
10033
96fb4434
PE
100342011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10035
10036 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10037 This makes this file independent of the recent pseudovector change.
10038
671875da 100392011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10040
69e9b5a3
PE
10041 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10042
b5f869a7 10043 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10044 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10045 Remove unused local.
c8926152 10046 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10047
841a1577 10048 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10049 GCC 4.6.0 optimizes based on type-based alias analysis.
10050 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10051 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10052 != &v->size, and therefore "v->size = 1; b->size = 2; return
10053 v->size;" must therefore return 1. This assumption is incorrect
10054 for Emacs, since it type-puns struct Lisp_Vector * with many other
10055 types. To fix this problem, this patch adds a new type struct
f904488f 10056 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10057 and pseudovectors, and helps optimizing compilers not get fooled
10058 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10059 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10060 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10061 the size member.
eab3844f
PE
10062 (XSETPVECTYPE): Rewrite in terms of new macro.
10063 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10064 This is a bit clearer, and further avoids the possibility of
10065 undesirable aliasing.
10066 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10067 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10068 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10069 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10070 (ASIZE): Now uses header.size rather than size.
10071 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10072 to avoid the hassle of writing XVECTOR (foo)->header.size.
10073 (struct vectorlike_header): New type.
eab3844f
PE
10074 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10075 object, to help avoid aliasing.
10076 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10077 (SUBRP): Likewise, since Lisp_Subr is a special case.
10078 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10079 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10080 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10081 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10082 changed to be "header.size" and "header.next".
10083 * buffer.h (struct buffer): Likewise.
10084 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10085 * frame.h (struct frame): Likewise.
10086 * process.h (struct Lisp_Process): Likewise.
10087 * termhooks.h (struct terminal): Likewise.
10088 * window.c (struct save_window_data, struct saved_window): Likewise.
10089 * window.h (struct window): Likewise.
10090 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10091 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10092 * buffer.c (init_buffer_once): Likewise.
10093 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10094 special case.
10095 * process.c (Fformat_network_address): Use local var for size,
10096 for brevity.
10097
0df1eac5
PE
10098 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10099
847ab9d1 10100 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10101 * data.c (atof): Remove decl; no longer used or needed.
10102 (digit_to_number): Move to lread.c.
10103 (Fstring_to_number): Use new string_to_number function, to be
10104 consistent with how the Lisp reader treats infinities and NaNs.
10105 Do not assume that floating-point numbers represent EMACS_INT
10106 without losing information; this is not true on most 64-bit hosts.
10107 Avoid double-rounding errors, by insisting on integers when
10108 parsing non-base-10 numbers, as the documentation specifies.
10109 * lisp.h (string_to_number): New decl, replacing ...
10110 (isfloat_string): Remove.
bc0a5c13 10111 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10112 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10113 appears to have been a coding error. Similarly, do not accept
10114 strings like +-1e0 as floating point numbers. Do not report
10115 overflow for integer overflows unless the base is not 10 which
10116 means we have no simple and reliable way to continue.
10117 Break out the floating-point parsing into a new
10118 function string_to_number, so that Fstring_to_number parses
10119 floating point numbers consistently with the Lisp reader.
04f2d78b 10120 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10121 (E_CHAR, EXP_INT): Remove, replacing with ...
10122 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10123 (string_to_number): New function, replacing isfloat_string.
10124 This function checks for valid syntax and produces the resulting
10125 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10126 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10127 so that overflow for non-base-10 numbers is reported only when
10128 there's no portable and simple way to convert to floating point.
452f4150 10129
67769ffc
PE
10130 * textprop.c (set_text_properties_1): Rewrite for clarity,
10131 and to avoid GCC warning about integer overflow.
10132
c20db43f
PE
10133 * intervals.h (struct interval): Use EMACS_INT for members
10134 where EMACS_UINT might cause problems. See
10135 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10136 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10137 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10138 All uses changed.
37aa2f85
PE
10139 (offset_intervals): Tell GCC not to worry about length overflow
10140 when negating a negative length.
c20db43f 10141
2538aa2f
PE
10142 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10143 (overrun_check_free): Likewise.
10144
f2d3008d
PE
10145 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10146 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10147 word size.
10148
ec8df744
PE
10149 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10150 (gnutls_make_error): Rename local to avoid shadowing.
10151 (gnutls_emacs_global_deinit): ifdef out; not used.
10152 (Fgnutls_boot): Use const for pointer to readonly storage.
10153 Comment out unused local. Fix pointer signedness problems.
10154
640ee02d
PE
10155 * lread.c (openp): Don't stuff size_t into an 'int'.
10156 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10157 about possible signed overflow.
10158
6048fb2a
PE
10159 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10160 (GDK_KEY_g): Don't define if already defined.
10161 (xg_prepare_tooltip): Avoid pointer signedness problem.
10162 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10163
fa3c87e1
PE
10164 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10165 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10166
2172544b
PE
10167 * xfns.c (Fx_window_property): Simplify a bit,
10168 to make a bit faster and to avoid GCC 4.6.0 warning.
10169 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10170
9b821a21
PE
10171 * fns.c (internal_equal): Don't assume size_t fits in int.
10172
3c616cfa
PE
10173 * alloc.c (compact_small_strings): Tighten assertion a little.
10174
c2982e87
PE
10175 Replace pEd with more-general pI, and fix some printf arg casts.
10176 * lisp.h (pI): New macro, generalizing old pEd macro to other
10177 conversion specifiers. For example, use "...%"pI"d..." rather
10178 than "...%"pEd"...".
10179 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10180 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10181 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10182 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10183 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10184 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10185 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10186 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10187 64-bit hosts.
10188 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10189 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10190 * print.c (safe_debug_print, print_object): Likewise.
10191 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10192 to int.
6f04d126
PE
10193 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10194 avoiding the 0 flag, which is not portable.
c2982e87
PE
10195 * process.c (Fmake_network_process): Use pI to avoid cast.
10196 * region-cache.c (pp_cache): Likewise.
10197 * xdisp.c (decode_mode_spec): Likewise.
10198 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10199 behavior on 64-bit hosts with printf arg.
6f04d126 10200 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10201 (x_stop_queuing_selection_requests): Likewise.
10202 (x_get_window_property): Don't truncate byte count to an 'int'
10203 when tracing.
0b432f21 10204
5e073ec7
PE
10205 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10206 here, since it parses constructs like leading '-' and spaces,
10207 which are not wanted; and it overflows with large numbers.
10208 Instead, simply match F[0-9]+, which is what is wanted anyway.
10209
36372bf9
PE
10210 * alloc.c: Remove unportable assumptions about struct layout.
10211 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10212 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10213 (allocate_vectorlike, make_pure_vector): Use the new macros,
10214 plus offsetof, to remove unportable assumptions about struct layout.
10215 These assumptions hold on all porting targets that I know of, but
10216 they are not guaranteed, they're easy to remove, and removing them
10217 makes further changes easier.
10218
0b432f21
PE
10219 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10220 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10221 (string_overrun_cookie): Now const. Use initializers that
10222 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10223 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10224 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10225 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10226 multiple of sizeof (EMACS_INT); it need not be, if
10227 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10228 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10229
895009e1
JB
102302011-04-26 Juanma Barranquero <lekktu@gmail.com>
10231
10232 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10233
6a7a1b0b
TZ
102342011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10235
10236 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10237 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10238 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10239
841a1577 102402011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10241
10242 * lisp.h (Qdebug): List symbol.
895009e1 10243 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10244 * keyboard.c (debug-on-event): New variable.
10245 (handle_user_signal): Break into debugger when debug-on-event
10246 matches the current signal symbol.
10247
f2d3ba6f
DN
102482011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10249
10250 * alloc.c (check_sblock, check_string_bytes)
10251 (check_string_free_list): Convert to standard C.
10252
42ce4c63
TZ
102532011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10254
10255 * w32.c (emacs_gnutls_push): Fix typo.
10256
825cd63c
EZ
102572011-04-25 Eli Zaretskii <eliz@gnu.org>
10258
fb11d64d
EZ
10259 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10260 "cast to pointer from integer of different size".
10261
825cd63c
EZ
10262 Improve doprnt and its use in verror. (Bug#8545)
10263 * doprnt.c (doprnt): Document the set of format control sequences
10264 supported by the function. Use SAFE_ALLOCA instead of always
10265 using `alloca'.
10266
10267 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10268 is one byte too soon. Don't use xrealloc; instead xfree and
10269 xmalloc anew.
10270
e061a11b
TZ
102712011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10272
10273 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10274 callbacks stage.
10275
10276 * gnutls.c: Renamed global_initialized to
10277 gnutls_global_initialized. Added internals for the
10278 :verify-hostname-error, :verify-error, and :verify-flags
10279 parameters of `gnutls-boot' and documented those parameters in the
10280 docstring. Start callback support.
9173deec
JB
10281 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10282 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10283 on error. Return error code.
e061a11b
TZ
10284 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10285 (emacs_gnutls_read): Likewise.
10286 (Fgnutls_boot): Return handshake error code.
10287 (emacs_gnutls_handle_error): New function.
10288 (wsaerror_to_errno): Likewise.
10289
10290 * w32.h (emacs_gnutls_pull): Add prototype.
10291 (emacs_gnutls_push): Likewise.
10292
10293 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10294 (emacs_gnutls_push): Likewise.
10295
102962011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10297
10298 * process.c (wait_reading_process_output): Check if GnuTLS
10299 buffered some data internally if no FDs are set for TLS
10300 connections.
10301
10302 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10303 (LIBS): Link to USER_LIBS.
10304 ($(BLD)/gnutls.$(0)): New target.
10305
fa6996bc
EZ
103062011-04-24 Eli Zaretskii <eliz@gnu.org>
10307
eb35682e
EZ
10308 * xdisp.c (handle_single_display_spec): Rename the
10309 display_replaced_before_p argument into display_replaced_p, to
10310 make it consistent with the commentary. Fix typos in the
10311 commentary.
10312
e2ad650c
EZ
10313 * textprop.c (syms_of_textprop): Remove dead code.
10314 (copy_text_properties): Delete obsolete commentary about an
10315 interface that was deleted long ago. Fix typos in the description
10316 of arguments.
10317
1b2de274
EZ
10318 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10319 to changes in oldXMenu/XMenu.h from 2011-04-16.
10320 <menu_help_message, prev_menu_help_message>: Constify.
10321 (IT_menu_make_room): menu->help_text is now `const char **';
10322 adjust.
10323
10324 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10325 to changes in oldXMenu/XMenu.h from 2011-04-16.
10326 (struct XMenu): Declare `help_text' `const char **'.
10327
10328 * xfaces.c <Qunspecified>: Make extern again.
10329
10330 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10331 required by POSIX.
1b2de274 10332
762b15be
EZ
10333 * doc.c (get_doc_string): Improve the format passed to `error'.
10334
10335 * doprnt.c (doprnt): Improve commentary.
10336
10337 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10338
10339 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10340 them with etags.
10341
f1052e5d
EZ
10342 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10343 changes in globals.h immediately force recompilation.
762b15be
EZ
10344 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10345 $(CURDIR)/s/ms-w32.h.
10346 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10347
fa6996bc
EZ
10348 * character.c (Fchar_direction): Function deleted.
10349 (syms_of_character): Don't defsubr it.
10350 <char-direction-table>: Deleted.
10351
e6c3da20
EZ
103522011-04-23 Eli Zaretskii <eliz@gnu.org>
10353
10354 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10355 * doprnt.c: Include limits.h.
10356 (SIZE_MAX): New macro.
04f2d78b
CB
10357 (doprnt): Return a size_t value. 2nd arg is now size_t.
10358 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10359 Improve overflow protection. Support `l' modifier for integer
10360 conversions. Support %l conversion. Don't assume an EMACS_INT
10361 argument for integer conversions and for %c.
10362
10363 * lisp.h (doprnt): Restore prototype.
10364
10365 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10366 $(SRC)/character.h.
10367
10368 * Makefile.in (base_obj): Add back doprnt.o.
10369
10370 * deps.mk (doprnt.o): Add back prerequisites.
10371 (callint.o): Depend on character.h.
10372
10373 * eval.c (internal_lisp_condition_case): Include the handler
10374 representation in the error message.
10375 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10376 when breaking from the loop.
10377
10378 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10379
10380 * callint.c (Fcall_interactively): When displaying error message
10381 about invalid control letter, pass the character's codepoint, not
10382 a pointer to its multibyte form. Improve display of the character
10383 in octal and display also its hex code.
10384
10385 * character.c (char_string): Use %x to display the (unsigned)
10386 codepoint of an invalid character, to avoid displaying a bogus
10387 negative value.
10388
10389 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10390 `error', not SYMBOL_NAME itself.
10391
10392 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10393 character arguments to `error'.
10394
10395 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10396 to `error' in error message about FINAL_CHAR argument. Make sure
10397 FINAL_CHAR is a character, and use %c when it is passed as
10398 argument to `error'.
10399
4ffd0d6b 104002011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10401
10402 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10403
10404 * w32.c: Include <time.h>.
10405 (sys_localtime): New function.
10406
4ffd0d6b 104072011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10408
10409 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10410
4ffd0d6b 10411 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10412
4ffd0d6b 104132011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10414
4ffd0d6b
GM
10415 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10416 zombies (Bug#8467).
aac0c6e3 10417
04c56954
EZ
104182011-04-19 Eli Zaretskii <eliz@gnu.org>
10419
10420 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10421 gl_state.e_property when gl_state.object is Qt.
10422
10423 * insdel.c (make_gap_larger): Remove limitation of buffer size
10424 to <= INT_MAX.
10425
16a43933
CY
104262011-04-18 Chong Yidong <cyd@stupidchicken.com>
10427
10428 * xdisp.c (lookup_glyphless_char_display)
10429 (produce_glyphless_glyph): Handle cons cell entry in
10430 glyphless-char-display.
10431 (Vglyphless_char_display): Document it.
10432
10433 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10434 glyphless-char-display.
10435
4581706e
CY
104362011-04-17 Chong Yidong <cyd@stupidchicken.com>
10437
10438 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10439
10440 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10441
10442 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10443 definition for no-X builds.
10444
4887c6e2 104452011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10446
fd35b6f9
PE
10447 Static checks with GCC 4.6.0 and non-default toolkits.
10448
5c1ccb01
PE
10449 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10450
006c5daa
PE
10451 * process.c (keyboard_bit_set): Define only if SIGIO.
10452 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10453 (send_process): Repair possible setjmp clobbering.
10454
efc736d3
PE
10455 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10456
4e2fe2e6
PE
10457 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10458
f97334a2
PE
10459 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10460
4e75f29d
PE
10461 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10462 Define only if needed.
10463
90efadd1
PE
10464 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10465 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10466 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10467
3c647824
PE
10468 * dispextern.h (struct redisplay_interface): Rename param
10469 to avoid shadowing.
e264f262 10470 * termhooks.h (struct terminal): Likewise.
761383f4 10471 * xterm.c (xembed_send_message): Likewise.
3c647824 10472
b58c5c4a
PE
10473 * insdel.c (make_gap_smaller): Define only if
10474 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10475
cad59032
PE
10476 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10477 it.
10478
c339dc2e
PE
10479 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10480 so that we aren't warned about unused symbols.
10481
91a3e27b
PE
10482 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10483
399c71d3 10484 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10485
8ffc96f5
PE
10486 * xfns.c (x_real_positions): Mark locals as initialized.
10487
eef9bc79
PE
10488 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10489
098db9dd
PE
10490 * xterm.c: Fix problems found by static analysis with other toolkits.
10491 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10492 (x_dispatch_event): Declare static if USE_GTK, and
10493 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10494 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10495 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10496 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10497 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10498
eb18f6cc
PE
10499 * xmenu.c (menu_help_callback): Pointer type fixes.
10500 Use const pointers when pointing at readonly data. Avoid pointer
10501 signedness clashes.
10502 (FALSE): Remove unused macro.
10503 (update_frame_menubar): Remove unused decl.
10504
1fe72bf8
PE
10505 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10506
60d9e1db
PE
10507 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10508 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10509 (single_menu_item): Rename local to avoid shadowing.
10510
39261c26
PE
10511 * keyboard.c (make_lispy_event): Remove unused local var.
10512
018c5e19
PE
10513 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10514 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10515
63d2b86e
PE
10516 * bitmaps: Change bitmaps from unsigned char back to the X11
10517 compatible char. Avoid the old compiler warnings about
10518 out-of-range initializers by using, for example, '\xab' rather
10519 than 0xab.
10520
aefd87e1
PE
10521 * xgselect.c (xgselect_initialize): Check vs interface
10522 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10523
bf501fb9
PE
10524 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10525
e9829fdf
PE
10526 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10527 to read-only memory.
10528
1086c095
PE
10529 * fns.c (vector): Remove; this old hack is no longer needed.
10530
2baccd04 10531 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10532 Remove unused var.
dde42981 10533 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10534
72391843 10535 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10536
436c16df 10537 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10538 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10539 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10540
92bb796d 10541 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10542 (x_term_init): Remove local to avoid shadowing.
92bb796d 10543
764430a3 10544 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10545
10546 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10547 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10548
d1dfb56c
EZ
105492011-04-16 Eli Zaretskii <eliz@gnu.org>
10550
c4354cb4
EZ
10551 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10552
d1dfb56c
EZ
10553 Fix regex.c, syntax.c and friends for buffers > 2GB.
10554 * syntax.h (struct gl_state_s): Declare character position members
10555 EMACS_INT.
10556
10557 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10558
04f2d78b
CB
10559 * textprop.c (verify_interval_modification, interval_of):
10560 Declare arguments EMACS_INT.
d1dfb56c
EZ
10561
10562 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10563 EMACS_INT.
10564
10565 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10566
10567 * indent.c (Fvertical_motion): Local variable it_start is now
10568 EMACS_INT.
10569
10570 * regex.c (re_match, re_match_2, re_match_2_internal)
10571 (bcmp_translate, regcomp, regexec, print_double_string)
10572 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10573 (re_compile_pattern, re_exec): Declare arguments and local
10574 variables `size_t' and `ssize_t' and return values `regoff_t', as
10575 appropriate.
10576 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10577 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10578 <compile_stack_type>: `size' and `avail' are now `size_t'.
10579
10580 * regex.h <regoff_t>: Use ssize_t, not int.
10581 (re_search, re_search_2, re_match, re_match_2): Arguments that
10582 specify buffer/string position and length are now ssize_t and
10583 size_t. Return type is regoff_t.
10584
613052cd
BK
105852011-04-16 Ben Key <bkey76@gmail.com>
10586
10587 * nsfont.m: Fixed bugs in ns_get_family and
10588 ns_descriptor_to_entity that were caused by using free to
10589 deallocate memory blocks that were allocated by xmalloc (via
10590 xstrdup). This caused Emacs to crash when compiled with
10591 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10592 --enable-checking=xmallocoverrun). xfree is now used to
10593 deallocate these memory blocks.
10594
4170f62f 105952011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10596
71b41406
PE
10597 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10598
9587a89d
PE
10599 emacs_write: Accept and return EMACS_INT for sizes.
10600 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10601 et seq.
10602 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10603 Accept and return EMACS_INT.
10604 (emacs_gnutls_write): Return the number of bytes written on
10605 partial writes.
10606 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10607 (emacs_read, emacs_write): Remove check for negative size, as the
10608 Emacs source code has been audited now.
9587a89d
PE
10609 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10610 (emacs_read, emacs_write): Use it.
273a5f82
PE
10611 * process.c (send_process): Adjust to the new signatures of
10612 emacs_write and emacs_gnutls_write. Do not attempt to store
10613 a byte offset into an 'int'; it might overflow.
9587a89d 10614 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10615
3e047f51
PE
10616 * sound.c: Don't assume sizes fit in 'int'.
10617 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10618 Return EMACS_INT, not int.
3e047f51 10619 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10620 Accept EMACS_INT, not int.
10621 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10622 record read return values.
10623
cc39a9db
BK
106242011-04-15 Ben Key <bkey76@gmail.com>
10625
c9d0ec6d
JB
10626 * keyboard.c (Qundefined): Don't declare static since it is used
10627 in nsfns.m.
10628 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10629 static since they are used in nsfont.m.
cc39a9db 10630
6c60eb9f
SM
106312011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10632
10633 * process.c (Qprocessp): Don't declare static.
10634 * lisp.h (Qprocessp): Declare again.
10635
7990b61a
JB
106362011-04-15 Juanma Barranquero <lekktu@gmail.com>
10637
10638 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10639
5d4cb038
PE
106402011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10641
8bd7b830 10642 Improve C-level modularity by making more things 'static'.
cd64ea1d 10643
e3b27b31
PE
10644 Don't publish debugger-only interfaces to other modules.
10645 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10646 (verify_bytepos, count_markers): Move decls to the only modules
10647 that need them.
10648 * region-cache.h (pp_cache): Likewise.
10649 * window.h (check_all_windows): Likewise.
10650 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10651
5d4cb038
PE
10652 * sysdep.c (croak): Now static, if
10653 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10654 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10655
10656 * alloc.c (refill_memory_reserve): Now static if
10657 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10658 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10659
e87b6180
PE
10660 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10661 Define only if USE_LUCID.
10662
ac64929e
PE
10663 * xrdb.c (x_customization_string, x_rm_string): Now static.
10664
6f37259d
PE
10665 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10666 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10667
1683e3ab
PE
10668 * xdisp.c (draw_row_with_mouse_face): Now static.
10669 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10670
de9c2632
PE
10671 * window.h (check_all_windows): Mark externally visible.
10672
2b96acb7
PE
10673 * window.c (window_deletion_count): Now static.
10674
10675 * undo.c: Make symbols static if they're not exported.
10676 (last_undo_buffer, last_boundary_position, pending_boundary):
10677 Now static.
10678
50436f33
PE
10679 * textprop.c (interval_insert_behind_hooks): Now static.
10680 (interval_insert_in_front_hooks): Likewise.
10681
64520e5c
PE
10682 * term.c: Make symbols static if they're not exported.
10683 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10684 (max_frame_lines, tty_set_terminal_modes):
10685 (tty_reset_terminal_modes, tty_turn_off_highlight):
10686 (get_tty_terminal): Now static.
10687 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10688 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10689 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10690 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10691 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10692
1fa53021
PE
10693 * sysdep.c: Make symbols static if they're not exported.
10694 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10695 Now static.
10696 (sigprocmask_set, full_mask): Remove; unused.
10697 (wait_debugging): Mark as visible.
10698 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10699 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10700
d4b43b22
PE
10701 * syntax.c (syntax_temp): Define only if !__GNUC__.
10702
b7c513d0
PE
10703 * sound.c (current_sound_device, current_sound): Now static.
10704
989b29ad
PE
10705 * search.c (searchbufs, searchbuf_head): Now static.
10706
13a55a78
PE
10707 * scroll.c (scroll_cost): Remove; unused.
10708 * dispextern.h (scroll_cost): Remove decl.
10709
de68a1fc
PE
10710 * region-cache.h (pp_cache): Mark as externally visible.
10711
40ccffa6
PE
10712 * process.c: Make symbols static if they're not exported.
10713 (process_tick, update_tick, create_process, chan_process):
10714 (Vprocess_alist, proc_buffered_char, datagram_access):
10715 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10716 (deactivate_process): Mark defn as static, as well as decl.
10717 * lisp.h (create_process): Remove decl.
10718 * process.h (chan_process, Vprocess_alist): Remove decls.
10719
ad64fc97
PE
10720 * print.c: Make symbols static if they're not exported.
10721 (print_depth, new_backquote_output, being_printed, print_buffer):
10722 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10723 (print_interval, print_number_index, initial_stderr_stream):
10724 Now static.
10725 * lisp.h (Fprinc): Remove decl.
10726 (debug_output_compilation_hack): Mark as externally visible.
10727
adddb265
PE
10728 * sysdep.c (croak): Move decl from here to syssignal.h.
10729 * syssignal.h (croak): Put it here, so the API can be checked when
10730 'croak' is called from dissociate_if_controlling_tty.
10731
1717ede2
PE
10732 * minibuf.c: Make symbols static if they're not exported.
10733 (minibuf_save_list, choose_minibuf_frame): Now static.
10734 * lisp.h (choose_minibuf_frame): Remove decl.
10735
fa5fb2bc
PE
10736 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10737
1e3890d1
PE
10738 * lread.c: Make symbols static if they're not exported.
10739 (read_objects, initial_obarray, oblookup_last_bucket_number):
10740 Now static.
10741 (make_symbol): Remove; unused.
10742 * lisp.h (initial_obarray, make_symbol): Remove decls.
10743
8a1414fa
PE
10744 * keyboard.c: Make symbols static if they're not exported.
10745 (single_kboard, recent_keys_index, total_keys, recent_keys):
10746 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10747 (this_single_command_key_start, echoing, last_auto_save):
10748 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10749 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10750 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10751 (Vlispy_mouse_stem, double_click_count):
10752 Now static.
10753 (force_auto_save_soon): Define only if SIGDANGER.
10754 (ignore_mouse_drag_p): Now static if
10755 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10756 (print_help): Remove; unused.
10757 (stop_character, last_timer_event): Mark as externally visible.
10758 * keyboard.h (ignore_mouse_drag_p): Declare only if
10759 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10760 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10761 * lisp.h (echoing): Remove decl.
10762 (force_auto_save_soon): Declare only if SIGDANGER.
10763 * xdisp.c (redisplay_window): Simplify code, to make it more
10764 obvious that ignore_mouse_drag_p is not accessed if !defined
10765 USE_GTK && !defined HAVE_NS.
10766
93ea6e8f
PE
10767 * intervals.c: Make symbols static if they're not exported.
10768 (merge_properties_sticky, merge_interval_right, delete_interval):
10769 Now static.
10770 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10771
77382fcc
PE
10772 * insdel.c: Make symbols static if they're not exported.
10773 However, leave prepare_to_modify_buffer alone. It's never
10774 called from outside this function, but that appears to be a bug.
10775 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10776 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10777 (adjust_after_replace_noundo): Remove; unused.
10778 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10779 (signal_before_change): Remove decls.
77382fcc 10780
9306c32e
PE
10781 * indent.c (val_compute_motion, val_vmotion): Now static.
10782
cd44d2eb
PE
10783 * image.c: Make symbols static if they're not exported.
10784 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10785 if USE_GTK.
10786 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10787 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10788
ad9a7a06
PE
10789 * fringe.c (standard_bitmaps): Now static.
10790 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10791
81626931
PE
10792 * frame.c: Make symbols static if they're not exported.
10793 (x_report_frame_params, make_terminal_frame): Now static.
10794 (get_frame_param): Now static, unless HAVE_NS.
10795 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10796 (x_get_resource_string): Remove; not used.
10797 * frame.h (make_terminal_frame, x_report_frame_params):
10798 (x_get_resource_string); Remove decls.
10799 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10800 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10801
239f9db9
PE
10802 * font.c, fontset.c: Make symbols static if they're not exported.
10803 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10804 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10805 * font.c (font_close_object): Now static.
10806 * font.h (font_close_object): Remove.
10807 * fontset.c (FONTSET_OBJLIST): Remove.
10808 (free_realized_fontset) #if-0 the body, which does nothing.
10809 (face_suitable_for_char_p): #if-0, as it's never called.
10810 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10811 * xfaces.c (face_at_string_position):
10812 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10813 since 0 is always ASCII.
10814
dfcf3579
PE
10815 * fns.c (weak_hash_tables): Now static.
10816
5045092b
PE
10817 * fileio.c: Make symbols static if they're not exported.
10818 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10819 (Vwrite_region_annotation_buffers): Now static.
10820
57a96f5c
PE
10821 * eval.c: Make symbols static if they're not exported.
10822 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10823 * lisp.h (backtrace_list): Remove decl.
10824
35f08c38
PE
10825 * emacs.c: Make symbols static if they're not exported.
10826 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10827 (fatal_error_code, fatal_error_signal_hook, standard_args):
10828 Now static.
10829 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10830 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10831 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10832 * lisp.h (fatal_error_signal_hook): Remove decl.
10833 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10834
f44bd759
PE
10835 * editfns.c: Move a (normally-unused) function to its only use.
10836 * editfns.c, lisp.h (get_operating_system_release): Remove.
10837 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10838 worth the hassle of breaking this out.
10839
b532497d
PE
10840 * xterm.c: Make symbols static if they're not exported.
10841 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10842 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10843 (x_destroy_window, x_delete_display):
10844 Now static.
10845 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10846 (x_mouse_leave): Remove; unused.
10847 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10848 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10849 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10850 Remove decls.
10851 (x_mouse_leave): Declare only if WINDOWSNT.
10852 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10853 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10854 USE_X_TOOLKIT.
10855
1675728f
PE
10856 * ftxfont.c: Make symbols static if they're not exported.
10857 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10858 HAVE_FREETYPE.
10859 * font.h (ftxfont_driver): Likewise.
10860
e4cebfca
PE
10861 * xfns.c: Make symbols static if they're not exported.
10862 (x_last_font_name, x_display_info_for_name):
10863 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10864 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10865 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10866 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10867 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10868 (last_show_tip_args): Now static.
10869 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10870 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10871 (x_screen_planes): Remove; unused.
10872 * dispextern.h (x_screen_planes): Remove decl.
10873
5bf46f05
PE
10874 * dispnew.c: Make symbols static if they're not exported.
10875 * dispextern.h (redraw_garbaged_frames, scrolling):
10876 (increment_row_positions): Remove.
10877 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10878 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10879 Now static.
10880 (redraw_garbaged_frames): Remove; unused.
10881
435f4c28
PE
10882 * xfaces.c: Make symbols static if they're not exported.
10883 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10884 Remove decls.
10885 * xterm.h (defined_color): Remove decls.
10886 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10887 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10888 (menu_face_changed_default, defined_color, free_realized_face):
10889 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10890 (ascii_face_of_lisp_face): Remove; unused.
10891
8524aef3
PE
10892 * xdisp.c: Make symbols static if they're not exported.
10893 * dispextern.h (scratch_glyph_row, window_box_edges):
10894 (glyph_to_pixel_coords, set_cursor_from_row):
10895 (get_next_display_element, set_iterator_to_next):
10896 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10897 (show_mouse_face): Remove decls
10898 * frame.h (message_buf_print): Likewise.
10899 * lisp.h (pop_message, set_message, check_point_in_composition):
10900 Likewise.
10901 * xterm.h (set_vertical_scroll_bar): Likewise.
10902 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10903 (message_buf_print, scratch_glyph_row, displayed_buffer):
10904 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10905 (get_next_display_element, show_mouse_face, window_box_edges):
10906 (frame_to_window_pixel_xy, check_point_in_composition):
10907 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10908 (glyph_to_pixel_coords): Remove; unused.
10909
16390cd2
PE
10910 * dired.c (file_name_completion): Now static.
10911
10912 * dbusbind.c (xd_in_read_queued_messages): Now static.
10913
a25f4dfa
PE
10914 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10915 * data.c (circular_list_error): Remove.
10916
14a9c8df
PE
10917 * commands.h (last_point_position, last_point_position_buffer):
10918 (last_point_position_window): Remove decls.
10919 * keyboard.c: Make these variables static.
10920
04f2d78b
CB
10921 * coding.h (coding, code_convert_region, encode_coding_gap):
10922 Remove decls.
74ab6df5
PE
10923 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10924 (iso_code_class, detect_coding, code_convert_region): Now static.
10925 (encode_coding_gap): Remove; unused.
10926
38dfbee1
PE
10927 * chartab.c (chartab_chars, chartab_bits): Now static.
10928
a2cb4e63
PE
10929 * charset.h (charset_iso_8859_1): Remove decl.
10930 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10931 Now static.
10932
127198fd
PE
10933 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10934 * ccl.c (Vccl_program_table): Now static.
10935 (check_ccl_update): Remove; unused.
10936
d85b608f
PE
10937 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10938 * category.h: ... from here.
10939 * category.c (check_category_table, set_category_set): Now static.
10940
31cd66f3
PE
10941 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10942 * lisp.h: Remove these decls.
10943
c358e587
PE
10944 * buffer.c (buffer_count): Remove unused var.
10945
e78aecca
PE
10946 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10947 so that it's not optimized away.
10948 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10949 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10950 exported only to the debugger.
10951
e192d7d3 10952 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10953 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10954
92470028
PE
10955 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10956 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10957 was inaccessible from Lisp.
10958 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10959 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10960
244ed907
PE
10961 alloc.c: Import and export fewer symbols, and remove unused items.
10962 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10963 is defined.
10964 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10965 it's not optimized away by whole-program optimization.
10966 (message_enable_multibyte, free_misc): Remove.
10967 (catchlist, handlerlist, mark_backtrace):
10968 Declare only if BYTE_MARK_STACK.
10969 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10970 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10971 (message_enable_multibyte): Remove decl.
10972 (free_misc, interval_free_list, float_block, float_block_index):
10973 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10974 (cons_free_list, last_marked_index):
10975 Now static.
10976 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10977 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10978 (mark_backtrace): Define only if BYTE_MARK_STACK.
10979 * xdisp.c (message_enable_multibyte): Now static.
10980
61c2b50e 10981 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10982 This makes it easier for human readers (and static analyzers)
10983 to see whether these variables are used from other modules.
10984 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10985 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10986 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10987 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10988 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10989 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10990 * xmenu.c, xselect.c:
10991 Declare Q* vars static if they are not used in other modules.
10992 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10993 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10994 Remove decls of unexported vars.
10995 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10996
95c82688
PE
10997 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10998
16a97296
PE
10999 Make Emacs functions such as Fatom 'static' by default.
11000 This makes it easier for human readers (and static analyzers)
11001 to see whether these functions can be called from other modules.
11002 DEFUN now defines a static function. To make the function external
11003 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11004 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11005 (Finit_image_library):
16a97296
PE
11006 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11007 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11008 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11009 Remove decls, since these functions are now static.
11010 (Funintern, Fget_internal_run_time): New decls, since these functions
11011 were already external.
95c82688 11012
16a97296
PE
11013 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11014 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11015 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11016 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11017 * keyboard.c, keymap.c, lread.c:
11018 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11019 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11020 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11021 Mark functions with DEFUE instead of DEFUN,
11022 if they are used in other modules.
11023 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11024 decls for now-static functions.
11025 * buffer.h (Fdelete_overlay): Remove decl.
11026 * callproc.c (Fgetenv_internal): Mark as internal.
11027 * composite.c (Fremove_list_of_text_properties): Remove decl.
11028 (Fcomposition_get_gstring): New forward static decl.
11029 * composite.h (Fcomposite_get_gstring): Remove decl.
11030 * dired.c (Ffile_attributes): New forward static decl.
11031 * doc.c (Fdocumntation_property): New forward static decl.
11032 * eval.c (Ffetch_bytecode): New forward static decl.
11033 (Funintern): Remove extern decl; now in .h file where it belongs.
11034 * fileio.c (Fmake_symbolic_link): New forward static decl.
11035 * image.c (Finit_image_library): New forward static decl.
11036 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11037 * intervals.h (Fprevious_property_change):
11038 (Fremove_list_of_text_properties): Remove decls.
11039 * keyboard.c (Fthis_command_keys): Remove decl.
11040 (Fcommand_execute): New forward static decl.
11041 * keymap.c (Flookup_key): New forward static decl.
11042 (Fcopy_keymap): Now static.
11043 * keymap.h (Flookup_key): Remove decl.
11044 * process.c (Fget_process): New forward static decl.
11045 (Fprocess_datagram_address): Mark as internal.
11046 * syntax.c (Fsyntax_table_p): New forward static decl.
11047 (skip_chars): Remove duplicate decl.
11048 * textprop.c (Fprevious_property_change): New forward static decl.
11049 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11050 Now internal.
11051 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11052 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11053
785bbd42
PE
11054 * editfns.c (Fformat): Remove unreachable code.
11055
8b913b57
AS
110562011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11057
11058 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11059 change. (Bug#8496)
11060
a6744a35
EZ
110612011-04-13 Eli Zaretskii <eliz@gnu.org>
11062
11063 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11064 when at ZV. (Bug#8487)
11065
e7974947
AS
110662011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11067
baad03f0
AS
11068 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11069 (Bug#8437)
11070 * keyboard.c (parse_tool_bar_item): Likewise.
11071 * sound.c (sound_cleanup, alsa_close): Likewise.
11072 * termcap.c (tgetent): Likewise.
11073 * xfns.c (x_default_font_parameter): Likewise.
11074 * xsettings.c (read_and_apply_settings): Likewise.
11075
e7974947
AS
11076 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11077 (overrun_check_free): Protoize.
11078
28272684
PE
110792011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11080
11081 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11082 since callers should never pass a negative size.
11083 Change the signature to match that of plain 'read' and 'write'; see
11084 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11085 * lisp.h: Update prototypes of emacs_write and emacs_read.
11086
11997c76
EZ
110872011-04-11 Eli Zaretskii <eliz@gnu.org>
11088
11089 * xdisp.c (redisplay_window): Don't try to determine the character
11090 position of the scroll margin if the window start point w->startp
e896f03c 11091 is outside the buffer's accessible region. (Bug#8468)
11997c76 11092
8a2cbd72
EZ
110932011-04-10 Eli Zaretskii <eliz@gnu.org>
11094
11095 Fix write-region and its subroutines for buffers > 2GB.
11096 * fileio.c (a_write, e_write): Modify declaration of arguments and
11097 local variables to support buffers larger than 2GB.
11098 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11099
11100 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11101 argument, local variables, and return value.
11102
11103 * lisp.h: Update prototypes of emacs_write and emacs_read.
11104
11105 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11106
4073e537 111072011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11108
1ebfdcb6
PE
11109 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11110
b2ded58d
PE
11111 Fix more problems found by GCC 4.6.0's static checks.
11112
7d66342c
PE
11113 * xdisp.c (vmessage): Use a better test for character truncation.
11114
bbf47d44
PE
11115 * charset.c (load_charset_map): <, not <=, for optimization,
11116 and to avoid potential problems with integer overflow.
9248994d 11117 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11118 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11119 * editfns.c (Fformat): Likewise.
1e69125e 11120 * syntax.c (skip_chars): Likewise.
3befa583 11121
e3019616
PE
11122 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11123 This also lets GCC 4.6.0 generate slightly better loop code.
11124
becfa255
PE
11125 * callint.c (Fcall_interactively): <, not <=, for optimization.
11126 (Fcall_interactively): Count the number of arguments produced,
11127 not the number of arguments given. This is simpler and lets GCC
11128 4.6.0 generate slightly better code.
11129
dae0cd48
PE
11130 * ftfont.c: Distingish more carefully between FcChar8 and char.
11131 The previous code passed unsigned char * to a functions like
11132 strlen and xstrcasecmp that expect char *, which does not
11133 conform to the C standard.
11134 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11135 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11136 char * when the C standard requires it.
11137
76032d70
PE
11138 * keyboard.c (read_char): Remove unused var.
11139
eb3f1cc8
PE
11140 * eval.c: Port to Windows vsnprintf (Bug#8435).
11141 Include <limits.h>.
11142 (SIZE_MAX): Define if the headers do not.
11143 (verror): Do not give up if vsnprintf returns a negative count.
11144 Instead, grow the buffer. This ports to Windows vsnprintf, which
11145 does not conform to C99. Problem reported by Eli Zaretskii.
11146 Also, simplify the allocation scheme, by avoiding the need for
11147 calling realloc, and removing the ALLOCATED variable.
11148
70476b54
PE
11149 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11150
12020a9e
PE
11151 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11152 But keep the doprint source code for now, as we might revamp it
11153 and use it again (Bug#8435).
ea6c7ae6
PE
11154 * lisp.h (doprnt): Remove.
11155 * Makefile.in (base_obj): Remove doprnt.o.
11156 * deps.mk (doprnt.o): Remove.
11157
5fdb398c
PE
11158 error: Print 32- and 64-bit integers portably (Bug#8435).
11159 Without this change, on typical 64-bit hosts error ("...%d...", N)
11160 was used to print both 32- and 64-bit integers N, which relied on
11161 undefined behavior.
61bdb816 11162 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11163 * lisp.h (error, verror): Mark as printf-like functions.
11164 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11165 Report overflow in size calculations when allocating printf buffer.
11166 Do not truncate output string at its first null byte.
11167 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11168 Truncate the output at a character boundary, since vsnprintf does not
11169 do that.
11170 * charset.c (check_iso_charset_parameter): Convert internal
11171 character to string before calling 'error', since %c now has the
11172 printf meaning.
11173 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11174 overflow when computing char to be passed to 'error'. Do not
11175 pass Lisp_Object to 'error'; pass the integer instead.
11176 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11177 formatted with plain %d.
11178
b189fa66
PE
11179 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11180
bff87ef0
PE
11181 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11182
7e2cac20
PE
11183 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11184
ce4d90b5
PE
11185 * xterm.c (x_catch_errors): Remove duplicate declaration.
11186
266c9547
PE
11187 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11188
79c49ad2
PE
11189 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11190
368f4090
JM
111912011-04-10 Jim Meyering <meyering@redhat.com>
11192
11193 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11194 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11195 return ssize_t not "int", and use size_t as the buffer length.
11196 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11197 * gnutls.h: Update declarations.
11198 * process.c (read_process_output): Use ssize_t, to match.
11199 (send_process): Likewise.
11200
a32d4040
CY
112012011-04-09 Chong Yidong <cyd@stupidchicken.com>
11202
11203 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11204
8546720e 112052011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11206
04f2d78b
CB
11207 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11208 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11209
8546720e
GM
11210 * xterm.c (handle_one_xevent):
11211 * xmenu.c (create_and_show_popup_menu):
11212 * xselect.c (x_decline_selection_request)
11213 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11214
0a2f5c1a 112152011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11216
11217 Fix some uses of `int' instead of EMACS_INT.
11218 * search.c (string_match_1, fast_string_match)
11219 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11220 (scan_buffer, find_next_newline_no_quit)
11221 (find_before_next_newline, search_command, Freplace_match)
11222 (Fmatch_data): Make some `int' variables be EMACS_INT.
11223
11224 * xdisp.c (display_count_lines): 3rd argument and return value now
11225 EMACS_INT. All callers changed.
11226 (pint2hrstr): Last argument is now EMACS_INT.
11227
11228 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11229 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11230 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11231 (decode_coding_utf_16, decode_coding_emacs_mule)
11232 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11233 (decode_coding_ccl, decode_coding_charset)
11234 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11235 (decode_coding_iso_2022, decode_coding_emacs_mule)
11236 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11237 <char_offset, last_offset>: Declare EMACS_INT.
11238 (encode_coding_utf_8, encode_coding_utf_16)
11239 (encode_coding_emacs_mule, encode_invocation_designation)
11240 (encode_designation_at_bol, encode_coding_iso_2022)
11241 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11242 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11243 Declare EMACS_INT.
11244 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11245 (encode_invocation_designation): Last argument P_NCHARS is now
11246 EMACS_INT.
11247 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11248 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11249
11250 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11251 All users changed.
11252
11253 * ccl.c (Fccl_execute_on_string): Declare some variables
11254 EMACS_INT.
11255
8546720e 112562011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11257
11258 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11259
4e19a977
CS
112602011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11261
11262 * process.c (Fformat_network_address): Doc fix.
11263
87302331
R
112642011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11265
ee7683eb 11266 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11267
cbb59342
CY
112682011-04-08 Chong Yidong <cyd@stupidchicken.com>
11269
11270 * keyboard.c (read_char): Call Lisp function help-form-show,
11271 instead of using internal_with_output_to_temp_buffer.
11272 (Qhelp_form_show): New var.
e0d38eeb 11273 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11274
11275 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11276
11277 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11278
e67a13ab
CY
112792011-04-06 Chong Yidong <cyd@stupidchicken.com>
11280
04f2d78b
CB
11281 * process.c (Flist_processes): Remove to Lisp.
11282 (list_processes_1): Delete.
e67a13ab 11283
973f782d
EZ
112842011-04-06 Eli Zaretskii <eliz@gnu.org>
11285
7c106b1e
EZ
11286 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11287
973f782d
EZ
11288 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11289
41cf7d1a 112902011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11291
ca23cc88
PE
11292 Fix more problems found by GCC 4.6.0's static checks.
11293
f390e2d5
PE
11294 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11295
42eea0d0
PE
11296 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11297
b69769da 11298 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11299
f9541e84
PE
11300 * xdisp.c (vmessage): Mark as a printf-like function.
11301
13841b55
PE
11302 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11303
c136c10f
PE
11304 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11305
5e2d4a30
PE
11306 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11307 printf-like functions.
11308 (tiff_load): Add casts to remove these marks before passing them
11309 to system-supplied API.
11310
583f48b9
PE
11311 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11312
b25d760e
PE
11313 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11314 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11315 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11316 directly, rather than having caller test rule sign. This avoids
11317 some unnecessary tests.
11318 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11319 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11320 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11321
bc7b6697 11322 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11323 (xfont_open): Avoid unnecessary tests.
bc7b6697 11324
27ccc379
PE
11325 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11326
dcd5c89a
PE
11327 * composite.h, composite.c (composition_gstring_put_cache):
11328 Use EMACS_INT, not int, for length.
11329
b13a45c6
PE
11330 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11331 breaking out part of COMPOSITION_DECODE_RULE.
11332 (COMPOSITION_DECODE_RULE): Use it.
11333 * composite.c (get_composition_id): Remove unused local vars,
11334 by using the new macro.
11335
1e792e4d
PE
11336 * textprop.c (set_text_properties_1): Change while to do-while,
11337 since the condition is always true at first.
11338
dc6c6455 11339 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11340 (interval_deletion_adjustment): Return unsigned value.
11341 All uses changed.
dc6c6455 11342
aba7731a
PE
11343 * process.c (list_processes_1, create_pty, read_process_output):
11344 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11345 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11346 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11347 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11348 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11349
fdfc4bf3
PE
11350 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11351
fca8fe46 11352 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11353 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11354
06a0259a 11355 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11356 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11357 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11358
e7b9e80f
PE
11359 * print.c (print_error_message): Avoid int overflow.
11360
56201685
PE
11361 * font.c (font_list_entities): Redo for clarity,
11362 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11363
78834453 11364 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11365 (font_score): Avoid potential overflow in diff calculation.
78834453 11366
0bc0b309 11367 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11368 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11369
e610eaca
PE
11370 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11371
b895abce
PE
11372 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11373 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11374 can always succeed if overflow has undefined behavior.
11375
1f1d9321 11376 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11377 (wordify): Omit three unnecessary tests.
1f1d9321 11378
c59478bc
PE
11379 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11380 All callers changed. This avoids the need for an unused var.
11381
79b73827
PE
11382 * casefiddle.c (casify_region): Remove var that is set but not used.
11383
a4db5dfe
PE
11384 * dired.c (file_name_completion): Remove var that is set but not used.
11385
43aae36e
PE
11386 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11387
2a47c44d 11388 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11389 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11390
a37c69bf
PE
11391 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11392 Check for integer overflow on size calculations.
11393
328ab8e7
PE
11394 * buffer.c (Fprevious_overlay_change): Remove var that is set
11395 but not used.
11396
e5a2a5cb
PE
11397 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11398 Remove vars that are set but not used.
8d84a6eb 11399 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11400 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11401
a60e5f68
PE
11402 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11403
f661cb61 11404 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11405 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11406
f0397f5a
PE
11407 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11408 that are set but not used.
11409
8664db06 11410 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11411 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11412
6abdaa4a
PE
11413 * xselect.c (x_get_local_selection, x_handle_property_notify):
11414 Remove vars that are set but not used.
11415
0ce7538d 11416 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11417 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11418
9ae848fc
PE
11419 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11420 Remove var that is set but not used.
0b918413
PE
11421 (scroll_bar_windows_size): Now size_t, not int.
11422 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11423 Check for overflow.
9ae848fc 11424
a5a62657
PE
11425 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11426 (map_tty_color) [!defined MSDOS]: Likewise.
11427
5c5cdd39
PE
11428 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11429
66ebf983
PE
11430 * coding.c: Remove vars that are set but not used.
11431 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11432 All callers changed.
11433 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11434 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11435 (decode_coding_charset): Remove vars that are set but not used.
11436
1be4d761
PE
11437 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11438 that is set but not used.
11439
47553fa8
PE
11440 * print.c (print_object): Remove var that is set but not used.
11441
1f7196bf 11442 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11443 The gnulib version avoids calling malloc in the usual case,
11444 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11445 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11446 * filelock.c (current_lock_owner): Likewise.
11447 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11448 * sysdep.c: Include allocator.h, careadlinkat.h.
11449 (emacs_no_realloc_allocator): New static constant.
11450 (emacs_readlink): New function.
fdb61804
PE
11451 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11452 ../lib/careadlinkat.h.
d1fdcab7 11453
f84c17c7
SM
114542011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11455
11456 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11457 first non-nil return value).
11458
ef3862ad
JD
114592011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11460
11461 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11462 if not defined (Bug#8403).
11463
376a7006
JB
114642011-04-02 Juanma Barranquero <lekktu@gmail.com>
11465
11466 * xdisp.c (display_count_lines): Remove parameter `start',
11467 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11468 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11469 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11470 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11471 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11472 and thereabouts. All callers changed.
11473 (get_per_char_metric): Remove parameter `f', unused since
11474 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11475
6ca3801d
JM
114762011-04-02 Jim Meyering <meyering@redhat.com>
11477
11478 do not dereference NULL upon failed strdup
11479 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11480 (ns_get_family): Likewise.
11481
d8e2b5ba
JB
114822011-04-02 Juanma Barranquero <lekktu@gmail.com>
11483
11484 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11485
8c74fcbd
JD
114862011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11487
11488 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11489 later (Bug#8403).
11490
7200d79c
SM
114912011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11492
03408648 11493 Add lexical binding.
7200d79c 11494
03408648
SM
11495 * window.c (Ftemp_output_buffer_show): New fun.
11496 (Fsave_window_excursion):
11497 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11498
11499 * lread.c (lisp_file_lexically_bound_p): New function.
11500 (Fload): Bind Qlexical_binding.
11501 (readevalloop): Remove `evalfun' arg.
11502 Bind Qinternal_interpreter_environment.
11503 (Feval_buffer): Bind Qlexical_binding.
11504 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11505 Mark as dynamic.
11506 (syms_of_lread): Declare `lexical-binding'.
11507
11508 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11509
11510 * keyboard.c (eval_dyn): New fun.
11511 (menu_item_eval_property): Use it.
ca105506
SM
11512
11513 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11514
03408648
SM
11515 * fns.c (concat, mapcar1): Accept byte-code-functions.
11516
11517 * eval.c (Fsetq): Handle lexical vars.
11518 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11519 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11520 (FletX, Flet): Obey lexical binding.
11521 (Fcommandp): Handle closures.
11522 (Feval): New `lexical' arg.
11523 (eval_sub): New function extracted from Feval. Use it almost
11524 everywhere where Feval was used. Look up vars in lexical env.
11525 Handle closures.
11526 (Ffunctionp): Move from subr.el.
11527 (Ffuncall): Handle closures.
11528 (apply_lambda): Remove `eval_flags'.
11529 (funcall_lambda): Handle closures and new byte-code-functions.
11530 (Fspecial_variable_p): New function.
11531 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11532 but without exporting it to Lisp.
23aba0ea 11533
23aba0ea 11534 * doc.c (Fdocumentation, store_function_docstring):
03408648 11535 * data.c (Finteractive_form): Handle closures.
23aba0ea 11536
03408648
SM
11537 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11538 interactive spec.
ba83908c 11539
04f2d78b
CB
11540 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11541 New byte-codes.
03408648
SM
11542 (exec_byte_code): New function extracted from Fbyte_code to handle new
11543 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11544
03408648 11545 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11546
03408648 11547 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11548
e2abce01
JB
115492011-03-31 Juanma Barranquero <lekktu@gmail.com>
11550
11551 * xdisp.c (redisplay_internal): Fix prototype.
11552
63696a73 115532011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11554
63696a73 11555 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11556 (try_scrolling): Use it when setting scroll_limit.
11557 Limit scrolling to 100 screen lines.
63696a73
EZ
11558 (redisplay_window): Even when falling back on "recentering",
11559 position point in the window according to scroll-conservatively,
11560 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11561
11562 (try_scrolling): When point is above the window, allow searching
11563 as far as scroll_max, or one screenful, to compute vertical
11564 distance from PT to the scroll margin position. This prevents
11565 try_scrolling from unnecessarily failing when
11566 scroll-conservatively is set to a value slightly larger than the
11567 window height. Clean up the case of PT below the margin at bottom
11568 of window: scroll_max can no longer be INT_MAX. When aggressive
11569 scrolling is in use, don't let point enter the opposite scroll
11570 margin as result of the scroll.
11571 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11572 threshold of 100 lines for never-recentering scrolling.
11573
e4cc2dfc
JB
115742011-03-31 Juanma Barranquero <lekktu@gmail.com>
11575
11576 * dispextern.h (move_it_by_lines):
11577 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11578 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11579 (message_log_check_duplicate): Remove parameters `prev_bol' and
11580 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11581 (redisplay_internal): Remove parameter `preserve_echo_area',
11582 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11583
11584 * indent.c (Fvertical_motion):
11585 * window.c (window_scroll_pixel_based, Frecenter):
11586 Don't pass `need_y_p' to `move_it_by_lines'.
11587
1c470562
SM
115882011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11589
44f230aa
SM
11590 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11591 steal a few bits to be more compact.
11592 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11593 Remove unneeded casts.
11594
1c470562
SM
11595 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11596
888adce9
ZK
115972011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11598
11599 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11600 binding" message (bug#7967).
11601
f838ed7b
PE
116022011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11603
77861b95
PE
11604 Fix more problems found by GCC 4.6.0's static checks.
11605
de6dbc14
PE
11606 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11607 Remove unused local var.
11608
f838ed7b
PE
11609 * editfns.c (Fmessage_box): Remove unused local var.
11610
792c7b2b
PE
11611 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11612 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11613 Omit unused local vars.
c499e557 11614 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11615 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11616 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11617 Omit unused local var.
11618
ba0165e1
PE
11619 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11620 Don't assume string length fits in int.
32ad8845 11621 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11622 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11623
3c59b4c9
PE
11624 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11625 instead of alloca (Bug#8344).
11626
a3eed478 11627 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11628 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11629
eb4d412d
PE
11630 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11631
1658b401
PE
11632 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11633 concerns.
11634
11635 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11636
11637 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11638
9a2c6e05
PE
11639 * keyboard.c (syms_of_keyboard): Use the same style as later
11640 in this function when indexing through an array. This also
11641 works around GCC bug 48267.
11642
03d0a109
PE
11643 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11644
44f730c8
PE
11645 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11646
fe75f926
PE
11647 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11648 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11649
ffa8c828
PE
11650 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11651 This avoids undefined behavior on integer overflow, and is a bit
11652 more convenient anyway since it is compared to a size_t variable.
11653
c5101a77
PE
11654 Variadic C functions now count arguments with size_t, not int.
11655 This avoids an unnecessary limitation on 64-bit machines, which
11656 caused (substring ...) to crash on large vectors (Bug#8344).
11657 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11658 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11659 All variadic functions and their callers changed accordingly.
c5101a77
PE
11660 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11661 * data.c (arith_driver, float_arith_driver): Likewise.
11662 * editfns.c (general_insert_function): Likewise.
11663 * eval.c (struct backtrace.nargs, interactive_p)
11664 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11665 (funcall_lambda, mark_backtrace): Likewise.
11666 * fns.c (concat): Likewise.
11667 * frame.c (x_set_frame_parameters): Likewise.
11668 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11669 0 if not found, not -1. All callers changed.
11670
dd3f25f7
PE
11671 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11672 (stack_copy_size): Now size_t, not int.
11673 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11674
461c2ab9
JB
116752011-03-28 Juanma Barranquero <lekktu@gmail.com>
11676
11677 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11678 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11679 All callers changed.
11680
11681 * lisp.h (multibyte_char_to_unibyte):
11682 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11683 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11684 * character.h (CHAR_TO_BYTE8):
11685 * cmds.c (internal_self_insert):
11686 * editfns.c (general_insert_function):
11687 * keymap.c (push_key_description):
11688 * search.c (Freplace_match):
11689 * xdisp.c (message_dolog, set_message_1): All callers changed.
11690
f6d62986
SM
116912011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11692
11693 * keyboard.c (safe_run_hook_funcall): New function.
11694 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11695 don't set the hook to nil, but remove the offending function instead.
11696 (Qcommand_hook_internal): Remove, unused.
11697 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11698 Vcommand_hook_internal.
11699
11700 * eval.c (enum run_hooks_condition): Remove.
11701 (funcall_nil, funcall_not): New functions.
11702 (run_hook_with_args): Call each function through a `funcall' argument.
11703 Remove `cond' argument, now redundant.
11704 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11705 (Frun_hook_with_args_until_failure): Adjust accordingly.
11706 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11707
1db5b1ad
JB
117082011-03-28 Juanma Barranquero <lekktu@gmail.com>
11709
11710 * dispextern.h (string_buffer_position): Remove declaration.
11711
11712 * print.c (strout): Remove parameter `multibyte', unused since
11713 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11714
11715 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11716 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11717 All callers changed.
11718
11719 * w32.c (_wsa_errlist): Use braces for struct initializers.
11720
11721 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11722 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11723 All callers changed.
11724 (string_buffer_position): Likewise. Also, make static (it's never
11725 used outside xdisp.c).
11726 (cursor_row_p): Remove parameter `w', unused since
11727 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11728 (decode_mode_spec): Remove parameter `precision', introduced during
11729 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11730 All callers changed.
11731
5ffb62aa
JD
117322011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11733
11734 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11735
461c2ab9 117362011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11737
11738 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11739 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11740 (ns_update_auto_hide_menu_bar): New functions.
11741 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11742 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11743 ns_constrain_all_frames.
11744 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11745 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11746
5c380ffb
JD
117472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11748
11749 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11750
9af30bdf
GM
117512011-03-27 Glenn Morris <rgm@gnu.org>
11752
11753 * syssignal.h: Replace RETSIGTYPE with void.
11754 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11755 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11756 Replace SIGTYPE with void everywhere.
11757 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11758 * s/template.h (SIGTYPE): Remove commented out definition.
11759
e2abce01
JB
117602011-03-26 Eli Zaretskii <eliz@gnu.org>
11761
11762 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11763 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11764
f868cd8a
JB
117652011-03-26 Juanma Barranquero <lekktu@gmail.com>
11766
59eb0929
JB
11767 * w32.c (read_unc_volume): Use parameter `henum', instead of
11768 global variable `wget_enum_handle'.
11769
11770 * keymap.c (describe_vector): Remove parameters `indices' and
11771 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11772 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11773
f868cd8a
JB
11774 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11775
11776 * keyboard.c (timer_check): Remove parameter `do_it_now',
11777 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11778 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11779 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11780
11781 * keyboard.c (read_char):
11782 * w32menu.c (w32_menu_display_help):
11783 * xmenu.c (show_help_event, menu_help_callback):
11784 Adjust calls to `show_help_echo'.
11785
11786 * gtkutil.c (xg_maybe_add_timer):
11787 * keyboard.c (readable_events):
11788 * process.c (wait_reading_process_output):
11789 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11790
11791 * insdel.c (adjust_markers_gap_motion):
11792 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11793 (gap_left, gap_right): Don't call it.
11794
2ecf6fdb
CY
117952011-03-25 Chong Yidong <cyd@stupidchicken.com>
11796
11797 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11798 incurred during fontification.
11799
6b1f9ba4
JB
118002011-03-25 Juanma Barranquero <lekktu@gmail.com>
11801
11802 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11803 (DEFVAR_PER_BUFFER): Don't pass it.
11804
11805 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11806 (scrolling_window): Don't pass it.
11807
0f4a96b5
JB
118082011-03-25 Juanma Barranquero <lekktu@gmail.com>
11809
11810 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11811
11812 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11813 and `suffix'.
11814 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11815 of variables specific to SELinux and computation of `encoded_absname'.
11816
11817 * image.c (XPutPixel): Remove unused variable `height'.
11818
11819 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11820
11821 * unexw32.c (get_section_info): Remove unused variable `section'.
11822
11823 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11824 (system_process_attributes): Remove unused variable `sess'.
11825 (sys_read): Remove unused variable `err'.
11826
11827 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11828 (w32_wnd_proc): Remove unused variable `isdead'.
11829 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11830 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11831 (x_create_tip_frame): Remove unused variable `tem'.
11832
11833 * w32inevt.c (w32_console_read_socket):
11834 Remove unused variable `no_events'.
11835
11836 * w32term.c (x_draw_composite_glyph_string_foreground):
11837 Remove unused variable `width'.
11838
1149507c
JB
118392011-03-24 Juanma Barranquero <lekktu@gmail.com>
11840
11841 * w32term.c (x_set_glyph_string_clipping):
11842 Don't pass uninitialized region to CombineRgn.
11843
9c88f339
JB
118442011-03-23 Juanma Barranquero <lekktu@gmail.com>
11845
11846 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11847 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11848 (Fx_close_connection): Remove unused variable `i'.
11849
11850 * w32font.c (w32font_draw): Return number of glyphs.
11851 (w32font_open_internal): Remove unused variable `i'.
11852 (w32font_driver): Add missing initializer.
11853
11854 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11855 (fill_in_menu): Remove unused variable `items_added'.
11856
11857 * w32term.c (last_mouse_press_frame): Remove static global variable.
11858 (w32_clip_to_row): Remove unused variable `f'.
11859 (x_delete_terminal): Remove unused variable `i'.
11860
11861 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11862 (NOTHING): Remove unused static global variable.
11863 (uniscribe_check_otf): Remove unused variable `table'.
11864 (uniscribe_font_driver): Add missing initializers.
11865
dee091a3
JD
118662011-03-23 Julien Danjou <julien@danjou.info>
11867
11868 * term.c (Fsuspend_tty, Fresume_tty):
11869 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11870 * window.c (temp_output_buffer_show):
11871 * insdel.c (signal_before_change):
11872 * frame.c (Fhandle_switch_frame):
11873 * fileio.c (Fdo_auto_save):
11874 * emacs.c (Fkill_emacs):
11875 * editfns.c (save_excursion_restore):
11876 * cmds.c (internal_self_insert):
11877 * callint.c (Fcall_interactively):
11878 * buffer.c (Fkill_all_local_variables):
11879 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11880 Use Frun_hooks.
0f4a96b5 11881 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11882 unconditionally since it does the check itself.
dee091a3 11883
2c520ab5 118842011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11885
c9c49752
PE
11886 Fix more problems found by GCC 4.5.2's static checks.
11887
8abc3f12
PE
11888 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11889 the first time through the loop, since we know p0 < p1 then.
11890 This also avoids a gcc -Wstrict-overflow warning.
11891
a2d26660
PE
11892 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11893 leading to a memory leak, possible in functions like
11894 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11895 of objects (Bug#8318).
a2d26660 11896
916c72e9
PE
11897 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11898 that could (at least in theory) be that large.
11899
19ab8a18
PE
11900 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11901 This is less likely to overflow, and avoids undefined behavior if
11902 overflow does occur. All callers changed. Use strtoul to scan
11903 for the unsigned long integer.
b7cbbd6f
PE
11904 (pint2hrstr): Simplify and tune code slightly.
11905 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11906
f0641eff
PE
11907 * scroll.c (do_scrolling): Work around GCC bug 48228.
11908 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11909
7f650bb9
PE
11910 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11911 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11912 (validate_x_resource_name): Simplify count usage.
11913 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11914
37dd57d1
PE
11915 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11916 fail (Bug#8306).
81e56e61 11917
699979fc 11918 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11919
401bf9b4
PE
11920 * process.c (Fmake_network_process): Use socklen_t, not int,
11921 where POSIX says socklen_t is required in portable programs.
11922 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11923 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11924 (Fmake_network_process, server_accept_connection):
11925 (wait_reading_process_output, read_process_output):
11926 Likewise.
11927
b93aacde
PE
11928 * process.c: Rename or move locals to avoid shadowing.
11929 (list_processes_1, Fmake_network_process):
11930 (read_process_output_error_handler, exec_sentinel_error_handler):
11931 Rename or move locals.
4dc343ee 11932 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11933 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11934 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11935 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11936 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11937
af8a867c 11938 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11939 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11940 Include tparam.h instead, since it declares them.
af8a867c
PE
11941 * cm.h (PC): Remove extern decl; tparam.h now does this.
11942 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11943 * terminfo.c: Include tparam.h, to check interfaces.
11944 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11945 (tparam): Adjust signature to match interface in tparam.h;
11946 this removes some undefined behavior. Check that outstring and len
11947 are zero, which they always are with Emacs.
11948 * tparam.h (PC, BC, UP): New extern decls.
11949
0248044d 11950 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11951 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11952
8ff096c1 11953 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11954 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11955 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11956 (ftfont_list): Remove unused local.
49eaafba
PE
11957 (get_adstyle_property, ftfont_pattern_entity):
11958 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11959 Rename locals to avoid shadowing.
8ff096c1 11960
e2be39f6
PE
11961 * xfont.c (xfont_list_family): Mark var as initialized.
11962
c9735e30
PE
11963 * xml.c (make_dom): Now static.
11964
8f5201ae
PE
11965 * composite.c (composition_compute_stop_pos): Rename local to
11966 avoid shadowing.
b246f932
PE
11967 (composition_reseat_it): Remove unused locals.
11968 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11969 (composition_update_it): Mark var as initialized.
11b61122
PE
11970 (find_automatic_composition): Mark vars as initialized,
11971 with a FIXME (Bug#8290).
8f5201ae 11972
760fbc2c
PE
11973 character.h: Rename locals to avoid shadowing.
11974 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11975 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11976 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11977 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11978 to avoid shadowing.
11979
ff08eb85
PE
11980 * textprop.c (property_change_between_p): Remove; unused.
11981
fc7bf025
PE
11982 * intervals.c (interval_start_pos): Now static.
11983
235d7abc
PE
11984 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11985
44f230aa
SM
11986 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11987 Rename locals to avoid shadowing.
3e7d6594 11988
50060332
PE
11989 * sound.c (wav_play, au_play, Fplay_sound_internal):
11990 Fix pointer signedness.
d01f234b 11991 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11992 (wav_play): Initialize a variable to 0, to prevent undefined
11993 behavior (Bug#8278).
50060332 11994
c4fc4e30
PE
11995 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11996
918436ed
PE
11997 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11998
c939f91b
PE
11999 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12000 clobbering (Bug#8298).
b9c7f648
PE
12001 * sysdep.c (sys_subshell): Likewise.
12002 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12003
6bd8c144
PE
12004 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12005 This should get cleaned up, so that child_setup has the
12006 same signature on all platforms.
12007
7710357c 12008 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12009 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12010
c59da222
CY
120112011-03-22 Chong Yidong <cyd@stupidchicken.com>
12012
12013 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12014 not to be necessary, and produces flickering.
12015
66b87493
GM
120162011-03-20 Glenn Morris <rgm@gnu.org>
12017
12018 * config.in: Remove file.
12019
45b6f6d5
JB
120202011-03-20 Juanma Barranquero <lekktu@gmail.com>
12021
12022 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12023 are now in src/globals.h.
12024 (syms_of_minibuf): Remove spurious & from previous change.
12025
cd394be1 120262011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12027
12028 * minibuf.c (completing-read-function): New variable.
12029 (completing-read-default): Rename from completing-read.
12030 (completing-read): Call completing-read-function.
12031
b14e3e21
CY
120322011-03-19 Juanma Barranquero <lekktu@gmail.com>
12033
12034 * xfaces.c (Fx_load_color_file):
12035 Read color file from absolute filename (bug#8250).
12036
f2b726e6
JB
120372011-03-19 Juanma Barranquero <lekktu@gmail.com>
12038
12039 * makefile.w32-in: Update dependencies.
12040
09f6ff02
EZ
120412011-03-17 Eli Zaretskii <eliz@gnu.org>
12042
12043 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12044
29a6015a
PE
120452011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12046
a3a6c54e
PE
12047 Fix more problems found by GCC 4.5.2's static checks.
12048
b766f867
PE
12049 * process.c (make_serial_process_unwind, send_process_trap):
12050 (sigchld_handler): Now static.
12051
be02381c
PE
12052 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12053 That way, the code declares only the vars that it needs.
12054 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12055 * s/cygwin.h (PTY_ITERATION): Likewise.
12056 * s/darwin.h (PTY_ITERATION): Likewise.
12057 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12058
57048744
PE
12059 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12060 * process.c (allocate_pty): Don't declare stb unless it's needed.
12061
7914961c 12062 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12063 (CONSTANTLIM): Remove; unused.
12064 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12065 Define only if needed.
7914961c 12066
b3967b18
PE
12067 * unexelf.c (unexec): Name an expression,
12068 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12069 Use a different way to cause a compilation error if anyone uses
12070 n rather than nn, a way that does not involve shadowing.
73366a00 12071 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12072
29a6015a
PE
12073 * deps.mk (unexalpha.o): Remove; unused.
12074
43cfc33e 12075 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12076 * unexec.h: New file.
ce701a33
PE
12077 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12078 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12079 Depend on unexec.h.
12080 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12081 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12082 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12083 Change as necessary to match prototype in unexec.h.
ce701a33 12084
01f44d5a
PE
12085 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12086 shadowing.
4f63c6bb 12087 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12088
a6670b0b
PE
12089 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12090 Rename locals to avoid shadowing.
12091
cef2010d 12092 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12093 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12094
d4d7173a
PE
12095 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12096
f08b802a
PE
12097 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12098 warning when compiling print.c.
12099
3ddb0639
PE
12100 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12101 instead of using an uninitialized var.
5ad03b97 12102 (font_sort_entities): Mark var as initialized.
3ddb0639 12103
170a2692
PE
12104 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12105
e663c700
PE
12106 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12107 pointers to constants.
89bc529a 12108 (font_parse_fcname): Remove unused vars.
7b81e2d0 12109 (font_delete_unmatched): Now static.
ea838e10 12110 (font_get_spec): Remove; unused.
13a547c6
PE
12111 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12112 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12113 Rename or move locals to avoid shadowing.
e663c700 12114
2a80c887 12115 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12116 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12117
1384fa33 12118 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12119 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12120
8b2c52e9
PE
12121 * alloc.c (mark_backtrace): Move decl from here ...
12122 * lisp.h: ... to here, so that it can be checked.
12123
475545b5 12124 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12125 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12126 (lisp_indirect_variable): Name an expression,
12127 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12128 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12129
b1349114 12130 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12131 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12132 Use const pointer when appropriate.
b1349114 12133
a2928364
PE
12134 * lisp.h (get_system_name, get_operating_system_release):
12135 Move decls here, to check interfaces.
12136 * process.c (get_operating_system_release): Move decl to lisp.h.
12137 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12138 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12139 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12140 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12141 (Fformat_time_string, Fencode_time, Finsert_char):
12142 (Ftranslate_region_internal, Fformat):
12143 Rename or remove local vars to avoid shadowing.
9710023e 12144 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12145
a415e694
PE
12146 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12147 avoid shadowing.
12148
8ef4622d
PE
12149 * lisp.h (eassert): Check that the argument compiles, even if
12150 ENABLE_CHECKING is not defined.
12151
946f9a5b
PE
12152 * data.c (Findirect_variable): Name an expression, to avoid
12153 gcc -Wbad-function-cast warning.
112396d6 12154 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12155 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12156 (Fmake_variable_buffer_local, Fmake_local_variable):
12157 Mark variables as initialized.
52746918 12158 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12159
e5aab7e7 12160 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12161 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12162 Rename locals to avoid shadowing.
dff45157
PE
12163 (mark_stack): Move local variables into the #ifdef region where
12164 they're used.
7bc26fdb
PE
12165 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12166 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12167 needed otherwise.
12168 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12169 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12170 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12171
e5aab7e7
PE
12172 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12173 avoids undefined behavior in theory.
12174
4da60324
PE
12175 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12176
88043301
PE
12177 Use functions, not macros, for up- and down-casing (Bug#8254).
12178 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12179 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12180 to use the following functions instead of these macros.
12181 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12182 EMACS_INT, since callers assume the returned value fits in int.
12183 (upcase1): Likewise, for UPCASE_TABLE.
12184 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12185 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12186 the race-condition problem in the old DOWNCASE.
88043301 12187
19ed5445
PE
12188 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12189 Rename locals to avoid shadowing.
12190 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12191 (regex_compile, re_search_2, re_match_2_internal):
12192 Remove unused local vars.
952db0d7
PE
12193 (FREE_VAR): Rewrite so as not to use empty "else",
12194 which gcc can warn about.
da053e48 12195 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12196 (RETALLOC_IF): Define only if needed.
12197 (WORDCHAR_P): Likewise. This one is never needed, but is used
12198 only in a comment talking about a compiler bug, so put inside
12199 the #if 0 of that comment.
12200 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12201 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12202 Remove; unused.
19ed5445 12203
1f3561e4 12204 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12205 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12206 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12207
ded6f8f7
PE
12208 * search.c (simple_search): Remove unused var.
12209
dbd37a95
PE
12210 * dired.c (compile_pattern): Move decl from here ...
12211 * lisp.h: ... to here, so that it can be checked.
12212 (struct re_registers): New forward decl.
12213
7e47afad
PE
12214 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12215
85f24f61
PE
12216 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12217 All uses changed.
12218 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12219 Rename locals to avoid shadowing.
5671df8f 12220 (Fvertical_motion): Mark locals as initialized.
85f24f61 12221
181aa2be 12222 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12223 (casify_region): Mark local as initialized.
181aa2be 12224
930d429c
PE
12225 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12226
7082eac6
PE
12227 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12228 New macros, so that the caller can use some names other than
12229 gcpro1, gcpro2, etc.
12230 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12231 of the new macros.
12232 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12233 argument, for consistency with GCPRO2_VAR, etc: it is now the
12234 prefix of the variable, not the variable itself. All uses
12235 changed.
38b2c076
PE
12236 * dired.c (directory_files_internal, file_name_completion):
12237 Rename locals to avoid shadowing.
12238
15206ed9
PE
12239 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12240 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12241 dired.c's scmp function, had undefined behavior.
12242 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12243 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12244 * buffer.h: ... to here, because these macros use current_buffer,
12245 and the new implementation with inline functions needs to have
12246 current_buffer in scope now, rather than later when the macros
12247 are used.
12248 (downcase, upcase1): New static inline functions.
12249 (DOWNCASE, UPCASE1): Reimplement using these functions.
12250 This avoids undefined behavior in expressions like
12251 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12252 from race conditions in accessing the global variables
12253 case_temp1 and case_temp2.
12254 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12255 * lisp.h (case_temp1, case_temp2): Remove their decls.
12256 * character.h (ASCII_CHAR_P): Move from here ...
12257 * lisp.h: ... to here, so that the inline functions mentioned
12258 above can use them.
12259
4a6bea26
PE
12260 * dired.c (directory_files_internal_unwind): Now static.
12261
f14b7e14
PE
12262 * fileio.c (file_name_as_directory, directory_file_name):
12263 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12264 Now static.
2893f146
PE
12265 (file_name_as_directory): Use const pointers when appropriate.
12266 (Fexpand_file_name): Likewise. In particular, newdir might
12267 point at constant storage, so make it a const pointer.
fd4ead52 12268 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12269 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12270 signedness issues.
f839df0c
PE
12271 (Fset_file_times, Finsert_file_contents, auto_save_error):
12272 Rename locals to avoid shadowing.
f14b7e14 12273
5716756e 12274 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12275 (Ftry_completion, Fall_completions): Rename or remove locals
12276 to avoid shadowing.
5716756e 12277
b4c3046a
PE
12278 * marker.c (bytepos_to_charpos): Remove; unused.
12279
b45db522
PE
12280 * lisp.h (verify_bytepos, count_markers): New decls,
12281 so that gcc does not warn that these functions aren't declared.
12282
85876d07
PE
12283 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12284 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12285 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12286 (copy_text): Remove unused local var.
85876d07 12287
03d78a21 12288 * filelock.c (within_one_second): Now static.
b3dd38ab 12289 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12290
5df8f01b
PE
12291 * buffer.c (fix_overlays_before): Mark locals as initialized.
12292 (fix_start_end_in_overlays): Likewise. This function should be
12293 simplified by using pointers-to-pointers, but that's a different
12294 matter.
b1d876f1 12295 (switch_to_buffer_1): Now static.
8f54f30a
PE
12296 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12297 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12298
a70072c9 12299 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12300 Fix pointer signedness issue.
edced198
PE
12301 (sys_subshell): Mark local as volatile if checking for lint,
12302 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12303 (MAXPATHLEN): Define only if needed.
a70072c9 12304
a0977c44
PE
12305 * process.c (serial_open, serial_configure): Move decls from here ...
12306 * systty.h: ... to here, so that they can be checked.
12307
a884fdcc
PE
12308 * fns.c (get_random, seed_random): Move extern decls from here ...
12309 * lisp.h: ... to here, so that they can be checked.
12310
604efe86 12311 * sysdep.c (reset_io): Now static.
b8950c94 12312 (wait_for_termination_signal): Remove; unused.
604efe86 12313
38fc62d9
PE
12314 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12315 (copy_keymap_item, append_key, push_text_char_description):
12316 Now static.
1004a21a 12317 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12318 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12319 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12320 (describe_map_tree):
12321 Rename locals to avoid shadowing.
38fc62d9 12322
2f2650da
PE
12323 * keyboard.c: Declare functions static if they are not used elsewhere.
12324 (echo_char, echo_dash, cmd_error, top_level_2):
12325 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12326 (read_char, kbd_buffer_get_event, make_lispy_position):
12327 (make_lispy_event, make_lispy_movement, apply_modifiers):
12328 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12329 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12330 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12331 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12332 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12333
a053e86c 12334 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12335 (mark_kboards): Move decl here ...
12336 * alloc.c (mark_kboards): ... from here.
a053e86c 12337
4752793e
PE
12338 * lisp.h (force_auto_save_soon): New decl.
12339
74f10ca7 12340 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12341 (DEFINE_DUMMY_FUNCTION): New macro.
12342 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12343 Use it.
c03cd23f
PE
12344 (main): Add casts to avoid warnings
12345 if GCC considers string literals to be constants.
74f10ca7 12346
022e70d4
PE
12347 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12348
59d6fe83
PE
12349 * dbusbind.c: Pointer signedness fixes.
12350 (xd_signature, xd_append_arg, xd_initialize):
12351 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12352 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12353 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12354 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12355
78320123
PE
12356 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12357 if GCC considers string literals to be constants.
49cebcca 12358 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12359
35ac2a97
SM
123602011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12361
fb103ca9
SM
12362 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12363 (print_preprocess, print_object): New macro to fix last change.
12364
35ac2a97
SM
12365 * print.c (print_preprocess): Don't forget font objects.
12366
62973b41
JB
123672011-03-16 Juanma Barranquero <lekktu@gmail.com>
12368
12369 * emacs.c (USAGE3): Doc fixes.
12370
0e48bb22
AS
123712011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12372
12373 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12374 structure.
12375
7684e57b
JB
123762011-03-14 Juanma Barranquero <lekktu@gmail.com>
12377
12378 * lisp.h (VWindow_system, Qfile_name_history):
12379 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12380 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12381 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12382
12383 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12384 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12385
12386 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12387 * w32console.c (detect_input_pending, read_input_pending)
12388 (encode_terminal_code):
12389 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12390 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12391 (w32_system_caret_y, Qfile_name_history):
12392 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12393 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12394 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12395 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12396 * w32proc.c (Qlocal, report_file_error):
12397 * w32term.c (Vwindow_system, updating_frame):
12398 * w32uniscribe.c (initialized, uniscribe_font_driver):
12399 Remove unneeded extern declarations.
12400
2aa46d6c
CY
124012011-03-14 Chong Yidong <cyd@stupidchicken.com>
12402
c96bbc66 12403 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12404
cffc6f3b
CY
124052011-03-13 Chong Yidong <cyd@stupidchicken.com>
12406
12407 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12408 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12409 These macros can no longer be used for assignment.
12410
44f230aa
SM
12411 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12412 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12413 (record_buffer_markers, fetch_buffer_markers): New functions for
12414 recording and fetching special buffer markers.
12415 (set_buffer_internal_1, set_buffer_temp): Use them.
12416
12417 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12418
12419 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12420
12421 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12422 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12423
12424 * xdisp.c (hscroll_window_tree):
12425 (reconsider_clip_changes): Use PT instead of BUF_PT.
12426
d251f04b
EZ
124272011-03-13 Eli Zaretskii <eliz@gnu.org>
12428
12429 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12430 $(EMACS_ROOT)/lib/intprops.h.
12431
f0c77cd1
PE
124322011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12433
3eca4629
PE
12434 Fix more problems found by GCC 4.5.2's static checks.
12435
7c86ee98
PE
12436 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12437 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12438 (xg_free_frame_widgets): Make it clear that a local variable is
12439 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12440 (gdk_window_get_screen): Make it clear that this macro is needed
12441 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12442 (int_gtk_range_get_value): New function, which avoids a diagnostic
12443 from gcc -Wbad-function-cast.
12444 (xg_set_toolkit_scroll_bar_thumb): Use it.
12445 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12446 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12447 (get_utf8_string, xg_get_file_with_chooser):
12448 Rename locals to avoid shadowing.
12449 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12450
41729b81
PE
12451 * xgselect.c (xg_select): Remove unused var.
12452
f0c77cd1
PE
12453 * image.c (four_corners_best): Mark locals as initialized.
12454 (gif_load): Initialize transparent_p to zero (Bug#8238).
12455 Mark another local as initialized.
ec6cf4c6 12456 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12457
ce0ad53d 12458 * image.c (clear_image_cache): Now static.
d5d5a617 12459 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12460 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12461 (x_edge_detection): Remove unnecessary cast that
12462 gcc -Wbad-function-cast diagnoses.
2037898d 12463 (gif_load): Fix pointer signedness.
6ae141d6
PE
12464 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12465 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12466
33383987 124672011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12468
d32df629
PE
12469 Improve quality of tests for time stamp overflow.
12470 For example, without this patch (encode-time 0 0 0 1 1
12471 1152921504606846976) returns the obviously-bogus value (-948597
12472 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12473 reports time overflow. See
12474 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12475 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12476 * editfns.c: Include limits.h and intprops.h.
12477 (TIME_T_MIN, TIME_T_MAX): New macros.
12478 (time_overflow): Move earlier, to before first use.
12479 (hi_time, lo_time): New functions, for an accurate test for
12480 out-of-range times.
12481 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12482 (Fget_internal_run_time): Don't assume time_t fits in int.
12483 (make_time): Use list2 instead of Fcons twice.
12484 (Fdecode_time): More accurate test for out-of-range times.
12485 (check_tm_member): New function.
12486 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12487 (lisp_time_argument): Don't rely on undefined left-shift and
12488 right-shift behavior when checking for time stamp overflow.
8be6f318 12489
fe31d94c
PE
12490 * editfns.c (time_overflow): New function, refactoring common code.
12491 (Fformat_time_string, Fdecode_time, Fencode_time):
12492 (Fcurrent_time_string): Use it.
12493
8be6f318
PE
12494 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12495 * dired.c (make_time): Move to ...
12496 * editfns.c (make_time): ... here.
12497 * systime.h: Note the move.
12498
09d9db2c 124992011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12500
126bc0dc
YM
12501 * fringe.c (update_window_fringes): Remove unused variables.
12502
c47cbdfd
YM
12503 * unexmacosx.c (copy_data_segment): Also copy __got section.
12504 (Bug#8223)
12505
7ac80be9
EZ
125062011-03-12 Eli Zaretskii <eliz@gnu.org>
12507
c96bbc66 12508 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12509 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12510 Constify `char *' arguments and their references according to
12511 prototypes in tparam.h.
12512
ecb0f94d 12513 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12514
7ac80be9
EZ
12515 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12516 Adapt all references accordingly.
12517
12518 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12519
ef1fd07e
TT
125202011-03-11 Tom Tromey <tromey@redhat.com>
12521
12522 * buffer.c (syms_of_buffer): Remove obsolete comment.
12523
7ef4b50c
EZ
125242011-03-11 Eli Zaretskii <eliz@gnu.org>
12525
12526 * termhooks.h (encode_terminal_code): Declare prototype.
12527
12528 * msdos.c (encode_terminal_code): Don't declare prototype.
12529
12530 * term.c (encode_terminal_code): Now external again, used by
12531 w32console.c and msdos.c.
12532
44f230aa
SM
12533 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12534 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12535
4b1ec863 125362011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12537
1714f52b 12538 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12539
4b1ec863
PE
12540 * fringe.c (update_window_fringes): Mark locals as initialized
12541 (Bug#8227).
12542 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12543
524c7aa6
PE
12544 * alloc.c (mark_fringe_data): Move decl from here ...
12545 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12546 to check its interface.
12547 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12548
a5c0af81 12549 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12550 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12551 (fontset_font): Mark local as initialized.
a9a06e0b 12552 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12553
b4716021
PE
12554 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12555
811e9bac 12556 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12557 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12558 (x_own_selection, Fx_disown_selection_internal): Rename locals
12559 to avoid shadowing.
12560 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12561
7e3ab302
PE
12562 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12563 so that the caller can use some name other than gcpro1.
12564 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12565 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12566 (Fx_backspace_delete_keys_p):
12567 Use them to avoid shadowing, and rename vars to avoid shadowing.
12568 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12569 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12570 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12571 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12572 Remove unused locals.
7e3ab302
PE
12573 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12574 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12575 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12576 macros.
f78faa98 12577
e2b13473
PE
12578 * xterm.h (x_mouse_leave): New decl.
12579
77f23912
PE
12580 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12581 Remove unused functions.
cdf4ba58
PE
12582 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12583 (x_calc_absolute_position): Now static.
7411c686 12584 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12585 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12586 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12587 unless they are used.
38d0b34a
PE
12588 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12589 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12590 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12591 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12592 (x_error_catcher, x_connection_closed, x_error_handler):
12593 (x_error_quitter, xembed_send_message, x_iconify_frame):
12594 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12595 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12596 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12597
44f230aa
SM
12598 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12599 Rename or move locals to avoid shadowing.
6b463e58 12600 (tty_defined_color, merge_face_heights): Now static.
5967d051 12601 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12602 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12603 does not deduce is never used uninitialized.
73719eba
PE
12604 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12605 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12606
426994c3 12607 * terminal.c (store_terminal_param): Now static.
5489860b 12608
032f1620 12609 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12610 (set_frame_menubar): Remove unused local.
d4323972 12611 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12612 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12613 since they might point to immutable storage.
281585b0
PE
12614 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12615 since it's unused otherwise.
032f1620 12616
367c19e5 12617 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12618 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12619 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12620 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12621 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12622 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12623 does not deduce are never used uninitialized.
70739cbe 12624
07b48fa9
PE
12625 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12626
8868a238 12627 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12628 * window.c (window_loop, size_window):
12629 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12630
7e5cf297 12631 * window.c (display_buffer): Now static.
d6550a9f
PE
12632 (size_window): Mark variables that gcc -Wuninitialized
12633 does not deduce are never used uninitialized.
a586633d
PE
12634 * window.h (check_all_windows): New decl, to forestall
12635 gcc -Wmissing-prototypes diagnostic.
5b555da1 12636 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12637
f6095868
PE
12638 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12639 shadowing.
12640 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12641 Include <limits.h>.
12642 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12643 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12644 (load_charset_map): Mark variables that gcc -Wuninitialized
12645 does not deduce are never used uninitialized.
53df7c11 12646 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12647
f38b440c
PE
12648 * coding.c (coding_set_source, coding_set_destination):
12649 Use "else { /* comment */ }" rather than "else /* comment */;"
12650 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12651 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12652 a block, when the outer 'i' will do.
12653 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12654 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12655 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12656 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12657 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12658 Rename locals to avoid shadowing.
12659 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12660 * coding.c (emacs_mule_char, encode_invocation_designation):
12661 Now static, since they're not used elsewhere.
413bb2db 12662 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12663 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12664 (decode_coding_emacs_mule): Mark variables that gcc
12665 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12666 (detect_coding_iso_2022): Initialize a local variable that might
12667 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12668 this initialization is needed. (Bug#8211)
5f58e762
PE
12669 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12670 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12671 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12672 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12673 Remove unused macros.
f38b440c 12674
232b38b9 12675 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12676 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12677 * character.c (string_count_byte8): Likewise.
232b38b9 12678
fb90da1b
PE
12679 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12680 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12681
fb93dbc2
PE
12682 * chartab.c (copy_sub_char_table): Now static, since it's not used
12683 elsewhere.
5c156ace
PE
12684 (sub_char_table_ref_and_range, char_table_ref_and_range):
12685 Rename locals to avoid shadowing.
bbcd0949 12686 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12687
7d3b3862 12688 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12689 (BIDI_BOB): Remove unused macro.
7d3b3862 12690
6be7d3da
PE
12691 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12692 deduce are never used uninitialized.
c2ed9c8b 12693 * term.c (encode_terminal_code): Likewise.
6be7d3da 12694
75f8807f 12695 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12696
50938595
PE
12697 * tparam.h: New file.
12698 * term.c, tparam.h: Include it.
12699 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12700 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12701 Move these decls to tparam.h, and make them agree with what
12702 is actually in tparam.c. The previous trick of using incompatible
12703 decls in different modules does not conform to the C standard.
12704 All callers of tparam changed to use tparam's actual API.
12705 * tparam.c (tparam1, tparam, tgoto):
12706 Use const pointers where appropriate.
12707
fbceeba2
PE
12708 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12709 * cm.h (struct cm): Likewise.
12710 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12711 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12712 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12713 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12714 (turn_on_face, init_tty): Likewise.
12715 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12716
7f3f1250
PE
12717 * term.c (term_mouse_position): Rename local to avoid shadowing.
12718
e6ca6543
PE
12719 * alloc.c (mark_ttys): Move decl from here ...
12720 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12721
c40f8d15
AS
127222011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12723
12724 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12725
cfe0661d
JB
127262011-03-09 Juanma Barranquero <lekktu@gmail.com>
12727
12728 * search.c (compile_pattern_1): Remove argument regp, unused since
12729 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12730 (compile_pattern): Don't pass it.
12731
0afb4571
J
127322011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12733
12734 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12735 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12736 for ! HAVE_GTK3.
12737 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12738
12739 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12740
12741 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12742 gdk_window_get_screen, gdk_window_get_geometry,
12743 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12744 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12745 (xg_get_pixbuf_from_pixmap): New function.
12746 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12747 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12748 Call xg_get_pixbuf_from_pixmap instead of
12749 gdk_pixbuf_get_from_drawable.
12750 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12751 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12752 (xg_check_special_colors): Use GtkStyleContext and its functions
12753 for HAVE_GTK3.
12754 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12755 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12756 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12757 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12758 Call gtk_widget_get_preferred_size.
0afb4571
J
12759 (xg_frame_resized): gdk_window_get_geometry only takes 5
12760 parameters.
44f230aa
SM
12761 (xg_win_to_widget, xg_event_is_for_menubar):
12762 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12763 (xg_set_widget_bg): New function.
12764 (delete_cb): New function.
895009e1 12765 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12766 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12767 (xg_set_background_color): Call xg_set_widget_bg.
12768 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12769 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12770 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12771 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12772 if ! HAVE_GTK3.
12773 (update_frame_tool_bar): Call gtk_widget_hide.
12774 (xg_initialize): Use GDK_KEY_g.
12775
12776 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12777 if ! HAVE_GTK3
12778 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12779
12780 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12781 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12782 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12783
1c2cc4ef
JB
127842011-03-08 Juanma Barranquero <lekktu@gmail.com>
12785
12786 * w32xfns.c (select_palette): Check success of RealizePalette against
12787 GDI_ERROR, not zero.
12788
33383987 12789See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12790
12791;; Local Variables:
12792;; coding: utf-8
aac0c6e3
MR
12793;; End:
12794
2f097256 12795 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12796
12797 This file is part of GNU Emacs.
12798
12799 GNU Emacs is free software: you can redistribute it and/or modify
12800 it under the terms of the GNU General Public License as published by
12801 the Free Software Foundation, either version 3 of the License, or
12802 (at your option) any later version.
12803
12804 GNU Emacs is distributed in the hope that it will be useful,
12805 but WITHOUT ANY WARRANTY; without even the implied warranty of
12806 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12807 GNU General Public License for more details.
12808
12809 You should have received a copy of the GNU General Public License
12810 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.