* font.c, fontset.c: Make symbols static if they're not exported.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b532497d
PE
12011-04-13 Paul Eggert <eggert@cs.ucla.edu>
2
239f9db9
PE
3 * font.c, fontset.c: Make symbols static if they're not exported.
4 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6 * font.c (font_close_object): Now static.
7 * font.h (font_close_object): Remove.
8 * fontset.c (FONTSET_OBJLIST): Remove.
9 (free_realized_fontset) #if-0 the body, which does nothing.
10 (face_suitable_for_char_p): #if-0, as it's never called.
11 * fontset.h (face_suitable_for_char_p): Remove decl.
12 * xfaces.c (face_at_string_position): Use
13 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
14 since 0 is always ASCII.
15
dfcf3579
PE
16 * fns.c (weak_hash_tables): Now static.
17
5045092b
PE
18 * fileio.c: Make symbols static if they're not exported.
19 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
20 (Vwrite_region_annotation_buffers): Now static.
21
57a96f5c
PE
22 * eval.c: Make symbols static if they're not exported.
23 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
24 * lisp.h (backtrace_list): Remove decl.
25
35f08c38
PE
26 * emacs.c: Make symbols static if they're not exported.
27 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
28 (fatal_error_code, fatal_error_signal_hook, standard_args):
29 Now static.
30 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
31 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
32 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
33 * lisp.h (fatal_error_signal_hook): Remove decl.
34 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
35
f44bd759
PE
36 * editfns.c: Move a (normally-unused) function to its only use.
37 * editfns.c, lisp.h (get_operating_system_release): Remove.
38 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
39 worth the hassle of breaking this out.
40
b532497d
PE
41 * xterm.c: Make symbols static if they're not exported.
42 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
43 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
44 (x_destroy_window, x_delete_display):
45 Now static.
46 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
47 (x_mouse_leave): Remove; unused.
48 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
49 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
50 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
51 Remove decls.
52 (x_mouse_leave): Declare only if WINDOWSNT.
53 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
54 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
55 USE_X_TOOLKIT.
56
a25f4dfa
PE
572011-04-12 Paul Eggert <eggert@cs.ucla.edu>
58
1675728f
PE
59 * ftxfont.c: Make symbols static if they're not exported.
60 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
61 HAVE_FREETYPE.
62 * font.h (ftxfont_driver): Likewise.
63
e4cebfca
PE
64 * xfns.c: Make symbols static if they're not exported.
65 (x_last_font_name, x_display_info_for_name):
66 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
67 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
68 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
69 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
70 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
71 (last_show_tip_args): Now static.
72 (xic_defaut_fontset, xic_create_fontsetname): Define only if
73 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
74 (x_screen_planes): Remove; unused.
75 * dispextern.h (x_screen_planes): Remove decl.
76
5bf46f05
PE
77 * dispnew.c: Make symbols static if they're not exported.
78 * dispextern.h (redraw_garbaged_frames, scrolling):
79 (increment_row_positions): Remove.
80 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
81 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
82 Now static.
83 (redraw_garbaged_frames): Remove; unused.
84
435f4c28
PE
85 * xfaces.c: Make symbols static if they're not exported.
86 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
87 Remove decls.
88 * xterm.h (defined_color): Remove decls.
89 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
90 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
91 (menu_face_changed_default, defined_color, free_realized_face):
92 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
93 (ascii_face_of_lisp_face): Remove; unused.
94
8524aef3
PE
95 * xdisp.c: Make symbols static if they're not exported.
96 * dispextern.h (scratch_glyph_row, window_box_edges):
97 (glyph_to_pixel_coords, set_cursor_from_row):
98 (get_next_display_element, set_iterator_to_next):
99 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
100 (show_mouse_face): Remove decls
101 * frame.h (message_buf_print): Likewise.
102 * lisp.h (pop_message, set_message, check_point_in_composition):
103 Likewise.
104 * xterm.h (set_vertical_scroll_bar): Likewise.
105 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
106 (message_buf_print, scratch_glyph_row, displayed_buffer):
107 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
108 (get_next_display_element, show_mouse_face, window_box_edges):
109 (frame_to_window_pixel_xy, check_point_in_composition):
110 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
111 (glyph_to_pixel_coords): Remove; unused.
112
16390cd2
PE
113 * dired.c (file_name_completion): Now static.
114
115 * dbusbind.c (xd_in_read_queued_messages): Now static.
116
a25f4dfa
PE
117 * lisp.h (circular_list_error, FOREACH): Remove; unused.
118 * data.c (circular_list_error): Remove.
119
16a97296
PE
1202011-04-11 Paul Eggert <eggert@cs.ucla.edu>
121
14a9c8df
PE
122 * commands.h (last_point_position, last_point_position_buffer):
123 (last_point_position_window): Remove decls.
124 * keyboard.c: Make these variables static.
125
74ab6df5
PE
126 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
127 decls.
128 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
129 (iso_code_class, detect_coding, code_convert_region): Now static.
130 (encode_coding_gap): Remove; unused.
131
38dfbee1
PE
132 * chartab.c (chartab_chars, chartab_bits): Now static.
133
a2cb4e63
PE
134 * charset.h (charset_iso_8859_1): Remove decl.
135 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
136 Now static.
137
127198fd
PE
138 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
139 * ccl.c (Vccl_program_table): Now static.
140 (check_ccl_update): Remove; unused.
141
d85b608f
PE
142 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
143 * category.h: ... from here.
144 * category.c (check_category_table, set_category_set): Now static.
145
31cd66f3
PE
146 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
147 * lisp.h: Remove these decls.
148
c358e587
PE
149 * buffer.c (buffer_count): Remove unused var.
150
e78aecca
PE
151 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
152 so that it's not optimized away.
153 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
154 * dispextern.h (bidi_dump_cached_states): Remove, since it's
155 exported only to the debugger.
156
e192d7d3
PE
157 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
158 * atimer.h (run_all_atimers): Removed; not exported.
159
92470028
PE
160 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
161 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
162 was inaccessible from Lisp.
163 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
164 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
165
244ed907
PE
166 alloc.c: Import and export fewer symbols, and remove unused items.
167 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
168 is defined.
169 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
170 it's not optimized away by whole-program optimization.
171 (message_enable_multibyte, free_misc): Remove.
172 (catchlist, handlerlist, mark_backtrace):
173 Declare only if BYTE_MARK_STACK.
174 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
175 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
176 (message_enable_multibyte): Remove decl.
177 (free_misc, interval_free_list, float_block, float_block_index):
178 (n_float_blocks, float_free_list, cons_block, cons_block_index):
179 (cons_free_list, last_marked_index):
180 Now static.
181 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
182 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
183 (mark_backtrace): Define only if BYTE_MARK_STACK.
184 * xdisp.c (message_enable_multibyte): Now static.
185
955cbe7b
PE
186 Declare Lisp_Object Q* variables to be 'static' if not exproted.
187 This makes it easier for human readers (and static analyzers)
188 to see whether these variables are used from other modules.
189 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
190 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
191 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
192 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
193 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
194 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
195 * xmenu.c, xselect.c:
196 Declare Q* vars static if they are not used in other modules.
197 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
198 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
199 Remove decls of unexported vars.
200 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
201
95c82688
PE
202 * lisp.h (DEFINE_FUNC): Make sname 'static'.
203
16a97296
PE
204 Make Emacs functions such as Fatom 'static' by default.
205 This makes it easier for human readers (and static analyzers)
206 to see whether these functions can be called from other modules.
207 DEFUN now defines a static function. To make the function external
208 so that it can be used in other C modules, use the new macro DEFUE.
209 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
210 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
211 static function definition. Use DEFUE if you want an extern one.
212 (DEFUE, INFUN): New macros.
213 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
214 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
215 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
216 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
217 Remove decls, since these functions are now static.
218 (Funintern, Fget_internal_run_time): New decls, since these functions
219 were already external.
95c82688 220
16a97296
PE
221 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
222 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
223 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
224 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
225 * keyboard.c, keymap.c, lread.c:
226 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
227 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
228 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
229 Mark functions with DEFUE instead of DEFUN,
230 if they are used in other modules.
231 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
232 decls for now-static functions.
233 * buffer.h (Fdelete_overlay): Remove decl.
234 * callproc.c (Fgetenv_internal): Mark as internal.
235 * composite.c (Fremove_list_of_text_properties): Remove decl.
236 (Fcomposition_get_gstring): New forward static decl.
237 * composite.h (Fcomposite_get_gstring): Remove decl.
238 * dired.c (Ffile_attributes): New forward static decl.
239 * doc.c (Fdocumntation_property): New forward static decl.
240 * eval.c (Ffetch_bytecode): New forward static decl.
241 (Funintern): Remove extern decl; now in .h file where it belongs.
242 * fileio.c (Fmake_symbolic_link): New forward static decl.
243 * image.c (Finit_image_library): New forward static decl.
244 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
245 * intervals.h (Fprevious_property_change):
246 (Fremove_list_of_text_properties): Remove decls.
247 * keyboard.c (Fthis_command_keys): Remove decl.
248 (Fcommand_execute): New forward static decl.
249 * keymap.c (Flookup_key): New forward static decl.
250 (Fcopy_keymap): Now static.
251 * keymap.h (Flookup_key): Remove decl.
252 * process.c (Fget_process): New forward static decl.
253 (Fprocess_datagram_address): Mark as internal.
254 * syntax.c (Fsyntax_table_p): New forward static decl.
255 (skip_chars): Remove duplicate decl.
256 * textprop.c (Fprevious_property_change): New forward static decl.
257 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
258 Now internal.
259 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
260 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
261
785bbd42
PE
2622011-04-10 Paul Eggert <eggert@cs.ucla.edu>
263
264 * editfns.c (Fformat): Remove unreachable code.
265
4073e537 2662011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 267
b2ded58d
PE
268 Fix more problems found by GCC 4.6.0's static checks.
269
7d66342c
PE
270 * xdisp.c (vmessage): Use a better test for character truncation.
271
bbf47d44
PE
272 * charset.c (load_charset_map): <, not <=, for optimization,
273 and to avoid potential problems with integer overflow.
9248994d 274 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 275 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 276 * editfns.c (Fformat): Likewise.
1e69125e 277 * syntax.c (skip_chars): Likewise.
3befa583 278
e3019616
PE
279 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
280 This also lets GCC 4.6.0 generate slightly better loop code.
281
becfa255
PE
282 * callint.c (Fcall_interactively): <, not <=, for optimization.
283 (Fcall_interactively): Count the number of arguments produced,
284 not the number of arguments given. This is simpler and lets GCC
285 4.6.0 generate slightly better code.
286
dae0cd48
PE
287 * ftfont.c: Distingish more carefully between FcChar8 and char.
288 The previous code passed unsigned char * to a functions like
289 strlen and xstrcasecmp that expect char *, which does not
290 conform to the C standard.
291 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
292 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
293 char * when the C standard requires it.
294
76032d70
PE
295 * keyboard.c (read_char): Remove unused var.
296
eb3f1cc8
PE
297 * eval.c: Port to Windows vsnprintf (Bug#8435).
298 Include <limits.h>.
299 (SIZE_MAX): Define if the headers do not.
300 (verror): Do not give up if vsnprintf returns a negative count.
301 Instead, grow the buffer. This ports to Windows vsnprintf, which
302 does not conform to C99. Problem reported by Eli Zaretskii.
303 Also, simplify the allocation scheme, by avoiding the need for
304 calling realloc, and removing the ALLOCATED variable.
305
70476b54
PE
306 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
307
12020a9e
PE
308 Remove invocations of doprnt, as Emacs now uses vsnprintf.
309 But keep the doprint source code for now, as we might revamp it
310 and use it again (Bug#8435).
ea6c7ae6
PE
311 * lisp.h (doprnt): Remove.
312 * Makefile.in (base_obj): Remove doprnt.o.
313 * deps.mk (doprnt.o): Remove.
314
5fdb398c
PE
315 error: Print 32- and 64-bit integers portably (Bug#8435).
316 Without this change, on typical 64-bit hosts error ("...%d...", N)
317 was used to print both 32- and 64-bit integers N, which relied on
318 undefined behavior.
319 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
320 New macro.
321 * lisp.h (error, verror): Mark as printf-like functions.
322 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
323 Report overflow in size calculations when allocating printf buffer.
324 Do not truncate output string at its first null byte.
325 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
326 Truncate the output at a character boundary, since vsnprintf does not
327 do that.
328 * charset.c (check_iso_charset_parameter): Convert internal
329 character to string before calling 'error', since %c now has the
330 printf meaning.
331 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
332 overflow when computing char to be passed to 'error'. Do not
333 pass Lisp_Object to 'error'; pass the integer instead.
334 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
335 formatted with plain %d.
336
b189fa66
PE
337 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
338
bff87ef0
PE
339 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
340
7e2cac20
PE
341 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
342
ce4d90b5
PE
343 * xterm.c (x_catch_errors): Remove duplicate declaration.
344
266c9547
PE
345 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
346
79c49ad2
PE
347 * xdisp.c, lisp.h (message_nolog): Remove; unused.
348
368f4090
JM
3492011-04-10 Jim Meyering <meyering@redhat.com>
350
351 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
352 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
353 return ssize_t not "int", and use size_t as the buffer length.
354 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
355 * gnutls.h: Update declarations.
356 * process.c (read_process_output): Use ssize_t, to match.
357 (send_process): Likewise.
358
a32d4040
CY
3592011-04-09 Chong Yidong <cyd@stupidchicken.com>
360
361 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
362
8546720e 3632011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 364
8546720e
GM
365 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
366 unsigned char, to match FcChar8 type definition.
aac0c6e3 367
8546720e
GM
368 * xterm.c (handle_one_xevent):
369 * xmenu.c (create_and_show_popup_menu):
370 * xselect.c (x_decline_selection_request)
371 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 372
a53e2e89
EZ
3732011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
374
375 Fix some uses of `int' instead of EMACS_INT.
376 * search.c (string_match_1, fast_string_match)
377 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
378 (scan_buffer, find_next_newline_no_quit)
379 (find_before_next_newline, search_command, Freplace_match)
380 (Fmatch_data): Make some `int' variables be EMACS_INT.
381
382 * xdisp.c (display_count_lines): 3rd argument and return value now
383 EMACS_INT. All callers changed.
384 (pint2hrstr): Last argument is now EMACS_INT.
385
386 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
387 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
388 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
389 (decode_coding_utf_16, decode_coding_emacs_mule)
390 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
391 (decode_coding_ccl, decode_coding_charset)
392 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
393 (decode_coding_iso_2022, decode_coding_emacs_mule)
394 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
395 <char_offset, last_offset>: Declare EMACS_INT.
396 (encode_coding_utf_8, encode_coding_utf_16)
397 (encode_coding_emacs_mule, encode_invocation_designation)
398 (encode_designation_at_bol, encode_coding_iso_2022)
399 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
400 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
401 Declare EMACS_INT.
402 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
403 (encode_invocation_designation): Last argument P_NCHARS is now
404 EMACS_INT.
405 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
406 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
407
408 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
409 All users changed.
410
411 * ccl.c (Fccl_execute_on_string): Declare some variables
412 EMACS_INT.
413
8546720e 4142011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
415
416 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
417
4e19a977
CS
4182011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
419
420 * process.c (Fformat_network_address): Doc fix.
421
87302331
R
4222011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
423
424 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
425
cbb59342
CY
4262011-04-08 Chong Yidong <cyd@stupidchicken.com>
427
428 * keyboard.c (read_char): Call Lisp function help-form-show,
429 instead of using internal_with_output_to_temp_buffer.
430 (Qhelp_form_show): New var.
e0d38eeb 431 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
432
433 * print.c (internal_with_output_to_temp_buffer): Function deleted.
434
435 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
436
e67a13ab
CY
4372011-04-06 Chong Yidong <cyd@stupidchicken.com>
438
439 * process.c (Flist_processes): Removed to Lisp.
440 (list_processes_1): Deleted.
441
973f782d
EZ
4422011-04-06 Eli Zaretskii <eliz@gnu.org>
443
7c106b1e
EZ
444 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
445
973f782d
EZ
446 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
447
41cf7d1a 4482011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 449
ca23cc88
PE
450 Fix more problems found by GCC 4.6.0's static checks.
451
f390e2d5
PE
452 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
453
42eea0d0
PE
454 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
455
b69769da 456 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 457
f9541e84
PE
458 * xdisp.c (vmessage): Mark as a printf-like function.
459
13841b55
PE
460 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
461
c136c10f
PE
462 * sound.c (sound_warning): Don't crash if arg contains a printf format.
463
5e2d4a30
PE
464 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
465 printf-like functions.
466 (tiff_load): Add casts to remove these marks before passing them
467 to system-supplied API.
468
583f48b9
PE
469 * eval.c (Fsignal): Remove excess argument to 'fatal'.
470
b25d760e
PE
471 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
472 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
473 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
474 directly, rather than having caller test rule sign. This avoids
475 some unnecessary tests.
476 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
477 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
478 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 479
bc7b6697 480 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 481 (xfont_open): Avoid unnecessary tests.
bc7b6697 482
27ccc379
PE
483 * composite.c (composition_gstring_put_cache): Use unsigned integer.
484
dcd5c89a
PE
485 * composite.h, composite.c (composition_gstring_put_cache):
486 Use EMACS_INT, not int, for length.
487
b13a45c6
PE
488 * composite.h (COMPOSITION_DECODE_REFS): New macro,
489 breaking out part of COMPOSITION_DECODE_RULE.
490 (COMPOSITION_DECODE_RULE): Use it.
491 * composite.c (get_composition_id): Remove unused local vars,
492 by using the new macro.
493
1e792e4d
PE
494 * textprop.c (set_text_properties_1): Change while to do-while,
495 since the condition is always true at first.
496
dc6c6455 497 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
498 (interval_deletion_adjustment): Return unsigned value.
499 All uses changed.
dc6c6455 500
aba7731a
PE
501 * process.c (list_processes_1, create_pty, read_process_output):
502 (exec_sentinel): Remove vars that were set but not used.
afd4052b 503 (create_pty): Remove unnecessary "volatile"s.
bc57d757 504 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 505 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 506 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 507
fdfc4bf3
PE
508 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
509
fca8fe46 510 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 511 (update_syntax_table): Use unsigned instead of int.
fca8fe46 512
06a0259a 513 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 514 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 515 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 516
e7b9e80f
PE
517 * print.c (print_error_message): Avoid int overflow.
518
56201685
PE
519 * font.c (font_list_entities): Redo for clarity,
520 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
521
78834453 522 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 523 (font_score): Avoid potential overflow in diff calculation.
78834453 524
0bc0b309 525 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 526 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 527
e610eaca
PE
528 * eval.c (funcall_lambda): Rename local to avoid shadowing.
529
b895abce
PE
530 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
531 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
532 can always succeed if overflow has undefined behavior.
533
1f1d9321 534 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 535 (wordify): Omit three unnecessary tests.
1f1d9321 536
c59478bc
PE
537 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
538 All callers changed. This avoids the need for an unused var.
539
79b73827
PE
540 * casefiddle.c (casify_region): Remove var that is set but not used.
541
a4db5dfe
PE
542 * dired.c (file_name_completion): Remove var that is set but not used.
543
43aae36e
PE
544 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
545
2a47c44d 546 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 547 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 548
a37c69bf
PE
549 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
550 Check for integer overflow on size calculations.
551
328ab8e7
PE
552 * buffer.c (Fprevious_overlay_change): Remove var that is set
553 but not used.
554
e5a2a5cb
PE
555 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
556 Remove vars that are set but not used.
8d84a6eb 557 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 558 (timer_check_2): Mark vars as initialized.
e5a2a5cb 559
a60e5f68
PE
560 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
561
f661cb61 562 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 563 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 564
f0397f5a
PE
565 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
566 that are set but not used.
567
8664db06 568 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 569 if XCreateBitmapFromData fails (Bug#8410).
8664db06 570
6abdaa4a
PE
571 * xselect.c (x_get_local_selection, x_handle_property_notify):
572 Remove vars that are set but not used.
573
0ce7538d 574 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 575 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 576
9ae848fc
PE
577 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
578 Remove var that is set but not used.
0b918413
PE
579 (scroll_bar_windows_size): Now size_t, not int.
580 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
581 Check for overflow.
9ae848fc 582
a5a62657
PE
583 * xfaces.c (realize_named_face): Remove vars that are set but not used.
584 (map_tty_color) [!defined MSDOS]: Likewise.
585
5c5cdd39
PE
586 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
587
66ebf983
PE
588 * coding.c: Remove vars that are set but not used.
589 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
590 All callers changed.
591 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
592 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
593 (decode_coding_charset): Remove vars that are set but not used.
594
1be4d761
PE
595 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
596 that is set but not used.
597
47553fa8
PE
598 * print.c (print_object): Remove var that is set but not used.
599
1f7196bf 600 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
601 The gnulib version avoids calling malloc in the usual case,
602 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
603 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
604 * filelock.c (current_lock_owner): Likewise.
605 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
606 * sysdep.c: Include allocator.h, careadlinkat.h.
607 (emacs_no_realloc_allocator): New static constant.
608 (emacs_readlink): New function.
fdb61804
PE
609 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
610 ../lib/careadlinkat.h.
d1fdcab7 611
f84c17c7
SM
6122011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
613
614 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
615 first non-nil return value).
616
ef3862ad
JD
6172011-04-03 Jan Djärv <jan.h.d@swipnet.se>
618
619 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
620 if not defined (Bug#8403).
621
376a7006
JB
6222011-04-02 Juanma Barranquero <lekktu@gmail.com>
623
624 * xdisp.c (display_count_lines): Remove parameter `start',
625 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
626 (get_char_face_and_encoding): Remove parameter `multibyte_p',
627 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
628 (fill_stretch_glyph_string): Remove parameters `row' and `area',
629 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
630 and thereabouts. All callers changed.
631 (get_per_char_metric): Remove parameter `f', unused since
632 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
633
6ca3801d
JM
6342011-04-02 Jim Meyering <meyering@redhat.com>
635
636 do not dereference NULL upon failed strdup
637 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
638 (ns_get_family): Likewise.
639
d8e2b5ba
JB
6402011-04-02 Juanma Barranquero <lekktu@gmail.com>
641
642 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
643
8c74fcbd
JD
6442011-04-02 Jan Djärv <jan.h.d@swipnet.se>
645
646 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
647 later (Bug#8403).
648
7200d79c
SM
6492011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
650
03408648 651 Add lexical binding.
7200d79c 652
03408648
SM
653 * window.c (Ftemp_output_buffer_show): New fun.
654 (Fsave_window_excursion):
655 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
656
657 * lread.c (lisp_file_lexically_bound_p): New function.
658 (Fload): Bind Qlexical_binding.
659 (readevalloop): Remove `evalfun' arg.
660 Bind Qinternal_interpreter_environment.
661 (Feval_buffer): Bind Qlexical_binding.
662 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
663 Mark as dynamic.
664 (syms_of_lread): Declare `lexical-binding'.
665
666 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
667
668 * keyboard.c (eval_dyn): New fun.
669 (menu_item_eval_property): Use it.
ca105506
SM
670
671 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 672
03408648
SM
673 * fns.c (concat, mapcar1): Accept byte-code-functions.
674
675 * eval.c (Fsetq): Handle lexical vars.
676 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
677 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
678 (FletX, Flet): Obey lexical binding.
679 (Fcommandp): Handle closures.
680 (Feval): New `lexical' arg.
681 (eval_sub): New function extracted from Feval. Use it almost
682 everywhere where Feval was used. Look up vars in lexical env.
683 Handle closures.
684 (Ffunctionp): Move from subr.el.
685 (Ffuncall): Handle closures.
686 (apply_lambda): Remove `eval_flags'.
687 (funcall_lambda): Handle closures and new byte-code-functions.
688 (Fspecial_variable_p): New function.
689 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
690 but without exporting it to Lisp.
23aba0ea 691
23aba0ea 692 * doc.c (Fdocumentation, store_function_docstring):
03408648 693 * data.c (Finteractive_form): Handle closures.
23aba0ea 694
03408648
SM
695 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
696 interactive spec.
ba83908c 697
03408648
SM
698 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
699 byte-codes.
700 (exec_byte_code): New function extracted from Fbyte_code to handle new
701 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 702
03408648 703 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 704
03408648 705 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 706
e2abce01
JB
7072011-03-31 Juanma Barranquero <lekktu@gmail.com>
708
709 * xdisp.c (redisplay_internal): Fix prototype.
710
63696a73 7112011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 712
63696a73
EZ
713 * xdisp.c (SCROLL_LIMIT): New macro.
714 (try_scrolling): Use it when setting scroll_limit. Limit
715 scrolling to 100 screen lines.
716 (redisplay_window): Even when falling back on "recentering",
717 position point in the window according to scroll-conservatively,
718 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
719
720 (try_scrolling): When point is above the window, allow searching
721 as far as scroll_max, or one screenful, to compute vertical
722 distance from PT to the scroll margin position. This prevents
723 try_scrolling from unnecessarily failing when
724 scroll-conservatively is set to a value slightly larger than the
725 window height. Clean up the case of PT below the margin at bottom
726 of window: scroll_max can no longer be INT_MAX. When aggressive
727 scrolling is in use, don't let point enter the opposite scroll
728 margin as result of the scroll.
729 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
730 threshold of 100 lines for never-recentering scrolling.
731
e4cc2dfc
JB
7322011-03-31 Juanma Barranquero <lekktu@gmail.com>
733
734 * dispextern.h (move_it_by_lines):
735 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
736 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
737 (message_log_check_duplicate): Remove parameters `prev_bol' and
738 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
739 (redisplay_internal): Remove parameter `preserve_echo_area',
740 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
741
742 * indent.c (Fvertical_motion):
743 * window.c (window_scroll_pixel_based, Frecenter):
744 Don't pass `need_y_p' to `move_it_by_lines'.
745
1c470562
SM
7462011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
747
44f230aa
SM
748 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
749 steal a few bits to be more compact.
750 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
751 Remove unneeded casts.
752
1c470562
SM
753 * bytecode.c (Fbyte_code): CAR and CDR can GC.
754
888adce9
ZK
7552011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
756
757 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
758 binding" message (bug#7967).
759
f838ed7b
PE
7602011-03-30 Paul Eggert <eggert@cs.ucla.edu>
761
77861b95
PE
762 Fix more problems found by GCC 4.6.0's static checks.
763
de6dbc14
PE
764 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
765 Remove unused local var.
766
f838ed7b
PE
767 * editfns.c (Fmessage_box): Remove unused local var.
768
792c7b2b
PE
769 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
770 (note_mode_line_or_margin_highlight, note_mouse_highlight):
771 Omit unused local vars.
c499e557 772 * window.c (shrink_windows): Omit unused local var.
b01a1c29 773 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
774 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
775 Omit unused local var.
776
ba0165e1
PE
777 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
778 Don't assume string length fits in int.
32ad8845 779 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 780 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 781
3c59b4c9
PE
782 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
783 instead of alloca (Bug#8344).
784
a3eed478 785 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 786 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 787
eb4d412d
PE
788 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
789
1658b401
PE
790 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
791 concerns.
792
793 * term.c (produce_glyphless_glyph): Remove unnecessary test.
794
795 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 796
9a2c6e05
PE
797 * keyboard.c (syms_of_keyboard): Use the same style as later
798 in this function when indexing through an array. This also
799 works around GCC bug 48267.
800
03d0a109
PE
801 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
802
44f730c8
PE
803 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
804
fe75f926
PE
805 * chartab.c (sub_char_table_ref_and_range): Redo for slight
806 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
807
ffa8c828
PE
808 * keyboard.c, keyboard.h (num_input_events): Now size_t.
809 This avoids undefined behavior on integer overflow, and is a bit
810 more convenient anyway since it is compared to a size_t variable.
811
c5101a77
PE
812 Variadic C functions now count arguments with size_t, not int.
813 This avoids an unnecessary limitation on 64-bit machines, which
814 caused (substring ...) to crash on large vectors (Bug#8344).
815 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
816 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 817 All variadic functions and their callers changed accordingly.
c5101a77
PE
818 (struct gcpro.nvars): Now size_t, not int. All uses changed.
819 * data.c (arith_driver, float_arith_driver): Likewise.
820 * editfns.c (general_insert_function): Likewise.
821 * eval.c (struct backtrace.nargs, interactive_p)
822 (internal_condition_case_n, run_hook_with_args, apply_lambda)
823 (funcall_lambda, mark_backtrace): Likewise.
824 * fns.c (concat): Likewise.
825 * frame.c (x_set_frame_parameters): Likewise.
826 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
827 0 if not found, not -1. All callers changed.
828
dd3f25f7
PE
829 * alloc.c (garbage_collect): Don't assume stack size fits in int.
830 (stack_copy_size): Now size_t, not int.
831 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
832
461c2ab9
JB
8332011-03-28 Juanma Barranquero <lekktu@gmail.com>
834
835 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
836 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
837 All callers changed.
838
839 * lisp.h (multibyte_char_to_unibyte):
840 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
841 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
842 * character.h (CHAR_TO_BYTE8):
843 * cmds.c (internal_self_insert):
844 * editfns.c (general_insert_function):
845 * keymap.c (push_key_description):
846 * search.c (Freplace_match):
847 * xdisp.c (message_dolog, set_message_1): All callers changed.
848
f6d62986
SM
8492011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
850
851 * keyboard.c (safe_run_hook_funcall): New function.
852 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
853 don't set the hook to nil, but remove the offending function instead.
854 (Qcommand_hook_internal): Remove, unused.
855 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
856 Vcommand_hook_internal.
857
858 * eval.c (enum run_hooks_condition): Remove.
859 (funcall_nil, funcall_not): New functions.
860 (run_hook_with_args): Call each function through a `funcall' argument.
861 Remove `cond' argument, now redundant.
862 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
863 (Frun_hook_with_args_until_failure): Adjust accordingly.
864 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
865
1db5b1ad
JB
8662011-03-28 Juanma Barranquero <lekktu@gmail.com>
867
868 * dispextern.h (string_buffer_position): Remove declaration.
869
870 * print.c (strout): Remove parameter `multibyte', unused since
871 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
872
873 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
874 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
875 All callers changed.
876
877 * w32.c (_wsa_errlist): Use braces for struct initializers.
878
879 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
880 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
881 All callers changed.
882 (string_buffer_position): Likewise. Also, make static (it's never
883 used outside xdisp.c).
884 (cursor_row_p): Remove parameter `w', unused since
885 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
886 (decode_mode_spec): Remove parameter `precision', introduced during
887 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
888 All callers changed.
889
5ffb62aa
JD
8902011-03-27 Jan Djärv <jan.h.d@swipnet.se>
891
892 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
893
461c2ab9 8942011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
895
896 * nsterm.m (ns_menu_bar_is_hidden): New variable.
897 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
898 (ns_update_auto_hide_menu_bar): New functions.
899 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
900 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
901 ns_constrain_all_frames.
902 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
903 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
904
5c380ffb
JD
9052011-03-27 Jan Djärv <jan.h.d@swipnet.se>
906
907 * nsmenu.m (runDialogAt): Remove argument to timer_check.
908
9af30bdf
GM
9092011-03-27 Glenn Morris <rgm@gnu.org>
910
911 * syssignal.h: Replace RETSIGTYPE with void.
912 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
913 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
914 Replace SIGTYPE with void everywhere.
915 * s/usg5-4-common.h (SIGTYPE): Remove definition.
916 * s/template.h (SIGTYPE): Remove commented out definition.
917
e2abce01
JB
9182011-03-26 Eli Zaretskii <eliz@gnu.org>
919
920 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
921 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
922
f868cd8a
JB
9232011-03-26 Juanma Barranquero <lekktu@gmail.com>
924
59eb0929
JB
925 * w32.c (read_unc_volume): Use parameter `henum', instead of
926 global variable `wget_enum_handle'.
927
928 * keymap.c (describe_vector): Remove parameters `indices' and
929 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
930 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
931
f868cd8a
JB
932 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
933
934 * keyboard.c (timer_check): Remove parameter `do_it_now',
935 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
936 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
937 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
938
939 * keyboard.c (read_char):
940 * w32menu.c (w32_menu_display_help):
941 * xmenu.c (show_help_event, menu_help_callback):
942 Adjust calls to `show_help_echo'.
943
944 * gtkutil.c (xg_maybe_add_timer):
945 * keyboard.c (readable_events):
946 * process.c (wait_reading_process_output):
947 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
948
949 * insdel.c (adjust_markers_gap_motion):
950 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
951 (gap_left, gap_right): Don't call it.
952
2ecf6fdb
CY
9532011-03-25 Chong Yidong <cyd@stupidchicken.com>
954
955 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
956 incurred during fontification.
957
6b1f9ba4
JB
9582011-03-25 Juanma Barranquero <lekktu@gmail.com>
959
960 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
961 (DEFVAR_PER_BUFFER): Don't pass it.
962
963 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
964 (scrolling_window): Don't pass it.
965
0f4a96b5
JB
9662011-03-25 Juanma Barranquero <lekktu@gmail.com>
967
968 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
969
970 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
971 and `suffix'.
972 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
973 of variables specific to SELinux and computation of `encoded_absname'.
974
975 * image.c (XPutPixel): Remove unused variable `height'.
976
977 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
978
979 * unexw32.c (get_section_info): Remove unused variable `section'.
980
981 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
982 (system_process_attributes): Remove unused variable `sess'.
983 (sys_read): Remove unused variable `err'.
984
985 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
986 (w32_wnd_proc): Remove unused variable `isdead'.
987 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
988 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
989 (x_create_tip_frame): Remove unused variable `tem'.
990
991 * w32inevt.c (w32_console_read_socket):
992 Remove unused variable `no_events'.
993
994 * w32term.c (x_draw_composite_glyph_string_foreground):
995 Remove unused variable `width'.
996
1149507c
JB
9972011-03-24 Juanma Barranquero <lekktu@gmail.com>
998
999 * w32term.c (x_set_glyph_string_clipping):
1000 Don't pass uninitialized region to CombineRgn.
1001
9c88f339
JB
10022011-03-23 Juanma Barranquero <lekktu@gmail.com>
1003
1004 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1005 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1006 (Fx_close_connection): Remove unused variable `i'.
1007
1008 * w32font.c (w32font_draw): Return number of glyphs.
1009 (w32font_open_internal): Remove unused variable `i'.
1010 (w32font_driver): Add missing initializer.
1011
1012 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1013 (fill_in_menu): Remove unused variable `items_added'.
1014
1015 * w32term.c (last_mouse_press_frame): Remove static global variable.
1016 (w32_clip_to_row): Remove unused variable `f'.
1017 (x_delete_terminal): Remove unused variable `i'.
1018
1019 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1020 (NOTHING): Remove unused static global variable.
1021 (uniscribe_check_otf): Remove unused variable `table'.
1022 (uniscribe_font_driver): Add missing initializers.
1023
dee091a3
JD
10242011-03-23 Julien Danjou <julien@danjou.info>
1025
1026 * term.c (Fsuspend_tty, Fresume_tty):
1027 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1028 * window.c (temp_output_buffer_show):
1029 * insdel.c (signal_before_change):
1030 * frame.c (Fhandle_switch_frame):
1031 * fileio.c (Fdo_auto_save):
1032 * emacs.c (Fkill_emacs):
1033 * editfns.c (save_excursion_restore):
1034 * cmds.c (internal_self_insert):
1035 * callint.c (Fcall_interactively):
1036 * buffer.c (Fkill_all_local_variables):
1037 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1038 Use Frun_hooks.
0f4a96b5 1039 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1040 unconditionnaly since it does the check itself.
1041
2c520ab5 10422011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1043
c9c49752
PE
1044 Fix more problems found by GCC 4.5.2's static checks.
1045
8abc3f12
PE
1046 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1047 the first time through the loop, since we know p0 < p1 then.
1048 This also avoids a gcc -Wstrict-overflow warning.
1049
a2d26660
PE
1050 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1051 leading to a memory leak, possible in functions like
1052 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1053 of objects (Bug#8318).
a2d26660 1054
916c72e9
PE
1055 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1056 that could (at least in theory) be that large.
1057
19ab8a18
PE
1058 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1059 This is less likely to overflow, and avoids undefined behavior if
1060 overflow does occur. All callers changed. Use strtoul to scan
1061 for the unsigned long integer.
b7cbbd6f
PE
1062 (pint2hrstr): Simplify and tune code slightly.
1063 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1064
f0641eff
PE
1065 * scroll.c (do_scrolling): Work around GCC bug 48228.
1066 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1067
7f650bb9
PE
1068 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1069 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1070 (validate_x_resource_name): Simplify count usage.
1071 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1072
37dd57d1
PE
1073 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1074 fail (Bug#8306).
81e56e61 1075
699979fc 1076 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1077
401bf9b4
PE
1078 * process.c (Fmake_network_process): Use socklen_t, not int,
1079 where POSIX says socklen_t is required in portable programs.
1080 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1081 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1082 (Fmake_network_process, server_accept_connection):
1083 (wait_reading_process_output, read_process_output):
1084 Likewise.
1085
b93aacde
PE
1086 * process.c: Rename or move locals to avoid shadowing.
1087 (list_processes_1, Fmake_network_process):
1088 (read_process_output_error_handler, exec_sentinel_error_handler):
1089 Rename or move locals.
4dc343ee 1090 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1091 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1092 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1093 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1094 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1095
af8a867c 1096 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1097 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1098 Include tparam.h instead, since it declares them.
af8a867c
PE
1099 * cm.h (PC): Remove extern decl; tparam.h now does this.
1100 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1101 * terminfo.c: Include tparam.h, to check interfaces.
1102 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1103 (tparam): Adjust signature to match interface in tparam.h;
1104 this removes some undefined behavior. Check that outstring and len
1105 are zero, which they always are with Emacs.
1106 * tparam.h (PC, BC, UP): New extern decls.
1107
0248044d 1108 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1109 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1110
8ff096c1 1111 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1112 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1113 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1114 (ftfont_list): Remove unused local.
49eaafba
PE
1115 (get_adstyle_property, ftfont_pattern_entity):
1116 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1117 Rename locals to avoid shadowing.
8ff096c1 1118
e2be39f6
PE
1119 * xfont.c (xfont_list_family): Mark var as initialized.
1120
c9735e30
PE
1121 * xml.c (make_dom): Now static.
1122
8f5201ae
PE
1123 * composite.c (composition_compute_stop_pos): Rename local to
1124 avoid shadowing.
b246f932
PE
1125 (composition_reseat_it): Remove unused locals.
1126 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1127 (composition_update_it): Mark var as initialized.
11b61122
PE
1128 (find_automatic_composition): Mark vars as initialized,
1129 with a FIXME (Bug#8290).
8f5201ae 1130
760fbc2c
PE
1131 character.h: Rename locals to avoid shadowing.
1132 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1133 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1134 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1135 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1136 to avoid shadowing.
1137
ff08eb85
PE
1138 * textprop.c (property_change_between_p): Remove; unused.
1139
fc7bf025
PE
1140 * intervals.c (interval_start_pos): Now static.
1141
235d7abc
PE
1142 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1143
44f230aa
SM
1144 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1145 Rename locals to avoid shadowing.
3e7d6594 1146
50060332
PE
1147 * sound.c (wav_play, au_play, Fplay_sound_internal):
1148 Fix pointer signedness.
d01f234b 1149 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1150 (wav_play): Initialize a variable to 0, to prevent undefined
1151 behavior (Bug#8278).
50060332 1152
c4fc4e30
PE
1153 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1154
918436ed
PE
1155 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1156
c939f91b
PE
1157 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1158 clobbering (Bug#8298).
b9c7f648
PE
1159 * sysdep.c (sys_subshell): Likewise.
1160 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1161
6bd8c144
PE
1162 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1163 This should get cleaned up, so that child_setup has the
1164 same signature on all platforms.
1165
7710357c 1166 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1167 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1168
c59da222
CY
11692011-03-22 Chong Yidong <cyd@stupidchicken.com>
1170
1171 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1172 not to be necessary, and produces flickering.
1173
66b87493
GM
11742011-03-20 Glenn Morris <rgm@gnu.org>
1175
1176 * config.in: Remove file.
1177
45b6f6d5
JB
11782011-03-20 Juanma Barranquero <lekktu@gmail.com>
1179
1180 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1181 are now in src/globals.h.
1182 (syms_of_minibuf): Remove spurious & from previous change.
1183
3ec03f7e
LL
11842011-03-20 Leo <sdl.web@gmail.com>
1185
1186 * minibuf.c (completing-read-function): New variable.
1187 (completing-read-default): Rename from completing-read.
1188 (completing-read): Call completing-read-function.
1189
b14e3e21
CY
11902011-03-19 Juanma Barranquero <lekktu@gmail.com>
1191
1192 * xfaces.c (Fx_load_color_file):
1193 Read color file from absolute filename (bug#8250).
1194
f2b726e6
JB
11952011-03-19 Juanma Barranquero <lekktu@gmail.com>
1196
1197 * makefile.w32-in: Update dependencies.
1198
09f6ff02
EZ
11992011-03-17 Eli Zaretskii <eliz@gnu.org>
1200
1201 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1202
29a6015a
PE
12032011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1204
a3a6c54e
PE
1205 Fix more problems found by GCC 4.5.2's static checks.
1206
b766f867
PE
1207 * process.c (make_serial_process_unwind, send_process_trap):
1208 (sigchld_handler): Now static.
1209
be02381c
PE
1210 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1211 That way, the code declares only the vars that it needs.
1212 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1213 * s/cygwin.h (PTY_ITERATION): Likewise.
1214 * s/darwin.h (PTY_ITERATION): Likewise.
1215 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1216
57048744
PE
1217 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1218 * process.c (allocate_pty): Don't declare stb unless it's needed.
1219
7914961c 1220 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1221 (CONSTANTLIM): Remove; unused.
1222 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1223 Define only if needed.
7914961c 1224
b3967b18
PE
1225 * unexelf.c (unexec): Name an expression,
1226 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1227 Use a different way to cause a compilation error if anyone uses
1228 n rather than nn, a way that does not involve shadowing.
73366a00 1229 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1230
29a6015a
PE
1231 * deps.mk (unexalpha.o): Remove; unused.
1232
43cfc33e 1233 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1234 * unexec.h: New file.
ce701a33
PE
1235 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1236 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1237 Depend on unexec.h.
1238 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1239 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1240 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1241 Change as necessary to match prototype in unexec.h.
ce701a33 1242
01f44d5a
PE
1243 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1244 shadowing.
4f63c6bb 1245 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1246
a6670b0b
PE
1247 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1248 Rename locals to avoid shadowing.
1249
cef2010d 1250 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1251 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1252
d4d7173a
PE
1253 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1254
f08b802a
PE
1255 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1256 warning when compiling print.c.
1257
3ddb0639
PE
1258 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1259 instead of using an uninitialized var.
5ad03b97 1260 (font_sort_entities): Mark var as initialized.
3ddb0639 1261
170a2692
PE
1262 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1263
e663c700
PE
1264 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1265 pointers to constants.
89bc529a 1266 (font_parse_fcname): Remove unused vars.
7b81e2d0 1267 (font_delete_unmatched): Now static.
ea838e10 1268 (font_get_spec): Remove; unused.
13a547c6
PE
1269 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1270 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1271 Rename or move locals to avoid shadowing.
e663c700 1272
2a80c887 1273 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1274 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1275
1384fa33 1276 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1277 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1278
8b2c52e9
PE
1279 * alloc.c (mark_backtrace): Move decl from here ...
1280 * lisp.h: ... to here, so that it can be checked.
1281
475545b5 1282 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1283 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1284 (lisp_indirect_variable): Name an expression,
1285 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1286 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1287
b1349114 1288 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1289 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1290 Use const pointer when appropriate.
b1349114 1291
a2928364
PE
1292 * lisp.h (get_system_name, get_operating_system_release):
1293 Move decls here, to check interfaces.
1294 * process.c (get_operating_system_release): Move decl to lisp.h.
1295 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1296 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1297 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1298 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1299 (Fformat_time_string, Fencode_time, Finsert_char):
1300 (Ftranslate_region_internal, Fformat):
1301 Rename or remove local vars to avoid shadowing.
9710023e 1302 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1303
a415e694
PE
1304 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1305 avoid shadowing.
1306
8ef4622d
PE
1307 * lisp.h (eassert): Check that the argument compiles, even if
1308 ENABLE_CHECKING is not defined.
1309
946f9a5b
PE
1310 * data.c (Findirect_variable): Name an expression, to avoid
1311 gcc -Wbad-function-cast warning.
112396d6 1312 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1313 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1314 (Fmake_variable_buffer_local, Fmake_local_variable):
1315 Mark variables as initialized.
52746918 1316 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1317
e5aab7e7 1318 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1319 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1320 Rename locals to avoid shadowing.
dff45157
PE
1321 (mark_stack): Move local variables into the #ifdef region where
1322 they're used.
7bc26fdb
PE
1323 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1324 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1325 needed otherwise.
1326 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1327 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1328 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1329
e5aab7e7
PE
1330 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1331 avoids undefined behavior in theory.
1332
4da60324
PE
1333 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1334
88043301
PE
1335 Use functions, not macros, for up- and down-casing (Bug#8254).
1336 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1337 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1338 to use the following functions instead of these macros.
1339 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1340 EMACS_INT, since callers assume the returned value fits in int.
1341 (upcase1): Likewise, for UPCASE_TABLE.
1342 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1343 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1344 the race-condition problem in the old DOWNCASE.
88043301 1345
19ed5445
PE
1346 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1347 Rename locals to avoid shadowing.
1348 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1349 (regex_compile, re_search_2, re_match_2_internal):
1350 Remove unused local vars.
952db0d7
PE
1351 (FREE_VAR): Rewrite so as not to use empty "else",
1352 which gcc can warn about.
da053e48 1353 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1354 (RETALLOC_IF): Define only if needed.
1355 (WORDCHAR_P): Likewise. This one is never needed, but is used
1356 only in a comment talking about a compiler bug, so put inside
1357 the #if 0 of that comment.
1358 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1359 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1360 Remove; unused.
19ed5445 1361
1f3561e4 1362 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1363 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1364 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1365
ded6f8f7
PE
1366 * search.c (simple_search): Remove unused var.
1367
dbd37a95
PE
1368 * dired.c (compile_pattern): Move decl from here ...
1369 * lisp.h: ... to here, so that it can be checked.
1370 (struct re_registers): New forward decl.
1371
7e47afad
PE
1372 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1373
85f24f61
PE
1374 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1375 All uses changed.
1376 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1377 Rename locals to avoid shadowing.
5671df8f 1378 (Fvertical_motion): Mark locals as initialized.
85f24f61 1379
181aa2be 1380 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1381 (casify_region): Mark local as initialized.
181aa2be 1382
930d429c
PE
1383 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1384
7082eac6
PE
1385 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1386 New macros, so that the caller can use some names other than
1387 gcpro1, gcpro2, etc.
1388 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1389 of the new macros.
1390 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1391 argument, for consistency with GCPRO2_VAR, etc: it is now the
1392 prefix of the variable, not the variable itself. All uses
1393 changed.
38b2c076
PE
1394 * dired.c (directory_files_internal, file_name_completion):
1395 Rename locals to avoid shadowing.
1396
15206ed9
PE
1397 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1398 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1399 dired.c's scmp function, had undefined behavior.
1400 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1401 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1402 * buffer.h: ... to here, because these macros use current_buffer,
1403 and the new implementation with inline functions needs to have
1404 current_buffer in scope now, rather than later when the macros
1405 are used.
1406 (downcase, upcase1): New static inline functions.
1407 (DOWNCASE, UPCASE1): Reimplement using these functions.
1408 This avoids undefined behavior in expressions like
1409 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1410 from race conditions in accessing the global variables
1411 case_temp1 and case_temp2.
1412 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1413 * lisp.h (case_temp1, case_temp2): Remove their decls.
1414 * character.h (ASCII_CHAR_P): Move from here ...
1415 * lisp.h: ... to here, so that the inline functions mentioned
1416 above can use them.
1417
4a6bea26
PE
1418 * dired.c (directory_files_internal_unwind): Now static.
1419
f14b7e14
PE
1420 * fileio.c (file_name_as_directory, directory_file_name):
1421 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1422 Now static.
2893f146
PE
1423 (file_name_as_directory): Use const pointers when appropriate.
1424 (Fexpand_file_name): Likewise. In particular, newdir might
1425 point at constant storage, so make it a const pointer.
fd4ead52 1426 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1427 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1428 signedness issues.
f839df0c
PE
1429 (Fset_file_times, Finsert_file_contents, auto_save_error):
1430 Rename locals to avoid shadowing.
f14b7e14 1431
5716756e 1432 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1433 (Ftry_completion, Fall_completions): Rename or remove locals
1434 to avoid shadowing.
5716756e 1435
b4c3046a
PE
1436 * marker.c (bytepos_to_charpos): Remove; unused.
1437
b45db522
PE
1438 * lisp.h (verify_bytepos, count_markers): New decls,
1439 so that gcc does not warn that these functions aren't declared.
1440
85876d07
PE
1441 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1442 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1443 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1444 (copy_text): Remove unused local var.
85876d07 1445
03d78a21 1446 * filelock.c (within_one_second): Now static.
b3dd38ab 1447 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1448
5df8f01b
PE
1449 * buffer.c (fix_overlays_before): Mark locals as initialized.
1450 (fix_start_end_in_overlays): Likewise. This function should be
1451 simplified by using pointers-to-pointers, but that's a different
1452 matter.
b1d876f1 1453 (switch_to_buffer_1): Now static.
8f54f30a
PE
1454 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1455 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1456
a70072c9 1457 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1458 Fix pointer signedness issue.
edced198
PE
1459 (sys_subshell): Mark local as volatile if checking for lint,
1460 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1461 (MAXPATHLEN): Define only if needed.
a70072c9 1462
a0977c44
PE
1463 * process.c (serial_open, serial_configure): Move decls from here ...
1464 * systty.h: ... to here, so that they can be checked.
1465
a884fdcc
PE
1466 * fns.c (get_random, seed_random): Move extern decls from here ...
1467 * lisp.h: ... to here, so that they can be checked.
1468
604efe86 1469 * sysdep.c (reset_io): Now static.
b8950c94 1470 (wait_for_termination_signal): Remove; unused.
604efe86 1471
38fc62d9
PE
1472 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1473 (copy_keymap_item, append_key, push_text_char_description):
1474 Now static.
1004a21a 1475 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1476 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1477 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1478 (describe_map_tree):
1479 Rename locals to avoid shadowing.
38fc62d9 1480
2f2650da
PE
1481 * keyboard.c: Declare functions static if they are not used elsewhere.
1482 (echo_char, echo_dash, cmd_error, top_level_2):
1483 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1484 (read_char, kbd_buffer_get_event, make_lispy_position):
1485 (make_lispy_event, make_lispy_movement, apply_modifiers):
1486 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1487 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1488 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1489 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1490 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1491
a053e86c 1492 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1493 (mark_kboards): Move decl here ...
1494 * alloc.c (mark_kboards): ... from here.
a053e86c 1495
4752793e
PE
1496 * lisp.h (force_auto_save_soon): New decl.
1497
74f10ca7 1498 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1499 (DEFINE_DUMMY_FUNCTION): New macro.
1500 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1501 Use it.
c03cd23f
PE
1502 (main): Add casts to avoid warnings
1503 if GCC considers string literals to be constants.
74f10ca7 1504
022e70d4
PE
1505 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1506
59d6fe83
PE
1507 * dbusbind.c: Pointer signedness fixes.
1508 (xd_signature, xd_append_arg, xd_initialize):
1509 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1510 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1511 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1512 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1513
78320123
PE
1514 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1515 if GCC considers string literals to be constants.
49cebcca 1516 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1517
35ac2a97
SM
15182011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1519
fb103ca9
SM
1520 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1521 (print_preprocess, print_object): New macro to fix last change.
1522
35ac2a97
SM
1523 * print.c (print_preprocess): Don't forget font objects.
1524
62973b41
JB
15252011-03-16 Juanma Barranquero <lekktu@gmail.com>
1526
1527 * emacs.c (USAGE3): Doc fixes.
1528
0e48bb22
AS
15292011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1530
1531 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1532 structure.
1533
7684e57b
JB
15342011-03-14 Juanma Barranquero <lekktu@gmail.com>
1535
1536 * lisp.h (VWindow_system, Qfile_name_history):
1537 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1538 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1539 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1540
1541 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1542 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1543
1544 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1545 * w32console.c (detect_input_pending, read_input_pending)
1546 (encode_terminal_code):
1547 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1548 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1549 (w32_system_caret_y, Qfile_name_history):
1550 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1551 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1552 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1553 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1554 * w32proc.c (Qlocal, report_file_error):
1555 * w32term.c (Vwindow_system, updating_frame):
1556 * w32uniscribe.c (initialized, uniscribe_font_driver):
1557 Remove unneeded extern declarations.
1558
2aa46d6c
CY
15592011-03-14 Chong Yidong <cyd@stupidchicken.com>
1560
c96bbc66 1561 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1562
cffc6f3b
CY
15632011-03-13 Chong Yidong <cyd@stupidchicken.com>
1564
1565 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1566 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1567 These macros can no longer be used for assignment.
1568
44f230aa
SM
1569 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1570 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1571 (record_buffer_markers, fetch_buffer_markers): New functions for
1572 recording and fetching special buffer markers.
1573 (set_buffer_internal_1, set_buffer_temp): Use them.
1574
1575 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1576
1577 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1578
1579 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1580 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1581
1582 * xdisp.c (hscroll_window_tree):
1583 (reconsider_clip_changes): Use PT instead of BUF_PT.
1584
d251f04b
EZ
15852011-03-13 Eli Zaretskii <eliz@gnu.org>
1586
1587 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1588 $(EMACS_ROOT)/lib/intprops.h.
1589
f0c77cd1
PE
15902011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1591
3eca4629
PE
1592 Fix more problems found by GCC 4.5.2's static checks.
1593
7c86ee98
PE
1594 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1595 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1596 (xg_free_frame_widgets): Make it clear that a local variable is
1597 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1598 (gdk_window_get_screen): Make it clear that this macro is needed
1599 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1600 (int_gtk_range_get_value): New function, which avoids a diagnostic
1601 from gcc -Wbad-function-cast.
1602 (xg_set_toolkit_scroll_bar_thumb): Use it.
1603 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1604 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1605 (get_utf8_string, xg_get_file_with_chooser):
1606 Rename locals to avoid shadowing.
1607 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1608
41729b81
PE
1609 * xgselect.c (xg_select): Remove unused var.
1610
f0c77cd1
PE
1611 * image.c (four_corners_best): Mark locals as initialized.
1612 (gif_load): Initialize transparent_p to zero (Bug#8238).
1613 Mark another local as initialized.
ec6cf4c6 1614 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1615
ce0ad53d 1616 * image.c (clear_image_cache): Now static.
d5d5a617 1617 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1618 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1619 (x_edge_detection): Remove unnecessary cast that
1620 gcc -Wbad-function-cast diagnoses.
2037898d 1621 (gif_load): Fix pointer signedness.
6ae141d6
PE
1622 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1623 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1624
33383987 16252011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1626
d32df629
PE
1627 Improve quality of tests for time stamp overflow.
1628 For example, without this patch (encode-time 0 0 0 1 1
1629 1152921504606846976) returns the obviously-bogus value (-948597
1630 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1631 reports time overflow. See
1632 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1633 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1634 * editfns.c: Include limits.h and intprops.h.
1635 (TIME_T_MIN, TIME_T_MAX): New macros.
1636 (time_overflow): Move earlier, to before first use.
1637 (hi_time, lo_time): New functions, for an accurate test for
1638 out-of-range times.
1639 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1640 (Fget_internal_run_time): Don't assume time_t fits in int.
1641 (make_time): Use list2 instead of Fcons twice.
1642 (Fdecode_time): More accurate test for out-of-range times.
1643 (check_tm_member): New function.
1644 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1645 (lisp_time_argument): Don't rely on undefined left-shift and
1646 right-shift behavior when checking for time stamp overflow.
8be6f318 1647
fe31d94c
PE
1648 * editfns.c (time_overflow): New function, refactoring common code.
1649 (Fformat_time_string, Fdecode_time, Fencode_time):
1650 (Fcurrent_time_string): Use it.
1651
8be6f318
PE
1652 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1653 * dired.c (make_time): Move to ...
1654 * editfns.c (make_time): ... here.
1655 * systime.h: Note the move.
1656
09d9db2c 16572011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1658
126bc0dc
YM
1659 * fringe.c (update_window_fringes): Remove unused variables.
1660
c47cbdfd
YM
1661 * unexmacosx.c (copy_data_segment): Also copy __got section.
1662 (Bug#8223)
1663
7ac80be9
EZ
16642011-03-12 Eli Zaretskii <eliz@gnu.org>
1665
c96bbc66 1666 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1667 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1668 Constify `char *' arguments and their references according to
1669 prototypes in tparam.h.
1670
ecb0f94d 1671 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1672
7ac80be9
EZ
1673 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1674 Adapt all references accordingly.
1675
1676 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1677
ef1fd07e
TT
16782011-03-11 Tom Tromey <tromey@redhat.com>
1679
1680 * buffer.c (syms_of_buffer): Remove obsolete comment.
1681
7ef4b50c
EZ
16822011-03-11 Eli Zaretskii <eliz@gnu.org>
1683
1684 * termhooks.h (encode_terminal_code): Declare prototype.
1685
1686 * msdos.c (encode_terminal_code): Don't declare prototype.
1687
1688 * term.c (encode_terminal_code): Now external again, used by
1689 w32console.c and msdos.c.
1690
44f230aa
SM
1691 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1692 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1693
4b1ec863 16942011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1695
1714f52b 1696 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1697
4b1ec863
PE
1698 * fringe.c (update_window_fringes): Mark locals as initialized
1699 (Bug#8227).
1700 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1701
524c7aa6
PE
1702 * alloc.c (mark_fringe_data): Move decl from here ...
1703 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1704 to check its interface.
1705 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1706
a5c0af81 1707 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1708 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1709 (fontset_font): Mark local as initialized.
a9a06e0b 1710 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1711
b4716021
PE
1712 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1713
811e9bac 1714 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1715 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1716 (x_own_selection, Fx_disown_selection_internal): Rename locals
1717 to avoid shadowing.
1718 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1719
7e3ab302
PE
1720 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1721 so that the caller can use some name other than gcpro1.
1722 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1723 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1724 (Fx_backspace_delete_keys_p):
1725 Use them to avoid shadowing, and rename vars to avoid shadowing.
1726 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1727 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1728 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1729 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1730 Remove unused locals.
7e3ab302
PE
1731 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1732 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1733 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1734 macros.
f78faa98 1735
e2b13473
PE
1736 * xterm.h (x_mouse_leave): New decl.
1737
77f23912
PE
1738 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1739 Remove unused functions.
cdf4ba58
PE
1740 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1741 (x_calc_absolute_position): Now static.
7411c686 1742 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1743 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1744 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1745 unless they are used.
38d0b34a
PE
1746 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1747 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1748 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1749 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1750 (x_error_catcher, x_connection_closed, x_error_handler):
1751 (x_error_quitter, xembed_send_message, x_iconify_frame):
1752 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1753 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1754 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1755
44f230aa
SM
1756 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1757 Rename or move locals to avoid shadowing.
6b463e58 1758 (tty_defined_color, merge_face_heights): Now static.
5967d051 1759 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1760 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1761 does not deduce is never used uninitialized.
73719eba
PE
1762 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1763 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1764
426994c3 1765 * terminal.c (store_terminal_param): Now static.
5489860b 1766
032f1620 1767 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1768 (set_frame_menubar): Remove unused local.
d4323972 1769 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1770 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1771 since they might point to immutable storage.
281585b0
PE
1772 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1773 since it's unused otherwise.
032f1620 1774
367c19e5 1775 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1776 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1777 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1778 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1779 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1780 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1781 does not deduce are never used uninitialized.
70739cbe 1782
07b48fa9
PE
1783 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1784
8868a238 1785 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1786 * window.c (window_loop, size_window):
1787 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1788
7e5cf297 1789 * window.c (display_buffer): Now static.
d6550a9f
PE
1790 (size_window): Mark variables that gcc -Wuninitialized
1791 does not deduce are never used uninitialized.
a586633d
PE
1792 * window.h (check_all_windows): New decl, to forestall
1793 gcc -Wmissing-prototypes diagnostic.
5b555da1 1794 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1795
f6095868
PE
1796 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1797 shadowing.
1798 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1799 Include <limits.h>.
1800 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1801 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1802 (load_charset_map): Mark variables that gcc -Wuninitialized
1803 does not deduce are never used uninitialized.
53df7c11 1804 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1805
f38b440c
PE
1806 * coding.c (coding_set_source, coding_set_destination):
1807 Use "else { /* comment */ }" rather than "else /* comment */;"
1808 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1809 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1810 a block, when the outer 'i' will do.
1811 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1812 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1813 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1814 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1815 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1816 Rename locals to avoid shadowing.
1817 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1818 * coding.c (emacs_mule_char, encode_invocation_designation):
1819 Now static, since they're not used elsewhere.
413bb2db 1820 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1821 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1822 (decode_coding_emacs_mule): Mark variables that gcc
1823 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1824 (detect_coding_iso_2022): Initialize a local variable that might
1825 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1826 this initialization is needed. (Bug#8211)
5f58e762
PE
1827 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1828 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1829 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1830 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1831 Remove unused macros.
f38b440c 1832
232b38b9 1833 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1834 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1835 * character.c (string_count_byte8): Likewise.
232b38b9 1836
fb90da1b
PE
1837 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1838 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1839
fb93dbc2
PE
1840 * chartab.c (copy_sub_char_table): Now static, since it's not used
1841 elsewhere.
5c156ace
PE
1842 (sub_char_table_ref_and_range, char_table_ref_and_range):
1843 Rename locals to avoid shadowing.
bbcd0949 1844 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1845
7d3b3862 1846 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1847 (BIDI_BOB): Remove unused macro.
7d3b3862 1848
6be7d3da
PE
1849 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1850 deduce are never used uninitialized.
c2ed9c8b 1851 * term.c (encode_terminal_code): Likewise.
6be7d3da 1852
75f8807f 1853 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1854
50938595
PE
1855 * tparam.h: New file.
1856 * term.c, tparam.h: Include it.
1857 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1858 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1859 Move these decls to tparam.h, and make them agree with what
1860 is actually in tparam.c. The previous trick of using incompatible
1861 decls in different modules does not conform to the C standard.
1862 All callers of tparam changed to use tparam's actual API.
1863 * tparam.c (tparam1, tparam, tgoto):
1864 Use const pointers where appropriate.
1865
fbceeba2
PE
1866 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1867 * cm.h (struct cm): Likewise.
1868 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1869 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1870 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1871 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1872 (turn_on_face, init_tty): Likewise.
1873 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1874
7f3f1250
PE
1875 * term.c (term_mouse_position): Rename local to avoid shadowing.
1876
e6ca6543
PE
1877 * alloc.c (mark_ttys): Move decl from here ...
1878 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1879
c40f8d15
AS
18802011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1881
1882 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1883
cfe0661d
JB
18842011-03-09 Juanma Barranquero <lekktu@gmail.com>
1885
1886 * search.c (compile_pattern_1): Remove argument regp, unused since
1887 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1888 (compile_pattern): Don't pass it.
1889
0afb4571
J
18902011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1891
1892 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1893 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1894 for ! HAVE_GTK3.
1895 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1896
1897 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1898
1899 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1900 gdk_window_get_screen, gdk_window_get_geometry,
1901 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1902 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1903 (xg_get_pixbuf_from_pixmap): New function.
1904 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1905 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1906 Call xg_get_pixbuf_from_pixmap instead of
1907 gdk_pixbuf_get_from_drawable.
1908 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1909 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1910 (xg_check_special_colors): Use GtkStyleContext and its functions
1911 for HAVE_GTK3.
1912 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1913 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1914 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1915 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1916 Call gtk_widget_get_preferred_size.
0afb4571
J
1917 (xg_frame_resized): gdk_window_get_geometry only takes 5
1918 parameters.
44f230aa
SM
1919 (xg_win_to_widget, xg_event_is_for_menubar):
1920 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1921 (xg_set_widget_bg): New function.
1922 (delete_cb): New function.
1923 (xg_create_frame_widgets): connect delete-event to delete_cb.
1924 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1925 (xg_set_background_color): Call xg_set_widget_bg.
1926 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1927 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1928 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1929 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1930 if ! HAVE_GTK3.
1931 (update_frame_tool_bar): Call gtk_widget_hide.
1932 (xg_initialize): Use GDK_KEY_g.
1933
1934 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1935 if ! HAVE_GTK3
1936 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1937
1938 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1939 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1940 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1941
1c2cc4ef
JB
19422011-03-08 Juanma Barranquero <lekktu@gmail.com>
1943
1944 * w32xfns.c (select_palette): Check success of RealizePalette against
1945 GDI_ERROR, not zero.
1946
33383987 1947See ChangeLog.11 for earlier changes.
aac0c6e3
MR
1948
1949;; Local Variables:
1950;; coding: utf-8
aac0c6e3
MR
1951;; End:
1952
33383987 1953 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
1954
1955 This file is part of GNU Emacs.
1956
1957 GNU Emacs is free software: you can redistribute it and/or modify
1958 it under the terms of the GNU General Public License as published by
1959 the Free Software Foundation, either version 3 of the License, or
1960 (at your option) any later version.
1961
1962 GNU Emacs is distributed in the hope that it will be useful,
1963 but WITHOUT ANY WARRANTY; without even the implied warranty of
1964 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1965 GNU General Public License for more details.
1966
1967 You should have received a copy of the GNU General Public License
1968 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.