Fix displaying the user name in error message about no home directory.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
436bc8e0
EZ
12012-07-23 Eli Zaretskii <eliz@gnu.org>
2
3 * print.c (print_object): Don't crash when a frame's name is nil
4 or invalid. (Bug#12025)
5
6 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
7 it signals an error when a tooltip frame is being created.
8
d7a7fda3
DA
92012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
10
11 Cleanup miscellaneous objects allocation and initialization.
12 * alloc.c (allocate_misc): Change to static. Add argument to
13 specify the subtype. Adjust comment and users.
14 (build_overlay): New function.
15 * buffer.c (copy_overlays, Fmake_overlay): Use it.
16 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
17 (allocate_misc): Remove prototype.
18 (build_overlay): Add prototype.
19
202012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
21
22 Swap buffer text indirection counters in Fbuffer_swap_text.
23 * buffer.c (Fbuffer_swap_text): Swap indirections too.
24 This avoids crash reported by Christoph Scholtes at
25 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
26
9d7fa573
JD
272012-07-22 Jan Djärv <jan.h.d@swipnet.se>
28
29 * nsmenu.m (Popdown_data): New struct.
30 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
31 free Popdown_data.
32 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
33 (initWithContentRect): Make imgView and contentView non-static
34 and autorelease them. Also autorelease img and matrix (Bug#12005).
35 (dealloc): Remove (Bug#12005).
36
0dd6d66d
DA
372012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
38
39 Adjust consing_since_gc when objects are explicitly freed.
40 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
41 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
42 (free_cons, free_misc): Subtract object size from consing_since_gc.
43
d36d71df
DA
442012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
45
46 Simplify and cleanup markers positioning code.
47 * marker.c (attach_marker): More useful eassert.
48 (live_buffer, set_marker_internal): New function.
49 (Fset_marker, set_marker_restricted): Use set_marker_internal.
50 (set_marker_both, set_marker_restricted_both): Use live_buffer.
51
fb9ea40f
PE
522012-07-22 Paul Eggert <eggert@cs.ucla.edu>
53
54 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
55 as it's limited by the amount of memory, not by INT_MAX.
56
2d5c5f7d
EZ
572012-07-21 Eli Zaretskii <eliz@gnu.org>
58
07fb592e
EZ
59 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
60 in special-event-map. See the discussion at
61 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
62 for the reasons.
63
37a9eac8 64 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
65 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
66 Fabrice Popineau <fabrice.popineau@supelec.fr>.
67
c4328746
JD
682012-07-21 Jan Djärv <jan.h.d@swipnet.se>
69
70 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 71 (conversationIdentifier): Return value is NSInteger.
784051c4 72 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 73
6e5d1c12
CY
742012-07-21 Chong Yidong <cyd@gnu.org>
75
76 * window.c (decode_any_window): Signal an error if the window is
77 on a dead frame (Bug#11984).
78
9928463d
DA
792012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
80
81 Add indirection counting to speed up Fkill_buffer.
82 * buffer.h (struct buffer): New member.
83 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
84 (Fmake_indirect_buffer): Set indirection counter to -1, increment
85 base buffer indirection counter.
86 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
87 (Fkill_buffer): Adjust indirection counters as needed, don't walk
88 through buffer list if indirection counter is 0.
89
f8643a6b
DA
902012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
91
92 Extend the value returned by Fgarbage_collect with heap statistics.
93 * alloc.c (Qheap): New symbol.
94 (syms_of_alloc): DEFSYM it.
95 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
96 (Fmemory_free): Remove.
97 (syms_of_alloc): Don't defsubr it.
98 * buffer.c (Fcompact_buffer): Remove.
99 (syms_of_buffer): Don't defsubr it.
100
dac616ff
DA
1012012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
102
103 Make maybe_gc inline.
104 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
105 * lisp.h (consing_since_gc, gc_relative_threshold)
106 (memory_full_cons_threshold): Revert declaration.
107 (maybe_gc): Remove prototype, define as inline.
108 * alloc.c: Remove old commented-out code.
109 (consing_since_gc, gc_relative_threshold)
110 (memory_full_cons_threshold): Revert to global.
111 (maybe_gc): Remove.
112
d7ea76b4
DA
1132012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
114
115 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
116 * lisp.h (build_unibyte_string): New function.
117 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
118 * sysdep.c, w32fns.c, xfns.c: Use it.
119 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
120 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
121 Adjust users accordingly.
122 * font.h (font_open_by_name): Adjust prototype.
123
765e61e3
DA
1242012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
125
126 Cleanup calls to Fgarbage_collect.
127 * lisp.h (maybe_gc): New prototype.
128 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
129 Remove declarations.
130 * alloc.c (maybe_gc): New function.
131 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
132 Make them static.
133 * bytecode.c (MAYBE_GC): Use maybe_gc.
134 * eval.c (eval_sub, Ffuncall): Likewise.
135 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
136 to avoid dependency from auto-save feature.
137
52b852c7
PE
1382012-07-19 Paul Eggert <eggert@cs.ucla.edu>
139
140 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
141 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
142 'for_each_per_buffer_object_at'.
143 All uses changed. It's better to use upper-case for macros that
144 cannot be implemented as functions, to give the reader a clue
145 that they're special.
146
5db81e33
SM
1472012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
148
149 * alloc.c (Fgarbage_collect): Tweak docstring.
150
5b835e1d
DA
1512012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
152
153 Tweak the value returned from Fgarbage_collect again.
154 * alloc.c (Fgarbage_collect): New return value, as confirmed in
155 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
156 Adjust documentation.
157 (total_vector_bytes): Rename to total_vector_slots, adjust
158 accounting.
159 (total_free_vector_bytes): Rename to total_free_vector_slots,
160 adjust accounting.
161 (Qstring_bytes, Qvector_slots): New symbols.
162 (syms_of_alloc): DEFSYM them.
163
9cd47b72
DA
1642012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
165
166 Buffer compaction primitive which may be used from Lisp.
167 * buffer.c (compact_buffer, Fcompact_buffer): New function.
168 (syms_of_buffer): Register Fcompact_buffer.
169 * alloc.c (Fgarbage_collect): Use compact_buffer.
170 * buffer.h (compact_buffer): New prototype.
171 (struct buffer_text): New member.
172
d17337e5
DA
1732012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
174
175 New macro to iterate over all buffers, miscellaneous cleanups.
176 * lisp.h (all_buffers): Remove declaration.
177 * buffer.h (all_buffers): Add declaration, with comment.
178 (for_each_buffer): New macro.
179 * alloc.c (Fgarbage_collect, mark_object): Use it.
180 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
181 (init_buffer): Likewise.
182 * data.c (Fset_default): Likewise.
183 * coding.c (code_conversion_restore): Remove redundant check
184 for dead buffer.
185 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
186
60cfd278
AS
1872012-07-18 Andreas Schwab <schwab@linux-m68k.org>
188
189 Fix bug that created negative-length intervals.
190 * intervals.c (merge_interval_right, merge_interval_left):
191 Do not zero out this interval if it is absorbed by its children,
192 as this interval's total length doesn't change in that case. See
193 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
194
d06714cb
PE
1952012-07-18 Paul Eggert <eggert@cs.ucla.edu>
196
83713154
PE
197 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
198 when invoking (make-bool-vector N t) and N is a positive
199 multiple of 8 -- the last 8 bits were mistakenly cleared.
200
d06714cb
PE
201 Remove some struct layout assumptions in bool vectors.
202 * alloc.c (bool_header_size): New constant.
203 (header_size, word_size): Move earlier, as they're now used earlier.
204 Use 'word_size' in a few more places, where it's appropriate.
205 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
206 padding before the data member of a bool vector.
207 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
208 than doing the check by hand with an abort ().
209
464d5a5e
SM
2102012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
211
5fbc0409
SM
212 * eval.c (Fdefvar): Don't check constants since we only set the var if
213 it's not yet defined anyway (bug#11904).
214
464d5a5e
SM
215 * lisp.h (last_undo_boundary): Declare new var.
216 * keyboard.c (command_loop_1): Set it.
217 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
218 were auto-added by the command loop (bug#11774).
219
8dc2e44a
AS
2202012-07-18 Andreas Schwab <schwab@linux-m68k.org>
221
222 * w32font.c (Qsymbol): Remove local definition.
223 (syms_of_w32font): Don't DEFSYM it.
224
169925ec
DA
2252012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
226
227 Fix sweep_vectors to handle large bool vectors correctly.
228 * alloc.c (sweep_vectors): Account total_vector_bytes for
229 bool vectors larger than VBLOCK_BYTES_MAX.
230
5fbfb018
CY
2312012-07-18 Chong Yidong <cyd@gnu.org>
232
233 * frame.c (x_set_frame_parameters): Revert bogus change introduced
234 in 2012-05-25 commit by Paul Eggert (Bug#11738).
235
3ab6e069
DA
2362012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
237
238 Return more descriptive data from Fgarbage_collect.
239 Suggested by Stefan Monnier in
240 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
241 * alloc.c (bounded_number): New function.
242 (total_buffers, total_vectors): New variable.
243 (total_string_size): Rename to total_string_bytes, adjust users.
244 (total_vector_size): Rename to total_vector_bytes, adjust users.
245 (sweep_vectors): Account total_vectors and total_vector_bytes.
246 (Fgarbage_collect): New return value. Adjust documentation.
247 (gc_sweep): Account total_buffers.
248 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
249 (VECTOR_SIZE): Remove.
250 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
251 (Qinterval, Qmisc): New symbols.
252 (syms_of_data): Initialize them.
253 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
254 (Qcons, Qbuffer): New declarations.
255
6d02fe5b
PE
2562012-07-17 Paul Eggert <eggert@cs.ucla.edu>
257
258 * alloc.c (Fmemory_free): Account for memory-free's own storage.
259 Round up, not down. Improve doc.
260
b7ffe040
DA
2612012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
262
263 Restore old code in allocate_string_data to avoid Faset breakage.
264 Reported by Julien Danjou <julien@danjou.info> in
265 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
266 * alloc.c (allocate_string_data): Restore old code with minor
267 adjustments, fix comment to explain this subtle issue.
268
4dc7c8d5
SM
2692012-07-17 Eli Zaretskii <eliz@gnu.org>
270
271 Remove FILE_SYSTEM_CASE.
272 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
273
274 * fileio.c (FILE_SYSTEM_CASE): Don't define.
275 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
276 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
277 call-process-region passes it through expand-file-name.
278
279 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
280
2812012-07-17 Andreas Schwab <schwab@linux-m68k.org>
282
283 Fix crash when creating indirect buffer (Bug#11917)
284 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
285 Don't handle unbound variables specially if non-zero.
286 (Fbuffer_local_variables): Pass zero.
287 (clone_per_buffer_values): Pass non-zero.
288
2892012-07-17 Andreas Schwab <schwab@linux-m68k.org>
290
291 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
292 to make the loop interruptible.
293
2942012-07-17 Andreas Schwab <schwab@linux-m68k.org>
295
296 * gnutls.c (emacs_gnutls_handshake): Only retry if
297 GNUTLS_E_INTERRUPTED.
298
cce7fefc
DA
2992012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
300
301 Cleanup and convert miscellaneous checks to eassert.
302 * alloc.c (mark_interval): Fix comment, partially rephrase
303 old comment from intervals.h (see below).
304 * intervals.c (find_interval, adjust_intervals_for_insertion)
305 (delete_interval, adjust_intervals_for_deletion)
306 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
307 Convert to eassert.
308 (adjust_intervals_for_insertion, make_new_interval):
309 Remove obsolete and unused code.
310 * intervals.h (struct interval): Remove obsolete comment.
311 * textprotp.c (erase_properties): Remove unused code.
312 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
313 (Fremove_list_of_text_properties): Convert to eassert.
314
9ea10cc3
CY
3152012-07-17 Chong Yidong <cyd@gnu.org>
316
317 * editfns.c (Finsert_char): Doc fix.
318
3900d5de
DA
3192012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
320
321 Fix previous change to make Fmemory_free always accurate.
322 * alloc.c (make_interval): Update total_free_intervals.
323 (make_float): Likewise for total_free_floats.
324 (free_cons, Fcons): Likewise for total_free_conses.
325 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
326 Likewise for total_free_vector_bytes.
327 (Fmake_symbol): Likewise for total_free_symbols.
328 (bytes_free): Remove.
329
7098646f
DA
3302012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
331
332 Simple free memory accounting feature.
333 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
334 (sweep_vectors): Accumulate size of free vectors.
335 (Fgarbage_collect): Setup bytes_free.
336 (Fmemory_free): New function.
337 (syms_of_alloc): Register it.
338
22657b40
DA
3392012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
340
341 Cleanup overlays checking.
342 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
343 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
344 eassert and OVERLAYP.
345 (sort_overlays): Change to use OVERLAYP.
346
ddfc8813
RK
3472012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
348
349 * editfns.c (Finsert_char): Make it interactive, and make the
350 second arg optional. Copy interactive spec and docstring from
351 ucs-insert.
352
7c26cf3c
PE
3532012-07-17 Paul Eggert <eggert@cs.ucla.edu>
354
355 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
356 Unlike the other wrapped functions, fabs has an unspecified
357 effect on errno.
358
5d127af9
JD
3592012-07-16 Jan Djärv <jan.h.d@swipnet.se>
360
361 * nsterm.m (keyDown): Interpret flags without left/right bits
362 as the left key (Bug#11670).
363
6a0dd1d7
DA
3642012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
365
366 Remove empty and useless init functions.
367 * lisp.h (init_character_once, init_fns, init_image)
368 (init_filelock, init_sound): Remove prototype.
369 * character.c (init_character_once): Remove.
370 * filelock.c (init_filelock): Likewise.
371 * fns.c (init_fns): Likewise.
372 * image.c (init_image): Likewise.
373 * sound.c (init_sound): Likewise.
374 * emacs.c (main): Adjust accordingly.
375
7a6136fd
DA
3762012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
377
378 * gtkutil.h: Tiny cleanups.
379 (use_old_gtk_file_dialog): Remove useless declaration.
380 (xg_uses_old_file_dialog): Add suggested const attribute.
381
ce811ad9
EZ
3822012-07-15 Eli Zaretskii <eliz@gnu.org>
383
384 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
385 (bidi_paragraph_init): Use it to limit search forward for a strong
386 directional character in abnormally large paragraphs full of
387 neutral or weak characters. (Bug#11943)
388
c9adfeaa
SF
3892012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
390
391 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
392 the toolbar (Bug#9451).
393 (xg_make_tool_item): Give the widget event box a transparent
394 background.
395
fff62aa9
DA
3962012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
397
398 Cleanup basic allocation variables and functions.
399 * alloc.c (ignore_warnings, init_intervals, init_float)
400 (init_cons, init_symbol, init_marker): Remove.
401 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
402 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
403 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
404 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
405 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
406 (staticidx, init_alloc_once, init_strings, free_ablock):
407 Remove redundant initialization.
408 * fns.c (init_weak_hash_tables): Remove.
409 * lisp.h (init_weak_hash_tables): Remove prototype.
410
9730daca
DA
4112012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
412
413 Use zero_vector where appropriate.
414 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
415 accordingly.
416 * lisp.h (zero_vector): New declaration.
417 * font.c (null_vector): Remove.
418 (syms_of_font): Remove initialization and staticpro.
419 (font_list_entities, font_find_for_lface): Change to use zero_vector.
420 * keymap.c (Faccessible_keymaps): Likewise.
421
2e2d2a13
LL
4222012-07-15 Leo Liu <sdl.web@gmail.com>
423
424 * fringe.c: Fix typo in comments.
425
cd276f6e
LL
4262012-07-14 Leo Liu <sdl.web@gmail.com>
427
428 * fringe.c: Add a new bitmap exclamation-mark.
429
5a1131d9
EZ
4302012-07-14 Eli Zaretskii <eliz@gnu.org>
431
432 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
433
434 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
435 (HAVE_MENUS): Don't define, defined by editing config.in with
436 msdos/sed2v2.inp.
437 (GMALLOC_INHIBIT_VALLOC): Don't define.
438 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
439
22e983b7
JB
4402012-07-14 Juanma Barranquero <lekktu@gmail.com>
441
442 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
443
5b3f250f
GM
4442012-07-14 Glenn Morris <rgm@gnu.org>
445
446 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
447 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
448 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
449
33d63ff4
GM
4502012-07-13 Glenn Morris <rgm@gnu.org>
451
5b633342
GM
452 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
453
33d63ff4
GM
454 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
455 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
456
b55b9f85
JD
4572012-07-13 Jan Djärv <jan.h.d@swipnet.se>
458
0dc8cf50
JD
459 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
460 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
461 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
462 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
463 where appropriate.
464 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
465 as boolean expression.
466 (x_set_window_size): Remove unused variable toolbar.
467 (ns_get_color_default, ns_mod_to_lisp): Remove.
468 (ns_mouse_position): Remove unused variables xchar and ychar.
469 (ns_compute_glyph_string_overhangs): Remove unused variable face.
470 (ns_set_vertical_scroll_bar): Remove unused variable count.
471 (ns_delete_terminal): Remove unused variable i.
472 (ns_term_init): Remove unused variables r, g and b.
473 (mouseDown): Remove unused variable window.
474 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
475 (initFrameFromEmacs): Remove unused variable vbextra.
476 (mouseEntered): Remove unused variables p and dpyinfo.
477 (mouseExited): Remove unused variables p and r.
478 (ns_define_frame_cursor, ns_clear_frame_area)
479 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
480 (menuDown): Assign [sender tag] to variable and cast the variable.
481
482 * nsterm.h (menuDown): Add id as type to argument sender.
483 (ns_display_info_for_name): Add Lisp_Object argument.
484 (ns_term_init): Add Lisp_Object argument.
485 (ns_map_event_to_object): Add void argument.
486 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
487 prototype with arguments and only declare if __OBJC__.
488 (nxatoms_of_nsselect): Add void argument.
489 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
490 (ns_alloc_autorelease_pool): Add void argument.
491 (ns_release_autorelease_pool): Add void* argument.
492 (ns_get_defaults_value): Add const char* argument.
493
494 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
495 (initFromContents): Use SSDATA where appropriate.
496 (ns_update_menubar): Add braces to ambigous if-else.
497 (initWithTitle): Put () around assignment in if statement.
498 (ns_menu_show): Remove unused variables window and keymap.
499 (update_frame_tool_bar): Remove unused variable selected_p.
500 (initWithContentRect): Remove unused variable this_cmd_name.
501
502 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
503 appropriate.
504 (setXBMColor): Remove unused variable len.
505 (setPixmapData): Put () around assignment in loop statement.
506
507 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
508 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
509 where appropriate.
510 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
511 around assignment in loop statement.
512 (nsfont_open): Remove unused variable i.
513 (nsfont_open): Remove unused variable len.
514 (nsfont_draw): Remove unused variable cs.
515
516 * nsfns.m (x_set_icon_name, ns_set_name_internal)
517 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
518 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
519 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
520 (Fns_font_name, Fns_perform_service)
521 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
522 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
523 (ns_set_name): Remove unused variable view.
524 (x_set_menu_bar_lines): Remove unused variable olines.
525 (x_set_tool_bar_lines): Remove unused variable root_window.
526 (Fns_list_colors): Put () around assignment in while statement.
527 (Fns_perform_service): Remove unused variable len.
528 (Fns_display_usable_bounds): Remove unused variable top.
529 (syms_of_nsfns): Remove unused variable i.
530
b55b9f85
JD
531 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
532 memcpy (Bug#11907).
533
ed9265fc 5342012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
535
536 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
537 and free it with DestroyExceptionInfo (Bug#11558).
538
ef099b57
JB
5392012-07-13 Juanma Barranquero <lekktu@gmail.com>
540
541 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
542 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
543 Set here, not in nt/config.nt.
544
ea814a5d
EZ
5452012-07-13 Eli Zaretskii <eliz@gnu.org>
546
547 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
548 cursor overflow into the last glyph on display line when the right
549 fringe is off. (Bug#11832)
550
1a952767
PE
5512012-07-13 Paul Eggert <eggert@cs.ucla.edu>
552
553 * xdisp.c (produce_special_glyphs): Now static.
554 * dispextern.h (produce_special_glyphs): Remove decl.
555
983188fd
GM
5562012-07-13 Glenn Morris <rgm@gnu.org>
557
32fb4bb6
GM
558 * s/bsd-common, s/cygwin.h: Remove empty files.
559 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
560
983188fd
GM
561 * s/usg5-4-common.h (USG, USG5):
562 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
563 * s/sol2-6.h (SOLARIS2):
564 * s/irix6-5.h (IRIX6_5):
565 * s/hpux10-20.h (USG, USG5, HPUX):
566 * s/gnu-linux.h (USG, GNU_LINUX):
567 * s/freebsd.h (BSD_SYSTEM):
568 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
569 * s/cygwin.h (CYGWIN):
570 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
571 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
572
d1e68667 5732012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
574
575 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 576
6de0e799
GM
5772012-07-13 Glenn Morris <rgm@gnu.org>
578
739ae010
GM
579 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
580
dbee5793
GM
581 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
582
6de0e799
GM
583 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
584 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
585
b82da769
GM
5862012-07-12 Glenn Morris <rgm@gnu.org>
587
4fae5a7a 588 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
589
590 * process.c (init_process_emacs): Rename from init_process.
591 The old name is also the name of a Mach system call.
592 * lisp.h, emacs.c: Update for this name change.
593 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
594 longer needed.
595
5a979817
EZ
5962012-07-12 Eli Zaretskii <eliz@gnu.org>
597
598 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
599 memmove call that removes glyphs covered by the left truncation
600 glyph. Improve commentary.
601 (display_line): Fix display of continuation glyphs on GUI frames
602 when the right fringe is turned off and variable-size fonts are
603 used in the window. Move the code that appends a stretch glyph to
604 produce_special_glyphs, so that it could be used for truncation
605 and continuation glyphs alike.
606 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
607 glyph of a suitably computed width, to align the special glyphs at
608 the window margin. Code moved from display_line. (Bug#11832)
609
3e91a053
GM
6102012-07-12 Glenn Morris <rgm@gnu.org>
611
ba9e4b84
GM
612 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
613
614 * s/gnu-linux.h, s/hpux10-20.h:
615 Do not unconditionally define HAVE_XRMSETDATABASE.
616
3e91a053
GM
617 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
618
b300b1f4
PE
6192012-07-12 Paul Eggert <eggert@cs.ucla.edu>
620
621 Fix typos that broke OS X build.
622 Reported by Randal L. Schwartz in
623 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
624 * nsterm.m (ns_timeout): Add missing local decl.
625 (ns_get_color): snprintf -> sprintf, to fix typo.
626
6e777848
GM
6272012-07-12 Glenn Morris <rgm@gnu.org>
628
3f922c37
GM
629 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
630 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
631 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
632 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
633
0ab7b23a
GM
634 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
635 Move PTY_OPEN to configure.
636
6e777848
GM
637 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
638 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
639 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
640
4a7edc24
DA
6412012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
642
643 Use empty_unibyte_string where applicable.
644 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
645 * lread.c (read1): Likewise.
646 * xsettings.c (syms_of_xsettings): Likewise.
647
308aab79
GM
6482012-07-12 Glenn Morris <rgm@gnu.org>
649
42bd1719
GM
650 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
651 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
652 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
653 * s/hpux10-20.h (RUN_TIME_REMAP):
654 * s/bsd-common.h (TABDLY): Move to configure.
655
656 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
657
658 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
659
ea0bbd17 660 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 661 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
662
663 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 664
308aab79
GM
665 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
666 * s/template.h: Move NARROWPROTO to configure.
667
ee1cf5cf
GM
6682012-07-11 Glenn Morris <rgm@gnu.org>
669
30fe9bf4
GM
670 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
671 unused since 2011-01-17 change to systty.h.
672
ee1cf5cf
GM
673 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
674 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
675 Move HAVE_PTYS and HAVE_SOCKETS to configure.
676
63e47e07
PE
6772012-07-11 Paul Eggert <eggert@cs.ucla.edu>
678
679 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
680
c43fb4c3
GM
6812012-07-11 Glenn Morris <rgm@gnu.org>
682
683 * s/darwin.h, s/gnu-linux.h, s/template.h:
684 Move INTERRUPT_INPUT to configure.
685
e8df9267
DA
6862012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
687
688 Minor adjustments to interning code.
689 * lisp.h (intern, intern_c_string): Redefine as static inline
690 wrappers for intern_1 and intern_c_string_1, respectively.
691 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
692 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
693 Vobarray checking.
e8df9267
DA
694 * font.c (font_intern_prop): Likewise. Adjust comment.
695 * w32font.c (intern_font_name): Likewise.
696
34348bd4
AS
6972012-07-11 Andreas Schwab <schwab@linux-m68k.org>
698
d96a1e0c
AS
699 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
700
34348bd4
AS
701 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
702 of Fcar/Fcdr if possible.
703 * font.c (check_otf_features): Likewise.
704 * fontset.c (Fnew_fontset): Likewise.
705 * gnutls.c (Fgnutls_boot): Likewise.
706 * minibuf.c (read_minibuf): Likewise.
707 * msdos.c (IT_set_frame_parameters): Likewise.
708 * xmenu.c (Fx_popup_dialog): Likewise.
709 * w32menu.c (Fx_popup_dialog): Likewise.
710
c8add24e
GM
7112012-07-11 Glenn Morris <rgm@gnu.org>
712
4b575b3c
GM
713 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
714 since nothing has defined it on these platforms.
715
09f4e3b0
GM
716 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
717 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
718
172bedef
GM
719 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
720 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
721 Move CLASH_DETECTION to configure.
722
249685df
GM
723 * s/gnu.h: Remove file, which is now empty.
724
c8add24e
GM
725 * s/gnu.h, s/gnu-linux.h:
726 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
727
b41253a3
JW
7282012-07-11 John Wiegley <johnw@newartisans.com>
729
730 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
731 function attribute, so we only use it if it exists in the
732 compiler.
733
d923b542
DA
7342012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
735
736 Avoid call to strlen in fast_c_string_match_ignore_case.
737 * search.c (fast_c_string_match_ignore_case): Change to use
738 length argument. Adjust users accordingly.
739 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
740
5ebbef1d
PE
7412012-07-11 Paul Eggert <eggert@cs.ucla.edu>
742
bb352260
PE
743 Assume mkdir, rmdir.
744 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
745 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
746
57054ddd
PE
747 Assume rename.
748 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
749
b747d3f7
PE
750 Assume perror.
751 * s/hpux10-20.h (HAVE_PERROR): Remove.
752 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
753 Remove dummy definition, as this problem was obsolete long ago.
754
5ebbef1d
PE
755 Assume strerror.
756 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
757
984e7f30
DA
7582012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
759
760 Avoid calls to strlen in font processing functions.
761 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 762 (font_open_by_name): Change to use length argument. Adjust
984e7f30 763 users accordingly.
d923b542
DA
764 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
765 Adjust prototypes.
766 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
767 Change to return ptrdiff_t.
984e7f30
DA
768 (xfont_list_pattern, xfont_match): Use length returned by
769 xfont_decode_coding_xlfd.
770 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
771
20e94fdd
GM
7722012-07-11 Glenn Morris <rgm@gnu.org>
773
9d596af3
GM
774 * s/darwin.h, s/freebsd.h, s/netbsd.h:
775 Move DONT_REOPEN_PTY to configure.
776
20e94fdd
GM
777 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
778 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
779
e99a530f
PE
7802012-07-10 Paul Eggert <eggert@cs.ucla.edu>
781
22ffb973
PE
782 Remove "#define unix" that is no longer needed (Bug#11905).
783 * s/aix4-2.h (unix): Remove; no longer needed.
784
e9a9ae03
PE
785 EMACS_TIME simplification (Bug#11875).
786 This replaces macros (which typically do not work in GDB)
787 with functions, typedefs and enums, making the code easier to debug.
788 The functional style also makes code easier to read and maintain.
789 * systime.h: Include <sys/time.h> on all hosts, not just if
790 WINDOWSNT, since 'struct timeval' is needed in general.
791 (EMACS_TIME): Now a typedef, not a macro.
792 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
793 not macros.
794 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
795 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
796 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
797 (EMACS_TIME_LE): Now functions, not macros.
798 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
799 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
800 which are not functions. All uses rewritten to use:
801 (make_emacs_time): New function.
802 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
803 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
804 not functions. All uses rewritten to use the following, respectively:
805 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
806 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 807 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
808 * fileio.c (Fcopy_file):
809 * xterm.c (XTflash): Get the current time closer to when it's used.
810 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
811
ffacb126
PE
812 * bytecode.c (targets): Suppress -Woverride-init warnings.
813
e99a530f
PE
814 Simplify by avoiding confusing use of strncpy etc.
815 * doc.c (Fsnarf_documentation):
816 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
817 * frame.c (Fmake_terminal_frame):
818 * gtkutil.c (get_utf8_string):
819 * lread.c (openp):
820 * nsmenu.m (ns_update_menubar):
821 * regex.c (regerror):
822 Prefer memcpy to strncpy and strncat when either will do.
823 * fileio.c (Fsubstitute_in_file_name):
824 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
825 (menu_separator_name_p):
826 * nsmenu.m (ns_update_menubar):
827 Prefer memcmp to strncmp when either will do.
828 * nsterm.m: Include <ftoastr.h>.
829 (ns_get_color):
830 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
831 Prefer snprintf to strncpy.
832 * nsterm.m (ns_term_init):
833 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
834 * nsterm.m (ns_term_init):
835 Avoid the need for strncpy, by using build_string or
836 make_unibyte_string directly. Use dtoastr, not snprintf.
837 * process.c (Fmake_network_process): Diagnose service names that
838 are too long, rather than silently truncating them or creating
839 non-null-terminated names.
840 (Fnetwork_interface_info): Likewise, for interface names.
841 * sysdep.c (system_process_attributes) [GNU_LINUX]:
842 Prefer sprintf to strncat.
843 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
844 Prefer vsnprintf to vsprintf + strncpy.
845
c59592b3
GM
8462012-07-10 Glenn Morris <rgm@gnu.org>
847
848 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
849 Clarify fallback case.
850
7d7bbefd
DA
8512012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
852
853 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
854 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
855 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 856 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
857 where argument type is known to be a Lisp_Cons.
858
3a4c8000
TT
8592012-07-10 Tom Tromey <tromey@redhat.com>
860
861 * bytecode.c (BYTE_CODE_THREADED): New macro.
862 (BYTE_CODES): New macro. Replaces all old byte-code defines.
863 (enum byte_code_op): New type.
864 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
865 (exec_byte_code): Use them. Use token threading when applicable.
866
2a0213a6
DA
8672012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
868
869 Optimize pure C strings initialization.
870 * lisp.h (make_pure_string): Fix prototype.
871 (build_pure_c_string): New function, defined as static inline. This
872 provides a better opportunity to optimize away calls to strlen when
873 the function is called with compile-time constant argument.
874 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
875 argument, adjust users accordingly. Use build_pure_c_string where
876 appropriate.
877 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
878 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
879 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
880
cb1caeaf
DA
8812012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
882
883 Avoid calls to strlen in miscellaneous functions.
884 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
885 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
886 * lread.c (openp): Likewise.
887
c293e30c
DA
8882012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
889
890 Avoid calls to strlen in path processing functions.
891 * fileio.c (file_name_as_directory): Add comment. Change to add
892 srclen argument and return the length of result. Adjust users
893 accordingly.
894 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 895 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
896 users accordingly.
897 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
898
9e059e3f
GM
8992012-07-10 Glenn Morris <rgm@gnu.org>
900
d02eb359
GM
901 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
902 Move PENDING_OUTPUT_COUNT definition to configure.
903
882cf227
GM
904 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
905 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
906 * s/gnu.h (DATA_START): Move definitions to configure.
907
af6e839f
GM
908 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
909 We include usg5-4-common.h, which defines them both.
910
40289a12
GM
911 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
912 O_RDONLY already includes it).
913
9e059e3f
GM
914 Stop ns builds setting the EMACSLOADPATH environment variable.
915 * nsterm.m (ns_load_path): Rename from ns_init_paths.
916 Now it does not set EMACSLOADPATH, just returns the load-path string.
917 * nsterm.h: Update accordingly.
918 * lread.c [HAVE_NS]: Include nsterm.h.
919 (init_lread) [HAVE_NS]: Use ns_load_path.
920 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
921
7c4e8ec0
GM
9222012-07-09 Glenn Morris <rgm@gnu.org>
923
d4f600ff
GM
924 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
925 since the included bsd-common.h does so.
926
cbb31951
GM
927 Stop ns builds setting the EMACSPATH environment variable.
928 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
929 (ns_init_paths): Do not set EMACSPATH.
930 * nsterm.h (ns_exec_path): Add it.
931 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
932 Use ns_exec_path.
933
7c4e8ec0
GM
934 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
935
26bccfae
PE
9362012-07-09 Paul Eggert <eggert@cs.ucla.edu>
937
a0bee46f
PE
938 * process.c (wait_reading_process_output): 'waitchannels' was unset
939 when read_kbd || !NILP (wait_for_cell); fix this.
940
5994c183
PE
941 Add GCC-style 'const' attribute to functions that can use it.
942 * character.h (char_resolve_modifier_mask):
943 * keyboard.h (make_ctrl_char):
944 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
945 (init_character_once, next_almost_prime, init_fns, init_image)
946 (flush_pending_output, init_sound):
947 * mem-limits.h (start_of_data):
948 * menu.h (finish_menu_items):
949 Add ATTRIBUTE_CONST.
950 * emacs.c (DEFINE_DUMMY_FUNCTION):
951 Declare the dummy function with ATTRIBUTE_CONST.
952 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
953 Add decls with ATTRIBUTE_CONST.
954
26bccfae
PE
955 Minor improvements to make_formatted_string.
956 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
957 where int is good enough, as vsprintf returns an int.
958 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
959
a8290ec3
DA
9602012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
961
962 Use make_formatted_string to avoid double length calculation.
963 * lisp.h (make_formatted_string): New prototype.
964 * alloc.c (make_formatted_string): New function.
965 * buffer.c (Fgenerate_new_buffer_name): Use it.
966 * dbus.c (syms_of_dbusbind): Likewise.
967 * editfns.c (Fcurrent_time_zone): Likewise.
968 * filelock.c (get_boot_time): Likewise.
969 * frame.c (make_terminal_frame, set_term_frame_name)
970 (x_report_frame_params): Likewise.
971 * image.c (gs_load): Likewise.
972 * minibuf.c (get_minibuffer): Likewise.
973 * msdos.c (dos_set_window_size): Likewise.
974 * process.c (make_process): Likewise.
975 * xdisp.c (ensure_echo_area_buffers): Likewise.
976 * xsettings.c (apply_xft_settings): Likewise.
977
d01ba2f1
GM
9782012-07-09 Glenn Morris <rgm@gnu.org>
979
980 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
981 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
982 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
983 * nsterm.h (ns_etc_directory): Add it.
984 * callproc.c [HAVE_NS]: Include nsterm.h.
985 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
986
f1f924b6
DA
9872012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
988
989 Move marker debugging code under MARKER_DEBUG.
990 * marker.c (MARKER_DEBUG): Move marker debugging code under
991 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
992 for bootstrap with --enable-checking (~3x slowdown reported
993 by Juanma Barranquero <lekktu@gmail.com>).
994 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
995
ab531b66
PE
9962012-07-08 Paul Eggert <eggert@cs.ucla.edu>
997
998 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
999 See <http://bugs.gnu.org/11825#29>.
1000
c4b3bc8a
EZ
10012012-07-08 Eli Zaretskii <eliz@gnu.org>
1002
1003 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1004 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1005 (display_line): Add commentary about displaying truncation glyphs
1006 on GUI frames.
1007 (produce_special_glyphs): Move here from term.c.
1008
1009 * term.c (produce_special_glyphs): Move to xdisp.c.
1010
1011 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1012 section.
c4b3bc8a 1013
b676b881
AS
10142012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1015
f17c5273
AS
1016 * xdisp.c (display_line): Avoid warning about implicit declaration
1017 of FRAME_FONT.
1018
298819b9
AS
1019 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1020
b676b881
AS
1021 * lisp.h: Remove empty conditional.
1022
6045c4fd
PE
10232012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1024
b3350bf9
PE
1025 * lread.c (load_path_check): Now static.
1026
6045c4fd
PE
1027 Fix some minor --with-ns problems found by static checking.
1028 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1029 (x_set_font) [!HAVE_X_WINDOWS]:
1030 * image.c (xpm_load_image) [HAVE_NS]:
1031 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1032 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1033 Remove unused local.
1034 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1035 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1036 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1037 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1038 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1039 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1040 Fix pointer signedness problem.
1041 * xfaces.c (FRAME_X_FONT_TABLE):
1042 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1043
929e7845
GM
10442012-07-07 Glenn Morris <rgm@gnu.org>
1045
1046 * lread.c (load_path_check): New function, split from init_lread.
1047 (init_lread): Reorganize. Motivation:
1048 If EMACSLOADPATH is set, check/warn about that rather than the
1049 defaults, which we are not going to use. Hence we can remove
1050 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1051 Don't warn if site-lisp directories are missing.
1052 If not installed, start from a blank load-path, since
1053 PATH_LOADSEARCH refers to the eventual installation directories.
1054
58dd0aa4
EZ
10552012-07-07 Eli Zaretskii <eliz@gnu.org>
1056
1057 Support truncation and continuation glyphs on GUI frames, when
1058 fringes are disabled. (Bug#11832)
1059 * xdisp.c (init_iterator): Get dimensions of truncation and
1060 continuation glyphs even if on GUI frames. Adjust
1061 it->last_visible_x on GUI frames when the left or right fringes,
1062 or both, are absent.
1063 (start_display, move_it_in_display_line_to): Handle the case of a
1064 GUI frame without a fringe to display continuation or truncation
1065 glyphs.
1066 (insert_left_trunc_glyphs): Support GUI frames: make sure
1067 truncation glyphs overwrite enough glyphs from the current line to
1068 have sufficient space in pixels.
1069 (display_line): Support truncation and continuation glyphs on GUI
1070 frames. If some spare pixels are left on the line after inserting
1071 the truncation glyphs, fill that space with a stretch glyph of a
1072 suitably computed width.
1073
1074 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1075 produce_glyphs, to support GUI sessions.
1076
31571fd7
PE
10772012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1078
5a16b9bc
PE
1079 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1080
f3047c75
PE
1081 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1082
31571fd7
PE
1083 Do not require float-time's arg to fit in time_t (Bug#11825).
1084 This works better on hosts where time_t is unsigned, and where
1085 float-time is applied to the (negative) difference between two times.
1086 * editfns.c (decode_time_components): Last arg is now double *,
1087 not int *, and means to store all the result as a double, without
1088 worrying about whether the seconds part fits in time_t.
1089 All callers changed.
1090 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1091 All callers changed.
1092 (Ffloat_time): Do not fail merely because the specified time falls
1093 outside of time_t range.
1094
4516fbef
GM
10952012-07-07 Glenn Morris <rgm@gnu.org>
1096
1097 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1098 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1099 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1100
07adc2c6
JB
11012012-07-07 Juanma Barranquero <lekktu@gmail.com>
1102
1103 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1104 Update dependencies.
1105
1106 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1107
fd573f31
PE
11082012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1109
fee5959d
PE
1110 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1111 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1112 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1113 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1114 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1115 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1116
fd573f31
PE
1117 * xfont.c (compare_font_names): Redo to omit the need for casts.
1118
ddadbc0e
AS
11192012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1120
fca8d6b6
AS
1121 * xfns.c (Fx_change_window_property): Doc fix.
1122 * w32fns.c (Fx_change_window_property): Doc fix.
1123
ddadbc0e
AS
1124 * w32fns.c (Fx_window_property): Accept the same arguments as the
1125 X Windows version. Doc fix.
1126 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1127
ed9265fc 11282012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1129 Eli Zaretskii <eliz@gnu.org>
1130
1131 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1132 Windows-specific code from nt/config.nt moved here.
1133 Obsolete settings removed.
1134
216ee680
PE
11352012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1136
1137 * process.c: Avoid unnecessary calls to gettime.
1138 (wait_reading_process_output): Don't get the time of day
1139 when gobbling data immediately and not waiting, as there's no need
1140 for it in that case. This removes a FIXME.
1141
bdd091e4
JD
11422012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1143
1144 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1145 is defined (Bug#11768).
1146
9d44f8ce
DA
11472012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1148
1149 Fix marker debugging code.
1150 * marker.c (byte_char_debug_check): Do not perform the check
1151 if buffer is not multibyte.
090bd7cb
JB
1152 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1153 Call byte_char_debug_check with correct arguments.
9d44f8ce 1154
90fc4786
DA
11552012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1156
1157 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1158 * marker.c (byte_char_debug_check, count_markers):
1159 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1160 (byte_debug_flag): Remove.
1161 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1162 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1163
7b7ae965
DA
11642012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1165
4e57b342
DA
1166 Avoid code repetition in marker-related functions.
1167 * marker.c (attach_marker): New function.
1168 (Fset_marker, set_marker_restricted, set_marker_both)
1169 (set_marker_restricted_both): Use it.
1170 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1171 Consistently rename charno to charpos.
1172 (marker_position): Add eassert.
1173 (marker_byte_position): Convert to eassert.
1174
11752012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1176
1177 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1178 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1179 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1180
657924ff
DA
11812012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1182
1183 Introduce fast path for the widely used marker operation.
1184 * alloc.c (build_marker): New function.
1185 * lisp.h (build_marker): New prototype.
1186 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1187 * composite.c (autocmp_chars): Likewise.
1188 * editfns.c (buildmark): Remove.
1189 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1190 (save_restriction_save): Use build_marker.
1191 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1192 * window.c (save_window_save): Likewise.
1193
041a49a6
DA
11942012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1195
1196 Do not use Fdelete_overlay in delete_all_overlays
1197 to avoid redundant calls to unchain_overlay.
1198 * buffer.c (drop_overlay): New function.
1199 (delete_all_overlays, Fdelete_overlay): Use it.
1200 * minibuf.c (get_minibuffer): Fix comment.
1201
7dca65a4
PE
12022012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 Port to OpenBSD 5.1 amd64.
1205 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1206 This is needed for OpenBSD, and should be harmless on all BSD systems.
1207 Also, include <sys/sysctl.h>, as it should be available on all
1208 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1209 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1210 use p_pid member, not kp_proc.pid.
1211
8eb876e2
GM
12122012-07-06 Glenn Morris <rgm@gnu.org>
1213
1214 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1215
38182d90
PE
12162012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1217
1218 More xmalloc and related cleanup.
1219 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1220 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1221 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1222 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1223 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1224 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1225 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1226 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1227 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1228 * xterm.c:
1229 Omit needless casts involving void * pointers and allocation.
1230 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1231 as the former is more robust if P's type is changed.
1232 Prefer xzalloc to xmalloc + memset 0.
1233 Simplify malloc-or-realloc to realloc.
1234 Don't worry about xmalloc returning a null pointer.
1235 Prefer xstrdup to xmalloc + strcpy.
1236 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1237 growing it.
1238 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1239 alloca of a constant.
1240
6dd5a677
EZ
12412012-07-05 Eli Zaretskii <eliz@gnu.org>
1242
1243 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1244 hscroll is larger than the line width. Fixes long and futile
1245 looping inside extend_face_to_end_of_line (on a TTY) producing
1246 glyphs that are not needed and thrown away.
1247
6b312f0f
DA
12482012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1249
1250 * marker.c (set_marker_restricted_both): Simplify by using
1251 clip_to_bounds.
1252
f520ef9b
PE
12532012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1254
1255 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1256
383b7c95
JD
12572012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1258
1259 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1260 not defined (Bug#11768).
1261 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1262 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1263 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1264 followed by gtk_box_set_homogeneous (Bug#11768).
1265 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1266 (update_theme_scrollbar_width, xg_create_scroll_bar):
1267 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1268 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1269 (is_box_type): New function (Bug#11768).
1270 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1271 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1272 with default display (Bug#11768).
1273
d6e7bf45
EZ
12742012-07-05 Eli Zaretskii <eliz@gnu.org>
1275
1276 * xdisp.c (window_hscroll_limited): New function.
1277 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1278 coordinates when window's hscroll is set to insanely large
1279 values. (Bug#11857)
1280
431391ec
JB
12812012-07-05 Juanma Barranquero <lekktu@gmail.com>
1282
1283 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1284 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1285
23f86fce
DA
12862012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1287
1288 Cleanup xmalloc.
1289 * lisp.h (xzalloc): New prototype. Omit needless casts.
1290 * alloc.c (xzalloc): New function. Omit needless casts.
1291 * charset.c: Omit needless casts. Convert all calls to
1292 xmalloc with following memset to xzalloc.
1293 * dispnew.c: Likewise.
1294 * fringe.c: Likewise.
1295 * image.c: Likewise.
1296 * sound.c: Likewise.
1297 * term.c: Likewise.
1298 * w32fns.c: Likewise.
1299 * w32font.c: Likewise.
1300 * w32term.c: Likewise.
1301 * xfaces.c: Likewise.
1302 * xfns.c: Likewise.
1303 * xterm.c: Likewise.
1304 * atimer.c: Omit needless casts.
1305 * buffer.c: Likewise.
1306 * callproc.c: Likewise.
1307 * ccl.c: Likewise.
1308 * coding.c: Likewise.
1309 * composite.c: Likewise.
1310 * doc.c: Likewise.
1311 * doprnt.c: Likewise.
1312 * editfns.c: Likewise.
1313 * emacs.c: Likewise.
1314 * eval.c: Likewise.
1315 * filelock.c: Likewise.
1316 * fns.c: Likewise.
1317 * gtkutil.c: Likewise.
1318 * keyboard.c: Likewise.
1319 * lisp.h: Likewise.
1320 * lread.c: Likewise.
1321 * minibuf.c: Likewise.
1322 * msdos.c: Likewise.
1323 * print.c: Likewise.
1324 * process.c: Likewise.
1325 * region-cache.c: Likewise.
1326 * search.c: Likewise.
1327 * sysdep.c: Likewise.
1328 * termcap.c: Likewise.
1329 * terminal.c: Likewise.
1330 * tparam.c: Likewise.
1331 * w16select.c: Likewise.
1332 * w32.c: Likewise.
1333 * w32reg.c: Likewise.
1334 * w32select.c: Likewise.
1335 * w32uniscribe.c: Likewise.
1336 * widget.c: Likewise.
1337 * xdisp.c: Likewise.
1338 * xmenu.c: Likewise.
1339 * xrdb.c: Likewise.
1340 * xselect.c: Likewise.
1341
0497dc44
PE
13422012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1343
1344 * fileio.c (time_error_value): Check the right error number.
1345 Problem reported by Troels Nielsen in
1346 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1347
356e7178
PE
13482012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1349
4e71fd89
PE
1350 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1351 This should be fixed in a better way; see Eli Zaretskii in
1352 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1353 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1354
f0941253
PE
1355 * fileio.c (time_error_value): Rename from special_mtime.
1356 The old name's problems were noted by Eli Zaretskii in
1357 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1358
065c9eb4
PE
1359 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1360 This variable's comment says Emacs needs at least one GDB-visible
1361 symbol of type enum pvec_type, to work around GDB problems.
1362 The symbol's value doesn't matter.
1363
356e7178
PE
1364 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1365 that causes compilation to fail on pre-C99 compilers.
1366
ed9265fc 13672012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1368
1369 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1370 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1371
3884d954
DA
13722012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1373
d209e2fb 1374 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1375 headers for buffer_defaults and buffer_local_symbols.
1376 Reported by Juanma Barranquero <lekktu@gmail.com>.
1377
ee28be33
SM
13782012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1379
1380 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1381 * lisp.h (enum pvec_type): Use fewer bits.
1382 (PSEUDOVECTOR_SIZE_BITS): New constant.
1383 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1384 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1385 change in pvec_type.
1386 (PSEUDOVECTOR_TYPEP): New macro.
1387 (TYPED_PSEUDOVECTORP): Use it.
1388 * fns.c (internal_equal): Adapt code to extract pvectype.
1389 * emacs.c (gdb_pvec_type): Update type.
1390 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1391 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1392 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1393 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1394 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1395 abusing vector->header.next.nbytes.
1396 (live_vector_p): Use PVEC_TYPE.
1397 (mark_object): Adapt code to extract pvectype. Use switch.
1398
c7f2cd7f
PE
13992012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1400
1401 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1402 Tighten new eassert a bit.
1403
8ce70ed2
DA
14042012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1405
1406 Fix compilation with --enable-gcc-warnings and -O1
1407 optimization level.
1408 * doprnt.c (doprnt): Change type of tem to int, initialize
1409 to avoid compiler warning. Add eassert.
1410 * search.c (simple_search): Initialize match_byte to avoid
1411 compiler warning. Add eassert.
1412
dea7f1e5
PE
14132012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1414
24a212eb
PE
1415 Avoid weird behavior with large horizontal scrolls.
1416 Without this change, for example, large hscroll values would
1417 mess up Emacs's display on Fedora 15 x86, presumably due to
1418 overflows in int calculations in the display code.
1419 Also, if buffers had long lines, Emacs would freeze.
1420 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1421 (set_window_hscroll): New function, containing the old guts of
1422 Fset_window_hscroll. Return the clipped value.
1423 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1424 This avoids the need to check against PTRDIFF_MAX.
1425
dea7f1e5
PE
1426 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1427
76046526
DA
14282012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1429
1430 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1431
39adff0d
PE
14322012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1433
63807d47
PE
1434 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1435 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1436 since GCC 4.4.6 issues a bogus warning for them.
1437
39adff0d
PE
1438 Fix bugs in file timestamp newness comparisons.
1439 * fileio.c (Ffile_newer_than_file_p):
1440 * lread.c (Fload): Use full timestamp resolution of files,
1441 not just the 1-second resolution, so that files that are only
1442 slightly newer still count as newer.
1443 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1444 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1445
dbeed9a6
PE
14462012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1447
1448 * fileio.c: Improve handling of file time marker. (Bug#11852)
1449 (special_mtime): New function.
1450 (Finsert_file_contents, Fverify_visited_file_modtime):
1451 Use it to set special mtime values consistently.
1452
636334d6
AS
14532012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1454
1455 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1456 marker for non-existing file. (Bug#11852)
1457
e2017fe2
GM
14582012-07-03 Glenn Morris <rgm@gnu.org>
1459
1460 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1461 and did not make it into globals.h).
1462
404dbd37
TT
14632012-07-03 Tom Tromey <tromey@redhat.com>
1464
1465 * window.c (Fset_window_margins, Fset_window_fringes)
1466 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1467 * textprop.c (Fprevious_property_change): No longer static.
1468 * syntax.c (Fsyntax_table_p): No longer static.
1469 * process.c (Fget_process, Fprocess_datagram_address): No longer
1470 static.
1471 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1472 * keyboard.c (Fcommand_execute): No longer static.
1473 Remove EXFUN.
1474 * insdel.c (Fcombine_after_change_execute): No longer static.
1475 * image.c (Finit_image_library): No longer static.
1476 * fileio.c (Fmake_symbolic_link): No longer static.
1477 * eval.c (Ffetch_bytecode): No longer static.
1478 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1479 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1480 No longer static.
404dbd37
TT
1481 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1482 static.
1483 * dired.c (Ffile_attributes): No longer static.
1484 * composite.c (Fcomposition_get_gstring): No longer static.
1485 * callproc.c (Fgetenv_internal): No longer static.
1486
1487 * ccl.h: Remove EXFUNs.
1488 * buffer.h: Remove EXFUNs.
1489 * dispextern.h: Remove EXFUNs.
1490 * intervals.h: Remove EXFUNs.
1491 * fontset.h: Remove EXFUN.
1492 * font.h: Remove EXFUNs.
1493 * dosfns.c (system_process_attributes): Remove EXFUN.
1494 * keymap.h: Remove EXFUNs.
1495 * lisp.h: Remove EXFUNs.
1496 * w32term.h: Remove EXFUNs.
1497 * window.h: Remove EXFUNs.
1498 * xsettings.h: Remove EXFUN.
1499 * xterm.h: Remove EXFUN.
1500
8e4fd1e1
GM
15012012-07-03 Glenn Morris <rgm@gnu.org>
1502
1503 * lisp.h (Frandom): Make it visible to C.
1504 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1505 buffer for invisible buffers. (Bug#1229)
1506
ca95b3eb
DA
15072012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1508
1509 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1510 values which aren't power of 2.
1511 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1512 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1513 accordingly.
1514
7555c33f
SM
15152012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1516
1517 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1518
1519 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1520
d12e8f5a
DA
15212012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1522
1523 * alloc.c (allocate_vector_block): Remove redundant
1524 calls to mallopt if DOUG_LEA_MALLOC is defined.
1525 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1526 avoid calls to mallopt if zero_vector is returned.
1527
296094c3
DA
15282012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1529
1530 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1531 is enabled, avoid dereferencing NULL current_sblock if
1532 running undumped.
1533
36429c89
DA
15342012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1535
1536 Cleanup basic buffer management.
1537 * buffer.h (struct buffer): Change layout to use generic vector
1538 marking code. Fix some comments. Change type of 'clip_changed'
1539 to bitfield. Remove unused #ifndef old.
1540 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1541 (GET_OVERLAYS_AT): Fix indentation.
1542 (for_each_per_buffer_object_at): New macro.
1543 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1544 (Fbuffer_local_variables): Use it.
1545 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1546 * alloc.c (allocate_buffer): Adjust to match new layout of
1547 struct buffer. Fix comment.
1548 (mark_overlay): New function.
1549 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1550 Lisp area of struct buffer.
1551 (mark_object): Use it. Adjust marking of misc objects
1552 and related comments.
1553
3b3e4cac
PE
15542012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1555
1556 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1557 wrapper that is not needed because the wrapped code is a no-op (zero
1558 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1559 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1560
cf5c0175
DA
15612012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1562
1563 * alloc.c (mark_buffer): Simplify. Remove prototype.
1564 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1565 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1566 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1567 redundant calls to mark_vectorlike for bool vectors.
1568
ca26824c
GM
15692012-06-30 Glenn Morris <rgm@gnu.org>
1570
2e4c5312
GM
1571 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1572
ca26824c
GM
1573 * epaths.in (PATH_SITELOADSEARCH): New.
1574 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1575 This is rather than relying on --enable-locallisppath elements
1576 having "site-lisp" in their names. (Bug#10208#25, 11658)
1577
0d23c240
EZ
15782012-06-30 Eli Zaretskii <eliz@gnu.org>
1579
c9240d7a
EZ
1580 * w32proc.c (sys_select): Accept and ignore one more argument.
1581
1582 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1583
0d23c240 1584 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1585 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1586
1587 * sysdep.c: Don't include dos.h and dosfns.h.
1588
1589 * process.c (sys_select):
1590 * msdos.c (sys_select): Accept one more argument and ignore it.
1591
1592 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1593 adapt data types and code to that.
1594
1595 * dosfns.c:
1596 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1597 which clashes with the gnulib function of the same name.
1598
af5a5a98
AS
15992012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1600
c5e4379c
AS
1601 * font.c (font_style_to_value, font_style_symbolic)
1602 (font_prop_validate_style): Add type checks for values in
1603 font_style_table.
1604
af5a5a98
AS
1605 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1606 argument.
1607 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1608 uses.
1609
8d38f461
EZ
16102012-06-29 Eli Zaretskii <eliz@gnu.org>
1611
2e5a6631
EZ
1612 * xdisp.c (try_window_id): Undo last change.
1613
8d38f461
EZ
1614 * w32.c (getwd): Adjust commentary about startup_dir.
1615 (init_environment): Always call sys_access, even in non-MSVC
1616 builds. Don't chdir to the directory of the Emacs executable.
1617 This undoes code from 1997 which was justified by the need to
1618 "avoid conflicts when removing and renaming directories". But its
1619 downside was that every relative file name was being interpreted
1620 relative to the directory of the Emacs executable, which can never
1621 be TRT. In particular, it broke sys_access when called with
1622 relative file names.
1623 (sys_access): Map GetLastError to errno.
1624
2af3565e
DA
16252012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1626
1627 * window.h (struct window): Change type of 'fringes_outside_margins'
1628 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1629 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1630 Adjust comment.
1631 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1632 to ptrdiff_t.
1633
c8d3a25c 16342012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1635
c8d3a25c
GM
1636 * gnutls.c (emacs_gnutls_handshake):
1637 Add QUIT to make the loop interruptible.
57570cd3 1638
c8d3a25c 16392012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1640
c8d3a25c
GM
1641 * charset.c (init_charset): Make lack of etc/charsets fatal.
1642
3e984ee8
DA
16432012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1644
1645 * editfns.c (region_limit): Fix type mismatch.
1646
ef884f23
DA
16472012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1648
1649 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1650 undefined. Convert from xassert to eassert.
1651 * nsmenu.m: Convert from xassert to eassert.
1652 * nsterm.m: Likewise.
1653
7d7e0027
SM
16542012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1655
1656 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1657
aa754e6a
PE
16582012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1659
1660 Avoid integer overflow on scroll-left and scroll-right.
1661 * window.c (HSCROLL_MAX): New macro.
1662 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1663 overflow when requested scroll falls outside ptrdiff_t range.
1664
80b00b08
DA
16652012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1666
1667 * window.h (struct window): Change type of 'hscroll',
1668 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1669 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1670 Adjust users accordingly.
1671 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1672 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1673 from EMACS_INT to ptrdiff_t.
1674 (make_window): Omit redundant initialization.
1675
62b2bcf6
JB
16762012-06-28 Juanma Barranquero <lekktu@gmail.com>
1677
1678 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1679
45942c7d
DA
16802012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1681
1682 * window.h (struct window): Change type of 'use_time' and
1683 'sequence_number' from Lisp_Object to int.
1684 * frame.c (make_frame): Adjust users accordingly.
1685 * print.c (print_object): Likewise.
1686 * window.c (select_window, Fwindow_use_time, make_parent_window)
1687 (make_window): Likewise.
1688
e509cfa6
DA
16892012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1690
1691 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1692 enabled with --enable-checking=[all,glyphs] configure option.
1693 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1694 adjust comments accordingly.
1695 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1696 undefined, adjust comments accordingly.
1697 * image.c: Likewise.
1698 * scroll.c: Likewise.
1699 * w32fns.c: Likewise.
1700 * w32term.c: Likewise.
1701 * xdisp.c: Likewise.
1702 * xfaces.c: Likewise.
1703 * xfns.c: Likewise.
1704 * xterm.c: Likewise.
1705
a54e2c05
DA
17062012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1707
1708 Generalize run-time debugging checks.
1709 * dispextern.h (XASSERTS): Remove.
1710 * fontset.c (xassert): Remove.
1711 Convert from xassert to eassert.
1712 * alloc.c: Convert from xassert to eassert.
1713 * bidi.c: Likewise.
1714 * dispnew.c: Likewise.
1715 * fns.c: Likewise.
1716 * fringe.c: Likewise.
1717 * ftfont.c: Likewise.
1718 * gtkutil.c: Likewise.
1719 * image.c: Likewise.
1720 * keyboard.c: Likewise.
1721 * menu.c: Likewise.
1722 * process.c: Likewise.
1723 * scroll.c: Likewise.
1724 * sound.c: Likewise.
1725 * term.c: Likewise.
1726 * w32console.c: Likewise.
1727 * w32fns.c: Likewise.
1728 * w32term.c: Likewise.
1729 * window.c: Likewise.
1730 * xdisp.c: Likewise.
1731 * xfaces.c: Likewise.
1732 * xfns.c: Likewise.
1733 * xselect.c: Likewise.
1734 * xterm.c: Likewise.
1735
1ec4b7b2
SM
17362012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1737
1738 * fns.c (maybe_resize_hash_table): Output message when growing the
1739 purify-hashtable.
1740
2014308a
DA
17412012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1742
1743 * alloc.c (allocate_string_data): Remove dead code.
1744 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1745 avoid GCC warning about unused macro.
1746
246155eb
DA
17472012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1748
1749 * alloc.c (allocate_string): Omit intervals initialization.
1750 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1751 as in make_pure_string and make_pure_c_string.
1752
43184b7b
DA
17532012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1754
d209e2fb 1755 * alloc.c (allocate_string): Fix last change.
43184b7b 1756
3fe6dd74
DA
17572012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1758
d209e2fb 1759 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1760 to memset, add explicit initialization where appropriate.
1761
1ba6038a
GM
17622012-06-27 Glenn Morris <rgm@gnu.org>
1763
1764 * lisp.mk (lisp): Remove paths.elc.
1765
c89926a5
CY
17662012-06-27 Chong Yidong <cyd@gnu.org>
1767
1768 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1769
ed6b3510
JW
17702012-06-26 John Wiegley <johnw@newartisans.com>
1771
1ec4b7b2 1772 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1773 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1774
ed6b3510
JW
1775 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1776 when building with Clang.
1777
8edd4a2b
SM
17782012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1779
1780 * eval.c (Fapply): Allow calling it with a single argument.
1781
f6f62d1b
EZ
17822012-06-26 Eli Zaretskii <eliz@gnu.org>
1783
1784 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1785 _stricmp and _strnicmp.
1786 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1787
62efea5e
DA
17882012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1789
1790 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1791 allocated window.
1792 (allocate_process): Likewise for new process.
8edd4a2b 1793 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1794 (allocate_frame): Likewise.
1795 * frame.c (make_frame): Omit redundant initialization.
1796 * window.c (make_parent_window): Use memset.
1797 (make_window): Omit redundant initialization.
1798 * process.c (make_process): Omit redundant initialization.
1799 * terminal.c (create_terminal): Likewise.
1800
42997f4d
DA
18012012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1802
1803 * term.c (delete_tty): Remove redundant call to memset.
1804
1130ecfc
DA
18052012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1806
1807 * alloc.c: Remove build_string.
1808 * lisp.h: Define build_string as static inline. This provides
1809 a better opportunity to optimize away calls to strlen when the
1810 function is called with compile-time constant argument.
1811 * image.c (imagemagick_error): Convert to build_string.
1812 * w32proc.c (sys_spawnve): Likewise.
1813 * xterm.c (x_term_init): Likewise.
1814
cf38a720
PE
18152012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1816
99027bdd
PE
1817 Use sprintf return value instead of invoking strlen on result.
1818 In the old days this wasn't portable, since some sprintf
1819 implementations returned char *. But they died out years ago and
1820 Emacs already assumes sprintf returns int.
1821 Similarly for float_to_string.
1822 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1823 * ccl.c (ccl_driver):
1824 * character.c (string_escape_byte8):
1825 * data.c (Fnumber_to_string):
1826 * doprnt.c (doprnt):
1827 * print.c (print_object):
1828 * xdisp.c (message_dolog):
1829 * xfns.c (syms_of_xfns):
1830 Use sprintf or float_to_string result to avoid need to call strlen.
1831 * data.c (Fnumber_to_string):
1832 Use make_unibyte_string, since the string must be ASCII.
1833 * lisp.h, print.c (float_to_string): Now returns int length.
1834 * term.c (produce_glyphless_glyph):
1835 Use sprintf result rather than recomputing it.
1836
cf38a720
PE
1837 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1838 * Makefile.in (ALL_CFLAGS):
1839 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1840 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1841
3511c784
DA
18422012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1843
0a08eb21 1844 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1845 strcasecmp if available.
1846 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1847
fb7da12e
AS
18482012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1849
1850 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1851 Avoid comma operator.
1852 * menu.c (push_submenu_start, push_submenu_end)
1853 (push_left_right_boundary, push_menu_pane): Likewise.
1854 * msdos.c (dos_rawgetc): Likewise.
1855
afa2ffd8
DA
18562012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1857
1858 * xfns.c (xic_create_fontsetname): Remove redundant calls
1859 to memset.
1860
b3b4476b
PE
18612012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1862
4495ff38
PE
1863 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1864 sprintf already null-terminates its output.
1865
b3b4476b
PE
1866 * xfns.c (x_window): Remove redundant cast.
1867
b00876c9
DA
18682012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1869
1870 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1871 `const char *' to `char *' to avoid compiler warning.
1872
d188e26b
PE
18732012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1874
885d1d74
PE
1875 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1876 instead of truncating it to 63 (admittedly a generous limit).
1877
d188e26b
PE
1878 * process.c: Fix spelling and caps in comments.
1879
e2f560b1
DN
18802012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1881
e86db54b 1882 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1883 * sysdep.c (setpgrp): Remove definition, not used in this file.
1884
7583a3a1
JB
18852012-06-24 Juanma Barranquero <lekktu@gmail.com>
1886
1887 * makefile.w32-in: Update dependencies.
1888
696056c2
EZ
18892012-06-24 Eli Zaretskii <eliz@gnu.org>
1890
1891 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1892 (SYSTIME_H): Add nt/inc/sys/time.h.
1893
1894 * systime.h [WINDOWSNT]: Include sys/time.h.
1895
1896 * s/ms-w32.h (struct timespec): Definition moved from
1897 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1898
845ca893
PE
18992012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1900
1901 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1902 * buffer.h (buffer_slot_type_mismatch):
1903 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1904 * eval.c (unwind_to_catch):
1905 * image.c (my_png_error, my_error_exit):
1906 * keyboard.c (quit_throw_to_read_char, user_error)
1907 (Fexit_recursive_edit, Fabort_recursive_edit):
1908 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1909 (wrong_type_argument, buffer_overflow, __executable_start)
1910 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1911 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1912 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1913 (fatal):
1914 (child_setup) [!DOS_NT]:
1915 * lread.c (end_of_file_error, invalid_syntax):
1916 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1917 * puresize.h (pure_write_error):
1918 * search.c (matcher_overflow):
1919 * sound.c (sound_perror, alsa_sound_perror):
1920 * sysdep.c, syssignal.h (croak):
1921 * term.c (maybe_fatal, vfatal):
1922 * textprop.c (text_read_only):
1923 * undo.c (user_error):
1924 * unexmacosx.c (unexec_error):
1925 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1926 Use _Noreturn rather than NO_RETURN.
1927 No need for separate decl merely because of _Noreturn.
1928 * sound.c (sound_warning, parse_sound):
1929 Remove unnecessary forward decls.
1930
f1dd8073
PE
19312012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1932
1933 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1934 * lisp.h (WAIT_READING_MAX): New macro.
1935 * dispnew.c (Fsleep_for, sit_for):
1936 * keyboard.c (kbd_buffer_get_event):
1937 * process.c (Faccept_process_output):
1938 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1939 This improves on the previous patch, which introduced a bug
1940 when time_t is unsigned and as wide as intmax_t.
1941 See <http://bugs.gnu.org/9000#51>.
1942
b82c1755
EZ
19432012-06-23 Eli Zaretskii <eliz@gnu.org>
1944
1945 * dispnew.c (sit_for, Fsleep_for):
1946 * keyboard.c (kbd_buffer_get_event):
1947 * process.c (Faccept_process_output): Avoid compiler warnings when
1948 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1949
ca300656
JB
19502012-06-23 Juanma Barranquero <lekktu@gmail.com>
1951
049ec95b
JB
1952 * makefile.w32-in: Update dependencies.
1953
ca300656
JB
1954 * w32.c (ltime): Add return type and declare static.
1955 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1956
db7b8d06
PE
19572012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1958
1959 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1960 Privately reported by Herbert J. Skuhra.
1961 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1962 All uses changed.
1963 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1964 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1965
0bd8297f
EZ
19662012-06-23 Eli Zaretskii <eliz@gnu.org>
1967
96512555
EZ
1968 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1969 last argument of make_unibyte_string.
1970
0bd8297f
EZ
1971 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1972 language ID in the event parameters.
1973
1974 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1975 event.code, not the obscure "character set ID".
1976
63def6b6
CY
19772012-06-23 Chong Yidong <cyd@gnu.org>
1978
1979 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1980
e8a02204
EZ
19812012-06-23 Eli Zaretskii <eliz@gnu.org>
1982
388cdec0
EZ
1983 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1984 * w32.c (fdutimens): New function.
1985
1986 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1987
1988 * s/ms-w32.h (pselect): Redirect to sys_select.
1989
1990 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1991
e8a02204
EZ
1992 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1993 in the logic of incrementing and decrementing the value of
1994 use_relocatable_buffers.
1995
d054f3fb
PE
19962012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1997
1998 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1999 Privately reported by Herbert J. Skuhra.
2000 [__FreeBSD__]: Remove "*/" typo after "#include".
2001 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2002 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2003 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2004 Don't assume EMACS_TIME and struct timeval are the same type.
2005
d35af63c
PE
20062012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2007
2008 Support higher-resolution time stamps (Bug#9000).
2009 The time stamps are only nanosecond-resolution at the C level,
2010 since that's the best that any real-world system supports now.
2011 But they are picosecond-resolution at the Lisp level, as that's
2012 easy, and leaves room for future OS improvements.
2013
2014 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2015 (LIBES): Use it.
2016
2017 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2018 Don't get current time unless it's needed.
2019
2020 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2021 now provides it if it's absent.
2022 (start_atimer): Port to higher-res time stamps.
2023 Check for time stamp overflow. Don't get current time more
2024 often than is needed.
2025
2026 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2027 Include systime.h, not time.h.
2028 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2029
2030 * dired.c: Include stat-time.h.
2031 (Ffile-attributes): File times now have higher resolution.
2032
2033 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2034 (struct image): Timestamp now has higher resolution.
2035
2036 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2037 has at least microseconds now. All uses removed.
2038 (update_frame, update_single_window, update_window, update_frame_1)
2039 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2040
2041 * editfns.c (time_overflow): Now extern.
2042 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2043 (float-time, Fformat_time_string, Fcurrent_time_string)
2044 (Fcurrent_time_zone): Accept and generate higher-resolution
2045 time stamps.
2046 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2047 (decode_time_components, lisp_seconds_argument): New functions.
2048 (make_time): Now static.
2049 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2050 Report an error if the time is invalid, rather than having the caller
2051 do that.
2052
2053 * fileio.c: Include <stat-time.h>
2054 (Fcopy_file): Copy higher-resolution time stamps.
2055 Prefer to set the time stamp via a file descriptor if that works.
2056 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2057 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2058 (Fvisited_file_modtime, Fset_visited_file_modtime):
2059 Support higher-resolution time stamps.
2060
2061 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2062
2063 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2064
2065 * image.c (prepare_image_for_display, clear_image_cache)
2066 (lookup_image): Port to higer-resolution time stamps.
2067
2068 * keyboard.c (start_polling, bind_polling_period):
2069 Check for time stamp overflow.
2070 (read_char, kbd_buffer_get_event, timer_start_idle)
2071 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2072 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2073 Port to higher-resolution time stamps. Do not assume time_t is signed.
2074 (decode_timer): New function. Timers are now vectors of length 9,
2075 not 8, to accommodate the picosecond component.
2076 (timer_check_2): Use it.
2077
2078 * nsterm.m (select_timeout, timeval_subtract): Remove.
2079 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2080 as they're a bit more accurate and handle overflow better.
2081 (ns_select): Change prototype to be compatible with pselect.
2082 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2083 * nsterm.h (ns_select): Adjust prototype.
2084
2085 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2086 us-resolution time stamps.
2087 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2088
2089 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2090
2091 * lisp.h (time_overflow): New decl.
2092 (wait_reading_process_output): First arg is now intmax_t, not int,
2093 to accommodate larger waits.
2094
2095 * process.h (struct Lisp_Process.read_output_delay):
2096 Now counts nanoseconds, not microseconds.
2097 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2098 EMACS_HAS_USECS.
2099 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2100 (wait_reading_process_output):
2101 Port to ns-resolution time stamps.
2102 (Faccept_process_output, wait_reading_process_output):
2103 Check for time stamp overflow. Do not assume time_t is signed.
2104 (select_wrapper): Remove; we now use pselect.
2105 (Fprocess_attributes): Now generates ns-resolution time stamps.
2106
2107 * sysdep.c: Include utimens.h. Don't include utime.h
2108 or worry about struct utimbuf; gnulib does that for us now.
2109 (gettimeofday): Remove; gnulib provides a substitute.
2110 (make_timeval): New function.
2111 (set_file_times): Now sets ns-resolution time stamps.
2112 New arg FD; all uses changed.
2113 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2114 (system_process_attributes):
2115 Now returns ns-resolution time stamp. All uses changed.
2116 Check for time stamp overflow.
2117
2118 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2119 provides a substitute now.
2120
2121 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2122 since it guarantees struct timespec.
2123 (EMACS_TIME): Now struct timespec, so that we can support
2124 ns-resolution time stamps.
2125 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2126 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2127 (EMACS_USECS): Remove.
2128 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2129 so multiply the arg by 1000 before storing it.
2130 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2131 New macros.
2132 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2133 Port to ns-resolution time stamps.
2134 (EMACS_TIME_NEG_P): Remove; replaced by....
2135 (EMACS_TIME_SIGN): New macro.
2136 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2137 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2138 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2139 (make_timeval, make_lisp_time, decode_time_components): New decls.
2140 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2141 that it mishandled time_t overflow. You can't compare by subtracting!
2142 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2143 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2144
2145 * term.c: Include <sys/time.h>.
2146 (timeval_to_Time): New function, for proper overflow wraparound.
2147 (term_mouse_position, term_mouse_click): Use it.
2148
2149 * undo.c (record_first_change): Support higher-resolution time stamps
2150 in the undo buffer.
2151 (Fprimitive_undo): Use them when restoring time stamps.
2152
2153 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2154 (w32_get_internal_run_time):
2155 Port to higher-resolution Emacs time stamps.
2156 (ltime): Now accepts single 64-bit integer, as that's more convenient
2157 for callers.
2158
2159 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2160
2161 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2162 for compatibility with pselect. Support ns-resolution time stamps.
2163
2164 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2165
2166 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2167 Check for time stamp overflow, and support ns-resolution time stamps.
2168
2169 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2170 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2171 (timeval_subtract): Remove; no longer needed.
2172 (XTflash, XTring_bell, x_wait_for_event):
2173 Port to ns-resolution time stamps. Don't assume time_t is signed.
2174
b6a92dfe
CY
21752012-06-22 Chong Yidong <cyd@gnu.org>
2176
2177 * xdisp.c (x_consider_frame_title): Revert last change.
2178
d251c37c
EZ
21792012-06-22 Eli Zaretskii <eliz@gnu.org>
2180
2181 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2182 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2183 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2184 staticidx goes up to 1597 out of 1600 = 0x640.)
2185
f10deafb
PE
21862012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2187
2188 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2189 Otherwise, the umask might be mistakenly 0 while handling input signals.
2190
ec6de1e2
SM
21912012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2192
2193 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2194
28be1ada
DA
21952012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2196
2197 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2198 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2199 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2200 access to `contents' member of Lisp_Vector objects with AREF and ASET
2201 where appropriate.
2202
c6bf3022
CY
22032012-06-19 Chong Yidong <cyd@gnu.org>
2204
2205 * frame.c (delete_frame): When selecting a frame on a different
2206 text terminal, do not alter the terminal's top-frame.
2207
2208 * xdisp.c (format_mode_line_unwind_data): Record the target
2209 frame's selected window and its terminal's top-frame.
2210 (unwind_format_mode_line): Restore them.
2211 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2212 Callers changed.
2213 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2214 since tty frames can be explicitly named.
2215 (prepare_menu_bars): Likewise.
2216
2217 * term.c (Ftty_top_frame): New function.
2218
defd4196
PE
22192012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2220
2221 Port byte-code-meter to modern targets.
2222 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2223 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2224 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2225 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2226 (METER_1, METER_2): Simplify.
2227
1053a871
SM
22282012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2229
2230 * data.c (Fdefalias): Return `symbol' (bug#11686).
2231
b7e8d081
MR
22322012-06-18 Martin Rudalics <rudalics@gmx.at>
2233
2234 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2235 gets killed during executing of this function (Bug#11665).
2236 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2237 (Vkill_buffer_query_functions): In doc-string say that functions
2238 run by this hook should not change the current buffer.
2239
7ea2b339
PE
22402012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2241
2242 Fix recently-introduced process.c problems found by static checking.
2243 * process.c (write_queue_push, write_queue_pop, send_process):
2244 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2245 (write_queue_pop): Fix pointer signedness problem.
2246 (send_process): Remove unused local.
2247
96a313a1
CY
22482012-06-17 Chong Yidong <cyd@gnu.org>
2249
2250 * xdisp.c (redisplay_internal): No need to redisplay terminal
2251 frames that are not on top.
2252
20ca2e94
TN
22532012-06-17 Troels Nielsen <bn.troels@gmail.com>
2254
2255 * process.c (make_process): Initialize write_queue.
2256 (write_queue_push, write_queue_pop): New functions.
2257 (send_process): Use them to maintain correct ordering of process
2258 writes (Bug#10815).
2259
9a900ca9
PE
22602012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2261
310fbfa8
PE
2262 * lisp.h (eassert): Assume C89 or later.
2263 This removes the need for CHECK.
2264 (CHECK): Remove. Its comments about always evaluating its
2265 argument were confusing, as 'eassert' typically does not evaluate
2266 its argument.
2267
27bb1ca4
PE
2268 * coding.c (produce_chars): Use ptrdiff_t, not int.
2269
9a900ca9
PE
2270 * xterm.c (x_draw_underwave): Check for integer overflow.
2271 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2272
41b7f8bc 22732012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2274
2275 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2276 referenced (Bug#11583).
2277
9b0e3eba
AA
22782012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2279
2280 Implement wave-style variant of underlining.
2281 * dispextern.h (face_underline_type): New enum.
2282 (face): Add field for underline type.
2283 * nsterm.m (ns_draw_underwave): New function.
2284 (ns_draw_text_decoration): Use it.
2285 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2286 New functions.
2287 (x_draw_glyph_string): Use them.
2288 * xfaces.c (Qline, Qwave): New Lisp objects.
2289 (check_lface_attrs, merge_face_ref)
1053a871
SM
2290 (Finternal_set_lisp_face_attribute, realize_x_face):
2291 Handle wave-style underline face attributes.
9b0e3eba
AA
2292 * xterm.c (x_draw_underwave): New function.
2293 (x_draw_glyph_string): Use it.
2294
0fb52f11
JB
22952012-06-16 Juanma Barranquero <lekktu@gmail.com>
2296
2297 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2298 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2299 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2300 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2301 ($(BLD)/w32select.$(O)): Update dependencies.
2302
e5560ff7
AS
23032012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2304
2305 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2306 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2307 * character.c (_fetch_multibyte_char_p): Remove.
2308 * alloc.c: Include "character.h" before "buffer.h".
2309 * bidi.c: Likewise.
2310 * buffer.c: Likewise.
2311 * bytecode.c: Likewise.
2312 * callint.c: Likewise.
2313 * callproc.c: Likewise.
2314 * casefiddle.c: Likewise.
2315 * casetab.c: Likewise.
2316 * category.c: Likewise.
2317 * cmds.c: Likewise.
2318 * coding.c: Likewise.
2319 * composite.c: Likewise.
2320 * dired.c: Likewise.
2321 * dispnew.c: Likewise.
2322 * doc.c: Likewise.
2323 * dosfns.c: Likewise.
2324 * editfns.c: Likewise.
2325 * emacs.c: Likewise.
2326 * fileio.c: Likewise.
2327 * filelock.c: Likewise.
2328 * font.c: Likewise.
2329 * fontset.c: Likewise.
2330 * fringe.c: Likewise.
2331 * indent.c: Likewise.
2332 * insdel.c: Likewise.
2333 * intervals.c: Likewise.
2334 * keyboard.c: Likewise.
2335 * keymap.c: Likewise.
2336 * lread.c: Likewise.
2337 * macros.c: Likewise.
2338 * marker.c: Likewise.
2339 * minibuf.c: Likewise.
2340 * nsfns.m: Likewise.
2341 * nsmenu.m: Likewise.
2342 * print.c: Likewise.
2343 * process.c: Likewise.
2344 * regex.c: Likewise.
2345 * region-cache.c: Likewise.
2346 * search.c: Likewise.
2347 * syntax.c: Likewise.
2348 * term.c: Likewise.
2349 * textprop.c: Likewise.
2350 * undo.c: Likewise.
2351 * unexsol.c: Likewise.
2352 * w16select.c: Likewise.
2353 * w32fns.c: Likewise.
2354 * w32menu.c: Likewise.
2355 * window.c: Likewise.
2356 * xdisp.c: Likewise.
2357 * xfns.c: Likewise.
2358 * xmenu.c: Likewise.
2359 * xml.c: Likewise.
2360 * xselect.c: Likewise.
2361
2f07e6af
EZ
23622012-06-16 Eli Zaretskii <eliz@gnu.org>
2363
1053a871
SM
2364 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2365 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2366 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2367 row.
2368 (handle_face_prop): Use chunk-relative overlay string index when
2369 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2370 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2371 the rightmost. (Bug#11720)
2f07e6af 2372
29b83cec
AS
23732012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2374
2375 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2376 (CATEGORY_MEMBER): Enforce 1/0 value.
2377 * category.c (_temp_category_set): Remove.
2378
4c5501e9
EZ
23792012-06-16 Eli Zaretskii <eliz@gnu.org>
2380
2381 * window.c (Fdelete_other_windows_internal)
2382 (Fdelete_window_internal): Don't access frame's mouse highlight
2383 info of the initial frame. (Bug#11677)
2384
2b570124
PE
23852012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2386
e93864f9
PE
2387 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2388 Assume USE_2_TAGS_FOR_INTS.
2389 (xreload): Adjust $tagmask width to match recent lisp.h change.
2390
2b570124
PE
2391 Simplify lisp.h in minor ways that should not affect code.
2392 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2393 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2394 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2395 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2396 (INTTYPEBITS): New macro, for clarity.
2397 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2398 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2399 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2400 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2401 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2402
81755f69
JB
24032012-06-13 Juanma Barranquero <lekktu@gmail.com>
2404
2405 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2406
16192a57
GM
24072012-06-13 Glenn Morris <rgm@gnu.org>
2408
2409 * s/bsd-common.h (BSD4_3):
2410 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2411
646b5f55
AS
24122012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2413
2414 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2415 instead of union.
2416 (XLI, XIL): Define.
1053a871
SM
2417 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2418 Use them.
2419 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2420 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2421 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2422 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2423 * frame.c (delete_frame): Remove outdated comment.
2424 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2425 USE_LISP_UNION_TYPE.
2426 (Fw32_unregister_hot_key): Likewise.
2427 (Fw32_toggle_lock_key): Likewise.
2428 * w32menu.c (add_menu_item): Likewise.
2429 (w32_menu_display_help): Use XIL instead of checking
2430 USE_LISP_UNION_TYPE.
2431 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2432 (init_heap): Likewise.
2433 * w32term.c (w32_read_socket): Update comment.
2434
1d3823c9
GM
24352012-06-13 Glenn Morris <rgm@gnu.org>
2436
c62ff706
GM
2437 * s/usg5-4-common.h, src/s/unixware.h:
2438 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2439
1d3823c9
GM
2440 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2441
bfe3e0a2
PE
24422012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2443
2444 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2445 * alloc.c (make_number) [!defined make_number]:
2446 Remove, as lisp.h always defines this now.
2447 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2448 (roundup_size): Verify that it is a power of 2.
2449 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2450 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2451 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2452 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2453 USE_LSB_TAG now is always defined to be either 0 or 1.
2454 All uses changed.
2455 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2456 code works fine either way, and efficiency is not a concern here,
2457 as the union type is for debugging, not for production.
2458 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2459 Use an inline function on all platforms when using the union type,
2460 since this is simpler and 'static inline' can be used portably
2461 within Emacs now.
2462 (LISP_INITIALLY_ZERO): New macro.
2463 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2464 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2465
45fa9c0f
GM
24662012-06-12 Glenn Morris <rgm@gnu.org>
2467
b4492cba
GM
2468 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2469
2470 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2471
45fa9c0f
GM
2472 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2473 Move BROKEN_SIGIO to configure.
2474
2475 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2476 Move NO_TERMIO to configure.
2477
0e25d334
CY
24782012-06-12 Chong Yidong <cyd@gnu.org>
2479
2480 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2481 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2482 MagickExportImagePixels is undefined.
2483
43682bb6
PE
24842012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2485
2486 * image.c (imagemagick_load_image): Remove unused label.
2487
a9be7d2b
GM
24882012-06-11 Glenn Morris <rgm@gnu.org>
2489
2490 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2491 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2492 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2493 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2494
3017f87f
SM
24952012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2496
2497 * alloc.c (make_byte_code): New function.
2498 (Fmake_byte_code): Use it. Don't purify here.
2499 * lread.c (read1): Use it as well to avoid extra allocation.
2500
1b9b4cf4
CY
25012012-06-11 Chong Yidong <cyd@gnu.org>
2502
2503 * image.c (imagemagick_load_image): Implement transparency.
2504
95988fcf
AS
25052012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2506
2507 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2508 account for preceding backslashes. (Bug#11663)
2509
cd4eb164
CY
25102012-06-09 Chong Yidong <cyd@gnu.org>
2511
2512 * term.c: Support italics in capable terminals (Bug#9652).
2513 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2514 (turn_on_face): Output using TS_enter_italic_mode if available.
2515 Don't handle unused blinking and alt-charset cases.
2516 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2517 and tty_alt_charset_p cases.
2518 (tty_capable_p, init_tty): Support italics.
2519
2520 * termchar.h (struct tty_display_info): Add field for italics.
2521 Remove unused blink field.
2522
2523 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2524 Handle slant.
2525
2526 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2527 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2528 tty_alt_charset_p. Add tty_italic_p.
2529
ff88beb8
MA
25302012-06-09 Michael Albinus <michael.albinus@gmx.de>
2531
2532 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2533 dbus_type_is_basic if available.
2534 (xd_extract_signed, xd_extract_unsigned): Rename from
2535 extract_signed and extract_unsigned, respectively. Adapt callers.
2536
44286096
CY
25372012-06-09 Chong Yidong <cyd@gnu.org>
2538
1682701f
CY
2539 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2540
44286096
CY
2541 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2542 case (Bug#9752).
2543
d86feb17
PE
25442012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2545
2546 * xdisp.c (vmessage): Treat frame message as multibyte.
2547 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2548 would generate the diagnostic "Making \302\247 buffer-local while
2549 let-bound!".
2550
d5c20fe8
EZ
25512012-06-08 Eli Zaretskii <eliz@gnu.org>
2552
2553 * dispnew.c (showing_window_margins_p): Undo last change, which
2554 was done due to an inadvertent commit.
2555 (adjust_frame_glyphs_for_frame_redisplay): Do call
2556 showing_window_margins_p.
2557
513749ee
SM
25582012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2559
2560 * eval.c (Fmake_var_non_special): New primitive.
2561 (syms_of_eval): Defsubr it.
2562 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2563
d4a8f5c1
JB
25642012-06-08 Juanma Barranquero <lekktu@gmail.com>
2565
2566 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2567 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2568
8bbbc977
EZ
25692012-06-08 Eli Zaretskii <eliz@gnu.org>
2570
2571 * alloc.c (allocate_vectorlike): Fix last change.
2572
f3372c87
DA
25732012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2574
2575 Block-based vector allocation of small vectors.
2576 * lisp.h (struct vectorlike_header): New field `nbytes',
2577 adjust comment accordingly.
2578 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2579 to denote vector blocks. Adjust users (live_vector_p,
2580 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2581 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2582 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2583 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2584 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2585 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2586 (roundup_size): New constant.
2587 (struct vector_block): New data type.
2588 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2589 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2590 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2591 (sweep_vectors): New functions.
2592 (allocate_vectorlike): Return `zero_vector' as the only vector of
2593 0 items. Allocate new vector from block if vector size is less than
2594 or equal to VBLOCK_BYTES_MAX.
2595 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2596 (init_alloc_once): Add call to init_vectors.
2597
4f18a4ed
SM
25982012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2599
2600 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2601
86f158bc
PE
26022012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2603
2604 * doprnt.c (doprnt): Truncate multibyte char correctly.
2605 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2606 would mishandle a string argument "Xc" if X was a multibyte
2607 character of length 2: it would truncate after X's first byte
2608 rather than including all of X.
2609
c5cfcbe0
CY
26102012-06-06 Chong Yidong <cyd@gnu.org>
2611
2612 * buffer.c (word_wrap): Doc fix.
2613
c05cf390
PE
26142012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2615
2616 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2617
0c3461de
GM
26182012-06-03 Glenn Morris <rgm@gnu.org>
2619
2620 * xdisp.c (tool-bar-style): Doc fix.
2621
c71232db
UM
26222012-06-03 Ulrich Müller <ulm@gentoo.org>
2623
2624 * Makefile.in (PAXCTL): Define.
2625 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2626 binary via PaX flags if the paxctl utility is available.
2627 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2628 Restore PaX flags to their default. (Bug#11398)
2629
383f7350
CY
26302012-06-03 Chong Yidong <cyd@gnu.org>
2631
2632 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2633 buffer (Bug#11226).
2634
5f2c76c6
CY
26352012-06-03 Chong Yidong <cyd@gnu.org>
2636
2637 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2638 (note_mode_line_or_margin_highlight): If there is no help echo,
2639 use mode-line-default-help-echo. Handle the case where the mouse
2640 position is past the end of the mode line string.
2641
2642 * buffer.c (buffer_local_value_1): New function, split from
2643 Fbuffer_local_value; can return Qunbound.
2644 (Fbuffer_local_value): Use it.
2645 (Vmode_line_format): Docstring tweaks.
2646
773d47f6
PE
26472012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2648
2649 * sysdep.c (system_process_attributes): Improve comment.
2650
f2d6a3df
SM
26512012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2652
2653 * keyboard.c: Export real-this-command to Elisp.
2654 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2655 and DEFVAR it. Update all users.
2656
63810350
PE
26572012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2658
7bd5c1f4
PE
2659 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2660
63810350
PE
2661 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2662 Convert pctcpu and pctmem to Lisp float properly.
2663 Let the compiler fold better, as 100.0/0x8000 is exact.
2664
a2821611
AS
26652012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2666
2667 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2668 cons_block.
2669
5fceba1d
PE
26702012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2671
2672 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2673
c98ff5dd
DA
26742012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2675
2676 For a 'struct window', replace some Lisp_Object fields to
2677 bitfields where appropriate, remove unused fields.
2678 * window.h (struct window): Remove unused 'last_mark_x' and
2679 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2680 change it's type from Lisp_Object to bitfield.
2681 Change type of 'force_start', 'optional_new_start',
2682 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2683 fields from Lisp_Object to bitfield. Adjust users accordingly.
2684
ca34e0be
PE
26852012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2686
2687 Pacify gcc -Wdouble-precision when using Xaw.
2688 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2689 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2690 Use 'float' consistently, rather than 'float' in most places
2691 and 'double' in a couple of places.
2692
efc00ab1 26932012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2694
2695 * xdisp.c (handle_stop): Detect whether we have overlay strings
2696 loaded by testing it->current.overlay_string_index to be
2697 non-negative, instead of checking whether n_overlay_strings is
2698 positive. (Bug#11587)
2699
efc00ab1 27002012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2701
2702 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2703
2704 * doc.c (Fsubstitute_command_keys): Doc fix.
2705
efc00ab1 27062012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2707
2708 * search.c (search_buffer): Remove calls to
2709 r_alloc_inhibit_buffer_relocation, as it is now called by
2710 maybe_unify_char, which was the cause of relocation of buffer text
2711 in bug#11519.
2712
efc00ab1 27132012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2714
2715 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2716 for the duration of call to load_charset, to avoid problems with
2717 callers of maybe_unify_char that access buffer text through C
2718 pointers.
2719
2720 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2721 decrement the inhibition flag, instead of just setting or
2722 resetting it.
2723
ba93a187
PE
27242012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2725
2726 Remove obsolete '#define static' cruft.
2727 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2728 This #undef was "temporary" in 2000; it is no longer needed
2729 now that '#define static' has gone away.
2730 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2731 (gray_bitmap_bits): Remove; no longer needed.
2732 All uses replaced with definiens.
2733 * xterm.c: Include "bitmaps/gray.xbm".
2734
9e4bf381
PE
27352012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2736
2737 Clean up __executable_start, monstartup when --enable-profiling.
2738 The following changes affect the code only when profiling.
2739 * dispnew.c (__executable_start): Rename from safe_bcopy.
2740 Define only on platforms that need it.
2741 * emacs.c: Include <sys/gmon.h> when profiling.
2742 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2743 (__executable_start): Remove decl, since lisp.h does it now.
2744 (safe_bcopy): Remove decl; no longer has that name.
2745 (main): Coalesce #if into single bit of code, for simplicity.
2746 Cast pointers to uintptr_t, since standard libraries want integers
2747 and not pointers.
2748 * lisp.h (__executable_start): New decl.
2749
32d72c2f
GM
27502012-05-31 Glenn Morris <rgm@gnu.org>
2751
2752 * image.c (Fimagemagick_types): Doc fix.
2753
baac5bc7
JM
27542012-05-30 Jim Meyering <meyering@redhat.com>
2755
2756 * callproc.c (Fcall_process_region): Include directory component
2757 in mkstemp error message (Bug#11586).
2758
72cb32cf
PE
27592012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2760
2761 * alloc.c, lisp.h (make_pure_vector): Now static.
2762
61b108cc
SM
27632012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2764
2765 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2766 Move to byte-run.el.
2767 (Fautoload): Do the hash-doc more carefully.
2768 * data.c (Fdefalias): Purify definition, except for keymaps.
2769 (Qdefun): Move from eval.c.
2770 * lisp.h (Qdefun): Remove.
2771 * lread.c (read1): Tiny simplification.
2772
471fe23d
TN
27732012-05-29 Troels Nielsen <bn.troels@gmail.com>
2774
934f3f58 2775 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2776 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2777 Bug#9642, but explicitly check that the buffer the overlay would
2778 be moved to is live and rearrange lines to make sure that errors
2779 will not put the overlay in an inconsistent state.
2780 (Fdelete_overlay): Cosmetics.
2781
85d0efd1
EZ
27822012-05-28 Eli Zaretskii <eliz@gnu.org>
2783
2784 * w32term.c (my_bring_window_to_top): New function.
2785 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2786 could be different from the original one.
2787 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2788 (Bug#11513)
2789
2790 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2791 by calling BringWindowToTop.
2792
2793 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2794 (WM_EMACS_END): Increase by one.
2795
da92a98c
PE
27962012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2797
2798 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2799 This avoids undefined behavior that might cause the eassert
2800 to not catch an out-of-range value.
2801
74d1f848
JB
28022012-05-28 Juanma Barranquero <lekktu@gmail.com>
2803
2804 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2805 Update dependencies.
2806
9e1a06fc
EZ
28072012-05-27 Eli Zaretskii <eliz@gnu.org>
2808
2809 * bidi.c (bidi_mirror_char): Fix last change.
2810
f3dd7312
AS
28112012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2812
2813 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2814 when referring to sectname field in printf format.
2815
81899c91
PE
28162012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2817
57b81a9f
PE
2818 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2819 Only r_alloc_inhibit_buffer_relocation needed to be added;
2820 the others were already declared.
2821
81899c91
PE
2822 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2823 before checking whether it's out of range. Put the check inside
2824 eassert. See
2825 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2826
33017faf 28272012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2828
2829 * callproc.c (Fcall_process): Restore a line that was accidentally
2830 commented out in the 2011-02-13 change (bug#11547).
2831
33017faf 28322012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2833
2834 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2835 defined on ralloc.c.
2836
2837 * buffer.c [REL_ALLOC]: Remove prototypes of
2838 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2839 they are now on lisp.h.
2840
2841 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2842
2843 * search.c (search_buffer): Use it to inhibit relocation of buffer
2844 text while re_search_2 is doing its job, because re_search_2 is
2845 passed C pointers to buffer text. (Bug#11519)
2846
23415acf
EZ
2847 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2848 Update value to 24.
2849
44e27368
EZ
2850 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2851 state after an additional call to move_it_in_display_line_to, keep
2852 the values of it->max_ascent and it->max_descent found for the
2853 entire line.
2854 (pos_visible_p): Revert the comparison against bottom_y to what it
2855 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2856 (Bug#11464)
2857
c1892f11
PE
28582012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2859
2860 Fix coding-related core dumps with gcc -ftrapv.
2861 The code was computing A - B, where A and B are pointers, and B is
2862 random garbage. This can lead to core dumps on platforms that
2863 have special pointer registers, and it also leads to core dumps on
2864 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2865 A - B only when B is initialized properly.
2866 * coding.c (coding_set_source, coding_set_destination): Return void.
2867 (coding_change_source, coding_change_destinations): New functions,
2868 with the old behaviors of coding_set_source and coding_set_destination.
2869 All callers that need an offset changed to use these new functions.
2870
eb7afdad
GM
28712012-05-26 Glenn Morris <rgm@gnu.org>
2872
2873 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2874
f12fdf02
EZ
28752012-05-26 Eli Zaretskii <eliz@gnu.org>
2876
53a63be6 2877 Extend mouse support on W32 text-mode console.
61b108cc
SM
2878 * xdisp.c (draw_row_with_mouse_face):
2879 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2880
eb3f6f01 2881 * w32console.c: Include window.h.
61b108cc
SM
2882 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2883 New functions.
eb3f6f01
EZ
2884 (initialize_w32_display): Initialize mouse-highlight data.
2885
53a63be6
EZ
2886 * w32inevt.c: Include termchar.h and window.h.
2887 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2888 moves, call note_mouse_highlight. If help_echo changed, call
2889 gen_help_event to produce help-echo message in the echo area.
2890 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2891 highlight info.
2892
4cfd81f6
PE
28932012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2894
2895 * lread.c (read1): Simplify slightly to avoid an overflow warning
2896 with GCC 4.7.0 on x86-64.
2897
4446092a
EZ
28982012-05-26 Eli Zaretskii <eliz@gnu.org>
2899
2900 * bidi.c (bidi_mirror_char): Revert last change: an int is
2901 definitely wide enough here.
2902
42b2a986 29032012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2904
42b2a986 2905 Fix integer width and related bugs (Bug#9874).
eb106a49 2906 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2907 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2908 (string_bytes, check_sblock, allocate_string_data):
2909 (compact_small_strings, Fmake_bool_vector, make_string)
2910 (make_unibyte_string, make_multibyte_string)
2911 (make_string_from_bytes, make_specified_string)
2912 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2913 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2914 (mark_vectorlike):
2915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2916 (allocate_pseudovector):
2917 Use int, not EMACS_INT, where int is wide enough.
2918 (inhibit_garbage_collection, Fgarbage_collect):
2919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2920 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2921 int might not be wide enough.
2922 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2923 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2924 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2925 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2926 (bidi_level_of_next_char, bidi_move_to_visually_next):
2927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2928 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2929 (Fkill_buffer, Fset_buffer_major_mode)
2930 (advance_to_char_boundary, Fbuffer_swap_text)
2931 (Fset_buffer_multibyte, overlays_at, overlays_in)
2932 (overlay_touches_p, struct sortvec, record_overlay_string)
2933 (overlay_strings, recenter_overlay_lists)
2934 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2935 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2936 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2937 (Foverlay_recenter, last_overlay_modification_hooks_used)
2938 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2940 (validate_region): Omit unnecessary test for b <= e,
2941 since that's guaranteed by the previous test.
d311d28c
PE
2942 (adjust_overlays_for_delete): Avoid pos + length overflow.
2943 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2944 (report_overlay_modification):
2945 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2946 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2947 Omit pointer cast, which isn't needed anyway, and doesn't work
2948 after the EMACS_INT -> ptrdiff_t change.
02481186 2949 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2950 * buffer.h: Adjust decls to match defn changes elsewhere.
2951 (struct buffer_text, struct buffer):
2952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2953 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2954 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2955 not int, to avoid needless 32-bit limit on 64-bit hosts.
2956 (exec_byte_code): Use tighter memory-full test, one that checks
2957 for alloca overflow. Don't compute the address of the object just
2958 before an array, as that's not portable. Use EMACS_INT, not
2959 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2960 * callint.c (Fcall_interactively):
2961 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2962 * callproc.c (call_process_kill, Fcall_process):
2963 Don't assume pid_t fits into an Emacs fixnum.
2964 (call_process_cleanup, Fcall_process, child_setup):
2965 Don't assume pid_t fits into int.
2966 (call_process_cleanup, Fcall_process, delete_temp_file)
2967 (Fcall_process_region):
2968 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2969 (Fcall_process): Simplify handling of volatile integers.
2970 Use int, not EMACS_INT, where int will do.
2971 * casefiddle.c (casify_object, casify_region, operate_on_word)
2972 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2974 (casify_object): Avoid integer overflow when overallocating buffer.
2975 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2976 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2977 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2978 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2979 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2980 integers are now checked earlier. All uses replaced with XINT.
2981 (ccl_driver):
2982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2983 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2984 (ccl_driver, Fregister_code_conversion_map):
2985 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2986 (resolve_symbol_ccl_program): Check that vector header is in range.
2987 Always copy the vector, so that we can check its contents reliably
2988 now rather than having to recheck each instruction as it's being
2989 executed. Check that vector words fit in 'int'.
2990 (ccl_get_compiled_code, Fregister_ccl_program)
2991 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2992 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2993 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2994 contents are in range.
2995 (Fccl_execute_on_string): Check that status is in range.
2996 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2997 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2998 Accept and return EMACS_INT, not int, because callers can pass values
2999 out of 'int' range.
3000 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3001 (multibyte_chars_in_text, parse_str_as_multibyte)
3002 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3003 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3004 (string_escape_byte8, Fget_byte):
3005 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3006 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3007 avoid mishandling large integers.
3008 * character.h: Adjust decls to match defn changes elsewhere.
3009 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3010 (Ffind_charset_region):
3011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3012 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3013 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3014 Don't assume fixnum fits in int.
d311d28c
PE
3015 (load_charset_map_from_vector, Fmap_charset_chars):
3016 Remove now-unnecessary CHECK_NATNUMs.
3017 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3018 Don't rely on undefined behavior with signed left shift overflow.
3019 Don't assume unsigned int fits into fixnum, or that fixnum fits
3020 into unsigned int. Don't require max_code to be a valid fixnum;
3021 that's not true for gb10830 4-byte on a 32-bit host. Allow
3022 invalid_code to be a cons, for the same reason. Require code_offset
3023 to be a character. Avoid int overflow if max_char is close
3024 to INT_MAX.
3025 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3026 this is intended anyway and avoids some undefined behavior.
3027 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3028 INDEX_TO_CODE_POINT, as that's what it expects.
3029 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3030 * charset.h (DECODE_CHAR): Return int, not unsigned;
3031 this is what was intended anyway, and it avoids undefined behavior.
3032 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3033 integer-overflow issues.
3034 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3035 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3036 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3037 * chartab.c (Fmake_char_table, Fset_char_table_range)
3038 (uniprop_get_decoder, uniprop_get_encoder):
3039 Don't assume fixnum fits in int.
3040 * cmds.c (move_point): New function, that does the gist of
3041 Fforward_char and Fbackward_char, but does so while checking
3042 for integer overflow more accurately.
c96e5d6a 3043 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3044 (Fforward_line, Fend_of_line, internal_self_insert)
3045 (internal_self_insert):
3046 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3047 Fix a FIXME, by checking for integer overflow when calculating
3048 target_clm and actual_clm.
3049 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3050 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3051 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3052 (coding_alloc_by_making_gap, alloc_destination)
3053 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3054 (encode_coding_utf_16, detect_coding_emacs_mule)
3055 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3056 (detect_coding_iso_2022, decode_coding_iso_2022)
3057 (encode_invocation_designation, encode_designation_at_bol)
3058 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3059 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3060 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3061 (encode_coding_ccl, encode_coding_raw_text)
3062 (detect_coding_charset, decode_coding_charset)
3063 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3064 (produce_composition, produce_charset, produce_annotation)
3065 (decode_coding, handle_composition_annotation)
3066 (handle_charset_annotation, consume_chars, decode_coding_gap)
3067 (decode_coding_object, encode_coding_object, detect_coding_system)
3068 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3069 (code_convert_region, code_convert_string)
8f50130c
PE
3070 (Fdefine_coding_system_internal)
3071 (coding_set_source, coding_set_destination):
d311d28c
PE
3072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3073 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3074 (Fdefine_coding_system_internal):
3075 Don't assume fixnums fit in int.
3076 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3077 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3078 (Funencodable_char_position, Fcheck_coding_systems_region)
3079 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3081 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3082 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3083 Don't access memory outside of the args array.
d311d28c 3084 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3085 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3086 result of ENCODE_CHAR.
d311d28c
PE
3087 * coding.h: Adjust decls to match defn changes elsewhere.
3088 (struct coding_system):
3089 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3090 * composite.c (get_composition_id, find_composition)
3091 (run_composition_function, update_compositions)
3092 (compose_text, composition_gstring_put_cache)
3093 (composition_gstring_p, composition_gstring_width)
3094 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3095 (composition_compute_stop_pos, composition_reseat_it)
3096 (composition_update_it, struct position_record)
3097 (find_automatic_composition, composition_adjust_point)
3098 (Fcomposition_get_gstring, Ffind_composition_internal):
3099 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3100 (update_compositions):
3101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3102 * composite.h: Adjust decls to match defn changes elsewhere.
3103 (struct composition):
3104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3105 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3106 Do not attempt to compute the address of the object just before a
3107 buffer; this is not portable.
3108 (Faref, Faset):
3109 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3110 (Faset): Use int, not EMACS_INT, where int is wide enough.
3111 (Fstring_to_number): Don't assume fixnums fit in int.
3112 (Frem): Don't assume arg is nonnegative.
3113 * dbusbind.c (xd_append_arg): Check for integers out of range.
3114 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3115 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3116 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3117 (xd_get_connection_references): Return ptrdiff_t, not int.
3118 All uses changed.
3119 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3120 (xd_read_message_1):
3121 Use int, not unsigned, where the dbus API uses int.
3122 (Fdbus_message_internal): Don't overflow mtype.
3123 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3124 * dired.c (directory_files_internal, file_name_completion, scmp)
3125 (file_name_completion_stat):
3126 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3127 (file_name_completion): Don't overflow matchcount.
3128 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3129 * dispextern.h: Adjust decls to match defn changes elsewhere.
3130 (struct text_pos, struct glyph, struct bidi_saved_info)
3131 (struct bidi_string_data, struct bidi_it, struct composition_it)
3132 (struct it):
3133 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3134 (struct display_pos, struct composition_it, struct it):
3135 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3136 * dispnew.c (increment_matrix_positions)
3137 (increment_row_positions, mode_line_string)
3138 (marginal_area_string):
3139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3140 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3141 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3142 (duration_to_sec_usec): New function, to check for overflow better.
3143 (Fsleep_for, sit_for): Use it.
3144 * doc.c (get_doc_string, store_function_docstring):
3145 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3146 (get_doc_string, Fsnarf_documentation):
3147 Use int, not EMACS_INT, where int is wide enough.
3148 (get_doc_string):
3149 Use SAFE_ALLOCA, not alloca.
3150 Check for overflow when converting EMACS_INT to off_t.
3151 * doprnt.c (doprnt):
3152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3153 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3154 Don't assume uid_t fits into fixnum.
3155 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3156 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3157 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3158 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3159 (general_insert_function)
3160 (Finsert_char, make_buffer_string, make_buffer_string_both)
3161 (update_buffer_properties, Fbuffer_substring)
3162 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3163 (Fsubst_char_in_region, check_translation)
3164 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3165 (transpose_markers, Ftranspose_regions):
3166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3167 (clip_to_bounds): Move to lisp.h as an inline function).
3168 (Fconstrain_to_field): Don't assume integers are nonnegative.
3169 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3170 (Fsubst_char_in_region, Fsave_restriction):
3171 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3172 (Femacs_pid): Don't assume pid_t fits into fixnum.
3173 (lo_time): Use int, not EMACS_INT, when int suffices.
3174 (lisp_time_argument): Check for usec out of range.
3175 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3176 (Fuser_login_name, Fuser_full_name): Signal an error
3177 if a uid argument is out of range, rather than relying on
3178 undefined behavior.
c8d5c857
PE
3179 (Fformat_time_string): Remove now-unnecessary check.
3180 lisp_time_argument checks for out-of-range usec now.
243e0530 3181 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3182 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3183 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3184 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3185 (init_cmdargs, Fdump_emacs):
3186 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3187 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3188 the bottom (typically) 32 bits of the fixnum.
3189 * eval.c (specpdl_size, call_debugger):
3190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3191 (when_entered_debugger, Fbacktrace_debug):
3192 Don't assume fixnum can fit in int.
3193 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3194 the object just before a buffer; this is not portable.
3195 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3196 (grow_specpdl, unbind_to):
3197 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3198 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3199 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3200 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3201 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3202 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3203 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3204 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3205 (a_write, e_write):
3206 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3207 (Fcopy_file, non_regular_nbytes, read_non_regular)
3208 (Finsert_file_contents):
3209 Use int, not EMACS_INT, where int is wide enough.
3210 (READ_BUF_SIZE): Verify that it fits in int.
3211 (Finsert_file_contents): Check that counts are in proper range,
3212 rather than assuming fixnums fit into ptrdiff_t etc.
3213 Don't assume fixnums fit into int.
125b3835 3214 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3215 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3216 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3217 (string_char_to_byte, string_byte_to_char)
3218 (string_make_multibyte, string_to_multibyte)
3219 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3220 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3221 (substring_both, Fdelete, internal_equal, Ffillarray)
3222 (Fclear_string, mapcar1)
3223 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3224 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3225 (larger_vector, make_hash_table, maybe_resize_hash_table)
3226 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3227 (Fmaphash, secure_hash):
3228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3229 (concat): Check for string index and length overflow.
3230 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3231 (Frequire):
3232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3233 (larger_vector): New API (vec, incr_min, size_max) replaces old
3234 one (vec, new_size, init). This catches size overflow.
3235 INIT was removed because it was always Qnil.
3236 All callers changed.
3237 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3238 the upper bound on a hash table index size.
3239 (make_hash_table, maybe_resize_hash_table): Use it.
3240 (secure_hash): Computer start_byte and end_byte only after
3241 they're known to be in ptrdiff_t range.
3242 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3243 (Ffont_get_glyphs, Ffont_at):
3244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3245 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3246 (Flist_fonts, Fopen_font):
3247 Don't assume fixnum can fit in int.
3248 (check_gstring): Don't assume index can fit in int.
3249 (font_match_p): Check that fixnum is a character, not a nonnegative
3250 fixnum, since the later code needs to stuff it into an int.
3251 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3252 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3253 conversion overflow issues.
3254 (Fopen_font): Check for integer out of range.
3255 (Ffont_get_glyphs): Don't assume index can fit in int.
3256 * font.h: Adjust decls to match defn changes elsewhere.
3257 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3258 integer overflow.
3259 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3260 printmax_t, where ptrdiff_t is wide enough.
3261 (Finternal_char_font):
3262 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3263 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3264 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3265 (Fset_frame_position, x_set_frame_parameters)
3266 (x_set_line_spacing, x_set_border_width)
3267 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3268 Check that fixnums are in proper range for system types.
3269 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3270 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3271 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3272 Use SAFE_ALLOCA_LISP, not alloca.
3273 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3274 intptr_t is wide enough.
3275 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3276 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3277 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3278 Check for fixnum out of range.
3279 * ftfont.c (ftfont_list): Don't assume index fits in int.
3280 Check that fixnums are in proper range for system types.
3281 (ftfont_shape_by_flt):
3282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3283 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3284 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3285 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3286 Check that fixnums are in proper range for system types.
3287 * gnutls.h: Adjust decls to match defn changes elsewhere.
3288 * gtkutil.c (xg_dialog_run):
3289 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3290 (update_frame_tool_bar):
3291 Check that fixnums are in proper range for system types.
3292 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3293 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3294 * indent.c (last_known_column, last_known_column_point):
3295 (current_column_bol_cache):
3296 (skip_invisible, current_column, check_display_width):
3297 (check_display_width, scan_for_column, current_column_1)
3298 (Findent_to, Fcurrent_indentation, position_indentation)
3299 (indented_beyond_p, Fmove_to_column, compute_motion):
3300 (Fcompute_motion, Fvertical_motion):
3301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3302 (last_known_column_modified): Use EMACS_INT, not int.
3303 (check_display_width):
3304 (Fcompute_motion):
3305 Check that fixnums and floats are in proper range for system types.
3306 (compute_motion): Don't assume index or fixnum fits in int.
3307 (compute_motion, Fcompute_motion):
3308 Use int, not EMACS_INT, when it is wide enough.
3309 (vmotion): Omit local var start_hpos that is always 0; that way
3310 we don't need to worry about overflow in expressions involving it.
3311 * indent.h: Adjust decls to match defn changes elsewhere.
3312 (struct position):
3313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3314 Use int, not EMACS_INT, where int is wide enough.
3315 Remove unused members ovstring_chars_done and tab_offset;
3316 all uses removed.
3317 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3318 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3319 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3320 (make_gap, copy_text, insert, insert_and_inherit)
3321 (insert_before_markers, insert_before_markers_and_inherit)
3322 (insert_1, count_combining_before, count_combining_after)
3323 (insert_1_both, insert_from_string)
3324 (insert_from_string_before_markers, insert_from_string_1)
3325 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3326 (adjust_after_replace, adjust_after_insert, replace_range)
3327 (replace_range_2, del_range, del_range_1, del_range_byte)
3328 (del_range_both, del_range_2, modify_region)
3329 (prepare_to_modify_buffer, signal_before_change)
3330 (signal_after_change, Fcombine_after_change_execute):
3331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3332 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3333 (balance_an_interval, split_interval_right, split_interval_left)
3334 (find_interval, next_interval, update_interval)
3335 (adjust_intervals_for_insertion, delete_node, delete_interval)
3336 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3337 (static_offset_intervals, offset_intervals)
3338 (merge_interval_right, merge_interval_left, make_new_interval)
3339 (graft_intervals_into_buffer, temp_set_point_both)
3340 (temp_set_point, set_point, adjust_for_invis_intang)
3341 (set_point_both, move_if_not_intangible, get_property_and_range)
3342 (get_local_map, copy_intervals, copy_intervals_to_string)
3343 (compare_string_intervals, set_intervals_multibyte_1):
3344 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3345 * intervals.h: Adjust decls to match defn changes elsewhere.
3346 (struct interval):
3347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3348 * keyboard.c (this_command_key_count, this_single_command_key_start)
3349 (before_command_key_count, before_command_echo_length, echo_now)
3350 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3351 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3352 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3353 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3354 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3355 (last_non_minibuf_size, last_point_position, echo_truncate)
3356 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3357 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3358 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3359 (stuff_buffered_input):
3360 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3361 (last_auto_save, command_loop_1, read_char):
3362 Use EMACS_INT, not int, to avoid integer overflow.
3363 (record_char): Avoid overflow in total_keys computation.
3364 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3365 * keyboard.h: Adjust decls to match defn changes elsewhere.
3366 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3367 (Fkey_description, Fdescribe_vector, Flookup_key):
3368 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3369 (click_position): New function, to check that positions are in range.
3370 (Fcurrent_active_maps):
3371 (describe_command):
3372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3373 (Faccessible_keymaps, Fkey_description):
3374 (preferred_sequence_p):
3375 Don't assume fixnum can fit into int.
3376 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3377 Check for integer overflow in size calculations.
3378 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3379 avoid mishandling large integers.
3380 * lisp.h: Adjust decls to match defn changes elsewhere.
3381 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3382 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3383 (struct Lisp_Marker):
3384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3385 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3386 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3387 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3388 All callers changed.
3389 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3390 Assume the arg has valid form, since it always does.
3391 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3392 unsigned integer system type.
3393 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3394 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3395 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3396 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3397 (duration_to_sec_usec): New decl.
3398 * lread.c (read_from_string_index, read_from_string_index_byte)
3399 (read_from_string_limit, readchar, unreadchar, openp)
3400 (read_internal_start, read1, oblookup):
3401 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3402 (Fload, readevalloop, Feval_buffer, Feval_region):
3403 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3404 (openp): Check for out-of-range argument to 'access'.
3405 (read1): Use int, not EMACS_INT, where int is wide enough.
3406 Don't assume fixnum fits into int.
6efdadfd 3407 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3408 (read_filtered_event): Use duration_to_sec_usec
3409 to do proper overflow checking on durations.
d311d28c
PE
3410 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3411 in size calculation.
3412 (Fexecute_kbd_macro):
3413 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3414 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3415 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3416 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3417 (set_marker_both, set_marker_restricted_both, marker_position)
3418 (marker_byte_position, Fbuffer_has_markers_at):
3419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3420 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3421 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3422 It now merely ensures that the menu is large enough, without
3423 necessarily growing it, as this avoids some integer overflow issues.
3424 All callers changed.
3425 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3426 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3427 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3428 Use SAFE_ALLOCA_LISP, not alloca.
3429 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3430 to EMACS_INT. Check that fixnums are in proper range for system types.
3431 * minibuf.c (minibuf_prompt_width, string_to_object)
3432 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3433 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3435 (get_minibuffer, read_minibuf_unwind):
3436 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3437 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3438 this simplifies overflow checking. All callers changed.
3439 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3440 (Ftest_completion):
3441 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3442 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3443 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3444 Check that fixnums are in proper range for system types.
3445 (Fx_create_frame, Fx_show_tip):
3446 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3447 * nsfont.m (ns_findfonts, nsfont_list_family):
3448 Don't assume fixnum fits in long.
3449 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3450 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3451 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3452 wide enough.
17fdb222 3453 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3455 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3456 (PRINTDECLARE, PRINTPREPARE):
3457 (strout, print_string):
3458 (print, print_preprocess, print_check_string_charset_prop)
3459 (print_object):
3460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3461 (PRINTDECLARE):
3462 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3463 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3464 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3465 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3466 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3467 (print_error_message): Use SAFE_ALLOCA, not alloca.
3468 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3469 (print_depth, new_backquote_output, print_number_index):
3470 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3471 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3472 (Fset_process_window_size, Fformat_network_address)
3473 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3474 (sigchld_handler):
d311d28c 3475 Check that fixnums are in proper range for system types.
d44287d4 3476 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3477 Check for process-ids out of pid_t range rather than relying on
3478 undefined behavior.
e4d81efc 3479 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3480 (Fformat_network_address, read_process_output, send_process)
3481 (Fprocess_send_region, status_notify):
3482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3483 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3484 (wait_reading_process_output, read_process_output, exec_sentinel):
3485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3486 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3487 (Faccept_process_output): Use duration_to_sec_usec to do proper
3488 overflow checking on durations.
dde14581
PE
3489 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3490 Don't assume pid_t fits in int.
02481186
PE
3491 * process.h (struct Lisp_Process): Members tick and update_tick
3492 are now of type EMACS_INT, not int.
b62b53e8
PE
3493 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3494 configured --with-wide-int.
d311d28c
PE
3495 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3496 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3497 * search.c (looking_at_1, string_match_1):
3498 (fast_string_match, fast_c_string_match_ignore_case)
3499 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3500 (scan_newline, find_before_next_newline, search_command)
3501 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3502 (set_search_regs, wordify):
3503 (Freplace_match):
3504 (Fmatch_data):
3505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3506 (string_match_1, search_buffer, set_search_regs):
3507 (Fmatch_data):
3508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3509 (wordify): Check for overflow in size calculation.
3510 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3511 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3512 Check that fixnums are in proper range for system types.
3513 * sound.c (struct sound_device)
3514 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3515 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3516 (Fplay_sound_internal):
3517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3518 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3519 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3520 (Fparse_partial_sexp):
3521 Don't assume fixnums can fit in int.
3522 (struct lisp_parse_state, find_start_pos, find_start_value)
3523 (find_start_value_byte, find_start_begv)
3524 (update_syntax_table, char_quoted, dec_bytepos)
3525 (find_defun_start, prev_char_comend_first, back_comment):
3526 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3527 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3529 (Finternal_describe_syntax_value): Check that match_lisp is a
3530 character, not an integer, since the code stuffs it into int.
3531 (scan_words, scan_sexps_forward):
3532 Check that fixnums are in proper range for system types.
3533 (Fforward_word):
3534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3535 (scan_sexps_forward):
3536 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3537 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3538 * syntax.h: Adjust decls to match defn changes elsewhere.
3539 (struct gl_state_s):
3540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3541 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3542 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3543 * sysdep.c (wait_for_termination_1, wait_for_termination)
3544 (interruptible_wait_for_termination, mkdir):
3545 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3546 (emacs_read, emacs_write):
3547 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3548 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3549 and double all fit in int.
d311d28c
PE
3550 * term.c (set_tty_color_mode):
3551 Check that fixnums are in proper range for system types.
3552 * termhooks.h (struct input_event):
3553 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3554 * textprop.c (validate_interval_range, interval_of)
3555 (Fadd_text_properties, set_text_properties_1)
3556 (Fremove_text_properties, Fremove_list_of_text_properties)
3557 (Ftext_property_any, Ftext_property_not_all)
3558 (copy_text_properties, text_property_list, extend_property_ranges)
3559 (verify_interval_modification):
3560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3561 (Fnext_single_char_property_change)
3562 (Fprevious_single_char_property_change):
3563 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3564 (copy_text_properties):
3565 Check for integer overflow in index calculation.
d311d28c
PE
3566 * undo.c (last_boundary_position, record_point, record_insert)
3567 (record_delete, record_marker_adjustment, record_change)
3568 (record_property_change):
3569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3570 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3572 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3573 (Fx_hide_tip, Fx_file_dialog):
3574 * w32menu.c (set_frame_menubar):
3575 Use ptrdiff_t, not int, for consistency with rest of code.
3576 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3577 (select_window, Fdelete_other_windows_internal)
3578 (window_scroll_pixel_based, window_scroll_line_based)
3579 (Frecenter, Fset_window_configuration):
3580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3581 (Fset_window_hscroll, run_window_configuration_change_hook)
3582 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3583 (Fscroll_other_window, Frecenter):
d311d28c
PE
3584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3585 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3586 Don't assume fixnum fits in int.
3587 (Fset_window_scroll_bars):
3588 Check that fixnums are in proper range for system types.
3589 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3590 (string_pos, c_string_pos, number_of_chars, init_iterator)
3591 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3592 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3593 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3594 (face_before_or_after_it_pos, handle_invisible_prop)
3595 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3596 (display_prop_intangible_p, string_buffer_position_lim)
3597 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3598 (get_overlay_strings_1, get_overlay_strings)
3599 (iterate_out_of_display_property, forward_to_next_line_start)
3600 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3601 (get_next_display_element, set_iterator_to_next)
3602 (get_visually_first_element, compute_stop_pos_backwards)
3603 (handle_stop_backwards, next_element_from_buffer)
3604 (move_it_in_display_line_to, move_it_in_display_line)
3605 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3606 (add_to_log, message_dolog, message_log_check_duplicate)
3607 (message2, message2_nolog, message3, message3_nolog
3608 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3609 (current_message_1, truncate_echo_area, truncate_message_1)
3610 (set_message, set_message_1, store_mode_line_noprop)
3611 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3612 (text_outside_line_unchanged_p, check_point_in_composition)
3613 (reconsider_clip_changes)
3614 (redisplay_internal, set_cursor_from_row, try_scrolling)
3615 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3616 (redisplay_window, find_last_unchanged_at_beg_row)
3617 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3618 (trailing_whitespace_p, find_row_edges, display_line)
3619 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3620 (display_mode_element, store_mode_line_string)
3621 (pint2str, pint2hrstr, decode_mode_spec)
3622 (display_count_lines, display_string, draw_glyphs)
3623 (x_produce_glyphs, x_insert_glyphs)
3624 (rows_from_pos_range, mouse_face_from_buffer_pos)
3625 (fast_find_string_pos, mouse_face_from_string_pos)
3626 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3628 (safe_call, init_from_display_pos, handle_fontified_prop)
3629 (handle_single_display_spec, load_overlay_strings)
3630 (with_echo_area_buffer, setup_echo_area_for_printing)
3631 (display_echo_area, echo_area_display)
3632 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3633 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3634 (redisplay_window, dump_glyph_row, display_mode_line)
3635 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3636 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3638 (handle_single_display_spec, build_desired_tool_bar_string)
3639 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3640 (get_specified_cursor_type):
3641 Check that fixnums are in proper range for system types.
3642 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3643 (Flookup_image_map):
3644 Don't assume fixnums fit in int.
3645 (compare_overlay_entries):
3646 Avoid mishandling comparisons due to subtraction overflow.
3647 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3648 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3649 (handle_tool_bar_click):
3650 Use int, not unsigned, since we prefer signed and the signedness
3651 doesn't matter here.
3652 (get_next_display_element, next_element_from_display_vector):
3653 Use int, not EMACS_INT, when int is wide enough.
3654 (start_hourglass): Use duration_to_sec_usec to do proper
3655 overflow checking on durations.
3656 * xfaces.c (Fbitmap_spec_p):
3657 Check that fixnums are in proper range for system types.
3658 (compare_fonts_by_sort_order):
3659 Avoid mishandling comparisons due to subtraction overflow.
3660 (Fx_family_fonts, realize_basic_faces):
3661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3662 (Fx_family_fonts):
3663 Don't assume fixnum fits in int.
3664 Use SAFE_ALLOCA_LISP, not alloca.
3665 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3666 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3667 (face_at_buffer_position, face_for_overlay_string)
3668 (face_at_string_position):
3669 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3670 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3671 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3672 (Fx_show_tip):
3673 Check that fixnums are in proper range for system types.
3674 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3675 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3677 (Fx_change_window_property): Don't assume fixnums fit in int.
3678 * xfont.c (xfont_chars_supported):
3679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3680 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3681 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3682 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3683 * xml.c (parse_region):
3684 * xrdb.c (magic_file_p):
3685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3686 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3687 (x_get_local_selection, x_reply_selection_request)
3688 (x_handle_selection_request, wait_for_property_change):
3689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3690 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3691 short is wide enough.
3692 (x_send_client_event): Don't assume fixnum fits in int.
3693 * xterm.c (x_x_to_emacs_modifiers):
3694 Don't assume EMACS_INT overflows nicely into int.
3695 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3696 may come from Lisp.
3697 (handle_one_xevent): NATNUMP can eval its arg twice.
3698 (x_connection_closed):
3699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3700 * xterm.h: Adjust decls to match defn changes elsewhere.
3701 (struct scroll_bar): Use struct vectorlike_header
3702 rather than rolling our own approximation.
3703 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3704
c6574eb5
GM
37052012-05-25 Glenn Morris <rgm@gnu.org>
3706
3707 * lisp.mk (lisp): Update for more files being compiled now.
3708
e8d32c7e
SM
37092012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3710
48def666
SM
3711 * lread.c: Remove `read_pure' which makes no difference.
3712 (read_pure): Remove var.
3713 (unreadpure): Remove function.
3714 (readevalloop): Don't call read_list with -1 flag.
3715 (read1, read_vector): Don't test read_pure any more.
3716 (read_list): Simplify.
3717
e8d32c7e
SM
3718 * fileio.c, character.h: Minor style tweaks.
3719
4b2addb7
DA
37202012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3721
3722 * window.h (clip_changed): Remove useless declaration.
3723
584461b2
JB
37242012-05-22 Juanma Barranquero <lekktu@gmail.com>
3725
3726 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3727 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3728
34374650
PE
37292012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3730
3731 Remove src/m/*.
3732 This directory predates autoconf and is no longer needed nowadays.
3733 Move its few remaining bits of functionality to where they're needed.
3734 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3735 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3736 * m/template.h: Remove.
3737 * Makefile.in (M_FILE): Remove. All uses removed.
3738 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3739 * lisp.h (USE_LSB_TAG):
3740 * mem-limits.h (EXCEEDS_LISP_PTR):
3741 Use VAL_MAX, not VALBITS, in #if.
3742 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3743 (EMACS_UINT): Define unconditionally now.
3744 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3745 (BITS_PER_EMACS_INT): New constants, replacing
3746 what used to be in config.h, but not useful in #if.
3747 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3748 define them any more.
3749 (VAL_MAX): New macro.
3750 (VALMASK): Use it.
3751 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3752 BITS_PER_EMACS_INT, in #if.
3753 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3754 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3755 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3756 * s/ms-w32.h (DATA_START):
3757 Move here from removed file m/intel386.h.
3758 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3759 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3760
261cb4bb
PE
37612012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3762
3763 Assume C89 or later.
3764 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3765 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3766 (xrealloc):
3767 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3768 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3769 * textprop.c, tparam.c (NULL): Remove.
3770 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3771 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3772 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3773 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3774 * xterm.c (input_signal_count): Assume volatile works.
3775
ff23cd9f
KB
37762012-05-21 Ken Brown <kbrown@cornell.edu>
3777
3778 * xgselect.c (xg_select): Fix first argument in call to 'select'
3779 (bug#11508).
3780
1b170bc6
KB
37812012-05-20 Ken Brown <kbrown@cornell.edu>
3782
3783 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3784 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3785
b2f4d39f
KB
37862012-05-19 Ken Brown <kbrown@cornell.edu>
3787
3788 * xfns.c (x_in_use): Remove `static' qualifier.
3789 * xterm.h (x_in_use): Declare.
3790 * xgselect.c: Include xterm.h.
3791 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3792 and `display_arg' (bug#9754).
3793
003fdae2
PE
37942012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3795
9232a6d9
PE
3796 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3797
003fdae2
PE
3798 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3799 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3800
784b56e2
EZ
38012012-05-18 Eli Zaretskii <eliz@gnu.org>
3802
3803 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3804
3805 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3806 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3807
3808 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3809 reference to image_cache->refcount.
3810 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3811
a0a79cde
JL
38122012-05-17 Juri Linkov <juri@jurta.org>
3813
3814 * search.c (Fword_search_regexp, Fword_search_backward)
3815 (Fword_search_forward, Fword_search_backward_lax)
3816 (Fword_search_forward_lax): Move functions to isearch.el
3817 (bug#10145, bug#11381).
3818
b0572523
PE
38192012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3820
3821 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3822
9660f5fc
SM
38232012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3824
3825 * lread.c (init_obarray): Declare Qt and Qnil as special.
3826
4374de83
GM
38272012-05-14 Glenn Morris <rgm@gnu.org>
3828
3829 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3830 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3831
dc44c39a
PE
38322012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3833
078c97cb
PE
3834 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3835
dc44c39a
PE
3836 * unexaix.c: Port to more-recent AIX compilers.
3837 (report_error, report_error_1, make_hdr, copy_sym)
3838 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3839 Make arguments const char *, not char *, to avoid violations of C
3840 standard and to fix some AIX warnings reported by Gilles Pion.
3841
e18afed7 38422012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3843
3844 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3845 already have overlays loaded.
3846 (handle_single_display_spec): Before returning without displaying
3847 fringe bitmap, synchronize the bidi iterator with the main display
3848 iterator, by calling iterate_out_of_display_property.
3849 (iterate_out_of_display_property): Detect buffer iteration by
3850 testing that it->string is a Lisp string.
3851 (get_next_display_element): When the current object is exhausted,
3852 and there's something on it->stack, call set_iterator_to_next to
3853 proceed with what's on the stack, instead of returning zero.
3854 (set_iterator_to_next): If called at the end of a Lisp string,
3855 proceed to consider_string_end without incrementing string
3856 position. Don't increment display vector index past the end of
3857 the display vector. (Bug#11417)
c8fb9dc6
EZ
3858 (pos_visible_p): Don't report a position visible when move_it_to
3859 stopped at the last line of window, which happens to be scanned
3860 backwards by the bidi iteration. (Bug#11464)
ac268e67 3861
e18afed7 38622012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3863
3864 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3865 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3866 are on a TTY, and thus unable to display on the fringes.
3867 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3868 so we need to signal to the caller that this is a "replacing"
3869 display spec. This fixes display when the spec is invalid or we
3870 are on a TTY.
3871
e18afed7 38722012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3873
3874 * unexaix.c (make_hdr): Fix typo in prototype.
3875 This bug broke the build on AIX. Problem reported by Gilles Pion.
3876
9d0a235a
MA
38772012-05-14 Michael Albinus <michael.albinus@gmx.de>
3878
3879 * keyboard.c (kbd_buffer_get_event): Read special events also in
3880 batch mode. (Bug#11415)
3881
9e6b06ed
GM
38822012-05-12 Glenn Morris <rgm@gnu.org>
3883
3884 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3885
c1a1d7a3
EZ
38862012-05-12 Eli Zaretskii <eliz@gnu.org>
3887
3888 * lisp.mk (lisp): Add newcomment.elc.
3889
3fe7cdc8
GM
38902012-05-12 Glenn Morris <rgm@gnu.org>
3891
3892 * Makefile.in (MKDIR_P): New, set by configure.
3893 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3894
53f7d2c0
PE
38952012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3896
3897 Remove unused function hourglass_started.
3898 * dispextern.h (hourglass_started):
3899 * w32fns.c (hourglass_started):
3900 * xdisp.c (hourglass_started): Remove.
3901
75aafb17
JB
39022012-05-10 Juanma Barranquero <lekktu@gmail.com>
3903
3904 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3905 Update dependencies.
3906
12959e8e
PE
39072012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3908
97107e2e
PE
3909 * xgselect.c (xg_select): Put maxfds+1 into a var.
3910 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3911
12959e8e
PE
3912 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3913
836d29b3
DA
39142012-05-10 Dave Abrahams <dave@boostpro.com>
3915
3916 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3917 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3918
5cb67954
MA
39192012-05-09 Michael Albinus <michael.albinus@gmx.de>
3920
3921 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3922 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3923 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3924 Initialize xd_registered_buses.
3925
3478ec45
PE
39262012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3927
b263a6b0
PE
3928 Untag more efficiently if USE_LSB_TAG.
3929 This is based on a proposal by YAMAMOTO Mitsuharu in
3930 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3931 For an admittedly artificial (nth 8000 longlist) benchmark on
3932 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3933 Emacs's overall text size by 1%.
3934 * lisp.h (XUNTAG): New macro.
3935 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3936 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3937 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3938 * eval.c (Fautoload):
3939 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3940 * frame.h (XFRAME): Use XUNTAG.
3941
3478ec45
PE
3942 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3943 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3944 Remove unportable assumptions about print widths of types like
3945 dbus_uint32_t.
3946 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3947 intptr_t when converting between pointer and integer, to avoid GCC
3948 warnings about wrong width.
3949
666b903b 39502012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3951
3952 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3953 stack for each reader_thread, instead of defaulting to 8MB
3954 determined by the linker. This avoids failures in creating
3955 subprocesses on Windows 7, see the discussion in this thread:
3956 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3957
b120cc17
JC
39582012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3959
3960 Fix up display of the *Minibuf-0* buffer in the mini window.
3961 * keyboard.c (read_char): Don't clear the echo area if there's no
3962 message to clear.
3963 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3964 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3965
9a4b36f8
MA
39662012-05-07 Michael Albinus <michael.albinus@gmx.de>
3967
3968 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3969 batch mode.
3970
e5f9458f
CY
39712012-05-06 Chong Yidong <cyd@gnu.org>
3972
3973 * lisp.mk (lisp): Update.
3974
eceeb5fc 39752012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3976
3977 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3978
71873e2b
SM
39792012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3980
3981 * data.c (PUT_ERROR): New macro.
3982 (syms_of_data): Use it. Add new error type `user-error'.
3983 * undo.c (user_error): New function.
3984 (Fprimitive_undo): Use it.
3985 * print.c (print_error_message): Adjust print style for `user-error'.
3986 * keyboard.c (user_error): New function.
3987 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3988
ab0fa4e4
PE
39892012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3990
3991 Do not limit current-time-string to years 1000..9999.
3992 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3993 (Fcurrent_time_string): Support any year that is supported by the
3994 underlying localtime representation. Don't use asctime, as it
3995 has undefined behavior for years outside the range -999..9999.
3996
7ed806a7
PE
39972012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3998
3999 Fix race conditions involving setenv, gmtime, localtime, asctime.
4000 Without this fix, interrupts could mess up code that uses these
4001 nonreentrant functions, since setting TZ invalidates existing
4002 tm_zone or tzname values, and since most of these functions return
4003 pointers to static storage.
4004 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4005 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4006 Grow the critical sections to include not just invoking
4007 localtime/gmtime, but also accessing these functions' results
4008 including their tm_zone values if any, and any related TZ setting.
4009 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4010 so that the struct tm is saved in the critical section.
4011 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4012 motivated by the fact that memory allocation needs to be outside
4013 the critical section.
4014
0c16dfed
DA
40152012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4016
4017 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4018 with RESET_INTERVAL.
4019
4020 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4021 Remove duplicated buffer name initialization.
4022
3f83ace8
JM
40232012-05-02 Jim Meyering <jim@meyering.net>
4024
4025 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4026
c7b8541e
JM
4027 * xfns.c (x_window): Use xstrdup (Bug#11375).
4028
90207a15 40292012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4030
4031 * xdisp.c (pos_visible_p): If already at a newline from the
4032 display string before the 'while' loop, don't walk back the glyphs
4033 from it3.glyph_row. Solves assertion violation when the display
4034 string begins with a newline (egg.el). (Bug#11367)
4035
b593d6a9
AH
40362012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4037
4038 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4039 Move to simple.el.
4040
4737362e
GM
40412012-05-01 Glenn Morris <rgm@gnu.org>
4042
99cf43f9
GM
4043 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4044 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4045 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4046 All were removed before 23.1.
4047
9311dcff
GM
4048 * dispnew.c: Remove HAVE_LIBNCURSES test;
4049 it is always true on relevant platforms.
4050
4d5c6349
GM
4051 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4052 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4053
4737362e
GM
4054 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4055
74dd3a6b
AS
40562012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4057
4058 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4059 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4060 Remove.
4061
13c379ee
PE
40622012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4063
4064 Do not avoid creating empty evaporating overlays (Bug#9642).
4065 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4066 That is, do not delete an evaporating overlay if it becomes
4067 empty after its bounds are adjusted to fit within its buffer.
4068 This fix caused other problems, and I'm reverting it until we get
4069 to the bottom of them.
4070
a8e7d6d7 40712012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4072
4073 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4074
a8e7d6d7 40752012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4076
4077 * xdisp.c (pos_visible_p): If the window start position is beyond
4078 ZV, start the display from buffer beginning. Prevents assertion
4079 violation in init_iterator when the minibuffer window is scrolled
4080 via the scroll bar.
4081
4082 * window.c (window_scroll_pixel_based): Likewise.
4083
a8e7d6d7 40842012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4085
4086 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4087
a8e7d6d7 40882012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4089
4090 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4091 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4092
a8e7d6d7 40932012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4094
b593d6a9
AH
4095 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4096 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4097
1c6900d9
EZ
40982012-04-26 Eli Zaretskii <eliz@gnu.org>
4099
4c3fa1d9
EZ
4100 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4101 display element, check also the underlying string or buffer
4102 character. (Bug#11341)
4103
1c6900d9
EZ
4104 * w32menu.c: Include w32heap.h.
4105 (add_menu_item): If the call to AppendMenuW (via
4106 unicode_append_menu) fails, disable Unicode menus only if we are
4107 running on Windows 9X/Me.
4108
42bf8205
AS
41092012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4110
4111 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4112 (xgetint): Add missing shift for LSB tags.
4113
b1bac16e
MR
41142012-04-24 Martin Rudalics <rudalics@gmx.at>
4115
4116 * keyboard.c (read_char): Don't wipe echo area for select window
4117 events: These might get delayed via `mouse-autoselect-window'
4118 (Bug#11304).
4119
d69621cc
JB
41202012-04-24 Juanma Barranquero <lekktu@gmail.com>
4121
4122 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4123 manipulation of :loaded-from data.
4124
02fd101b
JB
41252012-04-23 Juanma Barranquero <lekktu@gmail.com>
4126
4127 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4128 now a cons (bug#11311).
4129
888bec30
PE
41302012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4131
89a438bd
PE
4132 Do not create empty overlays with the evaporate property (Bug#9642).
4133 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4134 if it becomes empty after its bounds are adjusted to fit within
4135 its buffer. Without this fix, in a nonempty buffer (let ((o
4136 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4137 yields an empty overlay that has the evaporate property, which is
4138 not supposed to happen.
4139
1068fe4d
PE
4140 Fix minor GTK3 problems found by static checking.
4141 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4142 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4143 (struct _EmacsFixedClass, emacs_fixed_get_type):
4144 Move decls here from emacsgtkfixed.h, since they needn't be public.
4145 (emacs_fixed_get_type): Now static.
4146 (emacs_fixed_class_init): Omit unused local.
4147 (emacs_fixed_child_type): Remove; unused.
4148 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4149 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4150 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4151 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4152 (EMACS_FIXED_GET_CLASS): Remove; unused.
4153 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4154
888bec30
PE
4155 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4156 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4157
de85e130
PE
41582012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4159
d0baac98 4160 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4161 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4162 (__malloc_size_t, __malloc_ptrdiff_t):
4163 Remove. All uses removed, replaced by the definiens if needed,
4164 since we can assume C89 or better now.
4165 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4166 (protect_malloc_state, align, get_contiguous_space)
4167 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4168 (malloc_atfork_handler_child, malloc_enable_thread)
4169 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4170 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4171 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4172 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4173 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4174 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4175 Define using prototypes, not old style.
4176 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4177 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4178 (align): Don't assume that signed integer overflow wraps around.
4179 Omit unused local var.
4180 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4181 (_free_internal_nolock, memalign, mallochook, reallochook):
4182 Omit no-longer-needed casts.
4183 (valloc): Use getpagesize, not __getpagesize.
4184 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4185 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4186
de85e130
PE
4187 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4188
dcbf5805
MA
41892012-04-22 Michael Albinus <michael.albinus@gmx.de>
4190
4191 Move functions from C to Lisp. Make non-blocking method calls
4192 the default. Implement further D-Bus standard interfaces.
4193
4194 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4195 (QCdbus_request_name_allow_replacement)
4196 (QCdbus_request_name_replace_existing)
4197 (QCdbus_request_name_do_not_queue)
4198 (QCdbus_request_name_reply_primary_owner)
4199 (QCdbus_request_name_reply_in_queue)
4200 (QCdbus_request_name_reply_exists)
4201 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4202 (QCdbus_registered_serial, QCdbus_registered_method)
4203 (QCdbus_registered_signal): New Lisp objects.
4204 (XD_DEBUG_MESSAGE): Use sizeof.
4205 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4206 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4207 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4208 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4209 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4210 (xd_signature, xd_append_arg): Allow float for integer types.
4211 (xd_get_connection_references): New function.
b593d6a9
AH
4212 (xd_get_connection_address): Rename from xd_initialize.
4213 Return cached address.
dcbf5805
MA
4214 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4215 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4216 level.
4217 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4218 Return number of refcounts.
dcbf5805
MA
4219 (Fdbus_get_unique_name): Make stronger parameter check.
4220 (Fdbus_message_internal): New defun.
4221 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4222 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4223 (Fdbus_send_signal, Fdbus_register_service)
4224 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4225 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4226 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4227 (Vdbus_compiled_version, Vdbus_runtime_version)
4228 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4229 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4230 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4231 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4232 Adapt docstring.
dcbf5805 4233
52828e02
PE
42342012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4235
da05bc4c
PE
4236 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4237 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4238 Do not assume ptrdiff_t is the same width as 'int'.
4239
52828e02
PE
4240 * alloc.c: Handle unusual debugging option combinations.
4241 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4242 since the two debugging options are incompatible.
4243 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4244 is defined.
4245 (mem_init, mem_insert, mem_insert_fixup):
4246 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4247 (NEED_MEM_INSERT): Remove; no longer needed.
4248
f01769f9
LL
42492012-04-22 Leo Liu <sdl.web@gmail.com>
4250
4251 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4252
5790543d
PE
42532012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4254
4255 * sysdep.c [__FreeBSD__]: Minor cleanups.
4256 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4257 Use Emacs indenting style more consistently. Avoid some casts.
4258 Use 'double' consistently rather than mixing 'float' and 'double'.
4259
b91b7e4d
EW
42602012-04-21 Eduard Wiebe <usenet@pusto.de>
4261
b593d6a9
AH
4262 * sysdep.c (list_system_processes, system_process_attributes):
4263 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4264
6114eb15
AS
42652012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4266
4267 * lisp.mk (lisp): Update.
4268
2f38dff7
PE
42692012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4270
4271 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4272 It is never used otherwise.
4273
4ae29f89
SM
42742012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4275
4276 * print.c (print_preprocess): Only check print_depth if print-circle
4277 is nil.
4278 (print_object): Check for cycles even when print-circle is nil and
4279 print-gensym is t, but only check print_depth if print-circle is nil.
4280
f30d612a
CY
42812012-04-20 Chong Yidong <cyd@gnu.org>
4282
4283 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4284 set the status to "failed" and ensure that sentinel is run.
4285
c07a4c0b 42862012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4287
4288 * process.c (Fset_process_inherit_coding_system_flag)
4289 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4290 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4291
c07a4c0b 42922012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4293
4294 * xdisp.c (string_buffer_position_lim): Limit starting position to
4295 BEGV.
4296 (set_cursor_from_row): If called for a mode-line or header-line
4297 row, return zero immediately.
4298 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4299 farther than the first row after the header line, if any.
4300 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4301 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4302
c07a4c0b 43032012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4304
4ae29f89
SM
4305 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4306 (bug#11238).
ad3a2b41 4307
c07a4c0b 43082012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 43092012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4310
4311 configure: new option --enable-gcc-warnings (Bug#11207)
4312 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4313 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4314 (ALL_CFLAGS): Use new macros rather than old.
4315 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4316 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4317 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4318 -Wunused-result, -Wunused-variable. This should go away once
4319 the Emacs and Gnulib regex code is merged.
4320 (xmalloc, xrealloc): Now static.
4321
aba027e8
PE
43222012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4323
4324 * dired.c (Fsystem_groups): Remove unused local.
4325
e5a36063
GM
43262012-04-17 Glenn Morris <rgm@gnu.org>
4327
4328 * dired.c (Fsystem_users): Doc fix.
4329
316411f0
DA
43302012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4331
4332 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4333 (syms_of_dired): Add them.
4334
9426aba4
PE
43352012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4336
b62a57be
PE
4337 Fix minor alloc.c problems found by static checking.
4338 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4339 New extern decls, to avoid calling undeclared functions.
4340 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4341 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4342 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4343 (NEED_MEM_INSERT): New macro.
4344 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4345 Remove one incorrect comment and fix another.
b62a57be 4346
3539f31f
PE
4347 Fix minor ralloc.c problems found by static checking.
4348 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4349 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4350 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4351 (r_alloc_sbrk): Now static.
4352
a041960a
PE
4353 Improve ralloc.c interface checking.
4354 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4355 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4356 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4357 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4358 [REL_ALLOC]: ... to here, to check interface.
4359 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4360 Remove decls. This fixes an "It stinks!".
4361
9426aba4
PE
4362 * alloc.c (which_symbols): Fix alignment issue / type clash.
4363
d55c12ed
AS
43642012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4365
4366 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4367 (struct Lisp_Misc_Any): Likewise.
4368 (struct Lisp_Free): Likewise.
4369 * alloc.c (union aligned_Lisp_Symbol): Define.
4370 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4371 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4372 (union aligned_Lisp_Misc): Define.
4373 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4374 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4375 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4376
b948ce8b
PE
43772012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4378
4379 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4380 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4381 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4382 * s/netbsd.h, s/sol2-6.h:
4383 Remove definition of GC_MARK_STACK, since the default now works.
4384 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4385 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4386 no longer the default.
4387 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4388
35dc09a1 43892012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4390
35dc09a1
GM
4391 * lread.c (lisp_file_lexically_bound_p):
4392 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4393
35dc09a1
GM
43942012-04-14 Eli Zaretskii <eliz@gnu.org>
4395
4396 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4397 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4398
43992012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4400
4401 * nsterm.m (constrainFrameRect): Always constrain when there is only
4402 one screen (Bug#10962).
4403
bcd86815
KB
44042012-04-13 Ken Brown <kbrown@cornell.edu>
4405
4406 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4407
c25df26e
RT
44082012-04-13 Reuben Thomas <rrt@sc3d.org>
4409
4410 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4411
0fc59f1e
DC
44122012-04-11 Daniel Colascione <dancol@dancol.org>
4413
4414 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4415 against is gone. It's better to use vfork now so that when Cygwin
4416 gains a new, working vfork, we use it automatically (bug#10398).
4417
de8c03dc
SM
44182012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4419
4420 * window.c (save_window_save): Obey window-point-insertion-type.
4421
2f097256
GM
44222012-04-11 Glenn Morris <rgm@gnu.org>
4423
4424 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4425
453b951e
SM
44262012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4427
4428 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4429
75f1671a 44302012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4431
4432 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4433 (force_quit_count): New var.
4434 (handle_interrupt): Use it.
4435
2a8ce227
JB
44362012-04-10 Juanma Barranquero <lekktu@gmail.com>
4437
4438 * w32.c (w32_delayed_load): Record the full path of the library
4439 being loaded (bug#10424).
4440
935396c0
GM
44412012-04-09 Glenn Morris <rgm@gnu.org>
4442
05920a43
GM
4443 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4444 not just in the obarray, before snarfing them. (Bug#11036)
4445
935396c0
GM
4446 * Makefile.in ($(leimdir)/leim-list.el):
4447 Pass EMACS rather than BUILT_EMACS.
4448
a18ecafa
TZ
44492012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4450
4451 * process.c (make_process):
4452 * process.h: Add integer `gnutls_handshakes_tried' member to
4453 process struct.
4454
6bbef4e5
JC
4455 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4456 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4457
4458 * gnutls.c (gnutls_log_function2i): Convenience log function.
4459 (emacs_gnutls_read): Use new log functions,
4460 `gnutls_handshakes_tried' process member, and
4461 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4462 attempts per process (connection).
4463
b4d3bc10
CY
44642012-04-09 Chong Yidong <cyd@gnu.org>
4465
4466 * eval.c (Fuser_variable_p, user_variable_p_eh)
4467 (lisp_indirect_variable): Functions deleted.
4468 (Fdefvar): Caller changed.
4469
4470 * callint.c (Finteractive, Fcall_interactively):
4471 * minibuf.c (Fread_variable): Callers changed.
4472
70f4d973
EZ
44732012-04-09 Eli Zaretskii <eliz@gnu.org>
4474
4475 * xdisp.c (set_cursor_from_row): If the display string appears in
4476 the buffer at position that is closer to point than the position
4477 after the display string, display the cursor on the first glyph of
4478 the display string. Fixes cursor display when a 'display' text
4479 property immediately follows invisible text. (Bug#11094)
4480
cb3c2e3e
PE
44812012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4482
4483 composite.c: use 'double' consistently
4484 * composite.c (get_composition_id): Use 'double' consistently
4485 instead of converting 'float' to 'double' and vice versa; this is
4486 easier to understand and avoids a GCC warning.
4487
fd06db5d
GM
44882012-04-09 Glenn Morris <rgm@gnu.org>
4489
50fe702a
GM
4490 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4491 preparation for dumping it with emacs. (Bug#4789)
4492 (leimdir): New variable.
4493 ($(leimdir)/leim-list.el): New rule.
4494 (emacs$(EXEEXT)): Depend on leim-list.el.
4495
fd06db5d
GM
4496 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4497 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4498 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4499
55c131ee
AS
45002012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4501
4502 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4503 proper alignment.
4504
9209588f
JB
45052012-04-07 Juanma Barranquero <lekktu@gmail.com>
4506
4507 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4508 Remove unused local variable.
4509
e3fb2efb
PE
45102012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4511
4512 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4513 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4514 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4515 objects, as mark_maybe_pointer will catch them otherwise.
4516 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4517 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4518
b5385551
PE
45192012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4520
4521 Fix typo that broke non-Windows builds.
4522 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4523
9078ead6
EZ
45242012-04-07 Eli Zaretskii <eliz@gnu.org>
4525
4526 Support building on MS-Windows with libxml2.
4527
4528 * makefile.w32-in (OBJ2): Add xml.$(O).
4529 (GLOBAL_SOURCES): Add xml.c.
4530 ($(BLD)/xml.$(O)): New dependency list.
4531
4532 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4533 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4534 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4535 [!WINDOWSNT]: New macros.
4536 (init_libxml2_functions, libxml2_loaded_p): New functions.
4537 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4538 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4539 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4540 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4541 linked in).
6bbef4e5
JC
4542 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4543 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4544 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4545
4546 * emacs.c: Don't include libxml/parser.h.
4547 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4548 xmlCleanupParser directly.
4549
4550 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4551
3811fdf3
EZ
45522012-04-07 Eli Zaretskii <eliz@gnu.org>
4553
4554 * indent.c (Fvertical_motion): If there is a display string at
4555 point, use it.vpos to compute how many lines to backtrack after
4556 move_it_to point. (Bug#11133)
4557
2f8e16b2
EZ
45582012-04-06 Eli Zaretskii <eliz@gnu.org>
4559
4560 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4561 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4562 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4563 macros related to unification of CJK characters. For the details,
4564 see the discussion following the message here:
4565 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4566
3d439cd1
CY
45672012-04-04 Chong Yidong <cyd@gnu.org>
4568
4569 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4570
8bc53d00
EZ
45712012-04-01 Eli Zaretskii <eliz@gnu.org>
4572
4573 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4574 instead of alloca. (Bug#11138)
4575
3b0512a3
AS
45762012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4577
4578 * w32menu.c (is_simple_dialog): Properly check lisp types.
4579 (Bug#11141)
4580
8427ddd2
EZ
45812012-03-31 Eli Zaretskii <eliz@gnu.org>
4582
979022ef
EZ
4583 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4584 position we get to after a call to move_it_to fails the
4585 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4586 only if we wind up in a string from display property. (Bug#11063)
4587
a6b1c7cc
EZ
4588 * window.c (Fdelete_other_windows_internal): Invalidate the row
4589 and column information about mouse highlight, so that redisplay
4590 restores it after reallocating the glyph matrices. (Bug#7464)
4591
8427ddd2
EZ
4592 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4593 string comes from a `display' text property, use the buffer
4594 position of that property as if we actually saw that position in
4595 the row's glyphs.
697ba24b
EZ
4596 (move_it_by_lines): Remove the assertion that
4597 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4598 violated when there's a before-string at the beginning of a line.
4599 (Bug#11063)
8427ddd2 4600
65a0a738
EZ
46012012-03-30 Eli Zaretskii <eliz@gnu.org>
4602
4603 * xdisp.c (append_space_for_newline): If the default face was
4604 remapped, use the remapped face for the appended newline.
4605 (extend_face_to_end_of_line): Use the remapped default face for
4606 extending the face to the end of the line.
4607 (display_line): Call extend_face_to_end_of_line when the default
4608 face was remapped. (Bug#11068)
4609
581355cc
EZ
46102012-03-29 Eli Zaretskii <eliz@gnu.org>
4611
4612 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4613
e8fc049f
SM
46142012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4615
4616 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4617
4fb9a543
GM
46182012-03-27 Glenn Morris <rgm@gnu.org>
4619
4620 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4621 Doc fixes.
4622
679910f1
KH
46232012-03-26 Kenichi Handa <handa@m17n.org>
4624
4625 * dispextern.h (struct glyph): Fix previous change. Change the
4626 bit length of glyphless.ch to 25 (Bug#11082).
4627
90d49b7f
CY
46282012-03-26 Chong Yidong <cyd@gnu.org>
4629
4630 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4631 (command_loop_1): Use it; inhibit selection update for
4632 handle-select-window too (Bug#8996).
4633
f514f6f0
FP
46342012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4635
e8fc049f 4636 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4637
bf43fa51
KH
46382012-03-25 Kenichi Handa <handa@m17n.org>
4639
4640 * dispextern.h (struct glyph): Change the bit length of
4641 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4642
8a0c01dd
EZ
46432012-03-24 Eli Zaretskii <eliz@gnu.org>
4644
4645 * s/ms-w32.h (tzname): Include time.h before redirecting to
4646 _tzname. Fixes the MSVC build. (Bug#9960)
4647
7d1c3a76
AS
46482012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4649
8ed79523
AS
4650 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4651 characters.
4652
7d1c3a76
AS
4653 * xterm.c (XTread_socket): Only modify handling_signal if
4654 !SYNC_INPUT. (Bug#11080)
4655
e99a9b8b
EZ
46562012-03-23 Eli Zaretskii <eliz@gnu.org>
4657
4658 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4659 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4660 when fetching a multibyte character consumes more bytes than
4661 CHAR_BYTES returns, due to unification of CJK characters in
4662 string_char. (Bug#11073)
4663
5063c0e1
TN
46642012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4665
4666 * process.c (wait_reading_process_output): Handle pty disconnect
4667 by refraining from sending oneself a SIGCHLD (bug#10933).
4668
9f851fbd
CY
46692012-03-22 Chong Yidong <cyd@gnu.org>
4670
4671 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4672
5063c0e1 4673 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4674 Mark string as coming from a prefix property.
4675 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4676 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4677
fb5b8aca
CY
46782012-03-21 Chong Yidong <cyd@gnu.org>
4679
4680 * xfaces.c (Vface_remapping_alist): Doc fix.
4681
62356a1b
EZ
46822012-03-20 Eli Zaretskii <eliz@gnu.org>
4683
4684 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4685 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4686 Doc fixes.
62356a1b 4687
025de85b
CY
46882012-03-20 Chong Yidong <cyd@gnu.org>
4689
4690 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4691 to reflect default non-nil value of redisplay-dont-pause.
4692
4827f94e
KH
46932012-03-19 Kenichi Handa <handa@m17n.org>
4694
4695 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4696 it fit in a valid range (Bug#11003).
4697
e50a24a2
EZ
46982012-03-18 Eli Zaretskii <eliz@gnu.org>
4699
4700 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4701 that is not from display property, accept the row as a "cursor
4702 row" if one of the string's character has a non-nil `cursor'
4703 property. Fixes cursor positioning when there are newlines in
4704 overlay strings, e.g. in icomplete.el. (Bug#11035)
4705
9af5ed87
PE
47062012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4707
4708 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4709
d1f55f16
CY
47102012-03-12 Chong Yidong <cyd@gnu.org>
4711
4712 * eval.c (inhibit_lisp_code): Rename from
4713 inhibit_window_configuration_change_hook; move from window.c.
4714
4715 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4716 * window.c (run_window_configuration_change_hook)
4717 (syms_of_window): Callers changed.
4718
66c5eebd
CY
47192012-03-11 Chong Yidong <cyd@gnu.org>
4720
413df973
CY
4721 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4722
66c5eebd
CY
4723 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4724
1de11f56
CY
47252012-03-10 Chong Yidong <cyd@gnu.org>
4726
4727 * frame.c (other_visible_frames): Don't assume the selected frame
4728 is visible (Bug#10955).
4729
cae07000
SM
47302012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4731
4732 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4733
89c94350
JD
47342012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4735
4736 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4737 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4738 zero (Bug#10954).
4739
999dd333
GM
47402012-03-03 Glenn Morris <rgm@gnu.org>
4741
01a6dcc8 4742 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4743
de0100f2
EZ
47442012-03-02 Eli Zaretskii <eliz@gnu.org>
4745
4746 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4747 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4748 (redisplay_window, next_element_from_string): Fix typos in
4749 comments.
3e441275
EZ
4750 (redisplay_window): Pass to move_it_vertically the margin in
4751 pixels, not in screen lines.
de0100f2 4752
96a72ee9
GM
47532012-03-02 Glenn Morris <rgm@gnu.org>
4754
4755 * buffer.c (buffer-list-update-hook): Doc fix.
4756
312508d7
EZ
47572012-02-29 Eli Zaretskii <eliz@gnu.org>
4758
4759 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4760 push_it before setting up the iterator for the first overlay
4761 string, even if we have an empty string loaded.
4762 (next_overlay_string): If there's an empty string on the iterator
4763 stack, pop the stack. (Bug#10903)
4764
27f3c637
PE
47652012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4766
4767 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4768 Suggested by Stefan Monnier in
4769 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4770 * alloc.c (widen_to_Lisp_Object): New static function.
4771 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4772 and widening them to Lisp_Objects. This would work even if
4773 USE_LSB_TAG is defined and wide integers are used, which might
4774 happen in a future version of Emacs.
4775
3c9dfce6
CY
47762012-02-25 Chong Yidong <cyd@gnu.org>
4777
fa74b241
CY
4778 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4779 Doc fix.
4780
3c9dfce6
CY
4781 * xselect.c (Fx_selection_exists_p): Doc fix.
4782 (x_clipboard_manager_save_all): Print an informative message
4783 before saving to clipboard manager.
4784
9486df08
CY
47852012-02-24 Chong Yidong <cyd@gnu.org>
4786
4787 * keyboard.c (process_special_events): Handle all X selection
4788 requests in kbd_buffer, not just the next one (Bug#8869).
4789
f01d3321
CY
47902012-02-23 Chong Yidong <cyd@gnu.org>
4791
4792 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4793 call when setting menu-bar-lines and tool-bar-lines parameters.
4794 (unwind_create_frame_1): New helper function.
4795
4796 * window.c (inhibit_window_configuration_change_hook): New var.
4797 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4798 (syms_of_window): Initialize it.
f01d3321 4799
86b847b6
CY
48002012-02-22 Chong Yidong <cyd@gnu.org>
4801
4802 * xterm.c (x_draw_image_relief): Add missing type check for
4803 Vtool_bar_button_margin (Bug#10743).
4804
a59225b1
CY
48052012-02-21 Chong Yidong <cyd@gnu.org>
4806
4807 * fileio.c (Vfile_name_handler_alist): Doc fix.
4808
4809 * buffer.c (Fget_file_buffer): Protect against invalid file
4810 handler return value.
4811
310f5bd4
PE
48122012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4813
cb3a28cc
PE
4814 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4815 when computing $valmask.
4816
310f5bd4
PE
4817 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4818 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4819 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4820 It's useless in that case, and it can cause problems on hosts
4821 that allocate halves of EMACS_INT values separately.
4822 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4823 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4824 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4825 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4826 it avoids undefined behavior on hosts where shifting right by more
4827 than the word width has undefined behavior.
4828
2375c96a
CY
48292012-02-19 Chong Yidong <cyd@gnu.org>
4830
4831 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4832 (Funhandled_file_name_directory, Ffile_name_as_directory)
4833 (Fdirectory_file_name, Fexpand_file_name)
4834 (Fsubstitute_in_file_name): Protect against invalid file handler
4835 return values (Bug#10845).
4836
3eb49e71
EZ
48372012-02-18 Eli Zaretskii <eliz@gnu.org>
4838
4839 * .gdbinit (pitx): Fix incorrect references to fields of the
4840 iterator stack.
4841
7b926f3f
CY
48422012-02-17 Chong Yidong <cyd@gnu.org>
4843
4844 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4845
11273115
PE
48462012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4847
4848 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4849 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4850
c3a70e2b
CY
48512012-02-15 Chong Yidong <cyd@gnu.org>
4852
4853 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4854 marked as special. Also, starting docstrings with * is obsolete.
4855
0ca43699
AS
48562012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4857
4858 * gnutls.c (emacs_gnutls_write): Fix last change.
4859
2e8f3c56
LI
48602012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4861
4862 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4863 send_process.
4864
af70074f
SM
48652012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4866
4867 * keymap.c (Fsingle_key_description): Handle char ranges.
4868
95986d52
CY
48692012-02-12 Chong Yidong <cyd@gnu.org>
4870
afd83bd1
CY
4871 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4872 as that creates a dangerous corner case.
4873
95986d52
CY
4874 * window.c (Fdelete_window_internal): Invalidate the mouse
4875 highlight (Bug#9904).
4876
bd7da63e
GM
48772012-02-12 Glenn Morris <rgm@gnu.org>
4878
4879 * xselect.c (Fx_own_selection_internal)
4880 (Fx_get_selection_internal, Fx_disown_selection_internal)
4881 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4882 * nsselect.m (Fx_own_selection_internal)
4883 (Fx_disown_selection_internal, Fx_selection_exists_p)
4884 (Fx_selection_owner_p, Fx_get_selection_internal):
4885 Sync docs and argument specs with the xselect.c versions.
4886
77abcbc2
LI
48872012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4888
4889 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4890
90b671e2
EZ
48912012-02-11 Eli Zaretskii <eliz@gnu.org>
4892
1c0ca0b7
EZ
4893 * w32select.c (Fx_selection_exists_p): Sync doc string and
4894 argument list with xselect.c. (Bug#10783)
4895
4896 * w16select.c (Fx_selection_exists_p): Sync doc string and
4897 argument list with xselect.c. (Bug#10783)
90b671e2 4898
49241268
GM
48992012-02-10 Glenn Morris <rgm@gnu.org>
4900
4901 * fns.c (Fsecure_hash): Doc fix.
4902
f998bbe7 49032012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4904
4905 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4906
0992bd9c
CY
49072012-02-07 Chong Yidong <cyd@gnu.org>
4908
4909 * buffer.c (Fbuffer_local_variables)
4910 (buffer_lisp_local_variables): Handle unbound vars correctly;
4911 don't let Qunbound leak into Lisp.
4912
af008560
GM
49132012-02-07 Glenn Morris <rgm@gnu.org>
4914
dd605cc4
GM
4915 * image.c (Fimagemagick_types): Doc fix.
4916
af008560
GM
4917 * image.c (imagemagick-render-type): Change it from a lisp object
4918 to an integer. Move the doc here from the lisp manual.
4919 Treat all values not equal to 0 the same.
4920
1449fa1d
CY
49212012-02-06 Chong Yidong <cyd@gnu.org>
4922
4923 * doc.c (store_function_docstring): Avoid applying docstring of
4924 alias to base function (Bug#2603).
4925
3723ec07
AS
49262012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4927
4928 * .gdbinit (pp1, pv1): Remove redundant defines.
4929 (pr): Use pp.
4930
79c1cc1e
CY
49312012-02-04 Chong Yidong <cyd@gnu.org>
4932
4933 * nsterm.m: Declare a global (Bug#10694).
4934
d7f29f8e
EZ
49352012-02-04 Eli Zaretskii <eliz@gnu.org>
4936
cae07000
SM
4937 * w32.c (get_emacs_configuration_options):
4938 Include --enable-checking, if specified, in the return value.
d7f29f8e 4939
3b95a6f9
MR
49402012-02-04 Martin Rudalics <rudalics@gmx.at>
4941
4942 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4943 after rounding frame sizes. (Bug#9723)
4944
d6fa96a6
EZ
49452012-02-04 Eli Zaretskii <eliz@gnu.org>
4946
4947 * keyboard.c (adjust_point_for_property): Don't position point
4948 before BEGV. (Bug#10696)
4949
df0b2940
PE
49502012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4951
4952 Handle overflow when computing char display width (Bug#9496).
4953 * character.c (char_width): Return EMACS_INT, not int.
4954 (char_width, c_string_width): Check for overflow when
4955 computing the width; this is possible now that individual
4956 characters can have unbounded width. Problem introduced
4957 by merge from Emacs 23 on 2012-01-19.
4958
6bee44d6
MA
49592012-02-02 Michael Albinus <michael.albinus@gmx.de>
4960
4961 * dbusbind.c (Fdbus_register_method): Mention the return value
4962 :ignore in the docstring.
4963
44f92739
GM
49642012-02-02 Glenn Morris <rgm@gnu.org>
4965
1b9f60cc
GM
4966 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4967
44f92739
GM
4968 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4969 Unconditionally set to t. (Bug#10673)
4970 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4971 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4972 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4973
c5d3843c
KH
49742012-02-02 Kenichi Handa <handa@m17n.org>
4975
4976 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4977 0, do not call append_composite_glyph.
4978
159462d4 49792012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4980
4981 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4982 NULL (Bug#6988).
4983 (x_produce_glyphs): If the component of a composition is a null
4984 string, set it->pixel_width to 1 to avoid zero-width glyph.
4985
78cef877
EZ
49862012-02-01 Eli Zaretskii <eliz@gnu.org>
4987
4988 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4989 first 2 arguments are identical. This makes inserting large
4990 output from a subprocess an order of magnitude faster on
4991 MS-Windows, where all sbrk'ed memory is always contiguous.
4992
97897668
GM
49932012-01-31 Glenn Morris <rgm@gnu.org>
4994
4995 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4996 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4997 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4998
31fd3586
GM
49992012-01-29 Glenn Morris <rgm@gnu.org>
5000
5001 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5002
0e24a8b2
CY
50032012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5004
5005 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5006
cc0adcb0
CY
50072012-01-28 Chong Yidong <cyd@gnu.org>
5008
5009 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5010
acc28cb9
CY
50112012-01-26 Chong Yidong <cyd@gnu.org>
5012
9c69cfb7
CY
5013 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5014
acc28cb9
CY
5015 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5016 repeat counts (Bug#10507).
5017
48da7392
GM
50182012-01-26 Glenn Morris <rgm@gnu.org>
5019
5020 * lread.c (syms_of_lread): Doc fix.
5021
14af5f7f
CY
50222012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5023
5024 * coding.c (encode_designation_at_bol): Change return value to
5025 EMACS_INT.
5026
0b21c100
CY
50272012-01-25 Chong Yidong <cyd@gnu.org>
5028
5029 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5030
3c2907f7
CY
50312012-01-21 Chong Yidong <cyd@gnu.org>
5032
5033 * floatfns.c (Fcopysign): Make the second argument non-optional,
5034 since nil is not allowed anyway.
5035
959ad23f
AS
50362012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5037
5038 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5039 (send_process): Likewise.
5040
34a02f46
MR
50412012-01-19 Martin Rudalics <rudalics@gmx.at>
5042
5043 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5044 (Vwindow_persistent_parameters): Do not use Qstate.
5045 Rewrite doc-strings.
34a02f46 5046
1259009a 50472012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5048
5049 * character.c (char_width): New function.
70d4fdf6
GM
5050 (Fchar_width, c_string_width, lisp_string_width):
5051 Use char_width (Bug#9496).
25ed9e61 5052
6a6ee00d
MR
50532012-01-16 Martin Rudalics <rudalics@gmx.at>
5054
5055 * window.c (Vwindow_persistent_parameters): New variable.
5056 (Fset_window_configuration, save_window_save): Handle persistent
5057 window parameters.
5058
c85efaf7
EZ
50592012-01-14 Eli Zaretskii <eliz@gnu.org>
5060
5061 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5062 thrashing the stack of the thread. (Bug#9087)
5063
5944709e
PE
50642012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5065
5066 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5067
e71f5d99
EZ
50682012-01-11 Eli Zaretskii <eliz@gnu.org>
5069
5070 * xdisp.c (rows_from_pos_range): Handle the case where the
5071 highlight ends on a newline. (Bug#10464)
5072 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5073 he end column for display of highlight that ends on a newline
5074 before a R2L line.
5075
ce316182
GM
50762012-01-11 Glenn Morris <rgm@gnu.org>
5077
5078 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5079 from load-path also when installation-directory is nil. (Bug#10208)
5080
5b43da69
GM
50812012-01-10 Glenn Morris <rgm@gnu.org>
5082
74cc8ff9
GM
5083 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5084
7d8d6e4e
GM
5085 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5086 Update template values to be closer to their typical values these days.
5b43da69 5087
a0db8d43
EZ
50882012-01-09 Eli Zaretskii <eliz@gnu.org>
5089
5090 * xdisp.c (rows_from_pos_range): Accept additional argument
5091 DISP_STRING, and accept any glyph in a row whose object is that
5092 string as eligible for mouse highlight. Fixes mouse highlight of
5093 display strings from overlays. (Bug#10464)
5094
9a0115ab 50952012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5096
b9110d6a 5097 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5098 * fileio.c (auto_saving_dir_umask): New static var.
5099 (Fmake_directory_internal): Use it.
5100 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5101 creating the directory. The old code temporarily assigns
5102 too-generous permissions to the directory.
5103 (do_auto_save_eh): Clear it.
b9110d6a 5104 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5105 that the var is always cleared.
5106
6c1bd3f3
EZ
51072012-01-07 Eli Zaretskii <eliz@gnu.org>
5108
5109 * search.c (scan_buffer): Pass character positions to
5110 know_region_cache, not byte positions. (Bug#6540)
5111
069d2b50
L
51122012-01-07 LynX <_LynX@bk.ru> (tiny change)
5113
5114 * w32.c (sys_rename): Report EXDEV when rename of a directory
5115 fails because the target is on another logical disk. (Bug#10284)
5116
75bf0d33
DB
51172012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5118
5119 * xterm.c (x_embed_request_focus): New function.
5120
5121 * xterm.h: Add prototype.
5122
5123 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5124
1c6e5a32
GM
51252012-01-05 Glenn Morris <rgm@gnu.org>
5126
5127 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5128
651e947e
EZ
51292012-01-01 Eli Zaretskii <eliz@gnu.org>
5130
5131 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5132 Load gnutls_transport_set_lowat only if GnuTLS version is below
5133 2.11.1.
5134 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5135 GnuTLS versions below 2.11.1.
5136
3778cdd8
AL
51372011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5138
5139 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5140 to the doc string advising against its use for altering the way
5141 windows are scrolled.
5142
0e5317f7
KH
51432011-12-28 Kenichi Handa <handa@m17n.org>
5144
5145 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5146 coding-system ASCII compatible only when it does not produce BOM
5147 on encoding (Bug#10383).
5148
93d5ca1f
JD
51492011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5150
5151 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5152 can scroll.
5153 (create_and_show_popup_menu): Always use menu_position_func for
5154 Gtk3 (Bug#10361).
5155
ca22b785
AS
51562011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5157
5158 * callint.c (Fcall_interactively): Don't truncate prompt string.
5159
d048e1e6
EZ
51602011-12-23 Eli Zaretskii <eliz@gnu.org>
5161
5162 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5163 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5164 resumed from there (after widening). (Bug#10360)
d048e1e6 5165
5ccaba1f
JD
51662011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5167
5168 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5169
204ee57f
JD
51702011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5171
b81d40f0
JB
5172 * nsterm.m (x_free_frame_resources):
5173 Release f->output_data.ns->miniimage.
204ee57f
JD
5174 (ns_index_color): Fix indentation. Do not retain
5175 color_table->colors[i].
5176
5177 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5178 before returning.
5179
5180 * nsfns.m (x_set_background_color): Assign return value from
5181 ns_index_color to face-background instead of NSColor*.
5182 (ns_implicitly_set_icon_type): Fix indentation.
5183 Change assignment in for loop to comparison.
5184
5185 * emacs.c (ns_pool): New variable.
5186 (main): Assign ns_pool.
5187 (Fkill_emacs): Call ns_release_autorelease_pool.
5188
5189 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5190 autorelease fdesc, release fdAttrs and tdict.
5191 (ns_get_covering_families): Release charset.
5192 (ns_findfonts): Release NSFontDescriptor created with new.
5193 (ns_uni_to_glyphs): Fix indentation.
5194 (setString): Release attrStr before assigning new value.
5195
c803b2b7
JD
51962011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5197
678f4426
JD
5198 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5199 and NS_IMPL_COCOA.
5200 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5201 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5202
cd394be1 52032011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5204
5fecd5fc
JD
5205 * nsterm.m (ns_term_init): Subscribe for notifications
5206 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5207 to method trackingNotification in EmacsMenu.
5208
5209 * nsmenu.m (trackingMenu): New variable.
3771cb17 5210 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5211 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5212 from Aquamacs (Bug#7030).
678f4426
JD
5213
52142011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5215
c803b2b7
JD
5216 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5217 (symbol_to_nsstring): Fix indentation.
5218 (ns_symbol_to_pb): New function.
cae07000
SM
5219 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5220 (Fns_rotate_cut_buffers_internal): Remove.
5221 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5222 Fns_store_cut_buffer_internal.
5223 (ns_get_foreign_selection, Fx_own_selection_internal)
5224 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5225 (Fns_get_selection_internal, Fns_store_selection_internal):
5226 Use ns_symbol_to_pb and check if return value is nil.
5227 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5228 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5229 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5230 renamed to Sns_store_selection_internal.
5231 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5232 and remove this function.
5233 (ns_handle_selection_clear): Remove, never used.
5234 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5235 here.
5236
e1b01a3a
KB
52372011-12-17 Ken Brown <kbrown@cornell.edu>
5238
5239 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5240 GID is unknown (Bug#10257).
5241
2adb6e85
PE
52422011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5243
5244 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5245 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5246 which caused a build failure on GNU/Linux IA-64. This problem was
5247 introduced by my 2011-10-07 patch.
5248
d1d7b339
JL
52492011-12-15 Juri Linkov <juri@jurta.org>
5250
5251 * image.c (imagemagick_error): New function. (Bug#10112)
5252 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5253 Use `imagemagick_error' where ImageMagick functions return
5254 `MagickFalse'.
5255 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5256 proper order.
5257
100d5755
KH
52582011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5259
5260 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5261 fill background (Bug#8992).
5262
454592a6
MR
52632011-12-13 Martin Rudalics <rudalics@gmx.at>
5264
5265 * window.c (Vwindow_combination_resize)
5266 (Vwindow_combination_limit): Use t instead of non-nil in
5267 doc-strings.
61d4b438
MR
5268 (Vrecenter_redisplay): Add first sentence of doc-string on
5269 separate line.
53524d93 5270 (Frecenter): Fix doc-string typo.
454592a6 5271
3633e3aa
KH
52722011-12-11 Kenichi Handa <handa@m17n.org>
5273
5274 * coding.c (Funencodable_char_position): Pay attention to the
5275 buffer text relocation (Bug#9389).
5276
7b9d523a 52772011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5278
7b9d523a
JD
5279 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5280 gtk_init (Bug#10100).
5281
b73189c6
EZ
52822011-12-10 Eli Zaretskii <eliz@gnu.org>
5283
5284 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5285 IT->string is nil. (Bug#10263)
5286
f7dfe5d6
JD
52872011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5288
83faebb4
JD
5289 * nsterm.h (x_free_frame_resources): Declare.
5290
f7dfe5d6
JD
5291 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5292 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5293
5294 * nsterm.h (ns_get_defaults_value): Declare.
5295
5296 * nsterm.m (ns_default): Call ns_get_defaults_value.
5297
7cd4e72c
EZ
52982011-12-09 Eli Zaretskii <eliz@gnu.org>
5299
5300 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5301 (Bug#10170)
5302
b34d7317
YM
53032011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5304
5305 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5306 that where the value of an _OBJC_* symbol points to is in the .bss
5307 section (Bug#10240).
5308
76470ad1
KH
53092011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5310
5311 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5312 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5313
745fff94
KH
53142011-12-08 Kenichi Handa <handa@m17n.org>
5315
5316 * ftfont.c (get_adstyle_property): Fix previous change
5317 (Bug#10233).
5318
6e44397c
JB
53192011-12-07 Juanma Barranquero <lekktu@gmail.com>
5320
5321 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5322 dirs from the default value of EMACSLOADPATH (bug#10208).
5323
7efa6272
GM
53242011-12-07 Glenn Morris <rgm@gnu.org>
5325
5326 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5327 installation and source directories as well. (Bug#10208)
5328
f6fc4d87
CY
53292011-12-06 Chong Yidong <cyd@gnu.org>
5330
5331 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5332
2bf26180
GM
53332011-12-06 Glenn Morris <rgm@gnu.org>
5334
5335 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5336 as an error, not just -1. (Bug#10217)
5337
3a6ad4f0
CY
53382011-12-05 Chong Yidong <cyd@gnu.org>
5339
5340 * keyboard.c (process_special_events): New function.
5341 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5342
75a3b399
PE
53432011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5344
5345 * coding.c (encode_designation_at_bol): Don't use uninitialized
5346 local variable (Bug#9318).
5347
c3c9e25e
KH
53482011-12-05 Kenichi Handa <handa@m17n.org>
5349
5350 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5351 return Qnil (Bug#8046, Bug#10193).
5352
5eb05ea3
KH
53532011-12-05 Kenichi Handa <handa@m17n.org>
5354
5355 * coding.c (encode_designation_at_bol): New args charbuf_end and
5356 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5357 (coding_set_source): Return how many bytes coding->source was
5358 relocated.
5359 (coding_set_destination): Return how many bytes
5360 coding->destination was relocated.
5361 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5362 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5363
53642011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5365
5366 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5367 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5368 macro (Bug#9318).
5369
53702011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5371
5372 The following changes are to fix Bug#9318.
5373
a79703f5 5374 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5375 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5376 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5377 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5378
7dbda6df
JB
53792011-12-05 Juanma Barranquero <lekktu@gmail.com>
5380
5381 * lisp.h (process_quit_flag): Fix external declaration.
5382
6d5eb5b0
SM
53832011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5384
5385 Don't macro-inline non-performance-critical code.
5386 * eval.c (process_quit_flag): New function.
5387 * lisp.h (QUIT): Use it.
5388
a0c3fad0
JD
53892011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5390
5391 * nsfns.m (get_geometry_from_preferences): New function.
5392 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5393
6c07aac2
AS
53942011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5395
5396 * emacs.c (Qkill_emacs): Define.
5397 (syms_of_emacs): Initialize it.
5398 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5399 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5400 (quit_throw_to_read_char): Add parameter `from_signal'.
5401 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5402 * lisp.h (QUIT): Call Fkill_emacs if requested.
5403
c052ead4
JD
54042011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5405
5406 * widget.c (update_wm_hints): Return if wmshell is null.
5407 (widget_update_wm_size_hints): New function.
5408
5409 * widget.h (widget_update_wm_size_hints): Declare.
5410
5411 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5412 widget_update_wm_size_hints (Bug#10104).
5413
9e49252b
EZ
54142011-12-03 Eli Zaretskii <eliz@gnu.org>
5415
5416 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5417 before a newline, prepare the bidi iterator for consuming the
5418 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5419 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5420
02b16839
JL
54212011-12-02 Juri Linkov <juri@jurta.org>
5422
5423 * search.c (Fword_search_regexp): New Lisp function created from
5424 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5425 (Fword_search_backward, Fword_search_forward)
5426 (Fword_search_backward_lax, Fword_search_forward_lax):
5427 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5428 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5429
0068070e
SM
54302011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5431
5432 * fileio.c (Finsert_file_contents): Move after-change-function call
5433 to before the "handled:" label, since all "goto handled" appear in
5434 cases where the *-change-functions have already been properly called
5435 (bug#10117).
5436
3360a3fc
AS
54372011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5438
5439 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5440 waiting for input. (Bug#10169)
5441
73d6c093
EZ
54422011-11-30 Eli Zaretskii <eliz@gnu.org>
5443
5444 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5445 verifies glyph row's hash code--we have just reallocated the
5446 glyphs, so their contents can be complete garbage. (Bug#10164)
5447
febe6bea
JB
54482011-11-30 Juanma Barranquero <lekktu@gmail.com>
5449
5450 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5451
801a4313
EZ
54522011-11-30 Eli Zaretskii <eliz@gnu.org>
5453
5454 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5455 attributes are tested _before_ calling verify_row_hash, to protect
5456 against GCC re-ordering of the tests. (Bug#10164)
5457
2b56b87e
JD
54582011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5459
5460 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5461
5462 * xterm.c (handle_one_xevent): Only set async_visible and friends
5463 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5464 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5465 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5466
dbf31225
PE
54672011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5468
5469 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5470 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5471 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5472 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5473 All uses changed to use GCPRO1 etc.
5474 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5475 Revert to old implementation (i.e., before 2011-03-11).
5476
1305621b
YM
54772011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5478
5479 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5480 of scroll runs so as to avoid assigning disabled bogus rows and
5481 unnecessary graphics copy operations.
5482
8c9afb46
EZ
54832011-11-27 Eli Zaretskii <eliz@gnu.org>
5484
5485 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5486 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5487 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5488 (malloc, free, realloc, calloc): Redirect to e_* only when
5489 compiling Emacs.
5490
5491 * lisp.h (GCTYPEBITS): Move before first use.
5492 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5493 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5494 this macro definition.
5495
5496 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5497 _MSC_VER.
5498
54e9e3bf
JD
54992011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5500
6d5eb5b0
SM
5501 * gtkutil.c (xg_create_frame_widgets):
5502 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5503 present with Gtk+ 2.0.
5504
83aca1cb
PE
55052011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5506
5507 * fileio.c (Finsert_file_contents): Undo previous change; see
5508 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5509
5b76caa4
PE
55102011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5511
5512 Rename locals to avoid shadowing.
5513 * fileio.c (Finsert_file_contents):
5514 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5515 * process.c (wait_reading_process_output):
5516 Rename inner 'proc' to 'p' to avoid shadowing.
5517 Indent for consistency with usual Emacs style.
5518
8c535114
EZ
55192011-11-25 Eli Zaretskii <eliz@gnu.org>
5520
5521 * xdisp.c (redisplay_window): If cursor row is not fully visible
5522 after recentering, and scroll-conservatively is set to a large
5523 number, scroll window by a few more lines to make the cursor fully
5524 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5525 (start_display): Don't move to the next line if the display should
5526 start at a newline that is part of a display vector or an overlay
5527 string. (Bug#10119)
8c535114 5528
fa4fdb5c
JL
55292011-11-24 Juri Linkov <juri@jurta.org>
5530
5531 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5532 after the `MagickPingImage' call. (Bug#10112)
5533
90ec88df
CY
55342011-11-23 Chong Yidong <cyd@gnu.org>
5535
5536 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5537
56e2e794
MR
55382011-11-23 Martin Rudalics <rudalics@gmx.at>
5539
5540 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5541 making another buffer current. (Bug#10114)
5542
b6e64c41
GM
55432011-11-23 Glenn Morris <rgm@gnu.org>
5544
5545 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5546
6b21de18
CY
55472011-11-23 Chong Yidong <cyd@gnu.org>
5548
5549 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5550 using it (Bug#5984).
5551
b12cd789
EZ
55522011-11-22 Eli Zaretskii <eliz@gnu.org>
5553
5554 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5555 and header-lines, as they don't have one computed for them.
5556 (Bug#10098)
5557
5558 * .gdbinit (prow): Make displayed values more self-explaining.
5559 Add row's hash code.
5560
261b6fd4
LMI
55612011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5562
5563 * process.c (wait_reading_process_output): Fix asynchrounous
5564 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5565 (wait_reading_process_output): Add comment and URL.
261b6fd4 5566
e7cfd277
JD
55672011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5568
5569 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5570
a9b9b7f5
CY
55712011-11-21 Chong Yidong <cyd@gnu.org>
5572
5573 * window.c (Fnext_window, Fprevious_window): Doc fix.
5574
b0d15b4f
SM
55752011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5576
5577 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5578
fe7a3057
JB
55792011-11-20 Juanma Barranquero <lekktu@gmail.com>
5580
5581 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5582
d2999b1a
MR
55832011-11-20 Martin Rudalics <rudalics@gmx.at>
5584
5585 * window.c (Fset_window_combination_limit): Rename argument
5586 STATUS to LIMIT.
5587 (Vwindow_combination_limit): Remove "status" from doc-string.
5588
d5ff9cd0
AS
55892011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5590
5591 * m/ibms390.h: Remove.
5592 * m/ibms390x.h: Don't include "ibms390.h".
5593
a5bb9bd3
SM
55942011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5595
5596 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5597 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5598
cd1181db
JB
55992011-11-20 Juanma Barranquero <lekktu@gmail.com>
5600
5601 * casetab.c (Fset_case_table):
5602 * charset.c (Fcharset_after): Fix typos.
5603
615a3b8d 56042011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5605
17e845af
PE
5606 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5607 Otherwise, valgrind does not work on some platforms.
5608 Problem reported by Andreas Schwab in
6a0bf43d
PE
5609 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5610 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5611 is set, removing the need for VIRT_ADDRESS_VARIES.
5612 (PURE_P): Use a more-efficient implementation that needs just one
5613 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5614 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5615 to 4 (xorl, subq, cmpq, setbe).
5616 * alloc.c (pure): Always extern now, since that's the
5617 VIRT_ADDR_VARIES behavior.
5618 (PURE_POINTER_P): Use a single comparison, not two, for
5619 consistency with the new puresize.h.
5620 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5621 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5622 Remove VIRT_ADDR_VARIES no longer needed.
5623
f8fe6f96
EZ
56242011-11-19 Eli Zaretskii <eliz@gnu.org>
5625
5626 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5627 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5628 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5629 behave as if the cursor position were at the window margin.
5630
5631 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5632 and the cursor position is out of bounds, behave as if the cursor
5633 position were at the window margin. (Bug#10075)
5634
df05a53c
CY
56352011-11-18 Chong Yidong <cyd@gnu.org>
5636
5637 * window.c (Fwindow_combination_limit): Make first argument
5638 non-optional, since it is meaningless for live windows like the
5639 selected window.
61ccba97 5640
2071918e
DA
56412011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5642
5643 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5644
b50a28de
SM
56452011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5646
5647 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5648 (graft_intervals_into_buffer): Simplify.
5649
015137db
EZ
56502011-11-18 Eli Zaretskii <eliz@gnu.org>
5651
5652 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5653 hash values of the two rows.
5654 (copy_row_except_pointers): Preserve the used[] arrays and the
5655 hash values of the two rows. (Bug#10035)
68c95424 5656 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5657
5658 * xdisp.c (row_hash): New function, body extracted from
5659 compute_line_metrics.
5660 (compute_line_metrics): Call row_hash, instead of computing the
5661 hash code inline.
5662
5663 * dispnew.c (verify_row_hash): Call row_hash for computing the
5664 hash code of a row, instead of duplicating code from xdisp.c.
5665
5666 * dispextern.h (row_hash): Add prototype.
5667
a2addb04
TH
56682011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5669
5670 * frame.c (delete_frame): Don't delete the terminal when the last
5671 X frame is closed if emacs is built with GTK toolkit.
5672
df85d315
JB
56732011-11-17 Juanma Barranquero <lekktu@gmail.com>
5674
5675 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5676
a0c2d0ae
MR
56772011-11-17 Martin Rudalics <rudalics@gmx.at>
5678
5679 * window.c (Vwindow_splits): Rename to
5680 Vwindow_combination_resize. Suggested by Juri Linkov.
5681 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5682 of Vwindow_splits.
5683
58179cce
JB
56842011-11-16 Juanma Barranquero <lekktu@gmail.com>
5685
7877f373
JB
5686 * nsfns.m (Fns_font_name):
5687 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5688
b6f67890
MR
56892011-11-16 Martin Rudalics <rudalics@gmx.at>
5690
5691 * window.h (window): Rename slot "nest" to "combination_limit".
5692 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5693 (Fset_window_nest): Rename to Fset_window_combination_limit.
5694 (Vwindow_nest): Rename to Vwindow_combination_limit.
5695 (recombine_windows, make_parent_window, make_window)
5696 (Fsplit_window_internal, saved_window)
5697 (Fset_window_configuration, save_window_save): Rename all
5698 occurrences of window_nest to window_combination_limit.
5699
c7015153
JB
57002011-11-15 Juanma Barranquero <lekktu@gmail.com>
5701
5702 * image.c (imagemagick_load_image): Fix typo.
5703
322ad6ec
EZ
57042011-11-14 Eli Zaretskii <eliz@gnu.org>
5705
5706 * xdisp.c (display_line): Move the call to
5707 highlight_trailing_whitespace before the call to
5708 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5709 faces of all the glyphs to compute ROW's hash value.
5710 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5711
f067b8ec
JB
57122011-11-14 Juanma Barranquero <lekktu@gmail.com>
5713
5714 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5715 just return (bug#10044).
5716
1e5b2111
EZ
57172011-11-12 Eli Zaretskii <eliz@gnu.org>
5718
7ef3cbd5
EZ
5719 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5720 with user-defined heap size. Bump the default size of the temacs
5721 heap to 27MB, to avoid memory warning when running temacs.
5722 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5723
1e5b2111
EZ
5724 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5725 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5726 (verify_row_hash) [XASSERTS]: New function.
5727 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5728 that the hash value of glyph rows is correct.
1e5b2111 5729
89d61221
MR
57302011-11-12 Martin Rudalics <rudalics@gmx.at>
5731
5732 * window.h (window): Remove splits slot.
5733 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5734 (Fdelete_other_windows_internal, make_parent_window)
5735 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5736 (Fset_window_configuration, save_window_save): Don't deal with
5737 split status of windows.
5738 (saved_window): Remove splits slot.
5739 (Vwindow_splits): Rewrite doc-string.
5740
97f18cc8
JD
57412011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5742
5743 * xfns.c (unwind_create_frame):
5744 * nsfns.m (unwind_create_frame):
5745 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5746 Vframe_list (Bug#9999).
5747
22a648b4
DA
57482011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5749
0b381c7e 5750 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5751
659afede
KH
57522011-11-11 Kenichi Handa <handa@m17n.org>
5753
5754 * callproc.c (Fcall_process): Set the member dst_multibyte of
5755 process_coding.
5756
9ac0394b
KH
57572011-11-11 Johan Bockgård <bojohan@gnu.org>
5758
5759 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5760 avoid a crash (bug#9496).
5761
2fbdc249
CY
57622011-11-09 Chong Yidong <cyd@gnu.org>
5763
5764 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5765 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5766
ac6b1f81
PE
57672011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5768
5769 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5770
09db192c
PE
57712011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5772
5773 Avoid some portability problems by eschewing 'extern inline' functions.
5774 The trivial performance wins aren't worth the portability hassles; see
5775 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5776 et seq.
5777 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5778 (window_box_width, window_box_left, window_box_left_offset)
5779 (window_box_right, window_box_right_offset): Undo previous change,
5780 by removing the "extern"s.
5781 * intervals.c (adjust_intervals_for_insertion)
5782 (adjust_intervals_for_deletion): Undo previous change,
5783 making these static again.
5784 (offset_intervals, temp_set_point_both, temp_set_point)
5785 (copy_intervals_to_string): No longer inline.
5786 * xdisp.c (window_text_bottom_y, window_box_width)
5787 (window_box_height, window_box_left_offset)
5788 (window_box_right_offset, window_box_left, window_box_right)
5789 (window_box): No longer inline.
5790
105216ed
CY
57912011-11-08 Chong Yidong <cyd@gnu.org>
5792
5793 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5794 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5795 Signal an error if not a live window.
105216ed
CY
5796 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5797 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5798
ae9e237f
JB
57992011-11-07 Juanma Barranquero <lekktu@gmail.com>
5800
5801 * lisp.h (syms_of_abbrev): Remove declaration.
5802 Reported by CHENG Gao <chenggao@royau.me>.
5803
c7aa8333
EZ
58042011-11-07 Eli Zaretskii <eliz@gnu.org>
5805
5806 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5807 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5808 of temacs in GUI mode.
5809
be7f5545
MR
58102011-11-07 Martin Rudalics <rudalics@gmx.at>
5811
5812 * window.h: Declare delete_all_child_windows instead of
5813 delete_all_subwindows.
5814 * window.c (Fwindow_nest, Fset_window_nest)
5815 (Fset_window_new_total, Fset_window_new_normal)
5816 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5817 (delete_all_subwindows): Rename to delete_all_child_windows.
5818 (Fdelete_other_windows_internal, Fset_window_configuration):
5819 Call delete_all_child_windows instead of delete_all_subwindows.
5820 * frame.c (delete_frame): Call delete_all_child_windows instead
5821 of delete_all_subwindows.
5822
ca78dc43
PE
58232011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5824
5825 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5826 This is also needed for porting to any host where GC_MARK_STACK is
5827 not GC_MAKE_GCPROS_NOOPS.
5828 (which_symbols): Use it.
5829
a0241d01
KH
58302011-11-07 Kenichi Handa <handa@m17n.org>
5831
5832 * coding.c (coding_set_destination): Check coding->src_pos only
5833 when coding->src_object is a buffer (bug#9910).
5834
5835 * process.c (send_process): Set the member src_multibyte of coding
5836 to 0 (bug#9911) when sending a unibyte text.
5837
5838 * callproc.c (Fcall_process): Set the member src_multibyte of
5839 process_coding to 0 (bug#9912).
5840
a64bfdfa 58412011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5842
5843 * xmenu.c (cleanup_widget_value_tree): New function.
5844 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5845 calling free_menubar_widget_value_tree directly (Bug#9830).
5846
cb41b32a
PE
58472011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5848
5849 Fix some portability problems with 'inline'.
5850 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5851 (window_box_width, window_box_left, window_box_left_offset)
5852 (window_box_right, window_box_right_offset): Declare extern.
5853 Otherwise, these inline functions do not conform to C99 and
5854 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5855 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5856 * intervals.c (adjust_intervals_for_insertion)
5857 (adjust_intervals_for_deletion): Now extern, because otherwise the
5858 extern inline functions 'offset_intervals' couldn't refer to it.
5859 (static_offset_intervals): Remove.
5860 (offset_intervals): Rewrite using the old contents of
5861 static_offset_intervals. The old version didn't conform to C99
5862 because an extern inline function contained a reference to an
5863 identifier with static linkage.
5864
b7041366
AS
58652011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5866
5867 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5868 GC.
5869
88a37c4d
EZ
58702011-11-06 Eli Zaretskii <eliz@gnu.org>
5871
5872 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5873 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5874 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5875 return Qleft_to_right.
5876
49745b39
CY
58772011-11-06 Chong Yidong <cyd@gnu.org>
5878
5879 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5880 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5881 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5882 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5883 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5884 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5885 (Fwindow_vscroll): Doc fix.
5886 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5887 argument, since it makes no sense to pass a live window and for
5888 consistency with window-child.
5889
1f05cd82
CS
58902011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5891
5892 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5893 support MSVC.
5894
22610910
JR
58952011-11-05 Jason Rumney <jasonr@gnu.org>
5896
5897 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5898 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5899 fonts (Bug#6029).
5900 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5901 bitwise arithmetic preventing use of unicode-sip and non-truetype
5902 opentype fonts.
5903
a06776b2
EZ
59042011-11-05 Eli Zaretskii <eliz@gnu.org>
5905
3ad924ba
EZ
5906 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5907 "emacs"-only part.
5908
a06776b2
EZ
5909 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5910 initialization code to keep similarity to xfns.c after changes
5911 from 2011-11-05.
5912
c9e7db78
JD
59132011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5914
a97f8f3f
JD
5915 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5916 (unwind_create_frame): New function (Bug#9943).
5917 (Fx_create_frame): Restructure code to be more similar to the one in
5918 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5919 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5920 Move terminal->reference_count++ just before making the frame official
5921 (Bug#9943).
5922
5923 * nsterm.m (x_free_frame_resources): New function.
5924 (x_destroy_window): Move code to x_free_frame_resources.
5925
c9e7db78 5926 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5927 (Fx_create_frame, x_create_tip_frame):
5928 Move terminal->reference_count++ just before making the frame
75f1671a 5929 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5930 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5931
a6fc3b5c
EZ
59322011-11-05 Eli Zaretskii <eliz@gnu.org>
5933
5934 Support MSVC build with newer versions of Visual Studio.
5935 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5936 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5937 nt/gmake.defs.
5938
5939 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5940 which are not supported by MSVC.
5941 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5942 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5943 bitfields.
5944 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5945 types in bitfields.
5946 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5947
5948 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5949
58179cce 59502011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5951
5952 Support MSVC build with newer versions of Visual Studio.
5953 * w32.c: Don't include w32api.h for MSVC.
5954 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5955
5956 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5957 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5958 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5959 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5960 e_* cousins.
5961 (alloca) [_MSC_VER]: Define to _alloca.
5962
5963 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5964
5965 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5966
a58c13ed
EZ
59672011-11-04 Eli Zaretskii <eliz@gnu.org>
5968
5969 * xdisp.c (note_mouse_highlight): If either of
5970 previous/next-single-property-change returns nil, treat that as
5971 the beginning or the end of the buffer. (Bug#9955)
5972
fe0b6370
JD
59732011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5974
a58c13ed 5975 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5976 label is not null (Bug#9951).
5977 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5978 may be NULL.
5979
89bd5ee1
EZ
59802011-11-04 Eli Zaretskii <eliz@gnu.org>
5981
5982 * window.c (Fwindow_body_size): Mention in the doc string that the
5983 return value is in frame's canonical units. (Bug#9949)
5984
84c3edb9
EZ
59852011-11-03 Eli Zaretskii <eliz@gnu.org>
5986
4e2fb5c7
EZ
5987 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5988
84c3edb9 5989 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5990 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5991 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5992
bc17a887
EZ
59932011-11-01 Eli Zaretskii <eliz@gnu.org>
5994
5995 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5996 Don't stop backward scan on the continuation glyph, even though
5997 its CHARPOS is positive.
6d5eb5b0
SM
5998 (mouse_face_from_buffer_pos, note_mouse_highlight):
5999 Rename cover_string to disp_string.
bc17a887 6000
4ee88440
MR
60012011-11-01 Martin Rudalics <rudalics@gmx.at>
6002
6003 * window.c (temp_output_buffer_show): Don't use
6004 Vtemp_buffer_show_specifiers.
6005 (Vtemp_buffer_show_specifiers): Remove unused variable.
6006
c2ff3c02
EZ
60072011-10-30 Eli Zaretskii <eliz@gnu.org>
6008
6009 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6010 past the beginning of the current glyph matrix.
6011
58179cce 60122011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6013
6014 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6015 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6016 HAVE_GTK3 (Bug#9869).
b77a6a7f 6017
3b574623
JD
6018 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6019 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6020
b77a6a7f
JD
6021 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6022
6023 * xterm.c: Declare x_handle_net_wm_state to return int.
6024 (handle_one_xevent): Check if we are iconified but don't have
6025 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6026 (get_current_wm_state): Return non-zero if not hidden,
6027 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6028 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6029 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6030 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6031
196e41e4
PE
60322011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6033
6034 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6035 so that this new function doesn't get optimized away by a
6036 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6037
021f2e1a
AS
60382011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6039
6040 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6041
8b058d44
EZ
60422011-10-29 Eli Zaretskii <eliz@gnu.org>
6043
6044 Fix the `xbytecode' command.
6045 * .gdbinit (xprintbytestr): New command.
b50a28de 6046 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6047 (xbytecode): Print the byte-code string as well.
6048
4452fb80
EZ
60492011-10-29 Kim Storm <storm@cua.dk>
6050
8b058d44
EZ
6051 * alloc.c (which_symbols): New function.
6052
21b72067
AS
60532011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6054
6055 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6056 line. (Bug#9903)
6057
83ed7b5c
GM
60582011-10-29 Glenn Morris <rgm@gnu.org>
6059
6060 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6061 Not clear what it was for, and it causes various bugs. (Bug#9839)
6062
5a7a728b
EZ
60632011-10-28 Eli Zaretskii <eliz@gnu.org>
6064
6065 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6066 possible random value that matches one of those tested as
6067 condition to clear the mouse face.
6068
d3d0842f
CY
60692011-10-28 Chong Yidong <cyd@gnu.org>
6070
6071 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6072
31b39d13
DN
60732011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6074
6075 * window.c (make_window): Initialize phys_cursor_on_p.
6076
9aba6043
SM
60772011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6078
6079 * lisp.h (struct Lisp_Symbol): Update comments.
6080
c20992f4
JB
60812011-10-28 Juanma Barranquero <lekktu@gmail.com>
6082
6083 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6084
db4f02f2
EZ
60852011-10-28 Eli Zaretskii <eliz@gnu.org>
6086
6087 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6088 <oslsachem@gmail.com> for helping to debug this.
6089
6090 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6091 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6092 (g_b_init_get_glyph_outline_w): New static variables.
6093 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6094 (GetGlyphOutlineW_Proc): New typedefs.
6095 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6096 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6097 New functions.
6098 (w32font_open_internal, compute_metrics):
6099 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6100 instead of calling the "wide" APIs directly.
6101
6102 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6103
6104 * w32.h (syms_of_w32font): Add prototype.
6105
87e68db4
JB
61062011-10-27 Juanma Barranquero <lekktu@gmail.com>
6107
6108 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6109 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6110 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6111 (Fmove_to_window_line): Doc fix.
6112
435c1d67
CY
61132011-10-27 Chong Yidong <cyd@gnu.org>
6114
6115 * process.c (make_process): Set gnutls_state to NULL.
6116
6117 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6118 non-NULL, regardless of GNUTLS_INITSTAGE.
6119 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6120 an error. Set process slots as soon as we allocate them.
6121
6122 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6123
9c6c6f49
CY
61242011-10-27 Chong Yidong <cyd@gnu.org>
6125
9aba6043
SM
6126 * gnutls.c (emacs_gnutls_deinit): New function.
6127 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6128 (Fgnutls_deinit, Fgnutls_boot): Use it.
6129
6130 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6131 (deactivate_process): Call emacs_gnutls_deinit.
6132
657d08d3
JB
61332011-10-27 Juanma Barranquero <lekktu@gmail.com>
6134
6135 * image.c (x_create_x_image_and_pixmap):
6136 * w32.c (sys_rename, w32_delayed_load):
6137 * w32font.c (fill_in_logfont):
6138 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6139
5430d399
JB
61402011-10-26 Juanma Barranquero <lekktu@gmail.com>
6141
6142 * w32fns.c (w32_default_color_map): New function,
6143 extracted from Fw32_default_color_map.
a7ef684b 6144 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6145
fe0055fa
PE
61462011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6147
6148 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6149
e6346438
SM
61502011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6151
6152 * keyboard.c (test_undefined): New function (bug#9751).
6153 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6154
e112cc37
ET
61552011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6156
6157 * sysdep.c (init_sys_modes): Fix the check for the controlling
6158 terminal (Bug#6649).
6159
7b5d6677
EZ
61602011-10-20 Eli Zaretskii <eliz@gnu.org>
6161
6162 * dispextern.h (struct bidi_it): New member next_en_type.
6163
6164 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6165 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6166 current character, check also for next_en_type being WEAK_EN.
6167 (bidi_resolve_weak): Don't enter the expensive loop if the current
6168 position is before next_en_pos. Record the bidi type of the first
6169 non-ET, non-BN character we find, in addition to its position.
6170 (bidi_level_of_next_char): Invalidate next_en_type when
6171 next_en_pos is over-stepped.
6172
7da0b018
PE
61732011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6174
6175 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6176 * editfns.c: Rewrite current-time-zone so that it invokes
6177 the equivalent of (format-time-string "%Z") to get the time zone name.
6178 This fixes a bug when the time zone name contains characters that
6179 need converting from the system time locale to Emacs internal format.
6180 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6181 that patch fixed format-time-string to do the conversion, but
6182 I forgot to fix current-time-zone.
6183 (format_time_string): New function, containing most of
6184 what Fformat_time_string used to contain.
6185 (Fformat_time_string): Rewrite in terms of format_time_string.
6186 This doesn't change this function's behavior.
6187 (current-time-zone): Rewrite to use format_time_string.
6188 This fixes the bug reported by Michael Schierl in
6189 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6190 Jason Rumney's 2007-06-07 change worked around this bug, but
6191 didn't fix it.
6192 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6193
8547b010
EZ
61942011-10-19 Eli Zaretskii <eliz@gnu.org>
6195
6196 * xdisp.c (start_display): If the character at POS is displayed
6197 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6198 (try_window_reusing_current_matrix): If a line ends in a display
6199 vector or the next line starts in a display vector, continue
6200 redrawing the window even though the character position of
6201 start_row was reached.
8547b010
EZ
6202 (Bug#9771, part 2)
6203
4e948d15
CY
62042011-10-18 Chong Yidong <cyd@gnu.org>
6205
6206 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6207 with nobreak-char-display too.
6208
4787455f
EZ
62092011-10-18 Eli Zaretskii <eliz@gnu.org>
6210
6211 Fix part 3 of bug#9771.
6212 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6213 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6214 non-neutral characters if the current character is a paragraph
6215 separator (a.k.a. Newline). This avoids running the same
6216 expensive loop twice, once when we consume the preceding newline
6217 and the other time when the line actually needs to be displayed.
6218 Avoid the loop when we see neutrals on the base embedding level
6219 following a character whose directionality is the same as the
6220 paragraph's. This avoids running the expensive loop when a line
6221 ends in a long sequence of neutrals, like control characters.
6222 Add assertion against STRONG_AL type. Slightly rearrange code
6223 that determines the type of a neutral given the first non-neutral
6224 that follows it.
6225 (bidi_level_of_next_char): Set next_en_pos to zero when
6226 invalidating its info.
6227
2c91f553
EZ
62282011-10-17 Eli Zaretskii <eliz@gnu.org>
6229
6230 * xdisp.c (push_display_prop): Determine whether to record string
6231 or buffer position by IT->string, not by IT->method. Allow
6232 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6233 (move_it_vertically_backward): Don't look for character position
6234 immediately after the newline when in a continuation line.
6235 (Bug#9771, part 1)
2c91f553 6236
c7b08b0d
MR
62372011-10-15 Martin Rudalics <rudalics@gmx.at>
6238
6239 * window.c (coordinates_in_window): Rewrite and delabelize
6240 vertical border check. (Bug#5357) (Bug#9618)
6241
6b02f655
SM
62422011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6243
6244 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6245 errors in XSetWindowBorder (bug#9310).
6246
81d40c92
DA
62472011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6248
6249 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6250 avoid crash when xmalloc overrun checking is enabled.
6251
d4172c3b
EZ
62522011-10-13 Eli Zaretskii <eliz@gnu.org>
6253
6254 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6255 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6256 cursor motion with <left> and <right> arrow keys.
6257
6258 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6259 some callers set that themselves.
6260
b00eea75
EZ
62612011-10-12 Eli Zaretskii <eliz@gnu.org>
6262
6263 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6264 display string and the previous row comes from the same string and
6265 is empty. (Bug#9739) (Bug#9738)
6266
8fe012c4
SM
62672011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6268
6269 * doc.c (get_doc_string): Encode file name (bug#9735).
6270
0074aef2
EZ
62712011-10-12 Eli Zaretskii <eliz@gnu.org>
6272
79beb178
EZ
6273 * bidi.c (bidi_level_of_next_char):
6274 * xdisp.c (get_visually_first_element): Remove old incorrect
6275 comments regarding the Unicode Line Separator character.
6276
0074aef2
EZ
6277 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6278
6e4b3fbe
DA
62792011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6280
6281 * alloc.c (Fgc_status): Do not access beyond zombies array
6282 boundary if nzombies > MAX_ZOMBIES.
6283 * alloc.c (dump_zombies): Add missing format specifier.
6284
0324f3af
PE
62852011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6286
b5525cac
PE
6287 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6288 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6289
0324f3af
PE
6290 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6291 Some packages use them to denote characters with modifiers.
6292
e9b5f888
AS
62932011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6294
6295 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6296 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6297 matching a pp-number. Rename parameter var to var1.
6298
127827c0
SM
62992011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6300
6301 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6302
c8fd3bd0
GM
63032011-10-08 Glenn Morris <rgm@gnu.org>
6304
6305 * callint.c (Fcall_interactively): Give a more explicit error for the
6306 'c' case with a non-character input. (Bug#8479)
6307
352ec8ff
EZ
63082011-10-08 Eli Zaretskii <eliz@gnu.org>
6309
03669ccb
EZ
6310 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6311 lines.
7061c986
EZ
6312 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6313 lines that are hscrolled on the left.
03669ccb 6314
352ec8ff
EZ
6315 * dispnew.c (buffer_posn_from_coords): Account for a possible
6316 presence of header-line. (Bug#4426)
6317
a66cfb1c
SM
63182011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6319
6b02f655
SM
6320 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6321 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6322
7c5ee88e
PE
63232011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6324
6325 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6326 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6327 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6328 this makes Emacs dump core during garbage collection on rare
6329 occasions. sizeof is obviously inferior to offsetof here, so
6330 stick with offsetof.
6331 (GC_POINTER_ALIGNMENT): New macro.
6332 (mark_memory): Omit 3rd (offset) arg; caller changed.
6333 Don't assume EMACS_INT alignment is the same as pointer alignment.
6334
df1bbe5b
SM
63352011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6336
6337 * keyboard.c (read_key_sequence_remapped): New var.
6338 (read_key_sequence): Compute remapping in the right buffer.
6339 (command_loop_1): Use read_key_sequence's remapping directly.
6340
51553db6
SM
63412011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6342
32c1fffd
SM
6343 * dired.c (file_name_completion): Don't expand file name.
6344 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6345 before checking file name handler.
6346
51553db6
SM
6347 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6348 they've been requested explicitly (bug#9591).
6349
b6bd1599 63502011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6351
6352 * keymap.c (Fsingle_key_description): Use make_specified_string
6353 instead of build_string to build string from push_key_description.
6354 (Bug#5193)
6355
f701dc2a
PE
63562011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6357
4222c55d
PE
6358 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6359 This fixes a Y2038 bug on 64-bit hosts.
6360 * buffer.c (reset_buffer):
6361 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6362 (Fclear_buffer_auto_save_failure):
6363 Use 0, not -1, to represent an unset failure time, since time_t
6364 might not be signed.
6365
f701dc2a
PE
6366 Remove dependency on glibc malloc internals.
6367 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6368 Move back here from lisp.h, but with their new implementations.
6369 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6370 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6371 * charset.c (charset_table_init): New static var.
6372 (syms_of_charset): Use it instead of xmalloc. This removes a
6373 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6374 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6375 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6376 Move back to alloc.c.
6377 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6378 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6379
9ceebf39
JD
63802011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6381
6382 * nsterm.m (windowDidResize): Call x_set_window_size only when
6383 ns_in_resize is true. Otherwise set pixelwidth/height and
6384 call change_frame_size (Bug#9628).
6385
cb993c58
PE
63862011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6387
3930c88b
PE
6388 Port --enable-checking=all to Fedora 14 x86-64.
6389 * charset.c (syms_of_charset): Also account for glibc malloc's
6390 internal overhead when calculating the initial malloc maximum.
6391
cb993c58
PE
6392 Port --enable-checking=all to Fedora 14 x86.
6393 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6394 Move to lisp.h.
6395 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6396 (overrun_check_realloc, overrun_check_free):
6397 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6398 That way, xmalloc returns a properly-aligned pointer even if
6399 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6400 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6401 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6402 into account when calculating the initial malloc maximum.
6403 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6404 Move here from alloc.c, so that charset.c can use it too.
6405 Properly align; the old code wasn't right for common 32-bit hosts
6406 when configured with --enable-checking=all.
6407 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6408 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6409
31bed486
EZ
64102011-09-29 Eli Zaretskii <eliz@gnu.org>
6411
04c70788 6412 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6413 use EDOM.
6414
fbcaa2f3
EZ
64152011-09-28 Eli Zaretskii <eliz@gnu.org>
6416
6417 * xdisp.c (compute_display_string_end): If there's no display
6418 string at CHARPOS, return -1.
6419
6420 * bidi.c (bidi_fetch_char): When compute_display_string_end
6421 returns a negative value, treat the character as a normal
6422 character not covered by a display string. (Bug#9624)
6423
a239d4e9
JB
64242011-09-28 Juanma Barranquero <lekktu@gmail.com>
6425
6426 * lread.c (Fread_from_string): Fix typo in docstring.
6427
88652fd5
EZ
64282011-09-27 Eli Zaretskii <eliz@gnu.org>
6429
6430 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6431 newline, reseat the iterator instead of bidi-iterating there one
6432 character at a time. (Bug#9610)
32c1fffd
SM
6433 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6434 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6435
ed497dd4
AS
64362011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6437
6438 * lread.c (readevalloop): Use correct code for NBSP.
6439 (read1): Likewise. (Bug#9608)
6440
b2bf61aa
MA
64412011-09-25 Michael Albinus <michael.albinus@gmx.de>
6442
6443 * dbusbind.c (Fdbus_register_signal): When service is not
6444 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6445
32bbb17c
GM
64462011-09-25 Glenn Morris <rgm@gnu.org>
6447
6448 * buffer.c (truncate-lines): Doc fix.
6449
94e0933e
CY
64502011-09-24 Chong Yidong <cyd@stupidchicken.com>
6451
6452 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6453 (Fset_window_next_buffers): Doc fix.
6454
cddde921
GM
64552011-09-24 Glenn Morris <rgm@gnu.org>
6456
6457 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6458
1260aef1
PE
64592011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6460
25b4bfa0
PE
6461 Fix minor problems found by static checking.
6462 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6463 * indent.c (Fvertical_motion): Fix == vs = typo.
6464
e3cbd34b
EZ
64652011-09-24 Eli Zaretskii <eliz@gnu.org>
6466
a66cfb1c
SM
6467 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6468 Default value is now t. Doc fix.
6bf7006f 6469
e3cbd34b 6470 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6471 logic when moving up, not only when moving down. Fix the
e3cbd34b 6472 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6473 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6474
6475 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6476 CHARPOS is covered by a display string which includes newlines.
6477 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6478 is covered by a display string with embedded newlines.
6479
a3de0cbd
MA
64802011-09-24 Michael Albinus <michael.albinus@gmx.de>
6481
6482 * dbusbind.c (Fdbus_register_signal): Add match rule to
6483 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6484 (Fdbus_register_method, Vdbus_registered_objects_table):
6485 Fix docstring.
a3de0cbd 6486
b260039d
JM
64872011-09-24 Jim Meyering <meyering@redhat.com>
6488
32c1fffd 6489 do not ignore write error for any output size
b260039d
JM
6490 The previous change was incomplete.
6491 While it makes emacs --batch detect the vast majority of stdout
6492 write failures, errors were still ignored whenever the output size is
6493 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6494 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6495 && echo FAIL: ignored write error
6496 FAIL: ignored write error
6497 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6498 && echo FAIL: ignored write error
6499 FAIL: ignored write error
6500 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6501
8eca8a7c
AS
65022011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6503
6504 * emacs.c (Fkill_emacs): In noninteractive mode exit
6505 non-successfully if a write error occurred on stdout. (Bug#9574)
6506
3341db62
EZ
65072011-09-21 Eli Zaretskii <eliz@gnu.org>
6508
6509 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6510 the xassert test.
6511
6512 * dispextern.h (struct it): Update the comment documenting what
6513 can it->OBJECT be.
6514
8c203dbf
EZ
65152011-09-20 Eli Zaretskii <eliz@gnu.org>
6516
6517 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6518 a display string, extend search for cursor position to end of row.
6519 (find_row_edges): If the row ends in a newline from a display
6520 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6521 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6522 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6523 non-empty line. Fixes confusing cursor motion with arrow keys at
6524 the beginning of a line that starts with whitespace.
8c203dbf 6525
a4824228
LMI
65262011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6527
6528 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6529 (bug#9493).
6530
33ed493b
CY
65312011-09-18 Chong Yidong <cyd@stupidchicken.com>
6532
6533 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6534 boolean (Bug#9154).
6535
56cd55c8
EZ
65362011-09-18 Eli Zaretskii <eliz@gnu.org>
6537
6538 * xdisp.c (display_line): Record maximum and minimum buffer
6539 positions even if no glyphs were produced (e.g., by a zero-width
6540 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6541 buffer positions that will be removed from the glyph row because
6542 they don't fit.
c02dcedf
EZ
6543 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6544 column is beyond frame width: don't subtract 1 "pixel" when
6545 computing width of the stretch.
3e62b7e0
EZ
6546 (reseat_at_next_visible_line_start): Undo the change made on
6547 2011-09-17 that saved paragraph information and restored it after
6548 the call to `reseat'. (Bug#9545)
56cd55c8 6549
5ed99d36 65502011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6551
6552 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6553 and turn window cursor on if cleared (Bug#9415).
6554
5ed99d36 65552011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6556
6557 * search.c (boyer_moore): Take unibyte characters from pattern
6558 literally. (Bug#9458)
6559
9bade7b2
EZ
65602011-09-18 Eli Zaretskii <eliz@gnu.org>
6561
6562 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6563
e5e9d610
PE
65642011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6565
87e4427a
PE
6566 Fix minor problem found by static checking.
6567 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6568 initialized, to pacify gcc -Wuninitialized.
6569
e5e9d610
PE
6570 * fileio.c: Report proper errno when syscall falls.
6571 (Finsert_file_contents): Save and restore errno,
6572 so that report_file_error outputs the correct diagnostic.
6573 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6574
a1674f0b
EZ
65752011-09-18 Eli Zaretskii <eliz@gnu.org>
6576
6577 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6578
fbfb6dd4
EZ
65792011-09-17 Eli Zaretskii <eliz@gnu.org>
6580
6581 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6582 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6583
bb187662
EZ
65842011-09-17 Eli Zaretskii <eliz@gnu.org>
6585
1137e8b8 6586 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6587 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6588
6589 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6590 (bidi_find_paragraph_start): Search back for paragraph beginning
6591 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6592 (bidi_move_to_visually_next): Only trigger paragraph-related
6593 computations when the last character is a newline or at EOB, not
6594 just any NEUTRAL_B. (Bug#9470)
6595
bb187662
EZ
6596 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6597 truncated lines if point is covered by a display string. (Bug#9524)
6598
2e621251
PE
65992011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6600
6601 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6602 (cons_to_x_long): New function.
6603 (lisp_data_to_selection_data): Use it. Correct the test for
6604 short-versus-long data; it was negated. Break out of vector
6605 loop, for efficiency, when a long datum is discovered.
6606
91a15bc6
SM
66072011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6608
6609 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6610
b41c3a35
EZ
66112011-09-16 Eli Zaretskii <eliz@gnu.org>
6612
6613 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6614 GCC PR/17406) by declaring this function with external scope.
6615
7812ba2d
PE
66162011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6617
6618 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6619 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6620
cf7edc2a
AS
66212011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6622
6623 * editfns.c (Fformat): Correctly handle text properties on "%%".
6624
bd01620e
EZ
66252011-09-15 Eli Zaretskii <eliz@gnu.org>
6626
6627 * xterm.c (x_draw_composite_glyph_string_foreground):
6628 * w32term.c (x_draw_composite_glyph_string_foreground):
6629 * term.c (encode_terminal_code):
6630 * composite.c (composition_update_it, get_composition_id):
6631 * xdisp.c (get_next_display_element)
6632 (fill_composite_glyph_string): Add comments about special meaning
6633 of TAB characters in a composition.
6634
a02719a3
PE
66352011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6636
6637 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6638 This occurs when processing a multibyte format.
6639 Problem reported by Wolfgang Jenker.
a02719a3 6640
72589a3c
JB
66412011-09-15 Johan Bockgård <bojohan@gnu.org>
6642
6643 * xdisp.c (try_cursor_movement): Only check for exact match if
6644 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6645
1c14176c
PE
66462011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6647
6648 Remove unused external symbols.
6649 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6650 * xdisp.c (calc_pixel_width_or_height): Now static.
6651 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6652 * indent.c (check_display_width):
6653 * w32term.c: Fix comment to match code.
6654 * xterm.c, xterm.h (x_catching_errors): Remove.
6655
d2eea5b5
PE
66562011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6657
6658 * xselect.c: Use signed conversions more consistently (Bug#9498).
6659 (selection_data_to_lisp_data): Assume incoming selection data are
6660 signed integers, not unsigned. This is to be consistent with
6661 outgoing selection data, which was modified to use signed integers
6662 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6663 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6664 expects long, not unsigned long.
6665
46888499
EZ
66662011-09-14 Eli Zaretskii <eliz@gnu.org>
6667
6668 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6669 computation of loop end. Reported by Johan Bockgård
6670 <bojohan@gnu.org>.
6671
ef8ef9fb
CY
66722011-09-13 Chong Yidong <cyd@stupidchicken.com>
6673
6674 * frame.c (Fother_visible_frames_p): Function deleted.
6675
fa819fed
EZ
66762011-09-12 Eli Zaretskii <eliz@gnu.org>
6677
6678 * indent.c (compute_motion): Process display vector front to back
6679 rather than the other way around. (Bug#2496)
6680
2ba8e008
SM
66812011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6682
6683 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6684
20f53c69
CY
66852011-09-11 Chong Yidong <cyd@stupidchicken.com>
6686
6687 * minibuf.c (Fread_from_minibuffer): Doc fix.
6688
d562d7a4
EZ
66892011-09-11 Eli Zaretskii <eliz@gnu.org>
6690
6691 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6692 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6693
1c4d7f3d
LMI
66942011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6695
6696 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6697 value for non-existent files.
6698
b885bf36
EZ
66992011-09-11 Eli Zaretskii <eliz@gnu.org>
6700
6701 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6702 set its "size" to -1. This will set the modtime_size field of
6703 the corresponding buffer to -1, which is what
6704 verify-visited-file-modtime expects for files that do not exist.
6705 (Bug#9139)
6706
6612f0bf
PE
67072011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6708
6709 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6710 here ...
6711 * lisp.h: ... from here. push_key_description is no longer
6712 defined in keyboard.c, so its declaration should not be in
6713 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6714 logically belongs with push_key_description.
6715
dfb3f755
PE
67162011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6717
6718 * buffer.h: Include <sys/types.h> instead of <time.h>.
6719 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6720 Problem reported by Herbert J. Skuhra.
6721
3134906c
LMI
67222011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6723
6724 * xml.c (parse_region): Make the parsing work for
6725 non-comment-starting XML files again (bug#9144).
6726
8d903f4e
AS
67272011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6728
6729 * image.c (gif_load): Fix calculation of bottom and right corner.
6730 (Bug#9468)
6731
80ad64f4
EZ
67322011-09-10 Eli Zaretskii <eliz@gnu.org>
6733
6734 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6735 redisplay in small windows.
6736
208a048d
EZ
67372011-09-09 Eli Zaretskii <eliz@gnu.org>
6738
6739 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6740
9b1c252e
MR
67412011-09-08 Martin Rudalics <rudalics@gmx.at>
6742
6743 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6744 Operate on live windows only.
6745
2949f33b
JB
67462011-09-08 Juanma Barranquero <lekktu@gmail.com>
6747
6748 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6749
e08dcafd
EZ
67502011-09-07 Eli Zaretskii <eliz@gnu.org>
6751
6752 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6753 only under bidi iteration.
6754
115b96bd
JD
67552011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6756
6757 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6758
c8199d0f
PE
67592011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6760
6761 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6762 Without this fix, the command to link temacs failed due to an
6763 undefined symbol __builtin_isnan. This is because
6764 /usr/include/iso/math_c99.h #defines isnan(x) to
6765 __builtin_isnan(x), but the bundled gcc, which identifies itself
6766 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6767 a __builtin_isnan.
6768 * floatfns.c (isnan): #undef, and then #define to a clone of
6769 what's in data.c.
6770 (Fisnan): Always define, since it's always available now.
6771 (syms_of_floatfns): Always define isnan at the Lisp level.
6772
e39b275c 67732011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6774
6775 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6776
b2db44d9 67772011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6778
f4af5137 6779 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6780 The previous code assumed that file offsets (off_t values) fit in
6781 EMACS_INT variables, which is not true on typical 32-bit hosts.
6782 The code messed up by falsely reporting buffer overflow in cases
6783 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6784 when "big" contains more than 2**29 bytes, even though this
6785 inserts just one byte and does not overflow the buffer.
6786 (Finsert_file_contents): Store file offsets as off_t
6787 values, not as EMACS_INT values. Check for overflow when
6788 converting between EMACS_INT and off_t. When checking for
6789 buffer overflow or for overlap, take the offsets into account.
6790 Don't use EMACS_INT for small values where int suffices.
6791 When checking for overlap, fix a typo: ZV was used where
6792 ZV_BYTE was intended.
6793 (Fwrite_region): Don't assume off_t fits into 'long'.
6794 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6795
ecfc0a49
MA
67962011-09-05 Michael Albinus <michael.albinus@gmx.de>
6797
6798 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6799
6511acf2 68002011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6801
0999621a 6802 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6803
6804 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6805 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6806 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6807 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6808 (modify_event_symbol): Do not assume that the length of
6809 name_alist_or_stem is safe to alloca and fits in int.
6810 (Fexecute_extended_command): Likewise for function name and binding.
6811 (Frecursion_depth): Wrap around reliably on integer overflow.
6812 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6813 since some callers pass EMACS_INT values.
6814 (Fsingle_key_description): Don't crash if symbol name contains more
6815 than MAX_ALLOCA bytes.
6816 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6817 (get_minibuffer): Arg is now EMACS_INT, not int.
6818 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6819 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6820 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6821
2be7d702
PE
6822 * dbusbind.c (signature_cat): New function.
6823 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6824 Do not overrun buffer; instead, report string overflow.
6825
9d1df220
PE
6826 * dispnew.c (add_window_display_history): Don't overrun buffer.
6827 Truncate instead; this is OK since it's just a log.
6828
33ef5c64
PE
6829 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6830 even if the time zone offset is outlandishly large.
6831 Don't mishandle offset == INT_MIN.
6832
66c6fdd5
PE
6833 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6834 when creating daemon; the previous buffer-overflow check was incorrect.
6835
d749b01b
PE
6836 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6837 which has the guts of the old verror function.
6838
b5cd1905
PE
6839 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6840 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6841
6e1a67fb
PE
6842 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6843 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6844 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6845 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6846 length of string rather than counting it via multiple sprintfs;
6847 that's simpler and more reliable.
c21721cc
PE
6848 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6849 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6850 sprintf, in case result does not fit in int.
6851
c57b67fc
PE
6852 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6853 (fontset_from_font): Print it.
6854
8a401434
PE
6855 * frame.c (tty_frame_count): Now printmax_t, not int.
6856 (make_terminal_frame, set_term_frame_name): Print it.
6857 (x_report_frame_params): In X, window IDs are unsigned long,
6858 not signed long, so print them as unsigned.
6859 (validate_x_resource_name): Check for implausibly long names,
6860 and don't assume name length fits in 'int'.
6861 (x_get_resource_string): Don't blindly alloca invocation name;
6862 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6863 not fit in int.
6864
6e1a67fb
PE
6865 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6866 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6867 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6868
0df02bf3
PE
6869 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6870 Use esprintf, not sprintf, in case result does not fit in int.
6871
48e30793
PE
6872 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6873 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6874 it as a large positive number.
6875 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6876 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6877
a66ff6d8
PE
6878 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6879 in case result does not fit in int.
6880
aca216ff
PE
6881 * print.c (float_to_string): Detect width overflow more reliably.
6882 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6883 buffer overrun. Don't assume list length fits in 'int'. Treat
6884 print length of 0 as 0, not as infinity; to be consistent with other
6885 uses of print length in this function. Don't overflow print length
6886 index. Don't assume hash table size fits in 'long', or that
6887 vectorlike size fits in 'unsigned long'.
6888
31c286f7
PE
6889 * process.c (make_process): Use printmax_t, not int, to format
6890 process-name gensyms.
6891
55e5faa1
PE
6892 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6893
80f2e268
PE
6894 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6895 to avoid potential buffer overrun.
6896
670741ab
PE
6897 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6898 if X resource line is longer than 512 bytes.
6899
b7163a50
PE
6900 * xfns.c (x_window): Make sprintf buffer a bit bigger
6901 to avoid potential buffer overrun.
6902
ae58ff1f
PE
6903 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6904
c43c8a6a
PE
6905 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6906
3f8236f4
PE
69072011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6908
53e9fe90 6909 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6910 Without these, Emacs silently mishandles large integers sometimes.
6911 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6912 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6913
6511acf2
PE
6914 * xdisp.c (try_window_id): Check Emacs fixnum range before
6915 converting to 'int'.
806add1d 6916
6511acf2 6917 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6918 Check that an Emacs fixnum is in range before assigning it to 'int'.
6919 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6920 values converted from Emacs fixnums.
6921 (Frecenter): Don't wrap around a line count if it is out of 'int'
6922 range; instead, treat it as an extreme value.
6923 (Fset_window_configuration, compare_window_configurations):
6924 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6925
6511acf2
PE
6926 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6927 that can exceed INT_MAX. Check that EMACS_INT value is in range
6928 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6929 (match_limit): Don't assume that a fixnum can fit in 'int'.
6930
6511acf2 6931 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6932 exceed INT_MAX.
6933
6511acf2 6934 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6935 (Fvertical_motion): Don't wrap around LINES values that don't fit
6936 in 'int'. Instead, treat them as extreme values. This is good
6937 enough for windows, which can't have more than INT_MAX lines anyway.
6938
fcb901a7
LMI
69392011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6940
0f2f6b6d
LMI
6941 * Require libxml/parser.h to avoid compilation warning.
6942
fcb901a7
LMI
6943 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6944
6945 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6946 since this reportedly can destroy thread storage.
6947
6e20a0d4
CY
69482011-08-30 Chong Yidong <cyd@stupidchicken.com>
6949
6950 * syntax.c (find_defun_start): Update all cache variables if
6951 exiting early (Bug#9401).
6952
148ae00e
EZ
69532011-08-30 Eli Zaretskii <eliz@gnu.org>
6954
f6cfbd8f
EZ
6955 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6956
148ae00e
EZ
6957 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6958 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6959 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6960
6961 * term.c (tty_append_glyph): New function.
6962 (produce_stretch_glyph): Static function and its prototype deleted.
6963
a66cfb1c
SM
6964 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6965 Add prototypes.
148ae00e 6966
c4a07a4c
PE
69672011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6968
6969 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6970 when checking :margin (Bug#9390).
6971 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6972 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6973 so that the name doesn't mislead. All uses changed.
6974
6bc8cd65
JB
69752011-08-28 Johan Bockgård <bojohan@gnu.org>
6976
6977 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6978 set_tty_hooks.
6979
dca4927e
EZ
69802011-08-27 Eli Zaretskii <eliz@gnu.org>
6981
6982 * xdisp.c (move_it_to): Don't bail out early when reaching
6983 position beyond to_charpos, if we are scanning backwards.
6984 (move_it_vertically_backward): When DY == 0, make sure we get to
6985 the first character in the line after the newline.
6986
f2cad773
PE
69872011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6988
6989 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6990 (ccl_driver): Do not generate an out-of-range pointer.
6991 (Fccl_execute_on_string): Remove unnecessary check for
6992 integer overflow, noted by Stefan Monnier in
6993 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6994 Remove a FIXME that didn't need fixing.
6995 Simplify the newly-introduced buffer reallocation code.
6996
0cae2cdb
JB
69972011-08-27 Juanma Barranquero <lekktu@gmail.com>
6998
6999 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7000
5fc295a4 70012011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7002
70c60eb2 7003 Integer and memory overflow issues (Bug#9196).
726e0ab1 7004
d31850da
PE
7005 * doc.c (get_doc_string): Rework so that
7006 get_doc_string_buffer_size is the actual buffer size, rather than
7007 being 1 less than the actual buffer size; this makes xpalloc more
7008 convenient.
7009
a69fbedb
PE
7010 * image.c (x_allocate_bitmap_record, cache_image):
7011 * xselect.c (Fx_register_dnd_atom):
7012 Simplify previous changes by using xpalloc.
7013
fe5c5d37
PE
7014 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7015 since either will do and ptrdiff_t is convenient with xpalloc.
7016
0065d054
PE
7017 * charset.c (charset_table_size)
7018 (struct charset_sort_data.priority): Now ptrdiff_t.
7019 (charset_compare): Don't overflow if priorities differ greatly.
7020 (Fsort_charsets): Don't assume list length fits in int.
7021 Check for size-calculation overflow when allocating sort data.
7022 (syms_of_charset): Allocate an initial charset table that is
7023 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7024
7025 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7026
7027 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7028 The actual value is always <= INT_MAX, and leaving it unsigned made
7029 overflow checking harder.
7030
7031 * dispextern.h (struct glyph_matrix.rows_allocated)
7032 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7033 with xpalloc. The values are still always <= INT_MAX.
7034
7035 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7036
7037 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7038 (SAFE_NALLOCA): New macro.
7039
7040 * region-cache.c (struct boundary.pos, find_cache_boundary)
7041 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7042 (set_cache_region, invalidate_region_cache)
7043 (revalidate_region_cache, know_region_cache, region_cache_forward)
7044 (region_cache_backward, pp_cache):
7045 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7046 so that ptrdiff_t * can be passed to xpalloc.
7047 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7048 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7049 (pp_cache): Don't assume cache_len fits in int.
7050 * region-cache.h: Adjust extern decls to match.
7051
7052 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7053 EMACS_INT, since either will do, for xpalloc.
7054
7055 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7056 (xnmalloc, xnrealloc, xpalloc): New functions.
7057
726e0ab1
PE
7058 * bidi.c (bidi_shelve_header_size): New constant.
7059 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7060 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7061
51f30bc5 7062 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7063 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7064 (overlay_strings):
7065 Don't update size of array until after memory allocation succeeds,
7066 because xmalloc/xrealloc may not return.
0065d054
PE
7067 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7068 now that we have proper integer overflow checking.
7069 (record_overlay_string, overlay_strings): Catch overflows when
7070 calculating size of overlay_str_buf.
726e0ab1 7071
0065d054
PE
7072 * callproc.c (Fcall_process): Check for size overflow when
7073 calculating size of args2.
7074 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7075 Normally we prefer signed values, but sticking with ptrdiff_t would
7076 require adding more-complicated checks.
726e0ab1
PE
7077
7078 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7079 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7080 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7081 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7082
7083 * character.c (Fstring): Check for size-calculation overflow.
7084
7085 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7086 unnecessary integer overflow. Check for size overflow.
7087 (encode_coding_object): Don't update size until xmalloc succeeds.
7088
7089 * composite.c (get_composition_id): Check for overflow in glyph
7090 length calculations.
7091
7092 Integer and memory overflow fixes for display code.
7093 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7094 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7095 (scrolling_window): Check for overflow in size calculations.
7096 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7097 Don't assume glyph table len fits in int.
7098 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7099 (row_table_size): Now ptrdiff_t, not int.
7100 (scrolling_window): Avoid overflow in size calculations.
7101 Don't update size until allocation succeeds.
7102 * fns.c (concat): Check for overflow in size calculations.
7103 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7104 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7105 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7106
7107 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7108 (get_doc_string): Check for size calculation overflow.
7109 Don't update size until allocation succeeds.
7110 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7111 EMACS_INT, where ptrdiff_t will do.
7112 (Fsubstitute_command_keys): Check for string overflow.
7113
7114 * editfns.c (set_time_zone_rule): Don't assume environment length
7115 fits in int.
7116 (message_length): Now ptrdiff_t, not int.
7117 (Fmessage_box): Don't update size until allocation succeeds.
7118 Don't assume message length fits in int.
7119 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7120
0065d054
PE
7121 * emacs.c (main): Do not reallocate argv, since there is a null at
7122 the end that can be overwritten, and this way there's no need to
7123 worry about size-calculation overflow.
7124 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7125
7126 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7127 alloc succeeds.
7128 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7129
7130 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7131 (x_set_scroll_bar_width, x_figure_window_size):
7132 Check for integer overflow.
7133 (x_set_alpha): Do not assume XINT fits in int.
7134
7135 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7136 This is for the members text_lines, text_cols, total_lines, total_cols,
7137 where the system imposes an 'int' limit.
7138
7139 * fringe.c (Fdefine_fringe_bitmap):
7140 Don't update size until alloc works.
7141
7142 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7143 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7144
7145 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7146 Check for size-calculation overflow.
7147 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7148 do, as we prefer signed integers.
7149 (id_to_widget.max_size, id_to_widget.used)
7150 (xg_store_widget_in_map, xg_remove_widget_from_map)
7151 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7152 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7153 Use and return ptrdiff_t, not int.
7154 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7155 * gtkutil.h: Change prototypes to match the above.
7156
7157 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7158 are duplicate now that they've been promoted to lisp.h.
7159 (x_allocate_bitmap_record, x_alloc_image_color)
7160 (make_image_cache, cache_image, xpm_load):
7161 Don't update size until alloc is done.
7162 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7163 (x_detect_edges):
3256efce 7164 Check for size calculation overflow.
726e0ab1
PE
7165 (ct_colors_allocated_max): New constant.
7166 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7167 overflow.
3256efce 7168
726e0ab1
PE
7169 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7170 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7171 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7172 Use ptrdiff_t, not int, to count maps.
7173 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7174 calculations. Don't update size until allocation succeeds.
7175 Redo calculations to avoid overflow.
726e0ab1
PE
7176 * keyboard.h: Change prototypes to match the above.
7177
7178 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7179 to count maps.
7180 (current_minor_maps): Check for size calculation overflow.
7181 * keymap.h: Change prototypes to match the above.
7182
7183 * lread.c (read1, init_obarray): Don't update size until alloc done.
7184
7185 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7186 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7187
726e0ab1
PE
7188 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7189 Now ptrdiff_t, not int.
7190 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7191 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7192
7193 * process.c (Fnetwork_interface_list): Check for overflow
7194 in size calculation.
7195
7196 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7197
7198 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7199 overflow. Don't bother calling xmalloc when xrealloc will do.
7200
7201 * search.c (Freplace_match): Check for size calculation overflow.
7202 (Fset_match_data): Don't assume list lengths fit in 'int'.
7203
7204 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7205 for command line length. Do not attempt to address one before the
7206 beginning of an array, as that's not portable.
7207
7208 * term.c (max_frame_lines): Remove; unused.
7209 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7210 not int.
7211 (encode_terminal_code, calculate_costs): Check for size
7212 calculation overflow.
7213 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7214 table lengths and related sizes. Don't update size until alloc
7215 done. Redo calculations to avoid overflow.
7216 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7217
7218 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7219 subtracting pointers.
7220 (gobble_line): Check for overflow more carefully. Don't update size
7221 until alloc done.
7222
7223 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7224 Don't update size until alloc done.
7225 Redo size calculations to avoid overflow.
7226 Check for size calculation overflow.
0065d054 7227 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7228
7229 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7230 Use ptrdiff_t, not int, for sizes.
7231 (store_mode_line_noprop_char): Don't update size until alloc done.
7232
0065d054
PE
7233 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7234 Use ptrdiff_t, not int, for sizes.
7235 (Finternal_make_lisp_face, cache_face):
7236 Check for size calculation overflow.
7237 (cache_face): Treat size calculation overflows as if they were
7238 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7239
7240 * xfns.c (x_encode_text, x_set_name_internal)
7241 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7242 sizes, since they can exceed INT_MAX in size. Check for size
7243 calculation overflow.
7244
0065d054
PE
7245 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7246 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7247 Don't update size until alloc done.
7248
0065d054 7249 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7250 as sprintf is limited to int lengths.
1d526e2f 7251
252c5ee1
PE
7252 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7253 (X_LONG_MIN): New macros.
864d7ce7
PE
7254 Use them to make the following changes clearer.
7255 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7256 This change doesn't affect the value now, but it may help remind
7257 future maintainers not to raise the value too much later.
7258 (SELECTION_QUANTUM): Remove, replacing with ...
7259 (selection_quantum): ... new function, which avoids overflow.
7260 All uses changed.
7261 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7262 assumption that selection length fits in 'int'.
7263 (x_reply_selection_request, x_handle_selection_request)
7264 (x_get_window_property, receive_incremental_selection)
7265 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7266 (lisp_data_to_selection_data, clean_local_selection_data):
7267 Use ptrdiff_t, not int, to record length of selection.
7268 (x_reply_selection_request, x_get_window_property)
7269 (receive_incremental_selection, x_property_data_to_lisp):
7270 Redo calculations to avoid overflow.
7271 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7272 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7273 something.
7274 (x_get_window_property, receive_incremental_selection)
7275 (lisp_data_to_selection_data, x_property_data_to_lisp):
7276 Check for size-calculation overflow.
7277 (x_get_window_property, receive_incremental_selection)
7278 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7279 Don't store size until memory allocation succeeds.
7280 (x_get_window_property): Plug memory leak on memory exhaustion.
7281 Don't double-block input; malloc is safe here. Don't assume 2**34
7282 - 4 fits in unsigned long. Add an xassert to check
7283 XGetWindowProperty overflow. Be more careful about overflow
7284 calculations, and distinguish size from memory overflow better.
7285 (receive_incremental_selection): When tracing, don't assume
7286 unsigned int is less than INT_MAX.
7287 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7288 harmful) conversions of unsigned short to int.
7289 (lisp_data_to_selection_data): Don't assume that integers
7290 in the range -65535 through -1 fit in an X unsigned short.
7291 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7292 result parameters unless successful. Rely on cons_to_unsigned
7293 to report problems with elements; the old code wasn't right anyway.
7294 (x_check_property_data): Check for int overflow; we cannot use
7295 a wider type due to X limits.
7296 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7297
726e0ab1 7298 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7299
0065d054
PE
7300 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7301 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7302 (x_color_cells): Don't store size until memory allocation succeeds.
7303 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7304 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7305 (x_term_init): Don't assume length fits in int (sprintf is limited
7306 to int size).
bc18e09d 7307
ebfa62c0
PE
7308 Use ptrdiff_t for composition IDs.
7309 * character.c (lisp_string_width):
7310 * composite.c (composition_table_size, n_compositions)
7311 (get_composition_id, composition_gstring_from_id):
7312 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7313 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7314 * window.c (Frecenter):
7315 Use ptrdiff_t, not int, for composition IDs.
7316 * composite.c (get_composition_id): Check for integer overflow.
7317 * composite.h: Adjust prototypes to match the above changes.
7318
d3411f89
PE
7319 Use ptrdiff_t for hash table indexes.
7320 * category.c (hash_get_category_set):
7321 * ccl.c (ccl_driver):
7322 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7323 * coding.c (coding_system_charset_list, detect_coding_system):
7324 * coding.h (struct coding_system.id):
7325 * composite.c (get_composition_id, gstring_lookup_cache):
7326 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7327 * image.c (xpm_get_color_table_h):
7328 * lisp.h (hash_lookup, hash_put):
7329 * minibuf.c (Ftest_completion):
7330 Use ptrdiff_t for hash table indexes, not int (which is too
7331 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7332 32-bit --with-wide-int hosts).
7333
e097a6fa
PE
7334 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7335 Add a FIXME comment about memory leaks.
7336 (syms_of_charset): Don't assume xmalloc returns.
7337
5637687f
PE
7338 Don't assume that stated character widths fit in int.
7339 * character.c (Fchar_width, c_string_width, lisp_string_width):
7340 * character.h (CHAR_WIDTH):
7341 * indent.c (MULTIBYTE_BYTES_WIDTH):
7342 Use sanitize_char_width to avoid undefined and/or bad behavior
7343 with outlandish widths.
a66cfb1c 7344 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7345 now that we have two such functions. All uses changed.
7346 (sanitize_char_width): New inline function.
7347
a2271ba2
PE
7348 Don't assume that tab-width fits in int.
7349 * character.h (sanitize_width): New inline function.
7350 (SANE_TAB_WIDTH): New macro.
7351 (ASCII_CHAR_WIDTH): Use it.
7352 * indent.c (sane_tab_width): Remove. All uses replaced by
7353 SANE_TAB_WIDTH (current_buffer).
7354 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7355
18c52557
PE
7356 * fileio.c: Integer overflow issues with file modes.
7357 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7358
caeeedc1
PE
7359 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7360 Remove unreachable code.
7361 (read_hex, load_charset_map_from_file): Check for integer overflow.
7362
6df6ae42 7363 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7364 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7365 (x_send_scroll_bar_event): Likewise. Check that the size does not
7366 exceed limits imposed by XClientMessageEvent, as well as the usual
7367 ptrdiff_t and size_t limits.
7368
b13995db
PE
7369 * keyboard.c: Overflow, signedness and related fixes.
7370 (make_lispy_movement): Use same integer type in forward decl
7371 that is used in the definition.
7372 (read_key_sequence, keyremap_step):
7373 Change bufsize argument back to int, undoing my 2011-03-30 change.
7374 We prefer signed types, and int is wide enough here.
7375 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7376 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7377 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7378 length, not size_t. Use ptrdiff_t for index, not int.
7379 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7380 possibility of integer overflow.
7381
13464394
PE
7382 Overflow, signedness and related fixes for images.
7383
7384 * dispextern.h (struct it.stack[0].u.image.image_id)
7385 (struct_it.image_id, struct image.id, struct image_cache.size)
7386 (struct image_cache.used, struct image_cache.ref_count):
7387 * gtkutil.c (update_frame_tool_bar):
7388 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7389 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7390 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7391 * nsmenu.m (update_frame_tool_bar):
7392 * xdisp.c (calc_pixel_width_or_height):
7393 * xfns.c (image_cache_refcount):
7394 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7395 on typical 64-bit hosts.
7396
7397 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7398 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7399 Omit unnecessary casts to int.
7400 (parse_image_spec): Check that integers fall into 'int' range
7401 when the callers expect that.
7402 (image_ascent): Redo ascent calculation to avoid int overflow.
7403 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7404 (lookup_image): Remove unnecessary tests.
7405 (xbm_image_p): Locals are now of int, not EMACS_INT,
7406 since parse_image_check makes sure they fit into int.
7407 (png_load, gif_load, svg_load_image):
7408 Prefer int to unsigned where either will do.
7409 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7410 old tiff_error_handler and tiff_warning_handler.
7411 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7412 stack buffer overflows. It uses only the features of vsnprintf
7413 that are common to both POSIX and native Microsoft.
7414 (tiff_error_handler, tiff_warning_handler): Use it.
7415 (tiff_load, gif_load, imagemagick_load_image):
7416 Don't assume :index value fits in 'int'.
7417 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7418 (imagemagick_load_image): Check that crop parameters fit into
7419 the integer types that MagickCropImage accepts. Don't assume
7420 Vimagemagick_render_type has a nonnegative value. Don't assume
7421 size_t fits in 'long'.
7422 (gs_load): Use printmax_t to print the widest integers possible.
7423 Check for integer overflow when computing image height and width.
7424
c11821d4
EZ
74252011-08-26 Eli Zaretskii <eliz@gnu.org>
7426
7427 * xdisp.c (redisplay_window): Don't force window start if point
7428 will be invisible in the resulting window. (Bug#9324)
7429
0c95fcf7
EZ
74302011-08-25 Eli Zaretskii <eliz@gnu.org>
7431
7432 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7433 the display spec is of the form `(space ...)'.
7434 (handle_display_spec): Return the value returned by
7435 handle_single_display_spec, not just 1 or zero.
7436 (handle_single_display_spec): If the display spec is of the form
7437 `(space ...)', and specifies display in the text area, return 2
7438 rather than 1.
fee65a97 7439 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7440 accurately, and prefer exact match for point under bidi.
7441 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7442
7443 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7444 into disp_prop; all users changed.
7445
7446 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7447 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7448 for the text covered by the display property.
7449
e4ed06f1
CY
74502011-08-25 Chong Yidong <cyd@stupidchicken.com>
7451
7452 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7453 Change return value to nil.
7454 (Frecord_buffer): Delete unused function.
7455
f67cdd7f
EZ
74562011-08-24 Eli Zaretskii <eliz@gnu.org>
7457
5980d4c6
EZ
7458 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7459 buffers, return left-to-right.
8610fe8b
EZ
7460 (set_cursor_from_row): Consider candidate row a win if its glyph
7461 represents a newline and point is on that newline. Fixes cursor
7462 positioning on the newline at EOL of R2L text within L2R
7463 paragraph, and vice versa.
7464 (try_cursor_movement): Check continued rows, in addition to
7465 continuation rows. Fixes unwarranted scroll when point enters a
7466 continued line of R2L text within an L2R paragraph, or vice versa.
7467 (cursor_row_p): Consider the case of point being equal to
7468 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7469 from the end of a short line to the beginning of a continued line
7470 of R2L text within L2R paragraph.
7471 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7472 composed characters.
5980d4c6 7473
f67cdd7f
EZ
7474 * bidi.c (bidi_check_type): Use xassert.
7475 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7476 members.
7477
bca633fb
EZ
74782011-08-23 Eli Zaretskii <eliz@gnu.org>
7479
7480 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7481 a character.
7482
4a5885a7
CY
74832011-08-23 Chong Yidong <cyd@stupidchicken.com>
7484
7485 * nsfont.m (ns_otf_to_script): Fix typo.
7486
0902a04e
KH
74872011-08-22 Kenichi Handa <handa@m17n.org>
7488
7489 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7490 extra slot even if the purpose is char-code-property-table.
7491
1a2e6670
EZ
74922011-08-23 Eli Zaretskii <eliz@gnu.org>
7493
8ddde651
EZ
7494 * xdisp.c (redisplay_window): When computing centering_position,
7495 account for the height of the header line. (Bug#8874)
7496
425cc014
EZ
7497 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7498 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7499 candidate is selected by the mouse, and that candidate has a
7500 composed character under the mouse.
7501
1a2e6670
EZ
7502 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7503 coordinates reported by pos-visible-in-window-p for a composed
7504 character in column zero.
7505
8b76d6f8
SM
75062011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7507
7508 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7509
dac347dd
EZ
75102011-08-22 Eli Zaretskii <eliz@gnu.org>
7511
7512 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7513 consider it a hit if to_charpos is anywhere in the range of the
7514 composed buffer positions.
7515
e013fb34
CY
75162011-08-22 Chong Yidong <cyd@stupidchicken.com>
7517
7518 * image.c (gif_load): Don't assume that each subimage has the same
7519 dimensions as the base image. Handle disposal method that is
7520 "undefined" by the gif spec (Bug#9335).
7521
bd1ba3e8
CY
75222011-08-20 Chong Yidong <cyd@stupidchicken.com>
7523
7524 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7525 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7526
54a1215b
EZ
75272011-08-19 Eli Zaretskii <eliz@gnu.org>
7528
823564e5
EZ
7529 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7530 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7531 from an Org mode buffer to a Speedbar frame.
7532
54a1215b
EZ
7533 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7534 a composition, take its buffer position from IT->cmp_it.charpos.
7535 Fixes cursor positioning at the beginning of a line that begins
7536 with a composed character.
7537
9778ebcc
EZ
75382011-08-18 Eli Zaretskii <eliz@gnu.org>
7539
0be6ee06
EZ
7540 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7541 character bidirectional type, use STRONG_L instead. Fixes crashes
7542 in a buffer produced by `describe-categories'.
7543
9778ebcc
EZ
7544 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7545 members before the level stack, so they would be saved and
7546 restored when copying iterator state. Fixes incorrect reordering
7547 around TABs covered by display properties.
7548
156bffbe
AS
75492011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7550
6b02f655 7551 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7552
72ad093b
CY
75532011-08-17 Chong Yidong <cyd@stupidchicken.com>
7554
7555 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7556 (internal_condition_case_2, internal_condition_case_n):
7557 Remove unnecessary aborts (Bug#9081).
72ad093b 7558
35774242
EZ
75592011-08-17 Eli Zaretskii <eliz@gnu.org>
7560
7561 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7562 has no `load' handler, try opening the file locally. (Bug#9311)
7563
db76dd85
KB
75642011-08-16 Ken Brown <kbrown@cornell.edu>
7565
7566 * gmalloc.c: Expand comment.
7567
b215eee5
EZ
75682011-08-16 Eli Zaretskii <eliz@gnu.org>
7569
7570 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7571 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7572
a4579d33
KB
75732011-08-16 Ken Brown <kbrown@cornell.edu>
7574
7575 Fix memory allocation problems in Cygwin build (Bug#9273).
7576
7577 * unexcw.c ( __malloc_initialized): Declare external variable.
7578 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7579
8b76d6f8
SM
7580 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7581 New variables.
a4579d33
KB
7582 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7583 dumped emacs.
7584 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7585 in the static heap.
7586 [CYGWIN] (special_realloc): New function.
7587 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7588 requests to realloc storage in the static heap.
7589
3ebec551
PE
75902011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7591
7592 * bidi.c (bidi_initialize): Remove unused local.
7593
9fd8be00
EZ
75942011-08-15 Eli Zaretskii <eliz@gnu.org>
7595
6b02f655
SM
7596 * bidimirror.h:
7597 * biditype.h: Remove file.
7598 * makefile.w32-in ($(BLD)/bidi.$(O)):
7599 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7600
7601 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7602
7603 * chartab.c: Improve commentary for the uniprop_table API.
7604
32413314
EZ
7605 * bidi.c (bidi_paragraph_init): Support zero value of
7606 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7607 (bidi_initialize): Use uniprop_table instead of including
7608 biditype.h and bidimirror.h.
32413314 7609
9fd8be00
EZ
7610 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7611 coordinates of the iterator when restoring from ppos_it.
7612 (Bug#9296)
7613
5cf2b69b
KH
76142011-08-14 Kenichi Handa <handa@m17n.org>
7615
7616 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7617 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7618
daf17d00
EZ
76192011-08-14 Eli Zaretskii <eliz@gnu.org>
7620
7621 * xdisp.c (move_it_in_display_line_to): Don't invoke
7622 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7623 ppos_it. Fixes vertical cursor motion when line beginning is
7624 covered by an image. (Bug#9296)
7625
08e3161a
JD
76262011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7627
7628 * nsterm.h (ns_run_ascript): Declare.
7629 (NSAPP_DATA2_RUNASSCRIPT): Define.
7630
7631 * nsfns.m (as_script, as_result, as_status): New static variables.
7632 (ns_run_ascript): New function.
5e617bc2 7633 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7634 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7635 the event loop. Get status from as_status (Bug#7276).
7636
7637 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7638 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7639 the event loop (Bug#7276).
7640
a3720aa2
AS
76412011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7642
7643 * gnutls.c (QCgnutls_bootprop_priority)
7644 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7645 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7646 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7647 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7648 (QCgnutls_bootprop_verify_hostname_error)
7649 (QCgnutls_bootprop_callbacks_verify): Rename from
7650 Qgnutls_bootprop_..., all uses changed.
7651
7652 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7653 uses changed.
7654
0a0d27fb
PE
76552011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7656
19d5c50c
PE
7657 * xfaces.c (Qframe_set_background_mode): Now static.
7658 * dispextern.h (Qframe_set_background_mode): Remove decl.
7659
0a0d27fb
PE
7660 * process.c (Fnetwork_interface_info): Declare local only if needed.
7661
377538cb
JD
76622011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7663
7664 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7665 (Fnetwork_interface_list): Allocate in increments of bytes instead
7666 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7667 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7668 sockaddr.
7669 (struct ifflag_def): notrailers is smart on OSX.
7670 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7671 Get hardware address with getifaddrs if available.
7672
08fff70c
EZ
76732011-08-12 Eli Zaretskii <eliz@gnu.org>
7674
7675 * xdisp.c (iterate_out_of_display_property): xassert that
7676 IT->position is set to within IT->object's boundaries. Break from
7677 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7678 when IT->position is set up wrongly due to some bug.
7679 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7680 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7681 entry. Force push_it to save on the stack the current
7682 buffer/string position, to be restored by pop_it. Fix flags in
7683 the iterator structure wrt the object coming from a display
7684 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7685 properties. (Bug#9284)
7686
7be1c708 76872011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7688
7be1c708
CY
7689 * fontset.c (fontset_get_font_group): Add proper type checks.
7690 (Bug#9172)
aac0c6e3 7691
7be1c708 76922011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7693
7be1c708
CY
7694 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7695 and LC_VERSION_MIN_MACOSX.
7696 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7697 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7698
97bb72a6
EZ
76992011-08-08 Eli Zaretskii <eliz@gnu.org>
7700
7701 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7702 no-display-properties-and-no-overlays under bidi display.
7703 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7704 properties and overlays.
97bb72a6 7705
d5617611
CY
77062011-08-08 Chong Yidong <cyd@stupidchicken.com>
7707
37e11a63
CY
7708 * editfns.c (Fset_time_zone_rule): Document relationship with the
7709 setenv function.
7710
d5617611
CY
7711 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7712 the font entity extracted from the cache (Bug#8109).
7713
58872834
CY
77142011-08-07 Chong Yidong <cyd@stupidchicken.com>
7715
7716 * composite.c (autocmp_chars): Don't reset point. That is done by
7717 restore_point_unwind (Bug#5984).
7718
75bfc667
JL
77192011-08-07 Juri Linkov <juri@jurta.org>
7720
7721 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7722 to show the arg `TIME' instead of `TIMEVAL'.
7723
d1410150
EZ
77242011-08-06 Eli Zaretskii <eliz@gnu.org>
7725
7726 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7727 display property strides EOL and includes a newline, as in
7728 longlines-mode. (Bug#9254)
75b771e4
EZ
7729 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7730 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7731
7732 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7733 is non-zero, even if the data buffer is NULL. Fixes a crash in
7734 vertical-motion with longlines-mode. (Bug#9254)
7735
35928349
EZ
77362011-08-05 Eli Zaretskii <eliz@gnu.org>
7737
ec7cc85b
EZ
7738 * bidi.c <bidi_cache_total_alloc>: Now static.
7739 (bidi_initialize): Initialize bidi_cache_total_alloc.
7740
8b76d6f8 7741 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7742 cache. (Bug#9221)
7743
7744 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7745 amount allocated this far in `bidi_cache_total_alloc'.
7746 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7747 non-zero, only free the data buffer without restoring the cache
7748 contents. All callers changed.
7749
7750 * dispextern.h (bidi_unshelve_cache): Update prototype.
7751
7752 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7753 (move_it_in_display_line, move_it_to)
7754 (move_it_vertically_backward, move_it_by_lines): Replace the call
7755 to xfree to an equivalent call to bidi_unshelve_cache.
7756 (move_it_in_display_line_to): Fix logic of returning
412b6358 7757 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7758
e2e2423b
EZ
77592011-08-05 Eli Zaretskii <eliz@gnu.org>
7760
7761 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7762 came from a string character with a `cursor' property. (Bug#9229)
7763
ae9e757a
JD
77642011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7765
7766 * Makefile.in (LIB_PTHREAD): New variable.
7767 (LIBES): Add LIB_PTHREAD (Bug#9216).
7768
7769 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7770 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7771
213bd7f2
AS
77722011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7773
6b02f655 7774 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7775
99aaf75f
JD
77762011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7777
7778 * xterm.c (x_find_topmost_parent): New function.
7779 (x_set_frame_alpha): Find topmost parent window with
7780 x_find_topmost_parent and set the property there also (bug#9181).
7781 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7782
c74e9d86
PE
77832011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7784
7785 * callproc.c (Fcall_process): Avoid vfork clobbering
7786 the local vars buffer, coding_systems, current_dir.
7787
640c8776
SM
77882011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7789
7790 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7791
f26d0e4c
PE
77922011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7793
8a10d76c
PE
7794 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7795 so that it is not optimized away.
7796
f26d0e4c
PE
7797 * xdisp.c (compute_display_string_pos): Remove unused local.
7798
55439c61
EZ
77992011-08-02 Eli Zaretskii <eliz@gnu.org>
7800
7801 Fix slow cursor motion and scrolling in large buffers with
7802 selective display, like Org Mode buffers. (Bug#9218)
7803
7804 * dispextern.h (struct bidi_it): New member disp_prop_p.
7805
7806 * xdisp.c: Remove one-slot cache of display string positions.
7807 (compute_display_string_pos): Accept an additional argument
5e617bc2 7808 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7809 for a display string or property. If found, set DISP_PROP_P
7810 non-zero.
7811
7812 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7813 DISP_PROP_P, and pass it to compute_display_string_pos.
7814 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7815 non-zero. All callers of bidi_fetch_char changed.
7816
fb33fa43
SM
78172011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7818
7819 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7820
b099e063
DM
78212010-12-03 Don March <don@ohspite.net>
7822
7823 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7824 last character M-[char] is translated to ESC [char] (bug#7541).
7825
5cc7f7af
KH
78262011-08-02 Kenichi Handa <handa@m17n.org>
7827
d0fffa3f 7828 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7829
7830 * chartab.c (uniprop_table): Make it non-static.
7831
525d5e6e
EZ
78322011-08-01 Eli Zaretskii <eliz@gnu.org>
7833
7834 * xdisp.c (forward_to_next_line_start): Accept additional argument
7835 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7836 on the newline.
7837 (reseat_at_next_visible_line_start): Use the bidi iterator state
7838 returned by forward_to_next_line_start to restore the state of
7839 it->bidi_it after backing up to previous newline. (Bug#9212)
7840
31011111
AS
78412011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7842
7843 * regex.c (re_comp): Protoize.
7844 (re_exec): Fix return type.
7845 (regexec): Fix type of `ret'. (Bug#9203)
7846
476371c4
PE
78472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7848
e5d76069
PE
7849 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7850 This is needed if max-image-size is a floating-point number.
7851
9a79b20c
AS
78522011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7853
7854 * print.c (print_object): Print empty symbol as ##.
7855
7856 * lread.c (read1): Read ## as empty symbol.
7857
d8c2fa78
AA
78582011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7859
7860 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7861 setting frame foreground color (Bug#9175).
7862 (x_set_background_color): Likewise.
7863
ffe57a7a
AA
7864 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7865 contents (Bug#9176).
7866 (EmacsTooltip -init): Remove bezels and add shadows to
7867 tooltip windows.
7868
bf3492a5
AA
7869 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7870 or scroll bar (Bug#8470).
7871
d55e9c53
AA
7872 * nsfont.m (nsfont_open): Remove assignment to voffset and
7873 unnecessary vars hshink, expand, hd, full_height, min_height.
7874 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7875
7876 * nsterm.h (nsfont_info): Remove voffset field.
7877
d8c2fa78 78782011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7879
7880 Implement strike-through and overline on NextStep (Bug#8863).
7881
7882 * nsfont.m (nsfont_open): Use underline position provided by font,
7883 instead of hard-coded value of 2.
7884 (nsfont_draw): Call ns_draw_text_decoration instead.
7885
7886 * nsterm.h: Add declaration for ns_draw_text_decoration.
7887
7888 * nsterm.m (ns_draw_text_decoration): New function for drawing
7889 underline, overline, and strike-through.
7890 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7891 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7892 accommodate underlining, etc.
4843aac3 7893
4cc60b9b
EZ
78942011-07-28 Eli Zaretskii <eliz@gnu.org>
7895
bc7ece87
EZ
7896 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7897 default.
4cc60b9b 7898
476371c4
PE
78992011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7900
66606eea
PE
7901 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7902 Without this fix, if a signal arrives just after memory fills up,
7903 'malloc' might be invoked reentrantly.
7904
476371c4
PE
7905 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7906 In other words, assume that every image size is allowed, on non-X
7907 hosts. This assumption is probably wrong, but it lets Emacs compile.
7908
f3fcc40d
AS
79092011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7910
7911 * regex.c (re_iswctype): Convert return values to boolean.
7912
350c992f
EZ
79132011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7914
7915 * xdisp.c (compute_display_string_pos): Don't use cached display
7916 string position if the buffer had its restriction changed.
7917 (Bug#9184)
7918
5266b4bb
PE
79192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7920
7921 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7922
2573a837 79232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7924
41f55ccd 7925 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7926
39e378da
PE
7927 * bidi.c: Integer size and overflow fixes.
7928 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7929 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7930 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7931 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7932 (bidi_find_other_level_edge):
7933 Use ptrdiff_t instead of EMACS_INT where either will do.
7934 This works better on 32-bit hosts configured --with-wide-int.
7935 (bidi_cache_ensure_space): Check for size-calculation overflow.
7936 Use % rather than repeated addition, for better worst-case speed.
7937 Don't set bidi_cache_size until after xrealloc returns, because it
7938 might not return.
7939 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7940 (bidi_cache_ensure_space): Also check that the bidi cache size
7941 does not exceed that of the largest Lisp string or buffer. See Eli
7942 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7943
5e927815
PE
7944 * alloc.c (__malloc_size_t): Remove.
7945 All uses replaced by size_t. See Andreas Schwab's note
7946 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7947
ca4aa935
PE
7948 * image.c: Improve checking for integer overflow.
7949 (check_image_size): Assume that f is nonnull, since
7950 it is always nonnull in practice. This is one less thing to
7951 worry about when checking for integer overflow later.
7952 (x_check_image_size): New function, which checks for integer
7953 overflow issues inside X.
7954 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7955 This removes the need for a memory_full check.
7956 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7957 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7958 (xbm_read_bitmap_data): Change locals back to 'int', since
7959 their values must fit in 'int'.
7960 (xpm_load_image, png_load, tiff_load):
7961 Invoke x_create_x_image_and_pixmap earlier,
7962 to avoid much needless work if the image is too large.
7963 (tiff_load): Treat overly large images as if
7964 x_create_x_image_and_pixmap failed, not as malloc failures.
7965 (gs_load): Use x_check_image_size.
7966
5f8f9cc2
PE
7967 * gtkutil.c: Omit integer casts.
7968 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7969 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7970
5adf60bc
PE
7971 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7972
c8907a93
PE
7973 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7974 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7975 would wrongly return t on a 64-bit host.
7976
e3c25c68
PE
7977 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7978 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7979 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7980 and therefore cause GCC to emit a bogus diagnostic in some cases.
7981
3f791afe
PE
7982 * image.c: Integer signedness and overflow and related fixes.
7983 This is not an exhaustive set of fixes, but it's time to
7984 record what I've got.
7985 (lookup_pixel_color, check_image_size): Remove redundant decls.
7986 (check_image_size): Don't assume that arbitrary EMACS_INT values
7987 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7988 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7989 (tiff_load, imagemagick_load_image):
7990 Check for overflow in size calculations.
7991 (x_create_x_image_and_pixmap): Remove unnecessary test for
7992 xmalloc returning NULL; that can't happen.
7993 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7994 (xpm_color_bucket): Use better integer hashing function.
7995 (xpm_cache_color): Don't possibly over-allocate memory.
7996 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7997 (gif_memory_source):
7998 Use ptrdiff_t, not int or size_t, to record sizes.
7999 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8000 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8001 either works, as we prefer signed integers.
8002 (tiff_read_from_memory, tiff_write_from_memory):
8003 Return tsize_t, not size_t, since that's what the TIFF API wants.
8004 (tiff_read_from_memory): Don't fail simply because the read would
8005 go past EOF; instead, return a short read.
8006 (tiff_load): Omit no-longer-needed casts.
8007 (Fimagemagick_types): Don't assume size fits into 'int'.
8008
3cc5a532
PE
8009 Improve hashing quality when configured --with-wide-int.
8010 * fns.c (hash_string): New function, taken from sxhash_string.
8011 Do not discard information about ASCII character case; this
8012 discarding is no longer needed.
8013 (sxhash-string): Use it. Change sig to match it. Caller changed.
8014 * lisp.h: Declare it.
8015 * lread.c (hash_string): Remove, since we now use fns.c's version.
8016 The fns.c version returns a wider integer if --with-wide-int is
8017 specified, so this should help the quality of the hashing a bit.
8018
b312a492
PE
8019 * emacs.c: Integer overflow minor fix.
8020 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8021 Define only if GNU_LINUX.
8022 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8023
dfd153ae
PE
8024 * dispnew.c: Integer signedness and overflow fixes.
8025 Remove unnecessary forward decls, that were a maintenance hassle.
8026 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8027 All uses changed.
8028 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8029 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8030 (prepare_desired_row, line_draw_cost):
8031 Use int, not unsigned, where either works.
8032 (save_current_matrix, restore_current_matrix):
8033 Use ptrdiff_t, not size_t, where either works.
8034 (init_display): Check for overflow more accurately, and without
8035 relying on undefined behavior.
8036
a81d11a3
PE
8037 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8038 Remove, replacing with the new symbols in lisp.h. All uses changed.
8039 * fileio.c (make_temp_name):
8040 * filelock.c (lock_file_1, lock_file):
8041 * xdisp.c (message_dolog):
8042 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8043 Use pMd etc. instead.
8044 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8045 replacing the pWIDE etc. symbols removed from editfns.c.
8046
3300e6fd
PE
8047 * keyboard.h (num_input_events): Now uintmax_t.
8048 This is (very slightly) less likely to mess up due to wraparound.
8049 All uses changed.
8050
fd05c7e9
PE
8051 * buffer.c: Integer signedness fixes.
8052 (alloc_buffer_text, enlarge_buffer_text):
8053 Use ptrdiff_t rather than size_t when either will do, as we prefer
8054 signed integers.
8055
903fe15d
PE
8056 * alloc.c: Integer signedness and overflow fixes.
8057 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8058 (__malloc_size_t): Default to size_t, not to int.
8059 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8060 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8061 Prefer ptrdiff_t to size_t when either would do, as we prefer
8062 signed integers.
8063 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8064 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8065 Now const. Initialize with values that are in range even if char
8066 is signed.
8067 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8068 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8069 These functions do the right thing with sizes > 2**32.
8070 (check_depth): Now ptrdiff_t, not int.
8071 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8072 Adjust to new way of storing sizes. Check for size overflow bugs
8073 in rest of code.
8074 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8075 slightly wrong anyway, as it missed one instance of
8076 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8077 (refill_memory_reserve): Omit needless cast to size_t.
8078 (mark_object_loop_halt): Mark as externally visible.
8079
ac82cc6a
PE
8080 * xselect.c: Integer signedness and overflow fixes.
8081 (Fx_register_dnd_atom, x_handle_dnd_message):
8082 Use ptrdiff_t, not size_t, since we prefer signed.
8083 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8084 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8085 x_dnd_atoms_size and x_dnd_atoms_length.
8086
c2d1e36d
PE
8087 * doprnt.c: Prefer signed to unsigned when either works.
8088 * eval.c (verror):
8089 * doprnt.c (doprnt):
8090 * lisp.h (doprnt):
8091 * xdisp.c (vmessage):
8092 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8093 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8094 prefer signed arithmetic to avoid comparison confusion.
8095 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8096 but is a bit tricky.
8097
0e926e56
PE
8098 Assume freestanding C89 headers, string.h, stdlib.h.
8099 * data.c, doprnt.c, floatfns.c, print.c:
8100 Include float.h unconditionally.
8101 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8102 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8103 * regex.c: Likewise for stddef.h, string.h.
8104 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8105 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8106 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8107 (STDC_HEADERS): Remove obsolete defines.
8108 * sysdep.c: Include limits.h unconditionally.
8109
9cfdb3ec
PE
8110 Assume support for memcmp, memcpy, memmove, memset.
8111 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8112 * regex.c (memcmp, memcpy):
8113 Remove; we assume C89 now.
8114
8115 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8116 (__malloc_safe_bcopy): Remove; no longer needed.
8117
cf950e6b 8118 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8119 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8120 well either way, and we prefer signed to unsigned.
8121
dbf38e02
LMI
81222011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8123
8124 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8125 closes the connection while we're reading (bug#9182).
8126
d6f0886c 81272011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8128
d6f0886c
JD
8129 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8130 are specified (Bug#9168).
24e0f6b1 8131
2eb1f9e6
PE
81322011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8133
8134 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8135 Found by GCC static checking and --with-wide-int on a 32-bit host.
8136
22381272 81372011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8138
8139 * xdisp.c (compute_display_string_pos): Fix logic of caching
8140 previous display string position. Initialize cached_prev_pos to
8141 -1. Fixes slow-down at the beginning of a buffer.
8142
f25e39b4
EZ
81432011-07-24 Eli Zaretskii <eliz@gnu.org>
8144
8145 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8146 for attrs[LFACE_FONTSET_INDEX].
8147
04c4b52e
PE
81482011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8149
8150 * xml.c (parse_region): Remove unused local
8151 that was recently introduced.
8152
c1734fbd
EZ
81532011-07-23 Eli Zaretskii <eliz@gnu.org>
8154
be18c5a5
EZ
8155 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8156 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8157
c1734fbd
EZ
8158 * xdisp.c (move_it_in_display_line_to): Record the best matching
8159 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8160 exit if none of the characters scanned was an exact match.
8161 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8162 when exact match is impossible due to invisible text, and the
8163 lines are truncated.
8164
a258d627
JD
81652011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8166
8167 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8168 for OSX >= 10.7.
8169
b6d5a689
EZ
81702011-07-22 Eli Zaretskii <eliz@gnu.org>
8171
0f74f785
EZ
8172 Fix a significant slow-down of cursor motion with C-n, C-p,
8173 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8174 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8175 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8176 (next_element_from_buffer): Call compute_stop_pos_backwards to
8177 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8178 base_level_stop.
8179 (reseat): Don't look for prev_stop, as that could mean a very long
8180 run.
8181 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8182 <cached_disp_overlay_modiff>: Cache for last found display string
8183 position.
551918c1 8184 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8185 about the same buffer in the same area of character positions, and
8186 the buffer wasn't changed since the time the display string
8187 position was cached.
551918c1 8188
b2d0c91a
EZ
81892011-07-22 Eli Zaretskii <eliz@gnu.org>
8190
8191 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8192 is an integer, which is important for empty lines. (Bug#9149)
8193
043604ee
CY
81942011-07-22 Chong Yidong <cyd@stupidchicken.com>
8195
8196 * frame.c (Fmodify_frame_parameters): In tty case, update the
8197 default face if necessary (Bug#4238).
8198
da4adb04
CY
81992011-07-21 Chong Yidong <cyd@stupidchicken.com>
8200
8201 * editfns.c (Fstring_to_char): No need to explain what a character
8202 is in the docstring (Bug#6576).
8203
9abd0532
LMI
82042011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8205
8206 * xml.c (parse_region): Make sure we always return a tree.
8207
36881d16
HK
82082011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8209
8210 * xml.c (parse_region): If a document contains only comments,
8211 return that, too.
8212
1e98674d
LMI
82132011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8214
8215 * xml.c (make_dom): Return comments, too.
8216
590bd467
PE
82172011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8218
8219 Port to OpenBSD.
8220 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8221 and the surrounding thread.
8222 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8223 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8224 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8225 timer goes off.
8226 * s/openbsd.h (BROKEN_SIGIO): Define.
8227 * unexelf.c (unexec) [__OpenBSD__]:
8228 Don't update the .mdebug section of the Alpha COFF symbol table.
8229
f41628b2
LMI
82302011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8231
8232 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8233 (bug#8460).
8234
b59b67c5
PE
82352011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8236
15e3a074
PE
8237 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8238 This fixes some race conditions on the permissions of any newly
8239 created file.
8240
41bed37d
PE
8241 * alloc.c (valid_pointer_p): Use pipe, not open.
8242 This fixes some permissions issues when debugging.
8243
b59b67c5
PE
8244 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8245 If fchown fails to set both uid and gid, try to set just gid,
8246 as that is sometimes allowed. Adjust the file's mode to eliminate
8247 setuid or setgid bits that are inappropriate if fchown fails.
8248
925a6be7
SM
82492011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8250
8251 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8252 to compare Lisp_Objects.
8253 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8254 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8255 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8256
52968808
AS
82572011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8258
0a6a104b
AS
8259 * lread.c (read_integer): Unread even EOF character.
8260 (read1): Likewise. Properly record start position of symbol.
8261
52968808
AS
8262 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8263 symbol character follows.
8264
9e381cdd
PE
82652011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8266
8267 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8268 This works around a problem with the previous change to Fcopy_file.
8269 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8270 and without this change, GCC might complain about discarding
8271 fchown's return value.
8272
b5641435
JB
82732011-07-16 Juanma Barranquero <lekktu@gmail.com>
8274
8275 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8276
a8031457
PE
82772011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8278
8279 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8280
dd889327
LMI
82812011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8282
750c33f7
LMI
8283 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8284 it's used from the C level.
8285
dd889327
LMI
8286 * process.c: Use the same condition for POLL_FOR_INPUT in both
8287 keyboard.c and process.c (bug#1858).
8288
87e86684
LM
82892011-07-09 Lawrence Mitchell <wence@gmx.li>
8290
8291 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8292 (Fgnutls_boot): Use it.
8293
64348f40
AS
82942011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8295
8296 * doc.c (Fsubstitute_command_keys): Revert last change.
8297
1d698799
LMI
82982011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8299
f863868c
LMI
8300 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8301 quotes the next character, and doesn't affect other longer
8302 sequences (bug#8935).
8303
1d698799
LMI
8304 * lread.c (syms_of_lread): Clarify that is isn't only
8305 `eval-buffer' and `eval-defun' that's affected by
8306 `lexical-binding' (bug#8460).
8307
aa4b6df6
EZ
83082011-07-15 Eli Zaretskii <eliz@gnu.org>
8309
8310 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8311 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8312
5d856da6
PE
83132011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8314
ad6042bb
PE
8315 Fix minor problems found by static checking.
8316 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8317 (elsz): Now a signed constant, not a size_t var. We prefer signed
8318 types to unsigned, to avoid integer comparison confusion. Without
8319 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8320 "cannot optimize loop, the loop counter may overflow", a symptom
8321 of the confusion.
f00bbb22 8322 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8323 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8324
6468f31c
LMI
83252011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8326
49080b10
LMI
8327 * search.c (Fre_search_backward): Mention `case-fold-search' in
8328 all the re_search_* functions (bug#8138).
8329
6468f31c
LMI
8330 * keyboard.c (Fopen_dribble_file): Document when the file is
8331 closed (bug#8056).
8332
c965adc5
EZ
83332011-07-14 Eli Zaretskii <eliz@gnu.org>
8334
df9733bf
EZ
8335 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8336 bidi_cache_idx.
8337
0bb23927
EZ
8338 Support bidi reordering of display and overlay strings.
8339 * xdisp.c (compute_display_string_pos)
8340 (compute_display_string_end): Accept additional argument STRING.
8341 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8342 (reseat_to_string): Initialize bidi_it->string.s and
8343 bidi_it->string.schars.
8344 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8345 NULL (avoids a crash in bidi_paragraph_init).
8346 Initialize itb.string.lstring.
0bb23927
EZ
8347 (init_iterator): Call bidi_init_it only of a valid
8348 buffer position was specified. Initialize paragraph_embedding to
8349 L2R.
8350 (reseat_to_string): Initialize the bidi iterator.
8351 (display_string): If we need to ignore text properties of
8352 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8353 original value of -1 will not work with bidi.)
8354 (compute_display_string_pos): First arg is now struct
8355 `text_pos *'; all callers changed. Support display properties on
8356 Lisp strings.
8357 (compute_display_string_end): Support display properties on Lisp
8358 strings.
8359 (init_iterator, reseat_1, reseat_to_string): Initialize the
8360 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8361 when iterating on a string not from display properties).
640c8776
SM
8362 (compute_display_string_pos, compute_display_string_end):
8363 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8364 arrow keys.
8365 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8366 base_level_stop; instead, set base_level_stop to BEGV.
8367 Fixes crashes in vertical-motion.
0bb23927
EZ
8368 (next_element_from_buffer): Improve commentary for when
8369 the iterator is before prev_stop.
8370 (init_iterator): Initialize bidi_p from the default value of
8371 bidi-display-reordering, not from buffer-local value. Use the
8372 buffer-local value only if initializing for buffer iteration.
8373 (handle_invisible_prop): Support invisible properties on strings
8374 that are being bidi-reordered.
8375 (set_iterator_to_next): Support bidi reordering of C strings and
8376 Lisp strings.
8377 (next_element_from_string): Support bidi reordering of Lisp
8378 strings.
8379 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8380 (display_string): Support display of R2L glyph rows.
8381 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8382 (init_iterator): Don't initialize it->bidi_p for strings
8383 here.
8384 (reseat_to_string): Initialize it->bidi_p for strings here.
8385 (next_element_from_string, next_element_from_c_string)
8386 (next_element_from_buffer): Add xassert's for correspondence
8387 between IT's object being iterated and it->bidi_it.string
8388 structure.
8389 (face_before_or_after_it_pos): Support bidi iteration.
8390 (next_element_from_c_string): Handle the case of the first string
8391 character that is not the first one in the visual order.
8392 (get_visually_first_element): New function, refactored from common
8393 parts of next_element_from_buffer, next_element_from_string, and
8394 next_element_from_c_string.
8395 (tool_bar_lines_needed, redisplay_tool_bar)
8396 (display_menu_bar): Force left-to-right direction. Add a FIXME
8397 comment for making that be controlled by a user option.
8398 (push_it, pop_it): Save and restore the state of the
8399 bidi iterator. Save and restore the bidi_p flag.
8400 (pop_it): Iterate out of display property for string iteration as
8401 well.
8402 (iterate_out_of_display_property): Support iteration over strings.
8403 (handle_single_display_spec): Set up it->bidi_it for iteration
8404 over a display string, and call bidi_init_it.
8405 (handle_single_display_spec, next_overlay_string)
8406 (get_overlay_strings_1, push_display_prop): Set up the bidi
8407 iterator for displaying display or overlay strings.
8408 (forward_to_next_line_start): Don't use the shortcut if
8409 bidi-iterating.
8410 (back_to_previous_visible_line_start): If handle_display_prop
8411 pushed the iterator stack, restore the internal state of the bidi
8412 iterator by calling bidi_pop_it same number of times.
8413 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8414 and we are bidi-iterating, don't decrement the iterator position;
8415 instead, set the first_elt flag in the bidi iterator, to produce
8416 the same effect.
8417 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8418 (push_display_prop): xassert that we are iterating a buffer.
8419 (push_it, pop_it): Save and restore paragraph_embedding member.
8420 (handle_single_display_spec, next_overlay_string)
8421 (get_overlay_strings_1, reseat_1, reseat_to_string)
8422 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8423 correctly. Don't assume unibyte strings are not bidi-reordered.
8424 (compute_display_string_pos)
8425 (compute_display_string_end): Fix handling the case of C string.
8426 (push_it, pop_it): Save and restore from_disp_prop_p.
8427 (handle_single_display_spec, push_display_prop): Set the
8428 from_disp_prop_p flag.
8429 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8430 (pop_it): Call iterate_out_of_display_property only if we are
8431 popping after iteration over a string that came from a display
8432 property. Fix a typo in popping stretch info. Add an assertion
8433 for verifying that the iterator position is in sync with the bidi
8434 iterator.
8435 (handle_single_display_spec, get_overlay_strings_1)
8436 (push_display_prop): Fix initialization of paragraph direction for
8437 string when that of the parent object is not yet determined.
8438 (reseat_1): Call bidi_init_it to resync the bidi
8439 iterator with IT's position. (Bug#7616)
8440 (find_row_edges): If ROW->start.pos gives position
8441 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8442 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8443 Reset the from_disp_prop_p flag.
8444 (SAVE_IT, RESTORE_IT): New macros.
8445 (pos_visible_p, face_before_or_after_it_pos)
8446 (back_to_previous_visible_line_start)
8447 (move_it_in_display_line_to, move_it_in_display_line)
8448 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8449 (try_scrolling, redisplay_window, display_line): Use them when
8450 saving a temporary copy of the iterator and restoring it back.
8451 (back_to_previous_visible_line_start, reseat_1)
8452 (init_iterator): Empty the bidi cache "stack".
8453 (move_it_in_display_line_to): If iterator ended up at
8454 EOL, but we never saw any buffer positions smaller than
8455 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8456 motion in bidi-reordered lines.
8457 (move_it_in_display_line_to): Record prev_method and prev_pos
8458 immediately before the call to set_iterator_to_next. Fixes cursor
8459 motion in bidi-reordered lines with stretch glyphs and strings
8460 displayed in margins. (Bug#8133) (Bug#8867)
8461 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8462 TO_CHARPOS.
640c8776
SM
8463 (pos_visible_p): Support positions in bidi-reordered lines.
8464 Save and restore bidi cache.
0bb23927
EZ
8465
8466 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8467 (bidi_paragraph_info): Delete unused struct.
8468 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8469 (bidi_cache_start): New variable.
8470 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8471 to zero.
8472 (bidi_cache_fetch_state, bidi_cache_search)
8473 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8474 (bidi_cache_find, bidi_peek_at_next_level)
8475 (bidi_level_of_next_char, bidi_find_other_level_edge)
8476 (bidi_move_to_visually_next): Compare cache index with
8477 bidi_cache_start rather than with zero.
8478 (bidi_fetch_char): Accept new argument STRING; all callers
8479 changed. Support iteration over a string. Support strings with
8480 display properties. Support unibyte strings. Fix the type of
8481 `len' according to what STRING_CHAR_AND_LENGTH expects.
8482 (bidi_paragraph_init, bidi_resolve_explicit_1)
8483 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8484 (bidi_level_of_next_char, bidi_move_to_visually_next):
8485 Support iteration over a string.
0bb23927
EZ
8486 (bidi_set_sor_type, bidi_resolve_explicit_1)
8487 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8488 can now be zero (for strings); special values 0 and -1 were
8489 changed to -1 and -2, respectively.
8490 (bidi_char_at_pos): New function.
8491 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8492 Call it instead of FETCH_MULTIBYTE_CHAR.
8493 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8494 initialized to valid values.
8495 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8496 values.
8497 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8498 the test for valid cached positions. Fix the logic for looking up
8499 the sentinel state in the cache. GCPRO the Lisp string we are
8500 iterating.
8501 (bidi_push_it, bidi_pop_it): New functions.
8502 (bidi_initialize): Initialize the bidi cache start stack pointer.
8503 (bidi_cache_ensure_space): New function, refactored from part of
8504 bidi_cache_iterator_state. Don't assume the required size is just
8505 one BIDI_CACHE_CHUNK away.
8506 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8507 (bidi_count_bytes, bidi_char_at_pos): New functions.
8508 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8509 always valid if bidi_cache_idx is valid.
8510 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8511 is valid if it's going to be used.
8512 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8513 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8514 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8515 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8516 (bidi_find_other_level_edge, bidi_cache_start_stack):
8517 All variables related to cache indices are now EMACS_INT.
c965adc5 8518
0bb23927
EZ
8519 * dispextern.h (struct bidi_string_data): New structure.
8520 (struct bidi_it): New member `string'. Make flag members be 1-bit
8521 fields, and put them last in the struct.
640c8776
SM
8522 (compute_display_string_pos, compute_display_string_end):
8523 Update prototypes.
0bb23927
EZ
8524 (bidi_push_it, bidi_pop_it): Add prototypes.
8525 (struct iterator_stack_entry): New members bidi_p,
8526 paragraph_embedding, and from_disp_prop_p.
8527 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8528 (bidi_shelve_cache, bidi_unshelve_cache):
8529 Declare prototypes.
0bb23927
EZ
8530
8531 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8532 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8533 and vector-like objects.
8534
8535 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8536 cache around display iteration.
8537
8538 * window.c (Fwindow_end, window_scroll_pixel_based)
8539 (displayed_window_lines, Frecenter): Save and restore the bidi
8540 cache around display iteration.
8541
3bbd2265
LMI
85422011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8543
8544 * editfns.c (Fdelete_region): Clarify the use of the named
8545 parameters (bug#6788).
8546
adc47434
MR
85472011-07-14 Martin Rudalics <rudalics@gmx.at>
8548
8549 * indent.c (Fvertical_motion): Set and restore w->pointm when
8550 saving and restoring the window's buffer (Bug#9006).
8551
837c31f8
LMI
85522011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8553
8554 * editfns.c (Fstring_to_char): Clarify just what is returned
8555 (bug#6576). Text by Eli Zaretskii.
8556
ac389d0c
JB
85572011-07-13 Juanma Barranquero <lekktu@gmail.com>
8558
8559 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8560
0be0ce47
EZ
85612011-07-13 Eli Zaretskii <eliz@gnu.org>
8562
8563 * buffer.c (mmap_find): Fix a typo.
8564
cd18e7e3
JB
85652011-07-13 Johan Bockgård <bojohan@gnu.org>
8566
8567 Fix execution of x selection hooks.
8568 * xselect.c (Qx_lost_selection_functions)
8569 (Qx_sent_selection_functions): New vars.
8570 (syms_of_xselect): DEFSYM them.
8571 (x_handle_selection_request): Pass Qx_sent_selection_functions
8572 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8573 (x_handle_selection_clear,x_clear_frame_selections):
8574 Pass Qx_lost_selection_functions rather than
8575 Vx_lost_selection_functions to Frun_hook_with_args.
8576
47ea7f44
PE
85772011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8578
ac389d0c 8579 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8580 The old code sometimes used this field without initializing it.
8581
47ea7f44
PE
8582 * alloc.c (gc_sweep): Don't read past end of array.
8583 In theory, the old code could also have corrupted Emacs internals,
8584 though it'd be very unlikely.
8585
bc985c87
AS
85862011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8587
8588 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8589 argument. (Bug#4026)
bc985c87 8590
0cf34688
LMI
85912011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8592
b3dadd76
LMI
8593 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8594 key" (bug#4257).
8595
0cf34688
LMI
8596 * window.c (Fset_window_start): Doc fix (bug#4199).
8597 (Fset_window_hscroll): Ditto.
8598
270768cd
PE
85992011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8600
077e3dda 8601 Fix minor new problems caught by GCC 4.6.1.
270768cd 8602 * term.c (init_tty): Remove unused local.
490011a6 8603 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8604 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8605 not used otherwise.
270768cd 8606
b1f58454
CY
86072011-07-12 Chong Yidong <cyd@stupidchicken.com>
8608
8609 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8610
22b9578d
LMI
86112011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8612
6e70ab07
LMI
8613 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8614 are the mini-buffer and the echo area (bug#3320).
8615
22b9578d
LMI
8616 * term.c (init_tty): Remove support for supdup, c10 and perq
8617 terminals, which are no longer supported (bug#1482).
8618
8974cc9f
JB
86192011-07-10 Johan Bockgård <bojohan@gnu.org>
8620
8621 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8622
a560d974
JD
86232011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8624
8625 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8626 for non-popups (Bug#3642).
8627
1dae0f0a
AS
86282011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8629
268c2c36 8630 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8631 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8632 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8633 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8634 * data.c (fmod): Likewise.
8635 * dispnew.c (swap_glyphs_in_rows): Likewise.
8636 * emacs.c (memory_warning_signal): Likewise.
8637 * floatfns.c (float_error): Likewise.
8638 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8639 (otf_open, font_otf_capability, generate_otf_features)
8640 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8641 Likewise.
8642 * image.c (pbm_read_file): Likewise.
8643 * indent.c (string_display_width): Likewise.
8644 * intervals.c (check_for_interval, search_for_interval)
8645 (inc_interval_count, count_intervals, root_interval)
8646 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8647 * lread.c (defalias): Likewise.
268c2c36 8648 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8649 * regex.c (set_image_of_range_1, set_image_of_range)
8650 (regex_grow_registers): Likewise.
8651 * sysdep.c (strerror): Likewise.
8652 * termcap.c (valid_filename_p, tprint, main): Likewise.
8653 * tparam.c (main): Likewise.
8654 * unexhp9k800.c (run_time_remap, save_data_space)
8655 (update_file_ptrs, read_header, write_header, calculate_checksum)
8656 (copy_file, copy_rest, display_header): Likewise.
8657 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8658 Likewise.
8659 * xdisp.c (check_it): Likewise.
8660 * xfaces.c (register_color, unregister_color, unregister_colors):
8661 Likewise.
8662 * xfns.c (print_fontset_result): Likewise.
8663 * xrdb.c (member, fatal, main): Likewise.
8664
99033785
PE
86652011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8666
8667 Fix minor problems found by static checking (Bug#9031).
8668 * chartab.c (char_table_set_range, map_sub_char_table):
8669 Remove unused locals.
8670 (uniprop_table): Now static.
8671 * composite.c (_work_char): Remove unused static var.
8672
9cb2ac56
JB
86732011-07-09 Juanma Barranquero <lekktu@gmail.com>
8674
8675 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8676
f25661f0
JD
86772011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8678
8679 * gtkutil.c (qttip_cb): Remove code without function.
8680
8278c4fe
EZ
86812011-07-09 Eli Zaretskii <eliz@gnu.org>
8682
8683 * w32.c (pthread_sigmask): New stub.
8684
1692ae2d 86852011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8686
8a6ebd58 8687 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8688 sigprocmask is portable only for single-threaded applications, and
8689 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8690 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8691 (LIBES): Use it.
8692 * callproc.c (Fcall_process):
8693 * process.c (create_process):
8694 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8695 Use pthread_sigmask, not sigprocmask.
123403e4 8696
1b854618
JD
86972011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8698
8699 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8700 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8701 wrong (Bug#8591).
8702
3fe4b549
JD
87032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8704
0ce7e563
JD
8705 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8706 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8707 (xg_hide_tooltip): Fix comment.
8708
3fe4b549
JD
8709 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8710 in registerServicesMenuSendTypes.
8711 (validRequestorForSendType): Don't check ns_return_types.
8712
8713 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8714 ns_return_type.
8715
5df75e47
JR
87162011-07-08 Jason Rumney <jasonr@gnu.org>
8717
22610910
JR
8718 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8719 SH_SHOW for hidden windows (Bug#5482).
8720
5df75e47
JR
8721 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8722 frame struct members of non-existent frames (Bug#6284).
8723
699c10bd
JD
87242011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8725
4393663b
JD
8726 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8727 variable firstTime not needed on OSX >= 10.6.
8728 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8729 >= 10.5. Use setKnobProportion, setDoubleValue.
8730
8731 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8732 (MAC_OS_X_VERSION_10_5): Define if not defined.
8733 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8734 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8735 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8736
8737 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8738 cString and lossyCString on OSX >= 10.4.
4393663b 8739
58179cce 8740 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8741 sizeToFit on OSX >= 10.2.
8742
8743 * nsimage.m (allocInitFromFile): Don't use deprecated method
8744 bestRepresentationForDevice on OSX >= 10.6.
8745
8746 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8747 to avoid warning.
8748
8749 * emacs.c: Declare unexec_init_emacs_zone.
8750
a63e0781
JD
8751 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8752
699c10bd
JD
8753 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8754
8755 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8756 on svcsMenu (Bug#8842).
8757
8758 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8759 ns_return_types.
8760 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8761
8762 * nsterm.m (QUTF8_STRING): Declare.
8763 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8764 (validRequestorForSendType): Return type is (id).
8765 Change indexOfObjectIdenticalTo to indexOfObject.
8766 Check if we have local selection before returning self (Bug#8842).
8767 (writeSelectionToPasteboard): Put local selection into paste board
8768 if we have a local selection (Bug#8842).
8769 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8770
8771 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8772 (ns_get_local_selection): Declare.
8773
54e10184
LMI
87742011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8775
9888ff71
LMI
8776 * keymap.c (describe_map_tree): Don't insert a double newline at
8777 the end of the buffer (bug#1169) and return whether we inserted
8778 something.
8779
54e10184
LMI
8780 * callint.c (Fcall_interactively): Change "reading args" to
8781 "providing args" to try to clarify what it does (bug#1010).
8782
15fa4783
KH
87832011-07-07 Kenichi Handa <handa@m17n.org>
8784
8785 * composite.c (composition_compute_stop_pos): Ignore a static
8786 composition starting before CHARPOS (Bug#8915).
8787
8788 * xdisp.c (handle_composition_prop): Likewise.
8789
a8815b00
EZ
87902011-07-07 Eli Zaretskii <eliz@gnu.org>
8791
8792 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8793 (Bug#9015)
8794
ef7b981d 87952011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8796
8797 * character.h (unicode_category_t): New enum type.
8798
8799 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8800 (Qchar_code_property_table): New variable.
8801 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8802 (UNIPROP_COMPRESSED_FORM_P): New macros.
8803 (char_table_ascii): Uncompress the compressed values.
8804 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8805 Uncompress the compressed values.
ac389d0c 8806 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8807 (char_table_ref_and_range): Uncompress the compressed values.
8808 (sub_char_table_set): New arg is_uniprop. Callers changed.
8809 Uncompress the compressed values.
8810 (sub_char_table_set_range): Args changed. Callers changed.
8811 (char_table_set_range): Adjuted for the above change.
8812 (map_sub_char_table): Delete args default_val and parent. Add arg
8813 top. Give decoded values to a Lisp function.
640c8776 8814 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8815 values to a Lisp function. Gcpro more variables.
8816 (uniprop_table_uncompress)
8817 (uniprop_decode_value_run_length): New functions.
8818 (uniprop_decoder, uniprop_decoder_count): New variables.
8819 (uniprop_get_decoder, uniprop_encode_value_character)
8820 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8821 New functions.
8822 (uniprop_encoder, uniprop_encoder_count): New variables.
8823 (uniprop_get_encoder, uniprop_table)
8824 (Funicode_property_table_internal, Fget_unicode_property_internal)
8825 (Fput_unicode_property_internal): New functions.
8826 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8827 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8828 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8829 char-code-property-alist.
8830
640c8776 8831 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8832 Vunicode_category_table.
8833
640c8776 8834 * font.c (font_range): Adjust for the change of
c805dec0
KH
8835 Vunicode_category_table.
8836
76b397fb
DN
88372011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8838
8839 * m/iris4d.h: Remove file, move contents ...
8840 * s/irix6-5.h: ... here.
8841
22b4128e
PE
88422011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8843
8844 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8845 * alloc.c (mark_buffer):
8846 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8847 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8848 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8849 This isn't true in general, and it's particularly not true
8850 if Emacs is configured with --with-wide-int.
8851 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8852 New macros, used in the buffer.c change.
8853
869795d6
JD
88542011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8855
8856 * xsettings.c: Use both GConf and GSettings if both are available.
8857 (store_config_changed_event): Add comment.
8858 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8859 (store_tool_bar_style_changed): New functions.
5e617bc2 8860 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8861 (struct xsettings): Move font inside HAVE_XFT.
8862 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8863 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8864 Move inside HAVE_XFT.
640c8776 8865 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8866 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8867 also.
8868 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8869 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8870 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8871 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8872 (parse_settings): Move check for font inside HAVE_XFT.
8873 (read_settings, apply_xft_settings): Add comment.
8874 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8875 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8876 call store_font_name_changed.
8877 (xft_settings_event): Add comment.
8878 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8879 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8880 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8881 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8882 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8883 (xsettings_get_system_font, xsettings_get_system_normal_font):
8884 Add comment.
869795d6 8885
d8ed26bd
PE
88862011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8887
8888 Random fixes. E.g., (random) never returned negative values.
8889 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8890 subseconds part to the entropy, as that's a bit more random.
8891 Prefer signed to unsigned, since the signedness doesn't matter and
8892 in general we prefer signed. When given a limit, use a
8893 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8894 latter isn't right if USE_2_TAGS_FOR_INTS.
8895 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8896 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8897
cabf1cac
SM
88982011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8899
8900 * textprop.c (text_property_stickiness):
8901 Obey Vtext_property_default_nonsticky.
8902 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8903 * w32fns.c (syms_of_w32fns):
8904 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8905
6e9b2be9
PE
89062011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8907
8908 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8909 This is more efficient than Ffile_directory_p and avoids a minor race.
8910
90186c68
LMI
89112011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8912
7c301272
LMI
8913 * buffer.c (Foverlay_put): Say what the return value is
8914 (bug#7835).
8915
c4f2d8d4
LMI
8916 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8917 is a directory before asking whether to use the file name
8918 (bug#7564).
ad637907
LMI
8919 (barf_or_query_if_file_exists): Make the "File is a directory"
8920 error be more correct.
c4f2d8d4 8921
90186c68
LMI
8922 * fns.c (Frequire): Remove the mention of the .gz files, since
8923 that's installation-specific, but keep the mention of
8924 `get-load-suffixes'.
8925
da64016e
PE
89262011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8927
8928 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8929 Report string overflow if the output is too long.
8930
7d47b580
JB
89312011-07-04 Juanma Barranquero <lekktu@gmail.com>
8932
a555cb87
JB
8933 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8934 (syms_of_gnutls): Remove duplicate DEFSYM for
8935 Qgnutls_bootprop_verify_hostname_error, an error for
8936 Qgnutls_bootprop_verify_error (which is no longer used).
8937
7d47b580
JB
8938 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8939 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8940 Also (re)move comments that are misplaced or no longer relevant.
8941
1e49bfab
LMI
89422011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8943
8944 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8945
1485f4c0
CY
89462011-07-03 Chong Yidong <cyd@stupidchicken.com>
8947
8948 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8949 and background color parameters if they have been changed.
8950
a9ab721e
LMI
89512011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8952
8953 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8954
cf7cff57
PE
89552011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8956
2e13213d
PE
8957 * xsettings.c (SYSTEM_FONT): Define only when used.
8958 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8959
cf7cff57
PE
8960 * keymap.c (access_keymap_1): Now static.
8961
7a8e04f7
CY
89622011-07-02 Chong Yidong <cyd@stupidchicken.com>
8963
8964 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8965 leave any prefix arg for the up event (Bug#1586).
8966
61352f62
LMI
89672011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8968
69bb1ef7
LMI
8969 * lread.c (syms_of_lread): Mention single symbols defined by
8970 `defvar' or `defconst' (bug#7154).
8971
61352f62 8972 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8973 (Frequire): Mention get-load-suffixes.
61352f62 8974
28545e04
MR
89752011-07-02 Martin Rudalics <rudalics@gmx.at>
8976
8977 * window.h (window): Remove clone_number slot.
8978 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8979 Remove.
8980 (make_parent_window, make_window, saved_window)
8981 (Fset_window_configuration, save_window_save): Don't deal with
8982 clone numbers.
8983 * buffer.c (Qclone_number): Remove declaration.
8984 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8985
3349e122
SM
89862011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8987
8988 Add multiple inheritance to keymaps.
8989 * keymap.c (Fmake_composed_keymap): New function.
8990 (Fset_keymap_parent): Simplify.
8991 (fix_submap_inheritance): Remove.
8992 (access_keymap_1): New function extracted from access_keymap to handle
8993 embedded parents and handle lists of maps.
8994 (access_keymap): Use it.
8995 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8996 (Fcopy_keymap): Handle embedded parents.
8997 (Fcommand_remapping, define_as_prefix): Simplify.
8998 (Fkey_binding): Simplify.
8999 (syms_of_keymap): Move minibuffer-local-completion-map,
9000 minibuffer-local-filename-completion-map,
9001 minibuffer-local-must-match-map, and
9002 minibuffer-local-filename-must-match-map to Elisp.
9003 (syms_of_keymap): Defsubr make-composed-keymap.
9004 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9005 (parse_menu_item): Trivial simplification.
9006
3279eb87
GM
90072011-07-01 Glenn Morris <rgm@gnu.org>
9008
9009 * Makefile.in (SETTINGS_LIBS): Fix typo.
9010
4550efdf
KI
90112011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9012
9013 * coding.c (Fencode_coding_string): Record the last coding system
9014 used, as the function doc string says (bug#8738).
9015
0949d2b6
JD
90162011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9017
9018 * xsettings.c (store_monospaced_changed): Take new font as arg and
9019 check for change against current_mono_font.
9020 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9021 (emacs_settings_constructor, emacs_settings_get_property)
9022 (emacs_settings_set_property, emacs_settings_class_init)
9023 (emacs_settings_init, gsettings_obj): Remove.
9024 (something_changedCB): New function for HAVE_GSETTINGS.
9025 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9026 with value as argument.
9027 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9028 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9029 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9030 "changed".
9031
9032 * xgselect.c: Add defined (HAVE_GSETTINGS).
9033 (xgselect_initialize): Ditto.
9034
9035 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9036 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9037 xg_select.
9038
bbc6b304
PE
90392011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9040
9041 * eval.c (struct backtrace): Simplify and port the data structure.
9042 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9043 signed bit field, as this assumption is not portable and it makes
9044 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9045 "char debug_on_exit : 1" as this is not portable either; instead,
9046 use the portable "unsigned int debug_on_exit : 1". Remove unused
9047 member evalargs. Remove obsolete comments about cc bombing out.
9048
9851bfc5
JD
90492011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9050
51bb811f 9051 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9052 Let HAVE_GSETTINGS override HAVE_GCONF.
9053 (store_monospaced_changed): New function.
9054 (EMACS_SETTINGS): A new type derived from GObject to handle
9055 GSettings notifications.
9056 (emacs_settings_constructor, emacs_settings_get_property)
9057 (emacs_settings_set_property, emacs_settings_class_init):
9058 New functions.
9059 (gsettings_client, gsettings_obj): New variables.
9060 (GSETTINGS_SCHEMA): New define.
9061 (something_changedCB): Call store_monospaced_changed.
9062 (init_gsettings): New function.
9063 (xsettings_initialize): Call init_gsettings.
9064 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9065 to NULL.
9066
640c8776 9067 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9068 GCONF_CFLAGS/LIBS.
9069
5386012d
MR
90702011-06-29 Martin Rudalics <rudalics@gmx.at>
9071
9072 * window.c (resize_root_window, grow_mini_window)
9073 (shrink_mini_window): Rename Qresize_root_window to
9074 Qwindow_resize_root_window and Qresize_root_window_vertically to
9075 Qwindow_resize_root_window_vertically.
9076
f13e0b08
PE
90772011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9078
9079 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9080
94515237
JB
90812011-06-27 Juanma Barranquero <lekktu@gmail.com>
9082
9083 * makefile.w32-in: Redesign dependencies so they reflect more
9084 clearly which files are directly included by each source file,
9085 and not through other includes.
9086
e43b6e43
MR
90872011-06-27 Martin Rudalics <rudalics@gmx.at>
9088
9089 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9090 (sort_overlays, overlay_strings): When an overlay's clone number
9091 matches the window's clone number process the overlay even if
9092 the overlay's window property doesn't match the current window.
9093
d68443dc
MR
9094 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9095 (Fwindow_hchild): Rename to Fwindow_left_child.
9096 (Fwindow_next): Rename to Fwindow_next_sibling.
9097 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9098 (resize_window_check): Rename to window_resize_check.
9099 (resize_window_apply): Rename to window_resize_apply.
9100 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9101 (Fdelete_other_windows_internal, resize_frame_windows)
9102 (Fsplit_window_internal, Fdelete_window_internal)
9103 (grow_mini_window, shrink_mini_window)
9104 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9105
c7e73be5
JD
91062011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9107
9108 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9109 (emacs_fixed_set_min_size): Remove.
9110 (emacs_fixed_new): Take frame as argument.
9111
9112 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9113 (_EmacsFixedPrivate): Remove minwidth/height.
9114 Add struct frame *f.
9115 (emacs_fixed_init): Initialize priv->f.
9116 (get_parent_class, emacs_fixed_set_min_size): Remove.
9117 (emacs_fixed_new): Set priv->f to argument.
9118 (emacs_fixed_get_preferred_width)
9119 (emacs_fixed_get_preferred_height): Use min_width/height from
9120 frames size_hint to set minimum and natural (Bug#8919).
9121 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9122 and use min_width/height from frames size_hint to set
9123 min_width/height (Bug#8919).
9124
9125 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9126 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9127 Fix indentation.
c7e73be5 9128
cf99dcf8
EZ
91292011-06-26 Eli Zaretskii <eliz@gnu.org>
9130
9131 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9132 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9133 called at ZV.
9134
029529ac
CY
91352011-06-26 Chong Yidong <cyd@stupidchicken.com>
9136
9137 * process.c (wait_reading_process_output): Bypass select if
9138 waiting for a cell while ignoring keyboard input, and input is
9139 pending. Suggested by Jan Djärv (Bug#8869).
9140
7a7ef429
PE
91412011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9142
9143 Use gnulib's dup2 module instead of rolling our own.
9144 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9145
11fdef7d 91462011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9147
9148 * dispnew.c (scrolling_window): Before scrolling, turn off a
9149 mouse-highlight in the window being scrolled.
9150
cd3520a4
JB
91512011-06-24 Juanma Barranquero <lekktu@gmail.com>
9152
9153 Move DEFSYM to lisp.h and use everywhere.
9154
9155 * character.h (DEFSYM): Move declaration...
9156 * lisp.h (DEFSYM): ...here.
9157
9158 * gnutls.c:
9159 * minibuf.c:
9160 * w32menu.c:
9161 * w32proc.c:
9162 * w32select.c: Don't include character.h.
9163
9164 * alloc.c (syms_of_alloc):
9165 * buffer.c (syms_of_buffer):
9166 * bytecode.c (syms_of_bytecode):
9167 * callint.c (syms_of_callint):
9168 * casefiddle.c (syms_of_casefiddle):
9169 * casetab.c (init_casetab_once):
9170 * category.c (init_category_once, syms_of_category):
9171 * ccl.c (syms_of_ccl):
9172 * cmds.c (syms_of_cmds):
9173 * composite.c (syms_of_composite):
9174 * dbusbind.c (syms_of_dbusbind):
9175 * dired.c (syms_of_dired):
9176 * dispnew.c (syms_of_display):
9177 * doc.c (syms_of_doc):
9178 * editfns.c (syms_of_editfns):
9179 * emacs.c (syms_of_emacs):
9180 * eval.c (syms_of_eval):
9181 * fileio.c (syms_of_fileio):
9182 * fns.c (syms_of_fns):
9183 * frame.c (syms_of_frame):
9184 * fringe.c (syms_of_fringe):
9185 * insdel.c (syms_of_insdel):
9186 * keymap.c (syms_of_keymap):
9187 * lread.c (init_obarray, syms_of_lread):
9188 * macros.c (syms_of_macros):
9189 * msdos.c (syms_of_msdos):
9190 * print.c (syms_of_print):
9191 * process.c (syms_of_process):
9192 * search.c (syms_of_search):
9193 * sound.c (syms_of_sound):
9194 * syntax.c (init_syntax_once, syms_of_syntax):
9195 * terminal.c (syms_of_terminal):
9196 * textprop.c (syms_of_textprop):
9197 * undo.c (syms_of_undo):
9198 * w32.c (globals_of_w32):
9199 * window.c (syms_of_window):
9200 * xdisp.c (syms_of_xdisp):
9201 * xfaces.c (syms_of_xfaces):
9202 * xfns.c (syms_of_xfns):
9203 * xmenu.c (syms_of_xmenu):
9204 * xsettings.c (syms_of_xsettings):
9205 * xterm.c (syms_of_xterm): Use DEFSYM.
9206
4228cf16
TZ
92072011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9208
cd3520a4 9209 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9210
7fcccf1e
PE
92112011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9212
7efb4e0e
PE
9213 Integer and buffer overflow fixes (Bug#8873).
9214
ff5844ad
PE
9215 * print.c (printchar, strout): Check for string overflow.
9216 (PRINTPREPARE, printchar, strout):
9217 Don't set size unless allocation succeeds.
9218
90532f02
PE
9219 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9220 for sizes. Check for string overflow more accurately.
9221 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9222
6d84508d
PE
9223 * macros.c: Integer and buffer overflow fixes.
9224 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9225 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9226 Use ptrdiff_t, not int, for sizes.
9227 Don't increment bufsize until after realloc succeeds.
9228 Check for size-calculation overflow.
9229 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9230
437b2cb4
PE
9231 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9232
8b9ac8b4
PE
9233 * lread.c: Integer overflow fixes.
9234 (read_integer): Radix is now EMACS_INT, not int,
9235 to improve quality of diagnostics for out-of-range radices.
9236 Calculate buffer size correctly for out-of-range radices.
9237 (read1): Check for integer overflow in radices, and in
9238 read-circle numbers.
82cb60d3
PE
9239 (read_escape): Avoid int overflow.
9240 (Fload, openp, read_buffer_size, read1)
9241 (substitute_object_recurse, read_vector, read_list, map_obarray):
9242 Use ptrdiff_t, not int, for sizes.
9243 (read1): Use EMACS_INT, not int, for sizes.
20270765 9244 Check for size overflow.
8b9ac8b4 9245
7fcccf1e
PE
9246 * image.c (cache_image): Check for size arithmetic overflow.
9247
bfbbd7e7
PE
9248 * lread.c: Integer overflow issues.
9249 (saved_doc_string_size, saved_doc_string_length)
9250 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9251 Now ptrdiff_t, not int.
9252 (read1): Don't assume doc string length fits in int. Check for
9253 out-of-range doc string lengths.
9254 (read_list): Don't assume file position fits in int.
39019e54 9255 (read_escape): Check for hex character overflow.
bfbbd7e7 9256
4e323265
LL
92572011-06-22 Leo Liu <sdl.web@gmail.com>
9258
9259 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9260 Move to minibuffer.el.
9261
85fece3e
PE
92622011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9263
20b84ce9 9264 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9265 The following patches are for when GLYPH_DEBUG && !XASSERT.
9266 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9267 * dispnew.c (flush_stdout):
9268 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9269 Mark as externally visible.
9270 * dispnew.c (check_window_matrix_pointers): Now static.
9271 * dispnew.c (window_to_frame_vpos):
9272 * xfns.c (unwind_create_frame):
9273 * xterm.c (x_check_font): Remove unused local.
9274 * scroll.c (CHECK_BOUNDS):
9275 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9276 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9277 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9278 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9279 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9280 Now static.
9281 (debug_method_add): Use va_list and vsprintf rather than relying
9282 on undefined behavior with wrong number of arguments.
9283 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9284 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9285 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9286 since we're not interested in debugging glyphs with old libraries.
9287 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9288 GCC 4.6.0's static checking.
9289
0766b489
PE
92902011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9291
31fd4b32
PE
9292 Integer overflow and signedness fixes (Bug#8873).
9293 A few related buffer overrun fixes, too.
9294
b79e8648
PE
9295 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9296
0766b489
PE
9297 * dispextern.h (struct face.stipple):
9298 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9299 (x_bitmap_mask, x_allocate_bitmap_record)
9300 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9301 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9302 (x_create_bitmap_from_xpm_data):
9303 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9304 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9305 (.bitmaps_last):
9306 * xfaces.c (load_pixmap):
9307 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9308 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9309 (.bitmaps_last, struct x_output.icon_bitmap):
9310 Use ptrdiff_t, not int, for bitmap indexes.
9311 (x_allocate_bitmap_record): Check for size overflow.
9312 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9313
b081724f
PE
9314 Use ptrdiff_t, not int, for overlay counts.
9315 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9316 * editfns.c (overlays_around, get_pos_property):
9317 * textprop.c (get_char_property_and_overlay):
9318 * xdisp.c (next_overlay_change, note_mouse_highlight):
9319 * xfaces.c (face_at_buffer_position):
21514da7
PE
9320 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9321 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9322 (Fnext_overlay_change, Fprevious_overlay_change)
9323 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9324 Use ptrdiff_t, not int, for sizes.
21514da7 9325 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9326
3de73e5e
PE
9327 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9328
2606c57b
PE
9329 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9330 (x_session_initialize): Do not assume string length fits in int.
9331
aaafe47a
PE
9332 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9333 This is unlikely, but can occur if DPI is outlandish.
9334
2674ddc8 9335 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9336 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9337
28154962
PE
9338 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9339 * xrdb.c (magic_file_p, search_magic_path):
9340 Omit last arg SUFFIX; it was always 0. All callers changed.
9341 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9342
7de51af5
PE
9343 * xfont.c (xfont_match): Avoid need for strlen.
9344
25ed6cc3
PE
9345 * xfns.c: Don't assume strlen fits in int.
9346 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9347
4eab31dd
PE
9348 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9349 not unsigned long, as we prefer signed integers. All callers changed.
9350 Detect integer overflow in repeat count.
9351 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9352 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9353
171e2a58
PE
9354 * termcap.c: Don't assume sizes fit in int and never overflow.
9355 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9356 (gobble_line): Check for size-calculation overflow.
9357
ad39faca 9358 * minibuf.c (Fread_buffer):
6e5bb2dc 9359 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9360 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9361 Don't assume string length fits in int.
9362
52c61c22 9363 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9364 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9365
b5b8c9e5
PE
9366 * font.c: Don't assume string length fits in int.
9367 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9368 Use ptrdiff_t, not int.
ccd6111c
PE
9369 (font_intern_prop): Don't assume string length fits in int.
9370 Don't assume integer property fits in fixnum.
9371 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9372
882f0d81 9373 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9374 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9375 Reformulate so as not to need the command string.
9376 Invoke gzip -cd rather than gunzip, as it's more portable.
9377 (lock_info_type, lock_file_1, lock_file):
9378 Don't assume pid_t and time_t fit in unsigned long.
9379 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9380 (current_lock_owner): Prefer signed type for sizes.
9381 Use memcpy, not strncpy, where memcpy is what is really wanted.
9382 Don't assume (via atoi) that time_t and pid_t fit in int.
9383 Check for time_t and/or pid_t out of range, e.g., via a network share.
9384 Don't alloca where an auto var works fine.
9385
93f4cf88
PE
9386 * fileio.c: Fix some integer overflow issues.
9387 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9388 Don't assume string length fits in int.
9389 (directory_file_name): Don't assume string length fits in long.
9390 (make_temp_name): Don't assume pid fits in int, or that its print
9391 length is less than 20.
9392
f3e92b69
PE
9393 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9394
1bfdaf10
PE
9395 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9396
35016e9a
PE
9397 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9398
3d1e65a1
PE
9399 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9400 We prefer signed integers, even for size calculations.
9401
0b963a93
PE
9402 * emacs.c: Don't assume string length fits in 'int'.
9403 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9404 (main): Don't invoke strlen when not needed.
9405
573f4b54
PE
9406 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9407 (XD_DEBUG_MESSAGE): Don't waste a byte.
9408
989f33ba
PE
9409 * callproc.c (getenv_internal_1, getenv_internal)
9410 (Fgetenv_internal):
965d34eb
PE
9411 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9412
e4d29b33
PE
9413 * lread.c (invalid_syntax): Omit length argument.
9414 All uses changed. This doesn't fix a bug, but it simplifies the
9415 code away from its former Hollerith-constant appearance, and it's
9416 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9417 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9418
eb49b136
PE
9419 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9420 This didn't break anything, but it didn't help either.
9421 It's confusing to put a bogus integer in a place where the actual
9422 value does not matter.
9f62aeb1 9423 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9424 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9425
15375a22
PE
9426 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9427 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9428 implementation.
b61cc01c
PE
9429 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9430 We prefer signed types, and the value cannot exceed the EMACS_INT
9431 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9432 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9433 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9434 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9435
53b2623d
PE
9436 * indent.c (sane_tab_width): New function.
9437 (current_column, scan_for_column, Findent_to, position_indentation)
9438 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9439 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9440
51cab52b 9441 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9442
f2ed8a70
PE
9443 * lisp.h (lint_assume): New macro.
9444 * composite.c (composition_gstring_put_cache):
9445 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9446
abe80cc6
PE
9447 * editfns.c, insdel.c:
9448 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9449
b02c740e
PE
9450 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9451
ebc96716
PE
9452 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9453
b4e50fa0 9454 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9455 Use much-faster test for byte-length change.
311d5d7c 9456 Don't assume string byte-length fits in 'int'.
a4cf38e4 9457 Check that character arg fits in 'int'.
85461888 9458 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9459
c0c1ee9f
PE
9460 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9461
a498d7f4
PE
9462 * fns.c (concat): Catch string overflow earlier.
9463 Do not rely on integer wraparound.
9464
51cab52b
PE
9465 * dispextern.h (struct it.overlay_strings_charpos)
9466 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9467 * xdisp.c (forward_to_next_line_start)
9468 (back_to_previous_visible_line_start)
9469 (reseat_at_next_visible_line_start, next_element_from_buffer):
9470 Don't arbitrarily truncate the value of 'selective' to int.
9471
76031fad
PE
9472 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9473
5eb55db9
PE
9474 * composite.c: Don't truncate sizes to 'int'.
9475 (composition_gstring_p, composition_reseat_it)
9476 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9477 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9478 not EMACS_UINT, for indexes.
5eb55db9 9479
0703a717
PE
9480 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9481
d6202519
PE
9482 * buffer.c: Include <verify.h>.
9483 (struct sortvec.priority, struct sortstr.priority):
8961a454 9484 Now EMACS_INT, not int.
c20998a7 9485 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9486 (struct sortstr.size, record_overlay_string)
9487 (struct sortstrlist.size, struct sortlist.used):
9488 Don't truncate size to int.
9489 (record_overlay_string): Check for size-calculation overflow.
d6202519 9490 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9491
d5a19415
JM
94922011-06-22 Jim Meyering <meyering@redhat.com>
9493
029529ac 9494 Don't leak an XBM-image-sized buffer
d5a19415
JM
9495 * image.c (xbm_load): Free the image buffer after using it.
9496
a9041e6c
PE
94972011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9498
9499 Port to Sun C.
9500 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9501 that Sun C diagnosed.
9502 * fns.c (secure_hash): Fix pointer signedness issue.
9503 * intervals.c (static_offset_intervals): New function.
9504 (offset_intervals): Use it.
9505
7f3f739f
LL
95062011-06-21 Leo Liu <sdl.web@gmail.com>
9507
9508 * deps.mk (fns.o):
9509 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9510 sha512.h.
9511
9512 * fns.c (secure_hash): Rename from crypto_hash_function and change
9513 the first arg to accept symbols.
5b66d427 9514 (Fsecure_hash): New primitive.
7f3f739f
LL
9515 (syms_of_fns): New symbols.
9516
76147d94
DD
95172011-06-20 Deniz Dogan <deniz@dogan.se>
9518
9519 * process.c (Fset_process_buffer): Clarify return value in
9520 docstring.
9521
7d7d0045
CY
95222011-06-18 Chong Yidong <cyd@stupidchicken.com>
9523
9524 * dispnew.c (add_window_display_history): Use BVAR.
9525
9526 * xdisp.c (debug_method_add): Use BVAR.
9527 (check_window_end, dump_glyph_matrix, dump_glyph)
9528 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9529
9530 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9531 Likewise.
9532
9533 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9534 check till after the cache is created in init_frame_faces.
9535
ff2bc410
SM
95362011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9537
9538 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9539
28177add
PE
95402011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9541
dd3482fe
PE
9542 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9543 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9544 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9545
393d71f3 9546 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9547 * fileio.c (Finsert_file_contents):
9548 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9549 Remove the old (too-loose) buffer overflow checks.
9550 They weren't needed, since make_gap checks for buffer overflow.
9551 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9552 The old code merely checked for Emacs fixnum overflow, and relied
9553 on undefined (wraparound) behavior. The new code avoids undefined
9554 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9555
2e6813b0 9556 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9557 Tune. Don't use wider integers than needed. Don't use alloca.
9558 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9559
599a9e4f
PE
9560 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9561
99561444
PE
9562 * insdel.c, lisp.h (buffer_overflow): New function.
9563 (insert_from_buffer_1, replace_range, replace_range_2):
9564 * insdel.c (make_gap_larger):
9565 * editfns.c (Finsert_char):
9566 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9567
28177add
PE
9568 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9569
e69dafad
PE
95702011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9571
4baa020d 9572 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9573
b1c46f02
PE
9574 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9575 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9576
e69dafad
PE
9577 * fileio.c: Don't assume EMACS_INT fits in off_t.
9578 (emacs_lseek): New static function.
9579 (Finsert_file_contents, Fwrite_region): Use it.
9580 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9581
566684ea
PE
9582 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9583
e6966cd6
PE
9584 * fns.c: Don't overflow int when computing a list length.
9585 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9586 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9587 truncation on 64-bit hosts. Check for QUIT every
9588 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9589 faster and is responsive enough.
9590 (Flength): Report an error instead of overflowing an integer.
9591 (Fsafe_length): Return a float if the value is not representable
9592 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9593 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9594 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9595
dd0b0efb
PE
9596 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9597 (header_size, word_size): New constants.
9598 (allocate_vectorlike): Don't check size overflow here.
9599 (allocate_vector): Check it here instead, since this is the only
9600 caller of allocate_vectorlike that could cause overflow.
9601 Check that the new vector's length is representable as a fixnum.
9602
86fe5cfe
PE
9603 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9604 The previous code was bogus. For example, next_almost_prime (32)
9605 returned 39, which is undesirable as it is a multiple of 3; and
9606 next_almost_prime (24) returned 25, which is a multiple of 5 so
9607 why was the code bothering to check for multiples of 7?
9608
80e88859
PE
9609 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9610
4a2f0ad6
PE
9611 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9612
f66c7cf8
PE
9613 Variadic C functions now count arguments with ptrdiff_t.
9614 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9615 Back then I didn't know that the Emacs coding style prefers signed int.
9616 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9617 were being counted with int, which may truncate counts on 64-bit
9618 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9619 * lisp.h (struct Lisp_Subr.function.aMANY)
9620 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9621 Arg counts are now ptrdiff_t, not size_t.
9622 All variadic functions and their callers changed accordingly.
9623 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9624 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9625 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9626 * callint.c (Fcall_interactively): Check arg count for overflow,
9627 to avoid potential buffer overrun. Use signed char, not 'int',
9628 for 'varies' array, so that we needn't bother to check its size
9629 calculation for overflow.
9630 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9631 * eval.c (apply_lambda):
9632 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9633 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9634 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9635
a1759b76
PE
9636 * callint.c (Fcall_interactively): Don't use index var as event count.
9637
d96be9fc
PE
9638 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9639 * mem-limits.h (SIZE): Remove; no longer used.
9640
a690a978 9641 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9642
578c21e6
PE
9643 Remove unnecessary casts.
9644 * xterm.c (x_term_init):
9645 * xfns.c (x_set_border_pixel):
9646 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9647 These aren't needed now that we assume ANSI C.
9648
96f53c6c
PE
9649 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9650 It's more likely to cause problems (due to unsigned overflow)
9651 than to cure them.
9652
83c77d31
PE
9653 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9654
ee2079f1
PE
9655 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9656
6da65536
PE
9657 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9658
7147c4a4
PE
9659 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9660
193e32d9
PE
9661 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9662
e5533da6
PE
9663 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9664
9910e595
PE
9665 GLYPH_CODE_FACE returns EMACS_INT, not int.
9666 * dispextern.h (merge_faces):
9667 * xfaces.c (merge_faces):
01103c44
PE
9668 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9669 Don't assume EMACS_INT fits in int.
9910e595 9670
2638320e
PE
9671 * character.h (CHAR_VALID_P): Remove unused parameter.
9672 * fontset.c, lisp.h, xdisp.c: All uses changed.
9673
045eb8d9
PE
9674 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9675
c1f134b5
PE
9676 * fns.c (concat): Minor tuning based on overflow analysis.
9677 This doesn't fix any bugs. Use int to hold character, instead
9678 of constantly refetching from Emacs object. Use XFASTINT, not
9679 XINT, for value known to be a character. Don't bother comparing
9680 a single byte to 0400, as it's always less.
9681
395fcb93 9682 * floatfns.c (Fexpt):
327eeec8
PE
9683 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9684
abbd3d23
PE
9685 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9686 for characters.
9687
684a03ef
PE
9688 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9689
0fed43f3
PE
9690 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9691 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9692 incorrectly succeed when S was a string, because 4294967386 was
9693 truncated before it was used.
9694
8fd02eb7
PE
9695 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9696 Otherwise, an out-of-range integer could cause undefined behavior
9697 on a 64-bit host.
9698
f8c86b69
PE
9699 * composite.c: Use int, not EMACS_INT, for characters.
9700 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9701 EMACS_INT, for values that are known to be in character range.
9702 This doesn't fix any bugs but is the usual style inside Emacs and
9703 may generate better code on 32-bit machines.
9704
34206dd2
PE
9705 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9706 This is for reasons similar to the recent CHAR_STRING fix.
9707 * charset.c (Fencode_char): Check that character arg is actually
9708 a character. Pass an int to ENCODE_CHAR.
9709 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9710 wider than 'int', as a compile-time check to prevent future regressions
9711 in this area.
9712
c5958d4c 9713 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9714
9715 Make sure a 64-bit char is never passed to CHAR_STRING.
9716 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9717 by silently ignoring the top 32 bits, allowing some values
9718 that were far too large to be valid characters.
9719 * character.h: Include <verify.h>.
9720 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9721 arguments are no wider than unsigned, as a compile-time check
9722 to prevent future regressions in this area.
9723 * data.c (Faset):
01103c44 9724 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9725 (Fsubst_char_in_region):
9726 * fns.c (concat):
9727 * xdisp.c (decode_mode_spec_coding):
9728 Adjust to CHAR_STRING's new requirement.
9729 * editfns.c (Finsert_char, Fsubst_char_in_region):
9730 * fns.c (concat): Check that character args are actually
9731 characters. Without this test, these functions did the wrong
9732 thing with wildly out-of-range values on 64-bit hosts.
9733
d37ca623
PE
9734 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9735 These casts should not be needed on 32-bit hosts, either.
9736 * keyboard.c (read_char):
9737 * lread.c (Fload): Remove casts to unsigned.
9738
ea204efb
PE
9739 * lisp.h (UNSIGNED_CMP): New macro.
9740 This fixes comparison bugs on 64-bit hosts.
9741 (ASCII_CHAR_P): Use it.
9742 * casefiddle.c (casify_object):
01103c44 9743 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9744 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9745 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9746 * dispextern.h (FACE_FROM_ID):
9747 * keyboard.c (read_char): Use UNSIGNED_CMP.
9748
41cb286c
PE
9749 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9750 not to EMACS_INT, to avoid GCC warning.
9751
4a1b9832
PE
9752 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9753
55daad71
PE
9754 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9755 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9756 isn't needed on 32-bit machines.
8f95c75c 9757
01103c44
PE
9758 * buffer.c (Fgenerate_new_buffer_name):
9759 Use EMACS_INT for count, not int.
0ceccced 9760 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9761
9762 * data.c (Qcompiled_function): Now static.
9763
c6f072e7
PE
9764 * window.c (window_body_lines): Now static.
9765
20ce5912
PE
9766 * image.c (gif_load): Rename local to avoid shadowing.
9767
9c4c5f81
PE
9768 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9769 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9770 * alloc.c (make_save_value): Integer argument is now of type
9771 ptrdiff_t, not int.
9772 (mark_object): Use ptrdiff_t, not int.
9773 * lisp.h (pD): New macro.
9774 * print.c (print_object): Use it.
9775
c0c5c8ae
PE
9776 * alloc.c: Use EMACS_INT, not int, to count objects.
9777 (total_conses, total_markers, total_symbols, total_vector_size)
9778 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9779 (total_free_floats, total_floats, total_free_intervals)
9780 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9781 Now EMACS_INT, not int. All uses changed.
9782 (Fgarbage_collect): Compute overall total using a double, so that
9783 integer overflow is less likely to be a problem. Check for overflow
9784 when converting back to an integer.
5a25e253
PE
9785 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9786 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9787 These were 'int' variables that could overflow on 64-bit hosts;
9788 they were never used, so remove them instead of repairing them.
211a0b2a 9789 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9790 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9791 Previously, this ceilinged at INT_MAX, but that doesn't work on
9792 64-bit machines.
e46bb31a 9793 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9794
c78baabf 9795 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9796 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9797 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9798 when a (possibly-narrower) signed value would do just as well.
9799 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9800
c9d624c6
PE
9801 * alloc.c: Catch some string size overflows that we were missing.
9802 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9803 for convenience in STRING_BYTES_MAX.
9804 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9805 The definition here is exact; the one in lisp.h was approximate.
9806 (allocate_string_data): Check for string overflow. This catches
9807 some instances we weren't catching before. Also, it catches
9808 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9809 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9810 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9811
c9d624c6
PE
9812 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9813 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9814 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9815
353032ce
PE
9816 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9817
2bccce07
PE
9818 * alloc.c (Fmake_string): Check for out-of-range init.
9819
0ac30604
SM
98202011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9821
9822 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9823
c195f2de
JD
98242011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9825
9826 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9827 xg_get_default_scrollbar_width.
9828
9829 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9830 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9831 (style_changed_cb): Call update_theme_scrollbar_width and call
9832 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9833 all frames (Bug#8505).
9834 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9835 Call gtk_window_set_resizable if HAVE_GTK3.
9836 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9837 and height if HAVE_GTK3 (Bug#8505).
9838 (scroll_bar_width_for_theme): New variable.
9839 (update_theme_scrollbar_width): New function.
9840 (xg_get_default_scrollbar_width): Move code to
9841 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9842 (xg_initialize): Call update_theme_scrollbar_width.
9843
9844 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9845
9846 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9847
e10ac9f1
MR
98482011-06-12 Martin Rudalics <rudalics@gmx.at>
9849
9850 * frame.c (make_frame): Call other_buffer_safely instead of
9851 other_buffer.
9852
9853 * window.c (temp_output_buffer_show): Call display_buffer with
9854 second argument Vtemp_buffer_show_specifiers and reset latter
9855 immediately after the call.
9856 (Vtemp_buffer_show_specifiers): New variable.
9857 (auto_window_vscroll_p, next_screen_context_lines)
9858 (Vscroll_preserve_screen_position): Remove leading asterisks from
9859 doc-strings.
9860
2d3c217e 98612011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9862
7b7f97e8 9863 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9864 * buffer.c (Qclone_number): Remove for now, as it's unused.
9865 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9866 (record_buffer): Remove unused local.
9867 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9868 (set_frame_buffer_list): Remove; unused.
9869 * frame.h (other_visible_frames): Remove decl.
9870 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9871 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9872 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9873 if HAVE_GPM.
9874 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9875 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9876 Define only if HAVE_GPM.
9877 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9878 (update_hints_inhibit): Remove; never set. All uses removed.
9879 * widgetprv.h (emacsFrameClassRec): Remove decl.
9880 * window.c (delete_deletable_window): Now returns void, since it
9881 wasn't returning anything.
9882 (compare_window_configurations): Remove unused locals.
9883 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9884 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9885 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9886 the same widths as pointers. This follows up on the 2011-05-06 patch.
9887 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9888 * xterm.h: Likewise.
9889 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9890
1384b89e
JB
98912011-06-12 Juanma Barranquero <lekktu@gmail.com>
9892
9893 * makefile.w32-in: Update dependencies.
9894 (LISP_H): Add lib/intprops.h.
9895
1100a63c
CY
98962011-06-11 Chong Yidong <cyd@stupidchicken.com>
9897
9898 * image.c (gif_load): Add animation frame delay to the metadata.
9899 (syms_of_image): Use DEFSYM. New symbol `delay'.
9900
6198ccd0
MR
99012011-06-11 Martin Rudalics <rudalics@gmx.at>
9902
9903 * window.c (delete_deletable_window): Re-add.
9904 (Fset_window_configuration): Rewrite to handle dead buffers and
9905 consequently deletable windows.
9906 (window_tree, Fwindow_tree): Remove. Supply functionality in
9907 window.el.
9908 (compare_window_configurations): Simplify code.
9909
b6e3633c
AS
99102011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9911
1ab0dee5
AS
9912 * image.c (imagemagick_load_image): Fix type mismatch.
9913 (Fimagemagick_types): Likewise.
9914
b6e3633c
AS
9915 * window.h (replace_buffer_in_windows): Declare.
9916
9397e56f
MR
99172011-06-11 Martin Rudalics <rudalics@gmx.at>
9918
9919 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9920 Qclone_number. Remove external declaration of Qdelete_window.
9921 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9922 code.
640c8776
SM
9923 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9924 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9925 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9926 buffer list implementation.
9927 (other_buffer_safely): New function.
9928 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9929 calls to replace_buffer_in_windows and
9930 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9931 if allowed.
9932 (record_buffer): Inhibit quitting and rewrite using quittable
9933 functions. Run Qbuffer_list_update_hook if allowed.
9934 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9935 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9936 Move switch-to-buffer to window.el.
9397e56f
MR
9937 (bury-buffer): Move to window.el.
9938 (Vbuffer_list_update_hook): New variable.
9939
9940 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9941 section.
9942
9943 * window.h (resize_frame_windows): Move up in code.
9944 (Fwindow_frame): Remove EXFUN.
9945 (replace_buffer_in_all_windows): Remove prototype.
9946 (replace_buffer_in_windows_safely): Add prototype.
9947
9948 * window.c: Declare Qdelete_window static again. Move down
9949 declaration of select_count.
9950 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9951 (Fother_window): Move to window.el.
9952 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9953 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9954 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9955 window.el.
9956 (replace_buffer_in_windows): Implement by calling
9957 Qreplace_buffer_in_windows.
9958 (replace_buffer_in_all_windows): Remove with some functionality
9959 moved into replace_buffer_in_windows_safely.
9960 (replace_buffer_in_windows_safely): New function.
9961 (select_window_norecord, select_frame_norecord): Move in front
9962 of run_window_configuration_change_hook. Remove now obsolete
9963 declarations.
640c8776
SM
9964 (Fset_window_buffer): Rewrite doc-string.
9965 Call Qrecord_window_buffer.
9397e56f
MR
9966 (keys_of_window): Move binding for other-window to window.el.
9967
b50691aa
CY
99682011-06-11 Chong Yidong <cyd@stupidchicken.com>
9969
9970 * dispextern.h (struct image): Replace data member, whose int_val
9971 and ptr_val fields were not used by anything, with a single
9972 lisp_val object.
9973
9974 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9975 (gif_clear_image, gif_load, imagemagick_load_image)
9976 (gs_clear_image, gs_load): Callers changed.
9977
3f754b86
PE
99782011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9979
cca69397
PE
9980 * buffer.h: Include <time.h>, for time_t.
9981 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9982
109e28d0
PE
9983 Fix minor problems found by static checking.
9984
60737f02
PE
9985 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9986
4b66faf3
PE
9987 Make identifiers static if they are not used in other modules.
9988 * data.c (Qcompiled_function, Qframe, Qvector):
9989 * image.c (QimageMagick, Qsvg):
9990 * minibuf.c (Qmetadata):
9991 * window.c (resize_window_check, resize_root_window): Now static.
9992 * window.h (resize_window_check, resize_root_window): Remove decls.
9993
109e28d0
PE
9994 * window.c (window_deletion_count, delete_deletable_window):
9995 Remove; unused.
46a4ce9e
PE
9996 (window_body_lines): Now static.
9997 (Fdelete_other_windows_internal): Mark vars as initialized.
9998 Make sure 'resize_failed' is initialized.
9999 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10000 (resize_window_apply): Remove unused local.
10001 * window.h (delete_deletable_window): Remove decl.
10002
109e28d0 10003 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10004 (imagemagick_load_image): Fix pointer signedness problem by changing
10005 last arg from unsigned char * to char *. All uses changed.
10006 Also, fix a local for similar reasons.
10007 Remove unused locals. Remove locals to avoid shadowing.
10008 (fn_rsvg_handle_free): Remove; unused.
10009 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10010 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10011
3f754b86
PE
10012 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10013
2547adb1
CY
100142011-06-10 Chong Yidong <cyd@stupidchicken.com>
10015
10016 * image.c (gif_load): Fix omitted cast error introduced by
10017 2011-06-06 change.
10018
2c8e37d4
MR
100192011-06-10 Martin Rudalics <rudalics@gmx.at>
10020
10021 * window.h (resize_proportionally, orig_total_lines)
10022 (orig_top_line): Remove from window structure.
10023 (set_window_height, set_window_width, change_window_heights)
10024 (Fdelete_window): Remove prototypes.
10025 (resize_frame_windows): Remove duplicate declaration.
10026
440a42e3
EZ
100272011-06-10 Eli Zaretskii <eliz@gnu.org>
10028
10029 * window.h (resize_frame_windows, resize_window_check)
10030 (delete_deletable_window, resize_root_window)
10031 (resize_frame_windows): Declare prototypes.
10032
10033 * window.c (resize_window_apply): Make definition be "static" to
10034 match the prototype.
10035
562dd5e9
MR
100362011-06-10 Martin Rudalics <rudalics@gmx.at>
10037
10038 * window.c: Remove declarations of Qwindow_size_fixed,
10039 window_min_size_1, window_min_size_2, window_min_size,
10040 size_window, window_fixed_size_p, enlarge_window, delete_window.
10041 Remove static from declaration of Qdelete_window, it's
10042 temporarily needed by Fbury_buffer.
10043 (replace_window): Don't assign orig_top_line and
10044 orig_total_lines.
10045 (Fdelete_window, delete_window): Remove. Window deletion is
10046 handled by window.el.
640c8776
SM
10047 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10048 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10049 (Fdelete_other_windows): Remove. Deleting other windows is
10050 handled by window.el.
10051 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10052 handled in window.el.
10053 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10054 Window minimum sizes are handled in window.el.
10055 (shrink_windows, size_window, set_window_height)
10056 (set_window_width, change_window_heights, window_height)
10057 (window_width, CURBEG, CURSIZE, enlarge_window)
10058 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10059 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10060 handled in window.el.
10061 (make_dummy_parent): Rename to make_parent_window and give it a
10062 second argument horflag.
10063 (make_window): Don't set resize_proportionally any more.
10064 (Fsplit_window): Remove. Windows are split in window.el.
10065 (save_restore_action, save_restore_orig_size)
10066 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10067 Resize mini windows in window.el.
10068 (grow_mini_window, shrink_mini_window): Implement by calling
10069 Qresize_root_window_vertically, resize_window_check and
10070 resize_window_apply.
640c8776
SM
10071 (saved_window, Fset_window_configuration, save_window_save):
10072 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10073 resize_proportionally.
10074 (window_min_height, window_min_width): Move to window.el.
10075 (keys_of_window): Move bindings for delete-other-windows,
10076 split-window, delete-window and enlarge-window to window.el.
10077
10078 * buffer.c: Temporarily extern Qdelete_window.
10079 (Fbury_buffer): Temporarily call Qdelete_window instead of
10080 Fdelete_window (Fbury_buffer will move to window.el soon).
10081
10082 * frame.c (set_menu_bar_lines_1): Remove code handling
10083 orig_top_line and orig_total_lines.
10084
10085 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10086 set_window_height but set heights directly.
10087 (change_frame_size_1): Use resize_frame_windows.
10088
10089 * xdisp.c (init_xdisp): Don't use set_window_height but set
10090 heights directly.
10091
640c8776
SM
10092 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10093 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10094 run_window_configuration_change_hook.
10095
10096 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10097 instead of change_window_heights and run
10098 run_window_configuration_change_hook.
10099
1a13852e
MR
101002011-06-09 Martin Rudalics <rudalics@gmx.at>
10101
10102 * window.c (replace_window): Rename second argument REPLACEMENT to
10103 NEW. New third argument SETFLAG. Rewrite.
10104 (delete_window, make_dummy_parent): Call replace_window with
10105 third argument 1.
10106 (window_list_1): Move down in code.
10107 (run_window_configuration_change_hook): Move set_buffer part
10108 before select_frame_norecord part in order to unwind correctly.
10109 Rename count1 to count.
10110 (recombine_windows, delete_deletable_window, resize_root_window)
10111 (Fdelete_other_windows_internal)
10112 (Frun_window_configuration_change_hook, make_parent_window)
10113 (resize_window_check, resize_window_apply, Fresize_window_apply)
10114 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10115 (Fdelete_window_internal, Fresize_mini_window_internal):
10116 New functions.
1a13852e
MR
10117 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10118
f3d1777e
MR
101192011-06-08 Martin Rudalics <rudalics@gmx.at>
10120
496e208e
MR
10121 * window.h (window): Add some new members to window structure -
10122 normal_lines, normal_cols, new_total, new_normal, clone_number,
10123 splits, nest, prev_buffers, next_buffers.
10124 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10125 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10126
f3d1777e
MR
10127 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10128 Remove.
496e208e
MR
10129 (make_dummy_parent): Set new members of windows structure.
10130 (make_window): Move down in code. Handle new members of window
10131 structure.
10132 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10133 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10134 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10135 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10136 (Fset_window_next_buffers, Fset_window_clone_number):
10137 New functions.
496e208e
MR
10138 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10139 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10140 Doc-string fixes.
10141 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10142 Argument WINDOW can be now internal window too.
10143 (Fwindow_use_time): Move up in code.
10144 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10145 Rewrite doc-string.
10146 (Fset_window_configuration, saved_window)
10147 (Fcurrent_window_configuration, save_window_save): Handle new
10148 members of window structure.
b9e809c2
MR
10149 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10150 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10151 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10152 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10153 Qget_mru_window, Qresize_root_window,
10154 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10155 Qauto_buffer_name; staticpro them.
f3d1777e 10156
abde8f8c
MR
101572011-06-07 Martin Rudalics <rudalics@gmx.at>
10158
10159 * window.c (Fwindow_total_size, Fwindow_left_column)
10160 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10161 (Fwindow_list_1): New functions.
10162 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10163 (Fwindow_width, Fscroll_left, Fscroll_right):
10164 Use window_body_cols instead of window_box_text_cols.
10165 (delete_window, Fset_window_configuration):
10166 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10167 (delete_all_subwindows): Take a window as argument and not a
10168 structure. Rewrite.
190b47e6
MR
10169 (window_loop): Remove handling of GET_LRU_WINDOW and
10170 GET_LARGEST_WINDOW.
10171 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10172
10173 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10174 window_box_text_cols. delete_all_subwindows now takes a
10175 Lisp_Object as argument.
abde8f8c 10176
640c8776
SM
10177 * indent.c (compute_motion, Fcompute_motion):
10178 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10179
fa8a67e6
MR
10180 * frame.c (delete_frame): Call delete_all_subwindows with root
10181 window as argument.
10182
a54e3482
DC
101832011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10184
10185 * fns.c (Fputhash): Document return value.
10186
60002bf5
CY
101872011-06-06 Chong Yidong <cyd@stupidchicken.com>
10188
10189 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10190
0c671da6 101912011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10192
b862a52a 10193 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10194
be44ca6c
PE
10195 Check for overflow when converting integer to cons and back.
10196 * charset.c (Fdefine_charset_internal, Fdecode_char):
10197 Use cons_to_unsigned to catch overflow.
10198 (Fencode_char): Use INTEGER_TO_CONS.
10199 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10200 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10201 * data.c (long_to_cons, cons_to_long): Remove.
10202 (cons_to_unsigned, cons_to_signed): New functions.
10203 These signal an error for invalid or out-of-range values.
10204 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10205 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10206 * font.c (Ffont_variation_glyphs):
10207 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10208 * lisp.h: Include <intprops.h>.
10209 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10210 (cons_to_signed, cons_to_unsigned): New decls.
10211 (long_to_cons, cons_to_long): Remove decls.
10212 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10213 (Fprimitive_undo): Use CONS_TO_INTEGER.
10214 * xfns.c (Fx_window_property): Likewise.
10215 * xselect.c: Include <limits.h>.
10216 (x_own_selection, selection_data_to_lisp_data):
10217 Use INTEGER_TO_CONS.
10218 (x_handle_selection_request, x_handle_selection_clear)
10219 (x_get_foreign_selection, Fx_disown_selection_internal)
10220 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10221 (lisp_data_to_selection_data): Use cons_to_unsigned.
10222 (x_fill_property_data): Use cons_to_signed.
10223 Report values out of range.
10224
d1f3d2af
PE
10225 Check for buffer and string overflow more precisely.
10226 * buffer.h (BUF_BYTES_MAX): New macro.
10227 * lisp.h (STRING_BYTES_MAX): New macro.
10228 * alloc.c (Fmake_string):
10229 * character.c (string_escape_byte8):
10230 * coding.c (coding_alloc_by_realloc):
10231 * doprnt.c (doprnt):
10232 * editfns.c (Fformat):
10233 * eval.c (verror):
10234 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10235 since they may not be the same number.
10236 * editfns.c (Finsert_char):
10237 * fileio.c (Finsert_file_contents):
10238 Likewise for BUF_BYTES_MAX.
10239
dd52fcea
PE
10240 * image.c: Use ptrdiff_t, not int, for sizes.
10241 (slurp_file): Switch from int to ptrdiff_t.
10242 All uses changed.
10243 (slurp_file): Check that file size fits in both size_t (for
10244 malloc) and ptrdiff_t (for sanity and safety).
10245
7f9bbdbb
PE
10246 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10247 if b->modtime has its maximal value.
10248
dfe18f82
PE
10249 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10250
84acfcf0
PE
10251 Don't assume time_t can fit into int.
10252 * buffer.h (struct buffer.modtime): Now time_t, not int.
10253 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10254 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10255
ccd9a01a
PE
10256 Minor fixes for signed vs unsigned integers.
10257 * character.h (MAYBE_UNIFY_CHAR):
10258 * charset.c (maybe_unify_char):
10259 * keyboard.c (read_char, reorder_modifiers):
10260 XINT -> XFASTINT, since the integer must be nonnegative.
10261 * ftfont.c (ftfont_spec_pattern):
10262 * keymap.c (access_keymap, silly_event_symbol_error):
10263 XUINT -> XFASTINT, since the integer must be nonnegative.
10264 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10265 since it makes no difference and we prefer signed.
10266 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10267 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10268 nonnegative.
10269
d6d100dd
SM
102702011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10271
10272 * window.h (Fwindow_frame): Declare.
10273
2b6148e4
PE
102742011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10275
10276 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10277 (SPARE_MEMORY): Always define.
10278 (LARGE_REQUEST): Remove.
10279 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10280
f230ecc9
MR
102812011-06-06 Martin Rudalics <rudalics@gmx.at>
10282
727e958e
MR
10283 * lisp.h: Move EXFUNS for Fframe_root_window,
10284 Fframe_first_window and Fset_frame_selected_window to window.h.
10285
10286 * window.h: Move EXFUNS for Fframe_root_window,
10287 Fframe_first_window and Fset_frame_selected_window here from
10288 lisp.h.
10289
10290 * frame.c (Fwindow_frame, Fframe_first_window)
10291 (Fframe_root_window, Fframe_selected_window)
10292 (Fset_frame_selected_window): Move to window.c.
10293 (Factive_minibuffer_window): Move to minibuf.c.
10294 (Fother_visible_frames_p): New function.
10295
10296 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10297
f230ecc9
MR
10298 * window.c (decode_window, decode_any_window): Move up in code.
10299 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10300 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10301 (Fwindow_buffer): Move up and rewrite doc-string.
10302 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10303 (Fwindow_prev): New functions.
727e958e
MR
10304 (Fwindow_frame): Move here from frame.c. Accept any window as
10305 argument.
10306 (Fframe_root_window, Fframe_first_window)
10307 (Fframe_selected_window): Move here from frame.c. Accept frame
10308 or arbitrary window as argument. Update doc-strings.
10309 (Fminibuffer_window): Move up in code.
10310 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10311 (Fset_frame_selected_window): Move here from frame.c.
10312 Marginal rewrite.
727e958e
MR
10313 (Fselected_window, select_window, Fselect_window): Move up in
10314 code. Minor doc-string fixes.
f230ecc9 10315
4d09bcf6
PE
103162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10317
10318 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10319 Do not assume that spare memory exists; that assumption is valid
10320 only if SYSTEM_MALLOC.
10321 (LARGE_REQUEST): New macro, so that the issue of large requests
10322 is separated from the issue of spare memory.
10323
810928a2
AS
103242011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10325
172418ad
AS
10326 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10327 format. (Bug#8806)
10328
43f862f7
AS
10329 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10330
810928a2
AS
10331 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10332 before statements.
10333
a059fe24
JD
103342011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10335
10336 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10337
10338 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10339
10340 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10341 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10342
989bf368
JB
103432011-06-05 Juanma Barranquero <lekktu@gmail.com>
10344
10345 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10346
4b80f674
CY
103472011-06-04 Chong Yidong <cyd@stupidchicken.com>
10348
10349 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10350 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10351 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10352 New error handlers.
4b80f674
CY
10353 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10354 Obey Vx_select_enable_clipboard_manager. Catch errors in
10355 x_clipboard_manager_save (Bug#8779).
10356 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10357 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10358
99a33b77 103592011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10360
10361 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10362
99a33b77 103632011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10364
10365 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10366 in the current matrix if keep_current_p is non-zero.
10367
8264569d
EZ
103682011-06-04 Eli Zaretskii <eliz@gnu.org>
10369
10370 * bidi.c (bidi_level_of_next_char): Fix last change.
10371
57f97249
EZ
103722011-06-03 Eli Zaretskii <eliz@gnu.org>
10373
fec2107c 10374 Support bidi reordering of text covered by display properties.
57f97249 10375
fec2107c
EZ
10376 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10377 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10378 (bidi_cache_search, bidi_cache_iterator_state)
10379 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10380 (bidi_level_of_next_char, bidi_move_to_visually_next):
10381 Support character positions inside a run of characters covered by a
fec2107c
EZ
10382 display string.
10383 (bidi_paragraph_init, bidi_resolve_explicit_1)
10384 (bidi_level_of_next_char): Call bidi_fetch_char and
10385 bidi_fetch_char_advance instead of FETCH_CHAR and
10386 FETCH_CHAR_ADVANCE.
10387 (bidi_init_it): Initialize new members.
10388 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10389 definitions.
10390 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10391 instead of using explicit *_CHAR codes.
d6d100dd
SM
10392 (bidi_resolve_explicit, bidi_resolve_weak):
10393 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10394 bidirectional text is supported only in multibyte buffers.
10395 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10396 it to initialize the frame_window_p member of struct bidi_it.
10397 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10398 (bidi_resolve_explicit, bidi_resolve_weak)
10399 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10400 bidi_it->nchars is non-positive.
10401 (bidi_level_of_next_char): Don't try to lookup the cache for the
10402 next/previous character if nothing is cached there yet, or if we
10403 were just reseat()'ed to a new position.
c40e2fb2 10404
0e14fe90
EZ
10405 * xdisp.c (set_cursor_from_row): Set start and stop points
10406 according to the row's direction when priming the loop that looks
10407 for the glyph on which to display cursor.
10408 (single_display_spec_intangible_p): Function deleted.
10409 (display_prop_intangible_p): Reimplement to call
10410 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10411 Accept 3 additional arguments needed by handle_display_spec.
10412 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10413 values: lists, `(when COND...)' forms, etc.
10414 (single_display_spec_string_p): Support property values that are
10415 lists with the argument STRING its top-level element.
10416 (display_prop_string_p): Fix the condition for processing a
10417 property that is a list to be consistent with handle_display_spec.
fec2107c 10418 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10419 last portion of handle_display_prop.
10420 (compute_display_string_pos): Accept additional argument
10421 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10422 value of a `display' property is a "replacing spec".
10423 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10424 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10425 the display property, but just return a value indicating whether
10426 the display property will replace the characters it covers.
10427 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10428 frame_window_p members of struct bidi_it.
d6d100dd
SM
10429 (compute_display_string_pos, compute_display_string_end):
10430 New functions.
fec2107c
EZ
10431 (push_it): Accept second argument POSITION, where pop_it should
10432 jump to continue iteration.
10433 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10434
fec2107c
EZ
10435 * keyboard.c (adjust_point_for_property): Adjust the call to
10436 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10437
10438 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10439 (bidi_init_it): Update prototypes.
10440 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10441 (compute_display_string_pos, compute_display_string_end):
10442 Declare prototypes.
fec2107c
EZ
10443 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10444 EMACS_INT.
fc6f18ce 10445
40087514 104462011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10447
57f53182
PE
10448 Malloc failure behavior now depends on size of allocation.
10449 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10450 * lisp.h: Change signatures accordingly.
10451 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10452 All callers changed. (Bug#8762)
10453
10454 * gnutls.c: Use Emacs's memory allocators.
10455 Without this change, the gnutls library would invoke malloc etc.
10456 directly, which causes problems on non-SYNC_INPUT hosts, and which
10457 runs afoul of improving memory_full behavior. (Bug#8761)
10458 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10459 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10460 xfree instead of the default malloc, realloc, free.
10461 (Fgnutls_boot): No need to check for memory allocation failure,
10462 since xmalloc does that for us.
10463
ac32cd99 10464 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10465 * category.c (hash_get_category_set):
10466 * ccl.c (ccl_driver):
10467 * charset.c (Fdefine_charset_internal):
10468 * charset.h (struct charset.hash_index):
10469 * composite.c (get_composition_id, gstring_lookup_cache)
10470 (composition_gstring_put_cache):
10471 * composite.h (struct composition.hash_index):
10472 * dispextern.h (struct image.hash):
10473 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10474 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10475 (hashfn_equal, hashfn_user_defined, make_hash_table)
10476 (maybe_resize_hash_table, hash_lookup, hash_put)
10477 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10478 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10479 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10480 * image.c (make_image, search_image_cache, lookup_image)
10481 (xpm_put_color_table_h):
10482 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10483 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10484 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10485 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10486 * alloc.c (allocate_vectorlike):
10487 Check for overflow in vector size calculations.
10488 * ccl.c (ccl_driver):
10489 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10490 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10491 need to be updated by these changes.
40087514
PE
10492 * fns.c (make_hash_table, maybe_resize_hash_table):
10493 Check for integer overflow with large hash tables.
0de4bb68
PE
10494 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10495 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10496 (SXHASH_REDUCE): New macro.
10497 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10498 Use it instead of discarding useful hash info with large hash values.
10499 (sxhash_float): New function.
10500 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10501 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10502 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10503 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10504 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10505 Adjust signatures to match updated version of code.
10506 (consing_since_gc): Now EMACS_INT, since a single hash table can
10507 use more than INT_MAX bytes.
10508
698d32e2
DN
105092011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10510
10511 Make it possible to build with GCC-4.6+ -O2 -flto.
10512
10513 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10514
fd6fa53f
SM
105152011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10516
10517 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10518 Call minibuffer-inactive-mode.
10519
864db017
JB
105202011-05-31 Juanma Barranquero <lekktu@gmail.com>
10521
10522 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10523 Update dependencies.
10524
2ad0baf4
DN
105252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10526
10527 * data.c (init_data): Remove code for UTS, this system is not
10528 supported anymore.
10529
4fcc2638
DN
105302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10531
10532 Don't force ./temacs to start in terminal mode.
10533
10534 * frame.c (make_initial_frame): Initialize faces in all cases, not
10535 only when CANNOT_DUMP is defined.
10536 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10537
c56e0fd5
DN
105382011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10539
10540 * dispnew.c (add_window_display_history): Use const for the string
10541 pointer. Remove declaration, not needed.
10542
333d54da 105432011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10544
55d4c1b2 10545 Use 'inline', not 'INLINE'.
333d54da 10546 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10547 * alloc.c, fontset.c (INLINE): Remove.
10548 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10549 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10550 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10551 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10552 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10553
738db178
DN
105542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10555
10556 Make it possible to run ./temacs.
10557
10558 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10559 syms_of_callproc does the same thing. Remove test for
10560 "initialized", do it in the caller.
10561 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10562
620c53a6
SM
105632011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10564
10565 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10566 (read_minibuf): Use get_minibuffer.
10567 (syms_of_minibuf): Use DEFSYM.
10568 (Qmetadata): New var.
10569 * data.c (Qbuffer): Don't make it static.
10570 (syms_of_data): Use DEFSYM.
10571
e003a292
PE
105722011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10573
10574 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10575 (CCL_CODE_MIN): New macro.
10576
ed008a6d
PE
105772011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10578
3687c2ef
PE
10579 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10580
ed008a6d
PE
10581 * eval.c (Qdebug): Now static.
10582 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10583 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10584 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10585
d66c4c7c
CY
105862011-05-29 Chong Yidong <cyd@stupidchicken.com>
10587
10588 * image.c: Various fixes to ImageMagick code comments.
10589 (Fimagemagick_types): Doc fix.
10590
5fbc2025
PE
105912011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10592
0196f88a
PE
10593 Minor fixes prompted by GCC 4.6.0 warnings.
10594
10595 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10596
5fbc2025
PE
10597 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10598 (x_clipboard_manager_save_all): Move extern decl to ...
10599 * xterm.h: ... here, so that it can be checked for consistency.
10600
1dd3c2d9
CY
106012011-05-29 Chong Yidong <cyd@stupidchicken.com>
10602
10603 * xselect.c (x_clipboard_manager_save_frame)
10604 (x_clipboard_manager_save_all): New functions.
10605 (Fx_clipboard_manager_save): Lisp function deleted.
10606
10607 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10608 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10609
10610 * xterm.h: Update prototype.
10611
5ba6571d
WX
106122011-05-28 William Xu <william.xwl@gmail.com>
10613
10614 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10615 exiting (Bug#8239).
10616
3eaff834
JM
106172011-05-28 Jim Meyering <meyering@redhat.com>
10618
e1900994 10619 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10620 * fns.c (to_uchar): Define.
10621 (crypto_hash_function): Use it to convert some newly-signed
10622 variables to unsigned, to avoid sign-extension bugs. For example,
10623 without this change, (md5 "truc") would evaluate to
10624 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10625 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10626 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10627
0f6990a7
PE
106282011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10629
10630 Integer overflow fixes.
c8a9ca5a 10631
08686060
PE
10632 * dbusbind.c: Serial number integer overflow fixes.
10633 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10634 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10635 to hold a serial number that is too large for a fixnum.
10636 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10637 Check for serial numbers out of range. Decode any serial number
59568bf0 10638 that was so large that it became a float. (Bug#8722)
08686060 10639
2d1fc3c7
PE
10640 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10641 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10642 Use XFASTINT rather than XUINT when numbers are nonnegative.
10643 (xd_append_arg, Fdbus_method_return_internal):
10644 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10645 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10646 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10647 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10648 (Bug#8722)
2d1fc3c7 10649
c8a9ca5a
PE
10650 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10651
519e1d69
PE
10652 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10653
6df6ae42 10654 ccl: Add integer overflow checks.
30569699
PE
10655 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10656 (IN_INT_RANGE): New macros.
10657 (ccl_driver): Use them to check for integer overflow when
10658 decoding a CCL program. Many of the new checks are whether XINT (x)
10659 fits in int; it doesn't always, on 64-bit hosts. The new version
10660 doesn't catch all possible integer overflows, but it's an
847044ea 10661 improvement. (Bug#8719)
30569699 10662
c11285dc
PE
10663 * alloc.c (make_event_array): Use XINT, not XUINT.
10664 There's no need for unsigned here.
10665
fdccd48e
PE
10666 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10667 This follows up to the 2011-05-06 change that substituted uintptr_t
10668 for EMACS_INT. This case wasn't caught back then.
10669
37910ab2
PE
10670 Rework Fformat to avoid integer overflow issues.
10671 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10672 now (part of C89). Include <verify.h>.
10673 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10674 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10675 (Fformat): Avoid the prepass trying to compute sizes; it was only
10676 approximate and thus did not catch overflow reliably. Instead, walk
10677 through the format just once, formatting and computing sizes as we go,
10678 checking for integer overflow at every step, and allocating a larger
10679 buffer as needed. Keep track separately whether the format is
10680 multibyte. Keep only the most-recently calculated precision, rather
10681 than them all. Record whether each argument has been converted to
10682 string. Use EMACS_INT, not int, for byte and char and arg counts.
10683 Support field widths and precisions larger than INT_MAX. Avoid
10684 sprintf's undefined behavior with conversion specifications such as %#d
10685 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10686 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10687 formatting out-of-range floating point numbers with int
9173deec 10688 formats. (Bug#8668)
37910ab2 10689
2e6578fb
PE
10690 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10691
0ae6bdee
PE
10692 * data.c: Avoid integer truncation in expressions involving floats.
10693 * data.c: Include <intprops.h>.
10694 (arith_driver): When there's an integer overflow in an expression
10695 involving floating point, convert the integers to floating point
10696 so that the resulting value does not suffer from catastrophic
10697 integer truncation. For example, on a 64-bit host (* 4
10698 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10699 Do not rely on undefined behavior after integer overflow.
10700
de883a70
PE
10701 merge count_size_as_multibyte, parse_str_to_multibyte
10702 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10703 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10704 Check for integer overflow.
10705 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10706 since it's now a duplicate of the other. This is more of
10707 a character than a buffer op, so better that it's in character.c.
10708 * fns.c, print.c: Adjust to above changes.
10709
2ff916cb
PE
107102011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10711
10712 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10713
f1b54466
PE
107142011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10715
fb1ac845
PE
10716 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10717 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10718 (x_clipboard_manager_save): Now static.
10719 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10720
f1b54466
PE
10721 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10722 (crypto_hash_function): Now static.
10723 Fix pointer signedness problems. Avoid unnecessary initializations.
10724
a9f737ee
CY
107252011-05-27 Chong Yidong <cyd@stupidchicken.com>
10726
10727 * termhooks.h (Vselection_alist): Make it terminal-local.
10728
10729 * terminal.c (create_terminal): Initialize it.
10730
10731 * xselect.c: Support for clipboard managers.
10732 (Vselection_alist): Move to termhooks.h as terminal-local var.
10733 (LOCAL_SELECTION): New macro.
10734 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10735 (symbol_to_x_atom): Remove gratuitous arg.
10736 (x_handle_selection_request, lisp_data_to_selection_data)
10737 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10738 (x_own_selection, x_get_local_selection, x_convert_selection):
10739 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10740 (some_frame_on_display): Delete unused function.
10741 (Fx_own_selection_internal, Fx_get_selection_internal)
10742 (Fx_disown_selection_internal, Fx_selection_owner_p)
10743 (Fx_selection_exists_p): New optional frame arg.
10744 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10745 (x_handle_selection_clear): Don't treat other terminals with the
10746 same keyboard specially. Use the terminal-local Vselection_alist.
10747 (x_clear_frame_selections): Use Frun_hook_with_args.
10748
10749 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10750
10751 * xterm.h: Add support for those atoms.
10752
e067f0c1
CY
107532011-05-26 Chong Yidong <cyd@stupidchicken.com>
10754
10755 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10756 (converted_selections, conversion_fail_tag): New global variables.
10757 (x_selection_request_lisp_error): Free the above.
10758 (x_get_local_selection): Remove unnecessary code.
10759 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10760 of converted selections stored in converted_selections.
10761 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10762 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10763 (x_convert_selection): New function.
10764 (x_handle_selection_event): Simplify.
10765 (x_get_foreign_selection): Don't ignore incoming requests while
10766 waiting for an answer; this will fail when we implement
10767 SAVE_TARGETS, and seems unnecessary anyway.
10768 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10769 (Vx_sent_selection_functions): Doc fix.
10770
0f4aebc0
LL
107712011-05-26 Leo Liu <sdl.web@gmail.com>
10772
10773 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10774
e61124cd
YM
107752011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10776
10777 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10778
10779 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10780 for fringe update if it has periodic bitmap.
ac389d0c 10781 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10782 and fringe_bitmap_periodic_p.
10783
10784 * fringe.c (get_fringe_bitmap_data): New function.
10785 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10786 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10787 row. Mark glyph row for fringe update if periodicity changed.
10788
10789 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10790 for fringe update unless it has periodic bitmap.
10791
f16d9837
KH
107922011-05-25 Kenichi Handa <handa@m17n.org>
10793
10794 * xdisp.c (get_next_display_element): Set correct it->face_id for
10795 a static composition.
10796
e1b90ef6
LL
107972011-05-24 Leo Liu <sdl.web@gmail.com>
10798
10799 * deps.mk (fns.o):
10800 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10801
10802 * fns.c (crypto_hash_function, Fsha1): New function.
10803 (Fmd5): Use crypto_hash_function.
10804 (syms_of_fns): Add Ssha1.
10805
7400048f
PE
108062011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10807
10808 * gnutls.c: Remove unused macros.
10809 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10810 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10811 Remove macros that are defined and never used.
10812 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10813
abb71cf4
CY
108142011-05-22 Chong Yidong <cyd@stupidchicken.com>
10815
10816 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10817 (Fx_get_selection_internal): Minor cleanup.
10818 (Fx_own_selection_internal): Rename arguments for consistency with
10819 select.el.
10820
6307db39
PE
108212011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10822
10823 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10824
f3d4e0a4
CY
108252011-05-22 Chong Yidong <cyd@stupidchicken.com>
10826
10827 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10828
4d8ade89
YM
108292011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10830
10831 * dispnew.c (scrolling_window): Don't exclude the case that the
10832 last enabled row in the desired matrix touches the bottom boundary.
10833
32078c8d
GM
108342011-05-21 Glenn Morris <rgm@gnu.org>
10835
10836 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10837 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10838 and add some more files.
32078c8d 10839
7285dc67
EZ
108402011-05-20 Eli Zaretskii <eliz@gnu.org>
10841
10842 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10843 report_file_error introduced by the change from 2011-05-07.
10844
89d1bd22
PE
108452011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10846
10847 * systime.h (Time): Define only if emacs is defined.
10848 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10849 where the include path doesn't have X11/X.h by default. See
10850 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10851
cd394be1 108522011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10853
10854 * composite.c (find_automatic_composition): Fix previous change.
10855
b9704ad9
GM
108562011-05-20 Glenn Morris <rgm@gnu.org>
10857
10858 * lisp.mk: New file, split from Makefile.in.
10859 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10860 (shortlisp): Remove.
10861 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10862
4a720484
GM
108632011-05-19 Glenn Morris <rgm@gnu.org>
10864
10865 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10866 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10867 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10868 (lisp): Set the order to that of loadup.el.
10869 (shortlisp): Make it a copy of $lisp.
10870 (SOME_MACHINE_LISP): Remove.
10871 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10872 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10873
a28d4396
KH
108742011-05-18 Kenichi Handa <handa@m17n.org>
10875
10876 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10877 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10878 (find_automatic_composition): Mostly rewrite for efficiency.
10879
a2b1fa8e
JB
108802011-05-18 Juanma Barranquero <lekktu@gmail.com>
10881
10882 * makefile.w32-in: Update dependencies.
10883
8e1f5610
CS
108842011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10885
10886 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10887 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10888
7025ee00 108892011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10890
cdfa6eab
PE
10891 Fix some integer overflow issues, such as string length overflow.
10892
06d6db33
PE
10893 * insdel.c (count_size_as_multibyte): Check for string overflow.
10894
2b4560a8
PE
10895 * character.c (lisp_string_width): Check for string overflow.
10896 Use EMACS_INT, not int, for string indexes and lengths; in
10897 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10898 the resulting string length overflows an EMACS_INT; instead,
10899 report a string overflow if no precision given. When checking for
10900 precision exhaustion, use a check that cannot possibly have
10901 integer overflow. (Bug#8675)
10902 * character.h (lisp_string_width): Adjust to new signature.
10903
cb93f9be
PE
10904 * alloc.c (string_overflow): New function.
10905 (Fmake_string): Use it. This doesn't change behavior, but saves
10906 a few bytes and will simplify future changes.
10907 * character.c (string_escape_byte8): Likewise.
10908 * lisp.h (string_overflow): New decl.
10909
1a1f3366
PE
10910 Fixups, following up to the user-interface timestamp change.
10911 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10912 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10913 * msdos.c (mouse_get_pos): Likewise.
10914 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10915 * w32gui.h (Time): Define by including "systime.h" rather than by
10916 declaring it ourselves. (Bug#8664)
10917
d4e3e4d3
PE
10918 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10919 * image.c (clear_image_cache): Likewise.
10920
f6a24d19
PE
10921 * term.c (term_mouse_position): Don't assume time_t wraparound.
10922
08dc5ae6
PE
10923 Be more systematic about user-interface timestamps.
10924 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10925 and sometimes 'EMACS_UINT', to represent these timestamps.
10926 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10927 This makes the code easier to follow, and makes it easier to catch
10928 integer overflow bugs such as Bug#8664.
10929 * frame.c (Fmouse_position, Fmouse_pixel_position):
10930 Use Time, not unsigned long, for user-interface timestamps.
10931 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10932 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10933 * keyboard.h (last_event_timestamp): Likewise.
10934 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10935 * menu.h (xmenu_show): Likewise.
10936 * term.c (term_mouse_position): Likewise.
10937 * termhooks.h (struct input_event.timestamp): Likewise.
10938 (struct terminal.mouse_position_hook): Likewise.
10939 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10940 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10941 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10942 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10943 what it was before.
10944 * menu.h, termhooks.h: Include "systime.h", for Time.
10945
8e55734a
PE
10946 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10947 Don't assume that the difference between two unsigned long values
10948 can fit into an integer. At this point, we know button_down_time
10949 <= event->timestamp, so the difference must be nonnegative, so
10950 there's no need to cast the result if double-click-time is
10951 nonnegative, as it should be; check that it's nonnegative, just in
10952 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10953 apart (about 25 days). (Bug#8664)
8e55734a 10954
841f1b75 10955 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10956 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10957
3e26f69c
PE
10958 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10959 that always fit in int. Use a sentinel instead of a counter, to
10960 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10961 * frame.h (struct frame): Use int for menu_bar_items_used
10962 instead of EMACS_INT, since it always fits in int.
3e26f69c 10963
5cc152c0
PE
10964 * menu.c (grow_menu_items): Check for int overflow.
10965
d89eb65e
PE
10966 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10967
5235bd3e
PE
10968 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10969 Before, the code was not consistent. These values cannot exceed
10970 2**31 - 1 so there's no need to make them unsigned.
10971 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10972 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10973 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10974 as modifiers.
10975 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10976
bc827e23
PE
10977 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10978 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10979 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10980 presumably because the widths might not match.
10981
78eb494e
PE
10982 * window.c (size_window): Avoid needless test at loop start.
10983
04f2d78b
CB
109842011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10985
10986 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10987
d2fc7e3d 109882011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10989
10990 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10991
d2fc7e3d 109922011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10993
10994 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10995 `width' to `bar_area_x' and `bar_area_width', respectively.
10996 (x_scroll_run): Take account of fringe background extension.
10997
04f2d78b
CB
10998 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10999 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11000 `bar_area_width', respectively.
11001 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11002 background extension.
11003
79b70037
GM
110042011-05-10 Jim Meyering <meyering@redhat.com>
11005
11006 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11007
2f142cc5
JB
110082011-05-10 Juanma Barranquero <lekktu@gmail.com>
11009
11010 * image.c (Finit_image_library): Return t for built-in image types,
11011 like pbm and xbm. (Bug#8640)
11012
57679c86
AS
110132011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11014
11015 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11016
888c9e86
EZ
110172011-05-07 Eli Zaretskii <eliz@gnu.org>
11018
b0512a1d
EZ
11019 * w32console.c (Fset_screen_color): Doc fix.
11020 (Fget_screen_color): New function.
11021 (syms_of_ntterm): Defsubr it.
11022
7285dc67
EZ
11023 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11024 unlink the temporary file if Fcall_process didn't create it in the
11025 first place.
11026 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11027 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11028 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11029 cue to call_process_cleanup not to close that handle.
11030
4d3fcc8e
BK
110312011-05-07 Ben Key <bkey76@gmail.com>
11032
11033 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11034 one of two shell specific rules, either bootstrap-temacs-CMD or
11035 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11036 to the previous implementation of the bootstrap-temacs rule.
11037 The bootstrap-temacs-CMD rule is similar to the previous
11038 implementation of the bootstrap-temacs rule except that it
11039 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11040 variable.
11041
11042 These changes, along with some changes to nt/configure.bat,
11043 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11044 earlier fix to add support for --cflags and --ldflags options
11045 that include quotes so that it works whether make uses cmd or
11046 sh as the shell.
11047
b4289b64
MA
110482011-05-06 Michael Albinus <michael.albinus@gmx.de>
11049
11050 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11051 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11052 is a constant.
11053 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11054 a string. Handle both cases.
11055 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11056 (Fdbus_register_method): Use Qinvalid_function.
11057
af4c0e28
JB
110582011-05-06 Juanma Barranquero <lekktu@gmail.com>
11059
11060 * makefile.w32-in: Update dependencies.
11061 (LISP_H): Add inttypes.h and stdin.h.
11062 (PROCESS_H): Add unistd.h.
11063
c51453d9
EZ
110642011-05-06 Eli Zaretskii <eliz@gnu.org>
11065
11066 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11067 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11068
8ff0ac3c 110692011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11070
4c4b566b
PE
11071 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11072
aab2b9b5
PE
11073 * term.c (vfatal): Remove stray call to va_end.
11074 It's not needed and the C Standard doesn't allow it here anyway.
11075
c378da0b
PE
11076 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11077 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11078
288b08c7
PE
11079 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11080 bytes.
11081
e3601888
PE
11082 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11083
db6c0e74
PE
11084 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11085
dd5963ea
PE
11086 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11087
88c9450f
PE
11088 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11089
2f9442b8
PE
11090 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11091
c032b5f8
PE
11092 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11093 * charset.c (Fdefine_charset_internal): Don't initialize
11094 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11095 32-bit int (Bug#8600).
a108c10b
PE
11096
11097 * lread.c (read_integer): Be more consistent with string-to-number.
11098 Use string_to_number to do the actual conversion; this avoids
11099 rounding errors and fixes some other screwups. Without this fix,
11100 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11101 (digit_to_number): Move earlier, for benefit of read_integer.
11102 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11103 not a digit in any supported base. (Bug#8602)
a108c10b 11104
ad5f9eea
PE
11105 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11106
aec1708a
PE
11107 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11108 to match comment at start of function. This also removes a
11109 GCC warning about overflow in a 32+64-bit port.
11110
47be4ab5
PE
11111 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11112
371cac43
PE
11113 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11114 Reported by Stefan Monnier in
11115 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11116 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11117 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11118
d01a7826
PE
11119 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11120 (EMACS_UINTPTR): Likewise, with uintptr_t.
11121
7fd47d5c
PE
11122 * lisp.h: Prefer 64-bit EMACS_INT if available.
11123 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11124 on 32-bit hosts that have 64-bit int, so that they can access
11125 large files.
122b0c86
PE
11126 However, temporarily disable this change unless the temporary
11127 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11128
8727937b
PE
11129 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11130
8ac068ac
PE
11131 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11132 This removes an assumption that EMACS_INT and long are the same
11133 width as pointers. The assumption is true for Emacs porting targets
11134 now, but we want to make other targets possible.
11135 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11136 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11137 In the rest of the code, change types of integers that hold casted
11138 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11139 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11140 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11141 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11142 No need to cast type when ORing.
11143 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11144 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11145 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11146 assume EMACS_INT is the same width as char *.
11147 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11148 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11149 Remove no-longer-needed casts.
11150 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11151 (xg_tool_bar_help_callback, xg_make_tool_item):
11152 Use EMACS_INTPTR to hold an integer
11153 that will be cast to void *; this can avoid a GCC warning
11154 if EMACS_INT is not the same width as void *.
11155 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11156 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11157 (current_message_1, set_message_1):
11158 Use a local to convert to proper width without a cast.
11159 * xmenu.c (dialog_selection_callback): Likewise.
11160
ede49d71
PE
11161 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11162 Also, don't assume VALBITS / RAND_BITS is less than 5,
11163 and don't rely on undefined behavior when shifting a 1 left into
11164 the sign bit.
11165 * lisp.h (get_random): Change signature to match.
11166
2f30ecd0
PE
11167 * lread.c (hash_string): Use size_t, not int, for hash computation.
11168 Normally we prefer signed values; but hashing is special, because
11169 it's better to use unsigned division on hash table sizes so that
11170 the remainder is nonnegative. Also, size_t is the natural width
11171 for hashing into memory. The previous code used 'int', which doesn't
11172 retain enough info to hash well into very large tables.
11173 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11174
2a866e7b
PE
11175 * dbusbind.c: Don't possibly lose pointer info when converting.
11176 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11177 Use XPNTR rather than XHASH, so that the high-order bits of
11178 the pointer aren't lost when converting through void *.
11179
51639eac
PE
11180 * eval.c (Fautoload): Don't double-shift a pointer.
11181
92394119
PE
11182 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11183
dbdb9a7c
JB
111842011-05-06 Juanma Barranquero <lekktu@gmail.com>
11185
11186 * gnutls.c (DEF_GNUTLS_FN):
11187 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11188
db7a0b4f
AS
111892011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11190
11191 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11192 marker. (Bug#8610)
11193
cd394be1 111942011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11195
11196 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11197 New version that can reserve upto 2GB of heap space.
11198
f7ff1b0f 111992011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11200
11201 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11202
639c109b
TZ
112032011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11204
11205 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11206 `gnutls_certificate_set_x509_key_file'.
11207
d2127135
JB
112082011-05-05 Juanma Barranquero <lekktu@gmail.com>
11209
11210 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11211 Update dependencies.
11212
e968f4f3
JB
112132011-05-04 Juanma Barranquero <lekktu@gmail.com>
11214
11215 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11216 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11217 Remove unused parameter `fildes'.
11218 * process.c (read_process_output, send_process): Don't pass it.
11219
84d358f0
JB
112202011-05-04 Juanma Barranquero <lekktu@gmail.com>
11221
11222 Fix previous change: the library cache is defined in w32.c.
11223 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11224 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11225
0898ca10
JB
112262011-05-04 Juanma Barranquero <lekktu@gmail.com>
11227
11228 Implement dynamic loading of GnuTLS on Windows.
11229
11230 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11231 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11232 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11233 Declare.
11234
11235 * gnutls.c (Qgnutls_dll): Define.
11236 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11237 (gnutls_*): Declare function pointers.
11238 (init_gnutls_functions): New function to initialize function pointers.
11239 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11240 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11241 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11242 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11243 (emacs_gnutls_write, emacs_gnutls_read)
11244 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11245 (Fgnutls_available_p): New function.
11246 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11247 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11248 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11249
11250 * image.c: Include w32.h.
11251 (Vimage_type_cache): Delete.
11252 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11253 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11254 (w32_delayed_load): Move to w32.c.
11255
11256 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11257
11258 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11259 (w32_delayed_load): Move from image.c. When loading a library, record
11260 its filename in the :loaded-from property of the library id.
11261 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11262 Initialize and staticpro them.
11263 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11264
11265 * process.c: Include lisp.h before w32.h, not after.
11266 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11267 instead of gnutls_record_check_pending.
11268
11269 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11270
ff4de4aa
TZ
112712011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11272
11273 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11274 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11275 as passed in.
11276
abe95abb
JD
112772011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11278
11279 * xterm.c (x_set_frame_alpha): Do not set property on anything
11280 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11281
e16e55d4
JB
112822011-05-02 Juanma Barranquero <lekktu@gmail.com>
11283
11284 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11285
bafcf6a5
JB
112862011-05-02 Juanma Barranquero <lekktu@gmail.com>
11287
11288 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11289 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11290 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11291 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11292 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11293 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11294 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11295 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11296 (Qgnutls_bootprop_callbacks_verify): Make static.
11297
e7a6747f
AS
112982011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11299
19ed11ba
AS
11300 * callproc.c: Indentation fixup.
11301
e7a6747f 11302 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11303 (wait_for_termination, interruptible_wait_for_termination):
11304 Move after wait_for_termination_1.
e7a6747f 11305
1ef14cb4
LMI
113062011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11307
11308 * sysdep.c (interruptible_wait_for_termination): New function
11309 which is like wait_for_termination, but allows keyboard
11310 interruptions.
11311
11312 * callproc.c (Fcall_process): Add (:file "file") as an option for
11313 the STDOUT buffer.
11314 (Fcall_process_region): Ditto.
11315
330d880c
EZ
113162011-04-30 Eli Zaretskii <eliz@gnu.org>
11317
8db90b73
EZ
11318 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11319 rather than `XVECTOR (FOO)->size'.
11320
330d880c
EZ
11321 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11322 inttypes.h, as a gnulib replacement is used if it not available in
11323 system headers.
11324
15cbd324
EZ
113252011-04-21 Eli Zaretskii <eliz@gnu.org>
11326
11327 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11328 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11329 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11330
11331 * coding.c (coding_alloc_by_realloc): Error out if destination
11332 will grow beyond MOST_POSITIVE_FIXNUM.
11333 (decode_coding_emacs_mule): Abort if there isn't enough place in
11334 charbuf for the composition carryover bytes. Reserve an extra
11335 space for up to 2 characters produced in a loop.
11336 (decode_coding_iso_2022): Abort if there isn't enough place in
11337 charbuf for the composition carryover bytes.
11338
113392011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11340
ae940cca
EZ
11341 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11342 aborting when %lld or %lll format is passed.
11343 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11344 %llo or %llx format is passed. (Bug#8545)
11345
03ab8921
EZ
11346 * window.c (window_scroll_line_based): Use a marker instead of
11347 simple variables to record original value of point. (Bug#7952)
11348
afda1437
EZ
11349 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11350 produced by %s or %c overflows available buffer space. (Bug#8545)
11351
f76dee0c
PE
113522011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11353
11354 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11355 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11356
fdc5744d
JB
113572011-04-28 Juanma Barranquero <lekktu@gmail.com>
11358
11359 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11360
638f053a
JB
113612011-04-28 Juanma Barranquero <lekktu@gmail.com>
11362
11363 * keyboard.c (Qdelayed_warnings_hook): Define.
11364 (command_loop_1): Run `delayed-warnings-hook'
11365 if Vdelayed_warnings_list is non-nil.
11366 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11367 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11368
d178f871
EZ
113692011-04-28 Eli Zaretskii <eliz@gnu.org>
11370
11371 * doprnt.c (doprnt): Don't return value smaller than the buffer
11372 size if the message was truncated. (Bug#8545).
11373
b124fd93
JB
113742011-04-28 Juanma Barranquero <lekktu@gmail.com>
11375
11376 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11377 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11378
e810457d
PE
113792011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11380
11381 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11382
ea51cceb
JB
113832011-04-27 Juanma Barranquero <lekktu@gmail.com>
11384
11385 * makefile.w32-in: Update dependencies.
11386
94dcfacf
EZ
113872011-04-27 Eli Zaretskii <eliz@gnu.org>
11388
11389 Improve `doprnt' and its usage. (Bug#8545)
11390 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11391 `format_end'. Remove support for %l as a conversion specifier.
11392 Don't use xrealloc. Improve diagnostics when the %l size modifier
11393 is used. Update the commentary.
11394
11395 * eval.c (verror): Simplify calculation of size_t.
11396
11397 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11398 messages.
11399
f61f41d7
PE
114002011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11401
11402 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11403 change.
11404
96fb4434
PE
114052011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11406
11407 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11408 This makes this file independent of the recent pseudovector change.
11409
671875da 114102011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11411
69e9b5a3
PE
11412 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11413
b5f869a7 11414 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11415 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11416 Remove unused local.
c8926152 11417 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11418
841a1577 11419 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11420 GCC 4.6.0 optimizes based on type-based alias analysis.
11421 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11422 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11423 != &v->size, and therefore "v->size = 1; b->size = 2; return
11424 v->size;" must therefore return 1. This assumption is incorrect
11425 for Emacs, since it type-puns struct Lisp_Vector * with many other
11426 types. To fix this problem, this patch adds a new type struct
f904488f 11427 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11428 and pseudovectors, and helps optimizing compilers not get fooled
11429 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11430 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11431 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11432 the size member.
eab3844f
PE
11433 (XSETPVECTYPE): Rewrite in terms of new macro.
11434 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11435 This is a bit clearer, and further avoids the possibility of
11436 undesirable aliasing.
11437 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11438 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11439 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11440 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11441 (ASIZE): Now uses header.size rather than size.
11442 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11443 to avoid the hassle of writing XVECTOR (foo)->header.size.
11444 (struct vectorlike_header): New type.
eab3844f
PE
11445 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11446 object, to help avoid aliasing.
11447 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11448 (SUBRP): Likewise, since Lisp_Subr is a special case.
11449 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11450 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11451 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11452 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11453 changed to be "header.size" and "header.next".
11454 * buffer.h (struct buffer): Likewise.
11455 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11456 * frame.h (struct frame): Likewise.
11457 * process.h (struct Lisp_Process): Likewise.
11458 * termhooks.h (struct terminal): Likewise.
11459 * window.c (struct save_window_data, struct saved_window): Likewise.
11460 * window.h (struct window): Likewise.
11461 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11462 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11463 * buffer.c (init_buffer_once): Likewise.
11464 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11465 special case.
11466 * process.c (Fformat_network_address): Use local var for size,
11467 for brevity.
11468
0df1eac5
PE
11469 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11470
847ab9d1 11471 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11472 * data.c (atof): Remove decl; no longer used or needed.
11473 (digit_to_number): Move to lread.c.
11474 (Fstring_to_number): Use new string_to_number function, to be
11475 consistent with how the Lisp reader treats infinities and NaNs.
11476 Do not assume that floating-point numbers represent EMACS_INT
11477 without losing information; this is not true on most 64-bit hosts.
11478 Avoid double-rounding errors, by insisting on integers when
11479 parsing non-base-10 numbers, as the documentation specifies.
11480 * lisp.h (string_to_number): New decl, replacing ...
11481 (isfloat_string): Remove.
bc0a5c13 11482 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11483 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11484 appears to have been a coding error. Similarly, do not accept
11485 strings like +-1e0 as floating point numbers. Do not report
11486 overflow for integer overflows unless the base is not 10 which
11487 means we have no simple and reliable way to continue.
11488 Break out the floating-point parsing into a new
11489 function string_to_number, so that Fstring_to_number parses
11490 floating point numbers consistently with the Lisp reader.
04f2d78b 11491 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11492 (E_CHAR, EXP_INT): Remove, replacing with ...
11493 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11494 (string_to_number): New function, replacing isfloat_string.
11495 This function checks for valid syntax and produces the resulting
11496 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11497 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11498 so that overflow for non-base-10 numbers is reported only when
11499 there's no portable and simple way to convert to floating point.
452f4150 11500
67769ffc
PE
11501 * textprop.c (set_text_properties_1): Rewrite for clarity,
11502 and to avoid GCC warning about integer overflow.
11503
c20db43f
PE
11504 * intervals.h (struct interval): Use EMACS_INT for members
11505 where EMACS_UINT might cause problems. See
11506 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11507 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11508 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11509 All uses changed.
37aa2f85
PE
11510 (offset_intervals): Tell GCC not to worry about length overflow
11511 when negating a negative length.
c20db43f 11512
2538aa2f
PE
11513 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11514 (overrun_check_free): Likewise.
11515
f2d3008d
PE
11516 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11517 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11518 word size.
11519
ec8df744
PE
11520 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11521 (gnutls_make_error): Rename local to avoid shadowing.
11522 (gnutls_emacs_global_deinit): ifdef out; not used.
11523 (Fgnutls_boot): Use const for pointer to readonly storage.
11524 Comment out unused local. Fix pointer signedness problems.
11525
640ee02d
PE
11526 * lread.c (openp): Don't stuff size_t into an 'int'.
11527 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11528 about possible signed overflow.
11529
6048fb2a
PE
11530 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11531 (GDK_KEY_g): Don't define if already defined.
11532 (xg_prepare_tooltip): Avoid pointer signedness problem.
11533 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11534
fa3c87e1
PE
11535 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11536 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11537
2172544b
PE
11538 * xfns.c (Fx_window_property): Simplify a bit,
11539 to make a bit faster and to avoid GCC 4.6.0 warning.
11540 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11541
9b821a21
PE
11542 * fns.c (internal_equal): Don't assume size_t fits in int.
11543
3c616cfa
PE
11544 * alloc.c (compact_small_strings): Tighten assertion a little.
11545
c2982e87
PE
11546 Replace pEd with more-general pI, and fix some printf arg casts.
11547 * lisp.h (pI): New macro, generalizing old pEd macro to other
11548 conversion specifiers. For example, use "...%"pI"d..." rather
11549 than "...%"pEd"...".
11550 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11551 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11552 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11553 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11554 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11555 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11556 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11557 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11558 64-bit hosts.
11559 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11560 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11561 * print.c (safe_debug_print, print_object): Likewise.
11562 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11563 to int.
6f04d126
PE
11564 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11565 avoiding the 0 flag, which is not portable.
c2982e87
PE
11566 * process.c (Fmake_network_process): Use pI to avoid cast.
11567 * region-cache.c (pp_cache): Likewise.
11568 * xdisp.c (decode_mode_spec): Likewise.
11569 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11570 behavior on 64-bit hosts with printf arg.
6f04d126 11571 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11572 (x_stop_queuing_selection_requests): Likewise.
11573 (x_get_window_property): Don't truncate byte count to an 'int'
11574 when tracing.
0b432f21 11575
5e073ec7
PE
11576 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11577 here, since it parses constructs like leading '-' and spaces,
11578 which are not wanted; and it overflows with large numbers.
11579 Instead, simply match F[0-9]+, which is what is wanted anyway.
11580
36372bf9
PE
11581 * alloc.c: Remove unportable assumptions about struct layout.
11582 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11583 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11584 (allocate_vectorlike, make_pure_vector): Use the new macros,
11585 plus offsetof, to remove unportable assumptions about struct layout.
11586 These assumptions hold on all porting targets that I know of, but
11587 they are not guaranteed, they're easy to remove, and removing them
11588 makes further changes easier.
11589
0b432f21
PE
11590 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11591 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11592 (string_overrun_cookie): Now const. Use initializers that
11593 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11594 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11595 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11596 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11597 multiple of sizeof (EMACS_INT); it need not be, if
11598 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11599 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11600
895009e1
JB
116012011-04-26 Juanma Barranquero <lekktu@gmail.com>
11602
11603 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11604
6a7a1b0b
TZ
116052011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11606
11607 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11608 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11609 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11610
841a1577 116112011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11612
11613 * lisp.h (Qdebug): List symbol.
895009e1 11614 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11615 * keyboard.c (debug-on-event): New variable.
11616 (handle_user_signal): Break into debugger when debug-on-event
11617 matches the current signal symbol.
11618
f2d3ba6f
DN
116192011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11620
11621 * alloc.c (check_sblock, check_string_bytes)
11622 (check_string_free_list): Convert to standard C.
11623
42ce4c63
TZ
116242011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11625
11626 * w32.c (emacs_gnutls_push): Fix typo.
11627
825cd63c
EZ
116282011-04-25 Eli Zaretskii <eliz@gnu.org>
11629
fb11d64d
EZ
11630 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11631 "cast to pointer from integer of different size".
11632
825cd63c
EZ
11633 Improve doprnt and its use in verror. (Bug#8545)
11634 * doprnt.c (doprnt): Document the set of format control sequences
11635 supported by the function. Use SAFE_ALLOCA instead of always
11636 using `alloca'.
11637
11638 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11639 is one byte too soon. Don't use xrealloc; instead xfree and
11640 xmalloc anew.
11641
e061a11b
TZ
116422011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11643
11644 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11645 callbacks stage.
11646
11647 * gnutls.c: Renamed global_initialized to
11648 gnutls_global_initialized. Added internals for the
11649 :verify-hostname-error, :verify-error, and :verify-flags
11650 parameters of `gnutls-boot' and documented those parameters in the
11651 docstring. Start callback support.
9173deec
JB
11652 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11653 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11654 on error. Return error code.
e061a11b
TZ
11655 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11656 (emacs_gnutls_read): Likewise.
11657 (Fgnutls_boot): Return handshake error code.
11658 (emacs_gnutls_handle_error): New function.
11659 (wsaerror_to_errno): Likewise.
11660
11661 * w32.h (emacs_gnutls_pull): Add prototype.
11662 (emacs_gnutls_push): Likewise.
11663
11664 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11665 (emacs_gnutls_push): Likewise.
11666
116672011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11668
11669 * process.c (wait_reading_process_output): Check if GnuTLS
11670 buffered some data internally if no FDs are set for TLS
11671 connections.
11672
11673 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11674 (LIBS): Link to USER_LIBS.
11675 ($(BLD)/gnutls.$(0)): New target.
11676
fa6996bc
EZ
116772011-04-24 Eli Zaretskii <eliz@gnu.org>
11678
eb35682e
EZ
11679 * xdisp.c (handle_single_display_spec): Rename the
11680 display_replaced_before_p argument into display_replaced_p, to
11681 make it consistent with the commentary. Fix typos in the
11682 commentary.
11683
e2ad650c
EZ
11684 * textprop.c (syms_of_textprop): Remove dead code.
11685 (copy_text_properties): Delete obsolete commentary about an
11686 interface that was deleted long ago. Fix typos in the description
11687 of arguments.
11688
1b2de274
EZ
11689 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11690 to changes in oldXMenu/XMenu.h from 2011-04-16.
11691 <menu_help_message, prev_menu_help_message>: Constify.
11692 (IT_menu_make_room): menu->help_text is now `const char **';
11693 adjust.
11694
11695 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11696 to changes in oldXMenu/XMenu.h from 2011-04-16.
11697 (struct XMenu): Declare `help_text' `const char **'.
11698
11699 * xfaces.c <Qunspecified>: Make extern again.
11700
11701 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11702 required by POSIX.
1b2de274 11703
762b15be
EZ
11704 * doc.c (get_doc_string): Improve the format passed to `error'.
11705
11706 * doprnt.c (doprnt): Improve commentary.
11707
11708 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11709
11710 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11711 them with etags.
11712
f1052e5d
EZ
11713 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11714 changes in globals.h immediately force recompilation.
762b15be
EZ
11715 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11716 $(CURDIR)/s/ms-w32.h.
11717 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11718
fa6996bc
EZ
11719 * character.c (Fchar_direction): Function deleted.
11720 (syms_of_character): Don't defsubr it.
11721 <char-direction-table>: Deleted.
11722
e6c3da20
EZ
117232011-04-23 Eli Zaretskii <eliz@gnu.org>
11724
11725 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11726 * doprnt.c: Include limits.h.
11727 (SIZE_MAX): New macro.
04f2d78b
CB
11728 (doprnt): Return a size_t value. 2nd arg is now size_t.
11729 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11730 Improve overflow protection. Support `l' modifier for integer
11731 conversions. Support %l conversion. Don't assume an EMACS_INT
11732 argument for integer conversions and for %c.
11733
11734 * lisp.h (doprnt): Restore prototype.
11735
11736 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11737 $(SRC)/character.h.
11738
11739 * Makefile.in (base_obj): Add back doprnt.o.
11740
11741 * deps.mk (doprnt.o): Add back prerequisites.
11742 (callint.o): Depend on character.h.
11743
11744 * eval.c (internal_lisp_condition_case): Include the handler
11745 representation in the error message.
11746 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11747 when breaking from the loop.
11748
11749 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11750
11751 * callint.c (Fcall_interactively): When displaying error message
11752 about invalid control letter, pass the character's codepoint, not
11753 a pointer to its multibyte form. Improve display of the character
11754 in octal and display also its hex code.
11755
11756 * character.c (char_string): Use %x to display the (unsigned)
11757 codepoint of an invalid character, to avoid displaying a bogus
11758 negative value.
11759
11760 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11761 `error', not SYMBOL_NAME itself.
11762
11763 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11764 character arguments to `error'.
11765
11766 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11767 to `error' in error message about FINAL_CHAR argument. Make sure
11768 FINAL_CHAR is a character, and use %c when it is passed as
11769 argument to `error'.
11770
4ffd0d6b 117712011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11772
11773 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11774
11775 * w32.c: Include <time.h>.
11776 (sys_localtime): New function.
11777
4ffd0d6b 117782011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11779
11780 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11781
4ffd0d6b 11782 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11783
4ffd0d6b 117842011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11785
4ffd0d6b
GM
11786 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11787 zombies (Bug#8467).
aac0c6e3 11788
04c56954
EZ
117892011-04-19 Eli Zaretskii <eliz@gnu.org>
11790
11791 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11792 gl_state.e_property when gl_state.object is Qt.
11793
11794 * insdel.c (make_gap_larger): Remove limitation of buffer size
11795 to <= INT_MAX.
11796
16a43933
CY
117972011-04-18 Chong Yidong <cyd@stupidchicken.com>
11798
11799 * xdisp.c (lookup_glyphless_char_display)
11800 (produce_glyphless_glyph): Handle cons cell entry in
11801 glyphless-char-display.
11802 (Vglyphless_char_display): Document it.
11803
11804 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11805 glyphless-char-display.
11806
4581706e
CY
118072011-04-17 Chong Yidong <cyd@stupidchicken.com>
11808
11809 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11810
11811 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11812
11813 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11814 definition for no-X builds.
11815
4887c6e2 118162011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11817
fd35b6f9
PE
11818 Static checks with GCC 4.6.0 and non-default toolkits.
11819
5c1ccb01
PE
11820 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11821
006c5daa
PE
11822 * process.c (keyboard_bit_set): Define only if SIGIO.
11823 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11824 (send_process): Repair possible setjmp clobbering.
11825
efc736d3
PE
11826 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11827
4e2fe2e6
PE
11828 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11829
f97334a2
PE
11830 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11831
4e75f29d
PE
11832 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11833 Define only if needed.
11834
90efadd1
PE
11835 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11836 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11837 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11838
3c647824
PE
11839 * dispextern.h (struct redisplay_interface): Rename param
11840 to avoid shadowing.
e264f262 11841 * termhooks.h (struct terminal): Likewise.
761383f4 11842 * xterm.c (xembed_send_message): Likewise.
3c647824 11843
b58c5c4a
PE
11844 * insdel.c (make_gap_smaller): Define only if
11845 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11846
cad59032
PE
11847 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11848 it.
11849
c339dc2e
PE
11850 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11851 so that we aren't warned about unused symbols.
11852
91a3e27b
PE
11853 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11854
399c71d3 11855 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11856
8ffc96f5
PE
11857 * xfns.c (x_real_positions): Mark locals as initialized.
11858
eef9bc79
PE
11859 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11860
098db9dd
PE
11861 * xterm.c: Fix problems found by static analysis with other toolkits.
11862 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11863 (x_dispatch_event): Declare static if USE_GTK, and
11864 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11865 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11866 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11867 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11868 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11869
eb18f6cc
PE
11870 * xmenu.c (menu_help_callback): Pointer type fixes.
11871 Use const pointers when pointing at readonly data. Avoid pointer
11872 signedness clashes.
11873 (FALSE): Remove unused macro.
11874 (update_frame_menubar): Remove unused decl.
11875
1fe72bf8
PE
11876 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11877
60d9e1db
PE
11878 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11879 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11880 (single_menu_item): Rename local to avoid shadowing.
11881
39261c26
PE
11882 * keyboard.c (make_lispy_event): Remove unused local var.
11883
018c5e19
PE
11884 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11885 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11886
63d2b86e
PE
11887 * bitmaps: Change bitmaps from unsigned char back to the X11
11888 compatible char. Avoid the old compiler warnings about
11889 out-of-range initializers by using, for example, '\xab' rather
11890 than 0xab.
11891
aefd87e1
PE
11892 * xgselect.c (xgselect_initialize): Check vs interface
11893 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11894
bf501fb9
PE
11895 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11896
e9829fdf
PE
11897 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11898 to read-only memory.
11899
1086c095
PE
11900 * fns.c (vector): Remove; this old hack is no longer needed.
11901
2baccd04 11902 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11903 Remove unused var.
dde42981 11904 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11905
72391843 11906 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11907
436c16df 11908 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11909 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11910 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11911
92bb796d 11912 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11913 (x_term_init): Remove local to avoid shadowing.
92bb796d 11914
764430a3 11915 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11916
11917 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11918 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11919
d1dfb56c
EZ
119202011-04-16 Eli Zaretskii <eliz@gnu.org>
11921
c4354cb4
EZ
11922 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11923
d1dfb56c
EZ
11924 Fix regex.c, syntax.c and friends for buffers > 2GB.
11925 * syntax.h (struct gl_state_s): Declare character position members
11926 EMACS_INT.
11927
11928 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11929
04f2d78b
CB
11930 * textprop.c (verify_interval_modification, interval_of):
11931 Declare arguments EMACS_INT.
d1dfb56c
EZ
11932
11933 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11934 EMACS_INT.
11935
11936 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11937
11938 * indent.c (Fvertical_motion): Local variable it_start is now
11939 EMACS_INT.
11940
11941 * regex.c (re_match, re_match_2, re_match_2_internal)
11942 (bcmp_translate, regcomp, regexec, print_double_string)
11943 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11944 (re_compile_pattern, re_exec): Declare arguments and local
11945 variables `size_t' and `ssize_t' and return values `regoff_t', as
11946 appropriate.
11947 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11948 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11949 <compile_stack_type>: `size' and `avail' are now `size_t'.
11950
11951 * regex.h <regoff_t>: Use ssize_t, not int.
11952 (re_search, re_search_2, re_match, re_match_2): Arguments that
11953 specify buffer/string position and length are now ssize_t and
11954 size_t. Return type is regoff_t.
11955
613052cd
BK
119562011-04-16 Ben Key <bkey76@gmail.com>
11957
11958 * nsfont.m: Fixed bugs in ns_get_family and
11959 ns_descriptor_to_entity that were caused by using free to
11960 deallocate memory blocks that were allocated by xmalloc (via
11961 xstrdup). This caused Emacs to crash when compiled with
11962 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11963 --enable-checking=xmallocoverrun). xfree is now used to
11964 deallocate these memory blocks.
11965
4170f62f 119662011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11967
71b41406
PE
11968 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11969
9587a89d
PE
11970 emacs_write: Accept and return EMACS_INT for sizes.
11971 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11972 et seq.
11973 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11974 Accept and return EMACS_INT.
11975 (emacs_gnutls_write): Return the number of bytes written on
11976 partial writes.
11977 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11978 (emacs_read, emacs_write): Remove check for negative size, as the
11979 Emacs source code has been audited now.
9587a89d
PE
11980 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11981 (emacs_read, emacs_write): Use it.
273a5f82
PE
11982 * process.c (send_process): Adjust to the new signatures of
11983 emacs_write and emacs_gnutls_write. Do not attempt to store
11984 a byte offset into an 'int'; it might overflow.
9587a89d 11985 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11986
3e047f51
PE
11987 * sound.c: Don't assume sizes fit in 'int'.
11988 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11989 Return EMACS_INT, not int.
3e047f51 11990 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11991 Accept EMACS_INT, not int.
11992 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11993 record read return values.
11994
cc39a9db
BK
119952011-04-15 Ben Key <bkey76@gmail.com>
11996
c9d0ec6d
JB
11997 * keyboard.c (Qundefined): Don't declare static since it is used
11998 in nsfns.m.
11999 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12000 static since they are used in nsfont.m.
cc39a9db 12001
6c60eb9f
SM
120022011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12003
12004 * process.c (Qprocessp): Don't declare static.
12005 * lisp.h (Qprocessp): Declare again.
12006
7990b61a
JB
120072011-04-15 Juanma Barranquero <lekktu@gmail.com>
12008
12009 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12010
5d4cb038
PE
120112011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12012
8bd7b830 12013 Improve C-level modularity by making more things 'static'.
cd64ea1d 12014
e3b27b31
PE
12015 Don't publish debugger-only interfaces to other modules.
12016 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12017 (verify_bytepos, count_markers): Move decls to the only modules
12018 that need them.
12019 * region-cache.h (pp_cache): Likewise.
12020 * window.h (check_all_windows): Likewise.
12021 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12022
5d4cb038
PE
12023 * sysdep.c (croak): Now static, if
12024 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12025 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12026
12027 * alloc.c (refill_memory_reserve): Now static if
12028 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12029 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12030
e87b6180
PE
12031 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12032 Define only if USE_LUCID.
12033
ac64929e
PE
12034 * xrdb.c (x_customization_string, x_rm_string): Now static.
12035
6f37259d
PE
12036 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12037 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12038
1683e3ab
PE
12039 * xdisp.c (draw_row_with_mouse_face): Now static.
12040 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12041
de9c2632
PE
12042 * window.h (check_all_windows): Mark externally visible.
12043
2b96acb7
PE
12044 * window.c (window_deletion_count): Now static.
12045
12046 * undo.c: Make symbols static if they're not exported.
12047 (last_undo_buffer, last_boundary_position, pending_boundary):
12048 Now static.
12049
50436f33
PE
12050 * textprop.c (interval_insert_behind_hooks): Now static.
12051 (interval_insert_in_front_hooks): Likewise.
12052
64520e5c
PE
12053 * term.c: Make symbols static if they're not exported.
12054 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12055 (max_frame_lines, tty_set_terminal_modes):
12056 (tty_reset_terminal_modes, tty_turn_off_highlight):
12057 (get_tty_terminal): Now static.
12058 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12059 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12060 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12061 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12062 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12063
1fa53021
PE
12064 * sysdep.c: Make symbols static if they're not exported.
12065 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12066 Now static.
12067 (sigprocmask_set, full_mask): Remove; unused.
12068 (wait_debugging): Mark as visible.
12069 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12070 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12071
d4b43b22
PE
12072 * syntax.c (syntax_temp): Define only if !__GNUC__.
12073
b7c513d0
PE
12074 * sound.c (current_sound_device, current_sound): Now static.
12075
989b29ad
PE
12076 * search.c (searchbufs, searchbuf_head): Now static.
12077
13a55a78
PE
12078 * scroll.c (scroll_cost): Remove; unused.
12079 * dispextern.h (scroll_cost): Remove decl.
12080
de68a1fc
PE
12081 * region-cache.h (pp_cache): Mark as externally visible.
12082
40ccffa6
PE
12083 * process.c: Make symbols static if they're not exported.
12084 (process_tick, update_tick, create_process, chan_process):
12085 (Vprocess_alist, proc_buffered_char, datagram_access):
12086 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12087 (deactivate_process): Mark defn as static, as well as decl.
12088 * lisp.h (create_process): Remove decl.
12089 * process.h (chan_process, Vprocess_alist): Remove decls.
12090
ad64fc97
PE
12091 * print.c: Make symbols static if they're not exported.
12092 (print_depth, new_backquote_output, being_printed, print_buffer):
12093 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12094 (print_interval, print_number_index, initial_stderr_stream):
12095 Now static.
12096 * lisp.h (Fprinc): Remove decl.
12097 (debug_output_compilation_hack): Mark as externally visible.
12098
adddb265
PE
12099 * sysdep.c (croak): Move decl from here to syssignal.h.
12100 * syssignal.h (croak): Put it here, so the API can be checked when
12101 'croak' is called from dissociate_if_controlling_tty.
12102
1717ede2
PE
12103 * minibuf.c: Make symbols static if they're not exported.
12104 (minibuf_save_list, choose_minibuf_frame): Now static.
12105 * lisp.h (choose_minibuf_frame): Remove decl.
12106
fa5fb2bc
PE
12107 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12108
1e3890d1
PE
12109 * lread.c: Make symbols static if they're not exported.
12110 (read_objects, initial_obarray, oblookup_last_bucket_number):
12111 Now static.
12112 (make_symbol): Remove; unused.
12113 * lisp.h (initial_obarray, make_symbol): Remove decls.
12114
8a1414fa
PE
12115 * keyboard.c: Make symbols static if they're not exported.
12116 (single_kboard, recent_keys_index, total_keys, recent_keys):
12117 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12118 (this_single_command_key_start, echoing, last_auto_save):
12119 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12120 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12121 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12122 (Vlispy_mouse_stem, double_click_count):
12123 Now static.
12124 (force_auto_save_soon): Define only if SIGDANGER.
12125 (ignore_mouse_drag_p): Now static if
12126 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12127 (print_help): Remove; unused.
12128 (stop_character, last_timer_event): Mark as externally visible.
12129 * keyboard.h (ignore_mouse_drag_p): Declare only if
12130 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12131 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12132 * lisp.h (echoing): Remove decl.
12133 (force_auto_save_soon): Declare only if SIGDANGER.
12134 * xdisp.c (redisplay_window): Simplify code, to make it more
12135 obvious that ignore_mouse_drag_p is not accessed if !defined
12136 USE_GTK && !defined HAVE_NS.
12137
93ea6e8f
PE
12138 * intervals.c: Make symbols static if they're not exported.
12139 (merge_properties_sticky, merge_interval_right, delete_interval):
12140 Now static.
12141 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12142
77382fcc
PE
12143 * insdel.c: Make symbols static if they're not exported.
12144 However, leave prepare_to_modify_buffer alone. It's never
12145 called from outside this function, but that appears to be a bug.
12146 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12147 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12148 (adjust_after_replace_noundo): Remove; unused.
12149 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12150 (signal_before_change): Remove decls.
77382fcc 12151
9306c32e
PE
12152 * indent.c (val_compute_motion, val_vmotion): Now static.
12153
cd44d2eb
PE
12154 * image.c: Make symbols static if they're not exported.
12155 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12156 if USE_GTK.
12157 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12158 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12159
ad9a7a06
PE
12160 * fringe.c (standard_bitmaps): Now static.
12161 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12162
81626931
PE
12163 * frame.c: Make symbols static if they're not exported.
12164 (x_report_frame_params, make_terminal_frame): Now static.
12165 (get_frame_param): Now static, unless HAVE_NS.
12166 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12167 (x_get_resource_string): Remove; not used.
12168 * frame.h (make_terminal_frame, x_report_frame_params):
12169 (x_get_resource_string); Remove decls.
12170 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12171 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12172
239f9db9
PE
12173 * font.c, fontset.c: Make symbols static if they're not exported.
12174 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12175 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12176 * font.c (font_close_object): Now static.
12177 * font.h (font_close_object): Remove.
12178 * fontset.c (FONTSET_OBJLIST): Remove.
12179 (free_realized_fontset) #if-0 the body, which does nothing.
12180 (face_suitable_for_char_p): #if-0, as it's never called.
12181 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12182 * xfaces.c (face_at_string_position):
12183 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12184 since 0 is always ASCII.
12185
dfcf3579
PE
12186 * fns.c (weak_hash_tables): Now static.
12187
5045092b
PE
12188 * fileio.c: Make symbols static if they're not exported.
12189 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12190 (Vwrite_region_annotation_buffers): Now static.
12191
57a96f5c
PE
12192 * eval.c: Make symbols static if they're not exported.
12193 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12194 * lisp.h (backtrace_list): Remove decl.
12195
35f08c38
PE
12196 * emacs.c: Make symbols static if they're not exported.
12197 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12198 (fatal_error_code, fatal_error_signal_hook, standard_args):
12199 Now static.
12200 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12201 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12202 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12203 * lisp.h (fatal_error_signal_hook): Remove decl.
12204 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12205
f44bd759
PE
12206 * editfns.c: Move a (normally-unused) function to its only use.
12207 * editfns.c, lisp.h (get_operating_system_release): Remove.
12208 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12209 worth the hassle of breaking this out.
12210
b532497d
PE
12211 * xterm.c: Make symbols static if they're not exported.
12212 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12213 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12214 (x_destroy_window, x_delete_display):
12215 Now static.
12216 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12217 (x_mouse_leave): Remove; unused.
12218 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12219 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12220 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12221 Remove decls.
12222 (x_mouse_leave): Declare only if WINDOWSNT.
12223 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12224 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12225 USE_X_TOOLKIT.
12226
1675728f
PE
12227 * ftxfont.c: Make symbols static if they're not exported.
12228 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12229 HAVE_FREETYPE.
12230 * font.h (ftxfont_driver): Likewise.
12231
e4cebfca
PE
12232 * xfns.c: Make symbols static if they're not exported.
12233 (x_last_font_name, x_display_info_for_name):
12234 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12235 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12236 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12237 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12238 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12239 (last_show_tip_args): Now static.
12240 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12241 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12242 (x_screen_planes): Remove; unused.
12243 * dispextern.h (x_screen_planes): Remove decl.
12244
5bf46f05
PE
12245 * dispnew.c: Make symbols static if they're not exported.
12246 * dispextern.h (redraw_garbaged_frames, scrolling):
12247 (increment_row_positions): Remove.
12248 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12249 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12250 Now static.
12251 (redraw_garbaged_frames): Remove; unused.
12252
435f4c28
PE
12253 * xfaces.c: Make symbols static if they're not exported.
12254 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12255 Remove decls.
12256 * xterm.h (defined_color): Remove decls.
12257 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12258 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12259 (menu_face_changed_default, defined_color, free_realized_face):
12260 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12261 (ascii_face_of_lisp_face): Remove; unused.
12262
8524aef3
PE
12263 * xdisp.c: Make symbols static if they're not exported.
12264 * dispextern.h (scratch_glyph_row, window_box_edges):
12265 (glyph_to_pixel_coords, set_cursor_from_row):
12266 (get_next_display_element, set_iterator_to_next):
12267 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12268 (show_mouse_face): Remove decls
12269 * frame.h (message_buf_print): Likewise.
12270 * lisp.h (pop_message, set_message, check_point_in_composition):
12271 Likewise.
12272 * xterm.h (set_vertical_scroll_bar): Likewise.
12273 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12274 (message_buf_print, scratch_glyph_row, displayed_buffer):
12275 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12276 (get_next_display_element, show_mouse_face, window_box_edges):
12277 (frame_to_window_pixel_xy, check_point_in_composition):
12278 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12279 (glyph_to_pixel_coords): Remove; unused.
12280
16390cd2
PE
12281 * dired.c (file_name_completion): Now static.
12282
12283 * dbusbind.c (xd_in_read_queued_messages): Now static.
12284
a25f4dfa
PE
12285 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12286 * data.c (circular_list_error): Remove.
12287
14a9c8df
PE
12288 * commands.h (last_point_position, last_point_position_buffer):
12289 (last_point_position_window): Remove decls.
12290 * keyboard.c: Make these variables static.
12291
04f2d78b
CB
12292 * coding.h (coding, code_convert_region, encode_coding_gap):
12293 Remove decls.
74ab6df5
PE
12294 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12295 (iso_code_class, detect_coding, code_convert_region): Now static.
12296 (encode_coding_gap): Remove; unused.
12297
38dfbee1
PE
12298 * chartab.c (chartab_chars, chartab_bits): Now static.
12299
a2cb4e63
PE
12300 * charset.h (charset_iso_8859_1): Remove decl.
12301 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12302 Now static.
12303
127198fd
PE
12304 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12305 * ccl.c (Vccl_program_table): Now static.
12306 (check_ccl_update): Remove; unused.
12307
d85b608f
PE
12308 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12309 * category.h: ... from here.
12310 * category.c (check_category_table, set_category_set): Now static.
12311
31cd66f3
PE
12312 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12313 * lisp.h: Remove these decls.
12314
c358e587
PE
12315 * buffer.c (buffer_count): Remove unused var.
12316
e78aecca
PE
12317 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12318 so that it's not optimized away.
12319 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12320 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12321 exported only to the debugger.
12322
e192d7d3 12323 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12324 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12325
92470028
PE
12326 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12327 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12328 was inaccessible from Lisp.
12329 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12330 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12331
244ed907
PE
12332 alloc.c: Import and export fewer symbols, and remove unused items.
12333 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12334 is defined.
12335 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12336 it's not optimized away by whole-program optimization.
12337 (message_enable_multibyte, free_misc): Remove.
12338 (catchlist, handlerlist, mark_backtrace):
12339 Declare only if BYTE_MARK_STACK.
12340 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12341 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12342 (message_enable_multibyte): Remove decl.
12343 (free_misc, interval_free_list, float_block, float_block_index):
12344 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12345 (cons_free_list, last_marked_index):
12346 Now static.
12347 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12348 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12349 (mark_backtrace): Define only if BYTE_MARK_STACK.
12350 * xdisp.c (message_enable_multibyte): Now static.
12351
61c2b50e 12352 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12353 This makes it easier for human readers (and static analyzers)
12354 to see whether these variables are used from other modules.
12355 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12356 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12357 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12358 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12359 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12360 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12361 * xmenu.c, xselect.c:
12362 Declare Q* vars static if they are not used in other modules.
12363 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12364 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12365 Remove decls of unexported vars.
12366 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12367
95c82688
PE
12368 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12369
16a97296
PE
12370 Make Emacs functions such as Fatom 'static' by default.
12371 This makes it easier for human readers (and static analyzers)
12372 to see whether these functions can be called from other modules.
12373 DEFUN now defines a static function. To make the function external
12374 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12375 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12376 (Finit_image_library):
16a97296
PE
12377 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12378 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12379 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12380 Remove decls, since these functions are now static.
12381 (Funintern, Fget_internal_run_time): New decls, since these functions
12382 were already external.
95c82688 12383
16a97296
PE
12384 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12385 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12386 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12387 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12388 * keyboard.c, keymap.c, lread.c:
12389 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12390 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12391 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12392 Mark functions with DEFUE instead of DEFUN,
12393 if they are used in other modules.
12394 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12395 decls for now-static functions.
12396 * buffer.h (Fdelete_overlay): Remove decl.
12397 * callproc.c (Fgetenv_internal): Mark as internal.
12398 * composite.c (Fremove_list_of_text_properties): Remove decl.
12399 (Fcomposition_get_gstring): New forward static decl.
12400 * composite.h (Fcomposite_get_gstring): Remove decl.
12401 * dired.c (Ffile_attributes): New forward static decl.
12402 * doc.c (Fdocumntation_property): New forward static decl.
12403 * eval.c (Ffetch_bytecode): New forward static decl.
12404 (Funintern): Remove extern decl; now in .h file where it belongs.
12405 * fileio.c (Fmake_symbolic_link): New forward static decl.
12406 * image.c (Finit_image_library): New forward static decl.
12407 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12408 * intervals.h (Fprevious_property_change):
12409 (Fremove_list_of_text_properties): Remove decls.
12410 * keyboard.c (Fthis_command_keys): Remove decl.
12411 (Fcommand_execute): New forward static decl.
12412 * keymap.c (Flookup_key): New forward static decl.
12413 (Fcopy_keymap): Now static.
12414 * keymap.h (Flookup_key): Remove decl.
12415 * process.c (Fget_process): New forward static decl.
12416 (Fprocess_datagram_address): Mark as internal.
12417 * syntax.c (Fsyntax_table_p): New forward static decl.
12418 (skip_chars): Remove duplicate decl.
12419 * textprop.c (Fprevious_property_change): New forward static decl.
12420 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12421 Now internal.
12422 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12423 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12424
785bbd42
PE
12425 * editfns.c (Fformat): Remove unreachable code.
12426
8b913b57
AS
124272011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12428
12429 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12430 change. (Bug#8496)
12431
a6744a35
EZ
124322011-04-13 Eli Zaretskii <eliz@gnu.org>
12433
12434 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12435 when at ZV. (Bug#8487)
12436
e7974947
AS
124372011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12438
baad03f0
AS
12439 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12440 (Bug#8437)
12441 * keyboard.c (parse_tool_bar_item): Likewise.
12442 * sound.c (sound_cleanup, alsa_close): Likewise.
12443 * termcap.c (tgetent): Likewise.
12444 * xfns.c (x_default_font_parameter): Likewise.
12445 * xsettings.c (read_and_apply_settings): Likewise.
12446
e7974947
AS
12447 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12448 (overrun_check_free): Protoize.
12449
28272684
PE
124502011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12451
12452 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12453 since callers should never pass a negative size.
12454 Change the signature to match that of plain 'read' and 'write'; see
12455 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12456 * lisp.h: Update prototypes of emacs_write and emacs_read.
12457
11997c76
EZ
124582011-04-11 Eli Zaretskii <eliz@gnu.org>
12459
12460 * xdisp.c (redisplay_window): Don't try to determine the character
12461 position of the scroll margin if the window start point w->startp
e896f03c 12462 is outside the buffer's accessible region. (Bug#8468)
11997c76 12463
8a2cbd72
EZ
124642011-04-10 Eli Zaretskii <eliz@gnu.org>
12465
12466 Fix write-region and its subroutines for buffers > 2GB.
12467 * fileio.c (a_write, e_write): Modify declaration of arguments and
12468 local variables to support buffers larger than 2GB.
12469 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12470
12471 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12472 argument, local variables, and return value.
12473
12474 * lisp.h: Update prototypes of emacs_write and emacs_read.
12475
12476 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12477
4073e537 124782011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12479
1ebfdcb6
PE
12480 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12481
b2ded58d
PE
12482 Fix more problems found by GCC 4.6.0's static checks.
12483
7d66342c
PE
12484 * xdisp.c (vmessage): Use a better test for character truncation.
12485
bbf47d44
PE
12486 * charset.c (load_charset_map): <, not <=, for optimization,
12487 and to avoid potential problems with integer overflow.
9248994d 12488 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12489 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12490 * editfns.c (Fformat): Likewise.
1e69125e 12491 * syntax.c (skip_chars): Likewise.
3befa583 12492
e3019616
PE
12493 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12494 This also lets GCC 4.6.0 generate slightly better loop code.
12495
becfa255
PE
12496 * callint.c (Fcall_interactively): <, not <=, for optimization.
12497 (Fcall_interactively): Count the number of arguments produced,
12498 not the number of arguments given. This is simpler and lets GCC
12499 4.6.0 generate slightly better code.
12500
dae0cd48
PE
12501 * ftfont.c: Distingish more carefully between FcChar8 and char.
12502 The previous code passed unsigned char * to a functions like
12503 strlen and xstrcasecmp that expect char *, which does not
12504 conform to the C standard.
12505 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12506 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12507 char * when the C standard requires it.
12508
76032d70
PE
12509 * keyboard.c (read_char): Remove unused var.
12510
eb3f1cc8
PE
12511 * eval.c: Port to Windows vsnprintf (Bug#8435).
12512 Include <limits.h>.
12513 (SIZE_MAX): Define if the headers do not.
12514 (verror): Do not give up if vsnprintf returns a negative count.
12515 Instead, grow the buffer. This ports to Windows vsnprintf, which
12516 does not conform to C99. Problem reported by Eli Zaretskii.
12517 Also, simplify the allocation scheme, by avoiding the need for
12518 calling realloc, and removing the ALLOCATED variable.
12519
70476b54
PE
12520 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12521
12020a9e
PE
12522 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12523 But keep the doprint source code for now, as we might revamp it
12524 and use it again (Bug#8435).
ea6c7ae6
PE
12525 * lisp.h (doprnt): Remove.
12526 * Makefile.in (base_obj): Remove doprnt.o.
12527 * deps.mk (doprnt.o): Remove.
12528
5fdb398c
PE
12529 error: Print 32- and 64-bit integers portably (Bug#8435).
12530 Without this change, on typical 64-bit hosts error ("...%d...", N)
12531 was used to print both 32- and 64-bit integers N, which relied on
12532 undefined behavior.
61bdb816 12533 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12534 * lisp.h (error, verror): Mark as printf-like functions.
12535 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12536 Report overflow in size calculations when allocating printf buffer.
12537 Do not truncate output string at its first null byte.
12538 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12539 Truncate the output at a character boundary, since vsnprintf does not
12540 do that.
12541 * charset.c (check_iso_charset_parameter): Convert internal
12542 character to string before calling 'error', since %c now has the
12543 printf meaning.
12544 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12545 overflow when computing char to be passed to 'error'. Do not
12546 pass Lisp_Object to 'error'; pass the integer instead.
12547 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12548 formatted with plain %d.
12549
b189fa66
PE
12550 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12551
bff87ef0
PE
12552 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12553
7e2cac20
PE
12554 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12555
ce4d90b5
PE
12556 * xterm.c (x_catch_errors): Remove duplicate declaration.
12557
266c9547
PE
12558 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12559
79c49ad2
PE
12560 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12561
368f4090
JM
125622011-04-10 Jim Meyering <meyering@redhat.com>
12563
12564 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12565 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12566 return ssize_t not "int", and use size_t as the buffer length.
12567 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12568 * gnutls.h: Update declarations.
12569 * process.c (read_process_output): Use ssize_t, to match.
12570 (send_process): Likewise.
12571
a32d4040
CY
125722011-04-09 Chong Yidong <cyd@stupidchicken.com>
12573
12574 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12575
8546720e 125762011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12577
04f2d78b
CB
12578 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12579 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12580
8546720e
GM
12581 * xterm.c (handle_one_xevent):
12582 * xmenu.c (create_and_show_popup_menu):
12583 * xselect.c (x_decline_selection_request)
12584 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12585
0a2f5c1a 125862011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12587
12588 Fix some uses of `int' instead of EMACS_INT.
12589 * search.c (string_match_1, fast_string_match)
12590 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12591 (scan_buffer, find_next_newline_no_quit)
12592 (find_before_next_newline, search_command, Freplace_match)
12593 (Fmatch_data): Make some `int' variables be EMACS_INT.
12594
12595 * xdisp.c (display_count_lines): 3rd argument and return value now
12596 EMACS_INT. All callers changed.
12597 (pint2hrstr): Last argument is now EMACS_INT.
12598
12599 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12600 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12601 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12602 (decode_coding_utf_16, decode_coding_emacs_mule)
12603 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12604 (decode_coding_ccl, decode_coding_charset)
12605 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12606 (decode_coding_iso_2022, decode_coding_emacs_mule)
12607 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12608 <char_offset, last_offset>: Declare EMACS_INT.
12609 (encode_coding_utf_8, encode_coding_utf_16)
12610 (encode_coding_emacs_mule, encode_invocation_designation)
12611 (encode_designation_at_bol, encode_coding_iso_2022)
12612 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12613 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12614 Declare EMACS_INT.
12615 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12616 (encode_invocation_designation): Last argument P_NCHARS is now
12617 EMACS_INT.
12618 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12619 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12620
12621 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12622 All users changed.
12623
12624 * ccl.c (Fccl_execute_on_string): Declare some variables
12625 EMACS_INT.
12626
8546720e 126272011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12628
12629 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12630
4e19a977
CS
126312011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12632
12633 * process.c (Fformat_network_address): Doc fix.
12634
87302331
R
126352011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12636
ee7683eb 12637 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12638
cbb59342
CY
126392011-04-08 Chong Yidong <cyd@stupidchicken.com>
12640
12641 * keyboard.c (read_char): Call Lisp function help-form-show,
12642 instead of using internal_with_output_to_temp_buffer.
12643 (Qhelp_form_show): New var.
e0d38eeb 12644 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12645
12646 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12647
12648 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12649
e67a13ab
CY
126502011-04-06 Chong Yidong <cyd@stupidchicken.com>
12651
04f2d78b
CB
12652 * process.c (Flist_processes): Remove to Lisp.
12653 (list_processes_1): Delete.
e67a13ab 12654
973f782d
EZ
126552011-04-06 Eli Zaretskii <eliz@gnu.org>
12656
7c106b1e
EZ
12657 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12658
973f782d
EZ
12659 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12660
41cf7d1a 126612011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12662
ca23cc88
PE
12663 Fix more problems found by GCC 4.6.0's static checks.
12664
f390e2d5
PE
12665 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12666
42eea0d0
PE
12667 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12668
b69769da 12669 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12670
f9541e84
PE
12671 * xdisp.c (vmessage): Mark as a printf-like function.
12672
13841b55
PE
12673 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12674
c136c10f
PE
12675 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12676
5e2d4a30
PE
12677 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12678 printf-like functions.
12679 (tiff_load): Add casts to remove these marks before passing them
12680 to system-supplied API.
12681
583f48b9
PE
12682 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12683
b25d760e
PE
12684 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12685 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12686 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12687 directly, rather than having caller test rule sign. This avoids
12688 some unnecessary tests.
12689 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12690 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12691 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12692
bc7b6697 12693 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12694 (xfont_open): Avoid unnecessary tests.
bc7b6697 12695
27ccc379
PE
12696 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12697
dcd5c89a
PE
12698 * composite.h, composite.c (composition_gstring_put_cache):
12699 Use EMACS_INT, not int, for length.
12700
b13a45c6
PE
12701 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12702 breaking out part of COMPOSITION_DECODE_RULE.
12703 (COMPOSITION_DECODE_RULE): Use it.
12704 * composite.c (get_composition_id): Remove unused local vars,
12705 by using the new macro.
12706
1e792e4d
PE
12707 * textprop.c (set_text_properties_1): Change while to do-while,
12708 since the condition is always true at first.
12709
dc6c6455 12710 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12711 (interval_deletion_adjustment): Return unsigned value.
12712 All uses changed.
dc6c6455 12713
aba7731a
PE
12714 * process.c (list_processes_1, create_pty, read_process_output):
12715 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12716 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12717 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12718 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12719 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12720
fdfc4bf3
PE
12721 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12722
fca8fe46 12723 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12724 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12725
06a0259a 12726 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12727 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12728 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12729
e7b9e80f
PE
12730 * print.c (print_error_message): Avoid int overflow.
12731
56201685
PE
12732 * font.c (font_list_entities): Redo for clarity,
12733 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12734
78834453 12735 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12736 (font_score): Avoid potential overflow in diff calculation.
78834453 12737
0bc0b309 12738 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12739 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12740
e610eaca
PE
12741 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12742
b895abce
PE
12743 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12744 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12745 can always succeed if overflow has undefined behavior.
12746
1f1d9321 12747 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12748 (wordify): Omit three unnecessary tests.
1f1d9321 12749
c59478bc
PE
12750 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12751 All callers changed. This avoids the need for an unused var.
12752
79b73827
PE
12753 * casefiddle.c (casify_region): Remove var that is set but not used.
12754
a4db5dfe
PE
12755 * dired.c (file_name_completion): Remove var that is set but not used.
12756
43aae36e
PE
12757 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12758
2a47c44d 12759 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12760 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12761
a37c69bf
PE
12762 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12763 Check for integer overflow on size calculations.
12764
328ab8e7
PE
12765 * buffer.c (Fprevious_overlay_change): Remove var that is set
12766 but not used.
12767
e5a2a5cb
PE
12768 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12769 Remove vars that are set but not used.
8d84a6eb 12770 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12771 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12772
a60e5f68
PE
12773 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12774
f661cb61 12775 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12776 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12777
f0397f5a
PE
12778 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12779 that are set but not used.
12780
8664db06 12781 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12782 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12783
6abdaa4a
PE
12784 * xselect.c (x_get_local_selection, x_handle_property_notify):
12785 Remove vars that are set but not used.
12786
0ce7538d 12787 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12788 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12789
9ae848fc
PE
12790 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12791 Remove var that is set but not used.
0b918413
PE
12792 (scroll_bar_windows_size): Now size_t, not int.
12793 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12794 Check for overflow.
9ae848fc 12795
a5a62657
PE
12796 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12797 (map_tty_color) [!defined MSDOS]: Likewise.
12798
5c5cdd39
PE
12799 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12800
66ebf983
PE
12801 * coding.c: Remove vars that are set but not used.
12802 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12803 All callers changed.
12804 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12805 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12806 (decode_coding_charset): Remove vars that are set but not used.
12807
1be4d761
PE
12808 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12809 that is set but not used.
12810
47553fa8
PE
12811 * print.c (print_object): Remove var that is set but not used.
12812
1f7196bf 12813 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12814 The gnulib version avoids calling malloc in the usual case,
12815 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12816 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12817 * filelock.c (current_lock_owner): Likewise.
12818 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12819 * sysdep.c: Include allocator.h, careadlinkat.h.
12820 (emacs_no_realloc_allocator): New static constant.
12821 (emacs_readlink): New function.
fdb61804
PE
12822 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12823 ../lib/careadlinkat.h.
d1fdcab7 12824
f84c17c7
SM
128252011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12826
12827 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12828 first non-nil return value).
12829
ef3862ad
JD
128302011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12831
12832 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12833 if not defined (Bug#8403).
12834
376a7006
JB
128352011-04-02 Juanma Barranquero <lekktu@gmail.com>
12836
12837 * xdisp.c (display_count_lines): Remove parameter `start',
12838 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12839 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12840 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12841 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12842 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12843 and thereabouts. All callers changed.
12844 (get_per_char_metric): Remove parameter `f', unused since
12845 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12846
6ca3801d
JM
128472011-04-02 Jim Meyering <meyering@redhat.com>
12848
12849 do not dereference NULL upon failed strdup
12850 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12851 (ns_get_family): Likewise.
12852
d8e2b5ba
JB
128532011-04-02 Juanma Barranquero <lekktu@gmail.com>
12854
12855 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12856
8c74fcbd
JD
128572011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12858
12859 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12860 later (Bug#8403).
12861
7200d79c
SM
128622011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12863
03408648 12864 Add lexical binding.
7200d79c 12865
03408648
SM
12866 * window.c (Ftemp_output_buffer_show): New fun.
12867 (Fsave_window_excursion):
12868 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12869
12870 * lread.c (lisp_file_lexically_bound_p): New function.
12871 (Fload): Bind Qlexical_binding.
12872 (readevalloop): Remove `evalfun' arg.
12873 Bind Qinternal_interpreter_environment.
12874 (Feval_buffer): Bind Qlexical_binding.
12875 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12876 Mark as dynamic.
12877 (syms_of_lread): Declare `lexical-binding'.
12878
12879 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12880
12881 * keyboard.c (eval_dyn): New fun.
12882 (menu_item_eval_property): Use it.
ca105506
SM
12883
12884 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12885
03408648
SM
12886 * fns.c (concat, mapcar1): Accept byte-code-functions.
12887
12888 * eval.c (Fsetq): Handle lexical vars.
12889 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12890 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12891 (FletX, Flet): Obey lexical binding.
12892 (Fcommandp): Handle closures.
12893 (Feval): New `lexical' arg.
12894 (eval_sub): New function extracted from Feval. Use it almost
12895 everywhere where Feval was used. Look up vars in lexical env.
12896 Handle closures.
12897 (Ffunctionp): Move from subr.el.
12898 (Ffuncall): Handle closures.
12899 (apply_lambda): Remove `eval_flags'.
12900 (funcall_lambda): Handle closures and new byte-code-functions.
12901 (Fspecial_variable_p): New function.
12902 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12903 but without exporting it to Lisp.
23aba0ea 12904
23aba0ea 12905 * doc.c (Fdocumentation, store_function_docstring):
03408648 12906 * data.c (Finteractive_form): Handle closures.
23aba0ea 12907
03408648
SM
12908 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12909 interactive spec.
ba83908c 12910
04f2d78b
CB
12911 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12912 New byte-codes.
03408648
SM
12913 (exec_byte_code): New function extracted from Fbyte_code to handle new
12914 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12915
03408648 12916 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12917
03408648 12918 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12919
e2abce01
JB
129202011-03-31 Juanma Barranquero <lekktu@gmail.com>
12921
12922 * xdisp.c (redisplay_internal): Fix prototype.
12923
63696a73 129242011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12925
63696a73 12926 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12927 (try_scrolling): Use it when setting scroll_limit.
12928 Limit scrolling to 100 screen lines.
63696a73
EZ
12929 (redisplay_window): Even when falling back on "recentering",
12930 position point in the window according to scroll-conservatively,
12931 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12932
12933 (try_scrolling): When point is above the window, allow searching
12934 as far as scroll_max, or one screenful, to compute vertical
12935 distance from PT to the scroll margin position. This prevents
12936 try_scrolling from unnecessarily failing when
12937 scroll-conservatively is set to a value slightly larger than the
12938 window height. Clean up the case of PT below the margin at bottom
12939 of window: scroll_max can no longer be INT_MAX. When aggressive
12940 scrolling is in use, don't let point enter the opposite scroll
12941 margin as result of the scroll.
12942 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12943 threshold of 100 lines for never-recentering scrolling.
12944
e4cc2dfc
JB
129452011-03-31 Juanma Barranquero <lekktu@gmail.com>
12946
12947 * dispextern.h (move_it_by_lines):
12948 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12949 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12950 (message_log_check_duplicate): Remove parameters `prev_bol' and
12951 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12952 (redisplay_internal): Remove parameter `preserve_echo_area',
12953 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12954
12955 * indent.c (Fvertical_motion):
12956 * window.c (window_scroll_pixel_based, Frecenter):
12957 Don't pass `need_y_p' to `move_it_by_lines'.
12958
1c470562
SM
129592011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12960
44f230aa
SM
12961 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12962 steal a few bits to be more compact.
12963 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12964 Remove unneeded casts.
12965
1c470562
SM
12966 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12967
888adce9
ZK
129682011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12969
12970 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12971 binding" message (bug#7967).
12972
f838ed7b
PE
129732011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12974
77861b95
PE
12975 Fix more problems found by GCC 4.6.0's static checks.
12976
de6dbc14
PE
12977 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12978 Remove unused local var.
12979
f838ed7b
PE
12980 * editfns.c (Fmessage_box): Remove unused local var.
12981
792c7b2b
PE
12982 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12983 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12984 Omit unused local vars.
c499e557 12985 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12986 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12987 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12988 Omit unused local var.
12989
ba0165e1
PE
12990 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12991 Don't assume string length fits in int.
32ad8845 12992 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12993 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12994
3c59b4c9
PE
12995 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12996 instead of alloca (Bug#8344).
12997
a3eed478 12998 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12999 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13000
eb4d412d
PE
13001 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13002
1658b401
PE
13003 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13004 concerns.
13005
13006 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13007
13008 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13009
9a2c6e05
PE
13010 * keyboard.c (syms_of_keyboard): Use the same style as later
13011 in this function when indexing through an array. This also
13012 works around GCC bug 48267.
13013
03d0a109
PE
13014 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13015
44f730c8
PE
13016 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13017
fe75f926
PE
13018 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13019 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13020
ffa8c828
PE
13021 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13022 This avoids undefined behavior on integer overflow, and is a bit
13023 more convenient anyway since it is compared to a size_t variable.
13024
c5101a77
PE
13025 Variadic C functions now count arguments with size_t, not int.
13026 This avoids an unnecessary limitation on 64-bit machines, which
13027 caused (substring ...) to crash on large vectors (Bug#8344).
13028 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13029 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13030 All variadic functions and their callers changed accordingly.
c5101a77
PE
13031 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13032 * data.c (arith_driver, float_arith_driver): Likewise.
13033 * editfns.c (general_insert_function): Likewise.
13034 * eval.c (struct backtrace.nargs, interactive_p)
13035 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13036 (funcall_lambda, mark_backtrace): Likewise.
13037 * fns.c (concat): Likewise.
13038 * frame.c (x_set_frame_parameters): Likewise.
13039 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13040 0 if not found, not -1. All callers changed.
13041
dd3f25f7
PE
13042 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13043 (stack_copy_size): Now size_t, not int.
13044 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13045
461c2ab9
JB
130462011-03-28 Juanma Barranquero <lekktu@gmail.com>
13047
13048 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13049 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13050 All callers changed.
13051
13052 * lisp.h (multibyte_char_to_unibyte):
13053 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13054 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13055 * character.h (CHAR_TO_BYTE8):
13056 * cmds.c (internal_self_insert):
13057 * editfns.c (general_insert_function):
13058 * keymap.c (push_key_description):
13059 * search.c (Freplace_match):
13060 * xdisp.c (message_dolog, set_message_1): All callers changed.
13061
f6d62986
SM
130622011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13063
13064 * keyboard.c (safe_run_hook_funcall): New function.
13065 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13066 don't set the hook to nil, but remove the offending function instead.
13067 (Qcommand_hook_internal): Remove, unused.
13068 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13069 Vcommand_hook_internal.
13070
13071 * eval.c (enum run_hooks_condition): Remove.
13072 (funcall_nil, funcall_not): New functions.
13073 (run_hook_with_args): Call each function through a `funcall' argument.
13074 Remove `cond' argument, now redundant.
13075 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13076 (Frun_hook_with_args_until_failure): Adjust accordingly.
13077 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13078
1db5b1ad
JB
130792011-03-28 Juanma Barranquero <lekktu@gmail.com>
13080
13081 * dispextern.h (string_buffer_position): Remove declaration.
13082
13083 * print.c (strout): Remove parameter `multibyte', unused since
13084 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13085
13086 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13087 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13088 All callers changed.
13089
13090 * w32.c (_wsa_errlist): Use braces for struct initializers.
13091
13092 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13093 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13094 All callers changed.
13095 (string_buffer_position): Likewise. Also, make static (it's never
13096 used outside xdisp.c).
13097 (cursor_row_p): Remove parameter `w', unused since
13098 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13099 (decode_mode_spec): Remove parameter `precision', introduced during
13100 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13101 All callers changed.
13102
5ffb62aa
JD
131032011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13104
13105 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13106
461c2ab9 131072011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13108
13109 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13110 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13111 (ns_update_auto_hide_menu_bar): New functions.
13112 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13113 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13114 ns_constrain_all_frames.
13115 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13116 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13117
5c380ffb
JD
131182011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13119
13120 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13121
9af30bdf
GM
131222011-03-27 Glenn Morris <rgm@gnu.org>
13123
13124 * syssignal.h: Replace RETSIGTYPE with void.
13125 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13126 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13127 Replace SIGTYPE with void everywhere.
13128 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13129 * s/template.h (SIGTYPE): Remove commented out definition.
13130
e2abce01
JB
131312011-03-26 Eli Zaretskii <eliz@gnu.org>
13132
13133 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13134 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13135
f868cd8a
JB
131362011-03-26 Juanma Barranquero <lekktu@gmail.com>
13137
59eb0929
JB
13138 * w32.c (read_unc_volume): Use parameter `henum', instead of
13139 global variable `wget_enum_handle'.
13140
13141 * keymap.c (describe_vector): Remove parameters `indices' and
13142 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13143 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13144
f868cd8a
JB
13145 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13146
13147 * keyboard.c (timer_check): Remove parameter `do_it_now',
13148 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13149 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13150 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13151
13152 * keyboard.c (read_char):
13153 * w32menu.c (w32_menu_display_help):
13154 * xmenu.c (show_help_event, menu_help_callback):
13155 Adjust calls to `show_help_echo'.
13156
13157 * gtkutil.c (xg_maybe_add_timer):
13158 * keyboard.c (readable_events):
13159 * process.c (wait_reading_process_output):
13160 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13161
13162 * insdel.c (adjust_markers_gap_motion):
13163 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13164 (gap_left, gap_right): Don't call it.
13165
2ecf6fdb
CY
131662011-03-25 Chong Yidong <cyd@stupidchicken.com>
13167
13168 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13169 incurred during fontification.
13170
6b1f9ba4
JB
131712011-03-25 Juanma Barranquero <lekktu@gmail.com>
13172
13173 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13174 (DEFVAR_PER_BUFFER): Don't pass it.
13175
13176 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13177 (scrolling_window): Don't pass it.
13178
0f4a96b5
JB
131792011-03-25 Juanma Barranquero <lekktu@gmail.com>
13180
13181 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13182
13183 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13184 and `suffix'.
13185 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13186 of variables specific to SELinux and computation of `encoded_absname'.
13187
13188 * image.c (XPutPixel): Remove unused variable `height'.
13189
13190 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13191
13192 * unexw32.c (get_section_info): Remove unused variable `section'.
13193
13194 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13195 (system_process_attributes): Remove unused variable `sess'.
13196 (sys_read): Remove unused variable `err'.
13197
13198 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13199 (w32_wnd_proc): Remove unused variable `isdead'.
13200 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13201 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13202 (x_create_tip_frame): Remove unused variable `tem'.
13203
13204 * w32inevt.c (w32_console_read_socket):
13205 Remove unused variable `no_events'.
13206
13207 * w32term.c (x_draw_composite_glyph_string_foreground):
13208 Remove unused variable `width'.
13209
1149507c
JB
132102011-03-24 Juanma Barranquero <lekktu@gmail.com>
13211
13212 * w32term.c (x_set_glyph_string_clipping):
13213 Don't pass uninitialized region to CombineRgn.
13214
9c88f339
JB
132152011-03-23 Juanma Barranquero <lekktu@gmail.com>
13216
13217 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13218 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13219 (Fx_close_connection): Remove unused variable `i'.
13220
13221 * w32font.c (w32font_draw): Return number of glyphs.
13222 (w32font_open_internal): Remove unused variable `i'.
13223 (w32font_driver): Add missing initializer.
13224
13225 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13226 (fill_in_menu): Remove unused variable `items_added'.
13227
13228 * w32term.c (last_mouse_press_frame): Remove static global variable.
13229 (w32_clip_to_row): Remove unused variable `f'.
13230 (x_delete_terminal): Remove unused variable `i'.
13231
13232 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13233 (NOTHING): Remove unused static global variable.
13234 (uniscribe_check_otf): Remove unused variable `table'.
13235 (uniscribe_font_driver): Add missing initializers.
13236
dee091a3
JD
132372011-03-23 Julien Danjou <julien@danjou.info>
13238
13239 * term.c (Fsuspend_tty, Fresume_tty):
13240 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13241 * window.c (temp_output_buffer_show):
13242 * insdel.c (signal_before_change):
13243 * frame.c (Fhandle_switch_frame):
13244 * fileio.c (Fdo_auto_save):
13245 * emacs.c (Fkill_emacs):
13246 * editfns.c (save_excursion_restore):
13247 * cmds.c (internal_self_insert):
13248 * callint.c (Fcall_interactively):
13249 * buffer.c (Fkill_all_local_variables):
13250 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13251 Use Frun_hooks.
0f4a96b5 13252 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13253 unconditionally since it does the check itself.
dee091a3 13254
2c520ab5 132552011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13256
c9c49752
PE
13257 Fix more problems found by GCC 4.5.2's static checks.
13258
8abc3f12
PE
13259 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13260 the first time through the loop, since we know p0 < p1 then.
13261 This also avoids a gcc -Wstrict-overflow warning.
13262
a2d26660
PE
13263 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13264 leading to a memory leak, possible in functions like
13265 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13266 of objects (Bug#8318).
a2d26660 13267
916c72e9
PE
13268 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13269 that could (at least in theory) be that large.
13270
19ab8a18
PE
13271 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13272 This is less likely to overflow, and avoids undefined behavior if
13273 overflow does occur. All callers changed. Use strtoul to scan
13274 for the unsigned long integer.
b7cbbd6f
PE
13275 (pint2hrstr): Simplify and tune code slightly.
13276 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13277
f0641eff
PE
13278 * scroll.c (do_scrolling): Work around GCC bug 48228.
13279 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13280
7f650bb9
PE
13281 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13282 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13283 (validate_x_resource_name): Simplify count usage.
13284 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13285
37dd57d1
PE
13286 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13287 fail (Bug#8306).
81e56e61 13288
699979fc 13289 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13290
401bf9b4
PE
13291 * process.c (Fmake_network_process): Use socklen_t, not int,
13292 where POSIX says socklen_t is required in portable programs.
13293 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13294 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13295 (Fmake_network_process, server_accept_connection):
13296 (wait_reading_process_output, read_process_output):
13297 Likewise.
13298
b93aacde
PE
13299 * process.c: Rename or move locals to avoid shadowing.
13300 (list_processes_1, Fmake_network_process):
13301 (read_process_output_error_handler, exec_sentinel_error_handler):
13302 Rename or move locals.
4dc343ee 13303 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13304 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13305 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13306 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13307 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13308
af8a867c 13309 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13310 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13311 Include tparam.h instead, since it declares them.
af8a867c
PE
13312 * cm.h (PC): Remove extern decl; tparam.h now does this.
13313 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13314 * terminfo.c: Include tparam.h, to check interfaces.
13315 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13316 (tparam): Adjust signature to match interface in tparam.h;
13317 this removes some undefined behavior. Check that outstring and len
13318 are zero, which they always are with Emacs.
13319 * tparam.h (PC, BC, UP): New extern decls.
13320
0248044d 13321 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13322 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13323
8ff096c1 13324 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13325 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13326 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13327 (ftfont_list): Remove unused local.
49eaafba
PE
13328 (get_adstyle_property, ftfont_pattern_entity):
13329 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13330 Rename locals to avoid shadowing.
8ff096c1 13331
e2be39f6
PE
13332 * xfont.c (xfont_list_family): Mark var as initialized.
13333
c9735e30
PE
13334 * xml.c (make_dom): Now static.
13335
8f5201ae
PE
13336 * composite.c (composition_compute_stop_pos): Rename local to
13337 avoid shadowing.
b246f932
PE
13338 (composition_reseat_it): Remove unused locals.
13339 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13340 (composition_update_it): Mark var as initialized.
11b61122
PE
13341 (find_automatic_composition): Mark vars as initialized,
13342 with a FIXME (Bug#8290).
8f5201ae 13343
760fbc2c
PE
13344 character.h: Rename locals to avoid shadowing.
13345 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13346 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13347 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13348 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13349 to avoid shadowing.
13350
ff08eb85
PE
13351 * textprop.c (property_change_between_p): Remove; unused.
13352
fc7bf025
PE
13353 * intervals.c (interval_start_pos): Now static.
13354
235d7abc
PE
13355 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13356
44f230aa
SM
13357 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13358 Rename locals to avoid shadowing.
3e7d6594 13359
50060332
PE
13360 * sound.c (wav_play, au_play, Fplay_sound_internal):
13361 Fix pointer signedness.
d01f234b 13362 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13363 (wav_play): Initialize a variable to 0, to prevent undefined
13364 behavior (Bug#8278).
50060332 13365
c4fc4e30
PE
13366 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13367
918436ed
PE
13368 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13369
c939f91b
PE
13370 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13371 clobbering (Bug#8298).
b9c7f648
PE
13372 * sysdep.c (sys_subshell): Likewise.
13373 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13374
6bd8c144
PE
13375 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13376 This should get cleaned up, so that child_setup has the
13377 same signature on all platforms.
13378
7710357c 13379 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13380 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13381
c59da222
CY
133822011-03-22 Chong Yidong <cyd@stupidchicken.com>
13383
13384 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13385 not to be necessary, and produces flickering.
13386
66b87493
GM
133872011-03-20 Glenn Morris <rgm@gnu.org>
13388
13389 * config.in: Remove file.
13390
45b6f6d5
JB
133912011-03-20 Juanma Barranquero <lekktu@gmail.com>
13392
13393 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13394 are now in src/globals.h.
13395 (syms_of_minibuf): Remove spurious & from previous change.
13396
cd394be1 133972011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13398
13399 * minibuf.c (completing-read-function): New variable.
13400 (completing-read-default): Rename from completing-read.
13401 (completing-read): Call completing-read-function.
13402
b14e3e21
CY
134032011-03-19 Juanma Barranquero <lekktu@gmail.com>
13404
13405 * xfaces.c (Fx_load_color_file):
13406 Read color file from absolute filename (bug#8250).
13407
f2b726e6
JB
134082011-03-19 Juanma Barranquero <lekktu@gmail.com>
13409
13410 * makefile.w32-in: Update dependencies.
13411
09f6ff02
EZ
134122011-03-17 Eli Zaretskii <eliz@gnu.org>
13413
13414 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13415
29a6015a
PE
134162011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13417
a3a6c54e
PE
13418 Fix more problems found by GCC 4.5.2's static checks.
13419
b766f867
PE
13420 * process.c (make_serial_process_unwind, send_process_trap):
13421 (sigchld_handler): Now static.
13422
be02381c
PE
13423 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13424 That way, the code declares only the vars that it needs.
13425 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13426 * s/cygwin.h (PTY_ITERATION): Likewise.
13427 * s/darwin.h (PTY_ITERATION): Likewise.
13428 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13429
57048744
PE
13430 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13431 * process.c (allocate_pty): Don't declare stb unless it's needed.
13432
7914961c 13433 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13434 (CONSTANTLIM): Remove; unused.
13435 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13436 Define only if needed.
7914961c 13437
b3967b18
PE
13438 * unexelf.c (unexec): Name an expression,
13439 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13440 Use a different way to cause a compilation error if anyone uses
13441 n rather than nn, a way that does not involve shadowing.
73366a00 13442 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13443
29a6015a
PE
13444 * deps.mk (unexalpha.o): Remove; unused.
13445
43cfc33e 13446 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13447 * unexec.h: New file.
ce701a33
PE
13448 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13449 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13450 Depend on unexec.h.
13451 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13452 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13453 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13454 Change as necessary to match prototype in unexec.h.
ce701a33 13455
01f44d5a
PE
13456 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13457 shadowing.
4f63c6bb 13458 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13459
a6670b0b
PE
13460 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13461 Rename locals to avoid shadowing.
13462
cef2010d 13463 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13464 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13465
d4d7173a
PE
13466 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13467
f08b802a
PE
13468 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13469 warning when compiling print.c.
13470
3ddb0639
PE
13471 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13472 instead of using an uninitialized var.
5ad03b97 13473 (font_sort_entities): Mark var as initialized.
3ddb0639 13474
170a2692
PE
13475 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13476
e663c700
PE
13477 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13478 pointers to constants.
89bc529a 13479 (font_parse_fcname): Remove unused vars.
7b81e2d0 13480 (font_delete_unmatched): Now static.
ea838e10 13481 (font_get_spec): Remove; unused.
13a547c6
PE
13482 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13483 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13484 Rename or move locals to avoid shadowing.
e663c700 13485
2a80c887 13486 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13487 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13488
1384fa33 13489 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13490 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13491
8b2c52e9
PE
13492 * alloc.c (mark_backtrace): Move decl from here ...
13493 * lisp.h: ... to here, so that it can be checked.
13494
475545b5 13495 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13496 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13497 (lisp_indirect_variable): Name an expression,
13498 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13499 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13500
b1349114 13501 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13502 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13503 Use const pointer when appropriate.
b1349114 13504
a2928364
PE
13505 * lisp.h (get_system_name, get_operating_system_release):
13506 Move decls here, to check interfaces.
13507 * process.c (get_operating_system_release): Move decl to lisp.h.
13508 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13509 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13510 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13511 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13512 (Fformat_time_string, Fencode_time, Finsert_char):
13513 (Ftranslate_region_internal, Fformat):
13514 Rename or remove local vars to avoid shadowing.
9710023e 13515 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13516
a415e694
PE
13517 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13518 avoid shadowing.
13519
8ef4622d
PE
13520 * lisp.h (eassert): Check that the argument compiles, even if
13521 ENABLE_CHECKING is not defined.
13522
946f9a5b
PE
13523 * data.c (Findirect_variable): Name an expression, to avoid
13524 gcc -Wbad-function-cast warning.
112396d6 13525 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13526 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13527 (Fmake_variable_buffer_local, Fmake_local_variable):
13528 Mark variables as initialized.
52746918 13529 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13530
e5aab7e7 13531 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13532 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13533 Rename locals to avoid shadowing.
dff45157
PE
13534 (mark_stack): Move local variables into the #ifdef region where
13535 they're used.
7bc26fdb
PE
13536 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13537 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13538 needed otherwise.
13539 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13540 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13541 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13542
e5aab7e7
PE
13543 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13544 avoids undefined behavior in theory.
13545
4da60324
PE
13546 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13547
88043301
PE
13548 Use functions, not macros, for up- and down-casing (Bug#8254).
13549 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13550 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13551 to use the following functions instead of these macros.
13552 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13553 EMACS_INT, since callers assume the returned value fits in int.
13554 (upcase1): Likewise, for UPCASE_TABLE.
13555 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13556 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13557 the race-condition problem in the old DOWNCASE.
88043301 13558
19ed5445
PE
13559 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13560 Rename locals to avoid shadowing.
13561 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13562 (regex_compile, re_search_2, re_match_2_internal):
13563 Remove unused local vars.
952db0d7
PE
13564 (FREE_VAR): Rewrite so as not to use empty "else",
13565 which gcc can warn about.
da053e48 13566 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13567 (RETALLOC_IF): Define only if needed.
13568 (WORDCHAR_P): Likewise. This one is never needed, but is used
13569 only in a comment talking about a compiler bug, so put inside
13570 the #if 0 of that comment.
13571 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13572 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13573 Remove; unused.
19ed5445 13574
1f3561e4 13575 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13576 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13577 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13578
ded6f8f7
PE
13579 * search.c (simple_search): Remove unused var.
13580
dbd37a95
PE
13581 * dired.c (compile_pattern): Move decl from here ...
13582 * lisp.h: ... to here, so that it can be checked.
13583 (struct re_registers): New forward decl.
13584
7e47afad
PE
13585 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13586
85f24f61
PE
13587 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13588 All uses changed.
13589 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13590 Rename locals to avoid shadowing.
5671df8f 13591 (Fvertical_motion): Mark locals as initialized.
85f24f61 13592
181aa2be 13593 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13594 (casify_region): Mark local as initialized.
181aa2be 13595
930d429c
PE
13596 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13597
7082eac6
PE
13598 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13599 New macros, so that the caller can use some names other than
13600 gcpro1, gcpro2, etc.
13601 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13602 of the new macros.
13603 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13604 argument, for consistency with GCPRO2_VAR, etc: it is now the
13605 prefix of the variable, not the variable itself. All uses
13606 changed.
38b2c076
PE
13607 * dired.c (directory_files_internal, file_name_completion):
13608 Rename locals to avoid shadowing.
13609
15206ed9
PE
13610 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13611 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13612 dired.c's scmp function, had undefined behavior.
13613 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13614 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13615 * buffer.h: ... to here, because these macros use current_buffer,
13616 and the new implementation with inline functions needs to have
13617 current_buffer in scope now, rather than later when the macros
13618 are used.
13619 (downcase, upcase1): New static inline functions.
13620 (DOWNCASE, UPCASE1): Reimplement using these functions.
13621 This avoids undefined behavior in expressions like
13622 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13623 from race conditions in accessing the global variables
13624 case_temp1 and case_temp2.
13625 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13626 * lisp.h (case_temp1, case_temp2): Remove their decls.
13627 * character.h (ASCII_CHAR_P): Move from here ...
13628 * lisp.h: ... to here, so that the inline functions mentioned
13629 above can use them.
13630
4a6bea26
PE
13631 * dired.c (directory_files_internal_unwind): Now static.
13632
f14b7e14
PE
13633 * fileio.c (file_name_as_directory, directory_file_name):
13634 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13635 Now static.
2893f146
PE
13636 (file_name_as_directory): Use const pointers when appropriate.
13637 (Fexpand_file_name): Likewise. In particular, newdir might
13638 point at constant storage, so make it a const pointer.
fd4ead52 13639 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13640 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13641 signedness issues.
f839df0c
PE
13642 (Fset_file_times, Finsert_file_contents, auto_save_error):
13643 Rename locals to avoid shadowing.
f14b7e14 13644
5716756e 13645 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13646 (Ftry_completion, Fall_completions): Rename or remove locals
13647 to avoid shadowing.
5716756e 13648
b4c3046a
PE
13649 * marker.c (bytepos_to_charpos): Remove; unused.
13650
b45db522
PE
13651 * lisp.h (verify_bytepos, count_markers): New decls,
13652 so that gcc does not warn that these functions aren't declared.
13653
85876d07
PE
13654 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13655 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13656 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13657 (copy_text): Remove unused local var.
85876d07 13658
03d78a21 13659 * filelock.c (within_one_second): Now static.
b3dd38ab 13660 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13661
5df8f01b
PE
13662 * buffer.c (fix_overlays_before): Mark locals as initialized.
13663 (fix_start_end_in_overlays): Likewise. This function should be
13664 simplified by using pointers-to-pointers, but that's a different
13665 matter.
b1d876f1 13666 (switch_to_buffer_1): Now static.
8f54f30a
PE
13667 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13668 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13669
a70072c9 13670 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13671 Fix pointer signedness issue.
edced198
PE
13672 (sys_subshell): Mark local as volatile if checking for lint,
13673 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13674 (MAXPATHLEN): Define only if needed.
a70072c9 13675
a0977c44
PE
13676 * process.c (serial_open, serial_configure): Move decls from here ...
13677 * systty.h: ... to here, so that they can be checked.
13678
a884fdcc
PE
13679 * fns.c (get_random, seed_random): Move extern decls from here ...
13680 * lisp.h: ... to here, so that they can be checked.
13681
604efe86 13682 * sysdep.c (reset_io): Now static.
b8950c94 13683 (wait_for_termination_signal): Remove; unused.
604efe86 13684
38fc62d9
PE
13685 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13686 (copy_keymap_item, append_key, push_text_char_description):
13687 Now static.
1004a21a 13688 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13689 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13690 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13691 (describe_map_tree):
13692 Rename locals to avoid shadowing.
38fc62d9 13693
2f2650da
PE
13694 * keyboard.c: Declare functions static if they are not used elsewhere.
13695 (echo_char, echo_dash, cmd_error, top_level_2):
13696 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13697 (read_char, kbd_buffer_get_event, make_lispy_position):
13698 (make_lispy_event, make_lispy_movement, apply_modifiers):
13699 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13700 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13701 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13702 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13703 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13704
a053e86c 13705 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13706 (mark_kboards): Move decl here ...
13707 * alloc.c (mark_kboards): ... from here.
a053e86c 13708
4752793e
PE
13709 * lisp.h (force_auto_save_soon): New decl.
13710
74f10ca7 13711 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13712 (DEFINE_DUMMY_FUNCTION): New macro.
13713 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13714 Use it.
c03cd23f
PE
13715 (main): Add casts to avoid warnings
13716 if GCC considers string literals to be constants.
74f10ca7 13717
022e70d4
PE
13718 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13719
59d6fe83
PE
13720 * dbusbind.c: Pointer signedness fixes.
13721 (xd_signature, xd_append_arg, xd_initialize):
13722 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13723 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13724 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13725 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13726
78320123
PE
13727 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13728 if GCC considers string literals to be constants.
49cebcca 13729 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13730
35ac2a97
SM
137312011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13732
fb103ca9
SM
13733 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13734 (print_preprocess, print_object): New macro to fix last change.
13735
35ac2a97
SM
13736 * print.c (print_preprocess): Don't forget font objects.
13737
62973b41
JB
137382011-03-16 Juanma Barranquero <lekktu@gmail.com>
13739
13740 * emacs.c (USAGE3): Doc fixes.
13741
0e48bb22
AS
137422011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13743
13744 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13745 structure.
13746
7684e57b
JB
137472011-03-14 Juanma Barranquero <lekktu@gmail.com>
13748
13749 * lisp.h (VWindow_system, Qfile_name_history):
13750 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13751 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13752 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13753
13754 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13755 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13756
13757 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13758 * w32console.c (detect_input_pending, read_input_pending)
13759 (encode_terminal_code):
13760 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13761 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13762 (w32_system_caret_y, Qfile_name_history):
13763 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13764 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13765 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13766 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13767 * w32proc.c (Qlocal, report_file_error):
13768 * w32term.c (Vwindow_system, updating_frame):
13769 * w32uniscribe.c (initialized, uniscribe_font_driver):
13770 Remove unneeded extern declarations.
13771
2aa46d6c
CY
137722011-03-14 Chong Yidong <cyd@stupidchicken.com>
13773
c96bbc66 13774 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13775
cffc6f3b
CY
137762011-03-13 Chong Yidong <cyd@stupidchicken.com>
13777
13778 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13779 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13780 These macros can no longer be used for assignment.
13781
44f230aa
SM
13782 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13783 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13784 (record_buffer_markers, fetch_buffer_markers): New functions for
13785 recording and fetching special buffer markers.
13786 (set_buffer_internal_1, set_buffer_temp): Use them.
13787
13788 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13789
13790 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13791
13792 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13793 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13794
13795 * xdisp.c (hscroll_window_tree):
13796 (reconsider_clip_changes): Use PT instead of BUF_PT.
13797
d251f04b
EZ
137982011-03-13 Eli Zaretskii <eliz@gnu.org>
13799
13800 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13801 $(EMACS_ROOT)/lib/intprops.h.
13802
f0c77cd1
PE
138032011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13804
3eca4629
PE
13805 Fix more problems found by GCC 4.5.2's static checks.
13806
7c86ee98
PE
13807 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13808 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13809 (xg_free_frame_widgets): Make it clear that a local variable is
13810 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13811 (gdk_window_get_screen): Make it clear that this macro is needed
13812 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13813 (int_gtk_range_get_value): New function, which avoids a diagnostic
13814 from gcc -Wbad-function-cast.
13815 (xg_set_toolkit_scroll_bar_thumb): Use it.
13816 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13817 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13818 (get_utf8_string, xg_get_file_with_chooser):
13819 Rename locals to avoid shadowing.
13820 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13821
41729b81
PE
13822 * xgselect.c (xg_select): Remove unused var.
13823
f0c77cd1
PE
13824 * image.c (four_corners_best): Mark locals as initialized.
13825 (gif_load): Initialize transparent_p to zero (Bug#8238).
13826 Mark another local as initialized.
ec6cf4c6 13827 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13828
ce0ad53d 13829 * image.c (clear_image_cache): Now static.
d5d5a617 13830 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13831 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13832 (x_edge_detection): Remove unnecessary cast that
13833 gcc -Wbad-function-cast diagnoses.
2037898d 13834 (gif_load): Fix pointer signedness.
6ae141d6
PE
13835 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13836 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13837
33383987 138382011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13839
d32df629
PE
13840 Improve quality of tests for time stamp overflow.
13841 For example, without this patch (encode-time 0 0 0 1 1
13842 1152921504606846976) returns the obviously-bogus value (-948597
13843 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13844 reports time overflow. See
13845 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13846 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13847 * editfns.c: Include limits.h and intprops.h.
13848 (TIME_T_MIN, TIME_T_MAX): New macros.
13849 (time_overflow): Move earlier, to before first use.
13850 (hi_time, lo_time): New functions, for an accurate test for
13851 out-of-range times.
13852 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13853 (Fget_internal_run_time): Don't assume time_t fits in int.
13854 (make_time): Use list2 instead of Fcons twice.
13855 (Fdecode_time): More accurate test for out-of-range times.
13856 (check_tm_member): New function.
13857 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13858 (lisp_time_argument): Don't rely on undefined left-shift and
13859 right-shift behavior when checking for time stamp overflow.
8be6f318 13860
fe31d94c
PE
13861 * editfns.c (time_overflow): New function, refactoring common code.
13862 (Fformat_time_string, Fdecode_time, Fencode_time):
13863 (Fcurrent_time_string): Use it.
13864
8be6f318
PE
13865 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13866 * dired.c (make_time): Move to ...
13867 * editfns.c (make_time): ... here.
13868 * systime.h: Note the move.
13869
09d9db2c 138702011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13871
126bc0dc
YM
13872 * fringe.c (update_window_fringes): Remove unused variables.
13873
c47cbdfd
YM
13874 * unexmacosx.c (copy_data_segment): Also copy __got section.
13875 (Bug#8223)
13876
7ac80be9
EZ
138772011-03-12 Eli Zaretskii <eliz@gnu.org>
13878
c96bbc66 13879 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13880 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13881 Constify `char *' arguments and their references according to
13882 prototypes in tparam.h.
13883
ecb0f94d 13884 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13885
7ac80be9
EZ
13886 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13887 Adapt all references accordingly.
13888
13889 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13890
ef1fd07e
TT
138912011-03-11 Tom Tromey <tromey@redhat.com>
13892
13893 * buffer.c (syms_of_buffer): Remove obsolete comment.
13894
7ef4b50c
EZ
138952011-03-11 Eli Zaretskii <eliz@gnu.org>
13896
13897 * termhooks.h (encode_terminal_code): Declare prototype.
13898
13899 * msdos.c (encode_terminal_code): Don't declare prototype.
13900
13901 * term.c (encode_terminal_code): Now external again, used by
13902 w32console.c and msdos.c.
13903
44f230aa
SM
13904 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13905 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13906
4b1ec863 139072011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13908
1714f52b 13909 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13910
4b1ec863
PE
13911 * fringe.c (update_window_fringes): Mark locals as initialized
13912 (Bug#8227).
13913 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13914
524c7aa6
PE
13915 * alloc.c (mark_fringe_data): Move decl from here ...
13916 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13917 to check its interface.
13918 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13919
a5c0af81 13920 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13921 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13922 (fontset_font): Mark local as initialized.
a9a06e0b 13923 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13924
b4716021
PE
13925 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13926
811e9bac 13927 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13928 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13929 (x_own_selection, Fx_disown_selection_internal): Rename locals
13930 to avoid shadowing.
13931 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13932
7e3ab302
PE
13933 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13934 so that the caller can use some name other than gcpro1.
13935 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13936 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13937 (Fx_backspace_delete_keys_p):
13938 Use them to avoid shadowing, and rename vars to avoid shadowing.
13939 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13940 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13941 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13942 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13943 Remove unused locals.
7e3ab302
PE
13944 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13945 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13946 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13947 macros.
f78faa98 13948
e2b13473
PE
13949 * xterm.h (x_mouse_leave): New decl.
13950
77f23912
PE
13951 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13952 Remove unused functions.
cdf4ba58
PE
13953 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13954 (x_calc_absolute_position): Now static.
7411c686 13955 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13956 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13957 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13958 unless they are used.
38d0b34a
PE
13959 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13960 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13961 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13962 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13963 (x_error_catcher, x_connection_closed, x_error_handler):
13964 (x_error_quitter, xembed_send_message, x_iconify_frame):
13965 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13966 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13967 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13968
44f230aa
SM
13969 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13970 Rename or move locals to avoid shadowing.
6b463e58 13971 (tty_defined_color, merge_face_heights): Now static.
5967d051 13972 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13973 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13974 does not deduce is never used uninitialized.
73719eba
PE
13975 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13976 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13977
426994c3 13978 * terminal.c (store_terminal_param): Now static.
5489860b 13979
032f1620 13980 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13981 (set_frame_menubar): Remove unused local.
d4323972 13982 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13983 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13984 since they might point to immutable storage.
281585b0
PE
13985 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13986 since it's unused otherwise.
032f1620 13987
367c19e5 13988 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13989 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13990 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13991 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13992 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13993 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13994 does not deduce are never used uninitialized.
70739cbe 13995
07b48fa9
PE
13996 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13997
8868a238 13998 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13999 * window.c (window_loop, size_window):
14000 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14001
7e5cf297 14002 * window.c (display_buffer): Now static.
d6550a9f
PE
14003 (size_window): Mark variables that gcc -Wuninitialized
14004 does not deduce are never used uninitialized.
a586633d
PE
14005 * window.h (check_all_windows): New decl, to forestall
14006 gcc -Wmissing-prototypes diagnostic.
5b555da1 14007 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14008
f6095868
PE
14009 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14010 shadowing.
14011 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14012 Include <limits.h>.
14013 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14014 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14015 (load_charset_map): Mark variables that gcc -Wuninitialized
14016 does not deduce are never used uninitialized.
53df7c11 14017 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14018
f38b440c
PE
14019 * coding.c (coding_set_source, coding_set_destination):
14020 Use "else { /* comment */ }" rather than "else /* comment */;"
14021 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14022 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14023 a block, when the outer 'i' will do.
14024 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14025 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14026 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14027 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14028 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14029 Rename locals to avoid shadowing.
14030 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14031 * coding.c (emacs_mule_char, encode_invocation_designation):
14032 Now static, since they're not used elsewhere.
413bb2db 14033 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14034 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14035 (decode_coding_emacs_mule): Mark variables that gcc
14036 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14037 (detect_coding_iso_2022): Initialize a local variable that might
14038 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14039 this initialization is needed. (Bug#8211)
5f58e762
PE
14040 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14041 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14042 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14043 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14044 Remove unused macros.
f38b440c 14045
232b38b9 14046 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14047 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14048 * character.c (string_count_byte8): Likewise.
232b38b9 14049
fb90da1b
PE
14050 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14051 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14052
fb93dbc2
PE
14053 * chartab.c (copy_sub_char_table): Now static, since it's not used
14054 elsewhere.
5c156ace
PE
14055 (sub_char_table_ref_and_range, char_table_ref_and_range):
14056 Rename locals to avoid shadowing.
bbcd0949 14057 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14058
7d3b3862 14059 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14060 (BIDI_BOB): Remove unused macro.
7d3b3862 14061
6be7d3da
PE
14062 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14063 deduce are never used uninitialized.
c2ed9c8b 14064 * term.c (encode_terminal_code): Likewise.
6be7d3da 14065
75f8807f 14066 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14067
50938595
PE
14068 * tparam.h: New file.
14069 * term.c, tparam.h: Include it.
14070 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14071 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14072 Move these decls to tparam.h, and make them agree with what
14073 is actually in tparam.c. The previous trick of using incompatible
14074 decls in different modules does not conform to the C standard.
14075 All callers of tparam changed to use tparam's actual API.
14076 * tparam.c (tparam1, tparam, tgoto):
14077 Use const pointers where appropriate.
14078
fbceeba2
PE
14079 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14080 * cm.h (struct cm): Likewise.
14081 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14082 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14083 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14084 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14085 (turn_on_face, init_tty): Likewise.
14086 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14087
7f3f1250
PE
14088 * term.c (term_mouse_position): Rename local to avoid shadowing.
14089
e6ca6543
PE
14090 * alloc.c (mark_ttys): Move decl from here ...
14091 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14092
c40f8d15
AS
140932011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14094
14095 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14096
cfe0661d
JB
140972011-03-09 Juanma Barranquero <lekktu@gmail.com>
14098
14099 * search.c (compile_pattern_1): Remove argument regp, unused since
14100 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14101 (compile_pattern): Don't pass it.
14102
0afb4571
J
141032011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14104
14105 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14106 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14107 for ! HAVE_GTK3.
14108 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14109
14110 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14111
14112 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14113 gdk_window_get_screen, gdk_window_get_geometry,
14114 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14115 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14116 (xg_get_pixbuf_from_pixmap): New function.
14117 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14118 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14119 Call xg_get_pixbuf_from_pixmap instead of
14120 gdk_pixbuf_get_from_drawable.
14121 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14122 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14123 (xg_check_special_colors): Use GtkStyleContext and its functions
14124 for HAVE_GTK3.
14125 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14126 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14127 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14128 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14129 Call gtk_widget_get_preferred_size.
0afb4571
J
14130 (xg_frame_resized): gdk_window_get_geometry only takes 5
14131 parameters.
44f230aa
SM
14132 (xg_win_to_widget, xg_event_is_for_menubar):
14133 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14134 (xg_set_widget_bg): New function.
14135 (delete_cb): New function.
895009e1 14136 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14137 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14138 (xg_set_background_color): Call xg_set_widget_bg.
14139 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14140 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14141 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14142 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14143 if ! HAVE_GTK3.
14144 (update_frame_tool_bar): Call gtk_widget_hide.
14145 (xg_initialize): Use GDK_KEY_g.
14146
14147 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14148 if ! HAVE_GTK3
14149 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14150
14151 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14152 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14153 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14154
1c2cc4ef
JB
141552011-03-08 Juanma Barranquero <lekktu@gmail.com>
14156
14157 * w32xfns.c (select_palette): Check success of RealizePalette against
14158 GDI_ERROR, not zero.
14159
33383987 14160See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14161
14162;; Local Variables:
14163;; coding: utf-8
aac0c6e3
MR
14164;; End:
14165
2f097256 14166 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14167
14168 This file is part of GNU Emacs.
14169
14170 GNU Emacs is free software: you can redistribute it and/or modify
14171 it under the terms of the GNU General Public License as published by
14172 the Free Software Foundation, either version 3 of the License, or
14173 (at your option) any later version.
14174
14175 GNU Emacs is distributed in the hope that it will be useful,
14176 but WITHOUT ANY WARRANTY; without even the implied warranty of
14177 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14178 GNU General Public License for more details.
14179
14180 You should have received a copy of the GNU General Public License
14181 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.