* src/s/gnu.h: Don't include fcntl.h
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9e059e3f
GM
12012-07-10 Glenn Morris <rgm@gnu.org>
2
40289a12
GM
3 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
4 O_RDONLY already includes it).
5
9e059e3f
GM
6 Stop ns builds setting the EMACSLOADPATH environment variable.
7 * nsterm.m (ns_load_path): Rename from ns_init_paths.
8 Now it does not set EMACSLOADPATH, just returns the load-path string.
9 * nsterm.h: Update accordingly.
10 * lread.c [HAVE_NS]: Include nsterm.h.
11 (init_lread) [HAVE_NS]: Use ns_load_path.
12 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
13
7c4e8ec0
GM
142012-07-09 Glenn Morris <rgm@gnu.org>
15
d4f600ff
GM
16 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
17 since the included bsd-common.h does so.
18
cbb31951
GM
19 Stop ns builds setting the EMACSPATH environment variable.
20 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
21 (ns_init_paths): Do not set EMACSPATH.
22 * nsterm.h (ns_exec_path): Add it.
23 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
24 Use ns_exec_path.
25
7c4e8ec0
GM
26 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
27
26bccfae
PE
282012-07-09 Paul Eggert <eggert@cs.ucla.edu>
29
a0bee46f
PE
30 * process.c (wait_reading_process_output): 'waitchannels' was unset
31 when read_kbd || !NILP (wait_for_cell); fix this.
32
5994c183
PE
33 Add GCC-style 'const' attribute to functions that can use it.
34 * character.h (char_resolve_modifier_mask):
35 * keyboard.h (make_ctrl_char):
36 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
37 (init_character_once, next_almost_prime, init_fns, init_image)
38 (flush_pending_output, init_sound):
39 * mem-limits.h (start_of_data):
40 * menu.h (finish_menu_items):
41 Add ATTRIBUTE_CONST.
42 * emacs.c (DEFINE_DUMMY_FUNCTION):
43 Declare the dummy function with ATTRIBUTE_CONST.
44 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
45 Add decls with ATTRIBUTE_CONST.
46
26bccfae
PE
47 Minor improvements to make_formatted_string.
48 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
49 where int is good enough, as vsprintf returns an int.
50 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
51
a8290ec3
DA
522012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
53
54 Use make_formatted_string to avoid double length calculation.
55 * lisp.h (make_formatted_string): New prototype.
56 * alloc.c (make_formatted_string): New function.
57 * buffer.c (Fgenerate_new_buffer_name): Use it.
58 * dbus.c (syms_of_dbusbind): Likewise.
59 * editfns.c (Fcurrent_time_zone): Likewise.
60 * filelock.c (get_boot_time): Likewise.
61 * frame.c (make_terminal_frame, set_term_frame_name)
62 (x_report_frame_params): Likewise.
63 * image.c (gs_load): Likewise.
64 * minibuf.c (get_minibuffer): Likewise.
65 * msdos.c (dos_set_window_size): Likewise.
66 * process.c (make_process): Likewise.
67 * xdisp.c (ensure_echo_area_buffers): Likewise.
68 * xsettings.c (apply_xft_settings): Likewise.
69
d01ba2f1
GM
702012-07-09 Glenn Morris <rgm@gnu.org>
71
72 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
73 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
74 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
75 * nsterm.h (ns_etc_directory): Add it.
76 * callproc.c [HAVE_NS]: Include nsterm.h.
77 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
78
f1f924b6
DA
792012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
80
81 Move marker debugging code under MARKER_DEBUG.
82 * marker.c (MARKER_DEBUG): Move marker debugging code under
83 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
84 for bootstrap with --enable-checking (~3x slowdown reported
85 by Juanma Barranquero <lekktu@gmail.com>).
86 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
87
ab531b66
PE
882012-07-08 Paul Eggert <eggert@cs.ucla.edu>
89
90 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
91 See <http://bugs.gnu.org/11825#29>.
92
c4b3bc8a
EZ
932012-07-08 Eli Zaretskii <eliz@gnu.org>
94
95 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
96 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
97 (display_line): Add commentary about displaying truncation glyphs
98 on GUI frames.
99 (produce_special_glyphs): Move here from term.c.
100
101 * term.c (produce_special_glyphs): Move to xdisp.c.
102
103 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
104 section.
c4b3bc8a 105
b676b881
AS
1062012-07-07 Andreas Schwab <schwab@linux-m68k.org>
107
f17c5273
AS
108 * xdisp.c (display_line): Avoid warning about implicit declaration
109 of FRAME_FONT.
110
298819b9
AS
111 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
112
b676b881
AS
113 * lisp.h: Remove empty conditional.
114
6045c4fd
PE
1152012-07-07 Paul Eggert <eggert@cs.ucla.edu>
116
b3350bf9
PE
117 * lread.c (load_path_check): Now static.
118
6045c4fd
PE
119 Fix some minor --with-ns problems found by static checking.
120 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
121 (x_set_font) [!HAVE_X_WINDOWS]:
122 * image.c (xpm_load_image) [HAVE_NS]:
123 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
124 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
125 Remove unused local.
126 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
127 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
128 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
129 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
130 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
131 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
132 Fix pointer signedness problem.
133 * xfaces.c (FRAME_X_FONT_TABLE):
134 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
135
929e7845
GM
1362012-07-07 Glenn Morris <rgm@gnu.org>
137
138 * lread.c (load_path_check): New function, split from init_lread.
139 (init_lread): Reorganize. Motivation:
140 If EMACSLOADPATH is set, check/warn about that rather than the
141 defaults, which we are not going to use. Hence we can remove
142 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
143 Don't warn if site-lisp directories are missing.
144 If not installed, start from a blank load-path, since
145 PATH_LOADSEARCH refers to the eventual installation directories.
146
58dd0aa4
EZ
1472012-07-07 Eli Zaretskii <eliz@gnu.org>
148
149 Support truncation and continuation glyphs on GUI frames, when
150 fringes are disabled. (Bug#11832)
151 * xdisp.c (init_iterator): Get dimensions of truncation and
152 continuation glyphs even if on GUI frames. Adjust
153 it->last_visible_x on GUI frames when the left or right fringes,
154 or both, are absent.
155 (start_display, move_it_in_display_line_to): Handle the case of a
156 GUI frame without a fringe to display continuation or truncation
157 glyphs.
158 (insert_left_trunc_glyphs): Support GUI frames: make sure
159 truncation glyphs overwrite enough glyphs from the current line to
160 have sufficient space in pixels.
161 (display_line): Support truncation and continuation glyphs on GUI
162 frames. If some spare pixels are left on the line after inserting
163 the truncation glyphs, fill that space with a stretch glyph of a
164 suitably computed width.
165
166 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
167 produce_glyphs, to support GUI sessions.
168
31571fd7
PE
1692012-07-07 Paul Eggert <eggert@cs.ucla.edu>
170
5a16b9bc
PE
171 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
172
f3047c75
PE
173 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
174
31571fd7
PE
175 Do not require float-time's arg to fit in time_t (Bug#11825).
176 This works better on hosts where time_t is unsigned, and where
177 float-time is applied to the (negative) difference between two times.
178 * editfns.c (decode_time_components): Last arg is now double *,
179 not int *, and means to store all the result as a double, without
180 worrying about whether the seconds part fits in time_t.
181 All callers changed.
182 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
183 All callers changed.
184 (Ffloat_time): Do not fail merely because the specified time falls
185 outside of time_t range.
186
4516fbef
GM
1872012-07-07 Glenn Morris <rgm@gnu.org>
188
189 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
190 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
191 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
192
07adc2c6
JB
1932012-07-07 Juanma Barranquero <lekktu@gmail.com>
194
195 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
196 Update dependencies.
197
198 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
199
fd573f31
PE
2002012-07-06 Paul Eggert <eggert@cs.ucla.edu>
201
fee5959d
PE
202 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
203 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
204 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
205 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
206 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
207 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
208
fd573f31
PE
209 * xfont.c (compare_font_names): Redo to omit the need for casts.
210
ddadbc0e
AS
2112012-07-06 Andreas Schwab <schwab@linux-m68k.org>
212
fca8d6b6
AS
213 * xfns.c (Fx_change_window_property): Doc fix.
214 * w32fns.c (Fx_change_window_property): Doc fix.
215
ddadbc0e
AS
216 * w32fns.c (Fx_window_property): Accept the same arguments as the
217 X Windows version. Doc fix.
218 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
219
f247498e
JB
2202012-07-06 Juanma Barranquero <lekktu@gmail.com>
221 Eli Zaretskii <eliz@gnu.org>
222
223 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
224 Windows-specific code from nt/config.nt moved here.
225 Obsolete settings removed.
226
216ee680
PE
2272012-07-06 Paul Eggert <eggert@cs.ucla.edu>
228
229 * process.c: Avoid unnecessary calls to gettime.
230 (wait_reading_process_output): Don't get the time of day
231 when gobbling data immediately and not waiting, as there's no need
232 for it in that case. This removes a FIXME.
233
bdd091e4
JD
2342012-07-06 Jan Djärv <jan.h.d@swipnet.se>
235
236 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
237 is defined (Bug#11768).
238
9d44f8ce
DA
2392012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
240
241 Fix marker debugging code.
242 * marker.c (byte_char_debug_check): Do not perform the check
243 if buffer is not multibyte.
090bd7cb
JB
244 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
245 Call byte_char_debug_check with correct arguments.
9d44f8ce 246
90fc4786
DA
2472012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
248
249 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
250 * marker.c (byte_char_debug_check, count_markers):
251 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
252 (byte_debug_flag): Remove.
253 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
254 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
255
7b7ae965
DA
2562012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
257
4e57b342
DA
258 Avoid code repetition in marker-related functions.
259 * marker.c (attach_marker): New function.
260 (Fset_marker, set_marker_restricted, set_marker_both)
261 (set_marker_restricted_both): Use it.
262 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
263 Consistently rename charno to charpos.
264 (marker_position): Add eassert.
265 (marker_byte_position): Convert to eassert.
266
2672012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
268
269 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 270 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 271 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 272
657924ff
DA
2732012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
274
275 Introduce fast path for the widely used marker operation.
276 * alloc.c (build_marker): New function.
277 * lisp.h (build_marker): New prototype.
278 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
279 * composite.c (autocmp_chars): Likewise.
280 * editfns.c (buildmark): Remove.
281 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
282 (save_restriction_save): Use build_marker.
283 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
284 * window.c (save_window_save): Likewise.
285
041a49a6
DA
2862012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
287
288 Do not use Fdelete_overlay in delete_all_overlays
289 to avoid redundant calls to unchain_overlay.
290 * buffer.c (drop_overlay): New function.
291 (delete_all_overlays, Fdelete_overlay): Use it.
292 * minibuf.c (get_minibuffer): Fix comment.
293
7dca65a4
PE
2942012-07-06 Paul Eggert <eggert@cs.ucla.edu>
295
296 Port to OpenBSD 5.1 amd64.
297 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
298 This is needed for OpenBSD, and should be harmless on all BSD systems.
299 Also, include <sys/sysctl.h>, as it should be available on all
300 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
301 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
302 use p_pid member, not kp_proc.pid.
303
8eb876e2
GM
3042012-07-06 Glenn Morris <rgm@gnu.org>
305
306 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
307
38182d90
PE
3082012-07-05 Paul Eggert <eggert@cs.ucla.edu>
309
310 More xmalloc and related cleanup.
311 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
312 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
313 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
314 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
315 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
316 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
317 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
318 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
319 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
320 * xterm.c:
321 Omit needless casts involving void * pointers and allocation.
322 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
323 as the former is more robust if P's type is changed.
324 Prefer xzalloc to xmalloc + memset 0.
325 Simplify malloc-or-realloc to realloc.
326 Don't worry about xmalloc returning a null pointer.
327 Prefer xstrdup to xmalloc + strcpy.
328 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
329 growing it.
330 * keyboard.c (apply_modifiers_uncached): Prefer local array to
331 alloca of a constant.
332
6dd5a677
EZ
3332012-07-05 Eli Zaretskii <eliz@gnu.org>
334
335 * xdisp.c (display_line): Fix horizontal pixel coordinates when
336 hscroll is larger than the line width. Fixes long and futile
337 looping inside extend_face_to_end_of_line (on a TTY) producing
338 glyphs that are not needed and thrown away.
339
6b312f0f
DA
3402012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
341
342 * marker.c (set_marker_restricted_both): Simplify by using
343 clip_to_bounds.
344
f520ef9b
PE
3452012-07-05 Paul Eggert <eggert@cs.ucla.edu>
346
347 * editfns.c (region_limit): Simplify by using clip_to_bounds.
348
383b7c95
JD
3492012-07-05 Jan Djärv <jan.h.d@swipnet.se>
350
351 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
352 not defined (Bug#11768).
353 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
354 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
355 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
356 followed by gtk_box_set_homogeneous (Bug#11768).
357 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
358 (update_theme_scrollbar_width, xg_create_scroll_bar):
359 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
360 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
361 (is_box_type): New function (Bug#11768).
362 (xg_tool_item_stale_p): Call is_box_type.
5293d758 363 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
364 with default display (Bug#11768).
365
d6e7bf45
EZ
3662012-07-05 Eli Zaretskii <eliz@gnu.org>
367
368 * xdisp.c (window_hscroll_limited): New function.
369 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
370 coordinates when window's hscroll is set to insanely large
371 values. (Bug#11857)
372
431391ec
JB
3732012-07-05 Juanma Barranquero <lekktu@gmail.com>
374
375 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
376 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
377
23f86fce
DA
3782012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
379
380 Cleanup xmalloc.
381 * lisp.h (xzalloc): New prototype. Omit needless casts.
382 * alloc.c (xzalloc): New function. Omit needless casts.
383 * charset.c: Omit needless casts. Convert all calls to
384 xmalloc with following memset to xzalloc.
385 * dispnew.c: Likewise.
386 * fringe.c: Likewise.
387 * image.c: Likewise.
388 * sound.c: Likewise.
389 * term.c: Likewise.
390 * w32fns.c: Likewise.
391 * w32font.c: Likewise.
392 * w32term.c: Likewise.
393 * xfaces.c: Likewise.
394 * xfns.c: Likewise.
395 * xterm.c: Likewise.
396 * atimer.c: Omit needless casts.
397 * buffer.c: Likewise.
398 * callproc.c: Likewise.
399 * ccl.c: Likewise.
400 * coding.c: Likewise.
401 * composite.c: Likewise.
402 * doc.c: Likewise.
403 * doprnt.c: Likewise.
404 * editfns.c: Likewise.
405 * emacs.c: Likewise.
406 * eval.c: Likewise.
407 * filelock.c: Likewise.
408 * fns.c: Likewise.
409 * gtkutil.c: Likewise.
410 * keyboard.c: Likewise.
411 * lisp.h: Likewise.
412 * lread.c: Likewise.
413 * minibuf.c: Likewise.
414 * msdos.c: Likewise.
415 * print.c: Likewise.
416 * process.c: Likewise.
417 * region-cache.c: Likewise.
418 * search.c: Likewise.
419 * sysdep.c: Likewise.
420 * termcap.c: Likewise.
421 * terminal.c: Likewise.
422 * tparam.c: Likewise.
423 * w16select.c: Likewise.
424 * w32.c: Likewise.
425 * w32reg.c: Likewise.
426 * w32select.c: Likewise.
427 * w32uniscribe.c: Likewise.
428 * widget.c: Likewise.
429 * xdisp.c: Likewise.
430 * xmenu.c: Likewise.
431 * xrdb.c: Likewise.
432 * xselect.c: Likewise.
433
0497dc44
PE
4342012-07-05 Paul Eggert <eggert@cs.ucla.edu>
435
436 * fileio.c (time_error_value): Check the right error number.
437 Problem reported by Troels Nielsen in
438 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
439
356e7178
PE
4402012-07-04 Paul Eggert <eggert@cs.ucla.edu>
441
4e71fd89
PE
442 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
443 This should be fixed in a better way; see Eli Zaretskii in
444 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
445 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
446
f0941253
PE
447 * fileio.c (time_error_value): Rename from special_mtime.
448 The old name's problems were noted by Eli Zaretskii in
449 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
450
065c9eb4
PE
451 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
452 This variable's comment says Emacs needs at least one GDB-visible
453 symbol of type enum pvec_type, to work around GDB problems.
454 The symbol's value doesn't matter.
455
356e7178
PE
456 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
457 that causes compilation to fail on pre-C99 compilers.
458
95f61aa2
JB
4592012-07-04 Juanma Barranquero <lekktu@gmail.com>
460
461 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
462 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
463
3884d954
DA
4642012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
465
d209e2fb 466 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
467 headers for buffer_defaults and buffer_local_symbols.
468 Reported by Juanma Barranquero <lekktu@gmail.com>.
469
ee28be33
SM
4702012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
471
472 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
473 * lisp.h (enum pvec_type): Use fewer bits.
474 (PSEUDOVECTOR_SIZE_BITS): New constant.
475 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
476 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
477 change in pvec_type.
478 (PSEUDOVECTOR_TYPEP): New macro.
479 (TYPED_PSEUDOVECTORP): Use it.
480 * fns.c (internal_equal): Adapt code to extract pvectype.
481 * emacs.c (gdb_pvec_type): Update type.
482 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
483 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
484 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
485 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
486 (sweep_vectors): Use it. Use local var `total_bytes' instead of
487 abusing vector->header.next.nbytes.
488 (live_vector_p): Use PVEC_TYPE.
489 (mark_object): Adapt code to extract pvectype. Use switch.
490
c7f2cd7f
PE
4912012-07-04 Paul Eggert <eggert@cs.ucla.edu>
492
493 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
494 Tighten new eassert a bit.
495
8ce70ed2
DA
4962012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
497
498 Fix compilation with --enable-gcc-warnings and -O1
499 optimization level.
500 * doprnt.c (doprnt): Change type of tem to int, initialize
501 to avoid compiler warning. Add eassert.
502 * search.c (simple_search): Initialize match_byte to avoid
503 compiler warning. Add eassert.
504
dea7f1e5
PE
5052012-07-04 Paul Eggert <eggert@cs.ucla.edu>
506
24a212eb
PE
507 Avoid weird behavior with large horizontal scrolls.
508 Without this change, for example, large hscroll values would
509 mess up Emacs's display on Fedora 15 x86, presumably due to
510 overflows in int calculations in the display code.
511 Also, if buffers had long lines, Emacs would freeze.
512 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
513 (set_window_hscroll): New function, containing the old guts of
514 Fset_window_hscroll. Return the clipped value.
515 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
516 This avoids the need to check against PTRDIFF_MAX.
517
dea7f1e5
PE
518 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
519
76046526
DA
5202012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
521
522 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
523
39adff0d
PE
5242012-07-04 Paul Eggert <eggert@cs.ucla.edu>
525
63807d47
PE
526 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
527 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
528 since GCC 4.4.6 issues a bogus warning for them.
529
39adff0d
PE
530 Fix bugs in file timestamp newness comparisons.
531 * fileio.c (Ffile_newer_than_file_p):
532 * lread.c (Fload): Use full timestamp resolution of files,
533 not just the 1-second resolution, so that files that are only
534 slightly newer still count as newer.
535 * fileio.c (Ffile_newer_than_file_p): Don't assume file
536 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
537
dbeed9a6
PE
5382012-07-03 Paul Eggert <eggert@cs.ucla.edu>
539
540 * fileio.c: Improve handling of file time marker. (Bug#11852)
541 (special_mtime): New function.
542 (Finsert_file_contents, Fverify_visited_file_modtime):
543 Use it to set special mtime values consistently.
544
636334d6
AS
5452012-07-03 Andreas Schwab <schwab@linux-m68k.org>
546
547 * fileio.c (Finsert_file_contents): Properly handle st_mtime
548 marker for non-existing file. (Bug#11852)
549
e2017fe2
GM
5502012-07-03 Glenn Morris <rgm@gnu.org>
551
552 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
553 and did not make it into globals.h).
554
404dbd37
TT
5552012-07-03 Tom Tromey <tromey@redhat.com>
556
557 * window.c (Fset_window_margins, Fset_window_fringes)
558 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
559 * textprop.c (Fprevious_property_change): No longer static.
560 * syntax.c (Fsyntax_table_p): No longer static.
561 * process.c (Fget_process, Fprocess_datagram_address): No longer
562 static.
563 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
564 * keyboard.c (Fcommand_execute): No longer static.
565 Remove EXFUN.
566 * insdel.c (Fcombine_after_change_execute): No longer static.
567 * image.c (Finit_image_library): No longer static.
568 * fileio.c (Fmake_symbolic_link): No longer static.
569 * eval.c (Ffetch_bytecode): No longer static.
570 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
571 * doc.c (Fdocumentation_property, Fsnarf_documentation):
572 No longer static.
404dbd37
TT
573 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
574 static.
575 * dired.c (Ffile_attributes): No longer static.
576 * composite.c (Fcomposition_get_gstring): No longer static.
577 * callproc.c (Fgetenv_internal): No longer static.
578
579 * ccl.h: Remove EXFUNs.
580 * buffer.h: Remove EXFUNs.
581 * dispextern.h: Remove EXFUNs.
582 * intervals.h: Remove EXFUNs.
583 * fontset.h: Remove EXFUN.
584 * font.h: Remove EXFUNs.
585 * dosfns.c (system_process_attributes): Remove EXFUN.
586 * keymap.h: Remove EXFUNs.
587 * lisp.h: Remove EXFUNs.
588 * w32term.h: Remove EXFUNs.
589 * window.h: Remove EXFUNs.
590 * xsettings.h: Remove EXFUN.
591 * xterm.h: Remove EXFUN.
592
8e4fd1e1
GM
5932012-07-03 Glenn Morris <rgm@gnu.org>
594
595 * lisp.h (Frandom): Make it visible to C.
596 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
597 buffer for invisible buffers. (Bug#1229)
598
ca95b3eb
DA
5992012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
600
601 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
602 values which aren't power of 2.
603 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
604 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
605 accordingly.
606
7555c33f
SM
6072012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
608
609 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
610
611 * alloc.c (mark_object): Revert part of last patch to use `switch'.
612
d12e8f5a
DA
6132012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
614
615 * alloc.c (allocate_vector_block): Remove redundant
616 calls to mallopt if DOUG_LEA_MALLOC is defined.
617 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
618 avoid calls to mallopt if zero_vector is returned.
619
296094c3
DA
6202012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
621
622 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
623 is enabled, avoid dereferencing NULL current_sblock if
624 running undumped.
625
36429c89
DA
6262012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
627
628 Cleanup basic buffer management.
629 * buffer.h (struct buffer): Change layout to use generic vector
630 marking code. Fix some comments. Change type of 'clip_changed'
631 to bitfield. Remove unused #ifndef old.
632 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
633 (GET_OVERLAYS_AT): Fix indentation.
634 (for_each_per_buffer_object_at): New macro.
635 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
636 (Fbuffer_local_variables): Use it.
637 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
638 * alloc.c (allocate_buffer): Adjust to match new layout of
639 struct buffer. Fix comment.
640 (mark_overlay): New function.
641 (mark_buffer): Use it. Use mark_vectorlike to mark normal
642 Lisp area of struct buffer.
643 (mark_object): Use it. Adjust marking of misc objects
644 and related comments.
645
3b3e4cac
PE
6462012-07-02 Paul Eggert <eggert@cs.ucla.edu>
647
648 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
649 wrapper that is not needed because the wrapped code is a no-op (zero
650 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
651 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
652
cf5c0175
DA
6532012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
654
655 * alloc.c (mark_buffer): Simplify. Remove prototype.
656 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 657 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
658 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
659 redundant calls to mark_vectorlike for bool vectors.
660
ca26824c
GM
6612012-06-30 Glenn Morris <rgm@gnu.org>
662
2e4c5312
GM
663 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
664
ca26824c
GM
665 * epaths.in (PATH_SITELOADSEARCH): New.
666 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
667 This is rather than relying on --enable-locallisppath elements
668 having "site-lisp" in their names. (Bug#10208#25, 11658)
669
0d23c240
EZ
6702012-06-30 Eli Zaretskii <eliz@gnu.org>
671
c9240d7a
EZ
672 * w32proc.c (sys_select): Accept and ignore one more argument.
673
674 * w32.c (emacs_gnutls_pull): Call select with one more argument.
675
0d23c240 676 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 677 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
678
679 * sysdep.c: Don't include dos.h and dosfns.h.
680
681 * process.c (sys_select):
682 * msdos.c (sys_select): Accept one more argument and ignore it.
683
684 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
685 adapt data types and code to that.
686
687 * dosfns.c:
688 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
689 which clashes with the gnulib function of the same name.
690
af5a5a98
AS
6912012-06-30 Andreas Schwab <schwab@linux-m68k.org>
692
c5e4379c
AS
693 * font.c (font_style_to_value, font_style_symbolic)
694 (font_prop_validate_style): Add type checks for values in
695 font_style_table.
696
af5a5a98
AS
697 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
698 argument.
699 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
700 uses.
701
8d38f461
EZ
7022012-06-29 Eli Zaretskii <eliz@gnu.org>
703
2e5a6631
EZ
704 * xdisp.c (try_window_id): Undo last change.
705
8d38f461
EZ
706 * w32.c (getwd): Adjust commentary about startup_dir.
707 (init_environment): Always call sys_access, even in non-MSVC
708 builds. Don't chdir to the directory of the Emacs executable.
709 This undoes code from 1997 which was justified by the need to
710 "avoid conflicts when removing and renaming directories". But its
711 downside was that every relative file name was being interpreted
712 relative to the directory of the Emacs executable, which can never
713 be TRT. In particular, it broke sys_access when called with
714 relative file names.
715 (sys_access): Map GetLastError to errno.
716
2af3565e
DA
7172012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
718
719 * window.h (struct window): Change type of 'fringes_outside_margins'
720 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 721 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
722 Adjust comment.
723 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
724 to ptrdiff_t.
725
c8d3a25c 7262012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 727
c8d3a25c
GM
728 * gnutls.c (emacs_gnutls_handshake):
729 Add QUIT to make the loop interruptible.
57570cd3 730
c8d3a25c 7312012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 732
c8d3a25c
GM
733 * charset.c (init_charset): Make lack of etc/charsets fatal.
734
3e984ee8
DA
7352012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
736
737 * editfns.c (region_limit): Fix type mismatch.
738
ef884f23
DA
7392012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
740
741 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
742 undefined. Convert from xassert to eassert.
743 * nsmenu.m: Convert from xassert to eassert.
744 * nsterm.m: Likewise.
745
7d7e0027
SM
7462012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
747
748 * editfns.c (region_limit): Clip to narrowing (bug#11770).
749
aa754e6a
PE
7502012-06-28 Paul Eggert <eggert@cs.ucla.edu>
751
752 Avoid integer overflow on scroll-left and scroll-right.
753 * window.c (HSCROLL_MAX): New macro.
754 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
755 overflow when requested scroll falls outside ptrdiff_t range.
756
80b00b08
DA
7572012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
758
759 * window.h (struct window): Change type of 'hscroll',
760 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
761 'last_modified' and 'last_overlay_modified' to EMACS_INT.
762 Adjust users accordingly.
763 * xdisp.c (try_cursor_movement): Replace type check with eassert.
764 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
765 from EMACS_INT to ptrdiff_t.
766 (make_window): Omit redundant initialization.
767
62b2bcf6
JB
7682012-06-28 Juanma Barranquero <lekktu@gmail.com>
769
770 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
771
45942c7d
DA
7722012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
773
774 * window.h (struct window): Change type of 'use_time' and
775 'sequence_number' from Lisp_Object to int.
776 * frame.c (make_frame): Adjust users accordingly.
777 * print.c (print_object): Likewise.
778 * window.c (select_window, Fwindow_use_time, make_parent_window)
779 (make_window): Likewise.
780
e509cfa6
DA
7812012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
782
783 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
784 enabled with --enable-checking=[all,glyphs] configure option.
785 Fix GLYPH_DEBUG usage assuming that it may be undefined,
786 adjust comments accordingly.
787 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
788 undefined, adjust comments accordingly.
789 * image.c: Likewise.
790 * scroll.c: Likewise.
791 * w32fns.c: Likewise.
792 * w32term.c: Likewise.
793 * xdisp.c: Likewise.
794 * xfaces.c: Likewise.
795 * xfns.c: Likewise.
796 * xterm.c: Likewise.
797
a54e2c05
DA
7982012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
799
800 Generalize run-time debugging checks.
801 * dispextern.h (XASSERTS): Remove.
802 * fontset.c (xassert): Remove.
803 Convert from xassert to eassert.
804 * alloc.c: Convert from xassert to eassert.
805 * bidi.c: Likewise.
806 * dispnew.c: Likewise.
807 * fns.c: Likewise.
808 * fringe.c: Likewise.
809 * ftfont.c: Likewise.
810 * gtkutil.c: Likewise.
811 * image.c: Likewise.
812 * keyboard.c: Likewise.
813 * menu.c: Likewise.
814 * process.c: Likewise.
815 * scroll.c: Likewise.
816 * sound.c: Likewise.
817 * term.c: Likewise.
818 * w32console.c: Likewise.
819 * w32fns.c: Likewise.
820 * w32term.c: Likewise.
821 * window.c: Likewise.
822 * xdisp.c: Likewise.
823 * xfaces.c: Likewise.
824 * xfns.c: Likewise.
825 * xselect.c: Likewise.
826 * xterm.c: Likewise.
827
1ec4b7b2
SM
8282012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
829
830 * fns.c (maybe_resize_hash_table): Output message when growing the
831 purify-hashtable.
832
2014308a
DA
8332012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
834
835 * alloc.c (allocate_string_data): Remove dead code.
836 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
837 avoid GCC warning about unused macro.
838
246155eb
DA
8392012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
840
841 * alloc.c (allocate_string): Omit intervals initialization.
842 * alloc.c (make_uninit_multibyte_string): Initialize intervals
843 as in make_pure_string and make_pure_c_string.
844
43184b7b
DA
8452012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
846
d209e2fb 847 * alloc.c (allocate_string): Fix last change.
43184b7b 848
3fe6dd74
DA
8492012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
850
d209e2fb 851 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
852 to memset, add explicit initialization where appropriate.
853
1ba6038a
GM
8542012-06-27 Glenn Morris <rgm@gnu.org>
855
856 * lisp.mk (lisp): Remove paths.elc.
857
c89926a5
CY
8582012-06-27 Chong Yidong <cyd@gnu.org>
859
860 * doc.c (Fsubstitute_command_keys): Fix punctuation.
861
ed6b3510
JW
8622012-06-26 John Wiegley <johnw@newartisans.com>
863
1ec4b7b2 864 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
865 on Mac OS X Lion: __mod_init_func and __mod_term_func.
866
ed6b3510
JW
867 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
868 when building with Clang.
869
8edd4a2b
SM
8702012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
871
872 * eval.c (Fapply): Allow calling it with a single argument.
873
f6f62d1b
EZ
8742012-06-26 Eli Zaretskii <eliz@gnu.org>
875
876 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
877 _stricmp and _strnicmp.
878 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
879
62efea5e
DA
8802012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
881
882 * alloc.c (allocate_window): Zero out non-Lisp part of newly
883 allocated window.
884 (allocate_process): Likewise for new process.
8edd4a2b 885 (allocate_terminal): Change to use offsetof.
62efea5e
DA
886 (allocate_frame): Likewise.
887 * frame.c (make_frame): Omit redundant initialization.
888 * window.c (make_parent_window): Use memset.
889 (make_window): Omit redundant initialization.
890 * process.c (make_process): Omit redundant initialization.
891 * terminal.c (create_terminal): Likewise.
892
42997f4d
DA
8932012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
894
895 * term.c (delete_tty): Remove redundant call to memset.
896
1130ecfc
DA
8972012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
898
899 * alloc.c: Remove build_string.
900 * lisp.h: Define build_string as static inline. This provides
901 a better opportunity to optimize away calls to strlen when the
902 function is called with compile-time constant argument.
903 * image.c (imagemagick_error): Convert to build_string.
904 * w32proc.c (sys_spawnve): Likewise.
905 * xterm.c (x_term_init): Likewise.
906
cf38a720
PE
9072012-06-26 Paul Eggert <eggert@cs.ucla.edu>
908
99027bdd
PE
909 Use sprintf return value instead of invoking strlen on result.
910 In the old days this wasn't portable, since some sprintf
911 implementations returned char *. But they died out years ago and
912 Emacs already assumes sprintf returns int.
913 Similarly for float_to_string.
914 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
915 * ccl.c (ccl_driver):
916 * character.c (string_escape_byte8):
917 * data.c (Fnumber_to_string):
918 * doprnt.c (doprnt):
919 * print.c (print_object):
920 * xdisp.c (message_dolog):
921 * xfns.c (syms_of_xfns):
922 Use sprintf or float_to_string result to avoid need to call strlen.
923 * data.c (Fnumber_to_string):
924 Use make_unibyte_string, since the string must be ASCII.
925 * lisp.h, print.c (float_to_string): Now returns int length.
926 * term.c (produce_glyphless_glyph):
927 Use sprintf result rather than recomputing it.
928
cf38a720
PE
929 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
930 * Makefile.in (ALL_CFLAGS):
931 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
932 * gmalloc.c, regex.c: Include <config.h> unconditionally.
933
3511c784
DA
9342012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
935
0a08eb21 936 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
937 strcasecmp if available.
938 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
939
fb7da12e
AS
9402012-06-25 Andreas Schwab <schwab@linux-m68k.org>
941
942 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
943 Avoid comma operator.
944 * menu.c (push_submenu_start, push_submenu_end)
945 (push_left_right_boundary, push_menu_pane): Likewise.
946 * msdos.c (dos_rawgetc): Likewise.
947
afa2ffd8
DA
9482012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
949
950 * xfns.c (xic_create_fontsetname): Remove redundant calls
951 to memset.
952
b3b4476b
PE
9532012-06-25 Paul Eggert <eggert@cs.ucla.edu>
954
4495ff38
PE
955 * gtkutil.c (get_utf8_string): Remove redundant assignment.
956 sprintf already null-terminates its output.
957
b3b4476b
PE
958 * xfns.c (x_window): Remove redundant cast.
959
b00876c9
DA
9602012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
961
962 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
963 `const char *' to `char *' to avoid compiler warning.
964
d188e26b
PE
9652012-06-24 Paul Eggert <eggert@cs.ucla.edu>
966
885d1d74
PE
967 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
968 instead of truncating it to 63 (admittedly a generous limit).
969
d188e26b
PE
970 * process.c: Fix spelling and caps in comments.
971
e2f560b1
DN
9722012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
973
e86db54b 974 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
975 * sysdep.c (setpgrp): Remove definition, not used in this file.
976
7583a3a1
JB
9772012-06-24 Juanma Barranquero <lekktu@gmail.com>
978
979 * makefile.w32-in: Update dependencies.
980
696056c2
EZ
9812012-06-24 Eli Zaretskii <eliz@gnu.org>
982
983 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
984 (SYSTIME_H): Add nt/inc/sys/time.h.
985
986 * systime.h [WINDOWSNT]: Include sys/time.h.
987
988 * s/ms-w32.h (struct timespec): Definition moved from
989 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
990
845ca893
PE
9912012-06-24 Paul Eggert <eggert@cs.ucla.edu>
992
993 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
994 * buffer.h (buffer_slot_type_mismatch):
995 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
996 * eval.c (unwind_to_catch):
997 * image.c (my_png_error, my_error_exit):
998 * keyboard.c (quit_throw_to_read_char, user_error)
999 (Fexit_recursive_edit, Fabort_recursive_edit):
1000 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1001 (wrong_type_argument, buffer_overflow, __executable_start)
1002 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1003 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1004 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1005 (fatal):
1006 (child_setup) [!DOS_NT]:
1007 * lread.c (end_of_file_error, invalid_syntax):
1008 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1009 * puresize.h (pure_write_error):
1010 * search.c (matcher_overflow):
1011 * sound.c (sound_perror, alsa_sound_perror):
1012 * sysdep.c, syssignal.h (croak):
1013 * term.c (maybe_fatal, vfatal):
1014 * textprop.c (text_read_only):
1015 * undo.c (user_error):
1016 * unexmacosx.c (unexec_error):
1017 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1018 Use _Noreturn rather than NO_RETURN.
1019 No need for separate decl merely because of _Noreturn.
1020 * sound.c (sound_warning, parse_sound):
1021 Remove unnecessary forward decls.
1022
f1dd8073
PE
10232012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1024
1025 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1026 * lisp.h (WAIT_READING_MAX): New macro.
1027 * dispnew.c (Fsleep_for, sit_for):
1028 * keyboard.c (kbd_buffer_get_event):
1029 * process.c (Faccept_process_output):
1030 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1031 This improves on the previous patch, which introduced a bug
1032 when time_t is unsigned and as wide as intmax_t.
1033 See <http://bugs.gnu.org/9000#51>.
1034
b82c1755
EZ
10352012-06-23 Eli Zaretskii <eliz@gnu.org>
1036
1037 * dispnew.c (sit_for, Fsleep_for):
1038 * keyboard.c (kbd_buffer_get_event):
1039 * process.c (Faccept_process_output): Avoid compiler warnings when
1040 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1041
ca300656
JB
10422012-06-23 Juanma Barranquero <lekktu@gmail.com>
1043
049ec95b
JB
1044 * makefile.w32-in: Update dependencies.
1045
ca300656
JB
1046 * w32.c (ltime): Add return type and declare static.
1047 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1048
db7b8d06
PE
10492012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1050
1051 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1052 Privately reported by Herbert J. Skuhra.
1053 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1054 All uses changed.
1055 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1056 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1057
0bd8297f
EZ
10582012-06-23 Eli Zaretskii <eliz@gnu.org>
1059
96512555
EZ
1060 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1061 last argument of make_unibyte_string.
1062
0bd8297f
EZ
1063 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1064 language ID in the event parameters.
1065
1066 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1067 event.code, not the obscure "character set ID".
1068
63def6b6
CY
10692012-06-23 Chong Yidong <cyd@gnu.org>
1070
1071 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1072
e8a02204
EZ
10732012-06-23 Eli Zaretskii <eliz@gnu.org>
1074
388cdec0
EZ
1075 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1076 * w32.c (fdutimens): New function.
1077
1078 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1079
1080 * s/ms-w32.h (pselect): Redirect to sys_select.
1081
1082 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1083
e8a02204
EZ
1084 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1085 in the logic of incrementing and decrementing the value of
1086 use_relocatable_buffers.
1087
d054f3fb
PE
10882012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1089
1090 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1091 Privately reported by Herbert J. Skuhra.
1092 [__FreeBSD__]: Remove "*/" typo after "#include".
1093 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1094 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1095 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1096 Don't assume EMACS_TIME and struct timeval are the same type.
1097
d35af63c
PE
10982012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1099
1100 Support higher-resolution time stamps (Bug#9000).
1101 The time stamps are only nanosecond-resolution at the C level,
1102 since that's the best that any real-world system supports now.
1103 But they are picosecond-resolution at the Lisp level, as that's
1104 easy, and leaves room for future OS improvements.
1105
1106 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1107 (LIBES): Use it.
1108
1109 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1110 Don't get current time unless it's needed.
1111
1112 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1113 now provides it if it's absent.
1114 (start_atimer): Port to higher-res time stamps.
1115 Check for time stamp overflow. Don't get current time more
1116 often than is needed.
1117
1118 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1119 Include systime.h, not time.h.
1120 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1121
1122 * dired.c: Include stat-time.h.
1123 (Ffile-attributes): File times now have higher resolution.
1124
1125 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1126 (struct image): Timestamp now has higher resolution.
1127
1128 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1129 has at least microseconds now. All uses removed.
1130 (update_frame, update_single_window, update_window, update_frame_1)
1131 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1132
1133 * editfns.c (time_overflow): Now extern.
1134 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1135 (float-time, Fformat_time_string, Fcurrent_time_string)
1136 (Fcurrent_time_zone): Accept and generate higher-resolution
1137 time stamps.
1138 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1139 (decode_time_components, lisp_seconds_argument): New functions.
1140 (make_time): Now static.
1141 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1142 Report an error if the time is invalid, rather than having the caller
1143 do that.
1144
1145 * fileio.c: Include <stat-time.h>
1146 (Fcopy_file): Copy higher-resolution time stamps.
1147 Prefer to set the time stamp via a file descriptor if that works.
1148 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1149 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1150 (Fvisited_file_modtime, Fset_visited_file_modtime):
1151 Support higher-resolution time stamps.
1152
1153 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1154
1155 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1156
1157 * image.c (prepare_image_for_display, clear_image_cache)
1158 (lookup_image): Port to higer-resolution time stamps.
1159
1160 * keyboard.c (start_polling, bind_polling_period):
1161 Check for time stamp overflow.
1162 (read_char, kbd_buffer_get_event, timer_start_idle)
1163 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1164 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1165 Port to higher-resolution time stamps. Do not assume time_t is signed.
1166 (decode_timer): New function. Timers are now vectors of length 9,
1167 not 8, to accommodate the picosecond component.
1168 (timer_check_2): Use it.
1169
1170 * nsterm.m (select_timeout, timeval_subtract): Remove.
1171 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1172 as they're a bit more accurate and handle overflow better.
1173 (ns_select): Change prototype to be compatible with pselect.
1174 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1175 * nsterm.h (ns_select): Adjust prototype.
1176
1177 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1178 us-resolution time stamps.
1179 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1180
1181 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1182
1183 * lisp.h (time_overflow): New decl.
1184 (wait_reading_process_output): First arg is now intmax_t, not int,
1185 to accommodate larger waits.
1186
1187 * process.h (struct Lisp_Process.read_output_delay):
1188 Now counts nanoseconds, not microseconds.
1189 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1190 EMACS_HAS_USECS.
1191 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1192 (wait_reading_process_output):
1193 Port to ns-resolution time stamps.
1194 (Faccept_process_output, wait_reading_process_output):
1195 Check for time stamp overflow. Do not assume time_t is signed.
1196 (select_wrapper): Remove; we now use pselect.
1197 (Fprocess_attributes): Now generates ns-resolution time stamps.
1198
1199 * sysdep.c: Include utimens.h. Don't include utime.h
1200 or worry about struct utimbuf; gnulib does that for us now.
1201 (gettimeofday): Remove; gnulib provides a substitute.
1202 (make_timeval): New function.
1203 (set_file_times): Now sets ns-resolution time stamps.
1204 New arg FD; all uses changed.
1205 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1206 (system_process_attributes):
1207 Now returns ns-resolution time stamp. All uses changed.
1208 Check for time stamp overflow.
1209
1210 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1211 provides a substitute now.
1212
1213 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1214 since it guarantees struct timespec.
1215 (EMACS_TIME): Now struct timespec, so that we can support
1216 ns-resolution time stamps.
1217 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1218 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1219 (EMACS_USECS): Remove.
1220 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1221 so multiply the arg by 1000 before storing it.
1222 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1223 New macros.
1224 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1225 Port to ns-resolution time stamps.
1226 (EMACS_TIME_NEG_P): Remove; replaced by....
1227 (EMACS_TIME_SIGN): New macro.
1228 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1229 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1230 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1231 (make_timeval, make_lisp_time, decode_time_components): New decls.
1232 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1233 that it mishandled time_t overflow. You can't compare by subtracting!
1234 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1235 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1236
1237 * term.c: Include <sys/time.h>.
1238 (timeval_to_Time): New function, for proper overflow wraparound.
1239 (term_mouse_position, term_mouse_click): Use it.
1240
1241 * undo.c (record_first_change): Support higher-resolution time stamps
1242 in the undo buffer.
1243 (Fprimitive_undo): Use them when restoring time stamps.
1244
1245 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1246 (w32_get_internal_run_time):
1247 Port to higher-resolution Emacs time stamps.
1248 (ltime): Now accepts single 64-bit integer, as that's more convenient
1249 for callers.
1250
1251 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1252
1253 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1254 for compatibility with pselect. Support ns-resolution time stamps.
1255
1256 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1257
1258 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1259 Check for time stamp overflow, and support ns-resolution time stamps.
1260
1261 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1262 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1263 (timeval_subtract): Remove; no longer needed.
1264 (XTflash, XTring_bell, x_wait_for_event):
1265 Port to ns-resolution time stamps. Don't assume time_t is signed.
1266
b6a92dfe
CY
12672012-06-22 Chong Yidong <cyd@gnu.org>
1268
1269 * xdisp.c (x_consider_frame_title): Revert last change.
1270
d251c37c
EZ
12712012-06-22 Eli Zaretskii <eliz@gnu.org>
1272
1273 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1274 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1275 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1276 staticidx goes up to 1597 out of 1600 = 0x640.)
1277
f10deafb
PE
12782012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1279
1280 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1281 Otherwise, the umask might be mistakenly 0 while handling input signals.
1282
ec6de1e2
SM
12832012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1284
1285 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1286
28be1ada
DA
12872012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1288
1289 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1290 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1291 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1292 access to `contents' member of Lisp_Vector objects with AREF and ASET
1293 where appropriate.
1294
c6bf3022
CY
12952012-06-19 Chong Yidong <cyd@gnu.org>
1296
1297 * frame.c (delete_frame): When selecting a frame on a different
1298 text terminal, do not alter the terminal's top-frame.
1299
1300 * xdisp.c (format_mode_line_unwind_data): Record the target
1301 frame's selected window and its terminal's top-frame.
1302 (unwind_format_mode_line): Restore them.
1303 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1304 Callers changed.
1305 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1306 since tty frames can be explicitly named.
1307 (prepare_menu_bars): Likewise.
1308
1309 * term.c (Ftty_top_frame): New function.
1310
defd4196
PE
13112012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1312
1313 Port byte-code-meter to modern targets.
1314 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1315 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1316 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1317 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1318 (METER_1, METER_2): Simplify.
1319
1053a871
SM
13202012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1321
1322 * data.c (Fdefalias): Return `symbol' (bug#11686).
1323
b7e8d081
MR
13242012-06-18 Martin Rudalics <rudalics@gmx.at>
1325
1326 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1327 gets killed during executing of this function (Bug#11665).
1328 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1329 (Vkill_buffer_query_functions): In doc-string say that functions
1330 run by this hook should not change the current buffer.
1331
7ea2b339
PE
13322012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1333
1334 Fix recently-introduced process.c problems found by static checking.
1335 * process.c (write_queue_push, write_queue_pop, send_process):
1336 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1337 (write_queue_pop): Fix pointer signedness problem.
1338 (send_process): Remove unused local.
1339
96a313a1
CY
13402012-06-17 Chong Yidong <cyd@gnu.org>
1341
1342 * xdisp.c (redisplay_internal): No need to redisplay terminal
1343 frames that are not on top.
1344
20ca2e94
TN
13452012-06-17 Troels Nielsen <bn.troels@gmail.com>
1346
1347 * process.c (make_process): Initialize write_queue.
1348 (write_queue_push, write_queue_pop): New functions.
1349 (send_process): Use them to maintain correct ordering of process
1350 writes (Bug#10815).
1351
9a900ca9
PE
13522012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1353
310fbfa8
PE
1354 * lisp.h (eassert): Assume C89 or later.
1355 This removes the need for CHECK.
1356 (CHECK): Remove. Its comments about always evaluating its
1357 argument were confusing, as 'eassert' typically does not evaluate
1358 its argument.
1359
27bb1ca4
PE
1360 * coding.c (produce_chars): Use ptrdiff_t, not int.
1361
9a900ca9
PE
1362 * xterm.c (x_draw_underwave): Check for integer overflow.
1363 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1364
41b7f8bc 13652012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1366
1367 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1368 referenced (Bug#11583).
1369
9b0e3eba
AA
13702012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1371
1372 Implement wave-style variant of underlining.
1373 * dispextern.h (face_underline_type): New enum.
1374 (face): Add field for underline type.
1375 * nsterm.m (ns_draw_underwave): New function.
1376 (ns_draw_text_decoration): Use it.
1377 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1378 New functions.
1379 (x_draw_glyph_string): Use them.
1380 * xfaces.c (Qline, Qwave): New Lisp objects.
1381 (check_lface_attrs, merge_face_ref)
1053a871
SM
1382 (Finternal_set_lisp_face_attribute, realize_x_face):
1383 Handle wave-style underline face attributes.
9b0e3eba
AA
1384 * xterm.c (x_draw_underwave): New function.
1385 (x_draw_glyph_string): Use it.
1386
0fb52f11
JB
13872012-06-16 Juanma Barranquero <lekktu@gmail.com>
1388
1389 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1390 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1391 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1392 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1393 ($(BLD)/w32select.$(O)): Update dependencies.
1394
e5560ff7
AS
13952012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1396
1397 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1398 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1399 * character.c (_fetch_multibyte_char_p): Remove.
1400 * alloc.c: Include "character.h" before "buffer.h".
1401 * bidi.c: Likewise.
1402 * buffer.c: Likewise.
1403 * bytecode.c: Likewise.
1404 * callint.c: Likewise.
1405 * callproc.c: Likewise.
1406 * casefiddle.c: Likewise.
1407 * casetab.c: Likewise.
1408 * category.c: Likewise.
1409 * cmds.c: Likewise.
1410 * coding.c: Likewise.
1411 * composite.c: Likewise.
1412 * dired.c: Likewise.
1413 * dispnew.c: Likewise.
1414 * doc.c: Likewise.
1415 * dosfns.c: Likewise.
1416 * editfns.c: Likewise.
1417 * emacs.c: Likewise.
1418 * fileio.c: Likewise.
1419 * filelock.c: Likewise.
1420 * font.c: Likewise.
1421 * fontset.c: Likewise.
1422 * fringe.c: Likewise.
1423 * indent.c: Likewise.
1424 * insdel.c: Likewise.
1425 * intervals.c: Likewise.
1426 * keyboard.c: Likewise.
1427 * keymap.c: Likewise.
1428 * lread.c: Likewise.
1429 * macros.c: Likewise.
1430 * marker.c: Likewise.
1431 * minibuf.c: Likewise.
1432 * nsfns.m: Likewise.
1433 * nsmenu.m: Likewise.
1434 * print.c: Likewise.
1435 * process.c: Likewise.
1436 * regex.c: Likewise.
1437 * region-cache.c: Likewise.
1438 * search.c: Likewise.
1439 * syntax.c: Likewise.
1440 * term.c: Likewise.
1441 * textprop.c: Likewise.
1442 * undo.c: Likewise.
1443 * unexsol.c: Likewise.
1444 * w16select.c: Likewise.
1445 * w32fns.c: Likewise.
1446 * w32menu.c: Likewise.
1447 * window.c: Likewise.
1448 * xdisp.c: Likewise.
1449 * xfns.c: Likewise.
1450 * xmenu.c: Likewise.
1451 * xml.c: Likewise.
1452 * xselect.c: Likewise.
1453
2f07e6af
EZ
14542012-06-16 Eli Zaretskii <eliz@gnu.org>
1455
1053a871
SM
1456 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1457 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1458 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1459 row.
1460 (handle_face_prop): Use chunk-relative overlay string index when
1461 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1462 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1463 the rightmost. (Bug#11720)
2f07e6af 1464
29b83cec
AS
14652012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1466
1467 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1468 (CATEGORY_MEMBER): Enforce 1/0 value.
1469 * category.c (_temp_category_set): Remove.
1470
4c5501e9
EZ
14712012-06-16 Eli Zaretskii <eliz@gnu.org>
1472
1473 * window.c (Fdelete_other_windows_internal)
1474 (Fdelete_window_internal): Don't access frame's mouse highlight
1475 info of the initial frame. (Bug#11677)
1476
2b570124
PE
14772012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1478
e93864f9
PE
1479 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1480 Assume USE_2_TAGS_FOR_INTS.
1481 (xreload): Adjust $tagmask width to match recent lisp.h change.
1482
2b570124
PE
1483 Simplify lisp.h in minor ways that should not affect code.
1484 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1485 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1486 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1487 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1488 (INTTYPEBITS): New macro, for clarity.
1489 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1490 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1491 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1492 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1493 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1494
81755f69
JB
14952012-06-13 Juanma Barranquero <lekktu@gmail.com>
1496
1497 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1498
16192a57
GM
14992012-06-13 Glenn Morris <rgm@gnu.org>
1500
1501 * s/bsd-common.h (BSD4_3):
1502 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1503
646b5f55
AS
15042012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1505
1506 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1507 instead of union.
1508 (XLI, XIL): Define.
1053a871
SM
1509 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1510 Use them.
1511 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1512 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1513 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1514 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1515 * frame.c (delete_frame): Remove outdated comment.
1516 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1517 USE_LISP_UNION_TYPE.
1518 (Fw32_unregister_hot_key): Likewise.
1519 (Fw32_toggle_lock_key): Likewise.
1520 * w32menu.c (add_menu_item): Likewise.
1521 (w32_menu_display_help): Use XIL instead of checking
1522 USE_LISP_UNION_TYPE.
1523 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1524 (init_heap): Likewise.
1525 * w32term.c (w32_read_socket): Update comment.
1526
1d3823c9
GM
15272012-06-13 Glenn Morris <rgm@gnu.org>
1528
c62ff706
GM
1529 * s/usg5-4-common.h, src/s/unixware.h:
1530 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1531
1d3823c9
GM
1532 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1533
bfe3e0a2
PE
15342012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1535
1536 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1537 * alloc.c (make_number) [!defined make_number]:
1538 Remove, as lisp.h always defines this now.
1539 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1540 (roundup_size): Verify that it is a power of 2.
1541 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1542 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1543 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1544 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1545 USE_LSB_TAG now is always defined to be either 0 or 1.
1546 All uses changed.
1547 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1548 code works fine either way, and efficiency is not a concern here,
1549 as the union type is for debugging, not for production.
1550 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1551 Use an inline function on all platforms when using the union type,
1552 since this is simpler and 'static inline' can be used portably
1553 within Emacs now.
1554 (LISP_INITIALLY_ZERO): New macro.
1555 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1556 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1557
45fa9c0f
GM
15582012-06-12 Glenn Morris <rgm@gnu.org>
1559
b4492cba
GM
1560 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1561
1562 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1563
45fa9c0f
GM
1564 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1565 Move BROKEN_SIGIO to configure.
1566
1567 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1568 Move NO_TERMIO to configure.
1569
0e25d334
CY
15702012-06-12 Chong Yidong <cyd@gnu.org>
1571
1572 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1573 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1574 MagickExportImagePixels is undefined.
1575
43682bb6
PE
15762012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1577
1578 * image.c (imagemagick_load_image): Remove unused label.
1579
a9be7d2b
GM
15802012-06-11 Glenn Morris <rgm@gnu.org>
1581
1582 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1583 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1584 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1585 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1586
3017f87f
SM
15872012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1588
1589 * alloc.c (make_byte_code): New function.
1590 (Fmake_byte_code): Use it. Don't purify here.
1591 * lread.c (read1): Use it as well to avoid extra allocation.
1592
1b9b4cf4
CY
15932012-06-11 Chong Yidong <cyd@gnu.org>
1594
1595 * image.c (imagemagick_load_image): Implement transparency.
1596
95988fcf
AS
15972012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1598
1599 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1600 account for preceding backslashes. (Bug#11663)
1601
cd4eb164
CY
16022012-06-09 Chong Yidong <cyd@gnu.org>
1603
1604 * term.c: Support italics in capable terminals (Bug#9652).
1605 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1606 (turn_on_face): Output using TS_enter_italic_mode if available.
1607 Don't handle unused blinking and alt-charset cases.
1608 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1609 and tty_alt_charset_p cases.
1610 (tty_capable_p, init_tty): Support italics.
1611
1612 * termchar.h (struct tty_display_info): Add field for italics.
1613 Remove unused blink field.
1614
1615 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1616 Handle slant.
1617
1618 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1619 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1620 tty_alt_charset_p. Add tty_italic_p.
1621
ff88beb8
MA
16222012-06-09 Michael Albinus <michael.albinus@gmx.de>
1623
1624 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1625 dbus_type_is_basic if available.
1626 (xd_extract_signed, xd_extract_unsigned): Rename from
1627 extract_signed and extract_unsigned, respectively. Adapt callers.
1628
44286096
CY
16292012-06-09 Chong Yidong <cyd@gnu.org>
1630
1682701f
CY
1631 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1632
44286096
CY
1633 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1634 case (Bug#9752).
1635
d86feb17
PE
16362012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1637
1638 * xdisp.c (vmessage): Treat frame message as multibyte.
1639 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1640 would generate the diagnostic "Making \302\247 buffer-local while
1641 let-bound!".
1642
d5c20fe8
EZ
16432012-06-08 Eli Zaretskii <eliz@gnu.org>
1644
1645 * dispnew.c (showing_window_margins_p): Undo last change, which
1646 was done due to an inadvertent commit.
1647 (adjust_frame_glyphs_for_frame_redisplay): Do call
1648 showing_window_margins_p.
1649
513749ee
SM
16502012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1651
1652 * eval.c (Fmake_var_non_special): New primitive.
1653 (syms_of_eval): Defsubr it.
1654 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1655
d4a8f5c1
JB
16562012-06-08 Juanma Barranquero <lekktu@gmail.com>
1657
1658 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1659 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1660
8bbbc977
EZ
16612012-06-08 Eli Zaretskii <eliz@gnu.org>
1662
1663 * alloc.c (allocate_vectorlike): Fix last change.
1664
f3372c87
DA
16652012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1666
1667 Block-based vector allocation of small vectors.
1668 * lisp.h (struct vectorlike_header): New field `nbytes',
1669 adjust comment accordingly.
1670 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1671 to denote vector blocks. Adjust users (live_vector_p,
1672 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1673 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1674 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1675 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1676 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1677 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1678 (roundup_size): New constant.
1679 (struct vector_block): New data type.
1680 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1681 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1682 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1683 (sweep_vectors): New functions.
1684 (allocate_vectorlike): Return `zero_vector' as the only vector of
1685 0 items. Allocate new vector from block if vector size is less than
1686 or equal to VBLOCK_BYTES_MAX.
1687 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1688 (init_alloc_once): Add call to init_vectors.
1689
4f18a4ed
SM
16902012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1691
1692 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1693
86f158bc
PE
16942012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1695
1696 * doprnt.c (doprnt): Truncate multibyte char correctly.
1697 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1698 would mishandle a string argument "Xc" if X was a multibyte
1699 character of length 2: it would truncate after X's first byte
1700 rather than including all of X.
1701
c5cfcbe0
CY
17022012-06-06 Chong Yidong <cyd@gnu.org>
1703
1704 * buffer.c (word_wrap): Doc fix.
1705
c05cf390
PE
17062012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1707
1708 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1709
0c3461de
GM
17102012-06-03 Glenn Morris <rgm@gnu.org>
1711
1712 * xdisp.c (tool-bar-style): Doc fix.
1713
c71232db
UM
17142012-06-03 Ulrich Müller <ulm@gentoo.org>
1715
1716 * Makefile.in (PAXCTL): Define.
1717 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1718 binary via PaX flags if the paxctl utility is available.
1719 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1720 Restore PaX flags to their default. (Bug#11398)
1721
383f7350
CY
17222012-06-03 Chong Yidong <cyd@gnu.org>
1723
1724 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1725 buffer (Bug#11226).
1726
5f2c76c6
CY
17272012-06-03 Chong Yidong <cyd@gnu.org>
1728
1729 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1730 (note_mode_line_or_margin_highlight): If there is no help echo,
1731 use mode-line-default-help-echo. Handle the case where the mouse
1732 position is past the end of the mode line string.
1733
1734 * buffer.c (buffer_local_value_1): New function, split from
1735 Fbuffer_local_value; can return Qunbound.
1736 (Fbuffer_local_value): Use it.
1737 (Vmode_line_format): Docstring tweaks.
1738
773d47f6
PE
17392012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1740
1741 * sysdep.c (system_process_attributes): Improve comment.
1742
f2d6a3df
SM
17432012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1744
1745 * keyboard.c: Export real-this-command to Elisp.
1746 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1747 and DEFVAR it. Update all users.
1748
63810350
PE
17492012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1750
7bd5c1f4
PE
1751 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1752
63810350
PE
1753 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1754 Convert pctcpu and pctmem to Lisp float properly.
1755 Let the compiler fold better, as 100.0/0x8000 is exact.
1756
a2821611
AS
17572012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1758
1759 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1760 cons_block.
1761
5fceba1d
PE
17622012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1763
1764 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1765
c98ff5dd
DA
17662012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1767
1768 For a 'struct window', replace some Lisp_Object fields to
1769 bitfields where appropriate, remove unused fields.
1770 * window.h (struct window): Remove unused 'last_mark_x' and
1771 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1772 change it's type from Lisp_Object to bitfield.
1773 Change type of 'force_start', 'optional_new_start',
1774 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1775 fields from Lisp_Object to bitfield. Adjust users accordingly.
1776
ca34e0be
PE
17772012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1778
1779 Pacify gcc -Wdouble-precision when using Xaw.
1780 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1781 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1782 Use 'float' consistently, rather than 'float' in most places
1783 and 'double' in a couple of places.
1784
efc00ab1 17852012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1786
1787 * xdisp.c (handle_stop): Detect whether we have overlay strings
1788 loaded by testing it->current.overlay_string_index to be
1789 non-negative, instead of checking whether n_overlay_strings is
1790 positive. (Bug#11587)
1791
efc00ab1 17922012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1793
1794 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1795
1796 * doc.c (Fsubstitute_command_keys): Doc fix.
1797
efc00ab1 17982012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1799
1800 * search.c (search_buffer): Remove calls to
1801 r_alloc_inhibit_buffer_relocation, as it is now called by
1802 maybe_unify_char, which was the cause of relocation of buffer text
1803 in bug#11519.
1804
efc00ab1 18052012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1806
1807 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1808 for the duration of call to load_charset, to avoid problems with
1809 callers of maybe_unify_char that access buffer text through C
1810 pointers.
1811
1812 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1813 decrement the inhibition flag, instead of just setting or
1814 resetting it.
1815
ba93a187
PE
18162012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1817
1818 Remove obsolete '#define static' cruft.
1819 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1820 This #undef was "temporary" in 2000; it is no longer needed
1821 now that '#define static' has gone away.
1822 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1823 (gray_bitmap_bits): Remove; no longer needed.
1824 All uses replaced with definiens.
1825 * xterm.c: Include "bitmaps/gray.xbm".
1826
9e4bf381
PE
18272012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1828
1829 Clean up __executable_start, monstartup when --enable-profiling.
1830 The following changes affect the code only when profiling.
1831 * dispnew.c (__executable_start): Rename from safe_bcopy.
1832 Define only on platforms that need it.
1833 * emacs.c: Include <sys/gmon.h> when profiling.
1834 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1835 (__executable_start): Remove decl, since lisp.h does it now.
1836 (safe_bcopy): Remove decl; no longer has that name.
1837 (main): Coalesce #if into single bit of code, for simplicity.
1838 Cast pointers to uintptr_t, since standard libraries want integers
1839 and not pointers.
1840 * lisp.h (__executable_start): New decl.
1841
32d72c2f
GM
18422012-05-31 Glenn Morris <rgm@gnu.org>
1843
1844 * image.c (Fimagemagick_types): Doc fix.
1845
baac5bc7
JM
18462012-05-30 Jim Meyering <meyering@redhat.com>
1847
1848 * callproc.c (Fcall_process_region): Include directory component
1849 in mkstemp error message (Bug#11586).
1850
72cb32cf
PE
18512012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1852
1853 * alloc.c, lisp.h (make_pure_vector): Now static.
1854
61b108cc
SM
18552012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1856
1857 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1858 Move to byte-run.el.
1859 (Fautoload): Do the hash-doc more carefully.
1860 * data.c (Fdefalias): Purify definition, except for keymaps.
1861 (Qdefun): Move from eval.c.
1862 * lisp.h (Qdefun): Remove.
1863 * lread.c (read1): Tiny simplification.
1864
471fe23d
TN
18652012-05-29 Troels Nielsen <bn.troels@gmail.com>
1866
934f3f58 1867 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1868 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1869 Bug#9642, but explicitly check that the buffer the overlay would
1870 be moved to is live and rearrange lines to make sure that errors
1871 will not put the overlay in an inconsistent state.
1872 (Fdelete_overlay): Cosmetics.
1873
85d0efd1
EZ
18742012-05-28 Eli Zaretskii <eliz@gnu.org>
1875
1876 * w32term.c (my_bring_window_to_top): New function.
1877 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1878 could be different from the original one.
1879 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1880 (Bug#11513)
1881
1882 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1883 by calling BringWindowToTop.
1884
1885 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1886 (WM_EMACS_END): Increase by one.
1887
da92a98c
PE
18882012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1889
1890 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1891 This avoids undefined behavior that might cause the eassert
1892 to not catch an out-of-range value.
1893
74d1f848
JB
18942012-05-28 Juanma Barranquero <lekktu@gmail.com>
1895
1896 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1897 Update dependencies.
1898
9e1a06fc
EZ
18992012-05-27 Eli Zaretskii <eliz@gnu.org>
1900
1901 * bidi.c (bidi_mirror_char): Fix last change.
1902
f3dd7312
AS
19032012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1904
1905 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1906 when referring to sectname field in printf format.
1907
81899c91
PE
19082012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1909
57b81a9f
PE
1910 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1911 Only r_alloc_inhibit_buffer_relocation needed to be added;
1912 the others were already declared.
1913
81899c91
PE
1914 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1915 before checking whether it's out of range. Put the check inside
1916 eassert. See
1917 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1918
33017faf 19192012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1920
1921 * callproc.c (Fcall_process): Restore a line that was accidentally
1922 commented out in the 2011-02-13 change (bug#11547).
1923
33017faf 19242012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1925
1926 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1927 defined on ralloc.c.
1928
1929 * buffer.c [REL_ALLOC]: Remove prototypes of
1930 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1931 they are now on lisp.h.
1932
1933 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1934
1935 * search.c (search_buffer): Use it to inhibit relocation of buffer
1936 text while re_search_2 is doing its job, because re_search_2 is
1937 passed C pointers to buffer text. (Bug#11519)
1938
23415acf
EZ
1939 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1940 Update value to 24.
1941
44e27368
EZ
1942 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1943 state after an additional call to move_it_in_display_line_to, keep
1944 the values of it->max_ascent and it->max_descent found for the
1945 entire line.
1946 (pos_visible_p): Revert the comparison against bottom_y to what it
1947 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1948 (Bug#11464)
1949
c1892f11
PE
19502012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1951
1952 Fix coding-related core dumps with gcc -ftrapv.
1953 The code was computing A - B, where A and B are pointers, and B is
1954 random garbage. This can lead to core dumps on platforms that
1955 have special pointer registers, and it also leads to core dumps on
1956 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1957 A - B only when B is initialized properly.
1958 * coding.c (coding_set_source, coding_set_destination): Return void.
1959 (coding_change_source, coding_change_destinations): New functions,
1960 with the old behaviors of coding_set_source and coding_set_destination.
1961 All callers that need an offset changed to use these new functions.
1962
eb7afdad
GM
19632012-05-26 Glenn Morris <rgm@gnu.org>
1964
1965 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1966
f12fdf02
EZ
19672012-05-26 Eli Zaretskii <eliz@gnu.org>
1968
53a63be6 1969 Extend mouse support on W32 text-mode console.
61b108cc
SM
1970 * xdisp.c (draw_row_with_mouse_face):
1971 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1972
eb3f6f01 1973 * w32console.c: Include window.h.
61b108cc
SM
1974 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1975 New functions.
eb3f6f01
EZ
1976 (initialize_w32_display): Initialize mouse-highlight data.
1977
53a63be6
EZ
1978 * w32inevt.c: Include termchar.h and window.h.
1979 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1980 moves, call note_mouse_highlight. If help_echo changed, call
1981 gen_help_event to produce help-echo message in the echo area.
1982 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1983 highlight info.
1984
4cfd81f6
PE
19852012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1986
1987 * lread.c (read1): Simplify slightly to avoid an overflow warning
1988 with GCC 4.7.0 on x86-64.
1989
4446092a
EZ
19902012-05-26 Eli Zaretskii <eliz@gnu.org>
1991
1992 * bidi.c (bidi_mirror_char): Revert last change: an int is
1993 definitely wide enough here.
1994
42b2a986 19952012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1996
42b2a986 1997 Fix integer width and related bugs (Bug#9874).
eb106a49 1998 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1999 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2000 (string_bytes, check_sblock, allocate_string_data):
2001 (compact_small_strings, Fmake_bool_vector, make_string)
2002 (make_unibyte_string, make_multibyte_string)
2003 (make_string_from_bytes, make_specified_string)
2004 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2005 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2006 (mark_vectorlike):
2007 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2008 (allocate_pseudovector):
2009 Use int, not EMACS_INT, where int is wide enough.
2010 (inhibit_garbage_collection, Fgarbage_collect):
2011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2012 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2013 int might not be wide enough.
2014 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2015 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2016 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2017 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2018 (bidi_level_of_next_char, bidi_move_to_visually_next):
2019 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2020 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2021 (Fkill_buffer, Fset_buffer_major_mode)
2022 (advance_to_char_boundary, Fbuffer_swap_text)
2023 (Fset_buffer_multibyte, overlays_at, overlays_in)
2024 (overlay_touches_p, struct sortvec, record_overlay_string)
2025 (overlay_strings, recenter_overlay_lists)
2026 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2027 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2028 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2029 (Foverlay_recenter, last_overlay_modification_hooks_used)
2030 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2031 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2032 (validate_region): Omit unnecessary test for b <= e,
2033 since that's guaranteed by the previous test.
d311d28c
PE
2034 (adjust_overlays_for_delete): Avoid pos + length overflow.
2035 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2036 (report_overlay_modification):
2037 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2038 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2039 Omit pointer cast, which isn't needed anyway, and doesn't work
2040 after the EMACS_INT -> ptrdiff_t change.
02481186 2041 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2042 * buffer.h: Adjust decls to match defn changes elsewhere.
2043 (struct buffer_text, struct buffer):
2044 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2045 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2046 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2047 not int, to avoid needless 32-bit limit on 64-bit hosts.
2048 (exec_byte_code): Use tighter memory-full test, one that checks
2049 for alloca overflow. Don't compute the address of the object just
2050 before an array, as that's not portable. Use EMACS_INT, not
2051 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2052 * callint.c (Fcall_interactively):
2053 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2054 * callproc.c (call_process_kill, Fcall_process):
2055 Don't assume pid_t fits into an Emacs fixnum.
2056 (call_process_cleanup, Fcall_process, child_setup):
2057 Don't assume pid_t fits into int.
2058 (call_process_cleanup, Fcall_process, delete_temp_file)
2059 (Fcall_process_region):
2060 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2061 (Fcall_process): Simplify handling of volatile integers.
2062 Use int, not EMACS_INT, where int will do.
2063 * casefiddle.c (casify_object, casify_region, operate_on_word)
2064 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2065 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2066 (casify_object): Avoid integer overflow when overallocating buffer.
2067 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2068 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2069 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2070 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2071 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2072 integers are now checked earlier. All uses replaced with XINT.
2073 (ccl_driver):
2074 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2075 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2076 (ccl_driver, Fregister_code_conversion_map):
2077 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2078 (resolve_symbol_ccl_program): Check that vector header is in range.
2079 Always copy the vector, so that we can check its contents reliably
2080 now rather than having to recheck each instruction as it's being
2081 executed. Check that vector words fit in 'int'.
2082 (ccl_get_compiled_code, Fregister_ccl_program)
2083 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2084 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2085 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2086 contents are in range.
2087 (Fccl_execute_on_string): Check that status is in range.
2088 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2089 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2090 Accept and return EMACS_INT, not int, because callers can pass values
2091 out of 'int' range.
2092 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2093 (multibyte_chars_in_text, parse_str_as_multibyte)
2094 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2095 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2096 (string_escape_byte8, Fget_byte):
2097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2098 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2099 avoid mishandling large integers.
2100 * character.h: Adjust decls to match defn changes elsewhere.
2101 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2102 (Ffind_charset_region):
2103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2104 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2105 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2106 Don't assume fixnum fits in int.
d311d28c
PE
2107 (load_charset_map_from_vector, Fmap_charset_chars):
2108 Remove now-unnecessary CHECK_NATNUMs.
2109 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2110 Don't rely on undefined behavior with signed left shift overflow.
2111 Don't assume unsigned int fits into fixnum, or that fixnum fits
2112 into unsigned int. Don't require max_code to be a valid fixnum;
2113 that's not true for gb10830 4-byte on a 32-bit host. Allow
2114 invalid_code to be a cons, for the same reason. Require code_offset
2115 to be a character. Avoid int overflow if max_char is close
2116 to INT_MAX.
2117 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2118 this is intended anyway and avoids some undefined behavior.
2119 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2120 INDEX_TO_CODE_POINT, as that's what it expects.
2121 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2122 * charset.h (DECODE_CHAR): Return int, not unsigned;
2123 this is what was intended anyway, and it avoids undefined behavior.
2124 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2125 integer-overflow issues.
2126 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2127 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2128 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2129 * chartab.c (Fmake_char_table, Fset_char_table_range)
2130 (uniprop_get_decoder, uniprop_get_encoder):
2131 Don't assume fixnum fits in int.
2132 * cmds.c (move_point): New function, that does the gist of
2133 Fforward_char and Fbackward_char, but does so while checking
2134 for integer overflow more accurately.
c96e5d6a 2135 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2136 (Fforward_line, Fend_of_line, internal_self_insert)
2137 (internal_self_insert):
2138 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2139 Fix a FIXME, by checking for integer overflow when calculating
2140 target_clm and actual_clm.
2141 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2142 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2143 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2144 (coding_alloc_by_making_gap, alloc_destination)
2145 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2146 (encode_coding_utf_16, detect_coding_emacs_mule)
2147 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2148 (detect_coding_iso_2022, decode_coding_iso_2022)
2149 (encode_invocation_designation, encode_designation_at_bol)
2150 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2151 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2152 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2153 (encode_coding_ccl, encode_coding_raw_text)
2154 (detect_coding_charset, decode_coding_charset)
2155 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2156 (produce_composition, produce_charset, produce_annotation)
2157 (decode_coding, handle_composition_annotation)
2158 (handle_charset_annotation, consume_chars, decode_coding_gap)
2159 (decode_coding_object, encode_coding_object, detect_coding_system)
2160 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2161 (code_convert_region, code_convert_string)
8f50130c
PE
2162 (Fdefine_coding_system_internal)
2163 (coding_set_source, coding_set_destination):
d311d28c
PE
2164 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2165 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2166 (Fdefine_coding_system_internal):
2167 Don't assume fixnums fit in int.
2168 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2169 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2170 (Funencodable_char_position, Fcheck_coding_systems_region)
2171 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2173 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2174 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2175 Don't access memory outside of the args array.
d311d28c 2176 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2177 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2178 result of ENCODE_CHAR.
d311d28c
PE
2179 * coding.h: Adjust decls to match defn changes elsewhere.
2180 (struct coding_system):
2181 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2182 * composite.c (get_composition_id, find_composition)
2183 (run_composition_function, update_compositions)
2184 (compose_text, composition_gstring_put_cache)
2185 (composition_gstring_p, composition_gstring_width)
2186 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2187 (composition_compute_stop_pos, composition_reseat_it)
2188 (composition_update_it, struct position_record)
2189 (find_automatic_composition, composition_adjust_point)
2190 (Fcomposition_get_gstring, Ffind_composition_internal):
2191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2192 (update_compositions):
2193 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2194 * composite.h: Adjust decls to match defn changes elsewhere.
2195 (struct composition):
2196 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2197 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2198 Do not attempt to compute the address of the object just before a
2199 buffer; this is not portable.
2200 (Faref, Faset):
2201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2202 (Faset): Use int, not EMACS_INT, where int is wide enough.
2203 (Fstring_to_number): Don't assume fixnums fit in int.
2204 (Frem): Don't assume arg is nonnegative.
2205 * dbusbind.c (xd_append_arg): Check for integers out of range.
2206 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2207 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2208 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2209 (xd_get_connection_references): Return ptrdiff_t, not int.
2210 All uses changed.
2211 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2212 (xd_read_message_1):
2213 Use int, not unsigned, where the dbus API uses int.
2214 (Fdbus_message_internal): Don't overflow mtype.
2215 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2216 * dired.c (directory_files_internal, file_name_completion, scmp)
2217 (file_name_completion_stat):
2218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2219 (file_name_completion): Don't overflow matchcount.
2220 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2221 * dispextern.h: Adjust decls to match defn changes elsewhere.
2222 (struct text_pos, struct glyph, struct bidi_saved_info)
2223 (struct bidi_string_data, struct bidi_it, struct composition_it)
2224 (struct it):
2225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2226 (struct display_pos, struct composition_it, struct it):
2227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2228 * dispnew.c (increment_matrix_positions)
2229 (increment_row_positions, mode_line_string)
2230 (marginal_area_string):
2231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2232 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2234 (duration_to_sec_usec): New function, to check for overflow better.
2235 (Fsleep_for, sit_for): Use it.
2236 * doc.c (get_doc_string, store_function_docstring):
2237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2238 (get_doc_string, Fsnarf_documentation):
2239 Use int, not EMACS_INT, where int is wide enough.
2240 (get_doc_string):
2241 Use SAFE_ALLOCA, not alloca.
2242 Check for overflow when converting EMACS_INT to off_t.
2243 * doprnt.c (doprnt):
2244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2245 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2246 Don't assume uid_t fits into fixnum.
2247 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2248 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2249 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2250 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2251 (general_insert_function)
2252 (Finsert_char, make_buffer_string, make_buffer_string_both)
2253 (update_buffer_properties, Fbuffer_substring)
2254 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2255 (Fsubst_char_in_region, check_translation)
2256 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2257 (transpose_markers, Ftranspose_regions):
2258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2259 (clip_to_bounds): Move to lisp.h as an inline function).
2260 (Fconstrain_to_field): Don't assume integers are nonnegative.
2261 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2262 (Fsubst_char_in_region, Fsave_restriction):
2263 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2264 (Femacs_pid): Don't assume pid_t fits into fixnum.
2265 (lo_time): Use int, not EMACS_INT, when int suffices.
2266 (lisp_time_argument): Check for usec out of range.
2267 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2268 (Fuser_login_name, Fuser_full_name): Signal an error
2269 if a uid argument is out of range, rather than relying on
2270 undefined behavior.
c8d5c857
PE
2271 (Fformat_time_string): Remove now-unnecessary check.
2272 lisp_time_argument checks for out-of-range usec now.
243e0530 2273 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2274 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2275 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2276 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2277 (init_cmdargs, Fdump_emacs):
2278 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2279 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2280 the bottom (typically) 32 bits of the fixnum.
2281 * eval.c (specpdl_size, call_debugger):
2282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2283 (when_entered_debugger, Fbacktrace_debug):
2284 Don't assume fixnum can fit in int.
2285 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2286 the object just before a buffer; this is not portable.
2287 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2288 (grow_specpdl, unbind_to):
2289 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2290 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2291 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2292 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2293 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2294 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2295 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2296 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2297 (a_write, e_write):
2298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2299 (Fcopy_file, non_regular_nbytes, read_non_regular)
2300 (Finsert_file_contents):
2301 Use int, not EMACS_INT, where int is wide enough.
2302 (READ_BUF_SIZE): Verify that it fits in int.
2303 (Finsert_file_contents): Check that counts are in proper range,
2304 rather than assuming fixnums fit into ptrdiff_t etc.
2305 Don't assume fixnums fit into int.
125b3835 2306 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2307 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2308 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2309 (string_char_to_byte, string_byte_to_char)
2310 (string_make_multibyte, string_to_multibyte)
2311 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2312 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2313 (substring_both, Fdelete, internal_equal, Ffillarray)
2314 (Fclear_string, mapcar1)
2315 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2316 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2317 (larger_vector, make_hash_table, maybe_resize_hash_table)
2318 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2319 (Fmaphash, secure_hash):
2320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2321 (concat): Check for string index and length overflow.
2322 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2323 (Frequire):
2324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2325 (larger_vector): New API (vec, incr_min, size_max) replaces old
2326 one (vec, new_size, init). This catches size overflow.
2327 INIT was removed because it was always Qnil.
2328 All callers changed.
2329 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2330 the upper bound on a hash table index size.
2331 (make_hash_table, maybe_resize_hash_table): Use it.
2332 (secure_hash): Computer start_byte and end_byte only after
2333 they're known to be in ptrdiff_t range.
2334 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2335 (Ffont_get_glyphs, Ffont_at):
2336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2337 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2338 (Flist_fonts, Fopen_font):
2339 Don't assume fixnum can fit in int.
2340 (check_gstring): Don't assume index can fit in int.
2341 (font_match_p): Check that fixnum is a character, not a nonnegative
2342 fixnum, since the later code needs to stuff it into an int.
2343 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2344 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2345 conversion overflow issues.
2346 (Fopen_font): Check for integer out of range.
2347 (Ffont_get_glyphs): Don't assume index can fit in int.
2348 * font.h: Adjust decls to match defn changes elsewhere.
2349 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2350 integer overflow.
2351 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2352 printmax_t, where ptrdiff_t is wide enough.
2353 (Finternal_char_font):
2354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2355 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2356 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2357 (Fset_frame_position, x_set_frame_parameters)
2358 (x_set_line_spacing, x_set_border_width)
2359 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2360 Check that fixnums are in proper range for system types.
2361 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2362 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2363 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2364 Use SAFE_ALLOCA_LISP, not alloca.
2365 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2366 intptr_t is wide enough.
2367 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2368 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2369 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2370 Check for fixnum out of range.
2371 * ftfont.c (ftfont_list): Don't assume index fits in int.
2372 Check that fixnums are in proper range for system types.
2373 (ftfont_shape_by_flt):
2374 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2375 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2376 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2377 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2378 Check that fixnums are in proper range for system types.
2379 * gnutls.h: Adjust decls to match defn changes elsewhere.
2380 * gtkutil.c (xg_dialog_run):
2381 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2382 (update_frame_tool_bar):
2383 Check that fixnums are in proper range for system types.
2384 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2385 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2386 * indent.c (last_known_column, last_known_column_point):
2387 (current_column_bol_cache):
2388 (skip_invisible, current_column, check_display_width):
2389 (check_display_width, scan_for_column, current_column_1)
2390 (Findent_to, Fcurrent_indentation, position_indentation)
2391 (indented_beyond_p, Fmove_to_column, compute_motion):
2392 (Fcompute_motion, Fvertical_motion):
2393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2394 (last_known_column_modified): Use EMACS_INT, not int.
2395 (check_display_width):
2396 (Fcompute_motion):
2397 Check that fixnums and floats are in proper range for system types.
2398 (compute_motion): Don't assume index or fixnum fits in int.
2399 (compute_motion, Fcompute_motion):
2400 Use int, not EMACS_INT, when it is wide enough.
2401 (vmotion): Omit local var start_hpos that is always 0; that way
2402 we don't need to worry about overflow in expressions involving it.
2403 * indent.h: Adjust decls to match defn changes elsewhere.
2404 (struct position):
2405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2406 Use int, not EMACS_INT, where int is wide enough.
2407 Remove unused members ovstring_chars_done and tab_offset;
2408 all uses removed.
2409 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2410 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2411 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2412 (make_gap, copy_text, insert, insert_and_inherit)
2413 (insert_before_markers, insert_before_markers_and_inherit)
2414 (insert_1, count_combining_before, count_combining_after)
2415 (insert_1_both, insert_from_string)
2416 (insert_from_string_before_markers, insert_from_string_1)
2417 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2418 (adjust_after_replace, adjust_after_insert, replace_range)
2419 (replace_range_2, del_range, del_range_1, del_range_byte)
2420 (del_range_both, del_range_2, modify_region)
2421 (prepare_to_modify_buffer, signal_before_change)
2422 (signal_after_change, Fcombine_after_change_execute):
2423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2424 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2425 (balance_an_interval, split_interval_right, split_interval_left)
2426 (find_interval, next_interval, update_interval)
2427 (adjust_intervals_for_insertion, delete_node, delete_interval)
2428 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2429 (static_offset_intervals, offset_intervals)
2430 (merge_interval_right, merge_interval_left, make_new_interval)
2431 (graft_intervals_into_buffer, temp_set_point_both)
2432 (temp_set_point, set_point, adjust_for_invis_intang)
2433 (set_point_both, move_if_not_intangible, get_property_and_range)
2434 (get_local_map, copy_intervals, copy_intervals_to_string)
2435 (compare_string_intervals, set_intervals_multibyte_1):
2436 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2437 * intervals.h: Adjust decls to match defn changes elsewhere.
2438 (struct interval):
2439 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2440 * keyboard.c (this_command_key_count, this_single_command_key_start)
2441 (before_command_key_count, before_command_echo_length, echo_now)
2442 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2443 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2444 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2445 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2446 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2447 (last_non_minibuf_size, last_point_position, echo_truncate)
2448 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2449 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2450 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2451 (stuff_buffered_input):
2452 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2453 (last_auto_save, command_loop_1, read_char):
2454 Use EMACS_INT, not int, to avoid integer overflow.
2455 (record_char): Avoid overflow in total_keys computation.
2456 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2457 * keyboard.h: Adjust decls to match defn changes elsewhere.
2458 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2459 (Fkey_description, Fdescribe_vector, Flookup_key):
2460 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2461 (click_position): New function, to check that positions are in range.
2462 (Fcurrent_active_maps):
2463 (describe_command):
2464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2465 (Faccessible_keymaps, Fkey_description):
2466 (preferred_sequence_p):
2467 Don't assume fixnum can fit into int.
2468 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2469 Check for integer overflow in size calculations.
2470 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2471 avoid mishandling large integers.
2472 * lisp.h: Adjust decls to match defn changes elsewhere.
2473 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2474 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2475 (struct Lisp_Marker):
2476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2477 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2478 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2479 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2480 All callers changed.
2481 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2482 Assume the arg has valid form, since it always does.
2483 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2484 unsigned integer system type.
2485 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2486 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2487 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2488 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2489 (duration_to_sec_usec): New decl.
2490 * lread.c (read_from_string_index, read_from_string_index_byte)
2491 (read_from_string_limit, readchar, unreadchar, openp)
2492 (read_internal_start, read1, oblookup):
2493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2494 (Fload, readevalloop, Feval_buffer, Feval_region):
2495 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2496 (openp): Check for out-of-range argument to 'access'.
2497 (read1): Use int, not EMACS_INT, where int is wide enough.
2498 Don't assume fixnum fits into int.
6efdadfd 2499 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2500 (read_filtered_event): Use duration_to_sec_usec
2501 to do proper overflow checking on durations.
d311d28c
PE
2502 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2503 in size calculation.
2504 (Fexecute_kbd_macro):
2505 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2506 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2507 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2508 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2509 (set_marker_both, set_marker_restricted_both, marker_position)
2510 (marker_byte_position, Fbuffer_has_markers_at):
2511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2512 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2513 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2514 It now merely ensures that the menu is large enough, without
2515 necessarily growing it, as this avoids some integer overflow issues.
2516 All callers changed.
2517 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2518 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2519 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2520 Use SAFE_ALLOCA_LISP, not alloca.
2521 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2522 to EMACS_INT. Check that fixnums are in proper range for system types.
2523 * minibuf.c (minibuf_prompt_width, string_to_object)
2524 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2525 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2527 (get_minibuffer, read_minibuf_unwind):
2528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2529 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2530 this simplifies overflow checking. All callers changed.
2531 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2532 (Ftest_completion):
2533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2534 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2535 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2536 Check that fixnums are in proper range for system types.
2537 (Fx_create_frame, Fx_show_tip):
2538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2539 * nsfont.m (ns_findfonts, nsfont_list_family):
2540 Don't assume fixnum fits in long.
2541 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2542 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2543 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2544 wide enough.
17fdb222 2545 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2546 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2547 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2548 (PRINTDECLARE, PRINTPREPARE):
2549 (strout, print_string):
2550 (print, print_preprocess, print_check_string_charset_prop)
2551 (print_object):
2552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2553 (PRINTDECLARE):
2554 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2555 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2556 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2557 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2558 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2559 (print_error_message): Use SAFE_ALLOCA, not alloca.
2560 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2561 (print_depth, new_backquote_output, print_number_index):
2562 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2563 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2564 (Fset_process_window_size, Fformat_network_address)
2565 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2566 (sigchld_handler):
d311d28c 2567 Check that fixnums are in proper range for system types.
d44287d4 2568 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2569 Check for process-ids out of pid_t range rather than relying on
2570 undefined behavior.
e4d81efc 2571 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2572 (Fformat_network_address, read_process_output, send_process)
2573 (Fprocess_send_region, status_notify):
2574 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2575 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2576 (wait_reading_process_output, read_process_output, exec_sentinel):
2577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2578 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2579 (Faccept_process_output): Use duration_to_sec_usec to do proper
2580 overflow checking on durations.
dde14581
PE
2581 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2582 Don't assume pid_t fits in int.
02481186
PE
2583 * process.h (struct Lisp_Process): Members tick and update_tick
2584 are now of type EMACS_INT, not int.
b62b53e8
PE
2585 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2586 configured --with-wide-int.
d311d28c
PE
2587 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2588 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2589 * search.c (looking_at_1, string_match_1):
2590 (fast_string_match, fast_c_string_match_ignore_case)
2591 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2592 (scan_newline, find_before_next_newline, search_command)
2593 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2594 (set_search_regs, wordify):
2595 (Freplace_match):
2596 (Fmatch_data):
2597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2598 (string_match_1, search_buffer, set_search_regs):
2599 (Fmatch_data):
2600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2601 (wordify): Check for overflow in size calculation.
2602 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2603 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2604 Check that fixnums are in proper range for system types.
2605 * sound.c (struct sound_device)
2606 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2608 (Fplay_sound_internal):
2609 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2610 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2611 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2612 (Fparse_partial_sexp):
2613 Don't assume fixnums can fit in int.
2614 (struct lisp_parse_state, find_start_pos, find_start_value)
2615 (find_start_value_byte, find_start_begv)
2616 (update_syntax_table, char_quoted, dec_bytepos)
2617 (find_defun_start, prev_char_comend_first, back_comment):
2618 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2619 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2620 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2621 (Finternal_describe_syntax_value): Check that match_lisp is a
2622 character, not an integer, since the code stuffs it into int.
2623 (scan_words, scan_sexps_forward):
2624 Check that fixnums are in proper range for system types.
2625 (Fforward_word):
2626 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2627 (scan_sexps_forward):
2628 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2629 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2630 * syntax.h: Adjust decls to match defn changes elsewhere.
2631 (struct gl_state_s):
2632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2633 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2634 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2635 * sysdep.c (wait_for_termination_1, wait_for_termination)
2636 (interruptible_wait_for_termination, mkdir):
2637 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2638 (emacs_read, emacs_write):
2639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2640 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2641 and double all fit in int.
d311d28c
PE
2642 * term.c (set_tty_color_mode):
2643 Check that fixnums are in proper range for system types.
2644 * termhooks.h (struct input_event):
2645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2646 * textprop.c (validate_interval_range, interval_of)
2647 (Fadd_text_properties, set_text_properties_1)
2648 (Fremove_text_properties, Fremove_list_of_text_properties)
2649 (Ftext_property_any, Ftext_property_not_all)
2650 (copy_text_properties, text_property_list, extend_property_ranges)
2651 (verify_interval_modification):
2652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2653 (Fnext_single_char_property_change)
2654 (Fprevious_single_char_property_change):
2655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2656 (copy_text_properties):
2657 Check for integer overflow in index calculation.
d311d28c
PE
2658 * undo.c (last_boundary_position, record_point, record_insert)
2659 (record_delete, record_marker_adjustment, record_change)
2660 (record_property_change):
2661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2662 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2663 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2664 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2665 (Fx_hide_tip, Fx_file_dialog):
2666 * w32menu.c (set_frame_menubar):
2667 Use ptrdiff_t, not int, for consistency with rest of code.
2668 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2669 (select_window, Fdelete_other_windows_internal)
2670 (window_scroll_pixel_based, window_scroll_line_based)
2671 (Frecenter, Fset_window_configuration):
2672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2673 (Fset_window_hscroll, run_window_configuration_change_hook)
2674 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2675 (Fscroll_other_window, Frecenter):
d311d28c
PE
2676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2677 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2678 Don't assume fixnum fits in int.
2679 (Fset_window_scroll_bars):
2680 Check that fixnums are in proper range for system types.
2681 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2682 (string_pos, c_string_pos, number_of_chars, init_iterator)
2683 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2684 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2685 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2686 (face_before_or_after_it_pos, handle_invisible_prop)
2687 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2688 (display_prop_intangible_p, string_buffer_position_lim)
2689 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2690 (get_overlay_strings_1, get_overlay_strings)
2691 (iterate_out_of_display_property, forward_to_next_line_start)
2692 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2693 (get_next_display_element, set_iterator_to_next)
2694 (get_visually_first_element, compute_stop_pos_backwards)
2695 (handle_stop_backwards, next_element_from_buffer)
2696 (move_it_in_display_line_to, move_it_in_display_line)
2697 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2698 (add_to_log, message_dolog, message_log_check_duplicate)
2699 (message2, message2_nolog, message3, message3_nolog
2700 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2701 (current_message_1, truncate_echo_area, truncate_message_1)
2702 (set_message, set_message_1, store_mode_line_noprop)
2703 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2704 (text_outside_line_unchanged_p, check_point_in_composition)
2705 (reconsider_clip_changes)
2706 (redisplay_internal, set_cursor_from_row, try_scrolling)
2707 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2708 (redisplay_window, find_last_unchanged_at_beg_row)
2709 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2710 (trailing_whitespace_p, find_row_edges, display_line)
2711 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2712 (display_mode_element, store_mode_line_string)
2713 (pint2str, pint2hrstr, decode_mode_spec)
2714 (display_count_lines, display_string, draw_glyphs)
2715 (x_produce_glyphs, x_insert_glyphs)
2716 (rows_from_pos_range, mouse_face_from_buffer_pos)
2717 (fast_find_string_pos, mouse_face_from_string_pos)
2718 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2720 (safe_call, init_from_display_pos, handle_fontified_prop)
2721 (handle_single_display_spec, load_overlay_strings)
2722 (with_echo_area_buffer, setup_echo_area_for_printing)
2723 (display_echo_area, echo_area_display)
2724 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2725 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2726 (redisplay_window, dump_glyph_row, display_mode_line)
2727 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2728 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2729 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2730 (handle_single_display_spec, build_desired_tool_bar_string)
2731 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2732 (get_specified_cursor_type):
2733 Check that fixnums are in proper range for system types.
2734 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2735 (Flookup_image_map):
2736 Don't assume fixnums fit in int.
2737 (compare_overlay_entries):
2738 Avoid mishandling comparisons due to subtraction overflow.
2739 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2740 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2741 (handle_tool_bar_click):
2742 Use int, not unsigned, since we prefer signed and the signedness
2743 doesn't matter here.
2744 (get_next_display_element, next_element_from_display_vector):
2745 Use int, not EMACS_INT, when int is wide enough.
2746 (start_hourglass): Use duration_to_sec_usec to do proper
2747 overflow checking on durations.
2748 * xfaces.c (Fbitmap_spec_p):
2749 Check that fixnums are in proper range for system types.
2750 (compare_fonts_by_sort_order):
2751 Avoid mishandling comparisons due to subtraction overflow.
2752 (Fx_family_fonts, realize_basic_faces):
2753 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2754 (Fx_family_fonts):
2755 Don't assume fixnum fits in int.
2756 Use SAFE_ALLOCA_LISP, not alloca.
2757 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2758 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2759 (face_at_buffer_position, face_for_overlay_string)
2760 (face_at_string_position):
2761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2762 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2763 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2764 (Fx_show_tip):
2765 Check that fixnums are in proper range for system types.
2766 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2767 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2769 (Fx_change_window_property): Don't assume fixnums fit in int.
2770 * xfont.c (xfont_chars_supported):
2771 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2772 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2773 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2775 * xml.c (parse_region):
2776 * xrdb.c (magic_file_p):
2777 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2778 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2779 (x_get_local_selection, x_reply_selection_request)
2780 (x_handle_selection_request, wait_for_property_change):
2781 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2782 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2783 short is wide enough.
2784 (x_send_client_event): Don't assume fixnum fits in int.
2785 * xterm.c (x_x_to_emacs_modifiers):
2786 Don't assume EMACS_INT overflows nicely into int.
2787 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2788 may come from Lisp.
2789 (handle_one_xevent): NATNUMP can eval its arg twice.
2790 (x_connection_closed):
2791 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2792 * xterm.h: Adjust decls to match defn changes elsewhere.
2793 (struct scroll_bar): Use struct vectorlike_header
2794 rather than rolling our own approximation.
2795 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2796
c6574eb5
GM
27972012-05-25 Glenn Morris <rgm@gnu.org>
2798
2799 * lisp.mk (lisp): Update for more files being compiled now.
2800
e8d32c7e
SM
28012012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2802
48def666
SM
2803 * lread.c: Remove `read_pure' which makes no difference.
2804 (read_pure): Remove var.
2805 (unreadpure): Remove function.
2806 (readevalloop): Don't call read_list with -1 flag.
2807 (read1, read_vector): Don't test read_pure any more.
2808 (read_list): Simplify.
2809
e8d32c7e
SM
2810 * fileio.c, character.h: Minor style tweaks.
2811
4b2addb7
DA
28122012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2813
2814 * window.h (clip_changed): Remove useless declaration.
2815
584461b2
JB
28162012-05-22 Juanma Barranquero <lekktu@gmail.com>
2817
2818 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2819 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2820
34374650
PE
28212012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2822
2823 Remove src/m/*.
2824 This directory predates autoconf and is no longer needed nowadays.
2825 Move its few remaining bits of functionality to where they're needed.
2826 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2827 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2828 * m/template.h: Remove.
2829 * Makefile.in (M_FILE): Remove. All uses removed.
2830 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2831 * lisp.h (USE_LSB_TAG):
2832 * mem-limits.h (EXCEEDS_LISP_PTR):
2833 Use VAL_MAX, not VALBITS, in #if.
2834 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2835 (EMACS_UINT): Define unconditionally now.
2836 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2837 (BITS_PER_EMACS_INT): New constants, replacing
2838 what used to be in config.h, but not useful in #if.
2839 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2840 define them any more.
2841 (VAL_MAX): New macro.
2842 (VALMASK): Use it.
2843 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2844 BITS_PER_EMACS_INT, in #if.
2845 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2846 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2847 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2848 * s/ms-w32.h (DATA_START):
2849 Move here from removed file m/intel386.h.
2850 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2851 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2852
261cb4bb
PE
28532012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2854
2855 Assume C89 or later.
2856 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2857 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2858 (xrealloc):
2859 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2860 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2861 * textprop.c, tparam.c (NULL): Remove.
2862 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2863 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2864 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2865 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2866 * xterm.c (input_signal_count): Assume volatile works.
2867
ff23cd9f
KB
28682012-05-21 Ken Brown <kbrown@cornell.edu>
2869
2870 * xgselect.c (xg_select): Fix first argument in call to 'select'
2871 (bug#11508).
2872
1b170bc6
KB
28732012-05-20 Ken Brown <kbrown@cornell.edu>
2874
2875 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2876 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2877
b2f4d39f
KB
28782012-05-19 Ken Brown <kbrown@cornell.edu>
2879
2880 * xfns.c (x_in_use): Remove `static' qualifier.
2881 * xterm.h (x_in_use): Declare.
2882 * xgselect.c: Include xterm.h.
2883 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2884 and `display_arg' (bug#9754).
2885
003fdae2
PE
28862012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2887
9232a6d9
PE
2888 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2889
003fdae2
PE
2890 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2891 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2892
784b56e2
EZ
28932012-05-18 Eli Zaretskii <eliz@gnu.org>
2894
2895 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2896
2897 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 2898 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
2899
2900 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2901 reference to image_cache->refcount.
2902 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2903
a0a79cde
JL
29042012-05-17 Juri Linkov <juri@jurta.org>
2905
2906 * search.c (Fword_search_regexp, Fword_search_backward)
2907 (Fword_search_forward, Fword_search_backward_lax)
2908 (Fword_search_forward_lax): Move functions to isearch.el
2909 (bug#10145, bug#11381).
2910
b0572523
PE
29112012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2912
2913 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2914
9660f5fc
SM
29152012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2916
2917 * lread.c (init_obarray): Declare Qt and Qnil as special.
2918
4374de83
GM
29192012-05-14 Glenn Morris <rgm@gnu.org>
2920
2921 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2922 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2923
dc44c39a
PE
29242012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2925
078c97cb
PE
2926 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2927
dc44c39a
PE
2928 * unexaix.c: Port to more-recent AIX compilers.
2929 (report_error, report_error_1, make_hdr, copy_sym)
2930 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2931 Make arguments const char *, not char *, to avoid violations of C
2932 standard and to fix some AIX warnings reported by Gilles Pion.
2933
e18afed7 29342012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2935
2936 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2937 already have overlays loaded.
2938 (handle_single_display_spec): Before returning without displaying
2939 fringe bitmap, synchronize the bidi iterator with the main display
2940 iterator, by calling iterate_out_of_display_property.
2941 (iterate_out_of_display_property): Detect buffer iteration by
2942 testing that it->string is a Lisp string.
2943 (get_next_display_element): When the current object is exhausted,
2944 and there's something on it->stack, call set_iterator_to_next to
2945 proceed with what's on the stack, instead of returning zero.
2946 (set_iterator_to_next): If called at the end of a Lisp string,
2947 proceed to consider_string_end without incrementing string
2948 position. Don't increment display vector index past the end of
2949 the display vector. (Bug#11417)
c8fb9dc6
EZ
2950 (pos_visible_p): Don't report a position visible when move_it_to
2951 stopped at the last line of window, which happens to be scanned
2952 backwards by the bidi iteration. (Bug#11464)
ac268e67 2953
e18afed7 29542012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2955
2956 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2957 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2958 are on a TTY, and thus unable to display on the fringes.
2959 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2960 so we need to signal to the caller that this is a "replacing"
2961 display spec. This fixes display when the spec is invalid or we
2962 are on a TTY.
2963
e18afed7 29642012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2965
2966 * unexaix.c (make_hdr): Fix typo in prototype.
2967 This bug broke the build on AIX. Problem reported by Gilles Pion.
2968
9d0a235a
MA
29692012-05-14 Michael Albinus <michael.albinus@gmx.de>
2970
2971 * keyboard.c (kbd_buffer_get_event): Read special events also in
2972 batch mode. (Bug#11415)
2973
9e6b06ed
GM
29742012-05-12 Glenn Morris <rgm@gnu.org>
2975
2976 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2977
c1a1d7a3
EZ
29782012-05-12 Eli Zaretskii <eliz@gnu.org>
2979
2980 * lisp.mk (lisp): Add newcomment.elc.
2981
3fe7cdc8
GM
29822012-05-12 Glenn Morris <rgm@gnu.org>
2983
2984 * Makefile.in (MKDIR_P): New, set by configure.
2985 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2986
53f7d2c0
PE
29872012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2988
2989 Remove unused function hourglass_started.
2990 * dispextern.h (hourglass_started):
2991 * w32fns.c (hourglass_started):
2992 * xdisp.c (hourglass_started): Remove.
2993
75aafb17
JB
29942012-05-10 Juanma Barranquero <lekktu@gmail.com>
2995
2996 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2997 Update dependencies.
2998
12959e8e
PE
29992012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3000
97107e2e
PE
3001 * xgselect.c (xg_select): Put maxfds+1 into a var.
3002 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3003
12959e8e
PE
3004 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3005
836d29b3
DA
30062012-05-10 Dave Abrahams <dave@boostpro.com>
3007
3008 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3009 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3010
5cb67954
MA
30112012-05-09 Michael Albinus <michael.albinus@gmx.de>
3012
3013 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3014 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3015 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3016 Initialize xd_registered_buses.
3017
3478ec45
PE
30182012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3019
b263a6b0
PE
3020 Untag more efficiently if USE_LSB_TAG.
3021 This is based on a proposal by YAMAMOTO Mitsuharu in
3022 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3023 For an admittedly artificial (nth 8000 longlist) benchmark on
3024 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3025 Emacs's overall text size by 1%.
3026 * lisp.h (XUNTAG): New macro.
3027 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3028 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3029 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3030 * eval.c (Fautoload):
3031 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3032 * frame.h (XFRAME): Use XUNTAG.
3033
3478ec45
PE
3034 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3035 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3036 Remove unportable assumptions about print widths of types like
3037 dbus_uint32_t.
3038 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3039 intptr_t when converting between pointer and integer, to avoid GCC
3040 warnings about wrong width.
3041
666b903b 30422012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3043
3044 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3045 stack for each reader_thread, instead of defaulting to 8MB
3046 determined by the linker. This avoids failures in creating
3047 subprocesses on Windows 7, see the discussion in this thread:
3048 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3049
b120cc17
JC
30502012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3051
3052 Fix up display of the *Minibuf-0* buffer in the mini window.
3053 * keyboard.c (read_char): Don't clear the echo area if there's no
3054 message to clear.
3055 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3056 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3057
9a4b36f8
MA
30582012-05-07 Michael Albinus <michael.albinus@gmx.de>
3059
3060 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3061 batch mode.
3062
e5f9458f
CY
30632012-05-06 Chong Yidong <cyd@gnu.org>
3064
3065 * lisp.mk (lisp): Update.
3066
eceeb5fc 30672012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3068
3069 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3070
71873e2b
SM
30712012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3072
3073 * data.c (PUT_ERROR): New macro.
3074 (syms_of_data): Use it. Add new error type `user-error'.
3075 * undo.c (user_error): New function.
3076 (Fprimitive_undo): Use it.
3077 * print.c (print_error_message): Adjust print style for `user-error'.
3078 * keyboard.c (user_error): New function.
3079 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3080
ab0fa4e4
PE
30812012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 Do not limit current-time-string to years 1000..9999.
3084 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3085 (Fcurrent_time_string): Support any year that is supported by the
3086 underlying localtime representation. Don't use asctime, as it
3087 has undefined behavior for years outside the range -999..9999.
3088
7ed806a7
PE
30892012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3090
3091 Fix race conditions involving setenv, gmtime, localtime, asctime.
3092 Without this fix, interrupts could mess up code that uses these
3093 nonreentrant functions, since setting TZ invalidates existing
3094 tm_zone or tzname values, and since most of these functions return
3095 pointers to static storage.
3096 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3097 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3098 Grow the critical sections to include not just invoking
3099 localtime/gmtime, but also accessing these functions' results
3100 including their tm_zone values if any, and any related TZ setting.
3101 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3102 so that the struct tm is saved in the critical section.
3103 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3104 motivated by the fact that memory allocation needs to be outside
3105 the critical section.
3106
0c16dfed
DA
31072012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3108
3109 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3110 with RESET_INTERVAL.
3111
3112 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3113 Remove duplicated buffer name initialization.
3114
3f83ace8
JM
31152012-05-02 Jim Meyering <jim@meyering.net>
3116
3117 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3118
c7b8541e
JM
3119 * xfns.c (x_window): Use xstrdup (Bug#11375).
3120
90207a15 31212012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3122
3123 * xdisp.c (pos_visible_p): If already at a newline from the
3124 display string before the 'while' loop, don't walk back the glyphs
3125 from it3.glyph_row. Solves assertion violation when the display
3126 string begins with a newline (egg.el). (Bug#11367)
3127
b593d6a9
AH
31282012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3129
3130 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3131 Move to simple.el.
3132
4737362e
GM
31332012-05-01 Glenn Morris <rgm@gnu.org>
3134
99cf43f9
GM
3135 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3136 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3137 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3138 All were removed before 23.1.
3139
9311dcff
GM
3140 * dispnew.c: Remove HAVE_LIBNCURSES test;
3141 it is always true on relevant platforms.
3142
4d5c6349
GM
3143 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3144 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3145
4737362e
GM
3146 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3147
74dd3a6b
AS
31482012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3149
3150 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3151 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3152 Remove.
3153
13c379ee
PE
31542012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3155
3156 Do not avoid creating empty evaporating overlays (Bug#9642).
3157 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3158 That is, do not delete an evaporating overlay if it becomes
3159 empty after its bounds are adjusted to fit within its buffer.
3160 This fix caused other problems, and I'm reverting it until we get
3161 to the bottom of them.
3162
a8e7d6d7 31632012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3164
3165 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3166
a8e7d6d7 31672012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3168
3169 * xdisp.c (pos_visible_p): If the window start position is beyond
3170 ZV, start the display from buffer beginning. Prevents assertion
3171 violation in init_iterator when the minibuffer window is scrolled
3172 via the scroll bar.
3173
3174 * window.c (window_scroll_pixel_based): Likewise.
3175
a8e7d6d7 31762012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3177
3178 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3179
a8e7d6d7 31802012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3181
3182 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3183 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3184
a8e7d6d7 31852012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3186
b593d6a9
AH
3187 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3188 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3189
1c6900d9
EZ
31902012-04-26 Eli Zaretskii <eliz@gnu.org>
3191
4c3fa1d9
EZ
3192 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3193 display element, check also the underlying string or buffer
3194 character. (Bug#11341)
3195
1c6900d9
EZ
3196 * w32menu.c: Include w32heap.h.
3197 (add_menu_item): If the call to AppendMenuW (via
3198 unicode_append_menu) fails, disable Unicode menus only if we are
3199 running on Windows 9X/Me.
3200
42bf8205
AS
32012012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3202
3203 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3204 (xgetint): Add missing shift for LSB tags.
3205
b1bac16e
MR
32062012-04-24 Martin Rudalics <rudalics@gmx.at>
3207
3208 * keyboard.c (read_char): Don't wipe echo area for select window
3209 events: These might get delayed via `mouse-autoselect-window'
3210 (Bug#11304).
3211
d69621cc
JB
32122012-04-24 Juanma Barranquero <lekktu@gmail.com>
3213
3214 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3215 manipulation of :loaded-from data.
3216
02fd101b
JB
32172012-04-23 Juanma Barranquero <lekktu@gmail.com>
3218
3219 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3220 now a cons (bug#11311).
3221
888bec30
PE
32222012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3223
89a438bd
PE
3224 Do not create empty overlays with the evaporate property (Bug#9642).
3225 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3226 if it becomes empty after its bounds are adjusted to fit within
3227 its buffer. Without this fix, in a nonempty buffer (let ((o
3228 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3229 yields an empty overlay that has the evaporate property, which is
3230 not supposed to happen.
3231
1068fe4d
PE
3232 Fix minor GTK3 problems found by static checking.
3233 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3234 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3235 (struct _EmacsFixedClass, emacs_fixed_get_type):
3236 Move decls here from emacsgtkfixed.h, since they needn't be public.
3237 (emacs_fixed_get_type): Now static.
3238 (emacs_fixed_class_init): Omit unused local.
3239 (emacs_fixed_child_type): Remove; unused.
3240 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3241 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3242 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3243 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3244 (EMACS_FIXED_GET_CLASS): Remove; unused.
3245 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3246
888bec30
PE
3247 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3248 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3249
de85e130
PE
32502012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3251
d0baac98 3252 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3253 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3254 (__malloc_size_t, __malloc_ptrdiff_t):
3255 Remove. All uses removed, replaced by the definiens if needed,
3256 since we can assume C89 or better now.
3257 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3258 (protect_malloc_state, align, get_contiguous_space)
3259 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3260 (malloc_atfork_handler_child, malloc_enable_thread)
3261 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3262 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3263 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3264 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3265 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3266 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3267 Define using prototypes, not old style.
3268 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3269 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3270 (align): Don't assume that signed integer overflow wraps around.
3271 Omit unused local var.
3272 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3273 (_free_internal_nolock, memalign, mallochook, reallochook):
3274 Omit no-longer-needed casts.
3275 (valloc): Use getpagesize, not __getpagesize.
3276 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3277 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3278
de85e130
PE
3279 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3280
dcbf5805
MA
32812012-04-22 Michael Albinus <michael.albinus@gmx.de>
3282
3283 Move functions from C to Lisp. Make non-blocking method calls
3284 the default. Implement further D-Bus standard interfaces.
3285
3286 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3287 (QCdbus_request_name_allow_replacement)
3288 (QCdbus_request_name_replace_existing)
3289 (QCdbus_request_name_do_not_queue)
3290 (QCdbus_request_name_reply_primary_owner)
3291 (QCdbus_request_name_reply_in_queue)
3292 (QCdbus_request_name_reply_exists)
3293 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3294 (QCdbus_registered_serial, QCdbus_registered_method)
3295 (QCdbus_registered_signal): New Lisp objects.
3296 (XD_DEBUG_MESSAGE): Use sizeof.
3297 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3298 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3299 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3300 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3301 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3302 (xd_signature, xd_append_arg): Allow float for integer types.
3303 (xd_get_connection_references): New function.
b593d6a9
AH
3304 (xd_get_connection_address): Rename from xd_initialize.
3305 Return cached address.
dcbf5805
MA
3306 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3307 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3308 level.
3309 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3310 Return number of refcounts.
dcbf5805
MA
3311 (Fdbus_get_unique_name): Make stronger parameter check.
3312 (Fdbus_message_internal): New defun.
3313 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3314 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3315 (Fdbus_send_signal, Fdbus_register_service)
3316 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3317 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3318 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3319 (Vdbus_compiled_version, Vdbus_runtime_version)
3320 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3321 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3322 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3323 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3324 Adapt docstring.
dcbf5805 3325
52828e02
PE
33262012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3327
da05bc4c
PE
3328 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3329 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3330 Do not assume ptrdiff_t is the same width as 'int'.
3331
52828e02
PE
3332 * alloc.c: Handle unusual debugging option combinations.
3333 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3334 since the two debugging options are incompatible.
3335 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3336 is defined.
3337 (mem_init, mem_insert, mem_insert_fixup):
3338 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3339 (NEED_MEM_INSERT): Remove; no longer needed.
3340
f01769f9
LL
33412012-04-22 Leo Liu <sdl.web@gmail.com>
3342
3343 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3344
5790543d
PE
33452012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3346
3347 * sysdep.c [__FreeBSD__]: Minor cleanups.
3348 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3349 Use Emacs indenting style more consistently. Avoid some casts.
3350 Use 'double' consistently rather than mixing 'float' and 'double'.
3351
b91b7e4d
EW
33522012-04-21 Eduard Wiebe <usenet@pusto.de>
3353
b593d6a9
AH
3354 * sysdep.c (list_system_processes, system_process_attributes):
3355 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3356
6114eb15
AS
33572012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3358
3359 * lisp.mk (lisp): Update.
3360
2f38dff7
PE
33612012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3362
3363 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3364 It is never used otherwise.
3365
4ae29f89
SM
33662012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3367
3368 * print.c (print_preprocess): Only check print_depth if print-circle
3369 is nil.
3370 (print_object): Check for cycles even when print-circle is nil and
3371 print-gensym is t, but only check print_depth if print-circle is nil.
3372
f30d612a
CY
33732012-04-20 Chong Yidong <cyd@gnu.org>
3374
3375 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3376 set the status to "failed" and ensure that sentinel is run.
3377
c07a4c0b 33782012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3379
3380 * process.c (Fset_process_inherit_coding_system_flag)
3381 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3382 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3383
c07a4c0b 33842012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3385
3386 * xdisp.c (string_buffer_position_lim): Limit starting position to
3387 BEGV.
3388 (set_cursor_from_row): If called for a mode-line or header-line
3389 row, return zero immediately.
3390 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3391 farther than the first row after the header line, if any.
3392 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3393 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3394
c07a4c0b 33952012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3396
4ae29f89
SM
3397 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3398 (bug#11238).
ad3a2b41 3399
c07a4c0b 34002012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 34012012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3402
3403 configure: new option --enable-gcc-warnings (Bug#11207)
3404 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3405 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3406 (ALL_CFLAGS): Use new macros rather than old.
3407 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3408 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3409 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3410 -Wunused-result, -Wunused-variable. This should go away once
3411 the Emacs and Gnulib regex code is merged.
3412 (xmalloc, xrealloc): Now static.
3413
aba027e8
PE
34142012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3415
3416 * dired.c (Fsystem_groups): Remove unused local.
3417
e5a36063
GM
34182012-04-17 Glenn Morris <rgm@gnu.org>
3419
3420 * dired.c (Fsystem_users): Doc fix.
3421
316411f0
DA
34222012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3423
3424 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3425 (syms_of_dired): Add them.
3426
9426aba4
PE
34272012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3428
b62a57be
PE
3429 Fix minor alloc.c problems found by static checking.
3430 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3431 New extern decls, to avoid calling undeclared functions.
3432 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3433 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3434 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3435 (NEED_MEM_INSERT): New macro.
3436 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3437 Remove one incorrect comment and fix another.
b62a57be 3438
3539f31f
PE
3439 Fix minor ralloc.c problems found by static checking.
3440 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3441 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3442 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3443 (r_alloc_sbrk): Now static.
3444
a041960a
PE
3445 Improve ralloc.c interface checking.
3446 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3447 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3448 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3449 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3450 [REL_ALLOC]: ... to here, to check interface.
3451 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3452 Remove decls. This fixes an "It stinks!".
3453
9426aba4
PE
3454 * alloc.c (which_symbols): Fix alignment issue / type clash.
3455
d55c12ed
AS
34562012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3457
3458 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3459 (struct Lisp_Misc_Any): Likewise.
3460 (struct Lisp_Free): Likewise.
3461 * alloc.c (union aligned_Lisp_Symbol): Define.
3462 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3463 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3464 (union aligned_Lisp_Misc): Define.
3465 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3466 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3467 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3468
b948ce8b
PE
34692012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3470
3471 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3472 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3473 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3474 * s/netbsd.h, s/sol2-6.h:
3475 Remove definition of GC_MARK_STACK, since the default now works.
3476 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3477 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3478 no longer the default.
3479 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3480
35dc09a1 34812012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3482
35dc09a1
GM
3483 * lread.c (lisp_file_lexically_bound_p):
3484 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3485
35dc09a1
GM
34862012-04-14 Eli Zaretskii <eliz@gnu.org>
3487
3488 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3489 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3490
34912012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3492
3493 * nsterm.m (constrainFrameRect): Always constrain when there is only
3494 one screen (Bug#10962).
3495
bcd86815
KB
34962012-04-13 Ken Brown <kbrown@cornell.edu>
3497
3498 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3499
c25df26e
RT
35002012-04-13 Reuben Thomas <rrt@sc3d.org>
3501
3502 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3503
0fc59f1e
DC
35042012-04-11 Daniel Colascione <dancol@dancol.org>
3505
3506 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3507 against is gone. It's better to use vfork now so that when Cygwin
3508 gains a new, working vfork, we use it automatically (bug#10398).
3509
de8c03dc
SM
35102012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3511
3512 * window.c (save_window_save): Obey window-point-insertion-type.
3513
2f097256
GM
35142012-04-11 Glenn Morris <rgm@gnu.org>
3515
3516 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3517
453b951e
SM
35182012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3519
3520 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3521
75f1671a 35222012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3523
3524 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3525 (force_quit_count): New var.
3526 (handle_interrupt): Use it.
3527
2a8ce227
JB
35282012-04-10 Juanma Barranquero <lekktu@gmail.com>
3529
3530 * w32.c (w32_delayed_load): Record the full path of the library
3531 being loaded (bug#10424).
3532
935396c0
GM
35332012-04-09 Glenn Morris <rgm@gnu.org>
3534
05920a43
GM
3535 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3536 not just in the obarray, before snarfing them. (Bug#11036)
3537
935396c0
GM
3538 * Makefile.in ($(leimdir)/leim-list.el):
3539 Pass EMACS rather than BUILT_EMACS.
3540
a18ecafa
TZ
35412012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3542
3543 * process.c (make_process):
3544 * process.h: Add integer `gnutls_handshakes_tried' member to
3545 process struct.
3546
6bbef4e5
JC
3547 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3548 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3549
3550 * gnutls.c (gnutls_log_function2i): Convenience log function.
3551 (emacs_gnutls_read): Use new log functions,
3552 `gnutls_handshakes_tried' process member, and
3553 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3554 attempts per process (connection).
3555
b4d3bc10
CY
35562012-04-09 Chong Yidong <cyd@gnu.org>
3557
3558 * eval.c (Fuser_variable_p, user_variable_p_eh)
3559 (lisp_indirect_variable): Functions deleted.
3560 (Fdefvar): Caller changed.
3561
3562 * callint.c (Finteractive, Fcall_interactively):
3563 * minibuf.c (Fread_variable): Callers changed.
3564
70f4d973
EZ
35652012-04-09 Eli Zaretskii <eliz@gnu.org>
3566
3567 * xdisp.c (set_cursor_from_row): If the display string appears in
3568 the buffer at position that is closer to point than the position
3569 after the display string, display the cursor on the first glyph of
3570 the display string. Fixes cursor display when a 'display' text
3571 property immediately follows invisible text. (Bug#11094)
3572
cb3c2e3e
PE
35732012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3574
3575 composite.c: use 'double' consistently
3576 * composite.c (get_composition_id): Use 'double' consistently
3577 instead of converting 'float' to 'double' and vice versa; this is
3578 easier to understand and avoids a GCC warning.
3579
fd06db5d
GM
35802012-04-09 Glenn Morris <rgm@gnu.org>
3581
50fe702a
GM
3582 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3583 preparation for dumping it with emacs. (Bug#4789)
3584 (leimdir): New variable.
3585 ($(leimdir)/leim-list.el): New rule.
3586 (emacs$(EXEEXT)): Depend on leim-list.el.
3587
fd06db5d
GM
3588 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3589 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3590 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3591
55c131ee
AS
35922012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3593
3594 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3595 proper alignment.
3596
9209588f
JB
35972012-04-07 Juanma Barranquero <lekktu@gmail.com>
3598
3599 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3600 Remove unused local variable.
3601
e3fb2efb
PE
36022012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3603
3604 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3605 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3606 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3607 objects, as mark_maybe_pointer will catch them otherwise.
3608 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3609 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3610
b5385551
PE
36112012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3612
3613 Fix typo that broke non-Windows builds.
3614 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3615
9078ead6
EZ
36162012-04-07 Eli Zaretskii <eliz@gnu.org>
3617
3618 Support building on MS-Windows with libxml2.
3619
3620 * makefile.w32-in (OBJ2): Add xml.$(O).
3621 (GLOBAL_SOURCES): Add xml.c.
3622 ($(BLD)/xml.$(O)): New dependency list.
3623
3624 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3625 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3626 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3627 [!WINDOWSNT]: New macros.
3628 (init_libxml2_functions, libxml2_loaded_p): New functions.
3629 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3630 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3631 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3632 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3633 linked in).
6bbef4e5
JC
3634 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3635 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3636 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3637
3638 * emacs.c: Don't include libxml/parser.h.
3639 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3640 xmlCleanupParser directly.
3641
3642 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3643
3811fdf3
EZ
36442012-04-07 Eli Zaretskii <eliz@gnu.org>
3645
3646 * indent.c (Fvertical_motion): If there is a display string at
3647 point, use it.vpos to compute how many lines to backtrack after
3648 move_it_to point. (Bug#11133)
3649
2f8e16b2
EZ
36502012-04-06 Eli Zaretskii <eliz@gnu.org>
3651
3652 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3653 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3654 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3655 macros related to unification of CJK characters. For the details,
3656 see the discussion following the message here:
3657 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3658
3d439cd1
CY
36592012-04-04 Chong Yidong <cyd@gnu.org>
3660
3661 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3662
8bc53d00
EZ
36632012-04-01 Eli Zaretskii <eliz@gnu.org>
3664
3665 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3666 instead of alloca. (Bug#11138)
3667
3b0512a3
AS
36682012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3669
3670 * w32menu.c (is_simple_dialog): Properly check lisp types.
3671 (Bug#11141)
3672
8427ddd2
EZ
36732012-03-31 Eli Zaretskii <eliz@gnu.org>
3674
979022ef
EZ
3675 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3676 position we get to after a call to move_it_to fails the
3677 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3678 only if we wind up in a string from display property. (Bug#11063)
3679
a6b1c7cc
EZ
3680 * window.c (Fdelete_other_windows_internal): Invalidate the row
3681 and column information about mouse highlight, so that redisplay
3682 restores it after reallocating the glyph matrices. (Bug#7464)
3683
8427ddd2
EZ
3684 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3685 string comes from a `display' text property, use the buffer
3686 position of that property as if we actually saw that position in
3687 the row's glyphs.
697ba24b
EZ
3688 (move_it_by_lines): Remove the assertion that
3689 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3690 violated when there's a before-string at the beginning of a line.
3691 (Bug#11063)
8427ddd2 3692
65a0a738
EZ
36932012-03-30 Eli Zaretskii <eliz@gnu.org>
3694
3695 * xdisp.c (append_space_for_newline): If the default face was
3696 remapped, use the remapped face for the appended newline.
3697 (extend_face_to_end_of_line): Use the remapped default face for
3698 extending the face to the end of the line.
3699 (display_line): Call extend_face_to_end_of_line when the default
3700 face was remapped. (Bug#11068)
3701
581355cc
EZ
37022012-03-29 Eli Zaretskii <eliz@gnu.org>
3703
3704 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3705
e8fc049f
SM
37062012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3707
3708 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3709
4fb9a543
GM
37102012-03-27 Glenn Morris <rgm@gnu.org>
3711
3712 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3713 Doc fixes.
3714
679910f1
KH
37152012-03-26 Kenichi Handa <handa@m17n.org>
3716
3717 * dispextern.h (struct glyph): Fix previous change. Change the
3718 bit length of glyphless.ch to 25 (Bug#11082).
3719
90d49b7f
CY
37202012-03-26 Chong Yidong <cyd@gnu.org>
3721
3722 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3723 (command_loop_1): Use it; inhibit selection update for
3724 handle-select-window too (Bug#8996).
3725
f514f6f0
FP
37262012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3727
e8fc049f 3728 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3729
bf43fa51
KH
37302012-03-25 Kenichi Handa <handa@m17n.org>
3731
3732 * dispextern.h (struct glyph): Change the bit length of
3733 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3734
8a0c01dd
EZ
37352012-03-24 Eli Zaretskii <eliz@gnu.org>
3736
3737 * s/ms-w32.h (tzname): Include time.h before redirecting to
3738 _tzname. Fixes the MSVC build. (Bug#9960)
3739
7d1c3a76
AS
37402012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3741
8ed79523
AS
3742 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3743 characters.
3744
7d1c3a76
AS
3745 * xterm.c (XTread_socket): Only modify handling_signal if
3746 !SYNC_INPUT. (Bug#11080)
3747
e99a9b8b
EZ
37482012-03-23 Eli Zaretskii <eliz@gnu.org>
3749
3750 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3751 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3752 when fetching a multibyte character consumes more bytes than
3753 CHAR_BYTES returns, due to unification of CJK characters in
3754 string_char. (Bug#11073)
3755
5063c0e1
TN
37562012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3757
3758 * process.c (wait_reading_process_output): Handle pty disconnect
3759 by refraining from sending oneself a SIGCHLD (bug#10933).
3760
9f851fbd
CY
37612012-03-22 Chong Yidong <cyd@gnu.org>
3762
3763 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3764
5063c0e1 3765 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3766 Mark string as coming from a prefix property.
3767 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3768 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3769
fb5b8aca
CY
37702012-03-21 Chong Yidong <cyd@gnu.org>
3771
3772 * xfaces.c (Vface_remapping_alist): Doc fix.
3773
62356a1b
EZ
37742012-03-20 Eli Zaretskii <eliz@gnu.org>
3775
3776 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3777 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3778 Doc fixes.
62356a1b 3779
025de85b
CY
37802012-03-20 Chong Yidong <cyd@gnu.org>
3781
3782 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3783 to reflect default non-nil value of redisplay-dont-pause.
3784
4827f94e
KH
37852012-03-19 Kenichi Handa <handa@m17n.org>
3786
3787 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3788 it fit in a valid range (Bug#11003).
3789
e50a24a2
EZ
37902012-03-18 Eli Zaretskii <eliz@gnu.org>
3791
3792 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3793 that is not from display property, accept the row as a "cursor
3794 row" if one of the string's character has a non-nil `cursor'
3795 property. Fixes cursor positioning when there are newlines in
3796 overlay strings, e.g. in icomplete.el. (Bug#11035)
3797
9af5ed87
PE
37982012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3799
3800 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3801
d1f55f16
CY
38022012-03-12 Chong Yidong <cyd@gnu.org>
3803
3804 * eval.c (inhibit_lisp_code): Rename from
3805 inhibit_window_configuration_change_hook; move from window.c.
3806
3807 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3808 * window.c (run_window_configuration_change_hook)
3809 (syms_of_window): Callers changed.
3810
66c5eebd
CY
38112012-03-11 Chong Yidong <cyd@gnu.org>
3812
413df973
CY
3813 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3814
66c5eebd
CY
3815 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3816
1de11f56
CY
38172012-03-10 Chong Yidong <cyd@gnu.org>
3818
3819 * frame.c (other_visible_frames): Don't assume the selected frame
3820 is visible (Bug#10955).
3821
cae07000
SM
38222012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3823
3824 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3825
89c94350
JD
38262012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3827
3828 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3829 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3830 zero (Bug#10954).
3831
999dd333
GM
38322012-03-03 Glenn Morris <rgm@gnu.org>
3833
01a6dcc8 3834 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3835
de0100f2
EZ
38362012-03-02 Eli Zaretskii <eliz@gnu.org>
3837
3838 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3839 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3840 (redisplay_window, next_element_from_string): Fix typos in
3841 comments.
3e441275
EZ
3842 (redisplay_window): Pass to move_it_vertically the margin in
3843 pixels, not in screen lines.
de0100f2 3844
96a72ee9
GM
38452012-03-02 Glenn Morris <rgm@gnu.org>
3846
3847 * buffer.c (buffer-list-update-hook): Doc fix.
3848
312508d7
EZ
38492012-02-29 Eli Zaretskii <eliz@gnu.org>
3850
3851 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3852 push_it before setting up the iterator for the first overlay
3853 string, even if we have an empty string loaded.
3854 (next_overlay_string): If there's an empty string on the iterator
3855 stack, pop the stack. (Bug#10903)
3856
27f3c637
PE
38572012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3858
3859 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3860 Suggested by Stefan Monnier in
3861 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3862 * alloc.c (widen_to_Lisp_Object): New static function.
3863 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3864 and widening them to Lisp_Objects. This would work even if
3865 USE_LSB_TAG is defined and wide integers are used, which might
3866 happen in a future version of Emacs.
3867
3c9dfce6
CY
38682012-02-25 Chong Yidong <cyd@gnu.org>
3869
fa74b241
CY
3870 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3871 Doc fix.
3872
3c9dfce6
CY
3873 * xselect.c (Fx_selection_exists_p): Doc fix.
3874 (x_clipboard_manager_save_all): Print an informative message
3875 before saving to clipboard manager.
3876
9486df08
CY
38772012-02-24 Chong Yidong <cyd@gnu.org>
3878
3879 * keyboard.c (process_special_events): Handle all X selection
3880 requests in kbd_buffer, not just the next one (Bug#8869).
3881
f01d3321
CY
38822012-02-23 Chong Yidong <cyd@gnu.org>
3883
3884 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3885 call when setting menu-bar-lines and tool-bar-lines parameters.
3886 (unwind_create_frame_1): New helper function.
3887
3888 * window.c (inhibit_window_configuration_change_hook): New var.
3889 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3890 (syms_of_window): Initialize it.
f01d3321 3891
86b847b6
CY
38922012-02-22 Chong Yidong <cyd@gnu.org>
3893
3894 * xterm.c (x_draw_image_relief): Add missing type check for
3895 Vtool_bar_button_margin (Bug#10743).
3896
a59225b1
CY
38972012-02-21 Chong Yidong <cyd@gnu.org>
3898
3899 * fileio.c (Vfile_name_handler_alist): Doc fix.
3900
3901 * buffer.c (Fget_file_buffer): Protect against invalid file
3902 handler return value.
3903
310f5bd4
PE
39042012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3905
cb3a28cc
PE
3906 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3907 when computing $valmask.
3908
310f5bd4
PE
3909 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3910 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3911 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3912 It's useless in that case, and it can cause problems on hosts
3913 that allocate halves of EMACS_INT values separately.
3914 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3915 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3916 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3917 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3918 it avoids undefined behavior on hosts where shifting right by more
3919 than the word width has undefined behavior.
3920
2375c96a
CY
39212012-02-19 Chong Yidong <cyd@gnu.org>
3922
3923 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3924 (Funhandled_file_name_directory, Ffile_name_as_directory)
3925 (Fdirectory_file_name, Fexpand_file_name)
3926 (Fsubstitute_in_file_name): Protect against invalid file handler
3927 return values (Bug#10845).
3928
3eb49e71
EZ
39292012-02-18 Eli Zaretskii <eliz@gnu.org>
3930
3931 * .gdbinit (pitx): Fix incorrect references to fields of the
3932 iterator stack.
3933
7b926f3f
CY
39342012-02-17 Chong Yidong <cyd@gnu.org>
3935
3936 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3937
11273115
PE
39382012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3939
3940 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3941 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3942
c3a70e2b
CY
39432012-02-15 Chong Yidong <cyd@gnu.org>
3944
3945 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3946 marked as special. Also, starting docstrings with * is obsolete.
3947
0ca43699
AS
39482012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3949
3950 * gnutls.c (emacs_gnutls_write): Fix last change.
3951
2e8f3c56
LI
39522012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3953
3954 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3955 send_process.
3956
af70074f
SM
39572012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3958
3959 * keymap.c (Fsingle_key_description): Handle char ranges.
3960
95986d52
CY
39612012-02-12 Chong Yidong <cyd@gnu.org>
3962
afd83bd1
CY
3963 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3964 as that creates a dangerous corner case.
3965
95986d52
CY
3966 * window.c (Fdelete_window_internal): Invalidate the mouse
3967 highlight (Bug#9904).
3968
bd7da63e
GM
39692012-02-12 Glenn Morris <rgm@gnu.org>
3970
3971 * xselect.c (Fx_own_selection_internal)
3972 (Fx_get_selection_internal, Fx_disown_selection_internal)
3973 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3974 * nsselect.m (Fx_own_selection_internal)
3975 (Fx_disown_selection_internal, Fx_selection_exists_p)
3976 (Fx_selection_owner_p, Fx_get_selection_internal):
3977 Sync docs and argument specs with the xselect.c versions.
3978
77abcbc2
LI
39792012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3980
3981 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3982
90b671e2
EZ
39832012-02-11 Eli Zaretskii <eliz@gnu.org>
3984
1c0ca0b7
EZ
3985 * w32select.c (Fx_selection_exists_p): Sync doc string and
3986 argument list with xselect.c. (Bug#10783)
3987
3988 * w16select.c (Fx_selection_exists_p): Sync doc string and
3989 argument list with xselect.c. (Bug#10783)
90b671e2 3990
49241268
GM
39912012-02-10 Glenn Morris <rgm@gnu.org>
3992
3993 * fns.c (Fsecure_hash): Doc fix.
3994
f998bbe7 39952012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3996
3997 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3998
0992bd9c
CY
39992012-02-07 Chong Yidong <cyd@gnu.org>
4000
4001 * buffer.c (Fbuffer_local_variables)
4002 (buffer_lisp_local_variables): Handle unbound vars correctly;
4003 don't let Qunbound leak into Lisp.
4004
af008560
GM
40052012-02-07 Glenn Morris <rgm@gnu.org>
4006
dd605cc4
GM
4007 * image.c (Fimagemagick_types): Doc fix.
4008
af008560
GM
4009 * image.c (imagemagick-render-type): Change it from a lisp object
4010 to an integer. Move the doc here from the lisp manual.
4011 Treat all values not equal to 0 the same.
4012
1449fa1d
CY
40132012-02-06 Chong Yidong <cyd@gnu.org>
4014
4015 * doc.c (store_function_docstring): Avoid applying docstring of
4016 alias to base function (Bug#2603).
4017
3723ec07
AS
40182012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4019
4020 * .gdbinit (pp1, pv1): Remove redundant defines.
4021 (pr): Use pp.
4022
79c1cc1e
CY
40232012-02-04 Chong Yidong <cyd@gnu.org>
4024
4025 * nsterm.m: Declare a global (Bug#10694).
4026
d7f29f8e
EZ
40272012-02-04 Eli Zaretskii <eliz@gnu.org>
4028
cae07000
SM
4029 * w32.c (get_emacs_configuration_options):
4030 Include --enable-checking, if specified, in the return value.
d7f29f8e 4031
3b95a6f9
MR
40322012-02-04 Martin Rudalics <rudalics@gmx.at>
4033
4034 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4035 after rounding frame sizes. (Bug#9723)
4036
d6fa96a6
EZ
40372012-02-04 Eli Zaretskii <eliz@gnu.org>
4038
4039 * keyboard.c (adjust_point_for_property): Don't position point
4040 before BEGV. (Bug#10696)
4041
df0b2940
PE
40422012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4043
4044 Handle overflow when computing char display width (Bug#9496).
4045 * character.c (char_width): Return EMACS_INT, not int.
4046 (char_width, c_string_width): Check for overflow when
4047 computing the width; this is possible now that individual
4048 characters can have unbounded width. Problem introduced
4049 by merge from Emacs 23 on 2012-01-19.
4050
6bee44d6
MA
40512012-02-02 Michael Albinus <michael.albinus@gmx.de>
4052
4053 * dbusbind.c (Fdbus_register_method): Mention the return value
4054 :ignore in the docstring.
4055
44f92739
GM
40562012-02-02 Glenn Morris <rgm@gnu.org>
4057
1b9f60cc
GM
4058 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4059
44f92739
GM
4060 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4061 Unconditionally set to t. (Bug#10673)
4062 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4063 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4064 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4065
c5d3843c
KH
40662012-02-02 Kenichi Handa <handa@m17n.org>
4067
4068 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4069 0, do not call append_composite_glyph.
4070
159462d4 40712012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4072
4073 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4074 NULL (Bug#6988).
4075 (x_produce_glyphs): If the component of a composition is a null
4076 string, set it->pixel_width to 1 to avoid zero-width glyph.
4077
78cef877
EZ
40782012-02-01 Eli Zaretskii <eliz@gnu.org>
4079
4080 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4081 first 2 arguments are identical. This makes inserting large
4082 output from a subprocess an order of magnitude faster on
4083 MS-Windows, where all sbrk'ed memory is always contiguous.
4084
97897668
GM
40852012-01-31 Glenn Morris <rgm@gnu.org>
4086
4087 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4088 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4089 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4090
31fd3586
GM
40912012-01-29 Glenn Morris <rgm@gnu.org>
4092
4093 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4094
0e24a8b2
CY
40952012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4096
4097 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4098
cc0adcb0
CY
40992012-01-28 Chong Yidong <cyd@gnu.org>
4100
4101 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4102
acc28cb9
CY
41032012-01-26 Chong Yidong <cyd@gnu.org>
4104
9c69cfb7
CY
4105 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4106
acc28cb9
CY
4107 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4108 repeat counts (Bug#10507).
4109
48da7392
GM
41102012-01-26 Glenn Morris <rgm@gnu.org>
4111
4112 * lread.c (syms_of_lread): Doc fix.
4113
14af5f7f
CY
41142012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4115
4116 * coding.c (encode_designation_at_bol): Change return value to
4117 EMACS_INT.
4118
0b21c100
CY
41192012-01-25 Chong Yidong <cyd@gnu.org>
4120
4121 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4122
3c2907f7
CY
41232012-01-21 Chong Yidong <cyd@gnu.org>
4124
4125 * floatfns.c (Fcopysign): Make the second argument non-optional,
4126 since nil is not allowed anyway.
4127
959ad23f
AS
41282012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4129
4130 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4131 (send_process): Likewise.
4132
34a02f46
MR
41332012-01-19 Martin Rudalics <rudalics@gmx.at>
4134
4135 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4136 (Vwindow_persistent_parameters): Do not use Qstate.
4137 Rewrite doc-strings.
34a02f46 4138
1259009a 41392012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4140
4141 * character.c (char_width): New function.
70d4fdf6
GM
4142 (Fchar_width, c_string_width, lisp_string_width):
4143 Use char_width (Bug#9496).
25ed9e61 4144
6a6ee00d
MR
41452012-01-16 Martin Rudalics <rudalics@gmx.at>
4146
4147 * window.c (Vwindow_persistent_parameters): New variable.
4148 (Fset_window_configuration, save_window_save): Handle persistent
4149 window parameters.
4150
c85efaf7
EZ
41512012-01-14 Eli Zaretskii <eliz@gnu.org>
4152
4153 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4154 thrashing the stack of the thread. (Bug#9087)
4155
5944709e
PE
41562012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4157
4158 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4159
e71f5d99
EZ
41602012-01-11 Eli Zaretskii <eliz@gnu.org>
4161
4162 * xdisp.c (rows_from_pos_range): Handle the case where the
4163 highlight ends on a newline. (Bug#10464)
4164 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4165 he end column for display of highlight that ends on a newline
4166 before a R2L line.
4167
ce316182
GM
41682012-01-11 Glenn Morris <rgm@gnu.org>
4169
4170 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4171 from load-path also when installation-directory is nil. (Bug#10208)
4172
5b43da69
GM
41732012-01-10 Glenn Morris <rgm@gnu.org>
4174
74cc8ff9
GM
4175 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4176
7d8d6e4e
GM
4177 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4178 Update template values to be closer to their typical values these days.
5b43da69 4179
a0db8d43
EZ
41802012-01-09 Eli Zaretskii <eliz@gnu.org>
4181
4182 * xdisp.c (rows_from_pos_range): Accept additional argument
4183 DISP_STRING, and accept any glyph in a row whose object is that
4184 string as eligible for mouse highlight. Fixes mouse highlight of
4185 display strings from overlays. (Bug#10464)
4186
9a0115ab 41872012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4188
b9110d6a 4189 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4190 * fileio.c (auto_saving_dir_umask): New static var.
4191 (Fmake_directory_internal): Use it.
4192 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4193 creating the directory. The old code temporarily assigns
4194 too-generous permissions to the directory.
4195 (do_auto_save_eh): Clear it.
b9110d6a 4196 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4197 that the var is always cleared.
4198
6c1bd3f3
EZ
41992012-01-07 Eli Zaretskii <eliz@gnu.org>
4200
4201 * search.c (scan_buffer): Pass character positions to
4202 know_region_cache, not byte positions. (Bug#6540)
4203
069d2b50
L
42042012-01-07 LynX <_LynX@bk.ru> (tiny change)
4205
4206 * w32.c (sys_rename): Report EXDEV when rename of a directory
4207 fails because the target is on another logical disk. (Bug#10284)
4208
75bf0d33
DB
42092012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4210
4211 * xterm.c (x_embed_request_focus): New function.
4212
4213 * xterm.h: Add prototype.
4214
4215 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4216
1c6e5a32
GM
42172012-01-05 Glenn Morris <rgm@gnu.org>
4218
4219 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4220
651e947e
EZ
42212012-01-01 Eli Zaretskii <eliz@gnu.org>
4222
4223 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4224 Load gnutls_transport_set_lowat only if GnuTLS version is below
4225 2.11.1.
4226 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4227 GnuTLS versions below 2.11.1.
4228
3778cdd8
AL
42292011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4230
4231 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4232 to the doc string advising against its use for altering the way
4233 windows are scrolled.
4234
0e5317f7
KH
42352011-12-28 Kenichi Handa <handa@m17n.org>
4236
4237 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4238 coding-system ASCII compatible only when it does not produce BOM
4239 on encoding (Bug#10383).
4240
93d5ca1f
JD
42412011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4242
4243 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4244 can scroll.
4245 (create_and_show_popup_menu): Always use menu_position_func for
4246 Gtk3 (Bug#10361).
4247
ca22b785
AS
42482011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4249
4250 * callint.c (Fcall_interactively): Don't truncate prompt string.
4251
d048e1e6
EZ
42522011-12-23 Eli Zaretskii <eliz@gnu.org>
4253
4254 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4255 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4256 resumed from there (after widening). (Bug#10360)
d048e1e6 4257
5ccaba1f
JD
42582011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4259
4260 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4261
204ee57f
JD
42622011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4263
b81d40f0
JB
4264 * nsterm.m (x_free_frame_resources):
4265 Release f->output_data.ns->miniimage.
204ee57f
JD
4266 (ns_index_color): Fix indentation. Do not retain
4267 color_table->colors[i].
4268
4269 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4270 before returning.
4271
4272 * nsfns.m (x_set_background_color): Assign return value from
4273 ns_index_color to face-background instead of NSColor*.
4274 (ns_implicitly_set_icon_type): Fix indentation.
4275 Change assignment in for loop to comparison.
4276
4277 * emacs.c (ns_pool): New variable.
4278 (main): Assign ns_pool.
4279 (Fkill_emacs): Call ns_release_autorelease_pool.
4280
4281 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4282 autorelease fdesc, release fdAttrs and tdict.
4283 (ns_get_covering_families): Release charset.
4284 (ns_findfonts): Release NSFontDescriptor created with new.
4285 (ns_uni_to_glyphs): Fix indentation.
4286 (setString): Release attrStr before assigning new value.
4287
c803b2b7
JD
42882011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4289
678f4426
JD
4290 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4291 and NS_IMPL_COCOA.
4292 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4293 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4294
cd394be1 42952011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4296
5fecd5fc
JD
4297 * nsterm.m (ns_term_init): Subscribe for notifications
4298 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4299 to method trackingNotification in EmacsMenu.
4300
4301 * nsmenu.m (trackingMenu): New variable.
3771cb17 4302 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4303 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4304 from Aquamacs (Bug#7030).
678f4426
JD
4305
43062011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4307
c803b2b7
JD
4308 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4309 (symbol_to_nsstring): Fix indentation.
4310 (ns_symbol_to_pb): New function.
cae07000
SM
4311 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4312 (Fns_rotate_cut_buffers_internal): Remove.
4313 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4314 Fns_store_cut_buffer_internal.
4315 (ns_get_foreign_selection, Fx_own_selection_internal)
4316 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4317 (Fns_get_selection_internal, Fns_store_selection_internal):
4318 Use ns_symbol_to_pb and check if return value is nil.
4319 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4320 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4321 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4322 renamed to Sns_store_selection_internal.
4323 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4324 and remove this function.
4325 (ns_handle_selection_clear): Remove, never used.
4326 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4327 here.
4328
e1b01a3a
KB
43292011-12-17 Ken Brown <kbrown@cornell.edu>
4330
4331 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4332 GID is unknown (Bug#10257).
4333
2adb6e85
PE
43342011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4335
4336 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4337 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4338 which caused a build failure on GNU/Linux IA-64. This problem was
4339 introduced by my 2011-10-07 patch.
4340
d1d7b339
JL
43412011-12-15 Juri Linkov <juri@jurta.org>
4342
4343 * image.c (imagemagick_error): New function. (Bug#10112)
4344 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4345 Use `imagemagick_error' where ImageMagick functions return
4346 `MagickFalse'.
4347 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4348 proper order.
4349
100d5755
KH
43502011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4351
4352 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4353 fill background (Bug#8992).
4354
454592a6
MR
43552011-12-13 Martin Rudalics <rudalics@gmx.at>
4356
4357 * window.c (Vwindow_combination_resize)
4358 (Vwindow_combination_limit): Use t instead of non-nil in
4359 doc-strings.
61d4b438
MR
4360 (Vrecenter_redisplay): Add first sentence of doc-string on
4361 separate line.
53524d93 4362 (Frecenter): Fix doc-string typo.
454592a6 4363
3633e3aa
KH
43642011-12-11 Kenichi Handa <handa@m17n.org>
4365
4366 * coding.c (Funencodable_char_position): Pay attention to the
4367 buffer text relocation (Bug#9389).
4368
7b9d523a 43692011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4370
7b9d523a
JD
4371 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4372 gtk_init (Bug#10100).
4373
b73189c6
EZ
43742011-12-10 Eli Zaretskii <eliz@gnu.org>
4375
4376 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4377 IT->string is nil. (Bug#10263)
4378
f7dfe5d6
JD
43792011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4380
83faebb4
JD
4381 * nsterm.h (x_free_frame_resources): Declare.
4382
f7dfe5d6
JD
4383 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4384 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4385
4386 * nsterm.h (ns_get_defaults_value): Declare.
4387
4388 * nsterm.m (ns_default): Call ns_get_defaults_value.
4389
7cd4e72c
EZ
43902011-12-09 Eli Zaretskii <eliz@gnu.org>
4391
4392 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4393 (Bug#10170)
4394
b34d7317
YM
43952011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4396
4397 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4398 that where the value of an _OBJC_* symbol points to is in the .bss
4399 section (Bug#10240).
4400
76470ad1
KH
44012011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4402
4403 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4404 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4405
745fff94
KH
44062011-12-08 Kenichi Handa <handa@m17n.org>
4407
4408 * ftfont.c (get_adstyle_property): Fix previous change
4409 (Bug#10233).
4410
6e44397c
JB
44112011-12-07 Juanma Barranquero <lekktu@gmail.com>
4412
4413 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4414 dirs from the default value of EMACSLOADPATH (bug#10208).
4415
7efa6272
GM
44162011-12-07 Glenn Morris <rgm@gnu.org>
4417
4418 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4419 installation and source directories as well. (Bug#10208)
4420
f6fc4d87
CY
44212011-12-06 Chong Yidong <cyd@gnu.org>
4422
4423 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4424
2bf26180
GM
44252011-12-06 Glenn Morris <rgm@gnu.org>
4426
4427 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4428 as an error, not just -1. (Bug#10217)
4429
3a6ad4f0
CY
44302011-12-05 Chong Yidong <cyd@gnu.org>
4431
4432 * keyboard.c (process_special_events): New function.
4433 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4434
75a3b399
PE
44352011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4436
4437 * coding.c (encode_designation_at_bol): Don't use uninitialized
4438 local variable (Bug#9318).
4439
c3c9e25e
KH
44402011-12-05 Kenichi Handa <handa@m17n.org>
4441
4442 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4443 return Qnil (Bug#8046, Bug#10193).
4444
5eb05ea3
KH
44452011-12-05 Kenichi Handa <handa@m17n.org>
4446
4447 * coding.c (encode_designation_at_bol): New args charbuf_end and
4448 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4449 (coding_set_source): Return how many bytes coding->source was
4450 relocated.
4451 (coding_set_destination): Return how many bytes
4452 coding->destination was relocated.
4453 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4454 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4455
44562011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4457
4458 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4459 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4460 macro (Bug#9318).
4461
44622011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4463
4464 The following changes are to fix Bug#9318.
4465
a79703f5 4466 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4467 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4468 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4469 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4470
7dbda6df
JB
44712011-12-05 Juanma Barranquero <lekktu@gmail.com>
4472
4473 * lisp.h (process_quit_flag): Fix external declaration.
4474
6d5eb5b0
SM
44752011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4476
4477 Don't macro-inline non-performance-critical code.
4478 * eval.c (process_quit_flag): New function.
4479 * lisp.h (QUIT): Use it.
4480
a0c3fad0
JD
44812011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4482
4483 * nsfns.m (get_geometry_from_preferences): New function.
4484 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4485
6c07aac2
AS
44862011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4487
4488 * emacs.c (Qkill_emacs): Define.
4489 (syms_of_emacs): Initialize it.
4490 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4491 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4492 (quit_throw_to_read_char): Add parameter `from_signal'.
4493 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4494 * lisp.h (QUIT): Call Fkill_emacs if requested.
4495
c052ead4
JD
44962011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4497
4498 * widget.c (update_wm_hints): Return if wmshell is null.
4499 (widget_update_wm_size_hints): New function.
4500
4501 * widget.h (widget_update_wm_size_hints): Declare.
4502
4503 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4504 widget_update_wm_size_hints (Bug#10104).
4505
9e49252b
EZ
45062011-12-03 Eli Zaretskii <eliz@gnu.org>
4507
4508 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4509 before a newline, prepare the bidi iterator for consuming the
4510 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4511 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4512
02b16839
JL
45132011-12-02 Juri Linkov <juri@jurta.org>
4514
4515 * search.c (Fword_search_regexp): New Lisp function created from
4516 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4517 (Fword_search_backward, Fword_search_forward)
4518 (Fword_search_backward_lax, Fword_search_forward_lax):
4519 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4520 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4521
0068070e
SM
45222011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4523
4524 * fileio.c (Finsert_file_contents): Move after-change-function call
4525 to before the "handled:" label, since all "goto handled" appear in
4526 cases where the *-change-functions have already been properly called
4527 (bug#10117).
4528
3360a3fc
AS
45292011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4530
4531 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4532 waiting for input. (Bug#10169)
4533
73d6c093
EZ
45342011-11-30 Eli Zaretskii <eliz@gnu.org>
4535
4536 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4537 verifies glyph row's hash code--we have just reallocated the
4538 glyphs, so their contents can be complete garbage. (Bug#10164)
4539
febe6bea
JB
45402011-11-30 Juanma Barranquero <lekktu@gmail.com>
4541
4542 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4543
801a4313
EZ
45442011-11-30 Eli Zaretskii <eliz@gnu.org>
4545
4546 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4547 attributes are tested _before_ calling verify_row_hash, to protect
4548 against GCC re-ordering of the tests. (Bug#10164)
4549
2b56b87e
JD
45502011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4551
4552 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4553
4554 * xterm.c (handle_one_xevent): Only set async_visible and friends
4555 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4556 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4557 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4558
dbf31225
PE
45592011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4560
4561 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4562 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4563 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4564 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4565 All uses changed to use GCPRO1 etc.
4566 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4567 Revert to old implementation (i.e., before 2011-03-11).
4568
1305621b
YM
45692011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4570
4571 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4572 of scroll runs so as to avoid assigning disabled bogus rows and
4573 unnecessary graphics copy operations.
4574
8c9afb46
EZ
45752011-11-27 Eli Zaretskii <eliz@gnu.org>
4576
4577 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4578 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4579 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4580 (malloc, free, realloc, calloc): Redirect to e_* only when
4581 compiling Emacs.
4582
4583 * lisp.h (GCTYPEBITS): Move before first use.
4584 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4585 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4586 this macro definition.
4587
4588 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4589 _MSC_VER.
4590
54e9e3bf
JD
45912011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4592
6d5eb5b0
SM
4593 * gtkutil.c (xg_create_frame_widgets):
4594 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4595 present with Gtk+ 2.0.
4596
83aca1cb
PE
45972011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4598
4599 * fileio.c (Finsert_file_contents): Undo previous change; see
4600 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4601
5b76caa4
PE
46022011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4603
4604 Rename locals to avoid shadowing.
4605 * fileio.c (Finsert_file_contents):
4606 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4607 * process.c (wait_reading_process_output):
4608 Rename inner 'proc' to 'p' to avoid shadowing.
4609 Indent for consistency with usual Emacs style.
4610
8c535114
EZ
46112011-11-25 Eli Zaretskii <eliz@gnu.org>
4612
4613 * xdisp.c (redisplay_window): If cursor row is not fully visible
4614 after recentering, and scroll-conservatively is set to a large
4615 number, scroll window by a few more lines to make the cursor fully
4616 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4617 (start_display): Don't move to the next line if the display should
4618 start at a newline that is part of a display vector or an overlay
4619 string. (Bug#10119)
8c535114 4620
fa4fdb5c
JL
46212011-11-24 Juri Linkov <juri@jurta.org>
4622
4623 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4624 after the `MagickPingImage' call. (Bug#10112)
4625
90ec88df
CY
46262011-11-23 Chong Yidong <cyd@gnu.org>
4627
4628 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4629
56e2e794
MR
46302011-11-23 Martin Rudalics <rudalics@gmx.at>
4631
4632 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4633 making another buffer current. (Bug#10114)
4634
b6e64c41
GM
46352011-11-23 Glenn Morris <rgm@gnu.org>
4636
4637 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4638
6b21de18
CY
46392011-11-23 Chong Yidong <cyd@gnu.org>
4640
4641 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4642 using it (Bug#5984).
4643
b12cd789
EZ
46442011-11-22 Eli Zaretskii <eliz@gnu.org>
4645
4646 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4647 and header-lines, as they don't have one computed for them.
4648 (Bug#10098)
4649
4650 * .gdbinit (prow): Make displayed values more self-explaining.
4651 Add row's hash code.
4652
261b6fd4
LMI
46532011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4654
4655 * process.c (wait_reading_process_output): Fix asynchrounous
4656 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4657 (wait_reading_process_output): Add comment and URL.
261b6fd4 4658
e7cfd277
JD
46592011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4660
4661 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4662
a9b9b7f5
CY
46632011-11-21 Chong Yidong <cyd@gnu.org>
4664
4665 * window.c (Fnext_window, Fprevious_window): Doc fix.
4666
b0d15b4f
SM
46672011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4668
4669 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4670
fe7a3057
JB
46712011-11-20 Juanma Barranquero <lekktu@gmail.com>
4672
4673 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4674
d2999b1a
MR
46752011-11-20 Martin Rudalics <rudalics@gmx.at>
4676
4677 * window.c (Fset_window_combination_limit): Rename argument
4678 STATUS to LIMIT.
4679 (Vwindow_combination_limit): Remove "status" from doc-string.
4680
d5ff9cd0
AS
46812011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4682
4683 * m/ibms390.h: Remove.
4684 * m/ibms390x.h: Don't include "ibms390.h".
4685
a5bb9bd3
SM
46862011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4687
4688 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4689 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4690
cd1181db
JB
46912011-11-20 Juanma Barranquero <lekktu@gmail.com>
4692
4693 * casetab.c (Fset_case_table):
4694 * charset.c (Fcharset_after): Fix typos.
4695
615a3b8d 46962011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4697
17e845af
PE
4698 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4699 Otherwise, valgrind does not work on some platforms.
4700 Problem reported by Andreas Schwab in
6a0bf43d
PE
4701 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4702 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4703 is set, removing the need for VIRT_ADDRESS_VARIES.
4704 (PURE_P): Use a more-efficient implementation that needs just one
4705 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4706 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4707 to 4 (xorl, subq, cmpq, setbe).
4708 * alloc.c (pure): Always extern now, since that's the
4709 VIRT_ADDR_VARIES behavior.
4710 (PURE_POINTER_P): Use a single comparison, not two, for
4711 consistency with the new puresize.h.
4712 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4713 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4714 Remove VIRT_ADDR_VARIES no longer needed.
4715
f8fe6f96
EZ
47162011-11-19 Eli Zaretskii <eliz@gnu.org>
4717
4718 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4719 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4720 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4721 behave as if the cursor position were at the window margin.
4722
4723 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4724 and the cursor position is out of bounds, behave as if the cursor
4725 position were at the window margin. (Bug#10075)
4726
df05a53c
CY
47272011-11-18 Chong Yidong <cyd@gnu.org>
4728
4729 * window.c (Fwindow_combination_limit): Make first argument
4730 non-optional, since it is meaningless for live windows like the
4731 selected window.
61ccba97 4732
2071918e
DA
47332011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4734
4735 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4736
b50a28de
SM
47372011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4738
4739 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4740 (graft_intervals_into_buffer): Simplify.
4741
015137db
EZ
47422011-11-18 Eli Zaretskii <eliz@gnu.org>
4743
4744 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4745 hash values of the two rows.
4746 (copy_row_except_pointers): Preserve the used[] arrays and the
4747 hash values of the two rows. (Bug#10035)
68c95424 4748 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4749
4750 * xdisp.c (row_hash): New function, body extracted from
4751 compute_line_metrics.
4752 (compute_line_metrics): Call row_hash, instead of computing the
4753 hash code inline.
4754
4755 * dispnew.c (verify_row_hash): Call row_hash for computing the
4756 hash code of a row, instead of duplicating code from xdisp.c.
4757
4758 * dispextern.h (row_hash): Add prototype.
4759
a2addb04
TH
47602011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4761
4762 * frame.c (delete_frame): Don't delete the terminal when the last
4763 X frame is closed if emacs is built with GTK toolkit.
4764
df85d315
JB
47652011-11-17 Juanma Barranquero <lekktu@gmail.com>
4766
4767 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4768
a0c2d0ae
MR
47692011-11-17 Martin Rudalics <rudalics@gmx.at>
4770
4771 * window.c (Vwindow_splits): Rename to
4772 Vwindow_combination_resize. Suggested by Juri Linkov.
4773 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4774 of Vwindow_splits.
4775
58179cce
JB
47762011-11-16 Juanma Barranquero <lekktu@gmail.com>
4777
7877f373
JB
4778 * nsfns.m (Fns_font_name):
4779 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4780
b6f67890
MR
47812011-11-16 Martin Rudalics <rudalics@gmx.at>
4782
4783 * window.h (window): Rename slot "nest" to "combination_limit".
4784 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4785 (Fset_window_nest): Rename to Fset_window_combination_limit.
4786 (Vwindow_nest): Rename to Vwindow_combination_limit.
4787 (recombine_windows, make_parent_window, make_window)
4788 (Fsplit_window_internal, saved_window)
4789 (Fset_window_configuration, save_window_save): Rename all
4790 occurrences of window_nest to window_combination_limit.
4791
c7015153
JB
47922011-11-15 Juanma Barranquero <lekktu@gmail.com>
4793
4794 * image.c (imagemagick_load_image): Fix typo.
4795
322ad6ec
EZ
47962011-11-14 Eli Zaretskii <eliz@gnu.org>
4797
4798 * xdisp.c (display_line): Move the call to
4799 highlight_trailing_whitespace before the call to
4800 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4801 faces of all the glyphs to compute ROW's hash value.
4802 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4803
f067b8ec
JB
48042011-11-14 Juanma Barranquero <lekktu@gmail.com>
4805
4806 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4807 just return (bug#10044).
4808
1e5b2111
EZ
48092011-11-12 Eli Zaretskii <eliz@gnu.org>
4810
7ef3cbd5
EZ
4811 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4812 with user-defined heap size. Bump the default size of the temacs
4813 heap to 27MB, to avoid memory warning when running temacs.
4814 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4815
1e5b2111
EZ
4816 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4817 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4818 (verify_row_hash) [XASSERTS]: New function.
4819 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4820 that the hash value of glyph rows is correct.
1e5b2111 4821
89d61221
MR
48222011-11-12 Martin Rudalics <rudalics@gmx.at>
4823
4824 * window.h (window): Remove splits slot.
4825 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4826 (Fdelete_other_windows_internal, make_parent_window)
4827 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4828 (Fset_window_configuration, save_window_save): Don't deal with
4829 split status of windows.
4830 (saved_window): Remove splits slot.
4831 (Vwindow_splits): Rewrite doc-string.
4832
97f18cc8
JD
48332011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4834
4835 * xfns.c (unwind_create_frame):
4836 * nsfns.m (unwind_create_frame):
4837 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4838 Vframe_list (Bug#9999).
4839
22a648b4
DA
48402011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4841
0b381c7e 4842 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4843
659afede
KH
48442011-11-11 Kenichi Handa <handa@m17n.org>
4845
4846 * callproc.c (Fcall_process): Set the member dst_multibyte of
4847 process_coding.
4848
9ac0394b
KH
48492011-11-11 Johan Bockgård <bojohan@gnu.org>
4850
4851 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4852 avoid a crash (bug#9496).
4853
2fbdc249
CY
48542011-11-09 Chong Yidong <cyd@gnu.org>
4855
4856 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4857 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4858
ac6b1f81
PE
48592011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4860
4861 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4862
09db192c
PE
48632011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4864
4865 Avoid some portability problems by eschewing 'extern inline' functions.
4866 The trivial performance wins aren't worth the portability hassles; see
4867 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4868 et seq.
4869 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4870 (window_box_width, window_box_left, window_box_left_offset)
4871 (window_box_right, window_box_right_offset): Undo previous change,
4872 by removing the "extern"s.
4873 * intervals.c (adjust_intervals_for_insertion)
4874 (adjust_intervals_for_deletion): Undo previous change,
4875 making these static again.
4876 (offset_intervals, temp_set_point_both, temp_set_point)
4877 (copy_intervals_to_string): No longer inline.
4878 * xdisp.c (window_text_bottom_y, window_box_width)
4879 (window_box_height, window_box_left_offset)
4880 (window_box_right_offset, window_box_left, window_box_right)
4881 (window_box): No longer inline.
4882
105216ed
CY
48832011-11-08 Chong Yidong <cyd@gnu.org>
4884
4885 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4886 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4887 Signal an error if not a live window.
105216ed
CY
4888 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4889 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4890
ae9e237f
JB
48912011-11-07 Juanma Barranquero <lekktu@gmail.com>
4892
4893 * lisp.h (syms_of_abbrev): Remove declaration.
4894 Reported by CHENG Gao <chenggao@royau.me>.
4895
c7aa8333
EZ
48962011-11-07 Eli Zaretskii <eliz@gnu.org>
4897
4898 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4899 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4900 of temacs in GUI mode.
4901
be7f5545
MR
49022011-11-07 Martin Rudalics <rudalics@gmx.at>
4903
4904 * window.h: Declare delete_all_child_windows instead of
4905 delete_all_subwindows.
4906 * window.c (Fwindow_nest, Fset_window_nest)
4907 (Fset_window_new_total, Fset_window_new_normal)
4908 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4909 (delete_all_subwindows): Rename to delete_all_child_windows.
4910 (Fdelete_other_windows_internal, Fset_window_configuration):
4911 Call delete_all_child_windows instead of delete_all_subwindows.
4912 * frame.c (delete_frame): Call delete_all_child_windows instead
4913 of delete_all_subwindows.
4914
ca78dc43
PE
49152011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4916
4917 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4918 This is also needed for porting to any host where GC_MARK_STACK is
4919 not GC_MAKE_GCPROS_NOOPS.
4920 (which_symbols): Use it.
4921
a0241d01
KH
49222011-11-07 Kenichi Handa <handa@m17n.org>
4923
4924 * coding.c (coding_set_destination): Check coding->src_pos only
4925 when coding->src_object is a buffer (bug#9910).
4926
4927 * process.c (send_process): Set the member src_multibyte of coding
4928 to 0 (bug#9911) when sending a unibyte text.
4929
4930 * callproc.c (Fcall_process): Set the member src_multibyte of
4931 process_coding to 0 (bug#9912).
4932
a64bfdfa 49332011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4934
4935 * xmenu.c (cleanup_widget_value_tree): New function.
4936 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4937 calling free_menubar_widget_value_tree directly (Bug#9830).
4938
cb41b32a
PE
49392011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4940
4941 Fix some portability problems with 'inline'.
4942 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4943 (window_box_width, window_box_left, window_box_left_offset)
4944 (window_box_right, window_box_right_offset): Declare extern.
4945 Otherwise, these inline functions do not conform to C99 and
4946 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4947 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4948 * intervals.c (adjust_intervals_for_insertion)
4949 (adjust_intervals_for_deletion): Now extern, because otherwise the
4950 extern inline functions 'offset_intervals' couldn't refer to it.
4951 (static_offset_intervals): Remove.
4952 (offset_intervals): Rewrite using the old contents of
4953 static_offset_intervals. The old version didn't conform to C99
4954 because an extern inline function contained a reference to an
4955 identifier with static linkage.
4956
b7041366
AS
49572011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4958
4959 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4960 GC.
4961
88a37c4d
EZ
49622011-11-06 Eli Zaretskii <eliz@gnu.org>
4963
4964 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4965 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4966 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4967 return Qleft_to_right.
4968
49745b39
CY
49692011-11-06 Chong Yidong <cyd@gnu.org>
4970
4971 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4972 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4973 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4974 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4975 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4976 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4977 (Fwindow_vscroll): Doc fix.
4978 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4979 argument, since it makes no sense to pass a live window and for
4980 consistency with window-child.
4981
1f05cd82
CS
49822011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4983
4984 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4985 support MSVC.
4986
22610910
JR
49872011-11-05 Jason Rumney <jasonr@gnu.org>
4988
4989 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4990 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4991 fonts (Bug#6029).
4992 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4993 bitwise arithmetic preventing use of unicode-sip and non-truetype
4994 opentype fonts.
4995
a06776b2
EZ
49962011-11-05 Eli Zaretskii <eliz@gnu.org>
4997
3ad924ba
EZ
4998 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4999 "emacs"-only part.
5000
a06776b2
EZ
5001 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5002 initialization code to keep similarity to xfns.c after changes
5003 from 2011-11-05.
5004
c9e7db78
JD
50052011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5006
a97f8f3f
JD
5007 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5008 (unwind_create_frame): New function (Bug#9943).
5009 (Fx_create_frame): Restructure code to be more similar to the one in
5010 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5011 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5012 Move terminal->reference_count++ just before making the frame official
5013 (Bug#9943).
5014
5015 * nsterm.m (x_free_frame_resources): New function.
5016 (x_destroy_window): Move code to x_free_frame_resources.
5017
c9e7db78 5018 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5019 (Fx_create_frame, x_create_tip_frame):
5020 Move terminal->reference_count++ just before making the frame
75f1671a 5021 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5022 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5023
a6fc3b5c
EZ
50242011-11-05 Eli Zaretskii <eliz@gnu.org>
5025
5026 Support MSVC build with newer versions of Visual Studio.
5027 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5028 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5029 nt/gmake.defs.
5030
5031 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5032 which are not supported by MSVC.
5033 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5034 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5035 bitfields.
5036 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5037 types in bitfields.
5038 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5039
5040 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5041
58179cce 50422011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5043
5044 Support MSVC build with newer versions of Visual Studio.
5045 * w32.c: Don't include w32api.h for MSVC.
5046 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5047
5048 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5049 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5050 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5051 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5052 e_* cousins.
5053 (alloca) [_MSC_VER]: Define to _alloca.
5054
5055 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5056
5057 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5058
a58c13ed
EZ
50592011-11-04 Eli Zaretskii <eliz@gnu.org>
5060
5061 * xdisp.c (note_mouse_highlight): If either of
5062 previous/next-single-property-change returns nil, treat that as
5063 the beginning or the end of the buffer. (Bug#9955)
5064
fe0b6370
JD
50652011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5066
a58c13ed 5067 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5068 label is not null (Bug#9951).
5069 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5070 may be NULL.
5071
89bd5ee1
EZ
50722011-11-04 Eli Zaretskii <eliz@gnu.org>
5073
5074 * window.c (Fwindow_body_size): Mention in the doc string that the
5075 return value is in frame's canonical units. (Bug#9949)
5076
84c3edb9
EZ
50772011-11-03 Eli Zaretskii <eliz@gnu.org>
5078
4e2fb5c7
EZ
5079 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5080
84c3edb9 5081 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5082 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5083 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5084
bc17a887
EZ
50852011-11-01 Eli Zaretskii <eliz@gnu.org>
5086
5087 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5088 Don't stop backward scan on the continuation glyph, even though
5089 its CHARPOS is positive.
6d5eb5b0
SM
5090 (mouse_face_from_buffer_pos, note_mouse_highlight):
5091 Rename cover_string to disp_string.
bc17a887 5092
4ee88440
MR
50932011-11-01 Martin Rudalics <rudalics@gmx.at>
5094
5095 * window.c (temp_output_buffer_show): Don't use
5096 Vtemp_buffer_show_specifiers.
5097 (Vtemp_buffer_show_specifiers): Remove unused variable.
5098
c2ff3c02
EZ
50992011-10-30 Eli Zaretskii <eliz@gnu.org>
5100
5101 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5102 past the beginning of the current glyph matrix.
5103
58179cce 51042011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5105
5106 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5107 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5108 HAVE_GTK3 (Bug#9869).
b77a6a7f 5109
3b574623
JD
5110 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5111 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5112
b77a6a7f
JD
5113 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5114
5115 * xterm.c: Declare x_handle_net_wm_state to return int.
5116 (handle_one_xevent): Check if we are iconified but don't have
5117 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5118 (get_current_wm_state): Return non-zero if not hidden,
5119 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5120 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5121 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5122 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5123
196e41e4
PE
51242011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5125
5126 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5127 so that this new function doesn't get optimized away by a
5128 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5129
021f2e1a
AS
51302011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5131
5132 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5133
8b058d44
EZ
51342011-10-29 Eli Zaretskii <eliz@gnu.org>
5135
5136 Fix the `xbytecode' command.
5137 * .gdbinit (xprintbytestr): New command.
b50a28de 5138 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5139 (xbytecode): Print the byte-code string as well.
5140
4452fb80
EZ
51412011-10-29 Kim Storm <storm@cua.dk>
5142
8b058d44
EZ
5143 * alloc.c (which_symbols): New function.
5144
21b72067
AS
51452011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5146
5147 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5148 line. (Bug#9903)
5149
83ed7b5c
GM
51502011-10-29 Glenn Morris <rgm@gnu.org>
5151
5152 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5153 Not clear what it was for, and it causes various bugs. (Bug#9839)
5154
5a7a728b
EZ
51552011-10-28 Eli Zaretskii <eliz@gnu.org>
5156
5157 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5158 possible random value that matches one of those tested as
5159 condition to clear the mouse face.
5160
d3d0842f
CY
51612011-10-28 Chong Yidong <cyd@gnu.org>
5162
5163 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5164
31b39d13
DN
51652011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5166
5167 * window.c (make_window): Initialize phys_cursor_on_p.
5168
9aba6043
SM
51692011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5170
5171 * lisp.h (struct Lisp_Symbol): Update comments.
5172
c20992f4
JB
51732011-10-28 Juanma Barranquero <lekktu@gmail.com>
5174
5175 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5176
db4f02f2
EZ
51772011-10-28 Eli Zaretskii <eliz@gnu.org>
5178
5179 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5180 <oslsachem@gmail.com> for helping to debug this.
5181
5182 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5183 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5184 (g_b_init_get_glyph_outline_w): New static variables.
5185 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5186 (GetGlyphOutlineW_Proc): New typedefs.
5187 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5188 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5189 New functions.
5190 (w32font_open_internal, compute_metrics):
5191 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5192 instead of calling the "wide" APIs directly.
5193
5194 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5195
5196 * w32.h (syms_of_w32font): Add prototype.
5197
87e68db4
JB
51982011-10-27 Juanma Barranquero <lekktu@gmail.com>
5199
5200 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5201 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5202 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5203 (Fmove_to_window_line): Doc fix.
5204
435c1d67
CY
52052011-10-27 Chong Yidong <cyd@gnu.org>
5206
5207 * process.c (make_process): Set gnutls_state to NULL.
5208
5209 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5210 non-NULL, regardless of GNUTLS_INITSTAGE.
5211 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5212 an error. Set process slots as soon as we allocate them.
5213
5214 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5215
9c6c6f49
CY
52162011-10-27 Chong Yidong <cyd@gnu.org>
5217
9aba6043
SM
5218 * gnutls.c (emacs_gnutls_deinit): New function.
5219 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5220 (Fgnutls_deinit, Fgnutls_boot): Use it.
5221
5222 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5223 (deactivate_process): Call emacs_gnutls_deinit.
5224
657d08d3
JB
52252011-10-27 Juanma Barranquero <lekktu@gmail.com>
5226
5227 * image.c (x_create_x_image_and_pixmap):
5228 * w32.c (sys_rename, w32_delayed_load):
5229 * w32font.c (fill_in_logfont):
5230 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5231
5430d399
JB
52322011-10-26 Juanma Barranquero <lekktu@gmail.com>
5233
5234 * w32fns.c (w32_default_color_map): New function,
5235 extracted from Fw32_default_color_map.
a7ef684b 5236 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5237
fe0055fa
PE
52382011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5239
5240 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5241
e6346438
SM
52422011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5243
5244 * keyboard.c (test_undefined): New function (bug#9751).
5245 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5246
e112cc37
ET
52472011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5248
5249 * sysdep.c (init_sys_modes): Fix the check for the controlling
5250 terminal (Bug#6649).
5251
7b5d6677
EZ
52522011-10-20 Eli Zaretskii <eliz@gnu.org>
5253
5254 * dispextern.h (struct bidi_it): New member next_en_type.
5255
5256 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5257 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5258 current character, check also for next_en_type being WEAK_EN.
5259 (bidi_resolve_weak): Don't enter the expensive loop if the current
5260 position is before next_en_pos. Record the bidi type of the first
5261 non-ET, non-BN character we find, in addition to its position.
5262 (bidi_level_of_next_char): Invalidate next_en_type when
5263 next_en_pos is over-stepped.
5264
7da0b018
PE
52652011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5266
5267 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5268 * editfns.c: Rewrite current-time-zone so that it invokes
5269 the equivalent of (format-time-string "%Z") to get the time zone name.
5270 This fixes a bug when the time zone name contains characters that
5271 need converting from the system time locale to Emacs internal format.
5272 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5273 that patch fixed format-time-string to do the conversion, but
5274 I forgot to fix current-time-zone.
5275 (format_time_string): New function, containing most of
5276 what Fformat_time_string used to contain.
5277 (Fformat_time_string): Rewrite in terms of format_time_string.
5278 This doesn't change this function's behavior.
5279 (current-time-zone): Rewrite to use format_time_string.
5280 This fixes the bug reported by Michael Schierl in
5281 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5282 Jason Rumney's 2007-06-07 change worked around this bug, but
5283 didn't fix it.
5284 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5285
8547b010
EZ
52862011-10-19 Eli Zaretskii <eliz@gnu.org>
5287
5288 * xdisp.c (start_display): If the character at POS is displayed
5289 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5290 (try_window_reusing_current_matrix): If a line ends in a display
5291 vector or the next line starts in a display vector, continue
5292 redrawing the window even though the character position of
5293 start_row was reached.
8547b010
EZ
5294 (Bug#9771, part 2)
5295
4e948d15
CY
52962011-10-18 Chong Yidong <cyd@gnu.org>
5297
5298 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5299 with nobreak-char-display too.
5300
4787455f
EZ
53012011-10-18 Eli Zaretskii <eliz@gnu.org>
5302
5303 Fix part 3 of bug#9771.
5304 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5305 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5306 non-neutral characters if the current character is a paragraph
5307 separator (a.k.a. Newline). This avoids running the same
5308 expensive loop twice, once when we consume the preceding newline
5309 and the other time when the line actually needs to be displayed.
5310 Avoid the loop when we see neutrals on the base embedding level
5311 following a character whose directionality is the same as the
5312 paragraph's. This avoids running the expensive loop when a line
5313 ends in a long sequence of neutrals, like control characters.
5314 Add assertion against STRONG_AL type. Slightly rearrange code
5315 that determines the type of a neutral given the first non-neutral
5316 that follows it.
5317 (bidi_level_of_next_char): Set next_en_pos to zero when
5318 invalidating its info.
5319
2c91f553
EZ
53202011-10-17 Eli Zaretskii <eliz@gnu.org>
5321
5322 * xdisp.c (push_display_prop): Determine whether to record string
5323 or buffer position by IT->string, not by IT->method. Allow
5324 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5325 (move_it_vertically_backward): Don't look for character position
5326 immediately after the newline when in a continuation line.
5327 (Bug#9771, part 1)
2c91f553 5328
c7b08b0d
MR
53292011-10-15 Martin Rudalics <rudalics@gmx.at>
5330
5331 * window.c (coordinates_in_window): Rewrite and delabelize
5332 vertical border check. (Bug#5357) (Bug#9618)
5333
6b02f655
SM
53342011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5335
5336 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5337 errors in XSetWindowBorder (bug#9310).
5338
81d40c92
DA
53392011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5340
5341 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5342 avoid crash when xmalloc overrun checking is enabled.
5343
d4172c3b
EZ
53442011-10-13 Eli Zaretskii <eliz@gnu.org>
5345
5346 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5347 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5348 cursor motion with <left> and <right> arrow keys.
5349
5350 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5351 some callers set that themselves.
5352
b00eea75
EZ
53532011-10-12 Eli Zaretskii <eliz@gnu.org>
5354
5355 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5356 display string and the previous row comes from the same string and
5357 is empty. (Bug#9739) (Bug#9738)
5358
8fe012c4
SM
53592011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5360
5361 * doc.c (get_doc_string): Encode file name (bug#9735).
5362
0074aef2
EZ
53632011-10-12 Eli Zaretskii <eliz@gnu.org>
5364
79beb178
EZ
5365 * bidi.c (bidi_level_of_next_char):
5366 * xdisp.c (get_visually_first_element): Remove old incorrect
5367 comments regarding the Unicode Line Separator character.
5368
0074aef2
EZ
5369 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5370
6e4b3fbe
DA
53712011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5372
5373 * alloc.c (Fgc_status): Do not access beyond zombies array
5374 boundary if nzombies > MAX_ZOMBIES.
5375 * alloc.c (dump_zombies): Add missing format specifier.
5376
0324f3af
PE
53772011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5378
b5525cac
PE
5379 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5380 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5381
0324f3af
PE
5382 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5383 Some packages use them to denote characters with modifiers.
5384
e9b5f888
AS
53852011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5386
5387 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5388 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5389 matching a pp-number. Rename parameter var to var1.
5390
127827c0
SM
53912011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5392
5393 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5394
c8fd3bd0
GM
53952011-10-08 Glenn Morris <rgm@gnu.org>
5396
5397 * callint.c (Fcall_interactively): Give a more explicit error for the
5398 'c' case with a non-character input. (Bug#8479)
5399
352ec8ff
EZ
54002011-10-08 Eli Zaretskii <eliz@gnu.org>
5401
03669ccb
EZ
5402 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5403 lines.
7061c986
EZ
5404 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5405 lines that are hscrolled on the left.
03669ccb 5406
352ec8ff
EZ
5407 * dispnew.c (buffer_posn_from_coords): Account for a possible
5408 presence of header-line. (Bug#4426)
5409
a66cfb1c
SM
54102011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5411
6b02f655
SM
5412 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5413 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5414
7c5ee88e
PE
54152011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5416
5417 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5418 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5419 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5420 this makes Emacs dump core during garbage collection on rare
5421 occasions. sizeof is obviously inferior to offsetof here, so
5422 stick with offsetof.
5423 (GC_POINTER_ALIGNMENT): New macro.
5424 (mark_memory): Omit 3rd (offset) arg; caller changed.
5425 Don't assume EMACS_INT alignment is the same as pointer alignment.
5426
df1bbe5b
SM
54272011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5428
5429 * keyboard.c (read_key_sequence_remapped): New var.
5430 (read_key_sequence): Compute remapping in the right buffer.
5431 (command_loop_1): Use read_key_sequence's remapping directly.
5432
51553db6
SM
54332011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5434
32c1fffd
SM
5435 * dired.c (file_name_completion): Don't expand file name.
5436 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5437 before checking file name handler.
5438
51553db6
SM
5439 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5440 they've been requested explicitly (bug#9591).
5441
b6bd1599 54422011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5443
5444 * keymap.c (Fsingle_key_description): Use make_specified_string
5445 instead of build_string to build string from push_key_description.
5446 (Bug#5193)
5447
f701dc2a
PE
54482011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5449
4222c55d
PE
5450 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5451 This fixes a Y2038 bug on 64-bit hosts.
5452 * buffer.c (reset_buffer):
5453 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5454 (Fclear_buffer_auto_save_failure):
5455 Use 0, not -1, to represent an unset failure time, since time_t
5456 might not be signed.
5457
f701dc2a
PE
5458 Remove dependency on glibc malloc internals.
5459 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5460 Move back here from lisp.h, but with their new implementations.
5461 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5462 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5463 * charset.c (charset_table_init): New static var.
5464 (syms_of_charset): Use it instead of xmalloc. This removes a
5465 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5466 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5467 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5468 Move back to alloc.c.
5469 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5470 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5471
9ceebf39
JD
54722011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5473
5474 * nsterm.m (windowDidResize): Call x_set_window_size only when
5475 ns_in_resize is true. Otherwise set pixelwidth/height and
5476 call change_frame_size (Bug#9628).
5477
cb993c58
PE
54782011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5479
3930c88b
PE
5480 Port --enable-checking=all to Fedora 14 x86-64.
5481 * charset.c (syms_of_charset): Also account for glibc malloc's
5482 internal overhead when calculating the initial malloc maximum.
5483
cb993c58
PE
5484 Port --enable-checking=all to Fedora 14 x86.
5485 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5486 Move to lisp.h.
5487 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5488 (overrun_check_realloc, overrun_check_free):
5489 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5490 That way, xmalloc returns a properly-aligned pointer even if
5491 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5492 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5493 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5494 into account when calculating the initial malloc maximum.
5495 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5496 Move here from alloc.c, so that charset.c can use it too.
5497 Properly align; the old code wasn't right for common 32-bit hosts
5498 when configured with --enable-checking=all.
5499 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5500 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5501
31bed486
EZ
55022011-09-29 Eli Zaretskii <eliz@gnu.org>
5503
04c70788 5504 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5505 use EDOM.
5506
fbcaa2f3
EZ
55072011-09-28 Eli Zaretskii <eliz@gnu.org>
5508
5509 * xdisp.c (compute_display_string_end): If there's no display
5510 string at CHARPOS, return -1.
5511
5512 * bidi.c (bidi_fetch_char): When compute_display_string_end
5513 returns a negative value, treat the character as a normal
5514 character not covered by a display string. (Bug#9624)
5515
a239d4e9
JB
55162011-09-28 Juanma Barranquero <lekktu@gmail.com>
5517
5518 * lread.c (Fread_from_string): Fix typo in docstring.
5519
88652fd5
EZ
55202011-09-27 Eli Zaretskii <eliz@gnu.org>
5521
5522 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5523 newline, reseat the iterator instead of bidi-iterating there one
5524 character at a time. (Bug#9610)
32c1fffd
SM
5525 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5526 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5527
ed497dd4
AS
55282011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5529
5530 * lread.c (readevalloop): Use correct code for NBSP.
5531 (read1): Likewise. (Bug#9608)
5532
b2bf61aa
MA
55332011-09-25 Michael Albinus <michael.albinus@gmx.de>
5534
5535 * dbusbind.c (Fdbus_register_signal): When service is not
5536 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5537
32bbb17c
GM
55382011-09-25 Glenn Morris <rgm@gnu.org>
5539
5540 * buffer.c (truncate-lines): Doc fix.
5541
94e0933e
CY
55422011-09-24 Chong Yidong <cyd@stupidchicken.com>
5543
5544 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5545 (Fset_window_next_buffers): Doc fix.
5546
cddde921
GM
55472011-09-24 Glenn Morris <rgm@gnu.org>
5548
5549 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5550
1260aef1
PE
55512011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5552
25b4bfa0
PE
5553 Fix minor problems found by static checking.
5554 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5555 * indent.c (Fvertical_motion): Fix == vs = typo.
5556
e3cbd34b
EZ
55572011-09-24 Eli Zaretskii <eliz@gnu.org>
5558
a66cfb1c
SM
5559 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5560 Default value is now t. Doc fix.
6bf7006f 5561
e3cbd34b 5562 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5563 logic when moving up, not only when moving down. Fix the
e3cbd34b 5564 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5565 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5566
5567 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5568 CHARPOS is covered by a display string which includes newlines.
5569 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5570 is covered by a display string with embedded newlines.
5571
a3de0cbd
MA
55722011-09-24 Michael Albinus <michael.albinus@gmx.de>
5573
5574 * dbusbind.c (Fdbus_register_signal): Add match rule to
5575 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5576 (Fdbus_register_method, Vdbus_registered_objects_table):
5577 Fix docstring.
a3de0cbd 5578
b260039d
JM
55792011-09-24 Jim Meyering <meyering@redhat.com>
5580
32c1fffd 5581 do not ignore write error for any output size
b260039d
JM
5582 The previous change was incomplete.
5583 While it makes emacs --batch detect the vast majority of stdout
5584 write failures, errors were still ignored whenever the output size is
5585 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5586 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5587 && echo FAIL: ignored write error
5588 FAIL: ignored write error
5589 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5590 && echo FAIL: ignored write error
5591 FAIL: ignored write error
5592 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5593
8eca8a7c
AS
55942011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5595
5596 * emacs.c (Fkill_emacs): In noninteractive mode exit
5597 non-successfully if a write error occurred on stdout. (Bug#9574)
5598
3341db62
EZ
55992011-09-21 Eli Zaretskii <eliz@gnu.org>
5600
5601 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5602 the xassert test.
5603
5604 * dispextern.h (struct it): Update the comment documenting what
5605 can it->OBJECT be.
5606
8c203dbf
EZ
56072011-09-20 Eli Zaretskii <eliz@gnu.org>
5608
5609 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5610 a display string, extend search for cursor position to end of row.
5611 (find_row_edges): If the row ends in a newline from a display
5612 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5613 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5614 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5615 non-empty line. Fixes confusing cursor motion with arrow keys at
5616 the beginning of a line that starts with whitespace.
8c203dbf 5617
a4824228
LMI
56182011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5619
5620 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5621 (bug#9493).
5622
33ed493b
CY
56232011-09-18 Chong Yidong <cyd@stupidchicken.com>
5624
5625 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5626 boolean (Bug#9154).
5627
56cd55c8
EZ
56282011-09-18 Eli Zaretskii <eliz@gnu.org>
5629
5630 * xdisp.c (display_line): Record maximum and minimum buffer
5631 positions even if no glyphs were produced (e.g., by a zero-width
5632 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5633 buffer positions that will be removed from the glyph row because
5634 they don't fit.
c02dcedf
EZ
5635 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5636 column is beyond frame width: don't subtract 1 "pixel" when
5637 computing width of the stretch.
3e62b7e0
EZ
5638 (reseat_at_next_visible_line_start): Undo the change made on
5639 2011-09-17 that saved paragraph information and restored it after
5640 the call to `reseat'. (Bug#9545)
56cd55c8 5641
5ed99d36 56422011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5643
5644 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5645 and turn window cursor on if cleared (Bug#9415).
5646
5ed99d36 56472011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5648
5649 * search.c (boyer_moore): Take unibyte characters from pattern
5650 literally. (Bug#9458)
5651
9bade7b2
EZ
56522011-09-18 Eli Zaretskii <eliz@gnu.org>
5653
5654 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5655
e5e9d610
PE
56562011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5657
87e4427a
PE
5658 Fix minor problem found by static checking.
5659 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5660 initialized, to pacify gcc -Wuninitialized.
5661
e5e9d610
PE
5662 * fileio.c: Report proper errno when syscall falls.
5663 (Finsert_file_contents): Save and restore errno,
5664 so that report_file_error outputs the correct diagnostic.
5665 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5666
a1674f0b
EZ
56672011-09-18 Eli Zaretskii <eliz@gnu.org>
5668
5669 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5670
fbfb6dd4
EZ
56712011-09-17 Eli Zaretskii <eliz@gnu.org>
5672
5673 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5674 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5675
bb187662
EZ
56762011-09-17 Eli Zaretskii <eliz@gnu.org>
5677
1137e8b8 5678 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5679 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5680
5681 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5682 (bidi_find_paragraph_start): Search back for paragraph beginning
5683 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5684 (bidi_move_to_visually_next): Only trigger paragraph-related
5685 computations when the last character is a newline or at EOB, not
5686 just any NEUTRAL_B. (Bug#9470)
5687
bb187662
EZ
5688 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5689 truncated lines if point is covered by a display string. (Bug#9524)
5690
2e621251
PE
56912011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5692
5693 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5694 (cons_to_x_long): New function.
5695 (lisp_data_to_selection_data): Use it. Correct the test for
5696 short-versus-long data; it was negated. Break out of vector
5697 loop, for efficiency, when a long datum is discovered.
5698
91a15bc6
SM
56992011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5700
5701 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5702
b41c3a35
EZ
57032011-09-16 Eli Zaretskii <eliz@gnu.org>
5704
5705 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5706 GCC PR/17406) by declaring this function with external scope.
5707
7812ba2d
PE
57082011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5709
5710 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5711 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5712
cf7edc2a
AS
57132011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5714
5715 * editfns.c (Fformat): Correctly handle text properties on "%%".
5716
bd01620e
EZ
57172011-09-15 Eli Zaretskii <eliz@gnu.org>
5718
5719 * xterm.c (x_draw_composite_glyph_string_foreground):
5720 * w32term.c (x_draw_composite_glyph_string_foreground):
5721 * term.c (encode_terminal_code):
5722 * composite.c (composition_update_it, get_composition_id):
5723 * xdisp.c (get_next_display_element)
5724 (fill_composite_glyph_string): Add comments about special meaning
5725 of TAB characters in a composition.
5726
a02719a3
PE
57272011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5728
5729 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5730 This occurs when processing a multibyte format.
5731 Problem reported by Wolfgang Jenker.
a02719a3 5732
72589a3c
JB
57332011-09-15 Johan Bockgård <bojohan@gnu.org>
5734
5735 * xdisp.c (try_cursor_movement): Only check for exact match if
5736 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5737
1c14176c
PE
57382011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5739
5740 Remove unused external symbols.
5741 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5742 * xdisp.c (calc_pixel_width_or_height): Now static.
5743 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5744 * indent.c (check_display_width):
5745 * w32term.c: Fix comment to match code.
5746 * xterm.c, xterm.h (x_catching_errors): Remove.
5747
d2eea5b5
PE
57482011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5749
5750 * xselect.c: Use signed conversions more consistently (Bug#9498).
5751 (selection_data_to_lisp_data): Assume incoming selection data are
5752 signed integers, not unsigned. This is to be consistent with
5753 outgoing selection data, which was modified to use signed integers
5754 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5755 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5756 expects long, not unsigned long.
5757
46888499
EZ
57582011-09-14 Eli Zaretskii <eliz@gnu.org>
5759
5760 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5761 computation of loop end. Reported by Johan Bockgård
5762 <bojohan@gnu.org>.
5763
ef8ef9fb
CY
57642011-09-13 Chong Yidong <cyd@stupidchicken.com>
5765
5766 * frame.c (Fother_visible_frames_p): Function deleted.
5767
fa819fed
EZ
57682011-09-12 Eli Zaretskii <eliz@gnu.org>
5769
5770 * indent.c (compute_motion): Process display vector front to back
5771 rather than the other way around. (Bug#2496)
5772
2ba8e008
SM
57732011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5774
5775 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5776
20f53c69
CY
57772011-09-11 Chong Yidong <cyd@stupidchicken.com>
5778
5779 * minibuf.c (Fread_from_minibuffer): Doc fix.
5780
d562d7a4
EZ
57812011-09-11 Eli Zaretskii <eliz@gnu.org>
5782
5783 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5784 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5785
1c4d7f3d
LMI
57862011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5787
5788 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5789 value for non-existent files.
5790
b885bf36
EZ
57912011-09-11 Eli Zaretskii <eliz@gnu.org>
5792
5793 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5794 set its "size" to -1. This will set the modtime_size field of
5795 the corresponding buffer to -1, which is what
5796 verify-visited-file-modtime expects for files that do not exist.
5797 (Bug#9139)
5798
6612f0bf
PE
57992011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5800
5801 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5802 here ...
5803 * lisp.h: ... from here. push_key_description is no longer
5804 defined in keyboard.c, so its declaration should not be in
5805 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5806 logically belongs with push_key_description.
5807
dfb3f755
PE
58082011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5809
5810 * buffer.h: Include <sys/types.h> instead of <time.h>.
5811 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5812 Problem reported by Herbert J. Skuhra.
5813
3134906c
LMI
58142011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5815
5816 * xml.c (parse_region): Make the parsing work for
5817 non-comment-starting XML files again (bug#9144).
5818
8d903f4e
AS
58192011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5820
5821 * image.c (gif_load): Fix calculation of bottom and right corner.
5822 (Bug#9468)
5823
80ad64f4
EZ
58242011-09-10 Eli Zaretskii <eliz@gnu.org>
5825
5826 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5827 redisplay in small windows.
5828
208a048d
EZ
58292011-09-09 Eli Zaretskii <eliz@gnu.org>
5830
5831 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5832
9b1c252e
MR
58332011-09-08 Martin Rudalics <rudalics@gmx.at>
5834
5835 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5836 Operate on live windows only.
5837
2949f33b
JB
58382011-09-08 Juanma Barranquero <lekktu@gmail.com>
5839
5840 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5841
e08dcafd
EZ
58422011-09-07 Eli Zaretskii <eliz@gnu.org>
5843
5844 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5845 only under bidi iteration.
5846
115b96bd
JD
58472011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5848
5849 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5850
c8199d0f
PE
58512011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5852
5853 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5854 Without this fix, the command to link temacs failed due to an
5855 undefined symbol __builtin_isnan. This is because
5856 /usr/include/iso/math_c99.h #defines isnan(x) to
5857 __builtin_isnan(x), but the bundled gcc, which identifies itself
5858 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5859 a __builtin_isnan.
5860 * floatfns.c (isnan): #undef, and then #define to a clone of
5861 what's in data.c.
5862 (Fisnan): Always define, since it's always available now.
5863 (syms_of_floatfns): Always define isnan at the Lisp level.
5864
e39b275c 58652011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5866
5867 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5868
b2db44d9 58692011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5870
f4af5137 5871 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5872 The previous code assumed that file offsets (off_t values) fit in
5873 EMACS_INT variables, which is not true on typical 32-bit hosts.
5874 The code messed up by falsely reporting buffer overflow in cases
5875 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5876 when "big" contains more than 2**29 bytes, even though this
5877 inserts just one byte and does not overflow the buffer.
5878 (Finsert_file_contents): Store file offsets as off_t
5879 values, not as EMACS_INT values. Check for overflow when
5880 converting between EMACS_INT and off_t. When checking for
5881 buffer overflow or for overlap, take the offsets into account.
5882 Don't use EMACS_INT for small values where int suffices.
5883 When checking for overlap, fix a typo: ZV was used where
5884 ZV_BYTE was intended.
5885 (Fwrite_region): Don't assume off_t fits into 'long'.
5886 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5887
ecfc0a49
MA
58882011-09-05 Michael Albinus <michael.albinus@gmx.de>
5889
5890 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5891
6511acf2 58922011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5893
0999621a 5894 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5895
5896 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5897 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5898 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5899 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5900 (modify_event_symbol): Do not assume that the length of
5901 name_alist_or_stem is safe to alloca and fits in int.
5902 (Fexecute_extended_command): Likewise for function name and binding.
5903 (Frecursion_depth): Wrap around reliably on integer overflow.
5904 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5905 since some callers pass EMACS_INT values.
5906 (Fsingle_key_description): Don't crash if symbol name contains more
5907 than MAX_ALLOCA bytes.
5908 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5909 (get_minibuffer): Arg is now EMACS_INT, not int.
5910 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5911 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5912 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5913
2be7d702
PE
5914 * dbusbind.c (signature_cat): New function.
5915 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5916 Do not overrun buffer; instead, report string overflow.
5917
9d1df220
PE
5918 * dispnew.c (add_window_display_history): Don't overrun buffer.
5919 Truncate instead; this is OK since it's just a log.
5920
33ef5c64
PE
5921 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5922 even if the time zone offset is outlandishly large.
5923 Don't mishandle offset == INT_MIN.
5924
66c6fdd5
PE
5925 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5926 when creating daemon; the previous buffer-overflow check was incorrect.
5927
d749b01b
PE
5928 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5929 which has the guts of the old verror function.
5930
b5cd1905
PE
5931 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5932 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5933
6e1a67fb
PE
5934 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5935 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5936 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5937 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5938 length of string rather than counting it via multiple sprintfs;
5939 that's simpler and more reliable.
c21721cc
PE
5940 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5941 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5942 sprintf, in case result does not fit in int.
5943
c57b67fc
PE
5944 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5945 (fontset_from_font): Print it.
5946
8a401434
PE
5947 * frame.c (tty_frame_count): Now printmax_t, not int.
5948 (make_terminal_frame, set_term_frame_name): Print it.
5949 (x_report_frame_params): In X, window IDs are unsigned long,
5950 not signed long, so print them as unsigned.
5951 (validate_x_resource_name): Check for implausibly long names,
5952 and don't assume name length fits in 'int'.
5953 (x_get_resource_string): Don't blindly alloca invocation name;
5954 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5955 not fit in int.
5956
6e1a67fb
PE
5957 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5958 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5959 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5960
0df02bf3
PE
5961 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5962 Use esprintf, not sprintf, in case result does not fit in int.
5963
48e30793
PE
5964 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5965 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5966 it as a large positive number.
5967 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5968 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5969
a66ff6d8
PE
5970 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5971 in case result does not fit in int.
5972
aca216ff
PE
5973 * print.c (float_to_string): Detect width overflow more reliably.
5974 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5975 buffer overrun. Don't assume list length fits in 'int'. Treat
5976 print length of 0 as 0, not as infinity; to be consistent with other
5977 uses of print length in this function. Don't overflow print length
5978 index. Don't assume hash table size fits in 'long', or that
5979 vectorlike size fits in 'unsigned long'.
5980
31c286f7
PE
5981 * process.c (make_process): Use printmax_t, not int, to format
5982 process-name gensyms.
5983
55e5faa1
PE
5984 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5985
80f2e268
PE
5986 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5987 to avoid potential buffer overrun.
5988
670741ab
PE
5989 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5990 if X resource line is longer than 512 bytes.
5991
b7163a50
PE
5992 * xfns.c (x_window): Make sprintf buffer a bit bigger
5993 to avoid potential buffer overrun.
5994
ae58ff1f
PE
5995 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5996
c43c8a6a
PE
5997 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5998
3f8236f4
PE
59992011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6000
53e9fe90 6001 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6002 Without these, Emacs silently mishandles large integers sometimes.
6003 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6004 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6005
6511acf2
PE
6006 * xdisp.c (try_window_id): Check Emacs fixnum range before
6007 converting to 'int'.
806add1d 6008
6511acf2 6009 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6010 Check that an Emacs fixnum is in range before assigning it to 'int'.
6011 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6012 values converted from Emacs fixnums.
6013 (Frecenter): Don't wrap around a line count if it is out of 'int'
6014 range; instead, treat it as an extreme value.
6015 (Fset_window_configuration, compare_window_configurations):
6016 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6017
6511acf2
PE
6018 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6019 that can exceed INT_MAX. Check that EMACS_INT value is in range
6020 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6021 (match_limit): Don't assume that a fixnum can fit in 'int'.
6022
6511acf2 6023 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6024 exceed INT_MAX.
6025
6511acf2 6026 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6027 (Fvertical_motion): Don't wrap around LINES values that don't fit
6028 in 'int'. Instead, treat them as extreme values. This is good
6029 enough for windows, which can't have more than INT_MAX lines anyway.
6030
fcb901a7
LMI
60312011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6032
0f2f6b6d
LMI
6033 * Require libxml/parser.h to avoid compilation warning.
6034
fcb901a7
LMI
6035 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6036
6037 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6038 since this reportedly can destroy thread storage.
6039
6e20a0d4
CY
60402011-08-30 Chong Yidong <cyd@stupidchicken.com>
6041
6042 * syntax.c (find_defun_start): Update all cache variables if
6043 exiting early (Bug#9401).
6044
148ae00e
EZ
60452011-08-30 Eli Zaretskii <eliz@gnu.org>
6046
f6cfbd8f
EZ
6047 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6048
148ae00e
EZ
6049 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6050 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6051 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6052
6053 * term.c (tty_append_glyph): New function.
6054 (produce_stretch_glyph): Static function and its prototype deleted.
6055
a66cfb1c
SM
6056 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6057 Add prototypes.
148ae00e 6058
c4a07a4c
PE
60592011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6060
6061 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6062 when checking :margin (Bug#9390).
6063 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6064 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6065 so that the name doesn't mislead. All uses changed.
6066
6bc8cd65
JB
60672011-08-28 Johan Bockgård <bojohan@gnu.org>
6068
6069 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6070 set_tty_hooks.
6071
dca4927e
EZ
60722011-08-27 Eli Zaretskii <eliz@gnu.org>
6073
6074 * xdisp.c (move_it_to): Don't bail out early when reaching
6075 position beyond to_charpos, if we are scanning backwards.
6076 (move_it_vertically_backward): When DY == 0, make sure we get to
6077 the first character in the line after the newline.
6078
f2cad773
PE
60792011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6080
6081 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6082 (ccl_driver): Do not generate an out-of-range pointer.
6083 (Fccl_execute_on_string): Remove unnecessary check for
6084 integer overflow, noted by Stefan Monnier in
6085 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6086 Remove a FIXME that didn't need fixing.
6087 Simplify the newly-introduced buffer reallocation code.
6088
0cae2cdb
JB
60892011-08-27 Juanma Barranquero <lekktu@gmail.com>
6090
6091 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6092
5fc295a4 60932011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6094
70c60eb2 6095 Integer and memory overflow issues (Bug#9196).
726e0ab1 6096
d31850da
PE
6097 * doc.c (get_doc_string): Rework so that
6098 get_doc_string_buffer_size is the actual buffer size, rather than
6099 being 1 less than the actual buffer size; this makes xpalloc more
6100 convenient.
6101
a69fbedb
PE
6102 * image.c (x_allocate_bitmap_record, cache_image):
6103 * xselect.c (Fx_register_dnd_atom):
6104 Simplify previous changes by using xpalloc.
6105
fe5c5d37
PE
6106 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6107 since either will do and ptrdiff_t is convenient with xpalloc.
6108
0065d054
PE
6109 * charset.c (charset_table_size)
6110 (struct charset_sort_data.priority): Now ptrdiff_t.
6111 (charset_compare): Don't overflow if priorities differ greatly.
6112 (Fsort_charsets): Don't assume list length fits in int.
6113 Check for size-calculation overflow when allocating sort data.
6114 (syms_of_charset): Allocate an initial charset table that is
6115 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6116
6117 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6118
6119 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6120 The actual value is always <= INT_MAX, and leaving it unsigned made
6121 overflow checking harder.
6122
6123 * dispextern.h (struct glyph_matrix.rows_allocated)
6124 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6125 with xpalloc. The values are still always <= INT_MAX.
6126
6127 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6128
6129 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6130 (SAFE_NALLOCA): New macro.
6131
6132 * region-cache.c (struct boundary.pos, find_cache_boundary)
6133 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6134 (set_cache_region, invalidate_region_cache)
6135 (revalidate_region_cache, know_region_cache, region_cache_forward)
6136 (region_cache_backward, pp_cache):
6137 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6138 so that ptrdiff_t * can be passed to xpalloc.
6139 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6140 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6141 (pp_cache): Don't assume cache_len fits in int.
6142 * region-cache.h: Adjust extern decls to match.
6143
6144 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6145 EMACS_INT, since either will do, for xpalloc.
6146
6147 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6148 (xnmalloc, xnrealloc, xpalloc): New functions.
6149
726e0ab1
PE
6150 * bidi.c (bidi_shelve_header_size): New constant.
6151 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6152 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6153
51f30bc5 6154 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6155 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6156 (overlay_strings):
6157 Don't update size of array until after memory allocation succeeds,
6158 because xmalloc/xrealloc may not return.
0065d054
PE
6159 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6160 now that we have proper integer overflow checking.
6161 (record_overlay_string, overlay_strings): Catch overflows when
6162 calculating size of overlay_str_buf.
726e0ab1 6163
0065d054
PE
6164 * callproc.c (Fcall_process): Check for size overflow when
6165 calculating size of args2.
6166 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6167 Normally we prefer signed values, but sticking with ptrdiff_t would
6168 require adding more-complicated checks.
726e0ab1
PE
6169
6170 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6171 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6172 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6173 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6174
6175 * character.c (Fstring): Check for size-calculation overflow.
6176
6177 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6178 unnecessary integer overflow. Check for size overflow.
6179 (encode_coding_object): Don't update size until xmalloc succeeds.
6180
6181 * composite.c (get_composition_id): Check for overflow in glyph
6182 length calculations.
6183
6184 Integer and memory overflow fixes for display code.
6185 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6186 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6187 (scrolling_window): Check for overflow in size calculations.
6188 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6189 Don't assume glyph table len fits in int.
6190 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6191 (row_table_size): Now ptrdiff_t, not int.
6192 (scrolling_window): Avoid overflow in size calculations.
6193 Don't update size until allocation succeeds.
6194 * fns.c (concat): Check for overflow in size calculations.
6195 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6196 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6197 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6198
6199 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6200 (get_doc_string): Check for size calculation overflow.
6201 Don't update size until allocation succeeds.
6202 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6203 EMACS_INT, where ptrdiff_t will do.
6204 (Fsubstitute_command_keys): Check for string overflow.
6205
6206 * editfns.c (set_time_zone_rule): Don't assume environment length
6207 fits in int.
6208 (message_length): Now ptrdiff_t, not int.
6209 (Fmessage_box): Don't update size until allocation succeeds.
6210 Don't assume message length fits in int.
6211 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6212
0065d054
PE
6213 * emacs.c (main): Do not reallocate argv, since there is a null at
6214 the end that can be overwritten, and this way there's no need to
6215 worry about size-calculation overflow.
6216 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6217
6218 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6219 alloc succeeds.
6220 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6221
6222 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6223 (x_set_scroll_bar_width, x_figure_window_size):
6224 Check for integer overflow.
6225 (x_set_alpha): Do not assume XINT fits in int.
6226
6227 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6228 This is for the members text_lines, text_cols, total_lines, total_cols,
6229 where the system imposes an 'int' limit.
6230
6231 * fringe.c (Fdefine_fringe_bitmap):
6232 Don't update size until alloc works.
6233
6234 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6235 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6236
6237 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6238 Check for size-calculation overflow.
6239 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6240 do, as we prefer signed integers.
6241 (id_to_widget.max_size, id_to_widget.used)
6242 (xg_store_widget_in_map, xg_remove_widget_from_map)
6243 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6244 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6245 Use and return ptrdiff_t, not int.
6246 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6247 * gtkutil.h: Change prototypes to match the above.
6248
6249 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6250 are duplicate now that they've been promoted to lisp.h.
6251 (x_allocate_bitmap_record, x_alloc_image_color)
6252 (make_image_cache, cache_image, xpm_load):
6253 Don't update size until alloc is done.
6254 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6255 (x_detect_edges):
3256efce 6256 Check for size calculation overflow.
726e0ab1
PE
6257 (ct_colors_allocated_max): New constant.
6258 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6259 overflow.
3256efce 6260
726e0ab1
PE
6261 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6262 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6263 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6264 Use ptrdiff_t, not int, to count maps.
6265 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6266 calculations. Don't update size until allocation succeeds.
6267 Redo calculations to avoid overflow.
726e0ab1
PE
6268 * keyboard.h: Change prototypes to match the above.
6269
6270 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6271 to count maps.
6272 (current_minor_maps): Check for size calculation overflow.
6273 * keymap.h: Change prototypes to match the above.
6274
6275 * lread.c (read1, init_obarray): Don't update size until alloc done.
6276
6277 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6278 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6279
726e0ab1
PE
6280 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6281 Now ptrdiff_t, not int.
6282 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6283 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6284
6285 * process.c (Fnetwork_interface_list): Check for overflow
6286 in size calculation.
6287
6288 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6289
6290 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6291 overflow. Don't bother calling xmalloc when xrealloc will do.
6292
6293 * search.c (Freplace_match): Check for size calculation overflow.
6294 (Fset_match_data): Don't assume list lengths fit in 'int'.
6295
6296 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6297 for command line length. Do not attempt to address one before the
6298 beginning of an array, as that's not portable.
6299
6300 * term.c (max_frame_lines): Remove; unused.
6301 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6302 not int.
6303 (encode_terminal_code, calculate_costs): Check for size
6304 calculation overflow.
6305 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6306 table lengths and related sizes. Don't update size until alloc
6307 done. Redo calculations to avoid overflow.
6308 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6309
6310 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6311 subtracting pointers.
6312 (gobble_line): Check for overflow more carefully. Don't update size
6313 until alloc done.
6314
6315 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6316 Don't update size until alloc done.
6317 Redo size calculations to avoid overflow.
6318 Check for size calculation overflow.
0065d054 6319 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6320
6321 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6322 Use ptrdiff_t, not int, for sizes.
6323 (store_mode_line_noprop_char): Don't update size until alloc done.
6324
0065d054
PE
6325 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6326 Use ptrdiff_t, not int, for sizes.
6327 (Finternal_make_lisp_face, cache_face):
6328 Check for size calculation overflow.
6329 (cache_face): Treat size calculation overflows as if they were
6330 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6331
6332 * xfns.c (x_encode_text, x_set_name_internal)
6333 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6334 sizes, since they can exceed INT_MAX in size. Check for size
6335 calculation overflow.
6336
0065d054
PE
6337 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6338 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6339 Don't update size until alloc done.
6340
0065d054 6341 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6342 as sprintf is limited to int lengths.
1d526e2f 6343
252c5ee1
PE
6344 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6345 (X_LONG_MIN): New macros.
864d7ce7
PE
6346 Use them to make the following changes clearer.
6347 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6348 This change doesn't affect the value now, but it may help remind
6349 future maintainers not to raise the value too much later.
6350 (SELECTION_QUANTUM): Remove, replacing with ...
6351 (selection_quantum): ... new function, which avoids overflow.
6352 All uses changed.
6353 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6354 assumption that selection length fits in 'int'.
6355 (x_reply_selection_request, x_handle_selection_request)
6356 (x_get_window_property, receive_incremental_selection)
6357 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6358 (lisp_data_to_selection_data, clean_local_selection_data):
6359 Use ptrdiff_t, not int, to record length of selection.
6360 (x_reply_selection_request, x_get_window_property)
6361 (receive_incremental_selection, x_property_data_to_lisp):
6362 Redo calculations to avoid overflow.
6363 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6364 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6365 something.
6366 (x_get_window_property, receive_incremental_selection)
6367 (lisp_data_to_selection_data, x_property_data_to_lisp):
6368 Check for size-calculation overflow.
6369 (x_get_window_property, receive_incremental_selection)
6370 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6371 Don't store size until memory allocation succeeds.
6372 (x_get_window_property): Plug memory leak on memory exhaustion.
6373 Don't double-block input; malloc is safe here. Don't assume 2**34
6374 - 4 fits in unsigned long. Add an xassert to check
6375 XGetWindowProperty overflow. Be more careful about overflow
6376 calculations, and distinguish size from memory overflow better.
6377 (receive_incremental_selection): When tracing, don't assume
6378 unsigned int is less than INT_MAX.
6379 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6380 harmful) conversions of unsigned short to int.
6381 (lisp_data_to_selection_data): Don't assume that integers
6382 in the range -65535 through -1 fit in an X unsigned short.
6383 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6384 result parameters unless successful. Rely on cons_to_unsigned
6385 to report problems with elements; the old code wasn't right anyway.
6386 (x_check_property_data): Check for int overflow; we cannot use
6387 a wider type due to X limits.
6388 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6389
726e0ab1 6390 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6391
0065d054
PE
6392 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6393 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6394 (x_color_cells): Don't store size until memory allocation succeeds.
6395 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6396 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6397 (x_term_init): Don't assume length fits in int (sprintf is limited
6398 to int size).
bc18e09d 6399
ebfa62c0
PE
6400 Use ptrdiff_t for composition IDs.
6401 * character.c (lisp_string_width):
6402 * composite.c (composition_table_size, n_compositions)
6403 (get_composition_id, composition_gstring_from_id):
6404 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6405 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6406 * window.c (Frecenter):
6407 Use ptrdiff_t, not int, for composition IDs.
6408 * composite.c (get_composition_id): Check for integer overflow.
6409 * composite.h: Adjust prototypes to match the above changes.
6410
d3411f89
PE
6411 Use ptrdiff_t for hash table indexes.
6412 * category.c (hash_get_category_set):
6413 * ccl.c (ccl_driver):
6414 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6415 * coding.c (coding_system_charset_list, detect_coding_system):
6416 * coding.h (struct coding_system.id):
6417 * composite.c (get_composition_id, gstring_lookup_cache):
6418 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6419 * image.c (xpm_get_color_table_h):
6420 * lisp.h (hash_lookup, hash_put):
6421 * minibuf.c (Ftest_completion):
6422 Use ptrdiff_t for hash table indexes, not int (which is too
6423 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6424 32-bit --with-wide-int hosts).
6425
e097a6fa
PE
6426 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6427 Add a FIXME comment about memory leaks.
6428 (syms_of_charset): Don't assume xmalloc returns.
6429
5637687f
PE
6430 Don't assume that stated character widths fit in int.
6431 * character.c (Fchar_width, c_string_width, lisp_string_width):
6432 * character.h (CHAR_WIDTH):
6433 * indent.c (MULTIBYTE_BYTES_WIDTH):
6434 Use sanitize_char_width to avoid undefined and/or bad behavior
6435 with outlandish widths.
a66cfb1c 6436 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6437 now that we have two such functions. All uses changed.
6438 (sanitize_char_width): New inline function.
6439
a2271ba2
PE
6440 Don't assume that tab-width fits in int.
6441 * character.h (sanitize_width): New inline function.
6442 (SANE_TAB_WIDTH): New macro.
6443 (ASCII_CHAR_WIDTH): Use it.
6444 * indent.c (sane_tab_width): Remove. All uses replaced by
6445 SANE_TAB_WIDTH (current_buffer).
6446 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6447
18c52557
PE
6448 * fileio.c: Integer overflow issues with file modes.
6449 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6450
caeeedc1
PE
6451 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6452 Remove unreachable code.
6453 (read_hex, load_charset_map_from_file): Check for integer overflow.
6454
6df6ae42 6455 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6456 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6457 (x_send_scroll_bar_event): Likewise. Check that the size does not
6458 exceed limits imposed by XClientMessageEvent, as well as the usual
6459 ptrdiff_t and size_t limits.
6460
b13995db
PE
6461 * keyboard.c: Overflow, signedness and related fixes.
6462 (make_lispy_movement): Use same integer type in forward decl
6463 that is used in the definition.
6464 (read_key_sequence, keyremap_step):
6465 Change bufsize argument back to int, undoing my 2011-03-30 change.
6466 We prefer signed types, and int is wide enough here.
6467 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6468 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6469 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6470 length, not size_t. Use ptrdiff_t for index, not int.
6471 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6472 possibility of integer overflow.
6473
13464394
PE
6474 Overflow, signedness and related fixes for images.
6475
6476 * dispextern.h (struct it.stack[0].u.image.image_id)
6477 (struct_it.image_id, struct image.id, struct image_cache.size)
6478 (struct image_cache.used, struct image_cache.ref_count):
6479 * gtkutil.c (update_frame_tool_bar):
6480 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6481 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6482 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6483 * nsmenu.m (update_frame_tool_bar):
6484 * xdisp.c (calc_pixel_width_or_height):
6485 * xfns.c (image_cache_refcount):
6486 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6487 on typical 64-bit hosts.
6488
6489 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6490 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6491 Omit unnecessary casts to int.
6492 (parse_image_spec): Check that integers fall into 'int' range
6493 when the callers expect that.
6494 (image_ascent): Redo ascent calculation to avoid int overflow.
6495 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6496 (lookup_image): Remove unnecessary tests.
6497 (xbm_image_p): Locals are now of int, not EMACS_INT,
6498 since parse_image_check makes sure they fit into int.
6499 (png_load, gif_load, svg_load_image):
6500 Prefer int to unsigned where either will do.
6501 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6502 old tiff_error_handler and tiff_warning_handler.
6503 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6504 stack buffer overflows. It uses only the features of vsnprintf
6505 that are common to both POSIX and native Microsoft.
6506 (tiff_error_handler, tiff_warning_handler): Use it.
6507 (tiff_load, gif_load, imagemagick_load_image):
6508 Don't assume :index value fits in 'int'.
6509 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6510 (imagemagick_load_image): Check that crop parameters fit into
6511 the integer types that MagickCropImage accepts. Don't assume
6512 Vimagemagick_render_type has a nonnegative value. Don't assume
6513 size_t fits in 'long'.
6514 (gs_load): Use printmax_t to print the widest integers possible.
6515 Check for integer overflow when computing image height and width.
6516
c11821d4
EZ
65172011-08-26 Eli Zaretskii <eliz@gnu.org>
6518
6519 * xdisp.c (redisplay_window): Don't force window start if point
6520 will be invisible in the resulting window. (Bug#9324)
6521
0c95fcf7
EZ
65222011-08-25 Eli Zaretskii <eliz@gnu.org>
6523
6524 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6525 the display spec is of the form `(space ...)'.
6526 (handle_display_spec): Return the value returned by
6527 handle_single_display_spec, not just 1 or zero.
6528 (handle_single_display_spec): If the display spec is of the form
6529 `(space ...)', and specifies display in the text area, return 2
6530 rather than 1.
fee65a97 6531 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6532 accurately, and prefer exact match for point under bidi.
6533 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6534
6535 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6536 into disp_prop; all users changed.
6537
6538 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6539 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6540 for the text covered by the display property.
6541
e4ed06f1
CY
65422011-08-25 Chong Yidong <cyd@stupidchicken.com>
6543
6544 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6545 Change return value to nil.
6546 (Frecord_buffer): Delete unused function.
6547
f67cdd7f
EZ
65482011-08-24 Eli Zaretskii <eliz@gnu.org>
6549
5980d4c6
EZ
6550 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6551 buffers, return left-to-right.
8610fe8b
EZ
6552 (set_cursor_from_row): Consider candidate row a win if its glyph
6553 represents a newline and point is on that newline. Fixes cursor
6554 positioning on the newline at EOL of R2L text within L2R
6555 paragraph, and vice versa.
6556 (try_cursor_movement): Check continued rows, in addition to
6557 continuation rows. Fixes unwarranted scroll when point enters a
6558 continued line of R2L text within an L2R paragraph, or vice versa.
6559 (cursor_row_p): Consider the case of point being equal to
6560 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6561 from the end of a short line to the beginning of a continued line
6562 of R2L text within L2R paragraph.
6563 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6564 composed characters.
5980d4c6 6565
f67cdd7f
EZ
6566 * bidi.c (bidi_check_type): Use xassert.
6567 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6568 members.
6569
bca633fb
EZ
65702011-08-23 Eli Zaretskii <eliz@gnu.org>
6571
6572 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6573 a character.
6574
4a5885a7
CY
65752011-08-23 Chong Yidong <cyd@stupidchicken.com>
6576
6577 * nsfont.m (ns_otf_to_script): Fix typo.
6578
0902a04e
KH
65792011-08-22 Kenichi Handa <handa@m17n.org>
6580
6581 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6582 extra slot even if the purpose is char-code-property-table.
6583
1a2e6670
EZ
65842011-08-23 Eli Zaretskii <eliz@gnu.org>
6585
8ddde651
EZ
6586 * xdisp.c (redisplay_window): When computing centering_position,
6587 account for the height of the header line. (Bug#8874)
6588
425cc014
EZ
6589 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6590 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6591 candidate is selected by the mouse, and that candidate has a
6592 composed character under the mouse.
6593
1a2e6670
EZ
6594 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6595 coordinates reported by pos-visible-in-window-p for a composed
6596 character in column zero.
6597
8b76d6f8
SM
65982011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6599
6600 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6601
dac347dd
EZ
66022011-08-22 Eli Zaretskii <eliz@gnu.org>
6603
6604 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6605 consider it a hit if to_charpos is anywhere in the range of the
6606 composed buffer positions.
6607
e013fb34
CY
66082011-08-22 Chong Yidong <cyd@stupidchicken.com>
6609
6610 * image.c (gif_load): Don't assume that each subimage has the same
6611 dimensions as the base image. Handle disposal method that is
6612 "undefined" by the gif spec (Bug#9335).
6613
bd1ba3e8
CY
66142011-08-20 Chong Yidong <cyd@stupidchicken.com>
6615
6616 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6617 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6618
54a1215b
EZ
66192011-08-19 Eli Zaretskii <eliz@gnu.org>
6620
823564e5
EZ
6621 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6622 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6623 from an Org mode buffer to a Speedbar frame.
6624
54a1215b
EZ
6625 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6626 a composition, take its buffer position from IT->cmp_it.charpos.
6627 Fixes cursor positioning at the beginning of a line that begins
6628 with a composed character.
6629
9778ebcc
EZ
66302011-08-18 Eli Zaretskii <eliz@gnu.org>
6631
0be6ee06
EZ
6632 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6633 character bidirectional type, use STRONG_L instead. Fixes crashes
6634 in a buffer produced by `describe-categories'.
6635
9778ebcc
EZ
6636 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6637 members before the level stack, so they would be saved and
6638 restored when copying iterator state. Fixes incorrect reordering
6639 around TABs covered by display properties.
6640
156bffbe
AS
66412011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6642
6b02f655 6643 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6644
72ad093b
CY
66452011-08-17 Chong Yidong <cyd@stupidchicken.com>
6646
6647 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6648 (internal_condition_case_2, internal_condition_case_n):
6649 Remove unnecessary aborts (Bug#9081).
72ad093b 6650
35774242
EZ
66512011-08-17 Eli Zaretskii <eliz@gnu.org>
6652
6653 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6654 has no `load' handler, try opening the file locally. (Bug#9311)
6655
db76dd85
KB
66562011-08-16 Ken Brown <kbrown@cornell.edu>
6657
6658 * gmalloc.c: Expand comment.
6659
b215eee5
EZ
66602011-08-16 Eli Zaretskii <eliz@gnu.org>
6661
6662 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6663 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6664
a4579d33
KB
66652011-08-16 Ken Brown <kbrown@cornell.edu>
6666
6667 Fix memory allocation problems in Cygwin build (Bug#9273).
6668
6669 * unexcw.c ( __malloc_initialized): Declare external variable.
6670 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6671
8b76d6f8
SM
6672 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6673 New variables.
a4579d33
KB
6674 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6675 dumped emacs.
6676 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6677 in the static heap.
6678 [CYGWIN] (special_realloc): New function.
6679 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6680 requests to realloc storage in the static heap.
6681
3ebec551
PE
66822011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6683
6684 * bidi.c (bidi_initialize): Remove unused local.
6685
9fd8be00
EZ
66862011-08-15 Eli Zaretskii <eliz@gnu.org>
6687
6b02f655
SM
6688 * bidimirror.h:
6689 * biditype.h: Remove file.
6690 * makefile.w32-in ($(BLD)/bidi.$(O)):
6691 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6692
6693 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6694
6695 * chartab.c: Improve commentary for the uniprop_table API.
6696
32413314
EZ
6697 * bidi.c (bidi_paragraph_init): Support zero value of
6698 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6699 (bidi_initialize): Use uniprop_table instead of including
6700 biditype.h and bidimirror.h.
32413314 6701
9fd8be00
EZ
6702 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6703 coordinates of the iterator when restoring from ppos_it.
6704 (Bug#9296)
6705
5cf2b69b
KH
67062011-08-14 Kenichi Handa <handa@m17n.org>
6707
6708 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6709 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6710
daf17d00
EZ
67112011-08-14 Eli Zaretskii <eliz@gnu.org>
6712
6713 * xdisp.c (move_it_in_display_line_to): Don't invoke
6714 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6715 ppos_it. Fixes vertical cursor motion when line beginning is
6716 covered by an image. (Bug#9296)
6717
08e3161a
JD
67182011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6719
6720 * nsterm.h (ns_run_ascript): Declare.
6721 (NSAPP_DATA2_RUNASSCRIPT): Define.
6722
6723 * nsfns.m (as_script, as_result, as_status): New static variables.
6724 (ns_run_ascript): New function.
5e617bc2 6725 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6726 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6727 the event loop. Get status from as_status (Bug#7276).
6728
6729 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6730 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6731 the event loop (Bug#7276).
6732
a3720aa2
AS
67332011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6734
6735 * gnutls.c (QCgnutls_bootprop_priority)
6736 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6737 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6738 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6739 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6740 (QCgnutls_bootprop_verify_hostname_error)
6741 (QCgnutls_bootprop_callbacks_verify): Rename from
6742 Qgnutls_bootprop_..., all uses changed.
6743
6744 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6745 uses changed.
6746
0a0d27fb
PE
67472011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6748
19d5c50c
PE
6749 * xfaces.c (Qframe_set_background_mode): Now static.
6750 * dispextern.h (Qframe_set_background_mode): Remove decl.
6751
0a0d27fb
PE
6752 * process.c (Fnetwork_interface_info): Declare local only if needed.
6753
377538cb
JD
67542011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6755
6756 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6757 (Fnetwork_interface_list): Allocate in increments of bytes instead
6758 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6759 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6760 sockaddr.
6761 (struct ifflag_def): notrailers is smart on OSX.
6762 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6763 Get hardware address with getifaddrs if available.
6764
08fff70c
EZ
67652011-08-12 Eli Zaretskii <eliz@gnu.org>
6766
6767 * xdisp.c (iterate_out_of_display_property): xassert that
6768 IT->position is set to within IT->object's boundaries. Break from
6769 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6770 when IT->position is set up wrongly due to some bug.
6771 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6772 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6773 entry. Force push_it to save on the stack the current
6774 buffer/string position, to be restored by pop_it. Fix flags in
6775 the iterator structure wrt the object coming from a display
6776 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6777 properties. (Bug#9284)
6778
7be1c708 67792011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6780
7be1c708
CY
6781 * fontset.c (fontset_get_font_group): Add proper type checks.
6782 (Bug#9172)
aac0c6e3 6783
7be1c708 67842011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6785
7be1c708
CY
6786 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6787 and LC_VERSION_MIN_MACOSX.
6788 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6789 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6790
97bb72a6
EZ
67912011-08-08 Eli Zaretskii <eliz@gnu.org>
6792
6793 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6794 no-display-properties-and-no-overlays under bidi display.
6795 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6796 properties and overlays.
97bb72a6 6797
d5617611
CY
67982011-08-08 Chong Yidong <cyd@stupidchicken.com>
6799
37e11a63
CY
6800 * editfns.c (Fset_time_zone_rule): Document relationship with the
6801 setenv function.
6802
d5617611
CY
6803 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6804 the font entity extracted from the cache (Bug#8109).
6805
58872834
CY
68062011-08-07 Chong Yidong <cyd@stupidchicken.com>
6807
6808 * composite.c (autocmp_chars): Don't reset point. That is done by
6809 restore_point_unwind (Bug#5984).
6810
75bfc667
JL
68112011-08-07 Juri Linkov <juri@jurta.org>
6812
6813 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6814 to show the arg `TIME' instead of `TIMEVAL'.
6815
d1410150
EZ
68162011-08-06 Eli Zaretskii <eliz@gnu.org>
6817
6818 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6819 display property strides EOL and includes a newline, as in
6820 longlines-mode. (Bug#9254)
75b771e4
EZ
6821 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6822 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6823
6824 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6825 is non-zero, even if the data buffer is NULL. Fixes a crash in
6826 vertical-motion with longlines-mode. (Bug#9254)
6827
35928349
EZ
68282011-08-05 Eli Zaretskii <eliz@gnu.org>
6829
ec7cc85b
EZ
6830 * bidi.c <bidi_cache_total_alloc>: Now static.
6831 (bidi_initialize): Initialize bidi_cache_total_alloc.
6832
8b76d6f8 6833 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6834 cache. (Bug#9221)
6835
6836 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6837 amount allocated this far in `bidi_cache_total_alloc'.
6838 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6839 non-zero, only free the data buffer without restoring the cache
6840 contents. All callers changed.
6841
6842 * dispextern.h (bidi_unshelve_cache): Update prototype.
6843
6844 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6845 (move_it_in_display_line, move_it_to)
6846 (move_it_vertically_backward, move_it_by_lines): Replace the call
6847 to xfree to an equivalent call to bidi_unshelve_cache.
6848 (move_it_in_display_line_to): Fix logic of returning
412b6358 6849 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6850
e2e2423b
EZ
68512011-08-05 Eli Zaretskii <eliz@gnu.org>
6852
6853 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6854 came from a string character with a `cursor' property. (Bug#9229)
6855
ae9e757a
JD
68562011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6857
6858 * Makefile.in (LIB_PTHREAD): New variable.
6859 (LIBES): Add LIB_PTHREAD (Bug#9216).
6860
6861 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6862 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6863
213bd7f2
AS
68642011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6865
6b02f655 6866 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6867
99aaf75f
JD
68682011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6869
6870 * xterm.c (x_find_topmost_parent): New function.
6871 (x_set_frame_alpha): Find topmost parent window with
6872 x_find_topmost_parent and set the property there also (bug#9181).
6873 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6874
c74e9d86
PE
68752011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6876
6877 * callproc.c (Fcall_process): Avoid vfork clobbering
6878 the local vars buffer, coding_systems, current_dir.
6879
640c8776
SM
68802011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6881
6882 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6883
f26d0e4c
PE
68842011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6885
8a10d76c
PE
6886 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6887 so that it is not optimized away.
6888
f26d0e4c
PE
6889 * xdisp.c (compute_display_string_pos): Remove unused local.
6890
55439c61
EZ
68912011-08-02 Eli Zaretskii <eliz@gnu.org>
6892
6893 Fix slow cursor motion and scrolling in large buffers with
6894 selective display, like Org Mode buffers. (Bug#9218)
6895
6896 * dispextern.h (struct bidi_it): New member disp_prop_p.
6897
6898 * xdisp.c: Remove one-slot cache of display string positions.
6899 (compute_display_string_pos): Accept an additional argument
5e617bc2 6900 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6901 for a display string or property. If found, set DISP_PROP_P
6902 non-zero.
6903
6904 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6905 DISP_PROP_P, and pass it to compute_display_string_pos.
6906 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6907 non-zero. All callers of bidi_fetch_char changed.
6908
fb33fa43
SM
69092011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6910
6911 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6912
b099e063
DM
69132010-12-03 Don March <don@ohspite.net>
6914
6915 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6916 last character M-[char] is translated to ESC [char] (bug#7541).
6917
5cc7f7af
KH
69182011-08-02 Kenichi Handa <handa@m17n.org>
6919
d0fffa3f 6920 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6921
6922 * chartab.c (uniprop_table): Make it non-static.
6923
525d5e6e
EZ
69242011-08-01 Eli Zaretskii <eliz@gnu.org>
6925
6926 * xdisp.c (forward_to_next_line_start): Accept additional argument
6927 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6928 on the newline.
6929 (reseat_at_next_visible_line_start): Use the bidi iterator state
6930 returned by forward_to_next_line_start to restore the state of
6931 it->bidi_it after backing up to previous newline. (Bug#9212)
6932
31011111
AS
69332011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6934
6935 * regex.c (re_comp): Protoize.
6936 (re_exec): Fix return type.
6937 (regexec): Fix type of `ret'. (Bug#9203)
6938
476371c4
PE
69392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6940
e5d76069
PE
6941 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6942 This is needed if max-image-size is a floating-point number.
6943
9a79b20c
AS
69442011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6945
6946 * print.c (print_object): Print empty symbol as ##.
6947
6948 * lread.c (read1): Read ## as empty symbol.
6949
d8c2fa78
AA
69502011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6951
6952 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6953 setting frame foreground color (Bug#9175).
6954 (x_set_background_color): Likewise.
6955
ffe57a7a
AA
6956 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6957 contents (Bug#9176).
6958 (EmacsTooltip -init): Remove bezels and add shadows to
6959 tooltip windows.
6960
bf3492a5
AA
6961 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6962 or scroll bar (Bug#8470).
6963
d55e9c53
AA
6964 * nsfont.m (nsfont_open): Remove assignment to voffset and
6965 unnecessary vars hshink, expand, hd, full_height, min_height.
6966 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6967
6968 * nsterm.h (nsfont_info): Remove voffset field.
6969
d8c2fa78 69702011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6971
6972 Implement strike-through and overline on NextStep (Bug#8863).
6973
6974 * nsfont.m (nsfont_open): Use underline position provided by font,
6975 instead of hard-coded value of 2.
6976 (nsfont_draw): Call ns_draw_text_decoration instead.
6977
6978 * nsterm.h: Add declaration for ns_draw_text_decoration.
6979
6980 * nsterm.m (ns_draw_text_decoration): New function for drawing
6981 underline, overline, and strike-through.
6982 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6983 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6984 accommodate underlining, etc.
4843aac3 6985
4cc60b9b
EZ
69862011-07-28 Eli Zaretskii <eliz@gnu.org>
6987
bc7ece87
EZ
6988 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6989 default.
4cc60b9b 6990
476371c4
PE
69912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6992
66606eea
PE
6993 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6994 Without this fix, if a signal arrives just after memory fills up,
6995 'malloc' might be invoked reentrantly.
6996
476371c4
PE
6997 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6998 In other words, assume that every image size is allowed, on non-X
6999 hosts. This assumption is probably wrong, but it lets Emacs compile.
7000
f3fcc40d
AS
70012011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7002
7003 * regex.c (re_iswctype): Convert return values to boolean.
7004
350c992f
EZ
70052011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7006
7007 * xdisp.c (compute_display_string_pos): Don't use cached display
7008 string position if the buffer had its restriction changed.
7009 (Bug#9184)
7010
5266b4bb
PE
70112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7012
7013 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7014
2573a837 70152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7016
41f55ccd 7017 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7018
39e378da
PE
7019 * bidi.c: Integer size and overflow fixes.
7020 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7021 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7022 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7023 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7024 (bidi_find_other_level_edge):
7025 Use ptrdiff_t instead of EMACS_INT where either will do.
7026 This works better on 32-bit hosts configured --with-wide-int.
7027 (bidi_cache_ensure_space): Check for size-calculation overflow.
7028 Use % rather than repeated addition, for better worst-case speed.
7029 Don't set bidi_cache_size until after xrealloc returns, because it
7030 might not return.
7031 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7032 (bidi_cache_ensure_space): Also check that the bidi cache size
7033 does not exceed that of the largest Lisp string or buffer. See Eli
7034 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7035
5e927815
PE
7036 * alloc.c (__malloc_size_t): Remove.
7037 All uses replaced by size_t. See Andreas Schwab's note
7038 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7039
ca4aa935
PE
7040 * image.c: Improve checking for integer overflow.
7041 (check_image_size): Assume that f is nonnull, since
7042 it is always nonnull in practice. This is one less thing to
7043 worry about when checking for integer overflow later.
7044 (x_check_image_size): New function, which checks for integer
7045 overflow issues inside X.
7046 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7047 This removes the need for a memory_full check.
7048 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7049 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7050 (xbm_read_bitmap_data): Change locals back to 'int', since
7051 their values must fit in 'int'.
7052 (xpm_load_image, png_load, tiff_load):
7053 Invoke x_create_x_image_and_pixmap earlier,
7054 to avoid much needless work if the image is too large.
7055 (tiff_load): Treat overly large images as if
7056 x_create_x_image_and_pixmap failed, not as malloc failures.
7057 (gs_load): Use x_check_image_size.
7058
5f8f9cc2
PE
7059 * gtkutil.c: Omit integer casts.
7060 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7061 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7062
5adf60bc
PE
7063 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7064
c8907a93
PE
7065 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7066 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7067 would wrongly return t on a 64-bit host.
7068
e3c25c68
PE
7069 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7070 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7071 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7072 and therefore cause GCC to emit a bogus diagnostic in some cases.
7073
3f791afe
PE
7074 * image.c: Integer signedness and overflow and related fixes.
7075 This is not an exhaustive set of fixes, but it's time to
7076 record what I've got.
7077 (lookup_pixel_color, check_image_size): Remove redundant decls.
7078 (check_image_size): Don't assume that arbitrary EMACS_INT values
7079 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7080 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7081 (tiff_load, imagemagick_load_image):
7082 Check for overflow in size calculations.
7083 (x_create_x_image_and_pixmap): Remove unnecessary test for
7084 xmalloc returning NULL; that can't happen.
7085 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7086 (xpm_color_bucket): Use better integer hashing function.
7087 (xpm_cache_color): Don't possibly over-allocate memory.
7088 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7089 (gif_memory_source):
7090 Use ptrdiff_t, not int or size_t, to record sizes.
7091 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7092 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7093 either works, as we prefer signed integers.
7094 (tiff_read_from_memory, tiff_write_from_memory):
7095 Return tsize_t, not size_t, since that's what the TIFF API wants.
7096 (tiff_read_from_memory): Don't fail simply because the read would
7097 go past EOF; instead, return a short read.
7098 (tiff_load): Omit no-longer-needed casts.
7099 (Fimagemagick_types): Don't assume size fits into 'int'.
7100
3cc5a532
PE
7101 Improve hashing quality when configured --with-wide-int.
7102 * fns.c (hash_string): New function, taken from sxhash_string.
7103 Do not discard information about ASCII character case; this
7104 discarding is no longer needed.
7105 (sxhash-string): Use it. Change sig to match it. Caller changed.
7106 * lisp.h: Declare it.
7107 * lread.c (hash_string): Remove, since we now use fns.c's version.
7108 The fns.c version returns a wider integer if --with-wide-int is
7109 specified, so this should help the quality of the hashing a bit.
7110
b312a492
PE
7111 * emacs.c: Integer overflow minor fix.
7112 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7113 Define only if GNU_LINUX.
7114 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7115
dfd153ae
PE
7116 * dispnew.c: Integer signedness and overflow fixes.
7117 Remove unnecessary forward decls, that were a maintenance hassle.
7118 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7119 All uses changed.
7120 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7121 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7122 (prepare_desired_row, line_draw_cost):
7123 Use int, not unsigned, where either works.
7124 (save_current_matrix, restore_current_matrix):
7125 Use ptrdiff_t, not size_t, where either works.
7126 (init_display): Check for overflow more accurately, and without
7127 relying on undefined behavior.
7128
a81d11a3
PE
7129 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7130 Remove, replacing with the new symbols in lisp.h. All uses changed.
7131 * fileio.c (make_temp_name):
7132 * filelock.c (lock_file_1, lock_file):
7133 * xdisp.c (message_dolog):
7134 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7135 Use pMd etc. instead.
7136 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7137 replacing the pWIDE etc. symbols removed from editfns.c.
7138
3300e6fd
PE
7139 * keyboard.h (num_input_events): Now uintmax_t.
7140 This is (very slightly) less likely to mess up due to wraparound.
7141 All uses changed.
7142
fd05c7e9
PE
7143 * buffer.c: Integer signedness fixes.
7144 (alloc_buffer_text, enlarge_buffer_text):
7145 Use ptrdiff_t rather than size_t when either will do, as we prefer
7146 signed integers.
7147
903fe15d
PE
7148 * alloc.c: Integer signedness and overflow fixes.
7149 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7150 (__malloc_size_t): Default to size_t, not to int.
7151 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7152 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7153 Prefer ptrdiff_t to size_t when either would do, as we prefer
7154 signed integers.
7155 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7156 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7157 Now const. Initialize with values that are in range even if char
7158 is signed.
7159 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7160 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7161 These functions do the right thing with sizes > 2**32.
7162 (check_depth): Now ptrdiff_t, not int.
7163 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7164 Adjust to new way of storing sizes. Check for size overflow bugs
7165 in rest of code.
7166 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7167 slightly wrong anyway, as it missed one instance of
7168 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7169 (refill_memory_reserve): Omit needless cast to size_t.
7170 (mark_object_loop_halt): Mark as externally visible.
7171
ac82cc6a
PE
7172 * xselect.c: Integer signedness and overflow fixes.
7173 (Fx_register_dnd_atom, x_handle_dnd_message):
7174 Use ptrdiff_t, not size_t, since we prefer signed.
7175 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7176 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7177 x_dnd_atoms_size and x_dnd_atoms_length.
7178
c2d1e36d
PE
7179 * doprnt.c: Prefer signed to unsigned when either works.
7180 * eval.c (verror):
7181 * doprnt.c (doprnt):
7182 * lisp.h (doprnt):
7183 * xdisp.c (vmessage):
7184 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7185 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7186 prefer signed arithmetic to avoid comparison confusion.
7187 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7188 but is a bit tricky.
7189
0e926e56
PE
7190 Assume freestanding C89 headers, string.h, stdlib.h.
7191 * data.c, doprnt.c, floatfns.c, print.c:
7192 Include float.h unconditionally.
7193 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7194 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7195 * regex.c: Likewise for stddef.h, string.h.
7196 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7197 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7198 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7199 (STDC_HEADERS): Remove obsolete defines.
7200 * sysdep.c: Include limits.h unconditionally.
7201
9cfdb3ec
PE
7202 Assume support for memcmp, memcpy, memmove, memset.
7203 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7204 * regex.c (memcmp, memcpy):
7205 Remove; we assume C89 now.
7206
7207 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7208 (__malloc_safe_bcopy): Remove; no longer needed.
7209
cf950e6b 7210 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7211 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7212 well either way, and we prefer signed to unsigned.
7213
dbf38e02
LMI
72142011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7215
7216 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7217 closes the connection while we're reading (bug#9182).
7218
d6f0886c 72192011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7220
d6f0886c
JD
7221 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7222 are specified (Bug#9168).
24e0f6b1 7223
2eb1f9e6
PE
72242011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7225
7226 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7227 Found by GCC static checking and --with-wide-int on a 32-bit host.
7228
22381272 72292011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7230
7231 * xdisp.c (compute_display_string_pos): Fix logic of caching
7232 previous display string position. Initialize cached_prev_pos to
7233 -1. Fixes slow-down at the beginning of a buffer.
7234
f25e39b4
EZ
72352011-07-24 Eli Zaretskii <eliz@gnu.org>
7236
7237 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7238 for attrs[LFACE_FONTSET_INDEX].
7239
04c4b52e
PE
72402011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7241
7242 * xml.c (parse_region): Remove unused local
7243 that was recently introduced.
7244
c1734fbd
EZ
72452011-07-23 Eli Zaretskii <eliz@gnu.org>
7246
be18c5a5
EZ
7247 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7248 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7249
c1734fbd
EZ
7250 * xdisp.c (move_it_in_display_line_to): Record the best matching
7251 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7252 exit if none of the characters scanned was an exact match.
7253 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7254 when exact match is impossible due to invisible text, and the
7255 lines are truncated.
7256
a258d627
JD
72572011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7258
7259 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7260 for OSX >= 10.7.
7261
b6d5a689
EZ
72622011-07-22 Eli Zaretskii <eliz@gnu.org>
7263
0f74f785
EZ
7264 Fix a significant slow-down of cursor motion with C-n, C-p,
7265 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7266 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7267 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7268 (next_element_from_buffer): Call compute_stop_pos_backwards to
7269 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7270 base_level_stop.
7271 (reseat): Don't look for prev_stop, as that could mean a very long
7272 run.
7273 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7274 <cached_disp_overlay_modiff>: Cache for last found display string
7275 position.
551918c1 7276 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7277 about the same buffer in the same area of character positions, and
7278 the buffer wasn't changed since the time the display string
7279 position was cached.
551918c1 7280
b2d0c91a
EZ
72812011-07-22 Eli Zaretskii <eliz@gnu.org>
7282
7283 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7284 is an integer, which is important for empty lines. (Bug#9149)
7285
043604ee
CY
72862011-07-22 Chong Yidong <cyd@stupidchicken.com>
7287
7288 * frame.c (Fmodify_frame_parameters): In tty case, update the
7289 default face if necessary (Bug#4238).
7290
da4adb04
CY
72912011-07-21 Chong Yidong <cyd@stupidchicken.com>
7292
7293 * editfns.c (Fstring_to_char): No need to explain what a character
7294 is in the docstring (Bug#6576).
7295
9abd0532
LMI
72962011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7297
7298 * xml.c (parse_region): Make sure we always return a tree.
7299
36881d16
HK
73002011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7301
7302 * xml.c (parse_region): If a document contains only comments,
7303 return that, too.
7304
1e98674d
LMI
73052011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7306
7307 * xml.c (make_dom): Return comments, too.
7308
590bd467
PE
73092011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7310
7311 Port to OpenBSD.
7312 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7313 and the surrounding thread.
7314 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7315 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7316 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7317 timer goes off.
7318 * s/openbsd.h (BROKEN_SIGIO): Define.
7319 * unexelf.c (unexec) [__OpenBSD__]:
7320 Don't update the .mdebug section of the Alpha COFF symbol table.
7321
f41628b2
LMI
73222011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7323
7324 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7325 (bug#8460).
7326
b59b67c5
PE
73272011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7328
15e3a074
PE
7329 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7330 This fixes some race conditions on the permissions of any newly
7331 created file.
7332
41bed37d
PE
7333 * alloc.c (valid_pointer_p): Use pipe, not open.
7334 This fixes some permissions issues when debugging.
7335
b59b67c5
PE
7336 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7337 If fchown fails to set both uid and gid, try to set just gid,
7338 as that is sometimes allowed. Adjust the file's mode to eliminate
7339 setuid or setgid bits that are inappropriate if fchown fails.
7340
925a6be7
SM
73412011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7342
7343 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7344 to compare Lisp_Objects.
7345 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7346 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7347 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7348
52968808
AS
73492011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7350
0a6a104b
AS
7351 * lread.c (read_integer): Unread even EOF character.
7352 (read1): Likewise. Properly record start position of symbol.
7353
52968808
AS
7354 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7355 symbol character follows.
7356
9e381cdd
PE
73572011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7358
7359 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7360 This works around a problem with the previous change to Fcopy_file.
7361 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7362 and without this change, GCC might complain about discarding
7363 fchown's return value.
7364
b5641435
JB
73652011-07-16 Juanma Barranquero <lekktu@gmail.com>
7366
7367 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7368
a8031457
PE
73692011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7370
7371 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7372
dd889327
LMI
73732011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7374
750c33f7
LMI
7375 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7376 it's used from the C level.
7377
dd889327
LMI
7378 * process.c: Use the same condition for POLL_FOR_INPUT in both
7379 keyboard.c and process.c (bug#1858).
7380
87e86684
LM
73812011-07-09 Lawrence Mitchell <wence@gmx.li>
7382
7383 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7384 (Fgnutls_boot): Use it.
7385
64348f40
AS
73862011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7387
7388 * doc.c (Fsubstitute_command_keys): Revert last change.
7389
1d698799
LMI
73902011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7391
f863868c
LMI
7392 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7393 quotes the next character, and doesn't affect other longer
7394 sequences (bug#8935).
7395
1d698799
LMI
7396 * lread.c (syms_of_lread): Clarify that is isn't only
7397 `eval-buffer' and `eval-defun' that's affected by
7398 `lexical-binding' (bug#8460).
7399
aa4b6df6
EZ
74002011-07-15 Eli Zaretskii <eliz@gnu.org>
7401
7402 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7403 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7404
5d856da6
PE
74052011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7406
ad6042bb
PE
7407 Fix minor problems found by static checking.
7408 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7409 (elsz): Now a signed constant, not a size_t var. We prefer signed
7410 types to unsigned, to avoid integer comparison confusion. Without
7411 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7412 "cannot optimize loop, the loop counter may overflow", a symptom
7413 of the confusion.
f00bbb22 7414 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7415 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7416
6468f31c
LMI
74172011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7418
49080b10
LMI
7419 * search.c (Fre_search_backward): Mention `case-fold-search' in
7420 all the re_search_* functions (bug#8138).
7421
6468f31c
LMI
7422 * keyboard.c (Fopen_dribble_file): Document when the file is
7423 closed (bug#8056).
7424
c965adc5
EZ
74252011-07-14 Eli Zaretskii <eliz@gnu.org>
7426
df9733bf
EZ
7427 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7428 bidi_cache_idx.
7429
0bb23927
EZ
7430 Support bidi reordering of display and overlay strings.
7431 * xdisp.c (compute_display_string_pos)
7432 (compute_display_string_end): Accept additional argument STRING.
7433 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7434 (reseat_to_string): Initialize bidi_it->string.s and
7435 bidi_it->string.schars.
7436 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7437 NULL (avoids a crash in bidi_paragraph_init).
7438 Initialize itb.string.lstring.
0bb23927
EZ
7439 (init_iterator): Call bidi_init_it only of a valid
7440 buffer position was specified. Initialize paragraph_embedding to
7441 L2R.
7442 (reseat_to_string): Initialize the bidi iterator.
7443 (display_string): If we need to ignore text properties of
7444 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7445 original value of -1 will not work with bidi.)
7446 (compute_display_string_pos): First arg is now struct
7447 `text_pos *'; all callers changed. Support display properties on
7448 Lisp strings.
7449 (compute_display_string_end): Support display properties on Lisp
7450 strings.
7451 (init_iterator, reseat_1, reseat_to_string): Initialize the
7452 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7453 when iterating on a string not from display properties).
640c8776
SM
7454 (compute_display_string_pos, compute_display_string_end):
7455 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7456 arrow keys.
7457 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7458 base_level_stop; instead, set base_level_stop to BEGV.
7459 Fixes crashes in vertical-motion.
0bb23927
EZ
7460 (next_element_from_buffer): Improve commentary for when
7461 the iterator is before prev_stop.
7462 (init_iterator): Initialize bidi_p from the default value of
7463 bidi-display-reordering, not from buffer-local value. Use the
7464 buffer-local value only if initializing for buffer iteration.
7465 (handle_invisible_prop): Support invisible properties on strings
7466 that are being bidi-reordered.
7467 (set_iterator_to_next): Support bidi reordering of C strings and
7468 Lisp strings.
7469 (next_element_from_string): Support bidi reordering of Lisp
7470 strings.
7471 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7472 (display_string): Support display of R2L glyph rows.
7473 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7474 (init_iterator): Don't initialize it->bidi_p for strings
7475 here.
7476 (reseat_to_string): Initialize it->bidi_p for strings here.
7477 (next_element_from_string, next_element_from_c_string)
7478 (next_element_from_buffer): Add xassert's for correspondence
7479 between IT's object being iterated and it->bidi_it.string
7480 structure.
7481 (face_before_or_after_it_pos): Support bidi iteration.
7482 (next_element_from_c_string): Handle the case of the first string
7483 character that is not the first one in the visual order.
7484 (get_visually_first_element): New function, refactored from common
7485 parts of next_element_from_buffer, next_element_from_string, and
7486 next_element_from_c_string.
7487 (tool_bar_lines_needed, redisplay_tool_bar)
7488 (display_menu_bar): Force left-to-right direction. Add a FIXME
7489 comment for making that be controlled by a user option.
7490 (push_it, pop_it): Save and restore the state of the
7491 bidi iterator. Save and restore the bidi_p flag.
7492 (pop_it): Iterate out of display property for string iteration as
7493 well.
7494 (iterate_out_of_display_property): Support iteration over strings.
7495 (handle_single_display_spec): Set up it->bidi_it for iteration
7496 over a display string, and call bidi_init_it.
7497 (handle_single_display_spec, next_overlay_string)
7498 (get_overlay_strings_1, push_display_prop): Set up the bidi
7499 iterator for displaying display or overlay strings.
7500 (forward_to_next_line_start): Don't use the shortcut if
7501 bidi-iterating.
7502 (back_to_previous_visible_line_start): If handle_display_prop
7503 pushed the iterator stack, restore the internal state of the bidi
7504 iterator by calling bidi_pop_it same number of times.
7505 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7506 and we are bidi-iterating, don't decrement the iterator position;
7507 instead, set the first_elt flag in the bidi iterator, to produce
7508 the same effect.
7509 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7510 (push_display_prop): xassert that we are iterating a buffer.
7511 (push_it, pop_it): Save and restore paragraph_embedding member.
7512 (handle_single_display_spec, next_overlay_string)
7513 (get_overlay_strings_1, reseat_1, reseat_to_string)
7514 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7515 correctly. Don't assume unibyte strings are not bidi-reordered.
7516 (compute_display_string_pos)
7517 (compute_display_string_end): Fix handling the case of C string.
7518 (push_it, pop_it): Save and restore from_disp_prop_p.
7519 (handle_single_display_spec, push_display_prop): Set the
7520 from_disp_prop_p flag.
7521 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7522 (pop_it): Call iterate_out_of_display_property only if we are
7523 popping after iteration over a string that came from a display
7524 property. Fix a typo in popping stretch info. Add an assertion
7525 for verifying that the iterator position is in sync with the bidi
7526 iterator.
7527 (handle_single_display_spec, get_overlay_strings_1)
7528 (push_display_prop): Fix initialization of paragraph direction for
7529 string when that of the parent object is not yet determined.
7530 (reseat_1): Call bidi_init_it to resync the bidi
7531 iterator with IT's position. (Bug#7616)
7532 (find_row_edges): If ROW->start.pos gives position
7533 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7534 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7535 Reset the from_disp_prop_p flag.
7536 (SAVE_IT, RESTORE_IT): New macros.
7537 (pos_visible_p, face_before_or_after_it_pos)
7538 (back_to_previous_visible_line_start)
7539 (move_it_in_display_line_to, move_it_in_display_line)
7540 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7541 (try_scrolling, redisplay_window, display_line): Use them when
7542 saving a temporary copy of the iterator and restoring it back.
7543 (back_to_previous_visible_line_start, reseat_1)
7544 (init_iterator): Empty the bidi cache "stack".
7545 (move_it_in_display_line_to): If iterator ended up at
7546 EOL, but we never saw any buffer positions smaller than
7547 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7548 motion in bidi-reordered lines.
7549 (move_it_in_display_line_to): Record prev_method and prev_pos
7550 immediately before the call to set_iterator_to_next. Fixes cursor
7551 motion in bidi-reordered lines with stretch glyphs and strings
7552 displayed in margins. (Bug#8133) (Bug#8867)
7553 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7554 TO_CHARPOS.
640c8776
SM
7555 (pos_visible_p): Support positions in bidi-reordered lines.
7556 Save and restore bidi cache.
0bb23927
EZ
7557
7558 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7559 (bidi_paragraph_info): Delete unused struct.
7560 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7561 (bidi_cache_start): New variable.
7562 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7563 to zero.
7564 (bidi_cache_fetch_state, bidi_cache_search)
7565 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7566 (bidi_cache_find, bidi_peek_at_next_level)
7567 (bidi_level_of_next_char, bidi_find_other_level_edge)
7568 (bidi_move_to_visually_next): Compare cache index with
7569 bidi_cache_start rather than with zero.
7570 (bidi_fetch_char): Accept new argument STRING; all callers
7571 changed. Support iteration over a string. Support strings with
7572 display properties. Support unibyte strings. Fix the type of
7573 `len' according to what STRING_CHAR_AND_LENGTH expects.
7574 (bidi_paragraph_init, bidi_resolve_explicit_1)
7575 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7576 (bidi_level_of_next_char, bidi_move_to_visually_next):
7577 Support iteration over a string.
0bb23927
EZ
7578 (bidi_set_sor_type, bidi_resolve_explicit_1)
7579 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7580 can now be zero (for strings); special values 0 and -1 were
7581 changed to -1 and -2, respectively.
7582 (bidi_char_at_pos): New function.
7583 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7584 Call it instead of FETCH_MULTIBYTE_CHAR.
7585 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7586 initialized to valid values.
7587 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7588 values.
7589 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7590 the test for valid cached positions. Fix the logic for looking up
7591 the sentinel state in the cache. GCPRO the Lisp string we are
7592 iterating.
7593 (bidi_push_it, bidi_pop_it): New functions.
7594 (bidi_initialize): Initialize the bidi cache start stack pointer.
7595 (bidi_cache_ensure_space): New function, refactored from part of
7596 bidi_cache_iterator_state. Don't assume the required size is just
7597 one BIDI_CACHE_CHUNK away.
7598 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7599 (bidi_count_bytes, bidi_char_at_pos): New functions.
7600 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7601 always valid if bidi_cache_idx is valid.
7602 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7603 is valid if it's going to be used.
7604 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7605 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7606 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7607 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7608 (bidi_find_other_level_edge, bidi_cache_start_stack):
7609 All variables related to cache indices are now EMACS_INT.
c965adc5 7610
0bb23927
EZ
7611 * dispextern.h (struct bidi_string_data): New structure.
7612 (struct bidi_it): New member `string'. Make flag members be 1-bit
7613 fields, and put them last in the struct.
640c8776
SM
7614 (compute_display_string_pos, compute_display_string_end):
7615 Update prototypes.
0bb23927
EZ
7616 (bidi_push_it, bidi_pop_it): Add prototypes.
7617 (struct iterator_stack_entry): New members bidi_p,
7618 paragraph_embedding, and from_disp_prop_p.
7619 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7620 (bidi_shelve_cache, bidi_unshelve_cache):
7621 Declare prototypes.
0bb23927
EZ
7622
7623 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7624 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7625 and vector-like objects.
7626
7627 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7628 cache around display iteration.
7629
7630 * window.c (Fwindow_end, window_scroll_pixel_based)
7631 (displayed_window_lines, Frecenter): Save and restore the bidi
7632 cache around display iteration.
7633
3bbd2265
LMI
76342011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7635
7636 * editfns.c (Fdelete_region): Clarify the use of the named
7637 parameters (bug#6788).
7638
adc47434
MR
76392011-07-14 Martin Rudalics <rudalics@gmx.at>
7640
7641 * indent.c (Fvertical_motion): Set and restore w->pointm when
7642 saving and restoring the window's buffer (Bug#9006).
7643
837c31f8
LMI
76442011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7645
7646 * editfns.c (Fstring_to_char): Clarify just what is returned
7647 (bug#6576). Text by Eli Zaretskii.
7648
ac389d0c
JB
76492011-07-13 Juanma Barranquero <lekktu@gmail.com>
7650
7651 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7652
0be0ce47
EZ
76532011-07-13 Eli Zaretskii <eliz@gnu.org>
7654
7655 * buffer.c (mmap_find): Fix a typo.
7656
cd18e7e3
JB
76572011-07-13 Johan Bockgård <bojohan@gnu.org>
7658
7659 Fix execution of x selection hooks.
7660 * xselect.c (Qx_lost_selection_functions)
7661 (Qx_sent_selection_functions): New vars.
7662 (syms_of_xselect): DEFSYM them.
7663 (x_handle_selection_request): Pass Qx_sent_selection_functions
7664 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7665 (x_handle_selection_clear,x_clear_frame_selections):
7666 Pass Qx_lost_selection_functions rather than
7667 Vx_lost_selection_functions to Frun_hook_with_args.
7668
47ea7f44
PE
76692011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7670
ac389d0c 7671 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7672 The old code sometimes used this field without initializing it.
7673
47ea7f44
PE
7674 * alloc.c (gc_sweep): Don't read past end of array.
7675 In theory, the old code could also have corrupted Emacs internals,
7676 though it'd be very unlikely.
7677
bc985c87
AS
76782011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7679
7680 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7681 argument. (Bug#4026)
bc985c87 7682
0cf34688
LMI
76832011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7684
b3dadd76
LMI
7685 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7686 key" (bug#4257).
7687
0cf34688
LMI
7688 * window.c (Fset_window_start): Doc fix (bug#4199).
7689 (Fset_window_hscroll): Ditto.
7690
270768cd
PE
76912011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7692
077e3dda 7693 Fix minor new problems caught by GCC 4.6.1.
270768cd 7694 * term.c (init_tty): Remove unused local.
490011a6 7695 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7696 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7697 not used otherwise.
270768cd 7698
b1f58454
CY
76992011-07-12 Chong Yidong <cyd@stupidchicken.com>
7700
7701 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7702
22b9578d
LMI
77032011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7704
6e70ab07
LMI
7705 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7706 are the mini-buffer and the echo area (bug#3320).
7707
22b9578d
LMI
7708 * term.c (init_tty): Remove support for supdup, c10 and perq
7709 terminals, which are no longer supported (bug#1482).
7710
8974cc9f
JB
77112011-07-10 Johan Bockgård <bojohan@gnu.org>
7712
7713 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7714
a560d974
JD
77152011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7716
7717 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7718 for non-popups (Bug#3642).
7719
1dae0f0a
AS
77202011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7721
268c2c36 7722 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7723 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7724 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7725 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7726 * data.c (fmod): Likewise.
7727 * dispnew.c (swap_glyphs_in_rows): Likewise.
7728 * emacs.c (memory_warning_signal): Likewise.
7729 * floatfns.c (float_error): Likewise.
7730 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7731 (otf_open, font_otf_capability, generate_otf_features)
7732 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7733 Likewise.
7734 * image.c (pbm_read_file): Likewise.
7735 * indent.c (string_display_width): Likewise.
7736 * intervals.c (check_for_interval, search_for_interval)
7737 (inc_interval_count, count_intervals, root_interval)
7738 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7739 * lread.c (defalias): Likewise.
268c2c36 7740 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7741 * regex.c (set_image_of_range_1, set_image_of_range)
7742 (regex_grow_registers): Likewise.
7743 * sysdep.c (strerror): Likewise.
7744 * termcap.c (valid_filename_p, tprint, main): Likewise.
7745 * tparam.c (main): Likewise.
7746 * unexhp9k800.c (run_time_remap, save_data_space)
7747 (update_file_ptrs, read_header, write_header, calculate_checksum)
7748 (copy_file, copy_rest, display_header): Likewise.
7749 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7750 Likewise.
7751 * xdisp.c (check_it): Likewise.
7752 * xfaces.c (register_color, unregister_color, unregister_colors):
7753 Likewise.
7754 * xfns.c (print_fontset_result): Likewise.
7755 * xrdb.c (member, fatal, main): Likewise.
7756
99033785
PE
77572011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7758
7759 Fix minor problems found by static checking (Bug#9031).
7760 * chartab.c (char_table_set_range, map_sub_char_table):
7761 Remove unused locals.
7762 (uniprop_table): Now static.
7763 * composite.c (_work_char): Remove unused static var.
7764
9cb2ac56
JB
77652011-07-09 Juanma Barranquero <lekktu@gmail.com>
7766
7767 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7768
f25661f0
JD
77692011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7770
7771 * gtkutil.c (qttip_cb): Remove code without function.
7772
8278c4fe
EZ
77732011-07-09 Eli Zaretskii <eliz@gnu.org>
7774
7775 * w32.c (pthread_sigmask): New stub.
7776
1692ae2d 77772011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7778
8a6ebd58 7779 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7780 sigprocmask is portable only for single-threaded applications, and
7781 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7782 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7783 (LIBES): Use it.
7784 * callproc.c (Fcall_process):
7785 * process.c (create_process):
7786 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7787 Use pthread_sigmask, not sigprocmask.
123403e4 7788
1b854618
JD
77892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7790
7791 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7792 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7793 wrong (Bug#8591).
7794
3fe4b549
JD
77952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7796
0ce7e563
JD
7797 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7798 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7799 (xg_hide_tooltip): Fix comment.
7800
3fe4b549
JD
7801 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7802 in registerServicesMenuSendTypes.
7803 (validRequestorForSendType): Don't check ns_return_types.
7804
7805 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7806 ns_return_type.
7807
5df75e47
JR
78082011-07-08 Jason Rumney <jasonr@gnu.org>
7809
22610910
JR
7810 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7811 SH_SHOW for hidden windows (Bug#5482).
7812
5df75e47
JR
7813 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7814 frame struct members of non-existent frames (Bug#6284).
7815
699c10bd
JD
78162011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7817
4393663b
JD
7818 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7819 variable firstTime not needed on OSX >= 10.6.
7820 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7821 >= 10.5. Use setKnobProportion, setDoubleValue.
7822
7823 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7824 (MAC_OS_X_VERSION_10_5): Define if not defined.
7825 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7826 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7827 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7828
7829 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 7830 cString and lossyCString on OSX >= 10.4.
4393663b 7831
58179cce 7832 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7833 sizeToFit on OSX >= 10.2.
7834
7835 * nsimage.m (allocInitFromFile): Don't use deprecated method
7836 bestRepresentationForDevice on OSX >= 10.6.
7837
7838 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7839 to avoid warning.
7840
7841 * emacs.c: Declare unexec_init_emacs_zone.
7842
a63e0781
JD
7843 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7844
699c10bd
JD
7845 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7846
7847 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7848 on svcsMenu (Bug#8842).
7849
7850 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7851 ns_return_types.
7852 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7853
7854 * nsterm.m (QUTF8_STRING): Declare.
7855 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7856 (validRequestorForSendType): Return type is (id).
7857 Change indexOfObjectIdenticalTo to indexOfObject.
7858 Check if we have local selection before returning self (Bug#8842).
7859 (writeSelectionToPasteboard): Put local selection into paste board
7860 if we have a local selection (Bug#8842).
7861 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7862
7863 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7864 (ns_get_local_selection): Declare.
7865
54e10184
LMI
78662011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7867
9888ff71
LMI
7868 * keymap.c (describe_map_tree): Don't insert a double newline at
7869 the end of the buffer (bug#1169) and return whether we inserted
7870 something.
7871
54e10184
LMI
7872 * callint.c (Fcall_interactively): Change "reading args" to
7873 "providing args" to try to clarify what it does (bug#1010).
7874
15fa4783
KH
78752011-07-07 Kenichi Handa <handa@m17n.org>
7876
7877 * composite.c (composition_compute_stop_pos): Ignore a static
7878 composition starting before CHARPOS (Bug#8915).
7879
7880 * xdisp.c (handle_composition_prop): Likewise.
7881
a8815b00
EZ
78822011-07-07 Eli Zaretskii <eliz@gnu.org>
7883
7884 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7885 (Bug#9015)
7886
ef7b981d 78872011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7888
7889 * character.h (unicode_category_t): New enum type.
7890
7891 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7892 (Qchar_code_property_table): New variable.
7893 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7894 (UNIPROP_COMPRESSED_FORM_P): New macros.
7895 (char_table_ascii): Uncompress the compressed values.
7896 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7897 Uncompress the compressed values.
ac389d0c 7898 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7899 (char_table_ref_and_range): Uncompress the compressed values.
7900 (sub_char_table_set): New arg is_uniprop. Callers changed.
7901 Uncompress the compressed values.
7902 (sub_char_table_set_range): Args changed. Callers changed.
7903 (char_table_set_range): Adjuted for the above change.
7904 (map_sub_char_table): Delete args default_val and parent. Add arg
7905 top. Give decoded values to a Lisp function.
640c8776 7906 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7907 values to a Lisp function. Gcpro more variables.
7908 (uniprop_table_uncompress)
7909 (uniprop_decode_value_run_length): New functions.
7910 (uniprop_decoder, uniprop_decoder_count): New variables.
7911 (uniprop_get_decoder, uniprop_encode_value_character)
7912 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7913 New functions.
7914 (uniprop_encoder, uniprop_encoder_count): New variables.
7915 (uniprop_get_encoder, uniprop_table)
7916 (Funicode_property_table_internal, Fget_unicode_property_internal)
7917 (Fput_unicode_property_internal): New functions.
7918 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7919 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7920 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7921 char-code-property-alist.
7922
640c8776 7923 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7924 Vunicode_category_table.
7925
640c8776 7926 * font.c (font_range): Adjust for the change of
c805dec0
KH
7927 Vunicode_category_table.
7928
76b397fb
DN
79292011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7930
7931 * m/iris4d.h: Remove file, move contents ...
7932 * s/irix6-5.h: ... here.
7933
22b4128e
PE
79342011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7935
7936 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7937 * alloc.c (mark_buffer):
7938 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7939 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7940 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7941 This isn't true in general, and it's particularly not true
7942 if Emacs is configured with --with-wide-int.
7943 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7944 New macros, used in the buffer.c change.
7945
869795d6
JD
79462011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7947
7948 * xsettings.c: Use both GConf and GSettings if both are available.
7949 (store_config_changed_event): Add comment.
7950 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7951 (store_tool_bar_style_changed): New functions.
5e617bc2 7952 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7953 (struct xsettings): Move font inside HAVE_XFT.
7954 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7955 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7956 Move inside HAVE_XFT.
640c8776 7957 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7958 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7959 also.
7960 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7961 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7962 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7963 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7964 (parse_settings): Move check for font inside HAVE_XFT.
7965 (read_settings, apply_xft_settings): Add comment.
7966 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7967 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7968 call store_font_name_changed.
7969 (xft_settings_event): Add comment.
7970 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7971 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7972 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7973 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7974 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7975 (xsettings_get_system_font, xsettings_get_system_normal_font):
7976 Add comment.
869795d6 7977
d8ed26bd
PE
79782011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7979
7980 Random fixes. E.g., (random) never returned negative values.
7981 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7982 subseconds part to the entropy, as that's a bit more random.
7983 Prefer signed to unsigned, since the signedness doesn't matter and
7984 in general we prefer signed. When given a limit, use a
7985 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7986 latter isn't right if USE_2_TAGS_FOR_INTS.
7987 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7988 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7989
cabf1cac
SM
79902011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7991
7992 * textprop.c (text_property_stickiness):
7993 Obey Vtext_property_default_nonsticky.
7994 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7995 * w32fns.c (syms_of_w32fns):
7996 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7997
6e9b2be9
PE
79982011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7999
8000 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8001 This is more efficient than Ffile_directory_p and avoids a minor race.
8002
90186c68
LMI
80032011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8004
7c301272
LMI
8005 * buffer.c (Foverlay_put): Say what the return value is
8006 (bug#7835).
8007
c4f2d8d4
LMI
8008 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8009 is a directory before asking whether to use the file name
8010 (bug#7564).
ad637907
LMI
8011 (barf_or_query_if_file_exists): Make the "File is a directory"
8012 error be more correct.
c4f2d8d4 8013
90186c68
LMI
8014 * fns.c (Frequire): Remove the mention of the .gz files, since
8015 that's installation-specific, but keep the mention of
8016 `get-load-suffixes'.
8017
da64016e
PE
80182011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8019
8020 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8021 Report string overflow if the output is too long.
8022
7d47b580
JB
80232011-07-04 Juanma Barranquero <lekktu@gmail.com>
8024
a555cb87
JB
8025 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8026 (syms_of_gnutls): Remove duplicate DEFSYM for
8027 Qgnutls_bootprop_verify_hostname_error, an error for
8028 Qgnutls_bootprop_verify_error (which is no longer used).
8029
7d47b580
JB
8030 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8031 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8032 Also (re)move comments that are misplaced or no longer relevant.
8033
1e49bfab
LMI
80342011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8035
8036 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8037
1485f4c0
CY
80382011-07-03 Chong Yidong <cyd@stupidchicken.com>
8039
8040 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8041 and background color parameters if they have been changed.
8042
a9ab721e
LMI
80432011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8044
8045 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8046
cf7cff57
PE
80472011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8048
2e13213d
PE
8049 * xsettings.c (SYSTEM_FONT): Define only when used.
8050 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8051
cf7cff57
PE
8052 * keymap.c (access_keymap_1): Now static.
8053
7a8e04f7
CY
80542011-07-02 Chong Yidong <cyd@stupidchicken.com>
8055
8056 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8057 leave any prefix arg for the up event (Bug#1586).
8058
61352f62
LMI
80592011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8060
69bb1ef7
LMI
8061 * lread.c (syms_of_lread): Mention single symbols defined by
8062 `defvar' or `defconst' (bug#7154).
8063
61352f62 8064 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8065 (Frequire): Mention get-load-suffixes.
61352f62 8066
28545e04
MR
80672011-07-02 Martin Rudalics <rudalics@gmx.at>
8068
8069 * window.h (window): Remove clone_number slot.
8070 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8071 Remove.
8072 (make_parent_window, make_window, saved_window)
8073 (Fset_window_configuration, save_window_save): Don't deal with
8074 clone numbers.
8075 * buffer.c (Qclone_number): Remove declaration.
8076 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8077
3349e122
SM
80782011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8079
8080 Add multiple inheritance to keymaps.
8081 * keymap.c (Fmake_composed_keymap): New function.
8082 (Fset_keymap_parent): Simplify.
8083 (fix_submap_inheritance): Remove.
8084 (access_keymap_1): New function extracted from access_keymap to handle
8085 embedded parents and handle lists of maps.
8086 (access_keymap): Use it.
8087 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8088 (Fcopy_keymap): Handle embedded parents.
8089 (Fcommand_remapping, define_as_prefix): Simplify.
8090 (Fkey_binding): Simplify.
8091 (syms_of_keymap): Move minibuffer-local-completion-map,
8092 minibuffer-local-filename-completion-map,
8093 minibuffer-local-must-match-map, and
8094 minibuffer-local-filename-must-match-map to Elisp.
8095 (syms_of_keymap): Defsubr make-composed-keymap.
8096 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8097 (parse_menu_item): Trivial simplification.
8098
3279eb87
GM
80992011-07-01 Glenn Morris <rgm@gnu.org>
8100
8101 * Makefile.in (SETTINGS_LIBS): Fix typo.
8102
4550efdf
KI
81032011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8104
8105 * coding.c (Fencode_coding_string): Record the last coding system
8106 used, as the function doc string says (bug#8738).
8107
0949d2b6
JD
81082011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8109
8110 * xsettings.c (store_monospaced_changed): Take new font as arg and
8111 check for change against current_mono_font.
8112 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8113 (emacs_settings_constructor, emacs_settings_get_property)
8114 (emacs_settings_set_property, emacs_settings_class_init)
8115 (emacs_settings_init, gsettings_obj): Remove.
8116 (something_changedCB): New function for HAVE_GSETTINGS.
8117 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8118 with value as argument.
8119 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8120 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8121 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8122 "changed".
8123
8124 * xgselect.c: Add defined (HAVE_GSETTINGS).
8125 (xgselect_initialize): Ditto.
8126
8127 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8128 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8129 xg_select.
8130
bbc6b304
PE
81312011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8132
8133 * eval.c (struct backtrace): Simplify and port the data structure.
8134 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8135 signed bit field, as this assumption is not portable and it makes
8136 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8137 "char debug_on_exit : 1" as this is not portable either; instead,
8138 use the portable "unsigned int debug_on_exit : 1". Remove unused
8139 member evalargs. Remove obsolete comments about cc bombing out.
8140
9851bfc5
JD
81412011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8142
51bb811f 8143 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8144 Let HAVE_GSETTINGS override HAVE_GCONF.
8145 (store_monospaced_changed): New function.
8146 (EMACS_SETTINGS): A new type derived from GObject to handle
8147 GSettings notifications.
8148 (emacs_settings_constructor, emacs_settings_get_property)
8149 (emacs_settings_set_property, emacs_settings_class_init):
8150 New functions.
8151 (gsettings_client, gsettings_obj): New variables.
8152 (GSETTINGS_SCHEMA): New define.
8153 (something_changedCB): Call store_monospaced_changed.
8154 (init_gsettings): New function.
8155 (xsettings_initialize): Call init_gsettings.
8156 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8157 to NULL.
8158
640c8776 8159 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8160 GCONF_CFLAGS/LIBS.
8161
5386012d
MR
81622011-06-29 Martin Rudalics <rudalics@gmx.at>
8163
8164 * window.c (resize_root_window, grow_mini_window)
8165 (shrink_mini_window): Rename Qresize_root_window to
8166 Qwindow_resize_root_window and Qresize_root_window_vertically to
8167 Qwindow_resize_root_window_vertically.
8168
f13e0b08
PE
81692011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8170
8171 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8172
94515237
JB
81732011-06-27 Juanma Barranquero <lekktu@gmail.com>
8174
8175 * makefile.w32-in: Redesign dependencies so they reflect more
8176 clearly which files are directly included by each source file,
8177 and not through other includes.
8178
e43b6e43
MR
81792011-06-27 Martin Rudalics <rudalics@gmx.at>
8180
8181 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8182 (sort_overlays, overlay_strings): When an overlay's clone number
8183 matches the window's clone number process the overlay even if
8184 the overlay's window property doesn't match the current window.
8185
d68443dc
MR
8186 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8187 (Fwindow_hchild): Rename to Fwindow_left_child.
8188 (Fwindow_next): Rename to Fwindow_next_sibling.
8189 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8190 (resize_window_check): Rename to window_resize_check.
8191 (resize_window_apply): Rename to window_resize_apply.
8192 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8193 (Fdelete_other_windows_internal, resize_frame_windows)
8194 (Fsplit_window_internal, Fdelete_window_internal)
8195 (grow_mini_window, shrink_mini_window)
8196 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8197
c7e73be5
JD
81982011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8199
8200 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8201 (emacs_fixed_set_min_size): Remove.
8202 (emacs_fixed_new): Take frame as argument.
8203
8204 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8205 (_EmacsFixedPrivate): Remove minwidth/height.
8206 Add struct frame *f.
8207 (emacs_fixed_init): Initialize priv->f.
8208 (get_parent_class, emacs_fixed_set_min_size): Remove.
8209 (emacs_fixed_new): Set priv->f to argument.
8210 (emacs_fixed_get_preferred_width)
8211 (emacs_fixed_get_preferred_height): Use min_width/height from
8212 frames size_hint to set minimum and natural (Bug#8919).
8213 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8214 and use min_width/height from frames size_hint to set
8215 min_width/height (Bug#8919).
8216
8217 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8218 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8219 Fix indentation.
c7e73be5 8220
cf99dcf8
EZ
82212011-06-26 Eli Zaretskii <eliz@gnu.org>
8222
8223 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8224 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8225 called at ZV.
8226
029529ac
CY
82272011-06-26 Chong Yidong <cyd@stupidchicken.com>
8228
8229 * process.c (wait_reading_process_output): Bypass select if
8230 waiting for a cell while ignoring keyboard input, and input is
8231 pending. Suggested by Jan Djärv (Bug#8869).
8232
7a7ef429
PE
82332011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8234
8235 Use gnulib's dup2 module instead of rolling our own.
8236 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8237
11fdef7d 82382011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8239
8240 * dispnew.c (scrolling_window): Before scrolling, turn off a
8241 mouse-highlight in the window being scrolled.
8242
cd3520a4
JB
82432011-06-24 Juanma Barranquero <lekktu@gmail.com>
8244
8245 Move DEFSYM to lisp.h and use everywhere.
8246
8247 * character.h (DEFSYM): Move declaration...
8248 * lisp.h (DEFSYM): ...here.
8249
8250 * gnutls.c:
8251 * minibuf.c:
8252 * w32menu.c:
8253 * w32proc.c:
8254 * w32select.c: Don't include character.h.
8255
8256 * alloc.c (syms_of_alloc):
8257 * buffer.c (syms_of_buffer):
8258 * bytecode.c (syms_of_bytecode):
8259 * callint.c (syms_of_callint):
8260 * casefiddle.c (syms_of_casefiddle):
8261 * casetab.c (init_casetab_once):
8262 * category.c (init_category_once, syms_of_category):
8263 * ccl.c (syms_of_ccl):
8264 * cmds.c (syms_of_cmds):
8265 * composite.c (syms_of_composite):
8266 * dbusbind.c (syms_of_dbusbind):
8267 * dired.c (syms_of_dired):
8268 * dispnew.c (syms_of_display):
8269 * doc.c (syms_of_doc):
8270 * editfns.c (syms_of_editfns):
8271 * emacs.c (syms_of_emacs):
8272 * eval.c (syms_of_eval):
8273 * fileio.c (syms_of_fileio):
8274 * fns.c (syms_of_fns):
8275 * frame.c (syms_of_frame):
8276 * fringe.c (syms_of_fringe):
8277 * insdel.c (syms_of_insdel):
8278 * keymap.c (syms_of_keymap):
8279 * lread.c (init_obarray, syms_of_lread):
8280 * macros.c (syms_of_macros):
8281 * msdos.c (syms_of_msdos):
8282 * print.c (syms_of_print):
8283 * process.c (syms_of_process):
8284 * search.c (syms_of_search):
8285 * sound.c (syms_of_sound):
8286 * syntax.c (init_syntax_once, syms_of_syntax):
8287 * terminal.c (syms_of_terminal):
8288 * textprop.c (syms_of_textprop):
8289 * undo.c (syms_of_undo):
8290 * w32.c (globals_of_w32):
8291 * window.c (syms_of_window):
8292 * xdisp.c (syms_of_xdisp):
8293 * xfaces.c (syms_of_xfaces):
8294 * xfns.c (syms_of_xfns):
8295 * xmenu.c (syms_of_xmenu):
8296 * xsettings.c (syms_of_xsettings):
8297 * xterm.c (syms_of_xterm): Use DEFSYM.
8298
4228cf16
TZ
82992011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8300
cd3520a4 8301 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8302
7fcccf1e
PE
83032011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8304
7efb4e0e
PE
8305 Integer and buffer overflow fixes (Bug#8873).
8306
ff5844ad
PE
8307 * print.c (printchar, strout): Check for string overflow.
8308 (PRINTPREPARE, printchar, strout):
8309 Don't set size unless allocation succeeds.
8310
90532f02
PE
8311 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8312 for sizes. Check for string overflow more accurately.
8313 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8314
6d84508d
PE
8315 * macros.c: Integer and buffer overflow fixes.
8316 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8317 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8318 Use ptrdiff_t, not int, for sizes.
8319 Don't increment bufsize until after realloc succeeds.
8320 Check for size-calculation overflow.
8321 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8322
437b2cb4
PE
8323 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8324
8b9ac8b4
PE
8325 * lread.c: Integer overflow fixes.
8326 (read_integer): Radix is now EMACS_INT, not int,
8327 to improve quality of diagnostics for out-of-range radices.
8328 Calculate buffer size correctly for out-of-range radices.
8329 (read1): Check for integer overflow in radices, and in
8330 read-circle numbers.
82cb60d3
PE
8331 (read_escape): Avoid int overflow.
8332 (Fload, openp, read_buffer_size, read1)
8333 (substitute_object_recurse, read_vector, read_list, map_obarray):
8334 Use ptrdiff_t, not int, for sizes.
8335 (read1): Use EMACS_INT, not int, for sizes.
20270765 8336 Check for size overflow.
8b9ac8b4 8337
7fcccf1e
PE
8338 * image.c (cache_image): Check for size arithmetic overflow.
8339
bfbbd7e7
PE
8340 * lread.c: Integer overflow issues.
8341 (saved_doc_string_size, saved_doc_string_length)
8342 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8343 Now ptrdiff_t, not int.
8344 (read1): Don't assume doc string length fits in int. Check for
8345 out-of-range doc string lengths.
8346 (read_list): Don't assume file position fits in int.
39019e54 8347 (read_escape): Check for hex character overflow.
bfbbd7e7 8348
4e323265
LL
83492011-06-22 Leo Liu <sdl.web@gmail.com>
8350
8351 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8352 Move to minibuffer.el.
8353
85fece3e
PE
83542011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8355
20b84ce9 8356 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8357 The following patches are for when GLYPH_DEBUG && !XASSERT.
8358 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8359 * dispnew.c (flush_stdout):
8360 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8361 Mark as externally visible.
8362 * dispnew.c (check_window_matrix_pointers): Now static.
8363 * dispnew.c (window_to_frame_vpos):
8364 * xfns.c (unwind_create_frame):
8365 * xterm.c (x_check_font): Remove unused local.
8366 * scroll.c (CHECK_BOUNDS):
8367 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8368 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8369 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8370 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8371 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8372 Now static.
8373 (debug_method_add): Use va_list and vsprintf rather than relying
8374 on undefined behavior with wrong number of arguments.
8375 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8376 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8377 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8378 since we're not interested in debugging glyphs with old libraries.
8379 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8380 GCC 4.6.0's static checking.
8381
0766b489
PE
83822011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8383
31fd4b32
PE
8384 Integer overflow and signedness fixes (Bug#8873).
8385 A few related buffer overrun fixes, too.
8386
b79e8648
PE
8387 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8388
0766b489
PE
8389 * dispextern.h (struct face.stipple):
8390 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8391 (x_bitmap_mask, x_allocate_bitmap_record)
8392 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8393 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8394 (x_create_bitmap_from_xpm_data):
8395 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8396 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8397 (.bitmaps_last):
8398 * xfaces.c (load_pixmap):
8399 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8400 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8401 (.bitmaps_last, struct x_output.icon_bitmap):
8402 Use ptrdiff_t, not int, for bitmap indexes.
8403 (x_allocate_bitmap_record): Check for size overflow.
8404 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8405
b081724f
PE
8406 Use ptrdiff_t, not int, for overlay counts.
8407 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8408 * editfns.c (overlays_around, get_pos_property):
8409 * textprop.c (get_char_property_and_overlay):
8410 * xdisp.c (next_overlay_change, note_mouse_highlight):
8411 * xfaces.c (face_at_buffer_position):
21514da7
PE
8412 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8413 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8414 (Fnext_overlay_change, Fprevious_overlay_change)
8415 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8416 Use ptrdiff_t, not int, for sizes.
21514da7 8417 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8418
3de73e5e
PE
8419 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8420
2606c57b
PE
8421 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8422 (x_session_initialize): Do not assume string length fits in int.
8423
aaafe47a
PE
8424 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8425 This is unlikely, but can occur if DPI is outlandish.
8426
2674ddc8 8427 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8428 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8429
28154962
PE
8430 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8431 * xrdb.c (magic_file_p, search_magic_path):
8432 Omit last arg SUFFIX; it was always 0. All callers changed.
8433 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8434
7de51af5
PE
8435 * xfont.c (xfont_match): Avoid need for strlen.
8436
25ed6cc3
PE
8437 * xfns.c: Don't assume strlen fits in int.
8438 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8439
4eab31dd
PE
8440 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8441 not unsigned long, as we prefer signed integers. All callers changed.
8442 Detect integer overflow in repeat count.
8443 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8444 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8445
171e2a58
PE
8446 * termcap.c: Don't assume sizes fit in int and never overflow.
8447 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8448 (gobble_line): Check for size-calculation overflow.
8449
ad39faca 8450 * minibuf.c (Fread_buffer):
6e5bb2dc 8451 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8452 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8453 Don't assume string length fits in int.
8454
52c61c22 8455 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8456 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8457
b5b8c9e5
PE
8458 * font.c: Don't assume string length fits in int.
8459 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8460 Use ptrdiff_t, not int.
ccd6111c
PE
8461 (font_intern_prop): Don't assume string length fits in int.
8462 Don't assume integer property fits in fixnum.
8463 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8464
882f0d81 8465 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8466 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8467 Reformulate so as not to need the command string.
8468 Invoke gzip -cd rather than gunzip, as it's more portable.
8469 (lock_info_type, lock_file_1, lock_file):
8470 Don't assume pid_t and time_t fit in unsigned long.
8471 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8472 (current_lock_owner): Prefer signed type for sizes.
8473 Use memcpy, not strncpy, where memcpy is what is really wanted.
8474 Don't assume (via atoi) that time_t and pid_t fit in int.
8475 Check for time_t and/or pid_t out of range, e.g., via a network share.
8476 Don't alloca where an auto var works fine.
8477
93f4cf88
PE
8478 * fileio.c: Fix some integer overflow issues.
8479 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8480 Don't assume string length fits in int.
8481 (directory_file_name): Don't assume string length fits in long.
8482 (make_temp_name): Don't assume pid fits in int, or that its print
8483 length is less than 20.
8484
f3e92b69
PE
8485 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8486
1bfdaf10
PE
8487 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8488
35016e9a
PE
8489 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8490
3d1e65a1
PE
8491 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8492 We prefer signed integers, even for size calculations.
8493
0b963a93
PE
8494 * emacs.c: Don't assume string length fits in 'int'.
8495 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8496 (main): Don't invoke strlen when not needed.
8497
573f4b54
PE
8498 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8499 (XD_DEBUG_MESSAGE): Don't waste a byte.
8500
989f33ba
PE
8501 * callproc.c (getenv_internal_1, getenv_internal)
8502 (Fgetenv_internal):
965d34eb
PE
8503 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8504
e4d29b33
PE
8505 * lread.c (invalid_syntax): Omit length argument.
8506 All uses changed. This doesn't fix a bug, but it simplifies the
8507 code away from its former Hollerith-constant appearance, and it's
8508 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8509 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8510
eb49b136
PE
8511 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8512 This didn't break anything, but it didn't help either.
8513 It's confusing to put a bogus integer in a place where the actual
8514 value does not matter.
9f62aeb1 8515 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8516 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8517
15375a22
PE
8518 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8519 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8520 implementation.
b61cc01c
PE
8521 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8522 We prefer signed types, and the value cannot exceed the EMACS_INT
8523 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8524 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8525 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8526 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8527
53b2623d
PE
8528 * indent.c (sane_tab_width): New function.
8529 (current_column, scan_for_column, Findent_to, position_indentation)
8530 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8531 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8532
51cab52b 8533 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8534
f2ed8a70
PE
8535 * lisp.h (lint_assume): New macro.
8536 * composite.c (composition_gstring_put_cache):
8537 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8538
abe80cc6
PE
8539 * editfns.c, insdel.c:
8540 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8541
b02c740e
PE
8542 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8543
ebc96716
PE
8544 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8545
b4e50fa0 8546 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8547 Use much-faster test for byte-length change.
311d5d7c 8548 Don't assume string byte-length fits in 'int'.
a4cf38e4 8549 Check that character arg fits in 'int'.
85461888 8550 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8551
c0c1ee9f
PE
8552 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8553
a498d7f4
PE
8554 * fns.c (concat): Catch string overflow earlier.
8555 Do not rely on integer wraparound.
8556
51cab52b
PE
8557 * dispextern.h (struct it.overlay_strings_charpos)
8558 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8559 * xdisp.c (forward_to_next_line_start)
8560 (back_to_previous_visible_line_start)
8561 (reseat_at_next_visible_line_start, next_element_from_buffer):
8562 Don't arbitrarily truncate the value of 'selective' to int.
8563
76031fad
PE
8564 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8565
5eb55db9
PE
8566 * composite.c: Don't truncate sizes to 'int'.
8567 (composition_gstring_p, composition_reseat_it)
8568 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8569 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8570 not EMACS_UINT, for indexes.
5eb55db9 8571
0703a717
PE
8572 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8573
d6202519
PE
8574 * buffer.c: Include <verify.h>.
8575 (struct sortvec.priority, struct sortstr.priority):
8961a454 8576 Now EMACS_INT, not int.
c20998a7 8577 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8578 (struct sortstr.size, record_overlay_string)
8579 (struct sortstrlist.size, struct sortlist.used):
8580 Don't truncate size to int.
8581 (record_overlay_string): Check for size-calculation overflow.
d6202519 8582 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8583
d5a19415
JM
85842011-06-22 Jim Meyering <meyering@redhat.com>
8585
029529ac 8586 Don't leak an XBM-image-sized buffer
d5a19415
JM
8587 * image.c (xbm_load): Free the image buffer after using it.
8588
a9041e6c
PE
85892011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8590
8591 Port to Sun C.
8592 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8593 that Sun C diagnosed.
8594 * fns.c (secure_hash): Fix pointer signedness issue.
8595 * intervals.c (static_offset_intervals): New function.
8596 (offset_intervals): Use it.
8597
7f3f739f
LL
85982011-06-21 Leo Liu <sdl.web@gmail.com>
8599
8600 * deps.mk (fns.o):
8601 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8602 sha512.h.
8603
8604 * fns.c (secure_hash): Rename from crypto_hash_function and change
8605 the first arg to accept symbols.
5b66d427 8606 (Fsecure_hash): New primitive.
7f3f739f
LL
8607 (syms_of_fns): New symbols.
8608
76147d94
DD
86092011-06-20 Deniz Dogan <deniz@dogan.se>
8610
8611 * process.c (Fset_process_buffer): Clarify return value in
8612 docstring.
8613
7d7d0045
CY
86142011-06-18 Chong Yidong <cyd@stupidchicken.com>
8615
8616 * dispnew.c (add_window_display_history): Use BVAR.
8617
8618 * xdisp.c (debug_method_add): Use BVAR.
8619 (check_window_end, dump_glyph_matrix, dump_glyph)
8620 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8621
8622 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8623 Likewise.
8624
8625 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8626 check till after the cache is created in init_frame_faces.
8627
ff2bc410
SM
86282011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8629
8630 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8631
28177add
PE
86322011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8633
dd3482fe
PE
8634 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8635 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8636 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8637
393d71f3 8638 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8639 * fileio.c (Finsert_file_contents):
8640 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8641 Remove the old (too-loose) buffer overflow checks.
8642 They weren't needed, since make_gap checks for buffer overflow.
8643 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8644 The old code merely checked for Emacs fixnum overflow, and relied
8645 on undefined (wraparound) behavior. The new code avoids undefined
8646 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8647
2e6813b0 8648 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8649 Tune. Don't use wider integers than needed. Don't use alloca.
8650 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8651
599a9e4f
PE
8652 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8653
99561444
PE
8654 * insdel.c, lisp.h (buffer_overflow): New function.
8655 (insert_from_buffer_1, replace_range, replace_range_2):
8656 * insdel.c (make_gap_larger):
8657 * editfns.c (Finsert_char):
8658 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8659
28177add
PE
8660 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8661
e69dafad
PE
86622011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8663
4baa020d 8664 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8665
b1c46f02
PE
8666 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8667 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8668
e69dafad
PE
8669 * fileio.c: Don't assume EMACS_INT fits in off_t.
8670 (emacs_lseek): New static function.
8671 (Finsert_file_contents, Fwrite_region): Use it.
8672 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8673
566684ea
PE
8674 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8675
e6966cd6
PE
8676 * fns.c: Don't overflow int when computing a list length.
8677 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8678 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8679 truncation on 64-bit hosts. Check for QUIT every
8680 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8681 faster and is responsive enough.
8682 (Flength): Report an error instead of overflowing an integer.
8683 (Fsafe_length): Return a float if the value is not representable
8684 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8685 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8686 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8687
dd0b0efb
PE
8688 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8689 (header_size, word_size): New constants.
8690 (allocate_vectorlike): Don't check size overflow here.
8691 (allocate_vector): Check it here instead, since this is the only
8692 caller of allocate_vectorlike that could cause overflow.
8693 Check that the new vector's length is representable as a fixnum.
8694
86fe5cfe
PE
8695 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8696 The previous code was bogus. For example, next_almost_prime (32)
8697 returned 39, which is undesirable as it is a multiple of 3; and
8698 next_almost_prime (24) returned 25, which is a multiple of 5 so
8699 why was the code bothering to check for multiples of 7?
8700
80e88859
PE
8701 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8702
4a2f0ad6
PE
8703 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8704
f66c7cf8
PE
8705 Variadic C functions now count arguments with ptrdiff_t.
8706 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8707 Back then I didn't know that the Emacs coding style prefers signed int.
8708 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8709 were being counted with int, which may truncate counts on 64-bit
8710 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8711 * lisp.h (struct Lisp_Subr.function.aMANY)
8712 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8713 Arg counts are now ptrdiff_t, not size_t.
8714 All variadic functions and their callers changed accordingly.
8715 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8716 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8717 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8718 * callint.c (Fcall_interactively): Check arg count for overflow,
8719 to avoid potential buffer overrun. Use signed char, not 'int',
8720 for 'varies' array, so that we needn't bother to check its size
8721 calculation for overflow.
8722 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8723 * eval.c (apply_lambda):
8724 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8725 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8726 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8727
a1759b76
PE
8728 * callint.c (Fcall_interactively): Don't use index var as event count.
8729
d96be9fc
PE
8730 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8731 * mem-limits.h (SIZE): Remove; no longer used.
8732
a690a978 8733 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8734
578c21e6
PE
8735 Remove unnecessary casts.
8736 * xterm.c (x_term_init):
8737 * xfns.c (x_set_border_pixel):
8738 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8739 These aren't needed now that we assume ANSI C.
8740
96f53c6c
PE
8741 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8742 It's more likely to cause problems (due to unsigned overflow)
8743 than to cure them.
8744
83c77d31
PE
8745 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8746
ee2079f1
PE
8747 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8748
6da65536
PE
8749 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8750
7147c4a4
PE
8751 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8752
193e32d9
PE
8753 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8754
e5533da6
PE
8755 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8756
9910e595
PE
8757 GLYPH_CODE_FACE returns EMACS_INT, not int.
8758 * dispextern.h (merge_faces):
8759 * xfaces.c (merge_faces):
01103c44
PE
8760 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8761 Don't assume EMACS_INT fits in int.
9910e595 8762
2638320e
PE
8763 * character.h (CHAR_VALID_P): Remove unused parameter.
8764 * fontset.c, lisp.h, xdisp.c: All uses changed.
8765
045eb8d9
PE
8766 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8767
c1f134b5
PE
8768 * fns.c (concat): Minor tuning based on overflow analysis.
8769 This doesn't fix any bugs. Use int to hold character, instead
8770 of constantly refetching from Emacs object. Use XFASTINT, not
8771 XINT, for value known to be a character. Don't bother comparing
8772 a single byte to 0400, as it's always less.
8773
395fcb93 8774 * floatfns.c (Fexpt):
327eeec8
PE
8775 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8776
abbd3d23
PE
8777 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8778 for characters.
8779
684a03ef
PE
8780 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8781
0fed43f3
PE
8782 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8783 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8784 incorrectly succeed when S was a string, because 4294967386 was
8785 truncated before it was used.
8786
8fd02eb7
PE
8787 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8788 Otherwise, an out-of-range integer could cause undefined behavior
8789 on a 64-bit host.
8790
f8c86b69
PE
8791 * composite.c: Use int, not EMACS_INT, for characters.
8792 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8793 EMACS_INT, for values that are known to be in character range.
8794 This doesn't fix any bugs but is the usual style inside Emacs and
8795 may generate better code on 32-bit machines.
8796
34206dd2
PE
8797 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8798 This is for reasons similar to the recent CHAR_STRING fix.
8799 * charset.c (Fencode_char): Check that character arg is actually
8800 a character. Pass an int to ENCODE_CHAR.
8801 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8802 wider than 'int', as a compile-time check to prevent future regressions
8803 in this area.
8804
c5958d4c 8805 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8806
8807 Make sure a 64-bit char is never passed to CHAR_STRING.
8808 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8809 by silently ignoring the top 32 bits, allowing some values
8810 that were far too large to be valid characters.
8811 * character.h: Include <verify.h>.
8812 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8813 arguments are no wider than unsigned, as a compile-time check
8814 to prevent future regressions in this area.
8815 * data.c (Faset):
01103c44 8816 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8817 (Fsubst_char_in_region):
8818 * fns.c (concat):
8819 * xdisp.c (decode_mode_spec_coding):
8820 Adjust to CHAR_STRING's new requirement.
8821 * editfns.c (Finsert_char, Fsubst_char_in_region):
8822 * fns.c (concat): Check that character args are actually
8823 characters. Without this test, these functions did the wrong
8824 thing with wildly out-of-range values on 64-bit hosts.
8825
d37ca623
PE
8826 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8827 These casts should not be needed on 32-bit hosts, either.
8828 * keyboard.c (read_char):
8829 * lread.c (Fload): Remove casts to unsigned.
8830
ea204efb
PE
8831 * lisp.h (UNSIGNED_CMP): New macro.
8832 This fixes comparison bugs on 64-bit hosts.
8833 (ASCII_CHAR_P): Use it.
8834 * casefiddle.c (casify_object):
01103c44 8835 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8836 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8837 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8838 * dispextern.h (FACE_FROM_ID):
8839 * keyboard.c (read_char): Use UNSIGNED_CMP.
8840
41cb286c
PE
8841 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8842 not to EMACS_INT, to avoid GCC warning.
8843
4a1b9832
PE
8844 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8845
55daad71
PE
8846 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8847 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8848 isn't needed on 32-bit machines.
8f95c75c 8849
01103c44
PE
8850 * buffer.c (Fgenerate_new_buffer_name):
8851 Use EMACS_INT for count, not int.
0ceccced 8852 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8853
8854 * data.c (Qcompiled_function): Now static.
8855
c6f072e7
PE
8856 * window.c (window_body_lines): Now static.
8857
20ce5912
PE
8858 * image.c (gif_load): Rename local to avoid shadowing.
8859
9c4c5f81
PE
8860 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8861 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8862 * alloc.c (make_save_value): Integer argument is now of type
8863 ptrdiff_t, not int.
8864 (mark_object): Use ptrdiff_t, not int.
8865 * lisp.h (pD): New macro.
8866 * print.c (print_object): Use it.
8867
c0c5c8ae
PE
8868 * alloc.c: Use EMACS_INT, not int, to count objects.
8869 (total_conses, total_markers, total_symbols, total_vector_size)
8870 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8871 (total_free_floats, total_floats, total_free_intervals)
8872 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8873 Now EMACS_INT, not int. All uses changed.
8874 (Fgarbage_collect): Compute overall total using a double, so that
8875 integer overflow is less likely to be a problem. Check for overflow
8876 when converting back to an integer.
5a25e253
PE
8877 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8878 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8879 These were 'int' variables that could overflow on 64-bit hosts;
8880 they were never used, so remove them instead of repairing them.
211a0b2a 8881 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8882 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8883 Previously, this ceilinged at INT_MAX, but that doesn't work on
8884 64-bit machines.
e46bb31a 8885 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8886
c78baabf 8887 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8888 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8889 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8890 when a (possibly-narrower) signed value would do just as well.
8891 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8892
c9d624c6
PE
8893 * alloc.c: Catch some string size overflows that we were missing.
8894 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8895 for convenience in STRING_BYTES_MAX.
8896 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8897 The definition here is exact; the one in lisp.h was approximate.
8898 (allocate_string_data): Check for string overflow. This catches
8899 some instances we weren't catching before. Also, it catches
8900 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8901 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8902 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8903
c9d624c6
PE
8904 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8905 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8906 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8907
353032ce
PE
8908 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8909
2bccce07
PE
8910 * alloc.c (Fmake_string): Check for out-of-range init.
8911
0ac30604
SM
89122011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8913
8914 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8915
c195f2de
JD
89162011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8917
8918 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8919 xg_get_default_scrollbar_width.
8920
8921 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8922 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8923 (style_changed_cb): Call update_theme_scrollbar_width and call
8924 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8925 all frames (Bug#8505).
8926 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8927 Call gtk_window_set_resizable if HAVE_GTK3.
8928 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8929 and height if HAVE_GTK3 (Bug#8505).
8930 (scroll_bar_width_for_theme): New variable.
8931 (update_theme_scrollbar_width): New function.
8932 (xg_get_default_scrollbar_width): Move code to
8933 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8934 (xg_initialize): Call update_theme_scrollbar_width.
8935
8936 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8937
8938 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8939
e10ac9f1
MR
89402011-06-12 Martin Rudalics <rudalics@gmx.at>
8941
8942 * frame.c (make_frame): Call other_buffer_safely instead of
8943 other_buffer.
8944
8945 * window.c (temp_output_buffer_show): Call display_buffer with
8946 second argument Vtemp_buffer_show_specifiers and reset latter
8947 immediately after the call.
8948 (Vtemp_buffer_show_specifiers): New variable.
8949 (auto_window_vscroll_p, next_screen_context_lines)
8950 (Vscroll_preserve_screen_position): Remove leading asterisks from
8951 doc-strings.
8952
2d3c217e 89532011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8954
7b7f97e8 8955 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8956 * buffer.c (Qclone_number): Remove for now, as it's unused.
8957 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8958 (record_buffer): Remove unused local.
8959 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8960 (set_frame_buffer_list): Remove; unused.
8961 * frame.h (other_visible_frames): Remove decl.
8962 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8963 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8964 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8965 if HAVE_GPM.
8966 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8967 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8968 Define only if HAVE_GPM.
8969 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8970 (update_hints_inhibit): Remove; never set. All uses removed.
8971 * widgetprv.h (emacsFrameClassRec): Remove decl.
8972 * window.c (delete_deletable_window): Now returns void, since it
8973 wasn't returning anything.
8974 (compare_window_configurations): Remove unused locals.
8975 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8976 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8977 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8978 the same widths as pointers. This follows up on the 2011-05-06 patch.
8979 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8980 * xterm.h: Likewise.
8981 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8982
1384b89e
JB
89832011-06-12 Juanma Barranquero <lekktu@gmail.com>
8984
8985 * makefile.w32-in: Update dependencies.
8986 (LISP_H): Add lib/intprops.h.
8987
1100a63c
CY
89882011-06-11 Chong Yidong <cyd@stupidchicken.com>
8989
8990 * image.c (gif_load): Add animation frame delay to the metadata.
8991 (syms_of_image): Use DEFSYM. New symbol `delay'.
8992
6198ccd0
MR
89932011-06-11 Martin Rudalics <rudalics@gmx.at>
8994
8995 * window.c (delete_deletable_window): Re-add.
8996 (Fset_window_configuration): Rewrite to handle dead buffers and
8997 consequently deletable windows.
8998 (window_tree, Fwindow_tree): Remove. Supply functionality in
8999 window.el.
9000 (compare_window_configurations): Simplify code.
9001
b6e3633c
AS
90022011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9003
1ab0dee5
AS
9004 * image.c (imagemagick_load_image): Fix type mismatch.
9005 (Fimagemagick_types): Likewise.
9006
b6e3633c
AS
9007 * window.h (replace_buffer_in_windows): Declare.
9008
9397e56f
MR
90092011-06-11 Martin Rudalics <rudalics@gmx.at>
9010
9011 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9012 Qclone_number. Remove external declaration of Qdelete_window.
9013 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9014 code.
640c8776
SM
9015 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9016 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9017 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9018 buffer list implementation.
9019 (other_buffer_safely): New function.
9020 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9021 calls to replace_buffer_in_windows and
9022 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9023 if allowed.
9024 (record_buffer): Inhibit quitting and rewrite using quittable
9025 functions. Run Qbuffer_list_update_hook if allowed.
9026 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9027 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9028 Move switch-to-buffer to window.el.
9397e56f
MR
9029 (bury-buffer): Move to window.el.
9030 (Vbuffer_list_update_hook): New variable.
9031
9032 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9033 section.
9034
9035 * window.h (resize_frame_windows): Move up in code.
9036 (Fwindow_frame): Remove EXFUN.
9037 (replace_buffer_in_all_windows): Remove prototype.
9038 (replace_buffer_in_windows_safely): Add prototype.
9039
9040 * window.c: Declare Qdelete_window static again. Move down
9041 declaration of select_count.
9042 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9043 (Fother_window): Move to window.el.
9044 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9045 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9046 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9047 window.el.
9048 (replace_buffer_in_windows): Implement by calling
9049 Qreplace_buffer_in_windows.
9050 (replace_buffer_in_all_windows): Remove with some functionality
9051 moved into replace_buffer_in_windows_safely.
9052 (replace_buffer_in_windows_safely): New function.
9053 (select_window_norecord, select_frame_norecord): Move in front
9054 of run_window_configuration_change_hook. Remove now obsolete
9055 declarations.
640c8776
SM
9056 (Fset_window_buffer): Rewrite doc-string.
9057 Call Qrecord_window_buffer.
9397e56f
MR
9058 (keys_of_window): Move binding for other-window to window.el.
9059
b50691aa
CY
90602011-06-11 Chong Yidong <cyd@stupidchicken.com>
9061
9062 * dispextern.h (struct image): Replace data member, whose int_val
9063 and ptr_val fields were not used by anything, with a single
9064 lisp_val object.
9065
9066 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9067 (gif_clear_image, gif_load, imagemagick_load_image)
9068 (gs_clear_image, gs_load): Callers changed.
9069
3f754b86
PE
90702011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9071
cca69397
PE
9072 * buffer.h: Include <time.h>, for time_t.
9073 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9074
109e28d0
PE
9075 Fix minor problems found by static checking.
9076
60737f02
PE
9077 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9078
4b66faf3
PE
9079 Make identifiers static if they are not used in other modules.
9080 * data.c (Qcompiled_function, Qframe, Qvector):
9081 * image.c (QimageMagick, Qsvg):
9082 * minibuf.c (Qmetadata):
9083 * window.c (resize_window_check, resize_root_window): Now static.
9084 * window.h (resize_window_check, resize_root_window): Remove decls.
9085
109e28d0
PE
9086 * window.c (window_deletion_count, delete_deletable_window):
9087 Remove; unused.
46a4ce9e
PE
9088 (window_body_lines): Now static.
9089 (Fdelete_other_windows_internal): Mark vars as initialized.
9090 Make sure 'resize_failed' is initialized.
9091 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9092 (resize_window_apply): Remove unused local.
9093 * window.h (delete_deletable_window): Remove decl.
9094
109e28d0 9095 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9096 (imagemagick_load_image): Fix pointer signedness problem by changing
9097 last arg from unsigned char * to char *. All uses changed.
9098 Also, fix a local for similar reasons.
9099 Remove unused locals. Remove locals to avoid shadowing.
9100 (fn_rsvg_handle_free): Remove; unused.
9101 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9102 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9103
3f754b86
PE
9104 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9105
2547adb1
CY
91062011-06-10 Chong Yidong <cyd@stupidchicken.com>
9107
9108 * image.c (gif_load): Fix omitted cast error introduced by
9109 2011-06-06 change.
9110
2c8e37d4
MR
91112011-06-10 Martin Rudalics <rudalics@gmx.at>
9112
9113 * window.h (resize_proportionally, orig_total_lines)
9114 (orig_top_line): Remove from window structure.
9115 (set_window_height, set_window_width, change_window_heights)
9116 (Fdelete_window): Remove prototypes.
9117 (resize_frame_windows): Remove duplicate declaration.
9118
440a42e3
EZ
91192011-06-10 Eli Zaretskii <eliz@gnu.org>
9120
9121 * window.h (resize_frame_windows, resize_window_check)
9122 (delete_deletable_window, resize_root_window)
9123 (resize_frame_windows): Declare prototypes.
9124
9125 * window.c (resize_window_apply): Make definition be "static" to
9126 match the prototype.
9127
562dd5e9
MR
91282011-06-10 Martin Rudalics <rudalics@gmx.at>
9129
9130 * window.c: Remove declarations of Qwindow_size_fixed,
9131 window_min_size_1, window_min_size_2, window_min_size,
9132 size_window, window_fixed_size_p, enlarge_window, delete_window.
9133 Remove static from declaration of Qdelete_window, it's
9134 temporarily needed by Fbury_buffer.
9135 (replace_window): Don't assign orig_top_line and
9136 orig_total_lines.
9137 (Fdelete_window, delete_window): Remove. Window deletion is
9138 handled by window.el.
640c8776
SM
9139 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9140 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9141 (Fdelete_other_windows): Remove. Deleting other windows is
9142 handled by window.el.
9143 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9144 handled in window.el.
9145 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9146 Window minimum sizes are handled in window.el.
9147 (shrink_windows, size_window, set_window_height)
9148 (set_window_width, change_window_heights, window_height)
9149 (window_width, CURBEG, CURSIZE, enlarge_window)
9150 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9151 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9152 handled in window.el.
9153 (make_dummy_parent): Rename to make_parent_window and give it a
9154 second argument horflag.
9155 (make_window): Don't set resize_proportionally any more.
9156 (Fsplit_window): Remove. Windows are split in window.el.
9157 (save_restore_action, save_restore_orig_size)
9158 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9159 Resize mini windows in window.el.
9160 (grow_mini_window, shrink_mini_window): Implement by calling
9161 Qresize_root_window_vertically, resize_window_check and
9162 resize_window_apply.
640c8776
SM
9163 (saved_window, Fset_window_configuration, save_window_save):
9164 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9165 resize_proportionally.
9166 (window_min_height, window_min_width): Move to window.el.
9167 (keys_of_window): Move bindings for delete-other-windows,
9168 split-window, delete-window and enlarge-window to window.el.
9169
9170 * buffer.c: Temporarily extern Qdelete_window.
9171 (Fbury_buffer): Temporarily call Qdelete_window instead of
9172 Fdelete_window (Fbury_buffer will move to window.el soon).
9173
9174 * frame.c (set_menu_bar_lines_1): Remove code handling
9175 orig_top_line and orig_total_lines.
9176
9177 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9178 set_window_height but set heights directly.
9179 (change_frame_size_1): Use resize_frame_windows.
9180
9181 * xdisp.c (init_xdisp): Don't use set_window_height but set
9182 heights directly.
9183
640c8776
SM
9184 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9185 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9186 run_window_configuration_change_hook.
9187
9188 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9189 instead of change_window_heights and run
9190 run_window_configuration_change_hook.
9191
1a13852e
MR
91922011-06-09 Martin Rudalics <rudalics@gmx.at>
9193
9194 * window.c (replace_window): Rename second argument REPLACEMENT to
9195 NEW. New third argument SETFLAG. Rewrite.
9196 (delete_window, make_dummy_parent): Call replace_window with
9197 third argument 1.
9198 (window_list_1): Move down in code.
9199 (run_window_configuration_change_hook): Move set_buffer part
9200 before select_frame_norecord part in order to unwind correctly.
9201 Rename count1 to count.
9202 (recombine_windows, delete_deletable_window, resize_root_window)
9203 (Fdelete_other_windows_internal)
9204 (Frun_window_configuration_change_hook, make_parent_window)
9205 (resize_window_check, resize_window_apply, Fresize_window_apply)
9206 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9207 (Fdelete_window_internal, Fresize_mini_window_internal):
9208 New functions.
1a13852e
MR
9209 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9210
f3d1777e
MR
92112011-06-08 Martin Rudalics <rudalics@gmx.at>
9212
496e208e
MR
9213 * window.h (window): Add some new members to window structure -
9214 normal_lines, normal_cols, new_total, new_normal, clone_number,
9215 splits, nest, prev_buffers, next_buffers.
9216 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9217 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9218
f3d1777e
MR
9219 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9220 Remove.
496e208e
MR
9221 (make_dummy_parent): Set new members of windows structure.
9222 (make_window): Move down in code. Handle new members of window
9223 structure.
9224 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9225 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9226 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9227 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9228 (Fset_window_next_buffers, Fset_window_clone_number):
9229 New functions.
496e208e
MR
9230 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9231 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9232 Doc-string fixes.
9233 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9234 Argument WINDOW can be now internal window too.
9235 (Fwindow_use_time): Move up in code.
9236 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9237 Rewrite doc-string.
9238 (Fset_window_configuration, saved_window)
9239 (Fcurrent_window_configuration, save_window_save): Handle new
9240 members of window structure.
b9e809c2
MR
9241 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9242 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9243 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9244 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9245 Qget_mru_window, Qresize_root_window,
9246 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9247 Qauto_buffer_name; staticpro them.
f3d1777e 9248
abde8f8c
MR
92492011-06-07 Martin Rudalics <rudalics@gmx.at>
9250
9251 * window.c (Fwindow_total_size, Fwindow_left_column)
9252 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9253 (Fwindow_list_1): New functions.
9254 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9255 (Fwindow_width, Fscroll_left, Fscroll_right):
9256 Use window_body_cols instead of window_box_text_cols.
9257 (delete_window, Fset_window_configuration):
9258 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9259 (delete_all_subwindows): Take a window as argument and not a
9260 structure. Rewrite.
190b47e6
MR
9261 (window_loop): Remove handling of GET_LRU_WINDOW and
9262 GET_LARGEST_WINDOW.
9263 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9264
9265 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9266 window_box_text_cols. delete_all_subwindows now takes a
9267 Lisp_Object as argument.
abde8f8c 9268
640c8776
SM
9269 * indent.c (compute_motion, Fcompute_motion):
9270 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9271
fa8a67e6
MR
9272 * frame.c (delete_frame): Call delete_all_subwindows with root
9273 window as argument.
9274
a54e3482
DC
92752011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9276
9277 * fns.c (Fputhash): Document return value.
9278
60002bf5
CY
92792011-06-06 Chong Yidong <cyd@stupidchicken.com>
9280
9281 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9282
0c671da6 92832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9284
b862a52a 9285 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9286
be44ca6c
PE
9287 Check for overflow when converting integer to cons and back.
9288 * charset.c (Fdefine_charset_internal, Fdecode_char):
9289 Use cons_to_unsigned to catch overflow.
9290 (Fencode_char): Use INTEGER_TO_CONS.
9291 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9292 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9293 * data.c (long_to_cons, cons_to_long): Remove.
9294 (cons_to_unsigned, cons_to_signed): New functions.
9295 These signal an error for invalid or out-of-range values.
9296 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9297 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9298 * font.c (Ffont_variation_glyphs):
9299 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9300 * lisp.h: Include <intprops.h>.
9301 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9302 (cons_to_signed, cons_to_unsigned): New decls.
9303 (long_to_cons, cons_to_long): Remove decls.
9304 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9305 (Fprimitive_undo): Use CONS_TO_INTEGER.
9306 * xfns.c (Fx_window_property): Likewise.
9307 * xselect.c: Include <limits.h>.
9308 (x_own_selection, selection_data_to_lisp_data):
9309 Use INTEGER_TO_CONS.
9310 (x_handle_selection_request, x_handle_selection_clear)
9311 (x_get_foreign_selection, Fx_disown_selection_internal)
9312 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9313 (lisp_data_to_selection_data): Use cons_to_unsigned.
9314 (x_fill_property_data): Use cons_to_signed.
9315 Report values out of range.
9316
d1f3d2af
PE
9317 Check for buffer and string overflow more precisely.
9318 * buffer.h (BUF_BYTES_MAX): New macro.
9319 * lisp.h (STRING_BYTES_MAX): New macro.
9320 * alloc.c (Fmake_string):
9321 * character.c (string_escape_byte8):
9322 * coding.c (coding_alloc_by_realloc):
9323 * doprnt.c (doprnt):
9324 * editfns.c (Fformat):
9325 * eval.c (verror):
9326 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9327 since they may not be the same number.
9328 * editfns.c (Finsert_char):
9329 * fileio.c (Finsert_file_contents):
9330 Likewise for BUF_BYTES_MAX.
9331
dd52fcea
PE
9332 * image.c: Use ptrdiff_t, not int, for sizes.
9333 (slurp_file): Switch from int to ptrdiff_t.
9334 All uses changed.
9335 (slurp_file): Check that file size fits in both size_t (for
9336 malloc) and ptrdiff_t (for sanity and safety).
9337
7f9bbdbb
PE
9338 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9339 if b->modtime has its maximal value.
9340
dfe18f82
PE
9341 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9342
84acfcf0
PE
9343 Don't assume time_t can fit into int.
9344 * buffer.h (struct buffer.modtime): Now time_t, not int.
9345 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9346 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9347
ccd9a01a
PE
9348 Minor fixes for signed vs unsigned integers.
9349 * character.h (MAYBE_UNIFY_CHAR):
9350 * charset.c (maybe_unify_char):
9351 * keyboard.c (read_char, reorder_modifiers):
9352 XINT -> XFASTINT, since the integer must be nonnegative.
9353 * ftfont.c (ftfont_spec_pattern):
9354 * keymap.c (access_keymap, silly_event_symbol_error):
9355 XUINT -> XFASTINT, since the integer must be nonnegative.
9356 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9357 since it makes no difference and we prefer signed.
9358 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9359 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9360 nonnegative.
9361
d6d100dd
SM
93622011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9363
9364 * window.h (Fwindow_frame): Declare.
9365
2b6148e4
PE
93662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9367
9368 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9369 (SPARE_MEMORY): Always define.
9370 (LARGE_REQUEST): Remove.
9371 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9372
f230ecc9
MR
93732011-06-06 Martin Rudalics <rudalics@gmx.at>
9374
727e958e
MR
9375 * lisp.h: Move EXFUNS for Fframe_root_window,
9376 Fframe_first_window and Fset_frame_selected_window to window.h.
9377
9378 * window.h: Move EXFUNS for Fframe_root_window,
9379 Fframe_first_window and Fset_frame_selected_window here from
9380 lisp.h.
9381
9382 * frame.c (Fwindow_frame, Fframe_first_window)
9383 (Fframe_root_window, Fframe_selected_window)
9384 (Fset_frame_selected_window): Move to window.c.
9385 (Factive_minibuffer_window): Move to minibuf.c.
9386 (Fother_visible_frames_p): New function.
9387
9388 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9389
f230ecc9
MR
9390 * window.c (decode_window, decode_any_window): Move up in code.
9391 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9392 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9393 (Fwindow_buffer): Move up and rewrite doc-string.
9394 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9395 (Fwindow_prev): New functions.
727e958e
MR
9396 (Fwindow_frame): Move here from frame.c. Accept any window as
9397 argument.
9398 (Fframe_root_window, Fframe_first_window)
9399 (Fframe_selected_window): Move here from frame.c. Accept frame
9400 or arbitrary window as argument. Update doc-strings.
9401 (Fminibuffer_window): Move up in code.
9402 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9403 (Fset_frame_selected_window): Move here from frame.c.
9404 Marginal rewrite.
727e958e
MR
9405 (Fselected_window, select_window, Fselect_window): Move up in
9406 code. Minor doc-string fixes.
f230ecc9 9407
4d09bcf6
PE
94082011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9409
9410 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9411 Do not assume that spare memory exists; that assumption is valid
9412 only if SYSTEM_MALLOC.
9413 (LARGE_REQUEST): New macro, so that the issue of large requests
9414 is separated from the issue of spare memory.
9415
810928a2
AS
94162011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9417
172418ad
AS
9418 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9419 format. (Bug#8806)
9420
43f862f7
AS
9421 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9422
810928a2
AS
9423 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9424 before statements.
9425
a059fe24
JD
94262011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9427
9428 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9429
9430 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9431
9432 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9433 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9434
989bf368
JB
94352011-06-05 Juanma Barranquero <lekktu@gmail.com>
9436
9437 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9438
4b80f674
CY
94392011-06-04 Chong Yidong <cyd@stupidchicken.com>
9440
9441 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9442 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9443 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9444 New error handlers.
4b80f674
CY
9445 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9446 Obey Vx_select_enable_clipboard_manager. Catch errors in
9447 x_clipboard_manager_save (Bug#8779).
9448 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9449 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9450
99a33b77 94512011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9452
9453 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9454
99a33b77 94552011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9456
9457 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9458 in the current matrix if keep_current_p is non-zero.
9459
8264569d
EZ
94602011-06-04 Eli Zaretskii <eliz@gnu.org>
9461
9462 * bidi.c (bidi_level_of_next_char): Fix last change.
9463
57f97249
EZ
94642011-06-03 Eli Zaretskii <eliz@gnu.org>
9465
fec2107c 9466 Support bidi reordering of text covered by display properties.
57f97249 9467
fec2107c
EZ
9468 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9469 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9470 (bidi_cache_search, bidi_cache_iterator_state)
9471 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9472 (bidi_level_of_next_char, bidi_move_to_visually_next):
9473 Support character positions inside a run of characters covered by a
fec2107c
EZ
9474 display string.
9475 (bidi_paragraph_init, bidi_resolve_explicit_1)
9476 (bidi_level_of_next_char): Call bidi_fetch_char and
9477 bidi_fetch_char_advance instead of FETCH_CHAR and
9478 FETCH_CHAR_ADVANCE.
9479 (bidi_init_it): Initialize new members.
9480 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9481 definitions.
9482 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9483 instead of using explicit *_CHAR codes.
d6d100dd
SM
9484 (bidi_resolve_explicit, bidi_resolve_weak):
9485 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9486 bidirectional text is supported only in multibyte buffers.
9487 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9488 it to initialize the frame_window_p member of struct bidi_it.
9489 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9490 (bidi_resolve_explicit, bidi_resolve_weak)
9491 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9492 bidi_it->nchars is non-positive.
9493 (bidi_level_of_next_char): Don't try to lookup the cache for the
9494 next/previous character if nothing is cached there yet, or if we
9495 were just reseat()'ed to a new position.
c40e2fb2 9496
0e14fe90
EZ
9497 * xdisp.c (set_cursor_from_row): Set start and stop points
9498 according to the row's direction when priming the loop that looks
9499 for the glyph on which to display cursor.
9500 (single_display_spec_intangible_p): Function deleted.
9501 (display_prop_intangible_p): Reimplement to call
9502 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9503 Accept 3 additional arguments needed by handle_display_spec.
9504 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9505 values: lists, `(when COND...)' forms, etc.
9506 (single_display_spec_string_p): Support property values that are
9507 lists with the argument STRING its top-level element.
9508 (display_prop_string_p): Fix the condition for processing a
9509 property that is a list to be consistent with handle_display_spec.
fec2107c 9510 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9511 last portion of handle_display_prop.
9512 (compute_display_string_pos): Accept additional argument
9513 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9514 value of a `display' property is a "replacing spec".
9515 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9516 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9517 the display property, but just return a value indicating whether
9518 the display property will replace the characters it covers.
9519 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9520 frame_window_p members of struct bidi_it.
d6d100dd
SM
9521 (compute_display_string_pos, compute_display_string_end):
9522 New functions.
fec2107c
EZ
9523 (push_it): Accept second argument POSITION, where pop_it should
9524 jump to continue iteration.
9525 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9526
fec2107c
EZ
9527 * keyboard.c (adjust_point_for_property): Adjust the call to
9528 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9529
9530 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9531 (bidi_init_it): Update prototypes.
9532 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9533 (compute_display_string_pos, compute_display_string_end):
9534 Declare prototypes.
fec2107c
EZ
9535 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9536 EMACS_INT.
fc6f18ce 9537
40087514 95382011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9539
57f53182
PE
9540 Malloc failure behavior now depends on size of allocation.
9541 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9542 * lisp.h: Change signatures accordingly.
9543 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9544 All callers changed. (Bug#8762)
9545
9546 * gnutls.c: Use Emacs's memory allocators.
9547 Without this change, the gnutls library would invoke malloc etc.
9548 directly, which causes problems on non-SYNC_INPUT hosts, and which
9549 runs afoul of improving memory_full behavior. (Bug#8761)
9550 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9551 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9552 xfree instead of the default malloc, realloc, free.
9553 (Fgnutls_boot): No need to check for memory allocation failure,
9554 since xmalloc does that for us.
9555
ac32cd99 9556 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9557 * category.c (hash_get_category_set):
9558 * ccl.c (ccl_driver):
9559 * charset.c (Fdefine_charset_internal):
9560 * charset.h (struct charset.hash_index):
9561 * composite.c (get_composition_id, gstring_lookup_cache)
9562 (composition_gstring_put_cache):
9563 * composite.h (struct composition.hash_index):
9564 * dispextern.h (struct image.hash):
9565 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9566 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9567 (hashfn_equal, hashfn_user_defined, make_hash_table)
9568 (maybe_resize_hash_table, hash_lookup, hash_put)
9569 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9570 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9571 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9572 * image.c (make_image, search_image_cache, lookup_image)
9573 (xpm_put_color_table_h):
9574 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9575 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9576 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9577 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9578 * alloc.c (allocate_vectorlike):
9579 Check for overflow in vector size calculations.
9580 * ccl.c (ccl_driver):
9581 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9582 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9583 need to be updated by these changes.
40087514
PE
9584 * fns.c (make_hash_table, maybe_resize_hash_table):
9585 Check for integer overflow with large hash tables.
0de4bb68
PE
9586 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9587 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9588 (SXHASH_REDUCE): New macro.
9589 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9590 Use it instead of discarding useful hash info with large hash values.
9591 (sxhash_float): New function.
9592 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9593 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9594 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9595 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9596 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9597 Adjust signatures to match updated version of code.
9598 (consing_since_gc): Now EMACS_INT, since a single hash table can
9599 use more than INT_MAX bytes.
9600
698d32e2
DN
96012011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9602
9603 Make it possible to build with GCC-4.6+ -O2 -flto.
9604
9605 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9606
fd6fa53f
SM
96072011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9608
9609 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9610 Call minibuffer-inactive-mode.
9611
864db017
JB
96122011-05-31 Juanma Barranquero <lekktu@gmail.com>
9613
9614 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9615 Update dependencies.
9616
2ad0baf4
DN
96172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9618
9619 * data.c (init_data): Remove code for UTS, this system is not
9620 supported anymore.
9621
4fcc2638
DN
96222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9623
9624 Don't force ./temacs to start in terminal mode.
9625
9626 * frame.c (make_initial_frame): Initialize faces in all cases, not
9627 only when CANNOT_DUMP is defined.
9628 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9629
c56e0fd5
DN
96302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9631
9632 * dispnew.c (add_window_display_history): Use const for the string
9633 pointer. Remove declaration, not needed.
9634
333d54da 96352011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9636
55d4c1b2 9637 Use 'inline', not 'INLINE'.
333d54da 9638 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9639 * alloc.c, fontset.c (INLINE): Remove.
9640 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9641 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9642 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9643 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9644 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9645
738db178
DN
96462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9647
9648 Make it possible to run ./temacs.
9649
9650 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9651 syms_of_callproc does the same thing. Remove test for
9652 "initialized", do it in the caller.
9653 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9654
620c53a6
SM
96552011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9656
9657 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9658 (read_minibuf): Use get_minibuffer.
9659 (syms_of_minibuf): Use DEFSYM.
9660 (Qmetadata): New var.
9661 * data.c (Qbuffer): Don't make it static.
9662 (syms_of_data): Use DEFSYM.
9663
e003a292
PE
96642011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9665
9666 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9667 (CCL_CODE_MIN): New macro.
9668
ed008a6d
PE
96692011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9670
3687c2ef
PE
9671 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9672
ed008a6d
PE
9673 * eval.c (Qdebug): Now static.
9674 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9675 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9676 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9677
d66c4c7c
CY
96782011-05-29 Chong Yidong <cyd@stupidchicken.com>
9679
9680 * image.c: Various fixes to ImageMagick code comments.
9681 (Fimagemagick_types): Doc fix.
9682
5fbc2025
PE
96832011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9684
0196f88a
PE
9685 Minor fixes prompted by GCC 4.6.0 warnings.
9686
9687 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9688
5fbc2025
PE
9689 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9690 (x_clipboard_manager_save_all): Move extern decl to ...
9691 * xterm.h: ... here, so that it can be checked for consistency.
9692
1dd3c2d9
CY
96932011-05-29 Chong Yidong <cyd@stupidchicken.com>
9694
9695 * xselect.c (x_clipboard_manager_save_frame)
9696 (x_clipboard_manager_save_all): New functions.
9697 (Fx_clipboard_manager_save): Lisp function deleted.
9698
9699 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9700 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9701
9702 * xterm.h: Update prototype.
9703
5ba6571d
WX
97042011-05-28 William Xu <william.xwl@gmail.com>
9705
9706 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9707 exiting (Bug#8239).
9708
3eaff834
JM
97092011-05-28 Jim Meyering <meyering@redhat.com>
9710
e1900994 9711 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9712 * fns.c (to_uchar): Define.
9713 (crypto_hash_function): Use it to convert some newly-signed
9714 variables to unsigned, to avoid sign-extension bugs. For example,
9715 without this change, (md5 "truc") would evaluate to
9716 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9717 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9718 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9719
0f6990a7
PE
97202011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9721
9722 Integer overflow fixes.
c8a9ca5a 9723
08686060
PE
9724 * dbusbind.c: Serial number integer overflow fixes.
9725 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9726 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9727 to hold a serial number that is too large for a fixnum.
9728 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9729 Check for serial numbers out of range. Decode any serial number
59568bf0 9730 that was so large that it became a float. (Bug#8722)
08686060 9731
2d1fc3c7
PE
9732 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9733 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9734 Use XFASTINT rather than XUINT when numbers are nonnegative.
9735 (xd_append_arg, Fdbus_method_return_internal):
9736 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9737 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9738 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9739 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9740 (Bug#8722)
2d1fc3c7 9741
c8a9ca5a
PE
9742 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9743
519e1d69
PE
9744 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9745
6df6ae42 9746 ccl: Add integer overflow checks.
30569699
PE
9747 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9748 (IN_INT_RANGE): New macros.
9749 (ccl_driver): Use them to check for integer overflow when
9750 decoding a CCL program. Many of the new checks are whether XINT (x)
9751 fits in int; it doesn't always, on 64-bit hosts. The new version
9752 doesn't catch all possible integer overflows, but it's an
847044ea 9753 improvement. (Bug#8719)
30569699 9754
c11285dc
PE
9755 * alloc.c (make_event_array): Use XINT, not XUINT.
9756 There's no need for unsigned here.
9757
fdccd48e
PE
9758 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9759 This follows up to the 2011-05-06 change that substituted uintptr_t
9760 for EMACS_INT. This case wasn't caught back then.
9761
37910ab2
PE
9762 Rework Fformat to avoid integer overflow issues.
9763 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9764 now (part of C89). Include <verify.h>.
9765 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9766 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9767 (Fformat): Avoid the prepass trying to compute sizes; it was only
9768 approximate and thus did not catch overflow reliably. Instead, walk
9769 through the format just once, formatting and computing sizes as we go,
9770 checking for integer overflow at every step, and allocating a larger
9771 buffer as needed. Keep track separately whether the format is
9772 multibyte. Keep only the most-recently calculated precision, rather
9773 than them all. Record whether each argument has been converted to
9774 string. Use EMACS_INT, not int, for byte and char and arg counts.
9775 Support field widths and precisions larger than INT_MAX. Avoid
9776 sprintf's undefined behavior with conversion specifications such as %#d
9777 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9778 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9779 formatting out-of-range floating point numbers with int
9173deec 9780 formats. (Bug#8668)
37910ab2 9781
2e6578fb
PE
9782 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9783
0ae6bdee
PE
9784 * data.c: Avoid integer truncation in expressions involving floats.
9785 * data.c: Include <intprops.h>.
9786 (arith_driver): When there's an integer overflow in an expression
9787 involving floating point, convert the integers to floating point
9788 so that the resulting value does not suffer from catastrophic
9789 integer truncation. For example, on a 64-bit host (* 4
9790 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9791 Do not rely on undefined behavior after integer overflow.
9792
de883a70
PE
9793 merge count_size_as_multibyte, parse_str_to_multibyte
9794 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9795 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9796 Check for integer overflow.
9797 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9798 since it's now a duplicate of the other. This is more of
9799 a character than a buffer op, so better that it's in character.c.
9800 * fns.c, print.c: Adjust to above changes.
9801
2ff916cb
PE
98022011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9803
9804 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9805
f1b54466
PE
98062011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9807
fb1ac845
PE
9808 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9809 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9810 (x_clipboard_manager_save): Now static.
9811 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9812
f1b54466
PE
9813 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9814 (crypto_hash_function): Now static.
9815 Fix pointer signedness problems. Avoid unnecessary initializations.
9816
a9f737ee
CY
98172011-05-27 Chong Yidong <cyd@stupidchicken.com>
9818
9819 * termhooks.h (Vselection_alist): Make it terminal-local.
9820
9821 * terminal.c (create_terminal): Initialize it.
9822
9823 * xselect.c: Support for clipboard managers.
9824 (Vselection_alist): Move to termhooks.h as terminal-local var.
9825 (LOCAL_SELECTION): New macro.
9826 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9827 (symbol_to_x_atom): Remove gratuitous arg.
9828 (x_handle_selection_request, lisp_data_to_selection_data)
9829 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9830 (x_own_selection, x_get_local_selection, x_convert_selection):
9831 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9832 (some_frame_on_display): Delete unused function.
9833 (Fx_own_selection_internal, Fx_get_selection_internal)
9834 (Fx_disown_selection_internal, Fx_selection_owner_p)
9835 (Fx_selection_exists_p): New optional frame arg.
9836 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9837 (x_handle_selection_clear): Don't treat other terminals with the
9838 same keyboard specially. Use the terminal-local Vselection_alist.
9839 (x_clear_frame_selections): Use Frun_hook_with_args.
9840
9841 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9842
9843 * xterm.h: Add support for those atoms.
9844
e067f0c1
CY
98452011-05-26 Chong Yidong <cyd@stupidchicken.com>
9846
9847 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9848 (converted_selections, conversion_fail_tag): New global variables.
9849 (x_selection_request_lisp_error): Free the above.
9850 (x_get_local_selection): Remove unnecessary code.
9851 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9852 of converted selections stored in converted_selections.
9853 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9854 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9855 (x_convert_selection): New function.
9856 (x_handle_selection_event): Simplify.
9857 (x_get_foreign_selection): Don't ignore incoming requests while
9858 waiting for an answer; this will fail when we implement
9859 SAVE_TARGETS, and seems unnecessary anyway.
9860 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9861 (Vx_sent_selection_functions): Doc fix.
9862
0f4aebc0
LL
98632011-05-26 Leo Liu <sdl.web@gmail.com>
9864
9865 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9866
e61124cd
YM
98672011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9868
9869 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9870
9871 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9872 for fringe update if it has periodic bitmap.
ac389d0c 9873 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9874 and fringe_bitmap_periodic_p.
9875
9876 * fringe.c (get_fringe_bitmap_data): New function.
9877 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9878 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9879 row. Mark glyph row for fringe update if periodicity changed.
9880
9881 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9882 for fringe update unless it has periodic bitmap.
9883
f16d9837
KH
98842011-05-25 Kenichi Handa <handa@m17n.org>
9885
9886 * xdisp.c (get_next_display_element): Set correct it->face_id for
9887 a static composition.
9888
e1b90ef6
LL
98892011-05-24 Leo Liu <sdl.web@gmail.com>
9890
9891 * deps.mk (fns.o):
9892 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9893
9894 * fns.c (crypto_hash_function, Fsha1): New function.
9895 (Fmd5): Use crypto_hash_function.
9896 (syms_of_fns): Add Ssha1.
9897
7400048f
PE
98982011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9899
9900 * gnutls.c: Remove unused macros.
9901 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9902 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9903 Remove macros that are defined and never used.
9904 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9905
abb71cf4
CY
99062011-05-22 Chong Yidong <cyd@stupidchicken.com>
9907
9908 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9909 (Fx_get_selection_internal): Minor cleanup.
9910 (Fx_own_selection_internal): Rename arguments for consistency with
9911 select.el.
9912
6307db39
PE
99132011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9914
9915 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9916
f3d4e0a4
CY
99172011-05-22 Chong Yidong <cyd@stupidchicken.com>
9918
9919 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9920
4d8ade89
YM
99212011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9922
9923 * dispnew.c (scrolling_window): Don't exclude the case that the
9924 last enabled row in the desired matrix touches the bottom boundary.
9925
32078c8d
GM
99262011-05-21 Glenn Morris <rgm@gnu.org>
9927
9928 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9929 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9930 and add some more files.
32078c8d 9931
7285dc67
EZ
99322011-05-20 Eli Zaretskii <eliz@gnu.org>
9933
9934 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9935 report_file_error introduced by the change from 2011-05-07.
9936
89d1bd22
PE
99372011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9938
9939 * systime.h (Time): Define only if emacs is defined.
9940 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9941 where the include path doesn't have X11/X.h by default. See
9942 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9943
cd394be1 99442011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9945
9946 * composite.c (find_automatic_composition): Fix previous change.
9947
b9704ad9
GM
99482011-05-20 Glenn Morris <rgm@gnu.org>
9949
9950 * lisp.mk: New file, split from Makefile.in.
9951 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9952 (shortlisp): Remove.
9953 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9954
4a720484
GM
99552011-05-19 Glenn Morris <rgm@gnu.org>
9956
9957 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9958 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9959 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9960 (lisp): Set the order to that of loadup.el.
9961 (shortlisp): Make it a copy of $lisp.
9962 (SOME_MACHINE_LISP): Remove.
9963 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9964 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9965
a28d4396
KH
99662011-05-18 Kenichi Handa <handa@m17n.org>
9967
9968 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9969 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9970 (find_automatic_composition): Mostly rewrite for efficiency.
9971
a2b1fa8e
JB
99722011-05-18 Juanma Barranquero <lekktu@gmail.com>
9973
9974 * makefile.w32-in: Update dependencies.
9975
8e1f5610
CS
99762011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9977
9978 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9979 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9980
7025ee00 99812011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9982
cdfa6eab
PE
9983 Fix some integer overflow issues, such as string length overflow.
9984
06d6db33
PE
9985 * insdel.c (count_size_as_multibyte): Check for string overflow.
9986
2b4560a8
PE
9987 * character.c (lisp_string_width): Check for string overflow.
9988 Use EMACS_INT, not int, for string indexes and lengths; in
9989 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9990 the resulting string length overflows an EMACS_INT; instead,
9991 report a string overflow if no precision given. When checking for
9992 precision exhaustion, use a check that cannot possibly have
9993 integer overflow. (Bug#8675)
9994 * character.h (lisp_string_width): Adjust to new signature.
9995
cb93f9be
PE
9996 * alloc.c (string_overflow): New function.
9997 (Fmake_string): Use it. This doesn't change behavior, but saves
9998 a few bytes and will simplify future changes.
9999 * character.c (string_escape_byte8): Likewise.
10000 * lisp.h (string_overflow): New decl.
10001
1a1f3366
PE
10002 Fixups, following up to the user-interface timestamp change.
10003 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10004 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10005 * msdos.c (mouse_get_pos): Likewise.
10006 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10007 * w32gui.h (Time): Define by including "systime.h" rather than by
10008 declaring it ourselves. (Bug#8664)
10009
d4e3e4d3
PE
10010 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10011 * image.c (clear_image_cache): Likewise.
10012
f6a24d19
PE
10013 * term.c (term_mouse_position): Don't assume time_t wraparound.
10014
08dc5ae6
PE
10015 Be more systematic about user-interface timestamps.
10016 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10017 and sometimes 'EMACS_UINT', to represent these timestamps.
10018 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10019 This makes the code easier to follow, and makes it easier to catch
10020 integer overflow bugs such as Bug#8664.
10021 * frame.c (Fmouse_position, Fmouse_pixel_position):
10022 Use Time, not unsigned long, for user-interface timestamps.
10023 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10024 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10025 * keyboard.h (last_event_timestamp): Likewise.
10026 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10027 * menu.h (xmenu_show): Likewise.
10028 * term.c (term_mouse_position): Likewise.
10029 * termhooks.h (struct input_event.timestamp): Likewise.
10030 (struct terminal.mouse_position_hook): Likewise.
10031 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10032 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10033 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10034 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10035 what it was before.
10036 * menu.h, termhooks.h: Include "systime.h", for Time.
10037
8e55734a
PE
10038 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10039 Don't assume that the difference between two unsigned long values
10040 can fit into an integer. At this point, we know button_down_time
10041 <= event->timestamp, so the difference must be nonnegative, so
10042 there's no need to cast the result if double-click-time is
10043 nonnegative, as it should be; check that it's nonnegative, just in
10044 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10045 apart (about 25 days). (Bug#8664)
8e55734a 10046
841f1b75 10047 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10048 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10049
3e26f69c
PE
10050 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10051 that always fit in int. Use a sentinel instead of a counter, to
10052 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10053 * frame.h (struct frame): Use int for menu_bar_items_used
10054 instead of EMACS_INT, since it always fits in int.
3e26f69c 10055
5cc152c0
PE
10056 * menu.c (grow_menu_items): Check for int overflow.
10057
d89eb65e
PE
10058 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10059
5235bd3e
PE
10060 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10061 Before, the code was not consistent. These values cannot exceed
10062 2**31 - 1 so there's no need to make them unsigned.
10063 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10064 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10065 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10066 as modifiers.
10067 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10068
bc827e23
PE
10069 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10070 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10071 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10072 presumably because the widths might not match.
10073
78eb494e
PE
10074 * window.c (size_window): Avoid needless test at loop start.
10075
04f2d78b
CB
100762011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10077
10078 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10079
d2fc7e3d 100802011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10081
10082 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10083
d2fc7e3d 100842011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10085
10086 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10087 `width' to `bar_area_x' and `bar_area_width', respectively.
10088 (x_scroll_run): Take account of fringe background extension.
10089
04f2d78b
CB
10090 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10091 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10092 `bar_area_width', respectively.
10093 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10094 background extension.
10095
79b70037
GM
100962011-05-10 Jim Meyering <meyering@redhat.com>
10097
10098 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10099
2f142cc5
JB
101002011-05-10 Juanma Barranquero <lekktu@gmail.com>
10101
10102 * image.c (Finit_image_library): Return t for built-in image types,
10103 like pbm and xbm. (Bug#8640)
10104
57679c86
AS
101052011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10106
10107 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10108
888c9e86
EZ
101092011-05-07 Eli Zaretskii <eliz@gnu.org>
10110
b0512a1d
EZ
10111 * w32console.c (Fset_screen_color): Doc fix.
10112 (Fget_screen_color): New function.
10113 (syms_of_ntterm): Defsubr it.
10114
7285dc67
EZ
10115 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10116 unlink the temporary file if Fcall_process didn't create it in the
10117 first place.
10118 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10119 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10120 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10121 cue to call_process_cleanup not to close that handle.
10122
4d3fcc8e
BK
101232011-05-07 Ben Key <bkey76@gmail.com>
10124
10125 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10126 one of two shell specific rules, either bootstrap-temacs-CMD or
10127 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10128 to the previous implementation of the bootstrap-temacs rule.
10129 The bootstrap-temacs-CMD rule is similar to the previous
10130 implementation of the bootstrap-temacs rule except that it
10131 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10132 variable.
10133
10134 These changes, along with some changes to nt/configure.bat,
10135 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10136 earlier fix to add support for --cflags and --ldflags options
10137 that include quotes so that it works whether make uses cmd or
10138 sh as the shell.
10139
b4289b64
MA
101402011-05-06 Michael Albinus <michael.albinus@gmx.de>
10141
10142 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10143 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10144 is a constant.
10145 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10146 a string. Handle both cases.
10147 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10148 (Fdbus_register_method): Use Qinvalid_function.
10149
af4c0e28
JB
101502011-05-06 Juanma Barranquero <lekktu@gmail.com>
10151
10152 * makefile.w32-in: Update dependencies.
10153 (LISP_H): Add inttypes.h and stdin.h.
10154 (PROCESS_H): Add unistd.h.
10155
c51453d9
EZ
101562011-05-06 Eli Zaretskii <eliz@gnu.org>
10157
10158 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10159 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10160
8ff0ac3c 101612011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10162
4c4b566b
PE
10163 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10164
aab2b9b5
PE
10165 * term.c (vfatal): Remove stray call to va_end.
10166 It's not needed and the C Standard doesn't allow it here anyway.
10167
c378da0b
PE
10168 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10169 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10170
288b08c7
PE
10171 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10172 bytes.
10173
e3601888
PE
10174 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10175
db6c0e74
PE
10176 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10177
dd5963ea
PE
10178 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10179
88c9450f
PE
10180 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10181
2f9442b8
PE
10182 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10183
c032b5f8
PE
10184 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10185 * charset.c (Fdefine_charset_internal): Don't initialize
10186 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10187 32-bit int (Bug#8600).
a108c10b
PE
10188
10189 * lread.c (read_integer): Be more consistent with string-to-number.
10190 Use string_to_number to do the actual conversion; this avoids
10191 rounding errors and fixes some other screwups. Without this fix,
10192 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10193 (digit_to_number): Move earlier, for benefit of read_integer.
10194 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10195 not a digit in any supported base. (Bug#8602)
a108c10b 10196
ad5f9eea
PE
10197 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10198
aec1708a
PE
10199 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10200 to match comment at start of function. This also removes a
10201 GCC warning about overflow in a 32+64-bit port.
10202
47be4ab5
PE
10203 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10204
371cac43
PE
10205 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10206 Reported by Stefan Monnier in
10207 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10208 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10209 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10210
d01a7826
PE
10211 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10212 (EMACS_UINTPTR): Likewise, with uintptr_t.
10213
7fd47d5c
PE
10214 * lisp.h: Prefer 64-bit EMACS_INT if available.
10215 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10216 on 32-bit hosts that have 64-bit int, so that they can access
10217 large files.
122b0c86
PE
10218 However, temporarily disable this change unless the temporary
10219 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10220
8727937b
PE
10221 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10222
8ac068ac
PE
10223 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10224 This removes an assumption that EMACS_INT and long are the same
10225 width as pointers. The assumption is true for Emacs porting targets
10226 now, but we want to make other targets possible.
10227 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10228 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10229 In the rest of the code, change types of integers that hold casted
10230 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10231 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10232 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10233 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10234 No need to cast type when ORing.
10235 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10236 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10237 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10238 assume EMACS_INT is the same width as char *.
10239 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10240 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10241 Remove no-longer-needed casts.
10242 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10243 (xg_tool_bar_help_callback, xg_make_tool_item):
10244 Use EMACS_INTPTR to hold an integer
10245 that will be cast to void *; this can avoid a GCC warning
10246 if EMACS_INT is not the same width as void *.
10247 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10248 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10249 (current_message_1, set_message_1):
10250 Use a local to convert to proper width without a cast.
10251 * xmenu.c (dialog_selection_callback): Likewise.
10252
ede49d71
PE
10253 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10254 Also, don't assume VALBITS / RAND_BITS is less than 5,
10255 and don't rely on undefined behavior when shifting a 1 left into
10256 the sign bit.
10257 * lisp.h (get_random): Change signature to match.
10258
2f30ecd0
PE
10259 * lread.c (hash_string): Use size_t, not int, for hash computation.
10260 Normally we prefer signed values; but hashing is special, because
10261 it's better to use unsigned division on hash table sizes so that
10262 the remainder is nonnegative. Also, size_t is the natural width
10263 for hashing into memory. The previous code used 'int', which doesn't
10264 retain enough info to hash well into very large tables.
10265 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10266
2a866e7b
PE
10267 * dbusbind.c: Don't possibly lose pointer info when converting.
10268 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10269 Use XPNTR rather than XHASH, so that the high-order bits of
10270 the pointer aren't lost when converting through void *.
10271
51639eac
PE
10272 * eval.c (Fautoload): Don't double-shift a pointer.
10273
92394119
PE
10274 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10275
dbdb9a7c
JB
102762011-05-06 Juanma Barranquero <lekktu@gmail.com>
10277
10278 * gnutls.c (DEF_GNUTLS_FN):
10279 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10280
db7a0b4f
AS
102812011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10282
10283 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10284 marker. (Bug#8610)
10285
cd394be1 102862011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10287
10288 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10289 New version that can reserve upto 2GB of heap space.
10290
f7ff1b0f 102912011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10292
10293 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10294
639c109b
TZ
102952011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10296
10297 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10298 `gnutls_certificate_set_x509_key_file'.
10299
d2127135
JB
103002011-05-05 Juanma Barranquero <lekktu@gmail.com>
10301
10302 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10303 Update dependencies.
10304
e968f4f3
JB
103052011-05-04 Juanma Barranquero <lekktu@gmail.com>
10306
10307 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10308 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10309 Remove unused parameter `fildes'.
10310 * process.c (read_process_output, send_process): Don't pass it.
10311
84d358f0
JB
103122011-05-04 Juanma Barranquero <lekktu@gmail.com>
10313
10314 Fix previous change: the library cache is defined in w32.c.
10315 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10316 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10317
0898ca10
JB
103182011-05-04 Juanma Barranquero <lekktu@gmail.com>
10319
10320 Implement dynamic loading of GnuTLS on Windows.
10321
10322 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10323 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10324 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10325 Declare.
10326
10327 * gnutls.c (Qgnutls_dll): Define.
10328 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10329 (gnutls_*): Declare function pointers.
10330 (init_gnutls_functions): New function to initialize function pointers.
10331 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10332 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10333 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10334 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10335 (emacs_gnutls_write, emacs_gnutls_read)
10336 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10337 (Fgnutls_available_p): New function.
10338 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10339 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10340 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10341
10342 * image.c: Include w32.h.
10343 (Vimage_type_cache): Delete.
10344 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10345 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10346 (w32_delayed_load): Move to w32.c.
10347
10348 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10349
10350 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10351 (w32_delayed_load): Move from image.c. When loading a library, record
10352 its filename in the :loaded-from property of the library id.
10353 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10354 Initialize and staticpro them.
10355 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10356
10357 * process.c: Include lisp.h before w32.h, not after.
10358 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10359 instead of gnutls_record_check_pending.
10360
10361 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10362
ff4de4aa
TZ
103632011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10364
10365 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10366 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10367 as passed in.
10368
abe95abb
JD
103692011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10370
10371 * xterm.c (x_set_frame_alpha): Do not set property on anything
10372 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10373
e16e55d4
JB
103742011-05-02 Juanma Barranquero <lekktu@gmail.com>
10375
10376 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10377
bafcf6a5
JB
103782011-05-02 Juanma Barranquero <lekktu@gmail.com>
10379
10380 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10381 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10382 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10383 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10384 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10385 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10386 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10387 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10388 (Qgnutls_bootprop_callbacks_verify): Make static.
10389
e7a6747f
AS
103902011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10391
19ed11ba
AS
10392 * callproc.c: Indentation fixup.
10393
e7a6747f 10394 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10395 (wait_for_termination, interruptible_wait_for_termination):
10396 Move after wait_for_termination_1.
e7a6747f 10397
1ef14cb4
LMI
103982011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10399
10400 * sysdep.c (interruptible_wait_for_termination): New function
10401 which is like wait_for_termination, but allows keyboard
10402 interruptions.
10403
10404 * callproc.c (Fcall_process): Add (:file "file") as an option for
10405 the STDOUT buffer.
10406 (Fcall_process_region): Ditto.
10407
330d880c
EZ
104082011-04-30 Eli Zaretskii <eliz@gnu.org>
10409
8db90b73
EZ
10410 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10411 rather than `XVECTOR (FOO)->size'.
10412
330d880c
EZ
10413 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10414 inttypes.h, as a gnulib replacement is used if it not available in
10415 system headers.
10416
15cbd324
EZ
104172011-04-21 Eli Zaretskii <eliz@gnu.org>
10418
10419 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10420 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10421 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10422
10423 * coding.c (coding_alloc_by_realloc): Error out if destination
10424 will grow beyond MOST_POSITIVE_FIXNUM.
10425 (decode_coding_emacs_mule): Abort if there isn't enough place in
10426 charbuf for the composition carryover bytes. Reserve an extra
10427 space for up to 2 characters produced in a loop.
10428 (decode_coding_iso_2022): Abort if there isn't enough place in
10429 charbuf for the composition carryover bytes.
10430
104312011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10432
ae940cca
EZ
10433 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10434 aborting when %lld or %lll format is passed.
10435 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10436 %llo or %llx format is passed. (Bug#8545)
10437
03ab8921
EZ
10438 * window.c (window_scroll_line_based): Use a marker instead of
10439 simple variables to record original value of point. (Bug#7952)
10440
afda1437
EZ
10441 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10442 produced by %s or %c overflows available buffer space. (Bug#8545)
10443
f76dee0c
PE
104442011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10445
10446 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10447 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10448
fdc5744d
JB
104492011-04-28 Juanma Barranquero <lekktu@gmail.com>
10450
10451 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10452
638f053a
JB
104532011-04-28 Juanma Barranquero <lekktu@gmail.com>
10454
10455 * keyboard.c (Qdelayed_warnings_hook): Define.
10456 (command_loop_1): Run `delayed-warnings-hook'
10457 if Vdelayed_warnings_list is non-nil.
10458 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10459 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10460
d178f871
EZ
104612011-04-28 Eli Zaretskii <eliz@gnu.org>
10462
10463 * doprnt.c (doprnt): Don't return value smaller than the buffer
10464 size if the message was truncated. (Bug#8545).
10465
b124fd93
JB
104662011-04-28 Juanma Barranquero <lekktu@gmail.com>
10467
10468 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10469 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10470
e810457d
PE
104712011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10472
10473 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10474
ea51cceb
JB
104752011-04-27 Juanma Barranquero <lekktu@gmail.com>
10476
10477 * makefile.w32-in: Update dependencies.
10478
94dcfacf
EZ
104792011-04-27 Eli Zaretskii <eliz@gnu.org>
10480
10481 Improve `doprnt' and its usage. (Bug#8545)
10482 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10483 `format_end'. Remove support for %l as a conversion specifier.
10484 Don't use xrealloc. Improve diagnostics when the %l size modifier
10485 is used. Update the commentary.
10486
10487 * eval.c (verror): Simplify calculation of size_t.
10488
10489 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10490 messages.
10491
f61f41d7
PE
104922011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10493
10494 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10495 change.
10496
96fb4434
PE
104972011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10498
10499 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10500 This makes this file independent of the recent pseudovector change.
10501
671875da 105022011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10503
69e9b5a3
PE
10504 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10505
b5f869a7 10506 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10507 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10508 Remove unused local.
c8926152 10509 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10510
841a1577 10511 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10512 GCC 4.6.0 optimizes based on type-based alias analysis.
10513 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10514 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10515 != &v->size, and therefore "v->size = 1; b->size = 2; return
10516 v->size;" must therefore return 1. This assumption is incorrect
10517 for Emacs, since it type-puns struct Lisp_Vector * with many other
10518 types. To fix this problem, this patch adds a new type struct
f904488f 10519 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10520 and pseudovectors, and helps optimizing compilers not get fooled
10521 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10522 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10523 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10524 the size member.
eab3844f
PE
10525 (XSETPVECTYPE): Rewrite in terms of new macro.
10526 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10527 This is a bit clearer, and further avoids the possibility of
10528 undesirable aliasing.
10529 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10530 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10531 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10532 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10533 (ASIZE): Now uses header.size rather than size.
10534 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10535 to avoid the hassle of writing XVECTOR (foo)->header.size.
10536 (struct vectorlike_header): New type.
eab3844f
PE
10537 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10538 object, to help avoid aliasing.
10539 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10540 (SUBRP): Likewise, since Lisp_Subr is a special case.
10541 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10542 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10543 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10544 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10545 changed to be "header.size" and "header.next".
10546 * buffer.h (struct buffer): Likewise.
10547 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10548 * frame.h (struct frame): Likewise.
10549 * process.h (struct Lisp_Process): Likewise.
10550 * termhooks.h (struct terminal): Likewise.
10551 * window.c (struct save_window_data, struct saved_window): Likewise.
10552 * window.h (struct window): Likewise.
10553 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10554 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10555 * buffer.c (init_buffer_once): Likewise.
10556 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10557 special case.
10558 * process.c (Fformat_network_address): Use local var for size,
10559 for brevity.
10560
0df1eac5
PE
10561 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10562
847ab9d1 10563 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10564 * data.c (atof): Remove decl; no longer used or needed.
10565 (digit_to_number): Move to lread.c.
10566 (Fstring_to_number): Use new string_to_number function, to be
10567 consistent with how the Lisp reader treats infinities and NaNs.
10568 Do not assume that floating-point numbers represent EMACS_INT
10569 without losing information; this is not true on most 64-bit hosts.
10570 Avoid double-rounding errors, by insisting on integers when
10571 parsing non-base-10 numbers, as the documentation specifies.
10572 * lisp.h (string_to_number): New decl, replacing ...
10573 (isfloat_string): Remove.
bc0a5c13 10574 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10575 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10576 appears to have been a coding error. Similarly, do not accept
10577 strings like +-1e0 as floating point numbers. Do not report
10578 overflow for integer overflows unless the base is not 10 which
10579 means we have no simple and reliable way to continue.
10580 Break out the floating-point parsing into a new
10581 function string_to_number, so that Fstring_to_number parses
10582 floating point numbers consistently with the Lisp reader.
04f2d78b 10583 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10584 (E_CHAR, EXP_INT): Remove, replacing with ...
10585 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10586 (string_to_number): New function, replacing isfloat_string.
10587 This function checks for valid syntax and produces the resulting
10588 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10589 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10590 so that overflow for non-base-10 numbers is reported only when
10591 there's no portable and simple way to convert to floating point.
452f4150 10592
67769ffc
PE
10593 * textprop.c (set_text_properties_1): Rewrite for clarity,
10594 and to avoid GCC warning about integer overflow.
10595
c20db43f
PE
10596 * intervals.h (struct interval): Use EMACS_INT for members
10597 where EMACS_UINT might cause problems. See
10598 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10599 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10600 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10601 All uses changed.
37aa2f85
PE
10602 (offset_intervals): Tell GCC not to worry about length overflow
10603 when negating a negative length.
c20db43f 10604
2538aa2f
PE
10605 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10606 (overrun_check_free): Likewise.
10607
f2d3008d
PE
10608 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10609 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10610 word size.
10611
ec8df744
PE
10612 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10613 (gnutls_make_error): Rename local to avoid shadowing.
10614 (gnutls_emacs_global_deinit): ifdef out; not used.
10615 (Fgnutls_boot): Use const for pointer to readonly storage.
10616 Comment out unused local. Fix pointer signedness problems.
10617
640ee02d
PE
10618 * lread.c (openp): Don't stuff size_t into an 'int'.
10619 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10620 about possible signed overflow.
10621
6048fb2a
PE
10622 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10623 (GDK_KEY_g): Don't define if already defined.
10624 (xg_prepare_tooltip): Avoid pointer signedness problem.
10625 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10626
fa3c87e1
PE
10627 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10628 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10629
2172544b
PE
10630 * xfns.c (Fx_window_property): Simplify a bit,
10631 to make a bit faster and to avoid GCC 4.6.0 warning.
10632 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10633
9b821a21
PE
10634 * fns.c (internal_equal): Don't assume size_t fits in int.
10635
3c616cfa
PE
10636 * alloc.c (compact_small_strings): Tighten assertion a little.
10637
c2982e87
PE
10638 Replace pEd with more-general pI, and fix some printf arg casts.
10639 * lisp.h (pI): New macro, generalizing old pEd macro to other
10640 conversion specifiers. For example, use "...%"pI"d..." rather
10641 than "...%"pEd"...".
10642 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10643 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10644 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10645 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10646 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10647 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10648 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10649 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10650 64-bit hosts.
10651 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10652 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10653 * print.c (safe_debug_print, print_object): Likewise.
10654 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10655 to int.
6f04d126
PE
10656 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10657 avoiding the 0 flag, which is not portable.
c2982e87
PE
10658 * process.c (Fmake_network_process): Use pI to avoid cast.
10659 * region-cache.c (pp_cache): Likewise.
10660 * xdisp.c (decode_mode_spec): Likewise.
10661 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10662 behavior on 64-bit hosts with printf arg.
6f04d126 10663 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10664 (x_stop_queuing_selection_requests): Likewise.
10665 (x_get_window_property): Don't truncate byte count to an 'int'
10666 when tracing.
0b432f21 10667
5e073ec7
PE
10668 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10669 here, since it parses constructs like leading '-' and spaces,
10670 which are not wanted; and it overflows with large numbers.
10671 Instead, simply match F[0-9]+, which is what is wanted anyway.
10672
36372bf9
PE
10673 * alloc.c: Remove unportable assumptions about struct layout.
10674 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10675 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10676 (allocate_vectorlike, make_pure_vector): Use the new macros,
10677 plus offsetof, to remove unportable assumptions about struct layout.
10678 These assumptions hold on all porting targets that I know of, but
10679 they are not guaranteed, they're easy to remove, and removing them
10680 makes further changes easier.
10681
0b432f21
PE
10682 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10683 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10684 (string_overrun_cookie): Now const. Use initializers that
10685 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10686 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10687 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10688 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10689 multiple of sizeof (EMACS_INT); it need not be, if
10690 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10691 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10692
895009e1
JB
106932011-04-26 Juanma Barranquero <lekktu@gmail.com>
10694
10695 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10696
6a7a1b0b
TZ
106972011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10698
10699 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10700 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10701 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10702
841a1577 107032011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10704
10705 * lisp.h (Qdebug): List symbol.
895009e1 10706 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10707 * keyboard.c (debug-on-event): New variable.
10708 (handle_user_signal): Break into debugger when debug-on-event
10709 matches the current signal symbol.
10710
f2d3ba6f
DN
107112011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10712
10713 * alloc.c (check_sblock, check_string_bytes)
10714 (check_string_free_list): Convert to standard C.
10715
42ce4c63
TZ
107162011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10717
10718 * w32.c (emacs_gnutls_push): Fix typo.
10719
825cd63c
EZ
107202011-04-25 Eli Zaretskii <eliz@gnu.org>
10721
fb11d64d
EZ
10722 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10723 "cast to pointer from integer of different size".
10724
825cd63c
EZ
10725 Improve doprnt and its use in verror. (Bug#8545)
10726 * doprnt.c (doprnt): Document the set of format control sequences
10727 supported by the function. Use SAFE_ALLOCA instead of always
10728 using `alloca'.
10729
10730 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10731 is one byte too soon. Don't use xrealloc; instead xfree and
10732 xmalloc anew.
10733
e061a11b
TZ
107342011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10735
10736 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10737 callbacks stage.
10738
10739 * gnutls.c: Renamed global_initialized to
10740 gnutls_global_initialized. Added internals for the
10741 :verify-hostname-error, :verify-error, and :verify-flags
10742 parameters of `gnutls-boot' and documented those parameters in the
10743 docstring. Start callback support.
9173deec
JB
10744 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10745 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10746 on error. Return error code.
e061a11b
TZ
10747 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10748 (emacs_gnutls_read): Likewise.
10749 (Fgnutls_boot): Return handshake error code.
10750 (emacs_gnutls_handle_error): New function.
10751 (wsaerror_to_errno): Likewise.
10752
10753 * w32.h (emacs_gnutls_pull): Add prototype.
10754 (emacs_gnutls_push): Likewise.
10755
10756 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10757 (emacs_gnutls_push): Likewise.
10758
107592011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10760
10761 * process.c (wait_reading_process_output): Check if GnuTLS
10762 buffered some data internally if no FDs are set for TLS
10763 connections.
10764
10765 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10766 (LIBS): Link to USER_LIBS.
10767 ($(BLD)/gnutls.$(0)): New target.
10768
fa6996bc
EZ
107692011-04-24 Eli Zaretskii <eliz@gnu.org>
10770
eb35682e
EZ
10771 * xdisp.c (handle_single_display_spec): Rename the
10772 display_replaced_before_p argument into display_replaced_p, to
10773 make it consistent with the commentary. Fix typos in the
10774 commentary.
10775
e2ad650c
EZ
10776 * textprop.c (syms_of_textprop): Remove dead code.
10777 (copy_text_properties): Delete obsolete commentary about an
10778 interface that was deleted long ago. Fix typos in the description
10779 of arguments.
10780
1b2de274
EZ
10781 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10782 to changes in oldXMenu/XMenu.h from 2011-04-16.
10783 <menu_help_message, prev_menu_help_message>: Constify.
10784 (IT_menu_make_room): menu->help_text is now `const char **';
10785 adjust.
10786
10787 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10788 to changes in oldXMenu/XMenu.h from 2011-04-16.
10789 (struct XMenu): Declare `help_text' `const char **'.
10790
10791 * xfaces.c <Qunspecified>: Make extern again.
10792
10793 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10794 required by POSIX.
1b2de274 10795
762b15be
EZ
10796 * doc.c (get_doc_string): Improve the format passed to `error'.
10797
10798 * doprnt.c (doprnt): Improve commentary.
10799
10800 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10801
10802 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10803 them with etags.
10804
f1052e5d
EZ
10805 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10806 changes in globals.h immediately force recompilation.
762b15be
EZ
10807 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10808 $(CURDIR)/s/ms-w32.h.
10809 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10810
fa6996bc
EZ
10811 * character.c (Fchar_direction): Function deleted.
10812 (syms_of_character): Don't defsubr it.
10813 <char-direction-table>: Deleted.
10814
e6c3da20
EZ
108152011-04-23 Eli Zaretskii <eliz@gnu.org>
10816
10817 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10818 * doprnt.c: Include limits.h.
10819 (SIZE_MAX): New macro.
04f2d78b
CB
10820 (doprnt): Return a size_t value. 2nd arg is now size_t.
10821 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10822 Improve overflow protection. Support `l' modifier for integer
10823 conversions. Support %l conversion. Don't assume an EMACS_INT
10824 argument for integer conversions and for %c.
10825
10826 * lisp.h (doprnt): Restore prototype.
10827
10828 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10829 $(SRC)/character.h.
10830
10831 * Makefile.in (base_obj): Add back doprnt.o.
10832
10833 * deps.mk (doprnt.o): Add back prerequisites.
10834 (callint.o): Depend on character.h.
10835
10836 * eval.c (internal_lisp_condition_case): Include the handler
10837 representation in the error message.
10838 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10839 when breaking from the loop.
10840
10841 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10842
10843 * callint.c (Fcall_interactively): When displaying error message
10844 about invalid control letter, pass the character's codepoint, not
10845 a pointer to its multibyte form. Improve display of the character
10846 in octal and display also its hex code.
10847
10848 * character.c (char_string): Use %x to display the (unsigned)
10849 codepoint of an invalid character, to avoid displaying a bogus
10850 negative value.
10851
10852 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10853 `error', not SYMBOL_NAME itself.
10854
10855 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10856 character arguments to `error'.
10857
10858 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10859 to `error' in error message about FINAL_CHAR argument. Make sure
10860 FINAL_CHAR is a character, and use %c when it is passed as
10861 argument to `error'.
10862
4ffd0d6b 108632011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10864
10865 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10866
10867 * w32.c: Include <time.h>.
10868 (sys_localtime): New function.
10869
4ffd0d6b 108702011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10871
10872 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10873
4ffd0d6b 10874 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10875
4ffd0d6b 108762011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10877
4ffd0d6b
GM
10878 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10879 zombies (Bug#8467).
aac0c6e3 10880
04c56954
EZ
108812011-04-19 Eli Zaretskii <eliz@gnu.org>
10882
10883 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10884 gl_state.e_property when gl_state.object is Qt.
10885
10886 * insdel.c (make_gap_larger): Remove limitation of buffer size
10887 to <= INT_MAX.
10888
16a43933
CY
108892011-04-18 Chong Yidong <cyd@stupidchicken.com>
10890
10891 * xdisp.c (lookup_glyphless_char_display)
10892 (produce_glyphless_glyph): Handle cons cell entry in
10893 glyphless-char-display.
10894 (Vglyphless_char_display): Document it.
10895
10896 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10897 glyphless-char-display.
10898
4581706e
CY
108992011-04-17 Chong Yidong <cyd@stupidchicken.com>
10900
10901 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10902
10903 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10904
10905 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10906 definition for no-X builds.
10907
4887c6e2 109082011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10909
fd35b6f9
PE
10910 Static checks with GCC 4.6.0 and non-default toolkits.
10911
5c1ccb01
PE
10912 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10913
006c5daa
PE
10914 * process.c (keyboard_bit_set): Define only if SIGIO.
10915 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10916 (send_process): Repair possible setjmp clobbering.
10917
efc736d3
PE
10918 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10919
4e2fe2e6
PE
10920 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10921
f97334a2
PE
10922 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10923
4e75f29d
PE
10924 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10925 Define only if needed.
10926
90efadd1
PE
10927 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10928 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10929 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10930
3c647824
PE
10931 * dispextern.h (struct redisplay_interface): Rename param
10932 to avoid shadowing.
e264f262 10933 * termhooks.h (struct terminal): Likewise.
761383f4 10934 * xterm.c (xembed_send_message): Likewise.
3c647824 10935
b58c5c4a
PE
10936 * insdel.c (make_gap_smaller): Define only if
10937 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10938
cad59032
PE
10939 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10940 it.
10941
c339dc2e
PE
10942 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10943 so that we aren't warned about unused symbols.
10944
91a3e27b
PE
10945 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10946
399c71d3 10947 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10948
8ffc96f5
PE
10949 * xfns.c (x_real_positions): Mark locals as initialized.
10950
eef9bc79
PE
10951 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10952
098db9dd
PE
10953 * xterm.c: Fix problems found by static analysis with other toolkits.
10954 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10955 (x_dispatch_event): Declare static if USE_GTK, and
10956 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10957 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10958 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10959 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10960 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10961
eb18f6cc
PE
10962 * xmenu.c (menu_help_callback): Pointer type fixes.
10963 Use const pointers when pointing at readonly data. Avoid pointer
10964 signedness clashes.
10965 (FALSE): Remove unused macro.
10966 (update_frame_menubar): Remove unused decl.
10967
1fe72bf8
PE
10968 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10969
60d9e1db
PE
10970 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10971 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10972 (single_menu_item): Rename local to avoid shadowing.
10973
39261c26
PE
10974 * keyboard.c (make_lispy_event): Remove unused local var.
10975
018c5e19
PE
10976 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10977 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10978
63d2b86e
PE
10979 * bitmaps: Change bitmaps from unsigned char back to the X11
10980 compatible char. Avoid the old compiler warnings about
10981 out-of-range initializers by using, for example, '\xab' rather
10982 than 0xab.
10983
aefd87e1
PE
10984 * xgselect.c (xgselect_initialize): Check vs interface
10985 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10986
bf501fb9
PE
10987 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10988
e9829fdf
PE
10989 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10990 to read-only memory.
10991
1086c095
PE
10992 * fns.c (vector): Remove; this old hack is no longer needed.
10993
2baccd04 10994 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10995 Remove unused var.
dde42981 10996 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10997
72391843 10998 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10999
436c16df 11000 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11001 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11002 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11003
92bb796d 11004 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11005 (x_term_init): Remove local to avoid shadowing.
92bb796d 11006
764430a3 11007 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11008
11009 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11010 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11011
d1dfb56c
EZ
110122011-04-16 Eli Zaretskii <eliz@gnu.org>
11013
c4354cb4
EZ
11014 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11015
d1dfb56c
EZ
11016 Fix regex.c, syntax.c and friends for buffers > 2GB.
11017 * syntax.h (struct gl_state_s): Declare character position members
11018 EMACS_INT.
11019
11020 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11021
04f2d78b
CB
11022 * textprop.c (verify_interval_modification, interval_of):
11023 Declare arguments EMACS_INT.
d1dfb56c
EZ
11024
11025 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11026 EMACS_INT.
11027
11028 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11029
11030 * indent.c (Fvertical_motion): Local variable it_start is now
11031 EMACS_INT.
11032
11033 * regex.c (re_match, re_match_2, re_match_2_internal)
11034 (bcmp_translate, regcomp, regexec, print_double_string)
11035 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11036 (re_compile_pattern, re_exec): Declare arguments and local
11037 variables `size_t' and `ssize_t' and return values `regoff_t', as
11038 appropriate.
11039 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11040 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11041 <compile_stack_type>: `size' and `avail' are now `size_t'.
11042
11043 * regex.h <regoff_t>: Use ssize_t, not int.
11044 (re_search, re_search_2, re_match, re_match_2): Arguments that
11045 specify buffer/string position and length are now ssize_t and
11046 size_t. Return type is regoff_t.
11047
613052cd
BK
110482011-04-16 Ben Key <bkey76@gmail.com>
11049
11050 * nsfont.m: Fixed bugs in ns_get_family and
11051 ns_descriptor_to_entity that were caused by using free to
11052 deallocate memory blocks that were allocated by xmalloc (via
11053 xstrdup). This caused Emacs to crash when compiled with
11054 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11055 --enable-checking=xmallocoverrun). xfree is now used to
11056 deallocate these memory blocks.
11057
4170f62f 110582011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11059
71b41406
PE
11060 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11061
9587a89d
PE
11062 emacs_write: Accept and return EMACS_INT for sizes.
11063 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11064 et seq.
11065 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11066 Accept and return EMACS_INT.
11067 (emacs_gnutls_write): Return the number of bytes written on
11068 partial writes.
11069 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11070 (emacs_read, emacs_write): Remove check for negative size, as the
11071 Emacs source code has been audited now.
9587a89d
PE
11072 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11073 (emacs_read, emacs_write): Use it.
273a5f82
PE
11074 * process.c (send_process): Adjust to the new signatures of
11075 emacs_write and emacs_gnutls_write. Do not attempt to store
11076 a byte offset into an 'int'; it might overflow.
9587a89d 11077 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11078
3e047f51
PE
11079 * sound.c: Don't assume sizes fit in 'int'.
11080 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11081 Return EMACS_INT, not int.
3e047f51 11082 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11083 Accept EMACS_INT, not int.
11084 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11085 record read return values.
11086
cc39a9db
BK
110872011-04-15 Ben Key <bkey76@gmail.com>
11088
c9d0ec6d
JB
11089 * keyboard.c (Qundefined): Don't declare static since it is used
11090 in nsfns.m.
11091 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11092 static since they are used in nsfont.m.
cc39a9db 11093
6c60eb9f
SM
110942011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11095
11096 * process.c (Qprocessp): Don't declare static.
11097 * lisp.h (Qprocessp): Declare again.
11098
7990b61a
JB
110992011-04-15 Juanma Barranquero <lekktu@gmail.com>
11100
11101 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11102
5d4cb038
PE
111032011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11104
8bd7b830 11105 Improve C-level modularity by making more things 'static'.
cd64ea1d 11106
e3b27b31
PE
11107 Don't publish debugger-only interfaces to other modules.
11108 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11109 (verify_bytepos, count_markers): Move decls to the only modules
11110 that need them.
11111 * region-cache.h (pp_cache): Likewise.
11112 * window.h (check_all_windows): Likewise.
11113 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11114
5d4cb038
PE
11115 * sysdep.c (croak): Now static, if
11116 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11117 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11118
11119 * alloc.c (refill_memory_reserve): Now static if
11120 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11121 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11122
e87b6180
PE
11123 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11124 Define only if USE_LUCID.
11125
ac64929e
PE
11126 * xrdb.c (x_customization_string, x_rm_string): Now static.
11127
6f37259d
PE
11128 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11129 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11130
1683e3ab
PE
11131 * xdisp.c (draw_row_with_mouse_face): Now static.
11132 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11133
de9c2632
PE
11134 * window.h (check_all_windows): Mark externally visible.
11135
2b96acb7
PE
11136 * window.c (window_deletion_count): Now static.
11137
11138 * undo.c: Make symbols static if they're not exported.
11139 (last_undo_buffer, last_boundary_position, pending_boundary):
11140 Now static.
11141
50436f33
PE
11142 * textprop.c (interval_insert_behind_hooks): Now static.
11143 (interval_insert_in_front_hooks): Likewise.
11144
64520e5c
PE
11145 * term.c: Make symbols static if they're not exported.
11146 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11147 (max_frame_lines, tty_set_terminal_modes):
11148 (tty_reset_terminal_modes, tty_turn_off_highlight):
11149 (get_tty_terminal): Now static.
11150 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11151 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11152 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11153 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11154 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11155
1fa53021
PE
11156 * sysdep.c: Make symbols static if they're not exported.
11157 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11158 Now static.
11159 (sigprocmask_set, full_mask): Remove; unused.
11160 (wait_debugging): Mark as visible.
11161 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11162 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11163
d4b43b22
PE
11164 * syntax.c (syntax_temp): Define only if !__GNUC__.
11165
b7c513d0
PE
11166 * sound.c (current_sound_device, current_sound): Now static.
11167
989b29ad
PE
11168 * search.c (searchbufs, searchbuf_head): Now static.
11169
13a55a78
PE
11170 * scroll.c (scroll_cost): Remove; unused.
11171 * dispextern.h (scroll_cost): Remove decl.
11172
de68a1fc
PE
11173 * region-cache.h (pp_cache): Mark as externally visible.
11174
40ccffa6
PE
11175 * process.c: Make symbols static if they're not exported.
11176 (process_tick, update_tick, create_process, chan_process):
11177 (Vprocess_alist, proc_buffered_char, datagram_access):
11178 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11179 (deactivate_process): Mark defn as static, as well as decl.
11180 * lisp.h (create_process): Remove decl.
11181 * process.h (chan_process, Vprocess_alist): Remove decls.
11182
ad64fc97
PE
11183 * print.c: Make symbols static if they're not exported.
11184 (print_depth, new_backquote_output, being_printed, print_buffer):
11185 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11186 (print_interval, print_number_index, initial_stderr_stream):
11187 Now static.
11188 * lisp.h (Fprinc): Remove decl.
11189 (debug_output_compilation_hack): Mark as externally visible.
11190
adddb265
PE
11191 * sysdep.c (croak): Move decl from here to syssignal.h.
11192 * syssignal.h (croak): Put it here, so the API can be checked when
11193 'croak' is called from dissociate_if_controlling_tty.
11194
1717ede2
PE
11195 * minibuf.c: Make symbols static if they're not exported.
11196 (minibuf_save_list, choose_minibuf_frame): Now static.
11197 * lisp.h (choose_minibuf_frame): Remove decl.
11198
fa5fb2bc
PE
11199 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11200
1e3890d1
PE
11201 * lread.c: Make symbols static if they're not exported.
11202 (read_objects, initial_obarray, oblookup_last_bucket_number):
11203 Now static.
11204 (make_symbol): Remove; unused.
11205 * lisp.h (initial_obarray, make_symbol): Remove decls.
11206
8a1414fa
PE
11207 * keyboard.c: Make symbols static if they're not exported.
11208 (single_kboard, recent_keys_index, total_keys, recent_keys):
11209 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11210 (this_single_command_key_start, echoing, last_auto_save):
11211 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11212 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11213 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11214 (Vlispy_mouse_stem, double_click_count):
11215 Now static.
11216 (force_auto_save_soon): Define only if SIGDANGER.
11217 (ignore_mouse_drag_p): Now static if
11218 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11219 (print_help): Remove; unused.
11220 (stop_character, last_timer_event): Mark as externally visible.
11221 * keyboard.h (ignore_mouse_drag_p): Declare only if
11222 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11223 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11224 * lisp.h (echoing): Remove decl.
11225 (force_auto_save_soon): Declare only if SIGDANGER.
11226 * xdisp.c (redisplay_window): Simplify code, to make it more
11227 obvious that ignore_mouse_drag_p is not accessed if !defined
11228 USE_GTK && !defined HAVE_NS.
11229
93ea6e8f
PE
11230 * intervals.c: Make symbols static if they're not exported.
11231 (merge_properties_sticky, merge_interval_right, delete_interval):
11232 Now static.
11233 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11234
77382fcc
PE
11235 * insdel.c: Make symbols static if they're not exported.
11236 However, leave prepare_to_modify_buffer alone. It's never
11237 called from outside this function, but that appears to be a bug.
11238 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11239 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11240 (adjust_after_replace_noundo): Remove; unused.
11241 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11242 (signal_before_change): Remove decls.
77382fcc 11243
9306c32e
PE
11244 * indent.c (val_compute_motion, val_vmotion): Now static.
11245
cd44d2eb
PE
11246 * image.c: Make symbols static if they're not exported.
11247 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11248 if USE_GTK.
11249 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11250 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11251
ad9a7a06
PE
11252 * fringe.c (standard_bitmaps): Now static.
11253 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11254
81626931
PE
11255 * frame.c: Make symbols static if they're not exported.
11256 (x_report_frame_params, make_terminal_frame): Now static.
11257 (get_frame_param): Now static, unless HAVE_NS.
11258 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11259 (x_get_resource_string): Remove; not used.
11260 * frame.h (make_terminal_frame, x_report_frame_params):
11261 (x_get_resource_string); Remove decls.
11262 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11263 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11264
239f9db9
PE
11265 * font.c, fontset.c: Make symbols static if they're not exported.
11266 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11267 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11268 * font.c (font_close_object): Now static.
11269 * font.h (font_close_object): Remove.
11270 * fontset.c (FONTSET_OBJLIST): Remove.
11271 (free_realized_fontset) #if-0 the body, which does nothing.
11272 (face_suitable_for_char_p): #if-0, as it's never called.
11273 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11274 * xfaces.c (face_at_string_position):
11275 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11276 since 0 is always ASCII.
11277
dfcf3579
PE
11278 * fns.c (weak_hash_tables): Now static.
11279
5045092b
PE
11280 * fileio.c: Make symbols static if they're not exported.
11281 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11282 (Vwrite_region_annotation_buffers): Now static.
11283
57a96f5c
PE
11284 * eval.c: Make symbols static if they're not exported.
11285 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11286 * lisp.h (backtrace_list): Remove decl.
11287
35f08c38
PE
11288 * emacs.c: Make symbols static if they're not exported.
11289 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11290 (fatal_error_code, fatal_error_signal_hook, standard_args):
11291 Now static.
11292 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11293 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11294 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11295 * lisp.h (fatal_error_signal_hook): Remove decl.
11296 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11297
f44bd759
PE
11298 * editfns.c: Move a (normally-unused) function to its only use.
11299 * editfns.c, lisp.h (get_operating_system_release): Remove.
11300 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11301 worth the hassle of breaking this out.
11302
b532497d
PE
11303 * xterm.c: Make symbols static if they're not exported.
11304 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11305 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11306 (x_destroy_window, x_delete_display):
11307 Now static.
11308 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11309 (x_mouse_leave): Remove; unused.
11310 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11311 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11312 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11313 Remove decls.
11314 (x_mouse_leave): Declare only if WINDOWSNT.
11315 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11316 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11317 USE_X_TOOLKIT.
11318
1675728f
PE
11319 * ftxfont.c: Make symbols static if they're not exported.
11320 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11321 HAVE_FREETYPE.
11322 * font.h (ftxfont_driver): Likewise.
11323
e4cebfca
PE
11324 * xfns.c: Make symbols static if they're not exported.
11325 (x_last_font_name, x_display_info_for_name):
11326 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11327 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11328 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11329 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11330 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11331 (last_show_tip_args): Now static.
11332 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11333 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11334 (x_screen_planes): Remove; unused.
11335 * dispextern.h (x_screen_planes): Remove decl.
11336
5bf46f05
PE
11337 * dispnew.c: Make symbols static if they're not exported.
11338 * dispextern.h (redraw_garbaged_frames, scrolling):
11339 (increment_row_positions): Remove.
11340 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11341 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11342 Now static.
11343 (redraw_garbaged_frames): Remove; unused.
11344
435f4c28
PE
11345 * xfaces.c: Make symbols static if they're not exported.
11346 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11347 Remove decls.
11348 * xterm.h (defined_color): Remove decls.
11349 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11350 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11351 (menu_face_changed_default, defined_color, free_realized_face):
11352 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11353 (ascii_face_of_lisp_face): Remove; unused.
11354
8524aef3
PE
11355 * xdisp.c: Make symbols static if they're not exported.
11356 * dispextern.h (scratch_glyph_row, window_box_edges):
11357 (glyph_to_pixel_coords, set_cursor_from_row):
11358 (get_next_display_element, set_iterator_to_next):
11359 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11360 (show_mouse_face): Remove decls
11361 * frame.h (message_buf_print): Likewise.
11362 * lisp.h (pop_message, set_message, check_point_in_composition):
11363 Likewise.
11364 * xterm.h (set_vertical_scroll_bar): Likewise.
11365 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11366 (message_buf_print, scratch_glyph_row, displayed_buffer):
11367 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11368 (get_next_display_element, show_mouse_face, window_box_edges):
11369 (frame_to_window_pixel_xy, check_point_in_composition):
11370 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11371 (glyph_to_pixel_coords): Remove; unused.
11372
16390cd2
PE
11373 * dired.c (file_name_completion): Now static.
11374
11375 * dbusbind.c (xd_in_read_queued_messages): Now static.
11376
a25f4dfa
PE
11377 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11378 * data.c (circular_list_error): Remove.
11379
14a9c8df
PE
11380 * commands.h (last_point_position, last_point_position_buffer):
11381 (last_point_position_window): Remove decls.
11382 * keyboard.c: Make these variables static.
11383
04f2d78b
CB
11384 * coding.h (coding, code_convert_region, encode_coding_gap):
11385 Remove decls.
74ab6df5
PE
11386 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11387 (iso_code_class, detect_coding, code_convert_region): Now static.
11388 (encode_coding_gap): Remove; unused.
11389
38dfbee1
PE
11390 * chartab.c (chartab_chars, chartab_bits): Now static.
11391
a2cb4e63
PE
11392 * charset.h (charset_iso_8859_1): Remove decl.
11393 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11394 Now static.
11395
127198fd
PE
11396 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11397 * ccl.c (Vccl_program_table): Now static.
11398 (check_ccl_update): Remove; unused.
11399
d85b608f
PE
11400 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11401 * category.h: ... from here.
11402 * category.c (check_category_table, set_category_set): Now static.
11403
31cd66f3
PE
11404 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11405 * lisp.h: Remove these decls.
11406
c358e587
PE
11407 * buffer.c (buffer_count): Remove unused var.
11408
e78aecca
PE
11409 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11410 so that it's not optimized away.
11411 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11412 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11413 exported only to the debugger.
11414
e192d7d3 11415 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11416 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11417
92470028
PE
11418 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11419 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11420 was inaccessible from Lisp.
11421 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11422 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11423
244ed907
PE
11424 alloc.c: Import and export fewer symbols, and remove unused items.
11425 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11426 is defined.
11427 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11428 it's not optimized away by whole-program optimization.
11429 (message_enable_multibyte, free_misc): Remove.
11430 (catchlist, handlerlist, mark_backtrace):
11431 Declare only if BYTE_MARK_STACK.
11432 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11433 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11434 (message_enable_multibyte): Remove decl.
11435 (free_misc, interval_free_list, float_block, float_block_index):
11436 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11437 (cons_free_list, last_marked_index):
11438 Now static.
11439 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11440 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11441 (mark_backtrace): Define only if BYTE_MARK_STACK.
11442 * xdisp.c (message_enable_multibyte): Now static.
11443
61c2b50e 11444 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11445 This makes it easier for human readers (and static analyzers)
11446 to see whether these variables are used from other modules.
11447 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11448 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11449 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11450 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11451 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11452 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11453 * xmenu.c, xselect.c:
11454 Declare Q* vars static if they are not used in other modules.
11455 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11456 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11457 Remove decls of unexported vars.
11458 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11459
95c82688
PE
11460 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11461
16a97296
PE
11462 Make Emacs functions such as Fatom 'static' by default.
11463 This makes it easier for human readers (and static analyzers)
11464 to see whether these functions can be called from other modules.
11465 DEFUN now defines a static function. To make the function external
11466 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11467 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11468 (Finit_image_library):
16a97296
PE
11469 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11470 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11471 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11472 Remove decls, since these functions are now static.
11473 (Funintern, Fget_internal_run_time): New decls, since these functions
11474 were already external.
95c82688 11475
16a97296
PE
11476 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11477 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11478 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11479 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11480 * keyboard.c, keymap.c, lread.c:
11481 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11482 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11483 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11484 Mark functions with DEFUE instead of DEFUN,
11485 if they are used in other modules.
11486 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11487 decls for now-static functions.
11488 * buffer.h (Fdelete_overlay): Remove decl.
11489 * callproc.c (Fgetenv_internal): Mark as internal.
11490 * composite.c (Fremove_list_of_text_properties): Remove decl.
11491 (Fcomposition_get_gstring): New forward static decl.
11492 * composite.h (Fcomposite_get_gstring): Remove decl.
11493 * dired.c (Ffile_attributes): New forward static decl.
11494 * doc.c (Fdocumntation_property): New forward static decl.
11495 * eval.c (Ffetch_bytecode): New forward static decl.
11496 (Funintern): Remove extern decl; now in .h file where it belongs.
11497 * fileio.c (Fmake_symbolic_link): New forward static decl.
11498 * image.c (Finit_image_library): New forward static decl.
11499 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11500 * intervals.h (Fprevious_property_change):
11501 (Fremove_list_of_text_properties): Remove decls.
11502 * keyboard.c (Fthis_command_keys): Remove decl.
11503 (Fcommand_execute): New forward static decl.
11504 * keymap.c (Flookup_key): New forward static decl.
11505 (Fcopy_keymap): Now static.
11506 * keymap.h (Flookup_key): Remove decl.
11507 * process.c (Fget_process): New forward static decl.
11508 (Fprocess_datagram_address): Mark as internal.
11509 * syntax.c (Fsyntax_table_p): New forward static decl.
11510 (skip_chars): Remove duplicate decl.
11511 * textprop.c (Fprevious_property_change): New forward static decl.
11512 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11513 Now internal.
11514 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11515 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11516
785bbd42
PE
11517 * editfns.c (Fformat): Remove unreachable code.
11518
8b913b57
AS
115192011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11520
11521 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11522 change. (Bug#8496)
11523
a6744a35
EZ
115242011-04-13 Eli Zaretskii <eliz@gnu.org>
11525
11526 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11527 when at ZV. (Bug#8487)
11528
e7974947
AS
115292011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11530
baad03f0
AS
11531 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11532 (Bug#8437)
11533 * keyboard.c (parse_tool_bar_item): Likewise.
11534 * sound.c (sound_cleanup, alsa_close): Likewise.
11535 * termcap.c (tgetent): Likewise.
11536 * xfns.c (x_default_font_parameter): Likewise.
11537 * xsettings.c (read_and_apply_settings): Likewise.
11538
e7974947
AS
11539 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11540 (overrun_check_free): Protoize.
11541
28272684
PE
115422011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11543
11544 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11545 since callers should never pass a negative size.
11546 Change the signature to match that of plain 'read' and 'write'; see
11547 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11548 * lisp.h: Update prototypes of emacs_write and emacs_read.
11549
11997c76
EZ
115502011-04-11 Eli Zaretskii <eliz@gnu.org>
11551
11552 * xdisp.c (redisplay_window): Don't try to determine the character
11553 position of the scroll margin if the window start point w->startp
e896f03c 11554 is outside the buffer's accessible region. (Bug#8468)
11997c76 11555
8a2cbd72
EZ
115562011-04-10 Eli Zaretskii <eliz@gnu.org>
11557
11558 Fix write-region and its subroutines for buffers > 2GB.
11559 * fileio.c (a_write, e_write): Modify declaration of arguments and
11560 local variables to support buffers larger than 2GB.
11561 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11562
11563 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11564 argument, local variables, and return value.
11565
11566 * lisp.h: Update prototypes of emacs_write and emacs_read.
11567
11568 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11569
4073e537 115702011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11571
1ebfdcb6
PE
11572 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11573
b2ded58d
PE
11574 Fix more problems found by GCC 4.6.0's static checks.
11575
7d66342c
PE
11576 * xdisp.c (vmessage): Use a better test for character truncation.
11577
bbf47d44
PE
11578 * charset.c (load_charset_map): <, not <=, for optimization,
11579 and to avoid potential problems with integer overflow.
9248994d 11580 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11581 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11582 * editfns.c (Fformat): Likewise.
1e69125e 11583 * syntax.c (skip_chars): Likewise.
3befa583 11584
e3019616
PE
11585 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11586 This also lets GCC 4.6.0 generate slightly better loop code.
11587
becfa255
PE
11588 * callint.c (Fcall_interactively): <, not <=, for optimization.
11589 (Fcall_interactively): Count the number of arguments produced,
11590 not the number of arguments given. This is simpler and lets GCC
11591 4.6.0 generate slightly better code.
11592
dae0cd48
PE
11593 * ftfont.c: Distingish more carefully between FcChar8 and char.
11594 The previous code passed unsigned char * to a functions like
11595 strlen and xstrcasecmp that expect char *, which does not
11596 conform to the C standard.
11597 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11598 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11599 char * when the C standard requires it.
11600
76032d70
PE
11601 * keyboard.c (read_char): Remove unused var.
11602
eb3f1cc8
PE
11603 * eval.c: Port to Windows vsnprintf (Bug#8435).
11604 Include <limits.h>.
11605 (SIZE_MAX): Define if the headers do not.
11606 (verror): Do not give up if vsnprintf returns a negative count.
11607 Instead, grow the buffer. This ports to Windows vsnprintf, which
11608 does not conform to C99. Problem reported by Eli Zaretskii.
11609 Also, simplify the allocation scheme, by avoiding the need for
11610 calling realloc, and removing the ALLOCATED variable.
11611
70476b54
PE
11612 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11613
12020a9e
PE
11614 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11615 But keep the doprint source code for now, as we might revamp it
11616 and use it again (Bug#8435).
ea6c7ae6
PE
11617 * lisp.h (doprnt): Remove.
11618 * Makefile.in (base_obj): Remove doprnt.o.
11619 * deps.mk (doprnt.o): Remove.
11620
5fdb398c
PE
11621 error: Print 32- and 64-bit integers portably (Bug#8435).
11622 Without this change, on typical 64-bit hosts error ("...%d...", N)
11623 was used to print both 32- and 64-bit integers N, which relied on
11624 undefined behavior.
61bdb816 11625 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11626 * lisp.h (error, verror): Mark as printf-like functions.
11627 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11628 Report overflow in size calculations when allocating printf buffer.
11629 Do not truncate output string at its first null byte.
11630 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11631 Truncate the output at a character boundary, since vsnprintf does not
11632 do that.
11633 * charset.c (check_iso_charset_parameter): Convert internal
11634 character to string before calling 'error', since %c now has the
11635 printf meaning.
11636 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11637 overflow when computing char to be passed to 'error'. Do not
11638 pass Lisp_Object to 'error'; pass the integer instead.
11639 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11640 formatted with plain %d.
11641
b189fa66
PE
11642 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11643
bff87ef0
PE
11644 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11645
7e2cac20
PE
11646 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11647
ce4d90b5
PE
11648 * xterm.c (x_catch_errors): Remove duplicate declaration.
11649
266c9547
PE
11650 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11651
79c49ad2
PE
11652 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11653
368f4090
JM
116542011-04-10 Jim Meyering <meyering@redhat.com>
11655
11656 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11657 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11658 return ssize_t not "int", and use size_t as the buffer length.
11659 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11660 * gnutls.h: Update declarations.
11661 * process.c (read_process_output): Use ssize_t, to match.
11662 (send_process): Likewise.
11663
a32d4040
CY
116642011-04-09 Chong Yidong <cyd@stupidchicken.com>
11665
11666 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11667
8546720e 116682011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11669
04f2d78b
CB
11670 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11671 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11672
8546720e
GM
11673 * xterm.c (handle_one_xevent):
11674 * xmenu.c (create_and_show_popup_menu):
11675 * xselect.c (x_decline_selection_request)
11676 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11677
0a2f5c1a 116782011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11679
11680 Fix some uses of `int' instead of EMACS_INT.
11681 * search.c (string_match_1, fast_string_match)
11682 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11683 (scan_buffer, find_next_newline_no_quit)
11684 (find_before_next_newline, search_command, Freplace_match)
11685 (Fmatch_data): Make some `int' variables be EMACS_INT.
11686
11687 * xdisp.c (display_count_lines): 3rd argument and return value now
11688 EMACS_INT. All callers changed.
11689 (pint2hrstr): Last argument is now EMACS_INT.
11690
11691 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11692 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11693 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11694 (decode_coding_utf_16, decode_coding_emacs_mule)
11695 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11696 (decode_coding_ccl, decode_coding_charset)
11697 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11698 (decode_coding_iso_2022, decode_coding_emacs_mule)
11699 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11700 <char_offset, last_offset>: Declare EMACS_INT.
11701 (encode_coding_utf_8, encode_coding_utf_16)
11702 (encode_coding_emacs_mule, encode_invocation_designation)
11703 (encode_designation_at_bol, encode_coding_iso_2022)
11704 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11705 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11706 Declare EMACS_INT.
11707 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11708 (encode_invocation_designation): Last argument P_NCHARS is now
11709 EMACS_INT.
11710 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11711 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11712
11713 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11714 All users changed.
11715
11716 * ccl.c (Fccl_execute_on_string): Declare some variables
11717 EMACS_INT.
11718
8546720e 117192011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11720
11721 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11722
4e19a977
CS
117232011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11724
11725 * process.c (Fformat_network_address): Doc fix.
11726
87302331
R
117272011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11728
ee7683eb 11729 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11730
cbb59342
CY
117312011-04-08 Chong Yidong <cyd@stupidchicken.com>
11732
11733 * keyboard.c (read_char): Call Lisp function help-form-show,
11734 instead of using internal_with_output_to_temp_buffer.
11735 (Qhelp_form_show): New var.
e0d38eeb 11736 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11737
11738 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11739
11740 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11741
e67a13ab
CY
117422011-04-06 Chong Yidong <cyd@stupidchicken.com>
11743
04f2d78b
CB
11744 * process.c (Flist_processes): Remove to Lisp.
11745 (list_processes_1): Delete.
e67a13ab 11746
973f782d
EZ
117472011-04-06 Eli Zaretskii <eliz@gnu.org>
11748
7c106b1e
EZ
11749 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11750
973f782d
EZ
11751 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11752
41cf7d1a 117532011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11754
ca23cc88
PE
11755 Fix more problems found by GCC 4.6.0's static checks.
11756
f390e2d5
PE
11757 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11758
42eea0d0
PE
11759 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11760
b69769da 11761 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11762
f9541e84
PE
11763 * xdisp.c (vmessage): Mark as a printf-like function.
11764
13841b55
PE
11765 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11766
c136c10f
PE
11767 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11768
5e2d4a30
PE
11769 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11770 printf-like functions.
11771 (tiff_load): Add casts to remove these marks before passing them
11772 to system-supplied API.
11773
583f48b9
PE
11774 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11775
b25d760e
PE
11776 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11777 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11778 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11779 directly, rather than having caller test rule sign. This avoids
11780 some unnecessary tests.
11781 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11782 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11783 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11784
bc7b6697 11785 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11786 (xfont_open): Avoid unnecessary tests.
bc7b6697 11787
27ccc379
PE
11788 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11789
dcd5c89a
PE
11790 * composite.h, composite.c (composition_gstring_put_cache):
11791 Use EMACS_INT, not int, for length.
11792
b13a45c6
PE
11793 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11794 breaking out part of COMPOSITION_DECODE_RULE.
11795 (COMPOSITION_DECODE_RULE): Use it.
11796 * composite.c (get_composition_id): Remove unused local vars,
11797 by using the new macro.
11798
1e792e4d
PE
11799 * textprop.c (set_text_properties_1): Change while to do-while,
11800 since the condition is always true at first.
11801
dc6c6455 11802 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11803 (interval_deletion_adjustment): Return unsigned value.
11804 All uses changed.
dc6c6455 11805
aba7731a
PE
11806 * process.c (list_processes_1, create_pty, read_process_output):
11807 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11808 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11809 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11810 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11811 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11812
fdfc4bf3
PE
11813 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11814
fca8fe46 11815 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11816 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11817
06a0259a 11818 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11819 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11820 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11821
e7b9e80f
PE
11822 * print.c (print_error_message): Avoid int overflow.
11823
56201685
PE
11824 * font.c (font_list_entities): Redo for clarity,
11825 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11826
78834453 11827 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11828 (font_score): Avoid potential overflow in diff calculation.
78834453 11829
0bc0b309 11830 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11831 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11832
e610eaca
PE
11833 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11834
b895abce
PE
11835 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11836 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11837 can always succeed if overflow has undefined behavior.
11838
1f1d9321 11839 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11840 (wordify): Omit three unnecessary tests.
1f1d9321 11841
c59478bc
PE
11842 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11843 All callers changed. This avoids the need for an unused var.
11844
79b73827
PE
11845 * casefiddle.c (casify_region): Remove var that is set but not used.
11846
a4db5dfe
PE
11847 * dired.c (file_name_completion): Remove var that is set but not used.
11848
43aae36e
PE
11849 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11850
2a47c44d 11851 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11852 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11853
a37c69bf
PE
11854 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11855 Check for integer overflow on size calculations.
11856
328ab8e7
PE
11857 * buffer.c (Fprevious_overlay_change): Remove var that is set
11858 but not used.
11859
e5a2a5cb
PE
11860 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11861 Remove vars that are set but not used.
8d84a6eb 11862 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11863 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11864
a60e5f68
PE
11865 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11866
f661cb61 11867 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11868 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11869
f0397f5a
PE
11870 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11871 that are set but not used.
11872
8664db06 11873 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11874 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11875
6abdaa4a
PE
11876 * xselect.c (x_get_local_selection, x_handle_property_notify):
11877 Remove vars that are set but not used.
11878
0ce7538d 11879 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11880 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11881
9ae848fc
PE
11882 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11883 Remove var that is set but not used.
0b918413
PE
11884 (scroll_bar_windows_size): Now size_t, not int.
11885 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11886 Check for overflow.
9ae848fc 11887
a5a62657
PE
11888 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11889 (map_tty_color) [!defined MSDOS]: Likewise.
11890
5c5cdd39
PE
11891 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11892
66ebf983
PE
11893 * coding.c: Remove vars that are set but not used.
11894 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11895 All callers changed.
11896 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11897 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11898 (decode_coding_charset): Remove vars that are set but not used.
11899
1be4d761
PE
11900 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11901 that is set but not used.
11902
47553fa8
PE
11903 * print.c (print_object): Remove var that is set but not used.
11904
1f7196bf 11905 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11906 The gnulib version avoids calling malloc in the usual case,
11907 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11908 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11909 * filelock.c (current_lock_owner): Likewise.
11910 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11911 * sysdep.c: Include allocator.h, careadlinkat.h.
11912 (emacs_no_realloc_allocator): New static constant.
11913 (emacs_readlink): New function.
fdb61804
PE
11914 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11915 ../lib/careadlinkat.h.
d1fdcab7 11916
f84c17c7
SM
119172011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11918
11919 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11920 first non-nil return value).
11921
ef3862ad
JD
119222011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11923
11924 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11925 if not defined (Bug#8403).
11926
376a7006
JB
119272011-04-02 Juanma Barranquero <lekktu@gmail.com>
11928
11929 * xdisp.c (display_count_lines): Remove parameter `start',
11930 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11931 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11932 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11933 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11934 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11935 and thereabouts. All callers changed.
11936 (get_per_char_metric): Remove parameter `f', unused since
11937 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11938
6ca3801d
JM
119392011-04-02 Jim Meyering <meyering@redhat.com>
11940
11941 do not dereference NULL upon failed strdup
11942 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11943 (ns_get_family): Likewise.
11944
d8e2b5ba
JB
119452011-04-02 Juanma Barranquero <lekktu@gmail.com>
11946
11947 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11948
8c74fcbd
JD
119492011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11950
11951 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11952 later (Bug#8403).
11953
7200d79c
SM
119542011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11955
03408648 11956 Add lexical binding.
7200d79c 11957
03408648
SM
11958 * window.c (Ftemp_output_buffer_show): New fun.
11959 (Fsave_window_excursion):
11960 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11961
11962 * lread.c (lisp_file_lexically_bound_p): New function.
11963 (Fload): Bind Qlexical_binding.
11964 (readevalloop): Remove `evalfun' arg.
11965 Bind Qinternal_interpreter_environment.
11966 (Feval_buffer): Bind Qlexical_binding.
11967 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11968 Mark as dynamic.
11969 (syms_of_lread): Declare `lexical-binding'.
11970
11971 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11972
11973 * keyboard.c (eval_dyn): New fun.
11974 (menu_item_eval_property): Use it.
ca105506
SM
11975
11976 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11977
03408648
SM
11978 * fns.c (concat, mapcar1): Accept byte-code-functions.
11979
11980 * eval.c (Fsetq): Handle lexical vars.
11981 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11982 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11983 (FletX, Flet): Obey lexical binding.
11984 (Fcommandp): Handle closures.
11985 (Feval): New `lexical' arg.
11986 (eval_sub): New function extracted from Feval. Use it almost
11987 everywhere where Feval was used. Look up vars in lexical env.
11988 Handle closures.
11989 (Ffunctionp): Move from subr.el.
11990 (Ffuncall): Handle closures.
11991 (apply_lambda): Remove `eval_flags'.
11992 (funcall_lambda): Handle closures and new byte-code-functions.
11993 (Fspecial_variable_p): New function.
11994 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11995 but without exporting it to Lisp.
23aba0ea 11996
23aba0ea 11997 * doc.c (Fdocumentation, store_function_docstring):
03408648 11998 * data.c (Finteractive_form): Handle closures.
23aba0ea 11999
03408648
SM
12000 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12001 interactive spec.
ba83908c 12002
04f2d78b
CB
12003 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12004 New byte-codes.
03408648
SM
12005 (exec_byte_code): New function extracted from Fbyte_code to handle new
12006 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12007
03408648 12008 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12009
03408648 12010 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12011
e2abce01
JB
120122011-03-31 Juanma Barranquero <lekktu@gmail.com>
12013
12014 * xdisp.c (redisplay_internal): Fix prototype.
12015
63696a73 120162011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12017
63696a73 12018 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12019 (try_scrolling): Use it when setting scroll_limit.
12020 Limit scrolling to 100 screen lines.
63696a73
EZ
12021 (redisplay_window): Even when falling back on "recentering",
12022 position point in the window according to scroll-conservatively,
12023 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12024
12025 (try_scrolling): When point is above the window, allow searching
12026 as far as scroll_max, or one screenful, to compute vertical
12027 distance from PT to the scroll margin position. This prevents
12028 try_scrolling from unnecessarily failing when
12029 scroll-conservatively is set to a value slightly larger than the
12030 window height. Clean up the case of PT below the margin at bottom
12031 of window: scroll_max can no longer be INT_MAX. When aggressive
12032 scrolling is in use, don't let point enter the opposite scroll
12033 margin as result of the scroll.
12034 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12035 threshold of 100 lines for never-recentering scrolling.
12036
e4cc2dfc
JB
120372011-03-31 Juanma Barranquero <lekktu@gmail.com>
12038
12039 * dispextern.h (move_it_by_lines):
12040 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12041 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12042 (message_log_check_duplicate): Remove parameters `prev_bol' and
12043 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12044 (redisplay_internal): Remove parameter `preserve_echo_area',
12045 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12046
12047 * indent.c (Fvertical_motion):
12048 * window.c (window_scroll_pixel_based, Frecenter):
12049 Don't pass `need_y_p' to `move_it_by_lines'.
12050
1c470562
SM
120512011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12052
44f230aa
SM
12053 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12054 steal a few bits to be more compact.
12055 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12056 Remove unneeded casts.
12057
1c470562
SM
12058 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12059
888adce9
ZK
120602011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12061
12062 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12063 binding" message (bug#7967).
12064
f838ed7b
PE
120652011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12066
77861b95
PE
12067 Fix more problems found by GCC 4.6.0's static checks.
12068
de6dbc14
PE
12069 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12070 Remove unused local var.
12071
f838ed7b
PE
12072 * editfns.c (Fmessage_box): Remove unused local var.
12073
792c7b2b
PE
12074 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12075 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12076 Omit unused local vars.
c499e557 12077 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12078 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12079 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12080 Omit unused local var.
12081
ba0165e1
PE
12082 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12083 Don't assume string length fits in int.
32ad8845 12084 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12085 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12086
3c59b4c9
PE
12087 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12088 instead of alloca (Bug#8344).
12089
a3eed478 12090 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12091 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12092
eb4d412d
PE
12093 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12094
1658b401
PE
12095 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12096 concerns.
12097
12098 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12099
12100 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12101
9a2c6e05
PE
12102 * keyboard.c (syms_of_keyboard): Use the same style as later
12103 in this function when indexing through an array. This also
12104 works around GCC bug 48267.
12105
03d0a109
PE
12106 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12107
44f730c8
PE
12108 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12109
fe75f926
PE
12110 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12111 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12112
ffa8c828
PE
12113 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12114 This avoids undefined behavior on integer overflow, and is a bit
12115 more convenient anyway since it is compared to a size_t variable.
12116
c5101a77
PE
12117 Variadic C functions now count arguments with size_t, not int.
12118 This avoids an unnecessary limitation on 64-bit machines, which
12119 caused (substring ...) to crash on large vectors (Bug#8344).
12120 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12121 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12122 All variadic functions and their callers changed accordingly.
c5101a77
PE
12123 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12124 * data.c (arith_driver, float_arith_driver): Likewise.
12125 * editfns.c (general_insert_function): Likewise.
12126 * eval.c (struct backtrace.nargs, interactive_p)
12127 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12128 (funcall_lambda, mark_backtrace): Likewise.
12129 * fns.c (concat): Likewise.
12130 * frame.c (x_set_frame_parameters): Likewise.
12131 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12132 0 if not found, not -1. All callers changed.
12133
dd3f25f7
PE
12134 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12135 (stack_copy_size): Now size_t, not int.
12136 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12137
461c2ab9
JB
121382011-03-28 Juanma Barranquero <lekktu@gmail.com>
12139
12140 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12141 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12142 All callers changed.
12143
12144 * lisp.h (multibyte_char_to_unibyte):
12145 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12146 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12147 * character.h (CHAR_TO_BYTE8):
12148 * cmds.c (internal_self_insert):
12149 * editfns.c (general_insert_function):
12150 * keymap.c (push_key_description):
12151 * search.c (Freplace_match):
12152 * xdisp.c (message_dolog, set_message_1): All callers changed.
12153
f6d62986
SM
121542011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12155
12156 * keyboard.c (safe_run_hook_funcall): New function.
12157 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12158 don't set the hook to nil, but remove the offending function instead.
12159 (Qcommand_hook_internal): Remove, unused.
12160 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12161 Vcommand_hook_internal.
12162
12163 * eval.c (enum run_hooks_condition): Remove.
12164 (funcall_nil, funcall_not): New functions.
12165 (run_hook_with_args): Call each function through a `funcall' argument.
12166 Remove `cond' argument, now redundant.
12167 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12168 (Frun_hook_with_args_until_failure): Adjust accordingly.
12169 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12170
1db5b1ad
JB
121712011-03-28 Juanma Barranquero <lekktu@gmail.com>
12172
12173 * dispextern.h (string_buffer_position): Remove declaration.
12174
12175 * print.c (strout): Remove parameter `multibyte', unused since
12176 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12177
12178 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12179 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12180 All callers changed.
12181
12182 * w32.c (_wsa_errlist): Use braces for struct initializers.
12183
12184 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12185 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12186 All callers changed.
12187 (string_buffer_position): Likewise. Also, make static (it's never
12188 used outside xdisp.c).
12189 (cursor_row_p): Remove parameter `w', unused since
12190 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12191 (decode_mode_spec): Remove parameter `precision', introduced during
12192 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12193 All callers changed.
12194
5ffb62aa
JD
121952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12196
12197 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12198
461c2ab9 121992011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12200
12201 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12202 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12203 (ns_update_auto_hide_menu_bar): New functions.
12204 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12205 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12206 ns_constrain_all_frames.
12207 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12208 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12209
5c380ffb
JD
122102011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12211
12212 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12213
9af30bdf
GM
122142011-03-27 Glenn Morris <rgm@gnu.org>
12215
12216 * syssignal.h: Replace RETSIGTYPE with void.
12217 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12218 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12219 Replace SIGTYPE with void everywhere.
12220 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12221 * s/template.h (SIGTYPE): Remove commented out definition.
12222
e2abce01
JB
122232011-03-26 Eli Zaretskii <eliz@gnu.org>
12224
12225 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12226 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12227
f868cd8a
JB
122282011-03-26 Juanma Barranquero <lekktu@gmail.com>
12229
59eb0929
JB
12230 * w32.c (read_unc_volume): Use parameter `henum', instead of
12231 global variable `wget_enum_handle'.
12232
12233 * keymap.c (describe_vector): Remove parameters `indices' and
12234 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12235 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12236
f868cd8a
JB
12237 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12238
12239 * keyboard.c (timer_check): Remove parameter `do_it_now',
12240 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12241 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12242 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12243
12244 * keyboard.c (read_char):
12245 * w32menu.c (w32_menu_display_help):
12246 * xmenu.c (show_help_event, menu_help_callback):
12247 Adjust calls to `show_help_echo'.
12248
12249 * gtkutil.c (xg_maybe_add_timer):
12250 * keyboard.c (readable_events):
12251 * process.c (wait_reading_process_output):
12252 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12253
12254 * insdel.c (adjust_markers_gap_motion):
12255 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12256 (gap_left, gap_right): Don't call it.
12257
2ecf6fdb
CY
122582011-03-25 Chong Yidong <cyd@stupidchicken.com>
12259
12260 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12261 incurred during fontification.
12262
6b1f9ba4
JB
122632011-03-25 Juanma Barranquero <lekktu@gmail.com>
12264
12265 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12266 (DEFVAR_PER_BUFFER): Don't pass it.
12267
12268 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12269 (scrolling_window): Don't pass it.
12270
0f4a96b5
JB
122712011-03-25 Juanma Barranquero <lekktu@gmail.com>
12272
12273 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12274
12275 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12276 and `suffix'.
12277 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12278 of variables specific to SELinux and computation of `encoded_absname'.
12279
12280 * image.c (XPutPixel): Remove unused variable `height'.
12281
12282 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12283
12284 * unexw32.c (get_section_info): Remove unused variable `section'.
12285
12286 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12287 (system_process_attributes): Remove unused variable `sess'.
12288 (sys_read): Remove unused variable `err'.
12289
12290 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12291 (w32_wnd_proc): Remove unused variable `isdead'.
12292 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12293 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12294 (x_create_tip_frame): Remove unused variable `tem'.
12295
12296 * w32inevt.c (w32_console_read_socket):
12297 Remove unused variable `no_events'.
12298
12299 * w32term.c (x_draw_composite_glyph_string_foreground):
12300 Remove unused variable `width'.
12301
1149507c
JB
123022011-03-24 Juanma Barranquero <lekktu@gmail.com>
12303
12304 * w32term.c (x_set_glyph_string_clipping):
12305 Don't pass uninitialized region to CombineRgn.
12306
9c88f339
JB
123072011-03-23 Juanma Barranquero <lekktu@gmail.com>
12308
12309 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12310 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12311 (Fx_close_connection): Remove unused variable `i'.
12312
12313 * w32font.c (w32font_draw): Return number of glyphs.
12314 (w32font_open_internal): Remove unused variable `i'.
12315 (w32font_driver): Add missing initializer.
12316
12317 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12318 (fill_in_menu): Remove unused variable `items_added'.
12319
12320 * w32term.c (last_mouse_press_frame): Remove static global variable.
12321 (w32_clip_to_row): Remove unused variable `f'.
12322 (x_delete_terminal): Remove unused variable `i'.
12323
12324 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12325 (NOTHING): Remove unused static global variable.
12326 (uniscribe_check_otf): Remove unused variable `table'.
12327 (uniscribe_font_driver): Add missing initializers.
12328
dee091a3
JD
123292011-03-23 Julien Danjou <julien@danjou.info>
12330
12331 * term.c (Fsuspend_tty, Fresume_tty):
12332 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12333 * window.c (temp_output_buffer_show):
12334 * insdel.c (signal_before_change):
12335 * frame.c (Fhandle_switch_frame):
12336 * fileio.c (Fdo_auto_save):
12337 * emacs.c (Fkill_emacs):
12338 * editfns.c (save_excursion_restore):
12339 * cmds.c (internal_self_insert):
12340 * callint.c (Fcall_interactively):
12341 * buffer.c (Fkill_all_local_variables):
12342 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12343 Use Frun_hooks.
0f4a96b5 12344 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12345 unconditionally since it does the check itself.
dee091a3 12346
2c520ab5 123472011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12348
c9c49752
PE
12349 Fix more problems found by GCC 4.5.2's static checks.
12350
8abc3f12
PE
12351 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12352 the first time through the loop, since we know p0 < p1 then.
12353 This also avoids a gcc -Wstrict-overflow warning.
12354
a2d26660
PE
12355 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12356 leading to a memory leak, possible in functions like
12357 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12358 of objects (Bug#8318).
a2d26660 12359
916c72e9
PE
12360 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12361 that could (at least in theory) be that large.
12362
19ab8a18
PE
12363 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12364 This is less likely to overflow, and avoids undefined behavior if
12365 overflow does occur. All callers changed. Use strtoul to scan
12366 for the unsigned long integer.
b7cbbd6f
PE
12367 (pint2hrstr): Simplify and tune code slightly.
12368 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12369
f0641eff
PE
12370 * scroll.c (do_scrolling): Work around GCC bug 48228.
12371 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12372
7f650bb9
PE
12373 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12374 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12375 (validate_x_resource_name): Simplify count usage.
12376 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12377
37dd57d1
PE
12378 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12379 fail (Bug#8306).
81e56e61 12380
699979fc 12381 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12382
401bf9b4
PE
12383 * process.c (Fmake_network_process): Use socklen_t, not int,
12384 where POSIX says socklen_t is required in portable programs.
12385 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12386 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12387 (Fmake_network_process, server_accept_connection):
12388 (wait_reading_process_output, read_process_output):
12389 Likewise.
12390
b93aacde
PE
12391 * process.c: Rename or move locals to avoid shadowing.
12392 (list_processes_1, Fmake_network_process):
12393 (read_process_output_error_handler, exec_sentinel_error_handler):
12394 Rename or move locals.
4dc343ee 12395 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12396 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12397 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12398 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12399 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12400
af8a867c 12401 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12402 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12403 Include tparam.h instead, since it declares them.
af8a867c
PE
12404 * cm.h (PC): Remove extern decl; tparam.h now does this.
12405 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12406 * terminfo.c: Include tparam.h, to check interfaces.
12407 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12408 (tparam): Adjust signature to match interface in tparam.h;
12409 this removes some undefined behavior. Check that outstring and len
12410 are zero, which they always are with Emacs.
12411 * tparam.h (PC, BC, UP): New extern decls.
12412
0248044d 12413 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12414 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12415
8ff096c1 12416 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12417 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12418 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12419 (ftfont_list): Remove unused local.
49eaafba
PE
12420 (get_adstyle_property, ftfont_pattern_entity):
12421 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12422 Rename locals to avoid shadowing.
8ff096c1 12423
e2be39f6
PE
12424 * xfont.c (xfont_list_family): Mark var as initialized.
12425
c9735e30
PE
12426 * xml.c (make_dom): Now static.
12427
8f5201ae
PE
12428 * composite.c (composition_compute_stop_pos): Rename local to
12429 avoid shadowing.
b246f932
PE
12430 (composition_reseat_it): Remove unused locals.
12431 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12432 (composition_update_it): Mark var as initialized.
11b61122
PE
12433 (find_automatic_composition): Mark vars as initialized,
12434 with a FIXME (Bug#8290).
8f5201ae 12435
760fbc2c
PE
12436 character.h: Rename locals to avoid shadowing.
12437 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12438 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12439 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12440 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12441 to avoid shadowing.
12442
ff08eb85
PE
12443 * textprop.c (property_change_between_p): Remove; unused.
12444
fc7bf025
PE
12445 * intervals.c (interval_start_pos): Now static.
12446
235d7abc
PE
12447 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12448
44f230aa
SM
12449 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12450 Rename locals to avoid shadowing.
3e7d6594 12451
50060332
PE
12452 * sound.c (wav_play, au_play, Fplay_sound_internal):
12453 Fix pointer signedness.
d01f234b 12454 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12455 (wav_play): Initialize a variable to 0, to prevent undefined
12456 behavior (Bug#8278).
50060332 12457
c4fc4e30
PE
12458 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12459
918436ed
PE
12460 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12461
c939f91b
PE
12462 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12463 clobbering (Bug#8298).
b9c7f648
PE
12464 * sysdep.c (sys_subshell): Likewise.
12465 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12466
6bd8c144
PE
12467 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12468 This should get cleaned up, so that child_setup has the
12469 same signature on all platforms.
12470
7710357c 12471 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12472 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12473
c59da222
CY
124742011-03-22 Chong Yidong <cyd@stupidchicken.com>
12475
12476 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12477 not to be necessary, and produces flickering.
12478
66b87493
GM
124792011-03-20 Glenn Morris <rgm@gnu.org>
12480
12481 * config.in: Remove file.
12482
45b6f6d5
JB
124832011-03-20 Juanma Barranquero <lekktu@gmail.com>
12484
12485 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12486 are now in src/globals.h.
12487 (syms_of_minibuf): Remove spurious & from previous change.
12488
cd394be1 124892011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12490
12491 * minibuf.c (completing-read-function): New variable.
12492 (completing-read-default): Rename from completing-read.
12493 (completing-read): Call completing-read-function.
12494
b14e3e21
CY
124952011-03-19 Juanma Barranquero <lekktu@gmail.com>
12496
12497 * xfaces.c (Fx_load_color_file):
12498 Read color file from absolute filename (bug#8250).
12499
f2b726e6
JB
125002011-03-19 Juanma Barranquero <lekktu@gmail.com>
12501
12502 * makefile.w32-in: Update dependencies.
12503
09f6ff02
EZ
125042011-03-17 Eli Zaretskii <eliz@gnu.org>
12505
12506 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12507
29a6015a
PE
125082011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12509
a3a6c54e
PE
12510 Fix more problems found by GCC 4.5.2's static checks.
12511
b766f867
PE
12512 * process.c (make_serial_process_unwind, send_process_trap):
12513 (sigchld_handler): Now static.
12514
be02381c
PE
12515 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12516 That way, the code declares only the vars that it needs.
12517 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12518 * s/cygwin.h (PTY_ITERATION): Likewise.
12519 * s/darwin.h (PTY_ITERATION): Likewise.
12520 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12521
57048744
PE
12522 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12523 * process.c (allocate_pty): Don't declare stb unless it's needed.
12524
7914961c 12525 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12526 (CONSTANTLIM): Remove; unused.
12527 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12528 Define only if needed.
7914961c 12529
b3967b18
PE
12530 * unexelf.c (unexec): Name an expression,
12531 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12532 Use a different way to cause a compilation error if anyone uses
12533 n rather than nn, a way that does not involve shadowing.
73366a00 12534 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12535
29a6015a
PE
12536 * deps.mk (unexalpha.o): Remove; unused.
12537
43cfc33e 12538 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12539 * unexec.h: New file.
ce701a33
PE
12540 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12541 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12542 Depend on unexec.h.
12543 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12544 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12545 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12546 Change as necessary to match prototype in unexec.h.
ce701a33 12547
01f44d5a
PE
12548 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12549 shadowing.
4f63c6bb 12550 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12551
a6670b0b
PE
12552 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12553 Rename locals to avoid shadowing.
12554
cef2010d 12555 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12556 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12557
d4d7173a
PE
12558 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12559
f08b802a
PE
12560 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12561 warning when compiling print.c.
12562
3ddb0639
PE
12563 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12564 instead of using an uninitialized var.
5ad03b97 12565 (font_sort_entities): Mark var as initialized.
3ddb0639 12566
170a2692
PE
12567 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12568
e663c700
PE
12569 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12570 pointers to constants.
89bc529a 12571 (font_parse_fcname): Remove unused vars.
7b81e2d0 12572 (font_delete_unmatched): Now static.
ea838e10 12573 (font_get_spec): Remove; unused.
13a547c6
PE
12574 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12575 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12576 Rename or move locals to avoid shadowing.
e663c700 12577
2a80c887 12578 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12579 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12580
1384fa33 12581 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12582 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12583
8b2c52e9
PE
12584 * alloc.c (mark_backtrace): Move decl from here ...
12585 * lisp.h: ... to here, so that it can be checked.
12586
475545b5 12587 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12588 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12589 (lisp_indirect_variable): Name an expression,
12590 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12591 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12592
b1349114 12593 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12594 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12595 Use const pointer when appropriate.
b1349114 12596
a2928364
PE
12597 * lisp.h (get_system_name, get_operating_system_release):
12598 Move decls here, to check interfaces.
12599 * process.c (get_operating_system_release): Move decl to lisp.h.
12600 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12601 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12602 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12603 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12604 (Fformat_time_string, Fencode_time, Finsert_char):
12605 (Ftranslate_region_internal, Fformat):
12606 Rename or remove local vars to avoid shadowing.
9710023e 12607 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12608
a415e694
PE
12609 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12610 avoid shadowing.
12611
8ef4622d
PE
12612 * lisp.h (eassert): Check that the argument compiles, even if
12613 ENABLE_CHECKING is not defined.
12614
946f9a5b
PE
12615 * data.c (Findirect_variable): Name an expression, to avoid
12616 gcc -Wbad-function-cast warning.
112396d6 12617 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12618 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12619 (Fmake_variable_buffer_local, Fmake_local_variable):
12620 Mark variables as initialized.
52746918 12621 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12622
e5aab7e7 12623 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12624 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12625 Rename locals to avoid shadowing.
dff45157
PE
12626 (mark_stack): Move local variables into the #ifdef region where
12627 they're used.
7bc26fdb
PE
12628 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12629 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12630 needed otherwise.
12631 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12632 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12633 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12634
e5aab7e7
PE
12635 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12636 avoids undefined behavior in theory.
12637
4da60324
PE
12638 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12639
88043301
PE
12640 Use functions, not macros, for up- and down-casing (Bug#8254).
12641 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12642 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12643 to use the following functions instead of these macros.
12644 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12645 EMACS_INT, since callers assume the returned value fits in int.
12646 (upcase1): Likewise, for UPCASE_TABLE.
12647 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12648 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12649 the race-condition problem in the old DOWNCASE.
88043301 12650
19ed5445
PE
12651 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12652 Rename locals to avoid shadowing.
12653 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12654 (regex_compile, re_search_2, re_match_2_internal):
12655 Remove unused local vars.
952db0d7
PE
12656 (FREE_VAR): Rewrite so as not to use empty "else",
12657 which gcc can warn about.
da053e48 12658 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12659 (RETALLOC_IF): Define only if needed.
12660 (WORDCHAR_P): Likewise. This one is never needed, but is used
12661 only in a comment talking about a compiler bug, so put inside
12662 the #if 0 of that comment.
12663 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12664 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12665 Remove; unused.
19ed5445 12666
1f3561e4 12667 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12668 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12669 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12670
ded6f8f7
PE
12671 * search.c (simple_search): Remove unused var.
12672
dbd37a95
PE
12673 * dired.c (compile_pattern): Move decl from here ...
12674 * lisp.h: ... to here, so that it can be checked.
12675 (struct re_registers): New forward decl.
12676
7e47afad
PE
12677 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12678
85f24f61
PE
12679 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12680 All uses changed.
12681 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12682 Rename locals to avoid shadowing.
5671df8f 12683 (Fvertical_motion): Mark locals as initialized.
85f24f61 12684
181aa2be 12685 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12686 (casify_region): Mark local as initialized.
181aa2be 12687
930d429c
PE
12688 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12689
7082eac6
PE
12690 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12691 New macros, so that the caller can use some names other than
12692 gcpro1, gcpro2, etc.
12693 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12694 of the new macros.
12695 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12696 argument, for consistency with GCPRO2_VAR, etc: it is now the
12697 prefix of the variable, not the variable itself. All uses
12698 changed.
38b2c076
PE
12699 * dired.c (directory_files_internal, file_name_completion):
12700 Rename locals to avoid shadowing.
12701
15206ed9
PE
12702 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12703 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12704 dired.c's scmp function, had undefined behavior.
12705 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12706 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12707 * buffer.h: ... to here, because these macros use current_buffer,
12708 and the new implementation with inline functions needs to have
12709 current_buffer in scope now, rather than later when the macros
12710 are used.
12711 (downcase, upcase1): New static inline functions.
12712 (DOWNCASE, UPCASE1): Reimplement using these functions.
12713 This avoids undefined behavior in expressions like
12714 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12715 from race conditions in accessing the global variables
12716 case_temp1 and case_temp2.
12717 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12718 * lisp.h (case_temp1, case_temp2): Remove their decls.
12719 * character.h (ASCII_CHAR_P): Move from here ...
12720 * lisp.h: ... to here, so that the inline functions mentioned
12721 above can use them.
12722
4a6bea26
PE
12723 * dired.c (directory_files_internal_unwind): Now static.
12724
f14b7e14
PE
12725 * fileio.c (file_name_as_directory, directory_file_name):
12726 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12727 Now static.
2893f146
PE
12728 (file_name_as_directory): Use const pointers when appropriate.
12729 (Fexpand_file_name): Likewise. In particular, newdir might
12730 point at constant storage, so make it a const pointer.
fd4ead52 12731 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12732 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12733 signedness issues.
f839df0c
PE
12734 (Fset_file_times, Finsert_file_contents, auto_save_error):
12735 Rename locals to avoid shadowing.
f14b7e14 12736
5716756e 12737 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12738 (Ftry_completion, Fall_completions): Rename or remove locals
12739 to avoid shadowing.
5716756e 12740
b4c3046a
PE
12741 * marker.c (bytepos_to_charpos): Remove; unused.
12742
b45db522
PE
12743 * lisp.h (verify_bytepos, count_markers): New decls,
12744 so that gcc does not warn that these functions aren't declared.
12745
85876d07
PE
12746 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12747 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12748 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12749 (copy_text): Remove unused local var.
85876d07 12750
03d78a21 12751 * filelock.c (within_one_second): Now static.
b3dd38ab 12752 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12753
5df8f01b
PE
12754 * buffer.c (fix_overlays_before): Mark locals as initialized.
12755 (fix_start_end_in_overlays): Likewise. This function should be
12756 simplified by using pointers-to-pointers, but that's a different
12757 matter.
b1d876f1 12758 (switch_to_buffer_1): Now static.
8f54f30a
PE
12759 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12760 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12761
a70072c9 12762 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12763 Fix pointer signedness issue.
edced198
PE
12764 (sys_subshell): Mark local as volatile if checking for lint,
12765 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12766 (MAXPATHLEN): Define only if needed.
a70072c9 12767
a0977c44
PE
12768 * process.c (serial_open, serial_configure): Move decls from here ...
12769 * systty.h: ... to here, so that they can be checked.
12770
a884fdcc
PE
12771 * fns.c (get_random, seed_random): Move extern decls from here ...
12772 * lisp.h: ... to here, so that they can be checked.
12773
604efe86 12774 * sysdep.c (reset_io): Now static.
b8950c94 12775 (wait_for_termination_signal): Remove; unused.
604efe86 12776
38fc62d9
PE
12777 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12778 (copy_keymap_item, append_key, push_text_char_description):
12779 Now static.
1004a21a 12780 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12781 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12782 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12783 (describe_map_tree):
12784 Rename locals to avoid shadowing.
38fc62d9 12785
2f2650da
PE
12786 * keyboard.c: Declare functions static if they are not used elsewhere.
12787 (echo_char, echo_dash, cmd_error, top_level_2):
12788 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12789 (read_char, kbd_buffer_get_event, make_lispy_position):
12790 (make_lispy_event, make_lispy_movement, apply_modifiers):
12791 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12792 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12793 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12794 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12795 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12796
a053e86c 12797 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12798 (mark_kboards): Move decl here ...
12799 * alloc.c (mark_kboards): ... from here.
a053e86c 12800
4752793e
PE
12801 * lisp.h (force_auto_save_soon): New decl.
12802
74f10ca7 12803 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12804 (DEFINE_DUMMY_FUNCTION): New macro.
12805 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12806 Use it.
c03cd23f
PE
12807 (main): Add casts to avoid warnings
12808 if GCC considers string literals to be constants.
74f10ca7 12809
022e70d4
PE
12810 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12811
59d6fe83
PE
12812 * dbusbind.c: Pointer signedness fixes.
12813 (xd_signature, xd_append_arg, xd_initialize):
12814 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12815 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12816 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12817 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12818
78320123
PE
12819 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12820 if GCC considers string literals to be constants.
49cebcca 12821 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12822
35ac2a97
SM
128232011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12824
fb103ca9
SM
12825 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12826 (print_preprocess, print_object): New macro to fix last change.
12827
35ac2a97
SM
12828 * print.c (print_preprocess): Don't forget font objects.
12829
62973b41
JB
128302011-03-16 Juanma Barranquero <lekktu@gmail.com>
12831
12832 * emacs.c (USAGE3): Doc fixes.
12833
0e48bb22
AS
128342011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12835
12836 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12837 structure.
12838
7684e57b
JB
128392011-03-14 Juanma Barranquero <lekktu@gmail.com>
12840
12841 * lisp.h (VWindow_system, Qfile_name_history):
12842 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12843 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12844 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12845
12846 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12847 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12848
12849 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12850 * w32console.c (detect_input_pending, read_input_pending)
12851 (encode_terminal_code):
12852 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12853 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12854 (w32_system_caret_y, Qfile_name_history):
12855 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12856 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12857 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12858 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12859 * w32proc.c (Qlocal, report_file_error):
12860 * w32term.c (Vwindow_system, updating_frame):
12861 * w32uniscribe.c (initialized, uniscribe_font_driver):
12862 Remove unneeded extern declarations.
12863
2aa46d6c
CY
128642011-03-14 Chong Yidong <cyd@stupidchicken.com>
12865
c96bbc66 12866 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12867
cffc6f3b
CY
128682011-03-13 Chong Yidong <cyd@stupidchicken.com>
12869
12870 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12871 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12872 These macros can no longer be used for assignment.
12873
44f230aa
SM
12874 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12875 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12876 (record_buffer_markers, fetch_buffer_markers): New functions for
12877 recording and fetching special buffer markers.
12878 (set_buffer_internal_1, set_buffer_temp): Use them.
12879
12880 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12881
12882 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12883
12884 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12885 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12886
12887 * xdisp.c (hscroll_window_tree):
12888 (reconsider_clip_changes): Use PT instead of BUF_PT.
12889
d251f04b
EZ
128902011-03-13 Eli Zaretskii <eliz@gnu.org>
12891
12892 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12893 $(EMACS_ROOT)/lib/intprops.h.
12894
f0c77cd1
PE
128952011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12896
3eca4629
PE
12897 Fix more problems found by GCC 4.5.2's static checks.
12898
7c86ee98
PE
12899 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12900 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12901 (xg_free_frame_widgets): Make it clear that a local variable is
12902 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12903 (gdk_window_get_screen): Make it clear that this macro is needed
12904 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12905 (int_gtk_range_get_value): New function, which avoids a diagnostic
12906 from gcc -Wbad-function-cast.
12907 (xg_set_toolkit_scroll_bar_thumb): Use it.
12908 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12909 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12910 (get_utf8_string, xg_get_file_with_chooser):
12911 Rename locals to avoid shadowing.
12912 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12913
41729b81
PE
12914 * xgselect.c (xg_select): Remove unused var.
12915
f0c77cd1
PE
12916 * image.c (four_corners_best): Mark locals as initialized.
12917 (gif_load): Initialize transparent_p to zero (Bug#8238).
12918 Mark another local as initialized.
ec6cf4c6 12919 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12920
ce0ad53d 12921 * image.c (clear_image_cache): Now static.
d5d5a617 12922 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12923 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12924 (x_edge_detection): Remove unnecessary cast that
12925 gcc -Wbad-function-cast diagnoses.
2037898d 12926 (gif_load): Fix pointer signedness.
6ae141d6
PE
12927 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12928 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12929
33383987 129302011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12931
d32df629
PE
12932 Improve quality of tests for time stamp overflow.
12933 For example, without this patch (encode-time 0 0 0 1 1
12934 1152921504606846976) returns the obviously-bogus value (-948597
12935 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12936 reports time overflow. See
12937 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12938 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12939 * editfns.c: Include limits.h and intprops.h.
12940 (TIME_T_MIN, TIME_T_MAX): New macros.
12941 (time_overflow): Move earlier, to before first use.
12942 (hi_time, lo_time): New functions, for an accurate test for
12943 out-of-range times.
12944 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12945 (Fget_internal_run_time): Don't assume time_t fits in int.
12946 (make_time): Use list2 instead of Fcons twice.
12947 (Fdecode_time): More accurate test for out-of-range times.
12948 (check_tm_member): New function.
12949 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12950 (lisp_time_argument): Don't rely on undefined left-shift and
12951 right-shift behavior when checking for time stamp overflow.
8be6f318 12952
fe31d94c
PE
12953 * editfns.c (time_overflow): New function, refactoring common code.
12954 (Fformat_time_string, Fdecode_time, Fencode_time):
12955 (Fcurrent_time_string): Use it.
12956
8be6f318
PE
12957 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12958 * dired.c (make_time): Move to ...
12959 * editfns.c (make_time): ... here.
12960 * systime.h: Note the move.
12961
09d9db2c 129622011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12963
126bc0dc
YM
12964 * fringe.c (update_window_fringes): Remove unused variables.
12965
c47cbdfd
YM
12966 * unexmacosx.c (copy_data_segment): Also copy __got section.
12967 (Bug#8223)
12968
7ac80be9
EZ
129692011-03-12 Eli Zaretskii <eliz@gnu.org>
12970
c96bbc66 12971 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12972 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12973 Constify `char *' arguments and their references according to
12974 prototypes in tparam.h.
12975
ecb0f94d 12976 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12977
7ac80be9
EZ
12978 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12979 Adapt all references accordingly.
12980
12981 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12982
ef1fd07e
TT
129832011-03-11 Tom Tromey <tromey@redhat.com>
12984
12985 * buffer.c (syms_of_buffer): Remove obsolete comment.
12986
7ef4b50c
EZ
129872011-03-11 Eli Zaretskii <eliz@gnu.org>
12988
12989 * termhooks.h (encode_terminal_code): Declare prototype.
12990
12991 * msdos.c (encode_terminal_code): Don't declare prototype.
12992
12993 * term.c (encode_terminal_code): Now external again, used by
12994 w32console.c and msdos.c.
12995
44f230aa
SM
12996 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12997 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12998
4b1ec863 129992011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13000
1714f52b 13001 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13002
4b1ec863
PE
13003 * fringe.c (update_window_fringes): Mark locals as initialized
13004 (Bug#8227).
13005 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13006
524c7aa6
PE
13007 * alloc.c (mark_fringe_data): Move decl from here ...
13008 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13009 to check its interface.
13010 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13011
a5c0af81 13012 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13013 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13014 (fontset_font): Mark local as initialized.
a9a06e0b 13015 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13016
b4716021
PE
13017 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13018
811e9bac 13019 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13020 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13021 (x_own_selection, Fx_disown_selection_internal): Rename locals
13022 to avoid shadowing.
13023 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13024
7e3ab302
PE
13025 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13026 so that the caller can use some name other than gcpro1.
13027 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13028 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13029 (Fx_backspace_delete_keys_p):
13030 Use them to avoid shadowing, and rename vars to avoid shadowing.
13031 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13032 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13033 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13034 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13035 Remove unused locals.
7e3ab302
PE
13036 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13037 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13038 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13039 macros.
f78faa98 13040
e2b13473
PE
13041 * xterm.h (x_mouse_leave): New decl.
13042
77f23912
PE
13043 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13044 Remove unused functions.
cdf4ba58
PE
13045 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13046 (x_calc_absolute_position): Now static.
7411c686 13047 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13048 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13049 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13050 unless they are used.
38d0b34a
PE
13051 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13052 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13053 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13054 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13055 (x_error_catcher, x_connection_closed, x_error_handler):
13056 (x_error_quitter, xembed_send_message, x_iconify_frame):
13057 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13058 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13059 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13060
44f230aa
SM
13061 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13062 Rename or move locals to avoid shadowing.
6b463e58 13063 (tty_defined_color, merge_face_heights): Now static.
5967d051 13064 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13065 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13066 does not deduce is never used uninitialized.
73719eba
PE
13067 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13068 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13069
426994c3 13070 * terminal.c (store_terminal_param): Now static.
5489860b 13071
032f1620 13072 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13073 (set_frame_menubar): Remove unused local.
d4323972 13074 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13075 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13076 since they might point to immutable storage.
281585b0
PE
13077 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13078 since it's unused otherwise.
032f1620 13079
367c19e5 13080 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13081 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13082 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13083 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13084 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13085 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13086 does not deduce are never used uninitialized.
70739cbe 13087
07b48fa9
PE
13088 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13089
8868a238 13090 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13091 * window.c (window_loop, size_window):
13092 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13093
7e5cf297 13094 * window.c (display_buffer): Now static.
d6550a9f
PE
13095 (size_window): Mark variables that gcc -Wuninitialized
13096 does not deduce are never used uninitialized.
a586633d
PE
13097 * window.h (check_all_windows): New decl, to forestall
13098 gcc -Wmissing-prototypes diagnostic.
5b555da1 13099 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13100
f6095868
PE
13101 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13102 shadowing.
13103 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13104 Include <limits.h>.
13105 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13106 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13107 (load_charset_map): Mark variables that gcc -Wuninitialized
13108 does not deduce are never used uninitialized.
53df7c11 13109 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13110
f38b440c
PE
13111 * coding.c (coding_set_source, coding_set_destination):
13112 Use "else { /* comment */ }" rather than "else /* comment */;"
13113 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13114 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13115 a block, when the outer 'i' will do.
13116 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13117 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13118 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13119 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13120 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13121 Rename locals to avoid shadowing.
13122 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13123 * coding.c (emacs_mule_char, encode_invocation_designation):
13124 Now static, since they're not used elsewhere.
413bb2db 13125 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13126 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13127 (decode_coding_emacs_mule): Mark variables that gcc
13128 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13129 (detect_coding_iso_2022): Initialize a local variable that might
13130 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13131 this initialization is needed. (Bug#8211)
5f58e762
PE
13132 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13133 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13134 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13135 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13136 Remove unused macros.
f38b440c 13137
232b38b9 13138 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13139 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13140 * character.c (string_count_byte8): Likewise.
232b38b9 13141
fb90da1b
PE
13142 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13143 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13144
fb93dbc2
PE
13145 * chartab.c (copy_sub_char_table): Now static, since it's not used
13146 elsewhere.
5c156ace
PE
13147 (sub_char_table_ref_and_range, char_table_ref_and_range):
13148 Rename locals to avoid shadowing.
bbcd0949 13149 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13150
7d3b3862 13151 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13152 (BIDI_BOB): Remove unused macro.
7d3b3862 13153
6be7d3da
PE
13154 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13155 deduce are never used uninitialized.
c2ed9c8b 13156 * term.c (encode_terminal_code): Likewise.
6be7d3da 13157
75f8807f 13158 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13159
50938595
PE
13160 * tparam.h: New file.
13161 * term.c, tparam.h: Include it.
13162 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13163 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13164 Move these decls to tparam.h, and make them agree with what
13165 is actually in tparam.c. The previous trick of using incompatible
13166 decls in different modules does not conform to the C standard.
13167 All callers of tparam changed to use tparam's actual API.
13168 * tparam.c (tparam1, tparam, tgoto):
13169 Use const pointers where appropriate.
13170
fbceeba2
PE
13171 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13172 * cm.h (struct cm): Likewise.
13173 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13174 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13175 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13176 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13177 (turn_on_face, init_tty): Likewise.
13178 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13179
7f3f1250
PE
13180 * term.c (term_mouse_position): Rename local to avoid shadowing.
13181
e6ca6543
PE
13182 * alloc.c (mark_ttys): Move decl from here ...
13183 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13184
c40f8d15
AS
131852011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13186
13187 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13188
cfe0661d
JB
131892011-03-09 Juanma Barranquero <lekktu@gmail.com>
13190
13191 * search.c (compile_pattern_1): Remove argument regp, unused since
13192 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13193 (compile_pattern): Don't pass it.
13194
0afb4571
J
131952011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13196
13197 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13198 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13199 for ! HAVE_GTK3.
13200 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13201
13202 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13203
13204 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13205 gdk_window_get_screen, gdk_window_get_geometry,
13206 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13207 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13208 (xg_get_pixbuf_from_pixmap): New function.
13209 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13210 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13211 Call xg_get_pixbuf_from_pixmap instead of
13212 gdk_pixbuf_get_from_drawable.
13213 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13214 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13215 (xg_check_special_colors): Use GtkStyleContext and its functions
13216 for HAVE_GTK3.
13217 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13218 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13219 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13220 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13221 Call gtk_widget_get_preferred_size.
0afb4571
J
13222 (xg_frame_resized): gdk_window_get_geometry only takes 5
13223 parameters.
44f230aa
SM
13224 (xg_win_to_widget, xg_event_is_for_menubar):
13225 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13226 (xg_set_widget_bg): New function.
13227 (delete_cb): New function.
895009e1 13228 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13229 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13230 (xg_set_background_color): Call xg_set_widget_bg.
13231 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13232 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13233 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13234 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13235 if ! HAVE_GTK3.
13236 (update_frame_tool_bar): Call gtk_widget_hide.
13237 (xg_initialize): Use GDK_KEY_g.
13238
13239 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13240 if ! HAVE_GTK3
13241 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13242
13243 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13244 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13245 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13246
1c2cc4ef
JB
132472011-03-08 Juanma Barranquero <lekktu@gmail.com>
13248
13249 * w32xfns.c (select_palette): Check success of RealizePalette against
13250 GDI_ERROR, not zero.
13251
33383987 13252See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13253
13254;; Local Variables:
13255;; coding: utf-8
aac0c6e3
MR
13256;; End:
13257
2f097256 13258 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13259
13260 This file is part of GNU Emacs.
13261
13262 GNU Emacs is free software: you can redistribute it and/or modify
13263 it under the terms of the GNU General Public License as published by
13264 the Free Software Foundation, either version 3 of the License, or
13265 (at your option) any later version.
13266
13267 GNU Emacs is distributed in the hope that it will be useful,
13268 but WITHOUT ANY WARRANTY; without even the implied warranty of
13269 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13270 GNU General Public License for more details.
13271
13272 You should have received a copy of the GNU General Public License
13273 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.