* configure.ac (opsysfile): Tweak message for null case.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d34d6ffc
GM
12012-07-30 Glenn Morris <rgm@gnu.org>
2
3 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
4 Remove empty files.
5
03a660a6
PE
62012-07-30 Paul Eggert <eggert@cs.ucla.edu>
7
8 Export to GDB most of lisp.h's remaining object-like macros.
9 * lisp.h (min, max): Move earlier, because they're used earlier now.
10 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
11 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
12 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
13 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
14 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
15 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
16 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
17 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
18 Now constants, for GDB. They need not be macros.
19 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
20 Now constants, for GDB, as well as macros, for static initializers.
21 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
22 Move to after the definition of struct Lisp_Char_Table,
23 since the former now needs that type defined.
24 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
25 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
26 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
27 New enums, for gdb_make_enums_visible.
28 (GLYPH_MODE_LINE_FACE): Remove; unused.
29 * alloc.c (STRING_BYTES_MAX): Now a constant, now a macro.
30 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
31 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
32 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
33 enum maxargs, enum MAX_ALLOCA.
34 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
35 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
36 no longer needed, now that they are done in lisp.h.
37
e499d0ee
DA
382012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
39
40 Cleanup string bytes checking.
41 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
42 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
43 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
44 (check_sblock, compact_small_strings): Simplify.
45
d5040d2d
PE
462012-07-29 Paul Eggert <eggert@cs.ucla.edu>
47
48 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
49 These macros are confusing and no longer need to be defined, as
50 the enum values now suffice. All uses replaced with definiens.
51 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
52
7f259ae6
JB
532012-07-29 Juanma Barranquero <lekktu@gmail.com>
54
55 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
56 ($(BLD)/w32console.$(O)): Update dependencies.
57
7e63e0c3
DA
582012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
59
60 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
61 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
62 time. Adjust users.
63 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
64
ffd817eb
JD
652012-07-29 Jan Djärv <jan.h.d@swipnet.se>
66
67 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
68 setting sitelisp (Bug#12010).
69
417a7a0e
EZ
702012-07-29 Eli Zaretskii <eliz@gnu.org>
71
72 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
73
74 * w32heap.c (cache_system_info):
75 * w32.c (sys_rename):
76 * w32proc.c (find_child_console, sys_kill): All users changed.
77
387d4d92
PE
782012-07-29 Paul Eggert <eggert@cs.ucla.edu>
79
80 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
81
55a6cca6
EZ
822012-07-29 Eli Zaretskii <eliz@gnu.org>
83
84 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
85
dbcf001c
DA
862012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
87
88 Cleanup statistics calculation in Fgarbage_collect.
89 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
90 zombies percentage calculation. Simplify elapsed time calculation.
91
e2688e4a
DA
922012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
93
94 Generalize marker debugging code under MARKER_DEBUG and use eassert.
95 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
96 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
97 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
98 (replace_range, replace_range_2, del_range_2): Change to eassert.
99 * marker.c (byte_char_debug_check): Adjust style.
100
b46a6a83
PE
1012012-07-29 Paul Eggert <eggert@cs.ucla.edu>
102
103 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
104 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
105 long-ago-commented-out code that talks about "WIN32".
106 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
107 All uses changed.
108
e32a5799
PE
1092012-07-28 Paul Eggert <eggert@cs.ucla.edu>
110
111 Use Gnulib stdalign module (Bug#9772, Bug#9960).
112 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
113 Simplify by using alignof.
114 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
115 * lisp.h: Include <stdalign.h>.
116 (GCALIGNMENT): New macro and constant.
117 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
118 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
119 (stdalign): New macro, if not already defined.
120
df81cd29
EZ
1212012-07-28 Eli Zaretskii <eliz@gnu.org>
122
01bd1b0d
EZ
123 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
124 * w32inevt.c: Include w32inevt.h.
125 (w32_read_console_input): New inline function, calls either
126 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
127 w32_console_unicode_input.
128 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
129 (w32_kbd_patch_key, key_event): Use the codepage returned by
130 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
131 (key_event): use uChar.UnicodeChar only if
132 w32_console_unicode_input is non-zero.
133
134 * w32console.c: Include w32heap.h.
135 <w32_console_unicode_input>: New global variable.
136 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
137 family of Windows, zero otherwise.
138
139 * w32inevt.h: Declare w32_console_unicode_input.
140
df81cd29
EZ
141 * xdisp.c (init_iterator): Don't reference tip_frame in a build
142 --without-x. (Bug#11742)
143
c20fdd9e
PE
1442012-07-27 Paul Eggert <eggert@cs.ucla.edu>
145
146 Adjust GDB to reflect pvec_type changes (Bug#12036).
147 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
148 2012-07-04 changes to pseudovector representation. Problem
149 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
150
32770973 1512012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
152
153 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
154 bus address.
155 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
156
3438fe21
EZ
1572012-07-27 Eli Zaretskii <eliz@gnu.org>
158
bcfbc9de
EZ
159 * alloc.c (listn): Fix the order the arguments are consed onto the
160 list.
161
3438fe21
EZ
162 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
163 enumeration constants, as PURE and HEAP are too general, and clash
164 with other headers and sources, such as gmalloc.c and the
165 MS-Windows system headers. All users changed.
166
eeaea515
DA
1672012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
168
169 Revert last save_excursion_save and save_excursion_restore changes.
170 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
171 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
172
073c88c2
DA
1732012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
174
175 Fix recently-introduced typos in Windows port.
176 Reported by Martin Rudalics <rudalics@gmx.at>.
177 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 178 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 179
4706125e
PE
1802012-07-27 Paul Eggert <eggert@cs.ucla.edu>
181
182 Improve GDB symbol export (Bug#12036).
183 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
184 arms of an 'if', not using conditional expressions; otherwise GDB
185 complains about the types in the unevaluated arm when the argument
186 is an integer literal.
187 (xgetint): Simplify expression.
188 * alloc.c (gdb_make_enums_visible): New constant. This ports to
189 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
190 Zaretskii in <http://bugs.gnu.org/12036#13>.
191 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
192 needed now that we have gdb_make_enums_visible.
193 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
194 (enum enum_USE_LSB_TAG):
195 New enum types, packaging up enums that need to be exported to GDB.
196
694b6c97
DA
1972012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
198
199 Utility function to make a list from specified amount of objects.
200 * lisp.h (enum constype): New datatype.
201 (listn): New prototype.
202 * alloc.c (listn): New function.
203 (Fmemory_use_count, syms_of_alloc): Use it.
204 * buffer.c (syms_of_buffer): Likewise.
205 * callint.c (syms_of_callint): Likewise.
206 * charset.c (define_charset_internal): Likewise.
207 * coding.c (syms_of_coding): Likewise.
208 * keymap.c (syms_of_keymap): Likewise.
209 * search.c (syms_of_search): Likewise.
210 * syntax.c (syms_of_syntax): Likewise.
211 * w32.c (init_environment): Likewise.
212 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
213 * xdisp.c (syms_of_xdisp): Likewise.
214 * xfns.c (syms_of_xfns): Likewise.
215
6195f384
DA
2162012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
217
218 Fast save_excursion_save and save_excursion_restore.
219 * lisp.h (struct Lisp_Excursion): New data type.
220 (PVEC_EXCURSION): New pseudovector type.
221 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
222 to deal with it. Adjust comments.
223 (init_marker, attach_marker): New prototype.
224 (unchain_marker): Adjust prototype.
225 * marker.c (attach_marker): Change to global.
226 (init_marker): New function.
227 * alloc.c (Fmake_marker, build_marker): Use it.
228 (build_marker): More easserts.
229 (mark_object): Handle struct Lisp_Excursion.
230 * editfns.c (save_excursion_save, save_excursion_restore):
231 Reimplement to use struct Lisp_Excursion. Add comments.
232
5eceb8fb
PE
2332012-07-26 Paul Eggert <eggert@cs.ucla.edu>
234
235 Fix export of symbols to GDB (Bug#12036).
236 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
237 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
238 emacs.c, as this is a more-suitable home. Had this been done earlier
239 the fix for 12036 would have avoided some of the problems noted in
240 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
241 would have been more obvious.
562157c8
PE
242 * emacs.c: Do not include <verify.h>; no longer needed.
243 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
244 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
245 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
246 Remove; now done in lisp.h.
247 * lisp.h (PUBLISH_TO_GDB): New macro.
248 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
249 (DATA_SEG_BITS): Use it.
250 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
251 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
252 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
253 not be usable in #if. This simplifies things.
254
d6749401
JB
2552012-07-26 Juanma Barranquero <lekktu@gmail.com>
256
257 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
258
1781b9e9
PE
2592012-07-26 Paul Eggert <eggert@cs.ucla.edu>
260
d89518db 261 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
262 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
263 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
264 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
265 Adjust to changes in lisp.h and emacs.c, by using
266 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
267 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
268 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
269 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
270 instead of gdb_valbits.
271 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
272 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
273 instead of gdb_array_mark_flag.
274 (xboolvector): Get size from $->size, not $->header.size.
275 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
276 (xreload, hook-run, hookpost-run): Remove.
277 * emacs.c: Include <verify.h>.
278 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
279 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
280 Remove.
281 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
282 (gdb_USE_LSB_TAG): New enum constants.
283 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
284 Also define these as enum constants, so they're visible to GDB.
285 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
286 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
287 as constants, so they're visible to GDB.
288 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
289 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
290 Now enum constants, not macros, so they're visible to GDB.
291 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
292 more convenient now. All uses changed.
293 (VALMASK) [USE_LSB_TAG]: Also define in this case.
294 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
295
3628596a
DA
2962012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
297
298 Explicitly free restriction data that are not needed anymore.
299 * editfns.c (save_restriction_restore): Free restriction data.
300
7abaf5cc
SM
3012012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
302
303 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
304 add argument, tune behavior, and adjust all callers.
305
71f88e00
PE
3062012-07-25 Paul Eggert <eggert@cs.ucla.edu>
307
308 Use typedef for EMACS_INT, EMACS_UINT.
309 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
310 than macros. This simplifies debugging in the usual case, since
311 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
312 and it allows expressions involving EMACS_INT casts.
313 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
314
57ec3034
JD
3152012-07-25 Jan Djärv <jan.h.d@swipnet.se>
316
317 * nsterm.m (ns_read_socket): Return early if there is a modal
318 window (Bug#12043).
319
8137e7b3
MR
3202012-07-25 Martin Rudalics <rudalics@gmx.at>
321
322 * frame.c (Fredirect_frame_focus): In doc-string don't mention
323 that FOCUS-FRAME can be omitted.
324
04e9897c
DA
3252012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
326
327 Adjust buffer text indirection counters at the end of Fkill_buffer.
328 * buffer.c (Fkill_buffer): Adjust indirection counters when the
329 buffer is definitely dead. This should really fix an issue reported
330 by Christoph Scholtes again. (Bug#12007).
331 (init_buffer_once): Initialize indirection counters of
332 buffer_defaults and buffer_local_symbols (for sanity and safety).
333
8a0484e1
EZ
3342012-07-24 Eli Zaretskii <eliz@gnu.org>
335
336 * xdisp.c (init_iterator): Don't compute dimensions of truncation
337 and continuation glyphs on tooltip frames, leave them at zero.
338 Avoids continued lines in tooltips. (Bug#11832)
339
fa691a83
DA
3402012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
341
342 Simplify copy_overlay.
04e9897c 343 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
344 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
345
436bc8e0
EZ
3462012-07-23 Eli Zaretskii <eliz@gnu.org>
347
348 * print.c (print_object): Don't crash when a frame's name is nil
349 or invalid. (Bug#12025)
350
351 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
352 it signals an error when a tooltip frame is being created.
353
d7a7fda3
DA
3542012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
355
356 Cleanup miscellaneous objects allocation and initialization.
357 * alloc.c (allocate_misc): Change to static. Add argument to
358 specify the subtype. Adjust comment and users.
359 (build_overlay): New function.
360 * buffer.c (copy_overlays, Fmake_overlay): Use it.
361 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
362 (allocate_misc): Remove prototype.
363 (build_overlay): Add prototype.
364
3652012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
366
367 Swap buffer text indirection counters in Fbuffer_swap_text.
368 * buffer.c (Fbuffer_swap_text): Swap indirections too.
369 This avoids crash reported by Christoph Scholtes at
370 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
371
9d7fa573
JD
3722012-07-22 Jan Djärv <jan.h.d@swipnet.se>
373
374 * nsmenu.m (Popdown_data): New struct.
375 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
376 free Popdown_data.
377 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
378 (initWithContentRect): Make imgView and contentView non-static
379 and autorelease them. Also autorelease img and matrix (Bug#12005).
380 (dealloc): Remove (Bug#12005).
381
0dd6d66d
DA
3822012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
383
384 Adjust consing_since_gc when objects are explicitly freed.
385 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
386 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
387 (free_cons, free_misc): Subtract object size from consing_since_gc.
388
d36d71df
DA
3892012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
390
391 Simplify and cleanup markers positioning code.
392 * marker.c (attach_marker): More useful eassert.
393 (live_buffer, set_marker_internal): New function.
394 (Fset_marker, set_marker_restricted): Use set_marker_internal.
395 (set_marker_both, set_marker_restricted_both): Use live_buffer.
396
fb9ea40f
PE
3972012-07-22 Paul Eggert <eggert@cs.ucla.edu>
398
399 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
400 as it's limited by the amount of memory, not by INT_MAX.
401
2d5c5f7d
EZ
4022012-07-21 Eli Zaretskii <eliz@gnu.org>
403
07fb592e
EZ
404 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
405 in special-event-map. See the discussion at
406 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
407 for the reasons.
408
37a9eac8 409 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
410 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
411 Fabrice Popineau <fabrice.popineau@supelec.fr>.
412
c4328746
JD
4132012-07-21 Jan Djärv <jan.h.d@swipnet.se>
414
415 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 416 (conversationIdentifier): Return value is NSInteger.
784051c4 417 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 418
6e5d1c12
CY
4192012-07-21 Chong Yidong <cyd@gnu.org>
420
421 * window.c (decode_any_window): Signal an error if the window is
422 on a dead frame (Bug#11984).
423
9928463d
DA
4242012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
425
426 Add indirection counting to speed up Fkill_buffer.
427 * buffer.h (struct buffer): New member.
428 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
429 (Fmake_indirect_buffer): Set indirection counter to -1, increment
430 base buffer indirection counter.
431 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
432 (Fkill_buffer): Adjust indirection counters as needed, don't walk
433 through buffer list if indirection counter is 0.
434
f8643a6b
DA
4352012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
436
437 Extend the value returned by Fgarbage_collect with heap statistics.
438 * alloc.c (Qheap): New symbol.
439 (syms_of_alloc): DEFSYM it.
440 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
441 (Fmemory_free): Remove.
442 (syms_of_alloc): Don't defsubr it.
443 * buffer.c (Fcompact_buffer): Remove.
444 (syms_of_buffer): Don't defsubr it.
445
dac616ff
DA
4462012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
447
448 Make maybe_gc inline.
449 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
450 * lisp.h (consing_since_gc, gc_relative_threshold)
451 (memory_full_cons_threshold): Revert declaration.
452 (maybe_gc): Remove prototype, define as inline.
453 * alloc.c: Remove old commented-out code.
454 (consing_since_gc, gc_relative_threshold)
455 (memory_full_cons_threshold): Revert to global.
456 (maybe_gc): Remove.
457
d7ea76b4
DA
4582012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
459
460 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
461 * lisp.h (build_unibyte_string): New function.
462 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
463 * sysdep.c, w32fns.c, xfns.c: Use it.
464 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
465 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
466 Adjust users accordingly.
467 * font.h (font_open_by_name): Adjust prototype.
468
765e61e3
DA
4692012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
470
471 Cleanup calls to Fgarbage_collect.
472 * lisp.h (maybe_gc): New prototype.
473 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
474 Remove declarations.
475 * alloc.c (maybe_gc): New function.
476 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
477 Make them static.
478 * bytecode.c (MAYBE_GC): Use maybe_gc.
479 * eval.c (eval_sub, Ffuncall): Likewise.
480 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
481 to avoid dependency from auto-save feature.
482
52b852c7
PE
4832012-07-19 Paul Eggert <eggert@cs.ucla.edu>
484
485 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
486 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
487 'for_each_per_buffer_object_at'.
488 All uses changed. It's better to use upper-case for macros that
489 cannot be implemented as functions, to give the reader a clue
490 that they're special.
491
5db81e33
SM
4922012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
493
494 * alloc.c (Fgarbage_collect): Tweak docstring.
495
5b835e1d
DA
4962012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
497
498 Tweak the value returned from Fgarbage_collect again.
499 * alloc.c (Fgarbage_collect): New return value, as confirmed in
500 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
501 Adjust documentation.
502 (total_vector_bytes): Rename to total_vector_slots, adjust
503 accounting.
504 (total_free_vector_bytes): Rename to total_free_vector_slots,
505 adjust accounting.
506 (Qstring_bytes, Qvector_slots): New symbols.
507 (syms_of_alloc): DEFSYM them.
508
9cd47b72
DA
5092012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
510
511 Buffer compaction primitive which may be used from Lisp.
512 * buffer.c (compact_buffer, Fcompact_buffer): New function.
513 (syms_of_buffer): Register Fcompact_buffer.
514 * alloc.c (Fgarbage_collect): Use compact_buffer.
515 * buffer.h (compact_buffer): New prototype.
516 (struct buffer_text): New member.
517
d17337e5
DA
5182012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
519
520 New macro to iterate over all buffers, miscellaneous cleanups.
521 * lisp.h (all_buffers): Remove declaration.
522 * buffer.h (all_buffers): Add declaration, with comment.
523 (for_each_buffer): New macro.
524 * alloc.c (Fgarbage_collect, mark_object): Use it.
525 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
526 (init_buffer): Likewise.
527 * data.c (Fset_default): Likewise.
528 * coding.c (code_conversion_restore): Remove redundant check
529 for dead buffer.
530 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
531
60cfd278
AS
5322012-07-18 Andreas Schwab <schwab@linux-m68k.org>
533
534 Fix bug that created negative-length intervals.
535 * intervals.c (merge_interval_right, merge_interval_left):
536 Do not zero out this interval if it is absorbed by its children,
537 as this interval's total length doesn't change in that case. See
538 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
539
d06714cb
PE
5402012-07-18 Paul Eggert <eggert@cs.ucla.edu>
541
83713154
PE
542 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
543 when invoking (make-bool-vector N t) and N is a positive
544 multiple of 8 -- the last 8 bits were mistakenly cleared.
545
d06714cb
PE
546 Remove some struct layout assumptions in bool vectors.
547 * alloc.c (bool_header_size): New constant.
548 (header_size, word_size): Move earlier, as they're now used earlier.
549 Use 'word_size' in a few more places, where it's appropriate.
550 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
551 padding before the data member of a bool vector.
552 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
553 than doing the check by hand with an abort ().
554
464d5a5e
SM
5552012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
556
5fbc0409
SM
557 * eval.c (Fdefvar): Don't check constants since we only set the var if
558 it's not yet defined anyway (bug#11904).
559
464d5a5e
SM
560 * lisp.h (last_undo_boundary): Declare new var.
561 * keyboard.c (command_loop_1): Set it.
562 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
563 were auto-added by the command loop (bug#11774).
564
8dc2e44a
AS
5652012-07-18 Andreas Schwab <schwab@linux-m68k.org>
566
567 * w32font.c (Qsymbol): Remove local definition.
568 (syms_of_w32font): Don't DEFSYM it.
569
169925ec
DA
5702012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
571
572 Fix sweep_vectors to handle large bool vectors correctly.
573 * alloc.c (sweep_vectors): Account total_vector_bytes for
574 bool vectors larger than VBLOCK_BYTES_MAX.
575
5fbfb018
CY
5762012-07-18 Chong Yidong <cyd@gnu.org>
577
578 * frame.c (x_set_frame_parameters): Revert bogus change introduced
579 in 2012-05-25 commit by Paul Eggert (Bug#11738).
580
3ab6e069
DA
5812012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
582
583 Return more descriptive data from Fgarbage_collect.
584 Suggested by Stefan Monnier in
585 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
586 * alloc.c (bounded_number): New function.
587 (total_buffers, total_vectors): New variable.
588 (total_string_size): Rename to total_string_bytes, adjust users.
589 (total_vector_size): Rename to total_vector_bytes, adjust users.
590 (sweep_vectors): Account total_vectors and total_vector_bytes.
591 (Fgarbage_collect): New return value. Adjust documentation.
592 (gc_sweep): Account total_buffers.
593 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
594 (VECTOR_SIZE): Remove.
595 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
596 (Qinterval, Qmisc): New symbols.
597 (syms_of_data): Initialize them.
598 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
599 (Qcons, Qbuffer): New declarations.
600
6d02fe5b
PE
6012012-07-17 Paul Eggert <eggert@cs.ucla.edu>
602
603 * alloc.c (Fmemory_free): Account for memory-free's own storage.
604 Round up, not down. Improve doc.
605
b7ffe040
DA
6062012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
607
608 Restore old code in allocate_string_data to avoid Faset breakage.
609 Reported by Julien Danjou <julien@danjou.info> in
610 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
611 * alloc.c (allocate_string_data): Restore old code with minor
612 adjustments, fix comment to explain this subtle issue.
613
4dc7c8d5
SM
6142012-07-17 Eli Zaretskii <eliz@gnu.org>
615
616 Remove FILE_SYSTEM_CASE.
617 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
618
619 * fileio.c (FILE_SYSTEM_CASE): Don't define.
620 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
621 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
622 call-process-region passes it through expand-file-name.
623
624 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
625
6262012-07-17 Andreas Schwab <schwab@linux-m68k.org>
627
628 Fix crash when creating indirect buffer (Bug#11917)
629 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
630 Don't handle unbound variables specially if non-zero.
631 (Fbuffer_local_variables): Pass zero.
632 (clone_per_buffer_values): Pass non-zero.
633
6342012-07-17 Andreas Schwab <schwab@linux-m68k.org>
635
636 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
637 to make the loop interruptible.
638
6392012-07-17 Andreas Schwab <schwab@linux-m68k.org>
640
641 * gnutls.c (emacs_gnutls_handshake): Only retry if
642 GNUTLS_E_INTERRUPTED.
643
cce7fefc
DA
6442012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
645
646 Cleanup and convert miscellaneous checks to eassert.
647 * alloc.c (mark_interval): Fix comment, partially rephrase
648 old comment from intervals.h (see below).
649 * intervals.c (find_interval, adjust_intervals_for_insertion)
650 (delete_interval, adjust_intervals_for_deletion)
651 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
652 Convert to eassert.
653 (adjust_intervals_for_insertion, make_new_interval):
654 Remove obsolete and unused code.
655 * intervals.h (struct interval): Remove obsolete comment.
656 * textprotp.c (erase_properties): Remove unused code.
657 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
658 (Fremove_list_of_text_properties): Convert to eassert.
659
9ea10cc3
CY
6602012-07-17 Chong Yidong <cyd@gnu.org>
661
662 * editfns.c (Finsert_char): Doc fix.
663
3900d5de
DA
6642012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
665
666 Fix previous change to make Fmemory_free always accurate.
667 * alloc.c (make_interval): Update total_free_intervals.
668 (make_float): Likewise for total_free_floats.
669 (free_cons, Fcons): Likewise for total_free_conses.
670 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
671 Likewise for total_free_vector_bytes.
672 (Fmake_symbol): Likewise for total_free_symbols.
673 (bytes_free): Remove.
674
7098646f
DA
6752012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
676
677 Simple free memory accounting feature.
678 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
679 (sweep_vectors): Accumulate size of free vectors.
680 (Fgarbage_collect): Setup bytes_free.
681 (Fmemory_free): New function.
682 (syms_of_alloc): Register it.
683
22657b40
DA
6842012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
685
686 Cleanup overlays checking.
687 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
688 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
689 eassert and OVERLAYP.
690 (sort_overlays): Change to use OVERLAYP.
691
ddfc8813
RK
6922012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
693
694 * editfns.c (Finsert_char): Make it interactive, and make the
695 second arg optional. Copy interactive spec and docstring from
696 ucs-insert.
697
7c26cf3c
PE
6982012-07-17 Paul Eggert <eggert@cs.ucla.edu>
699
700 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
701 Unlike the other wrapped functions, fabs has an unspecified
702 effect on errno.
703
5d127af9
JD
7042012-07-16 Jan Djärv <jan.h.d@swipnet.se>
705
706 * nsterm.m (keyDown): Interpret flags without left/right bits
707 as the left key (Bug#11670).
708
6a0dd1d7
DA
7092012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
710
711 Remove empty and useless init functions.
712 * lisp.h (init_character_once, init_fns, init_image)
713 (init_filelock, init_sound): Remove prototype.
714 * character.c (init_character_once): Remove.
715 * filelock.c (init_filelock): Likewise.
716 * fns.c (init_fns): Likewise.
717 * image.c (init_image): Likewise.
718 * sound.c (init_sound): Likewise.
719 * emacs.c (main): Adjust accordingly.
720
7a6136fd
DA
7212012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
722
723 * gtkutil.h: Tiny cleanups.
724 (use_old_gtk_file_dialog): Remove useless declaration.
725 (xg_uses_old_file_dialog): Add suggested const attribute.
726
ce811ad9
EZ
7272012-07-15 Eli Zaretskii <eliz@gnu.org>
728
729 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
730 (bidi_paragraph_init): Use it to limit search forward for a strong
731 directional character in abnormally large paragraphs full of
732 neutral or weak characters. (Bug#11943)
733
c9adfeaa
SF
7342012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
735
736 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
737 the toolbar (Bug#9451).
738 (xg_make_tool_item): Give the widget event box a transparent
739 background.
740
fff62aa9
DA
7412012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
742
743 Cleanup basic allocation variables and functions.
744 * alloc.c (ignore_warnings, init_intervals, init_float)
745 (init_cons, init_symbol, init_marker): Remove.
746 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
747 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
748 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
749 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
750 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
751 (staticidx, init_alloc_once, init_strings, free_ablock):
752 Remove redundant initialization.
753 * fns.c (init_weak_hash_tables): Remove.
754 * lisp.h (init_weak_hash_tables): Remove prototype.
755
9730daca
DA
7562012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
757
758 Use zero_vector where appropriate.
759 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
760 accordingly.
761 * lisp.h (zero_vector): New declaration.
762 * font.c (null_vector): Remove.
763 (syms_of_font): Remove initialization and staticpro.
764 (font_list_entities, font_find_for_lface): Change to use zero_vector.
765 * keymap.c (Faccessible_keymaps): Likewise.
766
2e2d2a13
LL
7672012-07-15 Leo Liu <sdl.web@gmail.com>
768
769 * fringe.c: Fix typo in comments.
770
cd276f6e
LL
7712012-07-14 Leo Liu <sdl.web@gmail.com>
772
773 * fringe.c: Add a new bitmap exclamation-mark.
774
5a1131d9
EZ
7752012-07-14 Eli Zaretskii <eliz@gnu.org>
776
777 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
778
779 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
780 (HAVE_MENUS): Don't define, defined by editing config.in with
781 msdos/sed2v2.inp.
782 (GMALLOC_INHIBIT_VALLOC): Don't define.
783 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
784
22e983b7
JB
7852012-07-14 Juanma Barranquero <lekktu@gmail.com>
786
787 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
788
5b3f250f
GM
7892012-07-14 Glenn Morris <rgm@gnu.org>
790
791 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
792 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
793 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
794
33d63ff4
GM
7952012-07-13 Glenn Morris <rgm@gnu.org>
796
5b633342
GM
797 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
798
33d63ff4
GM
799 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
800 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
801
b55b9f85
JD
8022012-07-13 Jan Djärv <jan.h.d@swipnet.se>
803
0dc8cf50
JD
804 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
805 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
806 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
807 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
808 where appropriate.
809 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
810 as boolean expression.
811 (x_set_window_size): Remove unused variable toolbar.
812 (ns_get_color_default, ns_mod_to_lisp): Remove.
813 (ns_mouse_position): Remove unused variables xchar and ychar.
814 (ns_compute_glyph_string_overhangs): Remove unused variable face.
815 (ns_set_vertical_scroll_bar): Remove unused variable count.
816 (ns_delete_terminal): Remove unused variable i.
817 (ns_term_init): Remove unused variables r, g and b.
818 (mouseDown): Remove unused variable window.
819 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
820 (initFrameFromEmacs): Remove unused variable vbextra.
821 (mouseEntered): Remove unused variables p and dpyinfo.
822 (mouseExited): Remove unused variables p and r.
823 (ns_define_frame_cursor, ns_clear_frame_area)
824 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
825 (menuDown): Assign [sender tag] to variable and cast the variable.
826
827 * nsterm.h (menuDown): Add id as type to argument sender.
828 (ns_display_info_for_name): Add Lisp_Object argument.
829 (ns_term_init): Add Lisp_Object argument.
830 (ns_map_event_to_object): Add void argument.
831 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
832 prototype with arguments and only declare if __OBJC__.
833 (nxatoms_of_nsselect): Add void argument.
834 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
835 (ns_alloc_autorelease_pool): Add void argument.
836 (ns_release_autorelease_pool): Add void* argument.
837 (ns_get_defaults_value): Add const char* argument.
838
839 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
840 (initFromContents): Use SSDATA where appropriate.
841 (ns_update_menubar): Add braces to ambigous if-else.
842 (initWithTitle): Put () around assignment in if statement.
843 (ns_menu_show): Remove unused variables window and keymap.
844 (update_frame_tool_bar): Remove unused variable selected_p.
845 (initWithContentRect): Remove unused variable this_cmd_name.
846
847 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
848 appropriate.
849 (setXBMColor): Remove unused variable len.
850 (setPixmapData): Put () around assignment in loop statement.
851
852 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
853 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
854 where appropriate.
855 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
856 around assignment in loop statement.
857 (nsfont_open): Remove unused variable i.
858 (nsfont_open): Remove unused variable len.
859 (nsfont_draw): Remove unused variable cs.
860
861 * nsfns.m (x_set_icon_name, ns_set_name_internal)
862 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
863 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
864 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
865 (Fns_font_name, Fns_perform_service)
866 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
867 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
868 (ns_set_name): Remove unused variable view.
869 (x_set_menu_bar_lines): Remove unused variable olines.
870 (x_set_tool_bar_lines): Remove unused variable root_window.
871 (Fns_list_colors): Put () around assignment in while statement.
872 (Fns_perform_service): Remove unused variable len.
873 (Fns_display_usable_bounds): Remove unused variable top.
874 (syms_of_nsfns): Remove unused variable i.
875
b55b9f85
JD
876 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
877 memcpy (Bug#11907).
878
ed9265fc 8792012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
880
881 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
882 and free it with DestroyExceptionInfo (Bug#11558).
883
ef099b57
JB
8842012-07-13 Juanma Barranquero <lekktu@gmail.com>
885
886 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
887 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
888 Set here, not in nt/config.nt.
889
ea814a5d
EZ
8902012-07-13 Eli Zaretskii <eliz@gnu.org>
891
892 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
893 cursor overflow into the last glyph on display line when the right
894 fringe is off. (Bug#11832)
895
1a952767
PE
8962012-07-13 Paul Eggert <eggert@cs.ucla.edu>
897
898 * xdisp.c (produce_special_glyphs): Now static.
899 * dispextern.h (produce_special_glyphs): Remove decl.
900
983188fd
GM
9012012-07-13 Glenn Morris <rgm@gnu.org>
902
32fb4bb6
GM
903 * s/bsd-common, s/cygwin.h: Remove empty files.
904 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
905
983188fd
GM
906 * s/usg5-4-common.h (USG, USG5):
907 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
908 * s/sol2-6.h (SOLARIS2):
909 * s/irix6-5.h (IRIX6_5):
910 * s/hpux10-20.h (USG, USG5, HPUX):
911 * s/gnu-linux.h (USG, GNU_LINUX):
912 * s/freebsd.h (BSD_SYSTEM):
913 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
914 * s/cygwin.h (CYGWIN):
915 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
916 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
917
d1e68667 9182012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
919
920 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 921
6de0e799
GM
9222012-07-13 Glenn Morris <rgm@gnu.org>
923
739ae010
GM
924 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
925
dbee5793
GM
926 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
927
6de0e799
GM
928 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
929 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
930
b82da769
GM
9312012-07-12 Glenn Morris <rgm@gnu.org>
932
4fae5a7a 933 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
934
935 * process.c (init_process_emacs): Rename from init_process.
936 The old name is also the name of a Mach system call.
937 * lisp.h, emacs.c: Update for this name change.
938 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
939 longer needed.
940
5a979817
EZ
9412012-07-12 Eli Zaretskii <eliz@gnu.org>
942
943 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
944 memmove call that removes glyphs covered by the left truncation
945 glyph. Improve commentary.
946 (display_line): Fix display of continuation glyphs on GUI frames
947 when the right fringe is turned off and variable-size fonts are
948 used in the window. Move the code that appends a stretch glyph to
949 produce_special_glyphs, so that it could be used for truncation
950 and continuation glyphs alike.
951 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
952 glyph of a suitably computed width, to align the special glyphs at
953 the window margin. Code moved from display_line. (Bug#11832)
954
3e91a053
GM
9552012-07-12 Glenn Morris <rgm@gnu.org>
956
ba9e4b84
GM
957 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
958
959 * s/gnu-linux.h, s/hpux10-20.h:
960 Do not unconditionally define HAVE_XRMSETDATABASE.
961
3e91a053
GM
962 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
963
b300b1f4
PE
9642012-07-12 Paul Eggert <eggert@cs.ucla.edu>
965
966 Fix typos that broke OS X build.
967 Reported by Randal L. Schwartz in
968 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
969 * nsterm.m (ns_timeout): Add missing local decl.
970 (ns_get_color): snprintf -> sprintf, to fix typo.
971
6e777848
GM
9722012-07-12 Glenn Morris <rgm@gnu.org>
973
3f922c37
GM
974 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
975 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
976 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
977 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
978
0ab7b23a
GM
979 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
980 Move PTY_OPEN to configure.
981
6e777848
GM
982 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
983 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
984 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
985
4a7edc24
DA
9862012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
987
988 Use empty_unibyte_string where applicable.
989 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
990 * lread.c (read1): Likewise.
991 * xsettings.c (syms_of_xsettings): Likewise.
992
308aab79
GM
9932012-07-12 Glenn Morris <rgm@gnu.org>
994
42bd1719
GM
995 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
996 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
997 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
998 * s/hpux10-20.h (RUN_TIME_REMAP):
999 * s/bsd-common.h (TABDLY): Move to configure.
1000
1001 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1002
1003 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1004
ea0bbd17 1005 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1006 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1007
1008 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1009
308aab79
GM
1010 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1011 * s/template.h: Move NARROWPROTO to configure.
1012
ee1cf5cf
GM
10132012-07-11 Glenn Morris <rgm@gnu.org>
1014
30fe9bf4
GM
1015 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1016 unused since 2011-01-17 change to systty.h.
1017
ee1cf5cf
GM
1018 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1019 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1020 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1021
63e47e07
PE
10222012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1023
1024 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1025
c43fb4c3
GM
10262012-07-11 Glenn Morris <rgm@gnu.org>
1027
1028 * s/darwin.h, s/gnu-linux.h, s/template.h:
1029 Move INTERRUPT_INPUT to configure.
1030
e8df9267
DA
10312012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1032
1033 Minor adjustments to interning code.
1034 * lisp.h (intern, intern_c_string): Redefine as static inline
1035 wrappers for intern_1 and intern_c_string_1, respectively.
1036 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1037 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1038 Vobarray checking.
e8df9267
DA
1039 * font.c (font_intern_prop): Likewise. Adjust comment.
1040 * w32font.c (intern_font_name): Likewise.
1041
34348bd4
AS
10422012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1043
d96a1e0c
AS
1044 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1045
34348bd4
AS
1046 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1047 of Fcar/Fcdr if possible.
1048 * font.c (check_otf_features): Likewise.
1049 * fontset.c (Fnew_fontset): Likewise.
1050 * gnutls.c (Fgnutls_boot): Likewise.
1051 * minibuf.c (read_minibuf): Likewise.
1052 * msdos.c (IT_set_frame_parameters): Likewise.
1053 * xmenu.c (Fx_popup_dialog): Likewise.
1054 * w32menu.c (Fx_popup_dialog): Likewise.
1055
c8add24e
GM
10562012-07-11 Glenn Morris <rgm@gnu.org>
1057
4b575b3c
GM
1058 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1059 since nothing has defined it on these platforms.
1060
09f4e3b0
GM
1061 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1062 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1063
172bedef
GM
1064 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1065 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1066 Move CLASH_DETECTION to configure.
1067
249685df
GM
1068 * s/gnu.h: Remove file, which is now empty.
1069
c8add24e
GM
1070 * s/gnu.h, s/gnu-linux.h:
1071 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1072
b41253a3
JW
10732012-07-11 John Wiegley <johnw@newartisans.com>
1074
1075 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1076 function attribute, so we only use it if it exists in the
1077 compiler.
1078
d923b542
DA
10792012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1080
1081 Avoid call to strlen in fast_c_string_match_ignore_case.
1082 * search.c (fast_c_string_match_ignore_case): Change to use
1083 length argument. Adjust users accordingly.
1084 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1085
5ebbef1d
PE
10862012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1087
bb352260
PE
1088 Assume mkdir, rmdir.
1089 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1090 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1091
57054ddd
PE
1092 Assume rename.
1093 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1094
b747d3f7
PE
1095 Assume perror.
1096 * s/hpux10-20.h (HAVE_PERROR): Remove.
1097 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1098 Remove dummy definition, as this problem was obsolete long ago.
1099
5ebbef1d
PE
1100 Assume strerror.
1101 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1102
984e7f30
DA
11032012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1104
1105 Avoid calls to strlen in font processing functions.
1106 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1107 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1108 users accordingly.
d923b542
DA
1109 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1110 Adjust prototypes.
1111 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1112 Change to return ptrdiff_t.
984e7f30
DA
1113 (xfont_list_pattern, xfont_match): Use length returned by
1114 xfont_decode_coding_xlfd.
1115 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1116
20e94fdd
GM
11172012-07-11 Glenn Morris <rgm@gnu.org>
1118
9d596af3
GM
1119 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1120 Move DONT_REOPEN_PTY to configure.
1121
20e94fdd
GM
1122 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1123 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1124
e99a530f
PE
11252012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1126
22ffb973
PE
1127 Remove "#define unix" that is no longer needed (Bug#11905).
1128 * s/aix4-2.h (unix): Remove; no longer needed.
1129
e9a9ae03
PE
1130 EMACS_TIME simplification (Bug#11875).
1131 This replaces macros (which typically do not work in GDB)
1132 with functions, typedefs and enums, making the code easier to debug.
1133 The functional style also makes code easier to read and maintain.
1134 * systime.h: Include <sys/time.h> on all hosts, not just if
1135 WINDOWSNT, since 'struct timeval' is needed in general.
1136 (EMACS_TIME): Now a typedef, not a macro.
1137 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1138 not macros.
1139 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1140 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1141 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1142 (EMACS_TIME_LE): Now functions, not macros.
1143 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1144 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1145 which are not functions. All uses rewritten to use:
1146 (make_emacs_time): New function.
1147 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1148 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1149 not functions. All uses rewritten to use the following, respectively:
1150 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1151 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1152 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1153 * fileio.c (Fcopy_file):
1154 * xterm.c (XTflash): Get the current time closer to when it's used.
1155 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1156
ffacb126
PE
1157 * bytecode.c (targets): Suppress -Woverride-init warnings.
1158
e99a530f
PE
1159 Simplify by avoiding confusing use of strncpy etc.
1160 * doc.c (Fsnarf_documentation):
1161 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1162 * frame.c (Fmake_terminal_frame):
1163 * gtkutil.c (get_utf8_string):
1164 * lread.c (openp):
1165 * nsmenu.m (ns_update_menubar):
1166 * regex.c (regerror):
1167 Prefer memcpy to strncpy and strncat when either will do.
1168 * fileio.c (Fsubstitute_in_file_name):
1169 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1170 (menu_separator_name_p):
1171 * nsmenu.m (ns_update_menubar):
1172 Prefer memcmp to strncmp when either will do.
1173 * nsterm.m: Include <ftoastr.h>.
1174 (ns_get_color):
1175 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1176 Prefer snprintf to strncpy.
1177 * nsterm.m (ns_term_init):
1178 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1179 * nsterm.m (ns_term_init):
1180 Avoid the need for strncpy, by using build_string or
1181 make_unibyte_string directly. Use dtoastr, not snprintf.
1182 * process.c (Fmake_network_process): Diagnose service names that
1183 are too long, rather than silently truncating them or creating
1184 non-null-terminated names.
1185 (Fnetwork_interface_info): Likewise, for interface names.
1186 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1187 Prefer sprintf to strncat.
1188 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1189 Prefer vsnprintf to vsprintf + strncpy.
1190
c59592b3
GM
11912012-07-10 Glenn Morris <rgm@gnu.org>
1192
1193 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1194 Clarify fallback case.
1195
7d7bbefd
DA
11962012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1197
1198 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1199 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1200 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1201 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1202 where argument type is known to be a Lisp_Cons.
1203
3a4c8000
TT
12042012-07-10 Tom Tromey <tromey@redhat.com>
1205
1206 * bytecode.c (BYTE_CODE_THREADED): New macro.
1207 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1208 (enum byte_code_op): New type.
1209 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1210 (exec_byte_code): Use them. Use token threading when applicable.
1211
2a0213a6
DA
12122012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1213
1214 Optimize pure C strings initialization.
1215 * lisp.h (make_pure_string): Fix prototype.
1216 (build_pure_c_string): New function, defined as static inline. This
1217 provides a better opportunity to optimize away calls to strlen when
1218 the function is called with compile-time constant argument.
1219 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1220 argument, adjust users accordingly. Use build_pure_c_string where
1221 appropriate.
1222 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1223 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1224 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1225
cb1caeaf
DA
12262012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1227
1228 Avoid calls to strlen in miscellaneous functions.
1229 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1230 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1231 * lread.c (openp): Likewise.
1232
c293e30c
DA
12332012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1234
1235 Avoid calls to strlen in path processing functions.
1236 * fileio.c (file_name_as_directory): Add comment. Change to add
1237 srclen argument and return the length of result. Adjust users
1238 accordingly.
1239 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1240 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1241 users accordingly.
1242 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1243
9e059e3f
GM
12442012-07-10 Glenn Morris <rgm@gnu.org>
1245
d02eb359
GM
1246 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1247 Move PENDING_OUTPUT_COUNT definition to configure.
1248
882cf227
GM
1249 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1250 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1251 * s/gnu.h (DATA_START): Move definitions to configure.
1252
af6e839f
GM
1253 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1254 We include usg5-4-common.h, which defines them both.
1255
40289a12
GM
1256 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1257 O_RDONLY already includes it).
1258
9e059e3f
GM
1259 Stop ns builds setting the EMACSLOADPATH environment variable.
1260 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1261 Now it does not set EMACSLOADPATH, just returns the load-path string.
1262 * nsterm.h: Update accordingly.
1263 * lread.c [HAVE_NS]: Include nsterm.h.
1264 (init_lread) [HAVE_NS]: Use ns_load_path.
1265 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1266
7c4e8ec0
GM
12672012-07-09 Glenn Morris <rgm@gnu.org>
1268
d4f600ff
GM
1269 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1270 since the included bsd-common.h does so.
1271
cbb31951
GM
1272 Stop ns builds setting the EMACSPATH environment variable.
1273 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1274 (ns_init_paths): Do not set EMACSPATH.
1275 * nsterm.h (ns_exec_path): Add it.
1276 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1277 Use ns_exec_path.
1278
7c4e8ec0
GM
1279 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1280
26bccfae
PE
12812012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1282
a0bee46f
PE
1283 * process.c (wait_reading_process_output): 'waitchannels' was unset
1284 when read_kbd || !NILP (wait_for_cell); fix this.
1285
5994c183
PE
1286 Add GCC-style 'const' attribute to functions that can use it.
1287 * character.h (char_resolve_modifier_mask):
1288 * keyboard.h (make_ctrl_char):
1289 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1290 (init_character_once, next_almost_prime, init_fns, init_image)
1291 (flush_pending_output, init_sound):
1292 * mem-limits.h (start_of_data):
1293 * menu.h (finish_menu_items):
1294 Add ATTRIBUTE_CONST.
1295 * emacs.c (DEFINE_DUMMY_FUNCTION):
1296 Declare the dummy function with ATTRIBUTE_CONST.
1297 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1298 Add decls with ATTRIBUTE_CONST.
1299
26bccfae
PE
1300 Minor improvements to make_formatted_string.
1301 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1302 where int is good enough, as vsprintf returns an int.
1303 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1304
a8290ec3
DA
13052012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1306
1307 Use make_formatted_string to avoid double length calculation.
1308 * lisp.h (make_formatted_string): New prototype.
1309 * alloc.c (make_formatted_string): New function.
1310 * buffer.c (Fgenerate_new_buffer_name): Use it.
1311 * dbus.c (syms_of_dbusbind): Likewise.
1312 * editfns.c (Fcurrent_time_zone): Likewise.
1313 * filelock.c (get_boot_time): Likewise.
1314 * frame.c (make_terminal_frame, set_term_frame_name)
1315 (x_report_frame_params): Likewise.
1316 * image.c (gs_load): Likewise.
1317 * minibuf.c (get_minibuffer): Likewise.
1318 * msdos.c (dos_set_window_size): Likewise.
1319 * process.c (make_process): Likewise.
1320 * xdisp.c (ensure_echo_area_buffers): Likewise.
1321 * xsettings.c (apply_xft_settings): Likewise.
1322
d01ba2f1
GM
13232012-07-09 Glenn Morris <rgm@gnu.org>
1324
1325 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1326 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1327 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1328 * nsterm.h (ns_etc_directory): Add it.
1329 * callproc.c [HAVE_NS]: Include nsterm.h.
1330 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1331
f1f924b6
DA
13322012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1333
1334 Move marker debugging code under MARKER_DEBUG.
1335 * marker.c (MARKER_DEBUG): Move marker debugging code under
1336 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1337 for bootstrap with --enable-checking (~3x slowdown reported
1338 by Juanma Barranquero <lekktu@gmail.com>).
1339 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1340
ab531b66
PE
13412012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1342
1343 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1344 See <http://bugs.gnu.org/11825#29>.
1345
c4b3bc8a
EZ
13462012-07-08 Eli Zaretskii <eliz@gnu.org>
1347
1348 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1349 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1350 (display_line): Add commentary about displaying truncation glyphs
1351 on GUI frames.
1352 (produce_special_glyphs): Move here from term.c.
1353
1354 * term.c (produce_special_glyphs): Move to xdisp.c.
1355
1356 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1357 section.
c4b3bc8a 1358
b676b881
AS
13592012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1360
f17c5273
AS
1361 * xdisp.c (display_line): Avoid warning about implicit declaration
1362 of FRAME_FONT.
1363
298819b9
AS
1364 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1365
b676b881
AS
1366 * lisp.h: Remove empty conditional.
1367
6045c4fd
PE
13682012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1369
b3350bf9
PE
1370 * lread.c (load_path_check): Now static.
1371
6045c4fd
PE
1372 Fix some minor --with-ns problems found by static checking.
1373 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1374 (x_set_font) [!HAVE_X_WINDOWS]:
1375 * image.c (xpm_load_image) [HAVE_NS]:
1376 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1377 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1378 Remove unused local.
1379 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1380 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1381 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1382 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1383 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1384 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1385 Fix pointer signedness problem.
1386 * xfaces.c (FRAME_X_FONT_TABLE):
1387 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1388
929e7845
GM
13892012-07-07 Glenn Morris <rgm@gnu.org>
1390
1391 * lread.c (load_path_check): New function, split from init_lread.
1392 (init_lread): Reorganize. Motivation:
1393 If EMACSLOADPATH is set, check/warn about that rather than the
1394 defaults, which we are not going to use. Hence we can remove
1395 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1396 Don't warn if site-lisp directories are missing.
1397 If not installed, start from a blank load-path, since
1398 PATH_LOADSEARCH refers to the eventual installation directories.
1399
58dd0aa4
EZ
14002012-07-07 Eli Zaretskii <eliz@gnu.org>
1401
1402 Support truncation and continuation glyphs on GUI frames, when
1403 fringes are disabled. (Bug#11832)
1404 * xdisp.c (init_iterator): Get dimensions of truncation and
1405 continuation glyphs even if on GUI frames. Adjust
1406 it->last_visible_x on GUI frames when the left or right fringes,
1407 or both, are absent.
1408 (start_display, move_it_in_display_line_to): Handle the case of a
1409 GUI frame without a fringe to display continuation or truncation
1410 glyphs.
1411 (insert_left_trunc_glyphs): Support GUI frames: make sure
1412 truncation glyphs overwrite enough glyphs from the current line to
1413 have sufficient space in pixels.
1414 (display_line): Support truncation and continuation glyphs on GUI
1415 frames. If some spare pixels are left on the line after inserting
1416 the truncation glyphs, fill that space with a stretch glyph of a
1417 suitably computed width.
1418
1419 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1420 produce_glyphs, to support GUI sessions.
1421
31571fd7
PE
14222012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1423
5a16b9bc
PE
1424 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1425
f3047c75
PE
1426 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1427
31571fd7
PE
1428 Do not require float-time's arg to fit in time_t (Bug#11825).
1429 This works better on hosts where time_t is unsigned, and where
1430 float-time is applied to the (negative) difference between two times.
1431 * editfns.c (decode_time_components): Last arg is now double *,
1432 not int *, and means to store all the result as a double, without
1433 worrying about whether the seconds part fits in time_t.
1434 All callers changed.
1435 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1436 All callers changed.
1437 (Ffloat_time): Do not fail merely because the specified time falls
1438 outside of time_t range.
1439
4516fbef
GM
14402012-07-07 Glenn Morris <rgm@gnu.org>
1441
1442 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1443 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1444 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1445
07adc2c6
JB
14462012-07-07 Juanma Barranquero <lekktu@gmail.com>
1447
1448 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1449 Update dependencies.
1450
1451 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1452
fd573f31
PE
14532012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1454
fee5959d
PE
1455 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1456 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1457 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1458 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1459 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1460 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1461
fd573f31
PE
1462 * xfont.c (compare_font_names): Redo to omit the need for casts.
1463
ddadbc0e
AS
14642012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1465
fca8d6b6
AS
1466 * xfns.c (Fx_change_window_property): Doc fix.
1467 * w32fns.c (Fx_change_window_property): Doc fix.
1468
ddadbc0e
AS
1469 * w32fns.c (Fx_window_property): Accept the same arguments as the
1470 X Windows version. Doc fix.
1471 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1472
ed9265fc 14732012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1474 Eli Zaretskii <eliz@gnu.org>
1475
1476 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1477 Windows-specific code from nt/config.nt moved here.
1478 Obsolete settings removed.
1479
216ee680
PE
14802012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1481
1482 * process.c: Avoid unnecessary calls to gettime.
1483 (wait_reading_process_output): Don't get the time of day
1484 when gobbling data immediately and not waiting, as there's no need
1485 for it in that case. This removes a FIXME.
1486
bdd091e4
JD
14872012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1488
1489 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1490 is defined (Bug#11768).
1491
9d44f8ce
DA
14922012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1493
1494 Fix marker debugging code.
1495 * marker.c (byte_char_debug_check): Do not perform the check
1496 if buffer is not multibyte.
090bd7cb
JB
1497 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1498 Call byte_char_debug_check with correct arguments.
9d44f8ce 1499
90fc4786
DA
15002012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1501
1502 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1503 * marker.c (byte_char_debug_check, count_markers):
1504 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1505 (byte_debug_flag): Remove.
1506 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1507 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1508
7b7ae965
DA
15092012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1510
4e57b342
DA
1511 Avoid code repetition in marker-related functions.
1512 * marker.c (attach_marker): New function.
1513 (Fset_marker, set_marker_restricted, set_marker_both)
1514 (set_marker_restricted_both): Use it.
1515 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1516 Consistently rename charno to charpos.
1517 (marker_position): Add eassert.
1518 (marker_byte_position): Convert to eassert.
1519
15202012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1521
1522 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1523 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1524 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1525
657924ff
DA
15262012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1527
1528 Introduce fast path for the widely used marker operation.
1529 * alloc.c (build_marker): New function.
1530 * lisp.h (build_marker): New prototype.
1531 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1532 * composite.c (autocmp_chars): Likewise.
1533 * editfns.c (buildmark): Remove.
1534 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1535 (save_restriction_save): Use build_marker.
1536 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1537 * window.c (save_window_save): Likewise.
1538
041a49a6
DA
15392012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1540
1541 Do not use Fdelete_overlay in delete_all_overlays
1542 to avoid redundant calls to unchain_overlay.
1543 * buffer.c (drop_overlay): New function.
1544 (delete_all_overlays, Fdelete_overlay): Use it.
1545 * minibuf.c (get_minibuffer): Fix comment.
1546
7dca65a4
PE
15472012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1548
1549 Port to OpenBSD 5.1 amd64.
1550 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1551 This is needed for OpenBSD, and should be harmless on all BSD systems.
1552 Also, include <sys/sysctl.h>, as it should be available on all
1553 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1554 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1555 use p_pid member, not kp_proc.pid.
1556
8eb876e2
GM
15572012-07-06 Glenn Morris <rgm@gnu.org>
1558
1559 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1560
38182d90
PE
15612012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1562
1563 More xmalloc and related cleanup.
1564 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1565 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1566 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1567 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1568 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1569 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1570 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1571 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1572 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1573 * xterm.c:
1574 Omit needless casts involving void * pointers and allocation.
1575 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1576 as the former is more robust if P's type is changed.
1577 Prefer xzalloc to xmalloc + memset 0.
1578 Simplify malloc-or-realloc to realloc.
1579 Don't worry about xmalloc returning a null pointer.
1580 Prefer xstrdup to xmalloc + strcpy.
1581 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1582 growing it.
1583 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1584 alloca of a constant.
1585
6dd5a677
EZ
15862012-07-05 Eli Zaretskii <eliz@gnu.org>
1587
1588 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1589 hscroll is larger than the line width. Fixes long and futile
1590 looping inside extend_face_to_end_of_line (on a TTY) producing
1591 glyphs that are not needed and thrown away.
1592
6b312f0f
DA
15932012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1594
1595 * marker.c (set_marker_restricted_both): Simplify by using
1596 clip_to_bounds.
1597
f520ef9b
PE
15982012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1599
1600 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1601
383b7c95
JD
16022012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1603
1604 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1605 not defined (Bug#11768).
1606 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1607 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1608 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1609 followed by gtk_box_set_homogeneous (Bug#11768).
1610 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1611 (update_theme_scrollbar_width, xg_create_scroll_bar):
1612 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1613 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1614 (is_box_type): New function (Bug#11768).
1615 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1616 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1617 with default display (Bug#11768).
1618
d6e7bf45
EZ
16192012-07-05 Eli Zaretskii <eliz@gnu.org>
1620
1621 * xdisp.c (window_hscroll_limited): New function.
1622 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1623 coordinates when window's hscroll is set to insanely large
1624 values. (Bug#11857)
1625
431391ec
JB
16262012-07-05 Juanma Barranquero <lekktu@gmail.com>
1627
1628 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1629 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1630
23f86fce
DA
16312012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1632
1633 Cleanup xmalloc.
1634 * lisp.h (xzalloc): New prototype. Omit needless casts.
1635 * alloc.c (xzalloc): New function. Omit needless casts.
1636 * charset.c: Omit needless casts. Convert all calls to
1637 xmalloc with following memset to xzalloc.
1638 * dispnew.c: Likewise.
1639 * fringe.c: Likewise.
1640 * image.c: Likewise.
1641 * sound.c: Likewise.
1642 * term.c: Likewise.
1643 * w32fns.c: Likewise.
1644 * w32font.c: Likewise.
1645 * w32term.c: Likewise.
1646 * xfaces.c: Likewise.
1647 * xfns.c: Likewise.
1648 * xterm.c: Likewise.
1649 * atimer.c: Omit needless casts.
1650 * buffer.c: Likewise.
1651 * callproc.c: Likewise.
1652 * ccl.c: Likewise.
1653 * coding.c: Likewise.
1654 * composite.c: Likewise.
1655 * doc.c: Likewise.
1656 * doprnt.c: Likewise.
1657 * editfns.c: Likewise.
1658 * emacs.c: Likewise.
1659 * eval.c: Likewise.
1660 * filelock.c: Likewise.
1661 * fns.c: Likewise.
1662 * gtkutil.c: Likewise.
1663 * keyboard.c: Likewise.
1664 * lisp.h: Likewise.
1665 * lread.c: Likewise.
1666 * minibuf.c: Likewise.
1667 * msdos.c: Likewise.
1668 * print.c: Likewise.
1669 * process.c: Likewise.
1670 * region-cache.c: Likewise.
1671 * search.c: Likewise.
1672 * sysdep.c: Likewise.
1673 * termcap.c: Likewise.
1674 * terminal.c: Likewise.
1675 * tparam.c: Likewise.
1676 * w16select.c: Likewise.
1677 * w32.c: Likewise.
1678 * w32reg.c: Likewise.
1679 * w32select.c: Likewise.
1680 * w32uniscribe.c: Likewise.
1681 * widget.c: Likewise.
1682 * xdisp.c: Likewise.
1683 * xmenu.c: Likewise.
1684 * xrdb.c: Likewise.
1685 * xselect.c: Likewise.
1686
0497dc44
PE
16872012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1688
1689 * fileio.c (time_error_value): Check the right error number.
1690 Problem reported by Troels Nielsen in
1691 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1692
356e7178
PE
16932012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1694
4e71fd89
PE
1695 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1696 This should be fixed in a better way; see Eli Zaretskii in
1697 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1698 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1699
f0941253
PE
1700 * fileio.c (time_error_value): Rename from special_mtime.
1701 The old name's problems were noted by Eli Zaretskii in
1702 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1703
065c9eb4
PE
1704 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1705 This variable's comment says Emacs needs at least one GDB-visible
1706 symbol of type enum pvec_type, to work around GDB problems.
1707 The symbol's value doesn't matter.
1708
356e7178
PE
1709 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1710 that causes compilation to fail on pre-C99 compilers.
1711
ed9265fc 17122012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1713
1714 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1715 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1716
3884d954
DA
17172012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1718
d209e2fb 1719 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1720 headers for buffer_defaults and buffer_local_symbols.
1721 Reported by Juanma Barranquero <lekktu@gmail.com>.
1722
ee28be33
SM
17232012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1724
1725 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1726 * lisp.h (enum pvec_type): Use fewer bits.
1727 (PSEUDOVECTOR_SIZE_BITS): New constant.
1728 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1729 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1730 change in pvec_type.
1731 (PSEUDOVECTOR_TYPEP): New macro.
1732 (TYPED_PSEUDOVECTORP): Use it.
1733 * fns.c (internal_equal): Adapt code to extract pvectype.
1734 * emacs.c (gdb_pvec_type): Update type.
1735 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1736 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1737 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1738 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1739 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1740 abusing vector->header.next.nbytes.
1741 (live_vector_p): Use PVEC_TYPE.
1742 (mark_object): Adapt code to extract pvectype. Use switch.
1743
c7f2cd7f
PE
17442012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1745
1746 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1747 Tighten new eassert a bit.
1748
8ce70ed2
DA
17492012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1750
1751 Fix compilation with --enable-gcc-warnings and -O1
1752 optimization level.
1753 * doprnt.c (doprnt): Change type of tem to int, initialize
1754 to avoid compiler warning. Add eassert.
1755 * search.c (simple_search): Initialize match_byte to avoid
1756 compiler warning. Add eassert.
1757
dea7f1e5
PE
17582012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1759
24a212eb
PE
1760 Avoid weird behavior with large horizontal scrolls.
1761 Without this change, for example, large hscroll values would
1762 mess up Emacs's display on Fedora 15 x86, presumably due to
1763 overflows in int calculations in the display code.
1764 Also, if buffers had long lines, Emacs would freeze.
1765 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1766 (set_window_hscroll): New function, containing the old guts of
1767 Fset_window_hscroll. Return the clipped value.
1768 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1769 This avoids the need to check against PTRDIFF_MAX.
1770
dea7f1e5
PE
1771 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1772
76046526
DA
17732012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1774
1775 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1776
39adff0d
PE
17772012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1778
63807d47
PE
1779 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1780 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1781 since GCC 4.4.6 issues a bogus warning for them.
1782
39adff0d
PE
1783 Fix bugs in file timestamp newness comparisons.
1784 * fileio.c (Ffile_newer_than_file_p):
1785 * lread.c (Fload): Use full timestamp resolution of files,
1786 not just the 1-second resolution, so that files that are only
1787 slightly newer still count as newer.
1788 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1789 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1790
dbeed9a6
PE
17912012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1792
1793 * fileio.c: Improve handling of file time marker. (Bug#11852)
1794 (special_mtime): New function.
1795 (Finsert_file_contents, Fverify_visited_file_modtime):
1796 Use it to set special mtime values consistently.
1797
636334d6
AS
17982012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1799
1800 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1801 marker for non-existing file. (Bug#11852)
1802
e2017fe2
GM
18032012-07-03 Glenn Morris <rgm@gnu.org>
1804
1805 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1806 and did not make it into globals.h).
1807
404dbd37
TT
18082012-07-03 Tom Tromey <tromey@redhat.com>
1809
1810 * window.c (Fset_window_margins, Fset_window_fringes)
1811 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1812 * textprop.c (Fprevious_property_change): No longer static.
1813 * syntax.c (Fsyntax_table_p): No longer static.
1814 * process.c (Fget_process, Fprocess_datagram_address): No longer
1815 static.
1816 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1817 * keyboard.c (Fcommand_execute): No longer static.
1818 Remove EXFUN.
1819 * insdel.c (Fcombine_after_change_execute): No longer static.
1820 * image.c (Finit_image_library): No longer static.
1821 * fileio.c (Fmake_symbolic_link): No longer static.
1822 * eval.c (Ffetch_bytecode): No longer static.
1823 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1824 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1825 No longer static.
404dbd37
TT
1826 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1827 static.
1828 * dired.c (Ffile_attributes): No longer static.
1829 * composite.c (Fcomposition_get_gstring): No longer static.
1830 * callproc.c (Fgetenv_internal): No longer static.
1831
1832 * ccl.h: Remove EXFUNs.
1833 * buffer.h: Remove EXFUNs.
1834 * dispextern.h: Remove EXFUNs.
1835 * intervals.h: Remove EXFUNs.
1836 * fontset.h: Remove EXFUN.
1837 * font.h: Remove EXFUNs.
1838 * dosfns.c (system_process_attributes): Remove EXFUN.
1839 * keymap.h: Remove EXFUNs.
1840 * lisp.h: Remove EXFUNs.
1841 * w32term.h: Remove EXFUNs.
1842 * window.h: Remove EXFUNs.
1843 * xsettings.h: Remove EXFUN.
1844 * xterm.h: Remove EXFUN.
1845
8e4fd1e1
GM
18462012-07-03 Glenn Morris <rgm@gnu.org>
1847
1848 * lisp.h (Frandom): Make it visible to C.
1849 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1850 buffer for invisible buffers. (Bug#1229)
1851
ca95b3eb
DA
18522012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1853
1854 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1855 values which aren't power of 2.
1856 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1857 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1858 accordingly.
1859
7555c33f
SM
18602012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1861
1862 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1863
1864 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1865
d12e8f5a
DA
18662012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1867
1868 * alloc.c (allocate_vector_block): Remove redundant
1869 calls to mallopt if DOUG_LEA_MALLOC is defined.
1870 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1871 avoid calls to mallopt if zero_vector is returned.
1872
296094c3
DA
18732012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1874
1875 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1876 is enabled, avoid dereferencing NULL current_sblock if
1877 running undumped.
1878
36429c89
DA
18792012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1880
1881 Cleanup basic buffer management.
1882 * buffer.h (struct buffer): Change layout to use generic vector
1883 marking code. Fix some comments. Change type of 'clip_changed'
1884 to bitfield. Remove unused #ifndef old.
1885 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1886 (GET_OVERLAYS_AT): Fix indentation.
1887 (for_each_per_buffer_object_at): New macro.
1888 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1889 (Fbuffer_local_variables): Use it.
1890 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1891 * alloc.c (allocate_buffer): Adjust to match new layout of
1892 struct buffer. Fix comment.
1893 (mark_overlay): New function.
1894 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1895 Lisp area of struct buffer.
1896 (mark_object): Use it. Adjust marking of misc objects
1897 and related comments.
1898
3b3e4cac
PE
18992012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1900
1901 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1902 wrapper that is not needed because the wrapped code is a no-op (zero
1903 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1904 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1905
cf5c0175
DA
19062012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1907
1908 * alloc.c (mark_buffer): Simplify. Remove prototype.
1909 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1910 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1911 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1912 redundant calls to mark_vectorlike for bool vectors.
1913
ca26824c
GM
19142012-06-30 Glenn Morris <rgm@gnu.org>
1915
2e4c5312
GM
1916 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1917
ca26824c
GM
1918 * epaths.in (PATH_SITELOADSEARCH): New.
1919 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1920 This is rather than relying on --enable-locallisppath elements
1921 having "site-lisp" in their names. (Bug#10208#25, 11658)
1922
0d23c240
EZ
19232012-06-30 Eli Zaretskii <eliz@gnu.org>
1924
c9240d7a
EZ
1925 * w32proc.c (sys_select): Accept and ignore one more argument.
1926
1927 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1928
0d23c240 1929 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1930 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1931
1932 * sysdep.c: Don't include dos.h and dosfns.h.
1933
1934 * process.c (sys_select):
1935 * msdos.c (sys_select): Accept one more argument and ignore it.
1936
1937 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1938 adapt data types and code to that.
1939
1940 * dosfns.c:
1941 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1942 which clashes with the gnulib function of the same name.
1943
af5a5a98
AS
19442012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1945
c5e4379c
AS
1946 * font.c (font_style_to_value, font_style_symbolic)
1947 (font_prop_validate_style): Add type checks for values in
1948 font_style_table.
1949
af5a5a98
AS
1950 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1951 argument.
1952 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1953 uses.
1954
8d38f461
EZ
19552012-06-29 Eli Zaretskii <eliz@gnu.org>
1956
2e5a6631
EZ
1957 * xdisp.c (try_window_id): Undo last change.
1958
8d38f461
EZ
1959 * w32.c (getwd): Adjust commentary about startup_dir.
1960 (init_environment): Always call sys_access, even in non-MSVC
1961 builds. Don't chdir to the directory of the Emacs executable.
1962 This undoes code from 1997 which was justified by the need to
1963 "avoid conflicts when removing and renaming directories". But its
1964 downside was that every relative file name was being interpreted
1965 relative to the directory of the Emacs executable, which can never
1966 be TRT. In particular, it broke sys_access when called with
1967 relative file names.
1968 (sys_access): Map GetLastError to errno.
1969
2af3565e
DA
19702012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1971
1972 * window.h (struct window): Change type of 'fringes_outside_margins'
1973 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1974 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1975 Adjust comment.
1976 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1977 to ptrdiff_t.
1978
c8d3a25c 19792012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1980
c8d3a25c
GM
1981 * gnutls.c (emacs_gnutls_handshake):
1982 Add QUIT to make the loop interruptible.
57570cd3 1983
c8d3a25c 19842012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1985
c8d3a25c
GM
1986 * charset.c (init_charset): Make lack of etc/charsets fatal.
1987
3e984ee8
DA
19882012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1989
1990 * editfns.c (region_limit): Fix type mismatch.
1991
ef884f23
DA
19922012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1993
1994 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1995 undefined. Convert from xassert to eassert.
1996 * nsmenu.m: Convert from xassert to eassert.
1997 * nsterm.m: Likewise.
1998
7d7e0027
SM
19992012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2000
2001 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2002
aa754e6a
PE
20032012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2004
2005 Avoid integer overflow on scroll-left and scroll-right.
2006 * window.c (HSCROLL_MAX): New macro.
2007 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2008 overflow when requested scroll falls outside ptrdiff_t range.
2009
80b00b08
DA
20102012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2011
2012 * window.h (struct window): Change type of 'hscroll',
2013 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2014 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2015 Adjust users accordingly.
2016 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2017 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2018 from EMACS_INT to ptrdiff_t.
2019 (make_window): Omit redundant initialization.
2020
62b2bcf6
JB
20212012-06-28 Juanma Barranquero <lekktu@gmail.com>
2022
2023 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2024
45942c7d
DA
20252012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2026
2027 * window.h (struct window): Change type of 'use_time' and
2028 'sequence_number' from Lisp_Object to int.
2029 * frame.c (make_frame): Adjust users accordingly.
2030 * print.c (print_object): Likewise.
2031 * window.c (select_window, Fwindow_use_time, make_parent_window)
2032 (make_window): Likewise.
2033
e509cfa6
DA
20342012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2035
2036 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2037 enabled with --enable-checking=[all,glyphs] configure option.
2038 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2039 adjust comments accordingly.
2040 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2041 undefined, adjust comments accordingly.
2042 * image.c: Likewise.
2043 * scroll.c: Likewise.
2044 * w32fns.c: Likewise.
2045 * w32term.c: Likewise.
2046 * xdisp.c: Likewise.
2047 * xfaces.c: Likewise.
2048 * xfns.c: Likewise.
2049 * xterm.c: Likewise.
2050
a54e2c05
DA
20512012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2052
2053 Generalize run-time debugging checks.
2054 * dispextern.h (XASSERTS): Remove.
2055 * fontset.c (xassert): Remove.
2056 Convert from xassert to eassert.
2057 * alloc.c: Convert from xassert to eassert.
2058 * bidi.c: Likewise.
2059 * dispnew.c: Likewise.
2060 * fns.c: Likewise.
2061 * fringe.c: Likewise.
2062 * ftfont.c: Likewise.
2063 * gtkutil.c: Likewise.
2064 * image.c: Likewise.
2065 * keyboard.c: Likewise.
2066 * menu.c: Likewise.
2067 * process.c: Likewise.
2068 * scroll.c: Likewise.
2069 * sound.c: Likewise.
2070 * term.c: Likewise.
2071 * w32console.c: Likewise.
2072 * w32fns.c: Likewise.
2073 * w32term.c: Likewise.
2074 * window.c: Likewise.
2075 * xdisp.c: Likewise.
2076 * xfaces.c: Likewise.
2077 * xfns.c: Likewise.
2078 * xselect.c: Likewise.
2079 * xterm.c: Likewise.
2080
1ec4b7b2
SM
20812012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2082
2083 * fns.c (maybe_resize_hash_table): Output message when growing the
2084 purify-hashtable.
2085
2014308a
DA
20862012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2087
2088 * alloc.c (allocate_string_data): Remove dead code.
2089 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2090 avoid GCC warning about unused macro.
2091
246155eb
DA
20922012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2093
2094 * alloc.c (allocate_string): Omit intervals initialization.
2095 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2096 as in make_pure_string and make_pure_c_string.
2097
43184b7b
DA
20982012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2099
d209e2fb 2100 * alloc.c (allocate_string): Fix last change.
43184b7b 2101
3fe6dd74
DA
21022012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2103
d209e2fb 2104 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2105 to memset, add explicit initialization where appropriate.
2106
1ba6038a
GM
21072012-06-27 Glenn Morris <rgm@gnu.org>
2108
2109 * lisp.mk (lisp): Remove paths.elc.
2110
c89926a5
CY
21112012-06-27 Chong Yidong <cyd@gnu.org>
2112
2113 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2114
ed6b3510
JW
21152012-06-26 John Wiegley <johnw@newartisans.com>
2116
1ec4b7b2 2117 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2118 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2119
ed6b3510
JW
2120 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2121 when building with Clang.
2122
8edd4a2b
SM
21232012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2124
2125 * eval.c (Fapply): Allow calling it with a single argument.
2126
f6f62d1b
EZ
21272012-06-26 Eli Zaretskii <eliz@gnu.org>
2128
2129 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2130 _stricmp and _strnicmp.
2131 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2132
62efea5e
DA
21332012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2134
2135 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2136 allocated window.
2137 (allocate_process): Likewise for new process.
8edd4a2b 2138 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2139 (allocate_frame): Likewise.
2140 * frame.c (make_frame): Omit redundant initialization.
2141 * window.c (make_parent_window): Use memset.
2142 (make_window): Omit redundant initialization.
2143 * process.c (make_process): Omit redundant initialization.
2144 * terminal.c (create_terminal): Likewise.
2145
42997f4d
DA
21462012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2147
2148 * term.c (delete_tty): Remove redundant call to memset.
2149
1130ecfc
DA
21502012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2151
2152 * alloc.c: Remove build_string.
2153 * lisp.h: Define build_string as static inline. This provides
2154 a better opportunity to optimize away calls to strlen when the
2155 function is called with compile-time constant argument.
2156 * image.c (imagemagick_error): Convert to build_string.
2157 * w32proc.c (sys_spawnve): Likewise.
2158 * xterm.c (x_term_init): Likewise.
2159
cf38a720
PE
21602012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2161
99027bdd
PE
2162 Use sprintf return value instead of invoking strlen on result.
2163 In the old days this wasn't portable, since some sprintf
2164 implementations returned char *. But they died out years ago and
2165 Emacs already assumes sprintf returns int.
2166 Similarly for float_to_string.
2167 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2168 * ccl.c (ccl_driver):
2169 * character.c (string_escape_byte8):
2170 * data.c (Fnumber_to_string):
2171 * doprnt.c (doprnt):
2172 * print.c (print_object):
2173 * xdisp.c (message_dolog):
2174 * xfns.c (syms_of_xfns):
2175 Use sprintf or float_to_string result to avoid need to call strlen.
2176 * data.c (Fnumber_to_string):
2177 Use make_unibyte_string, since the string must be ASCII.
2178 * lisp.h, print.c (float_to_string): Now returns int length.
2179 * term.c (produce_glyphless_glyph):
2180 Use sprintf result rather than recomputing it.
2181
cf38a720
PE
2182 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2183 * Makefile.in (ALL_CFLAGS):
2184 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2185 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2186
3511c784
DA
21872012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2188
0a08eb21 2189 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2190 strcasecmp if available.
2191 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2192
fb7da12e
AS
21932012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2194
2195 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2196 Avoid comma operator.
2197 * menu.c (push_submenu_start, push_submenu_end)
2198 (push_left_right_boundary, push_menu_pane): Likewise.
2199 * msdos.c (dos_rawgetc): Likewise.
2200
afa2ffd8
DA
22012012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2202
2203 * xfns.c (xic_create_fontsetname): Remove redundant calls
2204 to memset.
2205
b3b4476b
PE
22062012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2207
4495ff38
PE
2208 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2209 sprintf already null-terminates its output.
2210
b3b4476b
PE
2211 * xfns.c (x_window): Remove redundant cast.
2212
b00876c9
DA
22132012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2214
2215 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2216 `const char *' to `char *' to avoid compiler warning.
2217
d188e26b
PE
22182012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2219
885d1d74
PE
2220 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2221 instead of truncating it to 63 (admittedly a generous limit).
2222
d188e26b
PE
2223 * process.c: Fix spelling and caps in comments.
2224
e2f560b1
DN
22252012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2226
e86db54b 2227 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2228 * sysdep.c (setpgrp): Remove definition, not used in this file.
2229
7583a3a1
JB
22302012-06-24 Juanma Barranquero <lekktu@gmail.com>
2231
2232 * makefile.w32-in: Update dependencies.
2233
696056c2
EZ
22342012-06-24 Eli Zaretskii <eliz@gnu.org>
2235
2236 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2237 (SYSTIME_H): Add nt/inc/sys/time.h.
2238
2239 * systime.h [WINDOWSNT]: Include sys/time.h.
2240
2241 * s/ms-w32.h (struct timespec): Definition moved from
2242 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2243
845ca893
PE
22442012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2245
2246 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2247 * buffer.h (buffer_slot_type_mismatch):
2248 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2249 * eval.c (unwind_to_catch):
2250 * image.c (my_png_error, my_error_exit):
2251 * keyboard.c (quit_throw_to_read_char, user_error)
2252 (Fexit_recursive_edit, Fabort_recursive_edit):
2253 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2254 (wrong_type_argument, buffer_overflow, __executable_start)
2255 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2256 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2257 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2258 (fatal):
2259 (child_setup) [!DOS_NT]:
2260 * lread.c (end_of_file_error, invalid_syntax):
2261 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2262 * puresize.h (pure_write_error):
2263 * search.c (matcher_overflow):
2264 * sound.c (sound_perror, alsa_sound_perror):
2265 * sysdep.c, syssignal.h (croak):
2266 * term.c (maybe_fatal, vfatal):
2267 * textprop.c (text_read_only):
2268 * undo.c (user_error):
2269 * unexmacosx.c (unexec_error):
2270 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2271 Use _Noreturn rather than NO_RETURN.
2272 No need for separate decl merely because of _Noreturn.
2273 * sound.c (sound_warning, parse_sound):
2274 Remove unnecessary forward decls.
2275
f1dd8073
PE
22762012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2277
2278 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2279 * lisp.h (WAIT_READING_MAX): New macro.
2280 * dispnew.c (Fsleep_for, sit_for):
2281 * keyboard.c (kbd_buffer_get_event):
2282 * process.c (Faccept_process_output):
2283 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2284 This improves on the previous patch, which introduced a bug
2285 when time_t is unsigned and as wide as intmax_t.
2286 See <http://bugs.gnu.org/9000#51>.
2287
b82c1755
EZ
22882012-06-23 Eli Zaretskii <eliz@gnu.org>
2289
2290 * dispnew.c (sit_for, Fsleep_for):
2291 * keyboard.c (kbd_buffer_get_event):
2292 * process.c (Faccept_process_output): Avoid compiler warnings when
2293 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2294
ca300656
JB
22952012-06-23 Juanma Barranquero <lekktu@gmail.com>
2296
049ec95b
JB
2297 * makefile.w32-in: Update dependencies.
2298
ca300656
JB
2299 * w32.c (ltime): Add return type and declare static.
2300 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2301
db7b8d06
PE
23022012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2303
2304 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2305 Privately reported by Herbert J. Skuhra.
2306 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2307 All uses changed.
2308 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2309 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2310
0bd8297f
EZ
23112012-06-23 Eli Zaretskii <eliz@gnu.org>
2312
96512555
EZ
2313 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2314 last argument of make_unibyte_string.
2315
0bd8297f
EZ
2316 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2317 language ID in the event parameters.
2318
2319 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2320 event.code, not the obscure "character set ID".
2321
63def6b6
CY
23222012-06-23 Chong Yidong <cyd@gnu.org>
2323
2324 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2325
e8a02204
EZ
23262012-06-23 Eli Zaretskii <eliz@gnu.org>
2327
388cdec0
EZ
2328 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2329 * w32.c (fdutimens): New function.
2330
2331 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2332
2333 * s/ms-w32.h (pselect): Redirect to sys_select.
2334
2335 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2336
e8a02204
EZ
2337 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2338 in the logic of incrementing and decrementing the value of
2339 use_relocatable_buffers.
2340
d054f3fb
PE
23412012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2342
2343 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2344 Privately reported by Herbert J. Skuhra.
2345 [__FreeBSD__]: Remove "*/" typo after "#include".
2346 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2347 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2348 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2349 Don't assume EMACS_TIME and struct timeval are the same type.
2350
d35af63c
PE
23512012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2352
2353 Support higher-resolution time stamps (Bug#9000).
2354 The time stamps are only nanosecond-resolution at the C level,
2355 since that's the best that any real-world system supports now.
2356 But they are picosecond-resolution at the Lisp level, as that's
2357 easy, and leaves room for future OS improvements.
2358
2359 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2360 (LIBES): Use it.
2361
2362 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2363 Don't get current time unless it's needed.
2364
2365 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2366 now provides it if it's absent.
2367 (start_atimer): Port to higher-res time stamps.
2368 Check for time stamp overflow. Don't get current time more
2369 often than is needed.
2370
2371 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2372 Include systime.h, not time.h.
2373 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2374
2375 * dired.c: Include stat-time.h.
2376 (Ffile-attributes): File times now have higher resolution.
2377
2378 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2379 (struct image): Timestamp now has higher resolution.
2380
2381 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2382 has at least microseconds now. All uses removed.
2383 (update_frame, update_single_window, update_window, update_frame_1)
2384 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2385
2386 * editfns.c (time_overflow): Now extern.
2387 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2388 (float-time, Fformat_time_string, Fcurrent_time_string)
2389 (Fcurrent_time_zone): Accept and generate higher-resolution
2390 time stamps.
2391 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2392 (decode_time_components, lisp_seconds_argument): New functions.
2393 (make_time): Now static.
2394 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2395 Report an error if the time is invalid, rather than having the caller
2396 do that.
2397
2398 * fileio.c: Include <stat-time.h>
2399 (Fcopy_file): Copy higher-resolution time stamps.
2400 Prefer to set the time stamp via a file descriptor if that works.
2401 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2402 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2403 (Fvisited_file_modtime, Fset_visited_file_modtime):
2404 Support higher-resolution time stamps.
2405
2406 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2407
2408 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2409
2410 * image.c (prepare_image_for_display, clear_image_cache)
2411 (lookup_image): Port to higer-resolution time stamps.
2412
2413 * keyboard.c (start_polling, bind_polling_period):
2414 Check for time stamp overflow.
2415 (read_char, kbd_buffer_get_event, timer_start_idle)
2416 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2417 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2418 Port to higher-resolution time stamps. Do not assume time_t is signed.
2419 (decode_timer): New function. Timers are now vectors of length 9,
2420 not 8, to accommodate the picosecond component.
2421 (timer_check_2): Use it.
2422
2423 * nsterm.m (select_timeout, timeval_subtract): Remove.
2424 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2425 as they're a bit more accurate and handle overflow better.
2426 (ns_select): Change prototype to be compatible with pselect.
2427 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2428 * nsterm.h (ns_select): Adjust prototype.
2429
2430 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2431 us-resolution time stamps.
2432 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2433
2434 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2435
2436 * lisp.h (time_overflow): New decl.
2437 (wait_reading_process_output): First arg is now intmax_t, not int,
2438 to accommodate larger waits.
2439
2440 * process.h (struct Lisp_Process.read_output_delay):
2441 Now counts nanoseconds, not microseconds.
2442 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2443 EMACS_HAS_USECS.
2444 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2445 (wait_reading_process_output):
2446 Port to ns-resolution time stamps.
2447 (Faccept_process_output, wait_reading_process_output):
2448 Check for time stamp overflow. Do not assume time_t is signed.
2449 (select_wrapper): Remove; we now use pselect.
2450 (Fprocess_attributes): Now generates ns-resolution time stamps.
2451
2452 * sysdep.c: Include utimens.h. Don't include utime.h
2453 or worry about struct utimbuf; gnulib does that for us now.
2454 (gettimeofday): Remove; gnulib provides a substitute.
2455 (make_timeval): New function.
2456 (set_file_times): Now sets ns-resolution time stamps.
2457 New arg FD; all uses changed.
2458 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2459 (system_process_attributes):
2460 Now returns ns-resolution time stamp. All uses changed.
2461 Check for time stamp overflow.
2462
2463 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2464 provides a substitute now.
2465
2466 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2467 since it guarantees struct timespec.
2468 (EMACS_TIME): Now struct timespec, so that we can support
2469 ns-resolution time stamps.
2470 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2471 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2472 (EMACS_USECS): Remove.
2473 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2474 so multiply the arg by 1000 before storing it.
2475 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2476 New macros.
2477 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2478 Port to ns-resolution time stamps.
2479 (EMACS_TIME_NEG_P): Remove; replaced by....
2480 (EMACS_TIME_SIGN): New macro.
2481 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2482 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2483 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2484 (make_timeval, make_lisp_time, decode_time_components): New decls.
2485 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2486 that it mishandled time_t overflow. You can't compare by subtracting!
2487 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2488 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2489
2490 * term.c: Include <sys/time.h>.
2491 (timeval_to_Time): New function, for proper overflow wraparound.
2492 (term_mouse_position, term_mouse_click): Use it.
2493
2494 * undo.c (record_first_change): Support higher-resolution time stamps
2495 in the undo buffer.
2496 (Fprimitive_undo): Use them when restoring time stamps.
2497
2498 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2499 (w32_get_internal_run_time):
2500 Port to higher-resolution Emacs time stamps.
2501 (ltime): Now accepts single 64-bit integer, as that's more convenient
2502 for callers.
2503
2504 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2505
2506 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2507 for compatibility with pselect. Support ns-resolution time stamps.
2508
2509 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2510
2511 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2512 Check for time stamp overflow, and support ns-resolution time stamps.
2513
2514 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2515 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2516 (timeval_subtract): Remove; no longer needed.
2517 (XTflash, XTring_bell, x_wait_for_event):
2518 Port to ns-resolution time stamps. Don't assume time_t is signed.
2519
b6a92dfe
CY
25202012-06-22 Chong Yidong <cyd@gnu.org>
2521
2522 * xdisp.c (x_consider_frame_title): Revert last change.
2523
d251c37c
EZ
25242012-06-22 Eli Zaretskii <eliz@gnu.org>
2525
2526 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2527 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2528 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2529 staticidx goes up to 1597 out of 1600 = 0x640.)
2530
f10deafb
PE
25312012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2532
2533 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2534 Otherwise, the umask might be mistakenly 0 while handling input signals.
2535
ec6de1e2
SM
25362012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2537
2538 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2539
28be1ada
DA
25402012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2541
2542 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2543 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2544 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2545 access to `contents' member of Lisp_Vector objects with AREF and ASET
2546 where appropriate.
2547
c6bf3022
CY
25482012-06-19 Chong Yidong <cyd@gnu.org>
2549
2550 * frame.c (delete_frame): When selecting a frame on a different
2551 text terminal, do not alter the terminal's top-frame.
2552
2553 * xdisp.c (format_mode_line_unwind_data): Record the target
2554 frame's selected window and its terminal's top-frame.
2555 (unwind_format_mode_line): Restore them.
2556 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2557 Callers changed.
2558 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2559 since tty frames can be explicitly named.
2560 (prepare_menu_bars): Likewise.
2561
2562 * term.c (Ftty_top_frame): New function.
2563
defd4196
PE
25642012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2565
2566 Port byte-code-meter to modern targets.
2567 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2568 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2569 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2570 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2571 (METER_1, METER_2): Simplify.
2572
1053a871
SM
25732012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2574
2575 * data.c (Fdefalias): Return `symbol' (bug#11686).
2576
b7e8d081
MR
25772012-06-18 Martin Rudalics <rudalics@gmx.at>
2578
2579 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2580 gets killed during executing of this function (Bug#11665).
2581 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2582 (Vkill_buffer_query_functions): In doc-string say that functions
2583 run by this hook should not change the current buffer.
2584
7ea2b339
PE
25852012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2586
2587 Fix recently-introduced process.c problems found by static checking.
2588 * process.c (write_queue_push, write_queue_pop, send_process):
2589 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2590 (write_queue_pop): Fix pointer signedness problem.
2591 (send_process): Remove unused local.
2592
96a313a1
CY
25932012-06-17 Chong Yidong <cyd@gnu.org>
2594
2595 * xdisp.c (redisplay_internal): No need to redisplay terminal
2596 frames that are not on top.
2597
20ca2e94
TN
25982012-06-17 Troels Nielsen <bn.troels@gmail.com>
2599
2600 * process.c (make_process): Initialize write_queue.
2601 (write_queue_push, write_queue_pop): New functions.
2602 (send_process): Use them to maintain correct ordering of process
2603 writes (Bug#10815).
2604
9a900ca9
PE
26052012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2606
310fbfa8
PE
2607 * lisp.h (eassert): Assume C89 or later.
2608 This removes the need for CHECK.
2609 (CHECK): Remove. Its comments about always evaluating its
2610 argument were confusing, as 'eassert' typically does not evaluate
2611 its argument.
2612
27bb1ca4
PE
2613 * coding.c (produce_chars): Use ptrdiff_t, not int.
2614
9a900ca9
PE
2615 * xterm.c (x_draw_underwave): Check for integer overflow.
2616 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2617
41b7f8bc 26182012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2619
2620 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2621 referenced (Bug#11583).
2622
9b0e3eba
AA
26232012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2624
2625 Implement wave-style variant of underlining.
2626 * dispextern.h (face_underline_type): New enum.
2627 (face): Add field for underline type.
2628 * nsterm.m (ns_draw_underwave): New function.
2629 (ns_draw_text_decoration): Use it.
2630 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2631 New functions.
2632 (x_draw_glyph_string): Use them.
2633 * xfaces.c (Qline, Qwave): New Lisp objects.
2634 (check_lface_attrs, merge_face_ref)
1053a871
SM
2635 (Finternal_set_lisp_face_attribute, realize_x_face):
2636 Handle wave-style underline face attributes.
9b0e3eba
AA
2637 * xterm.c (x_draw_underwave): New function.
2638 (x_draw_glyph_string): Use it.
2639
0fb52f11
JB
26402012-06-16 Juanma Barranquero <lekktu@gmail.com>
2641
2642 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2643 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2644 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2645 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2646 ($(BLD)/w32select.$(O)): Update dependencies.
2647
e5560ff7
AS
26482012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2649
2650 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2651 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2652 * character.c (_fetch_multibyte_char_p): Remove.
2653 * alloc.c: Include "character.h" before "buffer.h".
2654 * bidi.c: Likewise.
2655 * buffer.c: Likewise.
2656 * bytecode.c: Likewise.
2657 * callint.c: Likewise.
2658 * callproc.c: Likewise.
2659 * casefiddle.c: Likewise.
2660 * casetab.c: Likewise.
2661 * category.c: Likewise.
2662 * cmds.c: Likewise.
2663 * coding.c: Likewise.
2664 * composite.c: Likewise.
2665 * dired.c: Likewise.
2666 * dispnew.c: Likewise.
2667 * doc.c: Likewise.
2668 * dosfns.c: Likewise.
2669 * editfns.c: Likewise.
2670 * emacs.c: Likewise.
2671 * fileio.c: Likewise.
2672 * filelock.c: Likewise.
2673 * font.c: Likewise.
2674 * fontset.c: Likewise.
2675 * fringe.c: Likewise.
2676 * indent.c: Likewise.
2677 * insdel.c: Likewise.
2678 * intervals.c: Likewise.
2679 * keyboard.c: Likewise.
2680 * keymap.c: Likewise.
2681 * lread.c: Likewise.
2682 * macros.c: Likewise.
2683 * marker.c: Likewise.
2684 * minibuf.c: Likewise.
2685 * nsfns.m: Likewise.
2686 * nsmenu.m: Likewise.
2687 * print.c: Likewise.
2688 * process.c: Likewise.
2689 * regex.c: Likewise.
2690 * region-cache.c: Likewise.
2691 * search.c: Likewise.
2692 * syntax.c: Likewise.
2693 * term.c: Likewise.
2694 * textprop.c: Likewise.
2695 * undo.c: Likewise.
2696 * unexsol.c: Likewise.
2697 * w16select.c: Likewise.
2698 * w32fns.c: Likewise.
2699 * w32menu.c: Likewise.
2700 * window.c: Likewise.
2701 * xdisp.c: Likewise.
2702 * xfns.c: Likewise.
2703 * xmenu.c: Likewise.
2704 * xml.c: Likewise.
2705 * xselect.c: Likewise.
2706
2f07e6af
EZ
27072012-06-16 Eli Zaretskii <eliz@gnu.org>
2708
1053a871
SM
2709 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2710 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2711 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2712 row.
2713 (handle_face_prop): Use chunk-relative overlay string index when
2714 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2715 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2716 the rightmost. (Bug#11720)
2f07e6af 2717
29b83cec
AS
27182012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2719
2720 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2721 (CATEGORY_MEMBER): Enforce 1/0 value.
2722 * category.c (_temp_category_set): Remove.
2723
4c5501e9
EZ
27242012-06-16 Eli Zaretskii <eliz@gnu.org>
2725
2726 * window.c (Fdelete_other_windows_internal)
2727 (Fdelete_window_internal): Don't access frame's mouse highlight
2728 info of the initial frame. (Bug#11677)
2729
2b570124
PE
27302012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2731
e93864f9
PE
2732 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2733 Assume USE_2_TAGS_FOR_INTS.
2734 (xreload): Adjust $tagmask width to match recent lisp.h change.
2735
2b570124
PE
2736 Simplify lisp.h in minor ways that should not affect code.
2737 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2738 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2739 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2740 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2741 (INTTYPEBITS): New macro, for clarity.
2742 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2743 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2744 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2745 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2746 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2747
81755f69
JB
27482012-06-13 Juanma Barranquero <lekktu@gmail.com>
2749
2750 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2751
16192a57
GM
27522012-06-13 Glenn Morris <rgm@gnu.org>
2753
2754 * s/bsd-common.h (BSD4_3):
2755 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2756
646b5f55
AS
27572012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2758
2759 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2760 instead of union.
2761 (XLI, XIL): Define.
1053a871
SM
2762 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2763 Use them.
2764 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2765 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2766 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2767 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2768 * frame.c (delete_frame): Remove outdated comment.
2769 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2770 USE_LISP_UNION_TYPE.
2771 (Fw32_unregister_hot_key): Likewise.
2772 (Fw32_toggle_lock_key): Likewise.
2773 * w32menu.c (add_menu_item): Likewise.
2774 (w32_menu_display_help): Use XIL instead of checking
2775 USE_LISP_UNION_TYPE.
2776 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2777 (init_heap): Likewise.
2778 * w32term.c (w32_read_socket): Update comment.
2779
1d3823c9
GM
27802012-06-13 Glenn Morris <rgm@gnu.org>
2781
c62ff706
GM
2782 * s/usg5-4-common.h, src/s/unixware.h:
2783 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2784
1d3823c9
GM
2785 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2786
bfe3e0a2
PE
27872012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2788
2789 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2790 * alloc.c (make_number) [!defined make_number]:
2791 Remove, as lisp.h always defines this now.
2792 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2793 (roundup_size): Verify that it is a power of 2.
2794 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2795 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2796 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2797 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2798 USE_LSB_TAG now is always defined to be either 0 or 1.
2799 All uses changed.
2800 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2801 code works fine either way, and efficiency is not a concern here,
2802 as the union type is for debugging, not for production.
2803 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2804 Use an inline function on all platforms when using the union type,
2805 since this is simpler and 'static inline' can be used portably
2806 within Emacs now.
2807 (LISP_INITIALLY_ZERO): New macro.
2808 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2809 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2810
45fa9c0f
GM
28112012-06-12 Glenn Morris <rgm@gnu.org>
2812
b4492cba
GM
2813 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2814
2815 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2816
45fa9c0f
GM
2817 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2818 Move BROKEN_SIGIO to configure.
2819
2820 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2821 Move NO_TERMIO to configure.
2822
0e25d334
CY
28232012-06-12 Chong Yidong <cyd@gnu.org>
2824
2825 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2826 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2827 MagickExportImagePixels is undefined.
2828
43682bb6
PE
28292012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2830
2831 * image.c (imagemagick_load_image): Remove unused label.
2832
a9be7d2b
GM
28332012-06-11 Glenn Morris <rgm@gnu.org>
2834
2835 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2836 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2837 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2838 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2839
3017f87f
SM
28402012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2841
2842 * alloc.c (make_byte_code): New function.
2843 (Fmake_byte_code): Use it. Don't purify here.
2844 * lread.c (read1): Use it as well to avoid extra allocation.
2845
1b9b4cf4
CY
28462012-06-11 Chong Yidong <cyd@gnu.org>
2847
2848 * image.c (imagemagick_load_image): Implement transparency.
2849
95988fcf
AS
28502012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2851
2852 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2853 account for preceding backslashes. (Bug#11663)
2854
cd4eb164
CY
28552012-06-09 Chong Yidong <cyd@gnu.org>
2856
2857 * term.c: Support italics in capable terminals (Bug#9652).
2858 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2859 (turn_on_face): Output using TS_enter_italic_mode if available.
2860 Don't handle unused blinking and alt-charset cases.
2861 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2862 and tty_alt_charset_p cases.
2863 (tty_capable_p, init_tty): Support italics.
2864
2865 * termchar.h (struct tty_display_info): Add field for italics.
2866 Remove unused blink field.
2867
2868 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2869 Handle slant.
2870
2871 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2872 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2873 tty_alt_charset_p. Add tty_italic_p.
2874
ff88beb8
MA
28752012-06-09 Michael Albinus <michael.albinus@gmx.de>
2876
2877 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2878 dbus_type_is_basic if available.
2879 (xd_extract_signed, xd_extract_unsigned): Rename from
2880 extract_signed and extract_unsigned, respectively. Adapt callers.
2881
44286096
CY
28822012-06-09 Chong Yidong <cyd@gnu.org>
2883
1682701f
CY
2884 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2885
44286096
CY
2886 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2887 case (Bug#9752).
2888
d86feb17
PE
28892012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2890
2891 * xdisp.c (vmessage): Treat frame message as multibyte.
2892 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2893 would generate the diagnostic "Making \302\247 buffer-local while
2894 let-bound!".
2895
d5c20fe8
EZ
28962012-06-08 Eli Zaretskii <eliz@gnu.org>
2897
2898 * dispnew.c (showing_window_margins_p): Undo last change, which
2899 was done due to an inadvertent commit.
2900 (adjust_frame_glyphs_for_frame_redisplay): Do call
2901 showing_window_margins_p.
2902
513749ee
SM
29032012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2904
2905 * eval.c (Fmake_var_non_special): New primitive.
2906 (syms_of_eval): Defsubr it.
2907 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2908
d4a8f5c1
JB
29092012-06-08 Juanma Barranquero <lekktu@gmail.com>
2910
2911 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2912 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2913
8bbbc977
EZ
29142012-06-08 Eli Zaretskii <eliz@gnu.org>
2915
2916 * alloc.c (allocate_vectorlike): Fix last change.
2917
f3372c87
DA
29182012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2919
2920 Block-based vector allocation of small vectors.
2921 * lisp.h (struct vectorlike_header): New field `nbytes',
2922 adjust comment accordingly.
2923 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2924 to denote vector blocks. Adjust users (live_vector_p,
2925 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2926 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2927 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2928 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2929 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2930 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2931 (roundup_size): New constant.
2932 (struct vector_block): New data type.
2933 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2934 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2935 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2936 (sweep_vectors): New functions.
2937 (allocate_vectorlike): Return `zero_vector' as the only vector of
2938 0 items. Allocate new vector from block if vector size is less than
2939 or equal to VBLOCK_BYTES_MAX.
2940 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2941 (init_alloc_once): Add call to init_vectors.
2942
4f18a4ed
SM
29432012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2944
2945 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2946
86f158bc
PE
29472012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2948
2949 * doprnt.c (doprnt): Truncate multibyte char correctly.
2950 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2951 would mishandle a string argument "Xc" if X was a multibyte
2952 character of length 2: it would truncate after X's first byte
2953 rather than including all of X.
2954
c5cfcbe0
CY
29552012-06-06 Chong Yidong <cyd@gnu.org>
2956
2957 * buffer.c (word_wrap): Doc fix.
2958
c05cf390
PE
29592012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2960
2961 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2962
0c3461de
GM
29632012-06-03 Glenn Morris <rgm@gnu.org>
2964
2965 * xdisp.c (tool-bar-style): Doc fix.
2966
c71232db
UM
29672012-06-03 Ulrich Müller <ulm@gentoo.org>
2968
2969 * Makefile.in (PAXCTL): Define.
2970 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2971 binary via PaX flags if the paxctl utility is available.
2972 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2973 Restore PaX flags to their default. (Bug#11398)
2974
383f7350
CY
29752012-06-03 Chong Yidong <cyd@gnu.org>
2976
2977 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2978 buffer (Bug#11226).
2979
5f2c76c6
CY
29802012-06-03 Chong Yidong <cyd@gnu.org>
2981
2982 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2983 (note_mode_line_or_margin_highlight): If there is no help echo,
2984 use mode-line-default-help-echo. Handle the case where the mouse
2985 position is past the end of the mode line string.
2986
2987 * buffer.c (buffer_local_value_1): New function, split from
2988 Fbuffer_local_value; can return Qunbound.
2989 (Fbuffer_local_value): Use it.
2990 (Vmode_line_format): Docstring tweaks.
2991
773d47f6
PE
29922012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2993
2994 * sysdep.c (system_process_attributes): Improve comment.
2995
f2d6a3df
SM
29962012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2997
2998 * keyboard.c: Export real-this-command to Elisp.
2999 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3000 and DEFVAR it. Update all users.
3001
63810350
PE
30022012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3003
7bd5c1f4
PE
3004 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3005
63810350
PE
3006 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3007 Convert pctcpu and pctmem to Lisp float properly.
3008 Let the compiler fold better, as 100.0/0x8000 is exact.
3009
a2821611
AS
30102012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3011
3012 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3013 cons_block.
3014
5fceba1d
PE
30152012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3016
3017 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3018
c98ff5dd
DA
30192012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3020
3021 For a 'struct window', replace some Lisp_Object fields to
3022 bitfields where appropriate, remove unused fields.
3023 * window.h (struct window): Remove unused 'last_mark_x' and
3024 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3025 change it's type from Lisp_Object to bitfield.
3026 Change type of 'force_start', 'optional_new_start',
3027 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3028 fields from Lisp_Object to bitfield. Adjust users accordingly.
3029
ca34e0be
PE
30302012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3031
3032 Pacify gcc -Wdouble-precision when using Xaw.
3033 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3034 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3035 Use 'float' consistently, rather than 'float' in most places
3036 and 'double' in a couple of places.
3037
efc00ab1 30382012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3039
3040 * xdisp.c (handle_stop): Detect whether we have overlay strings
3041 loaded by testing it->current.overlay_string_index to be
3042 non-negative, instead of checking whether n_overlay_strings is
3043 positive. (Bug#11587)
3044
efc00ab1 30452012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3046
3047 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3048
3049 * doc.c (Fsubstitute_command_keys): Doc fix.
3050
efc00ab1 30512012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3052
3053 * search.c (search_buffer): Remove calls to
3054 r_alloc_inhibit_buffer_relocation, as it is now called by
3055 maybe_unify_char, which was the cause of relocation of buffer text
3056 in bug#11519.
3057
efc00ab1 30582012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3059
3060 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3061 for the duration of call to load_charset, to avoid problems with
3062 callers of maybe_unify_char that access buffer text through C
3063 pointers.
3064
3065 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3066 decrement the inhibition flag, instead of just setting or
3067 resetting it.
3068
ba93a187
PE
30692012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3070
3071 Remove obsolete '#define static' cruft.
3072 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3073 This #undef was "temporary" in 2000; it is no longer needed
3074 now that '#define static' has gone away.
3075 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3076 (gray_bitmap_bits): Remove; no longer needed.
3077 All uses replaced with definiens.
3078 * xterm.c: Include "bitmaps/gray.xbm".
3079
9e4bf381
PE
30802012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3081
3082 Clean up __executable_start, monstartup when --enable-profiling.
3083 The following changes affect the code only when profiling.
3084 * dispnew.c (__executable_start): Rename from safe_bcopy.
3085 Define only on platforms that need it.
3086 * emacs.c: Include <sys/gmon.h> when profiling.
3087 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3088 (__executable_start): Remove decl, since lisp.h does it now.
3089 (safe_bcopy): Remove decl; no longer has that name.
3090 (main): Coalesce #if into single bit of code, for simplicity.
3091 Cast pointers to uintptr_t, since standard libraries want integers
3092 and not pointers.
3093 * lisp.h (__executable_start): New decl.
3094
32d72c2f
GM
30952012-05-31 Glenn Morris <rgm@gnu.org>
3096
3097 * image.c (Fimagemagick_types): Doc fix.
3098
baac5bc7
JM
30992012-05-30 Jim Meyering <meyering@redhat.com>
3100
3101 * callproc.c (Fcall_process_region): Include directory component
3102 in mkstemp error message (Bug#11586).
3103
72cb32cf
PE
31042012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3105
3106 * alloc.c, lisp.h (make_pure_vector): Now static.
3107
61b108cc
SM
31082012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3109
3110 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3111 Move to byte-run.el.
3112 (Fautoload): Do the hash-doc more carefully.
3113 * data.c (Fdefalias): Purify definition, except for keymaps.
3114 (Qdefun): Move from eval.c.
3115 * lisp.h (Qdefun): Remove.
3116 * lread.c (read1): Tiny simplification.
3117
471fe23d
TN
31182012-05-29 Troels Nielsen <bn.troels@gmail.com>
3119
934f3f58 3120 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3121 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3122 Bug#9642, but explicitly check that the buffer the overlay would
3123 be moved to is live and rearrange lines to make sure that errors
3124 will not put the overlay in an inconsistent state.
3125 (Fdelete_overlay): Cosmetics.
3126
85d0efd1
EZ
31272012-05-28 Eli Zaretskii <eliz@gnu.org>
3128
3129 * w32term.c (my_bring_window_to_top): New function.
3130 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3131 could be different from the original one.
3132 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3133 (Bug#11513)
3134
3135 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3136 by calling BringWindowToTop.
3137
3138 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3139 (WM_EMACS_END): Increase by one.
3140
da92a98c
PE
31412012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3142
3143 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3144 This avoids undefined behavior that might cause the eassert
3145 to not catch an out-of-range value.
3146
74d1f848
JB
31472012-05-28 Juanma Barranquero <lekktu@gmail.com>
3148
3149 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3150 Update dependencies.
3151
9e1a06fc
EZ
31522012-05-27 Eli Zaretskii <eliz@gnu.org>
3153
3154 * bidi.c (bidi_mirror_char): Fix last change.
3155
f3dd7312
AS
31562012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3157
3158 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3159 when referring to sectname field in printf format.
3160
81899c91
PE
31612012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3162
57b81a9f
PE
3163 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3164 Only r_alloc_inhibit_buffer_relocation needed to be added;
3165 the others were already declared.
3166
81899c91
PE
3167 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3168 before checking whether it's out of range. Put the check inside
3169 eassert. See
3170 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3171
33017faf 31722012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3173
3174 * callproc.c (Fcall_process): Restore a line that was accidentally
3175 commented out in the 2011-02-13 change (bug#11547).
3176
33017faf 31772012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3178
3179 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3180 defined on ralloc.c.
3181
3182 * buffer.c [REL_ALLOC]: Remove prototypes of
3183 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3184 they are now on lisp.h.
3185
3186 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3187
3188 * search.c (search_buffer): Use it to inhibit relocation of buffer
3189 text while re_search_2 is doing its job, because re_search_2 is
3190 passed C pointers to buffer text. (Bug#11519)
3191
23415acf
EZ
3192 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3193 Update value to 24.
3194
44e27368
EZ
3195 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3196 state after an additional call to move_it_in_display_line_to, keep
3197 the values of it->max_ascent and it->max_descent found for the
3198 entire line.
3199 (pos_visible_p): Revert the comparison against bottom_y to what it
3200 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3201 (Bug#11464)
3202
c1892f11
PE
32032012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3204
3205 Fix coding-related core dumps with gcc -ftrapv.
3206 The code was computing A - B, where A and B are pointers, and B is
3207 random garbage. This can lead to core dumps on platforms that
3208 have special pointer registers, and it also leads to core dumps on
3209 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3210 A - B only when B is initialized properly.
3211 * coding.c (coding_set_source, coding_set_destination): Return void.
3212 (coding_change_source, coding_change_destinations): New functions,
3213 with the old behaviors of coding_set_source and coding_set_destination.
3214 All callers that need an offset changed to use these new functions.
3215
eb7afdad
GM
32162012-05-26 Glenn Morris <rgm@gnu.org>
3217
3218 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3219
f12fdf02
EZ
32202012-05-26 Eli Zaretskii <eliz@gnu.org>
3221
53a63be6 3222 Extend mouse support on W32 text-mode console.
61b108cc
SM
3223 * xdisp.c (draw_row_with_mouse_face):
3224 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3225
eb3f6f01 3226 * w32console.c: Include window.h.
61b108cc
SM
3227 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3228 New functions.
eb3f6f01
EZ
3229 (initialize_w32_display): Initialize mouse-highlight data.
3230
53a63be6
EZ
3231 * w32inevt.c: Include termchar.h and window.h.
3232 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3233 moves, call note_mouse_highlight. If help_echo changed, call
3234 gen_help_event to produce help-echo message in the echo area.
3235 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3236 highlight info.
3237
4cfd81f6
PE
32382012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3239
3240 * lread.c (read1): Simplify slightly to avoid an overflow warning
3241 with GCC 4.7.0 on x86-64.
3242
4446092a
EZ
32432012-05-26 Eli Zaretskii <eliz@gnu.org>
3244
3245 * bidi.c (bidi_mirror_char): Revert last change: an int is
3246 definitely wide enough here.
3247
42b2a986 32482012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3249
42b2a986 3250 Fix integer width and related bugs (Bug#9874).
eb106a49 3251 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3252 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3253 (string_bytes, check_sblock, allocate_string_data):
3254 (compact_small_strings, Fmake_bool_vector, make_string)
3255 (make_unibyte_string, make_multibyte_string)
3256 (make_string_from_bytes, make_specified_string)
3257 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3258 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3259 (mark_vectorlike):
3260 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3261 (allocate_pseudovector):
3262 Use int, not EMACS_INT, where int is wide enough.
3263 (inhibit_garbage_collection, Fgarbage_collect):
3264 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3265 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3266 int might not be wide enough.
3267 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3268 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3269 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3270 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3271 (bidi_level_of_next_char, bidi_move_to_visually_next):
3272 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3273 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3274 (Fkill_buffer, Fset_buffer_major_mode)
3275 (advance_to_char_boundary, Fbuffer_swap_text)
3276 (Fset_buffer_multibyte, overlays_at, overlays_in)
3277 (overlay_touches_p, struct sortvec, record_overlay_string)
3278 (overlay_strings, recenter_overlay_lists)
3279 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3280 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3281 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3282 (Foverlay_recenter, last_overlay_modification_hooks_used)
3283 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3284 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3285 (validate_region): Omit unnecessary test for b <= e,
3286 since that's guaranteed by the previous test.
d311d28c
PE
3287 (adjust_overlays_for_delete): Avoid pos + length overflow.
3288 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3289 (report_overlay_modification):
3290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3291 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3292 Omit pointer cast, which isn't needed anyway, and doesn't work
3293 after the EMACS_INT -> ptrdiff_t change.
02481186 3294 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3295 * buffer.h: Adjust decls to match defn changes elsewhere.
3296 (struct buffer_text, struct buffer):
3297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3298 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3299 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3300 not int, to avoid needless 32-bit limit on 64-bit hosts.
3301 (exec_byte_code): Use tighter memory-full test, one that checks
3302 for alloca overflow. Don't compute the address of the object just
3303 before an array, as that's not portable. Use EMACS_INT, not
3304 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3305 * callint.c (Fcall_interactively):
3306 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3307 * callproc.c (call_process_kill, Fcall_process):
3308 Don't assume pid_t fits into an Emacs fixnum.
3309 (call_process_cleanup, Fcall_process, child_setup):
3310 Don't assume pid_t fits into int.
3311 (call_process_cleanup, Fcall_process, delete_temp_file)
3312 (Fcall_process_region):
3313 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3314 (Fcall_process): Simplify handling of volatile integers.
3315 Use int, not EMACS_INT, where int will do.
3316 * casefiddle.c (casify_object, casify_region, operate_on_word)
3317 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3319 (casify_object): Avoid integer overflow when overallocating buffer.
3320 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3321 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3322 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3323 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3324 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3325 integers are now checked earlier. All uses replaced with XINT.
3326 (ccl_driver):
3327 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3328 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3329 (ccl_driver, Fregister_code_conversion_map):
3330 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3331 (resolve_symbol_ccl_program): Check that vector header is in range.
3332 Always copy the vector, so that we can check its contents reliably
3333 now rather than having to recheck each instruction as it's being
3334 executed. Check that vector words fit in 'int'.
3335 (ccl_get_compiled_code, Fregister_ccl_program)
3336 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3337 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3338 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3339 contents are in range.
3340 (Fccl_execute_on_string): Check that status is in range.
3341 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3342 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3343 Accept and return EMACS_INT, not int, because callers can pass values
3344 out of 'int' range.
3345 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3346 (multibyte_chars_in_text, parse_str_as_multibyte)
3347 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3348 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3349 (string_escape_byte8, Fget_byte):
3350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3351 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3352 avoid mishandling large integers.
3353 * character.h: Adjust decls to match defn changes elsewhere.
3354 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3355 (Ffind_charset_region):
3356 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3357 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3358 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3359 Don't assume fixnum fits in int.
d311d28c
PE
3360 (load_charset_map_from_vector, Fmap_charset_chars):
3361 Remove now-unnecessary CHECK_NATNUMs.
3362 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3363 Don't rely on undefined behavior with signed left shift overflow.
3364 Don't assume unsigned int fits into fixnum, or that fixnum fits
3365 into unsigned int. Don't require max_code to be a valid fixnum;
3366 that's not true for gb10830 4-byte on a 32-bit host. Allow
3367 invalid_code to be a cons, for the same reason. Require code_offset
3368 to be a character. Avoid int overflow if max_char is close
3369 to INT_MAX.
3370 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3371 this is intended anyway and avoids some undefined behavior.
3372 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3373 INDEX_TO_CODE_POINT, as that's what it expects.
3374 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3375 * charset.h (DECODE_CHAR): Return int, not unsigned;
3376 this is what was intended anyway, and it avoids undefined behavior.
3377 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3378 integer-overflow issues.
3379 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3380 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3381 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3382 * chartab.c (Fmake_char_table, Fset_char_table_range)
3383 (uniprop_get_decoder, uniprop_get_encoder):
3384 Don't assume fixnum fits in int.
3385 * cmds.c (move_point): New function, that does the gist of
3386 Fforward_char and Fbackward_char, but does so while checking
3387 for integer overflow more accurately.
c96e5d6a 3388 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3389 (Fforward_line, Fend_of_line, internal_self_insert)
3390 (internal_self_insert):
3391 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3392 Fix a FIXME, by checking for integer overflow when calculating
3393 target_clm and actual_clm.
3394 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3395 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3396 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3397 (coding_alloc_by_making_gap, alloc_destination)
3398 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3399 (encode_coding_utf_16, detect_coding_emacs_mule)
3400 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3401 (detect_coding_iso_2022, decode_coding_iso_2022)
3402 (encode_invocation_designation, encode_designation_at_bol)
3403 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3404 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3405 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3406 (encode_coding_ccl, encode_coding_raw_text)
3407 (detect_coding_charset, decode_coding_charset)
3408 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3409 (produce_composition, produce_charset, produce_annotation)
3410 (decode_coding, handle_composition_annotation)
3411 (handle_charset_annotation, consume_chars, decode_coding_gap)
3412 (decode_coding_object, encode_coding_object, detect_coding_system)
3413 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3414 (code_convert_region, code_convert_string)
8f50130c
PE
3415 (Fdefine_coding_system_internal)
3416 (coding_set_source, coding_set_destination):
d311d28c
PE
3417 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3418 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3419 (Fdefine_coding_system_internal):
3420 Don't assume fixnums fit in int.
3421 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3422 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3423 (Funencodable_char_position, Fcheck_coding_systems_region)
3424 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3425 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3426 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3427 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3428 Don't access memory outside of the args array.
d311d28c 3429 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3430 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3431 result of ENCODE_CHAR.
d311d28c
PE
3432 * coding.h: Adjust decls to match defn changes elsewhere.
3433 (struct coding_system):
3434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3435 * composite.c (get_composition_id, find_composition)
3436 (run_composition_function, update_compositions)
3437 (compose_text, composition_gstring_put_cache)
3438 (composition_gstring_p, composition_gstring_width)
3439 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3440 (composition_compute_stop_pos, composition_reseat_it)
3441 (composition_update_it, struct position_record)
3442 (find_automatic_composition, composition_adjust_point)
3443 (Fcomposition_get_gstring, Ffind_composition_internal):
3444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3445 (update_compositions):
3446 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3447 * composite.h: Adjust decls to match defn changes elsewhere.
3448 (struct composition):
3449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3450 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3451 Do not attempt to compute the address of the object just before a
3452 buffer; this is not portable.
3453 (Faref, Faset):
3454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3455 (Faset): Use int, not EMACS_INT, where int is wide enough.
3456 (Fstring_to_number): Don't assume fixnums fit in int.
3457 (Frem): Don't assume arg is nonnegative.
3458 * dbusbind.c (xd_append_arg): Check for integers out of range.
3459 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3460 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3461 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3462 (xd_get_connection_references): Return ptrdiff_t, not int.
3463 All uses changed.
3464 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3465 (xd_read_message_1):
3466 Use int, not unsigned, where the dbus API uses int.
3467 (Fdbus_message_internal): Don't overflow mtype.
3468 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3469 * dired.c (directory_files_internal, file_name_completion, scmp)
3470 (file_name_completion_stat):
3471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3472 (file_name_completion): Don't overflow matchcount.
3473 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3474 * dispextern.h: Adjust decls to match defn changes elsewhere.
3475 (struct text_pos, struct glyph, struct bidi_saved_info)
3476 (struct bidi_string_data, struct bidi_it, struct composition_it)
3477 (struct it):
3478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3479 (struct display_pos, struct composition_it, struct it):
3480 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3481 * dispnew.c (increment_matrix_positions)
3482 (increment_row_positions, mode_line_string)
3483 (marginal_area_string):
3484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3485 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3487 (duration_to_sec_usec): New function, to check for overflow better.
3488 (Fsleep_for, sit_for): Use it.
3489 * doc.c (get_doc_string, store_function_docstring):
3490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3491 (get_doc_string, Fsnarf_documentation):
3492 Use int, not EMACS_INT, where int is wide enough.
3493 (get_doc_string):
3494 Use SAFE_ALLOCA, not alloca.
3495 Check for overflow when converting EMACS_INT to off_t.
3496 * doprnt.c (doprnt):
3497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3498 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3499 Don't assume uid_t fits into fixnum.
3500 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3501 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3502 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3503 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3504 (general_insert_function)
3505 (Finsert_char, make_buffer_string, make_buffer_string_both)
3506 (update_buffer_properties, Fbuffer_substring)
3507 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3508 (Fsubst_char_in_region, check_translation)
3509 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3510 (transpose_markers, Ftranspose_regions):
3511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3512 (clip_to_bounds): Move to lisp.h as an inline function).
3513 (Fconstrain_to_field): Don't assume integers are nonnegative.
3514 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3515 (Fsubst_char_in_region, Fsave_restriction):
3516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3517 (Femacs_pid): Don't assume pid_t fits into fixnum.
3518 (lo_time): Use int, not EMACS_INT, when int suffices.
3519 (lisp_time_argument): Check for usec out of range.
3520 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3521 (Fuser_login_name, Fuser_full_name): Signal an error
3522 if a uid argument is out of range, rather than relying on
3523 undefined behavior.
c8d5c857
PE
3524 (Fformat_time_string): Remove now-unnecessary check.
3525 lisp_time_argument checks for out-of-range usec now.
243e0530 3526 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3527 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3528 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3529 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3530 (init_cmdargs, Fdump_emacs):
3531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3532 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3533 the bottom (typically) 32 bits of the fixnum.
3534 * eval.c (specpdl_size, call_debugger):
3535 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3536 (when_entered_debugger, Fbacktrace_debug):
3537 Don't assume fixnum can fit in int.
3538 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3539 the object just before a buffer; this is not portable.
3540 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3541 (grow_specpdl, unbind_to):
3542 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3543 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3544 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3545 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3546 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3547 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3549 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3550 (a_write, e_write):
3551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3552 (Fcopy_file, non_regular_nbytes, read_non_regular)
3553 (Finsert_file_contents):
3554 Use int, not EMACS_INT, where int is wide enough.
3555 (READ_BUF_SIZE): Verify that it fits in int.
3556 (Finsert_file_contents): Check that counts are in proper range,
3557 rather than assuming fixnums fit into ptrdiff_t etc.
3558 Don't assume fixnums fit into int.
125b3835 3559 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3560 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3561 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3562 (string_char_to_byte, string_byte_to_char)
3563 (string_make_multibyte, string_to_multibyte)
3564 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3565 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3566 (substring_both, Fdelete, internal_equal, Ffillarray)
3567 (Fclear_string, mapcar1)
3568 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3569 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3570 (larger_vector, make_hash_table, maybe_resize_hash_table)
3571 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3572 (Fmaphash, secure_hash):
3573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3574 (concat): Check for string index and length overflow.
3575 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3576 (Frequire):
3577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3578 (larger_vector): New API (vec, incr_min, size_max) replaces old
3579 one (vec, new_size, init). This catches size overflow.
3580 INIT was removed because it was always Qnil.
3581 All callers changed.
3582 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3583 the upper bound on a hash table index size.
3584 (make_hash_table, maybe_resize_hash_table): Use it.
3585 (secure_hash): Computer start_byte and end_byte only after
3586 they're known to be in ptrdiff_t range.
3587 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3588 (Ffont_get_glyphs, Ffont_at):
3589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3590 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3591 (Flist_fonts, Fopen_font):
3592 Don't assume fixnum can fit in int.
3593 (check_gstring): Don't assume index can fit in int.
3594 (font_match_p): Check that fixnum is a character, not a nonnegative
3595 fixnum, since the later code needs to stuff it into an int.
3596 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3597 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3598 conversion overflow issues.
3599 (Fopen_font): Check for integer out of range.
3600 (Ffont_get_glyphs): Don't assume index can fit in int.
3601 * font.h: Adjust decls to match defn changes elsewhere.
3602 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3603 integer overflow.
3604 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3605 printmax_t, where ptrdiff_t is wide enough.
3606 (Finternal_char_font):
3607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3608 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3609 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3610 (Fset_frame_position, x_set_frame_parameters)
3611 (x_set_line_spacing, x_set_border_width)
3612 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3613 Check that fixnums are in proper range for system types.
3614 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3616 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3617 Use SAFE_ALLOCA_LISP, not alloca.
3618 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3619 intptr_t is wide enough.
3620 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3621 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3622 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3623 Check for fixnum out of range.
3624 * ftfont.c (ftfont_list): Don't assume index fits in int.
3625 Check that fixnums are in proper range for system types.
3626 (ftfont_shape_by_flt):
3627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3628 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3630 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3631 Check that fixnums are in proper range for system types.
3632 * gnutls.h: Adjust decls to match defn changes elsewhere.
3633 * gtkutil.c (xg_dialog_run):
3634 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3635 (update_frame_tool_bar):
3636 Check that fixnums are in proper range for system types.
3637 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3638 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3639 * indent.c (last_known_column, last_known_column_point):
3640 (current_column_bol_cache):
3641 (skip_invisible, current_column, check_display_width):
3642 (check_display_width, scan_for_column, current_column_1)
3643 (Findent_to, Fcurrent_indentation, position_indentation)
3644 (indented_beyond_p, Fmove_to_column, compute_motion):
3645 (Fcompute_motion, Fvertical_motion):
3646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3647 (last_known_column_modified): Use EMACS_INT, not int.
3648 (check_display_width):
3649 (Fcompute_motion):
3650 Check that fixnums and floats are in proper range for system types.
3651 (compute_motion): Don't assume index or fixnum fits in int.
3652 (compute_motion, Fcompute_motion):
3653 Use int, not EMACS_INT, when it is wide enough.
3654 (vmotion): Omit local var start_hpos that is always 0; that way
3655 we don't need to worry about overflow in expressions involving it.
3656 * indent.h: Adjust decls to match defn changes elsewhere.
3657 (struct position):
3658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3659 Use int, not EMACS_INT, where int is wide enough.
3660 Remove unused members ovstring_chars_done and tab_offset;
3661 all uses removed.
3662 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3663 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3664 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3665 (make_gap, copy_text, insert, insert_and_inherit)
3666 (insert_before_markers, insert_before_markers_and_inherit)
3667 (insert_1, count_combining_before, count_combining_after)
3668 (insert_1_both, insert_from_string)
3669 (insert_from_string_before_markers, insert_from_string_1)
3670 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3671 (adjust_after_replace, adjust_after_insert, replace_range)
3672 (replace_range_2, del_range, del_range_1, del_range_byte)
3673 (del_range_both, del_range_2, modify_region)
3674 (prepare_to_modify_buffer, signal_before_change)
3675 (signal_after_change, Fcombine_after_change_execute):
3676 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3677 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3678 (balance_an_interval, split_interval_right, split_interval_left)
3679 (find_interval, next_interval, update_interval)
3680 (adjust_intervals_for_insertion, delete_node, delete_interval)
3681 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3682 (static_offset_intervals, offset_intervals)
3683 (merge_interval_right, merge_interval_left, make_new_interval)
3684 (graft_intervals_into_buffer, temp_set_point_both)
3685 (temp_set_point, set_point, adjust_for_invis_intang)
3686 (set_point_both, move_if_not_intangible, get_property_and_range)
3687 (get_local_map, copy_intervals, copy_intervals_to_string)
3688 (compare_string_intervals, set_intervals_multibyte_1):
3689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3690 * intervals.h: Adjust decls to match defn changes elsewhere.
3691 (struct interval):
3692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3693 * keyboard.c (this_command_key_count, this_single_command_key_start)
3694 (before_command_key_count, before_command_echo_length, echo_now)
3695 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3696 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3697 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3698 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3700 (last_non_minibuf_size, last_point_position, echo_truncate)
3701 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3702 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3703 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3704 (stuff_buffered_input):
3705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3706 (last_auto_save, command_loop_1, read_char):
3707 Use EMACS_INT, not int, to avoid integer overflow.
3708 (record_char): Avoid overflow in total_keys computation.
3709 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3710 * keyboard.h: Adjust decls to match defn changes elsewhere.
3711 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3712 (Fkey_description, Fdescribe_vector, Flookup_key):
3713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3714 (click_position): New function, to check that positions are in range.
3715 (Fcurrent_active_maps):
3716 (describe_command):
3717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3718 (Faccessible_keymaps, Fkey_description):
3719 (preferred_sequence_p):
3720 Don't assume fixnum can fit into int.
3721 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3722 Check for integer overflow in size calculations.
3723 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3724 avoid mishandling large integers.
3725 * lisp.h: Adjust decls to match defn changes elsewhere.
3726 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3727 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3728 (struct Lisp_Marker):
3729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3730 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3731 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3732 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3733 All callers changed.
3734 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3735 Assume the arg has valid form, since it always does.
3736 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3737 unsigned integer system type.
3738 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3739 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3741 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3742 (duration_to_sec_usec): New decl.
3743 * lread.c (read_from_string_index, read_from_string_index_byte)
3744 (read_from_string_limit, readchar, unreadchar, openp)
3745 (read_internal_start, read1, oblookup):
3746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3747 (Fload, readevalloop, Feval_buffer, Feval_region):
3748 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3749 (openp): Check for out-of-range argument to 'access'.
3750 (read1): Use int, not EMACS_INT, where int is wide enough.
3751 Don't assume fixnum fits into int.
6efdadfd 3752 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3753 (read_filtered_event): Use duration_to_sec_usec
3754 to do proper overflow checking on durations.
d311d28c
PE
3755 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3756 in size calculation.
3757 (Fexecute_kbd_macro):
3758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3759 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3760 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3761 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3762 (set_marker_both, set_marker_restricted_both, marker_position)
3763 (marker_byte_position, Fbuffer_has_markers_at):
3764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3765 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3766 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3767 It now merely ensures that the menu is large enough, without
3768 necessarily growing it, as this avoids some integer overflow issues.
3769 All callers changed.
3770 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3771 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3772 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3773 Use SAFE_ALLOCA_LISP, not alloca.
3774 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3775 to EMACS_INT. Check that fixnums are in proper range for system types.
3776 * minibuf.c (minibuf_prompt_width, string_to_object)
3777 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3778 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3780 (get_minibuffer, read_minibuf_unwind):
3781 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3782 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3783 this simplifies overflow checking. All callers changed.
3784 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3785 (Ftest_completion):
3786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3787 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3788 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3789 Check that fixnums are in proper range for system types.
3790 (Fx_create_frame, Fx_show_tip):
3791 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3792 * nsfont.m (ns_findfonts, nsfont_list_family):
3793 Don't assume fixnum fits in long.
3794 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3795 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3796 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3797 wide enough.
17fdb222 3798 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3799 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3800 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3801 (PRINTDECLARE, PRINTPREPARE):
3802 (strout, print_string):
3803 (print, print_preprocess, print_check_string_charset_prop)
3804 (print_object):
3805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3806 (PRINTDECLARE):
3807 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3809 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3810 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3811 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3812 (print_error_message): Use SAFE_ALLOCA, not alloca.
3813 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3814 (print_depth, new_backquote_output, print_number_index):
3815 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3816 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3817 (Fset_process_window_size, Fformat_network_address)
3818 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3819 (sigchld_handler):
d311d28c 3820 Check that fixnums are in proper range for system types.
d44287d4 3821 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3822 Check for process-ids out of pid_t range rather than relying on
3823 undefined behavior.
e4d81efc 3824 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3825 (Fformat_network_address, read_process_output, send_process)
3826 (Fprocess_send_region, status_notify):
3827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3828 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3829 (wait_reading_process_output, read_process_output, exec_sentinel):
3830 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3831 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3832 (Faccept_process_output): Use duration_to_sec_usec to do proper
3833 overflow checking on durations.
dde14581
PE
3834 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3835 Don't assume pid_t fits in int.
02481186
PE
3836 * process.h (struct Lisp_Process): Members tick and update_tick
3837 are now of type EMACS_INT, not int.
b62b53e8
PE
3838 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3839 configured --with-wide-int.
d311d28c
PE
3840 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3841 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3842 * search.c (looking_at_1, string_match_1):
3843 (fast_string_match, fast_c_string_match_ignore_case)
3844 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3845 (scan_newline, find_before_next_newline, search_command)
3846 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3847 (set_search_regs, wordify):
3848 (Freplace_match):
3849 (Fmatch_data):
3850 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3851 (string_match_1, search_buffer, set_search_regs):
3852 (Fmatch_data):
3853 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3854 (wordify): Check for overflow in size calculation.
3855 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3856 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3857 Check that fixnums are in proper range for system types.
3858 * sound.c (struct sound_device)
3859 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3861 (Fplay_sound_internal):
3862 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3863 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3864 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3865 (Fparse_partial_sexp):
3866 Don't assume fixnums can fit in int.
3867 (struct lisp_parse_state, find_start_pos, find_start_value)
3868 (find_start_value_byte, find_start_begv)
3869 (update_syntax_table, char_quoted, dec_bytepos)
3870 (find_defun_start, prev_char_comend_first, back_comment):
3871 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3872 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3874 (Finternal_describe_syntax_value): Check that match_lisp is a
3875 character, not an integer, since the code stuffs it into int.
3876 (scan_words, scan_sexps_forward):
3877 Check that fixnums are in proper range for system types.
3878 (Fforward_word):
3879 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3880 (scan_sexps_forward):
3881 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3882 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3883 * syntax.h: Adjust decls to match defn changes elsewhere.
3884 (struct gl_state_s):
3885 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3886 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3887 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3888 * sysdep.c (wait_for_termination_1, wait_for_termination)
3889 (interruptible_wait_for_termination, mkdir):
3890 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3891 (emacs_read, emacs_write):
3892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3893 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3894 and double all fit in int.
d311d28c
PE
3895 * term.c (set_tty_color_mode):
3896 Check that fixnums are in proper range for system types.
3897 * termhooks.h (struct input_event):
3898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3899 * textprop.c (validate_interval_range, interval_of)
3900 (Fadd_text_properties, set_text_properties_1)
3901 (Fremove_text_properties, Fremove_list_of_text_properties)
3902 (Ftext_property_any, Ftext_property_not_all)
3903 (copy_text_properties, text_property_list, extend_property_ranges)
3904 (verify_interval_modification):
3905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3906 (Fnext_single_char_property_change)
3907 (Fprevious_single_char_property_change):
3908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3909 (copy_text_properties):
3910 Check for integer overflow in index calculation.
d311d28c
PE
3911 * undo.c (last_boundary_position, record_point, record_insert)
3912 (record_delete, record_marker_adjustment, record_change)
3913 (record_property_change):
3914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3915 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3916 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3917 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3918 (Fx_hide_tip, Fx_file_dialog):
3919 * w32menu.c (set_frame_menubar):
3920 Use ptrdiff_t, not int, for consistency with rest of code.
3921 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3922 (select_window, Fdelete_other_windows_internal)
3923 (window_scroll_pixel_based, window_scroll_line_based)
3924 (Frecenter, Fset_window_configuration):
3925 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3926 (Fset_window_hscroll, run_window_configuration_change_hook)
3927 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3928 (Fscroll_other_window, Frecenter):
d311d28c
PE
3929 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3930 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3931 Don't assume fixnum fits in int.
3932 (Fset_window_scroll_bars):
3933 Check that fixnums are in proper range for system types.
3934 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3935 (string_pos, c_string_pos, number_of_chars, init_iterator)
3936 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3937 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3938 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3939 (face_before_or_after_it_pos, handle_invisible_prop)
3940 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3941 (display_prop_intangible_p, string_buffer_position_lim)
3942 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3943 (get_overlay_strings_1, get_overlay_strings)
3944 (iterate_out_of_display_property, forward_to_next_line_start)
3945 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3946 (get_next_display_element, set_iterator_to_next)
3947 (get_visually_first_element, compute_stop_pos_backwards)
3948 (handle_stop_backwards, next_element_from_buffer)
3949 (move_it_in_display_line_to, move_it_in_display_line)
3950 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3951 (add_to_log, message_dolog, message_log_check_duplicate)
3952 (message2, message2_nolog, message3, message3_nolog
3953 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3954 (current_message_1, truncate_echo_area, truncate_message_1)
3955 (set_message, set_message_1, store_mode_line_noprop)
3956 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3957 (text_outside_line_unchanged_p, check_point_in_composition)
3958 (reconsider_clip_changes)
3959 (redisplay_internal, set_cursor_from_row, try_scrolling)
3960 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3961 (redisplay_window, find_last_unchanged_at_beg_row)
3962 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3963 (trailing_whitespace_p, find_row_edges, display_line)
3964 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3965 (display_mode_element, store_mode_line_string)
3966 (pint2str, pint2hrstr, decode_mode_spec)
3967 (display_count_lines, display_string, draw_glyphs)
3968 (x_produce_glyphs, x_insert_glyphs)
3969 (rows_from_pos_range, mouse_face_from_buffer_pos)
3970 (fast_find_string_pos, mouse_face_from_string_pos)
3971 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3973 (safe_call, init_from_display_pos, handle_fontified_prop)
3974 (handle_single_display_spec, load_overlay_strings)
3975 (with_echo_area_buffer, setup_echo_area_for_printing)
3976 (display_echo_area, echo_area_display)
3977 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3978 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3979 (redisplay_window, dump_glyph_row, display_mode_line)
3980 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3981 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3982 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3983 (handle_single_display_spec, build_desired_tool_bar_string)
3984 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3985 (get_specified_cursor_type):
3986 Check that fixnums are in proper range for system types.
3987 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3988 (Flookup_image_map):
3989 Don't assume fixnums fit in int.
3990 (compare_overlay_entries):
3991 Avoid mishandling comparisons due to subtraction overflow.
3992 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3993 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3994 (handle_tool_bar_click):
3995 Use int, not unsigned, since we prefer signed and the signedness
3996 doesn't matter here.
3997 (get_next_display_element, next_element_from_display_vector):
3998 Use int, not EMACS_INT, when int is wide enough.
3999 (start_hourglass): Use duration_to_sec_usec to do proper
4000 overflow checking on durations.
4001 * xfaces.c (Fbitmap_spec_p):
4002 Check that fixnums are in proper range for system types.
4003 (compare_fonts_by_sort_order):
4004 Avoid mishandling comparisons due to subtraction overflow.
4005 (Fx_family_fonts, realize_basic_faces):
4006 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4007 (Fx_family_fonts):
4008 Don't assume fixnum fits in int.
4009 Use SAFE_ALLOCA_LISP, not alloca.
4010 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4011 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4012 (face_at_buffer_position, face_for_overlay_string)
4013 (face_at_string_position):
4014 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4015 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4016 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4017 (Fx_show_tip):
4018 Check that fixnums are in proper range for system types.
4019 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4020 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4021 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4022 (Fx_change_window_property): Don't assume fixnums fit in int.
4023 * xfont.c (xfont_chars_supported):
4024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4025 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4026 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4027 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4028 * xml.c (parse_region):
4029 * xrdb.c (magic_file_p):
4030 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4031 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4032 (x_get_local_selection, x_reply_selection_request)
4033 (x_handle_selection_request, wait_for_property_change):
4034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4035 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4036 short is wide enough.
4037 (x_send_client_event): Don't assume fixnum fits in int.
4038 * xterm.c (x_x_to_emacs_modifiers):
4039 Don't assume EMACS_INT overflows nicely into int.
4040 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4041 may come from Lisp.
4042 (handle_one_xevent): NATNUMP can eval its arg twice.
4043 (x_connection_closed):
4044 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4045 * xterm.h: Adjust decls to match defn changes elsewhere.
4046 (struct scroll_bar): Use struct vectorlike_header
4047 rather than rolling our own approximation.
4048 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4049
c6574eb5
GM
40502012-05-25 Glenn Morris <rgm@gnu.org>
4051
4052 * lisp.mk (lisp): Update for more files being compiled now.
4053
e8d32c7e
SM
40542012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4055
48def666
SM
4056 * lread.c: Remove `read_pure' which makes no difference.
4057 (read_pure): Remove var.
4058 (unreadpure): Remove function.
4059 (readevalloop): Don't call read_list with -1 flag.
4060 (read1, read_vector): Don't test read_pure any more.
4061 (read_list): Simplify.
4062
e8d32c7e
SM
4063 * fileio.c, character.h: Minor style tweaks.
4064
4b2addb7
DA
40652012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4066
4067 * window.h (clip_changed): Remove useless declaration.
4068
584461b2
JB
40692012-05-22 Juanma Barranquero <lekktu@gmail.com>
4070
4071 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4072 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4073
34374650
PE
40742012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4075
4076 Remove src/m/*.
4077 This directory predates autoconf and is no longer needed nowadays.
4078 Move its few remaining bits of functionality to where they're needed.
4079 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4080 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4081 * m/template.h: Remove.
4082 * Makefile.in (M_FILE): Remove. All uses removed.
4083 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4084 * lisp.h (USE_LSB_TAG):
4085 * mem-limits.h (EXCEEDS_LISP_PTR):
4086 Use VAL_MAX, not VALBITS, in #if.
4087 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4088 (EMACS_UINT): Define unconditionally now.
4089 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4090 (BITS_PER_EMACS_INT): New constants, replacing
4091 what used to be in config.h, but not useful in #if.
4092 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4093 define them any more.
4094 (VAL_MAX): New macro.
4095 (VALMASK): Use it.
4096 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4097 BITS_PER_EMACS_INT, in #if.
4098 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4099 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4100 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4101 * s/ms-w32.h (DATA_START):
4102 Move here from removed file m/intel386.h.
4103 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4104 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4105
261cb4bb
PE
41062012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4107
4108 Assume C89 or later.
4109 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4110 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4111 (xrealloc):
4112 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4113 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4114 * textprop.c, tparam.c (NULL): Remove.
4115 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4116 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4117 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4118 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4119 * xterm.c (input_signal_count): Assume volatile works.
4120
ff23cd9f
KB
41212012-05-21 Ken Brown <kbrown@cornell.edu>
4122
4123 * xgselect.c (xg_select): Fix first argument in call to 'select'
4124 (bug#11508).
4125
1b170bc6
KB
41262012-05-20 Ken Brown <kbrown@cornell.edu>
4127
4128 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4129 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4130
b2f4d39f
KB
41312012-05-19 Ken Brown <kbrown@cornell.edu>
4132
4133 * xfns.c (x_in_use): Remove `static' qualifier.
4134 * xterm.h (x_in_use): Declare.
4135 * xgselect.c: Include xterm.h.
4136 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4137 and `display_arg' (bug#9754).
4138
003fdae2
PE
41392012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4140
9232a6d9
PE
4141 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4142
003fdae2
PE
4143 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4144 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4145
784b56e2
EZ
41462012-05-18 Eli Zaretskii <eliz@gnu.org>
4147
4148 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4149
4150 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4151 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4152
4153 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4154 reference to image_cache->refcount.
4155 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4156
a0a79cde
JL
41572012-05-17 Juri Linkov <juri@jurta.org>
4158
4159 * search.c (Fword_search_regexp, Fword_search_backward)
4160 (Fword_search_forward, Fword_search_backward_lax)
4161 (Fword_search_forward_lax): Move functions to isearch.el
4162 (bug#10145, bug#11381).
4163
b0572523
PE
41642012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4165
4166 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4167
9660f5fc
SM
41682012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4169
4170 * lread.c (init_obarray): Declare Qt and Qnil as special.
4171
4374de83
GM
41722012-05-14 Glenn Morris <rgm@gnu.org>
4173
4174 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4175 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4176
dc44c39a
PE
41772012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4178
078c97cb
PE
4179 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4180
dc44c39a
PE
4181 * unexaix.c: Port to more-recent AIX compilers.
4182 (report_error, report_error_1, make_hdr, copy_sym)
4183 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4184 Make arguments const char *, not char *, to avoid violations of C
4185 standard and to fix some AIX warnings reported by Gilles Pion.
4186
e18afed7 41872012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4188
4189 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4190 already have overlays loaded.
4191 (handle_single_display_spec): Before returning without displaying
4192 fringe bitmap, synchronize the bidi iterator with the main display
4193 iterator, by calling iterate_out_of_display_property.
4194 (iterate_out_of_display_property): Detect buffer iteration by
4195 testing that it->string is a Lisp string.
4196 (get_next_display_element): When the current object is exhausted,
4197 and there's something on it->stack, call set_iterator_to_next to
4198 proceed with what's on the stack, instead of returning zero.
4199 (set_iterator_to_next): If called at the end of a Lisp string,
4200 proceed to consider_string_end without incrementing string
4201 position. Don't increment display vector index past the end of
4202 the display vector. (Bug#11417)
c8fb9dc6
EZ
4203 (pos_visible_p): Don't report a position visible when move_it_to
4204 stopped at the last line of window, which happens to be scanned
4205 backwards by the bidi iteration. (Bug#11464)
ac268e67 4206
e18afed7 42072012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4208
4209 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4210 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4211 are on a TTY, and thus unable to display on the fringes.
4212 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4213 so we need to signal to the caller that this is a "replacing"
4214 display spec. This fixes display when the spec is invalid or we
4215 are on a TTY.
4216
e18afed7 42172012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4218
4219 * unexaix.c (make_hdr): Fix typo in prototype.
4220 This bug broke the build on AIX. Problem reported by Gilles Pion.
4221
9d0a235a
MA
42222012-05-14 Michael Albinus <michael.albinus@gmx.de>
4223
4224 * keyboard.c (kbd_buffer_get_event): Read special events also in
4225 batch mode. (Bug#11415)
4226
9e6b06ed
GM
42272012-05-12 Glenn Morris <rgm@gnu.org>
4228
4229 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4230
c1a1d7a3
EZ
42312012-05-12 Eli Zaretskii <eliz@gnu.org>
4232
4233 * lisp.mk (lisp): Add newcomment.elc.
4234
3fe7cdc8
GM
42352012-05-12 Glenn Morris <rgm@gnu.org>
4236
4237 * Makefile.in (MKDIR_P): New, set by configure.
4238 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4239
53f7d2c0
PE
42402012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4241
4242 Remove unused function hourglass_started.
4243 * dispextern.h (hourglass_started):
4244 * w32fns.c (hourglass_started):
4245 * xdisp.c (hourglass_started): Remove.
4246
75aafb17
JB
42472012-05-10 Juanma Barranquero <lekktu@gmail.com>
4248
4249 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4250 Update dependencies.
4251
12959e8e
PE
42522012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4253
97107e2e
PE
4254 * xgselect.c (xg_select): Put maxfds+1 into a var.
4255 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4256
12959e8e
PE
4257 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4258
836d29b3
DA
42592012-05-10 Dave Abrahams <dave@boostpro.com>
4260
4261 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4262 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4263
5cb67954
MA
42642012-05-09 Michael Albinus <michael.albinus@gmx.de>
4265
4266 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4267 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4268 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4269 Initialize xd_registered_buses.
4270
3478ec45
PE
42712012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4272
b263a6b0
PE
4273 Untag more efficiently if USE_LSB_TAG.
4274 This is based on a proposal by YAMAMOTO Mitsuharu in
4275 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4276 For an admittedly artificial (nth 8000 longlist) benchmark on
4277 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4278 Emacs's overall text size by 1%.
4279 * lisp.h (XUNTAG): New macro.
4280 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4281 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4282 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4283 * eval.c (Fautoload):
4284 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4285 * frame.h (XFRAME): Use XUNTAG.
4286
3478ec45
PE
4287 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4288 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4289 Remove unportable assumptions about print widths of types like
4290 dbus_uint32_t.
4291 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4292 intptr_t when converting between pointer and integer, to avoid GCC
4293 warnings about wrong width.
4294
666b903b 42952012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4296
4297 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4298 stack for each reader_thread, instead of defaulting to 8MB
4299 determined by the linker. This avoids failures in creating
4300 subprocesses on Windows 7, see the discussion in this thread:
4301 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4302
b120cc17
JC
43032012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4304
4305 Fix up display of the *Minibuf-0* buffer in the mini window.
4306 * keyboard.c (read_char): Don't clear the echo area if there's no
4307 message to clear.
4308 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4309 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4310
9a4b36f8
MA
43112012-05-07 Michael Albinus <michael.albinus@gmx.de>
4312
4313 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4314 batch mode.
4315
e5f9458f
CY
43162012-05-06 Chong Yidong <cyd@gnu.org>
4317
4318 * lisp.mk (lisp): Update.
4319
eceeb5fc 43202012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4321
4322 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4323
71873e2b
SM
43242012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4325
4326 * data.c (PUT_ERROR): New macro.
4327 (syms_of_data): Use it. Add new error type `user-error'.
4328 * undo.c (user_error): New function.
4329 (Fprimitive_undo): Use it.
4330 * print.c (print_error_message): Adjust print style for `user-error'.
4331 * keyboard.c (user_error): New function.
4332 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4333
ab0fa4e4
PE
43342012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4335
4336 Do not limit current-time-string to years 1000..9999.
4337 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4338 (Fcurrent_time_string): Support any year that is supported by the
4339 underlying localtime representation. Don't use asctime, as it
4340 has undefined behavior for years outside the range -999..9999.
4341
7ed806a7
PE
43422012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4343
4344 Fix race conditions involving setenv, gmtime, localtime, asctime.
4345 Without this fix, interrupts could mess up code that uses these
4346 nonreentrant functions, since setting TZ invalidates existing
4347 tm_zone or tzname values, and since most of these functions return
4348 pointers to static storage.
4349 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4350 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4351 Grow the critical sections to include not just invoking
4352 localtime/gmtime, but also accessing these functions' results
4353 including their tm_zone values if any, and any related TZ setting.
4354 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4355 so that the struct tm is saved in the critical section.
4356 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4357 motivated by the fact that memory allocation needs to be outside
4358 the critical section.
4359
0c16dfed
DA
43602012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4361
4362 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4363 with RESET_INTERVAL.
4364
4365 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4366 Remove duplicated buffer name initialization.
4367
3f83ace8
JM
43682012-05-02 Jim Meyering <jim@meyering.net>
4369
4370 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4371
c7b8541e
JM
4372 * xfns.c (x_window): Use xstrdup (Bug#11375).
4373
90207a15 43742012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4375
4376 * xdisp.c (pos_visible_p): If already at a newline from the
4377 display string before the 'while' loop, don't walk back the glyphs
4378 from it3.glyph_row. Solves assertion violation when the display
4379 string begins with a newline (egg.el). (Bug#11367)
4380
b593d6a9
AH
43812012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4382
4383 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4384 Move to simple.el.
4385
4737362e
GM
43862012-05-01 Glenn Morris <rgm@gnu.org>
4387
99cf43f9
GM
4388 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4389 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4390 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4391 All were removed before 23.1.
4392
9311dcff
GM
4393 * dispnew.c: Remove HAVE_LIBNCURSES test;
4394 it is always true on relevant platforms.
4395
4d5c6349
GM
4396 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4397 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4398
4737362e
GM
4399 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4400
74dd3a6b
AS
44012012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4402
4403 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4404 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4405 Remove.
4406
13c379ee
PE
44072012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4408
4409 Do not avoid creating empty evaporating overlays (Bug#9642).
4410 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4411 That is, do not delete an evaporating overlay if it becomes
4412 empty after its bounds are adjusted to fit within its buffer.
4413 This fix caused other problems, and I'm reverting it until we get
4414 to the bottom of them.
4415
a8e7d6d7 44162012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4417
4418 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4419
a8e7d6d7 44202012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4421
4422 * xdisp.c (pos_visible_p): If the window start position is beyond
4423 ZV, start the display from buffer beginning. Prevents assertion
4424 violation in init_iterator when the minibuffer window is scrolled
4425 via the scroll bar.
4426
4427 * window.c (window_scroll_pixel_based): Likewise.
4428
a8e7d6d7 44292012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4430
4431 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4432
a8e7d6d7 44332012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4434
4435 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4436 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4437
a8e7d6d7 44382012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4439
b593d6a9
AH
4440 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4441 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4442
1c6900d9
EZ
44432012-04-26 Eli Zaretskii <eliz@gnu.org>
4444
4c3fa1d9
EZ
4445 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4446 display element, check also the underlying string or buffer
4447 character. (Bug#11341)
4448
1c6900d9
EZ
4449 * w32menu.c: Include w32heap.h.
4450 (add_menu_item): If the call to AppendMenuW (via
4451 unicode_append_menu) fails, disable Unicode menus only if we are
4452 running on Windows 9X/Me.
4453
42bf8205
AS
44542012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4455
4456 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4457 (xgetint): Add missing shift for LSB tags.
4458
b1bac16e
MR
44592012-04-24 Martin Rudalics <rudalics@gmx.at>
4460
4461 * keyboard.c (read_char): Don't wipe echo area for select window
4462 events: These might get delayed via `mouse-autoselect-window'
4463 (Bug#11304).
4464
d69621cc
JB
44652012-04-24 Juanma Barranquero <lekktu@gmail.com>
4466
4467 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4468 manipulation of :loaded-from data.
4469
02fd101b
JB
44702012-04-23 Juanma Barranquero <lekktu@gmail.com>
4471
4472 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4473 now a cons (bug#11311).
4474
888bec30
PE
44752012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4476
89a438bd
PE
4477 Do not create empty overlays with the evaporate property (Bug#9642).
4478 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4479 if it becomes empty after its bounds are adjusted to fit within
4480 its buffer. Without this fix, in a nonempty buffer (let ((o
4481 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4482 yields an empty overlay that has the evaporate property, which is
4483 not supposed to happen.
4484
1068fe4d
PE
4485 Fix minor GTK3 problems found by static checking.
4486 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4487 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4488 (struct _EmacsFixedClass, emacs_fixed_get_type):
4489 Move decls here from emacsgtkfixed.h, since they needn't be public.
4490 (emacs_fixed_get_type): Now static.
4491 (emacs_fixed_class_init): Omit unused local.
4492 (emacs_fixed_child_type): Remove; unused.
4493 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4494 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4495 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4496 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4497 (EMACS_FIXED_GET_CLASS): Remove; unused.
4498 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4499
888bec30
PE
4500 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4501 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4502
de85e130
PE
45032012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4504
d0baac98 4505 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4506 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4507 (__malloc_size_t, __malloc_ptrdiff_t):
4508 Remove. All uses removed, replaced by the definiens if needed,
4509 since we can assume C89 or better now.
4510 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4511 (protect_malloc_state, align, get_contiguous_space)
4512 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4513 (malloc_atfork_handler_child, malloc_enable_thread)
4514 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4515 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4516 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4517 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4518 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4519 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4520 Define using prototypes, not old style.
4521 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4522 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4523 (align): Don't assume that signed integer overflow wraps around.
4524 Omit unused local var.
4525 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4526 (_free_internal_nolock, memalign, mallochook, reallochook):
4527 Omit no-longer-needed casts.
4528 (valloc): Use getpagesize, not __getpagesize.
4529 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4530 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4531
de85e130
PE
4532 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4533
dcbf5805
MA
45342012-04-22 Michael Albinus <michael.albinus@gmx.de>
4535
4536 Move functions from C to Lisp. Make non-blocking method calls
4537 the default. Implement further D-Bus standard interfaces.
4538
4539 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4540 (QCdbus_request_name_allow_replacement)
4541 (QCdbus_request_name_replace_existing)
4542 (QCdbus_request_name_do_not_queue)
4543 (QCdbus_request_name_reply_primary_owner)
4544 (QCdbus_request_name_reply_in_queue)
4545 (QCdbus_request_name_reply_exists)
4546 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4547 (QCdbus_registered_serial, QCdbus_registered_method)
4548 (QCdbus_registered_signal): New Lisp objects.
4549 (XD_DEBUG_MESSAGE): Use sizeof.
4550 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4551 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4552 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4553 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4554 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4555 (xd_signature, xd_append_arg): Allow float for integer types.
4556 (xd_get_connection_references): New function.
b593d6a9
AH
4557 (xd_get_connection_address): Rename from xd_initialize.
4558 Return cached address.
dcbf5805
MA
4559 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4560 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4561 level.
4562 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4563 Return number of refcounts.
dcbf5805
MA
4564 (Fdbus_get_unique_name): Make stronger parameter check.
4565 (Fdbus_message_internal): New defun.
4566 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4567 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4568 (Fdbus_send_signal, Fdbus_register_service)
4569 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4570 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4571 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4572 (Vdbus_compiled_version, Vdbus_runtime_version)
4573 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4574 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4575 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4576 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4577 Adapt docstring.
dcbf5805 4578
52828e02
PE
45792012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4580
da05bc4c
PE
4581 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4582 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4583 Do not assume ptrdiff_t is the same width as 'int'.
4584
52828e02
PE
4585 * alloc.c: Handle unusual debugging option combinations.
4586 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4587 since the two debugging options are incompatible.
4588 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4589 is defined.
4590 (mem_init, mem_insert, mem_insert_fixup):
4591 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4592 (NEED_MEM_INSERT): Remove; no longer needed.
4593
f01769f9
LL
45942012-04-22 Leo Liu <sdl.web@gmail.com>
4595
4596 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4597
5790543d
PE
45982012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4599
4600 * sysdep.c [__FreeBSD__]: Minor cleanups.
4601 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4602 Use Emacs indenting style more consistently. Avoid some casts.
4603 Use 'double' consistently rather than mixing 'float' and 'double'.
4604
b91b7e4d
EW
46052012-04-21 Eduard Wiebe <usenet@pusto.de>
4606
b593d6a9
AH
4607 * sysdep.c (list_system_processes, system_process_attributes):
4608 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4609
6114eb15
AS
46102012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4611
4612 * lisp.mk (lisp): Update.
4613
2f38dff7
PE
46142012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4615
4616 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4617 It is never used otherwise.
4618
4ae29f89
SM
46192012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4620
4621 * print.c (print_preprocess): Only check print_depth if print-circle
4622 is nil.
4623 (print_object): Check for cycles even when print-circle is nil and
4624 print-gensym is t, but only check print_depth if print-circle is nil.
4625
f30d612a
CY
46262012-04-20 Chong Yidong <cyd@gnu.org>
4627
4628 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4629 set the status to "failed" and ensure that sentinel is run.
4630
c07a4c0b 46312012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4632
4633 * process.c (Fset_process_inherit_coding_system_flag)
4634 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4635 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4636
c07a4c0b 46372012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4638
4639 * xdisp.c (string_buffer_position_lim): Limit starting position to
4640 BEGV.
4641 (set_cursor_from_row): If called for a mode-line or header-line
4642 row, return zero immediately.
4643 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4644 farther than the first row after the header line, if any.
4645 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4646 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4647
c07a4c0b 46482012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4649
4ae29f89
SM
4650 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4651 (bug#11238).
ad3a2b41 4652
c07a4c0b 46532012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 46542012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4655
4656 configure: new option --enable-gcc-warnings (Bug#11207)
4657 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4658 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4659 (ALL_CFLAGS): Use new macros rather than old.
4660 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4661 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4662 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4663 -Wunused-result, -Wunused-variable. This should go away once
4664 the Emacs and Gnulib regex code is merged.
4665 (xmalloc, xrealloc): Now static.
4666
aba027e8
PE
46672012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4668
4669 * dired.c (Fsystem_groups): Remove unused local.
4670
e5a36063
GM
46712012-04-17 Glenn Morris <rgm@gnu.org>
4672
4673 * dired.c (Fsystem_users): Doc fix.
4674
316411f0
DA
46752012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4676
4677 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4678 (syms_of_dired): Add them.
4679
9426aba4
PE
46802012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4681
b62a57be
PE
4682 Fix minor alloc.c problems found by static checking.
4683 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4684 New extern decls, to avoid calling undeclared functions.
4685 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4686 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4687 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4688 (NEED_MEM_INSERT): New macro.
4689 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4690 Remove one incorrect comment and fix another.
b62a57be 4691
3539f31f
PE
4692 Fix minor ralloc.c problems found by static checking.
4693 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4694 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4695 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4696 (r_alloc_sbrk): Now static.
4697
a041960a
PE
4698 Improve ralloc.c interface checking.
4699 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4700 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4701 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4702 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4703 [REL_ALLOC]: ... to here, to check interface.
4704 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4705 Remove decls. This fixes an "It stinks!".
4706
9426aba4
PE
4707 * alloc.c (which_symbols): Fix alignment issue / type clash.
4708
d55c12ed
AS
47092012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4710
4711 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4712 (struct Lisp_Misc_Any): Likewise.
4713 (struct Lisp_Free): Likewise.
4714 * alloc.c (union aligned_Lisp_Symbol): Define.
4715 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4716 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4717 (union aligned_Lisp_Misc): Define.
4718 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4719 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4720 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4721
b948ce8b
PE
47222012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4723
4724 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4725 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4726 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4727 * s/netbsd.h, s/sol2-6.h:
4728 Remove definition of GC_MARK_STACK, since the default now works.
4729 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4730 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4731 no longer the default.
4732 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4733
35dc09a1 47342012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4735
35dc09a1
GM
4736 * lread.c (lisp_file_lexically_bound_p):
4737 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4738
35dc09a1
GM
47392012-04-14 Eli Zaretskii <eliz@gnu.org>
4740
4741 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4742 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4743
47442012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4745
4746 * nsterm.m (constrainFrameRect): Always constrain when there is only
4747 one screen (Bug#10962).
4748
bcd86815
KB
47492012-04-13 Ken Brown <kbrown@cornell.edu>
4750
4751 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4752
c25df26e
RT
47532012-04-13 Reuben Thomas <rrt@sc3d.org>
4754
4755 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4756
0fc59f1e
DC
47572012-04-11 Daniel Colascione <dancol@dancol.org>
4758
4759 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4760 against is gone. It's better to use vfork now so that when Cygwin
4761 gains a new, working vfork, we use it automatically (bug#10398).
4762
de8c03dc
SM
47632012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4764
4765 * window.c (save_window_save): Obey window-point-insertion-type.
4766
2f097256
GM
47672012-04-11 Glenn Morris <rgm@gnu.org>
4768
4769 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4770
453b951e
SM
47712012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4772
4773 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4774
75f1671a 47752012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4776
4777 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4778 (force_quit_count): New var.
4779 (handle_interrupt): Use it.
4780
2a8ce227
JB
47812012-04-10 Juanma Barranquero <lekktu@gmail.com>
4782
4783 * w32.c (w32_delayed_load): Record the full path of the library
4784 being loaded (bug#10424).
4785
935396c0
GM
47862012-04-09 Glenn Morris <rgm@gnu.org>
4787
05920a43
GM
4788 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4789 not just in the obarray, before snarfing them. (Bug#11036)
4790
935396c0
GM
4791 * Makefile.in ($(leimdir)/leim-list.el):
4792 Pass EMACS rather than BUILT_EMACS.
4793
a18ecafa
TZ
47942012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4795
4796 * process.c (make_process):
4797 * process.h: Add integer `gnutls_handshakes_tried' member to
4798 process struct.
4799
6bbef4e5
JC
4800 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4801 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4802
4803 * gnutls.c (gnutls_log_function2i): Convenience log function.
4804 (emacs_gnutls_read): Use new log functions,
4805 `gnutls_handshakes_tried' process member, and
4806 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4807 attempts per process (connection).
4808
b4d3bc10
CY
48092012-04-09 Chong Yidong <cyd@gnu.org>
4810
4811 * eval.c (Fuser_variable_p, user_variable_p_eh)
4812 (lisp_indirect_variable): Functions deleted.
4813 (Fdefvar): Caller changed.
4814
4815 * callint.c (Finteractive, Fcall_interactively):
4816 * minibuf.c (Fread_variable): Callers changed.
4817
70f4d973
EZ
48182012-04-09 Eli Zaretskii <eliz@gnu.org>
4819
4820 * xdisp.c (set_cursor_from_row): If the display string appears in
4821 the buffer at position that is closer to point than the position
4822 after the display string, display the cursor on the first glyph of
4823 the display string. Fixes cursor display when a 'display' text
4824 property immediately follows invisible text. (Bug#11094)
4825
cb3c2e3e
PE
48262012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4827
4828 composite.c: use 'double' consistently
4829 * composite.c (get_composition_id): Use 'double' consistently
4830 instead of converting 'float' to 'double' and vice versa; this is
4831 easier to understand and avoids a GCC warning.
4832
fd06db5d
GM
48332012-04-09 Glenn Morris <rgm@gnu.org>
4834
50fe702a
GM
4835 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4836 preparation for dumping it with emacs. (Bug#4789)
4837 (leimdir): New variable.
4838 ($(leimdir)/leim-list.el): New rule.
4839 (emacs$(EXEEXT)): Depend on leim-list.el.
4840
fd06db5d
GM
4841 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4842 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4843 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4844
55c131ee
AS
48452012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4846
4847 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4848 proper alignment.
4849
9209588f
JB
48502012-04-07 Juanma Barranquero <lekktu@gmail.com>
4851
4852 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4853 Remove unused local variable.
4854
e3fb2efb
PE
48552012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4856
4857 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4858 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4859 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4860 objects, as mark_maybe_pointer will catch them otherwise.
4861 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4862 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4863
b5385551
PE
48642012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4865
4866 Fix typo that broke non-Windows builds.
4867 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4868
9078ead6
EZ
48692012-04-07 Eli Zaretskii <eliz@gnu.org>
4870
4871 Support building on MS-Windows with libxml2.
4872
4873 * makefile.w32-in (OBJ2): Add xml.$(O).
4874 (GLOBAL_SOURCES): Add xml.c.
4875 ($(BLD)/xml.$(O)): New dependency list.
4876
4877 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4878 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4879 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4880 [!WINDOWSNT]: New macros.
4881 (init_libxml2_functions, libxml2_loaded_p): New functions.
4882 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4883 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4884 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4885 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4886 linked in).
6bbef4e5
JC
4887 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4888 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4889 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4890
4891 * emacs.c: Don't include libxml/parser.h.
4892 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4893 xmlCleanupParser directly.
4894
4895 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4896
3811fdf3
EZ
48972012-04-07 Eli Zaretskii <eliz@gnu.org>
4898
4899 * indent.c (Fvertical_motion): If there is a display string at
4900 point, use it.vpos to compute how many lines to backtrack after
4901 move_it_to point. (Bug#11133)
4902
2f8e16b2
EZ
49032012-04-06 Eli Zaretskii <eliz@gnu.org>
4904
4905 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4906 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4907 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4908 macros related to unification of CJK characters. For the details,
4909 see the discussion following the message here:
4910 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4911
3d439cd1
CY
49122012-04-04 Chong Yidong <cyd@gnu.org>
4913
4914 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4915
8bc53d00
EZ
49162012-04-01 Eli Zaretskii <eliz@gnu.org>
4917
4918 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4919 instead of alloca. (Bug#11138)
4920
3b0512a3
AS
49212012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4922
4923 * w32menu.c (is_simple_dialog): Properly check lisp types.
4924 (Bug#11141)
4925
8427ddd2
EZ
49262012-03-31 Eli Zaretskii <eliz@gnu.org>
4927
979022ef
EZ
4928 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4929 position we get to after a call to move_it_to fails the
4930 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4931 only if we wind up in a string from display property. (Bug#11063)
4932
a6b1c7cc
EZ
4933 * window.c (Fdelete_other_windows_internal): Invalidate the row
4934 and column information about mouse highlight, so that redisplay
4935 restores it after reallocating the glyph matrices. (Bug#7464)
4936
8427ddd2
EZ
4937 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4938 string comes from a `display' text property, use the buffer
4939 position of that property as if we actually saw that position in
4940 the row's glyphs.
697ba24b
EZ
4941 (move_it_by_lines): Remove the assertion that
4942 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4943 violated when there's a before-string at the beginning of a line.
4944 (Bug#11063)
8427ddd2 4945
65a0a738
EZ
49462012-03-30 Eli Zaretskii <eliz@gnu.org>
4947
4948 * xdisp.c (append_space_for_newline): If the default face was
4949 remapped, use the remapped face for the appended newline.
4950 (extend_face_to_end_of_line): Use the remapped default face for
4951 extending the face to the end of the line.
4952 (display_line): Call extend_face_to_end_of_line when the default
4953 face was remapped. (Bug#11068)
4954
581355cc
EZ
49552012-03-29 Eli Zaretskii <eliz@gnu.org>
4956
4957 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4958
e8fc049f
SM
49592012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4960
4961 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4962
4fb9a543
GM
49632012-03-27 Glenn Morris <rgm@gnu.org>
4964
4965 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4966 Doc fixes.
4967
679910f1
KH
49682012-03-26 Kenichi Handa <handa@m17n.org>
4969
4970 * dispextern.h (struct glyph): Fix previous change. Change the
4971 bit length of glyphless.ch to 25 (Bug#11082).
4972
90d49b7f
CY
49732012-03-26 Chong Yidong <cyd@gnu.org>
4974
4975 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4976 (command_loop_1): Use it; inhibit selection update for
4977 handle-select-window too (Bug#8996).
4978
f514f6f0
FP
49792012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4980
e8fc049f 4981 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4982
bf43fa51
KH
49832012-03-25 Kenichi Handa <handa@m17n.org>
4984
4985 * dispextern.h (struct glyph): Change the bit length of
4986 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4987
8a0c01dd
EZ
49882012-03-24 Eli Zaretskii <eliz@gnu.org>
4989
4990 * s/ms-w32.h (tzname): Include time.h before redirecting to
4991 _tzname. Fixes the MSVC build. (Bug#9960)
4992
7d1c3a76
AS
49932012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4994
8ed79523
AS
4995 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4996 characters.
4997
7d1c3a76
AS
4998 * xterm.c (XTread_socket): Only modify handling_signal if
4999 !SYNC_INPUT. (Bug#11080)
5000
e99a9b8b
EZ
50012012-03-23 Eli Zaretskii <eliz@gnu.org>
5002
5003 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5004 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5005 when fetching a multibyte character consumes more bytes than
5006 CHAR_BYTES returns, due to unification of CJK characters in
5007 string_char. (Bug#11073)
5008
5063c0e1
TN
50092012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5010
5011 * process.c (wait_reading_process_output): Handle pty disconnect
5012 by refraining from sending oneself a SIGCHLD (bug#10933).
5013
9f851fbd
CY
50142012-03-22 Chong Yidong <cyd@gnu.org>
5015
5016 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5017
5063c0e1 5018 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5019 Mark string as coming from a prefix property.
5020 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5021 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5022
fb5b8aca
CY
50232012-03-21 Chong Yidong <cyd@gnu.org>
5024
5025 * xfaces.c (Vface_remapping_alist): Doc fix.
5026
62356a1b
EZ
50272012-03-20 Eli Zaretskii <eliz@gnu.org>
5028
5029 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5030 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5031 Doc fixes.
62356a1b 5032
025de85b
CY
50332012-03-20 Chong Yidong <cyd@gnu.org>
5034
5035 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5036 to reflect default non-nil value of redisplay-dont-pause.
5037
4827f94e
KH
50382012-03-19 Kenichi Handa <handa@m17n.org>
5039
5040 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5041 it fit in a valid range (Bug#11003).
5042
e50a24a2
EZ
50432012-03-18 Eli Zaretskii <eliz@gnu.org>
5044
5045 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5046 that is not from display property, accept the row as a "cursor
5047 row" if one of the string's character has a non-nil `cursor'
5048 property. Fixes cursor positioning when there are newlines in
5049 overlay strings, e.g. in icomplete.el. (Bug#11035)
5050
9af5ed87
PE
50512012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5052
5053 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5054
d1f55f16
CY
50552012-03-12 Chong Yidong <cyd@gnu.org>
5056
5057 * eval.c (inhibit_lisp_code): Rename from
5058 inhibit_window_configuration_change_hook; move from window.c.
5059
5060 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5061 * window.c (run_window_configuration_change_hook)
5062 (syms_of_window): Callers changed.
5063
66c5eebd
CY
50642012-03-11 Chong Yidong <cyd@gnu.org>
5065
413df973
CY
5066 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5067
66c5eebd
CY
5068 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5069
1de11f56
CY
50702012-03-10 Chong Yidong <cyd@gnu.org>
5071
5072 * frame.c (other_visible_frames): Don't assume the selected frame
5073 is visible (Bug#10955).
5074
cae07000
SM
50752012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5076
5077 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5078
89c94350
JD
50792012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5080
5081 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5082 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5083 zero (Bug#10954).
5084
999dd333
GM
50852012-03-03 Glenn Morris <rgm@gnu.org>
5086
01a6dcc8 5087 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5088
de0100f2
EZ
50892012-03-02 Eli Zaretskii <eliz@gnu.org>
5090
5091 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5092 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5093 (redisplay_window, next_element_from_string): Fix typos in
5094 comments.
3e441275
EZ
5095 (redisplay_window): Pass to move_it_vertically the margin in
5096 pixels, not in screen lines.
de0100f2 5097
96a72ee9
GM
50982012-03-02 Glenn Morris <rgm@gnu.org>
5099
5100 * buffer.c (buffer-list-update-hook): Doc fix.
5101
312508d7
EZ
51022012-02-29 Eli Zaretskii <eliz@gnu.org>
5103
5104 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5105 push_it before setting up the iterator for the first overlay
5106 string, even if we have an empty string loaded.
5107 (next_overlay_string): If there's an empty string on the iterator
5108 stack, pop the stack. (Bug#10903)
5109
27f3c637
PE
51102012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5111
5112 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5113 Suggested by Stefan Monnier in
5114 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5115 * alloc.c (widen_to_Lisp_Object): New static function.
5116 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5117 and widening them to Lisp_Objects. This would work even if
5118 USE_LSB_TAG is defined and wide integers are used, which might
5119 happen in a future version of Emacs.
5120
3c9dfce6
CY
51212012-02-25 Chong Yidong <cyd@gnu.org>
5122
fa74b241
CY
5123 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5124 Doc fix.
5125
3c9dfce6
CY
5126 * xselect.c (Fx_selection_exists_p): Doc fix.
5127 (x_clipboard_manager_save_all): Print an informative message
5128 before saving to clipboard manager.
5129
9486df08
CY
51302012-02-24 Chong Yidong <cyd@gnu.org>
5131
5132 * keyboard.c (process_special_events): Handle all X selection
5133 requests in kbd_buffer, not just the next one (Bug#8869).
5134
f01d3321
CY
51352012-02-23 Chong Yidong <cyd@gnu.org>
5136
5137 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5138 call when setting menu-bar-lines and tool-bar-lines parameters.
5139 (unwind_create_frame_1): New helper function.
5140
5141 * window.c (inhibit_window_configuration_change_hook): New var.
5142 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5143 (syms_of_window): Initialize it.
f01d3321 5144
86b847b6
CY
51452012-02-22 Chong Yidong <cyd@gnu.org>
5146
5147 * xterm.c (x_draw_image_relief): Add missing type check for
5148 Vtool_bar_button_margin (Bug#10743).
5149
a59225b1
CY
51502012-02-21 Chong Yidong <cyd@gnu.org>
5151
5152 * fileio.c (Vfile_name_handler_alist): Doc fix.
5153
5154 * buffer.c (Fget_file_buffer): Protect against invalid file
5155 handler return value.
5156
310f5bd4
PE
51572012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5158
cb3a28cc
PE
5159 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5160 when computing $valmask.
5161
310f5bd4
PE
5162 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5163 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5164 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5165 It's useless in that case, and it can cause problems on hosts
5166 that allocate halves of EMACS_INT values separately.
5167 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5168 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5169 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5170 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5171 it avoids undefined behavior on hosts where shifting right by more
5172 than the word width has undefined behavior.
5173
2375c96a
CY
51742012-02-19 Chong Yidong <cyd@gnu.org>
5175
5176 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5177 (Funhandled_file_name_directory, Ffile_name_as_directory)
5178 (Fdirectory_file_name, Fexpand_file_name)
5179 (Fsubstitute_in_file_name): Protect against invalid file handler
5180 return values (Bug#10845).
5181
3eb49e71
EZ
51822012-02-18 Eli Zaretskii <eliz@gnu.org>
5183
5184 * .gdbinit (pitx): Fix incorrect references to fields of the
5185 iterator stack.
5186
7b926f3f
CY
51872012-02-17 Chong Yidong <cyd@gnu.org>
5188
5189 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5190
11273115
PE
51912012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5192
5193 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5194 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5195
c3a70e2b
CY
51962012-02-15 Chong Yidong <cyd@gnu.org>
5197
5198 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5199 marked as special. Also, starting docstrings with * is obsolete.
5200
0ca43699
AS
52012012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5202
5203 * gnutls.c (emacs_gnutls_write): Fix last change.
5204
2e8f3c56
LI
52052012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5206
5207 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5208 send_process.
5209
af70074f
SM
52102012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5211
5212 * keymap.c (Fsingle_key_description): Handle char ranges.
5213
95986d52
CY
52142012-02-12 Chong Yidong <cyd@gnu.org>
5215
afd83bd1
CY
5216 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5217 as that creates a dangerous corner case.
5218
95986d52
CY
5219 * window.c (Fdelete_window_internal): Invalidate the mouse
5220 highlight (Bug#9904).
5221
bd7da63e
GM
52222012-02-12 Glenn Morris <rgm@gnu.org>
5223
5224 * xselect.c (Fx_own_selection_internal)
5225 (Fx_get_selection_internal, Fx_disown_selection_internal)
5226 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5227 * nsselect.m (Fx_own_selection_internal)
5228 (Fx_disown_selection_internal, Fx_selection_exists_p)
5229 (Fx_selection_owner_p, Fx_get_selection_internal):
5230 Sync docs and argument specs with the xselect.c versions.
5231
77abcbc2
LI
52322012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5233
5234 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5235
90b671e2
EZ
52362012-02-11 Eli Zaretskii <eliz@gnu.org>
5237
1c0ca0b7
EZ
5238 * w32select.c (Fx_selection_exists_p): Sync doc string and
5239 argument list with xselect.c. (Bug#10783)
5240
5241 * w16select.c (Fx_selection_exists_p): Sync doc string and
5242 argument list with xselect.c. (Bug#10783)
90b671e2 5243
49241268
GM
52442012-02-10 Glenn Morris <rgm@gnu.org>
5245
5246 * fns.c (Fsecure_hash): Doc fix.
5247
f998bbe7 52482012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5249
5250 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5251
0992bd9c
CY
52522012-02-07 Chong Yidong <cyd@gnu.org>
5253
5254 * buffer.c (Fbuffer_local_variables)
5255 (buffer_lisp_local_variables): Handle unbound vars correctly;
5256 don't let Qunbound leak into Lisp.
5257
af008560
GM
52582012-02-07 Glenn Morris <rgm@gnu.org>
5259
dd605cc4
GM
5260 * image.c (Fimagemagick_types): Doc fix.
5261
af008560
GM
5262 * image.c (imagemagick-render-type): Change it from a lisp object
5263 to an integer. Move the doc here from the lisp manual.
5264 Treat all values not equal to 0 the same.
5265
1449fa1d
CY
52662012-02-06 Chong Yidong <cyd@gnu.org>
5267
5268 * doc.c (store_function_docstring): Avoid applying docstring of
5269 alias to base function (Bug#2603).
5270
3723ec07
AS
52712012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5272
5273 * .gdbinit (pp1, pv1): Remove redundant defines.
5274 (pr): Use pp.
5275
79c1cc1e
CY
52762012-02-04 Chong Yidong <cyd@gnu.org>
5277
5278 * nsterm.m: Declare a global (Bug#10694).
5279
d7f29f8e
EZ
52802012-02-04 Eli Zaretskii <eliz@gnu.org>
5281
cae07000
SM
5282 * w32.c (get_emacs_configuration_options):
5283 Include --enable-checking, if specified, in the return value.
d7f29f8e 5284
3b95a6f9
MR
52852012-02-04 Martin Rudalics <rudalics@gmx.at>
5286
5287 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5288 after rounding frame sizes. (Bug#9723)
5289
d6fa96a6
EZ
52902012-02-04 Eli Zaretskii <eliz@gnu.org>
5291
5292 * keyboard.c (adjust_point_for_property): Don't position point
5293 before BEGV. (Bug#10696)
5294
df0b2940
PE
52952012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5296
5297 Handle overflow when computing char display width (Bug#9496).
5298 * character.c (char_width): Return EMACS_INT, not int.
5299 (char_width, c_string_width): Check for overflow when
5300 computing the width; this is possible now that individual
5301 characters can have unbounded width. Problem introduced
5302 by merge from Emacs 23 on 2012-01-19.
5303
6bee44d6
MA
53042012-02-02 Michael Albinus <michael.albinus@gmx.de>
5305
5306 * dbusbind.c (Fdbus_register_method): Mention the return value
5307 :ignore in the docstring.
5308
44f92739
GM
53092012-02-02 Glenn Morris <rgm@gnu.org>
5310
1b9f60cc
GM
5311 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5312
44f92739
GM
5313 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5314 Unconditionally set to t. (Bug#10673)
5315 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5316 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5317 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5318
c5d3843c
KH
53192012-02-02 Kenichi Handa <handa@m17n.org>
5320
5321 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5322 0, do not call append_composite_glyph.
5323
159462d4 53242012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5325
5326 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5327 NULL (Bug#6988).
5328 (x_produce_glyphs): If the component of a composition is a null
5329 string, set it->pixel_width to 1 to avoid zero-width glyph.
5330
78cef877
EZ
53312012-02-01 Eli Zaretskii <eliz@gnu.org>
5332
5333 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5334 first 2 arguments are identical. This makes inserting large
5335 output from a subprocess an order of magnitude faster on
5336 MS-Windows, where all sbrk'ed memory is always contiguous.
5337
97897668
GM
53382012-01-31 Glenn Morris <rgm@gnu.org>
5339
5340 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5341 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5342 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5343
31fd3586
GM
53442012-01-29 Glenn Morris <rgm@gnu.org>
5345
5346 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5347
0e24a8b2
CY
53482012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5349
5350 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5351
cc0adcb0
CY
53522012-01-28 Chong Yidong <cyd@gnu.org>
5353
5354 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5355
acc28cb9
CY
53562012-01-26 Chong Yidong <cyd@gnu.org>
5357
9c69cfb7
CY
5358 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5359
acc28cb9
CY
5360 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5361 repeat counts (Bug#10507).
5362
48da7392
GM
53632012-01-26 Glenn Morris <rgm@gnu.org>
5364
5365 * lread.c (syms_of_lread): Doc fix.
5366
14af5f7f
CY
53672012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5368
5369 * coding.c (encode_designation_at_bol): Change return value to
5370 EMACS_INT.
5371
0b21c100
CY
53722012-01-25 Chong Yidong <cyd@gnu.org>
5373
5374 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5375
3c2907f7
CY
53762012-01-21 Chong Yidong <cyd@gnu.org>
5377
5378 * floatfns.c (Fcopysign): Make the second argument non-optional,
5379 since nil is not allowed anyway.
5380
959ad23f
AS
53812012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5382
5383 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5384 (send_process): Likewise.
5385
34a02f46
MR
53862012-01-19 Martin Rudalics <rudalics@gmx.at>
5387
5388 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5389 (Vwindow_persistent_parameters): Do not use Qstate.
5390 Rewrite doc-strings.
34a02f46 5391
1259009a 53922012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5393
5394 * character.c (char_width): New function.
70d4fdf6
GM
5395 (Fchar_width, c_string_width, lisp_string_width):
5396 Use char_width (Bug#9496).
25ed9e61 5397
6a6ee00d
MR
53982012-01-16 Martin Rudalics <rudalics@gmx.at>
5399
5400 * window.c (Vwindow_persistent_parameters): New variable.
5401 (Fset_window_configuration, save_window_save): Handle persistent
5402 window parameters.
5403
c85efaf7
EZ
54042012-01-14 Eli Zaretskii <eliz@gnu.org>
5405
5406 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5407 thrashing the stack of the thread. (Bug#9087)
5408
5944709e
PE
54092012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5410
5411 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5412
e71f5d99
EZ
54132012-01-11 Eli Zaretskii <eliz@gnu.org>
5414
5415 * xdisp.c (rows_from_pos_range): Handle the case where the
5416 highlight ends on a newline. (Bug#10464)
5417 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5418 he end column for display of highlight that ends on a newline
5419 before a R2L line.
5420
ce316182
GM
54212012-01-11 Glenn Morris <rgm@gnu.org>
5422
5423 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5424 from load-path also when installation-directory is nil. (Bug#10208)
5425
5b43da69
GM
54262012-01-10 Glenn Morris <rgm@gnu.org>
5427
74cc8ff9
GM
5428 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5429
7d8d6e4e
GM
5430 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5431 Update template values to be closer to their typical values these days.
5b43da69 5432
a0db8d43
EZ
54332012-01-09 Eli Zaretskii <eliz@gnu.org>
5434
5435 * xdisp.c (rows_from_pos_range): Accept additional argument
5436 DISP_STRING, and accept any glyph in a row whose object is that
5437 string as eligible for mouse highlight. Fixes mouse highlight of
5438 display strings from overlays. (Bug#10464)
5439
9a0115ab 54402012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5441
b9110d6a 5442 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5443 * fileio.c (auto_saving_dir_umask): New static var.
5444 (Fmake_directory_internal): Use it.
5445 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5446 creating the directory. The old code temporarily assigns
5447 too-generous permissions to the directory.
5448 (do_auto_save_eh): Clear it.
b9110d6a 5449 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5450 that the var is always cleared.
5451
6c1bd3f3
EZ
54522012-01-07 Eli Zaretskii <eliz@gnu.org>
5453
5454 * search.c (scan_buffer): Pass character positions to
5455 know_region_cache, not byte positions. (Bug#6540)
5456
069d2b50
L
54572012-01-07 LynX <_LynX@bk.ru> (tiny change)
5458
5459 * w32.c (sys_rename): Report EXDEV when rename of a directory
5460 fails because the target is on another logical disk. (Bug#10284)
5461
75bf0d33
DB
54622012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5463
5464 * xterm.c (x_embed_request_focus): New function.
5465
5466 * xterm.h: Add prototype.
5467
5468 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5469
1c6e5a32
GM
54702012-01-05 Glenn Morris <rgm@gnu.org>
5471
5472 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5473
651e947e
EZ
54742012-01-01 Eli Zaretskii <eliz@gnu.org>
5475
5476 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5477 Load gnutls_transport_set_lowat only if GnuTLS version is below
5478 2.11.1.
5479 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5480 GnuTLS versions below 2.11.1.
5481
3778cdd8
AL
54822011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5483
5484 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5485 to the doc string advising against its use for altering the way
5486 windows are scrolled.
5487
0e5317f7
KH
54882011-12-28 Kenichi Handa <handa@m17n.org>
5489
5490 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5491 coding-system ASCII compatible only when it does not produce BOM
5492 on encoding (Bug#10383).
5493
93d5ca1f
JD
54942011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5495
5496 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5497 can scroll.
5498 (create_and_show_popup_menu): Always use menu_position_func for
5499 Gtk3 (Bug#10361).
5500
ca22b785
AS
55012011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5502
5503 * callint.c (Fcall_interactively): Don't truncate prompt string.
5504
d048e1e6
EZ
55052011-12-23 Eli Zaretskii <eliz@gnu.org>
5506
5507 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5508 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5509 resumed from there (after widening). (Bug#10360)
d048e1e6 5510
5ccaba1f
JD
55112011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5512
5513 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5514
204ee57f
JD
55152011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5516
b81d40f0
JB
5517 * nsterm.m (x_free_frame_resources):
5518 Release f->output_data.ns->miniimage.
204ee57f
JD
5519 (ns_index_color): Fix indentation. Do not retain
5520 color_table->colors[i].
5521
5522 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5523 before returning.
5524
5525 * nsfns.m (x_set_background_color): Assign return value from
5526 ns_index_color to face-background instead of NSColor*.
5527 (ns_implicitly_set_icon_type): Fix indentation.
5528 Change assignment in for loop to comparison.
5529
5530 * emacs.c (ns_pool): New variable.
5531 (main): Assign ns_pool.
5532 (Fkill_emacs): Call ns_release_autorelease_pool.
5533
5534 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5535 autorelease fdesc, release fdAttrs and tdict.
5536 (ns_get_covering_families): Release charset.
5537 (ns_findfonts): Release NSFontDescriptor created with new.
5538 (ns_uni_to_glyphs): Fix indentation.
5539 (setString): Release attrStr before assigning new value.
5540
c803b2b7
JD
55412011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5542
678f4426
JD
5543 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5544 and NS_IMPL_COCOA.
5545 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5546 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5547
cd394be1 55482011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5549
5fecd5fc
JD
5550 * nsterm.m (ns_term_init): Subscribe for notifications
5551 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5552 to method trackingNotification in EmacsMenu.
5553
5554 * nsmenu.m (trackingMenu): New variable.
3771cb17 5555 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5556 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5557 from Aquamacs (Bug#7030).
678f4426
JD
5558
55592011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5560
c803b2b7
JD
5561 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5562 (symbol_to_nsstring): Fix indentation.
5563 (ns_symbol_to_pb): New function.
cae07000
SM
5564 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5565 (Fns_rotate_cut_buffers_internal): Remove.
5566 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5567 Fns_store_cut_buffer_internal.
5568 (ns_get_foreign_selection, Fx_own_selection_internal)
5569 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5570 (Fns_get_selection_internal, Fns_store_selection_internal):
5571 Use ns_symbol_to_pb and check if return value is nil.
5572 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5573 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5574 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5575 renamed to Sns_store_selection_internal.
5576 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5577 and remove this function.
5578 (ns_handle_selection_clear): Remove, never used.
5579 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5580 here.
5581
e1b01a3a
KB
55822011-12-17 Ken Brown <kbrown@cornell.edu>
5583
5584 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5585 GID is unknown (Bug#10257).
5586
2adb6e85
PE
55872011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5588
5589 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5590 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5591 which caused a build failure on GNU/Linux IA-64. This problem was
5592 introduced by my 2011-10-07 patch.
5593
d1d7b339
JL
55942011-12-15 Juri Linkov <juri@jurta.org>
5595
5596 * image.c (imagemagick_error): New function. (Bug#10112)
5597 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5598 Use `imagemagick_error' where ImageMagick functions return
5599 `MagickFalse'.
5600 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5601 proper order.
5602
100d5755
KH
56032011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5604
5605 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5606 fill background (Bug#8992).
5607
454592a6
MR
56082011-12-13 Martin Rudalics <rudalics@gmx.at>
5609
5610 * window.c (Vwindow_combination_resize)
5611 (Vwindow_combination_limit): Use t instead of non-nil in
5612 doc-strings.
61d4b438
MR
5613 (Vrecenter_redisplay): Add first sentence of doc-string on
5614 separate line.
53524d93 5615 (Frecenter): Fix doc-string typo.
454592a6 5616
3633e3aa
KH
56172011-12-11 Kenichi Handa <handa@m17n.org>
5618
5619 * coding.c (Funencodable_char_position): Pay attention to the
5620 buffer text relocation (Bug#9389).
5621
7b9d523a 56222011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5623
7b9d523a
JD
5624 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5625 gtk_init (Bug#10100).
5626
b73189c6
EZ
56272011-12-10 Eli Zaretskii <eliz@gnu.org>
5628
5629 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5630 IT->string is nil. (Bug#10263)
5631
f7dfe5d6
JD
56322011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5633
83faebb4
JD
5634 * nsterm.h (x_free_frame_resources): Declare.
5635
f7dfe5d6
JD
5636 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5637 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5638
5639 * nsterm.h (ns_get_defaults_value): Declare.
5640
5641 * nsterm.m (ns_default): Call ns_get_defaults_value.
5642
7cd4e72c
EZ
56432011-12-09 Eli Zaretskii <eliz@gnu.org>
5644
5645 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5646 (Bug#10170)
5647
b34d7317
YM
56482011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5649
5650 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5651 that where the value of an _OBJC_* symbol points to is in the .bss
5652 section (Bug#10240).
5653
76470ad1
KH
56542011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5655
5656 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5657 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5658
745fff94
KH
56592011-12-08 Kenichi Handa <handa@m17n.org>
5660
5661 * ftfont.c (get_adstyle_property): Fix previous change
5662 (Bug#10233).
5663
6e44397c
JB
56642011-12-07 Juanma Barranquero <lekktu@gmail.com>
5665
5666 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5667 dirs from the default value of EMACSLOADPATH (bug#10208).
5668
7efa6272
GM
56692011-12-07 Glenn Morris <rgm@gnu.org>
5670
5671 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5672 installation and source directories as well. (Bug#10208)
5673
f6fc4d87
CY
56742011-12-06 Chong Yidong <cyd@gnu.org>
5675
5676 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5677
2bf26180
GM
56782011-12-06 Glenn Morris <rgm@gnu.org>
5679
5680 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5681 as an error, not just -1. (Bug#10217)
5682
3a6ad4f0
CY
56832011-12-05 Chong Yidong <cyd@gnu.org>
5684
5685 * keyboard.c (process_special_events): New function.
5686 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5687
75a3b399
PE
56882011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5689
5690 * coding.c (encode_designation_at_bol): Don't use uninitialized
5691 local variable (Bug#9318).
5692
c3c9e25e
KH
56932011-12-05 Kenichi Handa <handa@m17n.org>
5694
5695 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5696 return Qnil (Bug#8046, Bug#10193).
5697
5eb05ea3
KH
56982011-12-05 Kenichi Handa <handa@m17n.org>
5699
5700 * coding.c (encode_designation_at_bol): New args charbuf_end and
5701 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5702 (coding_set_source): Return how many bytes coding->source was
5703 relocated.
5704 (coding_set_destination): Return how many bytes
5705 coding->destination was relocated.
5706 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5707 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5708
57092011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5710
5711 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5712 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5713 macro (Bug#9318).
5714
57152011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5716
5717 The following changes are to fix Bug#9318.
5718
a79703f5 5719 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5720 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5721 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5722 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5723
7dbda6df
JB
57242011-12-05 Juanma Barranquero <lekktu@gmail.com>
5725
5726 * lisp.h (process_quit_flag): Fix external declaration.
5727
6d5eb5b0
SM
57282011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5729
5730 Don't macro-inline non-performance-critical code.
5731 * eval.c (process_quit_flag): New function.
5732 * lisp.h (QUIT): Use it.
5733
a0c3fad0
JD
57342011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5735
5736 * nsfns.m (get_geometry_from_preferences): New function.
5737 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5738
6c07aac2
AS
57392011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5740
5741 * emacs.c (Qkill_emacs): Define.
5742 (syms_of_emacs): Initialize it.
5743 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5744 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5745 (quit_throw_to_read_char): Add parameter `from_signal'.
5746 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5747 * lisp.h (QUIT): Call Fkill_emacs if requested.
5748
c052ead4
JD
57492011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5750
5751 * widget.c (update_wm_hints): Return if wmshell is null.
5752 (widget_update_wm_size_hints): New function.
5753
5754 * widget.h (widget_update_wm_size_hints): Declare.
5755
5756 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5757 widget_update_wm_size_hints (Bug#10104).
5758
9e49252b
EZ
57592011-12-03 Eli Zaretskii <eliz@gnu.org>
5760
5761 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5762 before a newline, prepare the bidi iterator for consuming the
5763 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5764 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5765
02b16839
JL
57662011-12-02 Juri Linkov <juri@jurta.org>
5767
5768 * search.c (Fword_search_regexp): New Lisp function created from
5769 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5770 (Fword_search_backward, Fword_search_forward)
5771 (Fword_search_backward_lax, Fword_search_forward_lax):
5772 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5773 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5774
0068070e
SM
57752011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5776
5777 * fileio.c (Finsert_file_contents): Move after-change-function call
5778 to before the "handled:" label, since all "goto handled" appear in
5779 cases where the *-change-functions have already been properly called
5780 (bug#10117).
5781
3360a3fc
AS
57822011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5783
5784 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5785 waiting for input. (Bug#10169)
5786
73d6c093
EZ
57872011-11-30 Eli Zaretskii <eliz@gnu.org>
5788
5789 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5790 verifies glyph row's hash code--we have just reallocated the
5791 glyphs, so their contents can be complete garbage. (Bug#10164)
5792
febe6bea
JB
57932011-11-30 Juanma Barranquero <lekktu@gmail.com>
5794
5795 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5796
801a4313
EZ
57972011-11-30 Eli Zaretskii <eliz@gnu.org>
5798
5799 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5800 attributes are tested _before_ calling verify_row_hash, to protect
5801 against GCC re-ordering of the tests. (Bug#10164)
5802
2b56b87e
JD
58032011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5804
5805 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5806
5807 * xterm.c (handle_one_xevent): Only set async_visible and friends
5808 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5809 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5810 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5811
dbf31225
PE
58122011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5813
5814 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5815 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5816 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5817 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5818 All uses changed to use GCPRO1 etc.
5819 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5820 Revert to old implementation (i.e., before 2011-03-11).
5821
1305621b
YM
58222011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5823
5824 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5825 of scroll runs so as to avoid assigning disabled bogus rows and
5826 unnecessary graphics copy operations.
5827
8c9afb46
EZ
58282011-11-27 Eli Zaretskii <eliz@gnu.org>
5829
5830 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5831 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5832 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5833 (malloc, free, realloc, calloc): Redirect to e_* only when
5834 compiling Emacs.
5835
5836 * lisp.h (GCTYPEBITS): Move before first use.
5837 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5838 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5839 this macro definition.
5840
5841 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5842 _MSC_VER.
5843
54e9e3bf
JD
58442011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5845
6d5eb5b0
SM
5846 * gtkutil.c (xg_create_frame_widgets):
5847 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5848 present with Gtk+ 2.0.
5849
83aca1cb
PE
58502011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5851
5852 * fileio.c (Finsert_file_contents): Undo previous change; see
5853 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5854
5b76caa4
PE
58552011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5856
5857 Rename locals to avoid shadowing.
5858 * fileio.c (Finsert_file_contents):
5859 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5860 * process.c (wait_reading_process_output):
5861 Rename inner 'proc' to 'p' to avoid shadowing.
5862 Indent for consistency with usual Emacs style.
5863
8c535114
EZ
58642011-11-25 Eli Zaretskii <eliz@gnu.org>
5865
5866 * xdisp.c (redisplay_window): If cursor row is not fully visible
5867 after recentering, and scroll-conservatively is set to a large
5868 number, scroll window by a few more lines to make the cursor fully
5869 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5870 (start_display): Don't move to the next line if the display should
5871 start at a newline that is part of a display vector or an overlay
5872 string. (Bug#10119)
8c535114 5873
fa4fdb5c
JL
58742011-11-24 Juri Linkov <juri@jurta.org>
5875
5876 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5877 after the `MagickPingImage' call. (Bug#10112)
5878
90ec88df
CY
58792011-11-23 Chong Yidong <cyd@gnu.org>
5880
5881 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5882
56e2e794
MR
58832011-11-23 Martin Rudalics <rudalics@gmx.at>
5884
5885 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5886 making another buffer current. (Bug#10114)
5887
b6e64c41
GM
58882011-11-23 Glenn Morris <rgm@gnu.org>
5889
5890 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5891
6b21de18
CY
58922011-11-23 Chong Yidong <cyd@gnu.org>
5893
5894 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5895 using it (Bug#5984).
5896
b12cd789
EZ
58972011-11-22 Eli Zaretskii <eliz@gnu.org>
5898
5899 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5900 and header-lines, as they don't have one computed for them.
5901 (Bug#10098)
5902
5903 * .gdbinit (prow): Make displayed values more self-explaining.
5904 Add row's hash code.
5905
261b6fd4
LMI
59062011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5907
5908 * process.c (wait_reading_process_output): Fix asynchrounous
5909 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5910 (wait_reading_process_output): Add comment and URL.
261b6fd4 5911
e7cfd277
JD
59122011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5913
5914 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5915
a9b9b7f5
CY
59162011-11-21 Chong Yidong <cyd@gnu.org>
5917
5918 * window.c (Fnext_window, Fprevious_window): Doc fix.
5919
b0d15b4f
SM
59202011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5921
5922 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5923
fe7a3057
JB
59242011-11-20 Juanma Barranquero <lekktu@gmail.com>
5925
5926 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5927
d2999b1a
MR
59282011-11-20 Martin Rudalics <rudalics@gmx.at>
5929
5930 * window.c (Fset_window_combination_limit): Rename argument
5931 STATUS to LIMIT.
5932 (Vwindow_combination_limit): Remove "status" from doc-string.
5933
d5ff9cd0
AS
59342011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5935
5936 * m/ibms390.h: Remove.
5937 * m/ibms390x.h: Don't include "ibms390.h".
5938
a5bb9bd3
SM
59392011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5940
5941 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5942 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5943
cd1181db
JB
59442011-11-20 Juanma Barranquero <lekktu@gmail.com>
5945
5946 * casetab.c (Fset_case_table):
5947 * charset.c (Fcharset_after): Fix typos.
5948
615a3b8d 59492011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5950
17e845af
PE
5951 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5952 Otherwise, valgrind does not work on some platforms.
5953 Problem reported by Andreas Schwab in
6a0bf43d
PE
5954 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5955 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5956 is set, removing the need for VIRT_ADDRESS_VARIES.
5957 (PURE_P): Use a more-efficient implementation that needs just one
5958 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5959 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5960 to 4 (xorl, subq, cmpq, setbe).
5961 * alloc.c (pure): Always extern now, since that's the
5962 VIRT_ADDR_VARIES behavior.
5963 (PURE_POINTER_P): Use a single comparison, not two, for
5964 consistency with the new puresize.h.
5965 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5966 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5967 Remove VIRT_ADDR_VARIES no longer needed.
5968
f8fe6f96
EZ
59692011-11-19 Eli Zaretskii <eliz@gnu.org>
5970
5971 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5972 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5973 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5974 behave as if the cursor position were at the window margin.
5975
5976 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5977 and the cursor position is out of bounds, behave as if the cursor
5978 position were at the window margin. (Bug#10075)
5979
df05a53c
CY
59802011-11-18 Chong Yidong <cyd@gnu.org>
5981
5982 * window.c (Fwindow_combination_limit): Make first argument
5983 non-optional, since it is meaningless for live windows like the
5984 selected window.
61ccba97 5985
2071918e
DA
59862011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5987
5988 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5989
b50a28de
SM
59902011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5991
5992 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5993 (graft_intervals_into_buffer): Simplify.
5994
015137db
EZ
59952011-11-18 Eli Zaretskii <eliz@gnu.org>
5996
5997 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5998 hash values of the two rows.
5999 (copy_row_except_pointers): Preserve the used[] arrays and the
6000 hash values of the two rows. (Bug#10035)
68c95424 6001 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6002
6003 * xdisp.c (row_hash): New function, body extracted from
6004 compute_line_metrics.
6005 (compute_line_metrics): Call row_hash, instead of computing the
6006 hash code inline.
6007
6008 * dispnew.c (verify_row_hash): Call row_hash for computing the
6009 hash code of a row, instead of duplicating code from xdisp.c.
6010
6011 * dispextern.h (row_hash): Add prototype.
6012
a2addb04
TH
60132011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6014
6015 * frame.c (delete_frame): Don't delete the terminal when the last
6016 X frame is closed if emacs is built with GTK toolkit.
6017
df85d315
JB
60182011-11-17 Juanma Barranquero <lekktu@gmail.com>
6019
6020 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6021
a0c2d0ae
MR
60222011-11-17 Martin Rudalics <rudalics@gmx.at>
6023
6024 * window.c (Vwindow_splits): Rename to
6025 Vwindow_combination_resize. Suggested by Juri Linkov.
6026 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6027 of Vwindow_splits.
6028
58179cce
JB
60292011-11-16 Juanma Barranquero <lekktu@gmail.com>
6030
7877f373
JB
6031 * nsfns.m (Fns_font_name):
6032 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6033
b6f67890
MR
60342011-11-16 Martin Rudalics <rudalics@gmx.at>
6035
6036 * window.h (window): Rename slot "nest" to "combination_limit".
6037 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6038 (Fset_window_nest): Rename to Fset_window_combination_limit.
6039 (Vwindow_nest): Rename to Vwindow_combination_limit.
6040 (recombine_windows, make_parent_window, make_window)
6041 (Fsplit_window_internal, saved_window)
6042 (Fset_window_configuration, save_window_save): Rename all
6043 occurrences of window_nest to window_combination_limit.
6044
c7015153
JB
60452011-11-15 Juanma Barranquero <lekktu@gmail.com>
6046
6047 * image.c (imagemagick_load_image): Fix typo.
6048
322ad6ec
EZ
60492011-11-14 Eli Zaretskii <eliz@gnu.org>
6050
6051 * xdisp.c (display_line): Move the call to
6052 highlight_trailing_whitespace before the call to
6053 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6054 faces of all the glyphs to compute ROW's hash value.
6055 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6056
f067b8ec
JB
60572011-11-14 Juanma Barranquero <lekktu@gmail.com>
6058
6059 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6060 just return (bug#10044).
6061
1e5b2111
EZ
60622011-11-12 Eli Zaretskii <eliz@gnu.org>
6063
7ef3cbd5
EZ
6064 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6065 with user-defined heap size. Bump the default size of the temacs
6066 heap to 27MB, to avoid memory warning when running temacs.
6067 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6068
1e5b2111
EZ
6069 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6070 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6071 (verify_row_hash) [XASSERTS]: New function.
6072 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6073 that the hash value of glyph rows is correct.
1e5b2111 6074
89d61221
MR
60752011-11-12 Martin Rudalics <rudalics@gmx.at>
6076
6077 * window.h (window): Remove splits slot.
6078 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6079 (Fdelete_other_windows_internal, make_parent_window)
6080 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6081 (Fset_window_configuration, save_window_save): Don't deal with
6082 split status of windows.
6083 (saved_window): Remove splits slot.
6084 (Vwindow_splits): Rewrite doc-string.
6085
97f18cc8
JD
60862011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6087
6088 * xfns.c (unwind_create_frame):
6089 * nsfns.m (unwind_create_frame):
6090 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6091 Vframe_list (Bug#9999).
6092
22a648b4
DA
60932011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6094
0b381c7e 6095 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6096
659afede
KH
60972011-11-11 Kenichi Handa <handa@m17n.org>
6098
6099 * callproc.c (Fcall_process): Set the member dst_multibyte of
6100 process_coding.
6101
9ac0394b
KH
61022011-11-11 Johan Bockgård <bojohan@gnu.org>
6103
6104 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6105 avoid a crash (bug#9496).
6106
2fbdc249
CY
61072011-11-09 Chong Yidong <cyd@gnu.org>
6108
6109 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6110 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6111
ac6b1f81
PE
61122011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6113
6114 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6115
09db192c
PE
61162011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6117
6118 Avoid some portability problems by eschewing 'extern inline' functions.
6119 The trivial performance wins aren't worth the portability hassles; see
6120 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6121 et seq.
6122 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6123 (window_box_width, window_box_left, window_box_left_offset)
6124 (window_box_right, window_box_right_offset): Undo previous change,
6125 by removing the "extern"s.
6126 * intervals.c (adjust_intervals_for_insertion)
6127 (adjust_intervals_for_deletion): Undo previous change,
6128 making these static again.
6129 (offset_intervals, temp_set_point_both, temp_set_point)
6130 (copy_intervals_to_string): No longer inline.
6131 * xdisp.c (window_text_bottom_y, window_box_width)
6132 (window_box_height, window_box_left_offset)
6133 (window_box_right_offset, window_box_left, window_box_right)
6134 (window_box): No longer inline.
6135
105216ed
CY
61362011-11-08 Chong Yidong <cyd@gnu.org>
6137
6138 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6139 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6140 Signal an error if not a live window.
105216ed
CY
6141 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6142 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6143
ae9e237f
JB
61442011-11-07 Juanma Barranquero <lekktu@gmail.com>
6145
6146 * lisp.h (syms_of_abbrev): Remove declaration.
6147 Reported by CHENG Gao <chenggao@royau.me>.
6148
c7aa8333
EZ
61492011-11-07 Eli Zaretskii <eliz@gnu.org>
6150
6151 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6152 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6153 of temacs in GUI mode.
6154
be7f5545
MR
61552011-11-07 Martin Rudalics <rudalics@gmx.at>
6156
6157 * window.h: Declare delete_all_child_windows instead of
6158 delete_all_subwindows.
6159 * window.c (Fwindow_nest, Fset_window_nest)
6160 (Fset_window_new_total, Fset_window_new_normal)
6161 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6162 (delete_all_subwindows): Rename to delete_all_child_windows.
6163 (Fdelete_other_windows_internal, Fset_window_configuration):
6164 Call delete_all_child_windows instead of delete_all_subwindows.
6165 * frame.c (delete_frame): Call delete_all_child_windows instead
6166 of delete_all_subwindows.
6167
ca78dc43
PE
61682011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6169
6170 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6171 This is also needed for porting to any host where GC_MARK_STACK is
6172 not GC_MAKE_GCPROS_NOOPS.
6173 (which_symbols): Use it.
6174
a0241d01
KH
61752011-11-07 Kenichi Handa <handa@m17n.org>
6176
6177 * coding.c (coding_set_destination): Check coding->src_pos only
6178 when coding->src_object is a buffer (bug#9910).
6179
6180 * process.c (send_process): Set the member src_multibyte of coding
6181 to 0 (bug#9911) when sending a unibyte text.
6182
6183 * callproc.c (Fcall_process): Set the member src_multibyte of
6184 process_coding to 0 (bug#9912).
6185
a64bfdfa 61862011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6187
6188 * xmenu.c (cleanup_widget_value_tree): New function.
6189 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6190 calling free_menubar_widget_value_tree directly (Bug#9830).
6191
cb41b32a
PE
61922011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6193
6194 Fix some portability problems with 'inline'.
6195 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6196 (window_box_width, window_box_left, window_box_left_offset)
6197 (window_box_right, window_box_right_offset): Declare extern.
6198 Otherwise, these inline functions do not conform to C99 and
6199 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6200 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6201 * intervals.c (adjust_intervals_for_insertion)
6202 (adjust_intervals_for_deletion): Now extern, because otherwise the
6203 extern inline functions 'offset_intervals' couldn't refer to it.
6204 (static_offset_intervals): Remove.
6205 (offset_intervals): Rewrite using the old contents of
6206 static_offset_intervals. The old version didn't conform to C99
6207 because an extern inline function contained a reference to an
6208 identifier with static linkage.
6209
b7041366
AS
62102011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6211
6212 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6213 GC.
6214
88a37c4d
EZ
62152011-11-06 Eli Zaretskii <eliz@gnu.org>
6216
6217 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6218 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6219 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6220 return Qleft_to_right.
6221
49745b39
CY
62222011-11-06 Chong Yidong <cyd@gnu.org>
6223
6224 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6225 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6226 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6227 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6228 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6229 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6230 (Fwindow_vscroll): Doc fix.
6231 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6232 argument, since it makes no sense to pass a live window and for
6233 consistency with window-child.
6234
1f05cd82
CS
62352011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6236
6237 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6238 support MSVC.
6239
22610910
JR
62402011-11-05 Jason Rumney <jasonr@gnu.org>
6241
6242 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6243 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6244 fonts (Bug#6029).
6245 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6246 bitwise arithmetic preventing use of unicode-sip and non-truetype
6247 opentype fonts.
6248
a06776b2
EZ
62492011-11-05 Eli Zaretskii <eliz@gnu.org>
6250
3ad924ba
EZ
6251 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6252 "emacs"-only part.
6253
a06776b2
EZ
6254 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6255 initialization code to keep similarity to xfns.c after changes
6256 from 2011-11-05.
6257
c9e7db78
JD
62582011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6259
a97f8f3f
JD
6260 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6261 (unwind_create_frame): New function (Bug#9943).
6262 (Fx_create_frame): Restructure code to be more similar to the one in
6263 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6264 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6265 Move terminal->reference_count++ just before making the frame official
6266 (Bug#9943).
6267
6268 * nsterm.m (x_free_frame_resources): New function.
6269 (x_destroy_window): Move code to x_free_frame_resources.
6270
c9e7db78 6271 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6272 (Fx_create_frame, x_create_tip_frame):
6273 Move terminal->reference_count++ just before making the frame
75f1671a 6274 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6275 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6276
a6fc3b5c
EZ
62772011-11-05 Eli Zaretskii <eliz@gnu.org>
6278
6279 Support MSVC build with newer versions of Visual Studio.
6280 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6281 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6282 nt/gmake.defs.
6283
6284 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6285 which are not supported by MSVC.
6286 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6287 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6288 bitfields.
6289 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6290 types in bitfields.
6291 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6292
6293 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6294
58179cce 62952011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6296
6297 Support MSVC build with newer versions of Visual Studio.
6298 * w32.c: Don't include w32api.h for MSVC.
6299 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6300
6301 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6302 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6303 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6304 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6305 e_* cousins.
6306 (alloca) [_MSC_VER]: Define to _alloca.
6307
6308 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6309
6310 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6311
a58c13ed
EZ
63122011-11-04 Eli Zaretskii <eliz@gnu.org>
6313
6314 * xdisp.c (note_mouse_highlight): If either of
6315 previous/next-single-property-change returns nil, treat that as
6316 the beginning or the end of the buffer. (Bug#9955)
6317
fe0b6370
JD
63182011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6319
a58c13ed 6320 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6321 label is not null (Bug#9951).
6322 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6323 may be NULL.
6324
89bd5ee1
EZ
63252011-11-04 Eli Zaretskii <eliz@gnu.org>
6326
6327 * window.c (Fwindow_body_size): Mention in the doc string that the
6328 return value is in frame's canonical units. (Bug#9949)
6329
84c3edb9
EZ
63302011-11-03 Eli Zaretskii <eliz@gnu.org>
6331
4e2fb5c7
EZ
6332 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6333
84c3edb9 6334 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6335 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6336 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6337
bc17a887
EZ
63382011-11-01 Eli Zaretskii <eliz@gnu.org>
6339
6340 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6341 Don't stop backward scan on the continuation glyph, even though
6342 its CHARPOS is positive.
6d5eb5b0
SM
6343 (mouse_face_from_buffer_pos, note_mouse_highlight):
6344 Rename cover_string to disp_string.
bc17a887 6345
4ee88440
MR
63462011-11-01 Martin Rudalics <rudalics@gmx.at>
6347
6348 * window.c (temp_output_buffer_show): Don't use
6349 Vtemp_buffer_show_specifiers.
6350 (Vtemp_buffer_show_specifiers): Remove unused variable.
6351
c2ff3c02
EZ
63522011-10-30 Eli Zaretskii <eliz@gnu.org>
6353
6354 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6355 past the beginning of the current glyph matrix.
6356
58179cce 63572011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6358
6359 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6360 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6361 HAVE_GTK3 (Bug#9869).
b77a6a7f 6362
3b574623
JD
6363 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6364 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6365
b77a6a7f
JD
6366 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6367
6368 * xterm.c: Declare x_handle_net_wm_state to return int.
6369 (handle_one_xevent): Check if we are iconified but don't have
6370 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6371 (get_current_wm_state): Return non-zero if not hidden,
6372 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6373 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6374 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6375 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6376
196e41e4
PE
63772011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6378
6379 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6380 so that this new function doesn't get optimized away by a
6381 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6382
021f2e1a
AS
63832011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6384
6385 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6386
8b058d44
EZ
63872011-10-29 Eli Zaretskii <eliz@gnu.org>
6388
6389 Fix the `xbytecode' command.
6390 * .gdbinit (xprintbytestr): New command.
b50a28de 6391 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6392 (xbytecode): Print the byte-code string as well.
6393
4452fb80
EZ
63942011-10-29 Kim Storm <storm@cua.dk>
6395
8b058d44
EZ
6396 * alloc.c (which_symbols): New function.
6397
21b72067
AS
63982011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6399
6400 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6401 line. (Bug#9903)
6402
83ed7b5c
GM
64032011-10-29 Glenn Morris <rgm@gnu.org>
6404
6405 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6406 Not clear what it was for, and it causes various bugs. (Bug#9839)
6407
5a7a728b
EZ
64082011-10-28 Eli Zaretskii <eliz@gnu.org>
6409
6410 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6411 possible random value that matches one of those tested as
6412 condition to clear the mouse face.
6413
d3d0842f
CY
64142011-10-28 Chong Yidong <cyd@gnu.org>
6415
6416 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6417
31b39d13
DN
64182011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6419
6420 * window.c (make_window): Initialize phys_cursor_on_p.
6421
9aba6043
SM
64222011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6423
6424 * lisp.h (struct Lisp_Symbol): Update comments.
6425
c20992f4
JB
64262011-10-28 Juanma Barranquero <lekktu@gmail.com>
6427
6428 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6429
db4f02f2
EZ
64302011-10-28 Eli Zaretskii <eliz@gnu.org>
6431
6432 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6433 <oslsachem@gmail.com> for helping to debug this.
6434
6435 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6436 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6437 (g_b_init_get_glyph_outline_w): New static variables.
6438 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6439 (GetGlyphOutlineW_Proc): New typedefs.
6440 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6441 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6442 New functions.
6443 (w32font_open_internal, compute_metrics):
6444 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6445 instead of calling the "wide" APIs directly.
6446
6447 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6448
6449 * w32.h (syms_of_w32font): Add prototype.
6450
87e68db4
JB
64512011-10-27 Juanma Barranquero <lekktu@gmail.com>
6452
6453 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6454 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6455 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6456 (Fmove_to_window_line): Doc fix.
6457
435c1d67
CY
64582011-10-27 Chong Yidong <cyd@gnu.org>
6459
6460 * process.c (make_process): Set gnutls_state to NULL.
6461
6462 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6463 non-NULL, regardless of GNUTLS_INITSTAGE.
6464 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6465 an error. Set process slots as soon as we allocate them.
6466
6467 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6468
9c6c6f49
CY
64692011-10-27 Chong Yidong <cyd@gnu.org>
6470
9aba6043
SM
6471 * gnutls.c (emacs_gnutls_deinit): New function.
6472 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6473 (Fgnutls_deinit, Fgnutls_boot): Use it.
6474
6475 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6476 (deactivate_process): Call emacs_gnutls_deinit.
6477
657d08d3
JB
64782011-10-27 Juanma Barranquero <lekktu@gmail.com>
6479
6480 * image.c (x_create_x_image_and_pixmap):
6481 * w32.c (sys_rename, w32_delayed_load):
6482 * w32font.c (fill_in_logfont):
6483 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6484
5430d399
JB
64852011-10-26 Juanma Barranquero <lekktu@gmail.com>
6486
6487 * w32fns.c (w32_default_color_map): New function,
6488 extracted from Fw32_default_color_map.
a7ef684b 6489 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6490
fe0055fa
PE
64912011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6492
6493 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6494
e6346438
SM
64952011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6496
6497 * keyboard.c (test_undefined): New function (bug#9751).
6498 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6499
e112cc37
ET
65002011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6501
6502 * sysdep.c (init_sys_modes): Fix the check for the controlling
6503 terminal (Bug#6649).
6504
7b5d6677
EZ
65052011-10-20 Eli Zaretskii <eliz@gnu.org>
6506
6507 * dispextern.h (struct bidi_it): New member next_en_type.
6508
6509 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6510 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6511 current character, check also for next_en_type being WEAK_EN.
6512 (bidi_resolve_weak): Don't enter the expensive loop if the current
6513 position is before next_en_pos. Record the bidi type of the first
6514 non-ET, non-BN character we find, in addition to its position.
6515 (bidi_level_of_next_char): Invalidate next_en_type when
6516 next_en_pos is over-stepped.
6517
7da0b018
PE
65182011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6519
6520 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6521 * editfns.c: Rewrite current-time-zone so that it invokes
6522 the equivalent of (format-time-string "%Z") to get the time zone name.
6523 This fixes a bug when the time zone name contains characters that
6524 need converting from the system time locale to Emacs internal format.
6525 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6526 that patch fixed format-time-string to do the conversion, but
6527 I forgot to fix current-time-zone.
6528 (format_time_string): New function, containing most of
6529 what Fformat_time_string used to contain.
6530 (Fformat_time_string): Rewrite in terms of format_time_string.
6531 This doesn't change this function's behavior.
6532 (current-time-zone): Rewrite to use format_time_string.
6533 This fixes the bug reported by Michael Schierl in
6534 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6535 Jason Rumney's 2007-06-07 change worked around this bug, but
6536 didn't fix it.
6537 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6538
8547b010
EZ
65392011-10-19 Eli Zaretskii <eliz@gnu.org>
6540
6541 * xdisp.c (start_display): If the character at POS is displayed
6542 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6543 (try_window_reusing_current_matrix): If a line ends in a display
6544 vector or the next line starts in a display vector, continue
6545 redrawing the window even though the character position of
6546 start_row was reached.
8547b010
EZ
6547 (Bug#9771, part 2)
6548
4e948d15
CY
65492011-10-18 Chong Yidong <cyd@gnu.org>
6550
6551 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6552 with nobreak-char-display too.
6553
4787455f
EZ
65542011-10-18 Eli Zaretskii <eliz@gnu.org>
6555
6556 Fix part 3 of bug#9771.
6557 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6558 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6559 non-neutral characters if the current character is a paragraph
6560 separator (a.k.a. Newline). This avoids running the same
6561 expensive loop twice, once when we consume the preceding newline
6562 and the other time when the line actually needs to be displayed.
6563 Avoid the loop when we see neutrals on the base embedding level
6564 following a character whose directionality is the same as the
6565 paragraph's. This avoids running the expensive loop when a line
6566 ends in a long sequence of neutrals, like control characters.
6567 Add assertion against STRONG_AL type. Slightly rearrange code
6568 that determines the type of a neutral given the first non-neutral
6569 that follows it.
6570 (bidi_level_of_next_char): Set next_en_pos to zero when
6571 invalidating its info.
6572
2c91f553
EZ
65732011-10-17 Eli Zaretskii <eliz@gnu.org>
6574
6575 * xdisp.c (push_display_prop): Determine whether to record string
6576 or buffer position by IT->string, not by IT->method. Allow
6577 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6578 (move_it_vertically_backward): Don't look for character position
6579 immediately after the newline when in a continuation line.
6580 (Bug#9771, part 1)
2c91f553 6581
c7b08b0d
MR
65822011-10-15 Martin Rudalics <rudalics@gmx.at>
6583
6584 * window.c (coordinates_in_window): Rewrite and delabelize
6585 vertical border check. (Bug#5357) (Bug#9618)
6586
6b02f655
SM
65872011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6588
6589 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6590 errors in XSetWindowBorder (bug#9310).
6591
81d40c92
DA
65922011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6593
6594 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6595 avoid crash when xmalloc overrun checking is enabled.
6596
d4172c3b
EZ
65972011-10-13 Eli Zaretskii <eliz@gnu.org>
6598
6599 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6600 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6601 cursor motion with <left> and <right> arrow keys.
6602
6603 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6604 some callers set that themselves.
6605
b00eea75
EZ
66062011-10-12 Eli Zaretskii <eliz@gnu.org>
6607
6608 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6609 display string and the previous row comes from the same string and
6610 is empty. (Bug#9739) (Bug#9738)
6611
8fe012c4
SM
66122011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6613
6614 * doc.c (get_doc_string): Encode file name (bug#9735).
6615
0074aef2
EZ
66162011-10-12 Eli Zaretskii <eliz@gnu.org>
6617
79beb178
EZ
6618 * bidi.c (bidi_level_of_next_char):
6619 * xdisp.c (get_visually_first_element): Remove old incorrect
6620 comments regarding the Unicode Line Separator character.
6621
0074aef2
EZ
6622 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6623
6e4b3fbe
DA
66242011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6625
6626 * alloc.c (Fgc_status): Do not access beyond zombies array
6627 boundary if nzombies > MAX_ZOMBIES.
6628 * alloc.c (dump_zombies): Add missing format specifier.
6629
0324f3af
PE
66302011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6631
b5525cac
PE
6632 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6633 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6634
0324f3af
PE
6635 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6636 Some packages use them to denote characters with modifiers.
6637
e9b5f888
AS
66382011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6639
6640 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6641 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6642 matching a pp-number. Rename parameter var to var1.
6643
127827c0
SM
66442011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6645
6646 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6647
c8fd3bd0
GM
66482011-10-08 Glenn Morris <rgm@gnu.org>
6649
6650 * callint.c (Fcall_interactively): Give a more explicit error for the
6651 'c' case with a non-character input. (Bug#8479)
6652
352ec8ff
EZ
66532011-10-08 Eli Zaretskii <eliz@gnu.org>
6654
03669ccb
EZ
6655 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6656 lines.
7061c986
EZ
6657 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6658 lines that are hscrolled on the left.
03669ccb 6659
352ec8ff
EZ
6660 * dispnew.c (buffer_posn_from_coords): Account for a possible
6661 presence of header-line. (Bug#4426)
6662
a66cfb1c
SM
66632011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6664
6b02f655
SM
6665 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6666 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6667
7c5ee88e
PE
66682011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6669
6670 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6671 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6672 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6673 this makes Emacs dump core during garbage collection on rare
6674 occasions. sizeof is obviously inferior to offsetof here, so
6675 stick with offsetof.
6676 (GC_POINTER_ALIGNMENT): New macro.
6677 (mark_memory): Omit 3rd (offset) arg; caller changed.
6678 Don't assume EMACS_INT alignment is the same as pointer alignment.
6679
df1bbe5b
SM
66802011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6681
6682 * keyboard.c (read_key_sequence_remapped): New var.
6683 (read_key_sequence): Compute remapping in the right buffer.
6684 (command_loop_1): Use read_key_sequence's remapping directly.
6685
51553db6
SM
66862011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6687
32c1fffd
SM
6688 * dired.c (file_name_completion): Don't expand file name.
6689 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6690 before checking file name handler.
6691
51553db6
SM
6692 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6693 they've been requested explicitly (bug#9591).
6694
b6bd1599 66952011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6696
6697 * keymap.c (Fsingle_key_description): Use make_specified_string
6698 instead of build_string to build string from push_key_description.
6699 (Bug#5193)
6700
f701dc2a
PE
67012011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6702
4222c55d
PE
6703 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6704 This fixes a Y2038 bug on 64-bit hosts.
6705 * buffer.c (reset_buffer):
6706 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6707 (Fclear_buffer_auto_save_failure):
6708 Use 0, not -1, to represent an unset failure time, since time_t
6709 might not be signed.
6710
f701dc2a
PE
6711 Remove dependency on glibc malloc internals.
6712 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6713 Move back here from lisp.h, but with their new implementations.
6714 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6715 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6716 * charset.c (charset_table_init): New static var.
6717 (syms_of_charset): Use it instead of xmalloc. This removes a
6718 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6719 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6720 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6721 Move back to alloc.c.
6722 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6723 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6724
9ceebf39
JD
67252011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6726
6727 * nsterm.m (windowDidResize): Call x_set_window_size only when
6728 ns_in_resize is true. Otherwise set pixelwidth/height and
6729 call change_frame_size (Bug#9628).
6730
cb993c58
PE
67312011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6732
3930c88b
PE
6733 Port --enable-checking=all to Fedora 14 x86-64.
6734 * charset.c (syms_of_charset): Also account for glibc malloc's
6735 internal overhead when calculating the initial malloc maximum.
6736
cb993c58
PE
6737 Port --enable-checking=all to Fedora 14 x86.
6738 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6739 Move to lisp.h.
6740 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6741 (overrun_check_realloc, overrun_check_free):
6742 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6743 That way, xmalloc returns a properly-aligned pointer even if
6744 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6745 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6746 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6747 into account when calculating the initial malloc maximum.
6748 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6749 Move here from alloc.c, so that charset.c can use it too.
6750 Properly align; the old code wasn't right for common 32-bit hosts
6751 when configured with --enable-checking=all.
6752 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6753 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6754
31bed486
EZ
67552011-09-29 Eli Zaretskii <eliz@gnu.org>
6756
04c70788 6757 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6758 use EDOM.
6759
fbcaa2f3
EZ
67602011-09-28 Eli Zaretskii <eliz@gnu.org>
6761
6762 * xdisp.c (compute_display_string_end): If there's no display
6763 string at CHARPOS, return -1.
6764
6765 * bidi.c (bidi_fetch_char): When compute_display_string_end
6766 returns a negative value, treat the character as a normal
6767 character not covered by a display string. (Bug#9624)
6768
a239d4e9
JB
67692011-09-28 Juanma Barranquero <lekktu@gmail.com>
6770
6771 * lread.c (Fread_from_string): Fix typo in docstring.
6772
88652fd5
EZ
67732011-09-27 Eli Zaretskii <eliz@gnu.org>
6774
6775 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6776 newline, reseat the iterator instead of bidi-iterating there one
6777 character at a time. (Bug#9610)
32c1fffd
SM
6778 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6779 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6780
ed497dd4
AS
67812011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6782
6783 * lread.c (readevalloop): Use correct code for NBSP.
6784 (read1): Likewise. (Bug#9608)
6785
b2bf61aa
MA
67862011-09-25 Michael Albinus <michael.albinus@gmx.de>
6787
6788 * dbusbind.c (Fdbus_register_signal): When service is not
6789 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6790
32bbb17c
GM
67912011-09-25 Glenn Morris <rgm@gnu.org>
6792
6793 * buffer.c (truncate-lines): Doc fix.
6794
94e0933e
CY
67952011-09-24 Chong Yidong <cyd@stupidchicken.com>
6796
6797 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6798 (Fset_window_next_buffers): Doc fix.
6799
cddde921
GM
68002011-09-24 Glenn Morris <rgm@gnu.org>
6801
6802 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6803
1260aef1
PE
68042011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6805
25b4bfa0
PE
6806 Fix minor problems found by static checking.
6807 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6808 * indent.c (Fvertical_motion): Fix == vs = typo.
6809
e3cbd34b
EZ
68102011-09-24 Eli Zaretskii <eliz@gnu.org>
6811
a66cfb1c
SM
6812 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6813 Default value is now t. Doc fix.
6bf7006f 6814
e3cbd34b 6815 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6816 logic when moving up, not only when moving down. Fix the
e3cbd34b 6817 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6818 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6819
6820 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6821 CHARPOS is covered by a display string which includes newlines.
6822 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6823 is covered by a display string with embedded newlines.
6824
a3de0cbd
MA
68252011-09-24 Michael Albinus <michael.albinus@gmx.de>
6826
6827 * dbusbind.c (Fdbus_register_signal): Add match rule to
6828 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6829 (Fdbus_register_method, Vdbus_registered_objects_table):
6830 Fix docstring.
a3de0cbd 6831
b260039d
JM
68322011-09-24 Jim Meyering <meyering@redhat.com>
6833
32c1fffd 6834 do not ignore write error for any output size
b260039d
JM
6835 The previous change was incomplete.
6836 While it makes emacs --batch detect the vast majority of stdout
6837 write failures, errors were still ignored whenever the output size is
6838 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6839 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6840 && echo FAIL: ignored write error
6841 FAIL: ignored write error
6842 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6843 && echo FAIL: ignored write error
6844 FAIL: ignored write error
6845 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6846
8eca8a7c
AS
68472011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6848
6849 * emacs.c (Fkill_emacs): In noninteractive mode exit
6850 non-successfully if a write error occurred on stdout. (Bug#9574)
6851
3341db62
EZ
68522011-09-21 Eli Zaretskii <eliz@gnu.org>
6853
6854 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6855 the xassert test.
6856
6857 * dispextern.h (struct it): Update the comment documenting what
6858 can it->OBJECT be.
6859
8c203dbf
EZ
68602011-09-20 Eli Zaretskii <eliz@gnu.org>
6861
6862 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6863 a display string, extend search for cursor position to end of row.
6864 (find_row_edges): If the row ends in a newline from a display
6865 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6866 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6867 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6868 non-empty line. Fixes confusing cursor motion with arrow keys at
6869 the beginning of a line that starts with whitespace.
8c203dbf 6870
a4824228
LMI
68712011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6872
6873 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6874 (bug#9493).
6875
33ed493b
CY
68762011-09-18 Chong Yidong <cyd@stupidchicken.com>
6877
6878 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6879 boolean (Bug#9154).
6880
56cd55c8
EZ
68812011-09-18 Eli Zaretskii <eliz@gnu.org>
6882
6883 * xdisp.c (display_line): Record maximum and minimum buffer
6884 positions even if no glyphs were produced (e.g., by a zero-width
6885 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6886 buffer positions that will be removed from the glyph row because
6887 they don't fit.
c02dcedf
EZ
6888 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6889 column is beyond frame width: don't subtract 1 "pixel" when
6890 computing width of the stretch.
3e62b7e0
EZ
6891 (reseat_at_next_visible_line_start): Undo the change made on
6892 2011-09-17 that saved paragraph information and restored it after
6893 the call to `reseat'. (Bug#9545)
56cd55c8 6894
5ed99d36 68952011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6896
6897 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6898 and turn window cursor on if cleared (Bug#9415).
6899
5ed99d36 69002011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6901
6902 * search.c (boyer_moore): Take unibyte characters from pattern
6903 literally. (Bug#9458)
6904
9bade7b2
EZ
69052011-09-18 Eli Zaretskii <eliz@gnu.org>
6906
6907 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6908
e5e9d610
PE
69092011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6910
87e4427a
PE
6911 Fix minor problem found by static checking.
6912 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6913 initialized, to pacify gcc -Wuninitialized.
6914
e5e9d610
PE
6915 * fileio.c: Report proper errno when syscall falls.
6916 (Finsert_file_contents): Save and restore errno,
6917 so that report_file_error outputs the correct diagnostic.
6918 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6919
a1674f0b
EZ
69202011-09-18 Eli Zaretskii <eliz@gnu.org>
6921
6922 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6923
fbfb6dd4
EZ
69242011-09-17 Eli Zaretskii <eliz@gnu.org>
6925
6926 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6927 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6928
bb187662
EZ
69292011-09-17 Eli Zaretskii <eliz@gnu.org>
6930
1137e8b8 6931 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6932 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6933
6934 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6935 (bidi_find_paragraph_start): Search back for paragraph beginning
6936 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6937 (bidi_move_to_visually_next): Only trigger paragraph-related
6938 computations when the last character is a newline or at EOB, not
6939 just any NEUTRAL_B. (Bug#9470)
6940
bb187662
EZ
6941 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6942 truncated lines if point is covered by a display string. (Bug#9524)
6943
2e621251
PE
69442011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6945
6946 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6947 (cons_to_x_long): New function.
6948 (lisp_data_to_selection_data): Use it. Correct the test for
6949 short-versus-long data; it was negated. Break out of vector
6950 loop, for efficiency, when a long datum is discovered.
6951
91a15bc6
SM
69522011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6953
6954 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6955
b41c3a35
EZ
69562011-09-16 Eli Zaretskii <eliz@gnu.org>
6957
6958 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6959 GCC PR/17406) by declaring this function with external scope.
6960
7812ba2d
PE
69612011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6962
6963 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6964 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6965
cf7edc2a
AS
69662011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6967
6968 * editfns.c (Fformat): Correctly handle text properties on "%%".
6969
bd01620e
EZ
69702011-09-15 Eli Zaretskii <eliz@gnu.org>
6971
6972 * xterm.c (x_draw_composite_glyph_string_foreground):
6973 * w32term.c (x_draw_composite_glyph_string_foreground):
6974 * term.c (encode_terminal_code):
6975 * composite.c (composition_update_it, get_composition_id):
6976 * xdisp.c (get_next_display_element)
6977 (fill_composite_glyph_string): Add comments about special meaning
6978 of TAB characters in a composition.
6979
a02719a3
PE
69802011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6981
6982 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6983 This occurs when processing a multibyte format.
6984 Problem reported by Wolfgang Jenker.
a02719a3 6985
72589a3c
JB
69862011-09-15 Johan Bockgård <bojohan@gnu.org>
6987
6988 * xdisp.c (try_cursor_movement): Only check for exact match if
6989 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6990
1c14176c
PE
69912011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6992
6993 Remove unused external symbols.
6994 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6995 * xdisp.c (calc_pixel_width_or_height): Now static.
6996 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6997 * indent.c (check_display_width):
6998 * w32term.c: Fix comment to match code.
6999 * xterm.c, xterm.h (x_catching_errors): Remove.
7000
d2eea5b5
PE
70012011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7002
7003 * xselect.c: Use signed conversions more consistently (Bug#9498).
7004 (selection_data_to_lisp_data): Assume incoming selection data are
7005 signed integers, not unsigned. This is to be consistent with
7006 outgoing selection data, which was modified to use signed integers
7007 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7008 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7009 expects long, not unsigned long.
7010
46888499
EZ
70112011-09-14 Eli Zaretskii <eliz@gnu.org>
7012
7013 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7014 computation of loop end. Reported by Johan Bockgård
7015 <bojohan@gnu.org>.
7016
ef8ef9fb
CY
70172011-09-13 Chong Yidong <cyd@stupidchicken.com>
7018
7019 * frame.c (Fother_visible_frames_p): Function deleted.
7020
fa819fed
EZ
70212011-09-12 Eli Zaretskii <eliz@gnu.org>
7022
7023 * indent.c (compute_motion): Process display vector front to back
7024 rather than the other way around. (Bug#2496)
7025
2ba8e008
SM
70262011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7027
7028 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7029
20f53c69
CY
70302011-09-11 Chong Yidong <cyd@stupidchicken.com>
7031
7032 * minibuf.c (Fread_from_minibuffer): Doc fix.
7033
d562d7a4
EZ
70342011-09-11 Eli Zaretskii <eliz@gnu.org>
7035
7036 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7037 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7038
1c4d7f3d
LMI
70392011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7040
7041 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7042 value for non-existent files.
7043
b885bf36
EZ
70442011-09-11 Eli Zaretskii <eliz@gnu.org>
7045
7046 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7047 set its "size" to -1. This will set the modtime_size field of
7048 the corresponding buffer to -1, which is what
7049 verify-visited-file-modtime expects for files that do not exist.
7050 (Bug#9139)
7051
6612f0bf
PE
70522011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7053
7054 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7055 here ...
7056 * lisp.h: ... from here. push_key_description is no longer
7057 defined in keyboard.c, so its declaration should not be in
7058 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7059 logically belongs with push_key_description.
7060
dfb3f755
PE
70612011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7062
7063 * buffer.h: Include <sys/types.h> instead of <time.h>.
7064 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7065 Problem reported by Herbert J. Skuhra.
7066
3134906c
LMI
70672011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7068
7069 * xml.c (parse_region): Make the parsing work for
7070 non-comment-starting XML files again (bug#9144).
7071
8d903f4e
AS
70722011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7073
7074 * image.c (gif_load): Fix calculation of bottom and right corner.
7075 (Bug#9468)
7076
80ad64f4
EZ
70772011-09-10 Eli Zaretskii <eliz@gnu.org>
7078
7079 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7080 redisplay in small windows.
7081
208a048d
EZ
70822011-09-09 Eli Zaretskii <eliz@gnu.org>
7083
7084 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7085
9b1c252e
MR
70862011-09-08 Martin Rudalics <rudalics@gmx.at>
7087
7088 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7089 Operate on live windows only.
7090
2949f33b
JB
70912011-09-08 Juanma Barranquero <lekktu@gmail.com>
7092
7093 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7094
e08dcafd
EZ
70952011-09-07 Eli Zaretskii <eliz@gnu.org>
7096
7097 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7098 only under bidi iteration.
7099
115b96bd
JD
71002011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7101
7102 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7103
c8199d0f
PE
71042011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7105
7106 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7107 Without this fix, the command to link temacs failed due to an
7108 undefined symbol __builtin_isnan. This is because
7109 /usr/include/iso/math_c99.h #defines isnan(x) to
7110 __builtin_isnan(x), but the bundled gcc, which identifies itself
7111 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7112 a __builtin_isnan.
7113 * floatfns.c (isnan): #undef, and then #define to a clone of
7114 what's in data.c.
7115 (Fisnan): Always define, since it's always available now.
7116 (syms_of_floatfns): Always define isnan at the Lisp level.
7117
e39b275c 71182011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7119
7120 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7121
b2db44d9 71222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7123
f4af5137 7124 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7125 The previous code assumed that file offsets (off_t values) fit in
7126 EMACS_INT variables, which is not true on typical 32-bit hosts.
7127 The code messed up by falsely reporting buffer overflow in cases
7128 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7129 when "big" contains more than 2**29 bytes, even though this
7130 inserts just one byte and does not overflow the buffer.
7131 (Finsert_file_contents): Store file offsets as off_t
7132 values, not as EMACS_INT values. Check for overflow when
7133 converting between EMACS_INT and off_t. When checking for
7134 buffer overflow or for overlap, take the offsets into account.
7135 Don't use EMACS_INT for small values where int suffices.
7136 When checking for overlap, fix a typo: ZV was used where
7137 ZV_BYTE was intended.
7138 (Fwrite_region): Don't assume off_t fits into 'long'.
7139 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7140
ecfc0a49
MA
71412011-09-05 Michael Albinus <michael.albinus@gmx.de>
7142
7143 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7144
6511acf2 71452011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7146
0999621a 7147 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7148
7149 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7150 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7151 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7152 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7153 (modify_event_symbol): Do not assume that the length of
7154 name_alist_or_stem is safe to alloca and fits in int.
7155 (Fexecute_extended_command): Likewise for function name and binding.
7156 (Frecursion_depth): Wrap around reliably on integer overflow.
7157 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7158 since some callers pass EMACS_INT values.
7159 (Fsingle_key_description): Don't crash if symbol name contains more
7160 than MAX_ALLOCA bytes.
7161 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7162 (get_minibuffer): Arg is now EMACS_INT, not int.
7163 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7164 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7165 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7166
2be7d702
PE
7167 * dbusbind.c (signature_cat): New function.
7168 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7169 Do not overrun buffer; instead, report string overflow.
7170
9d1df220
PE
7171 * dispnew.c (add_window_display_history): Don't overrun buffer.
7172 Truncate instead; this is OK since it's just a log.
7173
33ef5c64
PE
7174 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7175 even if the time zone offset is outlandishly large.
7176 Don't mishandle offset == INT_MIN.
7177
66c6fdd5
PE
7178 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7179 when creating daemon; the previous buffer-overflow check was incorrect.
7180
d749b01b
PE
7181 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7182 which has the guts of the old verror function.
7183
b5cd1905
PE
7184 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7185 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7186
6e1a67fb
PE
7187 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7188 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7189 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7190 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7191 length of string rather than counting it via multiple sprintfs;
7192 that's simpler and more reliable.
c21721cc
PE
7193 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7194 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7195 sprintf, in case result does not fit in int.
7196
c57b67fc
PE
7197 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7198 (fontset_from_font): Print it.
7199
8a401434
PE
7200 * frame.c (tty_frame_count): Now printmax_t, not int.
7201 (make_terminal_frame, set_term_frame_name): Print it.
7202 (x_report_frame_params): In X, window IDs are unsigned long,
7203 not signed long, so print them as unsigned.
7204 (validate_x_resource_name): Check for implausibly long names,
7205 and don't assume name length fits in 'int'.
7206 (x_get_resource_string): Don't blindly alloca invocation name;
7207 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7208 not fit in int.
7209
6e1a67fb
PE
7210 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7211 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7212 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7213
0df02bf3
PE
7214 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7215 Use esprintf, not sprintf, in case result does not fit in int.
7216
48e30793
PE
7217 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7218 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7219 it as a large positive number.
7220 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7221 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7222
a66ff6d8
PE
7223 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7224 in case result does not fit in int.
7225
aca216ff
PE
7226 * print.c (float_to_string): Detect width overflow more reliably.
7227 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7228 buffer overrun. Don't assume list length fits in 'int'. Treat
7229 print length of 0 as 0, not as infinity; to be consistent with other
7230 uses of print length in this function. Don't overflow print length
7231 index. Don't assume hash table size fits in 'long', or that
7232 vectorlike size fits in 'unsigned long'.
7233
31c286f7
PE
7234 * process.c (make_process): Use printmax_t, not int, to format
7235 process-name gensyms.
7236
55e5faa1
PE
7237 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7238
80f2e268
PE
7239 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7240 to avoid potential buffer overrun.
7241
670741ab
PE
7242 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7243 if X resource line is longer than 512 bytes.
7244
b7163a50
PE
7245 * xfns.c (x_window): Make sprintf buffer a bit bigger
7246 to avoid potential buffer overrun.
7247
ae58ff1f
PE
7248 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7249
c43c8a6a
PE
7250 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7251
3f8236f4
PE
72522011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7253
53e9fe90 7254 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7255 Without these, Emacs silently mishandles large integers sometimes.
7256 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7257 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7258
6511acf2
PE
7259 * xdisp.c (try_window_id): Check Emacs fixnum range before
7260 converting to 'int'.
806add1d 7261
6511acf2 7262 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7263 Check that an Emacs fixnum is in range before assigning it to 'int'.
7264 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7265 values converted from Emacs fixnums.
7266 (Frecenter): Don't wrap around a line count if it is out of 'int'
7267 range; instead, treat it as an extreme value.
7268 (Fset_window_configuration, compare_window_configurations):
7269 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7270
6511acf2
PE
7271 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7272 that can exceed INT_MAX. Check that EMACS_INT value is in range
7273 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7274 (match_limit): Don't assume that a fixnum can fit in 'int'.
7275
6511acf2 7276 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7277 exceed INT_MAX.
7278
6511acf2 7279 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7280 (Fvertical_motion): Don't wrap around LINES values that don't fit
7281 in 'int'. Instead, treat them as extreme values. This is good
7282 enough for windows, which can't have more than INT_MAX lines anyway.
7283
fcb901a7
LMI
72842011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7285
0f2f6b6d
LMI
7286 * Require libxml/parser.h to avoid compilation warning.
7287
fcb901a7
LMI
7288 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7289
7290 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7291 since this reportedly can destroy thread storage.
7292
6e20a0d4
CY
72932011-08-30 Chong Yidong <cyd@stupidchicken.com>
7294
7295 * syntax.c (find_defun_start): Update all cache variables if
7296 exiting early (Bug#9401).
7297
148ae00e
EZ
72982011-08-30 Eli Zaretskii <eliz@gnu.org>
7299
f6cfbd8f
EZ
7300 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7301
148ae00e
EZ
7302 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7303 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7304 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7305
7306 * term.c (tty_append_glyph): New function.
7307 (produce_stretch_glyph): Static function and its prototype deleted.
7308
a66cfb1c
SM
7309 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7310 Add prototypes.
148ae00e 7311
c4a07a4c
PE
73122011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7313
7314 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7315 when checking :margin (Bug#9390).
7316 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7317 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7318 so that the name doesn't mislead. All uses changed.
7319
6bc8cd65
JB
73202011-08-28 Johan Bockgård <bojohan@gnu.org>
7321
7322 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7323 set_tty_hooks.
7324
dca4927e
EZ
73252011-08-27 Eli Zaretskii <eliz@gnu.org>
7326
7327 * xdisp.c (move_it_to): Don't bail out early when reaching
7328 position beyond to_charpos, if we are scanning backwards.
7329 (move_it_vertically_backward): When DY == 0, make sure we get to
7330 the first character in the line after the newline.
7331
f2cad773
PE
73322011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7333
7334 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7335 (ccl_driver): Do not generate an out-of-range pointer.
7336 (Fccl_execute_on_string): Remove unnecessary check for
7337 integer overflow, noted by Stefan Monnier in
7338 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7339 Remove a FIXME that didn't need fixing.
7340 Simplify the newly-introduced buffer reallocation code.
7341
0cae2cdb
JB
73422011-08-27 Juanma Barranquero <lekktu@gmail.com>
7343
7344 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7345
5fc295a4 73462011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7347
70c60eb2 7348 Integer and memory overflow issues (Bug#9196).
726e0ab1 7349
d31850da
PE
7350 * doc.c (get_doc_string): Rework so that
7351 get_doc_string_buffer_size is the actual buffer size, rather than
7352 being 1 less than the actual buffer size; this makes xpalloc more
7353 convenient.
7354
a69fbedb
PE
7355 * image.c (x_allocate_bitmap_record, cache_image):
7356 * xselect.c (Fx_register_dnd_atom):
7357 Simplify previous changes by using xpalloc.
7358
fe5c5d37
PE
7359 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7360 since either will do and ptrdiff_t is convenient with xpalloc.
7361
0065d054
PE
7362 * charset.c (charset_table_size)
7363 (struct charset_sort_data.priority): Now ptrdiff_t.
7364 (charset_compare): Don't overflow if priorities differ greatly.
7365 (Fsort_charsets): Don't assume list length fits in int.
7366 Check for size-calculation overflow when allocating sort data.
7367 (syms_of_charset): Allocate an initial charset table that is
7368 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7369
7370 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7371
7372 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7373 The actual value is always <= INT_MAX, and leaving it unsigned made
7374 overflow checking harder.
7375
7376 * dispextern.h (struct glyph_matrix.rows_allocated)
7377 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7378 with xpalloc. The values are still always <= INT_MAX.
7379
7380 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7381
7382 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7383 (SAFE_NALLOCA): New macro.
7384
7385 * region-cache.c (struct boundary.pos, find_cache_boundary)
7386 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7387 (set_cache_region, invalidate_region_cache)
7388 (revalidate_region_cache, know_region_cache, region_cache_forward)
7389 (region_cache_backward, pp_cache):
7390 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7391 so that ptrdiff_t * can be passed to xpalloc.
7392 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7393 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7394 (pp_cache): Don't assume cache_len fits in int.
7395 * region-cache.h: Adjust extern decls to match.
7396
7397 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7398 EMACS_INT, since either will do, for xpalloc.
7399
7400 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7401 (xnmalloc, xnrealloc, xpalloc): New functions.
7402
726e0ab1
PE
7403 * bidi.c (bidi_shelve_header_size): New constant.
7404 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7405 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7406
51f30bc5 7407 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7408 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7409 (overlay_strings):
7410 Don't update size of array until after memory allocation succeeds,
7411 because xmalloc/xrealloc may not return.
0065d054
PE
7412 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7413 now that we have proper integer overflow checking.
7414 (record_overlay_string, overlay_strings): Catch overflows when
7415 calculating size of overlay_str_buf.
726e0ab1 7416
0065d054
PE
7417 * callproc.c (Fcall_process): Check for size overflow when
7418 calculating size of args2.
7419 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7420 Normally we prefer signed values, but sticking with ptrdiff_t would
7421 require adding more-complicated checks.
726e0ab1
PE
7422
7423 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7424 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7425 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7426 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7427
7428 * character.c (Fstring): Check for size-calculation overflow.
7429
7430 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7431 unnecessary integer overflow. Check for size overflow.
7432 (encode_coding_object): Don't update size until xmalloc succeeds.
7433
7434 * composite.c (get_composition_id): Check for overflow in glyph
7435 length calculations.
7436
7437 Integer and memory overflow fixes for display code.
7438 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7439 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7440 (scrolling_window): Check for overflow in size calculations.
7441 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7442 Don't assume glyph table len fits in int.
7443 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7444 (row_table_size): Now ptrdiff_t, not int.
7445 (scrolling_window): Avoid overflow in size calculations.
7446 Don't update size until allocation succeeds.
7447 * fns.c (concat): Check for overflow in size calculations.
7448 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7449 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7450 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7451
7452 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7453 (get_doc_string): Check for size calculation overflow.
7454 Don't update size until allocation succeeds.
7455 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7456 EMACS_INT, where ptrdiff_t will do.
7457 (Fsubstitute_command_keys): Check for string overflow.
7458
7459 * editfns.c (set_time_zone_rule): Don't assume environment length
7460 fits in int.
7461 (message_length): Now ptrdiff_t, not int.
7462 (Fmessage_box): Don't update size until allocation succeeds.
7463 Don't assume message length fits in int.
7464 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7465
0065d054
PE
7466 * emacs.c (main): Do not reallocate argv, since there is a null at
7467 the end that can be overwritten, and this way there's no need to
7468 worry about size-calculation overflow.
7469 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7470
7471 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7472 alloc succeeds.
7473 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7474
7475 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7476 (x_set_scroll_bar_width, x_figure_window_size):
7477 Check for integer overflow.
7478 (x_set_alpha): Do not assume XINT fits in int.
7479
7480 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7481 This is for the members text_lines, text_cols, total_lines, total_cols,
7482 where the system imposes an 'int' limit.
7483
7484 * fringe.c (Fdefine_fringe_bitmap):
7485 Don't update size until alloc works.
7486
7487 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7488 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7489
7490 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7491 Check for size-calculation overflow.
7492 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7493 do, as we prefer signed integers.
7494 (id_to_widget.max_size, id_to_widget.used)
7495 (xg_store_widget_in_map, xg_remove_widget_from_map)
7496 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7497 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7498 Use and return ptrdiff_t, not int.
7499 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7500 * gtkutil.h: Change prototypes to match the above.
7501
7502 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7503 are duplicate now that they've been promoted to lisp.h.
7504 (x_allocate_bitmap_record, x_alloc_image_color)
7505 (make_image_cache, cache_image, xpm_load):
7506 Don't update size until alloc is done.
7507 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7508 (x_detect_edges):
3256efce 7509 Check for size calculation overflow.
726e0ab1
PE
7510 (ct_colors_allocated_max): New constant.
7511 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7512 overflow.
3256efce 7513
726e0ab1
PE
7514 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7515 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7516 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7517 Use ptrdiff_t, not int, to count maps.
7518 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7519 calculations. Don't update size until allocation succeeds.
7520 Redo calculations to avoid overflow.
726e0ab1
PE
7521 * keyboard.h: Change prototypes to match the above.
7522
7523 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7524 to count maps.
7525 (current_minor_maps): Check for size calculation overflow.
7526 * keymap.h: Change prototypes to match the above.
7527
7528 * lread.c (read1, init_obarray): Don't update size until alloc done.
7529
7530 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7531 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7532
726e0ab1
PE
7533 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7534 Now ptrdiff_t, not int.
7535 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7536 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7537
7538 * process.c (Fnetwork_interface_list): Check for overflow
7539 in size calculation.
7540
7541 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7542
7543 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7544 overflow. Don't bother calling xmalloc when xrealloc will do.
7545
7546 * search.c (Freplace_match): Check for size calculation overflow.
7547 (Fset_match_data): Don't assume list lengths fit in 'int'.
7548
7549 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7550 for command line length. Do not attempt to address one before the
7551 beginning of an array, as that's not portable.
7552
7553 * term.c (max_frame_lines): Remove; unused.
7554 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7555 not int.
7556 (encode_terminal_code, calculate_costs): Check for size
7557 calculation overflow.
7558 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7559 table lengths and related sizes. Don't update size until alloc
7560 done. Redo calculations to avoid overflow.
7561 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7562
7563 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7564 subtracting pointers.
7565 (gobble_line): Check for overflow more carefully. Don't update size
7566 until alloc done.
7567
7568 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7569 Don't update size until alloc done.
7570 Redo size calculations to avoid overflow.
7571 Check for size calculation overflow.
0065d054 7572 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7573
7574 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7575 Use ptrdiff_t, not int, for sizes.
7576 (store_mode_line_noprop_char): Don't update size until alloc done.
7577
0065d054
PE
7578 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7579 Use ptrdiff_t, not int, for sizes.
7580 (Finternal_make_lisp_face, cache_face):
7581 Check for size calculation overflow.
7582 (cache_face): Treat size calculation overflows as if they were
7583 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7584
7585 * xfns.c (x_encode_text, x_set_name_internal)
7586 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7587 sizes, since they can exceed INT_MAX in size. Check for size
7588 calculation overflow.
7589
0065d054
PE
7590 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7591 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7592 Don't update size until alloc done.
7593
0065d054 7594 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7595 as sprintf is limited to int lengths.
1d526e2f 7596
252c5ee1
PE
7597 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7598 (X_LONG_MIN): New macros.
864d7ce7
PE
7599 Use them to make the following changes clearer.
7600 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7601 This change doesn't affect the value now, but it may help remind
7602 future maintainers not to raise the value too much later.
7603 (SELECTION_QUANTUM): Remove, replacing with ...
7604 (selection_quantum): ... new function, which avoids overflow.
7605 All uses changed.
7606 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7607 assumption that selection length fits in 'int'.
7608 (x_reply_selection_request, x_handle_selection_request)
7609 (x_get_window_property, receive_incremental_selection)
7610 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7611 (lisp_data_to_selection_data, clean_local_selection_data):
7612 Use ptrdiff_t, not int, to record length of selection.
7613 (x_reply_selection_request, x_get_window_property)
7614 (receive_incremental_selection, x_property_data_to_lisp):
7615 Redo calculations to avoid overflow.
7616 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7617 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7618 something.
7619 (x_get_window_property, receive_incremental_selection)
7620 (lisp_data_to_selection_data, x_property_data_to_lisp):
7621 Check for size-calculation overflow.
7622 (x_get_window_property, receive_incremental_selection)
7623 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7624 Don't store size until memory allocation succeeds.
7625 (x_get_window_property): Plug memory leak on memory exhaustion.
7626 Don't double-block input; malloc is safe here. Don't assume 2**34
7627 - 4 fits in unsigned long. Add an xassert to check
7628 XGetWindowProperty overflow. Be more careful about overflow
7629 calculations, and distinguish size from memory overflow better.
7630 (receive_incremental_selection): When tracing, don't assume
7631 unsigned int is less than INT_MAX.
7632 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7633 harmful) conversions of unsigned short to int.
7634 (lisp_data_to_selection_data): Don't assume that integers
7635 in the range -65535 through -1 fit in an X unsigned short.
7636 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7637 result parameters unless successful. Rely on cons_to_unsigned
7638 to report problems with elements; the old code wasn't right anyway.
7639 (x_check_property_data): Check for int overflow; we cannot use
7640 a wider type due to X limits.
7641 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7642
726e0ab1 7643 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7644
0065d054
PE
7645 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7646 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7647 (x_color_cells): Don't store size until memory allocation succeeds.
7648 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7649 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7650 (x_term_init): Don't assume length fits in int (sprintf is limited
7651 to int size).
bc18e09d 7652
ebfa62c0
PE
7653 Use ptrdiff_t for composition IDs.
7654 * character.c (lisp_string_width):
7655 * composite.c (composition_table_size, n_compositions)
7656 (get_composition_id, composition_gstring_from_id):
7657 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7658 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7659 * window.c (Frecenter):
7660 Use ptrdiff_t, not int, for composition IDs.
7661 * composite.c (get_composition_id): Check for integer overflow.
7662 * composite.h: Adjust prototypes to match the above changes.
7663
d3411f89
PE
7664 Use ptrdiff_t for hash table indexes.
7665 * category.c (hash_get_category_set):
7666 * ccl.c (ccl_driver):
7667 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7668 * coding.c (coding_system_charset_list, detect_coding_system):
7669 * coding.h (struct coding_system.id):
7670 * composite.c (get_composition_id, gstring_lookup_cache):
7671 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7672 * image.c (xpm_get_color_table_h):
7673 * lisp.h (hash_lookup, hash_put):
7674 * minibuf.c (Ftest_completion):
7675 Use ptrdiff_t for hash table indexes, not int (which is too
7676 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7677 32-bit --with-wide-int hosts).
7678
e097a6fa
PE
7679 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7680 Add a FIXME comment about memory leaks.
7681 (syms_of_charset): Don't assume xmalloc returns.
7682
5637687f
PE
7683 Don't assume that stated character widths fit in int.
7684 * character.c (Fchar_width, c_string_width, lisp_string_width):
7685 * character.h (CHAR_WIDTH):
7686 * indent.c (MULTIBYTE_BYTES_WIDTH):
7687 Use sanitize_char_width to avoid undefined and/or bad behavior
7688 with outlandish widths.
a66cfb1c 7689 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7690 now that we have two such functions. All uses changed.
7691 (sanitize_char_width): New inline function.
7692
a2271ba2
PE
7693 Don't assume that tab-width fits in int.
7694 * character.h (sanitize_width): New inline function.
7695 (SANE_TAB_WIDTH): New macro.
7696 (ASCII_CHAR_WIDTH): Use it.
7697 * indent.c (sane_tab_width): Remove. All uses replaced by
7698 SANE_TAB_WIDTH (current_buffer).
7699 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7700
18c52557
PE
7701 * fileio.c: Integer overflow issues with file modes.
7702 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7703
caeeedc1
PE
7704 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7705 Remove unreachable code.
7706 (read_hex, load_charset_map_from_file): Check for integer overflow.
7707
6df6ae42 7708 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7709 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7710 (x_send_scroll_bar_event): Likewise. Check that the size does not
7711 exceed limits imposed by XClientMessageEvent, as well as the usual
7712 ptrdiff_t and size_t limits.
7713
b13995db
PE
7714 * keyboard.c: Overflow, signedness and related fixes.
7715 (make_lispy_movement): Use same integer type in forward decl
7716 that is used in the definition.
7717 (read_key_sequence, keyremap_step):
7718 Change bufsize argument back to int, undoing my 2011-03-30 change.
7719 We prefer signed types, and int is wide enough here.
7720 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7721 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7722 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7723 length, not size_t. Use ptrdiff_t for index, not int.
7724 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7725 possibility of integer overflow.
7726
13464394
PE
7727 Overflow, signedness and related fixes for images.
7728
7729 * dispextern.h (struct it.stack[0].u.image.image_id)
7730 (struct_it.image_id, struct image.id, struct image_cache.size)
7731 (struct image_cache.used, struct image_cache.ref_count):
7732 * gtkutil.c (update_frame_tool_bar):
7733 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7734 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7735 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7736 * nsmenu.m (update_frame_tool_bar):
7737 * xdisp.c (calc_pixel_width_or_height):
7738 * xfns.c (image_cache_refcount):
7739 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7740 on typical 64-bit hosts.
7741
7742 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7743 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7744 Omit unnecessary casts to int.
7745 (parse_image_spec): Check that integers fall into 'int' range
7746 when the callers expect that.
7747 (image_ascent): Redo ascent calculation to avoid int overflow.
7748 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7749 (lookup_image): Remove unnecessary tests.
7750 (xbm_image_p): Locals are now of int, not EMACS_INT,
7751 since parse_image_check makes sure they fit into int.
7752 (png_load, gif_load, svg_load_image):
7753 Prefer int to unsigned where either will do.
7754 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7755 old tiff_error_handler and tiff_warning_handler.
7756 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7757 stack buffer overflows. It uses only the features of vsnprintf
7758 that are common to both POSIX and native Microsoft.
7759 (tiff_error_handler, tiff_warning_handler): Use it.
7760 (tiff_load, gif_load, imagemagick_load_image):
7761 Don't assume :index value fits in 'int'.
7762 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7763 (imagemagick_load_image): Check that crop parameters fit into
7764 the integer types that MagickCropImage accepts. Don't assume
7765 Vimagemagick_render_type has a nonnegative value. Don't assume
7766 size_t fits in 'long'.
7767 (gs_load): Use printmax_t to print the widest integers possible.
7768 Check for integer overflow when computing image height and width.
7769
c11821d4
EZ
77702011-08-26 Eli Zaretskii <eliz@gnu.org>
7771
7772 * xdisp.c (redisplay_window): Don't force window start if point
7773 will be invisible in the resulting window. (Bug#9324)
7774
0c95fcf7
EZ
77752011-08-25 Eli Zaretskii <eliz@gnu.org>
7776
7777 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7778 the display spec is of the form `(space ...)'.
7779 (handle_display_spec): Return the value returned by
7780 handle_single_display_spec, not just 1 or zero.
7781 (handle_single_display_spec): If the display spec is of the form
7782 `(space ...)', and specifies display in the text area, return 2
7783 rather than 1.
fee65a97 7784 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7785 accurately, and prefer exact match for point under bidi.
7786 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7787
7788 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7789 into disp_prop; all users changed.
7790
7791 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7792 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7793 for the text covered by the display property.
7794
e4ed06f1
CY
77952011-08-25 Chong Yidong <cyd@stupidchicken.com>
7796
7797 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7798 Change return value to nil.
7799 (Frecord_buffer): Delete unused function.
7800
f67cdd7f
EZ
78012011-08-24 Eli Zaretskii <eliz@gnu.org>
7802
5980d4c6
EZ
7803 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7804 buffers, return left-to-right.
8610fe8b
EZ
7805 (set_cursor_from_row): Consider candidate row a win if its glyph
7806 represents a newline and point is on that newline. Fixes cursor
7807 positioning on the newline at EOL of R2L text within L2R
7808 paragraph, and vice versa.
7809 (try_cursor_movement): Check continued rows, in addition to
7810 continuation rows. Fixes unwarranted scroll when point enters a
7811 continued line of R2L text within an L2R paragraph, or vice versa.
7812 (cursor_row_p): Consider the case of point being equal to
7813 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7814 from the end of a short line to the beginning of a continued line
7815 of R2L text within L2R paragraph.
7816 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7817 composed characters.
5980d4c6 7818
f67cdd7f
EZ
7819 * bidi.c (bidi_check_type): Use xassert.
7820 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7821 members.
7822
bca633fb
EZ
78232011-08-23 Eli Zaretskii <eliz@gnu.org>
7824
7825 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7826 a character.
7827
4a5885a7
CY
78282011-08-23 Chong Yidong <cyd@stupidchicken.com>
7829
7830 * nsfont.m (ns_otf_to_script): Fix typo.
7831
0902a04e
KH
78322011-08-22 Kenichi Handa <handa@m17n.org>
7833
7834 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7835 extra slot even if the purpose is char-code-property-table.
7836
1a2e6670
EZ
78372011-08-23 Eli Zaretskii <eliz@gnu.org>
7838
8ddde651
EZ
7839 * xdisp.c (redisplay_window): When computing centering_position,
7840 account for the height of the header line. (Bug#8874)
7841
425cc014
EZ
7842 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7843 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7844 candidate is selected by the mouse, and that candidate has a
7845 composed character under the mouse.
7846
1a2e6670
EZ
7847 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7848 coordinates reported by pos-visible-in-window-p for a composed
7849 character in column zero.
7850
8b76d6f8
SM
78512011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7852
7853 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7854
dac347dd
EZ
78552011-08-22 Eli Zaretskii <eliz@gnu.org>
7856
7857 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7858 consider it a hit if to_charpos is anywhere in the range of the
7859 composed buffer positions.
7860
e013fb34
CY
78612011-08-22 Chong Yidong <cyd@stupidchicken.com>
7862
7863 * image.c (gif_load): Don't assume that each subimage has the same
7864 dimensions as the base image. Handle disposal method that is
7865 "undefined" by the gif spec (Bug#9335).
7866
bd1ba3e8
CY
78672011-08-20 Chong Yidong <cyd@stupidchicken.com>
7868
7869 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7870 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7871
54a1215b
EZ
78722011-08-19 Eli Zaretskii <eliz@gnu.org>
7873
823564e5
EZ
7874 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7875 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7876 from an Org mode buffer to a Speedbar frame.
7877
54a1215b
EZ
7878 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7879 a composition, take its buffer position from IT->cmp_it.charpos.
7880 Fixes cursor positioning at the beginning of a line that begins
7881 with a composed character.
7882
9778ebcc
EZ
78832011-08-18 Eli Zaretskii <eliz@gnu.org>
7884
0be6ee06
EZ
7885 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7886 character bidirectional type, use STRONG_L instead. Fixes crashes
7887 in a buffer produced by `describe-categories'.
7888
9778ebcc
EZ
7889 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7890 members before the level stack, so they would be saved and
7891 restored when copying iterator state. Fixes incorrect reordering
7892 around TABs covered by display properties.
7893
156bffbe
AS
78942011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7895
6b02f655 7896 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7897
72ad093b
CY
78982011-08-17 Chong Yidong <cyd@stupidchicken.com>
7899
7900 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7901 (internal_condition_case_2, internal_condition_case_n):
7902 Remove unnecessary aborts (Bug#9081).
72ad093b 7903
35774242
EZ
79042011-08-17 Eli Zaretskii <eliz@gnu.org>
7905
7906 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7907 has no `load' handler, try opening the file locally. (Bug#9311)
7908
db76dd85
KB
79092011-08-16 Ken Brown <kbrown@cornell.edu>
7910
7911 * gmalloc.c: Expand comment.
7912
b215eee5
EZ
79132011-08-16 Eli Zaretskii <eliz@gnu.org>
7914
7915 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7916 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7917
a4579d33
KB
79182011-08-16 Ken Brown <kbrown@cornell.edu>
7919
7920 Fix memory allocation problems in Cygwin build (Bug#9273).
7921
7922 * unexcw.c ( __malloc_initialized): Declare external variable.
7923 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7924
8b76d6f8
SM
7925 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7926 New variables.
a4579d33
KB
7927 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7928 dumped emacs.
7929 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7930 in the static heap.
7931 [CYGWIN] (special_realloc): New function.
7932 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7933 requests to realloc storage in the static heap.
7934
3ebec551
PE
79352011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7936
7937 * bidi.c (bidi_initialize): Remove unused local.
7938
9fd8be00
EZ
79392011-08-15 Eli Zaretskii <eliz@gnu.org>
7940
6b02f655
SM
7941 * bidimirror.h:
7942 * biditype.h: Remove file.
7943 * makefile.w32-in ($(BLD)/bidi.$(O)):
7944 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7945
7946 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7947
7948 * chartab.c: Improve commentary for the uniprop_table API.
7949
32413314
EZ
7950 * bidi.c (bidi_paragraph_init): Support zero value of
7951 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7952 (bidi_initialize): Use uniprop_table instead of including
7953 biditype.h and bidimirror.h.
32413314 7954
9fd8be00
EZ
7955 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7956 coordinates of the iterator when restoring from ppos_it.
7957 (Bug#9296)
7958
5cf2b69b
KH
79592011-08-14 Kenichi Handa <handa@m17n.org>
7960
7961 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7962 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7963
daf17d00
EZ
79642011-08-14 Eli Zaretskii <eliz@gnu.org>
7965
7966 * xdisp.c (move_it_in_display_line_to): Don't invoke
7967 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7968 ppos_it. Fixes vertical cursor motion when line beginning is
7969 covered by an image. (Bug#9296)
7970
08e3161a
JD
79712011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7972
7973 * nsterm.h (ns_run_ascript): Declare.
7974 (NSAPP_DATA2_RUNASSCRIPT): Define.
7975
7976 * nsfns.m (as_script, as_result, as_status): New static variables.
7977 (ns_run_ascript): New function.
5e617bc2 7978 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7979 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7980 the event loop. Get status from as_status (Bug#7276).
7981
7982 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7983 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7984 the event loop (Bug#7276).
7985
a3720aa2
AS
79862011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7987
7988 * gnutls.c (QCgnutls_bootprop_priority)
7989 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7990 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7991 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7992 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7993 (QCgnutls_bootprop_verify_hostname_error)
7994 (QCgnutls_bootprop_callbacks_verify): Rename from
7995 Qgnutls_bootprop_..., all uses changed.
7996
7997 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7998 uses changed.
7999
0a0d27fb
PE
80002011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8001
19d5c50c
PE
8002 * xfaces.c (Qframe_set_background_mode): Now static.
8003 * dispextern.h (Qframe_set_background_mode): Remove decl.
8004
0a0d27fb
PE
8005 * process.c (Fnetwork_interface_info): Declare local only if needed.
8006
377538cb
JD
80072011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8008
8009 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8010 (Fnetwork_interface_list): Allocate in increments of bytes instead
8011 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8012 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8013 sockaddr.
8014 (struct ifflag_def): notrailers is smart on OSX.
8015 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8016 Get hardware address with getifaddrs if available.
8017
08fff70c
EZ
80182011-08-12 Eli Zaretskii <eliz@gnu.org>
8019
8020 * xdisp.c (iterate_out_of_display_property): xassert that
8021 IT->position is set to within IT->object's boundaries. Break from
8022 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8023 when IT->position is set up wrongly due to some bug.
8024 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8025 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8026 entry. Force push_it to save on the stack the current
8027 buffer/string position, to be restored by pop_it. Fix flags in
8028 the iterator structure wrt the object coming from a display
8029 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8030 properties. (Bug#9284)
8031
7be1c708 80322011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8033
7be1c708
CY
8034 * fontset.c (fontset_get_font_group): Add proper type checks.
8035 (Bug#9172)
aac0c6e3 8036
7be1c708 80372011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8038
7be1c708
CY
8039 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8040 and LC_VERSION_MIN_MACOSX.
8041 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8042 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8043
97bb72a6
EZ
80442011-08-08 Eli Zaretskii <eliz@gnu.org>
8045
8046 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8047 no-display-properties-and-no-overlays under bidi display.
8048 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8049 properties and overlays.
97bb72a6 8050
d5617611
CY
80512011-08-08 Chong Yidong <cyd@stupidchicken.com>
8052
37e11a63
CY
8053 * editfns.c (Fset_time_zone_rule): Document relationship with the
8054 setenv function.
8055
d5617611
CY
8056 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8057 the font entity extracted from the cache (Bug#8109).
8058
58872834
CY
80592011-08-07 Chong Yidong <cyd@stupidchicken.com>
8060
8061 * composite.c (autocmp_chars): Don't reset point. That is done by
8062 restore_point_unwind (Bug#5984).
8063
75bfc667
JL
80642011-08-07 Juri Linkov <juri@jurta.org>
8065
8066 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8067 to show the arg `TIME' instead of `TIMEVAL'.
8068
d1410150
EZ
80692011-08-06 Eli Zaretskii <eliz@gnu.org>
8070
8071 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8072 display property strides EOL and includes a newline, as in
8073 longlines-mode. (Bug#9254)
75b771e4
EZ
8074 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8075 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8076
8077 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8078 is non-zero, even if the data buffer is NULL. Fixes a crash in
8079 vertical-motion with longlines-mode. (Bug#9254)
8080
35928349
EZ
80812011-08-05 Eli Zaretskii <eliz@gnu.org>
8082
ec7cc85b
EZ
8083 * bidi.c <bidi_cache_total_alloc>: Now static.
8084 (bidi_initialize): Initialize bidi_cache_total_alloc.
8085
8b76d6f8 8086 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8087 cache. (Bug#9221)
8088
8089 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8090 amount allocated this far in `bidi_cache_total_alloc'.
8091 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8092 non-zero, only free the data buffer without restoring the cache
8093 contents. All callers changed.
8094
8095 * dispextern.h (bidi_unshelve_cache): Update prototype.
8096
8097 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8098 (move_it_in_display_line, move_it_to)
8099 (move_it_vertically_backward, move_it_by_lines): Replace the call
8100 to xfree to an equivalent call to bidi_unshelve_cache.
8101 (move_it_in_display_line_to): Fix logic of returning
412b6358 8102 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8103
e2e2423b
EZ
81042011-08-05 Eli Zaretskii <eliz@gnu.org>
8105
8106 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8107 came from a string character with a `cursor' property. (Bug#9229)
8108
ae9e757a
JD
81092011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8110
8111 * Makefile.in (LIB_PTHREAD): New variable.
8112 (LIBES): Add LIB_PTHREAD (Bug#9216).
8113
8114 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8115 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8116
213bd7f2
AS
81172011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8118
6b02f655 8119 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8120
99aaf75f
JD
81212011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8122
8123 * xterm.c (x_find_topmost_parent): New function.
8124 (x_set_frame_alpha): Find topmost parent window with
8125 x_find_topmost_parent and set the property there also (bug#9181).
8126 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8127
c74e9d86
PE
81282011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8129
8130 * callproc.c (Fcall_process): Avoid vfork clobbering
8131 the local vars buffer, coding_systems, current_dir.
8132
640c8776
SM
81332011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8134
8135 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8136
f26d0e4c
PE
81372011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8138
8a10d76c
PE
8139 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8140 so that it is not optimized away.
8141
f26d0e4c
PE
8142 * xdisp.c (compute_display_string_pos): Remove unused local.
8143
55439c61
EZ
81442011-08-02 Eli Zaretskii <eliz@gnu.org>
8145
8146 Fix slow cursor motion and scrolling in large buffers with
8147 selective display, like Org Mode buffers. (Bug#9218)
8148
8149 * dispextern.h (struct bidi_it): New member disp_prop_p.
8150
8151 * xdisp.c: Remove one-slot cache of display string positions.
8152 (compute_display_string_pos): Accept an additional argument
5e617bc2 8153 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8154 for a display string or property. If found, set DISP_PROP_P
8155 non-zero.
8156
8157 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8158 DISP_PROP_P, and pass it to compute_display_string_pos.
8159 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8160 non-zero. All callers of bidi_fetch_char changed.
8161
fb33fa43
SM
81622011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8163
8164 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8165
b099e063
DM
81662010-12-03 Don March <don@ohspite.net>
8167
8168 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8169 last character M-[char] is translated to ESC [char] (bug#7541).
8170
5cc7f7af
KH
81712011-08-02 Kenichi Handa <handa@m17n.org>
8172
d0fffa3f 8173 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8174
8175 * chartab.c (uniprop_table): Make it non-static.
8176
525d5e6e
EZ
81772011-08-01 Eli Zaretskii <eliz@gnu.org>
8178
8179 * xdisp.c (forward_to_next_line_start): Accept additional argument
8180 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8181 on the newline.
8182 (reseat_at_next_visible_line_start): Use the bidi iterator state
8183 returned by forward_to_next_line_start to restore the state of
8184 it->bidi_it after backing up to previous newline. (Bug#9212)
8185
31011111
AS
81862011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8187
8188 * regex.c (re_comp): Protoize.
8189 (re_exec): Fix return type.
8190 (regexec): Fix type of `ret'. (Bug#9203)
8191
476371c4
PE
81922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8193
e5d76069
PE
8194 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8195 This is needed if max-image-size is a floating-point number.
8196
9a79b20c
AS
81972011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8198
8199 * print.c (print_object): Print empty symbol as ##.
8200
8201 * lread.c (read1): Read ## as empty symbol.
8202
d8c2fa78
AA
82032011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8204
8205 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8206 setting frame foreground color (Bug#9175).
8207 (x_set_background_color): Likewise.
8208
ffe57a7a
AA
8209 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8210 contents (Bug#9176).
8211 (EmacsTooltip -init): Remove bezels and add shadows to
8212 tooltip windows.
8213
bf3492a5
AA
8214 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8215 or scroll bar (Bug#8470).
8216
d55e9c53
AA
8217 * nsfont.m (nsfont_open): Remove assignment to voffset and
8218 unnecessary vars hshink, expand, hd, full_height, min_height.
8219 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8220
8221 * nsterm.h (nsfont_info): Remove voffset field.
8222
d8c2fa78 82232011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8224
8225 Implement strike-through and overline on NextStep (Bug#8863).
8226
8227 * nsfont.m (nsfont_open): Use underline position provided by font,
8228 instead of hard-coded value of 2.
8229 (nsfont_draw): Call ns_draw_text_decoration instead.
8230
8231 * nsterm.h: Add declaration for ns_draw_text_decoration.
8232
8233 * nsterm.m (ns_draw_text_decoration): New function for drawing
8234 underline, overline, and strike-through.
8235 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8236 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8237 accommodate underlining, etc.
4843aac3 8238
4cc60b9b
EZ
82392011-07-28 Eli Zaretskii <eliz@gnu.org>
8240
bc7ece87
EZ
8241 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8242 default.
4cc60b9b 8243
476371c4
PE
82442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8245
66606eea
PE
8246 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8247 Without this fix, if a signal arrives just after memory fills up,
8248 'malloc' might be invoked reentrantly.
8249
476371c4
PE
8250 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8251 In other words, assume that every image size is allowed, on non-X
8252 hosts. This assumption is probably wrong, but it lets Emacs compile.
8253
f3fcc40d
AS
82542011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8255
8256 * regex.c (re_iswctype): Convert return values to boolean.
8257
350c992f
EZ
82582011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8259
8260 * xdisp.c (compute_display_string_pos): Don't use cached display
8261 string position if the buffer had its restriction changed.
8262 (Bug#9184)
8263
5266b4bb
PE
82642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8265
8266 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8267
2573a837 82682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8269
41f55ccd 8270 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8271
39e378da
PE
8272 * bidi.c: Integer size and overflow fixes.
8273 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8274 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8275 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8276 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8277 (bidi_find_other_level_edge):
8278 Use ptrdiff_t instead of EMACS_INT where either will do.
8279 This works better on 32-bit hosts configured --with-wide-int.
8280 (bidi_cache_ensure_space): Check for size-calculation overflow.
8281 Use % rather than repeated addition, for better worst-case speed.
8282 Don't set bidi_cache_size until after xrealloc returns, because it
8283 might not return.
8284 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8285 (bidi_cache_ensure_space): Also check that the bidi cache size
8286 does not exceed that of the largest Lisp string or buffer. See Eli
8287 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8288
5e927815
PE
8289 * alloc.c (__malloc_size_t): Remove.
8290 All uses replaced by size_t. See Andreas Schwab's note
8291 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8292
ca4aa935
PE
8293 * image.c: Improve checking for integer overflow.
8294 (check_image_size): Assume that f is nonnull, since
8295 it is always nonnull in practice. This is one less thing to
8296 worry about when checking for integer overflow later.
8297 (x_check_image_size): New function, which checks for integer
8298 overflow issues inside X.
8299 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8300 This removes the need for a memory_full check.
8301 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8302 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8303 (xbm_read_bitmap_data): Change locals back to 'int', since
8304 their values must fit in 'int'.
8305 (xpm_load_image, png_load, tiff_load):
8306 Invoke x_create_x_image_and_pixmap earlier,
8307 to avoid much needless work if the image is too large.
8308 (tiff_load): Treat overly large images as if
8309 x_create_x_image_and_pixmap failed, not as malloc failures.
8310 (gs_load): Use x_check_image_size.
8311
5f8f9cc2
PE
8312 * gtkutil.c: Omit integer casts.
8313 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8314 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8315
5adf60bc
PE
8316 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8317
c8907a93
PE
8318 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8319 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8320 would wrongly return t on a 64-bit host.
8321
e3c25c68
PE
8322 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8323 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8324 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8325 and therefore cause GCC to emit a bogus diagnostic in some cases.
8326
3f791afe
PE
8327 * image.c: Integer signedness and overflow and related fixes.
8328 This is not an exhaustive set of fixes, but it's time to
8329 record what I've got.
8330 (lookup_pixel_color, check_image_size): Remove redundant decls.
8331 (check_image_size): Don't assume that arbitrary EMACS_INT values
8332 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8333 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8334 (tiff_load, imagemagick_load_image):
8335 Check for overflow in size calculations.
8336 (x_create_x_image_and_pixmap): Remove unnecessary test for
8337 xmalloc returning NULL; that can't happen.
8338 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8339 (xpm_color_bucket): Use better integer hashing function.
8340 (xpm_cache_color): Don't possibly over-allocate memory.
8341 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8342 (gif_memory_source):
8343 Use ptrdiff_t, not int or size_t, to record sizes.
8344 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8345 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8346 either works, as we prefer signed integers.
8347 (tiff_read_from_memory, tiff_write_from_memory):
8348 Return tsize_t, not size_t, since that's what the TIFF API wants.
8349 (tiff_read_from_memory): Don't fail simply because the read would
8350 go past EOF; instead, return a short read.
8351 (tiff_load): Omit no-longer-needed casts.
8352 (Fimagemagick_types): Don't assume size fits into 'int'.
8353
3cc5a532
PE
8354 Improve hashing quality when configured --with-wide-int.
8355 * fns.c (hash_string): New function, taken from sxhash_string.
8356 Do not discard information about ASCII character case; this
8357 discarding is no longer needed.
8358 (sxhash-string): Use it. Change sig to match it. Caller changed.
8359 * lisp.h: Declare it.
8360 * lread.c (hash_string): Remove, since we now use fns.c's version.
8361 The fns.c version returns a wider integer if --with-wide-int is
8362 specified, so this should help the quality of the hashing a bit.
8363
b312a492
PE
8364 * emacs.c: Integer overflow minor fix.
8365 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8366 Define only if GNU_LINUX.
8367 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8368
dfd153ae
PE
8369 * dispnew.c: Integer signedness and overflow fixes.
8370 Remove unnecessary forward decls, that were a maintenance hassle.
8371 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8372 All uses changed.
8373 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8374 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8375 (prepare_desired_row, line_draw_cost):
8376 Use int, not unsigned, where either works.
8377 (save_current_matrix, restore_current_matrix):
8378 Use ptrdiff_t, not size_t, where either works.
8379 (init_display): Check for overflow more accurately, and without
8380 relying on undefined behavior.
8381
a81d11a3
PE
8382 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8383 Remove, replacing with the new symbols in lisp.h. All uses changed.
8384 * fileio.c (make_temp_name):
8385 * filelock.c (lock_file_1, lock_file):
8386 * xdisp.c (message_dolog):
8387 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8388 Use pMd etc. instead.
8389 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8390 replacing the pWIDE etc. symbols removed from editfns.c.
8391
3300e6fd
PE
8392 * keyboard.h (num_input_events): Now uintmax_t.
8393 This is (very slightly) less likely to mess up due to wraparound.
8394 All uses changed.
8395
fd05c7e9
PE
8396 * buffer.c: Integer signedness fixes.
8397 (alloc_buffer_text, enlarge_buffer_text):
8398 Use ptrdiff_t rather than size_t when either will do, as we prefer
8399 signed integers.
8400
903fe15d
PE
8401 * alloc.c: Integer signedness and overflow fixes.
8402 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8403 (__malloc_size_t): Default to size_t, not to int.
8404 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8405 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8406 Prefer ptrdiff_t to size_t when either would do, as we prefer
8407 signed integers.
8408 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8409 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8410 Now const. Initialize with values that are in range even if char
8411 is signed.
8412 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8413 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8414 These functions do the right thing with sizes > 2**32.
8415 (check_depth): Now ptrdiff_t, not int.
8416 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8417 Adjust to new way of storing sizes. Check for size overflow bugs
8418 in rest of code.
8419 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8420 slightly wrong anyway, as it missed one instance of
8421 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8422 (refill_memory_reserve): Omit needless cast to size_t.
8423 (mark_object_loop_halt): Mark as externally visible.
8424
ac82cc6a
PE
8425 * xselect.c: Integer signedness and overflow fixes.
8426 (Fx_register_dnd_atom, x_handle_dnd_message):
8427 Use ptrdiff_t, not size_t, since we prefer signed.
8428 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8429 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8430 x_dnd_atoms_size and x_dnd_atoms_length.
8431
c2d1e36d
PE
8432 * doprnt.c: Prefer signed to unsigned when either works.
8433 * eval.c (verror):
8434 * doprnt.c (doprnt):
8435 * lisp.h (doprnt):
8436 * xdisp.c (vmessage):
8437 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8438 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8439 prefer signed arithmetic to avoid comparison confusion.
8440 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8441 but is a bit tricky.
8442
0e926e56
PE
8443 Assume freestanding C89 headers, string.h, stdlib.h.
8444 * data.c, doprnt.c, floatfns.c, print.c:
8445 Include float.h unconditionally.
8446 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8447 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8448 * regex.c: Likewise for stddef.h, string.h.
8449 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8450 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8451 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8452 (STDC_HEADERS): Remove obsolete defines.
8453 * sysdep.c: Include limits.h unconditionally.
8454
9cfdb3ec
PE
8455 Assume support for memcmp, memcpy, memmove, memset.
8456 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8457 * regex.c (memcmp, memcpy):
8458 Remove; we assume C89 now.
8459
8460 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8461 (__malloc_safe_bcopy): Remove; no longer needed.
8462
cf950e6b 8463 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8464 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8465 well either way, and we prefer signed to unsigned.
8466
dbf38e02
LMI
84672011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8468
8469 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8470 closes the connection while we're reading (bug#9182).
8471
d6f0886c 84722011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8473
d6f0886c
JD
8474 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8475 are specified (Bug#9168).
24e0f6b1 8476
2eb1f9e6
PE
84772011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8478
8479 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8480 Found by GCC static checking and --with-wide-int on a 32-bit host.
8481
22381272 84822011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8483
8484 * xdisp.c (compute_display_string_pos): Fix logic of caching
8485 previous display string position. Initialize cached_prev_pos to
8486 -1. Fixes slow-down at the beginning of a buffer.
8487
f25e39b4
EZ
84882011-07-24 Eli Zaretskii <eliz@gnu.org>
8489
8490 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8491 for attrs[LFACE_FONTSET_INDEX].
8492
04c4b52e
PE
84932011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8494
8495 * xml.c (parse_region): Remove unused local
8496 that was recently introduced.
8497
c1734fbd
EZ
84982011-07-23 Eli Zaretskii <eliz@gnu.org>
8499
be18c5a5
EZ
8500 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8501 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8502
c1734fbd
EZ
8503 * xdisp.c (move_it_in_display_line_to): Record the best matching
8504 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8505 exit if none of the characters scanned was an exact match.
8506 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8507 when exact match is impossible due to invisible text, and the
8508 lines are truncated.
8509
a258d627
JD
85102011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8511
8512 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8513 for OSX >= 10.7.
8514
b6d5a689
EZ
85152011-07-22 Eli Zaretskii <eliz@gnu.org>
8516
0f74f785
EZ
8517 Fix a significant slow-down of cursor motion with C-n, C-p,
8518 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8519 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8520 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8521 (next_element_from_buffer): Call compute_stop_pos_backwards to
8522 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8523 base_level_stop.
8524 (reseat): Don't look for prev_stop, as that could mean a very long
8525 run.
8526 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8527 <cached_disp_overlay_modiff>: Cache for last found display string
8528 position.
551918c1 8529 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8530 about the same buffer in the same area of character positions, and
8531 the buffer wasn't changed since the time the display string
8532 position was cached.
551918c1 8533
b2d0c91a
EZ
85342011-07-22 Eli Zaretskii <eliz@gnu.org>
8535
8536 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8537 is an integer, which is important for empty lines. (Bug#9149)
8538
043604ee
CY
85392011-07-22 Chong Yidong <cyd@stupidchicken.com>
8540
8541 * frame.c (Fmodify_frame_parameters): In tty case, update the
8542 default face if necessary (Bug#4238).
8543
da4adb04
CY
85442011-07-21 Chong Yidong <cyd@stupidchicken.com>
8545
8546 * editfns.c (Fstring_to_char): No need to explain what a character
8547 is in the docstring (Bug#6576).
8548
9abd0532
LMI
85492011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8550
8551 * xml.c (parse_region): Make sure we always return a tree.
8552
36881d16
HK
85532011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8554
8555 * xml.c (parse_region): If a document contains only comments,
8556 return that, too.
8557
1e98674d
LMI
85582011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8559
8560 * xml.c (make_dom): Return comments, too.
8561
590bd467
PE
85622011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8563
8564 Port to OpenBSD.
8565 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8566 and the surrounding thread.
8567 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8568 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8569 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8570 timer goes off.
8571 * s/openbsd.h (BROKEN_SIGIO): Define.
8572 * unexelf.c (unexec) [__OpenBSD__]:
8573 Don't update the .mdebug section of the Alpha COFF symbol table.
8574
f41628b2
LMI
85752011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8576
8577 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8578 (bug#8460).
8579
b59b67c5
PE
85802011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8581
15e3a074
PE
8582 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8583 This fixes some race conditions on the permissions of any newly
8584 created file.
8585
41bed37d
PE
8586 * alloc.c (valid_pointer_p): Use pipe, not open.
8587 This fixes some permissions issues when debugging.
8588
b59b67c5
PE
8589 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8590 If fchown fails to set both uid and gid, try to set just gid,
8591 as that is sometimes allowed. Adjust the file's mode to eliminate
8592 setuid or setgid bits that are inappropriate if fchown fails.
8593
925a6be7
SM
85942011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8595
8596 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8597 to compare Lisp_Objects.
8598 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8599 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8600 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8601
52968808
AS
86022011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8603
0a6a104b
AS
8604 * lread.c (read_integer): Unread even EOF character.
8605 (read1): Likewise. Properly record start position of symbol.
8606
52968808
AS
8607 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8608 symbol character follows.
8609
9e381cdd
PE
86102011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8611
8612 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8613 This works around a problem with the previous change to Fcopy_file.
8614 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8615 and without this change, GCC might complain about discarding
8616 fchown's return value.
8617
b5641435
JB
86182011-07-16 Juanma Barranquero <lekktu@gmail.com>
8619
8620 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8621
a8031457
PE
86222011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8623
8624 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8625
dd889327
LMI
86262011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8627
750c33f7
LMI
8628 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8629 it's used from the C level.
8630
dd889327
LMI
8631 * process.c: Use the same condition for POLL_FOR_INPUT in both
8632 keyboard.c and process.c (bug#1858).
8633
87e86684
LM
86342011-07-09 Lawrence Mitchell <wence@gmx.li>
8635
8636 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8637 (Fgnutls_boot): Use it.
8638
64348f40
AS
86392011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8640
8641 * doc.c (Fsubstitute_command_keys): Revert last change.
8642
1d698799
LMI
86432011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8644
f863868c
LMI
8645 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8646 quotes the next character, and doesn't affect other longer
8647 sequences (bug#8935).
8648
1d698799
LMI
8649 * lread.c (syms_of_lread): Clarify that is isn't only
8650 `eval-buffer' and `eval-defun' that's affected by
8651 `lexical-binding' (bug#8460).
8652
aa4b6df6
EZ
86532011-07-15 Eli Zaretskii <eliz@gnu.org>
8654
8655 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8656 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8657
5d856da6
PE
86582011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8659
ad6042bb
PE
8660 Fix minor problems found by static checking.
8661 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8662 (elsz): Now a signed constant, not a size_t var. We prefer signed
8663 types to unsigned, to avoid integer comparison confusion. Without
8664 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8665 "cannot optimize loop, the loop counter may overflow", a symptom
8666 of the confusion.
f00bbb22 8667 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8668 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8669
6468f31c
LMI
86702011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8671
49080b10
LMI
8672 * search.c (Fre_search_backward): Mention `case-fold-search' in
8673 all the re_search_* functions (bug#8138).
8674
6468f31c
LMI
8675 * keyboard.c (Fopen_dribble_file): Document when the file is
8676 closed (bug#8056).
8677
c965adc5
EZ
86782011-07-14 Eli Zaretskii <eliz@gnu.org>
8679
df9733bf
EZ
8680 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8681 bidi_cache_idx.
8682
0bb23927
EZ
8683 Support bidi reordering of display and overlay strings.
8684 * xdisp.c (compute_display_string_pos)
8685 (compute_display_string_end): Accept additional argument STRING.
8686 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8687 (reseat_to_string): Initialize bidi_it->string.s and
8688 bidi_it->string.schars.
8689 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8690 NULL (avoids a crash in bidi_paragraph_init).
8691 Initialize itb.string.lstring.
0bb23927
EZ
8692 (init_iterator): Call bidi_init_it only of a valid
8693 buffer position was specified. Initialize paragraph_embedding to
8694 L2R.
8695 (reseat_to_string): Initialize the bidi iterator.
8696 (display_string): If we need to ignore text properties of
8697 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8698 original value of -1 will not work with bidi.)
8699 (compute_display_string_pos): First arg is now struct
8700 `text_pos *'; all callers changed. Support display properties on
8701 Lisp strings.
8702 (compute_display_string_end): Support display properties on Lisp
8703 strings.
8704 (init_iterator, reseat_1, reseat_to_string): Initialize the
8705 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8706 when iterating on a string not from display properties).
640c8776
SM
8707 (compute_display_string_pos, compute_display_string_end):
8708 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8709 arrow keys.
8710 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8711 base_level_stop; instead, set base_level_stop to BEGV.
8712 Fixes crashes in vertical-motion.
0bb23927
EZ
8713 (next_element_from_buffer): Improve commentary for when
8714 the iterator is before prev_stop.
8715 (init_iterator): Initialize bidi_p from the default value of
8716 bidi-display-reordering, not from buffer-local value. Use the
8717 buffer-local value only if initializing for buffer iteration.
8718 (handle_invisible_prop): Support invisible properties on strings
8719 that are being bidi-reordered.
8720 (set_iterator_to_next): Support bidi reordering of C strings and
8721 Lisp strings.
8722 (next_element_from_string): Support bidi reordering of Lisp
8723 strings.
8724 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8725 (display_string): Support display of R2L glyph rows.
8726 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8727 (init_iterator): Don't initialize it->bidi_p for strings
8728 here.
8729 (reseat_to_string): Initialize it->bidi_p for strings here.
8730 (next_element_from_string, next_element_from_c_string)
8731 (next_element_from_buffer): Add xassert's for correspondence
8732 between IT's object being iterated and it->bidi_it.string
8733 structure.
8734 (face_before_or_after_it_pos): Support bidi iteration.
8735 (next_element_from_c_string): Handle the case of the first string
8736 character that is not the first one in the visual order.
8737 (get_visually_first_element): New function, refactored from common
8738 parts of next_element_from_buffer, next_element_from_string, and
8739 next_element_from_c_string.
8740 (tool_bar_lines_needed, redisplay_tool_bar)
8741 (display_menu_bar): Force left-to-right direction. Add a FIXME
8742 comment for making that be controlled by a user option.
8743 (push_it, pop_it): Save and restore the state of the
8744 bidi iterator. Save and restore the bidi_p flag.
8745 (pop_it): Iterate out of display property for string iteration as
8746 well.
8747 (iterate_out_of_display_property): Support iteration over strings.
8748 (handle_single_display_spec): Set up it->bidi_it for iteration
8749 over a display string, and call bidi_init_it.
8750 (handle_single_display_spec, next_overlay_string)
8751 (get_overlay_strings_1, push_display_prop): Set up the bidi
8752 iterator for displaying display or overlay strings.
8753 (forward_to_next_line_start): Don't use the shortcut if
8754 bidi-iterating.
8755 (back_to_previous_visible_line_start): If handle_display_prop
8756 pushed the iterator stack, restore the internal state of the bidi
8757 iterator by calling bidi_pop_it same number of times.
8758 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8759 and we are bidi-iterating, don't decrement the iterator position;
8760 instead, set the first_elt flag in the bidi iterator, to produce
8761 the same effect.
8762 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8763 (push_display_prop): xassert that we are iterating a buffer.
8764 (push_it, pop_it): Save and restore paragraph_embedding member.
8765 (handle_single_display_spec, next_overlay_string)
8766 (get_overlay_strings_1, reseat_1, reseat_to_string)
8767 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8768 correctly. Don't assume unibyte strings are not bidi-reordered.
8769 (compute_display_string_pos)
8770 (compute_display_string_end): Fix handling the case of C string.
8771 (push_it, pop_it): Save and restore from_disp_prop_p.
8772 (handle_single_display_spec, push_display_prop): Set the
8773 from_disp_prop_p flag.
8774 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8775 (pop_it): Call iterate_out_of_display_property only if we are
8776 popping after iteration over a string that came from a display
8777 property. Fix a typo in popping stretch info. Add an assertion
8778 for verifying that the iterator position is in sync with the bidi
8779 iterator.
8780 (handle_single_display_spec, get_overlay_strings_1)
8781 (push_display_prop): Fix initialization of paragraph direction for
8782 string when that of the parent object is not yet determined.
8783 (reseat_1): Call bidi_init_it to resync the bidi
8784 iterator with IT's position. (Bug#7616)
8785 (find_row_edges): If ROW->start.pos gives position
8786 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8787 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8788 Reset the from_disp_prop_p flag.
8789 (SAVE_IT, RESTORE_IT): New macros.
8790 (pos_visible_p, face_before_or_after_it_pos)
8791 (back_to_previous_visible_line_start)
8792 (move_it_in_display_line_to, move_it_in_display_line)
8793 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8794 (try_scrolling, redisplay_window, display_line): Use them when
8795 saving a temporary copy of the iterator and restoring it back.
8796 (back_to_previous_visible_line_start, reseat_1)
8797 (init_iterator): Empty the bidi cache "stack".
8798 (move_it_in_display_line_to): If iterator ended up at
8799 EOL, but we never saw any buffer positions smaller than
8800 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8801 motion in bidi-reordered lines.
8802 (move_it_in_display_line_to): Record prev_method and prev_pos
8803 immediately before the call to set_iterator_to_next. Fixes cursor
8804 motion in bidi-reordered lines with stretch glyphs and strings
8805 displayed in margins. (Bug#8133) (Bug#8867)
8806 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8807 TO_CHARPOS.
640c8776
SM
8808 (pos_visible_p): Support positions in bidi-reordered lines.
8809 Save and restore bidi cache.
0bb23927
EZ
8810
8811 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8812 (bidi_paragraph_info): Delete unused struct.
8813 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8814 (bidi_cache_start): New variable.
8815 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8816 to zero.
8817 (bidi_cache_fetch_state, bidi_cache_search)
8818 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8819 (bidi_cache_find, bidi_peek_at_next_level)
8820 (bidi_level_of_next_char, bidi_find_other_level_edge)
8821 (bidi_move_to_visually_next): Compare cache index with
8822 bidi_cache_start rather than with zero.
8823 (bidi_fetch_char): Accept new argument STRING; all callers
8824 changed. Support iteration over a string. Support strings with
8825 display properties. Support unibyte strings. Fix the type of
8826 `len' according to what STRING_CHAR_AND_LENGTH expects.
8827 (bidi_paragraph_init, bidi_resolve_explicit_1)
8828 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8829 (bidi_level_of_next_char, bidi_move_to_visually_next):
8830 Support iteration over a string.
0bb23927
EZ
8831 (bidi_set_sor_type, bidi_resolve_explicit_1)
8832 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8833 can now be zero (for strings); special values 0 and -1 were
8834 changed to -1 and -2, respectively.
8835 (bidi_char_at_pos): New function.
8836 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8837 Call it instead of FETCH_MULTIBYTE_CHAR.
8838 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8839 initialized to valid values.
8840 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8841 values.
8842 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8843 the test for valid cached positions. Fix the logic for looking up
8844 the sentinel state in the cache. GCPRO the Lisp string we are
8845 iterating.
8846 (bidi_push_it, bidi_pop_it): New functions.
8847 (bidi_initialize): Initialize the bidi cache start stack pointer.
8848 (bidi_cache_ensure_space): New function, refactored from part of
8849 bidi_cache_iterator_state. Don't assume the required size is just
8850 one BIDI_CACHE_CHUNK away.
8851 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8852 (bidi_count_bytes, bidi_char_at_pos): New functions.
8853 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8854 always valid if bidi_cache_idx is valid.
8855 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8856 is valid if it's going to be used.
8857 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8858 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8859 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8860 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8861 (bidi_find_other_level_edge, bidi_cache_start_stack):
8862 All variables related to cache indices are now EMACS_INT.
c965adc5 8863
0bb23927
EZ
8864 * dispextern.h (struct bidi_string_data): New structure.
8865 (struct bidi_it): New member `string'. Make flag members be 1-bit
8866 fields, and put them last in the struct.
640c8776
SM
8867 (compute_display_string_pos, compute_display_string_end):
8868 Update prototypes.
0bb23927
EZ
8869 (bidi_push_it, bidi_pop_it): Add prototypes.
8870 (struct iterator_stack_entry): New members bidi_p,
8871 paragraph_embedding, and from_disp_prop_p.
8872 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8873 (bidi_shelve_cache, bidi_unshelve_cache):
8874 Declare prototypes.
0bb23927
EZ
8875
8876 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8877 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8878 and vector-like objects.
8879
8880 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8881 cache around display iteration.
8882
8883 * window.c (Fwindow_end, window_scroll_pixel_based)
8884 (displayed_window_lines, Frecenter): Save and restore the bidi
8885 cache around display iteration.
8886
3bbd2265
LMI
88872011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8888
8889 * editfns.c (Fdelete_region): Clarify the use of the named
8890 parameters (bug#6788).
8891
adc47434
MR
88922011-07-14 Martin Rudalics <rudalics@gmx.at>
8893
8894 * indent.c (Fvertical_motion): Set and restore w->pointm when
8895 saving and restoring the window's buffer (Bug#9006).
8896
837c31f8
LMI
88972011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8898
8899 * editfns.c (Fstring_to_char): Clarify just what is returned
8900 (bug#6576). Text by Eli Zaretskii.
8901
ac389d0c
JB
89022011-07-13 Juanma Barranquero <lekktu@gmail.com>
8903
8904 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8905
0be0ce47
EZ
89062011-07-13 Eli Zaretskii <eliz@gnu.org>
8907
8908 * buffer.c (mmap_find): Fix a typo.
8909
cd18e7e3
JB
89102011-07-13 Johan Bockgård <bojohan@gnu.org>
8911
8912 Fix execution of x selection hooks.
8913 * xselect.c (Qx_lost_selection_functions)
8914 (Qx_sent_selection_functions): New vars.
8915 (syms_of_xselect): DEFSYM them.
8916 (x_handle_selection_request): Pass Qx_sent_selection_functions
8917 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8918 (x_handle_selection_clear,x_clear_frame_selections):
8919 Pass Qx_lost_selection_functions rather than
8920 Vx_lost_selection_functions to Frun_hook_with_args.
8921
47ea7f44
PE
89222011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8923
ac389d0c 8924 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8925 The old code sometimes used this field without initializing it.
8926
47ea7f44
PE
8927 * alloc.c (gc_sweep): Don't read past end of array.
8928 In theory, the old code could also have corrupted Emacs internals,
8929 though it'd be very unlikely.
8930
bc985c87
AS
89312011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8932
8933 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8934 argument. (Bug#4026)
bc985c87 8935
0cf34688
LMI
89362011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8937
b3dadd76
LMI
8938 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8939 key" (bug#4257).
8940
0cf34688
LMI
8941 * window.c (Fset_window_start): Doc fix (bug#4199).
8942 (Fset_window_hscroll): Ditto.
8943
270768cd
PE
89442011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8945
077e3dda 8946 Fix minor new problems caught by GCC 4.6.1.
270768cd 8947 * term.c (init_tty): Remove unused local.
490011a6 8948 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8949 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8950 not used otherwise.
270768cd 8951
b1f58454
CY
89522011-07-12 Chong Yidong <cyd@stupidchicken.com>
8953
8954 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8955
22b9578d
LMI
89562011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8957
6e70ab07
LMI
8958 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8959 are the mini-buffer and the echo area (bug#3320).
8960
22b9578d
LMI
8961 * term.c (init_tty): Remove support for supdup, c10 and perq
8962 terminals, which are no longer supported (bug#1482).
8963
8974cc9f
JB
89642011-07-10 Johan Bockgård <bojohan@gnu.org>
8965
8966 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8967
a560d974
JD
89682011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8969
8970 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8971 for non-popups (Bug#3642).
8972
1dae0f0a
AS
89732011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8974
268c2c36 8975 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8976 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8977 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8978 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8979 * data.c (fmod): Likewise.
8980 * dispnew.c (swap_glyphs_in_rows): Likewise.
8981 * emacs.c (memory_warning_signal): Likewise.
8982 * floatfns.c (float_error): Likewise.
8983 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8984 (otf_open, font_otf_capability, generate_otf_features)
8985 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8986 Likewise.
8987 * image.c (pbm_read_file): Likewise.
8988 * indent.c (string_display_width): Likewise.
8989 * intervals.c (check_for_interval, search_for_interval)
8990 (inc_interval_count, count_intervals, root_interval)
8991 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8992 * lread.c (defalias): Likewise.
268c2c36 8993 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8994 * regex.c (set_image_of_range_1, set_image_of_range)
8995 (regex_grow_registers): Likewise.
8996 * sysdep.c (strerror): Likewise.
8997 * termcap.c (valid_filename_p, tprint, main): Likewise.
8998 * tparam.c (main): Likewise.
8999 * unexhp9k800.c (run_time_remap, save_data_space)
9000 (update_file_ptrs, read_header, write_header, calculate_checksum)
9001 (copy_file, copy_rest, display_header): Likewise.
9002 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9003 Likewise.
9004 * xdisp.c (check_it): Likewise.
9005 * xfaces.c (register_color, unregister_color, unregister_colors):
9006 Likewise.
9007 * xfns.c (print_fontset_result): Likewise.
9008 * xrdb.c (member, fatal, main): Likewise.
9009
99033785
PE
90102011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9011
9012 Fix minor problems found by static checking (Bug#9031).
9013 * chartab.c (char_table_set_range, map_sub_char_table):
9014 Remove unused locals.
9015 (uniprop_table): Now static.
9016 * composite.c (_work_char): Remove unused static var.
9017
9cb2ac56
JB
90182011-07-09 Juanma Barranquero <lekktu@gmail.com>
9019
9020 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9021
f25661f0
JD
90222011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9023
9024 * gtkutil.c (qttip_cb): Remove code without function.
9025
8278c4fe
EZ
90262011-07-09 Eli Zaretskii <eliz@gnu.org>
9027
9028 * w32.c (pthread_sigmask): New stub.
9029
1692ae2d 90302011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9031
8a6ebd58 9032 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9033 sigprocmask is portable only for single-threaded applications, and
9034 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9035 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9036 (LIBES): Use it.
9037 * callproc.c (Fcall_process):
9038 * process.c (create_process):
9039 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9040 Use pthread_sigmask, not sigprocmask.
123403e4 9041
1b854618
JD
90422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9043
9044 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9045 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9046 wrong (Bug#8591).
9047
3fe4b549
JD
90482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9049
0ce7e563
JD
9050 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9051 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9052 (xg_hide_tooltip): Fix comment.
9053
3fe4b549
JD
9054 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9055 in registerServicesMenuSendTypes.
9056 (validRequestorForSendType): Don't check ns_return_types.
9057
9058 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9059 ns_return_type.
9060
5df75e47
JR
90612011-07-08 Jason Rumney <jasonr@gnu.org>
9062
22610910
JR
9063 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9064 SH_SHOW for hidden windows (Bug#5482).
9065
5df75e47
JR
9066 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9067 frame struct members of non-existent frames (Bug#6284).
9068
699c10bd
JD
90692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9070
4393663b
JD
9071 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9072 variable firstTime not needed on OSX >= 10.6.
9073 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9074 >= 10.5. Use setKnobProportion, setDoubleValue.
9075
9076 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9077 (MAC_OS_X_VERSION_10_5): Define if not defined.
9078 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9079 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9080 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9081
9082 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9083 cString and lossyCString on OSX >= 10.4.
4393663b 9084
58179cce 9085 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9086 sizeToFit on OSX >= 10.2.
9087
9088 * nsimage.m (allocInitFromFile): Don't use deprecated method
9089 bestRepresentationForDevice on OSX >= 10.6.
9090
9091 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9092 to avoid warning.
9093
9094 * emacs.c: Declare unexec_init_emacs_zone.
9095
a63e0781
JD
9096 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9097
699c10bd
JD
9098 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9099
9100 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9101 on svcsMenu (Bug#8842).
9102
9103 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9104 ns_return_types.
9105 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9106
9107 * nsterm.m (QUTF8_STRING): Declare.
9108 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9109 (validRequestorForSendType): Return type is (id).
9110 Change indexOfObjectIdenticalTo to indexOfObject.
9111 Check if we have local selection before returning self (Bug#8842).
9112 (writeSelectionToPasteboard): Put local selection into paste board
9113 if we have a local selection (Bug#8842).
9114 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9115
9116 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9117 (ns_get_local_selection): Declare.
9118
54e10184
LMI
91192011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9120
9888ff71
LMI
9121 * keymap.c (describe_map_tree): Don't insert a double newline at
9122 the end of the buffer (bug#1169) and return whether we inserted
9123 something.
9124
54e10184
LMI
9125 * callint.c (Fcall_interactively): Change "reading args" to
9126 "providing args" to try to clarify what it does (bug#1010).
9127
15fa4783
KH
91282011-07-07 Kenichi Handa <handa@m17n.org>
9129
9130 * composite.c (composition_compute_stop_pos): Ignore a static
9131 composition starting before CHARPOS (Bug#8915).
9132
9133 * xdisp.c (handle_composition_prop): Likewise.
9134
a8815b00
EZ
91352011-07-07 Eli Zaretskii <eliz@gnu.org>
9136
9137 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9138 (Bug#9015)
9139
ef7b981d 91402011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9141
9142 * character.h (unicode_category_t): New enum type.
9143
9144 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9145 (Qchar_code_property_table): New variable.
9146 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9147 (UNIPROP_COMPRESSED_FORM_P): New macros.
9148 (char_table_ascii): Uncompress the compressed values.
9149 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9150 Uncompress the compressed values.
ac389d0c 9151 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9152 (char_table_ref_and_range): Uncompress the compressed values.
9153 (sub_char_table_set): New arg is_uniprop. Callers changed.
9154 Uncompress the compressed values.
9155 (sub_char_table_set_range): Args changed. Callers changed.
9156 (char_table_set_range): Adjuted for the above change.
9157 (map_sub_char_table): Delete args default_val and parent. Add arg
9158 top. Give decoded values to a Lisp function.
640c8776 9159 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9160 values to a Lisp function. Gcpro more variables.
9161 (uniprop_table_uncompress)
9162 (uniprop_decode_value_run_length): New functions.
9163 (uniprop_decoder, uniprop_decoder_count): New variables.
9164 (uniprop_get_decoder, uniprop_encode_value_character)
9165 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9166 New functions.
9167 (uniprop_encoder, uniprop_encoder_count): New variables.
9168 (uniprop_get_encoder, uniprop_table)
9169 (Funicode_property_table_internal, Fget_unicode_property_internal)
9170 (Fput_unicode_property_internal): New functions.
9171 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9172 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9173 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9174 char-code-property-alist.
9175
640c8776 9176 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9177 Vunicode_category_table.
9178
640c8776 9179 * font.c (font_range): Adjust for the change of
c805dec0
KH
9180 Vunicode_category_table.
9181
76b397fb
DN
91822011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9183
9184 * m/iris4d.h: Remove file, move contents ...
9185 * s/irix6-5.h: ... here.
9186
22b4128e
PE
91872011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9188
9189 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9190 * alloc.c (mark_buffer):
9191 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9192 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9193 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9194 This isn't true in general, and it's particularly not true
9195 if Emacs is configured with --with-wide-int.
9196 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9197 New macros, used in the buffer.c change.
9198
869795d6
JD
91992011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9200
9201 * xsettings.c: Use both GConf and GSettings if both are available.
9202 (store_config_changed_event): Add comment.
9203 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9204 (store_tool_bar_style_changed): New functions.
5e617bc2 9205 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9206 (struct xsettings): Move font inside HAVE_XFT.
9207 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9208 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9209 Move inside HAVE_XFT.
640c8776 9210 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9211 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9212 also.
9213 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9214 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9215 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9216 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9217 (parse_settings): Move check for font inside HAVE_XFT.
9218 (read_settings, apply_xft_settings): Add comment.
9219 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9220 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9221 call store_font_name_changed.
9222 (xft_settings_event): Add comment.
9223 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9224 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9225 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9226 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9227 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9228 (xsettings_get_system_font, xsettings_get_system_normal_font):
9229 Add comment.
869795d6 9230
d8ed26bd
PE
92312011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9232
9233 Random fixes. E.g., (random) never returned negative values.
9234 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9235 subseconds part to the entropy, as that's a bit more random.
9236 Prefer signed to unsigned, since the signedness doesn't matter and
9237 in general we prefer signed. When given a limit, use a
9238 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9239 latter isn't right if USE_2_TAGS_FOR_INTS.
9240 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9241 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9242
cabf1cac
SM
92432011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9244
9245 * textprop.c (text_property_stickiness):
9246 Obey Vtext_property_default_nonsticky.
9247 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9248 * w32fns.c (syms_of_w32fns):
9249 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9250
6e9b2be9
PE
92512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9252
9253 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9254 This is more efficient than Ffile_directory_p and avoids a minor race.
9255
90186c68
LMI
92562011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9257
7c301272
LMI
9258 * buffer.c (Foverlay_put): Say what the return value is
9259 (bug#7835).
9260
c4f2d8d4
LMI
9261 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9262 is a directory before asking whether to use the file name
9263 (bug#7564).
ad637907
LMI
9264 (barf_or_query_if_file_exists): Make the "File is a directory"
9265 error be more correct.
c4f2d8d4 9266
90186c68
LMI
9267 * fns.c (Frequire): Remove the mention of the .gz files, since
9268 that's installation-specific, but keep the mention of
9269 `get-load-suffixes'.
9270
da64016e
PE
92712011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9272
9273 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9274 Report string overflow if the output is too long.
9275
7d47b580
JB
92762011-07-04 Juanma Barranquero <lekktu@gmail.com>
9277
a555cb87
JB
9278 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9279 (syms_of_gnutls): Remove duplicate DEFSYM for
9280 Qgnutls_bootprop_verify_hostname_error, an error for
9281 Qgnutls_bootprop_verify_error (which is no longer used).
9282
7d47b580
JB
9283 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9284 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9285 Also (re)move comments that are misplaced or no longer relevant.
9286
1e49bfab
LMI
92872011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9288
9289 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9290
1485f4c0
CY
92912011-07-03 Chong Yidong <cyd@stupidchicken.com>
9292
9293 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9294 and background color parameters if they have been changed.
9295
a9ab721e
LMI
92962011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9297
9298 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9299
cf7cff57
PE
93002011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9301
2e13213d
PE
9302 * xsettings.c (SYSTEM_FONT): Define only when used.
9303 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9304
cf7cff57
PE
9305 * keymap.c (access_keymap_1): Now static.
9306
7a8e04f7
CY
93072011-07-02 Chong Yidong <cyd@stupidchicken.com>
9308
9309 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9310 leave any prefix arg for the up event (Bug#1586).
9311
61352f62
LMI
93122011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9313
69bb1ef7
LMI
9314 * lread.c (syms_of_lread): Mention single symbols defined by
9315 `defvar' or `defconst' (bug#7154).
9316
61352f62 9317 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9318 (Frequire): Mention get-load-suffixes.
61352f62 9319
28545e04
MR
93202011-07-02 Martin Rudalics <rudalics@gmx.at>
9321
9322 * window.h (window): Remove clone_number slot.
9323 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9324 Remove.
9325 (make_parent_window, make_window, saved_window)
9326 (Fset_window_configuration, save_window_save): Don't deal with
9327 clone numbers.
9328 * buffer.c (Qclone_number): Remove declaration.
9329 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9330
3349e122
SM
93312011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9332
9333 Add multiple inheritance to keymaps.
9334 * keymap.c (Fmake_composed_keymap): New function.
9335 (Fset_keymap_parent): Simplify.
9336 (fix_submap_inheritance): Remove.
9337 (access_keymap_1): New function extracted from access_keymap to handle
9338 embedded parents and handle lists of maps.
9339 (access_keymap): Use it.
9340 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9341 (Fcopy_keymap): Handle embedded parents.
9342 (Fcommand_remapping, define_as_prefix): Simplify.
9343 (Fkey_binding): Simplify.
9344 (syms_of_keymap): Move minibuffer-local-completion-map,
9345 minibuffer-local-filename-completion-map,
9346 minibuffer-local-must-match-map, and
9347 minibuffer-local-filename-must-match-map to Elisp.
9348 (syms_of_keymap): Defsubr make-composed-keymap.
9349 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9350 (parse_menu_item): Trivial simplification.
9351
3279eb87
GM
93522011-07-01 Glenn Morris <rgm@gnu.org>
9353
9354 * Makefile.in (SETTINGS_LIBS): Fix typo.
9355
4550efdf
KI
93562011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9357
9358 * coding.c (Fencode_coding_string): Record the last coding system
9359 used, as the function doc string says (bug#8738).
9360
0949d2b6
JD
93612011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9362
9363 * xsettings.c (store_monospaced_changed): Take new font as arg and
9364 check for change against current_mono_font.
9365 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9366 (emacs_settings_constructor, emacs_settings_get_property)
9367 (emacs_settings_set_property, emacs_settings_class_init)
9368 (emacs_settings_init, gsettings_obj): Remove.
9369 (something_changedCB): New function for HAVE_GSETTINGS.
9370 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9371 with value as argument.
9372 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9373 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9374 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9375 "changed".
9376
9377 * xgselect.c: Add defined (HAVE_GSETTINGS).
9378 (xgselect_initialize): Ditto.
9379
9380 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9381 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9382 xg_select.
9383
bbc6b304
PE
93842011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9385
9386 * eval.c (struct backtrace): Simplify and port the data structure.
9387 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9388 signed bit field, as this assumption is not portable and it makes
9389 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9390 "char debug_on_exit : 1" as this is not portable either; instead,
9391 use the portable "unsigned int debug_on_exit : 1". Remove unused
9392 member evalargs. Remove obsolete comments about cc bombing out.
9393
9851bfc5
JD
93942011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9395
51bb811f 9396 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9397 Let HAVE_GSETTINGS override HAVE_GCONF.
9398 (store_monospaced_changed): New function.
9399 (EMACS_SETTINGS): A new type derived from GObject to handle
9400 GSettings notifications.
9401 (emacs_settings_constructor, emacs_settings_get_property)
9402 (emacs_settings_set_property, emacs_settings_class_init):
9403 New functions.
9404 (gsettings_client, gsettings_obj): New variables.
9405 (GSETTINGS_SCHEMA): New define.
9406 (something_changedCB): Call store_monospaced_changed.
9407 (init_gsettings): New function.
9408 (xsettings_initialize): Call init_gsettings.
9409 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9410 to NULL.
9411
640c8776 9412 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9413 GCONF_CFLAGS/LIBS.
9414
5386012d
MR
94152011-06-29 Martin Rudalics <rudalics@gmx.at>
9416
9417 * window.c (resize_root_window, grow_mini_window)
9418 (shrink_mini_window): Rename Qresize_root_window to
9419 Qwindow_resize_root_window and Qresize_root_window_vertically to
9420 Qwindow_resize_root_window_vertically.
9421
f13e0b08
PE
94222011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9423
9424 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9425
94515237
JB
94262011-06-27 Juanma Barranquero <lekktu@gmail.com>
9427
9428 * makefile.w32-in: Redesign dependencies so they reflect more
9429 clearly which files are directly included by each source file,
9430 and not through other includes.
9431
e43b6e43
MR
94322011-06-27 Martin Rudalics <rudalics@gmx.at>
9433
9434 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9435 (sort_overlays, overlay_strings): When an overlay's clone number
9436 matches the window's clone number process the overlay even if
9437 the overlay's window property doesn't match the current window.
9438
d68443dc
MR
9439 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9440 (Fwindow_hchild): Rename to Fwindow_left_child.
9441 (Fwindow_next): Rename to Fwindow_next_sibling.
9442 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9443 (resize_window_check): Rename to window_resize_check.
9444 (resize_window_apply): Rename to window_resize_apply.
9445 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9446 (Fdelete_other_windows_internal, resize_frame_windows)
9447 (Fsplit_window_internal, Fdelete_window_internal)
9448 (grow_mini_window, shrink_mini_window)
9449 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9450
c7e73be5
JD
94512011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9452
9453 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9454 (emacs_fixed_set_min_size): Remove.
9455 (emacs_fixed_new): Take frame as argument.
9456
9457 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9458 (_EmacsFixedPrivate): Remove minwidth/height.
9459 Add struct frame *f.
9460 (emacs_fixed_init): Initialize priv->f.
9461 (get_parent_class, emacs_fixed_set_min_size): Remove.
9462 (emacs_fixed_new): Set priv->f to argument.
9463 (emacs_fixed_get_preferred_width)
9464 (emacs_fixed_get_preferred_height): Use min_width/height from
9465 frames size_hint to set minimum and natural (Bug#8919).
9466 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9467 and use min_width/height from frames size_hint to set
9468 min_width/height (Bug#8919).
9469
9470 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9471 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9472 Fix indentation.
c7e73be5 9473
cf99dcf8
EZ
94742011-06-26 Eli Zaretskii <eliz@gnu.org>
9475
9476 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9477 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9478 called at ZV.
9479
029529ac
CY
94802011-06-26 Chong Yidong <cyd@stupidchicken.com>
9481
9482 * process.c (wait_reading_process_output): Bypass select if
9483 waiting for a cell while ignoring keyboard input, and input is
9484 pending. Suggested by Jan Djärv (Bug#8869).
9485
7a7ef429
PE
94862011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9487
9488 Use gnulib's dup2 module instead of rolling our own.
9489 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9490
11fdef7d 94912011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9492
9493 * dispnew.c (scrolling_window): Before scrolling, turn off a
9494 mouse-highlight in the window being scrolled.
9495
cd3520a4
JB
94962011-06-24 Juanma Barranquero <lekktu@gmail.com>
9497
9498 Move DEFSYM to lisp.h and use everywhere.
9499
9500 * character.h (DEFSYM): Move declaration...
9501 * lisp.h (DEFSYM): ...here.
9502
9503 * gnutls.c:
9504 * minibuf.c:
9505 * w32menu.c:
9506 * w32proc.c:
9507 * w32select.c: Don't include character.h.
9508
9509 * alloc.c (syms_of_alloc):
9510 * buffer.c (syms_of_buffer):
9511 * bytecode.c (syms_of_bytecode):
9512 * callint.c (syms_of_callint):
9513 * casefiddle.c (syms_of_casefiddle):
9514 * casetab.c (init_casetab_once):
9515 * category.c (init_category_once, syms_of_category):
9516 * ccl.c (syms_of_ccl):
9517 * cmds.c (syms_of_cmds):
9518 * composite.c (syms_of_composite):
9519 * dbusbind.c (syms_of_dbusbind):
9520 * dired.c (syms_of_dired):
9521 * dispnew.c (syms_of_display):
9522 * doc.c (syms_of_doc):
9523 * editfns.c (syms_of_editfns):
9524 * emacs.c (syms_of_emacs):
9525 * eval.c (syms_of_eval):
9526 * fileio.c (syms_of_fileio):
9527 * fns.c (syms_of_fns):
9528 * frame.c (syms_of_frame):
9529 * fringe.c (syms_of_fringe):
9530 * insdel.c (syms_of_insdel):
9531 * keymap.c (syms_of_keymap):
9532 * lread.c (init_obarray, syms_of_lread):
9533 * macros.c (syms_of_macros):
9534 * msdos.c (syms_of_msdos):
9535 * print.c (syms_of_print):
9536 * process.c (syms_of_process):
9537 * search.c (syms_of_search):
9538 * sound.c (syms_of_sound):
9539 * syntax.c (init_syntax_once, syms_of_syntax):
9540 * terminal.c (syms_of_terminal):
9541 * textprop.c (syms_of_textprop):
9542 * undo.c (syms_of_undo):
9543 * w32.c (globals_of_w32):
9544 * window.c (syms_of_window):
9545 * xdisp.c (syms_of_xdisp):
9546 * xfaces.c (syms_of_xfaces):
9547 * xfns.c (syms_of_xfns):
9548 * xmenu.c (syms_of_xmenu):
9549 * xsettings.c (syms_of_xsettings):
9550 * xterm.c (syms_of_xterm): Use DEFSYM.
9551
4228cf16
TZ
95522011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9553
cd3520a4 9554 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9555
7fcccf1e
PE
95562011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9557
7efb4e0e
PE
9558 Integer and buffer overflow fixes (Bug#8873).
9559
ff5844ad
PE
9560 * print.c (printchar, strout): Check for string overflow.
9561 (PRINTPREPARE, printchar, strout):
9562 Don't set size unless allocation succeeds.
9563
90532f02
PE
9564 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9565 for sizes. Check for string overflow more accurately.
9566 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9567
6d84508d
PE
9568 * macros.c: Integer and buffer overflow fixes.
9569 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9570 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9571 Use ptrdiff_t, not int, for sizes.
9572 Don't increment bufsize until after realloc succeeds.
9573 Check for size-calculation overflow.
9574 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9575
437b2cb4
PE
9576 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9577
8b9ac8b4
PE
9578 * lread.c: Integer overflow fixes.
9579 (read_integer): Radix is now EMACS_INT, not int,
9580 to improve quality of diagnostics for out-of-range radices.
9581 Calculate buffer size correctly for out-of-range radices.
9582 (read1): Check for integer overflow in radices, and in
9583 read-circle numbers.
82cb60d3
PE
9584 (read_escape): Avoid int overflow.
9585 (Fload, openp, read_buffer_size, read1)
9586 (substitute_object_recurse, read_vector, read_list, map_obarray):
9587 Use ptrdiff_t, not int, for sizes.
9588 (read1): Use EMACS_INT, not int, for sizes.
20270765 9589 Check for size overflow.
8b9ac8b4 9590
7fcccf1e
PE
9591 * image.c (cache_image): Check for size arithmetic overflow.
9592
bfbbd7e7
PE
9593 * lread.c: Integer overflow issues.
9594 (saved_doc_string_size, saved_doc_string_length)
9595 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9596 Now ptrdiff_t, not int.
9597 (read1): Don't assume doc string length fits in int. Check for
9598 out-of-range doc string lengths.
9599 (read_list): Don't assume file position fits in int.
39019e54 9600 (read_escape): Check for hex character overflow.
bfbbd7e7 9601
4e323265
LL
96022011-06-22 Leo Liu <sdl.web@gmail.com>
9603
9604 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9605 Move to minibuffer.el.
9606
85fece3e
PE
96072011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9608
20b84ce9 9609 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9610 The following patches are for when GLYPH_DEBUG && !XASSERT.
9611 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9612 * dispnew.c (flush_stdout):
9613 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9614 Mark as externally visible.
9615 * dispnew.c (check_window_matrix_pointers): Now static.
9616 * dispnew.c (window_to_frame_vpos):
9617 * xfns.c (unwind_create_frame):
9618 * xterm.c (x_check_font): Remove unused local.
9619 * scroll.c (CHECK_BOUNDS):
9620 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9621 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9622 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9623 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9624 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9625 Now static.
9626 (debug_method_add): Use va_list and vsprintf rather than relying
9627 on undefined behavior with wrong number of arguments.
9628 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9629 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9630 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9631 since we're not interested in debugging glyphs with old libraries.
9632 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9633 GCC 4.6.0's static checking.
9634
0766b489
PE
96352011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9636
31fd4b32
PE
9637 Integer overflow and signedness fixes (Bug#8873).
9638 A few related buffer overrun fixes, too.
9639
b79e8648
PE
9640 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9641
0766b489
PE
9642 * dispextern.h (struct face.stipple):
9643 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9644 (x_bitmap_mask, x_allocate_bitmap_record)
9645 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9646 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9647 (x_create_bitmap_from_xpm_data):
9648 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9649 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9650 (.bitmaps_last):
9651 * xfaces.c (load_pixmap):
9652 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9653 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9654 (.bitmaps_last, struct x_output.icon_bitmap):
9655 Use ptrdiff_t, not int, for bitmap indexes.
9656 (x_allocate_bitmap_record): Check for size overflow.
9657 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9658
b081724f
PE
9659 Use ptrdiff_t, not int, for overlay counts.
9660 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9661 * editfns.c (overlays_around, get_pos_property):
9662 * textprop.c (get_char_property_and_overlay):
9663 * xdisp.c (next_overlay_change, note_mouse_highlight):
9664 * xfaces.c (face_at_buffer_position):
21514da7
PE
9665 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9666 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9667 (Fnext_overlay_change, Fprevious_overlay_change)
9668 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9669 Use ptrdiff_t, not int, for sizes.
21514da7 9670 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9671
3de73e5e
PE
9672 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9673
2606c57b
PE
9674 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9675 (x_session_initialize): Do not assume string length fits in int.
9676
aaafe47a
PE
9677 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9678 This is unlikely, but can occur if DPI is outlandish.
9679
2674ddc8 9680 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9681 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9682
28154962
PE
9683 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9684 * xrdb.c (magic_file_p, search_magic_path):
9685 Omit last arg SUFFIX; it was always 0. All callers changed.
9686 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9687
7de51af5
PE
9688 * xfont.c (xfont_match): Avoid need for strlen.
9689
25ed6cc3
PE
9690 * xfns.c: Don't assume strlen fits in int.
9691 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9692
4eab31dd
PE
9693 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9694 not unsigned long, as we prefer signed integers. All callers changed.
9695 Detect integer overflow in repeat count.
9696 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9697 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9698
171e2a58
PE
9699 * termcap.c: Don't assume sizes fit in int and never overflow.
9700 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9701 (gobble_line): Check for size-calculation overflow.
9702
ad39faca 9703 * minibuf.c (Fread_buffer):
6e5bb2dc 9704 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9705 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9706 Don't assume string length fits in int.
9707
52c61c22 9708 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9709 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9710
b5b8c9e5
PE
9711 * font.c: Don't assume string length fits in int.
9712 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9713 Use ptrdiff_t, not int.
ccd6111c
PE
9714 (font_intern_prop): Don't assume string length fits in int.
9715 Don't assume integer property fits in fixnum.
9716 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9717
882f0d81 9718 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9719 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9720 Reformulate so as not to need the command string.
9721 Invoke gzip -cd rather than gunzip, as it's more portable.
9722 (lock_info_type, lock_file_1, lock_file):
9723 Don't assume pid_t and time_t fit in unsigned long.
9724 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9725 (current_lock_owner): Prefer signed type for sizes.
9726 Use memcpy, not strncpy, where memcpy is what is really wanted.
9727 Don't assume (via atoi) that time_t and pid_t fit in int.
9728 Check for time_t and/or pid_t out of range, e.g., via a network share.
9729 Don't alloca where an auto var works fine.
9730
93f4cf88
PE
9731 * fileio.c: Fix some integer overflow issues.
9732 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9733 Don't assume string length fits in int.
9734 (directory_file_name): Don't assume string length fits in long.
9735 (make_temp_name): Don't assume pid fits in int, or that its print
9736 length is less than 20.
9737
f3e92b69
PE
9738 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9739
1bfdaf10
PE
9740 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9741
35016e9a
PE
9742 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9743
3d1e65a1
PE
9744 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9745 We prefer signed integers, even for size calculations.
9746
0b963a93
PE
9747 * emacs.c: Don't assume string length fits in 'int'.
9748 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9749 (main): Don't invoke strlen when not needed.
9750
573f4b54
PE
9751 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9752 (XD_DEBUG_MESSAGE): Don't waste a byte.
9753
989f33ba
PE
9754 * callproc.c (getenv_internal_1, getenv_internal)
9755 (Fgetenv_internal):
965d34eb
PE
9756 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9757
e4d29b33
PE
9758 * lread.c (invalid_syntax): Omit length argument.
9759 All uses changed. This doesn't fix a bug, but it simplifies the
9760 code away from its former Hollerith-constant appearance, and it's
9761 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9762 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9763
eb49b136
PE
9764 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9765 This didn't break anything, but it didn't help either.
9766 It's confusing to put a bogus integer in a place where the actual
9767 value does not matter.
9f62aeb1 9768 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9769 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9770
15375a22
PE
9771 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9772 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9773 implementation.
b61cc01c
PE
9774 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9775 We prefer signed types, and the value cannot exceed the EMACS_INT
9776 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9777 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9778 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9779 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9780
53b2623d
PE
9781 * indent.c (sane_tab_width): New function.
9782 (current_column, scan_for_column, Findent_to, position_indentation)
9783 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9784 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9785
51cab52b 9786 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9787
f2ed8a70
PE
9788 * lisp.h (lint_assume): New macro.
9789 * composite.c (composition_gstring_put_cache):
9790 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9791
abe80cc6
PE
9792 * editfns.c, insdel.c:
9793 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9794
b02c740e
PE
9795 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9796
ebc96716
PE
9797 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9798
b4e50fa0 9799 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9800 Use much-faster test for byte-length change.
311d5d7c 9801 Don't assume string byte-length fits in 'int'.
a4cf38e4 9802 Check that character arg fits in 'int'.
85461888 9803 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9804
c0c1ee9f
PE
9805 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9806
a498d7f4
PE
9807 * fns.c (concat): Catch string overflow earlier.
9808 Do not rely on integer wraparound.
9809
51cab52b
PE
9810 * dispextern.h (struct it.overlay_strings_charpos)
9811 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9812 * xdisp.c (forward_to_next_line_start)
9813 (back_to_previous_visible_line_start)
9814 (reseat_at_next_visible_line_start, next_element_from_buffer):
9815 Don't arbitrarily truncate the value of 'selective' to int.
9816
76031fad
PE
9817 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9818
5eb55db9
PE
9819 * composite.c: Don't truncate sizes to 'int'.
9820 (composition_gstring_p, composition_reseat_it)
9821 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9822 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9823 not EMACS_UINT, for indexes.
5eb55db9 9824
0703a717
PE
9825 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9826
d6202519
PE
9827 * buffer.c: Include <verify.h>.
9828 (struct sortvec.priority, struct sortstr.priority):
8961a454 9829 Now EMACS_INT, not int.
c20998a7 9830 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9831 (struct sortstr.size, record_overlay_string)
9832 (struct sortstrlist.size, struct sortlist.used):
9833 Don't truncate size to int.
9834 (record_overlay_string): Check for size-calculation overflow.
d6202519 9835 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9836
d5a19415
JM
98372011-06-22 Jim Meyering <meyering@redhat.com>
9838
029529ac 9839 Don't leak an XBM-image-sized buffer
d5a19415
JM
9840 * image.c (xbm_load): Free the image buffer after using it.
9841
a9041e6c
PE
98422011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9843
9844 Port to Sun C.
9845 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9846 that Sun C diagnosed.
9847 * fns.c (secure_hash): Fix pointer signedness issue.
9848 * intervals.c (static_offset_intervals): New function.
9849 (offset_intervals): Use it.
9850
7f3f739f
LL
98512011-06-21 Leo Liu <sdl.web@gmail.com>
9852
9853 * deps.mk (fns.o):
9854 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9855 sha512.h.
9856
9857 * fns.c (secure_hash): Rename from crypto_hash_function and change
9858 the first arg to accept symbols.
5b66d427 9859 (Fsecure_hash): New primitive.
7f3f739f
LL
9860 (syms_of_fns): New symbols.
9861
76147d94
DD
98622011-06-20 Deniz Dogan <deniz@dogan.se>
9863
9864 * process.c (Fset_process_buffer): Clarify return value in
9865 docstring.
9866
7d7d0045
CY
98672011-06-18 Chong Yidong <cyd@stupidchicken.com>
9868
9869 * dispnew.c (add_window_display_history): Use BVAR.
9870
9871 * xdisp.c (debug_method_add): Use BVAR.
9872 (check_window_end, dump_glyph_matrix, dump_glyph)
9873 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9874
9875 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9876 Likewise.
9877
9878 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9879 check till after the cache is created in init_frame_faces.
9880
ff2bc410
SM
98812011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9882
9883 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9884
28177add
PE
98852011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9886
dd3482fe
PE
9887 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9888 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9889 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9890
393d71f3 9891 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9892 * fileio.c (Finsert_file_contents):
9893 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9894 Remove the old (too-loose) buffer overflow checks.
9895 They weren't needed, since make_gap checks for buffer overflow.
9896 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9897 The old code merely checked for Emacs fixnum overflow, and relied
9898 on undefined (wraparound) behavior. The new code avoids undefined
9899 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9900
2e6813b0 9901 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9902 Tune. Don't use wider integers than needed. Don't use alloca.
9903 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9904
599a9e4f
PE
9905 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9906
99561444
PE
9907 * insdel.c, lisp.h (buffer_overflow): New function.
9908 (insert_from_buffer_1, replace_range, replace_range_2):
9909 * insdel.c (make_gap_larger):
9910 * editfns.c (Finsert_char):
9911 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9912
28177add
PE
9913 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9914
e69dafad
PE
99152011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9916
4baa020d 9917 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9918
b1c46f02
PE
9919 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9920 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9921
e69dafad
PE
9922 * fileio.c: Don't assume EMACS_INT fits in off_t.
9923 (emacs_lseek): New static function.
9924 (Finsert_file_contents, Fwrite_region): Use it.
9925 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9926
566684ea
PE
9927 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9928
e6966cd6
PE
9929 * fns.c: Don't overflow int when computing a list length.
9930 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9931 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9932 truncation on 64-bit hosts. Check for QUIT every
9933 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9934 faster and is responsive enough.
9935 (Flength): Report an error instead of overflowing an integer.
9936 (Fsafe_length): Return a float if the value is not representable
9937 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9938 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9939 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9940
dd0b0efb
PE
9941 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9942 (header_size, word_size): New constants.
9943 (allocate_vectorlike): Don't check size overflow here.
9944 (allocate_vector): Check it here instead, since this is the only
9945 caller of allocate_vectorlike that could cause overflow.
9946 Check that the new vector's length is representable as a fixnum.
9947
86fe5cfe
PE
9948 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9949 The previous code was bogus. For example, next_almost_prime (32)
9950 returned 39, which is undesirable as it is a multiple of 3; and
9951 next_almost_prime (24) returned 25, which is a multiple of 5 so
9952 why was the code bothering to check for multiples of 7?
9953
80e88859
PE
9954 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9955
4a2f0ad6
PE
9956 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9957
f66c7cf8
PE
9958 Variadic C functions now count arguments with ptrdiff_t.
9959 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9960 Back then I didn't know that the Emacs coding style prefers signed int.
9961 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9962 were being counted with int, which may truncate counts on 64-bit
9963 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9964 * lisp.h (struct Lisp_Subr.function.aMANY)
9965 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9966 Arg counts are now ptrdiff_t, not size_t.
9967 All variadic functions and their callers changed accordingly.
9968 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9969 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9970 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9971 * callint.c (Fcall_interactively): Check arg count for overflow,
9972 to avoid potential buffer overrun. Use signed char, not 'int',
9973 for 'varies' array, so that we needn't bother to check its size
9974 calculation for overflow.
9975 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9976 * eval.c (apply_lambda):
9977 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9978 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9979 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9980
a1759b76
PE
9981 * callint.c (Fcall_interactively): Don't use index var as event count.
9982
d96be9fc
PE
9983 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9984 * mem-limits.h (SIZE): Remove; no longer used.
9985
a690a978 9986 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9987
578c21e6
PE
9988 Remove unnecessary casts.
9989 * xterm.c (x_term_init):
9990 * xfns.c (x_set_border_pixel):
9991 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9992 These aren't needed now that we assume ANSI C.
9993
96f53c6c
PE
9994 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9995 It's more likely to cause problems (due to unsigned overflow)
9996 than to cure them.
9997
83c77d31
PE
9998 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9999
ee2079f1
PE
10000 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10001
6da65536
PE
10002 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10003
7147c4a4
PE
10004 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10005
193e32d9
PE
10006 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10007
e5533da6
PE
10008 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10009
9910e595
PE
10010 GLYPH_CODE_FACE returns EMACS_INT, not int.
10011 * dispextern.h (merge_faces):
10012 * xfaces.c (merge_faces):
01103c44
PE
10013 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10014 Don't assume EMACS_INT fits in int.
9910e595 10015
2638320e
PE
10016 * character.h (CHAR_VALID_P): Remove unused parameter.
10017 * fontset.c, lisp.h, xdisp.c: All uses changed.
10018
045eb8d9
PE
10019 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10020
c1f134b5
PE
10021 * fns.c (concat): Minor tuning based on overflow analysis.
10022 This doesn't fix any bugs. Use int to hold character, instead
10023 of constantly refetching from Emacs object. Use XFASTINT, not
10024 XINT, for value known to be a character. Don't bother comparing
10025 a single byte to 0400, as it's always less.
10026
395fcb93 10027 * floatfns.c (Fexpt):
327eeec8
PE
10028 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10029
abbd3d23
PE
10030 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10031 for characters.
10032
684a03ef
PE
10033 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10034
0fed43f3
PE
10035 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10036 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10037 incorrectly succeed when S was a string, because 4294967386 was
10038 truncated before it was used.
10039
8fd02eb7
PE
10040 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10041 Otherwise, an out-of-range integer could cause undefined behavior
10042 on a 64-bit host.
10043
f8c86b69
PE
10044 * composite.c: Use int, not EMACS_INT, for characters.
10045 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10046 EMACS_INT, for values that are known to be in character range.
10047 This doesn't fix any bugs but is the usual style inside Emacs and
10048 may generate better code on 32-bit machines.
10049
34206dd2
PE
10050 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10051 This is for reasons similar to the recent CHAR_STRING fix.
10052 * charset.c (Fencode_char): Check that character arg is actually
10053 a character. Pass an int to ENCODE_CHAR.
10054 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10055 wider than 'int', as a compile-time check to prevent future regressions
10056 in this area.
10057
c5958d4c 10058 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10059
10060 Make sure a 64-bit char is never passed to CHAR_STRING.
10061 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10062 by silently ignoring the top 32 bits, allowing some values
10063 that were far too large to be valid characters.
10064 * character.h: Include <verify.h>.
10065 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10066 arguments are no wider than unsigned, as a compile-time check
10067 to prevent future regressions in this area.
10068 * data.c (Faset):
01103c44 10069 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10070 (Fsubst_char_in_region):
10071 * fns.c (concat):
10072 * xdisp.c (decode_mode_spec_coding):
10073 Adjust to CHAR_STRING's new requirement.
10074 * editfns.c (Finsert_char, Fsubst_char_in_region):
10075 * fns.c (concat): Check that character args are actually
10076 characters. Without this test, these functions did the wrong
10077 thing with wildly out-of-range values on 64-bit hosts.
10078
d37ca623
PE
10079 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10080 These casts should not be needed on 32-bit hosts, either.
10081 * keyboard.c (read_char):
10082 * lread.c (Fload): Remove casts to unsigned.
10083
ea204efb
PE
10084 * lisp.h (UNSIGNED_CMP): New macro.
10085 This fixes comparison bugs on 64-bit hosts.
10086 (ASCII_CHAR_P): Use it.
10087 * casefiddle.c (casify_object):
01103c44 10088 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10089 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10090 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10091 * dispextern.h (FACE_FROM_ID):
10092 * keyboard.c (read_char): Use UNSIGNED_CMP.
10093
41cb286c
PE
10094 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10095 not to EMACS_INT, to avoid GCC warning.
10096
4a1b9832
PE
10097 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10098
55daad71
PE
10099 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10100 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10101 isn't needed on 32-bit machines.
8f95c75c 10102
01103c44
PE
10103 * buffer.c (Fgenerate_new_buffer_name):
10104 Use EMACS_INT for count, not int.
0ceccced 10105 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10106
10107 * data.c (Qcompiled_function): Now static.
10108
c6f072e7
PE
10109 * window.c (window_body_lines): Now static.
10110
20ce5912
PE
10111 * image.c (gif_load): Rename local to avoid shadowing.
10112
9c4c5f81
PE
10113 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10114 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10115 * alloc.c (make_save_value): Integer argument is now of type
10116 ptrdiff_t, not int.
10117 (mark_object): Use ptrdiff_t, not int.
10118 * lisp.h (pD): New macro.
10119 * print.c (print_object): Use it.
10120
c0c5c8ae
PE
10121 * alloc.c: Use EMACS_INT, not int, to count objects.
10122 (total_conses, total_markers, total_symbols, total_vector_size)
10123 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10124 (total_free_floats, total_floats, total_free_intervals)
10125 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10126 Now EMACS_INT, not int. All uses changed.
10127 (Fgarbage_collect): Compute overall total using a double, so that
10128 integer overflow is less likely to be a problem. Check for overflow
10129 when converting back to an integer.
5a25e253
PE
10130 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10131 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10132 These were 'int' variables that could overflow on 64-bit hosts;
10133 they were never used, so remove them instead of repairing them.
211a0b2a 10134 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10135 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10136 Previously, this ceilinged at INT_MAX, but that doesn't work on
10137 64-bit machines.
e46bb31a 10138 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10139
c78baabf 10140 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10141 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10142 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10143 when a (possibly-narrower) signed value would do just as well.
10144 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10145
c9d624c6
PE
10146 * alloc.c: Catch some string size overflows that we were missing.
10147 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10148 for convenience in STRING_BYTES_MAX.
10149 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10150 The definition here is exact; the one in lisp.h was approximate.
10151 (allocate_string_data): Check for string overflow. This catches
10152 some instances we weren't catching before. Also, it catches
10153 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10154 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10155 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10156
c9d624c6
PE
10157 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10158 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10159 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10160
353032ce
PE
10161 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10162
2bccce07
PE
10163 * alloc.c (Fmake_string): Check for out-of-range init.
10164
0ac30604
SM
101652011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10166
10167 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10168
c195f2de
JD
101692011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10170
10171 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10172 xg_get_default_scrollbar_width.
10173
10174 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10175 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10176 (style_changed_cb): Call update_theme_scrollbar_width and call
10177 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10178 all frames (Bug#8505).
10179 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10180 Call gtk_window_set_resizable if HAVE_GTK3.
10181 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10182 and height if HAVE_GTK3 (Bug#8505).
10183 (scroll_bar_width_for_theme): New variable.
10184 (update_theme_scrollbar_width): New function.
10185 (xg_get_default_scrollbar_width): Move code to
10186 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10187 (xg_initialize): Call update_theme_scrollbar_width.
10188
10189 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10190
10191 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10192
e10ac9f1
MR
101932011-06-12 Martin Rudalics <rudalics@gmx.at>
10194
10195 * frame.c (make_frame): Call other_buffer_safely instead of
10196 other_buffer.
10197
10198 * window.c (temp_output_buffer_show): Call display_buffer with
10199 second argument Vtemp_buffer_show_specifiers and reset latter
10200 immediately after the call.
10201 (Vtemp_buffer_show_specifiers): New variable.
10202 (auto_window_vscroll_p, next_screen_context_lines)
10203 (Vscroll_preserve_screen_position): Remove leading asterisks from
10204 doc-strings.
10205
2d3c217e 102062011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10207
7b7f97e8 10208 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10209 * buffer.c (Qclone_number): Remove for now, as it's unused.
10210 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10211 (record_buffer): Remove unused local.
10212 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10213 (set_frame_buffer_list): Remove; unused.
10214 * frame.h (other_visible_frames): Remove decl.
10215 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10216 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10217 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10218 if HAVE_GPM.
10219 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10220 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10221 Define only if HAVE_GPM.
10222 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10223 (update_hints_inhibit): Remove; never set. All uses removed.
10224 * widgetprv.h (emacsFrameClassRec): Remove decl.
10225 * window.c (delete_deletable_window): Now returns void, since it
10226 wasn't returning anything.
10227 (compare_window_configurations): Remove unused locals.
10228 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10229 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10230 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10231 the same widths as pointers. This follows up on the 2011-05-06 patch.
10232 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10233 * xterm.h: Likewise.
10234 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10235
1384b89e
JB
102362011-06-12 Juanma Barranquero <lekktu@gmail.com>
10237
10238 * makefile.w32-in: Update dependencies.
10239 (LISP_H): Add lib/intprops.h.
10240
1100a63c
CY
102412011-06-11 Chong Yidong <cyd@stupidchicken.com>
10242
10243 * image.c (gif_load): Add animation frame delay to the metadata.
10244 (syms_of_image): Use DEFSYM. New symbol `delay'.
10245
6198ccd0
MR
102462011-06-11 Martin Rudalics <rudalics@gmx.at>
10247
10248 * window.c (delete_deletable_window): Re-add.
10249 (Fset_window_configuration): Rewrite to handle dead buffers and
10250 consequently deletable windows.
10251 (window_tree, Fwindow_tree): Remove. Supply functionality in
10252 window.el.
10253 (compare_window_configurations): Simplify code.
10254
b6e3633c
AS
102552011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10256
1ab0dee5
AS
10257 * image.c (imagemagick_load_image): Fix type mismatch.
10258 (Fimagemagick_types): Likewise.
10259
b6e3633c
AS
10260 * window.h (replace_buffer_in_windows): Declare.
10261
9397e56f
MR
102622011-06-11 Martin Rudalics <rudalics@gmx.at>
10263
10264 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10265 Qclone_number. Remove external declaration of Qdelete_window.
10266 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10267 code.
640c8776
SM
10268 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10269 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10270 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10271 buffer list implementation.
10272 (other_buffer_safely): New function.
10273 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10274 calls to replace_buffer_in_windows and
10275 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10276 if allowed.
10277 (record_buffer): Inhibit quitting and rewrite using quittable
10278 functions. Run Qbuffer_list_update_hook if allowed.
10279 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10280 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10281 Move switch-to-buffer to window.el.
9397e56f
MR
10282 (bury-buffer): Move to window.el.
10283 (Vbuffer_list_update_hook): New variable.
10284
10285 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10286 section.
10287
10288 * window.h (resize_frame_windows): Move up in code.
10289 (Fwindow_frame): Remove EXFUN.
10290 (replace_buffer_in_all_windows): Remove prototype.
10291 (replace_buffer_in_windows_safely): Add prototype.
10292
10293 * window.c: Declare Qdelete_window static again. Move down
10294 declaration of select_count.
10295 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10296 (Fother_window): Move to window.el.
10297 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10298 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10299 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10300 window.el.
10301 (replace_buffer_in_windows): Implement by calling
10302 Qreplace_buffer_in_windows.
10303 (replace_buffer_in_all_windows): Remove with some functionality
10304 moved into replace_buffer_in_windows_safely.
10305 (replace_buffer_in_windows_safely): New function.
10306 (select_window_norecord, select_frame_norecord): Move in front
10307 of run_window_configuration_change_hook. Remove now obsolete
10308 declarations.
640c8776
SM
10309 (Fset_window_buffer): Rewrite doc-string.
10310 Call Qrecord_window_buffer.
9397e56f
MR
10311 (keys_of_window): Move binding for other-window to window.el.
10312
b50691aa
CY
103132011-06-11 Chong Yidong <cyd@stupidchicken.com>
10314
10315 * dispextern.h (struct image): Replace data member, whose int_val
10316 and ptr_val fields were not used by anything, with a single
10317 lisp_val object.
10318
10319 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10320 (gif_clear_image, gif_load, imagemagick_load_image)
10321 (gs_clear_image, gs_load): Callers changed.
10322
3f754b86
PE
103232011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10324
cca69397
PE
10325 * buffer.h: Include <time.h>, for time_t.
10326 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10327
109e28d0
PE
10328 Fix minor problems found by static checking.
10329
60737f02
PE
10330 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10331
4b66faf3
PE
10332 Make identifiers static if they are not used in other modules.
10333 * data.c (Qcompiled_function, Qframe, Qvector):
10334 * image.c (QimageMagick, Qsvg):
10335 * minibuf.c (Qmetadata):
10336 * window.c (resize_window_check, resize_root_window): Now static.
10337 * window.h (resize_window_check, resize_root_window): Remove decls.
10338
109e28d0
PE
10339 * window.c (window_deletion_count, delete_deletable_window):
10340 Remove; unused.
46a4ce9e
PE
10341 (window_body_lines): Now static.
10342 (Fdelete_other_windows_internal): Mark vars as initialized.
10343 Make sure 'resize_failed' is initialized.
10344 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10345 (resize_window_apply): Remove unused local.
10346 * window.h (delete_deletable_window): Remove decl.
10347
109e28d0 10348 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10349 (imagemagick_load_image): Fix pointer signedness problem by changing
10350 last arg from unsigned char * to char *. All uses changed.
10351 Also, fix a local for similar reasons.
10352 Remove unused locals. Remove locals to avoid shadowing.
10353 (fn_rsvg_handle_free): Remove; unused.
10354 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10355 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10356
3f754b86
PE
10357 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10358
2547adb1
CY
103592011-06-10 Chong Yidong <cyd@stupidchicken.com>
10360
10361 * image.c (gif_load): Fix omitted cast error introduced by
10362 2011-06-06 change.
10363
2c8e37d4
MR
103642011-06-10 Martin Rudalics <rudalics@gmx.at>
10365
10366 * window.h (resize_proportionally, orig_total_lines)
10367 (orig_top_line): Remove from window structure.
10368 (set_window_height, set_window_width, change_window_heights)
10369 (Fdelete_window): Remove prototypes.
10370 (resize_frame_windows): Remove duplicate declaration.
10371
440a42e3
EZ
103722011-06-10 Eli Zaretskii <eliz@gnu.org>
10373
10374 * window.h (resize_frame_windows, resize_window_check)
10375 (delete_deletable_window, resize_root_window)
10376 (resize_frame_windows): Declare prototypes.
10377
10378 * window.c (resize_window_apply): Make definition be "static" to
10379 match the prototype.
10380
562dd5e9
MR
103812011-06-10 Martin Rudalics <rudalics@gmx.at>
10382
10383 * window.c: Remove declarations of Qwindow_size_fixed,
10384 window_min_size_1, window_min_size_2, window_min_size,
10385 size_window, window_fixed_size_p, enlarge_window, delete_window.
10386 Remove static from declaration of Qdelete_window, it's
10387 temporarily needed by Fbury_buffer.
10388 (replace_window): Don't assign orig_top_line and
10389 orig_total_lines.
10390 (Fdelete_window, delete_window): Remove. Window deletion is
10391 handled by window.el.
640c8776
SM
10392 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10393 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10394 (Fdelete_other_windows): Remove. Deleting other windows is
10395 handled by window.el.
10396 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10397 handled in window.el.
10398 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10399 Window minimum sizes are handled in window.el.
10400 (shrink_windows, size_window, set_window_height)
10401 (set_window_width, change_window_heights, window_height)
10402 (window_width, CURBEG, CURSIZE, enlarge_window)
10403 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10404 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10405 handled in window.el.
10406 (make_dummy_parent): Rename to make_parent_window and give it a
10407 second argument horflag.
10408 (make_window): Don't set resize_proportionally any more.
10409 (Fsplit_window): Remove. Windows are split in window.el.
10410 (save_restore_action, save_restore_orig_size)
10411 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10412 Resize mini windows in window.el.
10413 (grow_mini_window, shrink_mini_window): Implement by calling
10414 Qresize_root_window_vertically, resize_window_check and
10415 resize_window_apply.
640c8776
SM
10416 (saved_window, Fset_window_configuration, save_window_save):
10417 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10418 resize_proportionally.
10419 (window_min_height, window_min_width): Move to window.el.
10420 (keys_of_window): Move bindings for delete-other-windows,
10421 split-window, delete-window and enlarge-window to window.el.
10422
10423 * buffer.c: Temporarily extern Qdelete_window.
10424 (Fbury_buffer): Temporarily call Qdelete_window instead of
10425 Fdelete_window (Fbury_buffer will move to window.el soon).
10426
10427 * frame.c (set_menu_bar_lines_1): Remove code handling
10428 orig_top_line and orig_total_lines.
10429
10430 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10431 set_window_height but set heights directly.
10432 (change_frame_size_1): Use resize_frame_windows.
10433
10434 * xdisp.c (init_xdisp): Don't use set_window_height but set
10435 heights directly.
10436
640c8776
SM
10437 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10438 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10439 run_window_configuration_change_hook.
10440
10441 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10442 instead of change_window_heights and run
10443 run_window_configuration_change_hook.
10444
1a13852e
MR
104452011-06-09 Martin Rudalics <rudalics@gmx.at>
10446
10447 * window.c (replace_window): Rename second argument REPLACEMENT to
10448 NEW. New third argument SETFLAG. Rewrite.
10449 (delete_window, make_dummy_parent): Call replace_window with
10450 third argument 1.
10451 (window_list_1): Move down in code.
10452 (run_window_configuration_change_hook): Move set_buffer part
10453 before select_frame_norecord part in order to unwind correctly.
10454 Rename count1 to count.
10455 (recombine_windows, delete_deletable_window, resize_root_window)
10456 (Fdelete_other_windows_internal)
10457 (Frun_window_configuration_change_hook, make_parent_window)
10458 (resize_window_check, resize_window_apply, Fresize_window_apply)
10459 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10460 (Fdelete_window_internal, Fresize_mini_window_internal):
10461 New functions.
1a13852e
MR
10462 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10463
f3d1777e
MR
104642011-06-08 Martin Rudalics <rudalics@gmx.at>
10465
496e208e
MR
10466 * window.h (window): Add some new members to window structure -
10467 normal_lines, normal_cols, new_total, new_normal, clone_number,
10468 splits, nest, prev_buffers, next_buffers.
10469 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10470 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10471
f3d1777e
MR
10472 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10473 Remove.
496e208e
MR
10474 (make_dummy_parent): Set new members of windows structure.
10475 (make_window): Move down in code. Handle new members of window
10476 structure.
10477 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10478 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10479 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10480 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10481 (Fset_window_next_buffers, Fset_window_clone_number):
10482 New functions.
496e208e
MR
10483 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10484 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10485 Doc-string fixes.
10486 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10487 Argument WINDOW can be now internal window too.
10488 (Fwindow_use_time): Move up in code.
10489 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10490 Rewrite doc-string.
10491 (Fset_window_configuration, saved_window)
10492 (Fcurrent_window_configuration, save_window_save): Handle new
10493 members of window structure.
b9e809c2
MR
10494 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10495 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10496 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10497 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10498 Qget_mru_window, Qresize_root_window,
10499 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10500 Qauto_buffer_name; staticpro them.
f3d1777e 10501
abde8f8c
MR
105022011-06-07 Martin Rudalics <rudalics@gmx.at>
10503
10504 * window.c (Fwindow_total_size, Fwindow_left_column)
10505 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10506 (Fwindow_list_1): New functions.
10507 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10508 (Fwindow_width, Fscroll_left, Fscroll_right):
10509 Use window_body_cols instead of window_box_text_cols.
10510 (delete_window, Fset_window_configuration):
10511 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10512 (delete_all_subwindows): Take a window as argument and not a
10513 structure. Rewrite.
190b47e6
MR
10514 (window_loop): Remove handling of GET_LRU_WINDOW and
10515 GET_LARGEST_WINDOW.
10516 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10517
10518 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10519 window_box_text_cols. delete_all_subwindows now takes a
10520 Lisp_Object as argument.
abde8f8c 10521
640c8776
SM
10522 * indent.c (compute_motion, Fcompute_motion):
10523 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10524
fa8a67e6
MR
10525 * frame.c (delete_frame): Call delete_all_subwindows with root
10526 window as argument.
10527
a54e3482
DC
105282011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10529
10530 * fns.c (Fputhash): Document return value.
10531
60002bf5
CY
105322011-06-06 Chong Yidong <cyd@stupidchicken.com>
10533
10534 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10535
0c671da6 105362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10537
b862a52a 10538 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10539
be44ca6c
PE
10540 Check for overflow when converting integer to cons and back.
10541 * charset.c (Fdefine_charset_internal, Fdecode_char):
10542 Use cons_to_unsigned to catch overflow.
10543 (Fencode_char): Use INTEGER_TO_CONS.
10544 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10545 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10546 * data.c (long_to_cons, cons_to_long): Remove.
10547 (cons_to_unsigned, cons_to_signed): New functions.
10548 These signal an error for invalid or out-of-range values.
10549 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10550 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10551 * font.c (Ffont_variation_glyphs):
10552 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10553 * lisp.h: Include <intprops.h>.
10554 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10555 (cons_to_signed, cons_to_unsigned): New decls.
10556 (long_to_cons, cons_to_long): Remove decls.
10557 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10558 (Fprimitive_undo): Use CONS_TO_INTEGER.
10559 * xfns.c (Fx_window_property): Likewise.
10560 * xselect.c: Include <limits.h>.
10561 (x_own_selection, selection_data_to_lisp_data):
10562 Use INTEGER_TO_CONS.
10563 (x_handle_selection_request, x_handle_selection_clear)
10564 (x_get_foreign_selection, Fx_disown_selection_internal)
10565 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10566 (lisp_data_to_selection_data): Use cons_to_unsigned.
10567 (x_fill_property_data): Use cons_to_signed.
10568 Report values out of range.
10569
d1f3d2af
PE
10570 Check for buffer and string overflow more precisely.
10571 * buffer.h (BUF_BYTES_MAX): New macro.
10572 * lisp.h (STRING_BYTES_MAX): New macro.
10573 * alloc.c (Fmake_string):
10574 * character.c (string_escape_byte8):
10575 * coding.c (coding_alloc_by_realloc):
10576 * doprnt.c (doprnt):
10577 * editfns.c (Fformat):
10578 * eval.c (verror):
10579 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10580 since they may not be the same number.
10581 * editfns.c (Finsert_char):
10582 * fileio.c (Finsert_file_contents):
10583 Likewise for BUF_BYTES_MAX.
10584
dd52fcea
PE
10585 * image.c: Use ptrdiff_t, not int, for sizes.
10586 (slurp_file): Switch from int to ptrdiff_t.
10587 All uses changed.
10588 (slurp_file): Check that file size fits in both size_t (for
10589 malloc) and ptrdiff_t (for sanity and safety).
10590
7f9bbdbb
PE
10591 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10592 if b->modtime has its maximal value.
10593
dfe18f82
PE
10594 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10595
84acfcf0
PE
10596 Don't assume time_t can fit into int.
10597 * buffer.h (struct buffer.modtime): Now time_t, not int.
10598 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10599 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10600
ccd9a01a
PE
10601 Minor fixes for signed vs unsigned integers.
10602 * character.h (MAYBE_UNIFY_CHAR):
10603 * charset.c (maybe_unify_char):
10604 * keyboard.c (read_char, reorder_modifiers):
10605 XINT -> XFASTINT, since the integer must be nonnegative.
10606 * ftfont.c (ftfont_spec_pattern):
10607 * keymap.c (access_keymap, silly_event_symbol_error):
10608 XUINT -> XFASTINT, since the integer must be nonnegative.
10609 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10610 since it makes no difference and we prefer signed.
10611 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10612 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10613 nonnegative.
10614
d6d100dd
SM
106152011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10616
10617 * window.h (Fwindow_frame): Declare.
10618
2b6148e4
PE
106192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10620
10621 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10622 (SPARE_MEMORY): Always define.
10623 (LARGE_REQUEST): Remove.
10624 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10625
f230ecc9
MR
106262011-06-06 Martin Rudalics <rudalics@gmx.at>
10627
727e958e
MR
10628 * lisp.h: Move EXFUNS for Fframe_root_window,
10629 Fframe_first_window and Fset_frame_selected_window to window.h.
10630
10631 * window.h: Move EXFUNS for Fframe_root_window,
10632 Fframe_first_window and Fset_frame_selected_window here from
10633 lisp.h.
10634
10635 * frame.c (Fwindow_frame, Fframe_first_window)
10636 (Fframe_root_window, Fframe_selected_window)
10637 (Fset_frame_selected_window): Move to window.c.
10638 (Factive_minibuffer_window): Move to minibuf.c.
10639 (Fother_visible_frames_p): New function.
10640
10641 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10642
f230ecc9
MR
10643 * window.c (decode_window, decode_any_window): Move up in code.
10644 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10645 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10646 (Fwindow_buffer): Move up and rewrite doc-string.
10647 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10648 (Fwindow_prev): New functions.
727e958e
MR
10649 (Fwindow_frame): Move here from frame.c. Accept any window as
10650 argument.
10651 (Fframe_root_window, Fframe_first_window)
10652 (Fframe_selected_window): Move here from frame.c. Accept frame
10653 or arbitrary window as argument. Update doc-strings.
10654 (Fminibuffer_window): Move up in code.
10655 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10656 (Fset_frame_selected_window): Move here from frame.c.
10657 Marginal rewrite.
727e958e
MR
10658 (Fselected_window, select_window, Fselect_window): Move up in
10659 code. Minor doc-string fixes.
f230ecc9 10660
4d09bcf6
PE
106612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10662
10663 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10664 Do not assume that spare memory exists; that assumption is valid
10665 only if SYSTEM_MALLOC.
10666 (LARGE_REQUEST): New macro, so that the issue of large requests
10667 is separated from the issue of spare memory.
10668
810928a2
AS
106692011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10670
172418ad
AS
10671 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10672 format. (Bug#8806)
10673
43f862f7
AS
10674 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10675
810928a2
AS
10676 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10677 before statements.
10678
a059fe24
JD
106792011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10680
10681 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10682
10683 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10684
10685 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10686 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10687
989bf368
JB
106882011-06-05 Juanma Barranquero <lekktu@gmail.com>
10689
10690 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10691
4b80f674
CY
106922011-06-04 Chong Yidong <cyd@stupidchicken.com>
10693
10694 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10695 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10696 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10697 New error handlers.
4b80f674
CY
10698 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10699 Obey Vx_select_enable_clipboard_manager. Catch errors in
10700 x_clipboard_manager_save (Bug#8779).
10701 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10702 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10703
99a33b77 107042011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10705
10706 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10707
99a33b77 107082011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10709
10710 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10711 in the current matrix if keep_current_p is non-zero.
10712
8264569d
EZ
107132011-06-04 Eli Zaretskii <eliz@gnu.org>
10714
10715 * bidi.c (bidi_level_of_next_char): Fix last change.
10716
57f97249
EZ
107172011-06-03 Eli Zaretskii <eliz@gnu.org>
10718
fec2107c 10719 Support bidi reordering of text covered by display properties.
57f97249 10720
fec2107c
EZ
10721 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10722 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10723 (bidi_cache_search, bidi_cache_iterator_state)
10724 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10725 (bidi_level_of_next_char, bidi_move_to_visually_next):
10726 Support character positions inside a run of characters covered by a
fec2107c
EZ
10727 display string.
10728 (bidi_paragraph_init, bidi_resolve_explicit_1)
10729 (bidi_level_of_next_char): Call bidi_fetch_char and
10730 bidi_fetch_char_advance instead of FETCH_CHAR and
10731 FETCH_CHAR_ADVANCE.
10732 (bidi_init_it): Initialize new members.
10733 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10734 definitions.
10735 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10736 instead of using explicit *_CHAR codes.
d6d100dd
SM
10737 (bidi_resolve_explicit, bidi_resolve_weak):
10738 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10739 bidirectional text is supported only in multibyte buffers.
10740 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10741 it to initialize the frame_window_p member of struct bidi_it.
10742 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10743 (bidi_resolve_explicit, bidi_resolve_weak)
10744 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10745 bidi_it->nchars is non-positive.
10746 (bidi_level_of_next_char): Don't try to lookup the cache for the
10747 next/previous character if nothing is cached there yet, or if we
10748 were just reseat()'ed to a new position.
c40e2fb2 10749
0e14fe90
EZ
10750 * xdisp.c (set_cursor_from_row): Set start and stop points
10751 according to the row's direction when priming the loop that looks
10752 for the glyph on which to display cursor.
10753 (single_display_spec_intangible_p): Function deleted.
10754 (display_prop_intangible_p): Reimplement to call
10755 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10756 Accept 3 additional arguments needed by handle_display_spec.
10757 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10758 values: lists, `(when COND...)' forms, etc.
10759 (single_display_spec_string_p): Support property values that are
10760 lists with the argument STRING its top-level element.
10761 (display_prop_string_p): Fix the condition for processing a
10762 property that is a list to be consistent with handle_display_spec.
fec2107c 10763 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10764 last portion of handle_display_prop.
10765 (compute_display_string_pos): Accept additional argument
10766 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10767 value of a `display' property is a "replacing spec".
10768 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10769 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10770 the display property, but just return a value indicating whether
10771 the display property will replace the characters it covers.
10772 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10773 frame_window_p members of struct bidi_it.
d6d100dd
SM
10774 (compute_display_string_pos, compute_display_string_end):
10775 New functions.
fec2107c
EZ
10776 (push_it): Accept second argument POSITION, where pop_it should
10777 jump to continue iteration.
10778 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10779
fec2107c
EZ
10780 * keyboard.c (adjust_point_for_property): Adjust the call to
10781 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10782
10783 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10784 (bidi_init_it): Update prototypes.
10785 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10786 (compute_display_string_pos, compute_display_string_end):
10787 Declare prototypes.
fec2107c
EZ
10788 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10789 EMACS_INT.
fc6f18ce 10790
40087514 107912011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10792
57f53182
PE
10793 Malloc failure behavior now depends on size of allocation.
10794 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10795 * lisp.h: Change signatures accordingly.
10796 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10797 All callers changed. (Bug#8762)
10798
10799 * gnutls.c: Use Emacs's memory allocators.
10800 Without this change, the gnutls library would invoke malloc etc.
10801 directly, which causes problems on non-SYNC_INPUT hosts, and which
10802 runs afoul of improving memory_full behavior. (Bug#8761)
10803 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10804 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10805 xfree instead of the default malloc, realloc, free.
10806 (Fgnutls_boot): No need to check for memory allocation failure,
10807 since xmalloc does that for us.
10808
ac32cd99 10809 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10810 * category.c (hash_get_category_set):
10811 * ccl.c (ccl_driver):
10812 * charset.c (Fdefine_charset_internal):
10813 * charset.h (struct charset.hash_index):
10814 * composite.c (get_composition_id, gstring_lookup_cache)
10815 (composition_gstring_put_cache):
10816 * composite.h (struct composition.hash_index):
10817 * dispextern.h (struct image.hash):
10818 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10819 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10820 (hashfn_equal, hashfn_user_defined, make_hash_table)
10821 (maybe_resize_hash_table, hash_lookup, hash_put)
10822 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10823 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10824 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10825 * image.c (make_image, search_image_cache, lookup_image)
10826 (xpm_put_color_table_h):
10827 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10828 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10829 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10830 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10831 * alloc.c (allocate_vectorlike):
10832 Check for overflow in vector size calculations.
10833 * ccl.c (ccl_driver):
10834 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10835 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10836 need to be updated by these changes.
40087514
PE
10837 * fns.c (make_hash_table, maybe_resize_hash_table):
10838 Check for integer overflow with large hash tables.
0de4bb68
PE
10839 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10840 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10841 (SXHASH_REDUCE): New macro.
10842 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10843 Use it instead of discarding useful hash info with large hash values.
10844 (sxhash_float): New function.
10845 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10846 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10847 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10848 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10849 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10850 Adjust signatures to match updated version of code.
10851 (consing_since_gc): Now EMACS_INT, since a single hash table can
10852 use more than INT_MAX bytes.
10853
698d32e2
DN
108542011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10855
10856 Make it possible to build with GCC-4.6+ -O2 -flto.
10857
10858 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10859
fd6fa53f
SM
108602011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10861
10862 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10863 Call minibuffer-inactive-mode.
10864
864db017
JB
108652011-05-31 Juanma Barranquero <lekktu@gmail.com>
10866
10867 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10868 Update dependencies.
10869
2ad0baf4
DN
108702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10871
10872 * data.c (init_data): Remove code for UTS, this system is not
10873 supported anymore.
10874
4fcc2638
DN
108752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10876
10877 Don't force ./temacs to start in terminal mode.
10878
10879 * frame.c (make_initial_frame): Initialize faces in all cases, not
10880 only when CANNOT_DUMP is defined.
10881 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10882
c56e0fd5
DN
108832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10884
10885 * dispnew.c (add_window_display_history): Use const for the string
10886 pointer. Remove declaration, not needed.
10887
333d54da 108882011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10889
55d4c1b2 10890 Use 'inline', not 'INLINE'.
333d54da 10891 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10892 * alloc.c, fontset.c (INLINE): Remove.
10893 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10894 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10895 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10896 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10897 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10898
738db178
DN
108992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10900
10901 Make it possible to run ./temacs.
10902
10903 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10904 syms_of_callproc does the same thing. Remove test for
10905 "initialized", do it in the caller.
10906 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10907
620c53a6
SM
109082011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10909
10910 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10911 (read_minibuf): Use get_minibuffer.
10912 (syms_of_minibuf): Use DEFSYM.
10913 (Qmetadata): New var.
10914 * data.c (Qbuffer): Don't make it static.
10915 (syms_of_data): Use DEFSYM.
10916
e003a292
PE
109172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10918
10919 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10920 (CCL_CODE_MIN): New macro.
10921
ed008a6d
PE
109222011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10923
3687c2ef
PE
10924 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10925
ed008a6d
PE
10926 * eval.c (Qdebug): Now static.
10927 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10928 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10929 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10930
d66c4c7c
CY
109312011-05-29 Chong Yidong <cyd@stupidchicken.com>
10932
10933 * image.c: Various fixes to ImageMagick code comments.
10934 (Fimagemagick_types): Doc fix.
10935
5fbc2025
PE
109362011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10937
0196f88a
PE
10938 Minor fixes prompted by GCC 4.6.0 warnings.
10939
10940 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10941
5fbc2025
PE
10942 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10943 (x_clipboard_manager_save_all): Move extern decl to ...
10944 * xterm.h: ... here, so that it can be checked for consistency.
10945
1dd3c2d9
CY
109462011-05-29 Chong Yidong <cyd@stupidchicken.com>
10947
10948 * xselect.c (x_clipboard_manager_save_frame)
10949 (x_clipboard_manager_save_all): New functions.
10950 (Fx_clipboard_manager_save): Lisp function deleted.
10951
10952 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10953 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10954
10955 * xterm.h: Update prototype.
10956
5ba6571d
WX
109572011-05-28 William Xu <william.xwl@gmail.com>
10958
10959 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10960 exiting (Bug#8239).
10961
3eaff834
JM
109622011-05-28 Jim Meyering <meyering@redhat.com>
10963
e1900994 10964 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10965 * fns.c (to_uchar): Define.
10966 (crypto_hash_function): Use it to convert some newly-signed
10967 variables to unsigned, to avoid sign-extension bugs. For example,
10968 without this change, (md5 "truc") would evaluate to
10969 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10970 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10971 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10972
0f6990a7
PE
109732011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10974
10975 Integer overflow fixes.
c8a9ca5a 10976
08686060
PE
10977 * dbusbind.c: Serial number integer overflow fixes.
10978 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10979 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10980 to hold a serial number that is too large for a fixnum.
10981 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10982 Check for serial numbers out of range. Decode any serial number
59568bf0 10983 that was so large that it became a float. (Bug#8722)
08686060 10984
2d1fc3c7
PE
10985 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10986 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10987 Use XFASTINT rather than XUINT when numbers are nonnegative.
10988 (xd_append_arg, Fdbus_method_return_internal):
10989 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10990 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10991 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10992 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10993 (Bug#8722)
2d1fc3c7 10994
c8a9ca5a
PE
10995 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10996
519e1d69
PE
10997 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10998
6df6ae42 10999 ccl: Add integer overflow checks.
30569699
PE
11000 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11001 (IN_INT_RANGE): New macros.
11002 (ccl_driver): Use them to check for integer overflow when
11003 decoding a CCL program. Many of the new checks are whether XINT (x)
11004 fits in int; it doesn't always, on 64-bit hosts. The new version
11005 doesn't catch all possible integer overflows, but it's an
847044ea 11006 improvement. (Bug#8719)
30569699 11007
c11285dc
PE
11008 * alloc.c (make_event_array): Use XINT, not XUINT.
11009 There's no need for unsigned here.
11010
fdccd48e
PE
11011 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11012 This follows up to the 2011-05-06 change that substituted uintptr_t
11013 for EMACS_INT. This case wasn't caught back then.
11014
37910ab2
PE
11015 Rework Fformat to avoid integer overflow issues.
11016 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11017 now (part of C89). Include <verify.h>.
11018 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11019 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11020 (Fformat): Avoid the prepass trying to compute sizes; it was only
11021 approximate and thus did not catch overflow reliably. Instead, walk
11022 through the format just once, formatting and computing sizes as we go,
11023 checking for integer overflow at every step, and allocating a larger
11024 buffer as needed. Keep track separately whether the format is
11025 multibyte. Keep only the most-recently calculated precision, rather
11026 than them all. Record whether each argument has been converted to
11027 string. Use EMACS_INT, not int, for byte and char and arg counts.
11028 Support field widths and precisions larger than INT_MAX. Avoid
11029 sprintf's undefined behavior with conversion specifications such as %#d
11030 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11031 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11032 formatting out-of-range floating point numbers with int
9173deec 11033 formats. (Bug#8668)
37910ab2 11034
2e6578fb
PE
11035 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11036
0ae6bdee
PE
11037 * data.c: Avoid integer truncation in expressions involving floats.
11038 * data.c: Include <intprops.h>.
11039 (arith_driver): When there's an integer overflow in an expression
11040 involving floating point, convert the integers to floating point
11041 so that the resulting value does not suffer from catastrophic
11042 integer truncation. For example, on a 64-bit host (* 4
11043 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11044 Do not rely on undefined behavior after integer overflow.
11045
de883a70
PE
11046 merge count_size_as_multibyte, parse_str_to_multibyte
11047 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11048 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11049 Check for integer overflow.
11050 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11051 since it's now a duplicate of the other. This is more of
11052 a character than a buffer op, so better that it's in character.c.
11053 * fns.c, print.c: Adjust to above changes.
11054
2ff916cb
PE
110552011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11056
11057 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11058
f1b54466
PE
110592011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11060
fb1ac845
PE
11061 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11062 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11063 (x_clipboard_manager_save): Now static.
11064 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11065
f1b54466
PE
11066 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11067 (crypto_hash_function): Now static.
11068 Fix pointer signedness problems. Avoid unnecessary initializations.
11069
a9f737ee
CY
110702011-05-27 Chong Yidong <cyd@stupidchicken.com>
11071
11072 * termhooks.h (Vselection_alist): Make it terminal-local.
11073
11074 * terminal.c (create_terminal): Initialize it.
11075
11076 * xselect.c: Support for clipboard managers.
11077 (Vselection_alist): Move to termhooks.h as terminal-local var.
11078 (LOCAL_SELECTION): New macro.
11079 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11080 (symbol_to_x_atom): Remove gratuitous arg.
11081 (x_handle_selection_request, lisp_data_to_selection_data)
11082 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11083 (x_own_selection, x_get_local_selection, x_convert_selection):
11084 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11085 (some_frame_on_display): Delete unused function.
11086 (Fx_own_selection_internal, Fx_get_selection_internal)
11087 (Fx_disown_selection_internal, Fx_selection_owner_p)
11088 (Fx_selection_exists_p): New optional frame arg.
11089 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11090 (x_handle_selection_clear): Don't treat other terminals with the
11091 same keyboard specially. Use the terminal-local Vselection_alist.
11092 (x_clear_frame_selections): Use Frun_hook_with_args.
11093
11094 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11095
11096 * xterm.h: Add support for those atoms.
11097
e067f0c1
CY
110982011-05-26 Chong Yidong <cyd@stupidchicken.com>
11099
11100 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11101 (converted_selections, conversion_fail_tag): New global variables.
11102 (x_selection_request_lisp_error): Free the above.
11103 (x_get_local_selection): Remove unnecessary code.
11104 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11105 of converted selections stored in converted_selections.
11106 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11107 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11108 (x_convert_selection): New function.
11109 (x_handle_selection_event): Simplify.
11110 (x_get_foreign_selection): Don't ignore incoming requests while
11111 waiting for an answer; this will fail when we implement
11112 SAVE_TARGETS, and seems unnecessary anyway.
11113 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11114 (Vx_sent_selection_functions): Doc fix.
11115
0f4aebc0
LL
111162011-05-26 Leo Liu <sdl.web@gmail.com>
11117
11118 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11119
e61124cd
YM
111202011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11121
11122 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11123
11124 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11125 for fringe update if it has periodic bitmap.
ac389d0c 11126 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11127 and fringe_bitmap_periodic_p.
11128
11129 * fringe.c (get_fringe_bitmap_data): New function.
11130 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11131 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11132 row. Mark glyph row for fringe update if periodicity changed.
11133
11134 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11135 for fringe update unless it has periodic bitmap.
11136
f16d9837
KH
111372011-05-25 Kenichi Handa <handa@m17n.org>
11138
11139 * xdisp.c (get_next_display_element): Set correct it->face_id for
11140 a static composition.
11141
e1b90ef6
LL
111422011-05-24 Leo Liu <sdl.web@gmail.com>
11143
11144 * deps.mk (fns.o):
11145 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11146
11147 * fns.c (crypto_hash_function, Fsha1): New function.
11148 (Fmd5): Use crypto_hash_function.
11149 (syms_of_fns): Add Ssha1.
11150
7400048f
PE
111512011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11152
11153 * gnutls.c: Remove unused macros.
11154 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11155 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11156 Remove macros that are defined and never used.
11157 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11158
abb71cf4
CY
111592011-05-22 Chong Yidong <cyd@stupidchicken.com>
11160
11161 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11162 (Fx_get_selection_internal): Minor cleanup.
11163 (Fx_own_selection_internal): Rename arguments for consistency with
11164 select.el.
11165
6307db39
PE
111662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11167
11168 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11169
f3d4e0a4
CY
111702011-05-22 Chong Yidong <cyd@stupidchicken.com>
11171
11172 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11173
4d8ade89
YM
111742011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11175
11176 * dispnew.c (scrolling_window): Don't exclude the case that the
11177 last enabled row in the desired matrix touches the bottom boundary.
11178
32078c8d
GM
111792011-05-21 Glenn Morris <rgm@gnu.org>
11180
11181 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11182 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11183 and add some more files.
32078c8d 11184
7285dc67
EZ
111852011-05-20 Eli Zaretskii <eliz@gnu.org>
11186
11187 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11188 report_file_error introduced by the change from 2011-05-07.
11189
89d1bd22
PE
111902011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11191
11192 * systime.h (Time): Define only if emacs is defined.
11193 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11194 where the include path doesn't have X11/X.h by default. See
11195 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11196
cd394be1 111972011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11198
11199 * composite.c (find_automatic_composition): Fix previous change.
11200
b9704ad9
GM
112012011-05-20 Glenn Morris <rgm@gnu.org>
11202
11203 * lisp.mk: New file, split from Makefile.in.
11204 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11205 (shortlisp): Remove.
11206 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11207
4a720484
GM
112082011-05-19 Glenn Morris <rgm@gnu.org>
11209
11210 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11211 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11212 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11213 (lisp): Set the order to that of loadup.el.
11214 (shortlisp): Make it a copy of $lisp.
11215 (SOME_MACHINE_LISP): Remove.
11216 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11217 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11218
a28d4396
KH
112192011-05-18 Kenichi Handa <handa@m17n.org>
11220
11221 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11222 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11223 (find_automatic_composition): Mostly rewrite for efficiency.
11224
a2b1fa8e
JB
112252011-05-18 Juanma Barranquero <lekktu@gmail.com>
11226
11227 * makefile.w32-in: Update dependencies.
11228
8e1f5610
CS
112292011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11230
11231 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11232 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11233
7025ee00 112342011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11235
cdfa6eab
PE
11236 Fix some integer overflow issues, such as string length overflow.
11237
06d6db33
PE
11238 * insdel.c (count_size_as_multibyte): Check for string overflow.
11239
2b4560a8
PE
11240 * character.c (lisp_string_width): Check for string overflow.
11241 Use EMACS_INT, not int, for string indexes and lengths; in
11242 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11243 the resulting string length overflows an EMACS_INT; instead,
11244 report a string overflow if no precision given. When checking for
11245 precision exhaustion, use a check that cannot possibly have
11246 integer overflow. (Bug#8675)
11247 * character.h (lisp_string_width): Adjust to new signature.
11248
cb93f9be
PE
11249 * alloc.c (string_overflow): New function.
11250 (Fmake_string): Use it. This doesn't change behavior, but saves
11251 a few bytes and will simplify future changes.
11252 * character.c (string_escape_byte8): Likewise.
11253 * lisp.h (string_overflow): New decl.
11254
1a1f3366
PE
11255 Fixups, following up to the user-interface timestamp change.
11256 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11257 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11258 * msdos.c (mouse_get_pos): Likewise.
11259 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11260 * w32gui.h (Time): Define by including "systime.h" rather than by
11261 declaring it ourselves. (Bug#8664)
11262
d4e3e4d3
PE
11263 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11264 * image.c (clear_image_cache): Likewise.
11265
f6a24d19
PE
11266 * term.c (term_mouse_position): Don't assume time_t wraparound.
11267
08dc5ae6
PE
11268 Be more systematic about user-interface timestamps.
11269 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11270 and sometimes 'EMACS_UINT', to represent these timestamps.
11271 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11272 This makes the code easier to follow, and makes it easier to catch
11273 integer overflow bugs such as Bug#8664.
11274 * frame.c (Fmouse_position, Fmouse_pixel_position):
11275 Use Time, not unsigned long, for user-interface timestamps.
11276 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11277 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11278 * keyboard.h (last_event_timestamp): Likewise.
11279 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11280 * menu.h (xmenu_show): Likewise.
11281 * term.c (term_mouse_position): Likewise.
11282 * termhooks.h (struct input_event.timestamp): Likewise.
11283 (struct terminal.mouse_position_hook): Likewise.
11284 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11285 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11286 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11287 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11288 what it was before.
11289 * menu.h, termhooks.h: Include "systime.h", for Time.
11290
8e55734a
PE
11291 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11292 Don't assume that the difference between two unsigned long values
11293 can fit into an integer. At this point, we know button_down_time
11294 <= event->timestamp, so the difference must be nonnegative, so
11295 there's no need to cast the result if double-click-time is
11296 nonnegative, as it should be; check that it's nonnegative, just in
11297 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11298 apart (about 25 days). (Bug#8664)
8e55734a 11299
841f1b75 11300 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11301 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11302
3e26f69c
PE
11303 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11304 that always fit in int. Use a sentinel instead of a counter, to
11305 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11306 * frame.h (struct frame): Use int for menu_bar_items_used
11307 instead of EMACS_INT, since it always fits in int.
3e26f69c 11308
5cc152c0
PE
11309 * menu.c (grow_menu_items): Check for int overflow.
11310
d89eb65e
PE
11311 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11312
5235bd3e
PE
11313 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11314 Before, the code was not consistent. These values cannot exceed
11315 2**31 - 1 so there's no need to make them unsigned.
11316 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11317 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11318 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11319 as modifiers.
11320 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11321
bc827e23
PE
11322 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11323 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11324 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11325 presumably because the widths might not match.
11326
78eb494e
PE
11327 * window.c (size_window): Avoid needless test at loop start.
11328
04f2d78b
CB
113292011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11330
11331 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11332
d2fc7e3d 113332011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11334
11335 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11336
d2fc7e3d 113372011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11338
11339 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11340 `width' to `bar_area_x' and `bar_area_width', respectively.
11341 (x_scroll_run): Take account of fringe background extension.
11342
04f2d78b
CB
11343 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11344 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11345 `bar_area_width', respectively.
11346 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11347 background extension.
11348
79b70037
GM
113492011-05-10 Jim Meyering <meyering@redhat.com>
11350
11351 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11352
2f142cc5
JB
113532011-05-10 Juanma Barranquero <lekktu@gmail.com>
11354
11355 * image.c (Finit_image_library): Return t for built-in image types,
11356 like pbm and xbm. (Bug#8640)
11357
57679c86
AS
113582011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11359
11360 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11361
888c9e86
EZ
113622011-05-07 Eli Zaretskii <eliz@gnu.org>
11363
b0512a1d
EZ
11364 * w32console.c (Fset_screen_color): Doc fix.
11365 (Fget_screen_color): New function.
11366 (syms_of_ntterm): Defsubr it.
11367
7285dc67
EZ
11368 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11369 unlink the temporary file if Fcall_process didn't create it in the
11370 first place.
11371 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11372 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11373 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11374 cue to call_process_cleanup not to close that handle.
11375
4d3fcc8e
BK
113762011-05-07 Ben Key <bkey76@gmail.com>
11377
11378 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11379 one of two shell specific rules, either bootstrap-temacs-CMD or
11380 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11381 to the previous implementation of the bootstrap-temacs rule.
11382 The bootstrap-temacs-CMD rule is similar to the previous
11383 implementation of the bootstrap-temacs rule except that it
11384 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11385 variable.
11386
11387 These changes, along with some changes to nt/configure.bat,
11388 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11389 earlier fix to add support for --cflags and --ldflags options
11390 that include quotes so that it works whether make uses cmd or
11391 sh as the shell.
11392
b4289b64
MA
113932011-05-06 Michael Albinus <michael.albinus@gmx.de>
11394
11395 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11396 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11397 is a constant.
11398 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11399 a string. Handle both cases.
11400 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11401 (Fdbus_register_method): Use Qinvalid_function.
11402
af4c0e28
JB
114032011-05-06 Juanma Barranquero <lekktu@gmail.com>
11404
11405 * makefile.w32-in: Update dependencies.
11406 (LISP_H): Add inttypes.h and stdin.h.
11407 (PROCESS_H): Add unistd.h.
11408
c51453d9
EZ
114092011-05-06 Eli Zaretskii <eliz@gnu.org>
11410
11411 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11412 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11413
8ff0ac3c 114142011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11415
4c4b566b
PE
11416 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11417
aab2b9b5
PE
11418 * term.c (vfatal): Remove stray call to va_end.
11419 It's not needed and the C Standard doesn't allow it here anyway.
11420
c378da0b
PE
11421 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11422 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11423
288b08c7
PE
11424 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11425 bytes.
11426
e3601888
PE
11427 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11428
db6c0e74
PE
11429 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11430
dd5963ea
PE
11431 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11432
88c9450f
PE
11433 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11434
2f9442b8
PE
11435 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11436
c032b5f8
PE
11437 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11438 * charset.c (Fdefine_charset_internal): Don't initialize
11439 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11440 32-bit int (Bug#8600).
a108c10b
PE
11441
11442 * lread.c (read_integer): Be more consistent with string-to-number.
11443 Use string_to_number to do the actual conversion; this avoids
11444 rounding errors and fixes some other screwups. Without this fix,
11445 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11446 (digit_to_number): Move earlier, for benefit of read_integer.
11447 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11448 not a digit in any supported base. (Bug#8602)
a108c10b 11449
ad5f9eea
PE
11450 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11451
aec1708a
PE
11452 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11453 to match comment at start of function. This also removes a
11454 GCC warning about overflow in a 32+64-bit port.
11455
47be4ab5
PE
11456 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11457
371cac43
PE
11458 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11459 Reported by Stefan Monnier in
11460 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11461 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11462 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11463
d01a7826
PE
11464 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11465 (EMACS_UINTPTR): Likewise, with uintptr_t.
11466
7fd47d5c
PE
11467 * lisp.h: Prefer 64-bit EMACS_INT if available.
11468 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11469 on 32-bit hosts that have 64-bit int, so that they can access
11470 large files.
122b0c86
PE
11471 However, temporarily disable this change unless the temporary
11472 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11473
8727937b
PE
11474 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11475
8ac068ac
PE
11476 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11477 This removes an assumption that EMACS_INT and long are the same
11478 width as pointers. The assumption is true for Emacs porting targets
11479 now, but we want to make other targets possible.
11480 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11481 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11482 In the rest of the code, change types of integers that hold casted
11483 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11484 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11485 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11486 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11487 No need to cast type when ORing.
11488 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11489 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11490 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11491 assume EMACS_INT is the same width as char *.
11492 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11493 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11494 Remove no-longer-needed casts.
11495 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11496 (xg_tool_bar_help_callback, xg_make_tool_item):
11497 Use EMACS_INTPTR to hold an integer
11498 that will be cast to void *; this can avoid a GCC warning
11499 if EMACS_INT is not the same width as void *.
11500 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11501 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11502 (current_message_1, set_message_1):
11503 Use a local to convert to proper width without a cast.
11504 * xmenu.c (dialog_selection_callback): Likewise.
11505
ede49d71
PE
11506 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11507 Also, don't assume VALBITS / RAND_BITS is less than 5,
11508 and don't rely on undefined behavior when shifting a 1 left into
11509 the sign bit.
11510 * lisp.h (get_random): Change signature to match.
11511
2f30ecd0
PE
11512 * lread.c (hash_string): Use size_t, not int, for hash computation.
11513 Normally we prefer signed values; but hashing is special, because
11514 it's better to use unsigned division on hash table sizes so that
11515 the remainder is nonnegative. Also, size_t is the natural width
11516 for hashing into memory. The previous code used 'int', which doesn't
11517 retain enough info to hash well into very large tables.
11518 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11519
2a866e7b
PE
11520 * dbusbind.c: Don't possibly lose pointer info when converting.
11521 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11522 Use XPNTR rather than XHASH, so that the high-order bits of
11523 the pointer aren't lost when converting through void *.
11524
51639eac
PE
11525 * eval.c (Fautoload): Don't double-shift a pointer.
11526
92394119
PE
11527 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11528
dbdb9a7c
JB
115292011-05-06 Juanma Barranquero <lekktu@gmail.com>
11530
11531 * gnutls.c (DEF_GNUTLS_FN):
11532 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11533
db7a0b4f
AS
115342011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11535
11536 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11537 marker. (Bug#8610)
11538
cd394be1 115392011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11540
11541 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11542 New version that can reserve upto 2GB of heap space.
11543
f7ff1b0f 115442011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11545
11546 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11547
639c109b
TZ
115482011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11549
11550 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11551 `gnutls_certificate_set_x509_key_file'.
11552
d2127135
JB
115532011-05-05 Juanma Barranquero <lekktu@gmail.com>
11554
11555 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11556 Update dependencies.
11557
e968f4f3
JB
115582011-05-04 Juanma Barranquero <lekktu@gmail.com>
11559
11560 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11561 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11562 Remove unused parameter `fildes'.
11563 * process.c (read_process_output, send_process): Don't pass it.
11564
84d358f0
JB
115652011-05-04 Juanma Barranquero <lekktu@gmail.com>
11566
11567 Fix previous change: the library cache is defined in w32.c.
11568 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11569 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11570
0898ca10
JB
115712011-05-04 Juanma Barranquero <lekktu@gmail.com>
11572
11573 Implement dynamic loading of GnuTLS on Windows.
11574
11575 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11576 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11577 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11578 Declare.
11579
11580 * gnutls.c (Qgnutls_dll): Define.
11581 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11582 (gnutls_*): Declare function pointers.
11583 (init_gnutls_functions): New function to initialize function pointers.
11584 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11585 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11586 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11587 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11588 (emacs_gnutls_write, emacs_gnutls_read)
11589 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11590 (Fgnutls_available_p): New function.
11591 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11592 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11593 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11594
11595 * image.c: Include w32.h.
11596 (Vimage_type_cache): Delete.
11597 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11598 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11599 (w32_delayed_load): Move to w32.c.
11600
11601 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11602
11603 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11604 (w32_delayed_load): Move from image.c. When loading a library, record
11605 its filename in the :loaded-from property of the library id.
11606 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11607 Initialize and staticpro them.
11608 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11609
11610 * process.c: Include lisp.h before w32.h, not after.
11611 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11612 instead of gnutls_record_check_pending.
11613
11614 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11615
ff4de4aa
TZ
116162011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11617
11618 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11619 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11620 as passed in.
11621
abe95abb
JD
116222011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11623
11624 * xterm.c (x_set_frame_alpha): Do not set property on anything
11625 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11626
e16e55d4
JB
116272011-05-02 Juanma Barranquero <lekktu@gmail.com>
11628
11629 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11630
bafcf6a5
JB
116312011-05-02 Juanma Barranquero <lekktu@gmail.com>
11632
11633 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11634 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11635 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11636 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11637 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11638 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11639 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11640 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11641 (Qgnutls_bootprop_callbacks_verify): Make static.
11642
e7a6747f
AS
116432011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11644
19ed11ba
AS
11645 * callproc.c: Indentation fixup.
11646
e7a6747f 11647 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11648 (wait_for_termination, interruptible_wait_for_termination):
11649 Move after wait_for_termination_1.
e7a6747f 11650
1ef14cb4
LMI
116512011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11652
11653 * sysdep.c (interruptible_wait_for_termination): New function
11654 which is like wait_for_termination, but allows keyboard
11655 interruptions.
11656
11657 * callproc.c (Fcall_process): Add (:file "file") as an option for
11658 the STDOUT buffer.
11659 (Fcall_process_region): Ditto.
11660
330d880c
EZ
116612011-04-30 Eli Zaretskii <eliz@gnu.org>
11662
8db90b73
EZ
11663 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11664 rather than `XVECTOR (FOO)->size'.
11665
330d880c
EZ
11666 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11667 inttypes.h, as a gnulib replacement is used if it not available in
11668 system headers.
11669
15cbd324
EZ
116702011-04-21 Eli Zaretskii <eliz@gnu.org>
11671
11672 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11673 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11674 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11675
11676 * coding.c (coding_alloc_by_realloc): Error out if destination
11677 will grow beyond MOST_POSITIVE_FIXNUM.
11678 (decode_coding_emacs_mule): Abort if there isn't enough place in
11679 charbuf for the composition carryover bytes. Reserve an extra
11680 space for up to 2 characters produced in a loop.
11681 (decode_coding_iso_2022): Abort if there isn't enough place in
11682 charbuf for the composition carryover bytes.
11683
116842011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11685
ae940cca
EZ
11686 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11687 aborting when %lld or %lll format is passed.
11688 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11689 %llo or %llx format is passed. (Bug#8545)
11690
03ab8921
EZ
11691 * window.c (window_scroll_line_based): Use a marker instead of
11692 simple variables to record original value of point. (Bug#7952)
11693
afda1437
EZ
11694 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11695 produced by %s or %c overflows available buffer space. (Bug#8545)
11696
f76dee0c
PE
116972011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11698
11699 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11700 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11701
fdc5744d
JB
117022011-04-28 Juanma Barranquero <lekktu@gmail.com>
11703
11704 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11705
638f053a
JB
117062011-04-28 Juanma Barranquero <lekktu@gmail.com>
11707
11708 * keyboard.c (Qdelayed_warnings_hook): Define.
11709 (command_loop_1): Run `delayed-warnings-hook'
11710 if Vdelayed_warnings_list is non-nil.
11711 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11712 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11713
d178f871
EZ
117142011-04-28 Eli Zaretskii <eliz@gnu.org>
11715
11716 * doprnt.c (doprnt): Don't return value smaller than the buffer
11717 size if the message was truncated. (Bug#8545).
11718
b124fd93
JB
117192011-04-28 Juanma Barranquero <lekktu@gmail.com>
11720
11721 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11722 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11723
e810457d
PE
117242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11725
11726 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11727
ea51cceb
JB
117282011-04-27 Juanma Barranquero <lekktu@gmail.com>
11729
11730 * makefile.w32-in: Update dependencies.
11731
94dcfacf
EZ
117322011-04-27 Eli Zaretskii <eliz@gnu.org>
11733
11734 Improve `doprnt' and its usage. (Bug#8545)
11735 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11736 `format_end'. Remove support for %l as a conversion specifier.
11737 Don't use xrealloc. Improve diagnostics when the %l size modifier
11738 is used. Update the commentary.
11739
11740 * eval.c (verror): Simplify calculation of size_t.
11741
11742 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11743 messages.
11744
f61f41d7
PE
117452011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11746
11747 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11748 change.
11749
96fb4434
PE
117502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11751
11752 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11753 This makes this file independent of the recent pseudovector change.
11754
671875da 117552011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11756
69e9b5a3
PE
11757 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11758
b5f869a7 11759 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11760 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11761 Remove unused local.
c8926152 11762 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11763
841a1577 11764 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11765 GCC 4.6.0 optimizes based on type-based alias analysis.
11766 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11767 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11768 != &v->size, and therefore "v->size = 1; b->size = 2; return
11769 v->size;" must therefore return 1. This assumption is incorrect
11770 for Emacs, since it type-puns struct Lisp_Vector * with many other
11771 types. To fix this problem, this patch adds a new type struct
f904488f 11772 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11773 and pseudovectors, and helps optimizing compilers not get fooled
11774 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11775 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11776 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11777 the size member.
eab3844f
PE
11778 (XSETPVECTYPE): Rewrite in terms of new macro.
11779 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11780 This is a bit clearer, and further avoids the possibility of
11781 undesirable aliasing.
11782 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11783 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11784 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11785 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11786 (ASIZE): Now uses header.size rather than size.
11787 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11788 to avoid the hassle of writing XVECTOR (foo)->header.size.
11789 (struct vectorlike_header): New type.
eab3844f
PE
11790 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11791 object, to help avoid aliasing.
11792 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11793 (SUBRP): Likewise, since Lisp_Subr is a special case.
11794 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11795 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11796 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11797 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11798 changed to be "header.size" and "header.next".
11799 * buffer.h (struct buffer): Likewise.
11800 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11801 * frame.h (struct frame): Likewise.
11802 * process.h (struct Lisp_Process): Likewise.
11803 * termhooks.h (struct terminal): Likewise.
11804 * window.c (struct save_window_data, struct saved_window): Likewise.
11805 * window.h (struct window): Likewise.
11806 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11807 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11808 * buffer.c (init_buffer_once): Likewise.
11809 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11810 special case.
11811 * process.c (Fformat_network_address): Use local var for size,
11812 for brevity.
11813
0df1eac5
PE
11814 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11815
847ab9d1 11816 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11817 * data.c (atof): Remove decl; no longer used or needed.
11818 (digit_to_number): Move to lread.c.
11819 (Fstring_to_number): Use new string_to_number function, to be
11820 consistent with how the Lisp reader treats infinities and NaNs.
11821 Do not assume that floating-point numbers represent EMACS_INT
11822 without losing information; this is not true on most 64-bit hosts.
11823 Avoid double-rounding errors, by insisting on integers when
11824 parsing non-base-10 numbers, as the documentation specifies.
11825 * lisp.h (string_to_number): New decl, replacing ...
11826 (isfloat_string): Remove.
bc0a5c13 11827 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11828 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11829 appears to have been a coding error. Similarly, do not accept
11830 strings like +-1e0 as floating point numbers. Do not report
11831 overflow for integer overflows unless the base is not 10 which
11832 means we have no simple and reliable way to continue.
11833 Break out the floating-point parsing into a new
11834 function string_to_number, so that Fstring_to_number parses
11835 floating point numbers consistently with the Lisp reader.
04f2d78b 11836 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11837 (E_CHAR, EXP_INT): Remove, replacing with ...
11838 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11839 (string_to_number): New function, replacing isfloat_string.
11840 This function checks for valid syntax and produces the resulting
11841 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11842 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11843 so that overflow for non-base-10 numbers is reported only when
11844 there's no portable and simple way to convert to floating point.
452f4150 11845
67769ffc
PE
11846 * textprop.c (set_text_properties_1): Rewrite for clarity,
11847 and to avoid GCC warning about integer overflow.
11848
c20db43f
PE
11849 * intervals.h (struct interval): Use EMACS_INT for members
11850 where EMACS_UINT might cause problems. See
11851 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11852 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11853 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11854 All uses changed.
37aa2f85
PE
11855 (offset_intervals): Tell GCC not to worry about length overflow
11856 when negating a negative length.
c20db43f 11857
2538aa2f
PE
11858 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11859 (overrun_check_free): Likewise.
11860
f2d3008d
PE
11861 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11862 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11863 word size.
11864
ec8df744
PE
11865 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11866 (gnutls_make_error): Rename local to avoid shadowing.
11867 (gnutls_emacs_global_deinit): ifdef out; not used.
11868 (Fgnutls_boot): Use const for pointer to readonly storage.
11869 Comment out unused local. Fix pointer signedness problems.
11870
640ee02d
PE
11871 * lread.c (openp): Don't stuff size_t into an 'int'.
11872 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11873 about possible signed overflow.
11874
6048fb2a
PE
11875 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11876 (GDK_KEY_g): Don't define if already defined.
11877 (xg_prepare_tooltip): Avoid pointer signedness problem.
11878 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11879
fa3c87e1
PE
11880 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11881 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11882
2172544b
PE
11883 * xfns.c (Fx_window_property): Simplify a bit,
11884 to make a bit faster and to avoid GCC 4.6.0 warning.
11885 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11886
9b821a21
PE
11887 * fns.c (internal_equal): Don't assume size_t fits in int.
11888
3c616cfa
PE
11889 * alloc.c (compact_small_strings): Tighten assertion a little.
11890
c2982e87
PE
11891 Replace pEd with more-general pI, and fix some printf arg casts.
11892 * lisp.h (pI): New macro, generalizing old pEd macro to other
11893 conversion specifiers. For example, use "...%"pI"d..." rather
11894 than "...%"pEd"...".
11895 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11896 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11897 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11898 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11899 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11900 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11901 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11902 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11903 64-bit hosts.
11904 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11905 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11906 * print.c (safe_debug_print, print_object): Likewise.
11907 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11908 to int.
6f04d126
PE
11909 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11910 avoiding the 0 flag, which is not portable.
c2982e87
PE
11911 * process.c (Fmake_network_process): Use pI to avoid cast.
11912 * region-cache.c (pp_cache): Likewise.
11913 * xdisp.c (decode_mode_spec): Likewise.
11914 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11915 behavior on 64-bit hosts with printf arg.
6f04d126 11916 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11917 (x_stop_queuing_selection_requests): Likewise.
11918 (x_get_window_property): Don't truncate byte count to an 'int'
11919 when tracing.
0b432f21 11920
5e073ec7
PE
11921 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11922 here, since it parses constructs like leading '-' and spaces,
11923 which are not wanted; and it overflows with large numbers.
11924 Instead, simply match F[0-9]+, which is what is wanted anyway.
11925
36372bf9
PE
11926 * alloc.c: Remove unportable assumptions about struct layout.
11927 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11928 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11929 (allocate_vectorlike, make_pure_vector): Use the new macros,
11930 plus offsetof, to remove unportable assumptions about struct layout.
11931 These assumptions hold on all porting targets that I know of, but
11932 they are not guaranteed, they're easy to remove, and removing them
11933 makes further changes easier.
11934
0b432f21
PE
11935 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11936 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11937 (string_overrun_cookie): Now const. Use initializers that
11938 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11939 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11940 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11941 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11942 multiple of sizeof (EMACS_INT); it need not be, if
11943 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11944 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11945
895009e1
JB
119462011-04-26 Juanma Barranquero <lekktu@gmail.com>
11947
11948 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11949
6a7a1b0b
TZ
119502011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11951
11952 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11953 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11954 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11955
841a1577 119562011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11957
11958 * lisp.h (Qdebug): List symbol.
895009e1 11959 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11960 * keyboard.c (debug-on-event): New variable.
11961 (handle_user_signal): Break into debugger when debug-on-event
11962 matches the current signal symbol.
11963
f2d3ba6f
DN
119642011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11965
11966 * alloc.c (check_sblock, check_string_bytes)
11967 (check_string_free_list): Convert to standard C.
11968
42ce4c63
TZ
119692011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11970
11971 * w32.c (emacs_gnutls_push): Fix typo.
11972
825cd63c
EZ
119732011-04-25 Eli Zaretskii <eliz@gnu.org>
11974
fb11d64d
EZ
11975 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11976 "cast to pointer from integer of different size".
11977
825cd63c
EZ
11978 Improve doprnt and its use in verror. (Bug#8545)
11979 * doprnt.c (doprnt): Document the set of format control sequences
11980 supported by the function. Use SAFE_ALLOCA instead of always
11981 using `alloca'.
11982
11983 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11984 is one byte too soon. Don't use xrealloc; instead xfree and
11985 xmalloc anew.
11986
e061a11b
TZ
119872011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11988
11989 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11990 callbacks stage.
11991
11992 * gnutls.c: Renamed global_initialized to
11993 gnutls_global_initialized. Added internals for the
11994 :verify-hostname-error, :verify-error, and :verify-flags
11995 parameters of `gnutls-boot' and documented those parameters in the
11996 docstring. Start callback support.
9173deec
JB
11997 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11998 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11999 on error. Return error code.
e061a11b
TZ
12000 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12001 (emacs_gnutls_read): Likewise.
12002 (Fgnutls_boot): Return handshake error code.
12003 (emacs_gnutls_handle_error): New function.
12004 (wsaerror_to_errno): Likewise.
12005
12006 * w32.h (emacs_gnutls_pull): Add prototype.
12007 (emacs_gnutls_push): Likewise.
12008
12009 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12010 (emacs_gnutls_push): Likewise.
12011
120122011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12013
12014 * process.c (wait_reading_process_output): Check if GnuTLS
12015 buffered some data internally if no FDs are set for TLS
12016 connections.
12017
12018 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12019 (LIBS): Link to USER_LIBS.
12020 ($(BLD)/gnutls.$(0)): New target.
12021
fa6996bc
EZ
120222011-04-24 Eli Zaretskii <eliz@gnu.org>
12023
eb35682e
EZ
12024 * xdisp.c (handle_single_display_spec): Rename the
12025 display_replaced_before_p argument into display_replaced_p, to
12026 make it consistent with the commentary. Fix typos in the
12027 commentary.
12028
e2ad650c
EZ
12029 * textprop.c (syms_of_textprop): Remove dead code.
12030 (copy_text_properties): Delete obsolete commentary about an
12031 interface that was deleted long ago. Fix typos in the description
12032 of arguments.
12033
1b2de274
EZ
12034 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12035 to changes in oldXMenu/XMenu.h from 2011-04-16.
12036 <menu_help_message, prev_menu_help_message>: Constify.
12037 (IT_menu_make_room): menu->help_text is now `const char **';
12038 adjust.
12039
12040 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12041 to changes in oldXMenu/XMenu.h from 2011-04-16.
12042 (struct XMenu): Declare `help_text' `const char **'.
12043
12044 * xfaces.c <Qunspecified>: Make extern again.
12045
12046 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12047 required by POSIX.
1b2de274 12048
762b15be
EZ
12049 * doc.c (get_doc_string): Improve the format passed to `error'.
12050
12051 * doprnt.c (doprnt): Improve commentary.
12052
12053 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12054
12055 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12056 them with etags.
12057
f1052e5d
EZ
12058 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12059 changes in globals.h immediately force recompilation.
762b15be
EZ
12060 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12061 $(CURDIR)/s/ms-w32.h.
12062 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12063
fa6996bc
EZ
12064 * character.c (Fchar_direction): Function deleted.
12065 (syms_of_character): Don't defsubr it.
12066 <char-direction-table>: Deleted.
12067
e6c3da20
EZ
120682011-04-23 Eli Zaretskii <eliz@gnu.org>
12069
12070 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12071 * doprnt.c: Include limits.h.
12072 (SIZE_MAX): New macro.
04f2d78b
CB
12073 (doprnt): Return a size_t value. 2nd arg is now size_t.
12074 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12075 Improve overflow protection. Support `l' modifier for integer
12076 conversions. Support %l conversion. Don't assume an EMACS_INT
12077 argument for integer conversions and for %c.
12078
12079 * lisp.h (doprnt): Restore prototype.
12080
12081 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12082 $(SRC)/character.h.
12083
12084 * Makefile.in (base_obj): Add back doprnt.o.
12085
12086 * deps.mk (doprnt.o): Add back prerequisites.
12087 (callint.o): Depend on character.h.
12088
12089 * eval.c (internal_lisp_condition_case): Include the handler
12090 representation in the error message.
12091 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12092 when breaking from the loop.
12093
12094 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12095
12096 * callint.c (Fcall_interactively): When displaying error message
12097 about invalid control letter, pass the character's codepoint, not
12098 a pointer to its multibyte form. Improve display of the character
12099 in octal and display also its hex code.
12100
12101 * character.c (char_string): Use %x to display the (unsigned)
12102 codepoint of an invalid character, to avoid displaying a bogus
12103 negative value.
12104
12105 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12106 `error', not SYMBOL_NAME itself.
12107
12108 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12109 character arguments to `error'.
12110
12111 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12112 to `error' in error message about FINAL_CHAR argument. Make sure
12113 FINAL_CHAR is a character, and use %c when it is passed as
12114 argument to `error'.
12115
4ffd0d6b 121162011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12117
12118 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12119
12120 * w32.c: Include <time.h>.
12121 (sys_localtime): New function.
12122
4ffd0d6b 121232011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12124
12125 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12126
4ffd0d6b 12127 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12128
4ffd0d6b 121292011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12130
4ffd0d6b
GM
12131 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12132 zombies (Bug#8467).
aac0c6e3 12133
04c56954
EZ
121342011-04-19 Eli Zaretskii <eliz@gnu.org>
12135
12136 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12137 gl_state.e_property when gl_state.object is Qt.
12138
12139 * insdel.c (make_gap_larger): Remove limitation of buffer size
12140 to <= INT_MAX.
12141
16a43933
CY
121422011-04-18 Chong Yidong <cyd@stupidchicken.com>
12143
12144 * xdisp.c (lookup_glyphless_char_display)
12145 (produce_glyphless_glyph): Handle cons cell entry in
12146 glyphless-char-display.
12147 (Vglyphless_char_display): Document it.
12148
12149 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12150 glyphless-char-display.
12151
4581706e
CY
121522011-04-17 Chong Yidong <cyd@stupidchicken.com>
12153
12154 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12155
12156 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12157
12158 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12159 definition for no-X builds.
12160
4887c6e2 121612011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12162
fd35b6f9
PE
12163 Static checks with GCC 4.6.0 and non-default toolkits.
12164
5c1ccb01
PE
12165 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12166
006c5daa
PE
12167 * process.c (keyboard_bit_set): Define only if SIGIO.
12168 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12169 (send_process): Repair possible setjmp clobbering.
12170
efc736d3
PE
12171 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12172
4e2fe2e6
PE
12173 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12174
f97334a2
PE
12175 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12176
4e75f29d
PE
12177 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12178 Define only if needed.
12179
90efadd1
PE
12180 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12181 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12182 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12183
3c647824
PE
12184 * dispextern.h (struct redisplay_interface): Rename param
12185 to avoid shadowing.
e264f262 12186 * termhooks.h (struct terminal): Likewise.
761383f4 12187 * xterm.c (xembed_send_message): Likewise.
3c647824 12188
b58c5c4a
PE
12189 * insdel.c (make_gap_smaller): Define only if
12190 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12191
cad59032
PE
12192 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12193 it.
12194
c339dc2e
PE
12195 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12196 so that we aren't warned about unused symbols.
12197
91a3e27b
PE
12198 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12199
399c71d3 12200 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12201
8ffc96f5
PE
12202 * xfns.c (x_real_positions): Mark locals as initialized.
12203
eef9bc79
PE
12204 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12205
098db9dd
PE
12206 * xterm.c: Fix problems found by static analysis with other toolkits.
12207 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12208 (x_dispatch_event): Declare static if USE_GTK, and
12209 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12210 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12211 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12212 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12213 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12214
eb18f6cc
PE
12215 * xmenu.c (menu_help_callback): Pointer type fixes.
12216 Use const pointers when pointing at readonly data. Avoid pointer
12217 signedness clashes.
12218 (FALSE): Remove unused macro.
12219 (update_frame_menubar): Remove unused decl.
12220
1fe72bf8
PE
12221 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12222
60d9e1db
PE
12223 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12224 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12225 (single_menu_item): Rename local to avoid shadowing.
12226
39261c26
PE
12227 * keyboard.c (make_lispy_event): Remove unused local var.
12228
018c5e19
PE
12229 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12230 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12231
63d2b86e
PE
12232 * bitmaps: Change bitmaps from unsigned char back to the X11
12233 compatible char. Avoid the old compiler warnings about
12234 out-of-range initializers by using, for example, '\xab' rather
12235 than 0xab.
12236
aefd87e1
PE
12237 * xgselect.c (xgselect_initialize): Check vs interface
12238 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12239
bf501fb9
PE
12240 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12241
e9829fdf
PE
12242 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12243 to read-only memory.
12244
1086c095
PE
12245 * fns.c (vector): Remove; this old hack is no longer needed.
12246
2baccd04 12247 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12248 Remove unused var.
dde42981 12249 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12250
72391843 12251 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12252
436c16df 12253 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12254 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12255 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12256
92bb796d 12257 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12258 (x_term_init): Remove local to avoid shadowing.
92bb796d 12259
764430a3 12260 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12261
12262 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12263 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12264
d1dfb56c
EZ
122652011-04-16 Eli Zaretskii <eliz@gnu.org>
12266
c4354cb4
EZ
12267 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12268
d1dfb56c
EZ
12269 Fix regex.c, syntax.c and friends for buffers > 2GB.
12270 * syntax.h (struct gl_state_s): Declare character position members
12271 EMACS_INT.
12272
12273 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12274
04f2d78b
CB
12275 * textprop.c (verify_interval_modification, interval_of):
12276 Declare arguments EMACS_INT.
d1dfb56c
EZ
12277
12278 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12279 EMACS_INT.
12280
12281 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12282
12283 * indent.c (Fvertical_motion): Local variable it_start is now
12284 EMACS_INT.
12285
12286 * regex.c (re_match, re_match_2, re_match_2_internal)
12287 (bcmp_translate, regcomp, regexec, print_double_string)
12288 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12289 (re_compile_pattern, re_exec): Declare arguments and local
12290 variables `size_t' and `ssize_t' and return values `regoff_t', as
12291 appropriate.
12292 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12293 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12294 <compile_stack_type>: `size' and `avail' are now `size_t'.
12295
12296 * regex.h <regoff_t>: Use ssize_t, not int.
12297 (re_search, re_search_2, re_match, re_match_2): Arguments that
12298 specify buffer/string position and length are now ssize_t and
12299 size_t. Return type is regoff_t.
12300
613052cd
BK
123012011-04-16 Ben Key <bkey76@gmail.com>
12302
12303 * nsfont.m: Fixed bugs in ns_get_family and
12304 ns_descriptor_to_entity that were caused by using free to
12305 deallocate memory blocks that were allocated by xmalloc (via
12306 xstrdup). This caused Emacs to crash when compiled with
12307 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12308 --enable-checking=xmallocoverrun). xfree is now used to
12309 deallocate these memory blocks.
12310
4170f62f 123112011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12312
71b41406
PE
12313 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12314
9587a89d
PE
12315 emacs_write: Accept and return EMACS_INT for sizes.
12316 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12317 et seq.
12318 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12319 Accept and return EMACS_INT.
12320 (emacs_gnutls_write): Return the number of bytes written on
12321 partial writes.
12322 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12323 (emacs_read, emacs_write): Remove check for negative size, as the
12324 Emacs source code has been audited now.
9587a89d
PE
12325 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12326 (emacs_read, emacs_write): Use it.
273a5f82
PE
12327 * process.c (send_process): Adjust to the new signatures of
12328 emacs_write and emacs_gnutls_write. Do not attempt to store
12329 a byte offset into an 'int'; it might overflow.
9587a89d 12330 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12331
3e047f51
PE
12332 * sound.c: Don't assume sizes fit in 'int'.
12333 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12334 Return EMACS_INT, not int.
3e047f51 12335 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12336 Accept EMACS_INT, not int.
12337 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12338 record read return values.
12339
cc39a9db
BK
123402011-04-15 Ben Key <bkey76@gmail.com>
12341
c9d0ec6d
JB
12342 * keyboard.c (Qundefined): Don't declare static since it is used
12343 in nsfns.m.
12344 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12345 static since they are used in nsfont.m.
cc39a9db 12346
6c60eb9f
SM
123472011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12348
12349 * process.c (Qprocessp): Don't declare static.
12350 * lisp.h (Qprocessp): Declare again.
12351
7990b61a
JB
123522011-04-15 Juanma Barranquero <lekktu@gmail.com>
12353
12354 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12355
5d4cb038
PE
123562011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12357
8bd7b830 12358 Improve C-level modularity by making more things 'static'.
cd64ea1d 12359
e3b27b31
PE
12360 Don't publish debugger-only interfaces to other modules.
12361 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12362 (verify_bytepos, count_markers): Move decls to the only modules
12363 that need them.
12364 * region-cache.h (pp_cache): Likewise.
12365 * window.h (check_all_windows): Likewise.
12366 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12367
5d4cb038
PE
12368 * sysdep.c (croak): Now static, if
12369 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12370 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12371
12372 * alloc.c (refill_memory_reserve): Now static if
12373 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12374 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12375
e87b6180
PE
12376 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12377 Define only if USE_LUCID.
12378
ac64929e
PE
12379 * xrdb.c (x_customization_string, x_rm_string): Now static.
12380
6f37259d
PE
12381 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12382 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12383
1683e3ab
PE
12384 * xdisp.c (draw_row_with_mouse_face): Now static.
12385 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12386
de9c2632
PE
12387 * window.h (check_all_windows): Mark externally visible.
12388
2b96acb7
PE
12389 * window.c (window_deletion_count): Now static.
12390
12391 * undo.c: Make symbols static if they're not exported.
12392 (last_undo_buffer, last_boundary_position, pending_boundary):
12393 Now static.
12394
50436f33
PE
12395 * textprop.c (interval_insert_behind_hooks): Now static.
12396 (interval_insert_in_front_hooks): Likewise.
12397
64520e5c
PE
12398 * term.c: Make symbols static if they're not exported.
12399 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12400 (max_frame_lines, tty_set_terminal_modes):
12401 (tty_reset_terminal_modes, tty_turn_off_highlight):
12402 (get_tty_terminal): Now static.
12403 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12404 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12405 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12406 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12407 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12408
1fa53021
PE
12409 * sysdep.c: Make symbols static if they're not exported.
12410 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12411 Now static.
12412 (sigprocmask_set, full_mask): Remove; unused.
12413 (wait_debugging): Mark as visible.
12414 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12415 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12416
d4b43b22
PE
12417 * syntax.c (syntax_temp): Define only if !__GNUC__.
12418
b7c513d0
PE
12419 * sound.c (current_sound_device, current_sound): Now static.
12420
989b29ad
PE
12421 * search.c (searchbufs, searchbuf_head): Now static.
12422
13a55a78
PE
12423 * scroll.c (scroll_cost): Remove; unused.
12424 * dispextern.h (scroll_cost): Remove decl.
12425
de68a1fc
PE
12426 * region-cache.h (pp_cache): Mark as externally visible.
12427
40ccffa6
PE
12428 * process.c: Make symbols static if they're not exported.
12429 (process_tick, update_tick, create_process, chan_process):
12430 (Vprocess_alist, proc_buffered_char, datagram_access):
12431 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12432 (deactivate_process): Mark defn as static, as well as decl.
12433 * lisp.h (create_process): Remove decl.
12434 * process.h (chan_process, Vprocess_alist): Remove decls.
12435
ad64fc97
PE
12436 * print.c: Make symbols static if they're not exported.
12437 (print_depth, new_backquote_output, being_printed, print_buffer):
12438 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12439 (print_interval, print_number_index, initial_stderr_stream):
12440 Now static.
12441 * lisp.h (Fprinc): Remove decl.
12442 (debug_output_compilation_hack): Mark as externally visible.
12443
adddb265
PE
12444 * sysdep.c (croak): Move decl from here to syssignal.h.
12445 * syssignal.h (croak): Put it here, so the API can be checked when
12446 'croak' is called from dissociate_if_controlling_tty.
12447
1717ede2
PE
12448 * minibuf.c: Make symbols static if they're not exported.
12449 (minibuf_save_list, choose_minibuf_frame): Now static.
12450 * lisp.h (choose_minibuf_frame): Remove decl.
12451
fa5fb2bc
PE
12452 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12453
1e3890d1
PE
12454 * lread.c: Make symbols static if they're not exported.
12455 (read_objects, initial_obarray, oblookup_last_bucket_number):
12456 Now static.
12457 (make_symbol): Remove; unused.
12458 * lisp.h (initial_obarray, make_symbol): Remove decls.
12459
8a1414fa
PE
12460 * keyboard.c: Make symbols static if they're not exported.
12461 (single_kboard, recent_keys_index, total_keys, recent_keys):
12462 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12463 (this_single_command_key_start, echoing, last_auto_save):
12464 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12465 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12466 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12467 (Vlispy_mouse_stem, double_click_count):
12468 Now static.
12469 (force_auto_save_soon): Define only if SIGDANGER.
12470 (ignore_mouse_drag_p): Now static if
12471 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12472 (print_help): Remove; unused.
12473 (stop_character, last_timer_event): Mark as externally visible.
12474 * keyboard.h (ignore_mouse_drag_p): Declare only if
12475 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12476 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12477 * lisp.h (echoing): Remove decl.
12478 (force_auto_save_soon): Declare only if SIGDANGER.
12479 * xdisp.c (redisplay_window): Simplify code, to make it more
12480 obvious that ignore_mouse_drag_p is not accessed if !defined
12481 USE_GTK && !defined HAVE_NS.
12482
93ea6e8f
PE
12483 * intervals.c: Make symbols static if they're not exported.
12484 (merge_properties_sticky, merge_interval_right, delete_interval):
12485 Now static.
12486 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12487
77382fcc
PE
12488 * insdel.c: Make symbols static if they're not exported.
12489 However, leave prepare_to_modify_buffer alone. It's never
12490 called from outside this function, but that appears to be a bug.
12491 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12492 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12493 (adjust_after_replace_noundo): Remove; unused.
12494 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12495 (signal_before_change): Remove decls.
77382fcc 12496
9306c32e
PE
12497 * indent.c (val_compute_motion, val_vmotion): Now static.
12498
cd44d2eb
PE
12499 * image.c: Make symbols static if they're not exported.
12500 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12501 if USE_GTK.
12502 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12503 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12504
ad9a7a06
PE
12505 * fringe.c (standard_bitmaps): Now static.
12506 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12507
81626931
PE
12508 * frame.c: Make symbols static if they're not exported.
12509 (x_report_frame_params, make_terminal_frame): Now static.
12510 (get_frame_param): Now static, unless HAVE_NS.
12511 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12512 (x_get_resource_string): Remove; not used.
12513 * frame.h (make_terminal_frame, x_report_frame_params):
12514 (x_get_resource_string); Remove decls.
12515 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12516 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12517
239f9db9
PE
12518 * font.c, fontset.c: Make symbols static if they're not exported.
12519 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12520 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12521 * font.c (font_close_object): Now static.
12522 * font.h (font_close_object): Remove.
12523 * fontset.c (FONTSET_OBJLIST): Remove.
12524 (free_realized_fontset) #if-0 the body, which does nothing.
12525 (face_suitable_for_char_p): #if-0, as it's never called.
12526 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12527 * xfaces.c (face_at_string_position):
12528 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12529 since 0 is always ASCII.
12530
dfcf3579
PE
12531 * fns.c (weak_hash_tables): Now static.
12532
5045092b
PE
12533 * fileio.c: Make symbols static if they're not exported.
12534 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12535 (Vwrite_region_annotation_buffers): Now static.
12536
57a96f5c
PE
12537 * eval.c: Make symbols static if they're not exported.
12538 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12539 * lisp.h (backtrace_list): Remove decl.
12540
35f08c38
PE
12541 * emacs.c: Make symbols static if they're not exported.
12542 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12543 (fatal_error_code, fatal_error_signal_hook, standard_args):
12544 Now static.
12545 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12546 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12547 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12548 * lisp.h (fatal_error_signal_hook): Remove decl.
12549 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12550
f44bd759
PE
12551 * editfns.c: Move a (normally-unused) function to its only use.
12552 * editfns.c, lisp.h (get_operating_system_release): Remove.
12553 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12554 worth the hassle of breaking this out.
12555
b532497d
PE
12556 * xterm.c: Make symbols static if they're not exported.
12557 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12558 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12559 (x_destroy_window, x_delete_display):
12560 Now static.
12561 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12562 (x_mouse_leave): Remove; unused.
12563 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12564 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12565 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12566 Remove decls.
12567 (x_mouse_leave): Declare only if WINDOWSNT.
12568 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12569 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12570 USE_X_TOOLKIT.
12571
1675728f
PE
12572 * ftxfont.c: Make symbols static if they're not exported.
12573 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12574 HAVE_FREETYPE.
12575 * font.h (ftxfont_driver): Likewise.
12576
e4cebfca
PE
12577 * xfns.c: Make symbols static if they're not exported.
12578 (x_last_font_name, x_display_info_for_name):
12579 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12580 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12581 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12582 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12583 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12584 (last_show_tip_args): Now static.
12585 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12586 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12587 (x_screen_planes): Remove; unused.
12588 * dispextern.h (x_screen_planes): Remove decl.
12589
5bf46f05
PE
12590 * dispnew.c: Make symbols static if they're not exported.
12591 * dispextern.h (redraw_garbaged_frames, scrolling):
12592 (increment_row_positions): Remove.
12593 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12594 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12595 Now static.
12596 (redraw_garbaged_frames): Remove; unused.
12597
435f4c28
PE
12598 * xfaces.c: Make symbols static if they're not exported.
12599 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12600 Remove decls.
12601 * xterm.h (defined_color): Remove decls.
12602 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12603 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12604 (menu_face_changed_default, defined_color, free_realized_face):
12605 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12606 (ascii_face_of_lisp_face): Remove; unused.
12607
8524aef3
PE
12608 * xdisp.c: Make symbols static if they're not exported.
12609 * dispextern.h (scratch_glyph_row, window_box_edges):
12610 (glyph_to_pixel_coords, set_cursor_from_row):
12611 (get_next_display_element, set_iterator_to_next):
12612 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12613 (show_mouse_face): Remove decls
12614 * frame.h (message_buf_print): Likewise.
12615 * lisp.h (pop_message, set_message, check_point_in_composition):
12616 Likewise.
12617 * xterm.h (set_vertical_scroll_bar): Likewise.
12618 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12619 (message_buf_print, scratch_glyph_row, displayed_buffer):
12620 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12621 (get_next_display_element, show_mouse_face, window_box_edges):
12622 (frame_to_window_pixel_xy, check_point_in_composition):
12623 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12624 (glyph_to_pixel_coords): Remove; unused.
12625
16390cd2
PE
12626 * dired.c (file_name_completion): Now static.
12627
12628 * dbusbind.c (xd_in_read_queued_messages): Now static.
12629
a25f4dfa
PE
12630 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12631 * data.c (circular_list_error): Remove.
12632
14a9c8df
PE
12633 * commands.h (last_point_position, last_point_position_buffer):
12634 (last_point_position_window): Remove decls.
12635 * keyboard.c: Make these variables static.
12636
04f2d78b
CB
12637 * coding.h (coding, code_convert_region, encode_coding_gap):
12638 Remove decls.
74ab6df5
PE
12639 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12640 (iso_code_class, detect_coding, code_convert_region): Now static.
12641 (encode_coding_gap): Remove; unused.
12642
38dfbee1
PE
12643 * chartab.c (chartab_chars, chartab_bits): Now static.
12644
a2cb4e63
PE
12645 * charset.h (charset_iso_8859_1): Remove decl.
12646 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12647 Now static.
12648
127198fd
PE
12649 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12650 * ccl.c (Vccl_program_table): Now static.
12651 (check_ccl_update): Remove; unused.
12652
d85b608f
PE
12653 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12654 * category.h: ... from here.
12655 * category.c (check_category_table, set_category_set): Now static.
12656
31cd66f3
PE
12657 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12658 * lisp.h: Remove these decls.
12659
c358e587
PE
12660 * buffer.c (buffer_count): Remove unused var.
12661
e78aecca
PE
12662 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12663 so that it's not optimized away.
12664 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12665 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12666 exported only to the debugger.
12667
e192d7d3 12668 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12669 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12670
92470028
PE
12671 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12672 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12673 was inaccessible from Lisp.
12674 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12675 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12676
244ed907
PE
12677 alloc.c: Import and export fewer symbols, and remove unused items.
12678 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12679 is defined.
12680 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12681 it's not optimized away by whole-program optimization.
12682 (message_enable_multibyte, free_misc): Remove.
12683 (catchlist, handlerlist, mark_backtrace):
12684 Declare only if BYTE_MARK_STACK.
12685 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12686 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12687 (message_enable_multibyte): Remove decl.
12688 (free_misc, interval_free_list, float_block, float_block_index):
12689 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12690 (cons_free_list, last_marked_index):
12691 Now static.
12692 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12693 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12694 (mark_backtrace): Define only if BYTE_MARK_STACK.
12695 * xdisp.c (message_enable_multibyte): Now static.
12696
61c2b50e 12697 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12698 This makes it easier for human readers (and static analyzers)
12699 to see whether these variables are used from other modules.
12700 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12701 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12702 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12703 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12704 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12705 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12706 * xmenu.c, xselect.c:
12707 Declare Q* vars static if they are not used in other modules.
12708 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12709 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12710 Remove decls of unexported vars.
12711 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12712
95c82688
PE
12713 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12714
16a97296
PE
12715 Make Emacs functions such as Fatom 'static' by default.
12716 This makes it easier for human readers (and static analyzers)
12717 to see whether these functions can be called from other modules.
12718 DEFUN now defines a static function. To make the function external
12719 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12720 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12721 (Finit_image_library):
16a97296
PE
12722 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12723 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12724 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12725 Remove decls, since these functions are now static.
12726 (Funintern, Fget_internal_run_time): New decls, since these functions
12727 were already external.
95c82688 12728
16a97296
PE
12729 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12730 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12731 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12732 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12733 * keyboard.c, keymap.c, lread.c:
12734 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12735 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12736 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12737 Mark functions with DEFUE instead of DEFUN,
12738 if they are used in other modules.
12739 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12740 decls for now-static functions.
12741 * buffer.h (Fdelete_overlay): Remove decl.
12742 * callproc.c (Fgetenv_internal): Mark as internal.
12743 * composite.c (Fremove_list_of_text_properties): Remove decl.
12744 (Fcomposition_get_gstring): New forward static decl.
12745 * composite.h (Fcomposite_get_gstring): Remove decl.
12746 * dired.c (Ffile_attributes): New forward static decl.
12747 * doc.c (Fdocumntation_property): New forward static decl.
12748 * eval.c (Ffetch_bytecode): New forward static decl.
12749 (Funintern): Remove extern decl; now in .h file where it belongs.
12750 * fileio.c (Fmake_symbolic_link): New forward static decl.
12751 * image.c (Finit_image_library): New forward static decl.
12752 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12753 * intervals.h (Fprevious_property_change):
12754 (Fremove_list_of_text_properties): Remove decls.
12755 * keyboard.c (Fthis_command_keys): Remove decl.
12756 (Fcommand_execute): New forward static decl.
12757 * keymap.c (Flookup_key): New forward static decl.
12758 (Fcopy_keymap): Now static.
12759 * keymap.h (Flookup_key): Remove decl.
12760 * process.c (Fget_process): New forward static decl.
12761 (Fprocess_datagram_address): Mark as internal.
12762 * syntax.c (Fsyntax_table_p): New forward static decl.
12763 (skip_chars): Remove duplicate decl.
12764 * textprop.c (Fprevious_property_change): New forward static decl.
12765 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12766 Now internal.
12767 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12768 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12769
785bbd42
PE
12770 * editfns.c (Fformat): Remove unreachable code.
12771
8b913b57
AS
127722011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12773
12774 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12775 change. (Bug#8496)
12776
a6744a35
EZ
127772011-04-13 Eli Zaretskii <eliz@gnu.org>
12778
12779 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12780 when at ZV. (Bug#8487)
12781
e7974947
AS
127822011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12783
baad03f0
AS
12784 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12785 (Bug#8437)
12786 * keyboard.c (parse_tool_bar_item): Likewise.
12787 * sound.c (sound_cleanup, alsa_close): Likewise.
12788 * termcap.c (tgetent): Likewise.
12789 * xfns.c (x_default_font_parameter): Likewise.
12790 * xsettings.c (read_and_apply_settings): Likewise.
12791
e7974947
AS
12792 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12793 (overrun_check_free): Protoize.
12794
28272684
PE
127952011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12796
12797 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12798 since callers should never pass a negative size.
12799 Change the signature to match that of plain 'read' and 'write'; see
12800 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12801 * lisp.h: Update prototypes of emacs_write and emacs_read.
12802
11997c76
EZ
128032011-04-11 Eli Zaretskii <eliz@gnu.org>
12804
12805 * xdisp.c (redisplay_window): Don't try to determine the character
12806 position of the scroll margin if the window start point w->startp
e896f03c 12807 is outside the buffer's accessible region. (Bug#8468)
11997c76 12808
8a2cbd72
EZ
128092011-04-10 Eli Zaretskii <eliz@gnu.org>
12810
12811 Fix write-region and its subroutines for buffers > 2GB.
12812 * fileio.c (a_write, e_write): Modify declaration of arguments and
12813 local variables to support buffers larger than 2GB.
12814 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12815
12816 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12817 argument, local variables, and return value.
12818
12819 * lisp.h: Update prototypes of emacs_write and emacs_read.
12820
12821 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12822
4073e537 128232011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12824
1ebfdcb6
PE
12825 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12826
b2ded58d
PE
12827 Fix more problems found by GCC 4.6.0's static checks.
12828
7d66342c
PE
12829 * xdisp.c (vmessage): Use a better test for character truncation.
12830
bbf47d44
PE
12831 * charset.c (load_charset_map): <, not <=, for optimization,
12832 and to avoid potential problems with integer overflow.
9248994d 12833 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12834 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12835 * editfns.c (Fformat): Likewise.
1e69125e 12836 * syntax.c (skip_chars): Likewise.
3befa583 12837
e3019616
PE
12838 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12839 This also lets GCC 4.6.0 generate slightly better loop code.
12840
becfa255
PE
12841 * callint.c (Fcall_interactively): <, not <=, for optimization.
12842 (Fcall_interactively): Count the number of arguments produced,
12843 not the number of arguments given. This is simpler and lets GCC
12844 4.6.0 generate slightly better code.
12845
dae0cd48
PE
12846 * ftfont.c: Distingish more carefully between FcChar8 and char.
12847 The previous code passed unsigned char * to a functions like
12848 strlen and xstrcasecmp that expect char *, which does not
12849 conform to the C standard.
12850 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12851 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12852 char * when the C standard requires it.
12853
76032d70
PE
12854 * keyboard.c (read_char): Remove unused var.
12855
eb3f1cc8
PE
12856 * eval.c: Port to Windows vsnprintf (Bug#8435).
12857 Include <limits.h>.
12858 (SIZE_MAX): Define if the headers do not.
12859 (verror): Do not give up if vsnprintf returns a negative count.
12860 Instead, grow the buffer. This ports to Windows vsnprintf, which
12861 does not conform to C99. Problem reported by Eli Zaretskii.
12862 Also, simplify the allocation scheme, by avoiding the need for
12863 calling realloc, and removing the ALLOCATED variable.
12864
70476b54
PE
12865 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12866
12020a9e
PE
12867 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12868 But keep the doprint source code for now, as we might revamp it
12869 and use it again (Bug#8435).
ea6c7ae6
PE
12870 * lisp.h (doprnt): Remove.
12871 * Makefile.in (base_obj): Remove doprnt.o.
12872 * deps.mk (doprnt.o): Remove.
12873
5fdb398c
PE
12874 error: Print 32- and 64-bit integers portably (Bug#8435).
12875 Without this change, on typical 64-bit hosts error ("...%d...", N)
12876 was used to print both 32- and 64-bit integers N, which relied on
12877 undefined behavior.
61bdb816 12878 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12879 * lisp.h (error, verror): Mark as printf-like functions.
12880 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12881 Report overflow in size calculations when allocating printf buffer.
12882 Do not truncate output string at its first null byte.
12883 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12884 Truncate the output at a character boundary, since vsnprintf does not
12885 do that.
12886 * charset.c (check_iso_charset_parameter): Convert internal
12887 character to string before calling 'error', since %c now has the
12888 printf meaning.
12889 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12890 overflow when computing char to be passed to 'error'. Do not
12891 pass Lisp_Object to 'error'; pass the integer instead.
12892 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12893 formatted with plain %d.
12894
b189fa66
PE
12895 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12896
bff87ef0
PE
12897 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12898
7e2cac20
PE
12899 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12900
ce4d90b5
PE
12901 * xterm.c (x_catch_errors): Remove duplicate declaration.
12902
266c9547
PE
12903 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12904
79c49ad2
PE
12905 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12906
368f4090
JM
129072011-04-10 Jim Meyering <meyering@redhat.com>
12908
12909 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12910 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12911 return ssize_t not "int", and use size_t as the buffer length.
12912 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12913 * gnutls.h: Update declarations.
12914 * process.c (read_process_output): Use ssize_t, to match.
12915 (send_process): Likewise.
12916
a32d4040
CY
129172011-04-09 Chong Yidong <cyd@stupidchicken.com>
12918
12919 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12920
8546720e 129212011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12922
04f2d78b
CB
12923 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12924 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12925
8546720e
GM
12926 * xterm.c (handle_one_xevent):
12927 * xmenu.c (create_and_show_popup_menu):
12928 * xselect.c (x_decline_selection_request)
12929 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12930
0a2f5c1a 129312011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12932
12933 Fix some uses of `int' instead of EMACS_INT.
12934 * search.c (string_match_1, fast_string_match)
12935 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12936 (scan_buffer, find_next_newline_no_quit)
12937 (find_before_next_newline, search_command, Freplace_match)
12938 (Fmatch_data): Make some `int' variables be EMACS_INT.
12939
12940 * xdisp.c (display_count_lines): 3rd argument and return value now
12941 EMACS_INT. All callers changed.
12942 (pint2hrstr): Last argument is now EMACS_INT.
12943
12944 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12945 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12946 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12947 (decode_coding_utf_16, decode_coding_emacs_mule)
12948 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12949 (decode_coding_ccl, decode_coding_charset)
12950 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12951 (decode_coding_iso_2022, decode_coding_emacs_mule)
12952 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12953 <char_offset, last_offset>: Declare EMACS_INT.
12954 (encode_coding_utf_8, encode_coding_utf_16)
12955 (encode_coding_emacs_mule, encode_invocation_designation)
12956 (encode_designation_at_bol, encode_coding_iso_2022)
12957 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12958 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12959 Declare EMACS_INT.
12960 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12961 (encode_invocation_designation): Last argument P_NCHARS is now
12962 EMACS_INT.
12963 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12964 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12965
12966 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12967 All users changed.
12968
12969 * ccl.c (Fccl_execute_on_string): Declare some variables
12970 EMACS_INT.
12971
8546720e 129722011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12973
12974 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12975
4e19a977
CS
129762011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12977
12978 * process.c (Fformat_network_address): Doc fix.
12979
87302331
R
129802011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12981
ee7683eb 12982 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12983
cbb59342
CY
129842011-04-08 Chong Yidong <cyd@stupidchicken.com>
12985
12986 * keyboard.c (read_char): Call Lisp function help-form-show,
12987 instead of using internal_with_output_to_temp_buffer.
12988 (Qhelp_form_show): New var.
e0d38eeb 12989 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12990
12991 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12992
12993 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12994
e67a13ab
CY
129952011-04-06 Chong Yidong <cyd@stupidchicken.com>
12996
04f2d78b
CB
12997 * process.c (Flist_processes): Remove to Lisp.
12998 (list_processes_1): Delete.
e67a13ab 12999
973f782d
EZ
130002011-04-06 Eli Zaretskii <eliz@gnu.org>
13001
7c106b1e
EZ
13002 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13003
973f782d
EZ
13004 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13005
41cf7d1a 130062011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13007
ca23cc88
PE
13008 Fix more problems found by GCC 4.6.0's static checks.
13009
f390e2d5
PE
13010 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13011
42eea0d0
PE
13012 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13013
b69769da 13014 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13015
f9541e84
PE
13016 * xdisp.c (vmessage): Mark as a printf-like function.
13017
13841b55
PE
13018 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13019
c136c10f
PE
13020 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13021
5e2d4a30
PE
13022 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13023 printf-like functions.
13024 (tiff_load): Add casts to remove these marks before passing them
13025 to system-supplied API.
13026
583f48b9
PE
13027 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13028
b25d760e
PE
13029 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13030 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13031 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13032 directly, rather than having caller test rule sign. This avoids
13033 some unnecessary tests.
13034 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13035 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13036 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13037
bc7b6697 13038 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13039 (xfont_open): Avoid unnecessary tests.
bc7b6697 13040
27ccc379
PE
13041 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13042
dcd5c89a
PE
13043 * composite.h, composite.c (composition_gstring_put_cache):
13044 Use EMACS_INT, not int, for length.
13045
b13a45c6
PE
13046 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13047 breaking out part of COMPOSITION_DECODE_RULE.
13048 (COMPOSITION_DECODE_RULE): Use it.
13049 * composite.c (get_composition_id): Remove unused local vars,
13050 by using the new macro.
13051
1e792e4d
PE
13052 * textprop.c (set_text_properties_1): Change while to do-while,
13053 since the condition is always true at first.
13054
dc6c6455 13055 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13056 (interval_deletion_adjustment): Return unsigned value.
13057 All uses changed.
dc6c6455 13058
aba7731a
PE
13059 * process.c (list_processes_1, create_pty, read_process_output):
13060 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13061 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13062 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13063 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13064 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13065
fdfc4bf3
PE
13066 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13067
fca8fe46 13068 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13069 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13070
06a0259a 13071 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13072 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13073 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13074
e7b9e80f
PE
13075 * print.c (print_error_message): Avoid int overflow.
13076
56201685
PE
13077 * font.c (font_list_entities): Redo for clarity,
13078 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13079
78834453 13080 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13081 (font_score): Avoid potential overflow in diff calculation.
78834453 13082
0bc0b309 13083 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13084 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13085
e610eaca
PE
13086 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13087
b895abce
PE
13088 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13089 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13090 can always succeed if overflow has undefined behavior.
13091
1f1d9321 13092 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13093 (wordify): Omit three unnecessary tests.
1f1d9321 13094
c59478bc
PE
13095 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13096 All callers changed. This avoids the need for an unused var.
13097
79b73827
PE
13098 * casefiddle.c (casify_region): Remove var that is set but not used.
13099
a4db5dfe
PE
13100 * dired.c (file_name_completion): Remove var that is set but not used.
13101
43aae36e
PE
13102 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13103
2a47c44d 13104 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13105 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13106
a37c69bf
PE
13107 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13108 Check for integer overflow on size calculations.
13109
328ab8e7
PE
13110 * buffer.c (Fprevious_overlay_change): Remove var that is set
13111 but not used.
13112
e5a2a5cb
PE
13113 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13114 Remove vars that are set but not used.
8d84a6eb 13115 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13116 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13117
a60e5f68
PE
13118 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13119
f661cb61 13120 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13121 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13122
f0397f5a
PE
13123 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13124 that are set but not used.
13125
8664db06 13126 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13127 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13128
6abdaa4a
PE
13129 * xselect.c (x_get_local_selection, x_handle_property_notify):
13130 Remove vars that are set but not used.
13131
0ce7538d 13132 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13133 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13134
9ae848fc
PE
13135 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13136 Remove var that is set but not used.
0b918413
PE
13137 (scroll_bar_windows_size): Now size_t, not int.
13138 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13139 Check for overflow.
9ae848fc 13140
a5a62657
PE
13141 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13142 (map_tty_color) [!defined MSDOS]: Likewise.
13143
5c5cdd39
PE
13144 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13145
66ebf983
PE
13146 * coding.c: Remove vars that are set but not used.
13147 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13148 All callers changed.
13149 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13150 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13151 (decode_coding_charset): Remove vars that are set but not used.
13152
1be4d761
PE
13153 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13154 that is set but not used.
13155
47553fa8
PE
13156 * print.c (print_object): Remove var that is set but not used.
13157
1f7196bf 13158 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13159 The gnulib version avoids calling malloc in the usual case,
13160 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13161 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13162 * filelock.c (current_lock_owner): Likewise.
13163 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13164 * sysdep.c: Include allocator.h, careadlinkat.h.
13165 (emacs_no_realloc_allocator): New static constant.
13166 (emacs_readlink): New function.
fdb61804
PE
13167 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13168 ../lib/careadlinkat.h.
d1fdcab7 13169
f84c17c7
SM
131702011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13171
13172 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13173 first non-nil return value).
13174
ef3862ad
JD
131752011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13176
13177 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13178 if not defined (Bug#8403).
13179
376a7006
JB
131802011-04-02 Juanma Barranquero <lekktu@gmail.com>
13181
13182 * xdisp.c (display_count_lines): Remove parameter `start',
13183 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13184 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13185 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13186 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13187 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13188 and thereabouts. All callers changed.
13189 (get_per_char_metric): Remove parameter `f', unused since
13190 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13191
6ca3801d
JM
131922011-04-02 Jim Meyering <meyering@redhat.com>
13193
13194 do not dereference NULL upon failed strdup
13195 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13196 (ns_get_family): Likewise.
13197
d8e2b5ba
JB
131982011-04-02 Juanma Barranquero <lekktu@gmail.com>
13199
13200 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13201
8c74fcbd
JD
132022011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13203
13204 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13205 later (Bug#8403).
13206
7200d79c
SM
132072011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13208
03408648 13209 Add lexical binding.
7200d79c 13210
03408648
SM
13211 * window.c (Ftemp_output_buffer_show): New fun.
13212 (Fsave_window_excursion):
13213 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13214
13215 * lread.c (lisp_file_lexically_bound_p): New function.
13216 (Fload): Bind Qlexical_binding.
13217 (readevalloop): Remove `evalfun' arg.
13218 Bind Qinternal_interpreter_environment.
13219 (Feval_buffer): Bind Qlexical_binding.
13220 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13221 Mark as dynamic.
13222 (syms_of_lread): Declare `lexical-binding'.
13223
13224 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13225
13226 * keyboard.c (eval_dyn): New fun.
13227 (menu_item_eval_property): Use it.
ca105506
SM
13228
13229 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13230
03408648
SM
13231 * fns.c (concat, mapcar1): Accept byte-code-functions.
13232
13233 * eval.c (Fsetq): Handle lexical vars.
13234 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13235 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13236 (FletX, Flet): Obey lexical binding.
13237 (Fcommandp): Handle closures.
13238 (Feval): New `lexical' arg.
13239 (eval_sub): New function extracted from Feval. Use it almost
13240 everywhere where Feval was used. Look up vars in lexical env.
13241 Handle closures.
13242 (Ffunctionp): Move from subr.el.
13243 (Ffuncall): Handle closures.
13244 (apply_lambda): Remove `eval_flags'.
13245 (funcall_lambda): Handle closures and new byte-code-functions.
13246 (Fspecial_variable_p): New function.
13247 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13248 but without exporting it to Lisp.
23aba0ea 13249
23aba0ea 13250 * doc.c (Fdocumentation, store_function_docstring):
03408648 13251 * data.c (Finteractive_form): Handle closures.
23aba0ea 13252
03408648
SM
13253 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13254 interactive spec.
ba83908c 13255
04f2d78b
CB
13256 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13257 New byte-codes.
03408648
SM
13258 (exec_byte_code): New function extracted from Fbyte_code to handle new
13259 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13260
03408648 13261 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13262
03408648 13263 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13264
e2abce01
JB
132652011-03-31 Juanma Barranquero <lekktu@gmail.com>
13266
13267 * xdisp.c (redisplay_internal): Fix prototype.
13268
63696a73 132692011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13270
63696a73 13271 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13272 (try_scrolling): Use it when setting scroll_limit.
13273 Limit scrolling to 100 screen lines.
63696a73
EZ
13274 (redisplay_window): Even when falling back on "recentering",
13275 position point in the window according to scroll-conservatively,
13276 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13277
13278 (try_scrolling): When point is above the window, allow searching
13279 as far as scroll_max, or one screenful, to compute vertical
13280 distance from PT to the scroll margin position. This prevents
13281 try_scrolling from unnecessarily failing when
13282 scroll-conservatively is set to a value slightly larger than the
13283 window height. Clean up the case of PT below the margin at bottom
13284 of window: scroll_max can no longer be INT_MAX. When aggressive
13285 scrolling is in use, don't let point enter the opposite scroll
13286 margin as result of the scroll.
13287 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13288 threshold of 100 lines for never-recentering scrolling.
13289
e4cc2dfc
JB
132902011-03-31 Juanma Barranquero <lekktu@gmail.com>
13291
13292 * dispextern.h (move_it_by_lines):
13293 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13294 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13295 (message_log_check_duplicate): Remove parameters `prev_bol' and
13296 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13297 (redisplay_internal): Remove parameter `preserve_echo_area',
13298 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13299
13300 * indent.c (Fvertical_motion):
13301 * window.c (window_scroll_pixel_based, Frecenter):
13302 Don't pass `need_y_p' to `move_it_by_lines'.
13303
1c470562
SM
133042011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13305
44f230aa
SM
13306 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13307 steal a few bits to be more compact.
13308 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13309 Remove unneeded casts.
13310
1c470562
SM
13311 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13312
888adce9
ZK
133132011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13314
13315 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13316 binding" message (bug#7967).
13317
f838ed7b
PE
133182011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13319
77861b95
PE
13320 Fix more problems found by GCC 4.6.0's static checks.
13321
de6dbc14
PE
13322 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13323 Remove unused local var.
13324
f838ed7b
PE
13325 * editfns.c (Fmessage_box): Remove unused local var.
13326
792c7b2b
PE
13327 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13328 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13329 Omit unused local vars.
c499e557 13330 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13331 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13332 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13333 Omit unused local var.
13334
ba0165e1
PE
13335 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13336 Don't assume string length fits in int.
32ad8845 13337 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13338 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13339
3c59b4c9
PE
13340 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13341 instead of alloca (Bug#8344).
13342
a3eed478 13343 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13344 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13345
eb4d412d
PE
13346 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13347
1658b401
PE
13348 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13349 concerns.
13350
13351 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13352
13353 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13354
9a2c6e05
PE
13355 * keyboard.c (syms_of_keyboard): Use the same style as later
13356 in this function when indexing through an array. This also
13357 works around GCC bug 48267.
13358
03d0a109
PE
13359 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13360
44f730c8
PE
13361 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13362
fe75f926
PE
13363 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13364 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13365
ffa8c828
PE
13366 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13367 This avoids undefined behavior on integer overflow, and is a bit
13368 more convenient anyway since it is compared to a size_t variable.
13369
c5101a77
PE
13370 Variadic C functions now count arguments with size_t, not int.
13371 This avoids an unnecessary limitation on 64-bit machines, which
13372 caused (substring ...) to crash on large vectors (Bug#8344).
13373 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13374 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13375 All variadic functions and their callers changed accordingly.
c5101a77
PE
13376 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13377 * data.c (arith_driver, float_arith_driver): Likewise.
13378 * editfns.c (general_insert_function): Likewise.
13379 * eval.c (struct backtrace.nargs, interactive_p)
13380 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13381 (funcall_lambda, mark_backtrace): Likewise.
13382 * fns.c (concat): Likewise.
13383 * frame.c (x_set_frame_parameters): Likewise.
13384 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13385 0 if not found, not -1. All callers changed.
13386
dd3f25f7
PE
13387 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13388 (stack_copy_size): Now size_t, not int.
13389 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13390
461c2ab9
JB
133912011-03-28 Juanma Barranquero <lekktu@gmail.com>
13392
13393 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13394 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13395 All callers changed.
13396
13397 * lisp.h (multibyte_char_to_unibyte):
13398 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13399 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13400 * character.h (CHAR_TO_BYTE8):
13401 * cmds.c (internal_self_insert):
13402 * editfns.c (general_insert_function):
13403 * keymap.c (push_key_description):
13404 * search.c (Freplace_match):
13405 * xdisp.c (message_dolog, set_message_1): All callers changed.
13406
f6d62986
SM
134072011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13408
13409 * keyboard.c (safe_run_hook_funcall): New function.
13410 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13411 don't set the hook to nil, but remove the offending function instead.
13412 (Qcommand_hook_internal): Remove, unused.
13413 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13414 Vcommand_hook_internal.
13415
13416 * eval.c (enum run_hooks_condition): Remove.
13417 (funcall_nil, funcall_not): New functions.
13418 (run_hook_with_args): Call each function through a `funcall' argument.
13419 Remove `cond' argument, now redundant.
13420 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13421 (Frun_hook_with_args_until_failure): Adjust accordingly.
13422 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13423
1db5b1ad
JB
134242011-03-28 Juanma Barranquero <lekktu@gmail.com>
13425
13426 * dispextern.h (string_buffer_position): Remove declaration.
13427
13428 * print.c (strout): Remove parameter `multibyte', unused since
13429 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13430
13431 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13432 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13433 All callers changed.
13434
13435 * w32.c (_wsa_errlist): Use braces for struct initializers.
13436
13437 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13438 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13439 All callers changed.
13440 (string_buffer_position): Likewise. Also, make static (it's never
13441 used outside xdisp.c).
13442 (cursor_row_p): Remove parameter `w', unused since
13443 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13444 (decode_mode_spec): Remove parameter `precision', introduced during
13445 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13446 All callers changed.
13447
5ffb62aa
JD
134482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13449
13450 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13451
461c2ab9 134522011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13453
13454 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13455 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13456 (ns_update_auto_hide_menu_bar): New functions.
13457 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13458 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13459 ns_constrain_all_frames.
13460 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13461 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13462
5c380ffb
JD
134632011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13464
13465 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13466
9af30bdf
GM
134672011-03-27 Glenn Morris <rgm@gnu.org>
13468
13469 * syssignal.h: Replace RETSIGTYPE with void.
13470 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13471 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13472 Replace SIGTYPE with void everywhere.
13473 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13474 * s/template.h (SIGTYPE): Remove commented out definition.
13475
e2abce01
JB
134762011-03-26 Eli Zaretskii <eliz@gnu.org>
13477
13478 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13479 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13480
f868cd8a
JB
134812011-03-26 Juanma Barranquero <lekktu@gmail.com>
13482
59eb0929
JB
13483 * w32.c (read_unc_volume): Use parameter `henum', instead of
13484 global variable `wget_enum_handle'.
13485
13486 * keymap.c (describe_vector): Remove parameters `indices' and
13487 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13488 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13489
f868cd8a
JB
13490 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13491
13492 * keyboard.c (timer_check): Remove parameter `do_it_now',
13493 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13494 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13495 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13496
13497 * keyboard.c (read_char):
13498 * w32menu.c (w32_menu_display_help):
13499 * xmenu.c (show_help_event, menu_help_callback):
13500 Adjust calls to `show_help_echo'.
13501
13502 * gtkutil.c (xg_maybe_add_timer):
13503 * keyboard.c (readable_events):
13504 * process.c (wait_reading_process_output):
13505 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13506
13507 * insdel.c (adjust_markers_gap_motion):
13508 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13509 (gap_left, gap_right): Don't call it.
13510
2ecf6fdb
CY
135112011-03-25 Chong Yidong <cyd@stupidchicken.com>
13512
13513 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13514 incurred during fontification.
13515
6b1f9ba4
JB
135162011-03-25 Juanma Barranquero <lekktu@gmail.com>
13517
13518 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13519 (DEFVAR_PER_BUFFER): Don't pass it.
13520
13521 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13522 (scrolling_window): Don't pass it.
13523
0f4a96b5
JB
135242011-03-25 Juanma Barranquero <lekktu@gmail.com>
13525
13526 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13527
13528 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13529 and `suffix'.
13530 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13531 of variables specific to SELinux and computation of `encoded_absname'.
13532
13533 * image.c (XPutPixel): Remove unused variable `height'.
13534
13535 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13536
13537 * unexw32.c (get_section_info): Remove unused variable `section'.
13538
13539 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13540 (system_process_attributes): Remove unused variable `sess'.
13541 (sys_read): Remove unused variable `err'.
13542
13543 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13544 (w32_wnd_proc): Remove unused variable `isdead'.
13545 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13546 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13547 (x_create_tip_frame): Remove unused variable `tem'.
13548
13549 * w32inevt.c (w32_console_read_socket):
13550 Remove unused variable `no_events'.
13551
13552 * w32term.c (x_draw_composite_glyph_string_foreground):
13553 Remove unused variable `width'.
13554
1149507c
JB
135552011-03-24 Juanma Barranquero <lekktu@gmail.com>
13556
13557 * w32term.c (x_set_glyph_string_clipping):
13558 Don't pass uninitialized region to CombineRgn.
13559
9c88f339
JB
135602011-03-23 Juanma Barranquero <lekktu@gmail.com>
13561
13562 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13563 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13564 (Fx_close_connection): Remove unused variable `i'.
13565
13566 * w32font.c (w32font_draw): Return number of glyphs.
13567 (w32font_open_internal): Remove unused variable `i'.
13568 (w32font_driver): Add missing initializer.
13569
13570 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13571 (fill_in_menu): Remove unused variable `items_added'.
13572
13573 * w32term.c (last_mouse_press_frame): Remove static global variable.
13574 (w32_clip_to_row): Remove unused variable `f'.
13575 (x_delete_terminal): Remove unused variable `i'.
13576
13577 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13578 (NOTHING): Remove unused static global variable.
13579 (uniscribe_check_otf): Remove unused variable `table'.
13580 (uniscribe_font_driver): Add missing initializers.
13581
dee091a3
JD
135822011-03-23 Julien Danjou <julien@danjou.info>
13583
13584 * term.c (Fsuspend_tty, Fresume_tty):
13585 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13586 * window.c (temp_output_buffer_show):
13587 * insdel.c (signal_before_change):
13588 * frame.c (Fhandle_switch_frame):
13589 * fileio.c (Fdo_auto_save):
13590 * emacs.c (Fkill_emacs):
13591 * editfns.c (save_excursion_restore):
13592 * cmds.c (internal_self_insert):
13593 * callint.c (Fcall_interactively):
13594 * buffer.c (Fkill_all_local_variables):
13595 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13596 Use Frun_hooks.
0f4a96b5 13597 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13598 unconditionally since it does the check itself.
dee091a3 13599
2c520ab5 136002011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13601
c9c49752
PE
13602 Fix more problems found by GCC 4.5.2's static checks.
13603
8abc3f12
PE
13604 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13605 the first time through the loop, since we know p0 < p1 then.
13606 This also avoids a gcc -Wstrict-overflow warning.
13607
a2d26660
PE
13608 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13609 leading to a memory leak, possible in functions like
13610 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13611 of objects (Bug#8318).
a2d26660 13612
916c72e9
PE
13613 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13614 that could (at least in theory) be that large.
13615
19ab8a18
PE
13616 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13617 This is less likely to overflow, and avoids undefined behavior if
13618 overflow does occur. All callers changed. Use strtoul to scan
13619 for the unsigned long integer.
b7cbbd6f
PE
13620 (pint2hrstr): Simplify and tune code slightly.
13621 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13622
f0641eff
PE
13623 * scroll.c (do_scrolling): Work around GCC bug 48228.
13624 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13625
7f650bb9
PE
13626 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13627 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13628 (validate_x_resource_name): Simplify count usage.
13629 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13630
37dd57d1
PE
13631 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13632 fail (Bug#8306).
81e56e61 13633
699979fc 13634 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13635
401bf9b4
PE
13636 * process.c (Fmake_network_process): Use socklen_t, not int,
13637 where POSIX says socklen_t is required in portable programs.
13638 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13639 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13640 (Fmake_network_process, server_accept_connection):
13641 (wait_reading_process_output, read_process_output):
13642 Likewise.
13643
b93aacde
PE
13644 * process.c: Rename or move locals to avoid shadowing.
13645 (list_processes_1, Fmake_network_process):
13646 (read_process_output_error_handler, exec_sentinel_error_handler):
13647 Rename or move locals.
4dc343ee 13648 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13649 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13650 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13651 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13652 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13653
af8a867c 13654 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13655 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13656 Include tparam.h instead, since it declares them.
af8a867c
PE
13657 * cm.h (PC): Remove extern decl; tparam.h now does this.
13658 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13659 * terminfo.c: Include tparam.h, to check interfaces.
13660 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13661 (tparam): Adjust signature to match interface in tparam.h;
13662 this removes some undefined behavior. Check that outstring and len
13663 are zero, which they always are with Emacs.
13664 * tparam.h (PC, BC, UP): New extern decls.
13665
0248044d 13666 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13667 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13668
8ff096c1 13669 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13670 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13671 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13672 (ftfont_list): Remove unused local.
49eaafba
PE
13673 (get_adstyle_property, ftfont_pattern_entity):
13674 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13675 Rename locals to avoid shadowing.
8ff096c1 13676
e2be39f6
PE
13677 * xfont.c (xfont_list_family): Mark var as initialized.
13678
c9735e30
PE
13679 * xml.c (make_dom): Now static.
13680
8f5201ae
PE
13681 * composite.c (composition_compute_stop_pos): Rename local to
13682 avoid shadowing.
b246f932
PE
13683 (composition_reseat_it): Remove unused locals.
13684 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13685 (composition_update_it): Mark var as initialized.
11b61122
PE
13686 (find_automatic_composition): Mark vars as initialized,
13687 with a FIXME (Bug#8290).
8f5201ae 13688
760fbc2c
PE
13689 character.h: Rename locals to avoid shadowing.
13690 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13691 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13692 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13693 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13694 to avoid shadowing.
13695
ff08eb85
PE
13696 * textprop.c (property_change_between_p): Remove; unused.
13697
fc7bf025
PE
13698 * intervals.c (interval_start_pos): Now static.
13699
235d7abc
PE
13700 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13701
44f230aa
SM
13702 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13703 Rename locals to avoid shadowing.
3e7d6594 13704
50060332
PE
13705 * sound.c (wav_play, au_play, Fplay_sound_internal):
13706 Fix pointer signedness.
d01f234b 13707 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13708 (wav_play): Initialize a variable to 0, to prevent undefined
13709 behavior (Bug#8278).
50060332 13710
c4fc4e30
PE
13711 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13712
918436ed
PE
13713 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13714
c939f91b
PE
13715 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13716 clobbering (Bug#8298).
b9c7f648
PE
13717 * sysdep.c (sys_subshell): Likewise.
13718 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13719
6bd8c144
PE
13720 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13721 This should get cleaned up, so that child_setup has the
13722 same signature on all platforms.
13723
7710357c 13724 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13725 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13726
c59da222
CY
137272011-03-22 Chong Yidong <cyd@stupidchicken.com>
13728
13729 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13730 not to be necessary, and produces flickering.
13731
66b87493
GM
137322011-03-20 Glenn Morris <rgm@gnu.org>
13733
13734 * config.in: Remove file.
13735
45b6f6d5
JB
137362011-03-20 Juanma Barranquero <lekktu@gmail.com>
13737
13738 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13739 are now in src/globals.h.
13740 (syms_of_minibuf): Remove spurious & from previous change.
13741
cd394be1 137422011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13743
13744 * minibuf.c (completing-read-function): New variable.
13745 (completing-read-default): Rename from completing-read.
13746 (completing-read): Call completing-read-function.
13747
b14e3e21
CY
137482011-03-19 Juanma Barranquero <lekktu@gmail.com>
13749
13750 * xfaces.c (Fx_load_color_file):
13751 Read color file from absolute filename (bug#8250).
13752
f2b726e6
JB
137532011-03-19 Juanma Barranquero <lekktu@gmail.com>
13754
13755 * makefile.w32-in: Update dependencies.
13756
09f6ff02
EZ
137572011-03-17 Eli Zaretskii <eliz@gnu.org>
13758
13759 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13760
29a6015a
PE
137612011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13762
a3a6c54e
PE
13763 Fix more problems found by GCC 4.5.2's static checks.
13764
b766f867
PE
13765 * process.c (make_serial_process_unwind, send_process_trap):
13766 (sigchld_handler): Now static.
13767
be02381c
PE
13768 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13769 That way, the code declares only the vars that it needs.
13770 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13771 * s/cygwin.h (PTY_ITERATION): Likewise.
13772 * s/darwin.h (PTY_ITERATION): Likewise.
13773 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13774
57048744
PE
13775 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13776 * process.c (allocate_pty): Don't declare stb unless it's needed.
13777
7914961c 13778 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13779 (CONSTANTLIM): Remove; unused.
13780 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13781 Define only if needed.
7914961c 13782
b3967b18
PE
13783 * unexelf.c (unexec): Name an expression,
13784 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13785 Use a different way to cause a compilation error if anyone uses
13786 n rather than nn, a way that does not involve shadowing.
73366a00 13787 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13788
29a6015a
PE
13789 * deps.mk (unexalpha.o): Remove; unused.
13790
43cfc33e 13791 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13792 * unexec.h: New file.
ce701a33
PE
13793 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13794 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13795 Depend on unexec.h.
13796 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13797 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13798 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13799 Change as necessary to match prototype in unexec.h.
ce701a33 13800
01f44d5a
PE
13801 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13802 shadowing.
4f63c6bb 13803 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13804
a6670b0b
PE
13805 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13806 Rename locals to avoid shadowing.
13807
cef2010d 13808 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13809 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13810
d4d7173a
PE
13811 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13812
f08b802a
PE
13813 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13814 warning when compiling print.c.
13815
3ddb0639
PE
13816 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13817 instead of using an uninitialized var.
5ad03b97 13818 (font_sort_entities): Mark var as initialized.
3ddb0639 13819
170a2692
PE
13820 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13821
e663c700
PE
13822 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13823 pointers to constants.
89bc529a 13824 (font_parse_fcname): Remove unused vars.
7b81e2d0 13825 (font_delete_unmatched): Now static.
ea838e10 13826 (font_get_spec): Remove; unused.
13a547c6
PE
13827 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13828 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13829 Rename or move locals to avoid shadowing.
e663c700 13830
2a80c887 13831 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13832 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13833
1384fa33 13834 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13835 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13836
8b2c52e9
PE
13837 * alloc.c (mark_backtrace): Move decl from here ...
13838 * lisp.h: ... to here, so that it can be checked.
13839
475545b5 13840 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13841 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13842 (lisp_indirect_variable): Name an expression,
13843 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13844 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13845
b1349114 13846 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13847 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13848 Use const pointer when appropriate.
b1349114 13849
a2928364
PE
13850 * lisp.h (get_system_name, get_operating_system_release):
13851 Move decls here, to check interfaces.
13852 * process.c (get_operating_system_release): Move decl to lisp.h.
13853 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13854 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13855 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13856 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13857 (Fformat_time_string, Fencode_time, Finsert_char):
13858 (Ftranslate_region_internal, Fformat):
13859 Rename or remove local vars to avoid shadowing.
9710023e 13860 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13861
a415e694
PE
13862 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13863 avoid shadowing.
13864
8ef4622d
PE
13865 * lisp.h (eassert): Check that the argument compiles, even if
13866 ENABLE_CHECKING is not defined.
13867
946f9a5b
PE
13868 * data.c (Findirect_variable): Name an expression, to avoid
13869 gcc -Wbad-function-cast warning.
112396d6 13870 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13871 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13872 (Fmake_variable_buffer_local, Fmake_local_variable):
13873 Mark variables as initialized.
52746918 13874 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13875
e5aab7e7 13876 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13877 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13878 Rename locals to avoid shadowing.
dff45157
PE
13879 (mark_stack): Move local variables into the #ifdef region where
13880 they're used.
7bc26fdb
PE
13881 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13882 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13883 needed otherwise.
13884 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13885 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13886 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13887
e5aab7e7
PE
13888 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13889 avoids undefined behavior in theory.
13890
4da60324
PE
13891 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13892
88043301
PE
13893 Use functions, not macros, for up- and down-casing (Bug#8254).
13894 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13895 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13896 to use the following functions instead of these macros.
13897 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13898 EMACS_INT, since callers assume the returned value fits in int.
13899 (upcase1): Likewise, for UPCASE_TABLE.
13900 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13901 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13902 the race-condition problem in the old DOWNCASE.
88043301 13903
19ed5445
PE
13904 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13905 Rename locals to avoid shadowing.
13906 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13907 (regex_compile, re_search_2, re_match_2_internal):
13908 Remove unused local vars.
952db0d7
PE
13909 (FREE_VAR): Rewrite so as not to use empty "else",
13910 which gcc can warn about.
da053e48 13911 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13912 (RETALLOC_IF): Define only if needed.
13913 (WORDCHAR_P): Likewise. This one is never needed, but is used
13914 only in a comment talking about a compiler bug, so put inside
13915 the #if 0 of that comment.
13916 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13917 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13918 Remove; unused.
19ed5445 13919
1f3561e4 13920 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13921 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13922 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13923
ded6f8f7
PE
13924 * search.c (simple_search): Remove unused var.
13925
dbd37a95
PE
13926 * dired.c (compile_pattern): Move decl from here ...
13927 * lisp.h: ... to here, so that it can be checked.
13928 (struct re_registers): New forward decl.
13929
7e47afad
PE
13930 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13931
85f24f61
PE
13932 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13933 All uses changed.
13934 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13935 Rename locals to avoid shadowing.
5671df8f 13936 (Fvertical_motion): Mark locals as initialized.
85f24f61 13937
181aa2be 13938 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13939 (casify_region): Mark local as initialized.
181aa2be 13940
930d429c
PE
13941 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13942
7082eac6
PE
13943 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13944 New macros, so that the caller can use some names other than
13945 gcpro1, gcpro2, etc.
13946 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13947 of the new macros.
13948 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13949 argument, for consistency with GCPRO2_VAR, etc: it is now the
13950 prefix of the variable, not the variable itself. All uses
13951 changed.
38b2c076
PE
13952 * dired.c (directory_files_internal, file_name_completion):
13953 Rename locals to avoid shadowing.
13954
15206ed9
PE
13955 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13956 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13957 dired.c's scmp function, had undefined behavior.
13958 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13959 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13960 * buffer.h: ... to here, because these macros use current_buffer,
13961 and the new implementation with inline functions needs to have
13962 current_buffer in scope now, rather than later when the macros
13963 are used.
13964 (downcase, upcase1): New static inline functions.
13965 (DOWNCASE, UPCASE1): Reimplement using these functions.
13966 This avoids undefined behavior in expressions like
13967 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13968 from race conditions in accessing the global variables
13969 case_temp1 and case_temp2.
13970 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13971 * lisp.h (case_temp1, case_temp2): Remove their decls.
13972 * character.h (ASCII_CHAR_P): Move from here ...
13973 * lisp.h: ... to here, so that the inline functions mentioned
13974 above can use them.
13975
4a6bea26
PE
13976 * dired.c (directory_files_internal_unwind): Now static.
13977
f14b7e14
PE
13978 * fileio.c (file_name_as_directory, directory_file_name):
13979 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13980 Now static.
2893f146
PE
13981 (file_name_as_directory): Use const pointers when appropriate.
13982 (Fexpand_file_name): Likewise. In particular, newdir might
13983 point at constant storage, so make it a const pointer.
fd4ead52 13984 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13985 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13986 signedness issues.
f839df0c
PE
13987 (Fset_file_times, Finsert_file_contents, auto_save_error):
13988 Rename locals to avoid shadowing.
f14b7e14 13989
5716756e 13990 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13991 (Ftry_completion, Fall_completions): Rename or remove locals
13992 to avoid shadowing.
5716756e 13993
b4c3046a
PE
13994 * marker.c (bytepos_to_charpos): Remove; unused.
13995
b45db522
PE
13996 * lisp.h (verify_bytepos, count_markers): New decls,
13997 so that gcc does not warn that these functions aren't declared.
13998
85876d07
PE
13999 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14000 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14001 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14002 (copy_text): Remove unused local var.
85876d07 14003
03d78a21 14004 * filelock.c (within_one_second): Now static.
b3dd38ab 14005 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14006
5df8f01b
PE
14007 * buffer.c (fix_overlays_before): Mark locals as initialized.
14008 (fix_start_end_in_overlays): Likewise. This function should be
14009 simplified by using pointers-to-pointers, but that's a different
14010 matter.
b1d876f1 14011 (switch_to_buffer_1): Now static.
8f54f30a
PE
14012 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14013 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14014
a70072c9 14015 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14016 Fix pointer signedness issue.
edced198
PE
14017 (sys_subshell): Mark local as volatile if checking for lint,
14018 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14019 (MAXPATHLEN): Define only if needed.
a70072c9 14020
a0977c44
PE
14021 * process.c (serial_open, serial_configure): Move decls from here ...
14022 * systty.h: ... to here, so that they can be checked.
14023
a884fdcc
PE
14024 * fns.c (get_random, seed_random): Move extern decls from here ...
14025 * lisp.h: ... to here, so that they can be checked.
14026
604efe86 14027 * sysdep.c (reset_io): Now static.
b8950c94 14028 (wait_for_termination_signal): Remove; unused.
604efe86 14029
38fc62d9
PE
14030 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14031 (copy_keymap_item, append_key, push_text_char_description):
14032 Now static.
1004a21a 14033 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14034 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14035 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14036 (describe_map_tree):
14037 Rename locals to avoid shadowing.
38fc62d9 14038
2f2650da
PE
14039 * keyboard.c: Declare functions static if they are not used elsewhere.
14040 (echo_char, echo_dash, cmd_error, top_level_2):
14041 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14042 (read_char, kbd_buffer_get_event, make_lispy_position):
14043 (make_lispy_event, make_lispy_movement, apply_modifiers):
14044 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14045 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14046 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14047 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14048 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14049
a053e86c 14050 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14051 (mark_kboards): Move decl here ...
14052 * alloc.c (mark_kboards): ... from here.
a053e86c 14053
4752793e
PE
14054 * lisp.h (force_auto_save_soon): New decl.
14055
74f10ca7 14056 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14057 (DEFINE_DUMMY_FUNCTION): New macro.
14058 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14059 Use it.
c03cd23f
PE
14060 (main): Add casts to avoid warnings
14061 if GCC considers string literals to be constants.
74f10ca7 14062
022e70d4
PE
14063 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14064
59d6fe83
PE
14065 * dbusbind.c: Pointer signedness fixes.
14066 (xd_signature, xd_append_arg, xd_initialize):
14067 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14068 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14069 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14070 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14071
78320123
PE
14072 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14073 if GCC considers string literals to be constants.
49cebcca 14074 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14075
35ac2a97
SM
140762011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14077
fb103ca9
SM
14078 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14079 (print_preprocess, print_object): New macro to fix last change.
14080
35ac2a97
SM
14081 * print.c (print_preprocess): Don't forget font objects.
14082
62973b41
JB
140832011-03-16 Juanma Barranquero <lekktu@gmail.com>
14084
14085 * emacs.c (USAGE3): Doc fixes.
14086
0e48bb22
AS
140872011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14088
14089 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14090 structure.
14091
7684e57b
JB
140922011-03-14 Juanma Barranquero <lekktu@gmail.com>
14093
14094 * lisp.h (VWindow_system, Qfile_name_history):
14095 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14096 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14097 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14098
14099 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14100 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14101
14102 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14103 * w32console.c (detect_input_pending, read_input_pending)
14104 (encode_terminal_code):
14105 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14106 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14107 (w32_system_caret_y, Qfile_name_history):
14108 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14109 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14110 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14111 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14112 * w32proc.c (Qlocal, report_file_error):
14113 * w32term.c (Vwindow_system, updating_frame):
14114 * w32uniscribe.c (initialized, uniscribe_font_driver):
14115 Remove unneeded extern declarations.
14116
2aa46d6c
CY
141172011-03-14 Chong Yidong <cyd@stupidchicken.com>
14118
c96bbc66 14119 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14120
cffc6f3b
CY
141212011-03-13 Chong Yidong <cyd@stupidchicken.com>
14122
14123 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14124 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14125 These macros can no longer be used for assignment.
14126
44f230aa
SM
14127 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14128 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14129 (record_buffer_markers, fetch_buffer_markers): New functions for
14130 recording and fetching special buffer markers.
14131 (set_buffer_internal_1, set_buffer_temp): Use them.
14132
14133 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14134
14135 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14136
14137 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14138 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14139
14140 * xdisp.c (hscroll_window_tree):
14141 (reconsider_clip_changes): Use PT instead of BUF_PT.
14142
d251f04b
EZ
141432011-03-13 Eli Zaretskii <eliz@gnu.org>
14144
14145 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14146 $(EMACS_ROOT)/lib/intprops.h.
14147
f0c77cd1
PE
141482011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14149
3eca4629
PE
14150 Fix more problems found by GCC 4.5.2's static checks.
14151
7c86ee98
PE
14152 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14153 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14154 (xg_free_frame_widgets): Make it clear that a local variable is
14155 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14156 (gdk_window_get_screen): Make it clear that this macro is needed
14157 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14158 (int_gtk_range_get_value): New function, which avoids a diagnostic
14159 from gcc -Wbad-function-cast.
14160 (xg_set_toolkit_scroll_bar_thumb): Use it.
14161 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14162 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14163 (get_utf8_string, xg_get_file_with_chooser):
14164 Rename locals to avoid shadowing.
14165 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14166
41729b81
PE
14167 * xgselect.c (xg_select): Remove unused var.
14168
f0c77cd1
PE
14169 * image.c (four_corners_best): Mark locals as initialized.
14170 (gif_load): Initialize transparent_p to zero (Bug#8238).
14171 Mark another local as initialized.
ec6cf4c6 14172 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14173
ce0ad53d 14174 * image.c (clear_image_cache): Now static.
d5d5a617 14175 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14176 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14177 (x_edge_detection): Remove unnecessary cast that
14178 gcc -Wbad-function-cast diagnoses.
2037898d 14179 (gif_load): Fix pointer signedness.
6ae141d6
PE
14180 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14181 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14182
33383987 141832011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14184
d32df629
PE
14185 Improve quality of tests for time stamp overflow.
14186 For example, without this patch (encode-time 0 0 0 1 1
14187 1152921504606846976) returns the obviously-bogus value (-948597
14188 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14189 reports time overflow. See
14190 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14191 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14192 * editfns.c: Include limits.h and intprops.h.
14193 (TIME_T_MIN, TIME_T_MAX): New macros.
14194 (time_overflow): Move earlier, to before first use.
14195 (hi_time, lo_time): New functions, for an accurate test for
14196 out-of-range times.
14197 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14198 (Fget_internal_run_time): Don't assume time_t fits in int.
14199 (make_time): Use list2 instead of Fcons twice.
14200 (Fdecode_time): More accurate test for out-of-range times.
14201 (check_tm_member): New function.
14202 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14203 (lisp_time_argument): Don't rely on undefined left-shift and
14204 right-shift behavior when checking for time stamp overflow.
8be6f318 14205
fe31d94c
PE
14206 * editfns.c (time_overflow): New function, refactoring common code.
14207 (Fformat_time_string, Fdecode_time, Fencode_time):
14208 (Fcurrent_time_string): Use it.
14209
8be6f318
PE
14210 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14211 * dired.c (make_time): Move to ...
14212 * editfns.c (make_time): ... here.
14213 * systime.h: Note the move.
14214
09d9db2c 142152011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14216
126bc0dc
YM
14217 * fringe.c (update_window_fringes): Remove unused variables.
14218
c47cbdfd
YM
14219 * unexmacosx.c (copy_data_segment): Also copy __got section.
14220 (Bug#8223)
14221
7ac80be9
EZ
142222011-03-12 Eli Zaretskii <eliz@gnu.org>
14223
c96bbc66 14224 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14225 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14226 Constify `char *' arguments and their references according to
14227 prototypes in tparam.h.
14228
ecb0f94d 14229 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14230
7ac80be9
EZ
14231 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14232 Adapt all references accordingly.
14233
14234 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14235
ef1fd07e
TT
142362011-03-11 Tom Tromey <tromey@redhat.com>
14237
14238 * buffer.c (syms_of_buffer): Remove obsolete comment.
14239
7ef4b50c
EZ
142402011-03-11 Eli Zaretskii <eliz@gnu.org>
14241
14242 * termhooks.h (encode_terminal_code): Declare prototype.
14243
14244 * msdos.c (encode_terminal_code): Don't declare prototype.
14245
14246 * term.c (encode_terminal_code): Now external again, used by
14247 w32console.c and msdos.c.
14248
44f230aa
SM
14249 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14250 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14251
4b1ec863 142522011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14253
1714f52b 14254 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14255
4b1ec863
PE
14256 * fringe.c (update_window_fringes): Mark locals as initialized
14257 (Bug#8227).
14258 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14259
524c7aa6
PE
14260 * alloc.c (mark_fringe_data): Move decl from here ...
14261 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14262 to check its interface.
14263 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14264
a5c0af81 14265 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14266 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14267 (fontset_font): Mark local as initialized.
a9a06e0b 14268 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14269
b4716021
PE
14270 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14271
811e9bac 14272 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14273 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14274 (x_own_selection, Fx_disown_selection_internal): Rename locals
14275 to avoid shadowing.
14276 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14277
7e3ab302
PE
14278 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14279 so that the caller can use some name other than gcpro1.
14280 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14281 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14282 (Fx_backspace_delete_keys_p):
14283 Use them to avoid shadowing, and rename vars to avoid shadowing.
14284 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14285 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14286 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14287 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14288 Remove unused locals.
7e3ab302
PE
14289 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14290 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14291 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14292 macros.
f78faa98 14293
e2b13473
PE
14294 * xterm.h (x_mouse_leave): New decl.
14295
77f23912
PE
14296 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14297 Remove unused functions.
cdf4ba58
PE
14298 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14299 (x_calc_absolute_position): Now static.
7411c686 14300 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14301 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14302 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14303 unless they are used.
38d0b34a
PE
14304 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14305 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14306 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14307 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14308 (x_error_catcher, x_connection_closed, x_error_handler):
14309 (x_error_quitter, xembed_send_message, x_iconify_frame):
14310 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14311 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14312 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14313
44f230aa
SM
14314 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14315 Rename or move locals to avoid shadowing.
6b463e58 14316 (tty_defined_color, merge_face_heights): Now static.
5967d051 14317 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14318 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14319 does not deduce is never used uninitialized.
73719eba
PE
14320 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14321 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14322
426994c3 14323 * terminal.c (store_terminal_param): Now static.
5489860b 14324
032f1620 14325 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14326 (set_frame_menubar): Remove unused local.
d4323972 14327 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14328 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14329 since they might point to immutable storage.
281585b0
PE
14330 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14331 since it's unused otherwise.
032f1620 14332
367c19e5 14333 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14334 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14335 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14336 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14337 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14338 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14339 does not deduce are never used uninitialized.
70739cbe 14340
07b48fa9
PE
14341 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14342
8868a238 14343 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14344 * window.c (window_loop, size_window):
14345 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14346
7e5cf297 14347 * window.c (display_buffer): Now static.
d6550a9f
PE
14348 (size_window): Mark variables that gcc -Wuninitialized
14349 does not deduce are never used uninitialized.
a586633d
PE
14350 * window.h (check_all_windows): New decl, to forestall
14351 gcc -Wmissing-prototypes diagnostic.
5b555da1 14352 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14353
f6095868
PE
14354 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14355 shadowing.
14356 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14357 Include <limits.h>.
14358 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14359 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14360 (load_charset_map): Mark variables that gcc -Wuninitialized
14361 does not deduce are never used uninitialized.
53df7c11 14362 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14363
f38b440c
PE
14364 * coding.c (coding_set_source, coding_set_destination):
14365 Use "else { /* comment */ }" rather than "else /* comment */;"
14366 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14367 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14368 a block, when the outer 'i' will do.
14369 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14370 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14371 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14372 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14373 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14374 Rename locals to avoid shadowing.
14375 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14376 * coding.c (emacs_mule_char, encode_invocation_designation):
14377 Now static, since they're not used elsewhere.
413bb2db 14378 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14379 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14380 (decode_coding_emacs_mule): Mark variables that gcc
14381 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14382 (detect_coding_iso_2022): Initialize a local variable that might
14383 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14384 this initialization is needed. (Bug#8211)
5f58e762
PE
14385 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14386 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14387 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14388 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14389 Remove unused macros.
f38b440c 14390
232b38b9 14391 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14392 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14393 * character.c (string_count_byte8): Likewise.
232b38b9 14394
fb90da1b
PE
14395 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14396 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14397
fb93dbc2
PE
14398 * chartab.c (copy_sub_char_table): Now static, since it's not used
14399 elsewhere.
5c156ace
PE
14400 (sub_char_table_ref_and_range, char_table_ref_and_range):
14401 Rename locals to avoid shadowing.
bbcd0949 14402 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14403
7d3b3862 14404 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14405 (BIDI_BOB): Remove unused macro.
7d3b3862 14406
6be7d3da
PE
14407 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14408 deduce are never used uninitialized.
c2ed9c8b 14409 * term.c (encode_terminal_code): Likewise.
6be7d3da 14410
75f8807f 14411 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14412
50938595
PE
14413 * tparam.h: New file.
14414 * term.c, tparam.h: Include it.
14415 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14416 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14417 Move these decls to tparam.h, and make them agree with what
14418 is actually in tparam.c. The previous trick of using incompatible
14419 decls in different modules does not conform to the C standard.
14420 All callers of tparam changed to use tparam's actual API.
14421 * tparam.c (tparam1, tparam, tgoto):
14422 Use const pointers where appropriate.
14423
fbceeba2
PE
14424 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14425 * cm.h (struct cm): Likewise.
14426 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14427 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14428 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14429 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14430 (turn_on_face, init_tty): Likewise.
14431 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14432
7f3f1250
PE
14433 * term.c (term_mouse_position): Rename local to avoid shadowing.
14434
e6ca6543
PE
14435 * alloc.c (mark_ttys): Move decl from here ...
14436 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14437
c40f8d15
AS
144382011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14439
14440 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14441
cfe0661d
JB
144422011-03-09 Juanma Barranquero <lekktu@gmail.com>
14443
14444 * search.c (compile_pattern_1): Remove argument regp, unused since
14445 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14446 (compile_pattern): Don't pass it.
14447
0afb4571
J
144482011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14449
14450 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14451 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14452 for ! HAVE_GTK3.
14453 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14454
14455 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14456
14457 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14458 gdk_window_get_screen, gdk_window_get_geometry,
14459 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14460 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14461 (xg_get_pixbuf_from_pixmap): New function.
14462 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14463 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14464 Call xg_get_pixbuf_from_pixmap instead of
14465 gdk_pixbuf_get_from_drawable.
14466 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14467 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14468 (xg_check_special_colors): Use GtkStyleContext and its functions
14469 for HAVE_GTK3.
14470 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14471 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14472 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14473 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14474 Call gtk_widget_get_preferred_size.
0afb4571
J
14475 (xg_frame_resized): gdk_window_get_geometry only takes 5
14476 parameters.
44f230aa
SM
14477 (xg_win_to_widget, xg_event_is_for_menubar):
14478 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14479 (xg_set_widget_bg): New function.
14480 (delete_cb): New function.
895009e1 14481 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14482 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14483 (xg_set_background_color): Call xg_set_widget_bg.
14484 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14485 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14486 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14487 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14488 if ! HAVE_GTK3.
14489 (update_frame_tool_bar): Call gtk_widget_hide.
14490 (xg_initialize): Use GDK_KEY_g.
14491
14492 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14493 if ! HAVE_GTK3
14494 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14495
14496 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14497 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14498 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14499
1c2cc4ef
JB
145002011-03-08 Juanma Barranquero <lekktu@gmail.com>
14501
14502 * w32xfns.c (select_palette): Check success of RealizePalette against
14503 GDI_ERROR, not zero.
14504
33383987 14505See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14506
14507;; Local Variables:
14508;; coding: utf-8
aac0c6e3
MR
14509;; End:
14510
2f097256 14511 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14512
14513 This file is part of GNU Emacs.
14514
14515 GNU Emacs is free software: you can redistribute it and/or modify
14516 it under the terms of the GNU General Public License as published by
14517 the Free Software Foundation, either version 3 of the License, or
14518 (at your option) any later version.
14519
14520 GNU Emacs is distributed in the hope that it will be useful,
14521 but WITHOUT ANY WARRANTY; without even the implied warranty of
14522 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14523 GNU General Public License for more details.
14524
14525 You should have received a copy of the GNU General Public License
14526 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.