Fix bidi cursor motion when a line begins with a composed character.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
54a1215b
EZ
12011-08-19 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4 a composition, take its buffer position from IT->cmp_it.charpos.
5 Fixes cursor positioning at the beginning of a line that begins
6 with a composed character.
7
9778ebcc
EZ
82011-08-18 Eli Zaretskii <eliz@gnu.org>
9
0be6ee06
EZ
10 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
11 character bidirectional type, use STRONG_L instead. Fixes crashes
12 in a buffer produced by `describe-categories'.
13
9778ebcc
EZ
14 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
15 members before the level stack, so they would be saved and
16 restored when copying iterator state. Fixes incorrect reordering
17 around TABs covered by display properties.
18
156bffbe
AS
192011-08-18 Andreas Schwab <schwab@linux-m68k.org>
20
21 * process.c (Fnetwork_interface_list): Correctly determine buffer
22 size.
23
72ad093b
CY
242011-08-17 Chong Yidong <cyd@stupidchicken.com>
25
26 * eval.c (internal_condition_case, internal_condition_case_1)
27 (internal_condition_case_2, internal_condition_case_n): Remove
28 unnecessary aborts (Bug#9081).
29
35774242
EZ
302011-08-17 Eli Zaretskii <eliz@gnu.org>
31
32 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
33 has no `load' handler, try opening the file locally. (Bug#9311)
34
db76dd85
KB
352011-08-16 Ken Brown <kbrown@cornell.edu>
36
37 * gmalloc.c: Expand comment.
38
b215eee5
EZ
392011-08-16 Eli Zaretskii <eliz@gnu.org>
40
41 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
42 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
43
a4579d33
KB
442011-08-16 Ken Brown <kbrown@cornell.edu>
45
46 Fix memory allocation problems in Cygwin build (Bug#9273).
47
48 * unexcw.c ( __malloc_initialized): Declare external variable.
49 (fixup_executable): Force the dumped emacs to reinitialize malloc.
50
51 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
52 variables.
53 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
54 dumped emacs.
55 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
56 in the static heap.
57 [CYGWIN] (special_realloc): New function.
58 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
59 requests to realloc storage in the static heap.
60
3ebec551
PE
612011-08-15 Paul Eggert <eggert@cs.ucla.edu>
62
63 * bidi.c (bidi_initialize): Remove unused local.
64
9fd8be00
EZ
652011-08-15 Eli Zaretskii <eliz@gnu.org>
66
474a8465
EZ
67 * biditype.h: File removed.
68
69 * bidimirror.h: File removed.
70
71 * deps.mk (bidi.o): Remove biditype.h and
72 bidimirror.h.
73
74 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
75 bidimirror.h.
76
77 * dispextern.h: Fix a typo in the comment to bidi_type_t.
78
79 * chartab.c: Improve commentary for the uniprop_table API.
80
32413314
EZ
81 * bidi.c (bidi_paragraph_init): Support zero value of
82 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
83 (bidi_initialize): Use uniprop_table instead of including
84 biditype.h and bidimirror.h.
32413314 85
9fd8be00
EZ
86 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
87 coordinates of the iterator when restoring from ppos_it.
88 (Bug#9296)
89
5cf2b69b
KH
902011-08-14 Kenichi Handa <handa@m17n.org>
91
92 * process.c (create_process): Call setup_process_coding_systems
72ad093b 93 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 94
daf17d00
EZ
952011-08-14 Eli Zaretskii <eliz@gnu.org>
96
97 * xdisp.c (move_it_in_display_line_to): Don't invoke
98 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
99 ppos_it. Fixes vertical cursor motion when line beginning is
100 covered by an image. (Bug#9296)
101
08e3161a
JD
1022011-08-14 Jan Djärv <jan.h.d@swipnet.se>
103
104 * nsterm.h (ns_run_ascript): Declare.
105 (NSAPP_DATA2_RUNASSCRIPT): Define.
106
107 * nsfns.m (as_script, as_result, as_status): New static variables.
108 (ns_run_ascript): New function.
109 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
110 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
111 the event loop. Get status from as_status (Bug#7276).
112
113 * nsterm.m (sendEvent): If event is NSApplicationDefined and
114 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
115 the event loop (Bug#7276).
116
a3720aa2
AS
1172011-08-14 Andreas Schwab <schwab@linux-m68k.org>
118
119 * gnutls.c (QCgnutls_bootprop_priority)
120 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
121 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
122 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
123 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
124 (QCgnutls_bootprop_verify_hostname_error)
125 (QCgnutls_bootprop_callbacks_verify): Rename from
126 Qgnutls_bootprop_..., all uses changed.
127
128 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
129 uses changed.
130
0a0d27fb
PE
1312011-08-14 Paul Eggert <eggert@cs.ucla.edu>
132
19d5c50c
PE
133 * xfaces.c (Qframe_set_background_mode): Now static.
134 * dispextern.h (Qframe_set_background_mode): Remove decl.
135
0a0d27fb
PE
136 * process.c (Fnetwork_interface_info): Declare local only if needed.
137
377538cb
JD
1382011-08-13 Jan Djärv <jan.h.d@swipnet.se>
139
140 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
141 (Fnetwork_interface_list): Allocate in increments of bytes instead
142 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
143 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
144 sockaddr.
145 (struct ifflag_def): notrailers is smart on OSX.
146 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
147 Get hardware address with getifaddrs if available.
148
08fff70c
EZ
1492011-08-12 Eli Zaretskii <eliz@gnu.org>
150
151 * xdisp.c (iterate_out_of_display_property): xassert that
152 IT->position is set to within IT->object's boundaries. Break from
153 the loop as soon as EOB is reached; avoids infloops in redisplay
154 when IT->position is set up wrongly due to some bug. Set
155 IT->current to match the bidi iterator unconditionally.
156 (push_display_prop): Allow GET_FROM_STRING as IT->method on
157 entry. Force push_it to save on the stack the current
158 buffer/string position, to be restored by pop_it. Fix flags in
159 the iterator structure wrt the object coming from a display
160 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
161 properties. (Bug#9284)
162
7be1c708 1632011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 164
7be1c708
CY
165 * fontset.c (fontset_get_font_group): Add proper type checks.
166 (Bug#9172)
aac0c6e3 167
7be1c708 1682011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 169
7be1c708
CY
170 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
171 and LC_VERSION_MIN_MACOSX.
172 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
173 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 174
97bb72a6
EZ
1752011-08-08 Eli Zaretskii <eliz@gnu.org>
176
177 * xdisp.c (forward_to_next_line_start): Allow to use the
757664a4
EZ
178 no-display-properties-and-no-overlays under bidi display. Set
179 disp_pos in the bidi iterator to avoid searches for display
180 properties and overlays.
97bb72a6 181
d5617611
CY
1822011-08-08 Chong Yidong <cyd@stupidchicken.com>
183
37e11a63
CY
184 * editfns.c (Fset_time_zone_rule): Document relationship with the
185 setenv function.
186
d5617611
CY
187 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
188 the font entity extracted from the cache (Bug#8109).
189
58872834
CY
1902011-08-07 Chong Yidong <cyd@stupidchicken.com>
191
192 * composite.c (autocmp_chars): Don't reset point. That is done by
193 restore_point_unwind (Bug#5984).
194
75bfc667
JL
1952011-08-07 Juri Linkov <juri@jurta.org>
196
197 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
198 to show the arg `TIME' instead of `TIMEVAL'.
199
d1410150
EZ
2002011-08-06 Eli Zaretskii <eliz@gnu.org>
201
202 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
203 display property strides EOL and includes a newline, as in
204 longlines-mode. (Bug#9254)
75b771e4
EZ
205 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
206 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
207
208 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
209 is non-zero, even if the data buffer is NULL. Fixes a crash in
210 vertical-motion with longlines-mode. (Bug#9254)
211
35928349
EZ
2122011-08-05 Eli Zaretskii <eliz@gnu.org>
213
ec7cc85b
EZ
214 * bidi.c <bidi_cache_total_alloc>: Now static.
215 (bidi_initialize): Initialize bidi_cache_total_alloc.
216
35928349
EZ
217 *xdisp.c (display_line): Release buffer allocated for shelved bidi
218 cache. (Bug#9221)
219
220 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
221 amount allocated this far in `bidi_cache_total_alloc'.
222 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
223 non-zero, only free the data buffer without restoring the cache
224 contents. All callers changed.
225
226 * dispextern.h (bidi_unshelve_cache): Update prototype.
227
228 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
229 (move_it_in_display_line, move_it_to)
230 (move_it_vertically_backward, move_it_by_lines): Replace the call
231 to xfree to an equivalent call to bidi_unshelve_cache.
232 (move_it_in_display_line_to): Fix logic of returning
412b6358 233 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 234
e2e2423b
EZ
2352011-08-05 Eli Zaretskii <eliz@gnu.org>
236
237 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
238 came from a string character with a `cursor' property. (Bug#9229)
239
ae9e757a
JD
2402011-08-04 Jan Djärv <jan.h.d@swipnet.se>
241
242 * Makefile.in (LIB_PTHREAD): New variable.
243 (LIBES): Add LIB_PTHREAD (Bug#9216).
244
245 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
246 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
247
213bd7f2
AS
2482011-08-04 Andreas Schwab <schwab@linux-m68k.org>
249
250 * regex.c (re_iswctype): Remove some redundant boolean
251 conversions.
252
99aaf75f
JD
2532011-08-04 Jan Djärv <jan.h.d@swipnet.se>
254
255 * xterm.c (x_find_topmost_parent): New function.
256 (x_set_frame_alpha): Find topmost parent window with
257 x_find_topmost_parent and set the property there also (bug#9181).
258 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
259
c74e9d86
PE
2602011-08-04 Paul Eggert <eggert@cs.ucla.edu>
261
262 * callproc.c (Fcall_process): Avoid vfork clobbering
263 the local vars buffer, coding_systems, current_dir.
264
640c8776
SM
2652011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
266
267 * keymap.c (Fmake_composed_keymap): Move to subr.el.
268
f26d0e4c
PE
2692011-08-03 Paul Eggert <eggert@cs.ucla.edu>
270
8a10d76c
PE
271 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
272 so that it is not optimized away.
273
f26d0e4c
PE
274 * xdisp.c (compute_display_string_pos): Remove unused local.
275
55439c61
EZ
2762011-08-02 Eli Zaretskii <eliz@gnu.org>
277
278 Fix slow cursor motion and scrolling in large buffers with
279 selective display, like Org Mode buffers. (Bug#9218)
280
281 * dispextern.h (struct bidi_it): New member disp_prop_p.
282
283 * xdisp.c: Remove one-slot cache of display string positions.
284 (compute_display_string_pos): Accept an additional argument
285 DISP_PROP_P; callers changed. Scan at most 5K characters forward
286 for a display string or property. If found, set DISP_PROP_P
287 non-zero.
288
289 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
290 DISP_PROP_P, and pass it to compute_display_string_pos.
291 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
292 non-zero. All callers of bidi_fetch_char changed.
293
fb33fa43
SM
2942011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
295
296 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
297
b099e063
DM
2982010-12-03 Don March <don@ohspite.net>
299
300 * keymap.c (Fdefine_key): Fix non-prefix key error message when
301 last character M-[char] is translated to ESC [char] (bug#7541).
302
5cc7f7af
KH
3032011-08-02 Kenichi Handa <handa@m17n.org>
304
d0fffa3f 305 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
306
307 * chartab.c (uniprop_table): Make it non-static.
308
525d5e6e
EZ
3092011-08-01 Eli Zaretskii <eliz@gnu.org>
310
311 * xdisp.c (forward_to_next_line_start): Accept additional argument
312 BIDI_IT_PREV, and store into it the state of the bidi iterator had
313 on the newline.
314 (reseat_at_next_visible_line_start): Use the bidi iterator state
315 returned by forward_to_next_line_start to restore the state of
316 it->bidi_it after backing up to previous newline. (Bug#9212)
317
31011111
AS
3182011-07-30 Andreas Schwab <schwab@linux-m68k.org>
319
320 * regex.c (re_comp): Protoize.
321 (re_exec): Fix return type.
322 (regexec): Fix type of `ret'. (Bug#9203)
323
e5d76069
PE
3242011-07-29 Paul Eggert <eggert@cs.ucla.edu>
325
326 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
327 This is needed if max-image-size is a floating-point number.
328
9a79b20c
AS
3292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
330
331 * print.c (print_object): Print empty symbol as ##.
332
333 * lread.c (read1): Read ## as empty symbol.
334
d8c2fa78
AA
3352011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
336
337 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
338 setting frame foreground color (Bug#9175).
339 (x_set_background_color): Likewise.
340
ffe57a7a
AA
341 * nsmenu.m (-setText): Size tooltip dimensions precisely to
342 contents (Bug#9176).
343 (EmacsTooltip -init): Remove bezels and add shadows to
344 tooltip windows.
345
bf3492a5
AA
346 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
347 or scroll bar (Bug#8470).
348
d55e9c53
AA
349 * nsfont.m (nsfont_open): Remove assignment to voffset and
350 unnecessary vars hshink, expand, hd, full_height, min_height.
351 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
352
353 * nsterm.h (nsfont_info): Remove voffset field.
354
d8c2fa78 3552011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
356
357 Implement strike-through and overline on NextStep (Bug#8863).
358
359 * nsfont.m (nsfont_open): Use underline position provided by font,
360 instead of hard-coded value of 2.
361 (nsfont_draw): Call ns_draw_text_decoration instead.
362
363 * nsterm.h: Add declaration for ns_draw_text_decoration.
364
365 * nsterm.m (ns_draw_text_decoration): New function for drawing
366 underline, overline, and strike-through.
367 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
368 ns_draw_text_decoration. Change treatment of cursor drawing to
369 accomodate underlining, etc.
370
4cc60b9b
EZ
3712011-07-28 Eli Zaretskii <eliz@gnu.org>
372
bc7ece87
EZ
373 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
374 default.
4cc60b9b 375
476371c4
PE
3762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
377
66606eea
PE
378 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
379 Without this fix, if a signal arrives just after memory fills up,
380 'malloc' might be invoked reentrantly.
381
476371c4
PE
382 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
383 In other words, assume that every image size is allowed, on non-X
384 hosts. This assumption is probably wrong, but it lets Emacs compile.
385
f3fcc40d
AS
3862011-07-28 Andreas Schwab <schwab@linux-m68k.org>
387
388 * regex.c (re_iswctype): Convert return values to boolean.
389
350c992f
EZ
3902011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
391
392 * xdisp.c (compute_display_string_pos): Don't use cached display
393 string position if the buffer had its restriction changed.
394 (Bug#9184)
395
5266b4bb
PE
3962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
397
398 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
399
2573a837 4002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 401
41f55ccd 402 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 403
39e378da
PE
404 * bidi.c: Integer size and overflow fixes.
405 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
406 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
407 (bidi_cache_find_level_change, bidi_cache_ensure_space)
408 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
409 (bidi_find_other_level_edge):
410 Use ptrdiff_t instead of EMACS_INT where either will do.
411 This works better on 32-bit hosts configured --with-wide-int.
412 (bidi_cache_ensure_space): Check for size-calculation overflow.
413 Use % rather than repeated addition, for better worst-case speed.
414 Don't set bidi_cache_size until after xrealloc returns, because it
415 might not return.
416 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
417 (bidi_cache_ensure_space): Also check that the bidi cache size
418 does not exceed that of the largest Lisp string or buffer. See Eli
419 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 420
5e927815
PE
421 * alloc.c (__malloc_size_t): Remove.
422 All uses replaced by size_t. See Andreas Schwab's note
423 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
424
ca4aa935
PE
425 * image.c: Improve checking for integer overflow.
426 (check_image_size): Assume that f is nonnull, since
427 it is always nonnull in practice. This is one less thing to
428 worry about when checking for integer overflow later.
429 (x_check_image_size): New function, which checks for integer
430 overflow issues inside X.
431 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
432 This removes the need for a memory_full check.
433 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
434 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
435 (xbm_read_bitmap_data): Change locals back to 'int', since
436 their values must fit in 'int'.
437 (xpm_load_image, png_load, tiff_load):
438 Invoke x_create_x_image_and_pixmap earlier,
439 to avoid much needless work if the image is too large.
440 (tiff_load): Treat overly large images as if
441 x_create_x_image_and_pixmap failed, not as malloc failures.
442 (gs_load): Use x_check_image_size.
443
5f8f9cc2
PE
444 * gtkutil.c: Omit integer casts.
445 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
446 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
447
5adf60bc
PE
448 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
449
c8907a93
PE
450 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
451 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
452 would wrongly return t on a 64-bit host.
453
e3c25c68
PE
454 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
455 The plain *_OVERFLOW macros run afoul of GCC bug 49705
456 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
457 and therefore cause GCC to emit a bogus diagnostic in some cases.
458
3f791afe
PE
459 * image.c: Integer signedness and overflow and related fixes.
460 This is not an exhaustive set of fixes, but it's time to
461 record what I've got.
462 (lookup_pixel_color, check_image_size): Remove redundant decls.
463 (check_image_size): Don't assume that arbitrary EMACS_INT values
464 fit in 'int', or that arbitrary 'double' values fit in 'int'.
465 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
466 (tiff_load, imagemagick_load_image):
467 Check for overflow in size calculations.
468 (x_create_x_image_and_pixmap): Remove unnecessary test for
469 xmalloc returning NULL; that can't happen.
470 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
471 (xpm_color_bucket): Use better integer hashing function.
472 (xpm_cache_color): Don't possibly over-allocate memory.
473 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
474 (gif_memory_source):
475 Use ptrdiff_t, not int or size_t, to record sizes.
476 (png_load): Don't assume values greater than 2**31 fit in 'int'.
477 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
478 either works, as we prefer signed integers.
479 (tiff_read_from_memory, tiff_write_from_memory):
480 Return tsize_t, not size_t, since that's what the TIFF API wants.
481 (tiff_read_from_memory): Don't fail simply because the read would
482 go past EOF; instead, return a short read.
483 (tiff_load): Omit no-longer-needed casts.
484 (Fimagemagick_types): Don't assume size fits into 'int'.
485
3cc5a532
PE
486 Improve hashing quality when configured --with-wide-int.
487 * fns.c (hash_string): New function, taken from sxhash_string.
488 Do not discard information about ASCII character case; this
489 discarding is no longer needed.
490 (sxhash-string): Use it. Change sig to match it. Caller changed.
491 * lisp.h: Declare it.
492 * lread.c (hash_string): Remove, since we now use fns.c's version.
493 The fns.c version returns a wider integer if --with-wide-int is
494 specified, so this should help the quality of the hashing a bit.
495
b312a492
PE
496 * emacs.c: Integer overflow minor fix.
497 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
498 Define only if GNU_LINUX.
499 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
500
dfd153ae
PE
501 * dispnew.c: Integer signedness and overflow fixes.
502 Remove unnecessary forward decls, that were a maintenance hassle.
503 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
504 All uses changed.
505 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
506 (scrolling_window): Use ptrdiff_t, not int, for byte count.
507 (prepare_desired_row, line_draw_cost):
508 Use int, not unsigned, where either works.
509 (save_current_matrix, restore_current_matrix):
510 Use ptrdiff_t, not size_t, where either works.
511 (init_display): Check for overflow more accurately, and without
512 relying on undefined behavior.
513
a81d11a3
PE
514 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
515 Remove, replacing with the new symbols in lisp.h. All uses changed.
516 * fileio.c (make_temp_name):
517 * filelock.c (lock_file_1, lock_file):
518 * xdisp.c (message_dolog):
519 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
520 Use pMd etc. instead.
521 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
522 replacing the pWIDE etc. symbols removed from editfns.c.
523
3300e6fd
PE
524 * keyboard.h (num_input_events): Now uintmax_t.
525 This is (very slightly) less likely to mess up due to wraparound.
526 All uses changed.
527
fd05c7e9
PE
528 * buffer.c: Integer signedness fixes.
529 (alloc_buffer_text, enlarge_buffer_text):
530 Use ptrdiff_t rather than size_t when either will do, as we prefer
531 signed integers.
532
903fe15d
PE
533 * alloc.c: Integer signedness and overflow fixes.
534 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
535 (__malloc_size_t): Default to size_t, not to int.
536 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
537 (Fgarbage_collect, mark_object_loop_halt, mark_object):
538 Prefer ptrdiff_t to size_t when either would do, as we prefer
539 signed integers.
540 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
541 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
542 Now const. Initialize with values that are in range even if char
543 is signed.
544 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
545 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
546 These functions do the right thing with sizes > 2**32.
547 (check_depth): Now ptrdiff_t, not int.
548 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
549 Adjust to new way of storing sizes. Check for size overflow bugs
550 in rest of code.
551 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
552 slightly wrong anyway, as it missed one instance of
553 XMALLOC_OVERRUN_CHECK_OVERHEAD.
554 (refill_memory_reserve): Omit needless cast to size_t.
555 (mark_object_loop_halt): Mark as externally visible.
556
ac82cc6a
PE
557 * xselect.c: Integer signedness and overflow fixes.
558 (Fx_register_dnd_atom, x_handle_dnd_message):
559 Use ptrdiff_t, not size_t, since we prefer signed.
560 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
561 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
562 x_dnd_atoms_size and x_dnd_atoms_length.
563
c2d1e36d
PE
564 * doprnt.c: Prefer signed to unsigned when either works.
565 * eval.c (verror):
566 * doprnt.c (doprnt):
567 * lisp.h (doprnt):
568 * xdisp.c (vmessage):
569 Use ptrdiff_t, not size_t, when using or implementing doprnt,
570 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
571 prefer signed arithmetic to avoid comparison confusion.
572 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
573 but is a bit tricky.
574
0e926e56
PE
575 Assume freestanding C89 headers, string.h, stdlib.h.
576 * data.c, doprnt.c, floatfns.c, print.c:
577 Include float.h unconditionally.
578 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
579 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
580 * regex.c: Likewise for stddef.h, string.h.
581 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
582 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
583 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
584 (STDC_HEADERS): Remove obsolete defines.
585 * sysdep.c: Include limits.h unconditionally.
586
9cfdb3ec
PE
587 Assume support for memcmp, memcpy, memmove, memset.
588 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
589 * regex.c (memcmp, memcpy):
590 Remove; we assume C89 now.
591
592 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
593 (__malloc_safe_bcopy): Remove; no longer needed.
594
cf950e6b 595 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
596 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
597 well either way, and we prefer signed to unsigned.
598
dbf38e02
LMI
5992011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
600
601 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
602 closes the connection while we're reading (bug#9182).
603
d6f0886c
JD
6042011-07-25 Jan Djärv <jan.h.d@swipnet.se>
605
606 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
607 are specified (Bug#9168).
608
2eb1f9e6
PE
6092011-07-25 Paul Eggert <eggert@cs.ucla.edu>
610
611 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
612 Found by GCC static checking and --with-wide-int on a 32-bit host.
613
22381272 6142011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
615
616 * xdisp.c (compute_display_string_pos): Fix logic of caching
617 previous display string position. Initialize cached_prev_pos to
618 -1. Fixes slow-down at the beginning of a buffer.
619
f25e39b4
EZ
6202011-07-24 Eli Zaretskii <eliz@gnu.org>
621
622 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
623 for attrs[LFACE_FONTSET_INDEX].
624
04c4b52e
PE
6252011-07-23 Paul Eggert <eggert@cs.ucla.edu>
626
627 * xml.c (parse_region): Remove unused local
628 that was recently introduced.
629
c1734fbd
EZ
6302011-07-23 Eli Zaretskii <eliz@gnu.org>
631
be18c5a5
EZ
632 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
633 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
634
c1734fbd
EZ
635 * xdisp.c (move_it_in_display_line_to): Record the best matching
636 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
637 exit if none of the characters scanned was an exact match.
638 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
639 when exact match is impossible due to invisible text, and the
640 lines are truncated.
641
a258d627
JD
6422011-07-23 Jan Djärv <jan.h.d@swipnet.se>
643
644 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
645 for OSX >= 10.7.
646
b6d5a689
EZ
6472011-07-22 Eli Zaretskii <eliz@gnu.org>
648
0f74f785
EZ
649 Fix a significant slow-down of cursor motion with C-n, C-p,
650 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
651 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 652 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
653 (next_element_from_buffer): Call compute_stop_pos_backwards to
654 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
655 base_level_stop.
656 (reseat): Don't look for prev_stop, as that could mean a very long
657 run.
658 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
659 <cached_disp_overlay_modiff>: Cache for last found display string
660 position.
551918c1 661 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
662 about the same buffer in the same area of character positions, and
663 the buffer wasn't changed since the time the display string
664 position was cached.
551918c1 665
b2d0c91a
EZ
6662011-07-22 Eli Zaretskii <eliz@gnu.org>
667
668 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
669 is an integer, which is important for empty lines. (Bug#9149)
670
043604ee
CY
6712011-07-22 Chong Yidong <cyd@stupidchicken.com>
672
673 * frame.c (Fmodify_frame_parameters): In tty case, update the
674 default face if necessary (Bug#4238).
675
da4adb04
CY
6762011-07-21 Chong Yidong <cyd@stupidchicken.com>
677
678 * editfns.c (Fstring_to_char): No need to explain what a character
679 is in the docstring (Bug#6576).
680
9abd0532
LMI
6812011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
682
683 * xml.c (parse_region): Make sure we always return a tree.
684
36881d16
HK
6852011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
686
687 * xml.c (parse_region): If a document contains only comments,
688 return that, too.
689
1e98674d
LMI
6902011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
691
692 * xml.c (make_dom): Return comments, too.
693
590bd467
PE
6942011-07-19 Paul Eggert <eggert@cs.ucla.edu>
695
696 Port to OpenBSD.
697 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
698 and the surrounding thread.
699 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
700 rather than fgets, and retry after EINTR. Otherwise, 'emacs
701 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
702 timer goes off.
703 * s/openbsd.h (BROKEN_SIGIO): Define.
704 * unexelf.c (unexec) [__OpenBSD__]:
705 Don't update the .mdebug section of the Alpha COFF symbol table.
706
f41628b2
LMI
7072011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
708
709 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
710 (bug#8460).
711
b59b67c5
PE
7122011-07-18 Paul Eggert <eggert@cs.ucla.edu>
713
15e3a074
PE
714 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
715 This fixes some race conditions on the permissions of any newly
716 created file.
717
41bed37d
PE
718 * alloc.c (valid_pointer_p): Use pipe, not open.
719 This fixes some permissions issues when debugging.
720
b59b67c5
PE
721 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
722 If fchown fails to set both uid and gid, try to set just gid,
723 as that is sometimes allowed. Adjust the file's mode to eliminate
724 setuid or setgid bits that are inappropriate if fchown fails.
725
925a6be7
SM
7262011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
727
728 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
729 to compare Lisp_Objects.
730 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
731 global_gnutls_log_level, don't mistake it for a Lisp_Object.
732 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
733
52968808
AS
7342011-07-17 Andreas Schwab <schwab@linux-m68k.org>
735
0a6a104b
AS
736 * lread.c (read_integer): Unread even EOF character.
737 (read1): Likewise. Properly record start position of symbol.
738
52968808
AS
739 * lread.c (read1): Read `#:' as empty uninterned symbol if no
740 symbol character follows.
741
9e381cdd
PE
7422011-07-17 Paul Eggert <eggert@cs.ucla.edu>
743
744 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
745 This works around a problem with the previous change to Fcopy_file.
746 Recent glibc declares fchown with __attribute__((warn_unused_result)),
747 and without this change, GCC might complain about discarding
748 fchown's return value.
749
b5641435
JB
7502011-07-16 Juanma Barranquero <lekktu@gmail.com>
751
752 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
753
a8031457
PE
7542011-07-16 Paul Eggert <eggert@cs.ucla.edu>
755
756 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
757
dd889327
LMI
7582011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
759
750c33f7
LMI
760 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
761 it's used from the C level.
762
dd889327
LMI
763 * process.c: Use the same condition for POLL_FOR_INPUT in both
764 keyboard.c and process.c (bug#1858).
765
87e86684
LM
7662011-07-09 Lawrence Mitchell <wence@gmx.li>
767
768 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
769 (Fgnutls_boot): Use it.
770
64348f40
AS
7712011-07-15 Andreas Schwab <schwab@linux-m68k.org>
772
773 * doc.c (Fsubstitute_command_keys): Revert last change.
774
1d698799
LMI
7752011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
776
f863868c
LMI
777 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
778 quotes the next character, and doesn't affect other longer
779 sequences (bug#8935).
780
1d698799
LMI
781 * lread.c (syms_of_lread): Clarify that is isn't only
782 `eval-buffer' and `eval-defun' that's affected by
783 `lexical-binding' (bug#8460).
784
aa4b6df6
EZ
7852011-07-15 Eli Zaretskii <eliz@gnu.org>
786
787 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
788 bidi redisplay when a line includes both an image and is
789 truncated.
790
5d856da6
PE
7912011-07-14 Paul Eggert <eggert@cs.ucla.edu>
792
ad6042bb
PE
793 Fix minor problems found by static checking.
794 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
795 (elsz): Now a signed constant, not a size_t var. We prefer signed
796 types to unsigned, to avoid integer comparison confusion. Without
797 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
798 "cannot optimize loop, the loop counter may overflow", a symptom
799 of the confusion.
f00bbb22 800 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
801 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
802
6468f31c
LMI
8032011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
804
49080b10
LMI
805 * search.c (Fre_search_backward): Mention `case-fold-search' in
806 all the re_search_* functions (bug#8138).
807
6468f31c
LMI
808 * keyboard.c (Fopen_dribble_file): Document when the file is
809 closed (bug#8056).
810
c965adc5
EZ
8112011-07-14 Eli Zaretskii <eliz@gnu.org>
812
df9733bf
EZ
813 * bidi.c (bidi_dump_cached_states): Fix format of displaying
814 bidi_cache_idx.
815
0bb23927
EZ
816 Support bidi reordering of display and overlay strings.
817 * xdisp.c (compute_display_string_pos)
818 (compute_display_string_end): Accept additional argument STRING.
819 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
820 (reseat_to_string): Initialize bidi_it->string.s and
821 bidi_it->string.schars.
822 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
823 NULL (avoids a crash in bidi_paragraph_init).
824 Initialize itb.string.lstring.
0bb23927
EZ
825 (init_iterator): Call bidi_init_it only of a valid
826 buffer position was specified. Initialize paragraph_embedding to
827 L2R.
828 (reseat_to_string): Initialize the bidi iterator.
829 (display_string): If we need to ignore text properties of
830 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
831 original value of -1 will not work with bidi.)
832 (compute_display_string_pos): First arg is now struct
833 `text_pos *'; all callers changed. Support display properties on
834 Lisp strings.
835 (compute_display_string_end): Support display properties on Lisp
836 strings.
837 (init_iterator, reseat_1, reseat_to_string): Initialize the
838 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
839 when iterating on a string not from display properties).
640c8776
SM
840 (compute_display_string_pos, compute_display_string_end):
841 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
842 arrow keys.
843 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
844 base_level_stop; instead, set base_level_stop to BEGV.
845 Fixes crashes in vertical-motion.
0bb23927
EZ
846 (next_element_from_buffer): Improve commentary for when
847 the iterator is before prev_stop.
848 (init_iterator): Initialize bidi_p from the default value of
849 bidi-display-reordering, not from buffer-local value. Use the
850 buffer-local value only if initializing for buffer iteration.
851 (handle_invisible_prop): Support invisible properties on strings
852 that are being bidi-reordered.
853 (set_iterator_to_next): Support bidi reordering of C strings and
854 Lisp strings.
855 (next_element_from_string): Support bidi reordering of Lisp
856 strings.
857 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
858 (display_string): Support display of R2L glyph rows.
859 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
860 (init_iterator): Don't initialize it->bidi_p for strings
861 here.
862 (reseat_to_string): Initialize it->bidi_p for strings here.
863 (next_element_from_string, next_element_from_c_string)
864 (next_element_from_buffer): Add xassert's for correspondence
865 between IT's object being iterated and it->bidi_it.string
866 structure.
867 (face_before_or_after_it_pos): Support bidi iteration.
868 (next_element_from_c_string): Handle the case of the first string
869 character that is not the first one in the visual order.
870 (get_visually_first_element): New function, refactored from common
871 parts of next_element_from_buffer, next_element_from_string, and
872 next_element_from_c_string.
873 (tool_bar_lines_needed, redisplay_tool_bar)
874 (display_menu_bar): Force left-to-right direction. Add a FIXME
875 comment for making that be controlled by a user option.
876 (push_it, pop_it): Save and restore the state of the
877 bidi iterator. Save and restore the bidi_p flag.
878 (pop_it): Iterate out of display property for string iteration as
879 well.
880 (iterate_out_of_display_property): Support iteration over strings.
881 (handle_single_display_spec): Set up it->bidi_it for iteration
882 over a display string, and call bidi_init_it.
883 (handle_single_display_spec, next_overlay_string)
884 (get_overlay_strings_1, push_display_prop): Set up the bidi
885 iterator for displaying display or overlay strings.
886 (forward_to_next_line_start): Don't use the shortcut if
887 bidi-iterating.
888 (back_to_previous_visible_line_start): If handle_display_prop
889 pushed the iterator stack, restore the internal state of the bidi
890 iterator by calling bidi_pop_it same number of times.
891 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
892 and we are bidi-iterating, don't decrement the iterator position;
893 instead, set the first_elt flag in the bidi iterator, to produce
894 the same effect.
895 (reseat_1): Remove redundant setting of string_from_display_prop_p.
896 (push_display_prop): xassert that we are iterating a buffer.
897 (push_it, pop_it): Save and restore paragraph_embedding member.
898 (handle_single_display_spec, next_overlay_string)
899 (get_overlay_strings_1, reseat_1, reseat_to_string)
900 (push_display_prop): Set up the `unibyte' member of bidi_it.string
901 correctly. Don't assume unibyte strings are not bidi-reordered.
902 (compute_display_string_pos)
903 (compute_display_string_end): Fix handling the case of C string.
904 (push_it, pop_it): Save and restore from_disp_prop_p.
905 (handle_single_display_spec, push_display_prop): Set the
906 from_disp_prop_p flag.
907 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
908 (pop_it): Call iterate_out_of_display_property only if we are
909 popping after iteration over a string that came from a display
910 property. Fix a typo in popping stretch info. Add an assertion
911 for verifying that the iterator position is in sync with the bidi
912 iterator.
913 (handle_single_display_spec, get_overlay_strings_1)
914 (push_display_prop): Fix initialization of paragraph direction for
915 string when that of the parent object is not yet determined.
916 (reseat_1): Call bidi_init_it to resync the bidi
917 iterator with IT's position. (Bug#7616)
918 (find_row_edges): If ROW->start.pos gives position
919 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
920 (handle_stop, back_to_previous_visible_line_start, reseat_1):
921 Reset the from_disp_prop_p flag.
922 (SAVE_IT, RESTORE_IT): New macros.
923 (pos_visible_p, face_before_or_after_it_pos)
924 (back_to_previous_visible_line_start)
925 (move_it_in_display_line_to, move_it_in_display_line)
926 (move_it_to, move_it_vertically_backward, move_it_by_lines)
927 (try_scrolling, redisplay_window, display_line): Use them when
928 saving a temporary copy of the iterator and restoring it back.
929 (back_to_previous_visible_line_start, reseat_1)
930 (init_iterator): Empty the bidi cache "stack".
931 (move_it_in_display_line_to): If iterator ended up at
932 EOL, but we never saw any buffer positions smaller than
933 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
934 motion in bidi-reordered lines.
935 (move_it_in_display_line_to): Record prev_method and prev_pos
936 immediately before the call to set_iterator_to_next. Fixes cursor
937 motion in bidi-reordered lines with stretch glyphs and strings
938 displayed in margins. (Bug#8133) (Bug#8867)
939 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
940 TO_CHARPOS.
640c8776
SM
941 (pos_visible_p): Support positions in bidi-reordered lines.
942 Save and restore bidi cache.
0bb23927
EZ
943
944 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
945 (bidi_paragraph_info): Delete unused struct.
946 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
947 (bidi_cache_start): New variable.
948 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
949 to zero.
950 (bidi_cache_fetch_state, bidi_cache_search)
951 (bidi_cache_find_level_change, bidi_cache_iterator_state)
952 (bidi_cache_find, bidi_peek_at_next_level)
953 (bidi_level_of_next_char, bidi_find_other_level_edge)
954 (bidi_move_to_visually_next): Compare cache index with
955 bidi_cache_start rather than with zero.
956 (bidi_fetch_char): Accept new argument STRING; all callers
957 changed. Support iteration over a string. Support strings with
958 display properties. Support unibyte strings. Fix the type of
959 `len' according to what STRING_CHAR_AND_LENGTH expects.
960 (bidi_paragraph_init, bidi_resolve_explicit_1)
961 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
962 (bidi_level_of_next_char, bidi_move_to_visually_next):
963 Support iteration over a string.
0bb23927
EZ
964 (bidi_set_sor_type, bidi_resolve_explicit_1)
965 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
966 can now be zero (for strings); special values 0 and -1 were
967 changed to -1 and -2, respectively.
968 (bidi_char_at_pos): New function.
969 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
970 Call it instead of FETCH_MULTIBYTE_CHAR.
971 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
972 initialized to valid values.
973 (bidi_init_it): Don't initialize charpos and bytepos with invalid
974 values.
975 (bidi_level_of_next_char): Allow the sentinel "position" to pass
976 the test for valid cached positions. Fix the logic for looking up
977 the sentinel state in the cache. GCPRO the Lisp string we are
978 iterating.
979 (bidi_push_it, bidi_pop_it): New functions.
980 (bidi_initialize): Initialize the bidi cache start stack pointer.
981 (bidi_cache_ensure_space): New function, refactored from part of
982 bidi_cache_iterator_state. Don't assume the required size is just
983 one BIDI_CACHE_CHUNK away.
984 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
985 (bidi_count_bytes, bidi_char_at_pos): New functions.
986 (bidi_cache_search): Don't assume bidi_cache_last_idx is
987 always valid if bidi_cache_idx is valid.
988 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
989 is valid if it's going to be used.
990 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
991 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
992 (bidi_cache_find_level_change, bidi_cache_ensure_space)
993 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
994 (bidi_find_other_level_edge, bidi_cache_start_stack):
995 All variables related to cache indices are now EMACS_INT.
c965adc5 996
0bb23927
EZ
997 * dispextern.h (struct bidi_string_data): New structure.
998 (struct bidi_it): New member `string'. Make flag members be 1-bit
999 fields, and put them last in the struct.
640c8776
SM
1000 (compute_display_string_pos, compute_display_string_end):
1001 Update prototypes.
0bb23927
EZ
1002 (bidi_push_it, bidi_pop_it): Add prototypes.
1003 (struct iterator_stack_entry): New members bidi_p,
1004 paragraph_embedding, and from_disp_prop_p.
1005 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1006 (bidi_shelve_cache, bidi_unshelve_cache):
1007 Declare prototypes.
0bb23927
EZ
1008
1009 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1010 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1011 and vector-like objects.
1012
1013 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1014 cache around display iteration.
1015
1016 * window.c (Fwindow_end, window_scroll_pixel_based)
1017 (displayed_window_lines, Frecenter): Save and restore the bidi
1018 cache around display iteration.
1019
3bbd2265
LMI
10202011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1021
1022 * editfns.c (Fdelete_region): Clarify the use of the named
1023 parameters (bug#6788).
1024
adc47434
MR
10252011-07-14 Martin Rudalics <rudalics@gmx.at>
1026
1027 * indent.c (Fvertical_motion): Set and restore w->pointm when
1028 saving and restoring the window's buffer (Bug#9006).
1029
837c31f8
LMI
10302011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1031
1032 * editfns.c (Fstring_to_char): Clarify just what is returned
1033 (bug#6576). Text by Eli Zaretskii.
1034
ac389d0c
JB
10352011-07-13 Juanma Barranquero <lekktu@gmail.com>
1036
1037 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1038
0be0ce47
EZ
10392011-07-13 Eli Zaretskii <eliz@gnu.org>
1040
1041 * buffer.c (mmap_find): Fix a typo.
1042
cd18e7e3
JB
10432011-07-13 Johan Bockgård <bojohan@gnu.org>
1044
1045 Fix execution of x selection hooks.
1046 * xselect.c (Qx_lost_selection_functions)
1047 (Qx_sent_selection_functions): New vars.
1048 (syms_of_xselect): DEFSYM them.
1049 (x_handle_selection_request): Pass Qx_sent_selection_functions
1050 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1051 (x_handle_selection_clear,x_clear_frame_selections):
1052 Pass Qx_lost_selection_functions rather than
1053 Vx_lost_selection_functions to Frun_hook_with_args.
1054
47ea7f44
PE
10552011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1056
ac389d0c 1057 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1058 The old code sometimes used this field without initializing it.
1059
47ea7f44
PE
1060 * alloc.c (gc_sweep): Don't read past end of array.
1061 In theory, the old code could also have corrupted Emacs internals,
1062 though it'd be very unlikely.
1063
bc985c87
AS
10642011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1065
1066 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1067 argument. (Bug#4026)
bc985c87 1068
0cf34688
LMI
10692011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1070
b3dadd76
LMI
1071 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1072 key" (bug#4257).
1073
0cf34688
LMI
1074 * window.c (Fset_window_start): Doc fix (bug#4199).
1075 (Fset_window_hscroll): Ditto.
1076
270768cd
PE
10772011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1078
077e3dda 1079 Fix minor new problems caught by GCC 4.6.1.
270768cd 1080 * term.c (init_tty): Remove unused local.
490011a6 1081 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1082 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1083 not used otherwise.
270768cd 1084
b1f58454
CY
10852011-07-12 Chong Yidong <cyd@stupidchicken.com>
1086
1087 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1088
22b9578d
LMI
10892011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1090
6e70ab07
LMI
1091 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1092 are the mini-buffer and the echo area (bug#3320).
1093
22b9578d
LMI
1094 * term.c (init_tty): Remove support for supdup, c10 and perq
1095 terminals, which are no longer supported (bug#1482).
1096
8974cc9f
JB
10972011-07-10 Johan Bockgård <bojohan@gnu.org>
1098
1099 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1100
a560d974
JD
11012011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1102
1103 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1104 for non-popups (Bug#3642).
1105
1dae0f0a
AS
11062011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1107
268c2c36 1108 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1109 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1110 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1111 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1112 * data.c (fmod): Likewise.
1113 * dispnew.c (swap_glyphs_in_rows): Likewise.
1114 * emacs.c (memory_warning_signal): Likewise.
1115 * floatfns.c (float_error): Likewise.
1116 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1117 (otf_open, font_otf_capability, generate_otf_features)
1118 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1119 Likewise.
1120 * image.c (pbm_read_file): Likewise.
1121 * indent.c (string_display_width): Likewise.
1122 * intervals.c (check_for_interval, search_for_interval)
1123 (inc_interval_count, count_intervals, root_interval)
1124 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1125 * lread.c (defalias): Likewise.
268c2c36 1126 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1127 * regex.c (set_image_of_range_1, set_image_of_range)
1128 (regex_grow_registers): Likewise.
1129 * sysdep.c (strerror): Likewise.
1130 * termcap.c (valid_filename_p, tprint, main): Likewise.
1131 * tparam.c (main): Likewise.
1132 * unexhp9k800.c (run_time_remap, save_data_space)
1133 (update_file_ptrs, read_header, write_header, calculate_checksum)
1134 (copy_file, copy_rest, display_header): Likewise.
1135 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1136 Likewise.
1137 * xdisp.c (check_it): Likewise.
1138 * xfaces.c (register_color, unregister_color, unregister_colors):
1139 Likewise.
1140 * xfns.c (print_fontset_result): Likewise.
1141 * xrdb.c (member, fatal, main): Likewise.
1142
99033785
PE
11432011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1144
1145 Fix minor problems found by static checking (Bug#9031).
1146 * chartab.c (char_table_set_range, map_sub_char_table):
1147 Remove unused locals.
1148 (uniprop_table): Now static.
1149 * composite.c (_work_char): Remove unused static var.
1150
9cb2ac56
JB
11512011-07-09 Juanma Barranquero <lekktu@gmail.com>
1152
1153 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1154
f25661f0
JD
11552011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1156
1157 * gtkutil.c (qttip_cb): Remove code without function.
1158
8278c4fe
EZ
11592011-07-09 Eli Zaretskii <eliz@gnu.org>
1160
1161 * w32.c (pthread_sigmask): New stub.
1162
1692ae2d 11632011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1164
8a6ebd58 1165 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1166 sigprocmask is portable only for single-threaded applications, and
1167 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1168 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1169 (LIBES): Use it.
1170 * callproc.c (Fcall_process):
1171 * process.c (create_process):
1172 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1173 Use pthread_sigmask, not sigprocmask.
123403e4 1174
1b854618
JD
11752011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1176
1177 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1178 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1179 wrong (Bug#8591).
1180
3fe4b549
JD
11812011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1182
0ce7e563
JD
1183 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1184 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1185 (xg_hide_tooltip): Fix comment.
1186
3fe4b549
JD
1187 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1188 in registerServicesMenuSendTypes.
1189 (validRequestorForSendType): Don't check ns_return_types.
1190
1191 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1192 ns_return_type.
1193
5df75e47
JR
11942011-07-08 Jason Rumney <jasonr@gnu.org>
1195
1196 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1197 frame struct members of non-existent frames (Bug#6284).
1198
699c10bd
JD
11992011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1200
4393663b
JD
1201 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1202 variable firstTime not needed on OSX >= 10.6.
1203 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1204 >= 10.5. Use setKnobProportion, setDoubleValue.
1205
1206 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1207 (MAC_OS_X_VERSION_10_5): Define if not defined.
1208 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1209 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1210 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1211
1212 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1213 cString and lossyCString on OSX >= 10.4
1214
1215 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1216 sizeToFit on OSX >= 10.2.
1217
1218 * nsimage.m (allocInitFromFile): Don't use deprecated method
1219 bestRepresentationForDevice on OSX >= 10.6.
1220
1221 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1222 to avoid warning.
1223
1224 * emacs.c: Declare unexec_init_emacs_zone.
1225
a63e0781
JD
1226 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1227
699c10bd
JD
1228 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1229
1230 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1231 on svcsMenu (Bug#8842).
1232
1233 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1234 ns_return_types.
1235 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1236
1237 * nsterm.m (QUTF8_STRING): Declare.
1238 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1239 (validRequestorForSendType): Return type is (id).
1240 Change indexOfObjectIdenticalTo to indexOfObject.
1241 Check if we have local selection before returning self (Bug#8842).
1242 (writeSelectionToPasteboard): Put local selection into paste board
1243 if we have a local selection (Bug#8842).
1244 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1245
1246 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1247 (ns_get_local_selection): Declare.
1248
54e10184
LMI
12492011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1250
9888ff71
LMI
1251 * keymap.c (describe_map_tree): Don't insert a double newline at
1252 the end of the buffer (bug#1169) and return whether we inserted
1253 something.
1254
54e10184
LMI
1255 * callint.c (Fcall_interactively): Change "reading args" to
1256 "providing args" to try to clarify what it does (bug#1010).
1257
15fa4783
KH
12582011-07-07 Kenichi Handa <handa@m17n.org>
1259
1260 * composite.c (composition_compute_stop_pos): Ignore a static
1261 composition starting before CHARPOS (Bug#8915).
1262
1263 * xdisp.c (handle_composition_prop): Likewise.
1264
a8815b00
EZ
12652011-07-07 Eli Zaretskii <eliz@gnu.org>
1266
1267 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1268 (Bug#9015)
1269
ef7b981d 12702011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1271
1272 * character.h (unicode_category_t): New enum type.
1273
1274 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1275 (Qchar_code_property_table): New variable.
1276 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1277 (UNIPROP_COMPRESSED_FORM_P): New macros.
1278 (char_table_ascii): Uncompress the compressed values.
1279 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1280 Uncompress the compressed values.
ac389d0c 1281 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1282 (char_table_ref_and_range): Uncompress the compressed values.
1283 (sub_char_table_set): New arg is_uniprop. Callers changed.
1284 Uncompress the compressed values.
1285 (sub_char_table_set_range): Args changed. Callers changed.
1286 (char_table_set_range): Adjuted for the above change.
1287 (map_sub_char_table): Delete args default_val and parent. Add arg
1288 top. Give decoded values to a Lisp function.
640c8776 1289 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1290 values to a Lisp function. Gcpro more variables.
1291 (uniprop_table_uncompress)
1292 (uniprop_decode_value_run_length): New functions.
1293 (uniprop_decoder, uniprop_decoder_count): New variables.
1294 (uniprop_get_decoder, uniprop_encode_value_character)
1295 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1296 New functions.
1297 (uniprop_encoder, uniprop_encoder_count): New variables.
1298 (uniprop_get_encoder, uniprop_table)
1299 (Funicode_property_table_internal, Fget_unicode_property_internal)
1300 (Fput_unicode_property_internal): New functions.
1301 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1302 Sunicode_property_table_internal, Sget_unicode_property_internal,
1303 and Sput_unicode_property_internal. Defvar_lisp
1304 char-code-property-alist.
1305
640c8776 1306 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1307 Vunicode_category_table.
1308
640c8776 1309 * font.c (font_range): Adjust for the change of
c805dec0
KH
1310 Vunicode_category_table.
1311
76b397fb
DN
13122011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1313
1314 * m/iris4d.h: Remove file, move contents ...
1315 * s/irix6-5.h: ... here.
1316
22b4128e
PE
13172011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1318
1319 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1320 * alloc.c (mark_buffer):
1321 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1322 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1323 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1324 This isn't true in general, and it's particularly not true
1325 if Emacs is configured with --with-wide-int.
1326 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1327 New macros, used in the buffer.c change.
1328
869795d6
JD
13292011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1330
1331 * xsettings.c: Use both GConf and GSettings if both are available.
1332 (store_config_changed_event): Add comment.
1333 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1334 (store_tool_bar_style_changed): New functions.
1335 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1336 (struct xsettings): Move font inside HAVE_XFT.
1337 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1338 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1339 Move inside HAVE_XFT.
640c8776 1340 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1341 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1342 also.
1343 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1344 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1345 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1346 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1347 (parse_settings): Move check for font inside HAVE_XFT.
1348 (read_settings, apply_xft_settings): Add comment.
1349 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1350 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1351 call store_font_name_changed.
1352 (xft_settings_event): Add comment.
1353 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1354 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1355 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1356 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1357 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1358 (xsettings_get_system_font, xsettings_get_system_normal_font):
1359 Add comment.
869795d6 1360
d8ed26bd
PE
13612011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1362
1363 Random fixes. E.g., (random) never returned negative values.
1364 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1365 subseconds part to the entropy, as that's a bit more random.
1366 Prefer signed to unsigned, since the signedness doesn't matter and
1367 in general we prefer signed. When given a limit, use a
1368 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1369 latter isn't right if USE_2_TAGS_FOR_INTS.
1370 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1371 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1372
cabf1cac
SM
13732011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1374
1375 * textprop.c (text_property_stickiness):
1376 Obey Vtext_property_default_nonsticky.
1377 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1378 * w32fns.c (syms_of_w32fns):
1379 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1380
6e9b2be9
PE
13812011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1382
1383 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1384 This is more efficient than Ffile_directory_p and avoids a minor race.
1385
90186c68
LMI
13862011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1387
7c301272
LMI
1388 * buffer.c (Foverlay_put): Say what the return value is
1389 (bug#7835).
1390
c4f2d8d4
LMI
1391 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1392 is a directory before asking whether to use the file name
1393 (bug#7564).
ad637907
LMI
1394 (barf_or_query_if_file_exists): Make the "File is a directory"
1395 error be more correct.
c4f2d8d4 1396
90186c68
LMI
1397 * fns.c (Frequire): Remove the mention of the .gz files, since
1398 that's installation-specific, but keep the mention of
1399 `get-load-suffixes'.
1400
da64016e
PE
14012011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1402
1403 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1404 Report string overflow if the output is too long.
1405
7d47b580
JB
14062011-07-04 Juanma Barranquero <lekktu@gmail.com>
1407
a555cb87
JB
1408 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1409 (syms_of_gnutls): Remove duplicate DEFSYM for
1410 Qgnutls_bootprop_verify_hostname_error, an error for
1411 Qgnutls_bootprop_verify_error (which is no longer used).
1412
7d47b580
JB
1413 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1414 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1415 Also (re)move comments that are misplaced or no longer relevant.
1416
1e49bfab
LMI
14172011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1418
1419 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1420
1485f4c0
CY
14212011-07-03 Chong Yidong <cyd@stupidchicken.com>
1422
1423 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1424 and background color parameters if they have been changed.
1425
a9ab721e
LMI
14262011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1427
1428 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1429
cf7cff57
PE
14302011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1431
2e13213d
PE
1432 * xsettings.c (SYSTEM_FONT): Define only when used.
1433 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1434
cf7cff57
PE
1435 * keymap.c (access_keymap_1): Now static.
1436
7a8e04f7
CY
14372011-07-02 Chong Yidong <cyd@stupidchicken.com>
1438
1439 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1440 leave any prefix arg for the up event (Bug#1586).
1441
61352f62
LMI
14422011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1443
69bb1ef7
LMI
1444 * lread.c (syms_of_lread): Mention single symbols defined by
1445 `defvar' or `defconst' (bug#7154).
1446
61352f62 1447 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1448 (Frequire): Mention get-load-suffixes.
61352f62 1449
28545e04
MR
14502011-07-02 Martin Rudalics <rudalics@gmx.at>
1451
1452 * window.h (window): Remove clone_number slot.
1453 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1454 Remove.
1455 (make_parent_window, make_window, saved_window)
1456 (Fset_window_configuration, save_window_save): Don't deal with
1457 clone numbers.
1458 * buffer.c (Qclone_number): Remove declaration.
1459 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1460
3349e122
SM
14612011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1462
1463 Add multiple inheritance to keymaps.
1464 * keymap.c (Fmake_composed_keymap): New function.
1465 (Fset_keymap_parent): Simplify.
1466 (fix_submap_inheritance): Remove.
1467 (access_keymap_1): New function extracted from access_keymap to handle
1468 embedded parents and handle lists of maps.
1469 (access_keymap): Use it.
1470 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1471 (Fcopy_keymap): Handle embedded parents.
1472 (Fcommand_remapping, define_as_prefix): Simplify.
1473 (Fkey_binding): Simplify.
1474 (syms_of_keymap): Move minibuffer-local-completion-map,
1475 minibuffer-local-filename-completion-map,
1476 minibuffer-local-must-match-map, and
1477 minibuffer-local-filename-must-match-map to Elisp.
1478 (syms_of_keymap): Defsubr make-composed-keymap.
1479 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1480 (parse_menu_item): Trivial simplification.
1481
3279eb87
GM
14822011-07-01 Glenn Morris <rgm@gnu.org>
1483
1484 * Makefile.in (SETTINGS_LIBS): Fix typo.
1485
4550efdf
KI
14862011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1487
1488 * coding.c (Fencode_coding_string): Record the last coding system
1489 used, as the function doc string says (bug#8738).
1490
0949d2b6
JD
14912011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1492
1493 * xsettings.c (store_monospaced_changed): Take new font as arg and
1494 check for change against current_mono_font.
1495 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1496 (emacs_settings_constructor, emacs_settings_get_property)
1497 (emacs_settings_set_property, emacs_settings_class_init)
1498 (emacs_settings_init, gsettings_obj): Remove.
1499 (something_changedCB): New function for HAVE_GSETTINGS.
1500 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1501 with value as argument.
1502 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1503 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1504 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1505 "changed".
1506
1507 * xgselect.c: Add defined (HAVE_GSETTINGS).
1508 (xgselect_initialize): Ditto.
1509
1510 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1511 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1512 xg_select.
1513
bbc6b304
PE
15142011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1515
1516 * eval.c (struct backtrace): Simplify and port the data structure.
1517 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1518 signed bit field, as this assumption is not portable and it makes
1519 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1520 "char debug_on_exit : 1" as this is not portable either; instead,
1521 use the portable "unsigned int debug_on_exit : 1". Remove unused
1522 member evalargs. Remove obsolete comments about cc bombing out.
1523
9851bfc5
JD
15242011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1525
51bb811f 1526 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1527 Let HAVE_GSETTINGS override HAVE_GCONF.
1528 (store_monospaced_changed): New function.
1529 (EMACS_SETTINGS): A new type derived from GObject to handle
1530 GSettings notifications.
1531 (emacs_settings_constructor, emacs_settings_get_property)
1532 (emacs_settings_set_property, emacs_settings_class_init):
1533 New functions.
1534 (gsettings_client, gsettings_obj): New variables.
1535 (GSETTINGS_SCHEMA): New define.
1536 (something_changedCB): Call store_monospaced_changed.
1537 (init_gsettings): New function.
1538 (xsettings_initialize): Call init_gsettings.
1539 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1540 to NULL.
1541
640c8776 1542 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1543 GCONF_CFLAGS/LIBS.
1544
5386012d
MR
15452011-06-29 Martin Rudalics <rudalics@gmx.at>
1546
1547 * window.c (resize_root_window, grow_mini_window)
1548 (shrink_mini_window): Rename Qresize_root_window to
1549 Qwindow_resize_root_window and Qresize_root_window_vertically to
1550 Qwindow_resize_root_window_vertically.
1551
f13e0b08
PE
15522011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1553
1554 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1555
94515237
JB
15562011-06-27 Juanma Barranquero <lekktu@gmail.com>
1557
1558 * makefile.w32-in: Redesign dependencies so they reflect more
1559 clearly which files are directly included by each source file,
1560 and not through other includes.
1561
e43b6e43
MR
15622011-06-27 Martin Rudalics <rudalics@gmx.at>
1563
1564 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1565 (sort_overlays, overlay_strings): When an overlay's clone number
1566 matches the window's clone number process the overlay even if
1567 the overlay's window property doesn't match the current window.
1568
d68443dc
MR
1569 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1570 (Fwindow_hchild): Rename to Fwindow_left_child.
1571 (Fwindow_next): Rename to Fwindow_next_sibling.
1572 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1573 (resize_window_check): Rename to window_resize_check.
1574 (resize_window_apply): Rename to window_resize_apply.
1575 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1576 (Fdelete_other_windows_internal, resize_frame_windows)
1577 (Fsplit_window_internal, Fdelete_window_internal)
1578 (grow_mini_window, shrink_mini_window)
1579 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1580
c7e73be5
JD
15812011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1582
1583 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1584 (emacs_fixed_set_min_size): Remove.
1585 (emacs_fixed_new): Take frame as argument.
1586
1587 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1588 (_EmacsFixedPrivate): Remove minwidth/height.
1589 Add struct frame *f.
1590 (emacs_fixed_init): Initialize priv->f.
1591 (get_parent_class, emacs_fixed_set_min_size): Remove.
1592 (emacs_fixed_new): Set priv->f to argument.
1593 (emacs_fixed_get_preferred_width)
1594 (emacs_fixed_get_preferred_height): Use min_width/height from
1595 frames size_hint to set minimum and natural (Bug#8919).
1596 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1597 and use min_width/height from frames size_hint to set
1598 min_width/height (Bug#8919).
1599
1600 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1601 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1602 Fix indentation.
c7e73be5 1603
cf99dcf8
EZ
16042011-06-26 Eli Zaretskii <eliz@gnu.org>
1605
1606 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1607 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1608 called at ZV.
1609
029529ac
CY
16102011-06-26 Chong Yidong <cyd@stupidchicken.com>
1611
1612 * process.c (wait_reading_process_output): Bypass select if
1613 waiting for a cell while ignoring keyboard input, and input is
1614 pending. Suggested by Jan Djärv (Bug#8869).
1615
7a7ef429
PE
16162011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1617
1618 Use gnulib's dup2 module instead of rolling our own.
1619 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1620
11fdef7d 16212011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1622
1623 * dispnew.c (scrolling_window): Before scrolling, turn off a
1624 mouse-highlight in the window being scrolled.
1625
cd3520a4
JB
16262011-06-24 Juanma Barranquero <lekktu@gmail.com>
1627
1628 Move DEFSYM to lisp.h and use everywhere.
1629
1630 * character.h (DEFSYM): Move declaration...
1631 * lisp.h (DEFSYM): ...here.
1632
1633 * gnutls.c:
1634 * minibuf.c:
1635 * w32menu.c:
1636 * w32proc.c:
1637 * w32select.c: Don't include character.h.
1638
1639 * alloc.c (syms_of_alloc):
1640 * buffer.c (syms_of_buffer):
1641 * bytecode.c (syms_of_bytecode):
1642 * callint.c (syms_of_callint):
1643 * casefiddle.c (syms_of_casefiddle):
1644 * casetab.c (init_casetab_once):
1645 * category.c (init_category_once, syms_of_category):
1646 * ccl.c (syms_of_ccl):
1647 * cmds.c (syms_of_cmds):
1648 * composite.c (syms_of_composite):
1649 * dbusbind.c (syms_of_dbusbind):
1650 * dired.c (syms_of_dired):
1651 * dispnew.c (syms_of_display):
1652 * doc.c (syms_of_doc):
1653 * editfns.c (syms_of_editfns):
1654 * emacs.c (syms_of_emacs):
1655 * eval.c (syms_of_eval):
1656 * fileio.c (syms_of_fileio):
1657 * fns.c (syms_of_fns):
1658 * frame.c (syms_of_frame):
1659 * fringe.c (syms_of_fringe):
1660 * insdel.c (syms_of_insdel):
1661 * keymap.c (syms_of_keymap):
1662 * lread.c (init_obarray, syms_of_lread):
1663 * macros.c (syms_of_macros):
1664 * msdos.c (syms_of_msdos):
1665 * print.c (syms_of_print):
1666 * process.c (syms_of_process):
1667 * search.c (syms_of_search):
1668 * sound.c (syms_of_sound):
1669 * syntax.c (init_syntax_once, syms_of_syntax):
1670 * terminal.c (syms_of_terminal):
1671 * textprop.c (syms_of_textprop):
1672 * undo.c (syms_of_undo):
1673 * w32.c (globals_of_w32):
1674 * window.c (syms_of_window):
1675 * xdisp.c (syms_of_xdisp):
1676 * xfaces.c (syms_of_xfaces):
1677 * xfns.c (syms_of_xfns):
1678 * xmenu.c (syms_of_xmenu):
1679 * xsettings.c (syms_of_xsettings):
1680 * xterm.c (syms_of_xterm): Use DEFSYM.
1681
4228cf16
TZ
16822011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1683
cd3520a4 1684 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1685
7fcccf1e
PE
16862011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1687
7efb4e0e
PE
1688 Integer and buffer overflow fixes (Bug#8873).
1689
ff5844ad
PE
1690 * print.c (printchar, strout): Check for string overflow.
1691 (PRINTPREPARE, printchar, strout):
1692 Don't set size unless allocation succeeds.
1693
90532f02
PE
1694 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1695 for sizes. Check for string overflow more accurately.
1696 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1697
6d84508d
PE
1698 * macros.c: Integer and buffer overflow fixes.
1699 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1700 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1701 Use ptrdiff_t, not int, for sizes.
1702 Don't increment bufsize until after realloc succeeds.
1703 Check for size-calculation overflow.
1704 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1705
437b2cb4
PE
1706 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1707
8b9ac8b4
PE
1708 * lread.c: Integer overflow fixes.
1709 (read_integer): Radix is now EMACS_INT, not int,
1710 to improve quality of diagnostics for out-of-range radices.
1711 Calculate buffer size correctly for out-of-range radices.
1712 (read1): Check for integer overflow in radices, and in
1713 read-circle numbers.
82cb60d3
PE
1714 (read_escape): Avoid int overflow.
1715 (Fload, openp, read_buffer_size, read1)
1716 (substitute_object_recurse, read_vector, read_list, map_obarray):
1717 Use ptrdiff_t, not int, for sizes.
1718 (read1): Use EMACS_INT, not int, for sizes.
20270765 1719 Check for size overflow.
8b9ac8b4 1720
7fcccf1e
PE
1721 * image.c (cache_image): Check for size arithmetic overflow.
1722
bfbbd7e7
PE
1723 * lread.c: Integer overflow issues.
1724 (saved_doc_string_size, saved_doc_string_length)
1725 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1726 Now ptrdiff_t, not int.
1727 (read1): Don't assume doc string length fits in int. Check for
1728 out-of-range doc string lengths.
1729 (read_list): Don't assume file position fits in int.
39019e54 1730 (read_escape): Check for hex character overflow.
bfbbd7e7 1731
4e323265
LL
17322011-06-22 Leo Liu <sdl.web@gmail.com>
1733
1734 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1735 Move to minibuffer.el.
1736
85fece3e
PE
17372011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1738
20b84ce9 1739 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1740 The following patches are for when GLYPH_DEBUG && !XASSERT.
1741 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1742 * dispnew.c (flush_stdout):
1743 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1744 Mark as externally visible.
1745 * dispnew.c (check_window_matrix_pointers): Now static.
1746 * dispnew.c (window_to_frame_vpos):
1747 * xfns.c (unwind_create_frame):
1748 * xterm.c (x_check_font): Remove unused local.
1749 * scroll.c (CHECK_BOUNDS):
1750 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1751 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1752 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1753 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1754 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1755 Now static.
1756 (debug_method_add): Use va_list and vsprintf rather than relying
1757 on undefined behavior with wrong number of arguments.
1758 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1759 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1760 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1761 since we're not interested in debugging glyphs with old libraries.
1762 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1763 GCC 4.6.0's static checking.
1764
0766b489
PE
17652011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1766
31fd4b32
PE
1767 Integer overflow and signedness fixes (Bug#8873).
1768 A few related buffer overrun fixes, too.
1769
b79e8648
PE
1770 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1771
0766b489
PE
1772 * dispextern.h (struct face.stipple):
1773 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1774 (x_bitmap_mask, x_allocate_bitmap_record)
1775 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1776 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1777 (x_create_bitmap_from_xpm_data):
1778 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1779 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1780 (.bitmaps_last):
1781 * xfaces.c (load_pixmap):
1782 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1783 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1784 (.bitmaps_last, struct x_output.icon_bitmap):
1785 Use ptrdiff_t, not int, for bitmap indexes.
1786 (x_allocate_bitmap_record): Check for size overflow.
1787 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1788
b081724f
PE
1789 Use ptrdiff_t, not int, for overlay counts.
1790 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1791 * editfns.c (overlays_around, get_pos_property):
1792 * textprop.c (get_char_property_and_overlay):
1793 * xdisp.c (next_overlay_change, note_mouse_highlight):
1794 * xfaces.c (face_at_buffer_position):
21514da7
PE
1795 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1796 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1797 (Fnext_overlay_change, Fprevious_overlay_change)
1798 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1799 Use ptrdiff_t, not int, for sizes.
21514da7 1800 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1801
3de73e5e
PE
1802 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1803
2606c57b
PE
1804 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1805 (x_session_initialize): Do not assume string length fits in int.
1806
aaafe47a
PE
1807 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1808 This is unlikely, but can occur if DPI is outlandish.
1809
2674ddc8 1810 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1811 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1812
28154962
PE
1813 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1814 * xrdb.c (magic_file_p, search_magic_path):
1815 Omit last arg SUFFIX; it was always 0. All callers changed.
1816 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1817
7de51af5
PE
1818 * xfont.c (xfont_match): Avoid need for strlen.
1819
25ed6cc3
PE
1820 * xfns.c: Don't assume strlen fits in int.
1821 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1822
4eab31dd
PE
1823 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1824 not unsigned long, as we prefer signed integers. All callers changed.
1825 Detect integer overflow in repeat count.
1826 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1827 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1828
171e2a58
PE
1829 * termcap.c: Don't assume sizes fit in int and never overflow.
1830 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1831 (gobble_line): Check for size-calculation overflow.
1832
ad39faca 1833 * minibuf.c (Fread_buffer):
6e5bb2dc 1834 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1835 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1836 Don't assume string length fits in int.
1837
52c61c22 1838 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1839 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1840
b5b8c9e5
PE
1841 * font.c: Don't assume string length fits in int.
1842 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1843 Use ptrdiff_t, not int.
ccd6111c
PE
1844 (font_intern_prop): Don't assume string length fits in int.
1845 Don't assume integer property fits in fixnum.
1846 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1847
882f0d81 1848 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1849 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1850 Reformulate so as not to need the command string.
1851 Invoke gzip -cd rather than gunzip, as it's more portable.
1852 (lock_info_type, lock_file_1, lock_file):
1853 Don't assume pid_t and time_t fit in unsigned long.
1854 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1855 (current_lock_owner): Prefer signed type for sizes.
1856 Use memcpy, not strncpy, where memcpy is what is really wanted.
1857 Don't assume (via atoi) that time_t and pid_t fit in int.
1858 Check for time_t and/or pid_t out of range, e.g., via a network share.
1859 Don't alloca where an auto var works fine.
1860
93f4cf88
PE
1861 * fileio.c: Fix some integer overflow issues.
1862 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1863 Don't assume string length fits in int.
1864 (directory_file_name): Don't assume string length fits in long.
1865 (make_temp_name): Don't assume pid fits in int, or that its print
1866 length is less than 20.
1867
f3e92b69
PE
1868 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1869
1bfdaf10
PE
1870 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1871
35016e9a
PE
1872 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1873
3d1e65a1
PE
1874 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1875 We prefer signed integers, even for size calculations.
1876
0b963a93
PE
1877 * emacs.c: Don't assume string length fits in 'int'.
1878 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1879 (main): Don't invoke strlen when not needed.
1880
573f4b54
PE
1881 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1882 (XD_DEBUG_MESSAGE): Don't waste a byte.
1883
989f33ba
PE
1884 * callproc.c (getenv_internal_1, getenv_internal)
1885 (Fgetenv_internal):
965d34eb
PE
1886 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1887
e4d29b33
PE
1888 * lread.c (invalid_syntax): Omit length argument.
1889 All uses changed. This doesn't fix a bug, but it simplifies the
1890 code away from its former Hollerith-constant appearance, and it's
1891 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1892 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1893
eb49b136
PE
1894 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1895 This didn't break anything, but it didn't help either.
1896 It's confusing to put a bogus integer in a place where the actual
1897 value does not matter.
9f62aeb1 1898 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1899 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1900
15375a22
PE
1901 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1902 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1903 implementation.
b61cc01c
PE
1904 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1905 We prefer signed types, and the value cannot exceed the EMACS_INT
1906 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1907 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1908 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1909 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1910
53b2623d
PE
1911 * indent.c (sane_tab_width): New function.
1912 (current_column, scan_for_column, Findent_to, position_indentation)
1913 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1914 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1915
51cab52b 1916 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1917
f2ed8a70
PE
1918 * lisp.h (lint_assume): New macro.
1919 * composite.c (composition_gstring_put_cache):
1920 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1921
abe80cc6
PE
1922 * editfns.c, insdel.c:
1923 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1924
b02c740e
PE
1925 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1926
ebc96716
PE
1927 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1928
b4e50fa0 1929 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1930 Use much-faster test for byte-length change.
311d5d7c 1931 Don't assume string byte-length fits in 'int'.
a4cf38e4 1932 Check that character arg fits in 'int'.
85461888 1933 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1934
c0c1ee9f
PE
1935 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1936
a498d7f4
PE
1937 * fns.c (concat): Catch string overflow earlier.
1938 Do not rely on integer wraparound.
1939
51cab52b
PE
1940 * dispextern.h (struct it.overlay_strings_charpos)
1941 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1942 * xdisp.c (forward_to_next_line_start)
1943 (back_to_previous_visible_line_start)
1944 (reseat_at_next_visible_line_start, next_element_from_buffer):
1945 Don't arbitrarily truncate the value of 'selective' to int.
1946
76031fad
PE
1947 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1948
5eb55db9
PE
1949 * composite.c: Don't truncate sizes to 'int'.
1950 (composition_gstring_p, composition_reseat_it)
1951 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1952 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1953 not EMACS_UINT, for indexes.
5eb55db9 1954
0703a717
PE
1955 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1956
d6202519
PE
1957 * buffer.c: Include <verify.h>.
1958 (struct sortvec.priority, struct sortstr.priority):
8961a454 1959 Now EMACS_INT, not int.
c20998a7 1960 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1961 (struct sortstr.size, record_overlay_string)
1962 (struct sortstrlist.size, struct sortlist.used):
1963 Don't truncate size to int.
1964 (record_overlay_string): Check for size-calculation overflow.
d6202519 1965 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1966
d5a19415
JM
19672011-06-22 Jim Meyering <meyering@redhat.com>
1968
029529ac 1969 Don't leak an XBM-image-sized buffer
d5a19415
JM
1970 * image.c (xbm_load): Free the image buffer after using it.
1971
a9041e6c
PE
19722011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1973
1974 Port to Sun C.
1975 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1976 that Sun C diagnosed.
1977 * fns.c (secure_hash): Fix pointer signedness issue.
1978 * intervals.c (static_offset_intervals): New function.
1979 (offset_intervals): Use it.
1980
7f3f739f
LL
19812011-06-21 Leo Liu <sdl.web@gmail.com>
1982
1983 * deps.mk (fns.o):
1984 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1985 sha512.h.
1986
1987 * fns.c (secure_hash): Rename from crypto_hash_function and change
1988 the first arg to accept symbols.
5b66d427 1989 (Fsecure_hash): New primitive.
7f3f739f
LL
1990 (syms_of_fns): New symbols.
1991
76147d94
DD
19922011-06-20 Deniz Dogan <deniz@dogan.se>
1993
1994 * process.c (Fset_process_buffer): Clarify return value in
1995 docstring.
1996
7d7d0045
CY
19972011-06-18 Chong Yidong <cyd@stupidchicken.com>
1998
1999 * dispnew.c (add_window_display_history): Use BVAR.
2000
2001 * xdisp.c (debug_method_add): Use BVAR.
2002 (check_window_end, dump_glyph_matrix, dump_glyph)
2003 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2004
2005 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2006 Likewise.
2007
2008 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2009 check till after the cache is created in init_frame_faces.
2010
ff2bc410
SM
20112011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2012
2013 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2014
28177add
PE
20152011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2016
dd3482fe
PE
2017 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2018 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2019 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2020
393d71f3 2021 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2022 * fileio.c (Finsert_file_contents):
2023 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2024 Remove the old (too-loose) buffer overflow checks.
2025 They weren't needed, since make_gap checks for buffer overflow.
2026 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2027 The old code merely checked for Emacs fixnum overflow, and relied
2028 on undefined (wraparound) behavior. The new code avoids undefined
2029 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2030
2e6813b0 2031 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2032 Tune. Don't use wider integers than needed. Don't use alloca.
2033 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2034
599a9e4f
PE
2035 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2036
99561444
PE
2037 * insdel.c, lisp.h (buffer_overflow): New function.
2038 (insert_from_buffer_1, replace_range, replace_range_2):
2039 * insdel.c (make_gap_larger):
2040 * editfns.c (Finsert_char):
2041 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2042
28177add
PE
2043 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2044
e69dafad
PE
20452011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2046
a7af7fde 2047 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2048
b1c46f02
PE
2049 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2050 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2051
e69dafad
PE
2052 * fileio.c: Don't assume EMACS_INT fits in off_t.
2053 (emacs_lseek): New static function.
2054 (Finsert_file_contents, Fwrite_region): Use it.
2055 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2056
566684ea
PE
2057 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2058
e6966cd6
PE
2059 * fns.c: Don't overflow int when computing a list length.
2060 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2061 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2062 truncation on 64-bit hosts. Check for QUIT every
2063 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2064 faster and is responsive enough.
2065 (Flength): Report an error instead of overflowing an integer.
2066 (Fsafe_length): Return a float if the value is not representable
2067 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2068 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2069 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2070
dd0b0efb
PE
2071 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2072 (header_size, word_size): New constants.
2073 (allocate_vectorlike): Don't check size overflow here.
2074 (allocate_vector): Check it here instead, since this is the only
2075 caller of allocate_vectorlike that could cause overflow.
2076 Check that the new vector's length is representable as a fixnum.
2077
86fe5cfe
PE
2078 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2079 The previous code was bogus. For example, next_almost_prime (32)
2080 returned 39, which is undesirable as it is a multiple of 3; and
2081 next_almost_prime (24) returned 25, which is a multiple of 5 so
2082 why was the code bothering to check for multiples of 7?
2083
80e88859
PE
2084 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2085
4a2f0ad6
PE
2086 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2087
f66c7cf8
PE
2088 Variadic C functions now count arguments with ptrdiff_t.
2089 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2090 Back then I didn't know that the Emacs coding style prefers signed int.
2091 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2092 were being counted with int, which may truncate counts on 64-bit
2093 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2094 * lisp.h (struct Lisp_Subr.function.aMANY)
2095 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2096 Arg counts are now ptrdiff_t, not size_t.
2097 All variadic functions and their callers changed accordingly.
2098 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2099 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2100 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2101 * callint.c (Fcall_interactively): Check arg count for overflow,
2102 to avoid potential buffer overrun. Use signed char, not 'int',
2103 for 'varies' array, so that we needn't bother to check its size
2104 calculation for overflow.
2105 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2106 * eval.c (apply_lambda):
2107 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2108 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2109 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2110
a1759b76
PE
2111 * callint.c (Fcall_interactively): Don't use index var as event count.
2112
d96be9fc
PE
2113 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2114 * mem-limits.h (SIZE): Remove; no longer used.
2115
a690a978 2116 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2117
578c21e6
PE
2118 Remove unnecessary casts.
2119 * xterm.c (x_term_init):
2120 * xfns.c (x_set_border_pixel):
2121 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2122 These aren't needed now that we assume ANSI C.
2123
96f53c6c
PE
2124 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2125 It's more likely to cause problems (due to unsigned overflow)
2126 than to cure them.
2127
83c77d31
PE
2128 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2129
ee2079f1
PE
2130 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2131
6da65536
PE
2132 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2133
7147c4a4
PE
2134 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2135
193e32d9
PE
2136 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2137
e5533da6
PE
2138 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2139
9910e595
PE
2140 GLYPH_CODE_FACE returns EMACS_INT, not int.
2141 * dispextern.h (merge_faces):
2142 * xfaces.c (merge_faces):
01103c44
PE
2143 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2144 Don't assume EMACS_INT fits in int.
9910e595 2145
2638320e
PE
2146 * character.h (CHAR_VALID_P): Remove unused parameter.
2147 * fontset.c, lisp.h, xdisp.c: All uses changed.
2148
045eb8d9
PE
2149 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2150
c1f134b5
PE
2151 * fns.c (concat): Minor tuning based on overflow analysis.
2152 This doesn't fix any bugs. Use int to hold character, instead
2153 of constantly refetching from Emacs object. Use XFASTINT, not
2154 XINT, for value known to be a character. Don't bother comparing
2155 a single byte to 0400, as it's always less.
2156
395fcb93 2157 * floatfns.c (Fexpt):
327eeec8
PE
2158 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2159
abbd3d23
PE
2160 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2161 for characters.
2162
684a03ef
PE
2163 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2164
0fed43f3
PE
2165 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2166 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2167 incorrectly succeed when S was a string, because 4294967386 was
2168 truncated before it was used.
2169
8fd02eb7
PE
2170 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2171 Otherwise, an out-of-range integer could cause undefined behavior
2172 on a 64-bit host.
2173
f8c86b69
PE
2174 * composite.c: Use int, not EMACS_INT, for characters.
2175 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2176 EMACS_INT, for values that are known to be in character range.
2177 This doesn't fix any bugs but is the usual style inside Emacs and
2178 may generate better code on 32-bit machines.
2179
34206dd2
PE
2180 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2181 This is for reasons similar to the recent CHAR_STRING fix.
2182 * charset.c (Fencode_char): Check that character arg is actually
2183 a character. Pass an int to ENCODE_CHAR.
2184 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2185 wider than 'int', as a compile-time check to prevent future regressions
2186 in this area.
2187
c5958d4c 2188 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2189
2190 Make sure a 64-bit char is never passed to CHAR_STRING.
2191 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2192 by silently ignoring the top 32 bits, allowing some values
2193 that were far too large to be valid characters.
2194 * character.h: Include <verify.h>.
2195 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2196 arguments are no wider than unsigned, as a compile-time check
2197 to prevent future regressions in this area.
2198 * data.c (Faset):
01103c44 2199 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2200 (Fsubst_char_in_region):
2201 * fns.c (concat):
2202 * xdisp.c (decode_mode_spec_coding):
2203 Adjust to CHAR_STRING's new requirement.
2204 * editfns.c (Finsert_char, Fsubst_char_in_region):
2205 * fns.c (concat): Check that character args are actually
2206 characters. Without this test, these functions did the wrong
2207 thing with wildly out-of-range values on 64-bit hosts.
2208
d37ca623
PE
2209 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2210 These casts should not be needed on 32-bit hosts, either.
2211 * keyboard.c (read_char):
2212 * lread.c (Fload): Remove casts to unsigned.
2213
ea204efb
PE
2214 * lisp.h (UNSIGNED_CMP): New macro.
2215 This fixes comparison bugs on 64-bit hosts.
2216 (ASCII_CHAR_P): Use it.
2217 * casefiddle.c (casify_object):
01103c44 2218 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2219 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2220 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2221 * dispextern.h (FACE_FROM_ID):
2222 * keyboard.c (read_char): Use UNSIGNED_CMP.
2223
41cb286c
PE
2224 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2225 not to EMACS_INT, to avoid GCC warning.
2226
4a1b9832
PE
2227 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2228
55daad71
PE
2229 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2230 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2231 isn't needed on 32-bit machines.
8f95c75c 2232
01103c44
PE
2233 * buffer.c (Fgenerate_new_buffer_name):
2234 Use EMACS_INT for count, not int.
0ceccced 2235 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2236
2237 * data.c (Qcompiled_function): Now static.
2238
c6f072e7
PE
2239 * window.c (window_body_lines): Now static.
2240
20ce5912
PE
2241 * image.c (gif_load): Rename local to avoid shadowing.
2242
9c4c5f81
PE
2243 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2244 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2245 * alloc.c (make_save_value): Integer argument is now of type
2246 ptrdiff_t, not int.
2247 (mark_object): Use ptrdiff_t, not int.
2248 * lisp.h (pD): New macro.
2249 * print.c (print_object): Use it.
2250
c0c5c8ae
PE
2251 * alloc.c: Use EMACS_INT, not int, to count objects.
2252 (total_conses, total_markers, total_symbols, total_vector_size)
2253 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2254 (total_free_floats, total_floats, total_free_intervals)
2255 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2256 Now EMACS_INT, not int. All uses changed.
2257 (Fgarbage_collect): Compute overall total using a double, so that
2258 integer overflow is less likely to be a problem. Check for overflow
2259 when converting back to an integer.
5a25e253
PE
2260 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2261 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2262 These were 'int' variables that could overflow on 64-bit hosts;
2263 they were never used, so remove them instead of repairing them.
211a0b2a 2264 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2265 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2266 Previously, this ceilinged at INT_MAX, but that doesn't work on
2267 64-bit machines.
e46bb31a 2268 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2269
c78baabf 2270 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2271 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2272 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2273 when a (possibly-narrower) signed value would do just as well.
2274 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2275
c9d624c6
PE
2276 * alloc.c: Catch some string size overflows that we were missing.
2277 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2278 for convenience in STRING_BYTES_MAX.
2279 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2280 The definition here is exact; the one in lisp.h was approximate.
2281 (allocate_string_data): Check for string overflow. This catches
2282 some instances we weren't catching before. Also, it catches
2283 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2284 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2285 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2286
c9d624c6
PE
2287 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2288 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2289 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2290
353032ce
PE
2291 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2292
2bccce07
PE
2293 * alloc.c (Fmake_string): Check for out-of-range init.
2294
0ac30604
SM
22952011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2296
2297 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2298
c195f2de
JD
22992011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2300
2301 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2302 xg_get_default_scrollbar_width.
2303
2304 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2305 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2306 (style_changed_cb): Call update_theme_scrollbar_width and call
2307 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2308 all frames (Bug#8505).
2309 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2310 Call gtk_window_set_resizable if HAVE_GTK3.
2311 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2312 and height if HAVE_GTK3 (Bug#8505).
2313 (scroll_bar_width_for_theme): New variable.
2314 (update_theme_scrollbar_width): New function.
2315 (xg_get_default_scrollbar_width): Move code to
2316 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2317 (xg_initialize): Call update_theme_scrollbar_width.
2318
2319 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2320
2321 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2322
e10ac9f1
MR
23232011-06-12 Martin Rudalics <rudalics@gmx.at>
2324
2325 * frame.c (make_frame): Call other_buffer_safely instead of
2326 other_buffer.
2327
2328 * window.c (temp_output_buffer_show): Call display_buffer with
2329 second argument Vtemp_buffer_show_specifiers and reset latter
2330 immediately after the call.
2331 (Vtemp_buffer_show_specifiers): New variable.
2332 (auto_window_vscroll_p, next_screen_context_lines)
2333 (Vscroll_preserve_screen_position): Remove leading asterisks from
2334 doc-strings.
2335
2d3c217e 23362011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2337
7b7f97e8 2338 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2339 * buffer.c (Qclone_number): Remove for now, as it's unused.
2340 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2341 (record_buffer): Remove unused local.
2342 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2343 (set_frame_buffer_list): Remove; unused.
2344 * frame.h (other_visible_frames): Remove decl.
2345 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2346 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2347 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2348 if HAVE_GPM.
2349 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2350 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2351 Define only if HAVE_GPM.
2352 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2353 (update_hints_inhibit): Remove; never set. All uses removed.
2354 * widgetprv.h (emacsFrameClassRec): Remove decl.
2355 * window.c (delete_deletable_window): Now returns void, since it
2356 wasn't returning anything.
2357 (compare_window_configurations): Remove unused locals.
2358 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2359 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2360 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2361 the same widths as pointers. This follows up on the 2011-05-06 patch.
2362 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2363 * xterm.h: Likewise.
2364 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2365
1384b89e
JB
23662011-06-12 Juanma Barranquero <lekktu@gmail.com>
2367
2368 * makefile.w32-in: Update dependencies.
2369 (LISP_H): Add lib/intprops.h.
2370
1100a63c
CY
23712011-06-11 Chong Yidong <cyd@stupidchicken.com>
2372
2373 * image.c (gif_load): Add animation frame delay to the metadata.
2374 (syms_of_image): Use DEFSYM. New symbol `delay'.
2375
6198ccd0
MR
23762011-06-11 Martin Rudalics <rudalics@gmx.at>
2377
2378 * window.c (delete_deletable_window): Re-add.
2379 (Fset_window_configuration): Rewrite to handle dead buffers and
2380 consequently deletable windows.
2381 (window_tree, Fwindow_tree): Remove. Supply functionality in
2382 window.el.
2383 (compare_window_configurations): Simplify code.
2384
b6e3633c
AS
23852011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2386
1ab0dee5
AS
2387 * image.c (imagemagick_load_image): Fix type mismatch.
2388 (Fimagemagick_types): Likewise.
2389
b6e3633c
AS
2390 * window.h (replace_buffer_in_windows): Declare.
2391
9397e56f
MR
23922011-06-11 Martin Rudalics <rudalics@gmx.at>
2393
2394 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2395 Qclone_number. Remove external declaration of Qdelete_window.
2396 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2397 code.
640c8776
SM
2398 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2399 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2400 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2401 buffer list implementation.
2402 (other_buffer_safely): New function.
2403 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2404 calls to replace_buffer_in_windows and
2405 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2406 if allowed.
2407 (record_buffer): Inhibit quitting and rewrite using quittable
2408 functions. Run Qbuffer_list_update_hook if allowed.
2409 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2410 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2411 Move switch-to-buffer to window.el.
9397e56f
MR
2412 (bury-buffer): Move to window.el.
2413 (Vbuffer_list_update_hook): New variable.
2414
2415 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2416 section.
2417
2418 * window.h (resize_frame_windows): Move up in code.
2419 (Fwindow_frame): Remove EXFUN.
2420 (replace_buffer_in_all_windows): Remove prototype.
2421 (replace_buffer_in_windows_safely): Add prototype.
2422
2423 * window.c: Declare Qdelete_window static again. Move down
2424 declaration of select_count.
2425 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2426 (Fother_window): Move to window.el.
2427 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2428 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2429 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2430 window.el.
2431 (replace_buffer_in_windows): Implement by calling
2432 Qreplace_buffer_in_windows.
2433 (replace_buffer_in_all_windows): Remove with some functionality
2434 moved into replace_buffer_in_windows_safely.
2435 (replace_buffer_in_windows_safely): New function.
2436 (select_window_norecord, select_frame_norecord): Move in front
2437 of run_window_configuration_change_hook. Remove now obsolete
2438 declarations.
640c8776
SM
2439 (Fset_window_buffer): Rewrite doc-string.
2440 Call Qrecord_window_buffer.
9397e56f
MR
2441 (keys_of_window): Move binding for other-window to window.el.
2442
b50691aa
CY
24432011-06-11 Chong Yidong <cyd@stupidchicken.com>
2444
2445 * dispextern.h (struct image): Replace data member, whose int_val
2446 and ptr_val fields were not used by anything, with a single
2447 lisp_val object.
2448
2449 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2450 (gif_clear_image, gif_load, imagemagick_load_image)
2451 (gs_clear_image, gs_load): Callers changed.
2452
3f754b86
PE
24532011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2454
cca69397
PE
2455 * buffer.h: Include <time.h>, for time_t.
2456 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2457
109e28d0
PE
2458 Fix minor problems found by static checking.
2459
60737f02
PE
2460 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2461
4b66faf3
PE
2462 Make identifiers static if they are not used in other modules.
2463 * data.c (Qcompiled_function, Qframe, Qvector):
2464 * image.c (QimageMagick, Qsvg):
2465 * minibuf.c (Qmetadata):
2466 * window.c (resize_window_check, resize_root_window): Now static.
2467 * window.h (resize_window_check, resize_root_window): Remove decls.
2468
109e28d0
PE
2469 * window.c (window_deletion_count, delete_deletable_window):
2470 Remove; unused.
46a4ce9e
PE
2471 (window_body_lines): Now static.
2472 (Fdelete_other_windows_internal): Mark vars as initialized.
2473 Make sure 'resize_failed' is initialized.
2474 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2475 (resize_window_apply): Remove unused local.
2476 * window.h (delete_deletable_window): Remove decl.
2477
109e28d0 2478 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2479 (imagemagick_load_image): Fix pointer signedness problem by changing
2480 last arg from unsigned char * to char *. All uses changed.
2481 Also, fix a local for similar reasons.
2482 Remove unused locals. Remove locals to avoid shadowing.
2483 (fn_rsvg_handle_free): Remove; unused.
2484 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2485 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2486
3f754b86
PE
2487 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2488
2547adb1
CY
24892011-06-10 Chong Yidong <cyd@stupidchicken.com>
2490
2491 * image.c (gif_load): Fix omitted cast error introduced by
2492 2011-06-06 change.
2493
2c8e37d4
MR
24942011-06-10 Martin Rudalics <rudalics@gmx.at>
2495
2496 * window.h (resize_proportionally, orig_total_lines)
2497 (orig_top_line): Remove from window structure.
2498 (set_window_height, set_window_width, change_window_heights)
2499 (Fdelete_window): Remove prototypes.
2500 (resize_frame_windows): Remove duplicate declaration.
2501
440a42e3
EZ
25022011-06-10 Eli Zaretskii <eliz@gnu.org>
2503
2504 * window.h (resize_frame_windows, resize_window_check)
2505 (delete_deletable_window, resize_root_window)
2506 (resize_frame_windows): Declare prototypes.
2507
2508 * window.c (resize_window_apply): Make definition be "static" to
2509 match the prototype.
2510
562dd5e9
MR
25112011-06-10 Martin Rudalics <rudalics@gmx.at>
2512
2513 * window.c: Remove declarations of Qwindow_size_fixed,
2514 window_min_size_1, window_min_size_2, window_min_size,
2515 size_window, window_fixed_size_p, enlarge_window, delete_window.
2516 Remove static from declaration of Qdelete_window, it's
2517 temporarily needed by Fbury_buffer.
2518 (replace_window): Don't assign orig_top_line and
2519 orig_total_lines.
2520 (Fdelete_window, delete_window): Remove. Window deletion is
2521 handled by window.el.
640c8776
SM
2522 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2523 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2524 (Fdelete_other_windows): Remove. Deleting other windows is
2525 handled by window.el.
2526 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2527 handled in window.el.
2528 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2529 Window minimum sizes are handled in window.el.
2530 (shrink_windows, size_window, set_window_height)
2531 (set_window_width, change_window_heights, window_height)
2532 (window_width, CURBEG, CURSIZE, enlarge_window)
2533 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2534 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2535 handled in window.el.
2536 (make_dummy_parent): Rename to make_parent_window and give it a
2537 second argument horflag.
2538 (make_window): Don't set resize_proportionally any more.
2539 (Fsplit_window): Remove. Windows are split in window.el.
2540 (save_restore_action, save_restore_orig_size)
2541 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2542 Resize mini windows in window.el.
2543 (grow_mini_window, shrink_mini_window): Implement by calling
2544 Qresize_root_window_vertically, resize_window_check and
2545 resize_window_apply.
640c8776
SM
2546 (saved_window, Fset_window_configuration, save_window_save):
2547 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2548 resize_proportionally.
2549 (window_min_height, window_min_width): Move to window.el.
2550 (keys_of_window): Move bindings for delete-other-windows,
2551 split-window, delete-window and enlarge-window to window.el.
2552
2553 * buffer.c: Temporarily extern Qdelete_window.
2554 (Fbury_buffer): Temporarily call Qdelete_window instead of
2555 Fdelete_window (Fbury_buffer will move to window.el soon).
2556
2557 * frame.c (set_menu_bar_lines_1): Remove code handling
2558 orig_top_line and orig_total_lines.
2559
2560 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2561 set_window_height but set heights directly.
2562 (change_frame_size_1): Use resize_frame_windows.
2563
2564 * xdisp.c (init_xdisp): Don't use set_window_height but set
2565 heights directly.
2566
640c8776
SM
2567 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2568 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2569 run_window_configuration_change_hook.
2570
2571 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2572 instead of change_window_heights and run
2573 run_window_configuration_change_hook.
2574
1a13852e
MR
25752011-06-09 Martin Rudalics <rudalics@gmx.at>
2576
2577 * window.c (replace_window): Rename second argument REPLACEMENT to
2578 NEW. New third argument SETFLAG. Rewrite.
2579 (delete_window, make_dummy_parent): Call replace_window with
2580 third argument 1.
2581 (window_list_1): Move down in code.
2582 (run_window_configuration_change_hook): Move set_buffer part
2583 before select_frame_norecord part in order to unwind correctly.
2584 Rename count1 to count.
2585 (recombine_windows, delete_deletable_window, resize_root_window)
2586 (Fdelete_other_windows_internal)
2587 (Frun_window_configuration_change_hook, make_parent_window)
2588 (resize_window_check, resize_window_apply, Fresize_window_apply)
2589 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2590 (Fdelete_window_internal, Fresize_mini_window_internal):
2591 New functions.
1a13852e
MR
2592 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2593
f3d1777e
MR
25942011-06-08 Martin Rudalics <rudalics@gmx.at>
2595
496e208e
MR
2596 * window.h (window): Add some new members to window structure -
2597 normal_lines, normal_cols, new_total, new_normal, clone_number,
2598 splits, nest, prev_buffers, next_buffers.
2599 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2600 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2601
f3d1777e
MR
2602 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2603 Remove.
496e208e
MR
2604 (make_dummy_parent): Set new members of windows structure.
2605 (make_window): Move down in code. Handle new members of window
2606 structure.
2607 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2608 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2609 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2610 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2611 (Fset_window_next_buffers, Fset_window_clone_number):
2612 New functions.
496e208e
MR
2613 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2614 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2615 Doc-string fixes.
2616 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2617 Argument WINDOW can be now internal window too.
2618 (Fwindow_use_time): Move up in code.
2619 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2620 Rewrite doc-string.
2621 (Fset_window_configuration, saved_window)
2622 (Fcurrent_window_configuration, save_window_save): Handle new
2623 members of window structure.
b9e809c2
MR
2624 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2625 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2626 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2627 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2628 Qget_mru_window, Qresize_root_window,
2629 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2630 Qauto_buffer_name; staticpro them.
f3d1777e 2631
abde8f8c
MR
26322011-06-07 Martin Rudalics <rudalics@gmx.at>
2633
2634 * window.c (Fwindow_total_size, Fwindow_left_column)
2635 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2636 (Fwindow_list_1): New functions.
2637 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2638 (Fwindow_width, Fscroll_left, Fscroll_right):
2639 Use window_body_cols instead of window_box_text_cols.
2640 (delete_window, Fset_window_configuration):
2641 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2642 (delete_all_subwindows): Take a window as argument and not a
2643 structure. Rewrite.
190b47e6
MR
2644 (window_loop): Remove handling of GET_LRU_WINDOW and
2645 GET_LARGEST_WINDOW.
2646 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2647
2648 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2649 window_box_text_cols. delete_all_subwindows now takes a
2650 Lisp_Object as argument.
abde8f8c 2651
640c8776
SM
2652 * indent.c (compute_motion, Fcompute_motion):
2653 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2654
fa8a67e6
MR
2655 * frame.c (delete_frame): Call delete_all_subwindows with root
2656 window as argument.
2657
a54e3482
DC
26582011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2659
2660 * fns.c (Fputhash): Document return value.
2661
60002bf5
CY
26622011-06-06 Chong Yidong <cyd@stupidchicken.com>
2663
2664 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2665
0c671da6 26662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2667
b862a52a 2668 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2669
be44ca6c
PE
2670 Check for overflow when converting integer to cons and back.
2671 * charset.c (Fdefine_charset_internal, Fdecode_char):
2672 Use cons_to_unsigned to catch overflow.
2673 (Fencode_char): Use INTEGER_TO_CONS.
2674 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2675 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2676 * data.c (long_to_cons, cons_to_long): Remove.
2677 (cons_to_unsigned, cons_to_signed): New functions.
2678 These signal an error for invalid or out-of-range values.
2679 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2680 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2681 * font.c (Ffont_variation_glyphs):
2682 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2683 * lisp.h: Include <intprops.h>.
2684 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2685 (cons_to_signed, cons_to_unsigned): New decls.
2686 (long_to_cons, cons_to_long): Remove decls.
2687 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2688 (Fprimitive_undo): Use CONS_TO_INTEGER.
2689 * xfns.c (Fx_window_property): Likewise.
2690 * xselect.c: Include <limits.h>.
2691 (x_own_selection, selection_data_to_lisp_data):
2692 Use INTEGER_TO_CONS.
2693 (x_handle_selection_request, x_handle_selection_clear)
2694 (x_get_foreign_selection, Fx_disown_selection_internal)
2695 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2696 (lisp_data_to_selection_data): Use cons_to_unsigned.
2697 (x_fill_property_data): Use cons_to_signed.
2698 Report values out of range.
2699
d1f3d2af
PE
2700 Check for buffer and string overflow more precisely.
2701 * buffer.h (BUF_BYTES_MAX): New macro.
2702 * lisp.h (STRING_BYTES_MAX): New macro.
2703 * alloc.c (Fmake_string):
2704 * character.c (string_escape_byte8):
2705 * coding.c (coding_alloc_by_realloc):
2706 * doprnt.c (doprnt):
2707 * editfns.c (Fformat):
2708 * eval.c (verror):
2709 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2710 since they may not be the same number.
2711 * editfns.c (Finsert_char):
2712 * fileio.c (Finsert_file_contents):
2713 Likewise for BUF_BYTES_MAX.
2714
dd52fcea
PE
2715 * image.c: Use ptrdiff_t, not int, for sizes.
2716 (slurp_file): Switch from int to ptrdiff_t.
2717 All uses changed.
2718 (slurp_file): Check that file size fits in both size_t (for
2719 malloc) and ptrdiff_t (for sanity and safety).
2720
7f9bbdbb
PE
2721 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2722 if b->modtime has its maximal value.
2723
dfe18f82
PE
2724 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2725
84acfcf0
PE
2726 Don't assume time_t can fit into int.
2727 * buffer.h (struct buffer.modtime): Now time_t, not int.
2728 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2729 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2730
ccd9a01a
PE
2731 Minor fixes for signed vs unsigned integers.
2732 * character.h (MAYBE_UNIFY_CHAR):
2733 * charset.c (maybe_unify_char):
2734 * keyboard.c (read_char, reorder_modifiers):
2735 XINT -> XFASTINT, since the integer must be nonnegative.
2736 * ftfont.c (ftfont_spec_pattern):
2737 * keymap.c (access_keymap, silly_event_symbol_error):
2738 XUINT -> XFASTINT, since the integer must be nonnegative.
2739 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2740 since it makes no difference and we prefer signed.
2741 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2742 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2743 nonnegative.
2744
d6d100dd
SM
27452011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2746
2747 * window.h (Fwindow_frame): Declare.
2748
2b6148e4
PE
27492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2750
2751 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2752 (SPARE_MEMORY): Always define.
2753 (LARGE_REQUEST): Remove.
2754 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2755
f230ecc9
MR
27562011-06-06 Martin Rudalics <rudalics@gmx.at>
2757
727e958e
MR
2758 * lisp.h: Move EXFUNS for Fframe_root_window,
2759 Fframe_first_window and Fset_frame_selected_window to window.h.
2760
2761 * window.h: Move EXFUNS for Fframe_root_window,
2762 Fframe_first_window and Fset_frame_selected_window here from
2763 lisp.h.
2764
2765 * frame.c (Fwindow_frame, Fframe_first_window)
2766 (Fframe_root_window, Fframe_selected_window)
2767 (Fset_frame_selected_window): Move to window.c.
2768 (Factive_minibuffer_window): Move to minibuf.c.
2769 (Fother_visible_frames_p): New function.
2770
2771 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2772
f230ecc9
MR
2773 * window.c (decode_window, decode_any_window): Move up in code.
2774 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2775 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2776 (Fwindow_buffer): Move up and rewrite doc-string.
2777 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2778 (Fwindow_prev): New functions.
727e958e
MR
2779 (Fwindow_frame): Move here from frame.c. Accept any window as
2780 argument.
2781 (Fframe_root_window, Fframe_first_window)
2782 (Fframe_selected_window): Move here from frame.c. Accept frame
2783 or arbitrary window as argument. Update doc-strings.
2784 (Fminibuffer_window): Move up in code.
2785 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2786 (Fset_frame_selected_window): Move here from frame.c.
2787 Marginal rewrite.
727e958e
MR
2788 (Fselected_window, select_window, Fselect_window): Move up in
2789 code. Minor doc-string fixes.
f230ecc9 2790
4d09bcf6
PE
27912011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2792
2793 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2794 Do not assume that spare memory exists; that assumption is valid
2795 only if SYSTEM_MALLOC.
2796 (LARGE_REQUEST): New macro, so that the issue of large requests
2797 is separated from the issue of spare memory.
2798
810928a2
AS
27992011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2800
172418ad
AS
2801 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2802 format. (Bug#8806)
2803
43f862f7
AS
2804 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2805
810928a2
AS
2806 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2807 before statements.
2808
a059fe24
JD
28092011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2810
2811 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2812
2813 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2814
2815 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2816 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2817
989bf368
JB
28182011-06-05 Juanma Barranquero <lekktu@gmail.com>
2819
2820 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2821
4b80f674
CY
28222011-06-04 Chong Yidong <cyd@stupidchicken.com>
2823
2824 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2825 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2826 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2827 New error handlers.
4b80f674
CY
2828 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2829 Obey Vx_select_enable_clipboard_manager. Catch errors in
2830 x_clipboard_manager_save (Bug#8779).
2831 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2832 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2833
99a33b77 28342011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2835
2836 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2837
99a33b77 28382011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2839
2840 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2841 in the current matrix if keep_current_p is non-zero.
2842
8264569d
EZ
28432011-06-04 Eli Zaretskii <eliz@gnu.org>
2844
2845 * bidi.c (bidi_level_of_next_char): Fix last change.
2846
57f97249
EZ
28472011-06-03 Eli Zaretskii <eliz@gnu.org>
2848
fec2107c 2849 Support bidi reordering of text covered by display properties.
57f97249 2850
fec2107c
EZ
2851 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2852 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2853 (bidi_cache_search, bidi_cache_iterator_state)
2854 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2855 (bidi_level_of_next_char, bidi_move_to_visually_next):
2856 Support character positions inside a run of characters covered by a
fec2107c
EZ
2857 display string.
2858 (bidi_paragraph_init, bidi_resolve_explicit_1)
2859 (bidi_level_of_next_char): Call bidi_fetch_char and
2860 bidi_fetch_char_advance instead of FETCH_CHAR and
2861 FETCH_CHAR_ADVANCE.
2862 (bidi_init_it): Initialize new members.
2863 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2864 definitions.
2865 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2866 instead of using explicit *_CHAR codes.
d6d100dd
SM
2867 (bidi_resolve_explicit, bidi_resolve_weak):
2868 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2869 bidirectional text is supported only in multibyte buffers.
2870 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2871 it to initialize the frame_window_p member of struct bidi_it.
2872 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2873 (bidi_resolve_explicit, bidi_resolve_weak)
2874 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2875 bidi_it->nchars is non-positive.
2876 (bidi_level_of_next_char): Don't try to lookup the cache for the
2877 next/previous character if nothing is cached there yet, or if we
2878 were just reseat()'ed to a new position.
c40e2fb2 2879
0e14fe90
EZ
2880 * xdisp.c (set_cursor_from_row): Set start and stop points
2881 according to the row's direction when priming the loop that looks
2882 for the glyph on which to display cursor.
2883 (single_display_spec_intangible_p): Function deleted.
2884 (display_prop_intangible_p): Reimplement to call
2885 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2886 Accept 3 additional arguments needed by handle_display_spec.
2887 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2888 values: lists, `(when COND...)' forms, etc.
2889 (single_display_spec_string_p): Support property values that are
2890 lists with the argument STRING its top-level element.
2891 (display_prop_string_p): Fix the condition for processing a
2892 property that is a list to be consistent with handle_display_spec.
fec2107c 2893 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2894 last portion of handle_display_prop.
2895 (compute_display_string_pos): Accept additional argument
2896 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2897 value of a `display' property is a "replacing spec".
2898 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2899 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2900 the display property, but just return a value indicating whether
2901 the display property will replace the characters it covers.
2902 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2903 frame_window_p members of struct bidi_it.
d6d100dd
SM
2904 (compute_display_string_pos, compute_display_string_end):
2905 New functions.
fec2107c
EZ
2906 (push_it): Accept second argument POSITION, where pop_it should
2907 jump to continue iteration.
2908 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2909
fec2107c
EZ
2910 * keyboard.c (adjust_point_for_property): Adjust the call to
2911 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2912
2913 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2914 (bidi_init_it): Update prototypes.
2915 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2916 (compute_display_string_pos, compute_display_string_end):
2917 Declare prototypes.
fec2107c
EZ
2918 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2919 EMACS_INT.
fc6f18ce 2920
40087514 29212011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2922
57f53182
PE
2923 Malloc failure behavior now depends on size of allocation.
2924 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2925 * lisp.h: Change signatures accordingly.
2926 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2927 All callers changed. (Bug#8762)
2928
2929 * gnutls.c: Use Emacs's memory allocators.
2930 Without this change, the gnutls library would invoke malloc etc.
2931 directly, which causes problems on non-SYNC_INPUT hosts, and which
2932 runs afoul of improving memory_full behavior. (Bug#8761)
2933 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2934 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2935 xfree instead of the default malloc, realloc, free.
2936 (Fgnutls_boot): No need to check for memory allocation failure,
2937 since xmalloc does that for us.
2938
ac32cd99 2939 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2940 * category.c (hash_get_category_set):
2941 * ccl.c (ccl_driver):
2942 * charset.c (Fdefine_charset_internal):
2943 * charset.h (struct charset.hash_index):
2944 * composite.c (get_composition_id, gstring_lookup_cache)
2945 (composition_gstring_put_cache):
2946 * composite.h (struct composition.hash_index):
2947 * dispextern.h (struct image.hash):
2948 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2949 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2950 (hashfn_equal, hashfn_user_defined, make_hash_table)
2951 (maybe_resize_hash_table, hash_lookup, hash_put)
2952 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2953 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2954 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2955 * image.c (make_image, search_image_cache, lookup_image)
2956 (xpm_put_color_table_h):
2957 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2958 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2959 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2960 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2961 * alloc.c (allocate_vectorlike):
2962 Check for overflow in vector size calculations.
2963 * ccl.c (ccl_driver):
2964 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2965 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2966 need to be updated by these changes.
40087514
PE
2967 * fns.c (make_hash_table, maybe_resize_hash_table):
2968 Check for integer overflow with large hash tables.
0de4bb68
PE
2969 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2970 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2971 (SXHASH_REDUCE): New macro.
2972 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2973 Use it instead of discarding useful hash info with large hash values.
2974 (sxhash_float): New function.
2975 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2976 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2977 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2978 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2979 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2980 Adjust signatures to match updated version of code.
2981 (consing_since_gc): Now EMACS_INT, since a single hash table can
2982 use more than INT_MAX bytes.
2983
698d32e2
DN
29842011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2985
2986 Make it possible to build with GCC-4.6+ -O2 -flto.
2987
2988 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2989
fd6fa53f
SM
29902011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2991
2992 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2993 Call minibuffer-inactive-mode.
2994
864db017
JB
29952011-05-31 Juanma Barranquero <lekktu@gmail.com>
2996
2997 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2998 Update dependencies.
2999
2ad0baf4
DN
30002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3001
3002 * data.c (init_data): Remove code for UTS, this system is not
3003 supported anymore.
3004
4fcc2638
DN
30052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3006
3007 Don't force ./temacs to start in terminal mode.
3008
3009 * frame.c (make_initial_frame): Initialize faces in all cases, not
3010 only when CANNOT_DUMP is defined.
3011 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3012
c56e0fd5
DN
30132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3014
3015 * dispnew.c (add_window_display_history): Use const for the string
3016 pointer. Remove declaration, not needed.
3017
333d54da 30182011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3019
55d4c1b2 3020 Use 'inline', not 'INLINE'.
333d54da 3021 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3022 * alloc.c, fontset.c (INLINE): Remove.
3023 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3024 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3025 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3026 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3027 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3028
738db178
DN
30292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3030
3031 Make it possible to run ./temacs.
3032
3033 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3034 syms_of_callproc does the same thing. Remove test for
3035 "initialized", do it in the caller.
3036 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3037
620c53a6
SM
30382011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3039
3040 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3041 (read_minibuf): Use get_minibuffer.
3042 (syms_of_minibuf): Use DEFSYM.
3043 (Qmetadata): New var.
3044 * data.c (Qbuffer): Don't make it static.
3045 (syms_of_data): Use DEFSYM.
3046
e003a292
PE
30472011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3048
3049 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3050 (CCL_CODE_MIN): New macro.
3051
ed008a6d
PE
30522011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3053
3687c2ef
PE
3054 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3055
ed008a6d
PE
3056 * eval.c (Qdebug): Now static.
3057 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3058 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3059 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3060
d66c4c7c
CY
30612011-05-29 Chong Yidong <cyd@stupidchicken.com>
3062
3063 * image.c: Various fixes to ImageMagick code comments.
3064 (Fimagemagick_types): Doc fix.
3065
5fbc2025
PE
30662011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3067
0196f88a
PE
3068 Minor fixes prompted by GCC 4.6.0 warnings.
3069
3070 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3071
5fbc2025
PE
3072 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3073 (x_clipboard_manager_save_all): Move extern decl to ...
3074 * xterm.h: ... here, so that it can be checked for consistency.
3075
1dd3c2d9
CY
30762011-05-29 Chong Yidong <cyd@stupidchicken.com>
3077
3078 * xselect.c (x_clipboard_manager_save_frame)
3079 (x_clipboard_manager_save_all): New functions.
3080 (Fx_clipboard_manager_save): Lisp function deleted.
3081
3082 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3083 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3084
3085 * xterm.h: Update prototype.
3086
5ba6571d
WX
30872011-05-28 William Xu <william.xwl@gmail.com>
3088
3089 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3090 exiting (Bug#8239).
3091
3eaff834
JM
30922011-05-28 Jim Meyering <meyering@redhat.com>
3093
e1900994 3094 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3095 * fns.c (to_uchar): Define.
3096 (crypto_hash_function): Use it to convert some newly-signed
3097 variables to unsigned, to avoid sign-extension bugs. For example,
3098 without this change, (md5 "truc") would evaluate to
3099 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3100 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3101 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3102
0f6990a7
PE
31032011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3104
3105 Integer overflow fixes.
c8a9ca5a 3106
08686060
PE
3107 * dbusbind.c: Serial number integer overflow fixes.
3108 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3109 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3110 to hold a serial number that is too large for a fixnum.
3111 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3112 Check for serial numbers out of range. Decode any serial number
59568bf0 3113 that was so large that it became a float. (Bug#8722)
08686060 3114
2d1fc3c7
PE
3115 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3116 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3117 Use XFASTINT rather than XUINT when numbers are nonnegative.
3118 (xd_append_arg, Fdbus_method_return_internal):
3119 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3120 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3121 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3122 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3123 (Bug#8722)
2d1fc3c7 3124
c8a9ca5a
PE
3125 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3126
519e1d69
PE
3127 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3128
30569699
PE
3129 ccl: add integer overflow checks
3130 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3131 (IN_INT_RANGE): New macros.
3132 (ccl_driver): Use them to check for integer overflow when
3133 decoding a CCL program. Many of the new checks are whether XINT (x)
3134 fits in int; it doesn't always, on 64-bit hosts. The new version
3135 doesn't catch all possible integer overflows, but it's an
847044ea 3136 improvement. (Bug#8719)
30569699 3137
c11285dc
PE
3138 * alloc.c (make_event_array): Use XINT, not XUINT.
3139 There's no need for unsigned here.
3140
fdccd48e
PE
3141 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3142 This follows up to the 2011-05-06 change that substituted uintptr_t
3143 for EMACS_INT. This case wasn't caught back then.
3144
37910ab2
PE
3145 Rework Fformat to avoid integer overflow issues.
3146 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3147 now (part of C89). Include <verify.h>.
3148 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3149 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3150 (Fformat): Avoid the prepass trying to compute sizes; it was only
3151 approximate and thus did not catch overflow reliably. Instead, walk
3152 through the format just once, formatting and computing sizes as we go,
3153 checking for integer overflow at every step, and allocating a larger
3154 buffer as needed. Keep track separately whether the format is
3155 multibyte. Keep only the most-recently calculated precision, rather
3156 than them all. Record whether each argument has been converted to
3157 string. Use EMACS_INT, not int, for byte and char and arg counts.
3158 Support field widths and precisions larger than INT_MAX. Avoid
3159 sprintf's undefined behavior with conversion specifications such as %#d
3160 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3161 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3162 formatting out-of-range floating point numbers with int
9173deec 3163 formats. (Bug#8668)
37910ab2 3164
2e6578fb
PE
3165 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3166
0ae6bdee
PE
3167 * data.c: Avoid integer truncation in expressions involving floats.
3168 * data.c: Include <intprops.h>.
3169 (arith_driver): When there's an integer overflow in an expression
3170 involving floating point, convert the integers to floating point
3171 so that the resulting value does not suffer from catastrophic
3172 integer truncation. For example, on a 64-bit host (* 4
3173 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3174 Do not rely on undefined behavior after integer overflow.
3175
de883a70
PE
3176 merge count_size_as_multibyte, parse_str_to_multibyte
3177 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3178 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3179 Check for integer overflow.
3180 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3181 since it's now a duplicate of the other. This is more of
3182 a character than a buffer op, so better that it's in character.c.
3183 * fns.c, print.c: Adjust to above changes.
3184
2ff916cb
PE
31852011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3186
3187 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3188
f1b54466
PE
31892011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3190
fb1ac845
PE
3191 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3192 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3193 (x_clipboard_manager_save): Now static.
3194 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3195
f1b54466
PE
3196 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3197 (crypto_hash_function): Now static.
3198 Fix pointer signedness problems. Avoid unnecessary initializations.
3199
a9f737ee
CY
32002011-05-27 Chong Yidong <cyd@stupidchicken.com>
3201
3202 * termhooks.h (Vselection_alist): Make it terminal-local.
3203
3204 * terminal.c (create_terminal): Initialize it.
3205
3206 * xselect.c: Support for clipboard managers.
3207 (Vselection_alist): Move to termhooks.h as terminal-local var.
3208 (LOCAL_SELECTION): New macro.
3209 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3210 (symbol_to_x_atom): Remove gratuitous arg.
3211 (x_handle_selection_request, lisp_data_to_selection_data)
3212 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3213 (x_own_selection, x_get_local_selection, x_convert_selection):
3214 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3215 (some_frame_on_display): Delete unused function.
3216 (Fx_own_selection_internal, Fx_get_selection_internal)
3217 (Fx_disown_selection_internal, Fx_selection_owner_p)
3218 (Fx_selection_exists_p): New optional frame arg.
3219 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3220 (x_handle_selection_clear): Don't treat other terminals with the
3221 same keyboard specially. Use the terminal-local Vselection_alist.
3222 (x_clear_frame_selections): Use Frun_hook_with_args.
3223
3224 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3225
3226 * xterm.h: Add support for those atoms.
3227
e067f0c1
CY
32282011-05-26 Chong Yidong <cyd@stupidchicken.com>
3229
3230 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3231 (converted_selections, conversion_fail_tag): New global variables.
3232 (x_selection_request_lisp_error): Free the above.
3233 (x_get_local_selection): Remove unnecessary code.
3234 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3235 of converted selections stored in converted_selections.
3236 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3237 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3238 (x_convert_selection): New function.
3239 (x_handle_selection_event): Simplify.
3240 (x_get_foreign_selection): Don't ignore incoming requests while
3241 waiting for an answer; this will fail when we implement
3242 SAVE_TARGETS, and seems unnecessary anyway.
3243 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3244 (Vx_sent_selection_functions): Doc fix.
3245
0f4aebc0
LL
32462011-05-26 Leo Liu <sdl.web@gmail.com>
3247
3248 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3249
e61124cd
YM
32502011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3251
3252 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3253
3254 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3255 for fringe update if it has periodic bitmap.
ac389d0c 3256 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3257 and fringe_bitmap_periodic_p.
3258
3259 * fringe.c (get_fringe_bitmap_data): New function.
3260 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3261 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3262 row. Mark glyph row for fringe update if periodicity changed.
3263
3264 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3265 for fringe update unless it has periodic bitmap.
3266
f16d9837
KH
32672011-05-25 Kenichi Handa <handa@m17n.org>
3268
3269 * xdisp.c (get_next_display_element): Set correct it->face_id for
3270 a static composition.
3271
e1b90ef6
LL
32722011-05-24 Leo Liu <sdl.web@gmail.com>
3273
3274 * deps.mk (fns.o):
3275 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3276
3277 * fns.c (crypto_hash_function, Fsha1): New function.
3278 (Fmd5): Use crypto_hash_function.
3279 (syms_of_fns): Add Ssha1.
3280
7400048f
PE
32812011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3282
3283 * gnutls.c: Remove unused macros.
3284 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3285 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3286 Remove macros that are defined and never used.
3287 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3288
abb71cf4
CY
32892011-05-22 Chong Yidong <cyd@stupidchicken.com>
3290
3291 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3292 (Fx_get_selection_internal): Minor cleanup.
3293 (Fx_own_selection_internal): Rename arguments for consistency with
3294 select.el.
3295
6307db39
PE
32962011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3297
3298 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3299
f3d4e0a4
CY
33002011-05-22 Chong Yidong <cyd@stupidchicken.com>
3301
3302 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3303
4d8ade89
YM
33042011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3305
3306 * dispnew.c (scrolling_window): Don't exclude the case that the
3307 last enabled row in the desired matrix touches the bottom boundary.
3308
32078c8d
GM
33092011-05-21 Glenn Morris <rgm@gnu.org>
3310
3311 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3312 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3313 and add some more files.
32078c8d 3314
7285dc67
EZ
33152011-05-20 Eli Zaretskii <eliz@gnu.org>
3316
3317 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3318 report_file_error introduced by the change from 2011-05-07.
3319
89d1bd22
PE
33202011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3321
3322 * systime.h (Time): Define only if emacs is defined.
3323 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3324 where the include path doesn't have X11/X.h by default. See
3325 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3326
e23640bb 33272011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3328
3329 * composite.c (find_automatic_composition): Fix previous change.
3330
b9704ad9
GM
33312011-05-20 Glenn Morris <rgm@gnu.org>
3332
3333 * lisp.mk: New file, split from Makefile.in.
3334 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3335 (shortlisp): Remove.
3336 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3337
4a720484
GM
33382011-05-19 Glenn Morris <rgm@gnu.org>
3339
3340 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3341 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3342 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3343 (lisp): Set the order to that of loadup.el.
3344 (shortlisp): Make it a copy of $lisp.
3345 (SOME_MACHINE_LISP): Remove.
3346 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3347 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3348
a28d4396
KH
33492011-05-18 Kenichi Handa <handa@m17n.org>
3350
3351 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3352 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3353 (find_automatic_composition): Mostly rewrite for efficiency.
3354
a2b1fa8e
JB
33552011-05-18 Juanma Barranquero <lekktu@gmail.com>
3356
3357 * makefile.w32-in: Update dependencies.
3358
8e1f5610
CS
33592011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3360
3361 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3362 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3363
7025ee00 33642011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3365
cdfa6eab
PE
3366 Fix some integer overflow issues, such as string length overflow.
3367
06d6db33
PE
3368 * insdel.c (count_size_as_multibyte): Check for string overflow.
3369
2b4560a8
PE
3370 * character.c (lisp_string_width): Check for string overflow.
3371 Use EMACS_INT, not int, for string indexes and lengths; in
3372 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3373 the resulting string length overflows an EMACS_INT; instead,
3374 report a string overflow if no precision given. When checking for
3375 precision exhaustion, use a check that cannot possibly have
3376 integer overflow. (Bug#8675)
3377 * character.h (lisp_string_width): Adjust to new signature.
3378
cb93f9be
PE
3379 * alloc.c (string_overflow): New function.
3380 (Fmake_string): Use it. This doesn't change behavior, but saves
3381 a few bytes and will simplify future changes.
3382 * character.c (string_escape_byte8): Likewise.
3383 * lisp.h (string_overflow): New decl.
3384
1a1f3366
PE
3385 Fixups, following up to the user-interface timestamp change.
3386 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3387 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3388 * msdos.c (mouse_get_pos): Likewise.
3389 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3390 * w32gui.h (Time): Define by including "systime.h" rather than by
3391 declaring it ourselves. (Bug#8664)
3392
d4e3e4d3
PE
3393 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3394 * image.c (clear_image_cache): Likewise.
3395
f6a24d19
PE
3396 * term.c (term_mouse_position): Don't assume time_t wraparound.
3397
08dc5ae6
PE
3398 Be more systematic about user-interface timestamps.
3399 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3400 and sometimes 'EMACS_UINT', to represent these timestamps.
3401 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3402 This makes the code easier to follow, and makes it easier to catch
3403 integer overflow bugs such as Bug#8664.
3404 * frame.c (Fmouse_position, Fmouse_pixel_position):
3405 Use Time, not unsigned long, for user-interface timestamps.
3406 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3407 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3408 * keyboard.h (last_event_timestamp): Likewise.
3409 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3410 * menu.h (xmenu_show): Likewise.
3411 * term.c (term_mouse_position): Likewise.
3412 * termhooks.h (struct input_event.timestamp): Likewise.
3413 (struct terminal.mouse_position_hook): Likewise.
3414 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3415 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3416 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3417 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3418 what it was before.
3419 * menu.h, termhooks.h: Include "systime.h", for Time.
3420
8e55734a
PE
3421 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3422 Don't assume that the difference between two unsigned long values
3423 can fit into an integer. At this point, we know button_down_time
3424 <= event->timestamp, so the difference must be nonnegative, so
3425 there's no need to cast the result if double-click-time is
3426 nonnegative, as it should be; check that it's nonnegative, just in
3427 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3428 apart (about 25 days). (Bug#8664)
8e55734a 3429
841f1b75 3430 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3431 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3432
3e26f69c
PE
3433 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3434 that always fit in int. Use a sentinel instead of a counter, to
3435 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3436 * frame.h (struct frame): Use int for menu_bar_items_used
3437 instead of EMACS_INT, since it always fits in int.
3e26f69c 3438
5cc152c0
PE
3439 * menu.c (grow_menu_items): Check for int overflow.
3440
d89eb65e
PE
3441 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3442
5235bd3e
PE
3443 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3444 Before, the code was not consistent. These values cannot exceed
3445 2**31 - 1 so there's no need to make them unsigned.
3446 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3447 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3448 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3449 as modifiers.
3450 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3451
bc827e23
PE
3452 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3453 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3454 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3455 presumably because the widths might not match.
3456
78eb494e
PE
3457 * window.c (size_window): Avoid needless test at loop start.
3458
04f2d78b
CB
34592011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3460
3461 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3462
d2fc7e3d 34632011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3464
3465 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3466
d2fc7e3d 34672011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3468
3469 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3470 `width' to `bar_area_x' and `bar_area_width', respectively.
3471 (x_scroll_run): Take account of fringe background extension.
3472
04f2d78b
CB
3473 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3474 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3475 `bar_area_width', respectively.
3476 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3477 background extension.
3478
79b70037
GM
34792011-05-10 Jim Meyering <meyering@redhat.com>
3480
3481 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3482
2f142cc5
JB
34832011-05-10 Juanma Barranquero <lekktu@gmail.com>
3484
3485 * image.c (Finit_image_library): Return t for built-in image types,
3486 like pbm and xbm. (Bug#8640)
3487
57679c86
AS
34882011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3489
3490 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3491
888c9e86
EZ
34922011-05-07 Eli Zaretskii <eliz@gnu.org>
3493
b0512a1d
EZ
3494 * w32console.c (Fset_screen_color): Doc fix.
3495 (Fget_screen_color): New function.
3496 (syms_of_ntterm): Defsubr it.
3497
7285dc67
EZ
3498 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3499 unlink the temporary file if Fcall_process didn't create it in the
3500 first place.
3501 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3502 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3503 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3504 cue to call_process_cleanup not to close that handle.
3505
4d3fcc8e
BK
35062011-05-07 Ben Key <bkey76@gmail.com>
3507
3508 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3509 one of two shell specific rules, either bootstrap-temacs-CMD or
3510 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3511 to the previous implementation of the bootstrap-temacs rule.
3512 The bootstrap-temacs-CMD rule is similar to the previous
3513 implementation of the bootstrap-temacs rule except that it
3514 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3515 variable.
3516
3517 These changes, along with some changes to nt/configure.bat,
3518 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3519 earlier fix to add support for --cflags and --ldflags options
3520 that include quotes so that it works whether make uses cmd or
3521 sh as the shell.
3522
b4289b64
MA
35232011-05-06 Michael Albinus <michael.albinus@gmx.de>
3524
3525 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3526 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3527 is a constant.
3528 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3529 a string. Handle both cases.
3530 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3531 (Fdbus_register_method): Use Qinvalid_function.
3532
af4c0e28
JB
35332011-05-06 Juanma Barranquero <lekktu@gmail.com>
3534
3535 * makefile.w32-in: Update dependencies.
3536 (LISP_H): Add inttypes.h and stdin.h.
3537 (PROCESS_H): Add unistd.h.
3538
c51453d9
EZ
35392011-05-06 Eli Zaretskii <eliz@gnu.org>
3540
3541 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3542 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3543
8ff0ac3c 35442011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3545
4c4b566b
PE
3546 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3547
aab2b9b5
PE
3548 * term.c (vfatal): Remove stray call to va_end.
3549 It's not needed and the C Standard doesn't allow it here anyway.
3550
c378da0b
PE
3551 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3552 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3553
288b08c7
PE
3554 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3555 bytes.
3556
e3601888
PE
3557 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3558
db6c0e74
PE
3559 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3560
dd5963ea
PE
3561 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3562
88c9450f
PE
3563 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3564
2f9442b8
PE
3565 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3566
c032b5f8
PE
3567 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3568 * charset.c (Fdefine_charset_internal): Don't initialize
3569 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3570 32-bit int (Bug#8600).
a108c10b
PE
3571
3572 * lread.c (read_integer): Be more consistent with string-to-number.
3573 Use string_to_number to do the actual conversion; this avoids
3574 rounding errors and fixes some other screwups. Without this fix,
3575 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3576 (digit_to_number): Move earlier, for benefit of read_integer.
3577 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3578 not a digit in any supported base. (Bug#8602)
a108c10b 3579
ad5f9eea
PE
3580 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3581
aec1708a
PE
3582 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3583 to match comment at start of function. This also removes a
3584 GCC warning about overflow in a 32+64-bit port.
3585
47be4ab5
PE
3586 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3587
371cac43
PE
3588 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3589 Reported by Stefan Monnier in
3590 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3591 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3592 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3593
d01a7826
PE
3594 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3595 (EMACS_UINTPTR): Likewise, with uintptr_t.
3596
7fd47d5c
PE
3597 * lisp.h: Prefer 64-bit EMACS_INT if available.
3598 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3599 on 32-bit hosts that have 64-bit int, so that they can access
3600 large files.
122b0c86
PE
3601 However, temporarily disable this change unless the temporary
3602 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3603
8727937b
PE
3604 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3605
8ac068ac
PE
3606 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3607 This removes an assumption that EMACS_INT and long are the same
3608 width as pointers. The assumption is true for Emacs porting targets
3609 now, but we want to make other targets possible.
3610 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3611 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3612 In the rest of the code, change types of integers that hold casted
3613 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3614 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3615 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3616 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3617 No need to cast type when ORing.
3618 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3619 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3620 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3621 assume EMACS_INT is the same width as char *.
3622 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3623 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3624 Remove no-longer-needed casts.
3625 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3626 (xg_tool_bar_help_callback, xg_make_tool_item):
3627 Use EMACS_INTPTR to hold an integer
3628 that will be cast to void *; this can avoid a GCC warning
3629 if EMACS_INT is not the same width as void *.
3630 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3631 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3632 (current_message_1, set_message_1):
3633 Use a local to convert to proper width without a cast.
3634 * xmenu.c (dialog_selection_callback): Likewise.
3635
ede49d71
PE
3636 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3637 Also, don't assume VALBITS / RAND_BITS is less than 5,
3638 and don't rely on undefined behavior when shifting a 1 left into
3639 the sign bit.
3640 * lisp.h (get_random): Change signature to match.
3641
2f30ecd0
PE
3642 * lread.c (hash_string): Use size_t, not int, for hash computation.
3643 Normally we prefer signed values; but hashing is special, because
3644 it's better to use unsigned division on hash table sizes so that
3645 the remainder is nonnegative. Also, size_t is the natural width
3646 for hashing into memory. The previous code used 'int', which doesn't
3647 retain enough info to hash well into very large tables.
3648 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3649
2a866e7b
PE
3650 * dbusbind.c: Don't possibly lose pointer info when converting.
3651 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3652 Use XPNTR rather than XHASH, so that the high-order bits of
3653 the pointer aren't lost when converting through void *.
3654
51639eac
PE
3655 * eval.c (Fautoload): Don't double-shift a pointer.
3656
92394119
PE
3657 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3658
dbdb9a7c
JB
36592011-05-06 Juanma Barranquero <lekktu@gmail.com>
3660
3661 * gnutls.c (DEF_GNUTLS_FN):
3662 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3663
db7a0b4f
AS
36642011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3665
3666 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3667 marker. (Bug#8610)
3668
f7ff1b0f 36692011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3670
3671 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3672 New version that can reserve upto 2GB of heap space.
3673
f7ff1b0f 36742011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3675
3676 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3677
639c109b
TZ
36782011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3679
3680 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3681 `gnutls_certificate_set_x509_key_file'.
3682
d2127135
JB
36832011-05-05 Juanma Barranquero <lekktu@gmail.com>
3684
3685 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3686 Update dependencies.
3687
e968f4f3
JB
36882011-05-04 Juanma Barranquero <lekktu@gmail.com>
3689
3690 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3691 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3692 Remove unused parameter `fildes'.
3693 * process.c (read_process_output, send_process): Don't pass it.
3694
84d358f0
JB
36952011-05-04 Juanma Barranquero <lekktu@gmail.com>
3696
3697 Fix previous change: the library cache is defined in w32.c.
3698 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3699 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3700
0898ca10
JB
37012011-05-04 Juanma Barranquero <lekktu@gmail.com>
3702
3703 Implement dynamic loading of GnuTLS on Windows.
3704
3705 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3706 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3707 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3708 Declare.
3709
3710 * gnutls.c (Qgnutls_dll): Define.
3711 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3712 (gnutls_*): Declare function pointers.
3713 (init_gnutls_functions): New function to initialize function pointers.
3714 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3715 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3716 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3717 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3718 (emacs_gnutls_write, emacs_gnutls_read)
3719 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3720 (Fgnutls_available_p): New function.
3721 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3722 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3723 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3724
3725 * image.c: Include w32.h.
3726 (Vimage_type_cache): Delete.
3727 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3728 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3729 (w32_delayed_load): Move to w32.c.
3730
3731 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3732
3733 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3734 (w32_delayed_load): Move from image.c. When loading a library, record
3735 its filename in the :loaded-from property of the library id.
3736 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3737 Initialize and staticpro them.
3738 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3739
3740 * process.c: Include lisp.h before w32.h, not after.
3741 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3742 instead of gnutls_record_check_pending.
3743
3744 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3745
ff4de4aa
TZ
37462011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3747
3748 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3749 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3750 as passed in.
3751
abe95abb
JD
37522011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3753
3754 * xterm.c (x_set_frame_alpha): Do not set property on anything
3755 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3756
e16e55d4
JB
37572011-05-02 Juanma Barranquero <lekktu@gmail.com>
3758
3759 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3760
bafcf6a5
JB
37612011-05-02 Juanma Barranquero <lekktu@gmail.com>
3762
3763 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3764 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3765 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3766 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3767 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3768 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3769 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3770 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3771 (Qgnutls_bootprop_callbacks_verify): Make static.
3772
e7a6747f
AS
37732011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3774
19ed11ba
AS
3775 * callproc.c: Indentation fixup.
3776
e7a6747f 3777 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3778 (wait_for_termination, interruptible_wait_for_termination):
3779 Move after wait_for_termination_1.
e7a6747f 3780
1ef14cb4
LMI
37812011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3782
3783 * sysdep.c (interruptible_wait_for_termination): New function
3784 which is like wait_for_termination, but allows keyboard
3785 interruptions.
3786
3787 * callproc.c (Fcall_process): Add (:file "file") as an option for
3788 the STDOUT buffer.
3789 (Fcall_process_region): Ditto.
3790
330d880c
EZ
37912011-04-30 Eli Zaretskii <eliz@gnu.org>
3792
8db90b73
EZ
3793 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3794 rather than `XVECTOR (FOO)->size'.
3795
330d880c
EZ
3796 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3797 inttypes.h, as a gnulib replacement is used if it not available in
3798 system headers.
3799
15cbd324
EZ
38002011-04-21 Eli Zaretskii <eliz@gnu.org>
3801
3802 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3803 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3804 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3805
3806 * coding.c (coding_alloc_by_realloc): Error out if destination
3807 will grow beyond MOST_POSITIVE_FIXNUM.
3808 (decode_coding_emacs_mule): Abort if there isn't enough place in
3809 charbuf for the composition carryover bytes. Reserve an extra
3810 space for up to 2 characters produced in a loop.
3811 (decode_coding_iso_2022): Abort if there isn't enough place in
3812 charbuf for the composition carryover bytes.
3813
38142011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3815
ae940cca
EZ
3816 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3817 aborting when %lld or %lll format is passed.
3818 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3819 %llo or %llx format is passed. (Bug#8545)
3820
03ab8921
EZ
3821 * window.c (window_scroll_line_based): Use a marker instead of
3822 simple variables to record original value of point. (Bug#7952)
3823
afda1437
EZ
3824 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3825 produced by %s or %c overflows available buffer space. (Bug#8545)
3826
f76dee0c
PE
38272011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3828
3829 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3830 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3831
fdc5744d
JB
38322011-04-28 Juanma Barranquero <lekktu@gmail.com>
3833
3834 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3835
638f053a
JB
38362011-04-28 Juanma Barranquero <lekktu@gmail.com>
3837
3838 * keyboard.c (Qdelayed_warnings_hook): Define.
3839 (command_loop_1): Run `delayed-warnings-hook'
3840 if Vdelayed_warnings_list is non-nil.
3841 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3842 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3843
d178f871
EZ
38442011-04-28 Eli Zaretskii <eliz@gnu.org>
3845
3846 * doprnt.c (doprnt): Don't return value smaller than the buffer
3847 size if the message was truncated. (Bug#8545).
3848
b124fd93
JB
38492011-04-28 Juanma Barranquero <lekktu@gmail.com>
3850
3851 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3852 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3853
e810457d
PE
38542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3855
3856 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3857
ea51cceb
JB
38582011-04-27 Juanma Barranquero <lekktu@gmail.com>
3859
3860 * makefile.w32-in: Update dependencies.
3861
94dcfacf
EZ
38622011-04-27 Eli Zaretskii <eliz@gnu.org>
3863
3864 Improve `doprnt' and its usage. (Bug#8545)
3865 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3866 `format_end'. Remove support for %l as a conversion specifier.
3867 Don't use xrealloc. Improve diagnostics when the %l size modifier
3868 is used. Update the commentary.
3869
3870 * eval.c (verror): Simplify calculation of size_t.
3871
3872 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3873 messages.
3874
f61f41d7
PE
38752011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3876
3877 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3878 change.
3879
96fb4434
PE
38802011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3881
3882 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3883 This makes this file independent of the recent pseudovector change.
3884
671875da 38852011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3886
69e9b5a3
PE
3887 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3888
b5f869a7 3889 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3890 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3891 Remove unused local.
c8926152 3892 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3893
841a1577 3894 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3895 GCC 4.6.0 optimizes based on type-based alias analysis.
3896 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3897 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3898 != &v->size, and therefore "v->size = 1; b->size = 2; return
3899 v->size;" must therefore return 1. This assumption is incorrect
3900 for Emacs, since it type-puns struct Lisp_Vector * with many other
3901 types. To fix this problem, this patch adds a new type struct
f904488f 3902 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3903 and pseudovectors, and helps optimizing compilers not get fooled
3904 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3905 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3906 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3907 the size member.
eab3844f
PE
3908 (XSETPVECTYPE): Rewrite in terms of new macro.
3909 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3910 This is a bit clearer, and further avoids the possibility of
3911 undesirable aliasing.
3912 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3913 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3914 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3915 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3916 (ASIZE): Now uses header.size rather than size.
3917 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3918 to avoid the hassle of writing XVECTOR (foo)->header.size.
3919 (struct vectorlike_header): New type.
eab3844f
PE
3920 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3921 object, to help avoid aliasing.
3922 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3923 (SUBRP): Likewise, since Lisp_Subr is a special case.
3924 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3925 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3926 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3927 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3928 changed to be "header.size" and "header.next".
3929 * buffer.h (struct buffer): Likewise.
3930 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3931 * frame.h (struct frame): Likewise.
3932 * process.h (struct Lisp_Process): Likewise.
3933 * termhooks.h (struct terminal): Likewise.
3934 * window.c (struct save_window_data, struct saved_window): Likewise.
3935 * window.h (struct window): Likewise.
3936 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3937 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3938 * buffer.c (init_buffer_once): Likewise.
3939 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3940 special case.
3941 * process.c (Fformat_network_address): Use local var for size,
3942 for brevity.
3943
0df1eac5
PE
3944 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3945
847ab9d1 3946 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3947 * data.c (atof): Remove decl; no longer used or needed.
3948 (digit_to_number): Move to lread.c.
3949 (Fstring_to_number): Use new string_to_number function, to be
3950 consistent with how the Lisp reader treats infinities and NaNs.
3951 Do not assume that floating-point numbers represent EMACS_INT
3952 without losing information; this is not true on most 64-bit hosts.
3953 Avoid double-rounding errors, by insisting on integers when
3954 parsing non-base-10 numbers, as the documentation specifies.
3955 * lisp.h (string_to_number): New decl, replacing ...
3956 (isfloat_string): Remove.
bc0a5c13 3957 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3958 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3959 appears to have been a coding error. Similarly, do not accept
3960 strings like +-1e0 as floating point numbers. Do not report
3961 overflow for integer overflows unless the base is not 10 which
3962 means we have no simple and reliable way to continue.
3963 Break out the floating-point parsing into a new
3964 function string_to_number, so that Fstring_to_number parses
3965 floating point numbers consistently with the Lisp reader.
04f2d78b 3966 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3967 (E_CHAR, EXP_INT): Remove, replacing with ...
3968 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3969 (string_to_number): New function, replacing isfloat_string.
3970 This function checks for valid syntax and produces the resulting
3971 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3972 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3973 so that overflow for non-base-10 numbers is reported only when
3974 there's no portable and simple way to convert to floating point.
452f4150 3975
67769ffc
PE
3976 * textprop.c (set_text_properties_1): Rewrite for clarity,
3977 and to avoid GCC warning about integer overflow.
3978
c20db43f
PE
3979 * intervals.h (struct interval): Use EMACS_INT for members
3980 where EMACS_UINT might cause problems. See
3981 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3982 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3983 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3984 All uses changed.
37aa2f85
PE
3985 (offset_intervals): Tell GCC not to worry about length overflow
3986 when negating a negative length.
c20db43f 3987
2538aa2f
PE
3988 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3989 (overrun_check_free): Likewise.
3990
f2d3008d
PE
3991 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3992 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3993 word size.
3994
ec8df744
PE
3995 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3996 (gnutls_make_error): Rename local to avoid shadowing.
3997 (gnutls_emacs_global_deinit): ifdef out; not used.
3998 (Fgnutls_boot): Use const for pointer to readonly storage.
3999 Comment out unused local. Fix pointer signedness problems.
4000
640ee02d
PE
4001 * lread.c (openp): Don't stuff size_t into an 'int'.
4002 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4003 about possible signed overflow.
4004
6048fb2a
PE
4005 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4006 (GDK_KEY_g): Don't define if already defined.
4007 (xg_prepare_tooltip): Avoid pointer signedness problem.
4008 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4009
fa3c87e1
PE
4010 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4011 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4012
2172544b
PE
4013 * xfns.c (Fx_window_property): Simplify a bit,
4014 to make a bit faster and to avoid GCC 4.6.0 warning.
4015 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4016
9b821a21
PE
4017 * fns.c (internal_equal): Don't assume size_t fits in int.
4018
3c616cfa
PE
4019 * alloc.c (compact_small_strings): Tighten assertion a little.
4020
c2982e87
PE
4021 Replace pEd with more-general pI, and fix some printf arg casts.
4022 * lisp.h (pI): New macro, generalizing old pEd macro to other
4023 conversion specifiers. For example, use "...%"pI"d..." rather
4024 than "...%"pEd"...".
4025 (pEd): Remove. All uses replaced with similar uses of pI.
4026 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4027 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4028 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4029 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4030 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4031 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4032 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4033 64-bit hosts.
4034 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4035 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4036 * print.c (safe_debug_print, print_object): Likewise.
4037 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4038 to int.
6f04d126
PE
4039 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4040 avoiding the 0 flag, which is not portable.
c2982e87
PE
4041 * process.c (Fmake_network_process): Use pI to avoid cast.
4042 * region-cache.c (pp_cache): Likewise.
4043 * xdisp.c (decode_mode_spec): Likewise.
4044 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4045 behavior on 64-bit hosts with printf arg.
6f04d126 4046 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4047 (x_stop_queuing_selection_requests): Likewise.
4048 (x_get_window_property): Don't truncate byte count to an 'int'
4049 when tracing.
0b432f21 4050
5e073ec7
PE
4051 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4052 here, since it parses constructs like leading '-' and spaces,
4053 which are not wanted; and it overflows with large numbers.
4054 Instead, simply match F[0-9]+, which is what is wanted anyway.
4055
36372bf9
PE
4056 * alloc.c: Remove unportable assumptions about struct layout.
4057 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4058 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4059 (allocate_vectorlike, make_pure_vector): Use the new macros,
4060 plus offsetof, to remove unportable assumptions about struct layout.
4061 These assumptions hold on all porting targets that I know of, but
4062 they are not guaranteed, they're easy to remove, and removing them
4063 makes further changes easier.
4064
0b432f21
PE
4065 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4066 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4067 (string_overrun_cookie): Now const. Use initializers that
4068 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4069 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4070 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4071 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4072 multiple of sizeof (EMACS_INT); it need not be, if
4073 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4074 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4075
895009e1
JB
40762011-04-26 Juanma Barranquero <lekktu@gmail.com>
4077
4078 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4079
6a7a1b0b
TZ
40802011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4081
4082 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4083 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4084 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4085
841a1577 40862011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4087
4088 * lisp.h (Qdebug): List symbol.
895009e1 4089 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4090 * keyboard.c (debug-on-event): New variable.
4091 (handle_user_signal): Break into debugger when debug-on-event
4092 matches the current signal symbol.
4093
f2d3ba6f
DN
40942011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4095
4096 * alloc.c (check_sblock, check_string_bytes)
4097 (check_string_free_list): Convert to standard C.
4098
42ce4c63
TZ
40992011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4100
4101 * w32.c (emacs_gnutls_push): Fix typo.
4102
825cd63c
EZ
41032011-04-25 Eli Zaretskii <eliz@gnu.org>
4104
fb11d64d
EZ
4105 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4106 "cast to pointer from integer of different size".
4107
825cd63c
EZ
4108 Improve doprnt and its use in verror. (Bug#8545)
4109 * doprnt.c (doprnt): Document the set of format control sequences
4110 supported by the function. Use SAFE_ALLOCA instead of always
4111 using `alloca'.
4112
4113 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4114 is one byte too soon. Don't use xrealloc; instead xfree and
4115 xmalloc anew.
4116
e061a11b
TZ
41172011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4118
4119 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4120 callbacks stage.
4121
4122 * gnutls.c: Renamed global_initialized to
4123 gnutls_global_initialized. Added internals for the
4124 :verify-hostname-error, :verify-error, and :verify-flags
4125 parameters of `gnutls-boot' and documented those parameters in the
4126 docstring. Start callback support.
9173deec
JB
4127 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4128 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4129 on error. Return error code.
e061a11b
TZ
4130 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4131 (emacs_gnutls_read): Likewise.
4132 (Fgnutls_boot): Return handshake error code.
4133 (emacs_gnutls_handle_error): New function.
4134 (wsaerror_to_errno): Likewise.
4135
4136 * w32.h (emacs_gnutls_pull): Add prototype.
4137 (emacs_gnutls_push): Likewise.
4138
4139 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4140 (emacs_gnutls_push): Likewise.
4141
41422011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4143
4144 * process.c (wait_reading_process_output): Check if GnuTLS
4145 buffered some data internally if no FDs are set for TLS
4146 connections.
4147
4148 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4149 (LIBS): Link to USER_LIBS.
4150 ($(BLD)/gnutls.$(0)): New target.
4151
fa6996bc
EZ
41522011-04-24 Eli Zaretskii <eliz@gnu.org>
4153
eb35682e
EZ
4154 * xdisp.c (handle_single_display_spec): Rename the
4155 display_replaced_before_p argument into display_replaced_p, to
4156 make it consistent with the commentary. Fix typos in the
4157 commentary.
4158
e2ad650c
EZ
4159 * textprop.c (syms_of_textprop): Remove dead code.
4160 (copy_text_properties): Delete obsolete commentary about an
4161 interface that was deleted long ago. Fix typos in the description
4162 of arguments.
4163
1b2de274
EZ
4164 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4165 to changes in oldXMenu/XMenu.h from 2011-04-16.
4166 <menu_help_message, prev_menu_help_message>: Constify.
4167 (IT_menu_make_room): menu->help_text is now `const char **';
4168 adjust.
4169
4170 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4171 to changes in oldXMenu/XMenu.h from 2011-04-16.
4172 (struct XMenu): Declare `help_text' `const char **'.
4173
4174 * xfaces.c <Qunspecified>: Make extern again.
4175
4176 * syntax.c: Include sys/types.h before including regex.h, as
4177 required by Posix.
4178
762b15be
EZ
4179 * doc.c (get_doc_string): Improve the format passed to `error'.
4180
4181 * doprnt.c (doprnt): Improve commentary.
4182
4183 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4184
4185 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4186 them with etags.
4187
f1052e5d
EZ
4188 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4189 changes in globals.h immediately force recompilation.
762b15be
EZ
4190 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4191 $(CURDIR)/s/ms-w32.h.
4192 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4193
fa6996bc
EZ
4194 * character.c (Fchar_direction): Function deleted.
4195 (syms_of_character): Don't defsubr it.
4196 <char-direction-table>: Deleted.
4197
e6c3da20
EZ
41982011-04-23 Eli Zaretskii <eliz@gnu.org>
4199
4200 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4201 * doprnt.c: Include limits.h.
4202 (SIZE_MAX): New macro.
04f2d78b
CB
4203 (doprnt): Return a size_t value. 2nd arg is now size_t.
4204 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4205 Improve overflow protection. Support `l' modifier for integer
4206 conversions. Support %l conversion. Don't assume an EMACS_INT
4207 argument for integer conversions and for %c.
4208
4209 * lisp.h (doprnt): Restore prototype.
4210
4211 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4212 $(SRC)/character.h.
4213
4214 * Makefile.in (base_obj): Add back doprnt.o.
4215
4216 * deps.mk (doprnt.o): Add back prerequisites.
4217 (callint.o): Depend on character.h.
4218
4219 * eval.c (internal_lisp_condition_case): Include the handler
4220 representation in the error message.
4221 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4222 when breaking from the loop.
4223
4224 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4225
4226 * callint.c (Fcall_interactively): When displaying error message
4227 about invalid control letter, pass the character's codepoint, not
4228 a pointer to its multibyte form. Improve display of the character
4229 in octal and display also its hex code.
4230
4231 * character.c (char_string): Use %x to display the (unsigned)
4232 codepoint of an invalid character, to avoid displaying a bogus
4233 negative value.
4234
4235 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4236 `error', not SYMBOL_NAME itself.
4237
4238 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4239 character arguments to `error'.
4240
4241 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4242 to `error' in error message about FINAL_CHAR argument. Make sure
4243 FINAL_CHAR is a character, and use %c when it is passed as
4244 argument to `error'.
4245
4ffd0d6b 42462011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4247
4248 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4249
4250 * w32.c: Include <time.h>.
4251 (sys_localtime): New function.
4252
4ffd0d6b 42532011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4254
4255 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4256
4ffd0d6b 4257 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4258
4ffd0d6b 42592011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4260
4ffd0d6b
GM
4261 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4262 zombies (Bug#8467).
aac0c6e3 4263
04c56954
EZ
42642011-04-19 Eli Zaretskii <eliz@gnu.org>
4265
4266 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4267 gl_state.e_property when gl_state.object is Qt.
4268
4269 * insdel.c (make_gap_larger): Remove limitation of buffer size
4270 to <= INT_MAX.
4271
16a43933
CY
42722011-04-18 Chong Yidong <cyd@stupidchicken.com>
4273
4274 * xdisp.c (lookup_glyphless_char_display)
4275 (produce_glyphless_glyph): Handle cons cell entry in
4276 glyphless-char-display.
4277 (Vglyphless_char_display): Document it.
4278
4279 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4280 glyphless-char-display.
4281
4581706e
CY
42822011-04-17 Chong Yidong <cyd@stupidchicken.com>
4283
4284 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4285
4286 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4287
4288 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4289 definition for no-X builds.
4290
4887c6e2 42912011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4292
fd35b6f9
PE
4293 Static checks with GCC 4.6.0 and non-default toolkits.
4294
5c1ccb01
PE
4295 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4296
006c5daa
PE
4297 * process.c (keyboard_bit_set): Define only if SIGIO.
4298 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4299 (send_process): Repair possible setjmp clobbering.
4300
efc736d3
PE
4301 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4302
4e2fe2e6
PE
4303 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4304
f97334a2
PE
4305 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4306
4e75f29d
PE
4307 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4308 Define only if needed.
4309
90efadd1
PE
4310 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4311 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4312 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4313
3c647824
PE
4314 * dispextern.h (struct redisplay_interface): Rename param
4315 to avoid shadowing.
e264f262 4316 * termhooks.h (struct terminal): Likewise.
761383f4 4317 * xterm.c (xembed_send_message): Likewise.
3c647824 4318
b58c5c4a
PE
4319 * insdel.c (make_gap_smaller): Define only if
4320 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4321
cad59032
PE
4322 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4323 it.
4324
c339dc2e
PE
4325 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4326 so that we aren't warned about unused symbols.
4327
91a3e27b
PE
4328 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4329
399c71d3 4330 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4331
8ffc96f5
PE
4332 * xfns.c (x_real_positions): Mark locals as initialized.
4333
eef9bc79
PE
4334 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4335
098db9dd
PE
4336 * xterm.c: Fix problems found by static analysis with other toolkits.
4337 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4338 (x_dispatch_event): Declare static if USE_GTK, and
4339 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4340 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4341 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4342 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4343 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4344
eb18f6cc
PE
4345 * xmenu.c (menu_help_callback): Pointer type fixes.
4346 Use const pointers when pointing at readonly data. Avoid pointer
4347 signedness clashes.
4348 (FALSE): Remove unused macro.
4349 (update_frame_menubar): Remove unused decl.
4350
1fe72bf8
PE
4351 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4352
60d9e1db
PE
4353 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4354 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4355 (single_menu_item): Rename local to avoid shadowing.
4356
39261c26
PE
4357 * keyboard.c (make_lispy_event): Remove unused local var.
4358
018c5e19
PE
4359 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4360 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4361
63d2b86e
PE
4362 * bitmaps: Change bitmaps from unsigned char back to the X11
4363 compatible char. Avoid the old compiler warnings about
4364 out-of-range initializers by using, for example, '\xab' rather
4365 than 0xab.
4366
aefd87e1
PE
4367 * xgselect.c (xgselect_initialize): Check vs interface
4368 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4369
bf501fb9
PE
4370 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4371
e9829fdf
PE
4372 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4373 to read-only memory.
4374
1086c095
PE
4375 * fns.c (vector): Remove; this old hack is no longer needed.
4376
2baccd04 4377 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4378 Remove unused var.
dde42981 4379 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4380
72391843 4381 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4382
436c16df 4383 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4384 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4385 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4386
92bb796d 4387 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4388 (x_term_init): Remove local to avoid shadowing.
92bb796d 4389
764430a3 4390 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4391
4392 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4393 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4394
d1dfb56c
EZ
43952011-04-16 Eli Zaretskii <eliz@gnu.org>
4396
c4354cb4
EZ
4397 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4398
d1dfb56c
EZ
4399 Fix regex.c, syntax.c and friends for buffers > 2GB.
4400 * syntax.h (struct gl_state_s): Declare character position members
4401 EMACS_INT.
4402
4403 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4404
04f2d78b
CB
4405 * textprop.c (verify_interval_modification, interval_of):
4406 Declare arguments EMACS_INT.
d1dfb56c
EZ
4407
4408 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4409 EMACS_INT.
4410
4411 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4412
4413 * indent.c (Fvertical_motion): Local variable it_start is now
4414 EMACS_INT.
4415
4416 * regex.c (re_match, re_match_2, re_match_2_internal)
4417 (bcmp_translate, regcomp, regexec, print_double_string)
4418 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4419 (re_compile_pattern, re_exec): Declare arguments and local
4420 variables `size_t' and `ssize_t' and return values `regoff_t', as
4421 appropriate.
4422 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4423 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4424 <compile_stack_type>: `size' and `avail' are now `size_t'.
4425
4426 * regex.h <regoff_t>: Use ssize_t, not int.
4427 (re_search, re_search_2, re_match, re_match_2): Arguments that
4428 specify buffer/string position and length are now ssize_t and
4429 size_t. Return type is regoff_t.
4430
613052cd
BK
44312011-04-16 Ben Key <bkey76@gmail.com>
4432
4433 * nsfont.m: Fixed bugs in ns_get_family and
4434 ns_descriptor_to_entity that were caused by using free to
4435 deallocate memory blocks that were allocated by xmalloc (via
4436 xstrdup). This caused Emacs to crash when compiled with
4437 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4438 --enable-checking=xmallocoverrun). xfree is now used to
4439 deallocate these memory blocks.
4440
4170f62f 44412011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4442
71b41406
PE
4443 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4444
9587a89d
PE
4445 emacs_write: Accept and return EMACS_INT for sizes.
4446 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4447 et seq.
4448 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4449 Accept and return EMACS_INT.
4450 (emacs_gnutls_write): Return the number of bytes written on
4451 partial writes.
4452 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4453 (emacs_read, emacs_write): Remove check for negative size, as the
4454 Emacs source code has been audited now.
9587a89d
PE
4455 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4456 (emacs_read, emacs_write): Use it.
273a5f82
PE
4457 * process.c (send_process): Adjust to the new signatures of
4458 emacs_write and emacs_gnutls_write. Do not attempt to store
4459 a byte offset into an 'int'; it might overflow.
9587a89d 4460 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4461
3e047f51
PE
4462 * sound.c: Don't assume sizes fit in 'int'.
4463 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4464 Return EMACS_INT, not int.
3e047f51 4465 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4466 Accept EMACS_INT, not int.
4467 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4468 record read return values.
4469
cc39a9db
BK
44702011-04-15 Ben Key <bkey76@gmail.com>
4471
c9d0ec6d
JB
4472 * keyboard.c (Qundefined): Don't declare static since it is used
4473 in nsfns.m.
4474 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4475 static since they are used in nsfont.m.
cc39a9db 4476
6c60eb9f
SM
44772011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4478
4479 * process.c (Qprocessp): Don't declare static.
4480 * lisp.h (Qprocessp): Declare again.
4481
7990b61a
JB
44822011-04-15 Juanma Barranquero <lekktu@gmail.com>
4483
4484 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4485
5d4cb038
PE
44862011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4487
8bd7b830 4488 Improve C-level modularity by making more things 'static'.
cd64ea1d 4489
e3b27b31
PE
4490 Don't publish debugger-only interfaces to other modules.
4491 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4492 (verify_bytepos, count_markers): Move decls to the only modules
4493 that need them.
4494 * region-cache.h (pp_cache): Likewise.
4495 * window.h (check_all_windows): Likewise.
4496 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4497
5d4cb038
PE
4498 * sysdep.c (croak): Now static, if
4499 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4500 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4501
4502 * alloc.c (refill_memory_reserve): Now static if
4503 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4504 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4505
e87b6180
PE
4506 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4507 Define only if USE_LUCID.
4508
ac64929e
PE
4509 * xrdb.c (x_customization_string, x_rm_string): Now static.
4510
6f37259d
PE
4511 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4512 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4513
1683e3ab
PE
4514 * xdisp.c (draw_row_with_mouse_face): Now static.
4515 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4516
de9c2632
PE
4517 * window.h (check_all_windows): Mark externally visible.
4518
2b96acb7
PE
4519 * window.c (window_deletion_count): Now static.
4520
4521 * undo.c: Make symbols static if they're not exported.
4522 (last_undo_buffer, last_boundary_position, pending_boundary):
4523 Now static.
4524
50436f33
PE
4525 * textprop.c (interval_insert_behind_hooks): Now static.
4526 (interval_insert_in_front_hooks): Likewise.
4527
64520e5c
PE
4528 * term.c: Make symbols static if they're not exported.
4529 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4530 (max_frame_lines, tty_set_terminal_modes):
4531 (tty_reset_terminal_modes, tty_turn_off_highlight):
4532 (get_tty_terminal): Now static.
4533 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4534 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4535 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4536 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4537 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4538
1fa53021
PE
4539 * sysdep.c: Make symbols static if they're not exported.
4540 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4541 Now static.
4542 (sigprocmask_set, full_mask): Remove; unused.
4543 (wait_debugging): Mark as visible.
4544 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4545 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4546
d4b43b22
PE
4547 * syntax.c (syntax_temp): Define only if !__GNUC__.
4548
b7c513d0
PE
4549 * sound.c (current_sound_device, current_sound): Now static.
4550
989b29ad
PE
4551 * search.c (searchbufs, searchbuf_head): Now static.
4552
13a55a78
PE
4553 * scroll.c (scroll_cost): Remove; unused.
4554 * dispextern.h (scroll_cost): Remove decl.
4555
de68a1fc
PE
4556 * region-cache.h (pp_cache): Mark as externally visible.
4557
40ccffa6
PE
4558 * process.c: Make symbols static if they're not exported.
4559 (process_tick, update_tick, create_process, chan_process):
4560 (Vprocess_alist, proc_buffered_char, datagram_access):
4561 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4562 (deactivate_process): Mark defn as static, as well as decl.
4563 * lisp.h (create_process): Remove decl.
4564 * process.h (chan_process, Vprocess_alist): Remove decls.
4565
ad64fc97
PE
4566 * print.c: Make symbols static if they're not exported.
4567 (print_depth, new_backquote_output, being_printed, print_buffer):
4568 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4569 (print_interval, print_number_index, initial_stderr_stream):
4570 Now static.
4571 * lisp.h (Fprinc): Remove decl.
4572 (debug_output_compilation_hack): Mark as externally visible.
4573
adddb265
PE
4574 * sysdep.c (croak): Move decl from here to syssignal.h.
4575 * syssignal.h (croak): Put it here, so the API can be checked when
4576 'croak' is called from dissociate_if_controlling_tty.
4577
1717ede2
PE
4578 * minibuf.c: Make symbols static if they're not exported.
4579 (minibuf_save_list, choose_minibuf_frame): Now static.
4580 * lisp.h (choose_minibuf_frame): Remove decl.
4581
fa5fb2bc
PE
4582 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4583
1e3890d1
PE
4584 * lread.c: Make symbols static if they're not exported.
4585 (read_objects, initial_obarray, oblookup_last_bucket_number):
4586 Now static.
4587 (make_symbol): Remove; unused.
4588 * lisp.h (initial_obarray, make_symbol): Remove decls.
4589
8a1414fa
PE
4590 * keyboard.c: Make symbols static if they're not exported.
4591 (single_kboard, recent_keys_index, total_keys, recent_keys):
4592 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4593 (this_single_command_key_start, echoing, last_auto_save):
4594 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4595 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4596 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4597 (Vlispy_mouse_stem, double_click_count):
4598 Now static.
4599 (force_auto_save_soon): Define only if SIGDANGER.
4600 (ignore_mouse_drag_p): Now static if
4601 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4602 (print_help): Remove; unused.
4603 (stop_character, last_timer_event): Mark as externally visible.
4604 * keyboard.h (ignore_mouse_drag_p): Declare only if
4605 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4606 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4607 * lisp.h (echoing): Remove decl.
4608 (force_auto_save_soon): Declare only if SIGDANGER.
4609 * xdisp.c (redisplay_window): Simplify code, to make it more
4610 obvious that ignore_mouse_drag_p is not accessed if !defined
4611 USE_GTK && !defined HAVE_NS.
4612
93ea6e8f
PE
4613 * intervals.c: Make symbols static if they're not exported.
4614 (merge_properties_sticky, merge_interval_right, delete_interval):
4615 Now static.
4616 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4617
77382fcc
PE
4618 * insdel.c: Make symbols static if they're not exported.
4619 However, leave prepare_to_modify_buffer alone. It's never
4620 called from outside this function, but that appears to be a bug.
4621 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4622 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4623 (adjust_after_replace_noundo): Remove; unused.
4624 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4625 (signal_before_change): Remove decls.
77382fcc 4626
9306c32e
PE
4627 * indent.c (val_compute_motion, val_vmotion): Now static.
4628
cd44d2eb
PE
4629 * image.c: Make symbols static if they're not exported.
4630 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4631 if USE_GTK.
4632 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4633 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4634
ad9a7a06
PE
4635 * fringe.c (standard_bitmaps): Now static.
4636 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4637
81626931
PE
4638 * frame.c: Make symbols static if they're not exported.
4639 (x_report_frame_params, make_terminal_frame): Now static.
4640 (get_frame_param): Now static, unless HAVE_NS.
4641 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4642 (x_get_resource_string): Remove; not used.
4643 * frame.h (make_terminal_frame, x_report_frame_params):
4644 (x_get_resource_string); Remove decls.
4645 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4646 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4647
239f9db9
PE
4648 * font.c, fontset.c: Make symbols static if they're not exported.
4649 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4650 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4651 * font.c (font_close_object): Now static.
4652 * font.h (font_close_object): Remove.
4653 * fontset.c (FONTSET_OBJLIST): Remove.
4654 (free_realized_fontset) #if-0 the body, which does nothing.
4655 (face_suitable_for_char_p): #if-0, as it's never called.
4656 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4657 * xfaces.c (face_at_string_position):
4658 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4659 since 0 is always ASCII.
4660
dfcf3579
PE
4661 * fns.c (weak_hash_tables): Now static.
4662
5045092b
PE
4663 * fileio.c: Make symbols static if they're not exported.
4664 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4665 (Vwrite_region_annotation_buffers): Now static.
4666
57a96f5c
PE
4667 * eval.c: Make symbols static if they're not exported.
4668 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4669 * lisp.h (backtrace_list): Remove decl.
4670
35f08c38
PE
4671 * emacs.c: Make symbols static if they're not exported.
4672 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4673 (fatal_error_code, fatal_error_signal_hook, standard_args):
4674 Now static.
4675 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4676 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4677 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4678 * lisp.h (fatal_error_signal_hook): Remove decl.
4679 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4680
f44bd759
PE
4681 * editfns.c: Move a (normally-unused) function to its only use.
4682 * editfns.c, lisp.h (get_operating_system_release): Remove.
4683 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4684 worth the hassle of breaking this out.
4685
b532497d
PE
4686 * xterm.c: Make symbols static if they're not exported.
4687 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4688 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4689 (x_destroy_window, x_delete_display):
4690 Now static.
4691 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4692 (x_mouse_leave): Remove; unused.
4693 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4694 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4695 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4696 Remove decls.
4697 (x_mouse_leave): Declare only if WINDOWSNT.
4698 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4699 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4700 USE_X_TOOLKIT.
4701
1675728f
PE
4702 * ftxfont.c: Make symbols static if they're not exported.
4703 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4704 HAVE_FREETYPE.
4705 * font.h (ftxfont_driver): Likewise.
4706
e4cebfca
PE
4707 * xfns.c: Make symbols static if they're not exported.
4708 (x_last_font_name, x_display_info_for_name):
4709 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4710 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4711 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4712 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4713 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4714 (last_show_tip_args): Now static.
4715 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4716 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4717 (x_screen_planes): Remove; unused.
4718 * dispextern.h (x_screen_planes): Remove decl.
4719
5bf46f05
PE
4720 * dispnew.c: Make symbols static if they're not exported.
4721 * dispextern.h (redraw_garbaged_frames, scrolling):
4722 (increment_row_positions): Remove.
4723 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4724 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4725 Now static.
4726 (redraw_garbaged_frames): Remove; unused.
4727
435f4c28
PE
4728 * xfaces.c: Make symbols static if they're not exported.
4729 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4730 Remove decls.
4731 * xterm.h (defined_color): Remove decls.
4732 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4733 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4734 (menu_face_changed_default, defined_color, free_realized_face):
4735 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4736 (ascii_face_of_lisp_face): Remove; unused.
4737
8524aef3
PE
4738 * xdisp.c: Make symbols static if they're not exported.
4739 * dispextern.h (scratch_glyph_row, window_box_edges):
4740 (glyph_to_pixel_coords, set_cursor_from_row):
4741 (get_next_display_element, set_iterator_to_next):
4742 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4743 (show_mouse_face): Remove decls
4744 * frame.h (message_buf_print): Likewise.
4745 * lisp.h (pop_message, set_message, check_point_in_composition):
4746 Likewise.
4747 * xterm.h (set_vertical_scroll_bar): Likewise.
4748 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4749 (message_buf_print, scratch_glyph_row, displayed_buffer):
4750 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4751 (get_next_display_element, show_mouse_face, window_box_edges):
4752 (frame_to_window_pixel_xy, check_point_in_composition):
4753 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4754 (glyph_to_pixel_coords): Remove; unused.
4755
16390cd2
PE
4756 * dired.c (file_name_completion): Now static.
4757
4758 * dbusbind.c (xd_in_read_queued_messages): Now static.
4759
a25f4dfa
PE
4760 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4761 * data.c (circular_list_error): Remove.
4762
14a9c8df
PE
4763 * commands.h (last_point_position, last_point_position_buffer):
4764 (last_point_position_window): Remove decls.
4765 * keyboard.c: Make these variables static.
4766
04f2d78b
CB
4767 * coding.h (coding, code_convert_region, encode_coding_gap):
4768 Remove decls.
74ab6df5
PE
4769 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4770 (iso_code_class, detect_coding, code_convert_region): Now static.
4771 (encode_coding_gap): Remove; unused.
4772
38dfbee1
PE
4773 * chartab.c (chartab_chars, chartab_bits): Now static.
4774
a2cb4e63
PE
4775 * charset.h (charset_iso_8859_1): Remove decl.
4776 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4777 Now static.
4778
127198fd
PE
4779 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4780 * ccl.c (Vccl_program_table): Now static.
4781 (check_ccl_update): Remove; unused.
4782
d85b608f
PE
4783 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4784 * category.h: ... from here.
4785 * category.c (check_category_table, set_category_set): Now static.
4786
31cd66f3
PE
4787 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4788 * lisp.h: Remove these decls.
4789
c358e587
PE
4790 * buffer.c (buffer_count): Remove unused var.
4791
e78aecca
PE
4792 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4793 so that it's not optimized away.
4794 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4795 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4796 exported only to the debugger.
4797
e192d7d3 4798 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4799 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4800
92470028
PE
4801 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4802 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4803 was inaccessible from Lisp.
4804 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4805 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4806
244ed907
PE
4807 alloc.c: Import and export fewer symbols, and remove unused items.
4808 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4809 is defined.
4810 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4811 it's not optimized away by whole-program optimization.
4812 (message_enable_multibyte, free_misc): Remove.
4813 (catchlist, handlerlist, mark_backtrace):
4814 Declare only if BYTE_MARK_STACK.
4815 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4816 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4817 (message_enable_multibyte): Remove decl.
4818 (free_misc, interval_free_list, float_block, float_block_index):
4819 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4820 (cons_free_list, last_marked_index):
4821 Now static.
4822 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4823 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4824 (mark_backtrace): Define only if BYTE_MARK_STACK.
4825 * xdisp.c (message_enable_multibyte): Now static.
4826
61c2b50e 4827 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4828 This makes it easier for human readers (and static analyzers)
4829 to see whether these variables are used from other modules.
4830 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4831 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4832 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4833 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4834 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4835 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4836 * xmenu.c, xselect.c:
4837 Declare Q* vars static if they are not used in other modules.
4838 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4839 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4840 Remove decls of unexported vars.
4841 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4842
95c82688
PE
4843 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4844
16a97296
PE
4845 Make Emacs functions such as Fatom 'static' by default.
4846 This makes it easier for human readers (and static analyzers)
4847 to see whether these functions can be called from other modules.
4848 DEFUN now defines a static function. To make the function external
4849 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4850 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4851 (Finit_image_library):
16a97296
PE
4852 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4853 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4854 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4855 Remove decls, since these functions are now static.
4856 (Funintern, Fget_internal_run_time): New decls, since these functions
4857 were already external.
95c82688 4858
16a97296
PE
4859 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4860 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4861 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4862 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4863 * keyboard.c, keymap.c, lread.c:
4864 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4865 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4866 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4867 Mark functions with DEFUE instead of DEFUN,
4868 if they are used in other modules.
4869 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4870 decls for now-static functions.
4871 * buffer.h (Fdelete_overlay): Remove decl.
4872 * callproc.c (Fgetenv_internal): Mark as internal.
4873 * composite.c (Fremove_list_of_text_properties): Remove decl.
4874 (Fcomposition_get_gstring): New forward static decl.
4875 * composite.h (Fcomposite_get_gstring): Remove decl.
4876 * dired.c (Ffile_attributes): New forward static decl.
4877 * doc.c (Fdocumntation_property): New forward static decl.
4878 * eval.c (Ffetch_bytecode): New forward static decl.
4879 (Funintern): Remove extern decl; now in .h file where it belongs.
4880 * fileio.c (Fmake_symbolic_link): New forward static decl.
4881 * image.c (Finit_image_library): New forward static decl.
4882 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4883 * intervals.h (Fprevious_property_change):
4884 (Fremove_list_of_text_properties): Remove decls.
4885 * keyboard.c (Fthis_command_keys): Remove decl.
4886 (Fcommand_execute): New forward static decl.
4887 * keymap.c (Flookup_key): New forward static decl.
4888 (Fcopy_keymap): Now static.
4889 * keymap.h (Flookup_key): Remove decl.
4890 * process.c (Fget_process): New forward static decl.
4891 (Fprocess_datagram_address): Mark as internal.
4892 * syntax.c (Fsyntax_table_p): New forward static decl.
4893 (skip_chars): Remove duplicate decl.
4894 * textprop.c (Fprevious_property_change): New forward static decl.
4895 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4896 Now internal.
4897 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4898 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4899
785bbd42
PE
4900 * editfns.c (Fformat): Remove unreachable code.
4901
8b913b57
AS
49022011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4903
4904 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4905 change. (Bug#8496)
4906
a6744a35
EZ
49072011-04-13 Eli Zaretskii <eliz@gnu.org>
4908
4909 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4910 when at ZV. (Bug#8487)
4911
e7974947
AS
49122011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4913
baad03f0
AS
4914 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4915 (Bug#8437)
4916 * keyboard.c (parse_tool_bar_item): Likewise.
4917 * sound.c (sound_cleanup, alsa_close): Likewise.
4918 * termcap.c (tgetent): Likewise.
4919 * xfns.c (x_default_font_parameter): Likewise.
4920 * xsettings.c (read_and_apply_settings): Likewise.
4921
e7974947
AS
4922 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4923 (overrun_check_free): Protoize.
4924
28272684
PE
49252011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4926
4927 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4928 since callers should never pass a negative size.
4929 Change the signature to match that of plain 'read' and 'write'; see
4930 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4931 * lisp.h: Update prototypes of emacs_write and emacs_read.
4932
11997c76
EZ
49332011-04-11 Eli Zaretskii <eliz@gnu.org>
4934
4935 * xdisp.c (redisplay_window): Don't try to determine the character
4936 position of the scroll margin if the window start point w->startp
e896f03c 4937 is outside the buffer's accessible region. (Bug#8468)
11997c76 4938
8a2cbd72
EZ
49392011-04-10 Eli Zaretskii <eliz@gnu.org>
4940
4941 Fix write-region and its subroutines for buffers > 2GB.
4942 * fileio.c (a_write, e_write): Modify declaration of arguments and
4943 local variables to support buffers larger than 2GB.
4944 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4945
4946 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4947 argument, local variables, and return value.
4948
4949 * lisp.h: Update prototypes of emacs_write and emacs_read.
4950
4951 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4952
4073e537 49532011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4954
1ebfdcb6
PE
4955 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4956
b2ded58d
PE
4957 Fix more problems found by GCC 4.6.0's static checks.
4958
7d66342c
PE
4959 * xdisp.c (vmessage): Use a better test for character truncation.
4960
bbf47d44
PE
4961 * charset.c (load_charset_map): <, not <=, for optimization,
4962 and to avoid potential problems with integer overflow.
9248994d 4963 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4964 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4965 * editfns.c (Fformat): Likewise.
1e69125e 4966 * syntax.c (skip_chars): Likewise.
3befa583 4967
e3019616
PE
4968 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4969 This also lets GCC 4.6.0 generate slightly better loop code.
4970
becfa255
PE
4971 * callint.c (Fcall_interactively): <, not <=, for optimization.
4972 (Fcall_interactively): Count the number of arguments produced,
4973 not the number of arguments given. This is simpler and lets GCC
4974 4.6.0 generate slightly better code.
4975
dae0cd48
PE
4976 * ftfont.c: Distingish more carefully between FcChar8 and char.
4977 The previous code passed unsigned char * to a functions like
4978 strlen and xstrcasecmp that expect char *, which does not
4979 conform to the C standard.
4980 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4981 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4982 char * when the C standard requires it.
4983
76032d70
PE
4984 * keyboard.c (read_char): Remove unused var.
4985
eb3f1cc8
PE
4986 * eval.c: Port to Windows vsnprintf (Bug#8435).
4987 Include <limits.h>.
4988 (SIZE_MAX): Define if the headers do not.
4989 (verror): Do not give up if vsnprintf returns a negative count.
4990 Instead, grow the buffer. This ports to Windows vsnprintf, which
4991 does not conform to C99. Problem reported by Eli Zaretskii.
4992 Also, simplify the allocation scheme, by avoiding the need for
4993 calling realloc, and removing the ALLOCATED variable.
4994
70476b54
PE
4995 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4996
12020a9e
PE
4997 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4998 But keep the doprint source code for now, as we might revamp it
4999 and use it again (Bug#8435).
ea6c7ae6
PE
5000 * lisp.h (doprnt): Remove.
5001 * Makefile.in (base_obj): Remove doprnt.o.
5002 * deps.mk (doprnt.o): Remove.
5003
5fdb398c
PE
5004 error: Print 32- and 64-bit integers portably (Bug#8435).
5005 Without this change, on typical 64-bit hosts error ("...%d...", N)
5006 was used to print both 32- and 64-bit integers N, which relied on
5007 undefined behavior.
5008 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5009 New macro.
5010 * lisp.h (error, verror): Mark as printf-like functions.
5011 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5012 Report overflow in size calculations when allocating printf buffer.
5013 Do not truncate output string at its first null byte.
5014 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5015 Truncate the output at a character boundary, since vsnprintf does not
5016 do that.
5017 * charset.c (check_iso_charset_parameter): Convert internal
5018 character to string before calling 'error', since %c now has the
5019 printf meaning.
5020 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5021 overflow when computing char to be passed to 'error'. Do not
5022 pass Lisp_Object to 'error'; pass the integer instead.
5023 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5024 formatted with plain %d.
5025
b189fa66
PE
5026 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5027
bff87ef0
PE
5028 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5029
7e2cac20
PE
5030 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5031
ce4d90b5
PE
5032 * xterm.c (x_catch_errors): Remove duplicate declaration.
5033
266c9547
PE
5034 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5035
79c49ad2
PE
5036 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5037
368f4090
JM
50382011-04-10 Jim Meyering <meyering@redhat.com>
5039
5040 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5041 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5042 return ssize_t not "int", and use size_t as the buffer length.
5043 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5044 * gnutls.h: Update declarations.
5045 * process.c (read_process_output): Use ssize_t, to match.
5046 (send_process): Likewise.
5047
a32d4040
CY
50482011-04-09 Chong Yidong <cyd@stupidchicken.com>
5049
5050 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5051
8546720e 50522011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5053
04f2d78b
CB
5054 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5055 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5056
8546720e
GM
5057 * xterm.c (handle_one_xevent):
5058 * xmenu.c (create_and_show_popup_menu):
5059 * xselect.c (x_decline_selection_request)
5060 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5061
0a2f5c1a 50622011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5063
5064 Fix some uses of `int' instead of EMACS_INT.
5065 * search.c (string_match_1, fast_string_match)
5066 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5067 (scan_buffer, find_next_newline_no_quit)
5068 (find_before_next_newline, search_command, Freplace_match)
5069 (Fmatch_data): Make some `int' variables be EMACS_INT.
5070
5071 * xdisp.c (display_count_lines): 3rd argument and return value now
5072 EMACS_INT. All callers changed.
5073 (pint2hrstr): Last argument is now EMACS_INT.
5074
5075 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5076 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5077 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5078 (decode_coding_utf_16, decode_coding_emacs_mule)
5079 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5080 (decode_coding_ccl, decode_coding_charset)
5081 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5082 (decode_coding_iso_2022, decode_coding_emacs_mule)
5083 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5084 <char_offset, last_offset>: Declare EMACS_INT.
5085 (encode_coding_utf_8, encode_coding_utf_16)
5086 (encode_coding_emacs_mule, encode_invocation_designation)
5087 (encode_designation_at_bol, encode_coding_iso_2022)
5088 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5089 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5090 Declare EMACS_INT.
5091 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5092 (encode_invocation_designation): Last argument P_NCHARS is now
5093 EMACS_INT.
5094 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5095 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5096
5097 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5098 All users changed.
5099
5100 * ccl.c (Fccl_execute_on_string): Declare some variables
5101 EMACS_INT.
5102
8546720e 51032011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5104
5105 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5106
4e19a977
CS
51072011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5108
5109 * process.c (Fformat_network_address): Doc fix.
5110
87302331
R
51112011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5112
5113 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5114
cbb59342
CY
51152011-04-08 Chong Yidong <cyd@stupidchicken.com>
5116
5117 * keyboard.c (read_char): Call Lisp function help-form-show,
5118 instead of using internal_with_output_to_temp_buffer.
5119 (Qhelp_form_show): New var.
e0d38eeb 5120 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5121
5122 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5123
5124 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5125
e67a13ab
CY
51262011-04-06 Chong Yidong <cyd@stupidchicken.com>
5127
04f2d78b
CB
5128 * process.c (Flist_processes): Remove to Lisp.
5129 (list_processes_1): Delete.
e67a13ab 5130
973f782d
EZ
51312011-04-06 Eli Zaretskii <eliz@gnu.org>
5132
7c106b1e
EZ
5133 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5134
973f782d
EZ
5135 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5136
41cf7d1a 51372011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5138
ca23cc88
PE
5139 Fix more problems found by GCC 4.6.0's static checks.
5140
f390e2d5
PE
5141 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5142
42eea0d0
PE
5143 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5144
b69769da 5145 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5146
f9541e84
PE
5147 * xdisp.c (vmessage): Mark as a printf-like function.
5148
13841b55
PE
5149 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5150
c136c10f
PE
5151 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5152
5e2d4a30
PE
5153 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5154 printf-like functions.
5155 (tiff_load): Add casts to remove these marks before passing them
5156 to system-supplied API.
5157
583f48b9
PE
5158 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5159
b25d760e
PE
5160 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5161 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5162 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5163 directly, rather than having caller test rule sign. This avoids
5164 some unnecessary tests.
5165 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5166 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5167 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5168
bc7b6697 5169 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5170 (xfont_open): Avoid unnecessary tests.
bc7b6697 5171
27ccc379
PE
5172 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5173
dcd5c89a
PE
5174 * composite.h, composite.c (composition_gstring_put_cache):
5175 Use EMACS_INT, not int, for length.
5176
b13a45c6
PE
5177 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5178 breaking out part of COMPOSITION_DECODE_RULE.
5179 (COMPOSITION_DECODE_RULE): Use it.
5180 * composite.c (get_composition_id): Remove unused local vars,
5181 by using the new macro.
5182
1e792e4d
PE
5183 * textprop.c (set_text_properties_1): Change while to do-while,
5184 since the condition is always true at first.
5185
dc6c6455 5186 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5187 (interval_deletion_adjustment): Return unsigned value.
5188 All uses changed.
dc6c6455 5189
aba7731a
PE
5190 * process.c (list_processes_1, create_pty, read_process_output):
5191 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5192 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5193 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5194 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5195 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5196
fdfc4bf3
PE
5197 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5198
fca8fe46 5199 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5200 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5201
06a0259a 5202 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5203 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5204 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5205
e7b9e80f
PE
5206 * print.c (print_error_message): Avoid int overflow.
5207
56201685
PE
5208 * font.c (font_list_entities): Redo for clarity,
5209 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5210
78834453 5211 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5212 (font_score): Avoid potential overflow in diff calculation.
78834453 5213
0bc0b309 5214 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5215 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5216
e610eaca
PE
5217 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5218
b895abce
PE
5219 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5220 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5221 can always succeed if overflow has undefined behavior.
5222
1f1d9321 5223 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5224 (wordify): Omit three unnecessary tests.
1f1d9321 5225
c59478bc
PE
5226 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5227 All callers changed. This avoids the need for an unused var.
5228
79b73827
PE
5229 * casefiddle.c (casify_region): Remove var that is set but not used.
5230
a4db5dfe
PE
5231 * dired.c (file_name_completion): Remove var that is set but not used.
5232
43aae36e
PE
5233 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5234
2a47c44d 5235 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5236 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5237
a37c69bf
PE
5238 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5239 Check for integer overflow on size calculations.
5240
328ab8e7
PE
5241 * buffer.c (Fprevious_overlay_change): Remove var that is set
5242 but not used.
5243
e5a2a5cb
PE
5244 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5245 Remove vars that are set but not used.
8d84a6eb 5246 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5247 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5248
a60e5f68
PE
5249 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5250
f661cb61 5251 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5252 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5253
f0397f5a
PE
5254 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5255 that are set but not used.
5256
8664db06 5257 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5258 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5259
6abdaa4a
PE
5260 * xselect.c (x_get_local_selection, x_handle_property_notify):
5261 Remove vars that are set but not used.
5262
0ce7538d 5263 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5264 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5265
9ae848fc
PE
5266 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5267 Remove var that is set but not used.
0b918413
PE
5268 (scroll_bar_windows_size): Now size_t, not int.
5269 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5270 Check for overflow.
9ae848fc 5271
a5a62657
PE
5272 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5273 (map_tty_color) [!defined MSDOS]: Likewise.
5274
5c5cdd39
PE
5275 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5276
66ebf983
PE
5277 * coding.c: Remove vars that are set but not used.
5278 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5279 All callers changed.
5280 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5281 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5282 (decode_coding_charset): Remove vars that are set but not used.
5283
1be4d761
PE
5284 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5285 that is set but not used.
5286
47553fa8
PE
5287 * print.c (print_object): Remove var that is set but not used.
5288
1f7196bf 5289 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5290 The gnulib version avoids calling malloc in the usual case,
5291 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5292 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5293 * filelock.c (current_lock_owner): Likewise.
5294 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5295 * sysdep.c: Include allocator.h, careadlinkat.h.
5296 (emacs_no_realloc_allocator): New static constant.
5297 (emacs_readlink): New function.
fdb61804
PE
5298 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5299 ../lib/careadlinkat.h.
d1fdcab7 5300
f84c17c7
SM
53012011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5302
5303 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5304 first non-nil return value).
5305
ef3862ad
JD
53062011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5307
5308 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5309 if not defined (Bug#8403).
5310
376a7006
JB
53112011-04-02 Juanma Barranquero <lekktu@gmail.com>
5312
5313 * xdisp.c (display_count_lines): Remove parameter `start',
5314 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5315 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5316 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5317 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5318 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5319 and thereabouts. All callers changed.
5320 (get_per_char_metric): Remove parameter `f', unused since
5321 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5322
6ca3801d
JM
53232011-04-02 Jim Meyering <meyering@redhat.com>
5324
5325 do not dereference NULL upon failed strdup
5326 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5327 (ns_get_family): Likewise.
5328
d8e2b5ba
JB
53292011-04-02 Juanma Barranquero <lekktu@gmail.com>
5330
5331 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5332
8c74fcbd
JD
53332011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5334
5335 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5336 later (Bug#8403).
5337
7200d79c
SM
53382011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5339
03408648 5340 Add lexical binding.
7200d79c 5341
03408648
SM
5342 * window.c (Ftemp_output_buffer_show): New fun.
5343 (Fsave_window_excursion):
5344 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5345
5346 * lread.c (lisp_file_lexically_bound_p): New function.
5347 (Fload): Bind Qlexical_binding.
5348 (readevalloop): Remove `evalfun' arg.
5349 Bind Qinternal_interpreter_environment.
5350 (Feval_buffer): Bind Qlexical_binding.
5351 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5352 Mark as dynamic.
5353 (syms_of_lread): Declare `lexical-binding'.
5354
5355 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5356
5357 * keyboard.c (eval_dyn): New fun.
5358 (menu_item_eval_property): Use it.
ca105506
SM
5359
5360 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5361
03408648
SM
5362 * fns.c (concat, mapcar1): Accept byte-code-functions.
5363
5364 * eval.c (Fsetq): Handle lexical vars.
5365 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5366 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5367 (FletX, Flet): Obey lexical binding.
5368 (Fcommandp): Handle closures.
5369 (Feval): New `lexical' arg.
5370 (eval_sub): New function extracted from Feval. Use it almost
5371 everywhere where Feval was used. Look up vars in lexical env.
5372 Handle closures.
5373 (Ffunctionp): Move from subr.el.
5374 (Ffuncall): Handle closures.
5375 (apply_lambda): Remove `eval_flags'.
5376 (funcall_lambda): Handle closures and new byte-code-functions.
5377 (Fspecial_variable_p): New function.
5378 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5379 but without exporting it to Lisp.
23aba0ea 5380
23aba0ea 5381 * doc.c (Fdocumentation, store_function_docstring):
03408648 5382 * data.c (Finteractive_form): Handle closures.
23aba0ea 5383
03408648
SM
5384 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5385 interactive spec.
ba83908c 5386
04f2d78b
CB
5387 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5388 New byte-codes.
03408648
SM
5389 (exec_byte_code): New function extracted from Fbyte_code to handle new
5390 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5391
03408648 5392 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5393
03408648 5394 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5395
e2abce01
JB
53962011-03-31 Juanma Barranquero <lekktu@gmail.com>
5397
5398 * xdisp.c (redisplay_internal): Fix prototype.
5399
63696a73 54002011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5401
63696a73 5402 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5403 (try_scrolling): Use it when setting scroll_limit.
5404 Limit scrolling to 100 screen lines.
63696a73
EZ
5405 (redisplay_window): Even when falling back on "recentering",
5406 position point in the window according to scroll-conservatively,
5407 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5408
5409 (try_scrolling): When point is above the window, allow searching
5410 as far as scroll_max, or one screenful, to compute vertical
5411 distance from PT to the scroll margin position. This prevents
5412 try_scrolling from unnecessarily failing when
5413 scroll-conservatively is set to a value slightly larger than the
5414 window height. Clean up the case of PT below the margin at bottom
5415 of window: scroll_max can no longer be INT_MAX. When aggressive
5416 scrolling is in use, don't let point enter the opposite scroll
5417 margin as result of the scroll.
5418 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5419 threshold of 100 lines for never-recentering scrolling.
5420
e4cc2dfc
JB
54212011-03-31 Juanma Barranquero <lekktu@gmail.com>
5422
5423 * dispextern.h (move_it_by_lines):
5424 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5425 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5426 (message_log_check_duplicate): Remove parameters `prev_bol' and
5427 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5428 (redisplay_internal): Remove parameter `preserve_echo_area',
5429 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5430
5431 * indent.c (Fvertical_motion):
5432 * window.c (window_scroll_pixel_based, Frecenter):
5433 Don't pass `need_y_p' to `move_it_by_lines'.
5434
1c470562
SM
54352011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5436
44f230aa
SM
5437 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5438 steal a few bits to be more compact.
5439 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5440 Remove unneeded casts.
5441
1c470562
SM
5442 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5443
888adce9
ZK
54442011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5445
5446 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5447 binding" message (bug#7967).
5448
f838ed7b
PE
54492011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5450
77861b95
PE
5451 Fix more problems found by GCC 4.6.0's static checks.
5452
de6dbc14
PE
5453 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5454 Remove unused local var.
5455
f838ed7b
PE
5456 * editfns.c (Fmessage_box): Remove unused local var.
5457
792c7b2b
PE
5458 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5459 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5460 Omit unused local vars.
c499e557 5461 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5462 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5463 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5464 Omit unused local var.
5465
ba0165e1
PE
5466 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5467 Don't assume string length fits in int.
32ad8845 5468 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5469 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5470
3c59b4c9
PE
5471 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5472 instead of alloca (Bug#8344).
5473
a3eed478 5474 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5475 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5476
eb4d412d
PE
5477 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5478
1658b401
PE
5479 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5480 concerns.
5481
5482 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5483
5484 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5485
9a2c6e05
PE
5486 * keyboard.c (syms_of_keyboard): Use the same style as later
5487 in this function when indexing through an array. This also
5488 works around GCC bug 48267.
5489
03d0a109
PE
5490 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5491
44f730c8
PE
5492 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5493
fe75f926
PE
5494 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5495 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5496
ffa8c828
PE
5497 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5498 This avoids undefined behavior on integer overflow, and is a bit
5499 more convenient anyway since it is compared to a size_t variable.
5500
c5101a77
PE
5501 Variadic C functions now count arguments with size_t, not int.
5502 This avoids an unnecessary limitation on 64-bit machines, which
5503 caused (substring ...) to crash on large vectors (Bug#8344).
5504 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5505 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5506 All variadic functions and their callers changed accordingly.
c5101a77
PE
5507 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5508 * data.c (arith_driver, float_arith_driver): Likewise.
5509 * editfns.c (general_insert_function): Likewise.
5510 * eval.c (struct backtrace.nargs, interactive_p)
5511 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5512 (funcall_lambda, mark_backtrace): Likewise.
5513 * fns.c (concat): Likewise.
5514 * frame.c (x_set_frame_parameters): Likewise.
5515 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5516 0 if not found, not -1. All callers changed.
5517
dd3f25f7
PE
5518 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5519 (stack_copy_size): Now size_t, not int.
5520 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5521
461c2ab9
JB
55222011-03-28 Juanma Barranquero <lekktu@gmail.com>
5523
5524 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5525 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5526 All callers changed.
5527
5528 * lisp.h (multibyte_char_to_unibyte):
5529 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5530 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5531 * character.h (CHAR_TO_BYTE8):
5532 * cmds.c (internal_self_insert):
5533 * editfns.c (general_insert_function):
5534 * keymap.c (push_key_description):
5535 * search.c (Freplace_match):
5536 * xdisp.c (message_dolog, set_message_1): All callers changed.
5537
f6d62986
SM
55382011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5539
5540 * keyboard.c (safe_run_hook_funcall): New function.
5541 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5542 don't set the hook to nil, but remove the offending function instead.
5543 (Qcommand_hook_internal): Remove, unused.
5544 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5545 Vcommand_hook_internal.
5546
5547 * eval.c (enum run_hooks_condition): Remove.
5548 (funcall_nil, funcall_not): New functions.
5549 (run_hook_with_args): Call each function through a `funcall' argument.
5550 Remove `cond' argument, now redundant.
5551 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5552 (Frun_hook_with_args_until_failure): Adjust accordingly.
5553 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5554
1db5b1ad
JB
55552011-03-28 Juanma Barranquero <lekktu@gmail.com>
5556
5557 * dispextern.h (string_buffer_position): Remove declaration.
5558
5559 * print.c (strout): Remove parameter `multibyte', unused since
5560 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5561
5562 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5563 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5564 All callers changed.
5565
5566 * w32.c (_wsa_errlist): Use braces for struct initializers.
5567
5568 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5569 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5570 All callers changed.
5571 (string_buffer_position): Likewise. Also, make static (it's never
5572 used outside xdisp.c).
5573 (cursor_row_p): Remove parameter `w', unused since
5574 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5575 (decode_mode_spec): Remove parameter `precision', introduced during
5576 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5577 All callers changed.
5578
5ffb62aa
JD
55792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5580
5581 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5582
461c2ab9 55832011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5584
5585 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5586 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5587 (ns_update_auto_hide_menu_bar): New functions.
5588 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5589 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5590 ns_constrain_all_frames.
5591 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5592 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5593
5c380ffb
JD
55942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5595
5596 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5597
9af30bdf
GM
55982011-03-27 Glenn Morris <rgm@gnu.org>
5599
5600 * syssignal.h: Replace RETSIGTYPE with void.
5601 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5602 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5603 Replace SIGTYPE with void everywhere.
5604 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5605 * s/template.h (SIGTYPE): Remove commented out definition.
5606
e2abce01
JB
56072011-03-26 Eli Zaretskii <eliz@gnu.org>
5608
5609 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5610 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5611
f868cd8a
JB
56122011-03-26 Juanma Barranquero <lekktu@gmail.com>
5613
59eb0929
JB
5614 * w32.c (read_unc_volume): Use parameter `henum', instead of
5615 global variable `wget_enum_handle'.
5616
5617 * keymap.c (describe_vector): Remove parameters `indices' and
5618 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5619 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5620
f868cd8a
JB
5621 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5622
5623 * keyboard.c (timer_check): Remove parameter `do_it_now',
5624 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5625 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5626 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5627
5628 * keyboard.c (read_char):
5629 * w32menu.c (w32_menu_display_help):
5630 * xmenu.c (show_help_event, menu_help_callback):
5631 Adjust calls to `show_help_echo'.
5632
5633 * gtkutil.c (xg_maybe_add_timer):
5634 * keyboard.c (readable_events):
5635 * process.c (wait_reading_process_output):
5636 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5637
5638 * insdel.c (adjust_markers_gap_motion):
5639 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5640 (gap_left, gap_right): Don't call it.
5641
2ecf6fdb
CY
56422011-03-25 Chong Yidong <cyd@stupidchicken.com>
5643
5644 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5645 incurred during fontification.
5646
6b1f9ba4
JB
56472011-03-25 Juanma Barranquero <lekktu@gmail.com>
5648
5649 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5650 (DEFVAR_PER_BUFFER): Don't pass it.
5651
5652 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5653 (scrolling_window): Don't pass it.
5654
0f4a96b5
JB
56552011-03-25 Juanma Barranquero <lekktu@gmail.com>
5656
5657 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5658
5659 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5660 and `suffix'.
5661 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5662 of variables specific to SELinux and computation of `encoded_absname'.
5663
5664 * image.c (XPutPixel): Remove unused variable `height'.
5665
5666 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5667
5668 * unexw32.c (get_section_info): Remove unused variable `section'.
5669
5670 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5671 (system_process_attributes): Remove unused variable `sess'.
5672 (sys_read): Remove unused variable `err'.
5673
5674 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5675 (w32_wnd_proc): Remove unused variable `isdead'.
5676 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5677 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5678 (x_create_tip_frame): Remove unused variable `tem'.
5679
5680 * w32inevt.c (w32_console_read_socket):
5681 Remove unused variable `no_events'.
5682
5683 * w32term.c (x_draw_composite_glyph_string_foreground):
5684 Remove unused variable `width'.
5685
1149507c
JB
56862011-03-24 Juanma Barranquero <lekktu@gmail.com>
5687
5688 * w32term.c (x_set_glyph_string_clipping):
5689 Don't pass uninitialized region to CombineRgn.
5690
9c88f339
JB
56912011-03-23 Juanma Barranquero <lekktu@gmail.com>
5692
5693 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5694 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5695 (Fx_close_connection): Remove unused variable `i'.
5696
5697 * w32font.c (w32font_draw): Return number of glyphs.
5698 (w32font_open_internal): Remove unused variable `i'.
5699 (w32font_driver): Add missing initializer.
5700
5701 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5702 (fill_in_menu): Remove unused variable `items_added'.
5703
5704 * w32term.c (last_mouse_press_frame): Remove static global variable.
5705 (w32_clip_to_row): Remove unused variable `f'.
5706 (x_delete_terminal): Remove unused variable `i'.
5707
5708 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5709 (NOTHING): Remove unused static global variable.
5710 (uniscribe_check_otf): Remove unused variable `table'.
5711 (uniscribe_font_driver): Add missing initializers.
5712
dee091a3
JD
57132011-03-23 Julien Danjou <julien@danjou.info>
5714
5715 * term.c (Fsuspend_tty, Fresume_tty):
5716 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5717 * window.c (temp_output_buffer_show):
5718 * insdel.c (signal_before_change):
5719 * frame.c (Fhandle_switch_frame):
5720 * fileio.c (Fdo_auto_save):
5721 * emacs.c (Fkill_emacs):
5722 * editfns.c (save_excursion_restore):
5723 * cmds.c (internal_self_insert):
5724 * callint.c (Fcall_interactively):
5725 * buffer.c (Fkill_all_local_variables):
5726 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5727 Use Frun_hooks.
0f4a96b5 5728 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5729 unconditionnaly since it does the check itself.
5730
2c520ab5 57312011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5732
c9c49752
PE
5733 Fix more problems found by GCC 4.5.2's static checks.
5734
8abc3f12
PE
5735 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5736 the first time through the loop, since we know p0 < p1 then.
5737 This also avoids a gcc -Wstrict-overflow warning.
5738
a2d26660
PE
5739 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5740 leading to a memory leak, possible in functions like
5741 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5742 of objects (Bug#8318).
a2d26660 5743
916c72e9
PE
5744 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5745 that could (at least in theory) be that large.
5746
19ab8a18
PE
5747 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5748 This is less likely to overflow, and avoids undefined behavior if
5749 overflow does occur. All callers changed. Use strtoul to scan
5750 for the unsigned long integer.
b7cbbd6f
PE
5751 (pint2hrstr): Simplify and tune code slightly.
5752 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5753
f0641eff
PE
5754 * scroll.c (do_scrolling): Work around GCC bug 48228.
5755 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5756
7f650bb9
PE
5757 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5758 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5759 (validate_x_resource_name): Simplify count usage.
5760 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5761
37dd57d1
PE
5762 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5763 fail (Bug#8306).
81e56e61 5764
699979fc 5765 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5766
401bf9b4
PE
5767 * process.c (Fmake_network_process): Use socklen_t, not int,
5768 where POSIX says socklen_t is required in portable programs.
5769 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5770 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5771 (Fmake_network_process, server_accept_connection):
5772 (wait_reading_process_output, read_process_output):
5773 Likewise.
5774
b93aacde
PE
5775 * process.c: Rename or move locals to avoid shadowing.
5776 (list_processes_1, Fmake_network_process):
5777 (read_process_output_error_handler, exec_sentinel_error_handler):
5778 Rename or move locals.
4dc343ee 5779 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5780 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5781 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5782 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5783 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5784
af8a867c 5785 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5786 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5787 Include tparam.h instead, since it declares them.
af8a867c
PE
5788 * cm.h (PC): Remove extern decl; tparam.h now does this.
5789 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5790 * terminfo.c: Include tparam.h, to check interfaces.
5791 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5792 (tparam): Adjust signature to match interface in tparam.h;
5793 this removes some undefined behavior. Check that outstring and len
5794 are zero, which they always are with Emacs.
5795 * tparam.h (PC, BC, UP): New extern decls.
5796
0248044d 5797 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5798 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5799
8ff096c1 5800 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5801 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5802 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5803 (ftfont_list): Remove unused local.
49eaafba
PE
5804 (get_adstyle_property, ftfont_pattern_entity):
5805 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5806 Rename locals to avoid shadowing.
8ff096c1 5807
e2be39f6
PE
5808 * xfont.c (xfont_list_family): Mark var as initialized.
5809
c9735e30
PE
5810 * xml.c (make_dom): Now static.
5811
8f5201ae
PE
5812 * composite.c (composition_compute_stop_pos): Rename local to
5813 avoid shadowing.
b246f932
PE
5814 (composition_reseat_it): Remove unused locals.
5815 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5816 (composition_update_it): Mark var as initialized.
11b61122
PE
5817 (find_automatic_composition): Mark vars as initialized,
5818 with a FIXME (Bug#8290).
8f5201ae 5819
760fbc2c
PE
5820 character.h: Rename locals to avoid shadowing.
5821 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5822 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5823 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5824 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5825 to avoid shadowing.
5826
ff08eb85
PE
5827 * textprop.c (property_change_between_p): Remove; unused.
5828
fc7bf025
PE
5829 * intervals.c (interval_start_pos): Now static.
5830
235d7abc
PE
5831 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5832
44f230aa
SM
5833 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5834 Rename locals to avoid shadowing.
3e7d6594 5835
50060332
PE
5836 * sound.c (wav_play, au_play, Fplay_sound_internal):
5837 Fix pointer signedness.
d01f234b 5838 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5839 (wav_play): Initialize a variable to 0, to prevent undefined
5840 behavior (Bug#8278).
50060332 5841
c4fc4e30
PE
5842 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5843
918436ed
PE
5844 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5845
c939f91b
PE
5846 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5847 clobbering (Bug#8298).
b9c7f648
PE
5848 * sysdep.c (sys_subshell): Likewise.
5849 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5850
6bd8c144
PE
5851 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5852 This should get cleaned up, so that child_setup has the
5853 same signature on all platforms.
5854
7710357c 5855 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5856 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5857
c59da222
CY
58582011-03-22 Chong Yidong <cyd@stupidchicken.com>
5859
5860 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5861 not to be necessary, and produces flickering.
5862
66b87493
GM
58632011-03-20 Glenn Morris <rgm@gnu.org>
5864
5865 * config.in: Remove file.
5866
45b6f6d5
JB
58672011-03-20 Juanma Barranquero <lekktu@gmail.com>
5868
5869 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5870 are now in src/globals.h.
5871 (syms_of_minibuf): Remove spurious & from previous change.
5872
3ec03f7e
LL
58732011-03-20 Leo <sdl.web@gmail.com>
5874
5875 * minibuf.c (completing-read-function): New variable.
5876 (completing-read-default): Rename from completing-read.
5877 (completing-read): Call completing-read-function.
5878
b14e3e21
CY
58792011-03-19 Juanma Barranquero <lekktu@gmail.com>
5880
5881 * xfaces.c (Fx_load_color_file):
5882 Read color file from absolute filename (bug#8250).
5883
f2b726e6
JB
58842011-03-19 Juanma Barranquero <lekktu@gmail.com>
5885
5886 * makefile.w32-in: Update dependencies.
5887
09f6ff02
EZ
58882011-03-17 Eli Zaretskii <eliz@gnu.org>
5889
5890 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5891
29a6015a
PE
58922011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5893
a3a6c54e
PE
5894 Fix more problems found by GCC 4.5.2's static checks.
5895
b766f867
PE
5896 * process.c (make_serial_process_unwind, send_process_trap):
5897 (sigchld_handler): Now static.
5898
be02381c
PE
5899 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5900 That way, the code declares only the vars that it needs.
5901 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5902 * s/cygwin.h (PTY_ITERATION): Likewise.
5903 * s/darwin.h (PTY_ITERATION): Likewise.
5904 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5905
57048744
PE
5906 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5907 * process.c (allocate_pty): Don't declare stb unless it's needed.
5908
7914961c 5909 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5910 (CONSTANTLIM): Remove; unused.
5911 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5912 Define only if needed.
7914961c 5913
b3967b18
PE
5914 * unexelf.c (unexec): Name an expression,
5915 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5916 Use a different way to cause a compilation error if anyone uses
5917 n rather than nn, a way that does not involve shadowing.
73366a00 5918 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5919
29a6015a
PE
5920 * deps.mk (unexalpha.o): Remove; unused.
5921
43cfc33e 5922 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5923 * unexec.h: New file.
ce701a33
PE
5924 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5925 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5926 Depend on unexec.h.
5927 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5928 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5929 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5930 Change as necessary to match prototype in unexec.h.
ce701a33 5931
01f44d5a
PE
5932 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5933 shadowing.
4f63c6bb 5934 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5935
a6670b0b
PE
5936 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5937 Rename locals to avoid shadowing.
5938
cef2010d 5939 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5940 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5941
d4d7173a
PE
5942 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5943
f08b802a
PE
5944 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5945 warning when compiling print.c.
5946
3ddb0639
PE
5947 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5948 instead of using an uninitialized var.
5ad03b97 5949 (font_sort_entities): Mark var as initialized.
3ddb0639 5950
170a2692
PE
5951 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5952
e663c700
PE
5953 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5954 pointers to constants.
89bc529a 5955 (font_parse_fcname): Remove unused vars.
7b81e2d0 5956 (font_delete_unmatched): Now static.
ea838e10 5957 (font_get_spec): Remove; unused.
13a547c6
PE
5958 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5959 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5960 Rename or move locals to avoid shadowing.
e663c700 5961
2a80c887 5962 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5963 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5964
1384fa33 5965 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5966 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5967
8b2c52e9
PE
5968 * alloc.c (mark_backtrace): Move decl from here ...
5969 * lisp.h: ... to here, so that it can be checked.
5970
475545b5 5971 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5972 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5973 (lisp_indirect_variable): Name an expression,
5974 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5975 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5976
b1349114 5977 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5978 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5979 Use const pointer when appropriate.
b1349114 5980
a2928364
PE
5981 * lisp.h (get_system_name, get_operating_system_release):
5982 Move decls here, to check interfaces.
5983 * process.c (get_operating_system_release): Move decl to lisp.h.
5984 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5985 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5986 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5987 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5988 (Fformat_time_string, Fencode_time, Finsert_char):
5989 (Ftranslate_region_internal, Fformat):
5990 Rename or remove local vars to avoid shadowing.
9710023e 5991 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5992
a415e694
PE
5993 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5994 avoid shadowing.
5995
8ef4622d
PE
5996 * lisp.h (eassert): Check that the argument compiles, even if
5997 ENABLE_CHECKING is not defined.
5998
946f9a5b
PE
5999 * data.c (Findirect_variable): Name an expression, to avoid
6000 gcc -Wbad-function-cast warning.
112396d6 6001 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6002 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6003 (Fmake_variable_buffer_local, Fmake_local_variable):
6004 Mark variables as initialized.
52746918 6005 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6006
e5aab7e7 6007 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6008 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6009 Rename locals to avoid shadowing.
dff45157
PE
6010 (mark_stack): Move local variables into the #ifdef region where
6011 they're used.
7bc26fdb
PE
6012 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6013 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6014 needed otherwise.
6015 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6016 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6017 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6018
e5aab7e7
PE
6019 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6020 avoids undefined behavior in theory.
6021
4da60324
PE
6022 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6023
88043301
PE
6024 Use functions, not macros, for up- and down-casing (Bug#8254).
6025 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6026 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6027 to use the following functions instead of these macros.
6028 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6029 EMACS_INT, since callers assume the returned value fits in int.
6030 (upcase1): Likewise, for UPCASE_TABLE.
6031 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6032 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6033 the race-condition problem in the old DOWNCASE.
88043301 6034
19ed5445
PE
6035 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6036 Rename locals to avoid shadowing.
6037 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6038 (regex_compile, re_search_2, re_match_2_internal):
6039 Remove unused local vars.
952db0d7
PE
6040 (FREE_VAR): Rewrite so as not to use empty "else",
6041 which gcc can warn about.
da053e48 6042 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6043 (RETALLOC_IF): Define only if needed.
6044 (WORDCHAR_P): Likewise. This one is never needed, but is used
6045 only in a comment talking about a compiler bug, so put inside
6046 the #if 0 of that comment.
6047 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6048 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6049 Remove; unused.
19ed5445 6050
1f3561e4 6051 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6052 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6053 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6054
ded6f8f7
PE
6055 * search.c (simple_search): Remove unused var.
6056
dbd37a95
PE
6057 * dired.c (compile_pattern): Move decl from here ...
6058 * lisp.h: ... to here, so that it can be checked.
6059 (struct re_registers): New forward decl.
6060
7e47afad
PE
6061 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6062
85f24f61
PE
6063 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6064 All uses changed.
6065 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6066 Rename locals to avoid shadowing.
5671df8f 6067 (Fvertical_motion): Mark locals as initialized.
85f24f61 6068
181aa2be 6069 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6070 (casify_region): Mark local as initialized.
181aa2be 6071
930d429c
PE
6072 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6073
7082eac6
PE
6074 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6075 New macros, so that the caller can use some names other than
6076 gcpro1, gcpro2, etc.
6077 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6078 of the new macros.
6079 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6080 argument, for consistency with GCPRO2_VAR, etc: it is now the
6081 prefix of the variable, not the variable itself. All uses
6082 changed.
38b2c076
PE
6083 * dired.c (directory_files_internal, file_name_completion):
6084 Rename locals to avoid shadowing.
6085
15206ed9
PE
6086 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6087 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6088 dired.c's scmp function, had undefined behavior.
6089 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6090 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6091 * buffer.h: ... to here, because these macros use current_buffer,
6092 and the new implementation with inline functions needs to have
6093 current_buffer in scope now, rather than later when the macros
6094 are used.
6095 (downcase, upcase1): New static inline functions.
6096 (DOWNCASE, UPCASE1): Reimplement using these functions.
6097 This avoids undefined behavior in expressions like
6098 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6099 from race conditions in accessing the global variables
6100 case_temp1 and case_temp2.
6101 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6102 * lisp.h (case_temp1, case_temp2): Remove their decls.
6103 * character.h (ASCII_CHAR_P): Move from here ...
6104 * lisp.h: ... to here, so that the inline functions mentioned
6105 above can use them.
6106
4a6bea26
PE
6107 * dired.c (directory_files_internal_unwind): Now static.
6108
f14b7e14
PE
6109 * fileio.c (file_name_as_directory, directory_file_name):
6110 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6111 Now static.
2893f146
PE
6112 (file_name_as_directory): Use const pointers when appropriate.
6113 (Fexpand_file_name): Likewise. In particular, newdir might
6114 point at constant storage, so make it a const pointer.
fd4ead52 6115 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6116 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6117 signedness issues.
f839df0c
PE
6118 (Fset_file_times, Finsert_file_contents, auto_save_error):
6119 Rename locals to avoid shadowing.
f14b7e14 6120
5716756e 6121 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6122 (Ftry_completion, Fall_completions): Rename or remove locals
6123 to avoid shadowing.
5716756e 6124
b4c3046a
PE
6125 * marker.c (bytepos_to_charpos): Remove; unused.
6126
b45db522
PE
6127 * lisp.h (verify_bytepos, count_markers): New decls,
6128 so that gcc does not warn that these functions aren't declared.
6129
85876d07
PE
6130 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6131 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6132 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6133 (copy_text): Remove unused local var.
85876d07 6134
03d78a21 6135 * filelock.c (within_one_second): Now static.
b3dd38ab 6136 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6137
5df8f01b
PE
6138 * buffer.c (fix_overlays_before): Mark locals as initialized.
6139 (fix_start_end_in_overlays): Likewise. This function should be
6140 simplified by using pointers-to-pointers, but that's a different
6141 matter.
b1d876f1 6142 (switch_to_buffer_1): Now static.
8f54f30a
PE
6143 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6144 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6145
a70072c9 6146 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6147 Fix pointer signedness issue.
edced198
PE
6148 (sys_subshell): Mark local as volatile if checking for lint,
6149 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6150 (MAXPATHLEN): Define only if needed.
a70072c9 6151
a0977c44
PE
6152 * process.c (serial_open, serial_configure): Move decls from here ...
6153 * systty.h: ... to here, so that they can be checked.
6154
a884fdcc
PE
6155 * fns.c (get_random, seed_random): Move extern decls from here ...
6156 * lisp.h: ... to here, so that they can be checked.
6157
604efe86 6158 * sysdep.c (reset_io): Now static.
b8950c94 6159 (wait_for_termination_signal): Remove; unused.
604efe86 6160
38fc62d9
PE
6161 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6162 (copy_keymap_item, append_key, push_text_char_description):
6163 Now static.
1004a21a 6164 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6165 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6166 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6167 (describe_map_tree):
6168 Rename locals to avoid shadowing.
38fc62d9 6169
2f2650da
PE
6170 * keyboard.c: Declare functions static if they are not used elsewhere.
6171 (echo_char, echo_dash, cmd_error, top_level_2):
6172 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6173 (read_char, kbd_buffer_get_event, make_lispy_position):
6174 (make_lispy_event, make_lispy_movement, apply_modifiers):
6175 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6176 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6177 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6178 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6179 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6180
a053e86c 6181 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6182 (mark_kboards): Move decl here ...
6183 * alloc.c (mark_kboards): ... from here.
a053e86c 6184
4752793e
PE
6185 * lisp.h (force_auto_save_soon): New decl.
6186
74f10ca7 6187 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6188 (DEFINE_DUMMY_FUNCTION): New macro.
6189 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6190 Use it.
c03cd23f
PE
6191 (main): Add casts to avoid warnings
6192 if GCC considers string literals to be constants.
74f10ca7 6193
022e70d4
PE
6194 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6195
59d6fe83
PE
6196 * dbusbind.c: Pointer signedness fixes.
6197 (xd_signature, xd_append_arg, xd_initialize):
6198 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6199 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6200 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6201 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6202
78320123
PE
6203 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6204 if GCC considers string literals to be constants.
49cebcca 6205 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6206
35ac2a97
SM
62072011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6208
fb103ca9
SM
6209 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6210 (print_preprocess, print_object): New macro to fix last change.
6211
35ac2a97
SM
6212 * print.c (print_preprocess): Don't forget font objects.
6213
62973b41
JB
62142011-03-16 Juanma Barranquero <lekktu@gmail.com>
6215
6216 * emacs.c (USAGE3): Doc fixes.
6217
0e48bb22
AS
62182011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6219
6220 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6221 structure.
6222
7684e57b
JB
62232011-03-14 Juanma Barranquero <lekktu@gmail.com>
6224
6225 * lisp.h (VWindow_system, Qfile_name_history):
6226 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6227 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6228 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6229
6230 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6231 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6232
6233 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6234 * w32console.c (detect_input_pending, read_input_pending)
6235 (encode_terminal_code):
6236 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6237 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6238 (w32_system_caret_y, Qfile_name_history):
6239 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6240 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6241 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6242 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6243 * w32proc.c (Qlocal, report_file_error):
6244 * w32term.c (Vwindow_system, updating_frame):
6245 * w32uniscribe.c (initialized, uniscribe_font_driver):
6246 Remove unneeded extern declarations.
6247
2aa46d6c
CY
62482011-03-14 Chong Yidong <cyd@stupidchicken.com>
6249
c96bbc66 6250 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6251
cffc6f3b
CY
62522011-03-13 Chong Yidong <cyd@stupidchicken.com>
6253
6254 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6255 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6256 These macros can no longer be used for assignment.
6257
44f230aa
SM
6258 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6259 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6260 (record_buffer_markers, fetch_buffer_markers): New functions for
6261 recording and fetching special buffer markers.
6262 (set_buffer_internal_1, set_buffer_temp): Use them.
6263
6264 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6265
6266 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6267
6268 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6269 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6270
6271 * xdisp.c (hscroll_window_tree):
6272 (reconsider_clip_changes): Use PT instead of BUF_PT.
6273
d251f04b
EZ
62742011-03-13 Eli Zaretskii <eliz@gnu.org>
6275
6276 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6277 $(EMACS_ROOT)/lib/intprops.h.
6278
f0c77cd1
PE
62792011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6280
3eca4629
PE
6281 Fix more problems found by GCC 4.5.2's static checks.
6282
7c86ee98
PE
6283 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6284 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6285 (xg_free_frame_widgets): Make it clear that a local variable is
6286 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6287 (gdk_window_get_screen): Make it clear that this macro is needed
6288 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6289 (int_gtk_range_get_value): New function, which avoids a diagnostic
6290 from gcc -Wbad-function-cast.
6291 (xg_set_toolkit_scroll_bar_thumb): Use it.
6292 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6293 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6294 (get_utf8_string, xg_get_file_with_chooser):
6295 Rename locals to avoid shadowing.
6296 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6297
41729b81
PE
6298 * xgselect.c (xg_select): Remove unused var.
6299
f0c77cd1
PE
6300 * image.c (four_corners_best): Mark locals as initialized.
6301 (gif_load): Initialize transparent_p to zero (Bug#8238).
6302 Mark another local as initialized.
ec6cf4c6 6303 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6304
ce0ad53d 6305 * image.c (clear_image_cache): Now static.
d5d5a617 6306 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6307 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6308 (x_edge_detection): Remove unnecessary cast that
6309 gcc -Wbad-function-cast diagnoses.
2037898d 6310 (gif_load): Fix pointer signedness.
6ae141d6
PE
6311 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6312 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6313
33383987 63142011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6315
d32df629
PE
6316 Improve quality of tests for time stamp overflow.
6317 For example, without this patch (encode-time 0 0 0 1 1
6318 1152921504606846976) returns the obviously-bogus value (-948597
6319 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6320 reports time overflow. See
6321 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6322 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6323 * editfns.c: Include limits.h and intprops.h.
6324 (TIME_T_MIN, TIME_T_MAX): New macros.
6325 (time_overflow): Move earlier, to before first use.
6326 (hi_time, lo_time): New functions, for an accurate test for
6327 out-of-range times.
6328 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6329 (Fget_internal_run_time): Don't assume time_t fits in int.
6330 (make_time): Use list2 instead of Fcons twice.
6331 (Fdecode_time): More accurate test for out-of-range times.
6332 (check_tm_member): New function.
6333 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6334 (lisp_time_argument): Don't rely on undefined left-shift and
6335 right-shift behavior when checking for time stamp overflow.
8be6f318 6336
fe31d94c
PE
6337 * editfns.c (time_overflow): New function, refactoring common code.
6338 (Fformat_time_string, Fdecode_time, Fencode_time):
6339 (Fcurrent_time_string): Use it.
6340
8be6f318
PE
6341 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6342 * dired.c (make_time): Move to ...
6343 * editfns.c (make_time): ... here.
6344 * systime.h: Note the move.
6345
09d9db2c 63462011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6347
126bc0dc
YM
6348 * fringe.c (update_window_fringes): Remove unused variables.
6349
c47cbdfd
YM
6350 * unexmacosx.c (copy_data_segment): Also copy __got section.
6351 (Bug#8223)
6352
7ac80be9
EZ
63532011-03-12 Eli Zaretskii <eliz@gnu.org>
6354
c96bbc66 6355 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6356 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6357 Constify `char *' arguments and their references according to
6358 prototypes in tparam.h.
6359
ecb0f94d 6360 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6361
7ac80be9
EZ
6362 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6363 Adapt all references accordingly.
6364
6365 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6366
ef1fd07e
TT
63672011-03-11 Tom Tromey <tromey@redhat.com>
6368
6369 * buffer.c (syms_of_buffer): Remove obsolete comment.
6370
7ef4b50c
EZ
63712011-03-11 Eli Zaretskii <eliz@gnu.org>
6372
6373 * termhooks.h (encode_terminal_code): Declare prototype.
6374
6375 * msdos.c (encode_terminal_code): Don't declare prototype.
6376
6377 * term.c (encode_terminal_code): Now external again, used by
6378 w32console.c and msdos.c.
6379
44f230aa
SM
6380 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6381 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6382
4b1ec863 63832011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6384
1714f52b 6385 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6386
4b1ec863
PE
6387 * fringe.c (update_window_fringes): Mark locals as initialized
6388 (Bug#8227).
6389 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6390
524c7aa6
PE
6391 * alloc.c (mark_fringe_data): Move decl from here ...
6392 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6393 to check its interface.
6394 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6395
a5c0af81 6396 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6397 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6398 (fontset_font): Mark local as initialized.
a9a06e0b 6399 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6400
b4716021
PE
6401 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6402
811e9bac 6403 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6404 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6405 (x_own_selection, Fx_disown_selection_internal): Rename locals
6406 to avoid shadowing.
6407 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6408
7e3ab302
PE
6409 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6410 so that the caller can use some name other than gcpro1.
6411 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6412 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6413 (Fx_backspace_delete_keys_p):
6414 Use them to avoid shadowing, and rename vars to avoid shadowing.
6415 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6416 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6417 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6418 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6419 Remove unused locals.
7e3ab302
PE
6420 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6421 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6422 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6423 macros.
f78faa98 6424
e2b13473
PE
6425 * xterm.h (x_mouse_leave): New decl.
6426
77f23912
PE
6427 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6428 Remove unused functions.
cdf4ba58
PE
6429 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6430 (x_calc_absolute_position): Now static.
7411c686 6431 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6432 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6433 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6434 unless they are used.
38d0b34a
PE
6435 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6436 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6437 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6438 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6439 (x_error_catcher, x_connection_closed, x_error_handler):
6440 (x_error_quitter, xembed_send_message, x_iconify_frame):
6441 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6442 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6443 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6444
44f230aa
SM
6445 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6446 Rename or move locals to avoid shadowing.
6b463e58 6447 (tty_defined_color, merge_face_heights): Now static.
5967d051 6448 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6449 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6450 does not deduce is never used uninitialized.
73719eba
PE
6451 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6452 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6453
426994c3 6454 * terminal.c (store_terminal_param): Now static.
5489860b 6455
032f1620 6456 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6457 (set_frame_menubar): Remove unused local.
d4323972 6458 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6459 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6460 since they might point to immutable storage.
281585b0
PE
6461 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6462 since it's unused otherwise.
032f1620 6463
367c19e5 6464 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6465 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6466 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6467 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6468 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6469 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6470 does not deduce are never used uninitialized.
70739cbe 6471
07b48fa9
PE
6472 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6473
8868a238 6474 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6475 * window.c (window_loop, size_window):
6476 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6477
7e5cf297 6478 * window.c (display_buffer): Now static.
d6550a9f
PE
6479 (size_window): Mark variables that gcc -Wuninitialized
6480 does not deduce are never used uninitialized.
a586633d
PE
6481 * window.h (check_all_windows): New decl, to forestall
6482 gcc -Wmissing-prototypes diagnostic.
5b555da1 6483 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6484
f6095868
PE
6485 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6486 shadowing.
6487 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6488 Include <limits.h>.
6489 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6490 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6491 (load_charset_map): Mark variables that gcc -Wuninitialized
6492 does not deduce are never used uninitialized.
53df7c11 6493 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6494
f38b440c
PE
6495 * coding.c (coding_set_source, coding_set_destination):
6496 Use "else { /* comment */ }" rather than "else /* comment */;"
6497 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6498 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6499 a block, when the outer 'i' will do.
6500 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6501 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6502 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6503 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6504 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6505 Rename locals to avoid shadowing.
6506 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6507 * coding.c (emacs_mule_char, encode_invocation_designation):
6508 Now static, since they're not used elsewhere.
413bb2db 6509 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6510 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6511 (decode_coding_emacs_mule): Mark variables that gcc
6512 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6513 (detect_coding_iso_2022): Initialize a local variable that might
6514 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6515 this initialization is needed. (Bug#8211)
5f58e762
PE
6516 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6517 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6518 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6519 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6520 Remove unused macros.
f38b440c 6521
232b38b9 6522 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6523 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6524 * character.c (string_count_byte8): Likewise.
232b38b9 6525
fb90da1b
PE
6526 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6527 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6528
fb93dbc2
PE
6529 * chartab.c (copy_sub_char_table): Now static, since it's not used
6530 elsewhere.
5c156ace
PE
6531 (sub_char_table_ref_and_range, char_table_ref_and_range):
6532 Rename locals to avoid shadowing.
bbcd0949 6533 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6534
7d3b3862 6535 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6536 (BIDI_BOB): Remove unused macro.
7d3b3862 6537
6be7d3da
PE
6538 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6539 deduce are never used uninitialized.
c2ed9c8b 6540 * term.c (encode_terminal_code): Likewise.
6be7d3da 6541
75f8807f 6542 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6543
50938595
PE
6544 * tparam.h: New file.
6545 * term.c, tparam.h: Include it.
6546 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6547 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6548 Move these decls to tparam.h, and make them agree with what
6549 is actually in tparam.c. The previous trick of using incompatible
6550 decls in different modules does not conform to the C standard.
6551 All callers of tparam changed to use tparam's actual API.
6552 * tparam.c (tparam1, tparam, tgoto):
6553 Use const pointers where appropriate.
6554
fbceeba2
PE
6555 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6556 * cm.h (struct cm): Likewise.
6557 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6558 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6559 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6560 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6561 (turn_on_face, init_tty): Likewise.
6562 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6563
7f3f1250
PE
6564 * term.c (term_mouse_position): Rename local to avoid shadowing.
6565
e6ca6543
PE
6566 * alloc.c (mark_ttys): Move decl from here ...
6567 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6568
c40f8d15
AS
65692011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6570
6571 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6572
cfe0661d
JB
65732011-03-09 Juanma Barranquero <lekktu@gmail.com>
6574
6575 * search.c (compile_pattern_1): Remove argument regp, unused since
6576 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6577 (compile_pattern): Don't pass it.
6578
0afb4571
J
65792011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6580
6581 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6582 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6583 for ! HAVE_GTK3.
6584 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6585
6586 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6587
6588 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6589 gdk_window_get_screen, gdk_window_get_geometry,
6590 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6591 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6592 (xg_get_pixbuf_from_pixmap): New function.
6593 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6594 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6595 Call xg_get_pixbuf_from_pixmap instead of
6596 gdk_pixbuf_get_from_drawable.
6597 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6598 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6599 (xg_check_special_colors): Use GtkStyleContext and its functions
6600 for HAVE_GTK3.
6601 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6602 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6603 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6604 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6605 Call gtk_widget_get_preferred_size.
0afb4571
J
6606 (xg_frame_resized): gdk_window_get_geometry only takes 5
6607 parameters.
44f230aa
SM
6608 (xg_win_to_widget, xg_event_is_for_menubar):
6609 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6610 (xg_set_widget_bg): New function.
6611 (delete_cb): New function.
895009e1 6612 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6613 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6614 (xg_set_background_color): Call xg_set_widget_bg.
6615 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6616 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6617 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6618 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6619 if ! HAVE_GTK3.
6620 (update_frame_tool_bar): Call gtk_widget_hide.
6621 (xg_initialize): Use GDK_KEY_g.
6622
6623 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6624 if ! HAVE_GTK3
6625 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6626
6627 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6628 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6629 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6630
1c2cc4ef
JB
66312011-03-08 Juanma Barranquero <lekktu@gmail.com>
6632
6633 * w32xfns.c (select_palette): Check success of RealizePalette against
6634 GDI_ERROR, not zero.
6635
33383987 6636See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6637
6638;; Local Variables:
6639;; coding: utf-8
aac0c6e3
MR
6640;; End:
6641
33383987 6642 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6643
6644 This file is part of GNU Emacs.
6645
6646 GNU Emacs is free software: you can redistribute it and/or modify
6647 it under the terms of the GNU General Public License as published by
6648 the Free Software Foundation, either version 3 of the License, or
6649 (at your option) any later version.
6650
6651 GNU Emacs is distributed in the hope that it will be useful,
6652 but WITHOUT ANY WARRANTY; without even the implied warranty of
6653 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6654 GNU General Public License for more details.
6655
6656 You should have received a copy of the GNU General Public License
6657 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.