* mail/smtpmail.el (smtpmail-send-command): Send the command and
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0d887c7d
EZ
12012-05-05 Eli Zaretskii <eliz@gnu.org>
2
3 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4 stack for each reader_thread, instead of defaulting to 8MB
5 determined by the linker. This avoids failures in creating
6 subprocesses on Windows 7, see the discussion in this thread:
7 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
8
bf98199c
JM
92012-05-02 Jim Meyering <meyering@redhat.com>
10
11 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
12
2fa85638
EZ
132012-04-29 Eli Zaretskii <eliz@gnu.org>
14
15 * xdisp.c (pos_visible_p): If already at a newline from the
16 display string before the 'while' loop, don't walk back the glyphs
17 from it3.glyph_row. Solves assertion violation when the display
18 string begins with a newline (egg.el). (Bug#11367)
19
9be2fd9b
CY
202012-04-24 Chong Yidong <cyd@gnu.org>
21
22 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
23
f0ee99a0
EZ
242012-04-23 Eli Zaretskii <eliz@gnu.org>
25
26 * xdisp.c (pos_visible_p): If the window start position is beyond
27 ZV, start the display from buffer beginning. Prevents assertion
28 violation in init_iterator when the minibuffer window is scrolled
29 via the scroll bar.
30
31 * window.c (window_scroll_pixel_based): Likewise.
32
9ec7751f
CY
332012-04-23 Chong Yidong <cyd@gnu.org>
34
35 * keymap.c (where_is_internal): Doc fix (Bug#10872).
36
24c51a09
GM
372012-04-20 Glenn Morris <rgm@gnu.org>
38
39 * fileio.c (Fcopy_file, Fset_file_selinux_context):
40 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
41
73055685
EZ
422012-04-20 Eli Zaretskii <eliz@gnu.org>
43
44 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
45 overrun array limits of glyph row's used[] array. (Bug#11288)
46
f30d612a
CY
472012-04-20 Chong Yidong <cyd@gnu.org>
48
49 * process.c (wait_reading_process_output): If EIO occurs on a pty,
50 set the status to "failed" and ensure that sentinel is run.
51
016a35df
GM
522012-04-18 Glenn Morris <rgm@gnu.org>
53
54 * process.c (Fset_process_inherit_coding_system_flag)
55 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 56 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 57
20a68157
EZ
582012-04-17 Eli Zaretskii <eliz@gnu.org>
59
60 * xdisp.c (string_buffer_position_lim): Limit starting position to
61 BEGV.
62 (set_cursor_from_row): If called for a mode-line or header-line
63 row, return zero immediately.
64 (try_cursor_movement): If inside continuation line, don't back up
65 farther than the first row after the header line, if any. Don't
66 consider the header-line row as "partially visible", even if
67 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
68
ad3a2b41
AO
692012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
70
71 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
72
e63c261b
CY
732012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
74
75 * process.c (make_process):
76 * process.h: Add integer `gnutls_handshakes_tried' member to
77 process struct.
78
ad3a2b41
AO
79 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
80 Add convenience `GNUTLS_LOG2i' macro.
e63c261b
CY
81
82 * gnutls.c (gnutls_log_function2i): Convenience log function.
83 (emacs_gnutls_read): Use new log functions,
84 `gnutls_handshakes_tried' process member, and
85 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
86 attempts per process (connection).
87
e53357c4
EZ
882012-04-09 Eli Zaretskii <eliz@gnu.org>
89
90 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
91 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
92
aff67c82
JD
932012-04-09 Jan Djärv <jan.h.d@swipnet.se>
94
95 * nsterm.m (constrainFrameRect): Always constrain when there is only
96 one screen (Bug#10962).
97
2f8e16b2
EZ
982012-04-06 Eli Zaretskii <eliz@gnu.org>
99
100 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
101 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
102 about subtle differences between FETCH_CHAR* and STRING_CHAR*
103 macros related to unification of CJK characters. For the details,
104 see the discussion following the message here:
105 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
106
3d439cd1
CY
1072012-04-04 Chong Yidong <cyd@gnu.org>
108
109 * keyboard.c (Vdelayed_warnings_list): Doc fix.
110
8bc53d00
EZ
1112012-04-01 Eli Zaretskii <eliz@gnu.org>
112
113 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
114 instead of alloca. (Bug#11138)
115
3b0512a3
AS
1162012-04-01 Andreas Schwab <schwab@linux-m68k.org>
117
118 * w32menu.c (is_simple_dialog): Properly check lisp types.
119 (Bug#11141)
120
8427ddd2
EZ
1212012-03-31 Eli Zaretskii <eliz@gnu.org>
122
979022ef
EZ
123 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
124 position we get to after a call to move_it_to fails the
125 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
126 only if we wind up in a string from display property. (Bug#11063)
127
a6b1c7cc
EZ
128 * window.c (Fdelete_other_windows_internal): Invalidate the row
129 and column information about mouse highlight, so that redisplay
130 restores it after reallocating the glyph matrices. (Bug#7464)
131
8427ddd2
EZ
132 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
133 string comes from a `display' text property, use the buffer
134 position of that property as if we actually saw that position in
135 the row's glyphs.
697ba24b
EZ
136 (move_it_by_lines): Remove the assertion that
137 "it->current_x == 0 && it->hpos == 0" which can be legitimately
138 violated when there's a before-string at the beginning of a line.
139 (Bug#11063)
8427ddd2 140
65a0a738
EZ
1412012-03-30 Eli Zaretskii <eliz@gnu.org>
142
143 * xdisp.c (append_space_for_newline): If the default face was
144 remapped, use the remapped face for the appended newline.
145 (extend_face_to_end_of_line): Use the remapped default face for
146 extending the face to the end of the line.
147 (display_line): Call extend_face_to_end_of_line when the default
148 face was remapped. (Bug#11068)
149
581355cc
EZ
1502012-03-29 Eli Zaretskii <eliz@gnu.org>
151
152 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
153
e8fc049f
SM
1542012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
155
156 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
157
4fb9a543
GM
1582012-03-27 Glenn Morris <rgm@gnu.org>
159
160 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
161 Doc fixes.
162
679910f1
KH
1632012-03-26 Kenichi Handa <handa@m17n.org>
164
165 * dispextern.h (struct glyph): Fix previous change. Change the
166 bit length of glyphless.ch to 25 (Bug#11082).
167
90d49b7f
CY
1682012-03-26 Chong Yidong <cyd@gnu.org>
169
170 * keyboard.c (Vselection_inhibit_update_commands): New variable.
171 (command_loop_1): Use it; inhibit selection update for
172 handle-select-window too (Bug#8996).
173
f514f6f0
FP
1742012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
175
e8fc049f 176 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 177
bf43fa51
KH
1782012-03-25 Kenichi Handa <handa@m17n.org>
179
180 * dispextern.h (struct glyph): Change the bit length of
181 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
182
8a0c01dd
EZ
1832012-03-24 Eli Zaretskii <eliz@gnu.org>
184
185 * s/ms-w32.h (tzname): Include time.h before redirecting to
186 _tzname. Fixes the MSVC build. (Bug#9960)
187
7d1c3a76
AS
1882012-03-24 Andreas Schwab <schwab@linux-m68k.org>
189
8ed79523
AS
190 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
191 characters.
192
7d1c3a76
AS
193 * xterm.c (XTread_socket): Only modify handling_signal if
194 !SYNC_INPUT. (Bug#11080)
195
e99a9b8b
EZ
1962012-03-23 Eli Zaretskii <eliz@gnu.org>
197
198 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
199 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
200 when fetching a multibyte character consumes more bytes than
201 CHAR_BYTES returns, due to unification of CJK characters in
202 string_char. (Bug#11073)
203
5063c0e1
TN
2042012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
205
206 * process.c (wait_reading_process_output): Handle pty disconnect
207 by refraining from sending oneself a SIGCHLD (bug#10933).
208
9f851fbd
CY
2092012-03-22 Chong Yidong <cyd@gnu.org>
210
211 * dispextern.h (struct it): New member string_from_prefix_prop_p.
212
5063c0e1 213 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
214 Mark string as coming from a prefix property.
215 (handle_face_prop): Use default face for prefix strings (Bug#4281).
216 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
217
fb5b8aca
CY
2182012-03-21 Chong Yidong <cyd@gnu.org>
219
220 * xfaces.c (Vface_remapping_alist): Doc fix.
221
62356a1b
EZ
2222012-03-20 Eli Zaretskii <eliz@gnu.org>
223
224 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
225 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
226 Doc fixes.
62356a1b 227
025de85b
CY
2282012-03-20 Chong Yidong <cyd@gnu.org>
229
230 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
231 to reflect default non-nil value of redisplay-dont-pause.
232
4827f94e
KH
2332012-03-19 Kenichi Handa <handa@m17n.org>
234
235 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
236 it fit in a valid range (Bug#11003).
237
e50a24a2
EZ
2382012-03-18 Eli Zaretskii <eliz@gnu.org>
239
240 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
241 that is not from display property, accept the row as a "cursor
242 row" if one of the string's character has a non-nil `cursor'
243 property. Fixes cursor positioning when there are newlines in
244 overlay strings, e.g. in icomplete.el. (Bug#11035)
245
9af5ed87
PE
2462012-03-12 Paul Eggert <eggert@cs.ucla.edu>
247
248 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
249
d1f55f16
CY
2502012-03-12 Chong Yidong <cyd@gnu.org>
251
252 * eval.c (inhibit_lisp_code): Rename from
253 inhibit_window_configuration_change_hook; move from window.c.
254
255 * xfns.c (unwind_create_frame_1, Fx_create_frame):
256 * window.c (run_window_configuration_change_hook)
257 (syms_of_window): Callers changed.
258
66c5eebd
CY
2592012-03-11 Chong Yidong <cyd@gnu.org>
260
413df973
CY
261 * keymap.c (Fkey_description): Doc fix (Bug#9700).
262
66c5eebd
CY
263 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
264
1de11f56
CY
2652012-03-10 Chong Yidong <cyd@gnu.org>
266
267 * frame.c (other_visible_frames): Don't assume the selected frame
268 is visible (Bug#10955).
269
cae07000
SM
2702012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
271
272 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
273
89c94350
JD
2742012-03-08 Jan Djärv <jan.h.d@swipnet.se>
275
276 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
277 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
278 zero (Bug#10954).
279
999dd333
GM
2802012-03-03 Glenn Morris <rgm@gnu.org>
281
01a6dcc8 282 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 283
de0100f2
EZ
2842012-03-02 Eli Zaretskii <eliz@gnu.org>
285
286 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
287 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
288 (redisplay_window, next_element_from_string): Fix typos in
289 comments.
3e441275
EZ
290 (redisplay_window): Pass to move_it_vertically the margin in
291 pixels, not in screen lines.
de0100f2 292
96a72ee9
GM
2932012-03-02 Glenn Morris <rgm@gnu.org>
294
295 * buffer.c (buffer-list-update-hook): Doc fix.
296
312508d7
EZ
2972012-02-29 Eli Zaretskii <eliz@gnu.org>
298
299 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
300 push_it before setting up the iterator for the first overlay
301 string, even if we have an empty string loaded.
302 (next_overlay_string): If there's an empty string on the iterator
303 stack, pop the stack. (Bug#10903)
304
27f3c637
PE
3052012-02-25 Paul Eggert <eggert@cs.ucla.edu>
306
307 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
308 Suggested by Stefan Monnier in
309 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
310 * alloc.c (widen_to_Lisp_Object): New static function.
311 (mark_memory): Also mark Lisp_Objects by fetching pointer words
312 and widening them to Lisp_Objects. This would work even if
313 USE_LSB_TAG is defined and wide integers are used, which might
314 happen in a future version of Emacs.
315
3c9dfce6
CY
3162012-02-25 Chong Yidong <cyd@gnu.org>
317
fa74b241
CY
318 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
319 Doc fix.
320
3c9dfce6
CY
321 * xselect.c (Fx_selection_exists_p): Doc fix.
322 (x_clipboard_manager_save_all): Print an informative message
323 before saving to clipboard manager.
324
9486df08
CY
3252012-02-24 Chong Yidong <cyd@gnu.org>
326
327 * keyboard.c (process_special_events): Handle all X selection
328 requests in kbd_buffer, not just the next one (Bug#8869).
329
f01d3321
CY
3302012-02-23 Chong Yidong <cyd@gnu.org>
331
332 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
333 call when setting menu-bar-lines and tool-bar-lines parameters.
334 (unwind_create_frame_1): New helper function.
335
336 * window.c (inhibit_window_configuration_change_hook): New var.
337 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 338 (syms_of_window): Initialize it.
f01d3321 339
86b847b6
CY
3402012-02-22 Chong Yidong <cyd@gnu.org>
341
342 * xterm.c (x_draw_image_relief): Add missing type check for
343 Vtool_bar_button_margin (Bug#10743).
344
a59225b1
CY
3452012-02-21 Chong Yidong <cyd@gnu.org>
346
347 * fileio.c (Vfile_name_handler_alist): Doc fix.
348
349 * buffer.c (Fget_file_buffer): Protect against invalid file
350 handler return value.
351
310f5bd4
PE
3522012-02-20 Paul Eggert <eggert@cs.ucla.edu>
353
cb3a28cc
PE
354 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
355 when computing $valmask.
356
310f5bd4
PE
357 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
358 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
359 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
360 It's useless in that case, and it can cause problems on hosts
361 that allocate halves of EMACS_INT values separately.
362 Reported by Dan Horák. Diagnosed by Andreas Schwab in
363 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
364 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
365 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
366 it avoids undefined behavior on hosts where shifting right by more
367 than the word width has undefined behavior.
368
2375c96a
CY
3692012-02-19 Chong Yidong <cyd@gnu.org>
370
371 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
372 (Funhandled_file_name_directory, Ffile_name_as_directory)
373 (Fdirectory_file_name, Fexpand_file_name)
374 (Fsubstitute_in_file_name): Protect against invalid file handler
375 return values (Bug#10845).
376
3eb49e71
EZ
3772012-02-18 Eli Zaretskii <eliz@gnu.org>
378
379 * .gdbinit (pitx): Fix incorrect references to fields of the
380 iterator stack.
381
7b926f3f
CY
3822012-02-17 Chong Yidong <cyd@gnu.org>
383
384 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
385
11273115
PE
3862012-02-15 Paul Eggert <eggert@cs.ucla.edu>
387
388 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
389 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
390
c3a70e2b
CY
3912012-02-15 Chong Yidong <cyd@gnu.org>
392
393 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
394 marked as special. Also, starting docstrings with * is obsolete.
395
0ca43699
AS
3962012-02-13 Andreas Schwab <schwab@linux-m68k.org>
397
398 * gnutls.c (emacs_gnutls_write): Fix last change.
399
2e8f3c56
LI
4002012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
401
402 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
403 send_process.
404
af70074f
SM
4052012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
406
407 * keymap.c (Fsingle_key_description): Handle char ranges.
408
95986d52
CY
4092012-02-12 Chong Yidong <cyd@gnu.org>
410
afd83bd1
CY
411 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
412 as that creates a dangerous corner case.
413
95986d52
CY
414 * window.c (Fdelete_window_internal): Invalidate the mouse
415 highlight (Bug#9904).
416
bd7da63e
GM
4172012-02-12 Glenn Morris <rgm@gnu.org>
418
419 * xselect.c (Fx_own_selection_internal)
420 (Fx_get_selection_internal, Fx_disown_selection_internal)
421 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
422 * nsselect.m (Fx_own_selection_internal)
423 (Fx_disown_selection_internal, Fx_selection_exists_p)
424 (Fx_selection_owner_p, Fx_get_selection_internal):
425 Sync docs and argument specs with the xselect.c versions.
426
77abcbc2
LI
4272012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
428
429 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
430
90b671e2
EZ
4312012-02-11 Eli Zaretskii <eliz@gnu.org>
432
1c0ca0b7
EZ
433 * w32select.c (Fx_selection_exists_p): Sync doc string and
434 argument list with xselect.c. (Bug#10783)
435
436 * w16select.c (Fx_selection_exists_p): Sync doc string and
437 argument list with xselect.c. (Bug#10783)
90b671e2 438
49241268
GM
4392012-02-10 Glenn Morris <rgm@gnu.org>
440
441 * fns.c (Fsecure_hash): Doc fix.
442
f998bbe7 4432012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
444
445 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
446
0992bd9c
CY
4472012-02-07 Chong Yidong <cyd@gnu.org>
448
449 * buffer.c (Fbuffer_local_variables)
450 (buffer_lisp_local_variables): Handle unbound vars correctly;
451 don't let Qunbound leak into Lisp.
452
af008560
GM
4532012-02-07 Glenn Morris <rgm@gnu.org>
454
dd605cc4
GM
455 * image.c (Fimagemagick_types): Doc fix.
456
af008560
GM
457 * image.c (imagemagick-render-type): Change it from a lisp object
458 to an integer. Move the doc here from the lisp manual.
459 Treat all values not equal to 0 the same.
460
1449fa1d
CY
4612012-02-06 Chong Yidong <cyd@gnu.org>
462
463 * doc.c (store_function_docstring): Avoid applying docstring of
464 alias to base function (Bug#2603).
465
3723ec07
AS
4662012-02-04 Andreas Schwab <schwab@linux-m68k.org>
467
468 * .gdbinit (pp1, pv1): Remove redundant defines.
469 (pr): Use pp.
470
79c1cc1e
CY
4712012-02-04 Chong Yidong <cyd@gnu.org>
472
473 * nsterm.m: Declare a global (Bug#10694).
474
d7f29f8e
EZ
4752012-02-04 Eli Zaretskii <eliz@gnu.org>
476
cae07000
SM
477 * w32.c (get_emacs_configuration_options):
478 Include --enable-checking, if specified, in the return value.
d7f29f8e 479
3b95a6f9
MR
4802012-02-04 Martin Rudalics <rudalics@gmx.at>
481
482 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
483 after rounding frame sizes. (Bug#9723)
484
d6fa96a6
EZ
4852012-02-04 Eli Zaretskii <eliz@gnu.org>
486
487 * keyboard.c (adjust_point_for_property): Don't position point
488 before BEGV. (Bug#10696)
489
df0b2940
PE
4902012-02-03 Paul Eggert <eggert@cs.ucla.edu>
491
492 Handle overflow when computing char display width (Bug#9496).
493 * character.c (char_width): Return EMACS_INT, not int.
494 (char_width, c_string_width): Check for overflow when
495 computing the width; this is possible now that individual
496 characters can have unbounded width. Problem introduced
497 by merge from Emacs 23 on 2012-01-19.
498
6bee44d6
MA
4992012-02-02 Michael Albinus <michael.albinus@gmx.de>
500
501 * dbusbind.c (Fdbus_register_method): Mention the return value
502 :ignore in the docstring.
503
44f92739
GM
5042012-02-02 Glenn Morris <rgm@gnu.org>
505
1b9f60cc
GM
506 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
507
44f92739
GM
508 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
509 Unconditionally set to t. (Bug#10673)
510 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
511 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
512 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
513
c5d3843c
KH
5142012-02-02 Kenichi Handa <handa@m17n.org>
515
516 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
517 0, do not call append_composite_glyph.
518
159462d4 5192012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
520
521 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
522 NULL (Bug#6988).
523 (x_produce_glyphs): If the component of a composition is a null
524 string, set it->pixel_width to 1 to avoid zero-width glyph.
525
78cef877
EZ
5262012-02-01 Eli Zaretskii <eliz@gnu.org>
527
528 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
529 first 2 arguments are identical. This makes inserting large
530 output from a subprocess an order of magnitude faster on
531 MS-Windows, where all sbrk'ed memory is always contiguous.
532
97897668
GM
5332012-01-31 Glenn Morris <rgm@gnu.org>
534
535 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 536 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
537 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
538
31fd3586
GM
5392012-01-29 Glenn Morris <rgm@gnu.org>
540
541 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
542
0e24a8b2
CY
5432012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
544
545 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
546
cc0adcb0
CY
5472012-01-28 Chong Yidong <cyd@gnu.org>
548
549 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
550
acc28cb9
CY
5512012-01-26 Chong Yidong <cyd@gnu.org>
552
9c69cfb7
CY
553 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
554
acc28cb9
CY
555 * search.c (Fsearch_forward, Fsearch_backward): Document negative
556 repeat counts (Bug#10507).
557
48da7392
GM
5582012-01-26 Glenn Morris <rgm@gnu.org>
559
560 * lread.c (syms_of_lread): Doc fix.
561
14af5f7f
CY
5622012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
563
564 * coding.c (encode_designation_at_bol): Change return value to
565 EMACS_INT.
566
0b21c100
CY
5672012-01-25 Chong Yidong <cyd@gnu.org>
568
569 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
570
3c2907f7
CY
5712012-01-21 Chong Yidong <cyd@gnu.org>
572
573 * floatfns.c (Fcopysign): Make the second argument non-optional,
574 since nil is not allowed anyway.
575
959ad23f
AS
5762012-01-21 Andreas Schwab <schwab@linux-m68k.org>
577
578 * process.c (read_process_output): Use p instead of XPROCESS (proc).
579 (send_process): Likewise.
580
34a02f46
MR
5812012-01-19 Martin Rudalics <rudalics@gmx.at>
582
583 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
584 (Vwindow_persistent_parameters): Do not use Qstate.
585 Rewrite doc-strings.
34a02f46 586
1259009a 5872012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
588
589 * character.c (char_width): New function.
70d4fdf6
GM
590 (Fchar_width, c_string_width, lisp_string_width):
591 Use char_width (Bug#9496).
25ed9e61 592
6a6ee00d
MR
5932012-01-16 Martin Rudalics <rudalics@gmx.at>
594
595 * window.c (Vwindow_persistent_parameters): New variable.
596 (Fset_window_configuration, save_window_save): Handle persistent
597 window parameters.
598
c85efaf7
EZ
5992012-01-14 Eli Zaretskii <eliz@gnu.org>
600
601 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
602 thrashing the stack of the thread. (Bug#9087)
603
5944709e
PE
6042012-01-12 Paul Eggert <eggert@cs.ucla.edu>
605
606 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
607
e71f5d99
EZ
6082012-01-11 Eli Zaretskii <eliz@gnu.org>
609
610 * xdisp.c (rows_from_pos_range): Handle the case where the
611 highlight ends on a newline. (Bug#10464)
612 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
613 he end column for display of highlight that ends on a newline
614 before a R2L line.
615
ce316182
GM
6162012-01-11 Glenn Morris <rgm@gnu.org>
617
618 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
619 from load-path also when installation-directory is nil. (Bug#10208)
620
5b43da69
GM
6212012-01-10 Glenn Morris <rgm@gnu.org>
622
74cc8ff9
GM
623 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
624
7d8d6e4e
GM
625 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
626 Update template values to be closer to their typical values these days.
5b43da69 627
a0db8d43
EZ
6282012-01-09 Eli Zaretskii <eliz@gnu.org>
629
630 * xdisp.c (rows_from_pos_range): Accept additional argument
631 DISP_STRING, and accept any glyph in a row whose object is that
632 string as eligible for mouse highlight. Fixes mouse highlight of
633 display strings from overlays. (Bug#10464)
634
9a0115ab 6352012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 636
b9110d6a 637 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
638 * fileio.c (auto_saving_dir_umask): New static var.
639 (Fmake_directory_internal): Use it.
640 (do_auto_save_make_dir): Set it, instead of invoking chmod after
641 creating the directory. The old code temporarily assigns
642 too-generous permissions to the directory.
643 (do_auto_save_eh): Clear it.
b9110d6a 644 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
645 that the var is always cleared.
646
6c1bd3f3
EZ
6472012-01-07 Eli Zaretskii <eliz@gnu.org>
648
649 * search.c (scan_buffer): Pass character positions to
650 know_region_cache, not byte positions. (Bug#6540)
651
069d2b50
L
6522012-01-07 LynX <_LynX@bk.ru> (tiny change)
653
654 * w32.c (sys_rename): Report EXDEV when rename of a directory
655 fails because the target is on another logical disk. (Bug#10284)
656
75bf0d33
DB
6572012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
658
659 * xterm.c (x_embed_request_focus): New function.
660
661 * xterm.h: Add prototype.
662
663 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
664
1c6e5a32
GM
6652012-01-05 Glenn Morris <rgm@gnu.org>
666
667 * emacs.c (emacs_copyright): Update short copyright year to 2012.
668
651e947e
EZ
6692012-01-01 Eli Zaretskii <eliz@gnu.org>
670
671 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
672 Load gnutls_transport_set_lowat only if GnuTLS version is below
673 2.11.1.
674 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
675 GnuTLS versions below 2.11.1.
676
3778cdd8
AL
6772011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
678
679 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
680 to the doc string advising against its use for altering the way
681 windows are scrolled.
682
0e5317f7
KH
6832011-12-28 Kenichi Handa <handa@m17n.org>
684
685 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
686 coding-system ASCII compatible only when it does not produce BOM
687 on encoding (Bug#10383).
688
93d5ca1f
JD
6892011-12-26 Jan Djärv <jan.h.d@swipnet.se>
690
691 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
692 can scroll.
693 (create_and_show_popup_menu): Always use menu_position_func for
694 Gtk3 (Bug#10361).
695
ca22b785
AS
6962011-12-24 Andreas Schwab <schwab@linux-m68k.org>
697
698 * callint.c (Fcall_interactively): Don't truncate prompt string.
699
d048e1e6
EZ
7002011-12-23 Eli Zaretskii <eliz@gnu.org>
701
702 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
703 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 704 resumed from there (after widening). (Bug#10360)
d048e1e6 705
5ccaba1f
JD
7062011-12-22 Jan Djärv <jan.h.d@swipnet.se>
707
708 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
709
204ee57f
JD
7102011-12-21 Jan Djärv <jan.h.d@swipnet.se>
711
b81d40f0
JB
712 * nsterm.m (x_free_frame_resources):
713 Release f->output_data.ns->miniimage.
204ee57f
JD
714 (ns_index_color): Fix indentation. Do not retain
715 color_table->colors[i].
716
717 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
718 before returning.
719
720 * nsfns.m (x_set_background_color): Assign return value from
721 ns_index_color to face-background instead of NSColor*.
722 (ns_implicitly_set_icon_type): Fix indentation.
723 Change assignment in for loop to comparison.
724
725 * emacs.c (ns_pool): New variable.
726 (main): Assign ns_pool.
727 (Fkill_emacs): Call ns_release_autorelease_pool.
728
729 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
730 autorelease fdesc, release fdAttrs and tdict.
731 (ns_get_covering_families): Release charset.
732 (ns_findfonts): Release NSFontDescriptor created with new.
733 (ns_uni_to_glyphs): Fix indentation.
734 (setString): Release attrStr before assigning new value.
735
c803b2b7
JD
7362011-12-18 Jan Djärv <jan.h.d@swipnet.se>
737
678f4426
JD
738 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
739 and NS_IMPL_COCOA.
740 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
741 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
742
cd394be1 7432011-12-18 David Reitter <reitter@cmu.edu>
678f4426 744
5fecd5fc
JD
745 * nsterm.m (ns_term_init): Subscribe for notifications
746 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
747 to method trackingNotification in EmacsMenu.
748
749 * nsmenu.m (trackingMenu): New variable.
3771cb17 750 (trackingNotification): New method (from Aquamacs).
5fecd5fc 751 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 752 from Aquamacs (Bug#7030).
678f4426
JD
753
7542011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 755
c803b2b7
JD
756 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
757 (symbol_to_nsstring): Fix indentation.
758 (ns_symbol_to_pb): New function.
cae07000
SM
759 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
760 (Fns_rotate_cut_buffers_internal): Remove.
761 (Fns_store_selection_internal): Rename from
c803b2b7
JD
762 Fns_store_cut_buffer_internal.
763 (ns_get_foreign_selection, Fx_own_selection_internal)
764 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
765 (Fns_get_selection_internal, Fns_store_selection_internal):
766 Use ns_symbol_to_pb and check if return value is nil.
767 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
768 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
769 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
770 renamed to Sns_store_selection_internal.
771 (ns_handle_selection_request): Move code to Fx_own_selection_internal
772 and remove this function.
773 (ns_handle_selection_clear): Remove, never used.
774 (Fx_own_selection_internal): Move code from ns_handle_selection_request
775 here.
776
e1b01a3a
KB
7772011-12-17 Ken Brown <kbrown@cornell.edu>
778
779 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
780 GID is unknown (Bug#10257).
781
2adb6e85
PE
7822011-12-17 Paul Eggert <eggert@cs.ucla.edu>
783
784 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
785 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
786 which caused a build failure on GNU/Linux IA-64. This problem was
787 introduced by my 2011-10-07 patch.
788
d1d7b339
JL
7892011-12-15 Juri Linkov <juri@jurta.org>
790
791 * image.c (imagemagick_error): New function. (Bug#10112)
792 (imagemagick_load_image): Comment out `MagickSetResolution' call.
793 Use `imagemagick_error' where ImageMagick functions return
794 `MagickFalse'.
795 (Fimagemagick_types): Add `Fnreverse' to return the list in the
796 proper order.
797
100d5755
KH
7982011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
799
800 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
801 fill background (Bug#8992).
802
454592a6
MR
8032011-12-13 Martin Rudalics <rudalics@gmx.at>
804
805 * window.c (Vwindow_combination_resize)
806 (Vwindow_combination_limit): Use t instead of non-nil in
807 doc-strings.
61d4b438
MR
808 (Vrecenter_redisplay): Add first sentence of doc-string on
809 separate line.
53524d93 810 (Frecenter): Fix doc-string typo.
454592a6 811
3633e3aa
KH
8122011-12-11 Kenichi Handa <handa@m17n.org>
813
814 * coding.c (Funencodable_char_position): Pay attention to the
815 buffer text relocation (Bug#9389).
816
7b9d523a
JD
8172011-12-10 Jan Djärv <jan.h.d@swipnet.se>
818
819 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
820 gtk_init (Bug#10100).
821
b73189c6
EZ
8222011-12-10 Eli Zaretskii <eliz@gnu.org>
823
824 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
825 IT->string is nil. (Bug#10263)
826
f7dfe5d6
JD
8272011-12-10 Jan Djärv <jan.h.d@swipnet.se>
828
83faebb4
JD
829 * nsterm.h (x_free_frame_resources): Declare.
830
f7dfe5d6
JD
831 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
832 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
833
834 * nsterm.h (ns_get_defaults_value): Declare.
835
836 * nsterm.m (ns_default): Call ns_get_defaults_value.
837
7cd4e72c
EZ
8382011-12-09 Eli Zaretskii <eliz@gnu.org>
839
840 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
841 (Bug#10170)
842
b34d7317
YM
8432011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
844
845 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
846 that where the value of an _OBJC_* symbol points to is in the .bss
847 section (Bug#10240).
848
76470ad1
KH
8492011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
850
851 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 852 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 853
745fff94
KH
8542011-12-08 Kenichi Handa <handa@m17n.org>
855
856 * ftfont.c (get_adstyle_property): Fix previous change
857 (Bug#10233).
858
6e44397c
JB
8592011-12-07 Juanma Barranquero <lekktu@gmail.com>
860
861 * w32.c (init_environment): If no_site_lisp, remove site-lisp
862 dirs from the default value of EMACSLOADPATH (bug#10208).
863
7efa6272
GM
8642011-12-07 Glenn Morris <rgm@gnu.org>
865
866 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
867 installation and source directories as well. (Bug#10208)
868
f6fc4d87
CY
8692011-12-06 Chong Yidong <cyd@gnu.org>
870
871 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
872
2bf26180
GM
8732011-12-06 Glenn Morris <rgm@gnu.org>
874
875 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
876 as an error, not just -1. (Bug#10217)
877
3a6ad4f0
CY
8782011-12-05 Chong Yidong <cyd@gnu.org>
879
880 * keyboard.c (process_special_events): New function.
881 (swallow_events, Finput_pending_p): Use it (Bug#10195).
882
75a3b399
PE
8832011-12-05 Paul Eggert <eggert@cs.ucla.edu>
884
885 * coding.c (encode_designation_at_bol): Don't use uninitialized
886 local variable (Bug#9318).
887
c3c9e25e
KH
8882011-12-05 Kenichi Handa <handa@m17n.org>
889
890 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
891 return Qnil (Bug#8046, Bug#10193).
892
5eb05ea3
KH
8932011-12-05 Kenichi Handa <handa@m17n.org>
894
895 * coding.c (encode_designation_at_bol): New args charbuf_end and
896 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
897 (coding_set_source): Return how many bytes coding->source was
898 relocated.
899 (coding_set_destination): Return how many bytes
900 coding->destination was relocated.
901 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 902 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
903
9042011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
905
906 * coding.c (CODING_CHAR_CHARSET_P): New macro.
907 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
908 macro (Bug#9318).
909
9102011-12-05 Andreas Schwab <schwab@linux-m68k.org>
911
912 The following changes are to fix Bug#9318.
913
a79703f5 914 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
915 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
916 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 917 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 918
7dbda6df
JB
9192011-12-05 Juanma Barranquero <lekktu@gmail.com>
920
921 * lisp.h (process_quit_flag): Fix external declaration.
922
6d5eb5b0
SM
9232011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
924
925 Don't macro-inline non-performance-critical code.
926 * eval.c (process_quit_flag): New function.
927 * lisp.h (QUIT): Use it.
928
a0c3fad0
JD
9292011-12-04 Jan Djärv <jan.h.d@swipnet.se>
930
931 * nsfns.m (get_geometry_from_preferences): New function.
932 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
933
6c07aac2
AS
9342011-12-04 Andreas Schwab <schwab@linux-m68k.org>
935
936 * emacs.c (Qkill_emacs): Define.
937 (syms_of_emacs): Initialize it.
938 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
939 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
940 (quit_throw_to_read_char): Add parameter `from_signal'.
941 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
942 * lisp.h (QUIT): Call Fkill_emacs if requested.
943
c052ead4
JD
9442011-12-03 Jan Djärv <jan.h.d@swipnet.se>
945
946 * widget.c (update_wm_hints): Return if wmshell is null.
947 (widget_update_wm_size_hints): New function.
948
949 * widget.h (widget_update_wm_size_hints): Declare.
950
951 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
952 widget_update_wm_size_hints (Bug#10104).
953
9e49252b
EZ
9542011-12-03 Eli Zaretskii <eliz@gnu.org>
955
956 * xdisp.c (handle_invisible_prop): If the invisible text ends just
957 before a newline, prepare the bidi iterator for consuming the
958 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 959 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 960
02b16839
JL
9612011-12-02 Juri Linkov <juri@jurta.org>
962
963 * search.c (Fword_search_regexp): New Lisp function created from
964 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
965 (Fword_search_backward, Fword_search_forward)
966 (Fword_search_backward_lax, Fword_search_forward_lax):
967 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
968 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
969
0068070e
SM
9702011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
971
972 * fileio.c (Finsert_file_contents): Move after-change-function call
973 to before the "handled:" label, since all "goto handled" appear in
974 cases where the *-change-functions have already been properly called
975 (bug#10117).
976
3360a3fc
AS
9772011-12-01 Andreas Schwab <schwab@linux-m68k.org>
978
979 * keyboard.c (interrupt_signal): Don't call kill-emacs when
980 waiting for input. (Bug#10169)
981
73d6c093
EZ
9822011-11-30 Eli Zaretskii <eliz@gnu.org>
983
984 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
985 verifies glyph row's hash code--we have just reallocated the
986 glyphs, so their contents can be complete garbage. (Bug#10164)
987
febe6bea
JB
9882011-11-30 Juanma Barranquero <lekktu@gmail.com>
989
990 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
991
801a4313
EZ
9922011-11-30 Eli Zaretskii <eliz@gnu.org>
993
994 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
995 attributes are tested _before_ calling verify_row_hash, to protect
996 against GCC re-ordering of the tests. (Bug#10164)
997
2b56b87e
JD
9982011-11-29 Jan Djärv <jan.h.d@swipnet.se>
999
1000 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1001
1002 * xterm.c (handle_one_xevent): Only set async_visible and friends
1003 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1004 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1005 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1006
dbf31225
PE
10072011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1008
1009 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1010 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1011 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1012 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1013 All uses changed to use GCPRO1 etc.
1014 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1015 Revert to old implementation (i.e., before 2011-03-11).
1016
1305621b
YM
10172011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1018
1019 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1020 of scroll runs so as to avoid assigning disabled bogus rows and
1021 unnecessary graphics copy operations.
1022
8c9afb46
EZ
10232011-11-27 Eli Zaretskii <eliz@gnu.org>
1024
1025 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1026 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1027 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1028 (malloc, free, realloc, calloc): Redirect to e_* only when
1029 compiling Emacs.
1030
1031 * lisp.h (GCTYPEBITS): Move before first use.
1032 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1033 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1034 this macro definition.
1035
1036 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1037 _MSC_VER.
1038
54e9e3bf
JD
10392011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1040
6d5eb5b0
SM
1041 * gtkutil.c (xg_create_frame_widgets):
1042 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1043 present with Gtk+ 2.0.
1044
83aca1cb
PE
10452011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1046
1047 * fileio.c (Finsert_file_contents): Undo previous change; see
1048 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1049
5b76caa4
PE
10502011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1051
1052 Rename locals to avoid shadowing.
1053 * fileio.c (Finsert_file_contents):
1054 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1055 * process.c (wait_reading_process_output):
1056 Rename inner 'proc' to 'p' to avoid shadowing.
1057 Indent for consistency with usual Emacs style.
1058
8c535114
EZ
10592011-11-25 Eli Zaretskii <eliz@gnu.org>
1060
1061 * xdisp.c (redisplay_window): If cursor row is not fully visible
1062 after recentering, and scroll-conservatively is set to a large
1063 number, scroll window by a few more lines to make the cursor fully
1064 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1065 (start_display): Don't move to the next line if the display should
1066 start at a newline that is part of a display vector or an overlay
1067 string. (Bug#10119)
8c535114 1068
fa4fdb5c
JL
10692011-11-24 Juri Linkov <juri@jurta.org>
1070
1071 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1072 after the `MagickPingImage' call. (Bug#10112)
1073
90ec88df
CY
10742011-11-23 Chong Yidong <cyd@gnu.org>
1075
1076 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1077
56e2e794
MR
10782011-11-23 Martin Rudalics <rudalics@gmx.at>
1079
1080 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1081 making another buffer current. (Bug#10114)
1082
b6e64c41
GM
10832011-11-23 Glenn Morris <rgm@gnu.org>
1084
1085 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1086
6b21de18
CY
10872011-11-23 Chong Yidong <cyd@gnu.org>
1088
1089 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1090 using it (Bug#5984).
1091
b12cd789
EZ
10922011-11-22 Eli Zaretskii <eliz@gnu.org>
1093
1094 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1095 and header-lines, as they don't have one computed for them.
1096 (Bug#10098)
1097
1098 * .gdbinit (prow): Make displayed values more self-explaining.
1099 Add row's hash code.
1100
261b6fd4
LMI
11012011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1102
1103 * process.c (wait_reading_process_output): Fix asynchrounous
1104 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1105 (wait_reading_process_output): Add comment and URL.
261b6fd4 1106
e7cfd277
JD
11072011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1108
1109 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1110
a9b9b7f5
CY
11112011-11-21 Chong Yidong <cyd@gnu.org>
1112
1113 * window.c (Fnext_window, Fprevious_window): Doc fix.
1114
b0d15b4f
SM
11152011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1116
1117 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1118
fe7a3057
JB
11192011-11-20 Juanma Barranquero <lekktu@gmail.com>
1120
1121 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1122
d2999b1a
MR
11232011-11-20 Martin Rudalics <rudalics@gmx.at>
1124
1125 * window.c (Fset_window_combination_limit): Rename argument
1126 STATUS to LIMIT.
1127 (Vwindow_combination_limit): Remove "status" from doc-string.
1128
d5ff9cd0
AS
11292011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1130
1131 * m/ibms390.h: Remove.
1132 * m/ibms390x.h: Don't include "ibms390.h".
1133
a5bb9bd3
SM
11342011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1135
1136 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1137 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1138
cd1181db
JB
11392011-11-20 Juanma Barranquero <lekktu@gmail.com>
1140
1141 * casetab.c (Fset_case_table):
1142 * charset.c (Fcharset_after): Fix typos.
1143
615a3b8d 11442011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1145
17e845af
PE
1146 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1147 Otherwise, valgrind does not work on some platforms.
1148 Problem reported by Andreas Schwab in
6a0bf43d
PE
1149 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1150 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1151 is set, removing the need for VIRT_ADDRESS_VARIES.
1152 (PURE_P): Use a more-efficient implementation that needs just one
1153 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1154 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1155 to 4 (xorl, subq, cmpq, setbe).
1156 * alloc.c (pure): Always extern now, since that's the
1157 VIRT_ADDR_VARIES behavior.
1158 (PURE_POINTER_P): Use a single comparison, not two, for
1159 consistency with the new puresize.h.
1160 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1161 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1162 Remove VIRT_ADDR_VARIES no longer needed.
1163
f8fe6f96
EZ
11642011-11-19 Eli Zaretskii <eliz@gnu.org>
1165
1166 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1167 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1168 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1169 behave as if the cursor position were at the window margin.
1170
1171 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1172 and the cursor position is out of bounds, behave as if the cursor
1173 position were at the window margin. (Bug#10075)
1174
df05a53c
CY
11752011-11-18 Chong Yidong <cyd@gnu.org>
1176
1177 * window.c (Fwindow_combination_limit): Make first argument
1178 non-optional, since it is meaningless for live windows like the
1179 selected window.
1180
2071918e
DA
11812011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1182
1183 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1184
b50a28de
SM
11852011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1186
1187 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1188 (graft_intervals_into_buffer): Simplify.
1189
015137db
EZ
11902011-11-18 Eli Zaretskii <eliz@gnu.org>
1191
1192 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1193 hash values of the two rows.
1194 (copy_row_except_pointers): Preserve the used[] arrays and the
1195 hash values of the two rows. (Bug#10035)
68c95424 1196 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1197
1198 * xdisp.c (row_hash): New function, body extracted from
1199 compute_line_metrics.
1200 (compute_line_metrics): Call row_hash, instead of computing the
1201 hash code inline.
1202
1203 * dispnew.c (verify_row_hash): Call row_hash for computing the
1204 hash code of a row, instead of duplicating code from xdisp.c.
1205
1206 * dispextern.h (row_hash): Add prototype.
1207
a2addb04
TH
12082011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1209
1210 * frame.c (delete_frame): Don't delete the terminal when the last
1211 X frame is closed if emacs is built with GTK toolkit.
1212
df85d315
JB
12132011-11-17 Juanma Barranquero <lekktu@gmail.com>
1214
1215 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1216
a0c2d0ae
MR
12172011-11-17 Martin Rudalics <rudalics@gmx.at>
1218
1219 * window.c (Vwindow_splits): Rename to
1220 Vwindow_combination_resize. Suggested by Juri Linkov.
1221 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1222 of Vwindow_splits.
1223
58179cce
JB
12242011-11-16 Juanma Barranquero <lekktu@gmail.com>
1225
7877f373
JB
1226 * nsfns.m (Fns_font_name):
1227 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1228
b6f67890
MR
12292011-11-16 Martin Rudalics <rudalics@gmx.at>
1230
1231 * window.h (window): Rename slot "nest" to "combination_limit".
1232 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1233 (Fset_window_nest): Rename to Fset_window_combination_limit.
1234 (Vwindow_nest): Rename to Vwindow_combination_limit.
1235 (recombine_windows, make_parent_window, make_window)
1236 (Fsplit_window_internal, saved_window)
1237 (Fset_window_configuration, save_window_save): Rename all
1238 occurrences of window_nest to window_combination_limit.
1239
c7015153
JB
12402011-11-15 Juanma Barranquero <lekktu@gmail.com>
1241
1242 * image.c (imagemagick_load_image): Fix typo.
1243
322ad6ec
EZ
12442011-11-14 Eli Zaretskii <eliz@gnu.org>
1245
1246 * xdisp.c (display_line): Move the call to
1247 highlight_trailing_whitespace before the call to
1248 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1249 faces of all the glyphs to compute ROW's hash value.
1250 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1251
f067b8ec
JB
12522011-11-14 Juanma Barranquero <lekktu@gmail.com>
1253
1254 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1255 just return (bug#10044).
1256
1e5b2111
EZ
12572011-11-12 Eli Zaretskii <eliz@gnu.org>
1258
7ef3cbd5
EZ
1259 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1260 with user-defined heap size. Bump the default size of the temacs
1261 heap to 27MB, to avoid memory warning when running temacs.
1262 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1263
1e5b2111
EZ
1264 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1265 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1266 (verify_row_hash) [XASSERTS]: New function.
1267 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1268 that the hash value of glyph rows is correct.
1e5b2111 1269
89d61221
MR
12702011-11-12 Martin Rudalics <rudalics@gmx.at>
1271
1272 * window.h (window): Remove splits slot.
1273 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1274 (Fdelete_other_windows_internal, make_parent_window)
1275 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1276 (Fset_window_configuration, save_window_save): Don't deal with
1277 split status of windows.
1278 (saved_window): Remove splits slot.
1279 (Vwindow_splits): Rewrite doc-string.
1280
97f18cc8
JD
12812011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1282
1283 * xfns.c (unwind_create_frame):
1284 * nsfns.m (unwind_create_frame):
1285 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1286 Vframe_list (Bug#9999).
1287
22a648b4
DA
12882011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1289
0b381c7e 1290 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1291
659afede
KH
12922011-11-11 Kenichi Handa <handa@m17n.org>
1293
1294 * callproc.c (Fcall_process): Set the member dst_multibyte of
1295 process_coding.
1296
9ac0394b
KH
12972011-11-11 Johan Bockgård <bojohan@gnu.org>
1298
1299 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1300 avoid a crash (bug#9496).
1301
2fbdc249
CY
13022011-11-09 Chong Yidong <cyd@gnu.org>
1303
1304 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1305 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1306
ac6b1f81
PE
13072011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1308
1309 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1310
09db192c
PE
13112011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1312
1313 Avoid some portability problems by eschewing 'extern inline' functions.
1314 The trivial performance wins aren't worth the portability hassles; see
1315 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1316 et seq.
1317 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1318 (window_box_width, window_box_left, window_box_left_offset)
1319 (window_box_right, window_box_right_offset): Undo previous change,
1320 by removing the "extern"s.
1321 * intervals.c (adjust_intervals_for_insertion)
1322 (adjust_intervals_for_deletion): Undo previous change,
1323 making these static again.
1324 (offset_intervals, temp_set_point_both, temp_set_point)
1325 (copy_intervals_to_string): No longer inline.
1326 * xdisp.c (window_text_bottom_y, window_box_width)
1327 (window_box_height, window_box_left_offset)
1328 (window_box_right_offset, window_box_left, window_box_right)
1329 (window_box): No longer inline.
1330
105216ed
CY
13312011-11-08 Chong Yidong <cyd@gnu.org>
1332
1333 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1334 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1335 Signal an error if not a live window.
105216ed
CY
1336 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1337 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1338
ae9e237f
JB
13392011-11-07 Juanma Barranquero <lekktu@gmail.com>
1340
1341 * lisp.h (syms_of_abbrev): Remove declaration.
1342 Reported by CHENG Gao <chenggao@royau.me>.
1343
c7aa8333
EZ
13442011-11-07 Eli Zaretskii <eliz@gnu.org>
1345
1346 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1347 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1348 of temacs in GUI mode.
1349
be7f5545
MR
13502011-11-07 Martin Rudalics <rudalics@gmx.at>
1351
1352 * window.h: Declare delete_all_child_windows instead of
1353 delete_all_subwindows.
1354 * window.c (Fwindow_nest, Fset_window_nest)
1355 (Fset_window_new_total, Fset_window_new_normal)
1356 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1357 (delete_all_subwindows): Rename to delete_all_child_windows.
1358 (Fdelete_other_windows_internal, Fset_window_configuration):
1359 Call delete_all_child_windows instead of delete_all_subwindows.
1360 * frame.c (delete_frame): Call delete_all_child_windows instead
1361 of delete_all_subwindows.
1362
ca78dc43
PE
13632011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1364
1365 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1366 This is also needed for porting to any host where GC_MARK_STACK is
1367 not GC_MAKE_GCPROS_NOOPS.
1368 (which_symbols): Use it.
1369
a0241d01
KH
13702011-11-07 Kenichi Handa <handa@m17n.org>
1371
1372 * coding.c (coding_set_destination): Check coding->src_pos only
1373 when coding->src_object is a buffer (bug#9910).
1374
1375 * process.c (send_process): Set the member src_multibyte of coding
1376 to 0 (bug#9911) when sending a unibyte text.
1377
1378 * callproc.c (Fcall_process): Set the member src_multibyte of
1379 process_coding to 0 (bug#9912).
1380
a64bfdfa 13812011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1382
1383 * xmenu.c (cleanup_widget_value_tree): New function.
1384 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1385 calling free_menubar_widget_value_tree directly (Bug#9830).
1386
cb41b32a
PE
13872011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1388
1389 Fix some portability problems with 'inline'.
1390 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1391 (window_box_width, window_box_left, window_box_left_offset)
1392 (window_box_right, window_box_right_offset): Declare extern.
1393 Otherwise, these inline functions do not conform to C99 and
1394 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1395 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1396 * intervals.c (adjust_intervals_for_insertion)
1397 (adjust_intervals_for_deletion): Now extern, because otherwise the
1398 extern inline functions 'offset_intervals' couldn't refer to it.
1399 (static_offset_intervals): Remove.
1400 (offset_intervals): Rewrite using the old contents of
1401 static_offset_intervals. The old version didn't conform to C99
1402 because an extern inline function contained a reference to an
1403 identifier with static linkage.
1404
b7041366
AS
14052011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1406
1407 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1408 GC.
1409
88a37c4d
EZ
14102011-11-06 Eli Zaretskii <eliz@gnu.org>
1411
1412 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1413 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1414 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1415 return Qleft_to_right.
1416
49745b39
CY
14172011-11-06 Chong Yidong <cyd@gnu.org>
1418
1419 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1420 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1421 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1422 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1423 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1424 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1425 (Fwindow_vscroll): Doc fix.
1426 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1427 argument, since it makes no sense to pass a live window and for
1428 consistency with window-child.
1429
1f05cd82
CS
14302011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1431
1432 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1433 support MSVC.
1434
22610910
JR
14352011-11-05 Jason Rumney <jasonr@gnu.org>
1436
1437 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1438 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1439 fonts (Bug#6029).
1440 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1441 bitwise arithmetic preventing use of unicode-sip and non-truetype
1442 opentype fonts.
1443
a06776b2
EZ
14442011-11-05 Eli Zaretskii <eliz@gnu.org>
1445
3ad924ba
EZ
1446 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1447 "emacs"-only part.
1448
a06776b2
EZ
1449 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1450 initialization code to keep similarity to xfns.c after changes
1451 from 2011-11-05.
1452
c9e7db78
JD
14532011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1454
a97f8f3f
JD
1455 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1456 (unwind_create_frame): New function (Bug#9943).
1457 (Fx_create_frame): Restructure code to be more similar to the one in
1458 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1459 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1460 Move terminal->reference_count++ just before making the frame official
1461 (Bug#9943).
1462
1463 * nsterm.m (x_free_frame_resources): New function.
1464 (x_destroy_window): Move code to x_free_frame_resources.
1465
c9e7db78 1466 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1467 (Fx_create_frame, x_create_tip_frame):
1468 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1469 official. Move initialization of image_cache_refcount and
1470 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1471
a6fc3b5c
EZ
14722011-11-05 Eli Zaretskii <eliz@gnu.org>
1473
1474 Support MSVC build with newer versions of Visual Studio.
1475 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1476 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1477 nt/gmake.defs.
1478
1479 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1480 which are not supported by MSVC.
1481 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1482 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1483 bitfields.
1484 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1485 types in bitfields.
1486 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1487
1488 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1489
58179cce 14902011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1491
1492 Support MSVC build with newer versions of Visual Studio.
1493 * w32.c: Don't include w32api.h for MSVC.
1494 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1495
1496 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1497 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1498 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1499 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1500 e_* cousins.
1501 (alloca) [_MSC_VER]: Define to _alloca.
1502
1503 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1504
1505 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1506
a58c13ed
EZ
15072011-11-04 Eli Zaretskii <eliz@gnu.org>
1508
1509 * xdisp.c (note_mouse_highlight): If either of
1510 previous/next-single-property-change returns nil, treat that as
1511 the beginning or the end of the buffer. (Bug#9955)
1512
fe0b6370
JD
15132011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1514
a58c13ed 1515 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1516 label is not null (Bug#9951).
1517 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1518 may be NULL.
1519
89bd5ee1
EZ
15202011-11-04 Eli Zaretskii <eliz@gnu.org>
1521
1522 * window.c (Fwindow_body_size): Mention in the doc string that the
1523 return value is in frame's canonical units. (Bug#9949)
1524
84c3edb9
EZ
15252011-11-03 Eli Zaretskii <eliz@gnu.org>
1526
4e2fb5c7
EZ
1527 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1528
84c3edb9 1529 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1530 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1531 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1532
bc17a887
EZ
15332011-11-01 Eli Zaretskii <eliz@gnu.org>
1534
1535 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1536 Don't stop backward scan on the continuation glyph, even though
1537 its CHARPOS is positive.
6d5eb5b0
SM
1538 (mouse_face_from_buffer_pos, note_mouse_highlight):
1539 Rename cover_string to disp_string.
bc17a887 1540
4ee88440
MR
15412011-11-01 Martin Rudalics <rudalics@gmx.at>
1542
1543 * window.c (temp_output_buffer_show): Don't use
1544 Vtemp_buffer_show_specifiers.
1545 (Vtemp_buffer_show_specifiers): Remove unused variable.
1546
c2ff3c02
EZ
15472011-10-30 Eli Zaretskii <eliz@gnu.org>
1548
1549 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1550 past the beginning of the current glyph matrix.
1551
58179cce 15522011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1553
1554 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1555 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1556 HAVE_GTK3 (Bug#9869).
b77a6a7f 1557
3b574623
JD
1558 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1559 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1560
b77a6a7f
JD
1561 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1562
1563 * xterm.c: Declare x_handle_net_wm_state to return int.
1564 (handle_one_xevent): Check if we are iconified but don't have
1565 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1566 (get_current_wm_state): Return non-zero if not hidden,
1567 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1568 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1569 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1570 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1571
196e41e4
PE
15722011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1573
1574 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1575 so that this new function doesn't get optimized away by a
1576 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1577
021f2e1a
AS
15782011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1579
1580 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1581
8b058d44
EZ
15822011-10-29 Eli Zaretskii <eliz@gnu.org>
1583
1584 Fix the `xbytecode' command.
1585 * .gdbinit (xprintbytestr): New command.
b50a28de 1586 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1587 (xbytecode): Print the byte-code string as well.
1588
4452fb80
EZ
15892011-10-29 Kim Storm <storm@cua.dk>
1590
8b058d44
EZ
1591 * alloc.c (which_symbols): New function.
1592
21b72067
AS
15932011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1594
1595 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1596 line. (Bug#9903)
1597
83ed7b5c
GM
15982011-10-29 Glenn Morris <rgm@gnu.org>
1599
1600 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1601 Not clear what it was for, and it causes various bugs. (Bug#9839)
1602
5a7a728b
EZ
16032011-10-28 Eli Zaretskii <eliz@gnu.org>
1604
1605 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1606 possible random value that matches one of those tested as
1607 condition to clear the mouse face.
1608
d3d0842f
CY
16092011-10-28 Chong Yidong <cyd@gnu.org>
1610
1611 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1612
31b39d13
DN
16132011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1614
1615 * window.c (make_window): Initialize phys_cursor_on_p.
1616
9aba6043
SM
16172011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1618
1619 * lisp.h (struct Lisp_Symbol): Update comments.
1620
c20992f4
JB
16212011-10-28 Juanma Barranquero <lekktu@gmail.com>
1622
1623 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1624
db4f02f2
EZ
16252011-10-28 Eli Zaretskii <eliz@gnu.org>
1626
1627 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1628 <oslsachem@gmail.com> for helping to debug this.
1629
1630 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1631 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1632 (g_b_init_get_glyph_outline_w): New static variables.
1633 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1634 (GetGlyphOutlineW_Proc): New typedefs.
1635 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1636 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1637 New functions.
1638 (w32font_open_internal, compute_metrics):
1639 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1640 instead of calling the "wide" APIs directly.
1641
1642 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1643
1644 * w32.h (syms_of_w32font): Add prototype.
1645
87e68db4
JB
16462011-10-27 Juanma Barranquero <lekktu@gmail.com>
1647
1648 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1649 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1650 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1651 (Fmove_to_window_line): Doc fix.
1652
435c1d67
CY
16532011-10-27 Chong Yidong <cyd@gnu.org>
1654
1655 * process.c (make_process): Set gnutls_state to NULL.
1656
1657 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1658 non-NULL, regardless of GNUTLS_INITSTAGE.
1659 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1660 an error. Set process slots as soon as we allocate them.
1661
1662 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1663
9c6c6f49
CY
16642011-10-27 Chong Yidong <cyd@gnu.org>
1665
9aba6043
SM
1666 * gnutls.c (emacs_gnutls_deinit): New function.
1667 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1668 (Fgnutls_deinit, Fgnutls_boot): Use it.
1669
1670 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1671 (deactivate_process): Call emacs_gnutls_deinit.
1672
657d08d3
JB
16732011-10-27 Juanma Barranquero <lekktu@gmail.com>
1674
1675 * image.c (x_create_x_image_and_pixmap):
1676 * w32.c (sys_rename, w32_delayed_load):
1677 * w32font.c (fill_in_logfont):
1678 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1679
5430d399
JB
16802011-10-26 Juanma Barranquero <lekktu@gmail.com>
1681
1682 * w32fns.c (w32_default_color_map): New function,
1683 extracted from Fw32_default_color_map.
a7ef684b 1684 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1685
fe0055fa
PE
16862011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1687
1688 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1689
e6346438
SM
16902011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1691
1692 * keyboard.c (test_undefined): New function (bug#9751).
1693 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1694
e112cc37
ET
16952011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1696
1697 * sysdep.c (init_sys_modes): Fix the check for the controlling
1698 terminal (Bug#6649).
1699
7b5d6677
EZ
17002011-10-20 Eli Zaretskii <eliz@gnu.org>
1701
1702 * dispextern.h (struct bidi_it): New member next_en_type.
1703
1704 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1705 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1706 current character, check also for next_en_type being WEAK_EN.
1707 (bidi_resolve_weak): Don't enter the expensive loop if the current
1708 position is before next_en_pos. Record the bidi type of the first
1709 non-ET, non-BN character we find, in addition to its position.
1710 (bidi_level_of_next_char): Invalidate next_en_type when
1711 next_en_pos is over-stepped.
1712
7da0b018
PE
17132011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1714
1715 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1716 * editfns.c: Rewrite current-time-zone so that it invokes
1717 the equivalent of (format-time-string "%Z") to get the time zone name.
1718 This fixes a bug when the time zone name contains characters that
1719 need converting from the system time locale to Emacs internal format.
1720 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1721 that patch fixed format-time-string to do the conversion, but
1722 I forgot to fix current-time-zone.
1723 (format_time_string): New function, containing most of
1724 what Fformat_time_string used to contain.
1725 (Fformat_time_string): Rewrite in terms of format_time_string.
1726 This doesn't change this function's behavior.
1727 (current-time-zone): Rewrite to use format_time_string.
1728 This fixes the bug reported by Michael Schierl in
1729 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1730 Jason Rumney's 2007-06-07 change worked around this bug, but
1731 didn't fix it.
1732 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1733
8547b010
EZ
17342011-10-19 Eli Zaretskii <eliz@gnu.org>
1735
1736 * xdisp.c (start_display): If the character at POS is displayed
1737 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1738 (try_window_reusing_current_matrix): If a line ends in a display
1739 vector or the next line starts in a display vector, continue
1740 redrawing the window even though the character position of
1741 start_row was reached.
8547b010
EZ
1742 (Bug#9771, part 2)
1743
4e948d15
CY
17442011-10-18 Chong Yidong <cyd@gnu.org>
1745
1746 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1747 with nobreak-char-display too.
1748
4787455f
EZ
17492011-10-18 Eli Zaretskii <eliz@gnu.org>
1750
1751 Fix part 3 of bug#9771.
1752 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1753 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1754 non-neutral characters if the current character is a paragraph
1755 separator (a.k.a. Newline). This avoids running the same
1756 expensive loop twice, once when we consume the preceding newline
1757 and the other time when the line actually needs to be displayed.
1758 Avoid the loop when we see neutrals on the base embedding level
1759 following a character whose directionality is the same as the
1760 paragraph's. This avoids running the expensive loop when a line
1761 ends in a long sequence of neutrals, like control characters.
1762 Add assertion against STRONG_AL type. Slightly rearrange code
1763 that determines the type of a neutral given the first non-neutral
1764 that follows it.
1765 (bidi_level_of_next_char): Set next_en_pos to zero when
1766 invalidating its info.
1767
2c91f553
EZ
17682011-10-17 Eli Zaretskii <eliz@gnu.org>
1769
1770 * xdisp.c (push_display_prop): Determine whether to record string
1771 or buffer position by IT->string, not by IT->method. Allow
1772 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1773 (move_it_vertically_backward): Don't look for character position
1774 immediately after the newline when in a continuation line.
1775 (Bug#9771, part 1)
2c91f553 1776
c7b08b0d
MR
17772011-10-15 Martin Rudalics <rudalics@gmx.at>
1778
1779 * window.c (coordinates_in_window): Rewrite and delabelize
1780 vertical border check. (Bug#5357) (Bug#9618)
1781
6b02f655
SM
17822011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1783
1784 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1785 errors in XSetWindowBorder (bug#9310).
1786
81d40c92
DA
17872011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1788
1789 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1790 avoid crash when xmalloc overrun checking is enabled.
1791
d4172c3b
EZ
17922011-10-13 Eli Zaretskii <eliz@gnu.org>
1793
1794 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1795 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1796 cursor motion with <left> and <right> arrow keys.
1797
1798 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1799 some callers set that themselves.
1800
b00eea75
EZ
18012011-10-12 Eli Zaretskii <eliz@gnu.org>
1802
1803 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1804 display string and the previous row comes from the same string and
1805 is empty. (Bug#9739) (Bug#9738)
1806
8fe012c4
SM
18072011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1808
1809 * doc.c (get_doc_string): Encode file name (bug#9735).
1810
0074aef2
EZ
18112011-10-12 Eli Zaretskii <eliz@gnu.org>
1812
79beb178
EZ
1813 * bidi.c (bidi_level_of_next_char):
1814 * xdisp.c (get_visually_first_element): Remove old incorrect
1815 comments regarding the Unicode Line Separator character.
1816
0074aef2
EZ
1817 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1818
6e4b3fbe
DA
18192011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1820
1821 * alloc.c (Fgc_status): Do not access beyond zombies array
1822 boundary if nzombies > MAX_ZOMBIES.
1823 * alloc.c (dump_zombies): Add missing format specifier.
1824
0324f3af
PE
18252011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1826
b5525cac
PE
1827 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1828 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1829
0324f3af
PE
1830 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1831 Some packages use them to denote characters with modifiers.
1832
e9b5f888
AS
18332011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1834
1835 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1836 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1837 matching a pp-number. Rename parameter var to var1.
1838
127827c0
SM
18392011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1840
1841 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1842
c8fd3bd0
GM
18432011-10-08 Glenn Morris <rgm@gnu.org>
1844
1845 * callint.c (Fcall_interactively): Give a more explicit error for the
1846 'c' case with a non-character input. (Bug#8479)
1847
352ec8ff
EZ
18482011-10-08 Eli Zaretskii <eliz@gnu.org>
1849
03669ccb
EZ
1850 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1851 lines.
7061c986
EZ
1852 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1853 lines that are hscrolled on the left.
03669ccb 1854
352ec8ff
EZ
1855 * dispnew.c (buffer_posn_from_coords): Account for a possible
1856 presence of header-line. (Bug#4426)
1857
a66cfb1c
SM
18582011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1859
6b02f655
SM
1860 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1861 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1862
7c5ee88e
PE
18632011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1864
1865 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1866 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1867 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1868 this makes Emacs dump core during garbage collection on rare
1869 occasions. sizeof is obviously inferior to offsetof here, so
1870 stick with offsetof.
1871 (GC_POINTER_ALIGNMENT): New macro.
1872 (mark_memory): Omit 3rd (offset) arg; caller changed.
1873 Don't assume EMACS_INT alignment is the same as pointer alignment.
1874
df1bbe5b
SM
18752011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1876
1877 * keyboard.c (read_key_sequence_remapped): New var.
1878 (read_key_sequence): Compute remapping in the right buffer.
1879 (command_loop_1): Use read_key_sequence's remapping directly.
1880
51553db6
SM
18812011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1882
32c1fffd
SM
1883 * dired.c (file_name_completion): Don't expand file name.
1884 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1885 before checking file name handler.
1886
51553db6
SM
1887 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1888 they've been requested explicitly (bug#9591).
1889
b6bd1599 18902011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1891
1892 * keymap.c (Fsingle_key_description): Use make_specified_string
1893 instead of build_string to build string from push_key_description.
1894 (Bug#5193)
1895
f701dc2a
PE
18962011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1897
4222c55d
PE
1898 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1899 This fixes a Y2038 bug on 64-bit hosts.
1900 * buffer.c (reset_buffer):
1901 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1902 (Fclear_buffer_auto_save_failure):
1903 Use 0, not -1, to represent an unset failure time, since time_t
1904 might not be signed.
1905
f701dc2a
PE
1906 Remove dependency on glibc malloc internals.
1907 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1908 Move back here from lisp.h, but with their new implementations.
1909 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1910 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1911 * charset.c (charset_table_init): New static var.
1912 (syms_of_charset): Use it instead of xmalloc. This removes a
1913 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1914 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1915 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1916 Move back to alloc.c.
1917 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1918 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1919
9ceebf39
JD
19202011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1921
1922 * nsterm.m (windowDidResize): Call x_set_window_size only when
1923 ns_in_resize is true. Otherwise set pixelwidth/height and
1924 call change_frame_size (Bug#9628).
1925
cb993c58
PE
19262011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1927
3930c88b
PE
1928 Port --enable-checking=all to Fedora 14 x86-64.
1929 * charset.c (syms_of_charset): Also account for glibc malloc's
1930 internal overhead when calculating the initial malloc maximum.
1931
cb993c58
PE
1932 Port --enable-checking=all to Fedora 14 x86.
1933 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1934 Move to lisp.h.
1935 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1936 (overrun_check_realloc, overrun_check_free):
1937 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1938 That way, xmalloc returns a properly-aligned pointer even if
1939 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1940 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1941 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1942 into account when calculating the initial malloc maximum.
1943 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1944 Move here from alloc.c, so that charset.c can use it too.
1945 Properly align; the old code wasn't right for common 32-bit hosts
1946 when configured with --enable-checking=all.
1947 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1948 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1949
31bed486
EZ
19502011-09-29 Eli Zaretskii <eliz@gnu.org>
1951
04c70788 1952 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1953 use EDOM.
1954
fbcaa2f3
EZ
19552011-09-28 Eli Zaretskii <eliz@gnu.org>
1956
1957 * xdisp.c (compute_display_string_end): If there's no display
1958 string at CHARPOS, return -1.
1959
1960 * bidi.c (bidi_fetch_char): When compute_display_string_end
1961 returns a negative value, treat the character as a normal
1962 character not covered by a display string. (Bug#9624)
1963
a239d4e9
JB
19642011-09-28 Juanma Barranquero <lekktu@gmail.com>
1965
1966 * lread.c (Fread_from_string): Fix typo in docstring.
1967
88652fd5
EZ
19682011-09-27 Eli Zaretskii <eliz@gnu.org>
1969
1970 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1971 newline, reseat the iterator instead of bidi-iterating there one
1972 character at a time. (Bug#9610)
32c1fffd
SM
1973 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1974 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1975
ed497dd4
AS
19762011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1977
1978 * lread.c (readevalloop): Use correct code for NBSP.
1979 (read1): Likewise. (Bug#9608)
1980
b2bf61aa
MA
19812011-09-25 Michael Albinus <michael.albinus@gmx.de>
1982
1983 * dbusbind.c (Fdbus_register_signal): When service is not
1984 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1985
32bbb17c
GM
19862011-09-25 Glenn Morris <rgm@gnu.org>
1987
1988 * buffer.c (truncate-lines): Doc fix.
1989
94e0933e
CY
19902011-09-24 Chong Yidong <cyd@stupidchicken.com>
1991
1992 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1993 (Fset_window_next_buffers): Doc fix.
1994
cddde921
GM
19952011-09-24 Glenn Morris <rgm@gnu.org>
1996
1997 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1998
1260aef1
PE
19992011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2000
25b4bfa0
PE
2001 Fix minor problems found by static checking.
2002 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2003 * indent.c (Fvertical_motion): Fix == vs = typo.
2004
e3cbd34b
EZ
20052011-09-24 Eli Zaretskii <eliz@gnu.org>
2006
a66cfb1c
SM
2007 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2008 Default value is now t. Doc fix.
6bf7006f 2009
e3cbd34b 2010 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2011 logic when moving up, not only when moving down. Fix the
e3cbd34b 2012 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2013 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2014
2015 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2016 CHARPOS is covered by a display string which includes newlines.
2017 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2018 is covered by a display string with embedded newlines.
2019
a3de0cbd
MA
20202011-09-24 Michael Albinus <michael.albinus@gmx.de>
2021
2022 * dbusbind.c (Fdbus_register_signal): Add match rule to
2023 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2024 (Fdbus_register_method, Vdbus_registered_objects_table):
2025 Fix docstring.
a3de0cbd 2026
b260039d
JM
20272011-09-24 Jim Meyering <meyering@redhat.com>
2028
32c1fffd 2029 do not ignore write error for any output size
b260039d
JM
2030 The previous change was incomplete.
2031 While it makes emacs --batch detect the vast majority of stdout
2032 write failures, errors were still ignored whenever the output size is
2033 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2034 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2035 && echo FAIL: ignored write error
2036 FAIL: ignored write error
2037 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2038 && echo FAIL: ignored write error
2039 FAIL: ignored write error
2040 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2041
8eca8a7c
AS
20422011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2043
2044 * emacs.c (Fkill_emacs): In noninteractive mode exit
2045 non-successfully if a write error occurred on stdout. (Bug#9574)
2046
3341db62
EZ
20472011-09-21 Eli Zaretskii <eliz@gnu.org>
2048
2049 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2050 the xassert test.
2051
2052 * dispextern.h (struct it): Update the comment documenting what
2053 can it->OBJECT be.
2054
8c203dbf
EZ
20552011-09-20 Eli Zaretskii <eliz@gnu.org>
2056
2057 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2058 a display string, extend search for cursor position to end of row.
2059 (find_row_edges): If the row ends in a newline from a display
2060 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2061 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2062 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2063 non-empty line. Fixes confusing cursor motion with arrow keys at
2064 the beginning of a line that starts with whitespace.
8c203dbf 2065
a4824228
LMI
20662011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2067
2068 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2069 (bug#9493).
2070
33ed493b
CY
20712011-09-18 Chong Yidong <cyd@stupidchicken.com>
2072
2073 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2074 boolean (Bug#9154).
2075
56cd55c8
EZ
20762011-09-18 Eli Zaretskii <eliz@gnu.org>
2077
2078 * xdisp.c (display_line): Record maximum and minimum buffer
2079 positions even if no glyphs were produced (e.g., by a zero-width
2080 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2081 buffer positions that will be removed from the glyph row because
2082 they don't fit.
c02dcedf
EZ
2083 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2084 column is beyond frame width: don't subtract 1 "pixel" when
2085 computing width of the stretch.
3e62b7e0
EZ
2086 (reseat_at_next_visible_line_start): Undo the change made on
2087 2011-09-17 that saved paragraph information and restored it after
2088 the call to `reseat'. (Bug#9545)
56cd55c8 2089
5ed99d36 20902011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2091
2092 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2093 and turn window cursor on if cleared (Bug#9415).
2094
5ed99d36 20952011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2096
2097 * search.c (boyer_moore): Take unibyte characters from pattern
2098 literally. (Bug#9458)
2099
9bade7b2
EZ
21002011-09-18 Eli Zaretskii <eliz@gnu.org>
2101
2102 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2103
e5e9d610
PE
21042011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2105
87e4427a
PE
2106 Fix minor problem found by static checking.
2107 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2108 initialized, to pacify gcc -Wuninitialized.
2109
e5e9d610
PE
2110 * fileio.c: Report proper errno when syscall falls.
2111 (Finsert_file_contents): Save and restore errno,
2112 so that report_file_error outputs the correct diagnostic.
2113 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2114
a1674f0b
EZ
21152011-09-18 Eli Zaretskii <eliz@gnu.org>
2116
2117 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2118
fbfb6dd4
EZ
21192011-09-17 Eli Zaretskii <eliz@gnu.org>
2120
2121 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2122 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2123
bb187662
EZ
21242011-09-17 Eli Zaretskii <eliz@gnu.org>
2125
1137e8b8 2126 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2127 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2128
2129 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2130 (bidi_find_paragraph_start): Search back for paragraph beginning
2131 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2132 (bidi_move_to_visually_next): Only trigger paragraph-related
2133 computations when the last character is a newline or at EOB, not
2134 just any NEUTRAL_B. (Bug#9470)
2135
bb187662
EZ
2136 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2137 truncated lines if point is covered by a display string. (Bug#9524)
2138
2e621251
PE
21392011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2140
2141 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2142 (cons_to_x_long): New function.
2143 (lisp_data_to_selection_data): Use it. Correct the test for
2144 short-versus-long data; it was negated. Break out of vector
2145 loop, for efficiency, when a long datum is discovered.
2146
91a15bc6
SM
21472011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2148
2149 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2150
b41c3a35
EZ
21512011-09-16 Eli Zaretskii <eliz@gnu.org>
2152
2153 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2154 GCC PR/17406) by declaring this function with external scope.
2155
7812ba2d
PE
21562011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2157
2158 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2159 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2160
cf7edc2a
AS
21612011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2162
2163 * editfns.c (Fformat): Correctly handle text properties on "%%".
2164
bd01620e
EZ
21652011-09-15 Eli Zaretskii <eliz@gnu.org>
2166
2167 * xterm.c (x_draw_composite_glyph_string_foreground):
2168 * w32term.c (x_draw_composite_glyph_string_foreground):
2169 * term.c (encode_terminal_code):
2170 * composite.c (composition_update_it, get_composition_id):
2171 * xdisp.c (get_next_display_element)
2172 (fill_composite_glyph_string): Add comments about special meaning
2173 of TAB characters in a composition.
2174
a02719a3
PE
21752011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2176
2177 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2178 This occurs when processing a multibyte format.
2179 Problem reported by Wolfgang Jenker.
a02719a3 2180
72589a3c
JB
21812011-09-15 Johan Bockgård <bojohan@gnu.org>
2182
2183 * xdisp.c (try_cursor_movement): Only check for exact match if
2184 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2185
1c14176c
PE
21862011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2187
2188 Remove unused external symbols.
2189 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2190 * xdisp.c (calc_pixel_width_or_height): Now static.
2191 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2192 * indent.c (check_display_width):
2193 * w32term.c: Fix comment to match code.
2194 * xterm.c, xterm.h (x_catching_errors): Remove.
2195
d2eea5b5
PE
21962011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2197
2198 * xselect.c: Use signed conversions more consistently (Bug#9498).
2199 (selection_data_to_lisp_data): Assume incoming selection data are
2200 signed integers, not unsigned. This is to be consistent with
2201 outgoing selection data, which was modified to use signed integers
2202 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2203 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2204 expects long, not unsigned long.
2205
46888499
EZ
22062011-09-14 Eli Zaretskii <eliz@gnu.org>
2207
2208 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2209 computation of loop end. Reported by Johan Bockgård
2210 <bojohan@gnu.org>.
2211
ef8ef9fb
CY
22122011-09-13 Chong Yidong <cyd@stupidchicken.com>
2213
2214 * frame.c (Fother_visible_frames_p): Function deleted.
2215
fa819fed
EZ
22162011-09-12 Eli Zaretskii <eliz@gnu.org>
2217
2218 * indent.c (compute_motion): Process display vector front to back
2219 rather than the other way around. (Bug#2496)
2220
2ba8e008
SM
22212011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2222
2223 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2224
20f53c69
CY
22252011-09-11 Chong Yidong <cyd@stupidchicken.com>
2226
2227 * minibuf.c (Fread_from_minibuffer): Doc fix.
2228
d562d7a4
EZ
22292011-09-11 Eli Zaretskii <eliz@gnu.org>
2230
2231 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2232 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2233
1c4d7f3d
LMI
22342011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2235
2236 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2237 value for non-existent files.
2238
b885bf36
EZ
22392011-09-11 Eli Zaretskii <eliz@gnu.org>
2240
2241 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2242 set its "size" to -1. This will set the modtime_size field of
2243 the corresponding buffer to -1, which is what
2244 verify-visited-file-modtime expects for files that do not exist.
2245 (Bug#9139)
2246
6612f0bf
PE
22472011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2248
2249 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2250 here ...
2251 * lisp.h: ... from here. push_key_description is no longer
2252 defined in keyboard.c, so its declaration should not be in
2253 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2254 logically belongs with push_key_description.
2255
dfb3f755
PE
22562011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2257
2258 * buffer.h: Include <sys/types.h> instead of <time.h>.
2259 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2260 Problem reported by Herbert J. Skuhra.
2261
3134906c
LMI
22622011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2263
2264 * xml.c (parse_region): Make the parsing work for
2265 non-comment-starting XML files again (bug#9144).
2266
8d903f4e
AS
22672011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2268
2269 * image.c (gif_load): Fix calculation of bottom and right corner.
2270 (Bug#9468)
2271
80ad64f4
EZ
22722011-09-10 Eli Zaretskii <eliz@gnu.org>
2273
2274 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2275 redisplay in small windows.
2276
208a048d
EZ
22772011-09-09 Eli Zaretskii <eliz@gnu.org>
2278
2279 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2280
9b1c252e
MR
22812011-09-08 Martin Rudalics <rudalics@gmx.at>
2282
2283 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2284 Operate on live windows only.
2285
2949f33b
JB
22862011-09-08 Juanma Barranquero <lekktu@gmail.com>
2287
2288 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2289
e08dcafd
EZ
22902011-09-07 Eli Zaretskii <eliz@gnu.org>
2291
2292 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2293 only under bidi iteration.
2294
115b96bd
JD
22952011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2296
2297 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2298
c8199d0f
PE
22992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2300
2301 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2302 Without this fix, the command to link temacs failed due to an
2303 undefined symbol __builtin_isnan. This is because
2304 /usr/include/iso/math_c99.h #defines isnan(x) to
2305 __builtin_isnan(x), but the bundled gcc, which identifies itself
2306 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2307 a __builtin_isnan.
2308 * floatfns.c (isnan): #undef, and then #define to a clone of
2309 what's in data.c.
2310 (Fisnan): Always define, since it's always available now.
2311 (syms_of_floatfns): Always define isnan at the Lisp level.
2312
e39b275c 23132011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2314
2315 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2316
b2db44d9 23172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2318
f4af5137 2319 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2320 The previous code assumed that file offsets (off_t values) fit in
2321 EMACS_INT variables, which is not true on typical 32-bit hosts.
2322 The code messed up by falsely reporting buffer overflow in cases
2323 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2324 when "big" contains more than 2**29 bytes, even though this
2325 inserts just one byte and does not overflow the buffer.
2326 (Finsert_file_contents): Store file offsets as off_t
2327 values, not as EMACS_INT values. Check for overflow when
2328 converting between EMACS_INT and off_t. When checking for
2329 buffer overflow or for overlap, take the offsets into account.
2330 Don't use EMACS_INT for small values where int suffices.
2331 When checking for overlap, fix a typo: ZV was used where
2332 ZV_BYTE was intended.
2333 (Fwrite_region): Don't assume off_t fits into 'long'.
2334 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2335
ecfc0a49
MA
23362011-09-05 Michael Albinus <michael.albinus@gmx.de>
2337
2338 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2339
6511acf2 23402011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2341
0999621a 2342 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2343
2344 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2345 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2346 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2347 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2348 (modify_event_symbol): Do not assume that the length of
2349 name_alist_or_stem is safe to alloca and fits in int.
2350 (Fexecute_extended_command): Likewise for function name and binding.
2351 (Frecursion_depth): Wrap around reliably on integer overflow.
2352 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2353 since some callers pass EMACS_INT values.
2354 (Fsingle_key_description): Don't crash if symbol name contains more
2355 than MAX_ALLOCA bytes.
2356 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2357 (get_minibuffer): Arg is now EMACS_INT, not int.
2358 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2359 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2360 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2361
2be7d702
PE
2362 * dbusbind.c (signature_cat): New function.
2363 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2364 Do not overrun buffer; instead, report string overflow.
2365
9d1df220
PE
2366 * dispnew.c (add_window_display_history): Don't overrun buffer.
2367 Truncate instead; this is OK since it's just a log.
2368
33ef5c64
PE
2369 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2370 even if the time zone offset is outlandishly large.
2371 Don't mishandle offset == INT_MIN.
2372
66c6fdd5
PE
2373 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2374 when creating daemon; the previous buffer-overflow check was incorrect.
2375
d749b01b
PE
2376 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2377 which has the guts of the old verror function.
2378
b5cd1905
PE
2379 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2380 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2381
6e1a67fb
PE
2382 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2383 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2384 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2385 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2386 length of string rather than counting it via multiple sprintfs;
2387 that's simpler and more reliable.
c21721cc
PE
2388 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2389 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2390 sprintf, in case result does not fit in int.
2391
c57b67fc
PE
2392 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2393 (fontset_from_font): Print it.
2394
8a401434
PE
2395 * frame.c (tty_frame_count): Now printmax_t, not int.
2396 (make_terminal_frame, set_term_frame_name): Print it.
2397 (x_report_frame_params): In X, window IDs are unsigned long,
2398 not signed long, so print them as unsigned.
2399 (validate_x_resource_name): Check for implausibly long names,
2400 and don't assume name length fits in 'int'.
2401 (x_get_resource_string): Don't blindly alloca invocation name;
2402 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2403 not fit in int.
2404
6e1a67fb
PE
2405 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2406 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2407 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2408
0df02bf3
PE
2409 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2410 Use esprintf, not sprintf, in case result does not fit in int.
2411
48e30793
PE
2412 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2413 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2414 it as a large positive number.
2415 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2416 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2417
a66ff6d8
PE
2418 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2419 in case result does not fit in int.
2420
aca216ff
PE
2421 * print.c (float_to_string): Detect width overflow more reliably.
2422 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2423 buffer overrun. Don't assume list length fits in 'int'. Treat
2424 print length of 0 as 0, not as infinity; to be consistent with other
2425 uses of print length in this function. Don't overflow print length
2426 index. Don't assume hash table size fits in 'long', or that
2427 vectorlike size fits in 'unsigned long'.
2428
31c286f7
PE
2429 * process.c (make_process): Use printmax_t, not int, to format
2430 process-name gensyms.
2431
55e5faa1
PE
2432 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2433
80f2e268
PE
2434 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2435 to avoid potential buffer overrun.
2436
670741ab
PE
2437 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2438 if X resource line is longer than 512 bytes.
2439
b7163a50
PE
2440 * xfns.c (x_window): Make sprintf buffer a bit bigger
2441 to avoid potential buffer overrun.
2442
ae58ff1f
PE
2443 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2444
c43c8a6a
PE
2445 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2446
3f8236f4
PE
24472011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2448
53e9fe90 2449 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2450 Without these, Emacs silently mishandles large integers sometimes.
2451 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2452 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2453
6511acf2
PE
2454 * xdisp.c (try_window_id): Check Emacs fixnum range before
2455 converting to 'int'.
806add1d 2456
6511acf2 2457 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2458 Check that an Emacs fixnum is in range before assigning it to 'int'.
2459 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2460 values converted from Emacs fixnums.
2461 (Frecenter): Don't wrap around a line count if it is out of 'int'
2462 range; instead, treat it as an extreme value.
2463 (Fset_window_configuration, compare_window_configurations):
2464 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2465
6511acf2
PE
2466 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2467 that can exceed INT_MAX. Check that EMACS_INT value is in range
2468 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2469 (match_limit): Don't assume that a fixnum can fit in 'int'.
2470
6511acf2 2471 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2472 exceed INT_MAX.
2473
6511acf2 2474 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2475 (Fvertical_motion): Don't wrap around LINES values that don't fit
2476 in 'int'. Instead, treat them as extreme values. This is good
2477 enough for windows, which can't have more than INT_MAX lines anyway.
2478
fcb901a7
LMI
24792011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2480
0f2f6b6d
LMI
2481 * Require libxml/parser.h to avoid compilation warning.
2482
fcb901a7
LMI
2483 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2484
2485 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2486 since this reportedly can destroy thread storage.
2487
6e20a0d4
CY
24882011-08-30 Chong Yidong <cyd@stupidchicken.com>
2489
2490 * syntax.c (find_defun_start): Update all cache variables if
2491 exiting early (Bug#9401).
2492
148ae00e
EZ
24932011-08-30 Eli Zaretskii <eliz@gnu.org>
2494
f6cfbd8f
EZ
2495 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2496
148ae00e
EZ
2497 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2498 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2499 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2500
2501 * term.c (tty_append_glyph): New function.
2502 (produce_stretch_glyph): Static function and its prototype deleted.
2503
a66cfb1c
SM
2504 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2505 Add prototypes.
148ae00e 2506
c4a07a4c
PE
25072011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2508
2509 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2510 when checking :margin (Bug#9390).
2511 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2512 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2513 so that the name doesn't mislead. All uses changed.
2514
6bc8cd65
JB
25152011-08-28 Johan Bockgård <bojohan@gnu.org>
2516
2517 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2518 set_tty_hooks.
2519
dca4927e
EZ
25202011-08-27 Eli Zaretskii <eliz@gnu.org>
2521
2522 * xdisp.c (move_it_to): Don't bail out early when reaching
2523 position beyond to_charpos, if we are scanning backwards.
2524 (move_it_vertically_backward): When DY == 0, make sure we get to
2525 the first character in the line after the newline.
2526
f2cad773
PE
25272011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2528
2529 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2530 (ccl_driver): Do not generate an out-of-range pointer.
2531 (Fccl_execute_on_string): Remove unnecessary check for
2532 integer overflow, noted by Stefan Monnier in
2533 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2534 Remove a FIXME that didn't need fixing.
2535 Simplify the newly-introduced buffer reallocation code.
2536
0cae2cdb
JB
25372011-08-27 Juanma Barranquero <lekktu@gmail.com>
2538
2539 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2540
5fc295a4 25412011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2542
70c60eb2 2543 Integer and memory overflow issues (Bug#9196).
726e0ab1 2544
d31850da
PE
2545 * doc.c (get_doc_string): Rework so that
2546 get_doc_string_buffer_size is the actual buffer size, rather than
2547 being 1 less than the actual buffer size; this makes xpalloc more
2548 convenient.
2549
a69fbedb
PE
2550 * image.c (x_allocate_bitmap_record, cache_image):
2551 * xselect.c (Fx_register_dnd_atom):
2552 Simplify previous changes by using xpalloc.
2553
fe5c5d37
PE
2554 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2555 since either will do and ptrdiff_t is convenient with xpalloc.
2556
0065d054
PE
2557 * charset.c (charset_table_size)
2558 (struct charset_sort_data.priority): Now ptrdiff_t.
2559 (charset_compare): Don't overflow if priorities differ greatly.
2560 (Fsort_charsets): Don't assume list length fits in int.
2561 Check for size-calculation overflow when allocating sort data.
2562 (syms_of_charset): Allocate an initial charset table that is
2563 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2564
2565 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2566
2567 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2568 The actual value is always <= INT_MAX, and leaving it unsigned made
2569 overflow checking harder.
2570
2571 * dispextern.h (struct glyph_matrix.rows_allocated)
2572 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2573 with xpalloc. The values are still always <= INT_MAX.
2574
2575 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2576
2577 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2578 (SAFE_NALLOCA): New macro.
2579
2580 * region-cache.c (struct boundary.pos, find_cache_boundary)
2581 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2582 (set_cache_region, invalidate_region_cache)
2583 (revalidate_region_cache, know_region_cache, region_cache_forward)
2584 (region_cache_backward, pp_cache):
2585 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2586 so that ptrdiff_t * can be passed to xpalloc.
2587 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2588 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2589 (pp_cache): Don't assume cache_len fits in int.
2590 * region-cache.h: Adjust extern decls to match.
2591
2592 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2593 EMACS_INT, since either will do, for xpalloc.
2594
2595 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2596 (xnmalloc, xnrealloc, xpalloc): New functions.
2597
726e0ab1
PE
2598 * bidi.c (bidi_shelve_header_size): New constant.
2599 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2600 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2601
51f30bc5 2602 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2603 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2604 (overlay_strings):
2605 Don't update size of array until after memory allocation succeeds,
2606 because xmalloc/xrealloc may not return.
0065d054
PE
2607 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2608 now that we have proper integer overflow checking.
2609 (record_overlay_string, overlay_strings): Catch overflows when
2610 calculating size of overlay_str_buf.
726e0ab1 2611
0065d054
PE
2612 * callproc.c (Fcall_process): Check for size overflow when
2613 calculating size of args2.
2614 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2615 Normally we prefer signed values, but sticking with ptrdiff_t would
2616 require adding more-complicated checks.
726e0ab1
PE
2617
2618 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2619 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2620 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2621 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2622
2623 * character.c (Fstring): Check for size-calculation overflow.
2624
2625 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2626 unnecessary integer overflow. Check for size overflow.
2627 (encode_coding_object): Don't update size until xmalloc succeeds.
2628
2629 * composite.c (get_composition_id): Check for overflow in glyph
2630 length calculations.
2631
2632 Integer and memory overflow fixes for display code.
2633 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2634 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2635 (scrolling_window): Check for overflow in size calculations.
2636 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2637 Don't assume glyph table len fits in int.
2638 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2639 (row_table_size): Now ptrdiff_t, not int.
2640 (scrolling_window): Avoid overflow in size calculations.
2641 Don't update size until allocation succeeds.
2642 * fns.c (concat): Check for overflow in size calculations.
2643 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2644 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2645 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2646
2647 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2648 (get_doc_string): Check for size calculation overflow.
2649 Don't update size until allocation succeeds.
2650 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2651 EMACS_INT, where ptrdiff_t will do.
2652 (Fsubstitute_command_keys): Check for string overflow.
2653
2654 * editfns.c (set_time_zone_rule): Don't assume environment length
2655 fits in int.
2656 (message_length): Now ptrdiff_t, not int.
2657 (Fmessage_box): Don't update size until allocation succeeds.
2658 Don't assume message length fits in int.
2659 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2660
0065d054
PE
2661 * emacs.c (main): Do not reallocate argv, since there is a null at
2662 the end that can be overwritten, and this way there's no need to
2663 worry about size-calculation overflow.
2664 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2665
2666 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2667 alloc succeeds.
2668 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2669
2670 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2671 (x_set_scroll_bar_width, x_figure_window_size):
2672 Check for integer overflow.
2673 (x_set_alpha): Do not assume XINT fits in int.
2674
2675 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2676 This is for the members text_lines, text_cols, total_lines, total_cols,
2677 where the system imposes an 'int' limit.
2678
2679 * fringe.c (Fdefine_fringe_bitmap):
2680 Don't update size until alloc works.
2681
2682 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2683 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2684
2685 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2686 Check for size-calculation overflow.
2687 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2688 do, as we prefer signed integers.
2689 (id_to_widget.max_size, id_to_widget.used)
2690 (xg_store_widget_in_map, xg_remove_widget_from_map)
2691 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2692 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2693 Use and return ptrdiff_t, not int.
2694 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2695 * gtkutil.h: Change prototypes to match the above.
2696
2697 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2698 are duplicate now that they've been promoted to lisp.h.
2699 (x_allocate_bitmap_record, x_alloc_image_color)
2700 (make_image_cache, cache_image, xpm_load):
2701 Don't update size until alloc is done.
2702 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2703 (x_detect_edges):
3256efce 2704 Check for size calculation overflow.
726e0ab1
PE
2705 (ct_colors_allocated_max): New constant.
2706 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2707 overflow.
3256efce 2708
726e0ab1
PE
2709 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2710 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2711 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2712 Use ptrdiff_t, not int, to count maps.
2713 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2714 calculations. Don't update size until allocation succeeds.
2715 Redo calculations to avoid overflow.
726e0ab1
PE
2716 * keyboard.h: Change prototypes to match the above.
2717
2718 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2719 to count maps.
2720 (current_minor_maps): Check for size calculation overflow.
2721 * keymap.h: Change prototypes to match the above.
2722
2723 * lread.c (read1, init_obarray): Don't update size until alloc done.
2724
2725 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2726 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2727
726e0ab1
PE
2728 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2729 Now ptrdiff_t, not int.
2730 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2731 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2732
2733 * process.c (Fnetwork_interface_list): Check for overflow
2734 in size calculation.
2735
2736 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2737
2738 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2739 overflow. Don't bother calling xmalloc when xrealloc will do.
2740
2741 * search.c (Freplace_match): Check for size calculation overflow.
2742 (Fset_match_data): Don't assume list lengths fit in 'int'.
2743
2744 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2745 for command line length. Do not attempt to address one before the
2746 beginning of an array, as that's not portable.
2747
2748 * term.c (max_frame_lines): Remove; unused.
2749 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2750 not int.
2751 (encode_terminal_code, calculate_costs): Check for size
2752 calculation overflow.
2753 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2754 table lengths and related sizes. Don't update size until alloc
2755 done. Redo calculations to avoid overflow.
2756 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2757
2758 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2759 subtracting pointers.
2760 (gobble_line): Check for overflow more carefully. Don't update size
2761 until alloc done.
2762
2763 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2764 Don't update size until alloc done.
2765 Redo size calculations to avoid overflow.
2766 Check for size calculation overflow.
0065d054 2767 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2768
2769 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2770 Use ptrdiff_t, not int, for sizes.
2771 (store_mode_line_noprop_char): Don't update size until alloc done.
2772
0065d054
PE
2773 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2774 Use ptrdiff_t, not int, for sizes.
2775 (Finternal_make_lisp_face, cache_face):
2776 Check for size calculation overflow.
2777 (cache_face): Treat size calculation overflows as if they were
2778 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2779
2780 * xfns.c (x_encode_text, x_set_name_internal)
2781 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2782 sizes, since they can exceed INT_MAX in size. Check for size
2783 calculation overflow.
2784
0065d054
PE
2785 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2786 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2787 Don't update size until alloc done.
2788
0065d054 2789 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2790 as sprintf is limited to int lengths.
1d526e2f 2791
252c5ee1
PE
2792 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2793 (X_LONG_MIN): New macros.
864d7ce7
PE
2794 Use them to make the following changes clearer.
2795 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2796 This change doesn't affect the value now, but it may help remind
2797 future maintainers not to raise the value too much later.
2798 (SELECTION_QUANTUM): Remove, replacing with ...
2799 (selection_quantum): ... new function, which avoids overflow.
2800 All uses changed.
2801 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2802 assumption that selection length fits in 'int'.
2803 (x_reply_selection_request, x_handle_selection_request)
2804 (x_get_window_property, receive_incremental_selection)
2805 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2806 (lisp_data_to_selection_data, clean_local_selection_data):
2807 Use ptrdiff_t, not int, to record length of selection.
2808 (x_reply_selection_request, x_get_window_property)
2809 (receive_incremental_selection, x_property_data_to_lisp):
2810 Redo calculations to avoid overflow.
2811 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2812 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2813 something.
2814 (x_get_window_property, receive_incremental_selection)
2815 (lisp_data_to_selection_data, x_property_data_to_lisp):
2816 Check for size-calculation overflow.
2817 (x_get_window_property, receive_incremental_selection)
2818 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2819 Don't store size until memory allocation succeeds.
2820 (x_get_window_property): Plug memory leak on memory exhaustion.
2821 Don't double-block input; malloc is safe here. Don't assume 2**34
2822 - 4 fits in unsigned long. Add an xassert to check
2823 XGetWindowProperty overflow. Be more careful about overflow
2824 calculations, and distinguish size from memory overflow better.
2825 (receive_incremental_selection): When tracing, don't assume
2826 unsigned int is less than INT_MAX.
2827 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2828 harmful) conversions of unsigned short to int.
2829 (lisp_data_to_selection_data): Don't assume that integers
2830 in the range -65535 through -1 fit in an X unsigned short.
2831 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2832 result parameters unless successful. Rely on cons_to_unsigned
2833 to report problems with elements; the old code wasn't right anyway.
2834 (x_check_property_data): Check for int overflow; we cannot use
2835 a wider type due to X limits.
2836 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2837
726e0ab1 2838 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2839
0065d054
PE
2840 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2841 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2842 (x_color_cells): Don't store size until memory allocation succeeds.
2843 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2844 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2845 (x_term_init): Don't assume length fits in int (sprintf is limited
2846 to int size).
bc18e09d 2847
ebfa62c0
PE
2848 Use ptrdiff_t for composition IDs.
2849 * character.c (lisp_string_width):
2850 * composite.c (composition_table_size, n_compositions)
2851 (get_composition_id, composition_gstring_from_id):
2852 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2853 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2854 * window.c (Frecenter):
2855 Use ptrdiff_t, not int, for composition IDs.
2856 * composite.c (get_composition_id): Check for integer overflow.
2857 * composite.h: Adjust prototypes to match the above changes.
2858
d3411f89
PE
2859 Use ptrdiff_t for hash table indexes.
2860 * category.c (hash_get_category_set):
2861 * ccl.c (ccl_driver):
2862 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2863 * coding.c (coding_system_charset_list, detect_coding_system):
2864 * coding.h (struct coding_system.id):
2865 * composite.c (get_composition_id, gstring_lookup_cache):
2866 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2867 * image.c (xpm_get_color_table_h):
2868 * lisp.h (hash_lookup, hash_put):
2869 * minibuf.c (Ftest_completion):
2870 Use ptrdiff_t for hash table indexes, not int (which is too
2871 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2872 32-bit --with-wide-int hosts).
2873
e097a6fa
PE
2874 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2875 Add a FIXME comment about memory leaks.
2876 (syms_of_charset): Don't assume xmalloc returns.
2877
5637687f
PE
2878 Don't assume that stated character widths fit in int.
2879 * character.c (Fchar_width, c_string_width, lisp_string_width):
2880 * character.h (CHAR_WIDTH):
2881 * indent.c (MULTIBYTE_BYTES_WIDTH):
2882 Use sanitize_char_width to avoid undefined and/or bad behavior
2883 with outlandish widths.
a66cfb1c 2884 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2885 now that we have two such functions. All uses changed.
2886 (sanitize_char_width): New inline function.
2887
a2271ba2
PE
2888 Don't assume that tab-width fits in int.
2889 * character.h (sanitize_width): New inline function.
2890 (SANE_TAB_WIDTH): New macro.
2891 (ASCII_CHAR_WIDTH): Use it.
2892 * indent.c (sane_tab_width): Remove. All uses replaced by
2893 SANE_TAB_WIDTH (current_buffer).
2894 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2895
18c52557
PE
2896 * fileio.c: Integer overflow issues with file modes.
2897 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2898
caeeedc1
PE
2899 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2900 Remove unreachable code.
2901 (read_hex, load_charset_map_from_file): Check for integer overflow.
2902
6df6ae42 2903 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2904 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2905 (x_send_scroll_bar_event): Likewise. Check that the size does not
2906 exceed limits imposed by XClientMessageEvent, as well as the usual
2907 ptrdiff_t and size_t limits.
2908
b13995db
PE
2909 * keyboard.c: Overflow, signedness and related fixes.
2910 (make_lispy_movement): Use same integer type in forward decl
2911 that is used in the definition.
2912 (read_key_sequence, keyremap_step):
2913 Change bufsize argument back to int, undoing my 2011-03-30 change.
2914 We prefer signed types, and int is wide enough here.
2915 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2916 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2917 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2918 length, not size_t. Use ptrdiff_t for index, not int.
2919 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2920 possibility of integer overflow.
2921
13464394
PE
2922 Overflow, signedness and related fixes for images.
2923
2924 * dispextern.h (struct it.stack[0].u.image.image_id)
2925 (struct_it.image_id, struct image.id, struct image_cache.size)
2926 (struct image_cache.used, struct image_cache.ref_count):
2927 * gtkutil.c (update_frame_tool_bar):
2928 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2929 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2930 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2931 * nsmenu.m (update_frame_tool_bar):
2932 * xdisp.c (calc_pixel_width_or_height):
2933 * xfns.c (image_cache_refcount):
2934 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2935 on typical 64-bit hosts.
2936
2937 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2938 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2939 Omit unnecessary casts to int.
2940 (parse_image_spec): Check that integers fall into 'int' range
2941 when the callers expect that.
2942 (image_ascent): Redo ascent calculation to avoid int overflow.
2943 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2944 (lookup_image): Remove unnecessary tests.
2945 (xbm_image_p): Locals are now of int, not EMACS_INT,
2946 since parse_image_check makes sure they fit into int.
2947 (png_load, gif_load, svg_load_image):
2948 Prefer int to unsigned where either will do.
2949 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2950 old tiff_error_handler and tiff_warning_handler.
2951 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2952 stack buffer overflows. It uses only the features of vsnprintf
2953 that are common to both POSIX and native Microsoft.
2954 (tiff_error_handler, tiff_warning_handler): Use it.
2955 (tiff_load, gif_load, imagemagick_load_image):
2956 Don't assume :index value fits in 'int'.
2957 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2958 (imagemagick_load_image): Check that crop parameters fit into
2959 the integer types that MagickCropImage accepts. Don't assume
2960 Vimagemagick_render_type has a nonnegative value. Don't assume
2961 size_t fits in 'long'.
2962 (gs_load): Use printmax_t to print the widest integers possible.
2963 Check for integer overflow when computing image height and width.
2964
c11821d4
EZ
29652011-08-26 Eli Zaretskii <eliz@gnu.org>
2966
2967 * xdisp.c (redisplay_window): Don't force window start if point
2968 will be invisible in the resulting window. (Bug#9324)
2969
0c95fcf7
EZ
29702011-08-25 Eli Zaretskii <eliz@gnu.org>
2971
2972 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2973 the display spec is of the form `(space ...)'.
2974 (handle_display_spec): Return the value returned by
2975 handle_single_display_spec, not just 1 or zero.
2976 (handle_single_display_spec): If the display spec is of the form
2977 `(space ...)', and specifies display in the text area, return 2
2978 rather than 1.
fee65a97 2979 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2980 accurately, and prefer exact match for point under bidi.
2981 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2982
2983 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2984 into disp_prop; all users changed.
2985
2986 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2987 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2988 for the text covered by the display property.
2989
e4ed06f1
CY
29902011-08-25 Chong Yidong <cyd@stupidchicken.com>
2991
2992 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2993 Change return value to nil.
2994 (Frecord_buffer): Delete unused function.
2995
f67cdd7f
EZ
29962011-08-24 Eli Zaretskii <eliz@gnu.org>
2997
5980d4c6
EZ
2998 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2999 buffers, return left-to-right.
8610fe8b
EZ
3000 (set_cursor_from_row): Consider candidate row a win if its glyph
3001 represents a newline and point is on that newline. Fixes cursor
3002 positioning on the newline at EOL of R2L text within L2R
3003 paragraph, and vice versa.
3004 (try_cursor_movement): Check continued rows, in addition to
3005 continuation rows. Fixes unwarranted scroll when point enters a
3006 continued line of R2L text within an L2R paragraph, or vice versa.
3007 (cursor_row_p): Consider the case of point being equal to
3008 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3009 from the end of a short line to the beginning of a continued line
3010 of R2L text within L2R paragraph.
3011 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3012 composed characters.
5980d4c6 3013
f67cdd7f
EZ
3014 * bidi.c (bidi_check_type): Use xassert.
3015 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3016 members.
3017
bca633fb
EZ
30182011-08-23 Eli Zaretskii <eliz@gnu.org>
3019
3020 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3021 a character.
3022
4a5885a7
CY
30232011-08-23 Chong Yidong <cyd@stupidchicken.com>
3024
3025 * nsfont.m (ns_otf_to_script): Fix typo.
3026
0902a04e
KH
30272011-08-22 Kenichi Handa <handa@m17n.org>
3028
3029 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3030 extra slot even if the purpose is char-code-property-table.
3031
1a2e6670
EZ
30322011-08-23 Eli Zaretskii <eliz@gnu.org>
3033
8ddde651
EZ
3034 * xdisp.c (redisplay_window): When computing centering_position,
3035 account for the height of the header line. (Bug#8874)
3036
425cc014
EZ
3037 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3038 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3039 candidate is selected by the mouse, and that candidate has a
3040 composed character under the mouse.
3041
1a2e6670
EZ
3042 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3043 coordinates reported by pos-visible-in-window-p for a composed
3044 character in column zero.
3045
8b76d6f8
SM
30462011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3047
3048 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3049
dac347dd
EZ
30502011-08-22 Eli Zaretskii <eliz@gnu.org>
3051
3052 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3053 consider it a hit if to_charpos is anywhere in the range of the
3054 composed buffer positions.
3055
e013fb34
CY
30562011-08-22 Chong Yidong <cyd@stupidchicken.com>
3057
3058 * image.c (gif_load): Don't assume that each subimage has the same
3059 dimensions as the base image. Handle disposal method that is
3060 "undefined" by the gif spec (Bug#9335).
3061
bd1ba3e8
CY
30622011-08-20 Chong Yidong <cyd@stupidchicken.com>
3063
3064 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3065 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3066
54a1215b
EZ
30672011-08-19 Eli Zaretskii <eliz@gnu.org>
3068
823564e5
EZ
3069 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3070 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3071 from an Org mode buffer to a Speedbar frame.
3072
54a1215b
EZ
3073 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3074 a composition, take its buffer position from IT->cmp_it.charpos.
3075 Fixes cursor positioning at the beginning of a line that begins
3076 with a composed character.
3077
9778ebcc
EZ
30782011-08-18 Eli Zaretskii <eliz@gnu.org>
3079
0be6ee06
EZ
3080 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3081 character bidirectional type, use STRONG_L instead. Fixes crashes
3082 in a buffer produced by `describe-categories'.
3083
9778ebcc
EZ
3084 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3085 members before the level stack, so they would be saved and
3086 restored when copying iterator state. Fixes incorrect reordering
3087 around TABs covered by display properties.
3088
156bffbe
AS
30892011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3090
6b02f655 3091 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3092
72ad093b
CY
30932011-08-17 Chong Yidong <cyd@stupidchicken.com>
3094
3095 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3096 (internal_condition_case_2, internal_condition_case_n):
3097 Remove unnecessary aborts (Bug#9081).
72ad093b 3098
35774242
EZ
30992011-08-17 Eli Zaretskii <eliz@gnu.org>
3100
3101 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3102 has no `load' handler, try opening the file locally. (Bug#9311)
3103
db76dd85
KB
31042011-08-16 Ken Brown <kbrown@cornell.edu>
3105
3106 * gmalloc.c: Expand comment.
3107
b215eee5
EZ
31082011-08-16 Eli Zaretskii <eliz@gnu.org>
3109
3110 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3111 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3112
a4579d33
KB
31132011-08-16 Ken Brown <kbrown@cornell.edu>
3114
3115 Fix memory allocation problems in Cygwin build (Bug#9273).
3116
3117 * unexcw.c ( __malloc_initialized): Declare external variable.
3118 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3119
8b76d6f8
SM
3120 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3121 New variables.
a4579d33
KB
3122 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3123 dumped emacs.
3124 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3125 in the static heap.
3126 [CYGWIN] (special_realloc): New function.
3127 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3128 requests to realloc storage in the static heap.
3129
3ebec551
PE
31302011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3131
3132 * bidi.c (bidi_initialize): Remove unused local.
3133
9fd8be00
EZ
31342011-08-15 Eli Zaretskii <eliz@gnu.org>
3135
6b02f655
SM
3136 * bidimirror.h:
3137 * biditype.h: Remove file.
3138 * makefile.w32-in ($(BLD)/bidi.$(O)):
3139 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3140
3141 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3142
3143 * chartab.c: Improve commentary for the uniprop_table API.
3144
32413314
EZ
3145 * bidi.c (bidi_paragraph_init): Support zero value of
3146 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3147 (bidi_initialize): Use uniprop_table instead of including
3148 biditype.h and bidimirror.h.
32413314 3149
9fd8be00
EZ
3150 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3151 coordinates of the iterator when restoring from ppos_it.
3152 (Bug#9296)
3153
5cf2b69b
KH
31542011-08-14 Kenichi Handa <handa@m17n.org>
3155
3156 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3157 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3158
daf17d00
EZ
31592011-08-14 Eli Zaretskii <eliz@gnu.org>
3160
3161 * xdisp.c (move_it_in_display_line_to): Don't invoke
3162 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3163 ppos_it. Fixes vertical cursor motion when line beginning is
3164 covered by an image. (Bug#9296)
3165
08e3161a
JD
31662011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3167
3168 * nsterm.h (ns_run_ascript): Declare.
3169 (NSAPP_DATA2_RUNASSCRIPT): Define.
3170
3171 * nsfns.m (as_script, as_result, as_status): New static variables.
3172 (ns_run_ascript): New function.
5e617bc2 3173 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3174 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3175 the event loop. Get status from as_status (Bug#7276).
3176
3177 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3178 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3179 the event loop (Bug#7276).
3180
a3720aa2
AS
31812011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3182
3183 * gnutls.c (QCgnutls_bootprop_priority)
3184 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3185 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3186 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3187 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3188 (QCgnutls_bootprop_verify_hostname_error)
3189 (QCgnutls_bootprop_callbacks_verify): Rename from
3190 Qgnutls_bootprop_..., all uses changed.
3191
3192 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3193 uses changed.
3194
0a0d27fb
PE
31952011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3196
19d5c50c
PE
3197 * xfaces.c (Qframe_set_background_mode): Now static.
3198 * dispextern.h (Qframe_set_background_mode): Remove decl.
3199
0a0d27fb
PE
3200 * process.c (Fnetwork_interface_info): Declare local only if needed.
3201
377538cb
JD
32022011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3203
3204 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3205 (Fnetwork_interface_list): Allocate in increments of bytes instead
3206 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3207 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3208 sockaddr.
3209 (struct ifflag_def): notrailers is smart on OSX.
3210 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3211 Get hardware address with getifaddrs if available.
3212
08fff70c
EZ
32132011-08-12 Eli Zaretskii <eliz@gnu.org>
3214
3215 * xdisp.c (iterate_out_of_display_property): xassert that
3216 IT->position is set to within IT->object's boundaries. Break from
3217 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3218 when IT->position is set up wrongly due to some bug.
3219 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3220 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3221 entry. Force push_it to save on the stack the current
3222 buffer/string position, to be restored by pop_it. Fix flags in
3223 the iterator structure wrt the object coming from a display
3224 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3225 properties. (Bug#9284)
3226
7be1c708 32272011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3228
7be1c708
CY
3229 * fontset.c (fontset_get_font_group): Add proper type checks.
3230 (Bug#9172)
aac0c6e3 3231
7be1c708 32322011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3233
7be1c708
CY
3234 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3235 and LC_VERSION_MIN_MACOSX.
3236 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3237 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3238
97bb72a6
EZ
32392011-08-08 Eli Zaretskii <eliz@gnu.org>
3240
3241 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3242 no-display-properties-and-no-overlays under bidi display.
3243 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3244 properties and overlays.
97bb72a6 3245
d5617611
CY
32462011-08-08 Chong Yidong <cyd@stupidchicken.com>
3247
37e11a63
CY
3248 * editfns.c (Fset_time_zone_rule): Document relationship with the
3249 setenv function.
3250
d5617611
CY
3251 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3252 the font entity extracted from the cache (Bug#8109).
3253
58872834
CY
32542011-08-07 Chong Yidong <cyd@stupidchicken.com>
3255
3256 * composite.c (autocmp_chars): Don't reset point. That is done by
3257 restore_point_unwind (Bug#5984).
3258
75bfc667
JL
32592011-08-07 Juri Linkov <juri@jurta.org>
3260
3261 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3262 to show the arg `TIME' instead of `TIMEVAL'.
3263
d1410150
EZ
32642011-08-06 Eli Zaretskii <eliz@gnu.org>
3265
3266 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3267 display property strides EOL and includes a newline, as in
3268 longlines-mode. (Bug#9254)
75b771e4
EZ
3269 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3270 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3271
3272 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3273 is non-zero, even if the data buffer is NULL. Fixes a crash in
3274 vertical-motion with longlines-mode. (Bug#9254)
3275
35928349
EZ
32762011-08-05 Eli Zaretskii <eliz@gnu.org>
3277
ec7cc85b
EZ
3278 * bidi.c <bidi_cache_total_alloc>: Now static.
3279 (bidi_initialize): Initialize bidi_cache_total_alloc.
3280
8b76d6f8 3281 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3282 cache. (Bug#9221)
3283
3284 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3285 amount allocated this far in `bidi_cache_total_alloc'.
3286 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3287 non-zero, only free the data buffer without restoring the cache
3288 contents. All callers changed.
3289
3290 * dispextern.h (bidi_unshelve_cache): Update prototype.
3291
3292 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3293 (move_it_in_display_line, move_it_to)
3294 (move_it_vertically_backward, move_it_by_lines): Replace the call
3295 to xfree to an equivalent call to bidi_unshelve_cache.
3296 (move_it_in_display_line_to): Fix logic of returning
412b6358 3297 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3298
e2e2423b
EZ
32992011-08-05 Eli Zaretskii <eliz@gnu.org>
3300
3301 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3302 came from a string character with a `cursor' property. (Bug#9229)
3303
ae9e757a
JD
33042011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3305
3306 * Makefile.in (LIB_PTHREAD): New variable.
3307 (LIBES): Add LIB_PTHREAD (Bug#9216).
3308
3309 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3310 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3311
213bd7f2
AS
33122011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3313
6b02f655 3314 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3315
99aaf75f
JD
33162011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3317
3318 * xterm.c (x_find_topmost_parent): New function.
3319 (x_set_frame_alpha): Find topmost parent window with
3320 x_find_topmost_parent and set the property there also (bug#9181).
3321 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3322
c74e9d86
PE
33232011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3324
3325 * callproc.c (Fcall_process): Avoid vfork clobbering
3326 the local vars buffer, coding_systems, current_dir.
3327
640c8776
SM
33282011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3329
3330 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3331
f26d0e4c
PE
33322011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3333
8a10d76c
PE
3334 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3335 so that it is not optimized away.
3336
f26d0e4c
PE
3337 * xdisp.c (compute_display_string_pos): Remove unused local.
3338
55439c61
EZ
33392011-08-02 Eli Zaretskii <eliz@gnu.org>
3340
3341 Fix slow cursor motion and scrolling in large buffers with
3342 selective display, like Org Mode buffers. (Bug#9218)
3343
3344 * dispextern.h (struct bidi_it): New member disp_prop_p.
3345
3346 * xdisp.c: Remove one-slot cache of display string positions.
3347 (compute_display_string_pos): Accept an additional argument
5e617bc2 3348 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3349 for a display string or property. If found, set DISP_PROP_P
3350 non-zero.
3351
3352 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3353 DISP_PROP_P, and pass it to compute_display_string_pos.
3354 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3355 non-zero. All callers of bidi_fetch_char changed.
3356
fb33fa43
SM
33572011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3358
3359 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3360
b099e063
DM
33612010-12-03 Don March <don@ohspite.net>
3362
3363 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3364 last character M-[char] is translated to ESC [char] (bug#7541).
3365
5cc7f7af
KH
33662011-08-02 Kenichi Handa <handa@m17n.org>
3367
d0fffa3f 3368 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3369
3370 * chartab.c (uniprop_table): Make it non-static.
3371
525d5e6e
EZ
33722011-08-01 Eli Zaretskii <eliz@gnu.org>
3373
3374 * xdisp.c (forward_to_next_line_start): Accept additional argument
3375 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3376 on the newline.
3377 (reseat_at_next_visible_line_start): Use the bidi iterator state
3378 returned by forward_to_next_line_start to restore the state of
3379 it->bidi_it after backing up to previous newline. (Bug#9212)
3380
31011111
AS
33812011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3382
3383 * regex.c (re_comp): Protoize.
3384 (re_exec): Fix return type.
3385 (regexec): Fix type of `ret'. (Bug#9203)
3386
476371c4
PE
33872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3388
e5d76069
PE
3389 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3390 This is needed if max-image-size is a floating-point number.
3391
9a79b20c
AS
33922011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3393
3394 * print.c (print_object): Print empty symbol as ##.
3395
3396 * lread.c (read1): Read ## as empty symbol.
3397
d8c2fa78
AA
33982011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3399
3400 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3401 setting frame foreground color (Bug#9175).
3402 (x_set_background_color): Likewise.
3403
ffe57a7a
AA
3404 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3405 contents (Bug#9176).
3406 (EmacsTooltip -init): Remove bezels and add shadows to
3407 tooltip windows.
3408
bf3492a5
AA
3409 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3410 or scroll bar (Bug#8470).
3411
d55e9c53
AA
3412 * nsfont.m (nsfont_open): Remove assignment to voffset and
3413 unnecessary vars hshink, expand, hd, full_height, min_height.
3414 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3415
3416 * nsterm.h (nsfont_info): Remove voffset field.
3417
d8c2fa78 34182011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3419
3420 Implement strike-through and overline on NextStep (Bug#8863).
3421
3422 * nsfont.m (nsfont_open): Use underline position provided by font,
3423 instead of hard-coded value of 2.
3424 (nsfont_draw): Call ns_draw_text_decoration instead.
3425
3426 * nsterm.h: Add declaration for ns_draw_text_decoration.
3427
3428 * nsterm.m (ns_draw_text_decoration): New function for drawing
3429 underline, overline, and strike-through.
3430 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3431 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3432 accommodate underlining, etc.
4843aac3 3433
4cc60b9b
EZ
34342011-07-28 Eli Zaretskii <eliz@gnu.org>
3435
bc7ece87
EZ
3436 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3437 default.
4cc60b9b 3438
476371c4
PE
34392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3440
66606eea
PE
3441 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3442 Without this fix, if a signal arrives just after memory fills up,
3443 'malloc' might be invoked reentrantly.
3444
476371c4
PE
3445 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3446 In other words, assume that every image size is allowed, on non-X
3447 hosts. This assumption is probably wrong, but it lets Emacs compile.
3448
f3fcc40d
AS
34492011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3450
3451 * regex.c (re_iswctype): Convert return values to boolean.
3452
350c992f
EZ
34532011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3454
3455 * xdisp.c (compute_display_string_pos): Don't use cached display
3456 string position if the buffer had its restriction changed.
3457 (Bug#9184)
3458
5266b4bb
PE
34592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3460
3461 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3462
2573a837 34632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3464
41f55ccd 3465 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3466
39e378da
PE
3467 * bidi.c: Integer size and overflow fixes.
3468 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3469 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3470 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3471 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3472 (bidi_find_other_level_edge):
3473 Use ptrdiff_t instead of EMACS_INT where either will do.
3474 This works better on 32-bit hosts configured --with-wide-int.
3475 (bidi_cache_ensure_space): Check for size-calculation overflow.
3476 Use % rather than repeated addition, for better worst-case speed.
3477 Don't set bidi_cache_size until after xrealloc returns, because it
3478 might not return.
3479 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3480 (bidi_cache_ensure_space): Also check that the bidi cache size
3481 does not exceed that of the largest Lisp string or buffer. See Eli
3482 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3483
5e927815
PE
3484 * alloc.c (__malloc_size_t): Remove.
3485 All uses replaced by size_t. See Andreas Schwab's note
3486 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3487
ca4aa935
PE
3488 * image.c: Improve checking for integer overflow.
3489 (check_image_size): Assume that f is nonnull, since
3490 it is always nonnull in practice. This is one less thing to
3491 worry about when checking for integer overflow later.
3492 (x_check_image_size): New function, which checks for integer
3493 overflow issues inside X.
3494 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3495 This removes the need for a memory_full check.
3496 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3497 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3498 (xbm_read_bitmap_data): Change locals back to 'int', since
3499 their values must fit in 'int'.
3500 (xpm_load_image, png_load, tiff_load):
3501 Invoke x_create_x_image_and_pixmap earlier,
3502 to avoid much needless work if the image is too large.
3503 (tiff_load): Treat overly large images as if
3504 x_create_x_image_and_pixmap failed, not as malloc failures.
3505 (gs_load): Use x_check_image_size.
3506
5f8f9cc2
PE
3507 * gtkutil.c: Omit integer casts.
3508 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3509 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3510
5adf60bc
PE
3511 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3512
c8907a93
PE
3513 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3514 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3515 would wrongly return t on a 64-bit host.
3516
e3c25c68
PE
3517 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3518 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3519 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3520 and therefore cause GCC to emit a bogus diagnostic in some cases.
3521
3f791afe
PE
3522 * image.c: Integer signedness and overflow and related fixes.
3523 This is not an exhaustive set of fixes, but it's time to
3524 record what I've got.
3525 (lookup_pixel_color, check_image_size): Remove redundant decls.
3526 (check_image_size): Don't assume that arbitrary EMACS_INT values
3527 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3528 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3529 (tiff_load, imagemagick_load_image):
3530 Check for overflow in size calculations.
3531 (x_create_x_image_and_pixmap): Remove unnecessary test for
3532 xmalloc returning NULL; that can't happen.
3533 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3534 (xpm_color_bucket): Use better integer hashing function.
3535 (xpm_cache_color): Don't possibly over-allocate memory.
3536 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3537 (gif_memory_source):
3538 Use ptrdiff_t, not int or size_t, to record sizes.
3539 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3540 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3541 either works, as we prefer signed integers.
3542 (tiff_read_from_memory, tiff_write_from_memory):
3543 Return tsize_t, not size_t, since that's what the TIFF API wants.
3544 (tiff_read_from_memory): Don't fail simply because the read would
3545 go past EOF; instead, return a short read.
3546 (tiff_load): Omit no-longer-needed casts.
3547 (Fimagemagick_types): Don't assume size fits into 'int'.
3548
3cc5a532
PE
3549 Improve hashing quality when configured --with-wide-int.
3550 * fns.c (hash_string): New function, taken from sxhash_string.
3551 Do not discard information about ASCII character case; this
3552 discarding is no longer needed.
3553 (sxhash-string): Use it. Change sig to match it. Caller changed.
3554 * lisp.h: Declare it.
3555 * lread.c (hash_string): Remove, since we now use fns.c's version.
3556 The fns.c version returns a wider integer if --with-wide-int is
3557 specified, so this should help the quality of the hashing a bit.
3558
b312a492
PE
3559 * emacs.c: Integer overflow minor fix.
3560 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3561 Define only if GNU_LINUX.
3562 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3563
dfd153ae
PE
3564 * dispnew.c: Integer signedness and overflow fixes.
3565 Remove unnecessary forward decls, that were a maintenance hassle.
3566 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3567 All uses changed.
3568 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3569 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3570 (prepare_desired_row, line_draw_cost):
3571 Use int, not unsigned, where either works.
3572 (save_current_matrix, restore_current_matrix):
3573 Use ptrdiff_t, not size_t, where either works.
3574 (init_display): Check for overflow more accurately, and without
3575 relying on undefined behavior.
3576
a81d11a3
PE
3577 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3578 Remove, replacing with the new symbols in lisp.h. All uses changed.
3579 * fileio.c (make_temp_name):
3580 * filelock.c (lock_file_1, lock_file):
3581 * xdisp.c (message_dolog):
3582 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3583 Use pMd etc. instead.
3584 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3585 replacing the pWIDE etc. symbols removed from editfns.c.
3586
3300e6fd
PE
3587 * keyboard.h (num_input_events): Now uintmax_t.
3588 This is (very slightly) less likely to mess up due to wraparound.
3589 All uses changed.
3590
fd05c7e9
PE
3591 * buffer.c: Integer signedness fixes.
3592 (alloc_buffer_text, enlarge_buffer_text):
3593 Use ptrdiff_t rather than size_t when either will do, as we prefer
3594 signed integers.
3595
903fe15d
PE
3596 * alloc.c: Integer signedness and overflow fixes.
3597 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3598 (__malloc_size_t): Default to size_t, not to int.
3599 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3600 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3601 Prefer ptrdiff_t to size_t when either would do, as we prefer
3602 signed integers.
3603 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3604 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3605 Now const. Initialize with values that are in range even if char
3606 is signed.
3607 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3608 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3609 These functions do the right thing with sizes > 2**32.
3610 (check_depth): Now ptrdiff_t, not int.
3611 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3612 Adjust to new way of storing sizes. Check for size overflow bugs
3613 in rest of code.
3614 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3615 slightly wrong anyway, as it missed one instance of
3616 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3617 (refill_memory_reserve): Omit needless cast to size_t.
3618 (mark_object_loop_halt): Mark as externally visible.
3619
ac82cc6a
PE
3620 * xselect.c: Integer signedness and overflow fixes.
3621 (Fx_register_dnd_atom, x_handle_dnd_message):
3622 Use ptrdiff_t, not size_t, since we prefer signed.
3623 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3624 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3625 x_dnd_atoms_size and x_dnd_atoms_length.
3626
c2d1e36d
PE
3627 * doprnt.c: Prefer signed to unsigned when either works.
3628 * eval.c (verror):
3629 * doprnt.c (doprnt):
3630 * lisp.h (doprnt):
3631 * xdisp.c (vmessage):
3632 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3633 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3634 prefer signed arithmetic to avoid comparison confusion.
3635 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3636 but is a bit tricky.
3637
0e926e56
PE
3638 Assume freestanding C89 headers, string.h, stdlib.h.
3639 * data.c, doprnt.c, floatfns.c, print.c:
3640 Include float.h unconditionally.
3641 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3642 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3643 * regex.c: Likewise for stddef.h, string.h.
3644 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3645 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3646 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3647 (STDC_HEADERS): Remove obsolete defines.
3648 * sysdep.c: Include limits.h unconditionally.
3649
9cfdb3ec
PE
3650 Assume support for memcmp, memcpy, memmove, memset.
3651 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3652 * regex.c (memcmp, memcpy):
3653 Remove; we assume C89 now.
3654
3655 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3656 (__malloc_safe_bcopy): Remove; no longer needed.
3657
cf950e6b 3658 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3659 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3660 well either way, and we prefer signed to unsigned.
3661
dbf38e02
LMI
36622011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3663
3664 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3665 closes the connection while we're reading (bug#9182).
3666
d6f0886c 36672011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3668
d6f0886c
JD
3669 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3670 are specified (Bug#9168).
24e0f6b1 3671
2eb1f9e6
PE
36722011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3673
3674 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3675 Found by GCC static checking and --with-wide-int on a 32-bit host.
3676
22381272 36772011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3678
3679 * xdisp.c (compute_display_string_pos): Fix logic of caching
3680 previous display string position. Initialize cached_prev_pos to
3681 -1. Fixes slow-down at the beginning of a buffer.
3682
f25e39b4
EZ
36832011-07-24 Eli Zaretskii <eliz@gnu.org>
3684
3685 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3686 for attrs[LFACE_FONTSET_INDEX].
3687
04c4b52e
PE
36882011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3689
3690 * xml.c (parse_region): Remove unused local
3691 that was recently introduced.
3692
c1734fbd
EZ
36932011-07-23 Eli Zaretskii <eliz@gnu.org>
3694
be18c5a5
EZ
3695 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3696 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3697
c1734fbd
EZ
3698 * xdisp.c (move_it_in_display_line_to): Record the best matching
3699 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3700 exit if none of the characters scanned was an exact match.
3701 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3702 when exact match is impossible due to invisible text, and the
3703 lines are truncated.
3704
a258d627
JD
37052011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3706
3707 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3708 for OSX >= 10.7.
3709
b6d5a689
EZ
37102011-07-22 Eli Zaretskii <eliz@gnu.org>
3711
0f74f785
EZ
3712 Fix a significant slow-down of cursor motion with C-n, C-p,
3713 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3714 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3715 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3716 (next_element_from_buffer): Call compute_stop_pos_backwards to
3717 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3718 base_level_stop.
3719 (reseat): Don't look for prev_stop, as that could mean a very long
3720 run.
3721 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3722 <cached_disp_overlay_modiff>: Cache for last found display string
3723 position.
551918c1 3724 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3725 about the same buffer in the same area of character positions, and
3726 the buffer wasn't changed since the time the display string
3727 position was cached.
551918c1 3728
b2d0c91a
EZ
37292011-07-22 Eli Zaretskii <eliz@gnu.org>
3730
3731 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3732 is an integer, which is important for empty lines. (Bug#9149)
3733
043604ee
CY
37342011-07-22 Chong Yidong <cyd@stupidchicken.com>
3735
3736 * frame.c (Fmodify_frame_parameters): In tty case, update the
3737 default face if necessary (Bug#4238).
3738
da4adb04
CY
37392011-07-21 Chong Yidong <cyd@stupidchicken.com>
3740
3741 * editfns.c (Fstring_to_char): No need to explain what a character
3742 is in the docstring (Bug#6576).
3743
9abd0532
LMI
37442011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3745
3746 * xml.c (parse_region): Make sure we always return a tree.
3747
36881d16
HK
37482011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3749
3750 * xml.c (parse_region): If a document contains only comments,
3751 return that, too.
3752
1e98674d
LMI
37532011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3754
3755 * xml.c (make_dom): Return comments, too.
3756
590bd467
PE
37572011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3758
3759 Port to OpenBSD.
3760 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3761 and the surrounding thread.
3762 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3763 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3764 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3765 timer goes off.
3766 * s/openbsd.h (BROKEN_SIGIO): Define.
3767 * unexelf.c (unexec) [__OpenBSD__]:
3768 Don't update the .mdebug section of the Alpha COFF symbol table.
3769
f41628b2
LMI
37702011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3771
3772 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3773 (bug#8460).
3774
b59b67c5
PE
37752011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3776
15e3a074
PE
3777 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3778 This fixes some race conditions on the permissions of any newly
3779 created file.
3780
41bed37d
PE
3781 * alloc.c (valid_pointer_p): Use pipe, not open.
3782 This fixes some permissions issues when debugging.
3783
b59b67c5
PE
3784 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3785 If fchown fails to set both uid and gid, try to set just gid,
3786 as that is sometimes allowed. Adjust the file's mode to eliminate
3787 setuid or setgid bits that are inappropriate if fchown fails.
3788
925a6be7
SM
37892011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3790
3791 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3792 to compare Lisp_Objects.
3793 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3794 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3795 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3796
52968808
AS
37972011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3798
0a6a104b
AS
3799 * lread.c (read_integer): Unread even EOF character.
3800 (read1): Likewise. Properly record start position of symbol.
3801
52968808
AS
3802 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3803 symbol character follows.
3804
9e381cdd
PE
38052011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3806
3807 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3808 This works around a problem with the previous change to Fcopy_file.
3809 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3810 and without this change, GCC might complain about discarding
3811 fchown's return value.
3812
b5641435
JB
38132011-07-16 Juanma Barranquero <lekktu@gmail.com>
3814
3815 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3816
a8031457
PE
38172011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3818
3819 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3820
dd889327
LMI
38212011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3822
750c33f7
LMI
3823 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3824 it's used from the C level.
3825
dd889327
LMI
3826 * process.c: Use the same condition for POLL_FOR_INPUT in both
3827 keyboard.c and process.c (bug#1858).
3828
87e86684
LM
38292011-07-09 Lawrence Mitchell <wence@gmx.li>
3830
3831 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3832 (Fgnutls_boot): Use it.
3833
64348f40
AS
38342011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3835
3836 * doc.c (Fsubstitute_command_keys): Revert last change.
3837
1d698799
LMI
38382011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3839
f863868c
LMI
3840 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3841 quotes the next character, and doesn't affect other longer
3842 sequences (bug#8935).
3843
1d698799
LMI
3844 * lread.c (syms_of_lread): Clarify that is isn't only
3845 `eval-buffer' and `eval-defun' that's affected by
3846 `lexical-binding' (bug#8460).
3847
aa4b6df6
EZ
38482011-07-15 Eli Zaretskii <eliz@gnu.org>
3849
3850 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3851 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3852
5d856da6
PE
38532011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3854
ad6042bb
PE
3855 Fix minor problems found by static checking.
3856 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3857 (elsz): Now a signed constant, not a size_t var. We prefer signed
3858 types to unsigned, to avoid integer comparison confusion. Without
3859 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3860 "cannot optimize loop, the loop counter may overflow", a symptom
3861 of the confusion.
f00bbb22 3862 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3863 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3864
6468f31c
LMI
38652011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3866
49080b10
LMI
3867 * search.c (Fre_search_backward): Mention `case-fold-search' in
3868 all the re_search_* functions (bug#8138).
3869
6468f31c
LMI
3870 * keyboard.c (Fopen_dribble_file): Document when the file is
3871 closed (bug#8056).
3872
c965adc5
EZ
38732011-07-14 Eli Zaretskii <eliz@gnu.org>
3874
df9733bf
EZ
3875 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3876 bidi_cache_idx.
3877
0bb23927
EZ
3878 Support bidi reordering of display and overlay strings.
3879 * xdisp.c (compute_display_string_pos)
3880 (compute_display_string_end): Accept additional argument STRING.
3881 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3882 (reseat_to_string): Initialize bidi_it->string.s and
3883 bidi_it->string.schars.
3884 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3885 NULL (avoids a crash in bidi_paragraph_init).
3886 Initialize itb.string.lstring.
0bb23927
EZ
3887 (init_iterator): Call bidi_init_it only of a valid
3888 buffer position was specified. Initialize paragraph_embedding to
3889 L2R.
3890 (reseat_to_string): Initialize the bidi iterator.
3891 (display_string): If we need to ignore text properties of
3892 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3893 original value of -1 will not work with bidi.)
3894 (compute_display_string_pos): First arg is now struct
3895 `text_pos *'; all callers changed. Support display properties on
3896 Lisp strings.
3897 (compute_display_string_end): Support display properties on Lisp
3898 strings.
3899 (init_iterator, reseat_1, reseat_to_string): Initialize the
3900 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3901 when iterating on a string not from display properties).
640c8776
SM
3902 (compute_display_string_pos, compute_display_string_end):
3903 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3904 arrow keys.
3905 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3906 base_level_stop; instead, set base_level_stop to BEGV.
3907 Fixes crashes in vertical-motion.
0bb23927
EZ
3908 (next_element_from_buffer): Improve commentary for when
3909 the iterator is before prev_stop.
3910 (init_iterator): Initialize bidi_p from the default value of
3911 bidi-display-reordering, not from buffer-local value. Use the
3912 buffer-local value only if initializing for buffer iteration.
3913 (handle_invisible_prop): Support invisible properties on strings
3914 that are being bidi-reordered.
3915 (set_iterator_to_next): Support bidi reordering of C strings and
3916 Lisp strings.
3917 (next_element_from_string): Support bidi reordering of Lisp
3918 strings.
3919 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3920 (display_string): Support display of R2L glyph rows.
3921 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3922 (init_iterator): Don't initialize it->bidi_p for strings
3923 here.
3924 (reseat_to_string): Initialize it->bidi_p for strings here.
3925 (next_element_from_string, next_element_from_c_string)
3926 (next_element_from_buffer): Add xassert's for correspondence
3927 between IT's object being iterated and it->bidi_it.string
3928 structure.
3929 (face_before_or_after_it_pos): Support bidi iteration.
3930 (next_element_from_c_string): Handle the case of the first string
3931 character that is not the first one in the visual order.
3932 (get_visually_first_element): New function, refactored from common
3933 parts of next_element_from_buffer, next_element_from_string, and
3934 next_element_from_c_string.
3935 (tool_bar_lines_needed, redisplay_tool_bar)
3936 (display_menu_bar): Force left-to-right direction. Add a FIXME
3937 comment for making that be controlled by a user option.
3938 (push_it, pop_it): Save and restore the state of the
3939 bidi iterator. Save and restore the bidi_p flag.
3940 (pop_it): Iterate out of display property for string iteration as
3941 well.
3942 (iterate_out_of_display_property): Support iteration over strings.
3943 (handle_single_display_spec): Set up it->bidi_it for iteration
3944 over a display string, and call bidi_init_it.
3945 (handle_single_display_spec, next_overlay_string)
3946 (get_overlay_strings_1, push_display_prop): Set up the bidi
3947 iterator for displaying display or overlay strings.
3948 (forward_to_next_line_start): Don't use the shortcut if
3949 bidi-iterating.
3950 (back_to_previous_visible_line_start): If handle_display_prop
3951 pushed the iterator stack, restore the internal state of the bidi
3952 iterator by calling bidi_pop_it same number of times.
3953 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3954 and we are bidi-iterating, don't decrement the iterator position;
3955 instead, set the first_elt flag in the bidi iterator, to produce
3956 the same effect.
3957 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3958 (push_display_prop): xassert that we are iterating a buffer.
3959 (push_it, pop_it): Save and restore paragraph_embedding member.
3960 (handle_single_display_spec, next_overlay_string)
3961 (get_overlay_strings_1, reseat_1, reseat_to_string)
3962 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3963 correctly. Don't assume unibyte strings are not bidi-reordered.
3964 (compute_display_string_pos)
3965 (compute_display_string_end): Fix handling the case of C string.
3966 (push_it, pop_it): Save and restore from_disp_prop_p.
3967 (handle_single_display_spec, push_display_prop): Set the
3968 from_disp_prop_p flag.
3969 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3970 (pop_it): Call iterate_out_of_display_property only if we are
3971 popping after iteration over a string that came from a display
3972 property. Fix a typo in popping stretch info. Add an assertion
3973 for verifying that the iterator position is in sync with the bidi
3974 iterator.
3975 (handle_single_display_spec, get_overlay_strings_1)
3976 (push_display_prop): Fix initialization of paragraph direction for
3977 string when that of the parent object is not yet determined.
3978 (reseat_1): Call bidi_init_it to resync the bidi
3979 iterator with IT's position. (Bug#7616)
3980 (find_row_edges): If ROW->start.pos gives position
3981 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3982 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3983 Reset the from_disp_prop_p flag.
3984 (SAVE_IT, RESTORE_IT): New macros.
3985 (pos_visible_p, face_before_or_after_it_pos)
3986 (back_to_previous_visible_line_start)
3987 (move_it_in_display_line_to, move_it_in_display_line)
3988 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3989 (try_scrolling, redisplay_window, display_line): Use them when
3990 saving a temporary copy of the iterator and restoring it back.
3991 (back_to_previous_visible_line_start, reseat_1)
3992 (init_iterator): Empty the bidi cache "stack".
3993 (move_it_in_display_line_to): If iterator ended up at
3994 EOL, but we never saw any buffer positions smaller than
3995 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3996 motion in bidi-reordered lines.
3997 (move_it_in_display_line_to): Record prev_method and prev_pos
3998 immediately before the call to set_iterator_to_next. Fixes cursor
3999 motion in bidi-reordered lines with stretch glyphs and strings
4000 displayed in margins. (Bug#8133) (Bug#8867)
4001 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4002 TO_CHARPOS.
640c8776
SM
4003 (pos_visible_p): Support positions in bidi-reordered lines.
4004 Save and restore bidi cache.
0bb23927
EZ
4005
4006 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4007 (bidi_paragraph_info): Delete unused struct.
4008 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4009 (bidi_cache_start): New variable.
4010 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4011 to zero.
4012 (bidi_cache_fetch_state, bidi_cache_search)
4013 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4014 (bidi_cache_find, bidi_peek_at_next_level)
4015 (bidi_level_of_next_char, bidi_find_other_level_edge)
4016 (bidi_move_to_visually_next): Compare cache index with
4017 bidi_cache_start rather than with zero.
4018 (bidi_fetch_char): Accept new argument STRING; all callers
4019 changed. Support iteration over a string. Support strings with
4020 display properties. Support unibyte strings. Fix the type of
4021 `len' according to what STRING_CHAR_AND_LENGTH expects.
4022 (bidi_paragraph_init, bidi_resolve_explicit_1)
4023 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4024 (bidi_level_of_next_char, bidi_move_to_visually_next):
4025 Support iteration over a string.
0bb23927
EZ
4026 (bidi_set_sor_type, bidi_resolve_explicit_1)
4027 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4028 can now be zero (for strings); special values 0 and -1 were
4029 changed to -1 and -2, respectively.
4030 (bidi_char_at_pos): New function.
4031 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4032 Call it instead of FETCH_MULTIBYTE_CHAR.
4033 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4034 initialized to valid values.
4035 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4036 values.
4037 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4038 the test for valid cached positions. Fix the logic for looking up
4039 the sentinel state in the cache. GCPRO the Lisp string we are
4040 iterating.
4041 (bidi_push_it, bidi_pop_it): New functions.
4042 (bidi_initialize): Initialize the bidi cache start stack pointer.
4043 (bidi_cache_ensure_space): New function, refactored from part of
4044 bidi_cache_iterator_state. Don't assume the required size is just
4045 one BIDI_CACHE_CHUNK away.
4046 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4047 (bidi_count_bytes, bidi_char_at_pos): New functions.
4048 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4049 always valid if bidi_cache_idx is valid.
4050 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4051 is valid if it's going to be used.
4052 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4053 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4054 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4055 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4056 (bidi_find_other_level_edge, bidi_cache_start_stack):
4057 All variables related to cache indices are now EMACS_INT.
c965adc5 4058
0bb23927
EZ
4059 * dispextern.h (struct bidi_string_data): New structure.
4060 (struct bidi_it): New member `string'. Make flag members be 1-bit
4061 fields, and put them last in the struct.
640c8776
SM
4062 (compute_display_string_pos, compute_display_string_end):
4063 Update prototypes.
0bb23927
EZ
4064 (bidi_push_it, bidi_pop_it): Add prototypes.
4065 (struct iterator_stack_entry): New members bidi_p,
4066 paragraph_embedding, and from_disp_prop_p.
4067 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4068 (bidi_shelve_cache, bidi_unshelve_cache):
4069 Declare prototypes.
0bb23927
EZ
4070
4071 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4072 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4073 and vector-like objects.
4074
4075 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4076 cache around display iteration.
4077
4078 * window.c (Fwindow_end, window_scroll_pixel_based)
4079 (displayed_window_lines, Frecenter): Save and restore the bidi
4080 cache around display iteration.
4081
3bbd2265
LMI
40822011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4083
4084 * editfns.c (Fdelete_region): Clarify the use of the named
4085 parameters (bug#6788).
4086
adc47434
MR
40872011-07-14 Martin Rudalics <rudalics@gmx.at>
4088
4089 * indent.c (Fvertical_motion): Set and restore w->pointm when
4090 saving and restoring the window's buffer (Bug#9006).
4091
837c31f8
LMI
40922011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4093
4094 * editfns.c (Fstring_to_char): Clarify just what is returned
4095 (bug#6576). Text by Eli Zaretskii.
4096
ac389d0c
JB
40972011-07-13 Juanma Barranquero <lekktu@gmail.com>
4098
4099 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4100
0be0ce47
EZ
41012011-07-13 Eli Zaretskii <eliz@gnu.org>
4102
4103 * buffer.c (mmap_find): Fix a typo.
4104
cd18e7e3
JB
41052011-07-13 Johan Bockgård <bojohan@gnu.org>
4106
4107 Fix execution of x selection hooks.
4108 * xselect.c (Qx_lost_selection_functions)
4109 (Qx_sent_selection_functions): New vars.
4110 (syms_of_xselect): DEFSYM them.
4111 (x_handle_selection_request): Pass Qx_sent_selection_functions
4112 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4113 (x_handle_selection_clear,x_clear_frame_selections):
4114 Pass Qx_lost_selection_functions rather than
4115 Vx_lost_selection_functions to Frun_hook_with_args.
4116
47ea7f44
PE
41172011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4118
ac389d0c 4119 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4120 The old code sometimes used this field without initializing it.
4121
47ea7f44
PE
4122 * alloc.c (gc_sweep): Don't read past end of array.
4123 In theory, the old code could also have corrupted Emacs internals,
4124 though it'd be very unlikely.
4125
bc985c87
AS
41262011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4127
4128 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4129 argument. (Bug#4026)
bc985c87 4130
0cf34688
LMI
41312011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4132
b3dadd76
LMI
4133 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4134 key" (bug#4257).
4135
0cf34688
LMI
4136 * window.c (Fset_window_start): Doc fix (bug#4199).
4137 (Fset_window_hscroll): Ditto.
4138
270768cd
PE
41392011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4140
077e3dda 4141 Fix minor new problems caught by GCC 4.6.1.
270768cd 4142 * term.c (init_tty): Remove unused local.
490011a6 4143 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4144 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4145 not used otherwise.
270768cd 4146
b1f58454
CY
41472011-07-12 Chong Yidong <cyd@stupidchicken.com>
4148
4149 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4150
22b9578d
LMI
41512011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4152
6e70ab07
LMI
4153 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4154 are the mini-buffer and the echo area (bug#3320).
4155
22b9578d
LMI
4156 * term.c (init_tty): Remove support for supdup, c10 and perq
4157 terminals, which are no longer supported (bug#1482).
4158
8974cc9f
JB
41592011-07-10 Johan Bockgård <bojohan@gnu.org>
4160
4161 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4162
a560d974
JD
41632011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4164
4165 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4166 for non-popups (Bug#3642).
4167
1dae0f0a
AS
41682011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4169
268c2c36 4170 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4171 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4172 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4173 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4174 * data.c (fmod): Likewise.
4175 * dispnew.c (swap_glyphs_in_rows): Likewise.
4176 * emacs.c (memory_warning_signal): Likewise.
4177 * floatfns.c (float_error): Likewise.
4178 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4179 (otf_open, font_otf_capability, generate_otf_features)
4180 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4181 Likewise.
4182 * image.c (pbm_read_file): Likewise.
4183 * indent.c (string_display_width): Likewise.
4184 * intervals.c (check_for_interval, search_for_interval)
4185 (inc_interval_count, count_intervals, root_interval)
4186 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4187 * lread.c (defalias): Likewise.
268c2c36 4188 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4189 * regex.c (set_image_of_range_1, set_image_of_range)
4190 (regex_grow_registers): Likewise.
4191 * sysdep.c (strerror): Likewise.
4192 * termcap.c (valid_filename_p, tprint, main): Likewise.
4193 * tparam.c (main): Likewise.
4194 * unexhp9k800.c (run_time_remap, save_data_space)
4195 (update_file_ptrs, read_header, write_header, calculate_checksum)
4196 (copy_file, copy_rest, display_header): Likewise.
4197 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4198 Likewise.
4199 * xdisp.c (check_it): Likewise.
4200 * xfaces.c (register_color, unregister_color, unregister_colors):
4201 Likewise.
4202 * xfns.c (print_fontset_result): Likewise.
4203 * xrdb.c (member, fatal, main): Likewise.
4204
99033785
PE
42052011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4206
4207 Fix minor problems found by static checking (Bug#9031).
4208 * chartab.c (char_table_set_range, map_sub_char_table):
4209 Remove unused locals.
4210 (uniprop_table): Now static.
4211 * composite.c (_work_char): Remove unused static var.
4212
9cb2ac56
JB
42132011-07-09 Juanma Barranquero <lekktu@gmail.com>
4214
4215 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4216
f25661f0
JD
42172011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4218
4219 * gtkutil.c (qttip_cb): Remove code without function.
4220
8278c4fe
EZ
42212011-07-09 Eli Zaretskii <eliz@gnu.org>
4222
4223 * w32.c (pthread_sigmask): New stub.
4224
1692ae2d 42252011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4226
8a6ebd58 4227 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4228 sigprocmask is portable only for single-threaded applications, and
4229 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4230 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4231 (LIBES): Use it.
4232 * callproc.c (Fcall_process):
4233 * process.c (create_process):
4234 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4235 Use pthread_sigmask, not sigprocmask.
123403e4 4236
1b854618
JD
42372011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4238
4239 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4240 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4241 wrong (Bug#8591).
4242
3fe4b549
JD
42432011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4244
0ce7e563
JD
4245 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4246 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4247 (xg_hide_tooltip): Fix comment.
4248
3fe4b549
JD
4249 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4250 in registerServicesMenuSendTypes.
4251 (validRequestorForSendType): Don't check ns_return_types.
4252
4253 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4254 ns_return_type.
4255
5df75e47
JR
42562011-07-08 Jason Rumney <jasonr@gnu.org>
4257
22610910
JR
4258 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4259 SH_SHOW for hidden windows (Bug#5482).
4260
5df75e47
JR
4261 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4262 frame struct members of non-existent frames (Bug#6284).
4263
699c10bd
JD
42642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4265
4393663b
JD
4266 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4267 variable firstTime not needed on OSX >= 10.6.
4268 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4269 >= 10.5. Use setKnobProportion, setDoubleValue.
4270
4271 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4272 (MAC_OS_X_VERSION_10_5): Define if not defined.
4273 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4274 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4275 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4276
4277 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4278 cString and lossyCString on OSX >= 10.4
4279
58179cce 4280 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4281 sizeToFit on OSX >= 10.2.
4282
4283 * nsimage.m (allocInitFromFile): Don't use deprecated method
4284 bestRepresentationForDevice on OSX >= 10.6.
4285
4286 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4287 to avoid warning.
4288
4289 * emacs.c: Declare unexec_init_emacs_zone.
4290
a63e0781
JD
4291 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4292
699c10bd
JD
4293 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4294
4295 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4296 on svcsMenu (Bug#8842).
4297
4298 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4299 ns_return_types.
4300 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4301
4302 * nsterm.m (QUTF8_STRING): Declare.
4303 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4304 (validRequestorForSendType): Return type is (id).
4305 Change indexOfObjectIdenticalTo to indexOfObject.
4306 Check if we have local selection before returning self (Bug#8842).
4307 (writeSelectionToPasteboard): Put local selection into paste board
4308 if we have a local selection (Bug#8842).
4309 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4310
4311 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4312 (ns_get_local_selection): Declare.
4313
54e10184
LMI
43142011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4315
9888ff71
LMI
4316 * keymap.c (describe_map_tree): Don't insert a double newline at
4317 the end of the buffer (bug#1169) and return whether we inserted
4318 something.
4319
54e10184
LMI
4320 * callint.c (Fcall_interactively): Change "reading args" to
4321 "providing args" to try to clarify what it does (bug#1010).
4322
15fa4783
KH
43232011-07-07 Kenichi Handa <handa@m17n.org>
4324
4325 * composite.c (composition_compute_stop_pos): Ignore a static
4326 composition starting before CHARPOS (Bug#8915).
4327
4328 * xdisp.c (handle_composition_prop): Likewise.
4329
a8815b00
EZ
43302011-07-07 Eli Zaretskii <eliz@gnu.org>
4331
4332 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4333 (Bug#9015)
4334
ef7b981d 43352011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4336
4337 * character.h (unicode_category_t): New enum type.
4338
4339 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4340 (Qchar_code_property_table): New variable.
4341 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4342 (UNIPROP_COMPRESSED_FORM_P): New macros.
4343 (char_table_ascii): Uncompress the compressed values.
4344 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4345 Uncompress the compressed values.
ac389d0c 4346 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4347 (char_table_ref_and_range): Uncompress the compressed values.
4348 (sub_char_table_set): New arg is_uniprop. Callers changed.
4349 Uncompress the compressed values.
4350 (sub_char_table_set_range): Args changed. Callers changed.
4351 (char_table_set_range): Adjuted for the above change.
4352 (map_sub_char_table): Delete args default_val and parent. Add arg
4353 top. Give decoded values to a Lisp function.
640c8776 4354 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4355 values to a Lisp function. Gcpro more variables.
4356 (uniprop_table_uncompress)
4357 (uniprop_decode_value_run_length): New functions.
4358 (uniprop_decoder, uniprop_decoder_count): New variables.
4359 (uniprop_get_decoder, uniprop_encode_value_character)
4360 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4361 New functions.
4362 (uniprop_encoder, uniprop_encoder_count): New variables.
4363 (uniprop_get_encoder, uniprop_table)
4364 (Funicode_property_table_internal, Fget_unicode_property_internal)
4365 (Fput_unicode_property_internal): New functions.
4366 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4367 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4368 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4369 char-code-property-alist.
4370
640c8776 4371 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4372 Vunicode_category_table.
4373
640c8776 4374 * font.c (font_range): Adjust for the change of
c805dec0
KH
4375 Vunicode_category_table.
4376
76b397fb
DN
43772011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4378
4379 * m/iris4d.h: Remove file, move contents ...
4380 * s/irix6-5.h: ... here.
4381
22b4128e
PE
43822011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4383
4384 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4385 * alloc.c (mark_buffer):
4386 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4387 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4388 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4389 This isn't true in general, and it's particularly not true
4390 if Emacs is configured with --with-wide-int.
4391 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4392 New macros, used in the buffer.c change.
4393
869795d6
JD
43942011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4395
4396 * xsettings.c: Use both GConf and GSettings if both are available.
4397 (store_config_changed_event): Add comment.
4398 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4399 (store_tool_bar_style_changed): New functions.
5e617bc2 4400 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4401 (struct xsettings): Move font inside HAVE_XFT.
4402 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4403 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4404 Move inside HAVE_XFT.
640c8776 4405 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4406 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4407 also.
4408 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4409 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4410 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4411 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4412 (parse_settings): Move check for font inside HAVE_XFT.
4413 (read_settings, apply_xft_settings): Add comment.
4414 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4415 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4416 call store_font_name_changed.
4417 (xft_settings_event): Add comment.
4418 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4419 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4420 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4421 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4422 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4423 (xsettings_get_system_font, xsettings_get_system_normal_font):
4424 Add comment.
869795d6 4425
d8ed26bd
PE
44262011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4427
4428 Random fixes. E.g., (random) never returned negative values.
4429 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4430 subseconds part to the entropy, as that's a bit more random.
4431 Prefer signed to unsigned, since the signedness doesn't matter and
4432 in general we prefer signed. When given a limit, use a
4433 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4434 latter isn't right if USE_2_TAGS_FOR_INTS.
4435 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4436 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4437
cabf1cac
SM
44382011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4439
4440 * textprop.c (text_property_stickiness):
4441 Obey Vtext_property_default_nonsticky.
4442 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4443 * w32fns.c (syms_of_w32fns):
4444 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4445
6e9b2be9
PE
44462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4447
4448 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4449 This is more efficient than Ffile_directory_p and avoids a minor race.
4450
90186c68
LMI
44512011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4452
7c301272
LMI
4453 * buffer.c (Foverlay_put): Say what the return value is
4454 (bug#7835).
4455
c4f2d8d4
LMI
4456 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4457 is a directory before asking whether to use the file name
4458 (bug#7564).
ad637907
LMI
4459 (barf_or_query_if_file_exists): Make the "File is a directory"
4460 error be more correct.
c4f2d8d4 4461
90186c68
LMI
4462 * fns.c (Frequire): Remove the mention of the .gz files, since
4463 that's installation-specific, but keep the mention of
4464 `get-load-suffixes'.
4465
da64016e
PE
44662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4467
4468 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4469 Report string overflow if the output is too long.
4470
7d47b580
JB
44712011-07-04 Juanma Barranquero <lekktu@gmail.com>
4472
a555cb87
JB
4473 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4474 (syms_of_gnutls): Remove duplicate DEFSYM for
4475 Qgnutls_bootprop_verify_hostname_error, an error for
4476 Qgnutls_bootprop_verify_error (which is no longer used).
4477
7d47b580
JB
4478 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4479 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4480 Also (re)move comments that are misplaced or no longer relevant.
4481
1e49bfab
LMI
44822011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4483
4484 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4485
1485f4c0
CY
44862011-07-03 Chong Yidong <cyd@stupidchicken.com>
4487
4488 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4489 and background color parameters if they have been changed.
4490
a9ab721e
LMI
44912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4492
4493 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4494
cf7cff57
PE
44952011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4496
2e13213d
PE
4497 * xsettings.c (SYSTEM_FONT): Define only when used.
4498 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4499
cf7cff57
PE
4500 * keymap.c (access_keymap_1): Now static.
4501
7a8e04f7
CY
45022011-07-02 Chong Yidong <cyd@stupidchicken.com>
4503
4504 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4505 leave any prefix arg for the up event (Bug#1586).
4506
61352f62
LMI
45072011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4508
69bb1ef7
LMI
4509 * lread.c (syms_of_lread): Mention single symbols defined by
4510 `defvar' or `defconst' (bug#7154).
4511
61352f62 4512 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4513 (Frequire): Mention get-load-suffixes.
61352f62 4514
28545e04
MR
45152011-07-02 Martin Rudalics <rudalics@gmx.at>
4516
4517 * window.h (window): Remove clone_number slot.
4518 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4519 Remove.
4520 (make_parent_window, make_window, saved_window)
4521 (Fset_window_configuration, save_window_save): Don't deal with
4522 clone numbers.
4523 * buffer.c (Qclone_number): Remove declaration.
4524 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4525
3349e122
SM
45262011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4527
4528 Add multiple inheritance to keymaps.
4529 * keymap.c (Fmake_composed_keymap): New function.
4530 (Fset_keymap_parent): Simplify.
4531 (fix_submap_inheritance): Remove.
4532 (access_keymap_1): New function extracted from access_keymap to handle
4533 embedded parents and handle lists of maps.
4534 (access_keymap): Use it.
4535 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4536 (Fcopy_keymap): Handle embedded parents.
4537 (Fcommand_remapping, define_as_prefix): Simplify.
4538 (Fkey_binding): Simplify.
4539 (syms_of_keymap): Move minibuffer-local-completion-map,
4540 minibuffer-local-filename-completion-map,
4541 minibuffer-local-must-match-map, and
4542 minibuffer-local-filename-must-match-map to Elisp.
4543 (syms_of_keymap): Defsubr make-composed-keymap.
4544 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4545 (parse_menu_item): Trivial simplification.
4546
3279eb87
GM
45472011-07-01 Glenn Morris <rgm@gnu.org>
4548
4549 * Makefile.in (SETTINGS_LIBS): Fix typo.
4550
4550efdf
KI
45512011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4552
4553 * coding.c (Fencode_coding_string): Record the last coding system
4554 used, as the function doc string says (bug#8738).
4555
0949d2b6
JD
45562011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4557
4558 * xsettings.c (store_monospaced_changed): Take new font as arg and
4559 check for change against current_mono_font.
4560 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4561 (emacs_settings_constructor, emacs_settings_get_property)
4562 (emacs_settings_set_property, emacs_settings_class_init)
4563 (emacs_settings_init, gsettings_obj): Remove.
4564 (something_changedCB): New function for HAVE_GSETTINGS.
4565 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4566 with value as argument.
4567 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4568 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4569 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4570 "changed".
4571
4572 * xgselect.c: Add defined (HAVE_GSETTINGS).
4573 (xgselect_initialize): Ditto.
4574
4575 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4576 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4577 xg_select.
4578
bbc6b304
PE
45792011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4580
4581 * eval.c (struct backtrace): Simplify and port the data structure.
4582 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4583 signed bit field, as this assumption is not portable and it makes
4584 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4585 "char debug_on_exit : 1" as this is not portable either; instead,
4586 use the portable "unsigned int debug_on_exit : 1". Remove unused
4587 member evalargs. Remove obsolete comments about cc bombing out.
4588
9851bfc5
JD
45892011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4590
51bb811f 4591 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4592 Let HAVE_GSETTINGS override HAVE_GCONF.
4593 (store_monospaced_changed): New function.
4594 (EMACS_SETTINGS): A new type derived from GObject to handle
4595 GSettings notifications.
4596 (emacs_settings_constructor, emacs_settings_get_property)
4597 (emacs_settings_set_property, emacs_settings_class_init):
4598 New functions.
4599 (gsettings_client, gsettings_obj): New variables.
4600 (GSETTINGS_SCHEMA): New define.
4601 (something_changedCB): Call store_monospaced_changed.
4602 (init_gsettings): New function.
4603 (xsettings_initialize): Call init_gsettings.
4604 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4605 to NULL.
4606
640c8776 4607 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4608 GCONF_CFLAGS/LIBS.
4609
5386012d
MR
46102011-06-29 Martin Rudalics <rudalics@gmx.at>
4611
4612 * window.c (resize_root_window, grow_mini_window)
4613 (shrink_mini_window): Rename Qresize_root_window to
4614 Qwindow_resize_root_window and Qresize_root_window_vertically to
4615 Qwindow_resize_root_window_vertically.
4616
f13e0b08
PE
46172011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4618
4619 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4620
94515237
JB
46212011-06-27 Juanma Barranquero <lekktu@gmail.com>
4622
4623 * makefile.w32-in: Redesign dependencies so they reflect more
4624 clearly which files are directly included by each source file,
4625 and not through other includes.
4626
e43b6e43
MR
46272011-06-27 Martin Rudalics <rudalics@gmx.at>
4628
4629 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4630 (sort_overlays, overlay_strings): When an overlay's clone number
4631 matches the window's clone number process the overlay even if
4632 the overlay's window property doesn't match the current window.
4633
d68443dc
MR
4634 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4635 (Fwindow_hchild): Rename to Fwindow_left_child.
4636 (Fwindow_next): Rename to Fwindow_next_sibling.
4637 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4638 (resize_window_check): Rename to window_resize_check.
4639 (resize_window_apply): Rename to window_resize_apply.
4640 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4641 (Fdelete_other_windows_internal, resize_frame_windows)
4642 (Fsplit_window_internal, Fdelete_window_internal)
4643 (grow_mini_window, shrink_mini_window)
4644 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4645
c7e73be5
JD
46462011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4647
4648 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4649 (emacs_fixed_set_min_size): Remove.
4650 (emacs_fixed_new): Take frame as argument.
4651
4652 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4653 (_EmacsFixedPrivate): Remove minwidth/height.
4654 Add struct frame *f.
4655 (emacs_fixed_init): Initialize priv->f.
4656 (get_parent_class, emacs_fixed_set_min_size): Remove.
4657 (emacs_fixed_new): Set priv->f to argument.
4658 (emacs_fixed_get_preferred_width)
4659 (emacs_fixed_get_preferred_height): Use min_width/height from
4660 frames size_hint to set minimum and natural (Bug#8919).
4661 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4662 and use min_width/height from frames size_hint to set
4663 min_width/height (Bug#8919).
4664
4665 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4666 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4667 Fix indentation.
c7e73be5 4668
cf99dcf8
EZ
46692011-06-26 Eli Zaretskii <eliz@gnu.org>
4670
4671 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4672 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4673 called at ZV.
4674
029529ac
CY
46752011-06-26 Chong Yidong <cyd@stupidchicken.com>
4676
4677 * process.c (wait_reading_process_output): Bypass select if
4678 waiting for a cell while ignoring keyboard input, and input is
4679 pending. Suggested by Jan Djärv (Bug#8869).
4680
7a7ef429
PE
46812011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4682
4683 Use gnulib's dup2 module instead of rolling our own.
4684 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4685
11fdef7d 46862011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4687
4688 * dispnew.c (scrolling_window): Before scrolling, turn off a
4689 mouse-highlight in the window being scrolled.
4690
cd3520a4
JB
46912011-06-24 Juanma Barranquero <lekktu@gmail.com>
4692
4693 Move DEFSYM to lisp.h and use everywhere.
4694
4695 * character.h (DEFSYM): Move declaration...
4696 * lisp.h (DEFSYM): ...here.
4697
4698 * gnutls.c:
4699 * minibuf.c:
4700 * w32menu.c:
4701 * w32proc.c:
4702 * w32select.c: Don't include character.h.
4703
4704 * alloc.c (syms_of_alloc):
4705 * buffer.c (syms_of_buffer):
4706 * bytecode.c (syms_of_bytecode):
4707 * callint.c (syms_of_callint):
4708 * casefiddle.c (syms_of_casefiddle):
4709 * casetab.c (init_casetab_once):
4710 * category.c (init_category_once, syms_of_category):
4711 * ccl.c (syms_of_ccl):
4712 * cmds.c (syms_of_cmds):
4713 * composite.c (syms_of_composite):
4714 * dbusbind.c (syms_of_dbusbind):
4715 * dired.c (syms_of_dired):
4716 * dispnew.c (syms_of_display):
4717 * doc.c (syms_of_doc):
4718 * editfns.c (syms_of_editfns):
4719 * emacs.c (syms_of_emacs):
4720 * eval.c (syms_of_eval):
4721 * fileio.c (syms_of_fileio):
4722 * fns.c (syms_of_fns):
4723 * frame.c (syms_of_frame):
4724 * fringe.c (syms_of_fringe):
4725 * insdel.c (syms_of_insdel):
4726 * keymap.c (syms_of_keymap):
4727 * lread.c (init_obarray, syms_of_lread):
4728 * macros.c (syms_of_macros):
4729 * msdos.c (syms_of_msdos):
4730 * print.c (syms_of_print):
4731 * process.c (syms_of_process):
4732 * search.c (syms_of_search):
4733 * sound.c (syms_of_sound):
4734 * syntax.c (init_syntax_once, syms_of_syntax):
4735 * terminal.c (syms_of_terminal):
4736 * textprop.c (syms_of_textprop):
4737 * undo.c (syms_of_undo):
4738 * w32.c (globals_of_w32):
4739 * window.c (syms_of_window):
4740 * xdisp.c (syms_of_xdisp):
4741 * xfaces.c (syms_of_xfaces):
4742 * xfns.c (syms_of_xfns):
4743 * xmenu.c (syms_of_xmenu):
4744 * xsettings.c (syms_of_xsettings):
4745 * xterm.c (syms_of_xterm): Use DEFSYM.
4746
4228cf16
TZ
47472011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4748
cd3520a4 4749 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4750
7fcccf1e
PE
47512011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4752
7efb4e0e
PE
4753 Integer and buffer overflow fixes (Bug#8873).
4754
ff5844ad
PE
4755 * print.c (printchar, strout): Check for string overflow.
4756 (PRINTPREPARE, printchar, strout):
4757 Don't set size unless allocation succeeds.
4758
90532f02
PE
4759 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4760 for sizes. Check for string overflow more accurately.
4761 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4762
6d84508d
PE
4763 * macros.c: Integer and buffer overflow fixes.
4764 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4765 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4766 Use ptrdiff_t, not int, for sizes.
4767 Don't increment bufsize until after realloc succeeds.
4768 Check for size-calculation overflow.
4769 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4770
437b2cb4
PE
4771 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4772
8b9ac8b4
PE
4773 * lread.c: Integer overflow fixes.
4774 (read_integer): Radix is now EMACS_INT, not int,
4775 to improve quality of diagnostics for out-of-range radices.
4776 Calculate buffer size correctly for out-of-range radices.
4777 (read1): Check for integer overflow in radices, and in
4778 read-circle numbers.
82cb60d3
PE
4779 (read_escape): Avoid int overflow.
4780 (Fload, openp, read_buffer_size, read1)
4781 (substitute_object_recurse, read_vector, read_list, map_obarray):
4782 Use ptrdiff_t, not int, for sizes.
4783 (read1): Use EMACS_INT, not int, for sizes.
20270765 4784 Check for size overflow.
8b9ac8b4 4785
7fcccf1e
PE
4786 * image.c (cache_image): Check for size arithmetic overflow.
4787
bfbbd7e7
PE
4788 * lread.c: Integer overflow issues.
4789 (saved_doc_string_size, saved_doc_string_length)
4790 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4791 Now ptrdiff_t, not int.
4792 (read1): Don't assume doc string length fits in int. Check for
4793 out-of-range doc string lengths.
4794 (read_list): Don't assume file position fits in int.
39019e54 4795 (read_escape): Check for hex character overflow.
bfbbd7e7 4796
4e323265
LL
47972011-06-22 Leo Liu <sdl.web@gmail.com>
4798
4799 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4800 Move to minibuffer.el.
4801
85fece3e
PE
48022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4803
20b84ce9 4804 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4805 The following patches are for when GLYPH_DEBUG && !XASSERT.
4806 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4807 * dispnew.c (flush_stdout):
4808 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4809 Mark as externally visible.
4810 * dispnew.c (check_window_matrix_pointers): Now static.
4811 * dispnew.c (window_to_frame_vpos):
4812 * xfns.c (unwind_create_frame):
4813 * xterm.c (x_check_font): Remove unused local.
4814 * scroll.c (CHECK_BOUNDS):
4815 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4816 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4817 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4818 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4819 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4820 Now static.
4821 (debug_method_add): Use va_list and vsprintf rather than relying
4822 on undefined behavior with wrong number of arguments.
4823 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4824 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4825 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4826 since we're not interested in debugging glyphs with old libraries.
4827 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4828 GCC 4.6.0's static checking.
4829
0766b489
PE
48302011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4831
31fd4b32
PE
4832 Integer overflow and signedness fixes (Bug#8873).
4833 A few related buffer overrun fixes, too.
4834
b79e8648
PE
4835 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4836
0766b489
PE
4837 * dispextern.h (struct face.stipple):
4838 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4839 (x_bitmap_mask, x_allocate_bitmap_record)
4840 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4841 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4842 (x_create_bitmap_from_xpm_data):
4843 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4844 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4845 (.bitmaps_last):
4846 * xfaces.c (load_pixmap):
4847 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4848 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4849 (.bitmaps_last, struct x_output.icon_bitmap):
4850 Use ptrdiff_t, not int, for bitmap indexes.
4851 (x_allocate_bitmap_record): Check for size overflow.
4852 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4853
b081724f
PE
4854 Use ptrdiff_t, not int, for overlay counts.
4855 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4856 * editfns.c (overlays_around, get_pos_property):
4857 * textprop.c (get_char_property_and_overlay):
4858 * xdisp.c (next_overlay_change, note_mouse_highlight):
4859 * xfaces.c (face_at_buffer_position):
21514da7
PE
4860 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4861 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4862 (Fnext_overlay_change, Fprevious_overlay_change)
4863 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4864 Use ptrdiff_t, not int, for sizes.
21514da7 4865 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4866
3de73e5e
PE
4867 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4868
2606c57b
PE
4869 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4870 (x_session_initialize): Do not assume string length fits in int.
4871
aaafe47a
PE
4872 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4873 This is unlikely, but can occur if DPI is outlandish.
4874
2674ddc8 4875 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4876 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4877
28154962
PE
4878 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4879 * xrdb.c (magic_file_p, search_magic_path):
4880 Omit last arg SUFFIX; it was always 0. All callers changed.
4881 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4882
7de51af5
PE
4883 * xfont.c (xfont_match): Avoid need for strlen.
4884
25ed6cc3
PE
4885 * xfns.c: Don't assume strlen fits in int.
4886 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4887
4eab31dd
PE
4888 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4889 not unsigned long, as we prefer signed integers. All callers changed.
4890 Detect integer overflow in repeat count.
4891 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4892 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4893
171e2a58
PE
4894 * termcap.c: Don't assume sizes fit in int and never overflow.
4895 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4896 (gobble_line): Check for size-calculation overflow.
4897
ad39faca 4898 * minibuf.c (Fread_buffer):
6e5bb2dc 4899 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4900 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4901 Don't assume string length fits in int.
4902
52c61c22 4903 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4904 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4905
b5b8c9e5
PE
4906 * font.c: Don't assume string length fits in int.
4907 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4908 Use ptrdiff_t, not int.
ccd6111c
PE
4909 (font_intern_prop): Don't assume string length fits in int.
4910 Don't assume integer property fits in fixnum.
4911 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4912
882f0d81 4913 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4914 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4915 Reformulate so as not to need the command string.
4916 Invoke gzip -cd rather than gunzip, as it's more portable.
4917 (lock_info_type, lock_file_1, lock_file):
4918 Don't assume pid_t and time_t fit in unsigned long.
4919 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4920 (current_lock_owner): Prefer signed type for sizes.
4921 Use memcpy, not strncpy, where memcpy is what is really wanted.
4922 Don't assume (via atoi) that time_t and pid_t fit in int.
4923 Check for time_t and/or pid_t out of range, e.g., via a network share.
4924 Don't alloca where an auto var works fine.
4925
93f4cf88
PE
4926 * fileio.c: Fix some integer overflow issues.
4927 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4928 Don't assume string length fits in int.
4929 (directory_file_name): Don't assume string length fits in long.
4930 (make_temp_name): Don't assume pid fits in int, or that its print
4931 length is less than 20.
4932
f3e92b69
PE
4933 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4934
1bfdaf10
PE
4935 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4936
35016e9a
PE
4937 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4938
3d1e65a1
PE
4939 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4940 We prefer signed integers, even for size calculations.
4941
0b963a93
PE
4942 * emacs.c: Don't assume string length fits in 'int'.
4943 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4944 (main): Don't invoke strlen when not needed.
4945
573f4b54
PE
4946 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4947 (XD_DEBUG_MESSAGE): Don't waste a byte.
4948
989f33ba
PE
4949 * callproc.c (getenv_internal_1, getenv_internal)
4950 (Fgetenv_internal):
965d34eb
PE
4951 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4952
e4d29b33
PE
4953 * lread.c (invalid_syntax): Omit length argument.
4954 All uses changed. This doesn't fix a bug, but it simplifies the
4955 code away from its former Hollerith-constant appearance, and it's
4956 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4957 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4958
eb49b136
PE
4959 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4960 This didn't break anything, but it didn't help either.
4961 It's confusing to put a bogus integer in a place where the actual
4962 value does not matter.
9f62aeb1 4963 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4964 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4965
15375a22
PE
4966 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4967 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4968 implementation.
b61cc01c
PE
4969 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4970 We prefer signed types, and the value cannot exceed the EMACS_INT
4971 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4972 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4973 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4974 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4975
53b2623d
PE
4976 * indent.c (sane_tab_width): New function.
4977 (current_column, scan_for_column, Findent_to, position_indentation)
4978 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4979 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4980
51cab52b 4981 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4982
f2ed8a70
PE
4983 * lisp.h (lint_assume): New macro.
4984 * composite.c (composition_gstring_put_cache):
4985 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4986
abe80cc6
PE
4987 * editfns.c, insdel.c:
4988 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4989
b02c740e
PE
4990 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4991
ebc96716
PE
4992 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4993
b4e50fa0 4994 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4995 Use much-faster test for byte-length change.
311d5d7c 4996 Don't assume string byte-length fits in 'int'.
a4cf38e4 4997 Check that character arg fits in 'int'.
85461888 4998 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4999
c0c1ee9f
PE
5000 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5001
a498d7f4
PE
5002 * fns.c (concat): Catch string overflow earlier.
5003 Do not rely on integer wraparound.
5004
51cab52b
PE
5005 * dispextern.h (struct it.overlay_strings_charpos)
5006 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5007 * xdisp.c (forward_to_next_line_start)
5008 (back_to_previous_visible_line_start)
5009 (reseat_at_next_visible_line_start, next_element_from_buffer):
5010 Don't arbitrarily truncate the value of 'selective' to int.
5011
76031fad
PE
5012 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5013
5eb55db9
PE
5014 * composite.c: Don't truncate sizes to 'int'.
5015 (composition_gstring_p, composition_reseat_it)
5016 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5017 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5018 not EMACS_UINT, for indexes.
5eb55db9 5019
0703a717
PE
5020 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5021
d6202519
PE
5022 * buffer.c: Include <verify.h>.
5023 (struct sortvec.priority, struct sortstr.priority):
8961a454 5024 Now EMACS_INT, not int.
c20998a7 5025 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5026 (struct sortstr.size, record_overlay_string)
5027 (struct sortstrlist.size, struct sortlist.used):
5028 Don't truncate size to int.
5029 (record_overlay_string): Check for size-calculation overflow.
d6202519 5030 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5031
d5a19415
JM
50322011-06-22 Jim Meyering <meyering@redhat.com>
5033
029529ac 5034 Don't leak an XBM-image-sized buffer
d5a19415
JM
5035 * image.c (xbm_load): Free the image buffer after using it.
5036
a9041e6c
PE
50372011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5038
5039 Port to Sun C.
5040 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5041 that Sun C diagnosed.
5042 * fns.c (secure_hash): Fix pointer signedness issue.
5043 * intervals.c (static_offset_intervals): New function.
5044 (offset_intervals): Use it.
5045
7f3f739f
LL
50462011-06-21 Leo Liu <sdl.web@gmail.com>
5047
5048 * deps.mk (fns.o):
5049 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5050 sha512.h.
5051
5052 * fns.c (secure_hash): Rename from crypto_hash_function and change
5053 the first arg to accept symbols.
5b66d427 5054 (Fsecure_hash): New primitive.
7f3f739f
LL
5055 (syms_of_fns): New symbols.
5056
76147d94
DD
50572011-06-20 Deniz Dogan <deniz@dogan.se>
5058
5059 * process.c (Fset_process_buffer): Clarify return value in
5060 docstring.
5061
7d7d0045
CY
50622011-06-18 Chong Yidong <cyd@stupidchicken.com>
5063
5064 * dispnew.c (add_window_display_history): Use BVAR.
5065
5066 * xdisp.c (debug_method_add): Use BVAR.
5067 (check_window_end, dump_glyph_matrix, dump_glyph)
5068 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5069
5070 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5071 Likewise.
5072
5073 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5074 check till after the cache is created in init_frame_faces.
5075
ff2bc410
SM
50762011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5077
5078 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5079
28177add
PE
50802011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5081
dd3482fe
PE
5082 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5083 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5084 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5085
393d71f3 5086 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5087 * fileio.c (Finsert_file_contents):
5088 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5089 Remove the old (too-loose) buffer overflow checks.
5090 They weren't needed, since make_gap checks for buffer overflow.
5091 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5092 The old code merely checked for Emacs fixnum overflow, and relied
5093 on undefined (wraparound) behavior. The new code avoids undefined
5094 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5095
2e6813b0 5096 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5097 Tune. Don't use wider integers than needed. Don't use alloca.
5098 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5099
599a9e4f
PE
5100 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5101
99561444
PE
5102 * insdel.c, lisp.h (buffer_overflow): New function.
5103 (insert_from_buffer_1, replace_range, replace_range_2):
5104 * insdel.c (make_gap_larger):
5105 * editfns.c (Finsert_char):
5106 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5107
28177add
PE
5108 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5109
e69dafad
PE
51102011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5111
4baa020d 5112 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5113
b1c46f02
PE
5114 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5115 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5116
e69dafad
PE
5117 * fileio.c: Don't assume EMACS_INT fits in off_t.
5118 (emacs_lseek): New static function.
5119 (Finsert_file_contents, Fwrite_region): Use it.
5120 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5121
566684ea
PE
5122 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5123
e6966cd6
PE
5124 * fns.c: Don't overflow int when computing a list length.
5125 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5126 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5127 truncation on 64-bit hosts. Check for QUIT every
5128 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5129 faster and is responsive enough.
5130 (Flength): Report an error instead of overflowing an integer.
5131 (Fsafe_length): Return a float if the value is not representable
5132 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5133 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5134 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5135
dd0b0efb
PE
5136 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5137 (header_size, word_size): New constants.
5138 (allocate_vectorlike): Don't check size overflow here.
5139 (allocate_vector): Check it here instead, since this is the only
5140 caller of allocate_vectorlike that could cause overflow.
5141 Check that the new vector's length is representable as a fixnum.
5142
86fe5cfe
PE
5143 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5144 The previous code was bogus. For example, next_almost_prime (32)
5145 returned 39, which is undesirable as it is a multiple of 3; and
5146 next_almost_prime (24) returned 25, which is a multiple of 5 so
5147 why was the code bothering to check for multiples of 7?
5148
80e88859
PE
5149 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5150
4a2f0ad6
PE
5151 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5152
f66c7cf8
PE
5153 Variadic C functions now count arguments with ptrdiff_t.
5154 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5155 Back then I didn't know that the Emacs coding style prefers signed int.
5156 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5157 were being counted with int, which may truncate counts on 64-bit
5158 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5159 * lisp.h (struct Lisp_Subr.function.aMANY)
5160 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5161 Arg counts are now ptrdiff_t, not size_t.
5162 All variadic functions and their callers changed accordingly.
5163 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5164 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5165 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5166 * callint.c (Fcall_interactively): Check arg count for overflow,
5167 to avoid potential buffer overrun. Use signed char, not 'int',
5168 for 'varies' array, so that we needn't bother to check its size
5169 calculation for overflow.
5170 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5171 * eval.c (apply_lambda):
5172 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5173 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5174 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5175
a1759b76
PE
5176 * callint.c (Fcall_interactively): Don't use index var as event count.
5177
d96be9fc
PE
5178 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5179 * mem-limits.h (SIZE): Remove; no longer used.
5180
a690a978 5181 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5182
578c21e6
PE
5183 Remove unnecessary casts.
5184 * xterm.c (x_term_init):
5185 * xfns.c (x_set_border_pixel):
5186 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5187 These aren't needed now that we assume ANSI C.
5188
96f53c6c
PE
5189 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5190 It's more likely to cause problems (due to unsigned overflow)
5191 than to cure them.
5192
83c77d31
PE
5193 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5194
ee2079f1
PE
5195 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5196
6da65536
PE
5197 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5198
7147c4a4
PE
5199 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5200
193e32d9
PE
5201 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5202
e5533da6
PE
5203 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5204
9910e595
PE
5205 GLYPH_CODE_FACE returns EMACS_INT, not int.
5206 * dispextern.h (merge_faces):
5207 * xfaces.c (merge_faces):
01103c44
PE
5208 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5209 Don't assume EMACS_INT fits in int.
9910e595 5210
2638320e
PE
5211 * character.h (CHAR_VALID_P): Remove unused parameter.
5212 * fontset.c, lisp.h, xdisp.c: All uses changed.
5213
045eb8d9
PE
5214 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5215
c1f134b5
PE
5216 * fns.c (concat): Minor tuning based on overflow analysis.
5217 This doesn't fix any bugs. Use int to hold character, instead
5218 of constantly refetching from Emacs object. Use XFASTINT, not
5219 XINT, for value known to be a character. Don't bother comparing
5220 a single byte to 0400, as it's always less.
5221
395fcb93 5222 * floatfns.c (Fexpt):
327eeec8
PE
5223 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5224
abbd3d23
PE
5225 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5226 for characters.
5227
684a03ef
PE
5228 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5229
0fed43f3
PE
5230 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5231 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5232 incorrectly succeed when S was a string, because 4294967386 was
5233 truncated before it was used.
5234
8fd02eb7
PE
5235 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5236 Otherwise, an out-of-range integer could cause undefined behavior
5237 on a 64-bit host.
5238
f8c86b69
PE
5239 * composite.c: Use int, not EMACS_INT, for characters.
5240 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5241 EMACS_INT, for values that are known to be in character range.
5242 This doesn't fix any bugs but is the usual style inside Emacs and
5243 may generate better code on 32-bit machines.
5244
34206dd2
PE
5245 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5246 This is for reasons similar to the recent CHAR_STRING fix.
5247 * charset.c (Fencode_char): Check that character arg is actually
5248 a character. Pass an int to ENCODE_CHAR.
5249 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5250 wider than 'int', as a compile-time check to prevent future regressions
5251 in this area.
5252
c5958d4c 5253 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5254
5255 Make sure a 64-bit char is never passed to CHAR_STRING.
5256 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5257 by silently ignoring the top 32 bits, allowing some values
5258 that were far too large to be valid characters.
5259 * character.h: Include <verify.h>.
5260 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5261 arguments are no wider than unsigned, as a compile-time check
5262 to prevent future regressions in this area.
5263 * data.c (Faset):
01103c44 5264 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5265 (Fsubst_char_in_region):
5266 * fns.c (concat):
5267 * xdisp.c (decode_mode_spec_coding):
5268 Adjust to CHAR_STRING's new requirement.
5269 * editfns.c (Finsert_char, Fsubst_char_in_region):
5270 * fns.c (concat): Check that character args are actually
5271 characters. Without this test, these functions did the wrong
5272 thing with wildly out-of-range values on 64-bit hosts.
5273
d37ca623
PE
5274 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5275 These casts should not be needed on 32-bit hosts, either.
5276 * keyboard.c (read_char):
5277 * lread.c (Fload): Remove casts to unsigned.
5278
ea204efb
PE
5279 * lisp.h (UNSIGNED_CMP): New macro.
5280 This fixes comparison bugs on 64-bit hosts.
5281 (ASCII_CHAR_P): Use it.
5282 * casefiddle.c (casify_object):
01103c44 5283 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5284 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5285 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5286 * dispextern.h (FACE_FROM_ID):
5287 * keyboard.c (read_char): Use UNSIGNED_CMP.
5288
41cb286c
PE
5289 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5290 not to EMACS_INT, to avoid GCC warning.
5291
4a1b9832
PE
5292 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5293
55daad71
PE
5294 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5295 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5296 isn't needed on 32-bit machines.
8f95c75c 5297
01103c44
PE
5298 * buffer.c (Fgenerate_new_buffer_name):
5299 Use EMACS_INT for count, not int.
0ceccced 5300 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5301
5302 * data.c (Qcompiled_function): Now static.
5303
c6f072e7
PE
5304 * window.c (window_body_lines): Now static.
5305
20ce5912
PE
5306 * image.c (gif_load): Rename local to avoid shadowing.
5307
9c4c5f81
PE
5308 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5309 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5310 * alloc.c (make_save_value): Integer argument is now of type
5311 ptrdiff_t, not int.
5312 (mark_object): Use ptrdiff_t, not int.
5313 * lisp.h (pD): New macro.
5314 * print.c (print_object): Use it.
5315
c0c5c8ae
PE
5316 * alloc.c: Use EMACS_INT, not int, to count objects.
5317 (total_conses, total_markers, total_symbols, total_vector_size)
5318 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5319 (total_free_floats, total_floats, total_free_intervals)
5320 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5321 Now EMACS_INT, not int. All uses changed.
5322 (Fgarbage_collect): Compute overall total using a double, so that
5323 integer overflow is less likely to be a problem. Check for overflow
5324 when converting back to an integer.
5a25e253
PE
5325 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5326 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5327 These were 'int' variables that could overflow on 64-bit hosts;
5328 they were never used, so remove them instead of repairing them.
211a0b2a 5329 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5330 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5331 Previously, this ceilinged at INT_MAX, but that doesn't work on
5332 64-bit machines.
e46bb31a 5333 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5334
c78baabf 5335 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5336 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5337 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5338 when a (possibly-narrower) signed value would do just as well.
5339 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5340
c9d624c6
PE
5341 * alloc.c: Catch some string size overflows that we were missing.
5342 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5343 for convenience in STRING_BYTES_MAX.
5344 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5345 The definition here is exact; the one in lisp.h was approximate.
5346 (allocate_string_data): Check for string overflow. This catches
5347 some instances we weren't catching before. Also, it catches
5348 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5349 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5350 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5351
c9d624c6
PE
5352 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5353 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5354 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5355
353032ce
PE
5356 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5357
2bccce07
PE
5358 * alloc.c (Fmake_string): Check for out-of-range init.
5359
0ac30604
SM
53602011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5361
5362 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5363
c195f2de
JD
53642011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5365
5366 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5367 xg_get_default_scrollbar_width.
5368
5369 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5370 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5371 (style_changed_cb): Call update_theme_scrollbar_width and call
5372 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5373 all frames (Bug#8505).
5374 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5375 Call gtk_window_set_resizable if HAVE_GTK3.
5376 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5377 and height if HAVE_GTK3 (Bug#8505).
5378 (scroll_bar_width_for_theme): New variable.
5379 (update_theme_scrollbar_width): New function.
5380 (xg_get_default_scrollbar_width): Move code to
5381 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5382 (xg_initialize): Call update_theme_scrollbar_width.
5383
5384 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5385
5386 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5387
e10ac9f1
MR
53882011-06-12 Martin Rudalics <rudalics@gmx.at>
5389
5390 * frame.c (make_frame): Call other_buffer_safely instead of
5391 other_buffer.
5392
5393 * window.c (temp_output_buffer_show): Call display_buffer with
5394 second argument Vtemp_buffer_show_specifiers and reset latter
5395 immediately after the call.
5396 (Vtemp_buffer_show_specifiers): New variable.
5397 (auto_window_vscroll_p, next_screen_context_lines)
5398 (Vscroll_preserve_screen_position): Remove leading asterisks from
5399 doc-strings.
5400
2d3c217e 54012011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5402
7b7f97e8 5403 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5404 * buffer.c (Qclone_number): Remove for now, as it's unused.
5405 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5406 (record_buffer): Remove unused local.
5407 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5408 (set_frame_buffer_list): Remove; unused.
5409 * frame.h (other_visible_frames): Remove decl.
5410 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5411 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5412 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5413 if HAVE_GPM.
5414 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5415 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5416 Define only if HAVE_GPM.
5417 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5418 (update_hints_inhibit): Remove; never set. All uses removed.
5419 * widgetprv.h (emacsFrameClassRec): Remove decl.
5420 * window.c (delete_deletable_window): Now returns void, since it
5421 wasn't returning anything.
5422 (compare_window_configurations): Remove unused locals.
5423 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5424 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5425 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5426 the same widths as pointers. This follows up on the 2011-05-06 patch.
5427 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5428 * xterm.h: Likewise.
5429 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5430
1384b89e
JB
54312011-06-12 Juanma Barranquero <lekktu@gmail.com>
5432
5433 * makefile.w32-in: Update dependencies.
5434 (LISP_H): Add lib/intprops.h.
5435
1100a63c
CY
54362011-06-11 Chong Yidong <cyd@stupidchicken.com>
5437
5438 * image.c (gif_load): Add animation frame delay to the metadata.
5439 (syms_of_image): Use DEFSYM. New symbol `delay'.
5440
6198ccd0
MR
54412011-06-11 Martin Rudalics <rudalics@gmx.at>
5442
5443 * window.c (delete_deletable_window): Re-add.
5444 (Fset_window_configuration): Rewrite to handle dead buffers and
5445 consequently deletable windows.
5446 (window_tree, Fwindow_tree): Remove. Supply functionality in
5447 window.el.
5448 (compare_window_configurations): Simplify code.
5449
b6e3633c
AS
54502011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5451
1ab0dee5
AS
5452 * image.c (imagemagick_load_image): Fix type mismatch.
5453 (Fimagemagick_types): Likewise.
5454
b6e3633c
AS
5455 * window.h (replace_buffer_in_windows): Declare.
5456
9397e56f
MR
54572011-06-11 Martin Rudalics <rudalics@gmx.at>
5458
5459 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5460 Qclone_number. Remove external declaration of Qdelete_window.
5461 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5462 code.
640c8776
SM
5463 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5464 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5465 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5466 buffer list implementation.
5467 (other_buffer_safely): New function.
5468 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5469 calls to replace_buffer_in_windows and
5470 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5471 if allowed.
5472 (record_buffer): Inhibit quitting and rewrite using quittable
5473 functions. Run Qbuffer_list_update_hook if allowed.
5474 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5475 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5476 Move switch-to-buffer to window.el.
9397e56f
MR
5477 (bury-buffer): Move to window.el.
5478 (Vbuffer_list_update_hook): New variable.
5479
5480 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5481 section.
5482
5483 * window.h (resize_frame_windows): Move up in code.
5484 (Fwindow_frame): Remove EXFUN.
5485 (replace_buffer_in_all_windows): Remove prototype.
5486 (replace_buffer_in_windows_safely): Add prototype.
5487
5488 * window.c: Declare Qdelete_window static again. Move down
5489 declaration of select_count.
5490 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5491 (Fother_window): Move to window.el.
5492 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5493 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5494 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5495 window.el.
5496 (replace_buffer_in_windows): Implement by calling
5497 Qreplace_buffer_in_windows.
5498 (replace_buffer_in_all_windows): Remove with some functionality
5499 moved into replace_buffer_in_windows_safely.
5500 (replace_buffer_in_windows_safely): New function.
5501 (select_window_norecord, select_frame_norecord): Move in front
5502 of run_window_configuration_change_hook. Remove now obsolete
5503 declarations.
640c8776
SM
5504 (Fset_window_buffer): Rewrite doc-string.
5505 Call Qrecord_window_buffer.
9397e56f
MR
5506 (keys_of_window): Move binding for other-window to window.el.
5507
b50691aa
CY
55082011-06-11 Chong Yidong <cyd@stupidchicken.com>
5509
5510 * dispextern.h (struct image): Replace data member, whose int_val
5511 and ptr_val fields were not used by anything, with a single
5512 lisp_val object.
5513
5514 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5515 (gif_clear_image, gif_load, imagemagick_load_image)
5516 (gs_clear_image, gs_load): Callers changed.
5517
3f754b86
PE
55182011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5519
cca69397
PE
5520 * buffer.h: Include <time.h>, for time_t.
5521 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5522
109e28d0
PE
5523 Fix minor problems found by static checking.
5524
60737f02
PE
5525 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5526
4b66faf3
PE
5527 Make identifiers static if they are not used in other modules.
5528 * data.c (Qcompiled_function, Qframe, Qvector):
5529 * image.c (QimageMagick, Qsvg):
5530 * minibuf.c (Qmetadata):
5531 * window.c (resize_window_check, resize_root_window): Now static.
5532 * window.h (resize_window_check, resize_root_window): Remove decls.
5533
109e28d0
PE
5534 * window.c (window_deletion_count, delete_deletable_window):
5535 Remove; unused.
46a4ce9e
PE
5536 (window_body_lines): Now static.
5537 (Fdelete_other_windows_internal): Mark vars as initialized.
5538 Make sure 'resize_failed' is initialized.
5539 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5540 (resize_window_apply): Remove unused local.
5541 * window.h (delete_deletable_window): Remove decl.
5542
109e28d0 5543 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5544 (imagemagick_load_image): Fix pointer signedness problem by changing
5545 last arg from unsigned char * to char *. All uses changed.
5546 Also, fix a local for similar reasons.
5547 Remove unused locals. Remove locals to avoid shadowing.
5548 (fn_rsvg_handle_free): Remove; unused.
5549 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5550 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5551
3f754b86
PE
5552 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5553
2547adb1
CY
55542011-06-10 Chong Yidong <cyd@stupidchicken.com>
5555
5556 * image.c (gif_load): Fix omitted cast error introduced by
5557 2011-06-06 change.
5558
2c8e37d4
MR
55592011-06-10 Martin Rudalics <rudalics@gmx.at>
5560
5561 * window.h (resize_proportionally, orig_total_lines)
5562 (orig_top_line): Remove from window structure.
5563 (set_window_height, set_window_width, change_window_heights)
5564 (Fdelete_window): Remove prototypes.
5565 (resize_frame_windows): Remove duplicate declaration.
5566
440a42e3
EZ
55672011-06-10 Eli Zaretskii <eliz@gnu.org>
5568
5569 * window.h (resize_frame_windows, resize_window_check)
5570 (delete_deletable_window, resize_root_window)
5571 (resize_frame_windows): Declare prototypes.
5572
5573 * window.c (resize_window_apply): Make definition be "static" to
5574 match the prototype.
5575
562dd5e9
MR
55762011-06-10 Martin Rudalics <rudalics@gmx.at>
5577
5578 * window.c: Remove declarations of Qwindow_size_fixed,
5579 window_min_size_1, window_min_size_2, window_min_size,
5580 size_window, window_fixed_size_p, enlarge_window, delete_window.
5581 Remove static from declaration of Qdelete_window, it's
5582 temporarily needed by Fbury_buffer.
5583 (replace_window): Don't assign orig_top_line and
5584 orig_total_lines.
5585 (Fdelete_window, delete_window): Remove. Window deletion is
5586 handled by window.el.
640c8776
SM
5587 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5588 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5589 (Fdelete_other_windows): Remove. Deleting other windows is
5590 handled by window.el.
5591 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5592 handled in window.el.
5593 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5594 Window minimum sizes are handled in window.el.
5595 (shrink_windows, size_window, set_window_height)
5596 (set_window_width, change_window_heights, window_height)
5597 (window_width, CURBEG, CURSIZE, enlarge_window)
5598 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5599 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5600 handled in window.el.
5601 (make_dummy_parent): Rename to make_parent_window and give it a
5602 second argument horflag.
5603 (make_window): Don't set resize_proportionally any more.
5604 (Fsplit_window): Remove. Windows are split in window.el.
5605 (save_restore_action, save_restore_orig_size)
5606 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5607 Resize mini windows in window.el.
5608 (grow_mini_window, shrink_mini_window): Implement by calling
5609 Qresize_root_window_vertically, resize_window_check and
5610 resize_window_apply.
640c8776
SM
5611 (saved_window, Fset_window_configuration, save_window_save):
5612 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5613 resize_proportionally.
5614 (window_min_height, window_min_width): Move to window.el.
5615 (keys_of_window): Move bindings for delete-other-windows,
5616 split-window, delete-window and enlarge-window to window.el.
5617
5618 * buffer.c: Temporarily extern Qdelete_window.
5619 (Fbury_buffer): Temporarily call Qdelete_window instead of
5620 Fdelete_window (Fbury_buffer will move to window.el soon).
5621
5622 * frame.c (set_menu_bar_lines_1): Remove code handling
5623 orig_top_line and orig_total_lines.
5624
5625 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5626 set_window_height but set heights directly.
5627 (change_frame_size_1): Use resize_frame_windows.
5628
5629 * xdisp.c (init_xdisp): Don't use set_window_height but set
5630 heights directly.
5631
640c8776
SM
5632 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5633 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5634 run_window_configuration_change_hook.
5635
5636 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5637 instead of change_window_heights and run
5638 run_window_configuration_change_hook.
5639
1a13852e
MR
56402011-06-09 Martin Rudalics <rudalics@gmx.at>
5641
5642 * window.c (replace_window): Rename second argument REPLACEMENT to
5643 NEW. New third argument SETFLAG. Rewrite.
5644 (delete_window, make_dummy_parent): Call replace_window with
5645 third argument 1.
5646 (window_list_1): Move down in code.
5647 (run_window_configuration_change_hook): Move set_buffer part
5648 before select_frame_norecord part in order to unwind correctly.
5649 Rename count1 to count.
5650 (recombine_windows, delete_deletable_window, resize_root_window)
5651 (Fdelete_other_windows_internal)
5652 (Frun_window_configuration_change_hook, make_parent_window)
5653 (resize_window_check, resize_window_apply, Fresize_window_apply)
5654 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5655 (Fdelete_window_internal, Fresize_mini_window_internal):
5656 New functions.
1a13852e
MR
5657 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5658
f3d1777e
MR
56592011-06-08 Martin Rudalics <rudalics@gmx.at>
5660
496e208e
MR
5661 * window.h (window): Add some new members to window structure -
5662 normal_lines, normal_cols, new_total, new_normal, clone_number,
5663 splits, nest, prev_buffers, next_buffers.
5664 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5665 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5666
f3d1777e
MR
5667 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5668 Remove.
496e208e
MR
5669 (make_dummy_parent): Set new members of windows structure.
5670 (make_window): Move down in code. Handle new members of window
5671 structure.
5672 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5673 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5674 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5675 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5676 (Fset_window_next_buffers, Fset_window_clone_number):
5677 New functions.
496e208e
MR
5678 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5679 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5680 Doc-string fixes.
5681 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5682 Argument WINDOW can be now internal window too.
5683 (Fwindow_use_time): Move up in code.
5684 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5685 Rewrite doc-string.
5686 (Fset_window_configuration, saved_window)
5687 (Fcurrent_window_configuration, save_window_save): Handle new
5688 members of window structure.
b9e809c2
MR
5689 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5690 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5691 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5692 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5693 Qget_mru_window, Qresize_root_window,
5694 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5695 Qauto_buffer_name; staticpro them.
f3d1777e 5696
abde8f8c
MR
56972011-06-07 Martin Rudalics <rudalics@gmx.at>
5698
5699 * window.c (Fwindow_total_size, Fwindow_left_column)
5700 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5701 (Fwindow_list_1): New functions.
5702 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5703 (Fwindow_width, Fscroll_left, Fscroll_right):
5704 Use window_body_cols instead of window_box_text_cols.
5705 (delete_window, Fset_window_configuration):
5706 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5707 (delete_all_subwindows): Take a window as argument and not a
5708 structure. Rewrite.
190b47e6
MR
5709 (window_loop): Remove handling of GET_LRU_WINDOW and
5710 GET_LARGEST_WINDOW.
5711 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5712
5713 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5714 window_box_text_cols. delete_all_subwindows now takes a
5715 Lisp_Object as argument.
abde8f8c 5716
640c8776
SM
5717 * indent.c (compute_motion, Fcompute_motion):
5718 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5719
fa8a67e6
MR
5720 * frame.c (delete_frame): Call delete_all_subwindows with root
5721 window as argument.
5722
a54e3482
DC
57232011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5724
5725 * fns.c (Fputhash): Document return value.
5726
60002bf5
CY
57272011-06-06 Chong Yidong <cyd@stupidchicken.com>
5728
5729 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5730
0c671da6 57312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5732
b862a52a 5733 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5734
be44ca6c
PE
5735 Check for overflow when converting integer to cons and back.
5736 * charset.c (Fdefine_charset_internal, Fdecode_char):
5737 Use cons_to_unsigned to catch overflow.
5738 (Fencode_char): Use INTEGER_TO_CONS.
5739 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5740 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5741 * data.c (long_to_cons, cons_to_long): Remove.
5742 (cons_to_unsigned, cons_to_signed): New functions.
5743 These signal an error for invalid or out-of-range values.
5744 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5745 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5746 * font.c (Ffont_variation_glyphs):
5747 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5748 * lisp.h: Include <intprops.h>.
5749 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5750 (cons_to_signed, cons_to_unsigned): New decls.
5751 (long_to_cons, cons_to_long): Remove decls.
5752 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5753 (Fprimitive_undo): Use CONS_TO_INTEGER.
5754 * xfns.c (Fx_window_property): Likewise.
5755 * xselect.c: Include <limits.h>.
5756 (x_own_selection, selection_data_to_lisp_data):
5757 Use INTEGER_TO_CONS.
5758 (x_handle_selection_request, x_handle_selection_clear)
5759 (x_get_foreign_selection, Fx_disown_selection_internal)
5760 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5761 (lisp_data_to_selection_data): Use cons_to_unsigned.
5762 (x_fill_property_data): Use cons_to_signed.
5763 Report values out of range.
5764
d1f3d2af
PE
5765 Check for buffer and string overflow more precisely.
5766 * buffer.h (BUF_BYTES_MAX): New macro.
5767 * lisp.h (STRING_BYTES_MAX): New macro.
5768 * alloc.c (Fmake_string):
5769 * character.c (string_escape_byte8):
5770 * coding.c (coding_alloc_by_realloc):
5771 * doprnt.c (doprnt):
5772 * editfns.c (Fformat):
5773 * eval.c (verror):
5774 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5775 since they may not be the same number.
5776 * editfns.c (Finsert_char):
5777 * fileio.c (Finsert_file_contents):
5778 Likewise for BUF_BYTES_MAX.
5779
dd52fcea
PE
5780 * image.c: Use ptrdiff_t, not int, for sizes.
5781 (slurp_file): Switch from int to ptrdiff_t.
5782 All uses changed.
5783 (slurp_file): Check that file size fits in both size_t (for
5784 malloc) and ptrdiff_t (for sanity and safety).
5785
7f9bbdbb
PE
5786 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5787 if b->modtime has its maximal value.
5788
dfe18f82
PE
5789 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5790
84acfcf0
PE
5791 Don't assume time_t can fit into int.
5792 * buffer.h (struct buffer.modtime): Now time_t, not int.
5793 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5794 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5795
ccd9a01a
PE
5796 Minor fixes for signed vs unsigned integers.
5797 * character.h (MAYBE_UNIFY_CHAR):
5798 * charset.c (maybe_unify_char):
5799 * keyboard.c (read_char, reorder_modifiers):
5800 XINT -> XFASTINT, since the integer must be nonnegative.
5801 * ftfont.c (ftfont_spec_pattern):
5802 * keymap.c (access_keymap, silly_event_symbol_error):
5803 XUINT -> XFASTINT, since the integer must be nonnegative.
5804 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5805 since it makes no difference and we prefer signed.
5806 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5807 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5808 nonnegative.
5809
d6d100dd
SM
58102011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5811
5812 * window.h (Fwindow_frame): Declare.
5813
2b6148e4
PE
58142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5815
5816 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5817 (SPARE_MEMORY): Always define.
5818 (LARGE_REQUEST): Remove.
5819 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5820
f230ecc9
MR
58212011-06-06 Martin Rudalics <rudalics@gmx.at>
5822
727e958e
MR
5823 * lisp.h: Move EXFUNS for Fframe_root_window,
5824 Fframe_first_window and Fset_frame_selected_window to window.h.
5825
5826 * window.h: Move EXFUNS for Fframe_root_window,
5827 Fframe_first_window and Fset_frame_selected_window here from
5828 lisp.h.
5829
5830 * frame.c (Fwindow_frame, Fframe_first_window)
5831 (Fframe_root_window, Fframe_selected_window)
5832 (Fset_frame_selected_window): Move to window.c.
5833 (Factive_minibuffer_window): Move to minibuf.c.
5834 (Fother_visible_frames_p): New function.
5835
5836 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5837
f230ecc9
MR
5838 * window.c (decode_window, decode_any_window): Move up in code.
5839 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5840 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5841 (Fwindow_buffer): Move up and rewrite doc-string.
5842 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5843 (Fwindow_prev): New functions.
727e958e
MR
5844 (Fwindow_frame): Move here from frame.c. Accept any window as
5845 argument.
5846 (Fframe_root_window, Fframe_first_window)
5847 (Fframe_selected_window): Move here from frame.c. Accept frame
5848 or arbitrary window as argument. Update doc-strings.
5849 (Fminibuffer_window): Move up in code.
5850 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5851 (Fset_frame_selected_window): Move here from frame.c.
5852 Marginal rewrite.
727e958e
MR
5853 (Fselected_window, select_window, Fselect_window): Move up in
5854 code. Minor doc-string fixes.
f230ecc9 5855
4d09bcf6
PE
58562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5857
5858 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5859 Do not assume that spare memory exists; that assumption is valid
5860 only if SYSTEM_MALLOC.
5861 (LARGE_REQUEST): New macro, so that the issue of large requests
5862 is separated from the issue of spare memory.
5863
810928a2
AS
58642011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5865
172418ad
AS
5866 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5867 format. (Bug#8806)
5868
43f862f7
AS
5869 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5870
810928a2
AS
5871 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5872 before statements.
5873
a059fe24
JD
58742011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5875
5876 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5877
5878 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5879
5880 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5881 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5882
989bf368
JB
58832011-06-05 Juanma Barranquero <lekktu@gmail.com>
5884
5885 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5886
4b80f674
CY
58872011-06-04 Chong Yidong <cyd@stupidchicken.com>
5888
5889 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5890 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5891 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5892 New error handlers.
4b80f674
CY
5893 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5894 Obey Vx_select_enable_clipboard_manager. Catch errors in
5895 x_clipboard_manager_save (Bug#8779).
5896 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5897 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5898
99a33b77 58992011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5900
5901 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5902
99a33b77 59032011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5904
5905 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5906 in the current matrix if keep_current_p is non-zero.
5907
8264569d
EZ
59082011-06-04 Eli Zaretskii <eliz@gnu.org>
5909
5910 * bidi.c (bidi_level_of_next_char): Fix last change.
5911
57f97249
EZ
59122011-06-03 Eli Zaretskii <eliz@gnu.org>
5913
fec2107c 5914 Support bidi reordering of text covered by display properties.
57f97249 5915
fec2107c
EZ
5916 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5917 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5918 (bidi_cache_search, bidi_cache_iterator_state)
5919 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5920 (bidi_level_of_next_char, bidi_move_to_visually_next):
5921 Support character positions inside a run of characters covered by a
fec2107c
EZ
5922 display string.
5923 (bidi_paragraph_init, bidi_resolve_explicit_1)
5924 (bidi_level_of_next_char): Call bidi_fetch_char and
5925 bidi_fetch_char_advance instead of FETCH_CHAR and
5926 FETCH_CHAR_ADVANCE.
5927 (bidi_init_it): Initialize new members.
5928 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5929 definitions.
5930 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5931 instead of using explicit *_CHAR codes.
d6d100dd
SM
5932 (bidi_resolve_explicit, bidi_resolve_weak):
5933 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5934 bidirectional text is supported only in multibyte buffers.
5935 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5936 it to initialize the frame_window_p member of struct bidi_it.
5937 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5938 (bidi_resolve_explicit, bidi_resolve_weak)
5939 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5940 bidi_it->nchars is non-positive.
5941 (bidi_level_of_next_char): Don't try to lookup the cache for the
5942 next/previous character if nothing is cached there yet, or if we
5943 were just reseat()'ed to a new position.
c40e2fb2 5944
0e14fe90
EZ
5945 * xdisp.c (set_cursor_from_row): Set start and stop points
5946 according to the row's direction when priming the loop that looks
5947 for the glyph on which to display cursor.
5948 (single_display_spec_intangible_p): Function deleted.
5949 (display_prop_intangible_p): Reimplement to call
5950 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5951 Accept 3 additional arguments needed by handle_display_spec.
5952 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5953 values: lists, `(when COND...)' forms, etc.
5954 (single_display_spec_string_p): Support property values that are
5955 lists with the argument STRING its top-level element.
5956 (display_prop_string_p): Fix the condition for processing a
5957 property that is a list to be consistent with handle_display_spec.
fec2107c 5958 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5959 last portion of handle_display_prop.
5960 (compute_display_string_pos): Accept additional argument
5961 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5962 value of a `display' property is a "replacing spec".
5963 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5964 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5965 the display property, but just return a value indicating whether
5966 the display property will replace the characters it covers.
5967 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5968 frame_window_p members of struct bidi_it.
d6d100dd
SM
5969 (compute_display_string_pos, compute_display_string_end):
5970 New functions.
fec2107c
EZ
5971 (push_it): Accept second argument POSITION, where pop_it should
5972 jump to continue iteration.
5973 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5974
fec2107c
EZ
5975 * keyboard.c (adjust_point_for_property): Adjust the call to
5976 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5977
5978 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5979 (bidi_init_it): Update prototypes.
5980 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5981 (compute_display_string_pos, compute_display_string_end):
5982 Declare prototypes.
fec2107c
EZ
5983 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5984 EMACS_INT.
fc6f18ce 5985
40087514 59862011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5987
57f53182
PE
5988 Malloc failure behavior now depends on size of allocation.
5989 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5990 * lisp.h: Change signatures accordingly.
5991 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5992 All callers changed. (Bug#8762)
5993
5994 * gnutls.c: Use Emacs's memory allocators.
5995 Without this change, the gnutls library would invoke malloc etc.
5996 directly, which causes problems on non-SYNC_INPUT hosts, and which
5997 runs afoul of improving memory_full behavior. (Bug#8761)
5998 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5999 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6000 xfree instead of the default malloc, realloc, free.
6001 (Fgnutls_boot): No need to check for memory allocation failure,
6002 since xmalloc does that for us.
6003
ac32cd99 6004 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6005 * category.c (hash_get_category_set):
6006 * ccl.c (ccl_driver):
6007 * charset.c (Fdefine_charset_internal):
6008 * charset.h (struct charset.hash_index):
6009 * composite.c (get_composition_id, gstring_lookup_cache)
6010 (composition_gstring_put_cache):
6011 * composite.h (struct composition.hash_index):
6012 * dispextern.h (struct image.hash):
6013 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6014 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6015 (hashfn_equal, hashfn_user_defined, make_hash_table)
6016 (maybe_resize_hash_table, hash_lookup, hash_put)
6017 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6018 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6019 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6020 * image.c (make_image, search_image_cache, lookup_image)
6021 (xpm_put_color_table_h):
6022 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6023 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6024 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6025 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6026 * alloc.c (allocate_vectorlike):
6027 Check for overflow in vector size calculations.
6028 * ccl.c (ccl_driver):
6029 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6030 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6031 need to be updated by these changes.
40087514
PE
6032 * fns.c (make_hash_table, maybe_resize_hash_table):
6033 Check for integer overflow with large hash tables.
0de4bb68
PE
6034 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6035 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6036 (SXHASH_REDUCE): New macro.
6037 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6038 Use it instead of discarding useful hash info with large hash values.
6039 (sxhash_float): New function.
6040 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6041 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6042 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6043 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6044 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6045 Adjust signatures to match updated version of code.
6046 (consing_since_gc): Now EMACS_INT, since a single hash table can
6047 use more than INT_MAX bytes.
6048
698d32e2
DN
60492011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6050
6051 Make it possible to build with GCC-4.6+ -O2 -flto.
6052
6053 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6054
fd6fa53f
SM
60552011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6056
6057 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6058 Call minibuffer-inactive-mode.
6059
864db017
JB
60602011-05-31 Juanma Barranquero <lekktu@gmail.com>
6061
6062 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6063 Update dependencies.
6064
2ad0baf4
DN
60652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6066
6067 * data.c (init_data): Remove code for UTS, this system is not
6068 supported anymore.
6069
4fcc2638
DN
60702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6071
6072 Don't force ./temacs to start in terminal mode.
6073
6074 * frame.c (make_initial_frame): Initialize faces in all cases, not
6075 only when CANNOT_DUMP is defined.
6076 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6077
c56e0fd5
DN
60782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6079
6080 * dispnew.c (add_window_display_history): Use const for the string
6081 pointer. Remove declaration, not needed.
6082
333d54da 60832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6084
55d4c1b2 6085 Use 'inline', not 'INLINE'.
333d54da 6086 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6087 * alloc.c, fontset.c (INLINE): Remove.
6088 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6089 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6090 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6091 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6092 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6093
738db178
DN
60942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6095
6096 Make it possible to run ./temacs.
6097
6098 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6099 syms_of_callproc does the same thing. Remove test for
6100 "initialized", do it in the caller.
6101 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6102
620c53a6
SM
61032011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6104
6105 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6106 (read_minibuf): Use get_minibuffer.
6107 (syms_of_minibuf): Use DEFSYM.
6108 (Qmetadata): New var.
6109 * data.c (Qbuffer): Don't make it static.
6110 (syms_of_data): Use DEFSYM.
6111
e003a292
PE
61122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6113
6114 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6115 (CCL_CODE_MIN): New macro.
6116
ed008a6d
PE
61172011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6118
3687c2ef
PE
6119 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6120
ed008a6d
PE
6121 * eval.c (Qdebug): Now static.
6122 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6123 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6124 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6125
d66c4c7c
CY
61262011-05-29 Chong Yidong <cyd@stupidchicken.com>
6127
6128 * image.c: Various fixes to ImageMagick code comments.
6129 (Fimagemagick_types): Doc fix.
6130
5fbc2025
PE
61312011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6132
0196f88a
PE
6133 Minor fixes prompted by GCC 4.6.0 warnings.
6134
6135 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6136
5fbc2025
PE
6137 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6138 (x_clipboard_manager_save_all): Move extern decl to ...
6139 * xterm.h: ... here, so that it can be checked for consistency.
6140
1dd3c2d9
CY
61412011-05-29 Chong Yidong <cyd@stupidchicken.com>
6142
6143 * xselect.c (x_clipboard_manager_save_frame)
6144 (x_clipboard_manager_save_all): New functions.
6145 (Fx_clipboard_manager_save): Lisp function deleted.
6146
6147 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6148 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6149
6150 * xterm.h: Update prototype.
6151
5ba6571d
WX
61522011-05-28 William Xu <william.xwl@gmail.com>
6153
6154 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6155 exiting (Bug#8239).
6156
3eaff834
JM
61572011-05-28 Jim Meyering <meyering@redhat.com>
6158
e1900994 6159 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6160 * fns.c (to_uchar): Define.
6161 (crypto_hash_function): Use it to convert some newly-signed
6162 variables to unsigned, to avoid sign-extension bugs. For example,
6163 without this change, (md5 "truc") would evaluate to
6164 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6165 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6166 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6167
0f6990a7
PE
61682011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6169
6170 Integer overflow fixes.
c8a9ca5a 6171
08686060
PE
6172 * dbusbind.c: Serial number integer overflow fixes.
6173 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6174 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6175 to hold a serial number that is too large for a fixnum.
6176 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6177 Check for serial numbers out of range. Decode any serial number
59568bf0 6178 that was so large that it became a float. (Bug#8722)
08686060 6179
2d1fc3c7
PE
6180 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6181 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6182 Use XFASTINT rather than XUINT when numbers are nonnegative.
6183 (xd_append_arg, Fdbus_method_return_internal):
6184 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6185 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6186 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6187 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6188 (Bug#8722)
2d1fc3c7 6189
c8a9ca5a
PE
6190 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6191
519e1d69
PE
6192 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6193
6df6ae42 6194 ccl: Add integer overflow checks.
30569699
PE
6195 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6196 (IN_INT_RANGE): New macros.
6197 (ccl_driver): Use them to check for integer overflow when
6198 decoding a CCL program. Many of the new checks are whether XINT (x)
6199 fits in int; it doesn't always, on 64-bit hosts. The new version
6200 doesn't catch all possible integer overflows, but it's an
847044ea 6201 improvement. (Bug#8719)
30569699 6202
c11285dc
PE
6203 * alloc.c (make_event_array): Use XINT, not XUINT.
6204 There's no need for unsigned here.
6205
fdccd48e
PE
6206 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6207 This follows up to the 2011-05-06 change that substituted uintptr_t
6208 for EMACS_INT. This case wasn't caught back then.
6209
37910ab2
PE
6210 Rework Fformat to avoid integer overflow issues.
6211 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6212 now (part of C89). Include <verify.h>.
6213 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6214 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6215 (Fformat): Avoid the prepass trying to compute sizes; it was only
6216 approximate and thus did not catch overflow reliably. Instead, walk
6217 through the format just once, formatting and computing sizes as we go,
6218 checking for integer overflow at every step, and allocating a larger
6219 buffer as needed. Keep track separately whether the format is
6220 multibyte. Keep only the most-recently calculated precision, rather
6221 than them all. Record whether each argument has been converted to
6222 string. Use EMACS_INT, not int, for byte and char and arg counts.
6223 Support field widths and precisions larger than INT_MAX. Avoid
6224 sprintf's undefined behavior with conversion specifications such as %#d
6225 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6226 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6227 formatting out-of-range floating point numbers with int
9173deec 6228 formats. (Bug#8668)
37910ab2 6229
2e6578fb
PE
6230 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6231
0ae6bdee
PE
6232 * data.c: Avoid integer truncation in expressions involving floats.
6233 * data.c: Include <intprops.h>.
6234 (arith_driver): When there's an integer overflow in an expression
6235 involving floating point, convert the integers to floating point
6236 so that the resulting value does not suffer from catastrophic
6237 integer truncation. For example, on a 64-bit host (* 4
6238 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6239 Do not rely on undefined behavior after integer overflow.
6240
de883a70
PE
6241 merge count_size_as_multibyte, parse_str_to_multibyte
6242 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6243 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6244 Check for integer overflow.
6245 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6246 since it's now a duplicate of the other. This is more of
6247 a character than a buffer op, so better that it's in character.c.
6248 * fns.c, print.c: Adjust to above changes.
6249
2ff916cb
PE
62502011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6251
6252 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6253
f1b54466
PE
62542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6255
fb1ac845
PE
6256 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6257 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6258 (x_clipboard_manager_save): Now static.
6259 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6260
f1b54466
PE
6261 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6262 (crypto_hash_function): Now static.
6263 Fix pointer signedness problems. Avoid unnecessary initializations.
6264
a9f737ee
CY
62652011-05-27 Chong Yidong <cyd@stupidchicken.com>
6266
6267 * termhooks.h (Vselection_alist): Make it terminal-local.
6268
6269 * terminal.c (create_terminal): Initialize it.
6270
6271 * xselect.c: Support for clipboard managers.
6272 (Vselection_alist): Move to termhooks.h as terminal-local var.
6273 (LOCAL_SELECTION): New macro.
6274 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6275 (symbol_to_x_atom): Remove gratuitous arg.
6276 (x_handle_selection_request, lisp_data_to_selection_data)
6277 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6278 (x_own_selection, x_get_local_selection, x_convert_selection):
6279 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6280 (some_frame_on_display): Delete unused function.
6281 (Fx_own_selection_internal, Fx_get_selection_internal)
6282 (Fx_disown_selection_internal, Fx_selection_owner_p)
6283 (Fx_selection_exists_p): New optional frame arg.
6284 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6285 (x_handle_selection_clear): Don't treat other terminals with the
6286 same keyboard specially. Use the terminal-local Vselection_alist.
6287 (x_clear_frame_selections): Use Frun_hook_with_args.
6288
6289 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6290
6291 * xterm.h: Add support for those atoms.
6292
e067f0c1
CY
62932011-05-26 Chong Yidong <cyd@stupidchicken.com>
6294
6295 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6296 (converted_selections, conversion_fail_tag): New global variables.
6297 (x_selection_request_lisp_error): Free the above.
6298 (x_get_local_selection): Remove unnecessary code.
6299 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6300 of converted selections stored in converted_selections.
6301 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6302 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6303 (x_convert_selection): New function.
6304 (x_handle_selection_event): Simplify.
6305 (x_get_foreign_selection): Don't ignore incoming requests while
6306 waiting for an answer; this will fail when we implement
6307 SAVE_TARGETS, and seems unnecessary anyway.
6308 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6309 (Vx_sent_selection_functions): Doc fix.
6310
0f4aebc0
LL
63112011-05-26 Leo Liu <sdl.web@gmail.com>
6312
6313 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6314
e61124cd
YM
63152011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6316
6317 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6318
6319 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6320 for fringe update if it has periodic bitmap.
ac389d0c 6321 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6322 and fringe_bitmap_periodic_p.
6323
6324 * fringe.c (get_fringe_bitmap_data): New function.
6325 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6326 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6327 row. Mark glyph row for fringe update if periodicity changed.
6328
6329 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6330 for fringe update unless it has periodic bitmap.
6331
f16d9837
KH
63322011-05-25 Kenichi Handa <handa@m17n.org>
6333
6334 * xdisp.c (get_next_display_element): Set correct it->face_id for
6335 a static composition.
6336
e1b90ef6
LL
63372011-05-24 Leo Liu <sdl.web@gmail.com>
6338
6339 * deps.mk (fns.o):
6340 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6341
6342 * fns.c (crypto_hash_function, Fsha1): New function.
6343 (Fmd5): Use crypto_hash_function.
6344 (syms_of_fns): Add Ssha1.
6345
7400048f
PE
63462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6347
6348 * gnutls.c: Remove unused macros.
6349 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6350 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6351 Remove macros that are defined and never used.
6352 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6353
abb71cf4
CY
63542011-05-22 Chong Yidong <cyd@stupidchicken.com>
6355
6356 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6357 (Fx_get_selection_internal): Minor cleanup.
6358 (Fx_own_selection_internal): Rename arguments for consistency with
6359 select.el.
6360
6307db39
PE
63612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6362
6363 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6364
f3d4e0a4
CY
63652011-05-22 Chong Yidong <cyd@stupidchicken.com>
6366
6367 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6368
4d8ade89
YM
63692011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6370
6371 * dispnew.c (scrolling_window): Don't exclude the case that the
6372 last enabled row in the desired matrix touches the bottom boundary.
6373
32078c8d
GM
63742011-05-21 Glenn Morris <rgm@gnu.org>
6375
6376 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6377 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6378 and add some more files.
32078c8d 6379
7285dc67
EZ
63802011-05-20 Eli Zaretskii <eliz@gnu.org>
6381
6382 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6383 report_file_error introduced by the change from 2011-05-07.
6384
89d1bd22
PE
63852011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6386
6387 * systime.h (Time): Define only if emacs is defined.
6388 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6389 where the include path doesn't have X11/X.h by default. See
6390 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6391
cd394be1 63922011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6393
6394 * composite.c (find_automatic_composition): Fix previous change.
6395
b9704ad9
GM
63962011-05-20 Glenn Morris <rgm@gnu.org>
6397
6398 * lisp.mk: New file, split from Makefile.in.
6399 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6400 (shortlisp): Remove.
6401 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6402
4a720484
GM
64032011-05-19 Glenn Morris <rgm@gnu.org>
6404
6405 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6406 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6407 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6408 (lisp): Set the order to that of loadup.el.
6409 (shortlisp): Make it a copy of $lisp.
6410 (SOME_MACHINE_LISP): Remove.
6411 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6412 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6413
a28d4396
KH
64142011-05-18 Kenichi Handa <handa@m17n.org>
6415
6416 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6417 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6418 (find_automatic_composition): Mostly rewrite for efficiency.
6419
a2b1fa8e
JB
64202011-05-18 Juanma Barranquero <lekktu@gmail.com>
6421
6422 * makefile.w32-in: Update dependencies.
6423
8e1f5610
CS
64242011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6425
6426 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6427 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6428
7025ee00 64292011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6430
cdfa6eab
PE
6431 Fix some integer overflow issues, such as string length overflow.
6432
06d6db33
PE
6433 * insdel.c (count_size_as_multibyte): Check for string overflow.
6434
2b4560a8
PE
6435 * character.c (lisp_string_width): Check for string overflow.
6436 Use EMACS_INT, not int, for string indexes and lengths; in
6437 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6438 the resulting string length overflows an EMACS_INT; instead,
6439 report a string overflow if no precision given. When checking for
6440 precision exhaustion, use a check that cannot possibly have
6441 integer overflow. (Bug#8675)
6442 * character.h (lisp_string_width): Adjust to new signature.
6443
cb93f9be
PE
6444 * alloc.c (string_overflow): New function.
6445 (Fmake_string): Use it. This doesn't change behavior, but saves
6446 a few bytes and will simplify future changes.
6447 * character.c (string_escape_byte8): Likewise.
6448 * lisp.h (string_overflow): New decl.
6449
1a1f3366
PE
6450 Fixups, following up to the user-interface timestamp change.
6451 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6452 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6453 * msdos.c (mouse_get_pos): Likewise.
6454 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6455 * w32gui.h (Time): Define by including "systime.h" rather than by
6456 declaring it ourselves. (Bug#8664)
6457
d4e3e4d3
PE
6458 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6459 * image.c (clear_image_cache): Likewise.
6460
f6a24d19
PE
6461 * term.c (term_mouse_position): Don't assume time_t wraparound.
6462
08dc5ae6
PE
6463 Be more systematic about user-interface timestamps.
6464 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6465 and sometimes 'EMACS_UINT', to represent these timestamps.
6466 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6467 This makes the code easier to follow, and makes it easier to catch
6468 integer overflow bugs such as Bug#8664.
6469 * frame.c (Fmouse_position, Fmouse_pixel_position):
6470 Use Time, not unsigned long, for user-interface timestamps.
6471 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6472 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6473 * keyboard.h (last_event_timestamp): Likewise.
6474 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6475 * menu.h (xmenu_show): Likewise.
6476 * term.c (term_mouse_position): Likewise.
6477 * termhooks.h (struct input_event.timestamp): Likewise.
6478 (struct terminal.mouse_position_hook): Likewise.
6479 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6480 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6481 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6482 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6483 what it was before.
6484 * menu.h, termhooks.h: Include "systime.h", for Time.
6485
8e55734a
PE
6486 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6487 Don't assume that the difference between two unsigned long values
6488 can fit into an integer. At this point, we know button_down_time
6489 <= event->timestamp, so the difference must be nonnegative, so
6490 there's no need to cast the result if double-click-time is
6491 nonnegative, as it should be; check that it's nonnegative, just in
6492 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6493 apart (about 25 days). (Bug#8664)
8e55734a 6494
841f1b75 6495 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6496 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6497
3e26f69c
PE
6498 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6499 that always fit in int. Use a sentinel instead of a counter, to
6500 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6501 * frame.h (struct frame): Use int for menu_bar_items_used
6502 instead of EMACS_INT, since it always fits in int.
3e26f69c 6503
5cc152c0
PE
6504 * menu.c (grow_menu_items): Check for int overflow.
6505
d89eb65e
PE
6506 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6507
5235bd3e
PE
6508 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6509 Before, the code was not consistent. These values cannot exceed
6510 2**31 - 1 so there's no need to make them unsigned.
6511 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6512 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6513 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6514 as modifiers.
6515 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6516
bc827e23
PE
6517 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6518 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6519 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6520 presumably because the widths might not match.
6521
78eb494e
PE
6522 * window.c (size_window): Avoid needless test at loop start.
6523
04f2d78b
CB
65242011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6525
6526 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6527
d2fc7e3d 65282011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6529
6530 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6531
d2fc7e3d 65322011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6533
6534 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6535 `width' to `bar_area_x' and `bar_area_width', respectively.
6536 (x_scroll_run): Take account of fringe background extension.
6537
04f2d78b
CB
6538 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6539 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6540 `bar_area_width', respectively.
6541 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6542 background extension.
6543
79b70037
GM
65442011-05-10 Jim Meyering <meyering@redhat.com>
6545
6546 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6547
2f142cc5
JB
65482011-05-10 Juanma Barranquero <lekktu@gmail.com>
6549
6550 * image.c (Finit_image_library): Return t for built-in image types,
6551 like pbm and xbm. (Bug#8640)
6552
57679c86
AS
65532011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6554
6555 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6556
888c9e86
EZ
65572011-05-07 Eli Zaretskii <eliz@gnu.org>
6558
b0512a1d
EZ
6559 * w32console.c (Fset_screen_color): Doc fix.
6560 (Fget_screen_color): New function.
6561 (syms_of_ntterm): Defsubr it.
6562
7285dc67
EZ
6563 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6564 unlink the temporary file if Fcall_process didn't create it in the
6565 first place.
6566 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6567 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6568 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6569 cue to call_process_cleanup not to close that handle.
6570
4d3fcc8e
BK
65712011-05-07 Ben Key <bkey76@gmail.com>
6572
6573 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6574 one of two shell specific rules, either bootstrap-temacs-CMD or
6575 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6576 to the previous implementation of the bootstrap-temacs rule.
6577 The bootstrap-temacs-CMD rule is similar to the previous
6578 implementation of the bootstrap-temacs rule except that it
6579 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6580 variable.
6581
6582 These changes, along with some changes to nt/configure.bat,
6583 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6584 earlier fix to add support for --cflags and --ldflags options
6585 that include quotes so that it works whether make uses cmd or
6586 sh as the shell.
6587
b4289b64
MA
65882011-05-06 Michael Albinus <michael.albinus@gmx.de>
6589
6590 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6591 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6592 is a constant.
6593 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6594 a string. Handle both cases.
6595 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6596 (Fdbus_register_method): Use Qinvalid_function.
6597
af4c0e28
JB
65982011-05-06 Juanma Barranquero <lekktu@gmail.com>
6599
6600 * makefile.w32-in: Update dependencies.
6601 (LISP_H): Add inttypes.h and stdin.h.
6602 (PROCESS_H): Add unistd.h.
6603
c51453d9
EZ
66042011-05-06 Eli Zaretskii <eliz@gnu.org>
6605
6606 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6607 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6608
8ff0ac3c 66092011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6610
4c4b566b
PE
6611 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6612
aab2b9b5
PE
6613 * term.c (vfatal): Remove stray call to va_end.
6614 It's not needed and the C Standard doesn't allow it here anyway.
6615
c378da0b
PE
6616 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6617 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6618
288b08c7
PE
6619 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6620 bytes.
6621
e3601888
PE
6622 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6623
db6c0e74
PE
6624 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6625
dd5963ea
PE
6626 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6627
88c9450f
PE
6628 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6629
2f9442b8
PE
6630 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6631
c032b5f8
PE
6632 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6633 * charset.c (Fdefine_charset_internal): Don't initialize
6634 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6635 32-bit int (Bug#8600).
a108c10b
PE
6636
6637 * lread.c (read_integer): Be more consistent with string-to-number.
6638 Use string_to_number to do the actual conversion; this avoids
6639 rounding errors and fixes some other screwups. Without this fix,
6640 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6641 (digit_to_number): Move earlier, for benefit of read_integer.
6642 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6643 not a digit in any supported base. (Bug#8602)
a108c10b 6644
ad5f9eea
PE
6645 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6646
aec1708a
PE
6647 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6648 to match comment at start of function. This also removes a
6649 GCC warning about overflow in a 32+64-bit port.
6650
47be4ab5
PE
6651 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6652
371cac43
PE
6653 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6654 Reported by Stefan Monnier in
6655 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6656 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6657 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6658
d01a7826
PE
6659 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6660 (EMACS_UINTPTR): Likewise, with uintptr_t.
6661
7fd47d5c
PE
6662 * lisp.h: Prefer 64-bit EMACS_INT if available.
6663 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6664 on 32-bit hosts that have 64-bit int, so that they can access
6665 large files.
122b0c86
PE
6666 However, temporarily disable this change unless the temporary
6667 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6668
8727937b
PE
6669 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6670
8ac068ac
PE
6671 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6672 This removes an assumption that EMACS_INT and long are the same
6673 width as pointers. The assumption is true for Emacs porting targets
6674 now, but we want to make other targets possible.
6675 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6676 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6677 In the rest of the code, change types of integers that hold casted
6678 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6679 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6680 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6681 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6682 No need to cast type when ORing.
6683 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6684 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6685 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6686 assume EMACS_INT is the same width as char *.
6687 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6688 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6689 Remove no-longer-needed casts.
6690 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6691 (xg_tool_bar_help_callback, xg_make_tool_item):
6692 Use EMACS_INTPTR to hold an integer
6693 that will be cast to void *; this can avoid a GCC warning
6694 if EMACS_INT is not the same width as void *.
6695 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6696 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6697 (current_message_1, set_message_1):
6698 Use a local to convert to proper width without a cast.
6699 * xmenu.c (dialog_selection_callback): Likewise.
6700
ede49d71
PE
6701 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6702 Also, don't assume VALBITS / RAND_BITS is less than 5,
6703 and don't rely on undefined behavior when shifting a 1 left into
6704 the sign bit.
6705 * lisp.h (get_random): Change signature to match.
6706
2f30ecd0
PE
6707 * lread.c (hash_string): Use size_t, not int, for hash computation.
6708 Normally we prefer signed values; but hashing is special, because
6709 it's better to use unsigned division on hash table sizes so that
6710 the remainder is nonnegative. Also, size_t is the natural width
6711 for hashing into memory. The previous code used 'int', which doesn't
6712 retain enough info to hash well into very large tables.
6713 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6714
2a866e7b
PE
6715 * dbusbind.c: Don't possibly lose pointer info when converting.
6716 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6717 Use XPNTR rather than XHASH, so that the high-order bits of
6718 the pointer aren't lost when converting through void *.
6719
51639eac
PE
6720 * eval.c (Fautoload): Don't double-shift a pointer.
6721
92394119
PE
6722 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6723
dbdb9a7c
JB
67242011-05-06 Juanma Barranquero <lekktu@gmail.com>
6725
6726 * gnutls.c (DEF_GNUTLS_FN):
6727 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6728
db7a0b4f
AS
67292011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6730
6731 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6732 marker. (Bug#8610)
6733
cd394be1 67342011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6735
6736 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6737 New version that can reserve upto 2GB of heap space.
6738
f7ff1b0f 67392011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6740
6741 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6742
639c109b
TZ
67432011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6744
6745 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6746 `gnutls_certificate_set_x509_key_file'.
6747
d2127135
JB
67482011-05-05 Juanma Barranquero <lekktu@gmail.com>
6749
6750 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6751 Update dependencies.
6752
e968f4f3
JB
67532011-05-04 Juanma Barranquero <lekktu@gmail.com>
6754
6755 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6756 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6757 Remove unused parameter `fildes'.
6758 * process.c (read_process_output, send_process): Don't pass it.
6759
84d358f0
JB
67602011-05-04 Juanma Barranquero <lekktu@gmail.com>
6761
6762 Fix previous change: the library cache is defined in w32.c.
6763 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6764 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6765
0898ca10
JB
67662011-05-04 Juanma Barranquero <lekktu@gmail.com>
6767
6768 Implement dynamic loading of GnuTLS on Windows.
6769
6770 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6771 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6772 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6773 Declare.
6774
6775 * gnutls.c (Qgnutls_dll): Define.
6776 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6777 (gnutls_*): Declare function pointers.
6778 (init_gnutls_functions): New function to initialize function pointers.
6779 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6780 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6781 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6782 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6783 (emacs_gnutls_write, emacs_gnutls_read)
6784 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6785 (Fgnutls_available_p): New function.
6786 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6787 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6788 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6789
6790 * image.c: Include w32.h.
6791 (Vimage_type_cache): Delete.
6792 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6793 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6794 (w32_delayed_load): Move to w32.c.
6795
6796 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6797
6798 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6799 (w32_delayed_load): Move from image.c. When loading a library, record
6800 its filename in the :loaded-from property of the library id.
6801 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6802 Initialize and staticpro them.
6803 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6804
6805 * process.c: Include lisp.h before w32.h, not after.
6806 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6807 instead of gnutls_record_check_pending.
6808
6809 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6810
ff4de4aa
TZ
68112011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6812
6813 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6814 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6815 as passed in.
6816
abe95abb
JD
68172011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6818
6819 * xterm.c (x_set_frame_alpha): Do not set property on anything
6820 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6821
e16e55d4
JB
68222011-05-02 Juanma Barranquero <lekktu@gmail.com>
6823
6824 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6825
bafcf6a5
JB
68262011-05-02 Juanma Barranquero <lekktu@gmail.com>
6827
6828 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6829 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6830 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6831 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6832 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6833 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6834 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6835 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6836 (Qgnutls_bootprop_callbacks_verify): Make static.
6837
e7a6747f
AS
68382011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6839
19ed11ba
AS
6840 * callproc.c: Indentation fixup.
6841
e7a6747f 6842 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6843 (wait_for_termination, interruptible_wait_for_termination):
6844 Move after wait_for_termination_1.
e7a6747f 6845
1ef14cb4
LMI
68462011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6847
6848 * sysdep.c (interruptible_wait_for_termination): New function
6849 which is like wait_for_termination, but allows keyboard
6850 interruptions.
6851
6852 * callproc.c (Fcall_process): Add (:file "file") as an option for
6853 the STDOUT buffer.
6854 (Fcall_process_region): Ditto.
6855
330d880c
EZ
68562011-04-30 Eli Zaretskii <eliz@gnu.org>
6857
8db90b73
EZ
6858 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6859 rather than `XVECTOR (FOO)->size'.
6860
330d880c
EZ
6861 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6862 inttypes.h, as a gnulib replacement is used if it not available in
6863 system headers.
6864
15cbd324
EZ
68652011-04-21 Eli Zaretskii <eliz@gnu.org>
6866
6867 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6868 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6869 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6870
6871 * coding.c (coding_alloc_by_realloc): Error out if destination
6872 will grow beyond MOST_POSITIVE_FIXNUM.
6873 (decode_coding_emacs_mule): Abort if there isn't enough place in
6874 charbuf for the composition carryover bytes. Reserve an extra
6875 space for up to 2 characters produced in a loop.
6876 (decode_coding_iso_2022): Abort if there isn't enough place in
6877 charbuf for the composition carryover bytes.
6878
68792011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6880
ae940cca
EZ
6881 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6882 aborting when %lld or %lll format is passed.
6883 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6884 %llo or %llx format is passed. (Bug#8545)
6885
03ab8921
EZ
6886 * window.c (window_scroll_line_based): Use a marker instead of
6887 simple variables to record original value of point. (Bug#7952)
6888
afda1437
EZ
6889 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6890 produced by %s or %c overflows available buffer space. (Bug#8545)
6891
f76dee0c
PE
68922011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6893
6894 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6895 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6896
fdc5744d
JB
68972011-04-28 Juanma Barranquero <lekktu@gmail.com>
6898
6899 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6900
638f053a
JB
69012011-04-28 Juanma Barranquero <lekktu@gmail.com>
6902
6903 * keyboard.c (Qdelayed_warnings_hook): Define.
6904 (command_loop_1): Run `delayed-warnings-hook'
6905 if Vdelayed_warnings_list is non-nil.
6906 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6907 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6908
d178f871
EZ
69092011-04-28 Eli Zaretskii <eliz@gnu.org>
6910
6911 * doprnt.c (doprnt): Don't return value smaller than the buffer
6912 size if the message was truncated. (Bug#8545).
6913
b124fd93
JB
69142011-04-28 Juanma Barranquero <lekktu@gmail.com>
6915
6916 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6917 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6918
e810457d
PE
69192011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6920
6921 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6922
ea51cceb
JB
69232011-04-27 Juanma Barranquero <lekktu@gmail.com>
6924
6925 * makefile.w32-in: Update dependencies.
6926
94dcfacf
EZ
69272011-04-27 Eli Zaretskii <eliz@gnu.org>
6928
6929 Improve `doprnt' and its usage. (Bug#8545)
6930 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6931 `format_end'. Remove support for %l as a conversion specifier.
6932 Don't use xrealloc. Improve diagnostics when the %l size modifier
6933 is used. Update the commentary.
6934
6935 * eval.c (verror): Simplify calculation of size_t.
6936
6937 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6938 messages.
6939
f61f41d7
PE
69402011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6941
6942 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6943 change.
6944
96fb4434
PE
69452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6946
6947 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6948 This makes this file independent of the recent pseudovector change.
6949
671875da 69502011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6951
69e9b5a3
PE
6952 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6953
b5f869a7 6954 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6955 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6956 Remove unused local.
c8926152 6957 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6958
841a1577 6959 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6960 GCC 4.6.0 optimizes based on type-based alias analysis.
6961 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6962 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6963 != &v->size, and therefore "v->size = 1; b->size = 2; return
6964 v->size;" must therefore return 1. This assumption is incorrect
6965 for Emacs, since it type-puns struct Lisp_Vector * with many other
6966 types. To fix this problem, this patch adds a new type struct
f904488f 6967 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6968 and pseudovectors, and helps optimizing compilers not get fooled
6969 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6970 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6971 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6972 the size member.
eab3844f
PE
6973 (XSETPVECTYPE): Rewrite in terms of new macro.
6974 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6975 This is a bit clearer, and further avoids the possibility of
6976 undesirable aliasing.
6977 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6978 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6979 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6980 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6981 (ASIZE): Now uses header.size rather than size.
6982 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6983 to avoid the hassle of writing XVECTOR (foo)->header.size.
6984 (struct vectorlike_header): New type.
eab3844f
PE
6985 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6986 object, to help avoid aliasing.
6987 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6988 (SUBRP): Likewise, since Lisp_Subr is a special case.
6989 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6990 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6991 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6992 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6993 changed to be "header.size" and "header.next".
6994 * buffer.h (struct buffer): Likewise.
6995 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6996 * frame.h (struct frame): Likewise.
6997 * process.h (struct Lisp_Process): Likewise.
6998 * termhooks.h (struct terminal): Likewise.
6999 * window.c (struct save_window_data, struct saved_window): Likewise.
7000 * window.h (struct window): Likewise.
7001 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7002 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7003 * buffer.c (init_buffer_once): Likewise.
7004 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7005 special case.
7006 * process.c (Fformat_network_address): Use local var for size,
7007 for brevity.
7008
0df1eac5
PE
7009 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7010
847ab9d1 7011 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7012 * data.c (atof): Remove decl; no longer used or needed.
7013 (digit_to_number): Move to lread.c.
7014 (Fstring_to_number): Use new string_to_number function, to be
7015 consistent with how the Lisp reader treats infinities and NaNs.
7016 Do not assume that floating-point numbers represent EMACS_INT
7017 without losing information; this is not true on most 64-bit hosts.
7018 Avoid double-rounding errors, by insisting on integers when
7019 parsing non-base-10 numbers, as the documentation specifies.
7020 * lisp.h (string_to_number): New decl, replacing ...
7021 (isfloat_string): Remove.
bc0a5c13 7022 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7023 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7024 appears to have been a coding error. Similarly, do not accept
7025 strings like +-1e0 as floating point numbers. Do not report
7026 overflow for integer overflows unless the base is not 10 which
7027 means we have no simple and reliable way to continue.
7028 Break out the floating-point parsing into a new
7029 function string_to_number, so that Fstring_to_number parses
7030 floating point numbers consistently with the Lisp reader.
04f2d78b 7031 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7032 (E_CHAR, EXP_INT): Remove, replacing with ...
7033 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7034 (string_to_number): New function, replacing isfloat_string.
7035 This function checks for valid syntax and produces the resulting
7036 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7037 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7038 so that overflow for non-base-10 numbers is reported only when
7039 there's no portable and simple way to convert to floating point.
452f4150 7040
67769ffc
PE
7041 * textprop.c (set_text_properties_1): Rewrite for clarity,
7042 and to avoid GCC warning about integer overflow.
7043
c20db43f
PE
7044 * intervals.h (struct interval): Use EMACS_INT for members
7045 where EMACS_UINT might cause problems. See
7046 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7047 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7048 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7049 All uses changed.
37aa2f85
PE
7050 (offset_intervals): Tell GCC not to worry about length overflow
7051 when negating a negative length.
c20db43f 7052
2538aa2f
PE
7053 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7054 (overrun_check_free): Likewise.
7055
f2d3008d
PE
7056 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7057 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7058 word size.
7059
ec8df744
PE
7060 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7061 (gnutls_make_error): Rename local to avoid shadowing.
7062 (gnutls_emacs_global_deinit): ifdef out; not used.
7063 (Fgnutls_boot): Use const for pointer to readonly storage.
7064 Comment out unused local. Fix pointer signedness problems.
7065
640ee02d
PE
7066 * lread.c (openp): Don't stuff size_t into an 'int'.
7067 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7068 about possible signed overflow.
7069
6048fb2a
PE
7070 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7071 (GDK_KEY_g): Don't define if already defined.
7072 (xg_prepare_tooltip): Avoid pointer signedness problem.
7073 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7074
fa3c87e1
PE
7075 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7076 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7077
2172544b
PE
7078 * xfns.c (Fx_window_property): Simplify a bit,
7079 to make a bit faster and to avoid GCC 4.6.0 warning.
7080 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7081
9b821a21
PE
7082 * fns.c (internal_equal): Don't assume size_t fits in int.
7083
3c616cfa
PE
7084 * alloc.c (compact_small_strings): Tighten assertion a little.
7085
c2982e87
PE
7086 Replace pEd with more-general pI, and fix some printf arg casts.
7087 * lisp.h (pI): New macro, generalizing old pEd macro to other
7088 conversion specifiers. For example, use "...%"pI"d..." rather
7089 than "...%"pEd"...".
7090 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7091 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7092 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7093 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7094 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7095 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7096 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7097 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7098 64-bit hosts.
7099 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7100 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7101 * print.c (safe_debug_print, print_object): Likewise.
7102 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7103 to int.
6f04d126
PE
7104 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7105 avoiding the 0 flag, which is not portable.
c2982e87
PE
7106 * process.c (Fmake_network_process): Use pI to avoid cast.
7107 * region-cache.c (pp_cache): Likewise.
7108 * xdisp.c (decode_mode_spec): Likewise.
7109 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7110 behavior on 64-bit hosts with printf arg.
6f04d126 7111 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7112 (x_stop_queuing_selection_requests): Likewise.
7113 (x_get_window_property): Don't truncate byte count to an 'int'
7114 when tracing.
0b432f21 7115
5e073ec7
PE
7116 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7117 here, since it parses constructs like leading '-' and spaces,
7118 which are not wanted; and it overflows with large numbers.
7119 Instead, simply match F[0-9]+, which is what is wanted anyway.
7120
36372bf9
PE
7121 * alloc.c: Remove unportable assumptions about struct layout.
7122 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7123 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7124 (allocate_vectorlike, make_pure_vector): Use the new macros,
7125 plus offsetof, to remove unportable assumptions about struct layout.
7126 These assumptions hold on all porting targets that I know of, but
7127 they are not guaranteed, they're easy to remove, and removing them
7128 makes further changes easier.
7129
0b432f21
PE
7130 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7131 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7132 (string_overrun_cookie): Now const. Use initializers that
7133 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7134 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7135 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7136 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7137 multiple of sizeof (EMACS_INT); it need not be, if
7138 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7139 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7140
895009e1
JB
71412011-04-26 Juanma Barranquero <lekktu@gmail.com>
7142
7143 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7144
6a7a1b0b
TZ
71452011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7146
7147 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7148 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7149 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7150
841a1577 71512011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7152
7153 * lisp.h (Qdebug): List symbol.
895009e1 7154 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7155 * keyboard.c (debug-on-event): New variable.
7156 (handle_user_signal): Break into debugger when debug-on-event
7157 matches the current signal symbol.
7158
f2d3ba6f
DN
71592011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7160
7161 * alloc.c (check_sblock, check_string_bytes)
7162 (check_string_free_list): Convert to standard C.
7163
42ce4c63
TZ
71642011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7165
7166 * w32.c (emacs_gnutls_push): Fix typo.
7167
825cd63c
EZ
71682011-04-25 Eli Zaretskii <eliz@gnu.org>
7169
fb11d64d
EZ
7170 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7171 "cast to pointer from integer of different size".
7172
825cd63c
EZ
7173 Improve doprnt and its use in verror. (Bug#8545)
7174 * doprnt.c (doprnt): Document the set of format control sequences
7175 supported by the function. Use SAFE_ALLOCA instead of always
7176 using `alloca'.
7177
7178 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7179 is one byte too soon. Don't use xrealloc; instead xfree and
7180 xmalloc anew.
7181
e061a11b
TZ
71822011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7183
7184 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7185 callbacks stage.
7186
7187 * gnutls.c: Renamed global_initialized to
7188 gnutls_global_initialized. Added internals for the
7189 :verify-hostname-error, :verify-error, and :verify-flags
7190 parameters of `gnutls-boot' and documented those parameters in the
7191 docstring. Start callback support.
9173deec
JB
7192 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7193 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7194 on error. Return error code.
e061a11b
TZ
7195 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7196 (emacs_gnutls_read): Likewise.
7197 (Fgnutls_boot): Return handshake error code.
7198 (emacs_gnutls_handle_error): New function.
7199 (wsaerror_to_errno): Likewise.
7200
7201 * w32.h (emacs_gnutls_pull): Add prototype.
7202 (emacs_gnutls_push): Likewise.
7203
7204 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7205 (emacs_gnutls_push): Likewise.
7206
72072011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7208
7209 * process.c (wait_reading_process_output): Check if GnuTLS
7210 buffered some data internally if no FDs are set for TLS
7211 connections.
7212
7213 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7214 (LIBS): Link to USER_LIBS.
7215 ($(BLD)/gnutls.$(0)): New target.
7216
fa6996bc
EZ
72172011-04-24 Eli Zaretskii <eliz@gnu.org>
7218
eb35682e
EZ
7219 * xdisp.c (handle_single_display_spec): Rename the
7220 display_replaced_before_p argument into display_replaced_p, to
7221 make it consistent with the commentary. Fix typos in the
7222 commentary.
7223
e2ad650c
EZ
7224 * textprop.c (syms_of_textprop): Remove dead code.
7225 (copy_text_properties): Delete obsolete commentary about an
7226 interface that was deleted long ago. Fix typos in the description
7227 of arguments.
7228
1b2de274
EZ
7229 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7230 to changes in oldXMenu/XMenu.h from 2011-04-16.
7231 <menu_help_message, prev_menu_help_message>: Constify.
7232 (IT_menu_make_room): menu->help_text is now `const char **';
7233 adjust.
7234
7235 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7236 to changes in oldXMenu/XMenu.h from 2011-04-16.
7237 (struct XMenu): Declare `help_text' `const char **'.
7238
7239 * xfaces.c <Qunspecified>: Make extern again.
7240
7241 * syntax.c: Include sys/types.h before including regex.h, as
7242 required by Posix.
7243
762b15be
EZ
7244 * doc.c (get_doc_string): Improve the format passed to `error'.
7245
7246 * doprnt.c (doprnt): Improve commentary.
7247
7248 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7249
7250 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7251 them with etags.
7252
f1052e5d
EZ
7253 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7254 changes in globals.h immediately force recompilation.
762b15be
EZ
7255 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7256 $(CURDIR)/s/ms-w32.h.
7257 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7258
fa6996bc
EZ
7259 * character.c (Fchar_direction): Function deleted.
7260 (syms_of_character): Don't defsubr it.
7261 <char-direction-table>: Deleted.
7262
e6c3da20
EZ
72632011-04-23 Eli Zaretskii <eliz@gnu.org>
7264
7265 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7266 * doprnt.c: Include limits.h.
7267 (SIZE_MAX): New macro.
04f2d78b
CB
7268 (doprnt): Return a size_t value. 2nd arg is now size_t.
7269 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7270 Improve overflow protection. Support `l' modifier for integer
7271 conversions. Support %l conversion. Don't assume an EMACS_INT
7272 argument for integer conversions and for %c.
7273
7274 * lisp.h (doprnt): Restore prototype.
7275
7276 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7277 $(SRC)/character.h.
7278
7279 * Makefile.in (base_obj): Add back doprnt.o.
7280
7281 * deps.mk (doprnt.o): Add back prerequisites.
7282 (callint.o): Depend on character.h.
7283
7284 * eval.c (internal_lisp_condition_case): Include the handler
7285 representation in the error message.
7286 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7287 when breaking from the loop.
7288
7289 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7290
7291 * callint.c (Fcall_interactively): When displaying error message
7292 about invalid control letter, pass the character's codepoint, not
7293 a pointer to its multibyte form. Improve display of the character
7294 in octal and display also its hex code.
7295
7296 * character.c (char_string): Use %x to display the (unsigned)
7297 codepoint of an invalid character, to avoid displaying a bogus
7298 negative value.
7299
7300 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7301 `error', not SYMBOL_NAME itself.
7302
7303 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7304 character arguments to `error'.
7305
7306 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7307 to `error' in error message about FINAL_CHAR argument. Make sure
7308 FINAL_CHAR is a character, and use %c when it is passed as
7309 argument to `error'.
7310
4ffd0d6b 73112011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7312
7313 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7314
7315 * w32.c: Include <time.h>.
7316 (sys_localtime): New function.
7317
4ffd0d6b 73182011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7319
7320 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7321
4ffd0d6b 7322 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7323
4ffd0d6b 73242011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7325
4ffd0d6b
GM
7326 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7327 zombies (Bug#8467).
aac0c6e3 7328
04c56954
EZ
73292011-04-19 Eli Zaretskii <eliz@gnu.org>
7330
7331 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7332 gl_state.e_property when gl_state.object is Qt.
7333
7334 * insdel.c (make_gap_larger): Remove limitation of buffer size
7335 to <= INT_MAX.
7336
16a43933
CY
73372011-04-18 Chong Yidong <cyd@stupidchicken.com>
7338
7339 * xdisp.c (lookup_glyphless_char_display)
7340 (produce_glyphless_glyph): Handle cons cell entry in
7341 glyphless-char-display.
7342 (Vglyphless_char_display): Document it.
7343
7344 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7345 glyphless-char-display.
7346
4581706e
CY
73472011-04-17 Chong Yidong <cyd@stupidchicken.com>
7348
7349 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7350
7351 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7352
7353 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7354 definition for no-X builds.
7355
4887c6e2 73562011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7357
fd35b6f9
PE
7358 Static checks with GCC 4.6.0 and non-default toolkits.
7359
5c1ccb01
PE
7360 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7361
006c5daa
PE
7362 * process.c (keyboard_bit_set): Define only if SIGIO.
7363 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7364 (send_process): Repair possible setjmp clobbering.
7365
efc736d3
PE
7366 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7367
4e2fe2e6
PE
7368 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7369
f97334a2
PE
7370 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7371
4e75f29d
PE
7372 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7373 Define only if needed.
7374
90efadd1
PE
7375 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7376 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7377 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7378
3c647824
PE
7379 * dispextern.h (struct redisplay_interface): Rename param
7380 to avoid shadowing.
e264f262 7381 * termhooks.h (struct terminal): Likewise.
761383f4 7382 * xterm.c (xembed_send_message): Likewise.
3c647824 7383
b58c5c4a
PE
7384 * insdel.c (make_gap_smaller): Define only if
7385 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7386
cad59032
PE
7387 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7388 it.
7389
c339dc2e
PE
7390 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7391 so that we aren't warned about unused symbols.
7392
91a3e27b
PE
7393 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7394
399c71d3 7395 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7396
8ffc96f5
PE
7397 * xfns.c (x_real_positions): Mark locals as initialized.
7398
eef9bc79
PE
7399 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7400
098db9dd
PE
7401 * xterm.c: Fix problems found by static analysis with other toolkits.
7402 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7403 (x_dispatch_event): Declare static if USE_GTK, and
7404 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7405 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7406 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7407 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7408 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7409
eb18f6cc
PE
7410 * xmenu.c (menu_help_callback): Pointer type fixes.
7411 Use const pointers when pointing at readonly data. Avoid pointer
7412 signedness clashes.
7413 (FALSE): Remove unused macro.
7414 (update_frame_menubar): Remove unused decl.
7415
1fe72bf8
PE
7416 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7417
60d9e1db
PE
7418 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7419 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7420 (single_menu_item): Rename local to avoid shadowing.
7421
39261c26
PE
7422 * keyboard.c (make_lispy_event): Remove unused local var.
7423
018c5e19
PE
7424 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7425 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7426
63d2b86e
PE
7427 * bitmaps: Change bitmaps from unsigned char back to the X11
7428 compatible char. Avoid the old compiler warnings about
7429 out-of-range initializers by using, for example, '\xab' rather
7430 than 0xab.
7431
aefd87e1
PE
7432 * xgselect.c (xgselect_initialize): Check vs interface
7433 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7434
bf501fb9
PE
7435 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7436
e9829fdf
PE
7437 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7438 to read-only memory.
7439
1086c095
PE
7440 * fns.c (vector): Remove; this old hack is no longer needed.
7441
2baccd04 7442 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7443 Remove unused var.
dde42981 7444 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7445
72391843 7446 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7447
436c16df 7448 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7449 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7450 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7451
92bb796d 7452 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7453 (x_term_init): Remove local to avoid shadowing.
92bb796d 7454
764430a3 7455 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7456
7457 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7458 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7459
d1dfb56c
EZ
74602011-04-16 Eli Zaretskii <eliz@gnu.org>
7461
c4354cb4
EZ
7462 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7463
d1dfb56c
EZ
7464 Fix regex.c, syntax.c and friends for buffers > 2GB.
7465 * syntax.h (struct gl_state_s): Declare character position members
7466 EMACS_INT.
7467
7468 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7469
04f2d78b
CB
7470 * textprop.c (verify_interval_modification, interval_of):
7471 Declare arguments EMACS_INT.
d1dfb56c
EZ
7472
7473 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7474 EMACS_INT.
7475
7476 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7477
7478 * indent.c (Fvertical_motion): Local variable it_start is now
7479 EMACS_INT.
7480
7481 * regex.c (re_match, re_match_2, re_match_2_internal)
7482 (bcmp_translate, regcomp, regexec, print_double_string)
7483 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7484 (re_compile_pattern, re_exec): Declare arguments and local
7485 variables `size_t' and `ssize_t' and return values `regoff_t', as
7486 appropriate.
7487 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7488 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7489 <compile_stack_type>: `size' and `avail' are now `size_t'.
7490
7491 * regex.h <regoff_t>: Use ssize_t, not int.
7492 (re_search, re_search_2, re_match, re_match_2): Arguments that
7493 specify buffer/string position and length are now ssize_t and
7494 size_t. Return type is regoff_t.
7495
613052cd
BK
74962011-04-16 Ben Key <bkey76@gmail.com>
7497
7498 * nsfont.m: Fixed bugs in ns_get_family and
7499 ns_descriptor_to_entity that were caused by using free to
7500 deallocate memory blocks that were allocated by xmalloc (via
7501 xstrdup). This caused Emacs to crash when compiled with
7502 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7503 --enable-checking=xmallocoverrun). xfree is now used to
7504 deallocate these memory blocks.
7505
4170f62f 75062011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7507
71b41406
PE
7508 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7509
9587a89d
PE
7510 emacs_write: Accept and return EMACS_INT for sizes.
7511 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7512 et seq.
7513 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7514 Accept and return EMACS_INT.
7515 (emacs_gnutls_write): Return the number of bytes written on
7516 partial writes.
7517 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7518 (emacs_read, emacs_write): Remove check for negative size, as the
7519 Emacs source code has been audited now.
9587a89d
PE
7520 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7521 (emacs_read, emacs_write): Use it.
273a5f82
PE
7522 * process.c (send_process): Adjust to the new signatures of
7523 emacs_write and emacs_gnutls_write. Do not attempt to store
7524 a byte offset into an 'int'; it might overflow.
9587a89d 7525 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7526
3e047f51
PE
7527 * sound.c: Don't assume sizes fit in 'int'.
7528 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7529 Return EMACS_INT, not int.
3e047f51 7530 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7531 Accept EMACS_INT, not int.
7532 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7533 record read return values.
7534
cc39a9db
BK
75352011-04-15 Ben Key <bkey76@gmail.com>
7536
c9d0ec6d
JB
7537 * keyboard.c (Qundefined): Don't declare static since it is used
7538 in nsfns.m.
7539 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7540 static since they are used in nsfont.m.
cc39a9db 7541
6c60eb9f
SM
75422011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7543
7544 * process.c (Qprocessp): Don't declare static.
7545 * lisp.h (Qprocessp): Declare again.
7546
7990b61a
JB
75472011-04-15 Juanma Barranquero <lekktu@gmail.com>
7548
7549 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7550
5d4cb038
PE
75512011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7552
8bd7b830 7553 Improve C-level modularity by making more things 'static'.
cd64ea1d 7554
e3b27b31
PE
7555 Don't publish debugger-only interfaces to other modules.
7556 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7557 (verify_bytepos, count_markers): Move decls to the only modules
7558 that need them.
7559 * region-cache.h (pp_cache): Likewise.
7560 * window.h (check_all_windows): Likewise.
7561 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7562
5d4cb038
PE
7563 * sysdep.c (croak): Now static, if
7564 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7565 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7566
7567 * alloc.c (refill_memory_reserve): Now static if
7568 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7569 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7570
e87b6180
PE
7571 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7572 Define only if USE_LUCID.
7573
ac64929e
PE
7574 * xrdb.c (x_customization_string, x_rm_string): Now static.
7575
6f37259d
PE
7576 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7577 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7578
1683e3ab
PE
7579 * xdisp.c (draw_row_with_mouse_face): Now static.
7580 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7581
de9c2632
PE
7582 * window.h (check_all_windows): Mark externally visible.
7583
2b96acb7
PE
7584 * window.c (window_deletion_count): Now static.
7585
7586 * undo.c: Make symbols static if they're not exported.
7587 (last_undo_buffer, last_boundary_position, pending_boundary):
7588 Now static.
7589
50436f33
PE
7590 * textprop.c (interval_insert_behind_hooks): Now static.
7591 (interval_insert_in_front_hooks): Likewise.
7592
64520e5c
PE
7593 * term.c: Make symbols static if they're not exported.
7594 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7595 (max_frame_lines, tty_set_terminal_modes):
7596 (tty_reset_terminal_modes, tty_turn_off_highlight):
7597 (get_tty_terminal): Now static.
7598 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7599 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7600 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7601 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7602 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7603
1fa53021
PE
7604 * sysdep.c: Make symbols static if they're not exported.
7605 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7606 Now static.
7607 (sigprocmask_set, full_mask): Remove; unused.
7608 (wait_debugging): Mark as visible.
7609 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7610 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7611
d4b43b22
PE
7612 * syntax.c (syntax_temp): Define only if !__GNUC__.
7613
b7c513d0
PE
7614 * sound.c (current_sound_device, current_sound): Now static.
7615
989b29ad
PE
7616 * search.c (searchbufs, searchbuf_head): Now static.
7617
13a55a78
PE
7618 * scroll.c (scroll_cost): Remove; unused.
7619 * dispextern.h (scroll_cost): Remove decl.
7620
de68a1fc
PE
7621 * region-cache.h (pp_cache): Mark as externally visible.
7622
40ccffa6
PE
7623 * process.c: Make symbols static if they're not exported.
7624 (process_tick, update_tick, create_process, chan_process):
7625 (Vprocess_alist, proc_buffered_char, datagram_access):
7626 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7627 (deactivate_process): Mark defn as static, as well as decl.
7628 * lisp.h (create_process): Remove decl.
7629 * process.h (chan_process, Vprocess_alist): Remove decls.
7630
ad64fc97
PE
7631 * print.c: Make symbols static if they're not exported.
7632 (print_depth, new_backquote_output, being_printed, print_buffer):
7633 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7634 (print_interval, print_number_index, initial_stderr_stream):
7635 Now static.
7636 * lisp.h (Fprinc): Remove decl.
7637 (debug_output_compilation_hack): Mark as externally visible.
7638
adddb265
PE
7639 * sysdep.c (croak): Move decl from here to syssignal.h.
7640 * syssignal.h (croak): Put it here, so the API can be checked when
7641 'croak' is called from dissociate_if_controlling_tty.
7642
1717ede2
PE
7643 * minibuf.c: Make symbols static if they're not exported.
7644 (minibuf_save_list, choose_minibuf_frame): Now static.
7645 * lisp.h (choose_minibuf_frame): Remove decl.
7646
fa5fb2bc
PE
7647 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7648
1e3890d1
PE
7649 * lread.c: Make symbols static if they're not exported.
7650 (read_objects, initial_obarray, oblookup_last_bucket_number):
7651 Now static.
7652 (make_symbol): Remove; unused.
7653 * lisp.h (initial_obarray, make_symbol): Remove decls.
7654
8a1414fa
PE
7655 * keyboard.c: Make symbols static if they're not exported.
7656 (single_kboard, recent_keys_index, total_keys, recent_keys):
7657 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7658 (this_single_command_key_start, echoing, last_auto_save):
7659 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7660 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7661 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7662 (Vlispy_mouse_stem, double_click_count):
7663 Now static.
7664 (force_auto_save_soon): Define only if SIGDANGER.
7665 (ignore_mouse_drag_p): Now static if
7666 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7667 (print_help): Remove; unused.
7668 (stop_character, last_timer_event): Mark as externally visible.
7669 * keyboard.h (ignore_mouse_drag_p): Declare only if
7670 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7671 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7672 * lisp.h (echoing): Remove decl.
7673 (force_auto_save_soon): Declare only if SIGDANGER.
7674 * xdisp.c (redisplay_window): Simplify code, to make it more
7675 obvious that ignore_mouse_drag_p is not accessed if !defined
7676 USE_GTK && !defined HAVE_NS.
7677
93ea6e8f
PE
7678 * intervals.c: Make symbols static if they're not exported.
7679 (merge_properties_sticky, merge_interval_right, delete_interval):
7680 Now static.
7681 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7682
77382fcc
PE
7683 * insdel.c: Make symbols static if they're not exported.
7684 However, leave prepare_to_modify_buffer alone. It's never
7685 called from outside this function, but that appears to be a bug.
7686 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7687 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7688 (adjust_after_replace_noundo): Remove; unused.
7689 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7690 (signal_before_change): Remove decls.
77382fcc 7691
9306c32e
PE
7692 * indent.c (val_compute_motion, val_vmotion): Now static.
7693
cd44d2eb
PE
7694 * image.c: Make symbols static if they're not exported.
7695 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7696 if USE_GTK.
7697 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7698 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7699
ad9a7a06
PE
7700 * fringe.c (standard_bitmaps): Now static.
7701 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7702
81626931
PE
7703 * frame.c: Make symbols static if they're not exported.
7704 (x_report_frame_params, make_terminal_frame): Now static.
7705 (get_frame_param): Now static, unless HAVE_NS.
7706 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7707 (x_get_resource_string): Remove; not used.
7708 * frame.h (make_terminal_frame, x_report_frame_params):
7709 (x_get_resource_string); Remove decls.
7710 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7711 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7712
239f9db9
PE
7713 * font.c, fontset.c: Make symbols static if they're not exported.
7714 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7715 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7716 * font.c (font_close_object): Now static.
7717 * font.h (font_close_object): Remove.
7718 * fontset.c (FONTSET_OBJLIST): Remove.
7719 (free_realized_fontset) #if-0 the body, which does nothing.
7720 (face_suitable_for_char_p): #if-0, as it's never called.
7721 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7722 * xfaces.c (face_at_string_position):
7723 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7724 since 0 is always ASCII.
7725
dfcf3579
PE
7726 * fns.c (weak_hash_tables): Now static.
7727
5045092b
PE
7728 * fileio.c: Make symbols static if they're not exported.
7729 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7730 (Vwrite_region_annotation_buffers): Now static.
7731
57a96f5c
PE
7732 * eval.c: Make symbols static if they're not exported.
7733 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7734 * lisp.h (backtrace_list): Remove decl.
7735
35f08c38
PE
7736 * emacs.c: Make symbols static if they're not exported.
7737 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7738 (fatal_error_code, fatal_error_signal_hook, standard_args):
7739 Now static.
7740 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7741 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7742 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7743 * lisp.h (fatal_error_signal_hook): Remove decl.
7744 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7745
f44bd759
PE
7746 * editfns.c: Move a (normally-unused) function to its only use.
7747 * editfns.c, lisp.h (get_operating_system_release): Remove.
7748 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7749 worth the hassle of breaking this out.
7750
b532497d
PE
7751 * xterm.c: Make symbols static if they're not exported.
7752 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7753 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7754 (x_destroy_window, x_delete_display):
7755 Now static.
7756 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7757 (x_mouse_leave): Remove; unused.
7758 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7759 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7760 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7761 Remove decls.
7762 (x_mouse_leave): Declare only if WINDOWSNT.
7763 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7764 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7765 USE_X_TOOLKIT.
7766
1675728f
PE
7767 * ftxfont.c: Make symbols static if they're not exported.
7768 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7769 HAVE_FREETYPE.
7770 * font.h (ftxfont_driver): Likewise.
7771
e4cebfca
PE
7772 * xfns.c: Make symbols static if they're not exported.
7773 (x_last_font_name, x_display_info_for_name):
7774 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7775 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7776 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7777 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7778 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7779 (last_show_tip_args): Now static.
7780 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7781 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7782 (x_screen_planes): Remove; unused.
7783 * dispextern.h (x_screen_planes): Remove decl.
7784
5bf46f05
PE
7785 * dispnew.c: Make symbols static if they're not exported.
7786 * dispextern.h (redraw_garbaged_frames, scrolling):
7787 (increment_row_positions): Remove.
7788 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7789 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7790 Now static.
7791 (redraw_garbaged_frames): Remove; unused.
7792
435f4c28
PE
7793 * xfaces.c: Make symbols static if they're not exported.
7794 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7795 Remove decls.
7796 * xterm.h (defined_color): Remove decls.
7797 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7798 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7799 (menu_face_changed_default, defined_color, free_realized_face):
7800 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7801 (ascii_face_of_lisp_face): Remove; unused.
7802
8524aef3
PE
7803 * xdisp.c: Make symbols static if they're not exported.
7804 * dispextern.h (scratch_glyph_row, window_box_edges):
7805 (glyph_to_pixel_coords, set_cursor_from_row):
7806 (get_next_display_element, set_iterator_to_next):
7807 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7808 (show_mouse_face): Remove decls
7809 * frame.h (message_buf_print): Likewise.
7810 * lisp.h (pop_message, set_message, check_point_in_composition):
7811 Likewise.
7812 * xterm.h (set_vertical_scroll_bar): Likewise.
7813 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7814 (message_buf_print, scratch_glyph_row, displayed_buffer):
7815 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7816 (get_next_display_element, show_mouse_face, window_box_edges):
7817 (frame_to_window_pixel_xy, check_point_in_composition):
7818 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7819 (glyph_to_pixel_coords): Remove; unused.
7820
16390cd2
PE
7821 * dired.c (file_name_completion): Now static.
7822
7823 * dbusbind.c (xd_in_read_queued_messages): Now static.
7824
a25f4dfa
PE
7825 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7826 * data.c (circular_list_error): Remove.
7827
14a9c8df
PE
7828 * commands.h (last_point_position, last_point_position_buffer):
7829 (last_point_position_window): Remove decls.
7830 * keyboard.c: Make these variables static.
7831
04f2d78b
CB
7832 * coding.h (coding, code_convert_region, encode_coding_gap):
7833 Remove decls.
74ab6df5
PE
7834 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7835 (iso_code_class, detect_coding, code_convert_region): Now static.
7836 (encode_coding_gap): Remove; unused.
7837
38dfbee1
PE
7838 * chartab.c (chartab_chars, chartab_bits): Now static.
7839
a2cb4e63
PE
7840 * charset.h (charset_iso_8859_1): Remove decl.
7841 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7842 Now static.
7843
127198fd
PE
7844 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7845 * ccl.c (Vccl_program_table): Now static.
7846 (check_ccl_update): Remove; unused.
7847
d85b608f
PE
7848 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7849 * category.h: ... from here.
7850 * category.c (check_category_table, set_category_set): Now static.
7851
31cd66f3
PE
7852 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7853 * lisp.h: Remove these decls.
7854
c358e587
PE
7855 * buffer.c (buffer_count): Remove unused var.
7856
e78aecca
PE
7857 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7858 so that it's not optimized away.
7859 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7860 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7861 exported only to the debugger.
7862
e192d7d3 7863 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7864 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7865
92470028
PE
7866 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7867 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7868 was inaccessible from Lisp.
7869 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7870 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7871
244ed907
PE
7872 alloc.c: Import and export fewer symbols, and remove unused items.
7873 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7874 is defined.
7875 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7876 it's not optimized away by whole-program optimization.
7877 (message_enable_multibyte, free_misc): Remove.
7878 (catchlist, handlerlist, mark_backtrace):
7879 Declare only if BYTE_MARK_STACK.
7880 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7881 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7882 (message_enable_multibyte): Remove decl.
7883 (free_misc, interval_free_list, float_block, float_block_index):
7884 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7885 (cons_free_list, last_marked_index):
7886 Now static.
7887 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7888 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7889 (mark_backtrace): Define only if BYTE_MARK_STACK.
7890 * xdisp.c (message_enable_multibyte): Now static.
7891
61c2b50e 7892 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7893 This makes it easier for human readers (and static analyzers)
7894 to see whether these variables are used from other modules.
7895 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7896 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7897 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7898 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7899 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7900 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7901 * xmenu.c, xselect.c:
7902 Declare Q* vars static if they are not used in other modules.
7903 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7904 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7905 Remove decls of unexported vars.
7906 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7907
95c82688
PE
7908 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7909
16a97296
PE
7910 Make Emacs functions such as Fatom 'static' by default.
7911 This makes it easier for human readers (and static analyzers)
7912 to see whether these functions can be called from other modules.
7913 DEFUN now defines a static function. To make the function external
7914 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7915 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7916 (Finit_image_library):
16a97296
PE
7917 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7918 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7919 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7920 Remove decls, since these functions are now static.
7921 (Funintern, Fget_internal_run_time): New decls, since these functions
7922 were already external.
95c82688 7923
16a97296
PE
7924 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7925 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7926 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7927 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7928 * keyboard.c, keymap.c, lread.c:
7929 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7930 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7931 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7932 Mark functions with DEFUE instead of DEFUN,
7933 if they are used in other modules.
7934 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7935 decls for now-static functions.
7936 * buffer.h (Fdelete_overlay): Remove decl.
7937 * callproc.c (Fgetenv_internal): Mark as internal.
7938 * composite.c (Fremove_list_of_text_properties): Remove decl.
7939 (Fcomposition_get_gstring): New forward static decl.
7940 * composite.h (Fcomposite_get_gstring): Remove decl.
7941 * dired.c (Ffile_attributes): New forward static decl.
7942 * doc.c (Fdocumntation_property): New forward static decl.
7943 * eval.c (Ffetch_bytecode): New forward static decl.
7944 (Funintern): Remove extern decl; now in .h file where it belongs.
7945 * fileio.c (Fmake_symbolic_link): New forward static decl.
7946 * image.c (Finit_image_library): New forward static decl.
7947 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7948 * intervals.h (Fprevious_property_change):
7949 (Fremove_list_of_text_properties): Remove decls.
7950 * keyboard.c (Fthis_command_keys): Remove decl.
7951 (Fcommand_execute): New forward static decl.
7952 * keymap.c (Flookup_key): New forward static decl.
7953 (Fcopy_keymap): Now static.
7954 * keymap.h (Flookup_key): Remove decl.
7955 * process.c (Fget_process): New forward static decl.
7956 (Fprocess_datagram_address): Mark as internal.
7957 * syntax.c (Fsyntax_table_p): New forward static decl.
7958 (skip_chars): Remove duplicate decl.
7959 * textprop.c (Fprevious_property_change): New forward static decl.
7960 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7961 Now internal.
7962 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7963 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7964
785bbd42
PE
7965 * editfns.c (Fformat): Remove unreachable code.
7966
8b913b57
AS
79672011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7968
7969 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7970 change. (Bug#8496)
7971
a6744a35
EZ
79722011-04-13 Eli Zaretskii <eliz@gnu.org>
7973
7974 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7975 when at ZV. (Bug#8487)
7976
e7974947
AS
79772011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7978
baad03f0
AS
7979 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7980 (Bug#8437)
7981 * keyboard.c (parse_tool_bar_item): Likewise.
7982 * sound.c (sound_cleanup, alsa_close): Likewise.
7983 * termcap.c (tgetent): Likewise.
7984 * xfns.c (x_default_font_parameter): Likewise.
7985 * xsettings.c (read_and_apply_settings): Likewise.
7986
e7974947
AS
7987 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7988 (overrun_check_free): Protoize.
7989
28272684
PE
79902011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7991
7992 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7993 since callers should never pass a negative size.
7994 Change the signature to match that of plain 'read' and 'write'; see
7995 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7996 * lisp.h: Update prototypes of emacs_write and emacs_read.
7997
11997c76
EZ
79982011-04-11 Eli Zaretskii <eliz@gnu.org>
7999
8000 * xdisp.c (redisplay_window): Don't try to determine the character
8001 position of the scroll margin if the window start point w->startp
e896f03c 8002 is outside the buffer's accessible region. (Bug#8468)
11997c76 8003
8a2cbd72
EZ
80042011-04-10 Eli Zaretskii <eliz@gnu.org>
8005
8006 Fix write-region and its subroutines for buffers > 2GB.
8007 * fileio.c (a_write, e_write): Modify declaration of arguments and
8008 local variables to support buffers larger than 2GB.
8009 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8010
8011 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8012 argument, local variables, and return value.
8013
8014 * lisp.h: Update prototypes of emacs_write and emacs_read.
8015
8016 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8017
4073e537 80182011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8019
1ebfdcb6
PE
8020 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8021
b2ded58d
PE
8022 Fix more problems found by GCC 4.6.0's static checks.
8023
7d66342c
PE
8024 * xdisp.c (vmessage): Use a better test for character truncation.
8025
bbf47d44
PE
8026 * charset.c (load_charset_map): <, not <=, for optimization,
8027 and to avoid potential problems with integer overflow.
9248994d 8028 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8029 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8030 * editfns.c (Fformat): Likewise.
1e69125e 8031 * syntax.c (skip_chars): Likewise.
3befa583 8032
e3019616
PE
8033 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8034 This also lets GCC 4.6.0 generate slightly better loop code.
8035
becfa255
PE
8036 * callint.c (Fcall_interactively): <, not <=, for optimization.
8037 (Fcall_interactively): Count the number of arguments produced,
8038 not the number of arguments given. This is simpler and lets GCC
8039 4.6.0 generate slightly better code.
8040
dae0cd48
PE
8041 * ftfont.c: Distingish more carefully between FcChar8 and char.
8042 The previous code passed unsigned char * to a functions like
8043 strlen and xstrcasecmp that expect char *, which does not
8044 conform to the C standard.
8045 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8046 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8047 char * when the C standard requires it.
8048
76032d70
PE
8049 * keyboard.c (read_char): Remove unused var.
8050
eb3f1cc8
PE
8051 * eval.c: Port to Windows vsnprintf (Bug#8435).
8052 Include <limits.h>.
8053 (SIZE_MAX): Define if the headers do not.
8054 (verror): Do not give up if vsnprintf returns a negative count.
8055 Instead, grow the buffer. This ports to Windows vsnprintf, which
8056 does not conform to C99. Problem reported by Eli Zaretskii.
8057 Also, simplify the allocation scheme, by avoiding the need for
8058 calling realloc, and removing the ALLOCATED variable.
8059
70476b54
PE
8060 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8061
12020a9e
PE
8062 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8063 But keep the doprint source code for now, as we might revamp it
8064 and use it again (Bug#8435).
ea6c7ae6
PE
8065 * lisp.h (doprnt): Remove.
8066 * Makefile.in (base_obj): Remove doprnt.o.
8067 * deps.mk (doprnt.o): Remove.
8068
5fdb398c
PE
8069 error: Print 32- and 64-bit integers portably (Bug#8435).
8070 Without this change, on typical 64-bit hosts error ("...%d...", N)
8071 was used to print both 32- and 64-bit integers N, which relied on
8072 undefined behavior.
61bdb816 8073 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8074 * lisp.h (error, verror): Mark as printf-like functions.
8075 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8076 Report overflow in size calculations when allocating printf buffer.
8077 Do not truncate output string at its first null byte.
8078 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8079 Truncate the output at a character boundary, since vsnprintf does not
8080 do that.
8081 * charset.c (check_iso_charset_parameter): Convert internal
8082 character to string before calling 'error', since %c now has the
8083 printf meaning.
8084 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8085 overflow when computing char to be passed to 'error'. Do not
8086 pass Lisp_Object to 'error'; pass the integer instead.
8087 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8088 formatted with plain %d.
8089
b189fa66
PE
8090 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8091
bff87ef0
PE
8092 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8093
7e2cac20
PE
8094 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8095
ce4d90b5
PE
8096 * xterm.c (x_catch_errors): Remove duplicate declaration.
8097
266c9547
PE
8098 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8099
79c49ad2
PE
8100 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8101
368f4090
JM
81022011-04-10 Jim Meyering <meyering@redhat.com>
8103
8104 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8105 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8106 return ssize_t not "int", and use size_t as the buffer length.
8107 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8108 * gnutls.h: Update declarations.
8109 * process.c (read_process_output): Use ssize_t, to match.
8110 (send_process): Likewise.
8111
a32d4040
CY
81122011-04-09 Chong Yidong <cyd@stupidchicken.com>
8113
8114 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8115
8546720e 81162011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8117
04f2d78b
CB
8118 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8119 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8120
8546720e
GM
8121 * xterm.c (handle_one_xevent):
8122 * xmenu.c (create_and_show_popup_menu):
8123 * xselect.c (x_decline_selection_request)
8124 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8125
0a2f5c1a 81262011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8127
8128 Fix some uses of `int' instead of EMACS_INT.
8129 * search.c (string_match_1, fast_string_match)
8130 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8131 (scan_buffer, find_next_newline_no_quit)
8132 (find_before_next_newline, search_command, Freplace_match)
8133 (Fmatch_data): Make some `int' variables be EMACS_INT.
8134
8135 * xdisp.c (display_count_lines): 3rd argument and return value now
8136 EMACS_INT. All callers changed.
8137 (pint2hrstr): Last argument is now EMACS_INT.
8138
8139 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8140 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8141 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8142 (decode_coding_utf_16, decode_coding_emacs_mule)
8143 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8144 (decode_coding_ccl, decode_coding_charset)
8145 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8146 (decode_coding_iso_2022, decode_coding_emacs_mule)
8147 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8148 <char_offset, last_offset>: Declare EMACS_INT.
8149 (encode_coding_utf_8, encode_coding_utf_16)
8150 (encode_coding_emacs_mule, encode_invocation_designation)
8151 (encode_designation_at_bol, encode_coding_iso_2022)
8152 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8153 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8154 Declare EMACS_INT.
8155 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8156 (encode_invocation_designation): Last argument P_NCHARS is now
8157 EMACS_INT.
8158 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8159 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8160
8161 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8162 All users changed.
8163
8164 * ccl.c (Fccl_execute_on_string): Declare some variables
8165 EMACS_INT.
8166
8546720e 81672011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8168
8169 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8170
4e19a977
CS
81712011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8172
8173 * process.c (Fformat_network_address): Doc fix.
8174
87302331
R
81752011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8176
ee7683eb 8177 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8178
cbb59342
CY
81792011-04-08 Chong Yidong <cyd@stupidchicken.com>
8180
8181 * keyboard.c (read_char): Call Lisp function help-form-show,
8182 instead of using internal_with_output_to_temp_buffer.
8183 (Qhelp_form_show): New var.
e0d38eeb 8184 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8185
8186 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8187
8188 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8189
e67a13ab
CY
81902011-04-06 Chong Yidong <cyd@stupidchicken.com>
8191
04f2d78b
CB
8192 * process.c (Flist_processes): Remove to Lisp.
8193 (list_processes_1): Delete.
e67a13ab 8194
973f782d
EZ
81952011-04-06 Eli Zaretskii <eliz@gnu.org>
8196
7c106b1e
EZ
8197 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8198
973f782d
EZ
8199 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8200
41cf7d1a 82012011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8202
ca23cc88
PE
8203 Fix more problems found by GCC 4.6.0's static checks.
8204
f390e2d5
PE
8205 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8206
42eea0d0
PE
8207 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8208
b69769da 8209 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8210
f9541e84
PE
8211 * xdisp.c (vmessage): Mark as a printf-like function.
8212
13841b55
PE
8213 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8214
c136c10f
PE
8215 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8216
5e2d4a30
PE
8217 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8218 printf-like functions.
8219 (tiff_load): Add casts to remove these marks before passing them
8220 to system-supplied API.
8221
583f48b9
PE
8222 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8223
b25d760e
PE
8224 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8225 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8226 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8227 directly, rather than having caller test rule sign. This avoids
8228 some unnecessary tests.
8229 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8230 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8231 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8232
bc7b6697 8233 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8234 (xfont_open): Avoid unnecessary tests.
bc7b6697 8235
27ccc379
PE
8236 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8237
dcd5c89a
PE
8238 * composite.h, composite.c (composition_gstring_put_cache):
8239 Use EMACS_INT, not int, for length.
8240
b13a45c6
PE
8241 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8242 breaking out part of COMPOSITION_DECODE_RULE.
8243 (COMPOSITION_DECODE_RULE): Use it.
8244 * composite.c (get_composition_id): Remove unused local vars,
8245 by using the new macro.
8246
1e792e4d
PE
8247 * textprop.c (set_text_properties_1): Change while to do-while,
8248 since the condition is always true at first.
8249
dc6c6455 8250 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8251 (interval_deletion_adjustment): Return unsigned value.
8252 All uses changed.
dc6c6455 8253
aba7731a
PE
8254 * process.c (list_processes_1, create_pty, read_process_output):
8255 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8256 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8257 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8258 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8259 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8260
fdfc4bf3
PE
8261 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8262
fca8fe46 8263 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8264 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8265
06a0259a 8266 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8267 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8268 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8269
e7b9e80f
PE
8270 * print.c (print_error_message): Avoid int overflow.
8271
56201685
PE
8272 * font.c (font_list_entities): Redo for clarity,
8273 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8274
78834453 8275 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8276 (font_score): Avoid potential overflow in diff calculation.
78834453 8277
0bc0b309 8278 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8279 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8280
e610eaca
PE
8281 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8282
b895abce
PE
8283 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8284 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8285 can always succeed if overflow has undefined behavior.
8286
1f1d9321 8287 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8288 (wordify): Omit three unnecessary tests.
1f1d9321 8289
c59478bc
PE
8290 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8291 All callers changed. This avoids the need for an unused var.
8292
79b73827
PE
8293 * casefiddle.c (casify_region): Remove var that is set but not used.
8294
a4db5dfe
PE
8295 * dired.c (file_name_completion): Remove var that is set but not used.
8296
43aae36e
PE
8297 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8298
2a47c44d 8299 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8300 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8301
a37c69bf
PE
8302 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8303 Check for integer overflow on size calculations.
8304
328ab8e7
PE
8305 * buffer.c (Fprevious_overlay_change): Remove var that is set
8306 but not used.
8307
e5a2a5cb
PE
8308 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8309 Remove vars that are set but not used.
8d84a6eb 8310 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8311 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8312
a60e5f68
PE
8313 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8314
f661cb61 8315 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8316 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8317
f0397f5a
PE
8318 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8319 that are set but not used.
8320
8664db06 8321 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8322 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8323
6abdaa4a
PE
8324 * xselect.c (x_get_local_selection, x_handle_property_notify):
8325 Remove vars that are set but not used.
8326
0ce7538d 8327 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8328 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8329
9ae848fc
PE
8330 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8331 Remove var that is set but not used.
0b918413
PE
8332 (scroll_bar_windows_size): Now size_t, not int.
8333 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8334 Check for overflow.
9ae848fc 8335
a5a62657
PE
8336 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8337 (map_tty_color) [!defined MSDOS]: Likewise.
8338
5c5cdd39
PE
8339 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8340
66ebf983
PE
8341 * coding.c: Remove vars that are set but not used.
8342 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8343 All callers changed.
8344 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8345 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8346 (decode_coding_charset): Remove vars that are set but not used.
8347
1be4d761
PE
8348 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8349 that is set but not used.
8350
47553fa8
PE
8351 * print.c (print_object): Remove var that is set but not used.
8352
1f7196bf 8353 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8354 The gnulib version avoids calling malloc in the usual case,
8355 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8356 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8357 * filelock.c (current_lock_owner): Likewise.
8358 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8359 * sysdep.c: Include allocator.h, careadlinkat.h.
8360 (emacs_no_realloc_allocator): New static constant.
8361 (emacs_readlink): New function.
fdb61804
PE
8362 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8363 ../lib/careadlinkat.h.
d1fdcab7 8364
f84c17c7
SM
83652011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8366
8367 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8368 first non-nil return value).
8369
ef3862ad
JD
83702011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8371
8372 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8373 if not defined (Bug#8403).
8374
376a7006
JB
83752011-04-02 Juanma Barranquero <lekktu@gmail.com>
8376
8377 * xdisp.c (display_count_lines): Remove parameter `start',
8378 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8379 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8380 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8381 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8382 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8383 and thereabouts. All callers changed.
8384 (get_per_char_metric): Remove parameter `f', unused since
8385 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8386
6ca3801d
JM
83872011-04-02 Jim Meyering <meyering@redhat.com>
8388
8389 do not dereference NULL upon failed strdup
8390 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8391 (ns_get_family): Likewise.
8392
d8e2b5ba
JB
83932011-04-02 Juanma Barranquero <lekktu@gmail.com>
8394
8395 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8396
8c74fcbd
JD
83972011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8398
8399 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8400 later (Bug#8403).
8401
7200d79c
SM
84022011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8403
03408648 8404 Add lexical binding.
7200d79c 8405
03408648
SM
8406 * window.c (Ftemp_output_buffer_show): New fun.
8407 (Fsave_window_excursion):
8408 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8409
8410 * lread.c (lisp_file_lexically_bound_p): New function.
8411 (Fload): Bind Qlexical_binding.
8412 (readevalloop): Remove `evalfun' arg.
8413 Bind Qinternal_interpreter_environment.
8414 (Feval_buffer): Bind Qlexical_binding.
8415 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8416 Mark as dynamic.
8417 (syms_of_lread): Declare `lexical-binding'.
8418
8419 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8420
8421 * keyboard.c (eval_dyn): New fun.
8422 (menu_item_eval_property): Use it.
ca105506
SM
8423
8424 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8425
03408648
SM
8426 * fns.c (concat, mapcar1): Accept byte-code-functions.
8427
8428 * eval.c (Fsetq): Handle lexical vars.
8429 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8430 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8431 (FletX, Flet): Obey lexical binding.
8432 (Fcommandp): Handle closures.
8433 (Feval): New `lexical' arg.
8434 (eval_sub): New function extracted from Feval. Use it almost
8435 everywhere where Feval was used. Look up vars in lexical env.
8436 Handle closures.
8437 (Ffunctionp): Move from subr.el.
8438 (Ffuncall): Handle closures.
8439 (apply_lambda): Remove `eval_flags'.
8440 (funcall_lambda): Handle closures and new byte-code-functions.
8441 (Fspecial_variable_p): New function.
8442 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8443 but without exporting it to Lisp.
23aba0ea 8444
23aba0ea 8445 * doc.c (Fdocumentation, store_function_docstring):
03408648 8446 * data.c (Finteractive_form): Handle closures.
23aba0ea 8447
03408648
SM
8448 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8449 interactive spec.
ba83908c 8450
04f2d78b
CB
8451 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8452 New byte-codes.
03408648
SM
8453 (exec_byte_code): New function extracted from Fbyte_code to handle new
8454 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8455
03408648 8456 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8457
03408648 8458 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8459
e2abce01
JB
84602011-03-31 Juanma Barranquero <lekktu@gmail.com>
8461
8462 * xdisp.c (redisplay_internal): Fix prototype.
8463
63696a73 84642011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8465
63696a73 8466 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8467 (try_scrolling): Use it when setting scroll_limit.
8468 Limit scrolling to 100 screen lines.
63696a73
EZ
8469 (redisplay_window): Even when falling back on "recentering",
8470 position point in the window according to scroll-conservatively,
8471 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8472
8473 (try_scrolling): When point is above the window, allow searching
8474 as far as scroll_max, or one screenful, to compute vertical
8475 distance from PT to the scroll margin position. This prevents
8476 try_scrolling from unnecessarily failing when
8477 scroll-conservatively is set to a value slightly larger than the
8478 window height. Clean up the case of PT below the margin at bottom
8479 of window: scroll_max can no longer be INT_MAX. When aggressive
8480 scrolling is in use, don't let point enter the opposite scroll
8481 margin as result of the scroll.
8482 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8483 threshold of 100 lines for never-recentering scrolling.
8484
e4cc2dfc
JB
84852011-03-31 Juanma Barranquero <lekktu@gmail.com>
8486
8487 * dispextern.h (move_it_by_lines):
8488 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8489 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8490 (message_log_check_duplicate): Remove parameters `prev_bol' and
8491 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8492 (redisplay_internal): Remove parameter `preserve_echo_area',
8493 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8494
8495 * indent.c (Fvertical_motion):
8496 * window.c (window_scroll_pixel_based, Frecenter):
8497 Don't pass `need_y_p' to `move_it_by_lines'.
8498
1c470562
SM
84992011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8500
44f230aa
SM
8501 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8502 steal a few bits to be more compact.
8503 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8504 Remove unneeded casts.
8505
1c470562
SM
8506 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8507
888adce9
ZK
85082011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8509
8510 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8511 binding" message (bug#7967).
8512
f838ed7b
PE
85132011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8514
77861b95
PE
8515 Fix more problems found by GCC 4.6.0's static checks.
8516
de6dbc14
PE
8517 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8518 Remove unused local var.
8519
f838ed7b
PE
8520 * editfns.c (Fmessage_box): Remove unused local var.
8521
792c7b2b
PE
8522 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8523 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8524 Omit unused local vars.
c499e557 8525 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8526 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8527 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8528 Omit unused local var.
8529
ba0165e1
PE
8530 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8531 Don't assume string length fits in int.
32ad8845 8532 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8533 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8534
3c59b4c9
PE
8535 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8536 instead of alloca (Bug#8344).
8537
a3eed478 8538 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8539 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8540
eb4d412d
PE
8541 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8542
1658b401
PE
8543 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8544 concerns.
8545
8546 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8547
8548 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8549
9a2c6e05
PE
8550 * keyboard.c (syms_of_keyboard): Use the same style as later
8551 in this function when indexing through an array. This also
8552 works around GCC bug 48267.
8553
03d0a109
PE
8554 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8555
44f730c8
PE
8556 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8557
fe75f926
PE
8558 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8559 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8560
ffa8c828
PE
8561 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8562 This avoids undefined behavior on integer overflow, and is a bit
8563 more convenient anyway since it is compared to a size_t variable.
8564
c5101a77
PE
8565 Variadic C functions now count arguments with size_t, not int.
8566 This avoids an unnecessary limitation on 64-bit machines, which
8567 caused (substring ...) to crash on large vectors (Bug#8344).
8568 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8569 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8570 All variadic functions and their callers changed accordingly.
c5101a77
PE
8571 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8572 * data.c (arith_driver, float_arith_driver): Likewise.
8573 * editfns.c (general_insert_function): Likewise.
8574 * eval.c (struct backtrace.nargs, interactive_p)
8575 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8576 (funcall_lambda, mark_backtrace): Likewise.
8577 * fns.c (concat): Likewise.
8578 * frame.c (x_set_frame_parameters): Likewise.
8579 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8580 0 if not found, not -1. All callers changed.
8581
dd3f25f7
PE
8582 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8583 (stack_copy_size): Now size_t, not int.
8584 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8585
461c2ab9
JB
85862011-03-28 Juanma Barranquero <lekktu@gmail.com>
8587
8588 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8589 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8590 All callers changed.
8591
8592 * lisp.h (multibyte_char_to_unibyte):
8593 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8594 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8595 * character.h (CHAR_TO_BYTE8):
8596 * cmds.c (internal_self_insert):
8597 * editfns.c (general_insert_function):
8598 * keymap.c (push_key_description):
8599 * search.c (Freplace_match):
8600 * xdisp.c (message_dolog, set_message_1): All callers changed.
8601
f6d62986
SM
86022011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8603
8604 * keyboard.c (safe_run_hook_funcall): New function.
8605 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8606 don't set the hook to nil, but remove the offending function instead.
8607 (Qcommand_hook_internal): Remove, unused.
8608 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8609 Vcommand_hook_internal.
8610
8611 * eval.c (enum run_hooks_condition): Remove.
8612 (funcall_nil, funcall_not): New functions.
8613 (run_hook_with_args): Call each function through a `funcall' argument.
8614 Remove `cond' argument, now redundant.
8615 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8616 (Frun_hook_with_args_until_failure): Adjust accordingly.
8617 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8618
1db5b1ad
JB
86192011-03-28 Juanma Barranquero <lekktu@gmail.com>
8620
8621 * dispextern.h (string_buffer_position): Remove declaration.
8622
8623 * print.c (strout): Remove parameter `multibyte', unused since
8624 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8625
8626 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8627 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8628 All callers changed.
8629
8630 * w32.c (_wsa_errlist): Use braces for struct initializers.
8631
8632 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8633 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8634 All callers changed.
8635 (string_buffer_position): Likewise. Also, make static (it's never
8636 used outside xdisp.c).
8637 (cursor_row_p): Remove parameter `w', unused since
8638 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8639 (decode_mode_spec): Remove parameter `precision', introduced during
8640 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8641 All callers changed.
8642
5ffb62aa
JD
86432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8644
8645 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8646
461c2ab9 86472011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8648
8649 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8650 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8651 (ns_update_auto_hide_menu_bar): New functions.
8652 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8653 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8654 ns_constrain_all_frames.
8655 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8656 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8657
5c380ffb
JD
86582011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8659
8660 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8661
9af30bdf
GM
86622011-03-27 Glenn Morris <rgm@gnu.org>
8663
8664 * syssignal.h: Replace RETSIGTYPE with void.
8665 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8666 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8667 Replace SIGTYPE with void everywhere.
8668 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8669 * s/template.h (SIGTYPE): Remove commented out definition.
8670
e2abce01
JB
86712011-03-26 Eli Zaretskii <eliz@gnu.org>
8672
8673 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8674 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8675
f868cd8a
JB
86762011-03-26 Juanma Barranquero <lekktu@gmail.com>
8677
59eb0929
JB
8678 * w32.c (read_unc_volume): Use parameter `henum', instead of
8679 global variable `wget_enum_handle'.
8680
8681 * keymap.c (describe_vector): Remove parameters `indices' and
8682 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8683 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8684
f868cd8a
JB
8685 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8686
8687 * keyboard.c (timer_check): Remove parameter `do_it_now',
8688 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8689 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8690 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8691
8692 * keyboard.c (read_char):
8693 * w32menu.c (w32_menu_display_help):
8694 * xmenu.c (show_help_event, menu_help_callback):
8695 Adjust calls to `show_help_echo'.
8696
8697 * gtkutil.c (xg_maybe_add_timer):
8698 * keyboard.c (readable_events):
8699 * process.c (wait_reading_process_output):
8700 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8701
8702 * insdel.c (adjust_markers_gap_motion):
8703 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8704 (gap_left, gap_right): Don't call it.
8705
2ecf6fdb
CY
87062011-03-25 Chong Yidong <cyd@stupidchicken.com>
8707
8708 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8709 incurred during fontification.
8710
6b1f9ba4
JB
87112011-03-25 Juanma Barranquero <lekktu@gmail.com>
8712
8713 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8714 (DEFVAR_PER_BUFFER): Don't pass it.
8715
8716 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8717 (scrolling_window): Don't pass it.
8718
0f4a96b5
JB
87192011-03-25 Juanma Barranquero <lekktu@gmail.com>
8720
8721 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8722
8723 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8724 and `suffix'.
8725 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8726 of variables specific to SELinux and computation of `encoded_absname'.
8727
8728 * image.c (XPutPixel): Remove unused variable `height'.
8729
8730 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8731
8732 * unexw32.c (get_section_info): Remove unused variable `section'.
8733
8734 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8735 (system_process_attributes): Remove unused variable `sess'.
8736 (sys_read): Remove unused variable `err'.
8737
8738 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8739 (w32_wnd_proc): Remove unused variable `isdead'.
8740 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8741 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8742 (x_create_tip_frame): Remove unused variable `tem'.
8743
8744 * w32inevt.c (w32_console_read_socket):
8745 Remove unused variable `no_events'.
8746
8747 * w32term.c (x_draw_composite_glyph_string_foreground):
8748 Remove unused variable `width'.
8749
1149507c
JB
87502011-03-24 Juanma Barranquero <lekktu@gmail.com>
8751
8752 * w32term.c (x_set_glyph_string_clipping):
8753 Don't pass uninitialized region to CombineRgn.
8754
9c88f339
JB
87552011-03-23 Juanma Barranquero <lekktu@gmail.com>
8756
8757 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8758 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8759 (Fx_close_connection): Remove unused variable `i'.
8760
8761 * w32font.c (w32font_draw): Return number of glyphs.
8762 (w32font_open_internal): Remove unused variable `i'.
8763 (w32font_driver): Add missing initializer.
8764
8765 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8766 (fill_in_menu): Remove unused variable `items_added'.
8767
8768 * w32term.c (last_mouse_press_frame): Remove static global variable.
8769 (w32_clip_to_row): Remove unused variable `f'.
8770 (x_delete_terminal): Remove unused variable `i'.
8771
8772 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8773 (NOTHING): Remove unused static global variable.
8774 (uniscribe_check_otf): Remove unused variable `table'.
8775 (uniscribe_font_driver): Add missing initializers.
8776
dee091a3
JD
87772011-03-23 Julien Danjou <julien@danjou.info>
8778
8779 * term.c (Fsuspend_tty, Fresume_tty):
8780 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8781 * window.c (temp_output_buffer_show):
8782 * insdel.c (signal_before_change):
8783 * frame.c (Fhandle_switch_frame):
8784 * fileio.c (Fdo_auto_save):
8785 * emacs.c (Fkill_emacs):
8786 * editfns.c (save_excursion_restore):
8787 * cmds.c (internal_self_insert):
8788 * callint.c (Fcall_interactively):
8789 * buffer.c (Fkill_all_local_variables):
8790 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8791 Use Frun_hooks.
0f4a96b5 8792 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8793 unconditionally since it does the check itself.
dee091a3 8794
2c520ab5 87952011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8796
c9c49752
PE
8797 Fix more problems found by GCC 4.5.2's static checks.
8798
8abc3f12
PE
8799 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8800 the first time through the loop, since we know p0 < p1 then.
8801 This also avoids a gcc -Wstrict-overflow warning.
8802
a2d26660
PE
8803 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8804 leading to a memory leak, possible in functions like
8805 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8806 of objects (Bug#8318).
a2d26660 8807
916c72e9
PE
8808 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8809 that could (at least in theory) be that large.
8810
19ab8a18
PE
8811 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8812 This is less likely to overflow, and avoids undefined behavior if
8813 overflow does occur. All callers changed. Use strtoul to scan
8814 for the unsigned long integer.
b7cbbd6f
PE
8815 (pint2hrstr): Simplify and tune code slightly.
8816 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8817
f0641eff
PE
8818 * scroll.c (do_scrolling): Work around GCC bug 48228.
8819 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8820
7f650bb9
PE
8821 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8822 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8823 (validate_x_resource_name): Simplify count usage.
8824 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8825
37dd57d1
PE
8826 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8827 fail (Bug#8306).
81e56e61 8828
699979fc 8829 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8830
401bf9b4
PE
8831 * process.c (Fmake_network_process): Use socklen_t, not int,
8832 where POSIX says socklen_t is required in portable programs.
8833 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8834 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8835 (Fmake_network_process, server_accept_connection):
8836 (wait_reading_process_output, read_process_output):
8837 Likewise.
8838
b93aacde
PE
8839 * process.c: Rename or move locals to avoid shadowing.
8840 (list_processes_1, Fmake_network_process):
8841 (read_process_output_error_handler, exec_sentinel_error_handler):
8842 Rename or move locals.
4dc343ee 8843 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8844 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8845 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8846 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8847 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8848
af8a867c 8849 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8850 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8851 Include tparam.h instead, since it declares them.
af8a867c
PE
8852 * cm.h (PC): Remove extern decl; tparam.h now does this.
8853 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8854 * terminfo.c: Include tparam.h, to check interfaces.
8855 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8856 (tparam): Adjust signature to match interface in tparam.h;
8857 this removes some undefined behavior. Check that outstring and len
8858 are zero, which they always are with Emacs.
8859 * tparam.h (PC, BC, UP): New extern decls.
8860
0248044d 8861 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8862 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8863
8ff096c1 8864 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8865 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8866 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8867 (ftfont_list): Remove unused local.
49eaafba
PE
8868 (get_adstyle_property, ftfont_pattern_entity):
8869 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8870 Rename locals to avoid shadowing.
8ff096c1 8871
e2be39f6
PE
8872 * xfont.c (xfont_list_family): Mark var as initialized.
8873
c9735e30
PE
8874 * xml.c (make_dom): Now static.
8875
8f5201ae
PE
8876 * composite.c (composition_compute_stop_pos): Rename local to
8877 avoid shadowing.
b246f932
PE
8878 (composition_reseat_it): Remove unused locals.
8879 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8880 (composition_update_it): Mark var as initialized.
11b61122
PE
8881 (find_automatic_composition): Mark vars as initialized,
8882 with a FIXME (Bug#8290).
8f5201ae 8883
760fbc2c
PE
8884 character.h: Rename locals to avoid shadowing.
8885 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8886 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8887 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8888 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8889 to avoid shadowing.
8890
ff08eb85
PE
8891 * textprop.c (property_change_between_p): Remove; unused.
8892
fc7bf025
PE
8893 * intervals.c (interval_start_pos): Now static.
8894
235d7abc
PE
8895 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8896
44f230aa
SM
8897 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8898 Rename locals to avoid shadowing.
3e7d6594 8899
50060332
PE
8900 * sound.c (wav_play, au_play, Fplay_sound_internal):
8901 Fix pointer signedness.
d01f234b 8902 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8903 (wav_play): Initialize a variable to 0, to prevent undefined
8904 behavior (Bug#8278).
50060332 8905
c4fc4e30
PE
8906 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8907
918436ed
PE
8908 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8909
c939f91b
PE
8910 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8911 clobbering (Bug#8298).
b9c7f648
PE
8912 * sysdep.c (sys_subshell): Likewise.
8913 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8914
6bd8c144
PE
8915 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8916 This should get cleaned up, so that child_setup has the
8917 same signature on all platforms.
8918
7710357c 8919 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8920 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8921
c59da222
CY
89222011-03-22 Chong Yidong <cyd@stupidchicken.com>
8923
8924 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8925 not to be necessary, and produces flickering.
8926
66b87493
GM
89272011-03-20 Glenn Morris <rgm@gnu.org>
8928
8929 * config.in: Remove file.
8930
45b6f6d5
JB
89312011-03-20 Juanma Barranquero <lekktu@gmail.com>
8932
8933 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8934 are now in src/globals.h.
8935 (syms_of_minibuf): Remove spurious & from previous change.
8936
cd394be1 89372011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8938
8939 * minibuf.c (completing-read-function): New variable.
8940 (completing-read-default): Rename from completing-read.
8941 (completing-read): Call completing-read-function.
8942
b14e3e21
CY
89432011-03-19 Juanma Barranquero <lekktu@gmail.com>
8944
8945 * xfaces.c (Fx_load_color_file):
8946 Read color file from absolute filename (bug#8250).
8947
f2b726e6
JB
89482011-03-19 Juanma Barranquero <lekktu@gmail.com>
8949
8950 * makefile.w32-in: Update dependencies.
8951
09f6ff02
EZ
89522011-03-17 Eli Zaretskii <eliz@gnu.org>
8953
8954 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8955
29a6015a
PE
89562011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8957
a3a6c54e
PE
8958 Fix more problems found by GCC 4.5.2's static checks.
8959
b766f867
PE
8960 * process.c (make_serial_process_unwind, send_process_trap):
8961 (sigchld_handler): Now static.
8962
be02381c
PE
8963 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8964 That way, the code declares only the vars that it needs.
8965 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8966 * s/cygwin.h (PTY_ITERATION): Likewise.
8967 * s/darwin.h (PTY_ITERATION): Likewise.
8968 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8969
57048744
PE
8970 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8971 * process.c (allocate_pty): Don't declare stb unless it's needed.
8972
7914961c 8973 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8974 (CONSTANTLIM): Remove; unused.
8975 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8976 Define only if needed.
7914961c 8977
b3967b18
PE
8978 * unexelf.c (unexec): Name an expression,
8979 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8980 Use a different way to cause a compilation error if anyone uses
8981 n rather than nn, a way that does not involve shadowing.
73366a00 8982 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8983
29a6015a
PE
8984 * deps.mk (unexalpha.o): Remove; unused.
8985
43cfc33e 8986 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8987 * unexec.h: New file.
ce701a33
PE
8988 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8989 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8990 Depend on unexec.h.
8991 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8992 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8993 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8994 Change as necessary to match prototype in unexec.h.
ce701a33 8995
01f44d5a
PE
8996 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8997 shadowing.
4f63c6bb 8998 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8999
a6670b0b
PE
9000 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9001 Rename locals to avoid shadowing.
9002
cef2010d 9003 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9004 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9005
d4d7173a
PE
9006 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9007
f08b802a
PE
9008 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9009 warning when compiling print.c.
9010
3ddb0639
PE
9011 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9012 instead of using an uninitialized var.
5ad03b97 9013 (font_sort_entities): Mark var as initialized.
3ddb0639 9014
170a2692
PE
9015 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9016
e663c700
PE
9017 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9018 pointers to constants.
89bc529a 9019 (font_parse_fcname): Remove unused vars.
7b81e2d0 9020 (font_delete_unmatched): Now static.
ea838e10 9021 (font_get_spec): Remove; unused.
13a547c6
PE
9022 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9023 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9024 Rename or move locals to avoid shadowing.
e663c700 9025
2a80c887 9026 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9027 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9028
1384fa33 9029 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9030 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9031
8b2c52e9
PE
9032 * alloc.c (mark_backtrace): Move decl from here ...
9033 * lisp.h: ... to here, so that it can be checked.
9034
475545b5 9035 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9036 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9037 (lisp_indirect_variable): Name an expression,
9038 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9039 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9040
b1349114 9041 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9042 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9043 Use const pointer when appropriate.
b1349114 9044
a2928364
PE
9045 * lisp.h (get_system_name, get_operating_system_release):
9046 Move decls here, to check interfaces.
9047 * process.c (get_operating_system_release): Move decl to lisp.h.
9048 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9049 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9050 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9051 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9052 (Fformat_time_string, Fencode_time, Finsert_char):
9053 (Ftranslate_region_internal, Fformat):
9054 Rename or remove local vars to avoid shadowing.
9710023e 9055 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9056
a415e694
PE
9057 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9058 avoid shadowing.
9059
8ef4622d
PE
9060 * lisp.h (eassert): Check that the argument compiles, even if
9061 ENABLE_CHECKING is not defined.
9062
946f9a5b
PE
9063 * data.c (Findirect_variable): Name an expression, to avoid
9064 gcc -Wbad-function-cast warning.
112396d6 9065 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9066 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9067 (Fmake_variable_buffer_local, Fmake_local_variable):
9068 Mark variables as initialized.
52746918 9069 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9070
e5aab7e7 9071 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9072 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9073 Rename locals to avoid shadowing.
dff45157
PE
9074 (mark_stack): Move local variables into the #ifdef region where
9075 they're used.
7bc26fdb
PE
9076 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9077 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9078 needed otherwise.
9079 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9080 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9081 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9082
e5aab7e7
PE
9083 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9084 avoids undefined behavior in theory.
9085
4da60324
PE
9086 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9087
88043301
PE
9088 Use functions, not macros, for up- and down-casing (Bug#8254).
9089 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9090 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9091 to use the following functions instead of these macros.
9092 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9093 EMACS_INT, since callers assume the returned value fits in int.
9094 (upcase1): Likewise, for UPCASE_TABLE.
9095 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9096 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9097 the race-condition problem in the old DOWNCASE.
88043301 9098
19ed5445
PE
9099 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9100 Rename locals to avoid shadowing.
9101 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9102 (regex_compile, re_search_2, re_match_2_internal):
9103 Remove unused local vars.
952db0d7
PE
9104 (FREE_VAR): Rewrite so as not to use empty "else",
9105 which gcc can warn about.
da053e48 9106 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9107 (RETALLOC_IF): Define only if needed.
9108 (WORDCHAR_P): Likewise. This one is never needed, but is used
9109 only in a comment talking about a compiler bug, so put inside
9110 the #if 0 of that comment.
9111 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9112 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9113 Remove; unused.
19ed5445 9114
1f3561e4 9115 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9116 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9117 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9118
ded6f8f7
PE
9119 * search.c (simple_search): Remove unused var.
9120
dbd37a95
PE
9121 * dired.c (compile_pattern): Move decl from here ...
9122 * lisp.h: ... to here, so that it can be checked.
9123 (struct re_registers): New forward decl.
9124
7e47afad
PE
9125 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9126
85f24f61
PE
9127 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9128 All uses changed.
9129 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9130 Rename locals to avoid shadowing.
5671df8f 9131 (Fvertical_motion): Mark locals as initialized.
85f24f61 9132
181aa2be 9133 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9134 (casify_region): Mark local as initialized.
181aa2be 9135
930d429c
PE
9136 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9137
7082eac6
PE
9138 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9139 New macros, so that the caller can use some names other than
9140 gcpro1, gcpro2, etc.
9141 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9142 of the new macros.
9143 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9144 argument, for consistency with GCPRO2_VAR, etc: it is now the
9145 prefix of the variable, not the variable itself. All uses
9146 changed.
38b2c076
PE
9147 * dired.c (directory_files_internal, file_name_completion):
9148 Rename locals to avoid shadowing.
9149
15206ed9
PE
9150 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9151 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9152 dired.c's scmp function, had undefined behavior.
9153 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9154 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9155 * buffer.h: ... to here, because these macros use current_buffer,
9156 and the new implementation with inline functions needs to have
9157 current_buffer in scope now, rather than later when the macros
9158 are used.
9159 (downcase, upcase1): New static inline functions.
9160 (DOWNCASE, UPCASE1): Reimplement using these functions.
9161 This avoids undefined behavior in expressions like
9162 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9163 from race conditions in accessing the global variables
9164 case_temp1 and case_temp2.
9165 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9166 * lisp.h (case_temp1, case_temp2): Remove their decls.
9167 * character.h (ASCII_CHAR_P): Move from here ...
9168 * lisp.h: ... to here, so that the inline functions mentioned
9169 above can use them.
9170
4a6bea26
PE
9171 * dired.c (directory_files_internal_unwind): Now static.
9172
f14b7e14
PE
9173 * fileio.c (file_name_as_directory, directory_file_name):
9174 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9175 Now static.
2893f146
PE
9176 (file_name_as_directory): Use const pointers when appropriate.
9177 (Fexpand_file_name): Likewise. In particular, newdir might
9178 point at constant storage, so make it a const pointer.
fd4ead52 9179 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9180 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9181 signedness issues.
f839df0c
PE
9182 (Fset_file_times, Finsert_file_contents, auto_save_error):
9183 Rename locals to avoid shadowing.
f14b7e14 9184
5716756e 9185 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9186 (Ftry_completion, Fall_completions): Rename or remove locals
9187 to avoid shadowing.
5716756e 9188
b4c3046a
PE
9189 * marker.c (bytepos_to_charpos): Remove; unused.
9190
b45db522
PE
9191 * lisp.h (verify_bytepos, count_markers): New decls,
9192 so that gcc does not warn that these functions aren't declared.
9193
85876d07
PE
9194 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9195 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9196 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9197 (copy_text): Remove unused local var.
85876d07 9198
03d78a21 9199 * filelock.c (within_one_second): Now static.
b3dd38ab 9200 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9201
5df8f01b
PE
9202 * buffer.c (fix_overlays_before): Mark locals as initialized.
9203 (fix_start_end_in_overlays): Likewise. This function should be
9204 simplified by using pointers-to-pointers, but that's a different
9205 matter.
b1d876f1 9206 (switch_to_buffer_1): Now static.
8f54f30a
PE
9207 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9208 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9209
a70072c9 9210 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9211 Fix pointer signedness issue.
edced198
PE
9212 (sys_subshell): Mark local as volatile if checking for lint,
9213 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9214 (MAXPATHLEN): Define only if needed.
a70072c9 9215
a0977c44
PE
9216 * process.c (serial_open, serial_configure): Move decls from here ...
9217 * systty.h: ... to here, so that they can be checked.
9218
a884fdcc
PE
9219 * fns.c (get_random, seed_random): Move extern decls from here ...
9220 * lisp.h: ... to here, so that they can be checked.
9221
604efe86 9222 * sysdep.c (reset_io): Now static.
b8950c94 9223 (wait_for_termination_signal): Remove; unused.
604efe86 9224
38fc62d9
PE
9225 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9226 (copy_keymap_item, append_key, push_text_char_description):
9227 Now static.
1004a21a 9228 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9229 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9230 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9231 (describe_map_tree):
9232 Rename locals to avoid shadowing.
38fc62d9 9233
2f2650da
PE
9234 * keyboard.c: Declare functions static if they are not used elsewhere.
9235 (echo_char, echo_dash, cmd_error, top_level_2):
9236 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9237 (read_char, kbd_buffer_get_event, make_lispy_position):
9238 (make_lispy_event, make_lispy_movement, apply_modifiers):
9239 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9240 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9241 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9242 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9243 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9244
a053e86c 9245 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9246 (mark_kboards): Move decl here ...
9247 * alloc.c (mark_kboards): ... from here.
a053e86c 9248
4752793e
PE
9249 * lisp.h (force_auto_save_soon): New decl.
9250
74f10ca7 9251 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9252 (DEFINE_DUMMY_FUNCTION): New macro.
9253 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9254 Use it.
c03cd23f
PE
9255 (main): Add casts to avoid warnings
9256 if GCC considers string literals to be constants.
74f10ca7 9257
022e70d4
PE
9258 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9259
59d6fe83
PE
9260 * dbusbind.c: Pointer signedness fixes.
9261 (xd_signature, xd_append_arg, xd_initialize):
9262 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9263 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9264 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9265 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9266
78320123
PE
9267 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9268 if GCC considers string literals to be constants.
49cebcca 9269 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9270
35ac2a97
SM
92712011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9272
fb103ca9
SM
9273 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9274 (print_preprocess, print_object): New macro to fix last change.
9275
35ac2a97
SM
9276 * print.c (print_preprocess): Don't forget font objects.
9277
62973b41
JB
92782011-03-16 Juanma Barranquero <lekktu@gmail.com>
9279
9280 * emacs.c (USAGE3): Doc fixes.
9281
0e48bb22
AS
92822011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9283
9284 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9285 structure.
9286
7684e57b
JB
92872011-03-14 Juanma Barranquero <lekktu@gmail.com>
9288
9289 * lisp.h (VWindow_system, Qfile_name_history):
9290 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9291 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9292 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9293
9294 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9295 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9296
9297 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9298 * w32console.c (detect_input_pending, read_input_pending)
9299 (encode_terminal_code):
9300 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9301 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9302 (w32_system_caret_y, Qfile_name_history):
9303 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9304 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9305 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9306 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9307 * w32proc.c (Qlocal, report_file_error):
9308 * w32term.c (Vwindow_system, updating_frame):
9309 * w32uniscribe.c (initialized, uniscribe_font_driver):
9310 Remove unneeded extern declarations.
9311
2aa46d6c
CY
93122011-03-14 Chong Yidong <cyd@stupidchicken.com>
9313
c96bbc66 9314 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9315
cffc6f3b
CY
93162011-03-13 Chong Yidong <cyd@stupidchicken.com>
9317
9318 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9319 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9320 These macros can no longer be used for assignment.
9321
44f230aa
SM
9322 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9323 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9324 (record_buffer_markers, fetch_buffer_markers): New functions for
9325 recording and fetching special buffer markers.
9326 (set_buffer_internal_1, set_buffer_temp): Use them.
9327
9328 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9329
9330 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9331
9332 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9333 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9334
9335 * xdisp.c (hscroll_window_tree):
9336 (reconsider_clip_changes): Use PT instead of BUF_PT.
9337
d251f04b
EZ
93382011-03-13 Eli Zaretskii <eliz@gnu.org>
9339
9340 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9341 $(EMACS_ROOT)/lib/intprops.h.
9342
f0c77cd1
PE
93432011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9344
3eca4629
PE
9345 Fix more problems found by GCC 4.5.2's static checks.
9346
7c86ee98
PE
9347 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9348 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9349 (xg_free_frame_widgets): Make it clear that a local variable is
9350 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9351 (gdk_window_get_screen): Make it clear that this macro is needed
9352 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9353 (int_gtk_range_get_value): New function, which avoids a diagnostic
9354 from gcc -Wbad-function-cast.
9355 (xg_set_toolkit_scroll_bar_thumb): Use it.
9356 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9357 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9358 (get_utf8_string, xg_get_file_with_chooser):
9359 Rename locals to avoid shadowing.
9360 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9361
41729b81
PE
9362 * xgselect.c (xg_select): Remove unused var.
9363
f0c77cd1
PE
9364 * image.c (four_corners_best): Mark locals as initialized.
9365 (gif_load): Initialize transparent_p to zero (Bug#8238).
9366 Mark another local as initialized.
ec6cf4c6 9367 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9368
ce0ad53d 9369 * image.c (clear_image_cache): Now static.
d5d5a617 9370 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9371 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9372 (x_edge_detection): Remove unnecessary cast that
9373 gcc -Wbad-function-cast diagnoses.
2037898d 9374 (gif_load): Fix pointer signedness.
6ae141d6
PE
9375 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9376 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9377
33383987 93782011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9379
d32df629
PE
9380 Improve quality of tests for time stamp overflow.
9381 For example, without this patch (encode-time 0 0 0 1 1
9382 1152921504606846976) returns the obviously-bogus value (-948597
9383 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9384 reports time overflow. See
9385 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9386 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9387 * editfns.c: Include limits.h and intprops.h.
9388 (TIME_T_MIN, TIME_T_MAX): New macros.
9389 (time_overflow): Move earlier, to before first use.
9390 (hi_time, lo_time): New functions, for an accurate test for
9391 out-of-range times.
9392 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9393 (Fget_internal_run_time): Don't assume time_t fits in int.
9394 (make_time): Use list2 instead of Fcons twice.
9395 (Fdecode_time): More accurate test for out-of-range times.
9396 (check_tm_member): New function.
9397 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9398 (lisp_time_argument): Don't rely on undefined left-shift and
9399 right-shift behavior when checking for time stamp overflow.
8be6f318 9400
fe31d94c
PE
9401 * editfns.c (time_overflow): New function, refactoring common code.
9402 (Fformat_time_string, Fdecode_time, Fencode_time):
9403 (Fcurrent_time_string): Use it.
9404
8be6f318
PE
9405 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9406 * dired.c (make_time): Move to ...
9407 * editfns.c (make_time): ... here.
9408 * systime.h: Note the move.
9409
09d9db2c 94102011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9411
126bc0dc
YM
9412 * fringe.c (update_window_fringes): Remove unused variables.
9413
c47cbdfd
YM
9414 * unexmacosx.c (copy_data_segment): Also copy __got section.
9415 (Bug#8223)
9416
7ac80be9
EZ
94172011-03-12 Eli Zaretskii <eliz@gnu.org>
9418
c96bbc66 9419 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9420 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9421 Constify `char *' arguments and their references according to
9422 prototypes in tparam.h.
9423
ecb0f94d 9424 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9425
7ac80be9
EZ
9426 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9427 Adapt all references accordingly.
9428
9429 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9430
ef1fd07e
TT
94312011-03-11 Tom Tromey <tromey@redhat.com>
9432
9433 * buffer.c (syms_of_buffer): Remove obsolete comment.
9434
7ef4b50c
EZ
94352011-03-11 Eli Zaretskii <eliz@gnu.org>
9436
9437 * termhooks.h (encode_terminal_code): Declare prototype.
9438
9439 * msdos.c (encode_terminal_code): Don't declare prototype.
9440
9441 * term.c (encode_terminal_code): Now external again, used by
9442 w32console.c and msdos.c.
9443
44f230aa
SM
9444 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9445 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9446
4b1ec863 94472011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9448
1714f52b 9449 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9450
4b1ec863
PE
9451 * fringe.c (update_window_fringes): Mark locals as initialized
9452 (Bug#8227).
9453 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9454
524c7aa6
PE
9455 * alloc.c (mark_fringe_data): Move decl from here ...
9456 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9457 to check its interface.
9458 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9459
a5c0af81 9460 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9461 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9462 (fontset_font): Mark local as initialized.
a9a06e0b 9463 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9464
b4716021
PE
9465 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9466
811e9bac 9467 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9468 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9469 (x_own_selection, Fx_disown_selection_internal): Rename locals
9470 to avoid shadowing.
9471 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9472
7e3ab302
PE
9473 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9474 so that the caller can use some name other than gcpro1.
9475 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9476 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9477 (Fx_backspace_delete_keys_p):
9478 Use them to avoid shadowing, and rename vars to avoid shadowing.
9479 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9480 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9481 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9482 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9483 Remove unused locals.
7e3ab302
PE
9484 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9485 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9486 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9487 macros.
f78faa98 9488
e2b13473
PE
9489 * xterm.h (x_mouse_leave): New decl.
9490
77f23912
PE
9491 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9492 Remove unused functions.
cdf4ba58
PE
9493 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9494 (x_calc_absolute_position): Now static.
7411c686 9495 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9496 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9497 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9498 unless they are used.
38d0b34a
PE
9499 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9500 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9501 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9502 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9503 (x_error_catcher, x_connection_closed, x_error_handler):
9504 (x_error_quitter, xembed_send_message, x_iconify_frame):
9505 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9506 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9507 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9508
44f230aa
SM
9509 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9510 Rename or move locals to avoid shadowing.
6b463e58 9511 (tty_defined_color, merge_face_heights): Now static.
5967d051 9512 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9513 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9514 does not deduce is never used uninitialized.
73719eba
PE
9515 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9516 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9517
426994c3 9518 * terminal.c (store_terminal_param): Now static.
5489860b 9519
032f1620 9520 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9521 (set_frame_menubar): Remove unused local.
d4323972 9522 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9523 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9524 since they might point to immutable storage.
281585b0
PE
9525 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9526 since it's unused otherwise.
032f1620 9527
367c19e5 9528 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9529 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9530 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9531 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9532 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9533 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9534 does not deduce are never used uninitialized.
70739cbe 9535
07b48fa9
PE
9536 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9537
8868a238 9538 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9539 * window.c (window_loop, size_window):
9540 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9541
7e5cf297 9542 * window.c (display_buffer): Now static.
d6550a9f
PE
9543 (size_window): Mark variables that gcc -Wuninitialized
9544 does not deduce are never used uninitialized.
a586633d
PE
9545 * window.h (check_all_windows): New decl, to forestall
9546 gcc -Wmissing-prototypes diagnostic.
5b555da1 9547 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9548
f6095868
PE
9549 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9550 shadowing.
9551 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9552 Include <limits.h>.
9553 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9554 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9555 (load_charset_map): Mark variables that gcc -Wuninitialized
9556 does not deduce are never used uninitialized.
53df7c11 9557 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9558
f38b440c
PE
9559 * coding.c (coding_set_source, coding_set_destination):
9560 Use "else { /* comment */ }" rather than "else /* comment */;"
9561 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9562 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9563 a block, when the outer 'i' will do.
9564 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9565 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9566 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9567 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9568 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9569 Rename locals to avoid shadowing.
9570 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9571 * coding.c (emacs_mule_char, encode_invocation_designation):
9572 Now static, since they're not used elsewhere.
413bb2db 9573 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9574 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9575 (decode_coding_emacs_mule): Mark variables that gcc
9576 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9577 (detect_coding_iso_2022): Initialize a local variable that might
9578 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9579 this initialization is needed. (Bug#8211)
5f58e762
PE
9580 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9581 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9582 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9583 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9584 Remove unused macros.
f38b440c 9585
232b38b9 9586 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9587 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9588 * character.c (string_count_byte8): Likewise.
232b38b9 9589
fb90da1b
PE
9590 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9591 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9592
fb93dbc2
PE
9593 * chartab.c (copy_sub_char_table): Now static, since it's not used
9594 elsewhere.
5c156ace
PE
9595 (sub_char_table_ref_and_range, char_table_ref_and_range):
9596 Rename locals to avoid shadowing.
bbcd0949 9597 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9598
7d3b3862 9599 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9600 (BIDI_BOB): Remove unused macro.
7d3b3862 9601
6be7d3da
PE
9602 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9603 deduce are never used uninitialized.
c2ed9c8b 9604 * term.c (encode_terminal_code): Likewise.
6be7d3da 9605
75f8807f 9606 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9607
50938595
PE
9608 * tparam.h: New file.
9609 * term.c, tparam.h: Include it.
9610 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9611 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9612 Move these decls to tparam.h, and make them agree with what
9613 is actually in tparam.c. The previous trick of using incompatible
9614 decls in different modules does not conform to the C standard.
9615 All callers of tparam changed to use tparam's actual API.
9616 * tparam.c (tparam1, tparam, tgoto):
9617 Use const pointers where appropriate.
9618
fbceeba2
PE
9619 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9620 * cm.h (struct cm): Likewise.
9621 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9622 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9623 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9624 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9625 (turn_on_face, init_tty): Likewise.
9626 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9627
7f3f1250
PE
9628 * term.c (term_mouse_position): Rename local to avoid shadowing.
9629
e6ca6543
PE
9630 * alloc.c (mark_ttys): Move decl from here ...
9631 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9632
c40f8d15
AS
96332011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9634
9635 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9636
cfe0661d
JB
96372011-03-09 Juanma Barranquero <lekktu@gmail.com>
9638
9639 * search.c (compile_pattern_1): Remove argument regp, unused since
9640 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9641 (compile_pattern): Don't pass it.
9642
0afb4571
J
96432011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9644
9645 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9646 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9647 for ! HAVE_GTK3.
9648 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9649
9650 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9651
9652 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9653 gdk_window_get_screen, gdk_window_get_geometry,
9654 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9655 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9656 (xg_get_pixbuf_from_pixmap): New function.
9657 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9658 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9659 Call xg_get_pixbuf_from_pixmap instead of
9660 gdk_pixbuf_get_from_drawable.
9661 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9662 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9663 (xg_check_special_colors): Use GtkStyleContext and its functions
9664 for HAVE_GTK3.
9665 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9666 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9667 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9668 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9669 Call gtk_widget_get_preferred_size.
0afb4571
J
9670 (xg_frame_resized): gdk_window_get_geometry only takes 5
9671 parameters.
44f230aa
SM
9672 (xg_win_to_widget, xg_event_is_for_menubar):
9673 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9674 (xg_set_widget_bg): New function.
9675 (delete_cb): New function.
895009e1 9676 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9677 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9678 (xg_set_background_color): Call xg_set_widget_bg.
9679 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9680 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9681 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9682 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9683 if ! HAVE_GTK3.
9684 (update_frame_tool_bar): Call gtk_widget_hide.
9685 (xg_initialize): Use GDK_KEY_g.
9686
9687 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9688 if ! HAVE_GTK3
9689 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9690
9691 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9692 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9693 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9694
1c2cc4ef
JB
96952011-03-08 Juanma Barranquero <lekktu@gmail.com>
9696
9697 * w32xfns.c (select_palette): Check success of RealizePalette against
9698 GDI_ERROR, not zero.
9699
33383987 9700See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9701
9702;; Local Variables:
9703;; coding: utf-8
aac0c6e3
MR
9704;; End:
9705
acaf905b 9706 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9707
9708 This file is part of GNU Emacs.
9709
9710 GNU Emacs is free software: you can redistribute it and/or modify
9711 it under the terms of the GNU General Public License as published by
9712 the Free Software Foundation, either version 3 of the License, or
9713 (at your option) any later version.
9714
9715 GNU Emacs is distributed in the hope that it will be useful,
9716 but WITHOUT ANY WARRANTY; without even the implied warranty of
9717 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9718 GNU General Public License for more details.
9719
9720 You should have received a copy of the GNU General Public License
9721 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.