Move functions from C to Lisp. Make non-blocking method calls
[bpt/emacs.git] / src / ChangeLog
CommitLineData
dcbf5805
MA
12012-04-22 Michael Albinus <michael.albinus@gmx.de>
2
3 Move functions from C to Lisp. Make non-blocking method calls
4 the default. Implement further D-Bus standard interfaces.
5
6 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
7 (QCdbus_request_name_allow_replacement)
8 (QCdbus_request_name_replace_existing)
9 (QCdbus_request_name_do_not_queue)
10 (QCdbus_request_name_reply_primary_owner)
11 (QCdbus_request_name_reply_in_queue)
12 (QCdbus_request_name_reply_exists)
13 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
14 (QCdbus_registered_serial, QCdbus_registered_method)
15 (QCdbus_registered_signal): New Lisp objects.
16 (XD_DEBUG_MESSAGE): Use sizeof.
17 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
18 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
19 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
20 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
21 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
22 (xd_signature, xd_append_arg): Allow float for integer types.
23 (xd_get_connection_references): New function.
24 (xd_get_connection_address): Rename from xd_initialize. Return
25 cached address.
26 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
27 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
28 level.
29 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
30 Return number of recounts.
31 (Fdbus_get_unique_name): Make stronger parameter check.
32 (Fdbus_message_internal): New defun.
33 (Fdbus_call_method, Fdbus_call_method_asynchronously)
34 (Fdbus_method_return_internal, Fdbus_method_error_internal)
35 (Fdbus_send_signal, Fdbus_register_service)
36 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
37 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
38 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
39 (Vdbus_compiled_version, Vdbus_runtime_version)
40 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
41 (Vdbus_message_type_method_return, Vdbus_message_type_error)
42 (Vdbus_message_type_signal): New defvars.
43 (Vdbus_registered_buses, Vdbus_registered_objects_table): Adapt
44 docstring.
45
52828e02
PE
462012-04-22 Paul Eggert <eggert@cs.ucla.edu>
47
da05bc4c
PE
48 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
49 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
50 Do not assume ptrdiff_t is the same width as 'int'.
51
52828e02
PE
52 * alloc.c: Handle unusual debugging option combinations.
53 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
54 since the two debugging options are incompatible.
55 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
56 is defined.
57 (mem_init, mem_insert, mem_insert_fixup):
58 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
59 (NEED_MEM_INSERT): Remove; no longer needed.
60
f01769f9
LL
612012-04-22 Leo Liu <sdl.web@gmail.com>
62
63 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
64
5790543d
PE
652012-04-22 Paul Eggert <eggert@cs.ucla.edu>
66
67 * sysdep.c [__FreeBSD__]: Minor cleanups.
68 (list_system_processes, system_process_attributes) [__FreeBSD__]:
69 Use Emacs indenting style more consistently. Avoid some casts.
70 Use 'double' consistently rather than mixing 'float' and 'double'.
71
b91b7e4d
EW
722012-04-21 Eduard Wiebe <usenet@pusto.de>
73
74 * sysdep.c (list_system_processes, system_process_attributes): Add
75 implementation for FreeBSD (Bug#5243).
76
6114eb15
AS
772012-04-21 Andreas Schwab <schwab@linux-m68k.org>
78
79 * lisp.mk (lisp): Update.
80
2f38dff7
PE
812012-04-20 Paul Eggert <eggert@cs.ucla.edu>
82
83 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
84 It is never used otherwise.
85
4ae29f89
SM
862012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
87
88 * print.c (print_preprocess): Only check print_depth if print-circle
89 is nil.
90 (print_object): Check for cycles even when print-circle is nil and
91 print-gensym is t, but only check print_depth if print-circle is nil.
92
f30d612a
CY
932012-04-20 Chong Yidong <cyd@gnu.org>
94
95 * process.c (wait_reading_process_output): If EIO occurs on a pty,
96 set the status to "failed" and ensure that sentinel is run.
97
c07a4c0b 982012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
99
100 * process.c (Fset_process_inherit_coding_system_flag)
101 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 102 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 103
c07a4c0b 1042012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
105
106 * xdisp.c (string_buffer_position_lim): Limit starting position to
107 BEGV.
108 (set_cursor_from_row): If called for a mode-line or header-line
109 row, return zero immediately.
110 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
111 farther than the first row after the header line, if any.
112 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
113 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
114
c07a4c0b 1152012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 116
4ae29f89
SM
117 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
118 (bug#11238).
ad3a2b41 119
c07a4c0b 1202012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 1212012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
122
123 configure: new option --enable-gcc-warnings (Bug#11207)
124 * Makefile.in (C_WARNINGS_SWITCH): Remove.
125 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
126 (ALL_CFLAGS): Use new macros rather than old.
127 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
128 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
129 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
130 -Wunused-result, -Wunused-variable. This should go away once
131 the Emacs and Gnulib regex code is merged.
132 (xmalloc, xrealloc): Now static.
133
aba027e8
PE
1342012-04-17 Paul Eggert <eggert@cs.ucla.edu>
135
136 * dired.c (Fsystem_groups): Remove unused local.
137
e5a36063
GM
1382012-04-17 Glenn Morris <rgm@gnu.org>
139
140 * dired.c (Fsystem_users): Doc fix.
141
316411f0
DA
1422012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
143
144 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
145 (syms_of_dired): Add them.
146
9426aba4
PE
1472012-04-16 Paul Eggert <eggert@cs.ucla.edu>
148
b62a57be
PE
149 Fix minor alloc.c problems found by static checking.
150 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
151 New extern decls, to avoid calling undeclared functions.
152 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
153 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
154 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
155 (NEED_MEM_INSERT): New macro.
156 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 157 Remove one incorrect comment and fix another.
b62a57be 158
3539f31f
PE
159 Fix minor ralloc.c problems found by static checking.
160 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
161 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
162 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
163 (r_alloc_sbrk): Now static.
164
a041960a
PE
165 Improve ralloc.c interface checking.
166 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
167 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
168 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
169 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
170 [REL_ALLOC]: ... to here, to check interface.
171 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
172 Remove decls. This fixes an "It stinks!".
173
9426aba4
PE
174 * alloc.c (which_symbols): Fix alignment issue / type clash.
175
d55c12ed
AS
1762012-04-15 Andreas Schwab <schwab@linux-m68k.org>
177
178 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
179 (struct Lisp_Misc_Any): Likewise.
180 (struct Lisp_Free): Likewise.
181 * alloc.c (union aligned_Lisp_Symbol): Define.
182 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
183 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
184 (union aligned_Lisp_Misc): Define.
185 (MARKER_BLOCK_SIZE, struct marker_block): Use union
186 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 187 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 188
b948ce8b
PE
1892012-04-14 Paul Eggert <eggert@cs.ucla.edu>
190
191 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
192 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
193 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
194 * s/netbsd.h, s/sol2-6.h:
195 Remove definition of GC_MARK_STACK, since the default now works.
196 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
197 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
198 no longer the default.
199 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
200
35dc09a1 2012012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 202
35dc09a1
GM
203 * lread.c (lisp_file_lexically_bound_p):
204 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 205
35dc09a1
GM
2062012-04-14 Eli Zaretskii <eliz@gnu.org>
207
208 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
209 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
210
2112012-04-14 Jan Djärv <jan.h.d@swipnet.se>
212
213 * nsterm.m (constrainFrameRect): Always constrain when there is only
214 one screen (Bug#10962).
215
bcd86815
KB
2162012-04-13 Ken Brown <kbrown@cornell.edu>
217
218 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
219
c25df26e
RT
2202012-04-13 Reuben Thomas <rrt@sc3d.org>
221
222 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
223
0fc59f1e
DC
2242012-04-11 Daniel Colascione <dancol@dancol.org>
225
226 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
227 against is gone. It's better to use vfork now so that when Cygwin
228 gains a new, working vfork, we use it automatically (bug#10398).
229
de8c03dc
SM
2302012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
231
232 * window.c (save_window_save): Obey window-point-insertion-type.
233
2f097256
GM
2342012-04-11 Glenn Morris <rgm@gnu.org>
235
236 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
237
453b951e
SM
2382012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
239
240 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
241
75f1671a 2422012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
243
244 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
245 (force_quit_count): New var.
246 (handle_interrupt): Use it.
247
2a8ce227
JB
2482012-04-10 Juanma Barranquero <lekktu@gmail.com>
249
250 * w32.c (w32_delayed_load): Record the full path of the library
251 being loaded (bug#10424).
252
935396c0
GM
2532012-04-09 Glenn Morris <rgm@gnu.org>
254
05920a43
GM
255 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
256 not just in the obarray, before snarfing them. (Bug#11036)
257
935396c0
GM
258 * Makefile.in ($(leimdir)/leim-list.el):
259 Pass EMACS rather than BUILT_EMACS.
260
a18ecafa
TZ
2612012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
262
263 * process.c (make_process):
264 * process.h: Add integer `gnutls_handshakes_tried' member to
265 process struct.
266
6bbef4e5
JC
267 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
268 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
269
270 * gnutls.c (gnutls_log_function2i): Convenience log function.
271 (emacs_gnutls_read): Use new log functions,
272 `gnutls_handshakes_tried' process member, and
273 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
274 attempts per process (connection).
275
b4d3bc10
CY
2762012-04-09 Chong Yidong <cyd@gnu.org>
277
278 * eval.c (Fuser_variable_p, user_variable_p_eh)
279 (lisp_indirect_variable): Functions deleted.
280 (Fdefvar): Caller changed.
281
282 * callint.c (Finteractive, Fcall_interactively):
283 * minibuf.c (Fread_variable): Callers changed.
284
70f4d973
EZ
2852012-04-09 Eli Zaretskii <eliz@gnu.org>
286
287 * xdisp.c (set_cursor_from_row): If the display string appears in
288 the buffer at position that is closer to point than the position
289 after the display string, display the cursor on the first glyph of
290 the display string. Fixes cursor display when a 'display' text
291 property immediately follows invisible text. (Bug#11094)
292
cb3c2e3e
PE
2932012-04-09 Paul Eggert <eggert@cs.ucla.edu>
294
295 composite.c: use 'double' consistently
296 * composite.c (get_composition_id): Use 'double' consistently
297 instead of converting 'float' to 'double' and vice versa; this is
298 easier to understand and avoids a GCC warning.
299
fd06db5d
GM
3002012-04-09 Glenn Morris <rgm@gnu.org>
301
50fe702a
GM
302 * Makefile.in: Generate leim-list with bootstrap-emacs, in
303 preparation for dumping it with emacs. (Bug#4789)
304 (leimdir): New variable.
305 ($(leimdir)/leim-list.el): New rule.
306 (emacs$(EXEEXT)): Depend on leim-list.el.
307
fd06db5d
GM
308 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
309 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
310 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
311
55c131ee
AS
3122012-04-08 Andreas Schwab <schwab@linux-m68k.org>
313
314 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
315 proper alignment.
316
9209588f
JB
3172012-04-07 Juanma Barranquero <lekktu@gmail.com>
318
319 * xml.c (init_libxml2_functions) [WINDOWSNT]:
320 Remove unused local variable.
321
e3fb2efb
PE
3222012-04-07 Paul Eggert <eggert@cs.ucla.edu>
323
324 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
325 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
326 (mark_memory): Mark Lisp_Objects only if pointers might hide in
327 objects, as mark_maybe_pointer will catch them otherwise.
328 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
329 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
330
b5385551
PE
3312012-04-07 Paul Eggert <eggert@cs.ucla.edu>
332
333 Fix typo that broke non-Windows builds.
334 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
335
9078ead6
EZ
3362012-04-07 Eli Zaretskii <eliz@gnu.org>
337
338 Support building on MS-Windows with libxml2.
339
340 * makefile.w32-in (OBJ2): Add xml.$(O).
341 (GLOBAL_SOURCES): Add xml.c.
342 ($(BLD)/xml.$(O)): New dependency list.
343
344 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
345 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
346 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
347 [!WINDOWSNT]: New macros.
348 (init_libxml2_functions, libxml2_loaded_p): New functions.
349 (parse_region): Call fn_xmlCheckVersion instead of using the macro
350 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
351 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
352 Calls xmlCleanupParser only if libxml2 was loaded (or statically
353 linked in).
6bbef4e5
JC
354 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
355 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
356 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
357
358 * emacs.c: Don't include libxml/parser.h.
359 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
360 xmlCleanupParser directly.
361
362 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
363
3811fdf3
EZ
3642012-04-07 Eli Zaretskii <eliz@gnu.org>
365
366 * indent.c (Fvertical_motion): If there is a display string at
367 point, use it.vpos to compute how many lines to backtrack after
368 move_it_to point. (Bug#11133)
369
2f8e16b2
EZ
3702012-04-06 Eli Zaretskii <eliz@gnu.org>
371
372 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
373 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
374 about subtle differences between FETCH_CHAR* and STRING_CHAR*
375 macros related to unification of CJK characters. For the details,
376 see the discussion following the message here:
377 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
378
3d439cd1
CY
3792012-04-04 Chong Yidong <cyd@gnu.org>
380
381 * keyboard.c (Vdelayed_warnings_list): Doc fix.
382
8bc53d00
EZ
3832012-04-01 Eli Zaretskii <eliz@gnu.org>
384
385 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
386 instead of alloca. (Bug#11138)
387
3b0512a3
AS
3882012-04-01 Andreas Schwab <schwab@linux-m68k.org>
389
390 * w32menu.c (is_simple_dialog): Properly check lisp types.
391 (Bug#11141)
392
8427ddd2
EZ
3932012-03-31 Eli Zaretskii <eliz@gnu.org>
394
979022ef
EZ
395 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
396 position we get to after a call to move_it_to fails the
397 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
398 only if we wind up in a string from display property. (Bug#11063)
399
a6b1c7cc
EZ
400 * window.c (Fdelete_other_windows_internal): Invalidate the row
401 and column information about mouse highlight, so that redisplay
402 restores it after reallocating the glyph matrices. (Bug#7464)
403
8427ddd2
EZ
404 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
405 string comes from a `display' text property, use the buffer
406 position of that property as if we actually saw that position in
407 the row's glyphs.
697ba24b
EZ
408 (move_it_by_lines): Remove the assertion that
409 "it->current_x == 0 && it->hpos == 0" which can be legitimately
410 violated when there's a before-string at the beginning of a line.
411 (Bug#11063)
8427ddd2 412
65a0a738
EZ
4132012-03-30 Eli Zaretskii <eliz@gnu.org>
414
415 * xdisp.c (append_space_for_newline): If the default face was
416 remapped, use the remapped face for the appended newline.
417 (extend_face_to_end_of_line): Use the remapped default face for
418 extending the face to the end of the line.
419 (display_line): Call extend_face_to_end_of_line when the default
420 face was remapped. (Bug#11068)
421
581355cc
EZ
4222012-03-29 Eli Zaretskii <eliz@gnu.org>
423
424 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
425
e8fc049f
SM
4262012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
427
428 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
429
4fb9a543
GM
4302012-03-27 Glenn Morris <rgm@gnu.org>
431
432 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
433 Doc fixes.
434
679910f1
KH
4352012-03-26 Kenichi Handa <handa@m17n.org>
436
437 * dispextern.h (struct glyph): Fix previous change. Change the
438 bit length of glyphless.ch to 25 (Bug#11082).
439
90d49b7f
CY
4402012-03-26 Chong Yidong <cyd@gnu.org>
441
442 * keyboard.c (Vselection_inhibit_update_commands): New variable.
443 (command_loop_1): Use it; inhibit selection update for
444 handle-select-window too (Bug#8996).
445
f514f6f0
FP
4462012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
447
e8fc049f 448 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 449
bf43fa51
KH
4502012-03-25 Kenichi Handa <handa@m17n.org>
451
452 * dispextern.h (struct glyph): Change the bit length of
453 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
454
8a0c01dd
EZ
4552012-03-24 Eli Zaretskii <eliz@gnu.org>
456
457 * s/ms-w32.h (tzname): Include time.h before redirecting to
458 _tzname. Fixes the MSVC build. (Bug#9960)
459
7d1c3a76
AS
4602012-03-24 Andreas Schwab <schwab@linux-m68k.org>
461
8ed79523
AS
462 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
463 characters.
464
7d1c3a76
AS
465 * xterm.c (XTread_socket): Only modify handling_signal if
466 !SYNC_INPUT. (Bug#11080)
467
e99a9b8b
EZ
4682012-03-23 Eli Zaretskii <eliz@gnu.org>
469
470 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
471 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
472 when fetching a multibyte character consumes more bytes than
473 CHAR_BYTES returns, due to unification of CJK characters in
474 string_char. (Bug#11073)
475
5063c0e1
TN
4762012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
477
478 * process.c (wait_reading_process_output): Handle pty disconnect
479 by refraining from sending oneself a SIGCHLD (bug#10933).
480
9f851fbd
CY
4812012-03-22 Chong Yidong <cyd@gnu.org>
482
483 * dispextern.h (struct it): New member string_from_prefix_prop_p.
484
5063c0e1 485 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
486 Mark string as coming from a prefix property.
487 (handle_face_prop): Use default face for prefix strings (Bug#4281).
488 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
489
fb5b8aca
CY
4902012-03-21 Chong Yidong <cyd@gnu.org>
491
492 * xfaces.c (Vface_remapping_alist): Doc fix.
493
62356a1b
EZ
4942012-03-20 Eli Zaretskii <eliz@gnu.org>
495
496 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
497 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
498 Doc fixes.
62356a1b 499
025de85b
CY
5002012-03-20 Chong Yidong <cyd@gnu.org>
501
502 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
503 to reflect default non-nil value of redisplay-dont-pause.
504
4827f94e
KH
5052012-03-19 Kenichi Handa <handa@m17n.org>
506
507 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
508 it fit in a valid range (Bug#11003).
509
e50a24a2
EZ
5102012-03-18 Eli Zaretskii <eliz@gnu.org>
511
512 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
513 that is not from display property, accept the row as a "cursor
514 row" if one of the string's character has a non-nil `cursor'
515 property. Fixes cursor positioning when there are newlines in
516 overlay strings, e.g. in icomplete.el. (Bug#11035)
517
9af5ed87
PE
5182012-03-12 Paul Eggert <eggert@cs.ucla.edu>
519
520 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
521
d1f55f16
CY
5222012-03-12 Chong Yidong <cyd@gnu.org>
523
524 * eval.c (inhibit_lisp_code): Rename from
525 inhibit_window_configuration_change_hook; move from window.c.
526
527 * xfns.c (unwind_create_frame_1, Fx_create_frame):
528 * window.c (run_window_configuration_change_hook)
529 (syms_of_window): Callers changed.
530
66c5eebd
CY
5312012-03-11 Chong Yidong <cyd@gnu.org>
532
413df973
CY
533 * keymap.c (Fkey_description): Doc fix (Bug#9700).
534
66c5eebd
CY
535 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
536
1de11f56
CY
5372012-03-10 Chong Yidong <cyd@gnu.org>
538
539 * frame.c (other_visible_frames): Don't assume the selected frame
540 is visible (Bug#10955).
541
cae07000
SM
5422012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
543
544 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
545
89c94350
JD
5462012-03-08 Jan Djärv <jan.h.d@swipnet.se>
547
548 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
549 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
550 zero (Bug#10954).
551
999dd333
GM
5522012-03-03 Glenn Morris <rgm@gnu.org>
553
01a6dcc8 554 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 555
de0100f2
EZ
5562012-03-02 Eli Zaretskii <eliz@gnu.org>
557
558 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
559 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
560 (redisplay_window, next_element_from_string): Fix typos in
561 comments.
3e441275
EZ
562 (redisplay_window): Pass to move_it_vertically the margin in
563 pixels, not in screen lines.
de0100f2 564
96a72ee9
GM
5652012-03-02 Glenn Morris <rgm@gnu.org>
566
567 * buffer.c (buffer-list-update-hook): Doc fix.
568
312508d7
EZ
5692012-02-29 Eli Zaretskii <eliz@gnu.org>
570
571 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
572 push_it before setting up the iterator for the first overlay
573 string, even if we have an empty string loaded.
574 (next_overlay_string): If there's an empty string on the iterator
575 stack, pop the stack. (Bug#10903)
576
27f3c637
PE
5772012-02-25 Paul Eggert <eggert@cs.ucla.edu>
578
579 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
580 Suggested by Stefan Monnier in
581 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
582 * alloc.c (widen_to_Lisp_Object): New static function.
583 (mark_memory): Also mark Lisp_Objects by fetching pointer words
584 and widening them to Lisp_Objects. This would work even if
585 USE_LSB_TAG is defined and wide integers are used, which might
586 happen in a future version of Emacs.
587
3c9dfce6
CY
5882012-02-25 Chong Yidong <cyd@gnu.org>
589
fa74b241
CY
590 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
591 Doc fix.
592
3c9dfce6
CY
593 * xselect.c (Fx_selection_exists_p): Doc fix.
594 (x_clipboard_manager_save_all): Print an informative message
595 before saving to clipboard manager.
596
9486df08
CY
5972012-02-24 Chong Yidong <cyd@gnu.org>
598
599 * keyboard.c (process_special_events): Handle all X selection
600 requests in kbd_buffer, not just the next one (Bug#8869).
601
f01d3321
CY
6022012-02-23 Chong Yidong <cyd@gnu.org>
603
604 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
605 call when setting menu-bar-lines and tool-bar-lines parameters.
606 (unwind_create_frame_1): New helper function.
607
608 * window.c (inhibit_window_configuration_change_hook): New var.
609 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 610 (syms_of_window): Initialize it.
f01d3321 611
86b847b6
CY
6122012-02-22 Chong Yidong <cyd@gnu.org>
613
614 * xterm.c (x_draw_image_relief): Add missing type check for
615 Vtool_bar_button_margin (Bug#10743).
616
a59225b1
CY
6172012-02-21 Chong Yidong <cyd@gnu.org>
618
619 * fileio.c (Vfile_name_handler_alist): Doc fix.
620
621 * buffer.c (Fget_file_buffer): Protect against invalid file
622 handler return value.
623
310f5bd4
PE
6242012-02-20 Paul Eggert <eggert@cs.ucla.edu>
625
cb3a28cc
PE
626 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
627 when computing $valmask.
628
310f5bd4
PE
629 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
630 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
631 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
632 It's useless in that case, and it can cause problems on hosts
633 that allocate halves of EMACS_INT values separately.
634 Reported by Dan Horák. Diagnosed by Andreas Schwab in
635 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
636 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
637 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
638 it avoids undefined behavior on hosts where shifting right by more
639 than the word width has undefined behavior.
640
2375c96a
CY
6412012-02-19 Chong Yidong <cyd@gnu.org>
642
643 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
644 (Funhandled_file_name_directory, Ffile_name_as_directory)
645 (Fdirectory_file_name, Fexpand_file_name)
646 (Fsubstitute_in_file_name): Protect against invalid file handler
647 return values (Bug#10845).
648
3eb49e71
EZ
6492012-02-18 Eli Zaretskii <eliz@gnu.org>
650
651 * .gdbinit (pitx): Fix incorrect references to fields of the
652 iterator stack.
653
7b926f3f
CY
6542012-02-17 Chong Yidong <cyd@gnu.org>
655
656 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
657
11273115
PE
6582012-02-15 Paul Eggert <eggert@cs.ucla.edu>
659
660 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
661 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
662
c3a70e2b
CY
6632012-02-15 Chong Yidong <cyd@gnu.org>
664
665 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
666 marked as special. Also, starting docstrings with * is obsolete.
667
0ca43699
AS
6682012-02-13 Andreas Schwab <schwab@linux-m68k.org>
669
670 * gnutls.c (emacs_gnutls_write): Fix last change.
671
2e8f3c56
LI
6722012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
673
674 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
675 send_process.
676
af70074f
SM
6772012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
678
679 * keymap.c (Fsingle_key_description): Handle char ranges.
680
95986d52
CY
6812012-02-12 Chong Yidong <cyd@gnu.org>
682
afd83bd1
CY
683 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
684 as that creates a dangerous corner case.
685
95986d52
CY
686 * window.c (Fdelete_window_internal): Invalidate the mouse
687 highlight (Bug#9904).
688
bd7da63e
GM
6892012-02-12 Glenn Morris <rgm@gnu.org>
690
691 * xselect.c (Fx_own_selection_internal)
692 (Fx_get_selection_internal, Fx_disown_selection_internal)
693 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
694 * nsselect.m (Fx_own_selection_internal)
695 (Fx_disown_selection_internal, Fx_selection_exists_p)
696 (Fx_selection_owner_p, Fx_get_selection_internal):
697 Sync docs and argument specs with the xselect.c versions.
698
77abcbc2
LI
6992012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
700
701 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
702
90b671e2
EZ
7032012-02-11 Eli Zaretskii <eliz@gnu.org>
704
1c0ca0b7
EZ
705 * w32select.c (Fx_selection_exists_p): Sync doc string and
706 argument list with xselect.c. (Bug#10783)
707
708 * w16select.c (Fx_selection_exists_p): Sync doc string and
709 argument list with xselect.c. (Bug#10783)
90b671e2 710
49241268
GM
7112012-02-10 Glenn Morris <rgm@gnu.org>
712
713 * fns.c (Fsecure_hash): Doc fix.
714
f998bbe7 7152012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
716
717 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
718
0992bd9c
CY
7192012-02-07 Chong Yidong <cyd@gnu.org>
720
721 * buffer.c (Fbuffer_local_variables)
722 (buffer_lisp_local_variables): Handle unbound vars correctly;
723 don't let Qunbound leak into Lisp.
724
af008560
GM
7252012-02-07 Glenn Morris <rgm@gnu.org>
726
dd605cc4
GM
727 * image.c (Fimagemagick_types): Doc fix.
728
af008560
GM
729 * image.c (imagemagick-render-type): Change it from a lisp object
730 to an integer. Move the doc here from the lisp manual.
731 Treat all values not equal to 0 the same.
732
1449fa1d
CY
7332012-02-06 Chong Yidong <cyd@gnu.org>
734
735 * doc.c (store_function_docstring): Avoid applying docstring of
736 alias to base function (Bug#2603).
737
3723ec07
AS
7382012-02-04 Andreas Schwab <schwab@linux-m68k.org>
739
740 * .gdbinit (pp1, pv1): Remove redundant defines.
741 (pr): Use pp.
742
79c1cc1e
CY
7432012-02-04 Chong Yidong <cyd@gnu.org>
744
745 * nsterm.m: Declare a global (Bug#10694).
746
d7f29f8e
EZ
7472012-02-04 Eli Zaretskii <eliz@gnu.org>
748
cae07000
SM
749 * w32.c (get_emacs_configuration_options):
750 Include --enable-checking, if specified, in the return value.
d7f29f8e 751
3b95a6f9
MR
7522012-02-04 Martin Rudalics <rudalics@gmx.at>
753
754 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
755 after rounding frame sizes. (Bug#9723)
756
d6fa96a6
EZ
7572012-02-04 Eli Zaretskii <eliz@gnu.org>
758
759 * keyboard.c (adjust_point_for_property): Don't position point
760 before BEGV. (Bug#10696)
761
df0b2940
PE
7622012-02-03 Paul Eggert <eggert@cs.ucla.edu>
763
764 Handle overflow when computing char display width (Bug#9496).
765 * character.c (char_width): Return EMACS_INT, not int.
766 (char_width, c_string_width): Check for overflow when
767 computing the width; this is possible now that individual
768 characters can have unbounded width. Problem introduced
769 by merge from Emacs 23 on 2012-01-19.
770
6bee44d6
MA
7712012-02-02 Michael Albinus <michael.albinus@gmx.de>
772
773 * dbusbind.c (Fdbus_register_method): Mention the return value
774 :ignore in the docstring.
775
44f92739
GM
7762012-02-02 Glenn Morris <rgm@gnu.org>
777
1b9f60cc
GM
778 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
779
44f92739
GM
780 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
781 Unconditionally set to t. (Bug#10673)
782 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
783 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
784 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
785
c5d3843c
KH
7862012-02-02 Kenichi Handa <handa@m17n.org>
787
788 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
789 0, do not call append_composite_glyph.
790
159462d4 7912012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
792
793 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
794 NULL (Bug#6988).
795 (x_produce_glyphs): If the component of a composition is a null
796 string, set it->pixel_width to 1 to avoid zero-width glyph.
797
78cef877
EZ
7982012-02-01 Eli Zaretskii <eliz@gnu.org>
799
800 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
801 first 2 arguments are identical. This makes inserting large
802 output from a subprocess an order of magnitude faster on
803 MS-Windows, where all sbrk'ed memory is always contiguous.
804
97897668
GM
8052012-01-31 Glenn Morris <rgm@gnu.org>
806
807 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 808 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
809 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
810
31fd3586
GM
8112012-01-29 Glenn Morris <rgm@gnu.org>
812
813 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
814
0e24a8b2
CY
8152012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
816
817 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
818
cc0adcb0
CY
8192012-01-28 Chong Yidong <cyd@gnu.org>
820
821 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
822
acc28cb9
CY
8232012-01-26 Chong Yidong <cyd@gnu.org>
824
9c69cfb7
CY
825 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
826
acc28cb9
CY
827 * search.c (Fsearch_forward, Fsearch_backward): Document negative
828 repeat counts (Bug#10507).
829
48da7392
GM
8302012-01-26 Glenn Morris <rgm@gnu.org>
831
832 * lread.c (syms_of_lread): Doc fix.
833
14af5f7f
CY
8342012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
835
836 * coding.c (encode_designation_at_bol): Change return value to
837 EMACS_INT.
838
0b21c100
CY
8392012-01-25 Chong Yidong <cyd@gnu.org>
840
841 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
842
3c2907f7
CY
8432012-01-21 Chong Yidong <cyd@gnu.org>
844
845 * floatfns.c (Fcopysign): Make the second argument non-optional,
846 since nil is not allowed anyway.
847
959ad23f
AS
8482012-01-21 Andreas Schwab <schwab@linux-m68k.org>
849
850 * process.c (read_process_output): Use p instead of XPROCESS (proc).
851 (send_process): Likewise.
852
34a02f46
MR
8532012-01-19 Martin Rudalics <rudalics@gmx.at>
854
855 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
856 (Vwindow_persistent_parameters): Do not use Qstate.
857 Rewrite doc-strings.
34a02f46 858
1259009a 8592012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
860
861 * character.c (char_width): New function.
70d4fdf6
GM
862 (Fchar_width, c_string_width, lisp_string_width):
863 Use char_width (Bug#9496).
25ed9e61 864
6a6ee00d
MR
8652012-01-16 Martin Rudalics <rudalics@gmx.at>
866
867 * window.c (Vwindow_persistent_parameters): New variable.
868 (Fset_window_configuration, save_window_save): Handle persistent
869 window parameters.
870
c85efaf7
EZ
8712012-01-14 Eli Zaretskii <eliz@gnu.org>
872
873 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
874 thrashing the stack of the thread. (Bug#9087)
875
5944709e
PE
8762012-01-12 Paul Eggert <eggert@cs.ucla.edu>
877
878 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
879
e71f5d99
EZ
8802012-01-11 Eli Zaretskii <eliz@gnu.org>
881
882 * xdisp.c (rows_from_pos_range): Handle the case where the
883 highlight ends on a newline. (Bug#10464)
884 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
885 he end column for display of highlight that ends on a newline
886 before a R2L line.
887
ce316182
GM
8882012-01-11 Glenn Morris <rgm@gnu.org>
889
890 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
891 from load-path also when installation-directory is nil. (Bug#10208)
892
5b43da69
GM
8932012-01-10 Glenn Morris <rgm@gnu.org>
894
74cc8ff9
GM
895 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
896
7d8d6e4e
GM
897 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
898 Update template values to be closer to their typical values these days.
5b43da69 899
a0db8d43
EZ
9002012-01-09 Eli Zaretskii <eliz@gnu.org>
901
902 * xdisp.c (rows_from_pos_range): Accept additional argument
903 DISP_STRING, and accept any glyph in a row whose object is that
904 string as eligible for mouse highlight. Fixes mouse highlight of
905 display strings from overlays. (Bug#10464)
906
9a0115ab 9072012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 908
b9110d6a 909 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
910 * fileio.c (auto_saving_dir_umask): New static var.
911 (Fmake_directory_internal): Use it.
912 (do_auto_save_make_dir): Set it, instead of invoking chmod after
913 creating the directory. The old code temporarily assigns
914 too-generous permissions to the directory.
915 (do_auto_save_eh): Clear it.
b9110d6a 916 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
917 that the var is always cleared.
918
6c1bd3f3
EZ
9192012-01-07 Eli Zaretskii <eliz@gnu.org>
920
921 * search.c (scan_buffer): Pass character positions to
922 know_region_cache, not byte positions. (Bug#6540)
923
069d2b50
L
9242012-01-07 LynX <_LynX@bk.ru> (tiny change)
925
926 * w32.c (sys_rename): Report EXDEV when rename of a directory
927 fails because the target is on another logical disk. (Bug#10284)
928
75bf0d33
DB
9292012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
930
931 * xterm.c (x_embed_request_focus): New function.
932
933 * xterm.h: Add prototype.
934
935 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
936
1c6e5a32
GM
9372012-01-05 Glenn Morris <rgm@gnu.org>
938
939 * emacs.c (emacs_copyright): Update short copyright year to 2012.
940
651e947e
EZ
9412012-01-01 Eli Zaretskii <eliz@gnu.org>
942
943 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
944 Load gnutls_transport_set_lowat only if GnuTLS version is below
945 2.11.1.
946 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
947 GnuTLS versions below 2.11.1.
948
3778cdd8
AL
9492011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
950
951 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
952 to the doc string advising against its use for altering the way
953 windows are scrolled.
954
0e5317f7
KH
9552011-12-28 Kenichi Handa <handa@m17n.org>
956
957 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
958 coding-system ASCII compatible only when it does not produce BOM
959 on encoding (Bug#10383).
960
93d5ca1f
JD
9612011-12-26 Jan Djärv <jan.h.d@swipnet.se>
962
963 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
964 can scroll.
965 (create_and_show_popup_menu): Always use menu_position_func for
966 Gtk3 (Bug#10361).
967
ca22b785
AS
9682011-12-24 Andreas Schwab <schwab@linux-m68k.org>
969
970 * callint.c (Fcall_interactively): Don't truncate prompt string.
971
d048e1e6
EZ
9722011-12-23 Eli Zaretskii <eliz@gnu.org>
973
974 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
975 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 976 resumed from there (after widening). (Bug#10360)
d048e1e6 977
5ccaba1f
JD
9782011-12-22 Jan Djärv <jan.h.d@swipnet.se>
979
980 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
981
204ee57f
JD
9822011-12-21 Jan Djärv <jan.h.d@swipnet.se>
983
b81d40f0
JB
984 * nsterm.m (x_free_frame_resources):
985 Release f->output_data.ns->miniimage.
204ee57f
JD
986 (ns_index_color): Fix indentation. Do not retain
987 color_table->colors[i].
988
989 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
990 before returning.
991
992 * nsfns.m (x_set_background_color): Assign return value from
993 ns_index_color to face-background instead of NSColor*.
994 (ns_implicitly_set_icon_type): Fix indentation.
995 Change assignment in for loop to comparison.
996
997 * emacs.c (ns_pool): New variable.
998 (main): Assign ns_pool.
999 (Fkill_emacs): Call ns_release_autorelease_pool.
1000
1001 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1002 autorelease fdesc, release fdAttrs and tdict.
1003 (ns_get_covering_families): Release charset.
1004 (ns_findfonts): Release NSFontDescriptor created with new.
1005 (ns_uni_to_glyphs): Fix indentation.
1006 (setString): Release attrStr before assigning new value.
1007
c803b2b7
JD
10082011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1009
678f4426
JD
1010 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1011 and NS_IMPL_COCOA.
1012 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1013 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1014
cd394be1 10152011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1016
5fecd5fc
JD
1017 * nsterm.m (ns_term_init): Subscribe for notifications
1018 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1019 to method trackingNotification in EmacsMenu.
1020
1021 * nsmenu.m (trackingMenu): New variable.
3771cb17 1022 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1023 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1024 from Aquamacs (Bug#7030).
678f4426
JD
1025
10262011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1027
c803b2b7
JD
1028 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1029 (symbol_to_nsstring): Fix indentation.
1030 (ns_symbol_to_pb): New function.
cae07000
SM
1031 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1032 (Fns_rotate_cut_buffers_internal): Remove.
1033 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1034 Fns_store_cut_buffer_internal.
1035 (ns_get_foreign_selection, Fx_own_selection_internal)
1036 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1037 (Fns_get_selection_internal, Fns_store_selection_internal):
1038 Use ns_symbol_to_pb and check if return value is nil.
1039 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1040 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1041 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1042 renamed to Sns_store_selection_internal.
1043 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1044 and remove this function.
1045 (ns_handle_selection_clear): Remove, never used.
1046 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1047 here.
1048
e1b01a3a
KB
10492011-12-17 Ken Brown <kbrown@cornell.edu>
1050
1051 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1052 GID is unknown (Bug#10257).
1053
2adb6e85
PE
10542011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1055
1056 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1057 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1058 which caused a build failure on GNU/Linux IA-64. This problem was
1059 introduced by my 2011-10-07 patch.
1060
d1d7b339
JL
10612011-12-15 Juri Linkov <juri@jurta.org>
1062
1063 * image.c (imagemagick_error): New function. (Bug#10112)
1064 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1065 Use `imagemagick_error' where ImageMagick functions return
1066 `MagickFalse'.
1067 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1068 proper order.
1069
100d5755
KH
10702011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1071
1072 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1073 fill background (Bug#8992).
1074
454592a6
MR
10752011-12-13 Martin Rudalics <rudalics@gmx.at>
1076
1077 * window.c (Vwindow_combination_resize)
1078 (Vwindow_combination_limit): Use t instead of non-nil in
1079 doc-strings.
61d4b438
MR
1080 (Vrecenter_redisplay): Add first sentence of doc-string on
1081 separate line.
53524d93 1082 (Frecenter): Fix doc-string typo.
454592a6 1083
3633e3aa
KH
10842011-12-11 Kenichi Handa <handa@m17n.org>
1085
1086 * coding.c (Funencodable_char_position): Pay attention to the
1087 buffer text relocation (Bug#9389).
1088
7b9d523a
JD
10892011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1090
1091 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1092 gtk_init (Bug#10100).
1093
b73189c6
EZ
10942011-12-10 Eli Zaretskii <eliz@gnu.org>
1095
1096 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1097 IT->string is nil. (Bug#10263)
1098
f7dfe5d6
JD
10992011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1100
83faebb4
JD
1101 * nsterm.h (x_free_frame_resources): Declare.
1102
f7dfe5d6
JD
1103 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1104 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1105
1106 * nsterm.h (ns_get_defaults_value): Declare.
1107
1108 * nsterm.m (ns_default): Call ns_get_defaults_value.
1109
7cd4e72c
EZ
11102011-12-09 Eli Zaretskii <eliz@gnu.org>
1111
1112 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1113 (Bug#10170)
1114
b34d7317
YM
11152011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1116
1117 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1118 that where the value of an _OBJC_* symbol points to is in the .bss
1119 section (Bug#10240).
1120
76470ad1
KH
11212011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1122
1123 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1124 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1125
745fff94
KH
11262011-12-08 Kenichi Handa <handa@m17n.org>
1127
1128 * ftfont.c (get_adstyle_property): Fix previous change
1129 (Bug#10233).
1130
6e44397c
JB
11312011-12-07 Juanma Barranquero <lekktu@gmail.com>
1132
1133 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1134 dirs from the default value of EMACSLOADPATH (bug#10208).
1135
7efa6272
GM
11362011-12-07 Glenn Morris <rgm@gnu.org>
1137
1138 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1139 installation and source directories as well. (Bug#10208)
1140
f6fc4d87
CY
11412011-12-06 Chong Yidong <cyd@gnu.org>
1142
1143 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1144
2bf26180
GM
11452011-12-06 Glenn Morris <rgm@gnu.org>
1146
1147 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1148 as an error, not just -1. (Bug#10217)
1149
3a6ad4f0
CY
11502011-12-05 Chong Yidong <cyd@gnu.org>
1151
1152 * keyboard.c (process_special_events): New function.
1153 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1154
75a3b399
PE
11552011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1156
1157 * coding.c (encode_designation_at_bol): Don't use uninitialized
1158 local variable (Bug#9318).
1159
c3c9e25e
KH
11602011-12-05 Kenichi Handa <handa@m17n.org>
1161
1162 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1163 return Qnil (Bug#8046, Bug#10193).
1164
5eb05ea3
KH
11652011-12-05 Kenichi Handa <handa@m17n.org>
1166
1167 * coding.c (encode_designation_at_bol): New args charbuf_end and
1168 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1169 (coding_set_source): Return how many bytes coding->source was
1170 relocated.
1171 (coding_set_destination): Return how many bytes
1172 coding->destination was relocated.
1173 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1174 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1175
11762011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1177
1178 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1179 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1180 macro (Bug#9318).
1181
11822011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1183
1184 The following changes are to fix Bug#9318.
1185
a79703f5 1186 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1187 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1188 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1189 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1190
7dbda6df
JB
11912011-12-05 Juanma Barranquero <lekktu@gmail.com>
1192
1193 * lisp.h (process_quit_flag): Fix external declaration.
1194
6d5eb5b0
SM
11952011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1196
1197 Don't macro-inline non-performance-critical code.
1198 * eval.c (process_quit_flag): New function.
1199 * lisp.h (QUIT): Use it.
1200
a0c3fad0
JD
12012011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1202
1203 * nsfns.m (get_geometry_from_preferences): New function.
1204 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1205
6c07aac2
AS
12062011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1207
1208 * emacs.c (Qkill_emacs): Define.
1209 (syms_of_emacs): Initialize it.
1210 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1211 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1212 (quit_throw_to_read_char): Add parameter `from_signal'.
1213 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1214 * lisp.h (QUIT): Call Fkill_emacs if requested.
1215
c052ead4
JD
12162011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1217
1218 * widget.c (update_wm_hints): Return if wmshell is null.
1219 (widget_update_wm_size_hints): New function.
1220
1221 * widget.h (widget_update_wm_size_hints): Declare.
1222
1223 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1224 widget_update_wm_size_hints (Bug#10104).
1225
9e49252b
EZ
12262011-12-03 Eli Zaretskii <eliz@gnu.org>
1227
1228 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1229 before a newline, prepare the bidi iterator for consuming the
1230 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1231 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1232
02b16839
JL
12332011-12-02 Juri Linkov <juri@jurta.org>
1234
1235 * search.c (Fword_search_regexp): New Lisp function created from
1236 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1237 (Fword_search_backward, Fword_search_forward)
1238 (Fword_search_backward_lax, Fword_search_forward_lax):
1239 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1240 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1241
0068070e
SM
12422011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1243
1244 * fileio.c (Finsert_file_contents): Move after-change-function call
1245 to before the "handled:" label, since all "goto handled" appear in
1246 cases where the *-change-functions have already been properly called
1247 (bug#10117).
1248
3360a3fc
AS
12492011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1250
1251 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1252 waiting for input. (Bug#10169)
1253
73d6c093
EZ
12542011-11-30 Eli Zaretskii <eliz@gnu.org>
1255
1256 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1257 verifies glyph row's hash code--we have just reallocated the
1258 glyphs, so their contents can be complete garbage. (Bug#10164)
1259
febe6bea
JB
12602011-11-30 Juanma Barranquero <lekktu@gmail.com>
1261
1262 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1263
801a4313
EZ
12642011-11-30 Eli Zaretskii <eliz@gnu.org>
1265
1266 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1267 attributes are tested _before_ calling verify_row_hash, to protect
1268 against GCC re-ordering of the tests. (Bug#10164)
1269
2b56b87e
JD
12702011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1271
1272 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1273
1274 * xterm.c (handle_one_xevent): Only set async_visible and friends
1275 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1276 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1277 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1278
dbf31225
PE
12792011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1280
1281 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1282 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1283 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1284 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1285 All uses changed to use GCPRO1 etc.
1286 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1287 Revert to old implementation (i.e., before 2011-03-11).
1288
1305621b
YM
12892011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1290
1291 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1292 of scroll runs so as to avoid assigning disabled bogus rows and
1293 unnecessary graphics copy operations.
1294
8c9afb46
EZ
12952011-11-27 Eli Zaretskii <eliz@gnu.org>
1296
1297 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1298 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1299 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1300 (malloc, free, realloc, calloc): Redirect to e_* only when
1301 compiling Emacs.
1302
1303 * lisp.h (GCTYPEBITS): Move before first use.
1304 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1305 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1306 this macro definition.
1307
1308 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1309 _MSC_VER.
1310
54e9e3bf
JD
13112011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1312
6d5eb5b0
SM
1313 * gtkutil.c (xg_create_frame_widgets):
1314 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1315 present with Gtk+ 2.0.
1316
83aca1cb
PE
13172011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1318
1319 * fileio.c (Finsert_file_contents): Undo previous change; see
1320 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1321
5b76caa4
PE
13222011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1323
1324 Rename locals to avoid shadowing.
1325 * fileio.c (Finsert_file_contents):
1326 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1327 * process.c (wait_reading_process_output):
1328 Rename inner 'proc' to 'p' to avoid shadowing.
1329 Indent for consistency with usual Emacs style.
1330
8c535114
EZ
13312011-11-25 Eli Zaretskii <eliz@gnu.org>
1332
1333 * xdisp.c (redisplay_window): If cursor row is not fully visible
1334 after recentering, and scroll-conservatively is set to a large
1335 number, scroll window by a few more lines to make the cursor fully
1336 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1337 (start_display): Don't move to the next line if the display should
1338 start at a newline that is part of a display vector or an overlay
1339 string. (Bug#10119)
8c535114 1340
fa4fdb5c
JL
13412011-11-24 Juri Linkov <juri@jurta.org>
1342
1343 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1344 after the `MagickPingImage' call. (Bug#10112)
1345
90ec88df
CY
13462011-11-23 Chong Yidong <cyd@gnu.org>
1347
1348 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1349
56e2e794
MR
13502011-11-23 Martin Rudalics <rudalics@gmx.at>
1351
1352 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1353 making another buffer current. (Bug#10114)
1354
b6e64c41
GM
13552011-11-23 Glenn Morris <rgm@gnu.org>
1356
1357 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1358
6b21de18
CY
13592011-11-23 Chong Yidong <cyd@gnu.org>
1360
1361 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1362 using it (Bug#5984).
1363
b12cd789
EZ
13642011-11-22 Eli Zaretskii <eliz@gnu.org>
1365
1366 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1367 and header-lines, as they don't have one computed for them.
1368 (Bug#10098)
1369
1370 * .gdbinit (prow): Make displayed values more self-explaining.
1371 Add row's hash code.
1372
261b6fd4
LMI
13732011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1374
1375 * process.c (wait_reading_process_output): Fix asynchrounous
1376 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1377 (wait_reading_process_output): Add comment and URL.
261b6fd4 1378
e7cfd277
JD
13792011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1380
1381 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1382
a9b9b7f5
CY
13832011-11-21 Chong Yidong <cyd@gnu.org>
1384
1385 * window.c (Fnext_window, Fprevious_window): Doc fix.
1386
b0d15b4f
SM
13872011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1388
1389 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1390
fe7a3057
JB
13912011-11-20 Juanma Barranquero <lekktu@gmail.com>
1392
1393 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1394
d2999b1a
MR
13952011-11-20 Martin Rudalics <rudalics@gmx.at>
1396
1397 * window.c (Fset_window_combination_limit): Rename argument
1398 STATUS to LIMIT.
1399 (Vwindow_combination_limit): Remove "status" from doc-string.
1400
d5ff9cd0
AS
14012011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1402
1403 * m/ibms390.h: Remove.
1404 * m/ibms390x.h: Don't include "ibms390.h".
1405
a5bb9bd3
SM
14062011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1407
1408 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1409 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1410
cd1181db
JB
14112011-11-20 Juanma Barranquero <lekktu@gmail.com>
1412
1413 * casetab.c (Fset_case_table):
1414 * charset.c (Fcharset_after): Fix typos.
1415
615a3b8d 14162011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1417
17e845af
PE
1418 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1419 Otherwise, valgrind does not work on some platforms.
1420 Problem reported by Andreas Schwab in
6a0bf43d
PE
1421 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1422 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1423 is set, removing the need for VIRT_ADDRESS_VARIES.
1424 (PURE_P): Use a more-efficient implementation that needs just one
1425 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1426 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1427 to 4 (xorl, subq, cmpq, setbe).
1428 * alloc.c (pure): Always extern now, since that's the
1429 VIRT_ADDR_VARIES behavior.
1430 (PURE_POINTER_P): Use a single comparison, not two, for
1431 consistency with the new puresize.h.
1432 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1433 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1434 Remove VIRT_ADDR_VARIES no longer needed.
1435
f8fe6f96
EZ
14362011-11-19 Eli Zaretskii <eliz@gnu.org>
1437
1438 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1439 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1440 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1441 behave as if the cursor position were at the window margin.
1442
1443 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1444 and the cursor position is out of bounds, behave as if the cursor
1445 position were at the window margin. (Bug#10075)
1446
df05a53c
CY
14472011-11-18 Chong Yidong <cyd@gnu.org>
1448
1449 * window.c (Fwindow_combination_limit): Make first argument
1450 non-optional, since it is meaningless for live windows like the
1451 selected window.
1452
2071918e
DA
14532011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1454
1455 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1456
b50a28de
SM
14572011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1458
1459 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1460 (graft_intervals_into_buffer): Simplify.
1461
015137db
EZ
14622011-11-18 Eli Zaretskii <eliz@gnu.org>
1463
1464 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1465 hash values of the two rows.
1466 (copy_row_except_pointers): Preserve the used[] arrays and the
1467 hash values of the two rows. (Bug#10035)
68c95424 1468 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1469
1470 * xdisp.c (row_hash): New function, body extracted from
1471 compute_line_metrics.
1472 (compute_line_metrics): Call row_hash, instead of computing the
1473 hash code inline.
1474
1475 * dispnew.c (verify_row_hash): Call row_hash for computing the
1476 hash code of a row, instead of duplicating code from xdisp.c.
1477
1478 * dispextern.h (row_hash): Add prototype.
1479
a2addb04
TH
14802011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1481
1482 * frame.c (delete_frame): Don't delete the terminal when the last
1483 X frame is closed if emacs is built with GTK toolkit.
1484
df85d315
JB
14852011-11-17 Juanma Barranquero <lekktu@gmail.com>
1486
1487 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1488
a0c2d0ae
MR
14892011-11-17 Martin Rudalics <rudalics@gmx.at>
1490
1491 * window.c (Vwindow_splits): Rename to
1492 Vwindow_combination_resize. Suggested by Juri Linkov.
1493 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1494 of Vwindow_splits.
1495
58179cce
JB
14962011-11-16 Juanma Barranquero <lekktu@gmail.com>
1497
7877f373
JB
1498 * nsfns.m (Fns_font_name):
1499 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1500
b6f67890
MR
15012011-11-16 Martin Rudalics <rudalics@gmx.at>
1502
1503 * window.h (window): Rename slot "nest" to "combination_limit".
1504 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1505 (Fset_window_nest): Rename to Fset_window_combination_limit.
1506 (Vwindow_nest): Rename to Vwindow_combination_limit.
1507 (recombine_windows, make_parent_window, make_window)
1508 (Fsplit_window_internal, saved_window)
1509 (Fset_window_configuration, save_window_save): Rename all
1510 occurrences of window_nest to window_combination_limit.
1511
c7015153
JB
15122011-11-15 Juanma Barranquero <lekktu@gmail.com>
1513
1514 * image.c (imagemagick_load_image): Fix typo.
1515
322ad6ec
EZ
15162011-11-14 Eli Zaretskii <eliz@gnu.org>
1517
1518 * xdisp.c (display_line): Move the call to
1519 highlight_trailing_whitespace before the call to
1520 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1521 faces of all the glyphs to compute ROW's hash value.
1522 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1523
f067b8ec
JB
15242011-11-14 Juanma Barranquero <lekktu@gmail.com>
1525
1526 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1527 just return (bug#10044).
1528
1e5b2111
EZ
15292011-11-12 Eli Zaretskii <eliz@gnu.org>
1530
7ef3cbd5
EZ
1531 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1532 with user-defined heap size. Bump the default size of the temacs
1533 heap to 27MB, to avoid memory warning when running temacs.
1534 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1535
1e5b2111
EZ
1536 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1537 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1538 (verify_row_hash) [XASSERTS]: New function.
1539 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1540 that the hash value of glyph rows is correct.
1e5b2111 1541
89d61221
MR
15422011-11-12 Martin Rudalics <rudalics@gmx.at>
1543
1544 * window.h (window): Remove splits slot.
1545 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1546 (Fdelete_other_windows_internal, make_parent_window)
1547 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1548 (Fset_window_configuration, save_window_save): Don't deal with
1549 split status of windows.
1550 (saved_window): Remove splits slot.
1551 (Vwindow_splits): Rewrite doc-string.
1552
97f18cc8
JD
15532011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1554
1555 * xfns.c (unwind_create_frame):
1556 * nsfns.m (unwind_create_frame):
1557 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1558 Vframe_list (Bug#9999).
1559
22a648b4
DA
15602011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1561
0b381c7e 1562 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1563
659afede
KH
15642011-11-11 Kenichi Handa <handa@m17n.org>
1565
1566 * callproc.c (Fcall_process): Set the member dst_multibyte of
1567 process_coding.
1568
9ac0394b
KH
15692011-11-11 Johan Bockgård <bojohan@gnu.org>
1570
1571 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1572 avoid a crash (bug#9496).
1573
2fbdc249
CY
15742011-11-09 Chong Yidong <cyd@gnu.org>
1575
1576 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1577 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1578
ac6b1f81
PE
15792011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1580
1581 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1582
09db192c
PE
15832011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1584
1585 Avoid some portability problems by eschewing 'extern inline' functions.
1586 The trivial performance wins aren't worth the portability hassles; see
1587 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1588 et seq.
1589 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1590 (window_box_width, window_box_left, window_box_left_offset)
1591 (window_box_right, window_box_right_offset): Undo previous change,
1592 by removing the "extern"s.
1593 * intervals.c (adjust_intervals_for_insertion)
1594 (adjust_intervals_for_deletion): Undo previous change,
1595 making these static again.
1596 (offset_intervals, temp_set_point_both, temp_set_point)
1597 (copy_intervals_to_string): No longer inline.
1598 * xdisp.c (window_text_bottom_y, window_box_width)
1599 (window_box_height, window_box_left_offset)
1600 (window_box_right_offset, window_box_left, window_box_right)
1601 (window_box): No longer inline.
1602
105216ed
CY
16032011-11-08 Chong Yidong <cyd@gnu.org>
1604
1605 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1606 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1607 Signal an error if not a live window.
105216ed
CY
1608 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1609 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1610
ae9e237f
JB
16112011-11-07 Juanma Barranquero <lekktu@gmail.com>
1612
1613 * lisp.h (syms_of_abbrev): Remove declaration.
1614 Reported by CHENG Gao <chenggao@royau.me>.
1615
c7aa8333
EZ
16162011-11-07 Eli Zaretskii <eliz@gnu.org>
1617
1618 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1619 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1620 of temacs in GUI mode.
1621
be7f5545
MR
16222011-11-07 Martin Rudalics <rudalics@gmx.at>
1623
1624 * window.h: Declare delete_all_child_windows instead of
1625 delete_all_subwindows.
1626 * window.c (Fwindow_nest, Fset_window_nest)
1627 (Fset_window_new_total, Fset_window_new_normal)
1628 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1629 (delete_all_subwindows): Rename to delete_all_child_windows.
1630 (Fdelete_other_windows_internal, Fset_window_configuration):
1631 Call delete_all_child_windows instead of delete_all_subwindows.
1632 * frame.c (delete_frame): Call delete_all_child_windows instead
1633 of delete_all_subwindows.
1634
ca78dc43
PE
16352011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1636
1637 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1638 This is also needed for porting to any host where GC_MARK_STACK is
1639 not GC_MAKE_GCPROS_NOOPS.
1640 (which_symbols): Use it.
1641
a0241d01
KH
16422011-11-07 Kenichi Handa <handa@m17n.org>
1643
1644 * coding.c (coding_set_destination): Check coding->src_pos only
1645 when coding->src_object is a buffer (bug#9910).
1646
1647 * process.c (send_process): Set the member src_multibyte of coding
1648 to 0 (bug#9911) when sending a unibyte text.
1649
1650 * callproc.c (Fcall_process): Set the member src_multibyte of
1651 process_coding to 0 (bug#9912).
1652
a64bfdfa 16532011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1654
1655 * xmenu.c (cleanup_widget_value_tree): New function.
1656 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1657 calling free_menubar_widget_value_tree directly (Bug#9830).
1658
cb41b32a
PE
16592011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1660
1661 Fix some portability problems with 'inline'.
1662 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1663 (window_box_width, window_box_left, window_box_left_offset)
1664 (window_box_right, window_box_right_offset): Declare extern.
1665 Otherwise, these inline functions do not conform to C99 and
1666 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1667 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1668 * intervals.c (adjust_intervals_for_insertion)
1669 (adjust_intervals_for_deletion): Now extern, because otherwise the
1670 extern inline functions 'offset_intervals' couldn't refer to it.
1671 (static_offset_intervals): Remove.
1672 (offset_intervals): Rewrite using the old contents of
1673 static_offset_intervals. The old version didn't conform to C99
1674 because an extern inline function contained a reference to an
1675 identifier with static linkage.
1676
b7041366
AS
16772011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1678
1679 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1680 GC.
1681
88a37c4d
EZ
16822011-11-06 Eli Zaretskii <eliz@gnu.org>
1683
1684 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1685 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1686 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1687 return Qleft_to_right.
1688
49745b39
CY
16892011-11-06 Chong Yidong <cyd@gnu.org>
1690
1691 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1692 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1693 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1694 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1695 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1696 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1697 (Fwindow_vscroll): Doc fix.
1698 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1699 argument, since it makes no sense to pass a live window and for
1700 consistency with window-child.
1701
1f05cd82
CS
17022011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1703
1704 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1705 support MSVC.
1706
22610910
JR
17072011-11-05 Jason Rumney <jasonr@gnu.org>
1708
1709 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1710 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1711 fonts (Bug#6029).
1712 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1713 bitwise arithmetic preventing use of unicode-sip and non-truetype
1714 opentype fonts.
1715
a06776b2
EZ
17162011-11-05 Eli Zaretskii <eliz@gnu.org>
1717
3ad924ba
EZ
1718 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1719 "emacs"-only part.
1720
a06776b2
EZ
1721 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1722 initialization code to keep similarity to xfns.c after changes
1723 from 2011-11-05.
1724
c9e7db78
JD
17252011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1726
a97f8f3f
JD
1727 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1728 (unwind_create_frame): New function (Bug#9943).
1729 (Fx_create_frame): Restructure code to be more similar to the one in
1730 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1731 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1732 Move terminal->reference_count++ just before making the frame official
1733 (Bug#9943).
1734
1735 * nsterm.m (x_free_frame_resources): New function.
1736 (x_destroy_window): Move code to x_free_frame_resources.
1737
c9e7db78 1738 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1739 (Fx_create_frame, x_create_tip_frame):
1740 Move terminal->reference_count++ just before making the frame
75f1671a 1741 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1742 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1743
a6fc3b5c
EZ
17442011-11-05 Eli Zaretskii <eliz@gnu.org>
1745
1746 Support MSVC build with newer versions of Visual Studio.
1747 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1748 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1749 nt/gmake.defs.
1750
1751 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1752 which are not supported by MSVC.
1753 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1754 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1755 bitfields.
1756 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1757 types in bitfields.
1758 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1759
1760 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1761
58179cce 17622011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1763
1764 Support MSVC build with newer versions of Visual Studio.
1765 * w32.c: Don't include w32api.h for MSVC.
1766 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1767
1768 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1769 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1770 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1771 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1772 e_* cousins.
1773 (alloca) [_MSC_VER]: Define to _alloca.
1774
1775 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1776
1777 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1778
a58c13ed
EZ
17792011-11-04 Eli Zaretskii <eliz@gnu.org>
1780
1781 * xdisp.c (note_mouse_highlight): If either of
1782 previous/next-single-property-change returns nil, treat that as
1783 the beginning or the end of the buffer. (Bug#9955)
1784
fe0b6370
JD
17852011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1786
a58c13ed 1787 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1788 label is not null (Bug#9951).
1789 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1790 may be NULL.
1791
89bd5ee1
EZ
17922011-11-04 Eli Zaretskii <eliz@gnu.org>
1793
1794 * window.c (Fwindow_body_size): Mention in the doc string that the
1795 return value is in frame's canonical units. (Bug#9949)
1796
84c3edb9
EZ
17972011-11-03 Eli Zaretskii <eliz@gnu.org>
1798
4e2fb5c7
EZ
1799 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1800
84c3edb9 1801 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1802 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1803 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1804
bc17a887
EZ
18052011-11-01 Eli Zaretskii <eliz@gnu.org>
1806
1807 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1808 Don't stop backward scan on the continuation glyph, even though
1809 its CHARPOS is positive.
6d5eb5b0
SM
1810 (mouse_face_from_buffer_pos, note_mouse_highlight):
1811 Rename cover_string to disp_string.
bc17a887 1812
4ee88440
MR
18132011-11-01 Martin Rudalics <rudalics@gmx.at>
1814
1815 * window.c (temp_output_buffer_show): Don't use
1816 Vtemp_buffer_show_specifiers.
1817 (Vtemp_buffer_show_specifiers): Remove unused variable.
1818
c2ff3c02
EZ
18192011-10-30 Eli Zaretskii <eliz@gnu.org>
1820
1821 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1822 past the beginning of the current glyph matrix.
1823
58179cce 18242011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1825
1826 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1827 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1828 HAVE_GTK3 (Bug#9869).
b77a6a7f 1829
3b574623
JD
1830 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1831 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1832
b77a6a7f
JD
1833 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1834
1835 * xterm.c: Declare x_handle_net_wm_state to return int.
1836 (handle_one_xevent): Check if we are iconified but don't have
1837 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1838 (get_current_wm_state): Return non-zero if not hidden,
1839 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1840 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1841 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1842 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1843
196e41e4
PE
18442011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1845
1846 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1847 so that this new function doesn't get optimized away by a
1848 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1849
021f2e1a
AS
18502011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1851
1852 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1853
8b058d44
EZ
18542011-10-29 Eli Zaretskii <eliz@gnu.org>
1855
1856 Fix the `xbytecode' command.
1857 * .gdbinit (xprintbytestr): New command.
b50a28de 1858 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1859 (xbytecode): Print the byte-code string as well.
1860
4452fb80
EZ
18612011-10-29 Kim Storm <storm@cua.dk>
1862
8b058d44
EZ
1863 * alloc.c (which_symbols): New function.
1864
21b72067
AS
18652011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1866
1867 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1868 line. (Bug#9903)
1869
83ed7b5c
GM
18702011-10-29 Glenn Morris <rgm@gnu.org>
1871
1872 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1873 Not clear what it was for, and it causes various bugs. (Bug#9839)
1874
5a7a728b
EZ
18752011-10-28 Eli Zaretskii <eliz@gnu.org>
1876
1877 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1878 possible random value that matches one of those tested as
1879 condition to clear the mouse face.
1880
d3d0842f
CY
18812011-10-28 Chong Yidong <cyd@gnu.org>
1882
1883 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1884
31b39d13
DN
18852011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1886
1887 * window.c (make_window): Initialize phys_cursor_on_p.
1888
9aba6043
SM
18892011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1890
1891 * lisp.h (struct Lisp_Symbol): Update comments.
1892
c20992f4
JB
18932011-10-28 Juanma Barranquero <lekktu@gmail.com>
1894
1895 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1896
db4f02f2
EZ
18972011-10-28 Eli Zaretskii <eliz@gnu.org>
1898
1899 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1900 <oslsachem@gmail.com> for helping to debug this.
1901
1902 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1903 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1904 (g_b_init_get_glyph_outline_w): New static variables.
1905 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1906 (GetGlyphOutlineW_Proc): New typedefs.
1907 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1908 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1909 New functions.
1910 (w32font_open_internal, compute_metrics):
1911 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1912 instead of calling the "wide" APIs directly.
1913
1914 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1915
1916 * w32.h (syms_of_w32font): Add prototype.
1917
87e68db4
JB
19182011-10-27 Juanma Barranquero <lekktu@gmail.com>
1919
1920 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1921 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1922 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1923 (Fmove_to_window_line): Doc fix.
1924
435c1d67
CY
19252011-10-27 Chong Yidong <cyd@gnu.org>
1926
1927 * process.c (make_process): Set gnutls_state to NULL.
1928
1929 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1930 non-NULL, regardless of GNUTLS_INITSTAGE.
1931 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1932 an error. Set process slots as soon as we allocate them.
1933
1934 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1935
9c6c6f49
CY
19362011-10-27 Chong Yidong <cyd@gnu.org>
1937
9aba6043
SM
1938 * gnutls.c (emacs_gnutls_deinit): New function.
1939 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1940 (Fgnutls_deinit, Fgnutls_boot): Use it.
1941
1942 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1943 (deactivate_process): Call emacs_gnutls_deinit.
1944
657d08d3
JB
19452011-10-27 Juanma Barranquero <lekktu@gmail.com>
1946
1947 * image.c (x_create_x_image_and_pixmap):
1948 * w32.c (sys_rename, w32_delayed_load):
1949 * w32font.c (fill_in_logfont):
1950 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1951
5430d399
JB
19522011-10-26 Juanma Barranquero <lekktu@gmail.com>
1953
1954 * w32fns.c (w32_default_color_map): New function,
1955 extracted from Fw32_default_color_map.
a7ef684b 1956 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1957
fe0055fa
PE
19582011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1959
1960 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1961
e6346438
SM
19622011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1963
1964 * keyboard.c (test_undefined): New function (bug#9751).
1965 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1966
e112cc37
ET
19672011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1968
1969 * sysdep.c (init_sys_modes): Fix the check for the controlling
1970 terminal (Bug#6649).
1971
7b5d6677
EZ
19722011-10-20 Eli Zaretskii <eliz@gnu.org>
1973
1974 * dispextern.h (struct bidi_it): New member next_en_type.
1975
1976 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1977 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1978 current character, check also for next_en_type being WEAK_EN.
1979 (bidi_resolve_weak): Don't enter the expensive loop if the current
1980 position is before next_en_pos. Record the bidi type of the first
1981 non-ET, non-BN character we find, in addition to its position.
1982 (bidi_level_of_next_char): Invalidate next_en_type when
1983 next_en_pos is over-stepped.
1984
7da0b018
PE
19852011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1986
1987 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1988 * editfns.c: Rewrite current-time-zone so that it invokes
1989 the equivalent of (format-time-string "%Z") to get the time zone name.
1990 This fixes a bug when the time zone name contains characters that
1991 need converting from the system time locale to Emacs internal format.
1992 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1993 that patch fixed format-time-string to do the conversion, but
1994 I forgot to fix current-time-zone.
1995 (format_time_string): New function, containing most of
1996 what Fformat_time_string used to contain.
1997 (Fformat_time_string): Rewrite in terms of format_time_string.
1998 This doesn't change this function's behavior.
1999 (current-time-zone): Rewrite to use format_time_string.
2000 This fixes the bug reported by Michael Schierl in
2001 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2002 Jason Rumney's 2007-06-07 change worked around this bug, but
2003 didn't fix it.
2004 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2005
8547b010
EZ
20062011-10-19 Eli Zaretskii <eliz@gnu.org>
2007
2008 * xdisp.c (start_display): If the character at POS is displayed
2009 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2010 (try_window_reusing_current_matrix): If a line ends in a display
2011 vector or the next line starts in a display vector, continue
2012 redrawing the window even though the character position of
2013 start_row was reached.
8547b010
EZ
2014 (Bug#9771, part 2)
2015
4e948d15
CY
20162011-10-18 Chong Yidong <cyd@gnu.org>
2017
2018 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2019 with nobreak-char-display too.
2020
4787455f
EZ
20212011-10-18 Eli Zaretskii <eliz@gnu.org>
2022
2023 Fix part 3 of bug#9771.
2024 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2025 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2026 non-neutral characters if the current character is a paragraph
2027 separator (a.k.a. Newline). This avoids running the same
2028 expensive loop twice, once when we consume the preceding newline
2029 and the other time when the line actually needs to be displayed.
2030 Avoid the loop when we see neutrals on the base embedding level
2031 following a character whose directionality is the same as the
2032 paragraph's. This avoids running the expensive loop when a line
2033 ends in a long sequence of neutrals, like control characters.
2034 Add assertion against STRONG_AL type. Slightly rearrange code
2035 that determines the type of a neutral given the first non-neutral
2036 that follows it.
2037 (bidi_level_of_next_char): Set next_en_pos to zero when
2038 invalidating its info.
2039
2c91f553
EZ
20402011-10-17 Eli Zaretskii <eliz@gnu.org>
2041
2042 * xdisp.c (push_display_prop): Determine whether to record string
2043 or buffer position by IT->string, not by IT->method. Allow
2044 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2045 (move_it_vertically_backward): Don't look for character position
2046 immediately after the newline when in a continuation line.
2047 (Bug#9771, part 1)
2c91f553 2048
c7b08b0d
MR
20492011-10-15 Martin Rudalics <rudalics@gmx.at>
2050
2051 * window.c (coordinates_in_window): Rewrite and delabelize
2052 vertical border check. (Bug#5357) (Bug#9618)
2053
6b02f655
SM
20542011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2055
2056 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2057 errors in XSetWindowBorder (bug#9310).
2058
81d40c92
DA
20592011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2060
2061 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2062 avoid crash when xmalloc overrun checking is enabled.
2063
d4172c3b
EZ
20642011-10-13 Eli Zaretskii <eliz@gnu.org>
2065
2066 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2067 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2068 cursor motion with <left> and <right> arrow keys.
2069
2070 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2071 some callers set that themselves.
2072
b00eea75
EZ
20732011-10-12 Eli Zaretskii <eliz@gnu.org>
2074
2075 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2076 display string and the previous row comes from the same string and
2077 is empty. (Bug#9739) (Bug#9738)
2078
8fe012c4
SM
20792011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2080
2081 * doc.c (get_doc_string): Encode file name (bug#9735).
2082
0074aef2
EZ
20832011-10-12 Eli Zaretskii <eliz@gnu.org>
2084
79beb178
EZ
2085 * bidi.c (bidi_level_of_next_char):
2086 * xdisp.c (get_visually_first_element): Remove old incorrect
2087 comments regarding the Unicode Line Separator character.
2088
0074aef2
EZ
2089 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2090
6e4b3fbe
DA
20912011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2092
2093 * alloc.c (Fgc_status): Do not access beyond zombies array
2094 boundary if nzombies > MAX_ZOMBIES.
2095 * alloc.c (dump_zombies): Add missing format specifier.
2096
0324f3af
PE
20972011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2098
b5525cac
PE
2099 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2100 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2101
0324f3af
PE
2102 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2103 Some packages use them to denote characters with modifiers.
2104
e9b5f888
AS
21052011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2106
2107 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2108 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2109 matching a pp-number. Rename parameter var to var1.
2110
127827c0
SM
21112011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2112
2113 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2114
c8fd3bd0
GM
21152011-10-08 Glenn Morris <rgm@gnu.org>
2116
2117 * callint.c (Fcall_interactively): Give a more explicit error for the
2118 'c' case with a non-character input. (Bug#8479)
2119
352ec8ff
EZ
21202011-10-08 Eli Zaretskii <eliz@gnu.org>
2121
03669ccb
EZ
2122 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2123 lines.
7061c986
EZ
2124 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2125 lines that are hscrolled on the left.
03669ccb 2126
352ec8ff
EZ
2127 * dispnew.c (buffer_posn_from_coords): Account for a possible
2128 presence of header-line. (Bug#4426)
2129
a66cfb1c
SM
21302011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2131
6b02f655
SM
2132 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2133 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2134
7c5ee88e
PE
21352011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2136
2137 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2138 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2139 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2140 this makes Emacs dump core during garbage collection on rare
2141 occasions. sizeof is obviously inferior to offsetof here, so
2142 stick with offsetof.
2143 (GC_POINTER_ALIGNMENT): New macro.
2144 (mark_memory): Omit 3rd (offset) arg; caller changed.
2145 Don't assume EMACS_INT alignment is the same as pointer alignment.
2146
df1bbe5b
SM
21472011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2148
2149 * keyboard.c (read_key_sequence_remapped): New var.
2150 (read_key_sequence): Compute remapping in the right buffer.
2151 (command_loop_1): Use read_key_sequence's remapping directly.
2152
51553db6
SM
21532011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2154
32c1fffd
SM
2155 * dired.c (file_name_completion): Don't expand file name.
2156 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2157 before checking file name handler.
2158
51553db6
SM
2159 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2160 they've been requested explicitly (bug#9591).
2161
b6bd1599 21622011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2163
2164 * keymap.c (Fsingle_key_description): Use make_specified_string
2165 instead of build_string to build string from push_key_description.
2166 (Bug#5193)
2167
f701dc2a
PE
21682011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2169
4222c55d
PE
2170 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2171 This fixes a Y2038 bug on 64-bit hosts.
2172 * buffer.c (reset_buffer):
2173 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2174 (Fclear_buffer_auto_save_failure):
2175 Use 0, not -1, to represent an unset failure time, since time_t
2176 might not be signed.
2177
f701dc2a
PE
2178 Remove dependency on glibc malloc internals.
2179 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2180 Move back here from lisp.h, but with their new implementations.
2181 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2182 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2183 * charset.c (charset_table_init): New static var.
2184 (syms_of_charset): Use it instead of xmalloc. This removes a
2185 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2186 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2187 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2188 Move back to alloc.c.
2189 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2190 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2191
9ceebf39
JD
21922011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2193
2194 * nsterm.m (windowDidResize): Call x_set_window_size only when
2195 ns_in_resize is true. Otherwise set pixelwidth/height and
2196 call change_frame_size (Bug#9628).
2197
cb993c58
PE
21982011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2199
3930c88b
PE
2200 Port --enable-checking=all to Fedora 14 x86-64.
2201 * charset.c (syms_of_charset): Also account for glibc malloc's
2202 internal overhead when calculating the initial malloc maximum.
2203
cb993c58
PE
2204 Port --enable-checking=all to Fedora 14 x86.
2205 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2206 Move to lisp.h.
2207 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2208 (overrun_check_realloc, overrun_check_free):
2209 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2210 That way, xmalloc returns a properly-aligned pointer even if
2211 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2212 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2213 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2214 into account when calculating the initial malloc maximum.
2215 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2216 Move here from alloc.c, so that charset.c can use it too.
2217 Properly align; the old code wasn't right for common 32-bit hosts
2218 when configured with --enable-checking=all.
2219 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2220 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2221
31bed486
EZ
22222011-09-29 Eli Zaretskii <eliz@gnu.org>
2223
04c70788 2224 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2225 use EDOM.
2226
fbcaa2f3
EZ
22272011-09-28 Eli Zaretskii <eliz@gnu.org>
2228
2229 * xdisp.c (compute_display_string_end): If there's no display
2230 string at CHARPOS, return -1.
2231
2232 * bidi.c (bidi_fetch_char): When compute_display_string_end
2233 returns a negative value, treat the character as a normal
2234 character not covered by a display string. (Bug#9624)
2235
a239d4e9
JB
22362011-09-28 Juanma Barranquero <lekktu@gmail.com>
2237
2238 * lread.c (Fread_from_string): Fix typo in docstring.
2239
88652fd5
EZ
22402011-09-27 Eli Zaretskii <eliz@gnu.org>
2241
2242 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2243 newline, reseat the iterator instead of bidi-iterating there one
2244 character at a time. (Bug#9610)
32c1fffd
SM
2245 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2246 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2247
ed497dd4
AS
22482011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2249
2250 * lread.c (readevalloop): Use correct code for NBSP.
2251 (read1): Likewise. (Bug#9608)
2252
b2bf61aa
MA
22532011-09-25 Michael Albinus <michael.albinus@gmx.de>
2254
2255 * dbusbind.c (Fdbus_register_signal): When service is not
2256 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2257
32bbb17c
GM
22582011-09-25 Glenn Morris <rgm@gnu.org>
2259
2260 * buffer.c (truncate-lines): Doc fix.
2261
94e0933e
CY
22622011-09-24 Chong Yidong <cyd@stupidchicken.com>
2263
2264 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2265 (Fset_window_next_buffers): Doc fix.
2266
cddde921
GM
22672011-09-24 Glenn Morris <rgm@gnu.org>
2268
2269 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2270
1260aef1
PE
22712011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2272
25b4bfa0
PE
2273 Fix minor problems found by static checking.
2274 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2275 * indent.c (Fvertical_motion): Fix == vs = typo.
2276
e3cbd34b
EZ
22772011-09-24 Eli Zaretskii <eliz@gnu.org>
2278
a66cfb1c
SM
2279 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2280 Default value is now t. Doc fix.
6bf7006f 2281
e3cbd34b 2282 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2283 logic when moving up, not only when moving down. Fix the
e3cbd34b 2284 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2285 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2286
2287 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2288 CHARPOS is covered by a display string which includes newlines.
2289 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2290 is covered by a display string with embedded newlines.
2291
a3de0cbd
MA
22922011-09-24 Michael Albinus <michael.albinus@gmx.de>
2293
2294 * dbusbind.c (Fdbus_register_signal): Add match rule to
2295 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2296 (Fdbus_register_method, Vdbus_registered_objects_table):
2297 Fix docstring.
a3de0cbd 2298
b260039d
JM
22992011-09-24 Jim Meyering <meyering@redhat.com>
2300
32c1fffd 2301 do not ignore write error for any output size
b260039d
JM
2302 The previous change was incomplete.
2303 While it makes emacs --batch detect the vast majority of stdout
2304 write failures, errors were still ignored whenever the output size is
2305 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2306 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2307 && echo FAIL: ignored write error
2308 FAIL: ignored write error
2309 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2310 && echo FAIL: ignored write error
2311 FAIL: ignored write error
2312 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2313
8eca8a7c
AS
23142011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2315
2316 * emacs.c (Fkill_emacs): In noninteractive mode exit
2317 non-successfully if a write error occurred on stdout. (Bug#9574)
2318
3341db62
EZ
23192011-09-21 Eli Zaretskii <eliz@gnu.org>
2320
2321 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2322 the xassert test.
2323
2324 * dispextern.h (struct it): Update the comment documenting what
2325 can it->OBJECT be.
2326
8c203dbf
EZ
23272011-09-20 Eli Zaretskii <eliz@gnu.org>
2328
2329 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2330 a display string, extend search for cursor position to end of row.
2331 (find_row_edges): If the row ends in a newline from a display
2332 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2333 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2334 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2335 non-empty line. Fixes confusing cursor motion with arrow keys at
2336 the beginning of a line that starts with whitespace.
8c203dbf 2337
a4824228
LMI
23382011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2339
2340 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2341 (bug#9493).
2342
33ed493b
CY
23432011-09-18 Chong Yidong <cyd@stupidchicken.com>
2344
2345 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2346 boolean (Bug#9154).
2347
56cd55c8
EZ
23482011-09-18 Eli Zaretskii <eliz@gnu.org>
2349
2350 * xdisp.c (display_line): Record maximum and minimum buffer
2351 positions even if no glyphs were produced (e.g., by a zero-width
2352 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2353 buffer positions that will be removed from the glyph row because
2354 they don't fit.
c02dcedf
EZ
2355 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2356 column is beyond frame width: don't subtract 1 "pixel" when
2357 computing width of the stretch.
3e62b7e0
EZ
2358 (reseat_at_next_visible_line_start): Undo the change made on
2359 2011-09-17 that saved paragraph information and restored it after
2360 the call to `reseat'. (Bug#9545)
56cd55c8 2361
5ed99d36 23622011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2363
2364 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2365 and turn window cursor on if cleared (Bug#9415).
2366
5ed99d36 23672011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2368
2369 * search.c (boyer_moore): Take unibyte characters from pattern
2370 literally. (Bug#9458)
2371
9bade7b2
EZ
23722011-09-18 Eli Zaretskii <eliz@gnu.org>
2373
2374 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2375
e5e9d610
PE
23762011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2377
87e4427a
PE
2378 Fix minor problem found by static checking.
2379 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2380 initialized, to pacify gcc -Wuninitialized.
2381
e5e9d610
PE
2382 * fileio.c: Report proper errno when syscall falls.
2383 (Finsert_file_contents): Save and restore errno,
2384 so that report_file_error outputs the correct diagnostic.
2385 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2386
a1674f0b
EZ
23872011-09-18 Eli Zaretskii <eliz@gnu.org>
2388
2389 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2390
fbfb6dd4
EZ
23912011-09-17 Eli Zaretskii <eliz@gnu.org>
2392
2393 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2394 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2395
bb187662
EZ
23962011-09-17 Eli Zaretskii <eliz@gnu.org>
2397
1137e8b8 2398 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2399 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2400
2401 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2402 (bidi_find_paragraph_start): Search back for paragraph beginning
2403 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2404 (bidi_move_to_visually_next): Only trigger paragraph-related
2405 computations when the last character is a newline or at EOB, not
2406 just any NEUTRAL_B. (Bug#9470)
2407
bb187662
EZ
2408 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2409 truncated lines if point is covered by a display string. (Bug#9524)
2410
2e621251
PE
24112011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2412
2413 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2414 (cons_to_x_long): New function.
2415 (lisp_data_to_selection_data): Use it. Correct the test for
2416 short-versus-long data; it was negated. Break out of vector
2417 loop, for efficiency, when a long datum is discovered.
2418
91a15bc6
SM
24192011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2420
2421 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2422
b41c3a35
EZ
24232011-09-16 Eli Zaretskii <eliz@gnu.org>
2424
2425 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2426 GCC PR/17406) by declaring this function with external scope.
2427
7812ba2d
PE
24282011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2429
2430 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2431 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2432
cf7edc2a
AS
24332011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2434
2435 * editfns.c (Fformat): Correctly handle text properties on "%%".
2436
bd01620e
EZ
24372011-09-15 Eli Zaretskii <eliz@gnu.org>
2438
2439 * xterm.c (x_draw_composite_glyph_string_foreground):
2440 * w32term.c (x_draw_composite_glyph_string_foreground):
2441 * term.c (encode_terminal_code):
2442 * composite.c (composition_update_it, get_composition_id):
2443 * xdisp.c (get_next_display_element)
2444 (fill_composite_glyph_string): Add comments about special meaning
2445 of TAB characters in a composition.
2446
a02719a3
PE
24472011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2448
2449 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2450 This occurs when processing a multibyte format.
2451 Problem reported by Wolfgang Jenker.
a02719a3 2452
72589a3c
JB
24532011-09-15 Johan Bockgård <bojohan@gnu.org>
2454
2455 * xdisp.c (try_cursor_movement): Only check for exact match if
2456 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2457
1c14176c
PE
24582011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2459
2460 Remove unused external symbols.
2461 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2462 * xdisp.c (calc_pixel_width_or_height): Now static.
2463 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2464 * indent.c (check_display_width):
2465 * w32term.c: Fix comment to match code.
2466 * xterm.c, xterm.h (x_catching_errors): Remove.
2467
d2eea5b5
PE
24682011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2469
2470 * xselect.c: Use signed conversions more consistently (Bug#9498).
2471 (selection_data_to_lisp_data): Assume incoming selection data are
2472 signed integers, not unsigned. This is to be consistent with
2473 outgoing selection data, which was modified to use signed integers
2474 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2475 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2476 expects long, not unsigned long.
2477
46888499
EZ
24782011-09-14 Eli Zaretskii <eliz@gnu.org>
2479
2480 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2481 computation of loop end. Reported by Johan Bockgård
2482 <bojohan@gnu.org>.
2483
ef8ef9fb
CY
24842011-09-13 Chong Yidong <cyd@stupidchicken.com>
2485
2486 * frame.c (Fother_visible_frames_p): Function deleted.
2487
fa819fed
EZ
24882011-09-12 Eli Zaretskii <eliz@gnu.org>
2489
2490 * indent.c (compute_motion): Process display vector front to back
2491 rather than the other way around. (Bug#2496)
2492
2ba8e008
SM
24932011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2494
2495 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2496
20f53c69
CY
24972011-09-11 Chong Yidong <cyd@stupidchicken.com>
2498
2499 * minibuf.c (Fread_from_minibuffer): Doc fix.
2500
d562d7a4
EZ
25012011-09-11 Eli Zaretskii <eliz@gnu.org>
2502
2503 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2504 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2505
1c4d7f3d
LMI
25062011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2507
2508 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2509 value for non-existent files.
2510
b885bf36
EZ
25112011-09-11 Eli Zaretskii <eliz@gnu.org>
2512
2513 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2514 set its "size" to -1. This will set the modtime_size field of
2515 the corresponding buffer to -1, which is what
2516 verify-visited-file-modtime expects for files that do not exist.
2517 (Bug#9139)
2518
6612f0bf
PE
25192011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2520
2521 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2522 here ...
2523 * lisp.h: ... from here. push_key_description is no longer
2524 defined in keyboard.c, so its declaration should not be in
2525 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2526 logically belongs with push_key_description.
2527
dfb3f755
PE
25282011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2529
2530 * buffer.h: Include <sys/types.h> instead of <time.h>.
2531 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2532 Problem reported by Herbert J. Skuhra.
2533
3134906c
LMI
25342011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2535
2536 * xml.c (parse_region): Make the parsing work for
2537 non-comment-starting XML files again (bug#9144).
2538
8d903f4e
AS
25392011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2540
2541 * image.c (gif_load): Fix calculation of bottom and right corner.
2542 (Bug#9468)
2543
80ad64f4
EZ
25442011-09-10 Eli Zaretskii <eliz@gnu.org>
2545
2546 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2547 redisplay in small windows.
2548
208a048d
EZ
25492011-09-09 Eli Zaretskii <eliz@gnu.org>
2550
2551 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2552
9b1c252e
MR
25532011-09-08 Martin Rudalics <rudalics@gmx.at>
2554
2555 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2556 Operate on live windows only.
2557
2949f33b
JB
25582011-09-08 Juanma Barranquero <lekktu@gmail.com>
2559
2560 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2561
e08dcafd
EZ
25622011-09-07 Eli Zaretskii <eliz@gnu.org>
2563
2564 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2565 only under bidi iteration.
2566
115b96bd
JD
25672011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2568
2569 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2570
c8199d0f
PE
25712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2572
2573 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2574 Without this fix, the command to link temacs failed due to an
2575 undefined symbol __builtin_isnan. This is because
2576 /usr/include/iso/math_c99.h #defines isnan(x) to
2577 __builtin_isnan(x), but the bundled gcc, which identifies itself
2578 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2579 a __builtin_isnan.
2580 * floatfns.c (isnan): #undef, and then #define to a clone of
2581 what's in data.c.
2582 (Fisnan): Always define, since it's always available now.
2583 (syms_of_floatfns): Always define isnan at the Lisp level.
2584
e39b275c 25852011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2586
2587 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2588
b2db44d9 25892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2590
f4af5137 2591 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2592 The previous code assumed that file offsets (off_t values) fit in
2593 EMACS_INT variables, which is not true on typical 32-bit hosts.
2594 The code messed up by falsely reporting buffer overflow in cases
2595 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2596 when "big" contains more than 2**29 bytes, even though this
2597 inserts just one byte and does not overflow the buffer.
2598 (Finsert_file_contents): Store file offsets as off_t
2599 values, not as EMACS_INT values. Check for overflow when
2600 converting between EMACS_INT and off_t. When checking for
2601 buffer overflow or for overlap, take the offsets into account.
2602 Don't use EMACS_INT for small values where int suffices.
2603 When checking for overlap, fix a typo: ZV was used where
2604 ZV_BYTE was intended.
2605 (Fwrite_region): Don't assume off_t fits into 'long'.
2606 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2607
ecfc0a49
MA
26082011-09-05 Michael Albinus <michael.albinus@gmx.de>
2609
2610 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2611
6511acf2 26122011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2613
0999621a 2614 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2615
2616 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2617 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2618 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2619 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2620 (modify_event_symbol): Do not assume that the length of
2621 name_alist_or_stem is safe to alloca and fits in int.
2622 (Fexecute_extended_command): Likewise for function name and binding.
2623 (Frecursion_depth): Wrap around reliably on integer overflow.
2624 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2625 since some callers pass EMACS_INT values.
2626 (Fsingle_key_description): Don't crash if symbol name contains more
2627 than MAX_ALLOCA bytes.
2628 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2629 (get_minibuffer): Arg is now EMACS_INT, not int.
2630 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2631 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2632 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2633
2be7d702
PE
2634 * dbusbind.c (signature_cat): New function.
2635 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2636 Do not overrun buffer; instead, report string overflow.
2637
9d1df220
PE
2638 * dispnew.c (add_window_display_history): Don't overrun buffer.
2639 Truncate instead; this is OK since it's just a log.
2640
33ef5c64
PE
2641 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2642 even if the time zone offset is outlandishly large.
2643 Don't mishandle offset == INT_MIN.
2644
66c6fdd5
PE
2645 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2646 when creating daemon; the previous buffer-overflow check was incorrect.
2647
d749b01b
PE
2648 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2649 which has the guts of the old verror function.
2650
b5cd1905
PE
2651 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2652 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2653
6e1a67fb
PE
2654 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2655 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2656 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2657 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2658 length of string rather than counting it via multiple sprintfs;
2659 that's simpler and more reliable.
c21721cc
PE
2660 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2661 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2662 sprintf, in case result does not fit in int.
2663
c57b67fc
PE
2664 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2665 (fontset_from_font): Print it.
2666
8a401434
PE
2667 * frame.c (tty_frame_count): Now printmax_t, not int.
2668 (make_terminal_frame, set_term_frame_name): Print it.
2669 (x_report_frame_params): In X, window IDs are unsigned long,
2670 not signed long, so print them as unsigned.
2671 (validate_x_resource_name): Check for implausibly long names,
2672 and don't assume name length fits in 'int'.
2673 (x_get_resource_string): Don't blindly alloca invocation name;
2674 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2675 not fit in int.
2676
6e1a67fb
PE
2677 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2678 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2679 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2680
0df02bf3
PE
2681 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2682 Use esprintf, not sprintf, in case result does not fit in int.
2683
48e30793
PE
2684 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2685 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2686 it as a large positive number.
2687 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2688 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2689
a66ff6d8
PE
2690 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2691 in case result does not fit in int.
2692
aca216ff
PE
2693 * print.c (float_to_string): Detect width overflow more reliably.
2694 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2695 buffer overrun. Don't assume list length fits in 'int'. Treat
2696 print length of 0 as 0, not as infinity; to be consistent with other
2697 uses of print length in this function. Don't overflow print length
2698 index. Don't assume hash table size fits in 'long', or that
2699 vectorlike size fits in 'unsigned long'.
2700
31c286f7
PE
2701 * process.c (make_process): Use printmax_t, not int, to format
2702 process-name gensyms.
2703
55e5faa1
PE
2704 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2705
80f2e268
PE
2706 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2707 to avoid potential buffer overrun.
2708
670741ab
PE
2709 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2710 if X resource line is longer than 512 bytes.
2711
b7163a50
PE
2712 * xfns.c (x_window): Make sprintf buffer a bit bigger
2713 to avoid potential buffer overrun.
2714
ae58ff1f
PE
2715 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2716
c43c8a6a
PE
2717 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2718
3f8236f4
PE
27192011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2720
53e9fe90 2721 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2722 Without these, Emacs silently mishandles large integers sometimes.
2723 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2724 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2725
6511acf2
PE
2726 * xdisp.c (try_window_id): Check Emacs fixnum range before
2727 converting to 'int'.
806add1d 2728
6511acf2 2729 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2730 Check that an Emacs fixnum is in range before assigning it to 'int'.
2731 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2732 values converted from Emacs fixnums.
2733 (Frecenter): Don't wrap around a line count if it is out of 'int'
2734 range; instead, treat it as an extreme value.
2735 (Fset_window_configuration, compare_window_configurations):
2736 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2737
6511acf2
PE
2738 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2739 that can exceed INT_MAX. Check that EMACS_INT value is in range
2740 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2741 (match_limit): Don't assume that a fixnum can fit in 'int'.
2742
6511acf2 2743 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2744 exceed INT_MAX.
2745
6511acf2 2746 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2747 (Fvertical_motion): Don't wrap around LINES values that don't fit
2748 in 'int'. Instead, treat them as extreme values. This is good
2749 enough for windows, which can't have more than INT_MAX lines anyway.
2750
fcb901a7
LMI
27512011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2752
0f2f6b6d
LMI
2753 * Require libxml/parser.h to avoid compilation warning.
2754
fcb901a7
LMI
2755 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2756
2757 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2758 since this reportedly can destroy thread storage.
2759
6e20a0d4
CY
27602011-08-30 Chong Yidong <cyd@stupidchicken.com>
2761
2762 * syntax.c (find_defun_start): Update all cache variables if
2763 exiting early (Bug#9401).
2764
148ae00e
EZ
27652011-08-30 Eli Zaretskii <eliz@gnu.org>
2766
f6cfbd8f
EZ
2767 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2768
148ae00e
EZ
2769 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2770 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2771 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2772
2773 * term.c (tty_append_glyph): New function.
2774 (produce_stretch_glyph): Static function and its prototype deleted.
2775
a66cfb1c
SM
2776 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2777 Add prototypes.
148ae00e 2778
c4a07a4c
PE
27792011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2780
2781 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2782 when checking :margin (Bug#9390).
2783 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2784 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2785 so that the name doesn't mislead. All uses changed.
2786
6bc8cd65
JB
27872011-08-28 Johan Bockgård <bojohan@gnu.org>
2788
2789 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2790 set_tty_hooks.
2791
dca4927e
EZ
27922011-08-27 Eli Zaretskii <eliz@gnu.org>
2793
2794 * xdisp.c (move_it_to): Don't bail out early when reaching
2795 position beyond to_charpos, if we are scanning backwards.
2796 (move_it_vertically_backward): When DY == 0, make sure we get to
2797 the first character in the line after the newline.
2798
f2cad773
PE
27992011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2800
2801 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2802 (ccl_driver): Do not generate an out-of-range pointer.
2803 (Fccl_execute_on_string): Remove unnecessary check for
2804 integer overflow, noted by Stefan Monnier in
2805 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2806 Remove a FIXME that didn't need fixing.
2807 Simplify the newly-introduced buffer reallocation code.
2808
0cae2cdb
JB
28092011-08-27 Juanma Barranquero <lekktu@gmail.com>
2810
2811 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2812
5fc295a4 28132011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2814
70c60eb2 2815 Integer and memory overflow issues (Bug#9196).
726e0ab1 2816
d31850da
PE
2817 * doc.c (get_doc_string): Rework so that
2818 get_doc_string_buffer_size is the actual buffer size, rather than
2819 being 1 less than the actual buffer size; this makes xpalloc more
2820 convenient.
2821
a69fbedb
PE
2822 * image.c (x_allocate_bitmap_record, cache_image):
2823 * xselect.c (Fx_register_dnd_atom):
2824 Simplify previous changes by using xpalloc.
2825
fe5c5d37
PE
2826 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2827 since either will do and ptrdiff_t is convenient with xpalloc.
2828
0065d054
PE
2829 * charset.c (charset_table_size)
2830 (struct charset_sort_data.priority): Now ptrdiff_t.
2831 (charset_compare): Don't overflow if priorities differ greatly.
2832 (Fsort_charsets): Don't assume list length fits in int.
2833 Check for size-calculation overflow when allocating sort data.
2834 (syms_of_charset): Allocate an initial charset table that is
2835 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2836
2837 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2838
2839 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2840 The actual value is always <= INT_MAX, and leaving it unsigned made
2841 overflow checking harder.
2842
2843 * dispextern.h (struct glyph_matrix.rows_allocated)
2844 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2845 with xpalloc. The values are still always <= INT_MAX.
2846
2847 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2848
2849 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2850 (SAFE_NALLOCA): New macro.
2851
2852 * region-cache.c (struct boundary.pos, find_cache_boundary)
2853 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2854 (set_cache_region, invalidate_region_cache)
2855 (revalidate_region_cache, know_region_cache, region_cache_forward)
2856 (region_cache_backward, pp_cache):
2857 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2858 so that ptrdiff_t * can be passed to xpalloc.
2859 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2860 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2861 (pp_cache): Don't assume cache_len fits in int.
2862 * region-cache.h: Adjust extern decls to match.
2863
2864 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2865 EMACS_INT, since either will do, for xpalloc.
2866
2867 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2868 (xnmalloc, xnrealloc, xpalloc): New functions.
2869
726e0ab1
PE
2870 * bidi.c (bidi_shelve_header_size): New constant.
2871 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2872 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2873
51f30bc5 2874 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2875 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2876 (overlay_strings):
2877 Don't update size of array until after memory allocation succeeds,
2878 because xmalloc/xrealloc may not return.
0065d054
PE
2879 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2880 now that we have proper integer overflow checking.
2881 (record_overlay_string, overlay_strings): Catch overflows when
2882 calculating size of overlay_str_buf.
726e0ab1 2883
0065d054
PE
2884 * callproc.c (Fcall_process): Check for size overflow when
2885 calculating size of args2.
2886 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2887 Normally we prefer signed values, but sticking with ptrdiff_t would
2888 require adding more-complicated checks.
726e0ab1
PE
2889
2890 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2891 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2892 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2893 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2894
2895 * character.c (Fstring): Check for size-calculation overflow.
2896
2897 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2898 unnecessary integer overflow. Check for size overflow.
2899 (encode_coding_object): Don't update size until xmalloc succeeds.
2900
2901 * composite.c (get_composition_id): Check for overflow in glyph
2902 length calculations.
2903
2904 Integer and memory overflow fixes for display code.
2905 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2906 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2907 (scrolling_window): Check for overflow in size calculations.
2908 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2909 Don't assume glyph table len fits in int.
2910 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2911 (row_table_size): Now ptrdiff_t, not int.
2912 (scrolling_window): Avoid overflow in size calculations.
2913 Don't update size until allocation succeeds.
2914 * fns.c (concat): Check for overflow in size calculations.
2915 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2916 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2917 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2918
2919 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2920 (get_doc_string): Check for size calculation overflow.
2921 Don't update size until allocation succeeds.
2922 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2923 EMACS_INT, where ptrdiff_t will do.
2924 (Fsubstitute_command_keys): Check for string overflow.
2925
2926 * editfns.c (set_time_zone_rule): Don't assume environment length
2927 fits in int.
2928 (message_length): Now ptrdiff_t, not int.
2929 (Fmessage_box): Don't update size until allocation succeeds.
2930 Don't assume message length fits in int.
2931 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2932
0065d054
PE
2933 * emacs.c (main): Do not reallocate argv, since there is a null at
2934 the end that can be overwritten, and this way there's no need to
2935 worry about size-calculation overflow.
2936 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2937
2938 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2939 alloc succeeds.
2940 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2941
2942 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2943 (x_set_scroll_bar_width, x_figure_window_size):
2944 Check for integer overflow.
2945 (x_set_alpha): Do not assume XINT fits in int.
2946
2947 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2948 This is for the members text_lines, text_cols, total_lines, total_cols,
2949 where the system imposes an 'int' limit.
2950
2951 * fringe.c (Fdefine_fringe_bitmap):
2952 Don't update size until alloc works.
2953
2954 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2955 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2956
2957 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2958 Check for size-calculation overflow.
2959 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2960 do, as we prefer signed integers.
2961 (id_to_widget.max_size, id_to_widget.used)
2962 (xg_store_widget_in_map, xg_remove_widget_from_map)
2963 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2964 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2965 Use and return ptrdiff_t, not int.
2966 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2967 * gtkutil.h: Change prototypes to match the above.
2968
2969 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2970 are duplicate now that they've been promoted to lisp.h.
2971 (x_allocate_bitmap_record, x_alloc_image_color)
2972 (make_image_cache, cache_image, xpm_load):
2973 Don't update size until alloc is done.
2974 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2975 (x_detect_edges):
3256efce 2976 Check for size calculation overflow.
726e0ab1
PE
2977 (ct_colors_allocated_max): New constant.
2978 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2979 overflow.
3256efce 2980
726e0ab1
PE
2981 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2982 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2983 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2984 Use ptrdiff_t, not int, to count maps.
2985 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2986 calculations. Don't update size until allocation succeeds.
2987 Redo calculations to avoid overflow.
726e0ab1
PE
2988 * keyboard.h: Change prototypes to match the above.
2989
2990 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2991 to count maps.
2992 (current_minor_maps): Check for size calculation overflow.
2993 * keymap.h: Change prototypes to match the above.
2994
2995 * lread.c (read1, init_obarray): Don't update size until alloc done.
2996
2997 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2998 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2999
726e0ab1
PE
3000 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3001 Now ptrdiff_t, not int.
3002 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3003 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3004
3005 * process.c (Fnetwork_interface_list): Check for overflow
3006 in size calculation.
3007
3008 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3009
3010 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3011 overflow. Don't bother calling xmalloc when xrealloc will do.
3012
3013 * search.c (Freplace_match): Check for size calculation overflow.
3014 (Fset_match_data): Don't assume list lengths fit in 'int'.
3015
3016 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3017 for command line length. Do not attempt to address one before the
3018 beginning of an array, as that's not portable.
3019
3020 * term.c (max_frame_lines): Remove; unused.
3021 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3022 not int.
3023 (encode_terminal_code, calculate_costs): Check for size
3024 calculation overflow.
3025 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3026 table lengths and related sizes. Don't update size until alloc
3027 done. Redo calculations to avoid overflow.
3028 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3029
3030 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3031 subtracting pointers.
3032 (gobble_line): Check for overflow more carefully. Don't update size
3033 until alloc done.
3034
3035 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3036 Don't update size until alloc done.
3037 Redo size calculations to avoid overflow.
3038 Check for size calculation overflow.
0065d054 3039 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3040
3041 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3042 Use ptrdiff_t, not int, for sizes.
3043 (store_mode_line_noprop_char): Don't update size until alloc done.
3044
0065d054
PE
3045 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3046 Use ptrdiff_t, not int, for sizes.
3047 (Finternal_make_lisp_face, cache_face):
3048 Check for size calculation overflow.
3049 (cache_face): Treat size calculation overflows as if they were
3050 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3051
3052 * xfns.c (x_encode_text, x_set_name_internal)
3053 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3054 sizes, since they can exceed INT_MAX in size. Check for size
3055 calculation overflow.
3056
0065d054
PE
3057 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3058 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3059 Don't update size until alloc done.
3060
0065d054 3061 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3062 as sprintf is limited to int lengths.
1d526e2f 3063
252c5ee1
PE
3064 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3065 (X_LONG_MIN): New macros.
864d7ce7
PE
3066 Use them to make the following changes clearer.
3067 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3068 This change doesn't affect the value now, but it may help remind
3069 future maintainers not to raise the value too much later.
3070 (SELECTION_QUANTUM): Remove, replacing with ...
3071 (selection_quantum): ... new function, which avoids overflow.
3072 All uses changed.
3073 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3074 assumption that selection length fits in 'int'.
3075 (x_reply_selection_request, x_handle_selection_request)
3076 (x_get_window_property, receive_incremental_selection)
3077 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3078 (lisp_data_to_selection_data, clean_local_selection_data):
3079 Use ptrdiff_t, not int, to record length of selection.
3080 (x_reply_selection_request, x_get_window_property)
3081 (receive_incremental_selection, x_property_data_to_lisp):
3082 Redo calculations to avoid overflow.
3083 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3084 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3085 something.
3086 (x_get_window_property, receive_incremental_selection)
3087 (lisp_data_to_selection_data, x_property_data_to_lisp):
3088 Check for size-calculation overflow.
3089 (x_get_window_property, receive_incremental_selection)
3090 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3091 Don't store size until memory allocation succeeds.
3092 (x_get_window_property): Plug memory leak on memory exhaustion.
3093 Don't double-block input; malloc is safe here. Don't assume 2**34
3094 - 4 fits in unsigned long. Add an xassert to check
3095 XGetWindowProperty overflow. Be more careful about overflow
3096 calculations, and distinguish size from memory overflow better.
3097 (receive_incremental_selection): When tracing, don't assume
3098 unsigned int is less than INT_MAX.
3099 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3100 harmful) conversions of unsigned short to int.
3101 (lisp_data_to_selection_data): Don't assume that integers
3102 in the range -65535 through -1 fit in an X unsigned short.
3103 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3104 result parameters unless successful. Rely on cons_to_unsigned
3105 to report problems with elements; the old code wasn't right anyway.
3106 (x_check_property_data): Check for int overflow; we cannot use
3107 a wider type due to X limits.
3108 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3109
726e0ab1 3110 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3111
0065d054
PE
3112 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3113 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3114 (x_color_cells): Don't store size until memory allocation succeeds.
3115 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3116 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3117 (x_term_init): Don't assume length fits in int (sprintf is limited
3118 to int size).
bc18e09d 3119
ebfa62c0
PE
3120 Use ptrdiff_t for composition IDs.
3121 * character.c (lisp_string_width):
3122 * composite.c (composition_table_size, n_compositions)
3123 (get_composition_id, composition_gstring_from_id):
3124 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3125 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3126 * window.c (Frecenter):
3127 Use ptrdiff_t, not int, for composition IDs.
3128 * composite.c (get_composition_id): Check for integer overflow.
3129 * composite.h: Adjust prototypes to match the above changes.
3130
d3411f89
PE
3131 Use ptrdiff_t for hash table indexes.
3132 * category.c (hash_get_category_set):
3133 * ccl.c (ccl_driver):
3134 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3135 * coding.c (coding_system_charset_list, detect_coding_system):
3136 * coding.h (struct coding_system.id):
3137 * composite.c (get_composition_id, gstring_lookup_cache):
3138 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3139 * image.c (xpm_get_color_table_h):
3140 * lisp.h (hash_lookup, hash_put):
3141 * minibuf.c (Ftest_completion):
3142 Use ptrdiff_t for hash table indexes, not int (which is too
3143 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3144 32-bit --with-wide-int hosts).
3145
e097a6fa
PE
3146 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3147 Add a FIXME comment about memory leaks.
3148 (syms_of_charset): Don't assume xmalloc returns.
3149
5637687f
PE
3150 Don't assume that stated character widths fit in int.
3151 * character.c (Fchar_width, c_string_width, lisp_string_width):
3152 * character.h (CHAR_WIDTH):
3153 * indent.c (MULTIBYTE_BYTES_WIDTH):
3154 Use sanitize_char_width to avoid undefined and/or bad behavior
3155 with outlandish widths.
a66cfb1c 3156 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3157 now that we have two such functions. All uses changed.
3158 (sanitize_char_width): New inline function.
3159
a2271ba2
PE
3160 Don't assume that tab-width fits in int.
3161 * character.h (sanitize_width): New inline function.
3162 (SANE_TAB_WIDTH): New macro.
3163 (ASCII_CHAR_WIDTH): Use it.
3164 * indent.c (sane_tab_width): Remove. All uses replaced by
3165 SANE_TAB_WIDTH (current_buffer).
3166 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3167
18c52557
PE
3168 * fileio.c: Integer overflow issues with file modes.
3169 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3170
caeeedc1
PE
3171 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3172 Remove unreachable code.
3173 (read_hex, load_charset_map_from_file): Check for integer overflow.
3174
6df6ae42 3175 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3176 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3177 (x_send_scroll_bar_event): Likewise. Check that the size does not
3178 exceed limits imposed by XClientMessageEvent, as well as the usual
3179 ptrdiff_t and size_t limits.
3180
b13995db
PE
3181 * keyboard.c: Overflow, signedness and related fixes.
3182 (make_lispy_movement): Use same integer type in forward decl
3183 that is used in the definition.
3184 (read_key_sequence, keyremap_step):
3185 Change bufsize argument back to int, undoing my 2011-03-30 change.
3186 We prefer signed types, and int is wide enough here.
3187 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3188 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3189 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3190 length, not size_t. Use ptrdiff_t for index, not int.
3191 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3192 possibility of integer overflow.
3193
13464394
PE
3194 Overflow, signedness and related fixes for images.
3195
3196 * dispextern.h (struct it.stack[0].u.image.image_id)
3197 (struct_it.image_id, struct image.id, struct image_cache.size)
3198 (struct image_cache.used, struct image_cache.ref_count):
3199 * gtkutil.c (update_frame_tool_bar):
3200 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3201 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3202 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3203 * nsmenu.m (update_frame_tool_bar):
3204 * xdisp.c (calc_pixel_width_or_height):
3205 * xfns.c (image_cache_refcount):
3206 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3207 on typical 64-bit hosts.
3208
3209 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3210 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3211 Omit unnecessary casts to int.
3212 (parse_image_spec): Check that integers fall into 'int' range
3213 when the callers expect that.
3214 (image_ascent): Redo ascent calculation to avoid int overflow.
3215 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3216 (lookup_image): Remove unnecessary tests.
3217 (xbm_image_p): Locals are now of int, not EMACS_INT,
3218 since parse_image_check makes sure they fit into int.
3219 (png_load, gif_load, svg_load_image):
3220 Prefer int to unsigned where either will do.
3221 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3222 old tiff_error_handler and tiff_warning_handler.
3223 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3224 stack buffer overflows. It uses only the features of vsnprintf
3225 that are common to both POSIX and native Microsoft.
3226 (tiff_error_handler, tiff_warning_handler): Use it.
3227 (tiff_load, gif_load, imagemagick_load_image):
3228 Don't assume :index value fits in 'int'.
3229 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3230 (imagemagick_load_image): Check that crop parameters fit into
3231 the integer types that MagickCropImage accepts. Don't assume
3232 Vimagemagick_render_type has a nonnegative value. Don't assume
3233 size_t fits in 'long'.
3234 (gs_load): Use printmax_t to print the widest integers possible.
3235 Check for integer overflow when computing image height and width.
3236
c11821d4
EZ
32372011-08-26 Eli Zaretskii <eliz@gnu.org>
3238
3239 * xdisp.c (redisplay_window): Don't force window start if point
3240 will be invisible in the resulting window. (Bug#9324)
3241
0c95fcf7
EZ
32422011-08-25 Eli Zaretskii <eliz@gnu.org>
3243
3244 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3245 the display spec is of the form `(space ...)'.
3246 (handle_display_spec): Return the value returned by
3247 handle_single_display_spec, not just 1 or zero.
3248 (handle_single_display_spec): If the display spec is of the form
3249 `(space ...)', and specifies display in the text area, return 2
3250 rather than 1.
fee65a97 3251 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3252 accurately, and prefer exact match for point under bidi.
3253 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3254
3255 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3256 into disp_prop; all users changed.
3257
3258 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3259 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3260 for the text covered by the display property.
3261
e4ed06f1
CY
32622011-08-25 Chong Yidong <cyd@stupidchicken.com>
3263
3264 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3265 Change return value to nil.
3266 (Frecord_buffer): Delete unused function.
3267
f67cdd7f
EZ
32682011-08-24 Eli Zaretskii <eliz@gnu.org>
3269
5980d4c6
EZ
3270 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3271 buffers, return left-to-right.
8610fe8b
EZ
3272 (set_cursor_from_row): Consider candidate row a win if its glyph
3273 represents a newline and point is on that newline. Fixes cursor
3274 positioning on the newline at EOL of R2L text within L2R
3275 paragraph, and vice versa.
3276 (try_cursor_movement): Check continued rows, in addition to
3277 continuation rows. Fixes unwarranted scroll when point enters a
3278 continued line of R2L text within an L2R paragraph, or vice versa.
3279 (cursor_row_p): Consider the case of point being equal to
3280 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3281 from the end of a short line to the beginning of a continued line
3282 of R2L text within L2R paragraph.
3283 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3284 composed characters.
5980d4c6 3285
f67cdd7f
EZ
3286 * bidi.c (bidi_check_type): Use xassert.
3287 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3288 members.
3289
bca633fb
EZ
32902011-08-23 Eli Zaretskii <eliz@gnu.org>
3291
3292 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3293 a character.
3294
4a5885a7
CY
32952011-08-23 Chong Yidong <cyd@stupidchicken.com>
3296
3297 * nsfont.m (ns_otf_to_script): Fix typo.
3298
0902a04e
KH
32992011-08-22 Kenichi Handa <handa@m17n.org>
3300
3301 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3302 extra slot even if the purpose is char-code-property-table.
3303
1a2e6670
EZ
33042011-08-23 Eli Zaretskii <eliz@gnu.org>
3305
8ddde651
EZ
3306 * xdisp.c (redisplay_window): When computing centering_position,
3307 account for the height of the header line. (Bug#8874)
3308
425cc014
EZ
3309 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3310 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3311 candidate is selected by the mouse, and that candidate has a
3312 composed character under the mouse.
3313
1a2e6670
EZ
3314 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3315 coordinates reported by pos-visible-in-window-p for a composed
3316 character in column zero.
3317
8b76d6f8
SM
33182011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3319
3320 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3321
dac347dd
EZ
33222011-08-22 Eli Zaretskii <eliz@gnu.org>
3323
3324 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3325 consider it a hit if to_charpos is anywhere in the range of the
3326 composed buffer positions.
3327
e013fb34
CY
33282011-08-22 Chong Yidong <cyd@stupidchicken.com>
3329
3330 * image.c (gif_load): Don't assume that each subimage has the same
3331 dimensions as the base image. Handle disposal method that is
3332 "undefined" by the gif spec (Bug#9335).
3333
bd1ba3e8
CY
33342011-08-20 Chong Yidong <cyd@stupidchicken.com>
3335
3336 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3337 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3338
54a1215b
EZ
33392011-08-19 Eli Zaretskii <eliz@gnu.org>
3340
823564e5
EZ
3341 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3342 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3343 from an Org mode buffer to a Speedbar frame.
3344
54a1215b
EZ
3345 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3346 a composition, take its buffer position from IT->cmp_it.charpos.
3347 Fixes cursor positioning at the beginning of a line that begins
3348 with a composed character.
3349
9778ebcc
EZ
33502011-08-18 Eli Zaretskii <eliz@gnu.org>
3351
0be6ee06
EZ
3352 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3353 character bidirectional type, use STRONG_L instead. Fixes crashes
3354 in a buffer produced by `describe-categories'.
3355
9778ebcc
EZ
3356 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3357 members before the level stack, so they would be saved and
3358 restored when copying iterator state. Fixes incorrect reordering
3359 around TABs covered by display properties.
3360
156bffbe
AS
33612011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3362
6b02f655 3363 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3364
72ad093b
CY
33652011-08-17 Chong Yidong <cyd@stupidchicken.com>
3366
3367 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3368 (internal_condition_case_2, internal_condition_case_n):
3369 Remove unnecessary aborts (Bug#9081).
72ad093b 3370
35774242
EZ
33712011-08-17 Eli Zaretskii <eliz@gnu.org>
3372
3373 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3374 has no `load' handler, try opening the file locally. (Bug#9311)
3375
db76dd85
KB
33762011-08-16 Ken Brown <kbrown@cornell.edu>
3377
3378 * gmalloc.c: Expand comment.
3379
b215eee5
EZ
33802011-08-16 Eli Zaretskii <eliz@gnu.org>
3381
3382 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3383 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3384
a4579d33
KB
33852011-08-16 Ken Brown <kbrown@cornell.edu>
3386
3387 Fix memory allocation problems in Cygwin build (Bug#9273).
3388
3389 * unexcw.c ( __malloc_initialized): Declare external variable.
3390 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3391
8b76d6f8
SM
3392 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3393 New variables.
a4579d33
KB
3394 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3395 dumped emacs.
3396 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3397 in the static heap.
3398 [CYGWIN] (special_realloc): New function.
3399 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3400 requests to realloc storage in the static heap.
3401
3ebec551
PE
34022011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3403
3404 * bidi.c (bidi_initialize): Remove unused local.
3405
9fd8be00
EZ
34062011-08-15 Eli Zaretskii <eliz@gnu.org>
3407
6b02f655
SM
3408 * bidimirror.h:
3409 * biditype.h: Remove file.
3410 * makefile.w32-in ($(BLD)/bidi.$(O)):
3411 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3412
3413 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3414
3415 * chartab.c: Improve commentary for the uniprop_table API.
3416
32413314
EZ
3417 * bidi.c (bidi_paragraph_init): Support zero value of
3418 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3419 (bidi_initialize): Use uniprop_table instead of including
3420 biditype.h and bidimirror.h.
32413314 3421
9fd8be00
EZ
3422 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3423 coordinates of the iterator when restoring from ppos_it.
3424 (Bug#9296)
3425
5cf2b69b
KH
34262011-08-14 Kenichi Handa <handa@m17n.org>
3427
3428 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3429 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3430
daf17d00
EZ
34312011-08-14 Eli Zaretskii <eliz@gnu.org>
3432
3433 * xdisp.c (move_it_in_display_line_to): Don't invoke
3434 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3435 ppos_it. Fixes vertical cursor motion when line beginning is
3436 covered by an image. (Bug#9296)
3437
08e3161a
JD
34382011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3439
3440 * nsterm.h (ns_run_ascript): Declare.
3441 (NSAPP_DATA2_RUNASSCRIPT): Define.
3442
3443 * nsfns.m (as_script, as_result, as_status): New static variables.
3444 (ns_run_ascript): New function.
5e617bc2 3445 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3446 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3447 the event loop. Get status from as_status (Bug#7276).
3448
3449 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3450 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3451 the event loop (Bug#7276).
3452
a3720aa2
AS
34532011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3454
3455 * gnutls.c (QCgnutls_bootprop_priority)
3456 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3457 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3458 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3459 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3460 (QCgnutls_bootprop_verify_hostname_error)
3461 (QCgnutls_bootprop_callbacks_verify): Rename from
3462 Qgnutls_bootprop_..., all uses changed.
3463
3464 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3465 uses changed.
3466
0a0d27fb
PE
34672011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3468
19d5c50c
PE
3469 * xfaces.c (Qframe_set_background_mode): Now static.
3470 * dispextern.h (Qframe_set_background_mode): Remove decl.
3471
0a0d27fb
PE
3472 * process.c (Fnetwork_interface_info): Declare local only if needed.
3473
377538cb
JD
34742011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3475
3476 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3477 (Fnetwork_interface_list): Allocate in increments of bytes instead
3478 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3479 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3480 sockaddr.
3481 (struct ifflag_def): notrailers is smart on OSX.
3482 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3483 Get hardware address with getifaddrs if available.
3484
08fff70c
EZ
34852011-08-12 Eli Zaretskii <eliz@gnu.org>
3486
3487 * xdisp.c (iterate_out_of_display_property): xassert that
3488 IT->position is set to within IT->object's boundaries. Break from
3489 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3490 when IT->position is set up wrongly due to some bug.
3491 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3492 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3493 entry. Force push_it to save on the stack the current
3494 buffer/string position, to be restored by pop_it. Fix flags in
3495 the iterator structure wrt the object coming from a display
3496 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3497 properties. (Bug#9284)
3498
7be1c708 34992011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3500
7be1c708
CY
3501 * fontset.c (fontset_get_font_group): Add proper type checks.
3502 (Bug#9172)
aac0c6e3 3503
7be1c708 35042011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3505
7be1c708
CY
3506 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3507 and LC_VERSION_MIN_MACOSX.
3508 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3509 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3510
97bb72a6
EZ
35112011-08-08 Eli Zaretskii <eliz@gnu.org>
3512
3513 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3514 no-display-properties-and-no-overlays under bidi display.
3515 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3516 properties and overlays.
97bb72a6 3517
d5617611
CY
35182011-08-08 Chong Yidong <cyd@stupidchicken.com>
3519
37e11a63
CY
3520 * editfns.c (Fset_time_zone_rule): Document relationship with the
3521 setenv function.
3522
d5617611
CY
3523 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3524 the font entity extracted from the cache (Bug#8109).
3525
58872834
CY
35262011-08-07 Chong Yidong <cyd@stupidchicken.com>
3527
3528 * composite.c (autocmp_chars): Don't reset point. That is done by
3529 restore_point_unwind (Bug#5984).
3530
75bfc667
JL
35312011-08-07 Juri Linkov <juri@jurta.org>
3532
3533 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3534 to show the arg `TIME' instead of `TIMEVAL'.
3535
d1410150
EZ
35362011-08-06 Eli Zaretskii <eliz@gnu.org>
3537
3538 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3539 display property strides EOL and includes a newline, as in
3540 longlines-mode. (Bug#9254)
75b771e4
EZ
3541 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3542 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3543
3544 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3545 is non-zero, even if the data buffer is NULL. Fixes a crash in
3546 vertical-motion with longlines-mode. (Bug#9254)
3547
35928349
EZ
35482011-08-05 Eli Zaretskii <eliz@gnu.org>
3549
ec7cc85b
EZ
3550 * bidi.c <bidi_cache_total_alloc>: Now static.
3551 (bidi_initialize): Initialize bidi_cache_total_alloc.
3552
8b76d6f8 3553 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3554 cache. (Bug#9221)
3555
3556 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3557 amount allocated this far in `bidi_cache_total_alloc'.
3558 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3559 non-zero, only free the data buffer without restoring the cache
3560 contents. All callers changed.
3561
3562 * dispextern.h (bidi_unshelve_cache): Update prototype.
3563
3564 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3565 (move_it_in_display_line, move_it_to)
3566 (move_it_vertically_backward, move_it_by_lines): Replace the call
3567 to xfree to an equivalent call to bidi_unshelve_cache.
3568 (move_it_in_display_line_to): Fix logic of returning
412b6358 3569 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3570
e2e2423b
EZ
35712011-08-05 Eli Zaretskii <eliz@gnu.org>
3572
3573 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3574 came from a string character with a `cursor' property. (Bug#9229)
3575
ae9e757a
JD
35762011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3577
3578 * Makefile.in (LIB_PTHREAD): New variable.
3579 (LIBES): Add LIB_PTHREAD (Bug#9216).
3580
3581 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3582 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3583
213bd7f2
AS
35842011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3585
6b02f655 3586 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3587
99aaf75f
JD
35882011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3589
3590 * xterm.c (x_find_topmost_parent): New function.
3591 (x_set_frame_alpha): Find topmost parent window with
3592 x_find_topmost_parent and set the property there also (bug#9181).
3593 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3594
c74e9d86
PE
35952011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3596
3597 * callproc.c (Fcall_process): Avoid vfork clobbering
3598 the local vars buffer, coding_systems, current_dir.
3599
640c8776
SM
36002011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3601
3602 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3603
f26d0e4c
PE
36042011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3605
8a10d76c
PE
3606 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3607 so that it is not optimized away.
3608
f26d0e4c
PE
3609 * xdisp.c (compute_display_string_pos): Remove unused local.
3610
55439c61
EZ
36112011-08-02 Eli Zaretskii <eliz@gnu.org>
3612
3613 Fix slow cursor motion and scrolling in large buffers with
3614 selective display, like Org Mode buffers. (Bug#9218)
3615
3616 * dispextern.h (struct bidi_it): New member disp_prop_p.
3617
3618 * xdisp.c: Remove one-slot cache of display string positions.
3619 (compute_display_string_pos): Accept an additional argument
5e617bc2 3620 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3621 for a display string or property. If found, set DISP_PROP_P
3622 non-zero.
3623
3624 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3625 DISP_PROP_P, and pass it to compute_display_string_pos.
3626 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3627 non-zero. All callers of bidi_fetch_char changed.
3628
fb33fa43
SM
36292011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3630
3631 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3632
b099e063
DM
36332010-12-03 Don March <don@ohspite.net>
3634
3635 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3636 last character M-[char] is translated to ESC [char] (bug#7541).
3637
5cc7f7af
KH
36382011-08-02 Kenichi Handa <handa@m17n.org>
3639
d0fffa3f 3640 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3641
3642 * chartab.c (uniprop_table): Make it non-static.
3643
525d5e6e
EZ
36442011-08-01 Eli Zaretskii <eliz@gnu.org>
3645
3646 * xdisp.c (forward_to_next_line_start): Accept additional argument
3647 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3648 on the newline.
3649 (reseat_at_next_visible_line_start): Use the bidi iterator state
3650 returned by forward_to_next_line_start to restore the state of
3651 it->bidi_it after backing up to previous newline. (Bug#9212)
3652
31011111
AS
36532011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3654
3655 * regex.c (re_comp): Protoize.
3656 (re_exec): Fix return type.
3657 (regexec): Fix type of `ret'. (Bug#9203)
3658
476371c4
PE
36592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3660
e5d76069
PE
3661 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3662 This is needed if max-image-size is a floating-point number.
3663
9a79b20c
AS
36642011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3665
3666 * print.c (print_object): Print empty symbol as ##.
3667
3668 * lread.c (read1): Read ## as empty symbol.
3669
d8c2fa78
AA
36702011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3671
3672 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3673 setting frame foreground color (Bug#9175).
3674 (x_set_background_color): Likewise.
3675
ffe57a7a
AA
3676 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3677 contents (Bug#9176).
3678 (EmacsTooltip -init): Remove bezels and add shadows to
3679 tooltip windows.
3680
bf3492a5
AA
3681 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3682 or scroll bar (Bug#8470).
3683
d55e9c53
AA
3684 * nsfont.m (nsfont_open): Remove assignment to voffset and
3685 unnecessary vars hshink, expand, hd, full_height, min_height.
3686 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3687
3688 * nsterm.h (nsfont_info): Remove voffset field.
3689
d8c2fa78 36902011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3691
3692 Implement strike-through and overline on NextStep (Bug#8863).
3693
3694 * nsfont.m (nsfont_open): Use underline position provided by font,
3695 instead of hard-coded value of 2.
3696 (nsfont_draw): Call ns_draw_text_decoration instead.
3697
3698 * nsterm.h: Add declaration for ns_draw_text_decoration.
3699
3700 * nsterm.m (ns_draw_text_decoration): New function for drawing
3701 underline, overline, and strike-through.
3702 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3703 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3704 accommodate underlining, etc.
4843aac3 3705
4cc60b9b
EZ
37062011-07-28 Eli Zaretskii <eliz@gnu.org>
3707
bc7ece87
EZ
3708 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3709 default.
4cc60b9b 3710
476371c4
PE
37112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3712
66606eea
PE
3713 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3714 Without this fix, if a signal arrives just after memory fills up,
3715 'malloc' might be invoked reentrantly.
3716
476371c4
PE
3717 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3718 In other words, assume that every image size is allowed, on non-X
3719 hosts. This assumption is probably wrong, but it lets Emacs compile.
3720
f3fcc40d
AS
37212011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3722
3723 * regex.c (re_iswctype): Convert return values to boolean.
3724
350c992f
EZ
37252011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3726
3727 * xdisp.c (compute_display_string_pos): Don't use cached display
3728 string position if the buffer had its restriction changed.
3729 (Bug#9184)
3730
5266b4bb
PE
37312011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3732
3733 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3734
2573a837 37352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3736
41f55ccd 3737 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3738
39e378da
PE
3739 * bidi.c: Integer size and overflow fixes.
3740 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3741 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3742 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3743 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3744 (bidi_find_other_level_edge):
3745 Use ptrdiff_t instead of EMACS_INT where either will do.
3746 This works better on 32-bit hosts configured --with-wide-int.
3747 (bidi_cache_ensure_space): Check for size-calculation overflow.
3748 Use % rather than repeated addition, for better worst-case speed.
3749 Don't set bidi_cache_size until after xrealloc returns, because it
3750 might not return.
3751 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3752 (bidi_cache_ensure_space): Also check that the bidi cache size
3753 does not exceed that of the largest Lisp string or buffer. See Eli
3754 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3755
5e927815
PE
3756 * alloc.c (__malloc_size_t): Remove.
3757 All uses replaced by size_t. See Andreas Schwab's note
3758 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3759
ca4aa935
PE
3760 * image.c: Improve checking for integer overflow.
3761 (check_image_size): Assume that f is nonnull, since
3762 it is always nonnull in practice. This is one less thing to
3763 worry about when checking for integer overflow later.
3764 (x_check_image_size): New function, which checks for integer
3765 overflow issues inside X.
3766 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3767 This removes the need for a memory_full check.
3768 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3769 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3770 (xbm_read_bitmap_data): Change locals back to 'int', since
3771 their values must fit in 'int'.
3772 (xpm_load_image, png_load, tiff_load):
3773 Invoke x_create_x_image_and_pixmap earlier,
3774 to avoid much needless work if the image is too large.
3775 (tiff_load): Treat overly large images as if
3776 x_create_x_image_and_pixmap failed, not as malloc failures.
3777 (gs_load): Use x_check_image_size.
3778
5f8f9cc2
PE
3779 * gtkutil.c: Omit integer casts.
3780 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3781 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3782
5adf60bc
PE
3783 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3784
c8907a93
PE
3785 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3786 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3787 would wrongly return t on a 64-bit host.
3788
e3c25c68
PE
3789 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3790 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3791 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3792 and therefore cause GCC to emit a bogus diagnostic in some cases.
3793
3f791afe
PE
3794 * image.c: Integer signedness and overflow and related fixes.
3795 This is not an exhaustive set of fixes, but it's time to
3796 record what I've got.
3797 (lookup_pixel_color, check_image_size): Remove redundant decls.
3798 (check_image_size): Don't assume that arbitrary EMACS_INT values
3799 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3800 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3801 (tiff_load, imagemagick_load_image):
3802 Check for overflow in size calculations.
3803 (x_create_x_image_and_pixmap): Remove unnecessary test for
3804 xmalloc returning NULL; that can't happen.
3805 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3806 (xpm_color_bucket): Use better integer hashing function.
3807 (xpm_cache_color): Don't possibly over-allocate memory.
3808 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3809 (gif_memory_source):
3810 Use ptrdiff_t, not int or size_t, to record sizes.
3811 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3812 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3813 either works, as we prefer signed integers.
3814 (tiff_read_from_memory, tiff_write_from_memory):
3815 Return tsize_t, not size_t, since that's what the TIFF API wants.
3816 (tiff_read_from_memory): Don't fail simply because the read would
3817 go past EOF; instead, return a short read.
3818 (tiff_load): Omit no-longer-needed casts.
3819 (Fimagemagick_types): Don't assume size fits into 'int'.
3820
3cc5a532
PE
3821 Improve hashing quality when configured --with-wide-int.
3822 * fns.c (hash_string): New function, taken from sxhash_string.
3823 Do not discard information about ASCII character case; this
3824 discarding is no longer needed.
3825 (sxhash-string): Use it. Change sig to match it. Caller changed.
3826 * lisp.h: Declare it.
3827 * lread.c (hash_string): Remove, since we now use fns.c's version.
3828 The fns.c version returns a wider integer if --with-wide-int is
3829 specified, so this should help the quality of the hashing a bit.
3830
b312a492
PE
3831 * emacs.c: Integer overflow minor fix.
3832 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3833 Define only if GNU_LINUX.
3834 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3835
dfd153ae
PE
3836 * dispnew.c: Integer signedness and overflow fixes.
3837 Remove unnecessary forward decls, that were a maintenance hassle.
3838 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3839 All uses changed.
3840 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3841 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3842 (prepare_desired_row, line_draw_cost):
3843 Use int, not unsigned, where either works.
3844 (save_current_matrix, restore_current_matrix):
3845 Use ptrdiff_t, not size_t, where either works.
3846 (init_display): Check for overflow more accurately, and without
3847 relying on undefined behavior.
3848
a81d11a3
PE
3849 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3850 Remove, replacing with the new symbols in lisp.h. All uses changed.
3851 * fileio.c (make_temp_name):
3852 * filelock.c (lock_file_1, lock_file):
3853 * xdisp.c (message_dolog):
3854 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3855 Use pMd etc. instead.
3856 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3857 replacing the pWIDE etc. symbols removed from editfns.c.
3858
3300e6fd
PE
3859 * keyboard.h (num_input_events): Now uintmax_t.
3860 This is (very slightly) less likely to mess up due to wraparound.
3861 All uses changed.
3862
fd05c7e9
PE
3863 * buffer.c: Integer signedness fixes.
3864 (alloc_buffer_text, enlarge_buffer_text):
3865 Use ptrdiff_t rather than size_t when either will do, as we prefer
3866 signed integers.
3867
903fe15d
PE
3868 * alloc.c: Integer signedness and overflow fixes.
3869 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3870 (__malloc_size_t): Default to size_t, not to int.
3871 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3872 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3873 Prefer ptrdiff_t to size_t when either would do, as we prefer
3874 signed integers.
3875 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3876 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3877 Now const. Initialize with values that are in range even if char
3878 is signed.
3879 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3880 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3881 These functions do the right thing with sizes > 2**32.
3882 (check_depth): Now ptrdiff_t, not int.
3883 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3884 Adjust to new way of storing sizes. Check for size overflow bugs
3885 in rest of code.
3886 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3887 slightly wrong anyway, as it missed one instance of
3888 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3889 (refill_memory_reserve): Omit needless cast to size_t.
3890 (mark_object_loop_halt): Mark as externally visible.
3891
ac82cc6a
PE
3892 * xselect.c: Integer signedness and overflow fixes.
3893 (Fx_register_dnd_atom, x_handle_dnd_message):
3894 Use ptrdiff_t, not size_t, since we prefer signed.
3895 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3896 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3897 x_dnd_atoms_size and x_dnd_atoms_length.
3898
c2d1e36d
PE
3899 * doprnt.c: Prefer signed to unsigned when either works.
3900 * eval.c (verror):
3901 * doprnt.c (doprnt):
3902 * lisp.h (doprnt):
3903 * xdisp.c (vmessage):
3904 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3905 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3906 prefer signed arithmetic to avoid comparison confusion.
3907 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3908 but is a bit tricky.
3909
0e926e56
PE
3910 Assume freestanding C89 headers, string.h, stdlib.h.
3911 * data.c, doprnt.c, floatfns.c, print.c:
3912 Include float.h unconditionally.
3913 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3914 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3915 * regex.c: Likewise for stddef.h, string.h.
3916 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3917 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3918 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3919 (STDC_HEADERS): Remove obsolete defines.
3920 * sysdep.c: Include limits.h unconditionally.
3921
9cfdb3ec
PE
3922 Assume support for memcmp, memcpy, memmove, memset.
3923 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3924 * regex.c (memcmp, memcpy):
3925 Remove; we assume C89 now.
3926
3927 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3928 (__malloc_safe_bcopy): Remove; no longer needed.
3929
cf950e6b 3930 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3931 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3932 well either way, and we prefer signed to unsigned.
3933
dbf38e02
LMI
39342011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3935
3936 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3937 closes the connection while we're reading (bug#9182).
3938
d6f0886c 39392011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3940
d6f0886c
JD
3941 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3942 are specified (Bug#9168).
24e0f6b1 3943
2eb1f9e6
PE
39442011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3945
3946 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3947 Found by GCC static checking and --with-wide-int on a 32-bit host.
3948
22381272 39492011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3950
3951 * xdisp.c (compute_display_string_pos): Fix logic of caching
3952 previous display string position. Initialize cached_prev_pos to
3953 -1. Fixes slow-down at the beginning of a buffer.
3954
f25e39b4
EZ
39552011-07-24 Eli Zaretskii <eliz@gnu.org>
3956
3957 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3958 for attrs[LFACE_FONTSET_INDEX].
3959
04c4b52e
PE
39602011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3961
3962 * xml.c (parse_region): Remove unused local
3963 that was recently introduced.
3964
c1734fbd
EZ
39652011-07-23 Eli Zaretskii <eliz@gnu.org>
3966
be18c5a5
EZ
3967 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3968 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3969
c1734fbd
EZ
3970 * xdisp.c (move_it_in_display_line_to): Record the best matching
3971 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3972 exit if none of the characters scanned was an exact match.
3973 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3974 when exact match is impossible due to invisible text, and the
3975 lines are truncated.
3976
a258d627
JD
39772011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3978
3979 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3980 for OSX >= 10.7.
3981
b6d5a689
EZ
39822011-07-22 Eli Zaretskii <eliz@gnu.org>
3983
0f74f785
EZ
3984 Fix a significant slow-down of cursor motion with C-n, C-p,
3985 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3986 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3987 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3988 (next_element_from_buffer): Call compute_stop_pos_backwards to
3989 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3990 base_level_stop.
3991 (reseat): Don't look for prev_stop, as that could mean a very long
3992 run.
3993 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3994 <cached_disp_overlay_modiff>: Cache for last found display string
3995 position.
551918c1 3996 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3997 about the same buffer in the same area of character positions, and
3998 the buffer wasn't changed since the time the display string
3999 position was cached.
551918c1 4000
b2d0c91a
EZ
40012011-07-22 Eli Zaretskii <eliz@gnu.org>
4002
4003 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4004 is an integer, which is important for empty lines. (Bug#9149)
4005
043604ee
CY
40062011-07-22 Chong Yidong <cyd@stupidchicken.com>
4007
4008 * frame.c (Fmodify_frame_parameters): In tty case, update the
4009 default face if necessary (Bug#4238).
4010
da4adb04
CY
40112011-07-21 Chong Yidong <cyd@stupidchicken.com>
4012
4013 * editfns.c (Fstring_to_char): No need to explain what a character
4014 is in the docstring (Bug#6576).
4015
9abd0532
LMI
40162011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4017
4018 * xml.c (parse_region): Make sure we always return a tree.
4019
36881d16
HK
40202011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4021
4022 * xml.c (parse_region): If a document contains only comments,
4023 return that, too.
4024
1e98674d
LMI
40252011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4026
4027 * xml.c (make_dom): Return comments, too.
4028
590bd467
PE
40292011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4030
4031 Port to OpenBSD.
4032 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4033 and the surrounding thread.
4034 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4035 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4036 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4037 timer goes off.
4038 * s/openbsd.h (BROKEN_SIGIO): Define.
4039 * unexelf.c (unexec) [__OpenBSD__]:
4040 Don't update the .mdebug section of the Alpha COFF symbol table.
4041
f41628b2
LMI
40422011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4043
4044 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4045 (bug#8460).
4046
b59b67c5
PE
40472011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4048
15e3a074
PE
4049 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4050 This fixes some race conditions on the permissions of any newly
4051 created file.
4052
41bed37d
PE
4053 * alloc.c (valid_pointer_p): Use pipe, not open.
4054 This fixes some permissions issues when debugging.
4055
b59b67c5
PE
4056 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4057 If fchown fails to set both uid and gid, try to set just gid,
4058 as that is sometimes allowed. Adjust the file's mode to eliminate
4059 setuid or setgid bits that are inappropriate if fchown fails.
4060
925a6be7
SM
40612011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4062
4063 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4064 to compare Lisp_Objects.
4065 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4066 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4067 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4068
52968808
AS
40692011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4070
0a6a104b
AS
4071 * lread.c (read_integer): Unread even EOF character.
4072 (read1): Likewise. Properly record start position of symbol.
4073
52968808
AS
4074 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4075 symbol character follows.
4076
9e381cdd
PE
40772011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4078
4079 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4080 This works around a problem with the previous change to Fcopy_file.
4081 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4082 and without this change, GCC might complain about discarding
4083 fchown's return value.
4084
b5641435
JB
40852011-07-16 Juanma Barranquero <lekktu@gmail.com>
4086
4087 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4088
a8031457
PE
40892011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4090
4091 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4092
dd889327
LMI
40932011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4094
750c33f7
LMI
4095 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4096 it's used from the C level.
4097
dd889327
LMI
4098 * process.c: Use the same condition for POLL_FOR_INPUT in both
4099 keyboard.c and process.c (bug#1858).
4100
87e86684
LM
41012011-07-09 Lawrence Mitchell <wence@gmx.li>
4102
4103 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4104 (Fgnutls_boot): Use it.
4105
64348f40
AS
41062011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4107
4108 * doc.c (Fsubstitute_command_keys): Revert last change.
4109
1d698799
LMI
41102011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4111
f863868c
LMI
4112 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4113 quotes the next character, and doesn't affect other longer
4114 sequences (bug#8935).
4115
1d698799
LMI
4116 * lread.c (syms_of_lread): Clarify that is isn't only
4117 `eval-buffer' and `eval-defun' that's affected by
4118 `lexical-binding' (bug#8460).
4119
aa4b6df6
EZ
41202011-07-15 Eli Zaretskii <eliz@gnu.org>
4121
4122 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4123 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4124
5d856da6
PE
41252011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4126
ad6042bb
PE
4127 Fix minor problems found by static checking.
4128 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4129 (elsz): Now a signed constant, not a size_t var. We prefer signed
4130 types to unsigned, to avoid integer comparison confusion. Without
4131 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4132 "cannot optimize loop, the loop counter may overflow", a symptom
4133 of the confusion.
f00bbb22 4134 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4135 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4136
6468f31c
LMI
41372011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4138
49080b10
LMI
4139 * search.c (Fre_search_backward): Mention `case-fold-search' in
4140 all the re_search_* functions (bug#8138).
4141
6468f31c
LMI
4142 * keyboard.c (Fopen_dribble_file): Document when the file is
4143 closed (bug#8056).
4144
c965adc5
EZ
41452011-07-14 Eli Zaretskii <eliz@gnu.org>
4146
df9733bf
EZ
4147 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4148 bidi_cache_idx.
4149
0bb23927
EZ
4150 Support bidi reordering of display and overlay strings.
4151 * xdisp.c (compute_display_string_pos)
4152 (compute_display_string_end): Accept additional argument STRING.
4153 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4154 (reseat_to_string): Initialize bidi_it->string.s and
4155 bidi_it->string.schars.
4156 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4157 NULL (avoids a crash in bidi_paragraph_init).
4158 Initialize itb.string.lstring.
0bb23927
EZ
4159 (init_iterator): Call bidi_init_it only of a valid
4160 buffer position was specified. Initialize paragraph_embedding to
4161 L2R.
4162 (reseat_to_string): Initialize the bidi iterator.
4163 (display_string): If we need to ignore text properties of
4164 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4165 original value of -1 will not work with bidi.)
4166 (compute_display_string_pos): First arg is now struct
4167 `text_pos *'; all callers changed. Support display properties on
4168 Lisp strings.
4169 (compute_display_string_end): Support display properties on Lisp
4170 strings.
4171 (init_iterator, reseat_1, reseat_to_string): Initialize the
4172 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4173 when iterating on a string not from display properties).
640c8776
SM
4174 (compute_display_string_pos, compute_display_string_end):
4175 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4176 arrow keys.
4177 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4178 base_level_stop; instead, set base_level_stop to BEGV.
4179 Fixes crashes in vertical-motion.
0bb23927
EZ
4180 (next_element_from_buffer): Improve commentary for when
4181 the iterator is before prev_stop.
4182 (init_iterator): Initialize bidi_p from the default value of
4183 bidi-display-reordering, not from buffer-local value. Use the
4184 buffer-local value only if initializing for buffer iteration.
4185 (handle_invisible_prop): Support invisible properties on strings
4186 that are being bidi-reordered.
4187 (set_iterator_to_next): Support bidi reordering of C strings and
4188 Lisp strings.
4189 (next_element_from_string): Support bidi reordering of Lisp
4190 strings.
4191 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4192 (display_string): Support display of R2L glyph rows.
4193 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4194 (init_iterator): Don't initialize it->bidi_p for strings
4195 here.
4196 (reseat_to_string): Initialize it->bidi_p for strings here.
4197 (next_element_from_string, next_element_from_c_string)
4198 (next_element_from_buffer): Add xassert's for correspondence
4199 between IT's object being iterated and it->bidi_it.string
4200 structure.
4201 (face_before_or_after_it_pos): Support bidi iteration.
4202 (next_element_from_c_string): Handle the case of the first string
4203 character that is not the first one in the visual order.
4204 (get_visually_first_element): New function, refactored from common
4205 parts of next_element_from_buffer, next_element_from_string, and
4206 next_element_from_c_string.
4207 (tool_bar_lines_needed, redisplay_tool_bar)
4208 (display_menu_bar): Force left-to-right direction. Add a FIXME
4209 comment for making that be controlled by a user option.
4210 (push_it, pop_it): Save and restore the state of the
4211 bidi iterator. Save and restore the bidi_p flag.
4212 (pop_it): Iterate out of display property for string iteration as
4213 well.
4214 (iterate_out_of_display_property): Support iteration over strings.
4215 (handle_single_display_spec): Set up it->bidi_it for iteration
4216 over a display string, and call bidi_init_it.
4217 (handle_single_display_spec, next_overlay_string)
4218 (get_overlay_strings_1, push_display_prop): Set up the bidi
4219 iterator for displaying display or overlay strings.
4220 (forward_to_next_line_start): Don't use the shortcut if
4221 bidi-iterating.
4222 (back_to_previous_visible_line_start): If handle_display_prop
4223 pushed the iterator stack, restore the internal state of the bidi
4224 iterator by calling bidi_pop_it same number of times.
4225 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4226 and we are bidi-iterating, don't decrement the iterator position;
4227 instead, set the first_elt flag in the bidi iterator, to produce
4228 the same effect.
4229 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4230 (push_display_prop): xassert that we are iterating a buffer.
4231 (push_it, pop_it): Save and restore paragraph_embedding member.
4232 (handle_single_display_spec, next_overlay_string)
4233 (get_overlay_strings_1, reseat_1, reseat_to_string)
4234 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4235 correctly. Don't assume unibyte strings are not bidi-reordered.
4236 (compute_display_string_pos)
4237 (compute_display_string_end): Fix handling the case of C string.
4238 (push_it, pop_it): Save and restore from_disp_prop_p.
4239 (handle_single_display_spec, push_display_prop): Set the
4240 from_disp_prop_p flag.
4241 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4242 (pop_it): Call iterate_out_of_display_property only if we are
4243 popping after iteration over a string that came from a display
4244 property. Fix a typo in popping stretch info. Add an assertion
4245 for verifying that the iterator position is in sync with the bidi
4246 iterator.
4247 (handle_single_display_spec, get_overlay_strings_1)
4248 (push_display_prop): Fix initialization of paragraph direction for
4249 string when that of the parent object is not yet determined.
4250 (reseat_1): Call bidi_init_it to resync the bidi
4251 iterator with IT's position. (Bug#7616)
4252 (find_row_edges): If ROW->start.pos gives position
4253 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4254 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4255 Reset the from_disp_prop_p flag.
4256 (SAVE_IT, RESTORE_IT): New macros.
4257 (pos_visible_p, face_before_or_after_it_pos)
4258 (back_to_previous_visible_line_start)
4259 (move_it_in_display_line_to, move_it_in_display_line)
4260 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4261 (try_scrolling, redisplay_window, display_line): Use them when
4262 saving a temporary copy of the iterator and restoring it back.
4263 (back_to_previous_visible_line_start, reseat_1)
4264 (init_iterator): Empty the bidi cache "stack".
4265 (move_it_in_display_line_to): If iterator ended up at
4266 EOL, but we never saw any buffer positions smaller than
4267 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4268 motion in bidi-reordered lines.
4269 (move_it_in_display_line_to): Record prev_method and prev_pos
4270 immediately before the call to set_iterator_to_next. Fixes cursor
4271 motion in bidi-reordered lines with stretch glyphs and strings
4272 displayed in margins. (Bug#8133) (Bug#8867)
4273 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4274 TO_CHARPOS.
640c8776
SM
4275 (pos_visible_p): Support positions in bidi-reordered lines.
4276 Save and restore bidi cache.
0bb23927
EZ
4277
4278 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4279 (bidi_paragraph_info): Delete unused struct.
4280 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4281 (bidi_cache_start): New variable.
4282 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4283 to zero.
4284 (bidi_cache_fetch_state, bidi_cache_search)
4285 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4286 (bidi_cache_find, bidi_peek_at_next_level)
4287 (bidi_level_of_next_char, bidi_find_other_level_edge)
4288 (bidi_move_to_visually_next): Compare cache index with
4289 bidi_cache_start rather than with zero.
4290 (bidi_fetch_char): Accept new argument STRING; all callers
4291 changed. Support iteration over a string. Support strings with
4292 display properties. Support unibyte strings. Fix the type of
4293 `len' according to what STRING_CHAR_AND_LENGTH expects.
4294 (bidi_paragraph_init, bidi_resolve_explicit_1)
4295 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4296 (bidi_level_of_next_char, bidi_move_to_visually_next):
4297 Support iteration over a string.
0bb23927
EZ
4298 (bidi_set_sor_type, bidi_resolve_explicit_1)
4299 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4300 can now be zero (for strings); special values 0 and -1 were
4301 changed to -1 and -2, respectively.
4302 (bidi_char_at_pos): New function.
4303 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4304 Call it instead of FETCH_MULTIBYTE_CHAR.
4305 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4306 initialized to valid values.
4307 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4308 values.
4309 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4310 the test for valid cached positions. Fix the logic for looking up
4311 the sentinel state in the cache. GCPRO the Lisp string we are
4312 iterating.
4313 (bidi_push_it, bidi_pop_it): New functions.
4314 (bidi_initialize): Initialize the bidi cache start stack pointer.
4315 (bidi_cache_ensure_space): New function, refactored from part of
4316 bidi_cache_iterator_state. Don't assume the required size is just
4317 one BIDI_CACHE_CHUNK away.
4318 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4319 (bidi_count_bytes, bidi_char_at_pos): New functions.
4320 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4321 always valid if bidi_cache_idx is valid.
4322 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4323 is valid if it's going to be used.
4324 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4325 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4326 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4327 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4328 (bidi_find_other_level_edge, bidi_cache_start_stack):
4329 All variables related to cache indices are now EMACS_INT.
c965adc5 4330
0bb23927
EZ
4331 * dispextern.h (struct bidi_string_data): New structure.
4332 (struct bidi_it): New member `string'. Make flag members be 1-bit
4333 fields, and put them last in the struct.
640c8776
SM
4334 (compute_display_string_pos, compute_display_string_end):
4335 Update prototypes.
0bb23927
EZ
4336 (bidi_push_it, bidi_pop_it): Add prototypes.
4337 (struct iterator_stack_entry): New members bidi_p,
4338 paragraph_embedding, and from_disp_prop_p.
4339 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4340 (bidi_shelve_cache, bidi_unshelve_cache):
4341 Declare prototypes.
0bb23927
EZ
4342
4343 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4344 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4345 and vector-like objects.
4346
4347 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4348 cache around display iteration.
4349
4350 * window.c (Fwindow_end, window_scroll_pixel_based)
4351 (displayed_window_lines, Frecenter): Save and restore the bidi
4352 cache around display iteration.
4353
3bbd2265
LMI
43542011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4355
4356 * editfns.c (Fdelete_region): Clarify the use of the named
4357 parameters (bug#6788).
4358
adc47434
MR
43592011-07-14 Martin Rudalics <rudalics@gmx.at>
4360
4361 * indent.c (Fvertical_motion): Set and restore w->pointm when
4362 saving and restoring the window's buffer (Bug#9006).
4363
837c31f8
LMI
43642011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4365
4366 * editfns.c (Fstring_to_char): Clarify just what is returned
4367 (bug#6576). Text by Eli Zaretskii.
4368
ac389d0c
JB
43692011-07-13 Juanma Barranquero <lekktu@gmail.com>
4370
4371 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4372
0be0ce47
EZ
43732011-07-13 Eli Zaretskii <eliz@gnu.org>
4374
4375 * buffer.c (mmap_find): Fix a typo.
4376
cd18e7e3
JB
43772011-07-13 Johan Bockgård <bojohan@gnu.org>
4378
4379 Fix execution of x selection hooks.
4380 * xselect.c (Qx_lost_selection_functions)
4381 (Qx_sent_selection_functions): New vars.
4382 (syms_of_xselect): DEFSYM them.
4383 (x_handle_selection_request): Pass Qx_sent_selection_functions
4384 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4385 (x_handle_selection_clear,x_clear_frame_selections):
4386 Pass Qx_lost_selection_functions rather than
4387 Vx_lost_selection_functions to Frun_hook_with_args.
4388
47ea7f44
PE
43892011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4390
ac389d0c 4391 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4392 The old code sometimes used this field without initializing it.
4393
47ea7f44
PE
4394 * alloc.c (gc_sweep): Don't read past end of array.
4395 In theory, the old code could also have corrupted Emacs internals,
4396 though it'd be very unlikely.
4397
bc985c87
AS
43982011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4399
4400 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4401 argument. (Bug#4026)
bc985c87 4402
0cf34688
LMI
44032011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4404
b3dadd76
LMI
4405 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4406 key" (bug#4257).
4407
0cf34688
LMI
4408 * window.c (Fset_window_start): Doc fix (bug#4199).
4409 (Fset_window_hscroll): Ditto.
4410
270768cd
PE
44112011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4412
077e3dda 4413 Fix minor new problems caught by GCC 4.6.1.
270768cd 4414 * term.c (init_tty): Remove unused local.
490011a6 4415 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4416 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4417 not used otherwise.
270768cd 4418
b1f58454
CY
44192011-07-12 Chong Yidong <cyd@stupidchicken.com>
4420
4421 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4422
22b9578d
LMI
44232011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4424
6e70ab07
LMI
4425 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4426 are the mini-buffer and the echo area (bug#3320).
4427
22b9578d
LMI
4428 * term.c (init_tty): Remove support for supdup, c10 and perq
4429 terminals, which are no longer supported (bug#1482).
4430
8974cc9f
JB
44312011-07-10 Johan Bockgård <bojohan@gnu.org>
4432
4433 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4434
a560d974
JD
44352011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4436
4437 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4438 for non-popups (Bug#3642).
4439
1dae0f0a
AS
44402011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4441
268c2c36 4442 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4443 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4444 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4445 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4446 * data.c (fmod): Likewise.
4447 * dispnew.c (swap_glyphs_in_rows): Likewise.
4448 * emacs.c (memory_warning_signal): Likewise.
4449 * floatfns.c (float_error): Likewise.
4450 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4451 (otf_open, font_otf_capability, generate_otf_features)
4452 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4453 Likewise.
4454 * image.c (pbm_read_file): Likewise.
4455 * indent.c (string_display_width): Likewise.
4456 * intervals.c (check_for_interval, search_for_interval)
4457 (inc_interval_count, count_intervals, root_interval)
4458 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4459 * lread.c (defalias): Likewise.
268c2c36 4460 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4461 * regex.c (set_image_of_range_1, set_image_of_range)
4462 (regex_grow_registers): Likewise.
4463 * sysdep.c (strerror): Likewise.
4464 * termcap.c (valid_filename_p, tprint, main): Likewise.
4465 * tparam.c (main): Likewise.
4466 * unexhp9k800.c (run_time_remap, save_data_space)
4467 (update_file_ptrs, read_header, write_header, calculate_checksum)
4468 (copy_file, copy_rest, display_header): Likewise.
4469 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4470 Likewise.
4471 * xdisp.c (check_it): Likewise.
4472 * xfaces.c (register_color, unregister_color, unregister_colors):
4473 Likewise.
4474 * xfns.c (print_fontset_result): Likewise.
4475 * xrdb.c (member, fatal, main): Likewise.
4476
99033785
PE
44772011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4478
4479 Fix minor problems found by static checking (Bug#9031).
4480 * chartab.c (char_table_set_range, map_sub_char_table):
4481 Remove unused locals.
4482 (uniprop_table): Now static.
4483 * composite.c (_work_char): Remove unused static var.
4484
9cb2ac56
JB
44852011-07-09 Juanma Barranquero <lekktu@gmail.com>
4486
4487 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4488
f25661f0
JD
44892011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4490
4491 * gtkutil.c (qttip_cb): Remove code without function.
4492
8278c4fe
EZ
44932011-07-09 Eli Zaretskii <eliz@gnu.org>
4494
4495 * w32.c (pthread_sigmask): New stub.
4496
1692ae2d 44972011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4498
8a6ebd58 4499 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4500 sigprocmask is portable only for single-threaded applications, and
4501 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4502 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4503 (LIBES): Use it.
4504 * callproc.c (Fcall_process):
4505 * process.c (create_process):
4506 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4507 Use pthread_sigmask, not sigprocmask.
123403e4 4508
1b854618
JD
45092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4510
4511 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4512 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4513 wrong (Bug#8591).
4514
3fe4b549
JD
45152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4516
0ce7e563
JD
4517 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4518 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4519 (xg_hide_tooltip): Fix comment.
4520
3fe4b549
JD
4521 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4522 in registerServicesMenuSendTypes.
4523 (validRequestorForSendType): Don't check ns_return_types.
4524
4525 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4526 ns_return_type.
4527
5df75e47
JR
45282011-07-08 Jason Rumney <jasonr@gnu.org>
4529
22610910
JR
4530 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4531 SH_SHOW for hidden windows (Bug#5482).
4532
5df75e47
JR
4533 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4534 frame struct members of non-existent frames (Bug#6284).
4535
699c10bd
JD
45362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4537
4393663b
JD
4538 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4539 variable firstTime not needed on OSX >= 10.6.
4540 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4541 >= 10.5. Use setKnobProportion, setDoubleValue.
4542
4543 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4544 (MAC_OS_X_VERSION_10_5): Define if not defined.
4545 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4546 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4547 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4548
4549 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4550 cString and lossyCString on OSX >= 10.4
4551
58179cce 4552 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4553 sizeToFit on OSX >= 10.2.
4554
4555 * nsimage.m (allocInitFromFile): Don't use deprecated method
4556 bestRepresentationForDevice on OSX >= 10.6.
4557
4558 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4559 to avoid warning.
4560
4561 * emacs.c: Declare unexec_init_emacs_zone.
4562
a63e0781
JD
4563 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4564
699c10bd
JD
4565 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4566
4567 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4568 on svcsMenu (Bug#8842).
4569
4570 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4571 ns_return_types.
4572 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4573
4574 * nsterm.m (QUTF8_STRING): Declare.
4575 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4576 (validRequestorForSendType): Return type is (id).
4577 Change indexOfObjectIdenticalTo to indexOfObject.
4578 Check if we have local selection before returning self (Bug#8842).
4579 (writeSelectionToPasteboard): Put local selection into paste board
4580 if we have a local selection (Bug#8842).
4581 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4582
4583 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4584 (ns_get_local_selection): Declare.
4585
54e10184
LMI
45862011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4587
9888ff71
LMI
4588 * keymap.c (describe_map_tree): Don't insert a double newline at
4589 the end of the buffer (bug#1169) and return whether we inserted
4590 something.
4591
54e10184
LMI
4592 * callint.c (Fcall_interactively): Change "reading args" to
4593 "providing args" to try to clarify what it does (bug#1010).
4594
15fa4783
KH
45952011-07-07 Kenichi Handa <handa@m17n.org>
4596
4597 * composite.c (composition_compute_stop_pos): Ignore a static
4598 composition starting before CHARPOS (Bug#8915).
4599
4600 * xdisp.c (handle_composition_prop): Likewise.
4601
a8815b00
EZ
46022011-07-07 Eli Zaretskii <eliz@gnu.org>
4603
4604 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4605 (Bug#9015)
4606
ef7b981d 46072011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4608
4609 * character.h (unicode_category_t): New enum type.
4610
4611 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4612 (Qchar_code_property_table): New variable.
4613 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4614 (UNIPROP_COMPRESSED_FORM_P): New macros.
4615 (char_table_ascii): Uncompress the compressed values.
4616 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4617 Uncompress the compressed values.
ac389d0c 4618 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4619 (char_table_ref_and_range): Uncompress the compressed values.
4620 (sub_char_table_set): New arg is_uniprop. Callers changed.
4621 Uncompress the compressed values.
4622 (sub_char_table_set_range): Args changed. Callers changed.
4623 (char_table_set_range): Adjuted for the above change.
4624 (map_sub_char_table): Delete args default_val and parent. Add arg
4625 top. Give decoded values to a Lisp function.
640c8776 4626 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4627 values to a Lisp function. Gcpro more variables.
4628 (uniprop_table_uncompress)
4629 (uniprop_decode_value_run_length): New functions.
4630 (uniprop_decoder, uniprop_decoder_count): New variables.
4631 (uniprop_get_decoder, uniprop_encode_value_character)
4632 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4633 New functions.
4634 (uniprop_encoder, uniprop_encoder_count): New variables.
4635 (uniprop_get_encoder, uniprop_table)
4636 (Funicode_property_table_internal, Fget_unicode_property_internal)
4637 (Fput_unicode_property_internal): New functions.
4638 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4639 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4640 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4641 char-code-property-alist.
4642
640c8776 4643 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4644 Vunicode_category_table.
4645
640c8776 4646 * font.c (font_range): Adjust for the change of
c805dec0
KH
4647 Vunicode_category_table.
4648
76b397fb
DN
46492011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4650
4651 * m/iris4d.h: Remove file, move contents ...
4652 * s/irix6-5.h: ... here.
4653
22b4128e
PE
46542011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4655
4656 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4657 * alloc.c (mark_buffer):
4658 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4659 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4660 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4661 This isn't true in general, and it's particularly not true
4662 if Emacs is configured with --with-wide-int.
4663 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4664 New macros, used in the buffer.c change.
4665
869795d6
JD
46662011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4667
4668 * xsettings.c: Use both GConf and GSettings if both are available.
4669 (store_config_changed_event): Add comment.
4670 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4671 (store_tool_bar_style_changed): New functions.
5e617bc2 4672 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4673 (struct xsettings): Move font inside HAVE_XFT.
4674 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4675 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4676 Move inside HAVE_XFT.
640c8776 4677 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4678 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4679 also.
4680 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4681 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4682 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4683 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4684 (parse_settings): Move check for font inside HAVE_XFT.
4685 (read_settings, apply_xft_settings): Add comment.
4686 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4687 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4688 call store_font_name_changed.
4689 (xft_settings_event): Add comment.
4690 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4691 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4692 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4693 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4694 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4695 (xsettings_get_system_font, xsettings_get_system_normal_font):
4696 Add comment.
869795d6 4697
d8ed26bd
PE
46982011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4699
4700 Random fixes. E.g., (random) never returned negative values.
4701 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4702 subseconds part to the entropy, as that's a bit more random.
4703 Prefer signed to unsigned, since the signedness doesn't matter and
4704 in general we prefer signed. When given a limit, use a
4705 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4706 latter isn't right if USE_2_TAGS_FOR_INTS.
4707 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4708 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4709
cabf1cac
SM
47102011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4711
4712 * textprop.c (text_property_stickiness):
4713 Obey Vtext_property_default_nonsticky.
4714 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4715 * w32fns.c (syms_of_w32fns):
4716 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4717
6e9b2be9
PE
47182011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4719
4720 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4721 This is more efficient than Ffile_directory_p and avoids a minor race.
4722
90186c68
LMI
47232011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4724
7c301272
LMI
4725 * buffer.c (Foverlay_put): Say what the return value is
4726 (bug#7835).
4727
c4f2d8d4
LMI
4728 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4729 is a directory before asking whether to use the file name
4730 (bug#7564).
ad637907
LMI
4731 (barf_or_query_if_file_exists): Make the "File is a directory"
4732 error be more correct.
c4f2d8d4 4733
90186c68
LMI
4734 * fns.c (Frequire): Remove the mention of the .gz files, since
4735 that's installation-specific, but keep the mention of
4736 `get-load-suffixes'.
4737
da64016e
PE
47382011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4739
4740 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4741 Report string overflow if the output is too long.
4742
7d47b580
JB
47432011-07-04 Juanma Barranquero <lekktu@gmail.com>
4744
a555cb87
JB
4745 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4746 (syms_of_gnutls): Remove duplicate DEFSYM for
4747 Qgnutls_bootprop_verify_hostname_error, an error for
4748 Qgnutls_bootprop_verify_error (which is no longer used).
4749
7d47b580
JB
4750 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4751 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4752 Also (re)move comments that are misplaced or no longer relevant.
4753
1e49bfab
LMI
47542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4755
4756 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4757
1485f4c0
CY
47582011-07-03 Chong Yidong <cyd@stupidchicken.com>
4759
4760 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4761 and background color parameters if they have been changed.
4762
a9ab721e
LMI
47632011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4764
4765 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4766
cf7cff57
PE
47672011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4768
2e13213d
PE
4769 * xsettings.c (SYSTEM_FONT): Define only when used.
4770 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4771
cf7cff57
PE
4772 * keymap.c (access_keymap_1): Now static.
4773
7a8e04f7
CY
47742011-07-02 Chong Yidong <cyd@stupidchicken.com>
4775
4776 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4777 leave any prefix arg for the up event (Bug#1586).
4778
61352f62
LMI
47792011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4780
69bb1ef7
LMI
4781 * lread.c (syms_of_lread): Mention single symbols defined by
4782 `defvar' or `defconst' (bug#7154).
4783
61352f62 4784 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4785 (Frequire): Mention get-load-suffixes.
61352f62 4786
28545e04
MR
47872011-07-02 Martin Rudalics <rudalics@gmx.at>
4788
4789 * window.h (window): Remove clone_number slot.
4790 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4791 Remove.
4792 (make_parent_window, make_window, saved_window)
4793 (Fset_window_configuration, save_window_save): Don't deal with
4794 clone numbers.
4795 * buffer.c (Qclone_number): Remove declaration.
4796 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4797
3349e122
SM
47982011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4799
4800 Add multiple inheritance to keymaps.
4801 * keymap.c (Fmake_composed_keymap): New function.
4802 (Fset_keymap_parent): Simplify.
4803 (fix_submap_inheritance): Remove.
4804 (access_keymap_1): New function extracted from access_keymap to handle
4805 embedded parents and handle lists of maps.
4806 (access_keymap): Use it.
4807 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4808 (Fcopy_keymap): Handle embedded parents.
4809 (Fcommand_remapping, define_as_prefix): Simplify.
4810 (Fkey_binding): Simplify.
4811 (syms_of_keymap): Move minibuffer-local-completion-map,
4812 minibuffer-local-filename-completion-map,
4813 minibuffer-local-must-match-map, and
4814 minibuffer-local-filename-must-match-map to Elisp.
4815 (syms_of_keymap): Defsubr make-composed-keymap.
4816 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4817 (parse_menu_item): Trivial simplification.
4818
3279eb87
GM
48192011-07-01 Glenn Morris <rgm@gnu.org>
4820
4821 * Makefile.in (SETTINGS_LIBS): Fix typo.
4822
4550efdf
KI
48232011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4824
4825 * coding.c (Fencode_coding_string): Record the last coding system
4826 used, as the function doc string says (bug#8738).
4827
0949d2b6
JD
48282011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4829
4830 * xsettings.c (store_monospaced_changed): Take new font as arg and
4831 check for change against current_mono_font.
4832 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4833 (emacs_settings_constructor, emacs_settings_get_property)
4834 (emacs_settings_set_property, emacs_settings_class_init)
4835 (emacs_settings_init, gsettings_obj): Remove.
4836 (something_changedCB): New function for HAVE_GSETTINGS.
4837 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4838 with value as argument.
4839 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4840 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4841 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4842 "changed".
4843
4844 * xgselect.c: Add defined (HAVE_GSETTINGS).
4845 (xgselect_initialize): Ditto.
4846
4847 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4848 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4849 xg_select.
4850
bbc6b304
PE
48512011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4852
4853 * eval.c (struct backtrace): Simplify and port the data structure.
4854 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4855 signed bit field, as this assumption is not portable and it makes
4856 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4857 "char debug_on_exit : 1" as this is not portable either; instead,
4858 use the portable "unsigned int debug_on_exit : 1". Remove unused
4859 member evalargs. Remove obsolete comments about cc bombing out.
4860
9851bfc5
JD
48612011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4862
51bb811f 4863 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4864 Let HAVE_GSETTINGS override HAVE_GCONF.
4865 (store_monospaced_changed): New function.
4866 (EMACS_SETTINGS): A new type derived from GObject to handle
4867 GSettings notifications.
4868 (emacs_settings_constructor, emacs_settings_get_property)
4869 (emacs_settings_set_property, emacs_settings_class_init):
4870 New functions.
4871 (gsettings_client, gsettings_obj): New variables.
4872 (GSETTINGS_SCHEMA): New define.
4873 (something_changedCB): Call store_monospaced_changed.
4874 (init_gsettings): New function.
4875 (xsettings_initialize): Call init_gsettings.
4876 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4877 to NULL.
4878
640c8776 4879 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4880 GCONF_CFLAGS/LIBS.
4881
5386012d
MR
48822011-06-29 Martin Rudalics <rudalics@gmx.at>
4883
4884 * window.c (resize_root_window, grow_mini_window)
4885 (shrink_mini_window): Rename Qresize_root_window to
4886 Qwindow_resize_root_window and Qresize_root_window_vertically to
4887 Qwindow_resize_root_window_vertically.
4888
f13e0b08
PE
48892011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4890
4891 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4892
94515237
JB
48932011-06-27 Juanma Barranquero <lekktu@gmail.com>
4894
4895 * makefile.w32-in: Redesign dependencies so they reflect more
4896 clearly which files are directly included by each source file,
4897 and not through other includes.
4898
e43b6e43
MR
48992011-06-27 Martin Rudalics <rudalics@gmx.at>
4900
4901 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4902 (sort_overlays, overlay_strings): When an overlay's clone number
4903 matches the window's clone number process the overlay even if
4904 the overlay's window property doesn't match the current window.
4905
d68443dc
MR
4906 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4907 (Fwindow_hchild): Rename to Fwindow_left_child.
4908 (Fwindow_next): Rename to Fwindow_next_sibling.
4909 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4910 (resize_window_check): Rename to window_resize_check.
4911 (resize_window_apply): Rename to window_resize_apply.
4912 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4913 (Fdelete_other_windows_internal, resize_frame_windows)
4914 (Fsplit_window_internal, Fdelete_window_internal)
4915 (grow_mini_window, shrink_mini_window)
4916 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4917
c7e73be5
JD
49182011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4919
4920 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4921 (emacs_fixed_set_min_size): Remove.
4922 (emacs_fixed_new): Take frame as argument.
4923
4924 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4925 (_EmacsFixedPrivate): Remove minwidth/height.
4926 Add struct frame *f.
4927 (emacs_fixed_init): Initialize priv->f.
4928 (get_parent_class, emacs_fixed_set_min_size): Remove.
4929 (emacs_fixed_new): Set priv->f to argument.
4930 (emacs_fixed_get_preferred_width)
4931 (emacs_fixed_get_preferred_height): Use min_width/height from
4932 frames size_hint to set minimum and natural (Bug#8919).
4933 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4934 and use min_width/height from frames size_hint to set
4935 min_width/height (Bug#8919).
4936
4937 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4938 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4939 Fix indentation.
c7e73be5 4940
cf99dcf8
EZ
49412011-06-26 Eli Zaretskii <eliz@gnu.org>
4942
4943 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4944 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4945 called at ZV.
4946
029529ac
CY
49472011-06-26 Chong Yidong <cyd@stupidchicken.com>
4948
4949 * process.c (wait_reading_process_output): Bypass select if
4950 waiting for a cell while ignoring keyboard input, and input is
4951 pending. Suggested by Jan Djärv (Bug#8869).
4952
7a7ef429
PE
49532011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4954
4955 Use gnulib's dup2 module instead of rolling our own.
4956 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4957
11fdef7d 49582011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4959
4960 * dispnew.c (scrolling_window): Before scrolling, turn off a
4961 mouse-highlight in the window being scrolled.
4962
cd3520a4
JB
49632011-06-24 Juanma Barranquero <lekktu@gmail.com>
4964
4965 Move DEFSYM to lisp.h and use everywhere.
4966
4967 * character.h (DEFSYM): Move declaration...
4968 * lisp.h (DEFSYM): ...here.
4969
4970 * gnutls.c:
4971 * minibuf.c:
4972 * w32menu.c:
4973 * w32proc.c:
4974 * w32select.c: Don't include character.h.
4975
4976 * alloc.c (syms_of_alloc):
4977 * buffer.c (syms_of_buffer):
4978 * bytecode.c (syms_of_bytecode):
4979 * callint.c (syms_of_callint):
4980 * casefiddle.c (syms_of_casefiddle):
4981 * casetab.c (init_casetab_once):
4982 * category.c (init_category_once, syms_of_category):
4983 * ccl.c (syms_of_ccl):
4984 * cmds.c (syms_of_cmds):
4985 * composite.c (syms_of_composite):
4986 * dbusbind.c (syms_of_dbusbind):
4987 * dired.c (syms_of_dired):
4988 * dispnew.c (syms_of_display):
4989 * doc.c (syms_of_doc):
4990 * editfns.c (syms_of_editfns):
4991 * emacs.c (syms_of_emacs):
4992 * eval.c (syms_of_eval):
4993 * fileio.c (syms_of_fileio):
4994 * fns.c (syms_of_fns):
4995 * frame.c (syms_of_frame):
4996 * fringe.c (syms_of_fringe):
4997 * insdel.c (syms_of_insdel):
4998 * keymap.c (syms_of_keymap):
4999 * lread.c (init_obarray, syms_of_lread):
5000 * macros.c (syms_of_macros):
5001 * msdos.c (syms_of_msdos):
5002 * print.c (syms_of_print):
5003 * process.c (syms_of_process):
5004 * search.c (syms_of_search):
5005 * sound.c (syms_of_sound):
5006 * syntax.c (init_syntax_once, syms_of_syntax):
5007 * terminal.c (syms_of_terminal):
5008 * textprop.c (syms_of_textprop):
5009 * undo.c (syms_of_undo):
5010 * w32.c (globals_of_w32):
5011 * window.c (syms_of_window):
5012 * xdisp.c (syms_of_xdisp):
5013 * xfaces.c (syms_of_xfaces):
5014 * xfns.c (syms_of_xfns):
5015 * xmenu.c (syms_of_xmenu):
5016 * xsettings.c (syms_of_xsettings):
5017 * xterm.c (syms_of_xterm): Use DEFSYM.
5018
4228cf16
TZ
50192011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5020
cd3520a4 5021 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5022
7fcccf1e
PE
50232011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5024
7efb4e0e
PE
5025 Integer and buffer overflow fixes (Bug#8873).
5026
ff5844ad
PE
5027 * print.c (printchar, strout): Check for string overflow.
5028 (PRINTPREPARE, printchar, strout):
5029 Don't set size unless allocation succeeds.
5030
90532f02
PE
5031 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5032 for sizes. Check for string overflow more accurately.
5033 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5034
6d84508d
PE
5035 * macros.c: Integer and buffer overflow fixes.
5036 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5037 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5038 Use ptrdiff_t, not int, for sizes.
5039 Don't increment bufsize until after realloc succeeds.
5040 Check for size-calculation overflow.
5041 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5042
437b2cb4
PE
5043 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5044
8b9ac8b4
PE
5045 * lread.c: Integer overflow fixes.
5046 (read_integer): Radix is now EMACS_INT, not int,
5047 to improve quality of diagnostics for out-of-range radices.
5048 Calculate buffer size correctly for out-of-range radices.
5049 (read1): Check for integer overflow in radices, and in
5050 read-circle numbers.
82cb60d3
PE
5051 (read_escape): Avoid int overflow.
5052 (Fload, openp, read_buffer_size, read1)
5053 (substitute_object_recurse, read_vector, read_list, map_obarray):
5054 Use ptrdiff_t, not int, for sizes.
5055 (read1): Use EMACS_INT, not int, for sizes.
20270765 5056 Check for size overflow.
8b9ac8b4 5057
7fcccf1e
PE
5058 * image.c (cache_image): Check for size arithmetic overflow.
5059
bfbbd7e7
PE
5060 * lread.c: Integer overflow issues.
5061 (saved_doc_string_size, saved_doc_string_length)
5062 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5063 Now ptrdiff_t, not int.
5064 (read1): Don't assume doc string length fits in int. Check for
5065 out-of-range doc string lengths.
5066 (read_list): Don't assume file position fits in int.
39019e54 5067 (read_escape): Check for hex character overflow.
bfbbd7e7 5068
4e323265
LL
50692011-06-22 Leo Liu <sdl.web@gmail.com>
5070
5071 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5072 Move to minibuffer.el.
5073
85fece3e
PE
50742011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5075
20b84ce9 5076 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5077 The following patches are for when GLYPH_DEBUG && !XASSERT.
5078 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5079 * dispnew.c (flush_stdout):
5080 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5081 Mark as externally visible.
5082 * dispnew.c (check_window_matrix_pointers): Now static.
5083 * dispnew.c (window_to_frame_vpos):
5084 * xfns.c (unwind_create_frame):
5085 * xterm.c (x_check_font): Remove unused local.
5086 * scroll.c (CHECK_BOUNDS):
5087 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5088 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5089 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5090 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5091 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5092 Now static.
5093 (debug_method_add): Use va_list and vsprintf rather than relying
5094 on undefined behavior with wrong number of arguments.
5095 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5096 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5097 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5098 since we're not interested in debugging glyphs with old libraries.
5099 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5100 GCC 4.6.0's static checking.
5101
0766b489
PE
51022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5103
31fd4b32
PE
5104 Integer overflow and signedness fixes (Bug#8873).
5105 A few related buffer overrun fixes, too.
5106
b79e8648
PE
5107 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5108
0766b489
PE
5109 * dispextern.h (struct face.stipple):
5110 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5111 (x_bitmap_mask, x_allocate_bitmap_record)
5112 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5113 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5114 (x_create_bitmap_from_xpm_data):
5115 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5116 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5117 (.bitmaps_last):
5118 * xfaces.c (load_pixmap):
5119 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5120 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5121 (.bitmaps_last, struct x_output.icon_bitmap):
5122 Use ptrdiff_t, not int, for bitmap indexes.
5123 (x_allocate_bitmap_record): Check for size overflow.
5124 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5125
b081724f
PE
5126 Use ptrdiff_t, not int, for overlay counts.
5127 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5128 * editfns.c (overlays_around, get_pos_property):
5129 * textprop.c (get_char_property_and_overlay):
5130 * xdisp.c (next_overlay_change, note_mouse_highlight):
5131 * xfaces.c (face_at_buffer_position):
21514da7
PE
5132 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5133 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5134 (Fnext_overlay_change, Fprevious_overlay_change)
5135 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5136 Use ptrdiff_t, not int, for sizes.
21514da7 5137 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5138
3de73e5e
PE
5139 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5140
2606c57b
PE
5141 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5142 (x_session_initialize): Do not assume string length fits in int.
5143
aaafe47a
PE
5144 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5145 This is unlikely, but can occur if DPI is outlandish.
5146
2674ddc8 5147 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5148 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5149
28154962
PE
5150 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5151 * xrdb.c (magic_file_p, search_magic_path):
5152 Omit last arg SUFFIX; it was always 0. All callers changed.
5153 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5154
7de51af5
PE
5155 * xfont.c (xfont_match): Avoid need for strlen.
5156
25ed6cc3
PE
5157 * xfns.c: Don't assume strlen fits in int.
5158 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5159
4eab31dd
PE
5160 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5161 not unsigned long, as we prefer signed integers. All callers changed.
5162 Detect integer overflow in repeat count.
5163 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5164 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5165
171e2a58
PE
5166 * termcap.c: Don't assume sizes fit in int and never overflow.
5167 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5168 (gobble_line): Check for size-calculation overflow.
5169
ad39faca 5170 * minibuf.c (Fread_buffer):
6e5bb2dc 5171 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5172 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5173 Don't assume string length fits in int.
5174
52c61c22 5175 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5176 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5177
b5b8c9e5
PE
5178 * font.c: Don't assume string length fits in int.
5179 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5180 Use ptrdiff_t, not int.
ccd6111c
PE
5181 (font_intern_prop): Don't assume string length fits in int.
5182 Don't assume integer property fits in fixnum.
5183 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5184
882f0d81 5185 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5186 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5187 Reformulate so as not to need the command string.
5188 Invoke gzip -cd rather than gunzip, as it's more portable.
5189 (lock_info_type, lock_file_1, lock_file):
5190 Don't assume pid_t and time_t fit in unsigned long.
5191 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5192 (current_lock_owner): Prefer signed type for sizes.
5193 Use memcpy, not strncpy, where memcpy is what is really wanted.
5194 Don't assume (via atoi) that time_t and pid_t fit in int.
5195 Check for time_t and/or pid_t out of range, e.g., via a network share.
5196 Don't alloca where an auto var works fine.
5197
93f4cf88
PE
5198 * fileio.c: Fix some integer overflow issues.
5199 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5200 Don't assume string length fits in int.
5201 (directory_file_name): Don't assume string length fits in long.
5202 (make_temp_name): Don't assume pid fits in int, or that its print
5203 length is less than 20.
5204
f3e92b69
PE
5205 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5206
1bfdaf10
PE
5207 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5208
35016e9a
PE
5209 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5210
3d1e65a1
PE
5211 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5212 We prefer signed integers, even for size calculations.
5213
0b963a93
PE
5214 * emacs.c: Don't assume string length fits in 'int'.
5215 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5216 (main): Don't invoke strlen when not needed.
5217
573f4b54
PE
5218 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5219 (XD_DEBUG_MESSAGE): Don't waste a byte.
5220
989f33ba
PE
5221 * callproc.c (getenv_internal_1, getenv_internal)
5222 (Fgetenv_internal):
965d34eb
PE
5223 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5224
e4d29b33
PE
5225 * lread.c (invalid_syntax): Omit length argument.
5226 All uses changed. This doesn't fix a bug, but it simplifies the
5227 code away from its former Hollerith-constant appearance, and it's
5228 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5229 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5230
eb49b136
PE
5231 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5232 This didn't break anything, but it didn't help either.
5233 It's confusing to put a bogus integer in a place where the actual
5234 value does not matter.
9f62aeb1 5235 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5236 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5237
15375a22
PE
5238 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5239 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5240 implementation.
b61cc01c
PE
5241 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5242 We prefer signed types, and the value cannot exceed the EMACS_INT
5243 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5244 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5245 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5246 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5247
53b2623d
PE
5248 * indent.c (sane_tab_width): New function.
5249 (current_column, scan_for_column, Findent_to, position_indentation)
5250 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5251 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5252
51cab52b 5253 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5254
f2ed8a70
PE
5255 * lisp.h (lint_assume): New macro.
5256 * composite.c (composition_gstring_put_cache):
5257 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5258
abe80cc6
PE
5259 * editfns.c, insdel.c:
5260 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5261
b02c740e
PE
5262 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5263
ebc96716
PE
5264 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5265
b4e50fa0 5266 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5267 Use much-faster test for byte-length change.
311d5d7c 5268 Don't assume string byte-length fits in 'int'.
a4cf38e4 5269 Check that character arg fits in 'int'.
85461888 5270 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5271
c0c1ee9f
PE
5272 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5273
a498d7f4
PE
5274 * fns.c (concat): Catch string overflow earlier.
5275 Do not rely on integer wraparound.
5276
51cab52b
PE
5277 * dispextern.h (struct it.overlay_strings_charpos)
5278 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5279 * xdisp.c (forward_to_next_line_start)
5280 (back_to_previous_visible_line_start)
5281 (reseat_at_next_visible_line_start, next_element_from_buffer):
5282 Don't arbitrarily truncate the value of 'selective' to int.
5283
76031fad
PE
5284 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5285
5eb55db9
PE
5286 * composite.c: Don't truncate sizes to 'int'.
5287 (composition_gstring_p, composition_reseat_it)
5288 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5289 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5290 not EMACS_UINT, for indexes.
5eb55db9 5291
0703a717
PE
5292 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5293
d6202519
PE
5294 * buffer.c: Include <verify.h>.
5295 (struct sortvec.priority, struct sortstr.priority):
8961a454 5296 Now EMACS_INT, not int.
c20998a7 5297 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5298 (struct sortstr.size, record_overlay_string)
5299 (struct sortstrlist.size, struct sortlist.used):
5300 Don't truncate size to int.
5301 (record_overlay_string): Check for size-calculation overflow.
d6202519 5302 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5303
d5a19415
JM
53042011-06-22 Jim Meyering <meyering@redhat.com>
5305
029529ac 5306 Don't leak an XBM-image-sized buffer
d5a19415
JM
5307 * image.c (xbm_load): Free the image buffer after using it.
5308
a9041e6c
PE
53092011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5310
5311 Port to Sun C.
5312 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5313 that Sun C diagnosed.
5314 * fns.c (secure_hash): Fix pointer signedness issue.
5315 * intervals.c (static_offset_intervals): New function.
5316 (offset_intervals): Use it.
5317
7f3f739f
LL
53182011-06-21 Leo Liu <sdl.web@gmail.com>
5319
5320 * deps.mk (fns.o):
5321 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5322 sha512.h.
5323
5324 * fns.c (secure_hash): Rename from crypto_hash_function and change
5325 the first arg to accept symbols.
5b66d427 5326 (Fsecure_hash): New primitive.
7f3f739f
LL
5327 (syms_of_fns): New symbols.
5328
76147d94
DD
53292011-06-20 Deniz Dogan <deniz@dogan.se>
5330
5331 * process.c (Fset_process_buffer): Clarify return value in
5332 docstring.
5333
7d7d0045
CY
53342011-06-18 Chong Yidong <cyd@stupidchicken.com>
5335
5336 * dispnew.c (add_window_display_history): Use BVAR.
5337
5338 * xdisp.c (debug_method_add): Use BVAR.
5339 (check_window_end, dump_glyph_matrix, dump_glyph)
5340 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5341
5342 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5343 Likewise.
5344
5345 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5346 check till after the cache is created in init_frame_faces.
5347
ff2bc410
SM
53482011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5349
5350 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5351
28177add
PE
53522011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5353
dd3482fe
PE
5354 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5355 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5356 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5357
393d71f3 5358 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5359 * fileio.c (Finsert_file_contents):
5360 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5361 Remove the old (too-loose) buffer overflow checks.
5362 They weren't needed, since make_gap checks for buffer overflow.
5363 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5364 The old code merely checked for Emacs fixnum overflow, and relied
5365 on undefined (wraparound) behavior. The new code avoids undefined
5366 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5367
2e6813b0 5368 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5369 Tune. Don't use wider integers than needed. Don't use alloca.
5370 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5371
599a9e4f
PE
5372 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5373
99561444
PE
5374 * insdel.c, lisp.h (buffer_overflow): New function.
5375 (insert_from_buffer_1, replace_range, replace_range_2):
5376 * insdel.c (make_gap_larger):
5377 * editfns.c (Finsert_char):
5378 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5379
28177add
PE
5380 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5381
e69dafad
PE
53822011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5383
4baa020d 5384 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5385
b1c46f02
PE
5386 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5387 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5388
e69dafad
PE
5389 * fileio.c: Don't assume EMACS_INT fits in off_t.
5390 (emacs_lseek): New static function.
5391 (Finsert_file_contents, Fwrite_region): Use it.
5392 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5393
566684ea
PE
5394 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5395
e6966cd6
PE
5396 * fns.c: Don't overflow int when computing a list length.
5397 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5398 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5399 truncation on 64-bit hosts. Check for QUIT every
5400 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5401 faster and is responsive enough.
5402 (Flength): Report an error instead of overflowing an integer.
5403 (Fsafe_length): Return a float if the value is not representable
5404 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5405 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5406 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5407
dd0b0efb
PE
5408 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5409 (header_size, word_size): New constants.
5410 (allocate_vectorlike): Don't check size overflow here.
5411 (allocate_vector): Check it here instead, since this is the only
5412 caller of allocate_vectorlike that could cause overflow.
5413 Check that the new vector's length is representable as a fixnum.
5414
86fe5cfe
PE
5415 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5416 The previous code was bogus. For example, next_almost_prime (32)
5417 returned 39, which is undesirable as it is a multiple of 3; and
5418 next_almost_prime (24) returned 25, which is a multiple of 5 so
5419 why was the code bothering to check for multiples of 7?
5420
80e88859
PE
5421 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5422
4a2f0ad6
PE
5423 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5424
f66c7cf8
PE
5425 Variadic C functions now count arguments with ptrdiff_t.
5426 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5427 Back then I didn't know that the Emacs coding style prefers signed int.
5428 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5429 were being counted with int, which may truncate counts on 64-bit
5430 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5431 * lisp.h (struct Lisp_Subr.function.aMANY)
5432 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5433 Arg counts are now ptrdiff_t, not size_t.
5434 All variadic functions and their callers changed accordingly.
5435 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5436 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5437 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5438 * callint.c (Fcall_interactively): Check arg count for overflow,
5439 to avoid potential buffer overrun. Use signed char, not 'int',
5440 for 'varies' array, so that we needn't bother to check its size
5441 calculation for overflow.
5442 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5443 * eval.c (apply_lambda):
5444 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5445 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5446 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5447
a1759b76
PE
5448 * callint.c (Fcall_interactively): Don't use index var as event count.
5449
d96be9fc
PE
5450 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5451 * mem-limits.h (SIZE): Remove; no longer used.
5452
a690a978 5453 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5454
578c21e6
PE
5455 Remove unnecessary casts.
5456 * xterm.c (x_term_init):
5457 * xfns.c (x_set_border_pixel):
5458 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5459 These aren't needed now that we assume ANSI C.
5460
96f53c6c
PE
5461 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5462 It's more likely to cause problems (due to unsigned overflow)
5463 than to cure them.
5464
83c77d31
PE
5465 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5466
ee2079f1
PE
5467 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5468
6da65536
PE
5469 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5470
7147c4a4
PE
5471 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5472
193e32d9
PE
5473 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5474
e5533da6
PE
5475 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5476
9910e595
PE
5477 GLYPH_CODE_FACE returns EMACS_INT, not int.
5478 * dispextern.h (merge_faces):
5479 * xfaces.c (merge_faces):
01103c44
PE
5480 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5481 Don't assume EMACS_INT fits in int.
9910e595 5482
2638320e
PE
5483 * character.h (CHAR_VALID_P): Remove unused parameter.
5484 * fontset.c, lisp.h, xdisp.c: All uses changed.
5485
045eb8d9
PE
5486 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5487
c1f134b5
PE
5488 * fns.c (concat): Minor tuning based on overflow analysis.
5489 This doesn't fix any bugs. Use int to hold character, instead
5490 of constantly refetching from Emacs object. Use XFASTINT, not
5491 XINT, for value known to be a character. Don't bother comparing
5492 a single byte to 0400, as it's always less.
5493
395fcb93 5494 * floatfns.c (Fexpt):
327eeec8
PE
5495 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5496
abbd3d23
PE
5497 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5498 for characters.
5499
684a03ef
PE
5500 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5501
0fed43f3
PE
5502 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5503 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5504 incorrectly succeed when S was a string, because 4294967386 was
5505 truncated before it was used.
5506
8fd02eb7
PE
5507 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5508 Otherwise, an out-of-range integer could cause undefined behavior
5509 on a 64-bit host.
5510
f8c86b69
PE
5511 * composite.c: Use int, not EMACS_INT, for characters.
5512 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5513 EMACS_INT, for values that are known to be in character range.
5514 This doesn't fix any bugs but is the usual style inside Emacs and
5515 may generate better code on 32-bit machines.
5516
34206dd2
PE
5517 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5518 This is for reasons similar to the recent CHAR_STRING fix.
5519 * charset.c (Fencode_char): Check that character arg is actually
5520 a character. Pass an int to ENCODE_CHAR.
5521 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5522 wider than 'int', as a compile-time check to prevent future regressions
5523 in this area.
5524
c5958d4c 5525 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5526
5527 Make sure a 64-bit char is never passed to CHAR_STRING.
5528 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5529 by silently ignoring the top 32 bits, allowing some values
5530 that were far too large to be valid characters.
5531 * character.h: Include <verify.h>.
5532 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5533 arguments are no wider than unsigned, as a compile-time check
5534 to prevent future regressions in this area.
5535 * data.c (Faset):
01103c44 5536 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5537 (Fsubst_char_in_region):
5538 * fns.c (concat):
5539 * xdisp.c (decode_mode_spec_coding):
5540 Adjust to CHAR_STRING's new requirement.
5541 * editfns.c (Finsert_char, Fsubst_char_in_region):
5542 * fns.c (concat): Check that character args are actually
5543 characters. Without this test, these functions did the wrong
5544 thing with wildly out-of-range values on 64-bit hosts.
5545
d37ca623
PE
5546 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5547 These casts should not be needed on 32-bit hosts, either.
5548 * keyboard.c (read_char):
5549 * lread.c (Fload): Remove casts to unsigned.
5550
ea204efb
PE
5551 * lisp.h (UNSIGNED_CMP): New macro.
5552 This fixes comparison bugs on 64-bit hosts.
5553 (ASCII_CHAR_P): Use it.
5554 * casefiddle.c (casify_object):
01103c44 5555 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5556 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5557 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5558 * dispextern.h (FACE_FROM_ID):
5559 * keyboard.c (read_char): Use UNSIGNED_CMP.
5560
41cb286c
PE
5561 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5562 not to EMACS_INT, to avoid GCC warning.
5563
4a1b9832
PE
5564 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5565
55daad71
PE
5566 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5567 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5568 isn't needed on 32-bit machines.
8f95c75c 5569
01103c44
PE
5570 * buffer.c (Fgenerate_new_buffer_name):
5571 Use EMACS_INT for count, not int.
0ceccced 5572 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5573
5574 * data.c (Qcompiled_function): Now static.
5575
c6f072e7
PE
5576 * window.c (window_body_lines): Now static.
5577
20ce5912
PE
5578 * image.c (gif_load): Rename local to avoid shadowing.
5579
9c4c5f81
PE
5580 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5581 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5582 * alloc.c (make_save_value): Integer argument is now of type
5583 ptrdiff_t, not int.
5584 (mark_object): Use ptrdiff_t, not int.
5585 * lisp.h (pD): New macro.
5586 * print.c (print_object): Use it.
5587
c0c5c8ae
PE
5588 * alloc.c: Use EMACS_INT, not int, to count objects.
5589 (total_conses, total_markers, total_symbols, total_vector_size)
5590 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5591 (total_free_floats, total_floats, total_free_intervals)
5592 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5593 Now EMACS_INT, not int. All uses changed.
5594 (Fgarbage_collect): Compute overall total using a double, so that
5595 integer overflow is less likely to be a problem. Check for overflow
5596 when converting back to an integer.
5a25e253
PE
5597 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5598 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5599 These were 'int' variables that could overflow on 64-bit hosts;
5600 they were never used, so remove them instead of repairing them.
211a0b2a 5601 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5602 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5603 Previously, this ceilinged at INT_MAX, but that doesn't work on
5604 64-bit machines.
e46bb31a 5605 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5606
c78baabf 5607 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5608 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5609 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5610 when a (possibly-narrower) signed value would do just as well.
5611 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5612
c9d624c6
PE
5613 * alloc.c: Catch some string size overflows that we were missing.
5614 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5615 for convenience in STRING_BYTES_MAX.
5616 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5617 The definition here is exact; the one in lisp.h was approximate.
5618 (allocate_string_data): Check for string overflow. This catches
5619 some instances we weren't catching before. Also, it catches
5620 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5621 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5622 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5623
c9d624c6
PE
5624 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5625 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5626 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5627
353032ce
PE
5628 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5629
2bccce07
PE
5630 * alloc.c (Fmake_string): Check for out-of-range init.
5631
0ac30604
SM
56322011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5633
5634 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5635
c195f2de
JD
56362011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5637
5638 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5639 xg_get_default_scrollbar_width.
5640
5641 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5642 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5643 (style_changed_cb): Call update_theme_scrollbar_width and call
5644 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5645 all frames (Bug#8505).
5646 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5647 Call gtk_window_set_resizable if HAVE_GTK3.
5648 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5649 and height if HAVE_GTK3 (Bug#8505).
5650 (scroll_bar_width_for_theme): New variable.
5651 (update_theme_scrollbar_width): New function.
5652 (xg_get_default_scrollbar_width): Move code to
5653 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5654 (xg_initialize): Call update_theme_scrollbar_width.
5655
5656 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5657
5658 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5659
e10ac9f1
MR
56602011-06-12 Martin Rudalics <rudalics@gmx.at>
5661
5662 * frame.c (make_frame): Call other_buffer_safely instead of
5663 other_buffer.
5664
5665 * window.c (temp_output_buffer_show): Call display_buffer with
5666 second argument Vtemp_buffer_show_specifiers and reset latter
5667 immediately after the call.
5668 (Vtemp_buffer_show_specifiers): New variable.
5669 (auto_window_vscroll_p, next_screen_context_lines)
5670 (Vscroll_preserve_screen_position): Remove leading asterisks from
5671 doc-strings.
5672
2d3c217e 56732011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5674
7b7f97e8 5675 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5676 * buffer.c (Qclone_number): Remove for now, as it's unused.
5677 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5678 (record_buffer): Remove unused local.
5679 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5680 (set_frame_buffer_list): Remove; unused.
5681 * frame.h (other_visible_frames): Remove decl.
5682 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5683 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5684 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5685 if HAVE_GPM.
5686 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5687 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5688 Define only if HAVE_GPM.
5689 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5690 (update_hints_inhibit): Remove; never set. All uses removed.
5691 * widgetprv.h (emacsFrameClassRec): Remove decl.
5692 * window.c (delete_deletable_window): Now returns void, since it
5693 wasn't returning anything.
5694 (compare_window_configurations): Remove unused locals.
5695 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5696 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5697 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5698 the same widths as pointers. This follows up on the 2011-05-06 patch.
5699 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5700 * xterm.h: Likewise.
5701 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5702
1384b89e
JB
57032011-06-12 Juanma Barranquero <lekktu@gmail.com>
5704
5705 * makefile.w32-in: Update dependencies.
5706 (LISP_H): Add lib/intprops.h.
5707
1100a63c
CY
57082011-06-11 Chong Yidong <cyd@stupidchicken.com>
5709
5710 * image.c (gif_load): Add animation frame delay to the metadata.
5711 (syms_of_image): Use DEFSYM. New symbol `delay'.
5712
6198ccd0
MR
57132011-06-11 Martin Rudalics <rudalics@gmx.at>
5714
5715 * window.c (delete_deletable_window): Re-add.
5716 (Fset_window_configuration): Rewrite to handle dead buffers and
5717 consequently deletable windows.
5718 (window_tree, Fwindow_tree): Remove. Supply functionality in
5719 window.el.
5720 (compare_window_configurations): Simplify code.
5721
b6e3633c
AS
57222011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5723
1ab0dee5
AS
5724 * image.c (imagemagick_load_image): Fix type mismatch.
5725 (Fimagemagick_types): Likewise.
5726
b6e3633c
AS
5727 * window.h (replace_buffer_in_windows): Declare.
5728
9397e56f
MR
57292011-06-11 Martin Rudalics <rudalics@gmx.at>
5730
5731 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5732 Qclone_number. Remove external declaration of Qdelete_window.
5733 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5734 code.
640c8776
SM
5735 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5736 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5737 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5738 buffer list implementation.
5739 (other_buffer_safely): New function.
5740 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5741 calls to replace_buffer_in_windows and
5742 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5743 if allowed.
5744 (record_buffer): Inhibit quitting and rewrite using quittable
5745 functions. Run Qbuffer_list_update_hook if allowed.
5746 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5747 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5748 Move switch-to-buffer to window.el.
9397e56f
MR
5749 (bury-buffer): Move to window.el.
5750 (Vbuffer_list_update_hook): New variable.
5751
5752 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5753 section.
5754
5755 * window.h (resize_frame_windows): Move up in code.
5756 (Fwindow_frame): Remove EXFUN.
5757 (replace_buffer_in_all_windows): Remove prototype.
5758 (replace_buffer_in_windows_safely): Add prototype.
5759
5760 * window.c: Declare Qdelete_window static again. Move down
5761 declaration of select_count.
5762 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5763 (Fother_window): Move to window.el.
5764 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5765 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5766 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5767 window.el.
5768 (replace_buffer_in_windows): Implement by calling
5769 Qreplace_buffer_in_windows.
5770 (replace_buffer_in_all_windows): Remove with some functionality
5771 moved into replace_buffer_in_windows_safely.
5772 (replace_buffer_in_windows_safely): New function.
5773 (select_window_norecord, select_frame_norecord): Move in front
5774 of run_window_configuration_change_hook. Remove now obsolete
5775 declarations.
640c8776
SM
5776 (Fset_window_buffer): Rewrite doc-string.
5777 Call Qrecord_window_buffer.
9397e56f
MR
5778 (keys_of_window): Move binding for other-window to window.el.
5779
b50691aa
CY
57802011-06-11 Chong Yidong <cyd@stupidchicken.com>
5781
5782 * dispextern.h (struct image): Replace data member, whose int_val
5783 and ptr_val fields were not used by anything, with a single
5784 lisp_val object.
5785
5786 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5787 (gif_clear_image, gif_load, imagemagick_load_image)
5788 (gs_clear_image, gs_load): Callers changed.
5789
3f754b86
PE
57902011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5791
cca69397
PE
5792 * buffer.h: Include <time.h>, for time_t.
5793 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5794
109e28d0
PE
5795 Fix minor problems found by static checking.
5796
60737f02
PE
5797 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5798
4b66faf3
PE
5799 Make identifiers static if they are not used in other modules.
5800 * data.c (Qcompiled_function, Qframe, Qvector):
5801 * image.c (QimageMagick, Qsvg):
5802 * minibuf.c (Qmetadata):
5803 * window.c (resize_window_check, resize_root_window): Now static.
5804 * window.h (resize_window_check, resize_root_window): Remove decls.
5805
109e28d0
PE
5806 * window.c (window_deletion_count, delete_deletable_window):
5807 Remove; unused.
46a4ce9e
PE
5808 (window_body_lines): Now static.
5809 (Fdelete_other_windows_internal): Mark vars as initialized.
5810 Make sure 'resize_failed' is initialized.
5811 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5812 (resize_window_apply): Remove unused local.
5813 * window.h (delete_deletable_window): Remove decl.
5814
109e28d0 5815 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5816 (imagemagick_load_image): Fix pointer signedness problem by changing
5817 last arg from unsigned char * to char *. All uses changed.
5818 Also, fix a local for similar reasons.
5819 Remove unused locals. Remove locals to avoid shadowing.
5820 (fn_rsvg_handle_free): Remove; unused.
5821 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5822 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5823
3f754b86
PE
5824 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5825
2547adb1
CY
58262011-06-10 Chong Yidong <cyd@stupidchicken.com>
5827
5828 * image.c (gif_load): Fix omitted cast error introduced by
5829 2011-06-06 change.
5830
2c8e37d4
MR
58312011-06-10 Martin Rudalics <rudalics@gmx.at>
5832
5833 * window.h (resize_proportionally, orig_total_lines)
5834 (orig_top_line): Remove from window structure.
5835 (set_window_height, set_window_width, change_window_heights)
5836 (Fdelete_window): Remove prototypes.
5837 (resize_frame_windows): Remove duplicate declaration.
5838
440a42e3
EZ
58392011-06-10 Eli Zaretskii <eliz@gnu.org>
5840
5841 * window.h (resize_frame_windows, resize_window_check)
5842 (delete_deletable_window, resize_root_window)
5843 (resize_frame_windows): Declare prototypes.
5844
5845 * window.c (resize_window_apply): Make definition be "static" to
5846 match the prototype.
5847
562dd5e9
MR
58482011-06-10 Martin Rudalics <rudalics@gmx.at>
5849
5850 * window.c: Remove declarations of Qwindow_size_fixed,
5851 window_min_size_1, window_min_size_2, window_min_size,
5852 size_window, window_fixed_size_p, enlarge_window, delete_window.
5853 Remove static from declaration of Qdelete_window, it's
5854 temporarily needed by Fbury_buffer.
5855 (replace_window): Don't assign orig_top_line and
5856 orig_total_lines.
5857 (Fdelete_window, delete_window): Remove. Window deletion is
5858 handled by window.el.
640c8776
SM
5859 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5860 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5861 (Fdelete_other_windows): Remove. Deleting other windows is
5862 handled by window.el.
5863 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5864 handled in window.el.
5865 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5866 Window minimum sizes are handled in window.el.
5867 (shrink_windows, size_window, set_window_height)
5868 (set_window_width, change_window_heights, window_height)
5869 (window_width, CURBEG, CURSIZE, enlarge_window)
5870 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5871 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5872 handled in window.el.
5873 (make_dummy_parent): Rename to make_parent_window and give it a
5874 second argument horflag.
5875 (make_window): Don't set resize_proportionally any more.
5876 (Fsplit_window): Remove. Windows are split in window.el.
5877 (save_restore_action, save_restore_orig_size)
5878 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5879 Resize mini windows in window.el.
5880 (grow_mini_window, shrink_mini_window): Implement by calling
5881 Qresize_root_window_vertically, resize_window_check and
5882 resize_window_apply.
640c8776
SM
5883 (saved_window, Fset_window_configuration, save_window_save):
5884 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5885 resize_proportionally.
5886 (window_min_height, window_min_width): Move to window.el.
5887 (keys_of_window): Move bindings for delete-other-windows,
5888 split-window, delete-window and enlarge-window to window.el.
5889
5890 * buffer.c: Temporarily extern Qdelete_window.
5891 (Fbury_buffer): Temporarily call Qdelete_window instead of
5892 Fdelete_window (Fbury_buffer will move to window.el soon).
5893
5894 * frame.c (set_menu_bar_lines_1): Remove code handling
5895 orig_top_line and orig_total_lines.
5896
5897 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5898 set_window_height but set heights directly.
5899 (change_frame_size_1): Use resize_frame_windows.
5900
5901 * xdisp.c (init_xdisp): Don't use set_window_height but set
5902 heights directly.
5903
640c8776
SM
5904 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5905 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5906 run_window_configuration_change_hook.
5907
5908 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5909 instead of change_window_heights and run
5910 run_window_configuration_change_hook.
5911
1a13852e
MR
59122011-06-09 Martin Rudalics <rudalics@gmx.at>
5913
5914 * window.c (replace_window): Rename second argument REPLACEMENT to
5915 NEW. New third argument SETFLAG. Rewrite.
5916 (delete_window, make_dummy_parent): Call replace_window with
5917 third argument 1.
5918 (window_list_1): Move down in code.
5919 (run_window_configuration_change_hook): Move set_buffer part
5920 before select_frame_norecord part in order to unwind correctly.
5921 Rename count1 to count.
5922 (recombine_windows, delete_deletable_window, resize_root_window)
5923 (Fdelete_other_windows_internal)
5924 (Frun_window_configuration_change_hook, make_parent_window)
5925 (resize_window_check, resize_window_apply, Fresize_window_apply)
5926 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5927 (Fdelete_window_internal, Fresize_mini_window_internal):
5928 New functions.
1a13852e
MR
5929 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5930
f3d1777e
MR
59312011-06-08 Martin Rudalics <rudalics@gmx.at>
5932
496e208e
MR
5933 * window.h (window): Add some new members to window structure -
5934 normal_lines, normal_cols, new_total, new_normal, clone_number,
5935 splits, nest, prev_buffers, next_buffers.
5936 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5937 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5938
f3d1777e
MR
5939 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5940 Remove.
496e208e
MR
5941 (make_dummy_parent): Set new members of windows structure.
5942 (make_window): Move down in code. Handle new members of window
5943 structure.
5944 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5945 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5946 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5947 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5948 (Fset_window_next_buffers, Fset_window_clone_number):
5949 New functions.
496e208e
MR
5950 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5951 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5952 Doc-string fixes.
5953 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5954 Argument WINDOW can be now internal window too.
5955 (Fwindow_use_time): Move up in code.
5956 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5957 Rewrite doc-string.
5958 (Fset_window_configuration, saved_window)
5959 (Fcurrent_window_configuration, save_window_save): Handle new
5960 members of window structure.
b9e809c2
MR
5961 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5962 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5963 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5964 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5965 Qget_mru_window, Qresize_root_window,
5966 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5967 Qauto_buffer_name; staticpro them.
f3d1777e 5968
abde8f8c
MR
59692011-06-07 Martin Rudalics <rudalics@gmx.at>
5970
5971 * window.c (Fwindow_total_size, Fwindow_left_column)
5972 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5973 (Fwindow_list_1): New functions.
5974 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5975 (Fwindow_width, Fscroll_left, Fscroll_right):
5976 Use window_body_cols instead of window_box_text_cols.
5977 (delete_window, Fset_window_configuration):
5978 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5979 (delete_all_subwindows): Take a window as argument and not a
5980 structure. Rewrite.
190b47e6
MR
5981 (window_loop): Remove handling of GET_LRU_WINDOW and
5982 GET_LARGEST_WINDOW.
5983 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5984
5985 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5986 window_box_text_cols. delete_all_subwindows now takes a
5987 Lisp_Object as argument.
abde8f8c 5988
640c8776
SM
5989 * indent.c (compute_motion, Fcompute_motion):
5990 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5991
fa8a67e6
MR
5992 * frame.c (delete_frame): Call delete_all_subwindows with root
5993 window as argument.
5994
a54e3482
DC
59952011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5996
5997 * fns.c (Fputhash): Document return value.
5998
60002bf5
CY
59992011-06-06 Chong Yidong <cyd@stupidchicken.com>
6000
6001 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6002
0c671da6 60032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6004
b862a52a 6005 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6006
be44ca6c
PE
6007 Check for overflow when converting integer to cons and back.
6008 * charset.c (Fdefine_charset_internal, Fdecode_char):
6009 Use cons_to_unsigned to catch overflow.
6010 (Fencode_char): Use INTEGER_TO_CONS.
6011 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6012 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6013 * data.c (long_to_cons, cons_to_long): Remove.
6014 (cons_to_unsigned, cons_to_signed): New functions.
6015 These signal an error for invalid or out-of-range values.
6016 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6017 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6018 * font.c (Ffont_variation_glyphs):
6019 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6020 * lisp.h: Include <intprops.h>.
6021 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6022 (cons_to_signed, cons_to_unsigned): New decls.
6023 (long_to_cons, cons_to_long): Remove decls.
6024 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6025 (Fprimitive_undo): Use CONS_TO_INTEGER.
6026 * xfns.c (Fx_window_property): Likewise.
6027 * xselect.c: Include <limits.h>.
6028 (x_own_selection, selection_data_to_lisp_data):
6029 Use INTEGER_TO_CONS.
6030 (x_handle_selection_request, x_handle_selection_clear)
6031 (x_get_foreign_selection, Fx_disown_selection_internal)
6032 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6033 (lisp_data_to_selection_data): Use cons_to_unsigned.
6034 (x_fill_property_data): Use cons_to_signed.
6035 Report values out of range.
6036
d1f3d2af
PE
6037 Check for buffer and string overflow more precisely.
6038 * buffer.h (BUF_BYTES_MAX): New macro.
6039 * lisp.h (STRING_BYTES_MAX): New macro.
6040 * alloc.c (Fmake_string):
6041 * character.c (string_escape_byte8):
6042 * coding.c (coding_alloc_by_realloc):
6043 * doprnt.c (doprnt):
6044 * editfns.c (Fformat):
6045 * eval.c (verror):
6046 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6047 since they may not be the same number.
6048 * editfns.c (Finsert_char):
6049 * fileio.c (Finsert_file_contents):
6050 Likewise for BUF_BYTES_MAX.
6051
dd52fcea
PE
6052 * image.c: Use ptrdiff_t, not int, for sizes.
6053 (slurp_file): Switch from int to ptrdiff_t.
6054 All uses changed.
6055 (slurp_file): Check that file size fits in both size_t (for
6056 malloc) and ptrdiff_t (for sanity and safety).
6057
7f9bbdbb
PE
6058 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6059 if b->modtime has its maximal value.
6060
dfe18f82
PE
6061 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6062
84acfcf0
PE
6063 Don't assume time_t can fit into int.
6064 * buffer.h (struct buffer.modtime): Now time_t, not int.
6065 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6066 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6067
ccd9a01a
PE
6068 Minor fixes for signed vs unsigned integers.
6069 * character.h (MAYBE_UNIFY_CHAR):
6070 * charset.c (maybe_unify_char):
6071 * keyboard.c (read_char, reorder_modifiers):
6072 XINT -> XFASTINT, since the integer must be nonnegative.
6073 * ftfont.c (ftfont_spec_pattern):
6074 * keymap.c (access_keymap, silly_event_symbol_error):
6075 XUINT -> XFASTINT, since the integer must be nonnegative.
6076 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6077 since it makes no difference and we prefer signed.
6078 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6079 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6080 nonnegative.
6081
d6d100dd
SM
60822011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6083
6084 * window.h (Fwindow_frame): Declare.
6085
2b6148e4
PE
60862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6087
6088 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6089 (SPARE_MEMORY): Always define.
6090 (LARGE_REQUEST): Remove.
6091 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6092
f230ecc9
MR
60932011-06-06 Martin Rudalics <rudalics@gmx.at>
6094
727e958e
MR
6095 * lisp.h: Move EXFUNS for Fframe_root_window,
6096 Fframe_first_window and Fset_frame_selected_window to window.h.
6097
6098 * window.h: Move EXFUNS for Fframe_root_window,
6099 Fframe_first_window and Fset_frame_selected_window here from
6100 lisp.h.
6101
6102 * frame.c (Fwindow_frame, Fframe_first_window)
6103 (Fframe_root_window, Fframe_selected_window)
6104 (Fset_frame_selected_window): Move to window.c.
6105 (Factive_minibuffer_window): Move to minibuf.c.
6106 (Fother_visible_frames_p): New function.
6107
6108 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6109
f230ecc9
MR
6110 * window.c (decode_window, decode_any_window): Move up in code.
6111 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6112 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6113 (Fwindow_buffer): Move up and rewrite doc-string.
6114 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6115 (Fwindow_prev): New functions.
727e958e
MR
6116 (Fwindow_frame): Move here from frame.c. Accept any window as
6117 argument.
6118 (Fframe_root_window, Fframe_first_window)
6119 (Fframe_selected_window): Move here from frame.c. Accept frame
6120 or arbitrary window as argument. Update doc-strings.
6121 (Fminibuffer_window): Move up in code.
6122 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6123 (Fset_frame_selected_window): Move here from frame.c.
6124 Marginal rewrite.
727e958e
MR
6125 (Fselected_window, select_window, Fselect_window): Move up in
6126 code. Minor doc-string fixes.
f230ecc9 6127
4d09bcf6
PE
61282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6129
6130 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6131 Do not assume that spare memory exists; that assumption is valid
6132 only if SYSTEM_MALLOC.
6133 (LARGE_REQUEST): New macro, so that the issue of large requests
6134 is separated from the issue of spare memory.
6135
810928a2
AS
61362011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6137
172418ad
AS
6138 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6139 format. (Bug#8806)
6140
43f862f7
AS
6141 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6142
810928a2
AS
6143 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6144 before statements.
6145
a059fe24
JD
61462011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6147
6148 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6149
6150 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6151
6152 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6153 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6154
989bf368
JB
61552011-06-05 Juanma Barranquero <lekktu@gmail.com>
6156
6157 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6158
4b80f674
CY
61592011-06-04 Chong Yidong <cyd@stupidchicken.com>
6160
6161 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6162 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6163 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6164 New error handlers.
4b80f674
CY
6165 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6166 Obey Vx_select_enable_clipboard_manager. Catch errors in
6167 x_clipboard_manager_save (Bug#8779).
6168 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6169 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6170
99a33b77 61712011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6172
6173 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6174
99a33b77 61752011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6176
6177 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6178 in the current matrix if keep_current_p is non-zero.
6179
8264569d
EZ
61802011-06-04 Eli Zaretskii <eliz@gnu.org>
6181
6182 * bidi.c (bidi_level_of_next_char): Fix last change.
6183
57f97249
EZ
61842011-06-03 Eli Zaretskii <eliz@gnu.org>
6185
fec2107c 6186 Support bidi reordering of text covered by display properties.
57f97249 6187
fec2107c
EZ
6188 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6189 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6190 (bidi_cache_search, bidi_cache_iterator_state)
6191 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6192 (bidi_level_of_next_char, bidi_move_to_visually_next):
6193 Support character positions inside a run of characters covered by a
fec2107c
EZ
6194 display string.
6195 (bidi_paragraph_init, bidi_resolve_explicit_1)
6196 (bidi_level_of_next_char): Call bidi_fetch_char and
6197 bidi_fetch_char_advance instead of FETCH_CHAR and
6198 FETCH_CHAR_ADVANCE.
6199 (bidi_init_it): Initialize new members.
6200 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6201 definitions.
6202 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6203 instead of using explicit *_CHAR codes.
d6d100dd
SM
6204 (bidi_resolve_explicit, bidi_resolve_weak):
6205 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6206 bidirectional text is supported only in multibyte buffers.
6207 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6208 it to initialize the frame_window_p member of struct bidi_it.
6209 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6210 (bidi_resolve_explicit, bidi_resolve_weak)
6211 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6212 bidi_it->nchars is non-positive.
6213 (bidi_level_of_next_char): Don't try to lookup the cache for the
6214 next/previous character if nothing is cached there yet, or if we
6215 were just reseat()'ed to a new position.
c40e2fb2 6216
0e14fe90
EZ
6217 * xdisp.c (set_cursor_from_row): Set start and stop points
6218 according to the row's direction when priming the loop that looks
6219 for the glyph on which to display cursor.
6220 (single_display_spec_intangible_p): Function deleted.
6221 (display_prop_intangible_p): Reimplement to call
6222 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6223 Accept 3 additional arguments needed by handle_display_spec.
6224 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6225 values: lists, `(when COND...)' forms, etc.
6226 (single_display_spec_string_p): Support property values that are
6227 lists with the argument STRING its top-level element.
6228 (display_prop_string_p): Fix the condition for processing a
6229 property that is a list to be consistent with handle_display_spec.
fec2107c 6230 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6231 last portion of handle_display_prop.
6232 (compute_display_string_pos): Accept additional argument
6233 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6234 value of a `display' property is a "replacing spec".
6235 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6236 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6237 the display property, but just return a value indicating whether
6238 the display property will replace the characters it covers.
6239 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6240 frame_window_p members of struct bidi_it.
d6d100dd
SM
6241 (compute_display_string_pos, compute_display_string_end):
6242 New functions.
fec2107c
EZ
6243 (push_it): Accept second argument POSITION, where pop_it should
6244 jump to continue iteration.
6245 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6246
fec2107c
EZ
6247 * keyboard.c (adjust_point_for_property): Adjust the call to
6248 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6249
6250 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6251 (bidi_init_it): Update prototypes.
6252 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6253 (compute_display_string_pos, compute_display_string_end):
6254 Declare prototypes.
fec2107c
EZ
6255 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6256 EMACS_INT.
fc6f18ce 6257
40087514 62582011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6259
57f53182
PE
6260 Malloc failure behavior now depends on size of allocation.
6261 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6262 * lisp.h: Change signatures accordingly.
6263 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6264 All callers changed. (Bug#8762)
6265
6266 * gnutls.c: Use Emacs's memory allocators.
6267 Without this change, the gnutls library would invoke malloc etc.
6268 directly, which causes problems on non-SYNC_INPUT hosts, and which
6269 runs afoul of improving memory_full behavior. (Bug#8761)
6270 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6271 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6272 xfree instead of the default malloc, realloc, free.
6273 (Fgnutls_boot): No need to check for memory allocation failure,
6274 since xmalloc does that for us.
6275
ac32cd99 6276 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6277 * category.c (hash_get_category_set):
6278 * ccl.c (ccl_driver):
6279 * charset.c (Fdefine_charset_internal):
6280 * charset.h (struct charset.hash_index):
6281 * composite.c (get_composition_id, gstring_lookup_cache)
6282 (composition_gstring_put_cache):
6283 * composite.h (struct composition.hash_index):
6284 * dispextern.h (struct image.hash):
6285 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6286 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6287 (hashfn_equal, hashfn_user_defined, make_hash_table)
6288 (maybe_resize_hash_table, hash_lookup, hash_put)
6289 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6290 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6291 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6292 * image.c (make_image, search_image_cache, lookup_image)
6293 (xpm_put_color_table_h):
6294 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6295 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6296 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6297 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6298 * alloc.c (allocate_vectorlike):
6299 Check for overflow in vector size calculations.
6300 * ccl.c (ccl_driver):
6301 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6302 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6303 need to be updated by these changes.
40087514
PE
6304 * fns.c (make_hash_table, maybe_resize_hash_table):
6305 Check for integer overflow with large hash tables.
0de4bb68
PE
6306 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6307 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6308 (SXHASH_REDUCE): New macro.
6309 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6310 Use it instead of discarding useful hash info with large hash values.
6311 (sxhash_float): New function.
6312 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6313 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6314 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6315 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6316 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6317 Adjust signatures to match updated version of code.
6318 (consing_since_gc): Now EMACS_INT, since a single hash table can
6319 use more than INT_MAX bytes.
6320
698d32e2
DN
63212011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6322
6323 Make it possible to build with GCC-4.6+ -O2 -flto.
6324
6325 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6326
fd6fa53f
SM
63272011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6328
6329 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6330 Call minibuffer-inactive-mode.
6331
864db017
JB
63322011-05-31 Juanma Barranquero <lekktu@gmail.com>
6333
6334 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6335 Update dependencies.
6336
2ad0baf4
DN
63372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6338
6339 * data.c (init_data): Remove code for UTS, this system is not
6340 supported anymore.
6341
4fcc2638
DN
63422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6343
6344 Don't force ./temacs to start in terminal mode.
6345
6346 * frame.c (make_initial_frame): Initialize faces in all cases, not
6347 only when CANNOT_DUMP is defined.
6348 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6349
c56e0fd5
DN
63502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6351
6352 * dispnew.c (add_window_display_history): Use const for the string
6353 pointer. Remove declaration, not needed.
6354
333d54da 63552011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6356
55d4c1b2 6357 Use 'inline', not 'INLINE'.
333d54da 6358 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6359 * alloc.c, fontset.c (INLINE): Remove.
6360 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6361 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6362 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6363 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6364 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6365
738db178
DN
63662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6367
6368 Make it possible to run ./temacs.
6369
6370 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6371 syms_of_callproc does the same thing. Remove test for
6372 "initialized", do it in the caller.
6373 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6374
620c53a6
SM
63752011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6376
6377 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6378 (read_minibuf): Use get_minibuffer.
6379 (syms_of_minibuf): Use DEFSYM.
6380 (Qmetadata): New var.
6381 * data.c (Qbuffer): Don't make it static.
6382 (syms_of_data): Use DEFSYM.
6383
e003a292
PE
63842011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6385
6386 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6387 (CCL_CODE_MIN): New macro.
6388
ed008a6d
PE
63892011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6390
3687c2ef
PE
6391 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6392
ed008a6d
PE
6393 * eval.c (Qdebug): Now static.
6394 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6395 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6396 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6397
d66c4c7c
CY
63982011-05-29 Chong Yidong <cyd@stupidchicken.com>
6399
6400 * image.c: Various fixes to ImageMagick code comments.
6401 (Fimagemagick_types): Doc fix.
6402
5fbc2025
PE
64032011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6404
0196f88a
PE
6405 Minor fixes prompted by GCC 4.6.0 warnings.
6406
6407 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6408
5fbc2025
PE
6409 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6410 (x_clipboard_manager_save_all): Move extern decl to ...
6411 * xterm.h: ... here, so that it can be checked for consistency.
6412
1dd3c2d9
CY
64132011-05-29 Chong Yidong <cyd@stupidchicken.com>
6414
6415 * xselect.c (x_clipboard_manager_save_frame)
6416 (x_clipboard_manager_save_all): New functions.
6417 (Fx_clipboard_manager_save): Lisp function deleted.
6418
6419 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6420 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6421
6422 * xterm.h: Update prototype.
6423
5ba6571d
WX
64242011-05-28 William Xu <william.xwl@gmail.com>
6425
6426 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6427 exiting (Bug#8239).
6428
3eaff834
JM
64292011-05-28 Jim Meyering <meyering@redhat.com>
6430
e1900994 6431 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6432 * fns.c (to_uchar): Define.
6433 (crypto_hash_function): Use it to convert some newly-signed
6434 variables to unsigned, to avoid sign-extension bugs. For example,
6435 without this change, (md5 "truc") would evaluate to
6436 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6437 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6438 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6439
0f6990a7
PE
64402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6441
6442 Integer overflow fixes.
c8a9ca5a 6443
08686060
PE
6444 * dbusbind.c: Serial number integer overflow fixes.
6445 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6446 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6447 to hold a serial number that is too large for a fixnum.
6448 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6449 Check for serial numbers out of range. Decode any serial number
59568bf0 6450 that was so large that it became a float. (Bug#8722)
08686060 6451
2d1fc3c7
PE
6452 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6453 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6454 Use XFASTINT rather than XUINT when numbers are nonnegative.
6455 (xd_append_arg, Fdbus_method_return_internal):
6456 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6457 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6458 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6459 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6460 (Bug#8722)
2d1fc3c7 6461
c8a9ca5a
PE
6462 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6463
519e1d69
PE
6464 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6465
6df6ae42 6466 ccl: Add integer overflow checks.
30569699
PE
6467 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6468 (IN_INT_RANGE): New macros.
6469 (ccl_driver): Use them to check for integer overflow when
6470 decoding a CCL program. Many of the new checks are whether XINT (x)
6471 fits in int; it doesn't always, on 64-bit hosts. The new version
6472 doesn't catch all possible integer overflows, but it's an
847044ea 6473 improvement. (Bug#8719)
30569699 6474
c11285dc
PE
6475 * alloc.c (make_event_array): Use XINT, not XUINT.
6476 There's no need for unsigned here.
6477
fdccd48e
PE
6478 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6479 This follows up to the 2011-05-06 change that substituted uintptr_t
6480 for EMACS_INT. This case wasn't caught back then.
6481
37910ab2
PE
6482 Rework Fformat to avoid integer overflow issues.
6483 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6484 now (part of C89). Include <verify.h>.
6485 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6486 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6487 (Fformat): Avoid the prepass trying to compute sizes; it was only
6488 approximate and thus did not catch overflow reliably. Instead, walk
6489 through the format just once, formatting and computing sizes as we go,
6490 checking for integer overflow at every step, and allocating a larger
6491 buffer as needed. Keep track separately whether the format is
6492 multibyte. Keep only the most-recently calculated precision, rather
6493 than them all. Record whether each argument has been converted to
6494 string. Use EMACS_INT, not int, for byte and char and arg counts.
6495 Support field widths and precisions larger than INT_MAX. Avoid
6496 sprintf's undefined behavior with conversion specifications such as %#d
6497 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6498 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6499 formatting out-of-range floating point numbers with int
9173deec 6500 formats. (Bug#8668)
37910ab2 6501
2e6578fb
PE
6502 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6503
0ae6bdee
PE
6504 * data.c: Avoid integer truncation in expressions involving floats.
6505 * data.c: Include <intprops.h>.
6506 (arith_driver): When there's an integer overflow in an expression
6507 involving floating point, convert the integers to floating point
6508 so that the resulting value does not suffer from catastrophic
6509 integer truncation. For example, on a 64-bit host (* 4
6510 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6511 Do not rely on undefined behavior after integer overflow.
6512
de883a70
PE
6513 merge count_size_as_multibyte, parse_str_to_multibyte
6514 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6515 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6516 Check for integer overflow.
6517 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6518 since it's now a duplicate of the other. This is more of
6519 a character than a buffer op, so better that it's in character.c.
6520 * fns.c, print.c: Adjust to above changes.
6521
2ff916cb
PE
65222011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6523
6524 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6525
f1b54466
PE
65262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6527
fb1ac845
PE
6528 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6529 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6530 (x_clipboard_manager_save): Now static.
6531 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6532
f1b54466
PE
6533 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6534 (crypto_hash_function): Now static.
6535 Fix pointer signedness problems. Avoid unnecessary initializations.
6536
a9f737ee
CY
65372011-05-27 Chong Yidong <cyd@stupidchicken.com>
6538
6539 * termhooks.h (Vselection_alist): Make it terminal-local.
6540
6541 * terminal.c (create_terminal): Initialize it.
6542
6543 * xselect.c: Support for clipboard managers.
6544 (Vselection_alist): Move to termhooks.h as terminal-local var.
6545 (LOCAL_SELECTION): New macro.
6546 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6547 (symbol_to_x_atom): Remove gratuitous arg.
6548 (x_handle_selection_request, lisp_data_to_selection_data)
6549 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6550 (x_own_selection, x_get_local_selection, x_convert_selection):
6551 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6552 (some_frame_on_display): Delete unused function.
6553 (Fx_own_selection_internal, Fx_get_selection_internal)
6554 (Fx_disown_selection_internal, Fx_selection_owner_p)
6555 (Fx_selection_exists_p): New optional frame arg.
6556 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6557 (x_handle_selection_clear): Don't treat other terminals with the
6558 same keyboard specially. Use the terminal-local Vselection_alist.
6559 (x_clear_frame_selections): Use Frun_hook_with_args.
6560
6561 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6562
6563 * xterm.h: Add support for those atoms.
6564
e067f0c1
CY
65652011-05-26 Chong Yidong <cyd@stupidchicken.com>
6566
6567 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6568 (converted_selections, conversion_fail_tag): New global variables.
6569 (x_selection_request_lisp_error): Free the above.
6570 (x_get_local_selection): Remove unnecessary code.
6571 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6572 of converted selections stored in converted_selections.
6573 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6574 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6575 (x_convert_selection): New function.
6576 (x_handle_selection_event): Simplify.
6577 (x_get_foreign_selection): Don't ignore incoming requests while
6578 waiting for an answer; this will fail when we implement
6579 SAVE_TARGETS, and seems unnecessary anyway.
6580 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6581 (Vx_sent_selection_functions): Doc fix.
6582
0f4aebc0
LL
65832011-05-26 Leo Liu <sdl.web@gmail.com>
6584
6585 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6586
e61124cd
YM
65872011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6588
6589 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6590
6591 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6592 for fringe update if it has periodic bitmap.
ac389d0c 6593 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6594 and fringe_bitmap_periodic_p.
6595
6596 * fringe.c (get_fringe_bitmap_data): New function.
6597 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6598 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6599 row. Mark glyph row for fringe update if periodicity changed.
6600
6601 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6602 for fringe update unless it has periodic bitmap.
6603
f16d9837
KH
66042011-05-25 Kenichi Handa <handa@m17n.org>
6605
6606 * xdisp.c (get_next_display_element): Set correct it->face_id for
6607 a static composition.
6608
e1b90ef6
LL
66092011-05-24 Leo Liu <sdl.web@gmail.com>
6610
6611 * deps.mk (fns.o):
6612 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6613
6614 * fns.c (crypto_hash_function, Fsha1): New function.
6615 (Fmd5): Use crypto_hash_function.
6616 (syms_of_fns): Add Ssha1.
6617
7400048f
PE
66182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6619
6620 * gnutls.c: Remove unused macros.
6621 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6622 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6623 Remove macros that are defined and never used.
6624 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6625
abb71cf4
CY
66262011-05-22 Chong Yidong <cyd@stupidchicken.com>
6627
6628 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6629 (Fx_get_selection_internal): Minor cleanup.
6630 (Fx_own_selection_internal): Rename arguments for consistency with
6631 select.el.
6632
6307db39
PE
66332011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6634
6635 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6636
f3d4e0a4
CY
66372011-05-22 Chong Yidong <cyd@stupidchicken.com>
6638
6639 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6640
4d8ade89
YM
66412011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6642
6643 * dispnew.c (scrolling_window): Don't exclude the case that the
6644 last enabled row in the desired matrix touches the bottom boundary.
6645
32078c8d
GM
66462011-05-21 Glenn Morris <rgm@gnu.org>
6647
6648 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6649 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6650 and add some more files.
32078c8d 6651
7285dc67
EZ
66522011-05-20 Eli Zaretskii <eliz@gnu.org>
6653
6654 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6655 report_file_error introduced by the change from 2011-05-07.
6656
89d1bd22
PE
66572011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6658
6659 * systime.h (Time): Define only if emacs is defined.
6660 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6661 where the include path doesn't have X11/X.h by default. See
6662 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6663
cd394be1 66642011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6665
6666 * composite.c (find_automatic_composition): Fix previous change.
6667
b9704ad9
GM
66682011-05-20 Glenn Morris <rgm@gnu.org>
6669
6670 * lisp.mk: New file, split from Makefile.in.
6671 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6672 (shortlisp): Remove.
6673 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6674
4a720484
GM
66752011-05-19 Glenn Morris <rgm@gnu.org>
6676
6677 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6678 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6679 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6680 (lisp): Set the order to that of loadup.el.
6681 (shortlisp): Make it a copy of $lisp.
6682 (SOME_MACHINE_LISP): Remove.
6683 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6684 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6685
a28d4396
KH
66862011-05-18 Kenichi Handa <handa@m17n.org>
6687
6688 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6689 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6690 (find_automatic_composition): Mostly rewrite for efficiency.
6691
a2b1fa8e
JB
66922011-05-18 Juanma Barranquero <lekktu@gmail.com>
6693
6694 * makefile.w32-in: Update dependencies.
6695
8e1f5610
CS
66962011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6697
6698 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6699 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6700
7025ee00 67012011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6702
cdfa6eab
PE
6703 Fix some integer overflow issues, such as string length overflow.
6704
06d6db33
PE
6705 * insdel.c (count_size_as_multibyte): Check for string overflow.
6706
2b4560a8
PE
6707 * character.c (lisp_string_width): Check for string overflow.
6708 Use EMACS_INT, not int, for string indexes and lengths; in
6709 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6710 the resulting string length overflows an EMACS_INT; instead,
6711 report a string overflow if no precision given. When checking for
6712 precision exhaustion, use a check that cannot possibly have
6713 integer overflow. (Bug#8675)
6714 * character.h (lisp_string_width): Adjust to new signature.
6715
cb93f9be
PE
6716 * alloc.c (string_overflow): New function.
6717 (Fmake_string): Use it. This doesn't change behavior, but saves
6718 a few bytes and will simplify future changes.
6719 * character.c (string_escape_byte8): Likewise.
6720 * lisp.h (string_overflow): New decl.
6721
1a1f3366
PE
6722 Fixups, following up to the user-interface timestamp change.
6723 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6724 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6725 * msdos.c (mouse_get_pos): Likewise.
6726 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6727 * w32gui.h (Time): Define by including "systime.h" rather than by
6728 declaring it ourselves. (Bug#8664)
6729
d4e3e4d3
PE
6730 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6731 * image.c (clear_image_cache): Likewise.
6732
f6a24d19
PE
6733 * term.c (term_mouse_position): Don't assume time_t wraparound.
6734
08dc5ae6
PE
6735 Be more systematic about user-interface timestamps.
6736 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6737 and sometimes 'EMACS_UINT', to represent these timestamps.
6738 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6739 This makes the code easier to follow, and makes it easier to catch
6740 integer overflow bugs such as Bug#8664.
6741 * frame.c (Fmouse_position, Fmouse_pixel_position):
6742 Use Time, not unsigned long, for user-interface timestamps.
6743 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6744 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6745 * keyboard.h (last_event_timestamp): Likewise.
6746 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6747 * menu.h (xmenu_show): Likewise.
6748 * term.c (term_mouse_position): Likewise.
6749 * termhooks.h (struct input_event.timestamp): Likewise.
6750 (struct terminal.mouse_position_hook): Likewise.
6751 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6752 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6753 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6754 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6755 what it was before.
6756 * menu.h, termhooks.h: Include "systime.h", for Time.
6757
8e55734a
PE
6758 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6759 Don't assume that the difference between two unsigned long values
6760 can fit into an integer. At this point, we know button_down_time
6761 <= event->timestamp, so the difference must be nonnegative, so
6762 there's no need to cast the result if double-click-time is
6763 nonnegative, as it should be; check that it's nonnegative, just in
6764 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6765 apart (about 25 days). (Bug#8664)
8e55734a 6766
841f1b75 6767 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6768 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6769
3e26f69c
PE
6770 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6771 that always fit in int. Use a sentinel instead of a counter, to
6772 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6773 * frame.h (struct frame): Use int for menu_bar_items_used
6774 instead of EMACS_INT, since it always fits in int.
3e26f69c 6775
5cc152c0
PE
6776 * menu.c (grow_menu_items): Check for int overflow.
6777
d89eb65e
PE
6778 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6779
5235bd3e
PE
6780 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6781 Before, the code was not consistent. These values cannot exceed
6782 2**31 - 1 so there's no need to make them unsigned.
6783 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6784 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6785 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6786 as modifiers.
6787 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6788
bc827e23
PE
6789 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6790 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6791 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6792 presumably because the widths might not match.
6793
78eb494e
PE
6794 * window.c (size_window): Avoid needless test at loop start.
6795
04f2d78b
CB
67962011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6797
6798 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6799
d2fc7e3d 68002011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6801
6802 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6803
d2fc7e3d 68042011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6805
6806 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6807 `width' to `bar_area_x' and `bar_area_width', respectively.
6808 (x_scroll_run): Take account of fringe background extension.
6809
04f2d78b
CB
6810 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6811 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6812 `bar_area_width', respectively.
6813 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6814 background extension.
6815
79b70037
GM
68162011-05-10 Jim Meyering <meyering@redhat.com>
6817
6818 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6819
2f142cc5
JB
68202011-05-10 Juanma Barranquero <lekktu@gmail.com>
6821
6822 * image.c (Finit_image_library): Return t for built-in image types,
6823 like pbm and xbm. (Bug#8640)
6824
57679c86
AS
68252011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6826
6827 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6828
888c9e86
EZ
68292011-05-07 Eli Zaretskii <eliz@gnu.org>
6830
b0512a1d
EZ
6831 * w32console.c (Fset_screen_color): Doc fix.
6832 (Fget_screen_color): New function.
6833 (syms_of_ntterm): Defsubr it.
6834
7285dc67
EZ
6835 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6836 unlink the temporary file if Fcall_process didn't create it in the
6837 first place.
6838 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6839 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6840 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6841 cue to call_process_cleanup not to close that handle.
6842
4d3fcc8e
BK
68432011-05-07 Ben Key <bkey76@gmail.com>
6844
6845 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6846 one of two shell specific rules, either bootstrap-temacs-CMD or
6847 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6848 to the previous implementation of the bootstrap-temacs rule.
6849 The bootstrap-temacs-CMD rule is similar to the previous
6850 implementation of the bootstrap-temacs rule except that it
6851 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6852 variable.
6853
6854 These changes, along with some changes to nt/configure.bat,
6855 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6856 earlier fix to add support for --cflags and --ldflags options
6857 that include quotes so that it works whether make uses cmd or
6858 sh as the shell.
6859
b4289b64
MA
68602011-05-06 Michael Albinus <michael.albinus@gmx.de>
6861
6862 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6863 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6864 is a constant.
6865 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6866 a string. Handle both cases.
6867 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6868 (Fdbus_register_method): Use Qinvalid_function.
6869
af4c0e28
JB
68702011-05-06 Juanma Barranquero <lekktu@gmail.com>
6871
6872 * makefile.w32-in: Update dependencies.
6873 (LISP_H): Add inttypes.h and stdin.h.
6874 (PROCESS_H): Add unistd.h.
6875
c51453d9
EZ
68762011-05-06 Eli Zaretskii <eliz@gnu.org>
6877
6878 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6879 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6880
8ff0ac3c 68812011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6882
4c4b566b
PE
6883 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6884
aab2b9b5
PE
6885 * term.c (vfatal): Remove stray call to va_end.
6886 It's not needed and the C Standard doesn't allow it here anyway.
6887
c378da0b
PE
6888 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6889 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6890
288b08c7
PE
6891 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6892 bytes.
6893
e3601888
PE
6894 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6895
db6c0e74
PE
6896 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6897
dd5963ea
PE
6898 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6899
88c9450f
PE
6900 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6901
2f9442b8
PE
6902 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6903
c032b5f8
PE
6904 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6905 * charset.c (Fdefine_charset_internal): Don't initialize
6906 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6907 32-bit int (Bug#8600).
a108c10b
PE
6908
6909 * lread.c (read_integer): Be more consistent with string-to-number.
6910 Use string_to_number to do the actual conversion; this avoids
6911 rounding errors and fixes some other screwups. Without this fix,
6912 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6913 (digit_to_number): Move earlier, for benefit of read_integer.
6914 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6915 not a digit in any supported base. (Bug#8602)
a108c10b 6916
ad5f9eea
PE
6917 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6918
aec1708a
PE
6919 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6920 to match comment at start of function. This also removes a
6921 GCC warning about overflow in a 32+64-bit port.
6922
47be4ab5
PE
6923 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6924
371cac43
PE
6925 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6926 Reported by Stefan Monnier in
6927 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6928 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6929 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6930
d01a7826
PE
6931 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6932 (EMACS_UINTPTR): Likewise, with uintptr_t.
6933
7fd47d5c
PE
6934 * lisp.h: Prefer 64-bit EMACS_INT if available.
6935 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6936 on 32-bit hosts that have 64-bit int, so that they can access
6937 large files.
122b0c86
PE
6938 However, temporarily disable this change unless the temporary
6939 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6940
8727937b
PE
6941 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6942
8ac068ac
PE
6943 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6944 This removes an assumption that EMACS_INT and long are the same
6945 width as pointers. The assumption is true for Emacs porting targets
6946 now, but we want to make other targets possible.
6947 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6948 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6949 In the rest of the code, change types of integers that hold casted
6950 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6951 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6952 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6953 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6954 No need to cast type when ORing.
6955 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6956 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6957 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6958 assume EMACS_INT is the same width as char *.
6959 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6960 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6961 Remove no-longer-needed casts.
6962 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6963 (xg_tool_bar_help_callback, xg_make_tool_item):
6964 Use EMACS_INTPTR to hold an integer
6965 that will be cast to void *; this can avoid a GCC warning
6966 if EMACS_INT is not the same width as void *.
6967 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6968 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6969 (current_message_1, set_message_1):
6970 Use a local to convert to proper width without a cast.
6971 * xmenu.c (dialog_selection_callback): Likewise.
6972
ede49d71
PE
6973 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6974 Also, don't assume VALBITS / RAND_BITS is less than 5,
6975 and don't rely on undefined behavior when shifting a 1 left into
6976 the sign bit.
6977 * lisp.h (get_random): Change signature to match.
6978
2f30ecd0
PE
6979 * lread.c (hash_string): Use size_t, not int, for hash computation.
6980 Normally we prefer signed values; but hashing is special, because
6981 it's better to use unsigned division on hash table sizes so that
6982 the remainder is nonnegative. Also, size_t is the natural width
6983 for hashing into memory. The previous code used 'int', which doesn't
6984 retain enough info to hash well into very large tables.
6985 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6986
2a866e7b
PE
6987 * dbusbind.c: Don't possibly lose pointer info when converting.
6988 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6989 Use XPNTR rather than XHASH, so that the high-order bits of
6990 the pointer aren't lost when converting through void *.
6991
51639eac
PE
6992 * eval.c (Fautoload): Don't double-shift a pointer.
6993
92394119
PE
6994 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6995
dbdb9a7c
JB
69962011-05-06 Juanma Barranquero <lekktu@gmail.com>
6997
6998 * gnutls.c (DEF_GNUTLS_FN):
6999 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7000
db7a0b4f
AS
70012011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7002
7003 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7004 marker. (Bug#8610)
7005
cd394be1 70062011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7007
7008 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7009 New version that can reserve upto 2GB of heap space.
7010
f7ff1b0f 70112011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7012
7013 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7014
639c109b
TZ
70152011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7016
7017 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7018 `gnutls_certificate_set_x509_key_file'.
7019
d2127135
JB
70202011-05-05 Juanma Barranquero <lekktu@gmail.com>
7021
7022 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7023 Update dependencies.
7024
e968f4f3
JB
70252011-05-04 Juanma Barranquero <lekktu@gmail.com>
7026
7027 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7028 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7029 Remove unused parameter `fildes'.
7030 * process.c (read_process_output, send_process): Don't pass it.
7031
84d358f0
JB
70322011-05-04 Juanma Barranquero <lekktu@gmail.com>
7033
7034 Fix previous change: the library cache is defined in w32.c.
7035 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7036 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7037
0898ca10
JB
70382011-05-04 Juanma Barranquero <lekktu@gmail.com>
7039
7040 Implement dynamic loading of GnuTLS on Windows.
7041
7042 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7043 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7044 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7045 Declare.
7046
7047 * gnutls.c (Qgnutls_dll): Define.
7048 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7049 (gnutls_*): Declare function pointers.
7050 (init_gnutls_functions): New function to initialize function pointers.
7051 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7052 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7053 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7054 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7055 (emacs_gnutls_write, emacs_gnutls_read)
7056 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7057 (Fgnutls_available_p): New function.
7058 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7059 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7060 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7061
7062 * image.c: Include w32.h.
7063 (Vimage_type_cache): Delete.
7064 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7065 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7066 (w32_delayed_load): Move to w32.c.
7067
7068 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7069
7070 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7071 (w32_delayed_load): Move from image.c. When loading a library, record
7072 its filename in the :loaded-from property of the library id.
7073 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7074 Initialize and staticpro them.
7075 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7076
7077 * process.c: Include lisp.h before w32.h, not after.
7078 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7079 instead of gnutls_record_check_pending.
7080
7081 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7082
ff4de4aa
TZ
70832011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7084
7085 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7086 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7087 as passed in.
7088
abe95abb
JD
70892011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7090
7091 * xterm.c (x_set_frame_alpha): Do not set property on anything
7092 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7093
e16e55d4
JB
70942011-05-02 Juanma Barranquero <lekktu@gmail.com>
7095
7096 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7097
bafcf6a5
JB
70982011-05-02 Juanma Barranquero <lekktu@gmail.com>
7099
7100 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7101 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7102 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7103 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7104 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7105 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7106 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7107 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7108 (Qgnutls_bootprop_callbacks_verify): Make static.
7109
e7a6747f
AS
71102011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7111
19ed11ba
AS
7112 * callproc.c: Indentation fixup.
7113
e7a6747f 7114 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7115 (wait_for_termination, interruptible_wait_for_termination):
7116 Move after wait_for_termination_1.
e7a6747f 7117
1ef14cb4
LMI
71182011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7119
7120 * sysdep.c (interruptible_wait_for_termination): New function
7121 which is like wait_for_termination, but allows keyboard
7122 interruptions.
7123
7124 * callproc.c (Fcall_process): Add (:file "file") as an option for
7125 the STDOUT buffer.
7126 (Fcall_process_region): Ditto.
7127
330d880c
EZ
71282011-04-30 Eli Zaretskii <eliz@gnu.org>
7129
8db90b73
EZ
7130 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7131 rather than `XVECTOR (FOO)->size'.
7132
330d880c
EZ
7133 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7134 inttypes.h, as a gnulib replacement is used if it not available in
7135 system headers.
7136
15cbd324
EZ
71372011-04-21 Eli Zaretskii <eliz@gnu.org>
7138
7139 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7140 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7141 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7142
7143 * coding.c (coding_alloc_by_realloc): Error out if destination
7144 will grow beyond MOST_POSITIVE_FIXNUM.
7145 (decode_coding_emacs_mule): Abort if there isn't enough place in
7146 charbuf for the composition carryover bytes. Reserve an extra
7147 space for up to 2 characters produced in a loop.
7148 (decode_coding_iso_2022): Abort if there isn't enough place in
7149 charbuf for the composition carryover bytes.
7150
71512011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7152
ae940cca
EZ
7153 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7154 aborting when %lld or %lll format is passed.
7155 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7156 %llo or %llx format is passed. (Bug#8545)
7157
03ab8921
EZ
7158 * window.c (window_scroll_line_based): Use a marker instead of
7159 simple variables to record original value of point. (Bug#7952)
7160
afda1437
EZ
7161 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7162 produced by %s or %c overflows available buffer space. (Bug#8545)
7163
f76dee0c
PE
71642011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7165
7166 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7167 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7168
fdc5744d
JB
71692011-04-28 Juanma Barranquero <lekktu@gmail.com>
7170
7171 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7172
638f053a
JB
71732011-04-28 Juanma Barranquero <lekktu@gmail.com>
7174
7175 * keyboard.c (Qdelayed_warnings_hook): Define.
7176 (command_loop_1): Run `delayed-warnings-hook'
7177 if Vdelayed_warnings_list is non-nil.
7178 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7179 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7180
d178f871
EZ
71812011-04-28 Eli Zaretskii <eliz@gnu.org>
7182
7183 * doprnt.c (doprnt): Don't return value smaller than the buffer
7184 size if the message was truncated. (Bug#8545).
7185
b124fd93
JB
71862011-04-28 Juanma Barranquero <lekktu@gmail.com>
7187
7188 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7189 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7190
e810457d
PE
71912011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7192
7193 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7194
ea51cceb
JB
71952011-04-27 Juanma Barranquero <lekktu@gmail.com>
7196
7197 * makefile.w32-in: Update dependencies.
7198
94dcfacf
EZ
71992011-04-27 Eli Zaretskii <eliz@gnu.org>
7200
7201 Improve `doprnt' and its usage. (Bug#8545)
7202 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7203 `format_end'. Remove support for %l as a conversion specifier.
7204 Don't use xrealloc. Improve diagnostics when the %l size modifier
7205 is used. Update the commentary.
7206
7207 * eval.c (verror): Simplify calculation of size_t.
7208
7209 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7210 messages.
7211
f61f41d7
PE
72122011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7213
7214 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7215 change.
7216
96fb4434
PE
72172011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7218
7219 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7220 This makes this file independent of the recent pseudovector change.
7221
671875da 72222011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7223
69e9b5a3
PE
7224 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7225
b5f869a7 7226 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7227 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7228 Remove unused local.
c8926152 7229 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7230
841a1577 7231 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7232 GCC 4.6.0 optimizes based on type-based alias analysis.
7233 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7234 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7235 != &v->size, and therefore "v->size = 1; b->size = 2; return
7236 v->size;" must therefore return 1. This assumption is incorrect
7237 for Emacs, since it type-puns struct Lisp_Vector * with many other
7238 types. To fix this problem, this patch adds a new type struct
f904488f 7239 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7240 and pseudovectors, and helps optimizing compilers not get fooled
7241 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7242 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7243 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7244 the size member.
eab3844f
PE
7245 (XSETPVECTYPE): Rewrite in terms of new macro.
7246 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7247 This is a bit clearer, and further avoids the possibility of
7248 undesirable aliasing.
7249 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7250 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7251 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7252 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7253 (ASIZE): Now uses header.size rather than size.
7254 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7255 to avoid the hassle of writing XVECTOR (foo)->header.size.
7256 (struct vectorlike_header): New type.
eab3844f
PE
7257 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7258 object, to help avoid aliasing.
7259 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7260 (SUBRP): Likewise, since Lisp_Subr is a special case.
7261 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7262 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7263 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7264 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7265 changed to be "header.size" and "header.next".
7266 * buffer.h (struct buffer): Likewise.
7267 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7268 * frame.h (struct frame): Likewise.
7269 * process.h (struct Lisp_Process): Likewise.
7270 * termhooks.h (struct terminal): Likewise.
7271 * window.c (struct save_window_data, struct saved_window): Likewise.
7272 * window.h (struct window): Likewise.
7273 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7274 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7275 * buffer.c (init_buffer_once): Likewise.
7276 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7277 special case.
7278 * process.c (Fformat_network_address): Use local var for size,
7279 for brevity.
7280
0df1eac5
PE
7281 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7282
847ab9d1 7283 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7284 * data.c (atof): Remove decl; no longer used or needed.
7285 (digit_to_number): Move to lread.c.
7286 (Fstring_to_number): Use new string_to_number function, to be
7287 consistent with how the Lisp reader treats infinities and NaNs.
7288 Do not assume that floating-point numbers represent EMACS_INT
7289 without losing information; this is not true on most 64-bit hosts.
7290 Avoid double-rounding errors, by insisting on integers when
7291 parsing non-base-10 numbers, as the documentation specifies.
7292 * lisp.h (string_to_number): New decl, replacing ...
7293 (isfloat_string): Remove.
bc0a5c13 7294 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7295 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7296 appears to have been a coding error. Similarly, do not accept
7297 strings like +-1e0 as floating point numbers. Do not report
7298 overflow for integer overflows unless the base is not 10 which
7299 means we have no simple and reliable way to continue.
7300 Break out the floating-point parsing into a new
7301 function string_to_number, so that Fstring_to_number parses
7302 floating point numbers consistently with the Lisp reader.
04f2d78b 7303 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7304 (E_CHAR, EXP_INT): Remove, replacing with ...
7305 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7306 (string_to_number): New function, replacing isfloat_string.
7307 This function checks for valid syntax and produces the resulting
7308 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7309 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7310 so that overflow for non-base-10 numbers is reported only when
7311 there's no portable and simple way to convert to floating point.
452f4150 7312
67769ffc
PE
7313 * textprop.c (set_text_properties_1): Rewrite for clarity,
7314 and to avoid GCC warning about integer overflow.
7315
c20db43f
PE
7316 * intervals.h (struct interval): Use EMACS_INT for members
7317 where EMACS_UINT might cause problems. See
7318 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7319 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7320 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7321 All uses changed.
37aa2f85
PE
7322 (offset_intervals): Tell GCC not to worry about length overflow
7323 when negating a negative length.
c20db43f 7324
2538aa2f
PE
7325 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7326 (overrun_check_free): Likewise.
7327
f2d3008d
PE
7328 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7329 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7330 word size.
7331
ec8df744
PE
7332 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7333 (gnutls_make_error): Rename local to avoid shadowing.
7334 (gnutls_emacs_global_deinit): ifdef out; not used.
7335 (Fgnutls_boot): Use const for pointer to readonly storage.
7336 Comment out unused local. Fix pointer signedness problems.
7337
640ee02d
PE
7338 * lread.c (openp): Don't stuff size_t into an 'int'.
7339 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7340 about possible signed overflow.
7341
6048fb2a
PE
7342 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7343 (GDK_KEY_g): Don't define if already defined.
7344 (xg_prepare_tooltip): Avoid pointer signedness problem.
7345 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7346
fa3c87e1
PE
7347 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7348 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7349
2172544b
PE
7350 * xfns.c (Fx_window_property): Simplify a bit,
7351 to make a bit faster and to avoid GCC 4.6.0 warning.
7352 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7353
9b821a21
PE
7354 * fns.c (internal_equal): Don't assume size_t fits in int.
7355
3c616cfa
PE
7356 * alloc.c (compact_small_strings): Tighten assertion a little.
7357
c2982e87
PE
7358 Replace pEd with more-general pI, and fix some printf arg casts.
7359 * lisp.h (pI): New macro, generalizing old pEd macro to other
7360 conversion specifiers. For example, use "...%"pI"d..." rather
7361 than "...%"pEd"...".
7362 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7363 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7364 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7365 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7366 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7367 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7368 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7369 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7370 64-bit hosts.
7371 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7372 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7373 * print.c (safe_debug_print, print_object): Likewise.
7374 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7375 to int.
6f04d126
PE
7376 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7377 avoiding the 0 flag, which is not portable.
c2982e87
PE
7378 * process.c (Fmake_network_process): Use pI to avoid cast.
7379 * region-cache.c (pp_cache): Likewise.
7380 * xdisp.c (decode_mode_spec): Likewise.
7381 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7382 behavior on 64-bit hosts with printf arg.
6f04d126 7383 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7384 (x_stop_queuing_selection_requests): Likewise.
7385 (x_get_window_property): Don't truncate byte count to an 'int'
7386 when tracing.
0b432f21 7387
5e073ec7
PE
7388 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7389 here, since it parses constructs like leading '-' and spaces,
7390 which are not wanted; and it overflows with large numbers.
7391 Instead, simply match F[0-9]+, which is what is wanted anyway.
7392
36372bf9
PE
7393 * alloc.c: Remove unportable assumptions about struct layout.
7394 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7395 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7396 (allocate_vectorlike, make_pure_vector): Use the new macros,
7397 plus offsetof, to remove unportable assumptions about struct layout.
7398 These assumptions hold on all porting targets that I know of, but
7399 they are not guaranteed, they're easy to remove, and removing them
7400 makes further changes easier.
7401
0b432f21
PE
7402 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7403 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7404 (string_overrun_cookie): Now const. Use initializers that
7405 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7406 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7407 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7408 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7409 multiple of sizeof (EMACS_INT); it need not be, if
7410 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7411 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7412
895009e1
JB
74132011-04-26 Juanma Barranquero <lekktu@gmail.com>
7414
7415 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7416
6a7a1b0b
TZ
74172011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7418
7419 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7420 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7421 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7422
841a1577 74232011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7424
7425 * lisp.h (Qdebug): List symbol.
895009e1 7426 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7427 * keyboard.c (debug-on-event): New variable.
7428 (handle_user_signal): Break into debugger when debug-on-event
7429 matches the current signal symbol.
7430
f2d3ba6f
DN
74312011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7432
7433 * alloc.c (check_sblock, check_string_bytes)
7434 (check_string_free_list): Convert to standard C.
7435
42ce4c63
TZ
74362011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7437
7438 * w32.c (emacs_gnutls_push): Fix typo.
7439
825cd63c
EZ
74402011-04-25 Eli Zaretskii <eliz@gnu.org>
7441
fb11d64d
EZ
7442 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7443 "cast to pointer from integer of different size".
7444
825cd63c
EZ
7445 Improve doprnt and its use in verror. (Bug#8545)
7446 * doprnt.c (doprnt): Document the set of format control sequences
7447 supported by the function. Use SAFE_ALLOCA instead of always
7448 using `alloca'.
7449
7450 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7451 is one byte too soon. Don't use xrealloc; instead xfree and
7452 xmalloc anew.
7453
e061a11b
TZ
74542011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7455
7456 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7457 callbacks stage.
7458
7459 * gnutls.c: Renamed global_initialized to
7460 gnutls_global_initialized. Added internals for the
7461 :verify-hostname-error, :verify-error, and :verify-flags
7462 parameters of `gnutls-boot' and documented those parameters in the
7463 docstring. Start callback support.
9173deec
JB
7464 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7465 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7466 on error. Return error code.
e061a11b
TZ
7467 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7468 (emacs_gnutls_read): Likewise.
7469 (Fgnutls_boot): Return handshake error code.
7470 (emacs_gnutls_handle_error): New function.
7471 (wsaerror_to_errno): Likewise.
7472
7473 * w32.h (emacs_gnutls_pull): Add prototype.
7474 (emacs_gnutls_push): Likewise.
7475
7476 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7477 (emacs_gnutls_push): Likewise.
7478
74792011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7480
7481 * process.c (wait_reading_process_output): Check if GnuTLS
7482 buffered some data internally if no FDs are set for TLS
7483 connections.
7484
7485 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7486 (LIBS): Link to USER_LIBS.
7487 ($(BLD)/gnutls.$(0)): New target.
7488
fa6996bc
EZ
74892011-04-24 Eli Zaretskii <eliz@gnu.org>
7490
eb35682e
EZ
7491 * xdisp.c (handle_single_display_spec): Rename the
7492 display_replaced_before_p argument into display_replaced_p, to
7493 make it consistent with the commentary. Fix typos in the
7494 commentary.
7495
e2ad650c
EZ
7496 * textprop.c (syms_of_textprop): Remove dead code.
7497 (copy_text_properties): Delete obsolete commentary about an
7498 interface that was deleted long ago. Fix typos in the description
7499 of arguments.
7500
1b2de274
EZ
7501 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7502 to changes in oldXMenu/XMenu.h from 2011-04-16.
7503 <menu_help_message, prev_menu_help_message>: Constify.
7504 (IT_menu_make_room): menu->help_text is now `const char **';
7505 adjust.
7506
7507 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7508 to changes in oldXMenu/XMenu.h from 2011-04-16.
7509 (struct XMenu): Declare `help_text' `const char **'.
7510
7511 * xfaces.c <Qunspecified>: Make extern again.
7512
7513 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7514 required by POSIX.
1b2de274 7515
762b15be
EZ
7516 * doc.c (get_doc_string): Improve the format passed to `error'.
7517
7518 * doprnt.c (doprnt): Improve commentary.
7519
7520 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7521
7522 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7523 them with etags.
7524
f1052e5d
EZ
7525 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7526 changes in globals.h immediately force recompilation.
762b15be
EZ
7527 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7528 $(CURDIR)/s/ms-w32.h.
7529 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7530
fa6996bc
EZ
7531 * character.c (Fchar_direction): Function deleted.
7532 (syms_of_character): Don't defsubr it.
7533 <char-direction-table>: Deleted.
7534
e6c3da20
EZ
75352011-04-23 Eli Zaretskii <eliz@gnu.org>
7536
7537 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7538 * doprnt.c: Include limits.h.
7539 (SIZE_MAX): New macro.
04f2d78b
CB
7540 (doprnt): Return a size_t value. 2nd arg is now size_t.
7541 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7542 Improve overflow protection. Support `l' modifier for integer
7543 conversions. Support %l conversion. Don't assume an EMACS_INT
7544 argument for integer conversions and for %c.
7545
7546 * lisp.h (doprnt): Restore prototype.
7547
7548 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7549 $(SRC)/character.h.
7550
7551 * Makefile.in (base_obj): Add back doprnt.o.
7552
7553 * deps.mk (doprnt.o): Add back prerequisites.
7554 (callint.o): Depend on character.h.
7555
7556 * eval.c (internal_lisp_condition_case): Include the handler
7557 representation in the error message.
7558 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7559 when breaking from the loop.
7560
7561 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7562
7563 * callint.c (Fcall_interactively): When displaying error message
7564 about invalid control letter, pass the character's codepoint, not
7565 a pointer to its multibyte form. Improve display of the character
7566 in octal and display also its hex code.
7567
7568 * character.c (char_string): Use %x to display the (unsigned)
7569 codepoint of an invalid character, to avoid displaying a bogus
7570 negative value.
7571
7572 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7573 `error', not SYMBOL_NAME itself.
7574
7575 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7576 character arguments to `error'.
7577
7578 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7579 to `error' in error message about FINAL_CHAR argument. Make sure
7580 FINAL_CHAR is a character, and use %c when it is passed as
7581 argument to `error'.
7582
4ffd0d6b 75832011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7584
7585 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7586
7587 * w32.c: Include <time.h>.
7588 (sys_localtime): New function.
7589
4ffd0d6b 75902011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7591
7592 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7593
4ffd0d6b 7594 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7595
4ffd0d6b 75962011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7597
4ffd0d6b
GM
7598 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7599 zombies (Bug#8467).
aac0c6e3 7600
04c56954
EZ
76012011-04-19 Eli Zaretskii <eliz@gnu.org>
7602
7603 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7604 gl_state.e_property when gl_state.object is Qt.
7605
7606 * insdel.c (make_gap_larger): Remove limitation of buffer size
7607 to <= INT_MAX.
7608
16a43933
CY
76092011-04-18 Chong Yidong <cyd@stupidchicken.com>
7610
7611 * xdisp.c (lookup_glyphless_char_display)
7612 (produce_glyphless_glyph): Handle cons cell entry in
7613 glyphless-char-display.
7614 (Vglyphless_char_display): Document it.
7615
7616 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7617 glyphless-char-display.
7618
4581706e
CY
76192011-04-17 Chong Yidong <cyd@stupidchicken.com>
7620
7621 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7622
7623 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7624
7625 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7626 definition for no-X builds.
7627
4887c6e2 76282011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7629
fd35b6f9
PE
7630 Static checks with GCC 4.6.0 and non-default toolkits.
7631
5c1ccb01
PE
7632 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7633
006c5daa
PE
7634 * process.c (keyboard_bit_set): Define only if SIGIO.
7635 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7636 (send_process): Repair possible setjmp clobbering.
7637
efc736d3
PE
7638 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7639
4e2fe2e6
PE
7640 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7641
f97334a2
PE
7642 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7643
4e75f29d
PE
7644 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7645 Define only if needed.
7646
90efadd1
PE
7647 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7648 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7649 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7650
3c647824
PE
7651 * dispextern.h (struct redisplay_interface): Rename param
7652 to avoid shadowing.
e264f262 7653 * termhooks.h (struct terminal): Likewise.
761383f4 7654 * xterm.c (xembed_send_message): Likewise.
3c647824 7655
b58c5c4a
PE
7656 * insdel.c (make_gap_smaller): Define only if
7657 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7658
cad59032
PE
7659 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7660 it.
7661
c339dc2e
PE
7662 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7663 so that we aren't warned about unused symbols.
7664
91a3e27b
PE
7665 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7666
399c71d3 7667 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7668
8ffc96f5
PE
7669 * xfns.c (x_real_positions): Mark locals as initialized.
7670
eef9bc79
PE
7671 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7672
098db9dd
PE
7673 * xterm.c: Fix problems found by static analysis with other toolkits.
7674 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7675 (x_dispatch_event): Declare static if USE_GTK, and
7676 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7677 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7678 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7679 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7680 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7681
eb18f6cc
PE
7682 * xmenu.c (menu_help_callback): Pointer type fixes.
7683 Use const pointers when pointing at readonly data. Avoid pointer
7684 signedness clashes.
7685 (FALSE): Remove unused macro.
7686 (update_frame_menubar): Remove unused decl.
7687
1fe72bf8
PE
7688 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7689
60d9e1db
PE
7690 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7691 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7692 (single_menu_item): Rename local to avoid shadowing.
7693
39261c26
PE
7694 * keyboard.c (make_lispy_event): Remove unused local var.
7695
018c5e19
PE
7696 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7697 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7698
63d2b86e
PE
7699 * bitmaps: Change bitmaps from unsigned char back to the X11
7700 compatible char. Avoid the old compiler warnings about
7701 out-of-range initializers by using, for example, '\xab' rather
7702 than 0xab.
7703
aefd87e1
PE
7704 * xgselect.c (xgselect_initialize): Check vs interface
7705 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7706
bf501fb9
PE
7707 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7708
e9829fdf
PE
7709 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7710 to read-only memory.
7711
1086c095
PE
7712 * fns.c (vector): Remove; this old hack is no longer needed.
7713
2baccd04 7714 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7715 Remove unused var.
dde42981 7716 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7717
72391843 7718 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7719
436c16df 7720 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7721 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7722 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7723
92bb796d 7724 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7725 (x_term_init): Remove local to avoid shadowing.
92bb796d 7726
764430a3 7727 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7728
7729 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7730 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7731
d1dfb56c
EZ
77322011-04-16 Eli Zaretskii <eliz@gnu.org>
7733
c4354cb4
EZ
7734 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7735
d1dfb56c
EZ
7736 Fix regex.c, syntax.c and friends for buffers > 2GB.
7737 * syntax.h (struct gl_state_s): Declare character position members
7738 EMACS_INT.
7739
7740 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7741
04f2d78b
CB
7742 * textprop.c (verify_interval_modification, interval_of):
7743 Declare arguments EMACS_INT.
d1dfb56c
EZ
7744
7745 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7746 EMACS_INT.
7747
7748 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7749
7750 * indent.c (Fvertical_motion): Local variable it_start is now
7751 EMACS_INT.
7752
7753 * regex.c (re_match, re_match_2, re_match_2_internal)
7754 (bcmp_translate, regcomp, regexec, print_double_string)
7755 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7756 (re_compile_pattern, re_exec): Declare arguments and local
7757 variables `size_t' and `ssize_t' and return values `regoff_t', as
7758 appropriate.
7759 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7760 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7761 <compile_stack_type>: `size' and `avail' are now `size_t'.
7762
7763 * regex.h <regoff_t>: Use ssize_t, not int.
7764 (re_search, re_search_2, re_match, re_match_2): Arguments that
7765 specify buffer/string position and length are now ssize_t and
7766 size_t. Return type is regoff_t.
7767
613052cd
BK
77682011-04-16 Ben Key <bkey76@gmail.com>
7769
7770 * nsfont.m: Fixed bugs in ns_get_family and
7771 ns_descriptor_to_entity that were caused by using free to
7772 deallocate memory blocks that were allocated by xmalloc (via
7773 xstrdup). This caused Emacs to crash when compiled with
7774 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7775 --enable-checking=xmallocoverrun). xfree is now used to
7776 deallocate these memory blocks.
7777
4170f62f 77782011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7779
71b41406
PE
7780 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7781
9587a89d
PE
7782 emacs_write: Accept and return EMACS_INT for sizes.
7783 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7784 et seq.
7785 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7786 Accept and return EMACS_INT.
7787 (emacs_gnutls_write): Return the number of bytes written on
7788 partial writes.
7789 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7790 (emacs_read, emacs_write): Remove check for negative size, as the
7791 Emacs source code has been audited now.
9587a89d
PE
7792 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7793 (emacs_read, emacs_write): Use it.
273a5f82
PE
7794 * process.c (send_process): Adjust to the new signatures of
7795 emacs_write and emacs_gnutls_write. Do not attempt to store
7796 a byte offset into an 'int'; it might overflow.
9587a89d 7797 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7798
3e047f51
PE
7799 * sound.c: Don't assume sizes fit in 'int'.
7800 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7801 Return EMACS_INT, not int.
3e047f51 7802 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7803 Accept EMACS_INT, not int.
7804 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7805 record read return values.
7806
cc39a9db
BK
78072011-04-15 Ben Key <bkey76@gmail.com>
7808
c9d0ec6d
JB
7809 * keyboard.c (Qundefined): Don't declare static since it is used
7810 in nsfns.m.
7811 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7812 static since they are used in nsfont.m.
cc39a9db 7813
6c60eb9f
SM
78142011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7815
7816 * process.c (Qprocessp): Don't declare static.
7817 * lisp.h (Qprocessp): Declare again.
7818
7990b61a
JB
78192011-04-15 Juanma Barranquero <lekktu@gmail.com>
7820
7821 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7822
5d4cb038
PE
78232011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7824
8bd7b830 7825 Improve C-level modularity by making more things 'static'.
cd64ea1d 7826
e3b27b31
PE
7827 Don't publish debugger-only interfaces to other modules.
7828 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7829 (verify_bytepos, count_markers): Move decls to the only modules
7830 that need them.
7831 * region-cache.h (pp_cache): Likewise.
7832 * window.h (check_all_windows): Likewise.
7833 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7834
5d4cb038
PE
7835 * sysdep.c (croak): Now static, if
7836 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7837 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7838
7839 * alloc.c (refill_memory_reserve): Now static if
7840 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7841 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7842
e87b6180
PE
7843 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7844 Define only if USE_LUCID.
7845
ac64929e
PE
7846 * xrdb.c (x_customization_string, x_rm_string): Now static.
7847
6f37259d
PE
7848 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7849 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7850
1683e3ab
PE
7851 * xdisp.c (draw_row_with_mouse_face): Now static.
7852 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7853
de9c2632
PE
7854 * window.h (check_all_windows): Mark externally visible.
7855
2b96acb7
PE
7856 * window.c (window_deletion_count): Now static.
7857
7858 * undo.c: Make symbols static if they're not exported.
7859 (last_undo_buffer, last_boundary_position, pending_boundary):
7860 Now static.
7861
50436f33
PE
7862 * textprop.c (interval_insert_behind_hooks): Now static.
7863 (interval_insert_in_front_hooks): Likewise.
7864
64520e5c
PE
7865 * term.c: Make symbols static if they're not exported.
7866 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7867 (max_frame_lines, tty_set_terminal_modes):
7868 (tty_reset_terminal_modes, tty_turn_off_highlight):
7869 (get_tty_terminal): Now static.
7870 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7871 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7872 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7873 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7874 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7875
1fa53021
PE
7876 * sysdep.c: Make symbols static if they're not exported.
7877 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7878 Now static.
7879 (sigprocmask_set, full_mask): Remove; unused.
7880 (wait_debugging): Mark as visible.
7881 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7882 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7883
d4b43b22
PE
7884 * syntax.c (syntax_temp): Define only if !__GNUC__.
7885
b7c513d0
PE
7886 * sound.c (current_sound_device, current_sound): Now static.
7887
989b29ad
PE
7888 * search.c (searchbufs, searchbuf_head): Now static.
7889
13a55a78
PE
7890 * scroll.c (scroll_cost): Remove; unused.
7891 * dispextern.h (scroll_cost): Remove decl.
7892
de68a1fc
PE
7893 * region-cache.h (pp_cache): Mark as externally visible.
7894
40ccffa6
PE
7895 * process.c: Make symbols static if they're not exported.
7896 (process_tick, update_tick, create_process, chan_process):
7897 (Vprocess_alist, proc_buffered_char, datagram_access):
7898 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7899 (deactivate_process): Mark defn as static, as well as decl.
7900 * lisp.h (create_process): Remove decl.
7901 * process.h (chan_process, Vprocess_alist): Remove decls.
7902
ad64fc97
PE
7903 * print.c: Make symbols static if they're not exported.
7904 (print_depth, new_backquote_output, being_printed, print_buffer):
7905 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7906 (print_interval, print_number_index, initial_stderr_stream):
7907 Now static.
7908 * lisp.h (Fprinc): Remove decl.
7909 (debug_output_compilation_hack): Mark as externally visible.
7910
adddb265
PE
7911 * sysdep.c (croak): Move decl from here to syssignal.h.
7912 * syssignal.h (croak): Put it here, so the API can be checked when
7913 'croak' is called from dissociate_if_controlling_tty.
7914
1717ede2
PE
7915 * minibuf.c: Make symbols static if they're not exported.
7916 (minibuf_save_list, choose_minibuf_frame): Now static.
7917 * lisp.h (choose_minibuf_frame): Remove decl.
7918
fa5fb2bc
PE
7919 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7920
1e3890d1
PE
7921 * lread.c: Make symbols static if they're not exported.
7922 (read_objects, initial_obarray, oblookup_last_bucket_number):
7923 Now static.
7924 (make_symbol): Remove; unused.
7925 * lisp.h (initial_obarray, make_symbol): Remove decls.
7926
8a1414fa
PE
7927 * keyboard.c: Make symbols static if they're not exported.
7928 (single_kboard, recent_keys_index, total_keys, recent_keys):
7929 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7930 (this_single_command_key_start, echoing, last_auto_save):
7931 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7932 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7933 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7934 (Vlispy_mouse_stem, double_click_count):
7935 Now static.
7936 (force_auto_save_soon): Define only if SIGDANGER.
7937 (ignore_mouse_drag_p): Now static if
7938 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7939 (print_help): Remove; unused.
7940 (stop_character, last_timer_event): Mark as externally visible.
7941 * keyboard.h (ignore_mouse_drag_p): Declare only if
7942 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7943 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7944 * lisp.h (echoing): Remove decl.
7945 (force_auto_save_soon): Declare only if SIGDANGER.
7946 * xdisp.c (redisplay_window): Simplify code, to make it more
7947 obvious that ignore_mouse_drag_p is not accessed if !defined
7948 USE_GTK && !defined HAVE_NS.
7949
93ea6e8f
PE
7950 * intervals.c: Make symbols static if they're not exported.
7951 (merge_properties_sticky, merge_interval_right, delete_interval):
7952 Now static.
7953 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7954
77382fcc
PE
7955 * insdel.c: Make symbols static if they're not exported.
7956 However, leave prepare_to_modify_buffer alone. It's never
7957 called from outside this function, but that appears to be a bug.
7958 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7959 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7960 (adjust_after_replace_noundo): Remove; unused.
7961 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7962 (signal_before_change): Remove decls.
77382fcc 7963
9306c32e
PE
7964 * indent.c (val_compute_motion, val_vmotion): Now static.
7965
cd44d2eb
PE
7966 * image.c: Make symbols static if they're not exported.
7967 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7968 if USE_GTK.
7969 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7970 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7971
ad9a7a06
PE
7972 * fringe.c (standard_bitmaps): Now static.
7973 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7974
81626931
PE
7975 * frame.c: Make symbols static if they're not exported.
7976 (x_report_frame_params, make_terminal_frame): Now static.
7977 (get_frame_param): Now static, unless HAVE_NS.
7978 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7979 (x_get_resource_string): Remove; not used.
7980 * frame.h (make_terminal_frame, x_report_frame_params):
7981 (x_get_resource_string); Remove decls.
7982 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7983 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7984
239f9db9
PE
7985 * font.c, fontset.c: Make symbols static if they're not exported.
7986 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7987 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7988 * font.c (font_close_object): Now static.
7989 * font.h (font_close_object): Remove.
7990 * fontset.c (FONTSET_OBJLIST): Remove.
7991 (free_realized_fontset) #if-0 the body, which does nothing.
7992 (face_suitable_for_char_p): #if-0, as it's never called.
7993 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7994 * xfaces.c (face_at_string_position):
7995 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7996 since 0 is always ASCII.
7997
dfcf3579
PE
7998 * fns.c (weak_hash_tables): Now static.
7999
5045092b
PE
8000 * fileio.c: Make symbols static if they're not exported.
8001 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8002 (Vwrite_region_annotation_buffers): Now static.
8003
57a96f5c
PE
8004 * eval.c: Make symbols static if they're not exported.
8005 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8006 * lisp.h (backtrace_list): Remove decl.
8007
35f08c38
PE
8008 * emacs.c: Make symbols static if they're not exported.
8009 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8010 (fatal_error_code, fatal_error_signal_hook, standard_args):
8011 Now static.
8012 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8013 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8014 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8015 * lisp.h (fatal_error_signal_hook): Remove decl.
8016 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8017
f44bd759
PE
8018 * editfns.c: Move a (normally-unused) function to its only use.
8019 * editfns.c, lisp.h (get_operating_system_release): Remove.
8020 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8021 worth the hassle of breaking this out.
8022
b532497d
PE
8023 * xterm.c: Make symbols static if they're not exported.
8024 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8025 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8026 (x_destroy_window, x_delete_display):
8027 Now static.
8028 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8029 (x_mouse_leave): Remove; unused.
8030 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8031 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8032 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8033 Remove decls.
8034 (x_mouse_leave): Declare only if WINDOWSNT.
8035 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8036 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8037 USE_X_TOOLKIT.
8038
1675728f
PE
8039 * ftxfont.c: Make symbols static if they're not exported.
8040 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8041 HAVE_FREETYPE.
8042 * font.h (ftxfont_driver): Likewise.
8043
e4cebfca
PE
8044 * xfns.c: Make symbols static if they're not exported.
8045 (x_last_font_name, x_display_info_for_name):
8046 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8047 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8048 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8049 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8050 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8051 (last_show_tip_args): Now static.
8052 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8053 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8054 (x_screen_planes): Remove; unused.
8055 * dispextern.h (x_screen_planes): Remove decl.
8056
5bf46f05
PE
8057 * dispnew.c: Make symbols static if they're not exported.
8058 * dispextern.h (redraw_garbaged_frames, scrolling):
8059 (increment_row_positions): Remove.
8060 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8061 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8062 Now static.
8063 (redraw_garbaged_frames): Remove; unused.
8064
435f4c28
PE
8065 * xfaces.c: Make symbols static if they're not exported.
8066 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8067 Remove decls.
8068 * xterm.h (defined_color): Remove decls.
8069 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8070 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8071 (menu_face_changed_default, defined_color, free_realized_face):
8072 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8073 (ascii_face_of_lisp_face): Remove; unused.
8074
8524aef3
PE
8075 * xdisp.c: Make symbols static if they're not exported.
8076 * dispextern.h (scratch_glyph_row, window_box_edges):
8077 (glyph_to_pixel_coords, set_cursor_from_row):
8078 (get_next_display_element, set_iterator_to_next):
8079 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8080 (show_mouse_face): Remove decls
8081 * frame.h (message_buf_print): Likewise.
8082 * lisp.h (pop_message, set_message, check_point_in_composition):
8083 Likewise.
8084 * xterm.h (set_vertical_scroll_bar): Likewise.
8085 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8086 (message_buf_print, scratch_glyph_row, displayed_buffer):
8087 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8088 (get_next_display_element, show_mouse_face, window_box_edges):
8089 (frame_to_window_pixel_xy, check_point_in_composition):
8090 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8091 (glyph_to_pixel_coords): Remove; unused.
8092
16390cd2
PE
8093 * dired.c (file_name_completion): Now static.
8094
8095 * dbusbind.c (xd_in_read_queued_messages): Now static.
8096
a25f4dfa
PE
8097 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8098 * data.c (circular_list_error): Remove.
8099
14a9c8df
PE
8100 * commands.h (last_point_position, last_point_position_buffer):
8101 (last_point_position_window): Remove decls.
8102 * keyboard.c: Make these variables static.
8103
04f2d78b
CB
8104 * coding.h (coding, code_convert_region, encode_coding_gap):
8105 Remove decls.
74ab6df5
PE
8106 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8107 (iso_code_class, detect_coding, code_convert_region): Now static.
8108 (encode_coding_gap): Remove; unused.
8109
38dfbee1
PE
8110 * chartab.c (chartab_chars, chartab_bits): Now static.
8111
a2cb4e63
PE
8112 * charset.h (charset_iso_8859_1): Remove decl.
8113 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8114 Now static.
8115
127198fd
PE
8116 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8117 * ccl.c (Vccl_program_table): Now static.
8118 (check_ccl_update): Remove; unused.
8119
d85b608f
PE
8120 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8121 * category.h: ... from here.
8122 * category.c (check_category_table, set_category_set): Now static.
8123
31cd66f3
PE
8124 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8125 * lisp.h: Remove these decls.
8126
c358e587
PE
8127 * buffer.c (buffer_count): Remove unused var.
8128
e78aecca
PE
8129 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8130 so that it's not optimized away.
8131 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8132 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8133 exported only to the debugger.
8134
e192d7d3 8135 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8136 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8137
92470028
PE
8138 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8139 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8140 was inaccessible from Lisp.
8141 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8142 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8143
244ed907
PE
8144 alloc.c: Import and export fewer symbols, and remove unused items.
8145 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8146 is defined.
8147 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8148 it's not optimized away by whole-program optimization.
8149 (message_enable_multibyte, free_misc): Remove.
8150 (catchlist, handlerlist, mark_backtrace):
8151 Declare only if BYTE_MARK_STACK.
8152 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8153 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8154 (message_enable_multibyte): Remove decl.
8155 (free_misc, interval_free_list, float_block, float_block_index):
8156 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8157 (cons_free_list, last_marked_index):
8158 Now static.
8159 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8160 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8161 (mark_backtrace): Define only if BYTE_MARK_STACK.
8162 * xdisp.c (message_enable_multibyte): Now static.
8163
61c2b50e 8164 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8165 This makes it easier for human readers (and static analyzers)
8166 to see whether these variables are used from other modules.
8167 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8168 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8169 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8170 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8171 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8172 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8173 * xmenu.c, xselect.c:
8174 Declare Q* vars static if they are not used in other modules.
8175 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8176 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8177 Remove decls of unexported vars.
8178 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8179
95c82688
PE
8180 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8181
16a97296
PE
8182 Make Emacs functions such as Fatom 'static' by default.
8183 This makes it easier for human readers (and static analyzers)
8184 to see whether these functions can be called from other modules.
8185 DEFUN now defines a static function. To make the function external
8186 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8187 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8188 (Finit_image_library):
16a97296
PE
8189 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8190 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8191 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8192 Remove decls, since these functions are now static.
8193 (Funintern, Fget_internal_run_time): New decls, since these functions
8194 were already external.
95c82688 8195
16a97296
PE
8196 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8197 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8198 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8199 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8200 * keyboard.c, keymap.c, lread.c:
8201 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8202 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8203 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8204 Mark functions with DEFUE instead of DEFUN,
8205 if they are used in other modules.
8206 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8207 decls for now-static functions.
8208 * buffer.h (Fdelete_overlay): Remove decl.
8209 * callproc.c (Fgetenv_internal): Mark as internal.
8210 * composite.c (Fremove_list_of_text_properties): Remove decl.
8211 (Fcomposition_get_gstring): New forward static decl.
8212 * composite.h (Fcomposite_get_gstring): Remove decl.
8213 * dired.c (Ffile_attributes): New forward static decl.
8214 * doc.c (Fdocumntation_property): New forward static decl.
8215 * eval.c (Ffetch_bytecode): New forward static decl.
8216 (Funintern): Remove extern decl; now in .h file where it belongs.
8217 * fileio.c (Fmake_symbolic_link): New forward static decl.
8218 * image.c (Finit_image_library): New forward static decl.
8219 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8220 * intervals.h (Fprevious_property_change):
8221 (Fremove_list_of_text_properties): Remove decls.
8222 * keyboard.c (Fthis_command_keys): Remove decl.
8223 (Fcommand_execute): New forward static decl.
8224 * keymap.c (Flookup_key): New forward static decl.
8225 (Fcopy_keymap): Now static.
8226 * keymap.h (Flookup_key): Remove decl.
8227 * process.c (Fget_process): New forward static decl.
8228 (Fprocess_datagram_address): Mark as internal.
8229 * syntax.c (Fsyntax_table_p): New forward static decl.
8230 (skip_chars): Remove duplicate decl.
8231 * textprop.c (Fprevious_property_change): New forward static decl.
8232 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8233 Now internal.
8234 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8235 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8236
785bbd42
PE
8237 * editfns.c (Fformat): Remove unreachable code.
8238
8b913b57
AS
82392011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8240
8241 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8242 change. (Bug#8496)
8243
a6744a35
EZ
82442011-04-13 Eli Zaretskii <eliz@gnu.org>
8245
8246 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8247 when at ZV. (Bug#8487)
8248
e7974947
AS
82492011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8250
baad03f0
AS
8251 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8252 (Bug#8437)
8253 * keyboard.c (parse_tool_bar_item): Likewise.
8254 * sound.c (sound_cleanup, alsa_close): Likewise.
8255 * termcap.c (tgetent): Likewise.
8256 * xfns.c (x_default_font_parameter): Likewise.
8257 * xsettings.c (read_and_apply_settings): Likewise.
8258
e7974947
AS
8259 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8260 (overrun_check_free): Protoize.
8261
28272684
PE
82622011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8263
8264 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8265 since callers should never pass a negative size.
8266 Change the signature to match that of plain 'read' and 'write'; see
8267 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8268 * lisp.h: Update prototypes of emacs_write and emacs_read.
8269
11997c76
EZ
82702011-04-11 Eli Zaretskii <eliz@gnu.org>
8271
8272 * xdisp.c (redisplay_window): Don't try to determine the character
8273 position of the scroll margin if the window start point w->startp
e896f03c 8274 is outside the buffer's accessible region. (Bug#8468)
11997c76 8275
8a2cbd72
EZ
82762011-04-10 Eli Zaretskii <eliz@gnu.org>
8277
8278 Fix write-region and its subroutines for buffers > 2GB.
8279 * fileio.c (a_write, e_write): Modify declaration of arguments and
8280 local variables to support buffers larger than 2GB.
8281 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8282
8283 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8284 argument, local variables, and return value.
8285
8286 * lisp.h: Update prototypes of emacs_write and emacs_read.
8287
8288 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8289
4073e537 82902011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8291
1ebfdcb6
PE
8292 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8293
b2ded58d
PE
8294 Fix more problems found by GCC 4.6.0's static checks.
8295
7d66342c
PE
8296 * xdisp.c (vmessage): Use a better test for character truncation.
8297
bbf47d44
PE
8298 * charset.c (load_charset_map): <, not <=, for optimization,
8299 and to avoid potential problems with integer overflow.
9248994d 8300 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8301 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8302 * editfns.c (Fformat): Likewise.
1e69125e 8303 * syntax.c (skip_chars): Likewise.
3befa583 8304
e3019616
PE
8305 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8306 This also lets GCC 4.6.0 generate slightly better loop code.
8307
becfa255
PE
8308 * callint.c (Fcall_interactively): <, not <=, for optimization.
8309 (Fcall_interactively): Count the number of arguments produced,
8310 not the number of arguments given. This is simpler and lets GCC
8311 4.6.0 generate slightly better code.
8312
dae0cd48
PE
8313 * ftfont.c: Distingish more carefully between FcChar8 and char.
8314 The previous code passed unsigned char * to a functions like
8315 strlen and xstrcasecmp that expect char *, which does not
8316 conform to the C standard.
8317 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8318 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8319 char * when the C standard requires it.
8320
76032d70
PE
8321 * keyboard.c (read_char): Remove unused var.
8322
eb3f1cc8
PE
8323 * eval.c: Port to Windows vsnprintf (Bug#8435).
8324 Include <limits.h>.
8325 (SIZE_MAX): Define if the headers do not.
8326 (verror): Do not give up if vsnprintf returns a negative count.
8327 Instead, grow the buffer. This ports to Windows vsnprintf, which
8328 does not conform to C99. Problem reported by Eli Zaretskii.
8329 Also, simplify the allocation scheme, by avoiding the need for
8330 calling realloc, and removing the ALLOCATED variable.
8331
70476b54
PE
8332 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8333
12020a9e
PE
8334 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8335 But keep the doprint source code for now, as we might revamp it
8336 and use it again (Bug#8435).
ea6c7ae6
PE
8337 * lisp.h (doprnt): Remove.
8338 * Makefile.in (base_obj): Remove doprnt.o.
8339 * deps.mk (doprnt.o): Remove.
8340
5fdb398c
PE
8341 error: Print 32- and 64-bit integers portably (Bug#8435).
8342 Without this change, on typical 64-bit hosts error ("...%d...", N)
8343 was used to print both 32- and 64-bit integers N, which relied on
8344 undefined behavior.
61bdb816 8345 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8346 * lisp.h (error, verror): Mark as printf-like functions.
8347 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8348 Report overflow in size calculations when allocating printf buffer.
8349 Do not truncate output string at its first null byte.
8350 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8351 Truncate the output at a character boundary, since vsnprintf does not
8352 do that.
8353 * charset.c (check_iso_charset_parameter): Convert internal
8354 character to string before calling 'error', since %c now has the
8355 printf meaning.
8356 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8357 overflow when computing char to be passed to 'error'. Do not
8358 pass Lisp_Object to 'error'; pass the integer instead.
8359 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8360 formatted with plain %d.
8361
b189fa66
PE
8362 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8363
bff87ef0
PE
8364 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8365
7e2cac20
PE
8366 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8367
ce4d90b5
PE
8368 * xterm.c (x_catch_errors): Remove duplicate declaration.
8369
266c9547
PE
8370 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8371
79c49ad2
PE
8372 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8373
368f4090
JM
83742011-04-10 Jim Meyering <meyering@redhat.com>
8375
8376 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8377 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8378 return ssize_t not "int", and use size_t as the buffer length.
8379 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8380 * gnutls.h: Update declarations.
8381 * process.c (read_process_output): Use ssize_t, to match.
8382 (send_process): Likewise.
8383
a32d4040
CY
83842011-04-09 Chong Yidong <cyd@stupidchicken.com>
8385
8386 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8387
8546720e 83882011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8389
04f2d78b
CB
8390 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8391 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8392
8546720e
GM
8393 * xterm.c (handle_one_xevent):
8394 * xmenu.c (create_and_show_popup_menu):
8395 * xselect.c (x_decline_selection_request)
8396 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8397
0a2f5c1a 83982011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8399
8400 Fix some uses of `int' instead of EMACS_INT.
8401 * search.c (string_match_1, fast_string_match)
8402 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8403 (scan_buffer, find_next_newline_no_quit)
8404 (find_before_next_newline, search_command, Freplace_match)
8405 (Fmatch_data): Make some `int' variables be EMACS_INT.
8406
8407 * xdisp.c (display_count_lines): 3rd argument and return value now
8408 EMACS_INT. All callers changed.
8409 (pint2hrstr): Last argument is now EMACS_INT.
8410
8411 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8412 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8413 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8414 (decode_coding_utf_16, decode_coding_emacs_mule)
8415 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8416 (decode_coding_ccl, decode_coding_charset)
8417 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8418 (decode_coding_iso_2022, decode_coding_emacs_mule)
8419 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8420 <char_offset, last_offset>: Declare EMACS_INT.
8421 (encode_coding_utf_8, encode_coding_utf_16)
8422 (encode_coding_emacs_mule, encode_invocation_designation)
8423 (encode_designation_at_bol, encode_coding_iso_2022)
8424 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8425 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8426 Declare EMACS_INT.
8427 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8428 (encode_invocation_designation): Last argument P_NCHARS is now
8429 EMACS_INT.
8430 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8431 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8432
8433 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8434 All users changed.
8435
8436 * ccl.c (Fccl_execute_on_string): Declare some variables
8437 EMACS_INT.
8438
8546720e 84392011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8440
8441 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8442
4e19a977
CS
84432011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8444
8445 * process.c (Fformat_network_address): Doc fix.
8446
87302331
R
84472011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8448
ee7683eb 8449 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8450
cbb59342
CY
84512011-04-08 Chong Yidong <cyd@stupidchicken.com>
8452
8453 * keyboard.c (read_char): Call Lisp function help-form-show,
8454 instead of using internal_with_output_to_temp_buffer.
8455 (Qhelp_form_show): New var.
e0d38eeb 8456 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8457
8458 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8459
8460 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8461
e67a13ab
CY
84622011-04-06 Chong Yidong <cyd@stupidchicken.com>
8463
04f2d78b
CB
8464 * process.c (Flist_processes): Remove to Lisp.
8465 (list_processes_1): Delete.
e67a13ab 8466
973f782d
EZ
84672011-04-06 Eli Zaretskii <eliz@gnu.org>
8468
7c106b1e
EZ
8469 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8470
973f782d
EZ
8471 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8472
41cf7d1a 84732011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8474
ca23cc88
PE
8475 Fix more problems found by GCC 4.6.0's static checks.
8476
f390e2d5
PE
8477 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8478
42eea0d0
PE
8479 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8480
b69769da 8481 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8482
f9541e84
PE
8483 * xdisp.c (vmessage): Mark as a printf-like function.
8484
13841b55
PE
8485 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8486
c136c10f
PE
8487 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8488
5e2d4a30
PE
8489 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8490 printf-like functions.
8491 (tiff_load): Add casts to remove these marks before passing them
8492 to system-supplied API.
8493
583f48b9
PE
8494 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8495
b25d760e
PE
8496 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8497 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8498 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8499 directly, rather than having caller test rule sign. This avoids
8500 some unnecessary tests.
8501 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8502 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8503 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8504
bc7b6697 8505 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8506 (xfont_open): Avoid unnecessary tests.
bc7b6697 8507
27ccc379
PE
8508 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8509
dcd5c89a
PE
8510 * composite.h, composite.c (composition_gstring_put_cache):
8511 Use EMACS_INT, not int, for length.
8512
b13a45c6
PE
8513 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8514 breaking out part of COMPOSITION_DECODE_RULE.
8515 (COMPOSITION_DECODE_RULE): Use it.
8516 * composite.c (get_composition_id): Remove unused local vars,
8517 by using the new macro.
8518
1e792e4d
PE
8519 * textprop.c (set_text_properties_1): Change while to do-while,
8520 since the condition is always true at first.
8521
dc6c6455 8522 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8523 (interval_deletion_adjustment): Return unsigned value.
8524 All uses changed.
dc6c6455 8525
aba7731a
PE
8526 * process.c (list_processes_1, create_pty, read_process_output):
8527 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8528 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8529 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8530 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8531 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8532
fdfc4bf3
PE
8533 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8534
fca8fe46 8535 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8536 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8537
06a0259a 8538 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8539 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8540 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8541
e7b9e80f
PE
8542 * print.c (print_error_message): Avoid int overflow.
8543
56201685
PE
8544 * font.c (font_list_entities): Redo for clarity,
8545 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8546
78834453 8547 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8548 (font_score): Avoid potential overflow in diff calculation.
78834453 8549
0bc0b309 8550 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8551 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8552
e610eaca
PE
8553 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8554
b895abce
PE
8555 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8556 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8557 can always succeed if overflow has undefined behavior.
8558
1f1d9321 8559 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8560 (wordify): Omit three unnecessary tests.
1f1d9321 8561
c59478bc
PE
8562 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8563 All callers changed. This avoids the need for an unused var.
8564
79b73827
PE
8565 * casefiddle.c (casify_region): Remove var that is set but not used.
8566
a4db5dfe
PE
8567 * dired.c (file_name_completion): Remove var that is set but not used.
8568
43aae36e
PE
8569 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8570
2a47c44d 8571 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8572 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8573
a37c69bf
PE
8574 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8575 Check for integer overflow on size calculations.
8576
328ab8e7
PE
8577 * buffer.c (Fprevious_overlay_change): Remove var that is set
8578 but not used.
8579
e5a2a5cb
PE
8580 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8581 Remove vars that are set but not used.
8d84a6eb 8582 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8583 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8584
a60e5f68
PE
8585 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8586
f661cb61 8587 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8588 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8589
f0397f5a
PE
8590 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8591 that are set but not used.
8592
8664db06 8593 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8594 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8595
6abdaa4a
PE
8596 * xselect.c (x_get_local_selection, x_handle_property_notify):
8597 Remove vars that are set but not used.
8598
0ce7538d 8599 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8600 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8601
9ae848fc
PE
8602 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8603 Remove var that is set but not used.
0b918413
PE
8604 (scroll_bar_windows_size): Now size_t, not int.
8605 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8606 Check for overflow.
9ae848fc 8607
a5a62657
PE
8608 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8609 (map_tty_color) [!defined MSDOS]: Likewise.
8610
5c5cdd39
PE
8611 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8612
66ebf983
PE
8613 * coding.c: Remove vars that are set but not used.
8614 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8615 All callers changed.
8616 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8617 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8618 (decode_coding_charset): Remove vars that are set but not used.
8619
1be4d761
PE
8620 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8621 that is set but not used.
8622
47553fa8
PE
8623 * print.c (print_object): Remove var that is set but not used.
8624
1f7196bf 8625 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8626 The gnulib version avoids calling malloc in the usual case,
8627 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8628 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8629 * filelock.c (current_lock_owner): Likewise.
8630 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8631 * sysdep.c: Include allocator.h, careadlinkat.h.
8632 (emacs_no_realloc_allocator): New static constant.
8633 (emacs_readlink): New function.
fdb61804
PE
8634 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8635 ../lib/careadlinkat.h.
d1fdcab7 8636
f84c17c7
SM
86372011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8638
8639 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8640 first non-nil return value).
8641
ef3862ad
JD
86422011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8643
8644 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8645 if not defined (Bug#8403).
8646
376a7006
JB
86472011-04-02 Juanma Barranquero <lekktu@gmail.com>
8648
8649 * xdisp.c (display_count_lines): Remove parameter `start',
8650 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8651 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8652 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8653 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8654 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8655 and thereabouts. All callers changed.
8656 (get_per_char_metric): Remove parameter `f', unused since
8657 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8658
6ca3801d
JM
86592011-04-02 Jim Meyering <meyering@redhat.com>
8660
8661 do not dereference NULL upon failed strdup
8662 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8663 (ns_get_family): Likewise.
8664
d8e2b5ba
JB
86652011-04-02 Juanma Barranquero <lekktu@gmail.com>
8666
8667 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8668
8c74fcbd
JD
86692011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8670
8671 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8672 later (Bug#8403).
8673
7200d79c
SM
86742011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8675
03408648 8676 Add lexical binding.
7200d79c 8677
03408648
SM
8678 * window.c (Ftemp_output_buffer_show): New fun.
8679 (Fsave_window_excursion):
8680 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8681
8682 * lread.c (lisp_file_lexically_bound_p): New function.
8683 (Fload): Bind Qlexical_binding.
8684 (readevalloop): Remove `evalfun' arg.
8685 Bind Qinternal_interpreter_environment.
8686 (Feval_buffer): Bind Qlexical_binding.
8687 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8688 Mark as dynamic.
8689 (syms_of_lread): Declare `lexical-binding'.
8690
8691 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8692
8693 * keyboard.c (eval_dyn): New fun.
8694 (menu_item_eval_property): Use it.
ca105506
SM
8695
8696 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8697
03408648
SM
8698 * fns.c (concat, mapcar1): Accept byte-code-functions.
8699
8700 * eval.c (Fsetq): Handle lexical vars.
8701 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8702 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8703 (FletX, Flet): Obey lexical binding.
8704 (Fcommandp): Handle closures.
8705 (Feval): New `lexical' arg.
8706 (eval_sub): New function extracted from Feval. Use it almost
8707 everywhere where Feval was used. Look up vars in lexical env.
8708 Handle closures.
8709 (Ffunctionp): Move from subr.el.
8710 (Ffuncall): Handle closures.
8711 (apply_lambda): Remove `eval_flags'.
8712 (funcall_lambda): Handle closures and new byte-code-functions.
8713 (Fspecial_variable_p): New function.
8714 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8715 but without exporting it to Lisp.
23aba0ea 8716
23aba0ea 8717 * doc.c (Fdocumentation, store_function_docstring):
03408648 8718 * data.c (Finteractive_form): Handle closures.
23aba0ea 8719
03408648
SM
8720 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8721 interactive spec.
ba83908c 8722
04f2d78b
CB
8723 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8724 New byte-codes.
03408648
SM
8725 (exec_byte_code): New function extracted from Fbyte_code to handle new
8726 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8727
03408648 8728 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8729
03408648 8730 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8731
e2abce01
JB
87322011-03-31 Juanma Barranquero <lekktu@gmail.com>
8733
8734 * xdisp.c (redisplay_internal): Fix prototype.
8735
63696a73 87362011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8737
63696a73 8738 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8739 (try_scrolling): Use it when setting scroll_limit.
8740 Limit scrolling to 100 screen lines.
63696a73
EZ
8741 (redisplay_window): Even when falling back on "recentering",
8742 position point in the window according to scroll-conservatively,
8743 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8744
8745 (try_scrolling): When point is above the window, allow searching
8746 as far as scroll_max, or one screenful, to compute vertical
8747 distance from PT to the scroll margin position. This prevents
8748 try_scrolling from unnecessarily failing when
8749 scroll-conservatively is set to a value slightly larger than the
8750 window height. Clean up the case of PT below the margin at bottom
8751 of window: scroll_max can no longer be INT_MAX. When aggressive
8752 scrolling is in use, don't let point enter the opposite scroll
8753 margin as result of the scroll.
8754 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8755 threshold of 100 lines for never-recentering scrolling.
8756
e4cc2dfc
JB
87572011-03-31 Juanma Barranquero <lekktu@gmail.com>
8758
8759 * dispextern.h (move_it_by_lines):
8760 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8761 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8762 (message_log_check_duplicate): Remove parameters `prev_bol' and
8763 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8764 (redisplay_internal): Remove parameter `preserve_echo_area',
8765 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8766
8767 * indent.c (Fvertical_motion):
8768 * window.c (window_scroll_pixel_based, Frecenter):
8769 Don't pass `need_y_p' to `move_it_by_lines'.
8770
1c470562
SM
87712011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8772
44f230aa
SM
8773 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8774 steal a few bits to be more compact.
8775 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8776 Remove unneeded casts.
8777
1c470562
SM
8778 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8779
888adce9
ZK
87802011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8781
8782 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8783 binding" message (bug#7967).
8784
f838ed7b
PE
87852011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8786
77861b95
PE
8787 Fix more problems found by GCC 4.6.0's static checks.
8788
de6dbc14
PE
8789 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8790 Remove unused local var.
8791
f838ed7b
PE
8792 * editfns.c (Fmessage_box): Remove unused local var.
8793
792c7b2b
PE
8794 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8795 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8796 Omit unused local vars.
c499e557 8797 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8798 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8799 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8800 Omit unused local var.
8801
ba0165e1
PE
8802 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8803 Don't assume string length fits in int.
32ad8845 8804 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8805 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8806
3c59b4c9
PE
8807 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8808 instead of alloca (Bug#8344).
8809
a3eed478 8810 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8811 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8812
eb4d412d
PE
8813 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8814
1658b401
PE
8815 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8816 concerns.
8817
8818 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8819
8820 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8821
9a2c6e05
PE
8822 * keyboard.c (syms_of_keyboard): Use the same style as later
8823 in this function when indexing through an array. This also
8824 works around GCC bug 48267.
8825
03d0a109
PE
8826 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8827
44f730c8
PE
8828 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8829
fe75f926
PE
8830 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8831 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8832
ffa8c828
PE
8833 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8834 This avoids undefined behavior on integer overflow, and is a bit
8835 more convenient anyway since it is compared to a size_t variable.
8836
c5101a77
PE
8837 Variadic C functions now count arguments with size_t, not int.
8838 This avoids an unnecessary limitation on 64-bit machines, which
8839 caused (substring ...) to crash on large vectors (Bug#8344).
8840 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8841 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8842 All variadic functions and their callers changed accordingly.
c5101a77
PE
8843 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8844 * data.c (arith_driver, float_arith_driver): Likewise.
8845 * editfns.c (general_insert_function): Likewise.
8846 * eval.c (struct backtrace.nargs, interactive_p)
8847 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8848 (funcall_lambda, mark_backtrace): Likewise.
8849 * fns.c (concat): Likewise.
8850 * frame.c (x_set_frame_parameters): Likewise.
8851 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8852 0 if not found, not -1. All callers changed.
8853
dd3f25f7
PE
8854 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8855 (stack_copy_size): Now size_t, not int.
8856 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8857
461c2ab9
JB
88582011-03-28 Juanma Barranquero <lekktu@gmail.com>
8859
8860 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8861 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8862 All callers changed.
8863
8864 * lisp.h (multibyte_char_to_unibyte):
8865 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8866 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8867 * character.h (CHAR_TO_BYTE8):
8868 * cmds.c (internal_self_insert):
8869 * editfns.c (general_insert_function):
8870 * keymap.c (push_key_description):
8871 * search.c (Freplace_match):
8872 * xdisp.c (message_dolog, set_message_1): All callers changed.
8873
f6d62986
SM
88742011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8875
8876 * keyboard.c (safe_run_hook_funcall): New function.
8877 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8878 don't set the hook to nil, but remove the offending function instead.
8879 (Qcommand_hook_internal): Remove, unused.
8880 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8881 Vcommand_hook_internal.
8882
8883 * eval.c (enum run_hooks_condition): Remove.
8884 (funcall_nil, funcall_not): New functions.
8885 (run_hook_with_args): Call each function through a `funcall' argument.
8886 Remove `cond' argument, now redundant.
8887 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8888 (Frun_hook_with_args_until_failure): Adjust accordingly.
8889 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8890
1db5b1ad
JB
88912011-03-28 Juanma Barranquero <lekktu@gmail.com>
8892
8893 * dispextern.h (string_buffer_position): Remove declaration.
8894
8895 * print.c (strout): Remove parameter `multibyte', unused since
8896 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8897
8898 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8899 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8900 All callers changed.
8901
8902 * w32.c (_wsa_errlist): Use braces for struct initializers.
8903
8904 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8905 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8906 All callers changed.
8907 (string_buffer_position): Likewise. Also, make static (it's never
8908 used outside xdisp.c).
8909 (cursor_row_p): Remove parameter `w', unused since
8910 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8911 (decode_mode_spec): Remove parameter `precision', introduced during
8912 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8913 All callers changed.
8914
5ffb62aa
JD
89152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8916
8917 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8918
461c2ab9 89192011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8920
8921 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8922 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8923 (ns_update_auto_hide_menu_bar): New functions.
8924 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8925 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8926 ns_constrain_all_frames.
8927 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8928 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8929
5c380ffb
JD
89302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8931
8932 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8933
9af30bdf
GM
89342011-03-27 Glenn Morris <rgm@gnu.org>
8935
8936 * syssignal.h: Replace RETSIGTYPE with void.
8937 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8938 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8939 Replace SIGTYPE with void everywhere.
8940 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8941 * s/template.h (SIGTYPE): Remove commented out definition.
8942
e2abce01
JB
89432011-03-26 Eli Zaretskii <eliz@gnu.org>
8944
8945 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8946 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8947
f868cd8a
JB
89482011-03-26 Juanma Barranquero <lekktu@gmail.com>
8949
59eb0929
JB
8950 * w32.c (read_unc_volume): Use parameter `henum', instead of
8951 global variable `wget_enum_handle'.
8952
8953 * keymap.c (describe_vector): Remove parameters `indices' and
8954 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8955 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8956
f868cd8a
JB
8957 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8958
8959 * keyboard.c (timer_check): Remove parameter `do_it_now',
8960 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8961 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8962 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8963
8964 * keyboard.c (read_char):
8965 * w32menu.c (w32_menu_display_help):
8966 * xmenu.c (show_help_event, menu_help_callback):
8967 Adjust calls to `show_help_echo'.
8968
8969 * gtkutil.c (xg_maybe_add_timer):
8970 * keyboard.c (readable_events):
8971 * process.c (wait_reading_process_output):
8972 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8973
8974 * insdel.c (adjust_markers_gap_motion):
8975 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8976 (gap_left, gap_right): Don't call it.
8977
2ecf6fdb
CY
89782011-03-25 Chong Yidong <cyd@stupidchicken.com>
8979
8980 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8981 incurred during fontification.
8982
6b1f9ba4
JB
89832011-03-25 Juanma Barranquero <lekktu@gmail.com>
8984
8985 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8986 (DEFVAR_PER_BUFFER): Don't pass it.
8987
8988 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8989 (scrolling_window): Don't pass it.
8990
0f4a96b5
JB
89912011-03-25 Juanma Barranquero <lekktu@gmail.com>
8992
8993 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8994
8995 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8996 and `suffix'.
8997 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8998 of variables specific to SELinux and computation of `encoded_absname'.
8999
9000 * image.c (XPutPixel): Remove unused variable `height'.
9001
9002 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9003
9004 * unexw32.c (get_section_info): Remove unused variable `section'.
9005
9006 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9007 (system_process_attributes): Remove unused variable `sess'.
9008 (sys_read): Remove unused variable `err'.
9009
9010 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9011 (w32_wnd_proc): Remove unused variable `isdead'.
9012 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9013 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9014 (x_create_tip_frame): Remove unused variable `tem'.
9015
9016 * w32inevt.c (w32_console_read_socket):
9017 Remove unused variable `no_events'.
9018
9019 * w32term.c (x_draw_composite_glyph_string_foreground):
9020 Remove unused variable `width'.
9021
1149507c
JB
90222011-03-24 Juanma Barranquero <lekktu@gmail.com>
9023
9024 * w32term.c (x_set_glyph_string_clipping):
9025 Don't pass uninitialized region to CombineRgn.
9026
9c88f339
JB
90272011-03-23 Juanma Barranquero <lekktu@gmail.com>
9028
9029 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9030 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9031 (Fx_close_connection): Remove unused variable `i'.
9032
9033 * w32font.c (w32font_draw): Return number of glyphs.
9034 (w32font_open_internal): Remove unused variable `i'.
9035 (w32font_driver): Add missing initializer.
9036
9037 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9038 (fill_in_menu): Remove unused variable `items_added'.
9039
9040 * w32term.c (last_mouse_press_frame): Remove static global variable.
9041 (w32_clip_to_row): Remove unused variable `f'.
9042 (x_delete_terminal): Remove unused variable `i'.
9043
9044 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9045 (NOTHING): Remove unused static global variable.
9046 (uniscribe_check_otf): Remove unused variable `table'.
9047 (uniscribe_font_driver): Add missing initializers.
9048
dee091a3
JD
90492011-03-23 Julien Danjou <julien@danjou.info>
9050
9051 * term.c (Fsuspend_tty, Fresume_tty):
9052 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9053 * window.c (temp_output_buffer_show):
9054 * insdel.c (signal_before_change):
9055 * frame.c (Fhandle_switch_frame):
9056 * fileio.c (Fdo_auto_save):
9057 * emacs.c (Fkill_emacs):
9058 * editfns.c (save_excursion_restore):
9059 * cmds.c (internal_self_insert):
9060 * callint.c (Fcall_interactively):
9061 * buffer.c (Fkill_all_local_variables):
9062 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9063 Use Frun_hooks.
0f4a96b5 9064 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9065 unconditionally since it does the check itself.
dee091a3 9066
2c520ab5 90672011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9068
c9c49752
PE
9069 Fix more problems found by GCC 4.5.2's static checks.
9070
8abc3f12
PE
9071 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9072 the first time through the loop, since we know p0 < p1 then.
9073 This also avoids a gcc -Wstrict-overflow warning.
9074
a2d26660
PE
9075 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9076 leading to a memory leak, possible in functions like
9077 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9078 of objects (Bug#8318).
a2d26660 9079
916c72e9
PE
9080 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9081 that could (at least in theory) be that large.
9082
19ab8a18
PE
9083 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9084 This is less likely to overflow, and avoids undefined behavior if
9085 overflow does occur. All callers changed. Use strtoul to scan
9086 for the unsigned long integer.
b7cbbd6f
PE
9087 (pint2hrstr): Simplify and tune code slightly.
9088 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9089
f0641eff
PE
9090 * scroll.c (do_scrolling): Work around GCC bug 48228.
9091 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9092
7f650bb9
PE
9093 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9094 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9095 (validate_x_resource_name): Simplify count usage.
9096 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9097
37dd57d1
PE
9098 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9099 fail (Bug#8306).
81e56e61 9100
699979fc 9101 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9102
401bf9b4
PE
9103 * process.c (Fmake_network_process): Use socklen_t, not int,
9104 where POSIX says socklen_t is required in portable programs.
9105 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9106 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9107 (Fmake_network_process, server_accept_connection):
9108 (wait_reading_process_output, read_process_output):
9109 Likewise.
9110
b93aacde
PE
9111 * process.c: Rename or move locals to avoid shadowing.
9112 (list_processes_1, Fmake_network_process):
9113 (read_process_output_error_handler, exec_sentinel_error_handler):
9114 Rename or move locals.
4dc343ee 9115 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9116 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9117 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9118 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9119 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9120
af8a867c 9121 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9122 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9123 Include tparam.h instead, since it declares them.
af8a867c
PE
9124 * cm.h (PC): Remove extern decl; tparam.h now does this.
9125 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9126 * terminfo.c: Include tparam.h, to check interfaces.
9127 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9128 (tparam): Adjust signature to match interface in tparam.h;
9129 this removes some undefined behavior. Check that outstring and len
9130 are zero, which they always are with Emacs.
9131 * tparam.h (PC, BC, UP): New extern decls.
9132
0248044d 9133 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9134 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9135
8ff096c1 9136 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9137 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9138 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9139 (ftfont_list): Remove unused local.
49eaafba
PE
9140 (get_adstyle_property, ftfont_pattern_entity):
9141 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9142 Rename locals to avoid shadowing.
8ff096c1 9143
e2be39f6
PE
9144 * xfont.c (xfont_list_family): Mark var as initialized.
9145
c9735e30
PE
9146 * xml.c (make_dom): Now static.
9147
8f5201ae
PE
9148 * composite.c (composition_compute_stop_pos): Rename local to
9149 avoid shadowing.
b246f932
PE
9150 (composition_reseat_it): Remove unused locals.
9151 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9152 (composition_update_it): Mark var as initialized.
11b61122
PE
9153 (find_automatic_composition): Mark vars as initialized,
9154 with a FIXME (Bug#8290).
8f5201ae 9155
760fbc2c
PE
9156 character.h: Rename locals to avoid shadowing.
9157 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9158 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9159 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9160 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9161 to avoid shadowing.
9162
ff08eb85
PE
9163 * textprop.c (property_change_between_p): Remove; unused.
9164
fc7bf025
PE
9165 * intervals.c (interval_start_pos): Now static.
9166
235d7abc
PE
9167 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9168
44f230aa
SM
9169 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9170 Rename locals to avoid shadowing.
3e7d6594 9171
50060332
PE
9172 * sound.c (wav_play, au_play, Fplay_sound_internal):
9173 Fix pointer signedness.
d01f234b 9174 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9175 (wav_play): Initialize a variable to 0, to prevent undefined
9176 behavior (Bug#8278).
50060332 9177
c4fc4e30
PE
9178 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9179
918436ed
PE
9180 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9181
c939f91b
PE
9182 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9183 clobbering (Bug#8298).
b9c7f648
PE
9184 * sysdep.c (sys_subshell): Likewise.
9185 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9186
6bd8c144
PE
9187 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9188 This should get cleaned up, so that child_setup has the
9189 same signature on all platforms.
9190
7710357c 9191 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9192 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9193
c59da222
CY
91942011-03-22 Chong Yidong <cyd@stupidchicken.com>
9195
9196 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9197 not to be necessary, and produces flickering.
9198
66b87493
GM
91992011-03-20 Glenn Morris <rgm@gnu.org>
9200
9201 * config.in: Remove file.
9202
45b6f6d5
JB
92032011-03-20 Juanma Barranquero <lekktu@gmail.com>
9204
9205 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9206 are now in src/globals.h.
9207 (syms_of_minibuf): Remove spurious & from previous change.
9208
cd394be1 92092011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9210
9211 * minibuf.c (completing-read-function): New variable.
9212 (completing-read-default): Rename from completing-read.
9213 (completing-read): Call completing-read-function.
9214
b14e3e21
CY
92152011-03-19 Juanma Barranquero <lekktu@gmail.com>
9216
9217 * xfaces.c (Fx_load_color_file):
9218 Read color file from absolute filename (bug#8250).
9219
f2b726e6
JB
92202011-03-19 Juanma Barranquero <lekktu@gmail.com>
9221
9222 * makefile.w32-in: Update dependencies.
9223
09f6ff02
EZ
92242011-03-17 Eli Zaretskii <eliz@gnu.org>
9225
9226 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9227
29a6015a
PE
92282011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9229
a3a6c54e
PE
9230 Fix more problems found by GCC 4.5.2's static checks.
9231
b766f867
PE
9232 * process.c (make_serial_process_unwind, send_process_trap):
9233 (sigchld_handler): Now static.
9234
be02381c
PE
9235 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9236 That way, the code declares only the vars that it needs.
9237 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9238 * s/cygwin.h (PTY_ITERATION): Likewise.
9239 * s/darwin.h (PTY_ITERATION): Likewise.
9240 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9241
57048744
PE
9242 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9243 * process.c (allocate_pty): Don't declare stb unless it's needed.
9244
7914961c 9245 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9246 (CONSTANTLIM): Remove; unused.
9247 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9248 Define only if needed.
7914961c 9249
b3967b18
PE
9250 * unexelf.c (unexec): Name an expression,
9251 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9252 Use a different way to cause a compilation error if anyone uses
9253 n rather than nn, a way that does not involve shadowing.
73366a00 9254 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9255
29a6015a
PE
9256 * deps.mk (unexalpha.o): Remove; unused.
9257
43cfc33e 9258 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9259 * unexec.h: New file.
ce701a33
PE
9260 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9261 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9262 Depend on unexec.h.
9263 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9264 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9265 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9266 Change as necessary to match prototype in unexec.h.
ce701a33 9267
01f44d5a
PE
9268 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9269 shadowing.
4f63c6bb 9270 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9271
a6670b0b
PE
9272 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9273 Rename locals to avoid shadowing.
9274
cef2010d 9275 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9276 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9277
d4d7173a
PE
9278 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9279
f08b802a
PE
9280 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9281 warning when compiling print.c.
9282
3ddb0639
PE
9283 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9284 instead of using an uninitialized var.
5ad03b97 9285 (font_sort_entities): Mark var as initialized.
3ddb0639 9286
170a2692
PE
9287 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9288
e663c700
PE
9289 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9290 pointers to constants.
89bc529a 9291 (font_parse_fcname): Remove unused vars.
7b81e2d0 9292 (font_delete_unmatched): Now static.
ea838e10 9293 (font_get_spec): Remove; unused.
13a547c6
PE
9294 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9295 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9296 Rename or move locals to avoid shadowing.
e663c700 9297
2a80c887 9298 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9299 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9300
1384fa33 9301 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9302 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9303
8b2c52e9
PE
9304 * alloc.c (mark_backtrace): Move decl from here ...
9305 * lisp.h: ... to here, so that it can be checked.
9306
475545b5 9307 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9308 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9309 (lisp_indirect_variable): Name an expression,
9310 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9311 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9312
b1349114 9313 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9314 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9315 Use const pointer when appropriate.
b1349114 9316
a2928364
PE
9317 * lisp.h (get_system_name, get_operating_system_release):
9318 Move decls here, to check interfaces.
9319 * process.c (get_operating_system_release): Move decl to lisp.h.
9320 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9321 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9322 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9323 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9324 (Fformat_time_string, Fencode_time, Finsert_char):
9325 (Ftranslate_region_internal, Fformat):
9326 Rename or remove local vars to avoid shadowing.
9710023e 9327 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9328
a415e694
PE
9329 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9330 avoid shadowing.
9331
8ef4622d
PE
9332 * lisp.h (eassert): Check that the argument compiles, even if
9333 ENABLE_CHECKING is not defined.
9334
946f9a5b
PE
9335 * data.c (Findirect_variable): Name an expression, to avoid
9336 gcc -Wbad-function-cast warning.
112396d6 9337 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9338 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9339 (Fmake_variable_buffer_local, Fmake_local_variable):
9340 Mark variables as initialized.
52746918 9341 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9342
e5aab7e7 9343 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9344 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9345 Rename locals to avoid shadowing.
dff45157
PE
9346 (mark_stack): Move local variables into the #ifdef region where
9347 they're used.
7bc26fdb
PE
9348 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9349 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9350 needed otherwise.
9351 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9352 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9353 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9354
e5aab7e7
PE
9355 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9356 avoids undefined behavior in theory.
9357
4da60324
PE
9358 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9359
88043301
PE
9360 Use functions, not macros, for up- and down-casing (Bug#8254).
9361 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9362 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9363 to use the following functions instead of these macros.
9364 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9365 EMACS_INT, since callers assume the returned value fits in int.
9366 (upcase1): Likewise, for UPCASE_TABLE.
9367 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9368 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9369 the race-condition problem in the old DOWNCASE.
88043301 9370
19ed5445
PE
9371 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9372 Rename locals to avoid shadowing.
9373 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9374 (regex_compile, re_search_2, re_match_2_internal):
9375 Remove unused local vars.
952db0d7
PE
9376 (FREE_VAR): Rewrite so as not to use empty "else",
9377 which gcc can warn about.
da053e48 9378 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9379 (RETALLOC_IF): Define only if needed.
9380 (WORDCHAR_P): Likewise. This one is never needed, but is used
9381 only in a comment talking about a compiler bug, so put inside
9382 the #if 0 of that comment.
9383 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9384 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9385 Remove; unused.
19ed5445 9386
1f3561e4 9387 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9388 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9389 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9390
ded6f8f7
PE
9391 * search.c (simple_search): Remove unused var.
9392
dbd37a95
PE
9393 * dired.c (compile_pattern): Move decl from here ...
9394 * lisp.h: ... to here, so that it can be checked.
9395 (struct re_registers): New forward decl.
9396
7e47afad
PE
9397 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9398
85f24f61
PE
9399 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9400 All uses changed.
9401 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9402 Rename locals to avoid shadowing.
5671df8f 9403 (Fvertical_motion): Mark locals as initialized.
85f24f61 9404
181aa2be 9405 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9406 (casify_region): Mark local as initialized.
181aa2be 9407
930d429c
PE
9408 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9409
7082eac6
PE
9410 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9411 New macros, so that the caller can use some names other than
9412 gcpro1, gcpro2, etc.
9413 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9414 of the new macros.
9415 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9416 argument, for consistency with GCPRO2_VAR, etc: it is now the
9417 prefix of the variable, not the variable itself. All uses
9418 changed.
38b2c076
PE
9419 * dired.c (directory_files_internal, file_name_completion):
9420 Rename locals to avoid shadowing.
9421
15206ed9
PE
9422 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9423 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9424 dired.c's scmp function, had undefined behavior.
9425 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9426 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9427 * buffer.h: ... to here, because these macros use current_buffer,
9428 and the new implementation with inline functions needs to have
9429 current_buffer in scope now, rather than later when the macros
9430 are used.
9431 (downcase, upcase1): New static inline functions.
9432 (DOWNCASE, UPCASE1): Reimplement using these functions.
9433 This avoids undefined behavior in expressions like
9434 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9435 from race conditions in accessing the global variables
9436 case_temp1 and case_temp2.
9437 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9438 * lisp.h (case_temp1, case_temp2): Remove their decls.
9439 * character.h (ASCII_CHAR_P): Move from here ...
9440 * lisp.h: ... to here, so that the inline functions mentioned
9441 above can use them.
9442
4a6bea26
PE
9443 * dired.c (directory_files_internal_unwind): Now static.
9444
f14b7e14
PE
9445 * fileio.c (file_name_as_directory, directory_file_name):
9446 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9447 Now static.
2893f146
PE
9448 (file_name_as_directory): Use const pointers when appropriate.
9449 (Fexpand_file_name): Likewise. In particular, newdir might
9450 point at constant storage, so make it a const pointer.
fd4ead52 9451 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9452 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9453 signedness issues.
f839df0c
PE
9454 (Fset_file_times, Finsert_file_contents, auto_save_error):
9455 Rename locals to avoid shadowing.
f14b7e14 9456
5716756e 9457 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9458 (Ftry_completion, Fall_completions): Rename or remove locals
9459 to avoid shadowing.
5716756e 9460
b4c3046a
PE
9461 * marker.c (bytepos_to_charpos): Remove; unused.
9462
b45db522
PE
9463 * lisp.h (verify_bytepos, count_markers): New decls,
9464 so that gcc does not warn that these functions aren't declared.
9465
85876d07
PE
9466 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9467 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9468 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9469 (copy_text): Remove unused local var.
85876d07 9470
03d78a21 9471 * filelock.c (within_one_second): Now static.
b3dd38ab 9472 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9473
5df8f01b
PE
9474 * buffer.c (fix_overlays_before): Mark locals as initialized.
9475 (fix_start_end_in_overlays): Likewise. This function should be
9476 simplified by using pointers-to-pointers, but that's a different
9477 matter.
b1d876f1 9478 (switch_to_buffer_1): Now static.
8f54f30a
PE
9479 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9480 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9481
a70072c9 9482 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9483 Fix pointer signedness issue.
edced198
PE
9484 (sys_subshell): Mark local as volatile if checking for lint,
9485 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9486 (MAXPATHLEN): Define only if needed.
a70072c9 9487
a0977c44
PE
9488 * process.c (serial_open, serial_configure): Move decls from here ...
9489 * systty.h: ... to here, so that they can be checked.
9490
a884fdcc
PE
9491 * fns.c (get_random, seed_random): Move extern decls from here ...
9492 * lisp.h: ... to here, so that they can be checked.
9493
604efe86 9494 * sysdep.c (reset_io): Now static.
b8950c94 9495 (wait_for_termination_signal): Remove; unused.
604efe86 9496
38fc62d9
PE
9497 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9498 (copy_keymap_item, append_key, push_text_char_description):
9499 Now static.
1004a21a 9500 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9501 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9502 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9503 (describe_map_tree):
9504 Rename locals to avoid shadowing.
38fc62d9 9505
2f2650da
PE
9506 * keyboard.c: Declare functions static if they are not used elsewhere.
9507 (echo_char, echo_dash, cmd_error, top_level_2):
9508 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9509 (read_char, kbd_buffer_get_event, make_lispy_position):
9510 (make_lispy_event, make_lispy_movement, apply_modifiers):
9511 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9512 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9513 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9514 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9515 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9516
a053e86c 9517 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9518 (mark_kboards): Move decl here ...
9519 * alloc.c (mark_kboards): ... from here.
a053e86c 9520
4752793e
PE
9521 * lisp.h (force_auto_save_soon): New decl.
9522
74f10ca7 9523 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9524 (DEFINE_DUMMY_FUNCTION): New macro.
9525 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9526 Use it.
c03cd23f
PE
9527 (main): Add casts to avoid warnings
9528 if GCC considers string literals to be constants.
74f10ca7 9529
022e70d4
PE
9530 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9531
59d6fe83
PE
9532 * dbusbind.c: Pointer signedness fixes.
9533 (xd_signature, xd_append_arg, xd_initialize):
9534 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9535 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9536 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9537 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9538
78320123
PE
9539 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9540 if GCC considers string literals to be constants.
49cebcca 9541 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9542
35ac2a97
SM
95432011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9544
fb103ca9
SM
9545 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9546 (print_preprocess, print_object): New macro to fix last change.
9547
35ac2a97
SM
9548 * print.c (print_preprocess): Don't forget font objects.
9549
62973b41
JB
95502011-03-16 Juanma Barranquero <lekktu@gmail.com>
9551
9552 * emacs.c (USAGE3): Doc fixes.
9553
0e48bb22
AS
95542011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9555
9556 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9557 structure.
9558
7684e57b
JB
95592011-03-14 Juanma Barranquero <lekktu@gmail.com>
9560
9561 * lisp.h (VWindow_system, Qfile_name_history):
9562 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9563 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9564 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9565
9566 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9567 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9568
9569 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9570 * w32console.c (detect_input_pending, read_input_pending)
9571 (encode_terminal_code):
9572 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9573 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9574 (w32_system_caret_y, Qfile_name_history):
9575 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9576 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9577 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9578 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9579 * w32proc.c (Qlocal, report_file_error):
9580 * w32term.c (Vwindow_system, updating_frame):
9581 * w32uniscribe.c (initialized, uniscribe_font_driver):
9582 Remove unneeded extern declarations.
9583
2aa46d6c
CY
95842011-03-14 Chong Yidong <cyd@stupidchicken.com>
9585
c96bbc66 9586 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9587
cffc6f3b
CY
95882011-03-13 Chong Yidong <cyd@stupidchicken.com>
9589
9590 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9591 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9592 These macros can no longer be used for assignment.
9593
44f230aa
SM
9594 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9595 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9596 (record_buffer_markers, fetch_buffer_markers): New functions for
9597 recording and fetching special buffer markers.
9598 (set_buffer_internal_1, set_buffer_temp): Use them.
9599
9600 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9601
9602 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9603
9604 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9605 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9606
9607 * xdisp.c (hscroll_window_tree):
9608 (reconsider_clip_changes): Use PT instead of BUF_PT.
9609
d251f04b
EZ
96102011-03-13 Eli Zaretskii <eliz@gnu.org>
9611
9612 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9613 $(EMACS_ROOT)/lib/intprops.h.
9614
f0c77cd1
PE
96152011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9616
3eca4629
PE
9617 Fix more problems found by GCC 4.5.2's static checks.
9618
7c86ee98
PE
9619 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9620 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9621 (xg_free_frame_widgets): Make it clear that a local variable is
9622 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9623 (gdk_window_get_screen): Make it clear that this macro is needed
9624 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9625 (int_gtk_range_get_value): New function, which avoids a diagnostic
9626 from gcc -Wbad-function-cast.
9627 (xg_set_toolkit_scroll_bar_thumb): Use it.
9628 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9629 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9630 (get_utf8_string, xg_get_file_with_chooser):
9631 Rename locals to avoid shadowing.
9632 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9633
41729b81
PE
9634 * xgselect.c (xg_select): Remove unused var.
9635
f0c77cd1
PE
9636 * image.c (four_corners_best): Mark locals as initialized.
9637 (gif_load): Initialize transparent_p to zero (Bug#8238).
9638 Mark another local as initialized.
ec6cf4c6 9639 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9640
ce0ad53d 9641 * image.c (clear_image_cache): Now static.
d5d5a617 9642 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9643 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9644 (x_edge_detection): Remove unnecessary cast that
9645 gcc -Wbad-function-cast diagnoses.
2037898d 9646 (gif_load): Fix pointer signedness.
6ae141d6
PE
9647 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9648 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9649
33383987 96502011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9651
d32df629
PE
9652 Improve quality of tests for time stamp overflow.
9653 For example, without this patch (encode-time 0 0 0 1 1
9654 1152921504606846976) returns the obviously-bogus value (-948597
9655 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9656 reports time overflow. See
9657 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9658 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9659 * editfns.c: Include limits.h and intprops.h.
9660 (TIME_T_MIN, TIME_T_MAX): New macros.
9661 (time_overflow): Move earlier, to before first use.
9662 (hi_time, lo_time): New functions, for an accurate test for
9663 out-of-range times.
9664 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9665 (Fget_internal_run_time): Don't assume time_t fits in int.
9666 (make_time): Use list2 instead of Fcons twice.
9667 (Fdecode_time): More accurate test for out-of-range times.
9668 (check_tm_member): New function.
9669 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9670 (lisp_time_argument): Don't rely on undefined left-shift and
9671 right-shift behavior when checking for time stamp overflow.
8be6f318 9672
fe31d94c
PE
9673 * editfns.c (time_overflow): New function, refactoring common code.
9674 (Fformat_time_string, Fdecode_time, Fencode_time):
9675 (Fcurrent_time_string): Use it.
9676
8be6f318
PE
9677 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9678 * dired.c (make_time): Move to ...
9679 * editfns.c (make_time): ... here.
9680 * systime.h: Note the move.
9681
09d9db2c 96822011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9683
126bc0dc
YM
9684 * fringe.c (update_window_fringes): Remove unused variables.
9685
c47cbdfd
YM
9686 * unexmacosx.c (copy_data_segment): Also copy __got section.
9687 (Bug#8223)
9688
7ac80be9
EZ
96892011-03-12 Eli Zaretskii <eliz@gnu.org>
9690
c96bbc66 9691 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9692 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9693 Constify `char *' arguments and their references according to
9694 prototypes in tparam.h.
9695
ecb0f94d 9696 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9697
7ac80be9
EZ
9698 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9699 Adapt all references accordingly.
9700
9701 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9702
ef1fd07e
TT
97032011-03-11 Tom Tromey <tromey@redhat.com>
9704
9705 * buffer.c (syms_of_buffer): Remove obsolete comment.
9706
7ef4b50c
EZ
97072011-03-11 Eli Zaretskii <eliz@gnu.org>
9708
9709 * termhooks.h (encode_terminal_code): Declare prototype.
9710
9711 * msdos.c (encode_terminal_code): Don't declare prototype.
9712
9713 * term.c (encode_terminal_code): Now external again, used by
9714 w32console.c and msdos.c.
9715
44f230aa
SM
9716 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9717 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9718
4b1ec863 97192011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9720
1714f52b 9721 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9722
4b1ec863
PE
9723 * fringe.c (update_window_fringes): Mark locals as initialized
9724 (Bug#8227).
9725 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9726
524c7aa6
PE
9727 * alloc.c (mark_fringe_data): Move decl from here ...
9728 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9729 to check its interface.
9730 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9731
a5c0af81 9732 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9733 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9734 (fontset_font): Mark local as initialized.
a9a06e0b 9735 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9736
b4716021
PE
9737 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9738
811e9bac 9739 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9740 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9741 (x_own_selection, Fx_disown_selection_internal): Rename locals
9742 to avoid shadowing.
9743 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9744
7e3ab302
PE
9745 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9746 so that the caller can use some name other than gcpro1.
9747 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9748 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9749 (Fx_backspace_delete_keys_p):
9750 Use them to avoid shadowing, and rename vars to avoid shadowing.
9751 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9752 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9753 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9754 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9755 Remove unused locals.
7e3ab302
PE
9756 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9757 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9758 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9759 macros.
f78faa98 9760
e2b13473
PE
9761 * xterm.h (x_mouse_leave): New decl.
9762
77f23912
PE
9763 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9764 Remove unused functions.
cdf4ba58
PE
9765 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9766 (x_calc_absolute_position): Now static.
7411c686 9767 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9768 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9769 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9770 unless they are used.
38d0b34a
PE
9771 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9772 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9773 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9774 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9775 (x_error_catcher, x_connection_closed, x_error_handler):
9776 (x_error_quitter, xembed_send_message, x_iconify_frame):
9777 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9778 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9779 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9780
44f230aa
SM
9781 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9782 Rename or move locals to avoid shadowing.
6b463e58 9783 (tty_defined_color, merge_face_heights): Now static.
5967d051 9784 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9785 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9786 does not deduce is never used uninitialized.
73719eba
PE
9787 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9788 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9789
426994c3 9790 * terminal.c (store_terminal_param): Now static.
5489860b 9791
032f1620 9792 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9793 (set_frame_menubar): Remove unused local.
d4323972 9794 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9795 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9796 since they might point to immutable storage.
281585b0
PE
9797 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9798 since it's unused otherwise.
032f1620 9799
367c19e5 9800 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9801 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9802 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9803 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9804 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9805 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9806 does not deduce are never used uninitialized.
70739cbe 9807
07b48fa9
PE
9808 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9809
8868a238 9810 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9811 * window.c (window_loop, size_window):
9812 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9813
7e5cf297 9814 * window.c (display_buffer): Now static.
d6550a9f
PE
9815 (size_window): Mark variables that gcc -Wuninitialized
9816 does not deduce are never used uninitialized.
a586633d
PE
9817 * window.h (check_all_windows): New decl, to forestall
9818 gcc -Wmissing-prototypes diagnostic.
5b555da1 9819 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9820
f6095868
PE
9821 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9822 shadowing.
9823 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9824 Include <limits.h>.
9825 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9826 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9827 (load_charset_map): Mark variables that gcc -Wuninitialized
9828 does not deduce are never used uninitialized.
53df7c11 9829 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9830
f38b440c
PE
9831 * coding.c (coding_set_source, coding_set_destination):
9832 Use "else { /* comment */ }" rather than "else /* comment */;"
9833 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9834 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9835 a block, when the outer 'i' will do.
9836 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9837 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9838 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9839 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9840 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9841 Rename locals to avoid shadowing.
9842 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9843 * coding.c (emacs_mule_char, encode_invocation_designation):
9844 Now static, since they're not used elsewhere.
413bb2db 9845 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9846 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9847 (decode_coding_emacs_mule): Mark variables that gcc
9848 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9849 (detect_coding_iso_2022): Initialize a local variable that might
9850 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9851 this initialization is needed. (Bug#8211)
5f58e762
PE
9852 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9853 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9854 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9855 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9856 Remove unused macros.
f38b440c 9857
232b38b9 9858 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9859 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9860 * character.c (string_count_byte8): Likewise.
232b38b9 9861
fb90da1b
PE
9862 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9863 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9864
fb93dbc2
PE
9865 * chartab.c (copy_sub_char_table): Now static, since it's not used
9866 elsewhere.
5c156ace
PE
9867 (sub_char_table_ref_and_range, char_table_ref_and_range):
9868 Rename locals to avoid shadowing.
bbcd0949 9869 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9870
7d3b3862 9871 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9872 (BIDI_BOB): Remove unused macro.
7d3b3862 9873
6be7d3da
PE
9874 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9875 deduce are never used uninitialized.
c2ed9c8b 9876 * term.c (encode_terminal_code): Likewise.
6be7d3da 9877
75f8807f 9878 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9879
50938595
PE
9880 * tparam.h: New file.
9881 * term.c, tparam.h: Include it.
9882 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9883 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9884 Move these decls to tparam.h, and make them agree with what
9885 is actually in tparam.c. The previous trick of using incompatible
9886 decls in different modules does not conform to the C standard.
9887 All callers of tparam changed to use tparam's actual API.
9888 * tparam.c (tparam1, tparam, tgoto):
9889 Use const pointers where appropriate.
9890
fbceeba2
PE
9891 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9892 * cm.h (struct cm): Likewise.
9893 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9894 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9895 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9896 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9897 (turn_on_face, init_tty): Likewise.
9898 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9899
7f3f1250
PE
9900 * term.c (term_mouse_position): Rename local to avoid shadowing.
9901
e6ca6543
PE
9902 * alloc.c (mark_ttys): Move decl from here ...
9903 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9904
c40f8d15
AS
99052011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9906
9907 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9908
cfe0661d
JB
99092011-03-09 Juanma Barranquero <lekktu@gmail.com>
9910
9911 * search.c (compile_pattern_1): Remove argument regp, unused since
9912 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9913 (compile_pattern): Don't pass it.
9914
0afb4571
J
99152011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9916
9917 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9918 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9919 for ! HAVE_GTK3.
9920 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9921
9922 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9923
9924 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9925 gdk_window_get_screen, gdk_window_get_geometry,
9926 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9927 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9928 (xg_get_pixbuf_from_pixmap): New function.
9929 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9930 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9931 Call xg_get_pixbuf_from_pixmap instead of
9932 gdk_pixbuf_get_from_drawable.
9933 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9934 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9935 (xg_check_special_colors): Use GtkStyleContext and its functions
9936 for HAVE_GTK3.
9937 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9938 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9939 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9940 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9941 Call gtk_widget_get_preferred_size.
0afb4571
J
9942 (xg_frame_resized): gdk_window_get_geometry only takes 5
9943 parameters.
44f230aa
SM
9944 (xg_win_to_widget, xg_event_is_for_menubar):
9945 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9946 (xg_set_widget_bg): New function.
9947 (delete_cb): New function.
895009e1 9948 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9949 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9950 (xg_set_background_color): Call xg_set_widget_bg.
9951 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9952 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9953 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9954 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9955 if ! HAVE_GTK3.
9956 (update_frame_tool_bar): Call gtk_widget_hide.
9957 (xg_initialize): Use GDK_KEY_g.
9958
9959 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9960 if ! HAVE_GTK3
9961 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9962
9963 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9964 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9965 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9966
1c2cc4ef
JB
99672011-03-08 Juanma Barranquero <lekktu@gmail.com>
9968
9969 * w32xfns.c (select_palette): Check success of RealizePalette against
9970 GDI_ERROR, not zero.
9971
33383987 9972See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9973
9974;; Local Variables:
9975;; coding: utf-8
aac0c6e3
MR
9976;; End:
9977
2f097256 9978 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9979
9980 This file is part of GNU Emacs.
9981
9982 GNU Emacs is free software: you can redistribute it and/or modify
9983 it under the terms of the GNU General Public License as published by
9984 the Free Software Foundation, either version 3 of the License, or
9985 (at your option) any later version.
9986
9987 GNU Emacs is distributed in the hope that it will be useful,
9988 but WITHOUT ANY WARRANTY; without even the implied warranty of
9989 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9990 GNU General Public License for more details.
9991
9992 You should have received a copy of the GNU General Public License
9993 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.