* sound.c (Fplay_sound_internal): Remove cast to unsigned long.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
13bdea59
PE
12011-06-13 Paul Eggert <eggert@cs.ucla.edu>
2
96f53c6c
PE
3 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4 It's more likely to cause problems (due to unsigned overflow)
5 than to cure them.
6
83c77d31
PE
7 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8
ee2079f1
PE
9 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10
6da65536
PE
11 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
12
7147c4a4
PE
13 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
14
193e32d9
PE
15 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
16
e5533da6
PE
17 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
18
9910e595
PE
19 GLYPH_CODE_FACE returns EMACS_INT, not int.
20 * dispextern.h (merge_faces):
21 * xfaces.c (merge_faces):
22 * xdisp.c (get_next_display_element):
23 (next_element_from_display_vector): Don't assume EMACS_INT fits in int.
24
2638320e
PE
25 * character.h (CHAR_VALID_P): Remove unused parameter.
26 * fontset.c, lisp.h, xdisp.c: All uses changed.
27
045eb8d9
PE
28 * editfns.c (Ftranslate_region_internal): Omit redundant test.
29
c1f134b5
PE
30 * fns.c (concat): Minor tuning based on overflow analysis.
31 This doesn't fix any bugs. Use int to hold character, instead
32 of constantly refetching from Emacs object. Use XFASTINT, not
33 XINT, for value known to be a character. Don't bother comparing
34 a single byte to 0400, as it's always less.
35
395fcb93 36 * floatfns.c (Fexpt):
327eeec8
PE
37 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
38
abbd3d23
PE
39 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
40 for characters.
41
684a03ef
PE
42 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
43
0fed43f3
PE
44 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
45 Without this fix, on a 64-bit host (aset S 0 4294967386) would
46 incorrectly succeed when S was a string, because 4294967386 was
47 truncated before it was used.
48
8fd02eb7
PE
49 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
50 Otherwise, an out-of-range integer could cause undefined behavior
51 on a 64-bit host.
52
f8c86b69
PE
53 * composite.c: Use int, not EMACS_INT, for characters.
54 (fill_gstring_body, composition_compute_stop_pos): Use int, not
55 EMACS_INT, for values that are known to be in character range.
56 This doesn't fix any bugs but is the usual style inside Emacs and
57 may generate better code on 32-bit machines.
58
34206dd2
PE
59 Make sure a 64-bit char is never passed to ENCODE_CHAR.
60 This is for reasons similar to the recent CHAR_STRING fix.
61 * charset.c (Fencode_char): Check that character arg is actually
62 a character. Pass an int to ENCODE_CHAR.
63 * charset.h (ENCODE_CHAR): Verify that the character argument is no
64 wider than 'int', as a compile-time check to prevent future regressions
65 in this area.
66
c5958d4c 67 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
68
69 Make sure a 64-bit char is never passed to CHAR_STRING.
70 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
71 by silently ignoring the top 32 bits, allowing some values
72 that were far too large to be valid characters.
73 * character.h: Include <verify.h>.
74 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
75 arguments are no wider than unsigned, as a compile-time check
76 to prevent future regressions in this area.
77 * data.c (Faset):
78 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char):
79 (Fsubst_char_in_region):
80 * fns.c (concat):
81 * xdisp.c (decode_mode_spec_coding):
82 Adjust to CHAR_STRING's new requirement.
83 * editfns.c (Finsert_char, Fsubst_char_in_region):
84 * fns.c (concat): Check that character args are actually
85 characters. Without this test, these functions did the wrong
86 thing with wildly out-of-range values on 64-bit hosts.
87
ea204efb
PE
882011-06-12 Paul Eggert <eggert@cs.ucla.edu>
89
d37ca623
PE
90 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
91 These casts should not be needed on 32-bit hosts, either.
92 * keyboard.c (read_char):
93 * lread.c (Fload): Remove casts to unsigned.
94
ea204efb
PE
95 * lisp.h (UNSIGNED_CMP): New macro.
96 This fixes comparison bugs on 64-bit hosts.
97 (ASCII_CHAR_P): Use it.
98 * casefiddle.c (casify_object):
99 * character.h (ASCII_BYTE_P, CHAR_VALID_P):
100 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
101 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
102 * dispextern.h (FACE_FROM_ID):
103 * keyboard.c (read_char): Use UNSIGNED_CMP.
104
fc83f7d3 1052011-06-11 Paul Eggert <eggert@cs.ucla.edu>
666398f3 106
41cb286c
PE
107 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
108 not to EMACS_INT, to avoid GCC warning.
109
4a1b9832
PE
110 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
111
55daad71
PE
112 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
113 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
114 isn't needed on 32-bit machines.
8f95c75c 115
666398f3 116 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
0ceccced 117 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
118
119 * data.c (Qcompiled_function): Now static.
120
c6f072e7
PE
121 * window.c (window_body_lines): Now static.
122
20ce5912
PE
123 * image.c (gif_load): Rename local to avoid shadowing.
124
9c4c5f81
PE
125 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
126 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
127 * alloc.c (make_save_value): Integer argument is now of type
128 ptrdiff_t, not int.
129 (mark_object): Use ptrdiff_t, not int.
130 * lisp.h (pD): New macro.
131 * print.c (print_object): Use it.
132
c0c5c8ae
PE
133 * alloc.c: Use EMACS_INT, not int, to count objects.
134 (total_conses, total_markers, total_symbols, total_vector_size)
135 (total_free_conses, total_free_markers, total_free_symbols)
136 (total_free_floats, total_floats, total_free_intervals, total_intervals)
137 (total_strings, total_free_strings):
138 Now EMACS_INT, not int. All uses changed.
139 (Fgarbage_collect): Compute overall total using a double, so that
140 integer overflow is less likely to be a problem. Check for overflow
141 when converting back to an integer.
5a25e253
PE
142 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
143 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
144 These were 'int' variables that could overflow on 64-bit hosts;
145 they were never used, so remove them instead of repairing them.
211a0b2a 146 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
147 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
148 Previously, this ceilinged at INT_MAX, but that doesn't work on
149 64-bit machines.
e46bb31a 150 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 151
c78baabf 152 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 153 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
154 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
155 when a (possibly-narrower) signed value would do just as well.
156 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 157
c9d624c6
PE
158 * alloc.c: Catch some string size overflows that we were missing.
159 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
160 for convenience in STRING_BYTES_MAX.
161 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
162 The definition here is exact; the one in lisp.h was approximate.
163 (allocate_string_data): Check for string overflow. This catches
164 some instances we weren't catching before. Also, it catches
165 size_t overflow on (unusual) hosts where SIZE_MAX <= min
166 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
167 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 168
c9d624c6
PE
169 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
170 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
171 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
172
353032ce
PE
173 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
174
2bccce07
PE
175 * alloc.c (Fmake_string): Check for out-of-range init.
176
b50691aa
CY
1772011-06-11 Chong Yidong <cyd@stupidchicken.com>
178
179 * dispextern.h (struct image): Replace data member, whose int_val
180 and ptr_val fields were not used by anything, with a single
181 lisp_val object.
182
183 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
184 (gif_clear_image, gif_load, imagemagick_load_image)
185 (gs_clear_image, gs_load): Callers changed.
186
3f754b86
PE
1872011-06-10 Paul Eggert <eggert@cs.ucla.edu>
188
cca69397
PE
189 * buffer.h: Include <time.h>, for time_t.
190 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
191
109e28d0
PE
192 Fix minor problems found by static checking.
193
60737f02
PE
194 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
195
4b66faf3
PE
196 Make identifiers static if they are not used in other modules.
197 * data.c (Qcompiled_function, Qframe, Qvector):
198 * image.c (QimageMagick, Qsvg):
199 * minibuf.c (Qmetadata):
200 * window.c (resize_window_check, resize_root_window): Now static.
201 * window.h (resize_window_check, resize_root_window): Remove decls.
202
109e28d0
PE
203 * window.c (window_deletion_count, delete_deletable_window):
204 Remove; unused.
46a4ce9e
PE
205 (window_body_lines): Now static.
206 (Fdelete_other_windows_internal): Mark vars as initialized.
207 Make sure 'resize_failed' is initialized.
208 (run_window_configuration_change_hook): Rename local to avoid shadowing.
209 (resize_window_apply): Remove unused local.
210 * window.h (delete_deletable_window): Remove decl.
211
109e28d0 212 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
213 (imagemagick_load_image): Fix pointer signedness problem by changing
214 last arg from unsigned char * to char *. All uses changed.
215 Also, fix a local for similar reasons.
216 Remove unused locals. Remove locals to avoid shadowing.
217 (fn_rsvg_handle_free): Remove; unused.
218 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 219 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 220
3f754b86
PE
221 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
222
2547adb1
CY
2232011-06-10 Chong Yidong <cyd@stupidchicken.com>
224
225 * image.c (gif_load): Fix omitted cast error introduced by
226 2011-06-06 change.
227
2c8e37d4
MR
2282011-06-10 Martin Rudalics <rudalics@gmx.at>
229
230 * window.h (resize_proportionally, orig_total_lines)
231 (orig_top_line): Remove from window structure.
232 (set_window_height, set_window_width, change_window_heights)
233 (Fdelete_window): Remove prototypes.
234 (resize_frame_windows): Remove duplicate declaration.
235
440a42e3
EZ
2362011-06-10 Eli Zaretskii <eliz@gnu.org>
237
238 * window.h (resize_frame_windows, resize_window_check)
239 (delete_deletable_window, resize_root_window)
240 (resize_frame_windows): Declare prototypes.
241
242 * window.c (resize_window_apply): Make definition be "static" to
243 match the prototype.
244
562dd5e9
MR
2452011-06-10 Martin Rudalics <rudalics@gmx.at>
246
247 * window.c: Remove declarations of Qwindow_size_fixed,
248 window_min_size_1, window_min_size_2, window_min_size,
249 size_window, window_fixed_size_p, enlarge_window, delete_window.
250 Remove static from declaration of Qdelete_window, it's
251 temporarily needed by Fbury_buffer.
252 (replace_window): Don't assign orig_top_line and
253 orig_total_lines.
254 (Fdelete_window, delete_window): Remove. Window deletion is
255 handled by window.el.
256 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
257 Fdelete_window calls with calls to Qdelete_window.
258 (Fdelete_other_windows): Remove. Deleting other windows is
259 handled by window.el.
260 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
261 handled in window.el.
262 (window_min_size_2, window_min_size_1, window_min_size): Remove.
263 Window minimum sizes are handled in window.el.
264 (shrink_windows, size_window, set_window_height)
265 (set_window_width, change_window_heights, window_height)
266 (window_width, CURBEG, CURSIZE, enlarge_window)
267 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
268 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
269 handled in window.el.
270 (make_dummy_parent): Rename to make_parent_window and give it a
271 second argument horflag.
272 (make_window): Don't set resize_proportionally any more.
273 (Fsplit_window): Remove. Windows are split in window.el.
274 (save_restore_action, save_restore_orig_size)
275 (shrink_window_lowest_first, save_restore_orig_size): Remove.
276 Resize mini windows in window.el.
277 (grow_mini_window, shrink_mini_window): Implement by calling
278 Qresize_root_window_vertically, resize_window_check and
279 resize_window_apply.
280 (saved_window, Fset_window_configuration, save_window_save): Do
281 not handle orig_top_line, orig_total_lines, and
282 resize_proportionally.
283 (window_min_height, window_min_width): Move to window.el.
284 (keys_of_window): Move bindings for delete-other-windows,
285 split-window, delete-window and enlarge-window to window.el.
286
287 * buffer.c: Temporarily extern Qdelete_window.
288 (Fbury_buffer): Temporarily call Qdelete_window instead of
289 Fdelete_window (Fbury_buffer will move to window.el soon).
290
291 * frame.c (set_menu_bar_lines_1): Remove code handling
292 orig_top_line and orig_total_lines.
293
294 * dispnew.c (adjust_frame_glyphs_initially): Don't use
295 set_window_height but set heights directly.
296 (change_frame_size_1): Use resize_frame_windows.
297
298 * xdisp.c (init_xdisp): Don't use set_window_height but set
299 heights directly.
300
301 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
302 resize_frame_windows instead of change_window_heights and run
303 run_window_configuration_change_hook.
304
305 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
306 instead of change_window_heights and run
307 run_window_configuration_change_hook.
308
1a13852e
MR
3092011-06-09 Martin Rudalics <rudalics@gmx.at>
310
311 * window.c (replace_window): Rename second argument REPLACEMENT to
312 NEW. New third argument SETFLAG. Rewrite.
313 (delete_window, make_dummy_parent): Call replace_window with
314 third argument 1.
315 (window_list_1): Move down in code.
316 (run_window_configuration_change_hook): Move set_buffer part
317 before select_frame_norecord part in order to unwind correctly.
318 Rename count1 to count.
319 (recombine_windows, delete_deletable_window, resize_root_window)
320 (Fdelete_other_windows_internal)
321 (Frun_window_configuration_change_hook, make_parent_window)
322 (resize_window_check, resize_window_apply, Fresize_window_apply)
323 (resize_frame_windows, Fsplit_window_internal)
324 (Fdelete_window_internal, Fresize_mini_window_internal): New
325 functions.
326 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
327
f3d1777e
MR
3282011-06-08 Martin Rudalics <rudalics@gmx.at>
329
496e208e
MR
330 * window.h (window): Add some new members to window structure -
331 normal_lines, normal_cols, new_total, new_normal, clone_number,
332 splits, nest, prev_buffers, next_buffers.
333 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 334 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 335
f3d1777e
MR
336 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
337 Remove.
496e208e
MR
338 (make_dummy_parent): Set new members of windows structure.
339 (make_window): Move down in code. Handle new members of window
340 structure.
341 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
342 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
343 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
344 (Fset_window_prev_buffers, Fwindow_next_buffers)
345 (Fset_window_next_buffers, Fset_window_clone_number): New
346 functions.
347 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
348 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
349 Doc-string fixes.
350 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
351 Argument WINDOW can be now internal window too.
352 (Fwindow_use_time): Move up in code.
353 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
354 Rewrite doc-string.
355 (Fset_window_configuration, saved_window)
356 (Fcurrent_window_configuration, save_window_save): Handle new
357 members of window structure.
b9e809c2
MR
358 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
359 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
360 (syms_of_window): New Lisp objects Qrecord_window_buffer,
361 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
362 Qget_mru_window, Qresize_root_window,
363 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
364 Qauto_buffer_name; staticpro them.
f3d1777e 365
abde8f8c
MR
3662011-06-07 Martin Rudalics <rudalics@gmx.at>
367
368 * window.c (Fwindow_total_size, Fwindow_left_column)
369 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
370 (Fwindow_list_1): New functions.
371 (window_box_text_cols): Replace with window_body_cols.
372 (Fwindow_width, Fscroll_left, Fscroll_right): Use
373 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
374 (delete_window, Fset_window_configuration): Call
375 delete_all_subwindows with window as argument.
376 (delete_all_subwindows): Take a window as argument and not a
377 structure. Rewrite.
190b47e6
MR
378 (window_loop): Remove handling of GET_LRU_WINDOW and
379 GET_LARGEST_WINDOW.
380 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
381
382 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
383 window_box_text_cols. delete_all_subwindows now takes a
384 Lisp_Object as argument.
abde8f8c
MR
385
386 * indent.c (compute_motion, Fcompute_motion): Use
387 window_body_cols instead of window_box_text_cols.
388
fa8a67e6
MR
389 * frame.c (delete_frame): Call delete_all_subwindows with root
390 window as argument.
391
a54e3482
DC
3922011-06-07 Daniel Colascione <dan.colascione@gmail.com>
393
394 * fns.c (Fputhash): Document return value.
395
60002bf5
CY
3962011-06-06 Chong Yidong <cyd@stupidchicken.com>
397
398 * image.c (gif_load): Implement gif89a spec "no disposal" method.
399
0c671da6 4002011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 401
b862a52a 402 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 403
be44ca6c
PE
404 Check for overflow when converting integer to cons and back.
405 * charset.c (Fdefine_charset_internal, Fdecode_char):
406 Use cons_to_unsigned to catch overflow.
407 (Fencode_char): Use INTEGER_TO_CONS.
408 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
409 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
410 * data.c (long_to_cons, cons_to_long): Remove.
411 (cons_to_unsigned, cons_to_signed): New functions.
412 These signal an error for invalid or out-of-range values.
413 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
414 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
415 * font.c (Ffont_variation_glyphs):
416 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
417 * lisp.h: Include <intprops.h>.
418 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
419 (cons_to_signed, cons_to_unsigned): New decls.
420 (long_to_cons, cons_to_long): Remove decls.
421 * undo.c (record_first_change): Use INTEGER_TO_CONS.
422 (Fprimitive_undo): Use CONS_TO_INTEGER.
423 * xfns.c (Fx_window_property): Likewise.
424 * xselect.c: Include <limits.h>.
425 (x_own_selection, selection_data_to_lisp_data):
426 Use INTEGER_TO_CONS.
427 (x_handle_selection_request, x_handle_selection_clear)
428 (x_get_foreign_selection, Fx_disown_selection_internal)
429 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
430 (lisp_data_to_selection_data): Use cons_to_unsigned.
431 (x_fill_property_data): Use cons_to_signed.
432 Report values out of range.
433
d1f3d2af
PE
434 Check for buffer and string overflow more precisely.
435 * buffer.h (BUF_BYTES_MAX): New macro.
436 * lisp.h (STRING_BYTES_MAX): New macro.
437 * alloc.c (Fmake_string):
438 * character.c (string_escape_byte8):
439 * coding.c (coding_alloc_by_realloc):
440 * doprnt.c (doprnt):
441 * editfns.c (Fformat):
442 * eval.c (verror):
443 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
444 since they may not be the same number.
445 * editfns.c (Finsert_char):
446 * fileio.c (Finsert_file_contents):
447 Likewise for BUF_BYTES_MAX.
448
dd52fcea
PE
449 * image.c: Use ptrdiff_t, not int, for sizes.
450 (slurp_file): Switch from int to ptrdiff_t.
451 All uses changed.
452 (slurp_file): Check that file size fits in both size_t (for
453 malloc) and ptrdiff_t (for sanity and safety).
454
7f9bbdbb
PE
455 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
456 if b->modtime has its maximal value.
457
dfe18f82
PE
458 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
459
84acfcf0
PE
460 Don't assume time_t can fit into int.
461 * buffer.h (struct buffer.modtime): Now time_t, not int.
462 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
463 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
464
ccd9a01a
PE
465 Minor fixes for signed vs unsigned integers.
466 * character.h (MAYBE_UNIFY_CHAR):
467 * charset.c (maybe_unify_char):
468 * keyboard.c (read_char, reorder_modifiers):
469 XINT -> XFASTINT, since the integer must be nonnegative.
470 * ftfont.c (ftfont_spec_pattern):
471 * keymap.c (access_keymap, silly_event_symbol_error):
472 XUINT -> XFASTINT, since the integer must be nonnegative.
473 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
474 since it makes no difference and we prefer signed.
475 * keyboard.c (record_char): Use XUINT when all the neighbors do.
476 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
477 nonnegative.
478
d6d100dd
SM
4792011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
480
481 * window.h (Fwindow_frame): Declare.
482
2b6148e4
PE
4832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
484
485 * alloc.c: Simplify handling of large-request failures (Bug#8800).
486 (SPARE_MEMORY): Always define.
487 (LARGE_REQUEST): Remove.
488 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
489
f230ecc9
MR
4902011-06-06 Martin Rudalics <rudalics@gmx.at>
491
727e958e
MR
492 * lisp.h: Move EXFUNS for Fframe_root_window,
493 Fframe_first_window and Fset_frame_selected_window to window.h.
494
495 * window.h: Move EXFUNS for Fframe_root_window,
496 Fframe_first_window and Fset_frame_selected_window here from
497 lisp.h.
498
499 * frame.c (Fwindow_frame, Fframe_first_window)
500 (Fframe_root_window, Fframe_selected_window)
501 (Fset_frame_selected_window): Move to window.c.
502 (Factive_minibuffer_window): Move to minibuf.c.
503 (Fother_visible_frames_p): New function.
504
505 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
506
f230ecc9
MR
507 * window.c (decode_window, decode_any_window): Move up in code.
508 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
509 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
510 (Fwindow_buffer): Move up and rewrite doc-string.
511 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
512 (Fwindow_prev): New functions.
727e958e
MR
513 (Fwindow_frame): Move here from frame.c. Accept any window as
514 argument.
515 (Fframe_root_window, Fframe_first_window)
516 (Fframe_selected_window): Move here from frame.c. Accept frame
517 or arbitrary window as argument. Update doc-strings.
518 (Fminibuffer_window): Move up in code.
519 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
520 (Fset_frame_selected_window): Move here from frame.c.
521 Marginal rewrite.
727e958e
MR
522 (Fselected_window, select_window, Fselect_window): Move up in
523 code. Minor doc-string fixes.
f230ecc9 524
4d09bcf6
PE
5252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
526
527 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
528 Do not assume that spare memory exists; that assumption is valid
529 only if SYSTEM_MALLOC.
530 (LARGE_REQUEST): New macro, so that the issue of large requests
531 is separated from the issue of spare memory.
532
810928a2
AS
5332011-06-05 Andreas Schwab <schwab@linux-m68k.org>
534
172418ad
AS
535 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
536 format. (Bug#8806)
537
43f862f7
AS
538 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
539
810928a2
AS
540 * xfns.c (x_set_scroll_bar_default_width): Move declarations
541 before statements.
542
a059fe24
JD
5432011-06-05 Jan Djärv <jan.h.d@swipnet.se>
544
545 * gtkutil.c (xg_get_default_scrollbar_width): New function.
546
547 * gtkutil.h: Declare xg_get_default_scrollbar_width.
548
549 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
550 min width by calling x_set_scroll_bar_default_width (Bug#8505).
551
989bf368
JB
5522011-06-05 Juanma Barranquero <lekktu@gmail.com>
553
554 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
555
4b80f674
CY
5562011-06-04 Chong Yidong <cyd@stupidchicken.com>
557
558 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
559 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
560 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
561 New error handlers.
4b80f674
CY
562 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
563 Obey Vx_select_enable_clipboard_manager. Catch errors in
564 x_clipboard_manager_save (Bug#8779).
565 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 566 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 567
99a33b77 5682011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
569
570 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
571
99a33b77 5722011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
573
574 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
575 in the current matrix if keep_current_p is non-zero.
576
8264569d
EZ
5772011-06-04 Eli Zaretskii <eliz@gnu.org>
578
579 * bidi.c (bidi_level_of_next_char): Fix last change.
580
57f97249
EZ
5812011-06-03 Eli Zaretskii <eliz@gnu.org>
582
fec2107c 583 Support bidi reordering of text covered by display properties.
57f97249 584
fec2107c
EZ
585 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
586 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
587 (bidi_cache_search, bidi_cache_iterator_state)
588 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
589 (bidi_level_of_next_char, bidi_move_to_visually_next):
590 Support character positions inside a run of characters covered by a
fec2107c
EZ
591 display string.
592 (bidi_paragraph_init, bidi_resolve_explicit_1)
593 (bidi_level_of_next_char): Call bidi_fetch_char and
594 bidi_fetch_char_advance instead of FETCH_CHAR and
595 FETCH_CHAR_ADVANCE.
596 (bidi_init_it): Initialize new members.
597 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
598 definitions.
599 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
600 instead of using explicit *_CHAR codes.
d6d100dd
SM
601 (bidi_resolve_explicit, bidi_resolve_weak):
602 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
603 bidirectional text is supported only in multibyte buffers.
604 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
605 it to initialize the frame_window_p member of struct bidi_it.
606 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
607 (bidi_resolve_explicit, bidi_resolve_weak)
608 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
609 bidi_it->nchars is non-positive.
610 (bidi_level_of_next_char): Don't try to lookup the cache for the
611 next/previous character if nothing is cached there yet, or if we
612 were just reseat()'ed to a new position.
c40e2fb2 613
0e14fe90
EZ
614 * xdisp.c (set_cursor_from_row): Set start and stop points
615 according to the row's direction when priming the loop that looks
616 for the glyph on which to display cursor.
617 (single_display_spec_intangible_p): Function deleted.
618 (display_prop_intangible_p): Reimplement to call
619 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
620 Accept 3 additional arguments needed by handle_display_spec.
621 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
622 values: lists, `(when COND...)' forms, etc.
623 (single_display_spec_string_p): Support property values that are
624 lists with the argument STRING its top-level element.
625 (display_prop_string_p): Fix the condition for processing a
626 property that is a list to be consistent with handle_display_spec.
fec2107c 627 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
628 last portion of handle_display_prop.
629 (compute_display_string_pos): Accept additional argument
630 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
631 value of a `display' property is a "replacing spec".
632 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
633 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
634 the display property, but just return a value indicating whether
635 the display property will replace the characters it covers.
636 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
637 frame_window_p members of struct bidi_it.
d6d100dd
SM
638 (compute_display_string_pos, compute_display_string_end):
639 New functions.
fec2107c
EZ
640 (push_it): Accept second argument POSITION, where pop_it should
641 jump to continue iteration.
642 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 643
fec2107c
EZ
644 * keyboard.c (adjust_point_for_property): Adjust the call to
645 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
646
647 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
648 (bidi_init_it): Update prototypes.
649 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
650 (compute_display_string_pos, compute_display_string_end):
651 Declare prototypes.
fec2107c
EZ
652 (struct bidi_it): New members nchars and disp_pos. ch_len is now
653 EMACS_INT.
fc6f18ce 654
40087514 6552011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 656
57f53182
PE
657 Malloc failure behavior now depends on size of allocation.
658 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
659 * lisp.h: Change signatures accordingly.
660 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
661 All callers changed. (Bug#8762)
662
663 * gnutls.c: Use Emacs's memory allocators.
664 Without this change, the gnutls library would invoke malloc etc.
665 directly, which causes problems on non-SYNC_INPUT hosts, and which
666 runs afoul of improving memory_full behavior. (Bug#8761)
667 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
668 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
669 xfree instead of the default malloc, realloc, free.
670 (Fgnutls_boot): No need to check for memory allocation failure,
671 since xmalloc does that for us.
672
ac32cd99 673 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
674 * category.c (hash_get_category_set):
675 * ccl.c (ccl_driver):
676 * charset.c (Fdefine_charset_internal):
677 * charset.h (struct charset.hash_index):
678 * composite.c (get_composition_id, gstring_lookup_cache)
679 (composition_gstring_put_cache):
680 * composite.h (struct composition.hash_index):
681 * dispextern.h (struct image.hash):
682 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
683 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
684 (hashfn_equal, hashfn_user_defined, make_hash_table)
685 (maybe_resize_hash_table, hash_lookup, hash_put)
686 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
687 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
688 (Fsxhash, Fgethash, Fputhash, Fmaphash):
689 * image.c (make_image, search_image_cache, lookup_image)
690 (xpm_put_color_table_h):
691 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 692 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
693 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
694 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
695 * alloc.c (allocate_vectorlike):
696 Check for overflow in vector size calculations.
697 * ccl.c (ccl_driver):
698 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
699 * fns.c, image.c: Remove unnecessary static decls that would otherwise
700 need to be updated by these changes.
40087514
PE
701 * fns.c (make_hash_table, maybe_resize_hash_table):
702 Check for integer overflow with large hash tables.
0de4bb68
PE
703 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
704 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
705 (SXHASH_REDUCE): New macro.
706 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
707 Use it instead of discarding useful hash info with large hash values.
708 (sxhash_float): New function.
709 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
710 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
711 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
712 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
713 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
714 Adjust signatures to match updated version of code.
715 (consing_since_gc): Now EMACS_INT, since a single hash table can
716 use more than INT_MAX bytes.
717
698d32e2
DN
7182011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
719
720 Make it possible to build with GCC-4.6+ -O2 -flto.
721
722 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
723
fd6fa53f
SM
7242011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
725
726 * minibuf.c (get_minibuffer, read_minibuf_unwind):
727 Call minibuffer-inactive-mode.
728
864db017
JB
7292011-05-31 Juanma Barranquero <lekktu@gmail.com>
730
731 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
732 Update dependencies.
733
2ad0baf4
DN
7342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
735
736 * data.c (init_data): Remove code for UTS, this system is not
737 supported anymore.
738
4fcc2638
DN
7392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
740
741 Don't force ./temacs to start in terminal mode.
742
743 * frame.c (make_initial_frame): Initialize faces in all cases, not
744 only when CANNOT_DUMP is defined.
745 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
746
c56e0fd5
DN
7472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
748
749 * dispnew.c (add_window_display_history): Use const for the string
750 pointer. Remove declaration, not needed.
751
333d54da 7522011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 753
55d4c1b2 754 Use 'inline', not 'INLINE'.
333d54da 755 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
756 * alloc.c, fontset.c (INLINE): Remove.
757 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
758 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
759 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
760 * gmalloc.c (register_heapinfo): Use inline unconditionally.
761 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
762
738db178
DN
7632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
764
765 Make it possible to run ./temacs.
766
767 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
768 syms_of_callproc does the same thing. Remove test for
769 "initialized", do it in the caller.
770 * emacs.c (main): Avoid calling set_initial_environment when dumping.
771
620c53a6
SM
7722011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
773
774 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
775 (read_minibuf): Use get_minibuffer.
776 (syms_of_minibuf): Use DEFSYM.
777 (Qmetadata): New var.
778 * data.c (Qbuffer): Don't make it static.
779 (syms_of_data): Use DEFSYM.
780
e003a292
PE
7812011-05-31 Paul Eggert <eggert@cs.ucla.edu>
782
783 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
784 (CCL_CODE_MIN): New macro.
785
ed008a6d
PE
7862011-05-30 Paul Eggert <eggert@cs.ucla.edu>
787
3687c2ef
PE
788 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
789
ed008a6d
PE
790 * eval.c (Qdebug): Now static.
791 * lisp.h (Qdebug): Remove decl. This reverts a part of the
792 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
793 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
794
d66c4c7c
CY
7952011-05-29 Chong Yidong <cyd@stupidchicken.com>
796
797 * image.c: Various fixes to ImageMagick code comments.
798 (Fimagemagick_types): Doc fix.
799
5fbc2025
PE
8002011-05-29 Paul Eggert <eggert@cs.ucla.edu>
801
0196f88a
PE
802 Minor fixes prompted by GCC 4.6.0 warnings.
803
804 * xselect.c (converted_selections, conversion_fail_tag): Now static.
805
5fbc2025
PE
806 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
807 (x_clipboard_manager_save_all): Move extern decl to ...
808 * xterm.h: ... here, so that it can be checked for consistency.
809
1dd3c2d9
CY
8102011-05-29 Chong Yidong <cyd@stupidchicken.com>
811
812 * xselect.c (x_clipboard_manager_save_frame)
813 (x_clipboard_manager_save_all): New functions.
814 (Fx_clipboard_manager_save): Lisp function deleted.
815
816 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
817 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
818
819 * xterm.h: Update prototype.
820
5ba6571d
WX
8212011-05-28 William Xu <william.xwl@gmail.com>
822
823 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
824 exiting (Bug#8239).
825
3eaff834
JM
8262011-05-28 Jim Meyering <meyering@redhat.com>
827
e1900994 828 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
829 * fns.c (to_uchar): Define.
830 (crypto_hash_function): Use it to convert some newly-signed
831 variables to unsigned, to avoid sign-extension bugs. For example,
832 without this change, (md5 "truc") would evaluate to
833 45723a2aff78ff4fff7fff1114760e62 rather than the expected
834 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 835 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 836
0f6990a7
PE
8372011-05-27 Paul Eggert <eggert@cs.ucla.edu>
838
839 Integer overflow fixes.
c8a9ca5a 840
08686060
PE
841 * dbusbind.c: Serial number integer overflow fixes.
842 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
843 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
844 to hold a serial number that is too large for a fixnum.
845 (Fdbus_method_return_internal, Fdbus_method_error_internal):
846 Check for serial numbers out of range. Decode any serial number
59568bf0 847 that was so large that it became a float. (Bug#8722)
08686060 848
2d1fc3c7
PE
849 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
850 (Fdbus_call_method, Fdbus_call_method_asynchronously):
851 Use XFASTINT rather than XUINT when numbers are nonnegative.
852 (xd_append_arg, Fdbus_method_return_internal):
853 (Fdbus_method_error_internal): Likewise. Also, for unsigned
854 arguments, check that Lisp number is nonnegative, rather than
59568bf0 855 silently wrapping negative numbers around. (Bug#8722)
30217ff0 856 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 857 (Bug#8722)
2d1fc3c7 858
c8a9ca5a
PE
859 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
860
519e1d69
PE
861 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
862
30569699
PE
863 ccl: add integer overflow checks
864 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
865 (IN_INT_RANGE): New macros.
866 (ccl_driver): Use them to check for integer overflow when
867 decoding a CCL program. Many of the new checks are whether XINT (x)
868 fits in int; it doesn't always, on 64-bit hosts. The new version
869 doesn't catch all possible integer overflows, but it's an
847044ea 870 improvement. (Bug#8719)
30569699 871
c11285dc
PE
872 * alloc.c (make_event_array): Use XINT, not XUINT.
873 There's no need for unsigned here.
874
fdccd48e
PE
875 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
876 This follows up to the 2011-05-06 change that substituted uintptr_t
877 for EMACS_INT. This case wasn't caught back then.
878
37910ab2
PE
879 Rework Fformat to avoid integer overflow issues.
880 * editfns.c: Include <float.h> unconditionally, as it's everywhere
881 now (part of C89). Include <verify.h>.
882 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
883 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
884 (Fformat): Avoid the prepass trying to compute sizes; it was only
885 approximate and thus did not catch overflow reliably. Instead, walk
886 through the format just once, formatting and computing sizes as we go,
887 checking for integer overflow at every step, and allocating a larger
888 buffer as needed. Keep track separately whether the format is
889 multibyte. Keep only the most-recently calculated precision, rather
890 than them all. Record whether each argument has been converted to
891 string. Use EMACS_INT, not int, for byte and char and arg counts.
892 Support field widths and precisions larger than INT_MAX. Avoid
893 sprintf's undefined behavior with conversion specifications such as %#d
894 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
895 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
896 formatting out-of-range floating point numbers with int
897 formats. (Bug#8668)
898
2e6578fb
PE
899 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
900
0ae6bdee
PE
901 * data.c: Avoid integer truncation in expressions involving floats.
902 * data.c: Include <intprops.h>.
903 (arith_driver): When there's an integer overflow in an expression
904 involving floating point, convert the integers to floating point
905 so that the resulting value does not suffer from catastrophic
906 integer truncation. For example, on a 64-bit host (* 4
907 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
908 Do not rely on undefined behavior after integer overflow.
909
de883a70
PE
910 merge count_size_as_multibyte, parse_str_to_multibyte
911 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 912 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
913 Check for integer overflow.
914 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
915 since it's now a duplicate of the other. This is more of
916 a character than a buffer op, so better that it's in character.c.
917 * fns.c, print.c: Adjust to above changes.
918
2ff916cb
PE
9192011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
920
921 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
922
f1b54466
PE
9232011-05-27 Paul Eggert <eggert@cs.ucla.edu>
924
fb1ac845
PE
925 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
926 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
927 (x_clipboard_manager_save): Now static.
928 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
929
f1b54466
PE
930 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
931 (crypto_hash_function): Now static.
932 Fix pointer signedness problems. Avoid unnecessary initializations.
933
a9f737ee
CY
9342011-05-27 Chong Yidong <cyd@stupidchicken.com>
935
936 * termhooks.h (Vselection_alist): Make it terminal-local.
937
938 * terminal.c (create_terminal): Initialize it.
939
940 * xselect.c: Support for clipboard managers.
941 (Vselection_alist): Move to termhooks.h as terminal-local var.
942 (LOCAL_SELECTION): New macro.
943 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
944 (symbol_to_x_atom): Remove gratuitous arg.
945 (x_handle_selection_request, lisp_data_to_selection_data)
946 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
947 (x_own_selection, x_get_local_selection, x_convert_selection):
948 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
949 (some_frame_on_display): Delete unused function.
950 (Fx_own_selection_internal, Fx_get_selection_internal)
951 (Fx_disown_selection_internal, Fx_selection_owner_p)
952 (Fx_selection_exists_p): New optional frame arg.
953 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
954 (x_handle_selection_clear): Don't treat other terminals with the
955 same keyboard specially. Use the terminal-local Vselection_alist.
956 (x_clear_frame_selections): Use Frun_hook_with_args.
957
958 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
959
960 * xterm.h: Add support for those atoms.
961
e067f0c1
CY
9622011-05-26 Chong Yidong <cyd@stupidchicken.com>
963
964 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
965 (converted_selections, conversion_fail_tag): New global variables.
966 (x_selection_request_lisp_error): Free the above.
967 (x_get_local_selection): Remove unnecessary code.
968 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
969 of converted selections stored in converted_selections.
970 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
971 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
972 (x_convert_selection): New function.
973 (x_handle_selection_event): Simplify.
974 (x_get_foreign_selection): Don't ignore incoming requests while
975 waiting for an answer; this will fail when we implement
976 SAVE_TARGETS, and seems unnecessary anyway.
977 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
978 (Vx_sent_selection_functions): Doc fix.
979
0f4aebc0
LL
9802011-05-26 Leo Liu <sdl.web@gmail.com>
981
982 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
983
e61124cd
YM
9842011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
985
986 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
987
988 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
989 for fringe update if it has periodic bitmap.
990 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
991 and fringe_bitmap_periodic_p.
992
993 * fringe.c (get_fringe_bitmap_data): New function.
994 (draw_fringe_bitmap_1, update_window_fringes): Use it.
995 (update_window_fringes): Record periodicity of fringe bitmap in glyph
996 row. Mark glyph row for fringe update if periodicity changed.
997
998 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
999 for fringe update unless it has periodic bitmap.
1000
f16d9837
KH
10012011-05-25 Kenichi Handa <handa@m17n.org>
1002
1003 * xdisp.c (get_next_display_element): Set correct it->face_id for
1004 a static composition.
1005
e1b90ef6
LL
10062011-05-24 Leo Liu <sdl.web@gmail.com>
1007
1008 * deps.mk (fns.o):
1009 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1010
1011 * fns.c (crypto_hash_function, Fsha1): New function.
1012 (Fmd5): Use crypto_hash_function.
1013 (syms_of_fns): Add Ssha1.
1014
7400048f
PE
10152011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 * gnutls.c: Remove unused macros.
1018 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1019 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1020 Remove macros that are defined and never used.
1021 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1022
abb71cf4
CY
10232011-05-22 Chong Yidong <cyd@stupidchicken.com>
1024
1025 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1026 (Fx_get_selection_internal): Minor cleanup.
1027 (Fx_own_selection_internal): Rename arguments for consistency with
1028 select.el.
1029
6307db39
PE
10302011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1031
1032 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1033
f3d4e0a4
CY
10342011-05-22 Chong Yidong <cyd@stupidchicken.com>
1035
1036 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1037
4d8ade89
YM
10382011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1039
1040 * dispnew.c (scrolling_window): Don't exclude the case that the
1041 last enabled row in the desired matrix touches the bottom boundary.
1042
32078c8d
GM
10432011-05-21 Glenn Morris <rgm@gnu.org>
1044
1045 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1046 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1047 and add some more files.
32078c8d 1048
7285dc67
EZ
10492011-05-20 Eli Zaretskii <eliz@gnu.org>
1050
1051 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1052 report_file_error introduced by the change from 2011-05-07.
1053
89d1bd22
PE
10542011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1055
1056 * systime.h (Time): Define only if emacs is defined.
1057 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1058 where the include path doesn't have X11/X.h by default. See
1059 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1060
e23640bb 10612011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1062
1063 * composite.c (find_automatic_composition): Fix previous change.
1064
b9704ad9
GM
10652011-05-20 Glenn Morris <rgm@gnu.org>
1066
1067 * lisp.mk: New file, split from Makefile.in.
1068 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1069 (shortlisp): Remove.
1070 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1071
4a720484
GM
10722011-05-19 Glenn Morris <rgm@gnu.org>
1073
1074 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1075 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1076 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1077 (lisp): Set the order to that of loadup.el.
1078 (shortlisp): Make it a copy of $lisp.
1079 (SOME_MACHINE_LISP): Remove.
1080 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1081 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1082
a28d4396
KH
10832011-05-18 Kenichi Handa <handa@m17n.org>
1084
1085 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1086 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1087 (find_automatic_composition): Mostly rewrite for efficiency.
1088
a2b1fa8e
JB
10892011-05-18 Juanma Barranquero <lekktu@gmail.com>
1090
1091 * makefile.w32-in: Update dependencies.
1092
8e1f5610
CS
10932011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1094
1095 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1096 revision 104625).
1097
7025ee00 10982011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1099
cdfa6eab
PE
1100 Fix some integer overflow issues, such as string length overflow.
1101
06d6db33
PE
1102 * insdel.c (count_size_as_multibyte): Check for string overflow.
1103
2b4560a8
PE
1104 * character.c (lisp_string_width): Check for string overflow.
1105 Use EMACS_INT, not int, for string indexes and lengths; in
1106 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1107 the resulting string length overflows an EMACS_INT; instead,
1108 report a string overflow if no precision given. When checking for
1109 precision exhaustion, use a check that cannot possibly have
1110 integer overflow. (Bug#8675)
1111 * character.h (lisp_string_width): Adjust to new signature.
1112
cb93f9be
PE
1113 * alloc.c (string_overflow): New function.
1114 (Fmake_string): Use it. This doesn't change behavior, but saves
1115 a few bytes and will simplify future changes.
1116 * character.c (string_escape_byte8): Likewise.
1117 * lisp.h (string_overflow): New decl.
1118
1a1f3366
PE
1119 Fixups, following up to the user-interface timestamp change.
1120 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1121 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1122 * msdos.c (mouse_get_pos): Likewise.
1123 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1124 * w32gui.h (Time): Define by including "systime.h" rather than by
1125 declaring it ourselves. (Bug#8664)
1126
d4e3e4d3
PE
1127 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1128 * image.c (clear_image_cache): Likewise.
1129
f6a24d19
PE
1130 * term.c (term_mouse_position): Don't assume time_t wraparound.
1131
08dc5ae6
PE
1132 Be more systematic about user-interface timestamps.
1133 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1134 and sometimes 'EMACS_UINT', to represent these timestamps.
1135 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1136 This makes the code easier to follow, and makes it easier to catch
1137 integer overflow bugs such as Bug#8664.
1138 * frame.c (Fmouse_position, Fmouse_pixel_position):
1139 Use Time, not unsigned long, for user-interface timestamps.
1140 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1141 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1142 * keyboard.h (last_event_timestamp): Likewise.
1143 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1144 * menu.h (xmenu_show): Likewise.
1145 * term.c (term_mouse_position): Likewise.
1146 * termhooks.h (struct input_event.timestamp): Likewise.
1147 (struct terminal.mouse_position_hook): Likewise.
1148 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1149 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1150 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1151 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1152 what it was before.
1153 * menu.h, termhooks.h: Include "systime.h", for Time.
1154
8e55734a
PE
1155 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1156 Don't assume that the difference between two unsigned long values
1157 can fit into an integer. At this point, we know button_down_time
1158 <= event->timestamp, so the difference must be nonnegative, so
1159 there's no need to cast the result if double-click-time is
1160 nonnegative, as it should be; check that it's nonnegative, just in
1161 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1162 apart (about 25 days). (Bug#8664)
8e55734a 1163
841f1b75 1164 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1165 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1166
3e26f69c
PE
1167 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1168 that always fit in int. Use a sentinel instead of a counter, to
1169 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1170 * frame.h (struct frame): Use int for menu_bar_items_used
1171 instead of EMACS_INT, since it always fits in int.
3e26f69c 1172
5cc152c0
PE
1173 * menu.c (grow_menu_items): Check for int overflow.
1174
d89eb65e
PE
1175 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1176
5235bd3e
PE
1177 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1178 Before, the code was not consistent. These values cannot exceed
1179 2**31 - 1 so there's no need to make them unsigned.
1180 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1181 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1182 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1183 as modifiers.
1184 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1185
bc827e23
PE
1186 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1187 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1188 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1189 presumably because the widths might not match.
1190
78eb494e
PE
1191 * window.c (size_window): Avoid needless test at loop start.
1192
04f2d78b
CB
11932011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1194
1195 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1196
d2fc7e3d 11972011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1198
1199 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1200
d2fc7e3d 12012011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1202
1203 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1204 `width' to `bar_area_x' and `bar_area_width', respectively.
1205 (x_scroll_run): Take account of fringe background extension.
1206
04f2d78b
CB
1207 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1208 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1209 `bar_area_width', respectively.
1210 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1211 background extension.
1212
79b70037
GM
12132011-05-10 Jim Meyering <meyering@redhat.com>
1214
1215 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1216
2f142cc5
JB
12172011-05-10 Juanma Barranquero <lekktu@gmail.com>
1218
1219 * image.c (Finit_image_library): Return t for built-in image types,
1220 like pbm and xbm. (Bug#8640)
1221
57679c86
AS
12222011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1223
1224 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1225
888c9e86
EZ
12262011-05-07 Eli Zaretskii <eliz@gnu.org>
1227
b0512a1d
EZ
1228 * w32console.c (Fset_screen_color): Doc fix.
1229 (Fget_screen_color): New function.
1230 (syms_of_ntterm): Defsubr it.
1231
7285dc67
EZ
1232 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1233 unlink the temporary file if Fcall_process didn't create it in the
1234 first place.
1235 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1236 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1237 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1238 cue to call_process_cleanup not to close that handle.
1239
4d3fcc8e
BK
12402011-05-07 Ben Key <bkey76@gmail.com>
1241
1242 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1243 one of two shell specific rules, either bootstrap-temacs-CMD or
1244 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1245 to the previous implementation of the bootstrap-temacs rule.
1246 The bootstrap-temacs-CMD rule is similar to the previous
1247 implementation of the bootstrap-temacs rule except that it
1248 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1249 variable.
1250
1251 These changes, along with some changes to nt/configure.bat,
1252 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1253 earlier fix to add support for --cflags and --ldflags options
1254 that include quotes so that it works whether make uses cmd or
1255 sh as the shell.
1256
b4289b64
MA
12572011-05-06 Michael Albinus <michael.albinus@gmx.de>
1258
1259 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1260 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1261 is a constant.
1262 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1263 a string. Handle both cases.
1264 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1265 (Fdbus_register_method): Use Qinvalid_function.
1266
af4c0e28
JB
12672011-05-06 Juanma Barranquero <lekktu@gmail.com>
1268
1269 * makefile.w32-in: Update dependencies.
1270 (LISP_H): Add inttypes.h and stdin.h.
1271 (PROCESS_H): Add unistd.h.
1272
c51453d9
EZ
12732011-05-06 Eli Zaretskii <eliz@gnu.org>
1274
1275 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1276 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1277
8ff0ac3c 12782011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1279
4c4b566b
PE
1280 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1281
aab2b9b5
PE
1282 * term.c (vfatal): Remove stray call to va_end.
1283 It's not needed and the C Standard doesn't allow it here anyway.
1284
c378da0b
PE
1285 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1286 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1287
288b08c7
PE
1288 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1289 bytes.
1290
e3601888
PE
1291 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1292
db6c0e74
PE
1293 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1294
dd5963ea
PE
1295 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1296
88c9450f
PE
1297 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1298
2f9442b8
PE
1299 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1300
c032b5f8
PE
1301 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1302 * charset.c (Fdefine_charset_internal): Don't initialize
1303 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1304 32-bit int (Bug#8600).
a108c10b
PE
1305
1306 * lread.c (read_integer): Be more consistent with string-to-number.
1307 Use string_to_number to do the actual conversion; this avoids
1308 rounding errors and fixes some other screwups. Without this fix,
1309 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1310 (digit_to_number): Move earlier, for benefit of read_integer.
1311 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1312 not a digit in any supported base. (Bug#8602)
a108c10b 1313
ad5f9eea
PE
1314 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1315
aec1708a
PE
1316 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1317 to match comment at start of function. This also removes a
1318 GCC warning about overflow in a 32+64-bit port.
1319
47be4ab5
PE
1320 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1321
371cac43
PE
1322 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1323 Reported by Stefan Monnier in
1324 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1325 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1326 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1327
d01a7826
PE
1328 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1329 (EMACS_UINTPTR): Likewise, with uintptr_t.
1330
7fd47d5c
PE
1331 * lisp.h: Prefer 64-bit EMACS_INT if available.
1332 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1333 on 32-bit hosts that have 64-bit int, so that they can access
1334 large files.
122b0c86
PE
1335 However, temporarily disable this change unless the temporary
1336 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1337
8727937b
PE
1338 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1339
8ac068ac
PE
1340 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1341 This removes an assumption that EMACS_INT and long are the same
1342 width as pointers. The assumption is true for Emacs porting targets
1343 now, but we want to make other targets possible.
1344 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1345 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1346 In the rest of the code, change types of integers that hold casted
1347 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1348 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1349 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1350 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1351 No need to cast type when ORing.
1352 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1353 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1354 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1355 assume EMACS_INT is the same width as char *.
1356 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1357 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1358 Remove no-longer-needed casts.
1359 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1360 (xg_tool_bar_help_callback, xg_make_tool_item):
1361 Use EMACS_INTPTR to hold an integer
1362 that will be cast to void *; this can avoid a GCC warning
1363 if EMACS_INT is not the same width as void *.
1364 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1365 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1366 (current_message_1, set_message_1):
1367 Use a local to convert to proper width without a cast.
1368 * xmenu.c (dialog_selection_callback): Likewise.
1369
ede49d71
PE
1370 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1371 Also, don't assume VALBITS / RAND_BITS is less than 5,
1372 and don't rely on undefined behavior when shifting a 1 left into
1373 the sign bit.
1374 * lisp.h (get_random): Change signature to match.
1375
2f30ecd0
PE
1376 * lread.c (hash_string): Use size_t, not int, for hash computation.
1377 Normally we prefer signed values; but hashing is special, because
1378 it's better to use unsigned division on hash table sizes so that
1379 the remainder is nonnegative. Also, size_t is the natural width
1380 for hashing into memory. The previous code used 'int', which doesn't
1381 retain enough info to hash well into very large tables.
1382 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1383
2a866e7b
PE
1384 * dbusbind.c: Don't possibly lose pointer info when converting.
1385 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1386 Use XPNTR rather than XHASH, so that the high-order bits of
1387 the pointer aren't lost when converting through void *.
1388
51639eac
PE
1389 * eval.c (Fautoload): Don't double-shift a pointer.
1390
92394119
PE
1391 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1392
dbdb9a7c
JB
13932011-05-06 Juanma Barranquero <lekktu@gmail.com>
1394
1395 * gnutls.c (DEF_GNUTLS_FN):
1396 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1397
db7a0b4f
AS
13982011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1399
1400 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1401 marker. (Bug#8610)
1402
f7ff1b0f 14032011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1404
1405 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1406 New version that can reserve upto 2GB of heap space.
1407
f7ff1b0f 14082011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1409
1410 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1411
639c109b
TZ
14122011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1413
1414 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1415 `gnutls_certificate_set_x509_key_file'.
1416
d2127135
JB
14172011-05-05 Juanma Barranquero <lekktu@gmail.com>
1418
1419 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1420 Update dependencies.
1421
e968f4f3
JB
14222011-05-04 Juanma Barranquero <lekktu@gmail.com>
1423
1424 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1425 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1426 Remove unused parameter `fildes'.
1427 * process.c (read_process_output, send_process): Don't pass it.
1428
84d358f0
JB
14292011-05-04 Juanma Barranquero <lekktu@gmail.com>
1430
1431 Fix previous change: the library cache is defined in w32.c.
1432 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1433 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1434
0898ca10
JB
14352011-05-04 Juanma Barranquero <lekktu@gmail.com>
1436
1437 Implement dynamic loading of GnuTLS on Windows.
1438
1439 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1440 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1441 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1442 Declare.
1443
1444 * gnutls.c (Qgnutls_dll): Define.
1445 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1446 (gnutls_*): Declare function pointers.
1447 (init_gnutls_functions): New function to initialize function pointers.
1448 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1449 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1450 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1451 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1452 (emacs_gnutls_write, emacs_gnutls_read)
1453 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1454 (Fgnutls_available_p): New function.
1455 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1456 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1457 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1458
1459 * image.c: Include w32.h.
1460 (Vimage_type_cache): Delete.
1461 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1462 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1463 (w32_delayed_load): Move to w32.c.
1464
1465 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1466
1467 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1468 (w32_delayed_load): Move from image.c. When loading a library, record
1469 its filename in the :loaded-from property of the library id.
1470 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1471 Initialize and staticpro them.
1472 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1473
1474 * process.c: Include lisp.h before w32.h, not after.
1475 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1476 instead of gnutls_record_check_pending.
1477
1478 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1479
ff4de4aa
TZ
14802011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1481
1482 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1483 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1484 as passed in.
1485
abe95abb
JD
14862011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1487
1488 * xterm.c (x_set_frame_alpha): Do not set property on anything
1489 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1490
e16e55d4
JB
14912011-05-02 Juanma Barranquero <lekktu@gmail.com>
1492
1493 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1494
bafcf6a5
JB
14952011-05-02 Juanma Barranquero <lekktu@gmail.com>
1496
1497 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1498 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1499 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1500 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1501 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1502 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1503 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1504 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1505 (Qgnutls_bootprop_callbacks_verify): Make static.
1506
e7a6747f
AS
15072011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1508
19ed11ba
AS
1509 * callproc.c: Indentation fixup.
1510
e7a6747f 1511 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1512 (wait_for_termination, interruptible_wait_for_termination):
1513 Move after wait_for_termination_1.
e7a6747f 1514
1ef14cb4
LMI
15152011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1516
1517 * sysdep.c (interruptible_wait_for_termination): New function
1518 which is like wait_for_termination, but allows keyboard
1519 interruptions.
1520
1521 * callproc.c (Fcall_process): Add (:file "file") as an option for
1522 the STDOUT buffer.
1523 (Fcall_process_region): Ditto.
1524
330d880c
EZ
15252011-04-30 Eli Zaretskii <eliz@gnu.org>
1526
8db90b73
EZ
1527 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1528 rather than `XVECTOR (FOO)->size'.
1529
330d880c
EZ
1530 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1531 inttypes.h, as a gnulib replacement is used if it not available in
1532 system headers.
1533
15cbd324
EZ
15342011-04-21 Eli Zaretskii <eliz@gnu.org>
1535
1536 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1537 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1538 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1539
1540 * coding.c (coding_alloc_by_realloc): Error out if destination
1541 will grow beyond MOST_POSITIVE_FIXNUM.
1542 (decode_coding_emacs_mule): Abort if there isn't enough place in
1543 charbuf for the composition carryover bytes. Reserve an extra
1544 space for up to 2 characters produced in a loop.
1545 (decode_coding_iso_2022): Abort if there isn't enough place in
1546 charbuf for the composition carryover bytes.
1547
15482011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1549
ae940cca
EZ
1550 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1551 aborting when %lld or %lll format is passed.
1552 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1553 %llo or %llx format is passed. (Bug#8545)
1554
03ab8921
EZ
1555 * window.c (window_scroll_line_based): Use a marker instead of
1556 simple variables to record original value of point. (Bug#7952)
1557
afda1437
EZ
1558 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1559 produced by %s or %c overflows available buffer space. (Bug#8545)
1560
f76dee0c
PE
15612011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1562
1563 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1564 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1565
fdc5744d
JB
15662011-04-28 Juanma Barranquero <lekktu@gmail.com>
1567
1568 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1569
638f053a
JB
15702011-04-28 Juanma Barranquero <lekktu@gmail.com>
1571
1572 * keyboard.c (Qdelayed_warnings_hook): Define.
1573 (command_loop_1): Run `delayed-warnings-hook'
1574 if Vdelayed_warnings_list is non-nil.
1575 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1576 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1577
d178f871
EZ
15782011-04-28 Eli Zaretskii <eliz@gnu.org>
1579
1580 * doprnt.c (doprnt): Don't return value smaller than the buffer
1581 size if the message was truncated. (Bug#8545).
1582
b124fd93
JB
15832011-04-28 Juanma Barranquero <lekktu@gmail.com>
1584
1585 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1586 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1587
e810457d
PE
15882011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1589
1590 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1591
ea51cceb
JB
15922011-04-27 Juanma Barranquero <lekktu@gmail.com>
1593
1594 * makefile.w32-in: Update dependencies.
1595
94dcfacf
EZ
15962011-04-27 Eli Zaretskii <eliz@gnu.org>
1597
1598 Improve `doprnt' and its usage. (Bug#8545)
1599 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1600 `format_end'. Remove support for %l as a conversion specifier.
1601 Don't use xrealloc. Improve diagnostics when the %l size modifier
1602 is used. Update the commentary.
1603
1604 * eval.c (verror): Simplify calculation of size_t.
1605
1606 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1607 messages.
1608
f61f41d7
PE
16092011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1610
1611 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1612 change.
1613
96fb4434
PE
16142011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1615
1616 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1617 This makes this file independent of the recent pseudovector change.
1618
671875da 16192011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1620
69e9b5a3
PE
1621 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1622
b5f869a7 1623 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1624 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1625 Remove unused local.
c8926152 1626 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1627
841a1577 1628 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1629 GCC 4.6.0 optimizes based on type-based alias analysis.
1630 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1631 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1632 != &v->size, and therefore "v->size = 1; b->size = 2; return
1633 v->size;" must therefore return 1. This assumption is incorrect
1634 for Emacs, since it type-puns struct Lisp_Vector * with many other
1635 types. To fix this problem, this patch adds a new type struct
f904488f 1636 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1637 and pseudovectors, and helps optimizing compilers not get fooled
1638 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1639 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1640 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1641 the size member.
eab3844f
PE
1642 (XSETPVECTYPE): Rewrite in terms of new macro.
1643 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1644 This is a bit clearer, and further avoids the possibility of
1645 undesirable aliasing.
1646 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1647 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1648 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1649 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1650 (ASIZE): Now uses header.size rather than size.
1651 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1652 to avoid the hassle of writing XVECTOR (foo)->header.size.
1653 (struct vectorlike_header): New type.
eab3844f
PE
1654 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1655 object, to help avoid aliasing.
1656 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1657 (SUBRP): Likewise, since Lisp_Subr is a special case.
1658 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1659 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1660 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1661 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1662 changed to be "header.size" and "header.next".
1663 * buffer.h (struct buffer): Likewise.
1664 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1665 * frame.h (struct frame): Likewise.
1666 * process.h (struct Lisp_Process): Likewise.
1667 * termhooks.h (struct terminal): Likewise.
1668 * window.c (struct save_window_data, struct saved_window): Likewise.
1669 * window.h (struct window): Likewise.
1670 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1671 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1672 * buffer.c (init_buffer_once): Likewise.
1673 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1674 special case.
1675 * process.c (Fformat_network_address): Use local var for size,
1676 for brevity.
1677
0df1eac5
PE
1678 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1679
847ab9d1 1680 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1681 * data.c (atof): Remove decl; no longer used or needed.
1682 (digit_to_number): Move to lread.c.
1683 (Fstring_to_number): Use new string_to_number function, to be
1684 consistent with how the Lisp reader treats infinities and NaNs.
1685 Do not assume that floating-point numbers represent EMACS_INT
1686 without losing information; this is not true on most 64-bit hosts.
1687 Avoid double-rounding errors, by insisting on integers when
1688 parsing non-base-10 numbers, as the documentation specifies.
1689 * lisp.h (string_to_number): New decl, replacing ...
1690 (isfloat_string): Remove.
bc0a5c13 1691 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1692 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1693 appears to have been a coding error. Similarly, do not accept
1694 strings like +-1e0 as floating point numbers. Do not report
1695 overflow for integer overflows unless the base is not 10 which
1696 means we have no simple and reliable way to continue.
1697 Break out the floating-point parsing into a new
1698 function string_to_number, so that Fstring_to_number parses
1699 floating point numbers consistently with the Lisp reader.
04f2d78b 1700 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1701 (E_CHAR, EXP_INT): Remove, replacing with ...
1702 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1703 (string_to_number): New function, replacing isfloat_string.
1704 This function checks for valid syntax and produces the resulting
1705 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1706 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1707 so that overflow for non-base-10 numbers is reported only when
1708 there's no portable and simple way to convert to floating point.
452f4150 1709
67769ffc
PE
1710 * textprop.c (set_text_properties_1): Rewrite for clarity,
1711 and to avoid GCC warning about integer overflow.
1712
c20db43f
PE
1713 * intervals.h (struct interval): Use EMACS_INT for members
1714 where EMACS_UINT might cause problems. See
1715 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1716 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1717 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1718 All uses changed.
37aa2f85
PE
1719 (offset_intervals): Tell GCC not to worry about length overflow
1720 when negating a negative length.
c20db43f 1721
2538aa2f
PE
1722 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1723 (overrun_check_free): Likewise.
1724
f2d3008d
PE
1725 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1726 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1727 word size.
1728
ec8df744
PE
1729 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1730 (gnutls_make_error): Rename local to avoid shadowing.
1731 (gnutls_emacs_global_deinit): ifdef out; not used.
1732 (Fgnutls_boot): Use const for pointer to readonly storage.
1733 Comment out unused local. Fix pointer signedness problems.
1734
640ee02d
PE
1735 * lread.c (openp): Don't stuff size_t into an 'int'.
1736 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1737 about possible signed overflow.
1738
6048fb2a
PE
1739 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1740 (GDK_KEY_g): Don't define if already defined.
1741 (xg_prepare_tooltip): Avoid pointer signedness problem.
1742 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1743
fa3c87e1
PE
1744 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1745 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1746
2172544b
PE
1747 * xfns.c (Fx_window_property): Simplify a bit,
1748 to make a bit faster and to avoid GCC 4.6.0 warning.
1749 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1750
9b821a21
PE
1751 * fns.c (internal_equal): Don't assume size_t fits in int.
1752
3c616cfa
PE
1753 * alloc.c (compact_small_strings): Tighten assertion a little.
1754
c2982e87
PE
1755 Replace pEd with more-general pI, and fix some printf arg casts.
1756 * lisp.h (pI): New macro, generalizing old pEd macro to other
1757 conversion specifiers. For example, use "...%"pI"d..." rather
1758 than "...%"pEd"...".
1759 (pEd): Remove. All uses replaced with similar uses of pI.
1760 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1761 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1762 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1763 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1764 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1765 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1766 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1767 64-bit hosts.
1768 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1769 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1770 * print.c (safe_debug_print, print_object): Likewise.
1771 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1772 to int.
6f04d126
PE
1773 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1774 avoiding the 0 flag, which is not portable.
c2982e87
PE
1775 * process.c (Fmake_network_process): Use pI to avoid cast.
1776 * region-cache.c (pp_cache): Likewise.
1777 * xdisp.c (decode_mode_spec): Likewise.
1778 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1779 behavior on 64-bit hosts with printf arg.
6f04d126 1780 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1781 (x_stop_queuing_selection_requests): Likewise.
1782 (x_get_window_property): Don't truncate byte count to an 'int'
1783 when tracing.
0b432f21 1784
5e073ec7
PE
1785 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1786 here, since it parses constructs like leading '-' and spaces,
1787 which are not wanted; and it overflows with large numbers.
1788 Instead, simply match F[0-9]+, which is what is wanted anyway.
1789
36372bf9
PE
1790 * alloc.c: Remove unportable assumptions about struct layout.
1791 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1792 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1793 (allocate_vectorlike, make_pure_vector): Use the new macros,
1794 plus offsetof, to remove unportable assumptions about struct layout.
1795 These assumptions hold on all porting targets that I know of, but
1796 they are not guaranteed, they're easy to remove, and removing them
1797 makes further changes easier.
1798
0b432f21
PE
1799 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1800 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1801 (string_overrun_cookie): Now const. Use initializers that
1802 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1803 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1804 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1805 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1806 multiple of sizeof (EMACS_INT); it need not be, if
1807 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1808 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1809
895009e1
JB
18102011-04-26 Juanma Barranquero <lekktu@gmail.com>
1811
1812 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1813
6a7a1b0b
TZ
18142011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1815
1816 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1817 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1818 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1819
841a1577 18202011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1821
1822 * lisp.h (Qdebug): List symbol.
895009e1 1823 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1824 * keyboard.c (debug-on-event): New variable.
1825 (handle_user_signal): Break into debugger when debug-on-event
1826 matches the current signal symbol.
1827
f2d3ba6f
DN
18282011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1829
1830 * alloc.c (check_sblock, check_string_bytes)
1831 (check_string_free_list): Convert to standard C.
1832
42ce4c63
TZ
18332011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1834
1835 * w32.c (emacs_gnutls_push): Fix typo.
1836
825cd63c
EZ
18372011-04-25 Eli Zaretskii <eliz@gnu.org>
1838
fb11d64d
EZ
1839 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1840 "cast to pointer from integer of different size".
1841
825cd63c
EZ
1842 Improve doprnt and its use in verror. (Bug#8545)
1843 * doprnt.c (doprnt): Document the set of format control sequences
1844 supported by the function. Use SAFE_ALLOCA instead of always
1845 using `alloca'.
1846
1847 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1848 is one byte too soon. Don't use xrealloc; instead xfree and
1849 xmalloc anew.
1850
e061a11b
TZ
18512011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1852
1853 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1854 callbacks stage.
1855
1856 * gnutls.c: Renamed global_initialized to
1857 gnutls_global_initialized. Added internals for the
1858 :verify-hostname-error, :verify-error, and :verify-flags
1859 parameters of `gnutls-boot' and documented those parameters in the
1860 docstring. Start callback support.
1861 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1862 unless a fatal error occured. Call gnutls_alert_send_appropriate
1863 on error. Return error code.
1864 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1865 (emacs_gnutls_read): Likewise.
1866 (Fgnutls_boot): Return handshake error code.
1867 (emacs_gnutls_handle_error): New function.
1868 (wsaerror_to_errno): Likewise.
1869
1870 * w32.h (emacs_gnutls_pull): Add prototype.
1871 (emacs_gnutls_push): Likewise.
1872
1873 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1874 (emacs_gnutls_push): Likewise.
1875
18762011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1877
1878 * process.c (wait_reading_process_output): Check if GnuTLS
1879 buffered some data internally if no FDs are set for TLS
1880 connections.
1881
1882 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1883 (LIBS): Link to USER_LIBS.
1884 ($(BLD)/gnutls.$(0)): New target.
1885
fa6996bc
EZ
18862011-04-24 Eli Zaretskii <eliz@gnu.org>
1887
eb35682e
EZ
1888 * xdisp.c (handle_single_display_spec): Rename the
1889 display_replaced_before_p argument into display_replaced_p, to
1890 make it consistent with the commentary. Fix typos in the
1891 commentary.
1892
e2ad650c
EZ
1893 * textprop.c (syms_of_textprop): Remove dead code.
1894 (copy_text_properties): Delete obsolete commentary about an
1895 interface that was deleted long ago. Fix typos in the description
1896 of arguments.
1897
1b2de274
EZ
1898 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1899 to changes in oldXMenu/XMenu.h from 2011-04-16.
1900 <menu_help_message, prev_menu_help_message>: Constify.
1901 (IT_menu_make_room): menu->help_text is now `const char **';
1902 adjust.
1903
1904 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1905 to changes in oldXMenu/XMenu.h from 2011-04-16.
1906 (struct XMenu): Declare `help_text' `const char **'.
1907
1908 * xfaces.c <Qunspecified>: Make extern again.
1909
1910 * syntax.c: Include sys/types.h before including regex.h, as
1911 required by Posix.
1912
762b15be
EZ
1913 * doc.c (get_doc_string): Improve the format passed to `error'.
1914
1915 * doprnt.c (doprnt): Improve commentary.
1916
1917 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1918
1919 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1920 them with etags.
1921
f1052e5d
EZ
1922 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1923 changes in globals.h immediately force recompilation.
762b15be
EZ
1924 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1925 $(CURDIR)/s/ms-w32.h.
1926 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1927
fa6996bc
EZ
1928 * character.c (Fchar_direction): Function deleted.
1929 (syms_of_character): Don't defsubr it.
1930 <char-direction-table>: Deleted.
1931
e6c3da20
EZ
19322011-04-23 Eli Zaretskii <eliz@gnu.org>
1933
1934 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1935 * doprnt.c: Include limits.h.
1936 (SIZE_MAX): New macro.
04f2d78b
CB
1937 (doprnt): Return a size_t value. 2nd arg is now size_t.
1938 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1939 Improve overflow protection. Support `l' modifier for integer
1940 conversions. Support %l conversion. Don't assume an EMACS_INT
1941 argument for integer conversions and for %c.
1942
1943 * lisp.h (doprnt): Restore prototype.
1944
1945 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1946 $(SRC)/character.h.
1947
1948 * Makefile.in (base_obj): Add back doprnt.o.
1949
1950 * deps.mk (doprnt.o): Add back prerequisites.
1951 (callint.o): Depend on character.h.
1952
1953 * eval.c (internal_lisp_condition_case): Include the handler
1954 representation in the error message.
1955 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1956 when breaking from the loop.
1957
1958 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1959
1960 * callint.c (Fcall_interactively): When displaying error message
1961 about invalid control letter, pass the character's codepoint, not
1962 a pointer to its multibyte form. Improve display of the character
1963 in octal and display also its hex code.
1964
1965 * character.c (char_string): Use %x to display the (unsigned)
1966 codepoint of an invalid character, to avoid displaying a bogus
1967 negative value.
1968
1969 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1970 `error', not SYMBOL_NAME itself.
1971
1972 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1973 character arguments to `error'.
1974
1975 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1976 to `error' in error message about FINAL_CHAR argument. Make sure
1977 FINAL_CHAR is a character, and use %c when it is passed as
1978 argument to `error'.
1979
4ffd0d6b 19802011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1981
1982 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1983
1984 * w32.c: Include <time.h>.
1985 (sys_localtime): New function.
1986
4ffd0d6b 19872011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1988
1989 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1990
4ffd0d6b 1991 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1992
4ffd0d6b 19932011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1994
4ffd0d6b
GM
1995 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1996 zombies (Bug#8467).
aac0c6e3 1997
04c56954
EZ
19982011-04-19 Eli Zaretskii <eliz@gnu.org>
1999
2000 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2001 gl_state.e_property when gl_state.object is Qt.
2002
2003 * insdel.c (make_gap_larger): Remove limitation of buffer size
2004 to <= INT_MAX.
2005
16a43933
CY
20062011-04-18 Chong Yidong <cyd@stupidchicken.com>
2007
2008 * xdisp.c (lookup_glyphless_char_display)
2009 (produce_glyphless_glyph): Handle cons cell entry in
2010 glyphless-char-display.
2011 (Vglyphless_char_display): Document it.
2012
2013 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2014 glyphless-char-display.
2015
4581706e
CY
20162011-04-17 Chong Yidong <cyd@stupidchicken.com>
2017
2018 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2019
2020 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2021
2022 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2023 definition for no-X builds.
2024
4887c6e2 20252011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2026
fd35b6f9
PE
2027 Static checks with GCC 4.6.0 and non-default toolkits.
2028
5c1ccb01
PE
2029 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2030
006c5daa
PE
2031 * process.c (keyboard_bit_set): Define only if SIGIO.
2032 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2033 (send_process): Repair possible setjmp clobbering.
2034
efc736d3
PE
2035 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2036
4e2fe2e6
PE
2037 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2038
f97334a2
PE
2039 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2040
4e75f29d
PE
2041 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2042 Define only if needed.
2043
90efadd1
PE
2044 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2045 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2046 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2047
3c647824
PE
2048 * dispextern.h (struct redisplay_interface): Rename param
2049 to avoid shadowing.
e264f262 2050 * termhooks.h (struct terminal): Likewise.
761383f4 2051 * xterm.c (xembed_send_message): Likewise.
3c647824 2052
b58c5c4a
PE
2053 * insdel.c (make_gap_smaller): Define only if
2054 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2055
cad59032
PE
2056 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2057 it.
2058
c339dc2e
PE
2059 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2060 so that we aren't warned about unused symbols.
2061
91a3e27b
PE
2062 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2063
399c71d3 2064 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2065
8ffc96f5
PE
2066 * xfns.c (x_real_positions): Mark locals as initialized.
2067
eef9bc79
PE
2068 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2069
098db9dd
PE
2070 * xterm.c: Fix problems found by static analysis with other toolkits.
2071 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2072 (x_dispatch_event): Declare static if USE_GTK, and
2073 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2074 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2075 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2076 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2077 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2078
eb18f6cc
PE
2079 * xmenu.c (menu_help_callback): Pointer type fixes.
2080 Use const pointers when pointing at readonly data. Avoid pointer
2081 signedness clashes.
2082 (FALSE): Remove unused macro.
2083 (update_frame_menubar): Remove unused decl.
2084
1fe72bf8
PE
2085 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2086
60d9e1db
PE
2087 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2088 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2089 (single_menu_item): Rename local to avoid shadowing.
2090
39261c26
PE
2091 * keyboard.c (make_lispy_event): Remove unused local var.
2092
018c5e19
PE
2093 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2094 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2095
63d2b86e
PE
2096 * bitmaps: Change bitmaps from unsigned char back to the X11
2097 compatible char. Avoid the old compiler warnings about
2098 out-of-range initializers by using, for example, '\xab' rather
2099 than 0xab.
2100
aefd87e1
PE
2101 * xgselect.c (xgselect_initialize): Check vs interface
2102 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2103
bf501fb9
PE
2104 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2105
e9829fdf
PE
2106 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2107 to read-only memory.
2108
1086c095
PE
2109 * fns.c (vector): Remove; this old hack is no longer needed.
2110
2baccd04 2111 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2112 Remove unused var.
dde42981 2113 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2114
72391843 2115 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2116
436c16df 2117 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2118 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2119 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2120
92bb796d 2121 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2122 (x_term_init): Remove local to avoid shadowing.
92bb796d 2123
764430a3 2124 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2125
2126 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2127 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2128
d1dfb56c
EZ
21292011-04-16 Eli Zaretskii <eliz@gnu.org>
2130
c4354cb4
EZ
2131 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2132
d1dfb56c
EZ
2133 Fix regex.c, syntax.c and friends for buffers > 2GB.
2134 * syntax.h (struct gl_state_s): Declare character position members
2135 EMACS_INT.
2136
2137 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2138
04f2d78b
CB
2139 * textprop.c (verify_interval_modification, interval_of):
2140 Declare arguments EMACS_INT.
d1dfb56c
EZ
2141
2142 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2143 EMACS_INT.
2144
2145 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2146
2147 * indent.c (Fvertical_motion): Local variable it_start is now
2148 EMACS_INT.
2149
2150 * regex.c (re_match, re_match_2, re_match_2_internal)
2151 (bcmp_translate, regcomp, regexec, print_double_string)
2152 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2153 (re_compile_pattern, re_exec): Declare arguments and local
2154 variables `size_t' and `ssize_t' and return values `regoff_t', as
2155 appropriate.
2156 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2157 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2158 <compile_stack_type>: `size' and `avail' are now `size_t'.
2159
2160 * regex.h <regoff_t>: Use ssize_t, not int.
2161 (re_search, re_search_2, re_match, re_match_2): Arguments that
2162 specify buffer/string position and length are now ssize_t and
2163 size_t. Return type is regoff_t.
2164
613052cd
BK
21652011-04-16 Ben Key <bkey76@gmail.com>
2166
2167 * nsfont.m: Fixed bugs in ns_get_family and
2168 ns_descriptor_to_entity that were caused by using free to
2169 deallocate memory blocks that were allocated by xmalloc (via
2170 xstrdup). This caused Emacs to crash when compiled with
2171 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2172 --enable-checking=xmallocoverrun). xfree is now used to
2173 deallocate these memory blocks.
2174
4170f62f 21752011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2176
71b41406
PE
2177 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2178
9587a89d
PE
2179 emacs_write: Accept and return EMACS_INT for sizes.
2180 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2181 et seq.
2182 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2183 Accept and return EMACS_INT.
2184 (emacs_gnutls_write): Return the number of bytes written on
2185 partial writes.
2186 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2187 (emacs_read, emacs_write): Remove check for negative size, as the
2188 Emacs source code has been audited now.
9587a89d
PE
2189 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2190 (emacs_read, emacs_write): Use it.
273a5f82
PE
2191 * process.c (send_process): Adjust to the new signatures of
2192 emacs_write and emacs_gnutls_write. Do not attempt to store
2193 a byte offset into an 'int'; it might overflow.
9587a89d 2194 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2195
3e047f51
PE
2196 * sound.c: Don't assume sizes fit in 'int'.
2197 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2198 Return EMACS_INT, not int.
3e047f51 2199 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2200 Accept EMACS_INT, not int.
2201 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2202 record read return values.
2203
cc39a9db
BK
22042011-04-15 Ben Key <bkey76@gmail.com>
2205
c9d0ec6d
JB
2206 * keyboard.c (Qundefined): Don't declare static since it is used
2207 in nsfns.m.
2208 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2209 static since they are used in nsfont.m.
cc39a9db 2210
6c60eb9f
SM
22112011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2212
2213 * process.c (Qprocessp): Don't declare static.
2214 * lisp.h (Qprocessp): Declare again.
2215
7990b61a
JB
22162011-04-15 Juanma Barranquero <lekktu@gmail.com>
2217
2218 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2219
5d4cb038
PE
22202011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2221
8bd7b830 2222 Improve C-level modularity by making more things 'static'.
cd64ea1d 2223
e3b27b31
PE
2224 Don't publish debugger-only interfaces to other modules.
2225 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2226 (verify_bytepos, count_markers): Move decls to the only modules
2227 that need them.
2228 * region-cache.h (pp_cache): Likewise.
2229 * window.h (check_all_windows): Likewise.
2230 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2231
5d4cb038
PE
2232 * sysdep.c (croak): Now static, if
2233 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2234 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2235
2236 * alloc.c (refill_memory_reserve): Now static if
2237 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2238 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2239
e87b6180
PE
2240 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2241 Define only if USE_LUCID.
2242
ac64929e
PE
2243 * xrdb.c (x_customization_string, x_rm_string): Now static.
2244
6f37259d
PE
2245 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2246 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2247
1683e3ab
PE
2248 * xdisp.c (draw_row_with_mouse_face): Now static.
2249 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2250
de9c2632
PE
2251 * window.h (check_all_windows): Mark externally visible.
2252
2b96acb7
PE
2253 * window.c (window_deletion_count): Now static.
2254
2255 * undo.c: Make symbols static if they're not exported.
2256 (last_undo_buffer, last_boundary_position, pending_boundary):
2257 Now static.
2258
50436f33
PE
2259 * textprop.c (interval_insert_behind_hooks): Now static.
2260 (interval_insert_in_front_hooks): Likewise.
2261
64520e5c
PE
2262 * term.c: Make symbols static if they're not exported.
2263 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2264 (max_frame_lines, tty_set_terminal_modes):
2265 (tty_reset_terminal_modes, tty_turn_off_highlight):
2266 (get_tty_terminal): Now static.
2267 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2268 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2269 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2270 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2271 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2272
1fa53021
PE
2273 * sysdep.c: Make symbols static if they're not exported.
2274 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2275 Now static.
2276 (sigprocmask_set, full_mask): Remove; unused.
2277 (wait_debugging): Mark as visible.
2278 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2279 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2280
d4b43b22
PE
2281 * syntax.c (syntax_temp): Define only if !__GNUC__.
2282
b7c513d0
PE
2283 * sound.c (current_sound_device, current_sound): Now static.
2284
989b29ad
PE
2285 * search.c (searchbufs, searchbuf_head): Now static.
2286
13a55a78
PE
2287 * scroll.c (scroll_cost): Remove; unused.
2288 * dispextern.h (scroll_cost): Remove decl.
2289
de68a1fc
PE
2290 * region-cache.h (pp_cache): Mark as externally visible.
2291
40ccffa6
PE
2292 * process.c: Make symbols static if they're not exported.
2293 (process_tick, update_tick, create_process, chan_process):
2294 (Vprocess_alist, proc_buffered_char, datagram_access):
2295 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2296 (deactivate_process): Mark defn as static, as well as decl.
2297 * lisp.h (create_process): Remove decl.
2298 * process.h (chan_process, Vprocess_alist): Remove decls.
2299
ad64fc97
PE
2300 * print.c: Make symbols static if they're not exported.
2301 (print_depth, new_backquote_output, being_printed, print_buffer):
2302 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2303 (print_interval, print_number_index, initial_stderr_stream):
2304 Now static.
2305 * lisp.h (Fprinc): Remove decl.
2306 (debug_output_compilation_hack): Mark as externally visible.
2307
adddb265
PE
2308 * sysdep.c (croak): Move decl from here to syssignal.h.
2309 * syssignal.h (croak): Put it here, so the API can be checked when
2310 'croak' is called from dissociate_if_controlling_tty.
2311
1717ede2
PE
2312 * minibuf.c: Make symbols static if they're not exported.
2313 (minibuf_save_list, choose_minibuf_frame): Now static.
2314 * lisp.h (choose_minibuf_frame): Remove decl.
2315
fa5fb2bc
PE
2316 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2317
1e3890d1
PE
2318 * lread.c: Make symbols static if they're not exported.
2319 (read_objects, initial_obarray, oblookup_last_bucket_number):
2320 Now static.
2321 (make_symbol): Remove; unused.
2322 * lisp.h (initial_obarray, make_symbol): Remove decls.
2323
8a1414fa
PE
2324 * keyboard.c: Make symbols static if they're not exported.
2325 (single_kboard, recent_keys_index, total_keys, recent_keys):
2326 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2327 (this_single_command_key_start, echoing, last_auto_save):
2328 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2329 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2330 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2331 (Vlispy_mouse_stem, double_click_count):
2332 Now static.
2333 (force_auto_save_soon): Define only if SIGDANGER.
2334 (ignore_mouse_drag_p): Now static if
2335 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2336 (print_help): Remove; unused.
2337 (stop_character, last_timer_event): Mark as externally visible.
2338 * keyboard.h (ignore_mouse_drag_p): Declare only if
2339 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2340 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2341 * lisp.h (echoing): Remove decl.
2342 (force_auto_save_soon): Declare only if SIGDANGER.
2343 * xdisp.c (redisplay_window): Simplify code, to make it more
2344 obvious that ignore_mouse_drag_p is not accessed if !defined
2345 USE_GTK && !defined HAVE_NS.
2346
93ea6e8f
PE
2347 * intervals.c: Make symbols static if they're not exported.
2348 (merge_properties_sticky, merge_interval_right, delete_interval):
2349 Now static.
2350 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2351
77382fcc
PE
2352 * insdel.c: Make symbols static if they're not exported.
2353 However, leave prepare_to_modify_buffer alone. It's never
2354 called from outside this function, but that appears to be a bug.
2355 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2356 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2357 (adjust_after_replace_noundo): Remove; unused.
2358 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2359 (signal_before_change): Remove decls.
77382fcc 2360
9306c32e
PE
2361 * indent.c (val_compute_motion, val_vmotion): Now static.
2362
cd44d2eb
PE
2363 * image.c: Make symbols static if they're not exported.
2364 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2365 if USE_GTK.
2366 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2367 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2368
ad9a7a06
PE
2369 * fringe.c (standard_bitmaps): Now static.
2370 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2371
81626931
PE
2372 * frame.c: Make symbols static if they're not exported.
2373 (x_report_frame_params, make_terminal_frame): Now static.
2374 (get_frame_param): Now static, unless HAVE_NS.
2375 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2376 (x_get_resource_string): Remove; not used.
2377 * frame.h (make_terminal_frame, x_report_frame_params):
2378 (x_get_resource_string); Remove decls.
2379 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2380 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2381
239f9db9
PE
2382 * font.c, fontset.c: Make symbols static if they're not exported.
2383 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2384 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2385 * font.c (font_close_object): Now static.
2386 * font.h (font_close_object): Remove.
2387 * fontset.c (FONTSET_OBJLIST): Remove.
2388 (free_realized_fontset) #if-0 the body, which does nothing.
2389 (face_suitable_for_char_p): #if-0, as it's never called.
2390 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2391 * xfaces.c (face_at_string_position):
2392 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2393 since 0 is always ASCII.
2394
dfcf3579
PE
2395 * fns.c (weak_hash_tables): Now static.
2396
5045092b
PE
2397 * fileio.c: Make symbols static if they're not exported.
2398 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2399 (Vwrite_region_annotation_buffers): Now static.
2400
57a96f5c
PE
2401 * eval.c: Make symbols static if they're not exported.
2402 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2403 * lisp.h (backtrace_list): Remove decl.
2404
35f08c38
PE
2405 * emacs.c: Make symbols static if they're not exported.
2406 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2407 (fatal_error_code, fatal_error_signal_hook, standard_args):
2408 Now static.
2409 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2410 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2411 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2412 * lisp.h (fatal_error_signal_hook): Remove decl.
2413 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2414
f44bd759
PE
2415 * editfns.c: Move a (normally-unused) function to its only use.
2416 * editfns.c, lisp.h (get_operating_system_release): Remove.
2417 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2418 worth the hassle of breaking this out.
2419
b532497d
PE
2420 * xterm.c: Make symbols static if they're not exported.
2421 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2422 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2423 (x_destroy_window, x_delete_display):
2424 Now static.
2425 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2426 (x_mouse_leave): Remove; unused.
2427 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2428 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2429 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2430 Remove decls.
2431 (x_mouse_leave): Declare only if WINDOWSNT.
2432 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2433 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2434 USE_X_TOOLKIT.
2435
1675728f
PE
2436 * ftxfont.c: Make symbols static if they're not exported.
2437 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2438 HAVE_FREETYPE.
2439 * font.h (ftxfont_driver): Likewise.
2440
e4cebfca
PE
2441 * xfns.c: Make symbols static if they're not exported.
2442 (x_last_font_name, x_display_info_for_name):
2443 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2444 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2445 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2446 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2447 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2448 (last_show_tip_args): Now static.
2449 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2450 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2451 (x_screen_planes): Remove; unused.
2452 * dispextern.h (x_screen_planes): Remove decl.
2453
5bf46f05
PE
2454 * dispnew.c: Make symbols static if they're not exported.
2455 * dispextern.h (redraw_garbaged_frames, scrolling):
2456 (increment_row_positions): Remove.
2457 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2458 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2459 Now static.
2460 (redraw_garbaged_frames): Remove; unused.
2461
435f4c28
PE
2462 * xfaces.c: Make symbols static if they're not exported.
2463 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2464 Remove decls.
2465 * xterm.h (defined_color): Remove decls.
2466 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2467 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2468 (menu_face_changed_default, defined_color, free_realized_face):
2469 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2470 (ascii_face_of_lisp_face): Remove; unused.
2471
8524aef3
PE
2472 * xdisp.c: Make symbols static if they're not exported.
2473 * dispextern.h (scratch_glyph_row, window_box_edges):
2474 (glyph_to_pixel_coords, set_cursor_from_row):
2475 (get_next_display_element, set_iterator_to_next):
2476 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2477 (show_mouse_face): Remove decls
2478 * frame.h (message_buf_print): Likewise.
2479 * lisp.h (pop_message, set_message, check_point_in_composition):
2480 Likewise.
2481 * xterm.h (set_vertical_scroll_bar): Likewise.
2482 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2483 (message_buf_print, scratch_glyph_row, displayed_buffer):
2484 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2485 (get_next_display_element, show_mouse_face, window_box_edges):
2486 (frame_to_window_pixel_xy, check_point_in_composition):
2487 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2488 (glyph_to_pixel_coords): Remove; unused.
2489
16390cd2
PE
2490 * dired.c (file_name_completion): Now static.
2491
2492 * dbusbind.c (xd_in_read_queued_messages): Now static.
2493
a25f4dfa
PE
2494 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2495 * data.c (circular_list_error): Remove.
2496
14a9c8df
PE
2497 * commands.h (last_point_position, last_point_position_buffer):
2498 (last_point_position_window): Remove decls.
2499 * keyboard.c: Make these variables static.
2500
04f2d78b
CB
2501 * coding.h (coding, code_convert_region, encode_coding_gap):
2502 Remove decls.
74ab6df5
PE
2503 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2504 (iso_code_class, detect_coding, code_convert_region): Now static.
2505 (encode_coding_gap): Remove; unused.
2506
38dfbee1
PE
2507 * chartab.c (chartab_chars, chartab_bits): Now static.
2508
a2cb4e63
PE
2509 * charset.h (charset_iso_8859_1): Remove decl.
2510 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2511 Now static.
2512
127198fd
PE
2513 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2514 * ccl.c (Vccl_program_table): Now static.
2515 (check_ccl_update): Remove; unused.
2516
d85b608f
PE
2517 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2518 * category.h: ... from here.
2519 * category.c (check_category_table, set_category_set): Now static.
2520
31cd66f3
PE
2521 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2522 * lisp.h: Remove these decls.
2523
c358e587
PE
2524 * buffer.c (buffer_count): Remove unused var.
2525
e78aecca
PE
2526 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2527 so that it's not optimized away.
2528 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2529 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2530 exported only to the debugger.
2531
e192d7d3 2532 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2533 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2534
92470028
PE
2535 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2536 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2537 was inaccessible from Lisp.
2538 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2539 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2540
244ed907
PE
2541 alloc.c: Import and export fewer symbols, and remove unused items.
2542 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2543 is defined.
2544 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2545 it's not optimized away by whole-program optimization.
2546 (message_enable_multibyte, free_misc): Remove.
2547 (catchlist, handlerlist, mark_backtrace):
2548 Declare only if BYTE_MARK_STACK.
2549 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2550 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2551 (message_enable_multibyte): Remove decl.
2552 (free_misc, interval_free_list, float_block, float_block_index):
2553 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2554 (cons_free_list, last_marked_index):
2555 Now static.
2556 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2557 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2558 (mark_backtrace): Define only if BYTE_MARK_STACK.
2559 * xdisp.c (message_enable_multibyte): Now static.
2560
61c2b50e 2561 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2562 This makes it easier for human readers (and static analyzers)
2563 to see whether these variables are used from other modules.
2564 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2565 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2566 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2567 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2568 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2569 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2570 * xmenu.c, xselect.c:
2571 Declare Q* vars static if they are not used in other modules.
2572 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2573 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2574 Remove decls of unexported vars.
2575 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2576
95c82688
PE
2577 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2578
16a97296
PE
2579 Make Emacs functions such as Fatom 'static' by default.
2580 This makes it easier for human readers (and static analyzers)
2581 to see whether these functions can be called from other modules.
2582 DEFUN now defines a static function. To make the function external
2583 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2584 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2585 (Finit_image_library):
16a97296
PE
2586 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2587 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2588 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2589 Remove decls, since these functions are now static.
2590 (Funintern, Fget_internal_run_time): New decls, since these functions
2591 were already external.
95c82688 2592
16a97296
PE
2593 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2594 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2595 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2596 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2597 * keyboard.c, keymap.c, lread.c:
2598 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2599 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2600 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2601 Mark functions with DEFUE instead of DEFUN,
2602 if they are used in other modules.
2603 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2604 decls for now-static functions.
2605 * buffer.h (Fdelete_overlay): Remove decl.
2606 * callproc.c (Fgetenv_internal): Mark as internal.
2607 * composite.c (Fremove_list_of_text_properties): Remove decl.
2608 (Fcomposition_get_gstring): New forward static decl.
2609 * composite.h (Fcomposite_get_gstring): Remove decl.
2610 * dired.c (Ffile_attributes): New forward static decl.
2611 * doc.c (Fdocumntation_property): New forward static decl.
2612 * eval.c (Ffetch_bytecode): New forward static decl.
2613 (Funintern): Remove extern decl; now in .h file where it belongs.
2614 * fileio.c (Fmake_symbolic_link): New forward static decl.
2615 * image.c (Finit_image_library): New forward static decl.
2616 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2617 * intervals.h (Fprevious_property_change):
2618 (Fremove_list_of_text_properties): Remove decls.
2619 * keyboard.c (Fthis_command_keys): Remove decl.
2620 (Fcommand_execute): New forward static decl.
2621 * keymap.c (Flookup_key): New forward static decl.
2622 (Fcopy_keymap): Now static.
2623 * keymap.h (Flookup_key): Remove decl.
2624 * process.c (Fget_process): New forward static decl.
2625 (Fprocess_datagram_address): Mark as internal.
2626 * syntax.c (Fsyntax_table_p): New forward static decl.
2627 (skip_chars): Remove duplicate decl.
2628 * textprop.c (Fprevious_property_change): New forward static decl.
2629 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2630 Now internal.
2631 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2632 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2633
785bbd42
PE
2634 * editfns.c (Fformat): Remove unreachable code.
2635
8b913b57
AS
26362011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2637
2638 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2639 change. (Bug#8496)
2640
a6744a35
EZ
26412011-04-13 Eli Zaretskii <eliz@gnu.org>
2642
2643 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2644 when at ZV. (Bug#8487)
2645
e7974947
AS
26462011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2647
baad03f0
AS
2648 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2649 (Bug#8437)
2650 * keyboard.c (parse_tool_bar_item): Likewise.
2651 * sound.c (sound_cleanup, alsa_close): Likewise.
2652 * termcap.c (tgetent): Likewise.
2653 * xfns.c (x_default_font_parameter): Likewise.
2654 * xsettings.c (read_and_apply_settings): Likewise.
2655
e7974947
AS
2656 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2657 (overrun_check_free): Protoize.
2658
28272684
PE
26592011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2660
2661 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2662 since callers should never pass a negative size.
2663 Change the signature to match that of plain 'read' and 'write'; see
2664 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2665 * lisp.h: Update prototypes of emacs_write and emacs_read.
2666
11997c76
EZ
26672011-04-11 Eli Zaretskii <eliz@gnu.org>
2668
2669 * xdisp.c (redisplay_window): Don't try to determine the character
2670 position of the scroll margin if the window start point w->startp
e896f03c 2671 is outside the buffer's accessible region. (Bug#8468)
11997c76 2672
8a2cbd72
EZ
26732011-04-10 Eli Zaretskii <eliz@gnu.org>
2674
2675 Fix write-region and its subroutines for buffers > 2GB.
2676 * fileio.c (a_write, e_write): Modify declaration of arguments and
2677 local variables to support buffers larger than 2GB.
2678 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2679
2680 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2681 argument, local variables, and return value.
2682
2683 * lisp.h: Update prototypes of emacs_write and emacs_read.
2684
2685 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2686
4073e537 26872011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2688
1ebfdcb6
PE
2689 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2690
b2ded58d
PE
2691 Fix more problems found by GCC 4.6.0's static checks.
2692
7d66342c
PE
2693 * xdisp.c (vmessage): Use a better test for character truncation.
2694
bbf47d44
PE
2695 * charset.c (load_charset_map): <, not <=, for optimization,
2696 and to avoid potential problems with integer overflow.
9248994d 2697 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2698 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2699 * editfns.c (Fformat): Likewise.
1e69125e 2700 * syntax.c (skip_chars): Likewise.
3befa583 2701
e3019616
PE
2702 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2703 This also lets GCC 4.6.0 generate slightly better loop code.
2704
becfa255
PE
2705 * callint.c (Fcall_interactively): <, not <=, for optimization.
2706 (Fcall_interactively): Count the number of arguments produced,
2707 not the number of arguments given. This is simpler and lets GCC
2708 4.6.0 generate slightly better code.
2709
dae0cd48
PE
2710 * ftfont.c: Distingish more carefully between FcChar8 and char.
2711 The previous code passed unsigned char * to a functions like
2712 strlen and xstrcasecmp that expect char *, which does not
2713 conform to the C standard.
2714 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2715 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2716 char * when the C standard requires it.
2717
76032d70
PE
2718 * keyboard.c (read_char): Remove unused var.
2719
eb3f1cc8
PE
2720 * eval.c: Port to Windows vsnprintf (Bug#8435).
2721 Include <limits.h>.
2722 (SIZE_MAX): Define if the headers do not.
2723 (verror): Do not give up if vsnprintf returns a negative count.
2724 Instead, grow the buffer. This ports to Windows vsnprintf, which
2725 does not conform to C99. Problem reported by Eli Zaretskii.
2726 Also, simplify the allocation scheme, by avoiding the need for
2727 calling realloc, and removing the ALLOCATED variable.
2728
70476b54
PE
2729 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2730
12020a9e
PE
2731 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2732 But keep the doprint source code for now, as we might revamp it
2733 and use it again (Bug#8435).
ea6c7ae6
PE
2734 * lisp.h (doprnt): Remove.
2735 * Makefile.in (base_obj): Remove doprnt.o.
2736 * deps.mk (doprnt.o): Remove.
2737
5fdb398c
PE
2738 error: Print 32- and 64-bit integers portably (Bug#8435).
2739 Without this change, on typical 64-bit hosts error ("...%d...", N)
2740 was used to print both 32- and 64-bit integers N, which relied on
2741 undefined behavior.
2742 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2743 New macro.
2744 * lisp.h (error, verror): Mark as printf-like functions.
2745 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2746 Report overflow in size calculations when allocating printf buffer.
2747 Do not truncate output string at its first null byte.
2748 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2749 Truncate the output at a character boundary, since vsnprintf does not
2750 do that.
2751 * charset.c (check_iso_charset_parameter): Convert internal
2752 character to string before calling 'error', since %c now has the
2753 printf meaning.
2754 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2755 overflow when computing char to be passed to 'error'. Do not
2756 pass Lisp_Object to 'error'; pass the integer instead.
2757 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2758 formatted with plain %d.
2759
b189fa66
PE
2760 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2761
bff87ef0
PE
2762 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2763
7e2cac20
PE
2764 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2765
ce4d90b5
PE
2766 * xterm.c (x_catch_errors): Remove duplicate declaration.
2767
266c9547
PE
2768 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2769
79c49ad2
PE
2770 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2771
368f4090
JM
27722011-04-10 Jim Meyering <meyering@redhat.com>
2773
2774 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2775 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2776 return ssize_t not "int", and use size_t as the buffer length.
2777 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2778 * gnutls.h: Update declarations.
2779 * process.c (read_process_output): Use ssize_t, to match.
2780 (send_process): Likewise.
2781
a32d4040
CY
27822011-04-09 Chong Yidong <cyd@stupidchicken.com>
2783
2784 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2785
8546720e 27862011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2787
04f2d78b
CB
2788 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2789 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2790
8546720e
GM
2791 * xterm.c (handle_one_xevent):
2792 * xmenu.c (create_and_show_popup_menu):
2793 * xselect.c (x_decline_selection_request)
2794 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2795
0a2f5c1a 27962011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2797
2798 Fix some uses of `int' instead of EMACS_INT.
2799 * search.c (string_match_1, fast_string_match)
2800 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2801 (scan_buffer, find_next_newline_no_quit)
2802 (find_before_next_newline, search_command, Freplace_match)
2803 (Fmatch_data): Make some `int' variables be EMACS_INT.
2804
2805 * xdisp.c (display_count_lines): 3rd argument and return value now
2806 EMACS_INT. All callers changed.
2807 (pint2hrstr): Last argument is now EMACS_INT.
2808
2809 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2810 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2811 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2812 (decode_coding_utf_16, decode_coding_emacs_mule)
2813 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2814 (decode_coding_ccl, decode_coding_charset)
2815 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2816 (decode_coding_iso_2022, decode_coding_emacs_mule)
2817 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2818 <char_offset, last_offset>: Declare EMACS_INT.
2819 (encode_coding_utf_8, encode_coding_utf_16)
2820 (encode_coding_emacs_mule, encode_invocation_designation)
2821 (encode_designation_at_bol, encode_coding_iso_2022)
2822 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2823 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2824 Declare EMACS_INT.
2825 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2826 (encode_invocation_designation): Last argument P_NCHARS is now
2827 EMACS_INT.
2828 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2829 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2830
2831 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2832 All users changed.
2833
2834 * ccl.c (Fccl_execute_on_string): Declare some variables
2835 EMACS_INT.
2836
8546720e 28372011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2838
2839 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2840
4e19a977
CS
28412011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2842
2843 * process.c (Fformat_network_address): Doc fix.
2844
87302331
R
28452011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2846
2847 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2848
cbb59342
CY
28492011-04-08 Chong Yidong <cyd@stupidchicken.com>
2850
2851 * keyboard.c (read_char): Call Lisp function help-form-show,
2852 instead of using internal_with_output_to_temp_buffer.
2853 (Qhelp_form_show): New var.
e0d38eeb 2854 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2855
2856 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2857
2858 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2859
e67a13ab
CY
28602011-04-06 Chong Yidong <cyd@stupidchicken.com>
2861
04f2d78b
CB
2862 * process.c (Flist_processes): Remove to Lisp.
2863 (list_processes_1): Delete.
e67a13ab 2864
973f782d
EZ
28652011-04-06 Eli Zaretskii <eliz@gnu.org>
2866
7c106b1e
EZ
2867 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2868
973f782d
EZ
2869 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2870
41cf7d1a 28712011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2872
ca23cc88
PE
2873 Fix more problems found by GCC 4.6.0's static checks.
2874
f390e2d5
PE
2875 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2876
42eea0d0
PE
2877 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2878
b69769da 2879 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2880
f9541e84
PE
2881 * xdisp.c (vmessage): Mark as a printf-like function.
2882
13841b55
PE
2883 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2884
c136c10f
PE
2885 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2886
5e2d4a30
PE
2887 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2888 printf-like functions.
2889 (tiff_load): Add casts to remove these marks before passing them
2890 to system-supplied API.
2891
583f48b9
PE
2892 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2893
b25d760e
PE
2894 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2895 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2896 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2897 directly, rather than having caller test rule sign. This avoids
2898 some unnecessary tests.
2899 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2900 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2901 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2902
bc7b6697 2903 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2904 (xfont_open): Avoid unnecessary tests.
bc7b6697 2905
27ccc379
PE
2906 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2907
dcd5c89a
PE
2908 * composite.h, composite.c (composition_gstring_put_cache):
2909 Use EMACS_INT, not int, for length.
2910
b13a45c6
PE
2911 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2912 breaking out part of COMPOSITION_DECODE_RULE.
2913 (COMPOSITION_DECODE_RULE): Use it.
2914 * composite.c (get_composition_id): Remove unused local vars,
2915 by using the new macro.
2916
1e792e4d
PE
2917 * textprop.c (set_text_properties_1): Change while to do-while,
2918 since the condition is always true at first.
2919
dc6c6455 2920 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2921 (interval_deletion_adjustment): Return unsigned value.
2922 All uses changed.
dc6c6455 2923
aba7731a
PE
2924 * process.c (list_processes_1, create_pty, read_process_output):
2925 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2926 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2927 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2928 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2929 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2930
fdfc4bf3
PE
2931 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2932
fca8fe46 2933 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2934 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2935
06a0259a 2936 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2937 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2938 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2939
e7b9e80f
PE
2940 * print.c (print_error_message): Avoid int overflow.
2941
56201685
PE
2942 * font.c (font_list_entities): Redo for clarity,
2943 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2944
78834453 2945 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2946 (font_score): Avoid potential overflow in diff calculation.
78834453 2947
0bc0b309 2948 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2949 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2950
e610eaca
PE
2951 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2952
b895abce
PE
2953 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2954 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2955 can always succeed if overflow has undefined behavior.
2956
1f1d9321 2957 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2958 (wordify): Omit three unnecessary tests.
1f1d9321 2959
c59478bc
PE
2960 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2961 All callers changed. This avoids the need for an unused var.
2962
79b73827
PE
2963 * casefiddle.c (casify_region): Remove var that is set but not used.
2964
a4db5dfe
PE
2965 * dired.c (file_name_completion): Remove var that is set but not used.
2966
43aae36e
PE
2967 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2968
2a47c44d 2969 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2970 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2971
a37c69bf
PE
2972 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2973 Check for integer overflow on size calculations.
2974
328ab8e7
PE
2975 * buffer.c (Fprevious_overlay_change): Remove var that is set
2976 but not used.
2977
e5a2a5cb
PE
2978 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2979 Remove vars that are set but not used.
8d84a6eb 2980 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2981 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2982
a60e5f68
PE
2983 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2984
f661cb61 2985 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2986 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2987
f0397f5a
PE
2988 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2989 that are set but not used.
2990
8664db06 2991 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2992 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2993
6abdaa4a
PE
2994 * xselect.c (x_get_local_selection, x_handle_property_notify):
2995 Remove vars that are set but not used.
2996
0ce7538d 2997 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2998 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2999
9ae848fc
PE
3000 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3001 Remove var that is set but not used.
0b918413
PE
3002 (scroll_bar_windows_size): Now size_t, not int.
3003 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3004 Check for overflow.
9ae848fc 3005
a5a62657
PE
3006 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3007 (map_tty_color) [!defined MSDOS]: Likewise.
3008
5c5cdd39
PE
3009 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3010
66ebf983
PE
3011 * coding.c: Remove vars that are set but not used.
3012 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3013 All callers changed.
3014 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3015 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3016 (decode_coding_charset): Remove vars that are set but not used.
3017
1be4d761
PE
3018 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3019 that is set but not used.
3020
47553fa8
PE
3021 * print.c (print_object): Remove var that is set but not used.
3022
1f7196bf 3023 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3024 The gnulib version avoids calling malloc in the usual case,
3025 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3026 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3027 * filelock.c (current_lock_owner): Likewise.
3028 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3029 * sysdep.c: Include allocator.h, careadlinkat.h.
3030 (emacs_no_realloc_allocator): New static constant.
3031 (emacs_readlink): New function.
fdb61804
PE
3032 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3033 ../lib/careadlinkat.h.
d1fdcab7 3034
f84c17c7
SM
30352011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3036
3037 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3038 first non-nil return value).
3039
ef3862ad
JD
30402011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3041
3042 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3043 if not defined (Bug#8403).
3044
376a7006
JB
30452011-04-02 Juanma Barranquero <lekktu@gmail.com>
3046
3047 * xdisp.c (display_count_lines): Remove parameter `start',
3048 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3049 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3050 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3051 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3052 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3053 and thereabouts. All callers changed.
3054 (get_per_char_metric): Remove parameter `f', unused since
3055 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3056
6ca3801d
JM
30572011-04-02 Jim Meyering <meyering@redhat.com>
3058
3059 do not dereference NULL upon failed strdup
3060 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3061 (ns_get_family): Likewise.
3062
d8e2b5ba
JB
30632011-04-02 Juanma Barranquero <lekktu@gmail.com>
3064
3065 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3066
8c74fcbd
JD
30672011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3068
3069 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3070 later (Bug#8403).
3071
7200d79c
SM
30722011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3073
03408648 3074 Add lexical binding.
7200d79c 3075
03408648
SM
3076 * window.c (Ftemp_output_buffer_show): New fun.
3077 (Fsave_window_excursion):
3078 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3079
3080 * lread.c (lisp_file_lexically_bound_p): New function.
3081 (Fload): Bind Qlexical_binding.
3082 (readevalloop): Remove `evalfun' arg.
3083 Bind Qinternal_interpreter_environment.
3084 (Feval_buffer): Bind Qlexical_binding.
3085 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3086 Mark as dynamic.
3087 (syms_of_lread): Declare `lexical-binding'.
3088
3089 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3090
3091 * keyboard.c (eval_dyn): New fun.
3092 (menu_item_eval_property): Use it.
ca105506
SM
3093
3094 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3095
03408648
SM
3096 * fns.c (concat, mapcar1): Accept byte-code-functions.
3097
3098 * eval.c (Fsetq): Handle lexical vars.
3099 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3100 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3101 (FletX, Flet): Obey lexical binding.
3102 (Fcommandp): Handle closures.
3103 (Feval): New `lexical' arg.
3104 (eval_sub): New function extracted from Feval. Use it almost
3105 everywhere where Feval was used. Look up vars in lexical env.
3106 Handle closures.
3107 (Ffunctionp): Move from subr.el.
3108 (Ffuncall): Handle closures.
3109 (apply_lambda): Remove `eval_flags'.
3110 (funcall_lambda): Handle closures and new byte-code-functions.
3111 (Fspecial_variable_p): New function.
3112 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3113 but without exporting it to Lisp.
23aba0ea 3114
23aba0ea 3115 * doc.c (Fdocumentation, store_function_docstring):
03408648 3116 * data.c (Finteractive_form): Handle closures.
23aba0ea 3117
03408648
SM
3118 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3119 interactive spec.
ba83908c 3120
04f2d78b
CB
3121 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3122 New byte-codes.
03408648
SM
3123 (exec_byte_code): New function extracted from Fbyte_code to handle new
3124 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3125
03408648 3126 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3127
03408648 3128 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3129
e2abce01
JB
31302011-03-31 Juanma Barranquero <lekktu@gmail.com>
3131
3132 * xdisp.c (redisplay_internal): Fix prototype.
3133
63696a73 31342011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3135
63696a73 3136 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3137 (try_scrolling): Use it when setting scroll_limit.
3138 Limit scrolling to 100 screen lines.
63696a73
EZ
3139 (redisplay_window): Even when falling back on "recentering",
3140 position point in the window according to scroll-conservatively,
3141 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3142
3143 (try_scrolling): When point is above the window, allow searching
3144 as far as scroll_max, or one screenful, to compute vertical
3145 distance from PT to the scroll margin position. This prevents
3146 try_scrolling from unnecessarily failing when
3147 scroll-conservatively is set to a value slightly larger than the
3148 window height. Clean up the case of PT below the margin at bottom
3149 of window: scroll_max can no longer be INT_MAX. When aggressive
3150 scrolling is in use, don't let point enter the opposite scroll
3151 margin as result of the scroll.
3152 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3153 threshold of 100 lines for never-recentering scrolling.
3154
e4cc2dfc
JB
31552011-03-31 Juanma Barranquero <lekktu@gmail.com>
3156
3157 * dispextern.h (move_it_by_lines):
3158 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3159 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3160 (message_log_check_duplicate): Remove parameters `prev_bol' and
3161 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3162 (redisplay_internal): Remove parameter `preserve_echo_area',
3163 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3164
3165 * indent.c (Fvertical_motion):
3166 * window.c (window_scroll_pixel_based, Frecenter):
3167 Don't pass `need_y_p' to `move_it_by_lines'.
3168
1c470562
SM
31692011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3170
44f230aa
SM
3171 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3172 steal a few bits to be more compact.
3173 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3174 Remove unneeded casts.
3175
1c470562
SM
3176 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3177
888adce9
ZK
31782011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3179
3180 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3181 binding" message (bug#7967).
3182
f838ed7b
PE
31832011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3184
77861b95
PE
3185 Fix more problems found by GCC 4.6.0's static checks.
3186
de6dbc14
PE
3187 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3188 Remove unused local var.
3189
f838ed7b
PE
3190 * editfns.c (Fmessage_box): Remove unused local var.
3191
792c7b2b
PE
3192 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3193 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3194 Omit unused local vars.
c499e557 3195 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3196 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3197 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3198 Omit unused local var.
3199
ba0165e1
PE
3200 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3201 Don't assume string length fits in int.
32ad8845 3202 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3203 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3204
3c59b4c9
PE
3205 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3206 instead of alloca (Bug#8344).
3207
a3eed478 3208 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3209 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3210
eb4d412d
PE
3211 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3212
1658b401
PE
3213 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3214 concerns.
3215
3216 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3217
3218 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3219
9a2c6e05
PE
3220 * keyboard.c (syms_of_keyboard): Use the same style as later
3221 in this function when indexing through an array. This also
3222 works around GCC bug 48267.
3223
03d0a109
PE
3224 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3225
44f730c8
PE
3226 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3227
fe75f926
PE
3228 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3229 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3230
ffa8c828
PE
3231 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3232 This avoids undefined behavior on integer overflow, and is a bit
3233 more convenient anyway since it is compared to a size_t variable.
3234
c5101a77
PE
3235 Variadic C functions now count arguments with size_t, not int.
3236 This avoids an unnecessary limitation on 64-bit machines, which
3237 caused (substring ...) to crash on large vectors (Bug#8344).
3238 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3239 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3240 All variadic functions and their callers changed accordingly.
c5101a77
PE
3241 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3242 * data.c (arith_driver, float_arith_driver): Likewise.
3243 * editfns.c (general_insert_function): Likewise.
3244 * eval.c (struct backtrace.nargs, interactive_p)
3245 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3246 (funcall_lambda, mark_backtrace): Likewise.
3247 * fns.c (concat): Likewise.
3248 * frame.c (x_set_frame_parameters): Likewise.
3249 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3250 0 if not found, not -1. All callers changed.
3251
dd3f25f7
PE
3252 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3253 (stack_copy_size): Now size_t, not int.
3254 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3255
461c2ab9
JB
32562011-03-28 Juanma Barranquero <lekktu@gmail.com>
3257
3258 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3259 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3260 All callers changed.
3261
3262 * lisp.h (multibyte_char_to_unibyte):
3263 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3264 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3265 * character.h (CHAR_TO_BYTE8):
3266 * cmds.c (internal_self_insert):
3267 * editfns.c (general_insert_function):
3268 * keymap.c (push_key_description):
3269 * search.c (Freplace_match):
3270 * xdisp.c (message_dolog, set_message_1): All callers changed.
3271
f6d62986
SM
32722011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3273
3274 * keyboard.c (safe_run_hook_funcall): New function.
3275 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3276 don't set the hook to nil, but remove the offending function instead.
3277 (Qcommand_hook_internal): Remove, unused.
3278 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3279 Vcommand_hook_internal.
3280
3281 * eval.c (enum run_hooks_condition): Remove.
3282 (funcall_nil, funcall_not): New functions.
3283 (run_hook_with_args): Call each function through a `funcall' argument.
3284 Remove `cond' argument, now redundant.
3285 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3286 (Frun_hook_with_args_until_failure): Adjust accordingly.
3287 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3288
1db5b1ad
JB
32892011-03-28 Juanma Barranquero <lekktu@gmail.com>
3290
3291 * dispextern.h (string_buffer_position): Remove declaration.
3292
3293 * print.c (strout): Remove parameter `multibyte', unused since
3294 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3295
3296 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3297 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3298 All callers changed.
3299
3300 * w32.c (_wsa_errlist): Use braces for struct initializers.
3301
3302 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3303 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3304 All callers changed.
3305 (string_buffer_position): Likewise. Also, make static (it's never
3306 used outside xdisp.c).
3307 (cursor_row_p): Remove parameter `w', unused since
3308 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3309 (decode_mode_spec): Remove parameter `precision', introduced during
3310 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3311 All callers changed.
3312
5ffb62aa
JD
33132011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3314
3315 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3316
461c2ab9 33172011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3318
3319 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3320 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3321 (ns_update_auto_hide_menu_bar): New functions.
3322 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3323 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3324 ns_constrain_all_frames.
3325 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3326 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3327
5c380ffb
JD
33282011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3329
3330 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3331
9af30bdf
GM
33322011-03-27 Glenn Morris <rgm@gnu.org>
3333
3334 * syssignal.h: Replace RETSIGTYPE with void.
3335 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3336 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3337 Replace SIGTYPE with void everywhere.
3338 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3339 * s/template.h (SIGTYPE): Remove commented out definition.
3340
e2abce01
JB
33412011-03-26 Eli Zaretskii <eliz@gnu.org>
3342
3343 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3344 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3345
f868cd8a
JB
33462011-03-26 Juanma Barranquero <lekktu@gmail.com>
3347
59eb0929
JB
3348 * w32.c (read_unc_volume): Use parameter `henum', instead of
3349 global variable `wget_enum_handle'.
3350
3351 * keymap.c (describe_vector): Remove parameters `indices' and
3352 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3353 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3354
f868cd8a
JB
3355 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3356
3357 * keyboard.c (timer_check): Remove parameter `do_it_now',
3358 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3359 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3360 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3361
3362 * keyboard.c (read_char):
3363 * w32menu.c (w32_menu_display_help):
3364 * xmenu.c (show_help_event, menu_help_callback):
3365 Adjust calls to `show_help_echo'.
3366
3367 * gtkutil.c (xg_maybe_add_timer):
3368 * keyboard.c (readable_events):
3369 * process.c (wait_reading_process_output):
3370 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3371
3372 * insdel.c (adjust_markers_gap_motion):
3373 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3374 (gap_left, gap_right): Don't call it.
3375
2ecf6fdb
CY
33762011-03-25 Chong Yidong <cyd@stupidchicken.com>
3377
3378 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3379 incurred during fontification.
3380
6b1f9ba4
JB
33812011-03-25 Juanma Barranquero <lekktu@gmail.com>
3382
3383 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3384 (DEFVAR_PER_BUFFER): Don't pass it.
3385
3386 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3387 (scrolling_window): Don't pass it.
3388
0f4a96b5
JB
33892011-03-25 Juanma Barranquero <lekktu@gmail.com>
3390
3391 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3392
3393 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3394 and `suffix'.
3395 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3396 of variables specific to SELinux and computation of `encoded_absname'.
3397
3398 * image.c (XPutPixel): Remove unused variable `height'.
3399
3400 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3401
3402 * unexw32.c (get_section_info): Remove unused variable `section'.
3403
3404 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3405 (system_process_attributes): Remove unused variable `sess'.
3406 (sys_read): Remove unused variable `err'.
3407
3408 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3409 (w32_wnd_proc): Remove unused variable `isdead'.
3410 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3411 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3412 (x_create_tip_frame): Remove unused variable `tem'.
3413
3414 * w32inevt.c (w32_console_read_socket):
3415 Remove unused variable `no_events'.
3416
3417 * w32term.c (x_draw_composite_glyph_string_foreground):
3418 Remove unused variable `width'.
3419
1149507c
JB
34202011-03-24 Juanma Barranquero <lekktu@gmail.com>
3421
3422 * w32term.c (x_set_glyph_string_clipping):
3423 Don't pass uninitialized region to CombineRgn.
3424
9c88f339
JB
34252011-03-23 Juanma Barranquero <lekktu@gmail.com>
3426
3427 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3428 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3429 (Fx_close_connection): Remove unused variable `i'.
3430
3431 * w32font.c (w32font_draw): Return number of glyphs.
3432 (w32font_open_internal): Remove unused variable `i'.
3433 (w32font_driver): Add missing initializer.
3434
3435 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3436 (fill_in_menu): Remove unused variable `items_added'.
3437
3438 * w32term.c (last_mouse_press_frame): Remove static global variable.
3439 (w32_clip_to_row): Remove unused variable `f'.
3440 (x_delete_terminal): Remove unused variable `i'.
3441
3442 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3443 (NOTHING): Remove unused static global variable.
3444 (uniscribe_check_otf): Remove unused variable `table'.
3445 (uniscribe_font_driver): Add missing initializers.
3446
dee091a3
JD
34472011-03-23 Julien Danjou <julien@danjou.info>
3448
3449 * term.c (Fsuspend_tty, Fresume_tty):
3450 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3451 * window.c (temp_output_buffer_show):
3452 * insdel.c (signal_before_change):
3453 * frame.c (Fhandle_switch_frame):
3454 * fileio.c (Fdo_auto_save):
3455 * emacs.c (Fkill_emacs):
3456 * editfns.c (save_excursion_restore):
3457 * cmds.c (internal_self_insert):
3458 * callint.c (Fcall_interactively):
3459 * buffer.c (Fkill_all_local_variables):
3460 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3461 Use Frun_hooks.
0f4a96b5 3462 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3463 unconditionnaly since it does the check itself.
3464
2c520ab5 34652011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3466
c9c49752
PE
3467 Fix more problems found by GCC 4.5.2's static checks.
3468
8abc3f12
PE
3469 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3470 the first time through the loop, since we know p0 < p1 then.
3471 This also avoids a gcc -Wstrict-overflow warning.
3472
a2d26660
PE
3473 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3474 leading to a memory leak, possible in functions like
3475 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3476 of objects (Bug#8318).
a2d26660 3477
916c72e9
PE
3478 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3479 that could (at least in theory) be that large.
3480
19ab8a18
PE
3481 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3482 This is less likely to overflow, and avoids undefined behavior if
3483 overflow does occur. All callers changed. Use strtoul to scan
3484 for the unsigned long integer.
b7cbbd6f
PE
3485 (pint2hrstr): Simplify and tune code slightly.
3486 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3487
f0641eff
PE
3488 * scroll.c (do_scrolling): Work around GCC bug 48228.
3489 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3490
7f650bb9
PE
3491 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3492 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3493 (validate_x_resource_name): Simplify count usage.
3494 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3495
37dd57d1
PE
3496 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3497 fail (Bug#8306).
81e56e61 3498
699979fc 3499 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3500
401bf9b4
PE
3501 * process.c (Fmake_network_process): Use socklen_t, not int,
3502 where POSIX says socklen_t is required in portable programs.
3503 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3504 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3505 (Fmake_network_process, server_accept_connection):
3506 (wait_reading_process_output, read_process_output):
3507 Likewise.
3508
b93aacde
PE
3509 * process.c: Rename or move locals to avoid shadowing.
3510 (list_processes_1, Fmake_network_process):
3511 (read_process_output_error_handler, exec_sentinel_error_handler):
3512 Rename or move locals.
4dc343ee 3513 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3514 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3515 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3516 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3517 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3518
af8a867c 3519 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3520 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3521 Include tparam.h instead, since it declares them.
af8a867c
PE
3522 * cm.h (PC): Remove extern decl; tparam.h now does this.
3523 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3524 * terminfo.c: Include tparam.h, to check interfaces.
3525 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3526 (tparam): Adjust signature to match interface in tparam.h;
3527 this removes some undefined behavior. Check that outstring and len
3528 are zero, which they always are with Emacs.
3529 * tparam.h (PC, BC, UP): New extern decls.
3530
0248044d 3531 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3532 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3533
8ff096c1 3534 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3535 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3536 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3537 (ftfont_list): Remove unused local.
49eaafba
PE
3538 (get_adstyle_property, ftfont_pattern_entity):
3539 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3540 Rename locals to avoid shadowing.
8ff096c1 3541
e2be39f6
PE
3542 * xfont.c (xfont_list_family): Mark var as initialized.
3543
c9735e30
PE
3544 * xml.c (make_dom): Now static.
3545
8f5201ae
PE
3546 * composite.c (composition_compute_stop_pos): Rename local to
3547 avoid shadowing.
b246f932
PE
3548 (composition_reseat_it): Remove unused locals.
3549 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3550 (composition_update_it): Mark var as initialized.
11b61122
PE
3551 (find_automatic_composition): Mark vars as initialized,
3552 with a FIXME (Bug#8290).
8f5201ae 3553
760fbc2c
PE
3554 character.h: Rename locals to avoid shadowing.
3555 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3556 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3557 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3558 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3559 to avoid shadowing.
3560
ff08eb85
PE
3561 * textprop.c (property_change_between_p): Remove; unused.
3562
fc7bf025
PE
3563 * intervals.c (interval_start_pos): Now static.
3564
235d7abc
PE
3565 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3566
44f230aa
SM
3567 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3568 Rename locals to avoid shadowing.
3e7d6594 3569
50060332
PE
3570 * sound.c (wav_play, au_play, Fplay_sound_internal):
3571 Fix pointer signedness.
d01f234b 3572 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3573 (wav_play): Initialize a variable to 0, to prevent undefined
3574 behavior (Bug#8278).
50060332 3575
c4fc4e30
PE
3576 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3577
918436ed
PE
3578 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3579
c939f91b
PE
3580 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3581 clobbering (Bug#8298).
b9c7f648
PE
3582 * sysdep.c (sys_subshell): Likewise.
3583 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3584
6bd8c144
PE
3585 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3586 This should get cleaned up, so that child_setup has the
3587 same signature on all platforms.
3588
7710357c 3589 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3590 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3591
c59da222
CY
35922011-03-22 Chong Yidong <cyd@stupidchicken.com>
3593
3594 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3595 not to be necessary, and produces flickering.
3596
66b87493
GM
35972011-03-20 Glenn Morris <rgm@gnu.org>
3598
3599 * config.in: Remove file.
3600
45b6f6d5
JB
36012011-03-20 Juanma Barranquero <lekktu@gmail.com>
3602
3603 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3604 are now in src/globals.h.
3605 (syms_of_minibuf): Remove spurious & from previous change.
3606
3ec03f7e
LL
36072011-03-20 Leo <sdl.web@gmail.com>
3608
3609 * minibuf.c (completing-read-function): New variable.
3610 (completing-read-default): Rename from completing-read.
3611 (completing-read): Call completing-read-function.
3612
b14e3e21
CY
36132011-03-19 Juanma Barranquero <lekktu@gmail.com>
3614
3615 * xfaces.c (Fx_load_color_file):
3616 Read color file from absolute filename (bug#8250).
3617
f2b726e6
JB
36182011-03-19 Juanma Barranquero <lekktu@gmail.com>
3619
3620 * makefile.w32-in: Update dependencies.
3621
09f6ff02
EZ
36222011-03-17 Eli Zaretskii <eliz@gnu.org>
3623
3624 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3625
29a6015a
PE
36262011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3627
a3a6c54e
PE
3628 Fix more problems found by GCC 4.5.2's static checks.
3629
b766f867
PE
3630 * process.c (make_serial_process_unwind, send_process_trap):
3631 (sigchld_handler): Now static.
3632
be02381c
PE
3633 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3634 That way, the code declares only the vars that it needs.
3635 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3636 * s/cygwin.h (PTY_ITERATION): Likewise.
3637 * s/darwin.h (PTY_ITERATION): Likewise.
3638 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3639
57048744
PE
3640 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3641 * process.c (allocate_pty): Don't declare stb unless it's needed.
3642
7914961c 3643 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3644 (CONSTANTLIM): Remove; unused.
3645 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3646 Define only if needed.
7914961c 3647
b3967b18
PE
3648 * unexelf.c (unexec): Name an expression,
3649 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3650 Use a different way to cause a compilation error if anyone uses
3651 n rather than nn, a way that does not involve shadowing.
73366a00 3652 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3653
29a6015a
PE
3654 * deps.mk (unexalpha.o): Remove; unused.
3655
43cfc33e 3656 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3657 * unexec.h: New file.
ce701a33
PE
3658 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3659 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3660 Depend on unexec.h.
3661 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3662 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3663 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3664 Change as necessary to match prototype in unexec.h.
ce701a33 3665
01f44d5a
PE
3666 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3667 shadowing.
4f63c6bb 3668 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3669
a6670b0b
PE
3670 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3671 Rename locals to avoid shadowing.
3672
cef2010d 3673 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3674 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3675
d4d7173a
PE
3676 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3677
f08b802a
PE
3678 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3679 warning when compiling print.c.
3680
3ddb0639
PE
3681 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3682 instead of using an uninitialized var.
5ad03b97 3683 (font_sort_entities): Mark var as initialized.
3ddb0639 3684
170a2692
PE
3685 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3686
e663c700
PE
3687 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3688 pointers to constants.
89bc529a 3689 (font_parse_fcname): Remove unused vars.
7b81e2d0 3690 (font_delete_unmatched): Now static.
ea838e10 3691 (font_get_spec): Remove; unused.
13a547c6
PE
3692 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3693 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3694 Rename or move locals to avoid shadowing.
e663c700 3695
2a80c887 3696 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3697 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3698
1384fa33 3699 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3700 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3701
8b2c52e9
PE
3702 * alloc.c (mark_backtrace): Move decl from here ...
3703 * lisp.h: ... to here, so that it can be checked.
3704
475545b5 3705 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3706 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3707 (lisp_indirect_variable): Name an expression,
3708 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3709 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3710
b1349114 3711 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3712 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3713 Use const pointer when appropriate.
b1349114 3714
a2928364
PE
3715 * lisp.h (get_system_name, get_operating_system_release):
3716 Move decls here, to check interfaces.
3717 * process.c (get_operating_system_release): Move decl to lisp.h.
3718 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3719 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3720 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3721 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3722 (Fformat_time_string, Fencode_time, Finsert_char):
3723 (Ftranslate_region_internal, Fformat):
3724 Rename or remove local vars to avoid shadowing.
9710023e 3725 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3726
a415e694
PE
3727 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3728 avoid shadowing.
3729
8ef4622d
PE
3730 * lisp.h (eassert): Check that the argument compiles, even if
3731 ENABLE_CHECKING is not defined.
3732
946f9a5b
PE
3733 * data.c (Findirect_variable): Name an expression, to avoid
3734 gcc -Wbad-function-cast warning.
112396d6 3735 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3736 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3737 (Fmake_variable_buffer_local, Fmake_local_variable):
3738 Mark variables as initialized.
52746918 3739 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3740
e5aab7e7 3741 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3742 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3743 Rename locals to avoid shadowing.
dff45157
PE
3744 (mark_stack): Move local variables into the #ifdef region where
3745 they're used.
7bc26fdb
PE
3746 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3747 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3748 needed otherwise.
3749 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3750 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3751 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3752
e5aab7e7
PE
3753 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3754 avoids undefined behavior in theory.
3755
4da60324
PE
3756 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3757
88043301
PE
3758 Use functions, not macros, for up- and down-casing (Bug#8254).
3759 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3760 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3761 to use the following functions instead of these macros.
3762 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3763 EMACS_INT, since callers assume the returned value fits in int.
3764 (upcase1): Likewise, for UPCASE_TABLE.
3765 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3766 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3767 the race-condition problem in the old DOWNCASE.
88043301 3768
19ed5445
PE
3769 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3770 Rename locals to avoid shadowing.
3771 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3772 (regex_compile, re_search_2, re_match_2_internal):
3773 Remove unused local vars.
952db0d7
PE
3774 (FREE_VAR): Rewrite so as not to use empty "else",
3775 which gcc can warn about.
da053e48 3776 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3777 (RETALLOC_IF): Define only if needed.
3778 (WORDCHAR_P): Likewise. This one is never needed, but is used
3779 only in a comment talking about a compiler bug, so put inside
3780 the #if 0 of that comment.
3781 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3782 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3783 Remove; unused.
19ed5445 3784
1f3561e4 3785 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3786 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3787 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3788
ded6f8f7
PE
3789 * search.c (simple_search): Remove unused var.
3790
dbd37a95
PE
3791 * dired.c (compile_pattern): Move decl from here ...
3792 * lisp.h: ... to here, so that it can be checked.
3793 (struct re_registers): New forward decl.
3794
7e47afad
PE
3795 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3796
85f24f61
PE
3797 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3798 All uses changed.
3799 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3800 Rename locals to avoid shadowing.
5671df8f 3801 (Fvertical_motion): Mark locals as initialized.
85f24f61 3802
181aa2be 3803 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3804 (casify_region): Mark local as initialized.
181aa2be 3805
930d429c
PE
3806 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3807
7082eac6
PE
3808 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3809 New macros, so that the caller can use some names other than
3810 gcpro1, gcpro2, etc.
3811 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3812 of the new macros.
3813 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3814 argument, for consistency with GCPRO2_VAR, etc: it is now the
3815 prefix of the variable, not the variable itself. All uses
3816 changed.
38b2c076
PE
3817 * dired.c (directory_files_internal, file_name_completion):
3818 Rename locals to avoid shadowing.
3819
15206ed9
PE
3820 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3821 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3822 dired.c's scmp function, had undefined behavior.
3823 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3824 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3825 * buffer.h: ... to here, because these macros use current_buffer,
3826 and the new implementation with inline functions needs to have
3827 current_buffer in scope now, rather than later when the macros
3828 are used.
3829 (downcase, upcase1): New static inline functions.
3830 (DOWNCASE, UPCASE1): Reimplement using these functions.
3831 This avoids undefined behavior in expressions like
3832 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3833 from race conditions in accessing the global variables
3834 case_temp1 and case_temp2.
3835 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3836 * lisp.h (case_temp1, case_temp2): Remove their decls.
3837 * character.h (ASCII_CHAR_P): Move from here ...
3838 * lisp.h: ... to here, so that the inline functions mentioned
3839 above can use them.
3840
4a6bea26
PE
3841 * dired.c (directory_files_internal_unwind): Now static.
3842
f14b7e14
PE
3843 * fileio.c (file_name_as_directory, directory_file_name):
3844 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3845 Now static.
2893f146
PE
3846 (file_name_as_directory): Use const pointers when appropriate.
3847 (Fexpand_file_name): Likewise. In particular, newdir might
3848 point at constant storage, so make it a const pointer.
fd4ead52 3849 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3850 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3851 signedness issues.
f839df0c
PE
3852 (Fset_file_times, Finsert_file_contents, auto_save_error):
3853 Rename locals to avoid shadowing.
f14b7e14 3854
5716756e 3855 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3856 (Ftry_completion, Fall_completions): Rename or remove locals
3857 to avoid shadowing.
5716756e 3858
b4c3046a
PE
3859 * marker.c (bytepos_to_charpos): Remove; unused.
3860
b45db522
PE
3861 * lisp.h (verify_bytepos, count_markers): New decls,
3862 so that gcc does not warn that these functions aren't declared.
3863
85876d07
PE
3864 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3865 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3866 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3867 (copy_text): Remove unused local var.
85876d07 3868
03d78a21 3869 * filelock.c (within_one_second): Now static.
b3dd38ab 3870 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3871
5df8f01b
PE
3872 * buffer.c (fix_overlays_before): Mark locals as initialized.
3873 (fix_start_end_in_overlays): Likewise. This function should be
3874 simplified by using pointers-to-pointers, but that's a different
3875 matter.
b1d876f1 3876 (switch_to_buffer_1): Now static.
8f54f30a
PE
3877 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3878 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3879
a70072c9 3880 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3881 Fix pointer signedness issue.
edced198
PE
3882 (sys_subshell): Mark local as volatile if checking for lint,
3883 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3884 (MAXPATHLEN): Define only if needed.
a70072c9 3885
a0977c44
PE
3886 * process.c (serial_open, serial_configure): Move decls from here ...
3887 * systty.h: ... to here, so that they can be checked.
3888
a884fdcc
PE
3889 * fns.c (get_random, seed_random): Move extern decls from here ...
3890 * lisp.h: ... to here, so that they can be checked.
3891
604efe86 3892 * sysdep.c (reset_io): Now static.
b8950c94 3893 (wait_for_termination_signal): Remove; unused.
604efe86 3894
38fc62d9
PE
3895 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3896 (copy_keymap_item, append_key, push_text_char_description):
3897 Now static.
1004a21a 3898 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3899 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3900 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3901 (describe_map_tree):
3902 Rename locals to avoid shadowing.
38fc62d9 3903
2f2650da
PE
3904 * keyboard.c: Declare functions static if they are not used elsewhere.
3905 (echo_char, echo_dash, cmd_error, top_level_2):
3906 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3907 (read_char, kbd_buffer_get_event, make_lispy_position):
3908 (make_lispy_event, make_lispy_movement, apply_modifiers):
3909 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3910 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3911 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3912 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3913 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3914
a053e86c 3915 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3916 (mark_kboards): Move decl here ...
3917 * alloc.c (mark_kboards): ... from here.
a053e86c 3918
4752793e
PE
3919 * lisp.h (force_auto_save_soon): New decl.
3920
74f10ca7 3921 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3922 (DEFINE_DUMMY_FUNCTION): New macro.
3923 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3924 Use it.
c03cd23f
PE
3925 (main): Add casts to avoid warnings
3926 if GCC considers string literals to be constants.
74f10ca7 3927
022e70d4
PE
3928 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3929
59d6fe83
PE
3930 * dbusbind.c: Pointer signedness fixes.
3931 (xd_signature, xd_append_arg, xd_initialize):
3932 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3933 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3934 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3935 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3936
78320123
PE
3937 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3938 if GCC considers string literals to be constants.
49cebcca 3939 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3940
35ac2a97
SM
39412011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3942
fb103ca9
SM
3943 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3944 (print_preprocess, print_object): New macro to fix last change.
3945
35ac2a97
SM
3946 * print.c (print_preprocess): Don't forget font objects.
3947
62973b41
JB
39482011-03-16 Juanma Barranquero <lekktu@gmail.com>
3949
3950 * emacs.c (USAGE3): Doc fixes.
3951
0e48bb22
AS
39522011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3953
3954 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3955 structure.
3956
7684e57b
JB
39572011-03-14 Juanma Barranquero <lekktu@gmail.com>
3958
3959 * lisp.h (VWindow_system, Qfile_name_history):
3960 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3961 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3962 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3963
3964 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3965 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3966
3967 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3968 * w32console.c (detect_input_pending, read_input_pending)
3969 (encode_terminal_code):
3970 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3971 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3972 (w32_system_caret_y, Qfile_name_history):
3973 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3974 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3975 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3976 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3977 * w32proc.c (Qlocal, report_file_error):
3978 * w32term.c (Vwindow_system, updating_frame):
3979 * w32uniscribe.c (initialized, uniscribe_font_driver):
3980 Remove unneeded extern declarations.
3981
2aa46d6c
CY
39822011-03-14 Chong Yidong <cyd@stupidchicken.com>
3983
c96bbc66 3984 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3985
cffc6f3b
CY
39862011-03-13 Chong Yidong <cyd@stupidchicken.com>
3987
3988 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3989 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3990 These macros can no longer be used for assignment.
3991
44f230aa
SM
3992 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3993 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3994 (record_buffer_markers, fetch_buffer_markers): New functions for
3995 recording and fetching special buffer markers.
3996 (set_buffer_internal_1, set_buffer_temp): Use them.
3997
3998 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3999
4000 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4001
4002 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4003 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4004
4005 * xdisp.c (hscroll_window_tree):
4006 (reconsider_clip_changes): Use PT instead of BUF_PT.
4007
d251f04b
EZ
40082011-03-13 Eli Zaretskii <eliz@gnu.org>
4009
4010 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4011 $(EMACS_ROOT)/lib/intprops.h.
4012
f0c77cd1
PE
40132011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4014
3eca4629
PE
4015 Fix more problems found by GCC 4.5.2's static checks.
4016
7c86ee98
PE
4017 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4018 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4019 (xg_free_frame_widgets): Make it clear that a local variable is
4020 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4021 (gdk_window_get_screen): Make it clear that this macro is needed
4022 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4023 (int_gtk_range_get_value): New function, which avoids a diagnostic
4024 from gcc -Wbad-function-cast.
4025 (xg_set_toolkit_scroll_bar_thumb): Use it.
4026 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4027 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4028 (get_utf8_string, xg_get_file_with_chooser):
4029 Rename locals to avoid shadowing.
4030 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4031
41729b81
PE
4032 * xgselect.c (xg_select): Remove unused var.
4033
f0c77cd1
PE
4034 * image.c (four_corners_best): Mark locals as initialized.
4035 (gif_load): Initialize transparent_p to zero (Bug#8238).
4036 Mark another local as initialized.
ec6cf4c6 4037 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4038
ce0ad53d 4039 * image.c (clear_image_cache): Now static.
d5d5a617 4040 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4041 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4042 (x_edge_detection): Remove unnecessary cast that
4043 gcc -Wbad-function-cast diagnoses.
2037898d 4044 (gif_load): Fix pointer signedness.
6ae141d6
PE
4045 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4046 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4047
33383987 40482011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4049
d32df629
PE
4050 Improve quality of tests for time stamp overflow.
4051 For example, without this patch (encode-time 0 0 0 1 1
4052 1152921504606846976) returns the obviously-bogus value (-948597
4053 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4054 reports time overflow. See
4055 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4056 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4057 * editfns.c: Include limits.h and intprops.h.
4058 (TIME_T_MIN, TIME_T_MAX): New macros.
4059 (time_overflow): Move earlier, to before first use.
4060 (hi_time, lo_time): New functions, for an accurate test for
4061 out-of-range times.
4062 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4063 (Fget_internal_run_time): Don't assume time_t fits in int.
4064 (make_time): Use list2 instead of Fcons twice.
4065 (Fdecode_time): More accurate test for out-of-range times.
4066 (check_tm_member): New function.
4067 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4068 (lisp_time_argument): Don't rely on undefined left-shift and
4069 right-shift behavior when checking for time stamp overflow.
8be6f318 4070
fe31d94c
PE
4071 * editfns.c (time_overflow): New function, refactoring common code.
4072 (Fformat_time_string, Fdecode_time, Fencode_time):
4073 (Fcurrent_time_string): Use it.
4074
8be6f318
PE
4075 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4076 * dired.c (make_time): Move to ...
4077 * editfns.c (make_time): ... here.
4078 * systime.h: Note the move.
4079
09d9db2c 40802011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4081
126bc0dc
YM
4082 * fringe.c (update_window_fringes): Remove unused variables.
4083
c47cbdfd
YM
4084 * unexmacosx.c (copy_data_segment): Also copy __got section.
4085 (Bug#8223)
4086
7ac80be9
EZ
40872011-03-12 Eli Zaretskii <eliz@gnu.org>
4088
c96bbc66 4089 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4090 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4091 Constify `char *' arguments and their references according to
4092 prototypes in tparam.h.
4093
ecb0f94d 4094 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4095
7ac80be9
EZ
4096 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4097 Adapt all references accordingly.
4098
4099 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4100
ef1fd07e
TT
41012011-03-11 Tom Tromey <tromey@redhat.com>
4102
4103 * buffer.c (syms_of_buffer): Remove obsolete comment.
4104
7ef4b50c
EZ
41052011-03-11 Eli Zaretskii <eliz@gnu.org>
4106
4107 * termhooks.h (encode_terminal_code): Declare prototype.
4108
4109 * msdos.c (encode_terminal_code): Don't declare prototype.
4110
4111 * term.c (encode_terminal_code): Now external again, used by
4112 w32console.c and msdos.c.
4113
44f230aa
SM
4114 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4115 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4116
4b1ec863 41172011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4118
1714f52b 4119 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4120
4b1ec863
PE
4121 * fringe.c (update_window_fringes): Mark locals as initialized
4122 (Bug#8227).
4123 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4124
524c7aa6
PE
4125 * alloc.c (mark_fringe_data): Move decl from here ...
4126 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4127 to check its interface.
4128 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4129
a5c0af81 4130 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4131 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4132 (fontset_font): Mark local as initialized.
a9a06e0b 4133 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4134
b4716021
PE
4135 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4136
811e9bac 4137 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4138 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4139 (x_own_selection, Fx_disown_selection_internal): Rename locals
4140 to avoid shadowing.
4141 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4142
7e3ab302
PE
4143 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4144 so that the caller can use some name other than gcpro1.
4145 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4146 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4147 (Fx_backspace_delete_keys_p):
4148 Use them to avoid shadowing, and rename vars to avoid shadowing.
4149 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4150 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4151 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4152 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4153 Remove unused locals.
7e3ab302
PE
4154 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4155 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4156 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4157 macros.
f78faa98 4158
e2b13473
PE
4159 * xterm.h (x_mouse_leave): New decl.
4160
77f23912
PE
4161 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4162 Remove unused functions.
cdf4ba58
PE
4163 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4164 (x_calc_absolute_position): Now static.
7411c686 4165 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4166 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4167 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4168 unless they are used.
38d0b34a
PE
4169 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4170 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4171 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4172 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4173 (x_error_catcher, x_connection_closed, x_error_handler):
4174 (x_error_quitter, xembed_send_message, x_iconify_frame):
4175 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4176 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4177 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4178
44f230aa
SM
4179 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4180 Rename or move locals to avoid shadowing.
6b463e58 4181 (tty_defined_color, merge_face_heights): Now static.
5967d051 4182 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4183 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4184 does not deduce is never used uninitialized.
73719eba
PE
4185 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4186 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4187
426994c3 4188 * terminal.c (store_terminal_param): Now static.
5489860b 4189
032f1620 4190 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4191 (set_frame_menubar): Remove unused local.
d4323972 4192 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4193 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4194 since they might point to immutable storage.
281585b0
PE
4195 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4196 since it's unused otherwise.
032f1620 4197
367c19e5 4198 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4199 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4200 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4201 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4202 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4203 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4204 does not deduce are never used uninitialized.
70739cbe 4205
07b48fa9
PE
4206 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4207
8868a238 4208 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4209 * window.c (window_loop, size_window):
4210 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4211
7e5cf297 4212 * window.c (display_buffer): Now static.
d6550a9f
PE
4213 (size_window): Mark variables that gcc -Wuninitialized
4214 does not deduce are never used uninitialized.
a586633d
PE
4215 * window.h (check_all_windows): New decl, to forestall
4216 gcc -Wmissing-prototypes diagnostic.
5b555da1 4217 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4218
f6095868
PE
4219 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4220 shadowing.
4221 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4222 Include <limits.h>.
4223 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4224 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4225 (load_charset_map): Mark variables that gcc -Wuninitialized
4226 does not deduce are never used uninitialized.
53df7c11 4227 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4228
f38b440c
PE
4229 * coding.c (coding_set_source, coding_set_destination):
4230 Use "else { /* comment */ }" rather than "else /* comment */;"
4231 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4232 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4233 a block, when the outer 'i' will do.
4234 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4235 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4236 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4237 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4238 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4239 Rename locals to avoid shadowing.
4240 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4241 * coding.c (emacs_mule_char, encode_invocation_designation):
4242 Now static, since they're not used elsewhere.
413bb2db 4243 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4244 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4245 (decode_coding_emacs_mule): Mark variables that gcc
4246 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4247 (detect_coding_iso_2022): Initialize a local variable that might
4248 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4249 this initialization is needed. (Bug#8211)
5f58e762
PE
4250 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4251 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4252 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4253 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4254 Remove unused macros.
f38b440c 4255
232b38b9 4256 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4257 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4258 * character.c (string_count_byte8): Likewise.
232b38b9 4259
fb90da1b
PE
4260 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4261 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4262
fb93dbc2
PE
4263 * chartab.c (copy_sub_char_table): Now static, since it's not used
4264 elsewhere.
5c156ace
PE
4265 (sub_char_table_ref_and_range, char_table_ref_and_range):
4266 Rename locals to avoid shadowing.
bbcd0949 4267 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4268
7d3b3862 4269 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4270 (BIDI_BOB): Remove unused macro.
7d3b3862 4271
6be7d3da
PE
4272 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4273 deduce are never used uninitialized.
c2ed9c8b 4274 * term.c (encode_terminal_code): Likewise.
6be7d3da 4275
75f8807f 4276 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4277
50938595
PE
4278 * tparam.h: New file.
4279 * term.c, tparam.h: Include it.
4280 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4281 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4282 Move these decls to tparam.h, and make them agree with what
4283 is actually in tparam.c. The previous trick of using incompatible
4284 decls in different modules does not conform to the C standard.
4285 All callers of tparam changed to use tparam's actual API.
4286 * tparam.c (tparam1, tparam, tgoto):
4287 Use const pointers where appropriate.
4288
fbceeba2
PE
4289 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4290 * cm.h (struct cm): Likewise.
4291 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4292 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4293 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4294 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4295 (turn_on_face, init_tty): Likewise.
4296 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4297
7f3f1250
PE
4298 * term.c (term_mouse_position): Rename local to avoid shadowing.
4299
e6ca6543
PE
4300 * alloc.c (mark_ttys): Move decl from here ...
4301 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4302
c40f8d15
AS
43032011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4304
4305 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4306
cfe0661d
JB
43072011-03-09 Juanma Barranquero <lekktu@gmail.com>
4308
4309 * search.c (compile_pattern_1): Remove argument regp, unused since
4310 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4311 (compile_pattern): Don't pass it.
4312
0afb4571
J
43132011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4314
4315 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4316 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4317 for ! HAVE_GTK3.
4318 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4319
4320 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4321
4322 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4323 gdk_window_get_screen, gdk_window_get_geometry,
4324 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4325 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4326 (xg_get_pixbuf_from_pixmap): New function.
4327 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4328 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4329 Call xg_get_pixbuf_from_pixmap instead of
4330 gdk_pixbuf_get_from_drawable.
4331 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4332 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4333 (xg_check_special_colors): Use GtkStyleContext and its functions
4334 for HAVE_GTK3.
4335 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4336 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4337 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4338 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4339 Call gtk_widget_get_preferred_size.
0afb4571
J
4340 (xg_frame_resized): gdk_window_get_geometry only takes 5
4341 parameters.
44f230aa
SM
4342 (xg_win_to_widget, xg_event_is_for_menubar):
4343 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4344 (xg_set_widget_bg): New function.
4345 (delete_cb): New function.
895009e1 4346 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4347 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4348 (xg_set_background_color): Call xg_set_widget_bg.
4349 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4350 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4351 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4352 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4353 if ! HAVE_GTK3.
4354 (update_frame_tool_bar): Call gtk_widget_hide.
4355 (xg_initialize): Use GDK_KEY_g.
4356
4357 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4358 if ! HAVE_GTK3
4359 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4360
4361 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4362 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4363 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4364
1c2cc4ef
JB
43652011-03-08 Juanma Barranquero <lekktu@gmail.com>
4366
4367 * w32xfns.c (select_palette): Check success of RealizePalette against
4368 GDI_ERROR, not zero.
4369
33383987 4370See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4371
4372;; Local Variables:
4373;; coding: utf-8
aac0c6e3
MR
4374;; End:
4375
33383987 4376 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4377
4378 This file is part of GNU Emacs.
4379
4380 GNU Emacs is free software: you can redistribute it and/or modify
4381 it under the terms of the GNU General Public License as published by
4382 the Free Software Foundation, either version 3 of the License, or
4383 (at your option) any later version.
4384
4385 GNU Emacs is distributed in the hope that it will be useful,
4386 but WITHOUT ANY WARRANTY; without even the implied warranty of
4387 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4388 GNU General Public License for more details.
4389
4390 You should have received a copy of the GNU General Public License
4391 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.