* src/makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
[bpt/emacs.git] / src / ChangeLog
CommitLineData
1f05cd82
CS
12011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2
3 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4 support MSVC.
5
22610910
JR
62011-11-05 Jason Rumney <jasonr@gnu.org>
7
8 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
9 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
10 fonts (Bug#6029).
11 (add_font_entity_to_list): Fix logic errors in mixed boolean and
12 bitwise arithmetic preventing use of unicode-sip and non-truetype
13 opentype fonts.
14
a06776b2
EZ
152011-11-05 Eli Zaretskii <eliz@gnu.org>
16
3ad924ba
EZ
17 * s/ms-w32.h (fstat, stat, utime): Move redirections to
18 "emacs"-only part.
19
a06776b2
EZ
20 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
21 initialization code to keep similarity to xfns.c after changes
22 from 2011-11-05.
23
c9e7db78
JD
242011-11-05 Jan Djärv <jan.h.d@swipnet.se>
25
a97f8f3f
JD
26 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
27 (unwind_create_frame): New function (Bug#9943).
28 (Fx_create_frame): Restructure code to be more similar to the one in
29 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
30 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
31 Move terminal->reference_count++ just before making the frame official
32 (Bug#9943).
33
34 * nsterm.m (x_free_frame_resources): New function.
35 (x_destroy_window): Move code to x_free_frame_resources.
36
c9e7db78
JD
37 * xfns.c (unwind_create_frame): Fix comment.
38 (Fx_create_frame, x_create_tip_frame): Move
39 terminal->reference_count++ just before making the frame
40 official. Move initialization of image_cache_refcount and
41 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
42
a6fc3b5c
EZ
432011-11-05 Eli Zaretskii <eliz@gnu.org>
44
45 Support MSVC build with newer versions of Visual Studio.
46 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
47 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
48 nt/gmake.defs.
49
50 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
51 which are not supported by MSVC.
52 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
53 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
54 bitfields.
55 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
56 types in bitfields.
57 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
58
59 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
60
612011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
62
63 Support MSVC build with newer versions of Visual Studio.
64 * w32.c: Don't include w32api.h for MSVC.
65 (init_environment) [_MSC_VER]: Call sys_access, not _access.
66
67 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
68 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
69 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
70 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
71 e_* cousins.
72 (alloca) [_MSC_VER]: Define to _alloca.
73
74 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
75
76 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
77
a58c13ed
EZ
782011-11-04 Eli Zaretskii <eliz@gnu.org>
79
80 * xdisp.c (note_mouse_highlight): If either of
81 previous/next-single-property-change returns nil, treat that as
82 the beginning or the end of the buffer. (Bug#9955)
83
fe0b6370
JD
842011-11-04 Jan Djärv <jan.h.d@swipnet.se>
85
a58c13ed 86 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
87 label is not null (Bug#9951).
88 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
89 may be NULL.
90
89bd5ee1
EZ
912011-11-04 Eli Zaretskii <eliz@gnu.org>
92
93 * window.c (Fwindow_body_size): Mention in the doc string that the
94 return value is in frame's canonical units. (Bug#9949)
95
84c3edb9
EZ
962011-11-03 Eli Zaretskii <eliz@gnu.org>
97
4e2fb5c7
EZ
98 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
99
84c3edb9 100 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 101 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 102 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 103
bc17a887
EZ
1042011-11-01 Eli Zaretskii <eliz@gnu.org>
105
106 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
107 Don't stop backward scan on the continuation glyph, even though
108 its CHARPOS is positive.
26b46e51
EZ
109 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
110 cover_string to disp_string.
bc17a887 111
4ee88440
MR
1122011-11-01 Martin Rudalics <rudalics@gmx.at>
113
114 * window.c (temp_output_buffer_show): Don't use
115 Vtemp_buffer_show_specifiers.
116 (Vtemp_buffer_show_specifiers): Remove unused variable.
117
c2ff3c02
EZ
1182011-10-30 Eli Zaretskii <eliz@gnu.org>
119
120 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
121 past the beginning of the current glyph matrix.
122
6e56383b
JD
1232011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
124
125 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
126 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
127 HAVE_GTK3 (Bug#9869).
b77a6a7f 128
3b574623
JD
129 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
130 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
131
b77a6a7f
JD
132 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
133
134 * xterm.c: Declare x_handle_net_wm_state to return int.
135 (handle_one_xevent): Check if we are iconified but don't have
136 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
137 (get_current_wm_state): Return non-zero if not hidden,
138 check for _NET_WM_STATE_HIDDEN (Bug#9893).
139 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
140 (x_handle_net_wm_state): Return what get_current_wm_state returns.
141 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
142
196e41e4
PE
1432011-10-29 Paul Eggert <eggert@cs.ucla.edu>
144
145 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
146 so that this new function doesn't get optimized away by a
147 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
148
021f2e1a
AS
1492011-10-29 Andreas Schwab <schwab@linux-m68k.org>
150
151 * frame.h (MOUSE_HL_INFO): Remove excess parens.
152
8b058d44
EZ
1532011-10-29 Eli Zaretskii <eliz@gnu.org>
154
155 Fix the `xbytecode' command.
156 * .gdbinit (xprintbytestr): New command.
157 (xwhichsymbols): Renamed from `which'; all callers changed.
158 (xbytecode): Print the byte-code string as well.
159
4452fb80
EZ
1602011-10-29 Kim Storm <storm@cua.dk>
161
8b058d44
EZ
162 * alloc.c (which_symbols): New function.
163
21b72067
AS
1642011-10-29 Andreas Schwab <schwab@linux-m68k.org>
165
166 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
167 line. (Bug#9903)
168
83ed7b5c
GM
1692011-10-29 Glenn Morris <rgm@gnu.org>
170
171 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
172 Not clear what it was for, and it causes various bugs. (Bug#9839)
173
5a7a728b
EZ
1742011-10-28 Eli Zaretskii <eliz@gnu.org>
175
176 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
177 possible random value that matches one of those tested as
178 condition to clear the mouse face.
179
d3d0842f
CY
1802011-10-28 Chong Yidong <cyd@gnu.org>
181
182 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
183
31b39d13
DN
1842011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
185
186 * window.c (make_window): Initialize phys_cursor_on_p.
187
9aba6043
SM
1882011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
189
190 * lisp.h (struct Lisp_Symbol): Update comments.
191
c20992f4
JB
1922011-10-28 Juanma Barranquero <lekktu@gmail.com>
193
194 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
195
db4f02f2
EZ
1962011-10-28 Eli Zaretskii <eliz@gnu.org>
197
198 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
199 <oslsachem@gmail.com> for helping to debug this.
200
201 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
202 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
203 (g_b_init_get_glyph_outline_w): New static variables.
204 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
205 (GetGlyphOutlineW_Proc): New typedefs.
206 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
207 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
208 New functions.
209 (w32font_open_internal, compute_metrics):
210 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
211 instead of calling the "wide" APIs directly.
212
213 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
214
215 * w32.h (syms_of_w32font): Add prototype.
216
87e68db4
JB
2172011-10-27 Juanma Barranquero <lekktu@gmail.com>
218
219 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
220 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
221 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
222 (Fmove_to_window_line): Doc fix.
223
435c1d67
CY
2242011-10-27 Chong Yidong <cyd@gnu.org>
225
226 * process.c (make_process): Set gnutls_state to NULL.
227
228 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
229 non-NULL, regardless of GNUTLS_INITSTAGE.
230 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
231 an error. Set process slots as soon as we allocate them.
232
233 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
234
9c6c6f49
CY
2352011-10-27 Chong Yidong <cyd@gnu.org>
236
9aba6043
SM
237 * gnutls.c (emacs_gnutls_deinit): New function.
238 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
239 (Fgnutls_deinit, Fgnutls_boot): Use it.
240
241 * process.c (make_process): Initialize GnuTLS credentials to NULL.
242 (deactivate_process): Call emacs_gnutls_deinit.
243
657d08d3
JB
2442011-10-27 Juanma Barranquero <lekktu@gmail.com>
245
246 * image.c (x_create_x_image_and_pixmap):
247 * w32.c (sys_rename, w32_delayed_load):
248 * w32font.c (fill_in_logfont):
249 * w32reg.c (x_get_string_resource): Silence compiler warnings.
250
5430d399
JB
2512011-10-26 Juanma Barranquero <lekktu@gmail.com>
252
253 * w32fns.c (w32_default_color_map): New function,
254 extracted from Fw32_default_color_map.
a7ef684b 255 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 256
fe0055fa
PE
2572011-10-25 Paul Eggert <eggert@cs.ucla.edu>
258
259 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
260
e6346438
SM
2612011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
262
263 * keyboard.c (test_undefined): New function (bug#9751).
264 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
265
e112cc37
ET
2662011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
267
268 * sysdep.c (init_sys_modes): Fix the check for the controlling
269 terminal (Bug#6649).
270
7b5d6677
EZ
2712011-10-20 Eli Zaretskii <eliz@gnu.org>
272
273 * dispextern.h (struct bidi_it): New member next_en_type.
274
275 * bidi.c (bidi_line_init): Initialize the next_en_type member.
276 (bidi_resolve_explicit_1): When next_en_pos is valid for the
277 current character, check also for next_en_type being WEAK_EN.
278 (bidi_resolve_weak): Don't enter the expensive loop if the current
279 position is before next_en_pos. Record the bidi type of the first
280 non-ET, non-BN character we find, in addition to its position.
281 (bidi_level_of_next_char): Invalidate next_en_type when
282 next_en_pos is over-stepped.
283
7da0b018
PE
2842011-10-20 Paul Eggert <eggert@cs.ucla.edu>
285
286 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
287 * editfns.c: Rewrite current-time-zone so that it invokes
288 the equivalent of (format-time-string "%Z") to get the time zone name.
289 This fixes a bug when the time zone name contains characters that
290 need converting from the system time locale to Emacs internal format.
291 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
292 that patch fixed format-time-string to do the conversion, but
293 I forgot to fix current-time-zone.
294 (format_time_string): New function, containing most of
295 what Fformat_time_string used to contain.
296 (Fformat_time_string): Rewrite in terms of format_time_string.
297 This doesn't change this function's behavior.
298 (current-time-zone): Rewrite to use format_time_string.
299 This fixes the bug reported by Michael Schierl in
300 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
301 Jason Rumney's 2007-06-07 change worked around this bug, but
302 didn't fix it.
303 * systime.h (tzname, timezone): Remove no-longer-used declarations.
304
8547b010
EZ
3052011-10-19 Eli Zaretskii <eliz@gnu.org>
306
307 * xdisp.c (start_display): If the character at POS is displayed
308 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
309 (try_window_reusing_current_matrix): If a line ends in a display
310 vector or the next line starts in a display vector, continue
311 redrawing the window even though the character position of
312 start_row was reached.
8547b010
EZ
313 (Bug#9771, part 2)
314
4e948d15
CY
3152011-10-18 Chong Yidong <cyd@gnu.org>
316
317 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
318 with nobreak-char-display too.
319
4787455f
EZ
3202011-10-18 Eli Zaretskii <eliz@gnu.org>
321
322 Fix part 3 of bug#9771.
323 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
324 (bidi_resolve_neutral): Don't enter the expensive loop looking for
325 non-neutral characters if the current character is a paragraph
326 separator (a.k.a. Newline). This avoids running the same
327 expensive loop twice, once when we consume the preceding newline
328 and the other time when the line actually needs to be displayed.
329 Avoid the loop when we see neutrals on the base embedding level
330 following a character whose directionality is the same as the
331 paragraph's. This avoids running the expensive loop when a line
332 ends in a long sequence of neutrals, like control characters.
333 Add assertion against STRONG_AL type. Slightly rearrange code
334 that determines the type of a neutral given the first non-neutral
335 that follows it.
336 (bidi_level_of_next_char): Set next_en_pos to zero when
337 invalidating its info.
338
2c91f553
EZ
3392011-10-17 Eli Zaretskii <eliz@gnu.org>
340
341 * xdisp.c (push_display_prop): Determine whether to record string
342 or buffer position by IT->string, not by IT->method. Allow
343 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
344 (move_it_vertically_backward): Don't look for character position
345 immediately after the newline when in a continuation line.
346 (Bug#9771, part 1)
2c91f553 347
c7b08b0d
MR
3482011-10-15 Martin Rudalics <rudalics@gmx.at>
349
350 * window.c (coordinates_in_window): Rewrite and delabelize
351 vertical border check. (Bug#5357) (Bug#9618)
352
6b02f655
SM
3532011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
354
355 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
356 errors in XSetWindowBorder (bug#9310).
357
81d40c92
DA
3582011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
359
360 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
361 avoid crash when xmalloc overrun checking is enabled.
362
d4172c3b
EZ
3632011-10-13 Eli Zaretskii <eliz@gnu.org>
364
365 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
366 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
367 cursor motion with <left> and <right> arrow keys.
368
369 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
370 some callers set that themselves.
371
b00eea75
EZ
3722011-10-12 Eli Zaretskii <eliz@gnu.org>
373
374 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
375 display string and the previous row comes from the same string and
376 is empty. (Bug#9739) (Bug#9738)
377
8fe012c4
SM
3782011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
379
380 * doc.c (get_doc_string): Encode file name (bug#9735).
381
0074aef2
EZ
3822011-10-12 Eli Zaretskii <eliz@gnu.org>
383
79beb178
EZ
384 * bidi.c (bidi_level_of_next_char):
385 * xdisp.c (get_visually_first_element): Remove old incorrect
386 comments regarding the Unicode Line Separator character.
387
0074aef2
EZ
388 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
389
6e4b3fbe
DA
3902011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
391
392 * alloc.c (Fgc_status): Do not access beyond zombies array
393 boundary if nzombies > MAX_ZOMBIES.
394 * alloc.c (dump_zombies): Add missing format specifier.
395
0324f3af
PE
3962011-10-12 Paul Eggert <eggert@cs.ucla.edu>
397
b5525cac
PE
398 * xdisp.c (set_cursor_from_row): Simplify conditionals,
399 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
400
0324f3af
PE
401 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
402 Some packages use them to denote characters with modifiers.
403
e9b5f888
AS
4042011-10-11 Andreas Schwab <schwab@linux-m68k.org>
405
406 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
407 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
408 matching a pp-number. Rename parameter var to var1.
409
127827c0
SM
4102011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
411
412 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
413
c8fd3bd0
GM
4142011-10-08 Glenn Morris <rgm@gnu.org>
415
416 * callint.c (Fcall_interactively): Give a more explicit error for the
417 'c' case with a non-character input. (Bug#8479)
418
352ec8ff
EZ
4192011-10-08 Eli Zaretskii <eliz@gnu.org>
420
03669ccb
EZ
421 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
422 lines.
7061c986
EZ
423 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
424 lines that are hscrolled on the left.
03669ccb 425
352ec8ff
EZ
426 * dispnew.c (buffer_posn_from_coords): Account for a possible
427 presence of header-line. (Bug#4426)
428
a66cfb1c
SM
4292011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
430
6b02f655
SM
431 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
432 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 433
7c5ee88e
PE
4342011-10-07 Paul Eggert <eggert@cs.ucla.edu>
435
436 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
437 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
438 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
439 this makes Emacs dump core during garbage collection on rare
440 occasions. sizeof is obviously inferior to offsetof here, so
441 stick with offsetof.
442 (GC_POINTER_ALIGNMENT): New macro.
443 (mark_memory): Omit 3rd (offset) arg; caller changed.
444 Don't assume EMACS_INT alignment is the same as pointer alignment.
445
df1bbe5b
SM
4462011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
447
448 * keyboard.c (read_key_sequence_remapped): New var.
449 (read_key_sequence): Compute remapping in the right buffer.
450 (command_loop_1): Use read_key_sequence's remapping directly.
451
51553db6
SM
4522011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
453
32c1fffd
SM
454 * dired.c (file_name_completion): Don't expand file name.
455 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
456 before checking file name handler.
457
51553db6
SM
458 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
459 they've been requested explicitly (bug#9591).
460
b6bd1599 4612011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
462
463 * keymap.c (Fsingle_key_description): Use make_specified_string
464 instead of build_string to build string from push_key_description.
465 (Bug#5193)
466
f701dc2a
PE
4672011-09-30 Paul Eggert <eggert@cs.ucla.edu>
468
4222c55d
PE
469 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
470 This fixes a Y2038 bug on 64-bit hosts.
471 * buffer.c (reset_buffer):
472 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
473 (Fclear_buffer_auto_save_failure):
474 Use 0, not -1, to represent an unset failure time, since time_t
475 might not be signed.
476
f701dc2a
PE
477 Remove dependency on glibc malloc internals.
478 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
479 Move back here from lisp.h, but with their new implementations.
480 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
481 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
482 * charset.c (charset_table_init): New static var.
483 (syms_of_charset): Use it instead of xmalloc. This removes a
484 dependency on glibc malloc internals. See Eli Zaretskii's comment in
485 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
486 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
487 Move back to alloc.c.
488 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
489 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
490
9ceebf39
JD
4912011-09-30 Jan Djärv <jan.h.d@swipnet.se>
492
493 * nsterm.m (windowDidResize): Call x_set_window_size only when
494 ns_in_resize is true. Otherwise set pixelwidth/height and
495 call change_frame_size (Bug#9628).
496
cb993c58
PE
4972011-09-30 Paul Eggert <eggert@cs.ucla.edu>
498
3930c88b
PE
499 Port --enable-checking=all to Fedora 14 x86-64.
500 * charset.c (syms_of_charset): Also account for glibc malloc's
501 internal overhead when calculating the initial malloc maximum.
502
cb993c58
PE
503 Port --enable-checking=all to Fedora 14 x86.
504 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
505 Move to lisp.h.
506 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
507 (overrun_check_realloc, overrun_check_free):
508 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
509 That way, xmalloc returns a properly-aligned pointer even if
510 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
511 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
512 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
513 into account when calculating the initial malloc maximum.
514 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
515 Move here from alloc.c, so that charset.c can use it too.
516 Properly align; the old code wasn't right for common 32-bit hosts
517 when configured with --enable-checking=all.
518 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
519 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
520
31bed486
EZ
5212011-09-29 Eli Zaretskii <eliz@gnu.org>
522
04c70788 523 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
524 use EDOM.
525
fbcaa2f3
EZ
5262011-09-28 Eli Zaretskii <eliz@gnu.org>
527
528 * xdisp.c (compute_display_string_end): If there's no display
529 string at CHARPOS, return -1.
530
531 * bidi.c (bidi_fetch_char): When compute_display_string_end
532 returns a negative value, treat the character as a normal
533 character not covered by a display string. (Bug#9624)
534
a239d4e9
JB
5352011-09-28 Juanma Barranquero <lekktu@gmail.com>
536
537 * lread.c (Fread_from_string): Fix typo in docstring.
538
88652fd5
EZ
5392011-09-27 Eli Zaretskii <eliz@gnu.org>
540
541 * xdisp.c (handle_invisible_prop): If invisible text ends on a
542 newline, reseat the iterator instead of bidi-iterating there one
543 character at a time. (Bug#9610)
32c1fffd
SM
544 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
545 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 546
ed497dd4
AS
5472011-09-27 Andreas Schwab <schwab@linux-m68k.org>
548
549 * lread.c (readevalloop): Use correct code for NBSP.
550 (read1): Likewise. (Bug#9608)
551
b2bf61aa
MA
5522011-09-25 Michael Albinus <michael.albinus@gmx.de>
553
554 * dbusbind.c (Fdbus_register_signal): When service is not
555 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
556
32bbb17c
GM
5572011-09-25 Glenn Morris <rgm@gnu.org>
558
559 * buffer.c (truncate-lines): Doc fix.
560
94e0933e
CY
5612011-09-24 Chong Yidong <cyd@stupidchicken.com>
562
563 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
564 (Fset_window_next_buffers): Doc fix.
565
cddde921
GM
5662011-09-24 Glenn Morris <rgm@gnu.org>
567
568 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
569
1260aef1
PE
5702011-09-24 Paul Eggert <eggert@cs.ucla.edu>
571
25b4bfa0
PE
572 Fix minor problems found by static checking.
573 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
574 * indent.c (Fvertical_motion): Fix == vs = typo.
575
e3cbd34b
EZ
5762011-09-24 Eli Zaretskii <eliz@gnu.org>
577
a66cfb1c
SM
578 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
579 Default value is now t. Doc fix.
6bf7006f 580
e3cbd34b 581 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 582 logic when moving up, not only when moving down. Fix the
e3cbd34b 583 confusing name and values of the it_overshoot_expected variable;
32c1fffd 584 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
585
586 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
587 CHARPOS is covered by a display string which includes newlines.
588 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
589 is covered by a display string with embedded newlines.
590
a3de0cbd
MA
5912011-09-24 Michael Albinus <michael.albinus@gmx.de>
592
593 * dbusbind.c (Fdbus_register_signal): Add match rule to
594 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
595 (Fdbus_register_method, Vdbus_registered_objects_table):
596 Fix docstring.
a3de0cbd 597
b260039d
JM
5982011-09-24 Jim Meyering <meyering@redhat.com>
599
32c1fffd 600 do not ignore write error for any output size
b260039d
JM
601 The previous change was incomplete.
602 While it makes emacs --batch detect the vast majority of stdout
603 write failures, errors were still ignored whenever the output size is
604 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
605 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
606 && echo FAIL: ignored write error
607 FAIL: ignored write error
608 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
609 && echo FAIL: ignored write error
610 FAIL: ignored write error
611 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
612
8eca8a7c
AS
6132011-09-23 Andreas Schwab <schwab@linux-m68k.org>
614
615 * emacs.c (Fkill_emacs): In noninteractive mode exit
616 non-successfully if a write error occurred on stdout. (Bug#9574)
617
3341db62
EZ
6182011-09-21 Eli Zaretskii <eliz@gnu.org>
619
620 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
621 the xassert test.
622
623 * dispextern.h (struct it): Update the comment documenting what
624 can it->OBJECT be.
625
8c203dbf
EZ
6262011-09-20 Eli Zaretskii <eliz@gnu.org>
627
628 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
629 a display string, extend search for cursor position to end of row.
630 (find_row_edges): If the row ends in a newline from a display
631 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
632 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
633 (Fcurrent_bidi_paragraph_direction): Fix search for previous
634 non-empty line. Fixes confusing cursor motion with arrow keys at
635 the beginning of a line that starts with whitespace.
8c203dbf 636
a4824228
LMI
6372011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
638
639 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
640 (bug#9493).
641
33ed493b
CY
6422011-09-18 Chong Yidong <cyd@stupidchicken.com>
643
644 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
645 boolean (Bug#9154).
646
56cd55c8
EZ
6472011-09-18 Eli Zaretskii <eliz@gnu.org>
648
649 * xdisp.c (display_line): Record maximum and minimum buffer
650 positions even if no glyphs were produced (e.g., by a zero-width
651 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
652 buffer positions that will be removed from the glyph row because
653 they don't fit.
c02dcedf
EZ
654 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
655 column is beyond frame width: don't subtract 1 "pixel" when
656 computing width of the stretch.
3e62b7e0
EZ
657 (reseat_at_next_visible_line_start): Undo the change made on
658 2011-09-17 that saved paragraph information and restored it after
659 the call to `reseat'. (Bug#9545)
56cd55c8 660
5ed99d36 6612011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
662
663 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
664 and turn window cursor on if cleared (Bug#9415).
665
5ed99d36 6662011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
667
668 * search.c (boyer_moore): Take unibyte characters from pattern
669 literally. (Bug#9458)
670
9bade7b2
EZ
6712011-09-18 Eli Zaretskii <eliz@gnu.org>
672
673 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
674
e5e9d610
PE
6752011-09-18 Paul Eggert <eggert@cs.ucla.edu>
676
87e4427a
PE
677 Fix minor problem found by static checking.
678 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
679 initialized, to pacify gcc -Wuninitialized.
680
e5e9d610
PE
681 * fileio.c: Report proper errno when syscall falls.
682 (Finsert_file_contents): Save and restore errno,
683 so that report_file_error outputs the correct diagnostic.
684 (Fwrite_region) [CLASH_DETECTION]: Likewise.
685
a1674f0b
EZ
6862011-09-18 Eli Zaretskii <eliz@gnu.org>
687
688 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
689
fbfb6dd4
EZ
6902011-09-17 Eli Zaretskii <eliz@gnu.org>
691
692 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
693 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
694
bb187662
EZ
6952011-09-17 Eli Zaretskii <eliz@gnu.org>
696
1137e8b8 697 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 698 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
699
700 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
701 (bidi_find_paragraph_start): Search back for paragraph beginning
702 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
703 (bidi_move_to_visually_next): Only trigger paragraph-related
704 computations when the last character is a newline or at EOB, not
705 just any NEUTRAL_B. (Bug#9470)
706
bb187662
EZ
707 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
708 truncated lines if point is covered by a display string. (Bug#9524)
709
2e621251
PE
7102011-09-16 Paul Eggert <eggert@cs.ucla.edu>
711
712 * xselect.c: Relax test for outgoing X longs (Bug#9498).
713 (cons_to_x_long): New function.
714 (lisp_data_to_selection_data): Use it. Correct the test for
715 short-versus-long data; it was negated. Break out of vector
716 loop, for efficiency, when a long datum is discovered.
717
91a15bc6
SM
7182011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
719
720 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
721
b41c3a35
EZ
7222011-09-16 Eli Zaretskii <eliz@gnu.org>
723
724 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
725 GCC PR/17406) by declaring this function with external scope.
726
7812ba2d
PE
7272011-09-15 Paul Eggert <eggert@cs.ucla.edu>
728
729 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
730 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
731
cf7edc2a
AS
7322011-09-15 Andreas Schwab <schwab@linux-m68k.org>
733
734 * editfns.c (Fformat): Correctly handle text properties on "%%".
735
bd01620e
EZ
7362011-09-15 Eli Zaretskii <eliz@gnu.org>
737
738 * xterm.c (x_draw_composite_glyph_string_foreground):
739 * w32term.c (x_draw_composite_glyph_string_foreground):
740 * term.c (encode_terminal_code):
741 * composite.c (composition_update_it, get_composition_id):
742 * xdisp.c (get_next_display_element)
743 (fill_composite_glyph_string): Add comments about special meaning
744 of TAB characters in a composition.
745
a02719a3
PE
7462011-09-15 Paul Eggert <eggert@cs.ucla.edu>
747
748 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
749 This occurs when processing a multibyte format.
750 Problem reported by Wolfgang Jenker.
a02719a3 751
72589a3c
JB
7522011-09-15 Johan Bockgård <bojohan@gnu.org>
753
754 * xdisp.c (try_cursor_movement): Only check for exact match if
755 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
756
1c14176c
PE
7572011-09-14 Paul Eggert <eggert@cs.ucla.edu>
758
759 Remove unused external symbols.
760 * dispextern.h (calc_pixel_width_or_height): Remove decl.
761 * xdisp.c (calc_pixel_width_or_height): Now static.
762 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
763 * indent.c (check_display_width):
764 * w32term.c: Fix comment to match code.
765 * xterm.c, xterm.h (x_catching_errors): Remove.
766
d2eea5b5
PE
7672011-09-14 Paul Eggert <eggert@cs.ucla.edu>
768
769 * xselect.c: Use signed conversions more consistently (Bug#9498).
770 (selection_data_to_lisp_data): Assume incoming selection data are
771 signed integers, not unsigned. This is to be consistent with
772 outgoing selection data, which was modified to use signed integers
773 in as part of the fix to Bug#9196 in response to Jan D.'s comment
774 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
775 expects long, not unsigned long.
776
46888499
EZ
7772011-09-14 Eli Zaretskii <eliz@gnu.org>
778
779 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
780 computation of loop end. Reported by Johan Bockgård
781 <bojohan@gnu.org>.
782
ef8ef9fb
CY
7832011-09-13 Chong Yidong <cyd@stupidchicken.com>
784
785 * frame.c (Fother_visible_frames_p): Function deleted.
786
fa819fed
EZ
7872011-09-12 Eli Zaretskii <eliz@gnu.org>
788
789 * indent.c (compute_motion): Process display vector front to back
790 rather than the other way around. (Bug#2496)
791
2ba8e008
SM
7922011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
793
794 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
795
20f53c69
CY
7962011-09-11 Chong Yidong <cyd@stupidchicken.com>
797
798 * minibuf.c (Fread_from_minibuffer): Doc fix.
799
d562d7a4
EZ
8002011-09-11 Eli Zaretskii <eliz@gnu.org>
801
802 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
803 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
804
1c4d7f3d
LMI
8052011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
806
807 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
808 value for non-existent files.
809
b885bf36
EZ
8102011-09-11 Eli Zaretskii <eliz@gnu.org>
811
812 * fileio.c (Finsert_file_contents): If the file cannot be opened,
813 set its "size" to -1. This will set the modtime_size field of
814 the corresponding buffer to -1, which is what
815 verify-visited-file-modtime expects for files that do not exist.
816 (Bug#9139)
817
6612f0bf
PE
8182011-09-11 Paul Eggert <eggert@cs.ucla.edu>
819
820 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
821 here ...
822 * lisp.h: ... from here. push_key_description is no longer
823 defined in keyboard.c, so its declaration should not be in
824 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
825 logically belongs with push_key_description.
826
dfb3f755
PE
8272011-09-10 Paul Eggert <eggert@cs.ucla.edu>
828
829 * buffer.h: Include <sys/types.h> instead of <time.h>.
830 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
831 Problem reported by Herbert J. Skuhra.
832
3134906c
LMI
8332011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
834
835 * xml.c (parse_region): Make the parsing work for
836 non-comment-starting XML files again (bug#9144).
837
8d903f4e
AS
8382011-09-10 Andreas Schwab <schwab@linux-m68k.org>
839
840 * image.c (gif_load): Fix calculation of bottom and right corner.
841 (Bug#9468)
842
80ad64f4
EZ
8432011-09-10 Eli Zaretskii <eliz@gnu.org>
844
845 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
846 redisplay in small windows.
847
208a048d
EZ
8482011-09-09 Eli Zaretskii <eliz@gnu.org>
849
850 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
851
9b1c252e
MR
8522011-09-08 Martin Rudalics <rudalics@gmx.at>
853
854 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
855 Operate on live windows only.
856
2949f33b
JB
8572011-09-08 Juanma Barranquero <lekktu@gmail.com>
858
859 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
860
e08dcafd
EZ
8612011-09-07 Eli Zaretskii <eliz@gnu.org>
862
863 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
864 only under bidi iteration.
865
115b96bd
JD
8662011-09-07 Jan Djärv <jan.h.d@swipnet.se>
867
868 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
869
c8199d0f
PE
8702011-09-06 Paul Eggert <eggert@cs.ucla.edu>
871
872 isnan: Fix porting problem to Solaris 10 with bundled gcc.
873 Without this fix, the command to link temacs failed due to an
874 undefined symbol __builtin_isnan. This is because
875 /usr/include/iso/math_c99.h #defines isnan(x) to
876 __builtin_isnan(x), but the bundled gcc, which identifies itself
877 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
878 a __builtin_isnan.
879 * floatfns.c (isnan): #undef, and then #define to a clone of
880 what's in data.c.
881 (Fisnan): Always define, since it's always available now.
882 (syms_of_floatfns): Always define isnan at the Lisp level.
883
e39b275c 8842011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
885
886 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
887
b2db44d9 8882011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 889
f4af5137 890 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
891 The previous code assumed that file offsets (off_t values) fit in
892 EMACS_INT variables, which is not true on typical 32-bit hosts.
893 The code messed up by falsely reporting buffer overflow in cases
894 such as (insert-file-contents "big" nil 1 2) into an empty buffer
895 when "big" contains more than 2**29 bytes, even though this
896 inserts just one byte and does not overflow the buffer.
897 (Finsert_file_contents): Store file offsets as off_t
898 values, not as EMACS_INT values. Check for overflow when
899 converting between EMACS_INT and off_t. When checking for
900 buffer overflow or for overlap, take the offsets into account.
901 Don't use EMACS_INT for small values where int suffices.
902 When checking for overlap, fix a typo: ZV was used where
903 ZV_BYTE was intended.
904 (Fwrite_region): Don't assume off_t fits into 'long'.
905 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
906
ecfc0a49
MA
9072011-09-05 Michael Albinus <michael.albinus@gmx.de>
908
909 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
910
6511acf2 9112011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 912
0999621a 913 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
914
915 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 916 (esprintf, exprintf, evxprintf): New functions.
62f19c19 917 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 918 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
919 (modify_event_symbol): Do not assume that the length of
920 name_alist_or_stem is safe to alloca and fits in int.
921 (Fexecute_extended_command): Likewise for function name and binding.
922 (Frecursion_depth): Wrap around reliably on integer overflow.
923 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
924 since some callers pass EMACS_INT values.
925 (Fsingle_key_description): Don't crash if symbol name contains more
926 than MAX_ALLOCA bytes.
927 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
928 (get_minibuffer): Arg is now EMACS_INT, not int.
929 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 930 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
931 * window.h (command_loop_level, minibuf_level): Reflect API changes.
932
2be7d702
PE
933 * dbusbind.c (signature_cat): New function.
934 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
935 Do not overrun buffer; instead, report string overflow.
936
9d1df220
PE
937 * dispnew.c (add_window_display_history): Don't overrun buffer.
938 Truncate instead; this is OK since it's just a log.
939
33ef5c64
PE
940 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
941 even if the time zone offset is outlandishly large.
942 Don't mishandle offset == INT_MIN.
943
66c6fdd5
PE
944 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
945 when creating daemon; the previous buffer-overflow check was incorrect.
946
d749b01b
PE
947 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
948 which has the guts of the old verror function.
949
b5cd1905
PE
950 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
951 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
952
6e1a67fb
PE
953 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
954 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 955 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 956 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
957 length of string rather than counting it via multiple sprintfs;
958 that's simpler and more reliable.
c21721cc
PE
959 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
960 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
961 sprintf, in case result does not fit in int.
962
c57b67fc
PE
963 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
964 (fontset_from_font): Print it.
965
8a401434
PE
966 * frame.c (tty_frame_count): Now printmax_t, not int.
967 (make_terminal_frame, set_term_frame_name): Print it.
968 (x_report_frame_params): In X, window IDs are unsigned long,
969 not signed long, so print them as unsigned.
970 (validate_x_resource_name): Check for implausibly long names,
971 and don't assume name length fits in 'int'.
972 (x_get_resource_string): Don't blindly alloca invocation name;
973 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
974 not fit in int.
975
6e1a67fb
PE
976 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
977 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
978 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
979
0df02bf3
PE
980 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
981 Use esprintf, not sprintf, in case result does not fit in int.
982
48e30793
PE
983 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
984 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
985 it as a large positive number.
986 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
987 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
988
a66ff6d8
PE
989 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
990 in case result does not fit in int.
991
aca216ff
PE
992 * print.c (float_to_string): Detect width overflow more reliably.
993 (print_object): Make sprintf buffer a bit bigger, to avoid potential
994 buffer overrun. Don't assume list length fits in 'int'. Treat
995 print length of 0 as 0, not as infinity; to be consistent with other
996 uses of print length in this function. Don't overflow print length
997 index. Don't assume hash table size fits in 'long', or that
998 vectorlike size fits in 'unsigned long'.
999
31c286f7
PE
1000 * process.c (make_process): Use printmax_t, not int, to format
1001 process-name gensyms.
1002
55e5faa1
PE
1003 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1004
80f2e268
PE
1005 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1006 to avoid potential buffer overrun.
1007
670741ab
PE
1008 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1009 if X resource line is longer than 512 bytes.
1010
b7163a50
PE
1011 * xfns.c (x_window): Make sprintf buffer a bit bigger
1012 to avoid potential buffer overrun.
1013
ae58ff1f
PE
1014 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1015
c43c8a6a
PE
1016 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1017
3f8236f4
PE
10182011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1019
53e9fe90 1020 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1021 Without these, Emacs silently mishandles large integers sometimes.
1022 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1023 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1024
6511acf2
PE
1025 * xdisp.c (try_window_id): Check Emacs fixnum range before
1026 converting to 'int'.
806add1d 1027
6511acf2 1028 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1029 Check that an Emacs fixnum is in range before assigning it to 'int'.
1030 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1031 values converted from Emacs fixnums.
1032 (Frecenter): Don't wrap around a line count if it is out of 'int'
1033 range; instead, treat it as an extreme value.
1034 (Fset_window_configuration, compare_window_configurations):
1035 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1036
6511acf2
PE
1037 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1038 that can exceed INT_MAX. Check that EMACS_INT value is in range
1039 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1040 (match_limit): Don't assume that a fixnum can fit in 'int'.
1041
6511acf2 1042 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1043 exceed INT_MAX.
1044
6511acf2 1045 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1046 (Fvertical_motion): Don't wrap around LINES values that don't fit
1047 in 'int'. Instead, treat them as extreme values. This is good
1048 enough for windows, which can't have more than INT_MAX lines anyway.
1049
fcb901a7
LMI
10502011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1051
0f2f6b6d
LMI
1052 * Require libxml/parser.h to avoid compilation warning.
1053
fcb901a7
LMI
1054 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1055
1056 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1057 since this reportedly can destroy thread storage.
1058
6e20a0d4
CY
10592011-08-30 Chong Yidong <cyd@stupidchicken.com>
1060
1061 * syntax.c (find_defun_start): Update all cache variables if
1062 exiting early (Bug#9401).
1063
148ae00e
EZ
10642011-08-30 Eli Zaretskii <eliz@gnu.org>
1065
f6cfbd8f
EZ
1066 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1067
148ae00e
EZ
1068 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1069 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1070 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1071
1072 * term.c (tty_append_glyph): New function.
1073 (produce_stretch_glyph): Static function and its prototype deleted.
1074
a66cfb1c
SM
1075 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1076 Add prototypes.
148ae00e 1077
c4a07a4c
PE
10782011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1079
1080 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1081 when checking :margin (Bug#9390).
1082 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1083 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1084 so that the name doesn't mislead. All uses changed.
1085
6bc8cd65
JB
10862011-08-28 Johan Bockgård <bojohan@gnu.org>
1087
1088 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1089 set_tty_hooks.
1090
dca4927e
EZ
10912011-08-27 Eli Zaretskii <eliz@gnu.org>
1092
1093 * xdisp.c (move_it_to): Don't bail out early when reaching
1094 position beyond to_charpos, if we are scanning backwards.
1095 (move_it_vertically_backward): When DY == 0, make sure we get to
1096 the first character in the line after the newline.
1097
f2cad773
PE
10982011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1099
1100 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1101 (ccl_driver): Do not generate an out-of-range pointer.
1102 (Fccl_execute_on_string): Remove unnecessary check for
1103 integer overflow, noted by Stefan Monnier in
1104 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1105 Remove a FIXME that didn't need fixing.
1106 Simplify the newly-introduced buffer reallocation code.
1107
0cae2cdb
JB
11082011-08-27 Juanma Barranquero <lekktu@gmail.com>
1109
1110 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1111
5fc295a4 11122011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1113
70c60eb2 1114 Integer and memory overflow issues (Bug#9196).
726e0ab1 1115
d31850da
PE
1116 * doc.c (get_doc_string): Rework so that
1117 get_doc_string_buffer_size is the actual buffer size, rather than
1118 being 1 less than the actual buffer size; this makes xpalloc more
1119 convenient.
1120
a69fbedb
PE
1121 * image.c (x_allocate_bitmap_record, cache_image):
1122 * xselect.c (Fx_register_dnd_atom):
1123 Simplify previous changes by using xpalloc.
1124
fe5c5d37
PE
1125 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1126 since either will do and ptrdiff_t is convenient with xpalloc.
1127
0065d054
PE
1128 * charset.c (charset_table_size)
1129 (struct charset_sort_data.priority): Now ptrdiff_t.
1130 (charset_compare): Don't overflow if priorities differ greatly.
1131 (Fsort_charsets): Don't assume list length fits in int.
1132 Check for size-calculation overflow when allocating sort data.
1133 (syms_of_charset): Allocate an initial charset table that is
1134 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1135
1136 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1137
1138 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1139 The actual value is always <= INT_MAX, and leaving it unsigned made
1140 overflow checking harder.
1141
1142 * dispextern.h (struct glyph_matrix.rows_allocated)
1143 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1144 with xpalloc. The values are still always <= INT_MAX.
1145
1146 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1147
1148 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1149 (SAFE_NALLOCA): New macro.
1150
1151 * region-cache.c (struct boundary.pos, find_cache_boundary)
1152 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1153 (set_cache_region, invalidate_region_cache)
1154 (revalidate_region_cache, know_region_cache, region_cache_forward)
1155 (region_cache_backward, pp_cache):
1156 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1157 so that ptrdiff_t * can be passed to xpalloc.
1158 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1159 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1160 (pp_cache): Don't assume cache_len fits in int.
1161 * region-cache.h: Adjust extern decls to match.
1162
1163 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1164 EMACS_INT, since either will do, for xpalloc.
1165
1166 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1167 (xnmalloc, xnrealloc, xpalloc): New functions.
1168
726e0ab1
PE
1169 * bidi.c (bidi_shelve_header_size): New constant.
1170 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1171 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1172
51f30bc5 1173 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1174 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1175 (overlay_strings):
1176 Don't update size of array until after memory allocation succeeds,
1177 because xmalloc/xrealloc may not return.
0065d054
PE
1178 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1179 now that we have proper integer overflow checking.
1180 (record_overlay_string, overlay_strings): Catch overflows when
1181 calculating size of overlay_str_buf.
726e0ab1 1182
0065d054
PE
1183 * callproc.c (Fcall_process): Check for size overflow when
1184 calculating size of args2.
1185 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1186 Normally we prefer signed values, but sticking with ptrdiff_t would
1187 require adding more-complicated checks.
726e0ab1
PE
1188
1189 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1190 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1191 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1192 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1193
1194 * character.c (Fstring): Check for size-calculation overflow.
1195
1196 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1197 unnecessary integer overflow. Check for size overflow.
1198 (encode_coding_object): Don't update size until xmalloc succeeds.
1199
1200 * composite.c (get_composition_id): Check for overflow in glyph
1201 length calculations.
1202
1203 Integer and memory overflow fixes for display code.
1204 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1205 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1206 (scrolling_window): Check for overflow in size calculations.
1207 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1208 Don't assume glyph table len fits in int.
1209 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1210 (row_table_size): Now ptrdiff_t, not int.
1211 (scrolling_window): Avoid overflow in size calculations.
1212 Don't update size until allocation succeeds.
1213 * fns.c (concat): Check for overflow in size calculations.
1214 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1215 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1216 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1217
1218 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1219 (get_doc_string): Check for size calculation overflow.
1220 Don't update size until allocation succeeds.
1221 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1222 EMACS_INT, where ptrdiff_t will do.
1223 (Fsubstitute_command_keys): Check for string overflow.
1224
1225 * editfns.c (set_time_zone_rule): Don't assume environment length
1226 fits in int.
1227 (message_length): Now ptrdiff_t, not int.
1228 (Fmessage_box): Don't update size until allocation succeeds.
1229 Don't assume message length fits in int.
1230 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1231
0065d054
PE
1232 * emacs.c (main): Do not reallocate argv, since there is a null at
1233 the end that can be overwritten, and this way there's no need to
1234 worry about size-calculation overflow.
1235 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1236
1237 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1238 alloc succeeds.
1239 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1240
1241 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1242 (x_set_scroll_bar_width, x_figure_window_size):
1243 Check for integer overflow.
1244 (x_set_alpha): Do not assume XINT fits in int.
1245
1246 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1247 This is for the members text_lines, text_cols, total_lines, total_cols,
1248 where the system imposes an 'int' limit.
1249
1250 * fringe.c (Fdefine_fringe_bitmap):
1251 Don't update size until alloc works.
1252
1253 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1254 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1255
1256 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1257 Check for size-calculation overflow.
1258 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1259 do, as we prefer signed integers.
1260 (id_to_widget.max_size, id_to_widget.used)
1261 (xg_store_widget_in_map, xg_remove_widget_from_map)
1262 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1263 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1264 Use and return ptrdiff_t, not int.
1265 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1266 * gtkutil.h: Change prototypes to match the above.
1267
1268 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1269 are duplicate now that they've been promoted to lisp.h.
1270 (x_allocate_bitmap_record, x_alloc_image_color)
1271 (make_image_cache, cache_image, xpm_load):
1272 Don't update size until alloc is done.
1273 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1274 (x_detect_edges):
3256efce 1275 Check for size calculation overflow.
726e0ab1
PE
1276 (ct_colors_allocated_max): New constant.
1277 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1278 overflow.
3256efce 1279
726e0ab1
PE
1280 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1281 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1282 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1283 Use ptrdiff_t, not int, to count maps.
1284 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1285 calculations. Don't update size until allocation succeeds.
1286 Redo calculations to avoid overflow.
726e0ab1
PE
1287 * keyboard.h: Change prototypes to match the above.
1288
1289 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1290 to count maps.
1291 (current_minor_maps): Check for size calculation overflow.
1292 * keymap.h: Change prototypes to match the above.
1293
1294 * lread.c (read1, init_obarray): Don't update size until alloc done.
1295
1296 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1297 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1298
726e0ab1
PE
1299 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1300 Now ptrdiff_t, not int.
1301 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1302 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1303
1304 * process.c (Fnetwork_interface_list): Check for overflow
1305 in size calculation.
1306
1307 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1308
1309 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1310 overflow. Don't bother calling xmalloc when xrealloc will do.
1311
1312 * search.c (Freplace_match): Check for size calculation overflow.
1313 (Fset_match_data): Don't assume list lengths fit in 'int'.
1314
1315 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1316 for command line length. Do not attempt to address one before the
1317 beginning of an array, as that's not portable.
1318
1319 * term.c (max_frame_lines): Remove; unused.
1320 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1321 not int.
1322 (encode_terminal_code, calculate_costs): Check for size
1323 calculation overflow.
1324 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1325 table lengths and related sizes. Don't update size until alloc
1326 done. Redo calculations to avoid overflow.
1327 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1328
1329 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1330 subtracting pointers.
1331 (gobble_line): Check for overflow more carefully. Don't update size
1332 until alloc done.
1333
1334 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1335 Don't update size until alloc done.
1336 Redo size calculations to avoid overflow.
1337 Check for size calculation overflow.
0065d054 1338 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1339
1340 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1341 Use ptrdiff_t, not int, for sizes.
1342 (store_mode_line_noprop_char): Don't update size until alloc done.
1343
0065d054
PE
1344 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1345 Use ptrdiff_t, not int, for sizes.
1346 (Finternal_make_lisp_face, cache_face):
1347 Check for size calculation overflow.
1348 (cache_face): Treat size calculation overflows as if they were
1349 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1350
1351 * xfns.c (x_encode_text, x_set_name_internal)
1352 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1353 sizes, since they can exceed INT_MAX in size. Check for size
1354 calculation overflow.
1355
0065d054
PE
1356 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1357 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1358 Don't update size until alloc done.
1359
0065d054 1360 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1361 as sprintf is limited to int lengths.
1d526e2f 1362
252c5ee1
PE
1363 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1364 (X_LONG_MIN): New macros.
864d7ce7
PE
1365 Use them to make the following changes clearer.
1366 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1367 This change doesn't affect the value now, but it may help remind
1368 future maintainers not to raise the value too much later.
1369 (SELECTION_QUANTUM): Remove, replacing with ...
1370 (selection_quantum): ... new function, which avoids overflow.
1371 All uses changed.
1372 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1373 assumption that selection length fits in 'int'.
1374 (x_reply_selection_request, x_handle_selection_request)
1375 (x_get_window_property, receive_incremental_selection)
1376 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1377 (lisp_data_to_selection_data, clean_local_selection_data):
1378 Use ptrdiff_t, not int, to record length of selection.
1379 (x_reply_selection_request, x_get_window_property)
1380 (receive_incremental_selection, x_property_data_to_lisp):
1381 Redo calculations to avoid overflow.
1382 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1383 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1384 something.
1385 (x_get_window_property, receive_incremental_selection)
1386 (lisp_data_to_selection_data, x_property_data_to_lisp):
1387 Check for size-calculation overflow.
1388 (x_get_window_property, receive_incremental_selection)
1389 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1390 Don't store size until memory allocation succeeds.
1391 (x_get_window_property): Plug memory leak on memory exhaustion.
1392 Don't double-block input; malloc is safe here. Don't assume 2**34
1393 - 4 fits in unsigned long. Add an xassert to check
1394 XGetWindowProperty overflow. Be more careful about overflow
1395 calculations, and distinguish size from memory overflow better.
1396 (receive_incremental_selection): When tracing, don't assume
1397 unsigned int is less than INT_MAX.
1398 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1399 harmful) conversions of unsigned short to int.
1400 (lisp_data_to_selection_data): Don't assume that integers
1401 in the range -65535 through -1 fit in an X unsigned short.
1402 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1403 result parameters unless successful. Rely on cons_to_unsigned
1404 to report problems with elements; the old code wasn't right anyway.
1405 (x_check_property_data): Check for int overflow; we cannot use
1406 a wider type due to X limits.
1407 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1408
726e0ab1 1409 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1410
0065d054
PE
1411 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1412 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1413 (x_color_cells): Don't store size until memory allocation succeeds.
1414 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1415 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1416 (x_term_init): Don't assume length fits in int (sprintf is limited
1417 to int size).
bc18e09d 1418
ebfa62c0
PE
1419 Use ptrdiff_t for composition IDs.
1420 * character.c (lisp_string_width):
1421 * composite.c (composition_table_size, n_compositions)
1422 (get_composition_id, composition_gstring_from_id):
1423 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1424 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1425 * window.c (Frecenter):
1426 Use ptrdiff_t, not int, for composition IDs.
1427 * composite.c (get_composition_id): Check for integer overflow.
1428 * composite.h: Adjust prototypes to match the above changes.
1429
d3411f89
PE
1430 Use ptrdiff_t for hash table indexes.
1431 * category.c (hash_get_category_set):
1432 * ccl.c (ccl_driver):
1433 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1434 * coding.c (coding_system_charset_list, detect_coding_system):
1435 * coding.h (struct coding_system.id):
1436 * composite.c (get_composition_id, gstring_lookup_cache):
1437 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1438 * image.c (xpm_get_color_table_h):
1439 * lisp.h (hash_lookup, hash_put):
1440 * minibuf.c (Ftest_completion):
1441 Use ptrdiff_t for hash table indexes, not int (which is too
1442 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1443 32-bit --with-wide-int hosts).
1444
e097a6fa
PE
1445 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1446 Add a FIXME comment about memory leaks.
1447 (syms_of_charset): Don't assume xmalloc returns.
1448
5637687f
PE
1449 Don't assume that stated character widths fit in int.
1450 * character.c (Fchar_width, c_string_width, lisp_string_width):
1451 * character.h (CHAR_WIDTH):
1452 * indent.c (MULTIBYTE_BYTES_WIDTH):
1453 Use sanitize_char_width to avoid undefined and/or bad behavior
1454 with outlandish widths.
a66cfb1c 1455 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1456 now that we have two such functions. All uses changed.
1457 (sanitize_char_width): New inline function.
1458
a2271ba2
PE
1459 Don't assume that tab-width fits in int.
1460 * character.h (sanitize_width): New inline function.
1461 (SANE_TAB_WIDTH): New macro.
1462 (ASCII_CHAR_WIDTH): Use it.
1463 * indent.c (sane_tab_width): Remove. All uses replaced by
1464 SANE_TAB_WIDTH (current_buffer).
1465 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1466
18c52557
PE
1467 * fileio.c: Integer overflow issues with file modes.
1468 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1469
caeeedc1
PE
1470 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1471 Remove unreachable code.
1472 (read_hex, load_charset_map_from_file): Check for integer overflow.
1473
50849c52
PE
1474 * xterm.c: don't go over XClientMessageEvent limit
1475 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1476 (x_send_scroll_bar_event): Likewise. Check that the size does not
1477 exceed limits imposed by XClientMessageEvent, as well as the usual
1478 ptrdiff_t and size_t limits.
1479
b13995db
PE
1480 * keyboard.c: Overflow, signedness and related fixes.
1481 (make_lispy_movement): Use same integer type in forward decl
1482 that is used in the definition.
1483 (read_key_sequence, keyremap_step):
1484 Change bufsize argument back to int, undoing my 2011-03-30 change.
1485 We prefer signed types, and int is wide enough here.
1486 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1487 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1488 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1489 length, not size_t. Use ptrdiff_t for index, not int.
1490 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1491 possibility of integer overflow.
1492
13464394
PE
1493 Overflow, signedness and related fixes for images.
1494
1495 * dispextern.h (struct it.stack[0].u.image.image_id)
1496 (struct_it.image_id, struct image.id, struct image_cache.size)
1497 (struct image_cache.used, struct image_cache.ref_count):
1498 * gtkutil.c (update_frame_tool_bar):
1499 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1500 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1501 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1502 * nsmenu.m (update_frame_tool_bar):
1503 * xdisp.c (calc_pixel_width_or_height):
1504 * xfns.c (image_cache_refcount):
1505 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1506 on typical 64-bit hosts.
1507
1508 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1509 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1510 Omit unnecessary casts to int.
1511 (parse_image_spec): Check that integers fall into 'int' range
1512 when the callers expect that.
1513 (image_ascent): Redo ascent calculation to avoid int overflow.
1514 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1515 (lookup_image): Remove unnecessary tests.
1516 (xbm_image_p): Locals are now of int, not EMACS_INT,
1517 since parse_image_check makes sure they fit into int.
1518 (png_load, gif_load, svg_load_image):
1519 Prefer int to unsigned where either will do.
1520 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1521 old tiff_error_handler and tiff_warning_handler.
1522 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1523 stack buffer overflows. It uses only the features of vsnprintf
1524 that are common to both POSIX and native Microsoft.
1525 (tiff_error_handler, tiff_warning_handler): Use it.
1526 (tiff_load, gif_load, imagemagick_load_image):
1527 Don't assume :index value fits in 'int'.
1528 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1529 (imagemagick_load_image): Check that crop parameters fit into
1530 the integer types that MagickCropImage accepts. Don't assume
1531 Vimagemagick_render_type has a nonnegative value. Don't assume
1532 size_t fits in 'long'.
1533 (gs_load): Use printmax_t to print the widest integers possible.
1534 Check for integer overflow when computing image height and width.
1535
c11821d4
EZ
15362011-08-26 Eli Zaretskii <eliz@gnu.org>
1537
1538 * xdisp.c (redisplay_window): Don't force window start if point
1539 will be invisible in the resulting window. (Bug#9324)
1540
0c95fcf7
EZ
15412011-08-25 Eli Zaretskii <eliz@gnu.org>
1542
1543 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1544 the display spec is of the form `(space ...)'.
1545 (handle_display_spec): Return the value returned by
1546 handle_single_display_spec, not just 1 or zero.
1547 (handle_single_display_spec): If the display spec is of the form
1548 `(space ...)', and specifies display in the text area, return 2
1549 rather than 1.
fee65a97 1550 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1551 accurately, and prefer exact match for point under bidi.
1552 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1553
1554 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1555 into disp_prop; all users changed.
1556
1557 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1558 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1559 for the text covered by the display property.
1560
e4ed06f1
CY
15612011-08-25 Chong Yidong <cyd@stupidchicken.com>
1562
1563 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1564 Change return value to nil.
1565 (Frecord_buffer): Delete unused function.
1566
f67cdd7f
EZ
15672011-08-24 Eli Zaretskii <eliz@gnu.org>
1568
5980d4c6
EZ
1569 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1570 buffers, return left-to-right.
8610fe8b
EZ
1571 (set_cursor_from_row): Consider candidate row a win if its glyph
1572 represents a newline and point is on that newline. Fixes cursor
1573 positioning on the newline at EOL of R2L text within L2R
1574 paragraph, and vice versa.
1575 (try_cursor_movement): Check continued rows, in addition to
1576 continuation rows. Fixes unwarranted scroll when point enters a
1577 continued line of R2L text within an L2R paragraph, or vice versa.
1578 (cursor_row_p): Consider the case of point being equal to
1579 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1580 from the end of a short line to the beginning of a continued line
1581 of R2L text within L2R paragraph.
1582 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1583 composed characters.
5980d4c6 1584
f67cdd7f
EZ
1585 * bidi.c (bidi_check_type): Use xassert.
1586 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1587 members.
1588
bca633fb
EZ
15892011-08-23 Eli Zaretskii <eliz@gnu.org>
1590
1591 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1592 a character.
1593
4a5885a7
CY
15942011-08-23 Chong Yidong <cyd@stupidchicken.com>
1595
1596 * nsfont.m (ns_otf_to_script): Fix typo.
1597
0902a04e
KH
15982011-08-22 Kenichi Handa <handa@m17n.org>
1599
1600 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1601 extra slot even if the purpose is char-code-property-table.
1602
1a2e6670
EZ
16032011-08-23 Eli Zaretskii <eliz@gnu.org>
1604
8ddde651
EZ
1605 * xdisp.c (redisplay_window): When computing centering_position,
1606 account for the height of the header line. (Bug#8874)
1607
425cc014
EZ
1608 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1609 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1610 candidate is selected by the mouse, and that candidate has a
1611 composed character under the mouse.
1612
1a2e6670
EZ
1613 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1614 coordinates reported by pos-visible-in-window-p for a composed
1615 character in column zero.
1616
8b76d6f8
SM
16172011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1618
1619 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1620
dac347dd
EZ
16212011-08-22 Eli Zaretskii <eliz@gnu.org>
1622
1623 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1624 consider it a hit if to_charpos is anywhere in the range of the
1625 composed buffer positions.
1626
e013fb34
CY
16272011-08-22 Chong Yidong <cyd@stupidchicken.com>
1628
1629 * image.c (gif_load): Don't assume that each subimage has the same
1630 dimensions as the base image. Handle disposal method that is
1631 "undefined" by the gif spec (Bug#9335).
1632
bd1ba3e8
CY
16332011-08-20 Chong Yidong <cyd@stupidchicken.com>
1634
1635 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1636 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1637
54a1215b
EZ
16382011-08-19 Eli Zaretskii <eliz@gnu.org>
1639
823564e5
EZ
1640 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1641 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1642 from an Org mode buffer to a Speedbar frame.
1643
54a1215b
EZ
1644 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1645 a composition, take its buffer position from IT->cmp_it.charpos.
1646 Fixes cursor positioning at the beginning of a line that begins
1647 with a composed character.
1648
9778ebcc
EZ
16492011-08-18 Eli Zaretskii <eliz@gnu.org>
1650
0be6ee06
EZ
1651 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1652 character bidirectional type, use STRONG_L instead. Fixes crashes
1653 in a buffer produced by `describe-categories'.
1654
9778ebcc
EZ
1655 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1656 members before the level stack, so they would be saved and
1657 restored when copying iterator state. Fixes incorrect reordering
1658 around TABs covered by display properties.
1659
156bffbe
AS
16602011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1661
6b02f655 1662 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1663
72ad093b
CY
16642011-08-17 Chong Yidong <cyd@stupidchicken.com>
1665
1666 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1667 (internal_condition_case_2, internal_condition_case_n):
1668 Remove unnecessary aborts (Bug#9081).
72ad093b 1669
35774242
EZ
16702011-08-17 Eli Zaretskii <eliz@gnu.org>
1671
1672 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1673 has no `load' handler, try opening the file locally. (Bug#9311)
1674
db76dd85
KB
16752011-08-16 Ken Brown <kbrown@cornell.edu>
1676
1677 * gmalloc.c: Expand comment.
1678
b215eee5
EZ
16792011-08-16 Eli Zaretskii <eliz@gnu.org>
1680
1681 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1682 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1683
a4579d33
KB
16842011-08-16 Ken Brown <kbrown@cornell.edu>
1685
1686 Fix memory allocation problems in Cygwin build (Bug#9273).
1687
1688 * unexcw.c ( __malloc_initialized): Declare external variable.
1689 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1690
8b76d6f8
SM
1691 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1692 New variables.
a4579d33
KB
1693 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1694 dumped emacs.
1695 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1696 in the static heap.
1697 [CYGWIN] (special_realloc): New function.
1698 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1699 requests to realloc storage in the static heap.
1700
3ebec551
PE
17012011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1702
1703 * bidi.c (bidi_initialize): Remove unused local.
1704
9fd8be00
EZ
17052011-08-15 Eli Zaretskii <eliz@gnu.org>
1706
6b02f655
SM
1707 * bidimirror.h:
1708 * biditype.h: Remove file.
1709 * makefile.w32-in ($(BLD)/bidi.$(O)):
1710 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1711
1712 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1713
1714 * chartab.c: Improve commentary for the uniprop_table API.
1715
32413314
EZ
1716 * bidi.c (bidi_paragraph_init): Support zero value of
1717 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1718 (bidi_initialize): Use uniprop_table instead of including
1719 biditype.h and bidimirror.h.
32413314 1720
9fd8be00
EZ
1721 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1722 coordinates of the iterator when restoring from ppos_it.
1723 (Bug#9296)
1724
5cf2b69b
KH
17252011-08-14 Kenichi Handa <handa@m17n.org>
1726
1727 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1728 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1729
daf17d00
EZ
17302011-08-14 Eli Zaretskii <eliz@gnu.org>
1731
1732 * xdisp.c (move_it_in_display_line_to): Don't invoke
1733 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1734 ppos_it. Fixes vertical cursor motion when line beginning is
1735 covered by an image. (Bug#9296)
1736
08e3161a
JD
17372011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1738
1739 * nsterm.h (ns_run_ascript): Declare.
1740 (NSAPP_DATA2_RUNASSCRIPT): Define.
1741
1742 * nsfns.m (as_script, as_result, as_status): New static variables.
1743 (ns_run_ascript): New function.
5e617bc2 1744 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1745 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1746 the event loop. Get status from as_status (Bug#7276).
1747
1748 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1749 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1750 the event loop (Bug#7276).
1751
a3720aa2
AS
17522011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1753
1754 * gnutls.c (QCgnutls_bootprop_priority)
1755 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1756 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1757 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1758 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1759 (QCgnutls_bootprop_verify_hostname_error)
1760 (QCgnutls_bootprop_callbacks_verify): Rename from
1761 Qgnutls_bootprop_..., all uses changed.
1762
1763 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1764 uses changed.
1765
0a0d27fb
PE
17662011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1767
19d5c50c
PE
1768 * xfaces.c (Qframe_set_background_mode): Now static.
1769 * dispextern.h (Qframe_set_background_mode): Remove decl.
1770
0a0d27fb
PE
1771 * process.c (Fnetwork_interface_info): Declare local only if needed.
1772
377538cb
JD
17732011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1774
1775 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1776 (Fnetwork_interface_list): Allocate in increments of bytes instead
1777 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1778 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1779 sockaddr.
1780 (struct ifflag_def): notrailers is smart on OSX.
1781 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1782 Get hardware address with getifaddrs if available.
1783
08fff70c
EZ
17842011-08-12 Eli Zaretskii <eliz@gnu.org>
1785
1786 * xdisp.c (iterate_out_of_display_property): xassert that
1787 IT->position is set to within IT->object's boundaries. Break from
1788 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1789 when IT->position is set up wrongly due to some bug.
1790 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1791 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1792 entry. Force push_it to save on the stack the current
1793 buffer/string position, to be restored by pop_it. Fix flags in
1794 the iterator structure wrt the object coming from a display
1795 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1796 properties. (Bug#9284)
1797
7be1c708 17982011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1799
7be1c708
CY
1800 * fontset.c (fontset_get_font_group): Add proper type checks.
1801 (Bug#9172)
aac0c6e3 1802
7be1c708 18032011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1804
7be1c708
CY
1805 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1806 and LC_VERSION_MIN_MACOSX.
1807 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1808 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1809
97bb72a6
EZ
18102011-08-08 Eli Zaretskii <eliz@gnu.org>
1811
1812 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1813 no-display-properties-and-no-overlays under bidi display.
1814 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1815 properties and overlays.
97bb72a6 1816
d5617611
CY
18172011-08-08 Chong Yidong <cyd@stupidchicken.com>
1818
37e11a63
CY
1819 * editfns.c (Fset_time_zone_rule): Document relationship with the
1820 setenv function.
1821
d5617611
CY
1822 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1823 the font entity extracted from the cache (Bug#8109).
1824
58872834
CY
18252011-08-07 Chong Yidong <cyd@stupidchicken.com>
1826
1827 * composite.c (autocmp_chars): Don't reset point. That is done by
1828 restore_point_unwind (Bug#5984).
1829
75bfc667
JL
18302011-08-07 Juri Linkov <juri@jurta.org>
1831
1832 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1833 to show the arg `TIME' instead of `TIMEVAL'.
1834
d1410150
EZ
18352011-08-06 Eli Zaretskii <eliz@gnu.org>
1836
1837 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1838 display property strides EOL and includes a newline, as in
1839 longlines-mode. (Bug#9254)
75b771e4
EZ
1840 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1841 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1842
1843 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1844 is non-zero, even if the data buffer is NULL. Fixes a crash in
1845 vertical-motion with longlines-mode. (Bug#9254)
1846
35928349
EZ
18472011-08-05 Eli Zaretskii <eliz@gnu.org>
1848
ec7cc85b
EZ
1849 * bidi.c <bidi_cache_total_alloc>: Now static.
1850 (bidi_initialize): Initialize bidi_cache_total_alloc.
1851
8b76d6f8 1852 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1853 cache. (Bug#9221)
1854
1855 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1856 amount allocated this far in `bidi_cache_total_alloc'.
1857 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1858 non-zero, only free the data buffer without restoring the cache
1859 contents. All callers changed.
1860
1861 * dispextern.h (bidi_unshelve_cache): Update prototype.
1862
1863 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1864 (move_it_in_display_line, move_it_to)
1865 (move_it_vertically_backward, move_it_by_lines): Replace the call
1866 to xfree to an equivalent call to bidi_unshelve_cache.
1867 (move_it_in_display_line_to): Fix logic of returning
412b6358 1868 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1869
e2e2423b
EZ
18702011-08-05 Eli Zaretskii <eliz@gnu.org>
1871
1872 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1873 came from a string character with a `cursor' property. (Bug#9229)
1874
ae9e757a
JD
18752011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1876
1877 * Makefile.in (LIB_PTHREAD): New variable.
1878 (LIBES): Add LIB_PTHREAD (Bug#9216).
1879
1880 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1881 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1882
213bd7f2
AS
18832011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1884
6b02f655 1885 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1886
99aaf75f
JD
18872011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1888
1889 * xterm.c (x_find_topmost_parent): New function.
1890 (x_set_frame_alpha): Find topmost parent window with
1891 x_find_topmost_parent and set the property there also (bug#9181).
1892 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1893
c74e9d86
PE
18942011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1895
1896 * callproc.c (Fcall_process): Avoid vfork clobbering
1897 the local vars buffer, coding_systems, current_dir.
1898
640c8776
SM
18992011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1900
1901 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1902
f26d0e4c
PE
19032011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1904
8a10d76c
PE
1905 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1906 so that it is not optimized away.
1907
f26d0e4c
PE
1908 * xdisp.c (compute_display_string_pos): Remove unused local.
1909
55439c61
EZ
19102011-08-02 Eli Zaretskii <eliz@gnu.org>
1911
1912 Fix slow cursor motion and scrolling in large buffers with
1913 selective display, like Org Mode buffers. (Bug#9218)
1914
1915 * dispextern.h (struct bidi_it): New member disp_prop_p.
1916
1917 * xdisp.c: Remove one-slot cache of display string positions.
1918 (compute_display_string_pos): Accept an additional argument
5e617bc2 1919 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1920 for a display string or property. If found, set DISP_PROP_P
1921 non-zero.
1922
1923 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1924 DISP_PROP_P, and pass it to compute_display_string_pos.
1925 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1926 non-zero. All callers of bidi_fetch_char changed.
1927
fb33fa43
SM
19282011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1929
1930 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1931
b099e063
DM
19322010-12-03 Don March <don@ohspite.net>
1933
1934 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1935 last character M-[char] is translated to ESC [char] (bug#7541).
1936
5cc7f7af
KH
19372011-08-02 Kenichi Handa <handa@m17n.org>
1938
d0fffa3f 1939 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1940
1941 * chartab.c (uniprop_table): Make it non-static.
1942
525d5e6e
EZ
19432011-08-01 Eli Zaretskii <eliz@gnu.org>
1944
1945 * xdisp.c (forward_to_next_line_start): Accept additional argument
1946 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1947 on the newline.
1948 (reseat_at_next_visible_line_start): Use the bidi iterator state
1949 returned by forward_to_next_line_start to restore the state of
1950 it->bidi_it after backing up to previous newline. (Bug#9212)
1951
31011111
AS
19522011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1953
1954 * regex.c (re_comp): Protoize.
1955 (re_exec): Fix return type.
1956 (regexec): Fix type of `ret'. (Bug#9203)
1957
476371c4
PE
19582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1959
e5d76069
PE
1960 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1961 This is needed if max-image-size is a floating-point number.
1962
9a79b20c
AS
19632011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1964
1965 * print.c (print_object): Print empty symbol as ##.
1966
1967 * lread.c (read1): Read ## as empty symbol.
1968
d8c2fa78
AA
19692011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1970
1971 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1972 setting frame foreground color (Bug#9175).
1973 (x_set_background_color): Likewise.
1974
ffe57a7a
AA
1975 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1976 contents (Bug#9176).
1977 (EmacsTooltip -init): Remove bezels and add shadows to
1978 tooltip windows.
1979
bf3492a5
AA
1980 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1981 or scroll bar (Bug#8470).
1982
d55e9c53
AA
1983 * nsfont.m (nsfont_open): Remove assignment to voffset and
1984 unnecessary vars hshink, expand, hd, full_height, min_height.
1985 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1986
1987 * nsterm.h (nsfont_info): Remove voffset field.
1988
d8c2fa78 19892011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1990
1991 Implement strike-through and overline on NextStep (Bug#8863).
1992
1993 * nsfont.m (nsfont_open): Use underline position provided by font,
1994 instead of hard-coded value of 2.
1995 (nsfont_draw): Call ns_draw_text_decoration instead.
1996
1997 * nsterm.h: Add declaration for ns_draw_text_decoration.
1998
1999 * nsterm.m (ns_draw_text_decoration): New function for drawing
2000 underline, overline, and strike-through.
2001 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2002 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2003 accommodate underlining, etc.
4843aac3 2004
4cc60b9b
EZ
20052011-07-28 Eli Zaretskii <eliz@gnu.org>
2006
bc7ece87
EZ
2007 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2008 default.
4cc60b9b 2009
476371c4
PE
20102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2011
66606eea
PE
2012 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2013 Without this fix, if a signal arrives just after memory fills up,
2014 'malloc' might be invoked reentrantly.
2015
476371c4
PE
2016 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2017 In other words, assume that every image size is allowed, on non-X
2018 hosts. This assumption is probably wrong, but it lets Emacs compile.
2019
f3fcc40d
AS
20202011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2021
2022 * regex.c (re_iswctype): Convert return values to boolean.
2023
350c992f
EZ
20242011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2025
2026 * xdisp.c (compute_display_string_pos): Don't use cached display
2027 string position if the buffer had its restriction changed.
2028 (Bug#9184)
2029
5266b4bb
PE
20302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2031
2032 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2033
2573a837 20342011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2035
41f55ccd 2036 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2037
39e378da
PE
2038 * bidi.c: Integer size and overflow fixes.
2039 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2040 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2041 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2042 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2043 (bidi_find_other_level_edge):
2044 Use ptrdiff_t instead of EMACS_INT where either will do.
2045 This works better on 32-bit hosts configured --with-wide-int.
2046 (bidi_cache_ensure_space): Check for size-calculation overflow.
2047 Use % rather than repeated addition, for better worst-case speed.
2048 Don't set bidi_cache_size until after xrealloc returns, because it
2049 might not return.
2050 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2051 (bidi_cache_ensure_space): Also check that the bidi cache size
2052 does not exceed that of the largest Lisp string or buffer. See Eli
2053 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2054
5e927815
PE
2055 * alloc.c (__malloc_size_t): Remove.
2056 All uses replaced by size_t. See Andreas Schwab's note
2057 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2058
ca4aa935
PE
2059 * image.c: Improve checking for integer overflow.
2060 (check_image_size): Assume that f is nonnull, since
2061 it is always nonnull in practice. This is one less thing to
2062 worry about when checking for integer overflow later.
2063 (x_check_image_size): New function, which checks for integer
2064 overflow issues inside X.
2065 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2066 This removes the need for a memory_full check.
2067 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2068 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2069 (xbm_read_bitmap_data): Change locals back to 'int', since
2070 their values must fit in 'int'.
2071 (xpm_load_image, png_load, tiff_load):
2072 Invoke x_create_x_image_and_pixmap earlier,
2073 to avoid much needless work if the image is too large.
2074 (tiff_load): Treat overly large images as if
2075 x_create_x_image_and_pixmap failed, not as malloc failures.
2076 (gs_load): Use x_check_image_size.
2077
5f8f9cc2
PE
2078 * gtkutil.c: Omit integer casts.
2079 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2080 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2081
5adf60bc
PE
2082 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2083
c8907a93
PE
2084 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2085 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2086 would wrongly return t on a 64-bit host.
2087
e3c25c68
PE
2088 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2089 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2090 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2091 and therefore cause GCC to emit a bogus diagnostic in some cases.
2092
3f791afe
PE
2093 * image.c: Integer signedness and overflow and related fixes.
2094 This is not an exhaustive set of fixes, but it's time to
2095 record what I've got.
2096 (lookup_pixel_color, check_image_size): Remove redundant decls.
2097 (check_image_size): Don't assume that arbitrary EMACS_INT values
2098 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2099 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2100 (tiff_load, imagemagick_load_image):
2101 Check for overflow in size calculations.
2102 (x_create_x_image_and_pixmap): Remove unnecessary test for
2103 xmalloc returning NULL; that can't happen.
2104 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2105 (xpm_color_bucket): Use better integer hashing function.
2106 (xpm_cache_color): Don't possibly over-allocate memory.
2107 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2108 (gif_memory_source):
2109 Use ptrdiff_t, not int or size_t, to record sizes.
2110 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2111 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2112 either works, as we prefer signed integers.
2113 (tiff_read_from_memory, tiff_write_from_memory):
2114 Return tsize_t, not size_t, since that's what the TIFF API wants.
2115 (tiff_read_from_memory): Don't fail simply because the read would
2116 go past EOF; instead, return a short read.
2117 (tiff_load): Omit no-longer-needed casts.
2118 (Fimagemagick_types): Don't assume size fits into 'int'.
2119
3cc5a532
PE
2120 Improve hashing quality when configured --with-wide-int.
2121 * fns.c (hash_string): New function, taken from sxhash_string.
2122 Do not discard information about ASCII character case; this
2123 discarding is no longer needed.
2124 (sxhash-string): Use it. Change sig to match it. Caller changed.
2125 * lisp.h: Declare it.
2126 * lread.c (hash_string): Remove, since we now use fns.c's version.
2127 The fns.c version returns a wider integer if --with-wide-int is
2128 specified, so this should help the quality of the hashing a bit.
2129
b312a492
PE
2130 * emacs.c: Integer overflow minor fix.
2131 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2132 Define only if GNU_LINUX.
2133 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2134
dfd153ae
PE
2135 * dispnew.c: Integer signedness and overflow fixes.
2136 Remove unnecessary forward decls, that were a maintenance hassle.
2137 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2138 All uses changed.
2139 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2140 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2141 (prepare_desired_row, line_draw_cost):
2142 Use int, not unsigned, where either works.
2143 (save_current_matrix, restore_current_matrix):
2144 Use ptrdiff_t, not size_t, where either works.
2145 (init_display): Check for overflow more accurately, and without
2146 relying on undefined behavior.
2147
a81d11a3
PE
2148 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2149 Remove, replacing with the new symbols in lisp.h. All uses changed.
2150 * fileio.c (make_temp_name):
2151 * filelock.c (lock_file_1, lock_file):
2152 * xdisp.c (message_dolog):
2153 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2154 Use pMd etc. instead.
2155 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2156 replacing the pWIDE etc. symbols removed from editfns.c.
2157
3300e6fd
PE
2158 * keyboard.h (num_input_events): Now uintmax_t.
2159 This is (very slightly) less likely to mess up due to wraparound.
2160 All uses changed.
2161
fd05c7e9
PE
2162 * buffer.c: Integer signedness fixes.
2163 (alloc_buffer_text, enlarge_buffer_text):
2164 Use ptrdiff_t rather than size_t when either will do, as we prefer
2165 signed integers.
2166
903fe15d
PE
2167 * alloc.c: Integer signedness and overflow fixes.
2168 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2169 (__malloc_size_t): Default to size_t, not to int.
2170 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2171 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2172 Prefer ptrdiff_t to size_t when either would do, as we prefer
2173 signed integers.
2174 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2175 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2176 Now const. Initialize with values that are in range even if char
2177 is signed.
2178 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2179 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2180 These functions do the right thing with sizes > 2**32.
2181 (check_depth): Now ptrdiff_t, not int.
2182 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2183 Adjust to new way of storing sizes. Check for size overflow bugs
2184 in rest of code.
2185 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2186 slightly wrong anyway, as it missed one instance of
2187 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2188 (refill_memory_reserve): Omit needless cast to size_t.
2189 (mark_object_loop_halt): Mark as externally visible.
2190
ac82cc6a
PE
2191 * xselect.c: Integer signedness and overflow fixes.
2192 (Fx_register_dnd_atom, x_handle_dnd_message):
2193 Use ptrdiff_t, not size_t, since we prefer signed.
2194 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2195 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2196 x_dnd_atoms_size and x_dnd_atoms_length.
2197
c2d1e36d
PE
2198 * doprnt.c: Prefer signed to unsigned when either works.
2199 * eval.c (verror):
2200 * doprnt.c (doprnt):
2201 * lisp.h (doprnt):
2202 * xdisp.c (vmessage):
2203 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2204 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2205 prefer signed arithmetic to avoid comparison confusion.
2206 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2207 but is a bit tricky.
2208
0e926e56
PE
2209 Assume freestanding C89 headers, string.h, stdlib.h.
2210 * data.c, doprnt.c, floatfns.c, print.c:
2211 Include float.h unconditionally.
2212 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2213 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2214 * regex.c: Likewise for stddef.h, string.h.
2215 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2216 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2217 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2218 (STDC_HEADERS): Remove obsolete defines.
2219 * sysdep.c: Include limits.h unconditionally.
2220
9cfdb3ec
PE
2221 Assume support for memcmp, memcpy, memmove, memset.
2222 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2223 * regex.c (memcmp, memcpy):
2224 Remove; we assume C89 now.
2225
2226 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2227 (__malloc_safe_bcopy): Remove; no longer needed.
2228
cf950e6b 2229 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2230 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2231 well either way, and we prefer signed to unsigned.
2232
dbf38e02
LMI
22332011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2234
2235 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2236 closes the connection while we're reading (bug#9182).
2237
d6f0886c 22382011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2239
d6f0886c
JD
2240 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2241 are specified (Bug#9168).
24e0f6b1 2242
2eb1f9e6
PE
22432011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2244
2245 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2246 Found by GCC static checking and --with-wide-int on a 32-bit host.
2247
22381272 22482011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2249
2250 * xdisp.c (compute_display_string_pos): Fix logic of caching
2251 previous display string position. Initialize cached_prev_pos to
2252 -1. Fixes slow-down at the beginning of a buffer.
2253
f25e39b4
EZ
22542011-07-24 Eli Zaretskii <eliz@gnu.org>
2255
2256 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2257 for attrs[LFACE_FONTSET_INDEX].
2258
04c4b52e
PE
22592011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2260
2261 * xml.c (parse_region): Remove unused local
2262 that was recently introduced.
2263
c1734fbd
EZ
22642011-07-23 Eli Zaretskii <eliz@gnu.org>
2265
be18c5a5
EZ
2266 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2267 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2268
c1734fbd
EZ
2269 * xdisp.c (move_it_in_display_line_to): Record the best matching
2270 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2271 exit if none of the characters scanned was an exact match.
2272 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2273 when exact match is impossible due to invisible text, and the
2274 lines are truncated.
2275
a258d627
JD
22762011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2277
2278 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2279 for OSX >= 10.7.
2280
b6d5a689
EZ
22812011-07-22 Eli Zaretskii <eliz@gnu.org>
2282
0f74f785
EZ
2283 Fix a significant slow-down of cursor motion with C-n, C-p,
2284 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2285 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2286 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2287 (next_element_from_buffer): Call compute_stop_pos_backwards to
2288 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2289 base_level_stop.
2290 (reseat): Don't look for prev_stop, as that could mean a very long
2291 run.
2292 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2293 <cached_disp_overlay_modiff>: Cache for last found display string
2294 position.
551918c1 2295 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2296 about the same buffer in the same area of character positions, and
2297 the buffer wasn't changed since the time the display string
2298 position was cached.
551918c1 2299
b2d0c91a
EZ
23002011-07-22 Eli Zaretskii <eliz@gnu.org>
2301
2302 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2303 is an integer, which is important for empty lines. (Bug#9149)
2304
043604ee
CY
23052011-07-22 Chong Yidong <cyd@stupidchicken.com>
2306
2307 * frame.c (Fmodify_frame_parameters): In tty case, update the
2308 default face if necessary (Bug#4238).
2309
da4adb04
CY
23102011-07-21 Chong Yidong <cyd@stupidchicken.com>
2311
2312 * editfns.c (Fstring_to_char): No need to explain what a character
2313 is in the docstring (Bug#6576).
2314
9abd0532
LMI
23152011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2316
2317 * xml.c (parse_region): Make sure we always return a tree.
2318
36881d16
HK
23192011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2320
2321 * xml.c (parse_region): If a document contains only comments,
2322 return that, too.
2323
1e98674d
LMI
23242011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2325
2326 * xml.c (make_dom): Return comments, too.
2327
590bd467
PE
23282011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2329
2330 Port to OpenBSD.
2331 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2332 and the surrounding thread.
2333 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2334 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2335 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2336 timer goes off.
2337 * s/openbsd.h (BROKEN_SIGIO): Define.
2338 * unexelf.c (unexec) [__OpenBSD__]:
2339 Don't update the .mdebug section of the Alpha COFF symbol table.
2340
f41628b2
LMI
23412011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2342
2343 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2344 (bug#8460).
2345
b59b67c5
PE
23462011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2347
15e3a074
PE
2348 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2349 This fixes some race conditions on the permissions of any newly
2350 created file.
2351
41bed37d
PE
2352 * alloc.c (valid_pointer_p): Use pipe, not open.
2353 This fixes some permissions issues when debugging.
2354
b59b67c5
PE
2355 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2356 If fchown fails to set both uid and gid, try to set just gid,
2357 as that is sometimes allowed. Adjust the file's mode to eliminate
2358 setuid or setgid bits that are inappropriate if fchown fails.
2359
925a6be7
SM
23602011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2361
2362 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2363 to compare Lisp_Objects.
2364 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2365 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2366 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2367
52968808
AS
23682011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2369
0a6a104b
AS
2370 * lread.c (read_integer): Unread even EOF character.
2371 (read1): Likewise. Properly record start position of symbol.
2372
52968808
AS
2373 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2374 symbol character follows.
2375
9e381cdd
PE
23762011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2377
2378 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2379 This works around a problem with the previous change to Fcopy_file.
2380 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2381 and without this change, GCC might complain about discarding
2382 fchown's return value.
2383
b5641435
JB
23842011-07-16 Juanma Barranquero <lekktu@gmail.com>
2385
2386 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2387
a8031457
PE
23882011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2389
2390 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2391
dd889327
LMI
23922011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2393
750c33f7
LMI
2394 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2395 it's used from the C level.
2396
dd889327
LMI
2397 * process.c: Use the same condition for POLL_FOR_INPUT in both
2398 keyboard.c and process.c (bug#1858).
2399
87e86684
LM
24002011-07-09 Lawrence Mitchell <wence@gmx.li>
2401
2402 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2403 (Fgnutls_boot): Use it.
2404
64348f40
AS
24052011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2406
2407 * doc.c (Fsubstitute_command_keys): Revert last change.
2408
1d698799
LMI
24092011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2410
f863868c
LMI
2411 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2412 quotes the next character, and doesn't affect other longer
2413 sequences (bug#8935).
2414
1d698799
LMI
2415 * lread.c (syms_of_lread): Clarify that is isn't only
2416 `eval-buffer' and `eval-defun' that's affected by
2417 `lexical-binding' (bug#8460).
2418
aa4b6df6
EZ
24192011-07-15 Eli Zaretskii <eliz@gnu.org>
2420
2421 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2422 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2423
5d856da6
PE
24242011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2425
ad6042bb
PE
2426 Fix minor problems found by static checking.
2427 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2428 (elsz): Now a signed constant, not a size_t var. We prefer signed
2429 types to unsigned, to avoid integer comparison confusion. Without
2430 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2431 "cannot optimize loop, the loop counter may overflow", a symptom
2432 of the confusion.
f00bbb22 2433 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2434 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2435
6468f31c
LMI
24362011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2437
49080b10
LMI
2438 * search.c (Fre_search_backward): Mention `case-fold-search' in
2439 all the re_search_* functions (bug#8138).
2440
6468f31c
LMI
2441 * keyboard.c (Fopen_dribble_file): Document when the file is
2442 closed (bug#8056).
2443
c965adc5
EZ
24442011-07-14 Eli Zaretskii <eliz@gnu.org>
2445
df9733bf
EZ
2446 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2447 bidi_cache_idx.
2448
0bb23927
EZ
2449 Support bidi reordering of display and overlay strings.
2450 * xdisp.c (compute_display_string_pos)
2451 (compute_display_string_end): Accept additional argument STRING.
2452 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2453 (reseat_to_string): Initialize bidi_it->string.s and
2454 bidi_it->string.schars.
2455 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2456 NULL (avoids a crash in bidi_paragraph_init).
2457 Initialize itb.string.lstring.
0bb23927
EZ
2458 (init_iterator): Call bidi_init_it only of a valid
2459 buffer position was specified. Initialize paragraph_embedding to
2460 L2R.
2461 (reseat_to_string): Initialize the bidi iterator.
2462 (display_string): If we need to ignore text properties of
2463 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2464 original value of -1 will not work with bidi.)
2465 (compute_display_string_pos): First arg is now struct
2466 `text_pos *'; all callers changed. Support display properties on
2467 Lisp strings.
2468 (compute_display_string_end): Support display properties on Lisp
2469 strings.
2470 (init_iterator, reseat_1, reseat_to_string): Initialize the
2471 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2472 when iterating on a string not from display properties).
640c8776
SM
2473 (compute_display_string_pos, compute_display_string_end):
2474 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2475 arrow keys.
2476 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2477 base_level_stop; instead, set base_level_stop to BEGV.
2478 Fixes crashes in vertical-motion.
0bb23927
EZ
2479 (next_element_from_buffer): Improve commentary for when
2480 the iterator is before prev_stop.
2481 (init_iterator): Initialize bidi_p from the default value of
2482 bidi-display-reordering, not from buffer-local value. Use the
2483 buffer-local value only if initializing for buffer iteration.
2484 (handle_invisible_prop): Support invisible properties on strings
2485 that are being bidi-reordered.
2486 (set_iterator_to_next): Support bidi reordering of C strings and
2487 Lisp strings.
2488 (next_element_from_string): Support bidi reordering of Lisp
2489 strings.
2490 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2491 (display_string): Support display of R2L glyph rows.
2492 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2493 (init_iterator): Don't initialize it->bidi_p for strings
2494 here.
2495 (reseat_to_string): Initialize it->bidi_p for strings here.
2496 (next_element_from_string, next_element_from_c_string)
2497 (next_element_from_buffer): Add xassert's for correspondence
2498 between IT's object being iterated and it->bidi_it.string
2499 structure.
2500 (face_before_or_after_it_pos): Support bidi iteration.
2501 (next_element_from_c_string): Handle the case of the first string
2502 character that is not the first one in the visual order.
2503 (get_visually_first_element): New function, refactored from common
2504 parts of next_element_from_buffer, next_element_from_string, and
2505 next_element_from_c_string.
2506 (tool_bar_lines_needed, redisplay_tool_bar)
2507 (display_menu_bar): Force left-to-right direction. Add a FIXME
2508 comment for making that be controlled by a user option.
2509 (push_it, pop_it): Save and restore the state of the
2510 bidi iterator. Save and restore the bidi_p flag.
2511 (pop_it): Iterate out of display property for string iteration as
2512 well.
2513 (iterate_out_of_display_property): Support iteration over strings.
2514 (handle_single_display_spec): Set up it->bidi_it for iteration
2515 over a display string, and call bidi_init_it.
2516 (handle_single_display_spec, next_overlay_string)
2517 (get_overlay_strings_1, push_display_prop): Set up the bidi
2518 iterator for displaying display or overlay strings.
2519 (forward_to_next_line_start): Don't use the shortcut if
2520 bidi-iterating.
2521 (back_to_previous_visible_line_start): If handle_display_prop
2522 pushed the iterator stack, restore the internal state of the bidi
2523 iterator by calling bidi_pop_it same number of times.
2524 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2525 and we are bidi-iterating, don't decrement the iterator position;
2526 instead, set the first_elt flag in the bidi iterator, to produce
2527 the same effect.
2528 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2529 (push_display_prop): xassert that we are iterating a buffer.
2530 (push_it, pop_it): Save and restore paragraph_embedding member.
2531 (handle_single_display_spec, next_overlay_string)
2532 (get_overlay_strings_1, reseat_1, reseat_to_string)
2533 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2534 correctly. Don't assume unibyte strings are not bidi-reordered.
2535 (compute_display_string_pos)
2536 (compute_display_string_end): Fix handling the case of C string.
2537 (push_it, pop_it): Save and restore from_disp_prop_p.
2538 (handle_single_display_spec, push_display_prop): Set the
2539 from_disp_prop_p flag.
2540 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2541 (pop_it): Call iterate_out_of_display_property only if we are
2542 popping after iteration over a string that came from a display
2543 property. Fix a typo in popping stretch info. Add an assertion
2544 for verifying that the iterator position is in sync with the bidi
2545 iterator.
2546 (handle_single_display_spec, get_overlay_strings_1)
2547 (push_display_prop): Fix initialization of paragraph direction for
2548 string when that of the parent object is not yet determined.
2549 (reseat_1): Call bidi_init_it to resync the bidi
2550 iterator with IT's position. (Bug#7616)
2551 (find_row_edges): If ROW->start.pos gives position
2552 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2553 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2554 Reset the from_disp_prop_p flag.
2555 (SAVE_IT, RESTORE_IT): New macros.
2556 (pos_visible_p, face_before_or_after_it_pos)
2557 (back_to_previous_visible_line_start)
2558 (move_it_in_display_line_to, move_it_in_display_line)
2559 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2560 (try_scrolling, redisplay_window, display_line): Use them when
2561 saving a temporary copy of the iterator and restoring it back.
2562 (back_to_previous_visible_line_start, reseat_1)
2563 (init_iterator): Empty the bidi cache "stack".
2564 (move_it_in_display_line_to): If iterator ended up at
2565 EOL, but we never saw any buffer positions smaller than
2566 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2567 motion in bidi-reordered lines.
2568 (move_it_in_display_line_to): Record prev_method and prev_pos
2569 immediately before the call to set_iterator_to_next. Fixes cursor
2570 motion in bidi-reordered lines with stretch glyphs and strings
2571 displayed in margins. (Bug#8133) (Bug#8867)
2572 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2573 TO_CHARPOS.
640c8776
SM
2574 (pos_visible_p): Support positions in bidi-reordered lines.
2575 Save and restore bidi cache.
0bb23927
EZ
2576
2577 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2578 (bidi_paragraph_info): Delete unused struct.
2579 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2580 (bidi_cache_start): New variable.
2581 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2582 to zero.
2583 (bidi_cache_fetch_state, bidi_cache_search)
2584 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2585 (bidi_cache_find, bidi_peek_at_next_level)
2586 (bidi_level_of_next_char, bidi_find_other_level_edge)
2587 (bidi_move_to_visually_next): Compare cache index with
2588 bidi_cache_start rather than with zero.
2589 (bidi_fetch_char): Accept new argument STRING; all callers
2590 changed. Support iteration over a string. Support strings with
2591 display properties. Support unibyte strings. Fix the type of
2592 `len' according to what STRING_CHAR_AND_LENGTH expects.
2593 (bidi_paragraph_init, bidi_resolve_explicit_1)
2594 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2595 (bidi_level_of_next_char, bidi_move_to_visually_next):
2596 Support iteration over a string.
0bb23927
EZ
2597 (bidi_set_sor_type, bidi_resolve_explicit_1)
2598 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2599 can now be zero (for strings); special values 0 and -1 were
2600 changed to -1 and -2, respectively.
2601 (bidi_char_at_pos): New function.
2602 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2603 Call it instead of FETCH_MULTIBYTE_CHAR.
2604 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2605 initialized to valid values.
2606 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2607 values.
2608 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2609 the test for valid cached positions. Fix the logic for looking up
2610 the sentinel state in the cache. GCPRO the Lisp string we are
2611 iterating.
2612 (bidi_push_it, bidi_pop_it): New functions.
2613 (bidi_initialize): Initialize the bidi cache start stack pointer.
2614 (bidi_cache_ensure_space): New function, refactored from part of
2615 bidi_cache_iterator_state. Don't assume the required size is just
2616 one BIDI_CACHE_CHUNK away.
2617 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2618 (bidi_count_bytes, bidi_char_at_pos): New functions.
2619 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2620 always valid if bidi_cache_idx is valid.
2621 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2622 is valid if it's going to be used.
2623 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2624 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2625 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2626 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2627 (bidi_find_other_level_edge, bidi_cache_start_stack):
2628 All variables related to cache indices are now EMACS_INT.
c965adc5 2629
0bb23927
EZ
2630 * dispextern.h (struct bidi_string_data): New structure.
2631 (struct bidi_it): New member `string'. Make flag members be 1-bit
2632 fields, and put them last in the struct.
640c8776
SM
2633 (compute_display_string_pos, compute_display_string_end):
2634 Update prototypes.
0bb23927
EZ
2635 (bidi_push_it, bidi_pop_it): Add prototypes.
2636 (struct iterator_stack_entry): New members bidi_p,
2637 paragraph_embedding, and from_disp_prop_p.
2638 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2639 (bidi_shelve_cache, bidi_unshelve_cache):
2640 Declare prototypes.
0bb23927
EZ
2641
2642 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2643 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2644 and vector-like objects.
2645
2646 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2647 cache around display iteration.
2648
2649 * window.c (Fwindow_end, window_scroll_pixel_based)
2650 (displayed_window_lines, Frecenter): Save and restore the bidi
2651 cache around display iteration.
2652
3bbd2265
LMI
26532011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2654
2655 * editfns.c (Fdelete_region): Clarify the use of the named
2656 parameters (bug#6788).
2657
adc47434
MR
26582011-07-14 Martin Rudalics <rudalics@gmx.at>
2659
2660 * indent.c (Fvertical_motion): Set and restore w->pointm when
2661 saving and restoring the window's buffer (Bug#9006).
2662
837c31f8
LMI
26632011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2664
2665 * editfns.c (Fstring_to_char): Clarify just what is returned
2666 (bug#6576). Text by Eli Zaretskii.
2667
ac389d0c
JB
26682011-07-13 Juanma Barranquero <lekktu@gmail.com>
2669
2670 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2671
0be0ce47
EZ
26722011-07-13 Eli Zaretskii <eliz@gnu.org>
2673
2674 * buffer.c (mmap_find): Fix a typo.
2675
cd18e7e3
JB
26762011-07-13 Johan Bockgård <bojohan@gnu.org>
2677
2678 Fix execution of x selection hooks.
2679 * xselect.c (Qx_lost_selection_functions)
2680 (Qx_sent_selection_functions): New vars.
2681 (syms_of_xselect): DEFSYM them.
2682 (x_handle_selection_request): Pass Qx_sent_selection_functions
2683 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2684 (x_handle_selection_clear,x_clear_frame_selections):
2685 Pass Qx_lost_selection_functions rather than
2686 Vx_lost_selection_functions to Frun_hook_with_args.
2687
47ea7f44
PE
26882011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2689
ac389d0c 2690 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2691 The old code sometimes used this field without initializing it.
2692
47ea7f44
PE
2693 * alloc.c (gc_sweep): Don't read past end of array.
2694 In theory, the old code could also have corrupted Emacs internals,
2695 though it'd be very unlikely.
2696
bc985c87
AS
26972011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2698
2699 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2700 argument. (Bug#4026)
bc985c87 2701
0cf34688
LMI
27022011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2703
b3dadd76
LMI
2704 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2705 key" (bug#4257).
2706
0cf34688
LMI
2707 * window.c (Fset_window_start): Doc fix (bug#4199).
2708 (Fset_window_hscroll): Ditto.
2709
270768cd
PE
27102011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2711
077e3dda 2712 Fix minor new problems caught by GCC 4.6.1.
270768cd 2713 * term.c (init_tty): Remove unused local.
490011a6 2714 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2715 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2716 not used otherwise.
270768cd 2717
b1f58454
CY
27182011-07-12 Chong Yidong <cyd@stupidchicken.com>
2719
2720 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2721
22b9578d
LMI
27222011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2723
6e70ab07
LMI
2724 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2725 are the mini-buffer and the echo area (bug#3320).
2726
22b9578d
LMI
2727 * term.c (init_tty): Remove support for supdup, c10 and perq
2728 terminals, which are no longer supported (bug#1482).
2729
8974cc9f
JB
27302011-07-10 Johan Bockgård <bojohan@gnu.org>
2731
2732 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2733
a560d974
JD
27342011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2735
2736 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2737 for non-popups (Bug#3642).
2738
1dae0f0a
AS
27392011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2740
268c2c36 2741 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2742 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2743 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2744 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2745 * data.c (fmod): Likewise.
2746 * dispnew.c (swap_glyphs_in_rows): Likewise.
2747 * emacs.c (memory_warning_signal): Likewise.
2748 * floatfns.c (float_error): Likewise.
2749 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2750 (otf_open, font_otf_capability, generate_otf_features)
2751 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2752 Likewise.
2753 * image.c (pbm_read_file): Likewise.
2754 * indent.c (string_display_width): Likewise.
2755 * intervals.c (check_for_interval, search_for_interval)
2756 (inc_interval_count, count_intervals, root_interval)
2757 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2758 * lread.c (defalias): Likewise.
268c2c36 2759 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2760 * regex.c (set_image_of_range_1, set_image_of_range)
2761 (regex_grow_registers): Likewise.
2762 * sysdep.c (strerror): Likewise.
2763 * termcap.c (valid_filename_p, tprint, main): Likewise.
2764 * tparam.c (main): Likewise.
2765 * unexhp9k800.c (run_time_remap, save_data_space)
2766 (update_file_ptrs, read_header, write_header, calculate_checksum)
2767 (copy_file, copy_rest, display_header): Likewise.
2768 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2769 Likewise.
2770 * xdisp.c (check_it): Likewise.
2771 * xfaces.c (register_color, unregister_color, unregister_colors):
2772 Likewise.
2773 * xfns.c (print_fontset_result): Likewise.
2774 * xrdb.c (member, fatal, main): Likewise.
2775
99033785
PE
27762011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2777
2778 Fix minor problems found by static checking (Bug#9031).
2779 * chartab.c (char_table_set_range, map_sub_char_table):
2780 Remove unused locals.
2781 (uniprop_table): Now static.
2782 * composite.c (_work_char): Remove unused static var.
2783
9cb2ac56
JB
27842011-07-09 Juanma Barranquero <lekktu@gmail.com>
2785
2786 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2787
f25661f0
JD
27882011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2789
2790 * gtkutil.c (qttip_cb): Remove code without function.
2791
8278c4fe
EZ
27922011-07-09 Eli Zaretskii <eliz@gnu.org>
2793
2794 * w32.c (pthread_sigmask): New stub.
2795
1692ae2d 27962011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2797
8a6ebd58 2798 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2799 sigprocmask is portable only for single-threaded applications, and
2800 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2801 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2802 (LIBES): Use it.
2803 * callproc.c (Fcall_process):
2804 * process.c (create_process):
2805 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2806 Use pthread_sigmask, not sigprocmask.
123403e4 2807
1b854618
JD
28082011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2809
2810 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2811 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2812 wrong (Bug#8591).
2813
3fe4b549
JD
28142011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2815
0ce7e563
JD
2816 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2817 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2818 (xg_hide_tooltip): Fix comment.
2819
3fe4b549
JD
2820 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2821 in registerServicesMenuSendTypes.
2822 (validRequestorForSendType): Don't check ns_return_types.
2823
2824 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2825 ns_return_type.
2826
5df75e47
JR
28272011-07-08 Jason Rumney <jasonr@gnu.org>
2828
22610910
JR
2829 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
2830 SH_SHOW for hidden windows (Bug#5482).
2831
5df75e47
JR
2832 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2833 frame struct members of non-existent frames (Bug#6284).
2834
699c10bd
JD
28352011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2836
4393663b
JD
2837 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2838 variable firstTime not needed on OSX >= 10.6.
2839 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2840 >= 10.5. Use setKnobProportion, setDoubleValue.
2841
2842 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2843 (MAC_OS_X_VERSION_10_5): Define if not defined.
2844 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2845 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2846 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2847
2848 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2849 cString and lossyCString on OSX >= 10.4
2850
2851 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2852 sizeToFit on OSX >= 10.2.
2853
2854 * nsimage.m (allocInitFromFile): Don't use deprecated method
2855 bestRepresentationForDevice on OSX >= 10.6.
2856
2857 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2858 to avoid warning.
2859
2860 * emacs.c: Declare unexec_init_emacs_zone.
2861
a63e0781
JD
2862 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2863
699c10bd
JD
2864 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2865
2866 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2867 on svcsMenu (Bug#8842).
2868
2869 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2870 ns_return_types.
2871 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2872
2873 * nsterm.m (QUTF8_STRING): Declare.
2874 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2875 (validRequestorForSendType): Return type is (id).
2876 Change indexOfObjectIdenticalTo to indexOfObject.
2877 Check if we have local selection before returning self (Bug#8842).
2878 (writeSelectionToPasteboard): Put local selection into paste board
2879 if we have a local selection (Bug#8842).
2880 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2881
2882 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2883 (ns_get_local_selection): Declare.
2884
54e10184
LMI
28852011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2886
9888ff71
LMI
2887 * keymap.c (describe_map_tree): Don't insert a double newline at
2888 the end of the buffer (bug#1169) and return whether we inserted
2889 something.
2890
54e10184
LMI
2891 * callint.c (Fcall_interactively): Change "reading args" to
2892 "providing args" to try to clarify what it does (bug#1010).
2893
15fa4783
KH
28942011-07-07 Kenichi Handa <handa@m17n.org>
2895
2896 * composite.c (composition_compute_stop_pos): Ignore a static
2897 composition starting before CHARPOS (Bug#8915).
2898
2899 * xdisp.c (handle_composition_prop): Likewise.
2900
a8815b00
EZ
29012011-07-07 Eli Zaretskii <eliz@gnu.org>
2902
2903 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2904 (Bug#9015)
2905
ef7b981d 29062011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2907
2908 * character.h (unicode_category_t): New enum type.
2909
2910 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2911 (Qchar_code_property_table): New variable.
2912 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2913 (UNIPROP_COMPRESSED_FORM_P): New macros.
2914 (char_table_ascii): Uncompress the compressed values.
2915 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2916 Uncompress the compressed values.
ac389d0c 2917 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2918 (char_table_ref_and_range): Uncompress the compressed values.
2919 (sub_char_table_set): New arg is_uniprop. Callers changed.
2920 Uncompress the compressed values.
2921 (sub_char_table_set_range): Args changed. Callers changed.
2922 (char_table_set_range): Adjuted for the above change.
2923 (map_sub_char_table): Delete args default_val and parent. Add arg
2924 top. Give decoded values to a Lisp function.
640c8776 2925 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2926 values to a Lisp function. Gcpro more variables.
2927 (uniprop_table_uncompress)
2928 (uniprop_decode_value_run_length): New functions.
2929 (uniprop_decoder, uniprop_decoder_count): New variables.
2930 (uniprop_get_decoder, uniprop_encode_value_character)
2931 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2932 New functions.
2933 (uniprop_encoder, uniprop_encoder_count): New variables.
2934 (uniprop_get_encoder, uniprop_table)
2935 (Funicode_property_table_internal, Fget_unicode_property_internal)
2936 (Fput_unicode_property_internal): New functions.
2937 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2938 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2939 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2940 char-code-property-alist.
2941
640c8776 2942 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2943 Vunicode_category_table.
2944
640c8776 2945 * font.c (font_range): Adjust for the change of
c805dec0
KH
2946 Vunicode_category_table.
2947
76b397fb
DN
29482011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2949
2950 * m/iris4d.h: Remove file, move contents ...
2951 * s/irix6-5.h: ... here.
2952
22b4128e
PE
29532011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2954
2955 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2956 * alloc.c (mark_buffer):
2957 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2958 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2959 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2960 This isn't true in general, and it's particularly not true
2961 if Emacs is configured with --with-wide-int.
2962 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2963 New macros, used in the buffer.c change.
2964
869795d6
JD
29652011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2966
2967 * xsettings.c: Use both GConf and GSettings if both are available.
2968 (store_config_changed_event): Add comment.
2969 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2970 (store_tool_bar_style_changed): New functions.
5e617bc2 2971 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2972 (struct xsettings): Move font inside HAVE_XFT.
2973 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2974 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2975 Move inside HAVE_XFT.
640c8776 2976 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2977 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2978 also.
2979 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2980 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2981 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2982 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2983 (parse_settings): Move check for font inside HAVE_XFT.
2984 (read_settings, apply_xft_settings): Add comment.
2985 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2986 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2987 call store_font_name_changed.
2988 (xft_settings_event): Add comment.
2989 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2990 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2991 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2992 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2993 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2994 (xsettings_get_system_font, xsettings_get_system_normal_font):
2995 Add comment.
869795d6 2996
d8ed26bd
PE
29972011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2998
2999 Random fixes. E.g., (random) never returned negative values.
3000 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3001 subseconds part to the entropy, as that's a bit more random.
3002 Prefer signed to unsigned, since the signedness doesn't matter and
3003 in general we prefer signed. When given a limit, use a
3004 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3005 latter isn't right if USE_2_TAGS_FOR_INTS.
3006 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3007 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3008
cabf1cac
SM
30092011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3010
3011 * textprop.c (text_property_stickiness):
3012 Obey Vtext_property_default_nonsticky.
3013 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3014 * w32fns.c (syms_of_w32fns):
3015 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3016
6e9b2be9
PE
30172011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3018
3019 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3020 This is more efficient than Ffile_directory_p and avoids a minor race.
3021
90186c68
LMI
30222011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3023
7c301272
LMI
3024 * buffer.c (Foverlay_put): Say what the return value is
3025 (bug#7835).
3026
c4f2d8d4
LMI
3027 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3028 is a directory before asking whether to use the file name
3029 (bug#7564).
ad637907
LMI
3030 (barf_or_query_if_file_exists): Make the "File is a directory"
3031 error be more correct.
c4f2d8d4 3032
90186c68
LMI
3033 * fns.c (Frequire): Remove the mention of the .gz files, since
3034 that's installation-specific, but keep the mention of
3035 `get-load-suffixes'.
3036
da64016e
PE
30372011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3038
3039 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3040 Report string overflow if the output is too long.
3041
7d47b580
JB
30422011-07-04 Juanma Barranquero <lekktu@gmail.com>
3043
a555cb87
JB
3044 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3045 (syms_of_gnutls): Remove duplicate DEFSYM for
3046 Qgnutls_bootprop_verify_hostname_error, an error for
3047 Qgnutls_bootprop_verify_error (which is no longer used).
3048
7d47b580
JB
3049 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3050 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3051 Also (re)move comments that are misplaced or no longer relevant.
3052
1e49bfab
LMI
30532011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3054
3055 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3056
1485f4c0
CY
30572011-07-03 Chong Yidong <cyd@stupidchicken.com>
3058
3059 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3060 and background color parameters if they have been changed.
3061
a9ab721e
LMI
30622011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3063
3064 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3065
cf7cff57
PE
30662011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3067
2e13213d
PE
3068 * xsettings.c (SYSTEM_FONT): Define only when used.
3069 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3070
cf7cff57
PE
3071 * keymap.c (access_keymap_1): Now static.
3072
7a8e04f7
CY
30732011-07-02 Chong Yidong <cyd@stupidchicken.com>
3074
3075 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3076 leave any prefix arg for the up event (Bug#1586).
3077
61352f62
LMI
30782011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3079
69bb1ef7
LMI
3080 * lread.c (syms_of_lread): Mention single symbols defined by
3081 `defvar' or `defconst' (bug#7154).
3082
61352f62 3083 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3084 (Frequire): Mention get-load-suffixes.
61352f62 3085
28545e04
MR
30862011-07-02 Martin Rudalics <rudalics@gmx.at>
3087
3088 * window.h (window): Remove clone_number slot.
3089 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3090 Remove.
3091 (make_parent_window, make_window, saved_window)
3092 (Fset_window_configuration, save_window_save): Don't deal with
3093 clone numbers.
3094 * buffer.c (Qclone_number): Remove declaration.
3095 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3096
3349e122
SM
30972011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3098
3099 Add multiple inheritance to keymaps.
3100 * keymap.c (Fmake_composed_keymap): New function.
3101 (Fset_keymap_parent): Simplify.
3102 (fix_submap_inheritance): Remove.
3103 (access_keymap_1): New function extracted from access_keymap to handle
3104 embedded parents and handle lists of maps.
3105 (access_keymap): Use it.
3106 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3107 (Fcopy_keymap): Handle embedded parents.
3108 (Fcommand_remapping, define_as_prefix): Simplify.
3109 (Fkey_binding): Simplify.
3110 (syms_of_keymap): Move minibuffer-local-completion-map,
3111 minibuffer-local-filename-completion-map,
3112 minibuffer-local-must-match-map, and
3113 minibuffer-local-filename-must-match-map to Elisp.
3114 (syms_of_keymap): Defsubr make-composed-keymap.
3115 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3116 (parse_menu_item): Trivial simplification.
3117
3279eb87
GM
31182011-07-01 Glenn Morris <rgm@gnu.org>
3119
3120 * Makefile.in (SETTINGS_LIBS): Fix typo.
3121
4550efdf
KI
31222011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3123
3124 * coding.c (Fencode_coding_string): Record the last coding system
3125 used, as the function doc string says (bug#8738).
3126
0949d2b6
JD
31272011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3128
3129 * xsettings.c (store_monospaced_changed): Take new font as arg and
3130 check for change against current_mono_font.
3131 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3132 (emacs_settings_constructor, emacs_settings_get_property)
3133 (emacs_settings_set_property, emacs_settings_class_init)
3134 (emacs_settings_init, gsettings_obj): Remove.
3135 (something_changedCB): New function for HAVE_GSETTINGS.
3136 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3137 with value as argument.
3138 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3139 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3140 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3141 "changed".
3142
3143 * xgselect.c: Add defined (HAVE_GSETTINGS).
3144 (xgselect_initialize): Ditto.
3145
3146 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3147 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3148 xg_select.
3149
bbc6b304
PE
31502011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3151
3152 * eval.c (struct backtrace): Simplify and port the data structure.
3153 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3154 signed bit field, as this assumption is not portable and it makes
3155 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3156 "char debug_on_exit : 1" as this is not portable either; instead,
3157 use the portable "unsigned int debug_on_exit : 1". Remove unused
3158 member evalargs. Remove obsolete comments about cc bombing out.
3159
9851bfc5
JD
31602011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3161
51bb811f 3162 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3163 Let HAVE_GSETTINGS override HAVE_GCONF.
3164 (store_monospaced_changed): New function.
3165 (EMACS_SETTINGS): A new type derived from GObject to handle
3166 GSettings notifications.
3167 (emacs_settings_constructor, emacs_settings_get_property)
3168 (emacs_settings_set_property, emacs_settings_class_init):
3169 New functions.
3170 (gsettings_client, gsettings_obj): New variables.
3171 (GSETTINGS_SCHEMA): New define.
3172 (something_changedCB): Call store_monospaced_changed.
3173 (init_gsettings): New function.
3174 (xsettings_initialize): Call init_gsettings.
3175 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3176 to NULL.
3177
640c8776 3178 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3179 GCONF_CFLAGS/LIBS.
3180
5386012d
MR
31812011-06-29 Martin Rudalics <rudalics@gmx.at>
3182
3183 * window.c (resize_root_window, grow_mini_window)
3184 (shrink_mini_window): Rename Qresize_root_window to
3185 Qwindow_resize_root_window and Qresize_root_window_vertically to
3186 Qwindow_resize_root_window_vertically.
3187
f13e0b08
PE
31882011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3189
3190 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3191
94515237
JB
31922011-06-27 Juanma Barranquero <lekktu@gmail.com>
3193
3194 * makefile.w32-in: Redesign dependencies so they reflect more
3195 clearly which files are directly included by each source file,
3196 and not through other includes.
3197
e43b6e43
MR
31982011-06-27 Martin Rudalics <rudalics@gmx.at>
3199
3200 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3201 (sort_overlays, overlay_strings): When an overlay's clone number
3202 matches the window's clone number process the overlay even if
3203 the overlay's window property doesn't match the current window.
3204
d68443dc
MR
3205 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3206 (Fwindow_hchild): Rename to Fwindow_left_child.
3207 (Fwindow_next): Rename to Fwindow_next_sibling.
3208 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3209 (resize_window_check): Rename to window_resize_check.
3210 (resize_window_apply): Rename to window_resize_apply.
3211 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3212 (Fdelete_other_windows_internal, resize_frame_windows)
3213 (Fsplit_window_internal, Fdelete_window_internal)
3214 (grow_mini_window, shrink_mini_window)
3215 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3216
c7e73be5
JD
32172011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3218
3219 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3220 (emacs_fixed_set_min_size): Remove.
3221 (emacs_fixed_new): Take frame as argument.
3222
3223 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3224 (_EmacsFixedPrivate): Remove minwidth/height.
3225 Add struct frame *f.
3226 (emacs_fixed_init): Initialize priv->f.
3227 (get_parent_class, emacs_fixed_set_min_size): Remove.
3228 (emacs_fixed_new): Set priv->f to argument.
3229 (emacs_fixed_get_preferred_width)
3230 (emacs_fixed_get_preferred_height): Use min_width/height from
3231 frames size_hint to set minimum and natural (Bug#8919).
3232 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3233 and use min_width/height from frames size_hint to set
3234 min_width/height (Bug#8919).
3235
3236 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3237 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3238 Fix indentation.
c7e73be5 3239
cf99dcf8
EZ
32402011-06-26 Eli Zaretskii <eliz@gnu.org>
3241
3242 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3243 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3244 called at ZV.
3245
029529ac
CY
32462011-06-26 Chong Yidong <cyd@stupidchicken.com>
3247
3248 * process.c (wait_reading_process_output): Bypass select if
3249 waiting for a cell while ignoring keyboard input, and input is
3250 pending. Suggested by Jan Djärv (Bug#8869).
3251
7a7ef429
PE
32522011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3253
3254 Use gnulib's dup2 module instead of rolling our own.
3255 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3256
11fdef7d 32572011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3258
3259 * dispnew.c (scrolling_window): Before scrolling, turn off a
3260 mouse-highlight in the window being scrolled.
3261
cd3520a4
JB
32622011-06-24 Juanma Barranquero <lekktu@gmail.com>
3263
3264 Move DEFSYM to lisp.h and use everywhere.
3265
3266 * character.h (DEFSYM): Move declaration...
3267 * lisp.h (DEFSYM): ...here.
3268
3269 * gnutls.c:
3270 * minibuf.c:
3271 * w32menu.c:
3272 * w32proc.c:
3273 * w32select.c: Don't include character.h.
3274
3275 * alloc.c (syms_of_alloc):
3276 * buffer.c (syms_of_buffer):
3277 * bytecode.c (syms_of_bytecode):
3278 * callint.c (syms_of_callint):
3279 * casefiddle.c (syms_of_casefiddle):
3280 * casetab.c (init_casetab_once):
3281 * category.c (init_category_once, syms_of_category):
3282 * ccl.c (syms_of_ccl):
3283 * cmds.c (syms_of_cmds):
3284 * composite.c (syms_of_composite):
3285 * dbusbind.c (syms_of_dbusbind):
3286 * dired.c (syms_of_dired):
3287 * dispnew.c (syms_of_display):
3288 * doc.c (syms_of_doc):
3289 * editfns.c (syms_of_editfns):
3290 * emacs.c (syms_of_emacs):
3291 * eval.c (syms_of_eval):
3292 * fileio.c (syms_of_fileio):
3293 * fns.c (syms_of_fns):
3294 * frame.c (syms_of_frame):
3295 * fringe.c (syms_of_fringe):
3296 * insdel.c (syms_of_insdel):
3297 * keymap.c (syms_of_keymap):
3298 * lread.c (init_obarray, syms_of_lread):
3299 * macros.c (syms_of_macros):
3300 * msdos.c (syms_of_msdos):
3301 * print.c (syms_of_print):
3302 * process.c (syms_of_process):
3303 * search.c (syms_of_search):
3304 * sound.c (syms_of_sound):
3305 * syntax.c (init_syntax_once, syms_of_syntax):
3306 * terminal.c (syms_of_terminal):
3307 * textprop.c (syms_of_textprop):
3308 * undo.c (syms_of_undo):
3309 * w32.c (globals_of_w32):
3310 * window.c (syms_of_window):
3311 * xdisp.c (syms_of_xdisp):
3312 * xfaces.c (syms_of_xfaces):
3313 * xfns.c (syms_of_xfns):
3314 * xmenu.c (syms_of_xmenu):
3315 * xsettings.c (syms_of_xsettings):
3316 * xterm.c (syms_of_xterm): Use DEFSYM.
3317
4228cf16
TZ
33182011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3319
cd3520a4 3320 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3321
7fcccf1e
PE
33222011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3323
7efb4e0e
PE
3324 Integer and buffer overflow fixes (Bug#8873).
3325
ff5844ad
PE
3326 * print.c (printchar, strout): Check for string overflow.
3327 (PRINTPREPARE, printchar, strout):
3328 Don't set size unless allocation succeeds.
3329
90532f02
PE
3330 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3331 for sizes. Check for string overflow more accurately.
3332 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3333
6d84508d
PE
3334 * macros.c: Integer and buffer overflow fixes.
3335 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3336 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3337 Use ptrdiff_t, not int, for sizes.
3338 Don't increment bufsize until after realloc succeeds.
3339 Check for size-calculation overflow.
3340 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3341
437b2cb4
PE
3342 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3343
8b9ac8b4
PE
3344 * lread.c: Integer overflow fixes.
3345 (read_integer): Radix is now EMACS_INT, not int,
3346 to improve quality of diagnostics for out-of-range radices.
3347 Calculate buffer size correctly for out-of-range radices.
3348 (read1): Check for integer overflow in radices, and in
3349 read-circle numbers.
82cb60d3
PE
3350 (read_escape): Avoid int overflow.
3351 (Fload, openp, read_buffer_size, read1)
3352 (substitute_object_recurse, read_vector, read_list, map_obarray):
3353 Use ptrdiff_t, not int, for sizes.
3354 (read1): Use EMACS_INT, not int, for sizes.
20270765 3355 Check for size overflow.
8b9ac8b4 3356
7fcccf1e
PE
3357 * image.c (cache_image): Check for size arithmetic overflow.
3358
bfbbd7e7
PE
3359 * lread.c: Integer overflow issues.
3360 (saved_doc_string_size, saved_doc_string_length)
3361 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3362 Now ptrdiff_t, not int.
3363 (read1): Don't assume doc string length fits in int. Check for
3364 out-of-range doc string lengths.
3365 (read_list): Don't assume file position fits in int.
39019e54 3366 (read_escape): Check for hex character overflow.
bfbbd7e7 3367
4e323265
LL
33682011-06-22 Leo Liu <sdl.web@gmail.com>
3369
3370 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3371 Move to minibuffer.el.
3372
85fece3e
PE
33732011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3374
20b84ce9 3375 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3376 The following patches are for when GLYPH_DEBUG && !XASSERT.
3377 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3378 * dispnew.c (flush_stdout):
3379 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3380 Mark as externally visible.
3381 * dispnew.c (check_window_matrix_pointers): Now static.
3382 * dispnew.c (window_to_frame_vpos):
3383 * xfns.c (unwind_create_frame):
3384 * xterm.c (x_check_font): Remove unused local.
3385 * scroll.c (CHECK_BOUNDS):
3386 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3387 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3388 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3389 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3390 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3391 Now static.
3392 (debug_method_add): Use va_list and vsprintf rather than relying
3393 on undefined behavior with wrong number of arguments.
3394 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3395 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3396 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3397 since we're not interested in debugging glyphs with old libraries.
3398 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3399 GCC 4.6.0's static checking.
3400
0766b489
PE
34012011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3402
31fd4b32
PE
3403 Integer overflow and signedness fixes (Bug#8873).
3404 A few related buffer overrun fixes, too.
3405
b79e8648
PE
3406 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3407
0766b489
PE
3408 * dispextern.h (struct face.stipple):
3409 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3410 (x_bitmap_mask, x_allocate_bitmap_record)
3411 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3412 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3413 (x_create_bitmap_from_xpm_data):
3414 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3415 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3416 (.bitmaps_last):
3417 * xfaces.c (load_pixmap):
3418 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3419 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3420 (.bitmaps_last, struct x_output.icon_bitmap):
3421 Use ptrdiff_t, not int, for bitmap indexes.
3422 (x_allocate_bitmap_record): Check for size overflow.
3423 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3424
b081724f
PE
3425 Use ptrdiff_t, not int, for overlay counts.
3426 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3427 * editfns.c (overlays_around, get_pos_property):
3428 * textprop.c (get_char_property_and_overlay):
3429 * xdisp.c (next_overlay_change, note_mouse_highlight):
3430 * xfaces.c (face_at_buffer_position):
21514da7
PE
3431 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3432 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3433 (Fnext_overlay_change, Fprevious_overlay_change)
3434 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3435 Use ptrdiff_t, not int, for sizes.
21514da7 3436 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3437
3de73e5e
PE
3438 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3439
2606c57b
PE
3440 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3441 (x_session_initialize): Do not assume string length fits in int.
3442
aaafe47a
PE
3443 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3444 This is unlikely, but can occur if DPI is outlandish.
3445
2674ddc8 3446 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3447 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3448
28154962
PE
3449 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3450 * xrdb.c (magic_file_p, search_magic_path):
3451 Omit last arg SUFFIX; it was always 0. All callers changed.
3452 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3453
7de51af5
PE
3454 * xfont.c (xfont_match): Avoid need for strlen.
3455
25ed6cc3
PE
3456 * xfns.c: Don't assume strlen fits in int.
3457 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3458
4eab31dd
PE
3459 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3460 not unsigned long, as we prefer signed integers. All callers changed.
3461 Detect integer overflow in repeat count.
3462 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3463 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3464
171e2a58
PE
3465 * termcap.c: Don't assume sizes fit in int and never overflow.
3466 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3467 (gobble_line): Check for size-calculation overflow.
3468
ad39faca 3469 * minibuf.c (Fread_buffer):
6e5bb2dc 3470 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3471 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3472 Don't assume string length fits in int.
3473
52c61c22 3474 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3475 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3476
b5b8c9e5
PE
3477 * font.c: Don't assume string length fits in int.
3478 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3479 Use ptrdiff_t, not int.
ccd6111c
PE
3480 (font_intern_prop): Don't assume string length fits in int.
3481 Don't assume integer property fits in fixnum.
3482 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3483
882f0d81 3484 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3485 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3486 Reformulate so as not to need the command string.
3487 Invoke gzip -cd rather than gunzip, as it's more portable.
3488 (lock_info_type, lock_file_1, lock_file):
3489 Don't assume pid_t and time_t fit in unsigned long.
3490 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3491 (current_lock_owner): Prefer signed type for sizes.
3492 Use memcpy, not strncpy, where memcpy is what is really wanted.
3493 Don't assume (via atoi) that time_t and pid_t fit in int.
3494 Check for time_t and/or pid_t out of range, e.g., via a network share.
3495 Don't alloca where an auto var works fine.
3496
93f4cf88
PE
3497 * fileio.c: Fix some integer overflow issues.
3498 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3499 Don't assume string length fits in int.
3500 (directory_file_name): Don't assume string length fits in long.
3501 (make_temp_name): Don't assume pid fits in int, or that its print
3502 length is less than 20.
3503
f3e92b69
PE
3504 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3505
1bfdaf10
PE
3506 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3507
35016e9a
PE
3508 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3509
3d1e65a1
PE
3510 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3511 We prefer signed integers, even for size calculations.
3512
0b963a93
PE
3513 * emacs.c: Don't assume string length fits in 'int'.
3514 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3515 (main): Don't invoke strlen when not needed.
3516
573f4b54
PE
3517 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3518 (XD_DEBUG_MESSAGE): Don't waste a byte.
3519
989f33ba
PE
3520 * callproc.c (getenv_internal_1, getenv_internal)
3521 (Fgetenv_internal):
965d34eb
PE
3522 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3523
e4d29b33
PE
3524 * lread.c (invalid_syntax): Omit length argument.
3525 All uses changed. This doesn't fix a bug, but it simplifies the
3526 code away from its former Hollerith-constant appearance, and it's
3527 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3528 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3529
eb49b136
PE
3530 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3531 This didn't break anything, but it didn't help either.
3532 It's confusing to put a bogus integer in a place where the actual
3533 value does not matter.
9f62aeb1 3534 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3535 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3536
15375a22
PE
3537 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3538 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3539 implementation.
b61cc01c
PE
3540 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3541 We prefer signed types, and the value cannot exceed the EMACS_INT
3542 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3543 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3544 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3545 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3546
53b2623d
PE
3547 * indent.c (sane_tab_width): New function.
3548 (current_column, scan_for_column, Findent_to, position_indentation)
3549 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3550 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3551
51cab52b 3552 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3553
f2ed8a70
PE
3554 * lisp.h (lint_assume): New macro.
3555 * composite.c (composition_gstring_put_cache):
3556 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3557
abe80cc6
PE
3558 * editfns.c, insdel.c:
3559 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3560
b02c740e
PE
3561 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3562
ebc96716
PE
3563 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3564
b4e50fa0 3565 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3566 Use much-faster test for byte-length change.
311d5d7c 3567 Don't assume string byte-length fits in 'int'.
a4cf38e4 3568 Check that character arg fits in 'int'.
85461888 3569 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3570
c0c1ee9f
PE
3571 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3572
a498d7f4
PE
3573 * fns.c (concat): Catch string overflow earlier.
3574 Do not rely on integer wraparound.
3575
51cab52b
PE
3576 * dispextern.h (struct it.overlay_strings_charpos)
3577 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3578 * xdisp.c (forward_to_next_line_start)
3579 (back_to_previous_visible_line_start)
3580 (reseat_at_next_visible_line_start, next_element_from_buffer):
3581 Don't arbitrarily truncate the value of 'selective' to int.
3582
76031fad
PE
3583 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3584
5eb55db9
PE
3585 * composite.c: Don't truncate sizes to 'int'.
3586 (composition_gstring_p, composition_reseat_it)
3587 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3588 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3589 not EMACS_UINT, for indexes.
5eb55db9 3590
0703a717
PE
3591 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3592
d6202519
PE
3593 * buffer.c: Include <verify.h>.
3594 (struct sortvec.priority, struct sortstr.priority):
8961a454 3595 Now EMACS_INT, not int.
c20998a7 3596 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3597 (struct sortstr.size, record_overlay_string)
3598 (struct sortstrlist.size, struct sortlist.used):
3599 Don't truncate size to int.
3600 (record_overlay_string): Check for size-calculation overflow.
d6202519 3601 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3602
d5a19415
JM
36032011-06-22 Jim Meyering <meyering@redhat.com>
3604
029529ac 3605 Don't leak an XBM-image-sized buffer
d5a19415
JM
3606 * image.c (xbm_load): Free the image buffer after using it.
3607
a9041e6c
PE
36082011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3609
3610 Port to Sun C.
3611 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3612 that Sun C diagnosed.
3613 * fns.c (secure_hash): Fix pointer signedness issue.
3614 * intervals.c (static_offset_intervals): New function.
3615 (offset_intervals): Use it.
3616
7f3f739f
LL
36172011-06-21 Leo Liu <sdl.web@gmail.com>
3618
3619 * deps.mk (fns.o):
3620 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3621 sha512.h.
3622
3623 * fns.c (secure_hash): Rename from crypto_hash_function and change
3624 the first arg to accept symbols.
5b66d427 3625 (Fsecure_hash): New primitive.
7f3f739f
LL
3626 (syms_of_fns): New symbols.
3627
76147d94
DD
36282011-06-20 Deniz Dogan <deniz@dogan.se>
3629
3630 * process.c (Fset_process_buffer): Clarify return value in
3631 docstring.
3632
7d7d0045
CY
36332011-06-18 Chong Yidong <cyd@stupidchicken.com>
3634
3635 * dispnew.c (add_window_display_history): Use BVAR.
3636
3637 * xdisp.c (debug_method_add): Use BVAR.
3638 (check_window_end, dump_glyph_matrix, dump_glyph)
3639 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3640
3641 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3642 Likewise.
3643
3644 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3645 check till after the cache is created in init_frame_faces.
3646
ff2bc410
SM
36472011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3648
3649 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3650
28177add
PE
36512011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3652
dd3482fe
PE
3653 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3654 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3655 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3656
393d71f3 3657 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3658 * fileio.c (Finsert_file_contents):
3659 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3660 Remove the old (too-loose) buffer overflow checks.
3661 They weren't needed, since make_gap checks for buffer overflow.
3662 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3663 The old code merely checked for Emacs fixnum overflow, and relied
3664 on undefined (wraparound) behavior. The new code avoids undefined
3665 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3666
2e6813b0 3667 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3668 Tune. Don't use wider integers than needed. Don't use alloca.
3669 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3670
599a9e4f
PE
3671 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3672
99561444
PE
3673 * insdel.c, lisp.h (buffer_overflow): New function.
3674 (insert_from_buffer_1, replace_range, replace_range_2):
3675 * insdel.c (make_gap_larger):
3676 * editfns.c (Finsert_char):
3677 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3678
28177add
PE
3679 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3680
e69dafad
PE
36812011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3682
a7af7fde 3683 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3684
b1c46f02
PE
3685 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3686 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3687
e69dafad
PE
3688 * fileio.c: Don't assume EMACS_INT fits in off_t.
3689 (emacs_lseek): New static function.
3690 (Finsert_file_contents, Fwrite_region): Use it.
3691 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3692
566684ea
PE
3693 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3694
e6966cd6
PE
3695 * fns.c: Don't overflow int when computing a list length.
3696 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3697 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3698 truncation on 64-bit hosts. Check for QUIT every
3699 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3700 faster and is responsive enough.
3701 (Flength): Report an error instead of overflowing an integer.
3702 (Fsafe_length): Return a float if the value is not representable
3703 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3704 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3705 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3706
dd0b0efb
PE
3707 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3708 (header_size, word_size): New constants.
3709 (allocate_vectorlike): Don't check size overflow here.
3710 (allocate_vector): Check it here instead, since this is the only
3711 caller of allocate_vectorlike that could cause overflow.
3712 Check that the new vector's length is representable as a fixnum.
3713
86fe5cfe
PE
3714 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3715 The previous code was bogus. For example, next_almost_prime (32)
3716 returned 39, which is undesirable as it is a multiple of 3; and
3717 next_almost_prime (24) returned 25, which is a multiple of 5 so
3718 why was the code bothering to check for multiples of 7?
3719
80e88859
PE
3720 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3721
4a2f0ad6
PE
3722 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3723
f66c7cf8
PE
3724 Variadic C functions now count arguments with ptrdiff_t.
3725 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3726 Back then I didn't know that the Emacs coding style prefers signed int.
3727 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3728 were being counted with int, which may truncate counts on 64-bit
3729 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3730 * lisp.h (struct Lisp_Subr.function.aMANY)
3731 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3732 Arg counts are now ptrdiff_t, not size_t.
3733 All variadic functions and their callers changed accordingly.
3734 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3735 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3736 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3737 * callint.c (Fcall_interactively): Check arg count for overflow,
3738 to avoid potential buffer overrun. Use signed char, not 'int',
3739 for 'varies' array, so that we needn't bother to check its size
3740 calculation for overflow.
3741 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3742 * eval.c (apply_lambda):
3743 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3744 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3745 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3746
a1759b76
PE
3747 * callint.c (Fcall_interactively): Don't use index var as event count.
3748
d96be9fc
PE
3749 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3750 * mem-limits.h (SIZE): Remove; no longer used.
3751
a690a978 3752 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3753
578c21e6
PE
3754 Remove unnecessary casts.
3755 * xterm.c (x_term_init):
3756 * xfns.c (x_set_border_pixel):
3757 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3758 These aren't needed now that we assume ANSI C.
3759
96f53c6c
PE
3760 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3761 It's more likely to cause problems (due to unsigned overflow)
3762 than to cure them.
3763
83c77d31
PE
3764 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3765
ee2079f1
PE
3766 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3767
6da65536
PE
3768 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3769
7147c4a4
PE
3770 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3771
193e32d9
PE
3772 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3773
e5533da6
PE
3774 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3775
9910e595
PE
3776 GLYPH_CODE_FACE returns EMACS_INT, not int.
3777 * dispextern.h (merge_faces):
3778 * xfaces.c (merge_faces):
01103c44
PE
3779 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3780 Don't assume EMACS_INT fits in int.
9910e595 3781
2638320e
PE
3782 * character.h (CHAR_VALID_P): Remove unused parameter.
3783 * fontset.c, lisp.h, xdisp.c: All uses changed.
3784
045eb8d9
PE
3785 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3786
c1f134b5
PE
3787 * fns.c (concat): Minor tuning based on overflow analysis.
3788 This doesn't fix any bugs. Use int to hold character, instead
3789 of constantly refetching from Emacs object. Use XFASTINT, not
3790 XINT, for value known to be a character. Don't bother comparing
3791 a single byte to 0400, as it's always less.
3792
395fcb93 3793 * floatfns.c (Fexpt):
327eeec8
PE
3794 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3795
abbd3d23
PE
3796 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3797 for characters.
3798
684a03ef
PE
3799 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3800
0fed43f3
PE
3801 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3802 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3803 incorrectly succeed when S was a string, because 4294967386 was
3804 truncated before it was used.
3805
8fd02eb7
PE
3806 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3807 Otherwise, an out-of-range integer could cause undefined behavior
3808 on a 64-bit host.
3809
f8c86b69
PE
3810 * composite.c: Use int, not EMACS_INT, for characters.
3811 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3812 EMACS_INT, for values that are known to be in character range.
3813 This doesn't fix any bugs but is the usual style inside Emacs and
3814 may generate better code on 32-bit machines.
3815
34206dd2
PE
3816 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3817 This is for reasons similar to the recent CHAR_STRING fix.
3818 * charset.c (Fencode_char): Check that character arg is actually
3819 a character. Pass an int to ENCODE_CHAR.
3820 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3821 wider than 'int', as a compile-time check to prevent future regressions
3822 in this area.
3823
c5958d4c 3824 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3825
3826 Make sure a 64-bit char is never passed to CHAR_STRING.
3827 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3828 by silently ignoring the top 32 bits, allowing some values
3829 that were far too large to be valid characters.
3830 * character.h: Include <verify.h>.
3831 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3832 arguments are no wider than unsigned, as a compile-time check
3833 to prevent future regressions in this area.
3834 * data.c (Faset):
01103c44 3835 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3836 (Fsubst_char_in_region):
3837 * fns.c (concat):
3838 * xdisp.c (decode_mode_spec_coding):
3839 Adjust to CHAR_STRING's new requirement.
3840 * editfns.c (Finsert_char, Fsubst_char_in_region):
3841 * fns.c (concat): Check that character args are actually
3842 characters. Without this test, these functions did the wrong
3843 thing with wildly out-of-range values on 64-bit hosts.
3844
d37ca623
PE
3845 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3846 These casts should not be needed on 32-bit hosts, either.
3847 * keyboard.c (read_char):
3848 * lread.c (Fload): Remove casts to unsigned.
3849
ea204efb
PE
3850 * lisp.h (UNSIGNED_CMP): New macro.
3851 This fixes comparison bugs on 64-bit hosts.
3852 (ASCII_CHAR_P): Use it.
3853 * casefiddle.c (casify_object):
01103c44 3854 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3855 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3856 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3857 * dispextern.h (FACE_FROM_ID):
3858 * keyboard.c (read_char): Use UNSIGNED_CMP.
3859
41cb286c
PE
3860 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3861 not to EMACS_INT, to avoid GCC warning.
3862
4a1b9832
PE
3863 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3864
55daad71
PE
3865 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3866 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3867 isn't needed on 32-bit machines.
8f95c75c 3868
01103c44
PE
3869 * buffer.c (Fgenerate_new_buffer_name):
3870 Use EMACS_INT for count, not int.
0ceccced 3871 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3872
3873 * data.c (Qcompiled_function): Now static.
3874
c6f072e7
PE
3875 * window.c (window_body_lines): Now static.
3876
20ce5912
PE
3877 * image.c (gif_load): Rename local to avoid shadowing.
3878
9c4c5f81
PE
3879 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3880 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3881 * alloc.c (make_save_value): Integer argument is now of type
3882 ptrdiff_t, not int.
3883 (mark_object): Use ptrdiff_t, not int.
3884 * lisp.h (pD): New macro.
3885 * print.c (print_object): Use it.
3886
c0c5c8ae
PE
3887 * alloc.c: Use EMACS_INT, not int, to count objects.
3888 (total_conses, total_markers, total_symbols, total_vector_size)
3889 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3890 (total_free_floats, total_floats, total_free_intervals)
3891 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3892 Now EMACS_INT, not int. All uses changed.
3893 (Fgarbage_collect): Compute overall total using a double, so that
3894 integer overflow is less likely to be a problem. Check for overflow
3895 when converting back to an integer.
5a25e253
PE
3896 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3897 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3898 These were 'int' variables that could overflow on 64-bit hosts;
3899 they were never used, so remove them instead of repairing them.
211a0b2a 3900 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3901 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3902 Previously, this ceilinged at INT_MAX, but that doesn't work on
3903 64-bit machines.
e46bb31a 3904 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3905
c78baabf 3906 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3907 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3908 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3909 when a (possibly-narrower) signed value would do just as well.
3910 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3911
c9d624c6
PE
3912 * alloc.c: Catch some string size overflows that we were missing.
3913 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3914 for convenience in STRING_BYTES_MAX.
3915 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3916 The definition here is exact; the one in lisp.h was approximate.
3917 (allocate_string_data): Check for string overflow. This catches
3918 some instances we weren't catching before. Also, it catches
3919 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3920 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3921 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3922
c9d624c6
PE
3923 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3924 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3925 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3926
353032ce
PE
3927 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3928
2bccce07
PE
3929 * alloc.c (Fmake_string): Check for out-of-range init.
3930
0ac30604
SM
39312011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3932
3933 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3934
c195f2de
JD
39352011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3936
3937 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3938 xg_get_default_scrollbar_width.
3939
3940 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3941 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3942 (style_changed_cb): Call update_theme_scrollbar_width and call
3943 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3944 all frames (Bug#8505).
3945 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3946 Call gtk_window_set_resizable if HAVE_GTK3.
3947 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3948 and height if HAVE_GTK3 (Bug#8505).
3949 (scroll_bar_width_for_theme): New variable.
3950 (update_theme_scrollbar_width): New function.
3951 (xg_get_default_scrollbar_width): Move code to
3952 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3953 (xg_initialize): Call update_theme_scrollbar_width.
3954
3955 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3956
3957 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3958
e10ac9f1
MR
39592011-06-12 Martin Rudalics <rudalics@gmx.at>
3960
3961 * frame.c (make_frame): Call other_buffer_safely instead of
3962 other_buffer.
3963
3964 * window.c (temp_output_buffer_show): Call display_buffer with
3965 second argument Vtemp_buffer_show_specifiers and reset latter
3966 immediately after the call.
3967 (Vtemp_buffer_show_specifiers): New variable.
3968 (auto_window_vscroll_p, next_screen_context_lines)
3969 (Vscroll_preserve_screen_position): Remove leading asterisks from
3970 doc-strings.
3971
2d3c217e 39722011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3973
7b7f97e8 3974 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3975 * buffer.c (Qclone_number): Remove for now, as it's unused.
3976 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3977 (record_buffer): Remove unused local.
3978 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3979 (set_frame_buffer_list): Remove; unused.
3980 * frame.h (other_visible_frames): Remove decl.
3981 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3982 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3983 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3984 if HAVE_GPM.
3985 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3986 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3987 Define only if HAVE_GPM.
3988 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3989 (update_hints_inhibit): Remove; never set. All uses removed.
3990 * widgetprv.h (emacsFrameClassRec): Remove decl.
3991 * window.c (delete_deletable_window): Now returns void, since it
3992 wasn't returning anything.
3993 (compare_window_configurations): Remove unused locals.
3994 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3995 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3996 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3997 the same widths as pointers. This follows up on the 2011-05-06 patch.
3998 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3999 * xterm.h: Likewise.
4000 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4001
1384b89e
JB
40022011-06-12 Juanma Barranquero <lekktu@gmail.com>
4003
4004 * makefile.w32-in: Update dependencies.
4005 (LISP_H): Add lib/intprops.h.
4006
1100a63c
CY
40072011-06-11 Chong Yidong <cyd@stupidchicken.com>
4008
4009 * image.c (gif_load): Add animation frame delay to the metadata.
4010 (syms_of_image): Use DEFSYM. New symbol `delay'.
4011
6198ccd0
MR
40122011-06-11 Martin Rudalics <rudalics@gmx.at>
4013
4014 * window.c (delete_deletable_window): Re-add.
4015 (Fset_window_configuration): Rewrite to handle dead buffers and
4016 consequently deletable windows.
4017 (window_tree, Fwindow_tree): Remove. Supply functionality in
4018 window.el.
4019 (compare_window_configurations): Simplify code.
4020
b6e3633c
AS
40212011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4022
1ab0dee5
AS
4023 * image.c (imagemagick_load_image): Fix type mismatch.
4024 (Fimagemagick_types): Likewise.
4025
b6e3633c
AS
4026 * window.h (replace_buffer_in_windows): Declare.
4027
9397e56f
MR
40282011-06-11 Martin Rudalics <rudalics@gmx.at>
4029
4030 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4031 Qclone_number. Remove external declaration of Qdelete_window.
4032 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4033 code.
640c8776
SM
4034 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4035 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4036 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4037 buffer list implementation.
4038 (other_buffer_safely): New function.
4039 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4040 calls to replace_buffer_in_windows and
4041 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4042 if allowed.
4043 (record_buffer): Inhibit quitting and rewrite using quittable
4044 functions. Run Qbuffer_list_update_hook if allowed.
4045 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4046 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4047 Move switch-to-buffer to window.el.
9397e56f
MR
4048 (bury-buffer): Move to window.el.
4049 (Vbuffer_list_update_hook): New variable.
4050
4051 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4052 section.
4053
4054 * window.h (resize_frame_windows): Move up in code.
4055 (Fwindow_frame): Remove EXFUN.
4056 (replace_buffer_in_all_windows): Remove prototype.
4057 (replace_buffer_in_windows_safely): Add prototype.
4058
4059 * window.c: Declare Qdelete_window static again. Move down
4060 declaration of select_count.
4061 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4062 (Fother_window): Move to window.el.
4063 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4064 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4065 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4066 window.el.
4067 (replace_buffer_in_windows): Implement by calling
4068 Qreplace_buffer_in_windows.
4069 (replace_buffer_in_all_windows): Remove with some functionality
4070 moved into replace_buffer_in_windows_safely.
4071 (replace_buffer_in_windows_safely): New function.
4072 (select_window_norecord, select_frame_norecord): Move in front
4073 of run_window_configuration_change_hook. Remove now obsolete
4074 declarations.
640c8776
SM
4075 (Fset_window_buffer): Rewrite doc-string.
4076 Call Qrecord_window_buffer.
9397e56f
MR
4077 (keys_of_window): Move binding for other-window to window.el.
4078
b50691aa
CY
40792011-06-11 Chong Yidong <cyd@stupidchicken.com>
4080
4081 * dispextern.h (struct image): Replace data member, whose int_val
4082 and ptr_val fields were not used by anything, with a single
4083 lisp_val object.
4084
4085 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4086 (gif_clear_image, gif_load, imagemagick_load_image)
4087 (gs_clear_image, gs_load): Callers changed.
4088
3f754b86
PE
40892011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4090
cca69397
PE
4091 * buffer.h: Include <time.h>, for time_t.
4092 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4093
109e28d0
PE
4094 Fix minor problems found by static checking.
4095
60737f02
PE
4096 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4097
4b66faf3
PE
4098 Make identifiers static if they are not used in other modules.
4099 * data.c (Qcompiled_function, Qframe, Qvector):
4100 * image.c (QimageMagick, Qsvg):
4101 * minibuf.c (Qmetadata):
4102 * window.c (resize_window_check, resize_root_window): Now static.
4103 * window.h (resize_window_check, resize_root_window): Remove decls.
4104
109e28d0
PE
4105 * window.c (window_deletion_count, delete_deletable_window):
4106 Remove; unused.
46a4ce9e
PE
4107 (window_body_lines): Now static.
4108 (Fdelete_other_windows_internal): Mark vars as initialized.
4109 Make sure 'resize_failed' is initialized.
4110 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4111 (resize_window_apply): Remove unused local.
4112 * window.h (delete_deletable_window): Remove decl.
4113
109e28d0 4114 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4115 (imagemagick_load_image): Fix pointer signedness problem by changing
4116 last arg from unsigned char * to char *. All uses changed.
4117 Also, fix a local for similar reasons.
4118 Remove unused locals. Remove locals to avoid shadowing.
4119 (fn_rsvg_handle_free): Remove; unused.
4120 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4121 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4122
3f754b86
PE
4123 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4124
2547adb1
CY
41252011-06-10 Chong Yidong <cyd@stupidchicken.com>
4126
4127 * image.c (gif_load): Fix omitted cast error introduced by
4128 2011-06-06 change.
4129
2c8e37d4
MR
41302011-06-10 Martin Rudalics <rudalics@gmx.at>
4131
4132 * window.h (resize_proportionally, orig_total_lines)
4133 (orig_top_line): Remove from window structure.
4134 (set_window_height, set_window_width, change_window_heights)
4135 (Fdelete_window): Remove prototypes.
4136 (resize_frame_windows): Remove duplicate declaration.
4137
440a42e3
EZ
41382011-06-10 Eli Zaretskii <eliz@gnu.org>
4139
4140 * window.h (resize_frame_windows, resize_window_check)
4141 (delete_deletable_window, resize_root_window)
4142 (resize_frame_windows): Declare prototypes.
4143
4144 * window.c (resize_window_apply): Make definition be "static" to
4145 match the prototype.
4146
562dd5e9
MR
41472011-06-10 Martin Rudalics <rudalics@gmx.at>
4148
4149 * window.c: Remove declarations of Qwindow_size_fixed,
4150 window_min_size_1, window_min_size_2, window_min_size,
4151 size_window, window_fixed_size_p, enlarge_window, delete_window.
4152 Remove static from declaration of Qdelete_window, it's
4153 temporarily needed by Fbury_buffer.
4154 (replace_window): Don't assign orig_top_line and
4155 orig_total_lines.
4156 (Fdelete_window, delete_window): Remove. Window deletion is
4157 handled by window.el.
640c8776
SM
4158 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4159 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4160 (Fdelete_other_windows): Remove. Deleting other windows is
4161 handled by window.el.
4162 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4163 handled in window.el.
4164 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4165 Window minimum sizes are handled in window.el.
4166 (shrink_windows, size_window, set_window_height)
4167 (set_window_width, change_window_heights, window_height)
4168 (window_width, CURBEG, CURSIZE, enlarge_window)
4169 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4170 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4171 handled in window.el.
4172 (make_dummy_parent): Rename to make_parent_window and give it a
4173 second argument horflag.
4174 (make_window): Don't set resize_proportionally any more.
4175 (Fsplit_window): Remove. Windows are split in window.el.
4176 (save_restore_action, save_restore_orig_size)
4177 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4178 Resize mini windows in window.el.
4179 (grow_mini_window, shrink_mini_window): Implement by calling
4180 Qresize_root_window_vertically, resize_window_check and
4181 resize_window_apply.
640c8776
SM
4182 (saved_window, Fset_window_configuration, save_window_save):
4183 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4184 resize_proportionally.
4185 (window_min_height, window_min_width): Move to window.el.
4186 (keys_of_window): Move bindings for delete-other-windows,
4187 split-window, delete-window and enlarge-window to window.el.
4188
4189 * buffer.c: Temporarily extern Qdelete_window.
4190 (Fbury_buffer): Temporarily call Qdelete_window instead of
4191 Fdelete_window (Fbury_buffer will move to window.el soon).
4192
4193 * frame.c (set_menu_bar_lines_1): Remove code handling
4194 orig_top_line and orig_total_lines.
4195
4196 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4197 set_window_height but set heights directly.
4198 (change_frame_size_1): Use resize_frame_windows.
4199
4200 * xdisp.c (init_xdisp): Don't use set_window_height but set
4201 heights directly.
4202
640c8776
SM
4203 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4204 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4205 run_window_configuration_change_hook.
4206
4207 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4208 instead of change_window_heights and run
4209 run_window_configuration_change_hook.
4210
1a13852e
MR
42112011-06-09 Martin Rudalics <rudalics@gmx.at>
4212
4213 * window.c (replace_window): Rename second argument REPLACEMENT to
4214 NEW. New third argument SETFLAG. Rewrite.
4215 (delete_window, make_dummy_parent): Call replace_window with
4216 third argument 1.
4217 (window_list_1): Move down in code.
4218 (run_window_configuration_change_hook): Move set_buffer part
4219 before select_frame_norecord part in order to unwind correctly.
4220 Rename count1 to count.
4221 (recombine_windows, delete_deletable_window, resize_root_window)
4222 (Fdelete_other_windows_internal)
4223 (Frun_window_configuration_change_hook, make_parent_window)
4224 (resize_window_check, resize_window_apply, Fresize_window_apply)
4225 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4226 (Fdelete_window_internal, Fresize_mini_window_internal):
4227 New functions.
1a13852e
MR
4228 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4229
f3d1777e
MR
42302011-06-08 Martin Rudalics <rudalics@gmx.at>
4231
496e208e
MR
4232 * window.h (window): Add some new members to window structure -
4233 normal_lines, normal_cols, new_total, new_normal, clone_number,
4234 splits, nest, prev_buffers, next_buffers.
4235 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4236 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4237
f3d1777e
MR
4238 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4239 Remove.
496e208e
MR
4240 (make_dummy_parent): Set new members of windows structure.
4241 (make_window): Move down in code. Handle new members of window
4242 structure.
4243 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4244 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4245 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4246 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4247 (Fset_window_next_buffers, Fset_window_clone_number):
4248 New functions.
496e208e
MR
4249 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4250 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4251 Doc-string fixes.
4252 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4253 Argument WINDOW can be now internal window too.
4254 (Fwindow_use_time): Move up in code.
4255 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4256 Rewrite doc-string.
4257 (Fset_window_configuration, saved_window)
4258 (Fcurrent_window_configuration, save_window_save): Handle new
4259 members of window structure.
b9e809c2
MR
4260 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4261 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4262 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4263 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4264 Qget_mru_window, Qresize_root_window,
4265 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4266 Qauto_buffer_name; staticpro them.
f3d1777e 4267
abde8f8c
MR
42682011-06-07 Martin Rudalics <rudalics@gmx.at>
4269
4270 * window.c (Fwindow_total_size, Fwindow_left_column)
4271 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4272 (Fwindow_list_1): New functions.
4273 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4274 (Fwindow_width, Fscroll_left, Fscroll_right):
4275 Use window_body_cols instead of window_box_text_cols.
4276 (delete_window, Fset_window_configuration):
4277 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4278 (delete_all_subwindows): Take a window as argument and not a
4279 structure. Rewrite.
190b47e6
MR
4280 (window_loop): Remove handling of GET_LRU_WINDOW and
4281 GET_LARGEST_WINDOW.
4282 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4283
4284 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4285 window_box_text_cols. delete_all_subwindows now takes a
4286 Lisp_Object as argument.
abde8f8c 4287
640c8776
SM
4288 * indent.c (compute_motion, Fcompute_motion):
4289 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4290
fa8a67e6
MR
4291 * frame.c (delete_frame): Call delete_all_subwindows with root
4292 window as argument.
4293
a54e3482
DC
42942011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4295
4296 * fns.c (Fputhash): Document return value.
4297
60002bf5
CY
42982011-06-06 Chong Yidong <cyd@stupidchicken.com>
4299
4300 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4301
0c671da6 43022011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4303
b862a52a 4304 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4305
be44ca6c
PE
4306 Check for overflow when converting integer to cons and back.
4307 * charset.c (Fdefine_charset_internal, Fdecode_char):
4308 Use cons_to_unsigned to catch overflow.
4309 (Fencode_char): Use INTEGER_TO_CONS.
4310 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4311 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4312 * data.c (long_to_cons, cons_to_long): Remove.
4313 (cons_to_unsigned, cons_to_signed): New functions.
4314 These signal an error for invalid or out-of-range values.
4315 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4316 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4317 * font.c (Ffont_variation_glyphs):
4318 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4319 * lisp.h: Include <intprops.h>.
4320 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4321 (cons_to_signed, cons_to_unsigned): New decls.
4322 (long_to_cons, cons_to_long): Remove decls.
4323 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4324 (Fprimitive_undo): Use CONS_TO_INTEGER.
4325 * xfns.c (Fx_window_property): Likewise.
4326 * xselect.c: Include <limits.h>.
4327 (x_own_selection, selection_data_to_lisp_data):
4328 Use INTEGER_TO_CONS.
4329 (x_handle_selection_request, x_handle_selection_clear)
4330 (x_get_foreign_selection, Fx_disown_selection_internal)
4331 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4332 (lisp_data_to_selection_data): Use cons_to_unsigned.
4333 (x_fill_property_data): Use cons_to_signed.
4334 Report values out of range.
4335
d1f3d2af
PE
4336 Check for buffer and string overflow more precisely.
4337 * buffer.h (BUF_BYTES_MAX): New macro.
4338 * lisp.h (STRING_BYTES_MAX): New macro.
4339 * alloc.c (Fmake_string):
4340 * character.c (string_escape_byte8):
4341 * coding.c (coding_alloc_by_realloc):
4342 * doprnt.c (doprnt):
4343 * editfns.c (Fformat):
4344 * eval.c (verror):
4345 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4346 since they may not be the same number.
4347 * editfns.c (Finsert_char):
4348 * fileio.c (Finsert_file_contents):
4349 Likewise for BUF_BYTES_MAX.
4350
dd52fcea
PE
4351 * image.c: Use ptrdiff_t, not int, for sizes.
4352 (slurp_file): Switch from int to ptrdiff_t.
4353 All uses changed.
4354 (slurp_file): Check that file size fits in both size_t (for
4355 malloc) and ptrdiff_t (for sanity and safety).
4356
7f9bbdbb
PE
4357 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4358 if b->modtime has its maximal value.
4359
dfe18f82
PE
4360 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4361
84acfcf0
PE
4362 Don't assume time_t can fit into int.
4363 * buffer.h (struct buffer.modtime): Now time_t, not int.
4364 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4365 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4366
ccd9a01a
PE
4367 Minor fixes for signed vs unsigned integers.
4368 * character.h (MAYBE_UNIFY_CHAR):
4369 * charset.c (maybe_unify_char):
4370 * keyboard.c (read_char, reorder_modifiers):
4371 XINT -> XFASTINT, since the integer must be nonnegative.
4372 * ftfont.c (ftfont_spec_pattern):
4373 * keymap.c (access_keymap, silly_event_symbol_error):
4374 XUINT -> XFASTINT, since the integer must be nonnegative.
4375 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4376 since it makes no difference and we prefer signed.
4377 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4378 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4379 nonnegative.
4380
d6d100dd
SM
43812011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4382
4383 * window.h (Fwindow_frame): Declare.
4384
2b6148e4
PE
43852011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4386
4387 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4388 (SPARE_MEMORY): Always define.
4389 (LARGE_REQUEST): Remove.
4390 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4391
f230ecc9
MR
43922011-06-06 Martin Rudalics <rudalics@gmx.at>
4393
727e958e
MR
4394 * lisp.h: Move EXFUNS for Fframe_root_window,
4395 Fframe_first_window and Fset_frame_selected_window to window.h.
4396
4397 * window.h: Move EXFUNS for Fframe_root_window,
4398 Fframe_first_window and Fset_frame_selected_window here from
4399 lisp.h.
4400
4401 * frame.c (Fwindow_frame, Fframe_first_window)
4402 (Fframe_root_window, Fframe_selected_window)
4403 (Fset_frame_selected_window): Move to window.c.
4404 (Factive_minibuffer_window): Move to minibuf.c.
4405 (Fother_visible_frames_p): New function.
4406
4407 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4408
f230ecc9
MR
4409 * window.c (decode_window, decode_any_window): Move up in code.
4410 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4411 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4412 (Fwindow_buffer): Move up and rewrite doc-string.
4413 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4414 (Fwindow_prev): New functions.
727e958e
MR
4415 (Fwindow_frame): Move here from frame.c. Accept any window as
4416 argument.
4417 (Fframe_root_window, Fframe_first_window)
4418 (Fframe_selected_window): Move here from frame.c. Accept frame
4419 or arbitrary window as argument. Update doc-strings.
4420 (Fminibuffer_window): Move up in code.
4421 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4422 (Fset_frame_selected_window): Move here from frame.c.
4423 Marginal rewrite.
727e958e
MR
4424 (Fselected_window, select_window, Fselect_window): Move up in
4425 code. Minor doc-string fixes.
f230ecc9 4426
4d09bcf6
PE
44272011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4428
4429 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4430 Do not assume that spare memory exists; that assumption is valid
4431 only if SYSTEM_MALLOC.
4432 (LARGE_REQUEST): New macro, so that the issue of large requests
4433 is separated from the issue of spare memory.
4434
810928a2
AS
44352011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4436
172418ad
AS
4437 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4438 format. (Bug#8806)
4439
43f862f7
AS
4440 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4441
810928a2
AS
4442 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4443 before statements.
4444
a059fe24
JD
44452011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4446
4447 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4448
4449 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4450
4451 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4452 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4453
989bf368
JB
44542011-06-05 Juanma Barranquero <lekktu@gmail.com>
4455
4456 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4457
4b80f674
CY
44582011-06-04 Chong Yidong <cyd@stupidchicken.com>
4459
4460 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4461 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4462 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4463 New error handlers.
4b80f674
CY
4464 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4465 Obey Vx_select_enable_clipboard_manager. Catch errors in
4466 x_clipboard_manager_save (Bug#8779).
4467 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4468 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4469
99a33b77 44702011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4471
4472 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4473
99a33b77 44742011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4475
4476 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4477 in the current matrix if keep_current_p is non-zero.
4478
8264569d
EZ
44792011-06-04 Eli Zaretskii <eliz@gnu.org>
4480
4481 * bidi.c (bidi_level_of_next_char): Fix last change.
4482
57f97249
EZ
44832011-06-03 Eli Zaretskii <eliz@gnu.org>
4484
fec2107c 4485 Support bidi reordering of text covered by display properties.
57f97249 4486
fec2107c
EZ
4487 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4488 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4489 (bidi_cache_search, bidi_cache_iterator_state)
4490 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4491 (bidi_level_of_next_char, bidi_move_to_visually_next):
4492 Support character positions inside a run of characters covered by a
fec2107c
EZ
4493 display string.
4494 (bidi_paragraph_init, bidi_resolve_explicit_1)
4495 (bidi_level_of_next_char): Call bidi_fetch_char and
4496 bidi_fetch_char_advance instead of FETCH_CHAR and
4497 FETCH_CHAR_ADVANCE.
4498 (bidi_init_it): Initialize new members.
4499 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4500 definitions.
4501 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4502 instead of using explicit *_CHAR codes.
d6d100dd
SM
4503 (bidi_resolve_explicit, bidi_resolve_weak):
4504 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4505 bidirectional text is supported only in multibyte buffers.
4506 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4507 it to initialize the frame_window_p member of struct bidi_it.
4508 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4509 (bidi_resolve_explicit, bidi_resolve_weak)
4510 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4511 bidi_it->nchars is non-positive.
4512 (bidi_level_of_next_char): Don't try to lookup the cache for the
4513 next/previous character if nothing is cached there yet, or if we
4514 were just reseat()'ed to a new position.
c40e2fb2 4515
0e14fe90
EZ
4516 * xdisp.c (set_cursor_from_row): Set start and stop points
4517 according to the row's direction when priming the loop that looks
4518 for the glyph on which to display cursor.
4519 (single_display_spec_intangible_p): Function deleted.
4520 (display_prop_intangible_p): Reimplement to call
4521 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4522 Accept 3 additional arguments needed by handle_display_spec.
4523 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4524 values: lists, `(when COND...)' forms, etc.
4525 (single_display_spec_string_p): Support property values that are
4526 lists with the argument STRING its top-level element.
4527 (display_prop_string_p): Fix the condition for processing a
4528 property that is a list to be consistent with handle_display_spec.
fec2107c 4529 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4530 last portion of handle_display_prop.
4531 (compute_display_string_pos): Accept additional argument
4532 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4533 value of a `display' property is a "replacing spec".
4534 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4535 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4536 the display property, but just return a value indicating whether
4537 the display property will replace the characters it covers.
4538 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4539 frame_window_p members of struct bidi_it.
d6d100dd
SM
4540 (compute_display_string_pos, compute_display_string_end):
4541 New functions.
fec2107c
EZ
4542 (push_it): Accept second argument POSITION, where pop_it should
4543 jump to continue iteration.
4544 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4545
fec2107c
EZ
4546 * keyboard.c (adjust_point_for_property): Adjust the call to
4547 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4548
4549 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4550 (bidi_init_it): Update prototypes.
4551 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4552 (compute_display_string_pos, compute_display_string_end):
4553 Declare prototypes.
fec2107c
EZ
4554 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4555 EMACS_INT.
fc6f18ce 4556
40087514 45572011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4558
57f53182
PE
4559 Malloc failure behavior now depends on size of allocation.
4560 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4561 * lisp.h: Change signatures accordingly.
4562 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4563 All callers changed. (Bug#8762)
4564
4565 * gnutls.c: Use Emacs's memory allocators.
4566 Without this change, the gnutls library would invoke malloc etc.
4567 directly, which causes problems on non-SYNC_INPUT hosts, and which
4568 runs afoul of improving memory_full behavior. (Bug#8761)
4569 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4570 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4571 xfree instead of the default malloc, realloc, free.
4572 (Fgnutls_boot): No need to check for memory allocation failure,
4573 since xmalloc does that for us.
4574
ac32cd99 4575 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4576 * category.c (hash_get_category_set):
4577 * ccl.c (ccl_driver):
4578 * charset.c (Fdefine_charset_internal):
4579 * charset.h (struct charset.hash_index):
4580 * composite.c (get_composition_id, gstring_lookup_cache)
4581 (composition_gstring_put_cache):
4582 * composite.h (struct composition.hash_index):
4583 * dispextern.h (struct image.hash):
4584 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4585 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4586 (hashfn_equal, hashfn_user_defined, make_hash_table)
4587 (maybe_resize_hash_table, hash_lookup, hash_put)
4588 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4589 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4590 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4591 * image.c (make_image, search_image_cache, lookup_image)
4592 (xpm_put_color_table_h):
4593 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4594 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4595 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4596 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4597 * alloc.c (allocate_vectorlike):
4598 Check for overflow in vector size calculations.
4599 * ccl.c (ccl_driver):
4600 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4601 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4602 need to be updated by these changes.
40087514
PE
4603 * fns.c (make_hash_table, maybe_resize_hash_table):
4604 Check for integer overflow with large hash tables.
0de4bb68
PE
4605 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4606 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4607 (SXHASH_REDUCE): New macro.
4608 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4609 Use it instead of discarding useful hash info with large hash values.
4610 (sxhash_float): New function.
4611 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4612 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4613 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4614 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4615 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4616 Adjust signatures to match updated version of code.
4617 (consing_since_gc): Now EMACS_INT, since a single hash table can
4618 use more than INT_MAX bytes.
4619
698d32e2
DN
46202011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4621
4622 Make it possible to build with GCC-4.6+ -O2 -flto.
4623
4624 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4625
fd6fa53f
SM
46262011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4627
4628 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4629 Call minibuffer-inactive-mode.
4630
864db017
JB
46312011-05-31 Juanma Barranquero <lekktu@gmail.com>
4632
4633 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4634 Update dependencies.
4635
2ad0baf4
DN
46362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4637
4638 * data.c (init_data): Remove code for UTS, this system is not
4639 supported anymore.
4640
4fcc2638
DN
46412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4642
4643 Don't force ./temacs to start in terminal mode.
4644
4645 * frame.c (make_initial_frame): Initialize faces in all cases, not
4646 only when CANNOT_DUMP is defined.
4647 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4648
c56e0fd5
DN
46492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4650
4651 * dispnew.c (add_window_display_history): Use const for the string
4652 pointer. Remove declaration, not needed.
4653
333d54da 46542011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4655
55d4c1b2 4656 Use 'inline', not 'INLINE'.
333d54da 4657 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4658 * alloc.c, fontset.c (INLINE): Remove.
4659 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4660 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4661 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4662 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4663 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4664
738db178
DN
46652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4666
4667 Make it possible to run ./temacs.
4668
4669 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4670 syms_of_callproc does the same thing. Remove test for
4671 "initialized", do it in the caller.
4672 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4673
620c53a6
SM
46742011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4675
4676 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4677 (read_minibuf): Use get_minibuffer.
4678 (syms_of_minibuf): Use DEFSYM.
4679 (Qmetadata): New var.
4680 * data.c (Qbuffer): Don't make it static.
4681 (syms_of_data): Use DEFSYM.
4682
e003a292
PE
46832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4684
4685 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4686 (CCL_CODE_MIN): New macro.
4687
ed008a6d
PE
46882011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4689
3687c2ef
PE
4690 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4691
ed008a6d
PE
4692 * eval.c (Qdebug): Now static.
4693 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4694 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4695 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4696
d66c4c7c
CY
46972011-05-29 Chong Yidong <cyd@stupidchicken.com>
4698
4699 * image.c: Various fixes to ImageMagick code comments.
4700 (Fimagemagick_types): Doc fix.
4701
5fbc2025
PE
47022011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4703
0196f88a
PE
4704 Minor fixes prompted by GCC 4.6.0 warnings.
4705
4706 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4707
5fbc2025
PE
4708 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4709 (x_clipboard_manager_save_all): Move extern decl to ...
4710 * xterm.h: ... here, so that it can be checked for consistency.
4711
1dd3c2d9
CY
47122011-05-29 Chong Yidong <cyd@stupidchicken.com>
4713
4714 * xselect.c (x_clipboard_manager_save_frame)
4715 (x_clipboard_manager_save_all): New functions.
4716 (Fx_clipboard_manager_save): Lisp function deleted.
4717
4718 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4719 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4720
4721 * xterm.h: Update prototype.
4722
5ba6571d
WX
47232011-05-28 William Xu <william.xwl@gmail.com>
4724
4725 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4726 exiting (Bug#8239).
4727
3eaff834
JM
47282011-05-28 Jim Meyering <meyering@redhat.com>
4729
e1900994 4730 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4731 * fns.c (to_uchar): Define.
4732 (crypto_hash_function): Use it to convert some newly-signed
4733 variables to unsigned, to avoid sign-extension bugs. For example,
4734 without this change, (md5 "truc") would evaluate to
4735 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4736 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4737 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4738
0f6990a7
PE
47392011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4740
4741 Integer overflow fixes.
c8a9ca5a 4742
08686060
PE
4743 * dbusbind.c: Serial number integer overflow fixes.
4744 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4745 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4746 to hold a serial number that is too large for a fixnum.
4747 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4748 Check for serial numbers out of range. Decode any serial number
59568bf0 4749 that was so large that it became a float. (Bug#8722)
08686060 4750
2d1fc3c7
PE
4751 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4752 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4753 Use XFASTINT rather than XUINT when numbers are nonnegative.
4754 (xd_append_arg, Fdbus_method_return_internal):
4755 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4756 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4757 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4758 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4759 (Bug#8722)
2d1fc3c7 4760
c8a9ca5a
PE
4761 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4762
519e1d69
PE
4763 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4764
30569699
PE
4765 ccl: add integer overflow checks
4766 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4767 (IN_INT_RANGE): New macros.
4768 (ccl_driver): Use them to check for integer overflow when
4769 decoding a CCL program. Many of the new checks are whether XINT (x)
4770 fits in int; it doesn't always, on 64-bit hosts. The new version
4771 doesn't catch all possible integer overflows, but it's an
847044ea 4772 improvement. (Bug#8719)
30569699 4773
c11285dc
PE
4774 * alloc.c (make_event_array): Use XINT, not XUINT.
4775 There's no need for unsigned here.
4776
fdccd48e
PE
4777 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4778 This follows up to the 2011-05-06 change that substituted uintptr_t
4779 for EMACS_INT. This case wasn't caught back then.
4780
37910ab2
PE
4781 Rework Fformat to avoid integer overflow issues.
4782 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4783 now (part of C89). Include <verify.h>.
4784 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4785 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4786 (Fformat): Avoid the prepass trying to compute sizes; it was only
4787 approximate and thus did not catch overflow reliably. Instead, walk
4788 through the format just once, formatting and computing sizes as we go,
4789 checking for integer overflow at every step, and allocating a larger
4790 buffer as needed. Keep track separately whether the format is
4791 multibyte. Keep only the most-recently calculated precision, rather
4792 than them all. Record whether each argument has been converted to
4793 string. Use EMACS_INT, not int, for byte and char and arg counts.
4794 Support field widths and precisions larger than INT_MAX. Avoid
4795 sprintf's undefined behavior with conversion specifications such as %#d
4796 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4797 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4798 formatting out-of-range floating point numbers with int
9173deec 4799 formats. (Bug#8668)
37910ab2 4800
2e6578fb
PE
4801 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4802
0ae6bdee
PE
4803 * data.c: Avoid integer truncation in expressions involving floats.
4804 * data.c: Include <intprops.h>.
4805 (arith_driver): When there's an integer overflow in an expression
4806 involving floating point, convert the integers to floating point
4807 so that the resulting value does not suffer from catastrophic
4808 integer truncation. For example, on a 64-bit host (* 4
4809 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4810 Do not rely on undefined behavior after integer overflow.
4811
de883a70
PE
4812 merge count_size_as_multibyte, parse_str_to_multibyte
4813 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4814 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4815 Check for integer overflow.
4816 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4817 since it's now a duplicate of the other. This is more of
4818 a character than a buffer op, so better that it's in character.c.
4819 * fns.c, print.c: Adjust to above changes.
4820
2ff916cb
PE
48212011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4822
4823 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4824
f1b54466
PE
48252011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4826
fb1ac845
PE
4827 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4828 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4829 (x_clipboard_manager_save): Now static.
4830 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4831
f1b54466
PE
4832 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4833 (crypto_hash_function): Now static.
4834 Fix pointer signedness problems. Avoid unnecessary initializations.
4835
a9f737ee
CY
48362011-05-27 Chong Yidong <cyd@stupidchicken.com>
4837
4838 * termhooks.h (Vselection_alist): Make it terminal-local.
4839
4840 * terminal.c (create_terminal): Initialize it.
4841
4842 * xselect.c: Support for clipboard managers.
4843 (Vselection_alist): Move to termhooks.h as terminal-local var.
4844 (LOCAL_SELECTION): New macro.
4845 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4846 (symbol_to_x_atom): Remove gratuitous arg.
4847 (x_handle_selection_request, lisp_data_to_selection_data)
4848 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4849 (x_own_selection, x_get_local_selection, x_convert_selection):
4850 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4851 (some_frame_on_display): Delete unused function.
4852 (Fx_own_selection_internal, Fx_get_selection_internal)
4853 (Fx_disown_selection_internal, Fx_selection_owner_p)
4854 (Fx_selection_exists_p): New optional frame arg.
4855 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4856 (x_handle_selection_clear): Don't treat other terminals with the
4857 same keyboard specially. Use the terminal-local Vselection_alist.
4858 (x_clear_frame_selections): Use Frun_hook_with_args.
4859
4860 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4861
4862 * xterm.h: Add support for those atoms.
4863
e067f0c1
CY
48642011-05-26 Chong Yidong <cyd@stupidchicken.com>
4865
4866 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4867 (converted_selections, conversion_fail_tag): New global variables.
4868 (x_selection_request_lisp_error): Free the above.
4869 (x_get_local_selection): Remove unnecessary code.
4870 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4871 of converted selections stored in converted_selections.
4872 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4873 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4874 (x_convert_selection): New function.
4875 (x_handle_selection_event): Simplify.
4876 (x_get_foreign_selection): Don't ignore incoming requests while
4877 waiting for an answer; this will fail when we implement
4878 SAVE_TARGETS, and seems unnecessary anyway.
4879 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4880 (Vx_sent_selection_functions): Doc fix.
4881
0f4aebc0
LL
48822011-05-26 Leo Liu <sdl.web@gmail.com>
4883
4884 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4885
e61124cd
YM
48862011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4887
4888 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4889
4890 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4891 for fringe update if it has periodic bitmap.
ac389d0c 4892 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4893 and fringe_bitmap_periodic_p.
4894
4895 * fringe.c (get_fringe_bitmap_data): New function.
4896 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4897 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4898 row. Mark glyph row for fringe update if periodicity changed.
4899
4900 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4901 for fringe update unless it has periodic bitmap.
4902
f16d9837
KH
49032011-05-25 Kenichi Handa <handa@m17n.org>
4904
4905 * xdisp.c (get_next_display_element): Set correct it->face_id for
4906 a static composition.
4907
e1b90ef6
LL
49082011-05-24 Leo Liu <sdl.web@gmail.com>
4909
4910 * deps.mk (fns.o):
4911 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4912
4913 * fns.c (crypto_hash_function, Fsha1): New function.
4914 (Fmd5): Use crypto_hash_function.
4915 (syms_of_fns): Add Ssha1.
4916
7400048f
PE
49172011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4918
4919 * gnutls.c: Remove unused macros.
4920 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4921 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4922 Remove macros that are defined and never used.
4923 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4924
abb71cf4
CY
49252011-05-22 Chong Yidong <cyd@stupidchicken.com>
4926
4927 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4928 (Fx_get_selection_internal): Minor cleanup.
4929 (Fx_own_selection_internal): Rename arguments for consistency with
4930 select.el.
4931
6307db39
PE
49322011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4933
4934 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4935
f3d4e0a4
CY
49362011-05-22 Chong Yidong <cyd@stupidchicken.com>
4937
4938 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4939
4d8ade89
YM
49402011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4941
4942 * dispnew.c (scrolling_window): Don't exclude the case that the
4943 last enabled row in the desired matrix touches the bottom boundary.
4944
32078c8d
GM
49452011-05-21 Glenn Morris <rgm@gnu.org>
4946
4947 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4948 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4949 and add some more files.
32078c8d 4950
7285dc67
EZ
49512011-05-20 Eli Zaretskii <eliz@gnu.org>
4952
4953 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4954 report_file_error introduced by the change from 2011-05-07.
4955
89d1bd22
PE
49562011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4957
4958 * systime.h (Time): Define only if emacs is defined.
4959 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4960 where the include path doesn't have X11/X.h by default. See
4961 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4962
e23640bb 49632011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4964
4965 * composite.c (find_automatic_composition): Fix previous change.
4966
b9704ad9
GM
49672011-05-20 Glenn Morris <rgm@gnu.org>
4968
4969 * lisp.mk: New file, split from Makefile.in.
4970 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4971 (shortlisp): Remove.
4972 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4973
4a720484
GM
49742011-05-19 Glenn Morris <rgm@gnu.org>
4975
4976 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4977 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4978 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4979 (lisp): Set the order to that of loadup.el.
4980 (shortlisp): Make it a copy of $lisp.
4981 (SOME_MACHINE_LISP): Remove.
4982 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4983 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4984
a28d4396
KH
49852011-05-18 Kenichi Handa <handa@m17n.org>
4986
4987 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4988 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4989 (find_automatic_composition): Mostly rewrite for efficiency.
4990
a2b1fa8e
JB
49912011-05-18 Juanma Barranquero <lekktu@gmail.com>
4992
4993 * makefile.w32-in: Update dependencies.
4994
8e1f5610
CS
49952011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4996
4997 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4998 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4999
7025ee00 50002011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5001
cdfa6eab
PE
5002 Fix some integer overflow issues, such as string length overflow.
5003
06d6db33
PE
5004 * insdel.c (count_size_as_multibyte): Check for string overflow.
5005
2b4560a8
PE
5006 * character.c (lisp_string_width): Check for string overflow.
5007 Use EMACS_INT, not int, for string indexes and lengths; in
5008 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5009 the resulting string length overflows an EMACS_INT; instead,
5010 report a string overflow if no precision given. When checking for
5011 precision exhaustion, use a check that cannot possibly have
5012 integer overflow. (Bug#8675)
5013 * character.h (lisp_string_width): Adjust to new signature.
5014
cb93f9be
PE
5015 * alloc.c (string_overflow): New function.
5016 (Fmake_string): Use it. This doesn't change behavior, but saves
5017 a few bytes and will simplify future changes.
5018 * character.c (string_escape_byte8): Likewise.
5019 * lisp.h (string_overflow): New decl.
5020
1a1f3366
PE
5021 Fixups, following up to the user-interface timestamp change.
5022 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5023 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5024 * msdos.c (mouse_get_pos): Likewise.
5025 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5026 * w32gui.h (Time): Define by including "systime.h" rather than by
5027 declaring it ourselves. (Bug#8664)
5028
d4e3e4d3
PE
5029 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5030 * image.c (clear_image_cache): Likewise.
5031
f6a24d19
PE
5032 * term.c (term_mouse_position): Don't assume time_t wraparound.
5033
08dc5ae6
PE
5034 Be more systematic about user-interface timestamps.
5035 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5036 and sometimes 'EMACS_UINT', to represent these timestamps.
5037 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5038 This makes the code easier to follow, and makes it easier to catch
5039 integer overflow bugs such as Bug#8664.
5040 * frame.c (Fmouse_position, Fmouse_pixel_position):
5041 Use Time, not unsigned long, for user-interface timestamps.
5042 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5043 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5044 * keyboard.h (last_event_timestamp): Likewise.
5045 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5046 * menu.h (xmenu_show): Likewise.
5047 * term.c (term_mouse_position): Likewise.
5048 * termhooks.h (struct input_event.timestamp): Likewise.
5049 (struct terminal.mouse_position_hook): Likewise.
5050 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5051 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5052 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5053 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5054 what it was before.
5055 * menu.h, termhooks.h: Include "systime.h", for Time.
5056
8e55734a
PE
5057 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5058 Don't assume that the difference between two unsigned long values
5059 can fit into an integer. At this point, we know button_down_time
5060 <= event->timestamp, so the difference must be nonnegative, so
5061 there's no need to cast the result if double-click-time is
5062 nonnegative, as it should be; check that it's nonnegative, just in
5063 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5064 apart (about 25 days). (Bug#8664)
8e55734a 5065
841f1b75 5066 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5067 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5068
3e26f69c
PE
5069 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5070 that always fit in int. Use a sentinel instead of a counter, to
5071 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5072 * frame.h (struct frame): Use int for menu_bar_items_used
5073 instead of EMACS_INT, since it always fits in int.
3e26f69c 5074
5cc152c0
PE
5075 * menu.c (grow_menu_items): Check for int overflow.
5076
d89eb65e
PE
5077 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5078
5235bd3e
PE
5079 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5080 Before, the code was not consistent. These values cannot exceed
5081 2**31 - 1 so there's no need to make them unsigned.
5082 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5083 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5084 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5085 as modifiers.
5086 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5087
bc827e23
PE
5088 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5089 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5090 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5091 presumably because the widths might not match.
5092
78eb494e
PE
5093 * window.c (size_window): Avoid needless test at loop start.
5094
04f2d78b
CB
50952011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5096
5097 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5098
d2fc7e3d 50992011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5100
5101 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5102
d2fc7e3d 51032011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5104
5105 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5106 `width' to `bar_area_x' and `bar_area_width', respectively.
5107 (x_scroll_run): Take account of fringe background extension.
5108
04f2d78b
CB
5109 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5110 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5111 `bar_area_width', respectively.
5112 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5113 background extension.
5114
79b70037
GM
51152011-05-10 Jim Meyering <meyering@redhat.com>
5116
5117 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5118
2f142cc5
JB
51192011-05-10 Juanma Barranquero <lekktu@gmail.com>
5120
5121 * image.c (Finit_image_library): Return t for built-in image types,
5122 like pbm and xbm. (Bug#8640)
5123
57679c86
AS
51242011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5125
5126 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5127
888c9e86
EZ
51282011-05-07 Eli Zaretskii <eliz@gnu.org>
5129
b0512a1d
EZ
5130 * w32console.c (Fset_screen_color): Doc fix.
5131 (Fget_screen_color): New function.
5132 (syms_of_ntterm): Defsubr it.
5133
7285dc67
EZ
5134 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5135 unlink the temporary file if Fcall_process didn't create it in the
5136 first place.
5137 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5138 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5139 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5140 cue to call_process_cleanup not to close that handle.
5141
4d3fcc8e
BK
51422011-05-07 Ben Key <bkey76@gmail.com>
5143
5144 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5145 one of two shell specific rules, either bootstrap-temacs-CMD or
5146 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5147 to the previous implementation of the bootstrap-temacs rule.
5148 The bootstrap-temacs-CMD rule is similar to the previous
5149 implementation of the bootstrap-temacs rule except that it
5150 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5151 variable.
5152
5153 These changes, along with some changes to nt/configure.bat,
5154 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5155 earlier fix to add support for --cflags and --ldflags options
5156 that include quotes so that it works whether make uses cmd or
5157 sh as the shell.
5158
b4289b64
MA
51592011-05-06 Michael Albinus <michael.albinus@gmx.de>
5160
5161 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5162 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5163 is a constant.
5164 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5165 a string. Handle both cases.
5166 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5167 (Fdbus_register_method): Use Qinvalid_function.
5168
af4c0e28
JB
51692011-05-06 Juanma Barranquero <lekktu@gmail.com>
5170
5171 * makefile.w32-in: Update dependencies.
5172 (LISP_H): Add inttypes.h and stdin.h.
5173 (PROCESS_H): Add unistd.h.
5174
c51453d9
EZ
51752011-05-06 Eli Zaretskii <eliz@gnu.org>
5176
5177 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5178 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5179
8ff0ac3c 51802011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5181
4c4b566b
PE
5182 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5183
aab2b9b5
PE
5184 * term.c (vfatal): Remove stray call to va_end.
5185 It's not needed and the C Standard doesn't allow it here anyway.
5186
c378da0b
PE
5187 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5188 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5189
288b08c7
PE
5190 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5191 bytes.
5192
e3601888
PE
5193 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5194
db6c0e74
PE
5195 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5196
dd5963ea
PE
5197 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5198
88c9450f
PE
5199 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5200
2f9442b8
PE
5201 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5202
c032b5f8
PE
5203 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5204 * charset.c (Fdefine_charset_internal): Don't initialize
5205 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5206 32-bit int (Bug#8600).
a108c10b
PE
5207
5208 * lread.c (read_integer): Be more consistent with string-to-number.
5209 Use string_to_number to do the actual conversion; this avoids
5210 rounding errors and fixes some other screwups. Without this fix,
5211 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5212 (digit_to_number): Move earlier, for benefit of read_integer.
5213 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5214 not a digit in any supported base. (Bug#8602)
a108c10b 5215
ad5f9eea
PE
5216 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5217
aec1708a
PE
5218 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5219 to match comment at start of function. This also removes a
5220 GCC warning about overflow in a 32+64-bit port.
5221
47be4ab5
PE
5222 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5223
371cac43
PE
5224 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5225 Reported by Stefan Monnier in
5226 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5227 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5228 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5229
d01a7826
PE
5230 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5231 (EMACS_UINTPTR): Likewise, with uintptr_t.
5232
7fd47d5c
PE
5233 * lisp.h: Prefer 64-bit EMACS_INT if available.
5234 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5235 on 32-bit hosts that have 64-bit int, so that they can access
5236 large files.
122b0c86
PE
5237 However, temporarily disable this change unless the temporary
5238 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5239
8727937b
PE
5240 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5241
8ac068ac
PE
5242 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5243 This removes an assumption that EMACS_INT and long are the same
5244 width as pointers. The assumption is true for Emacs porting targets
5245 now, but we want to make other targets possible.
5246 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5247 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5248 In the rest of the code, change types of integers that hold casted
5249 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5250 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5251 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5252 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5253 No need to cast type when ORing.
5254 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5255 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5256 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5257 assume EMACS_INT is the same width as char *.
5258 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5259 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5260 Remove no-longer-needed casts.
5261 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5262 (xg_tool_bar_help_callback, xg_make_tool_item):
5263 Use EMACS_INTPTR to hold an integer
5264 that will be cast to void *; this can avoid a GCC warning
5265 if EMACS_INT is not the same width as void *.
5266 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5267 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5268 (current_message_1, set_message_1):
5269 Use a local to convert to proper width without a cast.
5270 * xmenu.c (dialog_selection_callback): Likewise.
5271
ede49d71
PE
5272 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5273 Also, don't assume VALBITS / RAND_BITS is less than 5,
5274 and don't rely on undefined behavior when shifting a 1 left into
5275 the sign bit.
5276 * lisp.h (get_random): Change signature to match.
5277
2f30ecd0
PE
5278 * lread.c (hash_string): Use size_t, not int, for hash computation.
5279 Normally we prefer signed values; but hashing is special, because
5280 it's better to use unsigned division on hash table sizes so that
5281 the remainder is nonnegative. Also, size_t is the natural width
5282 for hashing into memory. The previous code used 'int', which doesn't
5283 retain enough info to hash well into very large tables.
5284 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5285
2a866e7b
PE
5286 * dbusbind.c: Don't possibly lose pointer info when converting.
5287 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5288 Use XPNTR rather than XHASH, so that the high-order bits of
5289 the pointer aren't lost when converting through void *.
5290
51639eac
PE
5291 * eval.c (Fautoload): Don't double-shift a pointer.
5292
92394119
PE
5293 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5294
dbdb9a7c
JB
52952011-05-06 Juanma Barranquero <lekktu@gmail.com>
5296
5297 * gnutls.c (DEF_GNUTLS_FN):
5298 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5299
db7a0b4f
AS
53002011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5301
5302 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5303 marker. (Bug#8610)
5304
f7ff1b0f 53052011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5306
5307 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5308 New version that can reserve upto 2GB of heap space.
5309
f7ff1b0f 53102011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5311
5312 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5313
639c109b
TZ
53142011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5315
5316 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5317 `gnutls_certificate_set_x509_key_file'.
5318
d2127135
JB
53192011-05-05 Juanma Barranquero <lekktu@gmail.com>
5320
5321 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5322 Update dependencies.
5323
e968f4f3
JB
53242011-05-04 Juanma Barranquero <lekktu@gmail.com>
5325
5326 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5327 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5328 Remove unused parameter `fildes'.
5329 * process.c (read_process_output, send_process): Don't pass it.
5330
84d358f0
JB
53312011-05-04 Juanma Barranquero <lekktu@gmail.com>
5332
5333 Fix previous change: the library cache is defined in w32.c.
5334 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5335 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5336
0898ca10
JB
53372011-05-04 Juanma Barranquero <lekktu@gmail.com>
5338
5339 Implement dynamic loading of GnuTLS on Windows.
5340
5341 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5342 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5343 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5344 Declare.
5345
5346 * gnutls.c (Qgnutls_dll): Define.
5347 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5348 (gnutls_*): Declare function pointers.
5349 (init_gnutls_functions): New function to initialize function pointers.
5350 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5351 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5352 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5353 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5354 (emacs_gnutls_write, emacs_gnutls_read)
5355 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5356 (Fgnutls_available_p): New function.
5357 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5358 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5359 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5360
5361 * image.c: Include w32.h.
5362 (Vimage_type_cache): Delete.
5363 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5364 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5365 (w32_delayed_load): Move to w32.c.
5366
5367 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5368
5369 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5370 (w32_delayed_load): Move from image.c. When loading a library, record
5371 its filename in the :loaded-from property of the library id.
5372 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5373 Initialize and staticpro them.
5374 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5375
5376 * process.c: Include lisp.h before w32.h, not after.
5377 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5378 instead of gnutls_record_check_pending.
5379
5380 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5381
ff4de4aa
TZ
53822011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5383
5384 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5385 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5386 as passed in.
5387
abe95abb
JD
53882011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5389
5390 * xterm.c (x_set_frame_alpha): Do not set property on anything
5391 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5392
e16e55d4
JB
53932011-05-02 Juanma Barranquero <lekktu@gmail.com>
5394
5395 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5396
bafcf6a5
JB
53972011-05-02 Juanma Barranquero <lekktu@gmail.com>
5398
5399 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5400 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5401 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5402 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5403 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5404 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5405 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5406 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5407 (Qgnutls_bootprop_callbacks_verify): Make static.
5408
e7a6747f
AS
54092011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5410
19ed11ba
AS
5411 * callproc.c: Indentation fixup.
5412
e7a6747f 5413 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5414 (wait_for_termination, interruptible_wait_for_termination):
5415 Move after wait_for_termination_1.
e7a6747f 5416
1ef14cb4
LMI
54172011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5418
5419 * sysdep.c (interruptible_wait_for_termination): New function
5420 which is like wait_for_termination, but allows keyboard
5421 interruptions.
5422
5423 * callproc.c (Fcall_process): Add (:file "file") as an option for
5424 the STDOUT buffer.
5425 (Fcall_process_region): Ditto.
5426
330d880c
EZ
54272011-04-30 Eli Zaretskii <eliz@gnu.org>
5428
8db90b73
EZ
5429 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5430 rather than `XVECTOR (FOO)->size'.
5431
330d880c
EZ
5432 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5433 inttypes.h, as a gnulib replacement is used if it not available in
5434 system headers.
5435
15cbd324
EZ
54362011-04-21 Eli Zaretskii <eliz@gnu.org>
5437
5438 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5439 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5440 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5441
5442 * coding.c (coding_alloc_by_realloc): Error out if destination
5443 will grow beyond MOST_POSITIVE_FIXNUM.
5444 (decode_coding_emacs_mule): Abort if there isn't enough place in
5445 charbuf for the composition carryover bytes. Reserve an extra
5446 space for up to 2 characters produced in a loop.
5447 (decode_coding_iso_2022): Abort if there isn't enough place in
5448 charbuf for the composition carryover bytes.
5449
54502011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5451
ae940cca
EZ
5452 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5453 aborting when %lld or %lll format is passed.
5454 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5455 %llo or %llx format is passed. (Bug#8545)
5456
03ab8921
EZ
5457 * window.c (window_scroll_line_based): Use a marker instead of
5458 simple variables to record original value of point. (Bug#7952)
5459
afda1437
EZ
5460 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5461 produced by %s or %c overflows available buffer space. (Bug#8545)
5462
f76dee0c
PE
54632011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5464
5465 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5466 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5467
fdc5744d
JB
54682011-04-28 Juanma Barranquero <lekktu@gmail.com>
5469
5470 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5471
638f053a
JB
54722011-04-28 Juanma Barranquero <lekktu@gmail.com>
5473
5474 * keyboard.c (Qdelayed_warnings_hook): Define.
5475 (command_loop_1): Run `delayed-warnings-hook'
5476 if Vdelayed_warnings_list is non-nil.
5477 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5478 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5479
d178f871
EZ
54802011-04-28 Eli Zaretskii <eliz@gnu.org>
5481
5482 * doprnt.c (doprnt): Don't return value smaller than the buffer
5483 size if the message was truncated. (Bug#8545).
5484
b124fd93
JB
54852011-04-28 Juanma Barranquero <lekktu@gmail.com>
5486
5487 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5488 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5489
e810457d
PE
54902011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5491
5492 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5493
ea51cceb
JB
54942011-04-27 Juanma Barranquero <lekktu@gmail.com>
5495
5496 * makefile.w32-in: Update dependencies.
5497
94dcfacf
EZ
54982011-04-27 Eli Zaretskii <eliz@gnu.org>
5499
5500 Improve `doprnt' and its usage. (Bug#8545)
5501 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5502 `format_end'. Remove support for %l as a conversion specifier.
5503 Don't use xrealloc. Improve diagnostics when the %l size modifier
5504 is used. Update the commentary.
5505
5506 * eval.c (verror): Simplify calculation of size_t.
5507
5508 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5509 messages.
5510
f61f41d7
PE
55112011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5512
5513 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5514 change.
5515
96fb4434
PE
55162011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5517
5518 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5519 This makes this file independent of the recent pseudovector change.
5520
671875da 55212011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5522
69e9b5a3
PE
5523 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5524
b5f869a7 5525 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5526 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5527 Remove unused local.
c8926152 5528 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5529
841a1577 5530 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5531 GCC 4.6.0 optimizes based on type-based alias analysis.
5532 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5533 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5534 != &v->size, and therefore "v->size = 1; b->size = 2; return
5535 v->size;" must therefore return 1. This assumption is incorrect
5536 for Emacs, since it type-puns struct Lisp_Vector * with many other
5537 types. To fix this problem, this patch adds a new type struct
f904488f 5538 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5539 and pseudovectors, and helps optimizing compilers not get fooled
5540 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5541 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5542 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5543 the size member.
eab3844f
PE
5544 (XSETPVECTYPE): Rewrite in terms of new macro.
5545 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5546 This is a bit clearer, and further avoids the possibility of
5547 undesirable aliasing.
5548 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5549 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5550 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5551 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5552 (ASIZE): Now uses header.size rather than size.
5553 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5554 to avoid the hassle of writing XVECTOR (foo)->header.size.
5555 (struct vectorlike_header): New type.
eab3844f
PE
5556 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5557 object, to help avoid aliasing.
5558 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5559 (SUBRP): Likewise, since Lisp_Subr is a special case.
5560 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5561 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5562 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5563 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5564 changed to be "header.size" and "header.next".
5565 * buffer.h (struct buffer): Likewise.
5566 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5567 * frame.h (struct frame): Likewise.
5568 * process.h (struct Lisp_Process): Likewise.
5569 * termhooks.h (struct terminal): Likewise.
5570 * window.c (struct save_window_data, struct saved_window): Likewise.
5571 * window.h (struct window): Likewise.
5572 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5573 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5574 * buffer.c (init_buffer_once): Likewise.
5575 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5576 special case.
5577 * process.c (Fformat_network_address): Use local var for size,
5578 for brevity.
5579
0df1eac5
PE
5580 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5581
847ab9d1 5582 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5583 * data.c (atof): Remove decl; no longer used or needed.
5584 (digit_to_number): Move to lread.c.
5585 (Fstring_to_number): Use new string_to_number function, to be
5586 consistent with how the Lisp reader treats infinities and NaNs.
5587 Do not assume that floating-point numbers represent EMACS_INT
5588 without losing information; this is not true on most 64-bit hosts.
5589 Avoid double-rounding errors, by insisting on integers when
5590 parsing non-base-10 numbers, as the documentation specifies.
5591 * lisp.h (string_to_number): New decl, replacing ...
5592 (isfloat_string): Remove.
bc0a5c13 5593 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5594 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5595 appears to have been a coding error. Similarly, do not accept
5596 strings like +-1e0 as floating point numbers. Do not report
5597 overflow for integer overflows unless the base is not 10 which
5598 means we have no simple and reliable way to continue.
5599 Break out the floating-point parsing into a new
5600 function string_to_number, so that Fstring_to_number parses
5601 floating point numbers consistently with the Lisp reader.
04f2d78b 5602 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5603 (E_CHAR, EXP_INT): Remove, replacing with ...
5604 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5605 (string_to_number): New function, replacing isfloat_string.
5606 This function checks for valid syntax and produces the resulting
5607 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5608 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5609 so that overflow for non-base-10 numbers is reported only when
5610 there's no portable and simple way to convert to floating point.
452f4150 5611
67769ffc
PE
5612 * textprop.c (set_text_properties_1): Rewrite for clarity,
5613 and to avoid GCC warning about integer overflow.
5614
c20db43f
PE
5615 * intervals.h (struct interval): Use EMACS_INT for members
5616 where EMACS_UINT might cause problems. See
5617 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5618 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5619 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5620 All uses changed.
37aa2f85
PE
5621 (offset_intervals): Tell GCC not to worry about length overflow
5622 when negating a negative length.
c20db43f 5623
2538aa2f
PE
5624 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5625 (overrun_check_free): Likewise.
5626
f2d3008d
PE
5627 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5628 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5629 word size.
5630
ec8df744
PE
5631 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5632 (gnutls_make_error): Rename local to avoid shadowing.
5633 (gnutls_emacs_global_deinit): ifdef out; not used.
5634 (Fgnutls_boot): Use const for pointer to readonly storage.
5635 Comment out unused local. Fix pointer signedness problems.
5636
640ee02d
PE
5637 * lread.c (openp): Don't stuff size_t into an 'int'.
5638 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5639 about possible signed overflow.
5640
6048fb2a
PE
5641 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5642 (GDK_KEY_g): Don't define if already defined.
5643 (xg_prepare_tooltip): Avoid pointer signedness problem.
5644 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5645
fa3c87e1
PE
5646 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5647 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5648
2172544b
PE
5649 * xfns.c (Fx_window_property): Simplify a bit,
5650 to make a bit faster and to avoid GCC 4.6.0 warning.
5651 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5652
9b821a21
PE
5653 * fns.c (internal_equal): Don't assume size_t fits in int.
5654
3c616cfa
PE
5655 * alloc.c (compact_small_strings): Tighten assertion a little.
5656
c2982e87
PE
5657 Replace pEd with more-general pI, and fix some printf arg casts.
5658 * lisp.h (pI): New macro, generalizing old pEd macro to other
5659 conversion specifiers. For example, use "...%"pI"d..." rather
5660 than "...%"pEd"...".
5661 (pEd): Remove. All uses replaced with similar uses of pI.
5662 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5663 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5664 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5665 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5666 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5667 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5668 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5669 64-bit hosts.
5670 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5671 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5672 * print.c (safe_debug_print, print_object): Likewise.
5673 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5674 to int.
6f04d126
PE
5675 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5676 avoiding the 0 flag, which is not portable.
c2982e87
PE
5677 * process.c (Fmake_network_process): Use pI to avoid cast.
5678 * region-cache.c (pp_cache): Likewise.
5679 * xdisp.c (decode_mode_spec): Likewise.
5680 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5681 behavior on 64-bit hosts with printf arg.
6f04d126 5682 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5683 (x_stop_queuing_selection_requests): Likewise.
5684 (x_get_window_property): Don't truncate byte count to an 'int'
5685 when tracing.
0b432f21 5686
5e073ec7
PE
5687 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5688 here, since it parses constructs like leading '-' and spaces,
5689 which are not wanted; and it overflows with large numbers.
5690 Instead, simply match F[0-9]+, which is what is wanted anyway.
5691
36372bf9
PE
5692 * alloc.c: Remove unportable assumptions about struct layout.
5693 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5694 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5695 (allocate_vectorlike, make_pure_vector): Use the new macros,
5696 plus offsetof, to remove unportable assumptions about struct layout.
5697 These assumptions hold on all porting targets that I know of, but
5698 they are not guaranteed, they're easy to remove, and removing them
5699 makes further changes easier.
5700
0b432f21
PE
5701 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5702 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5703 (string_overrun_cookie): Now const. Use initializers that
5704 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5705 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5706 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5707 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5708 multiple of sizeof (EMACS_INT); it need not be, if
5709 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5710 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5711
895009e1
JB
57122011-04-26 Juanma Barranquero <lekktu@gmail.com>
5713
5714 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5715
6a7a1b0b
TZ
57162011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5717
5718 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5719 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5720 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5721
841a1577 57222011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5723
5724 * lisp.h (Qdebug): List symbol.
895009e1 5725 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5726 * keyboard.c (debug-on-event): New variable.
5727 (handle_user_signal): Break into debugger when debug-on-event
5728 matches the current signal symbol.
5729
f2d3ba6f
DN
57302011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5731
5732 * alloc.c (check_sblock, check_string_bytes)
5733 (check_string_free_list): Convert to standard C.
5734
42ce4c63
TZ
57352011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5736
5737 * w32.c (emacs_gnutls_push): Fix typo.
5738
825cd63c
EZ
57392011-04-25 Eli Zaretskii <eliz@gnu.org>
5740
fb11d64d
EZ
5741 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5742 "cast to pointer from integer of different size".
5743
825cd63c
EZ
5744 Improve doprnt and its use in verror. (Bug#8545)
5745 * doprnt.c (doprnt): Document the set of format control sequences
5746 supported by the function. Use SAFE_ALLOCA instead of always
5747 using `alloca'.
5748
5749 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5750 is one byte too soon. Don't use xrealloc; instead xfree and
5751 xmalloc anew.
5752
e061a11b
TZ
57532011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5754
5755 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5756 callbacks stage.
5757
5758 * gnutls.c: Renamed global_initialized to
5759 gnutls_global_initialized. Added internals for the
5760 :verify-hostname-error, :verify-error, and :verify-flags
5761 parameters of `gnutls-boot' and documented those parameters in the
5762 docstring. Start callback support.
9173deec
JB
5763 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5764 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5765 on error. Return error code.
e061a11b
TZ
5766 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5767 (emacs_gnutls_read): Likewise.
5768 (Fgnutls_boot): Return handshake error code.
5769 (emacs_gnutls_handle_error): New function.
5770 (wsaerror_to_errno): Likewise.
5771
5772 * w32.h (emacs_gnutls_pull): Add prototype.
5773 (emacs_gnutls_push): Likewise.
5774
5775 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5776 (emacs_gnutls_push): Likewise.
5777
57782011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5779
5780 * process.c (wait_reading_process_output): Check if GnuTLS
5781 buffered some data internally if no FDs are set for TLS
5782 connections.
5783
5784 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5785 (LIBS): Link to USER_LIBS.
5786 ($(BLD)/gnutls.$(0)): New target.
5787
fa6996bc
EZ
57882011-04-24 Eli Zaretskii <eliz@gnu.org>
5789
eb35682e
EZ
5790 * xdisp.c (handle_single_display_spec): Rename the
5791 display_replaced_before_p argument into display_replaced_p, to
5792 make it consistent with the commentary. Fix typos in the
5793 commentary.
5794
e2ad650c
EZ
5795 * textprop.c (syms_of_textprop): Remove dead code.
5796 (copy_text_properties): Delete obsolete commentary about an
5797 interface that was deleted long ago. Fix typos in the description
5798 of arguments.
5799
1b2de274
EZ
5800 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5801 to changes in oldXMenu/XMenu.h from 2011-04-16.
5802 <menu_help_message, prev_menu_help_message>: Constify.
5803 (IT_menu_make_room): menu->help_text is now `const char **';
5804 adjust.
5805
5806 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5807 to changes in oldXMenu/XMenu.h from 2011-04-16.
5808 (struct XMenu): Declare `help_text' `const char **'.
5809
5810 * xfaces.c <Qunspecified>: Make extern again.
5811
5812 * syntax.c: Include sys/types.h before including regex.h, as
5813 required by Posix.
5814
762b15be
EZ
5815 * doc.c (get_doc_string): Improve the format passed to `error'.
5816
5817 * doprnt.c (doprnt): Improve commentary.
5818
5819 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5820
5821 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5822 them with etags.
5823
f1052e5d
EZ
5824 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5825 changes in globals.h immediately force recompilation.
762b15be
EZ
5826 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5827 $(CURDIR)/s/ms-w32.h.
5828 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5829
fa6996bc
EZ
5830 * character.c (Fchar_direction): Function deleted.
5831 (syms_of_character): Don't defsubr it.
5832 <char-direction-table>: Deleted.
5833
e6c3da20
EZ
58342011-04-23 Eli Zaretskii <eliz@gnu.org>
5835
5836 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5837 * doprnt.c: Include limits.h.
5838 (SIZE_MAX): New macro.
04f2d78b
CB
5839 (doprnt): Return a size_t value. 2nd arg is now size_t.
5840 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5841 Improve overflow protection. Support `l' modifier for integer
5842 conversions. Support %l conversion. Don't assume an EMACS_INT
5843 argument for integer conversions and for %c.
5844
5845 * lisp.h (doprnt): Restore prototype.
5846
5847 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5848 $(SRC)/character.h.
5849
5850 * Makefile.in (base_obj): Add back doprnt.o.
5851
5852 * deps.mk (doprnt.o): Add back prerequisites.
5853 (callint.o): Depend on character.h.
5854
5855 * eval.c (internal_lisp_condition_case): Include the handler
5856 representation in the error message.
5857 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5858 when breaking from the loop.
5859
5860 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5861
5862 * callint.c (Fcall_interactively): When displaying error message
5863 about invalid control letter, pass the character's codepoint, not
5864 a pointer to its multibyte form. Improve display of the character
5865 in octal and display also its hex code.
5866
5867 * character.c (char_string): Use %x to display the (unsigned)
5868 codepoint of an invalid character, to avoid displaying a bogus
5869 negative value.
5870
5871 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5872 `error', not SYMBOL_NAME itself.
5873
5874 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5875 character arguments to `error'.
5876
5877 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5878 to `error' in error message about FINAL_CHAR argument. Make sure
5879 FINAL_CHAR is a character, and use %c when it is passed as
5880 argument to `error'.
5881
4ffd0d6b 58822011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5883
5884 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5885
5886 * w32.c: Include <time.h>.
5887 (sys_localtime): New function.
5888
4ffd0d6b 58892011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5890
5891 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5892
4ffd0d6b 5893 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5894
4ffd0d6b 58952011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5896
4ffd0d6b
GM
5897 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5898 zombies (Bug#8467).
aac0c6e3 5899
04c56954
EZ
59002011-04-19 Eli Zaretskii <eliz@gnu.org>
5901
5902 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5903 gl_state.e_property when gl_state.object is Qt.
5904
5905 * insdel.c (make_gap_larger): Remove limitation of buffer size
5906 to <= INT_MAX.
5907
16a43933
CY
59082011-04-18 Chong Yidong <cyd@stupidchicken.com>
5909
5910 * xdisp.c (lookup_glyphless_char_display)
5911 (produce_glyphless_glyph): Handle cons cell entry in
5912 glyphless-char-display.
5913 (Vglyphless_char_display): Document it.
5914
5915 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5916 glyphless-char-display.
5917
4581706e
CY
59182011-04-17 Chong Yidong <cyd@stupidchicken.com>
5919
5920 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5921
5922 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5923
5924 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5925 definition for no-X builds.
5926
4887c6e2 59272011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5928
fd35b6f9
PE
5929 Static checks with GCC 4.6.0 and non-default toolkits.
5930
5c1ccb01
PE
5931 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5932
006c5daa
PE
5933 * process.c (keyboard_bit_set): Define only if SIGIO.
5934 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5935 (send_process): Repair possible setjmp clobbering.
5936
efc736d3
PE
5937 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5938
4e2fe2e6
PE
5939 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5940
f97334a2
PE
5941 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5942
4e75f29d
PE
5943 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5944 Define only if needed.
5945
90efadd1
PE
5946 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5947 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5948 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5949
3c647824
PE
5950 * dispextern.h (struct redisplay_interface): Rename param
5951 to avoid shadowing.
e264f262 5952 * termhooks.h (struct terminal): Likewise.
761383f4 5953 * xterm.c (xembed_send_message): Likewise.
3c647824 5954
b58c5c4a
PE
5955 * insdel.c (make_gap_smaller): Define only if
5956 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5957
cad59032
PE
5958 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5959 it.
5960
c339dc2e
PE
5961 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5962 so that we aren't warned about unused symbols.
5963
91a3e27b
PE
5964 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5965
399c71d3 5966 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5967
8ffc96f5
PE
5968 * xfns.c (x_real_positions): Mark locals as initialized.
5969
eef9bc79
PE
5970 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5971
098db9dd
PE
5972 * xterm.c: Fix problems found by static analysis with other toolkits.
5973 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5974 (x_dispatch_event): Declare static if USE_GTK, and
5975 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5976 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5977 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5978 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5979 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5980
eb18f6cc
PE
5981 * xmenu.c (menu_help_callback): Pointer type fixes.
5982 Use const pointers when pointing at readonly data. Avoid pointer
5983 signedness clashes.
5984 (FALSE): Remove unused macro.
5985 (update_frame_menubar): Remove unused decl.
5986
1fe72bf8
PE
5987 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5988
60d9e1db
PE
5989 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5990 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5991 (single_menu_item): Rename local to avoid shadowing.
5992
39261c26
PE
5993 * keyboard.c (make_lispy_event): Remove unused local var.
5994
018c5e19
PE
5995 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5996 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5997
63d2b86e
PE
5998 * bitmaps: Change bitmaps from unsigned char back to the X11
5999 compatible char. Avoid the old compiler warnings about
6000 out-of-range initializers by using, for example, '\xab' rather
6001 than 0xab.
6002
aefd87e1
PE
6003 * xgselect.c (xgselect_initialize): Check vs interface
6004 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6005
bf501fb9
PE
6006 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6007
e9829fdf
PE
6008 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6009 to read-only memory.
6010
1086c095
PE
6011 * fns.c (vector): Remove; this old hack is no longer needed.
6012
2baccd04 6013 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6014 Remove unused var.
dde42981 6015 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6016
72391843 6017 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6018
436c16df 6019 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6020 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6021 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6022
92bb796d 6023 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6024 (x_term_init): Remove local to avoid shadowing.
92bb796d 6025
764430a3 6026 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6027
6028 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6029 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6030
d1dfb56c
EZ
60312011-04-16 Eli Zaretskii <eliz@gnu.org>
6032
c4354cb4
EZ
6033 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6034
d1dfb56c
EZ
6035 Fix regex.c, syntax.c and friends for buffers > 2GB.
6036 * syntax.h (struct gl_state_s): Declare character position members
6037 EMACS_INT.
6038
6039 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6040
04f2d78b
CB
6041 * textprop.c (verify_interval_modification, interval_of):
6042 Declare arguments EMACS_INT.
d1dfb56c
EZ
6043
6044 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6045 EMACS_INT.
6046
6047 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6048
6049 * indent.c (Fvertical_motion): Local variable it_start is now
6050 EMACS_INT.
6051
6052 * regex.c (re_match, re_match_2, re_match_2_internal)
6053 (bcmp_translate, regcomp, regexec, print_double_string)
6054 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6055 (re_compile_pattern, re_exec): Declare arguments and local
6056 variables `size_t' and `ssize_t' and return values `regoff_t', as
6057 appropriate.
6058 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6059 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6060 <compile_stack_type>: `size' and `avail' are now `size_t'.
6061
6062 * regex.h <regoff_t>: Use ssize_t, not int.
6063 (re_search, re_search_2, re_match, re_match_2): Arguments that
6064 specify buffer/string position and length are now ssize_t and
6065 size_t. Return type is regoff_t.
6066
613052cd
BK
60672011-04-16 Ben Key <bkey76@gmail.com>
6068
6069 * nsfont.m: Fixed bugs in ns_get_family and
6070 ns_descriptor_to_entity that were caused by using free to
6071 deallocate memory blocks that were allocated by xmalloc (via
6072 xstrdup). This caused Emacs to crash when compiled with
6073 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6074 --enable-checking=xmallocoverrun). xfree is now used to
6075 deallocate these memory blocks.
6076
4170f62f 60772011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6078
71b41406
PE
6079 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6080
9587a89d
PE
6081 emacs_write: Accept and return EMACS_INT for sizes.
6082 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6083 et seq.
6084 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6085 Accept and return EMACS_INT.
6086 (emacs_gnutls_write): Return the number of bytes written on
6087 partial writes.
6088 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6089 (emacs_read, emacs_write): Remove check for negative size, as the
6090 Emacs source code has been audited now.
9587a89d
PE
6091 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6092 (emacs_read, emacs_write): Use it.
273a5f82
PE
6093 * process.c (send_process): Adjust to the new signatures of
6094 emacs_write and emacs_gnutls_write. Do not attempt to store
6095 a byte offset into an 'int'; it might overflow.
9587a89d 6096 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6097
3e047f51
PE
6098 * sound.c: Don't assume sizes fit in 'int'.
6099 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6100 Return EMACS_INT, not int.
3e047f51 6101 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6102 Accept EMACS_INT, not int.
6103 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6104 record read return values.
6105
cc39a9db
BK
61062011-04-15 Ben Key <bkey76@gmail.com>
6107
c9d0ec6d
JB
6108 * keyboard.c (Qundefined): Don't declare static since it is used
6109 in nsfns.m.
6110 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6111 static since they are used in nsfont.m.
cc39a9db 6112
6c60eb9f
SM
61132011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6114
6115 * process.c (Qprocessp): Don't declare static.
6116 * lisp.h (Qprocessp): Declare again.
6117
7990b61a
JB
61182011-04-15 Juanma Barranquero <lekktu@gmail.com>
6119
6120 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6121
5d4cb038
PE
61222011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6123
8bd7b830 6124 Improve C-level modularity by making more things 'static'.
cd64ea1d 6125
e3b27b31
PE
6126 Don't publish debugger-only interfaces to other modules.
6127 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6128 (verify_bytepos, count_markers): Move decls to the only modules
6129 that need them.
6130 * region-cache.h (pp_cache): Likewise.
6131 * window.h (check_all_windows): Likewise.
6132 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6133
5d4cb038
PE
6134 * sysdep.c (croak): Now static, if
6135 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6136 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6137
6138 * alloc.c (refill_memory_reserve): Now static if
6139 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6140 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6141
e87b6180
PE
6142 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6143 Define only if USE_LUCID.
6144
ac64929e
PE
6145 * xrdb.c (x_customization_string, x_rm_string): Now static.
6146
6f37259d
PE
6147 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6148 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6149
1683e3ab
PE
6150 * xdisp.c (draw_row_with_mouse_face): Now static.
6151 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6152
de9c2632
PE
6153 * window.h (check_all_windows): Mark externally visible.
6154
2b96acb7
PE
6155 * window.c (window_deletion_count): Now static.
6156
6157 * undo.c: Make symbols static if they're not exported.
6158 (last_undo_buffer, last_boundary_position, pending_boundary):
6159 Now static.
6160
50436f33
PE
6161 * textprop.c (interval_insert_behind_hooks): Now static.
6162 (interval_insert_in_front_hooks): Likewise.
6163
64520e5c
PE
6164 * term.c: Make symbols static if they're not exported.
6165 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6166 (max_frame_lines, tty_set_terminal_modes):
6167 (tty_reset_terminal_modes, tty_turn_off_highlight):
6168 (get_tty_terminal): Now static.
6169 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6170 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6171 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6172 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6173 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6174
1fa53021
PE
6175 * sysdep.c: Make symbols static if they're not exported.
6176 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6177 Now static.
6178 (sigprocmask_set, full_mask): Remove; unused.
6179 (wait_debugging): Mark as visible.
6180 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6181 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6182
d4b43b22
PE
6183 * syntax.c (syntax_temp): Define only if !__GNUC__.
6184
b7c513d0
PE
6185 * sound.c (current_sound_device, current_sound): Now static.
6186
989b29ad
PE
6187 * search.c (searchbufs, searchbuf_head): Now static.
6188
13a55a78
PE
6189 * scroll.c (scroll_cost): Remove; unused.
6190 * dispextern.h (scroll_cost): Remove decl.
6191
de68a1fc
PE
6192 * region-cache.h (pp_cache): Mark as externally visible.
6193
40ccffa6
PE
6194 * process.c: Make symbols static if they're not exported.
6195 (process_tick, update_tick, create_process, chan_process):
6196 (Vprocess_alist, proc_buffered_char, datagram_access):
6197 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6198 (deactivate_process): Mark defn as static, as well as decl.
6199 * lisp.h (create_process): Remove decl.
6200 * process.h (chan_process, Vprocess_alist): Remove decls.
6201
ad64fc97
PE
6202 * print.c: Make symbols static if they're not exported.
6203 (print_depth, new_backquote_output, being_printed, print_buffer):
6204 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6205 (print_interval, print_number_index, initial_stderr_stream):
6206 Now static.
6207 * lisp.h (Fprinc): Remove decl.
6208 (debug_output_compilation_hack): Mark as externally visible.
6209
adddb265
PE
6210 * sysdep.c (croak): Move decl from here to syssignal.h.
6211 * syssignal.h (croak): Put it here, so the API can be checked when
6212 'croak' is called from dissociate_if_controlling_tty.
6213
1717ede2
PE
6214 * minibuf.c: Make symbols static if they're not exported.
6215 (minibuf_save_list, choose_minibuf_frame): Now static.
6216 * lisp.h (choose_minibuf_frame): Remove decl.
6217
fa5fb2bc
PE
6218 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6219
1e3890d1
PE
6220 * lread.c: Make symbols static if they're not exported.
6221 (read_objects, initial_obarray, oblookup_last_bucket_number):
6222 Now static.
6223 (make_symbol): Remove; unused.
6224 * lisp.h (initial_obarray, make_symbol): Remove decls.
6225
8a1414fa
PE
6226 * keyboard.c: Make symbols static if they're not exported.
6227 (single_kboard, recent_keys_index, total_keys, recent_keys):
6228 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6229 (this_single_command_key_start, echoing, last_auto_save):
6230 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6231 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6232 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6233 (Vlispy_mouse_stem, double_click_count):
6234 Now static.
6235 (force_auto_save_soon): Define only if SIGDANGER.
6236 (ignore_mouse_drag_p): Now static if
6237 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6238 (print_help): Remove; unused.
6239 (stop_character, last_timer_event): Mark as externally visible.
6240 * keyboard.h (ignore_mouse_drag_p): Declare only if
6241 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6242 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6243 * lisp.h (echoing): Remove decl.
6244 (force_auto_save_soon): Declare only if SIGDANGER.
6245 * xdisp.c (redisplay_window): Simplify code, to make it more
6246 obvious that ignore_mouse_drag_p is not accessed if !defined
6247 USE_GTK && !defined HAVE_NS.
6248
93ea6e8f
PE
6249 * intervals.c: Make symbols static if they're not exported.
6250 (merge_properties_sticky, merge_interval_right, delete_interval):
6251 Now static.
6252 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6253
77382fcc
PE
6254 * insdel.c: Make symbols static if they're not exported.
6255 However, leave prepare_to_modify_buffer alone. It's never
6256 called from outside this function, but that appears to be a bug.
6257 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6258 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6259 (adjust_after_replace_noundo): Remove; unused.
6260 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6261 (signal_before_change): Remove decls.
77382fcc 6262
9306c32e
PE
6263 * indent.c (val_compute_motion, val_vmotion): Now static.
6264
cd44d2eb
PE
6265 * image.c: Make symbols static if they're not exported.
6266 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6267 if USE_GTK.
6268 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6269 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6270
ad9a7a06
PE
6271 * fringe.c (standard_bitmaps): Now static.
6272 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6273
81626931
PE
6274 * frame.c: Make symbols static if they're not exported.
6275 (x_report_frame_params, make_terminal_frame): Now static.
6276 (get_frame_param): Now static, unless HAVE_NS.
6277 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6278 (x_get_resource_string): Remove; not used.
6279 * frame.h (make_terminal_frame, x_report_frame_params):
6280 (x_get_resource_string); Remove decls.
6281 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6282 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6283
239f9db9
PE
6284 * font.c, fontset.c: Make symbols static if they're not exported.
6285 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6286 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6287 * font.c (font_close_object): Now static.
6288 * font.h (font_close_object): Remove.
6289 * fontset.c (FONTSET_OBJLIST): Remove.
6290 (free_realized_fontset) #if-0 the body, which does nothing.
6291 (face_suitable_for_char_p): #if-0, as it's never called.
6292 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6293 * xfaces.c (face_at_string_position):
6294 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6295 since 0 is always ASCII.
6296
dfcf3579
PE
6297 * fns.c (weak_hash_tables): Now static.
6298
5045092b
PE
6299 * fileio.c: Make symbols static if they're not exported.
6300 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6301 (Vwrite_region_annotation_buffers): Now static.
6302
57a96f5c
PE
6303 * eval.c: Make symbols static if they're not exported.
6304 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6305 * lisp.h (backtrace_list): Remove decl.
6306
35f08c38
PE
6307 * emacs.c: Make symbols static if they're not exported.
6308 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6309 (fatal_error_code, fatal_error_signal_hook, standard_args):
6310 Now static.
6311 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6312 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6313 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6314 * lisp.h (fatal_error_signal_hook): Remove decl.
6315 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6316
f44bd759
PE
6317 * editfns.c: Move a (normally-unused) function to its only use.
6318 * editfns.c, lisp.h (get_operating_system_release): Remove.
6319 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6320 worth the hassle of breaking this out.
6321
b532497d
PE
6322 * xterm.c: Make symbols static if they're not exported.
6323 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6324 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6325 (x_destroy_window, x_delete_display):
6326 Now static.
6327 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6328 (x_mouse_leave): Remove; unused.
6329 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6330 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6331 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6332 Remove decls.
6333 (x_mouse_leave): Declare only if WINDOWSNT.
6334 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6335 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6336 USE_X_TOOLKIT.
6337
1675728f
PE
6338 * ftxfont.c: Make symbols static if they're not exported.
6339 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6340 HAVE_FREETYPE.
6341 * font.h (ftxfont_driver): Likewise.
6342
e4cebfca
PE
6343 * xfns.c: Make symbols static if they're not exported.
6344 (x_last_font_name, x_display_info_for_name):
6345 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6346 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6347 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6348 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6349 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6350 (last_show_tip_args): Now static.
6351 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6352 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6353 (x_screen_planes): Remove; unused.
6354 * dispextern.h (x_screen_planes): Remove decl.
6355
5bf46f05
PE
6356 * dispnew.c: Make symbols static if they're not exported.
6357 * dispextern.h (redraw_garbaged_frames, scrolling):
6358 (increment_row_positions): Remove.
6359 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6360 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6361 Now static.
6362 (redraw_garbaged_frames): Remove; unused.
6363
435f4c28
PE
6364 * xfaces.c: Make symbols static if they're not exported.
6365 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6366 Remove decls.
6367 * xterm.h (defined_color): Remove decls.
6368 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6369 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6370 (menu_face_changed_default, defined_color, free_realized_face):
6371 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6372 (ascii_face_of_lisp_face): Remove; unused.
6373
8524aef3
PE
6374 * xdisp.c: Make symbols static if they're not exported.
6375 * dispextern.h (scratch_glyph_row, window_box_edges):
6376 (glyph_to_pixel_coords, set_cursor_from_row):
6377 (get_next_display_element, set_iterator_to_next):
6378 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6379 (show_mouse_face): Remove decls
6380 * frame.h (message_buf_print): Likewise.
6381 * lisp.h (pop_message, set_message, check_point_in_composition):
6382 Likewise.
6383 * xterm.h (set_vertical_scroll_bar): Likewise.
6384 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6385 (message_buf_print, scratch_glyph_row, displayed_buffer):
6386 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6387 (get_next_display_element, show_mouse_face, window_box_edges):
6388 (frame_to_window_pixel_xy, check_point_in_composition):
6389 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6390 (glyph_to_pixel_coords): Remove; unused.
6391
16390cd2
PE
6392 * dired.c (file_name_completion): Now static.
6393
6394 * dbusbind.c (xd_in_read_queued_messages): Now static.
6395
a25f4dfa
PE
6396 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6397 * data.c (circular_list_error): Remove.
6398
14a9c8df
PE
6399 * commands.h (last_point_position, last_point_position_buffer):
6400 (last_point_position_window): Remove decls.
6401 * keyboard.c: Make these variables static.
6402
04f2d78b
CB
6403 * coding.h (coding, code_convert_region, encode_coding_gap):
6404 Remove decls.
74ab6df5
PE
6405 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6406 (iso_code_class, detect_coding, code_convert_region): Now static.
6407 (encode_coding_gap): Remove; unused.
6408
38dfbee1
PE
6409 * chartab.c (chartab_chars, chartab_bits): Now static.
6410
a2cb4e63
PE
6411 * charset.h (charset_iso_8859_1): Remove decl.
6412 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6413 Now static.
6414
127198fd
PE
6415 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6416 * ccl.c (Vccl_program_table): Now static.
6417 (check_ccl_update): Remove; unused.
6418
d85b608f
PE
6419 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6420 * category.h: ... from here.
6421 * category.c (check_category_table, set_category_set): Now static.
6422
31cd66f3
PE
6423 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6424 * lisp.h: Remove these decls.
6425
c358e587
PE
6426 * buffer.c (buffer_count): Remove unused var.
6427
e78aecca
PE
6428 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6429 so that it's not optimized away.
6430 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6431 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6432 exported only to the debugger.
6433
e192d7d3 6434 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6435 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6436
92470028
PE
6437 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6438 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6439 was inaccessible from Lisp.
6440 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6441 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6442
244ed907
PE
6443 alloc.c: Import and export fewer symbols, and remove unused items.
6444 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6445 is defined.
6446 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6447 it's not optimized away by whole-program optimization.
6448 (message_enable_multibyte, free_misc): Remove.
6449 (catchlist, handlerlist, mark_backtrace):
6450 Declare only if BYTE_MARK_STACK.
6451 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6452 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6453 (message_enable_multibyte): Remove decl.
6454 (free_misc, interval_free_list, float_block, float_block_index):
6455 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6456 (cons_free_list, last_marked_index):
6457 Now static.
6458 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6459 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6460 (mark_backtrace): Define only if BYTE_MARK_STACK.
6461 * xdisp.c (message_enable_multibyte): Now static.
6462
61c2b50e 6463 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6464 This makes it easier for human readers (and static analyzers)
6465 to see whether these variables are used from other modules.
6466 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6467 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6468 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6469 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6470 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6471 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6472 * xmenu.c, xselect.c:
6473 Declare Q* vars static if they are not used in other modules.
6474 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6475 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6476 Remove decls of unexported vars.
6477 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6478
95c82688
PE
6479 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6480
16a97296
PE
6481 Make Emacs functions such as Fatom 'static' by default.
6482 This makes it easier for human readers (and static analyzers)
6483 to see whether these functions can be called from other modules.
6484 DEFUN now defines a static function. To make the function external
6485 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6486 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6487 (Finit_image_library):
16a97296
PE
6488 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6489 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6490 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6491 Remove decls, since these functions are now static.
6492 (Funintern, Fget_internal_run_time): New decls, since these functions
6493 were already external.
95c82688 6494
16a97296
PE
6495 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6496 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6497 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6498 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6499 * keyboard.c, keymap.c, lread.c:
6500 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6501 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6502 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6503 Mark functions with DEFUE instead of DEFUN,
6504 if they are used in other modules.
6505 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6506 decls for now-static functions.
6507 * buffer.h (Fdelete_overlay): Remove decl.
6508 * callproc.c (Fgetenv_internal): Mark as internal.
6509 * composite.c (Fremove_list_of_text_properties): Remove decl.
6510 (Fcomposition_get_gstring): New forward static decl.
6511 * composite.h (Fcomposite_get_gstring): Remove decl.
6512 * dired.c (Ffile_attributes): New forward static decl.
6513 * doc.c (Fdocumntation_property): New forward static decl.
6514 * eval.c (Ffetch_bytecode): New forward static decl.
6515 (Funintern): Remove extern decl; now in .h file where it belongs.
6516 * fileio.c (Fmake_symbolic_link): New forward static decl.
6517 * image.c (Finit_image_library): New forward static decl.
6518 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6519 * intervals.h (Fprevious_property_change):
6520 (Fremove_list_of_text_properties): Remove decls.
6521 * keyboard.c (Fthis_command_keys): Remove decl.
6522 (Fcommand_execute): New forward static decl.
6523 * keymap.c (Flookup_key): New forward static decl.
6524 (Fcopy_keymap): Now static.
6525 * keymap.h (Flookup_key): Remove decl.
6526 * process.c (Fget_process): New forward static decl.
6527 (Fprocess_datagram_address): Mark as internal.
6528 * syntax.c (Fsyntax_table_p): New forward static decl.
6529 (skip_chars): Remove duplicate decl.
6530 * textprop.c (Fprevious_property_change): New forward static decl.
6531 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6532 Now internal.
6533 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6534 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6535
785bbd42
PE
6536 * editfns.c (Fformat): Remove unreachable code.
6537
8b913b57
AS
65382011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6539
6540 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6541 change. (Bug#8496)
6542
a6744a35
EZ
65432011-04-13 Eli Zaretskii <eliz@gnu.org>
6544
6545 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6546 when at ZV. (Bug#8487)
6547
e7974947
AS
65482011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6549
baad03f0
AS
6550 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6551 (Bug#8437)
6552 * keyboard.c (parse_tool_bar_item): Likewise.
6553 * sound.c (sound_cleanup, alsa_close): Likewise.
6554 * termcap.c (tgetent): Likewise.
6555 * xfns.c (x_default_font_parameter): Likewise.
6556 * xsettings.c (read_and_apply_settings): Likewise.
6557
e7974947
AS
6558 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6559 (overrun_check_free): Protoize.
6560
28272684
PE
65612011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6562
6563 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6564 since callers should never pass a negative size.
6565 Change the signature to match that of plain 'read' and 'write'; see
6566 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6567 * lisp.h: Update prototypes of emacs_write and emacs_read.
6568
11997c76
EZ
65692011-04-11 Eli Zaretskii <eliz@gnu.org>
6570
6571 * xdisp.c (redisplay_window): Don't try to determine the character
6572 position of the scroll margin if the window start point w->startp
e896f03c 6573 is outside the buffer's accessible region. (Bug#8468)
11997c76 6574
8a2cbd72
EZ
65752011-04-10 Eli Zaretskii <eliz@gnu.org>
6576
6577 Fix write-region and its subroutines for buffers > 2GB.
6578 * fileio.c (a_write, e_write): Modify declaration of arguments and
6579 local variables to support buffers larger than 2GB.
6580 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6581
6582 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6583 argument, local variables, and return value.
6584
6585 * lisp.h: Update prototypes of emacs_write and emacs_read.
6586
6587 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6588
4073e537 65892011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6590
1ebfdcb6
PE
6591 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6592
b2ded58d
PE
6593 Fix more problems found by GCC 4.6.0's static checks.
6594
7d66342c
PE
6595 * xdisp.c (vmessage): Use a better test for character truncation.
6596
bbf47d44
PE
6597 * charset.c (load_charset_map): <, not <=, for optimization,
6598 and to avoid potential problems with integer overflow.
9248994d 6599 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6600 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6601 * editfns.c (Fformat): Likewise.
1e69125e 6602 * syntax.c (skip_chars): Likewise.
3befa583 6603
e3019616
PE
6604 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6605 This also lets GCC 4.6.0 generate slightly better loop code.
6606
becfa255
PE
6607 * callint.c (Fcall_interactively): <, not <=, for optimization.
6608 (Fcall_interactively): Count the number of arguments produced,
6609 not the number of arguments given. This is simpler and lets GCC
6610 4.6.0 generate slightly better code.
6611
dae0cd48
PE
6612 * ftfont.c: Distingish more carefully between FcChar8 and char.
6613 The previous code passed unsigned char * to a functions like
6614 strlen and xstrcasecmp that expect char *, which does not
6615 conform to the C standard.
6616 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6617 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6618 char * when the C standard requires it.
6619
76032d70
PE
6620 * keyboard.c (read_char): Remove unused var.
6621
eb3f1cc8
PE
6622 * eval.c: Port to Windows vsnprintf (Bug#8435).
6623 Include <limits.h>.
6624 (SIZE_MAX): Define if the headers do not.
6625 (verror): Do not give up if vsnprintf returns a negative count.
6626 Instead, grow the buffer. This ports to Windows vsnprintf, which
6627 does not conform to C99. Problem reported by Eli Zaretskii.
6628 Also, simplify the allocation scheme, by avoiding the need for
6629 calling realloc, and removing the ALLOCATED variable.
6630
70476b54
PE
6631 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6632
12020a9e
PE
6633 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6634 But keep the doprint source code for now, as we might revamp it
6635 and use it again (Bug#8435).
ea6c7ae6
PE
6636 * lisp.h (doprnt): Remove.
6637 * Makefile.in (base_obj): Remove doprnt.o.
6638 * deps.mk (doprnt.o): Remove.
6639
5fdb398c
PE
6640 error: Print 32- and 64-bit integers portably (Bug#8435).
6641 Without this change, on typical 64-bit hosts error ("...%d...", N)
6642 was used to print both 32- and 64-bit integers N, which relied on
6643 undefined behavior.
6644 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6645 New macro.
6646 * lisp.h (error, verror): Mark as printf-like functions.
6647 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6648 Report overflow in size calculations when allocating printf buffer.
6649 Do not truncate output string at its first null byte.
6650 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6651 Truncate the output at a character boundary, since vsnprintf does not
6652 do that.
6653 * charset.c (check_iso_charset_parameter): Convert internal
6654 character to string before calling 'error', since %c now has the
6655 printf meaning.
6656 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6657 overflow when computing char to be passed to 'error'. Do not
6658 pass Lisp_Object to 'error'; pass the integer instead.
6659 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6660 formatted with plain %d.
6661
b189fa66
PE
6662 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6663
bff87ef0
PE
6664 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6665
7e2cac20
PE
6666 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6667
ce4d90b5
PE
6668 * xterm.c (x_catch_errors): Remove duplicate declaration.
6669
266c9547
PE
6670 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6671
79c49ad2
PE
6672 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6673
368f4090
JM
66742011-04-10 Jim Meyering <meyering@redhat.com>
6675
6676 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6677 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6678 return ssize_t not "int", and use size_t as the buffer length.
6679 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6680 * gnutls.h: Update declarations.
6681 * process.c (read_process_output): Use ssize_t, to match.
6682 (send_process): Likewise.
6683
a32d4040
CY
66842011-04-09 Chong Yidong <cyd@stupidchicken.com>
6685
6686 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6687
8546720e 66882011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6689
04f2d78b
CB
6690 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6691 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6692
8546720e
GM
6693 * xterm.c (handle_one_xevent):
6694 * xmenu.c (create_and_show_popup_menu):
6695 * xselect.c (x_decline_selection_request)
6696 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6697
0a2f5c1a 66982011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6699
6700 Fix some uses of `int' instead of EMACS_INT.
6701 * search.c (string_match_1, fast_string_match)
6702 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6703 (scan_buffer, find_next_newline_no_quit)
6704 (find_before_next_newline, search_command, Freplace_match)
6705 (Fmatch_data): Make some `int' variables be EMACS_INT.
6706
6707 * xdisp.c (display_count_lines): 3rd argument and return value now
6708 EMACS_INT. All callers changed.
6709 (pint2hrstr): Last argument is now EMACS_INT.
6710
6711 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6712 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6713 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6714 (decode_coding_utf_16, decode_coding_emacs_mule)
6715 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6716 (decode_coding_ccl, decode_coding_charset)
6717 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6718 (decode_coding_iso_2022, decode_coding_emacs_mule)
6719 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6720 <char_offset, last_offset>: Declare EMACS_INT.
6721 (encode_coding_utf_8, encode_coding_utf_16)
6722 (encode_coding_emacs_mule, encode_invocation_designation)
6723 (encode_designation_at_bol, encode_coding_iso_2022)
6724 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6725 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6726 Declare EMACS_INT.
6727 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6728 (encode_invocation_designation): Last argument P_NCHARS is now
6729 EMACS_INT.
6730 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6731 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6732
6733 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6734 All users changed.
6735
6736 * ccl.c (Fccl_execute_on_string): Declare some variables
6737 EMACS_INT.
6738
8546720e 67392011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6740
6741 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6742
4e19a977
CS
67432011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6744
6745 * process.c (Fformat_network_address): Doc fix.
6746
87302331
R
67472011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6748
6749 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6750
cbb59342
CY
67512011-04-08 Chong Yidong <cyd@stupidchicken.com>
6752
6753 * keyboard.c (read_char): Call Lisp function help-form-show,
6754 instead of using internal_with_output_to_temp_buffer.
6755 (Qhelp_form_show): New var.
e0d38eeb 6756 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6757
6758 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6759
6760 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6761
e67a13ab
CY
67622011-04-06 Chong Yidong <cyd@stupidchicken.com>
6763
04f2d78b
CB
6764 * process.c (Flist_processes): Remove to Lisp.
6765 (list_processes_1): Delete.
e67a13ab 6766
973f782d
EZ
67672011-04-06 Eli Zaretskii <eliz@gnu.org>
6768
7c106b1e
EZ
6769 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6770
973f782d
EZ
6771 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6772
41cf7d1a 67732011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6774
ca23cc88
PE
6775 Fix more problems found by GCC 4.6.0's static checks.
6776
f390e2d5
PE
6777 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6778
42eea0d0
PE
6779 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6780
b69769da 6781 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6782
f9541e84
PE
6783 * xdisp.c (vmessage): Mark as a printf-like function.
6784
13841b55
PE
6785 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6786
c136c10f
PE
6787 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6788
5e2d4a30
PE
6789 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6790 printf-like functions.
6791 (tiff_load): Add casts to remove these marks before passing them
6792 to system-supplied API.
6793
583f48b9
PE
6794 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6795
b25d760e
PE
6796 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6797 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6798 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6799 directly, rather than having caller test rule sign. This avoids
6800 some unnecessary tests.
6801 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6802 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6803 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6804
bc7b6697 6805 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6806 (xfont_open): Avoid unnecessary tests.
bc7b6697 6807
27ccc379
PE
6808 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6809
dcd5c89a
PE
6810 * composite.h, composite.c (composition_gstring_put_cache):
6811 Use EMACS_INT, not int, for length.
6812
b13a45c6
PE
6813 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6814 breaking out part of COMPOSITION_DECODE_RULE.
6815 (COMPOSITION_DECODE_RULE): Use it.
6816 * composite.c (get_composition_id): Remove unused local vars,
6817 by using the new macro.
6818
1e792e4d
PE
6819 * textprop.c (set_text_properties_1): Change while to do-while,
6820 since the condition is always true at first.
6821
dc6c6455 6822 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6823 (interval_deletion_adjustment): Return unsigned value.
6824 All uses changed.
dc6c6455 6825
aba7731a
PE
6826 * process.c (list_processes_1, create_pty, read_process_output):
6827 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6828 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6829 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6830 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6831 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6832
fdfc4bf3
PE
6833 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6834
fca8fe46 6835 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6836 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6837
06a0259a 6838 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6839 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6840 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6841
e7b9e80f
PE
6842 * print.c (print_error_message): Avoid int overflow.
6843
56201685
PE
6844 * font.c (font_list_entities): Redo for clarity,
6845 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6846
78834453 6847 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6848 (font_score): Avoid potential overflow in diff calculation.
78834453 6849
0bc0b309 6850 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6851 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6852
e610eaca
PE
6853 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6854
b895abce
PE
6855 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6856 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6857 can always succeed if overflow has undefined behavior.
6858
1f1d9321 6859 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6860 (wordify): Omit three unnecessary tests.
1f1d9321 6861
c59478bc
PE
6862 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6863 All callers changed. This avoids the need for an unused var.
6864
79b73827
PE
6865 * casefiddle.c (casify_region): Remove var that is set but not used.
6866
a4db5dfe
PE
6867 * dired.c (file_name_completion): Remove var that is set but not used.
6868
43aae36e
PE
6869 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6870
2a47c44d 6871 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6872 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6873
a37c69bf
PE
6874 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6875 Check for integer overflow on size calculations.
6876
328ab8e7
PE
6877 * buffer.c (Fprevious_overlay_change): Remove var that is set
6878 but not used.
6879
e5a2a5cb
PE
6880 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6881 Remove vars that are set but not used.
8d84a6eb 6882 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6883 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6884
a60e5f68
PE
6885 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6886
f661cb61 6887 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6888 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6889
f0397f5a
PE
6890 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6891 that are set but not used.
6892
8664db06 6893 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6894 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6895
6abdaa4a
PE
6896 * xselect.c (x_get_local_selection, x_handle_property_notify):
6897 Remove vars that are set but not used.
6898
0ce7538d 6899 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6900 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6901
9ae848fc
PE
6902 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6903 Remove var that is set but not used.
0b918413
PE
6904 (scroll_bar_windows_size): Now size_t, not int.
6905 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6906 Check for overflow.
9ae848fc 6907
a5a62657
PE
6908 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6909 (map_tty_color) [!defined MSDOS]: Likewise.
6910
5c5cdd39
PE
6911 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6912
66ebf983
PE
6913 * coding.c: Remove vars that are set but not used.
6914 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6915 All callers changed.
6916 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6917 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6918 (decode_coding_charset): Remove vars that are set but not used.
6919
1be4d761
PE
6920 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6921 that is set but not used.
6922
47553fa8
PE
6923 * print.c (print_object): Remove var that is set but not used.
6924
1f7196bf 6925 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6926 The gnulib version avoids calling malloc in the usual case,
6927 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6928 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6929 * filelock.c (current_lock_owner): Likewise.
6930 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6931 * sysdep.c: Include allocator.h, careadlinkat.h.
6932 (emacs_no_realloc_allocator): New static constant.
6933 (emacs_readlink): New function.
fdb61804
PE
6934 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6935 ../lib/careadlinkat.h.
d1fdcab7 6936
f84c17c7
SM
69372011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6938
6939 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6940 first non-nil return value).
6941
ef3862ad
JD
69422011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6943
6944 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6945 if not defined (Bug#8403).
6946
376a7006
JB
69472011-04-02 Juanma Barranquero <lekktu@gmail.com>
6948
6949 * xdisp.c (display_count_lines): Remove parameter `start',
6950 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6951 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6952 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6953 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6954 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6955 and thereabouts. All callers changed.
6956 (get_per_char_metric): Remove parameter `f', unused since
6957 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6958
6ca3801d
JM
69592011-04-02 Jim Meyering <meyering@redhat.com>
6960
6961 do not dereference NULL upon failed strdup
6962 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6963 (ns_get_family): Likewise.
6964
d8e2b5ba
JB
69652011-04-02 Juanma Barranquero <lekktu@gmail.com>
6966
6967 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6968
8c74fcbd
JD
69692011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6970
6971 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6972 later (Bug#8403).
6973
7200d79c
SM
69742011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6975
03408648 6976 Add lexical binding.
7200d79c 6977
03408648
SM
6978 * window.c (Ftemp_output_buffer_show): New fun.
6979 (Fsave_window_excursion):
6980 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6981
6982 * lread.c (lisp_file_lexically_bound_p): New function.
6983 (Fload): Bind Qlexical_binding.
6984 (readevalloop): Remove `evalfun' arg.
6985 Bind Qinternal_interpreter_environment.
6986 (Feval_buffer): Bind Qlexical_binding.
6987 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6988 Mark as dynamic.
6989 (syms_of_lread): Declare `lexical-binding'.
6990
6991 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6992
6993 * keyboard.c (eval_dyn): New fun.
6994 (menu_item_eval_property): Use it.
ca105506
SM
6995
6996 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6997
03408648
SM
6998 * fns.c (concat, mapcar1): Accept byte-code-functions.
6999
7000 * eval.c (Fsetq): Handle lexical vars.
7001 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7002 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7003 (FletX, Flet): Obey lexical binding.
7004 (Fcommandp): Handle closures.
7005 (Feval): New `lexical' arg.
7006 (eval_sub): New function extracted from Feval. Use it almost
7007 everywhere where Feval was used. Look up vars in lexical env.
7008 Handle closures.
7009 (Ffunctionp): Move from subr.el.
7010 (Ffuncall): Handle closures.
7011 (apply_lambda): Remove `eval_flags'.
7012 (funcall_lambda): Handle closures and new byte-code-functions.
7013 (Fspecial_variable_p): New function.
7014 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7015 but without exporting it to Lisp.
23aba0ea 7016
23aba0ea 7017 * doc.c (Fdocumentation, store_function_docstring):
03408648 7018 * data.c (Finteractive_form): Handle closures.
23aba0ea 7019
03408648
SM
7020 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7021 interactive spec.
ba83908c 7022
04f2d78b
CB
7023 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7024 New byte-codes.
03408648
SM
7025 (exec_byte_code): New function extracted from Fbyte_code to handle new
7026 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7027
03408648 7028 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7029
03408648 7030 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7031
e2abce01
JB
70322011-03-31 Juanma Barranquero <lekktu@gmail.com>
7033
7034 * xdisp.c (redisplay_internal): Fix prototype.
7035
63696a73 70362011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7037
63696a73 7038 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7039 (try_scrolling): Use it when setting scroll_limit.
7040 Limit scrolling to 100 screen lines.
63696a73
EZ
7041 (redisplay_window): Even when falling back on "recentering",
7042 position point in the window according to scroll-conservatively,
7043 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7044
7045 (try_scrolling): When point is above the window, allow searching
7046 as far as scroll_max, or one screenful, to compute vertical
7047 distance from PT to the scroll margin position. This prevents
7048 try_scrolling from unnecessarily failing when
7049 scroll-conservatively is set to a value slightly larger than the
7050 window height. Clean up the case of PT below the margin at bottom
7051 of window: scroll_max can no longer be INT_MAX. When aggressive
7052 scrolling is in use, don't let point enter the opposite scroll
7053 margin as result of the scroll.
7054 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7055 threshold of 100 lines for never-recentering scrolling.
7056
e4cc2dfc
JB
70572011-03-31 Juanma Barranquero <lekktu@gmail.com>
7058
7059 * dispextern.h (move_it_by_lines):
7060 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7061 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7062 (message_log_check_duplicate): Remove parameters `prev_bol' and
7063 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7064 (redisplay_internal): Remove parameter `preserve_echo_area',
7065 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7066
7067 * indent.c (Fvertical_motion):
7068 * window.c (window_scroll_pixel_based, Frecenter):
7069 Don't pass `need_y_p' to `move_it_by_lines'.
7070
1c470562
SM
70712011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7072
44f230aa
SM
7073 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7074 steal a few bits to be more compact.
7075 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7076 Remove unneeded casts.
7077
1c470562
SM
7078 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7079
888adce9
ZK
70802011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7081
7082 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7083 binding" message (bug#7967).
7084
f838ed7b
PE
70852011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7086
77861b95
PE
7087 Fix more problems found by GCC 4.6.0's static checks.
7088
de6dbc14
PE
7089 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7090 Remove unused local var.
7091
f838ed7b
PE
7092 * editfns.c (Fmessage_box): Remove unused local var.
7093
792c7b2b
PE
7094 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7095 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7096 Omit unused local vars.
c499e557 7097 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7098 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7099 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7100 Omit unused local var.
7101
ba0165e1
PE
7102 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7103 Don't assume string length fits in int.
32ad8845 7104 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7105 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7106
3c59b4c9
PE
7107 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7108 instead of alloca (Bug#8344).
7109
a3eed478 7110 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7111 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7112
eb4d412d
PE
7113 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7114
1658b401
PE
7115 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7116 concerns.
7117
7118 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7119
7120 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7121
9a2c6e05
PE
7122 * keyboard.c (syms_of_keyboard): Use the same style as later
7123 in this function when indexing through an array. This also
7124 works around GCC bug 48267.
7125
03d0a109
PE
7126 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7127
44f730c8
PE
7128 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7129
fe75f926
PE
7130 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7131 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7132
ffa8c828
PE
7133 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7134 This avoids undefined behavior on integer overflow, and is a bit
7135 more convenient anyway since it is compared to a size_t variable.
7136
c5101a77
PE
7137 Variadic C functions now count arguments with size_t, not int.
7138 This avoids an unnecessary limitation on 64-bit machines, which
7139 caused (substring ...) to crash on large vectors (Bug#8344).
7140 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7141 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7142 All variadic functions and their callers changed accordingly.
c5101a77
PE
7143 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7144 * data.c (arith_driver, float_arith_driver): Likewise.
7145 * editfns.c (general_insert_function): Likewise.
7146 * eval.c (struct backtrace.nargs, interactive_p)
7147 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7148 (funcall_lambda, mark_backtrace): Likewise.
7149 * fns.c (concat): Likewise.
7150 * frame.c (x_set_frame_parameters): Likewise.
7151 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7152 0 if not found, not -1. All callers changed.
7153
dd3f25f7
PE
7154 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7155 (stack_copy_size): Now size_t, not int.
7156 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7157
461c2ab9
JB
71582011-03-28 Juanma Barranquero <lekktu@gmail.com>
7159
7160 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7161 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7162 All callers changed.
7163
7164 * lisp.h (multibyte_char_to_unibyte):
7165 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7166 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7167 * character.h (CHAR_TO_BYTE8):
7168 * cmds.c (internal_self_insert):
7169 * editfns.c (general_insert_function):
7170 * keymap.c (push_key_description):
7171 * search.c (Freplace_match):
7172 * xdisp.c (message_dolog, set_message_1): All callers changed.
7173
f6d62986
SM
71742011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7175
7176 * keyboard.c (safe_run_hook_funcall): New function.
7177 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7178 don't set the hook to nil, but remove the offending function instead.
7179 (Qcommand_hook_internal): Remove, unused.
7180 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7181 Vcommand_hook_internal.
7182
7183 * eval.c (enum run_hooks_condition): Remove.
7184 (funcall_nil, funcall_not): New functions.
7185 (run_hook_with_args): Call each function through a `funcall' argument.
7186 Remove `cond' argument, now redundant.
7187 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7188 (Frun_hook_with_args_until_failure): Adjust accordingly.
7189 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7190
1db5b1ad
JB
71912011-03-28 Juanma Barranquero <lekktu@gmail.com>
7192
7193 * dispextern.h (string_buffer_position): Remove declaration.
7194
7195 * print.c (strout): Remove parameter `multibyte', unused since
7196 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7197
7198 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7199 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7200 All callers changed.
7201
7202 * w32.c (_wsa_errlist): Use braces for struct initializers.
7203
7204 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7205 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7206 All callers changed.
7207 (string_buffer_position): Likewise. Also, make static (it's never
7208 used outside xdisp.c).
7209 (cursor_row_p): Remove parameter `w', unused since
7210 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7211 (decode_mode_spec): Remove parameter `precision', introduced during
7212 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7213 All callers changed.
7214
5ffb62aa
JD
72152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7216
7217 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7218
461c2ab9 72192011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7220
7221 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7222 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7223 (ns_update_auto_hide_menu_bar): New functions.
7224 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7225 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7226 ns_constrain_all_frames.
7227 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7228 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7229
5c380ffb
JD
72302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7231
7232 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7233
9af30bdf
GM
72342011-03-27 Glenn Morris <rgm@gnu.org>
7235
7236 * syssignal.h: Replace RETSIGTYPE with void.
7237 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7238 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7239 Replace SIGTYPE with void everywhere.
7240 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7241 * s/template.h (SIGTYPE): Remove commented out definition.
7242
e2abce01
JB
72432011-03-26 Eli Zaretskii <eliz@gnu.org>
7244
7245 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7246 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7247
f868cd8a
JB
72482011-03-26 Juanma Barranquero <lekktu@gmail.com>
7249
59eb0929
JB
7250 * w32.c (read_unc_volume): Use parameter `henum', instead of
7251 global variable `wget_enum_handle'.
7252
7253 * keymap.c (describe_vector): Remove parameters `indices' and
7254 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7255 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7256
f868cd8a
JB
7257 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7258
7259 * keyboard.c (timer_check): Remove parameter `do_it_now',
7260 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7261 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7262 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7263
7264 * keyboard.c (read_char):
7265 * w32menu.c (w32_menu_display_help):
7266 * xmenu.c (show_help_event, menu_help_callback):
7267 Adjust calls to `show_help_echo'.
7268
7269 * gtkutil.c (xg_maybe_add_timer):
7270 * keyboard.c (readable_events):
7271 * process.c (wait_reading_process_output):
7272 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7273
7274 * insdel.c (adjust_markers_gap_motion):
7275 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7276 (gap_left, gap_right): Don't call it.
7277
2ecf6fdb
CY
72782011-03-25 Chong Yidong <cyd@stupidchicken.com>
7279
7280 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7281 incurred during fontification.
7282
6b1f9ba4
JB
72832011-03-25 Juanma Barranquero <lekktu@gmail.com>
7284
7285 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7286 (DEFVAR_PER_BUFFER): Don't pass it.
7287
7288 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7289 (scrolling_window): Don't pass it.
7290
0f4a96b5
JB
72912011-03-25 Juanma Barranquero <lekktu@gmail.com>
7292
7293 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7294
7295 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7296 and `suffix'.
7297 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7298 of variables specific to SELinux and computation of `encoded_absname'.
7299
7300 * image.c (XPutPixel): Remove unused variable `height'.
7301
7302 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7303
7304 * unexw32.c (get_section_info): Remove unused variable `section'.
7305
7306 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7307 (system_process_attributes): Remove unused variable `sess'.
7308 (sys_read): Remove unused variable `err'.
7309
7310 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7311 (w32_wnd_proc): Remove unused variable `isdead'.
7312 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7313 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7314 (x_create_tip_frame): Remove unused variable `tem'.
7315
7316 * w32inevt.c (w32_console_read_socket):
7317 Remove unused variable `no_events'.
7318
7319 * w32term.c (x_draw_composite_glyph_string_foreground):
7320 Remove unused variable `width'.
7321
1149507c
JB
73222011-03-24 Juanma Barranquero <lekktu@gmail.com>
7323
7324 * w32term.c (x_set_glyph_string_clipping):
7325 Don't pass uninitialized region to CombineRgn.
7326
9c88f339
JB
73272011-03-23 Juanma Barranquero <lekktu@gmail.com>
7328
7329 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7330 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7331 (Fx_close_connection): Remove unused variable `i'.
7332
7333 * w32font.c (w32font_draw): Return number of glyphs.
7334 (w32font_open_internal): Remove unused variable `i'.
7335 (w32font_driver): Add missing initializer.
7336
7337 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7338 (fill_in_menu): Remove unused variable `items_added'.
7339
7340 * w32term.c (last_mouse_press_frame): Remove static global variable.
7341 (w32_clip_to_row): Remove unused variable `f'.
7342 (x_delete_terminal): Remove unused variable `i'.
7343
7344 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7345 (NOTHING): Remove unused static global variable.
7346 (uniscribe_check_otf): Remove unused variable `table'.
7347 (uniscribe_font_driver): Add missing initializers.
7348
dee091a3
JD
73492011-03-23 Julien Danjou <julien@danjou.info>
7350
7351 * term.c (Fsuspend_tty, Fresume_tty):
7352 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7353 * window.c (temp_output_buffer_show):
7354 * insdel.c (signal_before_change):
7355 * frame.c (Fhandle_switch_frame):
7356 * fileio.c (Fdo_auto_save):
7357 * emacs.c (Fkill_emacs):
7358 * editfns.c (save_excursion_restore):
7359 * cmds.c (internal_self_insert):
7360 * callint.c (Fcall_interactively):
7361 * buffer.c (Fkill_all_local_variables):
7362 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7363 Use Frun_hooks.
0f4a96b5 7364 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7365 unconditionnaly since it does the check itself.
7366
2c520ab5 73672011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7368
c9c49752
PE
7369 Fix more problems found by GCC 4.5.2's static checks.
7370
8abc3f12
PE
7371 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7372 the first time through the loop, since we know p0 < p1 then.
7373 This also avoids a gcc -Wstrict-overflow warning.
7374
a2d26660
PE
7375 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7376 leading to a memory leak, possible in functions like
7377 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7378 of objects (Bug#8318).
a2d26660 7379
916c72e9
PE
7380 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7381 that could (at least in theory) be that large.
7382
19ab8a18
PE
7383 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7384 This is less likely to overflow, and avoids undefined behavior if
7385 overflow does occur. All callers changed. Use strtoul to scan
7386 for the unsigned long integer.
b7cbbd6f
PE
7387 (pint2hrstr): Simplify and tune code slightly.
7388 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7389
f0641eff
PE
7390 * scroll.c (do_scrolling): Work around GCC bug 48228.
7391 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7392
7f650bb9
PE
7393 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7394 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7395 (validate_x_resource_name): Simplify count usage.
7396 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7397
37dd57d1
PE
7398 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7399 fail (Bug#8306).
81e56e61 7400
699979fc 7401 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7402
401bf9b4
PE
7403 * process.c (Fmake_network_process): Use socklen_t, not int,
7404 where POSIX says socklen_t is required in portable programs.
7405 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7406 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7407 (Fmake_network_process, server_accept_connection):
7408 (wait_reading_process_output, read_process_output):
7409 Likewise.
7410
b93aacde
PE
7411 * process.c: Rename or move locals to avoid shadowing.
7412 (list_processes_1, Fmake_network_process):
7413 (read_process_output_error_handler, exec_sentinel_error_handler):
7414 Rename or move locals.
4dc343ee 7415 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7416 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7417 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7418 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7419 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7420
af8a867c 7421 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7422 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7423 Include tparam.h instead, since it declares them.
af8a867c
PE
7424 * cm.h (PC): Remove extern decl; tparam.h now does this.
7425 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7426 * terminfo.c: Include tparam.h, to check interfaces.
7427 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7428 (tparam): Adjust signature to match interface in tparam.h;
7429 this removes some undefined behavior. Check that outstring and len
7430 are zero, which they always are with Emacs.
7431 * tparam.h (PC, BC, UP): New extern decls.
7432
0248044d 7433 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7434 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7435
8ff096c1 7436 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7437 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7438 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7439 (ftfont_list): Remove unused local.
49eaafba
PE
7440 (get_adstyle_property, ftfont_pattern_entity):
7441 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7442 Rename locals to avoid shadowing.
8ff096c1 7443
e2be39f6
PE
7444 * xfont.c (xfont_list_family): Mark var as initialized.
7445
c9735e30
PE
7446 * xml.c (make_dom): Now static.
7447
8f5201ae
PE
7448 * composite.c (composition_compute_stop_pos): Rename local to
7449 avoid shadowing.
b246f932
PE
7450 (composition_reseat_it): Remove unused locals.
7451 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7452 (composition_update_it): Mark var as initialized.
11b61122
PE
7453 (find_automatic_composition): Mark vars as initialized,
7454 with a FIXME (Bug#8290).
8f5201ae 7455
760fbc2c
PE
7456 character.h: Rename locals to avoid shadowing.
7457 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7458 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7459 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7460 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7461 to avoid shadowing.
7462
ff08eb85
PE
7463 * textprop.c (property_change_between_p): Remove; unused.
7464
fc7bf025
PE
7465 * intervals.c (interval_start_pos): Now static.
7466
235d7abc
PE
7467 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7468
44f230aa
SM
7469 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7470 Rename locals to avoid shadowing.
3e7d6594 7471
50060332
PE
7472 * sound.c (wav_play, au_play, Fplay_sound_internal):
7473 Fix pointer signedness.
d01f234b 7474 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7475 (wav_play): Initialize a variable to 0, to prevent undefined
7476 behavior (Bug#8278).
50060332 7477
c4fc4e30
PE
7478 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7479
918436ed
PE
7480 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7481
c939f91b
PE
7482 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7483 clobbering (Bug#8298).
b9c7f648
PE
7484 * sysdep.c (sys_subshell): Likewise.
7485 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7486
6bd8c144
PE
7487 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7488 This should get cleaned up, so that child_setup has the
7489 same signature on all platforms.
7490
7710357c 7491 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7492 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7493
c59da222
CY
74942011-03-22 Chong Yidong <cyd@stupidchicken.com>
7495
7496 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7497 not to be necessary, and produces flickering.
7498
66b87493
GM
74992011-03-20 Glenn Morris <rgm@gnu.org>
7500
7501 * config.in: Remove file.
7502
45b6f6d5
JB
75032011-03-20 Juanma Barranquero <lekktu@gmail.com>
7504
7505 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7506 are now in src/globals.h.
7507 (syms_of_minibuf): Remove spurious & from previous change.
7508
3ec03f7e
LL
75092011-03-20 Leo <sdl.web@gmail.com>
7510
7511 * minibuf.c (completing-read-function): New variable.
7512 (completing-read-default): Rename from completing-read.
7513 (completing-read): Call completing-read-function.
7514
b14e3e21
CY
75152011-03-19 Juanma Barranquero <lekktu@gmail.com>
7516
7517 * xfaces.c (Fx_load_color_file):
7518 Read color file from absolute filename (bug#8250).
7519
f2b726e6
JB
75202011-03-19 Juanma Barranquero <lekktu@gmail.com>
7521
7522 * makefile.w32-in: Update dependencies.
7523
09f6ff02
EZ
75242011-03-17 Eli Zaretskii <eliz@gnu.org>
7525
7526 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7527
29a6015a
PE
75282011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7529
a3a6c54e
PE
7530 Fix more problems found by GCC 4.5.2's static checks.
7531
b766f867
PE
7532 * process.c (make_serial_process_unwind, send_process_trap):
7533 (sigchld_handler): Now static.
7534
be02381c
PE
7535 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7536 That way, the code declares only the vars that it needs.
7537 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7538 * s/cygwin.h (PTY_ITERATION): Likewise.
7539 * s/darwin.h (PTY_ITERATION): Likewise.
7540 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7541
57048744
PE
7542 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7543 * process.c (allocate_pty): Don't declare stb unless it's needed.
7544
7914961c 7545 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7546 (CONSTANTLIM): Remove; unused.
7547 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7548 Define only if needed.
7914961c 7549
b3967b18
PE
7550 * unexelf.c (unexec): Name an expression,
7551 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7552 Use a different way to cause a compilation error if anyone uses
7553 n rather than nn, a way that does not involve shadowing.
73366a00 7554 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7555
29a6015a
PE
7556 * deps.mk (unexalpha.o): Remove; unused.
7557
43cfc33e 7558 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7559 * unexec.h: New file.
ce701a33
PE
7560 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7561 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7562 Depend on unexec.h.
7563 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7564 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7565 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7566 Change as necessary to match prototype in unexec.h.
ce701a33 7567
01f44d5a
PE
7568 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7569 shadowing.
4f63c6bb 7570 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7571
a6670b0b
PE
7572 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7573 Rename locals to avoid shadowing.
7574
cef2010d 7575 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7576 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7577
d4d7173a
PE
7578 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7579
f08b802a
PE
7580 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7581 warning when compiling print.c.
7582
3ddb0639
PE
7583 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7584 instead of using an uninitialized var.
5ad03b97 7585 (font_sort_entities): Mark var as initialized.
3ddb0639 7586
170a2692
PE
7587 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7588
e663c700
PE
7589 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7590 pointers to constants.
89bc529a 7591 (font_parse_fcname): Remove unused vars.
7b81e2d0 7592 (font_delete_unmatched): Now static.
ea838e10 7593 (font_get_spec): Remove; unused.
13a547c6
PE
7594 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7595 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7596 Rename or move locals to avoid shadowing.
e663c700 7597
2a80c887 7598 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7599 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7600
1384fa33 7601 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7602 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7603
8b2c52e9
PE
7604 * alloc.c (mark_backtrace): Move decl from here ...
7605 * lisp.h: ... to here, so that it can be checked.
7606
475545b5 7607 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7608 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7609 (lisp_indirect_variable): Name an expression,
7610 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7611 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7612
b1349114 7613 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7614 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7615 Use const pointer when appropriate.
b1349114 7616
a2928364
PE
7617 * lisp.h (get_system_name, get_operating_system_release):
7618 Move decls here, to check interfaces.
7619 * process.c (get_operating_system_release): Move decl to lisp.h.
7620 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7621 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7622 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7623 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7624 (Fformat_time_string, Fencode_time, Finsert_char):
7625 (Ftranslate_region_internal, Fformat):
7626 Rename or remove local vars to avoid shadowing.
9710023e 7627 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7628
a415e694
PE
7629 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7630 avoid shadowing.
7631
8ef4622d
PE
7632 * lisp.h (eassert): Check that the argument compiles, even if
7633 ENABLE_CHECKING is not defined.
7634
946f9a5b
PE
7635 * data.c (Findirect_variable): Name an expression, to avoid
7636 gcc -Wbad-function-cast warning.
112396d6 7637 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7638 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7639 (Fmake_variable_buffer_local, Fmake_local_variable):
7640 Mark variables as initialized.
52746918 7641 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7642
e5aab7e7 7643 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7644 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7645 Rename locals to avoid shadowing.
dff45157
PE
7646 (mark_stack): Move local variables into the #ifdef region where
7647 they're used.
7bc26fdb
PE
7648 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7649 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7650 needed otherwise.
7651 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7652 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7653 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7654
e5aab7e7
PE
7655 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7656 avoids undefined behavior in theory.
7657
4da60324
PE
7658 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7659
88043301
PE
7660 Use functions, not macros, for up- and down-casing (Bug#8254).
7661 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7662 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7663 to use the following functions instead of these macros.
7664 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7665 EMACS_INT, since callers assume the returned value fits in int.
7666 (upcase1): Likewise, for UPCASE_TABLE.
7667 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7668 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7669 the race-condition problem in the old DOWNCASE.
88043301 7670
19ed5445
PE
7671 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7672 Rename locals to avoid shadowing.
7673 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7674 (regex_compile, re_search_2, re_match_2_internal):
7675 Remove unused local vars.
952db0d7
PE
7676 (FREE_VAR): Rewrite so as not to use empty "else",
7677 which gcc can warn about.
da053e48 7678 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7679 (RETALLOC_IF): Define only if needed.
7680 (WORDCHAR_P): Likewise. This one is never needed, but is used
7681 only in a comment talking about a compiler bug, so put inside
7682 the #if 0 of that comment.
7683 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7684 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7685 Remove; unused.
19ed5445 7686
1f3561e4 7687 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7688 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7689 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7690
ded6f8f7
PE
7691 * search.c (simple_search): Remove unused var.
7692
dbd37a95
PE
7693 * dired.c (compile_pattern): Move decl from here ...
7694 * lisp.h: ... to here, so that it can be checked.
7695 (struct re_registers): New forward decl.
7696
7e47afad
PE
7697 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7698
85f24f61
PE
7699 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7700 All uses changed.
7701 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7702 Rename locals to avoid shadowing.
5671df8f 7703 (Fvertical_motion): Mark locals as initialized.
85f24f61 7704
181aa2be 7705 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7706 (casify_region): Mark local as initialized.
181aa2be 7707
930d429c
PE
7708 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7709
7082eac6
PE
7710 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7711 New macros, so that the caller can use some names other than
7712 gcpro1, gcpro2, etc.
7713 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7714 of the new macros.
7715 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7716 argument, for consistency with GCPRO2_VAR, etc: it is now the
7717 prefix of the variable, not the variable itself. All uses
7718 changed.
38b2c076
PE
7719 * dired.c (directory_files_internal, file_name_completion):
7720 Rename locals to avoid shadowing.
7721
15206ed9
PE
7722 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7723 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7724 dired.c's scmp function, had undefined behavior.
7725 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7726 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7727 * buffer.h: ... to here, because these macros use current_buffer,
7728 and the new implementation with inline functions needs to have
7729 current_buffer in scope now, rather than later when the macros
7730 are used.
7731 (downcase, upcase1): New static inline functions.
7732 (DOWNCASE, UPCASE1): Reimplement using these functions.
7733 This avoids undefined behavior in expressions like
7734 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7735 from race conditions in accessing the global variables
7736 case_temp1 and case_temp2.
7737 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7738 * lisp.h (case_temp1, case_temp2): Remove their decls.
7739 * character.h (ASCII_CHAR_P): Move from here ...
7740 * lisp.h: ... to here, so that the inline functions mentioned
7741 above can use them.
7742
4a6bea26
PE
7743 * dired.c (directory_files_internal_unwind): Now static.
7744
f14b7e14
PE
7745 * fileio.c (file_name_as_directory, directory_file_name):
7746 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7747 Now static.
2893f146
PE
7748 (file_name_as_directory): Use const pointers when appropriate.
7749 (Fexpand_file_name): Likewise. In particular, newdir might
7750 point at constant storage, so make it a const pointer.
fd4ead52 7751 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7752 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7753 signedness issues.
f839df0c
PE
7754 (Fset_file_times, Finsert_file_contents, auto_save_error):
7755 Rename locals to avoid shadowing.
f14b7e14 7756
5716756e 7757 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7758 (Ftry_completion, Fall_completions): Rename or remove locals
7759 to avoid shadowing.
5716756e 7760
b4c3046a
PE
7761 * marker.c (bytepos_to_charpos): Remove; unused.
7762
b45db522
PE
7763 * lisp.h (verify_bytepos, count_markers): New decls,
7764 so that gcc does not warn that these functions aren't declared.
7765
85876d07
PE
7766 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7767 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7768 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7769 (copy_text): Remove unused local var.
85876d07 7770
03d78a21 7771 * filelock.c (within_one_second): Now static.
b3dd38ab 7772 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7773
5df8f01b
PE
7774 * buffer.c (fix_overlays_before): Mark locals as initialized.
7775 (fix_start_end_in_overlays): Likewise. This function should be
7776 simplified by using pointers-to-pointers, but that's a different
7777 matter.
b1d876f1 7778 (switch_to_buffer_1): Now static.
8f54f30a
PE
7779 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7780 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7781
a70072c9 7782 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7783 Fix pointer signedness issue.
edced198
PE
7784 (sys_subshell): Mark local as volatile if checking for lint,
7785 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7786 (MAXPATHLEN): Define only if needed.
a70072c9 7787
a0977c44
PE
7788 * process.c (serial_open, serial_configure): Move decls from here ...
7789 * systty.h: ... to here, so that they can be checked.
7790
a884fdcc
PE
7791 * fns.c (get_random, seed_random): Move extern decls from here ...
7792 * lisp.h: ... to here, so that they can be checked.
7793
604efe86 7794 * sysdep.c (reset_io): Now static.
b8950c94 7795 (wait_for_termination_signal): Remove; unused.
604efe86 7796
38fc62d9
PE
7797 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7798 (copy_keymap_item, append_key, push_text_char_description):
7799 Now static.
1004a21a 7800 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7801 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7802 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7803 (describe_map_tree):
7804 Rename locals to avoid shadowing.
38fc62d9 7805
2f2650da
PE
7806 * keyboard.c: Declare functions static if they are not used elsewhere.
7807 (echo_char, echo_dash, cmd_error, top_level_2):
7808 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7809 (read_char, kbd_buffer_get_event, make_lispy_position):
7810 (make_lispy_event, make_lispy_movement, apply_modifiers):
7811 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7812 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7813 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7814 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7815 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7816
a053e86c 7817 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7818 (mark_kboards): Move decl here ...
7819 * alloc.c (mark_kboards): ... from here.
a053e86c 7820
4752793e
PE
7821 * lisp.h (force_auto_save_soon): New decl.
7822
74f10ca7 7823 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7824 (DEFINE_DUMMY_FUNCTION): New macro.
7825 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7826 Use it.
c03cd23f
PE
7827 (main): Add casts to avoid warnings
7828 if GCC considers string literals to be constants.
74f10ca7 7829
022e70d4
PE
7830 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7831
59d6fe83
PE
7832 * dbusbind.c: Pointer signedness fixes.
7833 (xd_signature, xd_append_arg, xd_initialize):
7834 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7835 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7836 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7837 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7838
78320123
PE
7839 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7840 if GCC considers string literals to be constants.
49cebcca 7841 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7842
35ac2a97
SM
78432011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7844
fb103ca9
SM
7845 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7846 (print_preprocess, print_object): New macro to fix last change.
7847
35ac2a97
SM
7848 * print.c (print_preprocess): Don't forget font objects.
7849
62973b41
JB
78502011-03-16 Juanma Barranquero <lekktu@gmail.com>
7851
7852 * emacs.c (USAGE3): Doc fixes.
7853
0e48bb22
AS
78542011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7855
7856 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7857 structure.
7858
7684e57b
JB
78592011-03-14 Juanma Barranquero <lekktu@gmail.com>
7860
7861 * lisp.h (VWindow_system, Qfile_name_history):
7862 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7863 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7864 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7865
7866 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7867 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7868
7869 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7870 * w32console.c (detect_input_pending, read_input_pending)
7871 (encode_terminal_code):
7872 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7873 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7874 (w32_system_caret_y, Qfile_name_history):
7875 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7876 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7877 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7878 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7879 * w32proc.c (Qlocal, report_file_error):
7880 * w32term.c (Vwindow_system, updating_frame):
7881 * w32uniscribe.c (initialized, uniscribe_font_driver):
7882 Remove unneeded extern declarations.
7883
2aa46d6c
CY
78842011-03-14 Chong Yidong <cyd@stupidchicken.com>
7885
c96bbc66 7886 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7887
cffc6f3b
CY
78882011-03-13 Chong Yidong <cyd@stupidchicken.com>
7889
7890 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7891 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7892 These macros can no longer be used for assignment.
7893
44f230aa
SM
7894 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7895 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7896 (record_buffer_markers, fetch_buffer_markers): New functions for
7897 recording and fetching special buffer markers.
7898 (set_buffer_internal_1, set_buffer_temp): Use them.
7899
7900 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7901
7902 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7903
7904 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7905 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7906
7907 * xdisp.c (hscroll_window_tree):
7908 (reconsider_clip_changes): Use PT instead of BUF_PT.
7909
d251f04b
EZ
79102011-03-13 Eli Zaretskii <eliz@gnu.org>
7911
7912 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7913 $(EMACS_ROOT)/lib/intprops.h.
7914
f0c77cd1
PE
79152011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7916
3eca4629
PE
7917 Fix more problems found by GCC 4.5.2's static checks.
7918
7c86ee98
PE
7919 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7920 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7921 (xg_free_frame_widgets): Make it clear that a local variable is
7922 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7923 (gdk_window_get_screen): Make it clear that this macro is needed
7924 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7925 (int_gtk_range_get_value): New function, which avoids a diagnostic
7926 from gcc -Wbad-function-cast.
7927 (xg_set_toolkit_scroll_bar_thumb): Use it.
7928 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7929 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7930 (get_utf8_string, xg_get_file_with_chooser):
7931 Rename locals to avoid shadowing.
7932 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7933
41729b81
PE
7934 * xgselect.c (xg_select): Remove unused var.
7935
f0c77cd1
PE
7936 * image.c (four_corners_best): Mark locals as initialized.
7937 (gif_load): Initialize transparent_p to zero (Bug#8238).
7938 Mark another local as initialized.
ec6cf4c6 7939 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7940
ce0ad53d 7941 * image.c (clear_image_cache): Now static.
d5d5a617 7942 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7943 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7944 (x_edge_detection): Remove unnecessary cast that
7945 gcc -Wbad-function-cast diagnoses.
2037898d 7946 (gif_load): Fix pointer signedness.
6ae141d6
PE
7947 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7948 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7949
33383987 79502011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7951
d32df629
PE
7952 Improve quality of tests for time stamp overflow.
7953 For example, without this patch (encode-time 0 0 0 1 1
7954 1152921504606846976) returns the obviously-bogus value (-948597
7955 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7956 reports time overflow. See
7957 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7958 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7959 * editfns.c: Include limits.h and intprops.h.
7960 (TIME_T_MIN, TIME_T_MAX): New macros.
7961 (time_overflow): Move earlier, to before first use.
7962 (hi_time, lo_time): New functions, for an accurate test for
7963 out-of-range times.
7964 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7965 (Fget_internal_run_time): Don't assume time_t fits in int.
7966 (make_time): Use list2 instead of Fcons twice.
7967 (Fdecode_time): More accurate test for out-of-range times.
7968 (check_tm_member): New function.
7969 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7970 (lisp_time_argument): Don't rely on undefined left-shift and
7971 right-shift behavior when checking for time stamp overflow.
8be6f318 7972
fe31d94c
PE
7973 * editfns.c (time_overflow): New function, refactoring common code.
7974 (Fformat_time_string, Fdecode_time, Fencode_time):
7975 (Fcurrent_time_string): Use it.
7976
8be6f318
PE
7977 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7978 * dired.c (make_time): Move to ...
7979 * editfns.c (make_time): ... here.
7980 * systime.h: Note the move.
7981
09d9db2c 79822011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7983
126bc0dc
YM
7984 * fringe.c (update_window_fringes): Remove unused variables.
7985
c47cbdfd
YM
7986 * unexmacosx.c (copy_data_segment): Also copy __got section.
7987 (Bug#8223)
7988
7ac80be9
EZ
79892011-03-12 Eli Zaretskii <eliz@gnu.org>
7990
c96bbc66 7991 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7992 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7993 Constify `char *' arguments and their references according to
7994 prototypes in tparam.h.
7995
ecb0f94d 7996 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7997
7ac80be9
EZ
7998 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7999 Adapt all references accordingly.
8000
8001 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8002
ef1fd07e
TT
80032011-03-11 Tom Tromey <tromey@redhat.com>
8004
8005 * buffer.c (syms_of_buffer): Remove obsolete comment.
8006
7ef4b50c
EZ
80072011-03-11 Eli Zaretskii <eliz@gnu.org>
8008
8009 * termhooks.h (encode_terminal_code): Declare prototype.
8010
8011 * msdos.c (encode_terminal_code): Don't declare prototype.
8012
8013 * term.c (encode_terminal_code): Now external again, used by
8014 w32console.c and msdos.c.
8015
44f230aa
SM
8016 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8017 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8018
4b1ec863 80192011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8020
1714f52b 8021 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8022
4b1ec863
PE
8023 * fringe.c (update_window_fringes): Mark locals as initialized
8024 (Bug#8227).
8025 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8026
524c7aa6
PE
8027 * alloc.c (mark_fringe_data): Move decl from here ...
8028 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8029 to check its interface.
8030 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8031
a5c0af81 8032 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8033 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8034 (fontset_font): Mark local as initialized.
a9a06e0b 8035 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8036
b4716021
PE
8037 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8038
811e9bac 8039 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8040 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8041 (x_own_selection, Fx_disown_selection_internal): Rename locals
8042 to avoid shadowing.
8043 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8044
7e3ab302
PE
8045 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8046 so that the caller can use some name other than gcpro1.
8047 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8048 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8049 (Fx_backspace_delete_keys_p):
8050 Use them to avoid shadowing, and rename vars to avoid shadowing.
8051 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8052 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8053 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8054 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8055 Remove unused locals.
7e3ab302
PE
8056 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8057 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8058 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8059 macros.
f78faa98 8060
e2b13473
PE
8061 * xterm.h (x_mouse_leave): New decl.
8062
77f23912
PE
8063 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8064 Remove unused functions.
cdf4ba58
PE
8065 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8066 (x_calc_absolute_position): Now static.
7411c686 8067 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8068 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8069 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8070 unless they are used.
38d0b34a
PE
8071 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8072 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8073 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8074 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8075 (x_error_catcher, x_connection_closed, x_error_handler):
8076 (x_error_quitter, xembed_send_message, x_iconify_frame):
8077 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8078 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8079 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8080
44f230aa
SM
8081 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8082 Rename or move locals to avoid shadowing.
6b463e58 8083 (tty_defined_color, merge_face_heights): Now static.
5967d051 8084 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8085 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8086 does not deduce is never used uninitialized.
73719eba
PE
8087 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8088 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8089
426994c3 8090 * terminal.c (store_terminal_param): Now static.
5489860b 8091
032f1620 8092 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8093 (set_frame_menubar): Remove unused local.
d4323972 8094 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8095 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8096 since they might point to immutable storage.
281585b0
PE
8097 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8098 since it's unused otherwise.
032f1620 8099
367c19e5 8100 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8101 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8102 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8103 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8104 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8105 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8106 does not deduce are never used uninitialized.
70739cbe 8107
07b48fa9
PE
8108 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8109
8868a238 8110 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8111 * window.c (window_loop, size_window):
8112 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8113
7e5cf297 8114 * window.c (display_buffer): Now static.
d6550a9f
PE
8115 (size_window): Mark variables that gcc -Wuninitialized
8116 does not deduce are never used uninitialized.
a586633d
PE
8117 * window.h (check_all_windows): New decl, to forestall
8118 gcc -Wmissing-prototypes diagnostic.
5b555da1 8119 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8120
f6095868
PE
8121 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8122 shadowing.
8123 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8124 Include <limits.h>.
8125 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8126 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8127 (load_charset_map): Mark variables that gcc -Wuninitialized
8128 does not deduce are never used uninitialized.
53df7c11 8129 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8130
f38b440c
PE
8131 * coding.c (coding_set_source, coding_set_destination):
8132 Use "else { /* comment */ }" rather than "else /* comment */;"
8133 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8134 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8135 a block, when the outer 'i' will do.
8136 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8137 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8138 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8139 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8140 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8141 Rename locals to avoid shadowing.
8142 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8143 * coding.c (emacs_mule_char, encode_invocation_designation):
8144 Now static, since they're not used elsewhere.
413bb2db 8145 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8146 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8147 (decode_coding_emacs_mule): Mark variables that gcc
8148 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8149 (detect_coding_iso_2022): Initialize a local variable that might
8150 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8151 this initialization is needed. (Bug#8211)
5f58e762
PE
8152 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8153 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8154 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8155 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8156 Remove unused macros.
f38b440c 8157
232b38b9 8158 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8159 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8160 * character.c (string_count_byte8): Likewise.
232b38b9 8161
fb90da1b
PE
8162 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8163 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8164
fb93dbc2
PE
8165 * chartab.c (copy_sub_char_table): Now static, since it's not used
8166 elsewhere.
5c156ace
PE
8167 (sub_char_table_ref_and_range, char_table_ref_and_range):
8168 Rename locals to avoid shadowing.
bbcd0949 8169 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8170
7d3b3862 8171 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8172 (BIDI_BOB): Remove unused macro.
7d3b3862 8173
6be7d3da
PE
8174 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8175 deduce are never used uninitialized.
c2ed9c8b 8176 * term.c (encode_terminal_code): Likewise.
6be7d3da 8177
75f8807f 8178 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8179
50938595
PE
8180 * tparam.h: New file.
8181 * term.c, tparam.h: Include it.
8182 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8183 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8184 Move these decls to tparam.h, and make them agree with what
8185 is actually in tparam.c. The previous trick of using incompatible
8186 decls in different modules does not conform to the C standard.
8187 All callers of tparam changed to use tparam's actual API.
8188 * tparam.c (tparam1, tparam, tgoto):
8189 Use const pointers where appropriate.
8190
fbceeba2
PE
8191 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8192 * cm.h (struct cm): Likewise.
8193 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8194 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8195 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8196 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8197 (turn_on_face, init_tty): Likewise.
8198 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8199
7f3f1250
PE
8200 * term.c (term_mouse_position): Rename local to avoid shadowing.
8201
e6ca6543
PE
8202 * alloc.c (mark_ttys): Move decl from here ...
8203 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8204
c40f8d15
AS
82052011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8206
8207 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8208
cfe0661d
JB
82092011-03-09 Juanma Barranquero <lekktu@gmail.com>
8210
8211 * search.c (compile_pattern_1): Remove argument regp, unused since
8212 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8213 (compile_pattern): Don't pass it.
8214
0afb4571
J
82152011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8216
8217 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8218 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8219 for ! HAVE_GTK3.
8220 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8221
8222 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8223
8224 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8225 gdk_window_get_screen, gdk_window_get_geometry,
8226 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8227 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8228 (xg_get_pixbuf_from_pixmap): New function.
8229 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8230 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8231 Call xg_get_pixbuf_from_pixmap instead of
8232 gdk_pixbuf_get_from_drawable.
8233 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8234 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8235 (xg_check_special_colors): Use GtkStyleContext and its functions
8236 for HAVE_GTK3.
8237 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8238 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8239 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8240 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8241 Call gtk_widget_get_preferred_size.
0afb4571
J
8242 (xg_frame_resized): gdk_window_get_geometry only takes 5
8243 parameters.
44f230aa
SM
8244 (xg_win_to_widget, xg_event_is_for_menubar):
8245 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8246 (xg_set_widget_bg): New function.
8247 (delete_cb): New function.
895009e1 8248 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8249 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8250 (xg_set_background_color): Call xg_set_widget_bg.
8251 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8252 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8253 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8254 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8255 if ! HAVE_GTK3.
8256 (update_frame_tool_bar): Call gtk_widget_hide.
8257 (xg_initialize): Use GDK_KEY_g.
8258
8259 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8260 if ! HAVE_GTK3
8261 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8262
8263 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8264 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8265 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8266
1c2cc4ef
JB
82672011-03-08 Juanma Barranquero <lekktu@gmail.com>
8268
8269 * w32xfns.c (select_palette): Check success of RealizePalette against
8270 GDI_ERROR, not zero.
8271
33383987 8272See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8273
8274;; Local Variables:
8275;; coding: utf-8
aac0c6e3
MR
8276;; End:
8277
33383987 8278 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8279
8280 This file is part of GNU Emacs.
8281
8282 GNU Emacs is free software: you can redistribute it and/or modify
8283 it under the terms of the GNU General Public License as published by
8284 the Free Software Foundation, either version 3 of the License, or
8285 (at your option) any later version.
8286
8287 GNU Emacs is distributed in the hope that it will be useful,
8288 but WITHOUT ANY WARRANTY; without even the implied warranty of
8289 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8290 GNU General Public License for more details.
8291
8292 You should have received a copy of the GNU General Public License
8293 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.