* data.c (Fsubr_name): Rewrite to avoid a strlen call.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
eb49b136
PE
12011-06-19 Paul Eggert <eggert@cs.ucla.edu>
2
f3e92b69
PE
3 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4
1bfdaf10
PE
5 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6
35016e9a
PE
7 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8
3d1e65a1
PE
9 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10 We prefer signed integers, even for size calculations.
11
0b963a93
PE
12 * emacs.c: Don't assume string length fits in 'int'.
13 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
14 (main): Don't invoke strlen when not needed.
15
573f4b54
PE
16 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
17 (XD_DEBUG_MESSAGE): Don't waste a byte.
18
989f33ba
PE
19 * callproc.c (getenv_internal_1, getenv_internal)
20 (Fgetenv_internal):
965d34eb
PE
21 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
22
e4d29b33
PE
23 * lread.c (invalid_syntax): Omit length argument.
24 All uses changed. This doesn't fix a bug, but it simplifies the
25 code away from its former Hollerith-constant appearance, and it's
26 one less 'int' to worry about when looking at integer-overflow issues.
f14ed477 27 (string_to_number): Simplify the 2011-04-26 change by invoking xsignal1.
e4d29b33 28
eb49b136
PE
29 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
30 This didn't break anything, but it didn't help either.
31 It's confusing to put a bogus integer in a place where the actual
32 value does not matter.
9f62aeb1 33 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 34 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 35
e39e811e
PE
362011-06-18 Paul Eggert <eggert@cs.ucla.edu>
37
15375a22
PE
38 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
39 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
40 implementation.
b61cc01c
PE
41 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
42 We prefer signed types, and the value cannot exceed the EMACS_INT
43 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
44 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
45 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
46 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 47
53b2623d
PE
48 * indent.c (sane_tab_width): New function.
49 (current_column, scan_for_column, Findent_to, position_indentation)
50 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 51 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 52
45aebb64
PE
53 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
54
f2ed8a70
PE
55 * lisp.h (lint_assume): New macro.
56 * composite.c (composition_gstring_put_cache):
57 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
58
abe80cc6
PE
59 * editfns.c, insdel.c:
60 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 61
b02c740e
PE
62 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
63
ebc96716
PE
64 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
65
b4e50fa0 66 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 67 Use much-faster test for byte-length change.
311d5d7c 68 Don't assume string byte-length fits in 'int'.
a4cf38e4 69 Check that character arg fits in 'int'.
85461888 70 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 71
c0c1ee9f
PE
72 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
73
a498d7f4
PE
74 * fns.c (concat): Catch string overflow earlier.
75 Do not rely on integer wraparound.
76
e39e811e
PE
77 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
78
fadf4e30
PE
792011-06-17 Paul Eggert <eggert@cs.ucla.edu>
80
87830974
PE
81 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
82 * xdisp.c (forward_to_next_line_start)
83 (back_to_previous_visible_line_start)
84 (reseat_at_next_visible_line_start, next_element_from_buffer):
85 Don't arbitrarily truncate the value of 'selective' to int.
86
76031fad
PE
87 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
88
5eb55db9
PE
89 * composite.c: Don't truncate sizes to 'int'.
90 (composition_gstring_p, composition_reseat_it)
91 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
92 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
93 not EMACS_UINT, for indexes.
5eb55db9 94
0703a717
PE
95 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
96
d6202519
PE
97 * buffer.c: Include <verify.h>.
98 (struct sortvec.priority, struct sortstr.priority):
8961a454 99 Now EMACS_INT, not int.
c20998a7 100 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
101 (struct sortstr.size, record_overlay_string)
102 (struct sortstrlist.size, struct sortlist.used):
103 Don't truncate size to int.
104 (record_overlay_string): Check for size-calculation overflow.
d6202519 105 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 106
28177add
PE
1072011-06-16 Paul Eggert <eggert@cs.ucla.edu>
108
dd3482fe
PE
109 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
110 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
111 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
112
393d71f3 113 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
114 * fileio.c (Finsert_file_contents):
115 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
116 Remove the old (too-loose) buffer overflow checks.
117 They weren't needed, since make_gap checks for buffer overflow.
118 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
119 The old code merely checked for Emacs fixnum overflow, and relied
120 on undefined (wraparound) behavior. The new code avoids undefined
121 behavior, and also checks for ptrdiff_t and/or size_t overflow.
122
2e6813b0 123 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
124 Tune. Don't use wider integers than needed. Don't use alloca.
125 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 126
599a9e4f
PE
127 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
128
99561444
PE
129 * insdel.c, lisp.h (buffer_overflow): New function.
130 (insert_from_buffer_1, replace_range, replace_range_2):
131 * insdel.c (make_gap_larger):
132 * editfns.c (Finsert_char):
133 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
134
28177add
PE
135 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
136
e69dafad
PE
1372011-06-15 Paul Eggert <eggert@cs.ucla.edu>
138
a7af7fde 139 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 140
b1c46f02
PE
141 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
142 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
143
e69dafad
PE
144 * fileio.c: Don't assume EMACS_INT fits in off_t.
145 (emacs_lseek): New static function.
146 (Finsert_file_contents, Fwrite_region): Use it.
147 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
148
566684ea
PE
149 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
150
e6966cd6
PE
151 * fns.c: Don't overflow int when computing a list length.
152 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
153 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
154 truncation on 64-bit hosts. Check for QUIT every
155 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
156 faster and is responsive enough.
157 (Flength): Report an error instead of overflowing an integer.
158 (Fsafe_length): Return a float if the value is not representable
159 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 160 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 161 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 162
dd0b0efb
PE
163 * alloc.c: Check that resized vectors' lengths fit in fixnums.
164 (header_size, word_size): New constants.
165 (allocate_vectorlike): Don't check size overflow here.
166 (allocate_vector): Check it here instead, since this is the only
167 caller of allocate_vectorlike that could cause overflow.
168 Check that the new vector's length is representable as a fixnum.
169
86fe5cfe
PE
170 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
171 The previous code was bogus. For example, next_almost_prime (32)
172 returned 39, which is undesirable as it is a multiple of 3; and
173 next_almost_prime (24) returned 25, which is a multiple of 5 so
174 why was the code bothering to check for multiples of 7?
175
80e88859
PE
176 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
177
4a2f0ad6
PE
178 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
179
f66c7cf8
PE
180 Variadic C functions now count arguments with ptrdiff_t.
181 This partly undoes my 2011-03-30 change, which replaced int with size_t.
182 Back then I didn't know that the Emacs coding style prefers signed int.
183 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
184 were being counted with int, which may truncate counts on 64-bit
185 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
186 * lisp.h (struct Lisp_Subr.function.aMANY)
187 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
188 Arg counts are now ptrdiff_t, not size_t.
189 All variadic functions and their callers changed accordingly.
190 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
191 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
192 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
193 * callint.c (Fcall_interactively): Check arg count for overflow,
194 to avoid potential buffer overrun. Use signed char, not 'int',
195 for 'varies' array, so that we needn't bother to check its size
196 calculation for overflow.
197 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
198 * eval.c (apply_lambda):
199 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
200 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
201 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
202
a1759b76
PE
203 * callint.c (Fcall_interactively): Don't use index var as event count.
204
d96be9fc
PE
205 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
206 * mem-limits.h (SIZE): Remove; no longer used.
207
a690a978 208 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 209
578c21e6
PE
210 Remove unnecessary casts.
211 * xterm.c (x_term_init):
212 * xfns.c (x_set_border_pixel):
213 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
214 These aren't needed now that we assume ANSI C.
215
96f53c6c
PE
216 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
217 It's more likely to cause problems (due to unsigned overflow)
218 than to cure them.
219
83c77d31
PE
220 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
221
ee2079f1
PE
222 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
223
6da65536
PE
224 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
225
7147c4a4
PE
226 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
227
193e32d9
PE
228 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
229
e5533da6
PE
230 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
231
9910e595
PE
232 GLYPH_CODE_FACE returns EMACS_INT, not int.
233 * dispextern.h (merge_faces):
234 * xfaces.c (merge_faces):
01103c44
PE
235 * xdisp.c (get_next_display_element, next_element_from_display_vector):
236 Don't assume EMACS_INT fits in int.
9910e595 237
2638320e
PE
238 * character.h (CHAR_VALID_P): Remove unused parameter.
239 * fontset.c, lisp.h, xdisp.c: All uses changed.
240
045eb8d9
PE
241 * editfns.c (Ftranslate_region_internal): Omit redundant test.
242
c1f134b5
PE
243 * fns.c (concat): Minor tuning based on overflow analysis.
244 This doesn't fix any bugs. Use int to hold character, instead
245 of constantly refetching from Emacs object. Use XFASTINT, not
246 XINT, for value known to be a character. Don't bother comparing
247 a single byte to 0400, as it's always less.
248
395fcb93 249 * floatfns.c (Fexpt):
327eeec8
PE
250 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
251
abbd3d23
PE
252 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
253 for characters.
254
684a03ef
PE
255 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
256
0fed43f3
PE
257 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
258 Without this fix, on a 64-bit host (aset S 0 4294967386) would
259 incorrectly succeed when S was a string, because 4294967386 was
260 truncated before it was used.
261
8fd02eb7
PE
262 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
263 Otherwise, an out-of-range integer could cause undefined behavior
264 on a 64-bit host.
265
f8c86b69
PE
266 * composite.c: Use int, not EMACS_INT, for characters.
267 (fill_gstring_body, composition_compute_stop_pos): Use int, not
268 EMACS_INT, for values that are known to be in character range.
269 This doesn't fix any bugs but is the usual style inside Emacs and
270 may generate better code on 32-bit machines.
271
34206dd2
PE
272 Make sure a 64-bit char is never passed to ENCODE_CHAR.
273 This is for reasons similar to the recent CHAR_STRING fix.
274 * charset.c (Fencode_char): Check that character arg is actually
275 a character. Pass an int to ENCODE_CHAR.
276 * charset.h (ENCODE_CHAR): Verify that the character argument is no
277 wider than 'int', as a compile-time check to prevent future regressions
278 in this area.
279
c5958d4c 280 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
281
282 Make sure a 64-bit char is never passed to CHAR_STRING.
283 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
284 by silently ignoring the top 32 bits, allowing some values
285 that were far too large to be valid characters.
286 * character.h: Include <verify.h>.
287 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
288 arguments are no wider than unsigned, as a compile-time check
289 to prevent future regressions in this area.
290 * data.c (Faset):
01103c44 291 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
292 (Fsubst_char_in_region):
293 * fns.c (concat):
294 * xdisp.c (decode_mode_spec_coding):
295 Adjust to CHAR_STRING's new requirement.
296 * editfns.c (Finsert_char, Fsubst_char_in_region):
297 * fns.c (concat): Check that character args are actually
298 characters. Without this test, these functions did the wrong
299 thing with wildly out-of-range values on 64-bit hosts.
300
d37ca623
PE
301 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
302 These casts should not be needed on 32-bit hosts, either.
303 * keyboard.c (read_char):
304 * lread.c (Fload): Remove casts to unsigned.
305
ea204efb
PE
306 * lisp.h (UNSIGNED_CMP): New macro.
307 This fixes comparison bugs on 64-bit hosts.
308 (ASCII_CHAR_P): Use it.
309 * casefiddle.c (casify_object):
01103c44 310 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
311 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
312 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
313 * dispextern.h (FACE_FROM_ID):
314 * keyboard.c (read_char): Use UNSIGNED_CMP.
315
41cb286c
PE
316 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
317 not to EMACS_INT, to avoid GCC warning.
318
4a1b9832
PE
319 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
320
55daad71
PE
321 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
322 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
323 isn't needed on 32-bit machines.
8f95c75c 324
01103c44
PE
325 * buffer.c (Fgenerate_new_buffer_name):
326 Use EMACS_INT for count, not int.
0ceccced 327 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
328
329 * data.c (Qcompiled_function): Now static.
330
c6f072e7
PE
331 * window.c (window_body_lines): Now static.
332
20ce5912
PE
333 * image.c (gif_load): Rename local to avoid shadowing.
334
9c4c5f81
PE
335 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
336 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
337 * alloc.c (make_save_value): Integer argument is now of type
338 ptrdiff_t, not int.
339 (mark_object): Use ptrdiff_t, not int.
340 * lisp.h (pD): New macro.
341 * print.c (print_object): Use it.
342
c0c5c8ae
PE
343 * alloc.c: Use EMACS_INT, not int, to count objects.
344 (total_conses, total_markers, total_symbols, total_vector_size)
345 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
346 (total_free_floats, total_floats, total_free_intervals)
347 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
348 Now EMACS_INT, not int. All uses changed.
349 (Fgarbage_collect): Compute overall total using a double, so that
350 integer overflow is less likely to be a problem. Check for overflow
351 when converting back to an integer.
5a25e253
PE
352 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
353 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
354 These were 'int' variables that could overflow on 64-bit hosts;
355 they were never used, so remove them instead of repairing them.
211a0b2a 356 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
357 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
358 Previously, this ceilinged at INT_MAX, but that doesn't work on
359 64-bit machines.
e46bb31a 360 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 361
c78baabf 362 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 363 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
364 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
365 when a (possibly-narrower) signed value would do just as well.
366 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 367
c9d624c6
PE
368 * alloc.c: Catch some string size overflows that we were missing.
369 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
370 for convenience in STRING_BYTES_MAX.
371 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
372 The definition here is exact; the one in lisp.h was approximate.
373 (allocate_string_data): Check for string overflow. This catches
374 some instances we weren't catching before. Also, it catches
375 size_t overflow on (unusual) hosts where SIZE_MAX <= min
376 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
377 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 378
c9d624c6
PE
379 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
380 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
381 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
382
353032ce
PE
383 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
384
2bccce07
PE
385 * alloc.c (Fmake_string): Check for out-of-range init.
386
0ac30604
SM
3872011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
388
389 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
390
c195f2de
JD
3912011-06-14 Jan Djärv <jan.h.d@swipnet.se>
392
393 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
394 xg_get_default_scrollbar_width.
395
396 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
397 (int_gtk_range_get_value): Move to the scroll bar part of the file.
398 (style_changed_cb): Call update_theme_scrollbar_width and call
399 x_set_scroll_bar_default_width and xg_frame_set_char_size for
400 all frames (Bug#8505).
401 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
402 Call gtk_window_set_resizable if HAVE_GTK3.
403 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
404 and height if HAVE_GTK3 (Bug#8505).
405 (scroll_bar_width_for_theme): New variable.
406 (update_theme_scrollbar_width): New function.
407 (xg_get_default_scrollbar_width): Move code to
408 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
409 (xg_initialize): Call update_theme_scrollbar_width.
410
411 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
412
413 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
414
e10ac9f1
MR
4152011-06-12 Martin Rudalics <rudalics@gmx.at>
416
417 * frame.c (make_frame): Call other_buffer_safely instead of
418 other_buffer.
419
420 * window.c (temp_output_buffer_show): Call display_buffer with
421 second argument Vtemp_buffer_show_specifiers and reset latter
422 immediately after the call.
423 (Vtemp_buffer_show_specifiers): New variable.
424 (auto_window_vscroll_p, next_screen_context_lines)
425 (Vscroll_preserve_screen_position): Remove leading asterisks from
426 doc-strings.
427
2d3c217e 4282011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 429
7b7f97e8 430 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
431 * buffer.c (Qclone_number): Remove for now, as it's unused.
432 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
433 (record_buffer): Remove unused local.
434 * frame.c (other_visible_frames, frame_buffer_list): Now static.
435 (set_frame_buffer_list): Remove; unused.
436 * frame.h (other_visible_frames): Remove decl.
437 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
438 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
439 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
440 if HAVE_GPM.
441 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
442 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
443 Define only if HAVE_GPM.
444 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
445 (update_hints_inhibit): Remove; never set. All uses removed.
446 * widgetprv.h (emacsFrameClassRec): Remove decl.
447 * window.c (delete_deletable_window): Now returns void, since it
448 wasn't returning anything.
449 (compare_window_configurations): Remove unused locals.
450 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
451 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
452 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
453 the same widths as pointers. This follows up on the 2011-05-06 patch.
454 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
455 * xterm.h: Likewise.
456 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
457
1384b89e
JB
4582011-06-12 Juanma Barranquero <lekktu@gmail.com>
459
460 * makefile.w32-in: Update dependencies.
461 (LISP_H): Add lib/intprops.h.
462
1100a63c
CY
4632011-06-11 Chong Yidong <cyd@stupidchicken.com>
464
465 * image.c (gif_load): Add animation frame delay to the metadata.
466 (syms_of_image): Use DEFSYM. New symbol `delay'.
467
6198ccd0
MR
4682011-06-11 Martin Rudalics <rudalics@gmx.at>
469
470 * window.c (delete_deletable_window): Re-add.
471 (Fset_window_configuration): Rewrite to handle dead buffers and
472 consequently deletable windows.
473 (window_tree, Fwindow_tree): Remove. Supply functionality in
474 window.el.
475 (compare_window_configurations): Simplify code.
476
b6e3633c
AS
4772011-06-11 Andreas Schwab <schwab@linux-m68k.org>
478
1ab0dee5
AS
479 * image.c (imagemagick_load_image): Fix type mismatch.
480 (Fimagemagick_types): Likewise.
481
b6e3633c
AS
482 * window.h (replace_buffer_in_windows): Declare.
483
9397e56f
MR
4842011-06-11 Martin Rudalics <rudalics@gmx.at>
485
486 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
487 Qclone_number. Remove external declaration of Qdelete_window.
488 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
489 code.
490 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
491 Qbuffer_list_update_hook if allowed.
492 (Fother_buffer): Rewrite doc-string. Major rewrite for new
493 buffer list implementation.
494 (other_buffer_safely): New function.
495 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
496 calls to replace_buffer_in_windows and
497 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
498 if allowed.
499 (record_buffer): Inhibit quitting and rewrite using quittable
500 functions. Run Qbuffer_list_update_hook if allowed.
501 (Frecord_buffer, Funrecord_buffer): New functions.
502 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
503 switch-to-buffer to window.el.
504 (bury-buffer): Move to window.el.
505 (Vbuffer_list_update_hook): New variable.
506
507 * lisp.h (other_buffer_safely): Add prototype in buffer.c
508 section.
509
510 * window.h (resize_frame_windows): Move up in code.
511 (Fwindow_frame): Remove EXFUN.
512 (replace_buffer_in_all_windows): Remove prototype.
513 (replace_buffer_in_windows_safely): Add prototype.
514
515 * window.c: Declare Qdelete_window static again. Move down
516 declaration of select_count.
517 (Fnext_window, Fprevious_window): Rewrite doc-strings.
518 (Fother_window): Move to window.el.
519 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
520 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
521 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
522 window.el.
523 (replace_buffer_in_windows): Implement by calling
524 Qreplace_buffer_in_windows.
525 (replace_buffer_in_all_windows): Remove with some functionality
526 moved into replace_buffer_in_windows_safely.
527 (replace_buffer_in_windows_safely): New function.
528 (select_window_norecord, select_frame_norecord): Move in front
529 of run_window_configuration_change_hook. Remove now obsolete
530 declarations.
531 (Fset_window_buffer): Rewrite doc-string. Call
532 Qrecord_window_buffer.
533 (keys_of_window): Move binding for other-window to window.el.
534
b50691aa
CY
5352011-06-11 Chong Yidong <cyd@stupidchicken.com>
536
537 * dispextern.h (struct image): Replace data member, whose int_val
538 and ptr_val fields were not used by anything, with a single
539 lisp_val object.
540
541 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
542 (gif_clear_image, gif_load, imagemagick_load_image)
543 (gs_clear_image, gs_load): Callers changed.
544
3f754b86
PE
5452011-06-10 Paul Eggert <eggert@cs.ucla.edu>
546
cca69397
PE
547 * buffer.h: Include <time.h>, for time_t.
548 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
549
109e28d0
PE
550 Fix minor problems found by static checking.
551
60737f02
PE
552 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
553
4b66faf3
PE
554 Make identifiers static if they are not used in other modules.
555 * data.c (Qcompiled_function, Qframe, Qvector):
556 * image.c (QimageMagick, Qsvg):
557 * minibuf.c (Qmetadata):
558 * window.c (resize_window_check, resize_root_window): Now static.
559 * window.h (resize_window_check, resize_root_window): Remove decls.
560
109e28d0
PE
561 * window.c (window_deletion_count, delete_deletable_window):
562 Remove; unused.
46a4ce9e
PE
563 (window_body_lines): Now static.
564 (Fdelete_other_windows_internal): Mark vars as initialized.
565 Make sure 'resize_failed' is initialized.
566 (run_window_configuration_change_hook): Rename local to avoid shadowing.
567 (resize_window_apply): Remove unused local.
568 * window.h (delete_deletable_window): Remove decl.
569
109e28d0 570 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
571 (imagemagick_load_image): Fix pointer signedness problem by changing
572 last arg from unsigned char * to char *. All uses changed.
573 Also, fix a local for similar reasons.
574 Remove unused locals. Remove locals to avoid shadowing.
575 (fn_rsvg_handle_free): Remove; unused.
576 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 577 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 578
3f754b86
PE
579 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
580
2547adb1
CY
5812011-06-10 Chong Yidong <cyd@stupidchicken.com>
582
583 * image.c (gif_load): Fix omitted cast error introduced by
584 2011-06-06 change.
585
2c8e37d4
MR
5862011-06-10 Martin Rudalics <rudalics@gmx.at>
587
588 * window.h (resize_proportionally, orig_total_lines)
589 (orig_top_line): Remove from window structure.
590 (set_window_height, set_window_width, change_window_heights)
591 (Fdelete_window): Remove prototypes.
592 (resize_frame_windows): Remove duplicate declaration.
593
440a42e3
EZ
5942011-06-10 Eli Zaretskii <eliz@gnu.org>
595
596 * window.h (resize_frame_windows, resize_window_check)
597 (delete_deletable_window, resize_root_window)
598 (resize_frame_windows): Declare prototypes.
599
600 * window.c (resize_window_apply): Make definition be "static" to
601 match the prototype.
602
562dd5e9
MR
6032011-06-10 Martin Rudalics <rudalics@gmx.at>
604
605 * window.c: Remove declarations of Qwindow_size_fixed,
606 window_min_size_1, window_min_size_2, window_min_size,
607 size_window, window_fixed_size_p, enlarge_window, delete_window.
608 Remove static from declaration of Qdelete_window, it's
609 temporarily needed by Fbury_buffer.
610 (replace_window): Don't assign orig_top_line and
611 orig_total_lines.
612 (Fdelete_window, delete_window): Remove. Window deletion is
613 handled by window.el.
614 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
615 Fdelete_window calls with calls to Qdelete_window.
616 (Fdelete_other_windows): Remove. Deleting other windows is
617 handled by window.el.
618 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
619 handled in window.el.
620 (window_min_size_2, window_min_size_1, window_min_size): Remove.
621 Window minimum sizes are handled in window.el.
622 (shrink_windows, size_window, set_window_height)
623 (set_window_width, change_window_heights, window_height)
624 (window_width, CURBEG, CURSIZE, enlarge_window)
625 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
626 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
627 handled in window.el.
628 (make_dummy_parent): Rename to make_parent_window and give it a
629 second argument horflag.
630 (make_window): Don't set resize_proportionally any more.
631 (Fsplit_window): Remove. Windows are split in window.el.
632 (save_restore_action, save_restore_orig_size)
633 (shrink_window_lowest_first, save_restore_orig_size): Remove.
634 Resize mini windows in window.el.
635 (grow_mini_window, shrink_mini_window): Implement by calling
636 Qresize_root_window_vertically, resize_window_check and
637 resize_window_apply.
638 (saved_window, Fset_window_configuration, save_window_save): Do
639 not handle orig_top_line, orig_total_lines, and
640 resize_proportionally.
641 (window_min_height, window_min_width): Move to window.el.
642 (keys_of_window): Move bindings for delete-other-windows,
643 split-window, delete-window and enlarge-window to window.el.
644
645 * buffer.c: Temporarily extern Qdelete_window.
646 (Fbury_buffer): Temporarily call Qdelete_window instead of
647 Fdelete_window (Fbury_buffer will move to window.el soon).
648
649 * frame.c (set_menu_bar_lines_1): Remove code handling
650 orig_top_line and orig_total_lines.
651
652 * dispnew.c (adjust_frame_glyphs_initially): Don't use
653 set_window_height but set heights directly.
654 (change_frame_size_1): Use resize_frame_windows.
655
656 * xdisp.c (init_xdisp): Don't use set_window_height but set
657 heights directly.
658
659 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
660 resize_frame_windows instead of change_window_heights and run
661 run_window_configuration_change_hook.
662
663 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
664 instead of change_window_heights and run
665 run_window_configuration_change_hook.
666
1a13852e
MR
6672011-06-09 Martin Rudalics <rudalics@gmx.at>
668
669 * window.c (replace_window): Rename second argument REPLACEMENT to
670 NEW. New third argument SETFLAG. Rewrite.
671 (delete_window, make_dummy_parent): Call replace_window with
672 third argument 1.
673 (window_list_1): Move down in code.
674 (run_window_configuration_change_hook): Move set_buffer part
675 before select_frame_norecord part in order to unwind correctly.
676 Rename count1 to count.
677 (recombine_windows, delete_deletable_window, resize_root_window)
678 (Fdelete_other_windows_internal)
679 (Frun_window_configuration_change_hook, make_parent_window)
680 (resize_window_check, resize_window_apply, Fresize_window_apply)
681 (resize_frame_windows, Fsplit_window_internal)
682 (Fdelete_window_internal, Fresize_mini_window_internal): New
683 functions.
684 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
685
f3d1777e
MR
6862011-06-08 Martin Rudalics <rudalics@gmx.at>
687
496e208e
MR
688 * window.h (window): Add some new members to window structure -
689 normal_lines, normal_cols, new_total, new_normal, clone_number,
690 splits, nest, prev_buffers, next_buffers.
691 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 692 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 693
f3d1777e
MR
694 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
695 Remove.
496e208e
MR
696 (make_dummy_parent): Set new members of windows structure.
697 (make_window): Move down in code. Handle new members of window
698 structure.
699 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
700 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
701 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
702 (Fset_window_prev_buffers, Fwindow_next_buffers)
703 (Fset_window_next_buffers, Fset_window_clone_number): New
704 functions.
705 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
706 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
707 Doc-string fixes.
708 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
709 Argument WINDOW can be now internal window too.
710 (Fwindow_use_time): Move up in code.
711 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
712 Rewrite doc-string.
713 (Fset_window_configuration, saved_window)
714 (Fcurrent_window_configuration, save_window_save): Handle new
715 members of window structure.
b9e809c2
MR
716 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
717 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
718 (syms_of_window): New Lisp objects Qrecord_window_buffer,
719 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
720 Qget_mru_window, Qresize_root_window,
721 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
722 Qauto_buffer_name; staticpro them.
f3d1777e 723
abde8f8c
MR
7242011-06-07 Martin Rudalics <rudalics@gmx.at>
725
726 * window.c (Fwindow_total_size, Fwindow_left_column)
727 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
728 (Fwindow_list_1): New functions.
729 (window_box_text_cols): Replace with window_body_cols.
730 (Fwindow_width, Fscroll_left, Fscroll_right): Use
731 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
732 (delete_window, Fset_window_configuration): Call
733 delete_all_subwindows with window as argument.
734 (delete_all_subwindows): Take a window as argument and not a
735 structure. Rewrite.
190b47e6
MR
736 (window_loop): Remove handling of GET_LRU_WINDOW and
737 GET_LARGEST_WINDOW.
738 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
739
740 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
741 window_box_text_cols. delete_all_subwindows now takes a
742 Lisp_Object as argument.
abde8f8c
MR
743
744 * indent.c (compute_motion, Fcompute_motion): Use
745 window_body_cols instead of window_box_text_cols.
746
fa8a67e6
MR
747 * frame.c (delete_frame): Call delete_all_subwindows with root
748 window as argument.
749
a54e3482
DC
7502011-06-07 Daniel Colascione <dan.colascione@gmail.com>
751
752 * fns.c (Fputhash): Document return value.
753
60002bf5
CY
7542011-06-06 Chong Yidong <cyd@stupidchicken.com>
755
756 * image.c (gif_load): Implement gif89a spec "no disposal" method.
757
0c671da6 7582011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 759
b862a52a 760 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 761
be44ca6c
PE
762 Check for overflow when converting integer to cons and back.
763 * charset.c (Fdefine_charset_internal, Fdecode_char):
764 Use cons_to_unsigned to catch overflow.
765 (Fencode_char): Use INTEGER_TO_CONS.
766 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
767 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
768 * data.c (long_to_cons, cons_to_long): Remove.
769 (cons_to_unsigned, cons_to_signed): New functions.
770 These signal an error for invalid or out-of-range values.
771 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
772 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
773 * font.c (Ffont_variation_glyphs):
774 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
775 * lisp.h: Include <intprops.h>.
776 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
777 (cons_to_signed, cons_to_unsigned): New decls.
778 (long_to_cons, cons_to_long): Remove decls.
779 * undo.c (record_first_change): Use INTEGER_TO_CONS.
780 (Fprimitive_undo): Use CONS_TO_INTEGER.
781 * xfns.c (Fx_window_property): Likewise.
782 * xselect.c: Include <limits.h>.
783 (x_own_selection, selection_data_to_lisp_data):
784 Use INTEGER_TO_CONS.
785 (x_handle_selection_request, x_handle_selection_clear)
786 (x_get_foreign_selection, Fx_disown_selection_internal)
787 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
788 (lisp_data_to_selection_data): Use cons_to_unsigned.
789 (x_fill_property_data): Use cons_to_signed.
790 Report values out of range.
791
d1f3d2af
PE
792 Check for buffer and string overflow more precisely.
793 * buffer.h (BUF_BYTES_MAX): New macro.
794 * lisp.h (STRING_BYTES_MAX): New macro.
795 * alloc.c (Fmake_string):
796 * character.c (string_escape_byte8):
797 * coding.c (coding_alloc_by_realloc):
798 * doprnt.c (doprnt):
799 * editfns.c (Fformat):
800 * eval.c (verror):
801 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
802 since they may not be the same number.
803 * editfns.c (Finsert_char):
804 * fileio.c (Finsert_file_contents):
805 Likewise for BUF_BYTES_MAX.
806
dd52fcea
PE
807 * image.c: Use ptrdiff_t, not int, for sizes.
808 (slurp_file): Switch from int to ptrdiff_t.
809 All uses changed.
810 (slurp_file): Check that file size fits in both size_t (for
811 malloc) and ptrdiff_t (for sanity and safety).
812
7f9bbdbb
PE
813 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
814 if b->modtime has its maximal value.
815
dfe18f82
PE
816 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
817
84acfcf0
PE
818 Don't assume time_t can fit into int.
819 * buffer.h (struct buffer.modtime): Now time_t, not int.
820 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
821 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
822
ccd9a01a
PE
823 Minor fixes for signed vs unsigned integers.
824 * character.h (MAYBE_UNIFY_CHAR):
825 * charset.c (maybe_unify_char):
826 * keyboard.c (read_char, reorder_modifiers):
827 XINT -> XFASTINT, since the integer must be nonnegative.
828 * ftfont.c (ftfont_spec_pattern):
829 * keymap.c (access_keymap, silly_event_symbol_error):
830 XUINT -> XFASTINT, since the integer must be nonnegative.
831 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
832 since it makes no difference and we prefer signed.
833 * keyboard.c (record_char): Use XUINT when all the neighbors do.
834 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
835 nonnegative.
836
d6d100dd
SM
8372011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
838
839 * window.h (Fwindow_frame): Declare.
840
2b6148e4
PE
8412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
842
843 * alloc.c: Simplify handling of large-request failures (Bug#8800).
844 (SPARE_MEMORY): Always define.
845 (LARGE_REQUEST): Remove.
846 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
847
f230ecc9
MR
8482011-06-06 Martin Rudalics <rudalics@gmx.at>
849
727e958e
MR
850 * lisp.h: Move EXFUNS for Fframe_root_window,
851 Fframe_first_window and Fset_frame_selected_window to window.h.
852
853 * window.h: Move EXFUNS for Fframe_root_window,
854 Fframe_first_window and Fset_frame_selected_window here from
855 lisp.h.
856
857 * frame.c (Fwindow_frame, Fframe_first_window)
858 (Fframe_root_window, Fframe_selected_window)
859 (Fset_frame_selected_window): Move to window.c.
860 (Factive_minibuffer_window): Move to minibuf.c.
861 (Fother_visible_frames_p): New function.
862
863 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
864
f230ecc9
MR
865 * window.c (decode_window, decode_any_window): Move up in code.
866 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
867 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
868 (Fwindow_buffer): Move up and rewrite doc-string.
869 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
870 (Fwindow_prev): New functions.
727e958e
MR
871 (Fwindow_frame): Move here from frame.c. Accept any window as
872 argument.
873 (Fframe_root_window, Fframe_first_window)
874 (Fframe_selected_window): Move here from frame.c. Accept frame
875 or arbitrary window as argument. Update doc-strings.
876 (Fminibuffer_window): Move up in code.
877 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
878 (Fset_frame_selected_window): Move here from frame.c.
879 Marginal rewrite.
727e958e
MR
880 (Fselected_window, select_window, Fselect_window): Move up in
881 code. Minor doc-string fixes.
f230ecc9 882
4d09bcf6
PE
8832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
884
885 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
886 Do not assume that spare memory exists; that assumption is valid
887 only if SYSTEM_MALLOC.
888 (LARGE_REQUEST): New macro, so that the issue of large requests
889 is separated from the issue of spare memory.
890
810928a2
AS
8912011-06-05 Andreas Schwab <schwab@linux-m68k.org>
892
172418ad
AS
893 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
894 format. (Bug#8806)
895
43f862f7
AS
896 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
897
810928a2
AS
898 * xfns.c (x_set_scroll_bar_default_width): Move declarations
899 before statements.
900
a059fe24
JD
9012011-06-05 Jan Djärv <jan.h.d@swipnet.se>
902
903 * gtkutil.c (xg_get_default_scrollbar_width): New function.
904
905 * gtkutil.h: Declare xg_get_default_scrollbar_width.
906
907 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
908 min width by calling x_set_scroll_bar_default_width (Bug#8505).
909
989bf368
JB
9102011-06-05 Juanma Barranquero <lekktu@gmail.com>
911
912 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
913
4b80f674
CY
9142011-06-04 Chong Yidong <cyd@stupidchicken.com>
915
916 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
917 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
918 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
919 New error handlers.
4b80f674
CY
920 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
921 Obey Vx_select_enable_clipboard_manager. Catch errors in
922 x_clipboard_manager_save (Bug#8779).
923 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 924 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 925
99a33b77 9262011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
927
928 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
929
99a33b77 9302011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
931
932 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
933 in the current matrix if keep_current_p is non-zero.
934
8264569d
EZ
9352011-06-04 Eli Zaretskii <eliz@gnu.org>
936
937 * bidi.c (bidi_level_of_next_char): Fix last change.
938
57f97249
EZ
9392011-06-03 Eli Zaretskii <eliz@gnu.org>
940
fec2107c 941 Support bidi reordering of text covered by display properties.
57f97249 942
fec2107c
EZ
943 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
944 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
945 (bidi_cache_search, bidi_cache_iterator_state)
946 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
947 (bidi_level_of_next_char, bidi_move_to_visually_next):
948 Support character positions inside a run of characters covered by a
fec2107c
EZ
949 display string.
950 (bidi_paragraph_init, bidi_resolve_explicit_1)
951 (bidi_level_of_next_char): Call bidi_fetch_char and
952 bidi_fetch_char_advance instead of FETCH_CHAR and
953 FETCH_CHAR_ADVANCE.
954 (bidi_init_it): Initialize new members.
955 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
956 definitions.
957 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
958 instead of using explicit *_CHAR codes.
d6d100dd
SM
959 (bidi_resolve_explicit, bidi_resolve_weak):
960 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
961 bidirectional text is supported only in multibyte buffers.
962 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
963 it to initialize the frame_window_p member of struct bidi_it.
964 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
965 (bidi_resolve_explicit, bidi_resolve_weak)
966 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
967 bidi_it->nchars is non-positive.
968 (bidi_level_of_next_char): Don't try to lookup the cache for the
969 next/previous character if nothing is cached there yet, or if we
970 were just reseat()'ed to a new position.
c40e2fb2 971
0e14fe90
EZ
972 * xdisp.c (set_cursor_from_row): Set start and stop points
973 according to the row's direction when priming the loop that looks
974 for the glyph on which to display cursor.
975 (single_display_spec_intangible_p): Function deleted.
976 (display_prop_intangible_p): Reimplement to call
977 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
978 Accept 3 additional arguments needed by handle_display_spec.
979 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
980 values: lists, `(when COND...)' forms, etc.
981 (single_display_spec_string_p): Support property values that are
982 lists with the argument STRING its top-level element.
983 (display_prop_string_p): Fix the condition for processing a
984 property that is a list to be consistent with handle_display_spec.
fec2107c 985 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
986 last portion of handle_display_prop.
987 (compute_display_string_pos): Accept additional argument
988 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
989 value of a `display' property is a "replacing spec".
990 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
991 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
992 the display property, but just return a value indicating whether
993 the display property will replace the characters it covers.
994 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
995 frame_window_p members of struct bidi_it.
d6d100dd
SM
996 (compute_display_string_pos, compute_display_string_end):
997 New functions.
fec2107c
EZ
998 (push_it): Accept second argument POSITION, where pop_it should
999 jump to continue iteration.
1000 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1001
fec2107c
EZ
1002 * keyboard.c (adjust_point_for_property): Adjust the call to
1003 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1004
1005 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1006 (bidi_init_it): Update prototypes.
1007 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1008 (compute_display_string_pos, compute_display_string_end):
1009 Declare prototypes.
fec2107c
EZ
1010 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1011 EMACS_INT.
fc6f18ce 1012
40087514 10132011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1014
57f53182
PE
1015 Malloc failure behavior now depends on size of allocation.
1016 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1017 * lisp.h: Change signatures accordingly.
1018 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1019 All callers changed. (Bug#8762)
1020
1021 * gnutls.c: Use Emacs's memory allocators.
1022 Without this change, the gnutls library would invoke malloc etc.
1023 directly, which causes problems on non-SYNC_INPUT hosts, and which
1024 runs afoul of improving memory_full behavior. (Bug#8761)
1025 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1026 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1027 xfree instead of the default malloc, realloc, free.
1028 (Fgnutls_boot): No need to check for memory allocation failure,
1029 since xmalloc does that for us.
1030
ac32cd99 1031 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1032 * category.c (hash_get_category_set):
1033 * ccl.c (ccl_driver):
1034 * charset.c (Fdefine_charset_internal):
1035 * charset.h (struct charset.hash_index):
1036 * composite.c (get_composition_id, gstring_lookup_cache)
1037 (composition_gstring_put_cache):
1038 * composite.h (struct composition.hash_index):
1039 * dispextern.h (struct image.hash):
1040 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1041 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1042 (hashfn_equal, hashfn_user_defined, make_hash_table)
1043 (maybe_resize_hash_table, hash_lookup, hash_put)
1044 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1045 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1046 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1047 * image.c (make_image, search_image_cache, lookup_image)
1048 (xpm_put_color_table_h):
1049 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1050 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1051 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1052 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1053 * alloc.c (allocate_vectorlike):
1054 Check for overflow in vector size calculations.
1055 * ccl.c (ccl_driver):
1056 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1057 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1058 need to be updated by these changes.
40087514
PE
1059 * fns.c (make_hash_table, maybe_resize_hash_table):
1060 Check for integer overflow with large hash tables.
0de4bb68
PE
1061 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1062 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1063 (SXHASH_REDUCE): New macro.
1064 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1065 Use it instead of discarding useful hash info with large hash values.
1066 (sxhash_float): New function.
1067 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1068 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1069 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1070 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1071 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1072 Adjust signatures to match updated version of code.
1073 (consing_since_gc): Now EMACS_INT, since a single hash table can
1074 use more than INT_MAX bytes.
1075
698d32e2
DN
10762011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1077
1078 Make it possible to build with GCC-4.6+ -O2 -flto.
1079
1080 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1081
fd6fa53f
SM
10822011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1083
1084 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1085 Call minibuffer-inactive-mode.
1086
864db017
JB
10872011-05-31 Juanma Barranquero <lekktu@gmail.com>
1088
1089 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1090 Update dependencies.
1091
2ad0baf4
DN
10922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1093
1094 * data.c (init_data): Remove code for UTS, this system is not
1095 supported anymore.
1096
4fcc2638
DN
10972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1098
1099 Don't force ./temacs to start in terminal mode.
1100
1101 * frame.c (make_initial_frame): Initialize faces in all cases, not
1102 only when CANNOT_DUMP is defined.
1103 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1104
c56e0fd5
DN
11052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1106
1107 * dispnew.c (add_window_display_history): Use const for the string
1108 pointer. Remove declaration, not needed.
1109
333d54da 11102011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1111
55d4c1b2 1112 Use 'inline', not 'INLINE'.
333d54da 1113 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1114 * alloc.c, fontset.c (INLINE): Remove.
1115 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1116 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1117 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1118 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1119 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1120
738db178
DN
11212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1122
1123 Make it possible to run ./temacs.
1124
1125 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1126 syms_of_callproc does the same thing. Remove test for
1127 "initialized", do it in the caller.
1128 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1129
620c53a6
SM
11302011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1131
1132 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1133 (read_minibuf): Use get_minibuffer.
1134 (syms_of_minibuf): Use DEFSYM.
1135 (Qmetadata): New var.
1136 * data.c (Qbuffer): Don't make it static.
1137 (syms_of_data): Use DEFSYM.
1138
e003a292
PE
11392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1140
1141 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1142 (CCL_CODE_MIN): New macro.
1143
ed008a6d
PE
11442011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1145
3687c2ef
PE
1146 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1147
ed008a6d
PE
1148 * eval.c (Qdebug): Now static.
1149 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1150 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1151 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1152
d66c4c7c
CY
11532011-05-29 Chong Yidong <cyd@stupidchicken.com>
1154
1155 * image.c: Various fixes to ImageMagick code comments.
1156 (Fimagemagick_types): Doc fix.
1157
5fbc2025
PE
11582011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1159
0196f88a
PE
1160 Minor fixes prompted by GCC 4.6.0 warnings.
1161
1162 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1163
5fbc2025
PE
1164 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1165 (x_clipboard_manager_save_all): Move extern decl to ...
1166 * xterm.h: ... here, so that it can be checked for consistency.
1167
1dd3c2d9
CY
11682011-05-29 Chong Yidong <cyd@stupidchicken.com>
1169
1170 * xselect.c (x_clipboard_manager_save_frame)
1171 (x_clipboard_manager_save_all): New functions.
1172 (Fx_clipboard_manager_save): Lisp function deleted.
1173
1174 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1175 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1176
1177 * xterm.h: Update prototype.
1178
5ba6571d
WX
11792011-05-28 William Xu <william.xwl@gmail.com>
1180
1181 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1182 exiting (Bug#8239).
1183
3eaff834
JM
11842011-05-28 Jim Meyering <meyering@redhat.com>
1185
e1900994 1186 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1187 * fns.c (to_uchar): Define.
1188 (crypto_hash_function): Use it to convert some newly-signed
1189 variables to unsigned, to avoid sign-extension bugs. For example,
1190 without this change, (md5 "truc") would evaluate to
1191 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1192 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1193 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1194
0f6990a7
PE
11952011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1196
1197 Integer overflow fixes.
c8a9ca5a 1198
08686060
PE
1199 * dbusbind.c: Serial number integer overflow fixes.
1200 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1201 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1202 to hold a serial number that is too large for a fixnum.
1203 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1204 Check for serial numbers out of range. Decode any serial number
59568bf0 1205 that was so large that it became a float. (Bug#8722)
08686060 1206
2d1fc3c7
PE
1207 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1208 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1209 Use XFASTINT rather than XUINT when numbers are nonnegative.
1210 (xd_append_arg, Fdbus_method_return_internal):
1211 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1212 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1213 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1214 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1215 (Bug#8722)
2d1fc3c7 1216
c8a9ca5a
PE
1217 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1218
519e1d69
PE
1219 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1220
30569699
PE
1221 ccl: add integer overflow checks
1222 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1223 (IN_INT_RANGE): New macros.
1224 (ccl_driver): Use them to check for integer overflow when
1225 decoding a CCL program. Many of the new checks are whether XINT (x)
1226 fits in int; it doesn't always, on 64-bit hosts. The new version
1227 doesn't catch all possible integer overflows, but it's an
847044ea 1228 improvement. (Bug#8719)
30569699 1229
c11285dc
PE
1230 * alloc.c (make_event_array): Use XINT, not XUINT.
1231 There's no need for unsigned here.
1232
fdccd48e
PE
1233 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1234 This follows up to the 2011-05-06 change that substituted uintptr_t
1235 for EMACS_INT. This case wasn't caught back then.
1236
37910ab2
PE
1237 Rework Fformat to avoid integer overflow issues.
1238 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1239 now (part of C89). Include <verify.h>.
1240 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1241 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1242 (Fformat): Avoid the prepass trying to compute sizes; it was only
1243 approximate and thus did not catch overflow reliably. Instead, walk
1244 through the format just once, formatting and computing sizes as we go,
1245 checking for integer overflow at every step, and allocating a larger
1246 buffer as needed. Keep track separately whether the format is
1247 multibyte. Keep only the most-recently calculated precision, rather
1248 than them all. Record whether each argument has been converted to
1249 string. Use EMACS_INT, not int, for byte and char and arg counts.
1250 Support field widths and precisions larger than INT_MAX. Avoid
1251 sprintf's undefined behavior with conversion specifications such as %#d
1252 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1253 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1254 formatting out-of-range floating point numbers with int
1255 formats. (Bug#8668)
1256
2e6578fb
PE
1257 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1258
0ae6bdee
PE
1259 * data.c: Avoid integer truncation in expressions involving floats.
1260 * data.c: Include <intprops.h>.
1261 (arith_driver): When there's an integer overflow in an expression
1262 involving floating point, convert the integers to floating point
1263 so that the resulting value does not suffer from catastrophic
1264 integer truncation. For example, on a 64-bit host (* 4
1265 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1266 Do not rely on undefined behavior after integer overflow.
1267
de883a70
PE
1268 merge count_size_as_multibyte, parse_str_to_multibyte
1269 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1270 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1271 Check for integer overflow.
1272 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1273 since it's now a duplicate of the other. This is more of
1274 a character than a buffer op, so better that it's in character.c.
1275 * fns.c, print.c: Adjust to above changes.
1276
2ff916cb
PE
12772011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1278
1279 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1280
f1b54466
PE
12812011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1282
fb1ac845
PE
1283 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1284 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1285 (x_clipboard_manager_save): Now static.
1286 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1287
f1b54466
PE
1288 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1289 (crypto_hash_function): Now static.
1290 Fix pointer signedness problems. Avoid unnecessary initializations.
1291
a9f737ee
CY
12922011-05-27 Chong Yidong <cyd@stupidchicken.com>
1293
1294 * termhooks.h (Vselection_alist): Make it terminal-local.
1295
1296 * terminal.c (create_terminal): Initialize it.
1297
1298 * xselect.c: Support for clipboard managers.
1299 (Vselection_alist): Move to termhooks.h as terminal-local var.
1300 (LOCAL_SELECTION): New macro.
1301 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1302 (symbol_to_x_atom): Remove gratuitous arg.
1303 (x_handle_selection_request, lisp_data_to_selection_data)
1304 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1305 (x_own_selection, x_get_local_selection, x_convert_selection):
1306 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1307 (some_frame_on_display): Delete unused function.
1308 (Fx_own_selection_internal, Fx_get_selection_internal)
1309 (Fx_disown_selection_internal, Fx_selection_owner_p)
1310 (Fx_selection_exists_p): New optional frame arg.
1311 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1312 (x_handle_selection_clear): Don't treat other terminals with the
1313 same keyboard specially. Use the terminal-local Vselection_alist.
1314 (x_clear_frame_selections): Use Frun_hook_with_args.
1315
1316 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1317
1318 * xterm.h: Add support for those atoms.
1319
e067f0c1
CY
13202011-05-26 Chong Yidong <cyd@stupidchicken.com>
1321
1322 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1323 (converted_selections, conversion_fail_tag): New global variables.
1324 (x_selection_request_lisp_error): Free the above.
1325 (x_get_local_selection): Remove unnecessary code.
1326 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1327 of converted selections stored in converted_selections.
1328 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1329 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1330 (x_convert_selection): New function.
1331 (x_handle_selection_event): Simplify.
1332 (x_get_foreign_selection): Don't ignore incoming requests while
1333 waiting for an answer; this will fail when we implement
1334 SAVE_TARGETS, and seems unnecessary anyway.
1335 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1336 (Vx_sent_selection_functions): Doc fix.
1337
0f4aebc0
LL
13382011-05-26 Leo Liu <sdl.web@gmail.com>
1339
1340 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1341
e61124cd
YM
13422011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1343
1344 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1345
1346 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1347 for fringe update if it has periodic bitmap.
1348 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1349 and fringe_bitmap_periodic_p.
1350
1351 * fringe.c (get_fringe_bitmap_data): New function.
1352 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1353 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1354 row. Mark glyph row for fringe update if periodicity changed.
1355
1356 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1357 for fringe update unless it has periodic bitmap.
1358
f16d9837
KH
13592011-05-25 Kenichi Handa <handa@m17n.org>
1360
1361 * xdisp.c (get_next_display_element): Set correct it->face_id for
1362 a static composition.
1363
e1b90ef6
LL
13642011-05-24 Leo Liu <sdl.web@gmail.com>
1365
1366 * deps.mk (fns.o):
1367 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1368
1369 * fns.c (crypto_hash_function, Fsha1): New function.
1370 (Fmd5): Use crypto_hash_function.
1371 (syms_of_fns): Add Ssha1.
1372
7400048f
PE
13732011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1374
1375 * gnutls.c: Remove unused macros.
1376 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1377 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1378 Remove macros that are defined and never used.
1379 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1380
abb71cf4
CY
13812011-05-22 Chong Yidong <cyd@stupidchicken.com>
1382
1383 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1384 (Fx_get_selection_internal): Minor cleanup.
1385 (Fx_own_selection_internal): Rename arguments for consistency with
1386 select.el.
1387
6307db39
PE
13882011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1389
1390 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1391
f3d4e0a4
CY
13922011-05-22 Chong Yidong <cyd@stupidchicken.com>
1393
1394 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1395
4d8ade89
YM
13962011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1397
1398 * dispnew.c (scrolling_window): Don't exclude the case that the
1399 last enabled row in the desired matrix touches the bottom boundary.
1400
32078c8d
GM
14012011-05-21 Glenn Morris <rgm@gnu.org>
1402
1403 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1404 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1405 and add some more files.
32078c8d 1406
7285dc67
EZ
14072011-05-20 Eli Zaretskii <eliz@gnu.org>
1408
1409 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1410 report_file_error introduced by the change from 2011-05-07.
1411
89d1bd22
PE
14122011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1413
1414 * systime.h (Time): Define only if emacs is defined.
1415 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1416 where the include path doesn't have X11/X.h by default. See
1417 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1418
e23640bb 14192011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1420
1421 * composite.c (find_automatic_composition): Fix previous change.
1422
b9704ad9
GM
14232011-05-20 Glenn Morris <rgm@gnu.org>
1424
1425 * lisp.mk: New file, split from Makefile.in.
1426 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1427 (shortlisp): Remove.
1428 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1429
4a720484
GM
14302011-05-19 Glenn Morris <rgm@gnu.org>
1431
1432 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1433 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1434 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1435 (lisp): Set the order to that of loadup.el.
1436 (shortlisp): Make it a copy of $lisp.
1437 (SOME_MACHINE_LISP): Remove.
1438 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1439 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1440
a28d4396
KH
14412011-05-18 Kenichi Handa <handa@m17n.org>
1442
1443 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1444 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1445 (find_automatic_composition): Mostly rewrite for efficiency.
1446
a2b1fa8e
JB
14472011-05-18 Juanma Barranquero <lekktu@gmail.com>
1448
1449 * makefile.w32-in: Update dependencies.
1450
8e1f5610
CS
14512011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1452
1453 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1454 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1455
7025ee00 14562011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1457
cdfa6eab
PE
1458 Fix some integer overflow issues, such as string length overflow.
1459
06d6db33
PE
1460 * insdel.c (count_size_as_multibyte): Check for string overflow.
1461
2b4560a8
PE
1462 * character.c (lisp_string_width): Check for string overflow.
1463 Use EMACS_INT, not int, for string indexes and lengths; in
1464 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1465 the resulting string length overflows an EMACS_INT; instead,
1466 report a string overflow if no precision given. When checking for
1467 precision exhaustion, use a check that cannot possibly have
1468 integer overflow. (Bug#8675)
1469 * character.h (lisp_string_width): Adjust to new signature.
1470
cb93f9be
PE
1471 * alloc.c (string_overflow): New function.
1472 (Fmake_string): Use it. This doesn't change behavior, but saves
1473 a few bytes and will simplify future changes.
1474 * character.c (string_escape_byte8): Likewise.
1475 * lisp.h (string_overflow): New decl.
1476
1a1f3366
PE
1477 Fixups, following up to the user-interface timestamp change.
1478 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1479 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1480 * msdos.c (mouse_get_pos): Likewise.
1481 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1482 * w32gui.h (Time): Define by including "systime.h" rather than by
1483 declaring it ourselves. (Bug#8664)
1484
d4e3e4d3
PE
1485 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1486 * image.c (clear_image_cache): Likewise.
1487
f6a24d19
PE
1488 * term.c (term_mouse_position): Don't assume time_t wraparound.
1489
08dc5ae6
PE
1490 Be more systematic about user-interface timestamps.
1491 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1492 and sometimes 'EMACS_UINT', to represent these timestamps.
1493 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1494 This makes the code easier to follow, and makes it easier to catch
1495 integer overflow bugs such as Bug#8664.
1496 * frame.c (Fmouse_position, Fmouse_pixel_position):
1497 Use Time, not unsigned long, for user-interface timestamps.
1498 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1499 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1500 * keyboard.h (last_event_timestamp): Likewise.
1501 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1502 * menu.h (xmenu_show): Likewise.
1503 * term.c (term_mouse_position): Likewise.
1504 * termhooks.h (struct input_event.timestamp): Likewise.
1505 (struct terminal.mouse_position_hook): Likewise.
1506 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1507 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1508 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1509 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1510 what it was before.
1511 * menu.h, termhooks.h: Include "systime.h", for Time.
1512
8e55734a
PE
1513 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1514 Don't assume that the difference between two unsigned long values
1515 can fit into an integer. At this point, we know button_down_time
1516 <= event->timestamp, so the difference must be nonnegative, so
1517 there's no need to cast the result if double-click-time is
1518 nonnegative, as it should be; check that it's nonnegative, just in
1519 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1520 apart (about 25 days). (Bug#8664)
8e55734a 1521
841f1b75 1522 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1523 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1524
3e26f69c
PE
1525 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1526 that always fit in int. Use a sentinel instead of a counter, to
1527 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1528 * frame.h (struct frame): Use int for menu_bar_items_used
1529 instead of EMACS_INT, since it always fits in int.
3e26f69c 1530
5cc152c0
PE
1531 * menu.c (grow_menu_items): Check for int overflow.
1532
d89eb65e
PE
1533 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1534
5235bd3e
PE
1535 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1536 Before, the code was not consistent. These values cannot exceed
1537 2**31 - 1 so there's no need to make them unsigned.
1538 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1539 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1540 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1541 as modifiers.
1542 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1543
bc827e23
PE
1544 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1545 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1546 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1547 presumably because the widths might not match.
1548
78eb494e
PE
1549 * window.c (size_window): Avoid needless test at loop start.
1550
04f2d78b
CB
15512011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1552
1553 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1554
d2fc7e3d 15552011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1556
1557 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1558
d2fc7e3d 15592011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1560
1561 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1562 `width' to `bar_area_x' and `bar_area_width', respectively.
1563 (x_scroll_run): Take account of fringe background extension.
1564
04f2d78b
CB
1565 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1566 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1567 `bar_area_width', respectively.
1568 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1569 background extension.
1570
79b70037
GM
15712011-05-10 Jim Meyering <meyering@redhat.com>
1572
1573 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1574
2f142cc5
JB
15752011-05-10 Juanma Barranquero <lekktu@gmail.com>
1576
1577 * image.c (Finit_image_library): Return t for built-in image types,
1578 like pbm and xbm. (Bug#8640)
1579
57679c86
AS
15802011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1581
1582 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1583
888c9e86
EZ
15842011-05-07 Eli Zaretskii <eliz@gnu.org>
1585
b0512a1d
EZ
1586 * w32console.c (Fset_screen_color): Doc fix.
1587 (Fget_screen_color): New function.
1588 (syms_of_ntterm): Defsubr it.
1589
7285dc67
EZ
1590 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1591 unlink the temporary file if Fcall_process didn't create it in the
1592 first place.
1593 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1594 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1595 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1596 cue to call_process_cleanup not to close that handle.
1597
4d3fcc8e
BK
15982011-05-07 Ben Key <bkey76@gmail.com>
1599
1600 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1601 one of two shell specific rules, either bootstrap-temacs-CMD or
1602 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1603 to the previous implementation of the bootstrap-temacs rule.
1604 The bootstrap-temacs-CMD rule is similar to the previous
1605 implementation of the bootstrap-temacs rule except that it
1606 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1607 variable.
1608
1609 These changes, along with some changes to nt/configure.bat,
1610 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1611 earlier fix to add support for --cflags and --ldflags options
1612 that include quotes so that it works whether make uses cmd or
1613 sh as the shell.
1614
b4289b64
MA
16152011-05-06 Michael Albinus <michael.albinus@gmx.de>
1616
1617 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1618 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1619 is a constant.
1620 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1621 a string. Handle both cases.
1622 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1623 (Fdbus_register_method): Use Qinvalid_function.
1624
af4c0e28
JB
16252011-05-06 Juanma Barranquero <lekktu@gmail.com>
1626
1627 * makefile.w32-in: Update dependencies.
1628 (LISP_H): Add inttypes.h and stdin.h.
1629 (PROCESS_H): Add unistd.h.
1630
c51453d9
EZ
16312011-05-06 Eli Zaretskii <eliz@gnu.org>
1632
1633 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1634 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1635
8ff0ac3c 16362011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1637
4c4b566b
PE
1638 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1639
aab2b9b5
PE
1640 * term.c (vfatal): Remove stray call to va_end.
1641 It's not needed and the C Standard doesn't allow it here anyway.
1642
c378da0b
PE
1643 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1644 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1645
288b08c7
PE
1646 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1647 bytes.
1648
e3601888
PE
1649 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1650
db6c0e74
PE
1651 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1652
dd5963ea
PE
1653 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1654
88c9450f
PE
1655 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1656
2f9442b8
PE
1657 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1658
c032b5f8
PE
1659 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1660 * charset.c (Fdefine_charset_internal): Don't initialize
1661 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1662 32-bit int (Bug#8600).
a108c10b
PE
1663
1664 * lread.c (read_integer): Be more consistent with string-to-number.
1665 Use string_to_number to do the actual conversion; this avoids
1666 rounding errors and fixes some other screwups. Without this fix,
1667 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1668 (digit_to_number): Move earlier, for benefit of read_integer.
1669 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1670 not a digit in any supported base. (Bug#8602)
a108c10b 1671
ad5f9eea
PE
1672 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1673
aec1708a
PE
1674 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1675 to match comment at start of function. This also removes a
1676 GCC warning about overflow in a 32+64-bit port.
1677
47be4ab5
PE
1678 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1679
371cac43
PE
1680 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1681 Reported by Stefan Monnier in
1682 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1683 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1684 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1685
d01a7826
PE
1686 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1687 (EMACS_UINTPTR): Likewise, with uintptr_t.
1688
7fd47d5c
PE
1689 * lisp.h: Prefer 64-bit EMACS_INT if available.
1690 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1691 on 32-bit hosts that have 64-bit int, so that they can access
1692 large files.
122b0c86
PE
1693 However, temporarily disable this change unless the temporary
1694 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1695
8727937b
PE
1696 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1697
8ac068ac
PE
1698 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1699 This removes an assumption that EMACS_INT and long are the same
1700 width as pointers. The assumption is true for Emacs porting targets
1701 now, but we want to make other targets possible.
1702 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1703 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1704 In the rest of the code, change types of integers that hold casted
1705 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1706 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1707 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1708 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1709 No need to cast type when ORing.
1710 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1711 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1712 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1713 assume EMACS_INT is the same width as char *.
1714 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1715 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1716 Remove no-longer-needed casts.
1717 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1718 (xg_tool_bar_help_callback, xg_make_tool_item):
1719 Use EMACS_INTPTR to hold an integer
1720 that will be cast to void *; this can avoid a GCC warning
1721 if EMACS_INT is not the same width as void *.
1722 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1723 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1724 (current_message_1, set_message_1):
1725 Use a local to convert to proper width without a cast.
1726 * xmenu.c (dialog_selection_callback): Likewise.
1727
ede49d71
PE
1728 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1729 Also, don't assume VALBITS / RAND_BITS is less than 5,
1730 and don't rely on undefined behavior when shifting a 1 left into
1731 the sign bit.
1732 * lisp.h (get_random): Change signature to match.
1733
2f30ecd0
PE
1734 * lread.c (hash_string): Use size_t, not int, for hash computation.
1735 Normally we prefer signed values; but hashing is special, because
1736 it's better to use unsigned division on hash table sizes so that
1737 the remainder is nonnegative. Also, size_t is the natural width
1738 for hashing into memory. The previous code used 'int', which doesn't
1739 retain enough info to hash well into very large tables.
1740 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1741
2a866e7b
PE
1742 * dbusbind.c: Don't possibly lose pointer info when converting.
1743 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1744 Use XPNTR rather than XHASH, so that the high-order bits of
1745 the pointer aren't lost when converting through void *.
1746
51639eac
PE
1747 * eval.c (Fautoload): Don't double-shift a pointer.
1748
92394119
PE
1749 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1750
dbdb9a7c
JB
17512011-05-06 Juanma Barranquero <lekktu@gmail.com>
1752
1753 * gnutls.c (DEF_GNUTLS_FN):
1754 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1755
db7a0b4f
AS
17562011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1757
1758 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1759 marker. (Bug#8610)
1760
f7ff1b0f 17612011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1762
1763 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1764 New version that can reserve upto 2GB of heap space.
1765
f7ff1b0f 17662011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1767
1768 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1769
639c109b
TZ
17702011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1771
1772 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1773 `gnutls_certificate_set_x509_key_file'.
1774
d2127135
JB
17752011-05-05 Juanma Barranquero <lekktu@gmail.com>
1776
1777 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1778 Update dependencies.
1779
e968f4f3
JB
17802011-05-04 Juanma Barranquero <lekktu@gmail.com>
1781
1782 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1783 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1784 Remove unused parameter `fildes'.
1785 * process.c (read_process_output, send_process): Don't pass it.
1786
84d358f0
JB
17872011-05-04 Juanma Barranquero <lekktu@gmail.com>
1788
1789 Fix previous change: the library cache is defined in w32.c.
1790 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1791 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1792
0898ca10
JB
17932011-05-04 Juanma Barranquero <lekktu@gmail.com>
1794
1795 Implement dynamic loading of GnuTLS on Windows.
1796
1797 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1798 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1799 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1800 Declare.
1801
1802 * gnutls.c (Qgnutls_dll): Define.
1803 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1804 (gnutls_*): Declare function pointers.
1805 (init_gnutls_functions): New function to initialize function pointers.
1806 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1807 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1808 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1809 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1810 (emacs_gnutls_write, emacs_gnutls_read)
1811 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1812 (Fgnutls_available_p): New function.
1813 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1814 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1815 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1816
1817 * image.c: Include w32.h.
1818 (Vimage_type_cache): Delete.
1819 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1820 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1821 (w32_delayed_load): Move to w32.c.
1822
1823 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1824
1825 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1826 (w32_delayed_load): Move from image.c. When loading a library, record
1827 its filename in the :loaded-from property of the library id.
1828 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1829 Initialize and staticpro them.
1830 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1831
1832 * process.c: Include lisp.h before w32.h, not after.
1833 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1834 instead of gnutls_record_check_pending.
1835
1836 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1837
ff4de4aa
TZ
18382011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1839
1840 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1841 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1842 as passed in.
1843
abe95abb
JD
18442011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1845
1846 * xterm.c (x_set_frame_alpha): Do not set property on anything
1847 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1848
e16e55d4
JB
18492011-05-02 Juanma Barranquero <lekktu@gmail.com>
1850
1851 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1852
bafcf6a5
JB
18532011-05-02 Juanma Barranquero <lekktu@gmail.com>
1854
1855 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1856 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1857 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1858 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1859 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1860 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1861 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1862 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1863 (Qgnutls_bootprop_callbacks_verify): Make static.
1864
e7a6747f
AS
18652011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1866
19ed11ba
AS
1867 * callproc.c: Indentation fixup.
1868
e7a6747f 1869 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1870 (wait_for_termination, interruptible_wait_for_termination):
1871 Move after wait_for_termination_1.
e7a6747f 1872
1ef14cb4
LMI
18732011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1874
1875 * sysdep.c (interruptible_wait_for_termination): New function
1876 which is like wait_for_termination, but allows keyboard
1877 interruptions.
1878
1879 * callproc.c (Fcall_process): Add (:file "file") as an option for
1880 the STDOUT buffer.
1881 (Fcall_process_region): Ditto.
1882
330d880c
EZ
18832011-04-30 Eli Zaretskii <eliz@gnu.org>
1884
8db90b73
EZ
1885 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1886 rather than `XVECTOR (FOO)->size'.
1887
330d880c
EZ
1888 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1889 inttypes.h, as a gnulib replacement is used if it not available in
1890 system headers.
1891
15cbd324
EZ
18922011-04-21 Eli Zaretskii <eliz@gnu.org>
1893
1894 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1895 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1896 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1897
1898 * coding.c (coding_alloc_by_realloc): Error out if destination
1899 will grow beyond MOST_POSITIVE_FIXNUM.
1900 (decode_coding_emacs_mule): Abort if there isn't enough place in
1901 charbuf for the composition carryover bytes. Reserve an extra
1902 space for up to 2 characters produced in a loop.
1903 (decode_coding_iso_2022): Abort if there isn't enough place in
1904 charbuf for the composition carryover bytes.
1905
19062011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1907
ae940cca
EZ
1908 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1909 aborting when %lld or %lll format is passed.
1910 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1911 %llo or %llx format is passed. (Bug#8545)
1912
03ab8921
EZ
1913 * window.c (window_scroll_line_based): Use a marker instead of
1914 simple variables to record original value of point. (Bug#7952)
1915
afda1437
EZ
1916 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1917 produced by %s or %c overflows available buffer space. (Bug#8545)
1918
f76dee0c
PE
19192011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1920
1921 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1922 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1923
fdc5744d
JB
19242011-04-28 Juanma Barranquero <lekktu@gmail.com>
1925
1926 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1927
638f053a
JB
19282011-04-28 Juanma Barranquero <lekktu@gmail.com>
1929
1930 * keyboard.c (Qdelayed_warnings_hook): Define.
1931 (command_loop_1): Run `delayed-warnings-hook'
1932 if Vdelayed_warnings_list is non-nil.
1933 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1934 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1935
d178f871
EZ
19362011-04-28 Eli Zaretskii <eliz@gnu.org>
1937
1938 * doprnt.c (doprnt): Don't return value smaller than the buffer
1939 size if the message was truncated. (Bug#8545).
1940
b124fd93
JB
19412011-04-28 Juanma Barranquero <lekktu@gmail.com>
1942
1943 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1944 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1945
e810457d
PE
19462011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1947
1948 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1949
ea51cceb
JB
19502011-04-27 Juanma Barranquero <lekktu@gmail.com>
1951
1952 * makefile.w32-in: Update dependencies.
1953
94dcfacf
EZ
19542011-04-27 Eli Zaretskii <eliz@gnu.org>
1955
1956 Improve `doprnt' and its usage. (Bug#8545)
1957 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1958 `format_end'. Remove support for %l as a conversion specifier.
1959 Don't use xrealloc. Improve diagnostics when the %l size modifier
1960 is used. Update the commentary.
1961
1962 * eval.c (verror): Simplify calculation of size_t.
1963
1964 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1965 messages.
1966
f61f41d7
PE
19672011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1968
1969 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1970 change.
1971
96fb4434
PE
19722011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1973
1974 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1975 This makes this file independent of the recent pseudovector change.
1976
671875da 19772011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1978
69e9b5a3
PE
1979 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1980
b5f869a7 1981 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1982 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1983 Remove unused local.
c8926152 1984 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1985
841a1577 1986 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1987 GCC 4.6.0 optimizes based on type-based alias analysis.
1988 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1989 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1990 != &v->size, and therefore "v->size = 1; b->size = 2; return
1991 v->size;" must therefore return 1. This assumption is incorrect
1992 for Emacs, since it type-puns struct Lisp_Vector * with many other
1993 types. To fix this problem, this patch adds a new type struct
f904488f 1994 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1995 and pseudovectors, and helps optimizing compilers not get fooled
1996 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1997 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1998 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1999 the size member.
eab3844f
PE
2000 (XSETPVECTYPE): Rewrite in terms of new macro.
2001 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2002 This is a bit clearer, and further avoids the possibility of
2003 undesirable aliasing.
2004 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2005 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2006 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2007 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2008 (ASIZE): Now uses header.size rather than size.
2009 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2010 to avoid the hassle of writing XVECTOR (foo)->header.size.
2011 (struct vectorlike_header): New type.
eab3844f
PE
2012 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2013 object, to help avoid aliasing.
2014 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2015 (SUBRP): Likewise, since Lisp_Subr is a special case.
2016 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2017 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2018 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2019 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2020 changed to be "header.size" and "header.next".
2021 * buffer.h (struct buffer): Likewise.
2022 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2023 * frame.h (struct frame): Likewise.
2024 * process.h (struct Lisp_Process): Likewise.
2025 * termhooks.h (struct terminal): Likewise.
2026 * window.c (struct save_window_data, struct saved_window): Likewise.
2027 * window.h (struct window): Likewise.
2028 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2029 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2030 * buffer.c (init_buffer_once): Likewise.
2031 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2032 special case.
2033 * process.c (Fformat_network_address): Use local var for size,
2034 for brevity.
2035
0df1eac5
PE
2036 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2037
847ab9d1 2038 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2039 * data.c (atof): Remove decl; no longer used or needed.
2040 (digit_to_number): Move to lread.c.
2041 (Fstring_to_number): Use new string_to_number function, to be
2042 consistent with how the Lisp reader treats infinities and NaNs.
2043 Do not assume that floating-point numbers represent EMACS_INT
2044 without losing information; this is not true on most 64-bit hosts.
2045 Avoid double-rounding errors, by insisting on integers when
2046 parsing non-base-10 numbers, as the documentation specifies.
2047 * lisp.h (string_to_number): New decl, replacing ...
2048 (isfloat_string): Remove.
bc0a5c13 2049 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2050 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2051 appears to have been a coding error. Similarly, do not accept
2052 strings like +-1e0 as floating point numbers. Do not report
2053 overflow for integer overflows unless the base is not 10 which
2054 means we have no simple and reliable way to continue.
2055 Break out the floating-point parsing into a new
2056 function string_to_number, so that Fstring_to_number parses
2057 floating point numbers consistently with the Lisp reader.
04f2d78b 2058 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2059 (E_CHAR, EXP_INT): Remove, replacing with ...
2060 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2061 (string_to_number): New function, replacing isfloat_string.
2062 This function checks for valid syntax and produces the resulting
2063 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2064 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2065 so that overflow for non-base-10 numbers is reported only when
2066 there's no portable and simple way to convert to floating point.
452f4150 2067
67769ffc
PE
2068 * textprop.c (set_text_properties_1): Rewrite for clarity,
2069 and to avoid GCC warning about integer overflow.
2070
c20db43f
PE
2071 * intervals.h (struct interval): Use EMACS_INT for members
2072 where EMACS_UINT might cause problems. See
2073 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2074 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2075 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2076 All uses changed.
37aa2f85
PE
2077 (offset_intervals): Tell GCC not to worry about length overflow
2078 when negating a negative length.
c20db43f 2079
2538aa2f
PE
2080 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2081 (overrun_check_free): Likewise.
2082
f2d3008d
PE
2083 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2084 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2085 word size.
2086
ec8df744
PE
2087 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2088 (gnutls_make_error): Rename local to avoid shadowing.
2089 (gnutls_emacs_global_deinit): ifdef out; not used.
2090 (Fgnutls_boot): Use const for pointer to readonly storage.
2091 Comment out unused local. Fix pointer signedness problems.
2092
640ee02d
PE
2093 * lread.c (openp): Don't stuff size_t into an 'int'.
2094 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2095 about possible signed overflow.
2096
6048fb2a
PE
2097 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2098 (GDK_KEY_g): Don't define if already defined.
2099 (xg_prepare_tooltip): Avoid pointer signedness problem.
2100 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2101
fa3c87e1
PE
2102 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2103 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2104
2172544b
PE
2105 * xfns.c (Fx_window_property): Simplify a bit,
2106 to make a bit faster and to avoid GCC 4.6.0 warning.
2107 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2108
9b821a21
PE
2109 * fns.c (internal_equal): Don't assume size_t fits in int.
2110
3c616cfa
PE
2111 * alloc.c (compact_small_strings): Tighten assertion a little.
2112
c2982e87
PE
2113 Replace pEd with more-general pI, and fix some printf arg casts.
2114 * lisp.h (pI): New macro, generalizing old pEd macro to other
2115 conversion specifiers. For example, use "...%"pI"d..." rather
2116 than "...%"pEd"...".
2117 (pEd): Remove. All uses replaced with similar uses of pI.
2118 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2119 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2120 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2121 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2122 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2123 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2124 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2125 64-bit hosts.
2126 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2127 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2128 * print.c (safe_debug_print, print_object): Likewise.
2129 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2130 to int.
6f04d126
PE
2131 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2132 avoiding the 0 flag, which is not portable.
c2982e87
PE
2133 * process.c (Fmake_network_process): Use pI to avoid cast.
2134 * region-cache.c (pp_cache): Likewise.
2135 * xdisp.c (decode_mode_spec): Likewise.
2136 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2137 behavior on 64-bit hosts with printf arg.
6f04d126 2138 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2139 (x_stop_queuing_selection_requests): Likewise.
2140 (x_get_window_property): Don't truncate byte count to an 'int'
2141 when tracing.
0b432f21 2142
5e073ec7
PE
2143 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2144 here, since it parses constructs like leading '-' and spaces,
2145 which are not wanted; and it overflows with large numbers.
2146 Instead, simply match F[0-9]+, which is what is wanted anyway.
2147
36372bf9
PE
2148 * alloc.c: Remove unportable assumptions about struct layout.
2149 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2150 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2151 (allocate_vectorlike, make_pure_vector): Use the new macros,
2152 plus offsetof, to remove unportable assumptions about struct layout.
2153 These assumptions hold on all porting targets that I know of, but
2154 they are not guaranteed, they're easy to remove, and removing them
2155 makes further changes easier.
2156
0b432f21
PE
2157 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2158 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2159 (string_overrun_cookie): Now const. Use initializers that
2160 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2161 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2162 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2163 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2164 multiple of sizeof (EMACS_INT); it need not be, if
2165 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2166 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2167
895009e1
JB
21682011-04-26 Juanma Barranquero <lekktu@gmail.com>
2169
2170 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2171
6a7a1b0b
TZ
21722011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2173
2174 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2175 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2176 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2177
841a1577 21782011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2179
2180 * lisp.h (Qdebug): List symbol.
895009e1 2181 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2182 * keyboard.c (debug-on-event): New variable.
2183 (handle_user_signal): Break into debugger when debug-on-event
2184 matches the current signal symbol.
2185
f2d3ba6f
DN
21862011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2187
2188 * alloc.c (check_sblock, check_string_bytes)
2189 (check_string_free_list): Convert to standard C.
2190
42ce4c63
TZ
21912011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2192
2193 * w32.c (emacs_gnutls_push): Fix typo.
2194
825cd63c
EZ
21952011-04-25 Eli Zaretskii <eliz@gnu.org>
2196
fb11d64d
EZ
2197 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2198 "cast to pointer from integer of different size".
2199
825cd63c
EZ
2200 Improve doprnt and its use in verror. (Bug#8545)
2201 * doprnt.c (doprnt): Document the set of format control sequences
2202 supported by the function. Use SAFE_ALLOCA instead of always
2203 using `alloca'.
2204
2205 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2206 is one byte too soon. Don't use xrealloc; instead xfree and
2207 xmalloc anew.
2208
e061a11b
TZ
22092011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2210
2211 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2212 callbacks stage.
2213
2214 * gnutls.c: Renamed global_initialized to
2215 gnutls_global_initialized. Added internals for the
2216 :verify-hostname-error, :verify-error, and :verify-flags
2217 parameters of `gnutls-boot' and documented those parameters in the
2218 docstring. Start callback support.
2219 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2220 unless a fatal error occured. Call gnutls_alert_send_appropriate
2221 on error. Return error code.
2222 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2223 (emacs_gnutls_read): Likewise.
2224 (Fgnutls_boot): Return handshake error code.
2225 (emacs_gnutls_handle_error): New function.
2226 (wsaerror_to_errno): Likewise.
2227
2228 * w32.h (emacs_gnutls_pull): Add prototype.
2229 (emacs_gnutls_push): Likewise.
2230
2231 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2232 (emacs_gnutls_push): Likewise.
2233
22342011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2235
2236 * process.c (wait_reading_process_output): Check if GnuTLS
2237 buffered some data internally if no FDs are set for TLS
2238 connections.
2239
2240 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2241 (LIBS): Link to USER_LIBS.
2242 ($(BLD)/gnutls.$(0)): New target.
2243
fa6996bc
EZ
22442011-04-24 Eli Zaretskii <eliz@gnu.org>
2245
eb35682e
EZ
2246 * xdisp.c (handle_single_display_spec): Rename the
2247 display_replaced_before_p argument into display_replaced_p, to
2248 make it consistent with the commentary. Fix typos in the
2249 commentary.
2250
e2ad650c
EZ
2251 * textprop.c (syms_of_textprop): Remove dead code.
2252 (copy_text_properties): Delete obsolete commentary about an
2253 interface that was deleted long ago. Fix typos in the description
2254 of arguments.
2255
1b2de274
EZ
2256 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2257 to changes in oldXMenu/XMenu.h from 2011-04-16.
2258 <menu_help_message, prev_menu_help_message>: Constify.
2259 (IT_menu_make_room): menu->help_text is now `const char **';
2260 adjust.
2261
2262 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2263 to changes in oldXMenu/XMenu.h from 2011-04-16.
2264 (struct XMenu): Declare `help_text' `const char **'.
2265
2266 * xfaces.c <Qunspecified>: Make extern again.
2267
2268 * syntax.c: Include sys/types.h before including regex.h, as
2269 required by Posix.
2270
762b15be
EZ
2271 * doc.c (get_doc_string): Improve the format passed to `error'.
2272
2273 * doprnt.c (doprnt): Improve commentary.
2274
2275 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2276
2277 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2278 them with etags.
2279
f1052e5d
EZ
2280 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2281 changes in globals.h immediately force recompilation.
762b15be
EZ
2282 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2283 $(CURDIR)/s/ms-w32.h.
2284 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2285
fa6996bc
EZ
2286 * character.c (Fchar_direction): Function deleted.
2287 (syms_of_character): Don't defsubr it.
2288 <char-direction-table>: Deleted.
2289
e6c3da20
EZ
22902011-04-23 Eli Zaretskii <eliz@gnu.org>
2291
2292 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2293 * doprnt.c: Include limits.h.
2294 (SIZE_MAX): New macro.
04f2d78b
CB
2295 (doprnt): Return a size_t value. 2nd arg is now size_t.
2296 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2297 Improve overflow protection. Support `l' modifier for integer
2298 conversions. Support %l conversion. Don't assume an EMACS_INT
2299 argument for integer conversions and for %c.
2300
2301 * lisp.h (doprnt): Restore prototype.
2302
2303 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2304 $(SRC)/character.h.
2305
2306 * Makefile.in (base_obj): Add back doprnt.o.
2307
2308 * deps.mk (doprnt.o): Add back prerequisites.
2309 (callint.o): Depend on character.h.
2310
2311 * eval.c (internal_lisp_condition_case): Include the handler
2312 representation in the error message.
2313 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2314 when breaking from the loop.
2315
2316 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2317
2318 * callint.c (Fcall_interactively): When displaying error message
2319 about invalid control letter, pass the character's codepoint, not
2320 a pointer to its multibyte form. Improve display of the character
2321 in octal and display also its hex code.
2322
2323 * character.c (char_string): Use %x to display the (unsigned)
2324 codepoint of an invalid character, to avoid displaying a bogus
2325 negative value.
2326
2327 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2328 `error', not SYMBOL_NAME itself.
2329
2330 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2331 character arguments to `error'.
2332
2333 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2334 to `error' in error message about FINAL_CHAR argument. Make sure
2335 FINAL_CHAR is a character, and use %c when it is passed as
2336 argument to `error'.
2337
4ffd0d6b 23382011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2339
2340 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2341
2342 * w32.c: Include <time.h>.
2343 (sys_localtime): New function.
2344
4ffd0d6b 23452011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2346
2347 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2348
4ffd0d6b 2349 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2350
4ffd0d6b 23512011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2352
4ffd0d6b
GM
2353 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2354 zombies (Bug#8467).
aac0c6e3 2355
04c56954
EZ
23562011-04-19 Eli Zaretskii <eliz@gnu.org>
2357
2358 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2359 gl_state.e_property when gl_state.object is Qt.
2360
2361 * insdel.c (make_gap_larger): Remove limitation of buffer size
2362 to <= INT_MAX.
2363
16a43933
CY
23642011-04-18 Chong Yidong <cyd@stupidchicken.com>
2365
2366 * xdisp.c (lookup_glyphless_char_display)
2367 (produce_glyphless_glyph): Handle cons cell entry in
2368 glyphless-char-display.
2369 (Vglyphless_char_display): Document it.
2370
2371 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2372 glyphless-char-display.
2373
4581706e
CY
23742011-04-17 Chong Yidong <cyd@stupidchicken.com>
2375
2376 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2377
2378 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2379
2380 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2381 definition for no-X builds.
2382
4887c6e2 23832011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2384
fd35b6f9
PE
2385 Static checks with GCC 4.6.0 and non-default toolkits.
2386
5c1ccb01
PE
2387 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2388
006c5daa
PE
2389 * process.c (keyboard_bit_set): Define only if SIGIO.
2390 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2391 (send_process): Repair possible setjmp clobbering.
2392
efc736d3
PE
2393 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2394
4e2fe2e6
PE
2395 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2396
f97334a2
PE
2397 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2398
4e75f29d
PE
2399 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2400 Define only if needed.
2401
90efadd1
PE
2402 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2403 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2404 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2405
3c647824
PE
2406 * dispextern.h (struct redisplay_interface): Rename param
2407 to avoid shadowing.
e264f262 2408 * termhooks.h (struct terminal): Likewise.
761383f4 2409 * xterm.c (xembed_send_message): Likewise.
3c647824 2410
b58c5c4a
PE
2411 * insdel.c (make_gap_smaller): Define only if
2412 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2413
cad59032
PE
2414 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2415 it.
2416
c339dc2e
PE
2417 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2418 so that we aren't warned about unused symbols.
2419
91a3e27b
PE
2420 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2421
399c71d3 2422 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2423
8ffc96f5
PE
2424 * xfns.c (x_real_positions): Mark locals as initialized.
2425
eef9bc79
PE
2426 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2427
098db9dd
PE
2428 * xterm.c: Fix problems found by static analysis with other toolkits.
2429 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2430 (x_dispatch_event): Declare static if USE_GTK, and
2431 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2432 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2433 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2434 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2435 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2436
eb18f6cc
PE
2437 * xmenu.c (menu_help_callback): Pointer type fixes.
2438 Use const pointers when pointing at readonly data. Avoid pointer
2439 signedness clashes.
2440 (FALSE): Remove unused macro.
2441 (update_frame_menubar): Remove unused decl.
2442
1fe72bf8
PE
2443 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2444
60d9e1db
PE
2445 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2446 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2447 (single_menu_item): Rename local to avoid shadowing.
2448
39261c26
PE
2449 * keyboard.c (make_lispy_event): Remove unused local var.
2450
018c5e19
PE
2451 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2452 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2453
63d2b86e
PE
2454 * bitmaps: Change bitmaps from unsigned char back to the X11
2455 compatible char. Avoid the old compiler warnings about
2456 out-of-range initializers by using, for example, '\xab' rather
2457 than 0xab.
2458
aefd87e1
PE
2459 * xgselect.c (xgselect_initialize): Check vs interface
2460 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2461
bf501fb9
PE
2462 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2463
e9829fdf
PE
2464 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2465 to read-only memory.
2466
1086c095
PE
2467 * fns.c (vector): Remove; this old hack is no longer needed.
2468
2baccd04 2469 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2470 Remove unused var.
dde42981 2471 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2472
72391843 2473 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2474
436c16df 2475 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2476 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2477 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2478
92bb796d 2479 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2480 (x_term_init): Remove local to avoid shadowing.
92bb796d 2481
764430a3 2482 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2483
2484 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2485 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2486
d1dfb56c
EZ
24872011-04-16 Eli Zaretskii <eliz@gnu.org>
2488
c4354cb4
EZ
2489 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2490
d1dfb56c
EZ
2491 Fix regex.c, syntax.c and friends for buffers > 2GB.
2492 * syntax.h (struct gl_state_s): Declare character position members
2493 EMACS_INT.
2494
2495 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2496
04f2d78b
CB
2497 * textprop.c (verify_interval_modification, interval_of):
2498 Declare arguments EMACS_INT.
d1dfb56c
EZ
2499
2500 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2501 EMACS_INT.
2502
2503 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2504
2505 * indent.c (Fvertical_motion): Local variable it_start is now
2506 EMACS_INT.
2507
2508 * regex.c (re_match, re_match_2, re_match_2_internal)
2509 (bcmp_translate, regcomp, regexec, print_double_string)
2510 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2511 (re_compile_pattern, re_exec): Declare arguments and local
2512 variables `size_t' and `ssize_t' and return values `regoff_t', as
2513 appropriate.
2514 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2515 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2516 <compile_stack_type>: `size' and `avail' are now `size_t'.
2517
2518 * regex.h <regoff_t>: Use ssize_t, not int.
2519 (re_search, re_search_2, re_match, re_match_2): Arguments that
2520 specify buffer/string position and length are now ssize_t and
2521 size_t. Return type is regoff_t.
2522
613052cd
BK
25232011-04-16 Ben Key <bkey76@gmail.com>
2524
2525 * nsfont.m: Fixed bugs in ns_get_family and
2526 ns_descriptor_to_entity that were caused by using free to
2527 deallocate memory blocks that were allocated by xmalloc (via
2528 xstrdup). This caused Emacs to crash when compiled with
2529 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2530 --enable-checking=xmallocoverrun). xfree is now used to
2531 deallocate these memory blocks.
2532
4170f62f 25332011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2534
71b41406
PE
2535 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2536
9587a89d
PE
2537 emacs_write: Accept and return EMACS_INT for sizes.
2538 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2539 et seq.
2540 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2541 Accept and return EMACS_INT.
2542 (emacs_gnutls_write): Return the number of bytes written on
2543 partial writes.
2544 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2545 (emacs_read, emacs_write): Remove check for negative size, as the
2546 Emacs source code has been audited now.
9587a89d
PE
2547 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2548 (emacs_read, emacs_write): Use it.
273a5f82
PE
2549 * process.c (send_process): Adjust to the new signatures of
2550 emacs_write and emacs_gnutls_write. Do not attempt to store
2551 a byte offset into an 'int'; it might overflow.
9587a89d 2552 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2553
3e047f51
PE
2554 * sound.c: Don't assume sizes fit in 'int'.
2555 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2556 Return EMACS_INT, not int.
3e047f51 2557 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2558 Accept EMACS_INT, not int.
2559 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2560 record read return values.
2561
cc39a9db
BK
25622011-04-15 Ben Key <bkey76@gmail.com>
2563
c9d0ec6d
JB
2564 * keyboard.c (Qundefined): Don't declare static since it is used
2565 in nsfns.m.
2566 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2567 static since they are used in nsfont.m.
cc39a9db 2568
6c60eb9f
SM
25692011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2570
2571 * process.c (Qprocessp): Don't declare static.
2572 * lisp.h (Qprocessp): Declare again.
2573
7990b61a
JB
25742011-04-15 Juanma Barranquero <lekktu@gmail.com>
2575
2576 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2577
5d4cb038
PE
25782011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2579
8bd7b830 2580 Improve C-level modularity by making more things 'static'.
cd64ea1d 2581
e3b27b31
PE
2582 Don't publish debugger-only interfaces to other modules.
2583 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2584 (verify_bytepos, count_markers): Move decls to the only modules
2585 that need them.
2586 * region-cache.h (pp_cache): Likewise.
2587 * window.h (check_all_windows): Likewise.
2588 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2589
5d4cb038
PE
2590 * sysdep.c (croak): Now static, if
2591 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2592 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2593
2594 * alloc.c (refill_memory_reserve): Now static if
2595 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2596 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2597
e87b6180
PE
2598 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2599 Define only if USE_LUCID.
2600
ac64929e
PE
2601 * xrdb.c (x_customization_string, x_rm_string): Now static.
2602
6f37259d
PE
2603 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2604 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2605
1683e3ab
PE
2606 * xdisp.c (draw_row_with_mouse_face): Now static.
2607 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2608
de9c2632
PE
2609 * window.h (check_all_windows): Mark externally visible.
2610
2b96acb7
PE
2611 * window.c (window_deletion_count): Now static.
2612
2613 * undo.c: Make symbols static if they're not exported.
2614 (last_undo_buffer, last_boundary_position, pending_boundary):
2615 Now static.
2616
50436f33
PE
2617 * textprop.c (interval_insert_behind_hooks): Now static.
2618 (interval_insert_in_front_hooks): Likewise.
2619
64520e5c
PE
2620 * term.c: Make symbols static if they're not exported.
2621 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2622 (max_frame_lines, tty_set_terminal_modes):
2623 (tty_reset_terminal_modes, tty_turn_off_highlight):
2624 (get_tty_terminal): Now static.
2625 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2626 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2627 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2628 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2629 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2630
1fa53021
PE
2631 * sysdep.c: Make symbols static if they're not exported.
2632 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2633 Now static.
2634 (sigprocmask_set, full_mask): Remove; unused.
2635 (wait_debugging): Mark as visible.
2636 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2637 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2638
d4b43b22
PE
2639 * syntax.c (syntax_temp): Define only if !__GNUC__.
2640
b7c513d0
PE
2641 * sound.c (current_sound_device, current_sound): Now static.
2642
989b29ad
PE
2643 * search.c (searchbufs, searchbuf_head): Now static.
2644
13a55a78
PE
2645 * scroll.c (scroll_cost): Remove; unused.
2646 * dispextern.h (scroll_cost): Remove decl.
2647
de68a1fc
PE
2648 * region-cache.h (pp_cache): Mark as externally visible.
2649
40ccffa6
PE
2650 * process.c: Make symbols static if they're not exported.
2651 (process_tick, update_tick, create_process, chan_process):
2652 (Vprocess_alist, proc_buffered_char, datagram_access):
2653 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2654 (deactivate_process): Mark defn as static, as well as decl.
2655 * lisp.h (create_process): Remove decl.
2656 * process.h (chan_process, Vprocess_alist): Remove decls.
2657
ad64fc97
PE
2658 * print.c: Make symbols static if they're not exported.
2659 (print_depth, new_backquote_output, being_printed, print_buffer):
2660 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2661 (print_interval, print_number_index, initial_stderr_stream):
2662 Now static.
2663 * lisp.h (Fprinc): Remove decl.
2664 (debug_output_compilation_hack): Mark as externally visible.
2665
adddb265
PE
2666 * sysdep.c (croak): Move decl from here to syssignal.h.
2667 * syssignal.h (croak): Put it here, so the API can be checked when
2668 'croak' is called from dissociate_if_controlling_tty.
2669
1717ede2
PE
2670 * minibuf.c: Make symbols static if they're not exported.
2671 (minibuf_save_list, choose_minibuf_frame): Now static.
2672 * lisp.h (choose_minibuf_frame): Remove decl.
2673
fa5fb2bc
PE
2674 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2675
1e3890d1
PE
2676 * lread.c: Make symbols static if they're not exported.
2677 (read_objects, initial_obarray, oblookup_last_bucket_number):
2678 Now static.
2679 (make_symbol): Remove; unused.
2680 * lisp.h (initial_obarray, make_symbol): Remove decls.
2681
8a1414fa
PE
2682 * keyboard.c: Make symbols static if they're not exported.
2683 (single_kboard, recent_keys_index, total_keys, recent_keys):
2684 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2685 (this_single_command_key_start, echoing, last_auto_save):
2686 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2687 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2688 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2689 (Vlispy_mouse_stem, double_click_count):
2690 Now static.
2691 (force_auto_save_soon): Define only if SIGDANGER.
2692 (ignore_mouse_drag_p): Now static if
2693 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2694 (print_help): Remove; unused.
2695 (stop_character, last_timer_event): Mark as externally visible.
2696 * keyboard.h (ignore_mouse_drag_p): Declare only if
2697 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2698 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2699 * lisp.h (echoing): Remove decl.
2700 (force_auto_save_soon): Declare only if SIGDANGER.
2701 * xdisp.c (redisplay_window): Simplify code, to make it more
2702 obvious that ignore_mouse_drag_p is not accessed if !defined
2703 USE_GTK && !defined HAVE_NS.
2704
93ea6e8f
PE
2705 * intervals.c: Make symbols static if they're not exported.
2706 (merge_properties_sticky, merge_interval_right, delete_interval):
2707 Now static.
2708 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2709
77382fcc
PE
2710 * insdel.c: Make symbols static if they're not exported.
2711 However, leave prepare_to_modify_buffer alone. It's never
2712 called from outside this function, but that appears to be a bug.
2713 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2714 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2715 (adjust_after_replace_noundo): Remove; unused.
2716 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2717 (signal_before_change): Remove decls.
77382fcc 2718
9306c32e
PE
2719 * indent.c (val_compute_motion, val_vmotion): Now static.
2720
cd44d2eb
PE
2721 * image.c: Make symbols static if they're not exported.
2722 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2723 if USE_GTK.
2724 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2725 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2726
ad9a7a06
PE
2727 * fringe.c (standard_bitmaps): Now static.
2728 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2729
81626931
PE
2730 * frame.c: Make symbols static if they're not exported.
2731 (x_report_frame_params, make_terminal_frame): Now static.
2732 (get_frame_param): Now static, unless HAVE_NS.
2733 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2734 (x_get_resource_string): Remove; not used.
2735 * frame.h (make_terminal_frame, x_report_frame_params):
2736 (x_get_resource_string); Remove decls.
2737 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2738 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2739
239f9db9
PE
2740 * font.c, fontset.c: Make symbols static if they're not exported.
2741 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2742 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2743 * font.c (font_close_object): Now static.
2744 * font.h (font_close_object): Remove.
2745 * fontset.c (FONTSET_OBJLIST): Remove.
2746 (free_realized_fontset) #if-0 the body, which does nothing.
2747 (face_suitable_for_char_p): #if-0, as it's never called.
2748 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2749 * xfaces.c (face_at_string_position):
2750 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2751 since 0 is always ASCII.
2752
dfcf3579
PE
2753 * fns.c (weak_hash_tables): Now static.
2754
5045092b
PE
2755 * fileio.c: Make symbols static if they're not exported.
2756 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2757 (Vwrite_region_annotation_buffers): Now static.
2758
57a96f5c
PE
2759 * eval.c: Make symbols static if they're not exported.
2760 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2761 * lisp.h (backtrace_list): Remove decl.
2762
35f08c38
PE
2763 * emacs.c: Make symbols static if they're not exported.
2764 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2765 (fatal_error_code, fatal_error_signal_hook, standard_args):
2766 Now static.
2767 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2768 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2769 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2770 * lisp.h (fatal_error_signal_hook): Remove decl.
2771 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2772
f44bd759
PE
2773 * editfns.c: Move a (normally-unused) function to its only use.
2774 * editfns.c, lisp.h (get_operating_system_release): Remove.
2775 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2776 worth the hassle of breaking this out.
2777
b532497d
PE
2778 * xterm.c: Make symbols static if they're not exported.
2779 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2780 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2781 (x_destroy_window, x_delete_display):
2782 Now static.
2783 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2784 (x_mouse_leave): Remove; unused.
2785 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2786 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2787 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2788 Remove decls.
2789 (x_mouse_leave): Declare only if WINDOWSNT.
2790 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2791 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2792 USE_X_TOOLKIT.
2793
1675728f
PE
2794 * ftxfont.c: Make symbols static if they're not exported.
2795 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2796 HAVE_FREETYPE.
2797 * font.h (ftxfont_driver): Likewise.
2798
e4cebfca
PE
2799 * xfns.c: Make symbols static if they're not exported.
2800 (x_last_font_name, x_display_info_for_name):
2801 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2802 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2803 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2804 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2805 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2806 (last_show_tip_args): Now static.
2807 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2808 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2809 (x_screen_planes): Remove; unused.
2810 * dispextern.h (x_screen_planes): Remove decl.
2811
5bf46f05
PE
2812 * dispnew.c: Make symbols static if they're not exported.
2813 * dispextern.h (redraw_garbaged_frames, scrolling):
2814 (increment_row_positions): Remove.
2815 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2816 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2817 Now static.
2818 (redraw_garbaged_frames): Remove; unused.
2819
435f4c28
PE
2820 * xfaces.c: Make symbols static if they're not exported.
2821 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2822 Remove decls.
2823 * xterm.h (defined_color): Remove decls.
2824 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2825 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2826 (menu_face_changed_default, defined_color, free_realized_face):
2827 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2828 (ascii_face_of_lisp_face): Remove; unused.
2829
8524aef3
PE
2830 * xdisp.c: Make symbols static if they're not exported.
2831 * dispextern.h (scratch_glyph_row, window_box_edges):
2832 (glyph_to_pixel_coords, set_cursor_from_row):
2833 (get_next_display_element, set_iterator_to_next):
2834 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2835 (show_mouse_face): Remove decls
2836 * frame.h (message_buf_print): Likewise.
2837 * lisp.h (pop_message, set_message, check_point_in_composition):
2838 Likewise.
2839 * xterm.h (set_vertical_scroll_bar): Likewise.
2840 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2841 (message_buf_print, scratch_glyph_row, displayed_buffer):
2842 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2843 (get_next_display_element, show_mouse_face, window_box_edges):
2844 (frame_to_window_pixel_xy, check_point_in_composition):
2845 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2846 (glyph_to_pixel_coords): Remove; unused.
2847
16390cd2
PE
2848 * dired.c (file_name_completion): Now static.
2849
2850 * dbusbind.c (xd_in_read_queued_messages): Now static.
2851
a25f4dfa
PE
2852 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2853 * data.c (circular_list_error): Remove.
2854
14a9c8df
PE
2855 * commands.h (last_point_position, last_point_position_buffer):
2856 (last_point_position_window): Remove decls.
2857 * keyboard.c: Make these variables static.
2858
04f2d78b
CB
2859 * coding.h (coding, code_convert_region, encode_coding_gap):
2860 Remove decls.
74ab6df5
PE
2861 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2862 (iso_code_class, detect_coding, code_convert_region): Now static.
2863 (encode_coding_gap): Remove; unused.
2864
38dfbee1
PE
2865 * chartab.c (chartab_chars, chartab_bits): Now static.
2866
a2cb4e63
PE
2867 * charset.h (charset_iso_8859_1): Remove decl.
2868 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2869 Now static.
2870
127198fd
PE
2871 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2872 * ccl.c (Vccl_program_table): Now static.
2873 (check_ccl_update): Remove; unused.
2874
d85b608f
PE
2875 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2876 * category.h: ... from here.
2877 * category.c (check_category_table, set_category_set): Now static.
2878
31cd66f3
PE
2879 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2880 * lisp.h: Remove these decls.
2881
c358e587
PE
2882 * buffer.c (buffer_count): Remove unused var.
2883
e78aecca
PE
2884 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2885 so that it's not optimized away.
2886 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2887 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2888 exported only to the debugger.
2889
e192d7d3 2890 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2891 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2892
92470028
PE
2893 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2894 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2895 was inaccessible from Lisp.
2896 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2897 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2898
244ed907
PE
2899 alloc.c: Import and export fewer symbols, and remove unused items.
2900 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2901 is defined.
2902 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2903 it's not optimized away by whole-program optimization.
2904 (message_enable_multibyte, free_misc): Remove.
2905 (catchlist, handlerlist, mark_backtrace):
2906 Declare only if BYTE_MARK_STACK.
2907 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2908 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2909 (message_enable_multibyte): Remove decl.
2910 (free_misc, interval_free_list, float_block, float_block_index):
2911 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2912 (cons_free_list, last_marked_index):
2913 Now static.
2914 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2915 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2916 (mark_backtrace): Define only if BYTE_MARK_STACK.
2917 * xdisp.c (message_enable_multibyte): Now static.
2918
61c2b50e 2919 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2920 This makes it easier for human readers (and static analyzers)
2921 to see whether these variables are used from other modules.
2922 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2923 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2924 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2925 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2926 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2927 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2928 * xmenu.c, xselect.c:
2929 Declare Q* vars static if they are not used in other modules.
2930 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2931 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2932 Remove decls of unexported vars.
2933 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2934
95c82688
PE
2935 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2936
16a97296
PE
2937 Make Emacs functions such as Fatom 'static' by default.
2938 This makes it easier for human readers (and static analyzers)
2939 to see whether these functions can be called from other modules.
2940 DEFUN now defines a static function. To make the function external
2941 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2942 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2943 (Finit_image_library):
16a97296
PE
2944 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2945 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2946 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2947 Remove decls, since these functions are now static.
2948 (Funintern, Fget_internal_run_time): New decls, since these functions
2949 were already external.
95c82688 2950
16a97296
PE
2951 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2952 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2953 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2954 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2955 * keyboard.c, keymap.c, lread.c:
2956 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2957 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2958 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2959 Mark functions with DEFUE instead of DEFUN,
2960 if they are used in other modules.
2961 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2962 decls for now-static functions.
2963 * buffer.h (Fdelete_overlay): Remove decl.
2964 * callproc.c (Fgetenv_internal): Mark as internal.
2965 * composite.c (Fremove_list_of_text_properties): Remove decl.
2966 (Fcomposition_get_gstring): New forward static decl.
2967 * composite.h (Fcomposite_get_gstring): Remove decl.
2968 * dired.c (Ffile_attributes): New forward static decl.
2969 * doc.c (Fdocumntation_property): New forward static decl.
2970 * eval.c (Ffetch_bytecode): New forward static decl.
2971 (Funintern): Remove extern decl; now in .h file where it belongs.
2972 * fileio.c (Fmake_symbolic_link): New forward static decl.
2973 * image.c (Finit_image_library): New forward static decl.
2974 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2975 * intervals.h (Fprevious_property_change):
2976 (Fremove_list_of_text_properties): Remove decls.
2977 * keyboard.c (Fthis_command_keys): Remove decl.
2978 (Fcommand_execute): New forward static decl.
2979 * keymap.c (Flookup_key): New forward static decl.
2980 (Fcopy_keymap): Now static.
2981 * keymap.h (Flookup_key): Remove decl.
2982 * process.c (Fget_process): New forward static decl.
2983 (Fprocess_datagram_address): Mark as internal.
2984 * syntax.c (Fsyntax_table_p): New forward static decl.
2985 (skip_chars): Remove duplicate decl.
2986 * textprop.c (Fprevious_property_change): New forward static decl.
2987 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2988 Now internal.
2989 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2990 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2991
785bbd42
PE
2992 * editfns.c (Fformat): Remove unreachable code.
2993
8b913b57
AS
29942011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2995
2996 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2997 change. (Bug#8496)
2998
a6744a35
EZ
29992011-04-13 Eli Zaretskii <eliz@gnu.org>
3000
3001 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3002 when at ZV. (Bug#8487)
3003
e7974947
AS
30042011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3005
baad03f0
AS
3006 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3007 (Bug#8437)
3008 * keyboard.c (parse_tool_bar_item): Likewise.
3009 * sound.c (sound_cleanup, alsa_close): Likewise.
3010 * termcap.c (tgetent): Likewise.
3011 * xfns.c (x_default_font_parameter): Likewise.
3012 * xsettings.c (read_and_apply_settings): Likewise.
3013
e7974947
AS
3014 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3015 (overrun_check_free): Protoize.
3016
28272684
PE
30172011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3018
3019 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3020 since callers should never pass a negative size.
3021 Change the signature to match that of plain 'read' and 'write'; see
3022 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3023 * lisp.h: Update prototypes of emacs_write and emacs_read.
3024
11997c76
EZ
30252011-04-11 Eli Zaretskii <eliz@gnu.org>
3026
3027 * xdisp.c (redisplay_window): Don't try to determine the character
3028 position of the scroll margin if the window start point w->startp
e896f03c 3029 is outside the buffer's accessible region. (Bug#8468)
11997c76 3030
8a2cbd72
EZ
30312011-04-10 Eli Zaretskii <eliz@gnu.org>
3032
3033 Fix write-region and its subroutines for buffers > 2GB.
3034 * fileio.c (a_write, e_write): Modify declaration of arguments and
3035 local variables to support buffers larger than 2GB.
3036 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3037
3038 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3039 argument, local variables, and return value.
3040
3041 * lisp.h: Update prototypes of emacs_write and emacs_read.
3042
3043 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3044
4073e537 30452011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3046
1ebfdcb6
PE
3047 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3048
b2ded58d
PE
3049 Fix more problems found by GCC 4.6.0's static checks.
3050
7d66342c
PE
3051 * xdisp.c (vmessage): Use a better test for character truncation.
3052
bbf47d44
PE
3053 * charset.c (load_charset_map): <, not <=, for optimization,
3054 and to avoid potential problems with integer overflow.
9248994d 3055 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3056 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3057 * editfns.c (Fformat): Likewise.
1e69125e 3058 * syntax.c (skip_chars): Likewise.
3befa583 3059
e3019616
PE
3060 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3061 This also lets GCC 4.6.0 generate slightly better loop code.
3062
becfa255
PE
3063 * callint.c (Fcall_interactively): <, not <=, for optimization.
3064 (Fcall_interactively): Count the number of arguments produced,
3065 not the number of arguments given. This is simpler and lets GCC
3066 4.6.0 generate slightly better code.
3067
dae0cd48
PE
3068 * ftfont.c: Distingish more carefully between FcChar8 and char.
3069 The previous code passed unsigned char * to a functions like
3070 strlen and xstrcasecmp that expect char *, which does not
3071 conform to the C standard.
3072 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3073 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3074 char * when the C standard requires it.
3075
76032d70
PE
3076 * keyboard.c (read_char): Remove unused var.
3077
eb3f1cc8
PE
3078 * eval.c: Port to Windows vsnprintf (Bug#8435).
3079 Include <limits.h>.
3080 (SIZE_MAX): Define if the headers do not.
3081 (verror): Do not give up if vsnprintf returns a negative count.
3082 Instead, grow the buffer. This ports to Windows vsnprintf, which
3083 does not conform to C99. Problem reported by Eli Zaretskii.
3084 Also, simplify the allocation scheme, by avoiding the need for
3085 calling realloc, and removing the ALLOCATED variable.
3086
70476b54
PE
3087 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3088
12020a9e
PE
3089 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3090 But keep the doprint source code for now, as we might revamp it
3091 and use it again (Bug#8435).
ea6c7ae6
PE
3092 * lisp.h (doprnt): Remove.
3093 * Makefile.in (base_obj): Remove doprnt.o.
3094 * deps.mk (doprnt.o): Remove.
3095
5fdb398c
PE
3096 error: Print 32- and 64-bit integers portably (Bug#8435).
3097 Without this change, on typical 64-bit hosts error ("...%d...", N)
3098 was used to print both 32- and 64-bit integers N, which relied on
3099 undefined behavior.
3100 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3101 New macro.
3102 * lisp.h (error, verror): Mark as printf-like functions.
3103 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3104 Report overflow in size calculations when allocating printf buffer.
3105 Do not truncate output string at its first null byte.
3106 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3107 Truncate the output at a character boundary, since vsnprintf does not
3108 do that.
3109 * charset.c (check_iso_charset_parameter): Convert internal
3110 character to string before calling 'error', since %c now has the
3111 printf meaning.
3112 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3113 overflow when computing char to be passed to 'error'. Do not
3114 pass Lisp_Object to 'error'; pass the integer instead.
3115 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3116 formatted with plain %d.
3117
b189fa66
PE
3118 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3119
bff87ef0
PE
3120 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3121
7e2cac20
PE
3122 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3123
ce4d90b5
PE
3124 * xterm.c (x_catch_errors): Remove duplicate declaration.
3125
266c9547
PE
3126 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3127
79c49ad2
PE
3128 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3129
368f4090
JM
31302011-04-10 Jim Meyering <meyering@redhat.com>
3131
3132 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3133 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3134 return ssize_t not "int", and use size_t as the buffer length.
3135 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3136 * gnutls.h: Update declarations.
3137 * process.c (read_process_output): Use ssize_t, to match.
3138 (send_process): Likewise.
3139
a32d4040
CY
31402011-04-09 Chong Yidong <cyd@stupidchicken.com>
3141
3142 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3143
8546720e 31442011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3145
04f2d78b
CB
3146 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3147 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3148
8546720e
GM
3149 * xterm.c (handle_one_xevent):
3150 * xmenu.c (create_and_show_popup_menu):
3151 * xselect.c (x_decline_selection_request)
3152 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3153
0a2f5c1a 31542011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3155
3156 Fix some uses of `int' instead of EMACS_INT.
3157 * search.c (string_match_1, fast_string_match)
3158 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3159 (scan_buffer, find_next_newline_no_quit)
3160 (find_before_next_newline, search_command, Freplace_match)
3161 (Fmatch_data): Make some `int' variables be EMACS_INT.
3162
3163 * xdisp.c (display_count_lines): 3rd argument and return value now
3164 EMACS_INT. All callers changed.
3165 (pint2hrstr): Last argument is now EMACS_INT.
3166
3167 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3168 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3169 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3170 (decode_coding_utf_16, decode_coding_emacs_mule)
3171 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3172 (decode_coding_ccl, decode_coding_charset)
3173 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3174 (decode_coding_iso_2022, decode_coding_emacs_mule)
3175 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3176 <char_offset, last_offset>: Declare EMACS_INT.
3177 (encode_coding_utf_8, encode_coding_utf_16)
3178 (encode_coding_emacs_mule, encode_invocation_designation)
3179 (encode_designation_at_bol, encode_coding_iso_2022)
3180 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3181 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3182 Declare EMACS_INT.
3183 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3184 (encode_invocation_designation): Last argument P_NCHARS is now
3185 EMACS_INT.
3186 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3187 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3188
3189 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3190 All users changed.
3191
3192 * ccl.c (Fccl_execute_on_string): Declare some variables
3193 EMACS_INT.
3194
8546720e 31952011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3196
3197 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3198
4e19a977
CS
31992011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3200
3201 * process.c (Fformat_network_address): Doc fix.
3202
87302331
R
32032011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3204
3205 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3206
cbb59342
CY
32072011-04-08 Chong Yidong <cyd@stupidchicken.com>
3208
3209 * keyboard.c (read_char): Call Lisp function help-form-show,
3210 instead of using internal_with_output_to_temp_buffer.
3211 (Qhelp_form_show): New var.
e0d38eeb 3212 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3213
3214 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3215
3216 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3217
e67a13ab
CY
32182011-04-06 Chong Yidong <cyd@stupidchicken.com>
3219
04f2d78b
CB
3220 * process.c (Flist_processes): Remove to Lisp.
3221 (list_processes_1): Delete.
e67a13ab 3222
973f782d
EZ
32232011-04-06 Eli Zaretskii <eliz@gnu.org>
3224
7c106b1e
EZ
3225 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3226
973f782d
EZ
3227 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3228
41cf7d1a 32292011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3230
ca23cc88
PE
3231 Fix more problems found by GCC 4.6.0's static checks.
3232
f390e2d5
PE
3233 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3234
42eea0d0
PE
3235 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3236
b69769da 3237 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3238
f9541e84
PE
3239 * xdisp.c (vmessage): Mark as a printf-like function.
3240
13841b55
PE
3241 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3242
c136c10f
PE
3243 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3244
5e2d4a30
PE
3245 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3246 printf-like functions.
3247 (tiff_load): Add casts to remove these marks before passing them
3248 to system-supplied API.
3249
583f48b9
PE
3250 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3251
b25d760e
PE
3252 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3253 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3254 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3255 directly, rather than having caller test rule sign. This avoids
3256 some unnecessary tests.
3257 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3258 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3259 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3260
bc7b6697 3261 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3262 (xfont_open): Avoid unnecessary tests.
bc7b6697 3263
27ccc379
PE
3264 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3265
dcd5c89a
PE
3266 * composite.h, composite.c (composition_gstring_put_cache):
3267 Use EMACS_INT, not int, for length.
3268
b13a45c6
PE
3269 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3270 breaking out part of COMPOSITION_DECODE_RULE.
3271 (COMPOSITION_DECODE_RULE): Use it.
3272 * composite.c (get_composition_id): Remove unused local vars,
3273 by using the new macro.
3274
1e792e4d
PE
3275 * textprop.c (set_text_properties_1): Change while to do-while,
3276 since the condition is always true at first.
3277
dc6c6455 3278 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3279 (interval_deletion_adjustment): Return unsigned value.
3280 All uses changed.
dc6c6455 3281
aba7731a
PE
3282 * process.c (list_processes_1, create_pty, read_process_output):
3283 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3284 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3285 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3286 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3287 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3288
fdfc4bf3
PE
3289 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3290
fca8fe46 3291 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3292 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3293
06a0259a 3294 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3295 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3296 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3297
e7b9e80f
PE
3298 * print.c (print_error_message): Avoid int overflow.
3299
56201685
PE
3300 * font.c (font_list_entities): Redo for clarity,
3301 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3302
78834453 3303 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3304 (font_score): Avoid potential overflow in diff calculation.
78834453 3305
0bc0b309 3306 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3307 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3308
e610eaca
PE
3309 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3310
b895abce
PE
3311 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3312 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3313 can always succeed if overflow has undefined behavior.
3314
1f1d9321 3315 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3316 (wordify): Omit three unnecessary tests.
1f1d9321 3317
c59478bc
PE
3318 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3319 All callers changed. This avoids the need for an unused var.
3320
79b73827
PE
3321 * casefiddle.c (casify_region): Remove var that is set but not used.
3322
a4db5dfe
PE
3323 * dired.c (file_name_completion): Remove var that is set but not used.
3324
43aae36e
PE
3325 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3326
2a47c44d 3327 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3328 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3329
a37c69bf
PE
3330 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3331 Check for integer overflow on size calculations.
3332
328ab8e7
PE
3333 * buffer.c (Fprevious_overlay_change): Remove var that is set
3334 but not used.
3335
e5a2a5cb
PE
3336 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3337 Remove vars that are set but not used.
8d84a6eb 3338 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3339 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3340
a60e5f68
PE
3341 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3342
f661cb61 3343 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3344 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3345
f0397f5a
PE
3346 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3347 that are set but not used.
3348
8664db06 3349 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3350 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3351
6abdaa4a
PE
3352 * xselect.c (x_get_local_selection, x_handle_property_notify):
3353 Remove vars that are set but not used.
3354
0ce7538d 3355 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3356 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3357
9ae848fc
PE
3358 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3359 Remove var that is set but not used.
0b918413
PE
3360 (scroll_bar_windows_size): Now size_t, not int.
3361 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3362 Check for overflow.
9ae848fc 3363
a5a62657
PE
3364 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3365 (map_tty_color) [!defined MSDOS]: Likewise.
3366
5c5cdd39
PE
3367 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3368
66ebf983
PE
3369 * coding.c: Remove vars that are set but not used.
3370 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3371 All callers changed.
3372 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3373 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3374 (decode_coding_charset): Remove vars that are set but not used.
3375
1be4d761
PE
3376 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3377 that is set but not used.
3378
47553fa8
PE
3379 * print.c (print_object): Remove var that is set but not used.
3380
1f7196bf 3381 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3382 The gnulib version avoids calling malloc in the usual case,
3383 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3384 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3385 * filelock.c (current_lock_owner): Likewise.
3386 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3387 * sysdep.c: Include allocator.h, careadlinkat.h.
3388 (emacs_no_realloc_allocator): New static constant.
3389 (emacs_readlink): New function.
fdb61804
PE
3390 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3391 ../lib/careadlinkat.h.
d1fdcab7 3392
f84c17c7
SM
33932011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3394
3395 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3396 first non-nil return value).
3397
ef3862ad
JD
33982011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3399
3400 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3401 if not defined (Bug#8403).
3402
376a7006
JB
34032011-04-02 Juanma Barranquero <lekktu@gmail.com>
3404
3405 * xdisp.c (display_count_lines): Remove parameter `start',
3406 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3407 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3408 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3409 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3410 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3411 and thereabouts. All callers changed.
3412 (get_per_char_metric): Remove parameter `f', unused since
3413 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3414
6ca3801d
JM
34152011-04-02 Jim Meyering <meyering@redhat.com>
3416
3417 do not dereference NULL upon failed strdup
3418 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3419 (ns_get_family): Likewise.
3420
d8e2b5ba
JB
34212011-04-02 Juanma Barranquero <lekktu@gmail.com>
3422
3423 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3424
8c74fcbd
JD
34252011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3426
3427 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3428 later (Bug#8403).
3429
7200d79c
SM
34302011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3431
03408648 3432 Add lexical binding.
7200d79c 3433
03408648
SM
3434 * window.c (Ftemp_output_buffer_show): New fun.
3435 (Fsave_window_excursion):
3436 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3437
3438 * lread.c (lisp_file_lexically_bound_p): New function.
3439 (Fload): Bind Qlexical_binding.
3440 (readevalloop): Remove `evalfun' arg.
3441 Bind Qinternal_interpreter_environment.
3442 (Feval_buffer): Bind Qlexical_binding.
3443 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3444 Mark as dynamic.
3445 (syms_of_lread): Declare `lexical-binding'.
3446
3447 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3448
3449 * keyboard.c (eval_dyn): New fun.
3450 (menu_item_eval_property): Use it.
ca105506
SM
3451
3452 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3453
03408648
SM
3454 * fns.c (concat, mapcar1): Accept byte-code-functions.
3455
3456 * eval.c (Fsetq): Handle lexical vars.
3457 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3458 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3459 (FletX, Flet): Obey lexical binding.
3460 (Fcommandp): Handle closures.
3461 (Feval): New `lexical' arg.
3462 (eval_sub): New function extracted from Feval. Use it almost
3463 everywhere where Feval was used. Look up vars in lexical env.
3464 Handle closures.
3465 (Ffunctionp): Move from subr.el.
3466 (Ffuncall): Handle closures.
3467 (apply_lambda): Remove `eval_flags'.
3468 (funcall_lambda): Handle closures and new byte-code-functions.
3469 (Fspecial_variable_p): New function.
3470 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3471 but without exporting it to Lisp.
23aba0ea 3472
23aba0ea 3473 * doc.c (Fdocumentation, store_function_docstring):
03408648 3474 * data.c (Finteractive_form): Handle closures.
23aba0ea 3475
03408648
SM
3476 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3477 interactive spec.
ba83908c 3478
04f2d78b
CB
3479 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3480 New byte-codes.
03408648
SM
3481 (exec_byte_code): New function extracted from Fbyte_code to handle new
3482 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3483
03408648 3484 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3485
03408648 3486 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3487
e2abce01
JB
34882011-03-31 Juanma Barranquero <lekktu@gmail.com>
3489
3490 * xdisp.c (redisplay_internal): Fix prototype.
3491
63696a73 34922011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3493
63696a73 3494 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3495 (try_scrolling): Use it when setting scroll_limit.
3496 Limit scrolling to 100 screen lines.
63696a73
EZ
3497 (redisplay_window): Even when falling back on "recentering",
3498 position point in the window according to scroll-conservatively,
3499 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3500
3501 (try_scrolling): When point is above the window, allow searching
3502 as far as scroll_max, or one screenful, to compute vertical
3503 distance from PT to the scroll margin position. This prevents
3504 try_scrolling from unnecessarily failing when
3505 scroll-conservatively is set to a value slightly larger than the
3506 window height. Clean up the case of PT below the margin at bottom
3507 of window: scroll_max can no longer be INT_MAX. When aggressive
3508 scrolling is in use, don't let point enter the opposite scroll
3509 margin as result of the scroll.
3510 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3511 threshold of 100 lines for never-recentering scrolling.
3512
e4cc2dfc
JB
35132011-03-31 Juanma Barranquero <lekktu@gmail.com>
3514
3515 * dispextern.h (move_it_by_lines):
3516 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3517 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3518 (message_log_check_duplicate): Remove parameters `prev_bol' and
3519 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3520 (redisplay_internal): Remove parameter `preserve_echo_area',
3521 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3522
3523 * indent.c (Fvertical_motion):
3524 * window.c (window_scroll_pixel_based, Frecenter):
3525 Don't pass `need_y_p' to `move_it_by_lines'.
3526
1c470562
SM
35272011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3528
44f230aa
SM
3529 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3530 steal a few bits to be more compact.
3531 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3532 Remove unneeded casts.
3533
1c470562
SM
3534 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3535
888adce9
ZK
35362011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3537
3538 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3539 binding" message (bug#7967).
3540
f838ed7b
PE
35412011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3542
77861b95
PE
3543 Fix more problems found by GCC 4.6.0's static checks.
3544
de6dbc14
PE
3545 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3546 Remove unused local var.
3547
f838ed7b
PE
3548 * editfns.c (Fmessage_box): Remove unused local var.
3549
792c7b2b
PE
3550 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3551 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3552 Omit unused local vars.
c499e557 3553 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3554 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3555 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3556 Omit unused local var.
3557
ba0165e1
PE
3558 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3559 Don't assume string length fits in int.
32ad8845 3560 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3561 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3562
3c59b4c9
PE
3563 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3564 instead of alloca (Bug#8344).
3565
a3eed478 3566 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3567 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3568
eb4d412d
PE
3569 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3570
1658b401
PE
3571 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3572 concerns.
3573
3574 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3575
3576 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3577
9a2c6e05
PE
3578 * keyboard.c (syms_of_keyboard): Use the same style as later
3579 in this function when indexing through an array. This also
3580 works around GCC bug 48267.
3581
03d0a109
PE
3582 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3583
44f730c8
PE
3584 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3585
fe75f926
PE
3586 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3587 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3588
ffa8c828
PE
3589 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3590 This avoids undefined behavior on integer overflow, and is a bit
3591 more convenient anyway since it is compared to a size_t variable.
3592
c5101a77
PE
3593 Variadic C functions now count arguments with size_t, not int.
3594 This avoids an unnecessary limitation on 64-bit machines, which
3595 caused (substring ...) to crash on large vectors (Bug#8344).
3596 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3597 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3598 All variadic functions and their callers changed accordingly.
c5101a77
PE
3599 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3600 * data.c (arith_driver, float_arith_driver): Likewise.
3601 * editfns.c (general_insert_function): Likewise.
3602 * eval.c (struct backtrace.nargs, interactive_p)
3603 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3604 (funcall_lambda, mark_backtrace): Likewise.
3605 * fns.c (concat): Likewise.
3606 * frame.c (x_set_frame_parameters): Likewise.
3607 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3608 0 if not found, not -1. All callers changed.
3609
dd3f25f7
PE
3610 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3611 (stack_copy_size): Now size_t, not int.
3612 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3613
461c2ab9
JB
36142011-03-28 Juanma Barranquero <lekktu@gmail.com>
3615
3616 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3617 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3618 All callers changed.
3619
3620 * lisp.h (multibyte_char_to_unibyte):
3621 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3622 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3623 * character.h (CHAR_TO_BYTE8):
3624 * cmds.c (internal_self_insert):
3625 * editfns.c (general_insert_function):
3626 * keymap.c (push_key_description):
3627 * search.c (Freplace_match):
3628 * xdisp.c (message_dolog, set_message_1): All callers changed.
3629
f6d62986
SM
36302011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3631
3632 * keyboard.c (safe_run_hook_funcall): New function.
3633 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3634 don't set the hook to nil, but remove the offending function instead.
3635 (Qcommand_hook_internal): Remove, unused.
3636 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3637 Vcommand_hook_internal.
3638
3639 * eval.c (enum run_hooks_condition): Remove.
3640 (funcall_nil, funcall_not): New functions.
3641 (run_hook_with_args): Call each function through a `funcall' argument.
3642 Remove `cond' argument, now redundant.
3643 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3644 (Frun_hook_with_args_until_failure): Adjust accordingly.
3645 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3646
1db5b1ad
JB
36472011-03-28 Juanma Barranquero <lekktu@gmail.com>
3648
3649 * dispextern.h (string_buffer_position): Remove declaration.
3650
3651 * print.c (strout): Remove parameter `multibyte', unused since
3652 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3653
3654 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3655 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3656 All callers changed.
3657
3658 * w32.c (_wsa_errlist): Use braces for struct initializers.
3659
3660 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3661 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3662 All callers changed.
3663 (string_buffer_position): Likewise. Also, make static (it's never
3664 used outside xdisp.c).
3665 (cursor_row_p): Remove parameter `w', unused since
3666 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3667 (decode_mode_spec): Remove parameter `precision', introduced during
3668 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3669 All callers changed.
3670
5ffb62aa
JD
36712011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3672
3673 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3674
461c2ab9 36752011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3676
3677 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3678 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3679 (ns_update_auto_hide_menu_bar): New functions.
3680 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3681 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3682 ns_constrain_all_frames.
3683 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3684 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3685
5c380ffb
JD
36862011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3687
3688 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3689
9af30bdf
GM
36902011-03-27 Glenn Morris <rgm@gnu.org>
3691
3692 * syssignal.h: Replace RETSIGTYPE with void.
3693 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3694 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3695 Replace SIGTYPE with void everywhere.
3696 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3697 * s/template.h (SIGTYPE): Remove commented out definition.
3698
e2abce01
JB
36992011-03-26 Eli Zaretskii <eliz@gnu.org>
3700
3701 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3702 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3703
f868cd8a
JB
37042011-03-26 Juanma Barranquero <lekktu@gmail.com>
3705
59eb0929
JB
3706 * w32.c (read_unc_volume): Use parameter `henum', instead of
3707 global variable `wget_enum_handle'.
3708
3709 * keymap.c (describe_vector): Remove parameters `indices' and
3710 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3711 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3712
f868cd8a
JB
3713 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3714
3715 * keyboard.c (timer_check): Remove parameter `do_it_now',
3716 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3717 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3718 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3719
3720 * keyboard.c (read_char):
3721 * w32menu.c (w32_menu_display_help):
3722 * xmenu.c (show_help_event, menu_help_callback):
3723 Adjust calls to `show_help_echo'.
3724
3725 * gtkutil.c (xg_maybe_add_timer):
3726 * keyboard.c (readable_events):
3727 * process.c (wait_reading_process_output):
3728 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3729
3730 * insdel.c (adjust_markers_gap_motion):
3731 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3732 (gap_left, gap_right): Don't call it.
3733
2ecf6fdb
CY
37342011-03-25 Chong Yidong <cyd@stupidchicken.com>
3735
3736 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3737 incurred during fontification.
3738
6b1f9ba4
JB
37392011-03-25 Juanma Barranquero <lekktu@gmail.com>
3740
3741 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3742 (DEFVAR_PER_BUFFER): Don't pass it.
3743
3744 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3745 (scrolling_window): Don't pass it.
3746
0f4a96b5
JB
37472011-03-25 Juanma Barranquero <lekktu@gmail.com>
3748
3749 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3750
3751 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3752 and `suffix'.
3753 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3754 of variables specific to SELinux and computation of `encoded_absname'.
3755
3756 * image.c (XPutPixel): Remove unused variable `height'.
3757
3758 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3759
3760 * unexw32.c (get_section_info): Remove unused variable `section'.
3761
3762 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3763 (system_process_attributes): Remove unused variable `sess'.
3764 (sys_read): Remove unused variable `err'.
3765
3766 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3767 (w32_wnd_proc): Remove unused variable `isdead'.
3768 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3769 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3770 (x_create_tip_frame): Remove unused variable `tem'.
3771
3772 * w32inevt.c (w32_console_read_socket):
3773 Remove unused variable `no_events'.
3774
3775 * w32term.c (x_draw_composite_glyph_string_foreground):
3776 Remove unused variable `width'.
3777
1149507c
JB
37782011-03-24 Juanma Barranquero <lekktu@gmail.com>
3779
3780 * w32term.c (x_set_glyph_string_clipping):
3781 Don't pass uninitialized region to CombineRgn.
3782
9c88f339
JB
37832011-03-23 Juanma Barranquero <lekktu@gmail.com>
3784
3785 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3786 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3787 (Fx_close_connection): Remove unused variable `i'.
3788
3789 * w32font.c (w32font_draw): Return number of glyphs.
3790 (w32font_open_internal): Remove unused variable `i'.
3791 (w32font_driver): Add missing initializer.
3792
3793 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3794 (fill_in_menu): Remove unused variable `items_added'.
3795
3796 * w32term.c (last_mouse_press_frame): Remove static global variable.
3797 (w32_clip_to_row): Remove unused variable `f'.
3798 (x_delete_terminal): Remove unused variable `i'.
3799
3800 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3801 (NOTHING): Remove unused static global variable.
3802 (uniscribe_check_otf): Remove unused variable `table'.
3803 (uniscribe_font_driver): Add missing initializers.
3804
dee091a3
JD
38052011-03-23 Julien Danjou <julien@danjou.info>
3806
3807 * term.c (Fsuspend_tty, Fresume_tty):
3808 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3809 * window.c (temp_output_buffer_show):
3810 * insdel.c (signal_before_change):
3811 * frame.c (Fhandle_switch_frame):
3812 * fileio.c (Fdo_auto_save):
3813 * emacs.c (Fkill_emacs):
3814 * editfns.c (save_excursion_restore):
3815 * cmds.c (internal_self_insert):
3816 * callint.c (Fcall_interactively):
3817 * buffer.c (Fkill_all_local_variables):
3818 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3819 Use Frun_hooks.
0f4a96b5 3820 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3821 unconditionnaly since it does the check itself.
3822
2c520ab5 38232011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3824
c9c49752
PE
3825 Fix more problems found by GCC 4.5.2's static checks.
3826
8abc3f12
PE
3827 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3828 the first time through the loop, since we know p0 < p1 then.
3829 This also avoids a gcc -Wstrict-overflow warning.
3830
a2d26660
PE
3831 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3832 leading to a memory leak, possible in functions like
3833 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3834 of objects (Bug#8318).
a2d26660 3835
916c72e9
PE
3836 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3837 that could (at least in theory) be that large.
3838
19ab8a18
PE
3839 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3840 This is less likely to overflow, and avoids undefined behavior if
3841 overflow does occur. All callers changed. Use strtoul to scan
3842 for the unsigned long integer.
b7cbbd6f
PE
3843 (pint2hrstr): Simplify and tune code slightly.
3844 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3845
f0641eff
PE
3846 * scroll.c (do_scrolling): Work around GCC bug 48228.
3847 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3848
7f650bb9
PE
3849 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3850 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3851 (validate_x_resource_name): Simplify count usage.
3852 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3853
37dd57d1
PE
3854 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3855 fail (Bug#8306).
81e56e61 3856
699979fc 3857 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3858
401bf9b4
PE
3859 * process.c (Fmake_network_process): Use socklen_t, not int,
3860 where POSIX says socklen_t is required in portable programs.
3861 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3862 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3863 (Fmake_network_process, server_accept_connection):
3864 (wait_reading_process_output, read_process_output):
3865 Likewise.
3866
b93aacde
PE
3867 * process.c: Rename or move locals to avoid shadowing.
3868 (list_processes_1, Fmake_network_process):
3869 (read_process_output_error_handler, exec_sentinel_error_handler):
3870 Rename or move locals.
4dc343ee 3871 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3872 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3873 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3874 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3875 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3876
af8a867c 3877 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3878 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3879 Include tparam.h instead, since it declares them.
af8a867c
PE
3880 * cm.h (PC): Remove extern decl; tparam.h now does this.
3881 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3882 * terminfo.c: Include tparam.h, to check interfaces.
3883 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3884 (tparam): Adjust signature to match interface in tparam.h;
3885 this removes some undefined behavior. Check that outstring and len
3886 are zero, which they always are with Emacs.
3887 * tparam.h (PC, BC, UP): New extern decls.
3888
0248044d 3889 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3890 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3891
8ff096c1 3892 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3893 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3894 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3895 (ftfont_list): Remove unused local.
49eaafba
PE
3896 (get_adstyle_property, ftfont_pattern_entity):
3897 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3898 Rename locals to avoid shadowing.
8ff096c1 3899
e2be39f6
PE
3900 * xfont.c (xfont_list_family): Mark var as initialized.
3901
c9735e30
PE
3902 * xml.c (make_dom): Now static.
3903
8f5201ae
PE
3904 * composite.c (composition_compute_stop_pos): Rename local to
3905 avoid shadowing.
b246f932
PE
3906 (composition_reseat_it): Remove unused locals.
3907 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3908 (composition_update_it): Mark var as initialized.
11b61122
PE
3909 (find_automatic_composition): Mark vars as initialized,
3910 with a FIXME (Bug#8290).
8f5201ae 3911
760fbc2c
PE
3912 character.h: Rename locals to avoid shadowing.
3913 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3914 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3915 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3916 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3917 to avoid shadowing.
3918
ff08eb85
PE
3919 * textprop.c (property_change_between_p): Remove; unused.
3920
fc7bf025
PE
3921 * intervals.c (interval_start_pos): Now static.
3922
235d7abc
PE
3923 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3924
44f230aa
SM
3925 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3926 Rename locals to avoid shadowing.
3e7d6594 3927
50060332
PE
3928 * sound.c (wav_play, au_play, Fplay_sound_internal):
3929 Fix pointer signedness.
d01f234b 3930 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3931 (wav_play): Initialize a variable to 0, to prevent undefined
3932 behavior (Bug#8278).
50060332 3933
c4fc4e30
PE
3934 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3935
918436ed
PE
3936 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3937
c939f91b
PE
3938 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3939 clobbering (Bug#8298).
b9c7f648
PE
3940 * sysdep.c (sys_subshell): Likewise.
3941 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3942
6bd8c144
PE
3943 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3944 This should get cleaned up, so that child_setup has the
3945 same signature on all platforms.
3946
7710357c 3947 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3948 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3949
c59da222
CY
39502011-03-22 Chong Yidong <cyd@stupidchicken.com>
3951
3952 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3953 not to be necessary, and produces flickering.
3954
66b87493
GM
39552011-03-20 Glenn Morris <rgm@gnu.org>
3956
3957 * config.in: Remove file.
3958
45b6f6d5
JB
39592011-03-20 Juanma Barranquero <lekktu@gmail.com>
3960
3961 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3962 are now in src/globals.h.
3963 (syms_of_minibuf): Remove spurious & from previous change.
3964
3ec03f7e
LL
39652011-03-20 Leo <sdl.web@gmail.com>
3966
3967 * minibuf.c (completing-read-function): New variable.
3968 (completing-read-default): Rename from completing-read.
3969 (completing-read): Call completing-read-function.
3970
b14e3e21
CY
39712011-03-19 Juanma Barranquero <lekktu@gmail.com>
3972
3973 * xfaces.c (Fx_load_color_file):
3974 Read color file from absolute filename (bug#8250).
3975
f2b726e6
JB
39762011-03-19 Juanma Barranquero <lekktu@gmail.com>
3977
3978 * makefile.w32-in: Update dependencies.
3979
09f6ff02
EZ
39802011-03-17 Eli Zaretskii <eliz@gnu.org>
3981
3982 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3983
29a6015a
PE
39842011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3985
a3a6c54e
PE
3986 Fix more problems found by GCC 4.5.2's static checks.
3987
b766f867
PE
3988 * process.c (make_serial_process_unwind, send_process_trap):
3989 (sigchld_handler): Now static.
3990
be02381c
PE
3991 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3992 That way, the code declares only the vars that it needs.
3993 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3994 * s/cygwin.h (PTY_ITERATION): Likewise.
3995 * s/darwin.h (PTY_ITERATION): Likewise.
3996 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3997
57048744
PE
3998 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3999 * process.c (allocate_pty): Don't declare stb unless it's needed.
4000
7914961c 4001 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4002 (CONSTANTLIM): Remove; unused.
4003 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4004 Define only if needed.
7914961c 4005
b3967b18
PE
4006 * unexelf.c (unexec): Name an expression,
4007 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4008 Use a different way to cause a compilation error if anyone uses
4009 n rather than nn, a way that does not involve shadowing.
73366a00 4010 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4011
29a6015a
PE
4012 * deps.mk (unexalpha.o): Remove; unused.
4013
43cfc33e 4014 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4015 * unexec.h: New file.
ce701a33
PE
4016 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4017 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4018 Depend on unexec.h.
4019 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4020 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4021 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4022 Change as necessary to match prototype in unexec.h.
ce701a33 4023
01f44d5a
PE
4024 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4025 shadowing.
4f63c6bb 4026 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4027
a6670b0b
PE
4028 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4029 Rename locals to avoid shadowing.
4030
cef2010d 4031 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4032 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4033
d4d7173a
PE
4034 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4035
f08b802a
PE
4036 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4037 warning when compiling print.c.
4038
3ddb0639
PE
4039 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4040 instead of using an uninitialized var.
5ad03b97 4041 (font_sort_entities): Mark var as initialized.
3ddb0639 4042
170a2692
PE
4043 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4044
e663c700
PE
4045 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4046 pointers to constants.
89bc529a 4047 (font_parse_fcname): Remove unused vars.
7b81e2d0 4048 (font_delete_unmatched): Now static.
ea838e10 4049 (font_get_spec): Remove; unused.
13a547c6
PE
4050 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4051 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4052 Rename or move locals to avoid shadowing.
e663c700 4053
2a80c887 4054 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4055 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4056
1384fa33 4057 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4058 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4059
8b2c52e9
PE
4060 * alloc.c (mark_backtrace): Move decl from here ...
4061 * lisp.h: ... to here, so that it can be checked.
4062
475545b5 4063 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4064 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4065 (lisp_indirect_variable): Name an expression,
4066 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4067 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4068
b1349114 4069 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4070 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4071 Use const pointer when appropriate.
b1349114 4072
a2928364
PE
4073 * lisp.h (get_system_name, get_operating_system_release):
4074 Move decls here, to check interfaces.
4075 * process.c (get_operating_system_release): Move decl to lisp.h.
4076 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4077 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4078 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4079 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4080 (Fformat_time_string, Fencode_time, Finsert_char):
4081 (Ftranslate_region_internal, Fformat):
4082 Rename or remove local vars to avoid shadowing.
9710023e 4083 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4084
a415e694
PE
4085 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4086 avoid shadowing.
4087
8ef4622d
PE
4088 * lisp.h (eassert): Check that the argument compiles, even if
4089 ENABLE_CHECKING is not defined.
4090
946f9a5b
PE
4091 * data.c (Findirect_variable): Name an expression, to avoid
4092 gcc -Wbad-function-cast warning.
112396d6 4093 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4094 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4095 (Fmake_variable_buffer_local, Fmake_local_variable):
4096 Mark variables as initialized.
52746918 4097 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4098
e5aab7e7 4099 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4100 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4101 Rename locals to avoid shadowing.
dff45157
PE
4102 (mark_stack): Move local variables into the #ifdef region where
4103 they're used.
7bc26fdb
PE
4104 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4105 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4106 needed otherwise.
4107 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4108 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4109 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4110
e5aab7e7
PE
4111 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4112 avoids undefined behavior in theory.
4113
4da60324
PE
4114 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4115
88043301
PE
4116 Use functions, not macros, for up- and down-casing (Bug#8254).
4117 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4118 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4119 to use the following functions instead of these macros.
4120 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4121 EMACS_INT, since callers assume the returned value fits in int.
4122 (upcase1): Likewise, for UPCASE_TABLE.
4123 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4124 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4125 the race-condition problem in the old DOWNCASE.
88043301 4126
19ed5445
PE
4127 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4128 Rename locals to avoid shadowing.
4129 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4130 (regex_compile, re_search_2, re_match_2_internal):
4131 Remove unused local vars.
952db0d7
PE
4132 (FREE_VAR): Rewrite so as not to use empty "else",
4133 which gcc can warn about.
da053e48 4134 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4135 (RETALLOC_IF): Define only if needed.
4136 (WORDCHAR_P): Likewise. This one is never needed, but is used
4137 only in a comment talking about a compiler bug, so put inside
4138 the #if 0 of that comment.
4139 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4140 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4141 Remove; unused.
19ed5445 4142
1f3561e4 4143 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4144 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4145 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4146
ded6f8f7
PE
4147 * search.c (simple_search): Remove unused var.
4148
dbd37a95
PE
4149 * dired.c (compile_pattern): Move decl from here ...
4150 * lisp.h: ... to here, so that it can be checked.
4151 (struct re_registers): New forward decl.
4152
7e47afad
PE
4153 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4154
85f24f61
PE
4155 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4156 All uses changed.
4157 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4158 Rename locals to avoid shadowing.
5671df8f 4159 (Fvertical_motion): Mark locals as initialized.
85f24f61 4160
181aa2be 4161 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4162 (casify_region): Mark local as initialized.
181aa2be 4163
930d429c
PE
4164 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4165
7082eac6
PE
4166 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4167 New macros, so that the caller can use some names other than
4168 gcpro1, gcpro2, etc.
4169 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4170 of the new macros.
4171 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4172 argument, for consistency with GCPRO2_VAR, etc: it is now the
4173 prefix of the variable, not the variable itself. All uses
4174 changed.
38b2c076
PE
4175 * dired.c (directory_files_internal, file_name_completion):
4176 Rename locals to avoid shadowing.
4177
15206ed9
PE
4178 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4179 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4180 dired.c's scmp function, had undefined behavior.
4181 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4182 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4183 * buffer.h: ... to here, because these macros use current_buffer,
4184 and the new implementation with inline functions needs to have
4185 current_buffer in scope now, rather than later when the macros
4186 are used.
4187 (downcase, upcase1): New static inline functions.
4188 (DOWNCASE, UPCASE1): Reimplement using these functions.
4189 This avoids undefined behavior in expressions like
4190 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4191 from race conditions in accessing the global variables
4192 case_temp1 and case_temp2.
4193 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4194 * lisp.h (case_temp1, case_temp2): Remove their decls.
4195 * character.h (ASCII_CHAR_P): Move from here ...
4196 * lisp.h: ... to here, so that the inline functions mentioned
4197 above can use them.
4198
4a6bea26
PE
4199 * dired.c (directory_files_internal_unwind): Now static.
4200
f14b7e14
PE
4201 * fileio.c (file_name_as_directory, directory_file_name):
4202 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4203 Now static.
2893f146
PE
4204 (file_name_as_directory): Use const pointers when appropriate.
4205 (Fexpand_file_name): Likewise. In particular, newdir might
4206 point at constant storage, so make it a const pointer.
fd4ead52 4207 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4208 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4209 signedness issues.
f839df0c
PE
4210 (Fset_file_times, Finsert_file_contents, auto_save_error):
4211 Rename locals to avoid shadowing.
f14b7e14 4212
5716756e 4213 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4214 (Ftry_completion, Fall_completions): Rename or remove locals
4215 to avoid shadowing.
5716756e 4216
b4c3046a
PE
4217 * marker.c (bytepos_to_charpos): Remove; unused.
4218
b45db522
PE
4219 * lisp.h (verify_bytepos, count_markers): New decls,
4220 so that gcc does not warn that these functions aren't declared.
4221
85876d07
PE
4222 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4223 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4224 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4225 (copy_text): Remove unused local var.
85876d07 4226
03d78a21 4227 * filelock.c (within_one_second): Now static.
b3dd38ab 4228 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4229
5df8f01b
PE
4230 * buffer.c (fix_overlays_before): Mark locals as initialized.
4231 (fix_start_end_in_overlays): Likewise. This function should be
4232 simplified by using pointers-to-pointers, but that's a different
4233 matter.
b1d876f1 4234 (switch_to_buffer_1): Now static.
8f54f30a
PE
4235 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4236 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4237
a70072c9 4238 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4239 Fix pointer signedness issue.
edced198
PE
4240 (sys_subshell): Mark local as volatile if checking for lint,
4241 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4242 (MAXPATHLEN): Define only if needed.
a70072c9 4243
a0977c44
PE
4244 * process.c (serial_open, serial_configure): Move decls from here ...
4245 * systty.h: ... to here, so that they can be checked.
4246
a884fdcc
PE
4247 * fns.c (get_random, seed_random): Move extern decls from here ...
4248 * lisp.h: ... to here, so that they can be checked.
4249
604efe86 4250 * sysdep.c (reset_io): Now static.
b8950c94 4251 (wait_for_termination_signal): Remove; unused.
604efe86 4252
38fc62d9
PE
4253 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4254 (copy_keymap_item, append_key, push_text_char_description):
4255 Now static.
1004a21a 4256 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4257 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4258 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4259 (describe_map_tree):
4260 Rename locals to avoid shadowing.
38fc62d9 4261
2f2650da
PE
4262 * keyboard.c: Declare functions static if they are not used elsewhere.
4263 (echo_char, echo_dash, cmd_error, top_level_2):
4264 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4265 (read_char, kbd_buffer_get_event, make_lispy_position):
4266 (make_lispy_event, make_lispy_movement, apply_modifiers):
4267 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4268 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4269 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4270 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4271 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4272
a053e86c 4273 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4274 (mark_kboards): Move decl here ...
4275 * alloc.c (mark_kboards): ... from here.
a053e86c 4276
4752793e
PE
4277 * lisp.h (force_auto_save_soon): New decl.
4278
74f10ca7 4279 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4280 (DEFINE_DUMMY_FUNCTION): New macro.
4281 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4282 Use it.
c03cd23f
PE
4283 (main): Add casts to avoid warnings
4284 if GCC considers string literals to be constants.
74f10ca7 4285
022e70d4
PE
4286 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4287
59d6fe83
PE
4288 * dbusbind.c: Pointer signedness fixes.
4289 (xd_signature, xd_append_arg, xd_initialize):
4290 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4291 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4292 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4293 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4294
78320123
PE
4295 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4296 if GCC considers string literals to be constants.
49cebcca 4297 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4298
35ac2a97
SM
42992011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4300
fb103ca9
SM
4301 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4302 (print_preprocess, print_object): New macro to fix last change.
4303
35ac2a97
SM
4304 * print.c (print_preprocess): Don't forget font objects.
4305
62973b41
JB
43062011-03-16 Juanma Barranquero <lekktu@gmail.com>
4307
4308 * emacs.c (USAGE3): Doc fixes.
4309
0e48bb22
AS
43102011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4311
4312 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4313 structure.
4314
7684e57b
JB
43152011-03-14 Juanma Barranquero <lekktu@gmail.com>
4316
4317 * lisp.h (VWindow_system, Qfile_name_history):
4318 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4319 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4320 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4321
4322 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4323 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4324
4325 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4326 * w32console.c (detect_input_pending, read_input_pending)
4327 (encode_terminal_code):
4328 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4329 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4330 (w32_system_caret_y, Qfile_name_history):
4331 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4332 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4333 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4334 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4335 * w32proc.c (Qlocal, report_file_error):
4336 * w32term.c (Vwindow_system, updating_frame):
4337 * w32uniscribe.c (initialized, uniscribe_font_driver):
4338 Remove unneeded extern declarations.
4339
2aa46d6c
CY
43402011-03-14 Chong Yidong <cyd@stupidchicken.com>
4341
c96bbc66 4342 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4343
cffc6f3b
CY
43442011-03-13 Chong Yidong <cyd@stupidchicken.com>
4345
4346 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4347 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4348 These macros can no longer be used for assignment.
4349
44f230aa
SM
4350 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4351 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4352 (record_buffer_markers, fetch_buffer_markers): New functions for
4353 recording and fetching special buffer markers.
4354 (set_buffer_internal_1, set_buffer_temp): Use them.
4355
4356 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4357
4358 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4359
4360 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4361 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4362
4363 * xdisp.c (hscroll_window_tree):
4364 (reconsider_clip_changes): Use PT instead of BUF_PT.
4365
d251f04b
EZ
43662011-03-13 Eli Zaretskii <eliz@gnu.org>
4367
4368 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4369 $(EMACS_ROOT)/lib/intprops.h.
4370
f0c77cd1
PE
43712011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4372
3eca4629
PE
4373 Fix more problems found by GCC 4.5.2's static checks.
4374
7c86ee98
PE
4375 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4376 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4377 (xg_free_frame_widgets): Make it clear that a local variable is
4378 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4379 (gdk_window_get_screen): Make it clear that this macro is needed
4380 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4381 (int_gtk_range_get_value): New function, which avoids a diagnostic
4382 from gcc -Wbad-function-cast.
4383 (xg_set_toolkit_scroll_bar_thumb): Use it.
4384 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4385 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4386 (get_utf8_string, xg_get_file_with_chooser):
4387 Rename locals to avoid shadowing.
4388 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4389
41729b81
PE
4390 * xgselect.c (xg_select): Remove unused var.
4391
f0c77cd1
PE
4392 * image.c (four_corners_best): Mark locals as initialized.
4393 (gif_load): Initialize transparent_p to zero (Bug#8238).
4394 Mark another local as initialized.
ec6cf4c6 4395 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4396
ce0ad53d 4397 * image.c (clear_image_cache): Now static.
d5d5a617 4398 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4399 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4400 (x_edge_detection): Remove unnecessary cast that
4401 gcc -Wbad-function-cast diagnoses.
2037898d 4402 (gif_load): Fix pointer signedness.
6ae141d6
PE
4403 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4404 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4405
33383987 44062011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4407
d32df629
PE
4408 Improve quality of tests for time stamp overflow.
4409 For example, without this patch (encode-time 0 0 0 1 1
4410 1152921504606846976) returns the obviously-bogus value (-948597
4411 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4412 reports time overflow. See
4413 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4414 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4415 * editfns.c: Include limits.h and intprops.h.
4416 (TIME_T_MIN, TIME_T_MAX): New macros.
4417 (time_overflow): Move earlier, to before first use.
4418 (hi_time, lo_time): New functions, for an accurate test for
4419 out-of-range times.
4420 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4421 (Fget_internal_run_time): Don't assume time_t fits in int.
4422 (make_time): Use list2 instead of Fcons twice.
4423 (Fdecode_time): More accurate test for out-of-range times.
4424 (check_tm_member): New function.
4425 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4426 (lisp_time_argument): Don't rely on undefined left-shift and
4427 right-shift behavior when checking for time stamp overflow.
8be6f318 4428
fe31d94c
PE
4429 * editfns.c (time_overflow): New function, refactoring common code.
4430 (Fformat_time_string, Fdecode_time, Fencode_time):
4431 (Fcurrent_time_string): Use it.
4432
8be6f318
PE
4433 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4434 * dired.c (make_time): Move to ...
4435 * editfns.c (make_time): ... here.
4436 * systime.h: Note the move.
4437
09d9db2c 44382011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4439
126bc0dc
YM
4440 * fringe.c (update_window_fringes): Remove unused variables.
4441
c47cbdfd
YM
4442 * unexmacosx.c (copy_data_segment): Also copy __got section.
4443 (Bug#8223)
4444
7ac80be9
EZ
44452011-03-12 Eli Zaretskii <eliz@gnu.org>
4446
c96bbc66 4447 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4448 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4449 Constify `char *' arguments and their references according to
4450 prototypes in tparam.h.
4451
ecb0f94d 4452 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4453
7ac80be9
EZ
4454 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4455 Adapt all references accordingly.
4456
4457 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4458
ef1fd07e
TT
44592011-03-11 Tom Tromey <tromey@redhat.com>
4460
4461 * buffer.c (syms_of_buffer): Remove obsolete comment.
4462
7ef4b50c
EZ
44632011-03-11 Eli Zaretskii <eliz@gnu.org>
4464
4465 * termhooks.h (encode_terminal_code): Declare prototype.
4466
4467 * msdos.c (encode_terminal_code): Don't declare prototype.
4468
4469 * term.c (encode_terminal_code): Now external again, used by
4470 w32console.c and msdos.c.
4471
44f230aa
SM
4472 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4473 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4474
4b1ec863 44752011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4476
1714f52b 4477 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4478
4b1ec863
PE
4479 * fringe.c (update_window_fringes): Mark locals as initialized
4480 (Bug#8227).
4481 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4482
524c7aa6
PE
4483 * alloc.c (mark_fringe_data): Move decl from here ...
4484 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4485 to check its interface.
4486 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4487
a5c0af81 4488 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4489 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4490 (fontset_font): Mark local as initialized.
a9a06e0b 4491 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4492
b4716021
PE
4493 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4494
811e9bac 4495 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4496 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4497 (x_own_selection, Fx_disown_selection_internal): Rename locals
4498 to avoid shadowing.
4499 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4500
7e3ab302
PE
4501 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4502 so that the caller can use some name other than gcpro1.
4503 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4504 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4505 (Fx_backspace_delete_keys_p):
4506 Use them to avoid shadowing, and rename vars to avoid shadowing.
4507 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4508 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4509 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4510 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4511 Remove unused locals.
7e3ab302
PE
4512 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4513 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4514 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4515 macros.
f78faa98 4516
e2b13473
PE
4517 * xterm.h (x_mouse_leave): New decl.
4518
77f23912
PE
4519 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4520 Remove unused functions.
cdf4ba58
PE
4521 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4522 (x_calc_absolute_position): Now static.
7411c686 4523 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4524 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4525 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4526 unless they are used.
38d0b34a
PE
4527 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4528 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4529 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4530 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4531 (x_error_catcher, x_connection_closed, x_error_handler):
4532 (x_error_quitter, xembed_send_message, x_iconify_frame):
4533 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4534 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4535 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4536
44f230aa
SM
4537 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4538 Rename or move locals to avoid shadowing.
6b463e58 4539 (tty_defined_color, merge_face_heights): Now static.
5967d051 4540 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4541 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4542 does not deduce is never used uninitialized.
73719eba
PE
4543 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4544 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4545
426994c3 4546 * terminal.c (store_terminal_param): Now static.
5489860b 4547
032f1620 4548 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4549 (set_frame_menubar): Remove unused local.
d4323972 4550 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4551 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4552 since they might point to immutable storage.
281585b0
PE
4553 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4554 since it's unused otherwise.
032f1620 4555
367c19e5 4556 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4557 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4558 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4559 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4560 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4561 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4562 does not deduce are never used uninitialized.
70739cbe 4563
07b48fa9
PE
4564 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4565
8868a238 4566 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4567 * window.c (window_loop, size_window):
4568 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4569
7e5cf297 4570 * window.c (display_buffer): Now static.
d6550a9f
PE
4571 (size_window): Mark variables that gcc -Wuninitialized
4572 does not deduce are never used uninitialized.
a586633d
PE
4573 * window.h (check_all_windows): New decl, to forestall
4574 gcc -Wmissing-prototypes diagnostic.
5b555da1 4575 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4576
f6095868
PE
4577 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4578 shadowing.
4579 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4580 Include <limits.h>.
4581 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4582 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4583 (load_charset_map): Mark variables that gcc -Wuninitialized
4584 does not deduce are never used uninitialized.
53df7c11 4585 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4586
f38b440c
PE
4587 * coding.c (coding_set_source, coding_set_destination):
4588 Use "else { /* comment */ }" rather than "else /* comment */;"
4589 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4590 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4591 a block, when the outer 'i' will do.
4592 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4593 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4594 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4595 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4596 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4597 Rename locals to avoid shadowing.
4598 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4599 * coding.c (emacs_mule_char, encode_invocation_designation):
4600 Now static, since they're not used elsewhere.
413bb2db 4601 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4602 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4603 (decode_coding_emacs_mule): Mark variables that gcc
4604 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4605 (detect_coding_iso_2022): Initialize a local variable that might
4606 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4607 this initialization is needed. (Bug#8211)
5f58e762
PE
4608 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4609 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4610 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4611 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4612 Remove unused macros.
f38b440c 4613
232b38b9 4614 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4615 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4616 * character.c (string_count_byte8): Likewise.
232b38b9 4617
fb90da1b
PE
4618 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4619 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4620
fb93dbc2
PE
4621 * chartab.c (copy_sub_char_table): Now static, since it's not used
4622 elsewhere.
5c156ace
PE
4623 (sub_char_table_ref_and_range, char_table_ref_and_range):
4624 Rename locals to avoid shadowing.
bbcd0949 4625 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4626
7d3b3862 4627 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4628 (BIDI_BOB): Remove unused macro.
7d3b3862 4629
6be7d3da
PE
4630 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4631 deduce are never used uninitialized.
c2ed9c8b 4632 * term.c (encode_terminal_code): Likewise.
6be7d3da 4633
75f8807f 4634 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4635
50938595
PE
4636 * tparam.h: New file.
4637 * term.c, tparam.h: Include it.
4638 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4639 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4640 Move these decls to tparam.h, and make them agree with what
4641 is actually in tparam.c. The previous trick of using incompatible
4642 decls in different modules does not conform to the C standard.
4643 All callers of tparam changed to use tparam's actual API.
4644 * tparam.c (tparam1, tparam, tgoto):
4645 Use const pointers where appropriate.
4646
fbceeba2
PE
4647 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4648 * cm.h (struct cm): Likewise.
4649 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4650 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4651 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4652 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4653 (turn_on_face, init_tty): Likewise.
4654 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4655
7f3f1250
PE
4656 * term.c (term_mouse_position): Rename local to avoid shadowing.
4657
e6ca6543
PE
4658 * alloc.c (mark_ttys): Move decl from here ...
4659 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4660
c40f8d15
AS
46612011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4662
4663 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4664
cfe0661d
JB
46652011-03-09 Juanma Barranquero <lekktu@gmail.com>
4666
4667 * search.c (compile_pattern_1): Remove argument regp, unused since
4668 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4669 (compile_pattern): Don't pass it.
4670
0afb4571
J
46712011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4672
4673 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4674 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4675 for ! HAVE_GTK3.
4676 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4677
4678 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4679
4680 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4681 gdk_window_get_screen, gdk_window_get_geometry,
4682 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4683 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4684 (xg_get_pixbuf_from_pixmap): New function.
4685 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4686 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4687 Call xg_get_pixbuf_from_pixmap instead of
4688 gdk_pixbuf_get_from_drawable.
4689 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4690 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4691 (xg_check_special_colors): Use GtkStyleContext and its functions
4692 for HAVE_GTK3.
4693 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4694 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4695 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4696 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4697 Call gtk_widget_get_preferred_size.
0afb4571
J
4698 (xg_frame_resized): gdk_window_get_geometry only takes 5
4699 parameters.
44f230aa
SM
4700 (xg_win_to_widget, xg_event_is_for_menubar):
4701 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4702 (xg_set_widget_bg): New function.
4703 (delete_cb): New function.
895009e1 4704 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4705 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4706 (xg_set_background_color): Call xg_set_widget_bg.
4707 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4708 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4709 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4710 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4711 if ! HAVE_GTK3.
4712 (update_frame_tool_bar): Call gtk_widget_hide.
4713 (xg_initialize): Use GDK_KEY_g.
4714
4715 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4716 if ! HAVE_GTK3
4717 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4718
4719 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4720 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4721 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4722
1c2cc4ef
JB
47232011-03-08 Juanma Barranquero <lekktu@gmail.com>
4724
4725 * w32xfns.c (select_palette): Check success of RealizePalette against
4726 GDI_ERROR, not zero.
4727
33383987 4728See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4729
4730;; Local Variables:
4731;; coding: utf-8
aac0c6e3
MR
4732;; End:
4733
33383987 4734 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4735
4736 This file is part of GNU Emacs.
4737
4738 GNU Emacs is free software: you can redistribute it and/or modify
4739 it under the terms of the GNU General Public License as published by
4740 the Free Software Foundation, either version 3 of the License, or
4741 (at your option) any later version.
4742
4743 GNU Emacs is distributed in the hope that it will be useful,
4744 but WITHOUT ANY WARRANTY; without even the implied warranty of
4745 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4746 GNU General Public License for more details.
4747
4748 You should have received a copy of the GNU General Public License
4749 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.