* lisp/term/w32-win.el (w32-default-color-map): Declare obsolete.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5430d399
JB
12011-10-26 Juanma Barranquero <lekktu@gmail.com>
2
3 * w32fns.c (w32_default_color_map): New function,
4 extracted from Fw32_default_color_map.
5 (Fw32_default_color_map, Fx_open_connection): Use it.
6
fe0055fa
PE
72011-10-25 Paul Eggert <eggert@cs.ucla.edu>
8
9 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
10
e6346438
SM
112011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
12
13 * keyboard.c (test_undefined): New function (bug#9751).
14 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
15
e112cc37
ET
162011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
17
18 * sysdep.c (init_sys_modes): Fix the check for the controlling
19 terminal (Bug#6649).
20
7b5d6677
EZ
212011-10-20 Eli Zaretskii <eliz@gnu.org>
22
23 * dispextern.h (struct bidi_it): New member next_en_type.
24
25 * bidi.c (bidi_line_init): Initialize the next_en_type member.
26 (bidi_resolve_explicit_1): When next_en_pos is valid for the
27 current character, check also for next_en_type being WEAK_EN.
28 (bidi_resolve_weak): Don't enter the expensive loop if the current
29 position is before next_en_pos. Record the bidi type of the first
30 non-ET, non-BN character we find, in addition to its position.
31 (bidi_level_of_next_char): Invalidate next_en_type when
32 next_en_pos is over-stepped.
33
7da0b018
PE
342011-10-20 Paul Eggert <eggert@cs.ucla.edu>
35
36 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
37 * editfns.c: Rewrite current-time-zone so that it invokes
38 the equivalent of (format-time-string "%Z") to get the time zone name.
39 This fixes a bug when the time zone name contains characters that
40 need converting from the system time locale to Emacs internal format.
41 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
42 that patch fixed format-time-string to do the conversion, but
43 I forgot to fix current-time-zone.
44 (format_time_string): New function, containing most of
45 what Fformat_time_string used to contain.
46 (Fformat_time_string): Rewrite in terms of format_time_string.
47 This doesn't change this function's behavior.
48 (current-time-zone): Rewrite to use format_time_string.
49 This fixes the bug reported by Michael Schierl in
50 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
51 Jason Rumney's 2007-06-07 change worked around this bug, but
52 didn't fix it.
53 * systime.h (tzname, timezone): Remove no-longer-used declarations.
54
8547b010
EZ
552011-10-19 Eli Zaretskii <eliz@gnu.org>
56
57 * xdisp.c (start_display): If the character at POS is displayed
58 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
59 (try_window_reusing_current_matrix): If a line ends in a display
60 vector or the next line starts in a display vector, continue
61 redrawing the window even though the character position of
62 start_row was reached.
8547b010
EZ
63 (Bug#9771, part 2)
64
4e948d15
CY
652011-10-18 Chong Yidong <cyd@gnu.org>
66
67 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
68 with nobreak-char-display too.
69
4787455f
EZ
702011-10-18 Eli Zaretskii <eliz@gnu.org>
71
72 Fix part 3 of bug#9771.
73 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
74 (bidi_resolve_neutral): Don't enter the expensive loop looking for
75 non-neutral characters if the current character is a paragraph
76 separator (a.k.a. Newline). This avoids running the same
77 expensive loop twice, once when we consume the preceding newline
78 and the other time when the line actually needs to be displayed.
79 Avoid the loop when we see neutrals on the base embedding level
80 following a character whose directionality is the same as the
81 paragraph's. This avoids running the expensive loop when a line
82 ends in a long sequence of neutrals, like control characters.
83 Add assertion against STRONG_AL type. Slightly rearrange code
84 that determines the type of a neutral given the first non-neutral
85 that follows it.
86 (bidi_level_of_next_char): Set next_en_pos to zero when
87 invalidating its info.
88
2c91f553
EZ
892011-10-17 Eli Zaretskii <eliz@gnu.org>
90
91 * xdisp.c (push_display_prop): Determine whether to record string
92 or buffer position by IT->string, not by IT->method. Allow
93 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
94 (move_it_vertically_backward): Don't look for character position
95 immediately after the newline when in a continuation line.
96 (Bug#9771, part 1)
2c91f553 97
c7b08b0d
MR
982011-10-15 Martin Rudalics <rudalics@gmx.at>
99
100 * window.c (coordinates_in_window): Rewrite and delabelize
101 vertical border check. (Bug#5357) (Bug#9618)
102
6b02f655
SM
1032011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
104
105 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
106 errors in XSetWindowBorder (bug#9310).
107
81d40c92
DA
1082011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
109
110 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
111 avoid crash when xmalloc overrun checking is enabled.
112
d4172c3b
EZ
1132011-10-13 Eli Zaretskii <eliz@gnu.org>
114
115 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
116 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
117 cursor motion with <left> and <right> arrow keys.
118
119 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
120 some callers set that themselves.
121
b00eea75
EZ
1222011-10-12 Eli Zaretskii <eliz@gnu.org>
123
124 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
125 display string and the previous row comes from the same string and
126 is empty. (Bug#9739) (Bug#9738)
127
8fe012c4
SM
1282011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
129
130 * doc.c (get_doc_string): Encode file name (bug#9735).
131
0074aef2
EZ
1322011-10-12 Eli Zaretskii <eliz@gnu.org>
133
79beb178
EZ
134 * bidi.c (bidi_level_of_next_char):
135 * xdisp.c (get_visually_first_element): Remove old incorrect
136 comments regarding the Unicode Line Separator character.
137
0074aef2
EZ
138 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
139
6e4b3fbe
DA
1402011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
141
142 * alloc.c (Fgc_status): Do not access beyond zombies array
143 boundary if nzombies > MAX_ZOMBIES.
144 * alloc.c (dump_zombies): Add missing format specifier.
145
0324f3af
PE
1462011-10-12 Paul Eggert <eggert@cs.ucla.edu>
147
b5525cac
PE
148 * xdisp.c (set_cursor_from_row): Simplify conditionals,
149 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
150
0324f3af
PE
151 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
152 Some packages use them to denote characters with modifiers.
153
e9b5f888
AS
1542011-10-11 Andreas Schwab <schwab@linux-m68k.org>
155
156 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
157 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
158 matching a pp-number. Rename parameter var to var1.
159
127827c0
SM
1602011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
161
162 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
163
c8fd3bd0
GM
1642011-10-08 Glenn Morris <rgm@gnu.org>
165
166 * callint.c (Fcall_interactively): Give a more explicit error for the
167 'c' case with a non-character input. (Bug#8479)
168
352ec8ff
EZ
1692011-10-08 Eli Zaretskii <eliz@gnu.org>
170
03669ccb
EZ
171 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
172 lines.
7061c986
EZ
173 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
174 lines that are hscrolled on the left.
03669ccb 175
352ec8ff
EZ
176 * dispnew.c (buffer_posn_from_coords): Account for a possible
177 presence of header-line. (Bug#4426)
178
a66cfb1c
SM
1792011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
180
6b02f655
SM
181 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
182 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 183
7c5ee88e
PE
1842011-10-07 Paul Eggert <eggert@cs.ucla.edu>
185
186 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
187 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
188 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
189 this makes Emacs dump core during garbage collection on rare
190 occasions. sizeof is obviously inferior to offsetof here, so
191 stick with offsetof.
192 (GC_POINTER_ALIGNMENT): New macro.
193 (mark_memory): Omit 3rd (offset) arg; caller changed.
194 Don't assume EMACS_INT alignment is the same as pointer alignment.
195
df1bbe5b
SM
1962011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
197
198 * keyboard.c (read_key_sequence_remapped): New var.
199 (read_key_sequence): Compute remapping in the right buffer.
200 (command_loop_1): Use read_key_sequence's remapping directly.
201
51553db6
SM
2022011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
203
32c1fffd
SM
204 * dired.c (file_name_completion): Don't expand file name.
205 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
206 before checking file name handler.
207
51553db6
SM
208 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
209 they've been requested explicitly (bug#9591).
210
b6bd1599 2112011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
212
213 * keymap.c (Fsingle_key_description): Use make_specified_string
214 instead of build_string to build string from push_key_description.
215 (Bug#5193)
216
f701dc2a
PE
2172011-09-30 Paul Eggert <eggert@cs.ucla.edu>
218
4222c55d
PE
219 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
220 This fixes a Y2038 bug on 64-bit hosts.
221 * buffer.c (reset_buffer):
222 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
223 (Fclear_buffer_auto_save_failure):
224 Use 0, not -1, to represent an unset failure time, since time_t
225 might not be signed.
226
f701dc2a
PE
227 Remove dependency on glibc malloc internals.
228 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
229 Move back here from lisp.h, but with their new implementations.
230 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
231 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
232 * charset.c (charset_table_init): New static var.
233 (syms_of_charset): Use it instead of xmalloc. This removes a
234 dependency on glibc malloc internals. See Eli Zaretskii's comment in
235 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
236 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
237 Move back to alloc.c.
238 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
239 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
240
9ceebf39
JD
2412011-09-30 Jan Djärv <jan.h.d@swipnet.se>
242
243 * nsterm.m (windowDidResize): Call x_set_window_size only when
244 ns_in_resize is true. Otherwise set pixelwidth/height and
245 call change_frame_size (Bug#9628).
246
cb993c58
PE
2472011-09-30 Paul Eggert <eggert@cs.ucla.edu>
248
3930c88b
PE
249 Port --enable-checking=all to Fedora 14 x86-64.
250 * charset.c (syms_of_charset): Also account for glibc malloc's
251 internal overhead when calculating the initial malloc maximum.
252
cb993c58
PE
253 Port --enable-checking=all to Fedora 14 x86.
254 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
255 Move to lisp.h.
256 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
257 (overrun_check_realloc, overrun_check_free):
258 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
259 That way, xmalloc returns a properly-aligned pointer even if
260 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
261 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
262 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
263 into account when calculating the initial malloc maximum.
264 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
265 Move here from alloc.c, so that charset.c can use it too.
266 Properly align; the old code wasn't right for common 32-bit hosts
267 when configured with --enable-checking=all.
268 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
269 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
270
31bed486
EZ
2712011-09-29 Eli Zaretskii <eliz@gnu.org>
272
04c70788 273 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
274 use EDOM.
275
fbcaa2f3
EZ
2762011-09-28 Eli Zaretskii <eliz@gnu.org>
277
278 * xdisp.c (compute_display_string_end): If there's no display
279 string at CHARPOS, return -1.
280
281 * bidi.c (bidi_fetch_char): When compute_display_string_end
282 returns a negative value, treat the character as a normal
283 character not covered by a display string. (Bug#9624)
284
a239d4e9
JB
2852011-09-28 Juanma Barranquero <lekktu@gmail.com>
286
287 * lread.c (Fread_from_string): Fix typo in docstring.
288
88652fd5
EZ
2892011-09-27 Eli Zaretskii <eliz@gnu.org>
290
291 * xdisp.c (handle_invisible_prop): If invisible text ends on a
292 newline, reseat the iterator instead of bidi-iterating there one
293 character at a time. (Bug#9610)
32c1fffd
SM
294 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
295 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 296
ed497dd4
AS
2972011-09-27 Andreas Schwab <schwab@linux-m68k.org>
298
299 * lread.c (readevalloop): Use correct code for NBSP.
300 (read1): Likewise. (Bug#9608)
301
b2bf61aa
MA
3022011-09-25 Michael Albinus <michael.albinus@gmx.de>
303
304 * dbusbind.c (Fdbus_register_signal): When service is not
305 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
306
32bbb17c
GM
3072011-09-25 Glenn Morris <rgm@gnu.org>
308
309 * buffer.c (truncate-lines): Doc fix.
310
94e0933e
CY
3112011-09-24 Chong Yidong <cyd@stupidchicken.com>
312
313 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
314 (Fset_window_next_buffers): Doc fix.
315
cddde921
GM
3162011-09-24 Glenn Morris <rgm@gnu.org>
317
318 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
319
1260aef1
PE
3202011-09-24 Paul Eggert <eggert@cs.ucla.edu>
321
25b4bfa0
PE
322 Fix minor problems found by static checking.
323 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
324 * indent.c (Fvertical_motion): Fix == vs = typo.
325
e3cbd34b
EZ
3262011-09-24 Eli Zaretskii <eliz@gnu.org>
327
a66cfb1c
SM
328 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
329 Default value is now t. Doc fix.
6bf7006f 330
e3cbd34b 331 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 332 logic when moving up, not only when moving down. Fix the
e3cbd34b 333 confusing name and values of the it_overshoot_expected variable;
32c1fffd 334 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
335
336 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
337 CHARPOS is covered by a display string which includes newlines.
338 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
339 is covered by a display string with embedded newlines.
340
a3de0cbd
MA
3412011-09-24 Michael Albinus <michael.albinus@gmx.de>
342
343 * dbusbind.c (Fdbus_register_signal): Add match rule to
344 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
345 (Fdbus_register_method, Vdbus_registered_objects_table):
346 Fix docstring.
a3de0cbd 347
b260039d
JM
3482011-09-24 Jim Meyering <meyering@redhat.com>
349
32c1fffd 350 do not ignore write error for any output size
b260039d
JM
351 The previous change was incomplete.
352 While it makes emacs --batch detect the vast majority of stdout
353 write failures, errors were still ignored whenever the output size is
354 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
355 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
356 && echo FAIL: ignored write error
357 FAIL: ignored write error
358 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
359 && echo FAIL: ignored write error
360 FAIL: ignored write error
361 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
362
8eca8a7c
AS
3632011-09-23 Andreas Schwab <schwab@linux-m68k.org>
364
365 * emacs.c (Fkill_emacs): In noninteractive mode exit
366 non-successfully if a write error occurred on stdout. (Bug#9574)
367
3341db62
EZ
3682011-09-21 Eli Zaretskii <eliz@gnu.org>
369
370 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
371 the xassert test.
372
373 * dispextern.h (struct it): Update the comment documenting what
374 can it->OBJECT be.
375
8c203dbf
EZ
3762011-09-20 Eli Zaretskii <eliz@gnu.org>
377
378 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
379 a display string, extend search for cursor position to end of row.
380 (find_row_edges): If the row ends in a newline from a display
381 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
382 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
383 (Fcurrent_bidi_paragraph_direction): Fix search for previous
384 non-empty line. Fixes confusing cursor motion with arrow keys at
385 the beginning of a line that starts with whitespace.
8c203dbf 386
a4824228
LMI
3872011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
388
389 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
390 (bug#9493).
391
33ed493b
CY
3922011-09-18 Chong Yidong <cyd@stupidchicken.com>
393
394 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
395 boolean (Bug#9154).
396
56cd55c8
EZ
3972011-09-18 Eli Zaretskii <eliz@gnu.org>
398
399 * xdisp.c (display_line): Record maximum and minimum buffer
400 positions even if no glyphs were produced (e.g., by a zero-width
401 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
402 buffer positions that will be removed from the glyph row because
403 they don't fit.
c02dcedf
EZ
404 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
405 column is beyond frame width: don't subtract 1 "pixel" when
406 computing width of the stretch.
3e62b7e0
EZ
407 (reseat_at_next_visible_line_start): Undo the change made on
408 2011-09-17 that saved paragraph information and restored it after
409 the call to `reseat'. (Bug#9545)
56cd55c8 410
5ed99d36 4112011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
412
413 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
414 and turn window cursor on if cleared (Bug#9415).
415
5ed99d36 4162011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
417
418 * search.c (boyer_moore): Take unibyte characters from pattern
419 literally. (Bug#9458)
420
9bade7b2
EZ
4212011-09-18 Eli Zaretskii <eliz@gnu.org>
422
423 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
424
e5e9d610
PE
4252011-09-18 Paul Eggert <eggert@cs.ucla.edu>
426
87e4427a
PE
427 Fix minor problem found by static checking.
428 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
429 initialized, to pacify gcc -Wuninitialized.
430
e5e9d610
PE
431 * fileio.c: Report proper errno when syscall falls.
432 (Finsert_file_contents): Save and restore errno,
433 so that report_file_error outputs the correct diagnostic.
434 (Fwrite_region) [CLASH_DETECTION]: Likewise.
435
a1674f0b
EZ
4362011-09-18 Eli Zaretskii <eliz@gnu.org>
437
438 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
439
fbfb6dd4
EZ
4402011-09-17 Eli Zaretskii <eliz@gnu.org>
441
442 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
443 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
444
bb187662
EZ
4452011-09-17 Eli Zaretskii <eliz@gnu.org>
446
1137e8b8 447 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 448 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
449
450 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
451 (bidi_find_paragraph_start): Search back for paragraph beginning
452 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
453 (bidi_move_to_visually_next): Only trigger paragraph-related
454 computations when the last character is a newline or at EOB, not
455 just any NEUTRAL_B. (Bug#9470)
456
bb187662
EZ
457 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
458 truncated lines if point is covered by a display string. (Bug#9524)
459
2e621251
PE
4602011-09-16 Paul Eggert <eggert@cs.ucla.edu>
461
462 * xselect.c: Relax test for outgoing X longs (Bug#9498).
463 (cons_to_x_long): New function.
464 (lisp_data_to_selection_data): Use it. Correct the test for
465 short-versus-long data; it was negated. Break out of vector
466 loop, for efficiency, when a long datum is discovered.
467
91a15bc6
SM
4682011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
469
470 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
471
b41c3a35
EZ
4722011-09-16 Eli Zaretskii <eliz@gnu.org>
473
474 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
475 GCC PR/17406) by declaring this function with external scope.
476
7812ba2d
PE
4772011-09-15 Paul Eggert <eggert@cs.ucla.edu>
478
479 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
480 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
481
cf7edc2a
AS
4822011-09-15 Andreas Schwab <schwab@linux-m68k.org>
483
484 * editfns.c (Fformat): Correctly handle text properties on "%%".
485
bd01620e
EZ
4862011-09-15 Eli Zaretskii <eliz@gnu.org>
487
488 * xterm.c (x_draw_composite_glyph_string_foreground):
489 * w32term.c (x_draw_composite_glyph_string_foreground):
490 * term.c (encode_terminal_code):
491 * composite.c (composition_update_it, get_composition_id):
492 * xdisp.c (get_next_display_element)
493 (fill_composite_glyph_string): Add comments about special meaning
494 of TAB characters in a composition.
495
a02719a3
PE
4962011-09-15 Paul Eggert <eggert@cs.ucla.edu>
497
498 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
499 This occurs when processing a multibyte format.
500 Problem reported by Wolfgang Jenker.
a02719a3 501
72589a3c
JB
5022011-09-15 Johan Bockgård <bojohan@gnu.org>
503
504 * xdisp.c (try_cursor_movement): Only check for exact match if
505 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
506
1c14176c
PE
5072011-09-14 Paul Eggert <eggert@cs.ucla.edu>
508
509 Remove unused external symbols.
510 * dispextern.h (calc_pixel_width_or_height): Remove decl.
511 * xdisp.c (calc_pixel_width_or_height): Now static.
512 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
513 * indent.c (check_display_width):
514 * w32term.c: Fix comment to match code.
515 * xterm.c, xterm.h (x_catching_errors): Remove.
516
d2eea5b5
PE
5172011-09-14 Paul Eggert <eggert@cs.ucla.edu>
518
519 * xselect.c: Use signed conversions more consistently (Bug#9498).
520 (selection_data_to_lisp_data): Assume incoming selection data are
521 signed integers, not unsigned. This is to be consistent with
522 outgoing selection data, which was modified to use signed integers
523 in as part of the fix to Bug#9196 in response to Jan D.'s comment
524 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
525 expects long, not unsigned long.
526
46888499
EZ
5272011-09-14 Eli Zaretskii <eliz@gnu.org>
528
529 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
530 computation of loop end. Reported by Johan Bockgård
531 <bojohan@gnu.org>.
532
ef8ef9fb
CY
5332011-09-13 Chong Yidong <cyd@stupidchicken.com>
534
535 * frame.c (Fother_visible_frames_p): Function deleted.
536
fa819fed
EZ
5372011-09-12 Eli Zaretskii <eliz@gnu.org>
538
539 * indent.c (compute_motion): Process display vector front to back
540 rather than the other way around. (Bug#2496)
541
2ba8e008
SM
5422011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
543
544 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
545
20f53c69
CY
5462011-09-11 Chong Yidong <cyd@stupidchicken.com>
547
548 * minibuf.c (Fread_from_minibuffer): Doc fix.
549
d562d7a4
EZ
5502011-09-11 Eli Zaretskii <eliz@gnu.org>
551
552 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
553 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
554
1c4d7f3d
LMI
5552011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
556
557 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
558 value for non-existent files.
559
b885bf36
EZ
5602011-09-11 Eli Zaretskii <eliz@gnu.org>
561
562 * fileio.c (Finsert_file_contents): If the file cannot be opened,
563 set its "size" to -1. This will set the modtime_size field of
564 the corresponding buffer to -1, which is what
565 verify-visited-file-modtime expects for files that do not exist.
566 (Bug#9139)
567
6612f0bf
PE
5682011-09-11 Paul Eggert <eggert@cs.ucla.edu>
569
570 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
571 here ...
572 * lisp.h: ... from here. push_key_description is no longer
573 defined in keyboard.c, so its declaration should not be in
574 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
575 logically belongs with push_key_description.
576
dfb3f755
PE
5772011-09-10 Paul Eggert <eggert@cs.ucla.edu>
578
579 * buffer.h: Include <sys/types.h> instead of <time.h>.
580 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
581 Problem reported by Herbert J. Skuhra.
582
3134906c
LMI
5832011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
584
585 * xml.c (parse_region): Make the parsing work for
586 non-comment-starting XML files again (bug#9144).
587
8d903f4e
AS
5882011-09-10 Andreas Schwab <schwab@linux-m68k.org>
589
590 * image.c (gif_load): Fix calculation of bottom and right corner.
591 (Bug#9468)
592
80ad64f4
EZ
5932011-09-10 Eli Zaretskii <eliz@gnu.org>
594
595 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
596 redisplay in small windows.
597
208a048d
EZ
5982011-09-09 Eli Zaretskii <eliz@gnu.org>
599
600 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
601
9b1c252e
MR
6022011-09-08 Martin Rudalics <rudalics@gmx.at>
603
604 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
605 Operate on live windows only.
606
2949f33b
JB
6072011-09-08 Juanma Barranquero <lekktu@gmail.com>
608
609 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
610
e08dcafd
EZ
6112011-09-07 Eli Zaretskii <eliz@gnu.org>
612
613 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
614 only under bidi iteration.
615
115b96bd
JD
6162011-09-07 Jan Djärv <jan.h.d@swipnet.se>
617
618 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
619
c8199d0f
PE
6202011-09-06 Paul Eggert <eggert@cs.ucla.edu>
621
622 isnan: Fix porting problem to Solaris 10 with bundled gcc.
623 Without this fix, the command to link temacs failed due to an
624 undefined symbol __builtin_isnan. This is because
625 /usr/include/iso/math_c99.h #defines isnan(x) to
626 __builtin_isnan(x), but the bundled gcc, which identifies itself
627 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
628 a __builtin_isnan.
629 * floatfns.c (isnan): #undef, and then #define to a clone of
630 what's in data.c.
631 (Fisnan): Always define, since it's always available now.
632 (syms_of_floatfns): Always define isnan at the Lisp level.
633
e39b275c 6342011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
635
636 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
637
b2db44d9 6382011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 639
f4af5137 640 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
641 The previous code assumed that file offsets (off_t values) fit in
642 EMACS_INT variables, which is not true on typical 32-bit hosts.
643 The code messed up by falsely reporting buffer overflow in cases
644 such as (insert-file-contents "big" nil 1 2) into an empty buffer
645 when "big" contains more than 2**29 bytes, even though this
646 inserts just one byte and does not overflow the buffer.
647 (Finsert_file_contents): Store file offsets as off_t
648 values, not as EMACS_INT values. Check for overflow when
649 converting between EMACS_INT and off_t. When checking for
650 buffer overflow or for overlap, take the offsets into account.
651 Don't use EMACS_INT for small values where int suffices.
652 When checking for overlap, fix a typo: ZV was used where
653 ZV_BYTE was intended.
654 (Fwrite_region): Don't assume off_t fits into 'long'.
655 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
656
ecfc0a49
MA
6572011-09-05 Michael Albinus <michael.albinus@gmx.de>
658
659 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
660
6511acf2 6612011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 662
0999621a 663 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
664
665 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 666 (esprintf, exprintf, evxprintf): New functions.
62f19c19 667 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 668 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
669 (modify_event_symbol): Do not assume that the length of
670 name_alist_or_stem is safe to alloca and fits in int.
671 (Fexecute_extended_command): Likewise for function name and binding.
672 (Frecursion_depth): Wrap around reliably on integer overflow.
673 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
674 since some callers pass EMACS_INT values.
675 (Fsingle_key_description): Don't crash if symbol name contains more
676 than MAX_ALLOCA bytes.
677 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
678 (get_minibuffer): Arg is now EMACS_INT, not int.
679 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 680 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
681 * window.h (command_loop_level, minibuf_level): Reflect API changes.
682
2be7d702
PE
683 * dbusbind.c (signature_cat): New function.
684 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
685 Do not overrun buffer; instead, report string overflow.
686
9d1df220
PE
687 * dispnew.c (add_window_display_history): Don't overrun buffer.
688 Truncate instead; this is OK since it's just a log.
689
33ef5c64
PE
690 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
691 even if the time zone offset is outlandishly large.
692 Don't mishandle offset == INT_MIN.
693
66c6fdd5
PE
694 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
695 when creating daemon; the previous buffer-overflow check was incorrect.
696
d749b01b
PE
697 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
698 which has the guts of the old verror function.
699
b5cd1905
PE
700 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
701 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
702
6e1a67fb
PE
703 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
704 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 705 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 706 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
707 length of string rather than counting it via multiple sprintfs;
708 that's simpler and more reliable.
c21721cc
PE
709 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
710 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
711 sprintf, in case result does not fit in int.
712
c57b67fc
PE
713 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
714 (fontset_from_font): Print it.
715
8a401434
PE
716 * frame.c (tty_frame_count): Now printmax_t, not int.
717 (make_terminal_frame, set_term_frame_name): Print it.
718 (x_report_frame_params): In X, window IDs are unsigned long,
719 not signed long, so print them as unsigned.
720 (validate_x_resource_name): Check for implausibly long names,
721 and don't assume name length fits in 'int'.
722 (x_get_resource_string): Don't blindly alloca invocation name;
723 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
724 not fit in int.
725
6e1a67fb
PE
726 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
727 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
728 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
729
0df02bf3
PE
730 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
731 Use esprintf, not sprintf, in case result does not fit in int.
732
48e30793
PE
733 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
734 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
735 it as a large positive number.
736 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
737 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
738
a66ff6d8
PE
739 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
740 in case result does not fit in int.
741
aca216ff
PE
742 * print.c (float_to_string): Detect width overflow more reliably.
743 (print_object): Make sprintf buffer a bit bigger, to avoid potential
744 buffer overrun. Don't assume list length fits in 'int'. Treat
745 print length of 0 as 0, not as infinity; to be consistent with other
746 uses of print length in this function. Don't overflow print length
747 index. Don't assume hash table size fits in 'long', or that
748 vectorlike size fits in 'unsigned long'.
749
31c286f7
PE
750 * process.c (make_process): Use printmax_t, not int, to format
751 process-name gensyms.
752
55e5faa1
PE
753 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
754
80f2e268
PE
755 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
756 to avoid potential buffer overrun.
757
670741ab
PE
758 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
759 if X resource line is longer than 512 bytes.
760
b7163a50
PE
761 * xfns.c (x_window): Make sprintf buffer a bit bigger
762 to avoid potential buffer overrun.
763
ae58ff1f
PE
764 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
765
c43c8a6a
PE
766 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
767
3f8236f4
PE
7682011-09-04 Paul Eggert <eggert@cs.ucla.edu>
769
53e9fe90 770 Integer overflow fixes for scrolling, etc.
6511acf2
PE
771 Without these, Emacs silently mishandles large integers sometimes.
772 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
773 it were "C-u 1 M-x recenter" on a typical 64-bit host.
774
6511acf2
PE
775 * xdisp.c (try_window_id): Check Emacs fixnum range before
776 converting to 'int'.
806add1d 777
6511acf2 778 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
779 Check that an Emacs fixnum is in range before assigning it to 'int'.
780 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
781 values converted from Emacs fixnums.
782 (Frecenter): Don't wrap around a line count if it is out of 'int'
783 range; instead, treat it as an extreme value.
784 (Fset_window_configuration, compare_window_configurations):
785 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
786
6511acf2
PE
787 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
788 that can exceed INT_MAX. Check that EMACS_INT value is in range
789 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
790 (match_limit): Don't assume that a fixnum can fit in 'int'.
791
6511acf2 792 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
793 exceed INT_MAX.
794
6511acf2 795 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
796 (Fvertical_motion): Don't wrap around LINES values that don't fit
797 in 'int'. Instead, treat them as extreme values. This is good
798 enough for windows, which can't have more than INT_MAX lines anyway.
799
fcb901a7
LMI
8002011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
801
0f2f6b6d
LMI
802 * Require libxml/parser.h to avoid compilation warning.
803
fcb901a7
LMI
804 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
805
806 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
807 since this reportedly can destroy thread storage.
808
6e20a0d4
CY
8092011-08-30 Chong Yidong <cyd@stupidchicken.com>
810
811 * syntax.c (find_defun_start): Update all cache variables if
812 exiting early (Bug#9401).
813
148ae00e
EZ
8142011-08-30 Eli Zaretskii <eliz@gnu.org>
815
f6cfbd8f
EZ
816 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
817
148ae00e
EZ
818 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
819 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
820 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
821
822 * term.c (tty_append_glyph): New function.
823 (produce_stretch_glyph): Static function and its prototype deleted.
824
a66cfb1c
SM
825 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
826 Add prototypes.
148ae00e 827
c4a07a4c
PE
8282011-08-29 Paul Eggert <eggert@cs.ucla.edu>
829
830 * image.c (parse_image_spec): Check for nonnegative, not for positive,
831 when checking :margin (Bug#9390).
832 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 833 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
834 so that the name doesn't mislead. All uses changed.
835
6bc8cd65
JB
8362011-08-28 Johan Bockgård <bojohan@gnu.org>
837
838 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
839 set_tty_hooks.
840
dca4927e
EZ
8412011-08-27 Eli Zaretskii <eliz@gnu.org>
842
843 * xdisp.c (move_it_to): Don't bail out early when reaching
844 position beyond to_charpos, if we are scanning backwards.
845 (move_it_vertically_backward): When DY == 0, make sure we get to
846 the first character in the line after the newline.
847
f2cad773
PE
8482011-08-27 Paul Eggert <eggert@cs.ucla.edu>
849
850 * ccl.c: Improve and simplify overflow checking (Bug#9196).
851 (ccl_driver): Do not generate an out-of-range pointer.
852 (Fccl_execute_on_string): Remove unnecessary check for
853 integer overflow, noted by Stefan Monnier in
854 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
855 Remove a FIXME that didn't need fixing.
856 Simplify the newly-introduced buffer reallocation code.
857
0cae2cdb
JB
8582011-08-27 Juanma Barranquero <lekktu@gmail.com>
859
860 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
861
5fc295a4 8622011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 863
70c60eb2 864 Integer and memory overflow issues (Bug#9196).
726e0ab1 865
d31850da
PE
866 * doc.c (get_doc_string): Rework so that
867 get_doc_string_buffer_size is the actual buffer size, rather than
868 being 1 less than the actual buffer size; this makes xpalloc more
869 convenient.
870
a69fbedb
PE
871 * image.c (x_allocate_bitmap_record, cache_image):
872 * xselect.c (Fx_register_dnd_atom):
873 Simplify previous changes by using xpalloc.
874
fe5c5d37
PE
875 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
876 since either will do and ptrdiff_t is convenient with xpalloc.
877
0065d054
PE
878 * charset.c (charset_table_size)
879 (struct charset_sort_data.priority): Now ptrdiff_t.
880 (charset_compare): Don't overflow if priorities differ greatly.
881 (Fsort_charsets): Don't assume list length fits in int.
882 Check for size-calculation overflow when allocating sort data.
883 (syms_of_charset): Allocate an initial charset table that is
884 just under 64 KiB, to avoid problems with glibc malloc and mmap.
885
886 * cmds.c (internal_self_insert): Check for size-calculation overflow.
887
888 * composite.h (struct composition.glyph_len): Now int, not unsigned.
889 The actual value is always <= INT_MAX, and leaving it unsigned made
890 overflow checking harder.
891
892 * dispextern.h (struct glyph_matrix.rows_allocated)
893 (struct face_cache.size): Now ptrdiff_t, for convenience in use
894 with xpalloc. The values are still always <= INT_MAX.
895
896 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
897
898 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
899 (SAFE_NALLOCA): New macro.
900
901 * region-cache.c (struct boundary.pos, find_cache_boundary)
902 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
903 (set_cache_region, invalidate_region_cache)
904 (revalidate_region_cache, know_region_cache, region_cache_forward)
905 (region_cache_backward, pp_cache):
906 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
907 so that ptrdiff_t * can be passed to xpalloc.
908 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
909 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
910 (pp_cache): Don't assume cache_len fits in int.
911 * region-cache.h: Adjust extern decls to match.
912
913 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
914 EMACS_INT, since either will do, for xpalloc.
915
916 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
917 (xnmalloc, xnrealloc, xpalloc): New functions.
918
726e0ab1
PE
919 * bidi.c (bidi_shelve_header_size): New constant.
920 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
921 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
922
51f30bc5 923 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
924 * buffer.c (overlays_at, overlays_in, record_overlay_string)
925 (overlay_strings):
926 Don't update size of array until after memory allocation succeeds,
927 because xmalloc/xrealloc may not return.
0065d054
PE
928 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
929 now that we have proper integer overflow checking.
930 (record_overlay_string, overlay_strings): Catch overflows when
931 calculating size of overlay_str_buf.
726e0ab1 932
0065d054
PE
933 * callproc.c (Fcall_process): Check for size overflow when
934 calculating size of args2.
935 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
936 Normally we prefer signed values, but sticking with ptrdiff_t would
937 require adding more-complicated checks.
726e0ab1
PE
938
939 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
940 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
941 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 942 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
943
944 * character.c (Fstring): Check for size-calculation overflow.
945
946 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
947 unnecessary integer overflow. Check for size overflow.
948 (encode_coding_object): Don't update size until xmalloc succeeds.
949
950 * composite.c (get_composition_id): Check for overflow in glyph
951 length calculations.
952
953 Integer and memory overflow fixes for display code.
954 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
955 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
956 (scrolling_window): Check for overflow in size calculations.
957 (line_draw_cost, realloc_glyph_pool, add_row_entry):
958 Don't assume glyph table len fits in int.
959 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
960 (row_table_size): Now ptrdiff_t, not int.
961 (scrolling_window): Avoid overflow in size calculations.
962 Don't update size until allocation succeeds.
963 * fns.c (concat): Check for overflow in size calculations.
964 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
965 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
966 (NEXT_ALMOST_PRIME_LIMIT): New constant.
967
968 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
969 (get_doc_string): Check for size calculation overflow.
970 Don't update size until allocation succeeds.
971 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
972 EMACS_INT, where ptrdiff_t will do.
973 (Fsubstitute_command_keys): Check for string overflow.
974
975 * editfns.c (set_time_zone_rule): Don't assume environment length
976 fits in int.
977 (message_length): Now ptrdiff_t, not int.
978 (Fmessage_box): Don't update size until allocation succeeds.
979 Don't assume message length fits in int.
980 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
981
0065d054
PE
982 * emacs.c (main): Do not reallocate argv, since there is a null at
983 the end that can be overwritten, and this way there's no need to
984 worry about size-calculation overflow.
985 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
986
987 * eval.c (init_eval_once, grow_specpdl): Don't update size until
988 alloc succeeds.
989 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
990
991 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
992 (x_set_scroll_bar_width, x_figure_window_size):
993 Check for integer overflow.
994 (x_set_alpha): Do not assume XINT fits in int.
995
996 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
997 This is for the members text_lines, text_cols, total_lines, total_cols,
998 where the system imposes an 'int' limit.
999
1000 * fringe.c (Fdefine_fringe_bitmap):
1001 Don't update size until alloc works.
1002
1003 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1004 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1005
1006 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1007 Check for size-calculation overflow.
1008 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1009 do, as we prefer signed integers.
1010 (id_to_widget.max_size, id_to_widget.used)
1011 (xg_store_widget_in_map, xg_remove_widget_from_map)
1012 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1013 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1014 Use and return ptrdiff_t, not int.
1015 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1016 * gtkutil.h: Change prototypes to match the above.
1017
1018 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1019 are duplicate now that they've been promoted to lisp.h.
1020 (x_allocate_bitmap_record, x_alloc_image_color)
1021 (make_image_cache, cache_image, xpm_load):
1022 Don't update size until alloc is done.
1023 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1024 (x_detect_edges):
3256efce 1025 Check for size calculation overflow.
726e0ab1
PE
1026 (ct_colors_allocated_max): New constant.
1027 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1028 overflow.
3256efce 1029
726e0ab1
PE
1030 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1031 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1032 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1033 Use ptrdiff_t, not int, to count maps.
1034 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1035 calculations. Don't update size until allocation succeeds.
1036 Redo calculations to avoid overflow.
726e0ab1
PE
1037 * keyboard.h: Change prototypes to match the above.
1038
1039 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1040 to count maps.
1041 (current_minor_maps): Check for size calculation overflow.
1042 * keymap.h: Change prototypes to match the above.
1043
1044 * lread.c (read1, init_obarray): Don't update size until alloc done.
1045
1046 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1047 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1048
726e0ab1
PE
1049 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1050 Now ptrdiff_t, not int.
1051 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1052 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1053
1054 * process.c (Fnetwork_interface_list): Check for overflow
1055 in size calculation.
1056
1057 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1058
1059 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1060 overflow. Don't bother calling xmalloc when xrealloc will do.
1061
1062 * search.c (Freplace_match): Check for size calculation overflow.
1063 (Fset_match_data): Don't assume list lengths fit in 'int'.
1064
1065 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1066 for command line length. Do not attempt to address one before the
1067 beginning of an array, as that's not portable.
1068
1069 * term.c (max_frame_lines): Remove; unused.
1070 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1071 not int.
1072 (encode_terminal_code, calculate_costs): Check for size
1073 calculation overflow.
1074 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1075 table lengths and related sizes. Don't update size until alloc
1076 done. Redo calculations to avoid overflow.
1077 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1078
1079 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1080 subtracting pointers.
1081 (gobble_line): Check for overflow more carefully. Don't update size
1082 until alloc done.
1083
1084 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1085 Don't update size until alloc done.
1086 Redo size calculations to avoid overflow.
1087 Check for size calculation overflow.
0065d054 1088 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1089
1090 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1091 Use ptrdiff_t, not int, for sizes.
1092 (store_mode_line_noprop_char): Don't update size until alloc done.
1093
0065d054
PE
1094 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1095 Use ptrdiff_t, not int, for sizes.
1096 (Finternal_make_lisp_face, cache_face):
1097 Check for size calculation overflow.
1098 (cache_face): Treat size calculation overflows as if they were
1099 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1100
1101 * xfns.c (x_encode_text, x_set_name_internal)
1102 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1103 sizes, since they can exceed INT_MAX in size. Check for size
1104 calculation overflow.
1105
0065d054
PE
1106 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1107 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1108 Don't update size until alloc done.
1109
0065d054 1110 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1111 as sprintf is limited to int lengths.
1d526e2f 1112
252c5ee1
PE
1113 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1114 (X_LONG_MIN): New macros.
864d7ce7
PE
1115 Use them to make the following changes clearer.
1116 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1117 This change doesn't affect the value now, but it may help remind
1118 future maintainers not to raise the value too much later.
1119 (SELECTION_QUANTUM): Remove, replacing with ...
1120 (selection_quantum): ... new function, which avoids overflow.
1121 All uses changed.
1122 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1123 assumption that selection length fits in 'int'.
1124 (x_reply_selection_request, x_handle_selection_request)
1125 (x_get_window_property, receive_incremental_selection)
1126 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1127 (lisp_data_to_selection_data, clean_local_selection_data):
1128 Use ptrdiff_t, not int, to record length of selection.
1129 (x_reply_selection_request, x_get_window_property)
1130 (receive_incremental_selection, x_property_data_to_lisp):
1131 Redo calculations to avoid overflow.
1132 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1133 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1134 something.
1135 (x_get_window_property, receive_incremental_selection)
1136 (lisp_data_to_selection_data, x_property_data_to_lisp):
1137 Check for size-calculation overflow.
1138 (x_get_window_property, receive_incremental_selection)
1139 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1140 Don't store size until memory allocation succeeds.
1141 (x_get_window_property): Plug memory leak on memory exhaustion.
1142 Don't double-block input; malloc is safe here. Don't assume 2**34
1143 - 4 fits in unsigned long. Add an xassert to check
1144 XGetWindowProperty overflow. Be more careful about overflow
1145 calculations, and distinguish size from memory overflow better.
1146 (receive_incremental_selection): When tracing, don't assume
1147 unsigned int is less than INT_MAX.
1148 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1149 harmful) conversions of unsigned short to int.
1150 (lisp_data_to_selection_data): Don't assume that integers
1151 in the range -65535 through -1 fit in an X unsigned short.
1152 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1153 result parameters unless successful. Rely on cons_to_unsigned
1154 to report problems with elements; the old code wasn't right anyway.
1155 (x_check_property_data): Check for int overflow; we cannot use
1156 a wider type due to X limits.
1157 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1158
726e0ab1 1159 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1160
0065d054
PE
1161 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1162 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1163 (x_color_cells): Don't store size until memory allocation succeeds.
1164 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1165 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1166 (x_term_init): Don't assume length fits in int (sprintf is limited
1167 to int size).
bc18e09d 1168
ebfa62c0
PE
1169 Use ptrdiff_t for composition IDs.
1170 * character.c (lisp_string_width):
1171 * composite.c (composition_table_size, n_compositions)
1172 (get_composition_id, composition_gstring_from_id):
1173 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1174 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1175 * window.c (Frecenter):
1176 Use ptrdiff_t, not int, for composition IDs.
1177 * composite.c (get_composition_id): Check for integer overflow.
1178 * composite.h: Adjust prototypes to match the above changes.
1179
d3411f89
PE
1180 Use ptrdiff_t for hash table indexes.
1181 * category.c (hash_get_category_set):
1182 * ccl.c (ccl_driver):
1183 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1184 * coding.c (coding_system_charset_list, detect_coding_system):
1185 * coding.h (struct coding_system.id):
1186 * composite.c (get_composition_id, gstring_lookup_cache):
1187 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1188 * image.c (xpm_get_color_table_h):
1189 * lisp.h (hash_lookup, hash_put):
1190 * minibuf.c (Ftest_completion):
1191 Use ptrdiff_t for hash table indexes, not int (which is too
1192 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1193 32-bit --with-wide-int hosts).
1194
e097a6fa
PE
1195 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1196 Add a FIXME comment about memory leaks.
1197 (syms_of_charset): Don't assume xmalloc returns.
1198
5637687f
PE
1199 Don't assume that stated character widths fit in int.
1200 * character.c (Fchar_width, c_string_width, lisp_string_width):
1201 * character.h (CHAR_WIDTH):
1202 * indent.c (MULTIBYTE_BYTES_WIDTH):
1203 Use sanitize_char_width to avoid undefined and/or bad behavior
1204 with outlandish widths.
a66cfb1c 1205 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1206 now that we have two such functions. All uses changed.
1207 (sanitize_char_width): New inline function.
1208
a2271ba2
PE
1209 Don't assume that tab-width fits in int.
1210 * character.h (sanitize_width): New inline function.
1211 (SANE_TAB_WIDTH): New macro.
1212 (ASCII_CHAR_WIDTH): Use it.
1213 * indent.c (sane_tab_width): Remove. All uses replaced by
1214 SANE_TAB_WIDTH (current_buffer).
1215 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1216
18c52557
PE
1217 * fileio.c: Integer overflow issues with file modes.
1218 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1219
caeeedc1
PE
1220 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1221 Remove unreachable code.
1222 (read_hex, load_charset_map_from_file): Check for integer overflow.
1223
50849c52
PE
1224 * xterm.c: don't go over XClientMessageEvent limit
1225 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1226 (x_send_scroll_bar_event): Likewise. Check that the size does not
1227 exceed limits imposed by XClientMessageEvent, as well as the usual
1228 ptrdiff_t and size_t limits.
1229
b13995db
PE
1230 * keyboard.c: Overflow, signedness and related fixes.
1231 (make_lispy_movement): Use same integer type in forward decl
1232 that is used in the definition.
1233 (read_key_sequence, keyremap_step):
1234 Change bufsize argument back to int, undoing my 2011-03-30 change.
1235 We prefer signed types, and int is wide enough here.
1236 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1237 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1238 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1239 length, not size_t. Use ptrdiff_t for index, not int.
1240 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1241 possibility of integer overflow.
1242
13464394
PE
1243 Overflow, signedness and related fixes for images.
1244
1245 * dispextern.h (struct it.stack[0].u.image.image_id)
1246 (struct_it.image_id, struct image.id, struct image_cache.size)
1247 (struct image_cache.used, struct image_cache.ref_count):
1248 * gtkutil.c (update_frame_tool_bar):
1249 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1250 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1251 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1252 * nsmenu.m (update_frame_tool_bar):
1253 * xdisp.c (calc_pixel_width_or_height):
1254 * xfns.c (image_cache_refcount):
1255 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1256 on typical 64-bit hosts.
1257
1258 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1259 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1260 Omit unnecessary casts to int.
1261 (parse_image_spec): Check that integers fall into 'int' range
1262 when the callers expect that.
1263 (image_ascent): Redo ascent calculation to avoid int overflow.
1264 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1265 (lookup_image): Remove unnecessary tests.
1266 (xbm_image_p): Locals are now of int, not EMACS_INT,
1267 since parse_image_check makes sure they fit into int.
1268 (png_load, gif_load, svg_load_image):
1269 Prefer int to unsigned where either will do.
1270 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1271 old tiff_error_handler and tiff_warning_handler.
1272 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1273 stack buffer overflows. It uses only the features of vsnprintf
1274 that are common to both POSIX and native Microsoft.
1275 (tiff_error_handler, tiff_warning_handler): Use it.
1276 (tiff_load, gif_load, imagemagick_load_image):
1277 Don't assume :index value fits in 'int'.
1278 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1279 (imagemagick_load_image): Check that crop parameters fit into
1280 the integer types that MagickCropImage accepts. Don't assume
1281 Vimagemagick_render_type has a nonnegative value. Don't assume
1282 size_t fits in 'long'.
1283 (gs_load): Use printmax_t to print the widest integers possible.
1284 Check for integer overflow when computing image height and width.
1285
c11821d4
EZ
12862011-08-26 Eli Zaretskii <eliz@gnu.org>
1287
1288 * xdisp.c (redisplay_window): Don't force window start if point
1289 will be invisible in the resulting window. (Bug#9324)
1290
0c95fcf7
EZ
12912011-08-25 Eli Zaretskii <eliz@gnu.org>
1292
1293 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1294 the display spec is of the form `(space ...)'.
1295 (handle_display_spec): Return the value returned by
1296 handle_single_display_spec, not just 1 or zero.
1297 (handle_single_display_spec): If the display spec is of the form
1298 `(space ...)', and specifies display in the text area, return 2
1299 rather than 1.
fee65a97 1300 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1301 accurately, and prefer exact match for point under bidi.
1302 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1303
1304 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1305 into disp_prop; all users changed.
1306
1307 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1308 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1309 for the text covered by the display property.
1310
e4ed06f1
CY
13112011-08-25 Chong Yidong <cyd@stupidchicken.com>
1312
1313 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1314 Change return value to nil.
1315 (Frecord_buffer): Delete unused function.
1316
f67cdd7f
EZ
13172011-08-24 Eli Zaretskii <eliz@gnu.org>
1318
5980d4c6
EZ
1319 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1320 buffers, return left-to-right.
8610fe8b
EZ
1321 (set_cursor_from_row): Consider candidate row a win if its glyph
1322 represents a newline and point is on that newline. Fixes cursor
1323 positioning on the newline at EOL of R2L text within L2R
1324 paragraph, and vice versa.
1325 (try_cursor_movement): Check continued rows, in addition to
1326 continuation rows. Fixes unwarranted scroll when point enters a
1327 continued line of R2L text within an L2R paragraph, or vice versa.
1328 (cursor_row_p): Consider the case of point being equal to
1329 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1330 from the end of a short line to the beginning of a continued line
1331 of R2L text within L2R paragraph.
1332 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1333 composed characters.
5980d4c6 1334
f67cdd7f
EZ
1335 * bidi.c (bidi_check_type): Use xassert.
1336 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1337 members.
1338
bca633fb
EZ
13392011-08-23 Eli Zaretskii <eliz@gnu.org>
1340
1341 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1342 a character.
1343
4a5885a7
CY
13442011-08-23 Chong Yidong <cyd@stupidchicken.com>
1345
1346 * nsfont.m (ns_otf_to_script): Fix typo.
1347
0902a04e
KH
13482011-08-22 Kenichi Handa <handa@m17n.org>
1349
1350 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1351 extra slot even if the purpose is char-code-property-table.
1352
1a2e6670
EZ
13532011-08-23 Eli Zaretskii <eliz@gnu.org>
1354
8ddde651
EZ
1355 * xdisp.c (redisplay_window): When computing centering_position,
1356 account for the height of the header line. (Bug#8874)
1357
425cc014
EZ
1358 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1359 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1360 candidate is selected by the mouse, and that candidate has a
1361 composed character under the mouse.
1362
1a2e6670
EZ
1363 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1364 coordinates reported by pos-visible-in-window-p for a composed
1365 character in column zero.
1366
8b76d6f8
SM
13672011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1368
1369 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1370
dac347dd
EZ
13712011-08-22 Eli Zaretskii <eliz@gnu.org>
1372
1373 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1374 consider it a hit if to_charpos is anywhere in the range of the
1375 composed buffer positions.
1376
e013fb34
CY
13772011-08-22 Chong Yidong <cyd@stupidchicken.com>
1378
1379 * image.c (gif_load): Don't assume that each subimage has the same
1380 dimensions as the base image. Handle disposal method that is
1381 "undefined" by the gif spec (Bug#9335).
1382
bd1ba3e8
CY
13832011-08-20 Chong Yidong <cyd@stupidchicken.com>
1384
1385 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1386 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1387
54a1215b
EZ
13882011-08-19 Eli Zaretskii <eliz@gnu.org>
1389
823564e5
EZ
1390 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1391 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1392 from an Org mode buffer to a Speedbar frame.
1393
54a1215b
EZ
1394 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1395 a composition, take its buffer position from IT->cmp_it.charpos.
1396 Fixes cursor positioning at the beginning of a line that begins
1397 with a composed character.
1398
9778ebcc
EZ
13992011-08-18 Eli Zaretskii <eliz@gnu.org>
1400
0be6ee06
EZ
1401 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1402 character bidirectional type, use STRONG_L instead. Fixes crashes
1403 in a buffer produced by `describe-categories'.
1404
9778ebcc
EZ
1405 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1406 members before the level stack, so they would be saved and
1407 restored when copying iterator state. Fixes incorrect reordering
1408 around TABs covered by display properties.
1409
156bffbe
AS
14102011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1411
6b02f655 1412 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1413
72ad093b
CY
14142011-08-17 Chong Yidong <cyd@stupidchicken.com>
1415
1416 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1417 (internal_condition_case_2, internal_condition_case_n):
1418 Remove unnecessary aborts (Bug#9081).
72ad093b 1419
35774242
EZ
14202011-08-17 Eli Zaretskii <eliz@gnu.org>
1421
1422 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1423 has no `load' handler, try opening the file locally. (Bug#9311)
1424
db76dd85
KB
14252011-08-16 Ken Brown <kbrown@cornell.edu>
1426
1427 * gmalloc.c: Expand comment.
1428
b215eee5
EZ
14292011-08-16 Eli Zaretskii <eliz@gnu.org>
1430
1431 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1432 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1433
a4579d33
KB
14342011-08-16 Ken Brown <kbrown@cornell.edu>
1435
1436 Fix memory allocation problems in Cygwin build (Bug#9273).
1437
1438 * unexcw.c ( __malloc_initialized): Declare external variable.
1439 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1440
8b76d6f8
SM
1441 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1442 New variables.
a4579d33
KB
1443 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1444 dumped emacs.
1445 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1446 in the static heap.
1447 [CYGWIN] (special_realloc): New function.
1448 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1449 requests to realloc storage in the static heap.
1450
3ebec551
PE
14512011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1452
1453 * bidi.c (bidi_initialize): Remove unused local.
1454
9fd8be00
EZ
14552011-08-15 Eli Zaretskii <eliz@gnu.org>
1456
6b02f655
SM
1457 * bidimirror.h:
1458 * biditype.h: Remove file.
1459 * makefile.w32-in ($(BLD)/bidi.$(O)):
1460 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1461
1462 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1463
1464 * chartab.c: Improve commentary for the uniprop_table API.
1465
32413314
EZ
1466 * bidi.c (bidi_paragraph_init): Support zero value of
1467 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1468 (bidi_initialize): Use uniprop_table instead of including
1469 biditype.h and bidimirror.h.
32413314 1470
9fd8be00
EZ
1471 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1472 coordinates of the iterator when restoring from ppos_it.
1473 (Bug#9296)
1474
5cf2b69b
KH
14752011-08-14 Kenichi Handa <handa@m17n.org>
1476
1477 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1478 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1479
daf17d00
EZ
14802011-08-14 Eli Zaretskii <eliz@gnu.org>
1481
1482 * xdisp.c (move_it_in_display_line_to): Don't invoke
1483 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1484 ppos_it. Fixes vertical cursor motion when line beginning is
1485 covered by an image. (Bug#9296)
1486
08e3161a
JD
14872011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1488
1489 * nsterm.h (ns_run_ascript): Declare.
1490 (NSAPP_DATA2_RUNASSCRIPT): Define.
1491
1492 * nsfns.m (as_script, as_result, as_status): New static variables.
1493 (ns_run_ascript): New function.
5e617bc2 1494 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1495 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1496 the event loop. Get status from as_status (Bug#7276).
1497
1498 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1499 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1500 the event loop (Bug#7276).
1501
a3720aa2
AS
15022011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1503
1504 * gnutls.c (QCgnutls_bootprop_priority)
1505 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1506 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1507 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1508 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1509 (QCgnutls_bootprop_verify_hostname_error)
1510 (QCgnutls_bootprop_callbacks_verify): Rename from
1511 Qgnutls_bootprop_..., all uses changed.
1512
1513 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1514 uses changed.
1515
0a0d27fb
PE
15162011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1517
19d5c50c
PE
1518 * xfaces.c (Qframe_set_background_mode): Now static.
1519 * dispextern.h (Qframe_set_background_mode): Remove decl.
1520
0a0d27fb
PE
1521 * process.c (Fnetwork_interface_info): Declare local only if needed.
1522
377538cb
JD
15232011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1524
1525 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1526 (Fnetwork_interface_list): Allocate in increments of bytes instead
1527 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1528 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1529 sockaddr.
1530 (struct ifflag_def): notrailers is smart on OSX.
1531 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1532 Get hardware address with getifaddrs if available.
1533
08fff70c
EZ
15342011-08-12 Eli Zaretskii <eliz@gnu.org>
1535
1536 * xdisp.c (iterate_out_of_display_property): xassert that
1537 IT->position is set to within IT->object's boundaries. Break from
1538 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1539 when IT->position is set up wrongly due to some bug.
1540 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1541 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1542 entry. Force push_it to save on the stack the current
1543 buffer/string position, to be restored by pop_it. Fix flags in
1544 the iterator structure wrt the object coming from a display
1545 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1546 properties. (Bug#9284)
1547
7be1c708 15482011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1549
7be1c708
CY
1550 * fontset.c (fontset_get_font_group): Add proper type checks.
1551 (Bug#9172)
aac0c6e3 1552
7be1c708 15532011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1554
7be1c708
CY
1555 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1556 and LC_VERSION_MIN_MACOSX.
1557 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1558 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1559
97bb72a6
EZ
15602011-08-08 Eli Zaretskii <eliz@gnu.org>
1561
1562 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1563 no-display-properties-and-no-overlays under bidi display.
1564 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1565 properties and overlays.
97bb72a6 1566
d5617611
CY
15672011-08-08 Chong Yidong <cyd@stupidchicken.com>
1568
37e11a63
CY
1569 * editfns.c (Fset_time_zone_rule): Document relationship with the
1570 setenv function.
1571
d5617611
CY
1572 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1573 the font entity extracted from the cache (Bug#8109).
1574
58872834
CY
15752011-08-07 Chong Yidong <cyd@stupidchicken.com>
1576
1577 * composite.c (autocmp_chars): Don't reset point. That is done by
1578 restore_point_unwind (Bug#5984).
1579
75bfc667
JL
15802011-08-07 Juri Linkov <juri@jurta.org>
1581
1582 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1583 to show the arg `TIME' instead of `TIMEVAL'.
1584
d1410150
EZ
15852011-08-06 Eli Zaretskii <eliz@gnu.org>
1586
1587 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1588 display property strides EOL and includes a newline, as in
1589 longlines-mode. (Bug#9254)
75b771e4
EZ
1590 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1591 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1592
1593 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1594 is non-zero, even if the data buffer is NULL. Fixes a crash in
1595 vertical-motion with longlines-mode. (Bug#9254)
1596
35928349
EZ
15972011-08-05 Eli Zaretskii <eliz@gnu.org>
1598
ec7cc85b
EZ
1599 * bidi.c <bidi_cache_total_alloc>: Now static.
1600 (bidi_initialize): Initialize bidi_cache_total_alloc.
1601
8b76d6f8 1602 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1603 cache. (Bug#9221)
1604
1605 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1606 amount allocated this far in `bidi_cache_total_alloc'.
1607 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1608 non-zero, only free the data buffer without restoring the cache
1609 contents. All callers changed.
1610
1611 * dispextern.h (bidi_unshelve_cache): Update prototype.
1612
1613 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1614 (move_it_in_display_line, move_it_to)
1615 (move_it_vertically_backward, move_it_by_lines): Replace the call
1616 to xfree to an equivalent call to bidi_unshelve_cache.
1617 (move_it_in_display_line_to): Fix logic of returning
412b6358 1618 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1619
e2e2423b
EZ
16202011-08-05 Eli Zaretskii <eliz@gnu.org>
1621
1622 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1623 came from a string character with a `cursor' property. (Bug#9229)
1624
ae9e757a
JD
16252011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1626
1627 * Makefile.in (LIB_PTHREAD): New variable.
1628 (LIBES): Add LIB_PTHREAD (Bug#9216).
1629
1630 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1631 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1632
213bd7f2
AS
16332011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1634
6b02f655 1635 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1636
99aaf75f
JD
16372011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1638
1639 * xterm.c (x_find_topmost_parent): New function.
1640 (x_set_frame_alpha): Find topmost parent window with
1641 x_find_topmost_parent and set the property there also (bug#9181).
1642 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1643
c74e9d86
PE
16442011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1645
1646 * callproc.c (Fcall_process): Avoid vfork clobbering
1647 the local vars buffer, coding_systems, current_dir.
1648
640c8776
SM
16492011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1650
1651 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1652
f26d0e4c
PE
16532011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1654
8a10d76c
PE
1655 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1656 so that it is not optimized away.
1657
f26d0e4c
PE
1658 * xdisp.c (compute_display_string_pos): Remove unused local.
1659
55439c61
EZ
16602011-08-02 Eli Zaretskii <eliz@gnu.org>
1661
1662 Fix slow cursor motion and scrolling in large buffers with
1663 selective display, like Org Mode buffers. (Bug#9218)
1664
1665 * dispextern.h (struct bidi_it): New member disp_prop_p.
1666
1667 * xdisp.c: Remove one-slot cache of display string positions.
1668 (compute_display_string_pos): Accept an additional argument
5e617bc2 1669 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1670 for a display string or property. If found, set DISP_PROP_P
1671 non-zero.
1672
1673 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1674 DISP_PROP_P, and pass it to compute_display_string_pos.
1675 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1676 non-zero. All callers of bidi_fetch_char changed.
1677
fb33fa43
SM
16782011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1679
1680 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1681
b099e063
DM
16822010-12-03 Don March <don@ohspite.net>
1683
1684 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1685 last character M-[char] is translated to ESC [char] (bug#7541).
1686
5cc7f7af
KH
16872011-08-02 Kenichi Handa <handa@m17n.org>
1688
d0fffa3f 1689 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1690
1691 * chartab.c (uniprop_table): Make it non-static.
1692
525d5e6e
EZ
16932011-08-01 Eli Zaretskii <eliz@gnu.org>
1694
1695 * xdisp.c (forward_to_next_line_start): Accept additional argument
1696 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1697 on the newline.
1698 (reseat_at_next_visible_line_start): Use the bidi iterator state
1699 returned by forward_to_next_line_start to restore the state of
1700 it->bidi_it after backing up to previous newline. (Bug#9212)
1701
31011111
AS
17022011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1703
1704 * regex.c (re_comp): Protoize.
1705 (re_exec): Fix return type.
1706 (regexec): Fix type of `ret'. (Bug#9203)
1707
476371c4
PE
17082011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1709
e5d76069
PE
1710 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1711 This is needed if max-image-size is a floating-point number.
1712
9a79b20c
AS
17132011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1714
1715 * print.c (print_object): Print empty symbol as ##.
1716
1717 * lread.c (read1): Read ## as empty symbol.
1718
d8c2fa78
AA
17192011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1720
1721 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1722 setting frame foreground color (Bug#9175).
1723 (x_set_background_color): Likewise.
1724
ffe57a7a
AA
1725 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1726 contents (Bug#9176).
1727 (EmacsTooltip -init): Remove bezels and add shadows to
1728 tooltip windows.
1729
bf3492a5
AA
1730 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1731 or scroll bar (Bug#8470).
1732
d55e9c53
AA
1733 * nsfont.m (nsfont_open): Remove assignment to voffset and
1734 unnecessary vars hshink, expand, hd, full_height, min_height.
1735 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1736
1737 * nsterm.h (nsfont_info): Remove voffset field.
1738
d8c2fa78 17392011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1740
1741 Implement strike-through and overline on NextStep (Bug#8863).
1742
1743 * nsfont.m (nsfont_open): Use underline position provided by font,
1744 instead of hard-coded value of 2.
1745 (nsfont_draw): Call ns_draw_text_decoration instead.
1746
1747 * nsterm.h: Add declaration for ns_draw_text_decoration.
1748
1749 * nsterm.m (ns_draw_text_decoration): New function for drawing
1750 underline, overline, and strike-through.
1751 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1752 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1753 accommodate underlining, etc.
4843aac3 1754
4cc60b9b
EZ
17552011-07-28 Eli Zaretskii <eliz@gnu.org>
1756
bc7ece87
EZ
1757 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1758 default.
4cc60b9b 1759
476371c4
PE
17602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1761
66606eea
PE
1762 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1763 Without this fix, if a signal arrives just after memory fills up,
1764 'malloc' might be invoked reentrantly.
1765
476371c4
PE
1766 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1767 In other words, assume that every image size is allowed, on non-X
1768 hosts. This assumption is probably wrong, but it lets Emacs compile.
1769
f3fcc40d
AS
17702011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1771
1772 * regex.c (re_iswctype): Convert return values to boolean.
1773
350c992f
EZ
17742011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1775
1776 * xdisp.c (compute_display_string_pos): Don't use cached display
1777 string position if the buffer had its restriction changed.
1778 (Bug#9184)
1779
5266b4bb
PE
17802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1781
1782 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1783
2573a837 17842011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1785
41f55ccd 1786 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1787
39e378da
PE
1788 * bidi.c: Integer size and overflow fixes.
1789 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1790 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1791 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1792 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1793 (bidi_find_other_level_edge):
1794 Use ptrdiff_t instead of EMACS_INT where either will do.
1795 This works better on 32-bit hosts configured --with-wide-int.
1796 (bidi_cache_ensure_space): Check for size-calculation overflow.
1797 Use % rather than repeated addition, for better worst-case speed.
1798 Don't set bidi_cache_size until after xrealloc returns, because it
1799 might not return.
1800 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1801 (bidi_cache_ensure_space): Also check that the bidi cache size
1802 does not exceed that of the largest Lisp string or buffer. See Eli
1803 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1804
5e927815
PE
1805 * alloc.c (__malloc_size_t): Remove.
1806 All uses replaced by size_t. See Andreas Schwab's note
1807 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1808
ca4aa935
PE
1809 * image.c: Improve checking for integer overflow.
1810 (check_image_size): Assume that f is nonnull, since
1811 it is always nonnull in practice. This is one less thing to
1812 worry about when checking for integer overflow later.
1813 (x_check_image_size): New function, which checks for integer
1814 overflow issues inside X.
1815 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1816 This removes the need for a memory_full check.
1817 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1818 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1819 (xbm_read_bitmap_data): Change locals back to 'int', since
1820 their values must fit in 'int'.
1821 (xpm_load_image, png_load, tiff_load):
1822 Invoke x_create_x_image_and_pixmap earlier,
1823 to avoid much needless work if the image is too large.
1824 (tiff_load): Treat overly large images as if
1825 x_create_x_image_and_pixmap failed, not as malloc failures.
1826 (gs_load): Use x_check_image_size.
1827
5f8f9cc2
PE
1828 * gtkutil.c: Omit integer casts.
1829 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1830 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1831
5adf60bc
PE
1832 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1833
c8907a93
PE
1834 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1835 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1836 would wrongly return t on a 64-bit host.
1837
e3c25c68
PE
1838 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1839 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1840 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1841 and therefore cause GCC to emit a bogus diagnostic in some cases.
1842
3f791afe
PE
1843 * image.c: Integer signedness and overflow and related fixes.
1844 This is not an exhaustive set of fixes, but it's time to
1845 record what I've got.
1846 (lookup_pixel_color, check_image_size): Remove redundant decls.
1847 (check_image_size): Don't assume that arbitrary EMACS_INT values
1848 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1849 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1850 (tiff_load, imagemagick_load_image):
1851 Check for overflow in size calculations.
1852 (x_create_x_image_and_pixmap): Remove unnecessary test for
1853 xmalloc returning NULL; that can't happen.
1854 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1855 (xpm_color_bucket): Use better integer hashing function.
1856 (xpm_cache_color): Don't possibly over-allocate memory.
1857 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1858 (gif_memory_source):
1859 Use ptrdiff_t, not int or size_t, to record sizes.
1860 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1861 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1862 either works, as we prefer signed integers.
1863 (tiff_read_from_memory, tiff_write_from_memory):
1864 Return tsize_t, not size_t, since that's what the TIFF API wants.
1865 (tiff_read_from_memory): Don't fail simply because the read would
1866 go past EOF; instead, return a short read.
1867 (tiff_load): Omit no-longer-needed casts.
1868 (Fimagemagick_types): Don't assume size fits into 'int'.
1869
3cc5a532
PE
1870 Improve hashing quality when configured --with-wide-int.
1871 * fns.c (hash_string): New function, taken from sxhash_string.
1872 Do not discard information about ASCII character case; this
1873 discarding is no longer needed.
1874 (sxhash-string): Use it. Change sig to match it. Caller changed.
1875 * lisp.h: Declare it.
1876 * lread.c (hash_string): Remove, since we now use fns.c's version.
1877 The fns.c version returns a wider integer if --with-wide-int is
1878 specified, so this should help the quality of the hashing a bit.
1879
b312a492
PE
1880 * emacs.c: Integer overflow minor fix.
1881 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1882 Define only if GNU_LINUX.
1883 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1884
dfd153ae
PE
1885 * dispnew.c: Integer signedness and overflow fixes.
1886 Remove unnecessary forward decls, that were a maintenance hassle.
1887 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1888 All uses changed.
1889 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1890 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1891 (prepare_desired_row, line_draw_cost):
1892 Use int, not unsigned, where either works.
1893 (save_current_matrix, restore_current_matrix):
1894 Use ptrdiff_t, not size_t, where either works.
1895 (init_display): Check for overflow more accurately, and without
1896 relying on undefined behavior.
1897
a81d11a3
PE
1898 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1899 Remove, replacing with the new symbols in lisp.h. All uses changed.
1900 * fileio.c (make_temp_name):
1901 * filelock.c (lock_file_1, lock_file):
1902 * xdisp.c (message_dolog):
1903 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1904 Use pMd etc. instead.
1905 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1906 replacing the pWIDE etc. symbols removed from editfns.c.
1907
3300e6fd
PE
1908 * keyboard.h (num_input_events): Now uintmax_t.
1909 This is (very slightly) less likely to mess up due to wraparound.
1910 All uses changed.
1911
fd05c7e9
PE
1912 * buffer.c: Integer signedness fixes.
1913 (alloc_buffer_text, enlarge_buffer_text):
1914 Use ptrdiff_t rather than size_t when either will do, as we prefer
1915 signed integers.
1916
903fe15d
PE
1917 * alloc.c: Integer signedness and overflow fixes.
1918 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1919 (__malloc_size_t): Default to size_t, not to int.
1920 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1921 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1922 Prefer ptrdiff_t to size_t when either would do, as we prefer
1923 signed integers.
1924 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1925 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1926 Now const. Initialize with values that are in range even if char
1927 is signed.
1928 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1929 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1930 These functions do the right thing with sizes > 2**32.
1931 (check_depth): Now ptrdiff_t, not int.
1932 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1933 Adjust to new way of storing sizes. Check for size overflow bugs
1934 in rest of code.
1935 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1936 slightly wrong anyway, as it missed one instance of
1937 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1938 (refill_memory_reserve): Omit needless cast to size_t.
1939 (mark_object_loop_halt): Mark as externally visible.
1940
ac82cc6a
PE
1941 * xselect.c: Integer signedness and overflow fixes.
1942 (Fx_register_dnd_atom, x_handle_dnd_message):
1943 Use ptrdiff_t, not size_t, since we prefer signed.
1944 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1945 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1946 x_dnd_atoms_size and x_dnd_atoms_length.
1947
c2d1e36d
PE
1948 * doprnt.c: Prefer signed to unsigned when either works.
1949 * eval.c (verror):
1950 * doprnt.c (doprnt):
1951 * lisp.h (doprnt):
1952 * xdisp.c (vmessage):
1953 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1954 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1955 prefer signed arithmetic to avoid comparison confusion.
1956 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1957 but is a bit tricky.
1958
0e926e56
PE
1959 Assume freestanding C89 headers, string.h, stdlib.h.
1960 * data.c, doprnt.c, floatfns.c, print.c:
1961 Include float.h unconditionally.
1962 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1963 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1964 * regex.c: Likewise for stddef.h, string.h.
1965 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1966 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1967 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1968 (STDC_HEADERS): Remove obsolete defines.
1969 * sysdep.c: Include limits.h unconditionally.
1970
9cfdb3ec
PE
1971 Assume support for memcmp, memcpy, memmove, memset.
1972 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1973 * regex.c (memcmp, memcpy):
1974 Remove; we assume C89 now.
1975
1976 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1977 (__malloc_safe_bcopy): Remove; no longer needed.
1978
cf950e6b 1979 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1980 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1981 well either way, and we prefer signed to unsigned.
1982
dbf38e02
LMI
19832011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1984
1985 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1986 closes the connection while we're reading (bug#9182).
1987
d6f0886c 19882011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1989
d6f0886c
JD
1990 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1991 are specified (Bug#9168).
24e0f6b1 1992
2eb1f9e6
PE
19932011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1994
1995 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1996 Found by GCC static checking and --with-wide-int on a 32-bit host.
1997
22381272 19982011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1999
2000 * xdisp.c (compute_display_string_pos): Fix logic of caching
2001 previous display string position. Initialize cached_prev_pos to
2002 -1. Fixes slow-down at the beginning of a buffer.
2003
f25e39b4
EZ
20042011-07-24 Eli Zaretskii <eliz@gnu.org>
2005
2006 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2007 for attrs[LFACE_FONTSET_INDEX].
2008
04c4b52e
PE
20092011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2010
2011 * xml.c (parse_region): Remove unused local
2012 that was recently introduced.
2013
c1734fbd
EZ
20142011-07-23 Eli Zaretskii <eliz@gnu.org>
2015
be18c5a5
EZ
2016 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2017 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2018
c1734fbd
EZ
2019 * xdisp.c (move_it_in_display_line_to): Record the best matching
2020 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2021 exit if none of the characters scanned was an exact match.
2022 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2023 when exact match is impossible due to invisible text, and the
2024 lines are truncated.
2025
a258d627
JD
20262011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2027
2028 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2029 for OSX >= 10.7.
2030
b6d5a689
EZ
20312011-07-22 Eli Zaretskii <eliz@gnu.org>
2032
0f74f785
EZ
2033 Fix a significant slow-down of cursor motion with C-n, C-p,
2034 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2035 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2036 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2037 (next_element_from_buffer): Call compute_stop_pos_backwards to
2038 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2039 base_level_stop.
2040 (reseat): Don't look for prev_stop, as that could mean a very long
2041 run.
2042 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2043 <cached_disp_overlay_modiff>: Cache for last found display string
2044 position.
551918c1 2045 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2046 about the same buffer in the same area of character positions, and
2047 the buffer wasn't changed since the time the display string
2048 position was cached.
551918c1 2049
b2d0c91a
EZ
20502011-07-22 Eli Zaretskii <eliz@gnu.org>
2051
2052 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2053 is an integer, which is important for empty lines. (Bug#9149)
2054
043604ee
CY
20552011-07-22 Chong Yidong <cyd@stupidchicken.com>
2056
2057 * frame.c (Fmodify_frame_parameters): In tty case, update the
2058 default face if necessary (Bug#4238).
2059
da4adb04
CY
20602011-07-21 Chong Yidong <cyd@stupidchicken.com>
2061
2062 * editfns.c (Fstring_to_char): No need to explain what a character
2063 is in the docstring (Bug#6576).
2064
9abd0532
LMI
20652011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2066
2067 * xml.c (parse_region): Make sure we always return a tree.
2068
36881d16
HK
20692011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2070
2071 * xml.c (parse_region): If a document contains only comments,
2072 return that, too.
2073
1e98674d
LMI
20742011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2075
2076 * xml.c (make_dom): Return comments, too.
2077
590bd467
PE
20782011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2079
2080 Port to OpenBSD.
2081 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2082 and the surrounding thread.
2083 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2084 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2085 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2086 timer goes off.
2087 * s/openbsd.h (BROKEN_SIGIO): Define.
2088 * unexelf.c (unexec) [__OpenBSD__]:
2089 Don't update the .mdebug section of the Alpha COFF symbol table.
2090
f41628b2
LMI
20912011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2092
2093 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2094 (bug#8460).
2095
b59b67c5
PE
20962011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2097
15e3a074
PE
2098 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2099 This fixes some race conditions on the permissions of any newly
2100 created file.
2101
41bed37d
PE
2102 * alloc.c (valid_pointer_p): Use pipe, not open.
2103 This fixes some permissions issues when debugging.
2104
b59b67c5
PE
2105 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2106 If fchown fails to set both uid and gid, try to set just gid,
2107 as that is sometimes allowed. Adjust the file's mode to eliminate
2108 setuid or setgid bits that are inappropriate if fchown fails.
2109
925a6be7
SM
21102011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2111
2112 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2113 to compare Lisp_Objects.
2114 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2115 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2116 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2117
52968808
AS
21182011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2119
0a6a104b
AS
2120 * lread.c (read_integer): Unread even EOF character.
2121 (read1): Likewise. Properly record start position of symbol.
2122
52968808
AS
2123 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2124 symbol character follows.
2125
9e381cdd
PE
21262011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2127
2128 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2129 This works around a problem with the previous change to Fcopy_file.
2130 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2131 and without this change, GCC might complain about discarding
2132 fchown's return value.
2133
b5641435
JB
21342011-07-16 Juanma Barranquero <lekktu@gmail.com>
2135
2136 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2137
a8031457
PE
21382011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2139
2140 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2141
dd889327
LMI
21422011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2143
750c33f7
LMI
2144 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2145 it's used from the C level.
2146
dd889327
LMI
2147 * process.c: Use the same condition for POLL_FOR_INPUT in both
2148 keyboard.c and process.c (bug#1858).
2149
87e86684
LM
21502011-07-09 Lawrence Mitchell <wence@gmx.li>
2151
2152 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2153 (Fgnutls_boot): Use it.
2154
64348f40
AS
21552011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2156
2157 * doc.c (Fsubstitute_command_keys): Revert last change.
2158
1d698799
LMI
21592011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2160
f863868c
LMI
2161 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2162 quotes the next character, and doesn't affect other longer
2163 sequences (bug#8935).
2164
1d698799
LMI
2165 * lread.c (syms_of_lread): Clarify that is isn't only
2166 `eval-buffer' and `eval-defun' that's affected by
2167 `lexical-binding' (bug#8460).
2168
aa4b6df6
EZ
21692011-07-15 Eli Zaretskii <eliz@gnu.org>
2170
2171 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2172 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2173
5d856da6
PE
21742011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2175
ad6042bb
PE
2176 Fix minor problems found by static checking.
2177 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2178 (elsz): Now a signed constant, not a size_t var. We prefer signed
2179 types to unsigned, to avoid integer comparison confusion. Without
2180 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2181 "cannot optimize loop, the loop counter may overflow", a symptom
2182 of the confusion.
f00bbb22 2183 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2184 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2185
6468f31c
LMI
21862011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2187
49080b10
LMI
2188 * search.c (Fre_search_backward): Mention `case-fold-search' in
2189 all the re_search_* functions (bug#8138).
2190
6468f31c
LMI
2191 * keyboard.c (Fopen_dribble_file): Document when the file is
2192 closed (bug#8056).
2193
c965adc5
EZ
21942011-07-14 Eli Zaretskii <eliz@gnu.org>
2195
df9733bf
EZ
2196 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2197 bidi_cache_idx.
2198
0bb23927
EZ
2199 Support bidi reordering of display and overlay strings.
2200 * xdisp.c (compute_display_string_pos)
2201 (compute_display_string_end): Accept additional argument STRING.
2202 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2203 (reseat_to_string): Initialize bidi_it->string.s and
2204 bidi_it->string.schars.
2205 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2206 NULL (avoids a crash in bidi_paragraph_init).
2207 Initialize itb.string.lstring.
0bb23927
EZ
2208 (init_iterator): Call bidi_init_it only of a valid
2209 buffer position was specified. Initialize paragraph_embedding to
2210 L2R.
2211 (reseat_to_string): Initialize the bidi iterator.
2212 (display_string): If we need to ignore text properties of
2213 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2214 original value of -1 will not work with bidi.)
2215 (compute_display_string_pos): First arg is now struct
2216 `text_pos *'; all callers changed. Support display properties on
2217 Lisp strings.
2218 (compute_display_string_end): Support display properties on Lisp
2219 strings.
2220 (init_iterator, reseat_1, reseat_to_string): Initialize the
2221 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2222 when iterating on a string not from display properties).
640c8776
SM
2223 (compute_display_string_pos, compute_display_string_end):
2224 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2225 arrow keys.
2226 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2227 base_level_stop; instead, set base_level_stop to BEGV.
2228 Fixes crashes in vertical-motion.
0bb23927
EZ
2229 (next_element_from_buffer): Improve commentary for when
2230 the iterator is before prev_stop.
2231 (init_iterator): Initialize bidi_p from the default value of
2232 bidi-display-reordering, not from buffer-local value. Use the
2233 buffer-local value only if initializing for buffer iteration.
2234 (handle_invisible_prop): Support invisible properties on strings
2235 that are being bidi-reordered.
2236 (set_iterator_to_next): Support bidi reordering of C strings and
2237 Lisp strings.
2238 (next_element_from_string): Support bidi reordering of Lisp
2239 strings.
2240 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2241 (display_string): Support display of R2L glyph rows.
2242 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2243 (init_iterator): Don't initialize it->bidi_p for strings
2244 here.
2245 (reseat_to_string): Initialize it->bidi_p for strings here.
2246 (next_element_from_string, next_element_from_c_string)
2247 (next_element_from_buffer): Add xassert's for correspondence
2248 between IT's object being iterated and it->bidi_it.string
2249 structure.
2250 (face_before_or_after_it_pos): Support bidi iteration.
2251 (next_element_from_c_string): Handle the case of the first string
2252 character that is not the first one in the visual order.
2253 (get_visually_first_element): New function, refactored from common
2254 parts of next_element_from_buffer, next_element_from_string, and
2255 next_element_from_c_string.
2256 (tool_bar_lines_needed, redisplay_tool_bar)
2257 (display_menu_bar): Force left-to-right direction. Add a FIXME
2258 comment for making that be controlled by a user option.
2259 (push_it, pop_it): Save and restore the state of the
2260 bidi iterator. Save and restore the bidi_p flag.
2261 (pop_it): Iterate out of display property for string iteration as
2262 well.
2263 (iterate_out_of_display_property): Support iteration over strings.
2264 (handle_single_display_spec): Set up it->bidi_it for iteration
2265 over a display string, and call bidi_init_it.
2266 (handle_single_display_spec, next_overlay_string)
2267 (get_overlay_strings_1, push_display_prop): Set up the bidi
2268 iterator for displaying display or overlay strings.
2269 (forward_to_next_line_start): Don't use the shortcut if
2270 bidi-iterating.
2271 (back_to_previous_visible_line_start): If handle_display_prop
2272 pushed the iterator stack, restore the internal state of the bidi
2273 iterator by calling bidi_pop_it same number of times.
2274 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2275 and we are bidi-iterating, don't decrement the iterator position;
2276 instead, set the first_elt flag in the bidi iterator, to produce
2277 the same effect.
2278 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2279 (push_display_prop): xassert that we are iterating a buffer.
2280 (push_it, pop_it): Save and restore paragraph_embedding member.
2281 (handle_single_display_spec, next_overlay_string)
2282 (get_overlay_strings_1, reseat_1, reseat_to_string)
2283 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2284 correctly. Don't assume unibyte strings are not bidi-reordered.
2285 (compute_display_string_pos)
2286 (compute_display_string_end): Fix handling the case of C string.
2287 (push_it, pop_it): Save and restore from_disp_prop_p.
2288 (handle_single_display_spec, push_display_prop): Set the
2289 from_disp_prop_p flag.
2290 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2291 (pop_it): Call iterate_out_of_display_property only if we are
2292 popping after iteration over a string that came from a display
2293 property. Fix a typo in popping stretch info. Add an assertion
2294 for verifying that the iterator position is in sync with the bidi
2295 iterator.
2296 (handle_single_display_spec, get_overlay_strings_1)
2297 (push_display_prop): Fix initialization of paragraph direction for
2298 string when that of the parent object is not yet determined.
2299 (reseat_1): Call bidi_init_it to resync the bidi
2300 iterator with IT's position. (Bug#7616)
2301 (find_row_edges): If ROW->start.pos gives position
2302 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2303 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2304 Reset the from_disp_prop_p flag.
2305 (SAVE_IT, RESTORE_IT): New macros.
2306 (pos_visible_p, face_before_or_after_it_pos)
2307 (back_to_previous_visible_line_start)
2308 (move_it_in_display_line_to, move_it_in_display_line)
2309 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2310 (try_scrolling, redisplay_window, display_line): Use them when
2311 saving a temporary copy of the iterator and restoring it back.
2312 (back_to_previous_visible_line_start, reseat_1)
2313 (init_iterator): Empty the bidi cache "stack".
2314 (move_it_in_display_line_to): If iterator ended up at
2315 EOL, but we never saw any buffer positions smaller than
2316 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2317 motion in bidi-reordered lines.
2318 (move_it_in_display_line_to): Record prev_method and prev_pos
2319 immediately before the call to set_iterator_to_next. Fixes cursor
2320 motion in bidi-reordered lines with stretch glyphs and strings
2321 displayed in margins. (Bug#8133) (Bug#8867)
2322 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2323 TO_CHARPOS.
640c8776
SM
2324 (pos_visible_p): Support positions in bidi-reordered lines.
2325 Save and restore bidi cache.
0bb23927
EZ
2326
2327 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2328 (bidi_paragraph_info): Delete unused struct.
2329 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2330 (bidi_cache_start): New variable.
2331 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2332 to zero.
2333 (bidi_cache_fetch_state, bidi_cache_search)
2334 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2335 (bidi_cache_find, bidi_peek_at_next_level)
2336 (bidi_level_of_next_char, bidi_find_other_level_edge)
2337 (bidi_move_to_visually_next): Compare cache index with
2338 bidi_cache_start rather than with zero.
2339 (bidi_fetch_char): Accept new argument STRING; all callers
2340 changed. Support iteration over a string. Support strings with
2341 display properties. Support unibyte strings. Fix the type of
2342 `len' according to what STRING_CHAR_AND_LENGTH expects.
2343 (bidi_paragraph_init, bidi_resolve_explicit_1)
2344 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2345 (bidi_level_of_next_char, bidi_move_to_visually_next):
2346 Support iteration over a string.
0bb23927
EZ
2347 (bidi_set_sor_type, bidi_resolve_explicit_1)
2348 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2349 can now be zero (for strings); special values 0 and -1 were
2350 changed to -1 and -2, respectively.
2351 (bidi_char_at_pos): New function.
2352 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2353 Call it instead of FETCH_MULTIBYTE_CHAR.
2354 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2355 initialized to valid values.
2356 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2357 values.
2358 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2359 the test for valid cached positions. Fix the logic for looking up
2360 the sentinel state in the cache. GCPRO the Lisp string we are
2361 iterating.
2362 (bidi_push_it, bidi_pop_it): New functions.
2363 (bidi_initialize): Initialize the bidi cache start stack pointer.
2364 (bidi_cache_ensure_space): New function, refactored from part of
2365 bidi_cache_iterator_state. Don't assume the required size is just
2366 one BIDI_CACHE_CHUNK away.
2367 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2368 (bidi_count_bytes, bidi_char_at_pos): New functions.
2369 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2370 always valid if bidi_cache_idx is valid.
2371 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2372 is valid if it's going to be used.
2373 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2374 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2375 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2376 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2377 (bidi_find_other_level_edge, bidi_cache_start_stack):
2378 All variables related to cache indices are now EMACS_INT.
c965adc5 2379
0bb23927
EZ
2380 * dispextern.h (struct bidi_string_data): New structure.
2381 (struct bidi_it): New member `string'. Make flag members be 1-bit
2382 fields, and put them last in the struct.
640c8776
SM
2383 (compute_display_string_pos, compute_display_string_end):
2384 Update prototypes.
0bb23927
EZ
2385 (bidi_push_it, bidi_pop_it): Add prototypes.
2386 (struct iterator_stack_entry): New members bidi_p,
2387 paragraph_embedding, and from_disp_prop_p.
2388 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2389 (bidi_shelve_cache, bidi_unshelve_cache):
2390 Declare prototypes.
0bb23927
EZ
2391
2392 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2393 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2394 and vector-like objects.
2395
2396 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2397 cache around display iteration.
2398
2399 * window.c (Fwindow_end, window_scroll_pixel_based)
2400 (displayed_window_lines, Frecenter): Save and restore the bidi
2401 cache around display iteration.
2402
3bbd2265
LMI
24032011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2404
2405 * editfns.c (Fdelete_region): Clarify the use of the named
2406 parameters (bug#6788).
2407
adc47434
MR
24082011-07-14 Martin Rudalics <rudalics@gmx.at>
2409
2410 * indent.c (Fvertical_motion): Set and restore w->pointm when
2411 saving and restoring the window's buffer (Bug#9006).
2412
837c31f8
LMI
24132011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2414
2415 * editfns.c (Fstring_to_char): Clarify just what is returned
2416 (bug#6576). Text by Eli Zaretskii.
2417
ac389d0c
JB
24182011-07-13 Juanma Barranquero <lekktu@gmail.com>
2419
2420 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2421
0be0ce47
EZ
24222011-07-13 Eli Zaretskii <eliz@gnu.org>
2423
2424 * buffer.c (mmap_find): Fix a typo.
2425
cd18e7e3
JB
24262011-07-13 Johan Bockgård <bojohan@gnu.org>
2427
2428 Fix execution of x selection hooks.
2429 * xselect.c (Qx_lost_selection_functions)
2430 (Qx_sent_selection_functions): New vars.
2431 (syms_of_xselect): DEFSYM them.
2432 (x_handle_selection_request): Pass Qx_sent_selection_functions
2433 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2434 (x_handle_selection_clear,x_clear_frame_selections):
2435 Pass Qx_lost_selection_functions rather than
2436 Vx_lost_selection_functions to Frun_hook_with_args.
2437
47ea7f44
PE
24382011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2439
ac389d0c 2440 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2441 The old code sometimes used this field without initializing it.
2442
47ea7f44
PE
2443 * alloc.c (gc_sweep): Don't read past end of array.
2444 In theory, the old code could also have corrupted Emacs internals,
2445 though it'd be very unlikely.
2446
bc985c87
AS
24472011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2448
2449 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2450 argument. (Bug#4026)
bc985c87 2451
0cf34688
LMI
24522011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2453
b3dadd76
LMI
2454 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2455 key" (bug#4257).
2456
0cf34688
LMI
2457 * window.c (Fset_window_start): Doc fix (bug#4199).
2458 (Fset_window_hscroll): Ditto.
2459
270768cd
PE
24602011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2461
077e3dda 2462 Fix minor new problems caught by GCC 4.6.1.
270768cd 2463 * term.c (init_tty): Remove unused local.
490011a6 2464 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2465 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2466 not used otherwise.
270768cd 2467
b1f58454
CY
24682011-07-12 Chong Yidong <cyd@stupidchicken.com>
2469
2470 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2471
22b9578d
LMI
24722011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2473
6e70ab07
LMI
2474 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2475 are the mini-buffer and the echo area (bug#3320).
2476
22b9578d
LMI
2477 * term.c (init_tty): Remove support for supdup, c10 and perq
2478 terminals, which are no longer supported (bug#1482).
2479
8974cc9f
JB
24802011-07-10 Johan Bockgård <bojohan@gnu.org>
2481
2482 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2483
a560d974
JD
24842011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2485
2486 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2487 for non-popups (Bug#3642).
2488
1dae0f0a
AS
24892011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2490
268c2c36 2491 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2492 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2493 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2494 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2495 * data.c (fmod): Likewise.
2496 * dispnew.c (swap_glyphs_in_rows): Likewise.
2497 * emacs.c (memory_warning_signal): Likewise.
2498 * floatfns.c (float_error): Likewise.
2499 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2500 (otf_open, font_otf_capability, generate_otf_features)
2501 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2502 Likewise.
2503 * image.c (pbm_read_file): Likewise.
2504 * indent.c (string_display_width): Likewise.
2505 * intervals.c (check_for_interval, search_for_interval)
2506 (inc_interval_count, count_intervals, root_interval)
2507 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2508 * lread.c (defalias): Likewise.
268c2c36 2509 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2510 * regex.c (set_image_of_range_1, set_image_of_range)
2511 (regex_grow_registers): Likewise.
2512 * sysdep.c (strerror): Likewise.
2513 * termcap.c (valid_filename_p, tprint, main): Likewise.
2514 * tparam.c (main): Likewise.
2515 * unexhp9k800.c (run_time_remap, save_data_space)
2516 (update_file_ptrs, read_header, write_header, calculate_checksum)
2517 (copy_file, copy_rest, display_header): Likewise.
2518 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2519 Likewise.
2520 * xdisp.c (check_it): Likewise.
2521 * xfaces.c (register_color, unregister_color, unregister_colors):
2522 Likewise.
2523 * xfns.c (print_fontset_result): Likewise.
2524 * xrdb.c (member, fatal, main): Likewise.
2525
99033785
PE
25262011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2527
2528 Fix minor problems found by static checking (Bug#9031).
2529 * chartab.c (char_table_set_range, map_sub_char_table):
2530 Remove unused locals.
2531 (uniprop_table): Now static.
2532 * composite.c (_work_char): Remove unused static var.
2533
9cb2ac56
JB
25342011-07-09 Juanma Barranquero <lekktu@gmail.com>
2535
2536 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2537
f25661f0
JD
25382011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2539
2540 * gtkutil.c (qttip_cb): Remove code without function.
2541
8278c4fe
EZ
25422011-07-09 Eli Zaretskii <eliz@gnu.org>
2543
2544 * w32.c (pthread_sigmask): New stub.
2545
1692ae2d 25462011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2547
8a6ebd58 2548 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2549 sigprocmask is portable only for single-threaded applications, and
2550 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2551 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2552 (LIBES): Use it.
2553 * callproc.c (Fcall_process):
2554 * process.c (create_process):
2555 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2556 Use pthread_sigmask, not sigprocmask.
123403e4 2557
1b854618
JD
25582011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2559
2560 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2561 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2562 wrong (Bug#8591).
2563
3fe4b549
JD
25642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2565
0ce7e563
JD
2566 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2567 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2568 (xg_hide_tooltip): Fix comment.
2569
3fe4b549
JD
2570 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2571 in registerServicesMenuSendTypes.
2572 (validRequestorForSendType): Don't check ns_return_types.
2573
2574 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2575 ns_return_type.
2576
5df75e47
JR
25772011-07-08 Jason Rumney <jasonr@gnu.org>
2578
2579 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2580 frame struct members of non-existent frames (Bug#6284).
2581
699c10bd
JD
25822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2583
4393663b
JD
2584 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2585 variable firstTime not needed on OSX >= 10.6.
2586 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2587 >= 10.5. Use setKnobProportion, setDoubleValue.
2588
2589 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2590 (MAC_OS_X_VERSION_10_5): Define if not defined.
2591 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2592 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2593 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2594
2595 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2596 cString and lossyCString on OSX >= 10.4
2597
2598 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2599 sizeToFit on OSX >= 10.2.
2600
2601 * nsimage.m (allocInitFromFile): Don't use deprecated method
2602 bestRepresentationForDevice on OSX >= 10.6.
2603
2604 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2605 to avoid warning.
2606
2607 * emacs.c: Declare unexec_init_emacs_zone.
2608
a63e0781
JD
2609 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2610
699c10bd
JD
2611 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2612
2613 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2614 on svcsMenu (Bug#8842).
2615
2616 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2617 ns_return_types.
2618 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2619
2620 * nsterm.m (QUTF8_STRING): Declare.
2621 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2622 (validRequestorForSendType): Return type is (id).
2623 Change indexOfObjectIdenticalTo to indexOfObject.
2624 Check if we have local selection before returning self (Bug#8842).
2625 (writeSelectionToPasteboard): Put local selection into paste board
2626 if we have a local selection (Bug#8842).
2627 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2628
2629 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2630 (ns_get_local_selection): Declare.
2631
54e10184
LMI
26322011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2633
9888ff71
LMI
2634 * keymap.c (describe_map_tree): Don't insert a double newline at
2635 the end of the buffer (bug#1169) and return whether we inserted
2636 something.
2637
54e10184
LMI
2638 * callint.c (Fcall_interactively): Change "reading args" to
2639 "providing args" to try to clarify what it does (bug#1010).
2640
15fa4783
KH
26412011-07-07 Kenichi Handa <handa@m17n.org>
2642
2643 * composite.c (composition_compute_stop_pos): Ignore a static
2644 composition starting before CHARPOS (Bug#8915).
2645
2646 * xdisp.c (handle_composition_prop): Likewise.
2647
a8815b00
EZ
26482011-07-07 Eli Zaretskii <eliz@gnu.org>
2649
2650 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2651 (Bug#9015)
2652
ef7b981d 26532011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2654
2655 * character.h (unicode_category_t): New enum type.
2656
2657 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2658 (Qchar_code_property_table): New variable.
2659 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2660 (UNIPROP_COMPRESSED_FORM_P): New macros.
2661 (char_table_ascii): Uncompress the compressed values.
2662 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2663 Uncompress the compressed values.
ac389d0c 2664 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2665 (char_table_ref_and_range): Uncompress the compressed values.
2666 (sub_char_table_set): New arg is_uniprop. Callers changed.
2667 Uncompress the compressed values.
2668 (sub_char_table_set_range): Args changed. Callers changed.
2669 (char_table_set_range): Adjuted for the above change.
2670 (map_sub_char_table): Delete args default_val and parent. Add arg
2671 top. Give decoded values to a Lisp function.
640c8776 2672 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2673 values to a Lisp function. Gcpro more variables.
2674 (uniprop_table_uncompress)
2675 (uniprop_decode_value_run_length): New functions.
2676 (uniprop_decoder, uniprop_decoder_count): New variables.
2677 (uniprop_get_decoder, uniprop_encode_value_character)
2678 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2679 New functions.
2680 (uniprop_encoder, uniprop_encoder_count): New variables.
2681 (uniprop_get_encoder, uniprop_table)
2682 (Funicode_property_table_internal, Fget_unicode_property_internal)
2683 (Fput_unicode_property_internal): New functions.
2684 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2685 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2686 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2687 char-code-property-alist.
2688
640c8776 2689 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2690 Vunicode_category_table.
2691
640c8776 2692 * font.c (font_range): Adjust for the change of
c805dec0
KH
2693 Vunicode_category_table.
2694
76b397fb
DN
26952011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2696
2697 * m/iris4d.h: Remove file, move contents ...
2698 * s/irix6-5.h: ... here.
2699
22b4128e
PE
27002011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2701
2702 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2703 * alloc.c (mark_buffer):
2704 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2705 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2706 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2707 This isn't true in general, and it's particularly not true
2708 if Emacs is configured with --with-wide-int.
2709 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2710 New macros, used in the buffer.c change.
2711
869795d6
JD
27122011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2713
2714 * xsettings.c: Use both GConf and GSettings if both are available.
2715 (store_config_changed_event): Add comment.
2716 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2717 (store_tool_bar_style_changed): New functions.
5e617bc2 2718 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2719 (struct xsettings): Move font inside HAVE_XFT.
2720 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2721 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2722 Move inside HAVE_XFT.
640c8776 2723 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2724 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2725 also.
2726 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2727 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2728 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2729 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2730 (parse_settings): Move check for font inside HAVE_XFT.
2731 (read_settings, apply_xft_settings): Add comment.
2732 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2733 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2734 call store_font_name_changed.
2735 (xft_settings_event): Add comment.
2736 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2737 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2738 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2739 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2740 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2741 (xsettings_get_system_font, xsettings_get_system_normal_font):
2742 Add comment.
869795d6 2743
d8ed26bd
PE
27442011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2745
2746 Random fixes. E.g., (random) never returned negative values.
2747 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2748 subseconds part to the entropy, as that's a bit more random.
2749 Prefer signed to unsigned, since the signedness doesn't matter and
2750 in general we prefer signed. When given a limit, use a
2751 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2752 latter isn't right if USE_2_TAGS_FOR_INTS.
2753 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2754 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2755
cabf1cac
SM
27562011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2757
2758 * textprop.c (text_property_stickiness):
2759 Obey Vtext_property_default_nonsticky.
2760 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2761 * w32fns.c (syms_of_w32fns):
2762 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2763
6e9b2be9
PE
27642011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2765
2766 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2767 This is more efficient than Ffile_directory_p and avoids a minor race.
2768
90186c68
LMI
27692011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2770
7c301272
LMI
2771 * buffer.c (Foverlay_put): Say what the return value is
2772 (bug#7835).
2773
c4f2d8d4
LMI
2774 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2775 is a directory before asking whether to use the file name
2776 (bug#7564).
ad637907
LMI
2777 (barf_or_query_if_file_exists): Make the "File is a directory"
2778 error be more correct.
c4f2d8d4 2779
90186c68
LMI
2780 * fns.c (Frequire): Remove the mention of the .gz files, since
2781 that's installation-specific, but keep the mention of
2782 `get-load-suffixes'.
2783
da64016e
PE
27842011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2785
2786 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2787 Report string overflow if the output is too long.
2788
7d47b580
JB
27892011-07-04 Juanma Barranquero <lekktu@gmail.com>
2790
a555cb87
JB
2791 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2792 (syms_of_gnutls): Remove duplicate DEFSYM for
2793 Qgnutls_bootprop_verify_hostname_error, an error for
2794 Qgnutls_bootprop_verify_error (which is no longer used).
2795
7d47b580
JB
2796 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2797 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2798 Also (re)move comments that are misplaced or no longer relevant.
2799
1e49bfab
LMI
28002011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2801
2802 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2803
1485f4c0
CY
28042011-07-03 Chong Yidong <cyd@stupidchicken.com>
2805
2806 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2807 and background color parameters if they have been changed.
2808
a9ab721e
LMI
28092011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2810
2811 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2812
cf7cff57
PE
28132011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2814
2e13213d
PE
2815 * xsettings.c (SYSTEM_FONT): Define only when used.
2816 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2817
cf7cff57
PE
2818 * keymap.c (access_keymap_1): Now static.
2819
7a8e04f7
CY
28202011-07-02 Chong Yidong <cyd@stupidchicken.com>
2821
2822 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2823 leave any prefix arg for the up event (Bug#1586).
2824
61352f62
LMI
28252011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2826
69bb1ef7
LMI
2827 * lread.c (syms_of_lread): Mention single symbols defined by
2828 `defvar' or `defconst' (bug#7154).
2829
61352f62 2830 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2831 (Frequire): Mention get-load-suffixes.
61352f62 2832
28545e04
MR
28332011-07-02 Martin Rudalics <rudalics@gmx.at>
2834
2835 * window.h (window): Remove clone_number slot.
2836 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2837 Remove.
2838 (make_parent_window, make_window, saved_window)
2839 (Fset_window_configuration, save_window_save): Don't deal with
2840 clone numbers.
2841 * buffer.c (Qclone_number): Remove declaration.
2842 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2843
3349e122
SM
28442011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2845
2846 Add multiple inheritance to keymaps.
2847 * keymap.c (Fmake_composed_keymap): New function.
2848 (Fset_keymap_parent): Simplify.
2849 (fix_submap_inheritance): Remove.
2850 (access_keymap_1): New function extracted from access_keymap to handle
2851 embedded parents and handle lists of maps.
2852 (access_keymap): Use it.
2853 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2854 (Fcopy_keymap): Handle embedded parents.
2855 (Fcommand_remapping, define_as_prefix): Simplify.
2856 (Fkey_binding): Simplify.
2857 (syms_of_keymap): Move minibuffer-local-completion-map,
2858 minibuffer-local-filename-completion-map,
2859 minibuffer-local-must-match-map, and
2860 minibuffer-local-filename-must-match-map to Elisp.
2861 (syms_of_keymap): Defsubr make-composed-keymap.
2862 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2863 (parse_menu_item): Trivial simplification.
2864
3279eb87
GM
28652011-07-01 Glenn Morris <rgm@gnu.org>
2866
2867 * Makefile.in (SETTINGS_LIBS): Fix typo.
2868
4550efdf
KI
28692011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2870
2871 * coding.c (Fencode_coding_string): Record the last coding system
2872 used, as the function doc string says (bug#8738).
2873
0949d2b6
JD
28742011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2875
2876 * xsettings.c (store_monospaced_changed): Take new font as arg and
2877 check for change against current_mono_font.
2878 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2879 (emacs_settings_constructor, emacs_settings_get_property)
2880 (emacs_settings_set_property, emacs_settings_class_init)
2881 (emacs_settings_init, gsettings_obj): Remove.
2882 (something_changedCB): New function for HAVE_GSETTINGS.
2883 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2884 with value as argument.
2885 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2886 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2887 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2888 "changed".
2889
2890 * xgselect.c: Add defined (HAVE_GSETTINGS).
2891 (xgselect_initialize): Ditto.
2892
2893 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2894 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2895 xg_select.
2896
bbc6b304
PE
28972011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2898
2899 * eval.c (struct backtrace): Simplify and port the data structure.
2900 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2901 signed bit field, as this assumption is not portable and it makes
2902 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2903 "char debug_on_exit : 1" as this is not portable either; instead,
2904 use the portable "unsigned int debug_on_exit : 1". Remove unused
2905 member evalargs. Remove obsolete comments about cc bombing out.
2906
9851bfc5
JD
29072011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2908
51bb811f 2909 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2910 Let HAVE_GSETTINGS override HAVE_GCONF.
2911 (store_monospaced_changed): New function.
2912 (EMACS_SETTINGS): A new type derived from GObject to handle
2913 GSettings notifications.
2914 (emacs_settings_constructor, emacs_settings_get_property)
2915 (emacs_settings_set_property, emacs_settings_class_init):
2916 New functions.
2917 (gsettings_client, gsettings_obj): New variables.
2918 (GSETTINGS_SCHEMA): New define.
2919 (something_changedCB): Call store_monospaced_changed.
2920 (init_gsettings): New function.
2921 (xsettings_initialize): Call init_gsettings.
2922 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2923 to NULL.
2924
640c8776 2925 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2926 GCONF_CFLAGS/LIBS.
2927
5386012d
MR
29282011-06-29 Martin Rudalics <rudalics@gmx.at>
2929
2930 * window.c (resize_root_window, grow_mini_window)
2931 (shrink_mini_window): Rename Qresize_root_window to
2932 Qwindow_resize_root_window and Qresize_root_window_vertically to
2933 Qwindow_resize_root_window_vertically.
2934
f13e0b08
PE
29352011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2936
2937 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2938
94515237
JB
29392011-06-27 Juanma Barranquero <lekktu@gmail.com>
2940
2941 * makefile.w32-in: Redesign dependencies so they reflect more
2942 clearly which files are directly included by each source file,
2943 and not through other includes.
2944
e43b6e43
MR
29452011-06-27 Martin Rudalics <rudalics@gmx.at>
2946
2947 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2948 (sort_overlays, overlay_strings): When an overlay's clone number
2949 matches the window's clone number process the overlay even if
2950 the overlay's window property doesn't match the current window.
2951
d68443dc
MR
2952 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2953 (Fwindow_hchild): Rename to Fwindow_left_child.
2954 (Fwindow_next): Rename to Fwindow_next_sibling.
2955 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2956 (resize_window_check): Rename to window_resize_check.
2957 (resize_window_apply): Rename to window_resize_apply.
2958 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2959 (Fdelete_other_windows_internal, resize_frame_windows)
2960 (Fsplit_window_internal, Fdelete_window_internal)
2961 (grow_mini_window, shrink_mini_window)
2962 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2963
c7e73be5
JD
29642011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2965
2966 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2967 (emacs_fixed_set_min_size): Remove.
2968 (emacs_fixed_new): Take frame as argument.
2969
2970 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2971 (_EmacsFixedPrivate): Remove minwidth/height.
2972 Add struct frame *f.
2973 (emacs_fixed_init): Initialize priv->f.
2974 (get_parent_class, emacs_fixed_set_min_size): Remove.
2975 (emacs_fixed_new): Set priv->f to argument.
2976 (emacs_fixed_get_preferred_width)
2977 (emacs_fixed_get_preferred_height): Use min_width/height from
2978 frames size_hint to set minimum and natural (Bug#8919).
2979 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2980 and use min_width/height from frames size_hint to set
2981 min_width/height (Bug#8919).
2982
2983 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2984 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2985 Fix indentation.
c7e73be5 2986
cf99dcf8
EZ
29872011-06-26 Eli Zaretskii <eliz@gnu.org>
2988
2989 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2990 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2991 called at ZV.
2992
029529ac
CY
29932011-06-26 Chong Yidong <cyd@stupidchicken.com>
2994
2995 * process.c (wait_reading_process_output): Bypass select if
2996 waiting for a cell while ignoring keyboard input, and input is
2997 pending. Suggested by Jan Djärv (Bug#8869).
2998
7a7ef429
PE
29992011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3000
3001 Use gnulib's dup2 module instead of rolling our own.
3002 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3003
11fdef7d 30042011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3005
3006 * dispnew.c (scrolling_window): Before scrolling, turn off a
3007 mouse-highlight in the window being scrolled.
3008
cd3520a4
JB
30092011-06-24 Juanma Barranquero <lekktu@gmail.com>
3010
3011 Move DEFSYM to lisp.h and use everywhere.
3012
3013 * character.h (DEFSYM): Move declaration...
3014 * lisp.h (DEFSYM): ...here.
3015
3016 * gnutls.c:
3017 * minibuf.c:
3018 * w32menu.c:
3019 * w32proc.c:
3020 * w32select.c: Don't include character.h.
3021
3022 * alloc.c (syms_of_alloc):
3023 * buffer.c (syms_of_buffer):
3024 * bytecode.c (syms_of_bytecode):
3025 * callint.c (syms_of_callint):
3026 * casefiddle.c (syms_of_casefiddle):
3027 * casetab.c (init_casetab_once):
3028 * category.c (init_category_once, syms_of_category):
3029 * ccl.c (syms_of_ccl):
3030 * cmds.c (syms_of_cmds):
3031 * composite.c (syms_of_composite):
3032 * dbusbind.c (syms_of_dbusbind):
3033 * dired.c (syms_of_dired):
3034 * dispnew.c (syms_of_display):
3035 * doc.c (syms_of_doc):
3036 * editfns.c (syms_of_editfns):
3037 * emacs.c (syms_of_emacs):
3038 * eval.c (syms_of_eval):
3039 * fileio.c (syms_of_fileio):
3040 * fns.c (syms_of_fns):
3041 * frame.c (syms_of_frame):
3042 * fringe.c (syms_of_fringe):
3043 * insdel.c (syms_of_insdel):
3044 * keymap.c (syms_of_keymap):
3045 * lread.c (init_obarray, syms_of_lread):
3046 * macros.c (syms_of_macros):
3047 * msdos.c (syms_of_msdos):
3048 * print.c (syms_of_print):
3049 * process.c (syms_of_process):
3050 * search.c (syms_of_search):
3051 * sound.c (syms_of_sound):
3052 * syntax.c (init_syntax_once, syms_of_syntax):
3053 * terminal.c (syms_of_terminal):
3054 * textprop.c (syms_of_textprop):
3055 * undo.c (syms_of_undo):
3056 * w32.c (globals_of_w32):
3057 * window.c (syms_of_window):
3058 * xdisp.c (syms_of_xdisp):
3059 * xfaces.c (syms_of_xfaces):
3060 * xfns.c (syms_of_xfns):
3061 * xmenu.c (syms_of_xmenu):
3062 * xsettings.c (syms_of_xsettings):
3063 * xterm.c (syms_of_xterm): Use DEFSYM.
3064
4228cf16
TZ
30652011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3066
cd3520a4 3067 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3068
7fcccf1e
PE
30692011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3070
7efb4e0e
PE
3071 Integer and buffer overflow fixes (Bug#8873).
3072
ff5844ad
PE
3073 * print.c (printchar, strout): Check for string overflow.
3074 (PRINTPREPARE, printchar, strout):
3075 Don't set size unless allocation succeeds.
3076
90532f02
PE
3077 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3078 for sizes. Check for string overflow more accurately.
3079 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3080
6d84508d
PE
3081 * macros.c: Integer and buffer overflow fixes.
3082 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3083 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3084 Use ptrdiff_t, not int, for sizes.
3085 Don't increment bufsize until after realloc succeeds.
3086 Check for size-calculation overflow.
3087 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3088
437b2cb4
PE
3089 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3090
8b9ac8b4
PE
3091 * lread.c: Integer overflow fixes.
3092 (read_integer): Radix is now EMACS_INT, not int,
3093 to improve quality of diagnostics for out-of-range radices.
3094 Calculate buffer size correctly for out-of-range radices.
3095 (read1): Check for integer overflow in radices, and in
3096 read-circle numbers.
82cb60d3
PE
3097 (read_escape): Avoid int overflow.
3098 (Fload, openp, read_buffer_size, read1)
3099 (substitute_object_recurse, read_vector, read_list, map_obarray):
3100 Use ptrdiff_t, not int, for sizes.
3101 (read1): Use EMACS_INT, not int, for sizes.
20270765 3102 Check for size overflow.
8b9ac8b4 3103
7fcccf1e
PE
3104 * image.c (cache_image): Check for size arithmetic overflow.
3105
bfbbd7e7
PE
3106 * lread.c: Integer overflow issues.
3107 (saved_doc_string_size, saved_doc_string_length)
3108 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3109 Now ptrdiff_t, not int.
3110 (read1): Don't assume doc string length fits in int. Check for
3111 out-of-range doc string lengths.
3112 (read_list): Don't assume file position fits in int.
39019e54 3113 (read_escape): Check for hex character overflow.
bfbbd7e7 3114
4e323265
LL
31152011-06-22 Leo Liu <sdl.web@gmail.com>
3116
3117 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3118 Move to minibuffer.el.
3119
85fece3e
PE
31202011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3121
20b84ce9 3122 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3123 The following patches are for when GLYPH_DEBUG && !XASSERT.
3124 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3125 * dispnew.c (flush_stdout):
3126 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3127 Mark as externally visible.
3128 * dispnew.c (check_window_matrix_pointers): Now static.
3129 * dispnew.c (window_to_frame_vpos):
3130 * xfns.c (unwind_create_frame):
3131 * xterm.c (x_check_font): Remove unused local.
3132 * scroll.c (CHECK_BOUNDS):
3133 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3134 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3135 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3136 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3137 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3138 Now static.
3139 (debug_method_add): Use va_list and vsprintf rather than relying
3140 on undefined behavior with wrong number of arguments.
3141 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3142 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3143 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3144 since we're not interested in debugging glyphs with old libraries.
3145 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3146 GCC 4.6.0's static checking.
3147
0766b489
PE
31482011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3149
31fd4b32
PE
3150 Integer overflow and signedness fixes (Bug#8873).
3151 A few related buffer overrun fixes, too.
3152
b79e8648
PE
3153 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3154
0766b489
PE
3155 * dispextern.h (struct face.stipple):
3156 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3157 (x_bitmap_mask, x_allocate_bitmap_record)
3158 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3159 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3160 (x_create_bitmap_from_xpm_data):
3161 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3162 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3163 (.bitmaps_last):
3164 * xfaces.c (load_pixmap):
3165 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3166 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3167 (.bitmaps_last, struct x_output.icon_bitmap):
3168 Use ptrdiff_t, not int, for bitmap indexes.
3169 (x_allocate_bitmap_record): Check for size overflow.
3170 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3171
b081724f
PE
3172 Use ptrdiff_t, not int, for overlay counts.
3173 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3174 * editfns.c (overlays_around, get_pos_property):
3175 * textprop.c (get_char_property_and_overlay):
3176 * xdisp.c (next_overlay_change, note_mouse_highlight):
3177 * xfaces.c (face_at_buffer_position):
21514da7
PE
3178 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3179 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3180 (Fnext_overlay_change, Fprevious_overlay_change)
3181 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3182 Use ptrdiff_t, not int, for sizes.
21514da7 3183 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3184
3de73e5e
PE
3185 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3186
2606c57b
PE
3187 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3188 (x_session_initialize): Do not assume string length fits in int.
3189
aaafe47a
PE
3190 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3191 This is unlikely, but can occur if DPI is outlandish.
3192
2674ddc8 3193 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3194 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3195
28154962
PE
3196 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3197 * xrdb.c (magic_file_p, search_magic_path):
3198 Omit last arg SUFFIX; it was always 0. All callers changed.
3199 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3200
7de51af5
PE
3201 * xfont.c (xfont_match): Avoid need for strlen.
3202
25ed6cc3
PE
3203 * xfns.c: Don't assume strlen fits in int.
3204 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3205
4eab31dd
PE
3206 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3207 not unsigned long, as we prefer signed integers. All callers changed.
3208 Detect integer overflow in repeat count.
3209 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3210 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3211
171e2a58
PE
3212 * termcap.c: Don't assume sizes fit in int and never overflow.
3213 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3214 (gobble_line): Check for size-calculation overflow.
3215
ad39faca 3216 * minibuf.c (Fread_buffer):
6e5bb2dc 3217 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3218 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3219 Don't assume string length fits in int.
3220
52c61c22 3221 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3222 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3223
b5b8c9e5
PE
3224 * font.c: Don't assume string length fits in int.
3225 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3226 Use ptrdiff_t, not int.
ccd6111c
PE
3227 (font_intern_prop): Don't assume string length fits in int.
3228 Don't assume integer property fits in fixnum.
3229 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3230
882f0d81 3231 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3232 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3233 Reformulate so as not to need the command string.
3234 Invoke gzip -cd rather than gunzip, as it's more portable.
3235 (lock_info_type, lock_file_1, lock_file):
3236 Don't assume pid_t and time_t fit in unsigned long.
3237 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3238 (current_lock_owner): Prefer signed type for sizes.
3239 Use memcpy, not strncpy, where memcpy is what is really wanted.
3240 Don't assume (via atoi) that time_t and pid_t fit in int.
3241 Check for time_t and/or pid_t out of range, e.g., via a network share.
3242 Don't alloca where an auto var works fine.
3243
93f4cf88
PE
3244 * fileio.c: Fix some integer overflow issues.
3245 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3246 Don't assume string length fits in int.
3247 (directory_file_name): Don't assume string length fits in long.
3248 (make_temp_name): Don't assume pid fits in int, or that its print
3249 length is less than 20.
3250
f3e92b69
PE
3251 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3252
1bfdaf10
PE
3253 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3254
35016e9a
PE
3255 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3256
3d1e65a1
PE
3257 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3258 We prefer signed integers, even for size calculations.
3259
0b963a93
PE
3260 * emacs.c: Don't assume string length fits in 'int'.
3261 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3262 (main): Don't invoke strlen when not needed.
3263
573f4b54
PE
3264 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3265 (XD_DEBUG_MESSAGE): Don't waste a byte.
3266
989f33ba
PE
3267 * callproc.c (getenv_internal_1, getenv_internal)
3268 (Fgetenv_internal):
965d34eb
PE
3269 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3270
e4d29b33
PE
3271 * lread.c (invalid_syntax): Omit length argument.
3272 All uses changed. This doesn't fix a bug, but it simplifies the
3273 code away from its former Hollerith-constant appearance, and it's
3274 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3275 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3276
eb49b136
PE
3277 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3278 This didn't break anything, but it didn't help either.
3279 It's confusing to put a bogus integer in a place where the actual
3280 value does not matter.
9f62aeb1 3281 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3282 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3283
15375a22
PE
3284 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3285 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3286 implementation.
b61cc01c
PE
3287 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3288 We prefer signed types, and the value cannot exceed the EMACS_INT
3289 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3290 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3291 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3292 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3293
53b2623d
PE
3294 * indent.c (sane_tab_width): New function.
3295 (current_column, scan_for_column, Findent_to, position_indentation)
3296 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3297 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3298
51cab52b 3299 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3300
f2ed8a70
PE
3301 * lisp.h (lint_assume): New macro.
3302 * composite.c (composition_gstring_put_cache):
3303 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3304
abe80cc6
PE
3305 * editfns.c, insdel.c:
3306 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3307
b02c740e
PE
3308 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3309
ebc96716
PE
3310 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3311
b4e50fa0 3312 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3313 Use much-faster test for byte-length change.
311d5d7c 3314 Don't assume string byte-length fits in 'int'.
a4cf38e4 3315 Check that character arg fits in 'int'.
85461888 3316 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3317
c0c1ee9f
PE
3318 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3319
a498d7f4
PE
3320 * fns.c (concat): Catch string overflow earlier.
3321 Do not rely on integer wraparound.
3322
51cab52b
PE
3323 * dispextern.h (struct it.overlay_strings_charpos)
3324 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3325 * xdisp.c (forward_to_next_line_start)
3326 (back_to_previous_visible_line_start)
3327 (reseat_at_next_visible_line_start, next_element_from_buffer):
3328 Don't arbitrarily truncate the value of 'selective' to int.
3329
76031fad
PE
3330 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3331
5eb55db9
PE
3332 * composite.c: Don't truncate sizes to 'int'.
3333 (composition_gstring_p, composition_reseat_it)
3334 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3335 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3336 not EMACS_UINT, for indexes.
5eb55db9 3337
0703a717
PE
3338 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3339
d6202519
PE
3340 * buffer.c: Include <verify.h>.
3341 (struct sortvec.priority, struct sortstr.priority):
8961a454 3342 Now EMACS_INT, not int.
c20998a7 3343 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3344 (struct sortstr.size, record_overlay_string)
3345 (struct sortstrlist.size, struct sortlist.used):
3346 Don't truncate size to int.
3347 (record_overlay_string): Check for size-calculation overflow.
d6202519 3348 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3349
d5a19415
JM
33502011-06-22 Jim Meyering <meyering@redhat.com>
3351
029529ac 3352 Don't leak an XBM-image-sized buffer
d5a19415
JM
3353 * image.c (xbm_load): Free the image buffer after using it.
3354
a9041e6c
PE
33552011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3356
3357 Port to Sun C.
3358 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3359 that Sun C diagnosed.
3360 * fns.c (secure_hash): Fix pointer signedness issue.
3361 * intervals.c (static_offset_intervals): New function.
3362 (offset_intervals): Use it.
3363
7f3f739f
LL
33642011-06-21 Leo Liu <sdl.web@gmail.com>
3365
3366 * deps.mk (fns.o):
3367 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3368 sha512.h.
3369
3370 * fns.c (secure_hash): Rename from crypto_hash_function and change
3371 the first arg to accept symbols.
5b66d427 3372 (Fsecure_hash): New primitive.
7f3f739f
LL
3373 (syms_of_fns): New symbols.
3374
76147d94
DD
33752011-06-20 Deniz Dogan <deniz@dogan.se>
3376
3377 * process.c (Fset_process_buffer): Clarify return value in
3378 docstring.
3379
7d7d0045
CY
33802011-06-18 Chong Yidong <cyd@stupidchicken.com>
3381
3382 * dispnew.c (add_window_display_history): Use BVAR.
3383
3384 * xdisp.c (debug_method_add): Use BVAR.
3385 (check_window_end, dump_glyph_matrix, dump_glyph)
3386 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3387
3388 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3389 Likewise.
3390
3391 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3392 check till after the cache is created in init_frame_faces.
3393
ff2bc410
SM
33942011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3395
3396 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3397
28177add
PE
33982011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3399
dd3482fe
PE
3400 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3401 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3402 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3403
393d71f3 3404 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3405 * fileio.c (Finsert_file_contents):
3406 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3407 Remove the old (too-loose) buffer overflow checks.
3408 They weren't needed, since make_gap checks for buffer overflow.
3409 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3410 The old code merely checked for Emacs fixnum overflow, and relied
3411 on undefined (wraparound) behavior. The new code avoids undefined
3412 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3413
2e6813b0 3414 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3415 Tune. Don't use wider integers than needed. Don't use alloca.
3416 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3417
599a9e4f
PE
3418 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3419
99561444
PE
3420 * insdel.c, lisp.h (buffer_overflow): New function.
3421 (insert_from_buffer_1, replace_range, replace_range_2):
3422 * insdel.c (make_gap_larger):
3423 * editfns.c (Finsert_char):
3424 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3425
28177add
PE
3426 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3427
e69dafad
PE
34282011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3429
a7af7fde 3430 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3431
b1c46f02
PE
3432 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3433 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3434
e69dafad
PE
3435 * fileio.c: Don't assume EMACS_INT fits in off_t.
3436 (emacs_lseek): New static function.
3437 (Finsert_file_contents, Fwrite_region): Use it.
3438 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3439
566684ea
PE
3440 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3441
e6966cd6
PE
3442 * fns.c: Don't overflow int when computing a list length.
3443 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3444 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3445 truncation on 64-bit hosts. Check for QUIT every
3446 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3447 faster and is responsive enough.
3448 (Flength): Report an error instead of overflowing an integer.
3449 (Fsafe_length): Return a float if the value is not representable
3450 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3451 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3452 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3453
dd0b0efb
PE
3454 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3455 (header_size, word_size): New constants.
3456 (allocate_vectorlike): Don't check size overflow here.
3457 (allocate_vector): Check it here instead, since this is the only
3458 caller of allocate_vectorlike that could cause overflow.
3459 Check that the new vector's length is representable as a fixnum.
3460
86fe5cfe
PE
3461 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3462 The previous code was bogus. For example, next_almost_prime (32)
3463 returned 39, which is undesirable as it is a multiple of 3; and
3464 next_almost_prime (24) returned 25, which is a multiple of 5 so
3465 why was the code bothering to check for multiples of 7?
3466
80e88859
PE
3467 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3468
4a2f0ad6
PE
3469 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3470
f66c7cf8
PE
3471 Variadic C functions now count arguments with ptrdiff_t.
3472 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3473 Back then I didn't know that the Emacs coding style prefers signed int.
3474 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3475 were being counted with int, which may truncate counts on 64-bit
3476 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3477 * lisp.h (struct Lisp_Subr.function.aMANY)
3478 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3479 Arg counts are now ptrdiff_t, not size_t.
3480 All variadic functions and their callers changed accordingly.
3481 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3482 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3483 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3484 * callint.c (Fcall_interactively): Check arg count for overflow,
3485 to avoid potential buffer overrun. Use signed char, not 'int',
3486 for 'varies' array, so that we needn't bother to check its size
3487 calculation for overflow.
3488 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3489 * eval.c (apply_lambda):
3490 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3491 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3492 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3493
a1759b76
PE
3494 * callint.c (Fcall_interactively): Don't use index var as event count.
3495
d96be9fc
PE
3496 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3497 * mem-limits.h (SIZE): Remove; no longer used.
3498
a690a978 3499 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3500
578c21e6
PE
3501 Remove unnecessary casts.
3502 * xterm.c (x_term_init):
3503 * xfns.c (x_set_border_pixel):
3504 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3505 These aren't needed now that we assume ANSI C.
3506
96f53c6c
PE
3507 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3508 It's more likely to cause problems (due to unsigned overflow)
3509 than to cure them.
3510
83c77d31
PE
3511 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3512
ee2079f1
PE
3513 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3514
6da65536
PE
3515 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3516
7147c4a4
PE
3517 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3518
193e32d9
PE
3519 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3520
e5533da6
PE
3521 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3522
9910e595
PE
3523 GLYPH_CODE_FACE returns EMACS_INT, not int.
3524 * dispextern.h (merge_faces):
3525 * xfaces.c (merge_faces):
01103c44
PE
3526 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3527 Don't assume EMACS_INT fits in int.
9910e595 3528
2638320e
PE
3529 * character.h (CHAR_VALID_P): Remove unused parameter.
3530 * fontset.c, lisp.h, xdisp.c: All uses changed.
3531
045eb8d9
PE
3532 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3533
c1f134b5
PE
3534 * fns.c (concat): Minor tuning based on overflow analysis.
3535 This doesn't fix any bugs. Use int to hold character, instead
3536 of constantly refetching from Emacs object. Use XFASTINT, not
3537 XINT, for value known to be a character. Don't bother comparing
3538 a single byte to 0400, as it's always less.
3539
395fcb93 3540 * floatfns.c (Fexpt):
327eeec8
PE
3541 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3542
abbd3d23
PE
3543 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3544 for characters.
3545
684a03ef
PE
3546 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3547
0fed43f3
PE
3548 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3549 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3550 incorrectly succeed when S was a string, because 4294967386 was
3551 truncated before it was used.
3552
8fd02eb7
PE
3553 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3554 Otherwise, an out-of-range integer could cause undefined behavior
3555 on a 64-bit host.
3556
f8c86b69
PE
3557 * composite.c: Use int, not EMACS_INT, for characters.
3558 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3559 EMACS_INT, for values that are known to be in character range.
3560 This doesn't fix any bugs but is the usual style inside Emacs and
3561 may generate better code on 32-bit machines.
3562
34206dd2
PE
3563 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3564 This is for reasons similar to the recent CHAR_STRING fix.
3565 * charset.c (Fencode_char): Check that character arg is actually
3566 a character. Pass an int to ENCODE_CHAR.
3567 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3568 wider than 'int', as a compile-time check to prevent future regressions
3569 in this area.
3570
c5958d4c 3571 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3572
3573 Make sure a 64-bit char is never passed to CHAR_STRING.
3574 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3575 by silently ignoring the top 32 bits, allowing some values
3576 that were far too large to be valid characters.
3577 * character.h: Include <verify.h>.
3578 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3579 arguments are no wider than unsigned, as a compile-time check
3580 to prevent future regressions in this area.
3581 * data.c (Faset):
01103c44 3582 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3583 (Fsubst_char_in_region):
3584 * fns.c (concat):
3585 * xdisp.c (decode_mode_spec_coding):
3586 Adjust to CHAR_STRING's new requirement.
3587 * editfns.c (Finsert_char, Fsubst_char_in_region):
3588 * fns.c (concat): Check that character args are actually
3589 characters. Without this test, these functions did the wrong
3590 thing with wildly out-of-range values on 64-bit hosts.
3591
d37ca623
PE
3592 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3593 These casts should not be needed on 32-bit hosts, either.
3594 * keyboard.c (read_char):
3595 * lread.c (Fload): Remove casts to unsigned.
3596
ea204efb
PE
3597 * lisp.h (UNSIGNED_CMP): New macro.
3598 This fixes comparison bugs on 64-bit hosts.
3599 (ASCII_CHAR_P): Use it.
3600 * casefiddle.c (casify_object):
01103c44 3601 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3602 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3603 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3604 * dispextern.h (FACE_FROM_ID):
3605 * keyboard.c (read_char): Use UNSIGNED_CMP.
3606
41cb286c
PE
3607 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3608 not to EMACS_INT, to avoid GCC warning.
3609
4a1b9832
PE
3610 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3611
55daad71
PE
3612 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3613 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3614 isn't needed on 32-bit machines.
8f95c75c 3615
01103c44
PE
3616 * buffer.c (Fgenerate_new_buffer_name):
3617 Use EMACS_INT for count, not int.
0ceccced 3618 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3619
3620 * data.c (Qcompiled_function): Now static.
3621
c6f072e7
PE
3622 * window.c (window_body_lines): Now static.
3623
20ce5912
PE
3624 * image.c (gif_load): Rename local to avoid shadowing.
3625
9c4c5f81
PE
3626 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3627 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3628 * alloc.c (make_save_value): Integer argument is now of type
3629 ptrdiff_t, not int.
3630 (mark_object): Use ptrdiff_t, not int.
3631 * lisp.h (pD): New macro.
3632 * print.c (print_object): Use it.
3633
c0c5c8ae
PE
3634 * alloc.c: Use EMACS_INT, not int, to count objects.
3635 (total_conses, total_markers, total_symbols, total_vector_size)
3636 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3637 (total_free_floats, total_floats, total_free_intervals)
3638 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3639 Now EMACS_INT, not int. All uses changed.
3640 (Fgarbage_collect): Compute overall total using a double, so that
3641 integer overflow is less likely to be a problem. Check for overflow
3642 when converting back to an integer.
5a25e253
PE
3643 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3644 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3645 These were 'int' variables that could overflow on 64-bit hosts;
3646 they were never used, so remove them instead of repairing them.
211a0b2a 3647 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3648 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3649 Previously, this ceilinged at INT_MAX, but that doesn't work on
3650 64-bit machines.
e46bb31a 3651 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3652
c78baabf 3653 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3654 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3655 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3656 when a (possibly-narrower) signed value would do just as well.
3657 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3658
c9d624c6
PE
3659 * alloc.c: Catch some string size overflows that we were missing.
3660 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3661 for convenience in STRING_BYTES_MAX.
3662 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3663 The definition here is exact; the one in lisp.h was approximate.
3664 (allocate_string_data): Check for string overflow. This catches
3665 some instances we weren't catching before. Also, it catches
3666 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3667 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3668 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3669
c9d624c6
PE
3670 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3671 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3672 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3673
353032ce
PE
3674 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3675
2bccce07
PE
3676 * alloc.c (Fmake_string): Check for out-of-range init.
3677
0ac30604
SM
36782011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3679
3680 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3681
c195f2de
JD
36822011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3683
3684 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3685 xg_get_default_scrollbar_width.
3686
3687 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3688 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3689 (style_changed_cb): Call update_theme_scrollbar_width and call
3690 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3691 all frames (Bug#8505).
3692 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3693 Call gtk_window_set_resizable if HAVE_GTK3.
3694 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3695 and height if HAVE_GTK3 (Bug#8505).
3696 (scroll_bar_width_for_theme): New variable.
3697 (update_theme_scrollbar_width): New function.
3698 (xg_get_default_scrollbar_width): Move code to
3699 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3700 (xg_initialize): Call update_theme_scrollbar_width.
3701
3702 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3703
3704 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3705
e10ac9f1
MR
37062011-06-12 Martin Rudalics <rudalics@gmx.at>
3707
3708 * frame.c (make_frame): Call other_buffer_safely instead of
3709 other_buffer.
3710
3711 * window.c (temp_output_buffer_show): Call display_buffer with
3712 second argument Vtemp_buffer_show_specifiers and reset latter
3713 immediately after the call.
3714 (Vtemp_buffer_show_specifiers): New variable.
3715 (auto_window_vscroll_p, next_screen_context_lines)
3716 (Vscroll_preserve_screen_position): Remove leading asterisks from
3717 doc-strings.
3718
2d3c217e 37192011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3720
7b7f97e8 3721 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3722 * buffer.c (Qclone_number): Remove for now, as it's unused.
3723 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3724 (record_buffer): Remove unused local.
3725 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3726 (set_frame_buffer_list): Remove; unused.
3727 * frame.h (other_visible_frames): Remove decl.
3728 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3729 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3730 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3731 if HAVE_GPM.
3732 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3733 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3734 Define only if HAVE_GPM.
3735 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3736 (update_hints_inhibit): Remove; never set. All uses removed.
3737 * widgetprv.h (emacsFrameClassRec): Remove decl.
3738 * window.c (delete_deletable_window): Now returns void, since it
3739 wasn't returning anything.
3740 (compare_window_configurations): Remove unused locals.
3741 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3742 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3743 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3744 the same widths as pointers. This follows up on the 2011-05-06 patch.
3745 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3746 * xterm.h: Likewise.
3747 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3748
1384b89e
JB
37492011-06-12 Juanma Barranquero <lekktu@gmail.com>
3750
3751 * makefile.w32-in: Update dependencies.
3752 (LISP_H): Add lib/intprops.h.
3753
1100a63c
CY
37542011-06-11 Chong Yidong <cyd@stupidchicken.com>
3755
3756 * image.c (gif_load): Add animation frame delay to the metadata.
3757 (syms_of_image): Use DEFSYM. New symbol `delay'.
3758
6198ccd0
MR
37592011-06-11 Martin Rudalics <rudalics@gmx.at>
3760
3761 * window.c (delete_deletable_window): Re-add.
3762 (Fset_window_configuration): Rewrite to handle dead buffers and
3763 consequently deletable windows.
3764 (window_tree, Fwindow_tree): Remove. Supply functionality in
3765 window.el.
3766 (compare_window_configurations): Simplify code.
3767
b6e3633c
AS
37682011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3769
1ab0dee5
AS
3770 * image.c (imagemagick_load_image): Fix type mismatch.
3771 (Fimagemagick_types): Likewise.
3772
b6e3633c
AS
3773 * window.h (replace_buffer_in_windows): Declare.
3774
9397e56f
MR
37752011-06-11 Martin Rudalics <rudalics@gmx.at>
3776
3777 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3778 Qclone_number. Remove external declaration of Qdelete_window.
3779 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3780 code.
640c8776
SM
3781 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3782 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3783 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3784 buffer list implementation.
3785 (other_buffer_safely): New function.
3786 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3787 calls to replace_buffer_in_windows and
3788 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3789 if allowed.
3790 (record_buffer): Inhibit quitting and rewrite using quittable
3791 functions. Run Qbuffer_list_update_hook if allowed.
3792 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3793 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3794 Move switch-to-buffer to window.el.
9397e56f
MR
3795 (bury-buffer): Move to window.el.
3796 (Vbuffer_list_update_hook): New variable.
3797
3798 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3799 section.
3800
3801 * window.h (resize_frame_windows): Move up in code.
3802 (Fwindow_frame): Remove EXFUN.
3803 (replace_buffer_in_all_windows): Remove prototype.
3804 (replace_buffer_in_windows_safely): Add prototype.
3805
3806 * window.c: Declare Qdelete_window static again. Move down
3807 declaration of select_count.
3808 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3809 (Fother_window): Move to window.el.
3810 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3811 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3812 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3813 window.el.
3814 (replace_buffer_in_windows): Implement by calling
3815 Qreplace_buffer_in_windows.
3816 (replace_buffer_in_all_windows): Remove with some functionality
3817 moved into replace_buffer_in_windows_safely.
3818 (replace_buffer_in_windows_safely): New function.
3819 (select_window_norecord, select_frame_norecord): Move in front
3820 of run_window_configuration_change_hook. Remove now obsolete
3821 declarations.
640c8776
SM
3822 (Fset_window_buffer): Rewrite doc-string.
3823 Call Qrecord_window_buffer.
9397e56f
MR
3824 (keys_of_window): Move binding for other-window to window.el.
3825
b50691aa
CY
38262011-06-11 Chong Yidong <cyd@stupidchicken.com>
3827
3828 * dispextern.h (struct image): Replace data member, whose int_val
3829 and ptr_val fields were not used by anything, with a single
3830 lisp_val object.
3831
3832 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3833 (gif_clear_image, gif_load, imagemagick_load_image)
3834 (gs_clear_image, gs_load): Callers changed.
3835
3f754b86
PE
38362011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3837
cca69397
PE
3838 * buffer.h: Include <time.h>, for time_t.
3839 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3840
109e28d0
PE
3841 Fix minor problems found by static checking.
3842
60737f02
PE
3843 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3844
4b66faf3
PE
3845 Make identifiers static if they are not used in other modules.
3846 * data.c (Qcompiled_function, Qframe, Qvector):
3847 * image.c (QimageMagick, Qsvg):
3848 * minibuf.c (Qmetadata):
3849 * window.c (resize_window_check, resize_root_window): Now static.
3850 * window.h (resize_window_check, resize_root_window): Remove decls.
3851
109e28d0
PE
3852 * window.c (window_deletion_count, delete_deletable_window):
3853 Remove; unused.
46a4ce9e
PE
3854 (window_body_lines): Now static.
3855 (Fdelete_other_windows_internal): Mark vars as initialized.
3856 Make sure 'resize_failed' is initialized.
3857 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3858 (resize_window_apply): Remove unused local.
3859 * window.h (delete_deletable_window): Remove decl.
3860
109e28d0 3861 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3862 (imagemagick_load_image): Fix pointer signedness problem by changing
3863 last arg from unsigned char * to char *. All uses changed.
3864 Also, fix a local for similar reasons.
3865 Remove unused locals. Remove locals to avoid shadowing.
3866 (fn_rsvg_handle_free): Remove; unused.
3867 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3868 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3869
3f754b86
PE
3870 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3871
2547adb1
CY
38722011-06-10 Chong Yidong <cyd@stupidchicken.com>
3873
3874 * image.c (gif_load): Fix omitted cast error introduced by
3875 2011-06-06 change.
3876
2c8e37d4
MR
38772011-06-10 Martin Rudalics <rudalics@gmx.at>
3878
3879 * window.h (resize_proportionally, orig_total_lines)
3880 (orig_top_line): Remove from window structure.
3881 (set_window_height, set_window_width, change_window_heights)
3882 (Fdelete_window): Remove prototypes.
3883 (resize_frame_windows): Remove duplicate declaration.
3884
440a42e3
EZ
38852011-06-10 Eli Zaretskii <eliz@gnu.org>
3886
3887 * window.h (resize_frame_windows, resize_window_check)
3888 (delete_deletable_window, resize_root_window)
3889 (resize_frame_windows): Declare prototypes.
3890
3891 * window.c (resize_window_apply): Make definition be "static" to
3892 match the prototype.
3893
562dd5e9
MR
38942011-06-10 Martin Rudalics <rudalics@gmx.at>
3895
3896 * window.c: Remove declarations of Qwindow_size_fixed,
3897 window_min_size_1, window_min_size_2, window_min_size,
3898 size_window, window_fixed_size_p, enlarge_window, delete_window.
3899 Remove static from declaration of Qdelete_window, it's
3900 temporarily needed by Fbury_buffer.
3901 (replace_window): Don't assign orig_top_line and
3902 orig_total_lines.
3903 (Fdelete_window, delete_window): Remove. Window deletion is
3904 handled by window.el.
640c8776
SM
3905 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3906 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3907 (Fdelete_other_windows): Remove. Deleting other windows is
3908 handled by window.el.
3909 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3910 handled in window.el.
3911 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3912 Window minimum sizes are handled in window.el.
3913 (shrink_windows, size_window, set_window_height)
3914 (set_window_width, change_window_heights, window_height)
3915 (window_width, CURBEG, CURSIZE, enlarge_window)
3916 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3917 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3918 handled in window.el.
3919 (make_dummy_parent): Rename to make_parent_window and give it a
3920 second argument horflag.
3921 (make_window): Don't set resize_proportionally any more.
3922 (Fsplit_window): Remove. Windows are split in window.el.
3923 (save_restore_action, save_restore_orig_size)
3924 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3925 Resize mini windows in window.el.
3926 (grow_mini_window, shrink_mini_window): Implement by calling
3927 Qresize_root_window_vertically, resize_window_check and
3928 resize_window_apply.
640c8776
SM
3929 (saved_window, Fset_window_configuration, save_window_save):
3930 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3931 resize_proportionally.
3932 (window_min_height, window_min_width): Move to window.el.
3933 (keys_of_window): Move bindings for delete-other-windows,
3934 split-window, delete-window and enlarge-window to window.el.
3935
3936 * buffer.c: Temporarily extern Qdelete_window.
3937 (Fbury_buffer): Temporarily call Qdelete_window instead of
3938 Fdelete_window (Fbury_buffer will move to window.el soon).
3939
3940 * frame.c (set_menu_bar_lines_1): Remove code handling
3941 orig_top_line and orig_total_lines.
3942
3943 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3944 set_window_height but set heights directly.
3945 (change_frame_size_1): Use resize_frame_windows.
3946
3947 * xdisp.c (init_xdisp): Don't use set_window_height but set
3948 heights directly.
3949
640c8776
SM
3950 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3951 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3952 run_window_configuration_change_hook.
3953
3954 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3955 instead of change_window_heights and run
3956 run_window_configuration_change_hook.
3957
1a13852e
MR
39582011-06-09 Martin Rudalics <rudalics@gmx.at>
3959
3960 * window.c (replace_window): Rename second argument REPLACEMENT to
3961 NEW. New third argument SETFLAG. Rewrite.
3962 (delete_window, make_dummy_parent): Call replace_window with
3963 third argument 1.
3964 (window_list_1): Move down in code.
3965 (run_window_configuration_change_hook): Move set_buffer part
3966 before select_frame_norecord part in order to unwind correctly.
3967 Rename count1 to count.
3968 (recombine_windows, delete_deletable_window, resize_root_window)
3969 (Fdelete_other_windows_internal)
3970 (Frun_window_configuration_change_hook, make_parent_window)
3971 (resize_window_check, resize_window_apply, Fresize_window_apply)
3972 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3973 (Fdelete_window_internal, Fresize_mini_window_internal):
3974 New functions.
1a13852e
MR
3975 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3976
f3d1777e
MR
39772011-06-08 Martin Rudalics <rudalics@gmx.at>
3978
496e208e
MR
3979 * window.h (window): Add some new members to window structure -
3980 normal_lines, normal_cols, new_total, new_normal, clone_number,
3981 splits, nest, prev_buffers, next_buffers.
3982 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3983 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3984
f3d1777e
MR
3985 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3986 Remove.
496e208e
MR
3987 (make_dummy_parent): Set new members of windows structure.
3988 (make_window): Move down in code. Handle new members of window
3989 structure.
3990 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3991 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3992 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3993 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3994 (Fset_window_next_buffers, Fset_window_clone_number):
3995 New functions.
496e208e
MR
3996 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3997 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3998 Doc-string fixes.
3999 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4000 Argument WINDOW can be now internal window too.
4001 (Fwindow_use_time): Move up in code.
4002 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4003 Rewrite doc-string.
4004 (Fset_window_configuration, saved_window)
4005 (Fcurrent_window_configuration, save_window_save): Handle new
4006 members of window structure.
b9e809c2
MR
4007 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4008 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4009 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4010 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4011 Qget_mru_window, Qresize_root_window,
4012 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4013 Qauto_buffer_name; staticpro them.
f3d1777e 4014
abde8f8c
MR
40152011-06-07 Martin Rudalics <rudalics@gmx.at>
4016
4017 * window.c (Fwindow_total_size, Fwindow_left_column)
4018 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4019 (Fwindow_list_1): New functions.
4020 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4021 (Fwindow_width, Fscroll_left, Fscroll_right):
4022 Use window_body_cols instead of window_box_text_cols.
4023 (delete_window, Fset_window_configuration):
4024 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4025 (delete_all_subwindows): Take a window as argument and not a
4026 structure. Rewrite.
190b47e6
MR
4027 (window_loop): Remove handling of GET_LRU_WINDOW and
4028 GET_LARGEST_WINDOW.
4029 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4030
4031 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4032 window_box_text_cols. delete_all_subwindows now takes a
4033 Lisp_Object as argument.
abde8f8c 4034
640c8776
SM
4035 * indent.c (compute_motion, Fcompute_motion):
4036 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4037
fa8a67e6
MR
4038 * frame.c (delete_frame): Call delete_all_subwindows with root
4039 window as argument.
4040
a54e3482
DC
40412011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4042
4043 * fns.c (Fputhash): Document return value.
4044
60002bf5
CY
40452011-06-06 Chong Yidong <cyd@stupidchicken.com>
4046
4047 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4048
0c671da6 40492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4050
b862a52a 4051 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4052
be44ca6c
PE
4053 Check for overflow when converting integer to cons and back.
4054 * charset.c (Fdefine_charset_internal, Fdecode_char):
4055 Use cons_to_unsigned to catch overflow.
4056 (Fencode_char): Use INTEGER_TO_CONS.
4057 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4058 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4059 * data.c (long_to_cons, cons_to_long): Remove.
4060 (cons_to_unsigned, cons_to_signed): New functions.
4061 These signal an error for invalid or out-of-range values.
4062 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4063 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4064 * font.c (Ffont_variation_glyphs):
4065 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4066 * lisp.h: Include <intprops.h>.
4067 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4068 (cons_to_signed, cons_to_unsigned): New decls.
4069 (long_to_cons, cons_to_long): Remove decls.
4070 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4071 (Fprimitive_undo): Use CONS_TO_INTEGER.
4072 * xfns.c (Fx_window_property): Likewise.
4073 * xselect.c: Include <limits.h>.
4074 (x_own_selection, selection_data_to_lisp_data):
4075 Use INTEGER_TO_CONS.
4076 (x_handle_selection_request, x_handle_selection_clear)
4077 (x_get_foreign_selection, Fx_disown_selection_internal)
4078 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4079 (lisp_data_to_selection_data): Use cons_to_unsigned.
4080 (x_fill_property_data): Use cons_to_signed.
4081 Report values out of range.
4082
d1f3d2af
PE
4083 Check for buffer and string overflow more precisely.
4084 * buffer.h (BUF_BYTES_MAX): New macro.
4085 * lisp.h (STRING_BYTES_MAX): New macro.
4086 * alloc.c (Fmake_string):
4087 * character.c (string_escape_byte8):
4088 * coding.c (coding_alloc_by_realloc):
4089 * doprnt.c (doprnt):
4090 * editfns.c (Fformat):
4091 * eval.c (verror):
4092 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4093 since they may not be the same number.
4094 * editfns.c (Finsert_char):
4095 * fileio.c (Finsert_file_contents):
4096 Likewise for BUF_BYTES_MAX.
4097
dd52fcea
PE
4098 * image.c: Use ptrdiff_t, not int, for sizes.
4099 (slurp_file): Switch from int to ptrdiff_t.
4100 All uses changed.
4101 (slurp_file): Check that file size fits in both size_t (for
4102 malloc) and ptrdiff_t (for sanity and safety).
4103
7f9bbdbb
PE
4104 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4105 if b->modtime has its maximal value.
4106
dfe18f82
PE
4107 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4108
84acfcf0
PE
4109 Don't assume time_t can fit into int.
4110 * buffer.h (struct buffer.modtime): Now time_t, not int.
4111 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4112 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4113
ccd9a01a
PE
4114 Minor fixes for signed vs unsigned integers.
4115 * character.h (MAYBE_UNIFY_CHAR):
4116 * charset.c (maybe_unify_char):
4117 * keyboard.c (read_char, reorder_modifiers):
4118 XINT -> XFASTINT, since the integer must be nonnegative.
4119 * ftfont.c (ftfont_spec_pattern):
4120 * keymap.c (access_keymap, silly_event_symbol_error):
4121 XUINT -> XFASTINT, since the integer must be nonnegative.
4122 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4123 since it makes no difference and we prefer signed.
4124 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4125 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4126 nonnegative.
4127
d6d100dd
SM
41282011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4129
4130 * window.h (Fwindow_frame): Declare.
4131
2b6148e4
PE
41322011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4133
4134 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4135 (SPARE_MEMORY): Always define.
4136 (LARGE_REQUEST): Remove.
4137 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4138
f230ecc9
MR
41392011-06-06 Martin Rudalics <rudalics@gmx.at>
4140
727e958e
MR
4141 * lisp.h: Move EXFUNS for Fframe_root_window,
4142 Fframe_first_window and Fset_frame_selected_window to window.h.
4143
4144 * window.h: Move EXFUNS for Fframe_root_window,
4145 Fframe_first_window and Fset_frame_selected_window here from
4146 lisp.h.
4147
4148 * frame.c (Fwindow_frame, Fframe_first_window)
4149 (Fframe_root_window, Fframe_selected_window)
4150 (Fset_frame_selected_window): Move to window.c.
4151 (Factive_minibuffer_window): Move to minibuf.c.
4152 (Fother_visible_frames_p): New function.
4153
4154 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4155
f230ecc9
MR
4156 * window.c (decode_window, decode_any_window): Move up in code.
4157 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4158 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4159 (Fwindow_buffer): Move up and rewrite doc-string.
4160 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4161 (Fwindow_prev): New functions.
727e958e
MR
4162 (Fwindow_frame): Move here from frame.c. Accept any window as
4163 argument.
4164 (Fframe_root_window, Fframe_first_window)
4165 (Fframe_selected_window): Move here from frame.c. Accept frame
4166 or arbitrary window as argument. Update doc-strings.
4167 (Fminibuffer_window): Move up in code.
4168 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4169 (Fset_frame_selected_window): Move here from frame.c.
4170 Marginal rewrite.
727e958e
MR
4171 (Fselected_window, select_window, Fselect_window): Move up in
4172 code. Minor doc-string fixes.
f230ecc9 4173
4d09bcf6
PE
41742011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4175
4176 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4177 Do not assume that spare memory exists; that assumption is valid
4178 only if SYSTEM_MALLOC.
4179 (LARGE_REQUEST): New macro, so that the issue of large requests
4180 is separated from the issue of spare memory.
4181
810928a2
AS
41822011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4183
172418ad
AS
4184 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4185 format. (Bug#8806)
4186
43f862f7
AS
4187 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4188
810928a2
AS
4189 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4190 before statements.
4191
a059fe24
JD
41922011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4193
4194 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4195
4196 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4197
4198 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4199 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4200
989bf368
JB
42012011-06-05 Juanma Barranquero <lekktu@gmail.com>
4202
4203 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4204
4b80f674
CY
42052011-06-04 Chong Yidong <cyd@stupidchicken.com>
4206
4207 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4208 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4209 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4210 New error handlers.
4b80f674
CY
4211 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4212 Obey Vx_select_enable_clipboard_manager. Catch errors in
4213 x_clipboard_manager_save (Bug#8779).
4214 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4215 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4216
99a33b77 42172011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4218
4219 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4220
99a33b77 42212011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4222
4223 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4224 in the current matrix if keep_current_p is non-zero.
4225
8264569d
EZ
42262011-06-04 Eli Zaretskii <eliz@gnu.org>
4227
4228 * bidi.c (bidi_level_of_next_char): Fix last change.
4229
57f97249
EZ
42302011-06-03 Eli Zaretskii <eliz@gnu.org>
4231
fec2107c 4232 Support bidi reordering of text covered by display properties.
57f97249 4233
fec2107c
EZ
4234 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4235 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4236 (bidi_cache_search, bidi_cache_iterator_state)
4237 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4238 (bidi_level_of_next_char, bidi_move_to_visually_next):
4239 Support character positions inside a run of characters covered by a
fec2107c
EZ
4240 display string.
4241 (bidi_paragraph_init, bidi_resolve_explicit_1)
4242 (bidi_level_of_next_char): Call bidi_fetch_char and
4243 bidi_fetch_char_advance instead of FETCH_CHAR and
4244 FETCH_CHAR_ADVANCE.
4245 (bidi_init_it): Initialize new members.
4246 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4247 definitions.
4248 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4249 instead of using explicit *_CHAR codes.
d6d100dd
SM
4250 (bidi_resolve_explicit, bidi_resolve_weak):
4251 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4252 bidirectional text is supported only in multibyte buffers.
4253 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4254 it to initialize the frame_window_p member of struct bidi_it.
4255 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4256 (bidi_resolve_explicit, bidi_resolve_weak)
4257 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4258 bidi_it->nchars is non-positive.
4259 (bidi_level_of_next_char): Don't try to lookup the cache for the
4260 next/previous character if nothing is cached there yet, or if we
4261 were just reseat()'ed to a new position.
c40e2fb2 4262
0e14fe90
EZ
4263 * xdisp.c (set_cursor_from_row): Set start and stop points
4264 according to the row's direction when priming the loop that looks
4265 for the glyph on which to display cursor.
4266 (single_display_spec_intangible_p): Function deleted.
4267 (display_prop_intangible_p): Reimplement to call
4268 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4269 Accept 3 additional arguments needed by handle_display_spec.
4270 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4271 values: lists, `(when COND...)' forms, etc.
4272 (single_display_spec_string_p): Support property values that are
4273 lists with the argument STRING its top-level element.
4274 (display_prop_string_p): Fix the condition for processing a
4275 property that is a list to be consistent with handle_display_spec.
fec2107c 4276 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4277 last portion of handle_display_prop.
4278 (compute_display_string_pos): Accept additional argument
4279 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4280 value of a `display' property is a "replacing spec".
4281 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4282 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4283 the display property, but just return a value indicating whether
4284 the display property will replace the characters it covers.
4285 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4286 frame_window_p members of struct bidi_it.
d6d100dd
SM
4287 (compute_display_string_pos, compute_display_string_end):
4288 New functions.
fec2107c
EZ
4289 (push_it): Accept second argument POSITION, where pop_it should
4290 jump to continue iteration.
4291 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4292
fec2107c
EZ
4293 * keyboard.c (adjust_point_for_property): Adjust the call to
4294 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4295
4296 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4297 (bidi_init_it): Update prototypes.
4298 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4299 (compute_display_string_pos, compute_display_string_end):
4300 Declare prototypes.
fec2107c
EZ
4301 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4302 EMACS_INT.
fc6f18ce 4303
40087514 43042011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4305
57f53182
PE
4306 Malloc failure behavior now depends on size of allocation.
4307 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4308 * lisp.h: Change signatures accordingly.
4309 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4310 All callers changed. (Bug#8762)
4311
4312 * gnutls.c: Use Emacs's memory allocators.
4313 Without this change, the gnutls library would invoke malloc etc.
4314 directly, which causes problems on non-SYNC_INPUT hosts, and which
4315 runs afoul of improving memory_full behavior. (Bug#8761)
4316 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4317 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4318 xfree instead of the default malloc, realloc, free.
4319 (Fgnutls_boot): No need to check for memory allocation failure,
4320 since xmalloc does that for us.
4321
ac32cd99 4322 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4323 * category.c (hash_get_category_set):
4324 * ccl.c (ccl_driver):
4325 * charset.c (Fdefine_charset_internal):
4326 * charset.h (struct charset.hash_index):
4327 * composite.c (get_composition_id, gstring_lookup_cache)
4328 (composition_gstring_put_cache):
4329 * composite.h (struct composition.hash_index):
4330 * dispextern.h (struct image.hash):
4331 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4332 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4333 (hashfn_equal, hashfn_user_defined, make_hash_table)
4334 (maybe_resize_hash_table, hash_lookup, hash_put)
4335 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4336 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4337 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4338 * image.c (make_image, search_image_cache, lookup_image)
4339 (xpm_put_color_table_h):
4340 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4341 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4342 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4343 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4344 * alloc.c (allocate_vectorlike):
4345 Check for overflow in vector size calculations.
4346 * ccl.c (ccl_driver):
4347 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4348 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4349 need to be updated by these changes.
40087514
PE
4350 * fns.c (make_hash_table, maybe_resize_hash_table):
4351 Check for integer overflow with large hash tables.
0de4bb68
PE
4352 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4353 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4354 (SXHASH_REDUCE): New macro.
4355 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4356 Use it instead of discarding useful hash info with large hash values.
4357 (sxhash_float): New function.
4358 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4359 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4360 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4361 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4362 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4363 Adjust signatures to match updated version of code.
4364 (consing_since_gc): Now EMACS_INT, since a single hash table can
4365 use more than INT_MAX bytes.
4366
698d32e2
DN
43672011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4368
4369 Make it possible to build with GCC-4.6+ -O2 -flto.
4370
4371 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4372
fd6fa53f
SM
43732011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4374
4375 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4376 Call minibuffer-inactive-mode.
4377
864db017
JB
43782011-05-31 Juanma Barranquero <lekktu@gmail.com>
4379
4380 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4381 Update dependencies.
4382
2ad0baf4
DN
43832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4384
4385 * data.c (init_data): Remove code for UTS, this system is not
4386 supported anymore.
4387
4fcc2638
DN
43882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4389
4390 Don't force ./temacs to start in terminal mode.
4391
4392 * frame.c (make_initial_frame): Initialize faces in all cases, not
4393 only when CANNOT_DUMP is defined.
4394 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4395
c56e0fd5
DN
43962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4397
4398 * dispnew.c (add_window_display_history): Use const for the string
4399 pointer. Remove declaration, not needed.
4400
333d54da 44012011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4402
55d4c1b2 4403 Use 'inline', not 'INLINE'.
333d54da 4404 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4405 * alloc.c, fontset.c (INLINE): Remove.
4406 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4407 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4408 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4409 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4410 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4411
738db178
DN
44122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4413
4414 Make it possible to run ./temacs.
4415
4416 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4417 syms_of_callproc does the same thing. Remove test for
4418 "initialized", do it in the caller.
4419 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4420
620c53a6
SM
44212011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4422
4423 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4424 (read_minibuf): Use get_minibuffer.
4425 (syms_of_minibuf): Use DEFSYM.
4426 (Qmetadata): New var.
4427 * data.c (Qbuffer): Don't make it static.
4428 (syms_of_data): Use DEFSYM.
4429
e003a292
PE
44302011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4431
4432 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4433 (CCL_CODE_MIN): New macro.
4434
ed008a6d
PE
44352011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4436
3687c2ef
PE
4437 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4438
ed008a6d
PE
4439 * eval.c (Qdebug): Now static.
4440 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4441 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4442 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4443
d66c4c7c
CY
44442011-05-29 Chong Yidong <cyd@stupidchicken.com>
4445
4446 * image.c: Various fixes to ImageMagick code comments.
4447 (Fimagemagick_types): Doc fix.
4448
5fbc2025
PE
44492011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4450
0196f88a
PE
4451 Minor fixes prompted by GCC 4.6.0 warnings.
4452
4453 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4454
5fbc2025
PE
4455 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4456 (x_clipboard_manager_save_all): Move extern decl to ...
4457 * xterm.h: ... here, so that it can be checked for consistency.
4458
1dd3c2d9
CY
44592011-05-29 Chong Yidong <cyd@stupidchicken.com>
4460
4461 * xselect.c (x_clipboard_manager_save_frame)
4462 (x_clipboard_manager_save_all): New functions.
4463 (Fx_clipboard_manager_save): Lisp function deleted.
4464
4465 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4466 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4467
4468 * xterm.h: Update prototype.
4469
5ba6571d
WX
44702011-05-28 William Xu <william.xwl@gmail.com>
4471
4472 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4473 exiting (Bug#8239).
4474
3eaff834
JM
44752011-05-28 Jim Meyering <meyering@redhat.com>
4476
e1900994 4477 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4478 * fns.c (to_uchar): Define.
4479 (crypto_hash_function): Use it to convert some newly-signed
4480 variables to unsigned, to avoid sign-extension bugs. For example,
4481 without this change, (md5 "truc") would evaluate to
4482 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4483 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4484 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4485
0f6990a7
PE
44862011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4487
4488 Integer overflow fixes.
c8a9ca5a 4489
08686060
PE
4490 * dbusbind.c: Serial number integer overflow fixes.
4491 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4492 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4493 to hold a serial number that is too large for a fixnum.
4494 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4495 Check for serial numbers out of range. Decode any serial number
59568bf0 4496 that was so large that it became a float. (Bug#8722)
08686060 4497
2d1fc3c7
PE
4498 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4499 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4500 Use XFASTINT rather than XUINT when numbers are nonnegative.
4501 (xd_append_arg, Fdbus_method_return_internal):
4502 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4503 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4504 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4505 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4506 (Bug#8722)
2d1fc3c7 4507
c8a9ca5a
PE
4508 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4509
519e1d69
PE
4510 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4511
30569699
PE
4512 ccl: add integer overflow checks
4513 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4514 (IN_INT_RANGE): New macros.
4515 (ccl_driver): Use them to check for integer overflow when
4516 decoding a CCL program. Many of the new checks are whether XINT (x)
4517 fits in int; it doesn't always, on 64-bit hosts. The new version
4518 doesn't catch all possible integer overflows, but it's an
847044ea 4519 improvement. (Bug#8719)
30569699 4520
c11285dc
PE
4521 * alloc.c (make_event_array): Use XINT, not XUINT.
4522 There's no need for unsigned here.
4523
fdccd48e
PE
4524 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4525 This follows up to the 2011-05-06 change that substituted uintptr_t
4526 for EMACS_INT. This case wasn't caught back then.
4527
37910ab2
PE
4528 Rework Fformat to avoid integer overflow issues.
4529 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4530 now (part of C89). Include <verify.h>.
4531 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4532 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4533 (Fformat): Avoid the prepass trying to compute sizes; it was only
4534 approximate and thus did not catch overflow reliably. Instead, walk
4535 through the format just once, formatting and computing sizes as we go,
4536 checking for integer overflow at every step, and allocating a larger
4537 buffer as needed. Keep track separately whether the format is
4538 multibyte. Keep only the most-recently calculated precision, rather
4539 than them all. Record whether each argument has been converted to
4540 string. Use EMACS_INT, not int, for byte and char and arg counts.
4541 Support field widths and precisions larger than INT_MAX. Avoid
4542 sprintf's undefined behavior with conversion specifications such as %#d
4543 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4544 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4545 formatting out-of-range floating point numbers with int
9173deec 4546 formats. (Bug#8668)
37910ab2 4547
2e6578fb
PE
4548 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4549
0ae6bdee
PE
4550 * data.c: Avoid integer truncation in expressions involving floats.
4551 * data.c: Include <intprops.h>.
4552 (arith_driver): When there's an integer overflow in an expression
4553 involving floating point, convert the integers to floating point
4554 so that the resulting value does not suffer from catastrophic
4555 integer truncation. For example, on a 64-bit host (* 4
4556 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4557 Do not rely on undefined behavior after integer overflow.
4558
de883a70
PE
4559 merge count_size_as_multibyte, parse_str_to_multibyte
4560 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4561 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4562 Check for integer overflow.
4563 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4564 since it's now a duplicate of the other. This is more of
4565 a character than a buffer op, so better that it's in character.c.
4566 * fns.c, print.c: Adjust to above changes.
4567
2ff916cb
PE
45682011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4569
4570 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4571
f1b54466
PE
45722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4573
fb1ac845
PE
4574 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4575 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4576 (x_clipboard_manager_save): Now static.
4577 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4578
f1b54466
PE
4579 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4580 (crypto_hash_function): Now static.
4581 Fix pointer signedness problems. Avoid unnecessary initializations.
4582
a9f737ee
CY
45832011-05-27 Chong Yidong <cyd@stupidchicken.com>
4584
4585 * termhooks.h (Vselection_alist): Make it terminal-local.
4586
4587 * terminal.c (create_terminal): Initialize it.
4588
4589 * xselect.c: Support for clipboard managers.
4590 (Vselection_alist): Move to termhooks.h as terminal-local var.
4591 (LOCAL_SELECTION): New macro.
4592 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4593 (symbol_to_x_atom): Remove gratuitous arg.
4594 (x_handle_selection_request, lisp_data_to_selection_data)
4595 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4596 (x_own_selection, x_get_local_selection, x_convert_selection):
4597 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4598 (some_frame_on_display): Delete unused function.
4599 (Fx_own_selection_internal, Fx_get_selection_internal)
4600 (Fx_disown_selection_internal, Fx_selection_owner_p)
4601 (Fx_selection_exists_p): New optional frame arg.
4602 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4603 (x_handle_selection_clear): Don't treat other terminals with the
4604 same keyboard specially. Use the terminal-local Vselection_alist.
4605 (x_clear_frame_selections): Use Frun_hook_with_args.
4606
4607 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4608
4609 * xterm.h: Add support for those atoms.
4610
e067f0c1
CY
46112011-05-26 Chong Yidong <cyd@stupidchicken.com>
4612
4613 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4614 (converted_selections, conversion_fail_tag): New global variables.
4615 (x_selection_request_lisp_error): Free the above.
4616 (x_get_local_selection): Remove unnecessary code.
4617 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4618 of converted selections stored in converted_selections.
4619 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4620 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4621 (x_convert_selection): New function.
4622 (x_handle_selection_event): Simplify.
4623 (x_get_foreign_selection): Don't ignore incoming requests while
4624 waiting for an answer; this will fail when we implement
4625 SAVE_TARGETS, and seems unnecessary anyway.
4626 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4627 (Vx_sent_selection_functions): Doc fix.
4628
0f4aebc0
LL
46292011-05-26 Leo Liu <sdl.web@gmail.com>
4630
4631 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4632
e61124cd
YM
46332011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4634
4635 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4636
4637 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4638 for fringe update if it has periodic bitmap.
ac389d0c 4639 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4640 and fringe_bitmap_periodic_p.
4641
4642 * fringe.c (get_fringe_bitmap_data): New function.
4643 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4644 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4645 row. Mark glyph row for fringe update if periodicity changed.
4646
4647 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4648 for fringe update unless it has periodic bitmap.
4649
f16d9837
KH
46502011-05-25 Kenichi Handa <handa@m17n.org>
4651
4652 * xdisp.c (get_next_display_element): Set correct it->face_id for
4653 a static composition.
4654
e1b90ef6
LL
46552011-05-24 Leo Liu <sdl.web@gmail.com>
4656
4657 * deps.mk (fns.o):
4658 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4659
4660 * fns.c (crypto_hash_function, Fsha1): New function.
4661 (Fmd5): Use crypto_hash_function.
4662 (syms_of_fns): Add Ssha1.
4663
7400048f
PE
46642011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4665
4666 * gnutls.c: Remove unused macros.
4667 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4668 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4669 Remove macros that are defined and never used.
4670 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4671
abb71cf4
CY
46722011-05-22 Chong Yidong <cyd@stupidchicken.com>
4673
4674 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4675 (Fx_get_selection_internal): Minor cleanup.
4676 (Fx_own_selection_internal): Rename arguments for consistency with
4677 select.el.
4678
6307db39
PE
46792011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4680
4681 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4682
f3d4e0a4
CY
46832011-05-22 Chong Yidong <cyd@stupidchicken.com>
4684
4685 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4686
4d8ade89
YM
46872011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4688
4689 * dispnew.c (scrolling_window): Don't exclude the case that the
4690 last enabled row in the desired matrix touches the bottom boundary.
4691
32078c8d
GM
46922011-05-21 Glenn Morris <rgm@gnu.org>
4693
4694 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4695 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4696 and add some more files.
32078c8d 4697
7285dc67
EZ
46982011-05-20 Eli Zaretskii <eliz@gnu.org>
4699
4700 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4701 report_file_error introduced by the change from 2011-05-07.
4702
89d1bd22
PE
47032011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4704
4705 * systime.h (Time): Define only if emacs is defined.
4706 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4707 where the include path doesn't have X11/X.h by default. See
4708 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4709
e23640bb 47102011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4711
4712 * composite.c (find_automatic_composition): Fix previous change.
4713
b9704ad9
GM
47142011-05-20 Glenn Morris <rgm@gnu.org>
4715
4716 * lisp.mk: New file, split from Makefile.in.
4717 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4718 (shortlisp): Remove.
4719 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4720
4a720484
GM
47212011-05-19 Glenn Morris <rgm@gnu.org>
4722
4723 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4724 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4725 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4726 (lisp): Set the order to that of loadup.el.
4727 (shortlisp): Make it a copy of $lisp.
4728 (SOME_MACHINE_LISP): Remove.
4729 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4730 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4731
a28d4396
KH
47322011-05-18 Kenichi Handa <handa@m17n.org>
4733
4734 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4735 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4736 (find_automatic_composition): Mostly rewrite for efficiency.
4737
a2b1fa8e
JB
47382011-05-18 Juanma Barranquero <lekktu@gmail.com>
4739
4740 * makefile.w32-in: Update dependencies.
4741
8e1f5610
CS
47422011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4743
4744 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4745 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4746
7025ee00 47472011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4748
cdfa6eab
PE
4749 Fix some integer overflow issues, such as string length overflow.
4750
06d6db33
PE
4751 * insdel.c (count_size_as_multibyte): Check for string overflow.
4752
2b4560a8
PE
4753 * character.c (lisp_string_width): Check for string overflow.
4754 Use EMACS_INT, not int, for string indexes and lengths; in
4755 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4756 the resulting string length overflows an EMACS_INT; instead,
4757 report a string overflow if no precision given. When checking for
4758 precision exhaustion, use a check that cannot possibly have
4759 integer overflow. (Bug#8675)
4760 * character.h (lisp_string_width): Adjust to new signature.
4761
cb93f9be
PE
4762 * alloc.c (string_overflow): New function.
4763 (Fmake_string): Use it. This doesn't change behavior, but saves
4764 a few bytes and will simplify future changes.
4765 * character.c (string_escape_byte8): Likewise.
4766 * lisp.h (string_overflow): New decl.
4767
1a1f3366
PE
4768 Fixups, following up to the user-interface timestamp change.
4769 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4770 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4771 * msdos.c (mouse_get_pos): Likewise.
4772 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4773 * w32gui.h (Time): Define by including "systime.h" rather than by
4774 declaring it ourselves. (Bug#8664)
4775
d4e3e4d3
PE
4776 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4777 * image.c (clear_image_cache): Likewise.
4778
f6a24d19
PE
4779 * term.c (term_mouse_position): Don't assume time_t wraparound.
4780
08dc5ae6
PE
4781 Be more systematic about user-interface timestamps.
4782 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4783 and sometimes 'EMACS_UINT', to represent these timestamps.
4784 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4785 This makes the code easier to follow, and makes it easier to catch
4786 integer overflow bugs such as Bug#8664.
4787 * frame.c (Fmouse_position, Fmouse_pixel_position):
4788 Use Time, not unsigned long, for user-interface timestamps.
4789 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4790 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4791 * keyboard.h (last_event_timestamp): Likewise.
4792 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4793 * menu.h (xmenu_show): Likewise.
4794 * term.c (term_mouse_position): Likewise.
4795 * termhooks.h (struct input_event.timestamp): Likewise.
4796 (struct terminal.mouse_position_hook): Likewise.
4797 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4798 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4799 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4800 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4801 what it was before.
4802 * menu.h, termhooks.h: Include "systime.h", for Time.
4803
8e55734a
PE
4804 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4805 Don't assume that the difference between two unsigned long values
4806 can fit into an integer. At this point, we know button_down_time
4807 <= event->timestamp, so the difference must be nonnegative, so
4808 there's no need to cast the result if double-click-time is
4809 nonnegative, as it should be; check that it's nonnegative, just in
4810 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4811 apart (about 25 days). (Bug#8664)
8e55734a 4812
841f1b75 4813 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4814 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4815
3e26f69c
PE
4816 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4817 that always fit in int. Use a sentinel instead of a counter, to
4818 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4819 * frame.h (struct frame): Use int for menu_bar_items_used
4820 instead of EMACS_INT, since it always fits in int.
3e26f69c 4821
5cc152c0
PE
4822 * menu.c (grow_menu_items): Check for int overflow.
4823
d89eb65e
PE
4824 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4825
5235bd3e
PE
4826 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4827 Before, the code was not consistent. These values cannot exceed
4828 2**31 - 1 so there's no need to make them unsigned.
4829 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4830 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4831 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4832 as modifiers.
4833 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4834
bc827e23
PE
4835 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4836 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4837 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4838 presumably because the widths might not match.
4839
78eb494e
PE
4840 * window.c (size_window): Avoid needless test at loop start.
4841
04f2d78b
CB
48422011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4843
4844 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4845
d2fc7e3d 48462011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4847
4848 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4849
d2fc7e3d 48502011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4851
4852 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4853 `width' to `bar_area_x' and `bar_area_width', respectively.
4854 (x_scroll_run): Take account of fringe background extension.
4855
04f2d78b
CB
4856 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4857 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4858 `bar_area_width', respectively.
4859 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4860 background extension.
4861
79b70037
GM
48622011-05-10 Jim Meyering <meyering@redhat.com>
4863
4864 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4865
2f142cc5
JB
48662011-05-10 Juanma Barranquero <lekktu@gmail.com>
4867
4868 * image.c (Finit_image_library): Return t for built-in image types,
4869 like pbm and xbm. (Bug#8640)
4870
57679c86
AS
48712011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4872
4873 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4874
888c9e86
EZ
48752011-05-07 Eli Zaretskii <eliz@gnu.org>
4876
b0512a1d
EZ
4877 * w32console.c (Fset_screen_color): Doc fix.
4878 (Fget_screen_color): New function.
4879 (syms_of_ntterm): Defsubr it.
4880
7285dc67
EZ
4881 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4882 unlink the temporary file if Fcall_process didn't create it in the
4883 first place.
4884 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4885 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4886 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4887 cue to call_process_cleanup not to close that handle.
4888
4d3fcc8e
BK
48892011-05-07 Ben Key <bkey76@gmail.com>
4890
4891 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4892 one of two shell specific rules, either bootstrap-temacs-CMD or
4893 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4894 to the previous implementation of the bootstrap-temacs rule.
4895 The bootstrap-temacs-CMD rule is similar to the previous
4896 implementation of the bootstrap-temacs rule except that it
4897 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4898 variable.
4899
4900 These changes, along with some changes to nt/configure.bat,
4901 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4902 earlier fix to add support for --cflags and --ldflags options
4903 that include quotes so that it works whether make uses cmd or
4904 sh as the shell.
4905
b4289b64
MA
49062011-05-06 Michael Albinus <michael.albinus@gmx.de>
4907
4908 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4909 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4910 is a constant.
4911 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4912 a string. Handle both cases.
4913 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4914 (Fdbus_register_method): Use Qinvalid_function.
4915
af4c0e28
JB
49162011-05-06 Juanma Barranquero <lekktu@gmail.com>
4917
4918 * makefile.w32-in: Update dependencies.
4919 (LISP_H): Add inttypes.h and stdin.h.
4920 (PROCESS_H): Add unistd.h.
4921
c51453d9
EZ
49222011-05-06 Eli Zaretskii <eliz@gnu.org>
4923
4924 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4925 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4926
8ff0ac3c 49272011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4928
4c4b566b
PE
4929 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4930
aab2b9b5
PE
4931 * term.c (vfatal): Remove stray call to va_end.
4932 It's not needed and the C Standard doesn't allow it here anyway.
4933
c378da0b
PE
4934 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4935 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4936
288b08c7
PE
4937 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4938 bytes.
4939
e3601888
PE
4940 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4941
db6c0e74
PE
4942 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4943
dd5963ea
PE
4944 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4945
88c9450f
PE
4946 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4947
2f9442b8
PE
4948 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4949
c032b5f8
PE
4950 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4951 * charset.c (Fdefine_charset_internal): Don't initialize
4952 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4953 32-bit int (Bug#8600).
a108c10b
PE
4954
4955 * lread.c (read_integer): Be more consistent with string-to-number.
4956 Use string_to_number to do the actual conversion; this avoids
4957 rounding errors and fixes some other screwups. Without this fix,
4958 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4959 (digit_to_number): Move earlier, for benefit of read_integer.
4960 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4961 not a digit in any supported base. (Bug#8602)
a108c10b 4962
ad5f9eea
PE
4963 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4964
aec1708a
PE
4965 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4966 to match comment at start of function. This also removes a
4967 GCC warning about overflow in a 32+64-bit port.
4968
47be4ab5
PE
4969 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4970
371cac43
PE
4971 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4972 Reported by Stefan Monnier in
4973 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4974 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4975 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4976
d01a7826
PE
4977 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4978 (EMACS_UINTPTR): Likewise, with uintptr_t.
4979
7fd47d5c
PE
4980 * lisp.h: Prefer 64-bit EMACS_INT if available.
4981 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4982 on 32-bit hosts that have 64-bit int, so that they can access
4983 large files.
122b0c86
PE
4984 However, temporarily disable this change unless the temporary
4985 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4986
8727937b
PE
4987 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4988
8ac068ac
PE
4989 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4990 This removes an assumption that EMACS_INT and long are the same
4991 width as pointers. The assumption is true for Emacs porting targets
4992 now, but we want to make other targets possible.
4993 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4994 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4995 In the rest of the code, change types of integers that hold casted
4996 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4997 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4998 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4999 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5000 No need to cast type when ORing.
5001 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5002 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5003 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5004 assume EMACS_INT is the same width as char *.
5005 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5006 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5007 Remove no-longer-needed casts.
5008 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5009 (xg_tool_bar_help_callback, xg_make_tool_item):
5010 Use EMACS_INTPTR to hold an integer
5011 that will be cast to void *; this can avoid a GCC warning
5012 if EMACS_INT is not the same width as void *.
5013 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5014 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5015 (current_message_1, set_message_1):
5016 Use a local to convert to proper width without a cast.
5017 * xmenu.c (dialog_selection_callback): Likewise.
5018
ede49d71
PE
5019 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5020 Also, don't assume VALBITS / RAND_BITS is less than 5,
5021 and don't rely on undefined behavior when shifting a 1 left into
5022 the sign bit.
5023 * lisp.h (get_random): Change signature to match.
5024
2f30ecd0
PE
5025 * lread.c (hash_string): Use size_t, not int, for hash computation.
5026 Normally we prefer signed values; but hashing is special, because
5027 it's better to use unsigned division on hash table sizes so that
5028 the remainder is nonnegative. Also, size_t is the natural width
5029 for hashing into memory. The previous code used 'int', which doesn't
5030 retain enough info to hash well into very large tables.
5031 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5032
2a866e7b
PE
5033 * dbusbind.c: Don't possibly lose pointer info when converting.
5034 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5035 Use XPNTR rather than XHASH, so that the high-order bits of
5036 the pointer aren't lost when converting through void *.
5037
51639eac
PE
5038 * eval.c (Fautoload): Don't double-shift a pointer.
5039
92394119
PE
5040 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5041
dbdb9a7c
JB
50422011-05-06 Juanma Barranquero <lekktu@gmail.com>
5043
5044 * gnutls.c (DEF_GNUTLS_FN):
5045 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5046
db7a0b4f
AS
50472011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5048
5049 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5050 marker. (Bug#8610)
5051
f7ff1b0f 50522011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5053
5054 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5055 New version that can reserve upto 2GB of heap space.
5056
f7ff1b0f 50572011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5058
5059 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5060
639c109b
TZ
50612011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5062
5063 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5064 `gnutls_certificate_set_x509_key_file'.
5065
d2127135
JB
50662011-05-05 Juanma Barranquero <lekktu@gmail.com>
5067
5068 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5069 Update dependencies.
5070
e968f4f3
JB
50712011-05-04 Juanma Barranquero <lekktu@gmail.com>
5072
5073 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5074 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5075 Remove unused parameter `fildes'.
5076 * process.c (read_process_output, send_process): Don't pass it.
5077
84d358f0
JB
50782011-05-04 Juanma Barranquero <lekktu@gmail.com>
5079
5080 Fix previous change: the library cache is defined in w32.c.
5081 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5082 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5083
0898ca10
JB
50842011-05-04 Juanma Barranquero <lekktu@gmail.com>
5085
5086 Implement dynamic loading of GnuTLS on Windows.
5087
5088 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5089 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5090 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5091 Declare.
5092
5093 * gnutls.c (Qgnutls_dll): Define.
5094 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5095 (gnutls_*): Declare function pointers.
5096 (init_gnutls_functions): New function to initialize function pointers.
5097 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5098 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5099 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5100 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5101 (emacs_gnutls_write, emacs_gnutls_read)
5102 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5103 (Fgnutls_available_p): New function.
5104 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5105 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5106 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5107
5108 * image.c: Include w32.h.
5109 (Vimage_type_cache): Delete.
5110 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5111 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5112 (w32_delayed_load): Move to w32.c.
5113
5114 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5115
5116 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5117 (w32_delayed_load): Move from image.c. When loading a library, record
5118 its filename in the :loaded-from property of the library id.
5119 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5120 Initialize and staticpro them.
5121 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5122
5123 * process.c: Include lisp.h before w32.h, not after.
5124 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5125 instead of gnutls_record_check_pending.
5126
5127 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5128
ff4de4aa
TZ
51292011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5130
5131 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5132 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5133 as passed in.
5134
abe95abb
JD
51352011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5136
5137 * xterm.c (x_set_frame_alpha): Do not set property on anything
5138 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5139
e16e55d4
JB
51402011-05-02 Juanma Barranquero <lekktu@gmail.com>
5141
5142 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5143
bafcf6a5
JB
51442011-05-02 Juanma Barranquero <lekktu@gmail.com>
5145
5146 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5147 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5148 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5149 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5150 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5151 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5152 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5153 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5154 (Qgnutls_bootprop_callbacks_verify): Make static.
5155
e7a6747f
AS
51562011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5157
19ed11ba
AS
5158 * callproc.c: Indentation fixup.
5159
e7a6747f 5160 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5161 (wait_for_termination, interruptible_wait_for_termination):
5162 Move after wait_for_termination_1.
e7a6747f 5163
1ef14cb4
LMI
51642011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5165
5166 * sysdep.c (interruptible_wait_for_termination): New function
5167 which is like wait_for_termination, but allows keyboard
5168 interruptions.
5169
5170 * callproc.c (Fcall_process): Add (:file "file") as an option for
5171 the STDOUT buffer.
5172 (Fcall_process_region): Ditto.
5173
330d880c
EZ
51742011-04-30 Eli Zaretskii <eliz@gnu.org>
5175
8db90b73
EZ
5176 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5177 rather than `XVECTOR (FOO)->size'.
5178
330d880c
EZ
5179 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5180 inttypes.h, as a gnulib replacement is used if it not available in
5181 system headers.
5182
15cbd324
EZ
51832011-04-21 Eli Zaretskii <eliz@gnu.org>
5184
5185 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5186 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5187 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5188
5189 * coding.c (coding_alloc_by_realloc): Error out if destination
5190 will grow beyond MOST_POSITIVE_FIXNUM.
5191 (decode_coding_emacs_mule): Abort if there isn't enough place in
5192 charbuf for the composition carryover bytes. Reserve an extra
5193 space for up to 2 characters produced in a loop.
5194 (decode_coding_iso_2022): Abort if there isn't enough place in
5195 charbuf for the composition carryover bytes.
5196
51972011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5198
ae940cca
EZ
5199 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5200 aborting when %lld or %lll format is passed.
5201 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5202 %llo or %llx format is passed. (Bug#8545)
5203
03ab8921
EZ
5204 * window.c (window_scroll_line_based): Use a marker instead of
5205 simple variables to record original value of point. (Bug#7952)
5206
afda1437
EZ
5207 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5208 produced by %s or %c overflows available buffer space. (Bug#8545)
5209
f76dee0c
PE
52102011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5211
5212 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5213 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5214
fdc5744d
JB
52152011-04-28 Juanma Barranquero <lekktu@gmail.com>
5216
5217 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5218
638f053a
JB
52192011-04-28 Juanma Barranquero <lekktu@gmail.com>
5220
5221 * keyboard.c (Qdelayed_warnings_hook): Define.
5222 (command_loop_1): Run `delayed-warnings-hook'
5223 if Vdelayed_warnings_list is non-nil.
5224 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5225 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5226
d178f871
EZ
52272011-04-28 Eli Zaretskii <eliz@gnu.org>
5228
5229 * doprnt.c (doprnt): Don't return value smaller than the buffer
5230 size if the message was truncated. (Bug#8545).
5231
b124fd93
JB
52322011-04-28 Juanma Barranquero <lekktu@gmail.com>
5233
5234 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5235 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5236
e810457d
PE
52372011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5238
5239 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5240
ea51cceb
JB
52412011-04-27 Juanma Barranquero <lekktu@gmail.com>
5242
5243 * makefile.w32-in: Update dependencies.
5244
94dcfacf
EZ
52452011-04-27 Eli Zaretskii <eliz@gnu.org>
5246
5247 Improve `doprnt' and its usage. (Bug#8545)
5248 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5249 `format_end'. Remove support for %l as a conversion specifier.
5250 Don't use xrealloc. Improve diagnostics when the %l size modifier
5251 is used. Update the commentary.
5252
5253 * eval.c (verror): Simplify calculation of size_t.
5254
5255 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5256 messages.
5257
f61f41d7
PE
52582011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5259
5260 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5261 change.
5262
96fb4434
PE
52632011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5264
5265 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5266 This makes this file independent of the recent pseudovector change.
5267
671875da 52682011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5269
69e9b5a3
PE
5270 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5271
b5f869a7 5272 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5273 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5274 Remove unused local.
c8926152 5275 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5276
841a1577 5277 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5278 GCC 4.6.0 optimizes based on type-based alias analysis.
5279 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5280 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5281 != &v->size, and therefore "v->size = 1; b->size = 2; return
5282 v->size;" must therefore return 1. This assumption is incorrect
5283 for Emacs, since it type-puns struct Lisp_Vector * with many other
5284 types. To fix this problem, this patch adds a new type struct
f904488f 5285 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5286 and pseudovectors, and helps optimizing compilers not get fooled
5287 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5288 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5289 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5290 the size member.
eab3844f
PE
5291 (XSETPVECTYPE): Rewrite in terms of new macro.
5292 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5293 This is a bit clearer, and further avoids the possibility of
5294 undesirable aliasing.
5295 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5296 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5297 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5298 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5299 (ASIZE): Now uses header.size rather than size.
5300 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5301 to avoid the hassle of writing XVECTOR (foo)->header.size.
5302 (struct vectorlike_header): New type.
eab3844f
PE
5303 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5304 object, to help avoid aliasing.
5305 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5306 (SUBRP): Likewise, since Lisp_Subr is a special case.
5307 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5308 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5309 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5310 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5311 changed to be "header.size" and "header.next".
5312 * buffer.h (struct buffer): Likewise.
5313 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5314 * frame.h (struct frame): Likewise.
5315 * process.h (struct Lisp_Process): Likewise.
5316 * termhooks.h (struct terminal): Likewise.
5317 * window.c (struct save_window_data, struct saved_window): Likewise.
5318 * window.h (struct window): Likewise.
5319 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5320 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5321 * buffer.c (init_buffer_once): Likewise.
5322 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5323 special case.
5324 * process.c (Fformat_network_address): Use local var for size,
5325 for brevity.
5326
0df1eac5
PE
5327 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5328
847ab9d1 5329 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5330 * data.c (atof): Remove decl; no longer used or needed.
5331 (digit_to_number): Move to lread.c.
5332 (Fstring_to_number): Use new string_to_number function, to be
5333 consistent with how the Lisp reader treats infinities and NaNs.
5334 Do not assume that floating-point numbers represent EMACS_INT
5335 without losing information; this is not true on most 64-bit hosts.
5336 Avoid double-rounding errors, by insisting on integers when
5337 parsing non-base-10 numbers, as the documentation specifies.
5338 * lisp.h (string_to_number): New decl, replacing ...
5339 (isfloat_string): Remove.
bc0a5c13 5340 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5341 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5342 appears to have been a coding error. Similarly, do not accept
5343 strings like +-1e0 as floating point numbers. Do not report
5344 overflow for integer overflows unless the base is not 10 which
5345 means we have no simple and reliable way to continue.
5346 Break out the floating-point parsing into a new
5347 function string_to_number, so that Fstring_to_number parses
5348 floating point numbers consistently with the Lisp reader.
04f2d78b 5349 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5350 (E_CHAR, EXP_INT): Remove, replacing with ...
5351 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5352 (string_to_number): New function, replacing isfloat_string.
5353 This function checks for valid syntax and produces the resulting
5354 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5355 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5356 so that overflow for non-base-10 numbers is reported only when
5357 there's no portable and simple way to convert to floating point.
452f4150 5358
67769ffc
PE
5359 * textprop.c (set_text_properties_1): Rewrite for clarity,
5360 and to avoid GCC warning about integer overflow.
5361
c20db43f
PE
5362 * intervals.h (struct interval): Use EMACS_INT for members
5363 where EMACS_UINT might cause problems. See
5364 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5365 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5366 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5367 All uses changed.
37aa2f85
PE
5368 (offset_intervals): Tell GCC not to worry about length overflow
5369 when negating a negative length.
c20db43f 5370
2538aa2f
PE
5371 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5372 (overrun_check_free): Likewise.
5373
f2d3008d
PE
5374 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5375 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5376 word size.
5377
ec8df744
PE
5378 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5379 (gnutls_make_error): Rename local to avoid shadowing.
5380 (gnutls_emacs_global_deinit): ifdef out; not used.
5381 (Fgnutls_boot): Use const for pointer to readonly storage.
5382 Comment out unused local. Fix pointer signedness problems.
5383
640ee02d
PE
5384 * lread.c (openp): Don't stuff size_t into an 'int'.
5385 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5386 about possible signed overflow.
5387
6048fb2a
PE
5388 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5389 (GDK_KEY_g): Don't define if already defined.
5390 (xg_prepare_tooltip): Avoid pointer signedness problem.
5391 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5392
fa3c87e1
PE
5393 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5394 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5395
2172544b
PE
5396 * xfns.c (Fx_window_property): Simplify a bit,
5397 to make a bit faster and to avoid GCC 4.6.0 warning.
5398 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5399
9b821a21
PE
5400 * fns.c (internal_equal): Don't assume size_t fits in int.
5401
3c616cfa
PE
5402 * alloc.c (compact_small_strings): Tighten assertion a little.
5403
c2982e87
PE
5404 Replace pEd with more-general pI, and fix some printf arg casts.
5405 * lisp.h (pI): New macro, generalizing old pEd macro to other
5406 conversion specifiers. For example, use "...%"pI"d..." rather
5407 than "...%"pEd"...".
5408 (pEd): Remove. All uses replaced with similar uses of pI.
5409 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5410 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5411 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5412 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5413 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5414 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5415 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5416 64-bit hosts.
5417 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5418 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5419 * print.c (safe_debug_print, print_object): Likewise.
5420 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5421 to int.
6f04d126
PE
5422 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5423 avoiding the 0 flag, which is not portable.
c2982e87
PE
5424 * process.c (Fmake_network_process): Use pI to avoid cast.
5425 * region-cache.c (pp_cache): Likewise.
5426 * xdisp.c (decode_mode_spec): Likewise.
5427 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5428 behavior on 64-bit hosts with printf arg.
6f04d126 5429 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5430 (x_stop_queuing_selection_requests): Likewise.
5431 (x_get_window_property): Don't truncate byte count to an 'int'
5432 when tracing.
0b432f21 5433
5e073ec7
PE
5434 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5435 here, since it parses constructs like leading '-' and spaces,
5436 which are not wanted; and it overflows with large numbers.
5437 Instead, simply match F[0-9]+, which is what is wanted anyway.
5438
36372bf9
PE
5439 * alloc.c: Remove unportable assumptions about struct layout.
5440 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5441 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5442 (allocate_vectorlike, make_pure_vector): Use the new macros,
5443 plus offsetof, to remove unportable assumptions about struct layout.
5444 These assumptions hold on all porting targets that I know of, but
5445 they are not guaranteed, they're easy to remove, and removing them
5446 makes further changes easier.
5447
0b432f21
PE
5448 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5449 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5450 (string_overrun_cookie): Now const. Use initializers that
5451 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5452 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5453 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5454 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5455 multiple of sizeof (EMACS_INT); it need not be, if
5456 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5457 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5458
895009e1
JB
54592011-04-26 Juanma Barranquero <lekktu@gmail.com>
5460
5461 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5462
6a7a1b0b
TZ
54632011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5464
5465 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5466 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5467 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5468
841a1577 54692011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5470
5471 * lisp.h (Qdebug): List symbol.
895009e1 5472 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5473 * keyboard.c (debug-on-event): New variable.
5474 (handle_user_signal): Break into debugger when debug-on-event
5475 matches the current signal symbol.
5476
f2d3ba6f
DN
54772011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5478
5479 * alloc.c (check_sblock, check_string_bytes)
5480 (check_string_free_list): Convert to standard C.
5481
42ce4c63
TZ
54822011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5483
5484 * w32.c (emacs_gnutls_push): Fix typo.
5485
825cd63c
EZ
54862011-04-25 Eli Zaretskii <eliz@gnu.org>
5487
fb11d64d
EZ
5488 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5489 "cast to pointer from integer of different size".
5490
825cd63c
EZ
5491 Improve doprnt and its use in verror. (Bug#8545)
5492 * doprnt.c (doprnt): Document the set of format control sequences
5493 supported by the function. Use SAFE_ALLOCA instead of always
5494 using `alloca'.
5495
5496 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5497 is one byte too soon. Don't use xrealloc; instead xfree and
5498 xmalloc anew.
5499
e061a11b
TZ
55002011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5501
5502 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5503 callbacks stage.
5504
5505 * gnutls.c: Renamed global_initialized to
5506 gnutls_global_initialized. Added internals for the
5507 :verify-hostname-error, :verify-error, and :verify-flags
5508 parameters of `gnutls-boot' and documented those parameters in the
5509 docstring. Start callback support.
9173deec
JB
5510 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5511 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5512 on error. Return error code.
e061a11b
TZ
5513 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5514 (emacs_gnutls_read): Likewise.
5515 (Fgnutls_boot): Return handshake error code.
5516 (emacs_gnutls_handle_error): New function.
5517 (wsaerror_to_errno): Likewise.
5518
5519 * w32.h (emacs_gnutls_pull): Add prototype.
5520 (emacs_gnutls_push): Likewise.
5521
5522 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5523 (emacs_gnutls_push): Likewise.
5524
55252011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5526
5527 * process.c (wait_reading_process_output): Check if GnuTLS
5528 buffered some data internally if no FDs are set for TLS
5529 connections.
5530
5531 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5532 (LIBS): Link to USER_LIBS.
5533 ($(BLD)/gnutls.$(0)): New target.
5534
fa6996bc
EZ
55352011-04-24 Eli Zaretskii <eliz@gnu.org>
5536
eb35682e
EZ
5537 * xdisp.c (handle_single_display_spec): Rename the
5538 display_replaced_before_p argument into display_replaced_p, to
5539 make it consistent with the commentary. Fix typos in the
5540 commentary.
5541
e2ad650c
EZ
5542 * textprop.c (syms_of_textprop): Remove dead code.
5543 (copy_text_properties): Delete obsolete commentary about an
5544 interface that was deleted long ago. Fix typos in the description
5545 of arguments.
5546
1b2de274
EZ
5547 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5548 to changes in oldXMenu/XMenu.h from 2011-04-16.
5549 <menu_help_message, prev_menu_help_message>: Constify.
5550 (IT_menu_make_room): menu->help_text is now `const char **';
5551 adjust.
5552
5553 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5554 to changes in oldXMenu/XMenu.h from 2011-04-16.
5555 (struct XMenu): Declare `help_text' `const char **'.
5556
5557 * xfaces.c <Qunspecified>: Make extern again.
5558
5559 * syntax.c: Include sys/types.h before including regex.h, as
5560 required by Posix.
5561
762b15be
EZ
5562 * doc.c (get_doc_string): Improve the format passed to `error'.
5563
5564 * doprnt.c (doprnt): Improve commentary.
5565
5566 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5567
5568 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5569 them with etags.
5570
f1052e5d
EZ
5571 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5572 changes in globals.h immediately force recompilation.
762b15be
EZ
5573 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5574 $(CURDIR)/s/ms-w32.h.
5575 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5576
fa6996bc
EZ
5577 * character.c (Fchar_direction): Function deleted.
5578 (syms_of_character): Don't defsubr it.
5579 <char-direction-table>: Deleted.
5580
e6c3da20
EZ
55812011-04-23 Eli Zaretskii <eliz@gnu.org>
5582
5583 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5584 * doprnt.c: Include limits.h.
5585 (SIZE_MAX): New macro.
04f2d78b
CB
5586 (doprnt): Return a size_t value. 2nd arg is now size_t.
5587 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5588 Improve overflow protection. Support `l' modifier for integer
5589 conversions. Support %l conversion. Don't assume an EMACS_INT
5590 argument for integer conversions and for %c.
5591
5592 * lisp.h (doprnt): Restore prototype.
5593
5594 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5595 $(SRC)/character.h.
5596
5597 * Makefile.in (base_obj): Add back doprnt.o.
5598
5599 * deps.mk (doprnt.o): Add back prerequisites.
5600 (callint.o): Depend on character.h.
5601
5602 * eval.c (internal_lisp_condition_case): Include the handler
5603 representation in the error message.
5604 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5605 when breaking from the loop.
5606
5607 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5608
5609 * callint.c (Fcall_interactively): When displaying error message
5610 about invalid control letter, pass the character's codepoint, not
5611 a pointer to its multibyte form. Improve display of the character
5612 in octal and display also its hex code.
5613
5614 * character.c (char_string): Use %x to display the (unsigned)
5615 codepoint of an invalid character, to avoid displaying a bogus
5616 negative value.
5617
5618 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5619 `error', not SYMBOL_NAME itself.
5620
5621 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5622 character arguments to `error'.
5623
5624 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5625 to `error' in error message about FINAL_CHAR argument. Make sure
5626 FINAL_CHAR is a character, and use %c when it is passed as
5627 argument to `error'.
5628
4ffd0d6b 56292011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5630
5631 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5632
5633 * w32.c: Include <time.h>.
5634 (sys_localtime): New function.
5635
4ffd0d6b 56362011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5637
5638 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5639
4ffd0d6b 5640 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5641
4ffd0d6b 56422011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5643
4ffd0d6b
GM
5644 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5645 zombies (Bug#8467).
aac0c6e3 5646
04c56954
EZ
56472011-04-19 Eli Zaretskii <eliz@gnu.org>
5648
5649 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5650 gl_state.e_property when gl_state.object is Qt.
5651
5652 * insdel.c (make_gap_larger): Remove limitation of buffer size
5653 to <= INT_MAX.
5654
16a43933
CY
56552011-04-18 Chong Yidong <cyd@stupidchicken.com>
5656
5657 * xdisp.c (lookup_glyphless_char_display)
5658 (produce_glyphless_glyph): Handle cons cell entry in
5659 glyphless-char-display.
5660 (Vglyphless_char_display): Document it.
5661
5662 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5663 glyphless-char-display.
5664
4581706e
CY
56652011-04-17 Chong Yidong <cyd@stupidchicken.com>
5666
5667 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5668
5669 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5670
5671 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5672 definition for no-X builds.
5673
4887c6e2 56742011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5675
fd35b6f9
PE
5676 Static checks with GCC 4.6.0 and non-default toolkits.
5677
5c1ccb01
PE
5678 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5679
006c5daa
PE
5680 * process.c (keyboard_bit_set): Define only if SIGIO.
5681 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5682 (send_process): Repair possible setjmp clobbering.
5683
efc736d3
PE
5684 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5685
4e2fe2e6
PE
5686 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5687
f97334a2
PE
5688 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5689
4e75f29d
PE
5690 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5691 Define only if needed.
5692
90efadd1
PE
5693 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5694 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5695 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5696
3c647824
PE
5697 * dispextern.h (struct redisplay_interface): Rename param
5698 to avoid shadowing.
e264f262 5699 * termhooks.h (struct terminal): Likewise.
761383f4 5700 * xterm.c (xembed_send_message): Likewise.
3c647824 5701
b58c5c4a
PE
5702 * insdel.c (make_gap_smaller): Define only if
5703 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5704
cad59032
PE
5705 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5706 it.
5707
c339dc2e
PE
5708 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5709 so that we aren't warned about unused symbols.
5710
91a3e27b
PE
5711 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5712
399c71d3 5713 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5714
8ffc96f5
PE
5715 * xfns.c (x_real_positions): Mark locals as initialized.
5716
eef9bc79
PE
5717 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5718
098db9dd
PE
5719 * xterm.c: Fix problems found by static analysis with other toolkits.
5720 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5721 (x_dispatch_event): Declare static if USE_GTK, and
5722 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5723 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5724 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5725 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5726 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5727
eb18f6cc
PE
5728 * xmenu.c (menu_help_callback): Pointer type fixes.
5729 Use const pointers when pointing at readonly data. Avoid pointer
5730 signedness clashes.
5731 (FALSE): Remove unused macro.
5732 (update_frame_menubar): Remove unused decl.
5733
1fe72bf8
PE
5734 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5735
60d9e1db
PE
5736 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5737 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5738 (single_menu_item): Rename local to avoid shadowing.
5739
39261c26
PE
5740 * keyboard.c (make_lispy_event): Remove unused local var.
5741
018c5e19
PE
5742 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5743 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5744
63d2b86e
PE
5745 * bitmaps: Change bitmaps from unsigned char back to the X11
5746 compatible char. Avoid the old compiler warnings about
5747 out-of-range initializers by using, for example, '\xab' rather
5748 than 0xab.
5749
aefd87e1
PE
5750 * xgselect.c (xgselect_initialize): Check vs interface
5751 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5752
bf501fb9
PE
5753 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5754
e9829fdf
PE
5755 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5756 to read-only memory.
5757
1086c095
PE
5758 * fns.c (vector): Remove; this old hack is no longer needed.
5759
2baccd04 5760 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5761 Remove unused var.
dde42981 5762 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5763
72391843 5764 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5765
436c16df 5766 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5767 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5768 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5769
92bb796d 5770 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5771 (x_term_init): Remove local to avoid shadowing.
92bb796d 5772
764430a3 5773 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5774
5775 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5776 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5777
d1dfb56c
EZ
57782011-04-16 Eli Zaretskii <eliz@gnu.org>
5779
c4354cb4
EZ
5780 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5781
d1dfb56c
EZ
5782 Fix regex.c, syntax.c and friends for buffers > 2GB.
5783 * syntax.h (struct gl_state_s): Declare character position members
5784 EMACS_INT.
5785
5786 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5787
04f2d78b
CB
5788 * textprop.c (verify_interval_modification, interval_of):
5789 Declare arguments EMACS_INT.
d1dfb56c
EZ
5790
5791 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5792 EMACS_INT.
5793
5794 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5795
5796 * indent.c (Fvertical_motion): Local variable it_start is now
5797 EMACS_INT.
5798
5799 * regex.c (re_match, re_match_2, re_match_2_internal)
5800 (bcmp_translate, regcomp, regexec, print_double_string)
5801 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5802 (re_compile_pattern, re_exec): Declare arguments and local
5803 variables `size_t' and `ssize_t' and return values `regoff_t', as
5804 appropriate.
5805 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5806 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5807 <compile_stack_type>: `size' and `avail' are now `size_t'.
5808
5809 * regex.h <regoff_t>: Use ssize_t, not int.
5810 (re_search, re_search_2, re_match, re_match_2): Arguments that
5811 specify buffer/string position and length are now ssize_t and
5812 size_t. Return type is regoff_t.
5813
613052cd
BK
58142011-04-16 Ben Key <bkey76@gmail.com>
5815
5816 * nsfont.m: Fixed bugs in ns_get_family and
5817 ns_descriptor_to_entity that were caused by using free to
5818 deallocate memory blocks that were allocated by xmalloc (via
5819 xstrdup). This caused Emacs to crash when compiled with
5820 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5821 --enable-checking=xmallocoverrun). xfree is now used to
5822 deallocate these memory blocks.
5823
4170f62f 58242011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5825
71b41406
PE
5826 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5827
9587a89d
PE
5828 emacs_write: Accept and return EMACS_INT for sizes.
5829 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5830 et seq.
5831 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5832 Accept and return EMACS_INT.
5833 (emacs_gnutls_write): Return the number of bytes written on
5834 partial writes.
5835 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5836 (emacs_read, emacs_write): Remove check for negative size, as the
5837 Emacs source code has been audited now.
9587a89d
PE
5838 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5839 (emacs_read, emacs_write): Use it.
273a5f82
PE
5840 * process.c (send_process): Adjust to the new signatures of
5841 emacs_write and emacs_gnutls_write. Do not attempt to store
5842 a byte offset into an 'int'; it might overflow.
9587a89d 5843 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5844
3e047f51
PE
5845 * sound.c: Don't assume sizes fit in 'int'.
5846 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5847 Return EMACS_INT, not int.
3e047f51 5848 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5849 Accept EMACS_INT, not int.
5850 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5851 record read return values.
5852
cc39a9db
BK
58532011-04-15 Ben Key <bkey76@gmail.com>
5854
c9d0ec6d
JB
5855 * keyboard.c (Qundefined): Don't declare static since it is used
5856 in nsfns.m.
5857 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5858 static since they are used in nsfont.m.
cc39a9db 5859
6c60eb9f
SM
58602011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5861
5862 * process.c (Qprocessp): Don't declare static.
5863 * lisp.h (Qprocessp): Declare again.
5864
7990b61a
JB
58652011-04-15 Juanma Barranquero <lekktu@gmail.com>
5866
5867 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5868
5d4cb038
PE
58692011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5870
8bd7b830 5871 Improve C-level modularity by making more things 'static'.
cd64ea1d 5872
e3b27b31
PE
5873 Don't publish debugger-only interfaces to other modules.
5874 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5875 (verify_bytepos, count_markers): Move decls to the only modules
5876 that need them.
5877 * region-cache.h (pp_cache): Likewise.
5878 * window.h (check_all_windows): Likewise.
5879 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5880
5d4cb038
PE
5881 * sysdep.c (croak): Now static, if
5882 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5883 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5884
5885 * alloc.c (refill_memory_reserve): Now static if
5886 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5887 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5888
e87b6180
PE
5889 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5890 Define only if USE_LUCID.
5891
ac64929e
PE
5892 * xrdb.c (x_customization_string, x_rm_string): Now static.
5893
6f37259d
PE
5894 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5895 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5896
1683e3ab
PE
5897 * xdisp.c (draw_row_with_mouse_face): Now static.
5898 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5899
de9c2632
PE
5900 * window.h (check_all_windows): Mark externally visible.
5901
2b96acb7
PE
5902 * window.c (window_deletion_count): Now static.
5903
5904 * undo.c: Make symbols static if they're not exported.
5905 (last_undo_buffer, last_boundary_position, pending_boundary):
5906 Now static.
5907
50436f33
PE
5908 * textprop.c (interval_insert_behind_hooks): Now static.
5909 (interval_insert_in_front_hooks): Likewise.
5910
64520e5c
PE
5911 * term.c: Make symbols static if they're not exported.
5912 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5913 (max_frame_lines, tty_set_terminal_modes):
5914 (tty_reset_terminal_modes, tty_turn_off_highlight):
5915 (get_tty_terminal): Now static.
5916 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5917 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5918 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5919 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5920 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5921
1fa53021
PE
5922 * sysdep.c: Make symbols static if they're not exported.
5923 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5924 Now static.
5925 (sigprocmask_set, full_mask): Remove; unused.
5926 (wait_debugging): Mark as visible.
5927 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5928 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5929
d4b43b22
PE
5930 * syntax.c (syntax_temp): Define only if !__GNUC__.
5931
b7c513d0
PE
5932 * sound.c (current_sound_device, current_sound): Now static.
5933
989b29ad
PE
5934 * search.c (searchbufs, searchbuf_head): Now static.
5935
13a55a78
PE
5936 * scroll.c (scroll_cost): Remove; unused.
5937 * dispextern.h (scroll_cost): Remove decl.
5938
de68a1fc
PE
5939 * region-cache.h (pp_cache): Mark as externally visible.
5940
40ccffa6
PE
5941 * process.c: Make symbols static if they're not exported.
5942 (process_tick, update_tick, create_process, chan_process):
5943 (Vprocess_alist, proc_buffered_char, datagram_access):
5944 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5945 (deactivate_process): Mark defn as static, as well as decl.
5946 * lisp.h (create_process): Remove decl.
5947 * process.h (chan_process, Vprocess_alist): Remove decls.
5948
ad64fc97
PE
5949 * print.c: Make symbols static if they're not exported.
5950 (print_depth, new_backquote_output, being_printed, print_buffer):
5951 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5952 (print_interval, print_number_index, initial_stderr_stream):
5953 Now static.
5954 * lisp.h (Fprinc): Remove decl.
5955 (debug_output_compilation_hack): Mark as externally visible.
5956
adddb265
PE
5957 * sysdep.c (croak): Move decl from here to syssignal.h.
5958 * syssignal.h (croak): Put it here, so the API can be checked when
5959 'croak' is called from dissociate_if_controlling_tty.
5960
1717ede2
PE
5961 * minibuf.c: Make symbols static if they're not exported.
5962 (minibuf_save_list, choose_minibuf_frame): Now static.
5963 * lisp.h (choose_minibuf_frame): Remove decl.
5964
fa5fb2bc
PE
5965 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5966
1e3890d1
PE
5967 * lread.c: Make symbols static if they're not exported.
5968 (read_objects, initial_obarray, oblookup_last_bucket_number):
5969 Now static.
5970 (make_symbol): Remove; unused.
5971 * lisp.h (initial_obarray, make_symbol): Remove decls.
5972
8a1414fa
PE
5973 * keyboard.c: Make symbols static if they're not exported.
5974 (single_kboard, recent_keys_index, total_keys, recent_keys):
5975 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5976 (this_single_command_key_start, echoing, last_auto_save):
5977 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5978 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5979 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5980 (Vlispy_mouse_stem, double_click_count):
5981 Now static.
5982 (force_auto_save_soon): Define only if SIGDANGER.
5983 (ignore_mouse_drag_p): Now static if
5984 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5985 (print_help): Remove; unused.
5986 (stop_character, last_timer_event): Mark as externally visible.
5987 * keyboard.h (ignore_mouse_drag_p): Declare only if
5988 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5989 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5990 * lisp.h (echoing): Remove decl.
5991 (force_auto_save_soon): Declare only if SIGDANGER.
5992 * xdisp.c (redisplay_window): Simplify code, to make it more
5993 obvious that ignore_mouse_drag_p is not accessed if !defined
5994 USE_GTK && !defined HAVE_NS.
5995
93ea6e8f
PE
5996 * intervals.c: Make symbols static if they're not exported.
5997 (merge_properties_sticky, merge_interval_right, delete_interval):
5998 Now static.
5999 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6000
77382fcc
PE
6001 * insdel.c: Make symbols static if they're not exported.
6002 However, leave prepare_to_modify_buffer alone. It's never
6003 called from outside this function, but that appears to be a bug.
6004 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6005 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6006 (adjust_after_replace_noundo): Remove; unused.
6007 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6008 (signal_before_change): Remove decls.
77382fcc 6009
9306c32e
PE
6010 * indent.c (val_compute_motion, val_vmotion): Now static.
6011
cd44d2eb
PE
6012 * image.c: Make symbols static if they're not exported.
6013 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6014 if USE_GTK.
6015 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6016 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6017
ad9a7a06
PE
6018 * fringe.c (standard_bitmaps): Now static.
6019 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6020
81626931
PE
6021 * frame.c: Make symbols static if they're not exported.
6022 (x_report_frame_params, make_terminal_frame): Now static.
6023 (get_frame_param): Now static, unless HAVE_NS.
6024 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6025 (x_get_resource_string): Remove; not used.
6026 * frame.h (make_terminal_frame, x_report_frame_params):
6027 (x_get_resource_string); Remove decls.
6028 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6029 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6030
239f9db9
PE
6031 * font.c, fontset.c: Make symbols static if they're not exported.
6032 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6033 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6034 * font.c (font_close_object): Now static.
6035 * font.h (font_close_object): Remove.
6036 * fontset.c (FONTSET_OBJLIST): Remove.
6037 (free_realized_fontset) #if-0 the body, which does nothing.
6038 (face_suitable_for_char_p): #if-0, as it's never called.
6039 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6040 * xfaces.c (face_at_string_position):
6041 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6042 since 0 is always ASCII.
6043
dfcf3579
PE
6044 * fns.c (weak_hash_tables): Now static.
6045
5045092b
PE
6046 * fileio.c: Make symbols static if they're not exported.
6047 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6048 (Vwrite_region_annotation_buffers): Now static.
6049
57a96f5c
PE
6050 * eval.c: Make symbols static if they're not exported.
6051 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6052 * lisp.h (backtrace_list): Remove decl.
6053
35f08c38
PE
6054 * emacs.c: Make symbols static if they're not exported.
6055 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6056 (fatal_error_code, fatal_error_signal_hook, standard_args):
6057 Now static.
6058 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6059 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6060 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6061 * lisp.h (fatal_error_signal_hook): Remove decl.
6062 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6063
f44bd759
PE
6064 * editfns.c: Move a (normally-unused) function to its only use.
6065 * editfns.c, lisp.h (get_operating_system_release): Remove.
6066 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6067 worth the hassle of breaking this out.
6068
b532497d
PE
6069 * xterm.c: Make symbols static if they're not exported.
6070 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6071 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6072 (x_destroy_window, x_delete_display):
6073 Now static.
6074 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6075 (x_mouse_leave): Remove; unused.
6076 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6077 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6078 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6079 Remove decls.
6080 (x_mouse_leave): Declare only if WINDOWSNT.
6081 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6082 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6083 USE_X_TOOLKIT.
6084
1675728f
PE
6085 * ftxfont.c: Make symbols static if they're not exported.
6086 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6087 HAVE_FREETYPE.
6088 * font.h (ftxfont_driver): Likewise.
6089
e4cebfca
PE
6090 * xfns.c: Make symbols static if they're not exported.
6091 (x_last_font_name, x_display_info_for_name):
6092 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6093 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6094 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6095 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6096 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6097 (last_show_tip_args): Now static.
6098 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6099 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6100 (x_screen_planes): Remove; unused.
6101 * dispextern.h (x_screen_planes): Remove decl.
6102
5bf46f05
PE
6103 * dispnew.c: Make symbols static if they're not exported.
6104 * dispextern.h (redraw_garbaged_frames, scrolling):
6105 (increment_row_positions): Remove.
6106 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6107 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6108 Now static.
6109 (redraw_garbaged_frames): Remove; unused.
6110
435f4c28
PE
6111 * xfaces.c: Make symbols static if they're not exported.
6112 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6113 Remove decls.
6114 * xterm.h (defined_color): Remove decls.
6115 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6116 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6117 (menu_face_changed_default, defined_color, free_realized_face):
6118 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6119 (ascii_face_of_lisp_face): Remove; unused.
6120
8524aef3
PE
6121 * xdisp.c: Make symbols static if they're not exported.
6122 * dispextern.h (scratch_glyph_row, window_box_edges):
6123 (glyph_to_pixel_coords, set_cursor_from_row):
6124 (get_next_display_element, set_iterator_to_next):
6125 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6126 (show_mouse_face): Remove decls
6127 * frame.h (message_buf_print): Likewise.
6128 * lisp.h (pop_message, set_message, check_point_in_composition):
6129 Likewise.
6130 * xterm.h (set_vertical_scroll_bar): Likewise.
6131 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6132 (message_buf_print, scratch_glyph_row, displayed_buffer):
6133 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6134 (get_next_display_element, show_mouse_face, window_box_edges):
6135 (frame_to_window_pixel_xy, check_point_in_composition):
6136 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6137 (glyph_to_pixel_coords): Remove; unused.
6138
16390cd2
PE
6139 * dired.c (file_name_completion): Now static.
6140
6141 * dbusbind.c (xd_in_read_queued_messages): Now static.
6142
a25f4dfa
PE
6143 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6144 * data.c (circular_list_error): Remove.
6145
14a9c8df
PE
6146 * commands.h (last_point_position, last_point_position_buffer):
6147 (last_point_position_window): Remove decls.
6148 * keyboard.c: Make these variables static.
6149
04f2d78b
CB
6150 * coding.h (coding, code_convert_region, encode_coding_gap):
6151 Remove decls.
74ab6df5
PE
6152 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6153 (iso_code_class, detect_coding, code_convert_region): Now static.
6154 (encode_coding_gap): Remove; unused.
6155
38dfbee1
PE
6156 * chartab.c (chartab_chars, chartab_bits): Now static.
6157
a2cb4e63
PE
6158 * charset.h (charset_iso_8859_1): Remove decl.
6159 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6160 Now static.
6161
127198fd
PE
6162 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6163 * ccl.c (Vccl_program_table): Now static.
6164 (check_ccl_update): Remove; unused.
6165
d85b608f
PE
6166 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6167 * category.h: ... from here.
6168 * category.c (check_category_table, set_category_set): Now static.
6169
31cd66f3
PE
6170 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6171 * lisp.h: Remove these decls.
6172
c358e587
PE
6173 * buffer.c (buffer_count): Remove unused var.
6174
e78aecca
PE
6175 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6176 so that it's not optimized away.
6177 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6178 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6179 exported only to the debugger.
6180
e192d7d3 6181 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6182 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6183
92470028
PE
6184 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6185 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6186 was inaccessible from Lisp.
6187 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6188 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6189
244ed907
PE
6190 alloc.c: Import and export fewer symbols, and remove unused items.
6191 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6192 is defined.
6193 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6194 it's not optimized away by whole-program optimization.
6195 (message_enable_multibyte, free_misc): Remove.
6196 (catchlist, handlerlist, mark_backtrace):
6197 Declare only if BYTE_MARK_STACK.
6198 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6199 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6200 (message_enable_multibyte): Remove decl.
6201 (free_misc, interval_free_list, float_block, float_block_index):
6202 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6203 (cons_free_list, last_marked_index):
6204 Now static.
6205 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6206 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6207 (mark_backtrace): Define only if BYTE_MARK_STACK.
6208 * xdisp.c (message_enable_multibyte): Now static.
6209
61c2b50e 6210 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6211 This makes it easier for human readers (and static analyzers)
6212 to see whether these variables are used from other modules.
6213 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6214 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6215 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6216 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6217 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6218 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6219 * xmenu.c, xselect.c:
6220 Declare Q* vars static if they are not used in other modules.
6221 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6222 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6223 Remove decls of unexported vars.
6224 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6225
95c82688
PE
6226 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6227
16a97296
PE
6228 Make Emacs functions such as Fatom 'static' by default.
6229 This makes it easier for human readers (and static analyzers)
6230 to see whether these functions can be called from other modules.
6231 DEFUN now defines a static function. To make the function external
6232 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6233 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6234 (Finit_image_library):
16a97296
PE
6235 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6236 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6237 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6238 Remove decls, since these functions are now static.
6239 (Funintern, Fget_internal_run_time): New decls, since these functions
6240 were already external.
95c82688 6241
16a97296
PE
6242 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6243 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6244 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6245 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6246 * keyboard.c, keymap.c, lread.c:
6247 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6248 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6249 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6250 Mark functions with DEFUE instead of DEFUN,
6251 if they are used in other modules.
6252 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6253 decls for now-static functions.
6254 * buffer.h (Fdelete_overlay): Remove decl.
6255 * callproc.c (Fgetenv_internal): Mark as internal.
6256 * composite.c (Fremove_list_of_text_properties): Remove decl.
6257 (Fcomposition_get_gstring): New forward static decl.
6258 * composite.h (Fcomposite_get_gstring): Remove decl.
6259 * dired.c (Ffile_attributes): New forward static decl.
6260 * doc.c (Fdocumntation_property): New forward static decl.
6261 * eval.c (Ffetch_bytecode): New forward static decl.
6262 (Funintern): Remove extern decl; now in .h file where it belongs.
6263 * fileio.c (Fmake_symbolic_link): New forward static decl.
6264 * image.c (Finit_image_library): New forward static decl.
6265 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6266 * intervals.h (Fprevious_property_change):
6267 (Fremove_list_of_text_properties): Remove decls.
6268 * keyboard.c (Fthis_command_keys): Remove decl.
6269 (Fcommand_execute): New forward static decl.
6270 * keymap.c (Flookup_key): New forward static decl.
6271 (Fcopy_keymap): Now static.
6272 * keymap.h (Flookup_key): Remove decl.
6273 * process.c (Fget_process): New forward static decl.
6274 (Fprocess_datagram_address): Mark as internal.
6275 * syntax.c (Fsyntax_table_p): New forward static decl.
6276 (skip_chars): Remove duplicate decl.
6277 * textprop.c (Fprevious_property_change): New forward static decl.
6278 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6279 Now internal.
6280 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6281 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6282
785bbd42
PE
6283 * editfns.c (Fformat): Remove unreachable code.
6284
8b913b57
AS
62852011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6286
6287 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6288 change. (Bug#8496)
6289
a6744a35
EZ
62902011-04-13 Eli Zaretskii <eliz@gnu.org>
6291
6292 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6293 when at ZV. (Bug#8487)
6294
e7974947
AS
62952011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6296
baad03f0
AS
6297 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6298 (Bug#8437)
6299 * keyboard.c (parse_tool_bar_item): Likewise.
6300 * sound.c (sound_cleanup, alsa_close): Likewise.
6301 * termcap.c (tgetent): Likewise.
6302 * xfns.c (x_default_font_parameter): Likewise.
6303 * xsettings.c (read_and_apply_settings): Likewise.
6304
e7974947
AS
6305 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6306 (overrun_check_free): Protoize.
6307
28272684
PE
63082011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6309
6310 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6311 since callers should never pass a negative size.
6312 Change the signature to match that of plain 'read' and 'write'; see
6313 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6314 * lisp.h: Update prototypes of emacs_write and emacs_read.
6315
11997c76
EZ
63162011-04-11 Eli Zaretskii <eliz@gnu.org>
6317
6318 * xdisp.c (redisplay_window): Don't try to determine the character
6319 position of the scroll margin if the window start point w->startp
e896f03c 6320 is outside the buffer's accessible region. (Bug#8468)
11997c76 6321
8a2cbd72
EZ
63222011-04-10 Eli Zaretskii <eliz@gnu.org>
6323
6324 Fix write-region and its subroutines for buffers > 2GB.
6325 * fileio.c (a_write, e_write): Modify declaration of arguments and
6326 local variables to support buffers larger than 2GB.
6327 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6328
6329 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6330 argument, local variables, and return value.
6331
6332 * lisp.h: Update prototypes of emacs_write and emacs_read.
6333
6334 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6335
4073e537 63362011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6337
1ebfdcb6
PE
6338 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6339
b2ded58d
PE
6340 Fix more problems found by GCC 4.6.0's static checks.
6341
7d66342c
PE
6342 * xdisp.c (vmessage): Use a better test for character truncation.
6343
bbf47d44
PE
6344 * charset.c (load_charset_map): <, not <=, for optimization,
6345 and to avoid potential problems with integer overflow.
9248994d 6346 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6347 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6348 * editfns.c (Fformat): Likewise.
1e69125e 6349 * syntax.c (skip_chars): Likewise.
3befa583 6350
e3019616
PE
6351 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6352 This also lets GCC 4.6.0 generate slightly better loop code.
6353
becfa255
PE
6354 * callint.c (Fcall_interactively): <, not <=, for optimization.
6355 (Fcall_interactively): Count the number of arguments produced,
6356 not the number of arguments given. This is simpler and lets GCC
6357 4.6.0 generate slightly better code.
6358
dae0cd48
PE
6359 * ftfont.c: Distingish more carefully between FcChar8 and char.
6360 The previous code passed unsigned char * to a functions like
6361 strlen and xstrcasecmp that expect char *, which does not
6362 conform to the C standard.
6363 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6364 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6365 char * when the C standard requires it.
6366
76032d70
PE
6367 * keyboard.c (read_char): Remove unused var.
6368
eb3f1cc8
PE
6369 * eval.c: Port to Windows vsnprintf (Bug#8435).
6370 Include <limits.h>.
6371 (SIZE_MAX): Define if the headers do not.
6372 (verror): Do not give up if vsnprintf returns a negative count.
6373 Instead, grow the buffer. This ports to Windows vsnprintf, which
6374 does not conform to C99. Problem reported by Eli Zaretskii.
6375 Also, simplify the allocation scheme, by avoiding the need for
6376 calling realloc, and removing the ALLOCATED variable.
6377
70476b54
PE
6378 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6379
12020a9e
PE
6380 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6381 But keep the doprint source code for now, as we might revamp it
6382 and use it again (Bug#8435).
ea6c7ae6
PE
6383 * lisp.h (doprnt): Remove.
6384 * Makefile.in (base_obj): Remove doprnt.o.
6385 * deps.mk (doprnt.o): Remove.
6386
5fdb398c
PE
6387 error: Print 32- and 64-bit integers portably (Bug#8435).
6388 Without this change, on typical 64-bit hosts error ("...%d...", N)
6389 was used to print both 32- and 64-bit integers N, which relied on
6390 undefined behavior.
6391 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6392 New macro.
6393 * lisp.h (error, verror): Mark as printf-like functions.
6394 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6395 Report overflow in size calculations when allocating printf buffer.
6396 Do not truncate output string at its first null byte.
6397 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6398 Truncate the output at a character boundary, since vsnprintf does not
6399 do that.
6400 * charset.c (check_iso_charset_parameter): Convert internal
6401 character to string before calling 'error', since %c now has the
6402 printf meaning.
6403 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6404 overflow when computing char to be passed to 'error'. Do not
6405 pass Lisp_Object to 'error'; pass the integer instead.
6406 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6407 formatted with plain %d.
6408
b189fa66
PE
6409 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6410
bff87ef0
PE
6411 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6412
7e2cac20
PE
6413 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6414
ce4d90b5
PE
6415 * xterm.c (x_catch_errors): Remove duplicate declaration.
6416
266c9547
PE
6417 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6418
79c49ad2
PE
6419 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6420
368f4090
JM
64212011-04-10 Jim Meyering <meyering@redhat.com>
6422
6423 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6424 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6425 return ssize_t not "int", and use size_t as the buffer length.
6426 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6427 * gnutls.h: Update declarations.
6428 * process.c (read_process_output): Use ssize_t, to match.
6429 (send_process): Likewise.
6430
a32d4040
CY
64312011-04-09 Chong Yidong <cyd@stupidchicken.com>
6432
6433 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6434
8546720e 64352011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6436
04f2d78b
CB
6437 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6438 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6439
8546720e
GM
6440 * xterm.c (handle_one_xevent):
6441 * xmenu.c (create_and_show_popup_menu):
6442 * xselect.c (x_decline_selection_request)
6443 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6444
0a2f5c1a 64452011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6446
6447 Fix some uses of `int' instead of EMACS_INT.
6448 * search.c (string_match_1, fast_string_match)
6449 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6450 (scan_buffer, find_next_newline_no_quit)
6451 (find_before_next_newline, search_command, Freplace_match)
6452 (Fmatch_data): Make some `int' variables be EMACS_INT.
6453
6454 * xdisp.c (display_count_lines): 3rd argument and return value now
6455 EMACS_INT. All callers changed.
6456 (pint2hrstr): Last argument is now EMACS_INT.
6457
6458 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6459 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6460 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6461 (decode_coding_utf_16, decode_coding_emacs_mule)
6462 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6463 (decode_coding_ccl, decode_coding_charset)
6464 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6465 (decode_coding_iso_2022, decode_coding_emacs_mule)
6466 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6467 <char_offset, last_offset>: Declare EMACS_INT.
6468 (encode_coding_utf_8, encode_coding_utf_16)
6469 (encode_coding_emacs_mule, encode_invocation_designation)
6470 (encode_designation_at_bol, encode_coding_iso_2022)
6471 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6472 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6473 Declare EMACS_INT.
6474 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6475 (encode_invocation_designation): Last argument P_NCHARS is now
6476 EMACS_INT.
6477 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6478 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6479
6480 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6481 All users changed.
6482
6483 * ccl.c (Fccl_execute_on_string): Declare some variables
6484 EMACS_INT.
6485
8546720e 64862011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6487
6488 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6489
4e19a977
CS
64902011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6491
6492 * process.c (Fformat_network_address): Doc fix.
6493
87302331
R
64942011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6495
6496 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6497
cbb59342
CY
64982011-04-08 Chong Yidong <cyd@stupidchicken.com>
6499
6500 * keyboard.c (read_char): Call Lisp function help-form-show,
6501 instead of using internal_with_output_to_temp_buffer.
6502 (Qhelp_form_show): New var.
e0d38eeb 6503 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6504
6505 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6506
6507 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6508
e67a13ab
CY
65092011-04-06 Chong Yidong <cyd@stupidchicken.com>
6510
04f2d78b
CB
6511 * process.c (Flist_processes): Remove to Lisp.
6512 (list_processes_1): Delete.
e67a13ab 6513
973f782d
EZ
65142011-04-06 Eli Zaretskii <eliz@gnu.org>
6515
7c106b1e
EZ
6516 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6517
973f782d
EZ
6518 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6519
41cf7d1a 65202011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6521
ca23cc88
PE
6522 Fix more problems found by GCC 4.6.0's static checks.
6523
f390e2d5
PE
6524 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6525
42eea0d0
PE
6526 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6527
b69769da 6528 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6529
f9541e84
PE
6530 * xdisp.c (vmessage): Mark as a printf-like function.
6531
13841b55
PE
6532 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6533
c136c10f
PE
6534 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6535
5e2d4a30
PE
6536 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6537 printf-like functions.
6538 (tiff_load): Add casts to remove these marks before passing them
6539 to system-supplied API.
6540
583f48b9
PE
6541 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6542
b25d760e
PE
6543 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6544 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6545 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6546 directly, rather than having caller test rule sign. This avoids
6547 some unnecessary tests.
6548 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6549 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6550 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6551
bc7b6697 6552 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6553 (xfont_open): Avoid unnecessary tests.
bc7b6697 6554
27ccc379
PE
6555 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6556
dcd5c89a
PE
6557 * composite.h, composite.c (composition_gstring_put_cache):
6558 Use EMACS_INT, not int, for length.
6559
b13a45c6
PE
6560 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6561 breaking out part of COMPOSITION_DECODE_RULE.
6562 (COMPOSITION_DECODE_RULE): Use it.
6563 * composite.c (get_composition_id): Remove unused local vars,
6564 by using the new macro.
6565
1e792e4d
PE
6566 * textprop.c (set_text_properties_1): Change while to do-while,
6567 since the condition is always true at first.
6568
dc6c6455 6569 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6570 (interval_deletion_adjustment): Return unsigned value.
6571 All uses changed.
dc6c6455 6572
aba7731a
PE
6573 * process.c (list_processes_1, create_pty, read_process_output):
6574 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6575 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6576 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6577 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6578 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6579
fdfc4bf3
PE
6580 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6581
fca8fe46 6582 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6583 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6584
06a0259a 6585 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6586 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6587 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6588
e7b9e80f
PE
6589 * print.c (print_error_message): Avoid int overflow.
6590
56201685
PE
6591 * font.c (font_list_entities): Redo for clarity,
6592 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6593
78834453 6594 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6595 (font_score): Avoid potential overflow in diff calculation.
78834453 6596
0bc0b309 6597 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6598 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6599
e610eaca
PE
6600 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6601
b895abce
PE
6602 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6603 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6604 can always succeed if overflow has undefined behavior.
6605
1f1d9321 6606 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6607 (wordify): Omit three unnecessary tests.
1f1d9321 6608
c59478bc
PE
6609 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6610 All callers changed. This avoids the need for an unused var.
6611
79b73827
PE
6612 * casefiddle.c (casify_region): Remove var that is set but not used.
6613
a4db5dfe
PE
6614 * dired.c (file_name_completion): Remove var that is set but not used.
6615
43aae36e
PE
6616 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6617
2a47c44d 6618 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6619 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6620
a37c69bf
PE
6621 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6622 Check for integer overflow on size calculations.
6623
328ab8e7
PE
6624 * buffer.c (Fprevious_overlay_change): Remove var that is set
6625 but not used.
6626
e5a2a5cb
PE
6627 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6628 Remove vars that are set but not used.
8d84a6eb 6629 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6630 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6631
a60e5f68
PE
6632 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6633
f661cb61 6634 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6635 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6636
f0397f5a
PE
6637 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6638 that are set but not used.
6639
8664db06 6640 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6641 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6642
6abdaa4a
PE
6643 * xselect.c (x_get_local_selection, x_handle_property_notify):
6644 Remove vars that are set but not used.
6645
0ce7538d 6646 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6647 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6648
9ae848fc
PE
6649 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6650 Remove var that is set but not used.
0b918413
PE
6651 (scroll_bar_windows_size): Now size_t, not int.
6652 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6653 Check for overflow.
9ae848fc 6654
a5a62657
PE
6655 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6656 (map_tty_color) [!defined MSDOS]: Likewise.
6657
5c5cdd39
PE
6658 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6659
66ebf983
PE
6660 * coding.c: Remove vars that are set but not used.
6661 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6662 All callers changed.
6663 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6664 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6665 (decode_coding_charset): Remove vars that are set but not used.
6666
1be4d761
PE
6667 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6668 that is set but not used.
6669
47553fa8
PE
6670 * print.c (print_object): Remove var that is set but not used.
6671
1f7196bf 6672 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6673 The gnulib version avoids calling malloc in the usual case,
6674 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6675 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6676 * filelock.c (current_lock_owner): Likewise.
6677 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6678 * sysdep.c: Include allocator.h, careadlinkat.h.
6679 (emacs_no_realloc_allocator): New static constant.
6680 (emacs_readlink): New function.
fdb61804
PE
6681 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6682 ../lib/careadlinkat.h.
d1fdcab7 6683
f84c17c7
SM
66842011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6685
6686 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6687 first non-nil return value).
6688
ef3862ad
JD
66892011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6690
6691 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6692 if not defined (Bug#8403).
6693
376a7006
JB
66942011-04-02 Juanma Barranquero <lekktu@gmail.com>
6695
6696 * xdisp.c (display_count_lines): Remove parameter `start',
6697 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6698 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6699 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6700 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6701 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6702 and thereabouts. All callers changed.
6703 (get_per_char_metric): Remove parameter `f', unused since
6704 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6705
6ca3801d
JM
67062011-04-02 Jim Meyering <meyering@redhat.com>
6707
6708 do not dereference NULL upon failed strdup
6709 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6710 (ns_get_family): Likewise.
6711
d8e2b5ba
JB
67122011-04-02 Juanma Barranquero <lekktu@gmail.com>
6713
6714 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6715
8c74fcbd
JD
67162011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6717
6718 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6719 later (Bug#8403).
6720
7200d79c
SM
67212011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6722
03408648 6723 Add lexical binding.
7200d79c 6724
03408648
SM
6725 * window.c (Ftemp_output_buffer_show): New fun.
6726 (Fsave_window_excursion):
6727 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6728
6729 * lread.c (lisp_file_lexically_bound_p): New function.
6730 (Fload): Bind Qlexical_binding.
6731 (readevalloop): Remove `evalfun' arg.
6732 Bind Qinternal_interpreter_environment.
6733 (Feval_buffer): Bind Qlexical_binding.
6734 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6735 Mark as dynamic.
6736 (syms_of_lread): Declare `lexical-binding'.
6737
6738 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6739
6740 * keyboard.c (eval_dyn): New fun.
6741 (menu_item_eval_property): Use it.
ca105506
SM
6742
6743 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6744
03408648
SM
6745 * fns.c (concat, mapcar1): Accept byte-code-functions.
6746
6747 * eval.c (Fsetq): Handle lexical vars.
6748 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6749 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6750 (FletX, Flet): Obey lexical binding.
6751 (Fcommandp): Handle closures.
6752 (Feval): New `lexical' arg.
6753 (eval_sub): New function extracted from Feval. Use it almost
6754 everywhere where Feval was used. Look up vars in lexical env.
6755 Handle closures.
6756 (Ffunctionp): Move from subr.el.
6757 (Ffuncall): Handle closures.
6758 (apply_lambda): Remove `eval_flags'.
6759 (funcall_lambda): Handle closures and new byte-code-functions.
6760 (Fspecial_variable_p): New function.
6761 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6762 but without exporting it to Lisp.
23aba0ea 6763
23aba0ea 6764 * doc.c (Fdocumentation, store_function_docstring):
03408648 6765 * data.c (Finteractive_form): Handle closures.
23aba0ea 6766
03408648
SM
6767 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6768 interactive spec.
ba83908c 6769
04f2d78b
CB
6770 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6771 New byte-codes.
03408648
SM
6772 (exec_byte_code): New function extracted from Fbyte_code to handle new
6773 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6774
03408648 6775 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6776
03408648 6777 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6778
e2abce01
JB
67792011-03-31 Juanma Barranquero <lekktu@gmail.com>
6780
6781 * xdisp.c (redisplay_internal): Fix prototype.
6782
63696a73 67832011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6784
63696a73 6785 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6786 (try_scrolling): Use it when setting scroll_limit.
6787 Limit scrolling to 100 screen lines.
63696a73
EZ
6788 (redisplay_window): Even when falling back on "recentering",
6789 position point in the window according to scroll-conservatively,
6790 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6791
6792 (try_scrolling): When point is above the window, allow searching
6793 as far as scroll_max, or one screenful, to compute vertical
6794 distance from PT to the scroll margin position. This prevents
6795 try_scrolling from unnecessarily failing when
6796 scroll-conservatively is set to a value slightly larger than the
6797 window height. Clean up the case of PT below the margin at bottom
6798 of window: scroll_max can no longer be INT_MAX. When aggressive
6799 scrolling is in use, don't let point enter the opposite scroll
6800 margin as result of the scroll.
6801 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6802 threshold of 100 lines for never-recentering scrolling.
6803
e4cc2dfc
JB
68042011-03-31 Juanma Barranquero <lekktu@gmail.com>
6805
6806 * dispextern.h (move_it_by_lines):
6807 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6808 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6809 (message_log_check_duplicate): Remove parameters `prev_bol' and
6810 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6811 (redisplay_internal): Remove parameter `preserve_echo_area',
6812 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6813
6814 * indent.c (Fvertical_motion):
6815 * window.c (window_scroll_pixel_based, Frecenter):
6816 Don't pass `need_y_p' to `move_it_by_lines'.
6817
1c470562
SM
68182011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6819
44f230aa
SM
6820 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6821 steal a few bits to be more compact.
6822 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6823 Remove unneeded casts.
6824
1c470562
SM
6825 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6826
888adce9
ZK
68272011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6828
6829 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6830 binding" message (bug#7967).
6831
f838ed7b
PE
68322011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6833
77861b95
PE
6834 Fix more problems found by GCC 4.6.0's static checks.
6835
de6dbc14
PE
6836 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6837 Remove unused local var.
6838
f838ed7b
PE
6839 * editfns.c (Fmessage_box): Remove unused local var.
6840
792c7b2b
PE
6841 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6842 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6843 Omit unused local vars.
c499e557 6844 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6845 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6846 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6847 Omit unused local var.
6848
ba0165e1
PE
6849 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6850 Don't assume string length fits in int.
32ad8845 6851 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6852 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6853
3c59b4c9
PE
6854 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6855 instead of alloca (Bug#8344).
6856
a3eed478 6857 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6858 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6859
eb4d412d
PE
6860 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6861
1658b401
PE
6862 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6863 concerns.
6864
6865 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6866
6867 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6868
9a2c6e05
PE
6869 * keyboard.c (syms_of_keyboard): Use the same style as later
6870 in this function when indexing through an array. This also
6871 works around GCC bug 48267.
6872
03d0a109
PE
6873 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6874
44f730c8
PE
6875 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6876
fe75f926
PE
6877 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6878 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6879
ffa8c828
PE
6880 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6881 This avoids undefined behavior on integer overflow, and is a bit
6882 more convenient anyway since it is compared to a size_t variable.
6883
c5101a77
PE
6884 Variadic C functions now count arguments with size_t, not int.
6885 This avoids an unnecessary limitation on 64-bit machines, which
6886 caused (substring ...) to crash on large vectors (Bug#8344).
6887 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6888 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6889 All variadic functions and their callers changed accordingly.
c5101a77
PE
6890 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6891 * data.c (arith_driver, float_arith_driver): Likewise.
6892 * editfns.c (general_insert_function): Likewise.
6893 * eval.c (struct backtrace.nargs, interactive_p)
6894 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6895 (funcall_lambda, mark_backtrace): Likewise.
6896 * fns.c (concat): Likewise.
6897 * frame.c (x_set_frame_parameters): Likewise.
6898 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6899 0 if not found, not -1. All callers changed.
6900
dd3f25f7
PE
6901 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6902 (stack_copy_size): Now size_t, not int.
6903 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6904
461c2ab9
JB
69052011-03-28 Juanma Barranquero <lekktu@gmail.com>
6906
6907 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6908 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6909 All callers changed.
6910
6911 * lisp.h (multibyte_char_to_unibyte):
6912 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6913 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6914 * character.h (CHAR_TO_BYTE8):
6915 * cmds.c (internal_self_insert):
6916 * editfns.c (general_insert_function):
6917 * keymap.c (push_key_description):
6918 * search.c (Freplace_match):
6919 * xdisp.c (message_dolog, set_message_1): All callers changed.
6920
f6d62986
SM
69212011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6922
6923 * keyboard.c (safe_run_hook_funcall): New function.
6924 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6925 don't set the hook to nil, but remove the offending function instead.
6926 (Qcommand_hook_internal): Remove, unused.
6927 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6928 Vcommand_hook_internal.
6929
6930 * eval.c (enum run_hooks_condition): Remove.
6931 (funcall_nil, funcall_not): New functions.
6932 (run_hook_with_args): Call each function through a `funcall' argument.
6933 Remove `cond' argument, now redundant.
6934 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6935 (Frun_hook_with_args_until_failure): Adjust accordingly.
6936 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6937
1db5b1ad
JB
69382011-03-28 Juanma Barranquero <lekktu@gmail.com>
6939
6940 * dispextern.h (string_buffer_position): Remove declaration.
6941
6942 * print.c (strout): Remove parameter `multibyte', unused since
6943 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6944
6945 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6946 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6947 All callers changed.
6948
6949 * w32.c (_wsa_errlist): Use braces for struct initializers.
6950
6951 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6952 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6953 All callers changed.
6954 (string_buffer_position): Likewise. Also, make static (it's never
6955 used outside xdisp.c).
6956 (cursor_row_p): Remove parameter `w', unused since
6957 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6958 (decode_mode_spec): Remove parameter `precision', introduced during
6959 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6960 All callers changed.
6961
5ffb62aa
JD
69622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6963
6964 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6965
461c2ab9 69662011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6967
6968 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6969 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6970 (ns_update_auto_hide_menu_bar): New functions.
6971 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6972 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6973 ns_constrain_all_frames.
6974 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6975 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6976
5c380ffb
JD
69772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6978
6979 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6980
9af30bdf
GM
69812011-03-27 Glenn Morris <rgm@gnu.org>
6982
6983 * syssignal.h: Replace RETSIGTYPE with void.
6984 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6985 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6986 Replace SIGTYPE with void everywhere.
6987 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6988 * s/template.h (SIGTYPE): Remove commented out definition.
6989
e2abce01
JB
69902011-03-26 Eli Zaretskii <eliz@gnu.org>
6991
6992 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6993 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6994
f868cd8a
JB
69952011-03-26 Juanma Barranquero <lekktu@gmail.com>
6996
59eb0929
JB
6997 * w32.c (read_unc_volume): Use parameter `henum', instead of
6998 global variable `wget_enum_handle'.
6999
7000 * keymap.c (describe_vector): Remove parameters `indices' and
7001 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7002 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7003
f868cd8a
JB
7004 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7005
7006 * keyboard.c (timer_check): Remove parameter `do_it_now',
7007 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7008 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7009 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7010
7011 * keyboard.c (read_char):
7012 * w32menu.c (w32_menu_display_help):
7013 * xmenu.c (show_help_event, menu_help_callback):
7014 Adjust calls to `show_help_echo'.
7015
7016 * gtkutil.c (xg_maybe_add_timer):
7017 * keyboard.c (readable_events):
7018 * process.c (wait_reading_process_output):
7019 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7020
7021 * insdel.c (adjust_markers_gap_motion):
7022 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7023 (gap_left, gap_right): Don't call it.
7024
2ecf6fdb
CY
70252011-03-25 Chong Yidong <cyd@stupidchicken.com>
7026
7027 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7028 incurred during fontification.
7029
6b1f9ba4
JB
70302011-03-25 Juanma Barranquero <lekktu@gmail.com>
7031
7032 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7033 (DEFVAR_PER_BUFFER): Don't pass it.
7034
7035 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7036 (scrolling_window): Don't pass it.
7037
0f4a96b5
JB
70382011-03-25 Juanma Barranquero <lekktu@gmail.com>
7039
7040 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7041
7042 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7043 and `suffix'.
7044 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7045 of variables specific to SELinux and computation of `encoded_absname'.
7046
7047 * image.c (XPutPixel): Remove unused variable `height'.
7048
7049 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7050
7051 * unexw32.c (get_section_info): Remove unused variable `section'.
7052
7053 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7054 (system_process_attributes): Remove unused variable `sess'.
7055 (sys_read): Remove unused variable `err'.
7056
7057 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7058 (w32_wnd_proc): Remove unused variable `isdead'.
7059 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7060 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7061 (x_create_tip_frame): Remove unused variable `tem'.
7062
7063 * w32inevt.c (w32_console_read_socket):
7064 Remove unused variable `no_events'.
7065
7066 * w32term.c (x_draw_composite_glyph_string_foreground):
7067 Remove unused variable `width'.
7068
1149507c
JB
70692011-03-24 Juanma Barranquero <lekktu@gmail.com>
7070
7071 * w32term.c (x_set_glyph_string_clipping):
7072 Don't pass uninitialized region to CombineRgn.
7073
9c88f339
JB
70742011-03-23 Juanma Barranquero <lekktu@gmail.com>
7075
7076 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7077 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7078 (Fx_close_connection): Remove unused variable `i'.
7079
7080 * w32font.c (w32font_draw): Return number of glyphs.
7081 (w32font_open_internal): Remove unused variable `i'.
7082 (w32font_driver): Add missing initializer.
7083
7084 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7085 (fill_in_menu): Remove unused variable `items_added'.
7086
7087 * w32term.c (last_mouse_press_frame): Remove static global variable.
7088 (w32_clip_to_row): Remove unused variable `f'.
7089 (x_delete_terminal): Remove unused variable `i'.
7090
7091 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7092 (NOTHING): Remove unused static global variable.
7093 (uniscribe_check_otf): Remove unused variable `table'.
7094 (uniscribe_font_driver): Add missing initializers.
7095
dee091a3
JD
70962011-03-23 Julien Danjou <julien@danjou.info>
7097
7098 * term.c (Fsuspend_tty, Fresume_tty):
7099 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7100 * window.c (temp_output_buffer_show):
7101 * insdel.c (signal_before_change):
7102 * frame.c (Fhandle_switch_frame):
7103 * fileio.c (Fdo_auto_save):
7104 * emacs.c (Fkill_emacs):
7105 * editfns.c (save_excursion_restore):
7106 * cmds.c (internal_self_insert):
7107 * callint.c (Fcall_interactively):
7108 * buffer.c (Fkill_all_local_variables):
7109 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7110 Use Frun_hooks.
0f4a96b5 7111 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7112 unconditionnaly since it does the check itself.
7113
2c520ab5 71142011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7115
c9c49752
PE
7116 Fix more problems found by GCC 4.5.2's static checks.
7117
8abc3f12
PE
7118 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7119 the first time through the loop, since we know p0 < p1 then.
7120 This also avoids a gcc -Wstrict-overflow warning.
7121
a2d26660
PE
7122 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7123 leading to a memory leak, possible in functions like
7124 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7125 of objects (Bug#8318).
a2d26660 7126
916c72e9
PE
7127 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7128 that could (at least in theory) be that large.
7129
19ab8a18
PE
7130 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7131 This is less likely to overflow, and avoids undefined behavior if
7132 overflow does occur. All callers changed. Use strtoul to scan
7133 for the unsigned long integer.
b7cbbd6f
PE
7134 (pint2hrstr): Simplify and tune code slightly.
7135 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7136
f0641eff
PE
7137 * scroll.c (do_scrolling): Work around GCC bug 48228.
7138 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7139
7f650bb9
PE
7140 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7141 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7142 (validate_x_resource_name): Simplify count usage.
7143 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7144
37dd57d1
PE
7145 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7146 fail (Bug#8306).
81e56e61 7147
699979fc 7148 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7149
401bf9b4
PE
7150 * process.c (Fmake_network_process): Use socklen_t, not int,
7151 where POSIX says socklen_t is required in portable programs.
7152 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7153 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7154 (Fmake_network_process, server_accept_connection):
7155 (wait_reading_process_output, read_process_output):
7156 Likewise.
7157
b93aacde
PE
7158 * process.c: Rename or move locals to avoid shadowing.
7159 (list_processes_1, Fmake_network_process):
7160 (read_process_output_error_handler, exec_sentinel_error_handler):
7161 Rename or move locals.
4dc343ee 7162 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7163 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7164 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7165 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7166 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7167
af8a867c 7168 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7169 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7170 Include tparam.h instead, since it declares them.
af8a867c
PE
7171 * cm.h (PC): Remove extern decl; tparam.h now does this.
7172 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7173 * terminfo.c: Include tparam.h, to check interfaces.
7174 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7175 (tparam): Adjust signature to match interface in tparam.h;
7176 this removes some undefined behavior. Check that outstring and len
7177 are zero, which they always are with Emacs.
7178 * tparam.h (PC, BC, UP): New extern decls.
7179
0248044d 7180 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7181 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7182
8ff096c1 7183 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7184 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7185 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7186 (ftfont_list): Remove unused local.
49eaafba
PE
7187 (get_adstyle_property, ftfont_pattern_entity):
7188 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7189 Rename locals to avoid shadowing.
8ff096c1 7190
e2be39f6
PE
7191 * xfont.c (xfont_list_family): Mark var as initialized.
7192
c9735e30
PE
7193 * xml.c (make_dom): Now static.
7194
8f5201ae
PE
7195 * composite.c (composition_compute_stop_pos): Rename local to
7196 avoid shadowing.
b246f932
PE
7197 (composition_reseat_it): Remove unused locals.
7198 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7199 (composition_update_it): Mark var as initialized.
11b61122
PE
7200 (find_automatic_composition): Mark vars as initialized,
7201 with a FIXME (Bug#8290).
8f5201ae 7202
760fbc2c
PE
7203 character.h: Rename locals to avoid shadowing.
7204 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7205 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7206 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7207 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7208 to avoid shadowing.
7209
ff08eb85
PE
7210 * textprop.c (property_change_between_p): Remove; unused.
7211
fc7bf025
PE
7212 * intervals.c (interval_start_pos): Now static.
7213
235d7abc
PE
7214 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7215
44f230aa
SM
7216 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7217 Rename locals to avoid shadowing.
3e7d6594 7218
50060332
PE
7219 * sound.c (wav_play, au_play, Fplay_sound_internal):
7220 Fix pointer signedness.
d01f234b 7221 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7222 (wav_play): Initialize a variable to 0, to prevent undefined
7223 behavior (Bug#8278).
50060332 7224
c4fc4e30
PE
7225 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7226
918436ed
PE
7227 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7228
c939f91b
PE
7229 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7230 clobbering (Bug#8298).
b9c7f648
PE
7231 * sysdep.c (sys_subshell): Likewise.
7232 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7233
6bd8c144
PE
7234 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7235 This should get cleaned up, so that child_setup has the
7236 same signature on all platforms.
7237
7710357c 7238 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7239 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7240
c59da222
CY
72412011-03-22 Chong Yidong <cyd@stupidchicken.com>
7242
7243 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7244 not to be necessary, and produces flickering.
7245
66b87493
GM
72462011-03-20 Glenn Morris <rgm@gnu.org>
7247
7248 * config.in: Remove file.
7249
45b6f6d5
JB
72502011-03-20 Juanma Barranquero <lekktu@gmail.com>
7251
7252 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7253 are now in src/globals.h.
7254 (syms_of_minibuf): Remove spurious & from previous change.
7255
3ec03f7e
LL
72562011-03-20 Leo <sdl.web@gmail.com>
7257
7258 * minibuf.c (completing-read-function): New variable.
7259 (completing-read-default): Rename from completing-read.
7260 (completing-read): Call completing-read-function.
7261
b14e3e21
CY
72622011-03-19 Juanma Barranquero <lekktu@gmail.com>
7263
7264 * xfaces.c (Fx_load_color_file):
7265 Read color file from absolute filename (bug#8250).
7266
f2b726e6
JB
72672011-03-19 Juanma Barranquero <lekktu@gmail.com>
7268
7269 * makefile.w32-in: Update dependencies.
7270
09f6ff02
EZ
72712011-03-17 Eli Zaretskii <eliz@gnu.org>
7272
7273 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7274
29a6015a
PE
72752011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7276
a3a6c54e
PE
7277 Fix more problems found by GCC 4.5.2's static checks.
7278
b766f867
PE
7279 * process.c (make_serial_process_unwind, send_process_trap):
7280 (sigchld_handler): Now static.
7281
be02381c
PE
7282 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7283 That way, the code declares only the vars that it needs.
7284 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7285 * s/cygwin.h (PTY_ITERATION): Likewise.
7286 * s/darwin.h (PTY_ITERATION): Likewise.
7287 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7288
57048744
PE
7289 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7290 * process.c (allocate_pty): Don't declare stb unless it's needed.
7291
7914961c 7292 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7293 (CONSTANTLIM): Remove; unused.
7294 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7295 Define only if needed.
7914961c 7296
b3967b18
PE
7297 * unexelf.c (unexec): Name an expression,
7298 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7299 Use a different way to cause a compilation error if anyone uses
7300 n rather than nn, a way that does not involve shadowing.
73366a00 7301 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7302
29a6015a
PE
7303 * deps.mk (unexalpha.o): Remove; unused.
7304
43cfc33e 7305 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7306 * unexec.h: New file.
ce701a33
PE
7307 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7308 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7309 Depend on unexec.h.
7310 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7311 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7312 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7313 Change as necessary to match prototype in unexec.h.
ce701a33 7314
01f44d5a
PE
7315 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7316 shadowing.
4f63c6bb 7317 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7318
a6670b0b
PE
7319 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7320 Rename locals to avoid shadowing.
7321
cef2010d 7322 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7323 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7324
d4d7173a
PE
7325 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7326
f08b802a
PE
7327 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7328 warning when compiling print.c.
7329
3ddb0639
PE
7330 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7331 instead of using an uninitialized var.
5ad03b97 7332 (font_sort_entities): Mark var as initialized.
3ddb0639 7333
170a2692
PE
7334 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7335
e663c700
PE
7336 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7337 pointers to constants.
89bc529a 7338 (font_parse_fcname): Remove unused vars.
7b81e2d0 7339 (font_delete_unmatched): Now static.
ea838e10 7340 (font_get_spec): Remove; unused.
13a547c6
PE
7341 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7342 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7343 Rename or move locals to avoid shadowing.
e663c700 7344
2a80c887 7345 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7346 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7347
1384fa33 7348 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7349 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7350
8b2c52e9
PE
7351 * alloc.c (mark_backtrace): Move decl from here ...
7352 * lisp.h: ... to here, so that it can be checked.
7353
475545b5 7354 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7355 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7356 (lisp_indirect_variable): Name an expression,
7357 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7358 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7359
b1349114 7360 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7361 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7362 Use const pointer when appropriate.
b1349114 7363
a2928364
PE
7364 * lisp.h (get_system_name, get_operating_system_release):
7365 Move decls here, to check interfaces.
7366 * process.c (get_operating_system_release): Move decl to lisp.h.
7367 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7368 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7369 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7370 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7371 (Fformat_time_string, Fencode_time, Finsert_char):
7372 (Ftranslate_region_internal, Fformat):
7373 Rename or remove local vars to avoid shadowing.
9710023e 7374 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7375
a415e694
PE
7376 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7377 avoid shadowing.
7378
8ef4622d
PE
7379 * lisp.h (eassert): Check that the argument compiles, even if
7380 ENABLE_CHECKING is not defined.
7381
946f9a5b
PE
7382 * data.c (Findirect_variable): Name an expression, to avoid
7383 gcc -Wbad-function-cast warning.
112396d6 7384 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7385 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7386 (Fmake_variable_buffer_local, Fmake_local_variable):
7387 Mark variables as initialized.
52746918 7388 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7389
e5aab7e7 7390 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7391 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7392 Rename locals to avoid shadowing.
dff45157
PE
7393 (mark_stack): Move local variables into the #ifdef region where
7394 they're used.
7bc26fdb
PE
7395 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7396 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7397 needed otherwise.
7398 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7399 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7400 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7401
e5aab7e7
PE
7402 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7403 avoids undefined behavior in theory.
7404
4da60324
PE
7405 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7406
88043301
PE
7407 Use functions, not macros, for up- and down-casing (Bug#8254).
7408 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7409 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7410 to use the following functions instead of these macros.
7411 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7412 EMACS_INT, since callers assume the returned value fits in int.
7413 (upcase1): Likewise, for UPCASE_TABLE.
7414 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7415 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7416 the race-condition problem in the old DOWNCASE.
88043301 7417
19ed5445
PE
7418 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7419 Rename locals to avoid shadowing.
7420 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7421 (regex_compile, re_search_2, re_match_2_internal):
7422 Remove unused local vars.
952db0d7
PE
7423 (FREE_VAR): Rewrite so as not to use empty "else",
7424 which gcc can warn about.
da053e48 7425 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7426 (RETALLOC_IF): Define only if needed.
7427 (WORDCHAR_P): Likewise. This one is never needed, but is used
7428 only in a comment talking about a compiler bug, so put inside
7429 the #if 0 of that comment.
7430 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7431 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7432 Remove; unused.
19ed5445 7433
1f3561e4 7434 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7435 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7436 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7437
ded6f8f7
PE
7438 * search.c (simple_search): Remove unused var.
7439
dbd37a95
PE
7440 * dired.c (compile_pattern): Move decl from here ...
7441 * lisp.h: ... to here, so that it can be checked.
7442 (struct re_registers): New forward decl.
7443
7e47afad
PE
7444 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7445
85f24f61
PE
7446 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7447 All uses changed.
7448 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7449 Rename locals to avoid shadowing.
5671df8f 7450 (Fvertical_motion): Mark locals as initialized.
85f24f61 7451
181aa2be 7452 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7453 (casify_region): Mark local as initialized.
181aa2be 7454
930d429c
PE
7455 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7456
7082eac6
PE
7457 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7458 New macros, so that the caller can use some names other than
7459 gcpro1, gcpro2, etc.
7460 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7461 of the new macros.
7462 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7463 argument, for consistency with GCPRO2_VAR, etc: it is now the
7464 prefix of the variable, not the variable itself. All uses
7465 changed.
38b2c076
PE
7466 * dired.c (directory_files_internal, file_name_completion):
7467 Rename locals to avoid shadowing.
7468
15206ed9
PE
7469 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7470 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7471 dired.c's scmp function, had undefined behavior.
7472 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7473 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7474 * buffer.h: ... to here, because these macros use current_buffer,
7475 and the new implementation with inline functions needs to have
7476 current_buffer in scope now, rather than later when the macros
7477 are used.
7478 (downcase, upcase1): New static inline functions.
7479 (DOWNCASE, UPCASE1): Reimplement using these functions.
7480 This avoids undefined behavior in expressions like
7481 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7482 from race conditions in accessing the global variables
7483 case_temp1 and case_temp2.
7484 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7485 * lisp.h (case_temp1, case_temp2): Remove their decls.
7486 * character.h (ASCII_CHAR_P): Move from here ...
7487 * lisp.h: ... to here, so that the inline functions mentioned
7488 above can use them.
7489
4a6bea26
PE
7490 * dired.c (directory_files_internal_unwind): Now static.
7491
f14b7e14
PE
7492 * fileio.c (file_name_as_directory, directory_file_name):
7493 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7494 Now static.
2893f146
PE
7495 (file_name_as_directory): Use const pointers when appropriate.
7496 (Fexpand_file_name): Likewise. In particular, newdir might
7497 point at constant storage, so make it a const pointer.
fd4ead52 7498 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7499 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7500 signedness issues.
f839df0c
PE
7501 (Fset_file_times, Finsert_file_contents, auto_save_error):
7502 Rename locals to avoid shadowing.
f14b7e14 7503
5716756e 7504 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7505 (Ftry_completion, Fall_completions): Rename or remove locals
7506 to avoid shadowing.
5716756e 7507
b4c3046a
PE
7508 * marker.c (bytepos_to_charpos): Remove; unused.
7509
b45db522
PE
7510 * lisp.h (verify_bytepos, count_markers): New decls,
7511 so that gcc does not warn that these functions aren't declared.
7512
85876d07
PE
7513 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7514 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7515 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7516 (copy_text): Remove unused local var.
85876d07 7517
03d78a21 7518 * filelock.c (within_one_second): Now static.
b3dd38ab 7519 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7520
5df8f01b
PE
7521 * buffer.c (fix_overlays_before): Mark locals as initialized.
7522 (fix_start_end_in_overlays): Likewise. This function should be
7523 simplified by using pointers-to-pointers, but that's a different
7524 matter.
b1d876f1 7525 (switch_to_buffer_1): Now static.
8f54f30a
PE
7526 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7527 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7528
a70072c9 7529 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7530 Fix pointer signedness issue.
edced198
PE
7531 (sys_subshell): Mark local as volatile if checking for lint,
7532 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7533 (MAXPATHLEN): Define only if needed.
a70072c9 7534
a0977c44
PE
7535 * process.c (serial_open, serial_configure): Move decls from here ...
7536 * systty.h: ... to here, so that they can be checked.
7537
a884fdcc
PE
7538 * fns.c (get_random, seed_random): Move extern decls from here ...
7539 * lisp.h: ... to here, so that they can be checked.
7540
604efe86 7541 * sysdep.c (reset_io): Now static.
b8950c94 7542 (wait_for_termination_signal): Remove; unused.
604efe86 7543
38fc62d9
PE
7544 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7545 (copy_keymap_item, append_key, push_text_char_description):
7546 Now static.
1004a21a 7547 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7548 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7549 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7550 (describe_map_tree):
7551 Rename locals to avoid shadowing.
38fc62d9 7552
2f2650da
PE
7553 * keyboard.c: Declare functions static if they are not used elsewhere.
7554 (echo_char, echo_dash, cmd_error, top_level_2):
7555 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7556 (read_char, kbd_buffer_get_event, make_lispy_position):
7557 (make_lispy_event, make_lispy_movement, apply_modifiers):
7558 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7559 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7560 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7561 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7562 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7563
a053e86c 7564 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7565 (mark_kboards): Move decl here ...
7566 * alloc.c (mark_kboards): ... from here.
a053e86c 7567
4752793e
PE
7568 * lisp.h (force_auto_save_soon): New decl.
7569
74f10ca7 7570 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7571 (DEFINE_DUMMY_FUNCTION): New macro.
7572 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7573 Use it.
c03cd23f
PE
7574 (main): Add casts to avoid warnings
7575 if GCC considers string literals to be constants.
74f10ca7 7576
022e70d4
PE
7577 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7578
59d6fe83
PE
7579 * dbusbind.c: Pointer signedness fixes.
7580 (xd_signature, xd_append_arg, xd_initialize):
7581 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7582 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7583 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7584 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7585
78320123
PE
7586 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7587 if GCC considers string literals to be constants.
49cebcca 7588 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7589
35ac2a97
SM
75902011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7591
fb103ca9
SM
7592 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7593 (print_preprocess, print_object): New macro to fix last change.
7594
35ac2a97
SM
7595 * print.c (print_preprocess): Don't forget font objects.
7596
62973b41
JB
75972011-03-16 Juanma Barranquero <lekktu@gmail.com>
7598
7599 * emacs.c (USAGE3): Doc fixes.
7600
0e48bb22
AS
76012011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7602
7603 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7604 structure.
7605
7684e57b
JB
76062011-03-14 Juanma Barranquero <lekktu@gmail.com>
7607
7608 * lisp.h (VWindow_system, Qfile_name_history):
7609 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7610 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7611 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7612
7613 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7614 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7615
7616 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7617 * w32console.c (detect_input_pending, read_input_pending)
7618 (encode_terminal_code):
7619 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7620 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7621 (w32_system_caret_y, Qfile_name_history):
7622 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7623 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7624 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7625 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7626 * w32proc.c (Qlocal, report_file_error):
7627 * w32term.c (Vwindow_system, updating_frame):
7628 * w32uniscribe.c (initialized, uniscribe_font_driver):
7629 Remove unneeded extern declarations.
7630
2aa46d6c
CY
76312011-03-14 Chong Yidong <cyd@stupidchicken.com>
7632
c96bbc66 7633 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7634
cffc6f3b
CY
76352011-03-13 Chong Yidong <cyd@stupidchicken.com>
7636
7637 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7638 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7639 These macros can no longer be used for assignment.
7640
44f230aa
SM
7641 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7642 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7643 (record_buffer_markers, fetch_buffer_markers): New functions for
7644 recording and fetching special buffer markers.
7645 (set_buffer_internal_1, set_buffer_temp): Use them.
7646
7647 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7648
7649 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7650
7651 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7652 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7653
7654 * xdisp.c (hscroll_window_tree):
7655 (reconsider_clip_changes): Use PT instead of BUF_PT.
7656
d251f04b
EZ
76572011-03-13 Eli Zaretskii <eliz@gnu.org>
7658
7659 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7660 $(EMACS_ROOT)/lib/intprops.h.
7661
f0c77cd1
PE
76622011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7663
3eca4629
PE
7664 Fix more problems found by GCC 4.5.2's static checks.
7665
7c86ee98
PE
7666 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7667 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7668 (xg_free_frame_widgets): Make it clear that a local variable is
7669 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7670 (gdk_window_get_screen): Make it clear that this macro is needed
7671 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7672 (int_gtk_range_get_value): New function, which avoids a diagnostic
7673 from gcc -Wbad-function-cast.
7674 (xg_set_toolkit_scroll_bar_thumb): Use it.
7675 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7676 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7677 (get_utf8_string, xg_get_file_with_chooser):
7678 Rename locals to avoid shadowing.
7679 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7680
41729b81
PE
7681 * xgselect.c (xg_select): Remove unused var.
7682
f0c77cd1
PE
7683 * image.c (four_corners_best): Mark locals as initialized.
7684 (gif_load): Initialize transparent_p to zero (Bug#8238).
7685 Mark another local as initialized.
ec6cf4c6 7686 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7687
ce0ad53d 7688 * image.c (clear_image_cache): Now static.
d5d5a617 7689 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7690 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7691 (x_edge_detection): Remove unnecessary cast that
7692 gcc -Wbad-function-cast diagnoses.
2037898d 7693 (gif_load): Fix pointer signedness.
6ae141d6
PE
7694 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7695 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7696
33383987 76972011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7698
d32df629
PE
7699 Improve quality of tests for time stamp overflow.
7700 For example, without this patch (encode-time 0 0 0 1 1
7701 1152921504606846976) returns the obviously-bogus value (-948597
7702 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7703 reports time overflow. See
7704 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7705 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7706 * editfns.c: Include limits.h and intprops.h.
7707 (TIME_T_MIN, TIME_T_MAX): New macros.
7708 (time_overflow): Move earlier, to before first use.
7709 (hi_time, lo_time): New functions, for an accurate test for
7710 out-of-range times.
7711 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7712 (Fget_internal_run_time): Don't assume time_t fits in int.
7713 (make_time): Use list2 instead of Fcons twice.
7714 (Fdecode_time): More accurate test for out-of-range times.
7715 (check_tm_member): New function.
7716 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7717 (lisp_time_argument): Don't rely on undefined left-shift and
7718 right-shift behavior when checking for time stamp overflow.
8be6f318 7719
fe31d94c
PE
7720 * editfns.c (time_overflow): New function, refactoring common code.
7721 (Fformat_time_string, Fdecode_time, Fencode_time):
7722 (Fcurrent_time_string): Use it.
7723
8be6f318
PE
7724 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7725 * dired.c (make_time): Move to ...
7726 * editfns.c (make_time): ... here.
7727 * systime.h: Note the move.
7728
09d9db2c 77292011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7730
126bc0dc
YM
7731 * fringe.c (update_window_fringes): Remove unused variables.
7732
c47cbdfd
YM
7733 * unexmacosx.c (copy_data_segment): Also copy __got section.
7734 (Bug#8223)
7735
7ac80be9
EZ
77362011-03-12 Eli Zaretskii <eliz@gnu.org>
7737
c96bbc66 7738 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7739 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7740 Constify `char *' arguments and their references according to
7741 prototypes in tparam.h.
7742
ecb0f94d 7743 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7744
7ac80be9
EZ
7745 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7746 Adapt all references accordingly.
7747
7748 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7749
ef1fd07e
TT
77502011-03-11 Tom Tromey <tromey@redhat.com>
7751
7752 * buffer.c (syms_of_buffer): Remove obsolete comment.
7753
7ef4b50c
EZ
77542011-03-11 Eli Zaretskii <eliz@gnu.org>
7755
7756 * termhooks.h (encode_terminal_code): Declare prototype.
7757
7758 * msdos.c (encode_terminal_code): Don't declare prototype.
7759
7760 * term.c (encode_terminal_code): Now external again, used by
7761 w32console.c and msdos.c.
7762
44f230aa
SM
7763 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7764 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7765
4b1ec863 77662011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7767
1714f52b 7768 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7769
4b1ec863
PE
7770 * fringe.c (update_window_fringes): Mark locals as initialized
7771 (Bug#8227).
7772 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7773
524c7aa6
PE
7774 * alloc.c (mark_fringe_data): Move decl from here ...
7775 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7776 to check its interface.
7777 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7778
a5c0af81 7779 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7780 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7781 (fontset_font): Mark local as initialized.
a9a06e0b 7782 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7783
b4716021
PE
7784 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7785
811e9bac 7786 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7787 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7788 (x_own_selection, Fx_disown_selection_internal): Rename locals
7789 to avoid shadowing.
7790 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7791
7e3ab302
PE
7792 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7793 so that the caller can use some name other than gcpro1.
7794 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7795 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7796 (Fx_backspace_delete_keys_p):
7797 Use them to avoid shadowing, and rename vars to avoid shadowing.
7798 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7799 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7800 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7801 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7802 Remove unused locals.
7e3ab302
PE
7803 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7804 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7805 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7806 macros.
f78faa98 7807
e2b13473
PE
7808 * xterm.h (x_mouse_leave): New decl.
7809
77f23912
PE
7810 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7811 Remove unused functions.
cdf4ba58
PE
7812 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7813 (x_calc_absolute_position): Now static.
7411c686 7814 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7815 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7816 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7817 unless they are used.
38d0b34a
PE
7818 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7819 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7820 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7821 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7822 (x_error_catcher, x_connection_closed, x_error_handler):
7823 (x_error_quitter, xembed_send_message, x_iconify_frame):
7824 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7825 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7826 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7827
44f230aa
SM
7828 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7829 Rename or move locals to avoid shadowing.
6b463e58 7830 (tty_defined_color, merge_face_heights): Now static.
5967d051 7831 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7832 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7833 does not deduce is never used uninitialized.
73719eba
PE
7834 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7835 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7836
426994c3 7837 * terminal.c (store_terminal_param): Now static.
5489860b 7838
032f1620 7839 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7840 (set_frame_menubar): Remove unused local.
d4323972 7841 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7842 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7843 since they might point to immutable storage.
281585b0
PE
7844 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7845 since it's unused otherwise.
032f1620 7846
367c19e5 7847 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7848 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7849 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7850 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7851 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7852 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7853 does not deduce are never used uninitialized.
70739cbe 7854
07b48fa9
PE
7855 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7856
8868a238 7857 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7858 * window.c (window_loop, size_window):
7859 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7860
7e5cf297 7861 * window.c (display_buffer): Now static.
d6550a9f
PE
7862 (size_window): Mark variables that gcc -Wuninitialized
7863 does not deduce are never used uninitialized.
a586633d
PE
7864 * window.h (check_all_windows): New decl, to forestall
7865 gcc -Wmissing-prototypes diagnostic.
5b555da1 7866 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7867
f6095868
PE
7868 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7869 shadowing.
7870 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7871 Include <limits.h>.
7872 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7873 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7874 (load_charset_map): Mark variables that gcc -Wuninitialized
7875 does not deduce are never used uninitialized.
53df7c11 7876 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7877
f38b440c
PE
7878 * coding.c (coding_set_source, coding_set_destination):
7879 Use "else { /* comment */ }" rather than "else /* comment */;"
7880 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7881 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7882 a block, when the outer 'i' will do.
7883 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7884 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7885 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7886 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7887 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7888 Rename locals to avoid shadowing.
7889 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7890 * coding.c (emacs_mule_char, encode_invocation_designation):
7891 Now static, since they're not used elsewhere.
413bb2db 7892 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7893 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7894 (decode_coding_emacs_mule): Mark variables that gcc
7895 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7896 (detect_coding_iso_2022): Initialize a local variable that might
7897 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7898 this initialization is needed. (Bug#8211)
5f58e762
PE
7899 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7900 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7901 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7902 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7903 Remove unused macros.
f38b440c 7904
232b38b9 7905 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7906 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7907 * character.c (string_count_byte8): Likewise.
232b38b9 7908
fb90da1b
PE
7909 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7910 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7911
fb93dbc2
PE
7912 * chartab.c (copy_sub_char_table): Now static, since it's not used
7913 elsewhere.
5c156ace
PE
7914 (sub_char_table_ref_and_range, char_table_ref_and_range):
7915 Rename locals to avoid shadowing.
bbcd0949 7916 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7917
7d3b3862 7918 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7919 (BIDI_BOB): Remove unused macro.
7d3b3862 7920
6be7d3da
PE
7921 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7922 deduce are never used uninitialized.
c2ed9c8b 7923 * term.c (encode_terminal_code): Likewise.
6be7d3da 7924
75f8807f 7925 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7926
50938595
PE
7927 * tparam.h: New file.
7928 * term.c, tparam.h: Include it.
7929 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7930 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7931 Move these decls to tparam.h, and make them agree with what
7932 is actually in tparam.c. The previous trick of using incompatible
7933 decls in different modules does not conform to the C standard.
7934 All callers of tparam changed to use tparam's actual API.
7935 * tparam.c (tparam1, tparam, tgoto):
7936 Use const pointers where appropriate.
7937
fbceeba2
PE
7938 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7939 * cm.h (struct cm): Likewise.
7940 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7941 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7942 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7943 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7944 (turn_on_face, init_tty): Likewise.
7945 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7946
7f3f1250
PE
7947 * term.c (term_mouse_position): Rename local to avoid shadowing.
7948
e6ca6543
PE
7949 * alloc.c (mark_ttys): Move decl from here ...
7950 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7951
c40f8d15
AS
79522011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7953
7954 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7955
cfe0661d
JB
79562011-03-09 Juanma Barranquero <lekktu@gmail.com>
7957
7958 * search.c (compile_pattern_1): Remove argument regp, unused since
7959 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7960 (compile_pattern): Don't pass it.
7961
0afb4571
J
79622011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7963
7964 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7965 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7966 for ! HAVE_GTK3.
7967 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7968
7969 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7970
7971 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7972 gdk_window_get_screen, gdk_window_get_geometry,
7973 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7974 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7975 (xg_get_pixbuf_from_pixmap): New function.
7976 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7977 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7978 Call xg_get_pixbuf_from_pixmap instead of
7979 gdk_pixbuf_get_from_drawable.
7980 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7981 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7982 (xg_check_special_colors): Use GtkStyleContext and its functions
7983 for HAVE_GTK3.
7984 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7985 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7986 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7987 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7988 Call gtk_widget_get_preferred_size.
0afb4571
J
7989 (xg_frame_resized): gdk_window_get_geometry only takes 5
7990 parameters.
44f230aa
SM
7991 (xg_win_to_widget, xg_event_is_for_menubar):
7992 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7993 (xg_set_widget_bg): New function.
7994 (delete_cb): New function.
895009e1 7995 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7996 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7997 (xg_set_background_color): Call xg_set_widget_bg.
7998 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7999 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8000 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8001 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8002 if ! HAVE_GTK3.
8003 (update_frame_tool_bar): Call gtk_widget_hide.
8004 (xg_initialize): Use GDK_KEY_g.
8005
8006 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8007 if ! HAVE_GTK3
8008 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8009
8010 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8011 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8012 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8013
1c2cc4ef
JB
80142011-03-08 Juanma Barranquero <lekktu@gmail.com>
8015
8016 * w32xfns.c (select_palette): Check success of RealizePalette against
8017 GDI_ERROR, not zero.
8018
33383987 8019See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8020
8021;; Local Variables:
8022;; coding: utf-8
aac0c6e3
MR
8023;; End:
8024
33383987 8025 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8026
8027 This file is part of GNU Emacs.
8028
8029 GNU Emacs is free software: you can redistribute it and/or modify
8030 it under the terms of the GNU General Public License as published by
8031 the Free Software Foundation, either version 3 of the License, or
8032 (at your option) any later version.
8033
8034 GNU Emacs is distributed in the hope that it will be useful,
8035 but WITHOUT ANY WARRANTY; without even the implied warranty of
8036 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8037 GNU General Public License for more details.
8038
8039 You should have received a copy of the GNU General Public License
8040 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.