Manual fix for the dribble file
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6468f31c
LMI
12011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * keyboard.c (Fopen_dribble_file): Document when the file is
4 closed (bug#8056).
5
00bef2ba
AS
62011-07-14 Adam Sjøgren <asjo@koldfront.dk>
7
8 * data.c (car, cdr): add functionality hints to documentation.
9
c965adc5
EZ
102011-07-14 Eli Zaretskii <eliz@gnu.org>
11
df9733bf
EZ
12 * bidi.c (bidi_dump_cached_states): Fix format of displaying
13 bidi_cache_idx.
14
0bb23927
EZ
15 Support bidi reordering of display and overlay strings.
16 * xdisp.c (compute_display_string_pos)
17 (compute_display_string_end): Accept additional argument STRING.
18 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
19 (reseat_to_string): Initialize bidi_it->string.s and
20 bidi_it->string.schars.
21 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
22 NULL (avoids a crash in bidi_paragraph_init). Initialize
23 itb.string.lstring.
24 (init_iterator): Call bidi_init_it only of a valid
25 buffer position was specified. Initialize paragraph_embedding to
26 L2R.
27 (reseat_to_string): Initialize the bidi iterator.
28 (display_string): If we need to ignore text properties of
29 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
30 original value of -1 will not work with bidi.)
31 (compute_display_string_pos): First arg is now struct
32 `text_pos *'; all callers changed. Support display properties on
33 Lisp strings.
34 (compute_display_string_end): Support display properties on Lisp
35 strings.
36 (init_iterator, reseat_1, reseat_to_string): Initialize the
37 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
38 when iterating on a string not from display properties).
39 (compute_display_string_pos, compute_display_string_end): Fix
40 calculation of the object to scan. Fixes an error when using
41 arrow keys.
42 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
43 base_level_stop; instead, set base_level_stop to BEGV. Fixes
44 crashes in vertical-motion.
45 (next_element_from_buffer): Improve commentary for when
46 the iterator is before prev_stop.
47 (init_iterator): Initialize bidi_p from the default value of
48 bidi-display-reordering, not from buffer-local value. Use the
49 buffer-local value only if initializing for buffer iteration.
50 (handle_invisible_prop): Support invisible properties on strings
51 that are being bidi-reordered.
52 (set_iterator_to_next): Support bidi reordering of C strings and
53 Lisp strings.
54 (next_element_from_string): Support bidi reordering of Lisp
55 strings.
56 (handle_stop_backwards): Support Lisp strings as well.
57 (display_string): Support display of R2L glyph rows. Use
58 IT_STRING_CHARPOS when displaying from a Lisp string.
59 (init_iterator): Don't initialize it->bidi_p for strings
60 here.
61 (reseat_to_string): Initialize it->bidi_p for strings here.
62 (next_element_from_string, next_element_from_c_string)
63 (next_element_from_buffer): Add xassert's for correspondence
64 between IT's object being iterated and it->bidi_it.string
65 structure.
66 (face_before_or_after_it_pos): Support bidi iteration.
67 (next_element_from_c_string): Handle the case of the first string
68 character that is not the first one in the visual order.
69 (get_visually_first_element): New function, refactored from common
70 parts of next_element_from_buffer, next_element_from_string, and
71 next_element_from_c_string.
72 (tool_bar_lines_needed, redisplay_tool_bar)
73 (display_menu_bar): Force left-to-right direction. Add a FIXME
74 comment for making that be controlled by a user option.
75 (push_it, pop_it): Save and restore the state of the
76 bidi iterator. Save and restore the bidi_p flag.
77 (pop_it): Iterate out of display property for string iteration as
78 well.
79 (iterate_out_of_display_property): Support iteration over strings.
80 (handle_single_display_spec): Set up it->bidi_it for iteration
81 over a display string, and call bidi_init_it.
82 (handle_single_display_spec, next_overlay_string)
83 (get_overlay_strings_1, push_display_prop): Set up the bidi
84 iterator for displaying display or overlay strings.
85 (forward_to_next_line_start): Don't use the shortcut if
86 bidi-iterating.
87 (back_to_previous_visible_line_start): If handle_display_prop
88 pushed the iterator stack, restore the internal state of the bidi
89 iterator by calling bidi_pop_it same number of times.
90 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
91 and we are bidi-iterating, don't decrement the iterator position;
92 instead, set the first_elt flag in the bidi iterator, to produce
93 the same effect.
94 (reseat_1): Remove redundant setting of string_from_display_prop_p.
95 (push_display_prop): xassert that we are iterating a buffer.
96 (push_it, pop_it): Save and restore paragraph_embedding member.
97 (handle_single_display_spec, next_overlay_string)
98 (get_overlay_strings_1, reseat_1, reseat_to_string)
99 (push_display_prop): Set up the `unibyte' member of bidi_it.string
100 correctly. Don't assume unibyte strings are not bidi-reordered.
101 (compute_display_string_pos)
102 (compute_display_string_end): Fix handling the case of C string.
103 (push_it, pop_it): Save and restore from_disp_prop_p.
104 (handle_single_display_spec, push_display_prop): Set the
105 from_disp_prop_p flag.
106 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
107 (pop_it): Call iterate_out_of_display_property only if we are
108 popping after iteration over a string that came from a display
109 property. Fix a typo in popping stretch info. Add an assertion
110 for verifying that the iterator position is in sync with the bidi
111 iterator.
112 (handle_single_display_spec, get_overlay_strings_1)
113 (push_display_prop): Fix initialization of paragraph direction for
114 string when that of the parent object is not yet determined.
115 (reseat_1): Call bidi_init_it to resync the bidi
116 iterator with IT's position. (Bug#7616)
117 (find_row_edges): If ROW->start.pos gives position
118 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
119 (handle_stop, back_to_previous_visible_line_start, reseat_1):
120 Reset the from_disp_prop_p flag.
121 (SAVE_IT, RESTORE_IT): New macros.
122 (pos_visible_p, face_before_or_after_it_pos)
123 (back_to_previous_visible_line_start)
124 (move_it_in_display_line_to, move_it_in_display_line)
125 (move_it_to, move_it_vertically_backward, move_it_by_lines)
126 (try_scrolling, redisplay_window, display_line): Use them when
127 saving a temporary copy of the iterator and restoring it back.
128 (back_to_previous_visible_line_start, reseat_1)
129 (init_iterator): Empty the bidi cache "stack".
130 (move_it_in_display_line_to): If iterator ended up at
131 EOL, but we never saw any buffer positions smaller than
132 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
133 motion in bidi-reordered lines.
134 (move_it_in_display_line_to): Record prev_method and prev_pos
135 immediately before the call to set_iterator_to_next. Fixes cursor
136 motion in bidi-reordered lines with stretch glyphs and strings
137 displayed in margins. (Bug#8133) (Bug#8867)
138 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
139 TO_CHARPOS.
140 (pos_visible_p): Support positions in bidi-reordered lines. Save
141 and restore bidi cache.
142
143 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
144 (bidi_paragraph_info): Delete unused struct.
145 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
146 (bidi_cache_start): New variable.
147 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
148 to zero.
149 (bidi_cache_fetch_state, bidi_cache_search)
150 (bidi_cache_find_level_change, bidi_cache_iterator_state)
151 (bidi_cache_find, bidi_peek_at_next_level)
152 (bidi_level_of_next_char, bidi_find_other_level_edge)
153 (bidi_move_to_visually_next): Compare cache index with
154 bidi_cache_start rather than with zero.
155 (bidi_fetch_char): Accept new argument STRING; all callers
156 changed. Support iteration over a string. Support strings with
157 display properties. Support unibyte strings. Fix the type of
158 `len' according to what STRING_CHAR_AND_LENGTH expects.
159 (bidi_paragraph_init, bidi_resolve_explicit_1)
160 (bidi_resolve_explicit, bidi_resolve_weak)
161 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
162 iteration over a string.
163 (bidi_set_sor_type, bidi_resolve_explicit_1)
164 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
165 can now be zero (for strings); special values 0 and -1 were
166 changed to -1 and -2, respectively.
167 (bidi_char_at_pos): New function.
168 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
169 Call it instead of FETCH_MULTIBYTE_CHAR.
170 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
171 initialized to valid values.
172 (bidi_init_it): Don't initialize charpos and bytepos with invalid
173 values.
174 (bidi_level_of_next_char): Allow the sentinel "position" to pass
175 the test for valid cached positions. Fix the logic for looking up
176 the sentinel state in the cache. GCPRO the Lisp string we are
177 iterating.
178 (bidi_push_it, bidi_pop_it): New functions.
179 (bidi_initialize): Initialize the bidi cache start stack pointer.
180 (bidi_cache_ensure_space): New function, refactored from part of
181 bidi_cache_iterator_state. Don't assume the required size is just
182 one BIDI_CACHE_CHUNK away.
183 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
184 (bidi_count_bytes, bidi_char_at_pos): New functions.
185 (bidi_cache_search): Don't assume bidi_cache_last_idx is
186 always valid if bidi_cache_idx is valid.
187 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
188 is valid if it's going to be used.
189 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
190 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
191 (bidi_cache_find_level_change, bidi_cache_ensure_space)
192 (bidi_cache_iterator_state, bidi_cache_find)
193 (bidi_find_other_level_edge, bidi_cache_start_stack): All
194 variables related to cache indices are now EMACS_INT.
195
0bb23927
EZ
196 * dispextern.h (struct bidi_string_data): New structure.
197 (struct bidi_it): New member `string'. Make flag members be 1-bit
198 fields, and put them last in the struct.
199 (compute_display_string_pos, compute_display_string_end): Update
200 prototypes.
201 (bidi_push_it, bidi_pop_it): Add prototypes.
202 (struct iterator_stack_entry): New members bidi_p,
203 paragraph_embedding, and from_disp_prop_p.
204 (struct it): Member bidi_p is now a bit field 1 bit wide.
205 (bidi_shelve_cache, bidi_unshelve_cache): Declare
206 prototypes.
207
208 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
209 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
210 and vector-like objects.
211
212 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
213 cache around display iteration.
214
215 * window.c (Fwindow_end, window_scroll_pixel_based)
216 (displayed_window_lines, Frecenter): Save and restore the bidi
217 cache around display iteration.
218
3bbd2265
LMI
2192011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
220
221 * editfns.c (Fdelete_region): Clarify the use of the named
222 parameters (bug#6788).
223
adc47434
MR
2242011-07-14 Martin Rudalics <rudalics@gmx.at>
225
226 * indent.c (Fvertical_motion): Set and restore w->pointm when
227 saving and restoring the window's buffer (Bug#9006).
228
837c31f8
LMI
2292011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
230
231 * editfns.c (Fstring_to_char): Clarify just what is returned
232 (bug#6576). Text by Eli Zaretskii.
233
ac389d0c
JB
2342011-07-13 Juanma Barranquero <lekktu@gmail.com>
235
236 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
237
0be0ce47
EZ
2382011-07-13 Eli Zaretskii <eliz@gnu.org>
239
240 * buffer.c (mmap_find): Fix a typo.
241
cd18e7e3
JB
2422011-07-13 Johan Bockgård <bojohan@gnu.org>
243
244 Fix execution of x selection hooks.
245 * xselect.c (Qx_lost_selection_functions)
246 (Qx_sent_selection_functions): New vars.
247 (syms_of_xselect): DEFSYM them.
248 (x_handle_selection_request): Pass Qx_sent_selection_functions
249 rather than Vx_sent_selection_functions to Frun_hook_with_args.
250 (x_handle_selection_clear,x_clear_frame_selections):
251 Pass Qx_lost_selection_functions rather than
252 Vx_lost_selection_functions to Frun_hook_with_args.
253
47ea7f44
PE
2542011-07-13 Paul Eggert <eggert@cs.ucla.edu>
255
ac389d0c 256 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
257 The old code sometimes used this field without initializing it.
258
47ea7f44
PE
259 * alloc.c (gc_sweep): Don't read past end of array.
260 In theory, the old code could also have corrupted Emacs internals,
261 though it'd be very unlikely.
262
bc985c87
AS
2632011-07-12 Andreas Schwab <schwab@linux-m68k.org>
264
265 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 266 argument. (Bug#4026)
bc985c87 267
0cf34688
LMI
2682011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
269
b3dadd76
LMI
270 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
271 key" (bug#4257).
272
0cf34688
LMI
273 * window.c (Fset_window_start): Doc fix (bug#4199).
274 (Fset_window_hscroll): Ditto.
275
270768cd
PE
2762011-07-12 Paul Eggert <eggert@cs.ucla.edu>
277
077e3dda 278 Fix minor new problems caught by GCC 4.6.1.
270768cd 279 * term.c (init_tty): Remove unused local.
490011a6 280 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 281 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 282 not used otherwise.
270768cd 283
b1f58454
CY
2842011-07-12 Chong Yidong <cyd@stupidchicken.com>
285
286 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
287
22b9578d
LMI
2882011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
289
6e70ab07
LMI
290 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
291 are the mini-buffer and the echo area (bug#3320).
292
22b9578d
LMI
293 * term.c (init_tty): Remove support for supdup, c10 and perq
294 terminals, which are no longer supported (bug#1482).
295
8974cc9f
JB
2962011-07-10 Johan Bockgård <bojohan@gnu.org>
297
298 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
299
a560d974
JD
3002011-07-10 Jan Djärv <jan.h.d@swipnet.se>
301
302 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
303 for non-popups (Bug#3642).
304
1dae0f0a
AS
3052011-07-10 Andreas Schwab <schwab@linux-m68k.org>
306
268c2c36 307 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 308 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
309 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
310 * cm.c (losecursor): Likewise.
1dae0f0a
AS
311 * data.c (fmod): Likewise.
312 * dispnew.c (swap_glyphs_in_rows): Likewise.
313 * emacs.c (memory_warning_signal): Likewise.
314 * floatfns.c (float_error): Likewise.
315 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
316 (otf_open, font_otf_capability, generate_otf_features)
317 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
318 Likewise.
319 * image.c (pbm_read_file): Likewise.
320 * indent.c (string_display_width): Likewise.
321 * intervals.c (check_for_interval, search_for_interval)
322 (inc_interval_count, count_intervals, root_interval)
323 (adjust_intervals_for_insertion, make_new_interval): Likewise.
324 * lread.c (defalias): Likewise.
268c2c36 325 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
326 * regex.c (set_image_of_range_1, set_image_of_range)
327 (regex_grow_registers): Likewise.
328 * sysdep.c (strerror): Likewise.
329 * termcap.c (valid_filename_p, tprint, main): Likewise.
330 * tparam.c (main): Likewise.
331 * unexhp9k800.c (run_time_remap, save_data_space)
332 (update_file_ptrs, read_header, write_header, calculate_checksum)
333 (copy_file, copy_rest, display_header): Likewise.
334 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
335 Likewise.
336 * xdisp.c (check_it): Likewise.
337 * xfaces.c (register_color, unregister_color, unregister_colors):
338 Likewise.
339 * xfns.c (print_fontset_result): Likewise.
340 * xrdb.c (member, fatal, main): Likewise.
341
99033785
PE
3422011-07-10 Paul Eggert <eggert@cs.ucla.edu>
343
344 Fix minor problems found by static checking (Bug#9031).
345 * chartab.c (char_table_set_range, map_sub_char_table):
346 Remove unused locals.
347 (uniprop_table): Now static.
348 * composite.c (_work_char): Remove unused static var.
349
9cb2ac56
JB
3502011-07-09 Juanma Barranquero <lekktu@gmail.com>
351
352 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
353
f25661f0
JD
3542011-07-09 Jan Djärv <jan.h.d@swipnet.se>
355
356 * gtkutil.c (qttip_cb): Remove code without function.
357
8278c4fe
EZ
3582011-07-09 Eli Zaretskii <eliz@gnu.org>
359
360 * w32.c (pthread_sigmask): New stub.
361
1692ae2d 3622011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 363
8a6ebd58 364 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
365 sigprocmask is portable only for single-threaded applications, and
366 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
367 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
368 (LIBES): Use it.
369 * callproc.c (Fcall_process):
370 * process.c (create_process):
371 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
372 Use pthread_sigmask, not sigprocmask.
123403e4 373
1b854618
JD
3742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
375
376 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
377 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
378 wrong (Bug#8591).
379
3fe4b549
JD
3802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
381
0ce7e563
JD
382 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
383 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
384 (xg_hide_tooltip): Fix comment.
385
3fe4b549
JD
386 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
387 in registerServicesMenuSendTypes.
388 (validRequestorForSendType): Don't check ns_return_types.
389
390 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
391 ns_return_type.
392
5df75e47
JR
3932011-07-08 Jason Rumney <jasonr@gnu.org>
394
395 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
396 frame struct members of non-existent frames (Bug#6284).
397
699c10bd
JD
3982011-07-08 Jan Djärv <jan.h.d@swipnet.se>
399
4393663b
JD
400 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
401 variable firstTime not needed on OSX >= 10.6.
402 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
403 >= 10.5. Use setKnobProportion, setDoubleValue.
404
405 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
406 (MAC_OS_X_VERSION_10_5): Define if not defined.
407 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
408 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
409 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
410
411 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
412 cString and lossyCString on OSX >= 10.4
413
414 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
415 sizeToFit on OSX >= 10.2.
416
417 * nsimage.m (allocInitFromFile): Don't use deprecated method
418 bestRepresentationForDevice on OSX >= 10.6.
419
420 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
421 to avoid warning.
422
423 * emacs.c: Declare unexec_init_emacs_zone.
424
a63e0781
JD
425 * nsgui.h: Fix compiler warning about gnulib redefining verify.
426
699c10bd
JD
427 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
428
429 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
430 on svcsMenu (Bug#8842).
431
432 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
433 ns_return_types.
434 (Fns_list_services): Just return Qnil on 10.6, code not working there.
435
436 * nsterm.m (QUTF8_STRING): Declare.
437 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
438 (validRequestorForSendType): Return type is (id).
439 Change indexOfObjectIdenticalTo to indexOfObject.
440 Check if we have local selection before returning self (Bug#8842).
441 (writeSelectionToPasteboard): Put local selection into paste board
442 if we have a local selection (Bug#8842).
443 (syms_of_nsterm): DEFSYM QUTF8_STRING.
444
445 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
446 (ns_get_local_selection): Declare.
447
54e10184
LMI
4482011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
449
9888ff71
LMI
450 * keymap.c (describe_map_tree): Don't insert a double newline at
451 the end of the buffer (bug#1169) and return whether we inserted
452 something.
453
54e10184
LMI
454 * callint.c (Fcall_interactively): Change "reading args" to
455 "providing args" to try to clarify what it does (bug#1010).
456
15fa4783
KH
4572011-07-07 Kenichi Handa <handa@m17n.org>
458
459 * composite.c (composition_compute_stop_pos): Ignore a static
460 composition starting before CHARPOS (Bug#8915).
461
462 * xdisp.c (handle_composition_prop): Likewise.
463
a8815b00
EZ
4642011-07-07 Eli Zaretskii <eliz@gnu.org>
465
466 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
467 (Bug#9015)
468
ef7b981d 4692011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
470
471 * character.h (unicode_category_t): New enum type.
472
473 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
474 (Qchar_code_property_table): New variable.
475 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
476 (UNIPROP_COMPRESSED_FORM_P): New macros.
477 (char_table_ascii): Uncompress the compressed values.
478 (sub_char_table_ref): New arg is_uniprop. Callers changed.
479 Uncompress the compressed values.
ac389d0c 480 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
481 (char_table_ref_and_range): Uncompress the compressed values.
482 (sub_char_table_set): New arg is_uniprop. Callers changed.
483 Uncompress the compressed values.
484 (sub_char_table_set_range): Args changed. Callers changed.
485 (char_table_set_range): Adjuted for the above change.
486 (map_sub_char_table): Delete args default_val and parent. Add arg
487 top. Give decoded values to a Lisp function.
488 (map_char_table): Adjusted for the above change. Give decoded
489 values to a Lisp function. Gcpro more variables.
490 (uniprop_table_uncompress)
491 (uniprop_decode_value_run_length): New functions.
492 (uniprop_decoder, uniprop_decoder_count): New variables.
493 (uniprop_get_decoder, uniprop_encode_value_character)
494 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
495 New functions.
496 (uniprop_encoder, uniprop_encoder_count): New variables.
497 (uniprop_get_encoder, uniprop_table)
498 (Funicode_property_table_internal, Fget_unicode_property_internal)
499 (Fput_unicode_property_internal): New functions.
500 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
501 Sunicode_property_table_internal, Sget_unicode_property_internal,
502 and Sput_unicode_property_internal. Defvar_lisp
503 char-code-property-alist.
504
505 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
506 Vunicode_category_table.
507
508 * font.c (font_range): Adjusted for the change of
509 Vunicode_category_table.
510
76b397fb
DN
5112011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
512
513 * m/iris4d.h: Remove file, move contents ...
514 * s/irix6-5.h: ... here.
515
22b4128e
PE
5162011-07-06 Paul Eggert <eggert@cs.ucla.edu>
517
518 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
519 * alloc.c (mark_buffer):
520 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
521 (clone_per_buffer_values): Don't assume that
22b4128e
PE
522 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
523 This isn't true in general, and it's particularly not true
524 if Emacs is configured with --with-wide-int.
525 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
526 New macros, used in the buffer.c change.
527
869795d6
JD
5282011-07-05 Jan Djärv <jan.h.d@swipnet.se>
529
530 * xsettings.c: Use both GConf and GSettings if both are available.
531 (store_config_changed_event): Add comment.
532 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
533 (store_tool_bar_style_changed): New functions.
534 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
535 (struct xsettings): Move font inside HAVE_XFT.
536 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
537 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
538 Move inside HAVE_XFT.
539 (something_changed_gsettingsCB): Renamed from something_changedCB.
540 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
541 also.
542 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
543 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
544 (something_changed_gconfCB): Renamed from something_changedCB.
545 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
546 (parse_settings): Move check for font inside HAVE_XFT.
547 (read_settings, apply_xft_settings): Add comment.
548 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
549 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
550 call store_font_name_changed.
551 (xft_settings_event): Add comment.
552 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
553 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
554 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
555 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
556 (xsettings_initialize): Call init_gsettings last.
557 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
558 comment.
559
d8ed26bd
PE
5602011-07-05 Paul Eggert <eggert@cs.ucla.edu>
561
562 Random fixes. E.g., (random) never returned negative values.
563 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
564 subseconds part to the entropy, as that's a bit more random.
565 Prefer signed to unsigned, since the signedness doesn't matter and
566 in general we prefer signed. When given a limit, use a
567 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
568 latter isn't right if USE_2_TAGS_FOR_INTS.
569 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
570 not 0..VALMASK. Don't discard "excess" bits that random () returns.
571
cabf1cac
SM
5722011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
573
574 * textprop.c (text_property_stickiness):
575 Obey Vtext_property_default_nonsticky.
576 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
577 * w32fns.c (syms_of_w32fns):
578 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
579
6e9b2be9
PE
5802011-07-04 Paul Eggert <eggert@cs.ucla.edu>
581
582 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
583 This is more efficient than Ffile_directory_p and avoids a minor race.
584
90186c68
LMI
5852011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
586
7c301272
LMI
587 * buffer.c (Foverlay_put): Say what the return value is
588 (bug#7835).
589
c4f2d8d4
LMI
590 * fileio.c (barf_or_query_if_file_exists): Check first if the file
591 is a directory before asking whether to use the file name
592 (bug#7564).
ad637907
LMI
593 (barf_or_query_if_file_exists): Make the "File is a directory"
594 error be more correct.
c4f2d8d4 595
90186c68
LMI
596 * fns.c (Frequire): Remove the mention of the .gz files, since
597 that's installation-specific, but keep the mention of
598 `get-load-suffixes'.
599
da64016e
PE
6002011-07-04 Paul Eggert <eggert@cs.ucla.edu>
601
602 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
603 Report string overflow if the output is too long.
604
7d47b580
JB
6052011-07-04 Juanma Barranquero <lekktu@gmail.com>
606
a555cb87
JB
607 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
608 (syms_of_gnutls): Remove duplicate DEFSYM for
609 Qgnutls_bootprop_verify_hostname_error, an error for
610 Qgnutls_bootprop_verify_error (which is no longer used).
611
7d47b580
JB
612 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
613 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
614 Also (re)move comments that are misplaced or no longer relevant.
615
1e49bfab
LMI
6162011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
617
618 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
619
1485f4c0
CY
6202011-07-03 Chong Yidong <cyd@stupidchicken.com>
621
622 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
623 and background color parameters if they have been changed.
624
a9ab721e
LMI
6252011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
626
627 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
628
cf7cff57
PE
6292011-07-03 Paul Eggert <eggert@cs.ucla.edu>
630
2e13213d
PE
631 * xsettings.c (SYSTEM_FONT): Define only when used.
632 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
633
cf7cff57
PE
634 * keymap.c (access_keymap_1): Now static.
635
7a8e04f7
CY
6362011-07-02 Chong Yidong <cyd@stupidchicken.com>
637
638 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
639 leave any prefix arg for the up event (Bug#1586).
640
61352f62
LMI
6412011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
642
69bb1ef7
LMI
643 * lread.c (syms_of_lread): Mention single symbols defined by
644 `defvar' or `defconst' (bug#7154).
645
61352f62 646 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 647 (Frequire): Mention get-load-suffixes.
61352f62 648
28545e04
MR
6492011-07-02 Martin Rudalics <rudalics@gmx.at>
650
651 * window.h (window): Remove clone_number slot.
652 * window.c (Fwindow_clone_number, Fset_window_clone_number):
653 Remove.
654 (make_parent_window, make_window, saved_window)
655 (Fset_window_configuration, save_window_save): Don't deal with
656 clone numbers.
657 * buffer.c (Qclone_number): Remove declaration.
658 (sort_overlays, overlay_strings): Don't deal with clone numbers.
659
3349e122
SM
6602011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
661
662 Add multiple inheritance to keymaps.
663 * keymap.c (Fmake_composed_keymap): New function.
664 (Fset_keymap_parent): Simplify.
665 (fix_submap_inheritance): Remove.
666 (access_keymap_1): New function extracted from access_keymap to handle
667 embedded parents and handle lists of maps.
668 (access_keymap): Use it.
669 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
670 (Fcopy_keymap): Handle embedded parents.
671 (Fcommand_remapping, define_as_prefix): Simplify.
672 (Fkey_binding): Simplify.
673 (syms_of_keymap): Move minibuffer-local-completion-map,
674 minibuffer-local-filename-completion-map,
675 minibuffer-local-must-match-map, and
676 minibuffer-local-filename-must-match-map to Elisp.
677 (syms_of_keymap): Defsubr make-composed-keymap.
678 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
679 (parse_menu_item): Trivial simplification.
680
3279eb87
GM
6812011-07-01 Glenn Morris <rgm@gnu.org>
682
683 * Makefile.in (SETTINGS_LIBS): Fix typo.
684
4550efdf
KI
6852011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
686
687 * coding.c (Fencode_coding_string): Record the last coding system
688 used, as the function doc string says (bug#8738).
689
0949d2b6
JD
6902011-07-01 Jan Djärv <jan.h.d@swipnet.se>
691
692 * xsettings.c (store_monospaced_changed): Take new font as arg and
693 check for change against current_mono_font.
694 (EMACS_TYPE_SETTINGS): Remove this and related defines.
695 (emacs_settings_constructor, emacs_settings_get_property)
696 (emacs_settings_set_property, emacs_settings_class_init)
697 (emacs_settings_init, gsettings_obj): Remove.
698 (something_changedCB): New function for HAVE_GSETTINGS.
699 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
700 with value as argument.
701 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
702 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 703 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
704 "changed".
705
706 * xgselect.c: Add defined (HAVE_GSETTINGS).
707 (xgselect_initialize): Ditto.
708
709 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
710 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
711 xg_select.
712
bbc6b304
PE
7132011-07-01 Paul Eggert <eggert@cs.ucla.edu>
714
715 * eval.c (struct backtrace): Simplify and port the data structure.
716 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
717 signed bit field, as this assumption is not portable and it makes
718 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
719 "char debug_on_exit : 1" as this is not portable either; instead,
720 use the portable "unsigned int debug_on_exit : 1". Remove unused
721 member evalargs. Remove obsolete comments about cc bombing out.
722
9851bfc5
JD
7232011-06-30 Jan Djärv <jan.h.d@swipnet.se>
724
51bb811f 725 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
726 Let HAVE_GSETTINGS override HAVE_GCONF.
727 (store_monospaced_changed): New function.
728 (EMACS_SETTINGS): A new type derived from GObject to handle
729 GSettings notifications.
730 (emacs_settings_constructor, emacs_settings_get_property)
731 (emacs_settings_set_property, emacs_settings_class_init):
732 New functions.
733 (gsettings_client, gsettings_obj): New variables.
734 (GSETTINGS_SCHEMA): New define.
735 (something_changedCB): Call store_monospaced_changed.
736 (init_gsettings): New function.
737 (xsettings_initialize): Call init_gsettings.
738 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
739 to NULL.
740
741 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
742 GCONF_CFLAGS/LIBS.
743
5386012d
MR
7442011-06-29 Martin Rudalics <rudalics@gmx.at>
745
746 * window.c (resize_root_window, grow_mini_window)
747 (shrink_mini_window): Rename Qresize_root_window to
748 Qwindow_resize_root_window and Qresize_root_window_vertically to
749 Qwindow_resize_root_window_vertically.
750
f13e0b08
PE
7512011-06-28 Paul Eggert <eggert@cs.ucla.edu>
752
753 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
754
94515237
JB
7552011-06-27 Juanma Barranquero <lekktu@gmail.com>
756
757 * makefile.w32-in: Redesign dependencies so they reflect more
758 clearly which files are directly included by each source file,
759 and not through other includes.
760
e43b6e43
MR
7612011-06-27 Martin Rudalics <rudalics@gmx.at>
762
763 * buffer.c (Qclone_number): Declare static and DEFSYM it.
764 (sort_overlays, overlay_strings): When an overlay's clone number
765 matches the window's clone number process the overlay even if
766 the overlay's window property doesn't match the current window.
767
d68443dc
MR
768 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
769 (Fwindow_hchild): Rename to Fwindow_left_child.
770 (Fwindow_next): Rename to Fwindow_next_sibling.
771 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
772 (resize_window_check): Rename to window_resize_check.
773 (resize_window_apply): Rename to window_resize_apply.
774 (Fresize_window_apply): Rename to Fwindow_resize_apply.
775 (Fdelete_other_windows_internal, resize_frame_windows)
776 (Fsplit_window_internal, Fdelete_window_internal)
777 (grow_mini_window, shrink_mini_window)
778 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 779
c7e73be5
JD
7802011-06-26 Jan Djärv <jan.h.d@swipnet.se>
781
782 * emacsgtkfixed.h: State that this is only used with Gtk+3.
783 (emacs_fixed_set_min_size): Remove.
784 (emacs_fixed_new): Take frame as argument.
785
786 * emacsgtkfixed.c: State that this is only used with Gtk+3.
787 (_EmacsFixedPrivate): Remove minwidth/height.
788 Add struct frame *f.
789 (emacs_fixed_init): Initialize priv->f.
790 (get_parent_class, emacs_fixed_set_min_size): Remove.
791 (emacs_fixed_new): Set priv->f to argument.
792 (emacs_fixed_get_preferred_width)
793 (emacs_fixed_get_preferred_height): Use min_width/height from
794 frames size_hint to set minimum and natural (Bug#8919).
795 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
796 and use min_width/height from frames size_hint to set
797 min_width/height (Bug#8919).
798
799 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
800 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
801 Fix indentation.
c7e73be5 802
cf99dcf8
EZ
8032011-06-26 Eli Zaretskii <eliz@gnu.org>
804
805 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
806 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
807 called at ZV.
808
029529ac
CY
8092011-06-26 Chong Yidong <cyd@stupidchicken.com>
810
811 * process.c (wait_reading_process_output): Bypass select if
812 waiting for a cell while ignoring keyboard input, and input is
813 pending. Suggested by Jan Djärv (Bug#8869).
814
7a7ef429
PE
8152011-06-25 Paul Eggert <eggert@cs.ucla.edu>
816
817 Use gnulib's dup2 module instead of rolling our own.
818 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
819
11fdef7d 8202011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
821
822 * dispnew.c (scrolling_window): Before scrolling, turn off a
823 mouse-highlight in the window being scrolled.
824
cd3520a4
JB
8252011-06-24 Juanma Barranquero <lekktu@gmail.com>
826
827 Move DEFSYM to lisp.h and use everywhere.
828
829 * character.h (DEFSYM): Move declaration...
830 * lisp.h (DEFSYM): ...here.
831
832 * gnutls.c:
833 * minibuf.c:
834 * w32menu.c:
835 * w32proc.c:
836 * w32select.c: Don't include character.h.
837
838 * alloc.c (syms_of_alloc):
839 * buffer.c (syms_of_buffer):
840 * bytecode.c (syms_of_bytecode):
841 * callint.c (syms_of_callint):
842 * casefiddle.c (syms_of_casefiddle):
843 * casetab.c (init_casetab_once):
844 * category.c (init_category_once, syms_of_category):
845 * ccl.c (syms_of_ccl):
846 * cmds.c (syms_of_cmds):
847 * composite.c (syms_of_composite):
848 * dbusbind.c (syms_of_dbusbind):
849 * dired.c (syms_of_dired):
850 * dispnew.c (syms_of_display):
851 * doc.c (syms_of_doc):
852 * editfns.c (syms_of_editfns):
853 * emacs.c (syms_of_emacs):
854 * eval.c (syms_of_eval):
855 * fileio.c (syms_of_fileio):
856 * fns.c (syms_of_fns):
857 * frame.c (syms_of_frame):
858 * fringe.c (syms_of_fringe):
859 * insdel.c (syms_of_insdel):
860 * keymap.c (syms_of_keymap):
861 * lread.c (init_obarray, syms_of_lread):
862 * macros.c (syms_of_macros):
863 * msdos.c (syms_of_msdos):
864 * print.c (syms_of_print):
865 * process.c (syms_of_process):
866 * search.c (syms_of_search):
867 * sound.c (syms_of_sound):
868 * syntax.c (init_syntax_once, syms_of_syntax):
869 * terminal.c (syms_of_terminal):
870 * textprop.c (syms_of_textprop):
871 * undo.c (syms_of_undo):
872 * w32.c (globals_of_w32):
873 * window.c (syms_of_window):
874 * xdisp.c (syms_of_xdisp):
875 * xfaces.c (syms_of_xfaces):
876 * xfns.c (syms_of_xfns):
877 * xmenu.c (syms_of_xmenu):
878 * xsettings.c (syms_of_xsettings):
879 * xterm.c (syms_of_xterm): Use DEFSYM.
880
4228cf16
TZ
8812011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
882
cd3520a4 883 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 884
7fcccf1e
PE
8852011-06-23 Paul Eggert <eggert@cs.ucla.edu>
886
7efb4e0e
PE
887 Integer and buffer overflow fixes (Bug#8873).
888
ff5844ad
PE
889 * print.c (printchar, strout): Check for string overflow.
890 (PRINTPREPARE, printchar, strout):
891 Don't set size unless allocation succeeds.
892
90532f02
PE
893 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
894 for sizes. Check for string overflow more accurately.
895 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
896
6d84508d
PE
897 * macros.c: Integer and buffer overflow fixes.
898 * keyboard.h (struct keyboard.kbd_macro_bufsize):
899 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
900 Use ptrdiff_t, not int, for sizes.
901 Don't increment bufsize until after realloc succeeds.
902 Check for size-calculation overflow.
903 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
904
437b2cb4
PE
905 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
906
8b9ac8b4
PE
907 * lread.c: Integer overflow fixes.
908 (read_integer): Radix is now EMACS_INT, not int,
909 to improve quality of diagnostics for out-of-range radices.
910 Calculate buffer size correctly for out-of-range radices.
911 (read1): Check for integer overflow in radices, and in
912 read-circle numbers.
82cb60d3
PE
913 (read_escape): Avoid int overflow.
914 (Fload, openp, read_buffer_size, read1)
915 (substitute_object_recurse, read_vector, read_list, map_obarray):
916 Use ptrdiff_t, not int, for sizes.
917 (read1): Use EMACS_INT, not int, for sizes.
20270765 918 Check for size overflow.
8b9ac8b4 919
7fcccf1e
PE
920 * image.c (cache_image): Check for size arithmetic overflow.
921
bfbbd7e7
PE
922 * lread.c: Integer overflow issues.
923 (saved_doc_string_size, saved_doc_string_length)
924 (prev_saved_doc_string_size, prev_saved_doc_string_length):
925 Now ptrdiff_t, not int.
926 (read1): Don't assume doc string length fits in int. Check for
927 out-of-range doc string lengths.
928 (read_list): Don't assume file position fits in int.
39019e54 929 (read_escape): Check for hex character overflow.
bfbbd7e7 930
4e323265
LL
9312011-06-22 Leo Liu <sdl.web@gmail.com>
932
933 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
934 Move to minibuffer.el.
935
85fece3e
PE
9362011-06-22 Paul Eggert <eggert@cs.ucla.edu>
937
20b84ce9 938 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
939 The following patches are for when GLYPH_DEBUG && !XASSERT.
940 * dispextern.h (trace_redisplay_p, dump_glyph_string):
941 * dispnew.c (flush_stdout):
942 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
943 Mark as externally visible.
944 * dispnew.c (check_window_matrix_pointers): Now static.
945 * dispnew.c (window_to_frame_vpos):
946 * xfns.c (unwind_create_frame):
947 * xterm.c (x_check_font): Remove unused local.
948 * scroll.c (CHECK_BOUNDS):
949 * xfaces.c (cache_fache): Rename local to avoid shadowing.
950 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
951 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
952 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
953 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
954 Now static.
955 (debug_method_add): Use va_list and vsprintf rather than relying
956 on undefined behavior with wrong number of arguments.
957 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
958 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
959 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
960 since we're not interested in debugging glyphs with old libraries.
961 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
962 GCC 4.6.0's static checking.
963
0766b489
PE
9642011-06-22 Paul Eggert <eggert@cs.ucla.edu>
965
31fd4b32
PE
966 Integer overflow and signedness fixes (Bug#8873).
967 A few related buffer overrun fixes, too.
968
b79e8648
PE
969 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
970
0766b489
PE
971 * dispextern.h (struct face.stipple):
972 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
973 (x_bitmap_mask, x_allocate_bitmap_record)
974 (x_create_bitmap_from_data, x_create_bitmap_from_file)
975 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
976 (x_create_bitmap_from_xpm_data):
977 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
978 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
979 (.bitmaps_last):
980 * xfaces.c (load_pixmap):
981 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
982 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
983 (.bitmaps_last, struct x_output.icon_bitmap):
984 Use ptrdiff_t, not int, for bitmap indexes.
985 (x_allocate_bitmap_record): Check for size overflow.
986 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
987
b081724f
PE
988 Use ptrdiff_t, not int, for overlay counts.
989 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
990 * editfns.c (overlays_around, get_pos_property):
991 * textprop.c (get_char_property_and_overlay):
992 * xdisp.c (next_overlay_change, note_mouse_highlight):
993 * xfaces.c (face_at_buffer_position):
21514da7
PE
994 * buffer.c (OVERLAY_COUNT_MAX): New macro.
995 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
996 (Fnext_overlay_change, Fprevious_overlay_change)
997 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 998 Use ptrdiff_t, not int, for sizes.
21514da7 999 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1000
3de73e5e
PE
1001 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1002
2606c57b
PE
1003 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1004 (x_session_initialize): Do not assume string length fits in int.
1005
aaafe47a
PE
1006 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1007 This is unlikely, but can occur if DPI is outlandish.
1008
2674ddc8 1009 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1010 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1011
28154962
PE
1012 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1013 * xrdb.c (magic_file_p, search_magic_path):
1014 Omit last arg SUFFIX; it was always 0. All callers changed.
1015 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1016
7de51af5
PE
1017 * xfont.c (xfont_match): Avoid need for strlen.
1018
25ed6cc3
PE
1019 * xfns.c: Don't assume strlen fits in int.
1020 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1021
4eab31dd
PE
1022 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1023 not unsigned long, as we prefer signed integers. All callers changed.
1024 Detect integer overflow in repeat count.
1025 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1026 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1027
171e2a58
PE
1028 * termcap.c: Don't assume sizes fit in int and never overflow.
1029 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1030 (gobble_line): Check for size-calculation overflow.
1031
ad39faca 1032 * minibuf.c (Fread_buffer):
6e5bb2dc 1033 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1034 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1035 Don't assume string length fits in int.
1036
52c61c22 1037 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1038 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1039
b5b8c9e5
PE
1040 * font.c: Don't assume string length fits in int.
1041 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1042 Use ptrdiff_t, not int.
ccd6111c
PE
1043 (font_intern_prop): Don't assume string length fits in int.
1044 Don't assume integer property fits in fixnum.
1045 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1046
882f0d81 1047 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1048 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1049 Reformulate so as not to need the command string.
1050 Invoke gzip -cd rather than gunzip, as it's more portable.
1051 (lock_info_type, lock_file_1, lock_file):
1052 Don't assume pid_t and time_t fit in unsigned long.
1053 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1054 (current_lock_owner): Prefer signed type for sizes.
1055 Use memcpy, not strncpy, where memcpy is what is really wanted.
1056 Don't assume (via atoi) that time_t and pid_t fit in int.
1057 Check for time_t and/or pid_t out of range, e.g., via a network share.
1058 Don't alloca where an auto var works fine.
1059
93f4cf88
PE
1060 * fileio.c: Fix some integer overflow issues.
1061 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1062 Don't assume string length fits in int.
1063 (directory_file_name): Don't assume string length fits in long.
1064 (make_temp_name): Don't assume pid fits in int, or that its print
1065 length is less than 20.
1066
f3e92b69
PE
1067 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1068
1bfdaf10
PE
1069 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1070
35016e9a
PE
1071 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1072
3d1e65a1
PE
1073 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1074 We prefer signed integers, even for size calculations.
1075
0b963a93
PE
1076 * emacs.c: Don't assume string length fits in 'int'.
1077 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1078 (main): Don't invoke strlen when not needed.
1079
573f4b54
PE
1080 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1081 (XD_DEBUG_MESSAGE): Don't waste a byte.
1082
989f33ba
PE
1083 * callproc.c (getenv_internal_1, getenv_internal)
1084 (Fgetenv_internal):
965d34eb
PE
1085 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1086
e4d29b33
PE
1087 * lread.c (invalid_syntax): Omit length argument.
1088 All uses changed. This doesn't fix a bug, but it simplifies the
1089 code away from its former Hollerith-constant appearance, and it's
1090 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1091 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1092
eb49b136
PE
1093 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1094 This didn't break anything, but it didn't help either.
1095 It's confusing to put a bogus integer in a place where the actual
1096 value does not matter.
9f62aeb1 1097 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1098 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1099
15375a22
PE
1100 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1101 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1102 implementation.
b61cc01c
PE
1103 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1104 We prefer signed types, and the value cannot exceed the EMACS_INT
1105 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1106 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1107 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1108 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1109
53b2623d
PE
1110 * indent.c (sane_tab_width): New function.
1111 (current_column, scan_for_column, Findent_to, position_indentation)
1112 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1113 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1114
51cab52b 1115 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1116
f2ed8a70
PE
1117 * lisp.h (lint_assume): New macro.
1118 * composite.c (composition_gstring_put_cache):
1119 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1120
abe80cc6
PE
1121 * editfns.c, insdel.c:
1122 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1123
b02c740e
PE
1124 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1125
ebc96716
PE
1126 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1127
b4e50fa0 1128 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1129 Use much-faster test for byte-length change.
311d5d7c 1130 Don't assume string byte-length fits in 'int'.
a4cf38e4 1131 Check that character arg fits in 'int'.
85461888 1132 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1133
c0c1ee9f
PE
1134 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1135
a498d7f4
PE
1136 * fns.c (concat): Catch string overflow earlier.
1137 Do not rely on integer wraparound.
1138
51cab52b
PE
1139 * dispextern.h (struct it.overlay_strings_charpos)
1140 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1141 * xdisp.c (forward_to_next_line_start)
1142 (back_to_previous_visible_line_start)
1143 (reseat_at_next_visible_line_start, next_element_from_buffer):
1144 Don't arbitrarily truncate the value of 'selective' to int.
1145
76031fad
PE
1146 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1147
5eb55db9
PE
1148 * composite.c: Don't truncate sizes to 'int'.
1149 (composition_gstring_p, composition_reseat_it)
1150 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1151 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1152 not EMACS_UINT, for indexes.
5eb55db9 1153
0703a717
PE
1154 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1155
d6202519
PE
1156 * buffer.c: Include <verify.h>.
1157 (struct sortvec.priority, struct sortstr.priority):
8961a454 1158 Now EMACS_INT, not int.
c20998a7 1159 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1160 (struct sortstr.size, record_overlay_string)
1161 (struct sortstrlist.size, struct sortlist.used):
1162 Don't truncate size to int.
1163 (record_overlay_string): Check for size-calculation overflow.
d6202519 1164 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1165
d5a19415
JM
11662011-06-22 Jim Meyering <meyering@redhat.com>
1167
029529ac 1168 Don't leak an XBM-image-sized buffer
d5a19415
JM
1169 * image.c (xbm_load): Free the image buffer after using it.
1170
a9041e6c
PE
11712011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1172
1173 Port to Sun C.
1174 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1175 that Sun C diagnosed.
1176 * fns.c (secure_hash): Fix pointer signedness issue.
1177 * intervals.c (static_offset_intervals): New function.
1178 (offset_intervals): Use it.
1179
7f3f739f
LL
11802011-06-21 Leo Liu <sdl.web@gmail.com>
1181
1182 * deps.mk (fns.o):
1183 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1184 sha512.h.
1185
1186 * fns.c (secure_hash): Rename from crypto_hash_function and change
1187 the first arg to accept symbols.
5b66d427 1188 (Fsecure_hash): New primitive.
7f3f739f
LL
1189 (syms_of_fns): New symbols.
1190
76147d94
DD
11912011-06-20 Deniz Dogan <deniz@dogan.se>
1192
1193 * process.c (Fset_process_buffer): Clarify return value in
1194 docstring.
1195
7d7d0045
CY
11962011-06-18 Chong Yidong <cyd@stupidchicken.com>
1197
1198 * dispnew.c (add_window_display_history): Use BVAR.
1199
1200 * xdisp.c (debug_method_add): Use BVAR.
1201 (check_window_end, dump_glyph_matrix, dump_glyph)
1202 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1203
1204 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1205 Likewise.
1206
1207 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1208 check till after the cache is created in init_frame_faces.
1209
ff2bc410
SM
12102011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1211
1212 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1213
28177add
PE
12142011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1215
dd3482fe
PE
1216 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1217 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1218 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1219
393d71f3 1220 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1221 * fileio.c (Finsert_file_contents):
1222 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1223 Remove the old (too-loose) buffer overflow checks.
1224 They weren't needed, since make_gap checks for buffer overflow.
1225 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1226 The old code merely checked for Emacs fixnum overflow, and relied
1227 on undefined (wraparound) behavior. The new code avoids undefined
1228 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1229
2e6813b0 1230 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1231 Tune. Don't use wider integers than needed. Don't use alloca.
1232 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1233
599a9e4f
PE
1234 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1235
99561444
PE
1236 * insdel.c, lisp.h (buffer_overflow): New function.
1237 (insert_from_buffer_1, replace_range, replace_range_2):
1238 * insdel.c (make_gap_larger):
1239 * editfns.c (Finsert_char):
1240 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1241
28177add
PE
1242 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1243
e69dafad
PE
12442011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1245
a7af7fde 1246 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1247
b1c46f02
PE
1248 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1249 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1250
e69dafad
PE
1251 * fileio.c: Don't assume EMACS_INT fits in off_t.
1252 (emacs_lseek): New static function.
1253 (Finsert_file_contents, Fwrite_region): Use it.
1254 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1255
566684ea
PE
1256 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1257
e6966cd6
PE
1258 * fns.c: Don't overflow int when computing a list length.
1259 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1260 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1261 truncation on 64-bit hosts. Check for QUIT every
1262 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1263 faster and is responsive enough.
1264 (Flength): Report an error instead of overflowing an integer.
1265 (Fsafe_length): Return a float if the value is not representable
1266 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1267 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1268 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1269
dd0b0efb
PE
1270 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1271 (header_size, word_size): New constants.
1272 (allocate_vectorlike): Don't check size overflow here.
1273 (allocate_vector): Check it here instead, since this is the only
1274 caller of allocate_vectorlike that could cause overflow.
1275 Check that the new vector's length is representable as a fixnum.
1276
86fe5cfe
PE
1277 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1278 The previous code was bogus. For example, next_almost_prime (32)
1279 returned 39, which is undesirable as it is a multiple of 3; and
1280 next_almost_prime (24) returned 25, which is a multiple of 5 so
1281 why was the code bothering to check for multiples of 7?
1282
80e88859
PE
1283 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1284
4a2f0ad6
PE
1285 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1286
f66c7cf8
PE
1287 Variadic C functions now count arguments with ptrdiff_t.
1288 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1289 Back then I didn't know that the Emacs coding style prefers signed int.
1290 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1291 were being counted with int, which may truncate counts on 64-bit
1292 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1293 * lisp.h (struct Lisp_Subr.function.aMANY)
1294 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1295 Arg counts are now ptrdiff_t, not size_t.
1296 All variadic functions and their callers changed accordingly.
1297 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1298 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1299 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1300 * callint.c (Fcall_interactively): Check arg count for overflow,
1301 to avoid potential buffer overrun. Use signed char, not 'int',
1302 for 'varies' array, so that we needn't bother to check its size
1303 calculation for overflow.
1304 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1305 * eval.c (apply_lambda):
1306 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1307 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1308 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1309
a1759b76
PE
1310 * callint.c (Fcall_interactively): Don't use index var as event count.
1311
d96be9fc
PE
1312 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1313 * mem-limits.h (SIZE): Remove; no longer used.
1314
a690a978 1315 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1316
578c21e6
PE
1317 Remove unnecessary casts.
1318 * xterm.c (x_term_init):
1319 * xfns.c (x_set_border_pixel):
1320 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1321 These aren't needed now that we assume ANSI C.
1322
96f53c6c
PE
1323 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1324 It's more likely to cause problems (due to unsigned overflow)
1325 than to cure them.
1326
83c77d31
PE
1327 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1328
ee2079f1
PE
1329 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1330
6da65536
PE
1331 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1332
7147c4a4
PE
1333 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1334
193e32d9
PE
1335 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1336
e5533da6
PE
1337 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1338
9910e595
PE
1339 GLYPH_CODE_FACE returns EMACS_INT, not int.
1340 * dispextern.h (merge_faces):
1341 * xfaces.c (merge_faces):
01103c44
PE
1342 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1343 Don't assume EMACS_INT fits in int.
9910e595 1344
2638320e
PE
1345 * character.h (CHAR_VALID_P): Remove unused parameter.
1346 * fontset.c, lisp.h, xdisp.c: All uses changed.
1347
045eb8d9
PE
1348 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1349
c1f134b5
PE
1350 * fns.c (concat): Minor tuning based on overflow analysis.
1351 This doesn't fix any bugs. Use int to hold character, instead
1352 of constantly refetching from Emacs object. Use XFASTINT, not
1353 XINT, for value known to be a character. Don't bother comparing
1354 a single byte to 0400, as it's always less.
1355
395fcb93 1356 * floatfns.c (Fexpt):
327eeec8
PE
1357 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1358
abbd3d23
PE
1359 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1360 for characters.
1361
684a03ef
PE
1362 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1363
0fed43f3
PE
1364 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1365 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1366 incorrectly succeed when S was a string, because 4294967386 was
1367 truncated before it was used.
1368
8fd02eb7
PE
1369 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1370 Otherwise, an out-of-range integer could cause undefined behavior
1371 on a 64-bit host.
1372
f8c86b69
PE
1373 * composite.c: Use int, not EMACS_INT, for characters.
1374 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1375 EMACS_INT, for values that are known to be in character range.
1376 This doesn't fix any bugs but is the usual style inside Emacs and
1377 may generate better code on 32-bit machines.
1378
34206dd2
PE
1379 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1380 This is for reasons similar to the recent CHAR_STRING fix.
1381 * charset.c (Fencode_char): Check that character arg is actually
1382 a character. Pass an int to ENCODE_CHAR.
1383 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1384 wider than 'int', as a compile-time check to prevent future regressions
1385 in this area.
1386
c5958d4c 1387 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1388
1389 Make sure a 64-bit char is never passed to CHAR_STRING.
1390 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1391 by silently ignoring the top 32 bits, allowing some values
1392 that were far too large to be valid characters.
1393 * character.h: Include <verify.h>.
1394 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1395 arguments are no wider than unsigned, as a compile-time check
1396 to prevent future regressions in this area.
1397 * data.c (Faset):
01103c44 1398 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1399 (Fsubst_char_in_region):
1400 * fns.c (concat):
1401 * xdisp.c (decode_mode_spec_coding):
1402 Adjust to CHAR_STRING's new requirement.
1403 * editfns.c (Finsert_char, Fsubst_char_in_region):
1404 * fns.c (concat): Check that character args are actually
1405 characters. Without this test, these functions did the wrong
1406 thing with wildly out-of-range values on 64-bit hosts.
1407
d37ca623
PE
1408 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1409 These casts should not be needed on 32-bit hosts, either.
1410 * keyboard.c (read_char):
1411 * lread.c (Fload): Remove casts to unsigned.
1412
ea204efb
PE
1413 * lisp.h (UNSIGNED_CMP): New macro.
1414 This fixes comparison bugs on 64-bit hosts.
1415 (ASCII_CHAR_P): Use it.
1416 * casefiddle.c (casify_object):
01103c44 1417 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1418 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1419 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1420 * dispextern.h (FACE_FROM_ID):
1421 * keyboard.c (read_char): Use UNSIGNED_CMP.
1422
41cb286c
PE
1423 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1424 not to EMACS_INT, to avoid GCC warning.
1425
4a1b9832
PE
1426 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1427
55daad71
PE
1428 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1429 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1430 isn't needed on 32-bit machines.
8f95c75c 1431
01103c44
PE
1432 * buffer.c (Fgenerate_new_buffer_name):
1433 Use EMACS_INT for count, not int.
0ceccced 1434 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1435
1436 * data.c (Qcompiled_function): Now static.
1437
c6f072e7
PE
1438 * window.c (window_body_lines): Now static.
1439
20ce5912
PE
1440 * image.c (gif_load): Rename local to avoid shadowing.
1441
9c4c5f81
PE
1442 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1443 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1444 * alloc.c (make_save_value): Integer argument is now of type
1445 ptrdiff_t, not int.
1446 (mark_object): Use ptrdiff_t, not int.
1447 * lisp.h (pD): New macro.
1448 * print.c (print_object): Use it.
1449
c0c5c8ae
PE
1450 * alloc.c: Use EMACS_INT, not int, to count objects.
1451 (total_conses, total_markers, total_symbols, total_vector_size)
1452 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1453 (total_free_floats, total_floats, total_free_intervals)
1454 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1455 Now EMACS_INT, not int. All uses changed.
1456 (Fgarbage_collect): Compute overall total using a double, so that
1457 integer overflow is less likely to be a problem. Check for overflow
1458 when converting back to an integer.
5a25e253
PE
1459 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1460 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1461 These were 'int' variables that could overflow on 64-bit hosts;
1462 they were never used, so remove them instead of repairing them.
211a0b2a 1463 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1464 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1465 Previously, this ceilinged at INT_MAX, but that doesn't work on
1466 64-bit machines.
e46bb31a 1467 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1468
c78baabf 1469 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1470 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1471 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1472 when a (possibly-narrower) signed value would do just as well.
1473 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1474
c9d624c6
PE
1475 * alloc.c: Catch some string size overflows that we were missing.
1476 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1477 for convenience in STRING_BYTES_MAX.
1478 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1479 The definition here is exact; the one in lisp.h was approximate.
1480 (allocate_string_data): Check for string overflow. This catches
1481 some instances we weren't catching before. Also, it catches
1482 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1483 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1484 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1485
c9d624c6
PE
1486 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1487 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1488 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1489
353032ce
PE
1490 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1491
2bccce07
PE
1492 * alloc.c (Fmake_string): Check for out-of-range init.
1493
0ac30604
SM
14942011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1495
1496 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1497
c195f2de
JD
14982011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1499
1500 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1501 xg_get_default_scrollbar_width.
1502
1503 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1504 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1505 (style_changed_cb): Call update_theme_scrollbar_width and call
1506 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1507 all frames (Bug#8505).
1508 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1509 Call gtk_window_set_resizable if HAVE_GTK3.
1510 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1511 and height if HAVE_GTK3 (Bug#8505).
1512 (scroll_bar_width_for_theme): New variable.
1513 (update_theme_scrollbar_width): New function.
1514 (xg_get_default_scrollbar_width): Move code to
1515 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1516 (xg_initialize): Call update_theme_scrollbar_width.
1517
1518 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1519
1520 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1521
e10ac9f1
MR
15222011-06-12 Martin Rudalics <rudalics@gmx.at>
1523
1524 * frame.c (make_frame): Call other_buffer_safely instead of
1525 other_buffer.
1526
1527 * window.c (temp_output_buffer_show): Call display_buffer with
1528 second argument Vtemp_buffer_show_specifiers and reset latter
1529 immediately after the call.
1530 (Vtemp_buffer_show_specifiers): New variable.
1531 (auto_window_vscroll_p, next_screen_context_lines)
1532 (Vscroll_preserve_screen_position): Remove leading asterisks from
1533 doc-strings.
1534
2d3c217e 15352011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1536
7b7f97e8 1537 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1538 * buffer.c (Qclone_number): Remove for now, as it's unused.
1539 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1540 (record_buffer): Remove unused local.
1541 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1542 (set_frame_buffer_list): Remove; unused.
1543 * frame.h (other_visible_frames): Remove decl.
1544 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1545 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1546 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1547 if HAVE_GPM.
1548 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1549 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1550 Define only if HAVE_GPM.
1551 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1552 (update_hints_inhibit): Remove; never set. All uses removed.
1553 * widgetprv.h (emacsFrameClassRec): Remove decl.
1554 * window.c (delete_deletable_window): Now returns void, since it
1555 wasn't returning anything.
1556 (compare_window_configurations): Remove unused locals.
1557 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1558 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1559 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1560 the same widths as pointers. This follows up on the 2011-05-06 patch.
1561 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1562 * xterm.h: Likewise.
1563 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1564
1384b89e
JB
15652011-06-12 Juanma Barranquero <lekktu@gmail.com>
1566
1567 * makefile.w32-in: Update dependencies.
1568 (LISP_H): Add lib/intprops.h.
1569
1100a63c
CY
15702011-06-11 Chong Yidong <cyd@stupidchicken.com>
1571
1572 * image.c (gif_load): Add animation frame delay to the metadata.
1573 (syms_of_image): Use DEFSYM. New symbol `delay'.
1574
6198ccd0
MR
15752011-06-11 Martin Rudalics <rudalics@gmx.at>
1576
1577 * window.c (delete_deletable_window): Re-add.
1578 (Fset_window_configuration): Rewrite to handle dead buffers and
1579 consequently deletable windows.
1580 (window_tree, Fwindow_tree): Remove. Supply functionality in
1581 window.el.
1582 (compare_window_configurations): Simplify code.
1583
b6e3633c
AS
15842011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1585
1ab0dee5
AS
1586 * image.c (imagemagick_load_image): Fix type mismatch.
1587 (Fimagemagick_types): Likewise.
1588
b6e3633c
AS
1589 * window.h (replace_buffer_in_windows): Declare.
1590
9397e56f
MR
15912011-06-11 Martin Rudalics <rudalics@gmx.at>
1592
1593 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1594 Qclone_number. Remove external declaration of Qdelete_window.
1595 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1596 code.
1597 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1598 Qbuffer_list_update_hook if allowed.
1599 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1600 buffer list implementation.
1601 (other_buffer_safely): New function.
1602 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1603 calls to replace_buffer_in_windows and
1604 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1605 if allowed.
1606 (record_buffer): Inhibit quitting and rewrite using quittable
1607 functions. Run Qbuffer_list_update_hook if allowed.
1608 (Frecord_buffer, Funrecord_buffer): New functions.
1609 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1610 switch-to-buffer to window.el.
1611 (bury-buffer): Move to window.el.
1612 (Vbuffer_list_update_hook): New variable.
1613
1614 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1615 section.
1616
1617 * window.h (resize_frame_windows): Move up in code.
1618 (Fwindow_frame): Remove EXFUN.
1619 (replace_buffer_in_all_windows): Remove prototype.
1620 (replace_buffer_in_windows_safely): Add prototype.
1621
1622 * window.c: Declare Qdelete_window static again. Move down
1623 declaration of select_count.
1624 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1625 (Fother_window): Move to window.el.
1626 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1627 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1628 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1629 window.el.
1630 (replace_buffer_in_windows): Implement by calling
1631 Qreplace_buffer_in_windows.
1632 (replace_buffer_in_all_windows): Remove with some functionality
1633 moved into replace_buffer_in_windows_safely.
1634 (replace_buffer_in_windows_safely): New function.
1635 (select_window_norecord, select_frame_norecord): Move in front
1636 of run_window_configuration_change_hook. Remove now obsolete
1637 declarations.
1638 (Fset_window_buffer): Rewrite doc-string. Call
1639 Qrecord_window_buffer.
1640 (keys_of_window): Move binding for other-window to window.el.
1641
b50691aa
CY
16422011-06-11 Chong Yidong <cyd@stupidchicken.com>
1643
1644 * dispextern.h (struct image): Replace data member, whose int_val
1645 and ptr_val fields were not used by anything, with a single
1646 lisp_val object.
1647
1648 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1649 (gif_clear_image, gif_load, imagemagick_load_image)
1650 (gs_clear_image, gs_load): Callers changed.
1651
3f754b86
PE
16522011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1653
cca69397
PE
1654 * buffer.h: Include <time.h>, for time_t.
1655 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1656
109e28d0
PE
1657 Fix minor problems found by static checking.
1658
60737f02
PE
1659 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1660
4b66faf3
PE
1661 Make identifiers static if they are not used in other modules.
1662 * data.c (Qcompiled_function, Qframe, Qvector):
1663 * image.c (QimageMagick, Qsvg):
1664 * minibuf.c (Qmetadata):
1665 * window.c (resize_window_check, resize_root_window): Now static.
1666 * window.h (resize_window_check, resize_root_window): Remove decls.
1667
109e28d0
PE
1668 * window.c (window_deletion_count, delete_deletable_window):
1669 Remove; unused.
46a4ce9e
PE
1670 (window_body_lines): Now static.
1671 (Fdelete_other_windows_internal): Mark vars as initialized.
1672 Make sure 'resize_failed' is initialized.
1673 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1674 (resize_window_apply): Remove unused local.
1675 * window.h (delete_deletable_window): Remove decl.
1676
109e28d0 1677 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1678 (imagemagick_load_image): Fix pointer signedness problem by changing
1679 last arg from unsigned char * to char *. All uses changed.
1680 Also, fix a local for similar reasons.
1681 Remove unused locals. Remove locals to avoid shadowing.
1682 (fn_rsvg_handle_free): Remove; unused.
1683 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1684 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1685
3f754b86
PE
1686 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1687
2547adb1
CY
16882011-06-10 Chong Yidong <cyd@stupidchicken.com>
1689
1690 * image.c (gif_load): Fix omitted cast error introduced by
1691 2011-06-06 change.
1692
2c8e37d4
MR
16932011-06-10 Martin Rudalics <rudalics@gmx.at>
1694
1695 * window.h (resize_proportionally, orig_total_lines)
1696 (orig_top_line): Remove from window structure.
1697 (set_window_height, set_window_width, change_window_heights)
1698 (Fdelete_window): Remove prototypes.
1699 (resize_frame_windows): Remove duplicate declaration.
1700
440a42e3
EZ
17012011-06-10 Eli Zaretskii <eliz@gnu.org>
1702
1703 * window.h (resize_frame_windows, resize_window_check)
1704 (delete_deletable_window, resize_root_window)
1705 (resize_frame_windows): Declare prototypes.
1706
1707 * window.c (resize_window_apply): Make definition be "static" to
1708 match the prototype.
1709
562dd5e9
MR
17102011-06-10 Martin Rudalics <rudalics@gmx.at>
1711
1712 * window.c: Remove declarations of Qwindow_size_fixed,
1713 window_min_size_1, window_min_size_2, window_min_size,
1714 size_window, window_fixed_size_p, enlarge_window, delete_window.
1715 Remove static from declaration of Qdelete_window, it's
1716 temporarily needed by Fbury_buffer.
1717 (replace_window): Don't assign orig_top_line and
1718 orig_total_lines.
1719 (Fdelete_window, delete_window): Remove. Window deletion is
1720 handled by window.el.
1721 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1722 Fdelete_window calls with calls to Qdelete_window.
1723 (Fdelete_other_windows): Remove. Deleting other windows is
1724 handled by window.el.
1725 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1726 handled in window.el.
1727 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1728 Window minimum sizes are handled in window.el.
1729 (shrink_windows, size_window, set_window_height)
1730 (set_window_width, change_window_heights, window_height)
1731 (window_width, CURBEG, CURSIZE, enlarge_window)
1732 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1733 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1734 handled in window.el.
1735 (make_dummy_parent): Rename to make_parent_window and give it a
1736 second argument horflag.
1737 (make_window): Don't set resize_proportionally any more.
1738 (Fsplit_window): Remove. Windows are split in window.el.
1739 (save_restore_action, save_restore_orig_size)
1740 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1741 Resize mini windows in window.el.
1742 (grow_mini_window, shrink_mini_window): Implement by calling
1743 Qresize_root_window_vertically, resize_window_check and
1744 resize_window_apply.
1745 (saved_window, Fset_window_configuration, save_window_save): Do
1746 not handle orig_top_line, orig_total_lines, and
1747 resize_proportionally.
1748 (window_min_height, window_min_width): Move to window.el.
1749 (keys_of_window): Move bindings for delete-other-windows,
1750 split-window, delete-window and enlarge-window to window.el.
1751
1752 * buffer.c: Temporarily extern Qdelete_window.
1753 (Fbury_buffer): Temporarily call Qdelete_window instead of
1754 Fdelete_window (Fbury_buffer will move to window.el soon).
1755
1756 * frame.c (set_menu_bar_lines_1): Remove code handling
1757 orig_top_line and orig_total_lines.
1758
1759 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1760 set_window_height but set heights directly.
1761 (change_frame_size_1): Use resize_frame_windows.
1762
1763 * xdisp.c (init_xdisp): Don't use set_window_height but set
1764 heights directly.
1765
1766 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1767 resize_frame_windows instead of change_window_heights and run
1768 run_window_configuration_change_hook.
1769
1770 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1771 instead of change_window_heights and run
1772 run_window_configuration_change_hook.
1773
1a13852e
MR
17742011-06-09 Martin Rudalics <rudalics@gmx.at>
1775
1776 * window.c (replace_window): Rename second argument REPLACEMENT to
1777 NEW. New third argument SETFLAG. Rewrite.
1778 (delete_window, make_dummy_parent): Call replace_window with
1779 third argument 1.
1780 (window_list_1): Move down in code.
1781 (run_window_configuration_change_hook): Move set_buffer part
1782 before select_frame_norecord part in order to unwind correctly.
1783 Rename count1 to count.
1784 (recombine_windows, delete_deletable_window, resize_root_window)
1785 (Fdelete_other_windows_internal)
1786 (Frun_window_configuration_change_hook, make_parent_window)
1787 (resize_window_check, resize_window_apply, Fresize_window_apply)
1788 (resize_frame_windows, Fsplit_window_internal)
1789 (Fdelete_window_internal, Fresize_mini_window_internal): New
1790 functions.
1791 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1792
f3d1777e
MR
17932011-06-08 Martin Rudalics <rudalics@gmx.at>
1794
496e208e
MR
1795 * window.h (window): Add some new members to window structure -
1796 normal_lines, normal_cols, new_total, new_normal, clone_number,
1797 splits, nest, prev_buffers, next_buffers.
1798 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1799 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1800
f3d1777e
MR
1801 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1802 Remove.
496e208e
MR
1803 (make_dummy_parent): Set new members of windows structure.
1804 (make_window): Move down in code. Handle new members of window
1805 structure.
1806 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1807 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1808 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1809 (Fset_window_prev_buffers, Fwindow_next_buffers)
1810 (Fset_window_next_buffers, Fset_window_clone_number): New
1811 functions.
1812 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1813 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1814 Doc-string fixes.
1815 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1816 Argument WINDOW can be now internal window too.
1817 (Fwindow_use_time): Move up in code.
1818 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1819 Rewrite doc-string.
1820 (Fset_window_configuration, saved_window)
1821 (Fcurrent_window_configuration, save_window_save): Handle new
1822 members of window structure.
b9e809c2
MR
1823 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1824 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1825 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1826 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1827 Qget_mru_window, Qresize_root_window,
1828 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1829 Qauto_buffer_name; staticpro them.
f3d1777e 1830
abde8f8c
MR
18312011-06-07 Martin Rudalics <rudalics@gmx.at>
1832
1833 * window.c (Fwindow_total_size, Fwindow_left_column)
1834 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1835 (Fwindow_list_1): New functions.
1836 (window_box_text_cols): Replace with window_body_cols.
1837 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1838 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1839 (delete_window, Fset_window_configuration): Call
1840 delete_all_subwindows with window as argument.
1841 (delete_all_subwindows): Take a window as argument and not a
1842 structure. Rewrite.
190b47e6
MR
1843 (window_loop): Remove handling of GET_LRU_WINDOW and
1844 GET_LARGEST_WINDOW.
1845 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1846
1847 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1848 window_box_text_cols. delete_all_subwindows now takes a
1849 Lisp_Object as argument.
abde8f8c
MR
1850
1851 * indent.c (compute_motion, Fcompute_motion): Use
1852 window_body_cols instead of window_box_text_cols.
1853
fa8a67e6
MR
1854 * frame.c (delete_frame): Call delete_all_subwindows with root
1855 window as argument.
1856
a54e3482
DC
18572011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1858
1859 * fns.c (Fputhash): Document return value.
1860
60002bf5
CY
18612011-06-06 Chong Yidong <cyd@stupidchicken.com>
1862
1863 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1864
0c671da6 18652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1866
b862a52a 1867 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1868
be44ca6c
PE
1869 Check for overflow when converting integer to cons and back.
1870 * charset.c (Fdefine_charset_internal, Fdecode_char):
1871 Use cons_to_unsigned to catch overflow.
1872 (Fencode_char): Use INTEGER_TO_CONS.
1873 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1874 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1875 * data.c (long_to_cons, cons_to_long): Remove.
1876 (cons_to_unsigned, cons_to_signed): New functions.
1877 These signal an error for invalid or out-of-range values.
1878 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1879 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1880 * font.c (Ffont_variation_glyphs):
1881 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1882 * lisp.h: Include <intprops.h>.
1883 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1884 (cons_to_signed, cons_to_unsigned): New decls.
1885 (long_to_cons, cons_to_long): Remove decls.
1886 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1887 (Fprimitive_undo): Use CONS_TO_INTEGER.
1888 * xfns.c (Fx_window_property): Likewise.
1889 * xselect.c: Include <limits.h>.
1890 (x_own_selection, selection_data_to_lisp_data):
1891 Use INTEGER_TO_CONS.
1892 (x_handle_selection_request, x_handle_selection_clear)
1893 (x_get_foreign_selection, Fx_disown_selection_internal)
1894 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1895 (lisp_data_to_selection_data): Use cons_to_unsigned.
1896 (x_fill_property_data): Use cons_to_signed.
1897 Report values out of range.
1898
d1f3d2af
PE
1899 Check for buffer and string overflow more precisely.
1900 * buffer.h (BUF_BYTES_MAX): New macro.
1901 * lisp.h (STRING_BYTES_MAX): New macro.
1902 * alloc.c (Fmake_string):
1903 * character.c (string_escape_byte8):
1904 * coding.c (coding_alloc_by_realloc):
1905 * doprnt.c (doprnt):
1906 * editfns.c (Fformat):
1907 * eval.c (verror):
1908 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1909 since they may not be the same number.
1910 * editfns.c (Finsert_char):
1911 * fileio.c (Finsert_file_contents):
1912 Likewise for BUF_BYTES_MAX.
1913
dd52fcea
PE
1914 * image.c: Use ptrdiff_t, not int, for sizes.
1915 (slurp_file): Switch from int to ptrdiff_t.
1916 All uses changed.
1917 (slurp_file): Check that file size fits in both size_t (for
1918 malloc) and ptrdiff_t (for sanity and safety).
1919
7f9bbdbb
PE
1920 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1921 if b->modtime has its maximal value.
1922
dfe18f82
PE
1923 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1924
84acfcf0
PE
1925 Don't assume time_t can fit into int.
1926 * buffer.h (struct buffer.modtime): Now time_t, not int.
1927 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1928 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1929
ccd9a01a
PE
1930 Minor fixes for signed vs unsigned integers.
1931 * character.h (MAYBE_UNIFY_CHAR):
1932 * charset.c (maybe_unify_char):
1933 * keyboard.c (read_char, reorder_modifiers):
1934 XINT -> XFASTINT, since the integer must be nonnegative.
1935 * ftfont.c (ftfont_spec_pattern):
1936 * keymap.c (access_keymap, silly_event_symbol_error):
1937 XUINT -> XFASTINT, since the integer must be nonnegative.
1938 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1939 since it makes no difference and we prefer signed.
1940 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1941 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1942 nonnegative.
1943
d6d100dd
SM
19442011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1945
1946 * window.h (Fwindow_frame): Declare.
1947
2b6148e4
PE
19482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1949
1950 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1951 (SPARE_MEMORY): Always define.
1952 (LARGE_REQUEST): Remove.
1953 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1954
f230ecc9
MR
19552011-06-06 Martin Rudalics <rudalics@gmx.at>
1956
727e958e
MR
1957 * lisp.h: Move EXFUNS for Fframe_root_window,
1958 Fframe_first_window and Fset_frame_selected_window to window.h.
1959
1960 * window.h: Move EXFUNS for Fframe_root_window,
1961 Fframe_first_window and Fset_frame_selected_window here from
1962 lisp.h.
1963
1964 * frame.c (Fwindow_frame, Fframe_first_window)
1965 (Fframe_root_window, Fframe_selected_window)
1966 (Fset_frame_selected_window): Move to window.c.
1967 (Factive_minibuffer_window): Move to minibuf.c.
1968 (Fother_visible_frames_p): New function.
1969
1970 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1971
f230ecc9
MR
1972 * window.c (decode_window, decode_any_window): Move up in code.
1973 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1974 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1975 (Fwindow_buffer): Move up and rewrite doc-string.
1976 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1977 (Fwindow_prev): New functions.
727e958e
MR
1978 (Fwindow_frame): Move here from frame.c. Accept any window as
1979 argument.
1980 (Fframe_root_window, Fframe_first_window)
1981 (Fframe_selected_window): Move here from frame.c. Accept frame
1982 or arbitrary window as argument. Update doc-strings.
1983 (Fminibuffer_window): Move up in code.
1984 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1985 (Fset_frame_selected_window): Move here from frame.c.
1986 Marginal rewrite.
727e958e
MR
1987 (Fselected_window, select_window, Fselect_window): Move up in
1988 code. Minor doc-string fixes.
f230ecc9 1989
4d09bcf6
PE
19902011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1991
1992 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1993 Do not assume that spare memory exists; that assumption is valid
1994 only if SYSTEM_MALLOC.
1995 (LARGE_REQUEST): New macro, so that the issue of large requests
1996 is separated from the issue of spare memory.
1997
810928a2
AS
19982011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1999
172418ad
AS
2000 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2001 format. (Bug#8806)
2002
43f862f7
AS
2003 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2004
810928a2
AS
2005 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2006 before statements.
2007
a059fe24
JD
20082011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2009
2010 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2011
2012 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2013
2014 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2015 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2016
989bf368
JB
20172011-06-05 Juanma Barranquero <lekktu@gmail.com>
2018
2019 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2020
4b80f674
CY
20212011-06-04 Chong Yidong <cyd@stupidchicken.com>
2022
2023 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2024 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2025 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2026 New error handlers.
4b80f674
CY
2027 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2028 Obey Vx_select_enable_clipboard_manager. Catch errors in
2029 x_clipboard_manager_save (Bug#8779).
2030 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2031 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2032
99a33b77 20332011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2034
2035 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2036
99a33b77 20372011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2038
2039 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2040 in the current matrix if keep_current_p is non-zero.
2041
8264569d
EZ
20422011-06-04 Eli Zaretskii <eliz@gnu.org>
2043
2044 * bidi.c (bidi_level_of_next_char): Fix last change.
2045
57f97249
EZ
20462011-06-03 Eli Zaretskii <eliz@gnu.org>
2047
fec2107c 2048 Support bidi reordering of text covered by display properties.
57f97249 2049
fec2107c
EZ
2050 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2051 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2052 (bidi_cache_search, bidi_cache_iterator_state)
2053 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2054 (bidi_level_of_next_char, bidi_move_to_visually_next):
2055 Support character positions inside a run of characters covered by a
fec2107c
EZ
2056 display string.
2057 (bidi_paragraph_init, bidi_resolve_explicit_1)
2058 (bidi_level_of_next_char): Call bidi_fetch_char and
2059 bidi_fetch_char_advance instead of FETCH_CHAR and
2060 FETCH_CHAR_ADVANCE.
2061 (bidi_init_it): Initialize new members.
2062 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2063 definitions.
2064 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2065 instead of using explicit *_CHAR codes.
d6d100dd
SM
2066 (bidi_resolve_explicit, bidi_resolve_weak):
2067 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2068 bidirectional text is supported only in multibyte buffers.
2069 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2070 it to initialize the frame_window_p member of struct bidi_it.
2071 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2072 (bidi_resolve_explicit, bidi_resolve_weak)
2073 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2074 bidi_it->nchars is non-positive.
2075 (bidi_level_of_next_char): Don't try to lookup the cache for the
2076 next/previous character if nothing is cached there yet, or if we
2077 were just reseat()'ed to a new position.
c40e2fb2 2078
0e14fe90
EZ
2079 * xdisp.c (set_cursor_from_row): Set start and stop points
2080 according to the row's direction when priming the loop that looks
2081 for the glyph on which to display cursor.
2082 (single_display_spec_intangible_p): Function deleted.
2083 (display_prop_intangible_p): Reimplement to call
2084 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2085 Accept 3 additional arguments needed by handle_display_spec.
2086 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2087 values: lists, `(when COND...)' forms, etc.
2088 (single_display_spec_string_p): Support property values that are
2089 lists with the argument STRING its top-level element.
2090 (display_prop_string_p): Fix the condition for processing a
2091 property that is a list to be consistent with handle_display_spec.
fec2107c 2092 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2093 last portion of handle_display_prop.
2094 (compute_display_string_pos): Accept additional argument
2095 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2096 value of a `display' property is a "replacing spec".
2097 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2098 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2099 the display property, but just return a value indicating whether
2100 the display property will replace the characters it covers.
2101 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2102 frame_window_p members of struct bidi_it.
d6d100dd
SM
2103 (compute_display_string_pos, compute_display_string_end):
2104 New functions.
fec2107c
EZ
2105 (push_it): Accept second argument POSITION, where pop_it should
2106 jump to continue iteration.
2107 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2108
fec2107c
EZ
2109 * keyboard.c (adjust_point_for_property): Adjust the call to
2110 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2111
2112 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2113 (bidi_init_it): Update prototypes.
2114 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2115 (compute_display_string_pos, compute_display_string_end):
2116 Declare prototypes.
fec2107c
EZ
2117 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2118 EMACS_INT.
fc6f18ce 2119
40087514 21202011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2121
57f53182
PE
2122 Malloc failure behavior now depends on size of allocation.
2123 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2124 * lisp.h: Change signatures accordingly.
2125 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2126 All callers changed. (Bug#8762)
2127
2128 * gnutls.c: Use Emacs's memory allocators.
2129 Without this change, the gnutls library would invoke malloc etc.
2130 directly, which causes problems on non-SYNC_INPUT hosts, and which
2131 runs afoul of improving memory_full behavior. (Bug#8761)
2132 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2133 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2134 xfree instead of the default malloc, realloc, free.
2135 (Fgnutls_boot): No need to check for memory allocation failure,
2136 since xmalloc does that for us.
2137
ac32cd99 2138 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2139 * category.c (hash_get_category_set):
2140 * ccl.c (ccl_driver):
2141 * charset.c (Fdefine_charset_internal):
2142 * charset.h (struct charset.hash_index):
2143 * composite.c (get_composition_id, gstring_lookup_cache)
2144 (composition_gstring_put_cache):
2145 * composite.h (struct composition.hash_index):
2146 * dispextern.h (struct image.hash):
2147 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2148 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2149 (hashfn_equal, hashfn_user_defined, make_hash_table)
2150 (maybe_resize_hash_table, hash_lookup, hash_put)
2151 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2152 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2153 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2154 * image.c (make_image, search_image_cache, lookup_image)
2155 (xpm_put_color_table_h):
2156 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2157 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2158 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2159 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2160 * alloc.c (allocate_vectorlike):
2161 Check for overflow in vector size calculations.
2162 * ccl.c (ccl_driver):
2163 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2164 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2165 need to be updated by these changes.
40087514
PE
2166 * fns.c (make_hash_table, maybe_resize_hash_table):
2167 Check for integer overflow with large hash tables.
0de4bb68
PE
2168 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2169 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2170 (SXHASH_REDUCE): New macro.
2171 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2172 Use it instead of discarding useful hash info with large hash values.
2173 (sxhash_float): New function.
2174 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2175 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2176 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2177 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2178 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2179 Adjust signatures to match updated version of code.
2180 (consing_since_gc): Now EMACS_INT, since a single hash table can
2181 use more than INT_MAX bytes.
2182
698d32e2
DN
21832011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2184
2185 Make it possible to build with GCC-4.6+ -O2 -flto.
2186
2187 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2188
fd6fa53f
SM
21892011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2190
2191 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2192 Call minibuffer-inactive-mode.
2193
864db017
JB
21942011-05-31 Juanma Barranquero <lekktu@gmail.com>
2195
2196 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2197 Update dependencies.
2198
2ad0baf4
DN
21992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2200
2201 * data.c (init_data): Remove code for UTS, this system is not
2202 supported anymore.
2203
4fcc2638
DN
22042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2205
2206 Don't force ./temacs to start in terminal mode.
2207
2208 * frame.c (make_initial_frame): Initialize faces in all cases, not
2209 only when CANNOT_DUMP is defined.
2210 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2211
c56e0fd5
DN
22122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2213
2214 * dispnew.c (add_window_display_history): Use const for the string
2215 pointer. Remove declaration, not needed.
2216
333d54da 22172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2218
55d4c1b2 2219 Use 'inline', not 'INLINE'.
333d54da 2220 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2221 * alloc.c, fontset.c (INLINE): Remove.
2222 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2223 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2224 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2225 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2226 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2227
738db178
DN
22282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2229
2230 Make it possible to run ./temacs.
2231
2232 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2233 syms_of_callproc does the same thing. Remove test for
2234 "initialized", do it in the caller.
2235 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2236
620c53a6
SM
22372011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2238
2239 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2240 (read_minibuf): Use get_minibuffer.
2241 (syms_of_minibuf): Use DEFSYM.
2242 (Qmetadata): New var.
2243 * data.c (Qbuffer): Don't make it static.
2244 (syms_of_data): Use DEFSYM.
2245
e003a292
PE
22462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2247
2248 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2249 (CCL_CODE_MIN): New macro.
2250
ed008a6d
PE
22512011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2252
3687c2ef
PE
2253 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2254
ed008a6d
PE
2255 * eval.c (Qdebug): Now static.
2256 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2257 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2258 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2259
d66c4c7c
CY
22602011-05-29 Chong Yidong <cyd@stupidchicken.com>
2261
2262 * image.c: Various fixes to ImageMagick code comments.
2263 (Fimagemagick_types): Doc fix.
2264
5fbc2025
PE
22652011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2266
0196f88a
PE
2267 Minor fixes prompted by GCC 4.6.0 warnings.
2268
2269 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2270
5fbc2025
PE
2271 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2272 (x_clipboard_manager_save_all): Move extern decl to ...
2273 * xterm.h: ... here, so that it can be checked for consistency.
2274
1dd3c2d9
CY
22752011-05-29 Chong Yidong <cyd@stupidchicken.com>
2276
2277 * xselect.c (x_clipboard_manager_save_frame)
2278 (x_clipboard_manager_save_all): New functions.
2279 (Fx_clipboard_manager_save): Lisp function deleted.
2280
2281 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2282 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2283
2284 * xterm.h: Update prototype.
2285
5ba6571d
WX
22862011-05-28 William Xu <william.xwl@gmail.com>
2287
2288 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2289 exiting (Bug#8239).
2290
3eaff834
JM
22912011-05-28 Jim Meyering <meyering@redhat.com>
2292
e1900994 2293 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2294 * fns.c (to_uchar): Define.
2295 (crypto_hash_function): Use it to convert some newly-signed
2296 variables to unsigned, to avoid sign-extension bugs. For example,
2297 without this change, (md5 "truc") would evaluate to
2298 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2299 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2300 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2301
0f6990a7
PE
23022011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2303
2304 Integer overflow fixes.
c8a9ca5a 2305
08686060
PE
2306 * dbusbind.c: Serial number integer overflow fixes.
2307 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2308 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2309 to hold a serial number that is too large for a fixnum.
2310 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2311 Check for serial numbers out of range. Decode any serial number
59568bf0 2312 that was so large that it became a float. (Bug#8722)
08686060 2313
2d1fc3c7
PE
2314 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2315 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2316 Use XFASTINT rather than XUINT when numbers are nonnegative.
2317 (xd_append_arg, Fdbus_method_return_internal):
2318 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2319 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2320 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2321 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2322 (Bug#8722)
2d1fc3c7 2323
c8a9ca5a
PE
2324 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2325
519e1d69
PE
2326 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2327
30569699
PE
2328 ccl: add integer overflow checks
2329 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2330 (IN_INT_RANGE): New macros.
2331 (ccl_driver): Use them to check for integer overflow when
2332 decoding a CCL program. Many of the new checks are whether XINT (x)
2333 fits in int; it doesn't always, on 64-bit hosts. The new version
2334 doesn't catch all possible integer overflows, but it's an
847044ea 2335 improvement. (Bug#8719)
30569699 2336
c11285dc
PE
2337 * alloc.c (make_event_array): Use XINT, not XUINT.
2338 There's no need for unsigned here.
2339
fdccd48e
PE
2340 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2341 This follows up to the 2011-05-06 change that substituted uintptr_t
2342 for EMACS_INT. This case wasn't caught back then.
2343
37910ab2
PE
2344 Rework Fformat to avoid integer overflow issues.
2345 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2346 now (part of C89). Include <verify.h>.
2347 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2348 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2349 (Fformat): Avoid the prepass trying to compute sizes; it was only
2350 approximate and thus did not catch overflow reliably. Instead, walk
2351 through the format just once, formatting and computing sizes as we go,
2352 checking for integer overflow at every step, and allocating a larger
2353 buffer as needed. Keep track separately whether the format is
2354 multibyte. Keep only the most-recently calculated precision, rather
2355 than them all. Record whether each argument has been converted to
2356 string. Use EMACS_INT, not int, for byte and char and arg counts.
2357 Support field widths and precisions larger than INT_MAX. Avoid
2358 sprintf's undefined behavior with conversion specifications such as %#d
2359 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2360 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2361 formatting out-of-range floating point numbers with int
9173deec 2362 formats. (Bug#8668)
37910ab2 2363
2e6578fb
PE
2364 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2365
0ae6bdee
PE
2366 * data.c: Avoid integer truncation in expressions involving floats.
2367 * data.c: Include <intprops.h>.
2368 (arith_driver): When there's an integer overflow in an expression
2369 involving floating point, convert the integers to floating point
2370 so that the resulting value does not suffer from catastrophic
2371 integer truncation. For example, on a 64-bit host (* 4
2372 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2373 Do not rely on undefined behavior after integer overflow.
2374
de883a70
PE
2375 merge count_size_as_multibyte, parse_str_to_multibyte
2376 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2377 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2378 Check for integer overflow.
2379 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2380 since it's now a duplicate of the other. This is more of
2381 a character than a buffer op, so better that it's in character.c.
2382 * fns.c, print.c: Adjust to above changes.
2383
2ff916cb
PE
23842011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2385
2386 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2387
f1b54466
PE
23882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2389
fb1ac845
PE
2390 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2391 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2392 (x_clipboard_manager_save): Now static.
2393 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2394
f1b54466
PE
2395 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2396 (crypto_hash_function): Now static.
2397 Fix pointer signedness problems. Avoid unnecessary initializations.
2398
a9f737ee
CY
23992011-05-27 Chong Yidong <cyd@stupidchicken.com>
2400
2401 * termhooks.h (Vselection_alist): Make it terminal-local.
2402
2403 * terminal.c (create_terminal): Initialize it.
2404
2405 * xselect.c: Support for clipboard managers.
2406 (Vselection_alist): Move to termhooks.h as terminal-local var.
2407 (LOCAL_SELECTION): New macro.
2408 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2409 (symbol_to_x_atom): Remove gratuitous arg.
2410 (x_handle_selection_request, lisp_data_to_selection_data)
2411 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2412 (x_own_selection, x_get_local_selection, x_convert_selection):
2413 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2414 (some_frame_on_display): Delete unused function.
2415 (Fx_own_selection_internal, Fx_get_selection_internal)
2416 (Fx_disown_selection_internal, Fx_selection_owner_p)
2417 (Fx_selection_exists_p): New optional frame arg.
2418 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2419 (x_handle_selection_clear): Don't treat other terminals with the
2420 same keyboard specially. Use the terminal-local Vselection_alist.
2421 (x_clear_frame_selections): Use Frun_hook_with_args.
2422
2423 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2424
2425 * xterm.h: Add support for those atoms.
2426
e067f0c1
CY
24272011-05-26 Chong Yidong <cyd@stupidchicken.com>
2428
2429 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2430 (converted_selections, conversion_fail_tag): New global variables.
2431 (x_selection_request_lisp_error): Free the above.
2432 (x_get_local_selection): Remove unnecessary code.
2433 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2434 of converted selections stored in converted_selections.
2435 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2436 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2437 (x_convert_selection): New function.
2438 (x_handle_selection_event): Simplify.
2439 (x_get_foreign_selection): Don't ignore incoming requests while
2440 waiting for an answer; this will fail when we implement
2441 SAVE_TARGETS, and seems unnecessary anyway.
2442 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2443 (Vx_sent_selection_functions): Doc fix.
2444
0f4aebc0
LL
24452011-05-26 Leo Liu <sdl.web@gmail.com>
2446
2447 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2448
e61124cd
YM
24492011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2450
2451 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2452
2453 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2454 for fringe update if it has periodic bitmap.
ac389d0c 2455 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2456 and fringe_bitmap_periodic_p.
2457
2458 * fringe.c (get_fringe_bitmap_data): New function.
2459 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2460 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2461 row. Mark glyph row for fringe update if periodicity changed.
2462
2463 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2464 for fringe update unless it has periodic bitmap.
2465
f16d9837
KH
24662011-05-25 Kenichi Handa <handa@m17n.org>
2467
2468 * xdisp.c (get_next_display_element): Set correct it->face_id for
2469 a static composition.
2470
e1b90ef6
LL
24712011-05-24 Leo Liu <sdl.web@gmail.com>
2472
2473 * deps.mk (fns.o):
2474 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2475
2476 * fns.c (crypto_hash_function, Fsha1): New function.
2477 (Fmd5): Use crypto_hash_function.
2478 (syms_of_fns): Add Ssha1.
2479
7400048f
PE
24802011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2481
2482 * gnutls.c: Remove unused macros.
2483 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2484 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2485 Remove macros that are defined and never used.
2486 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2487
abb71cf4
CY
24882011-05-22 Chong Yidong <cyd@stupidchicken.com>
2489
2490 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2491 (Fx_get_selection_internal): Minor cleanup.
2492 (Fx_own_selection_internal): Rename arguments for consistency with
2493 select.el.
2494
6307db39
PE
24952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2496
2497 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2498
f3d4e0a4
CY
24992011-05-22 Chong Yidong <cyd@stupidchicken.com>
2500
2501 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2502
4d8ade89
YM
25032011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2504
2505 * dispnew.c (scrolling_window): Don't exclude the case that the
2506 last enabled row in the desired matrix touches the bottom boundary.
2507
32078c8d
GM
25082011-05-21 Glenn Morris <rgm@gnu.org>
2509
2510 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2511 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2512 and add some more files.
32078c8d 2513
7285dc67
EZ
25142011-05-20 Eli Zaretskii <eliz@gnu.org>
2515
2516 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2517 report_file_error introduced by the change from 2011-05-07.
2518
89d1bd22
PE
25192011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2520
2521 * systime.h (Time): Define only if emacs is defined.
2522 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2523 where the include path doesn't have X11/X.h by default. See
2524 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2525
e23640bb 25262011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2527
2528 * composite.c (find_automatic_composition): Fix previous change.
2529
b9704ad9
GM
25302011-05-20 Glenn Morris <rgm@gnu.org>
2531
2532 * lisp.mk: New file, split from Makefile.in.
2533 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2534 (shortlisp): Remove.
2535 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2536
4a720484
GM
25372011-05-19 Glenn Morris <rgm@gnu.org>
2538
2539 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2540 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2541 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2542 (lisp): Set the order to that of loadup.el.
2543 (shortlisp): Make it a copy of $lisp.
2544 (SOME_MACHINE_LISP): Remove.
2545 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2546 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2547
a28d4396
KH
25482011-05-18 Kenichi Handa <handa@m17n.org>
2549
2550 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2551 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2552 (find_automatic_composition): Mostly rewrite for efficiency.
2553
a2b1fa8e
JB
25542011-05-18 Juanma Barranquero <lekktu@gmail.com>
2555
2556 * makefile.w32-in: Update dependencies.
2557
8e1f5610
CS
25582011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2559
2560 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2561 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2562
7025ee00 25632011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2564
cdfa6eab
PE
2565 Fix some integer overflow issues, such as string length overflow.
2566
06d6db33
PE
2567 * insdel.c (count_size_as_multibyte): Check for string overflow.
2568
2b4560a8
PE
2569 * character.c (lisp_string_width): Check for string overflow.
2570 Use EMACS_INT, not int, for string indexes and lengths; in
2571 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2572 the resulting string length overflows an EMACS_INT; instead,
2573 report a string overflow if no precision given. When checking for
2574 precision exhaustion, use a check that cannot possibly have
2575 integer overflow. (Bug#8675)
2576 * character.h (lisp_string_width): Adjust to new signature.
2577
cb93f9be
PE
2578 * alloc.c (string_overflow): New function.
2579 (Fmake_string): Use it. This doesn't change behavior, but saves
2580 a few bytes and will simplify future changes.
2581 * character.c (string_escape_byte8): Likewise.
2582 * lisp.h (string_overflow): New decl.
2583
1a1f3366
PE
2584 Fixups, following up to the user-interface timestamp change.
2585 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2586 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2587 * msdos.c (mouse_get_pos): Likewise.
2588 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2589 * w32gui.h (Time): Define by including "systime.h" rather than by
2590 declaring it ourselves. (Bug#8664)
2591
d4e3e4d3
PE
2592 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2593 * image.c (clear_image_cache): Likewise.
2594
f6a24d19
PE
2595 * term.c (term_mouse_position): Don't assume time_t wraparound.
2596
08dc5ae6
PE
2597 Be more systematic about user-interface timestamps.
2598 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2599 and sometimes 'EMACS_UINT', to represent these timestamps.
2600 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2601 This makes the code easier to follow, and makes it easier to catch
2602 integer overflow bugs such as Bug#8664.
2603 * frame.c (Fmouse_position, Fmouse_pixel_position):
2604 Use Time, not unsigned long, for user-interface timestamps.
2605 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2606 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2607 * keyboard.h (last_event_timestamp): Likewise.
2608 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2609 * menu.h (xmenu_show): Likewise.
2610 * term.c (term_mouse_position): Likewise.
2611 * termhooks.h (struct input_event.timestamp): Likewise.
2612 (struct terminal.mouse_position_hook): Likewise.
2613 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2614 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2615 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2616 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2617 what it was before.
2618 * menu.h, termhooks.h: Include "systime.h", for Time.
2619
8e55734a
PE
2620 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2621 Don't assume that the difference between two unsigned long values
2622 can fit into an integer. At this point, we know button_down_time
2623 <= event->timestamp, so the difference must be nonnegative, so
2624 there's no need to cast the result if double-click-time is
2625 nonnegative, as it should be; check that it's nonnegative, just in
2626 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2627 apart (about 25 days). (Bug#8664)
8e55734a 2628
841f1b75 2629 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2630 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2631
3e26f69c
PE
2632 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2633 that always fit in int. Use a sentinel instead of a counter, to
2634 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2635 * frame.h (struct frame): Use int for menu_bar_items_used
2636 instead of EMACS_INT, since it always fits in int.
3e26f69c 2637
5cc152c0
PE
2638 * menu.c (grow_menu_items): Check for int overflow.
2639
d89eb65e
PE
2640 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2641
5235bd3e
PE
2642 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2643 Before, the code was not consistent. These values cannot exceed
2644 2**31 - 1 so there's no need to make them unsigned.
2645 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2646 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2647 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2648 as modifiers.
2649 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2650
bc827e23
PE
2651 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2652 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2653 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2654 presumably because the widths might not match.
2655
78eb494e
PE
2656 * window.c (size_window): Avoid needless test at loop start.
2657
04f2d78b
CB
26582011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2659
2660 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2661
d2fc7e3d 26622011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2663
2664 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2665
d2fc7e3d 26662011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2667
2668 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2669 `width' to `bar_area_x' and `bar_area_width', respectively.
2670 (x_scroll_run): Take account of fringe background extension.
2671
04f2d78b
CB
2672 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2673 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2674 `bar_area_width', respectively.
2675 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2676 background extension.
2677
79b70037
GM
26782011-05-10 Jim Meyering <meyering@redhat.com>
2679
2680 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2681
2f142cc5
JB
26822011-05-10 Juanma Barranquero <lekktu@gmail.com>
2683
2684 * image.c (Finit_image_library): Return t for built-in image types,
2685 like pbm and xbm. (Bug#8640)
2686
57679c86
AS
26872011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2688
2689 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2690
888c9e86
EZ
26912011-05-07 Eli Zaretskii <eliz@gnu.org>
2692
b0512a1d
EZ
2693 * w32console.c (Fset_screen_color): Doc fix.
2694 (Fget_screen_color): New function.
2695 (syms_of_ntterm): Defsubr it.
2696
7285dc67
EZ
2697 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2698 unlink the temporary file if Fcall_process didn't create it in the
2699 first place.
2700 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2701 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2702 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2703 cue to call_process_cleanup not to close that handle.
2704
4d3fcc8e
BK
27052011-05-07 Ben Key <bkey76@gmail.com>
2706
2707 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2708 one of two shell specific rules, either bootstrap-temacs-CMD or
2709 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2710 to the previous implementation of the bootstrap-temacs rule.
2711 The bootstrap-temacs-CMD rule is similar to the previous
2712 implementation of the bootstrap-temacs rule except that it
2713 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2714 variable.
2715
2716 These changes, along with some changes to nt/configure.bat,
2717 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2718 earlier fix to add support for --cflags and --ldflags options
2719 that include quotes so that it works whether make uses cmd or
2720 sh as the shell.
2721
b4289b64
MA
27222011-05-06 Michael Albinus <michael.albinus@gmx.de>
2723
2724 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2725 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2726 is a constant.
2727 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2728 a string. Handle both cases.
2729 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2730 (Fdbus_register_method): Use Qinvalid_function.
2731
af4c0e28
JB
27322011-05-06 Juanma Barranquero <lekktu@gmail.com>
2733
2734 * makefile.w32-in: Update dependencies.
2735 (LISP_H): Add inttypes.h and stdin.h.
2736 (PROCESS_H): Add unistd.h.
2737
c51453d9
EZ
27382011-05-06 Eli Zaretskii <eliz@gnu.org>
2739
2740 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2741 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2742
8ff0ac3c 27432011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2744
4c4b566b
PE
2745 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2746
aab2b9b5
PE
2747 * term.c (vfatal): Remove stray call to va_end.
2748 It's not needed and the C Standard doesn't allow it here anyway.
2749
c378da0b
PE
2750 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2751 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2752
288b08c7
PE
2753 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2754 bytes.
2755
e3601888
PE
2756 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2757
db6c0e74
PE
2758 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2759
dd5963ea
PE
2760 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2761
88c9450f
PE
2762 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2763
2f9442b8
PE
2764 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2765
c032b5f8
PE
2766 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2767 * charset.c (Fdefine_charset_internal): Don't initialize
2768 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2769 32-bit int (Bug#8600).
a108c10b
PE
2770
2771 * lread.c (read_integer): Be more consistent with string-to-number.
2772 Use string_to_number to do the actual conversion; this avoids
2773 rounding errors and fixes some other screwups. Without this fix,
2774 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2775 (digit_to_number): Move earlier, for benefit of read_integer.
2776 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2777 not a digit in any supported base. (Bug#8602)
a108c10b 2778
ad5f9eea
PE
2779 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2780
aec1708a
PE
2781 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2782 to match comment at start of function. This also removes a
2783 GCC warning about overflow in a 32+64-bit port.
2784
47be4ab5
PE
2785 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2786
371cac43
PE
2787 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2788 Reported by Stefan Monnier in
2789 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2790 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2791 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2792
d01a7826
PE
2793 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2794 (EMACS_UINTPTR): Likewise, with uintptr_t.
2795
7fd47d5c
PE
2796 * lisp.h: Prefer 64-bit EMACS_INT if available.
2797 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2798 on 32-bit hosts that have 64-bit int, so that they can access
2799 large files.
122b0c86
PE
2800 However, temporarily disable this change unless the temporary
2801 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2802
8727937b
PE
2803 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2804
8ac068ac
PE
2805 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2806 This removes an assumption that EMACS_INT and long are the same
2807 width as pointers. The assumption is true for Emacs porting targets
2808 now, but we want to make other targets possible.
2809 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2810 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2811 In the rest of the code, change types of integers that hold casted
2812 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2813 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2814 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2815 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2816 No need to cast type when ORing.
2817 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2818 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2819 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2820 assume EMACS_INT is the same width as char *.
2821 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2822 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2823 Remove no-longer-needed casts.
2824 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2825 (xg_tool_bar_help_callback, xg_make_tool_item):
2826 Use EMACS_INTPTR to hold an integer
2827 that will be cast to void *; this can avoid a GCC warning
2828 if EMACS_INT is not the same width as void *.
2829 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2830 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2831 (current_message_1, set_message_1):
2832 Use a local to convert to proper width without a cast.
2833 * xmenu.c (dialog_selection_callback): Likewise.
2834
ede49d71
PE
2835 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2836 Also, don't assume VALBITS / RAND_BITS is less than 5,
2837 and don't rely on undefined behavior when shifting a 1 left into
2838 the sign bit.
2839 * lisp.h (get_random): Change signature to match.
2840
2f30ecd0
PE
2841 * lread.c (hash_string): Use size_t, not int, for hash computation.
2842 Normally we prefer signed values; but hashing is special, because
2843 it's better to use unsigned division on hash table sizes so that
2844 the remainder is nonnegative. Also, size_t is the natural width
2845 for hashing into memory. The previous code used 'int', which doesn't
2846 retain enough info to hash well into very large tables.
2847 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2848
2a866e7b
PE
2849 * dbusbind.c: Don't possibly lose pointer info when converting.
2850 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2851 Use XPNTR rather than XHASH, so that the high-order bits of
2852 the pointer aren't lost when converting through void *.
2853
51639eac
PE
2854 * eval.c (Fautoload): Don't double-shift a pointer.
2855
92394119
PE
2856 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2857
dbdb9a7c
JB
28582011-05-06 Juanma Barranquero <lekktu@gmail.com>
2859
2860 * gnutls.c (DEF_GNUTLS_FN):
2861 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2862
db7a0b4f
AS
28632011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2864
2865 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2866 marker. (Bug#8610)
2867
f7ff1b0f 28682011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2869
2870 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2871 New version that can reserve upto 2GB of heap space.
2872
f7ff1b0f 28732011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2874
2875 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2876
639c109b
TZ
28772011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2878
2879 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2880 `gnutls_certificate_set_x509_key_file'.
2881
d2127135
JB
28822011-05-05 Juanma Barranquero <lekktu@gmail.com>
2883
2884 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2885 Update dependencies.
2886
e968f4f3
JB
28872011-05-04 Juanma Barranquero <lekktu@gmail.com>
2888
2889 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2890 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2891 Remove unused parameter `fildes'.
2892 * process.c (read_process_output, send_process): Don't pass it.
2893
84d358f0
JB
28942011-05-04 Juanma Barranquero <lekktu@gmail.com>
2895
2896 Fix previous change: the library cache is defined in w32.c.
2897 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2898 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2899
0898ca10
JB
29002011-05-04 Juanma Barranquero <lekktu@gmail.com>
2901
2902 Implement dynamic loading of GnuTLS on Windows.
2903
2904 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2905 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2906 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2907 Declare.
2908
2909 * gnutls.c (Qgnutls_dll): Define.
2910 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2911 (gnutls_*): Declare function pointers.
2912 (init_gnutls_functions): New function to initialize function pointers.
2913 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2914 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2915 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2916 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2917 (emacs_gnutls_write, emacs_gnutls_read)
2918 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2919 (Fgnutls_available_p): New function.
2920 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2921 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2922 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2923
2924 * image.c: Include w32.h.
2925 (Vimage_type_cache): Delete.
2926 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2927 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2928 (w32_delayed_load): Move to w32.c.
2929
2930 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2931
2932 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2933 (w32_delayed_load): Move from image.c. When loading a library, record
2934 its filename in the :loaded-from property of the library id.
2935 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2936 Initialize and staticpro them.
2937 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2938
2939 * process.c: Include lisp.h before w32.h, not after.
2940 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2941 instead of gnutls_record_check_pending.
2942
2943 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2944
ff4de4aa
TZ
29452011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2946
2947 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2948 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2949 as passed in.
2950
abe95abb
JD
29512011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2952
2953 * xterm.c (x_set_frame_alpha): Do not set property on anything
2954 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2955
e16e55d4
JB
29562011-05-02 Juanma Barranquero <lekktu@gmail.com>
2957
2958 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2959
bafcf6a5
JB
29602011-05-02 Juanma Barranquero <lekktu@gmail.com>
2961
2962 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2963 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2964 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2965 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2966 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2967 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2968 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2969 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2970 (Qgnutls_bootprop_callbacks_verify): Make static.
2971
e7a6747f
AS
29722011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2973
19ed11ba
AS
2974 * callproc.c: Indentation fixup.
2975
e7a6747f 2976 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2977 (wait_for_termination, interruptible_wait_for_termination):
2978 Move after wait_for_termination_1.
e7a6747f 2979
1ef14cb4
LMI
29802011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2981
2982 * sysdep.c (interruptible_wait_for_termination): New function
2983 which is like wait_for_termination, but allows keyboard
2984 interruptions.
2985
2986 * callproc.c (Fcall_process): Add (:file "file") as an option for
2987 the STDOUT buffer.
2988 (Fcall_process_region): Ditto.
2989
330d880c
EZ
29902011-04-30 Eli Zaretskii <eliz@gnu.org>
2991
8db90b73
EZ
2992 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2993 rather than `XVECTOR (FOO)->size'.
2994
330d880c
EZ
2995 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2996 inttypes.h, as a gnulib replacement is used if it not available in
2997 system headers.
2998
15cbd324
EZ
29992011-04-21 Eli Zaretskii <eliz@gnu.org>
3000
3001 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3002 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3003 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3004
3005 * coding.c (coding_alloc_by_realloc): Error out if destination
3006 will grow beyond MOST_POSITIVE_FIXNUM.
3007 (decode_coding_emacs_mule): Abort if there isn't enough place in
3008 charbuf for the composition carryover bytes. Reserve an extra
3009 space for up to 2 characters produced in a loop.
3010 (decode_coding_iso_2022): Abort if there isn't enough place in
3011 charbuf for the composition carryover bytes.
3012
30132011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3014
ae940cca
EZ
3015 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3016 aborting when %lld or %lll format is passed.
3017 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3018 %llo or %llx format is passed. (Bug#8545)
3019
03ab8921
EZ
3020 * window.c (window_scroll_line_based): Use a marker instead of
3021 simple variables to record original value of point. (Bug#7952)
3022
afda1437
EZ
3023 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3024 produced by %s or %c overflows available buffer space. (Bug#8545)
3025
f76dee0c
PE
30262011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3027
3028 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3029 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3030
fdc5744d
JB
30312011-04-28 Juanma Barranquero <lekktu@gmail.com>
3032
3033 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3034
638f053a
JB
30352011-04-28 Juanma Barranquero <lekktu@gmail.com>
3036
3037 * keyboard.c (Qdelayed_warnings_hook): Define.
3038 (command_loop_1): Run `delayed-warnings-hook'
3039 if Vdelayed_warnings_list is non-nil.
3040 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3041 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3042
d178f871
EZ
30432011-04-28 Eli Zaretskii <eliz@gnu.org>
3044
3045 * doprnt.c (doprnt): Don't return value smaller than the buffer
3046 size if the message was truncated. (Bug#8545).
3047
b124fd93
JB
30482011-04-28 Juanma Barranquero <lekktu@gmail.com>
3049
3050 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3051 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3052
e810457d
PE
30532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3054
3055 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3056
ea51cceb
JB
30572011-04-27 Juanma Barranquero <lekktu@gmail.com>
3058
3059 * makefile.w32-in: Update dependencies.
3060
94dcfacf
EZ
30612011-04-27 Eli Zaretskii <eliz@gnu.org>
3062
3063 Improve `doprnt' and its usage. (Bug#8545)
3064 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3065 `format_end'. Remove support for %l as a conversion specifier.
3066 Don't use xrealloc. Improve diagnostics when the %l size modifier
3067 is used. Update the commentary.
3068
3069 * eval.c (verror): Simplify calculation of size_t.
3070
3071 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3072 messages.
3073
f61f41d7
PE
30742011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3075
3076 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3077 change.
3078
96fb4434
PE
30792011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3080
3081 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3082 This makes this file independent of the recent pseudovector change.
3083
671875da 30842011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3085
69e9b5a3
PE
3086 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3087
b5f869a7 3088 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3089 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3090 Remove unused local.
c8926152 3091 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3092
841a1577 3093 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3094 GCC 4.6.0 optimizes based on type-based alias analysis.
3095 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3096 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3097 != &v->size, and therefore "v->size = 1; b->size = 2; return
3098 v->size;" must therefore return 1. This assumption is incorrect
3099 for Emacs, since it type-puns struct Lisp_Vector * with many other
3100 types. To fix this problem, this patch adds a new type struct
f904488f 3101 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3102 and pseudovectors, and helps optimizing compilers not get fooled
3103 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3104 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3105 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3106 the size member.
eab3844f
PE
3107 (XSETPVECTYPE): Rewrite in terms of new macro.
3108 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3109 This is a bit clearer, and further avoids the possibility of
3110 undesirable aliasing.
3111 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3112 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3113 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3114 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3115 (ASIZE): Now uses header.size rather than size.
3116 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3117 to avoid the hassle of writing XVECTOR (foo)->header.size.
3118 (struct vectorlike_header): New type.
eab3844f
PE
3119 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3120 object, to help avoid aliasing.
3121 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3122 (SUBRP): Likewise, since Lisp_Subr is a special case.
3123 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3124 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3125 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3126 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3127 changed to be "header.size" and "header.next".
3128 * buffer.h (struct buffer): Likewise.
3129 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3130 * frame.h (struct frame): Likewise.
3131 * process.h (struct Lisp_Process): Likewise.
3132 * termhooks.h (struct terminal): Likewise.
3133 * window.c (struct save_window_data, struct saved_window): Likewise.
3134 * window.h (struct window): Likewise.
3135 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3136 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3137 * buffer.c (init_buffer_once): Likewise.
3138 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3139 special case.
3140 * process.c (Fformat_network_address): Use local var for size,
3141 for brevity.
3142
0df1eac5
PE
3143 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3144
847ab9d1 3145 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3146 * data.c (atof): Remove decl; no longer used or needed.
3147 (digit_to_number): Move to lread.c.
3148 (Fstring_to_number): Use new string_to_number function, to be
3149 consistent with how the Lisp reader treats infinities and NaNs.
3150 Do not assume that floating-point numbers represent EMACS_INT
3151 without losing information; this is not true on most 64-bit hosts.
3152 Avoid double-rounding errors, by insisting on integers when
3153 parsing non-base-10 numbers, as the documentation specifies.
3154 * lisp.h (string_to_number): New decl, replacing ...
3155 (isfloat_string): Remove.
bc0a5c13 3156 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3157 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3158 appears to have been a coding error. Similarly, do not accept
3159 strings like +-1e0 as floating point numbers. Do not report
3160 overflow for integer overflows unless the base is not 10 which
3161 means we have no simple and reliable way to continue.
3162 Break out the floating-point parsing into a new
3163 function string_to_number, so that Fstring_to_number parses
3164 floating point numbers consistently with the Lisp reader.
04f2d78b 3165 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3166 (E_CHAR, EXP_INT): Remove, replacing with ...
3167 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3168 (string_to_number): New function, replacing isfloat_string.
3169 This function checks for valid syntax and produces the resulting
3170 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3171 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3172 so that overflow for non-base-10 numbers is reported only when
3173 there's no portable and simple way to convert to floating point.
452f4150 3174
67769ffc
PE
3175 * textprop.c (set_text_properties_1): Rewrite for clarity,
3176 and to avoid GCC warning about integer overflow.
3177
c20db43f
PE
3178 * intervals.h (struct interval): Use EMACS_INT for members
3179 where EMACS_UINT might cause problems. See
3180 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3181 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3182 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3183 All uses changed.
37aa2f85
PE
3184 (offset_intervals): Tell GCC not to worry about length overflow
3185 when negating a negative length.
c20db43f 3186
2538aa2f
PE
3187 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3188 (overrun_check_free): Likewise.
3189
f2d3008d
PE
3190 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3191 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3192 word size.
3193
ec8df744
PE
3194 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3195 (gnutls_make_error): Rename local to avoid shadowing.
3196 (gnutls_emacs_global_deinit): ifdef out; not used.
3197 (Fgnutls_boot): Use const for pointer to readonly storage.
3198 Comment out unused local. Fix pointer signedness problems.
3199
640ee02d
PE
3200 * lread.c (openp): Don't stuff size_t into an 'int'.
3201 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3202 about possible signed overflow.
3203
6048fb2a
PE
3204 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3205 (GDK_KEY_g): Don't define if already defined.
3206 (xg_prepare_tooltip): Avoid pointer signedness problem.
3207 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3208
fa3c87e1
PE
3209 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3210 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3211
2172544b
PE
3212 * xfns.c (Fx_window_property): Simplify a bit,
3213 to make a bit faster and to avoid GCC 4.6.0 warning.
3214 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3215
9b821a21
PE
3216 * fns.c (internal_equal): Don't assume size_t fits in int.
3217
3c616cfa
PE
3218 * alloc.c (compact_small_strings): Tighten assertion a little.
3219
c2982e87
PE
3220 Replace pEd with more-general pI, and fix some printf arg casts.
3221 * lisp.h (pI): New macro, generalizing old pEd macro to other
3222 conversion specifiers. For example, use "...%"pI"d..." rather
3223 than "...%"pEd"...".
3224 (pEd): Remove. All uses replaced with similar uses of pI.
3225 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3226 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3227 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3228 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3229 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3230 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3231 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3232 64-bit hosts.
3233 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3234 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3235 * print.c (safe_debug_print, print_object): Likewise.
3236 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3237 to int.
6f04d126
PE
3238 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3239 avoiding the 0 flag, which is not portable.
c2982e87
PE
3240 * process.c (Fmake_network_process): Use pI to avoid cast.
3241 * region-cache.c (pp_cache): Likewise.
3242 * xdisp.c (decode_mode_spec): Likewise.
3243 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3244 behavior on 64-bit hosts with printf arg.
6f04d126 3245 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3246 (x_stop_queuing_selection_requests): Likewise.
3247 (x_get_window_property): Don't truncate byte count to an 'int'
3248 when tracing.
0b432f21 3249
5e073ec7
PE
3250 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3251 here, since it parses constructs like leading '-' and spaces,
3252 which are not wanted; and it overflows with large numbers.
3253 Instead, simply match F[0-9]+, which is what is wanted anyway.
3254
36372bf9
PE
3255 * alloc.c: Remove unportable assumptions about struct layout.
3256 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3257 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3258 (allocate_vectorlike, make_pure_vector): Use the new macros,
3259 plus offsetof, to remove unportable assumptions about struct layout.
3260 These assumptions hold on all porting targets that I know of, but
3261 they are not guaranteed, they're easy to remove, and removing them
3262 makes further changes easier.
3263
0b432f21
PE
3264 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3265 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3266 (string_overrun_cookie): Now const. Use initializers that
3267 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3268 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3269 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3270 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3271 multiple of sizeof (EMACS_INT); it need not be, if
3272 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3273 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3274
895009e1
JB
32752011-04-26 Juanma Barranquero <lekktu@gmail.com>
3276
3277 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3278
6a7a1b0b
TZ
32792011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3280
3281 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3282 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3283 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3284
841a1577 32852011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3286
3287 * lisp.h (Qdebug): List symbol.
895009e1 3288 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3289 * keyboard.c (debug-on-event): New variable.
3290 (handle_user_signal): Break into debugger when debug-on-event
3291 matches the current signal symbol.
3292
f2d3ba6f
DN
32932011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3294
3295 * alloc.c (check_sblock, check_string_bytes)
3296 (check_string_free_list): Convert to standard C.
3297
42ce4c63
TZ
32982011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3299
3300 * w32.c (emacs_gnutls_push): Fix typo.
3301
825cd63c
EZ
33022011-04-25 Eli Zaretskii <eliz@gnu.org>
3303
fb11d64d
EZ
3304 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3305 "cast to pointer from integer of different size".
3306
825cd63c
EZ
3307 Improve doprnt and its use in verror. (Bug#8545)
3308 * doprnt.c (doprnt): Document the set of format control sequences
3309 supported by the function. Use SAFE_ALLOCA instead of always
3310 using `alloca'.
3311
3312 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3313 is one byte too soon. Don't use xrealloc; instead xfree and
3314 xmalloc anew.
3315
e061a11b
TZ
33162011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3317
3318 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3319 callbacks stage.
3320
3321 * gnutls.c: Renamed global_initialized to
3322 gnutls_global_initialized. Added internals for the
3323 :verify-hostname-error, :verify-error, and :verify-flags
3324 parameters of `gnutls-boot' and documented those parameters in the
3325 docstring. Start callback support.
9173deec
JB
3326 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3327 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3328 on error. Return error code.
e061a11b
TZ
3329 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3330 (emacs_gnutls_read): Likewise.
3331 (Fgnutls_boot): Return handshake error code.
3332 (emacs_gnutls_handle_error): New function.
3333 (wsaerror_to_errno): Likewise.
3334
3335 * w32.h (emacs_gnutls_pull): Add prototype.
3336 (emacs_gnutls_push): Likewise.
3337
3338 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3339 (emacs_gnutls_push): Likewise.
3340
33412011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3342
3343 * process.c (wait_reading_process_output): Check if GnuTLS
3344 buffered some data internally if no FDs are set for TLS
3345 connections.
3346
3347 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3348 (LIBS): Link to USER_LIBS.
3349 ($(BLD)/gnutls.$(0)): New target.
3350
fa6996bc
EZ
33512011-04-24 Eli Zaretskii <eliz@gnu.org>
3352
eb35682e
EZ
3353 * xdisp.c (handle_single_display_spec): Rename the
3354 display_replaced_before_p argument into display_replaced_p, to
3355 make it consistent with the commentary. Fix typos in the
3356 commentary.
3357
e2ad650c
EZ
3358 * textprop.c (syms_of_textprop): Remove dead code.
3359 (copy_text_properties): Delete obsolete commentary about an
3360 interface that was deleted long ago. Fix typos in the description
3361 of arguments.
3362
1b2de274
EZ
3363 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3364 to changes in oldXMenu/XMenu.h from 2011-04-16.
3365 <menu_help_message, prev_menu_help_message>: Constify.
3366 (IT_menu_make_room): menu->help_text is now `const char **';
3367 adjust.
3368
3369 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3370 to changes in oldXMenu/XMenu.h from 2011-04-16.
3371 (struct XMenu): Declare `help_text' `const char **'.
3372
3373 * xfaces.c <Qunspecified>: Make extern again.
3374
3375 * syntax.c: Include sys/types.h before including regex.h, as
3376 required by Posix.
3377
762b15be
EZ
3378 * doc.c (get_doc_string): Improve the format passed to `error'.
3379
3380 * doprnt.c (doprnt): Improve commentary.
3381
3382 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3383
3384 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3385 them with etags.
3386
f1052e5d
EZ
3387 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3388 changes in globals.h immediately force recompilation.
762b15be
EZ
3389 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3390 $(CURDIR)/s/ms-w32.h.
3391 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3392
fa6996bc
EZ
3393 * character.c (Fchar_direction): Function deleted.
3394 (syms_of_character): Don't defsubr it.
3395 <char-direction-table>: Deleted.
3396
e6c3da20
EZ
33972011-04-23 Eli Zaretskii <eliz@gnu.org>
3398
3399 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3400 * doprnt.c: Include limits.h.
3401 (SIZE_MAX): New macro.
04f2d78b
CB
3402 (doprnt): Return a size_t value. 2nd arg is now size_t.
3403 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3404 Improve overflow protection. Support `l' modifier for integer
3405 conversions. Support %l conversion. Don't assume an EMACS_INT
3406 argument for integer conversions and for %c.
3407
3408 * lisp.h (doprnt): Restore prototype.
3409
3410 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3411 $(SRC)/character.h.
3412
3413 * Makefile.in (base_obj): Add back doprnt.o.
3414
3415 * deps.mk (doprnt.o): Add back prerequisites.
3416 (callint.o): Depend on character.h.
3417
3418 * eval.c (internal_lisp_condition_case): Include the handler
3419 representation in the error message.
3420 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3421 when breaking from the loop.
3422
3423 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3424
3425 * callint.c (Fcall_interactively): When displaying error message
3426 about invalid control letter, pass the character's codepoint, not
3427 a pointer to its multibyte form. Improve display of the character
3428 in octal and display also its hex code.
3429
3430 * character.c (char_string): Use %x to display the (unsigned)
3431 codepoint of an invalid character, to avoid displaying a bogus
3432 negative value.
3433
3434 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3435 `error', not SYMBOL_NAME itself.
3436
3437 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3438 character arguments to `error'.
3439
3440 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3441 to `error' in error message about FINAL_CHAR argument. Make sure
3442 FINAL_CHAR is a character, and use %c when it is passed as
3443 argument to `error'.
3444
4ffd0d6b 34452011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3446
3447 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3448
3449 * w32.c: Include <time.h>.
3450 (sys_localtime): New function.
3451
4ffd0d6b 34522011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3453
3454 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3455
4ffd0d6b 3456 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3457
4ffd0d6b 34582011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3459
4ffd0d6b
GM
3460 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3461 zombies (Bug#8467).
aac0c6e3 3462
04c56954
EZ
34632011-04-19 Eli Zaretskii <eliz@gnu.org>
3464
3465 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3466 gl_state.e_property when gl_state.object is Qt.
3467
3468 * insdel.c (make_gap_larger): Remove limitation of buffer size
3469 to <= INT_MAX.
3470
16a43933
CY
34712011-04-18 Chong Yidong <cyd@stupidchicken.com>
3472
3473 * xdisp.c (lookup_glyphless_char_display)
3474 (produce_glyphless_glyph): Handle cons cell entry in
3475 glyphless-char-display.
3476 (Vglyphless_char_display): Document it.
3477
3478 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3479 glyphless-char-display.
3480
4581706e
CY
34812011-04-17 Chong Yidong <cyd@stupidchicken.com>
3482
3483 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3484
3485 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3486
3487 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3488 definition for no-X builds.
3489
4887c6e2 34902011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3491
fd35b6f9
PE
3492 Static checks with GCC 4.6.0 and non-default toolkits.
3493
5c1ccb01
PE
3494 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3495
006c5daa
PE
3496 * process.c (keyboard_bit_set): Define only if SIGIO.
3497 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3498 (send_process): Repair possible setjmp clobbering.
3499
efc736d3
PE
3500 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3501
4e2fe2e6
PE
3502 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3503
f97334a2
PE
3504 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3505
4e75f29d
PE
3506 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3507 Define only if needed.
3508
90efadd1
PE
3509 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3510 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3511 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3512
3c647824
PE
3513 * dispextern.h (struct redisplay_interface): Rename param
3514 to avoid shadowing.
e264f262 3515 * termhooks.h (struct terminal): Likewise.
761383f4 3516 * xterm.c (xembed_send_message): Likewise.
3c647824 3517
b58c5c4a
PE
3518 * insdel.c (make_gap_smaller): Define only if
3519 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3520
cad59032
PE
3521 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3522 it.
3523
c339dc2e
PE
3524 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3525 so that we aren't warned about unused symbols.
3526
91a3e27b
PE
3527 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3528
399c71d3 3529 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3530
8ffc96f5
PE
3531 * xfns.c (x_real_positions): Mark locals as initialized.
3532
eef9bc79
PE
3533 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3534
098db9dd
PE
3535 * xterm.c: Fix problems found by static analysis with other toolkits.
3536 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3537 (x_dispatch_event): Declare static if USE_GTK, and
3538 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3539 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3540 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3541 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3542 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3543
eb18f6cc
PE
3544 * xmenu.c (menu_help_callback): Pointer type fixes.
3545 Use const pointers when pointing at readonly data. Avoid pointer
3546 signedness clashes.
3547 (FALSE): Remove unused macro.
3548 (update_frame_menubar): Remove unused decl.
3549
1fe72bf8
PE
3550 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3551
60d9e1db
PE
3552 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3553 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3554 (single_menu_item): Rename local to avoid shadowing.
3555
39261c26
PE
3556 * keyboard.c (make_lispy_event): Remove unused local var.
3557
018c5e19
PE
3558 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3559 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3560
63d2b86e
PE
3561 * bitmaps: Change bitmaps from unsigned char back to the X11
3562 compatible char. Avoid the old compiler warnings about
3563 out-of-range initializers by using, for example, '\xab' rather
3564 than 0xab.
3565
aefd87e1
PE
3566 * xgselect.c (xgselect_initialize): Check vs interface
3567 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3568
bf501fb9
PE
3569 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3570
e9829fdf
PE
3571 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3572 to read-only memory.
3573
1086c095
PE
3574 * fns.c (vector): Remove; this old hack is no longer needed.
3575
2baccd04 3576 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3577 Remove unused var.
dde42981 3578 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3579
72391843 3580 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3581
436c16df 3582 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3583 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3584 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3585
92bb796d 3586 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3587 (x_term_init): Remove local to avoid shadowing.
92bb796d 3588
764430a3 3589 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3590
3591 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3592 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3593
d1dfb56c
EZ
35942011-04-16 Eli Zaretskii <eliz@gnu.org>
3595
c4354cb4
EZ
3596 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3597
d1dfb56c
EZ
3598 Fix regex.c, syntax.c and friends for buffers > 2GB.
3599 * syntax.h (struct gl_state_s): Declare character position members
3600 EMACS_INT.
3601
3602 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3603
04f2d78b
CB
3604 * textprop.c (verify_interval_modification, interval_of):
3605 Declare arguments EMACS_INT.
d1dfb56c
EZ
3606
3607 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3608 EMACS_INT.
3609
3610 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3611
3612 * indent.c (Fvertical_motion): Local variable it_start is now
3613 EMACS_INT.
3614
3615 * regex.c (re_match, re_match_2, re_match_2_internal)
3616 (bcmp_translate, regcomp, regexec, print_double_string)
3617 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3618 (re_compile_pattern, re_exec): Declare arguments and local
3619 variables `size_t' and `ssize_t' and return values `regoff_t', as
3620 appropriate.
3621 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3622 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3623 <compile_stack_type>: `size' and `avail' are now `size_t'.
3624
3625 * regex.h <regoff_t>: Use ssize_t, not int.
3626 (re_search, re_search_2, re_match, re_match_2): Arguments that
3627 specify buffer/string position and length are now ssize_t and
3628 size_t. Return type is regoff_t.
3629
613052cd
BK
36302011-04-16 Ben Key <bkey76@gmail.com>
3631
3632 * nsfont.m: Fixed bugs in ns_get_family and
3633 ns_descriptor_to_entity that were caused by using free to
3634 deallocate memory blocks that were allocated by xmalloc (via
3635 xstrdup). This caused Emacs to crash when compiled with
3636 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3637 --enable-checking=xmallocoverrun). xfree is now used to
3638 deallocate these memory blocks.
3639
4170f62f 36402011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3641
71b41406
PE
3642 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3643
9587a89d
PE
3644 emacs_write: Accept and return EMACS_INT for sizes.
3645 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3646 et seq.
3647 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3648 Accept and return EMACS_INT.
3649 (emacs_gnutls_write): Return the number of bytes written on
3650 partial writes.
3651 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3652 (emacs_read, emacs_write): Remove check for negative size, as the
3653 Emacs source code has been audited now.
9587a89d
PE
3654 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3655 (emacs_read, emacs_write): Use it.
273a5f82
PE
3656 * process.c (send_process): Adjust to the new signatures of
3657 emacs_write and emacs_gnutls_write. Do not attempt to store
3658 a byte offset into an 'int'; it might overflow.
9587a89d 3659 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3660
3e047f51
PE
3661 * sound.c: Don't assume sizes fit in 'int'.
3662 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3663 Return EMACS_INT, not int.
3e047f51 3664 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3665 Accept EMACS_INT, not int.
3666 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3667 record read return values.
3668
cc39a9db
BK
36692011-04-15 Ben Key <bkey76@gmail.com>
3670
c9d0ec6d
JB
3671 * keyboard.c (Qundefined): Don't declare static since it is used
3672 in nsfns.m.
3673 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3674 static since they are used in nsfont.m.
cc39a9db 3675
6c60eb9f
SM
36762011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3677
3678 * process.c (Qprocessp): Don't declare static.
3679 * lisp.h (Qprocessp): Declare again.
3680
7990b61a
JB
36812011-04-15 Juanma Barranquero <lekktu@gmail.com>
3682
3683 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3684
5d4cb038
PE
36852011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3686
8bd7b830 3687 Improve C-level modularity by making more things 'static'.
cd64ea1d 3688
e3b27b31
PE
3689 Don't publish debugger-only interfaces to other modules.
3690 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3691 (verify_bytepos, count_markers): Move decls to the only modules
3692 that need them.
3693 * region-cache.h (pp_cache): Likewise.
3694 * window.h (check_all_windows): Likewise.
3695 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3696
5d4cb038
PE
3697 * sysdep.c (croak): Now static, if
3698 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3699 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3700
3701 * alloc.c (refill_memory_reserve): Now static if
3702 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3703 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3704
e87b6180
PE
3705 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3706 Define only if USE_LUCID.
3707
ac64929e
PE
3708 * xrdb.c (x_customization_string, x_rm_string): Now static.
3709
6f37259d
PE
3710 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3711 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3712
1683e3ab
PE
3713 * xdisp.c (draw_row_with_mouse_face): Now static.
3714 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3715
de9c2632
PE
3716 * window.h (check_all_windows): Mark externally visible.
3717
2b96acb7
PE
3718 * window.c (window_deletion_count): Now static.
3719
3720 * undo.c: Make symbols static if they're not exported.
3721 (last_undo_buffer, last_boundary_position, pending_boundary):
3722 Now static.
3723
50436f33
PE
3724 * textprop.c (interval_insert_behind_hooks): Now static.
3725 (interval_insert_in_front_hooks): Likewise.
3726
64520e5c
PE
3727 * term.c: Make symbols static if they're not exported.
3728 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3729 (max_frame_lines, tty_set_terminal_modes):
3730 (tty_reset_terminal_modes, tty_turn_off_highlight):
3731 (get_tty_terminal): Now static.
3732 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3733 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3734 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3735 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3736 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3737
1fa53021
PE
3738 * sysdep.c: Make symbols static if they're not exported.
3739 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3740 Now static.
3741 (sigprocmask_set, full_mask): Remove; unused.
3742 (wait_debugging): Mark as visible.
3743 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3744 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3745
d4b43b22
PE
3746 * syntax.c (syntax_temp): Define only if !__GNUC__.
3747
b7c513d0
PE
3748 * sound.c (current_sound_device, current_sound): Now static.
3749
989b29ad
PE
3750 * search.c (searchbufs, searchbuf_head): Now static.
3751
13a55a78
PE
3752 * scroll.c (scroll_cost): Remove; unused.
3753 * dispextern.h (scroll_cost): Remove decl.
3754
de68a1fc
PE
3755 * region-cache.h (pp_cache): Mark as externally visible.
3756
40ccffa6
PE
3757 * process.c: Make symbols static if they're not exported.
3758 (process_tick, update_tick, create_process, chan_process):
3759 (Vprocess_alist, proc_buffered_char, datagram_access):
3760 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3761 (deactivate_process): Mark defn as static, as well as decl.
3762 * lisp.h (create_process): Remove decl.
3763 * process.h (chan_process, Vprocess_alist): Remove decls.
3764
ad64fc97
PE
3765 * print.c: Make symbols static if they're not exported.
3766 (print_depth, new_backquote_output, being_printed, print_buffer):
3767 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3768 (print_interval, print_number_index, initial_stderr_stream):
3769 Now static.
3770 * lisp.h (Fprinc): Remove decl.
3771 (debug_output_compilation_hack): Mark as externally visible.
3772
adddb265
PE
3773 * sysdep.c (croak): Move decl from here to syssignal.h.
3774 * syssignal.h (croak): Put it here, so the API can be checked when
3775 'croak' is called from dissociate_if_controlling_tty.
3776
1717ede2
PE
3777 * minibuf.c: Make symbols static if they're not exported.
3778 (minibuf_save_list, choose_minibuf_frame): Now static.
3779 * lisp.h (choose_minibuf_frame): Remove decl.
3780
fa5fb2bc
PE
3781 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3782
1e3890d1
PE
3783 * lread.c: Make symbols static if they're not exported.
3784 (read_objects, initial_obarray, oblookup_last_bucket_number):
3785 Now static.
3786 (make_symbol): Remove; unused.
3787 * lisp.h (initial_obarray, make_symbol): Remove decls.
3788
8a1414fa
PE
3789 * keyboard.c: Make symbols static if they're not exported.
3790 (single_kboard, recent_keys_index, total_keys, recent_keys):
3791 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3792 (this_single_command_key_start, echoing, last_auto_save):
3793 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3794 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3795 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3796 (Vlispy_mouse_stem, double_click_count):
3797 Now static.
3798 (force_auto_save_soon): Define only if SIGDANGER.
3799 (ignore_mouse_drag_p): Now static if
3800 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3801 (print_help): Remove; unused.
3802 (stop_character, last_timer_event): Mark as externally visible.
3803 * keyboard.h (ignore_mouse_drag_p): Declare only if
3804 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3805 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3806 * lisp.h (echoing): Remove decl.
3807 (force_auto_save_soon): Declare only if SIGDANGER.
3808 * xdisp.c (redisplay_window): Simplify code, to make it more
3809 obvious that ignore_mouse_drag_p is not accessed if !defined
3810 USE_GTK && !defined HAVE_NS.
3811
93ea6e8f
PE
3812 * intervals.c: Make symbols static if they're not exported.
3813 (merge_properties_sticky, merge_interval_right, delete_interval):
3814 Now static.
3815 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3816
77382fcc
PE
3817 * insdel.c: Make symbols static if they're not exported.
3818 However, leave prepare_to_modify_buffer alone. It's never
3819 called from outside this function, but that appears to be a bug.
3820 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3821 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3822 (adjust_after_replace_noundo): Remove; unused.
3823 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3824 (signal_before_change): Remove decls.
77382fcc 3825
9306c32e
PE
3826 * indent.c (val_compute_motion, val_vmotion): Now static.
3827
cd44d2eb
PE
3828 * image.c: Make symbols static if they're not exported.
3829 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3830 if USE_GTK.
3831 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3832 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3833
ad9a7a06
PE
3834 * fringe.c (standard_bitmaps): Now static.
3835 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3836
81626931
PE
3837 * frame.c: Make symbols static if they're not exported.
3838 (x_report_frame_params, make_terminal_frame): Now static.
3839 (get_frame_param): Now static, unless HAVE_NS.
3840 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3841 (x_get_resource_string): Remove; not used.
3842 * frame.h (make_terminal_frame, x_report_frame_params):
3843 (x_get_resource_string); Remove decls.
3844 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3845 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3846
239f9db9
PE
3847 * font.c, fontset.c: Make symbols static if they're not exported.
3848 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3849 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3850 * font.c (font_close_object): Now static.
3851 * font.h (font_close_object): Remove.
3852 * fontset.c (FONTSET_OBJLIST): Remove.
3853 (free_realized_fontset) #if-0 the body, which does nothing.
3854 (face_suitable_for_char_p): #if-0, as it's never called.
3855 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3856 * xfaces.c (face_at_string_position):
3857 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3858 since 0 is always ASCII.
3859
dfcf3579
PE
3860 * fns.c (weak_hash_tables): Now static.
3861
5045092b
PE
3862 * fileio.c: Make symbols static if they're not exported.
3863 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3864 (Vwrite_region_annotation_buffers): Now static.
3865
57a96f5c
PE
3866 * eval.c: Make symbols static if they're not exported.
3867 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3868 * lisp.h (backtrace_list): Remove decl.
3869
35f08c38
PE
3870 * emacs.c: Make symbols static if they're not exported.
3871 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3872 (fatal_error_code, fatal_error_signal_hook, standard_args):
3873 Now static.
3874 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3875 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3876 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3877 * lisp.h (fatal_error_signal_hook): Remove decl.
3878 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3879
f44bd759
PE
3880 * editfns.c: Move a (normally-unused) function to its only use.
3881 * editfns.c, lisp.h (get_operating_system_release): Remove.
3882 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3883 worth the hassle of breaking this out.
3884
b532497d
PE
3885 * xterm.c: Make symbols static if they're not exported.
3886 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3887 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3888 (x_destroy_window, x_delete_display):
3889 Now static.
3890 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3891 (x_mouse_leave): Remove; unused.
3892 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3893 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3894 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3895 Remove decls.
3896 (x_mouse_leave): Declare only if WINDOWSNT.
3897 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3898 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3899 USE_X_TOOLKIT.
3900
1675728f
PE
3901 * ftxfont.c: Make symbols static if they're not exported.
3902 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3903 HAVE_FREETYPE.
3904 * font.h (ftxfont_driver): Likewise.
3905
e4cebfca
PE
3906 * xfns.c: Make symbols static if they're not exported.
3907 (x_last_font_name, x_display_info_for_name):
3908 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3909 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3910 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3911 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3912 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3913 (last_show_tip_args): Now static.
3914 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3915 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3916 (x_screen_planes): Remove; unused.
3917 * dispextern.h (x_screen_planes): Remove decl.
3918
5bf46f05
PE
3919 * dispnew.c: Make symbols static if they're not exported.
3920 * dispextern.h (redraw_garbaged_frames, scrolling):
3921 (increment_row_positions): Remove.
3922 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3923 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3924 Now static.
3925 (redraw_garbaged_frames): Remove; unused.
3926
435f4c28
PE
3927 * xfaces.c: Make symbols static if they're not exported.
3928 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3929 Remove decls.
3930 * xterm.h (defined_color): Remove decls.
3931 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3932 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3933 (menu_face_changed_default, defined_color, free_realized_face):
3934 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3935 (ascii_face_of_lisp_face): Remove; unused.
3936
8524aef3
PE
3937 * xdisp.c: Make symbols static if they're not exported.
3938 * dispextern.h (scratch_glyph_row, window_box_edges):
3939 (glyph_to_pixel_coords, set_cursor_from_row):
3940 (get_next_display_element, set_iterator_to_next):
3941 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3942 (show_mouse_face): Remove decls
3943 * frame.h (message_buf_print): Likewise.
3944 * lisp.h (pop_message, set_message, check_point_in_composition):
3945 Likewise.
3946 * xterm.h (set_vertical_scroll_bar): Likewise.
3947 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3948 (message_buf_print, scratch_glyph_row, displayed_buffer):
3949 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3950 (get_next_display_element, show_mouse_face, window_box_edges):
3951 (frame_to_window_pixel_xy, check_point_in_composition):
3952 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3953 (glyph_to_pixel_coords): Remove; unused.
3954
16390cd2
PE
3955 * dired.c (file_name_completion): Now static.
3956
3957 * dbusbind.c (xd_in_read_queued_messages): Now static.
3958
a25f4dfa
PE
3959 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3960 * data.c (circular_list_error): Remove.
3961
14a9c8df
PE
3962 * commands.h (last_point_position, last_point_position_buffer):
3963 (last_point_position_window): Remove decls.
3964 * keyboard.c: Make these variables static.
3965
04f2d78b
CB
3966 * coding.h (coding, code_convert_region, encode_coding_gap):
3967 Remove decls.
74ab6df5
PE
3968 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3969 (iso_code_class, detect_coding, code_convert_region): Now static.
3970 (encode_coding_gap): Remove; unused.
3971
38dfbee1
PE
3972 * chartab.c (chartab_chars, chartab_bits): Now static.
3973
a2cb4e63
PE
3974 * charset.h (charset_iso_8859_1): Remove decl.
3975 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3976 Now static.
3977
127198fd
PE
3978 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3979 * ccl.c (Vccl_program_table): Now static.
3980 (check_ccl_update): Remove; unused.
3981
d85b608f
PE
3982 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3983 * category.h: ... from here.
3984 * category.c (check_category_table, set_category_set): Now static.
3985
31cd66f3
PE
3986 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3987 * lisp.h: Remove these decls.
3988
c358e587
PE
3989 * buffer.c (buffer_count): Remove unused var.
3990
e78aecca
PE
3991 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3992 so that it's not optimized away.
3993 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3994 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3995 exported only to the debugger.
3996
e192d7d3 3997 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3998 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3999
92470028
PE
4000 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4001 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4002 was inaccessible from Lisp.
4003 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4004 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4005
244ed907
PE
4006 alloc.c: Import and export fewer symbols, and remove unused items.
4007 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4008 is defined.
4009 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4010 it's not optimized away by whole-program optimization.
4011 (message_enable_multibyte, free_misc): Remove.
4012 (catchlist, handlerlist, mark_backtrace):
4013 Declare only if BYTE_MARK_STACK.
4014 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4015 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4016 (message_enable_multibyte): Remove decl.
4017 (free_misc, interval_free_list, float_block, float_block_index):
4018 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4019 (cons_free_list, last_marked_index):
4020 Now static.
4021 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4022 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4023 (mark_backtrace): Define only if BYTE_MARK_STACK.
4024 * xdisp.c (message_enable_multibyte): Now static.
4025
61c2b50e 4026 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4027 This makes it easier for human readers (and static analyzers)
4028 to see whether these variables are used from other modules.
4029 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4030 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4031 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4032 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4033 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4034 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4035 * xmenu.c, xselect.c:
4036 Declare Q* vars static if they are not used in other modules.
4037 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4038 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4039 Remove decls of unexported vars.
4040 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4041
95c82688
PE
4042 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4043
16a97296
PE
4044 Make Emacs functions such as Fatom 'static' by default.
4045 This makes it easier for human readers (and static analyzers)
4046 to see whether these functions can be called from other modules.
4047 DEFUN now defines a static function. To make the function external
4048 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4049 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4050 (Finit_image_library):
16a97296
PE
4051 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4052 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4053 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4054 Remove decls, since these functions are now static.
4055 (Funintern, Fget_internal_run_time): New decls, since these functions
4056 were already external.
95c82688 4057
16a97296
PE
4058 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4059 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4060 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4061 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4062 * keyboard.c, keymap.c, lread.c:
4063 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4064 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4065 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4066 Mark functions with DEFUE instead of DEFUN,
4067 if they are used in other modules.
4068 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4069 decls for now-static functions.
4070 * buffer.h (Fdelete_overlay): Remove decl.
4071 * callproc.c (Fgetenv_internal): Mark as internal.
4072 * composite.c (Fremove_list_of_text_properties): Remove decl.
4073 (Fcomposition_get_gstring): New forward static decl.
4074 * composite.h (Fcomposite_get_gstring): Remove decl.
4075 * dired.c (Ffile_attributes): New forward static decl.
4076 * doc.c (Fdocumntation_property): New forward static decl.
4077 * eval.c (Ffetch_bytecode): New forward static decl.
4078 (Funintern): Remove extern decl; now in .h file where it belongs.
4079 * fileio.c (Fmake_symbolic_link): New forward static decl.
4080 * image.c (Finit_image_library): New forward static decl.
4081 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4082 * intervals.h (Fprevious_property_change):
4083 (Fremove_list_of_text_properties): Remove decls.
4084 * keyboard.c (Fthis_command_keys): Remove decl.
4085 (Fcommand_execute): New forward static decl.
4086 * keymap.c (Flookup_key): New forward static decl.
4087 (Fcopy_keymap): Now static.
4088 * keymap.h (Flookup_key): Remove decl.
4089 * process.c (Fget_process): New forward static decl.
4090 (Fprocess_datagram_address): Mark as internal.
4091 * syntax.c (Fsyntax_table_p): New forward static decl.
4092 (skip_chars): Remove duplicate decl.
4093 * textprop.c (Fprevious_property_change): New forward static decl.
4094 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4095 Now internal.
4096 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4097 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4098
785bbd42
PE
4099 * editfns.c (Fformat): Remove unreachable code.
4100
8b913b57
AS
41012011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4102
4103 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4104 change. (Bug#8496)
4105
a6744a35
EZ
41062011-04-13 Eli Zaretskii <eliz@gnu.org>
4107
4108 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4109 when at ZV. (Bug#8487)
4110
e7974947
AS
41112011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4112
baad03f0
AS
4113 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4114 (Bug#8437)
4115 * keyboard.c (parse_tool_bar_item): Likewise.
4116 * sound.c (sound_cleanup, alsa_close): Likewise.
4117 * termcap.c (tgetent): Likewise.
4118 * xfns.c (x_default_font_parameter): Likewise.
4119 * xsettings.c (read_and_apply_settings): Likewise.
4120
e7974947
AS
4121 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4122 (overrun_check_free): Protoize.
4123
28272684
PE
41242011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4125
4126 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4127 since callers should never pass a negative size.
4128 Change the signature to match that of plain 'read' and 'write'; see
4129 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4130 * lisp.h: Update prototypes of emacs_write and emacs_read.
4131
11997c76
EZ
41322011-04-11 Eli Zaretskii <eliz@gnu.org>
4133
4134 * xdisp.c (redisplay_window): Don't try to determine the character
4135 position of the scroll margin if the window start point w->startp
e896f03c 4136 is outside the buffer's accessible region. (Bug#8468)
11997c76 4137
8a2cbd72
EZ
41382011-04-10 Eli Zaretskii <eliz@gnu.org>
4139
4140 Fix write-region and its subroutines for buffers > 2GB.
4141 * fileio.c (a_write, e_write): Modify declaration of arguments and
4142 local variables to support buffers larger than 2GB.
4143 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4144
4145 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4146 argument, local variables, and return value.
4147
4148 * lisp.h: Update prototypes of emacs_write and emacs_read.
4149
4150 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4151
4073e537 41522011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4153
1ebfdcb6
PE
4154 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4155
b2ded58d
PE
4156 Fix more problems found by GCC 4.6.0's static checks.
4157
7d66342c
PE
4158 * xdisp.c (vmessage): Use a better test for character truncation.
4159
bbf47d44
PE
4160 * charset.c (load_charset_map): <, not <=, for optimization,
4161 and to avoid potential problems with integer overflow.
9248994d 4162 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4163 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4164 * editfns.c (Fformat): Likewise.
1e69125e 4165 * syntax.c (skip_chars): Likewise.
3befa583 4166
e3019616
PE
4167 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4168 This also lets GCC 4.6.0 generate slightly better loop code.
4169
becfa255
PE
4170 * callint.c (Fcall_interactively): <, not <=, for optimization.
4171 (Fcall_interactively): Count the number of arguments produced,
4172 not the number of arguments given. This is simpler and lets GCC
4173 4.6.0 generate slightly better code.
4174
dae0cd48
PE
4175 * ftfont.c: Distingish more carefully between FcChar8 and char.
4176 The previous code passed unsigned char * to a functions like
4177 strlen and xstrcasecmp that expect char *, which does not
4178 conform to the C standard.
4179 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4180 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4181 char * when the C standard requires it.
4182
76032d70
PE
4183 * keyboard.c (read_char): Remove unused var.
4184
eb3f1cc8
PE
4185 * eval.c: Port to Windows vsnprintf (Bug#8435).
4186 Include <limits.h>.
4187 (SIZE_MAX): Define if the headers do not.
4188 (verror): Do not give up if vsnprintf returns a negative count.
4189 Instead, grow the buffer. This ports to Windows vsnprintf, which
4190 does not conform to C99. Problem reported by Eli Zaretskii.
4191 Also, simplify the allocation scheme, by avoiding the need for
4192 calling realloc, and removing the ALLOCATED variable.
4193
70476b54
PE
4194 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4195
12020a9e
PE
4196 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4197 But keep the doprint source code for now, as we might revamp it
4198 and use it again (Bug#8435).
ea6c7ae6
PE
4199 * lisp.h (doprnt): Remove.
4200 * Makefile.in (base_obj): Remove doprnt.o.
4201 * deps.mk (doprnt.o): Remove.
4202
5fdb398c
PE
4203 error: Print 32- and 64-bit integers portably (Bug#8435).
4204 Without this change, on typical 64-bit hosts error ("...%d...", N)
4205 was used to print both 32- and 64-bit integers N, which relied on
4206 undefined behavior.
4207 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4208 New macro.
4209 * lisp.h (error, verror): Mark as printf-like functions.
4210 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4211 Report overflow in size calculations when allocating printf buffer.
4212 Do not truncate output string at its first null byte.
4213 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4214 Truncate the output at a character boundary, since vsnprintf does not
4215 do that.
4216 * charset.c (check_iso_charset_parameter): Convert internal
4217 character to string before calling 'error', since %c now has the
4218 printf meaning.
4219 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4220 overflow when computing char to be passed to 'error'. Do not
4221 pass Lisp_Object to 'error'; pass the integer instead.
4222 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4223 formatted with plain %d.
4224
b189fa66
PE
4225 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4226
bff87ef0
PE
4227 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4228
7e2cac20
PE
4229 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4230
ce4d90b5
PE
4231 * xterm.c (x_catch_errors): Remove duplicate declaration.
4232
266c9547
PE
4233 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4234
79c49ad2
PE
4235 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4236
368f4090
JM
42372011-04-10 Jim Meyering <meyering@redhat.com>
4238
4239 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4240 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4241 return ssize_t not "int", and use size_t as the buffer length.
4242 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4243 * gnutls.h: Update declarations.
4244 * process.c (read_process_output): Use ssize_t, to match.
4245 (send_process): Likewise.
4246
a32d4040
CY
42472011-04-09 Chong Yidong <cyd@stupidchicken.com>
4248
4249 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4250
8546720e 42512011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4252
04f2d78b
CB
4253 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4254 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4255
8546720e
GM
4256 * xterm.c (handle_one_xevent):
4257 * xmenu.c (create_and_show_popup_menu):
4258 * xselect.c (x_decline_selection_request)
4259 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4260
0a2f5c1a 42612011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4262
4263 Fix some uses of `int' instead of EMACS_INT.
4264 * search.c (string_match_1, fast_string_match)
4265 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4266 (scan_buffer, find_next_newline_no_quit)
4267 (find_before_next_newline, search_command, Freplace_match)
4268 (Fmatch_data): Make some `int' variables be EMACS_INT.
4269
4270 * xdisp.c (display_count_lines): 3rd argument and return value now
4271 EMACS_INT. All callers changed.
4272 (pint2hrstr): Last argument is now EMACS_INT.
4273
4274 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4275 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4276 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4277 (decode_coding_utf_16, decode_coding_emacs_mule)
4278 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4279 (decode_coding_ccl, decode_coding_charset)
4280 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4281 (decode_coding_iso_2022, decode_coding_emacs_mule)
4282 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4283 <char_offset, last_offset>: Declare EMACS_INT.
4284 (encode_coding_utf_8, encode_coding_utf_16)
4285 (encode_coding_emacs_mule, encode_invocation_designation)
4286 (encode_designation_at_bol, encode_coding_iso_2022)
4287 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4288 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4289 Declare EMACS_INT.
4290 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4291 (encode_invocation_designation): Last argument P_NCHARS is now
4292 EMACS_INT.
4293 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4294 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4295
4296 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4297 All users changed.
4298
4299 * ccl.c (Fccl_execute_on_string): Declare some variables
4300 EMACS_INT.
4301
8546720e 43022011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4303
4304 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4305
4e19a977
CS
43062011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4307
4308 * process.c (Fformat_network_address): Doc fix.
4309
87302331
R
43102011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4311
4312 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4313
cbb59342
CY
43142011-04-08 Chong Yidong <cyd@stupidchicken.com>
4315
4316 * keyboard.c (read_char): Call Lisp function help-form-show,
4317 instead of using internal_with_output_to_temp_buffer.
4318 (Qhelp_form_show): New var.
e0d38eeb 4319 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4320
4321 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4322
4323 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4324
e67a13ab
CY
43252011-04-06 Chong Yidong <cyd@stupidchicken.com>
4326
04f2d78b
CB
4327 * process.c (Flist_processes): Remove to Lisp.
4328 (list_processes_1): Delete.
e67a13ab 4329
973f782d
EZ
43302011-04-06 Eli Zaretskii <eliz@gnu.org>
4331
7c106b1e
EZ
4332 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4333
973f782d
EZ
4334 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4335
41cf7d1a 43362011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4337
ca23cc88
PE
4338 Fix more problems found by GCC 4.6.0's static checks.
4339
f390e2d5
PE
4340 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4341
42eea0d0
PE
4342 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4343
b69769da 4344 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4345
f9541e84
PE
4346 * xdisp.c (vmessage): Mark as a printf-like function.
4347
13841b55
PE
4348 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4349
c136c10f
PE
4350 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4351
5e2d4a30
PE
4352 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4353 printf-like functions.
4354 (tiff_load): Add casts to remove these marks before passing them
4355 to system-supplied API.
4356
583f48b9
PE
4357 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4358
b25d760e
PE
4359 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4360 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4361 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4362 directly, rather than having caller test rule sign. This avoids
4363 some unnecessary tests.
4364 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4365 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4366 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4367
bc7b6697 4368 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4369 (xfont_open): Avoid unnecessary tests.
bc7b6697 4370
27ccc379
PE
4371 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4372
dcd5c89a
PE
4373 * composite.h, composite.c (composition_gstring_put_cache):
4374 Use EMACS_INT, not int, for length.
4375
b13a45c6
PE
4376 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4377 breaking out part of COMPOSITION_DECODE_RULE.
4378 (COMPOSITION_DECODE_RULE): Use it.
4379 * composite.c (get_composition_id): Remove unused local vars,
4380 by using the new macro.
4381
1e792e4d
PE
4382 * textprop.c (set_text_properties_1): Change while to do-while,
4383 since the condition is always true at first.
4384
dc6c6455 4385 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4386 (interval_deletion_adjustment): Return unsigned value.
4387 All uses changed.
dc6c6455 4388
aba7731a
PE
4389 * process.c (list_processes_1, create_pty, read_process_output):
4390 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4391 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4392 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4393 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4394 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4395
fdfc4bf3
PE
4396 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4397
fca8fe46 4398 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4399 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4400
06a0259a 4401 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4402 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4403 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4404
e7b9e80f
PE
4405 * print.c (print_error_message): Avoid int overflow.
4406
56201685
PE
4407 * font.c (font_list_entities): Redo for clarity,
4408 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4409
78834453 4410 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4411 (font_score): Avoid potential overflow in diff calculation.
78834453 4412
0bc0b309 4413 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4414 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4415
e610eaca
PE
4416 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4417
b895abce
PE
4418 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4419 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4420 can always succeed if overflow has undefined behavior.
4421
1f1d9321 4422 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4423 (wordify): Omit three unnecessary tests.
1f1d9321 4424
c59478bc
PE
4425 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4426 All callers changed. This avoids the need for an unused var.
4427
79b73827
PE
4428 * casefiddle.c (casify_region): Remove var that is set but not used.
4429
a4db5dfe
PE
4430 * dired.c (file_name_completion): Remove var that is set but not used.
4431
43aae36e
PE
4432 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4433
2a47c44d 4434 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4435 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4436
a37c69bf
PE
4437 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4438 Check for integer overflow on size calculations.
4439
328ab8e7
PE
4440 * buffer.c (Fprevious_overlay_change): Remove var that is set
4441 but not used.
4442
e5a2a5cb
PE
4443 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4444 Remove vars that are set but not used.
8d84a6eb 4445 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4446 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4447
a60e5f68
PE
4448 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4449
f661cb61 4450 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4451 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4452
f0397f5a
PE
4453 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4454 that are set but not used.
4455
8664db06 4456 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4457 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4458
6abdaa4a
PE
4459 * xselect.c (x_get_local_selection, x_handle_property_notify):
4460 Remove vars that are set but not used.
4461
0ce7538d 4462 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4463 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4464
9ae848fc
PE
4465 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4466 Remove var that is set but not used.
0b918413
PE
4467 (scroll_bar_windows_size): Now size_t, not int.
4468 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4469 Check for overflow.
9ae848fc 4470
a5a62657
PE
4471 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4472 (map_tty_color) [!defined MSDOS]: Likewise.
4473
5c5cdd39
PE
4474 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4475
66ebf983
PE
4476 * coding.c: Remove vars that are set but not used.
4477 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4478 All callers changed.
4479 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4480 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4481 (decode_coding_charset): Remove vars that are set but not used.
4482
1be4d761
PE
4483 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4484 that is set but not used.
4485
47553fa8
PE
4486 * print.c (print_object): Remove var that is set but not used.
4487
1f7196bf 4488 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4489 The gnulib version avoids calling malloc in the usual case,
4490 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4491 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4492 * filelock.c (current_lock_owner): Likewise.
4493 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4494 * sysdep.c: Include allocator.h, careadlinkat.h.
4495 (emacs_no_realloc_allocator): New static constant.
4496 (emacs_readlink): New function.
fdb61804
PE
4497 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4498 ../lib/careadlinkat.h.
d1fdcab7 4499
f84c17c7
SM
45002011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4501
4502 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4503 first non-nil return value).
4504
ef3862ad
JD
45052011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4506
4507 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4508 if not defined (Bug#8403).
4509
376a7006
JB
45102011-04-02 Juanma Barranquero <lekktu@gmail.com>
4511
4512 * xdisp.c (display_count_lines): Remove parameter `start',
4513 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4514 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4515 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4516 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4517 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4518 and thereabouts. All callers changed.
4519 (get_per_char_metric): Remove parameter `f', unused since
4520 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4521
6ca3801d
JM
45222011-04-02 Jim Meyering <meyering@redhat.com>
4523
4524 do not dereference NULL upon failed strdup
4525 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4526 (ns_get_family): Likewise.
4527
d8e2b5ba
JB
45282011-04-02 Juanma Barranquero <lekktu@gmail.com>
4529
4530 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4531
8c74fcbd
JD
45322011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4533
4534 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4535 later (Bug#8403).
4536
7200d79c
SM
45372011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4538
03408648 4539 Add lexical binding.
7200d79c 4540
03408648
SM
4541 * window.c (Ftemp_output_buffer_show): New fun.
4542 (Fsave_window_excursion):
4543 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4544
4545 * lread.c (lisp_file_lexically_bound_p): New function.
4546 (Fload): Bind Qlexical_binding.
4547 (readevalloop): Remove `evalfun' arg.
4548 Bind Qinternal_interpreter_environment.
4549 (Feval_buffer): Bind Qlexical_binding.
4550 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4551 Mark as dynamic.
4552 (syms_of_lread): Declare `lexical-binding'.
4553
4554 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4555
4556 * keyboard.c (eval_dyn): New fun.
4557 (menu_item_eval_property): Use it.
ca105506
SM
4558
4559 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4560
03408648
SM
4561 * fns.c (concat, mapcar1): Accept byte-code-functions.
4562
4563 * eval.c (Fsetq): Handle lexical vars.
4564 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4565 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4566 (FletX, Flet): Obey lexical binding.
4567 (Fcommandp): Handle closures.
4568 (Feval): New `lexical' arg.
4569 (eval_sub): New function extracted from Feval. Use it almost
4570 everywhere where Feval was used. Look up vars in lexical env.
4571 Handle closures.
4572 (Ffunctionp): Move from subr.el.
4573 (Ffuncall): Handle closures.
4574 (apply_lambda): Remove `eval_flags'.
4575 (funcall_lambda): Handle closures and new byte-code-functions.
4576 (Fspecial_variable_p): New function.
4577 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4578 but without exporting it to Lisp.
23aba0ea 4579
23aba0ea 4580 * doc.c (Fdocumentation, store_function_docstring):
03408648 4581 * data.c (Finteractive_form): Handle closures.
23aba0ea 4582
03408648
SM
4583 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4584 interactive spec.
ba83908c 4585
04f2d78b
CB
4586 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4587 New byte-codes.
03408648
SM
4588 (exec_byte_code): New function extracted from Fbyte_code to handle new
4589 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4590
03408648 4591 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4592
03408648 4593 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4594
e2abce01
JB
45952011-03-31 Juanma Barranquero <lekktu@gmail.com>
4596
4597 * xdisp.c (redisplay_internal): Fix prototype.
4598
63696a73 45992011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4600
63696a73 4601 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4602 (try_scrolling): Use it when setting scroll_limit.
4603 Limit scrolling to 100 screen lines.
63696a73
EZ
4604 (redisplay_window): Even when falling back on "recentering",
4605 position point in the window according to scroll-conservatively,
4606 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4607
4608 (try_scrolling): When point is above the window, allow searching
4609 as far as scroll_max, or one screenful, to compute vertical
4610 distance from PT to the scroll margin position. This prevents
4611 try_scrolling from unnecessarily failing when
4612 scroll-conservatively is set to a value slightly larger than the
4613 window height. Clean up the case of PT below the margin at bottom
4614 of window: scroll_max can no longer be INT_MAX. When aggressive
4615 scrolling is in use, don't let point enter the opposite scroll
4616 margin as result of the scroll.
4617 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4618 threshold of 100 lines for never-recentering scrolling.
4619
e4cc2dfc
JB
46202011-03-31 Juanma Barranquero <lekktu@gmail.com>
4621
4622 * dispextern.h (move_it_by_lines):
4623 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4624 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4625 (message_log_check_duplicate): Remove parameters `prev_bol' and
4626 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4627 (redisplay_internal): Remove parameter `preserve_echo_area',
4628 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4629
4630 * indent.c (Fvertical_motion):
4631 * window.c (window_scroll_pixel_based, Frecenter):
4632 Don't pass `need_y_p' to `move_it_by_lines'.
4633
1c470562
SM
46342011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4635
44f230aa
SM
4636 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4637 steal a few bits to be more compact.
4638 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4639 Remove unneeded casts.
4640
1c470562
SM
4641 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4642
888adce9
ZK
46432011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4644
4645 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4646 binding" message (bug#7967).
4647
f838ed7b
PE
46482011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4649
77861b95
PE
4650 Fix more problems found by GCC 4.6.0's static checks.
4651
de6dbc14
PE
4652 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4653 Remove unused local var.
4654
f838ed7b
PE
4655 * editfns.c (Fmessage_box): Remove unused local var.
4656
792c7b2b
PE
4657 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4658 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4659 Omit unused local vars.
c499e557 4660 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4661 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4662 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4663 Omit unused local var.
4664
ba0165e1
PE
4665 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4666 Don't assume string length fits in int.
32ad8845 4667 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4668 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4669
3c59b4c9
PE
4670 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4671 instead of alloca (Bug#8344).
4672
a3eed478 4673 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4674 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4675
eb4d412d
PE
4676 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4677
1658b401
PE
4678 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4679 concerns.
4680
4681 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4682
4683 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4684
9a2c6e05
PE
4685 * keyboard.c (syms_of_keyboard): Use the same style as later
4686 in this function when indexing through an array. This also
4687 works around GCC bug 48267.
4688
03d0a109
PE
4689 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4690
44f730c8
PE
4691 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4692
fe75f926
PE
4693 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4694 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4695
ffa8c828
PE
4696 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4697 This avoids undefined behavior on integer overflow, and is a bit
4698 more convenient anyway since it is compared to a size_t variable.
4699
c5101a77
PE
4700 Variadic C functions now count arguments with size_t, not int.
4701 This avoids an unnecessary limitation on 64-bit machines, which
4702 caused (substring ...) to crash on large vectors (Bug#8344).
4703 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4704 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4705 All variadic functions and their callers changed accordingly.
c5101a77
PE
4706 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4707 * data.c (arith_driver, float_arith_driver): Likewise.
4708 * editfns.c (general_insert_function): Likewise.
4709 * eval.c (struct backtrace.nargs, interactive_p)
4710 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4711 (funcall_lambda, mark_backtrace): Likewise.
4712 * fns.c (concat): Likewise.
4713 * frame.c (x_set_frame_parameters): Likewise.
4714 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4715 0 if not found, not -1. All callers changed.
4716
dd3f25f7
PE
4717 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4718 (stack_copy_size): Now size_t, not int.
4719 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4720
461c2ab9
JB
47212011-03-28 Juanma Barranquero <lekktu@gmail.com>
4722
4723 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4724 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4725 All callers changed.
4726
4727 * lisp.h (multibyte_char_to_unibyte):
4728 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4729 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4730 * character.h (CHAR_TO_BYTE8):
4731 * cmds.c (internal_self_insert):
4732 * editfns.c (general_insert_function):
4733 * keymap.c (push_key_description):
4734 * search.c (Freplace_match):
4735 * xdisp.c (message_dolog, set_message_1): All callers changed.
4736
f6d62986
SM
47372011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4738
4739 * keyboard.c (safe_run_hook_funcall): New function.
4740 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4741 don't set the hook to nil, but remove the offending function instead.
4742 (Qcommand_hook_internal): Remove, unused.
4743 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4744 Vcommand_hook_internal.
4745
4746 * eval.c (enum run_hooks_condition): Remove.
4747 (funcall_nil, funcall_not): New functions.
4748 (run_hook_with_args): Call each function through a `funcall' argument.
4749 Remove `cond' argument, now redundant.
4750 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4751 (Frun_hook_with_args_until_failure): Adjust accordingly.
4752 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4753
1db5b1ad
JB
47542011-03-28 Juanma Barranquero <lekktu@gmail.com>
4755
4756 * dispextern.h (string_buffer_position): Remove declaration.
4757
4758 * print.c (strout): Remove parameter `multibyte', unused since
4759 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4760
4761 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4762 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4763 All callers changed.
4764
4765 * w32.c (_wsa_errlist): Use braces for struct initializers.
4766
4767 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4768 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4769 All callers changed.
4770 (string_buffer_position): Likewise. Also, make static (it's never
4771 used outside xdisp.c).
4772 (cursor_row_p): Remove parameter `w', unused since
4773 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4774 (decode_mode_spec): Remove parameter `precision', introduced during
4775 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4776 All callers changed.
4777
5ffb62aa
JD
47782011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4779
4780 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4781
461c2ab9 47822011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4783
4784 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4785 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4786 (ns_update_auto_hide_menu_bar): New functions.
4787 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4788 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4789 ns_constrain_all_frames.
4790 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4791 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4792
5c380ffb
JD
47932011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4794
4795 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4796
9af30bdf
GM
47972011-03-27 Glenn Morris <rgm@gnu.org>
4798
4799 * syssignal.h: Replace RETSIGTYPE with void.
4800 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4801 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4802 Replace SIGTYPE with void everywhere.
4803 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4804 * s/template.h (SIGTYPE): Remove commented out definition.
4805
e2abce01
JB
48062011-03-26 Eli Zaretskii <eliz@gnu.org>
4807
4808 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4809 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4810
f868cd8a
JB
48112011-03-26 Juanma Barranquero <lekktu@gmail.com>
4812
59eb0929
JB
4813 * w32.c (read_unc_volume): Use parameter `henum', instead of
4814 global variable `wget_enum_handle'.
4815
4816 * keymap.c (describe_vector): Remove parameters `indices' and
4817 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4818 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4819
f868cd8a
JB
4820 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4821
4822 * keyboard.c (timer_check): Remove parameter `do_it_now',
4823 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4824 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4825 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4826
4827 * keyboard.c (read_char):
4828 * w32menu.c (w32_menu_display_help):
4829 * xmenu.c (show_help_event, menu_help_callback):
4830 Adjust calls to `show_help_echo'.
4831
4832 * gtkutil.c (xg_maybe_add_timer):
4833 * keyboard.c (readable_events):
4834 * process.c (wait_reading_process_output):
4835 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4836
4837 * insdel.c (adjust_markers_gap_motion):
4838 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4839 (gap_left, gap_right): Don't call it.
4840
2ecf6fdb
CY
48412011-03-25 Chong Yidong <cyd@stupidchicken.com>
4842
4843 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4844 incurred during fontification.
4845
6b1f9ba4
JB
48462011-03-25 Juanma Barranquero <lekktu@gmail.com>
4847
4848 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4849 (DEFVAR_PER_BUFFER): Don't pass it.
4850
4851 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4852 (scrolling_window): Don't pass it.
4853
0f4a96b5
JB
48542011-03-25 Juanma Barranquero <lekktu@gmail.com>
4855
4856 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4857
4858 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4859 and `suffix'.
4860 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4861 of variables specific to SELinux and computation of `encoded_absname'.
4862
4863 * image.c (XPutPixel): Remove unused variable `height'.
4864
4865 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4866
4867 * unexw32.c (get_section_info): Remove unused variable `section'.
4868
4869 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4870 (system_process_attributes): Remove unused variable `sess'.
4871 (sys_read): Remove unused variable `err'.
4872
4873 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4874 (w32_wnd_proc): Remove unused variable `isdead'.
4875 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4876 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4877 (x_create_tip_frame): Remove unused variable `tem'.
4878
4879 * w32inevt.c (w32_console_read_socket):
4880 Remove unused variable `no_events'.
4881
4882 * w32term.c (x_draw_composite_glyph_string_foreground):
4883 Remove unused variable `width'.
4884
1149507c
JB
48852011-03-24 Juanma Barranquero <lekktu@gmail.com>
4886
4887 * w32term.c (x_set_glyph_string_clipping):
4888 Don't pass uninitialized region to CombineRgn.
4889
9c88f339
JB
48902011-03-23 Juanma Barranquero <lekktu@gmail.com>
4891
4892 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4893 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4894 (Fx_close_connection): Remove unused variable `i'.
4895
4896 * w32font.c (w32font_draw): Return number of glyphs.
4897 (w32font_open_internal): Remove unused variable `i'.
4898 (w32font_driver): Add missing initializer.
4899
4900 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4901 (fill_in_menu): Remove unused variable `items_added'.
4902
4903 * w32term.c (last_mouse_press_frame): Remove static global variable.
4904 (w32_clip_to_row): Remove unused variable `f'.
4905 (x_delete_terminal): Remove unused variable `i'.
4906
4907 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4908 (NOTHING): Remove unused static global variable.
4909 (uniscribe_check_otf): Remove unused variable `table'.
4910 (uniscribe_font_driver): Add missing initializers.
4911
dee091a3
JD
49122011-03-23 Julien Danjou <julien@danjou.info>
4913
4914 * term.c (Fsuspend_tty, Fresume_tty):
4915 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4916 * window.c (temp_output_buffer_show):
4917 * insdel.c (signal_before_change):
4918 * frame.c (Fhandle_switch_frame):
4919 * fileio.c (Fdo_auto_save):
4920 * emacs.c (Fkill_emacs):
4921 * editfns.c (save_excursion_restore):
4922 * cmds.c (internal_self_insert):
4923 * callint.c (Fcall_interactively):
4924 * buffer.c (Fkill_all_local_variables):
4925 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4926 Use Frun_hooks.
0f4a96b5 4927 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4928 unconditionnaly since it does the check itself.
4929
2c520ab5 49302011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4931
c9c49752
PE
4932 Fix more problems found by GCC 4.5.2's static checks.
4933
8abc3f12
PE
4934 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4935 the first time through the loop, since we know p0 < p1 then.
4936 This also avoids a gcc -Wstrict-overflow warning.
4937
a2d26660
PE
4938 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4939 leading to a memory leak, possible in functions like
4940 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4941 of objects (Bug#8318).
a2d26660 4942
916c72e9
PE
4943 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4944 that could (at least in theory) be that large.
4945
19ab8a18
PE
4946 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4947 This is less likely to overflow, and avoids undefined behavior if
4948 overflow does occur. All callers changed. Use strtoul to scan
4949 for the unsigned long integer.
b7cbbd6f
PE
4950 (pint2hrstr): Simplify and tune code slightly.
4951 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4952
f0641eff
PE
4953 * scroll.c (do_scrolling): Work around GCC bug 48228.
4954 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4955
7f650bb9
PE
4956 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4957 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4958 (validate_x_resource_name): Simplify count usage.
4959 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4960
37dd57d1
PE
4961 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4962 fail (Bug#8306).
81e56e61 4963
699979fc 4964 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4965
401bf9b4
PE
4966 * process.c (Fmake_network_process): Use socklen_t, not int,
4967 where POSIX says socklen_t is required in portable programs.
4968 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4969 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4970 (Fmake_network_process, server_accept_connection):
4971 (wait_reading_process_output, read_process_output):
4972 Likewise.
4973
b93aacde
PE
4974 * process.c: Rename or move locals to avoid shadowing.
4975 (list_processes_1, Fmake_network_process):
4976 (read_process_output_error_handler, exec_sentinel_error_handler):
4977 Rename or move locals.
4dc343ee 4978 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4979 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4980 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4981 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4982 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4983
af8a867c 4984 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4985 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4986 Include tparam.h instead, since it declares them.
af8a867c
PE
4987 * cm.h (PC): Remove extern decl; tparam.h now does this.
4988 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4989 * terminfo.c: Include tparam.h, to check interfaces.
4990 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4991 (tparam): Adjust signature to match interface in tparam.h;
4992 this removes some undefined behavior. Check that outstring and len
4993 are zero, which they always are with Emacs.
4994 * tparam.h (PC, BC, UP): New extern decls.
4995
0248044d 4996 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4997 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4998
8ff096c1 4999 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5000 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5001 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5002 (ftfont_list): Remove unused local.
49eaafba
PE
5003 (get_adstyle_property, ftfont_pattern_entity):
5004 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5005 Rename locals to avoid shadowing.
8ff096c1 5006
e2be39f6
PE
5007 * xfont.c (xfont_list_family): Mark var as initialized.
5008
c9735e30
PE
5009 * xml.c (make_dom): Now static.
5010
8f5201ae
PE
5011 * composite.c (composition_compute_stop_pos): Rename local to
5012 avoid shadowing.
b246f932
PE
5013 (composition_reseat_it): Remove unused locals.
5014 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5015 (composition_update_it): Mark var as initialized.
11b61122
PE
5016 (find_automatic_composition): Mark vars as initialized,
5017 with a FIXME (Bug#8290).
8f5201ae 5018
760fbc2c
PE
5019 character.h: Rename locals to avoid shadowing.
5020 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5021 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5022 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5023 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5024 to avoid shadowing.
5025
ff08eb85
PE
5026 * textprop.c (property_change_between_p): Remove; unused.
5027
fc7bf025
PE
5028 * intervals.c (interval_start_pos): Now static.
5029
235d7abc
PE
5030 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5031
44f230aa
SM
5032 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5033 Rename locals to avoid shadowing.
3e7d6594 5034
50060332
PE
5035 * sound.c (wav_play, au_play, Fplay_sound_internal):
5036 Fix pointer signedness.
d01f234b 5037 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5038 (wav_play): Initialize a variable to 0, to prevent undefined
5039 behavior (Bug#8278).
50060332 5040
c4fc4e30
PE
5041 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5042
918436ed
PE
5043 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5044
c939f91b
PE
5045 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5046 clobbering (Bug#8298).
b9c7f648
PE
5047 * sysdep.c (sys_subshell): Likewise.
5048 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5049
6bd8c144
PE
5050 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5051 This should get cleaned up, so that child_setup has the
5052 same signature on all platforms.
5053
7710357c 5054 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5055 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5056
c59da222
CY
50572011-03-22 Chong Yidong <cyd@stupidchicken.com>
5058
5059 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5060 not to be necessary, and produces flickering.
5061
66b87493
GM
50622011-03-20 Glenn Morris <rgm@gnu.org>
5063
5064 * config.in: Remove file.
5065
45b6f6d5
JB
50662011-03-20 Juanma Barranquero <lekktu@gmail.com>
5067
5068 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5069 are now in src/globals.h.
5070 (syms_of_minibuf): Remove spurious & from previous change.
5071
3ec03f7e
LL
50722011-03-20 Leo <sdl.web@gmail.com>
5073
5074 * minibuf.c (completing-read-function): New variable.
5075 (completing-read-default): Rename from completing-read.
5076 (completing-read): Call completing-read-function.
5077
b14e3e21
CY
50782011-03-19 Juanma Barranquero <lekktu@gmail.com>
5079
5080 * xfaces.c (Fx_load_color_file):
5081 Read color file from absolute filename (bug#8250).
5082
f2b726e6
JB
50832011-03-19 Juanma Barranquero <lekktu@gmail.com>
5084
5085 * makefile.w32-in: Update dependencies.
5086
09f6ff02
EZ
50872011-03-17 Eli Zaretskii <eliz@gnu.org>
5088
5089 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5090
29a6015a
PE
50912011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5092
a3a6c54e
PE
5093 Fix more problems found by GCC 4.5.2's static checks.
5094
b766f867
PE
5095 * process.c (make_serial_process_unwind, send_process_trap):
5096 (sigchld_handler): Now static.
5097
be02381c
PE
5098 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5099 That way, the code declares only the vars that it needs.
5100 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5101 * s/cygwin.h (PTY_ITERATION): Likewise.
5102 * s/darwin.h (PTY_ITERATION): Likewise.
5103 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5104
57048744
PE
5105 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5106 * process.c (allocate_pty): Don't declare stb unless it's needed.
5107
7914961c 5108 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5109 (CONSTANTLIM): Remove; unused.
5110 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5111 Define only if needed.
7914961c 5112
b3967b18
PE
5113 * unexelf.c (unexec): Name an expression,
5114 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5115 Use a different way to cause a compilation error if anyone uses
5116 n rather than nn, a way that does not involve shadowing.
73366a00 5117 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5118
29a6015a
PE
5119 * deps.mk (unexalpha.o): Remove; unused.
5120
43cfc33e 5121 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5122 * unexec.h: New file.
ce701a33
PE
5123 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5124 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5125 Depend on unexec.h.
5126 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5127 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5128 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5129 Change as necessary to match prototype in unexec.h.
ce701a33 5130
01f44d5a
PE
5131 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5132 shadowing.
4f63c6bb 5133 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5134
a6670b0b
PE
5135 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5136 Rename locals to avoid shadowing.
5137
cef2010d 5138 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5139 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5140
d4d7173a
PE
5141 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5142
f08b802a
PE
5143 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5144 warning when compiling print.c.
5145
3ddb0639
PE
5146 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5147 instead of using an uninitialized var.
5ad03b97 5148 (font_sort_entities): Mark var as initialized.
3ddb0639 5149
170a2692
PE
5150 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5151
e663c700
PE
5152 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5153 pointers to constants.
89bc529a 5154 (font_parse_fcname): Remove unused vars.
7b81e2d0 5155 (font_delete_unmatched): Now static.
ea838e10 5156 (font_get_spec): Remove; unused.
13a547c6
PE
5157 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5158 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5159 Rename or move locals to avoid shadowing.
e663c700 5160
2a80c887 5161 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5162 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5163
1384fa33 5164 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5165 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5166
8b2c52e9
PE
5167 * alloc.c (mark_backtrace): Move decl from here ...
5168 * lisp.h: ... to here, so that it can be checked.
5169
475545b5 5170 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5171 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5172 (lisp_indirect_variable): Name an expression,
5173 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5174 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5175
b1349114 5176 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5177 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5178 Use const pointer when appropriate.
b1349114 5179
a2928364
PE
5180 * lisp.h (get_system_name, get_operating_system_release):
5181 Move decls here, to check interfaces.
5182 * process.c (get_operating_system_release): Move decl to lisp.h.
5183 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5184 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5185 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5186 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5187 (Fformat_time_string, Fencode_time, Finsert_char):
5188 (Ftranslate_region_internal, Fformat):
5189 Rename or remove local vars to avoid shadowing.
9710023e 5190 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5191
a415e694
PE
5192 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5193 avoid shadowing.
5194
8ef4622d
PE
5195 * lisp.h (eassert): Check that the argument compiles, even if
5196 ENABLE_CHECKING is not defined.
5197
946f9a5b
PE
5198 * data.c (Findirect_variable): Name an expression, to avoid
5199 gcc -Wbad-function-cast warning.
112396d6 5200 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5201 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5202 (Fmake_variable_buffer_local, Fmake_local_variable):
5203 Mark variables as initialized.
52746918 5204 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5205
e5aab7e7 5206 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5207 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5208 Rename locals to avoid shadowing.
dff45157
PE
5209 (mark_stack): Move local variables into the #ifdef region where
5210 they're used.
7bc26fdb
PE
5211 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5212 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5213 needed otherwise.
5214 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5215 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5216 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5217
e5aab7e7
PE
5218 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5219 avoids undefined behavior in theory.
5220
4da60324
PE
5221 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5222
88043301
PE
5223 Use functions, not macros, for up- and down-casing (Bug#8254).
5224 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5225 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5226 to use the following functions instead of these macros.
5227 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5228 EMACS_INT, since callers assume the returned value fits in int.
5229 (upcase1): Likewise, for UPCASE_TABLE.
5230 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5231 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5232 the race-condition problem in the old DOWNCASE.
88043301 5233
19ed5445
PE
5234 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5235 Rename locals to avoid shadowing.
5236 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5237 (regex_compile, re_search_2, re_match_2_internal):
5238 Remove unused local vars.
952db0d7
PE
5239 (FREE_VAR): Rewrite so as not to use empty "else",
5240 which gcc can warn about.
da053e48 5241 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5242 (RETALLOC_IF): Define only if needed.
5243 (WORDCHAR_P): Likewise. This one is never needed, but is used
5244 only in a comment talking about a compiler bug, so put inside
5245 the #if 0 of that comment.
5246 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5247 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5248 Remove; unused.
19ed5445 5249
1f3561e4 5250 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5251 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5252 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5253
ded6f8f7
PE
5254 * search.c (simple_search): Remove unused var.
5255
dbd37a95
PE
5256 * dired.c (compile_pattern): Move decl from here ...
5257 * lisp.h: ... to here, so that it can be checked.
5258 (struct re_registers): New forward decl.
5259
7e47afad
PE
5260 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5261
85f24f61
PE
5262 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5263 All uses changed.
5264 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5265 Rename locals to avoid shadowing.
5671df8f 5266 (Fvertical_motion): Mark locals as initialized.
85f24f61 5267
181aa2be 5268 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5269 (casify_region): Mark local as initialized.
181aa2be 5270
930d429c
PE
5271 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5272
7082eac6
PE
5273 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5274 New macros, so that the caller can use some names other than
5275 gcpro1, gcpro2, etc.
5276 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5277 of the new macros.
5278 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5279 argument, for consistency with GCPRO2_VAR, etc: it is now the
5280 prefix of the variable, not the variable itself. All uses
5281 changed.
38b2c076
PE
5282 * dired.c (directory_files_internal, file_name_completion):
5283 Rename locals to avoid shadowing.
5284
15206ed9
PE
5285 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5286 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5287 dired.c's scmp function, had undefined behavior.
5288 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5289 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5290 * buffer.h: ... to here, because these macros use current_buffer,
5291 and the new implementation with inline functions needs to have
5292 current_buffer in scope now, rather than later when the macros
5293 are used.
5294 (downcase, upcase1): New static inline functions.
5295 (DOWNCASE, UPCASE1): Reimplement using these functions.
5296 This avoids undefined behavior in expressions like
5297 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5298 from race conditions in accessing the global variables
5299 case_temp1 and case_temp2.
5300 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5301 * lisp.h (case_temp1, case_temp2): Remove their decls.
5302 * character.h (ASCII_CHAR_P): Move from here ...
5303 * lisp.h: ... to here, so that the inline functions mentioned
5304 above can use them.
5305
4a6bea26
PE
5306 * dired.c (directory_files_internal_unwind): Now static.
5307
f14b7e14
PE
5308 * fileio.c (file_name_as_directory, directory_file_name):
5309 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5310 Now static.
2893f146
PE
5311 (file_name_as_directory): Use const pointers when appropriate.
5312 (Fexpand_file_name): Likewise. In particular, newdir might
5313 point at constant storage, so make it a const pointer.
fd4ead52 5314 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5315 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5316 signedness issues.
f839df0c
PE
5317 (Fset_file_times, Finsert_file_contents, auto_save_error):
5318 Rename locals to avoid shadowing.
f14b7e14 5319
5716756e 5320 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5321 (Ftry_completion, Fall_completions): Rename or remove locals
5322 to avoid shadowing.
5716756e 5323
b4c3046a
PE
5324 * marker.c (bytepos_to_charpos): Remove; unused.
5325
b45db522
PE
5326 * lisp.h (verify_bytepos, count_markers): New decls,
5327 so that gcc does not warn that these functions aren't declared.
5328
85876d07
PE
5329 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5330 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5331 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5332 (copy_text): Remove unused local var.
85876d07 5333
03d78a21 5334 * filelock.c (within_one_second): Now static.
b3dd38ab 5335 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5336
5df8f01b
PE
5337 * buffer.c (fix_overlays_before): Mark locals as initialized.
5338 (fix_start_end_in_overlays): Likewise. This function should be
5339 simplified by using pointers-to-pointers, but that's a different
5340 matter.
b1d876f1 5341 (switch_to_buffer_1): Now static.
8f54f30a
PE
5342 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5343 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5344
a70072c9 5345 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5346 Fix pointer signedness issue.
edced198
PE
5347 (sys_subshell): Mark local as volatile if checking for lint,
5348 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5349 (MAXPATHLEN): Define only if needed.
a70072c9 5350
a0977c44
PE
5351 * process.c (serial_open, serial_configure): Move decls from here ...
5352 * systty.h: ... to here, so that they can be checked.
5353
a884fdcc
PE
5354 * fns.c (get_random, seed_random): Move extern decls from here ...
5355 * lisp.h: ... to here, so that they can be checked.
5356
604efe86 5357 * sysdep.c (reset_io): Now static.
b8950c94 5358 (wait_for_termination_signal): Remove; unused.
604efe86 5359
38fc62d9
PE
5360 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5361 (copy_keymap_item, append_key, push_text_char_description):
5362 Now static.
1004a21a 5363 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5364 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5365 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5366 (describe_map_tree):
5367 Rename locals to avoid shadowing.
38fc62d9 5368
2f2650da
PE
5369 * keyboard.c: Declare functions static if they are not used elsewhere.
5370 (echo_char, echo_dash, cmd_error, top_level_2):
5371 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5372 (read_char, kbd_buffer_get_event, make_lispy_position):
5373 (make_lispy_event, make_lispy_movement, apply_modifiers):
5374 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5375 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5376 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5377 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5378 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5379
a053e86c 5380 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5381 (mark_kboards): Move decl here ...
5382 * alloc.c (mark_kboards): ... from here.
a053e86c 5383
4752793e
PE
5384 * lisp.h (force_auto_save_soon): New decl.
5385
74f10ca7 5386 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5387 (DEFINE_DUMMY_FUNCTION): New macro.
5388 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5389 Use it.
c03cd23f
PE
5390 (main): Add casts to avoid warnings
5391 if GCC considers string literals to be constants.
74f10ca7 5392
022e70d4
PE
5393 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5394
59d6fe83
PE
5395 * dbusbind.c: Pointer signedness fixes.
5396 (xd_signature, xd_append_arg, xd_initialize):
5397 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5398 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5399 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5400 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5401
78320123
PE
5402 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5403 if GCC considers string literals to be constants.
49cebcca 5404 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5405
35ac2a97
SM
54062011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5407
fb103ca9
SM
5408 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5409 (print_preprocess, print_object): New macro to fix last change.
5410
35ac2a97
SM
5411 * print.c (print_preprocess): Don't forget font objects.
5412
62973b41
JB
54132011-03-16 Juanma Barranquero <lekktu@gmail.com>
5414
5415 * emacs.c (USAGE3): Doc fixes.
5416
0e48bb22
AS
54172011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5418
5419 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5420 structure.
5421
7684e57b
JB
54222011-03-14 Juanma Barranquero <lekktu@gmail.com>
5423
5424 * lisp.h (VWindow_system, Qfile_name_history):
5425 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5426 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5427 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5428
5429 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5430 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5431
5432 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5433 * w32console.c (detect_input_pending, read_input_pending)
5434 (encode_terminal_code):
5435 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5436 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5437 (w32_system_caret_y, Qfile_name_history):
5438 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5439 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5440 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5441 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5442 * w32proc.c (Qlocal, report_file_error):
5443 * w32term.c (Vwindow_system, updating_frame):
5444 * w32uniscribe.c (initialized, uniscribe_font_driver):
5445 Remove unneeded extern declarations.
5446
2aa46d6c
CY
54472011-03-14 Chong Yidong <cyd@stupidchicken.com>
5448
c96bbc66 5449 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5450
cffc6f3b
CY
54512011-03-13 Chong Yidong <cyd@stupidchicken.com>
5452
5453 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5454 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5455 These macros can no longer be used for assignment.
5456
44f230aa
SM
5457 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5458 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5459 (record_buffer_markers, fetch_buffer_markers): New functions for
5460 recording and fetching special buffer markers.
5461 (set_buffer_internal_1, set_buffer_temp): Use them.
5462
5463 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5464
5465 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5466
5467 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5468 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5469
5470 * xdisp.c (hscroll_window_tree):
5471 (reconsider_clip_changes): Use PT instead of BUF_PT.
5472
d251f04b
EZ
54732011-03-13 Eli Zaretskii <eliz@gnu.org>
5474
5475 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5476 $(EMACS_ROOT)/lib/intprops.h.
5477
f0c77cd1
PE
54782011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5479
3eca4629
PE
5480 Fix more problems found by GCC 4.5.2's static checks.
5481
7c86ee98
PE
5482 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5483 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5484 (xg_free_frame_widgets): Make it clear that a local variable is
5485 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5486 (gdk_window_get_screen): Make it clear that this macro is needed
5487 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5488 (int_gtk_range_get_value): New function, which avoids a diagnostic
5489 from gcc -Wbad-function-cast.
5490 (xg_set_toolkit_scroll_bar_thumb): Use it.
5491 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5492 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5493 (get_utf8_string, xg_get_file_with_chooser):
5494 Rename locals to avoid shadowing.
5495 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5496
41729b81
PE
5497 * xgselect.c (xg_select): Remove unused var.
5498
f0c77cd1
PE
5499 * image.c (four_corners_best): Mark locals as initialized.
5500 (gif_load): Initialize transparent_p to zero (Bug#8238).
5501 Mark another local as initialized.
ec6cf4c6 5502 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5503
ce0ad53d 5504 * image.c (clear_image_cache): Now static.
d5d5a617 5505 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5506 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5507 (x_edge_detection): Remove unnecessary cast that
5508 gcc -Wbad-function-cast diagnoses.
2037898d 5509 (gif_load): Fix pointer signedness.
6ae141d6
PE
5510 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5511 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5512
33383987 55132011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5514
d32df629
PE
5515 Improve quality of tests for time stamp overflow.
5516 For example, without this patch (encode-time 0 0 0 1 1
5517 1152921504606846976) returns the obviously-bogus value (-948597
5518 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5519 reports time overflow. See
5520 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5521 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5522 * editfns.c: Include limits.h and intprops.h.
5523 (TIME_T_MIN, TIME_T_MAX): New macros.
5524 (time_overflow): Move earlier, to before first use.
5525 (hi_time, lo_time): New functions, for an accurate test for
5526 out-of-range times.
5527 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5528 (Fget_internal_run_time): Don't assume time_t fits in int.
5529 (make_time): Use list2 instead of Fcons twice.
5530 (Fdecode_time): More accurate test for out-of-range times.
5531 (check_tm_member): New function.
5532 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5533 (lisp_time_argument): Don't rely on undefined left-shift and
5534 right-shift behavior when checking for time stamp overflow.
8be6f318 5535
fe31d94c
PE
5536 * editfns.c (time_overflow): New function, refactoring common code.
5537 (Fformat_time_string, Fdecode_time, Fencode_time):
5538 (Fcurrent_time_string): Use it.
5539
8be6f318
PE
5540 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5541 * dired.c (make_time): Move to ...
5542 * editfns.c (make_time): ... here.
5543 * systime.h: Note the move.
5544
09d9db2c 55452011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5546
126bc0dc
YM
5547 * fringe.c (update_window_fringes): Remove unused variables.
5548
c47cbdfd
YM
5549 * unexmacosx.c (copy_data_segment): Also copy __got section.
5550 (Bug#8223)
5551
7ac80be9
EZ
55522011-03-12 Eli Zaretskii <eliz@gnu.org>
5553
c96bbc66 5554 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5555 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5556 Constify `char *' arguments and their references according to
5557 prototypes in tparam.h.
5558
ecb0f94d 5559 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5560
7ac80be9
EZ
5561 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5562 Adapt all references accordingly.
5563
5564 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5565
ef1fd07e
TT
55662011-03-11 Tom Tromey <tromey@redhat.com>
5567
5568 * buffer.c (syms_of_buffer): Remove obsolete comment.
5569
7ef4b50c
EZ
55702011-03-11 Eli Zaretskii <eliz@gnu.org>
5571
5572 * termhooks.h (encode_terminal_code): Declare prototype.
5573
5574 * msdos.c (encode_terminal_code): Don't declare prototype.
5575
5576 * term.c (encode_terminal_code): Now external again, used by
5577 w32console.c and msdos.c.
5578
44f230aa
SM
5579 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5580 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5581
4b1ec863 55822011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5583
1714f52b 5584 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5585
4b1ec863
PE
5586 * fringe.c (update_window_fringes): Mark locals as initialized
5587 (Bug#8227).
5588 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5589
524c7aa6
PE
5590 * alloc.c (mark_fringe_data): Move decl from here ...
5591 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5592 to check its interface.
5593 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5594
a5c0af81 5595 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5596 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5597 (fontset_font): Mark local as initialized.
a9a06e0b 5598 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5599
b4716021
PE
5600 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5601
811e9bac 5602 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5603 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5604 (x_own_selection, Fx_disown_selection_internal): Rename locals
5605 to avoid shadowing.
5606 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5607
7e3ab302
PE
5608 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5609 so that the caller can use some name other than gcpro1.
5610 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5611 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5612 (Fx_backspace_delete_keys_p):
5613 Use them to avoid shadowing, and rename vars to avoid shadowing.
5614 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5615 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5616 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5617 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5618 Remove unused locals.
7e3ab302
PE
5619 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5620 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5621 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5622 macros.
f78faa98 5623
e2b13473
PE
5624 * xterm.h (x_mouse_leave): New decl.
5625
77f23912
PE
5626 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5627 Remove unused functions.
cdf4ba58
PE
5628 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5629 (x_calc_absolute_position): Now static.
7411c686 5630 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5631 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5632 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5633 unless they are used.
38d0b34a
PE
5634 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5635 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5636 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5637 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5638 (x_error_catcher, x_connection_closed, x_error_handler):
5639 (x_error_quitter, xembed_send_message, x_iconify_frame):
5640 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5641 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5642 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5643
44f230aa
SM
5644 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5645 Rename or move locals to avoid shadowing.
6b463e58 5646 (tty_defined_color, merge_face_heights): Now static.
5967d051 5647 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5648 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5649 does not deduce is never used uninitialized.
73719eba
PE
5650 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5651 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5652
426994c3 5653 * terminal.c (store_terminal_param): Now static.
5489860b 5654
032f1620 5655 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5656 (set_frame_menubar): Remove unused local.
d4323972 5657 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5658 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5659 since they might point to immutable storage.
281585b0
PE
5660 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5661 since it's unused otherwise.
032f1620 5662
367c19e5 5663 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5664 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5665 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5666 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5667 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5668 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5669 does not deduce are never used uninitialized.
70739cbe 5670
07b48fa9
PE
5671 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5672
8868a238 5673 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5674 * window.c (window_loop, size_window):
5675 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5676
7e5cf297 5677 * window.c (display_buffer): Now static.
d6550a9f
PE
5678 (size_window): Mark variables that gcc -Wuninitialized
5679 does not deduce are never used uninitialized.
a586633d
PE
5680 * window.h (check_all_windows): New decl, to forestall
5681 gcc -Wmissing-prototypes diagnostic.
5b555da1 5682 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5683
f6095868
PE
5684 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5685 shadowing.
5686 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5687 Include <limits.h>.
5688 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5689 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5690 (load_charset_map): Mark variables that gcc -Wuninitialized
5691 does not deduce are never used uninitialized.
53df7c11 5692 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5693
f38b440c
PE
5694 * coding.c (coding_set_source, coding_set_destination):
5695 Use "else { /* comment */ }" rather than "else /* comment */;"
5696 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5697 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5698 a block, when the outer 'i' will do.
5699 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5700 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5701 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5702 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5703 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5704 Rename locals to avoid shadowing.
5705 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5706 * coding.c (emacs_mule_char, encode_invocation_designation):
5707 Now static, since they're not used elsewhere.
413bb2db 5708 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5709 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5710 (decode_coding_emacs_mule): Mark variables that gcc
5711 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5712 (detect_coding_iso_2022): Initialize a local variable that might
5713 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5714 this initialization is needed. (Bug#8211)
5f58e762
PE
5715 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5716 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5717 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5718 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5719 Remove unused macros.
f38b440c 5720
232b38b9 5721 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5722 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5723 * character.c (string_count_byte8): Likewise.
232b38b9 5724
fb90da1b
PE
5725 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5726 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5727
fb93dbc2
PE
5728 * chartab.c (copy_sub_char_table): Now static, since it's not used
5729 elsewhere.
5c156ace
PE
5730 (sub_char_table_ref_and_range, char_table_ref_and_range):
5731 Rename locals to avoid shadowing.
bbcd0949 5732 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5733
7d3b3862 5734 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5735 (BIDI_BOB): Remove unused macro.
7d3b3862 5736
6be7d3da
PE
5737 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5738 deduce are never used uninitialized.
c2ed9c8b 5739 * term.c (encode_terminal_code): Likewise.
6be7d3da 5740
75f8807f 5741 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5742
50938595
PE
5743 * tparam.h: New file.
5744 * term.c, tparam.h: Include it.
5745 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5746 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5747 Move these decls to tparam.h, and make them agree with what
5748 is actually in tparam.c. The previous trick of using incompatible
5749 decls in different modules does not conform to the C standard.
5750 All callers of tparam changed to use tparam's actual API.
5751 * tparam.c (tparam1, tparam, tgoto):
5752 Use const pointers where appropriate.
5753
fbceeba2
PE
5754 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5755 * cm.h (struct cm): Likewise.
5756 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5757 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5758 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5759 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5760 (turn_on_face, init_tty): Likewise.
5761 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5762
7f3f1250
PE
5763 * term.c (term_mouse_position): Rename local to avoid shadowing.
5764
e6ca6543
PE
5765 * alloc.c (mark_ttys): Move decl from here ...
5766 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5767
c40f8d15
AS
57682011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5769
5770 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5771
cfe0661d
JB
57722011-03-09 Juanma Barranquero <lekktu@gmail.com>
5773
5774 * search.c (compile_pattern_1): Remove argument regp, unused since
5775 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5776 (compile_pattern): Don't pass it.
5777
0afb4571
J
57782011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5779
5780 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5781 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5782 for ! HAVE_GTK3.
5783 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5784
5785 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5786
5787 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5788 gdk_window_get_screen, gdk_window_get_geometry,
5789 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5790 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5791 (xg_get_pixbuf_from_pixmap): New function.
5792 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5793 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5794 Call xg_get_pixbuf_from_pixmap instead of
5795 gdk_pixbuf_get_from_drawable.
5796 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5797 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5798 (xg_check_special_colors): Use GtkStyleContext and its functions
5799 for HAVE_GTK3.
5800 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5801 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5802 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5803 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5804 Call gtk_widget_get_preferred_size.
0afb4571
J
5805 (xg_frame_resized): gdk_window_get_geometry only takes 5
5806 parameters.
44f230aa
SM
5807 (xg_win_to_widget, xg_event_is_for_menubar):
5808 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5809 (xg_set_widget_bg): New function.
5810 (delete_cb): New function.
895009e1 5811 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5812 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5813 (xg_set_background_color): Call xg_set_widget_bg.
5814 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5815 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5816 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5817 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5818 if ! HAVE_GTK3.
5819 (update_frame_tool_bar): Call gtk_widget_hide.
5820 (xg_initialize): Use GDK_KEY_g.
5821
5822 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5823 if ! HAVE_GTK3
5824 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5825
5826 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5827 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5828 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5829
1c2cc4ef
JB
58302011-03-08 Juanma Barranquero <lekktu@gmail.com>
5831
5832 * w32xfns.c (select_palette): Check success of RealizePalette against
5833 GDI_ERROR, not zero.
5834
33383987 5835See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5836
5837;; Local Variables:
5838;; coding: utf-8
aac0c6e3
MR
5839;; End:
5840
33383987 5841 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5842
5843 This file is part of GNU Emacs.
5844
5845 GNU Emacs is free software: you can redistribute it and/or modify
5846 it under the terms of the GNU General Public License as published by
5847 the Free Software Foundation, either version 3 of the License, or
5848 (at your option) any later version.
5849
5850 GNU Emacs is distributed in the hope that it will be useful,
5851 but WITHOUT ANY WARRANTY; without even the implied warranty of
5852 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5853 GNU General Public License for more details.
5854
5855 You should have received a copy of the GNU General Public License
5856 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.