Avoid the obsolete `assoc' package.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a8e7d6d7 12012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2
3 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4
a8e7d6d7 52012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
6
7 * xdisp.c (pos_visible_p): If the window start position is beyond
8 ZV, start the display from buffer beginning. Prevents assertion
9 violation in init_iterator when the minibuffer window is scrolled
10 via the scroll bar.
11
12 * window.c (window_scroll_pixel_based): Likewise.
13
a8e7d6d7 142012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
15
16 * keymap.c (where_is_internal): Doc fix (Bug#10872).
17
a8e7d6d7 182012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
19
20 * fileio.c (Fcopy_file, Fset_file_selinux_context):
21 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
22
a8e7d6d7 232012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685
EZ
24
25 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
26 overrun array limits of glyph row's used[] array. (Bug#11288)
27
1c6900d9
EZ
282012-04-26 Eli Zaretskii <eliz@gnu.org>
29
4c3fa1d9
EZ
30 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
31 display element, check also the underlying string or buffer
32 character. (Bug#11341)
33
1c6900d9
EZ
34 * w32menu.c: Include w32heap.h.
35 (add_menu_item): If the call to AppendMenuW (via
36 unicode_append_menu) fails, disable Unicode menus only if we are
37 running on Windows 9X/Me.
38
42bf8205
AS
392012-04-24 Andreas Schwab <schwab@linux-m68k.org>
40
41 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
42 (xgetint): Add missing shift for LSB tags.
43
b1bac16e
MR
442012-04-24 Martin Rudalics <rudalics@gmx.at>
45
46 * keyboard.c (read_char): Don't wipe echo area for select window
47 events: These might get delayed via `mouse-autoselect-window'
48 (Bug#11304).
49
d69621cc
JB
502012-04-24 Juanma Barranquero <lekktu@gmail.com>
51
52 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
53 manipulation of :loaded-from data.
54
02fd101b
JB
552012-04-23 Juanma Barranquero <lekktu@gmail.com>
56
57 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
58 now a cons (bug#11311).
59
888bec30
PE
602012-04-23 Paul Eggert <eggert@cs.ucla.edu>
61
89a438bd
PE
62 Do not create empty overlays with the evaporate property (Bug#9642).
63 * buffer.c (Fmove_overlay): Delete an evaporating overlay
64 if it becomes empty after its bounds are adjusted to fit within
65 its buffer. Without this fix, in a nonempty buffer (let ((o
66 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
67 yields an empty overlay that has the evaporate property, which is
68 not supposed to happen.
69
1068fe4d
PE
70 Fix minor GTK3 problems found by static checking.
71 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
72 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
73 (struct _EmacsFixedClass, emacs_fixed_get_type):
74 Move decls here from emacsgtkfixed.h, since they needn't be public.
75 (emacs_fixed_get_type): Now static.
76 (emacs_fixed_class_init): Omit unused local.
77 (emacs_fixed_child_type): Remove; unused.
78 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
79 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
80 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
81 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
82 (EMACS_FIXED_GET_CLASS): Remove; unused.
83 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
84
888bec30
PE
85 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
86 Problem reported by Juanma Barranquero for Windows -Wunused-function.
87
de85e130
PE
882012-04-22 Paul Eggert <eggert@cs.ucla.edu>
89
d0baac98
PE
90 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
91 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
92 (__malloc_size_t, __malloc_ptrdiff_t):
93 Remove. All uses removed, replaced by the definiens if needed,
94 since we can assume C89 or better now.
95 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
96 (protect_malloc_state, align, get_contiguous_space)
97 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
98 (malloc_atfork_handler_child, malloc_enable_thread)
99 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
100 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
101 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
102 (special_realloc, _realloc_internal_nolock, _realloc_internal)
103 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
104 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
105 Define using prototypes, not old style.
106 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
107 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
108 (align): Don't assume that signed integer overflow wraps around.
109 Omit unused local var.
110 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
111 (_free_internal_nolock, memalign, mallochook, reallochook):
112 Omit no-longer-needed casts.
113 (valloc): Use getpagesize, not __getpagesize.
114 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
115 (struct hdr): The 'magic' member is now size_t, not unsigned long.
116
de85e130
PE
117 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
118
dcbf5805
MA
1192012-04-22 Michael Albinus <michael.albinus@gmx.de>
120
121 Move functions from C to Lisp. Make non-blocking method calls
122 the default. Implement further D-Bus standard interfaces.
123
124 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
125 (QCdbus_request_name_allow_replacement)
126 (QCdbus_request_name_replace_existing)
127 (QCdbus_request_name_do_not_queue)
128 (QCdbus_request_name_reply_primary_owner)
129 (QCdbus_request_name_reply_in_queue)
130 (QCdbus_request_name_reply_exists)
131 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
132 (QCdbus_registered_serial, QCdbus_registered_method)
133 (QCdbus_registered_signal): New Lisp objects.
134 (XD_DEBUG_MESSAGE): Use sizeof.
135 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
136 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
137 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
138 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
139 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
140 (xd_signature, xd_append_arg): Allow float for integer types.
141 (xd_get_connection_references): New function.
142 (xd_get_connection_address): Rename from xd_initialize. Return
143 cached address.
144 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
145 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
146 level.
147 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
148 Return number of recounts.
149 (Fdbus_get_unique_name): Make stronger parameter check.
150 (Fdbus_message_internal): New defun.
151 (Fdbus_call_method, Fdbus_call_method_asynchronously)
152 (Fdbus_method_return_internal, Fdbus_method_error_internal)
153 (Fdbus_send_signal, Fdbus_register_service)
154 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
155 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
156 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
157 (Vdbus_compiled_version, Vdbus_runtime_version)
158 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
159 (Vdbus_message_type_method_return, Vdbus_message_type_error)
160 (Vdbus_message_type_signal): New defvars.
161 (Vdbus_registered_buses, Vdbus_registered_objects_table): Adapt
162 docstring.
163
52828e02
PE
1642012-04-22 Paul Eggert <eggert@cs.ucla.edu>
165
da05bc4c
PE
166 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
167 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
168 Do not assume ptrdiff_t is the same width as 'int'.
169
52828e02
PE
170 * alloc.c: Handle unusual debugging option combinations.
171 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
172 since the two debugging options are incompatible.
173 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
174 is defined.
175 (mem_init, mem_insert, mem_insert_fixup):
176 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
177 (NEED_MEM_INSERT): Remove; no longer needed.
178
f01769f9
LL
1792012-04-22 Leo Liu <sdl.web@gmail.com>
180
181 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
182
5790543d
PE
1832012-04-22 Paul Eggert <eggert@cs.ucla.edu>
184
185 * sysdep.c [__FreeBSD__]: Minor cleanups.
186 (list_system_processes, system_process_attributes) [__FreeBSD__]:
187 Use Emacs indenting style more consistently. Avoid some casts.
188 Use 'double' consistently rather than mixing 'float' and 'double'.
189
b91b7e4d
EW
1902012-04-21 Eduard Wiebe <usenet@pusto.de>
191
192 * sysdep.c (list_system_processes, system_process_attributes): Add
193 implementation for FreeBSD (Bug#5243).
194
6114eb15
AS
1952012-04-21 Andreas Schwab <schwab@linux-m68k.org>
196
197 * lisp.mk (lisp): Update.
198
2f38dff7
PE
1992012-04-20 Paul Eggert <eggert@cs.ucla.edu>
200
201 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
202 It is never used otherwise.
203
4ae29f89
SM
2042012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
205
206 * print.c (print_preprocess): Only check print_depth if print-circle
207 is nil.
208 (print_object): Check for cycles even when print-circle is nil and
209 print-gensym is t, but only check print_depth if print-circle is nil.
210
f30d612a
CY
2112012-04-20 Chong Yidong <cyd@gnu.org>
212
213 * process.c (wait_reading_process_output): If EIO occurs on a pty,
214 set the status to "failed" and ensure that sentinel is run.
215
c07a4c0b 2162012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
217
218 * process.c (Fset_process_inherit_coding_system_flag)
219 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 220 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 221
c07a4c0b 2222012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
223
224 * xdisp.c (string_buffer_position_lim): Limit starting position to
225 BEGV.
226 (set_cursor_from_row): If called for a mode-line or header-line
227 row, return zero immediately.
228 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
229 farther than the first row after the header line, if any.
230 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
231 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
232
c07a4c0b 2332012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 234
4ae29f89
SM
235 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
236 (bug#11238).
ad3a2b41 237
c07a4c0b 2382012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 2392012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
240
241 configure: new option --enable-gcc-warnings (Bug#11207)
242 * Makefile.in (C_WARNINGS_SWITCH): Remove.
243 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
244 (ALL_CFLAGS): Use new macros rather than old.
245 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
246 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
247 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
248 -Wunused-result, -Wunused-variable. This should go away once
249 the Emacs and Gnulib regex code is merged.
250 (xmalloc, xrealloc): Now static.
251
aba027e8
PE
2522012-04-17 Paul Eggert <eggert@cs.ucla.edu>
253
254 * dired.c (Fsystem_groups): Remove unused local.
255
e5a36063
GM
2562012-04-17 Glenn Morris <rgm@gnu.org>
257
258 * dired.c (Fsystem_users): Doc fix.
259
316411f0
DA
2602012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
261
262 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
263 (syms_of_dired): Add them.
264
9426aba4
PE
2652012-04-16 Paul Eggert <eggert@cs.ucla.edu>
266
b62a57be
PE
267 Fix minor alloc.c problems found by static checking.
268 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
269 New extern decls, to avoid calling undeclared functions.
270 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
271 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
272 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
273 (NEED_MEM_INSERT): New macro.
274 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 275 Remove one incorrect comment and fix another.
b62a57be 276
3539f31f
PE
277 Fix minor ralloc.c problems found by static checking.
278 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
279 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
280 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
281 (r_alloc_sbrk): Now static.
282
a041960a
PE
283 Improve ralloc.c interface checking.
284 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
285 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
286 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
287 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
288 [REL_ALLOC]: ... to here, to check interface.
289 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
290 Remove decls. This fixes an "It stinks!".
291
9426aba4
PE
292 * alloc.c (which_symbols): Fix alignment issue / type clash.
293
d55c12ed
AS
2942012-04-15 Andreas Schwab <schwab@linux-m68k.org>
295
296 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
297 (struct Lisp_Misc_Any): Likewise.
298 (struct Lisp_Free): Likewise.
299 * alloc.c (union aligned_Lisp_Symbol): Define.
300 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
301 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
302 (union aligned_Lisp_Misc): Define.
303 (MARKER_BLOCK_SIZE, struct marker_block): Use union
304 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 305 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 306
b948ce8b
PE
3072012-04-14 Paul Eggert <eggert@cs.ucla.edu>
308
309 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
310 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
311 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
312 * s/netbsd.h, s/sol2-6.h:
313 Remove definition of GC_MARK_STACK, since the default now works.
314 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
315 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
316 no longer the default.
317 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
318
35dc09a1 3192012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 320
35dc09a1
GM
321 * lread.c (lisp_file_lexically_bound_p):
322 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 323
35dc09a1
GM
3242012-04-14 Eli Zaretskii <eliz@gnu.org>
325
326 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
327 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
328
3292012-04-14 Jan Djärv <jan.h.d@swipnet.se>
330
331 * nsterm.m (constrainFrameRect): Always constrain when there is only
332 one screen (Bug#10962).
333
bcd86815
KB
3342012-04-13 Ken Brown <kbrown@cornell.edu>
335
336 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
337
c25df26e
RT
3382012-04-13 Reuben Thomas <rrt@sc3d.org>
339
340 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
341
0fc59f1e
DC
3422012-04-11 Daniel Colascione <dancol@dancol.org>
343
344 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
345 against is gone. It's better to use vfork now so that when Cygwin
346 gains a new, working vfork, we use it automatically (bug#10398).
347
de8c03dc
SM
3482012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
349
350 * window.c (save_window_save): Obey window-point-insertion-type.
351
2f097256
GM
3522012-04-11 Glenn Morris <rgm@gnu.org>
353
354 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
355
453b951e
SM
3562012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
357
358 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
359
75f1671a 3602012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
361
362 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
363 (force_quit_count): New var.
364 (handle_interrupt): Use it.
365
2a8ce227
JB
3662012-04-10 Juanma Barranquero <lekktu@gmail.com>
367
368 * w32.c (w32_delayed_load): Record the full path of the library
369 being loaded (bug#10424).
370
935396c0
GM
3712012-04-09 Glenn Morris <rgm@gnu.org>
372
05920a43
GM
373 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
374 not just in the obarray, before snarfing them. (Bug#11036)
375
935396c0
GM
376 * Makefile.in ($(leimdir)/leim-list.el):
377 Pass EMACS rather than BUILT_EMACS.
378
a18ecafa
TZ
3792012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
380
381 * process.c (make_process):
382 * process.h: Add integer `gnutls_handshakes_tried' member to
383 process struct.
384
6bbef4e5
JC
385 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
386 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
387
388 * gnutls.c (gnutls_log_function2i): Convenience log function.
389 (emacs_gnutls_read): Use new log functions,
390 `gnutls_handshakes_tried' process member, and
391 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
392 attempts per process (connection).
393
b4d3bc10
CY
3942012-04-09 Chong Yidong <cyd@gnu.org>
395
396 * eval.c (Fuser_variable_p, user_variable_p_eh)
397 (lisp_indirect_variable): Functions deleted.
398 (Fdefvar): Caller changed.
399
400 * callint.c (Finteractive, Fcall_interactively):
401 * minibuf.c (Fread_variable): Callers changed.
402
70f4d973
EZ
4032012-04-09 Eli Zaretskii <eliz@gnu.org>
404
405 * xdisp.c (set_cursor_from_row): If the display string appears in
406 the buffer at position that is closer to point than the position
407 after the display string, display the cursor on the first glyph of
408 the display string. Fixes cursor display when a 'display' text
409 property immediately follows invisible text. (Bug#11094)
410
cb3c2e3e
PE
4112012-04-09 Paul Eggert <eggert@cs.ucla.edu>
412
413 composite.c: use 'double' consistently
414 * composite.c (get_composition_id): Use 'double' consistently
415 instead of converting 'float' to 'double' and vice versa; this is
416 easier to understand and avoids a GCC warning.
417
fd06db5d
GM
4182012-04-09 Glenn Morris <rgm@gnu.org>
419
50fe702a
GM
420 * Makefile.in: Generate leim-list with bootstrap-emacs, in
421 preparation for dumping it with emacs. (Bug#4789)
422 (leimdir): New variable.
423 ($(leimdir)/leim-list.el): New rule.
424 (emacs$(EXEEXT)): Depend on leim-list.el.
425
fd06db5d
GM
426 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
427 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
428 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
429
55c131ee
AS
4302012-04-08 Andreas Schwab <schwab@linux-m68k.org>
431
432 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
433 proper alignment.
434
9209588f
JB
4352012-04-07 Juanma Barranquero <lekktu@gmail.com>
436
437 * xml.c (init_libxml2_functions) [WINDOWSNT]:
438 Remove unused local variable.
439
e3fb2efb
PE
4402012-04-07 Paul Eggert <eggert@cs.ucla.edu>
441
442 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
443 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
444 (mark_memory): Mark Lisp_Objects only if pointers might hide in
445 objects, as mark_maybe_pointer will catch them otherwise.
446 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
447 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
448
b5385551
PE
4492012-04-07 Paul Eggert <eggert@cs.ucla.edu>
450
451 Fix typo that broke non-Windows builds.
452 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
453
9078ead6
EZ
4542012-04-07 Eli Zaretskii <eliz@gnu.org>
455
456 Support building on MS-Windows with libxml2.
457
458 * makefile.w32-in (OBJ2): Add xml.$(O).
459 (GLOBAL_SOURCES): Add xml.c.
460 ($(BLD)/xml.$(O)): New dependency list.
461
462 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
463 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
464 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
465 [!WINDOWSNT]: New macros.
466 (init_libxml2_functions, libxml2_loaded_p): New functions.
467 (parse_region): Call fn_xmlCheckVersion instead of using the macro
468 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
469 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
470 Calls xmlCleanupParser only if libxml2 was loaded (or statically
471 linked in).
6bbef4e5
JC
472 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
473 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
474 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
475
476 * emacs.c: Don't include libxml/parser.h.
477 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
478 xmlCleanupParser directly.
479
480 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
481
3811fdf3
EZ
4822012-04-07 Eli Zaretskii <eliz@gnu.org>
483
484 * indent.c (Fvertical_motion): If there is a display string at
485 point, use it.vpos to compute how many lines to backtrack after
486 move_it_to point. (Bug#11133)
487
2f8e16b2
EZ
4882012-04-06 Eli Zaretskii <eliz@gnu.org>
489
490 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
491 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
492 about subtle differences between FETCH_CHAR* and STRING_CHAR*
493 macros related to unification of CJK characters. For the details,
494 see the discussion following the message here:
495 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
496
3d439cd1
CY
4972012-04-04 Chong Yidong <cyd@gnu.org>
498
499 * keyboard.c (Vdelayed_warnings_list): Doc fix.
500
8bc53d00
EZ
5012012-04-01 Eli Zaretskii <eliz@gnu.org>
502
503 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
504 instead of alloca. (Bug#11138)
505
3b0512a3
AS
5062012-04-01 Andreas Schwab <schwab@linux-m68k.org>
507
508 * w32menu.c (is_simple_dialog): Properly check lisp types.
509 (Bug#11141)
510
8427ddd2
EZ
5112012-03-31 Eli Zaretskii <eliz@gnu.org>
512
979022ef
EZ
513 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
514 position we get to after a call to move_it_to fails the
515 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
516 only if we wind up in a string from display property. (Bug#11063)
517
a6b1c7cc
EZ
518 * window.c (Fdelete_other_windows_internal): Invalidate the row
519 and column information about mouse highlight, so that redisplay
520 restores it after reallocating the glyph matrices. (Bug#7464)
521
8427ddd2
EZ
522 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
523 string comes from a `display' text property, use the buffer
524 position of that property as if we actually saw that position in
525 the row's glyphs.
697ba24b
EZ
526 (move_it_by_lines): Remove the assertion that
527 "it->current_x == 0 && it->hpos == 0" which can be legitimately
528 violated when there's a before-string at the beginning of a line.
529 (Bug#11063)
8427ddd2 530
65a0a738
EZ
5312012-03-30 Eli Zaretskii <eliz@gnu.org>
532
533 * xdisp.c (append_space_for_newline): If the default face was
534 remapped, use the remapped face for the appended newline.
535 (extend_face_to_end_of_line): Use the remapped default face for
536 extending the face to the end of the line.
537 (display_line): Call extend_face_to_end_of_line when the default
538 face was remapped. (Bug#11068)
539
581355cc
EZ
5402012-03-29 Eli Zaretskii <eliz@gnu.org>
541
542 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
543
e8fc049f
SM
5442012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
545
546 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
547
4fb9a543
GM
5482012-03-27 Glenn Morris <rgm@gnu.org>
549
550 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
551 Doc fixes.
552
679910f1
KH
5532012-03-26 Kenichi Handa <handa@m17n.org>
554
555 * dispextern.h (struct glyph): Fix previous change. Change the
556 bit length of glyphless.ch to 25 (Bug#11082).
557
90d49b7f
CY
5582012-03-26 Chong Yidong <cyd@gnu.org>
559
560 * keyboard.c (Vselection_inhibit_update_commands): New variable.
561 (command_loop_1): Use it; inhibit selection update for
562 handle-select-window too (Bug#8996).
563
f514f6f0
FP
5642012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
565
e8fc049f 566 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 567
bf43fa51
KH
5682012-03-25 Kenichi Handa <handa@m17n.org>
569
570 * dispextern.h (struct glyph): Change the bit length of
571 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
572
8a0c01dd
EZ
5732012-03-24 Eli Zaretskii <eliz@gnu.org>
574
575 * s/ms-w32.h (tzname): Include time.h before redirecting to
576 _tzname. Fixes the MSVC build. (Bug#9960)
577
7d1c3a76
AS
5782012-03-24 Andreas Schwab <schwab@linux-m68k.org>
579
8ed79523
AS
580 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
581 characters.
582
7d1c3a76
AS
583 * xterm.c (XTread_socket): Only modify handling_signal if
584 !SYNC_INPUT. (Bug#11080)
585
e99a9b8b
EZ
5862012-03-23 Eli Zaretskii <eliz@gnu.org>
587
588 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
589 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
590 when fetching a multibyte character consumes more bytes than
591 CHAR_BYTES returns, due to unification of CJK characters in
592 string_char. (Bug#11073)
593
5063c0e1
TN
5942012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
595
596 * process.c (wait_reading_process_output): Handle pty disconnect
597 by refraining from sending oneself a SIGCHLD (bug#10933).
598
9f851fbd
CY
5992012-03-22 Chong Yidong <cyd@gnu.org>
600
601 * dispextern.h (struct it): New member string_from_prefix_prop_p.
602
5063c0e1 603 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
604 Mark string as coming from a prefix property.
605 (handle_face_prop): Use default face for prefix strings (Bug#4281).
606 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
607
fb5b8aca
CY
6082012-03-21 Chong Yidong <cyd@gnu.org>
609
610 * xfaces.c (Vface_remapping_alist): Doc fix.
611
62356a1b
EZ
6122012-03-20 Eli Zaretskii <eliz@gnu.org>
613
614 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
615 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
616 Doc fixes.
62356a1b 617
025de85b
CY
6182012-03-20 Chong Yidong <cyd@gnu.org>
619
620 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
621 to reflect default non-nil value of redisplay-dont-pause.
622
4827f94e
KH
6232012-03-19 Kenichi Handa <handa@m17n.org>
624
625 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
626 it fit in a valid range (Bug#11003).
627
e50a24a2
EZ
6282012-03-18 Eli Zaretskii <eliz@gnu.org>
629
630 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
631 that is not from display property, accept the row as a "cursor
632 row" if one of the string's character has a non-nil `cursor'
633 property. Fixes cursor positioning when there are newlines in
634 overlay strings, e.g. in icomplete.el. (Bug#11035)
635
9af5ed87
PE
6362012-03-12 Paul Eggert <eggert@cs.ucla.edu>
637
638 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
639
d1f55f16
CY
6402012-03-12 Chong Yidong <cyd@gnu.org>
641
642 * eval.c (inhibit_lisp_code): Rename from
643 inhibit_window_configuration_change_hook; move from window.c.
644
645 * xfns.c (unwind_create_frame_1, Fx_create_frame):
646 * window.c (run_window_configuration_change_hook)
647 (syms_of_window): Callers changed.
648
66c5eebd
CY
6492012-03-11 Chong Yidong <cyd@gnu.org>
650
413df973
CY
651 * keymap.c (Fkey_description): Doc fix (Bug#9700).
652
66c5eebd
CY
653 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
654
1de11f56
CY
6552012-03-10 Chong Yidong <cyd@gnu.org>
656
657 * frame.c (other_visible_frames): Don't assume the selected frame
658 is visible (Bug#10955).
659
cae07000
SM
6602012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
661
662 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
663
89c94350
JD
6642012-03-08 Jan Djärv <jan.h.d@swipnet.se>
665
666 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
667 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
668 zero (Bug#10954).
669
999dd333
GM
6702012-03-03 Glenn Morris <rgm@gnu.org>
671
01a6dcc8 672 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 673
de0100f2
EZ
6742012-03-02 Eli Zaretskii <eliz@gnu.org>
675
676 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
677 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
678 (redisplay_window, next_element_from_string): Fix typos in
679 comments.
3e441275
EZ
680 (redisplay_window): Pass to move_it_vertically the margin in
681 pixels, not in screen lines.
de0100f2 682
96a72ee9
GM
6832012-03-02 Glenn Morris <rgm@gnu.org>
684
685 * buffer.c (buffer-list-update-hook): Doc fix.
686
312508d7
EZ
6872012-02-29 Eli Zaretskii <eliz@gnu.org>
688
689 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
690 push_it before setting up the iterator for the first overlay
691 string, even if we have an empty string loaded.
692 (next_overlay_string): If there's an empty string on the iterator
693 stack, pop the stack. (Bug#10903)
694
27f3c637
PE
6952012-02-25 Paul Eggert <eggert@cs.ucla.edu>
696
697 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
698 Suggested by Stefan Monnier in
699 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
700 * alloc.c (widen_to_Lisp_Object): New static function.
701 (mark_memory): Also mark Lisp_Objects by fetching pointer words
702 and widening them to Lisp_Objects. This would work even if
703 USE_LSB_TAG is defined and wide integers are used, which might
704 happen in a future version of Emacs.
705
3c9dfce6
CY
7062012-02-25 Chong Yidong <cyd@gnu.org>
707
fa74b241
CY
708 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
709 Doc fix.
710
3c9dfce6
CY
711 * xselect.c (Fx_selection_exists_p): Doc fix.
712 (x_clipboard_manager_save_all): Print an informative message
713 before saving to clipboard manager.
714
9486df08
CY
7152012-02-24 Chong Yidong <cyd@gnu.org>
716
717 * keyboard.c (process_special_events): Handle all X selection
718 requests in kbd_buffer, not just the next one (Bug#8869).
719
f01d3321
CY
7202012-02-23 Chong Yidong <cyd@gnu.org>
721
722 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
723 call when setting menu-bar-lines and tool-bar-lines parameters.
724 (unwind_create_frame_1): New helper function.
725
726 * window.c (inhibit_window_configuration_change_hook): New var.
727 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 728 (syms_of_window): Initialize it.
f01d3321 729
86b847b6
CY
7302012-02-22 Chong Yidong <cyd@gnu.org>
731
732 * xterm.c (x_draw_image_relief): Add missing type check for
733 Vtool_bar_button_margin (Bug#10743).
734
a59225b1
CY
7352012-02-21 Chong Yidong <cyd@gnu.org>
736
737 * fileio.c (Vfile_name_handler_alist): Doc fix.
738
739 * buffer.c (Fget_file_buffer): Protect against invalid file
740 handler return value.
741
310f5bd4
PE
7422012-02-20 Paul Eggert <eggert@cs.ucla.edu>
743
cb3a28cc
PE
744 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
745 when computing $valmask.
746
310f5bd4
PE
747 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
748 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
749 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
750 It's useless in that case, and it can cause problems on hosts
751 that allocate halves of EMACS_INT values separately.
752 Reported by Dan Horák. Diagnosed by Andreas Schwab in
753 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
754 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
755 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
756 it avoids undefined behavior on hosts where shifting right by more
757 than the word width has undefined behavior.
758
2375c96a
CY
7592012-02-19 Chong Yidong <cyd@gnu.org>
760
761 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
762 (Funhandled_file_name_directory, Ffile_name_as_directory)
763 (Fdirectory_file_name, Fexpand_file_name)
764 (Fsubstitute_in_file_name): Protect against invalid file handler
765 return values (Bug#10845).
766
3eb49e71
EZ
7672012-02-18 Eli Zaretskii <eliz@gnu.org>
768
769 * .gdbinit (pitx): Fix incorrect references to fields of the
770 iterator stack.
771
7b926f3f
CY
7722012-02-17 Chong Yidong <cyd@gnu.org>
773
774 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
775
11273115
PE
7762012-02-15 Paul Eggert <eggert@cs.ucla.edu>
777
778 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
779 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
780
c3a70e2b
CY
7812012-02-15 Chong Yidong <cyd@gnu.org>
782
783 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
784 marked as special. Also, starting docstrings with * is obsolete.
785
0ca43699
AS
7862012-02-13 Andreas Schwab <schwab@linux-m68k.org>
787
788 * gnutls.c (emacs_gnutls_write): Fix last change.
789
2e8f3c56
LI
7902012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
791
792 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
793 send_process.
794
af70074f
SM
7952012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
796
797 * keymap.c (Fsingle_key_description): Handle char ranges.
798
95986d52
CY
7992012-02-12 Chong Yidong <cyd@gnu.org>
800
afd83bd1
CY
801 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
802 as that creates a dangerous corner case.
803
95986d52
CY
804 * window.c (Fdelete_window_internal): Invalidate the mouse
805 highlight (Bug#9904).
806
bd7da63e
GM
8072012-02-12 Glenn Morris <rgm@gnu.org>
808
809 * xselect.c (Fx_own_selection_internal)
810 (Fx_get_selection_internal, Fx_disown_selection_internal)
811 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
812 * nsselect.m (Fx_own_selection_internal)
813 (Fx_disown_selection_internal, Fx_selection_exists_p)
814 (Fx_selection_owner_p, Fx_get_selection_internal):
815 Sync docs and argument specs with the xselect.c versions.
816
77abcbc2
LI
8172012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
818
819 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
820
90b671e2
EZ
8212012-02-11 Eli Zaretskii <eliz@gnu.org>
822
1c0ca0b7
EZ
823 * w32select.c (Fx_selection_exists_p): Sync doc string and
824 argument list with xselect.c. (Bug#10783)
825
826 * w16select.c (Fx_selection_exists_p): Sync doc string and
827 argument list with xselect.c. (Bug#10783)
90b671e2 828
49241268
GM
8292012-02-10 Glenn Morris <rgm@gnu.org>
830
831 * fns.c (Fsecure_hash): Doc fix.
832
f998bbe7 8332012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
834
835 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
836
0992bd9c
CY
8372012-02-07 Chong Yidong <cyd@gnu.org>
838
839 * buffer.c (Fbuffer_local_variables)
840 (buffer_lisp_local_variables): Handle unbound vars correctly;
841 don't let Qunbound leak into Lisp.
842
af008560
GM
8432012-02-07 Glenn Morris <rgm@gnu.org>
844
dd605cc4
GM
845 * image.c (Fimagemagick_types): Doc fix.
846
af008560
GM
847 * image.c (imagemagick-render-type): Change it from a lisp object
848 to an integer. Move the doc here from the lisp manual.
849 Treat all values not equal to 0 the same.
850
1449fa1d
CY
8512012-02-06 Chong Yidong <cyd@gnu.org>
852
853 * doc.c (store_function_docstring): Avoid applying docstring of
854 alias to base function (Bug#2603).
855
3723ec07
AS
8562012-02-04 Andreas Schwab <schwab@linux-m68k.org>
857
858 * .gdbinit (pp1, pv1): Remove redundant defines.
859 (pr): Use pp.
860
79c1cc1e
CY
8612012-02-04 Chong Yidong <cyd@gnu.org>
862
863 * nsterm.m: Declare a global (Bug#10694).
864
d7f29f8e
EZ
8652012-02-04 Eli Zaretskii <eliz@gnu.org>
866
cae07000
SM
867 * w32.c (get_emacs_configuration_options):
868 Include --enable-checking, if specified, in the return value.
d7f29f8e 869
3b95a6f9
MR
8702012-02-04 Martin Rudalics <rudalics@gmx.at>
871
872 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
873 after rounding frame sizes. (Bug#9723)
874
d6fa96a6
EZ
8752012-02-04 Eli Zaretskii <eliz@gnu.org>
876
877 * keyboard.c (adjust_point_for_property): Don't position point
878 before BEGV. (Bug#10696)
879
df0b2940
PE
8802012-02-03 Paul Eggert <eggert@cs.ucla.edu>
881
882 Handle overflow when computing char display width (Bug#9496).
883 * character.c (char_width): Return EMACS_INT, not int.
884 (char_width, c_string_width): Check for overflow when
885 computing the width; this is possible now that individual
886 characters can have unbounded width. Problem introduced
887 by merge from Emacs 23 on 2012-01-19.
888
6bee44d6
MA
8892012-02-02 Michael Albinus <michael.albinus@gmx.de>
890
891 * dbusbind.c (Fdbus_register_method): Mention the return value
892 :ignore in the docstring.
893
44f92739
GM
8942012-02-02 Glenn Morris <rgm@gnu.org>
895
1b9f60cc
GM
896 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
897
44f92739
GM
898 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
899 Unconditionally set to t. (Bug#10673)
900 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
901 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
902 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
903
c5d3843c
KH
9042012-02-02 Kenichi Handa <handa@m17n.org>
905
906 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
907 0, do not call append_composite_glyph.
908
159462d4 9092012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
910
911 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
912 NULL (Bug#6988).
913 (x_produce_glyphs): If the component of a composition is a null
914 string, set it->pixel_width to 1 to avoid zero-width glyph.
915
78cef877
EZ
9162012-02-01 Eli Zaretskii <eliz@gnu.org>
917
918 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
919 first 2 arguments are identical. This makes inserting large
920 output from a subprocess an order of magnitude faster on
921 MS-Windows, where all sbrk'ed memory is always contiguous.
922
97897668
GM
9232012-01-31 Glenn Morris <rgm@gnu.org>
924
925 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 926 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
927 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
928
31fd3586
GM
9292012-01-29 Glenn Morris <rgm@gnu.org>
930
931 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
932
0e24a8b2
CY
9332012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
934
935 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
936
cc0adcb0
CY
9372012-01-28 Chong Yidong <cyd@gnu.org>
938
939 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
940
acc28cb9
CY
9412012-01-26 Chong Yidong <cyd@gnu.org>
942
9c69cfb7
CY
943 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
944
acc28cb9
CY
945 * search.c (Fsearch_forward, Fsearch_backward): Document negative
946 repeat counts (Bug#10507).
947
48da7392
GM
9482012-01-26 Glenn Morris <rgm@gnu.org>
949
950 * lread.c (syms_of_lread): Doc fix.
951
14af5f7f
CY
9522012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
953
954 * coding.c (encode_designation_at_bol): Change return value to
955 EMACS_INT.
956
0b21c100
CY
9572012-01-25 Chong Yidong <cyd@gnu.org>
958
959 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
960
3c2907f7
CY
9612012-01-21 Chong Yidong <cyd@gnu.org>
962
963 * floatfns.c (Fcopysign): Make the second argument non-optional,
964 since nil is not allowed anyway.
965
959ad23f
AS
9662012-01-21 Andreas Schwab <schwab@linux-m68k.org>
967
968 * process.c (read_process_output): Use p instead of XPROCESS (proc).
969 (send_process): Likewise.
970
34a02f46
MR
9712012-01-19 Martin Rudalics <rudalics@gmx.at>
972
973 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
974 (Vwindow_persistent_parameters): Do not use Qstate.
975 Rewrite doc-strings.
34a02f46 976
1259009a 9772012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
978
979 * character.c (char_width): New function.
70d4fdf6
GM
980 (Fchar_width, c_string_width, lisp_string_width):
981 Use char_width (Bug#9496).
25ed9e61 982
6a6ee00d
MR
9832012-01-16 Martin Rudalics <rudalics@gmx.at>
984
985 * window.c (Vwindow_persistent_parameters): New variable.
986 (Fset_window_configuration, save_window_save): Handle persistent
987 window parameters.
988
c85efaf7
EZ
9892012-01-14 Eli Zaretskii <eliz@gnu.org>
990
991 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
992 thrashing the stack of the thread. (Bug#9087)
993
5944709e
PE
9942012-01-12 Paul Eggert <eggert@cs.ucla.edu>
995
996 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
997
e71f5d99
EZ
9982012-01-11 Eli Zaretskii <eliz@gnu.org>
999
1000 * xdisp.c (rows_from_pos_range): Handle the case where the
1001 highlight ends on a newline. (Bug#10464)
1002 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1003 he end column for display of highlight that ends on a newline
1004 before a R2L line.
1005
ce316182
GM
10062012-01-11 Glenn Morris <rgm@gnu.org>
1007
1008 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1009 from load-path also when installation-directory is nil. (Bug#10208)
1010
5b43da69
GM
10112012-01-10 Glenn Morris <rgm@gnu.org>
1012
74cc8ff9
GM
1013 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1014
7d8d6e4e
GM
1015 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1016 Update template values to be closer to their typical values these days.
5b43da69 1017
a0db8d43
EZ
10182012-01-09 Eli Zaretskii <eliz@gnu.org>
1019
1020 * xdisp.c (rows_from_pos_range): Accept additional argument
1021 DISP_STRING, and accept any glyph in a row whose object is that
1022 string as eligible for mouse highlight. Fixes mouse highlight of
1023 display strings from overlays. (Bug#10464)
1024
9a0115ab 10252012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 1026
b9110d6a 1027 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
1028 * fileio.c (auto_saving_dir_umask): New static var.
1029 (Fmake_directory_internal): Use it.
1030 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1031 creating the directory. The old code temporarily assigns
1032 too-generous permissions to the directory.
1033 (do_auto_save_eh): Clear it.
b9110d6a 1034 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
1035 that the var is always cleared.
1036
6c1bd3f3
EZ
10372012-01-07 Eli Zaretskii <eliz@gnu.org>
1038
1039 * search.c (scan_buffer): Pass character positions to
1040 know_region_cache, not byte positions. (Bug#6540)
1041
069d2b50
L
10422012-01-07 LynX <_LynX@bk.ru> (tiny change)
1043
1044 * w32.c (sys_rename): Report EXDEV when rename of a directory
1045 fails because the target is on another logical disk. (Bug#10284)
1046
75bf0d33
DB
10472012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1048
1049 * xterm.c (x_embed_request_focus): New function.
1050
1051 * xterm.h: Add prototype.
1052
1053 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1054
1c6e5a32
GM
10552012-01-05 Glenn Morris <rgm@gnu.org>
1056
1057 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1058
651e947e
EZ
10592012-01-01 Eli Zaretskii <eliz@gnu.org>
1060
1061 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1062 Load gnutls_transport_set_lowat only if GnuTLS version is below
1063 2.11.1.
1064 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1065 GnuTLS versions below 2.11.1.
1066
3778cdd8
AL
10672011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1068
1069 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1070 to the doc string advising against its use for altering the way
1071 windows are scrolled.
1072
0e5317f7
KH
10732011-12-28 Kenichi Handa <handa@m17n.org>
1074
1075 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1076 coding-system ASCII compatible only when it does not produce BOM
1077 on encoding (Bug#10383).
1078
93d5ca1f
JD
10792011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1080
1081 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1082 can scroll.
1083 (create_and_show_popup_menu): Always use menu_position_func for
1084 Gtk3 (Bug#10361).
1085
ca22b785
AS
10862011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1087
1088 * callint.c (Fcall_interactively): Don't truncate prompt string.
1089
d048e1e6
EZ
10902011-12-23 Eli Zaretskii <eliz@gnu.org>
1091
1092 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1093 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1094 resumed from there (after widening). (Bug#10360)
d048e1e6 1095
5ccaba1f
JD
10962011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1097
1098 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1099
204ee57f
JD
11002011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1101
b81d40f0
JB
1102 * nsterm.m (x_free_frame_resources):
1103 Release f->output_data.ns->miniimage.
204ee57f
JD
1104 (ns_index_color): Fix indentation. Do not retain
1105 color_table->colors[i].
1106
1107 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1108 before returning.
1109
1110 * nsfns.m (x_set_background_color): Assign return value from
1111 ns_index_color to face-background instead of NSColor*.
1112 (ns_implicitly_set_icon_type): Fix indentation.
1113 Change assignment in for loop to comparison.
1114
1115 * emacs.c (ns_pool): New variable.
1116 (main): Assign ns_pool.
1117 (Fkill_emacs): Call ns_release_autorelease_pool.
1118
1119 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1120 autorelease fdesc, release fdAttrs and tdict.
1121 (ns_get_covering_families): Release charset.
1122 (ns_findfonts): Release NSFontDescriptor created with new.
1123 (ns_uni_to_glyphs): Fix indentation.
1124 (setString): Release attrStr before assigning new value.
1125
c803b2b7
JD
11262011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1127
678f4426
JD
1128 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1129 and NS_IMPL_COCOA.
1130 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1131 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1132
cd394be1 11332011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1134
5fecd5fc
JD
1135 * nsterm.m (ns_term_init): Subscribe for notifications
1136 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1137 to method trackingNotification in EmacsMenu.
1138
1139 * nsmenu.m (trackingMenu): New variable.
3771cb17 1140 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1141 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1142 from Aquamacs (Bug#7030).
678f4426
JD
1143
11442011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1145
c803b2b7
JD
1146 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1147 (symbol_to_nsstring): Fix indentation.
1148 (ns_symbol_to_pb): New function.
cae07000
SM
1149 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1150 (Fns_rotate_cut_buffers_internal): Remove.
1151 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1152 Fns_store_cut_buffer_internal.
1153 (ns_get_foreign_selection, Fx_own_selection_internal)
1154 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1155 (Fns_get_selection_internal, Fns_store_selection_internal):
1156 Use ns_symbol_to_pb and check if return value is nil.
1157 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1158 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1159 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1160 renamed to Sns_store_selection_internal.
1161 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1162 and remove this function.
1163 (ns_handle_selection_clear): Remove, never used.
1164 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1165 here.
1166
e1b01a3a
KB
11672011-12-17 Ken Brown <kbrown@cornell.edu>
1168
1169 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1170 GID is unknown (Bug#10257).
1171
2adb6e85
PE
11722011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1173
1174 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1175 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1176 which caused a build failure on GNU/Linux IA-64. This problem was
1177 introduced by my 2011-10-07 patch.
1178
d1d7b339
JL
11792011-12-15 Juri Linkov <juri@jurta.org>
1180
1181 * image.c (imagemagick_error): New function. (Bug#10112)
1182 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1183 Use `imagemagick_error' where ImageMagick functions return
1184 `MagickFalse'.
1185 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1186 proper order.
1187
100d5755
KH
11882011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1189
1190 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1191 fill background (Bug#8992).
1192
454592a6
MR
11932011-12-13 Martin Rudalics <rudalics@gmx.at>
1194
1195 * window.c (Vwindow_combination_resize)
1196 (Vwindow_combination_limit): Use t instead of non-nil in
1197 doc-strings.
61d4b438
MR
1198 (Vrecenter_redisplay): Add first sentence of doc-string on
1199 separate line.
53524d93 1200 (Frecenter): Fix doc-string typo.
454592a6 1201
3633e3aa
KH
12022011-12-11 Kenichi Handa <handa@m17n.org>
1203
1204 * coding.c (Funencodable_char_position): Pay attention to the
1205 buffer text relocation (Bug#9389).
1206
7b9d523a
JD
12072011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1208
1209 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1210 gtk_init (Bug#10100).
1211
b73189c6
EZ
12122011-12-10 Eli Zaretskii <eliz@gnu.org>
1213
1214 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1215 IT->string is nil. (Bug#10263)
1216
f7dfe5d6
JD
12172011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1218
83faebb4
JD
1219 * nsterm.h (x_free_frame_resources): Declare.
1220
f7dfe5d6
JD
1221 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1222 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1223
1224 * nsterm.h (ns_get_defaults_value): Declare.
1225
1226 * nsterm.m (ns_default): Call ns_get_defaults_value.
1227
7cd4e72c
EZ
12282011-12-09 Eli Zaretskii <eliz@gnu.org>
1229
1230 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1231 (Bug#10170)
1232
b34d7317
YM
12332011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1234
1235 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1236 that where the value of an _OBJC_* symbol points to is in the .bss
1237 section (Bug#10240).
1238
76470ad1
KH
12392011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1240
1241 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1242 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1243
745fff94
KH
12442011-12-08 Kenichi Handa <handa@m17n.org>
1245
1246 * ftfont.c (get_adstyle_property): Fix previous change
1247 (Bug#10233).
1248
6e44397c
JB
12492011-12-07 Juanma Barranquero <lekktu@gmail.com>
1250
1251 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1252 dirs from the default value of EMACSLOADPATH (bug#10208).
1253
7efa6272
GM
12542011-12-07 Glenn Morris <rgm@gnu.org>
1255
1256 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1257 installation and source directories as well. (Bug#10208)
1258
f6fc4d87
CY
12592011-12-06 Chong Yidong <cyd@gnu.org>
1260
1261 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1262
2bf26180
GM
12632011-12-06 Glenn Morris <rgm@gnu.org>
1264
1265 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1266 as an error, not just -1. (Bug#10217)
1267
3a6ad4f0
CY
12682011-12-05 Chong Yidong <cyd@gnu.org>
1269
1270 * keyboard.c (process_special_events): New function.
1271 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1272
75a3b399
PE
12732011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1274
1275 * coding.c (encode_designation_at_bol): Don't use uninitialized
1276 local variable (Bug#9318).
1277
c3c9e25e
KH
12782011-12-05 Kenichi Handa <handa@m17n.org>
1279
1280 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1281 return Qnil (Bug#8046, Bug#10193).
1282
5eb05ea3
KH
12832011-12-05 Kenichi Handa <handa@m17n.org>
1284
1285 * coding.c (encode_designation_at_bol): New args charbuf_end and
1286 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1287 (coding_set_source): Return how many bytes coding->source was
1288 relocated.
1289 (coding_set_destination): Return how many bytes
1290 coding->destination was relocated.
1291 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1292 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1293
12942011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1295
1296 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1297 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1298 macro (Bug#9318).
1299
13002011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1301
1302 The following changes are to fix Bug#9318.
1303
a79703f5 1304 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1305 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1306 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1307 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1308
7dbda6df
JB
13092011-12-05 Juanma Barranquero <lekktu@gmail.com>
1310
1311 * lisp.h (process_quit_flag): Fix external declaration.
1312
6d5eb5b0
SM
13132011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1314
1315 Don't macro-inline non-performance-critical code.
1316 * eval.c (process_quit_flag): New function.
1317 * lisp.h (QUIT): Use it.
1318
a0c3fad0
JD
13192011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1320
1321 * nsfns.m (get_geometry_from_preferences): New function.
1322 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1323
6c07aac2
AS
13242011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1325
1326 * emacs.c (Qkill_emacs): Define.
1327 (syms_of_emacs): Initialize it.
1328 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1329 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1330 (quit_throw_to_read_char): Add parameter `from_signal'.
1331 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1332 * lisp.h (QUIT): Call Fkill_emacs if requested.
1333
c052ead4
JD
13342011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1335
1336 * widget.c (update_wm_hints): Return if wmshell is null.
1337 (widget_update_wm_size_hints): New function.
1338
1339 * widget.h (widget_update_wm_size_hints): Declare.
1340
1341 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1342 widget_update_wm_size_hints (Bug#10104).
1343
9e49252b
EZ
13442011-12-03 Eli Zaretskii <eliz@gnu.org>
1345
1346 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1347 before a newline, prepare the bidi iterator for consuming the
1348 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1349 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1350
02b16839
JL
13512011-12-02 Juri Linkov <juri@jurta.org>
1352
1353 * search.c (Fword_search_regexp): New Lisp function created from
1354 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1355 (Fword_search_backward, Fword_search_forward)
1356 (Fword_search_backward_lax, Fword_search_forward_lax):
1357 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1358 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1359
0068070e
SM
13602011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1361
1362 * fileio.c (Finsert_file_contents): Move after-change-function call
1363 to before the "handled:" label, since all "goto handled" appear in
1364 cases where the *-change-functions have already been properly called
1365 (bug#10117).
1366
3360a3fc
AS
13672011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1368
1369 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1370 waiting for input. (Bug#10169)
1371
73d6c093
EZ
13722011-11-30 Eli Zaretskii <eliz@gnu.org>
1373
1374 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1375 verifies glyph row's hash code--we have just reallocated the
1376 glyphs, so their contents can be complete garbage. (Bug#10164)
1377
febe6bea
JB
13782011-11-30 Juanma Barranquero <lekktu@gmail.com>
1379
1380 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1381
801a4313
EZ
13822011-11-30 Eli Zaretskii <eliz@gnu.org>
1383
1384 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1385 attributes are tested _before_ calling verify_row_hash, to protect
1386 against GCC re-ordering of the tests. (Bug#10164)
1387
2b56b87e
JD
13882011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1389
1390 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1391
1392 * xterm.c (handle_one_xevent): Only set async_visible and friends
1393 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1394 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1395 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1396
dbf31225
PE
13972011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1398
1399 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1400 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1401 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1402 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1403 All uses changed to use GCPRO1 etc.
1404 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1405 Revert to old implementation (i.e., before 2011-03-11).
1406
1305621b
YM
14072011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1408
1409 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1410 of scroll runs so as to avoid assigning disabled bogus rows and
1411 unnecessary graphics copy operations.
1412
8c9afb46
EZ
14132011-11-27 Eli Zaretskii <eliz@gnu.org>
1414
1415 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1416 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1417 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1418 (malloc, free, realloc, calloc): Redirect to e_* only when
1419 compiling Emacs.
1420
1421 * lisp.h (GCTYPEBITS): Move before first use.
1422 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1423 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1424 this macro definition.
1425
1426 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1427 _MSC_VER.
1428
54e9e3bf
JD
14292011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1430
6d5eb5b0
SM
1431 * gtkutil.c (xg_create_frame_widgets):
1432 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1433 present with Gtk+ 2.0.
1434
83aca1cb
PE
14352011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1436
1437 * fileio.c (Finsert_file_contents): Undo previous change; see
1438 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1439
5b76caa4
PE
14402011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1441
1442 Rename locals to avoid shadowing.
1443 * fileio.c (Finsert_file_contents):
1444 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1445 * process.c (wait_reading_process_output):
1446 Rename inner 'proc' to 'p' to avoid shadowing.
1447 Indent for consistency with usual Emacs style.
1448
8c535114
EZ
14492011-11-25 Eli Zaretskii <eliz@gnu.org>
1450
1451 * xdisp.c (redisplay_window): If cursor row is not fully visible
1452 after recentering, and scroll-conservatively is set to a large
1453 number, scroll window by a few more lines to make the cursor fully
1454 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1455 (start_display): Don't move to the next line if the display should
1456 start at a newline that is part of a display vector or an overlay
1457 string. (Bug#10119)
8c535114 1458
fa4fdb5c
JL
14592011-11-24 Juri Linkov <juri@jurta.org>
1460
1461 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1462 after the `MagickPingImage' call. (Bug#10112)
1463
90ec88df
CY
14642011-11-23 Chong Yidong <cyd@gnu.org>
1465
1466 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1467
56e2e794
MR
14682011-11-23 Martin Rudalics <rudalics@gmx.at>
1469
1470 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1471 making another buffer current. (Bug#10114)
1472
b6e64c41
GM
14732011-11-23 Glenn Morris <rgm@gnu.org>
1474
1475 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1476
6b21de18
CY
14772011-11-23 Chong Yidong <cyd@gnu.org>
1478
1479 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1480 using it (Bug#5984).
1481
b12cd789
EZ
14822011-11-22 Eli Zaretskii <eliz@gnu.org>
1483
1484 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1485 and header-lines, as they don't have one computed for them.
1486 (Bug#10098)
1487
1488 * .gdbinit (prow): Make displayed values more self-explaining.
1489 Add row's hash code.
1490
261b6fd4
LMI
14912011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1492
1493 * process.c (wait_reading_process_output): Fix asynchrounous
1494 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1495 (wait_reading_process_output): Add comment and URL.
261b6fd4 1496
e7cfd277
JD
14972011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1498
1499 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1500
a9b9b7f5
CY
15012011-11-21 Chong Yidong <cyd@gnu.org>
1502
1503 * window.c (Fnext_window, Fprevious_window): Doc fix.
1504
b0d15b4f
SM
15052011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1506
1507 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1508
fe7a3057
JB
15092011-11-20 Juanma Barranquero <lekktu@gmail.com>
1510
1511 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1512
d2999b1a
MR
15132011-11-20 Martin Rudalics <rudalics@gmx.at>
1514
1515 * window.c (Fset_window_combination_limit): Rename argument
1516 STATUS to LIMIT.
1517 (Vwindow_combination_limit): Remove "status" from doc-string.
1518
d5ff9cd0
AS
15192011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1520
1521 * m/ibms390.h: Remove.
1522 * m/ibms390x.h: Don't include "ibms390.h".
1523
a5bb9bd3
SM
15242011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1525
1526 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1527 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1528
cd1181db
JB
15292011-11-20 Juanma Barranquero <lekktu@gmail.com>
1530
1531 * casetab.c (Fset_case_table):
1532 * charset.c (Fcharset_after): Fix typos.
1533
615a3b8d 15342011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1535
17e845af
PE
1536 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1537 Otherwise, valgrind does not work on some platforms.
1538 Problem reported by Andreas Schwab in
6a0bf43d
PE
1539 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1540 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1541 is set, removing the need for VIRT_ADDRESS_VARIES.
1542 (PURE_P): Use a more-efficient implementation that needs just one
1543 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1544 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1545 to 4 (xorl, subq, cmpq, setbe).
1546 * alloc.c (pure): Always extern now, since that's the
1547 VIRT_ADDR_VARIES behavior.
1548 (PURE_POINTER_P): Use a single comparison, not two, for
1549 consistency with the new puresize.h.
1550 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1551 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1552 Remove VIRT_ADDR_VARIES no longer needed.
1553
f8fe6f96
EZ
15542011-11-19 Eli Zaretskii <eliz@gnu.org>
1555
1556 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1557 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1558 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1559 behave as if the cursor position were at the window margin.
1560
1561 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1562 and the cursor position is out of bounds, behave as if the cursor
1563 position were at the window margin. (Bug#10075)
1564
df05a53c
CY
15652011-11-18 Chong Yidong <cyd@gnu.org>
1566
1567 * window.c (Fwindow_combination_limit): Make first argument
1568 non-optional, since it is meaningless for live windows like the
1569 selected window.
1570
2071918e
DA
15712011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1572
1573 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1574
b50a28de
SM
15752011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1576
1577 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1578 (graft_intervals_into_buffer): Simplify.
1579
015137db
EZ
15802011-11-18 Eli Zaretskii <eliz@gnu.org>
1581
1582 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1583 hash values of the two rows.
1584 (copy_row_except_pointers): Preserve the used[] arrays and the
1585 hash values of the two rows. (Bug#10035)
68c95424 1586 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1587
1588 * xdisp.c (row_hash): New function, body extracted from
1589 compute_line_metrics.
1590 (compute_line_metrics): Call row_hash, instead of computing the
1591 hash code inline.
1592
1593 * dispnew.c (verify_row_hash): Call row_hash for computing the
1594 hash code of a row, instead of duplicating code from xdisp.c.
1595
1596 * dispextern.h (row_hash): Add prototype.
1597
a2addb04
TH
15982011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1599
1600 * frame.c (delete_frame): Don't delete the terminal when the last
1601 X frame is closed if emacs is built with GTK toolkit.
1602
df85d315
JB
16032011-11-17 Juanma Barranquero <lekktu@gmail.com>
1604
1605 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1606
a0c2d0ae
MR
16072011-11-17 Martin Rudalics <rudalics@gmx.at>
1608
1609 * window.c (Vwindow_splits): Rename to
1610 Vwindow_combination_resize. Suggested by Juri Linkov.
1611 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1612 of Vwindow_splits.
1613
58179cce
JB
16142011-11-16 Juanma Barranquero <lekktu@gmail.com>
1615
7877f373
JB
1616 * nsfns.m (Fns_font_name):
1617 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1618
b6f67890
MR
16192011-11-16 Martin Rudalics <rudalics@gmx.at>
1620
1621 * window.h (window): Rename slot "nest" to "combination_limit".
1622 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1623 (Fset_window_nest): Rename to Fset_window_combination_limit.
1624 (Vwindow_nest): Rename to Vwindow_combination_limit.
1625 (recombine_windows, make_parent_window, make_window)
1626 (Fsplit_window_internal, saved_window)
1627 (Fset_window_configuration, save_window_save): Rename all
1628 occurrences of window_nest to window_combination_limit.
1629
c7015153
JB
16302011-11-15 Juanma Barranquero <lekktu@gmail.com>
1631
1632 * image.c (imagemagick_load_image): Fix typo.
1633
322ad6ec
EZ
16342011-11-14 Eli Zaretskii <eliz@gnu.org>
1635
1636 * xdisp.c (display_line): Move the call to
1637 highlight_trailing_whitespace before the call to
1638 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1639 faces of all the glyphs to compute ROW's hash value.
1640 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1641
f067b8ec
JB
16422011-11-14 Juanma Barranquero <lekktu@gmail.com>
1643
1644 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1645 just return (bug#10044).
1646
1e5b2111
EZ
16472011-11-12 Eli Zaretskii <eliz@gnu.org>
1648
7ef3cbd5
EZ
1649 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1650 with user-defined heap size. Bump the default size of the temacs
1651 heap to 27MB, to avoid memory warning when running temacs.
1652 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1653
1e5b2111
EZ
1654 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1655 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1656 (verify_row_hash) [XASSERTS]: New function.
1657 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1658 that the hash value of glyph rows is correct.
1e5b2111 1659
89d61221
MR
16602011-11-12 Martin Rudalics <rudalics@gmx.at>
1661
1662 * window.h (window): Remove splits slot.
1663 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1664 (Fdelete_other_windows_internal, make_parent_window)
1665 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1666 (Fset_window_configuration, save_window_save): Don't deal with
1667 split status of windows.
1668 (saved_window): Remove splits slot.
1669 (Vwindow_splits): Rewrite doc-string.
1670
97f18cc8
JD
16712011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1672
1673 * xfns.c (unwind_create_frame):
1674 * nsfns.m (unwind_create_frame):
1675 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1676 Vframe_list (Bug#9999).
1677
22a648b4
DA
16782011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1679
0b381c7e 1680 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1681
659afede
KH
16822011-11-11 Kenichi Handa <handa@m17n.org>
1683
1684 * callproc.c (Fcall_process): Set the member dst_multibyte of
1685 process_coding.
1686
9ac0394b
KH
16872011-11-11 Johan Bockgård <bojohan@gnu.org>
1688
1689 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1690 avoid a crash (bug#9496).
1691
2fbdc249
CY
16922011-11-09 Chong Yidong <cyd@gnu.org>
1693
1694 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1695 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1696
ac6b1f81
PE
16972011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1698
1699 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1700
09db192c
PE
17012011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1702
1703 Avoid some portability problems by eschewing 'extern inline' functions.
1704 The trivial performance wins aren't worth the portability hassles; see
1705 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1706 et seq.
1707 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1708 (window_box_width, window_box_left, window_box_left_offset)
1709 (window_box_right, window_box_right_offset): Undo previous change,
1710 by removing the "extern"s.
1711 * intervals.c (adjust_intervals_for_insertion)
1712 (adjust_intervals_for_deletion): Undo previous change,
1713 making these static again.
1714 (offset_intervals, temp_set_point_both, temp_set_point)
1715 (copy_intervals_to_string): No longer inline.
1716 * xdisp.c (window_text_bottom_y, window_box_width)
1717 (window_box_height, window_box_left_offset)
1718 (window_box_right_offset, window_box_left, window_box_right)
1719 (window_box): No longer inline.
1720
105216ed
CY
17212011-11-08 Chong Yidong <cyd@gnu.org>
1722
1723 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1724 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1725 Signal an error if not a live window.
105216ed
CY
1726 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1727 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1728
ae9e237f
JB
17292011-11-07 Juanma Barranquero <lekktu@gmail.com>
1730
1731 * lisp.h (syms_of_abbrev): Remove declaration.
1732 Reported by CHENG Gao <chenggao@royau.me>.
1733
c7aa8333
EZ
17342011-11-07 Eli Zaretskii <eliz@gnu.org>
1735
1736 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1737 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1738 of temacs in GUI mode.
1739
be7f5545
MR
17402011-11-07 Martin Rudalics <rudalics@gmx.at>
1741
1742 * window.h: Declare delete_all_child_windows instead of
1743 delete_all_subwindows.
1744 * window.c (Fwindow_nest, Fset_window_nest)
1745 (Fset_window_new_total, Fset_window_new_normal)
1746 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1747 (delete_all_subwindows): Rename to delete_all_child_windows.
1748 (Fdelete_other_windows_internal, Fset_window_configuration):
1749 Call delete_all_child_windows instead of delete_all_subwindows.
1750 * frame.c (delete_frame): Call delete_all_child_windows instead
1751 of delete_all_subwindows.
1752
ca78dc43
PE
17532011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1754
1755 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1756 This is also needed for porting to any host where GC_MARK_STACK is
1757 not GC_MAKE_GCPROS_NOOPS.
1758 (which_symbols): Use it.
1759
a0241d01
KH
17602011-11-07 Kenichi Handa <handa@m17n.org>
1761
1762 * coding.c (coding_set_destination): Check coding->src_pos only
1763 when coding->src_object is a buffer (bug#9910).
1764
1765 * process.c (send_process): Set the member src_multibyte of coding
1766 to 0 (bug#9911) when sending a unibyte text.
1767
1768 * callproc.c (Fcall_process): Set the member src_multibyte of
1769 process_coding to 0 (bug#9912).
1770
a64bfdfa 17712011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1772
1773 * xmenu.c (cleanup_widget_value_tree): New function.
1774 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1775 calling free_menubar_widget_value_tree directly (Bug#9830).
1776
cb41b32a
PE
17772011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1778
1779 Fix some portability problems with 'inline'.
1780 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1781 (window_box_width, window_box_left, window_box_left_offset)
1782 (window_box_right, window_box_right_offset): Declare extern.
1783 Otherwise, these inline functions do not conform to C99 and
1784 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1785 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1786 * intervals.c (adjust_intervals_for_insertion)
1787 (adjust_intervals_for_deletion): Now extern, because otherwise the
1788 extern inline functions 'offset_intervals' couldn't refer to it.
1789 (static_offset_intervals): Remove.
1790 (offset_intervals): Rewrite using the old contents of
1791 static_offset_intervals. The old version didn't conform to C99
1792 because an extern inline function contained a reference to an
1793 identifier with static linkage.
1794
b7041366
AS
17952011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1796
1797 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1798 GC.
1799
88a37c4d
EZ
18002011-11-06 Eli Zaretskii <eliz@gnu.org>
1801
1802 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1803 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1804 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1805 return Qleft_to_right.
1806
49745b39
CY
18072011-11-06 Chong Yidong <cyd@gnu.org>
1808
1809 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1810 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1811 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1812 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1813 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1814 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1815 (Fwindow_vscroll): Doc fix.
1816 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1817 argument, since it makes no sense to pass a live window and for
1818 consistency with window-child.
1819
1f05cd82
CS
18202011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1821
1822 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1823 support MSVC.
1824
22610910
JR
18252011-11-05 Jason Rumney <jasonr@gnu.org>
1826
1827 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1828 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1829 fonts (Bug#6029).
1830 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1831 bitwise arithmetic preventing use of unicode-sip and non-truetype
1832 opentype fonts.
1833
a06776b2
EZ
18342011-11-05 Eli Zaretskii <eliz@gnu.org>
1835
3ad924ba
EZ
1836 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1837 "emacs"-only part.
1838
a06776b2
EZ
1839 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1840 initialization code to keep similarity to xfns.c after changes
1841 from 2011-11-05.
1842
c9e7db78
JD
18432011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1844
a97f8f3f
JD
1845 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1846 (unwind_create_frame): New function (Bug#9943).
1847 (Fx_create_frame): Restructure code to be more similar to the one in
1848 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1849 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1850 Move terminal->reference_count++ just before making the frame official
1851 (Bug#9943).
1852
1853 * nsterm.m (x_free_frame_resources): New function.
1854 (x_destroy_window): Move code to x_free_frame_resources.
1855
c9e7db78 1856 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1857 (Fx_create_frame, x_create_tip_frame):
1858 Move terminal->reference_count++ just before making the frame
75f1671a 1859 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1860 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1861
a6fc3b5c
EZ
18622011-11-05 Eli Zaretskii <eliz@gnu.org>
1863
1864 Support MSVC build with newer versions of Visual Studio.
1865 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1866 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1867 nt/gmake.defs.
1868
1869 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1870 which are not supported by MSVC.
1871 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1872 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1873 bitfields.
1874 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1875 types in bitfields.
1876 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1877
1878 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1879
58179cce 18802011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1881
1882 Support MSVC build with newer versions of Visual Studio.
1883 * w32.c: Don't include w32api.h for MSVC.
1884 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1885
1886 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1887 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1888 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1889 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1890 e_* cousins.
1891 (alloca) [_MSC_VER]: Define to _alloca.
1892
1893 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1894
1895 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1896
a58c13ed
EZ
18972011-11-04 Eli Zaretskii <eliz@gnu.org>
1898
1899 * xdisp.c (note_mouse_highlight): If either of
1900 previous/next-single-property-change returns nil, treat that as
1901 the beginning or the end of the buffer. (Bug#9955)
1902
fe0b6370
JD
19032011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1904
a58c13ed 1905 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1906 label is not null (Bug#9951).
1907 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1908 may be NULL.
1909
89bd5ee1
EZ
19102011-11-04 Eli Zaretskii <eliz@gnu.org>
1911
1912 * window.c (Fwindow_body_size): Mention in the doc string that the
1913 return value is in frame's canonical units. (Bug#9949)
1914
84c3edb9
EZ
19152011-11-03 Eli Zaretskii <eliz@gnu.org>
1916
4e2fb5c7
EZ
1917 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1918
84c3edb9 1919 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1920 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1921 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1922
bc17a887
EZ
19232011-11-01 Eli Zaretskii <eliz@gnu.org>
1924
1925 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1926 Don't stop backward scan on the continuation glyph, even though
1927 its CHARPOS is positive.
6d5eb5b0
SM
1928 (mouse_face_from_buffer_pos, note_mouse_highlight):
1929 Rename cover_string to disp_string.
bc17a887 1930
4ee88440
MR
19312011-11-01 Martin Rudalics <rudalics@gmx.at>
1932
1933 * window.c (temp_output_buffer_show): Don't use
1934 Vtemp_buffer_show_specifiers.
1935 (Vtemp_buffer_show_specifiers): Remove unused variable.
1936
c2ff3c02
EZ
19372011-10-30 Eli Zaretskii <eliz@gnu.org>
1938
1939 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1940 past the beginning of the current glyph matrix.
1941
58179cce 19422011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1943
1944 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1945 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1946 HAVE_GTK3 (Bug#9869).
b77a6a7f 1947
3b574623
JD
1948 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1949 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1950
b77a6a7f
JD
1951 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1952
1953 * xterm.c: Declare x_handle_net_wm_state to return int.
1954 (handle_one_xevent): Check if we are iconified but don't have
1955 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1956 (get_current_wm_state): Return non-zero if not hidden,
1957 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1958 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1959 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1960 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1961
196e41e4
PE
19622011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1963
1964 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1965 so that this new function doesn't get optimized away by a
1966 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1967
021f2e1a
AS
19682011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1969
1970 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1971
8b058d44
EZ
19722011-10-29 Eli Zaretskii <eliz@gnu.org>
1973
1974 Fix the `xbytecode' command.
1975 * .gdbinit (xprintbytestr): New command.
b50a28de 1976 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1977 (xbytecode): Print the byte-code string as well.
1978
4452fb80
EZ
19792011-10-29 Kim Storm <storm@cua.dk>
1980
8b058d44
EZ
1981 * alloc.c (which_symbols): New function.
1982
21b72067
AS
19832011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1984
1985 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1986 line. (Bug#9903)
1987
83ed7b5c
GM
19882011-10-29 Glenn Morris <rgm@gnu.org>
1989
1990 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1991 Not clear what it was for, and it causes various bugs. (Bug#9839)
1992
5a7a728b
EZ
19932011-10-28 Eli Zaretskii <eliz@gnu.org>
1994
1995 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1996 possible random value that matches one of those tested as
1997 condition to clear the mouse face.
1998
d3d0842f
CY
19992011-10-28 Chong Yidong <cyd@gnu.org>
2000
2001 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2002
31b39d13
DN
20032011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2004
2005 * window.c (make_window): Initialize phys_cursor_on_p.
2006
9aba6043
SM
20072011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2008
2009 * lisp.h (struct Lisp_Symbol): Update comments.
2010
c20992f4
JB
20112011-10-28 Juanma Barranquero <lekktu@gmail.com>
2012
2013 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2014
db4f02f2
EZ
20152011-10-28 Eli Zaretskii <eliz@gnu.org>
2016
2017 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2018 <oslsachem@gmail.com> for helping to debug this.
2019
2020 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2021 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2022 (g_b_init_get_glyph_outline_w): New static variables.
2023 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2024 (GetGlyphOutlineW_Proc): New typedefs.
2025 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
2026 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2027 New functions.
2028 (w32font_open_internal, compute_metrics):
2029 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
2030 instead of calling the "wide" APIs directly.
2031
2032 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2033
2034 * w32.h (syms_of_w32font): Add prototype.
2035
87e68db4
JB
20362011-10-27 Juanma Barranquero <lekktu@gmail.com>
2037
2038 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2039 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2040 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2041 (Fmove_to_window_line): Doc fix.
2042
435c1d67
CY
20432011-10-27 Chong Yidong <cyd@gnu.org>
2044
2045 * process.c (make_process): Set gnutls_state to NULL.
2046
2047 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2048 non-NULL, regardless of GNUTLS_INITSTAGE.
2049 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2050 an error. Set process slots as soon as we allocate them.
2051
2052 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2053
9c6c6f49
CY
20542011-10-27 Chong Yidong <cyd@gnu.org>
2055
9aba6043
SM
2056 * gnutls.c (emacs_gnutls_deinit): New function.
2057 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2058 (Fgnutls_deinit, Fgnutls_boot): Use it.
2059
2060 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2061 (deactivate_process): Call emacs_gnutls_deinit.
2062
657d08d3
JB
20632011-10-27 Juanma Barranquero <lekktu@gmail.com>
2064
2065 * image.c (x_create_x_image_and_pixmap):
2066 * w32.c (sys_rename, w32_delayed_load):
2067 * w32font.c (fill_in_logfont):
2068 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2069
5430d399
JB
20702011-10-26 Juanma Barranquero <lekktu@gmail.com>
2071
2072 * w32fns.c (w32_default_color_map): New function,
2073 extracted from Fw32_default_color_map.
a7ef684b 2074 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2075
fe0055fa
PE
20762011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2077
2078 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2079
e6346438
SM
20802011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2081
2082 * keyboard.c (test_undefined): New function (bug#9751).
2083 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2084
e112cc37
ET
20852011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2086
2087 * sysdep.c (init_sys_modes): Fix the check for the controlling
2088 terminal (Bug#6649).
2089
7b5d6677
EZ
20902011-10-20 Eli Zaretskii <eliz@gnu.org>
2091
2092 * dispextern.h (struct bidi_it): New member next_en_type.
2093
2094 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2095 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2096 current character, check also for next_en_type being WEAK_EN.
2097 (bidi_resolve_weak): Don't enter the expensive loop if the current
2098 position is before next_en_pos. Record the bidi type of the first
2099 non-ET, non-BN character we find, in addition to its position.
2100 (bidi_level_of_next_char): Invalidate next_en_type when
2101 next_en_pos is over-stepped.
2102
7da0b018
PE
21032011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2104
2105 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2106 * editfns.c: Rewrite current-time-zone so that it invokes
2107 the equivalent of (format-time-string "%Z") to get the time zone name.
2108 This fixes a bug when the time zone name contains characters that
2109 need converting from the system time locale to Emacs internal format.
2110 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2111 that patch fixed format-time-string to do the conversion, but
2112 I forgot to fix current-time-zone.
2113 (format_time_string): New function, containing most of
2114 what Fformat_time_string used to contain.
2115 (Fformat_time_string): Rewrite in terms of format_time_string.
2116 This doesn't change this function's behavior.
2117 (current-time-zone): Rewrite to use format_time_string.
2118 This fixes the bug reported by Michael Schierl in
2119 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2120 Jason Rumney's 2007-06-07 change worked around this bug, but
2121 didn't fix it.
2122 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2123
8547b010
EZ
21242011-10-19 Eli Zaretskii <eliz@gnu.org>
2125
2126 * xdisp.c (start_display): If the character at POS is displayed
2127 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2128 (try_window_reusing_current_matrix): If a line ends in a display
2129 vector or the next line starts in a display vector, continue
2130 redrawing the window even though the character position of
2131 start_row was reached.
8547b010
EZ
2132 (Bug#9771, part 2)
2133
4e948d15
CY
21342011-10-18 Chong Yidong <cyd@gnu.org>
2135
2136 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2137 with nobreak-char-display too.
2138
4787455f
EZ
21392011-10-18 Eli Zaretskii <eliz@gnu.org>
2140
2141 Fix part 3 of bug#9771.
2142 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2143 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2144 non-neutral characters if the current character is a paragraph
2145 separator (a.k.a. Newline). This avoids running the same
2146 expensive loop twice, once when we consume the preceding newline
2147 and the other time when the line actually needs to be displayed.
2148 Avoid the loop when we see neutrals on the base embedding level
2149 following a character whose directionality is the same as the
2150 paragraph's. This avoids running the expensive loop when a line
2151 ends in a long sequence of neutrals, like control characters.
2152 Add assertion against STRONG_AL type. Slightly rearrange code
2153 that determines the type of a neutral given the first non-neutral
2154 that follows it.
2155 (bidi_level_of_next_char): Set next_en_pos to zero when
2156 invalidating its info.
2157
2c91f553
EZ
21582011-10-17 Eli Zaretskii <eliz@gnu.org>
2159
2160 * xdisp.c (push_display_prop): Determine whether to record string
2161 or buffer position by IT->string, not by IT->method. Allow
2162 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2163 (move_it_vertically_backward): Don't look for character position
2164 immediately after the newline when in a continuation line.
2165 (Bug#9771, part 1)
2c91f553 2166
c7b08b0d
MR
21672011-10-15 Martin Rudalics <rudalics@gmx.at>
2168
2169 * window.c (coordinates_in_window): Rewrite and delabelize
2170 vertical border check. (Bug#5357) (Bug#9618)
2171
6b02f655
SM
21722011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2173
2174 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2175 errors in XSetWindowBorder (bug#9310).
2176
81d40c92
DA
21772011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2178
2179 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2180 avoid crash when xmalloc overrun checking is enabled.
2181
d4172c3b
EZ
21822011-10-13 Eli Zaretskii <eliz@gnu.org>
2183
2184 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2185 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2186 cursor motion with <left> and <right> arrow keys.
2187
2188 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2189 some callers set that themselves.
2190
b00eea75
EZ
21912011-10-12 Eli Zaretskii <eliz@gnu.org>
2192
2193 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2194 display string and the previous row comes from the same string and
2195 is empty. (Bug#9739) (Bug#9738)
2196
8fe012c4
SM
21972011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2198
2199 * doc.c (get_doc_string): Encode file name (bug#9735).
2200
0074aef2
EZ
22012011-10-12 Eli Zaretskii <eliz@gnu.org>
2202
79beb178
EZ
2203 * bidi.c (bidi_level_of_next_char):
2204 * xdisp.c (get_visually_first_element): Remove old incorrect
2205 comments regarding the Unicode Line Separator character.
2206
0074aef2
EZ
2207 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2208
6e4b3fbe
DA
22092011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2210
2211 * alloc.c (Fgc_status): Do not access beyond zombies array
2212 boundary if nzombies > MAX_ZOMBIES.
2213 * alloc.c (dump_zombies): Add missing format specifier.
2214
0324f3af
PE
22152011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2216
b5525cac
PE
2217 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2218 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2219
0324f3af
PE
2220 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2221 Some packages use them to denote characters with modifiers.
2222
e9b5f888
AS
22232011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2224
2225 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2226 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2227 matching a pp-number. Rename parameter var to var1.
2228
127827c0
SM
22292011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2230
2231 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2232
c8fd3bd0
GM
22332011-10-08 Glenn Morris <rgm@gnu.org>
2234
2235 * callint.c (Fcall_interactively): Give a more explicit error for the
2236 'c' case with a non-character input. (Bug#8479)
2237
352ec8ff
EZ
22382011-10-08 Eli Zaretskii <eliz@gnu.org>
2239
03669ccb
EZ
2240 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2241 lines.
7061c986
EZ
2242 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2243 lines that are hscrolled on the left.
03669ccb 2244
352ec8ff
EZ
2245 * dispnew.c (buffer_posn_from_coords): Account for a possible
2246 presence of header-line. (Bug#4426)
2247
a66cfb1c
SM
22482011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2249
6b02f655
SM
2250 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2251 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2252
7c5ee88e
PE
22532011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2254
2255 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2256 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2257 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2258 this makes Emacs dump core during garbage collection on rare
2259 occasions. sizeof is obviously inferior to offsetof here, so
2260 stick with offsetof.
2261 (GC_POINTER_ALIGNMENT): New macro.
2262 (mark_memory): Omit 3rd (offset) arg; caller changed.
2263 Don't assume EMACS_INT alignment is the same as pointer alignment.
2264
df1bbe5b
SM
22652011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2266
2267 * keyboard.c (read_key_sequence_remapped): New var.
2268 (read_key_sequence): Compute remapping in the right buffer.
2269 (command_loop_1): Use read_key_sequence's remapping directly.
2270
51553db6
SM
22712011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2272
32c1fffd
SM
2273 * dired.c (file_name_completion): Don't expand file name.
2274 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2275 before checking file name handler.
2276
51553db6
SM
2277 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2278 they've been requested explicitly (bug#9591).
2279
b6bd1599 22802011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2281
2282 * keymap.c (Fsingle_key_description): Use make_specified_string
2283 instead of build_string to build string from push_key_description.
2284 (Bug#5193)
2285
f701dc2a
PE
22862011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2287
4222c55d
PE
2288 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2289 This fixes a Y2038 bug on 64-bit hosts.
2290 * buffer.c (reset_buffer):
2291 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2292 (Fclear_buffer_auto_save_failure):
2293 Use 0, not -1, to represent an unset failure time, since time_t
2294 might not be signed.
2295
f701dc2a
PE
2296 Remove dependency on glibc malloc internals.
2297 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2298 Move back here from lisp.h, but with their new implementations.
2299 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2300 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2301 * charset.c (charset_table_init): New static var.
2302 (syms_of_charset): Use it instead of xmalloc. This removes a
2303 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2304 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2305 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2306 Move back to alloc.c.
2307 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2308 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2309
9ceebf39
JD
23102011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2311
2312 * nsterm.m (windowDidResize): Call x_set_window_size only when
2313 ns_in_resize is true. Otherwise set pixelwidth/height and
2314 call change_frame_size (Bug#9628).
2315
cb993c58
PE
23162011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2317
3930c88b
PE
2318 Port --enable-checking=all to Fedora 14 x86-64.
2319 * charset.c (syms_of_charset): Also account for glibc malloc's
2320 internal overhead when calculating the initial malloc maximum.
2321
cb993c58
PE
2322 Port --enable-checking=all to Fedora 14 x86.
2323 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2324 Move to lisp.h.
2325 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2326 (overrun_check_realloc, overrun_check_free):
2327 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2328 That way, xmalloc returns a properly-aligned pointer even if
2329 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2330 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2331 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2332 into account when calculating the initial malloc maximum.
2333 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2334 Move here from alloc.c, so that charset.c can use it too.
2335 Properly align; the old code wasn't right for common 32-bit hosts
2336 when configured with --enable-checking=all.
2337 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2338 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2339
31bed486
EZ
23402011-09-29 Eli Zaretskii <eliz@gnu.org>
2341
04c70788 2342 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2343 use EDOM.
2344
fbcaa2f3
EZ
23452011-09-28 Eli Zaretskii <eliz@gnu.org>
2346
2347 * xdisp.c (compute_display_string_end): If there's no display
2348 string at CHARPOS, return -1.
2349
2350 * bidi.c (bidi_fetch_char): When compute_display_string_end
2351 returns a negative value, treat the character as a normal
2352 character not covered by a display string. (Bug#9624)
2353
a239d4e9
JB
23542011-09-28 Juanma Barranquero <lekktu@gmail.com>
2355
2356 * lread.c (Fread_from_string): Fix typo in docstring.
2357
88652fd5
EZ
23582011-09-27 Eli Zaretskii <eliz@gnu.org>
2359
2360 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2361 newline, reseat the iterator instead of bidi-iterating there one
2362 character at a time. (Bug#9610)
32c1fffd
SM
2363 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2364 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2365
ed497dd4
AS
23662011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2367
2368 * lread.c (readevalloop): Use correct code for NBSP.
2369 (read1): Likewise. (Bug#9608)
2370
b2bf61aa
MA
23712011-09-25 Michael Albinus <michael.albinus@gmx.de>
2372
2373 * dbusbind.c (Fdbus_register_signal): When service is not
2374 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2375
32bbb17c
GM
23762011-09-25 Glenn Morris <rgm@gnu.org>
2377
2378 * buffer.c (truncate-lines): Doc fix.
2379
94e0933e
CY
23802011-09-24 Chong Yidong <cyd@stupidchicken.com>
2381
2382 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2383 (Fset_window_next_buffers): Doc fix.
2384
cddde921
GM
23852011-09-24 Glenn Morris <rgm@gnu.org>
2386
2387 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2388
1260aef1
PE
23892011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2390
25b4bfa0
PE
2391 Fix minor problems found by static checking.
2392 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2393 * indent.c (Fvertical_motion): Fix == vs = typo.
2394
e3cbd34b
EZ
23952011-09-24 Eli Zaretskii <eliz@gnu.org>
2396
a66cfb1c
SM
2397 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2398 Default value is now t. Doc fix.
6bf7006f 2399
e3cbd34b 2400 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2401 logic when moving up, not only when moving down. Fix the
e3cbd34b 2402 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2403 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2404
2405 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2406 CHARPOS is covered by a display string which includes newlines.
2407 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2408 is covered by a display string with embedded newlines.
2409
a3de0cbd
MA
24102011-09-24 Michael Albinus <michael.albinus@gmx.de>
2411
2412 * dbusbind.c (Fdbus_register_signal): Add match rule to
2413 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2414 (Fdbus_register_method, Vdbus_registered_objects_table):
2415 Fix docstring.
a3de0cbd 2416
b260039d
JM
24172011-09-24 Jim Meyering <meyering@redhat.com>
2418
32c1fffd 2419 do not ignore write error for any output size
b260039d
JM
2420 The previous change was incomplete.
2421 While it makes emacs --batch detect the vast majority of stdout
2422 write failures, errors were still ignored whenever the output size is
2423 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2424 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2425 && echo FAIL: ignored write error
2426 FAIL: ignored write error
2427 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2428 && echo FAIL: ignored write error
2429 FAIL: ignored write error
2430 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2431
8eca8a7c
AS
24322011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2433
2434 * emacs.c (Fkill_emacs): In noninteractive mode exit
2435 non-successfully if a write error occurred on stdout. (Bug#9574)
2436
3341db62
EZ
24372011-09-21 Eli Zaretskii <eliz@gnu.org>
2438
2439 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2440 the xassert test.
2441
2442 * dispextern.h (struct it): Update the comment documenting what
2443 can it->OBJECT be.
2444
8c203dbf
EZ
24452011-09-20 Eli Zaretskii <eliz@gnu.org>
2446
2447 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2448 a display string, extend search for cursor position to end of row.
2449 (find_row_edges): If the row ends in a newline from a display
2450 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2451 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2452 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2453 non-empty line. Fixes confusing cursor motion with arrow keys at
2454 the beginning of a line that starts with whitespace.
8c203dbf 2455
a4824228
LMI
24562011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2457
2458 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2459 (bug#9493).
2460
33ed493b
CY
24612011-09-18 Chong Yidong <cyd@stupidchicken.com>
2462
2463 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2464 boolean (Bug#9154).
2465
56cd55c8
EZ
24662011-09-18 Eli Zaretskii <eliz@gnu.org>
2467
2468 * xdisp.c (display_line): Record maximum and minimum buffer
2469 positions even if no glyphs were produced (e.g., by a zero-width
2470 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2471 buffer positions that will be removed from the glyph row because
2472 they don't fit.
c02dcedf
EZ
2473 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2474 column is beyond frame width: don't subtract 1 "pixel" when
2475 computing width of the stretch.
3e62b7e0
EZ
2476 (reseat_at_next_visible_line_start): Undo the change made on
2477 2011-09-17 that saved paragraph information and restored it after
2478 the call to `reseat'. (Bug#9545)
56cd55c8 2479
5ed99d36 24802011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2481
2482 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2483 and turn window cursor on if cleared (Bug#9415).
2484
5ed99d36 24852011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2486
2487 * search.c (boyer_moore): Take unibyte characters from pattern
2488 literally. (Bug#9458)
2489
9bade7b2
EZ
24902011-09-18 Eli Zaretskii <eliz@gnu.org>
2491
2492 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2493
e5e9d610
PE
24942011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2495
87e4427a
PE
2496 Fix minor problem found by static checking.
2497 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2498 initialized, to pacify gcc -Wuninitialized.
2499
e5e9d610
PE
2500 * fileio.c: Report proper errno when syscall falls.
2501 (Finsert_file_contents): Save and restore errno,
2502 so that report_file_error outputs the correct diagnostic.
2503 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2504
a1674f0b
EZ
25052011-09-18 Eli Zaretskii <eliz@gnu.org>
2506
2507 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2508
fbfb6dd4
EZ
25092011-09-17 Eli Zaretskii <eliz@gnu.org>
2510
2511 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2512 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2513
bb187662
EZ
25142011-09-17 Eli Zaretskii <eliz@gnu.org>
2515
1137e8b8 2516 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2517 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2518
2519 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2520 (bidi_find_paragraph_start): Search back for paragraph beginning
2521 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2522 (bidi_move_to_visually_next): Only trigger paragraph-related
2523 computations when the last character is a newline or at EOB, not
2524 just any NEUTRAL_B. (Bug#9470)
2525
bb187662
EZ
2526 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2527 truncated lines if point is covered by a display string. (Bug#9524)
2528
2e621251
PE
25292011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2530
2531 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2532 (cons_to_x_long): New function.
2533 (lisp_data_to_selection_data): Use it. Correct the test for
2534 short-versus-long data; it was negated. Break out of vector
2535 loop, for efficiency, when a long datum is discovered.
2536
91a15bc6
SM
25372011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2538
2539 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2540
b41c3a35
EZ
25412011-09-16 Eli Zaretskii <eliz@gnu.org>
2542
2543 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2544 GCC PR/17406) by declaring this function with external scope.
2545
7812ba2d
PE
25462011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2547
2548 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2549 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2550
cf7edc2a
AS
25512011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2552
2553 * editfns.c (Fformat): Correctly handle text properties on "%%".
2554
bd01620e
EZ
25552011-09-15 Eli Zaretskii <eliz@gnu.org>
2556
2557 * xterm.c (x_draw_composite_glyph_string_foreground):
2558 * w32term.c (x_draw_composite_glyph_string_foreground):
2559 * term.c (encode_terminal_code):
2560 * composite.c (composition_update_it, get_composition_id):
2561 * xdisp.c (get_next_display_element)
2562 (fill_composite_glyph_string): Add comments about special meaning
2563 of TAB characters in a composition.
2564
a02719a3
PE
25652011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2566
2567 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2568 This occurs when processing a multibyte format.
2569 Problem reported by Wolfgang Jenker.
a02719a3 2570
72589a3c
JB
25712011-09-15 Johan Bockgård <bojohan@gnu.org>
2572
2573 * xdisp.c (try_cursor_movement): Only check for exact match if
2574 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2575
1c14176c
PE
25762011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2577
2578 Remove unused external symbols.
2579 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2580 * xdisp.c (calc_pixel_width_or_height): Now static.
2581 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2582 * indent.c (check_display_width):
2583 * w32term.c: Fix comment to match code.
2584 * xterm.c, xterm.h (x_catching_errors): Remove.
2585
d2eea5b5
PE
25862011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2587
2588 * xselect.c: Use signed conversions more consistently (Bug#9498).
2589 (selection_data_to_lisp_data): Assume incoming selection data are
2590 signed integers, not unsigned. This is to be consistent with
2591 outgoing selection data, which was modified to use signed integers
2592 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2593 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2594 expects long, not unsigned long.
2595
46888499
EZ
25962011-09-14 Eli Zaretskii <eliz@gnu.org>
2597
2598 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2599 computation of loop end. Reported by Johan Bockgård
2600 <bojohan@gnu.org>.
2601
ef8ef9fb
CY
26022011-09-13 Chong Yidong <cyd@stupidchicken.com>
2603
2604 * frame.c (Fother_visible_frames_p): Function deleted.
2605
fa819fed
EZ
26062011-09-12 Eli Zaretskii <eliz@gnu.org>
2607
2608 * indent.c (compute_motion): Process display vector front to back
2609 rather than the other way around. (Bug#2496)
2610
2ba8e008
SM
26112011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2612
2613 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2614
20f53c69
CY
26152011-09-11 Chong Yidong <cyd@stupidchicken.com>
2616
2617 * minibuf.c (Fread_from_minibuffer): Doc fix.
2618
d562d7a4
EZ
26192011-09-11 Eli Zaretskii <eliz@gnu.org>
2620
2621 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2622 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2623
1c4d7f3d
LMI
26242011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2625
2626 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2627 value for non-existent files.
2628
b885bf36
EZ
26292011-09-11 Eli Zaretskii <eliz@gnu.org>
2630
2631 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2632 set its "size" to -1. This will set the modtime_size field of
2633 the corresponding buffer to -1, which is what
2634 verify-visited-file-modtime expects for files that do not exist.
2635 (Bug#9139)
2636
6612f0bf
PE
26372011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2638
2639 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2640 here ...
2641 * lisp.h: ... from here. push_key_description is no longer
2642 defined in keyboard.c, so its declaration should not be in
2643 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2644 logically belongs with push_key_description.
2645
dfb3f755
PE
26462011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2647
2648 * buffer.h: Include <sys/types.h> instead of <time.h>.
2649 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2650 Problem reported by Herbert J. Skuhra.
2651
3134906c
LMI
26522011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2653
2654 * xml.c (parse_region): Make the parsing work for
2655 non-comment-starting XML files again (bug#9144).
2656
8d903f4e
AS
26572011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2658
2659 * image.c (gif_load): Fix calculation of bottom and right corner.
2660 (Bug#9468)
2661
80ad64f4
EZ
26622011-09-10 Eli Zaretskii <eliz@gnu.org>
2663
2664 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2665 redisplay in small windows.
2666
208a048d
EZ
26672011-09-09 Eli Zaretskii <eliz@gnu.org>
2668
2669 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2670
9b1c252e
MR
26712011-09-08 Martin Rudalics <rudalics@gmx.at>
2672
2673 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2674 Operate on live windows only.
2675
2949f33b
JB
26762011-09-08 Juanma Barranquero <lekktu@gmail.com>
2677
2678 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2679
e08dcafd
EZ
26802011-09-07 Eli Zaretskii <eliz@gnu.org>
2681
2682 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2683 only under bidi iteration.
2684
115b96bd
JD
26852011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2686
2687 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2688
c8199d0f
PE
26892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2690
2691 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2692 Without this fix, the command to link temacs failed due to an
2693 undefined symbol __builtin_isnan. This is because
2694 /usr/include/iso/math_c99.h #defines isnan(x) to
2695 __builtin_isnan(x), but the bundled gcc, which identifies itself
2696 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2697 a __builtin_isnan.
2698 * floatfns.c (isnan): #undef, and then #define to a clone of
2699 what's in data.c.
2700 (Fisnan): Always define, since it's always available now.
2701 (syms_of_floatfns): Always define isnan at the Lisp level.
2702
e39b275c 27032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2704
2705 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2706
b2db44d9 27072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2708
f4af5137 2709 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2710 The previous code assumed that file offsets (off_t values) fit in
2711 EMACS_INT variables, which is not true on typical 32-bit hosts.
2712 The code messed up by falsely reporting buffer overflow in cases
2713 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2714 when "big" contains more than 2**29 bytes, even though this
2715 inserts just one byte and does not overflow the buffer.
2716 (Finsert_file_contents): Store file offsets as off_t
2717 values, not as EMACS_INT values. Check for overflow when
2718 converting between EMACS_INT and off_t. When checking for
2719 buffer overflow or for overlap, take the offsets into account.
2720 Don't use EMACS_INT for small values where int suffices.
2721 When checking for overlap, fix a typo: ZV was used where
2722 ZV_BYTE was intended.
2723 (Fwrite_region): Don't assume off_t fits into 'long'.
2724 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2725
ecfc0a49
MA
27262011-09-05 Michael Albinus <michael.albinus@gmx.de>
2727
2728 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2729
6511acf2 27302011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2731
0999621a 2732 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2733
2734 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2735 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2736 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2737 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2738 (modify_event_symbol): Do not assume that the length of
2739 name_alist_or_stem is safe to alloca and fits in int.
2740 (Fexecute_extended_command): Likewise for function name and binding.
2741 (Frecursion_depth): Wrap around reliably on integer overflow.
2742 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2743 since some callers pass EMACS_INT values.
2744 (Fsingle_key_description): Don't crash if symbol name contains more
2745 than MAX_ALLOCA bytes.
2746 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2747 (get_minibuffer): Arg is now EMACS_INT, not int.
2748 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2749 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2750 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2751
2be7d702
PE
2752 * dbusbind.c (signature_cat): New function.
2753 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2754 Do not overrun buffer; instead, report string overflow.
2755
9d1df220
PE
2756 * dispnew.c (add_window_display_history): Don't overrun buffer.
2757 Truncate instead; this is OK since it's just a log.
2758
33ef5c64
PE
2759 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2760 even if the time zone offset is outlandishly large.
2761 Don't mishandle offset == INT_MIN.
2762
66c6fdd5
PE
2763 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2764 when creating daemon; the previous buffer-overflow check was incorrect.
2765
d749b01b
PE
2766 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2767 which has the guts of the old verror function.
2768
b5cd1905
PE
2769 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2770 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2771
6e1a67fb
PE
2772 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2773 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2774 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2775 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2776 length of string rather than counting it via multiple sprintfs;
2777 that's simpler and more reliable.
c21721cc
PE
2778 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2779 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2780 sprintf, in case result does not fit in int.
2781
c57b67fc
PE
2782 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2783 (fontset_from_font): Print it.
2784
8a401434
PE
2785 * frame.c (tty_frame_count): Now printmax_t, not int.
2786 (make_terminal_frame, set_term_frame_name): Print it.
2787 (x_report_frame_params): In X, window IDs are unsigned long,
2788 not signed long, so print them as unsigned.
2789 (validate_x_resource_name): Check for implausibly long names,
2790 and don't assume name length fits in 'int'.
2791 (x_get_resource_string): Don't blindly alloca invocation name;
2792 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2793 not fit in int.
2794
6e1a67fb
PE
2795 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2796 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2797 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2798
0df02bf3
PE
2799 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2800 Use esprintf, not sprintf, in case result does not fit in int.
2801
48e30793
PE
2802 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2803 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2804 it as a large positive number.
2805 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2806 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2807
a66ff6d8
PE
2808 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2809 in case result does not fit in int.
2810
aca216ff
PE
2811 * print.c (float_to_string): Detect width overflow more reliably.
2812 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2813 buffer overrun. Don't assume list length fits in 'int'. Treat
2814 print length of 0 as 0, not as infinity; to be consistent with other
2815 uses of print length in this function. Don't overflow print length
2816 index. Don't assume hash table size fits in 'long', or that
2817 vectorlike size fits in 'unsigned long'.
2818
31c286f7
PE
2819 * process.c (make_process): Use printmax_t, not int, to format
2820 process-name gensyms.
2821
55e5faa1
PE
2822 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2823
80f2e268
PE
2824 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2825 to avoid potential buffer overrun.
2826
670741ab
PE
2827 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2828 if X resource line is longer than 512 bytes.
2829
b7163a50
PE
2830 * xfns.c (x_window): Make sprintf buffer a bit bigger
2831 to avoid potential buffer overrun.
2832
ae58ff1f
PE
2833 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2834
c43c8a6a
PE
2835 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2836
3f8236f4
PE
28372011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2838
53e9fe90 2839 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2840 Without these, Emacs silently mishandles large integers sometimes.
2841 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2842 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2843
6511acf2
PE
2844 * xdisp.c (try_window_id): Check Emacs fixnum range before
2845 converting to 'int'.
806add1d 2846
6511acf2 2847 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2848 Check that an Emacs fixnum is in range before assigning it to 'int'.
2849 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2850 values converted from Emacs fixnums.
2851 (Frecenter): Don't wrap around a line count if it is out of 'int'
2852 range; instead, treat it as an extreme value.
2853 (Fset_window_configuration, compare_window_configurations):
2854 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2855
6511acf2
PE
2856 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2857 that can exceed INT_MAX. Check that EMACS_INT value is in range
2858 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2859 (match_limit): Don't assume that a fixnum can fit in 'int'.
2860
6511acf2 2861 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2862 exceed INT_MAX.
2863
6511acf2 2864 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2865 (Fvertical_motion): Don't wrap around LINES values that don't fit
2866 in 'int'. Instead, treat them as extreme values. This is good
2867 enough for windows, which can't have more than INT_MAX lines anyway.
2868
fcb901a7
LMI
28692011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2870
0f2f6b6d
LMI
2871 * Require libxml/parser.h to avoid compilation warning.
2872
fcb901a7
LMI
2873 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2874
2875 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2876 since this reportedly can destroy thread storage.
2877
6e20a0d4
CY
28782011-08-30 Chong Yidong <cyd@stupidchicken.com>
2879
2880 * syntax.c (find_defun_start): Update all cache variables if
2881 exiting early (Bug#9401).
2882
148ae00e
EZ
28832011-08-30 Eli Zaretskii <eliz@gnu.org>
2884
f6cfbd8f
EZ
2885 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2886
148ae00e
EZ
2887 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2888 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2889 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2890
2891 * term.c (tty_append_glyph): New function.
2892 (produce_stretch_glyph): Static function and its prototype deleted.
2893
a66cfb1c
SM
2894 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2895 Add prototypes.
148ae00e 2896
c4a07a4c
PE
28972011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2898
2899 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2900 when checking :margin (Bug#9390).
2901 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2902 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2903 so that the name doesn't mislead. All uses changed.
2904
6bc8cd65
JB
29052011-08-28 Johan Bockgård <bojohan@gnu.org>
2906
2907 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2908 set_tty_hooks.
2909
dca4927e
EZ
29102011-08-27 Eli Zaretskii <eliz@gnu.org>
2911
2912 * xdisp.c (move_it_to): Don't bail out early when reaching
2913 position beyond to_charpos, if we are scanning backwards.
2914 (move_it_vertically_backward): When DY == 0, make sure we get to
2915 the first character in the line after the newline.
2916
f2cad773
PE
29172011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2918
2919 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2920 (ccl_driver): Do not generate an out-of-range pointer.
2921 (Fccl_execute_on_string): Remove unnecessary check for
2922 integer overflow, noted by Stefan Monnier in
2923 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2924 Remove a FIXME that didn't need fixing.
2925 Simplify the newly-introduced buffer reallocation code.
2926
0cae2cdb
JB
29272011-08-27 Juanma Barranquero <lekktu@gmail.com>
2928
2929 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2930
5fc295a4 29312011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2932
70c60eb2 2933 Integer and memory overflow issues (Bug#9196).
726e0ab1 2934
d31850da
PE
2935 * doc.c (get_doc_string): Rework so that
2936 get_doc_string_buffer_size is the actual buffer size, rather than
2937 being 1 less than the actual buffer size; this makes xpalloc more
2938 convenient.
2939
a69fbedb
PE
2940 * image.c (x_allocate_bitmap_record, cache_image):
2941 * xselect.c (Fx_register_dnd_atom):
2942 Simplify previous changes by using xpalloc.
2943
fe5c5d37
PE
2944 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2945 since either will do and ptrdiff_t is convenient with xpalloc.
2946
0065d054
PE
2947 * charset.c (charset_table_size)
2948 (struct charset_sort_data.priority): Now ptrdiff_t.
2949 (charset_compare): Don't overflow if priorities differ greatly.
2950 (Fsort_charsets): Don't assume list length fits in int.
2951 Check for size-calculation overflow when allocating sort data.
2952 (syms_of_charset): Allocate an initial charset table that is
2953 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2954
2955 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2956
2957 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2958 The actual value is always <= INT_MAX, and leaving it unsigned made
2959 overflow checking harder.
2960
2961 * dispextern.h (struct glyph_matrix.rows_allocated)
2962 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2963 with xpalloc. The values are still always <= INT_MAX.
2964
2965 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2966
2967 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2968 (SAFE_NALLOCA): New macro.
2969
2970 * region-cache.c (struct boundary.pos, find_cache_boundary)
2971 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2972 (set_cache_region, invalidate_region_cache)
2973 (revalidate_region_cache, know_region_cache, region_cache_forward)
2974 (region_cache_backward, pp_cache):
2975 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2976 so that ptrdiff_t * can be passed to xpalloc.
2977 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2978 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2979 (pp_cache): Don't assume cache_len fits in int.
2980 * region-cache.h: Adjust extern decls to match.
2981
2982 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2983 EMACS_INT, since either will do, for xpalloc.
2984
2985 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2986 (xnmalloc, xnrealloc, xpalloc): New functions.
2987
726e0ab1
PE
2988 * bidi.c (bidi_shelve_header_size): New constant.
2989 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2990 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2991
51f30bc5 2992 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2993 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2994 (overlay_strings):
2995 Don't update size of array until after memory allocation succeeds,
2996 because xmalloc/xrealloc may not return.
0065d054
PE
2997 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2998 now that we have proper integer overflow checking.
2999 (record_overlay_string, overlay_strings): Catch overflows when
3000 calculating size of overlay_str_buf.
726e0ab1 3001
0065d054
PE
3002 * callproc.c (Fcall_process): Check for size overflow when
3003 calculating size of args2.
3004 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3005 Normally we prefer signed values, but sticking with ptrdiff_t would
3006 require adding more-complicated checks.
726e0ab1
PE
3007
3008 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3009 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3010 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 3011 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
3012
3013 * character.c (Fstring): Check for size-calculation overflow.
3014
3015 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3016 unnecessary integer overflow. Check for size overflow.
3017 (encode_coding_object): Don't update size until xmalloc succeeds.
3018
3019 * composite.c (get_composition_id): Check for overflow in glyph
3020 length calculations.
3021
3022 Integer and memory overflow fixes for display code.
3023 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3024 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3025 (scrolling_window): Check for overflow in size calculations.
3026 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3027 Don't assume glyph table len fits in int.
3028 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3029 (row_table_size): Now ptrdiff_t, not int.
3030 (scrolling_window): Avoid overflow in size calculations.
3031 Don't update size until allocation succeeds.
3032 * fns.c (concat): Check for overflow in size calculations.
3033 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3034 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3035 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3036
3037 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3038 (get_doc_string): Check for size calculation overflow.
3039 Don't update size until allocation succeeds.
3040 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3041 EMACS_INT, where ptrdiff_t will do.
3042 (Fsubstitute_command_keys): Check for string overflow.
3043
3044 * editfns.c (set_time_zone_rule): Don't assume environment length
3045 fits in int.
3046 (message_length): Now ptrdiff_t, not int.
3047 (Fmessage_box): Don't update size until allocation succeeds.
3048 Don't assume message length fits in int.
3049 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3050
0065d054
PE
3051 * emacs.c (main): Do not reallocate argv, since there is a null at
3052 the end that can be overwritten, and this way there's no need to
3053 worry about size-calculation overflow.
3054 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3055
3056 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3057 alloc succeeds.
3058 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3059
3060 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3061 (x_set_scroll_bar_width, x_figure_window_size):
3062 Check for integer overflow.
3063 (x_set_alpha): Do not assume XINT fits in int.
3064
3065 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3066 This is for the members text_lines, text_cols, total_lines, total_cols,
3067 where the system imposes an 'int' limit.
3068
3069 * fringe.c (Fdefine_fringe_bitmap):
3070 Don't update size until alloc works.
3071
3072 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3073 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3074
3075 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3076 Check for size-calculation overflow.
3077 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3078 do, as we prefer signed integers.
3079 (id_to_widget.max_size, id_to_widget.used)
3080 (xg_store_widget_in_map, xg_remove_widget_from_map)
3081 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3082 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3083 Use and return ptrdiff_t, not int.
3084 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3085 * gtkutil.h: Change prototypes to match the above.
3086
3087 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3088 are duplicate now that they've been promoted to lisp.h.
3089 (x_allocate_bitmap_record, x_alloc_image_color)
3090 (make_image_cache, cache_image, xpm_load):
3091 Don't update size until alloc is done.
3092 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3093 (x_detect_edges):
3256efce 3094 Check for size calculation overflow.
726e0ab1
PE
3095 (ct_colors_allocated_max): New constant.
3096 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3097 overflow.
3256efce 3098
726e0ab1
PE
3099 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3100 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3101 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3102 Use ptrdiff_t, not int, to count maps.
3103 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3104 calculations. Don't update size until allocation succeeds.
3105 Redo calculations to avoid overflow.
726e0ab1
PE
3106 * keyboard.h: Change prototypes to match the above.
3107
3108 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3109 to count maps.
3110 (current_minor_maps): Check for size calculation overflow.
3111 * keymap.h: Change prototypes to match the above.
3112
3113 * lread.c (read1, init_obarray): Don't update size until alloc done.
3114
3115 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3116 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3117
726e0ab1
PE
3118 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3119 Now ptrdiff_t, not int.
3120 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3121 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3122
3123 * process.c (Fnetwork_interface_list): Check for overflow
3124 in size calculation.
3125
3126 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3127
3128 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3129 overflow. Don't bother calling xmalloc when xrealloc will do.
3130
3131 * search.c (Freplace_match): Check for size calculation overflow.
3132 (Fset_match_data): Don't assume list lengths fit in 'int'.
3133
3134 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3135 for command line length. Do not attempt to address one before the
3136 beginning of an array, as that's not portable.
3137
3138 * term.c (max_frame_lines): Remove; unused.
3139 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3140 not int.
3141 (encode_terminal_code, calculate_costs): Check for size
3142 calculation overflow.
3143 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3144 table lengths and related sizes. Don't update size until alloc
3145 done. Redo calculations to avoid overflow.
3146 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3147
3148 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3149 subtracting pointers.
3150 (gobble_line): Check for overflow more carefully. Don't update size
3151 until alloc done.
3152
3153 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3154 Don't update size until alloc done.
3155 Redo size calculations to avoid overflow.
3156 Check for size calculation overflow.
0065d054 3157 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3158
3159 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3160 Use ptrdiff_t, not int, for sizes.
3161 (store_mode_line_noprop_char): Don't update size until alloc done.
3162
0065d054
PE
3163 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3164 Use ptrdiff_t, not int, for sizes.
3165 (Finternal_make_lisp_face, cache_face):
3166 Check for size calculation overflow.
3167 (cache_face): Treat size calculation overflows as if they were
3168 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3169
3170 * xfns.c (x_encode_text, x_set_name_internal)
3171 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3172 sizes, since they can exceed INT_MAX in size. Check for size
3173 calculation overflow.
3174
0065d054
PE
3175 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3176 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3177 Don't update size until alloc done.
3178
0065d054 3179 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3180 as sprintf is limited to int lengths.
1d526e2f 3181
252c5ee1
PE
3182 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3183 (X_LONG_MIN): New macros.
864d7ce7
PE
3184 Use them to make the following changes clearer.
3185 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3186 This change doesn't affect the value now, but it may help remind
3187 future maintainers not to raise the value too much later.
3188 (SELECTION_QUANTUM): Remove, replacing with ...
3189 (selection_quantum): ... new function, which avoids overflow.
3190 All uses changed.
3191 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3192 assumption that selection length fits in 'int'.
3193 (x_reply_selection_request, x_handle_selection_request)
3194 (x_get_window_property, receive_incremental_selection)
3195 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3196 (lisp_data_to_selection_data, clean_local_selection_data):
3197 Use ptrdiff_t, not int, to record length of selection.
3198 (x_reply_selection_request, x_get_window_property)
3199 (receive_incremental_selection, x_property_data_to_lisp):
3200 Redo calculations to avoid overflow.
3201 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3202 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3203 something.
3204 (x_get_window_property, receive_incremental_selection)
3205 (lisp_data_to_selection_data, x_property_data_to_lisp):
3206 Check for size-calculation overflow.
3207 (x_get_window_property, receive_incremental_selection)
3208 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3209 Don't store size until memory allocation succeeds.
3210 (x_get_window_property): Plug memory leak on memory exhaustion.
3211 Don't double-block input; malloc is safe here. Don't assume 2**34
3212 - 4 fits in unsigned long. Add an xassert to check
3213 XGetWindowProperty overflow. Be more careful about overflow
3214 calculations, and distinguish size from memory overflow better.
3215 (receive_incremental_selection): When tracing, don't assume
3216 unsigned int is less than INT_MAX.
3217 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3218 harmful) conversions of unsigned short to int.
3219 (lisp_data_to_selection_data): Don't assume that integers
3220 in the range -65535 through -1 fit in an X unsigned short.
3221 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3222 result parameters unless successful. Rely on cons_to_unsigned
3223 to report problems with elements; the old code wasn't right anyway.
3224 (x_check_property_data): Check for int overflow; we cannot use
3225 a wider type due to X limits.
3226 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3227
726e0ab1 3228 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3229
0065d054
PE
3230 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3231 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3232 (x_color_cells): Don't store size until memory allocation succeeds.
3233 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3234 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3235 (x_term_init): Don't assume length fits in int (sprintf is limited
3236 to int size).
bc18e09d 3237
ebfa62c0
PE
3238 Use ptrdiff_t for composition IDs.
3239 * character.c (lisp_string_width):
3240 * composite.c (composition_table_size, n_compositions)
3241 (get_composition_id, composition_gstring_from_id):
3242 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3243 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3244 * window.c (Frecenter):
3245 Use ptrdiff_t, not int, for composition IDs.
3246 * composite.c (get_composition_id): Check for integer overflow.
3247 * composite.h: Adjust prototypes to match the above changes.
3248
d3411f89
PE
3249 Use ptrdiff_t for hash table indexes.
3250 * category.c (hash_get_category_set):
3251 * ccl.c (ccl_driver):
3252 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3253 * coding.c (coding_system_charset_list, detect_coding_system):
3254 * coding.h (struct coding_system.id):
3255 * composite.c (get_composition_id, gstring_lookup_cache):
3256 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3257 * image.c (xpm_get_color_table_h):
3258 * lisp.h (hash_lookup, hash_put):
3259 * minibuf.c (Ftest_completion):
3260 Use ptrdiff_t for hash table indexes, not int (which is too
3261 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3262 32-bit --with-wide-int hosts).
3263
e097a6fa
PE
3264 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3265 Add a FIXME comment about memory leaks.
3266 (syms_of_charset): Don't assume xmalloc returns.
3267
5637687f
PE
3268 Don't assume that stated character widths fit in int.
3269 * character.c (Fchar_width, c_string_width, lisp_string_width):
3270 * character.h (CHAR_WIDTH):
3271 * indent.c (MULTIBYTE_BYTES_WIDTH):
3272 Use sanitize_char_width to avoid undefined and/or bad behavior
3273 with outlandish widths.
a66cfb1c 3274 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3275 now that we have two such functions. All uses changed.
3276 (sanitize_char_width): New inline function.
3277
a2271ba2
PE
3278 Don't assume that tab-width fits in int.
3279 * character.h (sanitize_width): New inline function.
3280 (SANE_TAB_WIDTH): New macro.
3281 (ASCII_CHAR_WIDTH): Use it.
3282 * indent.c (sane_tab_width): Remove. All uses replaced by
3283 SANE_TAB_WIDTH (current_buffer).
3284 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3285
18c52557
PE
3286 * fileio.c: Integer overflow issues with file modes.
3287 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3288
caeeedc1
PE
3289 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3290 Remove unreachable code.
3291 (read_hex, load_charset_map_from_file): Check for integer overflow.
3292
6df6ae42 3293 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3294 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3295 (x_send_scroll_bar_event): Likewise. Check that the size does not
3296 exceed limits imposed by XClientMessageEvent, as well as the usual
3297 ptrdiff_t and size_t limits.
3298
b13995db
PE
3299 * keyboard.c: Overflow, signedness and related fixes.
3300 (make_lispy_movement): Use same integer type in forward decl
3301 that is used in the definition.
3302 (read_key_sequence, keyremap_step):
3303 Change bufsize argument back to int, undoing my 2011-03-30 change.
3304 We prefer signed types, and int is wide enough here.
3305 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3306 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3307 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3308 length, not size_t. Use ptrdiff_t for index, not int.
3309 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3310 possibility of integer overflow.
3311
13464394
PE
3312 Overflow, signedness and related fixes for images.
3313
3314 * dispextern.h (struct it.stack[0].u.image.image_id)
3315 (struct_it.image_id, struct image.id, struct image_cache.size)
3316 (struct image_cache.used, struct image_cache.ref_count):
3317 * gtkutil.c (update_frame_tool_bar):
3318 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3319 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3320 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3321 * nsmenu.m (update_frame_tool_bar):
3322 * xdisp.c (calc_pixel_width_or_height):
3323 * xfns.c (image_cache_refcount):
3324 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3325 on typical 64-bit hosts.
3326
3327 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3328 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3329 Omit unnecessary casts to int.
3330 (parse_image_spec): Check that integers fall into 'int' range
3331 when the callers expect that.
3332 (image_ascent): Redo ascent calculation to avoid int overflow.
3333 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3334 (lookup_image): Remove unnecessary tests.
3335 (xbm_image_p): Locals are now of int, not EMACS_INT,
3336 since parse_image_check makes sure they fit into int.
3337 (png_load, gif_load, svg_load_image):
3338 Prefer int to unsigned where either will do.
3339 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3340 old tiff_error_handler and tiff_warning_handler.
3341 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3342 stack buffer overflows. It uses only the features of vsnprintf
3343 that are common to both POSIX and native Microsoft.
3344 (tiff_error_handler, tiff_warning_handler): Use it.
3345 (tiff_load, gif_load, imagemagick_load_image):
3346 Don't assume :index value fits in 'int'.
3347 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3348 (imagemagick_load_image): Check that crop parameters fit into
3349 the integer types that MagickCropImage accepts. Don't assume
3350 Vimagemagick_render_type has a nonnegative value. Don't assume
3351 size_t fits in 'long'.
3352 (gs_load): Use printmax_t to print the widest integers possible.
3353 Check for integer overflow when computing image height and width.
3354
c11821d4
EZ
33552011-08-26 Eli Zaretskii <eliz@gnu.org>
3356
3357 * xdisp.c (redisplay_window): Don't force window start if point
3358 will be invisible in the resulting window. (Bug#9324)
3359
0c95fcf7
EZ
33602011-08-25 Eli Zaretskii <eliz@gnu.org>
3361
3362 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3363 the display spec is of the form `(space ...)'.
3364 (handle_display_spec): Return the value returned by
3365 handle_single_display_spec, not just 1 or zero.
3366 (handle_single_display_spec): If the display spec is of the form
3367 `(space ...)', and specifies display in the text area, return 2
3368 rather than 1.
fee65a97 3369 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3370 accurately, and prefer exact match for point under bidi.
3371 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3372
3373 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3374 into disp_prop; all users changed.
3375
3376 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3377 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3378 for the text covered by the display property.
3379
e4ed06f1
CY
33802011-08-25 Chong Yidong <cyd@stupidchicken.com>
3381
3382 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3383 Change return value to nil.
3384 (Frecord_buffer): Delete unused function.
3385
f67cdd7f
EZ
33862011-08-24 Eli Zaretskii <eliz@gnu.org>
3387
5980d4c6
EZ
3388 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3389 buffers, return left-to-right.
8610fe8b
EZ
3390 (set_cursor_from_row): Consider candidate row a win if its glyph
3391 represents a newline and point is on that newline. Fixes cursor
3392 positioning on the newline at EOL of R2L text within L2R
3393 paragraph, and vice versa.
3394 (try_cursor_movement): Check continued rows, in addition to
3395 continuation rows. Fixes unwarranted scroll when point enters a
3396 continued line of R2L text within an L2R paragraph, or vice versa.
3397 (cursor_row_p): Consider the case of point being equal to
3398 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3399 from the end of a short line to the beginning of a continued line
3400 of R2L text within L2R paragraph.
3401 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3402 composed characters.
5980d4c6 3403
f67cdd7f
EZ
3404 * bidi.c (bidi_check_type): Use xassert.
3405 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3406 members.
3407
bca633fb
EZ
34082011-08-23 Eli Zaretskii <eliz@gnu.org>
3409
3410 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3411 a character.
3412
4a5885a7
CY
34132011-08-23 Chong Yidong <cyd@stupidchicken.com>
3414
3415 * nsfont.m (ns_otf_to_script): Fix typo.
3416
0902a04e
KH
34172011-08-22 Kenichi Handa <handa@m17n.org>
3418
3419 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3420 extra slot even if the purpose is char-code-property-table.
3421
1a2e6670
EZ
34222011-08-23 Eli Zaretskii <eliz@gnu.org>
3423
8ddde651
EZ
3424 * xdisp.c (redisplay_window): When computing centering_position,
3425 account for the height of the header line. (Bug#8874)
3426
425cc014
EZ
3427 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3428 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3429 candidate is selected by the mouse, and that candidate has a
3430 composed character under the mouse.
3431
1a2e6670
EZ
3432 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3433 coordinates reported by pos-visible-in-window-p for a composed
3434 character in column zero.
3435
8b76d6f8
SM
34362011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3437
3438 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3439
dac347dd
EZ
34402011-08-22 Eli Zaretskii <eliz@gnu.org>
3441
3442 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3443 consider it a hit if to_charpos is anywhere in the range of the
3444 composed buffer positions.
3445
e013fb34
CY
34462011-08-22 Chong Yidong <cyd@stupidchicken.com>
3447
3448 * image.c (gif_load): Don't assume that each subimage has the same
3449 dimensions as the base image. Handle disposal method that is
3450 "undefined" by the gif spec (Bug#9335).
3451
bd1ba3e8
CY
34522011-08-20 Chong Yidong <cyd@stupidchicken.com>
3453
3454 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3455 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3456
54a1215b
EZ
34572011-08-19 Eli Zaretskii <eliz@gnu.org>
3458
823564e5
EZ
3459 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3460 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3461 from an Org mode buffer to a Speedbar frame.
3462
54a1215b
EZ
3463 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3464 a composition, take its buffer position from IT->cmp_it.charpos.
3465 Fixes cursor positioning at the beginning of a line that begins
3466 with a composed character.
3467
9778ebcc
EZ
34682011-08-18 Eli Zaretskii <eliz@gnu.org>
3469
0be6ee06
EZ
3470 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3471 character bidirectional type, use STRONG_L instead. Fixes crashes
3472 in a buffer produced by `describe-categories'.
3473
9778ebcc
EZ
3474 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3475 members before the level stack, so they would be saved and
3476 restored when copying iterator state. Fixes incorrect reordering
3477 around TABs covered by display properties.
3478
156bffbe
AS
34792011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3480
6b02f655 3481 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3482
72ad093b
CY
34832011-08-17 Chong Yidong <cyd@stupidchicken.com>
3484
3485 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3486 (internal_condition_case_2, internal_condition_case_n):
3487 Remove unnecessary aborts (Bug#9081).
72ad093b 3488
35774242
EZ
34892011-08-17 Eli Zaretskii <eliz@gnu.org>
3490
3491 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3492 has no `load' handler, try opening the file locally. (Bug#9311)
3493
db76dd85
KB
34942011-08-16 Ken Brown <kbrown@cornell.edu>
3495
3496 * gmalloc.c: Expand comment.
3497
b215eee5
EZ
34982011-08-16 Eli Zaretskii <eliz@gnu.org>
3499
3500 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3501 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3502
a4579d33
KB
35032011-08-16 Ken Brown <kbrown@cornell.edu>
3504
3505 Fix memory allocation problems in Cygwin build (Bug#9273).
3506
3507 * unexcw.c ( __malloc_initialized): Declare external variable.
3508 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3509
8b76d6f8
SM
3510 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3511 New variables.
a4579d33
KB
3512 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3513 dumped emacs.
3514 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3515 in the static heap.
3516 [CYGWIN] (special_realloc): New function.
3517 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3518 requests to realloc storage in the static heap.
3519
3ebec551
PE
35202011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3521
3522 * bidi.c (bidi_initialize): Remove unused local.
3523
9fd8be00
EZ
35242011-08-15 Eli Zaretskii <eliz@gnu.org>
3525
6b02f655
SM
3526 * bidimirror.h:
3527 * biditype.h: Remove file.
3528 * makefile.w32-in ($(BLD)/bidi.$(O)):
3529 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3530
3531 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3532
3533 * chartab.c: Improve commentary for the uniprop_table API.
3534
32413314
EZ
3535 * bidi.c (bidi_paragraph_init): Support zero value of
3536 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3537 (bidi_initialize): Use uniprop_table instead of including
3538 biditype.h and bidimirror.h.
32413314 3539
9fd8be00
EZ
3540 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3541 coordinates of the iterator when restoring from ppos_it.
3542 (Bug#9296)
3543
5cf2b69b
KH
35442011-08-14 Kenichi Handa <handa@m17n.org>
3545
3546 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3547 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3548
daf17d00
EZ
35492011-08-14 Eli Zaretskii <eliz@gnu.org>
3550
3551 * xdisp.c (move_it_in_display_line_to): Don't invoke
3552 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3553 ppos_it. Fixes vertical cursor motion when line beginning is
3554 covered by an image. (Bug#9296)
3555
08e3161a
JD
35562011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3557
3558 * nsterm.h (ns_run_ascript): Declare.
3559 (NSAPP_DATA2_RUNASSCRIPT): Define.
3560
3561 * nsfns.m (as_script, as_result, as_status): New static variables.
3562 (ns_run_ascript): New function.
5e617bc2 3563 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3564 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3565 the event loop. Get status from as_status (Bug#7276).
3566
3567 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3568 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3569 the event loop (Bug#7276).
3570
a3720aa2
AS
35712011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3572
3573 * gnutls.c (QCgnutls_bootprop_priority)
3574 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3575 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3576 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3577 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3578 (QCgnutls_bootprop_verify_hostname_error)
3579 (QCgnutls_bootprop_callbacks_verify): Rename from
3580 Qgnutls_bootprop_..., all uses changed.
3581
3582 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3583 uses changed.
3584
0a0d27fb
PE
35852011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3586
19d5c50c
PE
3587 * xfaces.c (Qframe_set_background_mode): Now static.
3588 * dispextern.h (Qframe_set_background_mode): Remove decl.
3589
0a0d27fb
PE
3590 * process.c (Fnetwork_interface_info): Declare local only if needed.
3591
377538cb
JD
35922011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3593
3594 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3595 (Fnetwork_interface_list): Allocate in increments of bytes instead
3596 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3597 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3598 sockaddr.
3599 (struct ifflag_def): notrailers is smart on OSX.
3600 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3601 Get hardware address with getifaddrs if available.
3602
08fff70c
EZ
36032011-08-12 Eli Zaretskii <eliz@gnu.org>
3604
3605 * xdisp.c (iterate_out_of_display_property): xassert that
3606 IT->position is set to within IT->object's boundaries. Break from
3607 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3608 when IT->position is set up wrongly due to some bug.
3609 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3610 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3611 entry. Force push_it to save on the stack the current
3612 buffer/string position, to be restored by pop_it. Fix flags in
3613 the iterator structure wrt the object coming from a display
3614 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3615 properties. (Bug#9284)
3616
7be1c708 36172011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3618
7be1c708
CY
3619 * fontset.c (fontset_get_font_group): Add proper type checks.
3620 (Bug#9172)
aac0c6e3 3621
7be1c708 36222011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3623
7be1c708
CY
3624 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3625 and LC_VERSION_MIN_MACOSX.
3626 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3627 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3628
97bb72a6
EZ
36292011-08-08 Eli Zaretskii <eliz@gnu.org>
3630
3631 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3632 no-display-properties-and-no-overlays under bidi display.
3633 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3634 properties and overlays.
97bb72a6 3635
d5617611
CY
36362011-08-08 Chong Yidong <cyd@stupidchicken.com>
3637
37e11a63
CY
3638 * editfns.c (Fset_time_zone_rule): Document relationship with the
3639 setenv function.
3640
d5617611
CY
3641 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3642 the font entity extracted from the cache (Bug#8109).
3643
58872834
CY
36442011-08-07 Chong Yidong <cyd@stupidchicken.com>
3645
3646 * composite.c (autocmp_chars): Don't reset point. That is done by
3647 restore_point_unwind (Bug#5984).
3648
75bfc667
JL
36492011-08-07 Juri Linkov <juri@jurta.org>
3650
3651 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3652 to show the arg `TIME' instead of `TIMEVAL'.
3653
d1410150
EZ
36542011-08-06 Eli Zaretskii <eliz@gnu.org>
3655
3656 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3657 display property strides EOL and includes a newline, as in
3658 longlines-mode. (Bug#9254)
75b771e4
EZ
3659 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3660 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3661
3662 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3663 is non-zero, even if the data buffer is NULL. Fixes a crash in
3664 vertical-motion with longlines-mode. (Bug#9254)
3665
35928349
EZ
36662011-08-05 Eli Zaretskii <eliz@gnu.org>
3667
ec7cc85b
EZ
3668 * bidi.c <bidi_cache_total_alloc>: Now static.
3669 (bidi_initialize): Initialize bidi_cache_total_alloc.
3670
8b76d6f8 3671 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3672 cache. (Bug#9221)
3673
3674 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3675 amount allocated this far in `bidi_cache_total_alloc'.
3676 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3677 non-zero, only free the data buffer without restoring the cache
3678 contents. All callers changed.
3679
3680 * dispextern.h (bidi_unshelve_cache): Update prototype.
3681
3682 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3683 (move_it_in_display_line, move_it_to)
3684 (move_it_vertically_backward, move_it_by_lines): Replace the call
3685 to xfree to an equivalent call to bidi_unshelve_cache.
3686 (move_it_in_display_line_to): Fix logic of returning
412b6358 3687 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3688
e2e2423b
EZ
36892011-08-05 Eli Zaretskii <eliz@gnu.org>
3690
3691 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3692 came from a string character with a `cursor' property. (Bug#9229)
3693
ae9e757a
JD
36942011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3695
3696 * Makefile.in (LIB_PTHREAD): New variable.
3697 (LIBES): Add LIB_PTHREAD (Bug#9216).
3698
3699 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3700 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3701
213bd7f2
AS
37022011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3703
6b02f655 3704 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3705
99aaf75f
JD
37062011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3707
3708 * xterm.c (x_find_topmost_parent): New function.
3709 (x_set_frame_alpha): Find topmost parent window with
3710 x_find_topmost_parent and set the property there also (bug#9181).
3711 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3712
c74e9d86
PE
37132011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3714
3715 * callproc.c (Fcall_process): Avoid vfork clobbering
3716 the local vars buffer, coding_systems, current_dir.
3717
640c8776
SM
37182011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3719
3720 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3721
f26d0e4c
PE
37222011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3723
8a10d76c
PE
3724 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3725 so that it is not optimized away.
3726
f26d0e4c
PE
3727 * xdisp.c (compute_display_string_pos): Remove unused local.
3728
55439c61
EZ
37292011-08-02 Eli Zaretskii <eliz@gnu.org>
3730
3731 Fix slow cursor motion and scrolling in large buffers with
3732 selective display, like Org Mode buffers. (Bug#9218)
3733
3734 * dispextern.h (struct bidi_it): New member disp_prop_p.
3735
3736 * xdisp.c: Remove one-slot cache of display string positions.
3737 (compute_display_string_pos): Accept an additional argument
5e617bc2 3738 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3739 for a display string or property. If found, set DISP_PROP_P
3740 non-zero.
3741
3742 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3743 DISP_PROP_P, and pass it to compute_display_string_pos.
3744 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3745 non-zero. All callers of bidi_fetch_char changed.
3746
fb33fa43
SM
37472011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3748
3749 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3750
b099e063
DM
37512010-12-03 Don March <don@ohspite.net>
3752
3753 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3754 last character M-[char] is translated to ESC [char] (bug#7541).
3755
5cc7f7af
KH
37562011-08-02 Kenichi Handa <handa@m17n.org>
3757
d0fffa3f 3758 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3759
3760 * chartab.c (uniprop_table): Make it non-static.
3761
525d5e6e
EZ
37622011-08-01 Eli Zaretskii <eliz@gnu.org>
3763
3764 * xdisp.c (forward_to_next_line_start): Accept additional argument
3765 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3766 on the newline.
3767 (reseat_at_next_visible_line_start): Use the bidi iterator state
3768 returned by forward_to_next_line_start to restore the state of
3769 it->bidi_it after backing up to previous newline. (Bug#9212)
3770
31011111
AS
37712011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3772
3773 * regex.c (re_comp): Protoize.
3774 (re_exec): Fix return type.
3775 (regexec): Fix type of `ret'. (Bug#9203)
3776
476371c4
PE
37772011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3778
e5d76069
PE
3779 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3780 This is needed if max-image-size is a floating-point number.
3781
9a79b20c
AS
37822011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3783
3784 * print.c (print_object): Print empty symbol as ##.
3785
3786 * lread.c (read1): Read ## as empty symbol.
3787
d8c2fa78
AA
37882011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3789
3790 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3791 setting frame foreground color (Bug#9175).
3792 (x_set_background_color): Likewise.
3793
ffe57a7a
AA
3794 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3795 contents (Bug#9176).
3796 (EmacsTooltip -init): Remove bezels and add shadows to
3797 tooltip windows.
3798
bf3492a5
AA
3799 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3800 or scroll bar (Bug#8470).
3801
d55e9c53
AA
3802 * nsfont.m (nsfont_open): Remove assignment to voffset and
3803 unnecessary vars hshink, expand, hd, full_height, min_height.
3804 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3805
3806 * nsterm.h (nsfont_info): Remove voffset field.
3807
d8c2fa78 38082011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3809
3810 Implement strike-through and overline on NextStep (Bug#8863).
3811
3812 * nsfont.m (nsfont_open): Use underline position provided by font,
3813 instead of hard-coded value of 2.
3814 (nsfont_draw): Call ns_draw_text_decoration instead.
3815
3816 * nsterm.h: Add declaration for ns_draw_text_decoration.
3817
3818 * nsterm.m (ns_draw_text_decoration): New function for drawing
3819 underline, overline, and strike-through.
3820 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3821 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3822 accommodate underlining, etc.
4843aac3 3823
4cc60b9b
EZ
38242011-07-28 Eli Zaretskii <eliz@gnu.org>
3825
bc7ece87
EZ
3826 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3827 default.
4cc60b9b 3828
476371c4
PE
38292011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3830
66606eea
PE
3831 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3832 Without this fix, if a signal arrives just after memory fills up,
3833 'malloc' might be invoked reentrantly.
3834
476371c4
PE
3835 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3836 In other words, assume that every image size is allowed, on non-X
3837 hosts. This assumption is probably wrong, but it lets Emacs compile.
3838
f3fcc40d
AS
38392011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3840
3841 * regex.c (re_iswctype): Convert return values to boolean.
3842
350c992f
EZ
38432011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3844
3845 * xdisp.c (compute_display_string_pos): Don't use cached display
3846 string position if the buffer had its restriction changed.
3847 (Bug#9184)
3848
5266b4bb
PE
38492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3850
3851 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3852
2573a837 38532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3854
41f55ccd 3855 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3856
39e378da
PE
3857 * bidi.c: Integer size and overflow fixes.
3858 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3859 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3860 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3861 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3862 (bidi_find_other_level_edge):
3863 Use ptrdiff_t instead of EMACS_INT where either will do.
3864 This works better on 32-bit hosts configured --with-wide-int.
3865 (bidi_cache_ensure_space): Check for size-calculation overflow.
3866 Use % rather than repeated addition, for better worst-case speed.
3867 Don't set bidi_cache_size until after xrealloc returns, because it
3868 might not return.
3869 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3870 (bidi_cache_ensure_space): Also check that the bidi cache size
3871 does not exceed that of the largest Lisp string or buffer. See Eli
3872 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3873
5e927815
PE
3874 * alloc.c (__malloc_size_t): Remove.
3875 All uses replaced by size_t. See Andreas Schwab's note
3876 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3877
ca4aa935
PE
3878 * image.c: Improve checking for integer overflow.
3879 (check_image_size): Assume that f is nonnull, since
3880 it is always nonnull in practice. This is one less thing to
3881 worry about when checking for integer overflow later.
3882 (x_check_image_size): New function, which checks for integer
3883 overflow issues inside X.
3884 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3885 This removes the need for a memory_full check.
3886 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3887 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3888 (xbm_read_bitmap_data): Change locals back to 'int', since
3889 their values must fit in 'int'.
3890 (xpm_load_image, png_load, tiff_load):
3891 Invoke x_create_x_image_and_pixmap earlier,
3892 to avoid much needless work if the image is too large.
3893 (tiff_load): Treat overly large images as if
3894 x_create_x_image_and_pixmap failed, not as malloc failures.
3895 (gs_load): Use x_check_image_size.
3896
5f8f9cc2
PE
3897 * gtkutil.c: Omit integer casts.
3898 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3899 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3900
5adf60bc
PE
3901 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3902
c8907a93
PE
3903 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3904 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3905 would wrongly return t on a 64-bit host.
3906
e3c25c68
PE
3907 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3908 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3909 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3910 and therefore cause GCC to emit a bogus diagnostic in some cases.
3911
3f791afe
PE
3912 * image.c: Integer signedness and overflow and related fixes.
3913 This is not an exhaustive set of fixes, but it's time to
3914 record what I've got.
3915 (lookup_pixel_color, check_image_size): Remove redundant decls.
3916 (check_image_size): Don't assume that arbitrary EMACS_INT values
3917 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3918 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3919 (tiff_load, imagemagick_load_image):
3920 Check for overflow in size calculations.
3921 (x_create_x_image_and_pixmap): Remove unnecessary test for
3922 xmalloc returning NULL; that can't happen.
3923 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3924 (xpm_color_bucket): Use better integer hashing function.
3925 (xpm_cache_color): Don't possibly over-allocate memory.
3926 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3927 (gif_memory_source):
3928 Use ptrdiff_t, not int or size_t, to record sizes.
3929 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3930 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3931 either works, as we prefer signed integers.
3932 (tiff_read_from_memory, tiff_write_from_memory):
3933 Return tsize_t, not size_t, since that's what the TIFF API wants.
3934 (tiff_read_from_memory): Don't fail simply because the read would
3935 go past EOF; instead, return a short read.
3936 (tiff_load): Omit no-longer-needed casts.
3937 (Fimagemagick_types): Don't assume size fits into 'int'.
3938
3cc5a532
PE
3939 Improve hashing quality when configured --with-wide-int.
3940 * fns.c (hash_string): New function, taken from sxhash_string.
3941 Do not discard information about ASCII character case; this
3942 discarding is no longer needed.
3943 (sxhash-string): Use it. Change sig to match it. Caller changed.
3944 * lisp.h: Declare it.
3945 * lread.c (hash_string): Remove, since we now use fns.c's version.
3946 The fns.c version returns a wider integer if --with-wide-int is
3947 specified, so this should help the quality of the hashing a bit.
3948
b312a492
PE
3949 * emacs.c: Integer overflow minor fix.
3950 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3951 Define only if GNU_LINUX.
3952 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3953
dfd153ae
PE
3954 * dispnew.c: Integer signedness and overflow fixes.
3955 Remove unnecessary forward decls, that were a maintenance hassle.
3956 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3957 All uses changed.
3958 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3959 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3960 (prepare_desired_row, line_draw_cost):
3961 Use int, not unsigned, where either works.
3962 (save_current_matrix, restore_current_matrix):
3963 Use ptrdiff_t, not size_t, where either works.
3964 (init_display): Check for overflow more accurately, and without
3965 relying on undefined behavior.
3966
a81d11a3
PE
3967 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3968 Remove, replacing with the new symbols in lisp.h. All uses changed.
3969 * fileio.c (make_temp_name):
3970 * filelock.c (lock_file_1, lock_file):
3971 * xdisp.c (message_dolog):
3972 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3973 Use pMd etc. instead.
3974 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3975 replacing the pWIDE etc. symbols removed from editfns.c.
3976
3300e6fd
PE
3977 * keyboard.h (num_input_events): Now uintmax_t.
3978 This is (very slightly) less likely to mess up due to wraparound.
3979 All uses changed.
3980
fd05c7e9
PE
3981 * buffer.c: Integer signedness fixes.
3982 (alloc_buffer_text, enlarge_buffer_text):
3983 Use ptrdiff_t rather than size_t when either will do, as we prefer
3984 signed integers.
3985
903fe15d
PE
3986 * alloc.c: Integer signedness and overflow fixes.
3987 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3988 (__malloc_size_t): Default to size_t, not to int.
3989 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3990 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3991 Prefer ptrdiff_t to size_t when either would do, as we prefer
3992 signed integers.
3993 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3994 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3995 Now const. Initialize with values that are in range even if char
3996 is signed.
3997 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3998 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3999 These functions do the right thing with sizes > 2**32.
4000 (check_depth): Now ptrdiff_t, not int.
4001 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4002 Adjust to new way of storing sizes. Check for size overflow bugs
4003 in rest of code.
4004 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4005 slightly wrong anyway, as it missed one instance of
4006 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4007 (refill_memory_reserve): Omit needless cast to size_t.
4008 (mark_object_loop_halt): Mark as externally visible.
4009
ac82cc6a
PE
4010 * xselect.c: Integer signedness and overflow fixes.
4011 (Fx_register_dnd_atom, x_handle_dnd_message):
4012 Use ptrdiff_t, not size_t, since we prefer signed.
4013 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4014 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4015 x_dnd_atoms_size and x_dnd_atoms_length.
4016
c2d1e36d
PE
4017 * doprnt.c: Prefer signed to unsigned when either works.
4018 * eval.c (verror):
4019 * doprnt.c (doprnt):
4020 * lisp.h (doprnt):
4021 * xdisp.c (vmessage):
4022 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4023 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4024 prefer signed arithmetic to avoid comparison confusion.
4025 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4026 but is a bit tricky.
4027
0e926e56
PE
4028 Assume freestanding C89 headers, string.h, stdlib.h.
4029 * data.c, doprnt.c, floatfns.c, print.c:
4030 Include float.h unconditionally.
4031 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4032 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4033 * regex.c: Likewise for stddef.h, string.h.
4034 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4035 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4036 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4037 (STDC_HEADERS): Remove obsolete defines.
4038 * sysdep.c: Include limits.h unconditionally.
4039
9cfdb3ec
PE
4040 Assume support for memcmp, memcpy, memmove, memset.
4041 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4042 * regex.c (memcmp, memcpy):
4043 Remove; we assume C89 now.
4044
4045 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4046 (__malloc_safe_bcopy): Remove; no longer needed.
4047
cf950e6b 4048 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4049 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4050 well either way, and we prefer signed to unsigned.
4051
dbf38e02
LMI
40522011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4053
4054 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4055 closes the connection while we're reading (bug#9182).
4056
d6f0886c 40572011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4058
d6f0886c
JD
4059 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4060 are specified (Bug#9168).
24e0f6b1 4061
2eb1f9e6
PE
40622011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4063
4064 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4065 Found by GCC static checking and --with-wide-int on a 32-bit host.
4066
22381272 40672011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4068
4069 * xdisp.c (compute_display_string_pos): Fix logic of caching
4070 previous display string position. Initialize cached_prev_pos to
4071 -1. Fixes slow-down at the beginning of a buffer.
4072
f25e39b4
EZ
40732011-07-24 Eli Zaretskii <eliz@gnu.org>
4074
4075 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4076 for attrs[LFACE_FONTSET_INDEX].
4077
04c4b52e
PE
40782011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4079
4080 * xml.c (parse_region): Remove unused local
4081 that was recently introduced.
4082
c1734fbd
EZ
40832011-07-23 Eli Zaretskii <eliz@gnu.org>
4084
be18c5a5
EZ
4085 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4086 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4087
c1734fbd
EZ
4088 * xdisp.c (move_it_in_display_line_to): Record the best matching
4089 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4090 exit if none of the characters scanned was an exact match.
4091 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4092 when exact match is impossible due to invisible text, and the
4093 lines are truncated.
4094
a258d627
JD
40952011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4096
4097 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4098 for OSX >= 10.7.
4099
b6d5a689
EZ
41002011-07-22 Eli Zaretskii <eliz@gnu.org>
4101
0f74f785
EZ
4102 Fix a significant slow-down of cursor motion with C-n, C-p,
4103 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4104 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4105 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4106 (next_element_from_buffer): Call compute_stop_pos_backwards to
4107 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4108 base_level_stop.
4109 (reseat): Don't look for prev_stop, as that could mean a very long
4110 run.
4111 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4112 <cached_disp_overlay_modiff>: Cache for last found display string
4113 position.
551918c1 4114 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4115 about the same buffer in the same area of character positions, and
4116 the buffer wasn't changed since the time the display string
4117 position was cached.
551918c1 4118
b2d0c91a
EZ
41192011-07-22 Eli Zaretskii <eliz@gnu.org>
4120
4121 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4122 is an integer, which is important for empty lines. (Bug#9149)
4123
043604ee
CY
41242011-07-22 Chong Yidong <cyd@stupidchicken.com>
4125
4126 * frame.c (Fmodify_frame_parameters): In tty case, update the
4127 default face if necessary (Bug#4238).
4128
da4adb04
CY
41292011-07-21 Chong Yidong <cyd@stupidchicken.com>
4130
4131 * editfns.c (Fstring_to_char): No need to explain what a character
4132 is in the docstring (Bug#6576).
4133
9abd0532
LMI
41342011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4135
4136 * xml.c (parse_region): Make sure we always return a tree.
4137
36881d16
HK
41382011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4139
4140 * xml.c (parse_region): If a document contains only comments,
4141 return that, too.
4142
1e98674d
LMI
41432011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4144
4145 * xml.c (make_dom): Return comments, too.
4146
590bd467
PE
41472011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4148
4149 Port to OpenBSD.
4150 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4151 and the surrounding thread.
4152 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4153 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4154 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4155 timer goes off.
4156 * s/openbsd.h (BROKEN_SIGIO): Define.
4157 * unexelf.c (unexec) [__OpenBSD__]:
4158 Don't update the .mdebug section of the Alpha COFF symbol table.
4159
f41628b2
LMI
41602011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4161
4162 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4163 (bug#8460).
4164
b59b67c5
PE
41652011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4166
15e3a074
PE
4167 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4168 This fixes some race conditions on the permissions of any newly
4169 created file.
4170
41bed37d
PE
4171 * alloc.c (valid_pointer_p): Use pipe, not open.
4172 This fixes some permissions issues when debugging.
4173
b59b67c5
PE
4174 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4175 If fchown fails to set both uid and gid, try to set just gid,
4176 as that is sometimes allowed. Adjust the file's mode to eliminate
4177 setuid or setgid bits that are inappropriate if fchown fails.
4178
925a6be7
SM
41792011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4180
4181 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4182 to compare Lisp_Objects.
4183 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4184 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4185 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4186
52968808
AS
41872011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4188
0a6a104b
AS
4189 * lread.c (read_integer): Unread even EOF character.
4190 (read1): Likewise. Properly record start position of symbol.
4191
52968808
AS
4192 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4193 symbol character follows.
4194
9e381cdd
PE
41952011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4196
4197 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4198 This works around a problem with the previous change to Fcopy_file.
4199 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4200 and without this change, GCC might complain about discarding
4201 fchown's return value.
4202
b5641435
JB
42032011-07-16 Juanma Barranquero <lekktu@gmail.com>
4204
4205 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4206
a8031457
PE
42072011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4208
4209 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4210
dd889327
LMI
42112011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4212
750c33f7
LMI
4213 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4214 it's used from the C level.
4215
dd889327
LMI
4216 * process.c: Use the same condition for POLL_FOR_INPUT in both
4217 keyboard.c and process.c (bug#1858).
4218
87e86684
LM
42192011-07-09 Lawrence Mitchell <wence@gmx.li>
4220
4221 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4222 (Fgnutls_boot): Use it.
4223
64348f40
AS
42242011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4225
4226 * doc.c (Fsubstitute_command_keys): Revert last change.
4227
1d698799
LMI
42282011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4229
f863868c
LMI
4230 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4231 quotes the next character, and doesn't affect other longer
4232 sequences (bug#8935).
4233
1d698799
LMI
4234 * lread.c (syms_of_lread): Clarify that is isn't only
4235 `eval-buffer' and `eval-defun' that's affected by
4236 `lexical-binding' (bug#8460).
4237
aa4b6df6
EZ
42382011-07-15 Eli Zaretskii <eliz@gnu.org>
4239
4240 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4241 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4242
5d856da6
PE
42432011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4244
ad6042bb
PE
4245 Fix minor problems found by static checking.
4246 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4247 (elsz): Now a signed constant, not a size_t var. We prefer signed
4248 types to unsigned, to avoid integer comparison confusion. Without
4249 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4250 "cannot optimize loop, the loop counter may overflow", a symptom
4251 of the confusion.
f00bbb22 4252 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4253 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4254
6468f31c
LMI
42552011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4256
49080b10
LMI
4257 * search.c (Fre_search_backward): Mention `case-fold-search' in
4258 all the re_search_* functions (bug#8138).
4259
6468f31c
LMI
4260 * keyboard.c (Fopen_dribble_file): Document when the file is
4261 closed (bug#8056).
4262
c965adc5
EZ
42632011-07-14 Eli Zaretskii <eliz@gnu.org>
4264
df9733bf
EZ
4265 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4266 bidi_cache_idx.
4267
0bb23927
EZ
4268 Support bidi reordering of display and overlay strings.
4269 * xdisp.c (compute_display_string_pos)
4270 (compute_display_string_end): Accept additional argument STRING.
4271 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4272 (reseat_to_string): Initialize bidi_it->string.s and
4273 bidi_it->string.schars.
4274 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4275 NULL (avoids a crash in bidi_paragraph_init).
4276 Initialize itb.string.lstring.
0bb23927
EZ
4277 (init_iterator): Call bidi_init_it only of a valid
4278 buffer position was specified. Initialize paragraph_embedding to
4279 L2R.
4280 (reseat_to_string): Initialize the bidi iterator.
4281 (display_string): If we need to ignore text properties of
4282 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4283 original value of -1 will not work with bidi.)
4284 (compute_display_string_pos): First arg is now struct
4285 `text_pos *'; all callers changed. Support display properties on
4286 Lisp strings.
4287 (compute_display_string_end): Support display properties on Lisp
4288 strings.
4289 (init_iterator, reseat_1, reseat_to_string): Initialize the
4290 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4291 when iterating on a string not from display properties).
640c8776
SM
4292 (compute_display_string_pos, compute_display_string_end):
4293 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4294 arrow keys.
4295 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4296 base_level_stop; instead, set base_level_stop to BEGV.
4297 Fixes crashes in vertical-motion.
0bb23927
EZ
4298 (next_element_from_buffer): Improve commentary for when
4299 the iterator is before prev_stop.
4300 (init_iterator): Initialize bidi_p from the default value of
4301 bidi-display-reordering, not from buffer-local value. Use the
4302 buffer-local value only if initializing for buffer iteration.
4303 (handle_invisible_prop): Support invisible properties on strings
4304 that are being bidi-reordered.
4305 (set_iterator_to_next): Support bidi reordering of C strings and
4306 Lisp strings.
4307 (next_element_from_string): Support bidi reordering of Lisp
4308 strings.
4309 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4310 (display_string): Support display of R2L glyph rows.
4311 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4312 (init_iterator): Don't initialize it->bidi_p for strings
4313 here.
4314 (reseat_to_string): Initialize it->bidi_p for strings here.
4315 (next_element_from_string, next_element_from_c_string)
4316 (next_element_from_buffer): Add xassert's for correspondence
4317 between IT's object being iterated and it->bidi_it.string
4318 structure.
4319 (face_before_or_after_it_pos): Support bidi iteration.
4320 (next_element_from_c_string): Handle the case of the first string
4321 character that is not the first one in the visual order.
4322 (get_visually_first_element): New function, refactored from common
4323 parts of next_element_from_buffer, next_element_from_string, and
4324 next_element_from_c_string.
4325 (tool_bar_lines_needed, redisplay_tool_bar)
4326 (display_menu_bar): Force left-to-right direction. Add a FIXME
4327 comment for making that be controlled by a user option.
4328 (push_it, pop_it): Save and restore the state of the
4329 bidi iterator. Save and restore the bidi_p flag.
4330 (pop_it): Iterate out of display property for string iteration as
4331 well.
4332 (iterate_out_of_display_property): Support iteration over strings.
4333 (handle_single_display_spec): Set up it->bidi_it for iteration
4334 over a display string, and call bidi_init_it.
4335 (handle_single_display_spec, next_overlay_string)
4336 (get_overlay_strings_1, push_display_prop): Set up the bidi
4337 iterator for displaying display or overlay strings.
4338 (forward_to_next_line_start): Don't use the shortcut if
4339 bidi-iterating.
4340 (back_to_previous_visible_line_start): If handle_display_prop
4341 pushed the iterator stack, restore the internal state of the bidi
4342 iterator by calling bidi_pop_it same number of times.
4343 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4344 and we are bidi-iterating, don't decrement the iterator position;
4345 instead, set the first_elt flag in the bidi iterator, to produce
4346 the same effect.
4347 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4348 (push_display_prop): xassert that we are iterating a buffer.
4349 (push_it, pop_it): Save and restore paragraph_embedding member.
4350 (handle_single_display_spec, next_overlay_string)
4351 (get_overlay_strings_1, reseat_1, reseat_to_string)
4352 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4353 correctly. Don't assume unibyte strings are not bidi-reordered.
4354 (compute_display_string_pos)
4355 (compute_display_string_end): Fix handling the case of C string.
4356 (push_it, pop_it): Save and restore from_disp_prop_p.
4357 (handle_single_display_spec, push_display_prop): Set the
4358 from_disp_prop_p flag.
4359 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4360 (pop_it): Call iterate_out_of_display_property only if we are
4361 popping after iteration over a string that came from a display
4362 property. Fix a typo in popping stretch info. Add an assertion
4363 for verifying that the iterator position is in sync with the bidi
4364 iterator.
4365 (handle_single_display_spec, get_overlay_strings_1)
4366 (push_display_prop): Fix initialization of paragraph direction for
4367 string when that of the parent object is not yet determined.
4368 (reseat_1): Call bidi_init_it to resync the bidi
4369 iterator with IT's position. (Bug#7616)
4370 (find_row_edges): If ROW->start.pos gives position
4371 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4372 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4373 Reset the from_disp_prop_p flag.
4374 (SAVE_IT, RESTORE_IT): New macros.
4375 (pos_visible_p, face_before_or_after_it_pos)
4376 (back_to_previous_visible_line_start)
4377 (move_it_in_display_line_to, move_it_in_display_line)
4378 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4379 (try_scrolling, redisplay_window, display_line): Use them when
4380 saving a temporary copy of the iterator and restoring it back.
4381 (back_to_previous_visible_line_start, reseat_1)
4382 (init_iterator): Empty the bidi cache "stack".
4383 (move_it_in_display_line_to): If iterator ended up at
4384 EOL, but we never saw any buffer positions smaller than
4385 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4386 motion in bidi-reordered lines.
4387 (move_it_in_display_line_to): Record prev_method and prev_pos
4388 immediately before the call to set_iterator_to_next. Fixes cursor
4389 motion in bidi-reordered lines with stretch glyphs and strings
4390 displayed in margins. (Bug#8133) (Bug#8867)
4391 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4392 TO_CHARPOS.
640c8776
SM
4393 (pos_visible_p): Support positions in bidi-reordered lines.
4394 Save and restore bidi cache.
0bb23927
EZ
4395
4396 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4397 (bidi_paragraph_info): Delete unused struct.
4398 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4399 (bidi_cache_start): New variable.
4400 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4401 to zero.
4402 (bidi_cache_fetch_state, bidi_cache_search)
4403 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4404 (bidi_cache_find, bidi_peek_at_next_level)
4405 (bidi_level_of_next_char, bidi_find_other_level_edge)
4406 (bidi_move_to_visually_next): Compare cache index with
4407 bidi_cache_start rather than with zero.
4408 (bidi_fetch_char): Accept new argument STRING; all callers
4409 changed. Support iteration over a string. Support strings with
4410 display properties. Support unibyte strings. Fix the type of
4411 `len' according to what STRING_CHAR_AND_LENGTH expects.
4412 (bidi_paragraph_init, bidi_resolve_explicit_1)
4413 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4414 (bidi_level_of_next_char, bidi_move_to_visually_next):
4415 Support iteration over a string.
0bb23927
EZ
4416 (bidi_set_sor_type, bidi_resolve_explicit_1)
4417 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4418 can now be zero (for strings); special values 0 and -1 were
4419 changed to -1 and -2, respectively.
4420 (bidi_char_at_pos): New function.
4421 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4422 Call it instead of FETCH_MULTIBYTE_CHAR.
4423 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4424 initialized to valid values.
4425 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4426 values.
4427 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4428 the test for valid cached positions. Fix the logic for looking up
4429 the sentinel state in the cache. GCPRO the Lisp string we are
4430 iterating.
4431 (bidi_push_it, bidi_pop_it): New functions.
4432 (bidi_initialize): Initialize the bidi cache start stack pointer.
4433 (bidi_cache_ensure_space): New function, refactored from part of
4434 bidi_cache_iterator_state. Don't assume the required size is just
4435 one BIDI_CACHE_CHUNK away.
4436 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4437 (bidi_count_bytes, bidi_char_at_pos): New functions.
4438 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4439 always valid if bidi_cache_idx is valid.
4440 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4441 is valid if it's going to be used.
4442 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4443 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4444 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4445 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4446 (bidi_find_other_level_edge, bidi_cache_start_stack):
4447 All variables related to cache indices are now EMACS_INT.
c965adc5 4448
0bb23927
EZ
4449 * dispextern.h (struct bidi_string_data): New structure.
4450 (struct bidi_it): New member `string'. Make flag members be 1-bit
4451 fields, and put them last in the struct.
640c8776
SM
4452 (compute_display_string_pos, compute_display_string_end):
4453 Update prototypes.
0bb23927
EZ
4454 (bidi_push_it, bidi_pop_it): Add prototypes.
4455 (struct iterator_stack_entry): New members bidi_p,
4456 paragraph_embedding, and from_disp_prop_p.
4457 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4458 (bidi_shelve_cache, bidi_unshelve_cache):
4459 Declare prototypes.
0bb23927
EZ
4460
4461 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4462 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4463 and vector-like objects.
4464
4465 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4466 cache around display iteration.
4467
4468 * window.c (Fwindow_end, window_scroll_pixel_based)
4469 (displayed_window_lines, Frecenter): Save and restore the bidi
4470 cache around display iteration.
4471
3bbd2265
LMI
44722011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4473
4474 * editfns.c (Fdelete_region): Clarify the use of the named
4475 parameters (bug#6788).
4476
adc47434
MR
44772011-07-14 Martin Rudalics <rudalics@gmx.at>
4478
4479 * indent.c (Fvertical_motion): Set and restore w->pointm when
4480 saving and restoring the window's buffer (Bug#9006).
4481
837c31f8
LMI
44822011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4483
4484 * editfns.c (Fstring_to_char): Clarify just what is returned
4485 (bug#6576). Text by Eli Zaretskii.
4486
ac389d0c
JB
44872011-07-13 Juanma Barranquero <lekktu@gmail.com>
4488
4489 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4490
0be0ce47
EZ
44912011-07-13 Eli Zaretskii <eliz@gnu.org>
4492
4493 * buffer.c (mmap_find): Fix a typo.
4494
cd18e7e3
JB
44952011-07-13 Johan Bockgård <bojohan@gnu.org>
4496
4497 Fix execution of x selection hooks.
4498 * xselect.c (Qx_lost_selection_functions)
4499 (Qx_sent_selection_functions): New vars.
4500 (syms_of_xselect): DEFSYM them.
4501 (x_handle_selection_request): Pass Qx_sent_selection_functions
4502 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4503 (x_handle_selection_clear,x_clear_frame_selections):
4504 Pass Qx_lost_selection_functions rather than
4505 Vx_lost_selection_functions to Frun_hook_with_args.
4506
47ea7f44
PE
45072011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4508
ac389d0c 4509 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4510 The old code sometimes used this field without initializing it.
4511
47ea7f44
PE
4512 * alloc.c (gc_sweep): Don't read past end of array.
4513 In theory, the old code could also have corrupted Emacs internals,
4514 though it'd be very unlikely.
4515
bc985c87
AS
45162011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4517
4518 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4519 argument. (Bug#4026)
bc985c87 4520
0cf34688
LMI
45212011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4522
b3dadd76
LMI
4523 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4524 key" (bug#4257).
4525
0cf34688
LMI
4526 * window.c (Fset_window_start): Doc fix (bug#4199).
4527 (Fset_window_hscroll): Ditto.
4528
270768cd
PE
45292011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4530
077e3dda 4531 Fix minor new problems caught by GCC 4.6.1.
270768cd 4532 * term.c (init_tty): Remove unused local.
490011a6 4533 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4534 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4535 not used otherwise.
270768cd 4536
b1f58454
CY
45372011-07-12 Chong Yidong <cyd@stupidchicken.com>
4538
4539 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4540
22b9578d
LMI
45412011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4542
6e70ab07
LMI
4543 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4544 are the mini-buffer and the echo area (bug#3320).
4545
22b9578d
LMI
4546 * term.c (init_tty): Remove support for supdup, c10 and perq
4547 terminals, which are no longer supported (bug#1482).
4548
8974cc9f
JB
45492011-07-10 Johan Bockgård <bojohan@gnu.org>
4550
4551 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4552
a560d974
JD
45532011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4554
4555 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4556 for non-popups (Bug#3642).
4557
1dae0f0a
AS
45582011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4559
268c2c36 4560 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4561 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4562 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4563 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4564 * data.c (fmod): Likewise.
4565 * dispnew.c (swap_glyphs_in_rows): Likewise.
4566 * emacs.c (memory_warning_signal): Likewise.
4567 * floatfns.c (float_error): Likewise.
4568 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4569 (otf_open, font_otf_capability, generate_otf_features)
4570 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4571 Likewise.
4572 * image.c (pbm_read_file): Likewise.
4573 * indent.c (string_display_width): Likewise.
4574 * intervals.c (check_for_interval, search_for_interval)
4575 (inc_interval_count, count_intervals, root_interval)
4576 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4577 * lread.c (defalias): Likewise.
268c2c36 4578 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4579 * regex.c (set_image_of_range_1, set_image_of_range)
4580 (regex_grow_registers): Likewise.
4581 * sysdep.c (strerror): Likewise.
4582 * termcap.c (valid_filename_p, tprint, main): Likewise.
4583 * tparam.c (main): Likewise.
4584 * unexhp9k800.c (run_time_remap, save_data_space)
4585 (update_file_ptrs, read_header, write_header, calculate_checksum)
4586 (copy_file, copy_rest, display_header): Likewise.
4587 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4588 Likewise.
4589 * xdisp.c (check_it): Likewise.
4590 * xfaces.c (register_color, unregister_color, unregister_colors):
4591 Likewise.
4592 * xfns.c (print_fontset_result): Likewise.
4593 * xrdb.c (member, fatal, main): Likewise.
4594
99033785
PE
45952011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4596
4597 Fix minor problems found by static checking (Bug#9031).
4598 * chartab.c (char_table_set_range, map_sub_char_table):
4599 Remove unused locals.
4600 (uniprop_table): Now static.
4601 * composite.c (_work_char): Remove unused static var.
4602
9cb2ac56
JB
46032011-07-09 Juanma Barranquero <lekktu@gmail.com>
4604
4605 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4606
f25661f0
JD
46072011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4608
4609 * gtkutil.c (qttip_cb): Remove code without function.
4610
8278c4fe
EZ
46112011-07-09 Eli Zaretskii <eliz@gnu.org>
4612
4613 * w32.c (pthread_sigmask): New stub.
4614
1692ae2d 46152011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4616
8a6ebd58 4617 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4618 sigprocmask is portable only for single-threaded applications, and
4619 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4620 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4621 (LIBES): Use it.
4622 * callproc.c (Fcall_process):
4623 * process.c (create_process):
4624 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4625 Use pthread_sigmask, not sigprocmask.
123403e4 4626
1b854618
JD
46272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4628
4629 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4630 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4631 wrong (Bug#8591).
4632
3fe4b549
JD
46332011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4634
0ce7e563
JD
4635 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4636 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4637 (xg_hide_tooltip): Fix comment.
4638
3fe4b549
JD
4639 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4640 in registerServicesMenuSendTypes.
4641 (validRequestorForSendType): Don't check ns_return_types.
4642
4643 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4644 ns_return_type.
4645
5df75e47
JR
46462011-07-08 Jason Rumney <jasonr@gnu.org>
4647
22610910
JR
4648 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4649 SH_SHOW for hidden windows (Bug#5482).
4650
5df75e47
JR
4651 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4652 frame struct members of non-existent frames (Bug#6284).
4653
699c10bd
JD
46542011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4655
4393663b
JD
4656 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4657 variable firstTime not needed on OSX >= 10.6.
4658 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4659 >= 10.5. Use setKnobProportion, setDoubleValue.
4660
4661 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4662 (MAC_OS_X_VERSION_10_5): Define if not defined.
4663 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4664 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4665 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4666
4667 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4668 cString and lossyCString on OSX >= 10.4
4669
58179cce 4670 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4671 sizeToFit on OSX >= 10.2.
4672
4673 * nsimage.m (allocInitFromFile): Don't use deprecated method
4674 bestRepresentationForDevice on OSX >= 10.6.
4675
4676 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4677 to avoid warning.
4678
4679 * emacs.c: Declare unexec_init_emacs_zone.
4680
a63e0781
JD
4681 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4682
699c10bd
JD
4683 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4684
4685 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4686 on svcsMenu (Bug#8842).
4687
4688 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4689 ns_return_types.
4690 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4691
4692 * nsterm.m (QUTF8_STRING): Declare.
4693 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4694 (validRequestorForSendType): Return type is (id).
4695 Change indexOfObjectIdenticalTo to indexOfObject.
4696 Check if we have local selection before returning self (Bug#8842).
4697 (writeSelectionToPasteboard): Put local selection into paste board
4698 if we have a local selection (Bug#8842).
4699 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4700
4701 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4702 (ns_get_local_selection): Declare.
4703
54e10184
LMI
47042011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4705
9888ff71
LMI
4706 * keymap.c (describe_map_tree): Don't insert a double newline at
4707 the end of the buffer (bug#1169) and return whether we inserted
4708 something.
4709
54e10184
LMI
4710 * callint.c (Fcall_interactively): Change "reading args" to
4711 "providing args" to try to clarify what it does (bug#1010).
4712
15fa4783
KH
47132011-07-07 Kenichi Handa <handa@m17n.org>
4714
4715 * composite.c (composition_compute_stop_pos): Ignore a static
4716 composition starting before CHARPOS (Bug#8915).
4717
4718 * xdisp.c (handle_composition_prop): Likewise.
4719
a8815b00
EZ
47202011-07-07 Eli Zaretskii <eliz@gnu.org>
4721
4722 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4723 (Bug#9015)
4724
ef7b981d 47252011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4726
4727 * character.h (unicode_category_t): New enum type.
4728
4729 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4730 (Qchar_code_property_table): New variable.
4731 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4732 (UNIPROP_COMPRESSED_FORM_P): New macros.
4733 (char_table_ascii): Uncompress the compressed values.
4734 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4735 Uncompress the compressed values.
ac389d0c 4736 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4737 (char_table_ref_and_range): Uncompress the compressed values.
4738 (sub_char_table_set): New arg is_uniprop. Callers changed.
4739 Uncompress the compressed values.
4740 (sub_char_table_set_range): Args changed. Callers changed.
4741 (char_table_set_range): Adjuted for the above change.
4742 (map_sub_char_table): Delete args default_val and parent. Add arg
4743 top. Give decoded values to a Lisp function.
640c8776 4744 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4745 values to a Lisp function. Gcpro more variables.
4746 (uniprop_table_uncompress)
4747 (uniprop_decode_value_run_length): New functions.
4748 (uniprop_decoder, uniprop_decoder_count): New variables.
4749 (uniprop_get_decoder, uniprop_encode_value_character)
4750 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4751 New functions.
4752 (uniprop_encoder, uniprop_encoder_count): New variables.
4753 (uniprop_get_encoder, uniprop_table)
4754 (Funicode_property_table_internal, Fget_unicode_property_internal)
4755 (Fput_unicode_property_internal): New functions.
4756 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4757 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4758 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4759 char-code-property-alist.
4760
640c8776 4761 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4762 Vunicode_category_table.
4763
640c8776 4764 * font.c (font_range): Adjust for the change of
c805dec0
KH
4765 Vunicode_category_table.
4766
76b397fb
DN
47672011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4768
4769 * m/iris4d.h: Remove file, move contents ...
4770 * s/irix6-5.h: ... here.
4771
22b4128e
PE
47722011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4773
4774 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4775 * alloc.c (mark_buffer):
4776 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4777 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4778 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4779 This isn't true in general, and it's particularly not true
4780 if Emacs is configured with --with-wide-int.
4781 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4782 New macros, used in the buffer.c change.
4783
869795d6
JD
47842011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4785
4786 * xsettings.c: Use both GConf and GSettings if both are available.
4787 (store_config_changed_event): Add comment.
4788 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4789 (store_tool_bar_style_changed): New functions.
5e617bc2 4790 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4791 (struct xsettings): Move font inside HAVE_XFT.
4792 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4793 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4794 Move inside HAVE_XFT.
640c8776 4795 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4796 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4797 also.
4798 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4799 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4800 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4801 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4802 (parse_settings): Move check for font inside HAVE_XFT.
4803 (read_settings, apply_xft_settings): Add comment.
4804 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4805 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4806 call store_font_name_changed.
4807 (xft_settings_event): Add comment.
4808 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4809 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4810 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4811 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4812 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4813 (xsettings_get_system_font, xsettings_get_system_normal_font):
4814 Add comment.
869795d6 4815
d8ed26bd
PE
48162011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4817
4818 Random fixes. E.g., (random) never returned negative values.
4819 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4820 subseconds part to the entropy, as that's a bit more random.
4821 Prefer signed to unsigned, since the signedness doesn't matter and
4822 in general we prefer signed. When given a limit, use a
4823 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4824 latter isn't right if USE_2_TAGS_FOR_INTS.
4825 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4826 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4827
cabf1cac
SM
48282011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4829
4830 * textprop.c (text_property_stickiness):
4831 Obey Vtext_property_default_nonsticky.
4832 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4833 * w32fns.c (syms_of_w32fns):
4834 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4835
6e9b2be9
PE
48362011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4837
4838 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4839 This is more efficient than Ffile_directory_p and avoids a minor race.
4840
90186c68
LMI
48412011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4842
7c301272
LMI
4843 * buffer.c (Foverlay_put): Say what the return value is
4844 (bug#7835).
4845
c4f2d8d4
LMI
4846 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4847 is a directory before asking whether to use the file name
4848 (bug#7564).
ad637907
LMI
4849 (barf_or_query_if_file_exists): Make the "File is a directory"
4850 error be more correct.
c4f2d8d4 4851
90186c68
LMI
4852 * fns.c (Frequire): Remove the mention of the .gz files, since
4853 that's installation-specific, but keep the mention of
4854 `get-load-suffixes'.
4855
da64016e
PE
48562011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4857
4858 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4859 Report string overflow if the output is too long.
4860
7d47b580
JB
48612011-07-04 Juanma Barranquero <lekktu@gmail.com>
4862
a555cb87
JB
4863 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4864 (syms_of_gnutls): Remove duplicate DEFSYM for
4865 Qgnutls_bootprop_verify_hostname_error, an error for
4866 Qgnutls_bootprop_verify_error (which is no longer used).
4867
7d47b580
JB
4868 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4869 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4870 Also (re)move comments that are misplaced or no longer relevant.
4871
1e49bfab
LMI
48722011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4873
4874 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4875
1485f4c0
CY
48762011-07-03 Chong Yidong <cyd@stupidchicken.com>
4877
4878 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4879 and background color parameters if they have been changed.
4880
a9ab721e
LMI
48812011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4882
4883 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4884
cf7cff57
PE
48852011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4886
2e13213d
PE
4887 * xsettings.c (SYSTEM_FONT): Define only when used.
4888 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4889
cf7cff57
PE
4890 * keymap.c (access_keymap_1): Now static.
4891
7a8e04f7
CY
48922011-07-02 Chong Yidong <cyd@stupidchicken.com>
4893
4894 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4895 leave any prefix arg for the up event (Bug#1586).
4896
61352f62
LMI
48972011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4898
69bb1ef7
LMI
4899 * lread.c (syms_of_lread): Mention single symbols defined by
4900 `defvar' or `defconst' (bug#7154).
4901
61352f62 4902 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4903 (Frequire): Mention get-load-suffixes.
61352f62 4904
28545e04
MR
49052011-07-02 Martin Rudalics <rudalics@gmx.at>
4906
4907 * window.h (window): Remove clone_number slot.
4908 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4909 Remove.
4910 (make_parent_window, make_window, saved_window)
4911 (Fset_window_configuration, save_window_save): Don't deal with
4912 clone numbers.
4913 * buffer.c (Qclone_number): Remove declaration.
4914 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4915
3349e122
SM
49162011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4917
4918 Add multiple inheritance to keymaps.
4919 * keymap.c (Fmake_composed_keymap): New function.
4920 (Fset_keymap_parent): Simplify.
4921 (fix_submap_inheritance): Remove.
4922 (access_keymap_1): New function extracted from access_keymap to handle
4923 embedded parents and handle lists of maps.
4924 (access_keymap): Use it.
4925 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4926 (Fcopy_keymap): Handle embedded parents.
4927 (Fcommand_remapping, define_as_prefix): Simplify.
4928 (Fkey_binding): Simplify.
4929 (syms_of_keymap): Move minibuffer-local-completion-map,
4930 minibuffer-local-filename-completion-map,
4931 minibuffer-local-must-match-map, and
4932 minibuffer-local-filename-must-match-map to Elisp.
4933 (syms_of_keymap): Defsubr make-composed-keymap.
4934 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4935 (parse_menu_item): Trivial simplification.
4936
3279eb87
GM
49372011-07-01 Glenn Morris <rgm@gnu.org>
4938
4939 * Makefile.in (SETTINGS_LIBS): Fix typo.
4940
4550efdf
KI
49412011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4942
4943 * coding.c (Fencode_coding_string): Record the last coding system
4944 used, as the function doc string says (bug#8738).
4945
0949d2b6
JD
49462011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4947
4948 * xsettings.c (store_monospaced_changed): Take new font as arg and
4949 check for change against current_mono_font.
4950 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4951 (emacs_settings_constructor, emacs_settings_get_property)
4952 (emacs_settings_set_property, emacs_settings_class_init)
4953 (emacs_settings_init, gsettings_obj): Remove.
4954 (something_changedCB): New function for HAVE_GSETTINGS.
4955 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4956 with value as argument.
4957 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4958 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4959 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4960 "changed".
4961
4962 * xgselect.c: Add defined (HAVE_GSETTINGS).
4963 (xgselect_initialize): Ditto.
4964
4965 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4966 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4967 xg_select.
4968
bbc6b304
PE
49692011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4970
4971 * eval.c (struct backtrace): Simplify and port the data structure.
4972 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4973 signed bit field, as this assumption is not portable and it makes
4974 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4975 "char debug_on_exit : 1" as this is not portable either; instead,
4976 use the portable "unsigned int debug_on_exit : 1". Remove unused
4977 member evalargs. Remove obsolete comments about cc bombing out.
4978
9851bfc5
JD
49792011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4980
51bb811f 4981 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4982 Let HAVE_GSETTINGS override HAVE_GCONF.
4983 (store_monospaced_changed): New function.
4984 (EMACS_SETTINGS): A new type derived from GObject to handle
4985 GSettings notifications.
4986 (emacs_settings_constructor, emacs_settings_get_property)
4987 (emacs_settings_set_property, emacs_settings_class_init):
4988 New functions.
4989 (gsettings_client, gsettings_obj): New variables.
4990 (GSETTINGS_SCHEMA): New define.
4991 (something_changedCB): Call store_monospaced_changed.
4992 (init_gsettings): New function.
4993 (xsettings_initialize): Call init_gsettings.
4994 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4995 to NULL.
4996
640c8776 4997 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4998 GCONF_CFLAGS/LIBS.
4999
5386012d
MR
50002011-06-29 Martin Rudalics <rudalics@gmx.at>
5001
5002 * window.c (resize_root_window, grow_mini_window)
5003 (shrink_mini_window): Rename Qresize_root_window to
5004 Qwindow_resize_root_window and Qresize_root_window_vertically to
5005 Qwindow_resize_root_window_vertically.
5006
f13e0b08
PE
50072011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5008
5009 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5010
94515237
JB
50112011-06-27 Juanma Barranquero <lekktu@gmail.com>
5012
5013 * makefile.w32-in: Redesign dependencies so they reflect more
5014 clearly which files are directly included by each source file,
5015 and not through other includes.
5016
e43b6e43
MR
50172011-06-27 Martin Rudalics <rudalics@gmx.at>
5018
5019 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5020 (sort_overlays, overlay_strings): When an overlay's clone number
5021 matches the window's clone number process the overlay even if
5022 the overlay's window property doesn't match the current window.
5023
d68443dc
MR
5024 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5025 (Fwindow_hchild): Rename to Fwindow_left_child.
5026 (Fwindow_next): Rename to Fwindow_next_sibling.
5027 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
5028 (resize_window_check): Rename to window_resize_check.
5029 (resize_window_apply): Rename to window_resize_apply.
5030 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5031 (Fdelete_other_windows_internal, resize_frame_windows)
5032 (Fsplit_window_internal, Fdelete_window_internal)
5033 (grow_mini_window, shrink_mini_window)
5034 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 5035
c7e73be5
JD
50362011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5037
5038 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5039 (emacs_fixed_set_min_size): Remove.
5040 (emacs_fixed_new): Take frame as argument.
5041
5042 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5043 (_EmacsFixedPrivate): Remove minwidth/height.
5044 Add struct frame *f.
5045 (emacs_fixed_init): Initialize priv->f.
5046 (get_parent_class, emacs_fixed_set_min_size): Remove.
5047 (emacs_fixed_new): Set priv->f to argument.
5048 (emacs_fixed_get_preferred_width)
5049 (emacs_fixed_get_preferred_height): Use min_width/height from
5050 frames size_hint to set minimum and natural (Bug#8919).
5051 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5052 and use min_width/height from frames size_hint to set
5053 min_width/height (Bug#8919).
5054
5055 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5056 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5057 Fix indentation.
c7e73be5 5058
cf99dcf8
EZ
50592011-06-26 Eli Zaretskii <eliz@gnu.org>
5060
5061 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5062 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5063 called at ZV.
5064
029529ac
CY
50652011-06-26 Chong Yidong <cyd@stupidchicken.com>
5066
5067 * process.c (wait_reading_process_output): Bypass select if
5068 waiting for a cell while ignoring keyboard input, and input is
5069 pending. Suggested by Jan Djärv (Bug#8869).
5070
7a7ef429
PE
50712011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5072
5073 Use gnulib's dup2 module instead of rolling our own.
5074 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5075
11fdef7d 50762011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5077
5078 * dispnew.c (scrolling_window): Before scrolling, turn off a
5079 mouse-highlight in the window being scrolled.
5080
cd3520a4
JB
50812011-06-24 Juanma Barranquero <lekktu@gmail.com>
5082
5083 Move DEFSYM to lisp.h and use everywhere.
5084
5085 * character.h (DEFSYM): Move declaration...
5086 * lisp.h (DEFSYM): ...here.
5087
5088 * gnutls.c:
5089 * minibuf.c:
5090 * w32menu.c:
5091 * w32proc.c:
5092 * w32select.c: Don't include character.h.
5093
5094 * alloc.c (syms_of_alloc):
5095 * buffer.c (syms_of_buffer):
5096 * bytecode.c (syms_of_bytecode):
5097 * callint.c (syms_of_callint):
5098 * casefiddle.c (syms_of_casefiddle):
5099 * casetab.c (init_casetab_once):
5100 * category.c (init_category_once, syms_of_category):
5101 * ccl.c (syms_of_ccl):
5102 * cmds.c (syms_of_cmds):
5103 * composite.c (syms_of_composite):
5104 * dbusbind.c (syms_of_dbusbind):
5105 * dired.c (syms_of_dired):
5106 * dispnew.c (syms_of_display):
5107 * doc.c (syms_of_doc):
5108 * editfns.c (syms_of_editfns):
5109 * emacs.c (syms_of_emacs):
5110 * eval.c (syms_of_eval):
5111 * fileio.c (syms_of_fileio):
5112 * fns.c (syms_of_fns):
5113 * frame.c (syms_of_frame):
5114 * fringe.c (syms_of_fringe):
5115 * insdel.c (syms_of_insdel):
5116 * keymap.c (syms_of_keymap):
5117 * lread.c (init_obarray, syms_of_lread):
5118 * macros.c (syms_of_macros):
5119 * msdos.c (syms_of_msdos):
5120 * print.c (syms_of_print):
5121 * process.c (syms_of_process):
5122 * search.c (syms_of_search):
5123 * sound.c (syms_of_sound):
5124 * syntax.c (init_syntax_once, syms_of_syntax):
5125 * terminal.c (syms_of_terminal):
5126 * textprop.c (syms_of_textprop):
5127 * undo.c (syms_of_undo):
5128 * w32.c (globals_of_w32):
5129 * window.c (syms_of_window):
5130 * xdisp.c (syms_of_xdisp):
5131 * xfaces.c (syms_of_xfaces):
5132 * xfns.c (syms_of_xfns):
5133 * xmenu.c (syms_of_xmenu):
5134 * xsettings.c (syms_of_xsettings):
5135 * xterm.c (syms_of_xterm): Use DEFSYM.
5136
4228cf16
TZ
51372011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5138
cd3520a4 5139 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5140
7fcccf1e
PE
51412011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5142
7efb4e0e
PE
5143 Integer and buffer overflow fixes (Bug#8873).
5144
ff5844ad
PE
5145 * print.c (printchar, strout): Check for string overflow.
5146 (PRINTPREPARE, printchar, strout):
5147 Don't set size unless allocation succeeds.
5148
90532f02
PE
5149 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5150 for sizes. Check for string overflow more accurately.
5151 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5152
6d84508d
PE
5153 * macros.c: Integer and buffer overflow fixes.
5154 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5155 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5156 Use ptrdiff_t, not int, for sizes.
5157 Don't increment bufsize until after realloc succeeds.
5158 Check for size-calculation overflow.
5159 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5160
437b2cb4
PE
5161 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5162
8b9ac8b4
PE
5163 * lread.c: Integer overflow fixes.
5164 (read_integer): Radix is now EMACS_INT, not int,
5165 to improve quality of diagnostics for out-of-range radices.
5166 Calculate buffer size correctly for out-of-range radices.
5167 (read1): Check for integer overflow in radices, and in
5168 read-circle numbers.
82cb60d3
PE
5169 (read_escape): Avoid int overflow.
5170 (Fload, openp, read_buffer_size, read1)
5171 (substitute_object_recurse, read_vector, read_list, map_obarray):
5172 Use ptrdiff_t, not int, for sizes.
5173 (read1): Use EMACS_INT, not int, for sizes.
20270765 5174 Check for size overflow.
8b9ac8b4 5175
7fcccf1e
PE
5176 * image.c (cache_image): Check for size arithmetic overflow.
5177
bfbbd7e7
PE
5178 * lread.c: Integer overflow issues.
5179 (saved_doc_string_size, saved_doc_string_length)
5180 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5181 Now ptrdiff_t, not int.
5182 (read1): Don't assume doc string length fits in int. Check for
5183 out-of-range doc string lengths.
5184 (read_list): Don't assume file position fits in int.
39019e54 5185 (read_escape): Check for hex character overflow.
bfbbd7e7 5186
4e323265
LL
51872011-06-22 Leo Liu <sdl.web@gmail.com>
5188
5189 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5190 Move to minibuffer.el.
5191
85fece3e
PE
51922011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5193
20b84ce9 5194 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5195 The following patches are for when GLYPH_DEBUG && !XASSERT.
5196 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5197 * dispnew.c (flush_stdout):
5198 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5199 Mark as externally visible.
5200 * dispnew.c (check_window_matrix_pointers): Now static.
5201 * dispnew.c (window_to_frame_vpos):
5202 * xfns.c (unwind_create_frame):
5203 * xterm.c (x_check_font): Remove unused local.
5204 * scroll.c (CHECK_BOUNDS):
5205 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5206 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5207 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5208 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5209 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5210 Now static.
5211 (debug_method_add): Use va_list and vsprintf rather than relying
5212 on undefined behavior with wrong number of arguments.
5213 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5214 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5215 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5216 since we're not interested in debugging glyphs with old libraries.
5217 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5218 GCC 4.6.0's static checking.
5219
0766b489
PE
52202011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5221
31fd4b32
PE
5222 Integer overflow and signedness fixes (Bug#8873).
5223 A few related buffer overrun fixes, too.
5224
b79e8648
PE
5225 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5226
0766b489
PE
5227 * dispextern.h (struct face.stipple):
5228 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5229 (x_bitmap_mask, x_allocate_bitmap_record)
5230 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5231 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5232 (x_create_bitmap_from_xpm_data):
5233 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5234 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5235 (.bitmaps_last):
5236 * xfaces.c (load_pixmap):
5237 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5238 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5239 (.bitmaps_last, struct x_output.icon_bitmap):
5240 Use ptrdiff_t, not int, for bitmap indexes.
5241 (x_allocate_bitmap_record): Check for size overflow.
5242 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5243
b081724f
PE
5244 Use ptrdiff_t, not int, for overlay counts.
5245 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5246 * editfns.c (overlays_around, get_pos_property):
5247 * textprop.c (get_char_property_and_overlay):
5248 * xdisp.c (next_overlay_change, note_mouse_highlight):
5249 * xfaces.c (face_at_buffer_position):
21514da7
PE
5250 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5251 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5252 (Fnext_overlay_change, Fprevious_overlay_change)
5253 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5254 Use ptrdiff_t, not int, for sizes.
21514da7 5255 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5256
3de73e5e
PE
5257 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5258
2606c57b
PE
5259 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5260 (x_session_initialize): Do not assume string length fits in int.
5261
aaafe47a
PE
5262 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5263 This is unlikely, but can occur if DPI is outlandish.
5264
2674ddc8 5265 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5266 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5267
28154962
PE
5268 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5269 * xrdb.c (magic_file_p, search_magic_path):
5270 Omit last arg SUFFIX; it was always 0. All callers changed.
5271 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5272
7de51af5
PE
5273 * xfont.c (xfont_match): Avoid need for strlen.
5274
25ed6cc3
PE
5275 * xfns.c: Don't assume strlen fits in int.
5276 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5277
4eab31dd
PE
5278 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5279 not unsigned long, as we prefer signed integers. All callers changed.
5280 Detect integer overflow in repeat count.
5281 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5282 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5283
171e2a58
PE
5284 * termcap.c: Don't assume sizes fit in int and never overflow.
5285 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5286 (gobble_line): Check for size-calculation overflow.
5287
ad39faca 5288 * minibuf.c (Fread_buffer):
6e5bb2dc 5289 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5290 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5291 Don't assume string length fits in int.
5292
52c61c22 5293 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5294 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5295
b5b8c9e5
PE
5296 * font.c: Don't assume string length fits in int.
5297 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5298 Use ptrdiff_t, not int.
ccd6111c
PE
5299 (font_intern_prop): Don't assume string length fits in int.
5300 Don't assume integer property fits in fixnum.
5301 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5302
882f0d81 5303 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5304 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5305 Reformulate so as not to need the command string.
5306 Invoke gzip -cd rather than gunzip, as it's more portable.
5307 (lock_info_type, lock_file_1, lock_file):
5308 Don't assume pid_t and time_t fit in unsigned long.
5309 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5310 (current_lock_owner): Prefer signed type for sizes.
5311 Use memcpy, not strncpy, where memcpy is what is really wanted.
5312 Don't assume (via atoi) that time_t and pid_t fit in int.
5313 Check for time_t and/or pid_t out of range, e.g., via a network share.
5314 Don't alloca where an auto var works fine.
5315
93f4cf88
PE
5316 * fileio.c: Fix some integer overflow issues.
5317 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5318 Don't assume string length fits in int.
5319 (directory_file_name): Don't assume string length fits in long.
5320 (make_temp_name): Don't assume pid fits in int, or that its print
5321 length is less than 20.
5322
f3e92b69
PE
5323 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5324
1bfdaf10
PE
5325 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5326
35016e9a
PE
5327 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5328
3d1e65a1
PE
5329 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5330 We prefer signed integers, even for size calculations.
5331
0b963a93
PE
5332 * emacs.c: Don't assume string length fits in 'int'.
5333 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5334 (main): Don't invoke strlen when not needed.
5335
573f4b54
PE
5336 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5337 (XD_DEBUG_MESSAGE): Don't waste a byte.
5338
989f33ba
PE
5339 * callproc.c (getenv_internal_1, getenv_internal)
5340 (Fgetenv_internal):
965d34eb
PE
5341 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5342
e4d29b33
PE
5343 * lread.c (invalid_syntax): Omit length argument.
5344 All uses changed. This doesn't fix a bug, but it simplifies the
5345 code away from its former Hollerith-constant appearance, and it's
5346 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5347 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5348
eb49b136
PE
5349 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5350 This didn't break anything, but it didn't help either.
5351 It's confusing to put a bogus integer in a place where the actual
5352 value does not matter.
9f62aeb1 5353 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5354 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5355
15375a22
PE
5356 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5357 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5358 implementation.
b61cc01c
PE
5359 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5360 We prefer signed types, and the value cannot exceed the EMACS_INT
5361 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5362 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5363 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5364 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5365
53b2623d
PE
5366 * indent.c (sane_tab_width): New function.
5367 (current_column, scan_for_column, Findent_to, position_indentation)
5368 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5369 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5370
51cab52b 5371 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5372
f2ed8a70
PE
5373 * lisp.h (lint_assume): New macro.
5374 * composite.c (composition_gstring_put_cache):
5375 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5376
abe80cc6
PE
5377 * editfns.c, insdel.c:
5378 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5379
b02c740e
PE
5380 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5381
ebc96716
PE
5382 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5383
b4e50fa0 5384 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5385 Use much-faster test for byte-length change.
311d5d7c 5386 Don't assume string byte-length fits in 'int'.
a4cf38e4 5387 Check that character arg fits in 'int'.
85461888 5388 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5389
c0c1ee9f
PE
5390 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5391
a498d7f4
PE
5392 * fns.c (concat): Catch string overflow earlier.
5393 Do not rely on integer wraparound.
5394
51cab52b
PE
5395 * dispextern.h (struct it.overlay_strings_charpos)
5396 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5397 * xdisp.c (forward_to_next_line_start)
5398 (back_to_previous_visible_line_start)
5399 (reseat_at_next_visible_line_start, next_element_from_buffer):
5400 Don't arbitrarily truncate the value of 'selective' to int.
5401
76031fad
PE
5402 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5403
5eb55db9
PE
5404 * composite.c: Don't truncate sizes to 'int'.
5405 (composition_gstring_p, composition_reseat_it)
5406 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5407 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5408 not EMACS_UINT, for indexes.
5eb55db9 5409
0703a717
PE
5410 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5411
d6202519
PE
5412 * buffer.c: Include <verify.h>.
5413 (struct sortvec.priority, struct sortstr.priority):
8961a454 5414 Now EMACS_INT, not int.
c20998a7 5415 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5416 (struct sortstr.size, record_overlay_string)
5417 (struct sortstrlist.size, struct sortlist.used):
5418 Don't truncate size to int.
5419 (record_overlay_string): Check for size-calculation overflow.
d6202519 5420 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5421
d5a19415
JM
54222011-06-22 Jim Meyering <meyering@redhat.com>
5423
029529ac 5424 Don't leak an XBM-image-sized buffer
d5a19415
JM
5425 * image.c (xbm_load): Free the image buffer after using it.
5426
a9041e6c
PE
54272011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5428
5429 Port to Sun C.
5430 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5431 that Sun C diagnosed.
5432 * fns.c (secure_hash): Fix pointer signedness issue.
5433 * intervals.c (static_offset_intervals): New function.
5434 (offset_intervals): Use it.
5435
7f3f739f
LL
54362011-06-21 Leo Liu <sdl.web@gmail.com>
5437
5438 * deps.mk (fns.o):
5439 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5440 sha512.h.
5441
5442 * fns.c (secure_hash): Rename from crypto_hash_function and change
5443 the first arg to accept symbols.
5b66d427 5444 (Fsecure_hash): New primitive.
7f3f739f
LL
5445 (syms_of_fns): New symbols.
5446
76147d94
DD
54472011-06-20 Deniz Dogan <deniz@dogan.se>
5448
5449 * process.c (Fset_process_buffer): Clarify return value in
5450 docstring.
5451
7d7d0045
CY
54522011-06-18 Chong Yidong <cyd@stupidchicken.com>
5453
5454 * dispnew.c (add_window_display_history): Use BVAR.
5455
5456 * xdisp.c (debug_method_add): Use BVAR.
5457 (check_window_end, dump_glyph_matrix, dump_glyph)
5458 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5459
5460 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5461 Likewise.
5462
5463 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5464 check till after the cache is created in init_frame_faces.
5465
ff2bc410
SM
54662011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5467
5468 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5469
28177add
PE
54702011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5471
dd3482fe
PE
5472 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5473 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5474 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5475
393d71f3 5476 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5477 * fileio.c (Finsert_file_contents):
5478 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5479 Remove the old (too-loose) buffer overflow checks.
5480 They weren't needed, since make_gap checks for buffer overflow.
5481 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5482 The old code merely checked for Emacs fixnum overflow, and relied
5483 on undefined (wraparound) behavior. The new code avoids undefined
5484 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5485
2e6813b0 5486 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5487 Tune. Don't use wider integers than needed. Don't use alloca.
5488 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5489
599a9e4f
PE
5490 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5491
99561444
PE
5492 * insdel.c, lisp.h (buffer_overflow): New function.
5493 (insert_from_buffer_1, replace_range, replace_range_2):
5494 * insdel.c (make_gap_larger):
5495 * editfns.c (Finsert_char):
5496 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5497
28177add
PE
5498 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5499
e69dafad
PE
55002011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5501
4baa020d 5502 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5503
b1c46f02
PE
5504 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5505 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5506
e69dafad
PE
5507 * fileio.c: Don't assume EMACS_INT fits in off_t.
5508 (emacs_lseek): New static function.
5509 (Finsert_file_contents, Fwrite_region): Use it.
5510 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5511
566684ea
PE
5512 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5513
e6966cd6
PE
5514 * fns.c: Don't overflow int when computing a list length.
5515 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5516 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5517 truncation on 64-bit hosts. Check for QUIT every
5518 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5519 faster and is responsive enough.
5520 (Flength): Report an error instead of overflowing an integer.
5521 (Fsafe_length): Return a float if the value is not representable
5522 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5523 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5524 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5525
dd0b0efb
PE
5526 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5527 (header_size, word_size): New constants.
5528 (allocate_vectorlike): Don't check size overflow here.
5529 (allocate_vector): Check it here instead, since this is the only
5530 caller of allocate_vectorlike that could cause overflow.
5531 Check that the new vector's length is representable as a fixnum.
5532
86fe5cfe
PE
5533 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5534 The previous code was bogus. For example, next_almost_prime (32)
5535 returned 39, which is undesirable as it is a multiple of 3; and
5536 next_almost_prime (24) returned 25, which is a multiple of 5 so
5537 why was the code bothering to check for multiples of 7?
5538
80e88859
PE
5539 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5540
4a2f0ad6
PE
5541 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5542
f66c7cf8
PE
5543 Variadic C functions now count arguments with ptrdiff_t.
5544 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5545 Back then I didn't know that the Emacs coding style prefers signed int.
5546 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5547 were being counted with int, which may truncate counts on 64-bit
5548 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5549 * lisp.h (struct Lisp_Subr.function.aMANY)
5550 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5551 Arg counts are now ptrdiff_t, not size_t.
5552 All variadic functions and their callers changed accordingly.
5553 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5554 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5555 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5556 * callint.c (Fcall_interactively): Check arg count for overflow,
5557 to avoid potential buffer overrun. Use signed char, not 'int',
5558 for 'varies' array, so that we needn't bother to check its size
5559 calculation for overflow.
5560 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5561 * eval.c (apply_lambda):
5562 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5563 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5564 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5565
a1759b76
PE
5566 * callint.c (Fcall_interactively): Don't use index var as event count.
5567
d96be9fc
PE
5568 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5569 * mem-limits.h (SIZE): Remove; no longer used.
5570
a690a978 5571 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5572
578c21e6
PE
5573 Remove unnecessary casts.
5574 * xterm.c (x_term_init):
5575 * xfns.c (x_set_border_pixel):
5576 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5577 These aren't needed now that we assume ANSI C.
5578
96f53c6c
PE
5579 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5580 It's more likely to cause problems (due to unsigned overflow)
5581 than to cure them.
5582
83c77d31
PE
5583 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5584
ee2079f1
PE
5585 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5586
6da65536
PE
5587 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5588
7147c4a4
PE
5589 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5590
193e32d9
PE
5591 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5592
e5533da6
PE
5593 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5594
9910e595
PE
5595 GLYPH_CODE_FACE returns EMACS_INT, not int.
5596 * dispextern.h (merge_faces):
5597 * xfaces.c (merge_faces):
01103c44
PE
5598 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5599 Don't assume EMACS_INT fits in int.
9910e595 5600
2638320e
PE
5601 * character.h (CHAR_VALID_P): Remove unused parameter.
5602 * fontset.c, lisp.h, xdisp.c: All uses changed.
5603
045eb8d9
PE
5604 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5605
c1f134b5
PE
5606 * fns.c (concat): Minor tuning based on overflow analysis.
5607 This doesn't fix any bugs. Use int to hold character, instead
5608 of constantly refetching from Emacs object. Use XFASTINT, not
5609 XINT, for value known to be a character. Don't bother comparing
5610 a single byte to 0400, as it's always less.
5611
395fcb93 5612 * floatfns.c (Fexpt):
327eeec8
PE
5613 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5614
abbd3d23
PE
5615 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5616 for characters.
5617
684a03ef
PE
5618 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5619
0fed43f3
PE
5620 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5621 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5622 incorrectly succeed when S was a string, because 4294967386 was
5623 truncated before it was used.
5624
8fd02eb7
PE
5625 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5626 Otherwise, an out-of-range integer could cause undefined behavior
5627 on a 64-bit host.
5628
f8c86b69
PE
5629 * composite.c: Use int, not EMACS_INT, for characters.
5630 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5631 EMACS_INT, for values that are known to be in character range.
5632 This doesn't fix any bugs but is the usual style inside Emacs and
5633 may generate better code on 32-bit machines.
5634
34206dd2
PE
5635 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5636 This is for reasons similar to the recent CHAR_STRING fix.
5637 * charset.c (Fencode_char): Check that character arg is actually
5638 a character. Pass an int to ENCODE_CHAR.
5639 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5640 wider than 'int', as a compile-time check to prevent future regressions
5641 in this area.
5642
c5958d4c 5643 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5644
5645 Make sure a 64-bit char is never passed to CHAR_STRING.
5646 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5647 by silently ignoring the top 32 bits, allowing some values
5648 that were far too large to be valid characters.
5649 * character.h: Include <verify.h>.
5650 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5651 arguments are no wider than unsigned, as a compile-time check
5652 to prevent future regressions in this area.
5653 * data.c (Faset):
01103c44 5654 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5655 (Fsubst_char_in_region):
5656 * fns.c (concat):
5657 * xdisp.c (decode_mode_spec_coding):
5658 Adjust to CHAR_STRING's new requirement.
5659 * editfns.c (Finsert_char, Fsubst_char_in_region):
5660 * fns.c (concat): Check that character args are actually
5661 characters. Without this test, these functions did the wrong
5662 thing with wildly out-of-range values on 64-bit hosts.
5663
d37ca623
PE
5664 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5665 These casts should not be needed on 32-bit hosts, either.
5666 * keyboard.c (read_char):
5667 * lread.c (Fload): Remove casts to unsigned.
5668
ea204efb
PE
5669 * lisp.h (UNSIGNED_CMP): New macro.
5670 This fixes comparison bugs on 64-bit hosts.
5671 (ASCII_CHAR_P): Use it.
5672 * casefiddle.c (casify_object):
01103c44 5673 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5674 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5675 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5676 * dispextern.h (FACE_FROM_ID):
5677 * keyboard.c (read_char): Use UNSIGNED_CMP.
5678
41cb286c
PE
5679 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5680 not to EMACS_INT, to avoid GCC warning.
5681
4a1b9832
PE
5682 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5683
55daad71
PE
5684 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5685 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5686 isn't needed on 32-bit machines.
8f95c75c 5687
01103c44
PE
5688 * buffer.c (Fgenerate_new_buffer_name):
5689 Use EMACS_INT for count, not int.
0ceccced 5690 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5691
5692 * data.c (Qcompiled_function): Now static.
5693
c6f072e7
PE
5694 * window.c (window_body_lines): Now static.
5695
20ce5912
PE
5696 * image.c (gif_load): Rename local to avoid shadowing.
5697
9c4c5f81
PE
5698 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5699 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5700 * alloc.c (make_save_value): Integer argument is now of type
5701 ptrdiff_t, not int.
5702 (mark_object): Use ptrdiff_t, not int.
5703 * lisp.h (pD): New macro.
5704 * print.c (print_object): Use it.
5705
c0c5c8ae
PE
5706 * alloc.c: Use EMACS_INT, not int, to count objects.
5707 (total_conses, total_markers, total_symbols, total_vector_size)
5708 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5709 (total_free_floats, total_floats, total_free_intervals)
5710 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5711 Now EMACS_INT, not int. All uses changed.
5712 (Fgarbage_collect): Compute overall total using a double, so that
5713 integer overflow is less likely to be a problem. Check for overflow
5714 when converting back to an integer.
5a25e253
PE
5715 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5716 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5717 These were 'int' variables that could overflow on 64-bit hosts;
5718 they were never used, so remove them instead of repairing them.
211a0b2a 5719 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5720 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5721 Previously, this ceilinged at INT_MAX, but that doesn't work on
5722 64-bit machines.
e46bb31a 5723 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5724
c78baabf 5725 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5726 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5727 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5728 when a (possibly-narrower) signed value would do just as well.
5729 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5730
c9d624c6
PE
5731 * alloc.c: Catch some string size overflows that we were missing.
5732 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5733 for convenience in STRING_BYTES_MAX.
5734 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5735 The definition here is exact; the one in lisp.h was approximate.
5736 (allocate_string_data): Check for string overflow. This catches
5737 some instances we weren't catching before. Also, it catches
5738 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5739 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5740 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5741
c9d624c6
PE
5742 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5743 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5744 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5745
353032ce
PE
5746 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5747
2bccce07
PE
5748 * alloc.c (Fmake_string): Check for out-of-range init.
5749
0ac30604
SM
57502011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5751
5752 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5753
c195f2de
JD
57542011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5755
5756 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5757 xg_get_default_scrollbar_width.
5758
5759 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5760 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5761 (style_changed_cb): Call update_theme_scrollbar_width and call
5762 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5763 all frames (Bug#8505).
5764 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5765 Call gtk_window_set_resizable if HAVE_GTK3.
5766 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5767 and height if HAVE_GTK3 (Bug#8505).
5768 (scroll_bar_width_for_theme): New variable.
5769 (update_theme_scrollbar_width): New function.
5770 (xg_get_default_scrollbar_width): Move code to
5771 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5772 (xg_initialize): Call update_theme_scrollbar_width.
5773
5774 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5775
5776 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5777
e10ac9f1
MR
57782011-06-12 Martin Rudalics <rudalics@gmx.at>
5779
5780 * frame.c (make_frame): Call other_buffer_safely instead of
5781 other_buffer.
5782
5783 * window.c (temp_output_buffer_show): Call display_buffer with
5784 second argument Vtemp_buffer_show_specifiers and reset latter
5785 immediately after the call.
5786 (Vtemp_buffer_show_specifiers): New variable.
5787 (auto_window_vscroll_p, next_screen_context_lines)
5788 (Vscroll_preserve_screen_position): Remove leading asterisks from
5789 doc-strings.
5790
2d3c217e 57912011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5792
7b7f97e8 5793 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5794 * buffer.c (Qclone_number): Remove for now, as it's unused.
5795 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5796 (record_buffer): Remove unused local.
5797 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5798 (set_frame_buffer_list): Remove; unused.
5799 * frame.h (other_visible_frames): Remove decl.
5800 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5801 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5802 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5803 if HAVE_GPM.
5804 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5805 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5806 Define only if HAVE_GPM.
5807 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5808 (update_hints_inhibit): Remove; never set. All uses removed.
5809 * widgetprv.h (emacsFrameClassRec): Remove decl.
5810 * window.c (delete_deletable_window): Now returns void, since it
5811 wasn't returning anything.
5812 (compare_window_configurations): Remove unused locals.
5813 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5814 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5815 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5816 the same widths as pointers. This follows up on the 2011-05-06 patch.
5817 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5818 * xterm.h: Likewise.
5819 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5820
1384b89e
JB
58212011-06-12 Juanma Barranquero <lekktu@gmail.com>
5822
5823 * makefile.w32-in: Update dependencies.
5824 (LISP_H): Add lib/intprops.h.
5825
1100a63c
CY
58262011-06-11 Chong Yidong <cyd@stupidchicken.com>
5827
5828 * image.c (gif_load): Add animation frame delay to the metadata.
5829 (syms_of_image): Use DEFSYM. New symbol `delay'.
5830
6198ccd0
MR
58312011-06-11 Martin Rudalics <rudalics@gmx.at>
5832
5833 * window.c (delete_deletable_window): Re-add.
5834 (Fset_window_configuration): Rewrite to handle dead buffers and
5835 consequently deletable windows.
5836 (window_tree, Fwindow_tree): Remove. Supply functionality in
5837 window.el.
5838 (compare_window_configurations): Simplify code.
5839
b6e3633c
AS
58402011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5841
1ab0dee5
AS
5842 * image.c (imagemagick_load_image): Fix type mismatch.
5843 (Fimagemagick_types): Likewise.
5844
b6e3633c
AS
5845 * window.h (replace_buffer_in_windows): Declare.
5846
9397e56f
MR
58472011-06-11 Martin Rudalics <rudalics@gmx.at>
5848
5849 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5850 Qclone_number. Remove external declaration of Qdelete_window.
5851 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5852 code.
640c8776
SM
5853 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5854 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5855 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5856 buffer list implementation.
5857 (other_buffer_safely): New function.
5858 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5859 calls to replace_buffer_in_windows and
5860 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5861 if allowed.
5862 (record_buffer): Inhibit quitting and rewrite using quittable
5863 functions. Run Qbuffer_list_update_hook if allowed.
5864 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5865 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5866 Move switch-to-buffer to window.el.
9397e56f
MR
5867 (bury-buffer): Move to window.el.
5868 (Vbuffer_list_update_hook): New variable.
5869
5870 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5871 section.
5872
5873 * window.h (resize_frame_windows): Move up in code.
5874 (Fwindow_frame): Remove EXFUN.
5875 (replace_buffer_in_all_windows): Remove prototype.
5876 (replace_buffer_in_windows_safely): Add prototype.
5877
5878 * window.c: Declare Qdelete_window static again. Move down
5879 declaration of select_count.
5880 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5881 (Fother_window): Move to window.el.
5882 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5883 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5884 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5885 window.el.
5886 (replace_buffer_in_windows): Implement by calling
5887 Qreplace_buffer_in_windows.
5888 (replace_buffer_in_all_windows): Remove with some functionality
5889 moved into replace_buffer_in_windows_safely.
5890 (replace_buffer_in_windows_safely): New function.
5891 (select_window_norecord, select_frame_norecord): Move in front
5892 of run_window_configuration_change_hook. Remove now obsolete
5893 declarations.
640c8776
SM
5894 (Fset_window_buffer): Rewrite doc-string.
5895 Call Qrecord_window_buffer.
9397e56f
MR
5896 (keys_of_window): Move binding for other-window to window.el.
5897
b50691aa
CY
58982011-06-11 Chong Yidong <cyd@stupidchicken.com>
5899
5900 * dispextern.h (struct image): Replace data member, whose int_val
5901 and ptr_val fields were not used by anything, with a single
5902 lisp_val object.
5903
5904 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5905 (gif_clear_image, gif_load, imagemagick_load_image)
5906 (gs_clear_image, gs_load): Callers changed.
5907
3f754b86
PE
59082011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5909
cca69397
PE
5910 * buffer.h: Include <time.h>, for time_t.
5911 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5912
109e28d0
PE
5913 Fix minor problems found by static checking.
5914
60737f02
PE
5915 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5916
4b66faf3
PE
5917 Make identifiers static if they are not used in other modules.
5918 * data.c (Qcompiled_function, Qframe, Qvector):
5919 * image.c (QimageMagick, Qsvg):
5920 * minibuf.c (Qmetadata):
5921 * window.c (resize_window_check, resize_root_window): Now static.
5922 * window.h (resize_window_check, resize_root_window): Remove decls.
5923
109e28d0
PE
5924 * window.c (window_deletion_count, delete_deletable_window):
5925 Remove; unused.
46a4ce9e
PE
5926 (window_body_lines): Now static.
5927 (Fdelete_other_windows_internal): Mark vars as initialized.
5928 Make sure 'resize_failed' is initialized.
5929 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5930 (resize_window_apply): Remove unused local.
5931 * window.h (delete_deletable_window): Remove decl.
5932
109e28d0 5933 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5934 (imagemagick_load_image): Fix pointer signedness problem by changing
5935 last arg from unsigned char * to char *. All uses changed.
5936 Also, fix a local for similar reasons.
5937 Remove unused locals. Remove locals to avoid shadowing.
5938 (fn_rsvg_handle_free): Remove; unused.
5939 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5940 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5941
3f754b86
PE
5942 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5943
2547adb1
CY
59442011-06-10 Chong Yidong <cyd@stupidchicken.com>
5945
5946 * image.c (gif_load): Fix omitted cast error introduced by
5947 2011-06-06 change.
5948
2c8e37d4
MR
59492011-06-10 Martin Rudalics <rudalics@gmx.at>
5950
5951 * window.h (resize_proportionally, orig_total_lines)
5952 (orig_top_line): Remove from window structure.
5953 (set_window_height, set_window_width, change_window_heights)
5954 (Fdelete_window): Remove prototypes.
5955 (resize_frame_windows): Remove duplicate declaration.
5956
440a42e3
EZ
59572011-06-10 Eli Zaretskii <eliz@gnu.org>
5958
5959 * window.h (resize_frame_windows, resize_window_check)
5960 (delete_deletable_window, resize_root_window)
5961 (resize_frame_windows): Declare prototypes.
5962
5963 * window.c (resize_window_apply): Make definition be "static" to
5964 match the prototype.
5965
562dd5e9
MR
59662011-06-10 Martin Rudalics <rudalics@gmx.at>
5967
5968 * window.c: Remove declarations of Qwindow_size_fixed,
5969 window_min_size_1, window_min_size_2, window_min_size,
5970 size_window, window_fixed_size_p, enlarge_window, delete_window.
5971 Remove static from declaration of Qdelete_window, it's
5972 temporarily needed by Fbury_buffer.
5973 (replace_window): Don't assign orig_top_line and
5974 orig_total_lines.
5975 (Fdelete_window, delete_window): Remove. Window deletion is
5976 handled by window.el.
640c8776
SM
5977 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5978 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5979 (Fdelete_other_windows): Remove. Deleting other windows is
5980 handled by window.el.
5981 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5982 handled in window.el.
5983 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5984 Window minimum sizes are handled in window.el.
5985 (shrink_windows, size_window, set_window_height)
5986 (set_window_width, change_window_heights, window_height)
5987 (window_width, CURBEG, CURSIZE, enlarge_window)
5988 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5989 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5990 handled in window.el.
5991 (make_dummy_parent): Rename to make_parent_window and give it a
5992 second argument horflag.
5993 (make_window): Don't set resize_proportionally any more.
5994 (Fsplit_window): Remove. Windows are split in window.el.
5995 (save_restore_action, save_restore_orig_size)
5996 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5997 Resize mini windows in window.el.
5998 (grow_mini_window, shrink_mini_window): Implement by calling
5999 Qresize_root_window_vertically, resize_window_check and
6000 resize_window_apply.
640c8776
SM
6001 (saved_window, Fset_window_configuration, save_window_save):
6002 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
6003 resize_proportionally.
6004 (window_min_height, window_min_width): Move to window.el.
6005 (keys_of_window): Move bindings for delete-other-windows,
6006 split-window, delete-window and enlarge-window to window.el.
6007
6008 * buffer.c: Temporarily extern Qdelete_window.
6009 (Fbury_buffer): Temporarily call Qdelete_window instead of
6010 Fdelete_window (Fbury_buffer will move to window.el soon).
6011
6012 * frame.c (set_menu_bar_lines_1): Remove code handling
6013 orig_top_line and orig_total_lines.
6014
6015 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6016 set_window_height but set heights directly.
6017 (change_frame_size_1): Use resize_frame_windows.
6018
6019 * xdisp.c (init_xdisp): Don't use set_window_height but set
6020 heights directly.
6021
640c8776
SM
6022 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6023 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
6024 run_window_configuration_change_hook.
6025
6026 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6027 instead of change_window_heights and run
6028 run_window_configuration_change_hook.
6029
1a13852e
MR
60302011-06-09 Martin Rudalics <rudalics@gmx.at>
6031
6032 * window.c (replace_window): Rename second argument REPLACEMENT to
6033 NEW. New third argument SETFLAG. Rewrite.
6034 (delete_window, make_dummy_parent): Call replace_window with
6035 third argument 1.
6036 (window_list_1): Move down in code.
6037 (run_window_configuration_change_hook): Move set_buffer part
6038 before select_frame_norecord part in order to unwind correctly.
6039 Rename count1 to count.
6040 (recombine_windows, delete_deletable_window, resize_root_window)
6041 (Fdelete_other_windows_internal)
6042 (Frun_window_configuration_change_hook, make_parent_window)
6043 (resize_window_check, resize_window_apply, Fresize_window_apply)
6044 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
6045 (Fdelete_window_internal, Fresize_mini_window_internal):
6046 New functions.
1a13852e
MR
6047 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6048
f3d1777e
MR
60492011-06-08 Martin Rudalics <rudalics@gmx.at>
6050
496e208e
MR
6051 * window.h (window): Add some new members to window structure -
6052 normal_lines, normal_cols, new_total, new_normal, clone_number,
6053 splits, nest, prev_buffers, next_buffers.
6054 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6055 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6056
f3d1777e
MR
6057 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6058 Remove.
496e208e
MR
6059 (make_dummy_parent): Set new members of windows structure.
6060 (make_window): Move down in code. Handle new members of window
6061 structure.
6062 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6063 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6064 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6065 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6066 (Fset_window_next_buffers, Fset_window_clone_number):
6067 New functions.
496e208e
MR
6068 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6069 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6070 Doc-string fixes.
6071 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6072 Argument WINDOW can be now internal window too.
6073 (Fwindow_use_time): Move up in code.
6074 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6075 Rewrite doc-string.
6076 (Fset_window_configuration, saved_window)
6077 (Fcurrent_window_configuration, save_window_save): Handle new
6078 members of window structure.
b9e809c2
MR
6079 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6080 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6081 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6082 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6083 Qget_mru_window, Qresize_root_window,
6084 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6085 Qauto_buffer_name; staticpro them.
f3d1777e 6086
abde8f8c
MR
60872011-06-07 Martin Rudalics <rudalics@gmx.at>
6088
6089 * window.c (Fwindow_total_size, Fwindow_left_column)
6090 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6091 (Fwindow_list_1): New functions.
6092 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6093 (Fwindow_width, Fscroll_left, Fscroll_right):
6094 Use window_body_cols instead of window_box_text_cols.
6095 (delete_window, Fset_window_configuration):
6096 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6097 (delete_all_subwindows): Take a window as argument and not a
6098 structure. Rewrite.
190b47e6
MR
6099 (window_loop): Remove handling of GET_LRU_WINDOW and
6100 GET_LARGEST_WINDOW.
6101 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6102
6103 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6104 window_box_text_cols. delete_all_subwindows now takes a
6105 Lisp_Object as argument.
abde8f8c 6106
640c8776
SM
6107 * indent.c (compute_motion, Fcompute_motion):
6108 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6109
fa8a67e6
MR
6110 * frame.c (delete_frame): Call delete_all_subwindows with root
6111 window as argument.
6112
a54e3482
DC
61132011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6114
6115 * fns.c (Fputhash): Document return value.
6116
60002bf5
CY
61172011-06-06 Chong Yidong <cyd@stupidchicken.com>
6118
6119 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6120
0c671da6 61212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6122
b862a52a 6123 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6124
be44ca6c
PE
6125 Check for overflow when converting integer to cons and back.
6126 * charset.c (Fdefine_charset_internal, Fdecode_char):
6127 Use cons_to_unsigned to catch overflow.
6128 (Fencode_char): Use INTEGER_TO_CONS.
6129 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6130 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6131 * data.c (long_to_cons, cons_to_long): Remove.
6132 (cons_to_unsigned, cons_to_signed): New functions.
6133 These signal an error for invalid or out-of-range values.
6134 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6135 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6136 * font.c (Ffont_variation_glyphs):
6137 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6138 * lisp.h: Include <intprops.h>.
6139 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6140 (cons_to_signed, cons_to_unsigned): New decls.
6141 (long_to_cons, cons_to_long): Remove decls.
6142 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6143 (Fprimitive_undo): Use CONS_TO_INTEGER.
6144 * xfns.c (Fx_window_property): Likewise.
6145 * xselect.c: Include <limits.h>.
6146 (x_own_selection, selection_data_to_lisp_data):
6147 Use INTEGER_TO_CONS.
6148 (x_handle_selection_request, x_handle_selection_clear)
6149 (x_get_foreign_selection, Fx_disown_selection_internal)
6150 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6151 (lisp_data_to_selection_data): Use cons_to_unsigned.
6152 (x_fill_property_data): Use cons_to_signed.
6153 Report values out of range.
6154
d1f3d2af
PE
6155 Check for buffer and string overflow more precisely.
6156 * buffer.h (BUF_BYTES_MAX): New macro.
6157 * lisp.h (STRING_BYTES_MAX): New macro.
6158 * alloc.c (Fmake_string):
6159 * character.c (string_escape_byte8):
6160 * coding.c (coding_alloc_by_realloc):
6161 * doprnt.c (doprnt):
6162 * editfns.c (Fformat):
6163 * eval.c (verror):
6164 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6165 since they may not be the same number.
6166 * editfns.c (Finsert_char):
6167 * fileio.c (Finsert_file_contents):
6168 Likewise for BUF_BYTES_MAX.
6169
dd52fcea
PE
6170 * image.c: Use ptrdiff_t, not int, for sizes.
6171 (slurp_file): Switch from int to ptrdiff_t.
6172 All uses changed.
6173 (slurp_file): Check that file size fits in both size_t (for
6174 malloc) and ptrdiff_t (for sanity and safety).
6175
7f9bbdbb
PE
6176 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6177 if b->modtime has its maximal value.
6178
dfe18f82
PE
6179 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6180
84acfcf0
PE
6181 Don't assume time_t can fit into int.
6182 * buffer.h (struct buffer.modtime): Now time_t, not int.
6183 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6184 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6185
ccd9a01a
PE
6186 Minor fixes for signed vs unsigned integers.
6187 * character.h (MAYBE_UNIFY_CHAR):
6188 * charset.c (maybe_unify_char):
6189 * keyboard.c (read_char, reorder_modifiers):
6190 XINT -> XFASTINT, since the integer must be nonnegative.
6191 * ftfont.c (ftfont_spec_pattern):
6192 * keymap.c (access_keymap, silly_event_symbol_error):
6193 XUINT -> XFASTINT, since the integer must be nonnegative.
6194 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6195 since it makes no difference and we prefer signed.
6196 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6197 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6198 nonnegative.
6199
d6d100dd
SM
62002011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6201
6202 * window.h (Fwindow_frame): Declare.
6203
2b6148e4
PE
62042011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6205
6206 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6207 (SPARE_MEMORY): Always define.
6208 (LARGE_REQUEST): Remove.
6209 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6210
f230ecc9
MR
62112011-06-06 Martin Rudalics <rudalics@gmx.at>
6212
727e958e
MR
6213 * lisp.h: Move EXFUNS for Fframe_root_window,
6214 Fframe_first_window and Fset_frame_selected_window to window.h.
6215
6216 * window.h: Move EXFUNS for Fframe_root_window,
6217 Fframe_first_window and Fset_frame_selected_window here from
6218 lisp.h.
6219
6220 * frame.c (Fwindow_frame, Fframe_first_window)
6221 (Fframe_root_window, Fframe_selected_window)
6222 (Fset_frame_selected_window): Move to window.c.
6223 (Factive_minibuffer_window): Move to minibuf.c.
6224 (Fother_visible_frames_p): New function.
6225
6226 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6227
f230ecc9
MR
6228 * window.c (decode_window, decode_any_window): Move up in code.
6229 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6230 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6231 (Fwindow_buffer): Move up and rewrite doc-string.
6232 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6233 (Fwindow_prev): New functions.
727e958e
MR
6234 (Fwindow_frame): Move here from frame.c. Accept any window as
6235 argument.
6236 (Fframe_root_window, Fframe_first_window)
6237 (Fframe_selected_window): Move here from frame.c. Accept frame
6238 or arbitrary window as argument. Update doc-strings.
6239 (Fminibuffer_window): Move up in code.
6240 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6241 (Fset_frame_selected_window): Move here from frame.c.
6242 Marginal rewrite.
727e958e
MR
6243 (Fselected_window, select_window, Fselect_window): Move up in
6244 code. Minor doc-string fixes.
f230ecc9 6245
4d09bcf6
PE
62462011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6247
6248 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6249 Do not assume that spare memory exists; that assumption is valid
6250 only if SYSTEM_MALLOC.
6251 (LARGE_REQUEST): New macro, so that the issue of large requests
6252 is separated from the issue of spare memory.
6253
810928a2
AS
62542011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6255
172418ad
AS
6256 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6257 format. (Bug#8806)
6258
43f862f7
AS
6259 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6260
810928a2
AS
6261 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6262 before statements.
6263
a059fe24
JD
62642011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6265
6266 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6267
6268 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6269
6270 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6271 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6272
989bf368
JB
62732011-06-05 Juanma Barranquero <lekktu@gmail.com>
6274
6275 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6276
4b80f674
CY
62772011-06-04 Chong Yidong <cyd@stupidchicken.com>
6278
6279 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6280 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6281 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6282 New error handlers.
4b80f674
CY
6283 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6284 Obey Vx_select_enable_clipboard_manager. Catch errors in
6285 x_clipboard_manager_save (Bug#8779).
6286 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6287 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6288
99a33b77 62892011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6290
6291 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6292
99a33b77 62932011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6294
6295 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6296 in the current matrix if keep_current_p is non-zero.
6297
8264569d
EZ
62982011-06-04 Eli Zaretskii <eliz@gnu.org>
6299
6300 * bidi.c (bidi_level_of_next_char): Fix last change.
6301
57f97249
EZ
63022011-06-03 Eli Zaretskii <eliz@gnu.org>
6303
fec2107c 6304 Support bidi reordering of text covered by display properties.
57f97249 6305
fec2107c
EZ
6306 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6307 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6308 (bidi_cache_search, bidi_cache_iterator_state)
6309 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6310 (bidi_level_of_next_char, bidi_move_to_visually_next):
6311 Support character positions inside a run of characters covered by a
fec2107c
EZ
6312 display string.
6313 (bidi_paragraph_init, bidi_resolve_explicit_1)
6314 (bidi_level_of_next_char): Call bidi_fetch_char and
6315 bidi_fetch_char_advance instead of FETCH_CHAR and
6316 FETCH_CHAR_ADVANCE.
6317 (bidi_init_it): Initialize new members.
6318 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6319 definitions.
6320 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6321 instead of using explicit *_CHAR codes.
d6d100dd
SM
6322 (bidi_resolve_explicit, bidi_resolve_weak):
6323 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6324 bidirectional text is supported only in multibyte buffers.
6325 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6326 it to initialize the frame_window_p member of struct bidi_it.
6327 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6328 (bidi_resolve_explicit, bidi_resolve_weak)
6329 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6330 bidi_it->nchars is non-positive.
6331 (bidi_level_of_next_char): Don't try to lookup the cache for the
6332 next/previous character if nothing is cached there yet, or if we
6333 were just reseat()'ed to a new position.
c40e2fb2 6334
0e14fe90
EZ
6335 * xdisp.c (set_cursor_from_row): Set start and stop points
6336 according to the row's direction when priming the loop that looks
6337 for the glyph on which to display cursor.
6338 (single_display_spec_intangible_p): Function deleted.
6339 (display_prop_intangible_p): Reimplement to call
6340 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6341 Accept 3 additional arguments needed by handle_display_spec.
6342 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6343 values: lists, `(when COND...)' forms, etc.
6344 (single_display_spec_string_p): Support property values that are
6345 lists with the argument STRING its top-level element.
6346 (display_prop_string_p): Fix the condition for processing a
6347 property that is a list to be consistent with handle_display_spec.
fec2107c 6348 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6349 last portion of handle_display_prop.
6350 (compute_display_string_pos): Accept additional argument
6351 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6352 value of a `display' property is a "replacing spec".
6353 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6354 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6355 the display property, but just return a value indicating whether
6356 the display property will replace the characters it covers.
6357 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6358 frame_window_p members of struct bidi_it.
d6d100dd
SM
6359 (compute_display_string_pos, compute_display_string_end):
6360 New functions.
fec2107c
EZ
6361 (push_it): Accept second argument POSITION, where pop_it should
6362 jump to continue iteration.
6363 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6364
fec2107c
EZ
6365 * keyboard.c (adjust_point_for_property): Adjust the call to
6366 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6367
6368 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6369 (bidi_init_it): Update prototypes.
6370 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6371 (compute_display_string_pos, compute_display_string_end):
6372 Declare prototypes.
fec2107c
EZ
6373 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6374 EMACS_INT.
fc6f18ce 6375
40087514 63762011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6377
57f53182
PE
6378 Malloc failure behavior now depends on size of allocation.
6379 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6380 * lisp.h: Change signatures accordingly.
6381 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6382 All callers changed. (Bug#8762)
6383
6384 * gnutls.c: Use Emacs's memory allocators.
6385 Without this change, the gnutls library would invoke malloc etc.
6386 directly, which causes problems on non-SYNC_INPUT hosts, and which
6387 runs afoul of improving memory_full behavior. (Bug#8761)
6388 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6389 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6390 xfree instead of the default malloc, realloc, free.
6391 (Fgnutls_boot): No need to check for memory allocation failure,
6392 since xmalloc does that for us.
6393
ac32cd99 6394 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6395 * category.c (hash_get_category_set):
6396 * ccl.c (ccl_driver):
6397 * charset.c (Fdefine_charset_internal):
6398 * charset.h (struct charset.hash_index):
6399 * composite.c (get_composition_id, gstring_lookup_cache)
6400 (composition_gstring_put_cache):
6401 * composite.h (struct composition.hash_index):
6402 * dispextern.h (struct image.hash):
6403 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6404 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6405 (hashfn_equal, hashfn_user_defined, make_hash_table)
6406 (maybe_resize_hash_table, hash_lookup, hash_put)
6407 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6408 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6409 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6410 * image.c (make_image, search_image_cache, lookup_image)
6411 (xpm_put_color_table_h):
6412 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6413 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6414 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6415 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6416 * alloc.c (allocate_vectorlike):
6417 Check for overflow in vector size calculations.
6418 * ccl.c (ccl_driver):
6419 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6420 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6421 need to be updated by these changes.
40087514
PE
6422 * fns.c (make_hash_table, maybe_resize_hash_table):
6423 Check for integer overflow with large hash tables.
0de4bb68
PE
6424 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6425 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6426 (SXHASH_REDUCE): New macro.
6427 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6428 Use it instead of discarding useful hash info with large hash values.
6429 (sxhash_float): New function.
6430 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6431 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6432 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6433 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6434 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6435 Adjust signatures to match updated version of code.
6436 (consing_since_gc): Now EMACS_INT, since a single hash table can
6437 use more than INT_MAX bytes.
6438
698d32e2
DN
64392011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6440
6441 Make it possible to build with GCC-4.6+ -O2 -flto.
6442
6443 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6444
fd6fa53f
SM
64452011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6446
6447 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6448 Call minibuffer-inactive-mode.
6449
864db017
JB
64502011-05-31 Juanma Barranquero <lekktu@gmail.com>
6451
6452 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6453 Update dependencies.
6454
2ad0baf4
DN
64552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6456
6457 * data.c (init_data): Remove code for UTS, this system is not
6458 supported anymore.
6459
4fcc2638
DN
64602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6461
6462 Don't force ./temacs to start in terminal mode.
6463
6464 * frame.c (make_initial_frame): Initialize faces in all cases, not
6465 only when CANNOT_DUMP is defined.
6466 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6467
c56e0fd5
DN
64682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6469
6470 * dispnew.c (add_window_display_history): Use const for the string
6471 pointer. Remove declaration, not needed.
6472
333d54da 64732011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6474
55d4c1b2 6475 Use 'inline', not 'INLINE'.
333d54da 6476 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6477 * alloc.c, fontset.c (INLINE): Remove.
6478 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6479 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6480 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6481 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6482 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6483
738db178
DN
64842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6485
6486 Make it possible to run ./temacs.
6487
6488 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6489 syms_of_callproc does the same thing. Remove test for
6490 "initialized", do it in the caller.
6491 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6492
620c53a6
SM
64932011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6494
6495 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6496 (read_minibuf): Use get_minibuffer.
6497 (syms_of_minibuf): Use DEFSYM.
6498 (Qmetadata): New var.
6499 * data.c (Qbuffer): Don't make it static.
6500 (syms_of_data): Use DEFSYM.
6501
e003a292
PE
65022011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6503
6504 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6505 (CCL_CODE_MIN): New macro.
6506
ed008a6d
PE
65072011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6508
3687c2ef
PE
6509 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6510
ed008a6d
PE
6511 * eval.c (Qdebug): Now static.
6512 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6513 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6514 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6515
d66c4c7c
CY
65162011-05-29 Chong Yidong <cyd@stupidchicken.com>
6517
6518 * image.c: Various fixes to ImageMagick code comments.
6519 (Fimagemagick_types): Doc fix.
6520
5fbc2025
PE
65212011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6522
0196f88a
PE
6523 Minor fixes prompted by GCC 4.6.0 warnings.
6524
6525 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6526
5fbc2025
PE
6527 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6528 (x_clipboard_manager_save_all): Move extern decl to ...
6529 * xterm.h: ... here, so that it can be checked for consistency.
6530
1dd3c2d9
CY
65312011-05-29 Chong Yidong <cyd@stupidchicken.com>
6532
6533 * xselect.c (x_clipboard_manager_save_frame)
6534 (x_clipboard_manager_save_all): New functions.
6535 (Fx_clipboard_manager_save): Lisp function deleted.
6536
6537 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6538 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6539
6540 * xterm.h: Update prototype.
6541
5ba6571d
WX
65422011-05-28 William Xu <william.xwl@gmail.com>
6543
6544 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6545 exiting (Bug#8239).
6546
3eaff834
JM
65472011-05-28 Jim Meyering <meyering@redhat.com>
6548
e1900994 6549 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6550 * fns.c (to_uchar): Define.
6551 (crypto_hash_function): Use it to convert some newly-signed
6552 variables to unsigned, to avoid sign-extension bugs. For example,
6553 without this change, (md5 "truc") would evaluate to
6554 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6555 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6556 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6557
0f6990a7
PE
65582011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6559
6560 Integer overflow fixes.
c8a9ca5a 6561
08686060
PE
6562 * dbusbind.c: Serial number integer overflow fixes.
6563 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6564 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6565 to hold a serial number that is too large for a fixnum.
6566 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6567 Check for serial numbers out of range. Decode any serial number
59568bf0 6568 that was so large that it became a float. (Bug#8722)
08686060 6569
2d1fc3c7
PE
6570 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6571 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6572 Use XFASTINT rather than XUINT when numbers are nonnegative.
6573 (xd_append_arg, Fdbus_method_return_internal):
6574 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6575 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6576 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6577 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6578 (Bug#8722)
2d1fc3c7 6579
c8a9ca5a
PE
6580 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6581
519e1d69
PE
6582 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6583
6df6ae42 6584 ccl: Add integer overflow checks.
30569699
PE
6585 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6586 (IN_INT_RANGE): New macros.
6587 (ccl_driver): Use them to check for integer overflow when
6588 decoding a CCL program. Many of the new checks are whether XINT (x)
6589 fits in int; it doesn't always, on 64-bit hosts. The new version
6590 doesn't catch all possible integer overflows, but it's an
847044ea 6591 improvement. (Bug#8719)
30569699 6592
c11285dc
PE
6593 * alloc.c (make_event_array): Use XINT, not XUINT.
6594 There's no need for unsigned here.
6595
fdccd48e
PE
6596 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6597 This follows up to the 2011-05-06 change that substituted uintptr_t
6598 for EMACS_INT. This case wasn't caught back then.
6599
37910ab2
PE
6600 Rework Fformat to avoid integer overflow issues.
6601 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6602 now (part of C89). Include <verify.h>.
6603 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6604 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6605 (Fformat): Avoid the prepass trying to compute sizes; it was only
6606 approximate and thus did not catch overflow reliably. Instead, walk
6607 through the format just once, formatting and computing sizes as we go,
6608 checking for integer overflow at every step, and allocating a larger
6609 buffer as needed. Keep track separately whether the format is
6610 multibyte. Keep only the most-recently calculated precision, rather
6611 than them all. Record whether each argument has been converted to
6612 string. Use EMACS_INT, not int, for byte and char and arg counts.
6613 Support field widths and precisions larger than INT_MAX. Avoid
6614 sprintf's undefined behavior with conversion specifications such as %#d
6615 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6616 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6617 formatting out-of-range floating point numbers with int
9173deec 6618 formats. (Bug#8668)
37910ab2 6619
2e6578fb
PE
6620 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6621
0ae6bdee
PE
6622 * data.c: Avoid integer truncation in expressions involving floats.
6623 * data.c: Include <intprops.h>.
6624 (arith_driver): When there's an integer overflow in an expression
6625 involving floating point, convert the integers to floating point
6626 so that the resulting value does not suffer from catastrophic
6627 integer truncation. For example, on a 64-bit host (* 4
6628 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6629 Do not rely on undefined behavior after integer overflow.
6630
de883a70
PE
6631 merge count_size_as_multibyte, parse_str_to_multibyte
6632 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6633 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6634 Check for integer overflow.
6635 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6636 since it's now a duplicate of the other. This is more of
6637 a character than a buffer op, so better that it's in character.c.
6638 * fns.c, print.c: Adjust to above changes.
6639
2ff916cb
PE
66402011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6641
6642 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6643
f1b54466
PE
66442011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6645
fb1ac845
PE
6646 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6647 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6648 (x_clipboard_manager_save): Now static.
6649 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6650
f1b54466
PE
6651 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6652 (crypto_hash_function): Now static.
6653 Fix pointer signedness problems. Avoid unnecessary initializations.
6654
a9f737ee
CY
66552011-05-27 Chong Yidong <cyd@stupidchicken.com>
6656
6657 * termhooks.h (Vselection_alist): Make it terminal-local.
6658
6659 * terminal.c (create_terminal): Initialize it.
6660
6661 * xselect.c: Support for clipboard managers.
6662 (Vselection_alist): Move to termhooks.h as terminal-local var.
6663 (LOCAL_SELECTION): New macro.
6664 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6665 (symbol_to_x_atom): Remove gratuitous arg.
6666 (x_handle_selection_request, lisp_data_to_selection_data)
6667 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6668 (x_own_selection, x_get_local_selection, x_convert_selection):
6669 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6670 (some_frame_on_display): Delete unused function.
6671 (Fx_own_selection_internal, Fx_get_selection_internal)
6672 (Fx_disown_selection_internal, Fx_selection_owner_p)
6673 (Fx_selection_exists_p): New optional frame arg.
6674 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6675 (x_handle_selection_clear): Don't treat other terminals with the
6676 same keyboard specially. Use the terminal-local Vselection_alist.
6677 (x_clear_frame_selections): Use Frun_hook_with_args.
6678
6679 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6680
6681 * xterm.h: Add support for those atoms.
6682
e067f0c1
CY
66832011-05-26 Chong Yidong <cyd@stupidchicken.com>
6684
6685 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6686 (converted_selections, conversion_fail_tag): New global variables.
6687 (x_selection_request_lisp_error): Free the above.
6688 (x_get_local_selection): Remove unnecessary code.
6689 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6690 of converted selections stored in converted_selections.
6691 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6692 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6693 (x_convert_selection): New function.
6694 (x_handle_selection_event): Simplify.
6695 (x_get_foreign_selection): Don't ignore incoming requests while
6696 waiting for an answer; this will fail when we implement
6697 SAVE_TARGETS, and seems unnecessary anyway.
6698 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6699 (Vx_sent_selection_functions): Doc fix.
6700
0f4aebc0
LL
67012011-05-26 Leo Liu <sdl.web@gmail.com>
6702
6703 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6704
e61124cd
YM
67052011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6706
6707 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6708
6709 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6710 for fringe update if it has periodic bitmap.
ac389d0c 6711 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6712 and fringe_bitmap_periodic_p.
6713
6714 * fringe.c (get_fringe_bitmap_data): New function.
6715 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6716 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6717 row. Mark glyph row for fringe update if periodicity changed.
6718
6719 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6720 for fringe update unless it has periodic bitmap.
6721
f16d9837
KH
67222011-05-25 Kenichi Handa <handa@m17n.org>
6723
6724 * xdisp.c (get_next_display_element): Set correct it->face_id for
6725 a static composition.
6726
e1b90ef6
LL
67272011-05-24 Leo Liu <sdl.web@gmail.com>
6728
6729 * deps.mk (fns.o):
6730 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6731
6732 * fns.c (crypto_hash_function, Fsha1): New function.
6733 (Fmd5): Use crypto_hash_function.
6734 (syms_of_fns): Add Ssha1.
6735
7400048f
PE
67362011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6737
6738 * gnutls.c: Remove unused macros.
6739 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6740 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6741 Remove macros that are defined and never used.
6742 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6743
abb71cf4
CY
67442011-05-22 Chong Yidong <cyd@stupidchicken.com>
6745
6746 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6747 (Fx_get_selection_internal): Minor cleanup.
6748 (Fx_own_selection_internal): Rename arguments for consistency with
6749 select.el.
6750
6307db39
PE
67512011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6752
6753 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6754
f3d4e0a4
CY
67552011-05-22 Chong Yidong <cyd@stupidchicken.com>
6756
6757 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6758
4d8ade89
YM
67592011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6760
6761 * dispnew.c (scrolling_window): Don't exclude the case that the
6762 last enabled row in the desired matrix touches the bottom boundary.
6763
32078c8d
GM
67642011-05-21 Glenn Morris <rgm@gnu.org>
6765
6766 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6767 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6768 and add some more files.
32078c8d 6769
7285dc67
EZ
67702011-05-20 Eli Zaretskii <eliz@gnu.org>
6771
6772 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6773 report_file_error introduced by the change from 2011-05-07.
6774
89d1bd22
PE
67752011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6776
6777 * systime.h (Time): Define only if emacs is defined.
6778 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6779 where the include path doesn't have X11/X.h by default. See
6780 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6781
cd394be1 67822011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6783
6784 * composite.c (find_automatic_composition): Fix previous change.
6785
b9704ad9
GM
67862011-05-20 Glenn Morris <rgm@gnu.org>
6787
6788 * lisp.mk: New file, split from Makefile.in.
6789 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6790 (shortlisp): Remove.
6791 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6792
4a720484
GM
67932011-05-19 Glenn Morris <rgm@gnu.org>
6794
6795 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6796 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6797 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6798 (lisp): Set the order to that of loadup.el.
6799 (shortlisp): Make it a copy of $lisp.
6800 (SOME_MACHINE_LISP): Remove.
6801 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6802 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6803
a28d4396
KH
68042011-05-18 Kenichi Handa <handa@m17n.org>
6805
6806 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6807 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6808 (find_automatic_composition): Mostly rewrite for efficiency.
6809
a2b1fa8e
JB
68102011-05-18 Juanma Barranquero <lekktu@gmail.com>
6811
6812 * makefile.w32-in: Update dependencies.
6813
8e1f5610
CS
68142011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6815
6816 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6817 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6818
7025ee00 68192011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6820
cdfa6eab
PE
6821 Fix some integer overflow issues, such as string length overflow.
6822
06d6db33
PE
6823 * insdel.c (count_size_as_multibyte): Check for string overflow.
6824
2b4560a8
PE
6825 * character.c (lisp_string_width): Check for string overflow.
6826 Use EMACS_INT, not int, for string indexes and lengths; in
6827 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6828 the resulting string length overflows an EMACS_INT; instead,
6829 report a string overflow if no precision given. When checking for
6830 precision exhaustion, use a check that cannot possibly have
6831 integer overflow. (Bug#8675)
6832 * character.h (lisp_string_width): Adjust to new signature.
6833
cb93f9be
PE
6834 * alloc.c (string_overflow): New function.
6835 (Fmake_string): Use it. This doesn't change behavior, but saves
6836 a few bytes and will simplify future changes.
6837 * character.c (string_escape_byte8): Likewise.
6838 * lisp.h (string_overflow): New decl.
6839
1a1f3366
PE
6840 Fixups, following up to the user-interface timestamp change.
6841 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6842 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6843 * msdos.c (mouse_get_pos): Likewise.
6844 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6845 * w32gui.h (Time): Define by including "systime.h" rather than by
6846 declaring it ourselves. (Bug#8664)
6847
d4e3e4d3
PE
6848 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6849 * image.c (clear_image_cache): Likewise.
6850
f6a24d19
PE
6851 * term.c (term_mouse_position): Don't assume time_t wraparound.
6852
08dc5ae6
PE
6853 Be more systematic about user-interface timestamps.
6854 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6855 and sometimes 'EMACS_UINT', to represent these timestamps.
6856 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6857 This makes the code easier to follow, and makes it easier to catch
6858 integer overflow bugs such as Bug#8664.
6859 * frame.c (Fmouse_position, Fmouse_pixel_position):
6860 Use Time, not unsigned long, for user-interface timestamps.
6861 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6862 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6863 * keyboard.h (last_event_timestamp): Likewise.
6864 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6865 * menu.h (xmenu_show): Likewise.
6866 * term.c (term_mouse_position): Likewise.
6867 * termhooks.h (struct input_event.timestamp): Likewise.
6868 (struct terminal.mouse_position_hook): Likewise.
6869 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6870 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6871 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6872 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6873 what it was before.
6874 * menu.h, termhooks.h: Include "systime.h", for Time.
6875
8e55734a
PE
6876 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6877 Don't assume that the difference between two unsigned long values
6878 can fit into an integer. At this point, we know button_down_time
6879 <= event->timestamp, so the difference must be nonnegative, so
6880 there's no need to cast the result if double-click-time is
6881 nonnegative, as it should be; check that it's nonnegative, just in
6882 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6883 apart (about 25 days). (Bug#8664)
8e55734a 6884
841f1b75 6885 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6886 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6887
3e26f69c
PE
6888 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6889 that always fit in int. Use a sentinel instead of a counter, to
6890 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6891 * frame.h (struct frame): Use int for menu_bar_items_used
6892 instead of EMACS_INT, since it always fits in int.
3e26f69c 6893
5cc152c0
PE
6894 * menu.c (grow_menu_items): Check for int overflow.
6895
d89eb65e
PE
6896 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6897
5235bd3e
PE
6898 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6899 Before, the code was not consistent. These values cannot exceed
6900 2**31 - 1 so there's no need to make them unsigned.
6901 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6902 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6903 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6904 as modifiers.
6905 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6906
bc827e23
PE
6907 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6908 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6909 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6910 presumably because the widths might not match.
6911
78eb494e
PE
6912 * window.c (size_window): Avoid needless test at loop start.
6913
04f2d78b
CB
69142011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6915
6916 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6917
d2fc7e3d 69182011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6919
6920 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6921
d2fc7e3d 69222011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6923
6924 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6925 `width' to `bar_area_x' and `bar_area_width', respectively.
6926 (x_scroll_run): Take account of fringe background extension.
6927
04f2d78b
CB
6928 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6929 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6930 `bar_area_width', respectively.
6931 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6932 background extension.
6933
79b70037
GM
69342011-05-10 Jim Meyering <meyering@redhat.com>
6935
6936 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6937
2f142cc5
JB
69382011-05-10 Juanma Barranquero <lekktu@gmail.com>
6939
6940 * image.c (Finit_image_library): Return t for built-in image types,
6941 like pbm and xbm. (Bug#8640)
6942
57679c86
AS
69432011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6944
6945 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6946
888c9e86
EZ
69472011-05-07 Eli Zaretskii <eliz@gnu.org>
6948
b0512a1d
EZ
6949 * w32console.c (Fset_screen_color): Doc fix.
6950 (Fget_screen_color): New function.
6951 (syms_of_ntterm): Defsubr it.
6952
7285dc67
EZ
6953 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6954 unlink the temporary file if Fcall_process didn't create it in the
6955 first place.
6956 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6957 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6958 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6959 cue to call_process_cleanup not to close that handle.
6960
4d3fcc8e
BK
69612011-05-07 Ben Key <bkey76@gmail.com>
6962
6963 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6964 one of two shell specific rules, either bootstrap-temacs-CMD or
6965 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6966 to the previous implementation of the bootstrap-temacs rule.
6967 The bootstrap-temacs-CMD rule is similar to the previous
6968 implementation of the bootstrap-temacs rule except that it
6969 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6970 variable.
6971
6972 These changes, along with some changes to nt/configure.bat,
6973 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6974 earlier fix to add support for --cflags and --ldflags options
6975 that include quotes so that it works whether make uses cmd or
6976 sh as the shell.
6977
b4289b64
MA
69782011-05-06 Michael Albinus <michael.albinus@gmx.de>
6979
6980 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6981 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6982 is a constant.
6983 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6984 a string. Handle both cases.
6985 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6986 (Fdbus_register_method): Use Qinvalid_function.
6987
af4c0e28
JB
69882011-05-06 Juanma Barranquero <lekktu@gmail.com>
6989
6990 * makefile.w32-in: Update dependencies.
6991 (LISP_H): Add inttypes.h and stdin.h.
6992 (PROCESS_H): Add unistd.h.
6993
c51453d9
EZ
69942011-05-06 Eli Zaretskii <eliz@gnu.org>
6995
6996 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6997 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6998
8ff0ac3c 69992011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 7000
4c4b566b
PE
7001 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7002
aab2b9b5
PE
7003 * term.c (vfatal): Remove stray call to va_end.
7004 It's not needed and the C Standard doesn't allow it here anyway.
7005
c378da0b
PE
7006 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7007 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7008
288b08c7
PE
7009 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7010 bytes.
7011
e3601888
PE
7012 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7013
db6c0e74
PE
7014 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7015
dd5963ea
PE
7016 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7017
88c9450f
PE
7018 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7019
2f9442b8
PE
7020 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7021
c032b5f8
PE
7022 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7023 * charset.c (Fdefine_charset_internal): Don't initialize
7024 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 7025 32-bit int (Bug#8600).
a108c10b
PE
7026
7027 * lread.c (read_integer): Be more consistent with string-to-number.
7028 Use string_to_number to do the actual conversion; this avoids
7029 rounding errors and fixes some other screwups. Without this fix,
7030 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7031 (digit_to_number): Move earlier, for benefit of read_integer.
7032 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 7033 not a digit in any supported base. (Bug#8602)
a108c10b 7034
ad5f9eea
PE
7035 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7036
aec1708a
PE
7037 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7038 to match comment at start of function. This also removes a
7039 GCC warning about overflow in a 32+64-bit port.
7040
47be4ab5
PE
7041 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7042
371cac43
PE
7043 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7044 Reported by Stefan Monnier in
7045 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
7046 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7047 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 7048
d01a7826
PE
7049 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7050 (EMACS_UINTPTR): Likewise, with uintptr_t.
7051
7fd47d5c
PE
7052 * lisp.h: Prefer 64-bit EMACS_INT if available.
7053 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7054 on 32-bit hosts that have 64-bit int, so that they can access
7055 large files.
122b0c86
PE
7056 However, temporarily disable this change unless the temporary
7057 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7058
8727937b
PE
7059 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7060
8ac068ac
PE
7061 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7062 This removes an assumption that EMACS_INT and long are the same
7063 width as pointers. The assumption is true for Emacs porting targets
7064 now, but we want to make other targets possible.
7065 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7066 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7067 In the rest of the code, change types of integers that hold casted
7068 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7069 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7070 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7071 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7072 No need to cast type when ORing.
7073 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7074 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7075 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7076 assume EMACS_INT is the same width as char *.
7077 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7078 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7079 Remove no-longer-needed casts.
7080 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7081 (xg_tool_bar_help_callback, xg_make_tool_item):
7082 Use EMACS_INTPTR to hold an integer
7083 that will be cast to void *; this can avoid a GCC warning
7084 if EMACS_INT is not the same width as void *.
7085 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7086 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7087 (current_message_1, set_message_1):
7088 Use a local to convert to proper width without a cast.
7089 * xmenu.c (dialog_selection_callback): Likewise.
7090
ede49d71
PE
7091 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7092 Also, don't assume VALBITS / RAND_BITS is less than 5,
7093 and don't rely on undefined behavior when shifting a 1 left into
7094 the sign bit.
7095 * lisp.h (get_random): Change signature to match.
7096
2f30ecd0
PE
7097 * lread.c (hash_string): Use size_t, not int, for hash computation.
7098 Normally we prefer signed values; but hashing is special, because
7099 it's better to use unsigned division on hash table sizes so that
7100 the remainder is nonnegative. Also, size_t is the natural width
7101 for hashing into memory. The previous code used 'int', which doesn't
7102 retain enough info to hash well into very large tables.
7103 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7104
2a866e7b
PE
7105 * dbusbind.c: Don't possibly lose pointer info when converting.
7106 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7107 Use XPNTR rather than XHASH, so that the high-order bits of
7108 the pointer aren't lost when converting through void *.
7109
51639eac
PE
7110 * eval.c (Fautoload): Don't double-shift a pointer.
7111
92394119
PE
7112 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7113
dbdb9a7c
JB
71142011-05-06 Juanma Barranquero <lekktu@gmail.com>
7115
7116 * gnutls.c (DEF_GNUTLS_FN):
7117 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7118
db7a0b4f
AS
71192011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7120
7121 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7122 marker. (Bug#8610)
7123
cd394be1 71242011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7125
7126 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7127 New version that can reserve upto 2GB of heap space.
7128
f7ff1b0f 71292011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7130
7131 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7132
639c109b
TZ
71332011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7134
7135 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7136 `gnutls_certificate_set_x509_key_file'.
7137
d2127135
JB
71382011-05-05 Juanma Barranquero <lekktu@gmail.com>
7139
7140 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7141 Update dependencies.
7142
e968f4f3
JB
71432011-05-04 Juanma Barranquero <lekktu@gmail.com>
7144
7145 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7146 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7147 Remove unused parameter `fildes'.
7148 * process.c (read_process_output, send_process): Don't pass it.
7149
84d358f0
JB
71502011-05-04 Juanma Barranquero <lekktu@gmail.com>
7151
7152 Fix previous change: the library cache is defined in w32.c.
7153 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7154 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7155
0898ca10
JB
71562011-05-04 Juanma Barranquero <lekktu@gmail.com>
7157
7158 Implement dynamic loading of GnuTLS on Windows.
7159
7160 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7161 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7162 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7163 Declare.
7164
7165 * gnutls.c (Qgnutls_dll): Define.
7166 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7167 (gnutls_*): Declare function pointers.
7168 (init_gnutls_functions): New function to initialize function pointers.
7169 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7170 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7171 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7172 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7173 (emacs_gnutls_write, emacs_gnutls_read)
7174 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7175 (Fgnutls_available_p): New function.
7176 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7177 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7178 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7179
7180 * image.c: Include w32.h.
7181 (Vimage_type_cache): Delete.
7182 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7183 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7184 (w32_delayed_load): Move to w32.c.
7185
7186 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7187
7188 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7189 (w32_delayed_load): Move from image.c. When loading a library, record
7190 its filename in the :loaded-from property of the library id.
7191 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7192 Initialize and staticpro them.
7193 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7194
7195 * process.c: Include lisp.h before w32.h, not after.
7196 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7197 instead of gnutls_record_check_pending.
7198
7199 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7200
ff4de4aa
TZ
72012011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7202
7203 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7204 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7205 as passed in.
7206
abe95abb
JD
72072011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7208
7209 * xterm.c (x_set_frame_alpha): Do not set property on anything
7210 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7211
e16e55d4
JB
72122011-05-02 Juanma Barranquero <lekktu@gmail.com>
7213
7214 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7215
bafcf6a5
JB
72162011-05-02 Juanma Barranquero <lekktu@gmail.com>
7217
7218 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7219 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7220 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7221 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7222 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7223 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7224 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7225 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7226 (Qgnutls_bootprop_callbacks_verify): Make static.
7227
e7a6747f
AS
72282011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7229
19ed11ba
AS
7230 * callproc.c: Indentation fixup.
7231
e7a6747f 7232 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7233 (wait_for_termination, interruptible_wait_for_termination):
7234 Move after wait_for_termination_1.
e7a6747f 7235
1ef14cb4
LMI
72362011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7237
7238 * sysdep.c (interruptible_wait_for_termination): New function
7239 which is like wait_for_termination, but allows keyboard
7240 interruptions.
7241
7242 * callproc.c (Fcall_process): Add (:file "file") as an option for
7243 the STDOUT buffer.
7244 (Fcall_process_region): Ditto.
7245
330d880c
EZ
72462011-04-30 Eli Zaretskii <eliz@gnu.org>
7247
8db90b73
EZ
7248 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7249 rather than `XVECTOR (FOO)->size'.
7250
330d880c
EZ
7251 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7252 inttypes.h, as a gnulib replacement is used if it not available in
7253 system headers.
7254
15cbd324
EZ
72552011-04-21 Eli Zaretskii <eliz@gnu.org>
7256
7257 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7258 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7259 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7260
7261 * coding.c (coding_alloc_by_realloc): Error out if destination
7262 will grow beyond MOST_POSITIVE_FIXNUM.
7263 (decode_coding_emacs_mule): Abort if there isn't enough place in
7264 charbuf for the composition carryover bytes. Reserve an extra
7265 space for up to 2 characters produced in a loop.
7266 (decode_coding_iso_2022): Abort if there isn't enough place in
7267 charbuf for the composition carryover bytes.
7268
72692011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7270
ae940cca
EZ
7271 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7272 aborting when %lld or %lll format is passed.
7273 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7274 %llo or %llx format is passed. (Bug#8545)
7275
03ab8921
EZ
7276 * window.c (window_scroll_line_based): Use a marker instead of
7277 simple variables to record original value of point. (Bug#7952)
7278
afda1437
EZ
7279 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7280 produced by %s or %c overflows available buffer space. (Bug#8545)
7281
f76dee0c
PE
72822011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7283
7284 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7285 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7286
fdc5744d
JB
72872011-04-28 Juanma Barranquero <lekktu@gmail.com>
7288
7289 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7290
638f053a
JB
72912011-04-28 Juanma Barranquero <lekktu@gmail.com>
7292
7293 * keyboard.c (Qdelayed_warnings_hook): Define.
7294 (command_loop_1): Run `delayed-warnings-hook'
7295 if Vdelayed_warnings_list is non-nil.
7296 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7297 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7298
d178f871
EZ
72992011-04-28 Eli Zaretskii <eliz@gnu.org>
7300
7301 * doprnt.c (doprnt): Don't return value smaller than the buffer
7302 size if the message was truncated. (Bug#8545).
7303
b124fd93
JB
73042011-04-28 Juanma Barranquero <lekktu@gmail.com>
7305
7306 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7307 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7308
e810457d
PE
73092011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7310
7311 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7312
ea51cceb
JB
73132011-04-27 Juanma Barranquero <lekktu@gmail.com>
7314
7315 * makefile.w32-in: Update dependencies.
7316
94dcfacf
EZ
73172011-04-27 Eli Zaretskii <eliz@gnu.org>
7318
7319 Improve `doprnt' and its usage. (Bug#8545)
7320 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7321 `format_end'. Remove support for %l as a conversion specifier.
7322 Don't use xrealloc. Improve diagnostics when the %l size modifier
7323 is used. Update the commentary.
7324
7325 * eval.c (verror): Simplify calculation of size_t.
7326
7327 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7328 messages.
7329
f61f41d7
PE
73302011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7331
7332 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7333 change.
7334
96fb4434
PE
73352011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7336
7337 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7338 This makes this file independent of the recent pseudovector change.
7339
671875da 73402011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7341
69e9b5a3
PE
7342 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7343
b5f869a7 7344 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7345 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7346 Remove unused local.
c8926152 7347 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7348
841a1577 7349 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7350 GCC 4.6.0 optimizes based on type-based alias analysis.
7351 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7352 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7353 != &v->size, and therefore "v->size = 1; b->size = 2; return
7354 v->size;" must therefore return 1. This assumption is incorrect
7355 for Emacs, since it type-puns struct Lisp_Vector * with many other
7356 types. To fix this problem, this patch adds a new type struct
f904488f 7357 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7358 and pseudovectors, and helps optimizing compilers not get fooled
7359 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7360 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7361 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7362 the size member.
eab3844f
PE
7363 (XSETPVECTYPE): Rewrite in terms of new macro.
7364 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7365 This is a bit clearer, and further avoids the possibility of
7366 undesirable aliasing.
7367 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7368 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7369 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7370 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7371 (ASIZE): Now uses header.size rather than size.
7372 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7373 to avoid the hassle of writing XVECTOR (foo)->header.size.
7374 (struct vectorlike_header): New type.
eab3844f
PE
7375 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7376 object, to help avoid aliasing.
7377 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7378 (SUBRP): Likewise, since Lisp_Subr is a special case.
7379 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7380 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7381 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7382 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7383 changed to be "header.size" and "header.next".
7384 * buffer.h (struct buffer): Likewise.
7385 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7386 * frame.h (struct frame): Likewise.
7387 * process.h (struct Lisp_Process): Likewise.
7388 * termhooks.h (struct terminal): Likewise.
7389 * window.c (struct save_window_data, struct saved_window): Likewise.
7390 * window.h (struct window): Likewise.
7391 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7392 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7393 * buffer.c (init_buffer_once): Likewise.
7394 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7395 special case.
7396 * process.c (Fformat_network_address): Use local var for size,
7397 for brevity.
7398
0df1eac5
PE
7399 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7400
847ab9d1 7401 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7402 * data.c (atof): Remove decl; no longer used or needed.
7403 (digit_to_number): Move to lread.c.
7404 (Fstring_to_number): Use new string_to_number function, to be
7405 consistent with how the Lisp reader treats infinities and NaNs.
7406 Do not assume that floating-point numbers represent EMACS_INT
7407 without losing information; this is not true on most 64-bit hosts.
7408 Avoid double-rounding errors, by insisting on integers when
7409 parsing non-base-10 numbers, as the documentation specifies.
7410 * lisp.h (string_to_number): New decl, replacing ...
7411 (isfloat_string): Remove.
bc0a5c13 7412 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7413 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7414 appears to have been a coding error. Similarly, do not accept
7415 strings like +-1e0 as floating point numbers. Do not report
7416 overflow for integer overflows unless the base is not 10 which
7417 means we have no simple and reliable way to continue.
7418 Break out the floating-point parsing into a new
7419 function string_to_number, so that Fstring_to_number parses
7420 floating point numbers consistently with the Lisp reader.
04f2d78b 7421 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7422 (E_CHAR, EXP_INT): Remove, replacing with ...
7423 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7424 (string_to_number): New function, replacing isfloat_string.
7425 This function checks for valid syntax and produces the resulting
7426 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7427 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7428 so that overflow for non-base-10 numbers is reported only when
7429 there's no portable and simple way to convert to floating point.
452f4150 7430
67769ffc
PE
7431 * textprop.c (set_text_properties_1): Rewrite for clarity,
7432 and to avoid GCC warning about integer overflow.
7433
c20db43f
PE
7434 * intervals.h (struct interval): Use EMACS_INT for members
7435 where EMACS_UINT might cause problems. See
7436 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7437 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7438 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7439 All uses changed.
37aa2f85
PE
7440 (offset_intervals): Tell GCC not to worry about length overflow
7441 when negating a negative length.
c20db43f 7442
2538aa2f
PE
7443 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7444 (overrun_check_free): Likewise.
7445
f2d3008d
PE
7446 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7447 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7448 word size.
7449
ec8df744
PE
7450 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7451 (gnutls_make_error): Rename local to avoid shadowing.
7452 (gnutls_emacs_global_deinit): ifdef out; not used.
7453 (Fgnutls_boot): Use const for pointer to readonly storage.
7454 Comment out unused local. Fix pointer signedness problems.
7455
640ee02d
PE
7456 * lread.c (openp): Don't stuff size_t into an 'int'.
7457 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7458 about possible signed overflow.
7459
6048fb2a
PE
7460 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7461 (GDK_KEY_g): Don't define if already defined.
7462 (xg_prepare_tooltip): Avoid pointer signedness problem.
7463 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7464
fa3c87e1
PE
7465 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7466 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7467
2172544b
PE
7468 * xfns.c (Fx_window_property): Simplify a bit,
7469 to make a bit faster and to avoid GCC 4.6.0 warning.
7470 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7471
9b821a21
PE
7472 * fns.c (internal_equal): Don't assume size_t fits in int.
7473
3c616cfa
PE
7474 * alloc.c (compact_small_strings): Tighten assertion a little.
7475
c2982e87
PE
7476 Replace pEd with more-general pI, and fix some printf arg casts.
7477 * lisp.h (pI): New macro, generalizing old pEd macro to other
7478 conversion specifiers. For example, use "...%"pI"d..." rather
7479 than "...%"pEd"...".
7480 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7481 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7482 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7483 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7484 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7485 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7486 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7487 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7488 64-bit hosts.
7489 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7490 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7491 * print.c (safe_debug_print, print_object): Likewise.
7492 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7493 to int.
6f04d126
PE
7494 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7495 avoiding the 0 flag, which is not portable.
c2982e87
PE
7496 * process.c (Fmake_network_process): Use pI to avoid cast.
7497 * region-cache.c (pp_cache): Likewise.
7498 * xdisp.c (decode_mode_spec): Likewise.
7499 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7500 behavior on 64-bit hosts with printf arg.
6f04d126 7501 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7502 (x_stop_queuing_selection_requests): Likewise.
7503 (x_get_window_property): Don't truncate byte count to an 'int'
7504 when tracing.
0b432f21 7505
5e073ec7
PE
7506 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7507 here, since it parses constructs like leading '-' and spaces,
7508 which are not wanted; and it overflows with large numbers.
7509 Instead, simply match F[0-9]+, which is what is wanted anyway.
7510
36372bf9
PE
7511 * alloc.c: Remove unportable assumptions about struct layout.
7512 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7513 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7514 (allocate_vectorlike, make_pure_vector): Use the new macros,
7515 plus offsetof, to remove unportable assumptions about struct layout.
7516 These assumptions hold on all porting targets that I know of, but
7517 they are not guaranteed, they're easy to remove, and removing them
7518 makes further changes easier.
7519
0b432f21
PE
7520 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7521 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7522 (string_overrun_cookie): Now const. Use initializers that
7523 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7524 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7525 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7526 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7527 multiple of sizeof (EMACS_INT); it need not be, if
7528 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7529 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7530
895009e1
JB
75312011-04-26 Juanma Barranquero <lekktu@gmail.com>
7532
7533 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7534
6a7a1b0b
TZ
75352011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7536
7537 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7538 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7539 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7540
841a1577 75412011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7542
7543 * lisp.h (Qdebug): List symbol.
895009e1 7544 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7545 * keyboard.c (debug-on-event): New variable.
7546 (handle_user_signal): Break into debugger when debug-on-event
7547 matches the current signal symbol.
7548
f2d3ba6f
DN
75492011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7550
7551 * alloc.c (check_sblock, check_string_bytes)
7552 (check_string_free_list): Convert to standard C.
7553
42ce4c63
TZ
75542011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7555
7556 * w32.c (emacs_gnutls_push): Fix typo.
7557
825cd63c
EZ
75582011-04-25 Eli Zaretskii <eliz@gnu.org>
7559
fb11d64d
EZ
7560 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7561 "cast to pointer from integer of different size".
7562
825cd63c
EZ
7563 Improve doprnt and its use in verror. (Bug#8545)
7564 * doprnt.c (doprnt): Document the set of format control sequences
7565 supported by the function. Use SAFE_ALLOCA instead of always
7566 using `alloca'.
7567
7568 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7569 is one byte too soon. Don't use xrealloc; instead xfree and
7570 xmalloc anew.
7571
e061a11b
TZ
75722011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7573
7574 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7575 callbacks stage.
7576
7577 * gnutls.c: Renamed global_initialized to
7578 gnutls_global_initialized. Added internals for the
7579 :verify-hostname-error, :verify-error, and :verify-flags
7580 parameters of `gnutls-boot' and documented those parameters in the
7581 docstring. Start callback support.
9173deec
JB
7582 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7583 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7584 on error. Return error code.
e061a11b
TZ
7585 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7586 (emacs_gnutls_read): Likewise.
7587 (Fgnutls_boot): Return handshake error code.
7588 (emacs_gnutls_handle_error): New function.
7589 (wsaerror_to_errno): Likewise.
7590
7591 * w32.h (emacs_gnutls_pull): Add prototype.
7592 (emacs_gnutls_push): Likewise.
7593
7594 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7595 (emacs_gnutls_push): Likewise.
7596
75972011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7598
7599 * process.c (wait_reading_process_output): Check if GnuTLS
7600 buffered some data internally if no FDs are set for TLS
7601 connections.
7602
7603 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7604 (LIBS): Link to USER_LIBS.
7605 ($(BLD)/gnutls.$(0)): New target.
7606
fa6996bc
EZ
76072011-04-24 Eli Zaretskii <eliz@gnu.org>
7608
eb35682e
EZ
7609 * xdisp.c (handle_single_display_spec): Rename the
7610 display_replaced_before_p argument into display_replaced_p, to
7611 make it consistent with the commentary. Fix typos in the
7612 commentary.
7613
e2ad650c
EZ
7614 * textprop.c (syms_of_textprop): Remove dead code.
7615 (copy_text_properties): Delete obsolete commentary about an
7616 interface that was deleted long ago. Fix typos in the description
7617 of arguments.
7618
1b2de274
EZ
7619 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7620 to changes in oldXMenu/XMenu.h from 2011-04-16.
7621 <menu_help_message, prev_menu_help_message>: Constify.
7622 (IT_menu_make_room): menu->help_text is now `const char **';
7623 adjust.
7624
7625 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7626 to changes in oldXMenu/XMenu.h from 2011-04-16.
7627 (struct XMenu): Declare `help_text' `const char **'.
7628
7629 * xfaces.c <Qunspecified>: Make extern again.
7630
7631 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7632 required by POSIX.
1b2de274 7633
762b15be
EZ
7634 * doc.c (get_doc_string): Improve the format passed to `error'.
7635
7636 * doprnt.c (doprnt): Improve commentary.
7637
7638 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7639
7640 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7641 them with etags.
7642
f1052e5d
EZ
7643 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7644 changes in globals.h immediately force recompilation.
762b15be
EZ
7645 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7646 $(CURDIR)/s/ms-w32.h.
7647 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7648
fa6996bc
EZ
7649 * character.c (Fchar_direction): Function deleted.
7650 (syms_of_character): Don't defsubr it.
7651 <char-direction-table>: Deleted.
7652
e6c3da20
EZ
76532011-04-23 Eli Zaretskii <eliz@gnu.org>
7654
7655 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7656 * doprnt.c: Include limits.h.
7657 (SIZE_MAX): New macro.
04f2d78b
CB
7658 (doprnt): Return a size_t value. 2nd arg is now size_t.
7659 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7660 Improve overflow protection. Support `l' modifier for integer
7661 conversions. Support %l conversion. Don't assume an EMACS_INT
7662 argument for integer conversions and for %c.
7663
7664 * lisp.h (doprnt): Restore prototype.
7665
7666 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7667 $(SRC)/character.h.
7668
7669 * Makefile.in (base_obj): Add back doprnt.o.
7670
7671 * deps.mk (doprnt.o): Add back prerequisites.
7672 (callint.o): Depend on character.h.
7673
7674 * eval.c (internal_lisp_condition_case): Include the handler
7675 representation in the error message.
7676 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7677 when breaking from the loop.
7678
7679 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7680
7681 * callint.c (Fcall_interactively): When displaying error message
7682 about invalid control letter, pass the character's codepoint, not
7683 a pointer to its multibyte form. Improve display of the character
7684 in octal and display also its hex code.
7685
7686 * character.c (char_string): Use %x to display the (unsigned)
7687 codepoint of an invalid character, to avoid displaying a bogus
7688 negative value.
7689
7690 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7691 `error', not SYMBOL_NAME itself.
7692
7693 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7694 character arguments to `error'.
7695
7696 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7697 to `error' in error message about FINAL_CHAR argument. Make sure
7698 FINAL_CHAR is a character, and use %c when it is passed as
7699 argument to `error'.
7700
4ffd0d6b 77012011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7702
7703 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7704
7705 * w32.c: Include <time.h>.
7706 (sys_localtime): New function.
7707
4ffd0d6b 77082011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7709
7710 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7711
4ffd0d6b 7712 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7713
4ffd0d6b 77142011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7715
4ffd0d6b
GM
7716 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7717 zombies (Bug#8467).
aac0c6e3 7718
04c56954
EZ
77192011-04-19 Eli Zaretskii <eliz@gnu.org>
7720
7721 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7722 gl_state.e_property when gl_state.object is Qt.
7723
7724 * insdel.c (make_gap_larger): Remove limitation of buffer size
7725 to <= INT_MAX.
7726
16a43933
CY
77272011-04-18 Chong Yidong <cyd@stupidchicken.com>
7728
7729 * xdisp.c (lookup_glyphless_char_display)
7730 (produce_glyphless_glyph): Handle cons cell entry in
7731 glyphless-char-display.
7732 (Vglyphless_char_display): Document it.
7733
7734 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7735 glyphless-char-display.
7736
4581706e
CY
77372011-04-17 Chong Yidong <cyd@stupidchicken.com>
7738
7739 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7740
7741 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7742
7743 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7744 definition for no-X builds.
7745
4887c6e2 77462011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7747
fd35b6f9
PE
7748 Static checks with GCC 4.6.0 and non-default toolkits.
7749
5c1ccb01
PE
7750 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7751
006c5daa
PE
7752 * process.c (keyboard_bit_set): Define only if SIGIO.
7753 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7754 (send_process): Repair possible setjmp clobbering.
7755
efc736d3
PE
7756 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7757
4e2fe2e6
PE
7758 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7759
f97334a2
PE
7760 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7761
4e75f29d
PE
7762 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7763 Define only if needed.
7764
90efadd1
PE
7765 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7766 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7767 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7768
3c647824
PE
7769 * dispextern.h (struct redisplay_interface): Rename param
7770 to avoid shadowing.
e264f262 7771 * termhooks.h (struct terminal): Likewise.
761383f4 7772 * xterm.c (xembed_send_message): Likewise.
3c647824 7773
b58c5c4a
PE
7774 * insdel.c (make_gap_smaller): Define only if
7775 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7776
cad59032
PE
7777 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7778 it.
7779
c339dc2e
PE
7780 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7781 so that we aren't warned about unused symbols.
7782
91a3e27b
PE
7783 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7784
399c71d3 7785 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7786
8ffc96f5
PE
7787 * xfns.c (x_real_positions): Mark locals as initialized.
7788
eef9bc79
PE
7789 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7790
098db9dd
PE
7791 * xterm.c: Fix problems found by static analysis with other toolkits.
7792 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7793 (x_dispatch_event): Declare static if USE_GTK, and
7794 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7795 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7796 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7797 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7798 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7799
eb18f6cc
PE
7800 * xmenu.c (menu_help_callback): Pointer type fixes.
7801 Use const pointers when pointing at readonly data. Avoid pointer
7802 signedness clashes.
7803 (FALSE): Remove unused macro.
7804 (update_frame_menubar): Remove unused decl.
7805
1fe72bf8
PE
7806 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7807
60d9e1db
PE
7808 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7809 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7810 (single_menu_item): Rename local to avoid shadowing.
7811
39261c26
PE
7812 * keyboard.c (make_lispy_event): Remove unused local var.
7813
018c5e19
PE
7814 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7815 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7816
63d2b86e
PE
7817 * bitmaps: Change bitmaps from unsigned char back to the X11
7818 compatible char. Avoid the old compiler warnings about
7819 out-of-range initializers by using, for example, '\xab' rather
7820 than 0xab.
7821
aefd87e1
PE
7822 * xgselect.c (xgselect_initialize): Check vs interface
7823 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7824
bf501fb9
PE
7825 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7826
e9829fdf
PE
7827 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7828 to read-only memory.
7829
1086c095
PE
7830 * fns.c (vector): Remove; this old hack is no longer needed.
7831
2baccd04 7832 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7833 Remove unused var.
dde42981 7834 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7835
72391843 7836 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7837
436c16df 7838 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7839 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7840 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7841
92bb796d 7842 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7843 (x_term_init): Remove local to avoid shadowing.
92bb796d 7844
764430a3 7845 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7846
7847 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7848 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7849
d1dfb56c
EZ
78502011-04-16 Eli Zaretskii <eliz@gnu.org>
7851
c4354cb4
EZ
7852 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7853
d1dfb56c
EZ
7854 Fix regex.c, syntax.c and friends for buffers > 2GB.
7855 * syntax.h (struct gl_state_s): Declare character position members
7856 EMACS_INT.
7857
7858 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7859
04f2d78b
CB
7860 * textprop.c (verify_interval_modification, interval_of):
7861 Declare arguments EMACS_INT.
d1dfb56c
EZ
7862
7863 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7864 EMACS_INT.
7865
7866 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7867
7868 * indent.c (Fvertical_motion): Local variable it_start is now
7869 EMACS_INT.
7870
7871 * regex.c (re_match, re_match_2, re_match_2_internal)
7872 (bcmp_translate, regcomp, regexec, print_double_string)
7873 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7874 (re_compile_pattern, re_exec): Declare arguments and local
7875 variables `size_t' and `ssize_t' and return values `regoff_t', as
7876 appropriate.
7877 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7878 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7879 <compile_stack_type>: `size' and `avail' are now `size_t'.
7880
7881 * regex.h <regoff_t>: Use ssize_t, not int.
7882 (re_search, re_search_2, re_match, re_match_2): Arguments that
7883 specify buffer/string position and length are now ssize_t and
7884 size_t. Return type is regoff_t.
7885
613052cd
BK
78862011-04-16 Ben Key <bkey76@gmail.com>
7887
7888 * nsfont.m: Fixed bugs in ns_get_family and
7889 ns_descriptor_to_entity that were caused by using free to
7890 deallocate memory blocks that were allocated by xmalloc (via
7891 xstrdup). This caused Emacs to crash when compiled with
7892 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7893 --enable-checking=xmallocoverrun). xfree is now used to
7894 deallocate these memory blocks.
7895
4170f62f 78962011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7897
71b41406
PE
7898 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7899
9587a89d
PE
7900 emacs_write: Accept and return EMACS_INT for sizes.
7901 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7902 et seq.
7903 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7904 Accept and return EMACS_INT.
7905 (emacs_gnutls_write): Return the number of bytes written on
7906 partial writes.
7907 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7908 (emacs_read, emacs_write): Remove check for negative size, as the
7909 Emacs source code has been audited now.
9587a89d
PE
7910 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7911 (emacs_read, emacs_write): Use it.
273a5f82
PE
7912 * process.c (send_process): Adjust to the new signatures of
7913 emacs_write and emacs_gnutls_write. Do not attempt to store
7914 a byte offset into an 'int'; it might overflow.
9587a89d 7915 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7916
3e047f51
PE
7917 * sound.c: Don't assume sizes fit in 'int'.
7918 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7919 Return EMACS_INT, not int.
3e047f51 7920 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7921 Accept EMACS_INT, not int.
7922 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7923 record read return values.
7924
cc39a9db
BK
79252011-04-15 Ben Key <bkey76@gmail.com>
7926
c9d0ec6d
JB
7927 * keyboard.c (Qundefined): Don't declare static since it is used
7928 in nsfns.m.
7929 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7930 static since they are used in nsfont.m.
cc39a9db 7931
6c60eb9f
SM
79322011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7933
7934 * process.c (Qprocessp): Don't declare static.
7935 * lisp.h (Qprocessp): Declare again.
7936
7990b61a
JB
79372011-04-15 Juanma Barranquero <lekktu@gmail.com>
7938
7939 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7940
5d4cb038
PE
79412011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7942
8bd7b830 7943 Improve C-level modularity by making more things 'static'.
cd64ea1d 7944
e3b27b31
PE
7945 Don't publish debugger-only interfaces to other modules.
7946 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7947 (verify_bytepos, count_markers): Move decls to the only modules
7948 that need them.
7949 * region-cache.h (pp_cache): Likewise.
7950 * window.h (check_all_windows): Likewise.
7951 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7952
5d4cb038
PE
7953 * sysdep.c (croak): Now static, if
7954 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7955 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7956
7957 * alloc.c (refill_memory_reserve): Now static if
7958 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7959 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7960
e87b6180
PE
7961 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7962 Define only if USE_LUCID.
7963
ac64929e
PE
7964 * xrdb.c (x_customization_string, x_rm_string): Now static.
7965
6f37259d
PE
7966 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7967 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7968
1683e3ab
PE
7969 * xdisp.c (draw_row_with_mouse_face): Now static.
7970 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7971
de9c2632
PE
7972 * window.h (check_all_windows): Mark externally visible.
7973
2b96acb7
PE
7974 * window.c (window_deletion_count): Now static.
7975
7976 * undo.c: Make symbols static if they're not exported.
7977 (last_undo_buffer, last_boundary_position, pending_boundary):
7978 Now static.
7979
50436f33
PE
7980 * textprop.c (interval_insert_behind_hooks): Now static.
7981 (interval_insert_in_front_hooks): Likewise.
7982
64520e5c
PE
7983 * term.c: Make symbols static if they're not exported.
7984 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7985 (max_frame_lines, tty_set_terminal_modes):
7986 (tty_reset_terminal_modes, tty_turn_off_highlight):
7987 (get_tty_terminal): Now static.
7988 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7989 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7990 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7991 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7992 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7993
1fa53021
PE
7994 * sysdep.c: Make symbols static if they're not exported.
7995 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7996 Now static.
7997 (sigprocmask_set, full_mask): Remove; unused.
7998 (wait_debugging): Mark as visible.
7999 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8000 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8001
d4b43b22
PE
8002 * syntax.c (syntax_temp): Define only if !__GNUC__.
8003
b7c513d0
PE
8004 * sound.c (current_sound_device, current_sound): Now static.
8005
989b29ad
PE
8006 * search.c (searchbufs, searchbuf_head): Now static.
8007
13a55a78
PE
8008 * scroll.c (scroll_cost): Remove; unused.
8009 * dispextern.h (scroll_cost): Remove decl.
8010
de68a1fc
PE
8011 * region-cache.h (pp_cache): Mark as externally visible.
8012
40ccffa6
PE
8013 * process.c: Make symbols static if they're not exported.
8014 (process_tick, update_tick, create_process, chan_process):
8015 (Vprocess_alist, proc_buffered_char, datagram_access):
8016 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8017 (deactivate_process): Mark defn as static, as well as decl.
8018 * lisp.h (create_process): Remove decl.
8019 * process.h (chan_process, Vprocess_alist): Remove decls.
8020
ad64fc97
PE
8021 * print.c: Make symbols static if they're not exported.
8022 (print_depth, new_backquote_output, being_printed, print_buffer):
8023 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8024 (print_interval, print_number_index, initial_stderr_stream):
8025 Now static.
8026 * lisp.h (Fprinc): Remove decl.
8027 (debug_output_compilation_hack): Mark as externally visible.
8028
adddb265
PE
8029 * sysdep.c (croak): Move decl from here to syssignal.h.
8030 * syssignal.h (croak): Put it here, so the API can be checked when
8031 'croak' is called from dissociate_if_controlling_tty.
8032
1717ede2
PE
8033 * minibuf.c: Make symbols static if they're not exported.
8034 (minibuf_save_list, choose_minibuf_frame): Now static.
8035 * lisp.h (choose_minibuf_frame): Remove decl.
8036
fa5fb2bc
PE
8037 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8038
1e3890d1
PE
8039 * lread.c: Make symbols static if they're not exported.
8040 (read_objects, initial_obarray, oblookup_last_bucket_number):
8041 Now static.
8042 (make_symbol): Remove; unused.
8043 * lisp.h (initial_obarray, make_symbol): Remove decls.
8044
8a1414fa
PE
8045 * keyboard.c: Make symbols static if they're not exported.
8046 (single_kboard, recent_keys_index, total_keys, recent_keys):
8047 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8048 (this_single_command_key_start, echoing, last_auto_save):
8049 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8050 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8051 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8052 (Vlispy_mouse_stem, double_click_count):
8053 Now static.
8054 (force_auto_save_soon): Define only if SIGDANGER.
8055 (ignore_mouse_drag_p): Now static if
8056 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8057 (print_help): Remove; unused.
8058 (stop_character, last_timer_event): Mark as externally visible.
8059 * keyboard.h (ignore_mouse_drag_p): Declare only if
8060 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8061 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8062 * lisp.h (echoing): Remove decl.
8063 (force_auto_save_soon): Declare only if SIGDANGER.
8064 * xdisp.c (redisplay_window): Simplify code, to make it more
8065 obvious that ignore_mouse_drag_p is not accessed if !defined
8066 USE_GTK && !defined HAVE_NS.
8067
93ea6e8f
PE
8068 * intervals.c: Make symbols static if they're not exported.
8069 (merge_properties_sticky, merge_interval_right, delete_interval):
8070 Now static.
8071 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8072
77382fcc
PE
8073 * insdel.c: Make symbols static if they're not exported.
8074 However, leave prepare_to_modify_buffer alone. It's never
8075 called from outside this function, but that appears to be a bug.
8076 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8077 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8078 (adjust_after_replace_noundo): Remove; unused.
8079 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8080 (signal_before_change): Remove decls.
77382fcc 8081
9306c32e
PE
8082 * indent.c (val_compute_motion, val_vmotion): Now static.
8083
cd44d2eb
PE
8084 * image.c: Make symbols static if they're not exported.
8085 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8086 if USE_GTK.
8087 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8088 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8089
ad9a7a06
PE
8090 * fringe.c (standard_bitmaps): Now static.
8091 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8092
81626931
PE
8093 * frame.c: Make symbols static if they're not exported.
8094 (x_report_frame_params, make_terminal_frame): Now static.
8095 (get_frame_param): Now static, unless HAVE_NS.
8096 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8097 (x_get_resource_string): Remove; not used.
8098 * frame.h (make_terminal_frame, x_report_frame_params):
8099 (x_get_resource_string); Remove decls.
8100 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8101 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8102
239f9db9
PE
8103 * font.c, fontset.c: Make symbols static if they're not exported.
8104 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8105 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8106 * font.c (font_close_object): Now static.
8107 * font.h (font_close_object): Remove.
8108 * fontset.c (FONTSET_OBJLIST): Remove.
8109 (free_realized_fontset) #if-0 the body, which does nothing.
8110 (face_suitable_for_char_p): #if-0, as it's never called.
8111 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8112 * xfaces.c (face_at_string_position):
8113 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8114 since 0 is always ASCII.
8115
dfcf3579
PE
8116 * fns.c (weak_hash_tables): Now static.
8117
5045092b
PE
8118 * fileio.c: Make symbols static if they're not exported.
8119 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8120 (Vwrite_region_annotation_buffers): Now static.
8121
57a96f5c
PE
8122 * eval.c: Make symbols static if they're not exported.
8123 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8124 * lisp.h (backtrace_list): Remove decl.
8125
35f08c38
PE
8126 * emacs.c: Make symbols static if they're not exported.
8127 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8128 (fatal_error_code, fatal_error_signal_hook, standard_args):
8129 Now static.
8130 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8131 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8132 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8133 * lisp.h (fatal_error_signal_hook): Remove decl.
8134 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8135
f44bd759
PE
8136 * editfns.c: Move a (normally-unused) function to its only use.
8137 * editfns.c, lisp.h (get_operating_system_release): Remove.
8138 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8139 worth the hassle of breaking this out.
8140
b532497d
PE
8141 * xterm.c: Make symbols static if they're not exported.
8142 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8143 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8144 (x_destroy_window, x_delete_display):
8145 Now static.
8146 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8147 (x_mouse_leave): Remove; unused.
8148 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8149 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8150 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8151 Remove decls.
8152 (x_mouse_leave): Declare only if WINDOWSNT.
8153 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8154 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8155 USE_X_TOOLKIT.
8156
1675728f
PE
8157 * ftxfont.c: Make symbols static if they're not exported.
8158 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8159 HAVE_FREETYPE.
8160 * font.h (ftxfont_driver): Likewise.
8161
e4cebfca
PE
8162 * xfns.c: Make symbols static if they're not exported.
8163 (x_last_font_name, x_display_info_for_name):
8164 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8165 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8166 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8167 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8168 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8169 (last_show_tip_args): Now static.
8170 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8171 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8172 (x_screen_planes): Remove; unused.
8173 * dispextern.h (x_screen_planes): Remove decl.
8174
5bf46f05
PE
8175 * dispnew.c: Make symbols static if they're not exported.
8176 * dispextern.h (redraw_garbaged_frames, scrolling):
8177 (increment_row_positions): Remove.
8178 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8179 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8180 Now static.
8181 (redraw_garbaged_frames): Remove; unused.
8182
435f4c28
PE
8183 * xfaces.c: Make symbols static if they're not exported.
8184 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8185 Remove decls.
8186 * xterm.h (defined_color): Remove decls.
8187 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8188 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8189 (menu_face_changed_default, defined_color, free_realized_face):
8190 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8191 (ascii_face_of_lisp_face): Remove; unused.
8192
8524aef3
PE
8193 * xdisp.c: Make symbols static if they're not exported.
8194 * dispextern.h (scratch_glyph_row, window_box_edges):
8195 (glyph_to_pixel_coords, set_cursor_from_row):
8196 (get_next_display_element, set_iterator_to_next):
8197 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8198 (show_mouse_face): Remove decls
8199 * frame.h (message_buf_print): Likewise.
8200 * lisp.h (pop_message, set_message, check_point_in_composition):
8201 Likewise.
8202 * xterm.h (set_vertical_scroll_bar): Likewise.
8203 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8204 (message_buf_print, scratch_glyph_row, displayed_buffer):
8205 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8206 (get_next_display_element, show_mouse_face, window_box_edges):
8207 (frame_to_window_pixel_xy, check_point_in_composition):
8208 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8209 (glyph_to_pixel_coords): Remove; unused.
8210
16390cd2
PE
8211 * dired.c (file_name_completion): Now static.
8212
8213 * dbusbind.c (xd_in_read_queued_messages): Now static.
8214
a25f4dfa
PE
8215 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8216 * data.c (circular_list_error): Remove.
8217
14a9c8df
PE
8218 * commands.h (last_point_position, last_point_position_buffer):
8219 (last_point_position_window): Remove decls.
8220 * keyboard.c: Make these variables static.
8221
04f2d78b
CB
8222 * coding.h (coding, code_convert_region, encode_coding_gap):
8223 Remove decls.
74ab6df5
PE
8224 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8225 (iso_code_class, detect_coding, code_convert_region): Now static.
8226 (encode_coding_gap): Remove; unused.
8227
38dfbee1
PE
8228 * chartab.c (chartab_chars, chartab_bits): Now static.
8229
a2cb4e63
PE
8230 * charset.h (charset_iso_8859_1): Remove decl.
8231 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8232 Now static.
8233
127198fd
PE
8234 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8235 * ccl.c (Vccl_program_table): Now static.
8236 (check_ccl_update): Remove; unused.
8237
d85b608f
PE
8238 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8239 * category.h: ... from here.
8240 * category.c (check_category_table, set_category_set): Now static.
8241
31cd66f3
PE
8242 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8243 * lisp.h: Remove these decls.
8244
c358e587
PE
8245 * buffer.c (buffer_count): Remove unused var.
8246
e78aecca
PE
8247 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8248 so that it's not optimized away.
8249 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8250 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8251 exported only to the debugger.
8252
e192d7d3 8253 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8254 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8255
92470028
PE
8256 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8257 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8258 was inaccessible from Lisp.
8259 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8260 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8261
244ed907
PE
8262 alloc.c: Import and export fewer symbols, and remove unused items.
8263 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8264 is defined.
8265 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8266 it's not optimized away by whole-program optimization.
8267 (message_enable_multibyte, free_misc): Remove.
8268 (catchlist, handlerlist, mark_backtrace):
8269 Declare only if BYTE_MARK_STACK.
8270 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8271 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8272 (message_enable_multibyte): Remove decl.
8273 (free_misc, interval_free_list, float_block, float_block_index):
8274 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8275 (cons_free_list, last_marked_index):
8276 Now static.
8277 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8278 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8279 (mark_backtrace): Define only if BYTE_MARK_STACK.
8280 * xdisp.c (message_enable_multibyte): Now static.
8281
61c2b50e 8282 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8283 This makes it easier for human readers (and static analyzers)
8284 to see whether these variables are used from other modules.
8285 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8286 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8287 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8288 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8289 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8290 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8291 * xmenu.c, xselect.c:
8292 Declare Q* vars static if they are not used in other modules.
8293 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8294 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8295 Remove decls of unexported vars.
8296 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8297
95c82688
PE
8298 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8299
16a97296
PE
8300 Make Emacs functions such as Fatom 'static' by default.
8301 This makes it easier for human readers (and static analyzers)
8302 to see whether these functions can be called from other modules.
8303 DEFUN now defines a static function. To make the function external
8304 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8305 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8306 (Finit_image_library):
16a97296
PE
8307 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8308 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8309 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8310 Remove decls, since these functions are now static.
8311 (Funintern, Fget_internal_run_time): New decls, since these functions
8312 were already external.
95c82688 8313
16a97296
PE
8314 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8315 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8316 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8317 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8318 * keyboard.c, keymap.c, lread.c:
8319 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8320 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8321 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8322 Mark functions with DEFUE instead of DEFUN,
8323 if they are used in other modules.
8324 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8325 decls for now-static functions.
8326 * buffer.h (Fdelete_overlay): Remove decl.
8327 * callproc.c (Fgetenv_internal): Mark as internal.
8328 * composite.c (Fremove_list_of_text_properties): Remove decl.
8329 (Fcomposition_get_gstring): New forward static decl.
8330 * composite.h (Fcomposite_get_gstring): Remove decl.
8331 * dired.c (Ffile_attributes): New forward static decl.
8332 * doc.c (Fdocumntation_property): New forward static decl.
8333 * eval.c (Ffetch_bytecode): New forward static decl.
8334 (Funintern): Remove extern decl; now in .h file where it belongs.
8335 * fileio.c (Fmake_symbolic_link): New forward static decl.
8336 * image.c (Finit_image_library): New forward static decl.
8337 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8338 * intervals.h (Fprevious_property_change):
8339 (Fremove_list_of_text_properties): Remove decls.
8340 * keyboard.c (Fthis_command_keys): Remove decl.
8341 (Fcommand_execute): New forward static decl.
8342 * keymap.c (Flookup_key): New forward static decl.
8343 (Fcopy_keymap): Now static.
8344 * keymap.h (Flookup_key): Remove decl.
8345 * process.c (Fget_process): New forward static decl.
8346 (Fprocess_datagram_address): Mark as internal.
8347 * syntax.c (Fsyntax_table_p): New forward static decl.
8348 (skip_chars): Remove duplicate decl.
8349 * textprop.c (Fprevious_property_change): New forward static decl.
8350 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8351 Now internal.
8352 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8353 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8354
785bbd42
PE
8355 * editfns.c (Fformat): Remove unreachable code.
8356
8b913b57
AS
83572011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8358
8359 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8360 change. (Bug#8496)
8361
a6744a35
EZ
83622011-04-13 Eli Zaretskii <eliz@gnu.org>
8363
8364 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8365 when at ZV. (Bug#8487)
8366
e7974947
AS
83672011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8368
baad03f0
AS
8369 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8370 (Bug#8437)
8371 * keyboard.c (parse_tool_bar_item): Likewise.
8372 * sound.c (sound_cleanup, alsa_close): Likewise.
8373 * termcap.c (tgetent): Likewise.
8374 * xfns.c (x_default_font_parameter): Likewise.
8375 * xsettings.c (read_and_apply_settings): Likewise.
8376
e7974947
AS
8377 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8378 (overrun_check_free): Protoize.
8379
28272684
PE
83802011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8381
8382 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8383 since callers should never pass a negative size.
8384 Change the signature to match that of plain 'read' and 'write'; see
8385 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8386 * lisp.h: Update prototypes of emacs_write and emacs_read.
8387
11997c76
EZ
83882011-04-11 Eli Zaretskii <eliz@gnu.org>
8389
8390 * xdisp.c (redisplay_window): Don't try to determine the character
8391 position of the scroll margin if the window start point w->startp
e896f03c 8392 is outside the buffer's accessible region. (Bug#8468)
11997c76 8393
8a2cbd72
EZ
83942011-04-10 Eli Zaretskii <eliz@gnu.org>
8395
8396 Fix write-region and its subroutines for buffers > 2GB.
8397 * fileio.c (a_write, e_write): Modify declaration of arguments and
8398 local variables to support buffers larger than 2GB.
8399 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8400
8401 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8402 argument, local variables, and return value.
8403
8404 * lisp.h: Update prototypes of emacs_write and emacs_read.
8405
8406 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8407
4073e537 84082011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8409
1ebfdcb6
PE
8410 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8411
b2ded58d
PE
8412 Fix more problems found by GCC 4.6.0's static checks.
8413
7d66342c
PE
8414 * xdisp.c (vmessage): Use a better test for character truncation.
8415
bbf47d44
PE
8416 * charset.c (load_charset_map): <, not <=, for optimization,
8417 and to avoid potential problems with integer overflow.
9248994d 8418 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8419 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8420 * editfns.c (Fformat): Likewise.
1e69125e 8421 * syntax.c (skip_chars): Likewise.
3befa583 8422
e3019616
PE
8423 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8424 This also lets GCC 4.6.0 generate slightly better loop code.
8425
becfa255
PE
8426 * callint.c (Fcall_interactively): <, not <=, for optimization.
8427 (Fcall_interactively): Count the number of arguments produced,
8428 not the number of arguments given. This is simpler and lets GCC
8429 4.6.0 generate slightly better code.
8430
dae0cd48
PE
8431 * ftfont.c: Distingish more carefully between FcChar8 and char.
8432 The previous code passed unsigned char * to a functions like
8433 strlen and xstrcasecmp that expect char *, which does not
8434 conform to the C standard.
8435 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8436 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8437 char * when the C standard requires it.
8438
76032d70
PE
8439 * keyboard.c (read_char): Remove unused var.
8440
eb3f1cc8
PE
8441 * eval.c: Port to Windows vsnprintf (Bug#8435).
8442 Include <limits.h>.
8443 (SIZE_MAX): Define if the headers do not.
8444 (verror): Do not give up if vsnprintf returns a negative count.
8445 Instead, grow the buffer. This ports to Windows vsnprintf, which
8446 does not conform to C99. Problem reported by Eli Zaretskii.
8447 Also, simplify the allocation scheme, by avoiding the need for
8448 calling realloc, and removing the ALLOCATED variable.
8449
70476b54
PE
8450 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8451
12020a9e
PE
8452 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8453 But keep the doprint source code for now, as we might revamp it
8454 and use it again (Bug#8435).
ea6c7ae6
PE
8455 * lisp.h (doprnt): Remove.
8456 * Makefile.in (base_obj): Remove doprnt.o.
8457 * deps.mk (doprnt.o): Remove.
8458
5fdb398c
PE
8459 error: Print 32- and 64-bit integers portably (Bug#8435).
8460 Without this change, on typical 64-bit hosts error ("...%d...", N)
8461 was used to print both 32- and 64-bit integers N, which relied on
8462 undefined behavior.
61bdb816 8463 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8464 * lisp.h (error, verror): Mark as printf-like functions.
8465 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8466 Report overflow in size calculations when allocating printf buffer.
8467 Do not truncate output string at its first null byte.
8468 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8469 Truncate the output at a character boundary, since vsnprintf does not
8470 do that.
8471 * charset.c (check_iso_charset_parameter): Convert internal
8472 character to string before calling 'error', since %c now has the
8473 printf meaning.
8474 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8475 overflow when computing char to be passed to 'error'. Do not
8476 pass Lisp_Object to 'error'; pass the integer instead.
8477 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8478 formatted with plain %d.
8479
b189fa66
PE
8480 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8481
bff87ef0
PE
8482 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8483
7e2cac20
PE
8484 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8485
ce4d90b5
PE
8486 * xterm.c (x_catch_errors): Remove duplicate declaration.
8487
266c9547
PE
8488 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8489
79c49ad2
PE
8490 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8491
368f4090
JM
84922011-04-10 Jim Meyering <meyering@redhat.com>
8493
8494 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8495 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8496 return ssize_t not "int", and use size_t as the buffer length.
8497 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8498 * gnutls.h: Update declarations.
8499 * process.c (read_process_output): Use ssize_t, to match.
8500 (send_process): Likewise.
8501
a32d4040
CY
85022011-04-09 Chong Yidong <cyd@stupidchicken.com>
8503
8504 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8505
8546720e 85062011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8507
04f2d78b
CB
8508 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8509 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8510
8546720e
GM
8511 * xterm.c (handle_one_xevent):
8512 * xmenu.c (create_and_show_popup_menu):
8513 * xselect.c (x_decline_selection_request)
8514 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8515
0a2f5c1a 85162011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8517
8518 Fix some uses of `int' instead of EMACS_INT.
8519 * search.c (string_match_1, fast_string_match)
8520 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8521 (scan_buffer, find_next_newline_no_quit)
8522 (find_before_next_newline, search_command, Freplace_match)
8523 (Fmatch_data): Make some `int' variables be EMACS_INT.
8524
8525 * xdisp.c (display_count_lines): 3rd argument and return value now
8526 EMACS_INT. All callers changed.
8527 (pint2hrstr): Last argument is now EMACS_INT.
8528
8529 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8530 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8531 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8532 (decode_coding_utf_16, decode_coding_emacs_mule)
8533 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8534 (decode_coding_ccl, decode_coding_charset)
8535 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8536 (decode_coding_iso_2022, decode_coding_emacs_mule)
8537 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8538 <char_offset, last_offset>: Declare EMACS_INT.
8539 (encode_coding_utf_8, encode_coding_utf_16)
8540 (encode_coding_emacs_mule, encode_invocation_designation)
8541 (encode_designation_at_bol, encode_coding_iso_2022)
8542 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8543 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8544 Declare EMACS_INT.
8545 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8546 (encode_invocation_designation): Last argument P_NCHARS is now
8547 EMACS_INT.
8548 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8549 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8550
8551 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8552 All users changed.
8553
8554 * ccl.c (Fccl_execute_on_string): Declare some variables
8555 EMACS_INT.
8556
8546720e 85572011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8558
8559 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8560
4e19a977
CS
85612011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8562
8563 * process.c (Fformat_network_address): Doc fix.
8564
87302331
R
85652011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8566
ee7683eb 8567 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8568
cbb59342
CY
85692011-04-08 Chong Yidong <cyd@stupidchicken.com>
8570
8571 * keyboard.c (read_char): Call Lisp function help-form-show,
8572 instead of using internal_with_output_to_temp_buffer.
8573 (Qhelp_form_show): New var.
e0d38eeb 8574 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8575
8576 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8577
8578 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8579
e67a13ab
CY
85802011-04-06 Chong Yidong <cyd@stupidchicken.com>
8581
04f2d78b
CB
8582 * process.c (Flist_processes): Remove to Lisp.
8583 (list_processes_1): Delete.
e67a13ab 8584
973f782d
EZ
85852011-04-06 Eli Zaretskii <eliz@gnu.org>
8586
7c106b1e
EZ
8587 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8588
973f782d
EZ
8589 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8590
41cf7d1a 85912011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8592
ca23cc88
PE
8593 Fix more problems found by GCC 4.6.0's static checks.
8594
f390e2d5
PE
8595 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8596
42eea0d0
PE
8597 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8598
b69769da 8599 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8600
f9541e84
PE
8601 * xdisp.c (vmessage): Mark as a printf-like function.
8602
13841b55
PE
8603 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8604
c136c10f
PE
8605 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8606
5e2d4a30
PE
8607 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8608 printf-like functions.
8609 (tiff_load): Add casts to remove these marks before passing them
8610 to system-supplied API.
8611
583f48b9
PE
8612 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8613
b25d760e
PE
8614 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8615 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8616 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8617 directly, rather than having caller test rule sign. This avoids
8618 some unnecessary tests.
8619 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8620 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8621 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8622
bc7b6697 8623 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8624 (xfont_open): Avoid unnecessary tests.
bc7b6697 8625
27ccc379
PE
8626 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8627
dcd5c89a
PE
8628 * composite.h, composite.c (composition_gstring_put_cache):
8629 Use EMACS_INT, not int, for length.
8630
b13a45c6
PE
8631 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8632 breaking out part of COMPOSITION_DECODE_RULE.
8633 (COMPOSITION_DECODE_RULE): Use it.
8634 * composite.c (get_composition_id): Remove unused local vars,
8635 by using the new macro.
8636
1e792e4d
PE
8637 * textprop.c (set_text_properties_1): Change while to do-while,
8638 since the condition is always true at first.
8639
dc6c6455 8640 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8641 (interval_deletion_adjustment): Return unsigned value.
8642 All uses changed.
dc6c6455 8643
aba7731a
PE
8644 * process.c (list_processes_1, create_pty, read_process_output):
8645 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8646 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8647 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8648 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8649 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8650
fdfc4bf3
PE
8651 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8652
fca8fe46 8653 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8654 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8655
06a0259a 8656 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8657 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8658 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8659
e7b9e80f
PE
8660 * print.c (print_error_message): Avoid int overflow.
8661
56201685
PE
8662 * font.c (font_list_entities): Redo for clarity,
8663 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8664
78834453 8665 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8666 (font_score): Avoid potential overflow in diff calculation.
78834453 8667
0bc0b309 8668 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8669 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8670
e610eaca
PE
8671 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8672
b895abce
PE
8673 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8674 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8675 can always succeed if overflow has undefined behavior.
8676
1f1d9321 8677 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8678 (wordify): Omit three unnecessary tests.
1f1d9321 8679
c59478bc
PE
8680 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8681 All callers changed. This avoids the need for an unused var.
8682
79b73827
PE
8683 * casefiddle.c (casify_region): Remove var that is set but not used.
8684
a4db5dfe
PE
8685 * dired.c (file_name_completion): Remove var that is set but not used.
8686
43aae36e
PE
8687 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8688
2a47c44d 8689 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8690 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8691
a37c69bf
PE
8692 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8693 Check for integer overflow on size calculations.
8694
328ab8e7
PE
8695 * buffer.c (Fprevious_overlay_change): Remove var that is set
8696 but not used.
8697
e5a2a5cb
PE
8698 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8699 Remove vars that are set but not used.
8d84a6eb 8700 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8701 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8702
a60e5f68
PE
8703 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8704
f661cb61 8705 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8706 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8707
f0397f5a
PE
8708 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8709 that are set but not used.
8710
8664db06 8711 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8712 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8713
6abdaa4a
PE
8714 * xselect.c (x_get_local_selection, x_handle_property_notify):
8715 Remove vars that are set but not used.
8716
0ce7538d 8717 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8718 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8719
9ae848fc
PE
8720 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8721 Remove var that is set but not used.
0b918413
PE
8722 (scroll_bar_windows_size): Now size_t, not int.
8723 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8724 Check for overflow.
9ae848fc 8725
a5a62657
PE
8726 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8727 (map_tty_color) [!defined MSDOS]: Likewise.
8728
5c5cdd39
PE
8729 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8730
66ebf983
PE
8731 * coding.c: Remove vars that are set but not used.
8732 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8733 All callers changed.
8734 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8735 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8736 (decode_coding_charset): Remove vars that are set but not used.
8737
1be4d761
PE
8738 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8739 that is set but not used.
8740
47553fa8
PE
8741 * print.c (print_object): Remove var that is set but not used.
8742
1f7196bf 8743 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8744 The gnulib version avoids calling malloc in the usual case,
8745 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8746 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8747 * filelock.c (current_lock_owner): Likewise.
8748 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8749 * sysdep.c: Include allocator.h, careadlinkat.h.
8750 (emacs_no_realloc_allocator): New static constant.
8751 (emacs_readlink): New function.
fdb61804
PE
8752 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8753 ../lib/careadlinkat.h.
d1fdcab7 8754
f84c17c7
SM
87552011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8756
8757 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8758 first non-nil return value).
8759
ef3862ad
JD
87602011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8761
8762 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8763 if not defined (Bug#8403).
8764
376a7006
JB
87652011-04-02 Juanma Barranquero <lekktu@gmail.com>
8766
8767 * xdisp.c (display_count_lines): Remove parameter `start',
8768 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8769 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8770 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8771 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8772 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8773 and thereabouts. All callers changed.
8774 (get_per_char_metric): Remove parameter `f', unused since
8775 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8776
6ca3801d
JM
87772011-04-02 Jim Meyering <meyering@redhat.com>
8778
8779 do not dereference NULL upon failed strdup
8780 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8781 (ns_get_family): Likewise.
8782
d8e2b5ba
JB
87832011-04-02 Juanma Barranquero <lekktu@gmail.com>
8784
8785 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8786
8c74fcbd
JD
87872011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8788
8789 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8790 later (Bug#8403).
8791
7200d79c
SM
87922011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8793
03408648 8794 Add lexical binding.
7200d79c 8795
03408648
SM
8796 * window.c (Ftemp_output_buffer_show): New fun.
8797 (Fsave_window_excursion):
8798 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8799
8800 * lread.c (lisp_file_lexically_bound_p): New function.
8801 (Fload): Bind Qlexical_binding.
8802 (readevalloop): Remove `evalfun' arg.
8803 Bind Qinternal_interpreter_environment.
8804 (Feval_buffer): Bind Qlexical_binding.
8805 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8806 Mark as dynamic.
8807 (syms_of_lread): Declare `lexical-binding'.
8808
8809 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8810
8811 * keyboard.c (eval_dyn): New fun.
8812 (menu_item_eval_property): Use it.
ca105506
SM
8813
8814 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8815
03408648
SM
8816 * fns.c (concat, mapcar1): Accept byte-code-functions.
8817
8818 * eval.c (Fsetq): Handle lexical vars.
8819 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8820 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8821 (FletX, Flet): Obey lexical binding.
8822 (Fcommandp): Handle closures.
8823 (Feval): New `lexical' arg.
8824 (eval_sub): New function extracted from Feval. Use it almost
8825 everywhere where Feval was used. Look up vars in lexical env.
8826 Handle closures.
8827 (Ffunctionp): Move from subr.el.
8828 (Ffuncall): Handle closures.
8829 (apply_lambda): Remove `eval_flags'.
8830 (funcall_lambda): Handle closures and new byte-code-functions.
8831 (Fspecial_variable_p): New function.
8832 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8833 but without exporting it to Lisp.
23aba0ea 8834
23aba0ea 8835 * doc.c (Fdocumentation, store_function_docstring):
03408648 8836 * data.c (Finteractive_form): Handle closures.
23aba0ea 8837
03408648
SM
8838 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8839 interactive spec.
ba83908c 8840
04f2d78b
CB
8841 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8842 New byte-codes.
03408648
SM
8843 (exec_byte_code): New function extracted from Fbyte_code to handle new
8844 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8845
03408648 8846 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8847
03408648 8848 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8849
e2abce01
JB
88502011-03-31 Juanma Barranquero <lekktu@gmail.com>
8851
8852 * xdisp.c (redisplay_internal): Fix prototype.
8853
63696a73 88542011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8855
63696a73 8856 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8857 (try_scrolling): Use it when setting scroll_limit.
8858 Limit scrolling to 100 screen lines.
63696a73
EZ
8859 (redisplay_window): Even when falling back on "recentering",
8860 position point in the window according to scroll-conservatively,
8861 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8862
8863 (try_scrolling): When point is above the window, allow searching
8864 as far as scroll_max, or one screenful, to compute vertical
8865 distance from PT to the scroll margin position. This prevents
8866 try_scrolling from unnecessarily failing when
8867 scroll-conservatively is set to a value slightly larger than the
8868 window height. Clean up the case of PT below the margin at bottom
8869 of window: scroll_max can no longer be INT_MAX. When aggressive
8870 scrolling is in use, don't let point enter the opposite scroll
8871 margin as result of the scroll.
8872 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8873 threshold of 100 lines for never-recentering scrolling.
8874
e4cc2dfc
JB
88752011-03-31 Juanma Barranquero <lekktu@gmail.com>
8876
8877 * dispextern.h (move_it_by_lines):
8878 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8879 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8880 (message_log_check_duplicate): Remove parameters `prev_bol' and
8881 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8882 (redisplay_internal): Remove parameter `preserve_echo_area',
8883 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8884
8885 * indent.c (Fvertical_motion):
8886 * window.c (window_scroll_pixel_based, Frecenter):
8887 Don't pass `need_y_p' to `move_it_by_lines'.
8888
1c470562
SM
88892011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8890
44f230aa
SM
8891 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8892 steal a few bits to be more compact.
8893 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8894 Remove unneeded casts.
8895
1c470562
SM
8896 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8897
888adce9
ZK
88982011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8899
8900 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8901 binding" message (bug#7967).
8902
f838ed7b
PE
89032011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8904
77861b95
PE
8905 Fix more problems found by GCC 4.6.0's static checks.
8906
de6dbc14
PE
8907 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8908 Remove unused local var.
8909
f838ed7b
PE
8910 * editfns.c (Fmessage_box): Remove unused local var.
8911
792c7b2b
PE
8912 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8913 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8914 Omit unused local vars.
c499e557 8915 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8916 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8917 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8918 Omit unused local var.
8919
ba0165e1
PE
8920 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8921 Don't assume string length fits in int.
32ad8845 8922 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8923 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8924
3c59b4c9
PE
8925 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8926 instead of alloca (Bug#8344).
8927
a3eed478 8928 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8929 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8930
eb4d412d
PE
8931 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8932
1658b401
PE
8933 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8934 concerns.
8935
8936 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8937
8938 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8939
9a2c6e05
PE
8940 * keyboard.c (syms_of_keyboard): Use the same style as later
8941 in this function when indexing through an array. This also
8942 works around GCC bug 48267.
8943
03d0a109
PE
8944 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8945
44f730c8
PE
8946 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8947
fe75f926
PE
8948 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8949 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8950
ffa8c828
PE
8951 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8952 This avoids undefined behavior on integer overflow, and is a bit
8953 more convenient anyway since it is compared to a size_t variable.
8954
c5101a77
PE
8955 Variadic C functions now count arguments with size_t, not int.
8956 This avoids an unnecessary limitation on 64-bit machines, which
8957 caused (substring ...) to crash on large vectors (Bug#8344).
8958 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8959 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8960 All variadic functions and their callers changed accordingly.
c5101a77
PE
8961 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8962 * data.c (arith_driver, float_arith_driver): Likewise.
8963 * editfns.c (general_insert_function): Likewise.
8964 * eval.c (struct backtrace.nargs, interactive_p)
8965 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8966 (funcall_lambda, mark_backtrace): Likewise.
8967 * fns.c (concat): Likewise.
8968 * frame.c (x_set_frame_parameters): Likewise.
8969 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8970 0 if not found, not -1. All callers changed.
8971
dd3f25f7
PE
8972 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8973 (stack_copy_size): Now size_t, not int.
8974 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8975
461c2ab9
JB
89762011-03-28 Juanma Barranquero <lekktu@gmail.com>
8977
8978 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8979 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8980 All callers changed.
8981
8982 * lisp.h (multibyte_char_to_unibyte):
8983 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8984 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8985 * character.h (CHAR_TO_BYTE8):
8986 * cmds.c (internal_self_insert):
8987 * editfns.c (general_insert_function):
8988 * keymap.c (push_key_description):
8989 * search.c (Freplace_match):
8990 * xdisp.c (message_dolog, set_message_1): All callers changed.
8991
f6d62986
SM
89922011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8993
8994 * keyboard.c (safe_run_hook_funcall): New function.
8995 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8996 don't set the hook to nil, but remove the offending function instead.
8997 (Qcommand_hook_internal): Remove, unused.
8998 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8999 Vcommand_hook_internal.
9000
9001 * eval.c (enum run_hooks_condition): Remove.
9002 (funcall_nil, funcall_not): New functions.
9003 (run_hook_with_args): Call each function through a `funcall' argument.
9004 Remove `cond' argument, now redundant.
9005 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9006 (Frun_hook_with_args_until_failure): Adjust accordingly.
9007 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9008
1db5b1ad
JB
90092011-03-28 Juanma Barranquero <lekktu@gmail.com>
9010
9011 * dispextern.h (string_buffer_position): Remove declaration.
9012
9013 * print.c (strout): Remove parameter `multibyte', unused since
9014 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9015
9016 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9017 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9018 All callers changed.
9019
9020 * w32.c (_wsa_errlist): Use braces for struct initializers.
9021
9022 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9023 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9024 All callers changed.
9025 (string_buffer_position): Likewise. Also, make static (it's never
9026 used outside xdisp.c).
9027 (cursor_row_p): Remove parameter `w', unused since
9028 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9029 (decode_mode_spec): Remove parameter `precision', introduced during
9030 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9031 All callers changed.
9032
5ffb62aa
JD
90332011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9034
9035 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9036
461c2ab9 90372011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
9038
9039 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9040 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9041 (ns_update_auto_hide_menu_bar): New functions.
9042 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9043 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9044 ns_constrain_all_frames.
9045 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9046 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9047
5c380ffb
JD
90482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9049
9050 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9051
9af30bdf
GM
90522011-03-27 Glenn Morris <rgm@gnu.org>
9053
9054 * syssignal.h: Replace RETSIGTYPE with void.
9055 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9056 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9057 Replace SIGTYPE with void everywhere.
9058 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9059 * s/template.h (SIGTYPE): Remove commented out definition.
9060
e2abce01
JB
90612011-03-26 Eli Zaretskii <eliz@gnu.org>
9062
9063 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9064 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9065
f868cd8a
JB
90662011-03-26 Juanma Barranquero <lekktu@gmail.com>
9067
59eb0929
JB
9068 * w32.c (read_unc_volume): Use parameter `henum', instead of
9069 global variable `wget_enum_handle'.
9070
9071 * keymap.c (describe_vector): Remove parameters `indices' and
9072 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9073 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9074
f868cd8a
JB
9075 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9076
9077 * keyboard.c (timer_check): Remove parameter `do_it_now',
9078 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9079 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9080 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9081
9082 * keyboard.c (read_char):
9083 * w32menu.c (w32_menu_display_help):
9084 * xmenu.c (show_help_event, menu_help_callback):
9085 Adjust calls to `show_help_echo'.
9086
9087 * gtkutil.c (xg_maybe_add_timer):
9088 * keyboard.c (readable_events):
9089 * process.c (wait_reading_process_output):
9090 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9091
9092 * insdel.c (adjust_markers_gap_motion):
9093 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9094 (gap_left, gap_right): Don't call it.
9095
2ecf6fdb
CY
90962011-03-25 Chong Yidong <cyd@stupidchicken.com>
9097
9098 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9099 incurred during fontification.
9100
6b1f9ba4
JB
91012011-03-25 Juanma Barranquero <lekktu@gmail.com>
9102
9103 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9104 (DEFVAR_PER_BUFFER): Don't pass it.
9105
9106 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9107 (scrolling_window): Don't pass it.
9108
0f4a96b5
JB
91092011-03-25 Juanma Barranquero <lekktu@gmail.com>
9110
9111 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9112
9113 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9114 and `suffix'.
9115 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9116 of variables specific to SELinux and computation of `encoded_absname'.
9117
9118 * image.c (XPutPixel): Remove unused variable `height'.
9119
9120 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9121
9122 * unexw32.c (get_section_info): Remove unused variable `section'.
9123
9124 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9125 (system_process_attributes): Remove unused variable `sess'.
9126 (sys_read): Remove unused variable `err'.
9127
9128 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9129 (w32_wnd_proc): Remove unused variable `isdead'.
9130 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9131 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9132 (x_create_tip_frame): Remove unused variable `tem'.
9133
9134 * w32inevt.c (w32_console_read_socket):
9135 Remove unused variable `no_events'.
9136
9137 * w32term.c (x_draw_composite_glyph_string_foreground):
9138 Remove unused variable `width'.
9139
1149507c
JB
91402011-03-24 Juanma Barranquero <lekktu@gmail.com>
9141
9142 * w32term.c (x_set_glyph_string_clipping):
9143 Don't pass uninitialized region to CombineRgn.
9144
9c88f339
JB
91452011-03-23 Juanma Barranquero <lekktu@gmail.com>
9146
9147 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9148 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9149 (Fx_close_connection): Remove unused variable `i'.
9150
9151 * w32font.c (w32font_draw): Return number of glyphs.
9152 (w32font_open_internal): Remove unused variable `i'.
9153 (w32font_driver): Add missing initializer.
9154
9155 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9156 (fill_in_menu): Remove unused variable `items_added'.
9157
9158 * w32term.c (last_mouse_press_frame): Remove static global variable.
9159 (w32_clip_to_row): Remove unused variable `f'.
9160 (x_delete_terminal): Remove unused variable `i'.
9161
9162 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9163 (NOTHING): Remove unused static global variable.
9164 (uniscribe_check_otf): Remove unused variable `table'.
9165 (uniscribe_font_driver): Add missing initializers.
9166
dee091a3
JD
91672011-03-23 Julien Danjou <julien@danjou.info>
9168
9169 * term.c (Fsuspend_tty, Fresume_tty):
9170 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9171 * window.c (temp_output_buffer_show):
9172 * insdel.c (signal_before_change):
9173 * frame.c (Fhandle_switch_frame):
9174 * fileio.c (Fdo_auto_save):
9175 * emacs.c (Fkill_emacs):
9176 * editfns.c (save_excursion_restore):
9177 * cmds.c (internal_self_insert):
9178 * callint.c (Fcall_interactively):
9179 * buffer.c (Fkill_all_local_variables):
9180 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9181 Use Frun_hooks.
0f4a96b5 9182 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9183 unconditionally since it does the check itself.
dee091a3 9184
2c520ab5 91852011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9186
c9c49752
PE
9187 Fix more problems found by GCC 4.5.2's static checks.
9188
8abc3f12
PE
9189 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9190 the first time through the loop, since we know p0 < p1 then.
9191 This also avoids a gcc -Wstrict-overflow warning.
9192
a2d26660
PE
9193 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9194 leading to a memory leak, possible in functions like
9195 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9196 of objects (Bug#8318).
a2d26660 9197
916c72e9
PE
9198 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9199 that could (at least in theory) be that large.
9200
19ab8a18
PE
9201 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9202 This is less likely to overflow, and avoids undefined behavior if
9203 overflow does occur. All callers changed. Use strtoul to scan
9204 for the unsigned long integer.
b7cbbd6f
PE
9205 (pint2hrstr): Simplify and tune code slightly.
9206 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9207
f0641eff
PE
9208 * scroll.c (do_scrolling): Work around GCC bug 48228.
9209 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9210
7f650bb9
PE
9211 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9212 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9213 (validate_x_resource_name): Simplify count usage.
9214 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9215
37dd57d1
PE
9216 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9217 fail (Bug#8306).
81e56e61 9218
699979fc 9219 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9220
401bf9b4
PE
9221 * process.c (Fmake_network_process): Use socklen_t, not int,
9222 where POSIX says socklen_t is required in portable programs.
9223 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9224 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9225 (Fmake_network_process, server_accept_connection):
9226 (wait_reading_process_output, read_process_output):
9227 Likewise.
9228
b93aacde
PE
9229 * process.c: Rename or move locals to avoid shadowing.
9230 (list_processes_1, Fmake_network_process):
9231 (read_process_output_error_handler, exec_sentinel_error_handler):
9232 Rename or move locals.
4dc343ee 9233 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9234 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9235 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9236 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9237 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9238
af8a867c 9239 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9240 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9241 Include tparam.h instead, since it declares them.
af8a867c
PE
9242 * cm.h (PC): Remove extern decl; tparam.h now does this.
9243 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9244 * terminfo.c: Include tparam.h, to check interfaces.
9245 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9246 (tparam): Adjust signature to match interface in tparam.h;
9247 this removes some undefined behavior. Check that outstring and len
9248 are zero, which they always are with Emacs.
9249 * tparam.h (PC, BC, UP): New extern decls.
9250
0248044d 9251 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9252 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9253
8ff096c1 9254 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9255 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9256 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9257 (ftfont_list): Remove unused local.
49eaafba
PE
9258 (get_adstyle_property, ftfont_pattern_entity):
9259 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9260 Rename locals to avoid shadowing.
8ff096c1 9261
e2be39f6
PE
9262 * xfont.c (xfont_list_family): Mark var as initialized.
9263
c9735e30
PE
9264 * xml.c (make_dom): Now static.
9265
8f5201ae
PE
9266 * composite.c (composition_compute_stop_pos): Rename local to
9267 avoid shadowing.
b246f932
PE
9268 (composition_reseat_it): Remove unused locals.
9269 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9270 (composition_update_it): Mark var as initialized.
11b61122
PE
9271 (find_automatic_composition): Mark vars as initialized,
9272 with a FIXME (Bug#8290).
8f5201ae 9273
760fbc2c
PE
9274 character.h: Rename locals to avoid shadowing.
9275 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9276 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9277 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9278 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9279 to avoid shadowing.
9280
ff08eb85
PE
9281 * textprop.c (property_change_between_p): Remove; unused.
9282
fc7bf025
PE
9283 * intervals.c (interval_start_pos): Now static.
9284
235d7abc
PE
9285 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9286
44f230aa
SM
9287 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9288 Rename locals to avoid shadowing.
3e7d6594 9289
50060332
PE
9290 * sound.c (wav_play, au_play, Fplay_sound_internal):
9291 Fix pointer signedness.
d01f234b 9292 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9293 (wav_play): Initialize a variable to 0, to prevent undefined
9294 behavior (Bug#8278).
50060332 9295
c4fc4e30
PE
9296 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9297
918436ed
PE
9298 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9299
c939f91b
PE
9300 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9301 clobbering (Bug#8298).
b9c7f648
PE
9302 * sysdep.c (sys_subshell): Likewise.
9303 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9304
6bd8c144
PE
9305 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9306 This should get cleaned up, so that child_setup has the
9307 same signature on all platforms.
9308
7710357c 9309 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9310 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9311
c59da222
CY
93122011-03-22 Chong Yidong <cyd@stupidchicken.com>
9313
9314 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9315 not to be necessary, and produces flickering.
9316
66b87493
GM
93172011-03-20 Glenn Morris <rgm@gnu.org>
9318
9319 * config.in: Remove file.
9320
45b6f6d5
JB
93212011-03-20 Juanma Barranquero <lekktu@gmail.com>
9322
9323 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9324 are now in src/globals.h.
9325 (syms_of_minibuf): Remove spurious & from previous change.
9326
cd394be1 93272011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9328
9329 * minibuf.c (completing-read-function): New variable.
9330 (completing-read-default): Rename from completing-read.
9331 (completing-read): Call completing-read-function.
9332
b14e3e21
CY
93332011-03-19 Juanma Barranquero <lekktu@gmail.com>
9334
9335 * xfaces.c (Fx_load_color_file):
9336 Read color file from absolute filename (bug#8250).
9337
f2b726e6
JB
93382011-03-19 Juanma Barranquero <lekktu@gmail.com>
9339
9340 * makefile.w32-in: Update dependencies.
9341
09f6ff02
EZ
93422011-03-17 Eli Zaretskii <eliz@gnu.org>
9343
9344 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9345
29a6015a
PE
93462011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9347
a3a6c54e
PE
9348 Fix more problems found by GCC 4.5.2's static checks.
9349
b766f867
PE
9350 * process.c (make_serial_process_unwind, send_process_trap):
9351 (sigchld_handler): Now static.
9352
be02381c
PE
9353 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9354 That way, the code declares only the vars that it needs.
9355 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9356 * s/cygwin.h (PTY_ITERATION): Likewise.
9357 * s/darwin.h (PTY_ITERATION): Likewise.
9358 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9359
57048744
PE
9360 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9361 * process.c (allocate_pty): Don't declare stb unless it's needed.
9362
7914961c 9363 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9364 (CONSTANTLIM): Remove; unused.
9365 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9366 Define only if needed.
7914961c 9367
b3967b18
PE
9368 * unexelf.c (unexec): Name an expression,
9369 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9370 Use a different way to cause a compilation error if anyone uses
9371 n rather than nn, a way that does not involve shadowing.
73366a00 9372 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9373
29a6015a
PE
9374 * deps.mk (unexalpha.o): Remove; unused.
9375
43cfc33e 9376 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9377 * unexec.h: New file.
ce701a33
PE
9378 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9379 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9380 Depend on unexec.h.
9381 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9382 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9383 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9384 Change as necessary to match prototype in unexec.h.
ce701a33 9385
01f44d5a
PE
9386 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9387 shadowing.
4f63c6bb 9388 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9389
a6670b0b
PE
9390 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9391 Rename locals to avoid shadowing.
9392
cef2010d 9393 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9394 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9395
d4d7173a
PE
9396 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9397
f08b802a
PE
9398 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9399 warning when compiling print.c.
9400
3ddb0639
PE
9401 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9402 instead of using an uninitialized var.
5ad03b97 9403 (font_sort_entities): Mark var as initialized.
3ddb0639 9404
170a2692
PE
9405 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9406
e663c700
PE
9407 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9408 pointers to constants.
89bc529a 9409 (font_parse_fcname): Remove unused vars.
7b81e2d0 9410 (font_delete_unmatched): Now static.
ea838e10 9411 (font_get_spec): Remove; unused.
13a547c6
PE
9412 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9413 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9414 Rename or move locals to avoid shadowing.
e663c700 9415
2a80c887 9416 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9417 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9418
1384fa33 9419 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9420 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9421
8b2c52e9
PE
9422 * alloc.c (mark_backtrace): Move decl from here ...
9423 * lisp.h: ... to here, so that it can be checked.
9424
475545b5 9425 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9426 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9427 (lisp_indirect_variable): Name an expression,
9428 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9429 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9430
b1349114 9431 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9432 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9433 Use const pointer when appropriate.
b1349114 9434
a2928364
PE
9435 * lisp.h (get_system_name, get_operating_system_release):
9436 Move decls here, to check interfaces.
9437 * process.c (get_operating_system_release): Move decl to lisp.h.
9438 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9439 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9440 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9441 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9442 (Fformat_time_string, Fencode_time, Finsert_char):
9443 (Ftranslate_region_internal, Fformat):
9444 Rename or remove local vars to avoid shadowing.
9710023e 9445 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9446
a415e694
PE
9447 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9448 avoid shadowing.
9449
8ef4622d
PE
9450 * lisp.h (eassert): Check that the argument compiles, even if
9451 ENABLE_CHECKING is not defined.
9452
946f9a5b
PE
9453 * data.c (Findirect_variable): Name an expression, to avoid
9454 gcc -Wbad-function-cast warning.
112396d6 9455 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9456 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9457 (Fmake_variable_buffer_local, Fmake_local_variable):
9458 Mark variables as initialized.
52746918 9459 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9460
e5aab7e7 9461 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9462 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9463 Rename locals to avoid shadowing.
dff45157
PE
9464 (mark_stack): Move local variables into the #ifdef region where
9465 they're used.
7bc26fdb
PE
9466 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9467 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9468 needed otherwise.
9469 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9470 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9471 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9472
e5aab7e7
PE
9473 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9474 avoids undefined behavior in theory.
9475
4da60324
PE
9476 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9477
88043301
PE
9478 Use functions, not macros, for up- and down-casing (Bug#8254).
9479 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9480 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9481 to use the following functions instead of these macros.
9482 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9483 EMACS_INT, since callers assume the returned value fits in int.
9484 (upcase1): Likewise, for UPCASE_TABLE.
9485 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9486 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9487 the race-condition problem in the old DOWNCASE.
88043301 9488
19ed5445
PE
9489 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9490 Rename locals to avoid shadowing.
9491 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9492 (regex_compile, re_search_2, re_match_2_internal):
9493 Remove unused local vars.
952db0d7
PE
9494 (FREE_VAR): Rewrite so as not to use empty "else",
9495 which gcc can warn about.
da053e48 9496 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9497 (RETALLOC_IF): Define only if needed.
9498 (WORDCHAR_P): Likewise. This one is never needed, but is used
9499 only in a comment talking about a compiler bug, so put inside
9500 the #if 0 of that comment.
9501 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9502 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9503 Remove; unused.
19ed5445 9504
1f3561e4 9505 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9506 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9507 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9508
ded6f8f7
PE
9509 * search.c (simple_search): Remove unused var.
9510
dbd37a95
PE
9511 * dired.c (compile_pattern): Move decl from here ...
9512 * lisp.h: ... to here, so that it can be checked.
9513 (struct re_registers): New forward decl.
9514
7e47afad
PE
9515 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9516
85f24f61
PE
9517 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9518 All uses changed.
9519 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9520 Rename locals to avoid shadowing.
5671df8f 9521 (Fvertical_motion): Mark locals as initialized.
85f24f61 9522
181aa2be 9523 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9524 (casify_region): Mark local as initialized.
181aa2be 9525
930d429c
PE
9526 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9527
7082eac6
PE
9528 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9529 New macros, so that the caller can use some names other than
9530 gcpro1, gcpro2, etc.
9531 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9532 of the new macros.
9533 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9534 argument, for consistency with GCPRO2_VAR, etc: it is now the
9535 prefix of the variable, not the variable itself. All uses
9536 changed.
38b2c076
PE
9537 * dired.c (directory_files_internal, file_name_completion):
9538 Rename locals to avoid shadowing.
9539
15206ed9
PE
9540 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9541 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9542 dired.c's scmp function, had undefined behavior.
9543 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9544 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9545 * buffer.h: ... to here, because these macros use current_buffer,
9546 and the new implementation with inline functions needs to have
9547 current_buffer in scope now, rather than later when the macros
9548 are used.
9549 (downcase, upcase1): New static inline functions.
9550 (DOWNCASE, UPCASE1): Reimplement using these functions.
9551 This avoids undefined behavior in expressions like
9552 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9553 from race conditions in accessing the global variables
9554 case_temp1 and case_temp2.
9555 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9556 * lisp.h (case_temp1, case_temp2): Remove their decls.
9557 * character.h (ASCII_CHAR_P): Move from here ...
9558 * lisp.h: ... to here, so that the inline functions mentioned
9559 above can use them.
9560
4a6bea26
PE
9561 * dired.c (directory_files_internal_unwind): Now static.
9562
f14b7e14
PE
9563 * fileio.c (file_name_as_directory, directory_file_name):
9564 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9565 Now static.
2893f146
PE
9566 (file_name_as_directory): Use const pointers when appropriate.
9567 (Fexpand_file_name): Likewise. In particular, newdir might
9568 point at constant storage, so make it a const pointer.
fd4ead52 9569 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9570 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9571 signedness issues.
f839df0c
PE
9572 (Fset_file_times, Finsert_file_contents, auto_save_error):
9573 Rename locals to avoid shadowing.
f14b7e14 9574
5716756e 9575 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9576 (Ftry_completion, Fall_completions): Rename or remove locals
9577 to avoid shadowing.
5716756e 9578
b4c3046a
PE
9579 * marker.c (bytepos_to_charpos): Remove; unused.
9580
b45db522
PE
9581 * lisp.h (verify_bytepos, count_markers): New decls,
9582 so that gcc does not warn that these functions aren't declared.
9583
85876d07
PE
9584 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9585 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9586 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9587 (copy_text): Remove unused local var.
85876d07 9588
03d78a21 9589 * filelock.c (within_one_second): Now static.
b3dd38ab 9590 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9591
5df8f01b
PE
9592 * buffer.c (fix_overlays_before): Mark locals as initialized.
9593 (fix_start_end_in_overlays): Likewise. This function should be
9594 simplified by using pointers-to-pointers, but that's a different
9595 matter.
b1d876f1 9596 (switch_to_buffer_1): Now static.
8f54f30a
PE
9597 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9598 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9599
a70072c9 9600 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9601 Fix pointer signedness issue.
edced198
PE
9602 (sys_subshell): Mark local as volatile if checking for lint,
9603 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9604 (MAXPATHLEN): Define only if needed.
a70072c9 9605
a0977c44
PE
9606 * process.c (serial_open, serial_configure): Move decls from here ...
9607 * systty.h: ... to here, so that they can be checked.
9608
a884fdcc
PE
9609 * fns.c (get_random, seed_random): Move extern decls from here ...
9610 * lisp.h: ... to here, so that they can be checked.
9611
604efe86 9612 * sysdep.c (reset_io): Now static.
b8950c94 9613 (wait_for_termination_signal): Remove; unused.
604efe86 9614
38fc62d9
PE
9615 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9616 (copy_keymap_item, append_key, push_text_char_description):
9617 Now static.
1004a21a 9618 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9619 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9620 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9621 (describe_map_tree):
9622 Rename locals to avoid shadowing.
38fc62d9 9623
2f2650da
PE
9624 * keyboard.c: Declare functions static if they are not used elsewhere.
9625 (echo_char, echo_dash, cmd_error, top_level_2):
9626 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9627 (read_char, kbd_buffer_get_event, make_lispy_position):
9628 (make_lispy_event, make_lispy_movement, apply_modifiers):
9629 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9630 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9631 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9632 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9633 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9634
a053e86c 9635 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9636 (mark_kboards): Move decl here ...
9637 * alloc.c (mark_kboards): ... from here.
a053e86c 9638
4752793e
PE
9639 * lisp.h (force_auto_save_soon): New decl.
9640
74f10ca7 9641 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9642 (DEFINE_DUMMY_FUNCTION): New macro.
9643 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9644 Use it.
c03cd23f
PE
9645 (main): Add casts to avoid warnings
9646 if GCC considers string literals to be constants.
74f10ca7 9647
022e70d4
PE
9648 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9649
59d6fe83
PE
9650 * dbusbind.c: Pointer signedness fixes.
9651 (xd_signature, xd_append_arg, xd_initialize):
9652 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9653 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9654 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9655 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9656
78320123
PE
9657 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9658 if GCC considers string literals to be constants.
49cebcca 9659 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9660
35ac2a97
SM
96612011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9662
fb103ca9
SM
9663 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9664 (print_preprocess, print_object): New macro to fix last change.
9665
35ac2a97
SM
9666 * print.c (print_preprocess): Don't forget font objects.
9667
62973b41
JB
96682011-03-16 Juanma Barranquero <lekktu@gmail.com>
9669
9670 * emacs.c (USAGE3): Doc fixes.
9671
0e48bb22
AS
96722011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9673
9674 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9675 structure.
9676
7684e57b
JB
96772011-03-14 Juanma Barranquero <lekktu@gmail.com>
9678
9679 * lisp.h (VWindow_system, Qfile_name_history):
9680 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9681 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9682 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9683
9684 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9685 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9686
9687 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9688 * w32console.c (detect_input_pending, read_input_pending)
9689 (encode_terminal_code):
9690 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9691 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9692 (w32_system_caret_y, Qfile_name_history):
9693 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9694 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9695 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9696 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9697 * w32proc.c (Qlocal, report_file_error):
9698 * w32term.c (Vwindow_system, updating_frame):
9699 * w32uniscribe.c (initialized, uniscribe_font_driver):
9700 Remove unneeded extern declarations.
9701
2aa46d6c
CY
97022011-03-14 Chong Yidong <cyd@stupidchicken.com>
9703
c96bbc66 9704 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9705
cffc6f3b
CY
97062011-03-13 Chong Yidong <cyd@stupidchicken.com>
9707
9708 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9709 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9710 These macros can no longer be used for assignment.
9711
44f230aa
SM
9712 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9713 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9714 (record_buffer_markers, fetch_buffer_markers): New functions for
9715 recording and fetching special buffer markers.
9716 (set_buffer_internal_1, set_buffer_temp): Use them.
9717
9718 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9719
9720 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9721
9722 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9723 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9724
9725 * xdisp.c (hscroll_window_tree):
9726 (reconsider_clip_changes): Use PT instead of BUF_PT.
9727
d251f04b
EZ
97282011-03-13 Eli Zaretskii <eliz@gnu.org>
9729
9730 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9731 $(EMACS_ROOT)/lib/intprops.h.
9732
f0c77cd1
PE
97332011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9734
3eca4629
PE
9735 Fix more problems found by GCC 4.5.2's static checks.
9736
7c86ee98
PE
9737 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9738 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9739 (xg_free_frame_widgets): Make it clear that a local variable is
9740 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9741 (gdk_window_get_screen): Make it clear that this macro is needed
9742 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9743 (int_gtk_range_get_value): New function, which avoids a diagnostic
9744 from gcc -Wbad-function-cast.
9745 (xg_set_toolkit_scroll_bar_thumb): Use it.
9746 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9747 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9748 (get_utf8_string, xg_get_file_with_chooser):
9749 Rename locals to avoid shadowing.
9750 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9751
41729b81
PE
9752 * xgselect.c (xg_select): Remove unused var.
9753
f0c77cd1
PE
9754 * image.c (four_corners_best): Mark locals as initialized.
9755 (gif_load): Initialize transparent_p to zero (Bug#8238).
9756 Mark another local as initialized.
ec6cf4c6 9757 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9758
ce0ad53d 9759 * image.c (clear_image_cache): Now static.
d5d5a617 9760 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9761 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9762 (x_edge_detection): Remove unnecessary cast that
9763 gcc -Wbad-function-cast diagnoses.
2037898d 9764 (gif_load): Fix pointer signedness.
6ae141d6
PE
9765 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9766 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9767
33383987 97682011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9769
d32df629
PE
9770 Improve quality of tests for time stamp overflow.
9771 For example, without this patch (encode-time 0 0 0 1 1
9772 1152921504606846976) returns the obviously-bogus value (-948597
9773 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9774 reports time overflow. See
9775 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9776 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9777 * editfns.c: Include limits.h and intprops.h.
9778 (TIME_T_MIN, TIME_T_MAX): New macros.
9779 (time_overflow): Move earlier, to before first use.
9780 (hi_time, lo_time): New functions, for an accurate test for
9781 out-of-range times.
9782 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9783 (Fget_internal_run_time): Don't assume time_t fits in int.
9784 (make_time): Use list2 instead of Fcons twice.
9785 (Fdecode_time): More accurate test for out-of-range times.
9786 (check_tm_member): New function.
9787 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9788 (lisp_time_argument): Don't rely on undefined left-shift and
9789 right-shift behavior when checking for time stamp overflow.
8be6f318 9790
fe31d94c
PE
9791 * editfns.c (time_overflow): New function, refactoring common code.
9792 (Fformat_time_string, Fdecode_time, Fencode_time):
9793 (Fcurrent_time_string): Use it.
9794
8be6f318
PE
9795 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9796 * dired.c (make_time): Move to ...
9797 * editfns.c (make_time): ... here.
9798 * systime.h: Note the move.
9799
09d9db2c 98002011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9801
126bc0dc
YM
9802 * fringe.c (update_window_fringes): Remove unused variables.
9803
c47cbdfd
YM
9804 * unexmacosx.c (copy_data_segment): Also copy __got section.
9805 (Bug#8223)
9806
7ac80be9
EZ
98072011-03-12 Eli Zaretskii <eliz@gnu.org>
9808
c96bbc66 9809 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9810 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9811 Constify `char *' arguments and their references according to
9812 prototypes in tparam.h.
9813
ecb0f94d 9814 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9815
7ac80be9
EZ
9816 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9817 Adapt all references accordingly.
9818
9819 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9820
ef1fd07e
TT
98212011-03-11 Tom Tromey <tromey@redhat.com>
9822
9823 * buffer.c (syms_of_buffer): Remove obsolete comment.
9824
7ef4b50c
EZ
98252011-03-11 Eli Zaretskii <eliz@gnu.org>
9826
9827 * termhooks.h (encode_terminal_code): Declare prototype.
9828
9829 * msdos.c (encode_terminal_code): Don't declare prototype.
9830
9831 * term.c (encode_terminal_code): Now external again, used by
9832 w32console.c and msdos.c.
9833
44f230aa
SM
9834 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9835 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9836
4b1ec863 98372011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9838
1714f52b 9839 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9840
4b1ec863
PE
9841 * fringe.c (update_window_fringes): Mark locals as initialized
9842 (Bug#8227).
9843 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9844
524c7aa6
PE
9845 * alloc.c (mark_fringe_data): Move decl from here ...
9846 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9847 to check its interface.
9848 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9849
a5c0af81 9850 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9851 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9852 (fontset_font): Mark local as initialized.
a9a06e0b 9853 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9854
b4716021
PE
9855 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9856
811e9bac 9857 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9858 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9859 (x_own_selection, Fx_disown_selection_internal): Rename locals
9860 to avoid shadowing.
9861 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9862
7e3ab302
PE
9863 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9864 so that the caller can use some name other than gcpro1.
9865 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9866 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9867 (Fx_backspace_delete_keys_p):
9868 Use them to avoid shadowing, and rename vars to avoid shadowing.
9869 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9870 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9871 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9872 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9873 Remove unused locals.
7e3ab302
PE
9874 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9875 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9876 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9877 macros.
f78faa98 9878
e2b13473
PE
9879 * xterm.h (x_mouse_leave): New decl.
9880
77f23912
PE
9881 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9882 Remove unused functions.
cdf4ba58
PE
9883 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9884 (x_calc_absolute_position): Now static.
7411c686 9885 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9886 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9887 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9888 unless they are used.
38d0b34a
PE
9889 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9890 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9891 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9892 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9893 (x_error_catcher, x_connection_closed, x_error_handler):
9894 (x_error_quitter, xembed_send_message, x_iconify_frame):
9895 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9896 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9897 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9898
44f230aa
SM
9899 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9900 Rename or move locals to avoid shadowing.
6b463e58 9901 (tty_defined_color, merge_face_heights): Now static.
5967d051 9902 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9903 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9904 does not deduce is never used uninitialized.
73719eba
PE
9905 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9906 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9907
426994c3 9908 * terminal.c (store_terminal_param): Now static.
5489860b 9909
032f1620 9910 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9911 (set_frame_menubar): Remove unused local.
d4323972 9912 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9913 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9914 since they might point to immutable storage.
281585b0
PE
9915 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9916 since it's unused otherwise.
032f1620 9917
367c19e5 9918 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9919 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9920 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9921 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9922 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9923 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9924 does not deduce are never used uninitialized.
70739cbe 9925
07b48fa9
PE
9926 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9927
8868a238 9928 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9929 * window.c (window_loop, size_window):
9930 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9931
7e5cf297 9932 * window.c (display_buffer): Now static.
d6550a9f
PE
9933 (size_window): Mark variables that gcc -Wuninitialized
9934 does not deduce are never used uninitialized.
a586633d
PE
9935 * window.h (check_all_windows): New decl, to forestall
9936 gcc -Wmissing-prototypes diagnostic.
5b555da1 9937 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9938
f6095868
PE
9939 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9940 shadowing.
9941 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9942 Include <limits.h>.
9943 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9944 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9945 (load_charset_map): Mark variables that gcc -Wuninitialized
9946 does not deduce are never used uninitialized.
53df7c11 9947 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9948
f38b440c
PE
9949 * coding.c (coding_set_source, coding_set_destination):
9950 Use "else { /* comment */ }" rather than "else /* comment */;"
9951 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9952 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9953 a block, when the outer 'i' will do.
9954 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9955 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9956 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9957 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9958 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9959 Rename locals to avoid shadowing.
9960 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9961 * coding.c (emacs_mule_char, encode_invocation_designation):
9962 Now static, since they're not used elsewhere.
413bb2db 9963 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9964 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9965 (decode_coding_emacs_mule): Mark variables that gcc
9966 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9967 (detect_coding_iso_2022): Initialize a local variable that might
9968 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9969 this initialization is needed. (Bug#8211)
5f58e762
PE
9970 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9971 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9972 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9973 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9974 Remove unused macros.
f38b440c 9975
232b38b9 9976 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9977 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9978 * character.c (string_count_byte8): Likewise.
232b38b9 9979
fb90da1b
PE
9980 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9981 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9982
fb93dbc2
PE
9983 * chartab.c (copy_sub_char_table): Now static, since it's not used
9984 elsewhere.
5c156ace
PE
9985 (sub_char_table_ref_and_range, char_table_ref_and_range):
9986 Rename locals to avoid shadowing.
bbcd0949 9987 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9988
7d3b3862 9989 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9990 (BIDI_BOB): Remove unused macro.
7d3b3862 9991
6be7d3da
PE
9992 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9993 deduce are never used uninitialized.
c2ed9c8b 9994 * term.c (encode_terminal_code): Likewise.
6be7d3da 9995
75f8807f 9996 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9997
50938595
PE
9998 * tparam.h: New file.
9999 * term.c, tparam.h: Include it.
10000 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10001 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10002 Move these decls to tparam.h, and make them agree with what
10003 is actually in tparam.c. The previous trick of using incompatible
10004 decls in different modules does not conform to the C standard.
10005 All callers of tparam changed to use tparam's actual API.
10006 * tparam.c (tparam1, tparam, tgoto):
10007 Use const pointers where appropriate.
10008
fbceeba2
PE
10009 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10010 * cm.h (struct cm): Likewise.
10011 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10012 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10013 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10014 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10015 (turn_on_face, init_tty): Likewise.
10016 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 10017
7f3f1250
PE
10018 * term.c (term_mouse_position): Rename local to avoid shadowing.
10019
e6ca6543
PE
10020 * alloc.c (mark_ttys): Move decl from here ...
10021 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10022
c40f8d15
AS
100232011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10024
10025 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10026
cfe0661d
JB
100272011-03-09 Juanma Barranquero <lekktu@gmail.com>
10028
10029 * search.c (compile_pattern_1): Remove argument regp, unused since
10030 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10031 (compile_pattern): Don't pass it.
10032
0afb4571
J
100332011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10034
10035 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10036 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10037 for ! HAVE_GTK3.
10038 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10039
10040 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10041
10042 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10043 gdk_window_get_screen, gdk_window_get_geometry,
10044 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10045 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10046 (xg_get_pixbuf_from_pixmap): New function.
10047 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10048 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10049 Call xg_get_pixbuf_from_pixmap instead of
10050 gdk_pixbuf_get_from_drawable.
10051 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10052 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10053 (xg_check_special_colors): Use GtkStyleContext and its functions
10054 for HAVE_GTK3.
10055 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10056 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10057 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10058 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10059 Call gtk_widget_get_preferred_size.
0afb4571
J
10060 (xg_frame_resized): gdk_window_get_geometry only takes 5
10061 parameters.
44f230aa
SM
10062 (xg_win_to_widget, xg_event_is_for_menubar):
10063 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10064 (xg_set_widget_bg): New function.
10065 (delete_cb): New function.
895009e1 10066 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10067 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10068 (xg_set_background_color): Call xg_set_widget_bg.
10069 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10070 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10071 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10072 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10073 if ! HAVE_GTK3.
10074 (update_frame_tool_bar): Call gtk_widget_hide.
10075 (xg_initialize): Use GDK_KEY_g.
10076
10077 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10078 if ! HAVE_GTK3
10079 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10080
10081 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10082 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10083 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10084
1c2cc4ef
JB
100852011-03-08 Juanma Barranquero <lekktu@gmail.com>
10086
10087 * w32xfns.c (select_palette): Check success of RealizePalette against
10088 GDI_ERROR, not zero.
10089
33383987 10090See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10091
10092;; Local Variables:
10093;; coding: utf-8
aac0c6e3
MR
10094;; End:
10095
2f097256 10096 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10097
10098 This file is part of GNU Emacs.
10099
10100 GNU Emacs is free software: you can redistribute it and/or modify
10101 it under the terms of the GNU General Public License as published by
10102 the Free Software Foundation, either version 3 of the License, or
10103 (at your option) any later version.
10104
10105 GNU Emacs is distributed in the hope that it will be useful,
10106 but WITHOUT ANY WARRANTY; without even the implied warranty of
10107 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10108 GNU General Public License for more details.
10109
10110 You should have received a copy of the GNU General Public License
10111 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.