* lisp/subr.el (make-progress-reporter): Add "..." by default.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
40087514 12011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2
57f53182
PE
3 Malloc failure behavior now depends on size of allocation.
4 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5 * lisp.h: Change signatures accordingly.
6 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7 All callers changed. (Bug#8762)
8
9 * gnutls.c: Use Emacs's memory allocators.
10 Without this change, the gnutls library would invoke malloc etc.
11 directly, which causes problems on non-SYNC_INPUT hosts, and which
12 runs afoul of improving memory_full behavior. (Bug#8761)
13 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
14 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
15 xfree instead of the default malloc, realloc, free.
16 (Fgnutls_boot): No need to check for memory allocation failure,
17 since xmalloc does that for us.
18
ac32cd99 19 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
20 * category.c (hash_get_category_set):
21 * ccl.c (ccl_driver):
22 * charset.c (Fdefine_charset_internal):
23 * charset.h (struct charset.hash_index):
24 * composite.c (get_composition_id, gstring_lookup_cache)
25 (composition_gstring_put_cache):
26 * composite.h (struct composition.hash_index):
27 * dispextern.h (struct image.hash):
28 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
29 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
30 (hashfn_equal, hashfn_user_defined, make_hash_table)
31 (maybe_resize_hash_table, hash_lookup, hash_put)
32 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
33 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
34 (Fsxhash, Fgethash, Fputhash, Fmaphash):
35 * image.c (make_image, search_image_cache, lookup_image)
36 (xpm_put_color_table_h):
37 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 38 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
39 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
40 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
41 * alloc.c (allocate_vectorlike):
42 Check for overflow in vector size calculations.
43 * ccl.c (ccl_driver):
44 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
45 * fns.c, image.c: Remove unnecessary static decls that would otherwise
46 need to be updated by these changes.
40087514
PE
47 * fns.c (make_hash_table, maybe_resize_hash_table):
48 Check for integer overflow with large hash tables.
0de4bb68
PE
49 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
50 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
51 (SXHASH_REDUCE): New macro.
52 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
53 Use it instead of discarding useful hash info with large hash values.
54 (sxhash_float): New function.
55 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
56 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
57 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
58 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
59 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
60 Adjust signatures to match updated version of code.
61 (consing_since_gc): Now EMACS_INT, since a single hash table can
62 use more than INT_MAX bytes.
63
698d32e2
DN
642011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
65
66 Make it possible to build with GCC-4.6+ -O2 -flto.
67
68 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
69
fd6fa53f
SM
702011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
71
72 * minibuf.c (get_minibuffer, read_minibuf_unwind):
73 Call minibuffer-inactive-mode.
74
864db017
JB
752011-05-31 Juanma Barranquero <lekktu@gmail.com>
76
77 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
78 Update dependencies.
79
2ad0baf4
DN
802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
81
82 * data.c (init_data): Remove code for UTS, this system is not
83 supported anymore.
84
4fcc2638
DN
852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
86
87 Don't force ./temacs to start in terminal mode.
88
89 * frame.c (make_initial_frame): Initialize faces in all cases, not
90 only when CANNOT_DUMP is defined.
91 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
92
c56e0fd5
DN
932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
94
95 * dispnew.c (add_window_display_history): Use const for the string
96 pointer. Remove declaration, not needed.
97
333d54da 982011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 99
55d4c1b2 100 Use 'inline', not 'INLINE'.
333d54da 101 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
102 * alloc.c, fontset.c (INLINE): Remove.
103 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
104 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
105 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
106 * gmalloc.c (register_heapinfo): Use inline unconditionally.
107 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
108
738db178
DN
1092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
110
111 Make it possible to run ./temacs.
112
113 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
114 syms_of_callproc does the same thing. Remove test for
115 "initialized", do it in the caller.
116 * emacs.c (main): Avoid calling set_initial_environment when dumping.
117
620c53a6
SM
1182011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
119
120 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
121 (read_minibuf): Use get_minibuffer.
122 (syms_of_minibuf): Use DEFSYM.
123 (Qmetadata): New var.
124 * data.c (Qbuffer): Don't make it static.
125 (syms_of_data): Use DEFSYM.
126
e003a292
PE
1272011-05-31 Paul Eggert <eggert@cs.ucla.edu>
128
129 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
130 (CCL_CODE_MIN): New macro.
131
ed008a6d
PE
1322011-05-30 Paul Eggert <eggert@cs.ucla.edu>
133
3687c2ef
PE
134 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
135
ed008a6d
PE
136 * eval.c (Qdebug): Now static.
137 * lisp.h (Qdebug): Remove decl. This reverts a part of the
138 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
139 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
140
d66c4c7c
CY
1412011-05-29 Chong Yidong <cyd@stupidchicken.com>
142
143 * image.c: Various fixes to ImageMagick code comments.
144 (Fimagemagick_types): Doc fix.
145
5fbc2025
PE
1462011-05-29 Paul Eggert <eggert@cs.ucla.edu>
147
0196f88a
PE
148 Minor fixes prompted by GCC 4.6.0 warnings.
149
150 * xselect.c (converted_selections, conversion_fail_tag): Now static.
151
5fbc2025
PE
152 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
153 (x_clipboard_manager_save_all): Move extern decl to ...
154 * xterm.h: ... here, so that it can be checked for consistency.
155
1dd3c2d9
CY
1562011-05-29 Chong Yidong <cyd@stupidchicken.com>
157
158 * xselect.c (x_clipboard_manager_save_frame)
159 (x_clipboard_manager_save_all): New functions.
160 (Fx_clipboard_manager_save): Lisp function deleted.
161
162 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
163 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
164
165 * xterm.h: Update prototype.
166
5ba6571d
WX
1672011-05-28 William Xu <william.xwl@gmail.com>
168
169 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
170 exiting (Bug#8239).
171
3eaff834
JM
1722011-05-28 Jim Meyering <meyering@redhat.com>
173
e1900994 174 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
175 * fns.c (to_uchar): Define.
176 (crypto_hash_function): Use it to convert some newly-signed
177 variables to unsigned, to avoid sign-extension bugs. For example,
178 without this change, (md5 "truc") would evaluate to
179 45723a2aff78ff4fff7fff1114760e62 rather than the expected
180 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 181 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 182
0f6990a7
PE
1832011-05-27 Paul Eggert <eggert@cs.ucla.edu>
184
185 Integer overflow fixes.
c8a9ca5a 186
08686060
PE
187 * dbusbind.c: Serial number integer overflow fixes.
188 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
189 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
190 to hold a serial number that is too large for a fixnum.
191 (Fdbus_method_return_internal, Fdbus_method_error_internal):
192 Check for serial numbers out of range. Decode any serial number
59568bf0 193 that was so large that it became a float. (Bug#8722)
08686060 194
2d1fc3c7
PE
195 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
196 (Fdbus_call_method, Fdbus_call_method_asynchronously):
197 Use XFASTINT rather than XUINT when numbers are nonnegative.
198 (xd_append_arg, Fdbus_method_return_internal):
199 (Fdbus_method_error_internal): Likewise. Also, for unsigned
200 arguments, check that Lisp number is nonnegative, rather than
59568bf0 201 silently wrapping negative numbers around. (Bug#8722)
30217ff0 202 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 203 (Bug#8722)
2d1fc3c7 204
c8a9ca5a
PE
205 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
206
519e1d69
PE
207 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
208
30569699
PE
209 ccl: add integer overflow checks
210 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
211 (IN_INT_RANGE): New macros.
212 (ccl_driver): Use them to check for integer overflow when
213 decoding a CCL program. Many of the new checks are whether XINT (x)
214 fits in int; it doesn't always, on 64-bit hosts. The new version
215 doesn't catch all possible integer overflows, but it's an
847044ea 216 improvement. (Bug#8719)
30569699 217
c11285dc
PE
218 * alloc.c (make_event_array): Use XINT, not XUINT.
219 There's no need for unsigned here.
220
fdccd48e
PE
221 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
222 This follows up to the 2011-05-06 change that substituted uintptr_t
223 for EMACS_INT. This case wasn't caught back then.
224
37910ab2
PE
225 Rework Fformat to avoid integer overflow issues.
226 * editfns.c: Include <float.h> unconditionally, as it's everywhere
227 now (part of C89). Include <verify.h>.
228 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
229 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
230 (Fformat): Avoid the prepass trying to compute sizes; it was only
231 approximate and thus did not catch overflow reliably. Instead, walk
232 through the format just once, formatting and computing sizes as we go,
233 checking for integer overflow at every step, and allocating a larger
234 buffer as needed. Keep track separately whether the format is
235 multibyte. Keep only the most-recently calculated precision, rather
236 than them all. Record whether each argument has been converted to
237 string. Use EMACS_INT, not int, for byte and char and arg counts.
238 Support field widths and precisions larger than INT_MAX. Avoid
239 sprintf's undefined behavior with conversion specifications such as %#d
240 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
241 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
242 formatting out-of-range floating point numbers with int
243 formats. (Bug#8668)
244
2e6578fb
PE
245 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
246
0ae6bdee
PE
247 * data.c: Avoid integer truncation in expressions involving floats.
248 * data.c: Include <intprops.h>.
249 (arith_driver): When there's an integer overflow in an expression
250 involving floating point, convert the integers to floating point
251 so that the resulting value does not suffer from catastrophic
252 integer truncation. For example, on a 64-bit host (* 4
253 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
254 Do not rely on undefined behavior after integer overflow.
255
de883a70
PE
256 merge count_size_as_multibyte, parse_str_to_multibyte
257 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 258 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
259 Check for integer overflow.
260 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
261 since it's now a duplicate of the other. This is more of
262 a character than a buffer op, so better that it's in character.c.
263 * fns.c, print.c: Adjust to above changes.
264
2ff916cb
PE
2652011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
266
267 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
268
f1b54466
PE
2692011-05-27 Paul Eggert <eggert@cs.ucla.edu>
270
fb1ac845
PE
271 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
272 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
273 (x_clipboard_manager_save): Now static.
274 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
275
f1b54466
PE
276 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
277 (crypto_hash_function): Now static.
278 Fix pointer signedness problems. Avoid unnecessary initializations.
279
a9f737ee
CY
2802011-05-27 Chong Yidong <cyd@stupidchicken.com>
281
282 * termhooks.h (Vselection_alist): Make it terminal-local.
283
284 * terminal.c (create_terminal): Initialize it.
285
286 * xselect.c: Support for clipboard managers.
287 (Vselection_alist): Move to termhooks.h as terminal-local var.
288 (LOCAL_SELECTION): New macro.
289 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
290 (symbol_to_x_atom): Remove gratuitous arg.
291 (x_handle_selection_request, lisp_data_to_selection_data)
292 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
293 (x_own_selection, x_get_local_selection, x_convert_selection):
294 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
295 (some_frame_on_display): Delete unused function.
296 (Fx_own_selection_internal, Fx_get_selection_internal)
297 (Fx_disown_selection_internal, Fx_selection_owner_p)
298 (Fx_selection_exists_p): New optional frame arg.
299 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
300 (x_handle_selection_clear): Don't treat other terminals with the
301 same keyboard specially. Use the terminal-local Vselection_alist.
302 (x_clear_frame_selections): Use Frun_hook_with_args.
303
304 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
305
306 * xterm.h: Add support for those atoms.
307
e067f0c1
CY
3082011-05-26 Chong Yidong <cyd@stupidchicken.com>
309
310 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
311 (converted_selections, conversion_fail_tag): New global variables.
312 (x_selection_request_lisp_error): Free the above.
313 (x_get_local_selection): Remove unnecessary code.
314 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
315 of converted selections stored in converted_selections.
316 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
317 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
318 (x_convert_selection): New function.
319 (x_handle_selection_event): Simplify.
320 (x_get_foreign_selection): Don't ignore incoming requests while
321 waiting for an answer; this will fail when we implement
322 SAVE_TARGETS, and seems unnecessary anyway.
323 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
324 (Vx_sent_selection_functions): Doc fix.
325
0f4aebc0
LL
3262011-05-26 Leo Liu <sdl.web@gmail.com>
327
328 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
329
e61124cd
YM
3302011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
331
332 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
333
334 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
335 for fringe update if it has periodic bitmap.
336 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
337 and fringe_bitmap_periodic_p.
338
339 * fringe.c (get_fringe_bitmap_data): New function.
340 (draw_fringe_bitmap_1, update_window_fringes): Use it.
341 (update_window_fringes): Record periodicity of fringe bitmap in glyph
342 row. Mark glyph row for fringe update if periodicity changed.
343
344 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
345 for fringe update unless it has periodic bitmap.
346
f16d9837
KH
3472011-05-25 Kenichi Handa <handa@m17n.org>
348
349 * xdisp.c (get_next_display_element): Set correct it->face_id for
350 a static composition.
351
e1b90ef6
LL
3522011-05-24 Leo Liu <sdl.web@gmail.com>
353
354 * deps.mk (fns.o):
355 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
356
357 * fns.c (crypto_hash_function, Fsha1): New function.
358 (Fmd5): Use crypto_hash_function.
359 (syms_of_fns): Add Ssha1.
360
7400048f
PE
3612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
362
363 * gnutls.c: Remove unused macros.
364 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
365 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
366 Remove macros that are defined and never used.
367 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
368
abb71cf4
CY
3692011-05-22 Chong Yidong <cyd@stupidchicken.com>
370
371 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
372 (Fx_get_selection_internal): Minor cleanup.
373 (Fx_own_selection_internal): Rename arguments for consistency with
374 select.el.
375
6307db39
PE
3762011-05-22 Paul Eggert <eggert@cs.ucla.edu>
377
378 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
379
f3d4e0a4
CY
3802011-05-22 Chong Yidong <cyd@stupidchicken.com>
381
382 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
383
4d8ade89
YM
3842011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
385
386 * dispnew.c (scrolling_window): Don't exclude the case that the
387 last enabled row in the desired matrix touches the bottom boundary.
388
32078c8d
GM
3892011-05-21 Glenn Morris <rgm@gnu.org>
390
391 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
392 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
393 and add some more files.
32078c8d 394
7285dc67
EZ
3952011-05-20 Eli Zaretskii <eliz@gnu.org>
396
397 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
398 report_file_error introduced by the change from 2011-05-07.
399
89d1bd22
PE
4002011-05-20 Paul Eggert <eggert@cs.ucla.edu>
401
402 * systime.h (Time): Define only if emacs is defined.
403 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
404 where the include path doesn't have X11/X.h by default. See
405 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
406
e23640bb 4072011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
408
409 * composite.c (find_automatic_composition): Fix previous change.
410
b9704ad9
GM
4112011-05-20 Glenn Morris <rgm@gnu.org>
412
413 * lisp.mk: New file, split from Makefile.in.
414 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
415 (shortlisp): Remove.
416 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
417
4a720484
GM
4182011-05-19 Glenn Morris <rgm@gnu.org>
419
420 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
421 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
422 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
423 (lisp): Set the order to that of loadup.el.
424 (shortlisp): Make it a copy of $lisp.
425 (SOME_MACHINE_LISP): Remove.
426 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
427 Use just $shortlisp, not $SOME_MACHINE_LISP too.
428
a28d4396
KH
4292011-05-18 Kenichi Handa <handa@m17n.org>
430
431 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
432 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
433 (find_automatic_composition): Mostly rewrite for efficiency.
434
a2b1fa8e
JB
4352011-05-18 Juanma Barranquero <lekktu@gmail.com>
436
437 * makefile.w32-in: Update dependencies.
438
8e1f5610
CS
4392011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
440
441 * menu.c: Include limits.h (fixes the MS-Windows build broken by
442 revision 104625).
443
7025ee00 4442011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 445
cdfa6eab
PE
446 Fix some integer overflow issues, such as string length overflow.
447
06d6db33
PE
448 * insdel.c (count_size_as_multibyte): Check for string overflow.
449
2b4560a8
PE
450 * character.c (lisp_string_width): Check for string overflow.
451 Use EMACS_INT, not int, for string indexes and lengths; in
452 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
453 the resulting string length overflows an EMACS_INT; instead,
454 report a string overflow if no precision given. When checking for
455 precision exhaustion, use a check that cannot possibly have
456 integer overflow. (Bug#8675)
457 * character.h (lisp_string_width): Adjust to new signature.
458
cb93f9be
PE
459 * alloc.c (string_overflow): New function.
460 (Fmake_string): Use it. This doesn't change behavior, but saves
461 a few bytes and will simplify future changes.
462 * character.c (string_escape_byte8): Likewise.
463 * lisp.h (string_overflow): New decl.
464
1a1f3366
PE
465 Fixups, following up to the user-interface timestamp change.
466 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
467 for UI timestamps, instead of unsigned long.
9fbd6841
PE
468 * msdos.c (mouse_get_pos): Likewise.
469 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
470 * w32gui.h (Time): Define by including "systime.h" rather than by
471 declaring it ourselves. (Bug#8664)
472
d4e3e4d3
PE
473 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
474 * image.c (clear_image_cache): Likewise.
475
f6a24d19
PE
476 * term.c (term_mouse_position): Don't assume time_t wraparound.
477
08dc5ae6
PE
478 Be more systematic about user-interface timestamps.
479 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
480 and sometimes 'EMACS_UINT', to represent these timestamps.
481 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
482 This makes the code easier to follow, and makes it easier to catch
483 integer overflow bugs such as Bug#8664.
484 * frame.c (Fmouse_position, Fmouse_pixel_position):
485 Use Time, not unsigned long, for user-interface timestamps.
486 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
487 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
488 * keyboard.h (last_event_timestamp): Likewise.
489 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
490 * menu.h (xmenu_show): Likewise.
491 * term.c (term_mouse_position): Likewise.
492 * termhooks.h (struct input_event.timestamp): Likewise.
493 (struct terminal.mouse_position_hook): Likewise.
494 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
495 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
496 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
497 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
498 what it was before.
499 * menu.h, termhooks.h: Include "systime.h", for Time.
500
8e55734a
PE
501 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
502 Don't assume that the difference between two unsigned long values
503 can fit into an integer. At this point, we know button_down_time
504 <= event->timestamp, so the difference must be nonnegative, so
505 there's no need to cast the result if double-click-time is
506 nonnegative, as it should be; check that it's nonnegative, just in
507 case. This bug is triggered when events are more than 2**31 ms
86db42d2 508 apart (about 25 days). (Bug#8664)
8e55734a 509
841f1b75 510 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 511 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 512
3e26f69c
PE
513 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
514 that always fit in int. Use a sentinel instead of a counter, to
515 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
516 * frame.h (struct frame): Use int for menu_bar_items_used
517 instead of EMACS_INT, since it always fits in int.
3e26f69c 518
5cc152c0
PE
519 * menu.c (grow_menu_items): Check for int overflow.
520
d89eb65e
PE
521 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
522
5235bd3e
PE
523 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
524 Before, the code was not consistent. These values cannot exceed
525 2**31 - 1 so there's no need to make them unsigned.
526 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
527 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
528 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
529 as modifiers.
530 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
531
bc827e23
PE
532 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
533 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
534 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
535 presumably because the widths might not match.
536
78eb494e
PE
537 * window.c (size_window): Avoid needless test at loop start.
538
04f2d78b
CB
5392011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
540
541 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
542
d2fc7e3d 5432011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
544
545 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
546
d2fc7e3d 5472011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
548
549 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
550 `width' to `bar_area_x' and `bar_area_width', respectively.
551 (x_scroll_run): Take account of fringe background extension.
552
04f2d78b
CB
553 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
554 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
555 `bar_area_width', respectively.
556 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
557 background extension.
558
79b70037
GM
5592011-05-10 Jim Meyering <meyering@redhat.com>
560
561 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
562
2f142cc5
JB
5632011-05-10 Juanma Barranquero <lekktu@gmail.com>
564
565 * image.c (Finit_image_library): Return t for built-in image types,
566 like pbm and xbm. (Bug#8640)
567
57679c86
AS
5682011-05-09 Andreas Schwab <schwab@linux-m68k.org>
569
570 * w32menu.c (set_frame_menubar): Fix submenu allocation.
571
888c9e86
EZ
5722011-05-07 Eli Zaretskii <eliz@gnu.org>
573
b0512a1d
EZ
574 * w32console.c (Fset_screen_color): Doc fix.
575 (Fget_screen_color): New function.
576 (syms_of_ntterm): Defsubr it.
577
7285dc67
EZ
578 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
579 unlink the temporary file if Fcall_process didn't create it in the
580 first place.
581 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
582 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
583 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
584 cue to call_process_cleanup not to close that handle.
585
4d3fcc8e
BK
5862011-05-07 Ben Key <bkey76@gmail.com>
587
588 * makefile.w32-in: The bootstrap-temacs rule now makes use of
589 one of two shell specific rules, either bootstrap-temacs-CMD or
590 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
591 to the previous implementation of the bootstrap-temacs rule.
592 The bootstrap-temacs-CMD rule is similar to the previous
593 implementation of the bootstrap-temacs rule except that it
594 makes use of the ESC_CFLAGS variable instead of the CFLAGS
595 variable.
596
597 These changes, along with some changes to nt/configure.bat,
598 nt/gmake.defs, and nt/nmake.defs, are required to extend my
599 earlier fix to add support for --cflags and --ldflags options
600 that include quotes so that it works whether make uses cmd or
601 sh as the shell.
602
b4289b64
MA
6032011-05-06 Michael Albinus <michael.albinus@gmx.de>
604
605 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
606 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
607 is a constant.
608 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
609 a string. Handle both cases.
610 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
611 (Fdbus_register_method): Use Qinvalid_function.
612
af4c0e28
JB
6132011-05-06 Juanma Barranquero <lekktu@gmail.com>
614
615 * makefile.w32-in: Update dependencies.
616 (LISP_H): Add inttypes.h and stdin.h.
617 (PROCESS_H): Add unistd.h.
618
c51453d9
EZ
6192011-05-06 Eli Zaretskii <eliz@gnu.org>
620
621 * lread.c: Include limits.h (fixes the MS-Windows build broken by
622 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
623
8ff0ac3c 6242011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 625
4c4b566b
PE
626 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
627
aab2b9b5
PE
628 * term.c (vfatal): Remove stray call to va_end.
629 It's not needed and the C Standard doesn't allow it here anyway.
630
c378da0b
PE
631 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
632 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
633
288b08c7
PE
634 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
635 bytes.
636
e3601888
PE
637 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
638
db6c0e74
PE
639 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
640
dd5963ea
PE
641 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
642
88c9450f
PE
643 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
644
2f9442b8
PE
645 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
646
c032b5f8
PE
647 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
648 * charset.c (Fdefine_charset_internal): Don't initialize
649 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 650 32-bit int (Bug#8600).
a108c10b
PE
651
652 * lread.c (read_integer): Be more consistent with string-to-number.
653 Use string_to_number to do the actual conversion; this avoids
654 rounding errors and fixes some other screwups. Without this fix,
655 for example, #x1fffffffffffffff was misread as -2305843009213693952.
656 (digit_to_number): Move earlier, for benefit of read_integer.
657 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 658 not a digit in any supported base. (Bug#8602)
a108c10b 659
ad5f9eea
PE
660 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
661
aec1708a
PE
662 * dispnew.c (scrolling_window): Return 1 if we scrolled,
663 to match comment at start of function. This also removes a
664 GCC warning about overflow in a 32+64-bit port.
665
47be4ab5
PE
666 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
667
371cac43
PE
668 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
669 Reported by Stefan Monnier in
670 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
671 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
672 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 673
d01a7826
PE
674 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
675 (EMACS_UINTPTR): Likewise, with uintptr_t.
676
7fd47d5c
PE
677 * lisp.h: Prefer 64-bit EMACS_INT if available.
678 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
679 on 32-bit hosts that have 64-bit int, so that they can access
680 large files.
122b0c86
PE
681 However, temporarily disable this change unless the temporary
682 symbol WIDE_EMACS_INT is defined.
7fd47d5c 683
8727937b
PE
684 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
685
8ac068ac
PE
686 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
687 This removes an assumption that EMACS_INT and long are the same
688 width as pointers. The assumption is true for Emacs porting targets
689 now, but we want to make other targets possible.
690 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
691 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
692 In the rest of the code, change types of integers that hold casted
693 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
694 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
695 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
696 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
697 No need to cast type when ORing.
698 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
699 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
700 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
701 assume EMACS_INT is the same width as char *.
702 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
703 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
704 Remove no-longer-needed casts.
705 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
706 (xg_tool_bar_help_callback, xg_make_tool_item):
707 Use EMACS_INTPTR to hold an integer
708 that will be cast to void *; this can avoid a GCC warning
709 if EMACS_INT is not the same width as void *.
710 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
711 * xdisp.c (display_echo_area_1, resize_mini_window_1):
712 (current_message_1, set_message_1):
713 Use a local to convert to proper width without a cast.
714 * xmenu.c (dialog_selection_callback): Likewise.
715
ede49d71
PE
716 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
717 Also, don't assume VALBITS / RAND_BITS is less than 5,
718 and don't rely on undefined behavior when shifting a 1 left into
719 the sign bit.
720 * lisp.h (get_random): Change signature to match.
721
2f30ecd0
PE
722 * lread.c (hash_string): Use size_t, not int, for hash computation.
723 Normally we prefer signed values; but hashing is special, because
724 it's better to use unsigned division on hash table sizes so that
725 the remainder is nonnegative. Also, size_t is the natural width
726 for hashing into memory. The previous code used 'int', which doesn't
727 retain enough info to hash well into very large tables.
728 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
729
2a866e7b
PE
730 * dbusbind.c: Don't possibly lose pointer info when converting.
731 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
732 Use XPNTR rather than XHASH, so that the high-order bits of
733 the pointer aren't lost when converting through void *.
734
51639eac
PE
735 * eval.c (Fautoload): Don't double-shift a pointer.
736
92394119
PE
737 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
738
dbdb9a7c
JB
7392011-05-06 Juanma Barranquero <lekktu@gmail.com>
740
741 * gnutls.c (DEF_GNUTLS_FN):
742 * image.c (DEF_IMGLIB_FN): Make function pointers static.
743
db7a0b4f
AS
7442011-05-05 Andreas Schwab <schwab@linux-m68k.org>
745
746 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
747 marker. (Bug#8610)
748
f7ff1b0f 7492011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
750
751 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
752 New version that can reserve upto 2GB of heap space.
753
f7ff1b0f 7542011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
755
756 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
757
639c109b
TZ
7582011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
759
760 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
761 `gnutls_certificate_set_x509_key_file'.
762
d2127135
JB
7632011-05-05 Juanma Barranquero <lekktu@gmail.com>
764
765 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
766 Update dependencies.
767
e968f4f3
JB
7682011-05-04 Juanma Barranquero <lekktu@gmail.com>
769
770 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
771 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
772 Remove unused parameter `fildes'.
773 * process.c (read_process_output, send_process): Don't pass it.
774
84d358f0
JB
7752011-05-04 Juanma Barranquero <lekktu@gmail.com>
776
777 Fix previous change: the library cache is defined in w32.c.
778 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
779 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
780
0898ca10
JB
7812011-05-04 Juanma Barranquero <lekktu@gmail.com>
782
783 Implement dynamic loading of GnuTLS on Windows.
784
785 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
786 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
787 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
788 Declare.
789
790 * gnutls.c (Qgnutls_dll): Define.
791 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
792 (gnutls_*): Declare function pointers.
793 (init_gnutls_functions): New function to initialize function pointers.
794 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
795 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
796 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
797 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
798 (emacs_gnutls_write, emacs_gnutls_read)
799 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
800 (Fgnutls_available_p): New function.
801 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
802 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
803 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
804
805 * image.c: Include w32.h.
806 (Vimage_type_cache): Delete.
807 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
808 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
809 (w32_delayed_load): Move to w32.c.
810
811 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
812
813 * w32.c (QCloaded_from, Vlibrary_cache): Define.
814 (w32_delayed_load): Move from image.c. When loading a library, record
815 its filename in the :loaded-from property of the library id.
816 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
817 Initialize and staticpro them.
818 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
819
820 * process.c: Include lisp.h before w32.h, not after.
821 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
822 instead of gnutls_record_check_pending.
823
824 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
825
ff4de4aa
TZ
8262011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
827
828 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
829 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
830 as passed in.
831
abe95abb
JD
8322011-05-03 Jan Djärv <jan.h.d@swipnet.se>
833
834 * xterm.c (x_set_frame_alpha): Do not set property on anything
835 else than FRAME_X_OUTER_WINDOW (Bug#8608).
836
e16e55d4
JB
8372011-05-02 Juanma Barranquero <lekktu@gmail.com>
838
839 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
840
bafcf6a5
JB
8412011-05-02 Juanma Barranquero <lekktu@gmail.com>
842
843 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
844 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
845 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
846 (gnutls_global_initialized, Qgnutls_bootprop_priority)
847 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
848 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
849 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
850 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
851 (Qgnutls_bootprop_callbacks_verify): Make static.
852
e7a6747f
AS
8532011-05-01 Andreas Schwab <schwab@linux-m68k.org>
854
19ed11ba
AS
855 * callproc.c: Indentation fixup.
856
e7a6747f 857 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
858 (wait_for_termination, interruptible_wait_for_termination):
859 Move after wait_for_termination_1.
e7a6747f 860
1ef14cb4
LMI
8612011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
862
863 * sysdep.c (interruptible_wait_for_termination): New function
864 which is like wait_for_termination, but allows keyboard
865 interruptions.
866
867 * callproc.c (Fcall_process): Add (:file "file") as an option for
868 the STDOUT buffer.
869 (Fcall_process_region): Ditto.
870
330d880c
EZ
8712011-04-30 Eli Zaretskii <eliz@gnu.org>
872
8db90b73
EZ
873 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
874 rather than `XVECTOR (FOO)->size'.
875
330d880c
EZ
876 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
877 inttypes.h, as a gnulib replacement is used if it not available in
878 system headers.
879
15cbd324
EZ
8802011-04-21 Eli Zaretskii <eliz@gnu.org>
881
882 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
883 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
884 of MOST_POSITIVE_FIXNUM. (Bug#8528)
885
886 * coding.c (coding_alloc_by_realloc): Error out if destination
887 will grow beyond MOST_POSITIVE_FIXNUM.
888 (decode_coding_emacs_mule): Abort if there isn't enough place in
889 charbuf for the composition carryover bytes. Reserve an extra
890 space for up to 2 characters produced in a loop.
891 (decode_coding_iso_2022): Abort if there isn't enough place in
892 charbuf for the composition carryover bytes.
893
8942011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 895
ae940cca
EZ
896 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
897 aborting when %lld or %lll format is passed.
898 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
899 %llo or %llx format is passed. (Bug#8545)
900
03ab8921
EZ
901 * window.c (window_scroll_line_based): Use a marker instead of
902 simple variables to record original value of point. (Bug#7952)
903
afda1437
EZ
904 * doprnt.c (doprnt): Fix the case where a multibyte sequence
905 produced by %s or %c overflows available buffer space. (Bug#8545)
906
f76dee0c
PE
9072011-04-28 Paul Eggert <eggert@cs.ucla.edu>
908
909 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 910 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 911
fdc5744d
JB
9122011-04-28 Juanma Barranquero <lekktu@gmail.com>
913
914 * w32.c (init_environment): Warn about defaulting HOME to C:\.
915
638f053a
JB
9162011-04-28 Juanma Barranquero <lekktu@gmail.com>
917
918 * keyboard.c (Qdelayed_warnings_hook): Define.
919 (command_loop_1): Run `delayed-warnings-hook'
920 if Vdelayed_warnings_list is non-nil.
921 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
922 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
923
d178f871
EZ
9242011-04-28 Eli Zaretskii <eliz@gnu.org>
925
926 * doprnt.c (doprnt): Don't return value smaller than the buffer
927 size if the message was truncated. (Bug#8545).
928
b124fd93
JB
9292011-04-28 Juanma Barranquero <lekktu@gmail.com>
930
931 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
932 (Fx_window_property): #if-0 the whole functions, not just the bodies.
933
e810457d
PE
9342011-04-27 Paul Eggert <eggert@cs.ucla.edu>
935
936 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
937
ea51cceb
JB
9382011-04-27 Juanma Barranquero <lekktu@gmail.com>
939
940 * makefile.w32-in: Update dependencies.
941
94dcfacf
EZ
9422011-04-27 Eli Zaretskii <eliz@gnu.org>
943
944 Improve `doprnt' and its usage. (Bug#8545)
945 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
946 `format_end'. Remove support for %l as a conversion specifier.
947 Don't use xrealloc. Improve diagnostics when the %l size modifier
948 is used. Update the commentary.
949
950 * eval.c (verror): Simplify calculation of size_t.
951
952 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
953 messages.
954
f61f41d7
PE
9552011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
956
957 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
958 change.
959
96fb4434
PE
9602011-04-27 Paul Eggert <eggert@cs.ucla.edu>
961
962 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
963 This makes this file independent of the recent pseudovector change.
964
671875da 9652011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 966
69e9b5a3
PE
967 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
968
b5f869a7 969 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 970 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 971 Remove unused local.
c8926152 972 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 973
841a1577 974 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
975 GCC 4.6.0 optimizes based on type-based alias analysis.
976 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
977 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
978 != &v->size, and therefore "v->size = 1; b->size = 2; return
979 v->size;" must therefore return 1. This assumption is incorrect
980 for Emacs, since it type-puns struct Lisp_Vector * with many other
981 types. To fix this problem, this patch adds a new type struct
f904488f 982 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
983 and pseudovectors, and helps optimizing compilers not get fooled
984 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
985 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
986 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
987 the size member.
eab3844f
PE
988 (XSETPVECTYPE): Rewrite in terms of new macro.
989 (XSETPVECTYPESIZE): New macro, specifying both type and size.
990 This is a bit clearer, and further avoids the possibility of
991 undesirable aliasing.
992 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 993 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
994 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
995 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
996 (ASIZE): Now uses header.size rather than size.
997 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
998 to avoid the hassle of writing XVECTOR (foo)->header.size.
999 (struct vectorlike_header): New type.
eab3844f
PE
1000 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1001 object, to help avoid aliasing.
1002 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1003 (SUBRP): Likewise, since Lisp_Subr is a special case.
1004 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1005 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1006 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1007 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1008 changed to be "header.size" and "header.next".
1009 * buffer.h (struct buffer): Likewise.
1010 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1011 * frame.h (struct frame): Likewise.
1012 * process.h (struct Lisp_Process): Likewise.
1013 * termhooks.h (struct terminal): Likewise.
1014 * window.c (struct save_window_data, struct saved_window): Likewise.
1015 * window.h (struct window): Likewise.
1016 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1017 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1018 * buffer.c (init_buffer_once): Likewise.
1019 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1020 special case.
1021 * process.c (Fformat_network_address): Use local var for size,
1022 for brevity.
1023
0df1eac5
PE
1024 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1025
847ab9d1 1026 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1027 * data.c (atof): Remove decl; no longer used or needed.
1028 (digit_to_number): Move to lread.c.
1029 (Fstring_to_number): Use new string_to_number function, to be
1030 consistent with how the Lisp reader treats infinities and NaNs.
1031 Do not assume that floating-point numbers represent EMACS_INT
1032 without losing information; this is not true on most 64-bit hosts.
1033 Avoid double-rounding errors, by insisting on integers when
1034 parsing non-base-10 numbers, as the documentation specifies.
1035 * lisp.h (string_to_number): New decl, replacing ...
1036 (isfloat_string): Remove.
bc0a5c13 1037 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1038 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1039 appears to have been a coding error. Similarly, do not accept
1040 strings like +-1e0 as floating point numbers. Do not report
1041 overflow for integer overflows unless the base is not 10 which
1042 means we have no simple and reliable way to continue.
1043 Break out the floating-point parsing into a new
1044 function string_to_number, so that Fstring_to_number parses
1045 floating point numbers consistently with the Lisp reader.
04f2d78b 1046 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1047 (E_CHAR, EXP_INT): Remove, replacing with ...
1048 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1049 (string_to_number): New function, replacing isfloat_string.
1050 This function checks for valid syntax and produces the resulting
1051 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1052 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1053 so that overflow for non-base-10 numbers is reported only when
1054 there's no portable and simple way to convert to floating point.
452f4150 1055
67769ffc
PE
1056 * textprop.c (set_text_properties_1): Rewrite for clarity,
1057 and to avoid GCC warning about integer overflow.
1058
c20db43f
PE
1059 * intervals.h (struct interval): Use EMACS_INT for members
1060 where EMACS_UINT might cause problems. See
1061 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1062 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1063 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1064 All uses changed.
37aa2f85
PE
1065 (offset_intervals): Tell GCC not to worry about length overflow
1066 when negating a negative length.
c20db43f 1067
2538aa2f
PE
1068 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1069 (overrun_check_free): Likewise.
1070
f2d3008d
PE
1071 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1072 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1073 word size.
1074
ec8df744
PE
1075 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1076 (gnutls_make_error): Rename local to avoid shadowing.
1077 (gnutls_emacs_global_deinit): ifdef out; not used.
1078 (Fgnutls_boot): Use const for pointer to readonly storage.
1079 Comment out unused local. Fix pointer signedness problems.
1080
640ee02d
PE
1081 * lread.c (openp): Don't stuff size_t into an 'int'.
1082 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1083 about possible signed overflow.
1084
6048fb2a
PE
1085 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1086 (GDK_KEY_g): Don't define if already defined.
1087 (xg_prepare_tooltip): Avoid pointer signedness problem.
1088 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1089
fa3c87e1
PE
1090 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1091 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1092
2172544b
PE
1093 * xfns.c (Fx_window_property): Simplify a bit,
1094 to make a bit faster and to avoid GCC 4.6.0 warning.
1095 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1096
9b821a21
PE
1097 * fns.c (internal_equal): Don't assume size_t fits in int.
1098
3c616cfa
PE
1099 * alloc.c (compact_small_strings): Tighten assertion a little.
1100
c2982e87
PE
1101 Replace pEd with more-general pI, and fix some printf arg casts.
1102 * lisp.h (pI): New macro, generalizing old pEd macro to other
1103 conversion specifiers. For example, use "...%"pI"d..." rather
1104 than "...%"pEd"...".
1105 (pEd): Remove. All uses replaced with similar uses of pI.
1106 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1107 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1108 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1109 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1110 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1111 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1112 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1113 64-bit hosts.
1114 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1115 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1116 * print.c (safe_debug_print, print_object): Likewise.
1117 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1118 to int.
6f04d126
PE
1119 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1120 avoiding the 0 flag, which is not portable.
c2982e87
PE
1121 * process.c (Fmake_network_process): Use pI to avoid cast.
1122 * region-cache.c (pp_cache): Likewise.
1123 * xdisp.c (decode_mode_spec): Likewise.
1124 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1125 behavior on 64-bit hosts with printf arg.
6f04d126 1126 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1127 (x_stop_queuing_selection_requests): Likewise.
1128 (x_get_window_property): Don't truncate byte count to an 'int'
1129 when tracing.
0b432f21 1130
5e073ec7
PE
1131 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1132 here, since it parses constructs like leading '-' and spaces,
1133 which are not wanted; and it overflows with large numbers.
1134 Instead, simply match F[0-9]+, which is what is wanted anyway.
1135
36372bf9
PE
1136 * alloc.c: Remove unportable assumptions about struct layout.
1137 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1138 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1139 (allocate_vectorlike, make_pure_vector): Use the new macros,
1140 plus offsetof, to remove unportable assumptions about struct layout.
1141 These assumptions hold on all porting targets that I know of, but
1142 they are not guaranteed, they're easy to remove, and removing them
1143 makes further changes easier.
1144
0b432f21
PE
1145 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1146 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1147 (string_overrun_cookie): Now const. Use initializers that
1148 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1149 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1150 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1151 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1152 multiple of sizeof (EMACS_INT); it need not be, if
1153 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1154 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1155
895009e1
JB
11562011-04-26 Juanma Barranquero <lekktu@gmail.com>
1157
1158 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1159
6a7a1b0b
TZ
11602011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1161
1162 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1163 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1164 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1165
841a1577 11662011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1167
1168 * lisp.h (Qdebug): List symbol.
895009e1 1169 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1170 * keyboard.c (debug-on-event): New variable.
1171 (handle_user_signal): Break into debugger when debug-on-event
1172 matches the current signal symbol.
1173
f2d3ba6f
DN
11742011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1175
1176 * alloc.c (check_sblock, check_string_bytes)
1177 (check_string_free_list): Convert to standard C.
1178
42ce4c63
TZ
11792011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1180
1181 * w32.c (emacs_gnutls_push): Fix typo.
1182
825cd63c
EZ
11832011-04-25 Eli Zaretskii <eliz@gnu.org>
1184
fb11d64d
EZ
1185 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1186 "cast to pointer from integer of different size".
1187
825cd63c
EZ
1188 Improve doprnt and its use in verror. (Bug#8545)
1189 * doprnt.c (doprnt): Document the set of format control sequences
1190 supported by the function. Use SAFE_ALLOCA instead of always
1191 using `alloca'.
1192
1193 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1194 is one byte too soon. Don't use xrealloc; instead xfree and
1195 xmalloc anew.
1196
e061a11b
TZ
11972011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1198
1199 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1200 callbacks stage.
1201
1202 * gnutls.c: Renamed global_initialized to
1203 gnutls_global_initialized. Added internals for the
1204 :verify-hostname-error, :verify-error, and :verify-flags
1205 parameters of `gnutls-boot' and documented those parameters in the
1206 docstring. Start callback support.
1207 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1208 unless a fatal error occured. Call gnutls_alert_send_appropriate
1209 on error. Return error code.
1210 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1211 (emacs_gnutls_read): Likewise.
1212 (Fgnutls_boot): Return handshake error code.
1213 (emacs_gnutls_handle_error): New function.
1214 (wsaerror_to_errno): Likewise.
1215
1216 * w32.h (emacs_gnutls_pull): Add prototype.
1217 (emacs_gnutls_push): Likewise.
1218
1219 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1220 (emacs_gnutls_push): Likewise.
1221
12222011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1223
1224 * process.c (wait_reading_process_output): Check if GnuTLS
1225 buffered some data internally if no FDs are set for TLS
1226 connections.
1227
1228 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1229 (LIBS): Link to USER_LIBS.
1230 ($(BLD)/gnutls.$(0)): New target.
1231
fa6996bc
EZ
12322011-04-24 Eli Zaretskii <eliz@gnu.org>
1233
eb35682e
EZ
1234 * xdisp.c (handle_single_display_spec): Rename the
1235 display_replaced_before_p argument into display_replaced_p, to
1236 make it consistent with the commentary. Fix typos in the
1237 commentary.
1238
e2ad650c
EZ
1239 * textprop.c (syms_of_textprop): Remove dead code.
1240 (copy_text_properties): Delete obsolete commentary about an
1241 interface that was deleted long ago. Fix typos in the description
1242 of arguments.
1243
1b2de274
EZ
1244 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1245 to changes in oldXMenu/XMenu.h from 2011-04-16.
1246 <menu_help_message, prev_menu_help_message>: Constify.
1247 (IT_menu_make_room): menu->help_text is now `const char **';
1248 adjust.
1249
1250 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1251 to changes in oldXMenu/XMenu.h from 2011-04-16.
1252 (struct XMenu): Declare `help_text' `const char **'.
1253
1254 * xfaces.c <Qunspecified>: Make extern again.
1255
1256 * syntax.c: Include sys/types.h before including regex.h, as
1257 required by Posix.
1258
762b15be
EZ
1259 * doc.c (get_doc_string): Improve the format passed to `error'.
1260
1261 * doprnt.c (doprnt): Improve commentary.
1262
1263 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1264
1265 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1266 them with etags.
1267
f1052e5d
EZ
1268 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1269 changes in globals.h immediately force recompilation.
762b15be
EZ
1270 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1271 $(CURDIR)/s/ms-w32.h.
1272 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1273
fa6996bc
EZ
1274 * character.c (Fchar_direction): Function deleted.
1275 (syms_of_character): Don't defsubr it.
1276 <char-direction-table>: Deleted.
1277
e6c3da20
EZ
12782011-04-23 Eli Zaretskii <eliz@gnu.org>
1279
1280 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1281 * doprnt.c: Include limits.h.
1282 (SIZE_MAX): New macro.
04f2d78b
CB
1283 (doprnt): Return a size_t value. 2nd arg is now size_t.
1284 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1285 Improve overflow protection. Support `l' modifier for integer
1286 conversions. Support %l conversion. Don't assume an EMACS_INT
1287 argument for integer conversions and for %c.
1288
1289 * lisp.h (doprnt): Restore prototype.
1290
1291 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1292 $(SRC)/character.h.
1293
1294 * Makefile.in (base_obj): Add back doprnt.o.
1295
1296 * deps.mk (doprnt.o): Add back prerequisites.
1297 (callint.o): Depend on character.h.
1298
1299 * eval.c (internal_lisp_condition_case): Include the handler
1300 representation in the error message.
1301 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1302 when breaking from the loop.
1303
1304 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1305
1306 * callint.c (Fcall_interactively): When displaying error message
1307 about invalid control letter, pass the character's codepoint, not
1308 a pointer to its multibyte form. Improve display of the character
1309 in octal and display also its hex code.
1310
1311 * character.c (char_string): Use %x to display the (unsigned)
1312 codepoint of an invalid character, to avoid displaying a bogus
1313 negative value.
1314
1315 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1316 `error', not SYMBOL_NAME itself.
1317
1318 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1319 character arguments to `error'.
1320
1321 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1322 to `error' in error message about FINAL_CHAR argument. Make sure
1323 FINAL_CHAR is a character, and use %c when it is passed as
1324 argument to `error'.
1325
4ffd0d6b 13262011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1327
1328 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1329
1330 * w32.c: Include <time.h>.
1331 (sys_localtime): New function.
1332
4ffd0d6b 13332011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1334
1335 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1336
4ffd0d6b 1337 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1338
4ffd0d6b 13392011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1340
4ffd0d6b
GM
1341 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1342 zombies (Bug#8467).
aac0c6e3 1343
04c56954
EZ
13442011-04-19 Eli Zaretskii <eliz@gnu.org>
1345
1346 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1347 gl_state.e_property when gl_state.object is Qt.
1348
1349 * insdel.c (make_gap_larger): Remove limitation of buffer size
1350 to <= INT_MAX.
1351
16a43933
CY
13522011-04-18 Chong Yidong <cyd@stupidchicken.com>
1353
1354 * xdisp.c (lookup_glyphless_char_display)
1355 (produce_glyphless_glyph): Handle cons cell entry in
1356 glyphless-char-display.
1357 (Vglyphless_char_display): Document it.
1358
1359 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1360 glyphless-char-display.
1361
4581706e
CY
13622011-04-17 Chong Yidong <cyd@stupidchicken.com>
1363
1364 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1365
1366 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1367
1368 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1369 definition for no-X builds.
1370
4887c6e2 13712011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1372
fd35b6f9
PE
1373 Static checks with GCC 4.6.0 and non-default toolkits.
1374
5c1ccb01
PE
1375 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1376
006c5daa
PE
1377 * process.c (keyboard_bit_set): Define only if SIGIO.
1378 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1379 (send_process): Repair possible setjmp clobbering.
1380
efc736d3
PE
1381 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1382
4e2fe2e6
PE
1383 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1384
f97334a2
PE
1385 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1386
4e75f29d
PE
1387 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1388 Define only if needed.
1389
90efadd1
PE
1390 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1391 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1392 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1393
3c647824
PE
1394 * dispextern.h (struct redisplay_interface): Rename param
1395 to avoid shadowing.
e264f262 1396 * termhooks.h (struct terminal): Likewise.
761383f4 1397 * xterm.c (xembed_send_message): Likewise.
3c647824 1398
b58c5c4a
PE
1399 * insdel.c (make_gap_smaller): Define only if
1400 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1401
cad59032
PE
1402 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1403 it.
1404
c339dc2e
PE
1405 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1406 so that we aren't warned about unused symbols.
1407
91a3e27b
PE
1408 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1409
399c71d3 1410 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1411
8ffc96f5
PE
1412 * xfns.c (x_real_positions): Mark locals as initialized.
1413
eef9bc79
PE
1414 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1415
098db9dd
PE
1416 * xterm.c: Fix problems found by static analysis with other toolkits.
1417 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1418 (x_dispatch_event): Declare static if USE_GTK, and
1419 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1420 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1421 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1422 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1423 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1424
eb18f6cc
PE
1425 * xmenu.c (menu_help_callback): Pointer type fixes.
1426 Use const pointers when pointing at readonly data. Avoid pointer
1427 signedness clashes.
1428 (FALSE): Remove unused macro.
1429 (update_frame_menubar): Remove unused decl.
1430
1fe72bf8
PE
1431 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1432
60d9e1db
PE
1433 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1434 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1435 (single_menu_item): Rename local to avoid shadowing.
1436
39261c26
PE
1437 * keyboard.c (make_lispy_event): Remove unused local var.
1438
018c5e19
PE
1439 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1440 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1441
63d2b86e
PE
1442 * bitmaps: Change bitmaps from unsigned char back to the X11
1443 compatible char. Avoid the old compiler warnings about
1444 out-of-range initializers by using, for example, '\xab' rather
1445 than 0xab.
1446
aefd87e1
PE
1447 * xgselect.c (xgselect_initialize): Check vs interface
1448 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1449
bf501fb9
PE
1450 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1451
e9829fdf
PE
1452 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1453 to read-only memory.
1454
1086c095
PE
1455 * fns.c (vector): Remove; this old hack is no longer needed.
1456
2baccd04 1457 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1458 Remove unused var.
dde42981 1459 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1460
72391843 1461 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1462
436c16df 1463 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1464 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1465 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1466
92bb796d 1467 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1468 (x_term_init): Remove local to avoid shadowing.
92bb796d 1469
764430a3 1470 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1471
1472 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1473 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1474
d1dfb56c
EZ
14752011-04-16 Eli Zaretskii <eliz@gnu.org>
1476
c4354cb4
EZ
1477 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1478
d1dfb56c
EZ
1479 Fix regex.c, syntax.c and friends for buffers > 2GB.
1480 * syntax.h (struct gl_state_s): Declare character position members
1481 EMACS_INT.
1482
1483 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1484
04f2d78b
CB
1485 * textprop.c (verify_interval_modification, interval_of):
1486 Declare arguments EMACS_INT.
d1dfb56c
EZ
1487
1488 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1489 EMACS_INT.
1490
1491 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1492
1493 * indent.c (Fvertical_motion): Local variable it_start is now
1494 EMACS_INT.
1495
1496 * regex.c (re_match, re_match_2, re_match_2_internal)
1497 (bcmp_translate, regcomp, regexec, print_double_string)
1498 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1499 (re_compile_pattern, re_exec): Declare arguments and local
1500 variables `size_t' and `ssize_t' and return values `regoff_t', as
1501 appropriate.
1502 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1503 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1504 <compile_stack_type>: `size' and `avail' are now `size_t'.
1505
1506 * regex.h <regoff_t>: Use ssize_t, not int.
1507 (re_search, re_search_2, re_match, re_match_2): Arguments that
1508 specify buffer/string position and length are now ssize_t and
1509 size_t. Return type is regoff_t.
1510
613052cd
BK
15112011-04-16 Ben Key <bkey76@gmail.com>
1512
1513 * nsfont.m: Fixed bugs in ns_get_family and
1514 ns_descriptor_to_entity that were caused by using free to
1515 deallocate memory blocks that were allocated by xmalloc (via
1516 xstrdup). This caused Emacs to crash when compiled with
1517 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1518 --enable-checking=xmallocoverrun). xfree is now used to
1519 deallocate these memory blocks.
1520
4170f62f 15212011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1522
71b41406
PE
1523 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1524
9587a89d
PE
1525 emacs_write: Accept and return EMACS_INT for sizes.
1526 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1527 et seq.
1528 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1529 Accept and return EMACS_INT.
1530 (emacs_gnutls_write): Return the number of bytes written on
1531 partial writes.
1532 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1533 (emacs_read, emacs_write): Remove check for negative size, as the
1534 Emacs source code has been audited now.
9587a89d
PE
1535 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1536 (emacs_read, emacs_write): Use it.
273a5f82
PE
1537 * process.c (send_process): Adjust to the new signatures of
1538 emacs_write and emacs_gnutls_write. Do not attempt to store
1539 a byte offset into an 'int'; it might overflow.
9587a89d 1540 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1541
3e047f51
PE
1542 * sound.c: Don't assume sizes fit in 'int'.
1543 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1544 Return EMACS_INT, not int.
3e047f51 1545 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1546 Accept EMACS_INT, not int.
1547 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1548 record read return values.
1549
cc39a9db
BK
15502011-04-15 Ben Key <bkey76@gmail.com>
1551
c9d0ec6d
JB
1552 * keyboard.c (Qundefined): Don't declare static since it is used
1553 in nsfns.m.
1554 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1555 static since they are used in nsfont.m.
cc39a9db 1556
6c60eb9f
SM
15572011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1558
1559 * process.c (Qprocessp): Don't declare static.
1560 * lisp.h (Qprocessp): Declare again.
1561
7990b61a
JB
15622011-04-15 Juanma Barranquero <lekktu@gmail.com>
1563
1564 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1565
5d4cb038
PE
15662011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1567
8bd7b830 1568 Improve C-level modularity by making more things 'static'.
cd64ea1d 1569
e3b27b31
PE
1570 Don't publish debugger-only interfaces to other modules.
1571 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1572 (verify_bytepos, count_markers): Move decls to the only modules
1573 that need them.
1574 * region-cache.h (pp_cache): Likewise.
1575 * window.h (check_all_windows): Likewise.
1576 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1577
5d4cb038
PE
1578 * sysdep.c (croak): Now static, if
1579 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1580 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1581
1582 * alloc.c (refill_memory_reserve): Now static if
1583 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1584 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1585
e87b6180
PE
1586 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1587 Define only if USE_LUCID.
1588
ac64929e
PE
1589 * xrdb.c (x_customization_string, x_rm_string): Now static.
1590
6f37259d
PE
1591 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1592 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1593
1683e3ab
PE
1594 * xdisp.c (draw_row_with_mouse_face): Now static.
1595 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1596
de9c2632
PE
1597 * window.h (check_all_windows): Mark externally visible.
1598
2b96acb7
PE
1599 * window.c (window_deletion_count): Now static.
1600
1601 * undo.c: Make symbols static if they're not exported.
1602 (last_undo_buffer, last_boundary_position, pending_boundary):
1603 Now static.
1604
50436f33
PE
1605 * textprop.c (interval_insert_behind_hooks): Now static.
1606 (interval_insert_in_front_hooks): Likewise.
1607
64520e5c
PE
1608 * term.c: Make symbols static if they're not exported.
1609 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1610 (max_frame_lines, tty_set_terminal_modes):
1611 (tty_reset_terminal_modes, tty_turn_off_highlight):
1612 (get_tty_terminal): Now static.
1613 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1614 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1615 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1616 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1617 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1618
1fa53021
PE
1619 * sysdep.c: Make symbols static if they're not exported.
1620 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1621 Now static.
1622 (sigprocmask_set, full_mask): Remove; unused.
1623 (wait_debugging): Mark as visible.
1624 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1625 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1626
d4b43b22
PE
1627 * syntax.c (syntax_temp): Define only if !__GNUC__.
1628
b7c513d0
PE
1629 * sound.c (current_sound_device, current_sound): Now static.
1630
989b29ad
PE
1631 * search.c (searchbufs, searchbuf_head): Now static.
1632
13a55a78
PE
1633 * scroll.c (scroll_cost): Remove; unused.
1634 * dispextern.h (scroll_cost): Remove decl.
1635
de68a1fc
PE
1636 * region-cache.h (pp_cache): Mark as externally visible.
1637
40ccffa6
PE
1638 * process.c: Make symbols static if they're not exported.
1639 (process_tick, update_tick, create_process, chan_process):
1640 (Vprocess_alist, proc_buffered_char, datagram_access):
1641 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1642 (deactivate_process): Mark defn as static, as well as decl.
1643 * lisp.h (create_process): Remove decl.
1644 * process.h (chan_process, Vprocess_alist): Remove decls.
1645
ad64fc97
PE
1646 * print.c: Make symbols static if they're not exported.
1647 (print_depth, new_backquote_output, being_printed, print_buffer):
1648 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1649 (print_interval, print_number_index, initial_stderr_stream):
1650 Now static.
1651 * lisp.h (Fprinc): Remove decl.
1652 (debug_output_compilation_hack): Mark as externally visible.
1653
adddb265
PE
1654 * sysdep.c (croak): Move decl from here to syssignal.h.
1655 * syssignal.h (croak): Put it here, so the API can be checked when
1656 'croak' is called from dissociate_if_controlling_tty.
1657
1717ede2
PE
1658 * minibuf.c: Make symbols static if they're not exported.
1659 (minibuf_save_list, choose_minibuf_frame): Now static.
1660 * lisp.h (choose_minibuf_frame): Remove decl.
1661
fa5fb2bc
PE
1662 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1663
1e3890d1
PE
1664 * lread.c: Make symbols static if they're not exported.
1665 (read_objects, initial_obarray, oblookup_last_bucket_number):
1666 Now static.
1667 (make_symbol): Remove; unused.
1668 * lisp.h (initial_obarray, make_symbol): Remove decls.
1669
8a1414fa
PE
1670 * keyboard.c: Make symbols static if they're not exported.
1671 (single_kboard, recent_keys_index, total_keys, recent_keys):
1672 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1673 (this_single_command_key_start, echoing, last_auto_save):
1674 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1675 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1676 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1677 (Vlispy_mouse_stem, double_click_count):
1678 Now static.
1679 (force_auto_save_soon): Define only if SIGDANGER.
1680 (ignore_mouse_drag_p): Now static if
1681 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1682 (print_help): Remove; unused.
1683 (stop_character, last_timer_event): Mark as externally visible.
1684 * keyboard.h (ignore_mouse_drag_p): Declare only if
1685 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1686 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1687 * lisp.h (echoing): Remove decl.
1688 (force_auto_save_soon): Declare only if SIGDANGER.
1689 * xdisp.c (redisplay_window): Simplify code, to make it more
1690 obvious that ignore_mouse_drag_p is not accessed if !defined
1691 USE_GTK && !defined HAVE_NS.
1692
93ea6e8f
PE
1693 * intervals.c: Make symbols static if they're not exported.
1694 (merge_properties_sticky, merge_interval_right, delete_interval):
1695 Now static.
1696 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1697
77382fcc
PE
1698 * insdel.c: Make symbols static if they're not exported.
1699 However, leave prepare_to_modify_buffer alone. It's never
1700 called from outside this function, but that appears to be a bug.
1701 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1702 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1703 (adjust_after_replace_noundo): Remove; unused.
1704 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1705 (signal_before_change): Remove decls.
77382fcc 1706
9306c32e
PE
1707 * indent.c (val_compute_motion, val_vmotion): Now static.
1708
cd44d2eb
PE
1709 * image.c: Make symbols static if they're not exported.
1710 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1711 if USE_GTK.
1712 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1713 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1714
ad9a7a06
PE
1715 * fringe.c (standard_bitmaps): Now static.
1716 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1717
81626931
PE
1718 * frame.c: Make symbols static if they're not exported.
1719 (x_report_frame_params, make_terminal_frame): Now static.
1720 (get_frame_param): Now static, unless HAVE_NS.
1721 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1722 (x_get_resource_string): Remove; not used.
1723 * frame.h (make_terminal_frame, x_report_frame_params):
1724 (x_get_resource_string); Remove decls.
1725 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1726 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1727
239f9db9
PE
1728 * font.c, fontset.c: Make symbols static if they're not exported.
1729 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1730 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1731 * font.c (font_close_object): Now static.
1732 * font.h (font_close_object): Remove.
1733 * fontset.c (FONTSET_OBJLIST): Remove.
1734 (free_realized_fontset) #if-0 the body, which does nothing.
1735 (face_suitable_for_char_p): #if-0, as it's never called.
1736 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1737 * xfaces.c (face_at_string_position):
1738 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1739 since 0 is always ASCII.
1740
dfcf3579
PE
1741 * fns.c (weak_hash_tables): Now static.
1742
5045092b
PE
1743 * fileio.c: Make symbols static if they're not exported.
1744 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1745 (Vwrite_region_annotation_buffers): Now static.
1746
57a96f5c
PE
1747 * eval.c: Make symbols static if they're not exported.
1748 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1749 * lisp.h (backtrace_list): Remove decl.
1750
35f08c38
PE
1751 * emacs.c: Make symbols static if they're not exported.
1752 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1753 (fatal_error_code, fatal_error_signal_hook, standard_args):
1754 Now static.
1755 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1756 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1757 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1758 * lisp.h (fatal_error_signal_hook): Remove decl.
1759 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1760
f44bd759
PE
1761 * editfns.c: Move a (normally-unused) function to its only use.
1762 * editfns.c, lisp.h (get_operating_system_release): Remove.
1763 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1764 worth the hassle of breaking this out.
1765
b532497d
PE
1766 * xterm.c: Make symbols static if they're not exported.
1767 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1768 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1769 (x_destroy_window, x_delete_display):
1770 Now static.
1771 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1772 (x_mouse_leave): Remove; unused.
1773 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1774 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1775 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1776 Remove decls.
1777 (x_mouse_leave): Declare only if WINDOWSNT.
1778 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1779 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1780 USE_X_TOOLKIT.
1781
1675728f
PE
1782 * ftxfont.c: Make symbols static if they're not exported.
1783 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1784 HAVE_FREETYPE.
1785 * font.h (ftxfont_driver): Likewise.
1786
e4cebfca
PE
1787 * xfns.c: Make symbols static if they're not exported.
1788 (x_last_font_name, x_display_info_for_name):
1789 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1790 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1791 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1792 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1793 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1794 (last_show_tip_args): Now static.
1795 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1796 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1797 (x_screen_planes): Remove; unused.
1798 * dispextern.h (x_screen_planes): Remove decl.
1799
5bf46f05
PE
1800 * dispnew.c: Make symbols static if they're not exported.
1801 * dispextern.h (redraw_garbaged_frames, scrolling):
1802 (increment_row_positions): Remove.
1803 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1804 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1805 Now static.
1806 (redraw_garbaged_frames): Remove; unused.
1807
435f4c28
PE
1808 * xfaces.c: Make symbols static if they're not exported.
1809 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1810 Remove decls.
1811 * xterm.h (defined_color): Remove decls.
1812 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1813 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1814 (menu_face_changed_default, defined_color, free_realized_face):
1815 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1816 (ascii_face_of_lisp_face): Remove; unused.
1817
8524aef3
PE
1818 * xdisp.c: Make symbols static if they're not exported.
1819 * dispextern.h (scratch_glyph_row, window_box_edges):
1820 (glyph_to_pixel_coords, set_cursor_from_row):
1821 (get_next_display_element, set_iterator_to_next):
1822 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1823 (show_mouse_face): Remove decls
1824 * frame.h (message_buf_print): Likewise.
1825 * lisp.h (pop_message, set_message, check_point_in_composition):
1826 Likewise.
1827 * xterm.h (set_vertical_scroll_bar): Likewise.
1828 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1829 (message_buf_print, scratch_glyph_row, displayed_buffer):
1830 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1831 (get_next_display_element, show_mouse_face, window_box_edges):
1832 (frame_to_window_pixel_xy, check_point_in_composition):
1833 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1834 (glyph_to_pixel_coords): Remove; unused.
1835
16390cd2
PE
1836 * dired.c (file_name_completion): Now static.
1837
1838 * dbusbind.c (xd_in_read_queued_messages): Now static.
1839
a25f4dfa
PE
1840 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1841 * data.c (circular_list_error): Remove.
1842
14a9c8df
PE
1843 * commands.h (last_point_position, last_point_position_buffer):
1844 (last_point_position_window): Remove decls.
1845 * keyboard.c: Make these variables static.
1846
04f2d78b
CB
1847 * coding.h (coding, code_convert_region, encode_coding_gap):
1848 Remove decls.
74ab6df5
PE
1849 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1850 (iso_code_class, detect_coding, code_convert_region): Now static.
1851 (encode_coding_gap): Remove; unused.
1852
38dfbee1
PE
1853 * chartab.c (chartab_chars, chartab_bits): Now static.
1854
a2cb4e63
PE
1855 * charset.h (charset_iso_8859_1): Remove decl.
1856 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1857 Now static.
1858
127198fd
PE
1859 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1860 * ccl.c (Vccl_program_table): Now static.
1861 (check_ccl_update): Remove; unused.
1862
d85b608f
PE
1863 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1864 * category.h: ... from here.
1865 * category.c (check_category_table, set_category_set): Now static.
1866
31cd66f3
PE
1867 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1868 * lisp.h: Remove these decls.
1869
c358e587
PE
1870 * buffer.c (buffer_count): Remove unused var.
1871
e78aecca
PE
1872 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1873 so that it's not optimized away.
1874 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1875 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1876 exported only to the debugger.
1877
e192d7d3 1878 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1879 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1880
92470028
PE
1881 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1882 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1883 was inaccessible from Lisp.
1884 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1885 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1886
244ed907
PE
1887 alloc.c: Import and export fewer symbols, and remove unused items.
1888 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1889 is defined.
1890 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1891 it's not optimized away by whole-program optimization.
1892 (message_enable_multibyte, free_misc): Remove.
1893 (catchlist, handlerlist, mark_backtrace):
1894 Declare only if BYTE_MARK_STACK.
1895 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1896 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1897 (message_enable_multibyte): Remove decl.
1898 (free_misc, interval_free_list, float_block, float_block_index):
1899 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1900 (cons_free_list, last_marked_index):
1901 Now static.
1902 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1903 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1904 (mark_backtrace): Define only if BYTE_MARK_STACK.
1905 * xdisp.c (message_enable_multibyte): Now static.
1906
61c2b50e 1907 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1908 This makes it easier for human readers (and static analyzers)
1909 to see whether these variables are used from other modules.
1910 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1911 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1912 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1913 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1914 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1915 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1916 * xmenu.c, xselect.c:
1917 Declare Q* vars static if they are not used in other modules.
1918 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1919 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1920 Remove decls of unexported vars.
1921 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1922
95c82688
PE
1923 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1924
16a97296
PE
1925 Make Emacs functions such as Fatom 'static' by default.
1926 This makes it easier for human readers (and static analyzers)
1927 to see whether these functions can be called from other modules.
1928 DEFUN now defines a static function. To make the function external
1929 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1930 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1931 (Finit_image_library):
16a97296
PE
1932 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1933 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1934 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1935 Remove decls, since these functions are now static.
1936 (Funintern, Fget_internal_run_time): New decls, since these functions
1937 were already external.
95c82688 1938
16a97296
PE
1939 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1940 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1941 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1942 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1943 * keyboard.c, keymap.c, lread.c:
1944 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1945 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1946 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1947 Mark functions with DEFUE instead of DEFUN,
1948 if they are used in other modules.
1949 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1950 decls for now-static functions.
1951 * buffer.h (Fdelete_overlay): Remove decl.
1952 * callproc.c (Fgetenv_internal): Mark as internal.
1953 * composite.c (Fremove_list_of_text_properties): Remove decl.
1954 (Fcomposition_get_gstring): New forward static decl.
1955 * composite.h (Fcomposite_get_gstring): Remove decl.
1956 * dired.c (Ffile_attributes): New forward static decl.
1957 * doc.c (Fdocumntation_property): New forward static decl.
1958 * eval.c (Ffetch_bytecode): New forward static decl.
1959 (Funintern): Remove extern decl; now in .h file where it belongs.
1960 * fileio.c (Fmake_symbolic_link): New forward static decl.
1961 * image.c (Finit_image_library): New forward static decl.
1962 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1963 * intervals.h (Fprevious_property_change):
1964 (Fremove_list_of_text_properties): Remove decls.
1965 * keyboard.c (Fthis_command_keys): Remove decl.
1966 (Fcommand_execute): New forward static decl.
1967 * keymap.c (Flookup_key): New forward static decl.
1968 (Fcopy_keymap): Now static.
1969 * keymap.h (Flookup_key): Remove decl.
1970 * process.c (Fget_process): New forward static decl.
1971 (Fprocess_datagram_address): Mark as internal.
1972 * syntax.c (Fsyntax_table_p): New forward static decl.
1973 (skip_chars): Remove duplicate decl.
1974 * textprop.c (Fprevious_property_change): New forward static decl.
1975 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1976 Now internal.
1977 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1978 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1979
785bbd42
PE
1980 * editfns.c (Fformat): Remove unreachable code.
1981
8b913b57
AS
19822011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1983
1984 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1985 change. (Bug#8496)
1986
a6744a35
EZ
19872011-04-13 Eli Zaretskii <eliz@gnu.org>
1988
1989 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1990 when at ZV. (Bug#8487)
1991
e7974947
AS
19922011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1993
baad03f0
AS
1994 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1995 (Bug#8437)
1996 * keyboard.c (parse_tool_bar_item): Likewise.
1997 * sound.c (sound_cleanup, alsa_close): Likewise.
1998 * termcap.c (tgetent): Likewise.
1999 * xfns.c (x_default_font_parameter): Likewise.
2000 * xsettings.c (read_and_apply_settings): Likewise.
2001
e7974947
AS
2002 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2003 (overrun_check_free): Protoize.
2004
28272684
PE
20052011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2006
2007 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2008 since callers should never pass a negative size.
2009 Change the signature to match that of plain 'read' and 'write'; see
2010 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2011 * lisp.h: Update prototypes of emacs_write and emacs_read.
2012
11997c76
EZ
20132011-04-11 Eli Zaretskii <eliz@gnu.org>
2014
2015 * xdisp.c (redisplay_window): Don't try to determine the character
2016 position of the scroll margin if the window start point w->startp
e896f03c 2017 is outside the buffer's accessible region. (Bug#8468)
11997c76 2018
8a2cbd72
EZ
20192011-04-10 Eli Zaretskii <eliz@gnu.org>
2020
2021 Fix write-region and its subroutines for buffers > 2GB.
2022 * fileio.c (a_write, e_write): Modify declaration of arguments and
2023 local variables to support buffers larger than 2GB.
2024 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2025
2026 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2027 argument, local variables, and return value.
2028
2029 * lisp.h: Update prototypes of emacs_write and emacs_read.
2030
2031 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2032
4073e537 20332011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2034
1ebfdcb6
PE
2035 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2036
b2ded58d
PE
2037 Fix more problems found by GCC 4.6.0's static checks.
2038
7d66342c
PE
2039 * xdisp.c (vmessage): Use a better test for character truncation.
2040
bbf47d44
PE
2041 * charset.c (load_charset_map): <, not <=, for optimization,
2042 and to avoid potential problems with integer overflow.
9248994d 2043 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2044 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2045 * editfns.c (Fformat): Likewise.
1e69125e 2046 * syntax.c (skip_chars): Likewise.
3befa583 2047
e3019616
PE
2048 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2049 This also lets GCC 4.6.0 generate slightly better loop code.
2050
becfa255
PE
2051 * callint.c (Fcall_interactively): <, not <=, for optimization.
2052 (Fcall_interactively): Count the number of arguments produced,
2053 not the number of arguments given. This is simpler and lets GCC
2054 4.6.0 generate slightly better code.
2055
dae0cd48
PE
2056 * ftfont.c: Distingish more carefully between FcChar8 and char.
2057 The previous code passed unsigned char * to a functions like
2058 strlen and xstrcasecmp that expect char *, which does not
2059 conform to the C standard.
2060 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2061 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2062 char * when the C standard requires it.
2063
76032d70
PE
2064 * keyboard.c (read_char): Remove unused var.
2065
eb3f1cc8
PE
2066 * eval.c: Port to Windows vsnprintf (Bug#8435).
2067 Include <limits.h>.
2068 (SIZE_MAX): Define if the headers do not.
2069 (verror): Do not give up if vsnprintf returns a negative count.
2070 Instead, grow the buffer. This ports to Windows vsnprintf, which
2071 does not conform to C99. Problem reported by Eli Zaretskii.
2072 Also, simplify the allocation scheme, by avoiding the need for
2073 calling realloc, and removing the ALLOCATED variable.
2074
70476b54
PE
2075 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2076
12020a9e
PE
2077 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2078 But keep the doprint source code for now, as we might revamp it
2079 and use it again (Bug#8435).
ea6c7ae6
PE
2080 * lisp.h (doprnt): Remove.
2081 * Makefile.in (base_obj): Remove doprnt.o.
2082 * deps.mk (doprnt.o): Remove.
2083
5fdb398c
PE
2084 error: Print 32- and 64-bit integers portably (Bug#8435).
2085 Without this change, on typical 64-bit hosts error ("...%d...", N)
2086 was used to print both 32- and 64-bit integers N, which relied on
2087 undefined behavior.
2088 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2089 New macro.
2090 * lisp.h (error, verror): Mark as printf-like functions.
2091 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2092 Report overflow in size calculations when allocating printf buffer.
2093 Do not truncate output string at its first null byte.
2094 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2095 Truncate the output at a character boundary, since vsnprintf does not
2096 do that.
2097 * charset.c (check_iso_charset_parameter): Convert internal
2098 character to string before calling 'error', since %c now has the
2099 printf meaning.
2100 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2101 overflow when computing char to be passed to 'error'. Do not
2102 pass Lisp_Object to 'error'; pass the integer instead.
2103 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2104 formatted with plain %d.
2105
b189fa66
PE
2106 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2107
bff87ef0
PE
2108 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2109
7e2cac20
PE
2110 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2111
ce4d90b5
PE
2112 * xterm.c (x_catch_errors): Remove duplicate declaration.
2113
266c9547
PE
2114 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2115
79c49ad2
PE
2116 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2117
368f4090
JM
21182011-04-10 Jim Meyering <meyering@redhat.com>
2119
2120 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2121 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2122 return ssize_t not "int", and use size_t as the buffer length.
2123 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2124 * gnutls.h: Update declarations.
2125 * process.c (read_process_output): Use ssize_t, to match.
2126 (send_process): Likewise.
2127
a32d4040
CY
21282011-04-09 Chong Yidong <cyd@stupidchicken.com>
2129
2130 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2131
8546720e 21322011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2133
04f2d78b
CB
2134 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2135 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2136
8546720e
GM
2137 * xterm.c (handle_one_xevent):
2138 * xmenu.c (create_and_show_popup_menu):
2139 * xselect.c (x_decline_selection_request)
2140 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2141
0a2f5c1a 21422011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2143
2144 Fix some uses of `int' instead of EMACS_INT.
2145 * search.c (string_match_1, fast_string_match)
2146 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2147 (scan_buffer, find_next_newline_no_quit)
2148 (find_before_next_newline, search_command, Freplace_match)
2149 (Fmatch_data): Make some `int' variables be EMACS_INT.
2150
2151 * xdisp.c (display_count_lines): 3rd argument and return value now
2152 EMACS_INT. All callers changed.
2153 (pint2hrstr): Last argument is now EMACS_INT.
2154
2155 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2156 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2157 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2158 (decode_coding_utf_16, decode_coding_emacs_mule)
2159 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2160 (decode_coding_ccl, decode_coding_charset)
2161 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2162 (decode_coding_iso_2022, decode_coding_emacs_mule)
2163 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2164 <char_offset, last_offset>: Declare EMACS_INT.
2165 (encode_coding_utf_8, encode_coding_utf_16)
2166 (encode_coding_emacs_mule, encode_invocation_designation)
2167 (encode_designation_at_bol, encode_coding_iso_2022)
2168 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2169 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2170 Declare EMACS_INT.
2171 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2172 (encode_invocation_designation): Last argument P_NCHARS is now
2173 EMACS_INT.
2174 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2175 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2176
2177 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2178 All users changed.
2179
2180 * ccl.c (Fccl_execute_on_string): Declare some variables
2181 EMACS_INT.
2182
8546720e 21832011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2184
2185 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2186
4e19a977
CS
21872011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2188
2189 * process.c (Fformat_network_address): Doc fix.
2190
87302331
R
21912011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2192
2193 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2194
cbb59342
CY
21952011-04-08 Chong Yidong <cyd@stupidchicken.com>
2196
2197 * keyboard.c (read_char): Call Lisp function help-form-show,
2198 instead of using internal_with_output_to_temp_buffer.
2199 (Qhelp_form_show): New var.
e0d38eeb 2200 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2201
2202 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2203
2204 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2205
e67a13ab
CY
22062011-04-06 Chong Yidong <cyd@stupidchicken.com>
2207
04f2d78b
CB
2208 * process.c (Flist_processes): Remove to Lisp.
2209 (list_processes_1): Delete.
e67a13ab 2210
973f782d
EZ
22112011-04-06 Eli Zaretskii <eliz@gnu.org>
2212
7c106b1e
EZ
2213 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2214
973f782d
EZ
2215 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2216
41cf7d1a 22172011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2218
ca23cc88
PE
2219 Fix more problems found by GCC 4.6.0's static checks.
2220
f390e2d5
PE
2221 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2222
42eea0d0
PE
2223 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2224
b69769da 2225 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2226
f9541e84
PE
2227 * xdisp.c (vmessage): Mark as a printf-like function.
2228
13841b55
PE
2229 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2230
c136c10f
PE
2231 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2232
5e2d4a30
PE
2233 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2234 printf-like functions.
2235 (tiff_load): Add casts to remove these marks before passing them
2236 to system-supplied API.
2237
583f48b9
PE
2238 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2239
b25d760e
PE
2240 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2241 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2242 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2243 directly, rather than having caller test rule sign. This avoids
2244 some unnecessary tests.
2245 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2246 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2247 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2248
bc7b6697 2249 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2250 (xfont_open): Avoid unnecessary tests.
bc7b6697 2251
27ccc379
PE
2252 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2253
dcd5c89a
PE
2254 * composite.h, composite.c (composition_gstring_put_cache):
2255 Use EMACS_INT, not int, for length.
2256
b13a45c6
PE
2257 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2258 breaking out part of COMPOSITION_DECODE_RULE.
2259 (COMPOSITION_DECODE_RULE): Use it.
2260 * composite.c (get_composition_id): Remove unused local vars,
2261 by using the new macro.
2262
1e792e4d
PE
2263 * textprop.c (set_text_properties_1): Change while to do-while,
2264 since the condition is always true at first.
2265
dc6c6455 2266 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2267 (interval_deletion_adjustment): Return unsigned value.
2268 All uses changed.
dc6c6455 2269
aba7731a
PE
2270 * process.c (list_processes_1, create_pty, read_process_output):
2271 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2272 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2273 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2274 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2275 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2276
fdfc4bf3
PE
2277 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2278
fca8fe46 2279 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2280 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2281
06a0259a 2282 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2283 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2284 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2285
e7b9e80f
PE
2286 * print.c (print_error_message): Avoid int overflow.
2287
56201685
PE
2288 * font.c (font_list_entities): Redo for clarity,
2289 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2290
78834453 2291 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2292 (font_score): Avoid potential overflow in diff calculation.
78834453 2293
0bc0b309 2294 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2295 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2296
e610eaca
PE
2297 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2298
b895abce
PE
2299 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2300 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2301 can always succeed if overflow has undefined behavior.
2302
1f1d9321 2303 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2304 (wordify): Omit three unnecessary tests.
1f1d9321 2305
c59478bc
PE
2306 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2307 All callers changed. This avoids the need for an unused var.
2308
79b73827
PE
2309 * casefiddle.c (casify_region): Remove var that is set but not used.
2310
a4db5dfe
PE
2311 * dired.c (file_name_completion): Remove var that is set but not used.
2312
43aae36e
PE
2313 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2314
2a47c44d 2315 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2316 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2317
a37c69bf
PE
2318 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2319 Check for integer overflow on size calculations.
2320
328ab8e7
PE
2321 * buffer.c (Fprevious_overlay_change): Remove var that is set
2322 but not used.
2323
e5a2a5cb
PE
2324 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2325 Remove vars that are set but not used.
8d84a6eb 2326 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2327 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2328
a60e5f68
PE
2329 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2330
f661cb61 2331 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2332 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2333
f0397f5a
PE
2334 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2335 that are set but not used.
2336
8664db06 2337 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2338 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2339
6abdaa4a
PE
2340 * xselect.c (x_get_local_selection, x_handle_property_notify):
2341 Remove vars that are set but not used.
2342
0ce7538d 2343 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2344 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2345
9ae848fc
PE
2346 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2347 Remove var that is set but not used.
0b918413
PE
2348 (scroll_bar_windows_size): Now size_t, not int.
2349 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2350 Check for overflow.
9ae848fc 2351
a5a62657
PE
2352 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2353 (map_tty_color) [!defined MSDOS]: Likewise.
2354
5c5cdd39
PE
2355 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2356
66ebf983
PE
2357 * coding.c: Remove vars that are set but not used.
2358 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2359 All callers changed.
2360 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2361 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2362 (decode_coding_charset): Remove vars that are set but not used.
2363
1be4d761
PE
2364 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2365 that is set but not used.
2366
47553fa8
PE
2367 * print.c (print_object): Remove var that is set but not used.
2368
1f7196bf 2369 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2370 The gnulib version avoids calling malloc in the usual case,
2371 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2372 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2373 * filelock.c (current_lock_owner): Likewise.
2374 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2375 * sysdep.c: Include allocator.h, careadlinkat.h.
2376 (emacs_no_realloc_allocator): New static constant.
2377 (emacs_readlink): New function.
fdb61804
PE
2378 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2379 ../lib/careadlinkat.h.
d1fdcab7 2380
f84c17c7
SM
23812011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2382
2383 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2384 first non-nil return value).
2385
ef3862ad
JD
23862011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2387
2388 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2389 if not defined (Bug#8403).
2390
376a7006
JB
23912011-04-02 Juanma Barranquero <lekktu@gmail.com>
2392
2393 * xdisp.c (display_count_lines): Remove parameter `start',
2394 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2395 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2396 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2397 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2398 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2399 and thereabouts. All callers changed.
2400 (get_per_char_metric): Remove parameter `f', unused since
2401 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2402
6ca3801d
JM
24032011-04-02 Jim Meyering <meyering@redhat.com>
2404
2405 do not dereference NULL upon failed strdup
2406 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2407 (ns_get_family): Likewise.
2408
d8e2b5ba
JB
24092011-04-02 Juanma Barranquero <lekktu@gmail.com>
2410
2411 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2412
8c74fcbd
JD
24132011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2414
2415 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2416 later (Bug#8403).
2417
7200d79c
SM
24182011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2419
03408648 2420 Add lexical binding.
7200d79c 2421
03408648
SM
2422 * window.c (Ftemp_output_buffer_show): New fun.
2423 (Fsave_window_excursion):
2424 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2425
2426 * lread.c (lisp_file_lexically_bound_p): New function.
2427 (Fload): Bind Qlexical_binding.
2428 (readevalloop): Remove `evalfun' arg.
2429 Bind Qinternal_interpreter_environment.
2430 (Feval_buffer): Bind Qlexical_binding.
2431 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2432 Mark as dynamic.
2433 (syms_of_lread): Declare `lexical-binding'.
2434
2435 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2436
2437 * keyboard.c (eval_dyn): New fun.
2438 (menu_item_eval_property): Use it.
ca105506
SM
2439
2440 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2441
03408648
SM
2442 * fns.c (concat, mapcar1): Accept byte-code-functions.
2443
2444 * eval.c (Fsetq): Handle lexical vars.
2445 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2446 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2447 (FletX, Flet): Obey lexical binding.
2448 (Fcommandp): Handle closures.
2449 (Feval): New `lexical' arg.
2450 (eval_sub): New function extracted from Feval. Use it almost
2451 everywhere where Feval was used. Look up vars in lexical env.
2452 Handle closures.
2453 (Ffunctionp): Move from subr.el.
2454 (Ffuncall): Handle closures.
2455 (apply_lambda): Remove `eval_flags'.
2456 (funcall_lambda): Handle closures and new byte-code-functions.
2457 (Fspecial_variable_p): New function.
2458 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2459 but without exporting it to Lisp.
23aba0ea 2460
23aba0ea 2461 * doc.c (Fdocumentation, store_function_docstring):
03408648 2462 * data.c (Finteractive_form): Handle closures.
23aba0ea 2463
03408648
SM
2464 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2465 interactive spec.
ba83908c 2466
04f2d78b
CB
2467 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2468 New byte-codes.
03408648
SM
2469 (exec_byte_code): New function extracted from Fbyte_code to handle new
2470 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2471
03408648 2472 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2473
03408648 2474 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2475
e2abce01
JB
24762011-03-31 Juanma Barranquero <lekktu@gmail.com>
2477
2478 * xdisp.c (redisplay_internal): Fix prototype.
2479
63696a73 24802011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2481
63696a73 2482 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2483 (try_scrolling): Use it when setting scroll_limit.
2484 Limit scrolling to 100 screen lines.
63696a73
EZ
2485 (redisplay_window): Even when falling back on "recentering",
2486 position point in the window according to scroll-conservatively,
2487 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2488
2489 (try_scrolling): When point is above the window, allow searching
2490 as far as scroll_max, or one screenful, to compute vertical
2491 distance from PT to the scroll margin position. This prevents
2492 try_scrolling from unnecessarily failing when
2493 scroll-conservatively is set to a value slightly larger than the
2494 window height. Clean up the case of PT below the margin at bottom
2495 of window: scroll_max can no longer be INT_MAX. When aggressive
2496 scrolling is in use, don't let point enter the opposite scroll
2497 margin as result of the scroll.
2498 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2499 threshold of 100 lines for never-recentering scrolling.
2500
e4cc2dfc
JB
25012011-03-31 Juanma Barranquero <lekktu@gmail.com>
2502
2503 * dispextern.h (move_it_by_lines):
2504 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2505 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2506 (message_log_check_duplicate): Remove parameters `prev_bol' and
2507 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2508 (redisplay_internal): Remove parameter `preserve_echo_area',
2509 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2510
2511 * indent.c (Fvertical_motion):
2512 * window.c (window_scroll_pixel_based, Frecenter):
2513 Don't pass `need_y_p' to `move_it_by_lines'.
2514
1c470562
SM
25152011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2516
44f230aa
SM
2517 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2518 steal a few bits to be more compact.
2519 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2520 Remove unneeded casts.
2521
1c470562
SM
2522 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2523
888adce9
ZK
25242011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2525
2526 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2527 binding" message (bug#7967).
2528
f838ed7b
PE
25292011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2530
77861b95
PE
2531 Fix more problems found by GCC 4.6.0's static checks.
2532
de6dbc14
PE
2533 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2534 Remove unused local var.
2535
f838ed7b
PE
2536 * editfns.c (Fmessage_box): Remove unused local var.
2537
792c7b2b
PE
2538 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2539 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2540 Omit unused local vars.
c499e557 2541 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2542 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2543 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2544 Omit unused local var.
2545
ba0165e1
PE
2546 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2547 Don't assume string length fits in int.
32ad8845 2548 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2549 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2550
3c59b4c9
PE
2551 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2552 instead of alloca (Bug#8344).
2553
a3eed478 2554 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2555 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2556
eb4d412d
PE
2557 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2558
1658b401
PE
2559 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2560 concerns.
2561
2562 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2563
2564 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2565
9a2c6e05
PE
2566 * keyboard.c (syms_of_keyboard): Use the same style as later
2567 in this function when indexing through an array. This also
2568 works around GCC bug 48267.
2569
03d0a109
PE
2570 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2571
44f730c8
PE
2572 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2573
fe75f926
PE
2574 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2575 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2576
ffa8c828
PE
2577 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2578 This avoids undefined behavior on integer overflow, and is a bit
2579 more convenient anyway since it is compared to a size_t variable.
2580
c5101a77
PE
2581 Variadic C functions now count arguments with size_t, not int.
2582 This avoids an unnecessary limitation on 64-bit machines, which
2583 caused (substring ...) to crash on large vectors (Bug#8344).
2584 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2585 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2586 All variadic functions and their callers changed accordingly.
c5101a77
PE
2587 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2588 * data.c (arith_driver, float_arith_driver): Likewise.
2589 * editfns.c (general_insert_function): Likewise.
2590 * eval.c (struct backtrace.nargs, interactive_p)
2591 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2592 (funcall_lambda, mark_backtrace): Likewise.
2593 * fns.c (concat): Likewise.
2594 * frame.c (x_set_frame_parameters): Likewise.
2595 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2596 0 if not found, not -1. All callers changed.
2597
dd3f25f7
PE
2598 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2599 (stack_copy_size): Now size_t, not int.
2600 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2601
461c2ab9
JB
26022011-03-28 Juanma Barranquero <lekktu@gmail.com>
2603
2604 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2605 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2606 All callers changed.
2607
2608 * lisp.h (multibyte_char_to_unibyte):
2609 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2610 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2611 * character.h (CHAR_TO_BYTE8):
2612 * cmds.c (internal_self_insert):
2613 * editfns.c (general_insert_function):
2614 * keymap.c (push_key_description):
2615 * search.c (Freplace_match):
2616 * xdisp.c (message_dolog, set_message_1): All callers changed.
2617
f6d62986
SM
26182011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2619
2620 * keyboard.c (safe_run_hook_funcall): New function.
2621 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2622 don't set the hook to nil, but remove the offending function instead.
2623 (Qcommand_hook_internal): Remove, unused.
2624 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2625 Vcommand_hook_internal.
2626
2627 * eval.c (enum run_hooks_condition): Remove.
2628 (funcall_nil, funcall_not): New functions.
2629 (run_hook_with_args): Call each function through a `funcall' argument.
2630 Remove `cond' argument, now redundant.
2631 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2632 (Frun_hook_with_args_until_failure): Adjust accordingly.
2633 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2634
1db5b1ad
JB
26352011-03-28 Juanma Barranquero <lekktu@gmail.com>
2636
2637 * dispextern.h (string_buffer_position): Remove declaration.
2638
2639 * print.c (strout): Remove parameter `multibyte', unused since
2640 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2641
2642 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2643 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2644 All callers changed.
2645
2646 * w32.c (_wsa_errlist): Use braces for struct initializers.
2647
2648 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2649 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2650 All callers changed.
2651 (string_buffer_position): Likewise. Also, make static (it's never
2652 used outside xdisp.c).
2653 (cursor_row_p): Remove parameter `w', unused since
2654 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2655 (decode_mode_spec): Remove parameter `precision', introduced during
2656 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2657 All callers changed.
2658
5ffb62aa
JD
26592011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2660
2661 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2662
461c2ab9 26632011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2664
2665 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2666 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2667 (ns_update_auto_hide_menu_bar): New functions.
2668 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2669 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2670 ns_constrain_all_frames.
2671 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2672 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2673
5c380ffb
JD
26742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2675
2676 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2677
9af30bdf
GM
26782011-03-27 Glenn Morris <rgm@gnu.org>
2679
2680 * syssignal.h: Replace RETSIGTYPE with void.
2681 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2682 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2683 Replace SIGTYPE with void everywhere.
2684 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2685 * s/template.h (SIGTYPE): Remove commented out definition.
2686
e2abce01
JB
26872011-03-26 Eli Zaretskii <eliz@gnu.org>
2688
2689 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2690 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2691
f868cd8a
JB
26922011-03-26 Juanma Barranquero <lekktu@gmail.com>
2693
59eb0929
JB
2694 * w32.c (read_unc_volume): Use parameter `henum', instead of
2695 global variable `wget_enum_handle'.
2696
2697 * keymap.c (describe_vector): Remove parameters `indices' and
2698 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2699 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2700
f868cd8a
JB
2701 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2702
2703 * keyboard.c (timer_check): Remove parameter `do_it_now',
2704 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2705 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2706 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2707
2708 * keyboard.c (read_char):
2709 * w32menu.c (w32_menu_display_help):
2710 * xmenu.c (show_help_event, menu_help_callback):
2711 Adjust calls to `show_help_echo'.
2712
2713 * gtkutil.c (xg_maybe_add_timer):
2714 * keyboard.c (readable_events):
2715 * process.c (wait_reading_process_output):
2716 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2717
2718 * insdel.c (adjust_markers_gap_motion):
2719 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2720 (gap_left, gap_right): Don't call it.
2721
2ecf6fdb
CY
27222011-03-25 Chong Yidong <cyd@stupidchicken.com>
2723
2724 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2725 incurred during fontification.
2726
6b1f9ba4
JB
27272011-03-25 Juanma Barranquero <lekktu@gmail.com>
2728
2729 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2730 (DEFVAR_PER_BUFFER): Don't pass it.
2731
2732 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2733 (scrolling_window): Don't pass it.
2734
0f4a96b5
JB
27352011-03-25 Juanma Barranquero <lekktu@gmail.com>
2736
2737 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2738
2739 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2740 and `suffix'.
2741 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2742 of variables specific to SELinux and computation of `encoded_absname'.
2743
2744 * image.c (XPutPixel): Remove unused variable `height'.
2745
2746 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2747
2748 * unexw32.c (get_section_info): Remove unused variable `section'.
2749
2750 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2751 (system_process_attributes): Remove unused variable `sess'.
2752 (sys_read): Remove unused variable `err'.
2753
2754 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2755 (w32_wnd_proc): Remove unused variable `isdead'.
2756 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2757 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2758 (x_create_tip_frame): Remove unused variable `tem'.
2759
2760 * w32inevt.c (w32_console_read_socket):
2761 Remove unused variable `no_events'.
2762
2763 * w32term.c (x_draw_composite_glyph_string_foreground):
2764 Remove unused variable `width'.
2765
1149507c
JB
27662011-03-24 Juanma Barranquero <lekktu@gmail.com>
2767
2768 * w32term.c (x_set_glyph_string_clipping):
2769 Don't pass uninitialized region to CombineRgn.
2770
9c88f339
JB
27712011-03-23 Juanma Barranquero <lekktu@gmail.com>
2772
2773 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2774 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2775 (Fx_close_connection): Remove unused variable `i'.
2776
2777 * w32font.c (w32font_draw): Return number of glyphs.
2778 (w32font_open_internal): Remove unused variable `i'.
2779 (w32font_driver): Add missing initializer.
2780
2781 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2782 (fill_in_menu): Remove unused variable `items_added'.
2783
2784 * w32term.c (last_mouse_press_frame): Remove static global variable.
2785 (w32_clip_to_row): Remove unused variable `f'.
2786 (x_delete_terminal): Remove unused variable `i'.
2787
2788 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2789 (NOTHING): Remove unused static global variable.
2790 (uniscribe_check_otf): Remove unused variable `table'.
2791 (uniscribe_font_driver): Add missing initializers.
2792
dee091a3
JD
27932011-03-23 Julien Danjou <julien@danjou.info>
2794
2795 * term.c (Fsuspend_tty, Fresume_tty):
2796 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2797 * window.c (temp_output_buffer_show):
2798 * insdel.c (signal_before_change):
2799 * frame.c (Fhandle_switch_frame):
2800 * fileio.c (Fdo_auto_save):
2801 * emacs.c (Fkill_emacs):
2802 * editfns.c (save_excursion_restore):
2803 * cmds.c (internal_self_insert):
2804 * callint.c (Fcall_interactively):
2805 * buffer.c (Fkill_all_local_variables):
2806 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2807 Use Frun_hooks.
0f4a96b5 2808 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2809 unconditionnaly since it does the check itself.
2810
2c520ab5 28112011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2812
c9c49752
PE
2813 Fix more problems found by GCC 4.5.2's static checks.
2814
8abc3f12
PE
2815 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2816 the first time through the loop, since we know p0 < p1 then.
2817 This also avoids a gcc -Wstrict-overflow warning.
2818
a2d26660
PE
2819 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2820 leading to a memory leak, possible in functions like
2821 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2822 of objects (Bug#8318).
a2d26660 2823
916c72e9
PE
2824 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2825 that could (at least in theory) be that large.
2826
19ab8a18
PE
2827 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2828 This is less likely to overflow, and avoids undefined behavior if
2829 overflow does occur. All callers changed. Use strtoul to scan
2830 for the unsigned long integer.
b7cbbd6f
PE
2831 (pint2hrstr): Simplify and tune code slightly.
2832 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2833
f0641eff
PE
2834 * scroll.c (do_scrolling): Work around GCC bug 48228.
2835 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2836
7f650bb9
PE
2837 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2838 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2839 (validate_x_resource_name): Simplify count usage.
2840 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2841
37dd57d1
PE
2842 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2843 fail (Bug#8306).
81e56e61 2844
699979fc 2845 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2846
401bf9b4
PE
2847 * process.c (Fmake_network_process): Use socklen_t, not int,
2848 where POSIX says socklen_t is required in portable programs.
2849 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2850 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2851 (Fmake_network_process, server_accept_connection):
2852 (wait_reading_process_output, read_process_output):
2853 Likewise.
2854
b93aacde
PE
2855 * process.c: Rename or move locals to avoid shadowing.
2856 (list_processes_1, Fmake_network_process):
2857 (read_process_output_error_handler, exec_sentinel_error_handler):
2858 Rename or move locals.
4dc343ee 2859 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2860 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2861 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2862 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2863 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2864
af8a867c 2865 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2866 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2867 Include tparam.h instead, since it declares them.
af8a867c
PE
2868 * cm.h (PC): Remove extern decl; tparam.h now does this.
2869 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2870 * terminfo.c: Include tparam.h, to check interfaces.
2871 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2872 (tparam): Adjust signature to match interface in tparam.h;
2873 this removes some undefined behavior. Check that outstring and len
2874 are zero, which they always are with Emacs.
2875 * tparam.h (PC, BC, UP): New extern decls.
2876
0248044d 2877 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2878 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2879
8ff096c1 2880 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2881 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2882 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2883 (ftfont_list): Remove unused local.
49eaafba
PE
2884 (get_adstyle_property, ftfont_pattern_entity):
2885 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2886 Rename locals to avoid shadowing.
8ff096c1 2887
e2be39f6
PE
2888 * xfont.c (xfont_list_family): Mark var as initialized.
2889
c9735e30
PE
2890 * xml.c (make_dom): Now static.
2891
8f5201ae
PE
2892 * composite.c (composition_compute_stop_pos): Rename local to
2893 avoid shadowing.
b246f932
PE
2894 (composition_reseat_it): Remove unused locals.
2895 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2896 (composition_update_it): Mark var as initialized.
11b61122
PE
2897 (find_automatic_composition): Mark vars as initialized,
2898 with a FIXME (Bug#8290).
8f5201ae 2899
760fbc2c
PE
2900 character.h: Rename locals to avoid shadowing.
2901 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2902 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2903 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2904 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2905 to avoid shadowing.
2906
ff08eb85
PE
2907 * textprop.c (property_change_between_p): Remove; unused.
2908
fc7bf025
PE
2909 * intervals.c (interval_start_pos): Now static.
2910
235d7abc
PE
2911 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2912
44f230aa
SM
2913 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2914 Rename locals to avoid shadowing.
3e7d6594 2915
50060332
PE
2916 * sound.c (wav_play, au_play, Fplay_sound_internal):
2917 Fix pointer signedness.
d01f234b 2918 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2919 (wav_play): Initialize a variable to 0, to prevent undefined
2920 behavior (Bug#8278).
50060332 2921
c4fc4e30
PE
2922 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2923
918436ed
PE
2924 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2925
c939f91b
PE
2926 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2927 clobbering (Bug#8298).
b9c7f648
PE
2928 * sysdep.c (sys_subshell): Likewise.
2929 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2930
6bd8c144
PE
2931 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2932 This should get cleaned up, so that child_setup has the
2933 same signature on all platforms.
2934
7710357c 2935 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2936 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2937
c59da222
CY
29382011-03-22 Chong Yidong <cyd@stupidchicken.com>
2939
2940 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2941 not to be necessary, and produces flickering.
2942
66b87493
GM
29432011-03-20 Glenn Morris <rgm@gnu.org>
2944
2945 * config.in: Remove file.
2946
45b6f6d5
JB
29472011-03-20 Juanma Barranquero <lekktu@gmail.com>
2948
2949 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2950 are now in src/globals.h.
2951 (syms_of_minibuf): Remove spurious & from previous change.
2952
3ec03f7e
LL
29532011-03-20 Leo <sdl.web@gmail.com>
2954
2955 * minibuf.c (completing-read-function): New variable.
2956 (completing-read-default): Rename from completing-read.
2957 (completing-read): Call completing-read-function.
2958
b14e3e21
CY
29592011-03-19 Juanma Barranquero <lekktu@gmail.com>
2960
2961 * xfaces.c (Fx_load_color_file):
2962 Read color file from absolute filename (bug#8250).
2963
f2b726e6
JB
29642011-03-19 Juanma Barranquero <lekktu@gmail.com>
2965
2966 * makefile.w32-in: Update dependencies.
2967
09f6ff02
EZ
29682011-03-17 Eli Zaretskii <eliz@gnu.org>
2969
2970 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2971
29a6015a
PE
29722011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2973
a3a6c54e
PE
2974 Fix more problems found by GCC 4.5.2's static checks.
2975
b766f867
PE
2976 * process.c (make_serial_process_unwind, send_process_trap):
2977 (sigchld_handler): Now static.
2978
be02381c
PE
2979 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2980 That way, the code declares only the vars that it needs.
2981 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2982 * s/cygwin.h (PTY_ITERATION): Likewise.
2983 * s/darwin.h (PTY_ITERATION): Likewise.
2984 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2985
57048744
PE
2986 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2987 * process.c (allocate_pty): Don't declare stb unless it's needed.
2988
7914961c 2989 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2990 (CONSTANTLIM): Remove; unused.
2991 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2992 Define only if needed.
7914961c 2993
b3967b18
PE
2994 * unexelf.c (unexec): Name an expression,
2995 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2996 Use a different way to cause a compilation error if anyone uses
2997 n rather than nn, a way that does not involve shadowing.
73366a00 2998 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2999
29a6015a
PE
3000 * deps.mk (unexalpha.o): Remove; unused.
3001
43cfc33e 3002 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3003 * unexec.h: New file.
ce701a33
PE
3004 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3005 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3006 Depend on unexec.h.
3007 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3008 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3009 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3010 Change as necessary to match prototype in unexec.h.
ce701a33 3011
01f44d5a
PE
3012 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3013 shadowing.
4f63c6bb 3014 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3015
a6670b0b
PE
3016 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3017 Rename locals to avoid shadowing.
3018
cef2010d 3019 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3020 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3021
d4d7173a
PE
3022 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3023
f08b802a
PE
3024 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3025 warning when compiling print.c.
3026
3ddb0639
PE
3027 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3028 instead of using an uninitialized var.
5ad03b97 3029 (font_sort_entities): Mark var as initialized.
3ddb0639 3030
170a2692
PE
3031 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3032
e663c700
PE
3033 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3034 pointers to constants.
89bc529a 3035 (font_parse_fcname): Remove unused vars.
7b81e2d0 3036 (font_delete_unmatched): Now static.
ea838e10 3037 (font_get_spec): Remove; unused.
13a547c6
PE
3038 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3039 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3040 Rename or move locals to avoid shadowing.
e663c700 3041
2a80c887 3042 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3043 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3044
1384fa33 3045 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3046 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3047
8b2c52e9
PE
3048 * alloc.c (mark_backtrace): Move decl from here ...
3049 * lisp.h: ... to here, so that it can be checked.
3050
475545b5 3051 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3052 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3053 (lisp_indirect_variable): Name an expression,
3054 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3055 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3056
b1349114 3057 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3058 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3059 Use const pointer when appropriate.
b1349114 3060
a2928364
PE
3061 * lisp.h (get_system_name, get_operating_system_release):
3062 Move decls here, to check interfaces.
3063 * process.c (get_operating_system_release): Move decl to lisp.h.
3064 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3065 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3066 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3067 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3068 (Fformat_time_string, Fencode_time, Finsert_char):
3069 (Ftranslate_region_internal, Fformat):
3070 Rename or remove local vars to avoid shadowing.
9710023e 3071 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3072
a415e694
PE
3073 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3074 avoid shadowing.
3075
8ef4622d
PE
3076 * lisp.h (eassert): Check that the argument compiles, even if
3077 ENABLE_CHECKING is not defined.
3078
946f9a5b
PE
3079 * data.c (Findirect_variable): Name an expression, to avoid
3080 gcc -Wbad-function-cast warning.
112396d6 3081 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3082 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3083 (Fmake_variable_buffer_local, Fmake_local_variable):
3084 Mark variables as initialized.
52746918 3085 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3086
e5aab7e7 3087 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3088 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3089 Rename locals to avoid shadowing.
dff45157
PE
3090 (mark_stack): Move local variables into the #ifdef region where
3091 they're used.
7bc26fdb
PE
3092 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3093 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3094 needed otherwise.
3095 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3096 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3097 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3098
e5aab7e7
PE
3099 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3100 avoids undefined behavior in theory.
3101
4da60324
PE
3102 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3103
88043301
PE
3104 Use functions, not macros, for up- and down-casing (Bug#8254).
3105 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3106 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3107 to use the following functions instead of these macros.
3108 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3109 EMACS_INT, since callers assume the returned value fits in int.
3110 (upcase1): Likewise, for UPCASE_TABLE.
3111 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3112 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3113 the race-condition problem in the old DOWNCASE.
88043301 3114
19ed5445
PE
3115 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3116 Rename locals to avoid shadowing.
3117 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3118 (regex_compile, re_search_2, re_match_2_internal):
3119 Remove unused local vars.
952db0d7
PE
3120 (FREE_VAR): Rewrite so as not to use empty "else",
3121 which gcc can warn about.
da053e48 3122 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3123 (RETALLOC_IF): Define only if needed.
3124 (WORDCHAR_P): Likewise. This one is never needed, but is used
3125 only in a comment talking about a compiler bug, so put inside
3126 the #if 0 of that comment.
3127 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3128 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3129 Remove; unused.
19ed5445 3130
1f3561e4 3131 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3132 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3133 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3134
ded6f8f7
PE
3135 * search.c (simple_search): Remove unused var.
3136
dbd37a95
PE
3137 * dired.c (compile_pattern): Move decl from here ...
3138 * lisp.h: ... to here, so that it can be checked.
3139 (struct re_registers): New forward decl.
3140
7e47afad
PE
3141 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3142
85f24f61
PE
3143 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3144 All uses changed.
3145 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3146 Rename locals to avoid shadowing.
5671df8f 3147 (Fvertical_motion): Mark locals as initialized.
85f24f61 3148
181aa2be 3149 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3150 (casify_region): Mark local as initialized.
181aa2be 3151
930d429c
PE
3152 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3153
7082eac6
PE
3154 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3155 New macros, so that the caller can use some names other than
3156 gcpro1, gcpro2, etc.
3157 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3158 of the new macros.
3159 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3160 argument, for consistency with GCPRO2_VAR, etc: it is now the
3161 prefix of the variable, not the variable itself. All uses
3162 changed.
38b2c076
PE
3163 * dired.c (directory_files_internal, file_name_completion):
3164 Rename locals to avoid shadowing.
3165
15206ed9
PE
3166 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3167 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3168 dired.c's scmp function, had undefined behavior.
3169 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3170 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3171 * buffer.h: ... to here, because these macros use current_buffer,
3172 and the new implementation with inline functions needs to have
3173 current_buffer in scope now, rather than later when the macros
3174 are used.
3175 (downcase, upcase1): New static inline functions.
3176 (DOWNCASE, UPCASE1): Reimplement using these functions.
3177 This avoids undefined behavior in expressions like
3178 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3179 from race conditions in accessing the global variables
3180 case_temp1 and case_temp2.
3181 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3182 * lisp.h (case_temp1, case_temp2): Remove their decls.
3183 * character.h (ASCII_CHAR_P): Move from here ...
3184 * lisp.h: ... to here, so that the inline functions mentioned
3185 above can use them.
3186
4a6bea26
PE
3187 * dired.c (directory_files_internal_unwind): Now static.
3188
f14b7e14
PE
3189 * fileio.c (file_name_as_directory, directory_file_name):
3190 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3191 Now static.
2893f146
PE
3192 (file_name_as_directory): Use const pointers when appropriate.
3193 (Fexpand_file_name): Likewise. In particular, newdir might
3194 point at constant storage, so make it a const pointer.
fd4ead52 3195 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3196 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3197 signedness issues.
f839df0c
PE
3198 (Fset_file_times, Finsert_file_contents, auto_save_error):
3199 Rename locals to avoid shadowing.
f14b7e14 3200
5716756e 3201 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3202 (Ftry_completion, Fall_completions): Rename or remove locals
3203 to avoid shadowing.
5716756e 3204
b4c3046a
PE
3205 * marker.c (bytepos_to_charpos): Remove; unused.
3206
b45db522
PE
3207 * lisp.h (verify_bytepos, count_markers): New decls,
3208 so that gcc does not warn that these functions aren't declared.
3209
85876d07
PE
3210 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3211 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3212 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3213 (copy_text): Remove unused local var.
85876d07 3214
03d78a21 3215 * filelock.c (within_one_second): Now static.
b3dd38ab 3216 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3217
5df8f01b
PE
3218 * buffer.c (fix_overlays_before): Mark locals as initialized.
3219 (fix_start_end_in_overlays): Likewise. This function should be
3220 simplified by using pointers-to-pointers, but that's a different
3221 matter.
b1d876f1 3222 (switch_to_buffer_1): Now static.
8f54f30a
PE
3223 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3224 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3225
a70072c9 3226 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3227 Fix pointer signedness issue.
edced198
PE
3228 (sys_subshell): Mark local as volatile if checking for lint,
3229 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3230 (MAXPATHLEN): Define only if needed.
a70072c9 3231
a0977c44
PE
3232 * process.c (serial_open, serial_configure): Move decls from here ...
3233 * systty.h: ... to here, so that they can be checked.
3234
a884fdcc
PE
3235 * fns.c (get_random, seed_random): Move extern decls from here ...
3236 * lisp.h: ... to here, so that they can be checked.
3237
604efe86 3238 * sysdep.c (reset_io): Now static.
b8950c94 3239 (wait_for_termination_signal): Remove; unused.
604efe86 3240
38fc62d9
PE
3241 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3242 (copy_keymap_item, append_key, push_text_char_description):
3243 Now static.
1004a21a 3244 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3245 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3246 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3247 (describe_map_tree):
3248 Rename locals to avoid shadowing.
38fc62d9 3249
2f2650da
PE
3250 * keyboard.c: Declare functions static if they are not used elsewhere.
3251 (echo_char, echo_dash, cmd_error, top_level_2):
3252 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3253 (read_char, kbd_buffer_get_event, make_lispy_position):
3254 (make_lispy_event, make_lispy_movement, apply_modifiers):
3255 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3256 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3257 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3258 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3259 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3260
a053e86c 3261 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3262 (mark_kboards): Move decl here ...
3263 * alloc.c (mark_kboards): ... from here.
a053e86c 3264
4752793e
PE
3265 * lisp.h (force_auto_save_soon): New decl.
3266
74f10ca7 3267 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3268 (DEFINE_DUMMY_FUNCTION): New macro.
3269 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3270 Use it.
c03cd23f
PE
3271 (main): Add casts to avoid warnings
3272 if GCC considers string literals to be constants.
74f10ca7 3273
022e70d4
PE
3274 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3275
59d6fe83
PE
3276 * dbusbind.c: Pointer signedness fixes.
3277 (xd_signature, xd_append_arg, xd_initialize):
3278 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3279 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3280 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3281 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3282
78320123
PE
3283 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3284 if GCC considers string literals to be constants.
49cebcca 3285 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3286
35ac2a97
SM
32872011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3288
fb103ca9
SM
3289 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3290 (print_preprocess, print_object): New macro to fix last change.
3291
35ac2a97
SM
3292 * print.c (print_preprocess): Don't forget font objects.
3293
62973b41
JB
32942011-03-16 Juanma Barranquero <lekktu@gmail.com>
3295
3296 * emacs.c (USAGE3): Doc fixes.
3297
0e48bb22
AS
32982011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3299
3300 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3301 structure.
3302
7684e57b
JB
33032011-03-14 Juanma Barranquero <lekktu@gmail.com>
3304
3305 * lisp.h (VWindow_system, Qfile_name_history):
3306 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3307 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3308 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3309
3310 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3311 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3312
3313 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3314 * w32console.c (detect_input_pending, read_input_pending)
3315 (encode_terminal_code):
3316 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3317 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3318 (w32_system_caret_y, Qfile_name_history):
3319 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3320 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3321 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3322 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3323 * w32proc.c (Qlocal, report_file_error):
3324 * w32term.c (Vwindow_system, updating_frame):
3325 * w32uniscribe.c (initialized, uniscribe_font_driver):
3326 Remove unneeded extern declarations.
3327
2aa46d6c
CY
33282011-03-14 Chong Yidong <cyd@stupidchicken.com>
3329
c96bbc66 3330 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3331
cffc6f3b
CY
33322011-03-13 Chong Yidong <cyd@stupidchicken.com>
3333
3334 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3335 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3336 These macros can no longer be used for assignment.
3337
44f230aa
SM
3338 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3339 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3340 (record_buffer_markers, fetch_buffer_markers): New functions for
3341 recording and fetching special buffer markers.
3342 (set_buffer_internal_1, set_buffer_temp): Use them.
3343
3344 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3345
3346 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3347
3348 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3349 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3350
3351 * xdisp.c (hscroll_window_tree):
3352 (reconsider_clip_changes): Use PT instead of BUF_PT.
3353
d251f04b
EZ
33542011-03-13 Eli Zaretskii <eliz@gnu.org>
3355
3356 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3357 $(EMACS_ROOT)/lib/intprops.h.
3358
f0c77cd1
PE
33592011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3360
3eca4629
PE
3361 Fix more problems found by GCC 4.5.2's static checks.
3362
7c86ee98
PE
3363 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3364 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3365 (xg_free_frame_widgets): Make it clear that a local variable is
3366 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3367 (gdk_window_get_screen): Make it clear that this macro is needed
3368 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3369 (int_gtk_range_get_value): New function, which avoids a diagnostic
3370 from gcc -Wbad-function-cast.
3371 (xg_set_toolkit_scroll_bar_thumb): Use it.
3372 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3373 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3374 (get_utf8_string, xg_get_file_with_chooser):
3375 Rename locals to avoid shadowing.
3376 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3377
41729b81
PE
3378 * xgselect.c (xg_select): Remove unused var.
3379
f0c77cd1
PE
3380 * image.c (four_corners_best): Mark locals as initialized.
3381 (gif_load): Initialize transparent_p to zero (Bug#8238).
3382 Mark another local as initialized.
ec6cf4c6 3383 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3384
ce0ad53d 3385 * image.c (clear_image_cache): Now static.
d5d5a617 3386 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3387 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3388 (x_edge_detection): Remove unnecessary cast that
3389 gcc -Wbad-function-cast diagnoses.
2037898d 3390 (gif_load): Fix pointer signedness.
6ae141d6
PE
3391 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3392 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3393
33383987 33942011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3395
d32df629
PE
3396 Improve quality of tests for time stamp overflow.
3397 For example, without this patch (encode-time 0 0 0 1 1
3398 1152921504606846976) returns the obviously-bogus value (-948597
3399 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3400 reports time overflow. See
3401 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3402 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3403 * editfns.c: Include limits.h and intprops.h.
3404 (TIME_T_MIN, TIME_T_MAX): New macros.
3405 (time_overflow): Move earlier, to before first use.
3406 (hi_time, lo_time): New functions, for an accurate test for
3407 out-of-range times.
3408 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3409 (Fget_internal_run_time): Don't assume time_t fits in int.
3410 (make_time): Use list2 instead of Fcons twice.
3411 (Fdecode_time): More accurate test for out-of-range times.
3412 (check_tm_member): New function.
3413 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3414 (lisp_time_argument): Don't rely on undefined left-shift and
3415 right-shift behavior when checking for time stamp overflow.
8be6f318 3416
fe31d94c
PE
3417 * editfns.c (time_overflow): New function, refactoring common code.
3418 (Fformat_time_string, Fdecode_time, Fencode_time):
3419 (Fcurrent_time_string): Use it.
3420
8be6f318
PE
3421 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3422 * dired.c (make_time): Move to ...
3423 * editfns.c (make_time): ... here.
3424 * systime.h: Note the move.
3425
09d9db2c 34262011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3427
126bc0dc
YM
3428 * fringe.c (update_window_fringes): Remove unused variables.
3429
c47cbdfd
YM
3430 * unexmacosx.c (copy_data_segment): Also copy __got section.
3431 (Bug#8223)
3432
7ac80be9
EZ
34332011-03-12 Eli Zaretskii <eliz@gnu.org>
3434
c96bbc66 3435 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3436 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3437 Constify `char *' arguments and their references according to
3438 prototypes in tparam.h.
3439
ecb0f94d 3440 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3441
7ac80be9
EZ
3442 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3443 Adapt all references accordingly.
3444
3445 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3446
ef1fd07e
TT
34472011-03-11 Tom Tromey <tromey@redhat.com>
3448
3449 * buffer.c (syms_of_buffer): Remove obsolete comment.
3450
7ef4b50c
EZ
34512011-03-11 Eli Zaretskii <eliz@gnu.org>
3452
3453 * termhooks.h (encode_terminal_code): Declare prototype.
3454
3455 * msdos.c (encode_terminal_code): Don't declare prototype.
3456
3457 * term.c (encode_terminal_code): Now external again, used by
3458 w32console.c and msdos.c.
3459
44f230aa
SM
3460 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3461 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3462
4b1ec863 34632011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3464
1714f52b 3465 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3466
4b1ec863
PE
3467 * fringe.c (update_window_fringes): Mark locals as initialized
3468 (Bug#8227).
3469 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3470
524c7aa6
PE
3471 * alloc.c (mark_fringe_data): Move decl from here ...
3472 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3473 to check its interface.
3474 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3475
a5c0af81 3476 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3477 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3478 (fontset_font): Mark local as initialized.
a9a06e0b 3479 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3480
b4716021
PE
3481 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3482
811e9bac 3483 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3484 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3485 (x_own_selection, Fx_disown_selection_internal): Rename locals
3486 to avoid shadowing.
3487 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3488
7e3ab302
PE
3489 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3490 so that the caller can use some name other than gcpro1.
3491 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3492 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3493 (Fx_backspace_delete_keys_p):
3494 Use them to avoid shadowing, and rename vars to avoid shadowing.
3495 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3496 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3497 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3498 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3499 Remove unused locals.
7e3ab302
PE
3500 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3501 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3502 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3503 macros.
f78faa98 3504
e2b13473
PE
3505 * xterm.h (x_mouse_leave): New decl.
3506
77f23912
PE
3507 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3508 Remove unused functions.
cdf4ba58
PE
3509 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3510 (x_calc_absolute_position): Now static.
7411c686 3511 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3512 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3513 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3514 unless they are used.
38d0b34a
PE
3515 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3516 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3517 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3518 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3519 (x_error_catcher, x_connection_closed, x_error_handler):
3520 (x_error_quitter, xembed_send_message, x_iconify_frame):
3521 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3522 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3523 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3524
44f230aa
SM
3525 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3526 Rename or move locals to avoid shadowing.
6b463e58 3527 (tty_defined_color, merge_face_heights): Now static.
5967d051 3528 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3529 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3530 does not deduce is never used uninitialized.
73719eba
PE
3531 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3532 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3533
426994c3 3534 * terminal.c (store_terminal_param): Now static.
5489860b 3535
032f1620 3536 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3537 (set_frame_menubar): Remove unused local.
d4323972 3538 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3539 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3540 since they might point to immutable storage.
281585b0
PE
3541 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3542 since it's unused otherwise.
032f1620 3543
367c19e5 3544 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3545 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3546 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3547 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3548 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3549 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3550 does not deduce are never used uninitialized.
70739cbe 3551
07b48fa9
PE
3552 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3553
8868a238 3554 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3555 * window.c (window_loop, size_window):
3556 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3557
7e5cf297 3558 * window.c (display_buffer): Now static.
d6550a9f
PE
3559 (size_window): Mark variables that gcc -Wuninitialized
3560 does not deduce are never used uninitialized.
a586633d
PE
3561 * window.h (check_all_windows): New decl, to forestall
3562 gcc -Wmissing-prototypes diagnostic.
5b555da1 3563 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3564
f6095868
PE
3565 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3566 shadowing.
3567 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3568 Include <limits.h>.
3569 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3570 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3571 (load_charset_map): Mark variables that gcc -Wuninitialized
3572 does not deduce are never used uninitialized.
53df7c11 3573 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3574
f38b440c
PE
3575 * coding.c (coding_set_source, coding_set_destination):
3576 Use "else { /* comment */ }" rather than "else /* comment */;"
3577 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3578 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3579 a block, when the outer 'i' will do.
3580 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3581 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3582 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3583 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3584 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3585 Rename locals to avoid shadowing.
3586 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3587 * coding.c (emacs_mule_char, encode_invocation_designation):
3588 Now static, since they're not used elsewhere.
413bb2db 3589 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3590 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3591 (decode_coding_emacs_mule): Mark variables that gcc
3592 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3593 (detect_coding_iso_2022): Initialize a local variable that might
3594 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3595 this initialization is needed. (Bug#8211)
5f58e762
PE
3596 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3597 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3598 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3599 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3600 Remove unused macros.
f38b440c 3601
232b38b9 3602 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3603 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3604 * character.c (string_count_byte8): Likewise.
232b38b9 3605
fb90da1b
PE
3606 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3607 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3608
fb93dbc2
PE
3609 * chartab.c (copy_sub_char_table): Now static, since it's not used
3610 elsewhere.
5c156ace
PE
3611 (sub_char_table_ref_and_range, char_table_ref_and_range):
3612 Rename locals to avoid shadowing.
bbcd0949 3613 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3614
7d3b3862 3615 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3616 (BIDI_BOB): Remove unused macro.
7d3b3862 3617
6be7d3da
PE
3618 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3619 deduce are never used uninitialized.
c2ed9c8b 3620 * term.c (encode_terminal_code): Likewise.
6be7d3da 3621
75f8807f 3622 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3623
50938595
PE
3624 * tparam.h: New file.
3625 * term.c, tparam.h: Include it.
3626 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3627 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3628 Move these decls to tparam.h, and make them agree with what
3629 is actually in tparam.c. The previous trick of using incompatible
3630 decls in different modules does not conform to the C standard.
3631 All callers of tparam changed to use tparam's actual API.
3632 * tparam.c (tparam1, tparam, tgoto):
3633 Use const pointers where appropriate.
3634
fbceeba2
PE
3635 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3636 * cm.h (struct cm): Likewise.
3637 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3638 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3639 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3640 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3641 (turn_on_face, init_tty): Likewise.
3642 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3643
7f3f1250
PE
3644 * term.c (term_mouse_position): Rename local to avoid shadowing.
3645
e6ca6543
PE
3646 * alloc.c (mark_ttys): Move decl from here ...
3647 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3648
c40f8d15
AS
36492011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3650
3651 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3652
cfe0661d
JB
36532011-03-09 Juanma Barranquero <lekktu@gmail.com>
3654
3655 * search.c (compile_pattern_1): Remove argument regp, unused since
3656 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3657 (compile_pattern): Don't pass it.
3658
0afb4571
J
36592011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3660
3661 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3662 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3663 for ! HAVE_GTK3.
3664 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3665
3666 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3667
3668 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3669 gdk_window_get_screen, gdk_window_get_geometry,
3670 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3671 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3672 (xg_get_pixbuf_from_pixmap): New function.
3673 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3674 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3675 Call xg_get_pixbuf_from_pixmap instead of
3676 gdk_pixbuf_get_from_drawable.
3677 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3678 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3679 (xg_check_special_colors): Use GtkStyleContext and its functions
3680 for HAVE_GTK3.
3681 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3682 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3683 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3684 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3685 Call gtk_widget_get_preferred_size.
0afb4571
J
3686 (xg_frame_resized): gdk_window_get_geometry only takes 5
3687 parameters.
44f230aa
SM
3688 (xg_win_to_widget, xg_event_is_for_menubar):
3689 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3690 (xg_set_widget_bg): New function.
3691 (delete_cb): New function.
895009e1 3692 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3693 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3694 (xg_set_background_color): Call xg_set_widget_bg.
3695 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3696 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3697 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3698 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3699 if ! HAVE_GTK3.
3700 (update_frame_tool_bar): Call gtk_widget_hide.
3701 (xg_initialize): Use GDK_KEY_g.
3702
3703 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3704 if ! HAVE_GTK3
3705 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3706
3707 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3708 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3709 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3710
1c2cc4ef
JB
37112011-03-08 Juanma Barranquero <lekktu@gmail.com>
3712
3713 * w32xfns.c (select_palette): Check success of RealizePalette against
3714 GDI_ERROR, not zero.
3715
33383987 3716See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3717
3718;; Local Variables:
3719;; coding: utf-8
aac0c6e3
MR
3720;; End:
3721
33383987 3722 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3723
3724 This file is part of GNU Emacs.
3725
3726 GNU Emacs is free software: you can redistribute it and/or modify
3727 it under the terms of the GNU General Public License as published by
3728 the Free Software Foundation, either version 3 of the License, or
3729 (at your option) any later version.
3730
3731 GNU Emacs is distributed in the hope that it will be useful,
3732 but WITHOUT ANY WARRANTY; without even the implied warranty of
3733 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3734 GNU General Public License for more details.
3735
3736 You should have received a copy of the GNU General Public License
3737 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.