Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
13bdea59
PE
12011-06-13 Paul Eggert <eggert@cs.ucla.edu>
2
a690a978 3 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4
578c21e6
PE
5 Remove unnecessary casts.
6 * xterm.c (x_term_init):
7 * xfns.c (x_set_border_pixel):
8 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9 These aren't needed now that we assume ANSI C.
10
96f53c6c
PE
11 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
12 It's more likely to cause problems (due to unsigned overflow)
13 than to cure them.
14
83c77d31
PE
15 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
16
ee2079f1
PE
17 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
18
6da65536
PE
19 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
20
7147c4a4
PE
21 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
22
193e32d9
PE
23 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
24
e5533da6
PE
25 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
26
9910e595
PE
27 GLYPH_CODE_FACE returns EMACS_INT, not int.
28 * dispextern.h (merge_faces):
29 * xfaces.c (merge_faces):
01103c44
PE
30 * xdisp.c (get_next_display_element, next_element_from_display_vector):
31 Don't assume EMACS_INT fits in int.
9910e595 32
2638320e
PE
33 * character.h (CHAR_VALID_P): Remove unused parameter.
34 * fontset.c, lisp.h, xdisp.c: All uses changed.
35
045eb8d9
PE
36 * editfns.c (Ftranslate_region_internal): Omit redundant test.
37
c1f134b5
PE
38 * fns.c (concat): Minor tuning based on overflow analysis.
39 This doesn't fix any bugs. Use int to hold character, instead
40 of constantly refetching from Emacs object. Use XFASTINT, not
41 XINT, for value known to be a character. Don't bother comparing
42 a single byte to 0400, as it's always less.
43
395fcb93 44 * floatfns.c (Fexpt):
327eeec8
PE
45 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
46
abbd3d23
PE
47 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
48 for characters.
49
684a03ef
PE
50 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
51
0fed43f3
PE
52 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
53 Without this fix, on a 64-bit host (aset S 0 4294967386) would
54 incorrectly succeed when S was a string, because 4294967386 was
55 truncated before it was used.
56
8fd02eb7
PE
57 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
58 Otherwise, an out-of-range integer could cause undefined behavior
59 on a 64-bit host.
60
f8c86b69
PE
61 * composite.c: Use int, not EMACS_INT, for characters.
62 (fill_gstring_body, composition_compute_stop_pos): Use int, not
63 EMACS_INT, for values that are known to be in character range.
64 This doesn't fix any bugs but is the usual style inside Emacs and
65 may generate better code on 32-bit machines.
66
34206dd2
PE
67 Make sure a 64-bit char is never passed to ENCODE_CHAR.
68 This is for reasons similar to the recent CHAR_STRING fix.
69 * charset.c (Fencode_char): Check that character arg is actually
70 a character. Pass an int to ENCODE_CHAR.
71 * charset.h (ENCODE_CHAR): Verify that the character argument is no
72 wider than 'int', as a compile-time check to prevent future regressions
73 in this area.
74
c5958d4c 75 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
76
77 Make sure a 64-bit char is never passed to CHAR_STRING.
78 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
79 by silently ignoring the top 32 bits, allowing some values
80 that were far too large to be valid characters.
81 * character.h: Include <verify.h>.
82 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
83 arguments are no wider than unsigned, as a compile-time check
84 to prevent future regressions in this area.
85 * data.c (Faset):
01103c44 86 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
87 (Fsubst_char_in_region):
88 * fns.c (concat):
89 * xdisp.c (decode_mode_spec_coding):
90 Adjust to CHAR_STRING's new requirement.
91 * editfns.c (Finsert_char, Fsubst_char_in_region):
92 * fns.c (concat): Check that character args are actually
93 characters. Without this test, these functions did the wrong
94 thing with wildly out-of-range values on 64-bit hosts.
95
d37ca623
PE
96 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
97 These casts should not be needed on 32-bit hosts, either.
98 * keyboard.c (read_char):
99 * lread.c (Fload): Remove casts to unsigned.
100
ea204efb
PE
101 * lisp.h (UNSIGNED_CMP): New macro.
102 This fixes comparison bugs on 64-bit hosts.
103 (ASCII_CHAR_P): Use it.
104 * casefiddle.c (casify_object):
01103c44 105 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
106 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
107 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
108 * dispextern.h (FACE_FROM_ID):
109 * keyboard.c (read_char): Use UNSIGNED_CMP.
110
41cb286c
PE
111 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
112 not to EMACS_INT, to avoid GCC warning.
113
4a1b9832
PE
114 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
115
55daad71
PE
116 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
117 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
118 isn't needed on 32-bit machines.
8f95c75c 119
01103c44
PE
120 * buffer.c (Fgenerate_new_buffer_name):
121 Use EMACS_INT for count, not int.
0ceccced 122 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
123
124 * data.c (Qcompiled_function): Now static.
125
c6f072e7
PE
126 * window.c (window_body_lines): Now static.
127
20ce5912
PE
128 * image.c (gif_load): Rename local to avoid shadowing.
129
9c4c5f81
PE
130 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
131 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
132 * alloc.c (make_save_value): Integer argument is now of type
133 ptrdiff_t, not int.
134 (mark_object): Use ptrdiff_t, not int.
135 * lisp.h (pD): New macro.
136 * print.c (print_object): Use it.
137
c0c5c8ae
PE
138 * alloc.c: Use EMACS_INT, not int, to count objects.
139 (total_conses, total_markers, total_symbols, total_vector_size)
140 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
141 (total_free_floats, total_floats, total_free_intervals)
142 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
143 Now EMACS_INT, not int. All uses changed.
144 (Fgarbage_collect): Compute overall total using a double, so that
145 integer overflow is less likely to be a problem. Check for overflow
146 when converting back to an integer.
5a25e253
PE
147 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
148 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
149 These were 'int' variables that could overflow on 64-bit hosts;
150 they were never used, so remove them instead of repairing them.
211a0b2a 151 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
152 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
153 Previously, this ceilinged at INT_MAX, but that doesn't work on
154 64-bit machines.
e46bb31a 155 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 156
c78baabf 157 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 158 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
159 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
160 when a (possibly-narrower) signed value would do just as well.
161 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 162
c9d624c6
PE
163 * alloc.c: Catch some string size overflows that we were missing.
164 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
165 for convenience in STRING_BYTES_MAX.
166 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
167 The definition here is exact; the one in lisp.h was approximate.
168 (allocate_string_data): Check for string overflow. This catches
169 some instances we weren't catching before. Also, it catches
170 size_t overflow on (unusual) hosts where SIZE_MAX <= min
171 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
172 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 173
c9d624c6
PE
174 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
175 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
176 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
177
353032ce
PE
178 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
179
2bccce07
PE
180 * alloc.c (Fmake_string): Check for out-of-range init.
181
e10ac9f1
MR
1822011-06-12 Martin Rudalics <rudalics@gmx.at>
183
184 * frame.c (make_frame): Call other_buffer_safely instead of
185 other_buffer.
186
187 * window.c (temp_output_buffer_show): Call display_buffer with
188 second argument Vtemp_buffer_show_specifiers and reset latter
189 immediately after the call.
190 (Vtemp_buffer_show_specifiers): New variable.
191 (auto_window_vscroll_p, next_screen_context_lines)
192 (Vscroll_preserve_screen_position): Remove leading asterisks from
193 doc-strings.
194
2d3c217e 1952011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 196
7b7f97e8 197 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
198 * buffer.c (Qclone_number): Remove for now, as it's unused.
199 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
200 (record_buffer): Remove unused local.
201 * frame.c (other_visible_frames, frame_buffer_list): Now static.
202 (set_frame_buffer_list): Remove; unused.
203 * frame.h (other_visible_frames): Remove decl.
204 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
205 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
206 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
207 if HAVE_GPM.
208 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
209 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
210 Define only if HAVE_GPM.
211 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
212 (update_hints_inhibit): Remove; never set. All uses removed.
213 * widgetprv.h (emacsFrameClassRec): Remove decl.
214 * window.c (delete_deletable_window): Now returns void, since it
215 wasn't returning anything.
216 (compare_window_configurations): Remove unused locals.
217 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
218 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
219 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
220 the same widths as pointers. This follows up on the 2011-05-06 patch.
221 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
222 * xterm.h: Likewise.
223 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
224
1384b89e
JB
2252011-06-12 Juanma Barranquero <lekktu@gmail.com>
226
227 * makefile.w32-in: Update dependencies.
228 (LISP_H): Add lib/intprops.h.
229
1100a63c
CY
2302011-06-11 Chong Yidong <cyd@stupidchicken.com>
231
232 * image.c (gif_load): Add animation frame delay to the metadata.
233 (syms_of_image): Use DEFSYM. New symbol `delay'.
234
6198ccd0
MR
2352011-06-11 Martin Rudalics <rudalics@gmx.at>
236
237 * window.c (delete_deletable_window): Re-add.
238 (Fset_window_configuration): Rewrite to handle dead buffers and
239 consequently deletable windows.
240 (window_tree, Fwindow_tree): Remove. Supply functionality in
241 window.el.
242 (compare_window_configurations): Simplify code.
243
b6e3633c
AS
2442011-06-11 Andreas Schwab <schwab@linux-m68k.org>
245
1ab0dee5
AS
246 * image.c (imagemagick_load_image): Fix type mismatch.
247 (Fimagemagick_types): Likewise.
248
b6e3633c
AS
249 * window.h (replace_buffer_in_windows): Declare.
250
9397e56f
MR
2512011-06-11 Martin Rudalics <rudalics@gmx.at>
252
253 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
254 Qclone_number. Remove external declaration of Qdelete_window.
255 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
256 code.
257 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
258 Qbuffer_list_update_hook if allowed.
259 (Fother_buffer): Rewrite doc-string. Major rewrite for new
260 buffer list implementation.
261 (other_buffer_safely): New function.
262 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
263 calls to replace_buffer_in_windows and
264 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
265 if allowed.
266 (record_buffer): Inhibit quitting and rewrite using quittable
267 functions. Run Qbuffer_list_update_hook if allowed.
268 (Frecord_buffer, Funrecord_buffer): New functions.
269 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
270 switch-to-buffer to window.el.
271 (bury-buffer): Move to window.el.
272 (Vbuffer_list_update_hook): New variable.
273
274 * lisp.h (other_buffer_safely): Add prototype in buffer.c
275 section.
276
277 * window.h (resize_frame_windows): Move up in code.
278 (Fwindow_frame): Remove EXFUN.
279 (replace_buffer_in_all_windows): Remove prototype.
280 (replace_buffer_in_windows_safely): Add prototype.
281
282 * window.c: Declare Qdelete_window static again. Move down
283 declaration of select_count.
284 (Fnext_window, Fprevious_window): Rewrite doc-strings.
285 (Fother_window): Move to window.el.
286 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
287 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
288 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
289 window.el.
290 (replace_buffer_in_windows): Implement by calling
291 Qreplace_buffer_in_windows.
292 (replace_buffer_in_all_windows): Remove with some functionality
293 moved into replace_buffer_in_windows_safely.
294 (replace_buffer_in_windows_safely): New function.
295 (select_window_norecord, select_frame_norecord): Move in front
296 of run_window_configuration_change_hook. Remove now obsolete
297 declarations.
298 (Fset_window_buffer): Rewrite doc-string. Call
299 Qrecord_window_buffer.
300 (keys_of_window): Move binding for other-window to window.el.
301
b50691aa
CY
3022011-06-11 Chong Yidong <cyd@stupidchicken.com>
303
304 * dispextern.h (struct image): Replace data member, whose int_val
305 and ptr_val fields were not used by anything, with a single
306 lisp_val object.
307
308 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
309 (gif_clear_image, gif_load, imagemagick_load_image)
310 (gs_clear_image, gs_load): Callers changed.
311
3f754b86
PE
3122011-06-10 Paul Eggert <eggert@cs.ucla.edu>
313
cca69397
PE
314 * buffer.h: Include <time.h>, for time_t.
315 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
316
109e28d0
PE
317 Fix minor problems found by static checking.
318
60737f02
PE
319 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
320
4b66faf3
PE
321 Make identifiers static if they are not used in other modules.
322 * data.c (Qcompiled_function, Qframe, Qvector):
323 * image.c (QimageMagick, Qsvg):
324 * minibuf.c (Qmetadata):
325 * window.c (resize_window_check, resize_root_window): Now static.
326 * window.h (resize_window_check, resize_root_window): Remove decls.
327
109e28d0
PE
328 * window.c (window_deletion_count, delete_deletable_window):
329 Remove; unused.
46a4ce9e
PE
330 (window_body_lines): Now static.
331 (Fdelete_other_windows_internal): Mark vars as initialized.
332 Make sure 'resize_failed' is initialized.
333 (run_window_configuration_change_hook): Rename local to avoid shadowing.
334 (resize_window_apply): Remove unused local.
335 * window.h (delete_deletable_window): Remove decl.
336
109e28d0 337 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
338 (imagemagick_load_image): Fix pointer signedness problem by changing
339 last arg from unsigned char * to char *. All uses changed.
340 Also, fix a local for similar reasons.
341 Remove unused locals. Remove locals to avoid shadowing.
342 (fn_rsvg_handle_free): Remove; unused.
343 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 344 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 345
3f754b86
PE
346 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
347
2547adb1
CY
3482011-06-10 Chong Yidong <cyd@stupidchicken.com>
349
350 * image.c (gif_load): Fix omitted cast error introduced by
351 2011-06-06 change.
352
2c8e37d4
MR
3532011-06-10 Martin Rudalics <rudalics@gmx.at>
354
355 * window.h (resize_proportionally, orig_total_lines)
356 (orig_top_line): Remove from window structure.
357 (set_window_height, set_window_width, change_window_heights)
358 (Fdelete_window): Remove prototypes.
359 (resize_frame_windows): Remove duplicate declaration.
360
440a42e3
EZ
3612011-06-10 Eli Zaretskii <eliz@gnu.org>
362
363 * window.h (resize_frame_windows, resize_window_check)
364 (delete_deletable_window, resize_root_window)
365 (resize_frame_windows): Declare prototypes.
366
367 * window.c (resize_window_apply): Make definition be "static" to
368 match the prototype.
369
562dd5e9
MR
3702011-06-10 Martin Rudalics <rudalics@gmx.at>
371
372 * window.c: Remove declarations of Qwindow_size_fixed,
373 window_min_size_1, window_min_size_2, window_min_size,
374 size_window, window_fixed_size_p, enlarge_window, delete_window.
375 Remove static from declaration of Qdelete_window, it's
376 temporarily needed by Fbury_buffer.
377 (replace_window): Don't assign orig_top_line and
378 orig_total_lines.
379 (Fdelete_window, delete_window): Remove. Window deletion is
380 handled by window.el.
381 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
382 Fdelete_window calls with calls to Qdelete_window.
383 (Fdelete_other_windows): Remove. Deleting other windows is
384 handled by window.el.
385 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
386 handled in window.el.
387 (window_min_size_2, window_min_size_1, window_min_size): Remove.
388 Window minimum sizes are handled in window.el.
389 (shrink_windows, size_window, set_window_height)
390 (set_window_width, change_window_heights, window_height)
391 (window_width, CURBEG, CURSIZE, enlarge_window)
392 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
393 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
394 handled in window.el.
395 (make_dummy_parent): Rename to make_parent_window and give it a
396 second argument horflag.
397 (make_window): Don't set resize_proportionally any more.
398 (Fsplit_window): Remove. Windows are split in window.el.
399 (save_restore_action, save_restore_orig_size)
400 (shrink_window_lowest_first, save_restore_orig_size): Remove.
401 Resize mini windows in window.el.
402 (grow_mini_window, shrink_mini_window): Implement by calling
403 Qresize_root_window_vertically, resize_window_check and
404 resize_window_apply.
405 (saved_window, Fset_window_configuration, save_window_save): Do
406 not handle orig_top_line, orig_total_lines, and
407 resize_proportionally.
408 (window_min_height, window_min_width): Move to window.el.
409 (keys_of_window): Move bindings for delete-other-windows,
410 split-window, delete-window and enlarge-window to window.el.
411
412 * buffer.c: Temporarily extern Qdelete_window.
413 (Fbury_buffer): Temporarily call Qdelete_window instead of
414 Fdelete_window (Fbury_buffer will move to window.el soon).
415
416 * frame.c (set_menu_bar_lines_1): Remove code handling
417 orig_top_line and orig_total_lines.
418
419 * dispnew.c (adjust_frame_glyphs_initially): Don't use
420 set_window_height but set heights directly.
421 (change_frame_size_1): Use resize_frame_windows.
422
423 * xdisp.c (init_xdisp): Don't use set_window_height but set
424 heights directly.
425
426 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
427 resize_frame_windows instead of change_window_heights and run
428 run_window_configuration_change_hook.
429
430 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
431 instead of change_window_heights and run
432 run_window_configuration_change_hook.
433
1a13852e
MR
4342011-06-09 Martin Rudalics <rudalics@gmx.at>
435
436 * window.c (replace_window): Rename second argument REPLACEMENT to
437 NEW. New third argument SETFLAG. Rewrite.
438 (delete_window, make_dummy_parent): Call replace_window with
439 third argument 1.
440 (window_list_1): Move down in code.
441 (run_window_configuration_change_hook): Move set_buffer part
442 before select_frame_norecord part in order to unwind correctly.
443 Rename count1 to count.
444 (recombine_windows, delete_deletable_window, resize_root_window)
445 (Fdelete_other_windows_internal)
446 (Frun_window_configuration_change_hook, make_parent_window)
447 (resize_window_check, resize_window_apply, Fresize_window_apply)
448 (resize_frame_windows, Fsplit_window_internal)
449 (Fdelete_window_internal, Fresize_mini_window_internal): New
450 functions.
451 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
452
f3d1777e
MR
4532011-06-08 Martin Rudalics <rudalics@gmx.at>
454
496e208e
MR
455 * window.h (window): Add some new members to window structure -
456 normal_lines, normal_cols, new_total, new_normal, clone_number,
457 splits, nest, prev_buffers, next_buffers.
458 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 459 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 460
f3d1777e
MR
461 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
462 Remove.
496e208e
MR
463 (make_dummy_parent): Set new members of windows structure.
464 (make_window): Move down in code. Handle new members of window
465 structure.
466 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
467 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
468 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
469 (Fset_window_prev_buffers, Fwindow_next_buffers)
470 (Fset_window_next_buffers, Fset_window_clone_number): New
471 functions.
472 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
473 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
474 Doc-string fixes.
475 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
476 Argument WINDOW can be now internal window too.
477 (Fwindow_use_time): Move up in code.
478 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
479 Rewrite doc-string.
480 (Fset_window_configuration, saved_window)
481 (Fcurrent_window_configuration, save_window_save): Handle new
482 members of window structure.
b9e809c2
MR
483 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
484 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
485 (syms_of_window): New Lisp objects Qrecord_window_buffer,
486 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
487 Qget_mru_window, Qresize_root_window,
488 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
489 Qauto_buffer_name; staticpro them.
f3d1777e 490
abde8f8c
MR
4912011-06-07 Martin Rudalics <rudalics@gmx.at>
492
493 * window.c (Fwindow_total_size, Fwindow_left_column)
494 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
495 (Fwindow_list_1): New functions.
496 (window_box_text_cols): Replace with window_body_cols.
497 (Fwindow_width, Fscroll_left, Fscroll_right): Use
498 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
499 (delete_window, Fset_window_configuration): Call
500 delete_all_subwindows with window as argument.
501 (delete_all_subwindows): Take a window as argument and not a
502 structure. Rewrite.
190b47e6
MR
503 (window_loop): Remove handling of GET_LRU_WINDOW and
504 GET_LARGEST_WINDOW.
505 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
506
507 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
508 window_box_text_cols. delete_all_subwindows now takes a
509 Lisp_Object as argument.
abde8f8c
MR
510
511 * indent.c (compute_motion, Fcompute_motion): Use
512 window_body_cols instead of window_box_text_cols.
513
fa8a67e6
MR
514 * frame.c (delete_frame): Call delete_all_subwindows with root
515 window as argument.
516
a54e3482
DC
5172011-06-07 Daniel Colascione <dan.colascione@gmail.com>
518
519 * fns.c (Fputhash): Document return value.
520
60002bf5
CY
5212011-06-06 Chong Yidong <cyd@stupidchicken.com>
522
523 * image.c (gif_load): Implement gif89a spec "no disposal" method.
524
0c671da6 5252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 526
b862a52a 527 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 528
be44ca6c
PE
529 Check for overflow when converting integer to cons and back.
530 * charset.c (Fdefine_charset_internal, Fdecode_char):
531 Use cons_to_unsigned to catch overflow.
532 (Fencode_char): Use INTEGER_TO_CONS.
533 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
534 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
535 * data.c (long_to_cons, cons_to_long): Remove.
536 (cons_to_unsigned, cons_to_signed): New functions.
537 These signal an error for invalid or out-of-range values.
538 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
539 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
540 * font.c (Ffont_variation_glyphs):
541 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
542 * lisp.h: Include <intprops.h>.
543 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
544 (cons_to_signed, cons_to_unsigned): New decls.
545 (long_to_cons, cons_to_long): Remove decls.
546 * undo.c (record_first_change): Use INTEGER_TO_CONS.
547 (Fprimitive_undo): Use CONS_TO_INTEGER.
548 * xfns.c (Fx_window_property): Likewise.
549 * xselect.c: Include <limits.h>.
550 (x_own_selection, selection_data_to_lisp_data):
551 Use INTEGER_TO_CONS.
552 (x_handle_selection_request, x_handle_selection_clear)
553 (x_get_foreign_selection, Fx_disown_selection_internal)
554 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
555 (lisp_data_to_selection_data): Use cons_to_unsigned.
556 (x_fill_property_data): Use cons_to_signed.
557 Report values out of range.
558
d1f3d2af
PE
559 Check for buffer and string overflow more precisely.
560 * buffer.h (BUF_BYTES_MAX): New macro.
561 * lisp.h (STRING_BYTES_MAX): New macro.
562 * alloc.c (Fmake_string):
563 * character.c (string_escape_byte8):
564 * coding.c (coding_alloc_by_realloc):
565 * doprnt.c (doprnt):
566 * editfns.c (Fformat):
567 * eval.c (verror):
568 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
569 since they may not be the same number.
570 * editfns.c (Finsert_char):
571 * fileio.c (Finsert_file_contents):
572 Likewise for BUF_BYTES_MAX.
573
dd52fcea
PE
574 * image.c: Use ptrdiff_t, not int, for sizes.
575 (slurp_file): Switch from int to ptrdiff_t.
576 All uses changed.
577 (slurp_file): Check that file size fits in both size_t (for
578 malloc) and ptrdiff_t (for sanity and safety).
579
7f9bbdbb
PE
580 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
581 if b->modtime has its maximal value.
582
dfe18f82
PE
583 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
584
84acfcf0
PE
585 Don't assume time_t can fit into int.
586 * buffer.h (struct buffer.modtime): Now time_t, not int.
587 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
588 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
589
ccd9a01a
PE
590 Minor fixes for signed vs unsigned integers.
591 * character.h (MAYBE_UNIFY_CHAR):
592 * charset.c (maybe_unify_char):
593 * keyboard.c (read_char, reorder_modifiers):
594 XINT -> XFASTINT, since the integer must be nonnegative.
595 * ftfont.c (ftfont_spec_pattern):
596 * keymap.c (access_keymap, silly_event_symbol_error):
597 XUINT -> XFASTINT, since the integer must be nonnegative.
598 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
599 since it makes no difference and we prefer signed.
600 * keyboard.c (record_char): Use XUINT when all the neighbors do.
601 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
602 nonnegative.
603
d6d100dd
SM
6042011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
605
606 * window.h (Fwindow_frame): Declare.
607
2b6148e4
PE
6082011-06-06 Paul Eggert <eggert@cs.ucla.edu>
609
610 * alloc.c: Simplify handling of large-request failures (Bug#8800).
611 (SPARE_MEMORY): Always define.
612 (LARGE_REQUEST): Remove.
613 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
614
f230ecc9
MR
6152011-06-06 Martin Rudalics <rudalics@gmx.at>
616
727e958e
MR
617 * lisp.h: Move EXFUNS for Fframe_root_window,
618 Fframe_first_window and Fset_frame_selected_window to window.h.
619
620 * window.h: Move EXFUNS for Fframe_root_window,
621 Fframe_first_window and Fset_frame_selected_window here from
622 lisp.h.
623
624 * frame.c (Fwindow_frame, Fframe_first_window)
625 (Fframe_root_window, Fframe_selected_window)
626 (Fset_frame_selected_window): Move to window.c.
627 (Factive_minibuffer_window): Move to minibuf.c.
628 (Fother_visible_frames_p): New function.
629
630 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
631
f230ecc9
MR
632 * window.c (decode_window, decode_any_window): Move up in code.
633 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
634 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
635 (Fwindow_buffer): Move up and rewrite doc-string.
636 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
637 (Fwindow_prev): New functions.
727e958e
MR
638 (Fwindow_frame): Move here from frame.c. Accept any window as
639 argument.
640 (Fframe_root_window, Fframe_first_window)
641 (Fframe_selected_window): Move here from frame.c. Accept frame
642 or arbitrary window as argument. Update doc-strings.
643 (Fminibuffer_window): Move up in code.
644 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
645 (Fset_frame_selected_window): Move here from frame.c.
646 Marginal rewrite.
727e958e
MR
647 (Fselected_window, select_window, Fselect_window): Move up in
648 code. Minor doc-string fixes.
f230ecc9 649
4d09bcf6
PE
6502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
651
652 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
653 Do not assume that spare memory exists; that assumption is valid
654 only if SYSTEM_MALLOC.
655 (LARGE_REQUEST): New macro, so that the issue of large requests
656 is separated from the issue of spare memory.
657
810928a2
AS
6582011-06-05 Andreas Schwab <schwab@linux-m68k.org>
659
172418ad
AS
660 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
661 format. (Bug#8806)
662
43f862f7
AS
663 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
664
810928a2
AS
665 * xfns.c (x_set_scroll_bar_default_width): Move declarations
666 before statements.
667
a059fe24
JD
6682011-06-05 Jan Djärv <jan.h.d@swipnet.se>
669
670 * gtkutil.c (xg_get_default_scrollbar_width): New function.
671
672 * gtkutil.h: Declare xg_get_default_scrollbar_width.
673
674 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
675 min width by calling x_set_scroll_bar_default_width (Bug#8505).
676
989bf368
JB
6772011-06-05 Juanma Barranquero <lekktu@gmail.com>
678
679 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
680
4b80f674
CY
6812011-06-04 Chong Yidong <cyd@stupidchicken.com>
682
683 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
684 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
685 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
686 New error handlers.
4b80f674
CY
687 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
688 Obey Vx_select_enable_clipboard_manager. Catch errors in
689 x_clipboard_manager_save (Bug#8779).
690 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 691 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 692
99a33b77 6932011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
694
695 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
696
99a33b77 6972011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
698
699 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
700 in the current matrix if keep_current_p is non-zero.
701
8264569d
EZ
7022011-06-04 Eli Zaretskii <eliz@gnu.org>
703
704 * bidi.c (bidi_level_of_next_char): Fix last change.
705
57f97249
EZ
7062011-06-03 Eli Zaretskii <eliz@gnu.org>
707
fec2107c 708 Support bidi reordering of text covered by display properties.
57f97249 709
fec2107c
EZ
710 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
711 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
712 (bidi_cache_search, bidi_cache_iterator_state)
713 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
714 (bidi_level_of_next_char, bidi_move_to_visually_next):
715 Support character positions inside a run of characters covered by a
fec2107c
EZ
716 display string.
717 (bidi_paragraph_init, bidi_resolve_explicit_1)
718 (bidi_level_of_next_char): Call bidi_fetch_char and
719 bidi_fetch_char_advance instead of FETCH_CHAR and
720 FETCH_CHAR_ADVANCE.
721 (bidi_init_it): Initialize new members.
722 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
723 definitions.
724 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
725 instead of using explicit *_CHAR codes.
d6d100dd
SM
726 (bidi_resolve_explicit, bidi_resolve_weak):
727 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
728 bidirectional text is supported only in multibyte buffers.
729 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
730 it to initialize the frame_window_p member of struct bidi_it.
731 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
732 (bidi_resolve_explicit, bidi_resolve_weak)
733 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
734 bidi_it->nchars is non-positive.
735 (bidi_level_of_next_char): Don't try to lookup the cache for the
736 next/previous character if nothing is cached there yet, or if we
737 were just reseat()'ed to a new position.
c40e2fb2 738
0e14fe90
EZ
739 * xdisp.c (set_cursor_from_row): Set start and stop points
740 according to the row's direction when priming the loop that looks
741 for the glyph on which to display cursor.
742 (single_display_spec_intangible_p): Function deleted.
743 (display_prop_intangible_p): Reimplement to call
744 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
745 Accept 3 additional arguments needed by handle_display_spec.
746 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
747 values: lists, `(when COND...)' forms, etc.
748 (single_display_spec_string_p): Support property values that are
749 lists with the argument STRING its top-level element.
750 (display_prop_string_p): Fix the condition for processing a
751 property that is a list to be consistent with handle_display_spec.
fec2107c 752 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
753 last portion of handle_display_prop.
754 (compute_display_string_pos): Accept additional argument
755 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
756 value of a `display' property is a "replacing spec".
757 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
758 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
759 the display property, but just return a value indicating whether
760 the display property will replace the characters it covers.
761 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
762 frame_window_p members of struct bidi_it.
d6d100dd
SM
763 (compute_display_string_pos, compute_display_string_end):
764 New functions.
fec2107c
EZ
765 (push_it): Accept second argument POSITION, where pop_it should
766 jump to continue iteration.
767 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 768
fec2107c
EZ
769 * keyboard.c (adjust_point_for_property): Adjust the call to
770 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
771
772 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
773 (bidi_init_it): Update prototypes.
774 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
775 (compute_display_string_pos, compute_display_string_end):
776 Declare prototypes.
fec2107c
EZ
777 (struct bidi_it): New members nchars and disp_pos. ch_len is now
778 EMACS_INT.
fc6f18ce 779
40087514 7802011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 781
57f53182
PE
782 Malloc failure behavior now depends on size of allocation.
783 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
784 * lisp.h: Change signatures accordingly.
785 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
786 All callers changed. (Bug#8762)
787
788 * gnutls.c: Use Emacs's memory allocators.
789 Without this change, the gnutls library would invoke malloc etc.
790 directly, which causes problems on non-SYNC_INPUT hosts, and which
791 runs afoul of improving memory_full behavior. (Bug#8761)
792 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
793 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
794 xfree instead of the default malloc, realloc, free.
795 (Fgnutls_boot): No need to check for memory allocation failure,
796 since xmalloc does that for us.
797
ac32cd99 798 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
799 * category.c (hash_get_category_set):
800 * ccl.c (ccl_driver):
801 * charset.c (Fdefine_charset_internal):
802 * charset.h (struct charset.hash_index):
803 * composite.c (get_composition_id, gstring_lookup_cache)
804 (composition_gstring_put_cache):
805 * composite.h (struct composition.hash_index):
806 * dispextern.h (struct image.hash):
807 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
808 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
809 (hashfn_equal, hashfn_user_defined, make_hash_table)
810 (maybe_resize_hash_table, hash_lookup, hash_put)
811 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
812 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
813 (Fsxhash, Fgethash, Fputhash, Fmaphash):
814 * image.c (make_image, search_image_cache, lookup_image)
815 (xpm_put_color_table_h):
816 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 817 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
818 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
819 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
820 * alloc.c (allocate_vectorlike):
821 Check for overflow in vector size calculations.
822 * ccl.c (ccl_driver):
823 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
824 * fns.c, image.c: Remove unnecessary static decls that would otherwise
825 need to be updated by these changes.
40087514
PE
826 * fns.c (make_hash_table, maybe_resize_hash_table):
827 Check for integer overflow with large hash tables.
0de4bb68
PE
828 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
829 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
830 (SXHASH_REDUCE): New macro.
831 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
832 Use it instead of discarding useful hash info with large hash values.
833 (sxhash_float): New function.
834 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
835 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
836 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
837 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
838 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
839 Adjust signatures to match updated version of code.
840 (consing_since_gc): Now EMACS_INT, since a single hash table can
841 use more than INT_MAX bytes.
842
698d32e2
DN
8432011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
844
845 Make it possible to build with GCC-4.6+ -O2 -flto.
846
847 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
848
fd6fa53f
SM
8492011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
850
851 * minibuf.c (get_minibuffer, read_minibuf_unwind):
852 Call minibuffer-inactive-mode.
853
864db017
JB
8542011-05-31 Juanma Barranquero <lekktu@gmail.com>
855
856 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
857 Update dependencies.
858
2ad0baf4
DN
8592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
860
861 * data.c (init_data): Remove code for UTS, this system is not
862 supported anymore.
863
4fcc2638
DN
8642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
865
866 Don't force ./temacs to start in terminal mode.
867
868 * frame.c (make_initial_frame): Initialize faces in all cases, not
869 only when CANNOT_DUMP is defined.
870 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
871
c56e0fd5
DN
8722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
873
874 * dispnew.c (add_window_display_history): Use const for the string
875 pointer. Remove declaration, not needed.
876
333d54da 8772011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 878
55d4c1b2 879 Use 'inline', not 'INLINE'.
333d54da 880 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
881 * alloc.c, fontset.c (INLINE): Remove.
882 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
883 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
884 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
885 * gmalloc.c (register_heapinfo): Use inline unconditionally.
886 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
887
738db178
DN
8882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
889
890 Make it possible to run ./temacs.
891
892 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
893 syms_of_callproc does the same thing. Remove test for
894 "initialized", do it in the caller.
895 * emacs.c (main): Avoid calling set_initial_environment when dumping.
896
620c53a6
SM
8972011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
898
899 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
900 (read_minibuf): Use get_minibuffer.
901 (syms_of_minibuf): Use DEFSYM.
902 (Qmetadata): New var.
903 * data.c (Qbuffer): Don't make it static.
904 (syms_of_data): Use DEFSYM.
905
e003a292
PE
9062011-05-31 Paul Eggert <eggert@cs.ucla.edu>
907
908 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
909 (CCL_CODE_MIN): New macro.
910
ed008a6d
PE
9112011-05-30 Paul Eggert <eggert@cs.ucla.edu>
912
3687c2ef
PE
913 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
914
ed008a6d
PE
915 * eval.c (Qdebug): Now static.
916 * lisp.h (Qdebug): Remove decl. This reverts a part of the
917 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
918 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
919
d66c4c7c
CY
9202011-05-29 Chong Yidong <cyd@stupidchicken.com>
921
922 * image.c: Various fixes to ImageMagick code comments.
923 (Fimagemagick_types): Doc fix.
924
5fbc2025
PE
9252011-05-29 Paul Eggert <eggert@cs.ucla.edu>
926
0196f88a
PE
927 Minor fixes prompted by GCC 4.6.0 warnings.
928
929 * xselect.c (converted_selections, conversion_fail_tag): Now static.
930
5fbc2025
PE
931 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
932 (x_clipboard_manager_save_all): Move extern decl to ...
933 * xterm.h: ... here, so that it can be checked for consistency.
934
1dd3c2d9
CY
9352011-05-29 Chong Yidong <cyd@stupidchicken.com>
936
937 * xselect.c (x_clipboard_manager_save_frame)
938 (x_clipboard_manager_save_all): New functions.
939 (Fx_clipboard_manager_save): Lisp function deleted.
940
941 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
942 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
943
944 * xterm.h: Update prototype.
945
5ba6571d
WX
9462011-05-28 William Xu <william.xwl@gmail.com>
947
948 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
949 exiting (Bug#8239).
950
3eaff834
JM
9512011-05-28 Jim Meyering <meyering@redhat.com>
952
e1900994 953 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
954 * fns.c (to_uchar): Define.
955 (crypto_hash_function): Use it to convert some newly-signed
956 variables to unsigned, to avoid sign-extension bugs. For example,
957 without this change, (md5 "truc") would evaluate to
958 45723a2aff78ff4fff7fff1114760e62 rather than the expected
959 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 960 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 961
0f6990a7
PE
9622011-05-27 Paul Eggert <eggert@cs.ucla.edu>
963
964 Integer overflow fixes.
c8a9ca5a 965
08686060
PE
966 * dbusbind.c: Serial number integer overflow fixes.
967 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
968 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
969 to hold a serial number that is too large for a fixnum.
970 (Fdbus_method_return_internal, Fdbus_method_error_internal):
971 Check for serial numbers out of range. Decode any serial number
59568bf0 972 that was so large that it became a float. (Bug#8722)
08686060 973
2d1fc3c7
PE
974 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
975 (Fdbus_call_method, Fdbus_call_method_asynchronously):
976 Use XFASTINT rather than XUINT when numbers are nonnegative.
977 (xd_append_arg, Fdbus_method_return_internal):
978 (Fdbus_method_error_internal): Likewise. Also, for unsigned
979 arguments, check that Lisp number is nonnegative, rather than
59568bf0 980 silently wrapping negative numbers around. (Bug#8722)
30217ff0 981 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 982 (Bug#8722)
2d1fc3c7 983
c8a9ca5a
PE
984 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
985
519e1d69
PE
986 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
987
30569699
PE
988 ccl: add integer overflow checks
989 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
990 (IN_INT_RANGE): New macros.
991 (ccl_driver): Use them to check for integer overflow when
992 decoding a CCL program. Many of the new checks are whether XINT (x)
993 fits in int; it doesn't always, on 64-bit hosts. The new version
994 doesn't catch all possible integer overflows, but it's an
847044ea 995 improvement. (Bug#8719)
30569699 996
c11285dc
PE
997 * alloc.c (make_event_array): Use XINT, not XUINT.
998 There's no need for unsigned here.
999
fdccd48e
PE
1000 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1001 This follows up to the 2011-05-06 change that substituted uintptr_t
1002 for EMACS_INT. This case wasn't caught back then.
1003
37910ab2
PE
1004 Rework Fformat to avoid integer overflow issues.
1005 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1006 now (part of C89). Include <verify.h>.
1007 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1008 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1009 (Fformat): Avoid the prepass trying to compute sizes; it was only
1010 approximate and thus did not catch overflow reliably. Instead, walk
1011 through the format just once, formatting and computing sizes as we go,
1012 checking for integer overflow at every step, and allocating a larger
1013 buffer as needed. Keep track separately whether the format is
1014 multibyte. Keep only the most-recently calculated precision, rather
1015 than them all. Record whether each argument has been converted to
1016 string. Use EMACS_INT, not int, for byte and char and arg counts.
1017 Support field widths and precisions larger than INT_MAX. Avoid
1018 sprintf's undefined behavior with conversion specifications such as %#d
1019 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1020 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1021 formatting out-of-range floating point numbers with int
1022 formats. (Bug#8668)
1023
2e6578fb
PE
1024 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1025
0ae6bdee
PE
1026 * data.c: Avoid integer truncation in expressions involving floats.
1027 * data.c: Include <intprops.h>.
1028 (arith_driver): When there's an integer overflow in an expression
1029 involving floating point, convert the integers to floating point
1030 so that the resulting value does not suffer from catastrophic
1031 integer truncation. For example, on a 64-bit host (* 4
1032 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1033 Do not rely on undefined behavior after integer overflow.
1034
de883a70
PE
1035 merge count_size_as_multibyte, parse_str_to_multibyte
1036 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1037 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1038 Check for integer overflow.
1039 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1040 since it's now a duplicate of the other. This is more of
1041 a character than a buffer op, so better that it's in character.c.
1042 * fns.c, print.c: Adjust to above changes.
1043
2ff916cb
PE
10442011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1045
1046 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1047
f1b54466
PE
10482011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1049
fb1ac845
PE
1050 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1051 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1052 (x_clipboard_manager_save): Now static.
1053 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1054
f1b54466
PE
1055 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1056 (crypto_hash_function): Now static.
1057 Fix pointer signedness problems. Avoid unnecessary initializations.
1058
a9f737ee
CY
10592011-05-27 Chong Yidong <cyd@stupidchicken.com>
1060
1061 * termhooks.h (Vselection_alist): Make it terminal-local.
1062
1063 * terminal.c (create_terminal): Initialize it.
1064
1065 * xselect.c: Support for clipboard managers.
1066 (Vselection_alist): Move to termhooks.h as terminal-local var.
1067 (LOCAL_SELECTION): New macro.
1068 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1069 (symbol_to_x_atom): Remove gratuitous arg.
1070 (x_handle_selection_request, lisp_data_to_selection_data)
1071 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1072 (x_own_selection, x_get_local_selection, x_convert_selection):
1073 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1074 (some_frame_on_display): Delete unused function.
1075 (Fx_own_selection_internal, Fx_get_selection_internal)
1076 (Fx_disown_selection_internal, Fx_selection_owner_p)
1077 (Fx_selection_exists_p): New optional frame arg.
1078 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1079 (x_handle_selection_clear): Don't treat other terminals with the
1080 same keyboard specially. Use the terminal-local Vselection_alist.
1081 (x_clear_frame_selections): Use Frun_hook_with_args.
1082
1083 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1084
1085 * xterm.h: Add support for those atoms.
1086
e067f0c1
CY
10872011-05-26 Chong Yidong <cyd@stupidchicken.com>
1088
1089 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1090 (converted_selections, conversion_fail_tag): New global variables.
1091 (x_selection_request_lisp_error): Free the above.
1092 (x_get_local_selection): Remove unnecessary code.
1093 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1094 of converted selections stored in converted_selections.
1095 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1096 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1097 (x_convert_selection): New function.
1098 (x_handle_selection_event): Simplify.
1099 (x_get_foreign_selection): Don't ignore incoming requests while
1100 waiting for an answer; this will fail when we implement
1101 SAVE_TARGETS, and seems unnecessary anyway.
1102 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1103 (Vx_sent_selection_functions): Doc fix.
1104
0f4aebc0
LL
11052011-05-26 Leo Liu <sdl.web@gmail.com>
1106
1107 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1108
e61124cd
YM
11092011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1110
1111 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1112
1113 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1114 for fringe update if it has periodic bitmap.
1115 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1116 and fringe_bitmap_periodic_p.
1117
1118 * fringe.c (get_fringe_bitmap_data): New function.
1119 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1120 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1121 row. Mark glyph row for fringe update if periodicity changed.
1122
1123 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1124 for fringe update unless it has periodic bitmap.
1125
f16d9837
KH
11262011-05-25 Kenichi Handa <handa@m17n.org>
1127
1128 * xdisp.c (get_next_display_element): Set correct it->face_id for
1129 a static composition.
1130
e1b90ef6
LL
11312011-05-24 Leo Liu <sdl.web@gmail.com>
1132
1133 * deps.mk (fns.o):
1134 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1135
1136 * fns.c (crypto_hash_function, Fsha1): New function.
1137 (Fmd5): Use crypto_hash_function.
1138 (syms_of_fns): Add Ssha1.
1139
7400048f
PE
11402011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1141
1142 * gnutls.c: Remove unused macros.
1143 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1144 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1145 Remove macros that are defined and never used.
1146 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1147
abb71cf4
CY
11482011-05-22 Chong Yidong <cyd@stupidchicken.com>
1149
1150 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1151 (Fx_get_selection_internal): Minor cleanup.
1152 (Fx_own_selection_internal): Rename arguments for consistency with
1153 select.el.
1154
6307db39
PE
11552011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1156
1157 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1158
f3d4e0a4
CY
11592011-05-22 Chong Yidong <cyd@stupidchicken.com>
1160
1161 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1162
4d8ade89
YM
11632011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1164
1165 * dispnew.c (scrolling_window): Don't exclude the case that the
1166 last enabled row in the desired matrix touches the bottom boundary.
1167
32078c8d
GM
11682011-05-21 Glenn Morris <rgm@gnu.org>
1169
1170 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1171 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1172 and add some more files.
32078c8d 1173
7285dc67
EZ
11742011-05-20 Eli Zaretskii <eliz@gnu.org>
1175
1176 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1177 report_file_error introduced by the change from 2011-05-07.
1178
89d1bd22
PE
11792011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1180
1181 * systime.h (Time): Define only if emacs is defined.
1182 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1183 where the include path doesn't have X11/X.h by default. See
1184 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1185
e23640bb 11862011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1187
1188 * composite.c (find_automatic_composition): Fix previous change.
1189
b9704ad9
GM
11902011-05-20 Glenn Morris <rgm@gnu.org>
1191
1192 * lisp.mk: New file, split from Makefile.in.
1193 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1194 (shortlisp): Remove.
1195 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1196
4a720484
GM
11972011-05-19 Glenn Morris <rgm@gnu.org>
1198
1199 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1200 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1201 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1202 (lisp): Set the order to that of loadup.el.
1203 (shortlisp): Make it a copy of $lisp.
1204 (SOME_MACHINE_LISP): Remove.
1205 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1206 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1207
a28d4396
KH
12082011-05-18 Kenichi Handa <handa@m17n.org>
1209
1210 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1211 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1212 (find_automatic_composition): Mostly rewrite for efficiency.
1213
a2b1fa8e
JB
12142011-05-18 Juanma Barranquero <lekktu@gmail.com>
1215
1216 * makefile.w32-in: Update dependencies.
1217
8e1f5610
CS
12182011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1219
1220 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1221 revision 104625).
1222
7025ee00 12232011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1224
cdfa6eab
PE
1225 Fix some integer overflow issues, such as string length overflow.
1226
06d6db33
PE
1227 * insdel.c (count_size_as_multibyte): Check for string overflow.
1228
2b4560a8
PE
1229 * character.c (lisp_string_width): Check for string overflow.
1230 Use EMACS_INT, not int, for string indexes and lengths; in
1231 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1232 the resulting string length overflows an EMACS_INT; instead,
1233 report a string overflow if no precision given. When checking for
1234 precision exhaustion, use a check that cannot possibly have
1235 integer overflow. (Bug#8675)
1236 * character.h (lisp_string_width): Adjust to new signature.
1237
cb93f9be
PE
1238 * alloc.c (string_overflow): New function.
1239 (Fmake_string): Use it. This doesn't change behavior, but saves
1240 a few bytes and will simplify future changes.
1241 * character.c (string_escape_byte8): Likewise.
1242 * lisp.h (string_overflow): New decl.
1243
1a1f3366
PE
1244 Fixups, following up to the user-interface timestamp change.
1245 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1246 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1247 * msdos.c (mouse_get_pos): Likewise.
1248 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1249 * w32gui.h (Time): Define by including "systime.h" rather than by
1250 declaring it ourselves. (Bug#8664)
1251
d4e3e4d3
PE
1252 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1253 * image.c (clear_image_cache): Likewise.
1254
f6a24d19
PE
1255 * term.c (term_mouse_position): Don't assume time_t wraparound.
1256
08dc5ae6
PE
1257 Be more systematic about user-interface timestamps.
1258 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1259 and sometimes 'EMACS_UINT', to represent these timestamps.
1260 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1261 This makes the code easier to follow, and makes it easier to catch
1262 integer overflow bugs such as Bug#8664.
1263 * frame.c (Fmouse_position, Fmouse_pixel_position):
1264 Use Time, not unsigned long, for user-interface timestamps.
1265 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1266 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1267 * keyboard.h (last_event_timestamp): Likewise.
1268 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1269 * menu.h (xmenu_show): Likewise.
1270 * term.c (term_mouse_position): Likewise.
1271 * termhooks.h (struct input_event.timestamp): Likewise.
1272 (struct terminal.mouse_position_hook): Likewise.
1273 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1274 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1275 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1276 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1277 what it was before.
1278 * menu.h, termhooks.h: Include "systime.h", for Time.
1279
8e55734a
PE
1280 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1281 Don't assume that the difference between two unsigned long values
1282 can fit into an integer. At this point, we know button_down_time
1283 <= event->timestamp, so the difference must be nonnegative, so
1284 there's no need to cast the result if double-click-time is
1285 nonnegative, as it should be; check that it's nonnegative, just in
1286 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1287 apart (about 25 days). (Bug#8664)
8e55734a 1288
841f1b75 1289 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1290 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1291
3e26f69c
PE
1292 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1293 that always fit in int. Use a sentinel instead of a counter, to
1294 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1295 * frame.h (struct frame): Use int for menu_bar_items_used
1296 instead of EMACS_INT, since it always fits in int.
3e26f69c 1297
5cc152c0
PE
1298 * menu.c (grow_menu_items): Check for int overflow.
1299
d89eb65e
PE
1300 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1301
5235bd3e
PE
1302 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1303 Before, the code was not consistent. These values cannot exceed
1304 2**31 - 1 so there's no need to make them unsigned.
1305 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1306 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1307 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1308 as modifiers.
1309 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1310
bc827e23
PE
1311 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1312 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1313 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1314 presumably because the widths might not match.
1315
78eb494e
PE
1316 * window.c (size_window): Avoid needless test at loop start.
1317
04f2d78b
CB
13182011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1319
1320 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1321
d2fc7e3d 13222011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1323
1324 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1325
d2fc7e3d 13262011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1327
1328 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1329 `width' to `bar_area_x' and `bar_area_width', respectively.
1330 (x_scroll_run): Take account of fringe background extension.
1331
04f2d78b
CB
1332 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1333 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1334 `bar_area_width', respectively.
1335 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1336 background extension.
1337
79b70037
GM
13382011-05-10 Jim Meyering <meyering@redhat.com>
1339
1340 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1341
2f142cc5
JB
13422011-05-10 Juanma Barranquero <lekktu@gmail.com>
1343
1344 * image.c (Finit_image_library): Return t for built-in image types,
1345 like pbm and xbm. (Bug#8640)
1346
57679c86
AS
13472011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1348
1349 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1350
888c9e86
EZ
13512011-05-07 Eli Zaretskii <eliz@gnu.org>
1352
b0512a1d
EZ
1353 * w32console.c (Fset_screen_color): Doc fix.
1354 (Fget_screen_color): New function.
1355 (syms_of_ntterm): Defsubr it.
1356
7285dc67
EZ
1357 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1358 unlink the temporary file if Fcall_process didn't create it in the
1359 first place.
1360 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1361 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1362 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1363 cue to call_process_cleanup not to close that handle.
1364
4d3fcc8e
BK
13652011-05-07 Ben Key <bkey76@gmail.com>
1366
1367 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1368 one of two shell specific rules, either bootstrap-temacs-CMD or
1369 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1370 to the previous implementation of the bootstrap-temacs rule.
1371 The bootstrap-temacs-CMD rule is similar to the previous
1372 implementation of the bootstrap-temacs rule except that it
1373 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1374 variable.
1375
1376 These changes, along with some changes to nt/configure.bat,
1377 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1378 earlier fix to add support for --cflags and --ldflags options
1379 that include quotes so that it works whether make uses cmd or
1380 sh as the shell.
1381
b4289b64
MA
13822011-05-06 Michael Albinus <michael.albinus@gmx.de>
1383
1384 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1385 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1386 is a constant.
1387 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1388 a string. Handle both cases.
1389 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1390 (Fdbus_register_method): Use Qinvalid_function.
1391
af4c0e28
JB
13922011-05-06 Juanma Barranquero <lekktu@gmail.com>
1393
1394 * makefile.w32-in: Update dependencies.
1395 (LISP_H): Add inttypes.h and stdin.h.
1396 (PROCESS_H): Add unistd.h.
1397
c51453d9
EZ
13982011-05-06 Eli Zaretskii <eliz@gnu.org>
1399
1400 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1401 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1402
8ff0ac3c 14032011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1404
4c4b566b
PE
1405 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1406
aab2b9b5
PE
1407 * term.c (vfatal): Remove stray call to va_end.
1408 It's not needed and the C Standard doesn't allow it here anyway.
1409
c378da0b
PE
1410 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1411 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1412
288b08c7
PE
1413 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1414 bytes.
1415
e3601888
PE
1416 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1417
db6c0e74
PE
1418 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1419
dd5963ea
PE
1420 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1421
88c9450f
PE
1422 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1423
2f9442b8
PE
1424 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1425
c032b5f8
PE
1426 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1427 * charset.c (Fdefine_charset_internal): Don't initialize
1428 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1429 32-bit int (Bug#8600).
a108c10b
PE
1430
1431 * lread.c (read_integer): Be more consistent with string-to-number.
1432 Use string_to_number to do the actual conversion; this avoids
1433 rounding errors and fixes some other screwups. Without this fix,
1434 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1435 (digit_to_number): Move earlier, for benefit of read_integer.
1436 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1437 not a digit in any supported base. (Bug#8602)
a108c10b 1438
ad5f9eea
PE
1439 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1440
aec1708a
PE
1441 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1442 to match comment at start of function. This also removes a
1443 GCC warning about overflow in a 32+64-bit port.
1444
47be4ab5
PE
1445 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1446
371cac43
PE
1447 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1448 Reported by Stefan Monnier in
1449 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1450 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1451 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1452
d01a7826
PE
1453 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1454 (EMACS_UINTPTR): Likewise, with uintptr_t.
1455
7fd47d5c
PE
1456 * lisp.h: Prefer 64-bit EMACS_INT if available.
1457 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1458 on 32-bit hosts that have 64-bit int, so that they can access
1459 large files.
122b0c86
PE
1460 However, temporarily disable this change unless the temporary
1461 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1462
8727937b
PE
1463 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1464
8ac068ac
PE
1465 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1466 This removes an assumption that EMACS_INT and long are the same
1467 width as pointers. The assumption is true for Emacs porting targets
1468 now, but we want to make other targets possible.
1469 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1470 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1471 In the rest of the code, change types of integers that hold casted
1472 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1473 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1474 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1475 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1476 No need to cast type when ORing.
1477 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1478 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1479 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1480 assume EMACS_INT is the same width as char *.
1481 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1482 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1483 Remove no-longer-needed casts.
1484 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1485 (xg_tool_bar_help_callback, xg_make_tool_item):
1486 Use EMACS_INTPTR to hold an integer
1487 that will be cast to void *; this can avoid a GCC warning
1488 if EMACS_INT is not the same width as void *.
1489 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1490 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1491 (current_message_1, set_message_1):
1492 Use a local to convert to proper width without a cast.
1493 * xmenu.c (dialog_selection_callback): Likewise.
1494
ede49d71
PE
1495 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1496 Also, don't assume VALBITS / RAND_BITS is less than 5,
1497 and don't rely on undefined behavior when shifting a 1 left into
1498 the sign bit.
1499 * lisp.h (get_random): Change signature to match.
1500
2f30ecd0
PE
1501 * lread.c (hash_string): Use size_t, not int, for hash computation.
1502 Normally we prefer signed values; but hashing is special, because
1503 it's better to use unsigned division on hash table sizes so that
1504 the remainder is nonnegative. Also, size_t is the natural width
1505 for hashing into memory. The previous code used 'int', which doesn't
1506 retain enough info to hash well into very large tables.
1507 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1508
2a866e7b
PE
1509 * dbusbind.c: Don't possibly lose pointer info when converting.
1510 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1511 Use XPNTR rather than XHASH, so that the high-order bits of
1512 the pointer aren't lost when converting through void *.
1513
51639eac
PE
1514 * eval.c (Fautoload): Don't double-shift a pointer.
1515
92394119
PE
1516 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1517
dbdb9a7c
JB
15182011-05-06 Juanma Barranquero <lekktu@gmail.com>
1519
1520 * gnutls.c (DEF_GNUTLS_FN):
1521 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1522
db7a0b4f
AS
15232011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1524
1525 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1526 marker. (Bug#8610)
1527
f7ff1b0f 15282011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1529
1530 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1531 New version that can reserve upto 2GB of heap space.
1532
f7ff1b0f 15332011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1534
1535 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1536
639c109b
TZ
15372011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1538
1539 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1540 `gnutls_certificate_set_x509_key_file'.
1541
d2127135
JB
15422011-05-05 Juanma Barranquero <lekktu@gmail.com>
1543
1544 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1545 Update dependencies.
1546
e968f4f3
JB
15472011-05-04 Juanma Barranquero <lekktu@gmail.com>
1548
1549 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1550 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1551 Remove unused parameter `fildes'.
1552 * process.c (read_process_output, send_process): Don't pass it.
1553
84d358f0
JB
15542011-05-04 Juanma Barranquero <lekktu@gmail.com>
1555
1556 Fix previous change: the library cache is defined in w32.c.
1557 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1558 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1559
0898ca10
JB
15602011-05-04 Juanma Barranquero <lekktu@gmail.com>
1561
1562 Implement dynamic loading of GnuTLS on Windows.
1563
1564 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1565 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1566 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1567 Declare.
1568
1569 * gnutls.c (Qgnutls_dll): Define.
1570 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1571 (gnutls_*): Declare function pointers.
1572 (init_gnutls_functions): New function to initialize function pointers.
1573 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1574 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1575 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1576 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1577 (emacs_gnutls_write, emacs_gnutls_read)
1578 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1579 (Fgnutls_available_p): New function.
1580 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1581 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1582 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1583
1584 * image.c: Include w32.h.
1585 (Vimage_type_cache): Delete.
1586 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1587 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1588 (w32_delayed_load): Move to w32.c.
1589
1590 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1591
1592 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1593 (w32_delayed_load): Move from image.c. When loading a library, record
1594 its filename in the :loaded-from property of the library id.
1595 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1596 Initialize and staticpro them.
1597 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1598
1599 * process.c: Include lisp.h before w32.h, not after.
1600 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1601 instead of gnutls_record_check_pending.
1602
1603 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1604
ff4de4aa
TZ
16052011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1606
1607 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1608 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1609 as passed in.
1610
abe95abb
JD
16112011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1612
1613 * xterm.c (x_set_frame_alpha): Do not set property on anything
1614 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1615
e16e55d4
JB
16162011-05-02 Juanma Barranquero <lekktu@gmail.com>
1617
1618 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1619
bafcf6a5
JB
16202011-05-02 Juanma Barranquero <lekktu@gmail.com>
1621
1622 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1623 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1624 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1625 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1626 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1627 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1628 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1629 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1630 (Qgnutls_bootprop_callbacks_verify): Make static.
1631
e7a6747f
AS
16322011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1633
19ed11ba
AS
1634 * callproc.c: Indentation fixup.
1635
e7a6747f 1636 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1637 (wait_for_termination, interruptible_wait_for_termination):
1638 Move after wait_for_termination_1.
e7a6747f 1639
1ef14cb4
LMI
16402011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1641
1642 * sysdep.c (interruptible_wait_for_termination): New function
1643 which is like wait_for_termination, but allows keyboard
1644 interruptions.
1645
1646 * callproc.c (Fcall_process): Add (:file "file") as an option for
1647 the STDOUT buffer.
1648 (Fcall_process_region): Ditto.
1649
330d880c
EZ
16502011-04-30 Eli Zaretskii <eliz@gnu.org>
1651
8db90b73
EZ
1652 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1653 rather than `XVECTOR (FOO)->size'.
1654
330d880c
EZ
1655 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1656 inttypes.h, as a gnulib replacement is used if it not available in
1657 system headers.
1658
15cbd324
EZ
16592011-04-21 Eli Zaretskii <eliz@gnu.org>
1660
1661 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1662 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1663 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1664
1665 * coding.c (coding_alloc_by_realloc): Error out if destination
1666 will grow beyond MOST_POSITIVE_FIXNUM.
1667 (decode_coding_emacs_mule): Abort if there isn't enough place in
1668 charbuf for the composition carryover bytes. Reserve an extra
1669 space for up to 2 characters produced in a loop.
1670 (decode_coding_iso_2022): Abort if there isn't enough place in
1671 charbuf for the composition carryover bytes.
1672
16732011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1674
ae940cca
EZ
1675 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1676 aborting when %lld or %lll format is passed.
1677 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1678 %llo or %llx format is passed. (Bug#8545)
1679
03ab8921
EZ
1680 * window.c (window_scroll_line_based): Use a marker instead of
1681 simple variables to record original value of point. (Bug#7952)
1682
afda1437
EZ
1683 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1684 produced by %s or %c overflows available buffer space. (Bug#8545)
1685
f76dee0c
PE
16862011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1687
1688 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1689 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1690
fdc5744d
JB
16912011-04-28 Juanma Barranquero <lekktu@gmail.com>
1692
1693 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1694
638f053a
JB
16952011-04-28 Juanma Barranquero <lekktu@gmail.com>
1696
1697 * keyboard.c (Qdelayed_warnings_hook): Define.
1698 (command_loop_1): Run `delayed-warnings-hook'
1699 if Vdelayed_warnings_list is non-nil.
1700 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1701 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1702
d178f871
EZ
17032011-04-28 Eli Zaretskii <eliz@gnu.org>
1704
1705 * doprnt.c (doprnt): Don't return value smaller than the buffer
1706 size if the message was truncated. (Bug#8545).
1707
b124fd93
JB
17082011-04-28 Juanma Barranquero <lekktu@gmail.com>
1709
1710 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1711 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1712
e810457d
PE
17132011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1714
1715 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1716
ea51cceb
JB
17172011-04-27 Juanma Barranquero <lekktu@gmail.com>
1718
1719 * makefile.w32-in: Update dependencies.
1720
94dcfacf
EZ
17212011-04-27 Eli Zaretskii <eliz@gnu.org>
1722
1723 Improve `doprnt' and its usage. (Bug#8545)
1724 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1725 `format_end'. Remove support for %l as a conversion specifier.
1726 Don't use xrealloc. Improve diagnostics when the %l size modifier
1727 is used. Update the commentary.
1728
1729 * eval.c (verror): Simplify calculation of size_t.
1730
1731 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1732 messages.
1733
f61f41d7
PE
17342011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1735
1736 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1737 change.
1738
96fb4434
PE
17392011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1740
1741 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1742 This makes this file independent of the recent pseudovector change.
1743
671875da 17442011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1745
69e9b5a3
PE
1746 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1747
b5f869a7 1748 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1749 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1750 Remove unused local.
c8926152 1751 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1752
841a1577 1753 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1754 GCC 4.6.0 optimizes based on type-based alias analysis.
1755 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1756 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1757 != &v->size, and therefore "v->size = 1; b->size = 2; return
1758 v->size;" must therefore return 1. This assumption is incorrect
1759 for Emacs, since it type-puns struct Lisp_Vector * with many other
1760 types. To fix this problem, this patch adds a new type struct
f904488f 1761 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1762 and pseudovectors, and helps optimizing compilers not get fooled
1763 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1764 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1765 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1766 the size member.
eab3844f
PE
1767 (XSETPVECTYPE): Rewrite in terms of new macro.
1768 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1769 This is a bit clearer, and further avoids the possibility of
1770 undesirable aliasing.
1771 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1772 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1773 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1774 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1775 (ASIZE): Now uses header.size rather than size.
1776 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1777 to avoid the hassle of writing XVECTOR (foo)->header.size.
1778 (struct vectorlike_header): New type.
eab3844f
PE
1779 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1780 object, to help avoid aliasing.
1781 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1782 (SUBRP): Likewise, since Lisp_Subr is a special case.
1783 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1784 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1785 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1786 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1787 changed to be "header.size" and "header.next".
1788 * buffer.h (struct buffer): Likewise.
1789 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1790 * frame.h (struct frame): Likewise.
1791 * process.h (struct Lisp_Process): Likewise.
1792 * termhooks.h (struct terminal): Likewise.
1793 * window.c (struct save_window_data, struct saved_window): Likewise.
1794 * window.h (struct window): Likewise.
1795 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1796 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1797 * buffer.c (init_buffer_once): Likewise.
1798 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1799 special case.
1800 * process.c (Fformat_network_address): Use local var for size,
1801 for brevity.
1802
0df1eac5
PE
1803 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1804
847ab9d1 1805 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1806 * data.c (atof): Remove decl; no longer used or needed.
1807 (digit_to_number): Move to lread.c.
1808 (Fstring_to_number): Use new string_to_number function, to be
1809 consistent with how the Lisp reader treats infinities and NaNs.
1810 Do not assume that floating-point numbers represent EMACS_INT
1811 without losing information; this is not true on most 64-bit hosts.
1812 Avoid double-rounding errors, by insisting on integers when
1813 parsing non-base-10 numbers, as the documentation specifies.
1814 * lisp.h (string_to_number): New decl, replacing ...
1815 (isfloat_string): Remove.
bc0a5c13 1816 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1817 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1818 appears to have been a coding error. Similarly, do not accept
1819 strings like +-1e0 as floating point numbers. Do not report
1820 overflow for integer overflows unless the base is not 10 which
1821 means we have no simple and reliable way to continue.
1822 Break out the floating-point parsing into a new
1823 function string_to_number, so that Fstring_to_number parses
1824 floating point numbers consistently with the Lisp reader.
04f2d78b 1825 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1826 (E_CHAR, EXP_INT): Remove, replacing with ...
1827 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1828 (string_to_number): New function, replacing isfloat_string.
1829 This function checks for valid syntax and produces the resulting
1830 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1831 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1832 so that overflow for non-base-10 numbers is reported only when
1833 there's no portable and simple way to convert to floating point.
452f4150 1834
67769ffc
PE
1835 * textprop.c (set_text_properties_1): Rewrite for clarity,
1836 and to avoid GCC warning about integer overflow.
1837
c20db43f
PE
1838 * intervals.h (struct interval): Use EMACS_INT for members
1839 where EMACS_UINT might cause problems. See
1840 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1841 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1842 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1843 All uses changed.
37aa2f85
PE
1844 (offset_intervals): Tell GCC not to worry about length overflow
1845 when negating a negative length.
c20db43f 1846
2538aa2f
PE
1847 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1848 (overrun_check_free): Likewise.
1849
f2d3008d
PE
1850 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1851 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1852 word size.
1853
ec8df744
PE
1854 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1855 (gnutls_make_error): Rename local to avoid shadowing.
1856 (gnutls_emacs_global_deinit): ifdef out; not used.
1857 (Fgnutls_boot): Use const for pointer to readonly storage.
1858 Comment out unused local. Fix pointer signedness problems.
1859
640ee02d
PE
1860 * lread.c (openp): Don't stuff size_t into an 'int'.
1861 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1862 about possible signed overflow.
1863
6048fb2a
PE
1864 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1865 (GDK_KEY_g): Don't define if already defined.
1866 (xg_prepare_tooltip): Avoid pointer signedness problem.
1867 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1868
fa3c87e1
PE
1869 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1870 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1871
2172544b
PE
1872 * xfns.c (Fx_window_property): Simplify a bit,
1873 to make a bit faster and to avoid GCC 4.6.0 warning.
1874 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1875
9b821a21
PE
1876 * fns.c (internal_equal): Don't assume size_t fits in int.
1877
3c616cfa
PE
1878 * alloc.c (compact_small_strings): Tighten assertion a little.
1879
c2982e87
PE
1880 Replace pEd with more-general pI, and fix some printf arg casts.
1881 * lisp.h (pI): New macro, generalizing old pEd macro to other
1882 conversion specifiers. For example, use "...%"pI"d..." rather
1883 than "...%"pEd"...".
1884 (pEd): Remove. All uses replaced with similar uses of pI.
1885 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1886 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1887 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1888 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1889 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1890 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1891 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1892 64-bit hosts.
1893 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1894 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1895 * print.c (safe_debug_print, print_object): Likewise.
1896 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1897 to int.
6f04d126
PE
1898 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1899 avoiding the 0 flag, which is not portable.
c2982e87
PE
1900 * process.c (Fmake_network_process): Use pI to avoid cast.
1901 * region-cache.c (pp_cache): Likewise.
1902 * xdisp.c (decode_mode_spec): Likewise.
1903 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1904 behavior on 64-bit hosts with printf arg.
6f04d126 1905 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1906 (x_stop_queuing_selection_requests): Likewise.
1907 (x_get_window_property): Don't truncate byte count to an 'int'
1908 when tracing.
0b432f21 1909
5e073ec7
PE
1910 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1911 here, since it parses constructs like leading '-' and spaces,
1912 which are not wanted; and it overflows with large numbers.
1913 Instead, simply match F[0-9]+, which is what is wanted anyway.
1914
36372bf9
PE
1915 * alloc.c: Remove unportable assumptions about struct layout.
1916 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1917 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1918 (allocate_vectorlike, make_pure_vector): Use the new macros,
1919 plus offsetof, to remove unportable assumptions about struct layout.
1920 These assumptions hold on all porting targets that I know of, but
1921 they are not guaranteed, they're easy to remove, and removing them
1922 makes further changes easier.
1923
0b432f21
PE
1924 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1925 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1926 (string_overrun_cookie): Now const. Use initializers that
1927 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1928 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1929 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1930 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1931 multiple of sizeof (EMACS_INT); it need not be, if
1932 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1933 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1934
895009e1
JB
19352011-04-26 Juanma Barranquero <lekktu@gmail.com>
1936
1937 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1938
6a7a1b0b
TZ
19392011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1940
1941 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1942 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1943 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1944
841a1577 19452011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1946
1947 * lisp.h (Qdebug): List symbol.
895009e1 1948 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1949 * keyboard.c (debug-on-event): New variable.
1950 (handle_user_signal): Break into debugger when debug-on-event
1951 matches the current signal symbol.
1952
f2d3ba6f
DN
19532011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1954
1955 * alloc.c (check_sblock, check_string_bytes)
1956 (check_string_free_list): Convert to standard C.
1957
42ce4c63
TZ
19582011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1959
1960 * w32.c (emacs_gnutls_push): Fix typo.
1961
825cd63c
EZ
19622011-04-25 Eli Zaretskii <eliz@gnu.org>
1963
fb11d64d
EZ
1964 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1965 "cast to pointer from integer of different size".
1966
825cd63c
EZ
1967 Improve doprnt and its use in verror. (Bug#8545)
1968 * doprnt.c (doprnt): Document the set of format control sequences
1969 supported by the function. Use SAFE_ALLOCA instead of always
1970 using `alloca'.
1971
1972 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1973 is one byte too soon. Don't use xrealloc; instead xfree and
1974 xmalloc anew.
1975
e061a11b
TZ
19762011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1977
1978 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1979 callbacks stage.
1980
1981 * gnutls.c: Renamed global_initialized to
1982 gnutls_global_initialized. Added internals for the
1983 :verify-hostname-error, :verify-error, and :verify-flags
1984 parameters of `gnutls-boot' and documented those parameters in the
1985 docstring. Start callback support.
1986 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1987 unless a fatal error occured. Call gnutls_alert_send_appropriate
1988 on error. Return error code.
1989 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1990 (emacs_gnutls_read): Likewise.
1991 (Fgnutls_boot): Return handshake error code.
1992 (emacs_gnutls_handle_error): New function.
1993 (wsaerror_to_errno): Likewise.
1994
1995 * w32.h (emacs_gnutls_pull): Add prototype.
1996 (emacs_gnutls_push): Likewise.
1997
1998 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1999 (emacs_gnutls_push): Likewise.
2000
20012011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2002
2003 * process.c (wait_reading_process_output): Check if GnuTLS
2004 buffered some data internally if no FDs are set for TLS
2005 connections.
2006
2007 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2008 (LIBS): Link to USER_LIBS.
2009 ($(BLD)/gnutls.$(0)): New target.
2010
fa6996bc
EZ
20112011-04-24 Eli Zaretskii <eliz@gnu.org>
2012
eb35682e
EZ
2013 * xdisp.c (handle_single_display_spec): Rename the
2014 display_replaced_before_p argument into display_replaced_p, to
2015 make it consistent with the commentary. Fix typos in the
2016 commentary.
2017
e2ad650c
EZ
2018 * textprop.c (syms_of_textprop): Remove dead code.
2019 (copy_text_properties): Delete obsolete commentary about an
2020 interface that was deleted long ago. Fix typos in the description
2021 of arguments.
2022
1b2de274
EZ
2023 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2024 to changes in oldXMenu/XMenu.h from 2011-04-16.
2025 <menu_help_message, prev_menu_help_message>: Constify.
2026 (IT_menu_make_room): menu->help_text is now `const char **';
2027 adjust.
2028
2029 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2030 to changes in oldXMenu/XMenu.h from 2011-04-16.
2031 (struct XMenu): Declare `help_text' `const char **'.
2032
2033 * xfaces.c <Qunspecified>: Make extern again.
2034
2035 * syntax.c: Include sys/types.h before including regex.h, as
2036 required by Posix.
2037
762b15be
EZ
2038 * doc.c (get_doc_string): Improve the format passed to `error'.
2039
2040 * doprnt.c (doprnt): Improve commentary.
2041
2042 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2043
2044 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2045 them with etags.
2046
f1052e5d
EZ
2047 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2048 changes in globals.h immediately force recompilation.
762b15be
EZ
2049 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2050 $(CURDIR)/s/ms-w32.h.
2051 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2052
fa6996bc
EZ
2053 * character.c (Fchar_direction): Function deleted.
2054 (syms_of_character): Don't defsubr it.
2055 <char-direction-table>: Deleted.
2056
e6c3da20
EZ
20572011-04-23 Eli Zaretskii <eliz@gnu.org>
2058
2059 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2060 * doprnt.c: Include limits.h.
2061 (SIZE_MAX): New macro.
04f2d78b
CB
2062 (doprnt): Return a size_t value. 2nd arg is now size_t.
2063 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2064 Improve overflow protection. Support `l' modifier for integer
2065 conversions. Support %l conversion. Don't assume an EMACS_INT
2066 argument for integer conversions and for %c.
2067
2068 * lisp.h (doprnt): Restore prototype.
2069
2070 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2071 $(SRC)/character.h.
2072
2073 * Makefile.in (base_obj): Add back doprnt.o.
2074
2075 * deps.mk (doprnt.o): Add back prerequisites.
2076 (callint.o): Depend on character.h.
2077
2078 * eval.c (internal_lisp_condition_case): Include the handler
2079 representation in the error message.
2080 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2081 when breaking from the loop.
2082
2083 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2084
2085 * callint.c (Fcall_interactively): When displaying error message
2086 about invalid control letter, pass the character's codepoint, not
2087 a pointer to its multibyte form. Improve display of the character
2088 in octal and display also its hex code.
2089
2090 * character.c (char_string): Use %x to display the (unsigned)
2091 codepoint of an invalid character, to avoid displaying a bogus
2092 negative value.
2093
2094 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2095 `error', not SYMBOL_NAME itself.
2096
2097 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2098 character arguments to `error'.
2099
2100 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2101 to `error' in error message about FINAL_CHAR argument. Make sure
2102 FINAL_CHAR is a character, and use %c when it is passed as
2103 argument to `error'.
2104
4ffd0d6b 21052011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2106
2107 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2108
2109 * w32.c: Include <time.h>.
2110 (sys_localtime): New function.
2111
4ffd0d6b 21122011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2113
2114 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2115
4ffd0d6b 2116 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2117
4ffd0d6b 21182011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2119
4ffd0d6b
GM
2120 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2121 zombies (Bug#8467).
aac0c6e3 2122
04c56954
EZ
21232011-04-19 Eli Zaretskii <eliz@gnu.org>
2124
2125 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2126 gl_state.e_property when gl_state.object is Qt.
2127
2128 * insdel.c (make_gap_larger): Remove limitation of buffer size
2129 to <= INT_MAX.
2130
16a43933
CY
21312011-04-18 Chong Yidong <cyd@stupidchicken.com>
2132
2133 * xdisp.c (lookup_glyphless_char_display)
2134 (produce_glyphless_glyph): Handle cons cell entry in
2135 glyphless-char-display.
2136 (Vglyphless_char_display): Document it.
2137
2138 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2139 glyphless-char-display.
2140
4581706e
CY
21412011-04-17 Chong Yidong <cyd@stupidchicken.com>
2142
2143 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2144
2145 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2146
2147 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2148 definition for no-X builds.
2149
4887c6e2 21502011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2151
fd35b6f9
PE
2152 Static checks with GCC 4.6.0 and non-default toolkits.
2153
5c1ccb01
PE
2154 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2155
006c5daa
PE
2156 * process.c (keyboard_bit_set): Define only if SIGIO.
2157 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2158 (send_process): Repair possible setjmp clobbering.
2159
efc736d3
PE
2160 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2161
4e2fe2e6
PE
2162 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2163
f97334a2
PE
2164 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2165
4e75f29d
PE
2166 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2167 Define only if needed.
2168
90efadd1
PE
2169 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2170 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2171 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2172
3c647824
PE
2173 * dispextern.h (struct redisplay_interface): Rename param
2174 to avoid shadowing.
e264f262 2175 * termhooks.h (struct terminal): Likewise.
761383f4 2176 * xterm.c (xembed_send_message): Likewise.
3c647824 2177
b58c5c4a
PE
2178 * insdel.c (make_gap_smaller): Define only if
2179 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2180
cad59032
PE
2181 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2182 it.
2183
c339dc2e
PE
2184 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2185 so that we aren't warned about unused symbols.
2186
91a3e27b
PE
2187 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2188
399c71d3 2189 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2190
8ffc96f5
PE
2191 * xfns.c (x_real_positions): Mark locals as initialized.
2192
eef9bc79
PE
2193 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2194
098db9dd
PE
2195 * xterm.c: Fix problems found by static analysis with other toolkits.
2196 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2197 (x_dispatch_event): Declare static if USE_GTK, and
2198 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2199 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2200 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2201 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2202 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2203
eb18f6cc
PE
2204 * xmenu.c (menu_help_callback): Pointer type fixes.
2205 Use const pointers when pointing at readonly data. Avoid pointer
2206 signedness clashes.
2207 (FALSE): Remove unused macro.
2208 (update_frame_menubar): Remove unused decl.
2209
1fe72bf8
PE
2210 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2211
60d9e1db
PE
2212 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2213 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2214 (single_menu_item): Rename local to avoid shadowing.
2215
39261c26
PE
2216 * keyboard.c (make_lispy_event): Remove unused local var.
2217
018c5e19
PE
2218 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2219 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2220
63d2b86e
PE
2221 * bitmaps: Change bitmaps from unsigned char back to the X11
2222 compatible char. Avoid the old compiler warnings about
2223 out-of-range initializers by using, for example, '\xab' rather
2224 than 0xab.
2225
aefd87e1
PE
2226 * xgselect.c (xgselect_initialize): Check vs interface
2227 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2228
bf501fb9
PE
2229 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2230
e9829fdf
PE
2231 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2232 to read-only memory.
2233
1086c095
PE
2234 * fns.c (vector): Remove; this old hack is no longer needed.
2235
2baccd04 2236 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2237 Remove unused var.
dde42981 2238 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2239
72391843 2240 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2241
436c16df 2242 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2243 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2244 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2245
92bb796d 2246 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2247 (x_term_init): Remove local to avoid shadowing.
92bb796d 2248
764430a3 2249 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2250
2251 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2252 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2253
d1dfb56c
EZ
22542011-04-16 Eli Zaretskii <eliz@gnu.org>
2255
c4354cb4
EZ
2256 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2257
d1dfb56c
EZ
2258 Fix regex.c, syntax.c and friends for buffers > 2GB.
2259 * syntax.h (struct gl_state_s): Declare character position members
2260 EMACS_INT.
2261
2262 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2263
04f2d78b
CB
2264 * textprop.c (verify_interval_modification, interval_of):
2265 Declare arguments EMACS_INT.
d1dfb56c
EZ
2266
2267 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2268 EMACS_INT.
2269
2270 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2271
2272 * indent.c (Fvertical_motion): Local variable it_start is now
2273 EMACS_INT.
2274
2275 * regex.c (re_match, re_match_2, re_match_2_internal)
2276 (bcmp_translate, regcomp, regexec, print_double_string)
2277 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2278 (re_compile_pattern, re_exec): Declare arguments and local
2279 variables `size_t' and `ssize_t' and return values `regoff_t', as
2280 appropriate.
2281 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2282 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2283 <compile_stack_type>: `size' and `avail' are now `size_t'.
2284
2285 * regex.h <regoff_t>: Use ssize_t, not int.
2286 (re_search, re_search_2, re_match, re_match_2): Arguments that
2287 specify buffer/string position and length are now ssize_t and
2288 size_t. Return type is regoff_t.
2289
613052cd
BK
22902011-04-16 Ben Key <bkey76@gmail.com>
2291
2292 * nsfont.m: Fixed bugs in ns_get_family and
2293 ns_descriptor_to_entity that were caused by using free to
2294 deallocate memory blocks that were allocated by xmalloc (via
2295 xstrdup). This caused Emacs to crash when compiled with
2296 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2297 --enable-checking=xmallocoverrun). xfree is now used to
2298 deallocate these memory blocks.
2299
4170f62f 23002011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2301
71b41406
PE
2302 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2303
9587a89d
PE
2304 emacs_write: Accept and return EMACS_INT for sizes.
2305 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2306 et seq.
2307 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2308 Accept and return EMACS_INT.
2309 (emacs_gnutls_write): Return the number of bytes written on
2310 partial writes.
2311 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2312 (emacs_read, emacs_write): Remove check for negative size, as the
2313 Emacs source code has been audited now.
9587a89d
PE
2314 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2315 (emacs_read, emacs_write): Use it.
273a5f82
PE
2316 * process.c (send_process): Adjust to the new signatures of
2317 emacs_write and emacs_gnutls_write. Do not attempt to store
2318 a byte offset into an 'int'; it might overflow.
9587a89d 2319 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2320
3e047f51
PE
2321 * sound.c: Don't assume sizes fit in 'int'.
2322 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2323 Return EMACS_INT, not int.
3e047f51 2324 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2325 Accept EMACS_INT, not int.
2326 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2327 record read return values.
2328
cc39a9db
BK
23292011-04-15 Ben Key <bkey76@gmail.com>
2330
c9d0ec6d
JB
2331 * keyboard.c (Qundefined): Don't declare static since it is used
2332 in nsfns.m.
2333 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2334 static since they are used in nsfont.m.
cc39a9db 2335
6c60eb9f
SM
23362011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2337
2338 * process.c (Qprocessp): Don't declare static.
2339 * lisp.h (Qprocessp): Declare again.
2340
7990b61a
JB
23412011-04-15 Juanma Barranquero <lekktu@gmail.com>
2342
2343 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2344
5d4cb038
PE
23452011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2346
8bd7b830 2347 Improve C-level modularity by making more things 'static'.
cd64ea1d 2348
e3b27b31
PE
2349 Don't publish debugger-only interfaces to other modules.
2350 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2351 (verify_bytepos, count_markers): Move decls to the only modules
2352 that need them.
2353 * region-cache.h (pp_cache): Likewise.
2354 * window.h (check_all_windows): Likewise.
2355 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2356
5d4cb038
PE
2357 * sysdep.c (croak): Now static, if
2358 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2359 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2360
2361 * alloc.c (refill_memory_reserve): Now static if
2362 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2363 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2364
e87b6180
PE
2365 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2366 Define only if USE_LUCID.
2367
ac64929e
PE
2368 * xrdb.c (x_customization_string, x_rm_string): Now static.
2369
6f37259d
PE
2370 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2371 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2372
1683e3ab
PE
2373 * xdisp.c (draw_row_with_mouse_face): Now static.
2374 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2375
de9c2632
PE
2376 * window.h (check_all_windows): Mark externally visible.
2377
2b96acb7
PE
2378 * window.c (window_deletion_count): Now static.
2379
2380 * undo.c: Make symbols static if they're not exported.
2381 (last_undo_buffer, last_boundary_position, pending_boundary):
2382 Now static.
2383
50436f33
PE
2384 * textprop.c (interval_insert_behind_hooks): Now static.
2385 (interval_insert_in_front_hooks): Likewise.
2386
64520e5c
PE
2387 * term.c: Make symbols static if they're not exported.
2388 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2389 (max_frame_lines, tty_set_terminal_modes):
2390 (tty_reset_terminal_modes, tty_turn_off_highlight):
2391 (get_tty_terminal): Now static.
2392 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2393 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2394 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2395 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2396 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2397
1fa53021
PE
2398 * sysdep.c: Make symbols static if they're not exported.
2399 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2400 Now static.
2401 (sigprocmask_set, full_mask): Remove; unused.
2402 (wait_debugging): Mark as visible.
2403 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2404 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2405
d4b43b22
PE
2406 * syntax.c (syntax_temp): Define only if !__GNUC__.
2407
b7c513d0
PE
2408 * sound.c (current_sound_device, current_sound): Now static.
2409
989b29ad
PE
2410 * search.c (searchbufs, searchbuf_head): Now static.
2411
13a55a78
PE
2412 * scroll.c (scroll_cost): Remove; unused.
2413 * dispextern.h (scroll_cost): Remove decl.
2414
de68a1fc
PE
2415 * region-cache.h (pp_cache): Mark as externally visible.
2416
40ccffa6
PE
2417 * process.c: Make symbols static if they're not exported.
2418 (process_tick, update_tick, create_process, chan_process):
2419 (Vprocess_alist, proc_buffered_char, datagram_access):
2420 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2421 (deactivate_process): Mark defn as static, as well as decl.
2422 * lisp.h (create_process): Remove decl.
2423 * process.h (chan_process, Vprocess_alist): Remove decls.
2424
ad64fc97
PE
2425 * print.c: Make symbols static if they're not exported.
2426 (print_depth, new_backquote_output, being_printed, print_buffer):
2427 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2428 (print_interval, print_number_index, initial_stderr_stream):
2429 Now static.
2430 * lisp.h (Fprinc): Remove decl.
2431 (debug_output_compilation_hack): Mark as externally visible.
2432
adddb265
PE
2433 * sysdep.c (croak): Move decl from here to syssignal.h.
2434 * syssignal.h (croak): Put it here, so the API can be checked when
2435 'croak' is called from dissociate_if_controlling_tty.
2436
1717ede2
PE
2437 * minibuf.c: Make symbols static if they're not exported.
2438 (minibuf_save_list, choose_minibuf_frame): Now static.
2439 * lisp.h (choose_minibuf_frame): Remove decl.
2440
fa5fb2bc
PE
2441 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2442
1e3890d1
PE
2443 * lread.c: Make symbols static if they're not exported.
2444 (read_objects, initial_obarray, oblookup_last_bucket_number):
2445 Now static.
2446 (make_symbol): Remove; unused.
2447 * lisp.h (initial_obarray, make_symbol): Remove decls.
2448
8a1414fa
PE
2449 * keyboard.c: Make symbols static if they're not exported.
2450 (single_kboard, recent_keys_index, total_keys, recent_keys):
2451 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2452 (this_single_command_key_start, echoing, last_auto_save):
2453 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2454 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2455 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2456 (Vlispy_mouse_stem, double_click_count):
2457 Now static.
2458 (force_auto_save_soon): Define only if SIGDANGER.
2459 (ignore_mouse_drag_p): Now static if
2460 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2461 (print_help): Remove; unused.
2462 (stop_character, last_timer_event): Mark as externally visible.
2463 * keyboard.h (ignore_mouse_drag_p): Declare only if
2464 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2465 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2466 * lisp.h (echoing): Remove decl.
2467 (force_auto_save_soon): Declare only if SIGDANGER.
2468 * xdisp.c (redisplay_window): Simplify code, to make it more
2469 obvious that ignore_mouse_drag_p is not accessed if !defined
2470 USE_GTK && !defined HAVE_NS.
2471
93ea6e8f
PE
2472 * intervals.c: Make symbols static if they're not exported.
2473 (merge_properties_sticky, merge_interval_right, delete_interval):
2474 Now static.
2475 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2476
77382fcc
PE
2477 * insdel.c: Make symbols static if they're not exported.
2478 However, leave prepare_to_modify_buffer alone. It's never
2479 called from outside this function, but that appears to be a bug.
2480 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2481 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2482 (adjust_after_replace_noundo): Remove; unused.
2483 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2484 (signal_before_change): Remove decls.
77382fcc 2485
9306c32e
PE
2486 * indent.c (val_compute_motion, val_vmotion): Now static.
2487
cd44d2eb
PE
2488 * image.c: Make symbols static if they're not exported.
2489 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2490 if USE_GTK.
2491 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2492 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2493
ad9a7a06
PE
2494 * fringe.c (standard_bitmaps): Now static.
2495 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2496
81626931
PE
2497 * frame.c: Make symbols static if they're not exported.
2498 (x_report_frame_params, make_terminal_frame): Now static.
2499 (get_frame_param): Now static, unless HAVE_NS.
2500 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2501 (x_get_resource_string): Remove; not used.
2502 * frame.h (make_terminal_frame, x_report_frame_params):
2503 (x_get_resource_string); Remove decls.
2504 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2505 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2506
239f9db9
PE
2507 * font.c, fontset.c: Make symbols static if they're not exported.
2508 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2509 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2510 * font.c (font_close_object): Now static.
2511 * font.h (font_close_object): Remove.
2512 * fontset.c (FONTSET_OBJLIST): Remove.
2513 (free_realized_fontset) #if-0 the body, which does nothing.
2514 (face_suitable_for_char_p): #if-0, as it's never called.
2515 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2516 * xfaces.c (face_at_string_position):
2517 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2518 since 0 is always ASCII.
2519
dfcf3579
PE
2520 * fns.c (weak_hash_tables): Now static.
2521
5045092b
PE
2522 * fileio.c: Make symbols static if they're not exported.
2523 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2524 (Vwrite_region_annotation_buffers): Now static.
2525
57a96f5c
PE
2526 * eval.c: Make symbols static if they're not exported.
2527 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2528 * lisp.h (backtrace_list): Remove decl.
2529
35f08c38
PE
2530 * emacs.c: Make symbols static if they're not exported.
2531 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2532 (fatal_error_code, fatal_error_signal_hook, standard_args):
2533 Now static.
2534 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2535 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2536 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2537 * lisp.h (fatal_error_signal_hook): Remove decl.
2538 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2539
f44bd759
PE
2540 * editfns.c: Move a (normally-unused) function to its only use.
2541 * editfns.c, lisp.h (get_operating_system_release): Remove.
2542 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2543 worth the hassle of breaking this out.
2544
b532497d
PE
2545 * xterm.c: Make symbols static if they're not exported.
2546 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2547 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2548 (x_destroy_window, x_delete_display):
2549 Now static.
2550 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2551 (x_mouse_leave): Remove; unused.
2552 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2553 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2554 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2555 Remove decls.
2556 (x_mouse_leave): Declare only if WINDOWSNT.
2557 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2558 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2559 USE_X_TOOLKIT.
2560
1675728f
PE
2561 * ftxfont.c: Make symbols static if they're not exported.
2562 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2563 HAVE_FREETYPE.
2564 * font.h (ftxfont_driver): Likewise.
2565
e4cebfca
PE
2566 * xfns.c: Make symbols static if they're not exported.
2567 (x_last_font_name, x_display_info_for_name):
2568 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2569 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2570 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2571 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2572 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2573 (last_show_tip_args): Now static.
2574 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2575 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2576 (x_screen_planes): Remove; unused.
2577 * dispextern.h (x_screen_planes): Remove decl.
2578
5bf46f05
PE
2579 * dispnew.c: Make symbols static if they're not exported.
2580 * dispextern.h (redraw_garbaged_frames, scrolling):
2581 (increment_row_positions): Remove.
2582 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2583 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2584 Now static.
2585 (redraw_garbaged_frames): Remove; unused.
2586
435f4c28
PE
2587 * xfaces.c: Make symbols static if they're not exported.
2588 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2589 Remove decls.
2590 * xterm.h (defined_color): Remove decls.
2591 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2592 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2593 (menu_face_changed_default, defined_color, free_realized_face):
2594 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2595 (ascii_face_of_lisp_face): Remove; unused.
2596
8524aef3
PE
2597 * xdisp.c: Make symbols static if they're not exported.
2598 * dispextern.h (scratch_glyph_row, window_box_edges):
2599 (glyph_to_pixel_coords, set_cursor_from_row):
2600 (get_next_display_element, set_iterator_to_next):
2601 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2602 (show_mouse_face): Remove decls
2603 * frame.h (message_buf_print): Likewise.
2604 * lisp.h (pop_message, set_message, check_point_in_composition):
2605 Likewise.
2606 * xterm.h (set_vertical_scroll_bar): Likewise.
2607 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2608 (message_buf_print, scratch_glyph_row, displayed_buffer):
2609 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2610 (get_next_display_element, show_mouse_face, window_box_edges):
2611 (frame_to_window_pixel_xy, check_point_in_composition):
2612 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2613 (glyph_to_pixel_coords): Remove; unused.
2614
16390cd2
PE
2615 * dired.c (file_name_completion): Now static.
2616
2617 * dbusbind.c (xd_in_read_queued_messages): Now static.
2618
a25f4dfa
PE
2619 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2620 * data.c (circular_list_error): Remove.
2621
14a9c8df
PE
2622 * commands.h (last_point_position, last_point_position_buffer):
2623 (last_point_position_window): Remove decls.
2624 * keyboard.c: Make these variables static.
2625
04f2d78b
CB
2626 * coding.h (coding, code_convert_region, encode_coding_gap):
2627 Remove decls.
74ab6df5
PE
2628 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2629 (iso_code_class, detect_coding, code_convert_region): Now static.
2630 (encode_coding_gap): Remove; unused.
2631
38dfbee1
PE
2632 * chartab.c (chartab_chars, chartab_bits): Now static.
2633
a2cb4e63
PE
2634 * charset.h (charset_iso_8859_1): Remove decl.
2635 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2636 Now static.
2637
127198fd
PE
2638 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2639 * ccl.c (Vccl_program_table): Now static.
2640 (check_ccl_update): Remove; unused.
2641
d85b608f
PE
2642 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2643 * category.h: ... from here.
2644 * category.c (check_category_table, set_category_set): Now static.
2645
31cd66f3
PE
2646 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2647 * lisp.h: Remove these decls.
2648
c358e587
PE
2649 * buffer.c (buffer_count): Remove unused var.
2650
e78aecca
PE
2651 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2652 so that it's not optimized away.
2653 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2654 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2655 exported only to the debugger.
2656
e192d7d3 2657 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2658 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2659
92470028
PE
2660 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2661 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2662 was inaccessible from Lisp.
2663 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2664 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2665
244ed907
PE
2666 alloc.c: Import and export fewer symbols, and remove unused items.
2667 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2668 is defined.
2669 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2670 it's not optimized away by whole-program optimization.
2671 (message_enable_multibyte, free_misc): Remove.
2672 (catchlist, handlerlist, mark_backtrace):
2673 Declare only if BYTE_MARK_STACK.
2674 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2675 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2676 (message_enable_multibyte): Remove decl.
2677 (free_misc, interval_free_list, float_block, float_block_index):
2678 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2679 (cons_free_list, last_marked_index):
2680 Now static.
2681 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2682 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2683 (mark_backtrace): Define only if BYTE_MARK_STACK.
2684 * xdisp.c (message_enable_multibyte): Now static.
2685
61c2b50e 2686 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2687 This makes it easier for human readers (and static analyzers)
2688 to see whether these variables are used from other modules.
2689 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2690 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2691 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2692 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2693 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2694 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2695 * xmenu.c, xselect.c:
2696 Declare Q* vars static if they are not used in other modules.
2697 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2698 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2699 Remove decls of unexported vars.
2700 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2701
95c82688
PE
2702 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2703
16a97296
PE
2704 Make Emacs functions such as Fatom 'static' by default.
2705 This makes it easier for human readers (and static analyzers)
2706 to see whether these functions can be called from other modules.
2707 DEFUN now defines a static function. To make the function external
2708 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2709 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2710 (Finit_image_library):
16a97296
PE
2711 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2712 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2713 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2714 Remove decls, since these functions are now static.
2715 (Funintern, Fget_internal_run_time): New decls, since these functions
2716 were already external.
95c82688 2717
16a97296
PE
2718 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2719 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2720 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2721 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2722 * keyboard.c, keymap.c, lread.c:
2723 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2724 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2725 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2726 Mark functions with DEFUE instead of DEFUN,
2727 if they are used in other modules.
2728 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2729 decls for now-static functions.
2730 * buffer.h (Fdelete_overlay): Remove decl.
2731 * callproc.c (Fgetenv_internal): Mark as internal.
2732 * composite.c (Fremove_list_of_text_properties): Remove decl.
2733 (Fcomposition_get_gstring): New forward static decl.
2734 * composite.h (Fcomposite_get_gstring): Remove decl.
2735 * dired.c (Ffile_attributes): New forward static decl.
2736 * doc.c (Fdocumntation_property): New forward static decl.
2737 * eval.c (Ffetch_bytecode): New forward static decl.
2738 (Funintern): Remove extern decl; now in .h file where it belongs.
2739 * fileio.c (Fmake_symbolic_link): New forward static decl.
2740 * image.c (Finit_image_library): New forward static decl.
2741 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2742 * intervals.h (Fprevious_property_change):
2743 (Fremove_list_of_text_properties): Remove decls.
2744 * keyboard.c (Fthis_command_keys): Remove decl.
2745 (Fcommand_execute): New forward static decl.
2746 * keymap.c (Flookup_key): New forward static decl.
2747 (Fcopy_keymap): Now static.
2748 * keymap.h (Flookup_key): Remove decl.
2749 * process.c (Fget_process): New forward static decl.
2750 (Fprocess_datagram_address): Mark as internal.
2751 * syntax.c (Fsyntax_table_p): New forward static decl.
2752 (skip_chars): Remove duplicate decl.
2753 * textprop.c (Fprevious_property_change): New forward static decl.
2754 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2755 Now internal.
2756 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2757 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2758
785bbd42
PE
2759 * editfns.c (Fformat): Remove unreachable code.
2760
8b913b57
AS
27612011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2762
2763 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2764 change. (Bug#8496)
2765
a6744a35
EZ
27662011-04-13 Eli Zaretskii <eliz@gnu.org>
2767
2768 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2769 when at ZV. (Bug#8487)
2770
e7974947
AS
27712011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2772
baad03f0
AS
2773 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2774 (Bug#8437)
2775 * keyboard.c (parse_tool_bar_item): Likewise.
2776 * sound.c (sound_cleanup, alsa_close): Likewise.
2777 * termcap.c (tgetent): Likewise.
2778 * xfns.c (x_default_font_parameter): Likewise.
2779 * xsettings.c (read_and_apply_settings): Likewise.
2780
e7974947
AS
2781 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2782 (overrun_check_free): Protoize.
2783
28272684
PE
27842011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2785
2786 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2787 since callers should never pass a negative size.
2788 Change the signature to match that of plain 'read' and 'write'; see
2789 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2790 * lisp.h: Update prototypes of emacs_write and emacs_read.
2791
11997c76
EZ
27922011-04-11 Eli Zaretskii <eliz@gnu.org>
2793
2794 * xdisp.c (redisplay_window): Don't try to determine the character
2795 position of the scroll margin if the window start point w->startp
e896f03c 2796 is outside the buffer's accessible region. (Bug#8468)
11997c76 2797
8a2cbd72
EZ
27982011-04-10 Eli Zaretskii <eliz@gnu.org>
2799
2800 Fix write-region and its subroutines for buffers > 2GB.
2801 * fileio.c (a_write, e_write): Modify declaration of arguments and
2802 local variables to support buffers larger than 2GB.
2803 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2804
2805 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2806 argument, local variables, and return value.
2807
2808 * lisp.h: Update prototypes of emacs_write and emacs_read.
2809
2810 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2811
4073e537 28122011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2813
1ebfdcb6
PE
2814 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2815
b2ded58d
PE
2816 Fix more problems found by GCC 4.6.0's static checks.
2817
7d66342c
PE
2818 * xdisp.c (vmessage): Use a better test for character truncation.
2819
bbf47d44
PE
2820 * charset.c (load_charset_map): <, not <=, for optimization,
2821 and to avoid potential problems with integer overflow.
9248994d 2822 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2823 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2824 * editfns.c (Fformat): Likewise.
1e69125e 2825 * syntax.c (skip_chars): Likewise.
3befa583 2826
e3019616
PE
2827 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2828 This also lets GCC 4.6.0 generate slightly better loop code.
2829
becfa255
PE
2830 * callint.c (Fcall_interactively): <, not <=, for optimization.
2831 (Fcall_interactively): Count the number of arguments produced,
2832 not the number of arguments given. This is simpler and lets GCC
2833 4.6.0 generate slightly better code.
2834
dae0cd48
PE
2835 * ftfont.c: Distingish more carefully between FcChar8 and char.
2836 The previous code passed unsigned char * to a functions like
2837 strlen and xstrcasecmp that expect char *, which does not
2838 conform to the C standard.
2839 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2840 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2841 char * when the C standard requires it.
2842
76032d70
PE
2843 * keyboard.c (read_char): Remove unused var.
2844
eb3f1cc8
PE
2845 * eval.c: Port to Windows vsnprintf (Bug#8435).
2846 Include <limits.h>.
2847 (SIZE_MAX): Define if the headers do not.
2848 (verror): Do not give up if vsnprintf returns a negative count.
2849 Instead, grow the buffer. This ports to Windows vsnprintf, which
2850 does not conform to C99. Problem reported by Eli Zaretskii.
2851 Also, simplify the allocation scheme, by avoiding the need for
2852 calling realloc, and removing the ALLOCATED variable.
2853
70476b54
PE
2854 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2855
12020a9e
PE
2856 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2857 But keep the doprint source code for now, as we might revamp it
2858 and use it again (Bug#8435).
ea6c7ae6
PE
2859 * lisp.h (doprnt): Remove.
2860 * Makefile.in (base_obj): Remove doprnt.o.
2861 * deps.mk (doprnt.o): Remove.
2862
5fdb398c
PE
2863 error: Print 32- and 64-bit integers portably (Bug#8435).
2864 Without this change, on typical 64-bit hosts error ("...%d...", N)
2865 was used to print both 32- and 64-bit integers N, which relied on
2866 undefined behavior.
2867 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2868 New macro.
2869 * lisp.h (error, verror): Mark as printf-like functions.
2870 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2871 Report overflow in size calculations when allocating printf buffer.
2872 Do not truncate output string at its first null byte.
2873 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2874 Truncate the output at a character boundary, since vsnprintf does not
2875 do that.
2876 * charset.c (check_iso_charset_parameter): Convert internal
2877 character to string before calling 'error', since %c now has the
2878 printf meaning.
2879 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2880 overflow when computing char to be passed to 'error'. Do not
2881 pass Lisp_Object to 'error'; pass the integer instead.
2882 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2883 formatted with plain %d.
2884
b189fa66
PE
2885 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2886
bff87ef0
PE
2887 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2888
7e2cac20
PE
2889 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2890
ce4d90b5
PE
2891 * xterm.c (x_catch_errors): Remove duplicate declaration.
2892
266c9547
PE
2893 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2894
79c49ad2
PE
2895 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2896
368f4090
JM
28972011-04-10 Jim Meyering <meyering@redhat.com>
2898
2899 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2900 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2901 return ssize_t not "int", and use size_t as the buffer length.
2902 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2903 * gnutls.h: Update declarations.
2904 * process.c (read_process_output): Use ssize_t, to match.
2905 (send_process): Likewise.
2906
a32d4040
CY
29072011-04-09 Chong Yidong <cyd@stupidchicken.com>
2908
2909 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2910
8546720e 29112011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2912
04f2d78b
CB
2913 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2914 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2915
8546720e
GM
2916 * xterm.c (handle_one_xevent):
2917 * xmenu.c (create_and_show_popup_menu):
2918 * xselect.c (x_decline_selection_request)
2919 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2920
0a2f5c1a 29212011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2922
2923 Fix some uses of `int' instead of EMACS_INT.
2924 * search.c (string_match_1, fast_string_match)
2925 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2926 (scan_buffer, find_next_newline_no_quit)
2927 (find_before_next_newline, search_command, Freplace_match)
2928 (Fmatch_data): Make some `int' variables be EMACS_INT.
2929
2930 * xdisp.c (display_count_lines): 3rd argument and return value now
2931 EMACS_INT. All callers changed.
2932 (pint2hrstr): Last argument is now EMACS_INT.
2933
2934 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2935 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2936 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2937 (decode_coding_utf_16, decode_coding_emacs_mule)
2938 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2939 (decode_coding_ccl, decode_coding_charset)
2940 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2941 (decode_coding_iso_2022, decode_coding_emacs_mule)
2942 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2943 <char_offset, last_offset>: Declare EMACS_INT.
2944 (encode_coding_utf_8, encode_coding_utf_16)
2945 (encode_coding_emacs_mule, encode_invocation_designation)
2946 (encode_designation_at_bol, encode_coding_iso_2022)
2947 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2948 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2949 Declare EMACS_INT.
2950 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2951 (encode_invocation_designation): Last argument P_NCHARS is now
2952 EMACS_INT.
2953 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2954 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2955
2956 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2957 All users changed.
2958
2959 * ccl.c (Fccl_execute_on_string): Declare some variables
2960 EMACS_INT.
2961
8546720e 29622011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2963
2964 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2965
4e19a977
CS
29662011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2967
2968 * process.c (Fformat_network_address): Doc fix.
2969
87302331
R
29702011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2971
2972 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2973
cbb59342
CY
29742011-04-08 Chong Yidong <cyd@stupidchicken.com>
2975
2976 * keyboard.c (read_char): Call Lisp function help-form-show,
2977 instead of using internal_with_output_to_temp_buffer.
2978 (Qhelp_form_show): New var.
e0d38eeb 2979 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2980
2981 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2982
2983 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2984
e67a13ab
CY
29852011-04-06 Chong Yidong <cyd@stupidchicken.com>
2986
04f2d78b
CB
2987 * process.c (Flist_processes): Remove to Lisp.
2988 (list_processes_1): Delete.
e67a13ab 2989
973f782d
EZ
29902011-04-06 Eli Zaretskii <eliz@gnu.org>
2991
7c106b1e
EZ
2992 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2993
973f782d
EZ
2994 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2995
41cf7d1a 29962011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2997
ca23cc88
PE
2998 Fix more problems found by GCC 4.6.0's static checks.
2999
f390e2d5
PE
3000 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3001
42eea0d0
PE
3002 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3003
b69769da 3004 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3005
f9541e84
PE
3006 * xdisp.c (vmessage): Mark as a printf-like function.
3007
13841b55
PE
3008 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3009
c136c10f
PE
3010 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3011
5e2d4a30
PE
3012 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3013 printf-like functions.
3014 (tiff_load): Add casts to remove these marks before passing them
3015 to system-supplied API.
3016
583f48b9
PE
3017 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3018
b25d760e
PE
3019 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3020 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3021 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3022 directly, rather than having caller test rule sign. This avoids
3023 some unnecessary tests.
3024 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3025 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3026 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3027
bc7b6697 3028 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3029 (xfont_open): Avoid unnecessary tests.
bc7b6697 3030
27ccc379
PE
3031 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3032
dcd5c89a
PE
3033 * composite.h, composite.c (composition_gstring_put_cache):
3034 Use EMACS_INT, not int, for length.
3035
b13a45c6
PE
3036 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3037 breaking out part of COMPOSITION_DECODE_RULE.
3038 (COMPOSITION_DECODE_RULE): Use it.
3039 * composite.c (get_composition_id): Remove unused local vars,
3040 by using the new macro.
3041
1e792e4d
PE
3042 * textprop.c (set_text_properties_1): Change while to do-while,
3043 since the condition is always true at first.
3044
dc6c6455 3045 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3046 (interval_deletion_adjustment): Return unsigned value.
3047 All uses changed.
dc6c6455 3048
aba7731a
PE
3049 * process.c (list_processes_1, create_pty, read_process_output):
3050 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3051 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3052 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3053 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3054 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3055
fdfc4bf3
PE
3056 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3057
fca8fe46 3058 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3059 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3060
06a0259a 3061 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3062 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3063 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3064
e7b9e80f
PE
3065 * print.c (print_error_message): Avoid int overflow.
3066
56201685
PE
3067 * font.c (font_list_entities): Redo for clarity,
3068 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3069
78834453 3070 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3071 (font_score): Avoid potential overflow in diff calculation.
78834453 3072
0bc0b309 3073 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3074 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3075
e610eaca
PE
3076 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3077
b895abce
PE
3078 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3079 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3080 can always succeed if overflow has undefined behavior.
3081
1f1d9321 3082 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3083 (wordify): Omit three unnecessary tests.
1f1d9321 3084
c59478bc
PE
3085 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3086 All callers changed. This avoids the need for an unused var.
3087
79b73827
PE
3088 * casefiddle.c (casify_region): Remove var that is set but not used.
3089
a4db5dfe
PE
3090 * dired.c (file_name_completion): Remove var that is set but not used.
3091
43aae36e
PE
3092 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3093
2a47c44d 3094 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3095 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3096
a37c69bf
PE
3097 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3098 Check for integer overflow on size calculations.
3099
328ab8e7
PE
3100 * buffer.c (Fprevious_overlay_change): Remove var that is set
3101 but not used.
3102
e5a2a5cb
PE
3103 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3104 Remove vars that are set but not used.
8d84a6eb 3105 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3106 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3107
a60e5f68
PE
3108 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3109
f661cb61 3110 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3111 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3112
f0397f5a
PE
3113 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3114 that are set but not used.
3115
8664db06 3116 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3117 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3118
6abdaa4a
PE
3119 * xselect.c (x_get_local_selection, x_handle_property_notify):
3120 Remove vars that are set but not used.
3121
0ce7538d 3122 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3123 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3124
9ae848fc
PE
3125 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3126 Remove var that is set but not used.
0b918413
PE
3127 (scroll_bar_windows_size): Now size_t, not int.
3128 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3129 Check for overflow.
9ae848fc 3130
a5a62657
PE
3131 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3132 (map_tty_color) [!defined MSDOS]: Likewise.
3133
5c5cdd39
PE
3134 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3135
66ebf983
PE
3136 * coding.c: Remove vars that are set but not used.
3137 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3138 All callers changed.
3139 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3140 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3141 (decode_coding_charset): Remove vars that are set but not used.
3142
1be4d761
PE
3143 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3144 that is set but not used.
3145
47553fa8
PE
3146 * print.c (print_object): Remove var that is set but not used.
3147
1f7196bf 3148 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3149 The gnulib version avoids calling malloc in the usual case,
3150 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3151 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3152 * filelock.c (current_lock_owner): Likewise.
3153 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3154 * sysdep.c: Include allocator.h, careadlinkat.h.
3155 (emacs_no_realloc_allocator): New static constant.
3156 (emacs_readlink): New function.
fdb61804
PE
3157 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3158 ../lib/careadlinkat.h.
d1fdcab7 3159
f84c17c7
SM
31602011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3161
3162 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3163 first non-nil return value).
3164
ef3862ad
JD
31652011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3166
3167 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3168 if not defined (Bug#8403).
3169
376a7006
JB
31702011-04-02 Juanma Barranquero <lekktu@gmail.com>
3171
3172 * xdisp.c (display_count_lines): Remove parameter `start',
3173 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3174 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3175 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3176 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3177 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3178 and thereabouts. All callers changed.
3179 (get_per_char_metric): Remove parameter `f', unused since
3180 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3181
6ca3801d
JM
31822011-04-02 Jim Meyering <meyering@redhat.com>
3183
3184 do not dereference NULL upon failed strdup
3185 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3186 (ns_get_family): Likewise.
3187
d8e2b5ba
JB
31882011-04-02 Juanma Barranquero <lekktu@gmail.com>
3189
3190 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3191
8c74fcbd
JD
31922011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3193
3194 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3195 later (Bug#8403).
3196
7200d79c
SM
31972011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3198
03408648 3199 Add lexical binding.
7200d79c 3200
03408648
SM
3201 * window.c (Ftemp_output_buffer_show): New fun.
3202 (Fsave_window_excursion):
3203 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3204
3205 * lread.c (lisp_file_lexically_bound_p): New function.
3206 (Fload): Bind Qlexical_binding.
3207 (readevalloop): Remove `evalfun' arg.
3208 Bind Qinternal_interpreter_environment.
3209 (Feval_buffer): Bind Qlexical_binding.
3210 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3211 Mark as dynamic.
3212 (syms_of_lread): Declare `lexical-binding'.
3213
3214 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3215
3216 * keyboard.c (eval_dyn): New fun.
3217 (menu_item_eval_property): Use it.
ca105506
SM
3218
3219 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3220
03408648
SM
3221 * fns.c (concat, mapcar1): Accept byte-code-functions.
3222
3223 * eval.c (Fsetq): Handle lexical vars.
3224 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3225 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3226 (FletX, Flet): Obey lexical binding.
3227 (Fcommandp): Handle closures.
3228 (Feval): New `lexical' arg.
3229 (eval_sub): New function extracted from Feval. Use it almost
3230 everywhere where Feval was used. Look up vars in lexical env.
3231 Handle closures.
3232 (Ffunctionp): Move from subr.el.
3233 (Ffuncall): Handle closures.
3234 (apply_lambda): Remove `eval_flags'.
3235 (funcall_lambda): Handle closures and new byte-code-functions.
3236 (Fspecial_variable_p): New function.
3237 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3238 but without exporting it to Lisp.
23aba0ea 3239
23aba0ea 3240 * doc.c (Fdocumentation, store_function_docstring):
03408648 3241 * data.c (Finteractive_form): Handle closures.
23aba0ea 3242
03408648
SM
3243 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3244 interactive spec.
ba83908c 3245
04f2d78b
CB
3246 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3247 New byte-codes.
03408648
SM
3248 (exec_byte_code): New function extracted from Fbyte_code to handle new
3249 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3250
03408648 3251 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3252
03408648 3253 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3254
e2abce01
JB
32552011-03-31 Juanma Barranquero <lekktu@gmail.com>
3256
3257 * xdisp.c (redisplay_internal): Fix prototype.
3258
63696a73 32592011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3260
63696a73 3261 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3262 (try_scrolling): Use it when setting scroll_limit.
3263 Limit scrolling to 100 screen lines.
63696a73
EZ
3264 (redisplay_window): Even when falling back on "recentering",
3265 position point in the window according to scroll-conservatively,
3266 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3267
3268 (try_scrolling): When point is above the window, allow searching
3269 as far as scroll_max, or one screenful, to compute vertical
3270 distance from PT to the scroll margin position. This prevents
3271 try_scrolling from unnecessarily failing when
3272 scroll-conservatively is set to a value slightly larger than the
3273 window height. Clean up the case of PT below the margin at bottom
3274 of window: scroll_max can no longer be INT_MAX. When aggressive
3275 scrolling is in use, don't let point enter the opposite scroll
3276 margin as result of the scroll.
3277 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3278 threshold of 100 lines for never-recentering scrolling.
3279
e4cc2dfc
JB
32802011-03-31 Juanma Barranquero <lekktu@gmail.com>
3281
3282 * dispextern.h (move_it_by_lines):
3283 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3284 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3285 (message_log_check_duplicate): Remove parameters `prev_bol' and
3286 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3287 (redisplay_internal): Remove parameter `preserve_echo_area',
3288 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3289
3290 * indent.c (Fvertical_motion):
3291 * window.c (window_scroll_pixel_based, Frecenter):
3292 Don't pass `need_y_p' to `move_it_by_lines'.
3293
1c470562
SM
32942011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3295
44f230aa
SM
3296 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3297 steal a few bits to be more compact.
3298 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3299 Remove unneeded casts.
3300
1c470562
SM
3301 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3302
888adce9
ZK
33032011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3304
3305 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3306 binding" message (bug#7967).
3307
f838ed7b
PE
33082011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3309
77861b95
PE
3310 Fix more problems found by GCC 4.6.0's static checks.
3311
de6dbc14
PE
3312 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3313 Remove unused local var.
3314
f838ed7b
PE
3315 * editfns.c (Fmessage_box): Remove unused local var.
3316
792c7b2b
PE
3317 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3318 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3319 Omit unused local vars.
c499e557 3320 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3321 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3322 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3323 Omit unused local var.
3324
ba0165e1
PE
3325 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3326 Don't assume string length fits in int.
32ad8845 3327 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3328 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3329
3c59b4c9
PE
3330 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3331 instead of alloca (Bug#8344).
3332
a3eed478 3333 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3334 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3335
eb4d412d
PE
3336 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3337
1658b401
PE
3338 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3339 concerns.
3340
3341 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3342
3343 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3344
9a2c6e05
PE
3345 * keyboard.c (syms_of_keyboard): Use the same style as later
3346 in this function when indexing through an array. This also
3347 works around GCC bug 48267.
3348
03d0a109
PE
3349 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3350
44f730c8
PE
3351 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3352
fe75f926
PE
3353 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3354 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3355
ffa8c828
PE
3356 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3357 This avoids undefined behavior on integer overflow, and is a bit
3358 more convenient anyway since it is compared to a size_t variable.
3359
c5101a77
PE
3360 Variadic C functions now count arguments with size_t, not int.
3361 This avoids an unnecessary limitation on 64-bit machines, which
3362 caused (substring ...) to crash on large vectors (Bug#8344).
3363 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3364 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3365 All variadic functions and their callers changed accordingly.
c5101a77
PE
3366 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3367 * data.c (arith_driver, float_arith_driver): Likewise.
3368 * editfns.c (general_insert_function): Likewise.
3369 * eval.c (struct backtrace.nargs, interactive_p)
3370 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3371 (funcall_lambda, mark_backtrace): Likewise.
3372 * fns.c (concat): Likewise.
3373 * frame.c (x_set_frame_parameters): Likewise.
3374 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3375 0 if not found, not -1. All callers changed.
3376
dd3f25f7
PE
3377 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3378 (stack_copy_size): Now size_t, not int.
3379 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3380
461c2ab9
JB
33812011-03-28 Juanma Barranquero <lekktu@gmail.com>
3382
3383 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3384 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3385 All callers changed.
3386
3387 * lisp.h (multibyte_char_to_unibyte):
3388 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3389 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3390 * character.h (CHAR_TO_BYTE8):
3391 * cmds.c (internal_self_insert):
3392 * editfns.c (general_insert_function):
3393 * keymap.c (push_key_description):
3394 * search.c (Freplace_match):
3395 * xdisp.c (message_dolog, set_message_1): All callers changed.
3396
f6d62986
SM
33972011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3398
3399 * keyboard.c (safe_run_hook_funcall): New function.
3400 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3401 don't set the hook to nil, but remove the offending function instead.
3402 (Qcommand_hook_internal): Remove, unused.
3403 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3404 Vcommand_hook_internal.
3405
3406 * eval.c (enum run_hooks_condition): Remove.
3407 (funcall_nil, funcall_not): New functions.
3408 (run_hook_with_args): Call each function through a `funcall' argument.
3409 Remove `cond' argument, now redundant.
3410 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3411 (Frun_hook_with_args_until_failure): Adjust accordingly.
3412 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3413
1db5b1ad
JB
34142011-03-28 Juanma Barranquero <lekktu@gmail.com>
3415
3416 * dispextern.h (string_buffer_position): Remove declaration.
3417
3418 * print.c (strout): Remove parameter `multibyte', unused since
3419 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3420
3421 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3422 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3423 All callers changed.
3424
3425 * w32.c (_wsa_errlist): Use braces for struct initializers.
3426
3427 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3428 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3429 All callers changed.
3430 (string_buffer_position): Likewise. Also, make static (it's never
3431 used outside xdisp.c).
3432 (cursor_row_p): Remove parameter `w', unused since
3433 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3434 (decode_mode_spec): Remove parameter `precision', introduced during
3435 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3436 All callers changed.
3437
5ffb62aa
JD
34382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3439
3440 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3441
461c2ab9 34422011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3443
3444 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3445 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3446 (ns_update_auto_hide_menu_bar): New functions.
3447 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3448 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3449 ns_constrain_all_frames.
3450 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3451 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3452
5c380ffb
JD
34532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3454
3455 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3456
9af30bdf
GM
34572011-03-27 Glenn Morris <rgm@gnu.org>
3458
3459 * syssignal.h: Replace RETSIGTYPE with void.
3460 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3461 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3462 Replace SIGTYPE with void everywhere.
3463 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3464 * s/template.h (SIGTYPE): Remove commented out definition.
3465
e2abce01
JB
34662011-03-26 Eli Zaretskii <eliz@gnu.org>
3467
3468 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3469 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3470
f868cd8a
JB
34712011-03-26 Juanma Barranquero <lekktu@gmail.com>
3472
59eb0929
JB
3473 * w32.c (read_unc_volume): Use parameter `henum', instead of
3474 global variable `wget_enum_handle'.
3475
3476 * keymap.c (describe_vector): Remove parameters `indices' and
3477 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3478 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3479
f868cd8a
JB
3480 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3481
3482 * keyboard.c (timer_check): Remove parameter `do_it_now',
3483 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3484 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3485 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3486
3487 * keyboard.c (read_char):
3488 * w32menu.c (w32_menu_display_help):
3489 * xmenu.c (show_help_event, menu_help_callback):
3490 Adjust calls to `show_help_echo'.
3491
3492 * gtkutil.c (xg_maybe_add_timer):
3493 * keyboard.c (readable_events):
3494 * process.c (wait_reading_process_output):
3495 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3496
3497 * insdel.c (adjust_markers_gap_motion):
3498 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3499 (gap_left, gap_right): Don't call it.
3500
2ecf6fdb
CY
35012011-03-25 Chong Yidong <cyd@stupidchicken.com>
3502
3503 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3504 incurred during fontification.
3505
6b1f9ba4
JB
35062011-03-25 Juanma Barranquero <lekktu@gmail.com>
3507
3508 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3509 (DEFVAR_PER_BUFFER): Don't pass it.
3510
3511 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3512 (scrolling_window): Don't pass it.
3513
0f4a96b5
JB
35142011-03-25 Juanma Barranquero <lekktu@gmail.com>
3515
3516 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3517
3518 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3519 and `suffix'.
3520 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3521 of variables specific to SELinux and computation of `encoded_absname'.
3522
3523 * image.c (XPutPixel): Remove unused variable `height'.
3524
3525 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3526
3527 * unexw32.c (get_section_info): Remove unused variable `section'.
3528
3529 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3530 (system_process_attributes): Remove unused variable `sess'.
3531 (sys_read): Remove unused variable `err'.
3532
3533 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3534 (w32_wnd_proc): Remove unused variable `isdead'.
3535 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3536 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3537 (x_create_tip_frame): Remove unused variable `tem'.
3538
3539 * w32inevt.c (w32_console_read_socket):
3540 Remove unused variable `no_events'.
3541
3542 * w32term.c (x_draw_composite_glyph_string_foreground):
3543 Remove unused variable `width'.
3544
1149507c
JB
35452011-03-24 Juanma Barranquero <lekktu@gmail.com>
3546
3547 * w32term.c (x_set_glyph_string_clipping):
3548 Don't pass uninitialized region to CombineRgn.
3549
9c88f339
JB
35502011-03-23 Juanma Barranquero <lekktu@gmail.com>
3551
3552 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3553 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3554 (Fx_close_connection): Remove unused variable `i'.
3555
3556 * w32font.c (w32font_draw): Return number of glyphs.
3557 (w32font_open_internal): Remove unused variable `i'.
3558 (w32font_driver): Add missing initializer.
3559
3560 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3561 (fill_in_menu): Remove unused variable `items_added'.
3562
3563 * w32term.c (last_mouse_press_frame): Remove static global variable.
3564 (w32_clip_to_row): Remove unused variable `f'.
3565 (x_delete_terminal): Remove unused variable `i'.
3566
3567 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3568 (NOTHING): Remove unused static global variable.
3569 (uniscribe_check_otf): Remove unused variable `table'.
3570 (uniscribe_font_driver): Add missing initializers.
3571
dee091a3
JD
35722011-03-23 Julien Danjou <julien@danjou.info>
3573
3574 * term.c (Fsuspend_tty, Fresume_tty):
3575 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3576 * window.c (temp_output_buffer_show):
3577 * insdel.c (signal_before_change):
3578 * frame.c (Fhandle_switch_frame):
3579 * fileio.c (Fdo_auto_save):
3580 * emacs.c (Fkill_emacs):
3581 * editfns.c (save_excursion_restore):
3582 * cmds.c (internal_self_insert):
3583 * callint.c (Fcall_interactively):
3584 * buffer.c (Fkill_all_local_variables):
3585 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3586 Use Frun_hooks.
0f4a96b5 3587 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3588 unconditionnaly since it does the check itself.
3589
2c520ab5 35902011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3591
c9c49752
PE
3592 Fix more problems found by GCC 4.5.2's static checks.
3593
8abc3f12
PE
3594 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3595 the first time through the loop, since we know p0 < p1 then.
3596 This also avoids a gcc -Wstrict-overflow warning.
3597
a2d26660
PE
3598 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3599 leading to a memory leak, possible in functions like
3600 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3601 of objects (Bug#8318).
a2d26660 3602
916c72e9
PE
3603 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3604 that could (at least in theory) be that large.
3605
19ab8a18
PE
3606 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3607 This is less likely to overflow, and avoids undefined behavior if
3608 overflow does occur. All callers changed. Use strtoul to scan
3609 for the unsigned long integer.
b7cbbd6f
PE
3610 (pint2hrstr): Simplify and tune code slightly.
3611 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3612
f0641eff
PE
3613 * scroll.c (do_scrolling): Work around GCC bug 48228.
3614 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3615
7f650bb9
PE
3616 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3617 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3618 (validate_x_resource_name): Simplify count usage.
3619 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3620
37dd57d1
PE
3621 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3622 fail (Bug#8306).
81e56e61 3623
699979fc 3624 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3625
401bf9b4
PE
3626 * process.c (Fmake_network_process): Use socklen_t, not int,
3627 where POSIX says socklen_t is required in portable programs.
3628 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3629 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3630 (Fmake_network_process, server_accept_connection):
3631 (wait_reading_process_output, read_process_output):
3632 Likewise.
3633
b93aacde
PE
3634 * process.c: Rename or move locals to avoid shadowing.
3635 (list_processes_1, Fmake_network_process):
3636 (read_process_output_error_handler, exec_sentinel_error_handler):
3637 Rename or move locals.
4dc343ee 3638 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3639 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3640 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3641 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3642 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3643
af8a867c 3644 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3645 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3646 Include tparam.h instead, since it declares them.
af8a867c
PE
3647 * cm.h (PC): Remove extern decl; tparam.h now does this.
3648 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3649 * terminfo.c: Include tparam.h, to check interfaces.
3650 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3651 (tparam): Adjust signature to match interface in tparam.h;
3652 this removes some undefined behavior. Check that outstring and len
3653 are zero, which they always are with Emacs.
3654 * tparam.h (PC, BC, UP): New extern decls.
3655
0248044d 3656 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3657 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3658
8ff096c1 3659 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3660 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3661 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3662 (ftfont_list): Remove unused local.
49eaafba
PE
3663 (get_adstyle_property, ftfont_pattern_entity):
3664 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3665 Rename locals to avoid shadowing.
8ff096c1 3666
e2be39f6
PE
3667 * xfont.c (xfont_list_family): Mark var as initialized.
3668
c9735e30
PE
3669 * xml.c (make_dom): Now static.
3670
8f5201ae
PE
3671 * composite.c (composition_compute_stop_pos): Rename local to
3672 avoid shadowing.
b246f932
PE
3673 (composition_reseat_it): Remove unused locals.
3674 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3675 (composition_update_it): Mark var as initialized.
11b61122
PE
3676 (find_automatic_composition): Mark vars as initialized,
3677 with a FIXME (Bug#8290).
8f5201ae 3678
760fbc2c
PE
3679 character.h: Rename locals to avoid shadowing.
3680 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3681 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3682 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3683 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3684 to avoid shadowing.
3685
ff08eb85
PE
3686 * textprop.c (property_change_between_p): Remove; unused.
3687
fc7bf025
PE
3688 * intervals.c (interval_start_pos): Now static.
3689
235d7abc
PE
3690 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3691
44f230aa
SM
3692 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3693 Rename locals to avoid shadowing.
3e7d6594 3694
50060332
PE
3695 * sound.c (wav_play, au_play, Fplay_sound_internal):
3696 Fix pointer signedness.
d01f234b 3697 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3698 (wav_play): Initialize a variable to 0, to prevent undefined
3699 behavior (Bug#8278).
50060332 3700
c4fc4e30
PE
3701 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3702
918436ed
PE
3703 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3704
c939f91b
PE
3705 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3706 clobbering (Bug#8298).
b9c7f648
PE
3707 * sysdep.c (sys_subshell): Likewise.
3708 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3709
6bd8c144
PE
3710 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3711 This should get cleaned up, so that child_setup has the
3712 same signature on all platforms.
3713
7710357c 3714 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3715 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3716
c59da222
CY
37172011-03-22 Chong Yidong <cyd@stupidchicken.com>
3718
3719 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3720 not to be necessary, and produces flickering.
3721
66b87493
GM
37222011-03-20 Glenn Morris <rgm@gnu.org>
3723
3724 * config.in: Remove file.
3725
45b6f6d5
JB
37262011-03-20 Juanma Barranquero <lekktu@gmail.com>
3727
3728 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3729 are now in src/globals.h.
3730 (syms_of_minibuf): Remove spurious & from previous change.
3731
3ec03f7e
LL
37322011-03-20 Leo <sdl.web@gmail.com>
3733
3734 * minibuf.c (completing-read-function): New variable.
3735 (completing-read-default): Rename from completing-read.
3736 (completing-read): Call completing-read-function.
3737
b14e3e21
CY
37382011-03-19 Juanma Barranquero <lekktu@gmail.com>
3739
3740 * xfaces.c (Fx_load_color_file):
3741 Read color file from absolute filename (bug#8250).
3742
f2b726e6
JB
37432011-03-19 Juanma Barranquero <lekktu@gmail.com>
3744
3745 * makefile.w32-in: Update dependencies.
3746
09f6ff02
EZ
37472011-03-17 Eli Zaretskii <eliz@gnu.org>
3748
3749 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3750
29a6015a
PE
37512011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3752
a3a6c54e
PE
3753 Fix more problems found by GCC 4.5.2's static checks.
3754
b766f867
PE
3755 * process.c (make_serial_process_unwind, send_process_trap):
3756 (sigchld_handler): Now static.
3757
be02381c
PE
3758 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3759 That way, the code declares only the vars that it needs.
3760 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3761 * s/cygwin.h (PTY_ITERATION): Likewise.
3762 * s/darwin.h (PTY_ITERATION): Likewise.
3763 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3764
57048744
PE
3765 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3766 * process.c (allocate_pty): Don't declare stb unless it's needed.
3767
7914961c 3768 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3769 (CONSTANTLIM): Remove; unused.
3770 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3771 Define only if needed.
7914961c 3772
b3967b18
PE
3773 * unexelf.c (unexec): Name an expression,
3774 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3775 Use a different way to cause a compilation error if anyone uses
3776 n rather than nn, a way that does not involve shadowing.
73366a00 3777 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3778
29a6015a
PE
3779 * deps.mk (unexalpha.o): Remove; unused.
3780
43cfc33e 3781 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3782 * unexec.h: New file.
ce701a33
PE
3783 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3784 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3785 Depend on unexec.h.
3786 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3787 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3788 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3789 Change as necessary to match prototype in unexec.h.
ce701a33 3790
01f44d5a
PE
3791 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3792 shadowing.
4f63c6bb 3793 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3794
a6670b0b
PE
3795 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3796 Rename locals to avoid shadowing.
3797
cef2010d 3798 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3799 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3800
d4d7173a
PE
3801 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3802
f08b802a
PE
3803 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3804 warning when compiling print.c.
3805
3ddb0639
PE
3806 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3807 instead of using an uninitialized var.
5ad03b97 3808 (font_sort_entities): Mark var as initialized.
3ddb0639 3809
170a2692
PE
3810 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3811
e663c700
PE
3812 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3813 pointers to constants.
89bc529a 3814 (font_parse_fcname): Remove unused vars.
7b81e2d0 3815 (font_delete_unmatched): Now static.
ea838e10 3816 (font_get_spec): Remove; unused.
13a547c6
PE
3817 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3818 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3819 Rename or move locals to avoid shadowing.
e663c700 3820
2a80c887 3821 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3822 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3823
1384fa33 3824 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3825 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3826
8b2c52e9
PE
3827 * alloc.c (mark_backtrace): Move decl from here ...
3828 * lisp.h: ... to here, so that it can be checked.
3829
475545b5 3830 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3831 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3832 (lisp_indirect_variable): Name an expression,
3833 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3834 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3835
b1349114 3836 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3837 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3838 Use const pointer when appropriate.
b1349114 3839
a2928364
PE
3840 * lisp.h (get_system_name, get_operating_system_release):
3841 Move decls here, to check interfaces.
3842 * process.c (get_operating_system_release): Move decl to lisp.h.
3843 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3844 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3845 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3846 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3847 (Fformat_time_string, Fencode_time, Finsert_char):
3848 (Ftranslate_region_internal, Fformat):
3849 Rename or remove local vars to avoid shadowing.
9710023e 3850 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3851
a415e694
PE
3852 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3853 avoid shadowing.
3854
8ef4622d
PE
3855 * lisp.h (eassert): Check that the argument compiles, even if
3856 ENABLE_CHECKING is not defined.
3857
946f9a5b
PE
3858 * data.c (Findirect_variable): Name an expression, to avoid
3859 gcc -Wbad-function-cast warning.
112396d6 3860 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3861 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3862 (Fmake_variable_buffer_local, Fmake_local_variable):
3863 Mark variables as initialized.
52746918 3864 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3865
e5aab7e7 3866 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3867 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3868 Rename locals to avoid shadowing.
dff45157
PE
3869 (mark_stack): Move local variables into the #ifdef region where
3870 they're used.
7bc26fdb
PE
3871 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3872 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3873 needed otherwise.
3874 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3875 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3876 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3877
e5aab7e7
PE
3878 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3879 avoids undefined behavior in theory.
3880
4da60324
PE
3881 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3882
88043301
PE
3883 Use functions, not macros, for up- and down-casing (Bug#8254).
3884 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3885 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3886 to use the following functions instead of these macros.
3887 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3888 EMACS_INT, since callers assume the returned value fits in int.
3889 (upcase1): Likewise, for UPCASE_TABLE.
3890 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3891 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3892 the race-condition problem in the old DOWNCASE.
88043301 3893
19ed5445
PE
3894 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3895 Rename locals to avoid shadowing.
3896 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3897 (regex_compile, re_search_2, re_match_2_internal):
3898 Remove unused local vars.
952db0d7
PE
3899 (FREE_VAR): Rewrite so as not to use empty "else",
3900 which gcc can warn about.
da053e48 3901 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3902 (RETALLOC_IF): Define only if needed.
3903 (WORDCHAR_P): Likewise. This one is never needed, but is used
3904 only in a comment talking about a compiler bug, so put inside
3905 the #if 0 of that comment.
3906 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3907 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3908 Remove; unused.
19ed5445 3909
1f3561e4 3910 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3911 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3912 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3913
ded6f8f7
PE
3914 * search.c (simple_search): Remove unused var.
3915
dbd37a95
PE
3916 * dired.c (compile_pattern): Move decl from here ...
3917 * lisp.h: ... to here, so that it can be checked.
3918 (struct re_registers): New forward decl.
3919
7e47afad
PE
3920 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3921
85f24f61
PE
3922 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3923 All uses changed.
3924 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3925 Rename locals to avoid shadowing.
5671df8f 3926 (Fvertical_motion): Mark locals as initialized.
85f24f61 3927
181aa2be 3928 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3929 (casify_region): Mark local as initialized.
181aa2be 3930
930d429c
PE
3931 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3932
7082eac6
PE
3933 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3934 New macros, so that the caller can use some names other than
3935 gcpro1, gcpro2, etc.
3936 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3937 of the new macros.
3938 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3939 argument, for consistency with GCPRO2_VAR, etc: it is now the
3940 prefix of the variable, not the variable itself. All uses
3941 changed.
38b2c076
PE
3942 * dired.c (directory_files_internal, file_name_completion):
3943 Rename locals to avoid shadowing.
3944
15206ed9
PE
3945 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3946 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3947 dired.c's scmp function, had undefined behavior.
3948 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3949 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3950 * buffer.h: ... to here, because these macros use current_buffer,
3951 and the new implementation with inline functions needs to have
3952 current_buffer in scope now, rather than later when the macros
3953 are used.
3954 (downcase, upcase1): New static inline functions.
3955 (DOWNCASE, UPCASE1): Reimplement using these functions.
3956 This avoids undefined behavior in expressions like
3957 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3958 from race conditions in accessing the global variables
3959 case_temp1 and case_temp2.
3960 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3961 * lisp.h (case_temp1, case_temp2): Remove their decls.
3962 * character.h (ASCII_CHAR_P): Move from here ...
3963 * lisp.h: ... to here, so that the inline functions mentioned
3964 above can use them.
3965
4a6bea26
PE
3966 * dired.c (directory_files_internal_unwind): Now static.
3967
f14b7e14
PE
3968 * fileio.c (file_name_as_directory, directory_file_name):
3969 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3970 Now static.
2893f146
PE
3971 (file_name_as_directory): Use const pointers when appropriate.
3972 (Fexpand_file_name): Likewise. In particular, newdir might
3973 point at constant storage, so make it a const pointer.
fd4ead52 3974 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3975 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3976 signedness issues.
f839df0c
PE
3977 (Fset_file_times, Finsert_file_contents, auto_save_error):
3978 Rename locals to avoid shadowing.
f14b7e14 3979
5716756e 3980 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3981 (Ftry_completion, Fall_completions): Rename or remove locals
3982 to avoid shadowing.
5716756e 3983
b4c3046a
PE
3984 * marker.c (bytepos_to_charpos): Remove; unused.
3985
b45db522
PE
3986 * lisp.h (verify_bytepos, count_markers): New decls,
3987 so that gcc does not warn that these functions aren't declared.
3988
85876d07
PE
3989 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3990 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3991 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3992 (copy_text): Remove unused local var.
85876d07 3993
03d78a21 3994 * filelock.c (within_one_second): Now static.
b3dd38ab 3995 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3996
5df8f01b
PE
3997 * buffer.c (fix_overlays_before): Mark locals as initialized.
3998 (fix_start_end_in_overlays): Likewise. This function should be
3999 simplified by using pointers-to-pointers, but that's a different
4000 matter.
b1d876f1 4001 (switch_to_buffer_1): Now static.
8f54f30a
PE
4002 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4003 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4004
a70072c9 4005 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4006 Fix pointer signedness issue.
edced198
PE
4007 (sys_subshell): Mark local as volatile if checking for lint,
4008 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4009 (MAXPATHLEN): Define only if needed.
a70072c9 4010
a0977c44
PE
4011 * process.c (serial_open, serial_configure): Move decls from here ...
4012 * systty.h: ... to here, so that they can be checked.
4013
a884fdcc
PE
4014 * fns.c (get_random, seed_random): Move extern decls from here ...
4015 * lisp.h: ... to here, so that they can be checked.
4016
604efe86 4017 * sysdep.c (reset_io): Now static.
b8950c94 4018 (wait_for_termination_signal): Remove; unused.
604efe86 4019
38fc62d9
PE
4020 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4021 (copy_keymap_item, append_key, push_text_char_description):
4022 Now static.
1004a21a 4023 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4024 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4025 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4026 (describe_map_tree):
4027 Rename locals to avoid shadowing.
38fc62d9 4028
2f2650da
PE
4029 * keyboard.c: Declare functions static if they are not used elsewhere.
4030 (echo_char, echo_dash, cmd_error, top_level_2):
4031 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4032 (read_char, kbd_buffer_get_event, make_lispy_position):
4033 (make_lispy_event, make_lispy_movement, apply_modifiers):
4034 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4035 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4036 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4037 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4038 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4039
a053e86c 4040 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4041 (mark_kboards): Move decl here ...
4042 * alloc.c (mark_kboards): ... from here.
a053e86c 4043
4752793e
PE
4044 * lisp.h (force_auto_save_soon): New decl.
4045
74f10ca7 4046 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4047 (DEFINE_DUMMY_FUNCTION): New macro.
4048 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4049 Use it.
c03cd23f
PE
4050 (main): Add casts to avoid warnings
4051 if GCC considers string literals to be constants.
74f10ca7 4052
022e70d4
PE
4053 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4054
59d6fe83
PE
4055 * dbusbind.c: Pointer signedness fixes.
4056 (xd_signature, xd_append_arg, xd_initialize):
4057 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4058 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4059 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4060 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4061
78320123
PE
4062 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4063 if GCC considers string literals to be constants.
49cebcca 4064 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4065
35ac2a97
SM
40662011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4067
fb103ca9
SM
4068 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4069 (print_preprocess, print_object): New macro to fix last change.
4070
35ac2a97
SM
4071 * print.c (print_preprocess): Don't forget font objects.
4072
62973b41
JB
40732011-03-16 Juanma Barranquero <lekktu@gmail.com>
4074
4075 * emacs.c (USAGE3): Doc fixes.
4076
0e48bb22
AS
40772011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4078
4079 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4080 structure.
4081
7684e57b
JB
40822011-03-14 Juanma Barranquero <lekktu@gmail.com>
4083
4084 * lisp.h (VWindow_system, Qfile_name_history):
4085 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4086 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4087 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4088
4089 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4090 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4091
4092 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4093 * w32console.c (detect_input_pending, read_input_pending)
4094 (encode_terminal_code):
4095 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4096 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4097 (w32_system_caret_y, Qfile_name_history):
4098 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4099 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4100 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4101 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4102 * w32proc.c (Qlocal, report_file_error):
4103 * w32term.c (Vwindow_system, updating_frame):
4104 * w32uniscribe.c (initialized, uniscribe_font_driver):
4105 Remove unneeded extern declarations.
4106
2aa46d6c
CY
41072011-03-14 Chong Yidong <cyd@stupidchicken.com>
4108
c96bbc66 4109 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4110
cffc6f3b
CY
41112011-03-13 Chong Yidong <cyd@stupidchicken.com>
4112
4113 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4114 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4115 These macros can no longer be used for assignment.
4116
44f230aa
SM
4117 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4118 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4119 (record_buffer_markers, fetch_buffer_markers): New functions for
4120 recording and fetching special buffer markers.
4121 (set_buffer_internal_1, set_buffer_temp): Use them.
4122
4123 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4124
4125 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4126
4127 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4128 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4129
4130 * xdisp.c (hscroll_window_tree):
4131 (reconsider_clip_changes): Use PT instead of BUF_PT.
4132
d251f04b
EZ
41332011-03-13 Eli Zaretskii <eliz@gnu.org>
4134
4135 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4136 $(EMACS_ROOT)/lib/intprops.h.
4137
f0c77cd1
PE
41382011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4139
3eca4629
PE
4140 Fix more problems found by GCC 4.5.2's static checks.
4141
7c86ee98
PE
4142 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4143 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4144 (xg_free_frame_widgets): Make it clear that a local variable is
4145 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4146 (gdk_window_get_screen): Make it clear that this macro is needed
4147 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4148 (int_gtk_range_get_value): New function, which avoids a diagnostic
4149 from gcc -Wbad-function-cast.
4150 (xg_set_toolkit_scroll_bar_thumb): Use it.
4151 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4152 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4153 (get_utf8_string, xg_get_file_with_chooser):
4154 Rename locals to avoid shadowing.
4155 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4156
41729b81
PE
4157 * xgselect.c (xg_select): Remove unused var.
4158
f0c77cd1
PE
4159 * image.c (four_corners_best): Mark locals as initialized.
4160 (gif_load): Initialize transparent_p to zero (Bug#8238).
4161 Mark another local as initialized.
ec6cf4c6 4162 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4163
ce0ad53d 4164 * image.c (clear_image_cache): Now static.
d5d5a617 4165 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4166 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4167 (x_edge_detection): Remove unnecessary cast that
4168 gcc -Wbad-function-cast diagnoses.
2037898d 4169 (gif_load): Fix pointer signedness.
6ae141d6
PE
4170 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4171 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4172
33383987 41732011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4174
d32df629
PE
4175 Improve quality of tests for time stamp overflow.
4176 For example, without this patch (encode-time 0 0 0 1 1
4177 1152921504606846976) returns the obviously-bogus value (-948597
4178 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4179 reports time overflow. See
4180 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4181 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4182 * editfns.c: Include limits.h and intprops.h.
4183 (TIME_T_MIN, TIME_T_MAX): New macros.
4184 (time_overflow): Move earlier, to before first use.
4185 (hi_time, lo_time): New functions, for an accurate test for
4186 out-of-range times.
4187 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4188 (Fget_internal_run_time): Don't assume time_t fits in int.
4189 (make_time): Use list2 instead of Fcons twice.
4190 (Fdecode_time): More accurate test for out-of-range times.
4191 (check_tm_member): New function.
4192 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4193 (lisp_time_argument): Don't rely on undefined left-shift and
4194 right-shift behavior when checking for time stamp overflow.
8be6f318 4195
fe31d94c
PE
4196 * editfns.c (time_overflow): New function, refactoring common code.
4197 (Fformat_time_string, Fdecode_time, Fencode_time):
4198 (Fcurrent_time_string): Use it.
4199
8be6f318
PE
4200 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4201 * dired.c (make_time): Move to ...
4202 * editfns.c (make_time): ... here.
4203 * systime.h: Note the move.
4204
09d9db2c 42052011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4206
126bc0dc
YM
4207 * fringe.c (update_window_fringes): Remove unused variables.
4208
c47cbdfd
YM
4209 * unexmacosx.c (copy_data_segment): Also copy __got section.
4210 (Bug#8223)
4211
7ac80be9
EZ
42122011-03-12 Eli Zaretskii <eliz@gnu.org>
4213
c96bbc66 4214 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4215 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4216 Constify `char *' arguments and their references according to
4217 prototypes in tparam.h.
4218
ecb0f94d 4219 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4220
7ac80be9
EZ
4221 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4222 Adapt all references accordingly.
4223
4224 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4225
ef1fd07e
TT
42262011-03-11 Tom Tromey <tromey@redhat.com>
4227
4228 * buffer.c (syms_of_buffer): Remove obsolete comment.
4229
7ef4b50c
EZ
42302011-03-11 Eli Zaretskii <eliz@gnu.org>
4231
4232 * termhooks.h (encode_terminal_code): Declare prototype.
4233
4234 * msdos.c (encode_terminal_code): Don't declare prototype.
4235
4236 * term.c (encode_terminal_code): Now external again, used by
4237 w32console.c and msdos.c.
4238
44f230aa
SM
4239 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4240 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4241
4b1ec863 42422011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4243
1714f52b 4244 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4245
4b1ec863
PE
4246 * fringe.c (update_window_fringes): Mark locals as initialized
4247 (Bug#8227).
4248 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4249
524c7aa6
PE
4250 * alloc.c (mark_fringe_data): Move decl from here ...
4251 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4252 to check its interface.
4253 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4254
a5c0af81 4255 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4256 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4257 (fontset_font): Mark local as initialized.
a9a06e0b 4258 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4259
b4716021
PE
4260 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4261
811e9bac 4262 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4263 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4264 (x_own_selection, Fx_disown_selection_internal): Rename locals
4265 to avoid shadowing.
4266 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4267
7e3ab302
PE
4268 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4269 so that the caller can use some name other than gcpro1.
4270 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4271 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4272 (Fx_backspace_delete_keys_p):
4273 Use them to avoid shadowing, and rename vars to avoid shadowing.
4274 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4275 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4276 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4277 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4278 Remove unused locals.
7e3ab302
PE
4279 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4280 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4281 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4282 macros.
f78faa98 4283
e2b13473
PE
4284 * xterm.h (x_mouse_leave): New decl.
4285
77f23912
PE
4286 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4287 Remove unused functions.
cdf4ba58
PE
4288 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4289 (x_calc_absolute_position): Now static.
7411c686 4290 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4291 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4292 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4293 unless they are used.
38d0b34a
PE
4294 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4295 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4296 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4297 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4298 (x_error_catcher, x_connection_closed, x_error_handler):
4299 (x_error_quitter, xembed_send_message, x_iconify_frame):
4300 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4301 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4302 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4303
44f230aa
SM
4304 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4305 Rename or move locals to avoid shadowing.
6b463e58 4306 (tty_defined_color, merge_face_heights): Now static.
5967d051 4307 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4308 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4309 does not deduce is never used uninitialized.
73719eba
PE
4310 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4311 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4312
426994c3 4313 * terminal.c (store_terminal_param): Now static.
5489860b 4314
032f1620 4315 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4316 (set_frame_menubar): Remove unused local.
d4323972 4317 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4318 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4319 since they might point to immutable storage.
281585b0
PE
4320 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4321 since it's unused otherwise.
032f1620 4322
367c19e5 4323 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4324 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4325 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4326 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4327 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4328 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4329 does not deduce are never used uninitialized.
70739cbe 4330
07b48fa9
PE
4331 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4332
8868a238 4333 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4334 * window.c (window_loop, size_window):
4335 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4336
7e5cf297 4337 * window.c (display_buffer): Now static.
d6550a9f
PE
4338 (size_window): Mark variables that gcc -Wuninitialized
4339 does not deduce are never used uninitialized.
a586633d
PE
4340 * window.h (check_all_windows): New decl, to forestall
4341 gcc -Wmissing-prototypes diagnostic.
5b555da1 4342 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4343
f6095868
PE
4344 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4345 shadowing.
4346 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4347 Include <limits.h>.
4348 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4349 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4350 (load_charset_map): Mark variables that gcc -Wuninitialized
4351 does not deduce are never used uninitialized.
53df7c11 4352 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4353
f38b440c
PE
4354 * coding.c (coding_set_source, coding_set_destination):
4355 Use "else { /* comment */ }" rather than "else /* comment */;"
4356 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4357 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4358 a block, when the outer 'i' will do.
4359 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4360 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4361 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4362 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4363 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4364 Rename locals to avoid shadowing.
4365 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4366 * coding.c (emacs_mule_char, encode_invocation_designation):
4367 Now static, since they're not used elsewhere.
413bb2db 4368 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4369 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4370 (decode_coding_emacs_mule): Mark variables that gcc
4371 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4372 (detect_coding_iso_2022): Initialize a local variable that might
4373 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4374 this initialization is needed. (Bug#8211)
5f58e762
PE
4375 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4376 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4377 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4378 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4379 Remove unused macros.
f38b440c 4380
232b38b9 4381 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4382 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4383 * character.c (string_count_byte8): Likewise.
232b38b9 4384
fb90da1b
PE
4385 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4386 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4387
fb93dbc2
PE
4388 * chartab.c (copy_sub_char_table): Now static, since it's not used
4389 elsewhere.
5c156ace
PE
4390 (sub_char_table_ref_and_range, char_table_ref_and_range):
4391 Rename locals to avoid shadowing.
bbcd0949 4392 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4393
7d3b3862 4394 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4395 (BIDI_BOB): Remove unused macro.
7d3b3862 4396
6be7d3da
PE
4397 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4398 deduce are never used uninitialized.
c2ed9c8b 4399 * term.c (encode_terminal_code): Likewise.
6be7d3da 4400
75f8807f 4401 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4402
50938595
PE
4403 * tparam.h: New file.
4404 * term.c, tparam.h: Include it.
4405 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4406 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4407 Move these decls to tparam.h, and make them agree with what
4408 is actually in tparam.c. The previous trick of using incompatible
4409 decls in different modules does not conform to the C standard.
4410 All callers of tparam changed to use tparam's actual API.
4411 * tparam.c (tparam1, tparam, tgoto):
4412 Use const pointers where appropriate.
4413
fbceeba2
PE
4414 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4415 * cm.h (struct cm): Likewise.
4416 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4417 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4418 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4419 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4420 (turn_on_face, init_tty): Likewise.
4421 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4422
7f3f1250
PE
4423 * term.c (term_mouse_position): Rename local to avoid shadowing.
4424
e6ca6543
PE
4425 * alloc.c (mark_ttys): Move decl from here ...
4426 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4427
c40f8d15
AS
44282011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4429
4430 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4431
cfe0661d
JB
44322011-03-09 Juanma Barranquero <lekktu@gmail.com>
4433
4434 * search.c (compile_pattern_1): Remove argument regp, unused since
4435 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4436 (compile_pattern): Don't pass it.
4437
0afb4571
J
44382011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4439
4440 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4441 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4442 for ! HAVE_GTK3.
4443 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4444
4445 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4446
4447 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4448 gdk_window_get_screen, gdk_window_get_geometry,
4449 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4450 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4451 (xg_get_pixbuf_from_pixmap): New function.
4452 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4453 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4454 Call xg_get_pixbuf_from_pixmap instead of
4455 gdk_pixbuf_get_from_drawable.
4456 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4457 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4458 (xg_check_special_colors): Use GtkStyleContext and its functions
4459 for HAVE_GTK3.
4460 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4461 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4462 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4463 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4464 Call gtk_widget_get_preferred_size.
0afb4571
J
4465 (xg_frame_resized): gdk_window_get_geometry only takes 5
4466 parameters.
44f230aa
SM
4467 (xg_win_to_widget, xg_event_is_for_menubar):
4468 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4469 (xg_set_widget_bg): New function.
4470 (delete_cb): New function.
895009e1 4471 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4472 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4473 (xg_set_background_color): Call xg_set_widget_bg.
4474 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4475 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4476 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4477 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4478 if ! HAVE_GTK3.
4479 (update_frame_tool_bar): Call gtk_widget_hide.
4480 (xg_initialize): Use GDK_KEY_g.
4481
4482 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4483 if ! HAVE_GTK3
4484 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4485
4486 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4487 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4488 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4489
1c2cc4ef
JB
44902011-03-08 Juanma Barranquero <lekktu@gmail.com>
4491
4492 * w32xfns.c (select_palette): Check success of RealizePalette against
4493 GDI_ERROR, not zero.
4494
33383987 4495See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4496
4497;; Local Variables:
4498;; coding: utf-8
aac0c6e3
MR
4499;; End:
4500
33383987 4501 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4502
4503 This file is part of GNU Emacs.
4504
4505 GNU Emacs is free software: you can redistribute it and/or modify
4506 it under the terms of the GNU General Public License as published by
4507 the Free Software Foundation, either version 3 of the License, or
4508 (at your option) any later version.
4509
4510 GNU Emacs is distributed in the hope that it will be useful,
4511 but WITHOUT ANY WARRANTY; without even the implied warranty of
4512 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4513 GNU General Public License for more details.
4514
4515 You should have received a copy of the GNU General Public License
4516 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.