Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ea204efb
PE
12011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2
d37ca623
PE
3 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4 These casts should not be needed on 32-bit hosts, either.
5 * keyboard.c (read_char):
6 * lread.c (Fload): Remove casts to unsigned.
7
ea204efb
PE
8 * lisp.h (UNSIGNED_CMP): New macro.
9 This fixes comparison bugs on 64-bit hosts.
10 (ASCII_CHAR_P): Use it.
11 * casefiddle.c (casify_object):
12 * character.h (ASCII_BYTE_P, CHAR_VALID_P):
13 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
14 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
15 * dispextern.h (FACE_FROM_ID):
16 * keyboard.c (read_char): Use UNSIGNED_CMP.
17
fc83f7d3 182011-06-11 Paul Eggert <eggert@cs.ucla.edu>
666398f3 19
41cb286c
PE
20 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
21 not to EMACS_INT, to avoid GCC warning.
22
4a1b9832
PE
23 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
24
55daad71
PE
25 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
26 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
27 isn't needed on 32-bit machines.
8f95c75c 28
666398f3 29 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
0ceccced 30 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
31
32 * data.c (Qcompiled_function): Now static.
33
c6f072e7
PE
34 * window.c (window_body_lines): Now static.
35
20ce5912
PE
36 * image.c (gif_load): Rename local to avoid shadowing.
37
9c4c5f81
PE
38 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
39 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
40 * alloc.c (make_save_value): Integer argument is now of type
41 ptrdiff_t, not int.
42 (mark_object): Use ptrdiff_t, not int.
43 * lisp.h (pD): New macro.
44 * print.c (print_object): Use it.
45
c0c5c8ae
PE
46 * alloc.c: Use EMACS_INT, not int, to count objects.
47 (total_conses, total_markers, total_symbols, total_vector_size)
48 (total_free_conses, total_free_markers, total_free_symbols)
49 (total_free_floats, total_floats, total_free_intervals, total_intervals)
50 (total_strings, total_free_strings):
51 Now EMACS_INT, not int. All uses changed.
52 (Fgarbage_collect): Compute overall total using a double, so that
53 integer overflow is less likely to be a problem. Check for overflow
54 when converting back to an integer.
5a25e253
PE
55 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
56 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
57 These were 'int' variables that could overflow on 64-bit hosts;
58 they were never used, so remove them instead of repairing them.
211a0b2a 59 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
60 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
61 Previously, this ceilinged at INT_MAX, but that doesn't work on
62 64-bit machines.
e46bb31a 63 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 64
c78baabf 65 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 66 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
67 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
68 when a (possibly-narrower) signed value would do just as well.
69 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 70
c9d624c6
PE
71 * alloc.c: Catch some string size overflows that we were missing.
72 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
73 for convenience in STRING_BYTES_MAX.
74 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
75 The definition here is exact; the one in lisp.h was approximate.
76 (allocate_string_data): Check for string overflow. This catches
77 some instances we weren't catching before. Also, it catches
78 size_t overflow on (unusual) hosts where SIZE_MAX <= min
79 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
80 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 81
c9d624c6
PE
82 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
83 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
84 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
85
353032ce
PE
86 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
87
2bccce07
PE
88 * alloc.c (Fmake_string): Check for out-of-range init.
89
b50691aa
CY
902011-06-11 Chong Yidong <cyd@stupidchicken.com>
91
92 * dispextern.h (struct image): Replace data member, whose int_val
93 and ptr_val fields were not used by anything, with a single
94 lisp_val object.
95
96 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
97 (gif_clear_image, gif_load, imagemagick_load_image)
98 (gs_clear_image, gs_load): Callers changed.
99
3f754b86
PE
1002011-06-10 Paul Eggert <eggert@cs.ucla.edu>
101
cca69397
PE
102 * buffer.h: Include <time.h>, for time_t.
103 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
104
109e28d0
PE
105 Fix minor problems found by static checking.
106
60737f02
PE
107 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
108
4b66faf3
PE
109 Make identifiers static if they are not used in other modules.
110 * data.c (Qcompiled_function, Qframe, Qvector):
111 * image.c (QimageMagick, Qsvg):
112 * minibuf.c (Qmetadata):
113 * window.c (resize_window_check, resize_root_window): Now static.
114 * window.h (resize_window_check, resize_root_window): Remove decls.
115
109e28d0
PE
116 * window.c (window_deletion_count, delete_deletable_window):
117 Remove; unused.
46a4ce9e
PE
118 (window_body_lines): Now static.
119 (Fdelete_other_windows_internal): Mark vars as initialized.
120 Make sure 'resize_failed' is initialized.
121 (run_window_configuration_change_hook): Rename local to avoid shadowing.
122 (resize_window_apply): Remove unused local.
123 * window.h (delete_deletable_window): Remove decl.
124
109e28d0 125 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
126 (imagemagick_load_image): Fix pointer signedness problem by changing
127 last arg from unsigned char * to char *. All uses changed.
128 Also, fix a local for similar reasons.
129 Remove unused locals. Remove locals to avoid shadowing.
130 (fn_rsvg_handle_free): Remove; unused.
131 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 132 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 133
3f754b86
PE
134 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
135
2547adb1
CY
1362011-06-10 Chong Yidong <cyd@stupidchicken.com>
137
138 * image.c (gif_load): Fix omitted cast error introduced by
139 2011-06-06 change.
140
2c8e37d4
MR
1412011-06-10 Martin Rudalics <rudalics@gmx.at>
142
143 * window.h (resize_proportionally, orig_total_lines)
144 (orig_top_line): Remove from window structure.
145 (set_window_height, set_window_width, change_window_heights)
146 (Fdelete_window): Remove prototypes.
147 (resize_frame_windows): Remove duplicate declaration.
148
440a42e3
EZ
1492011-06-10 Eli Zaretskii <eliz@gnu.org>
150
151 * window.h (resize_frame_windows, resize_window_check)
152 (delete_deletable_window, resize_root_window)
153 (resize_frame_windows): Declare prototypes.
154
155 * window.c (resize_window_apply): Make definition be "static" to
156 match the prototype.
157
562dd5e9
MR
1582011-06-10 Martin Rudalics <rudalics@gmx.at>
159
160 * window.c: Remove declarations of Qwindow_size_fixed,
161 window_min_size_1, window_min_size_2, window_min_size,
162 size_window, window_fixed_size_p, enlarge_window, delete_window.
163 Remove static from declaration of Qdelete_window, it's
164 temporarily needed by Fbury_buffer.
165 (replace_window): Don't assign orig_top_line and
166 orig_total_lines.
167 (Fdelete_window, delete_window): Remove. Window deletion is
168 handled by window.el.
169 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
170 Fdelete_window calls with calls to Qdelete_window.
171 (Fdelete_other_windows): Remove. Deleting other windows is
172 handled by window.el.
173 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
174 handled in window.el.
175 (window_min_size_2, window_min_size_1, window_min_size): Remove.
176 Window minimum sizes are handled in window.el.
177 (shrink_windows, size_window, set_window_height)
178 (set_window_width, change_window_heights, window_height)
179 (window_width, CURBEG, CURSIZE, enlarge_window)
180 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
181 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
182 handled in window.el.
183 (make_dummy_parent): Rename to make_parent_window and give it a
184 second argument horflag.
185 (make_window): Don't set resize_proportionally any more.
186 (Fsplit_window): Remove. Windows are split in window.el.
187 (save_restore_action, save_restore_orig_size)
188 (shrink_window_lowest_first, save_restore_orig_size): Remove.
189 Resize mini windows in window.el.
190 (grow_mini_window, shrink_mini_window): Implement by calling
191 Qresize_root_window_vertically, resize_window_check and
192 resize_window_apply.
193 (saved_window, Fset_window_configuration, save_window_save): Do
194 not handle orig_top_line, orig_total_lines, and
195 resize_proportionally.
196 (window_min_height, window_min_width): Move to window.el.
197 (keys_of_window): Move bindings for delete-other-windows,
198 split-window, delete-window and enlarge-window to window.el.
199
200 * buffer.c: Temporarily extern Qdelete_window.
201 (Fbury_buffer): Temporarily call Qdelete_window instead of
202 Fdelete_window (Fbury_buffer will move to window.el soon).
203
204 * frame.c (set_menu_bar_lines_1): Remove code handling
205 orig_top_line and orig_total_lines.
206
207 * dispnew.c (adjust_frame_glyphs_initially): Don't use
208 set_window_height but set heights directly.
209 (change_frame_size_1): Use resize_frame_windows.
210
211 * xdisp.c (init_xdisp): Don't use set_window_height but set
212 heights directly.
213
214 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
215 resize_frame_windows instead of change_window_heights and run
216 run_window_configuration_change_hook.
217
218 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
219 instead of change_window_heights and run
220 run_window_configuration_change_hook.
221
1a13852e
MR
2222011-06-09 Martin Rudalics <rudalics@gmx.at>
223
224 * window.c (replace_window): Rename second argument REPLACEMENT to
225 NEW. New third argument SETFLAG. Rewrite.
226 (delete_window, make_dummy_parent): Call replace_window with
227 third argument 1.
228 (window_list_1): Move down in code.
229 (run_window_configuration_change_hook): Move set_buffer part
230 before select_frame_norecord part in order to unwind correctly.
231 Rename count1 to count.
232 (recombine_windows, delete_deletable_window, resize_root_window)
233 (Fdelete_other_windows_internal)
234 (Frun_window_configuration_change_hook, make_parent_window)
235 (resize_window_check, resize_window_apply, Fresize_window_apply)
236 (resize_frame_windows, Fsplit_window_internal)
237 (Fdelete_window_internal, Fresize_mini_window_internal): New
238 functions.
239 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
240
f3d1777e
MR
2412011-06-08 Martin Rudalics <rudalics@gmx.at>
242
496e208e
MR
243 * window.h (window): Add some new members to window structure -
244 normal_lines, normal_cols, new_total, new_normal, clone_number,
245 splits, nest, prev_buffers, next_buffers.
246 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 247 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 248
f3d1777e
MR
249 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
250 Remove.
496e208e
MR
251 (make_dummy_parent): Set new members of windows structure.
252 (make_window): Move down in code. Handle new members of window
253 structure.
254 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
255 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
256 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
257 (Fset_window_prev_buffers, Fwindow_next_buffers)
258 (Fset_window_next_buffers, Fset_window_clone_number): New
259 functions.
260 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
261 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
262 Doc-string fixes.
263 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
264 Argument WINDOW can be now internal window too.
265 (Fwindow_use_time): Move up in code.
266 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
267 Rewrite doc-string.
268 (Fset_window_configuration, saved_window)
269 (Fcurrent_window_configuration, save_window_save): Handle new
270 members of window structure.
b9e809c2
MR
271 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
272 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
273 (syms_of_window): New Lisp objects Qrecord_window_buffer,
274 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
275 Qget_mru_window, Qresize_root_window,
276 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
277 Qauto_buffer_name; staticpro them.
f3d1777e 278
abde8f8c
MR
2792011-06-07 Martin Rudalics <rudalics@gmx.at>
280
281 * window.c (Fwindow_total_size, Fwindow_left_column)
282 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
283 (Fwindow_list_1): New functions.
284 (window_box_text_cols): Replace with window_body_cols.
285 (Fwindow_width, Fscroll_left, Fscroll_right): Use
286 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
287 (delete_window, Fset_window_configuration): Call
288 delete_all_subwindows with window as argument.
289 (delete_all_subwindows): Take a window as argument and not a
290 structure. Rewrite.
190b47e6
MR
291 (window_loop): Remove handling of GET_LRU_WINDOW and
292 GET_LARGEST_WINDOW.
293 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
294
295 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
296 window_box_text_cols. delete_all_subwindows now takes a
297 Lisp_Object as argument.
abde8f8c
MR
298
299 * indent.c (compute_motion, Fcompute_motion): Use
300 window_body_cols instead of window_box_text_cols.
301
fa8a67e6
MR
302 * frame.c (delete_frame): Call delete_all_subwindows with root
303 window as argument.
304
a54e3482
DC
3052011-06-07 Daniel Colascione <dan.colascione@gmail.com>
306
307 * fns.c (Fputhash): Document return value.
308
60002bf5
CY
3092011-06-06 Chong Yidong <cyd@stupidchicken.com>
310
311 * image.c (gif_load): Implement gif89a spec "no disposal" method.
312
0c671da6 3132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 314
b862a52a 315 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 316
be44ca6c
PE
317 Check for overflow when converting integer to cons and back.
318 * charset.c (Fdefine_charset_internal, Fdecode_char):
319 Use cons_to_unsigned to catch overflow.
320 (Fencode_char): Use INTEGER_TO_CONS.
321 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
322 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
323 * data.c (long_to_cons, cons_to_long): Remove.
324 (cons_to_unsigned, cons_to_signed): New functions.
325 These signal an error for invalid or out-of-range values.
326 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
327 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
328 * font.c (Ffont_variation_glyphs):
329 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
330 * lisp.h: Include <intprops.h>.
331 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
332 (cons_to_signed, cons_to_unsigned): New decls.
333 (long_to_cons, cons_to_long): Remove decls.
334 * undo.c (record_first_change): Use INTEGER_TO_CONS.
335 (Fprimitive_undo): Use CONS_TO_INTEGER.
336 * xfns.c (Fx_window_property): Likewise.
337 * xselect.c: Include <limits.h>.
338 (x_own_selection, selection_data_to_lisp_data):
339 Use INTEGER_TO_CONS.
340 (x_handle_selection_request, x_handle_selection_clear)
341 (x_get_foreign_selection, Fx_disown_selection_internal)
342 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
343 (lisp_data_to_selection_data): Use cons_to_unsigned.
344 (x_fill_property_data): Use cons_to_signed.
345 Report values out of range.
346
d1f3d2af
PE
347 Check for buffer and string overflow more precisely.
348 * buffer.h (BUF_BYTES_MAX): New macro.
349 * lisp.h (STRING_BYTES_MAX): New macro.
350 * alloc.c (Fmake_string):
351 * character.c (string_escape_byte8):
352 * coding.c (coding_alloc_by_realloc):
353 * doprnt.c (doprnt):
354 * editfns.c (Fformat):
355 * eval.c (verror):
356 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
357 since they may not be the same number.
358 * editfns.c (Finsert_char):
359 * fileio.c (Finsert_file_contents):
360 Likewise for BUF_BYTES_MAX.
361
dd52fcea
PE
362 * image.c: Use ptrdiff_t, not int, for sizes.
363 (slurp_file): Switch from int to ptrdiff_t.
364 All uses changed.
365 (slurp_file): Check that file size fits in both size_t (for
366 malloc) and ptrdiff_t (for sanity and safety).
367
7f9bbdbb
PE
368 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
369 if b->modtime has its maximal value.
370
dfe18f82
PE
371 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
372
84acfcf0
PE
373 Don't assume time_t can fit into int.
374 * buffer.h (struct buffer.modtime): Now time_t, not int.
375 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
376 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
377
ccd9a01a
PE
378 Minor fixes for signed vs unsigned integers.
379 * character.h (MAYBE_UNIFY_CHAR):
380 * charset.c (maybe_unify_char):
381 * keyboard.c (read_char, reorder_modifiers):
382 XINT -> XFASTINT, since the integer must be nonnegative.
383 * ftfont.c (ftfont_spec_pattern):
384 * keymap.c (access_keymap, silly_event_symbol_error):
385 XUINT -> XFASTINT, since the integer must be nonnegative.
386 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
387 since it makes no difference and we prefer signed.
388 * keyboard.c (record_char): Use XUINT when all the neighbors do.
389 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
390 nonnegative.
391
d6d100dd
SM
3922011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
393
394 * window.h (Fwindow_frame): Declare.
395
2b6148e4
PE
3962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
397
398 * alloc.c: Simplify handling of large-request failures (Bug#8800).
399 (SPARE_MEMORY): Always define.
400 (LARGE_REQUEST): Remove.
401 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
402
f230ecc9
MR
4032011-06-06 Martin Rudalics <rudalics@gmx.at>
404
727e958e
MR
405 * lisp.h: Move EXFUNS for Fframe_root_window,
406 Fframe_first_window and Fset_frame_selected_window to window.h.
407
408 * window.h: Move EXFUNS for Fframe_root_window,
409 Fframe_first_window and Fset_frame_selected_window here from
410 lisp.h.
411
412 * frame.c (Fwindow_frame, Fframe_first_window)
413 (Fframe_root_window, Fframe_selected_window)
414 (Fset_frame_selected_window): Move to window.c.
415 (Factive_minibuffer_window): Move to minibuf.c.
416 (Fother_visible_frames_p): New function.
417
418 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
419
f230ecc9
MR
420 * window.c (decode_window, decode_any_window): Move up in code.
421 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
422 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
423 (Fwindow_buffer): Move up and rewrite doc-string.
424 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
425 (Fwindow_prev): New functions.
727e958e
MR
426 (Fwindow_frame): Move here from frame.c. Accept any window as
427 argument.
428 (Fframe_root_window, Fframe_first_window)
429 (Fframe_selected_window): Move here from frame.c. Accept frame
430 or arbitrary window as argument. Update doc-strings.
431 (Fminibuffer_window): Move up in code.
432 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
433 (Fset_frame_selected_window): Move here from frame.c.
434 Marginal rewrite.
727e958e
MR
435 (Fselected_window, select_window, Fselect_window): Move up in
436 code. Minor doc-string fixes.
f230ecc9 437
4d09bcf6
PE
4382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
439
440 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
441 Do not assume that spare memory exists; that assumption is valid
442 only if SYSTEM_MALLOC.
443 (LARGE_REQUEST): New macro, so that the issue of large requests
444 is separated from the issue of spare memory.
445
810928a2
AS
4462011-06-05 Andreas Schwab <schwab@linux-m68k.org>
447
172418ad
AS
448 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
449 format. (Bug#8806)
450
43f862f7
AS
451 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
452
810928a2
AS
453 * xfns.c (x_set_scroll_bar_default_width): Move declarations
454 before statements.
455
a059fe24
JD
4562011-06-05 Jan Djärv <jan.h.d@swipnet.se>
457
458 * gtkutil.c (xg_get_default_scrollbar_width): New function.
459
460 * gtkutil.h: Declare xg_get_default_scrollbar_width.
461
462 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
463 min width by calling x_set_scroll_bar_default_width (Bug#8505).
464
989bf368
JB
4652011-06-05 Juanma Barranquero <lekktu@gmail.com>
466
467 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
468
4b80f674
CY
4692011-06-04 Chong Yidong <cyd@stupidchicken.com>
470
471 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
472 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
473 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
474 New error handlers.
4b80f674
CY
475 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
476 Obey Vx_select_enable_clipboard_manager. Catch errors in
477 x_clipboard_manager_save (Bug#8779).
478 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 479 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 480
99a33b77 4812011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
482
483 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
484
99a33b77 4852011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
486
487 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
488 in the current matrix if keep_current_p is non-zero.
489
8264569d
EZ
4902011-06-04 Eli Zaretskii <eliz@gnu.org>
491
492 * bidi.c (bidi_level_of_next_char): Fix last change.
493
57f97249
EZ
4942011-06-03 Eli Zaretskii <eliz@gnu.org>
495
fec2107c 496 Support bidi reordering of text covered by display properties.
57f97249 497
fec2107c
EZ
498 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
499 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
500 (bidi_cache_search, bidi_cache_iterator_state)
501 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
502 (bidi_level_of_next_char, bidi_move_to_visually_next):
503 Support character positions inside a run of characters covered by a
fec2107c
EZ
504 display string.
505 (bidi_paragraph_init, bidi_resolve_explicit_1)
506 (bidi_level_of_next_char): Call bidi_fetch_char and
507 bidi_fetch_char_advance instead of FETCH_CHAR and
508 FETCH_CHAR_ADVANCE.
509 (bidi_init_it): Initialize new members.
510 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
511 definitions.
512 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
513 instead of using explicit *_CHAR codes.
d6d100dd
SM
514 (bidi_resolve_explicit, bidi_resolve_weak):
515 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
516 bidirectional text is supported only in multibyte buffers.
517 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
518 it to initialize the frame_window_p member of struct bidi_it.
519 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
520 (bidi_resolve_explicit, bidi_resolve_weak)
521 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
522 bidi_it->nchars is non-positive.
523 (bidi_level_of_next_char): Don't try to lookup the cache for the
524 next/previous character if nothing is cached there yet, or if we
525 were just reseat()'ed to a new position.
c40e2fb2 526
0e14fe90
EZ
527 * xdisp.c (set_cursor_from_row): Set start and stop points
528 according to the row's direction when priming the loop that looks
529 for the glyph on which to display cursor.
530 (single_display_spec_intangible_p): Function deleted.
531 (display_prop_intangible_p): Reimplement to call
532 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
533 Accept 3 additional arguments needed by handle_display_spec.
534 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
535 values: lists, `(when COND...)' forms, etc.
536 (single_display_spec_string_p): Support property values that are
537 lists with the argument STRING its top-level element.
538 (display_prop_string_p): Fix the condition for processing a
539 property that is a list to be consistent with handle_display_spec.
fec2107c 540 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
541 last portion of handle_display_prop.
542 (compute_display_string_pos): Accept additional argument
543 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
544 value of a `display' property is a "replacing spec".
545 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
546 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
547 the display property, but just return a value indicating whether
548 the display property will replace the characters it covers.
549 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
550 frame_window_p members of struct bidi_it.
d6d100dd
SM
551 (compute_display_string_pos, compute_display_string_end):
552 New functions.
fec2107c
EZ
553 (push_it): Accept second argument POSITION, where pop_it should
554 jump to continue iteration.
555 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 556
fec2107c
EZ
557 * keyboard.c (adjust_point_for_property): Adjust the call to
558 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
559
560 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
561 (bidi_init_it): Update prototypes.
562 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
563 (compute_display_string_pos, compute_display_string_end):
564 Declare prototypes.
fec2107c
EZ
565 (struct bidi_it): New members nchars and disp_pos. ch_len is now
566 EMACS_INT.
fc6f18ce 567
40087514 5682011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 569
57f53182
PE
570 Malloc failure behavior now depends on size of allocation.
571 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
572 * lisp.h: Change signatures accordingly.
573 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
574 All callers changed. (Bug#8762)
575
576 * gnutls.c: Use Emacs's memory allocators.
577 Without this change, the gnutls library would invoke malloc etc.
578 directly, which causes problems on non-SYNC_INPUT hosts, and which
579 runs afoul of improving memory_full behavior. (Bug#8761)
580 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
581 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
582 xfree instead of the default malloc, realloc, free.
583 (Fgnutls_boot): No need to check for memory allocation failure,
584 since xmalloc does that for us.
585
ac32cd99 586 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
587 * category.c (hash_get_category_set):
588 * ccl.c (ccl_driver):
589 * charset.c (Fdefine_charset_internal):
590 * charset.h (struct charset.hash_index):
591 * composite.c (get_composition_id, gstring_lookup_cache)
592 (composition_gstring_put_cache):
593 * composite.h (struct composition.hash_index):
594 * dispextern.h (struct image.hash):
595 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
596 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
597 (hashfn_equal, hashfn_user_defined, make_hash_table)
598 (maybe_resize_hash_table, hash_lookup, hash_put)
599 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
600 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
601 (Fsxhash, Fgethash, Fputhash, Fmaphash):
602 * image.c (make_image, search_image_cache, lookup_image)
603 (xpm_put_color_table_h):
604 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 605 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
606 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
607 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
608 * alloc.c (allocate_vectorlike):
609 Check for overflow in vector size calculations.
610 * ccl.c (ccl_driver):
611 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
612 * fns.c, image.c: Remove unnecessary static decls that would otherwise
613 need to be updated by these changes.
40087514
PE
614 * fns.c (make_hash_table, maybe_resize_hash_table):
615 Check for integer overflow with large hash tables.
0de4bb68
PE
616 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
617 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
618 (SXHASH_REDUCE): New macro.
619 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
620 Use it instead of discarding useful hash info with large hash values.
621 (sxhash_float): New function.
622 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
623 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
624 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
625 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
626 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
627 Adjust signatures to match updated version of code.
628 (consing_since_gc): Now EMACS_INT, since a single hash table can
629 use more than INT_MAX bytes.
630
698d32e2
DN
6312011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
632
633 Make it possible to build with GCC-4.6+ -O2 -flto.
634
635 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
636
fd6fa53f
SM
6372011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
638
639 * minibuf.c (get_minibuffer, read_minibuf_unwind):
640 Call minibuffer-inactive-mode.
641
864db017
JB
6422011-05-31 Juanma Barranquero <lekktu@gmail.com>
643
644 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
645 Update dependencies.
646
2ad0baf4
DN
6472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
648
649 * data.c (init_data): Remove code for UTS, this system is not
650 supported anymore.
651
4fcc2638
DN
6522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
653
654 Don't force ./temacs to start in terminal mode.
655
656 * frame.c (make_initial_frame): Initialize faces in all cases, not
657 only when CANNOT_DUMP is defined.
658 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
659
c56e0fd5
DN
6602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
661
662 * dispnew.c (add_window_display_history): Use const for the string
663 pointer. Remove declaration, not needed.
664
333d54da 6652011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 666
55d4c1b2 667 Use 'inline', not 'INLINE'.
333d54da 668 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
669 * alloc.c, fontset.c (INLINE): Remove.
670 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
671 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
672 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
673 * gmalloc.c (register_heapinfo): Use inline unconditionally.
674 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
675
738db178
DN
6762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
677
678 Make it possible to run ./temacs.
679
680 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
681 syms_of_callproc does the same thing. Remove test for
682 "initialized", do it in the caller.
683 * emacs.c (main): Avoid calling set_initial_environment when dumping.
684
620c53a6
SM
6852011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
686
687 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
688 (read_minibuf): Use get_minibuffer.
689 (syms_of_minibuf): Use DEFSYM.
690 (Qmetadata): New var.
691 * data.c (Qbuffer): Don't make it static.
692 (syms_of_data): Use DEFSYM.
693
e003a292
PE
6942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
695
696 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
697 (CCL_CODE_MIN): New macro.
698
ed008a6d
PE
6992011-05-30 Paul Eggert <eggert@cs.ucla.edu>
700
3687c2ef
PE
701 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
702
ed008a6d
PE
703 * eval.c (Qdebug): Now static.
704 * lisp.h (Qdebug): Remove decl. This reverts a part of the
705 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
706 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
707
d66c4c7c
CY
7082011-05-29 Chong Yidong <cyd@stupidchicken.com>
709
710 * image.c: Various fixes to ImageMagick code comments.
711 (Fimagemagick_types): Doc fix.
712
5fbc2025
PE
7132011-05-29 Paul Eggert <eggert@cs.ucla.edu>
714
0196f88a
PE
715 Minor fixes prompted by GCC 4.6.0 warnings.
716
717 * xselect.c (converted_selections, conversion_fail_tag): Now static.
718
5fbc2025
PE
719 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
720 (x_clipboard_manager_save_all): Move extern decl to ...
721 * xterm.h: ... here, so that it can be checked for consistency.
722
1dd3c2d9
CY
7232011-05-29 Chong Yidong <cyd@stupidchicken.com>
724
725 * xselect.c (x_clipboard_manager_save_frame)
726 (x_clipboard_manager_save_all): New functions.
727 (Fx_clipboard_manager_save): Lisp function deleted.
728
729 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
730 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
731
732 * xterm.h: Update prototype.
733
5ba6571d
WX
7342011-05-28 William Xu <william.xwl@gmail.com>
735
736 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
737 exiting (Bug#8239).
738
3eaff834
JM
7392011-05-28 Jim Meyering <meyering@redhat.com>
740
e1900994 741 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
742 * fns.c (to_uchar): Define.
743 (crypto_hash_function): Use it to convert some newly-signed
744 variables to unsigned, to avoid sign-extension bugs. For example,
745 without this change, (md5 "truc") would evaluate to
746 45723a2aff78ff4fff7fff1114760e62 rather than the expected
747 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 748 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 749
0f6990a7
PE
7502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
751
752 Integer overflow fixes.
c8a9ca5a 753
08686060
PE
754 * dbusbind.c: Serial number integer overflow fixes.
755 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
756 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
757 to hold a serial number that is too large for a fixnum.
758 (Fdbus_method_return_internal, Fdbus_method_error_internal):
759 Check for serial numbers out of range. Decode any serial number
59568bf0 760 that was so large that it became a float. (Bug#8722)
08686060 761
2d1fc3c7
PE
762 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
763 (Fdbus_call_method, Fdbus_call_method_asynchronously):
764 Use XFASTINT rather than XUINT when numbers are nonnegative.
765 (xd_append_arg, Fdbus_method_return_internal):
766 (Fdbus_method_error_internal): Likewise. Also, for unsigned
767 arguments, check that Lisp number is nonnegative, rather than
59568bf0 768 silently wrapping negative numbers around. (Bug#8722)
30217ff0 769 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 770 (Bug#8722)
2d1fc3c7 771
c8a9ca5a
PE
772 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
773
519e1d69
PE
774 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
775
30569699
PE
776 ccl: add integer overflow checks
777 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
778 (IN_INT_RANGE): New macros.
779 (ccl_driver): Use them to check for integer overflow when
780 decoding a CCL program. Many of the new checks are whether XINT (x)
781 fits in int; it doesn't always, on 64-bit hosts. The new version
782 doesn't catch all possible integer overflows, but it's an
847044ea 783 improvement. (Bug#8719)
30569699 784
c11285dc
PE
785 * alloc.c (make_event_array): Use XINT, not XUINT.
786 There's no need for unsigned here.
787
fdccd48e
PE
788 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
789 This follows up to the 2011-05-06 change that substituted uintptr_t
790 for EMACS_INT. This case wasn't caught back then.
791
37910ab2
PE
792 Rework Fformat to avoid integer overflow issues.
793 * editfns.c: Include <float.h> unconditionally, as it's everywhere
794 now (part of C89). Include <verify.h>.
795 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
796 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
797 (Fformat): Avoid the prepass trying to compute sizes; it was only
798 approximate and thus did not catch overflow reliably. Instead, walk
799 through the format just once, formatting and computing sizes as we go,
800 checking for integer overflow at every step, and allocating a larger
801 buffer as needed. Keep track separately whether the format is
802 multibyte. Keep only the most-recently calculated precision, rather
803 than them all. Record whether each argument has been converted to
804 string. Use EMACS_INT, not int, for byte and char and arg counts.
805 Support field widths and precisions larger than INT_MAX. Avoid
806 sprintf's undefined behavior with conversion specifications such as %#d
807 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
808 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
809 formatting out-of-range floating point numbers with int
810 formats. (Bug#8668)
811
2e6578fb
PE
812 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
813
0ae6bdee
PE
814 * data.c: Avoid integer truncation in expressions involving floats.
815 * data.c: Include <intprops.h>.
816 (arith_driver): When there's an integer overflow in an expression
817 involving floating point, convert the integers to floating point
818 so that the resulting value does not suffer from catastrophic
819 integer truncation. For example, on a 64-bit host (* 4
820 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
821 Do not rely on undefined behavior after integer overflow.
822
de883a70
PE
823 merge count_size_as_multibyte, parse_str_to_multibyte
824 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 825 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
826 Check for integer overflow.
827 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
828 since it's now a duplicate of the other. This is more of
829 a character than a buffer op, so better that it's in character.c.
830 * fns.c, print.c: Adjust to above changes.
831
2ff916cb
PE
8322011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
833
834 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
835
f1b54466
PE
8362011-05-27 Paul Eggert <eggert@cs.ucla.edu>
837
fb1ac845
PE
838 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
839 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
840 (x_clipboard_manager_save): Now static.
841 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
842
f1b54466
PE
843 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
844 (crypto_hash_function): Now static.
845 Fix pointer signedness problems. Avoid unnecessary initializations.
846
a9f737ee
CY
8472011-05-27 Chong Yidong <cyd@stupidchicken.com>
848
849 * termhooks.h (Vselection_alist): Make it terminal-local.
850
851 * terminal.c (create_terminal): Initialize it.
852
853 * xselect.c: Support for clipboard managers.
854 (Vselection_alist): Move to termhooks.h as terminal-local var.
855 (LOCAL_SELECTION): New macro.
856 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
857 (symbol_to_x_atom): Remove gratuitous arg.
858 (x_handle_selection_request, lisp_data_to_selection_data)
859 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
860 (x_own_selection, x_get_local_selection, x_convert_selection):
861 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
862 (some_frame_on_display): Delete unused function.
863 (Fx_own_selection_internal, Fx_get_selection_internal)
864 (Fx_disown_selection_internal, Fx_selection_owner_p)
865 (Fx_selection_exists_p): New optional frame arg.
866 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
867 (x_handle_selection_clear): Don't treat other terminals with the
868 same keyboard specially. Use the terminal-local Vselection_alist.
869 (x_clear_frame_selections): Use Frun_hook_with_args.
870
871 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
872
873 * xterm.h: Add support for those atoms.
874
e067f0c1
CY
8752011-05-26 Chong Yidong <cyd@stupidchicken.com>
876
877 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
878 (converted_selections, conversion_fail_tag): New global variables.
879 (x_selection_request_lisp_error): Free the above.
880 (x_get_local_selection): Remove unnecessary code.
881 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
882 of converted selections stored in converted_selections.
883 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
884 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
885 (x_convert_selection): New function.
886 (x_handle_selection_event): Simplify.
887 (x_get_foreign_selection): Don't ignore incoming requests while
888 waiting for an answer; this will fail when we implement
889 SAVE_TARGETS, and seems unnecessary anyway.
890 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
891 (Vx_sent_selection_functions): Doc fix.
892
0f4aebc0
LL
8932011-05-26 Leo Liu <sdl.web@gmail.com>
894
895 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
896
e61124cd
YM
8972011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
898
899 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
900
901 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
902 for fringe update if it has periodic bitmap.
903 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
904 and fringe_bitmap_periodic_p.
905
906 * fringe.c (get_fringe_bitmap_data): New function.
907 (draw_fringe_bitmap_1, update_window_fringes): Use it.
908 (update_window_fringes): Record periodicity of fringe bitmap in glyph
909 row. Mark glyph row for fringe update if periodicity changed.
910
911 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
912 for fringe update unless it has periodic bitmap.
913
f16d9837
KH
9142011-05-25 Kenichi Handa <handa@m17n.org>
915
916 * xdisp.c (get_next_display_element): Set correct it->face_id for
917 a static composition.
918
e1b90ef6
LL
9192011-05-24 Leo Liu <sdl.web@gmail.com>
920
921 * deps.mk (fns.o):
922 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
923
924 * fns.c (crypto_hash_function, Fsha1): New function.
925 (Fmd5): Use crypto_hash_function.
926 (syms_of_fns): Add Ssha1.
927
7400048f
PE
9282011-05-22 Paul Eggert <eggert@cs.ucla.edu>
929
930 * gnutls.c: Remove unused macros.
931 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
932 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
933 Remove macros that are defined and never used.
934 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
935
abb71cf4
CY
9362011-05-22 Chong Yidong <cyd@stupidchicken.com>
937
938 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
939 (Fx_get_selection_internal): Minor cleanup.
940 (Fx_own_selection_internal): Rename arguments for consistency with
941 select.el.
942
6307db39
PE
9432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
944
945 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
946
f3d4e0a4
CY
9472011-05-22 Chong Yidong <cyd@stupidchicken.com>
948
949 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
950
4d8ade89
YM
9512011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
952
953 * dispnew.c (scrolling_window): Don't exclude the case that the
954 last enabled row in the desired matrix touches the bottom boundary.
955
32078c8d
GM
9562011-05-21 Glenn Morris <rgm@gnu.org>
957
958 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
959 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
960 and add some more files.
32078c8d 961
7285dc67
EZ
9622011-05-20 Eli Zaretskii <eliz@gnu.org>
963
964 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
965 report_file_error introduced by the change from 2011-05-07.
966
89d1bd22
PE
9672011-05-20 Paul Eggert <eggert@cs.ucla.edu>
968
969 * systime.h (Time): Define only if emacs is defined.
970 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
971 where the include path doesn't have X11/X.h by default. See
972 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
973
e23640bb 9742011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
975
976 * composite.c (find_automatic_composition): Fix previous change.
977
b9704ad9
GM
9782011-05-20 Glenn Morris <rgm@gnu.org>
979
980 * lisp.mk: New file, split from Makefile.in.
981 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
982 (shortlisp): Remove.
983 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
984
4a720484
GM
9852011-05-19 Glenn Morris <rgm@gnu.org>
986
987 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
988 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
989 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
990 (lisp): Set the order to that of loadup.el.
991 (shortlisp): Make it a copy of $lisp.
992 (SOME_MACHINE_LISP): Remove.
993 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
994 Use just $shortlisp, not $SOME_MACHINE_LISP too.
995
a28d4396
KH
9962011-05-18 Kenichi Handa <handa@m17n.org>
997
998 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
999 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1000 (find_automatic_composition): Mostly rewrite for efficiency.
1001
a2b1fa8e
JB
10022011-05-18 Juanma Barranquero <lekktu@gmail.com>
1003
1004 * makefile.w32-in: Update dependencies.
1005
8e1f5610
CS
10062011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1007
1008 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1009 revision 104625).
1010
7025ee00 10112011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1012
cdfa6eab
PE
1013 Fix some integer overflow issues, such as string length overflow.
1014
06d6db33
PE
1015 * insdel.c (count_size_as_multibyte): Check for string overflow.
1016
2b4560a8
PE
1017 * character.c (lisp_string_width): Check for string overflow.
1018 Use EMACS_INT, not int, for string indexes and lengths; in
1019 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1020 the resulting string length overflows an EMACS_INT; instead,
1021 report a string overflow if no precision given. When checking for
1022 precision exhaustion, use a check that cannot possibly have
1023 integer overflow. (Bug#8675)
1024 * character.h (lisp_string_width): Adjust to new signature.
1025
cb93f9be
PE
1026 * alloc.c (string_overflow): New function.
1027 (Fmake_string): Use it. This doesn't change behavior, but saves
1028 a few bytes and will simplify future changes.
1029 * character.c (string_escape_byte8): Likewise.
1030 * lisp.h (string_overflow): New decl.
1031
1a1f3366
PE
1032 Fixups, following up to the user-interface timestamp change.
1033 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1034 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1035 * msdos.c (mouse_get_pos): Likewise.
1036 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1037 * w32gui.h (Time): Define by including "systime.h" rather than by
1038 declaring it ourselves. (Bug#8664)
1039
d4e3e4d3
PE
1040 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1041 * image.c (clear_image_cache): Likewise.
1042
f6a24d19
PE
1043 * term.c (term_mouse_position): Don't assume time_t wraparound.
1044
08dc5ae6
PE
1045 Be more systematic about user-interface timestamps.
1046 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1047 and sometimes 'EMACS_UINT', to represent these timestamps.
1048 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1049 This makes the code easier to follow, and makes it easier to catch
1050 integer overflow bugs such as Bug#8664.
1051 * frame.c (Fmouse_position, Fmouse_pixel_position):
1052 Use Time, not unsigned long, for user-interface timestamps.
1053 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1054 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1055 * keyboard.h (last_event_timestamp): Likewise.
1056 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1057 * menu.h (xmenu_show): Likewise.
1058 * term.c (term_mouse_position): Likewise.
1059 * termhooks.h (struct input_event.timestamp): Likewise.
1060 (struct terminal.mouse_position_hook): Likewise.
1061 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1062 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1063 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1064 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1065 what it was before.
1066 * menu.h, termhooks.h: Include "systime.h", for Time.
1067
8e55734a
PE
1068 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1069 Don't assume that the difference between two unsigned long values
1070 can fit into an integer. At this point, we know button_down_time
1071 <= event->timestamp, so the difference must be nonnegative, so
1072 there's no need to cast the result if double-click-time is
1073 nonnegative, as it should be; check that it's nonnegative, just in
1074 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1075 apart (about 25 days). (Bug#8664)
8e55734a 1076
841f1b75 1077 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1078 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1079
3e26f69c
PE
1080 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1081 that always fit in int. Use a sentinel instead of a counter, to
1082 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1083 * frame.h (struct frame): Use int for menu_bar_items_used
1084 instead of EMACS_INT, since it always fits in int.
3e26f69c 1085
5cc152c0
PE
1086 * menu.c (grow_menu_items): Check for int overflow.
1087
d89eb65e
PE
1088 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1089
5235bd3e
PE
1090 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1091 Before, the code was not consistent. These values cannot exceed
1092 2**31 - 1 so there's no need to make them unsigned.
1093 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1094 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1095 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1096 as modifiers.
1097 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1098
bc827e23
PE
1099 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1100 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1101 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1102 presumably because the widths might not match.
1103
78eb494e
PE
1104 * window.c (size_window): Avoid needless test at loop start.
1105
04f2d78b
CB
11062011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1107
1108 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1109
d2fc7e3d 11102011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1111
1112 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1113
d2fc7e3d 11142011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1115
1116 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1117 `width' to `bar_area_x' and `bar_area_width', respectively.
1118 (x_scroll_run): Take account of fringe background extension.
1119
04f2d78b
CB
1120 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1121 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1122 `bar_area_width', respectively.
1123 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1124 background extension.
1125
79b70037
GM
11262011-05-10 Jim Meyering <meyering@redhat.com>
1127
1128 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1129
2f142cc5
JB
11302011-05-10 Juanma Barranquero <lekktu@gmail.com>
1131
1132 * image.c (Finit_image_library): Return t for built-in image types,
1133 like pbm and xbm. (Bug#8640)
1134
57679c86
AS
11352011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1136
1137 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1138
888c9e86
EZ
11392011-05-07 Eli Zaretskii <eliz@gnu.org>
1140
b0512a1d
EZ
1141 * w32console.c (Fset_screen_color): Doc fix.
1142 (Fget_screen_color): New function.
1143 (syms_of_ntterm): Defsubr it.
1144
7285dc67
EZ
1145 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1146 unlink the temporary file if Fcall_process didn't create it in the
1147 first place.
1148 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1149 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1150 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1151 cue to call_process_cleanup not to close that handle.
1152
4d3fcc8e
BK
11532011-05-07 Ben Key <bkey76@gmail.com>
1154
1155 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1156 one of two shell specific rules, either bootstrap-temacs-CMD or
1157 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1158 to the previous implementation of the bootstrap-temacs rule.
1159 The bootstrap-temacs-CMD rule is similar to the previous
1160 implementation of the bootstrap-temacs rule except that it
1161 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1162 variable.
1163
1164 These changes, along with some changes to nt/configure.bat,
1165 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1166 earlier fix to add support for --cflags and --ldflags options
1167 that include quotes so that it works whether make uses cmd or
1168 sh as the shell.
1169
b4289b64
MA
11702011-05-06 Michael Albinus <michael.albinus@gmx.de>
1171
1172 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1173 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1174 is a constant.
1175 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1176 a string. Handle both cases.
1177 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1178 (Fdbus_register_method): Use Qinvalid_function.
1179
af4c0e28
JB
11802011-05-06 Juanma Barranquero <lekktu@gmail.com>
1181
1182 * makefile.w32-in: Update dependencies.
1183 (LISP_H): Add inttypes.h and stdin.h.
1184 (PROCESS_H): Add unistd.h.
1185
c51453d9
EZ
11862011-05-06 Eli Zaretskii <eliz@gnu.org>
1187
1188 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1189 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1190
8ff0ac3c 11912011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1192
4c4b566b
PE
1193 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1194
aab2b9b5
PE
1195 * term.c (vfatal): Remove stray call to va_end.
1196 It's not needed and the C Standard doesn't allow it here anyway.
1197
c378da0b
PE
1198 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1199 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1200
288b08c7
PE
1201 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1202 bytes.
1203
e3601888
PE
1204 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1205
db6c0e74
PE
1206 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1207
dd5963ea
PE
1208 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1209
88c9450f
PE
1210 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1211
2f9442b8
PE
1212 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1213
c032b5f8
PE
1214 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1215 * charset.c (Fdefine_charset_internal): Don't initialize
1216 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1217 32-bit int (Bug#8600).
a108c10b
PE
1218
1219 * lread.c (read_integer): Be more consistent with string-to-number.
1220 Use string_to_number to do the actual conversion; this avoids
1221 rounding errors and fixes some other screwups. Without this fix,
1222 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1223 (digit_to_number): Move earlier, for benefit of read_integer.
1224 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1225 not a digit in any supported base. (Bug#8602)
a108c10b 1226
ad5f9eea
PE
1227 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1228
aec1708a
PE
1229 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1230 to match comment at start of function. This also removes a
1231 GCC warning about overflow in a 32+64-bit port.
1232
47be4ab5
PE
1233 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1234
371cac43
PE
1235 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1236 Reported by Stefan Monnier in
1237 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1238 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1239 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1240
d01a7826
PE
1241 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1242 (EMACS_UINTPTR): Likewise, with uintptr_t.
1243
7fd47d5c
PE
1244 * lisp.h: Prefer 64-bit EMACS_INT if available.
1245 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1246 on 32-bit hosts that have 64-bit int, so that they can access
1247 large files.
122b0c86
PE
1248 However, temporarily disable this change unless the temporary
1249 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1250
8727937b
PE
1251 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1252
8ac068ac
PE
1253 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1254 This removes an assumption that EMACS_INT and long are the same
1255 width as pointers. The assumption is true for Emacs porting targets
1256 now, but we want to make other targets possible.
1257 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1258 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1259 In the rest of the code, change types of integers that hold casted
1260 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1261 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1262 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1263 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1264 No need to cast type when ORing.
1265 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1266 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1267 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1268 assume EMACS_INT is the same width as char *.
1269 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1270 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1271 Remove no-longer-needed casts.
1272 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1273 (xg_tool_bar_help_callback, xg_make_tool_item):
1274 Use EMACS_INTPTR to hold an integer
1275 that will be cast to void *; this can avoid a GCC warning
1276 if EMACS_INT is not the same width as void *.
1277 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1278 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1279 (current_message_1, set_message_1):
1280 Use a local to convert to proper width without a cast.
1281 * xmenu.c (dialog_selection_callback): Likewise.
1282
ede49d71
PE
1283 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1284 Also, don't assume VALBITS / RAND_BITS is less than 5,
1285 and don't rely on undefined behavior when shifting a 1 left into
1286 the sign bit.
1287 * lisp.h (get_random): Change signature to match.
1288
2f30ecd0
PE
1289 * lread.c (hash_string): Use size_t, not int, for hash computation.
1290 Normally we prefer signed values; but hashing is special, because
1291 it's better to use unsigned division on hash table sizes so that
1292 the remainder is nonnegative. Also, size_t is the natural width
1293 for hashing into memory. The previous code used 'int', which doesn't
1294 retain enough info to hash well into very large tables.
1295 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1296
2a866e7b
PE
1297 * dbusbind.c: Don't possibly lose pointer info when converting.
1298 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1299 Use XPNTR rather than XHASH, so that the high-order bits of
1300 the pointer aren't lost when converting through void *.
1301
51639eac
PE
1302 * eval.c (Fautoload): Don't double-shift a pointer.
1303
92394119
PE
1304 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1305
dbdb9a7c
JB
13062011-05-06 Juanma Barranquero <lekktu@gmail.com>
1307
1308 * gnutls.c (DEF_GNUTLS_FN):
1309 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1310
db7a0b4f
AS
13112011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1312
1313 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1314 marker. (Bug#8610)
1315
f7ff1b0f 13162011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1317
1318 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1319 New version that can reserve upto 2GB of heap space.
1320
f7ff1b0f 13212011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1322
1323 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1324
639c109b
TZ
13252011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1326
1327 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1328 `gnutls_certificate_set_x509_key_file'.
1329
d2127135
JB
13302011-05-05 Juanma Barranquero <lekktu@gmail.com>
1331
1332 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1333 Update dependencies.
1334
e968f4f3
JB
13352011-05-04 Juanma Barranquero <lekktu@gmail.com>
1336
1337 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1338 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1339 Remove unused parameter `fildes'.
1340 * process.c (read_process_output, send_process): Don't pass it.
1341
84d358f0
JB
13422011-05-04 Juanma Barranquero <lekktu@gmail.com>
1343
1344 Fix previous change: the library cache is defined in w32.c.
1345 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1346 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1347
0898ca10
JB
13482011-05-04 Juanma Barranquero <lekktu@gmail.com>
1349
1350 Implement dynamic loading of GnuTLS on Windows.
1351
1352 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1353 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1354 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1355 Declare.
1356
1357 * gnutls.c (Qgnutls_dll): Define.
1358 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1359 (gnutls_*): Declare function pointers.
1360 (init_gnutls_functions): New function to initialize function pointers.
1361 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1362 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1363 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1364 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1365 (emacs_gnutls_write, emacs_gnutls_read)
1366 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1367 (Fgnutls_available_p): New function.
1368 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1369 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1370 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1371
1372 * image.c: Include w32.h.
1373 (Vimage_type_cache): Delete.
1374 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1375 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1376 (w32_delayed_load): Move to w32.c.
1377
1378 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1379
1380 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1381 (w32_delayed_load): Move from image.c. When loading a library, record
1382 its filename in the :loaded-from property of the library id.
1383 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1384 Initialize and staticpro them.
1385 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1386
1387 * process.c: Include lisp.h before w32.h, not after.
1388 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1389 instead of gnutls_record_check_pending.
1390
1391 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1392
ff4de4aa
TZ
13932011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1394
1395 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1396 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1397 as passed in.
1398
abe95abb
JD
13992011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1400
1401 * xterm.c (x_set_frame_alpha): Do not set property on anything
1402 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1403
e16e55d4
JB
14042011-05-02 Juanma Barranquero <lekktu@gmail.com>
1405
1406 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1407
bafcf6a5
JB
14082011-05-02 Juanma Barranquero <lekktu@gmail.com>
1409
1410 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1411 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1412 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1413 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1414 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1415 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1416 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1417 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1418 (Qgnutls_bootprop_callbacks_verify): Make static.
1419
e7a6747f
AS
14202011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1421
19ed11ba
AS
1422 * callproc.c: Indentation fixup.
1423
e7a6747f 1424 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1425 (wait_for_termination, interruptible_wait_for_termination):
1426 Move after wait_for_termination_1.
e7a6747f 1427
1ef14cb4
LMI
14282011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1429
1430 * sysdep.c (interruptible_wait_for_termination): New function
1431 which is like wait_for_termination, but allows keyboard
1432 interruptions.
1433
1434 * callproc.c (Fcall_process): Add (:file "file") as an option for
1435 the STDOUT buffer.
1436 (Fcall_process_region): Ditto.
1437
330d880c
EZ
14382011-04-30 Eli Zaretskii <eliz@gnu.org>
1439
8db90b73
EZ
1440 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1441 rather than `XVECTOR (FOO)->size'.
1442
330d880c
EZ
1443 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1444 inttypes.h, as a gnulib replacement is used if it not available in
1445 system headers.
1446
15cbd324
EZ
14472011-04-21 Eli Zaretskii <eliz@gnu.org>
1448
1449 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1450 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1451 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1452
1453 * coding.c (coding_alloc_by_realloc): Error out if destination
1454 will grow beyond MOST_POSITIVE_FIXNUM.
1455 (decode_coding_emacs_mule): Abort if there isn't enough place in
1456 charbuf for the composition carryover bytes. Reserve an extra
1457 space for up to 2 characters produced in a loop.
1458 (decode_coding_iso_2022): Abort if there isn't enough place in
1459 charbuf for the composition carryover bytes.
1460
14612011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1462
ae940cca
EZ
1463 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1464 aborting when %lld or %lll format is passed.
1465 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1466 %llo or %llx format is passed. (Bug#8545)
1467
03ab8921
EZ
1468 * window.c (window_scroll_line_based): Use a marker instead of
1469 simple variables to record original value of point. (Bug#7952)
1470
afda1437
EZ
1471 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1472 produced by %s or %c overflows available buffer space. (Bug#8545)
1473
f76dee0c
PE
14742011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1475
1476 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1477 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1478
fdc5744d
JB
14792011-04-28 Juanma Barranquero <lekktu@gmail.com>
1480
1481 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1482
638f053a
JB
14832011-04-28 Juanma Barranquero <lekktu@gmail.com>
1484
1485 * keyboard.c (Qdelayed_warnings_hook): Define.
1486 (command_loop_1): Run `delayed-warnings-hook'
1487 if Vdelayed_warnings_list is non-nil.
1488 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1489 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1490
d178f871
EZ
14912011-04-28 Eli Zaretskii <eliz@gnu.org>
1492
1493 * doprnt.c (doprnt): Don't return value smaller than the buffer
1494 size if the message was truncated. (Bug#8545).
1495
b124fd93
JB
14962011-04-28 Juanma Barranquero <lekktu@gmail.com>
1497
1498 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1499 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1500
e810457d
PE
15012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1502
1503 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1504
ea51cceb
JB
15052011-04-27 Juanma Barranquero <lekktu@gmail.com>
1506
1507 * makefile.w32-in: Update dependencies.
1508
94dcfacf
EZ
15092011-04-27 Eli Zaretskii <eliz@gnu.org>
1510
1511 Improve `doprnt' and its usage. (Bug#8545)
1512 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1513 `format_end'. Remove support for %l as a conversion specifier.
1514 Don't use xrealloc. Improve diagnostics when the %l size modifier
1515 is used. Update the commentary.
1516
1517 * eval.c (verror): Simplify calculation of size_t.
1518
1519 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1520 messages.
1521
f61f41d7
PE
15222011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1523
1524 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1525 change.
1526
96fb4434
PE
15272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1528
1529 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1530 This makes this file independent of the recent pseudovector change.
1531
671875da 15322011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1533
69e9b5a3
PE
1534 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1535
b5f869a7 1536 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1537 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1538 Remove unused local.
c8926152 1539 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1540
841a1577 1541 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1542 GCC 4.6.0 optimizes based on type-based alias analysis.
1543 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1544 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1545 != &v->size, and therefore "v->size = 1; b->size = 2; return
1546 v->size;" must therefore return 1. This assumption is incorrect
1547 for Emacs, since it type-puns struct Lisp_Vector * with many other
1548 types. To fix this problem, this patch adds a new type struct
f904488f 1549 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1550 and pseudovectors, and helps optimizing compilers not get fooled
1551 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1552 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1553 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1554 the size member.
eab3844f
PE
1555 (XSETPVECTYPE): Rewrite in terms of new macro.
1556 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1557 This is a bit clearer, and further avoids the possibility of
1558 undesirable aliasing.
1559 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1560 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1561 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1562 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1563 (ASIZE): Now uses header.size rather than size.
1564 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1565 to avoid the hassle of writing XVECTOR (foo)->header.size.
1566 (struct vectorlike_header): New type.
eab3844f
PE
1567 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1568 object, to help avoid aliasing.
1569 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1570 (SUBRP): Likewise, since Lisp_Subr is a special case.
1571 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1572 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1573 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1574 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1575 changed to be "header.size" and "header.next".
1576 * buffer.h (struct buffer): Likewise.
1577 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1578 * frame.h (struct frame): Likewise.
1579 * process.h (struct Lisp_Process): Likewise.
1580 * termhooks.h (struct terminal): Likewise.
1581 * window.c (struct save_window_data, struct saved_window): Likewise.
1582 * window.h (struct window): Likewise.
1583 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1584 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1585 * buffer.c (init_buffer_once): Likewise.
1586 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1587 special case.
1588 * process.c (Fformat_network_address): Use local var for size,
1589 for brevity.
1590
0df1eac5
PE
1591 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1592
847ab9d1 1593 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1594 * data.c (atof): Remove decl; no longer used or needed.
1595 (digit_to_number): Move to lread.c.
1596 (Fstring_to_number): Use new string_to_number function, to be
1597 consistent with how the Lisp reader treats infinities and NaNs.
1598 Do not assume that floating-point numbers represent EMACS_INT
1599 without losing information; this is not true on most 64-bit hosts.
1600 Avoid double-rounding errors, by insisting on integers when
1601 parsing non-base-10 numbers, as the documentation specifies.
1602 * lisp.h (string_to_number): New decl, replacing ...
1603 (isfloat_string): Remove.
bc0a5c13 1604 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1605 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1606 appears to have been a coding error. Similarly, do not accept
1607 strings like +-1e0 as floating point numbers. Do not report
1608 overflow for integer overflows unless the base is not 10 which
1609 means we have no simple and reliable way to continue.
1610 Break out the floating-point parsing into a new
1611 function string_to_number, so that Fstring_to_number parses
1612 floating point numbers consistently with the Lisp reader.
04f2d78b 1613 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1614 (E_CHAR, EXP_INT): Remove, replacing with ...
1615 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1616 (string_to_number): New function, replacing isfloat_string.
1617 This function checks for valid syntax and produces the resulting
1618 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1619 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1620 so that overflow for non-base-10 numbers is reported only when
1621 there's no portable and simple way to convert to floating point.
452f4150 1622
67769ffc
PE
1623 * textprop.c (set_text_properties_1): Rewrite for clarity,
1624 and to avoid GCC warning about integer overflow.
1625
c20db43f
PE
1626 * intervals.h (struct interval): Use EMACS_INT for members
1627 where EMACS_UINT might cause problems. See
1628 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1629 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1630 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1631 All uses changed.
37aa2f85
PE
1632 (offset_intervals): Tell GCC not to worry about length overflow
1633 when negating a negative length.
c20db43f 1634
2538aa2f
PE
1635 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1636 (overrun_check_free): Likewise.
1637
f2d3008d
PE
1638 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1639 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1640 word size.
1641
ec8df744
PE
1642 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1643 (gnutls_make_error): Rename local to avoid shadowing.
1644 (gnutls_emacs_global_deinit): ifdef out; not used.
1645 (Fgnutls_boot): Use const for pointer to readonly storage.
1646 Comment out unused local. Fix pointer signedness problems.
1647
640ee02d
PE
1648 * lread.c (openp): Don't stuff size_t into an 'int'.
1649 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1650 about possible signed overflow.
1651
6048fb2a
PE
1652 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1653 (GDK_KEY_g): Don't define if already defined.
1654 (xg_prepare_tooltip): Avoid pointer signedness problem.
1655 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1656
fa3c87e1
PE
1657 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1658 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1659
2172544b
PE
1660 * xfns.c (Fx_window_property): Simplify a bit,
1661 to make a bit faster and to avoid GCC 4.6.0 warning.
1662 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1663
9b821a21
PE
1664 * fns.c (internal_equal): Don't assume size_t fits in int.
1665
3c616cfa
PE
1666 * alloc.c (compact_small_strings): Tighten assertion a little.
1667
c2982e87
PE
1668 Replace pEd with more-general pI, and fix some printf arg casts.
1669 * lisp.h (pI): New macro, generalizing old pEd macro to other
1670 conversion specifiers. For example, use "...%"pI"d..." rather
1671 than "...%"pEd"...".
1672 (pEd): Remove. All uses replaced with similar uses of pI.
1673 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1674 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1675 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1676 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1677 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1678 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1679 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1680 64-bit hosts.
1681 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1682 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1683 * print.c (safe_debug_print, print_object): Likewise.
1684 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1685 to int.
6f04d126
PE
1686 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1687 avoiding the 0 flag, which is not portable.
c2982e87
PE
1688 * process.c (Fmake_network_process): Use pI to avoid cast.
1689 * region-cache.c (pp_cache): Likewise.
1690 * xdisp.c (decode_mode_spec): Likewise.
1691 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1692 behavior on 64-bit hosts with printf arg.
6f04d126 1693 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1694 (x_stop_queuing_selection_requests): Likewise.
1695 (x_get_window_property): Don't truncate byte count to an 'int'
1696 when tracing.
0b432f21 1697
5e073ec7
PE
1698 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1699 here, since it parses constructs like leading '-' and spaces,
1700 which are not wanted; and it overflows with large numbers.
1701 Instead, simply match F[0-9]+, which is what is wanted anyway.
1702
36372bf9
PE
1703 * alloc.c: Remove unportable assumptions about struct layout.
1704 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1705 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1706 (allocate_vectorlike, make_pure_vector): Use the new macros,
1707 plus offsetof, to remove unportable assumptions about struct layout.
1708 These assumptions hold on all porting targets that I know of, but
1709 they are not guaranteed, they're easy to remove, and removing them
1710 makes further changes easier.
1711
0b432f21
PE
1712 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1713 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1714 (string_overrun_cookie): Now const. Use initializers that
1715 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1716 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1717 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1718 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1719 multiple of sizeof (EMACS_INT); it need not be, if
1720 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1721 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1722
895009e1
JB
17232011-04-26 Juanma Barranquero <lekktu@gmail.com>
1724
1725 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1726
6a7a1b0b
TZ
17272011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1728
1729 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1730 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1731 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1732
841a1577 17332011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1734
1735 * lisp.h (Qdebug): List symbol.
895009e1 1736 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1737 * keyboard.c (debug-on-event): New variable.
1738 (handle_user_signal): Break into debugger when debug-on-event
1739 matches the current signal symbol.
1740
f2d3ba6f
DN
17412011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1742
1743 * alloc.c (check_sblock, check_string_bytes)
1744 (check_string_free_list): Convert to standard C.
1745
42ce4c63
TZ
17462011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1747
1748 * w32.c (emacs_gnutls_push): Fix typo.
1749
825cd63c
EZ
17502011-04-25 Eli Zaretskii <eliz@gnu.org>
1751
fb11d64d
EZ
1752 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1753 "cast to pointer from integer of different size".
1754
825cd63c
EZ
1755 Improve doprnt and its use in verror. (Bug#8545)
1756 * doprnt.c (doprnt): Document the set of format control sequences
1757 supported by the function. Use SAFE_ALLOCA instead of always
1758 using `alloca'.
1759
1760 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1761 is one byte too soon. Don't use xrealloc; instead xfree and
1762 xmalloc anew.
1763
e061a11b
TZ
17642011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1765
1766 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1767 callbacks stage.
1768
1769 * gnutls.c: Renamed global_initialized to
1770 gnutls_global_initialized. Added internals for the
1771 :verify-hostname-error, :verify-error, and :verify-flags
1772 parameters of `gnutls-boot' and documented those parameters in the
1773 docstring. Start callback support.
1774 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1775 unless a fatal error occured. Call gnutls_alert_send_appropriate
1776 on error. Return error code.
1777 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1778 (emacs_gnutls_read): Likewise.
1779 (Fgnutls_boot): Return handshake error code.
1780 (emacs_gnutls_handle_error): New function.
1781 (wsaerror_to_errno): Likewise.
1782
1783 * w32.h (emacs_gnutls_pull): Add prototype.
1784 (emacs_gnutls_push): Likewise.
1785
1786 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1787 (emacs_gnutls_push): Likewise.
1788
17892011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1790
1791 * process.c (wait_reading_process_output): Check if GnuTLS
1792 buffered some data internally if no FDs are set for TLS
1793 connections.
1794
1795 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1796 (LIBS): Link to USER_LIBS.
1797 ($(BLD)/gnutls.$(0)): New target.
1798
fa6996bc
EZ
17992011-04-24 Eli Zaretskii <eliz@gnu.org>
1800
eb35682e
EZ
1801 * xdisp.c (handle_single_display_spec): Rename the
1802 display_replaced_before_p argument into display_replaced_p, to
1803 make it consistent with the commentary. Fix typos in the
1804 commentary.
1805
e2ad650c
EZ
1806 * textprop.c (syms_of_textprop): Remove dead code.
1807 (copy_text_properties): Delete obsolete commentary about an
1808 interface that was deleted long ago. Fix typos in the description
1809 of arguments.
1810
1b2de274
EZ
1811 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1812 to changes in oldXMenu/XMenu.h from 2011-04-16.
1813 <menu_help_message, prev_menu_help_message>: Constify.
1814 (IT_menu_make_room): menu->help_text is now `const char **';
1815 adjust.
1816
1817 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1818 to changes in oldXMenu/XMenu.h from 2011-04-16.
1819 (struct XMenu): Declare `help_text' `const char **'.
1820
1821 * xfaces.c <Qunspecified>: Make extern again.
1822
1823 * syntax.c: Include sys/types.h before including regex.h, as
1824 required by Posix.
1825
762b15be
EZ
1826 * doc.c (get_doc_string): Improve the format passed to `error'.
1827
1828 * doprnt.c (doprnt): Improve commentary.
1829
1830 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1831
1832 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1833 them with etags.
1834
f1052e5d
EZ
1835 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1836 changes in globals.h immediately force recompilation.
762b15be
EZ
1837 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1838 $(CURDIR)/s/ms-w32.h.
1839 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1840
fa6996bc
EZ
1841 * character.c (Fchar_direction): Function deleted.
1842 (syms_of_character): Don't defsubr it.
1843 <char-direction-table>: Deleted.
1844
e6c3da20
EZ
18452011-04-23 Eli Zaretskii <eliz@gnu.org>
1846
1847 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1848 * doprnt.c: Include limits.h.
1849 (SIZE_MAX): New macro.
04f2d78b
CB
1850 (doprnt): Return a size_t value. 2nd arg is now size_t.
1851 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1852 Improve overflow protection. Support `l' modifier for integer
1853 conversions. Support %l conversion. Don't assume an EMACS_INT
1854 argument for integer conversions and for %c.
1855
1856 * lisp.h (doprnt): Restore prototype.
1857
1858 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1859 $(SRC)/character.h.
1860
1861 * Makefile.in (base_obj): Add back doprnt.o.
1862
1863 * deps.mk (doprnt.o): Add back prerequisites.
1864 (callint.o): Depend on character.h.
1865
1866 * eval.c (internal_lisp_condition_case): Include the handler
1867 representation in the error message.
1868 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1869 when breaking from the loop.
1870
1871 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1872
1873 * callint.c (Fcall_interactively): When displaying error message
1874 about invalid control letter, pass the character's codepoint, not
1875 a pointer to its multibyte form. Improve display of the character
1876 in octal and display also its hex code.
1877
1878 * character.c (char_string): Use %x to display the (unsigned)
1879 codepoint of an invalid character, to avoid displaying a bogus
1880 negative value.
1881
1882 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1883 `error', not SYMBOL_NAME itself.
1884
1885 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1886 character arguments to `error'.
1887
1888 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1889 to `error' in error message about FINAL_CHAR argument. Make sure
1890 FINAL_CHAR is a character, and use %c when it is passed as
1891 argument to `error'.
1892
4ffd0d6b 18932011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1894
1895 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1896
1897 * w32.c: Include <time.h>.
1898 (sys_localtime): New function.
1899
4ffd0d6b 19002011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1901
1902 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1903
4ffd0d6b 1904 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1905
4ffd0d6b 19062011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1907
4ffd0d6b
GM
1908 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1909 zombies (Bug#8467).
aac0c6e3 1910
04c56954
EZ
19112011-04-19 Eli Zaretskii <eliz@gnu.org>
1912
1913 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1914 gl_state.e_property when gl_state.object is Qt.
1915
1916 * insdel.c (make_gap_larger): Remove limitation of buffer size
1917 to <= INT_MAX.
1918
16a43933
CY
19192011-04-18 Chong Yidong <cyd@stupidchicken.com>
1920
1921 * xdisp.c (lookup_glyphless_char_display)
1922 (produce_glyphless_glyph): Handle cons cell entry in
1923 glyphless-char-display.
1924 (Vglyphless_char_display): Document it.
1925
1926 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1927 glyphless-char-display.
1928
4581706e
CY
19292011-04-17 Chong Yidong <cyd@stupidchicken.com>
1930
1931 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1932
1933 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1934
1935 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1936 definition for no-X builds.
1937
4887c6e2 19382011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1939
fd35b6f9
PE
1940 Static checks with GCC 4.6.0 and non-default toolkits.
1941
5c1ccb01
PE
1942 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1943
006c5daa
PE
1944 * process.c (keyboard_bit_set): Define only if SIGIO.
1945 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1946 (send_process): Repair possible setjmp clobbering.
1947
efc736d3
PE
1948 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1949
4e2fe2e6
PE
1950 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1951
f97334a2
PE
1952 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1953
4e75f29d
PE
1954 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1955 Define only if needed.
1956
90efadd1
PE
1957 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1958 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1959 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1960
3c647824
PE
1961 * dispextern.h (struct redisplay_interface): Rename param
1962 to avoid shadowing.
e264f262 1963 * termhooks.h (struct terminal): Likewise.
761383f4 1964 * xterm.c (xembed_send_message): Likewise.
3c647824 1965
b58c5c4a
PE
1966 * insdel.c (make_gap_smaller): Define only if
1967 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1968
cad59032
PE
1969 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1970 it.
1971
c339dc2e
PE
1972 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1973 so that we aren't warned about unused symbols.
1974
91a3e27b
PE
1975 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1976
399c71d3 1977 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1978
8ffc96f5
PE
1979 * xfns.c (x_real_positions): Mark locals as initialized.
1980
eef9bc79
PE
1981 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1982
098db9dd
PE
1983 * xterm.c: Fix problems found by static analysis with other toolkits.
1984 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1985 (x_dispatch_event): Declare static if USE_GTK, and
1986 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1987 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1988 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1989 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1990 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1991
eb18f6cc
PE
1992 * xmenu.c (menu_help_callback): Pointer type fixes.
1993 Use const pointers when pointing at readonly data. Avoid pointer
1994 signedness clashes.
1995 (FALSE): Remove unused macro.
1996 (update_frame_menubar): Remove unused decl.
1997
1fe72bf8
PE
1998 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1999
60d9e1db
PE
2000 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2001 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2002 (single_menu_item): Rename local to avoid shadowing.
2003
39261c26
PE
2004 * keyboard.c (make_lispy_event): Remove unused local var.
2005
018c5e19
PE
2006 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2007 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2008
63d2b86e
PE
2009 * bitmaps: Change bitmaps from unsigned char back to the X11
2010 compatible char. Avoid the old compiler warnings about
2011 out-of-range initializers by using, for example, '\xab' rather
2012 than 0xab.
2013
aefd87e1
PE
2014 * xgselect.c (xgselect_initialize): Check vs interface
2015 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2016
bf501fb9
PE
2017 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2018
e9829fdf
PE
2019 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2020 to read-only memory.
2021
1086c095
PE
2022 * fns.c (vector): Remove; this old hack is no longer needed.
2023
2baccd04 2024 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2025 Remove unused var.
dde42981 2026 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2027
72391843 2028 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2029
436c16df 2030 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2031 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2032 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2033
92bb796d 2034 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2035 (x_term_init): Remove local to avoid shadowing.
92bb796d 2036
764430a3 2037 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2038
2039 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2040 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2041
d1dfb56c
EZ
20422011-04-16 Eli Zaretskii <eliz@gnu.org>
2043
c4354cb4
EZ
2044 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2045
d1dfb56c
EZ
2046 Fix regex.c, syntax.c and friends for buffers > 2GB.
2047 * syntax.h (struct gl_state_s): Declare character position members
2048 EMACS_INT.
2049
2050 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2051
04f2d78b
CB
2052 * textprop.c (verify_interval_modification, interval_of):
2053 Declare arguments EMACS_INT.
d1dfb56c
EZ
2054
2055 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2056 EMACS_INT.
2057
2058 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2059
2060 * indent.c (Fvertical_motion): Local variable it_start is now
2061 EMACS_INT.
2062
2063 * regex.c (re_match, re_match_2, re_match_2_internal)
2064 (bcmp_translate, regcomp, regexec, print_double_string)
2065 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2066 (re_compile_pattern, re_exec): Declare arguments and local
2067 variables `size_t' and `ssize_t' and return values `regoff_t', as
2068 appropriate.
2069 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2070 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2071 <compile_stack_type>: `size' and `avail' are now `size_t'.
2072
2073 * regex.h <regoff_t>: Use ssize_t, not int.
2074 (re_search, re_search_2, re_match, re_match_2): Arguments that
2075 specify buffer/string position and length are now ssize_t and
2076 size_t. Return type is regoff_t.
2077
613052cd
BK
20782011-04-16 Ben Key <bkey76@gmail.com>
2079
2080 * nsfont.m: Fixed bugs in ns_get_family and
2081 ns_descriptor_to_entity that were caused by using free to
2082 deallocate memory blocks that were allocated by xmalloc (via
2083 xstrdup). This caused Emacs to crash when compiled with
2084 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2085 --enable-checking=xmallocoverrun). xfree is now used to
2086 deallocate these memory blocks.
2087
4170f62f 20882011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2089
71b41406
PE
2090 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2091
9587a89d
PE
2092 emacs_write: Accept and return EMACS_INT for sizes.
2093 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2094 et seq.
2095 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2096 Accept and return EMACS_INT.
2097 (emacs_gnutls_write): Return the number of bytes written on
2098 partial writes.
2099 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2100 (emacs_read, emacs_write): Remove check for negative size, as the
2101 Emacs source code has been audited now.
9587a89d
PE
2102 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2103 (emacs_read, emacs_write): Use it.
273a5f82
PE
2104 * process.c (send_process): Adjust to the new signatures of
2105 emacs_write and emacs_gnutls_write. Do not attempt to store
2106 a byte offset into an 'int'; it might overflow.
9587a89d 2107 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2108
3e047f51
PE
2109 * sound.c: Don't assume sizes fit in 'int'.
2110 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2111 Return EMACS_INT, not int.
3e047f51 2112 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2113 Accept EMACS_INT, not int.
2114 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2115 record read return values.
2116
cc39a9db
BK
21172011-04-15 Ben Key <bkey76@gmail.com>
2118
c9d0ec6d
JB
2119 * keyboard.c (Qundefined): Don't declare static since it is used
2120 in nsfns.m.
2121 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2122 static since they are used in nsfont.m.
cc39a9db 2123
6c60eb9f
SM
21242011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2125
2126 * process.c (Qprocessp): Don't declare static.
2127 * lisp.h (Qprocessp): Declare again.
2128
7990b61a
JB
21292011-04-15 Juanma Barranquero <lekktu@gmail.com>
2130
2131 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2132
5d4cb038
PE
21332011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2134
8bd7b830 2135 Improve C-level modularity by making more things 'static'.
cd64ea1d 2136
e3b27b31
PE
2137 Don't publish debugger-only interfaces to other modules.
2138 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2139 (verify_bytepos, count_markers): Move decls to the only modules
2140 that need them.
2141 * region-cache.h (pp_cache): Likewise.
2142 * window.h (check_all_windows): Likewise.
2143 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2144
5d4cb038
PE
2145 * sysdep.c (croak): Now static, if
2146 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2147 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2148
2149 * alloc.c (refill_memory_reserve): Now static if
2150 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2151 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2152
e87b6180
PE
2153 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2154 Define only if USE_LUCID.
2155
ac64929e
PE
2156 * xrdb.c (x_customization_string, x_rm_string): Now static.
2157
6f37259d
PE
2158 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2159 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2160
1683e3ab
PE
2161 * xdisp.c (draw_row_with_mouse_face): Now static.
2162 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2163
de9c2632
PE
2164 * window.h (check_all_windows): Mark externally visible.
2165
2b96acb7
PE
2166 * window.c (window_deletion_count): Now static.
2167
2168 * undo.c: Make symbols static if they're not exported.
2169 (last_undo_buffer, last_boundary_position, pending_boundary):
2170 Now static.
2171
50436f33
PE
2172 * textprop.c (interval_insert_behind_hooks): Now static.
2173 (interval_insert_in_front_hooks): Likewise.
2174
64520e5c
PE
2175 * term.c: Make symbols static if they're not exported.
2176 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2177 (max_frame_lines, tty_set_terminal_modes):
2178 (tty_reset_terminal_modes, tty_turn_off_highlight):
2179 (get_tty_terminal): Now static.
2180 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2181 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2182 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2183 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2184 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2185
1fa53021
PE
2186 * sysdep.c: Make symbols static if they're not exported.
2187 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2188 Now static.
2189 (sigprocmask_set, full_mask): Remove; unused.
2190 (wait_debugging): Mark as visible.
2191 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2192 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2193
d4b43b22
PE
2194 * syntax.c (syntax_temp): Define only if !__GNUC__.
2195
b7c513d0
PE
2196 * sound.c (current_sound_device, current_sound): Now static.
2197
989b29ad
PE
2198 * search.c (searchbufs, searchbuf_head): Now static.
2199
13a55a78
PE
2200 * scroll.c (scroll_cost): Remove; unused.
2201 * dispextern.h (scroll_cost): Remove decl.
2202
de68a1fc
PE
2203 * region-cache.h (pp_cache): Mark as externally visible.
2204
40ccffa6
PE
2205 * process.c: Make symbols static if they're not exported.
2206 (process_tick, update_tick, create_process, chan_process):
2207 (Vprocess_alist, proc_buffered_char, datagram_access):
2208 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2209 (deactivate_process): Mark defn as static, as well as decl.
2210 * lisp.h (create_process): Remove decl.
2211 * process.h (chan_process, Vprocess_alist): Remove decls.
2212
ad64fc97
PE
2213 * print.c: Make symbols static if they're not exported.
2214 (print_depth, new_backquote_output, being_printed, print_buffer):
2215 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2216 (print_interval, print_number_index, initial_stderr_stream):
2217 Now static.
2218 * lisp.h (Fprinc): Remove decl.
2219 (debug_output_compilation_hack): Mark as externally visible.
2220
adddb265
PE
2221 * sysdep.c (croak): Move decl from here to syssignal.h.
2222 * syssignal.h (croak): Put it here, so the API can be checked when
2223 'croak' is called from dissociate_if_controlling_tty.
2224
1717ede2
PE
2225 * minibuf.c: Make symbols static if they're not exported.
2226 (minibuf_save_list, choose_minibuf_frame): Now static.
2227 * lisp.h (choose_minibuf_frame): Remove decl.
2228
fa5fb2bc
PE
2229 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2230
1e3890d1
PE
2231 * lread.c: Make symbols static if they're not exported.
2232 (read_objects, initial_obarray, oblookup_last_bucket_number):
2233 Now static.
2234 (make_symbol): Remove; unused.
2235 * lisp.h (initial_obarray, make_symbol): Remove decls.
2236
8a1414fa
PE
2237 * keyboard.c: Make symbols static if they're not exported.
2238 (single_kboard, recent_keys_index, total_keys, recent_keys):
2239 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2240 (this_single_command_key_start, echoing, last_auto_save):
2241 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2242 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2243 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2244 (Vlispy_mouse_stem, double_click_count):
2245 Now static.
2246 (force_auto_save_soon): Define only if SIGDANGER.
2247 (ignore_mouse_drag_p): Now static if
2248 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2249 (print_help): Remove; unused.
2250 (stop_character, last_timer_event): Mark as externally visible.
2251 * keyboard.h (ignore_mouse_drag_p): Declare only if
2252 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2253 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2254 * lisp.h (echoing): Remove decl.
2255 (force_auto_save_soon): Declare only if SIGDANGER.
2256 * xdisp.c (redisplay_window): Simplify code, to make it more
2257 obvious that ignore_mouse_drag_p is not accessed if !defined
2258 USE_GTK && !defined HAVE_NS.
2259
93ea6e8f
PE
2260 * intervals.c: Make symbols static if they're not exported.
2261 (merge_properties_sticky, merge_interval_right, delete_interval):
2262 Now static.
2263 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2264
77382fcc
PE
2265 * insdel.c: Make symbols static if they're not exported.
2266 However, leave prepare_to_modify_buffer alone. It's never
2267 called from outside this function, but that appears to be a bug.
2268 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2269 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2270 (adjust_after_replace_noundo): Remove; unused.
2271 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2272 (signal_before_change): Remove decls.
77382fcc 2273
9306c32e
PE
2274 * indent.c (val_compute_motion, val_vmotion): Now static.
2275
cd44d2eb
PE
2276 * image.c: Make symbols static if they're not exported.
2277 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2278 if USE_GTK.
2279 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2280 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2281
ad9a7a06
PE
2282 * fringe.c (standard_bitmaps): Now static.
2283 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2284
81626931
PE
2285 * frame.c: Make symbols static if they're not exported.
2286 (x_report_frame_params, make_terminal_frame): Now static.
2287 (get_frame_param): Now static, unless HAVE_NS.
2288 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2289 (x_get_resource_string): Remove; not used.
2290 * frame.h (make_terminal_frame, x_report_frame_params):
2291 (x_get_resource_string); Remove decls.
2292 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2293 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2294
239f9db9
PE
2295 * font.c, fontset.c: Make symbols static if they're not exported.
2296 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2297 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2298 * font.c (font_close_object): Now static.
2299 * font.h (font_close_object): Remove.
2300 * fontset.c (FONTSET_OBJLIST): Remove.
2301 (free_realized_fontset) #if-0 the body, which does nothing.
2302 (face_suitable_for_char_p): #if-0, as it's never called.
2303 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2304 * xfaces.c (face_at_string_position):
2305 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2306 since 0 is always ASCII.
2307
dfcf3579
PE
2308 * fns.c (weak_hash_tables): Now static.
2309
5045092b
PE
2310 * fileio.c: Make symbols static if they're not exported.
2311 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2312 (Vwrite_region_annotation_buffers): Now static.
2313
57a96f5c
PE
2314 * eval.c: Make symbols static if they're not exported.
2315 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2316 * lisp.h (backtrace_list): Remove decl.
2317
35f08c38
PE
2318 * emacs.c: Make symbols static if they're not exported.
2319 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2320 (fatal_error_code, fatal_error_signal_hook, standard_args):
2321 Now static.
2322 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2323 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2324 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2325 * lisp.h (fatal_error_signal_hook): Remove decl.
2326 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2327
f44bd759
PE
2328 * editfns.c: Move a (normally-unused) function to its only use.
2329 * editfns.c, lisp.h (get_operating_system_release): Remove.
2330 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2331 worth the hassle of breaking this out.
2332
b532497d
PE
2333 * xterm.c: Make symbols static if they're not exported.
2334 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2335 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2336 (x_destroy_window, x_delete_display):
2337 Now static.
2338 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2339 (x_mouse_leave): Remove; unused.
2340 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2341 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2342 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2343 Remove decls.
2344 (x_mouse_leave): Declare only if WINDOWSNT.
2345 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2346 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2347 USE_X_TOOLKIT.
2348
1675728f
PE
2349 * ftxfont.c: Make symbols static if they're not exported.
2350 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2351 HAVE_FREETYPE.
2352 * font.h (ftxfont_driver): Likewise.
2353
e4cebfca
PE
2354 * xfns.c: Make symbols static if they're not exported.
2355 (x_last_font_name, x_display_info_for_name):
2356 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2357 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2358 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2359 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2360 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2361 (last_show_tip_args): Now static.
2362 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2363 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2364 (x_screen_planes): Remove; unused.
2365 * dispextern.h (x_screen_planes): Remove decl.
2366
5bf46f05
PE
2367 * dispnew.c: Make symbols static if they're not exported.
2368 * dispextern.h (redraw_garbaged_frames, scrolling):
2369 (increment_row_positions): Remove.
2370 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2371 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2372 Now static.
2373 (redraw_garbaged_frames): Remove; unused.
2374
435f4c28
PE
2375 * xfaces.c: Make symbols static if they're not exported.
2376 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2377 Remove decls.
2378 * xterm.h (defined_color): Remove decls.
2379 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2380 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2381 (menu_face_changed_default, defined_color, free_realized_face):
2382 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2383 (ascii_face_of_lisp_face): Remove; unused.
2384
8524aef3
PE
2385 * xdisp.c: Make symbols static if they're not exported.
2386 * dispextern.h (scratch_glyph_row, window_box_edges):
2387 (glyph_to_pixel_coords, set_cursor_from_row):
2388 (get_next_display_element, set_iterator_to_next):
2389 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2390 (show_mouse_face): Remove decls
2391 * frame.h (message_buf_print): Likewise.
2392 * lisp.h (pop_message, set_message, check_point_in_composition):
2393 Likewise.
2394 * xterm.h (set_vertical_scroll_bar): Likewise.
2395 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2396 (message_buf_print, scratch_glyph_row, displayed_buffer):
2397 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2398 (get_next_display_element, show_mouse_face, window_box_edges):
2399 (frame_to_window_pixel_xy, check_point_in_composition):
2400 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2401 (glyph_to_pixel_coords): Remove; unused.
2402
16390cd2
PE
2403 * dired.c (file_name_completion): Now static.
2404
2405 * dbusbind.c (xd_in_read_queued_messages): Now static.
2406
a25f4dfa
PE
2407 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2408 * data.c (circular_list_error): Remove.
2409
14a9c8df
PE
2410 * commands.h (last_point_position, last_point_position_buffer):
2411 (last_point_position_window): Remove decls.
2412 * keyboard.c: Make these variables static.
2413
04f2d78b
CB
2414 * coding.h (coding, code_convert_region, encode_coding_gap):
2415 Remove decls.
74ab6df5
PE
2416 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2417 (iso_code_class, detect_coding, code_convert_region): Now static.
2418 (encode_coding_gap): Remove; unused.
2419
38dfbee1
PE
2420 * chartab.c (chartab_chars, chartab_bits): Now static.
2421
a2cb4e63
PE
2422 * charset.h (charset_iso_8859_1): Remove decl.
2423 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2424 Now static.
2425
127198fd
PE
2426 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2427 * ccl.c (Vccl_program_table): Now static.
2428 (check_ccl_update): Remove; unused.
2429
d85b608f
PE
2430 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2431 * category.h: ... from here.
2432 * category.c (check_category_table, set_category_set): Now static.
2433
31cd66f3
PE
2434 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2435 * lisp.h: Remove these decls.
2436
c358e587
PE
2437 * buffer.c (buffer_count): Remove unused var.
2438
e78aecca
PE
2439 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2440 so that it's not optimized away.
2441 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2442 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2443 exported only to the debugger.
2444
e192d7d3 2445 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2446 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2447
92470028
PE
2448 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2449 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2450 was inaccessible from Lisp.
2451 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2452 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2453
244ed907
PE
2454 alloc.c: Import and export fewer symbols, and remove unused items.
2455 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2456 is defined.
2457 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2458 it's not optimized away by whole-program optimization.
2459 (message_enable_multibyte, free_misc): Remove.
2460 (catchlist, handlerlist, mark_backtrace):
2461 Declare only if BYTE_MARK_STACK.
2462 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2463 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2464 (message_enable_multibyte): Remove decl.
2465 (free_misc, interval_free_list, float_block, float_block_index):
2466 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2467 (cons_free_list, last_marked_index):
2468 Now static.
2469 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2470 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2471 (mark_backtrace): Define only if BYTE_MARK_STACK.
2472 * xdisp.c (message_enable_multibyte): Now static.
2473
61c2b50e 2474 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2475 This makes it easier for human readers (and static analyzers)
2476 to see whether these variables are used from other modules.
2477 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2478 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2479 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2480 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2481 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2482 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2483 * xmenu.c, xselect.c:
2484 Declare Q* vars static if they are not used in other modules.
2485 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2486 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2487 Remove decls of unexported vars.
2488 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2489
95c82688
PE
2490 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2491
16a97296
PE
2492 Make Emacs functions such as Fatom 'static' by default.
2493 This makes it easier for human readers (and static analyzers)
2494 to see whether these functions can be called from other modules.
2495 DEFUN now defines a static function. To make the function external
2496 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2497 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2498 (Finit_image_library):
16a97296
PE
2499 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2500 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2501 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2502 Remove decls, since these functions are now static.
2503 (Funintern, Fget_internal_run_time): New decls, since these functions
2504 were already external.
95c82688 2505
16a97296
PE
2506 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2507 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2508 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2509 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2510 * keyboard.c, keymap.c, lread.c:
2511 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2512 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2513 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2514 Mark functions with DEFUE instead of DEFUN,
2515 if they are used in other modules.
2516 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2517 decls for now-static functions.
2518 * buffer.h (Fdelete_overlay): Remove decl.
2519 * callproc.c (Fgetenv_internal): Mark as internal.
2520 * composite.c (Fremove_list_of_text_properties): Remove decl.
2521 (Fcomposition_get_gstring): New forward static decl.
2522 * composite.h (Fcomposite_get_gstring): Remove decl.
2523 * dired.c (Ffile_attributes): New forward static decl.
2524 * doc.c (Fdocumntation_property): New forward static decl.
2525 * eval.c (Ffetch_bytecode): New forward static decl.
2526 (Funintern): Remove extern decl; now in .h file where it belongs.
2527 * fileio.c (Fmake_symbolic_link): New forward static decl.
2528 * image.c (Finit_image_library): New forward static decl.
2529 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2530 * intervals.h (Fprevious_property_change):
2531 (Fremove_list_of_text_properties): Remove decls.
2532 * keyboard.c (Fthis_command_keys): Remove decl.
2533 (Fcommand_execute): New forward static decl.
2534 * keymap.c (Flookup_key): New forward static decl.
2535 (Fcopy_keymap): Now static.
2536 * keymap.h (Flookup_key): Remove decl.
2537 * process.c (Fget_process): New forward static decl.
2538 (Fprocess_datagram_address): Mark as internal.
2539 * syntax.c (Fsyntax_table_p): New forward static decl.
2540 (skip_chars): Remove duplicate decl.
2541 * textprop.c (Fprevious_property_change): New forward static decl.
2542 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2543 Now internal.
2544 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2545 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2546
785bbd42
PE
2547 * editfns.c (Fformat): Remove unreachable code.
2548
8b913b57
AS
25492011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2550
2551 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2552 change. (Bug#8496)
2553
a6744a35
EZ
25542011-04-13 Eli Zaretskii <eliz@gnu.org>
2555
2556 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2557 when at ZV. (Bug#8487)
2558
e7974947
AS
25592011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2560
baad03f0
AS
2561 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2562 (Bug#8437)
2563 * keyboard.c (parse_tool_bar_item): Likewise.
2564 * sound.c (sound_cleanup, alsa_close): Likewise.
2565 * termcap.c (tgetent): Likewise.
2566 * xfns.c (x_default_font_parameter): Likewise.
2567 * xsettings.c (read_and_apply_settings): Likewise.
2568
e7974947
AS
2569 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2570 (overrun_check_free): Protoize.
2571
28272684
PE
25722011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2573
2574 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2575 since callers should never pass a negative size.
2576 Change the signature to match that of plain 'read' and 'write'; see
2577 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2578 * lisp.h: Update prototypes of emacs_write and emacs_read.
2579
11997c76
EZ
25802011-04-11 Eli Zaretskii <eliz@gnu.org>
2581
2582 * xdisp.c (redisplay_window): Don't try to determine the character
2583 position of the scroll margin if the window start point w->startp
e896f03c 2584 is outside the buffer's accessible region. (Bug#8468)
11997c76 2585
8a2cbd72
EZ
25862011-04-10 Eli Zaretskii <eliz@gnu.org>
2587
2588 Fix write-region and its subroutines for buffers > 2GB.
2589 * fileio.c (a_write, e_write): Modify declaration of arguments and
2590 local variables to support buffers larger than 2GB.
2591 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2592
2593 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2594 argument, local variables, and return value.
2595
2596 * lisp.h: Update prototypes of emacs_write and emacs_read.
2597
2598 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2599
4073e537 26002011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2601
1ebfdcb6
PE
2602 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2603
b2ded58d
PE
2604 Fix more problems found by GCC 4.6.0's static checks.
2605
7d66342c
PE
2606 * xdisp.c (vmessage): Use a better test for character truncation.
2607
bbf47d44
PE
2608 * charset.c (load_charset_map): <, not <=, for optimization,
2609 and to avoid potential problems with integer overflow.
9248994d 2610 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2611 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2612 * editfns.c (Fformat): Likewise.
1e69125e 2613 * syntax.c (skip_chars): Likewise.
3befa583 2614
e3019616
PE
2615 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2616 This also lets GCC 4.6.0 generate slightly better loop code.
2617
becfa255
PE
2618 * callint.c (Fcall_interactively): <, not <=, for optimization.
2619 (Fcall_interactively): Count the number of arguments produced,
2620 not the number of arguments given. This is simpler and lets GCC
2621 4.6.0 generate slightly better code.
2622
dae0cd48
PE
2623 * ftfont.c: Distingish more carefully between FcChar8 and char.
2624 The previous code passed unsigned char * to a functions like
2625 strlen and xstrcasecmp that expect char *, which does not
2626 conform to the C standard.
2627 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2628 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2629 char * when the C standard requires it.
2630
76032d70
PE
2631 * keyboard.c (read_char): Remove unused var.
2632
eb3f1cc8
PE
2633 * eval.c: Port to Windows vsnprintf (Bug#8435).
2634 Include <limits.h>.
2635 (SIZE_MAX): Define if the headers do not.
2636 (verror): Do not give up if vsnprintf returns a negative count.
2637 Instead, grow the buffer. This ports to Windows vsnprintf, which
2638 does not conform to C99. Problem reported by Eli Zaretskii.
2639 Also, simplify the allocation scheme, by avoiding the need for
2640 calling realloc, and removing the ALLOCATED variable.
2641
70476b54
PE
2642 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2643
12020a9e
PE
2644 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2645 But keep the doprint source code for now, as we might revamp it
2646 and use it again (Bug#8435).
ea6c7ae6
PE
2647 * lisp.h (doprnt): Remove.
2648 * Makefile.in (base_obj): Remove doprnt.o.
2649 * deps.mk (doprnt.o): Remove.
2650
5fdb398c
PE
2651 error: Print 32- and 64-bit integers portably (Bug#8435).
2652 Without this change, on typical 64-bit hosts error ("...%d...", N)
2653 was used to print both 32- and 64-bit integers N, which relied on
2654 undefined behavior.
2655 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2656 New macro.
2657 * lisp.h (error, verror): Mark as printf-like functions.
2658 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2659 Report overflow in size calculations when allocating printf buffer.
2660 Do not truncate output string at its first null byte.
2661 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2662 Truncate the output at a character boundary, since vsnprintf does not
2663 do that.
2664 * charset.c (check_iso_charset_parameter): Convert internal
2665 character to string before calling 'error', since %c now has the
2666 printf meaning.
2667 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2668 overflow when computing char to be passed to 'error'. Do not
2669 pass Lisp_Object to 'error'; pass the integer instead.
2670 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2671 formatted with plain %d.
2672
b189fa66
PE
2673 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2674
bff87ef0
PE
2675 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2676
7e2cac20
PE
2677 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2678
ce4d90b5
PE
2679 * xterm.c (x_catch_errors): Remove duplicate declaration.
2680
266c9547
PE
2681 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2682
79c49ad2
PE
2683 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2684
368f4090
JM
26852011-04-10 Jim Meyering <meyering@redhat.com>
2686
2687 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2688 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2689 return ssize_t not "int", and use size_t as the buffer length.
2690 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2691 * gnutls.h: Update declarations.
2692 * process.c (read_process_output): Use ssize_t, to match.
2693 (send_process): Likewise.
2694
a32d4040
CY
26952011-04-09 Chong Yidong <cyd@stupidchicken.com>
2696
2697 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2698
8546720e 26992011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2700
04f2d78b
CB
2701 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2702 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2703
8546720e
GM
2704 * xterm.c (handle_one_xevent):
2705 * xmenu.c (create_and_show_popup_menu):
2706 * xselect.c (x_decline_selection_request)
2707 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2708
0a2f5c1a 27092011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2710
2711 Fix some uses of `int' instead of EMACS_INT.
2712 * search.c (string_match_1, fast_string_match)
2713 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2714 (scan_buffer, find_next_newline_no_quit)
2715 (find_before_next_newline, search_command, Freplace_match)
2716 (Fmatch_data): Make some `int' variables be EMACS_INT.
2717
2718 * xdisp.c (display_count_lines): 3rd argument and return value now
2719 EMACS_INT. All callers changed.
2720 (pint2hrstr): Last argument is now EMACS_INT.
2721
2722 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2723 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2724 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2725 (decode_coding_utf_16, decode_coding_emacs_mule)
2726 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2727 (decode_coding_ccl, decode_coding_charset)
2728 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2729 (decode_coding_iso_2022, decode_coding_emacs_mule)
2730 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2731 <char_offset, last_offset>: Declare EMACS_INT.
2732 (encode_coding_utf_8, encode_coding_utf_16)
2733 (encode_coding_emacs_mule, encode_invocation_designation)
2734 (encode_designation_at_bol, encode_coding_iso_2022)
2735 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2736 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2737 Declare EMACS_INT.
2738 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2739 (encode_invocation_designation): Last argument P_NCHARS is now
2740 EMACS_INT.
2741 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2742 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2743
2744 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2745 All users changed.
2746
2747 * ccl.c (Fccl_execute_on_string): Declare some variables
2748 EMACS_INT.
2749
8546720e 27502011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2751
2752 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2753
4e19a977
CS
27542011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2755
2756 * process.c (Fformat_network_address): Doc fix.
2757
87302331
R
27582011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2759
2760 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2761
cbb59342
CY
27622011-04-08 Chong Yidong <cyd@stupidchicken.com>
2763
2764 * keyboard.c (read_char): Call Lisp function help-form-show,
2765 instead of using internal_with_output_to_temp_buffer.
2766 (Qhelp_form_show): New var.
e0d38eeb 2767 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2768
2769 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2770
2771 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2772
e67a13ab
CY
27732011-04-06 Chong Yidong <cyd@stupidchicken.com>
2774
04f2d78b
CB
2775 * process.c (Flist_processes): Remove to Lisp.
2776 (list_processes_1): Delete.
e67a13ab 2777
973f782d
EZ
27782011-04-06 Eli Zaretskii <eliz@gnu.org>
2779
7c106b1e
EZ
2780 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2781
973f782d
EZ
2782 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2783
41cf7d1a 27842011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2785
ca23cc88
PE
2786 Fix more problems found by GCC 4.6.0's static checks.
2787
f390e2d5
PE
2788 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2789
42eea0d0
PE
2790 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2791
b69769da 2792 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2793
f9541e84
PE
2794 * xdisp.c (vmessage): Mark as a printf-like function.
2795
13841b55
PE
2796 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2797
c136c10f
PE
2798 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2799
5e2d4a30
PE
2800 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2801 printf-like functions.
2802 (tiff_load): Add casts to remove these marks before passing them
2803 to system-supplied API.
2804
583f48b9
PE
2805 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2806
b25d760e
PE
2807 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2808 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2809 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2810 directly, rather than having caller test rule sign. This avoids
2811 some unnecessary tests.
2812 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2813 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2814 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2815
bc7b6697 2816 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2817 (xfont_open): Avoid unnecessary tests.
bc7b6697 2818
27ccc379
PE
2819 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2820
dcd5c89a
PE
2821 * composite.h, composite.c (composition_gstring_put_cache):
2822 Use EMACS_INT, not int, for length.
2823
b13a45c6
PE
2824 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2825 breaking out part of COMPOSITION_DECODE_RULE.
2826 (COMPOSITION_DECODE_RULE): Use it.
2827 * composite.c (get_composition_id): Remove unused local vars,
2828 by using the new macro.
2829
1e792e4d
PE
2830 * textprop.c (set_text_properties_1): Change while to do-while,
2831 since the condition is always true at first.
2832
dc6c6455 2833 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2834 (interval_deletion_adjustment): Return unsigned value.
2835 All uses changed.
dc6c6455 2836
aba7731a
PE
2837 * process.c (list_processes_1, create_pty, read_process_output):
2838 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2839 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2840 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2841 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2842 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2843
fdfc4bf3
PE
2844 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2845
fca8fe46 2846 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2847 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2848
06a0259a 2849 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2850 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2851 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2852
e7b9e80f
PE
2853 * print.c (print_error_message): Avoid int overflow.
2854
56201685
PE
2855 * font.c (font_list_entities): Redo for clarity,
2856 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2857
78834453 2858 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2859 (font_score): Avoid potential overflow in diff calculation.
78834453 2860
0bc0b309 2861 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2862 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2863
e610eaca
PE
2864 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2865
b895abce
PE
2866 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2867 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2868 can always succeed if overflow has undefined behavior.
2869
1f1d9321 2870 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2871 (wordify): Omit three unnecessary tests.
1f1d9321 2872
c59478bc
PE
2873 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2874 All callers changed. This avoids the need for an unused var.
2875
79b73827
PE
2876 * casefiddle.c (casify_region): Remove var that is set but not used.
2877
a4db5dfe
PE
2878 * dired.c (file_name_completion): Remove var that is set but not used.
2879
43aae36e
PE
2880 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2881
2a47c44d 2882 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2883 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2884
a37c69bf
PE
2885 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2886 Check for integer overflow on size calculations.
2887
328ab8e7
PE
2888 * buffer.c (Fprevious_overlay_change): Remove var that is set
2889 but not used.
2890
e5a2a5cb
PE
2891 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2892 Remove vars that are set but not used.
8d84a6eb 2893 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2894 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2895
a60e5f68
PE
2896 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2897
f661cb61 2898 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2899 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2900
f0397f5a
PE
2901 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2902 that are set but not used.
2903
8664db06 2904 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2905 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2906
6abdaa4a
PE
2907 * xselect.c (x_get_local_selection, x_handle_property_notify):
2908 Remove vars that are set but not used.
2909
0ce7538d 2910 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2911 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2912
9ae848fc
PE
2913 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2914 Remove var that is set but not used.
0b918413
PE
2915 (scroll_bar_windows_size): Now size_t, not int.
2916 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2917 Check for overflow.
9ae848fc 2918
a5a62657
PE
2919 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2920 (map_tty_color) [!defined MSDOS]: Likewise.
2921
5c5cdd39
PE
2922 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2923
66ebf983
PE
2924 * coding.c: Remove vars that are set but not used.
2925 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2926 All callers changed.
2927 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2928 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2929 (decode_coding_charset): Remove vars that are set but not used.
2930
1be4d761
PE
2931 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2932 that is set but not used.
2933
47553fa8
PE
2934 * print.c (print_object): Remove var that is set but not used.
2935
1f7196bf 2936 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2937 The gnulib version avoids calling malloc in the usual case,
2938 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2939 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2940 * filelock.c (current_lock_owner): Likewise.
2941 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2942 * sysdep.c: Include allocator.h, careadlinkat.h.
2943 (emacs_no_realloc_allocator): New static constant.
2944 (emacs_readlink): New function.
fdb61804
PE
2945 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2946 ../lib/careadlinkat.h.
d1fdcab7 2947
f84c17c7
SM
29482011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2949
2950 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2951 first non-nil return value).
2952
ef3862ad
JD
29532011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2954
2955 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2956 if not defined (Bug#8403).
2957
376a7006
JB
29582011-04-02 Juanma Barranquero <lekktu@gmail.com>
2959
2960 * xdisp.c (display_count_lines): Remove parameter `start',
2961 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2962 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2963 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2964 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2965 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2966 and thereabouts. All callers changed.
2967 (get_per_char_metric): Remove parameter `f', unused since
2968 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2969
6ca3801d
JM
29702011-04-02 Jim Meyering <meyering@redhat.com>
2971
2972 do not dereference NULL upon failed strdup
2973 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2974 (ns_get_family): Likewise.
2975
d8e2b5ba
JB
29762011-04-02 Juanma Barranquero <lekktu@gmail.com>
2977
2978 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2979
8c74fcbd
JD
29802011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2981
2982 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2983 later (Bug#8403).
2984
7200d79c
SM
29852011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2986
03408648 2987 Add lexical binding.
7200d79c 2988
03408648
SM
2989 * window.c (Ftemp_output_buffer_show): New fun.
2990 (Fsave_window_excursion):
2991 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2992
2993 * lread.c (lisp_file_lexically_bound_p): New function.
2994 (Fload): Bind Qlexical_binding.
2995 (readevalloop): Remove `evalfun' arg.
2996 Bind Qinternal_interpreter_environment.
2997 (Feval_buffer): Bind Qlexical_binding.
2998 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2999 Mark as dynamic.
3000 (syms_of_lread): Declare `lexical-binding'.
3001
3002 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3003
3004 * keyboard.c (eval_dyn): New fun.
3005 (menu_item_eval_property): Use it.
ca105506
SM
3006
3007 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3008
03408648
SM
3009 * fns.c (concat, mapcar1): Accept byte-code-functions.
3010
3011 * eval.c (Fsetq): Handle lexical vars.
3012 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3013 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3014 (FletX, Flet): Obey lexical binding.
3015 (Fcommandp): Handle closures.
3016 (Feval): New `lexical' arg.
3017 (eval_sub): New function extracted from Feval. Use it almost
3018 everywhere where Feval was used. Look up vars in lexical env.
3019 Handle closures.
3020 (Ffunctionp): Move from subr.el.
3021 (Ffuncall): Handle closures.
3022 (apply_lambda): Remove `eval_flags'.
3023 (funcall_lambda): Handle closures and new byte-code-functions.
3024 (Fspecial_variable_p): New function.
3025 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3026 but without exporting it to Lisp.
23aba0ea 3027
23aba0ea 3028 * doc.c (Fdocumentation, store_function_docstring):
03408648 3029 * data.c (Finteractive_form): Handle closures.
23aba0ea 3030
03408648
SM
3031 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3032 interactive spec.
ba83908c 3033
04f2d78b
CB
3034 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3035 New byte-codes.
03408648
SM
3036 (exec_byte_code): New function extracted from Fbyte_code to handle new
3037 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3038
03408648 3039 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3040
03408648 3041 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3042
e2abce01
JB
30432011-03-31 Juanma Barranquero <lekktu@gmail.com>
3044
3045 * xdisp.c (redisplay_internal): Fix prototype.
3046
63696a73 30472011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3048
63696a73 3049 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3050 (try_scrolling): Use it when setting scroll_limit.
3051 Limit scrolling to 100 screen lines.
63696a73
EZ
3052 (redisplay_window): Even when falling back on "recentering",
3053 position point in the window according to scroll-conservatively,
3054 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3055
3056 (try_scrolling): When point is above the window, allow searching
3057 as far as scroll_max, or one screenful, to compute vertical
3058 distance from PT to the scroll margin position. This prevents
3059 try_scrolling from unnecessarily failing when
3060 scroll-conservatively is set to a value slightly larger than the
3061 window height. Clean up the case of PT below the margin at bottom
3062 of window: scroll_max can no longer be INT_MAX. When aggressive
3063 scrolling is in use, don't let point enter the opposite scroll
3064 margin as result of the scroll.
3065 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3066 threshold of 100 lines for never-recentering scrolling.
3067
e4cc2dfc
JB
30682011-03-31 Juanma Barranquero <lekktu@gmail.com>
3069
3070 * dispextern.h (move_it_by_lines):
3071 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3072 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3073 (message_log_check_duplicate): Remove parameters `prev_bol' and
3074 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3075 (redisplay_internal): Remove parameter `preserve_echo_area',
3076 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3077
3078 * indent.c (Fvertical_motion):
3079 * window.c (window_scroll_pixel_based, Frecenter):
3080 Don't pass `need_y_p' to `move_it_by_lines'.
3081
1c470562
SM
30822011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3083
44f230aa
SM
3084 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3085 steal a few bits to be more compact.
3086 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3087 Remove unneeded casts.
3088
1c470562
SM
3089 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3090
888adce9
ZK
30912011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3092
3093 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3094 binding" message (bug#7967).
3095
f838ed7b
PE
30962011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3097
77861b95
PE
3098 Fix more problems found by GCC 4.6.0's static checks.
3099
de6dbc14
PE
3100 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3101 Remove unused local var.
3102
f838ed7b
PE
3103 * editfns.c (Fmessage_box): Remove unused local var.
3104
792c7b2b
PE
3105 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3106 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3107 Omit unused local vars.
c499e557 3108 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3109 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3110 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3111 Omit unused local var.
3112
ba0165e1
PE
3113 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3114 Don't assume string length fits in int.
32ad8845 3115 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3116 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3117
3c59b4c9
PE
3118 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3119 instead of alloca (Bug#8344).
3120
a3eed478 3121 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3122 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3123
eb4d412d
PE
3124 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3125
1658b401
PE
3126 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3127 concerns.
3128
3129 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3130
3131 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3132
9a2c6e05
PE
3133 * keyboard.c (syms_of_keyboard): Use the same style as later
3134 in this function when indexing through an array. This also
3135 works around GCC bug 48267.
3136
03d0a109
PE
3137 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3138
44f730c8
PE
3139 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3140
fe75f926
PE
3141 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3142 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3143
ffa8c828
PE
3144 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3145 This avoids undefined behavior on integer overflow, and is a bit
3146 more convenient anyway since it is compared to a size_t variable.
3147
c5101a77
PE
3148 Variadic C functions now count arguments with size_t, not int.
3149 This avoids an unnecessary limitation on 64-bit machines, which
3150 caused (substring ...) to crash on large vectors (Bug#8344).
3151 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3152 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3153 All variadic functions and their callers changed accordingly.
c5101a77
PE
3154 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3155 * data.c (arith_driver, float_arith_driver): Likewise.
3156 * editfns.c (general_insert_function): Likewise.
3157 * eval.c (struct backtrace.nargs, interactive_p)
3158 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3159 (funcall_lambda, mark_backtrace): Likewise.
3160 * fns.c (concat): Likewise.
3161 * frame.c (x_set_frame_parameters): Likewise.
3162 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3163 0 if not found, not -1. All callers changed.
3164
dd3f25f7
PE
3165 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3166 (stack_copy_size): Now size_t, not int.
3167 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3168
461c2ab9
JB
31692011-03-28 Juanma Barranquero <lekktu@gmail.com>
3170
3171 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3172 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3173 All callers changed.
3174
3175 * lisp.h (multibyte_char_to_unibyte):
3176 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3177 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3178 * character.h (CHAR_TO_BYTE8):
3179 * cmds.c (internal_self_insert):
3180 * editfns.c (general_insert_function):
3181 * keymap.c (push_key_description):
3182 * search.c (Freplace_match):
3183 * xdisp.c (message_dolog, set_message_1): All callers changed.
3184
f6d62986
SM
31852011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3186
3187 * keyboard.c (safe_run_hook_funcall): New function.
3188 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3189 don't set the hook to nil, but remove the offending function instead.
3190 (Qcommand_hook_internal): Remove, unused.
3191 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3192 Vcommand_hook_internal.
3193
3194 * eval.c (enum run_hooks_condition): Remove.
3195 (funcall_nil, funcall_not): New functions.
3196 (run_hook_with_args): Call each function through a `funcall' argument.
3197 Remove `cond' argument, now redundant.
3198 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3199 (Frun_hook_with_args_until_failure): Adjust accordingly.
3200 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3201
1db5b1ad
JB
32022011-03-28 Juanma Barranquero <lekktu@gmail.com>
3203
3204 * dispextern.h (string_buffer_position): Remove declaration.
3205
3206 * print.c (strout): Remove parameter `multibyte', unused since
3207 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3208
3209 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3210 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3211 All callers changed.
3212
3213 * w32.c (_wsa_errlist): Use braces for struct initializers.
3214
3215 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3216 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3217 All callers changed.
3218 (string_buffer_position): Likewise. Also, make static (it's never
3219 used outside xdisp.c).
3220 (cursor_row_p): Remove parameter `w', unused since
3221 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3222 (decode_mode_spec): Remove parameter `precision', introduced during
3223 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3224 All callers changed.
3225
5ffb62aa
JD
32262011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3227
3228 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3229
461c2ab9 32302011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3231
3232 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3233 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3234 (ns_update_auto_hide_menu_bar): New functions.
3235 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3236 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3237 ns_constrain_all_frames.
3238 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3239 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3240
5c380ffb
JD
32412011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3242
3243 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3244
9af30bdf
GM
32452011-03-27 Glenn Morris <rgm@gnu.org>
3246
3247 * syssignal.h: Replace RETSIGTYPE with void.
3248 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3249 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3250 Replace SIGTYPE with void everywhere.
3251 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3252 * s/template.h (SIGTYPE): Remove commented out definition.
3253
e2abce01
JB
32542011-03-26 Eli Zaretskii <eliz@gnu.org>
3255
3256 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3257 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3258
f868cd8a
JB
32592011-03-26 Juanma Barranquero <lekktu@gmail.com>
3260
59eb0929
JB
3261 * w32.c (read_unc_volume): Use parameter `henum', instead of
3262 global variable `wget_enum_handle'.
3263
3264 * keymap.c (describe_vector): Remove parameters `indices' and
3265 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3266 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3267
f868cd8a
JB
3268 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3269
3270 * keyboard.c (timer_check): Remove parameter `do_it_now',
3271 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3272 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3273 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3274
3275 * keyboard.c (read_char):
3276 * w32menu.c (w32_menu_display_help):
3277 * xmenu.c (show_help_event, menu_help_callback):
3278 Adjust calls to `show_help_echo'.
3279
3280 * gtkutil.c (xg_maybe_add_timer):
3281 * keyboard.c (readable_events):
3282 * process.c (wait_reading_process_output):
3283 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3284
3285 * insdel.c (adjust_markers_gap_motion):
3286 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3287 (gap_left, gap_right): Don't call it.
3288
2ecf6fdb
CY
32892011-03-25 Chong Yidong <cyd@stupidchicken.com>
3290
3291 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3292 incurred during fontification.
3293
6b1f9ba4
JB
32942011-03-25 Juanma Barranquero <lekktu@gmail.com>
3295
3296 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3297 (DEFVAR_PER_BUFFER): Don't pass it.
3298
3299 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3300 (scrolling_window): Don't pass it.
3301
0f4a96b5
JB
33022011-03-25 Juanma Barranquero <lekktu@gmail.com>
3303
3304 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3305
3306 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3307 and `suffix'.
3308 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3309 of variables specific to SELinux and computation of `encoded_absname'.
3310
3311 * image.c (XPutPixel): Remove unused variable `height'.
3312
3313 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3314
3315 * unexw32.c (get_section_info): Remove unused variable `section'.
3316
3317 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3318 (system_process_attributes): Remove unused variable `sess'.
3319 (sys_read): Remove unused variable `err'.
3320
3321 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3322 (w32_wnd_proc): Remove unused variable `isdead'.
3323 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3324 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3325 (x_create_tip_frame): Remove unused variable `tem'.
3326
3327 * w32inevt.c (w32_console_read_socket):
3328 Remove unused variable `no_events'.
3329
3330 * w32term.c (x_draw_composite_glyph_string_foreground):
3331 Remove unused variable `width'.
3332
1149507c
JB
33332011-03-24 Juanma Barranquero <lekktu@gmail.com>
3334
3335 * w32term.c (x_set_glyph_string_clipping):
3336 Don't pass uninitialized region to CombineRgn.
3337
9c88f339
JB
33382011-03-23 Juanma Barranquero <lekktu@gmail.com>
3339
3340 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3341 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3342 (Fx_close_connection): Remove unused variable `i'.
3343
3344 * w32font.c (w32font_draw): Return number of glyphs.
3345 (w32font_open_internal): Remove unused variable `i'.
3346 (w32font_driver): Add missing initializer.
3347
3348 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3349 (fill_in_menu): Remove unused variable `items_added'.
3350
3351 * w32term.c (last_mouse_press_frame): Remove static global variable.
3352 (w32_clip_to_row): Remove unused variable `f'.
3353 (x_delete_terminal): Remove unused variable `i'.
3354
3355 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3356 (NOTHING): Remove unused static global variable.
3357 (uniscribe_check_otf): Remove unused variable `table'.
3358 (uniscribe_font_driver): Add missing initializers.
3359
dee091a3
JD
33602011-03-23 Julien Danjou <julien@danjou.info>
3361
3362 * term.c (Fsuspend_tty, Fresume_tty):
3363 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3364 * window.c (temp_output_buffer_show):
3365 * insdel.c (signal_before_change):
3366 * frame.c (Fhandle_switch_frame):
3367 * fileio.c (Fdo_auto_save):
3368 * emacs.c (Fkill_emacs):
3369 * editfns.c (save_excursion_restore):
3370 * cmds.c (internal_self_insert):
3371 * callint.c (Fcall_interactively):
3372 * buffer.c (Fkill_all_local_variables):
3373 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3374 Use Frun_hooks.
0f4a96b5 3375 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3376 unconditionnaly since it does the check itself.
3377
2c520ab5 33782011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3379
c9c49752
PE
3380 Fix more problems found by GCC 4.5.2's static checks.
3381
8abc3f12
PE
3382 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3383 the first time through the loop, since we know p0 < p1 then.
3384 This also avoids a gcc -Wstrict-overflow warning.
3385
a2d26660
PE
3386 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3387 leading to a memory leak, possible in functions like
3388 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3389 of objects (Bug#8318).
a2d26660 3390
916c72e9
PE
3391 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3392 that could (at least in theory) be that large.
3393
19ab8a18
PE
3394 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3395 This is less likely to overflow, and avoids undefined behavior if
3396 overflow does occur. All callers changed. Use strtoul to scan
3397 for the unsigned long integer.
b7cbbd6f
PE
3398 (pint2hrstr): Simplify and tune code slightly.
3399 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3400
f0641eff
PE
3401 * scroll.c (do_scrolling): Work around GCC bug 48228.
3402 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3403
7f650bb9
PE
3404 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3405 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3406 (validate_x_resource_name): Simplify count usage.
3407 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3408
37dd57d1
PE
3409 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3410 fail (Bug#8306).
81e56e61 3411
699979fc 3412 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3413
401bf9b4
PE
3414 * process.c (Fmake_network_process): Use socklen_t, not int,
3415 where POSIX says socklen_t is required in portable programs.
3416 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3417 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3418 (Fmake_network_process, server_accept_connection):
3419 (wait_reading_process_output, read_process_output):
3420 Likewise.
3421
b93aacde
PE
3422 * process.c: Rename or move locals to avoid shadowing.
3423 (list_processes_1, Fmake_network_process):
3424 (read_process_output_error_handler, exec_sentinel_error_handler):
3425 Rename or move locals.
4dc343ee 3426 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3427 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3428 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3429 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3430 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3431
af8a867c 3432 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3433 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3434 Include tparam.h instead, since it declares them.
af8a867c
PE
3435 * cm.h (PC): Remove extern decl; tparam.h now does this.
3436 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3437 * terminfo.c: Include tparam.h, to check interfaces.
3438 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3439 (tparam): Adjust signature to match interface in tparam.h;
3440 this removes some undefined behavior. Check that outstring and len
3441 are zero, which they always are with Emacs.
3442 * tparam.h (PC, BC, UP): New extern decls.
3443
0248044d 3444 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3445 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3446
8ff096c1 3447 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3448 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3449 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3450 (ftfont_list): Remove unused local.
49eaafba
PE
3451 (get_adstyle_property, ftfont_pattern_entity):
3452 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3453 Rename locals to avoid shadowing.
8ff096c1 3454
e2be39f6
PE
3455 * xfont.c (xfont_list_family): Mark var as initialized.
3456
c9735e30
PE
3457 * xml.c (make_dom): Now static.
3458
8f5201ae
PE
3459 * composite.c (composition_compute_stop_pos): Rename local to
3460 avoid shadowing.
b246f932
PE
3461 (composition_reseat_it): Remove unused locals.
3462 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3463 (composition_update_it): Mark var as initialized.
11b61122
PE
3464 (find_automatic_composition): Mark vars as initialized,
3465 with a FIXME (Bug#8290).
8f5201ae 3466
760fbc2c
PE
3467 character.h: Rename locals to avoid shadowing.
3468 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3469 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3470 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3471 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3472 to avoid shadowing.
3473
ff08eb85
PE
3474 * textprop.c (property_change_between_p): Remove; unused.
3475
fc7bf025
PE
3476 * intervals.c (interval_start_pos): Now static.
3477
235d7abc
PE
3478 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3479
44f230aa
SM
3480 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3481 Rename locals to avoid shadowing.
3e7d6594 3482
50060332
PE
3483 * sound.c (wav_play, au_play, Fplay_sound_internal):
3484 Fix pointer signedness.
d01f234b 3485 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3486 (wav_play): Initialize a variable to 0, to prevent undefined
3487 behavior (Bug#8278).
50060332 3488
c4fc4e30
PE
3489 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3490
918436ed
PE
3491 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3492
c939f91b
PE
3493 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3494 clobbering (Bug#8298).
b9c7f648
PE
3495 * sysdep.c (sys_subshell): Likewise.
3496 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3497
6bd8c144
PE
3498 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3499 This should get cleaned up, so that child_setup has the
3500 same signature on all platforms.
3501
7710357c 3502 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3503 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3504
c59da222
CY
35052011-03-22 Chong Yidong <cyd@stupidchicken.com>
3506
3507 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3508 not to be necessary, and produces flickering.
3509
66b87493
GM
35102011-03-20 Glenn Morris <rgm@gnu.org>
3511
3512 * config.in: Remove file.
3513
45b6f6d5
JB
35142011-03-20 Juanma Barranquero <lekktu@gmail.com>
3515
3516 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3517 are now in src/globals.h.
3518 (syms_of_minibuf): Remove spurious & from previous change.
3519
3ec03f7e
LL
35202011-03-20 Leo <sdl.web@gmail.com>
3521
3522 * minibuf.c (completing-read-function): New variable.
3523 (completing-read-default): Rename from completing-read.
3524 (completing-read): Call completing-read-function.
3525
b14e3e21
CY
35262011-03-19 Juanma Barranquero <lekktu@gmail.com>
3527
3528 * xfaces.c (Fx_load_color_file):
3529 Read color file from absolute filename (bug#8250).
3530
f2b726e6
JB
35312011-03-19 Juanma Barranquero <lekktu@gmail.com>
3532
3533 * makefile.w32-in: Update dependencies.
3534
09f6ff02
EZ
35352011-03-17 Eli Zaretskii <eliz@gnu.org>
3536
3537 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3538
29a6015a
PE
35392011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3540
a3a6c54e
PE
3541 Fix more problems found by GCC 4.5.2's static checks.
3542
b766f867
PE
3543 * process.c (make_serial_process_unwind, send_process_trap):
3544 (sigchld_handler): Now static.
3545
be02381c
PE
3546 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3547 That way, the code declares only the vars that it needs.
3548 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3549 * s/cygwin.h (PTY_ITERATION): Likewise.
3550 * s/darwin.h (PTY_ITERATION): Likewise.
3551 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3552
57048744
PE
3553 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3554 * process.c (allocate_pty): Don't declare stb unless it's needed.
3555
7914961c 3556 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3557 (CONSTANTLIM): Remove; unused.
3558 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3559 Define only if needed.
7914961c 3560
b3967b18
PE
3561 * unexelf.c (unexec): Name an expression,
3562 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3563 Use a different way to cause a compilation error if anyone uses
3564 n rather than nn, a way that does not involve shadowing.
73366a00 3565 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3566
29a6015a
PE
3567 * deps.mk (unexalpha.o): Remove; unused.
3568
43cfc33e 3569 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3570 * unexec.h: New file.
ce701a33
PE
3571 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3572 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3573 Depend on unexec.h.
3574 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3575 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3576 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3577 Change as necessary to match prototype in unexec.h.
ce701a33 3578
01f44d5a
PE
3579 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3580 shadowing.
4f63c6bb 3581 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3582
a6670b0b
PE
3583 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3584 Rename locals to avoid shadowing.
3585
cef2010d 3586 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3587 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3588
d4d7173a
PE
3589 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3590
f08b802a
PE
3591 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3592 warning when compiling print.c.
3593
3ddb0639
PE
3594 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3595 instead of using an uninitialized var.
5ad03b97 3596 (font_sort_entities): Mark var as initialized.
3ddb0639 3597
170a2692
PE
3598 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3599
e663c700
PE
3600 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3601 pointers to constants.
89bc529a 3602 (font_parse_fcname): Remove unused vars.
7b81e2d0 3603 (font_delete_unmatched): Now static.
ea838e10 3604 (font_get_spec): Remove; unused.
13a547c6
PE
3605 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3606 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3607 Rename or move locals to avoid shadowing.
e663c700 3608
2a80c887 3609 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3610 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3611
1384fa33 3612 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3613 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3614
8b2c52e9
PE
3615 * alloc.c (mark_backtrace): Move decl from here ...
3616 * lisp.h: ... to here, so that it can be checked.
3617
475545b5 3618 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3619 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3620 (lisp_indirect_variable): Name an expression,
3621 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3622 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3623
b1349114 3624 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3625 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3626 Use const pointer when appropriate.
b1349114 3627
a2928364
PE
3628 * lisp.h (get_system_name, get_operating_system_release):
3629 Move decls here, to check interfaces.
3630 * process.c (get_operating_system_release): Move decl to lisp.h.
3631 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3632 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3633 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3634 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3635 (Fformat_time_string, Fencode_time, Finsert_char):
3636 (Ftranslate_region_internal, Fformat):
3637 Rename or remove local vars to avoid shadowing.
9710023e 3638 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3639
a415e694
PE
3640 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3641 avoid shadowing.
3642
8ef4622d
PE
3643 * lisp.h (eassert): Check that the argument compiles, even if
3644 ENABLE_CHECKING is not defined.
3645
946f9a5b
PE
3646 * data.c (Findirect_variable): Name an expression, to avoid
3647 gcc -Wbad-function-cast warning.
112396d6 3648 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3649 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3650 (Fmake_variable_buffer_local, Fmake_local_variable):
3651 Mark variables as initialized.
52746918 3652 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3653
e5aab7e7 3654 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3655 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3656 Rename locals to avoid shadowing.
dff45157
PE
3657 (mark_stack): Move local variables into the #ifdef region where
3658 they're used.
7bc26fdb
PE
3659 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3660 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3661 needed otherwise.
3662 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3663 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3664 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3665
e5aab7e7
PE
3666 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3667 avoids undefined behavior in theory.
3668
4da60324
PE
3669 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3670
88043301
PE
3671 Use functions, not macros, for up- and down-casing (Bug#8254).
3672 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3673 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3674 to use the following functions instead of these macros.
3675 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3676 EMACS_INT, since callers assume the returned value fits in int.
3677 (upcase1): Likewise, for UPCASE_TABLE.
3678 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3679 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3680 the race-condition problem in the old DOWNCASE.
88043301 3681
19ed5445
PE
3682 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3683 Rename locals to avoid shadowing.
3684 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3685 (regex_compile, re_search_2, re_match_2_internal):
3686 Remove unused local vars.
952db0d7
PE
3687 (FREE_VAR): Rewrite so as not to use empty "else",
3688 which gcc can warn about.
da053e48 3689 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3690 (RETALLOC_IF): Define only if needed.
3691 (WORDCHAR_P): Likewise. This one is never needed, but is used
3692 only in a comment talking about a compiler bug, so put inside
3693 the #if 0 of that comment.
3694 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3695 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3696 Remove; unused.
19ed5445 3697
1f3561e4 3698 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3699 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3700 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3701
ded6f8f7
PE
3702 * search.c (simple_search): Remove unused var.
3703
dbd37a95
PE
3704 * dired.c (compile_pattern): Move decl from here ...
3705 * lisp.h: ... to here, so that it can be checked.
3706 (struct re_registers): New forward decl.
3707
7e47afad
PE
3708 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3709
85f24f61
PE
3710 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3711 All uses changed.
3712 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3713 Rename locals to avoid shadowing.
5671df8f 3714 (Fvertical_motion): Mark locals as initialized.
85f24f61 3715
181aa2be 3716 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3717 (casify_region): Mark local as initialized.
181aa2be 3718
930d429c
PE
3719 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3720
7082eac6
PE
3721 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3722 New macros, so that the caller can use some names other than
3723 gcpro1, gcpro2, etc.
3724 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3725 of the new macros.
3726 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3727 argument, for consistency with GCPRO2_VAR, etc: it is now the
3728 prefix of the variable, not the variable itself. All uses
3729 changed.
38b2c076
PE
3730 * dired.c (directory_files_internal, file_name_completion):
3731 Rename locals to avoid shadowing.
3732
15206ed9
PE
3733 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3734 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3735 dired.c's scmp function, had undefined behavior.
3736 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3737 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3738 * buffer.h: ... to here, because these macros use current_buffer,
3739 and the new implementation with inline functions needs to have
3740 current_buffer in scope now, rather than later when the macros
3741 are used.
3742 (downcase, upcase1): New static inline functions.
3743 (DOWNCASE, UPCASE1): Reimplement using these functions.
3744 This avoids undefined behavior in expressions like
3745 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3746 from race conditions in accessing the global variables
3747 case_temp1 and case_temp2.
3748 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3749 * lisp.h (case_temp1, case_temp2): Remove their decls.
3750 * character.h (ASCII_CHAR_P): Move from here ...
3751 * lisp.h: ... to here, so that the inline functions mentioned
3752 above can use them.
3753
4a6bea26
PE
3754 * dired.c (directory_files_internal_unwind): Now static.
3755
f14b7e14
PE
3756 * fileio.c (file_name_as_directory, directory_file_name):
3757 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3758 Now static.
2893f146
PE
3759 (file_name_as_directory): Use const pointers when appropriate.
3760 (Fexpand_file_name): Likewise. In particular, newdir might
3761 point at constant storage, so make it a const pointer.
fd4ead52 3762 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3763 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3764 signedness issues.
f839df0c
PE
3765 (Fset_file_times, Finsert_file_contents, auto_save_error):
3766 Rename locals to avoid shadowing.
f14b7e14 3767
5716756e 3768 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3769 (Ftry_completion, Fall_completions): Rename or remove locals
3770 to avoid shadowing.
5716756e 3771
b4c3046a
PE
3772 * marker.c (bytepos_to_charpos): Remove; unused.
3773
b45db522
PE
3774 * lisp.h (verify_bytepos, count_markers): New decls,
3775 so that gcc does not warn that these functions aren't declared.
3776
85876d07
PE
3777 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3778 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3779 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3780 (copy_text): Remove unused local var.
85876d07 3781
03d78a21 3782 * filelock.c (within_one_second): Now static.
b3dd38ab 3783 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3784
5df8f01b
PE
3785 * buffer.c (fix_overlays_before): Mark locals as initialized.
3786 (fix_start_end_in_overlays): Likewise. This function should be
3787 simplified by using pointers-to-pointers, but that's a different
3788 matter.
b1d876f1 3789 (switch_to_buffer_1): Now static.
8f54f30a
PE
3790 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3791 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3792
a70072c9 3793 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3794 Fix pointer signedness issue.
edced198
PE
3795 (sys_subshell): Mark local as volatile if checking for lint,
3796 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3797 (MAXPATHLEN): Define only if needed.
a70072c9 3798
a0977c44
PE
3799 * process.c (serial_open, serial_configure): Move decls from here ...
3800 * systty.h: ... to here, so that they can be checked.
3801
a884fdcc
PE
3802 * fns.c (get_random, seed_random): Move extern decls from here ...
3803 * lisp.h: ... to here, so that they can be checked.
3804
604efe86 3805 * sysdep.c (reset_io): Now static.
b8950c94 3806 (wait_for_termination_signal): Remove; unused.
604efe86 3807
38fc62d9
PE
3808 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3809 (copy_keymap_item, append_key, push_text_char_description):
3810 Now static.
1004a21a 3811 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3812 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3813 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3814 (describe_map_tree):
3815 Rename locals to avoid shadowing.
38fc62d9 3816
2f2650da
PE
3817 * keyboard.c: Declare functions static if they are not used elsewhere.
3818 (echo_char, echo_dash, cmd_error, top_level_2):
3819 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3820 (read_char, kbd_buffer_get_event, make_lispy_position):
3821 (make_lispy_event, make_lispy_movement, apply_modifiers):
3822 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3823 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3824 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3825 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3826 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3827
a053e86c 3828 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3829 (mark_kboards): Move decl here ...
3830 * alloc.c (mark_kboards): ... from here.
a053e86c 3831
4752793e
PE
3832 * lisp.h (force_auto_save_soon): New decl.
3833
74f10ca7 3834 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3835 (DEFINE_DUMMY_FUNCTION): New macro.
3836 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3837 Use it.
c03cd23f
PE
3838 (main): Add casts to avoid warnings
3839 if GCC considers string literals to be constants.
74f10ca7 3840
022e70d4
PE
3841 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3842
59d6fe83
PE
3843 * dbusbind.c: Pointer signedness fixes.
3844 (xd_signature, xd_append_arg, xd_initialize):
3845 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3846 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3847 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3848 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3849
78320123
PE
3850 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3851 if GCC considers string literals to be constants.
49cebcca 3852 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3853
35ac2a97
SM
38542011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3855
fb103ca9
SM
3856 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3857 (print_preprocess, print_object): New macro to fix last change.
3858
35ac2a97
SM
3859 * print.c (print_preprocess): Don't forget font objects.
3860
62973b41
JB
38612011-03-16 Juanma Barranquero <lekktu@gmail.com>
3862
3863 * emacs.c (USAGE3): Doc fixes.
3864
0e48bb22
AS
38652011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3866
3867 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3868 structure.
3869
7684e57b
JB
38702011-03-14 Juanma Barranquero <lekktu@gmail.com>
3871
3872 * lisp.h (VWindow_system, Qfile_name_history):
3873 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3874 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3875 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3876
3877 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3878 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3879
3880 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3881 * w32console.c (detect_input_pending, read_input_pending)
3882 (encode_terminal_code):
3883 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3884 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3885 (w32_system_caret_y, Qfile_name_history):
3886 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3887 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3888 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3889 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3890 * w32proc.c (Qlocal, report_file_error):
3891 * w32term.c (Vwindow_system, updating_frame):
3892 * w32uniscribe.c (initialized, uniscribe_font_driver):
3893 Remove unneeded extern declarations.
3894
2aa46d6c
CY
38952011-03-14 Chong Yidong <cyd@stupidchicken.com>
3896
c96bbc66 3897 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3898
cffc6f3b
CY
38992011-03-13 Chong Yidong <cyd@stupidchicken.com>
3900
3901 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3902 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3903 These macros can no longer be used for assignment.
3904
44f230aa
SM
3905 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3906 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3907 (record_buffer_markers, fetch_buffer_markers): New functions for
3908 recording and fetching special buffer markers.
3909 (set_buffer_internal_1, set_buffer_temp): Use them.
3910
3911 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3912
3913 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3914
3915 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3916 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3917
3918 * xdisp.c (hscroll_window_tree):
3919 (reconsider_clip_changes): Use PT instead of BUF_PT.
3920
d251f04b
EZ
39212011-03-13 Eli Zaretskii <eliz@gnu.org>
3922
3923 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3924 $(EMACS_ROOT)/lib/intprops.h.
3925
f0c77cd1
PE
39262011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3927
3eca4629
PE
3928 Fix more problems found by GCC 4.5.2's static checks.
3929
7c86ee98
PE
3930 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3931 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3932 (xg_free_frame_widgets): Make it clear that a local variable is
3933 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3934 (gdk_window_get_screen): Make it clear that this macro is needed
3935 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3936 (int_gtk_range_get_value): New function, which avoids a diagnostic
3937 from gcc -Wbad-function-cast.
3938 (xg_set_toolkit_scroll_bar_thumb): Use it.
3939 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3940 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3941 (get_utf8_string, xg_get_file_with_chooser):
3942 Rename locals to avoid shadowing.
3943 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3944
41729b81
PE
3945 * xgselect.c (xg_select): Remove unused var.
3946
f0c77cd1
PE
3947 * image.c (four_corners_best): Mark locals as initialized.
3948 (gif_load): Initialize transparent_p to zero (Bug#8238).
3949 Mark another local as initialized.
ec6cf4c6 3950 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3951
ce0ad53d 3952 * image.c (clear_image_cache): Now static.
d5d5a617 3953 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3954 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3955 (x_edge_detection): Remove unnecessary cast that
3956 gcc -Wbad-function-cast diagnoses.
2037898d 3957 (gif_load): Fix pointer signedness.
6ae141d6
PE
3958 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3959 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3960
33383987 39612011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3962
d32df629
PE
3963 Improve quality of tests for time stamp overflow.
3964 For example, without this patch (encode-time 0 0 0 1 1
3965 1152921504606846976) returns the obviously-bogus value (-948597
3966 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3967 reports time overflow. See
3968 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3969 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3970 * editfns.c: Include limits.h and intprops.h.
3971 (TIME_T_MIN, TIME_T_MAX): New macros.
3972 (time_overflow): Move earlier, to before first use.
3973 (hi_time, lo_time): New functions, for an accurate test for
3974 out-of-range times.
3975 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3976 (Fget_internal_run_time): Don't assume time_t fits in int.
3977 (make_time): Use list2 instead of Fcons twice.
3978 (Fdecode_time): More accurate test for out-of-range times.
3979 (check_tm_member): New function.
3980 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3981 (lisp_time_argument): Don't rely on undefined left-shift and
3982 right-shift behavior when checking for time stamp overflow.
8be6f318 3983
fe31d94c
PE
3984 * editfns.c (time_overflow): New function, refactoring common code.
3985 (Fformat_time_string, Fdecode_time, Fencode_time):
3986 (Fcurrent_time_string): Use it.
3987
8be6f318
PE
3988 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3989 * dired.c (make_time): Move to ...
3990 * editfns.c (make_time): ... here.
3991 * systime.h: Note the move.
3992
09d9db2c 39932011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3994
126bc0dc
YM
3995 * fringe.c (update_window_fringes): Remove unused variables.
3996
c47cbdfd
YM
3997 * unexmacosx.c (copy_data_segment): Also copy __got section.
3998 (Bug#8223)
3999
7ac80be9
EZ
40002011-03-12 Eli Zaretskii <eliz@gnu.org>
4001
c96bbc66 4002 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4003 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4004 Constify `char *' arguments and their references according to
4005 prototypes in tparam.h.
4006
ecb0f94d 4007 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4008
7ac80be9
EZ
4009 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4010 Adapt all references accordingly.
4011
4012 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4013
ef1fd07e
TT
40142011-03-11 Tom Tromey <tromey@redhat.com>
4015
4016 * buffer.c (syms_of_buffer): Remove obsolete comment.
4017
7ef4b50c
EZ
40182011-03-11 Eli Zaretskii <eliz@gnu.org>
4019
4020 * termhooks.h (encode_terminal_code): Declare prototype.
4021
4022 * msdos.c (encode_terminal_code): Don't declare prototype.
4023
4024 * term.c (encode_terminal_code): Now external again, used by
4025 w32console.c and msdos.c.
4026
44f230aa
SM
4027 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4028 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4029
4b1ec863 40302011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4031
1714f52b 4032 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4033
4b1ec863
PE
4034 * fringe.c (update_window_fringes): Mark locals as initialized
4035 (Bug#8227).
4036 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4037
524c7aa6
PE
4038 * alloc.c (mark_fringe_data): Move decl from here ...
4039 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4040 to check its interface.
4041 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4042
a5c0af81 4043 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4044 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4045 (fontset_font): Mark local as initialized.
a9a06e0b 4046 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4047
b4716021
PE
4048 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4049
811e9bac 4050 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4051 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4052 (x_own_selection, Fx_disown_selection_internal): Rename locals
4053 to avoid shadowing.
4054 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4055
7e3ab302
PE
4056 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4057 so that the caller can use some name other than gcpro1.
4058 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4059 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4060 (Fx_backspace_delete_keys_p):
4061 Use them to avoid shadowing, and rename vars to avoid shadowing.
4062 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4063 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4064 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4065 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4066 Remove unused locals.
7e3ab302
PE
4067 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4068 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4069 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4070 macros.
f78faa98 4071
e2b13473
PE
4072 * xterm.h (x_mouse_leave): New decl.
4073
77f23912
PE
4074 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4075 Remove unused functions.
cdf4ba58
PE
4076 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4077 (x_calc_absolute_position): Now static.
7411c686 4078 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4079 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4080 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4081 unless they are used.
38d0b34a
PE
4082 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4083 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4084 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4085 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4086 (x_error_catcher, x_connection_closed, x_error_handler):
4087 (x_error_quitter, xembed_send_message, x_iconify_frame):
4088 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4089 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4090 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4091
44f230aa
SM
4092 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4093 Rename or move locals to avoid shadowing.
6b463e58 4094 (tty_defined_color, merge_face_heights): Now static.
5967d051 4095 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4096 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4097 does not deduce is never used uninitialized.
73719eba
PE
4098 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4099 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4100
426994c3 4101 * terminal.c (store_terminal_param): Now static.
5489860b 4102
032f1620 4103 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4104 (set_frame_menubar): Remove unused local.
d4323972 4105 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4106 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4107 since they might point to immutable storage.
281585b0
PE
4108 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4109 since it's unused otherwise.
032f1620 4110
367c19e5 4111 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4112 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4113 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4114 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4115 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4116 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4117 does not deduce are never used uninitialized.
70739cbe 4118
07b48fa9
PE
4119 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4120
8868a238 4121 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4122 * window.c (window_loop, size_window):
4123 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4124
7e5cf297 4125 * window.c (display_buffer): Now static.
d6550a9f
PE
4126 (size_window): Mark variables that gcc -Wuninitialized
4127 does not deduce are never used uninitialized.
a586633d
PE
4128 * window.h (check_all_windows): New decl, to forestall
4129 gcc -Wmissing-prototypes diagnostic.
5b555da1 4130 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4131
f6095868
PE
4132 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4133 shadowing.
4134 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4135 Include <limits.h>.
4136 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4137 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4138 (load_charset_map): Mark variables that gcc -Wuninitialized
4139 does not deduce are never used uninitialized.
53df7c11 4140 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4141
f38b440c
PE
4142 * coding.c (coding_set_source, coding_set_destination):
4143 Use "else { /* comment */ }" rather than "else /* comment */;"
4144 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4145 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4146 a block, when the outer 'i' will do.
4147 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4148 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4149 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4150 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4151 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4152 Rename locals to avoid shadowing.
4153 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4154 * coding.c (emacs_mule_char, encode_invocation_designation):
4155 Now static, since they're not used elsewhere.
413bb2db 4156 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4157 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4158 (decode_coding_emacs_mule): Mark variables that gcc
4159 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4160 (detect_coding_iso_2022): Initialize a local variable that might
4161 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4162 this initialization is needed. (Bug#8211)
5f58e762
PE
4163 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4164 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4165 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4166 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4167 Remove unused macros.
f38b440c 4168
232b38b9 4169 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4170 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4171 * character.c (string_count_byte8): Likewise.
232b38b9 4172
fb90da1b
PE
4173 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4174 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4175
fb93dbc2
PE
4176 * chartab.c (copy_sub_char_table): Now static, since it's not used
4177 elsewhere.
5c156ace
PE
4178 (sub_char_table_ref_and_range, char_table_ref_and_range):
4179 Rename locals to avoid shadowing.
bbcd0949 4180 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4181
7d3b3862 4182 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4183 (BIDI_BOB): Remove unused macro.
7d3b3862 4184
6be7d3da
PE
4185 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4186 deduce are never used uninitialized.
c2ed9c8b 4187 * term.c (encode_terminal_code): Likewise.
6be7d3da 4188
75f8807f 4189 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4190
50938595
PE
4191 * tparam.h: New file.
4192 * term.c, tparam.h: Include it.
4193 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4194 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4195 Move these decls to tparam.h, and make them agree with what
4196 is actually in tparam.c. The previous trick of using incompatible
4197 decls in different modules does not conform to the C standard.
4198 All callers of tparam changed to use tparam's actual API.
4199 * tparam.c (tparam1, tparam, tgoto):
4200 Use const pointers where appropriate.
4201
fbceeba2
PE
4202 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4203 * cm.h (struct cm): Likewise.
4204 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4205 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4206 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4207 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4208 (turn_on_face, init_tty): Likewise.
4209 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4210
7f3f1250
PE
4211 * term.c (term_mouse_position): Rename local to avoid shadowing.
4212
e6ca6543
PE
4213 * alloc.c (mark_ttys): Move decl from here ...
4214 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4215
c40f8d15
AS
42162011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4217
4218 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4219
cfe0661d
JB
42202011-03-09 Juanma Barranquero <lekktu@gmail.com>
4221
4222 * search.c (compile_pattern_1): Remove argument regp, unused since
4223 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4224 (compile_pattern): Don't pass it.
4225
0afb4571
J
42262011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4227
4228 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4229 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4230 for ! HAVE_GTK3.
4231 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4232
4233 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4234
4235 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4236 gdk_window_get_screen, gdk_window_get_geometry,
4237 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4238 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4239 (xg_get_pixbuf_from_pixmap): New function.
4240 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4241 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4242 Call xg_get_pixbuf_from_pixmap instead of
4243 gdk_pixbuf_get_from_drawable.
4244 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4245 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4246 (xg_check_special_colors): Use GtkStyleContext and its functions
4247 for HAVE_GTK3.
4248 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4249 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4250 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4251 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4252 Call gtk_widget_get_preferred_size.
0afb4571
J
4253 (xg_frame_resized): gdk_window_get_geometry only takes 5
4254 parameters.
44f230aa
SM
4255 (xg_win_to_widget, xg_event_is_for_menubar):
4256 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4257 (xg_set_widget_bg): New function.
4258 (delete_cb): New function.
895009e1 4259 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4260 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4261 (xg_set_background_color): Call xg_set_widget_bg.
4262 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4263 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4264 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4265 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4266 if ! HAVE_GTK3.
4267 (update_frame_tool_bar): Call gtk_widget_hide.
4268 (xg_initialize): Use GDK_KEY_g.
4269
4270 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4271 if ! HAVE_GTK3
4272 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4273
4274 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4275 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4276 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4277
1c2cc4ef
JB
42782011-03-08 Juanma Barranquero <lekktu@gmail.com>
4279
4280 * w32xfns.c (select_palette): Check success of RealizePalette against
4281 GDI_ERROR, not zero.
4282
33383987 4283See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4284
4285;; Local Variables:
4286;; coding: utf-8
aac0c6e3
MR
4287;; End:
4288
33383987 4289 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4290
4291 This file is part of GNU Emacs.
4292
4293 GNU Emacs is free software: you can redistribute it and/or modify
4294 it under the terms of the GNU General Public License as published by
4295 the Free Software Foundation, either version 3 of the License, or
4296 (at your option) any later version.
4297
4298 GNU Emacs is distributed in the hope that it will be useful,
4299 but WITHOUT ANY WARRANTY; without even the implied warranty of
4300 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4301 GNU General Public License for more details.
4302
4303 You should have received a copy of the GNU General Public License
4304 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.