Merge from gnulib.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4073e537 12011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2
7d66342c
PE
3 * xdisp.c (vmessage): Use a better test for character truncation.
4
bbf47d44
PE
5 * charset.c (load_charset_map): <, not <=, for optimization,
6 and to avoid potential problems with integer overflow.
9248994d 7 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9 * editfns.c (Fformat): Likewise.
1e69125e 10 * syntax.c (skip_chars): Likewise.
3befa583 11
e3019616
PE
12 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13 This also lets GCC 4.6.0 generate slightly better loop code.
14
becfa255
PE
15 * callint.c (Fcall_interactively): <, not <=, for optimization.
16 (Fcall_interactively): Count the number of arguments produced,
17 not the number of arguments given. This is simpler and lets GCC
18 4.6.0 generate slightly better code.
19
dae0cd48
PE
20 * ftfont.c: Distingish more carefully between FcChar8 and char.
21 The previous code passed unsigned char * to a functions like
22 strlen and xstrcasecmp that expect char *, which does not
23 conform to the C standard.
24 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
25 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
26 char * when the C standard requires it.
27
76032d70
PE
28 * keyboard.c (read_char): Remove unused var.
29
eb3f1cc8
PE
30 * eval.c: Port to Windows vsnprintf (Bug#8435).
31 Include <limits.h>.
32 (SIZE_MAX): Define if the headers do not.
33 (verror): Do not give up if vsnprintf returns a negative count.
34 Instead, grow the buffer. This ports to Windows vsnprintf, which
35 does not conform to C99. Problem reported by Eli Zaretskii.
36 Also, simplify the allocation scheme, by avoiding the need for
37 calling realloc, and removing the ALLOCATED variable.
38
70476b54
PE
39 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
40
ea6c7ae6
PE
41 Remove the doprnt implementation, as Emacs now uses vsnprintf.
42 * doprnt.c: Remove.
43 * lisp.h (doprnt): Remove.
44 * Makefile.in (base_obj): Remove doprnt.o.
45 * deps.mk (doprnt.o): Remove.
46
5fdb398c
PE
47 error: Print 32- and 64-bit integers portably (Bug#8435).
48 Without this change, on typical 64-bit hosts error ("...%d...", N)
49 was used to print both 32- and 64-bit integers N, which relied on
50 undefined behavior.
51 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
52 New macro.
53 * lisp.h (error, verror): Mark as printf-like functions.
54 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
55 Report overflow in size calculations when allocating printf buffer.
56 Do not truncate output string at its first null byte.
57 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
58 Truncate the output at a character boundary, since vsnprintf does not
59 do that.
60 * charset.c (check_iso_charset_parameter): Convert internal
61 character to string before calling 'error', since %c now has the
62 printf meaning.
63 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
64 overflow when computing char to be passed to 'error'. Do not
65 pass Lisp_Object to 'error'; pass the integer instead.
66 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
67 formatted with plain %d.
68
b189fa66
PE
69 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
70
bff87ef0
PE
71 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
72
7e2cac20
PE
73 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
74
ce4d90b5
PE
75 * xterm.c (x_catch_errors): Remove duplicate declaration.
76
266c9547
PE
77 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
78
79c49ad2
PE
79 * xdisp.c, lisp.h (message_nolog): Remove; unused.
80
368f4090
JM
812011-04-10 Jim Meyering <meyering@redhat.com>
82
83 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
84 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
85 return ssize_t not "int", and use size_t as the buffer length.
86 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
87 * gnutls.h: Update declarations.
88 * process.c (read_process_output): Use ssize_t, to match.
89 (send_process): Likewise.
90
a32d4040
CY
912011-04-09 Chong Yidong <cyd@stupidchicken.com>
92
93 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
94
8546720e 952011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 96
8546720e
GM
97 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
98 unsigned char, to match FcChar8 type definition.
aac0c6e3 99
8546720e
GM
100 * xterm.c (handle_one_xevent):
101 * xmenu.c (create_and_show_popup_menu):
102 * xselect.c (x_decline_selection_request)
103 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 104
a53e2e89
EZ
1052011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
106
107 Fix some uses of `int' instead of EMACS_INT.
108 * search.c (string_match_1, fast_string_match)
109 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
110 (scan_buffer, find_next_newline_no_quit)
111 (find_before_next_newline, search_command, Freplace_match)
112 (Fmatch_data): Make some `int' variables be EMACS_INT.
113
114 * xdisp.c (display_count_lines): 3rd argument and return value now
115 EMACS_INT. All callers changed.
116 (pint2hrstr): Last argument is now EMACS_INT.
117
118 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
119 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
120 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
121 (decode_coding_utf_16, decode_coding_emacs_mule)
122 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
123 (decode_coding_ccl, decode_coding_charset)
124 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
125 (decode_coding_iso_2022, decode_coding_emacs_mule)
126 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
127 <char_offset, last_offset>: Declare EMACS_INT.
128 (encode_coding_utf_8, encode_coding_utf_16)
129 (encode_coding_emacs_mule, encode_invocation_designation)
130 (encode_designation_at_bol, encode_coding_iso_2022)
131 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
132 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
133 Declare EMACS_INT.
134 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
135 (encode_invocation_designation): Last argument P_NCHARS is now
136 EMACS_INT.
137 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
138 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
139
140 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
141 All users changed.
142
143 * ccl.c (Fccl_execute_on_string): Declare some variables
144 EMACS_INT.
145
8546720e 1462011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
147
148 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
149
4e19a977
CS
1502011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
151
152 * process.c (Fformat_network_address): Doc fix.
153
87302331
R
1542011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
155
156 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
157
cbb59342
CY
1582011-04-08 Chong Yidong <cyd@stupidchicken.com>
159
160 * keyboard.c (read_char): Call Lisp function help-form-show,
161 instead of using internal_with_output_to_temp_buffer.
162 (Qhelp_form_show): New var.
e0d38eeb 163 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
164
165 * print.c (internal_with_output_to_temp_buffer): Function deleted.
166
167 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
168
e67a13ab
CY
1692011-04-06 Chong Yidong <cyd@stupidchicken.com>
170
171 * process.c (Flist_processes): Removed to Lisp.
172 (list_processes_1): Deleted.
173
973f782d
EZ
1742011-04-06 Eli Zaretskii <eliz@gnu.org>
175
7c106b1e
EZ
176 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
177
973f782d
EZ
178 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
179
41cf7d1a 1802011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 181
ca23cc88
PE
182 Fix more problems found by GCC 4.6.0's static checks.
183
f390e2d5
PE
184 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
185
42eea0d0
PE
186 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
187
b69769da 188 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 189
f9541e84
PE
190 * xdisp.c (vmessage): Mark as a printf-like function.
191
13841b55
PE
192 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
193
c136c10f
PE
194 * sound.c (sound_warning): Don't crash if arg contains a printf format.
195
5e2d4a30
PE
196 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
197 printf-like functions.
198 (tiff_load): Add casts to remove these marks before passing them
199 to system-supplied API.
200
583f48b9
PE
201 * eval.c (Fsignal): Remove excess argument to 'fatal'.
202
b25d760e
PE
203 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
204 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
205 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
206 directly, rather than having caller test rule sign. This avoids
207 some unnecessary tests.
208 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
209 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
210 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 211
bc7b6697 212 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 213 (xfont_open): Avoid unnecessary tests.
bc7b6697 214
27ccc379
PE
215 * composite.c (composition_gstring_put_cache): Use unsigned integer.
216
dcd5c89a
PE
217 * composite.h, composite.c (composition_gstring_put_cache):
218 Use EMACS_INT, not int, for length.
219
b13a45c6
PE
220 * composite.h (COMPOSITION_DECODE_REFS): New macro,
221 breaking out part of COMPOSITION_DECODE_RULE.
222 (COMPOSITION_DECODE_RULE): Use it.
223 * composite.c (get_composition_id): Remove unused local vars,
224 by using the new macro.
225
1e792e4d
PE
226 * textprop.c (set_text_properties_1): Change while to do-while,
227 since the condition is always true at first.
228
dc6c6455 229 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
230 (interval_deletion_adjustment): Return unsigned value.
231 All uses changed.
dc6c6455 232
aba7731a
PE
233 * process.c (list_processes_1, create_pty, read_process_output):
234 (exec_sentinel): Remove vars that were set but not used.
afd4052b 235 (create_pty): Remove unnecessary "volatile"s.
bc57d757 236 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 237 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 238 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 239
fdfc4bf3
PE
240 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
241
fca8fe46 242 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 243 (update_syntax_table): Use unsigned instead of int.
fca8fe46 244
06a0259a 245 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 246 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 247 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 248
e7b9e80f
PE
249 * print.c (print_error_message): Avoid int overflow.
250
56201685
PE
251 * font.c (font_list_entities): Redo for clarity,
252 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
253
78834453 254 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 255 (font_score): Avoid potential overflow in diff calculation.
78834453 256
0bc0b309 257 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 258 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 259
e610eaca
PE
260 * eval.c (funcall_lambda): Rename local to avoid shadowing.
261
b895abce
PE
262 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
263 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
264 can always succeed if overflow has undefined behavior.
265
1f1d9321 266 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 267 (wordify): Omit three unnecessary tests.
1f1d9321 268
c59478bc
PE
269 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
270 All callers changed. This avoids the need for an unused var.
271
79b73827
PE
272 * casefiddle.c (casify_region): Remove var that is set but not used.
273
a4db5dfe
PE
274 * dired.c (file_name_completion): Remove var that is set but not used.
275
43aae36e
PE
276 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
277
2a47c44d 278 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 279 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 280
a37c69bf
PE
281 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
282 Check for integer overflow on size calculations.
283
328ab8e7
PE
284 * buffer.c (Fprevious_overlay_change): Remove var that is set
285 but not used.
286
e5a2a5cb
PE
287 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
288 Remove vars that are set but not used.
8d84a6eb 289 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 290 (timer_check_2): Mark vars as initialized.
e5a2a5cb 291
a60e5f68
PE
292 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
293
f661cb61 294 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 295 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 296
f0397f5a
PE
297 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
298 that are set but not used.
299
8664db06 300 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 301 if XCreateBitmapFromData fails (Bug#8410).
8664db06 302
6abdaa4a
PE
303 * xselect.c (x_get_local_selection, x_handle_property_notify):
304 Remove vars that are set but not used.
305
0ce7538d 306 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 307 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 308
9ae848fc
PE
309 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
310 Remove var that is set but not used.
0b918413
PE
311 (scroll_bar_windows_size): Now size_t, not int.
312 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
313 Check for overflow.
9ae848fc 314
a5a62657
PE
315 * xfaces.c (realize_named_face): Remove vars that are set but not used.
316 (map_tty_color) [!defined MSDOS]: Likewise.
317
5c5cdd39
PE
318 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
319
66ebf983
PE
320 * coding.c: Remove vars that are set but not used.
321 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
322 All callers changed.
323 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
324 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
325 (decode_coding_charset): Remove vars that are set but not used.
326
1be4d761
PE
327 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
328 that is set but not used.
329
47553fa8
PE
330 * print.c (print_object): Remove var that is set but not used.
331
1f7196bf 332 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
333 The gnulib version avoids calling malloc in the usual case,
334 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
335 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
336 * filelock.c (current_lock_owner): Likewise.
337 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
338 * sysdep.c: Include allocator.h, careadlinkat.h.
339 (emacs_no_realloc_allocator): New static constant.
340 (emacs_readlink): New function.
fdb61804
PE
341 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
342 ../lib/careadlinkat.h.
d1fdcab7 343
f84c17c7
SM
3442011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
345
346 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
347 first non-nil return value).
348
ef3862ad
JD
3492011-04-03 Jan Djärv <jan.h.d@swipnet.se>
350
351 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
352 if not defined (Bug#8403).
353
376a7006
JB
3542011-04-02 Juanma Barranquero <lekktu@gmail.com>
355
356 * xdisp.c (display_count_lines): Remove parameter `start',
357 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
358 (get_char_face_and_encoding): Remove parameter `multibyte_p',
359 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
360 (fill_stretch_glyph_string): Remove parameters `row' and `area',
361 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
362 and thereabouts. All callers changed.
363 (get_per_char_metric): Remove parameter `f', unused since
364 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
365
6ca3801d
JM
3662011-04-02 Jim Meyering <meyering@redhat.com>
367
368 do not dereference NULL upon failed strdup
369 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
370 (ns_get_family): Likewise.
371
d8e2b5ba
JB
3722011-04-02 Juanma Barranquero <lekktu@gmail.com>
373
374 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
375
8c74fcbd
JD
3762011-04-02 Jan Djärv <jan.h.d@swipnet.se>
377
378 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
379 later (Bug#8403).
380
7200d79c
SM
3812011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
382
03408648 383 Add lexical binding.
7200d79c 384
03408648
SM
385 * window.c (Ftemp_output_buffer_show): New fun.
386 (Fsave_window_excursion):
387 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
388
389 * lread.c (lisp_file_lexically_bound_p): New function.
390 (Fload): Bind Qlexical_binding.
391 (readevalloop): Remove `evalfun' arg.
392 Bind Qinternal_interpreter_environment.
393 (Feval_buffer): Bind Qlexical_binding.
394 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
395 Mark as dynamic.
396 (syms_of_lread): Declare `lexical-binding'.
397
398 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
399
400 * keyboard.c (eval_dyn): New fun.
401 (menu_item_eval_property): Use it.
ca105506
SM
402
403 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 404
03408648
SM
405 * fns.c (concat, mapcar1): Accept byte-code-functions.
406
407 * eval.c (Fsetq): Handle lexical vars.
408 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
409 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
410 (FletX, Flet): Obey lexical binding.
411 (Fcommandp): Handle closures.
412 (Feval): New `lexical' arg.
413 (eval_sub): New function extracted from Feval. Use it almost
414 everywhere where Feval was used. Look up vars in lexical env.
415 Handle closures.
416 (Ffunctionp): Move from subr.el.
417 (Ffuncall): Handle closures.
418 (apply_lambda): Remove `eval_flags'.
419 (funcall_lambda): Handle closures and new byte-code-functions.
420 (Fspecial_variable_p): New function.
421 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
422 but without exporting it to Lisp.
23aba0ea 423
23aba0ea 424 * doc.c (Fdocumentation, store_function_docstring):
03408648 425 * data.c (Finteractive_form): Handle closures.
23aba0ea 426
03408648
SM
427 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
428 interactive spec.
ba83908c 429
03408648
SM
430 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
431 byte-codes.
432 (exec_byte_code): New function extracted from Fbyte_code to handle new
433 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 434
03408648 435 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 436
03408648 437 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 438
e2abce01
JB
4392011-03-31 Juanma Barranquero <lekktu@gmail.com>
440
441 * xdisp.c (redisplay_internal): Fix prototype.
442
63696a73 4432011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 444
63696a73
EZ
445 * xdisp.c (SCROLL_LIMIT): New macro.
446 (try_scrolling): Use it when setting scroll_limit. Limit
447 scrolling to 100 screen lines.
448 (redisplay_window): Even when falling back on "recentering",
449 position point in the window according to scroll-conservatively,
450 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
451
452 (try_scrolling): When point is above the window, allow searching
453 as far as scroll_max, or one screenful, to compute vertical
454 distance from PT to the scroll margin position. This prevents
455 try_scrolling from unnecessarily failing when
456 scroll-conservatively is set to a value slightly larger than the
457 window height. Clean up the case of PT below the margin at bottom
458 of window: scroll_max can no longer be INT_MAX. When aggressive
459 scrolling is in use, don't let point enter the opposite scroll
460 margin as result of the scroll.
461 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
462 threshold of 100 lines for never-recentering scrolling.
463
e4cc2dfc
JB
4642011-03-31 Juanma Barranquero <lekktu@gmail.com>
465
466 * dispextern.h (move_it_by_lines):
467 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
468 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
469 (message_log_check_duplicate): Remove parameters `prev_bol' and
470 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
471 (redisplay_internal): Remove parameter `preserve_echo_area',
472 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
473
474 * indent.c (Fvertical_motion):
475 * window.c (window_scroll_pixel_based, Frecenter):
476 Don't pass `need_y_p' to `move_it_by_lines'.
477
1c470562
SM
4782011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
479
44f230aa
SM
480 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
481 steal a few bits to be more compact.
482 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
483 Remove unneeded casts.
484
1c470562
SM
485 * bytecode.c (Fbyte_code): CAR and CDR can GC.
486
888adce9
ZK
4872011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
488
489 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
490 binding" message (bug#7967).
491
f838ed7b
PE
4922011-03-30 Paul Eggert <eggert@cs.ucla.edu>
493
77861b95
PE
494 Fix more problems found by GCC 4.6.0's static checks.
495
de6dbc14
PE
496 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
497 Remove unused local var.
498
f838ed7b
PE
499 * editfns.c (Fmessage_box): Remove unused local var.
500
792c7b2b
PE
501 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
502 (note_mode_line_or_margin_highlight, note_mouse_highlight):
503 Omit unused local vars.
c499e557 504 * window.c (shrink_windows): Omit unused local var.
b01a1c29 505 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
506 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
507 Omit unused local var.
508
ba0165e1
PE
509 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
510 Don't assume string length fits in int.
32ad8845 511 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 512 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 513
3c59b4c9
PE
514 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
515 instead of alloca (Bug#8344).
516
a3eed478 517 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 518 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 519
eb4d412d
PE
520 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
521
1658b401
PE
522 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
523 concerns.
524
525 * term.c (produce_glyphless_glyph): Remove unnecessary test.
526
527 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 528
9a2c6e05
PE
529 * keyboard.c (syms_of_keyboard): Use the same style as later
530 in this function when indexing through an array. This also
531 works around GCC bug 48267.
532
03d0a109
PE
533 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
534
44f730c8
PE
535 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
536
fe75f926
PE
537 * chartab.c (sub_char_table_ref_and_range): Redo for slight
538 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
539
ffa8c828
PE
540 * keyboard.c, keyboard.h (num_input_events): Now size_t.
541 This avoids undefined behavior on integer overflow, and is a bit
542 more convenient anyway since it is compared to a size_t variable.
543
c5101a77
PE
544 Variadic C functions now count arguments with size_t, not int.
545 This avoids an unnecessary limitation on 64-bit machines, which
546 caused (substring ...) to crash on large vectors (Bug#8344).
547 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
548 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 549 All variadic functions and their callers changed accordingly.
c5101a77
PE
550 (struct gcpro.nvars): Now size_t, not int. All uses changed.
551 * data.c (arith_driver, float_arith_driver): Likewise.
552 * editfns.c (general_insert_function): Likewise.
553 * eval.c (struct backtrace.nargs, interactive_p)
554 (internal_condition_case_n, run_hook_with_args, apply_lambda)
555 (funcall_lambda, mark_backtrace): Likewise.
556 * fns.c (concat): Likewise.
557 * frame.c (x_set_frame_parameters): Likewise.
558 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
559 0 if not found, not -1. All callers changed.
560
dd3f25f7
PE
561 * alloc.c (garbage_collect): Don't assume stack size fits in int.
562 (stack_copy_size): Now size_t, not int.
563 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
564
461c2ab9
JB
5652011-03-28 Juanma Barranquero <lekktu@gmail.com>
566
567 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
568 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
569 All callers changed.
570
571 * lisp.h (multibyte_char_to_unibyte):
572 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
573 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
574 * character.h (CHAR_TO_BYTE8):
575 * cmds.c (internal_self_insert):
576 * editfns.c (general_insert_function):
577 * keymap.c (push_key_description):
578 * search.c (Freplace_match):
579 * xdisp.c (message_dolog, set_message_1): All callers changed.
580
f6d62986
SM
5812011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
582
583 * keyboard.c (safe_run_hook_funcall): New function.
584 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
585 don't set the hook to nil, but remove the offending function instead.
586 (Qcommand_hook_internal): Remove, unused.
587 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
588 Vcommand_hook_internal.
589
590 * eval.c (enum run_hooks_condition): Remove.
591 (funcall_nil, funcall_not): New functions.
592 (run_hook_with_args): Call each function through a `funcall' argument.
593 Remove `cond' argument, now redundant.
594 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
595 (Frun_hook_with_args_until_failure): Adjust accordingly.
596 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
597
1db5b1ad
JB
5982011-03-28 Juanma Barranquero <lekktu@gmail.com>
599
600 * dispextern.h (string_buffer_position): Remove declaration.
601
602 * print.c (strout): Remove parameter `multibyte', unused since
603 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
604
605 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
606 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
607 All callers changed.
608
609 * w32.c (_wsa_errlist): Use braces for struct initializers.
610
611 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
612 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
613 All callers changed.
614 (string_buffer_position): Likewise. Also, make static (it's never
615 used outside xdisp.c).
616 (cursor_row_p): Remove parameter `w', unused since
617 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
618 (decode_mode_spec): Remove parameter `precision', introduced during
619 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
620 All callers changed.
621
5ffb62aa
JD
6222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
623
624 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
625
461c2ab9 6262011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
627
628 * nsterm.m (ns_menu_bar_is_hidden): New variable.
629 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
630 (ns_update_auto_hide_menu_bar): New functions.
631 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
632 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
633 ns_constrain_all_frames.
634 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
635 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
636
5c380ffb
JD
6372011-03-27 Jan Djärv <jan.h.d@swipnet.se>
638
639 * nsmenu.m (runDialogAt): Remove argument to timer_check.
640
9af30bdf
GM
6412011-03-27 Glenn Morris <rgm@gnu.org>
642
643 * syssignal.h: Replace RETSIGTYPE with void.
644 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
645 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
646 Replace SIGTYPE with void everywhere.
647 * s/usg5-4-common.h (SIGTYPE): Remove definition.
648 * s/template.h (SIGTYPE): Remove commented out definition.
649
e2abce01
JB
6502011-03-26 Eli Zaretskii <eliz@gnu.org>
651
652 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
653 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
654
f868cd8a
JB
6552011-03-26 Juanma Barranquero <lekktu@gmail.com>
656
59eb0929
JB
657 * w32.c (read_unc_volume): Use parameter `henum', instead of
658 global variable `wget_enum_handle'.
659
660 * keymap.c (describe_vector): Remove parameters `indices' and
661 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
662 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
663
f868cd8a
JB
664 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
665
666 * keyboard.c (timer_check): Remove parameter `do_it_now',
667 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
668 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
669 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
670
671 * keyboard.c (read_char):
672 * w32menu.c (w32_menu_display_help):
673 * xmenu.c (show_help_event, menu_help_callback):
674 Adjust calls to `show_help_echo'.
675
676 * gtkutil.c (xg_maybe_add_timer):
677 * keyboard.c (readable_events):
678 * process.c (wait_reading_process_output):
679 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
680
681 * insdel.c (adjust_markers_gap_motion):
682 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
683 (gap_left, gap_right): Don't call it.
684
2ecf6fdb
CY
6852011-03-25 Chong Yidong <cyd@stupidchicken.com>
686
687 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
688 incurred during fontification.
689
6b1f9ba4
JB
6902011-03-25 Juanma Barranquero <lekktu@gmail.com>
691
692 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
693 (DEFVAR_PER_BUFFER): Don't pass it.
694
695 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
696 (scrolling_window): Don't pass it.
697
0f4a96b5
JB
6982011-03-25 Juanma Barranquero <lekktu@gmail.com>
699
700 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
701
702 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
703 and `suffix'.
704 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
705 of variables specific to SELinux and computation of `encoded_absname'.
706
707 * image.c (XPutPixel): Remove unused variable `height'.
708
709 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
710
711 * unexw32.c (get_section_info): Remove unused variable `section'.
712
713 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
714 (system_process_attributes): Remove unused variable `sess'.
715 (sys_read): Remove unused variable `err'.
716
717 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
718 (w32_wnd_proc): Remove unused variable `isdead'.
719 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
720 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
721 (x_create_tip_frame): Remove unused variable `tem'.
722
723 * w32inevt.c (w32_console_read_socket):
724 Remove unused variable `no_events'.
725
726 * w32term.c (x_draw_composite_glyph_string_foreground):
727 Remove unused variable `width'.
728
1149507c
JB
7292011-03-24 Juanma Barranquero <lekktu@gmail.com>
730
731 * w32term.c (x_set_glyph_string_clipping):
732 Don't pass uninitialized region to CombineRgn.
733
9c88f339
JB
7342011-03-23 Juanma Barranquero <lekktu@gmail.com>
735
736 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
737 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
738 (Fx_close_connection): Remove unused variable `i'.
739
740 * w32font.c (w32font_draw): Return number of glyphs.
741 (w32font_open_internal): Remove unused variable `i'.
742 (w32font_driver): Add missing initializer.
743
744 * w32menu.c (utf8to16): Remove unused variable `utf16'.
745 (fill_in_menu): Remove unused variable `items_added'.
746
747 * w32term.c (last_mouse_press_frame): Remove static global variable.
748 (w32_clip_to_row): Remove unused variable `f'.
749 (x_delete_terminal): Remove unused variable `i'.
750
751 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
752 (NOTHING): Remove unused static global variable.
753 (uniscribe_check_otf): Remove unused variable `table'.
754 (uniscribe_font_driver): Add missing initializers.
755
dee091a3
JD
7562011-03-23 Julien Danjou <julien@danjou.info>
757
758 * term.c (Fsuspend_tty, Fresume_tty):
759 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
760 * window.c (temp_output_buffer_show):
761 * insdel.c (signal_before_change):
762 * frame.c (Fhandle_switch_frame):
763 * fileio.c (Fdo_auto_save):
764 * emacs.c (Fkill_emacs):
765 * editfns.c (save_excursion_restore):
766 * cmds.c (internal_self_insert):
767 * callint.c (Fcall_interactively):
768 * buffer.c (Fkill_all_local_variables):
769 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
770 Use Frun_hooks.
0f4a96b5 771 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
772 unconditionnaly since it does the check itself.
773
2c520ab5 7742011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 775
c9c49752
PE
776 Fix more problems found by GCC 4.5.2's static checks.
777
8abc3f12
PE
778 * coding.c (encode_coding_raw_text): Avoid unnecessary test
779 the first time through the loop, since we know p0 < p1 then.
780 This also avoids a gcc -Wstrict-overflow warning.
781
a2d26660
PE
782 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
783 leading to a memory leak, possible in functions like
784 load_charset_map_from_file that can allocate an unbounded number
b12ef411 785 of objects (Bug#8318).
a2d26660 786
916c72e9
PE
787 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
788 that could (at least in theory) be that large.
789
19ab8a18
PE
790 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
791 This is less likely to overflow, and avoids undefined behavior if
792 overflow does occur. All callers changed. Use strtoul to scan
793 for the unsigned long integer.
b7cbbd6f
PE
794 (pint2hrstr): Simplify and tune code slightly.
795 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 796
f0641eff
PE
797 * scroll.c (do_scrolling): Work around GCC bug 48228.
798 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
799
7f650bb9
PE
800 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
801 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
802 (validate_x_resource_name): Simplify count usage.
803 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 804
37dd57d1
PE
805 * fileio.c (Fcopy_file): Report error if fchown or fchmod
806 fail (Bug#8306).
81e56e61 807
699979fc 808 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 809
401bf9b4
PE
810 * process.c (Fmake_network_process): Use socklen_t, not int,
811 where POSIX says socklen_t is required in portable programs.
812 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 813 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
814 (Fmake_network_process, server_accept_connection):
815 (wait_reading_process_output, read_process_output):
816 Likewise.
817
b93aacde
PE
818 * process.c: Rename or move locals to avoid shadowing.
819 (list_processes_1, Fmake_network_process):
820 (read_process_output_error_handler, exec_sentinel_error_handler):
821 Rename or move locals.
4dc343ee 822 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 823 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 824 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 825 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 826 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 827
af8a867c 828 Make tparam.h and terminfo.c consistent.
44f230aa
SM
829 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
830 Include tparam.h instead, since it declares them.
af8a867c
PE
831 * cm.h (PC): Remove extern decl; tparam.h now does this.
832 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
833 * terminfo.c: Include tparam.h, to check interfaces.
834 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
835 (tparam): Adjust signature to match interface in tparam.h;
836 this removes some undefined behavior. Check that outstring and len
837 are zero, which they always are with Emacs.
838 * tparam.h (PC, BC, UP): New extern decls.
839
0248044d 840 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 841 (xftfont_open): Rename locals to avoid shadowing.
0248044d 842
8ff096c1 843 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
844 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
845 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 846 (ftfont_list): Remove unused local.
49eaafba
PE
847 (get_adstyle_property, ftfont_pattern_entity):
848 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
849 Rename locals to avoid shadowing.
8ff096c1 850
e2be39f6
PE
851 * xfont.c (xfont_list_family): Mark var as initialized.
852
c9735e30
PE
853 * xml.c (make_dom): Now static.
854
8f5201ae
PE
855 * composite.c (composition_compute_stop_pos): Rename local to
856 avoid shadowing.
b246f932
PE
857 (composition_reseat_it): Remove unused locals.
858 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 859 (composition_update_it): Mark var as initialized.
11b61122
PE
860 (find_automatic_composition): Mark vars as initialized,
861 with a FIXME (Bug#8290).
8f5201ae 862
760fbc2c
PE
863 character.h: Rename locals to avoid shadowing.
864 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
865 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
866 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
867 (BUF_DEC_POS): Be more systematic about renaming local temporaries
868 to avoid shadowing.
869
ff08eb85
PE
870 * textprop.c (property_change_between_p): Remove; unused.
871
fc7bf025
PE
872 * intervals.c (interval_start_pos): Now static.
873
235d7abc
PE
874 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
875
44f230aa
SM
876 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
877 Rename locals to avoid shadowing.
3e7d6594 878
50060332
PE
879 * sound.c (wav_play, au_play, Fplay_sound_internal):
880 Fix pointer signedness.
d01f234b 881 (alsa_choose_format): Remove unused local var.
c83b8872
PE
882 (wav_play): Initialize a variable to 0, to prevent undefined
883 behavior (Bug#8278).
50060332 884
c4fc4e30
PE
885 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
886
918436ed
PE
887 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
888
c939f91b
PE
889 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
890 clobbering (Bug#8298).
b9c7f648
PE
891 * sysdep.c (sys_subshell): Likewise.
892 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 893
6bd8c144
PE
894 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
895 This should get cleaned up, so that child_setup has the
896 same signature on all platforms.
897
7710357c 898 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 899 (relocate_fd): Rename locals to avoid shadowing.
7710357c 900
c59da222
CY
9012011-03-22 Chong Yidong <cyd@stupidchicken.com>
902
903 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
904 not to be necessary, and produces flickering.
905
66b87493
GM
9062011-03-20 Glenn Morris <rgm@gnu.org>
907
908 * config.in: Remove file.
909
45b6f6d5
JB
9102011-03-20 Juanma Barranquero <lekktu@gmail.com>
911
912 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
913 are now in src/globals.h.
914 (syms_of_minibuf): Remove spurious & from previous change.
915
3ec03f7e
LL
9162011-03-20 Leo <sdl.web@gmail.com>
917
918 * minibuf.c (completing-read-function): New variable.
919 (completing-read-default): Rename from completing-read.
920 (completing-read): Call completing-read-function.
921
b14e3e21
CY
9222011-03-19 Juanma Barranquero <lekktu@gmail.com>
923
924 * xfaces.c (Fx_load_color_file):
925 Read color file from absolute filename (bug#8250).
926
f2b726e6
JB
9272011-03-19 Juanma Barranquero <lekktu@gmail.com>
928
929 * makefile.w32-in: Update dependencies.
930
09f6ff02
EZ
9312011-03-17 Eli Zaretskii <eliz@gnu.org>
932
933 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
934
29a6015a
PE
9352011-03-17 Paul Eggert <eggert@cs.ucla.edu>
936
a3a6c54e
PE
937 Fix more problems found by GCC 4.5.2's static checks.
938
b766f867
PE
939 * process.c (make_serial_process_unwind, send_process_trap):
940 (sigchld_handler): Now static.
941
be02381c
PE
942 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
943 That way, the code declares only the vars that it needs.
944 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
945 * s/cygwin.h (PTY_ITERATION): Likewise.
946 * s/darwin.h (PTY_ITERATION): Likewise.
947 * s/gnu-linux.h (PTY_ITERATION): Likewise.
948
57048744
PE
949 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
950 * process.c (allocate_pty): Don't declare stb unless it's needed.
951
7914961c 952 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
953 (CONSTANTLIM): Remove; unused.
954 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
955 Define only if needed.
7914961c 956
b3967b18
PE
957 * unexelf.c (unexec): Name an expression,
958 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
959 Use a different way to cause a compilation error if anyone uses
960 n rather than nn, a way that does not involve shadowing.
73366a00 961 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 962
29a6015a
PE
963 * deps.mk (unexalpha.o): Remove; unused.
964
43cfc33e 965 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 966 * unexec.h: New file.
ce701a33
PE
967 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
968 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
969 Depend on unexec.h.
970 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
971 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
972 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 973 Change as necessary to match prototype in unexec.h.
ce701a33 974
01f44d5a
PE
975 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
976 shadowing.
4f63c6bb 977 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 978
a6670b0b
PE
979 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
980 Rename locals to avoid shadowing.
981
cef2010d 982 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 983 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 984
d4d7173a
PE
985 * print.c (Fredirect_debugging_output): Fix pointer signedess.
986
f08b802a
PE
987 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
988 warning when compiling print.c.
989
3ddb0639
PE
990 * font.c (font_unparse_fcname): Abort in an "impossible" situation
991 instead of using an uninitialized var.
5ad03b97 992 (font_sort_entities): Mark var as initialized.
3ddb0639 993
170a2692
PE
994 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
995
e663c700
PE
996 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
997 pointers to constants.
89bc529a 998 (font_parse_fcname): Remove unused vars.
7b81e2d0 999 (font_delete_unmatched): Now static.
ea838e10 1000 (font_get_spec): Remove; unused.
13a547c6
PE
1001 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1002 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1003 Rename or move locals to avoid shadowing.
e663c700 1004
2a80c887 1005 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1006 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1007
1384fa33 1008 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1009 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1010
8b2c52e9
PE
1011 * alloc.c (mark_backtrace): Move decl from here ...
1012 * lisp.h: ... to here, so that it can be checked.
1013
475545b5 1014 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1015 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1016 (lisp_indirect_variable): Name an expression,
1017 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1018 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1019
b1349114 1020 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1021 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1022 Use const pointer when appropriate.
b1349114 1023
a2928364
PE
1024 * lisp.h (get_system_name, get_operating_system_release):
1025 Move decls here, to check interfaces.
1026 * process.c (get_operating_system_release): Move decl to lisp.h.
1027 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1028 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1029 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1030 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1031 (Fformat_time_string, Fencode_time, Finsert_char):
1032 (Ftranslate_region_internal, Fformat):
1033 Rename or remove local vars to avoid shadowing.
9710023e 1034 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1035
a415e694
PE
1036 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1037 avoid shadowing.
1038
8ef4622d
PE
1039 * lisp.h (eassert): Check that the argument compiles, even if
1040 ENABLE_CHECKING is not defined.
1041
946f9a5b
PE
1042 * data.c (Findirect_variable): Name an expression, to avoid
1043 gcc -Wbad-function-cast warning.
112396d6 1044 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1045 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1046 (Fmake_variable_buffer_local, Fmake_local_variable):
1047 Mark variables as initialized.
52746918 1048 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1049
e5aab7e7 1050 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1051 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1052 Rename locals to avoid shadowing.
dff45157
PE
1053 (mark_stack): Move local variables into the #ifdef region where
1054 they're used.
7bc26fdb
PE
1055 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1056 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1057 needed otherwise.
1058 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1059 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1060 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1061
e5aab7e7
PE
1062 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1063 avoids undefined behavior in theory.
1064
4da60324
PE
1065 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1066
88043301
PE
1067 Use functions, not macros, for up- and down-casing (Bug#8254).
1068 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1069 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1070 to use the following functions instead of these macros.
1071 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1072 EMACS_INT, since callers assume the returned value fits in int.
1073 (upcase1): Likewise, for UPCASE_TABLE.
1074 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1075 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1076 the race-condition problem in the old DOWNCASE.
88043301 1077
19ed5445
PE
1078 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1079 Rename locals to avoid shadowing.
1080 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1081 (regex_compile, re_search_2, re_match_2_internal):
1082 Remove unused local vars.
952db0d7
PE
1083 (FREE_VAR): Rewrite so as not to use empty "else",
1084 which gcc can warn about.
da053e48 1085 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1086 (RETALLOC_IF): Define only if needed.
1087 (WORDCHAR_P): Likewise. This one is never needed, but is used
1088 only in a comment talking about a compiler bug, so put inside
1089 the #if 0 of that comment.
1090 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1091 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1092 Remove; unused.
19ed5445 1093
1f3561e4 1094 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1095 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1096 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1097
ded6f8f7
PE
1098 * search.c (simple_search): Remove unused var.
1099
dbd37a95
PE
1100 * dired.c (compile_pattern): Move decl from here ...
1101 * lisp.h: ... to here, so that it can be checked.
1102 (struct re_registers): New forward decl.
1103
7e47afad
PE
1104 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1105
85f24f61
PE
1106 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1107 All uses changed.
1108 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1109 Rename locals to avoid shadowing.
5671df8f 1110 (Fvertical_motion): Mark locals as initialized.
85f24f61 1111
181aa2be 1112 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1113 (casify_region): Mark local as initialized.
181aa2be 1114
930d429c
PE
1115 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1116
7082eac6
PE
1117 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1118 New macros, so that the caller can use some names other than
1119 gcpro1, gcpro2, etc.
1120 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1121 of the new macros.
1122 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1123 argument, for consistency with GCPRO2_VAR, etc: it is now the
1124 prefix of the variable, not the variable itself. All uses
1125 changed.
38b2c076
PE
1126 * dired.c (directory_files_internal, file_name_completion):
1127 Rename locals to avoid shadowing.
1128
15206ed9
PE
1129 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1130 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1131 dired.c's scmp function, had undefined behavior.
1132 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1133 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1134 * buffer.h: ... to here, because these macros use current_buffer,
1135 and the new implementation with inline functions needs to have
1136 current_buffer in scope now, rather than later when the macros
1137 are used.
1138 (downcase, upcase1): New static inline functions.
1139 (DOWNCASE, UPCASE1): Reimplement using these functions.
1140 This avoids undefined behavior in expressions like
1141 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1142 from race conditions in accessing the global variables
1143 case_temp1 and case_temp2.
1144 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1145 * lisp.h (case_temp1, case_temp2): Remove their decls.
1146 * character.h (ASCII_CHAR_P): Move from here ...
1147 * lisp.h: ... to here, so that the inline functions mentioned
1148 above can use them.
1149
4a6bea26
PE
1150 * dired.c (directory_files_internal_unwind): Now static.
1151
f14b7e14
PE
1152 * fileio.c (file_name_as_directory, directory_file_name):
1153 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1154 Now static.
2893f146
PE
1155 (file_name_as_directory): Use const pointers when appropriate.
1156 (Fexpand_file_name): Likewise. In particular, newdir might
1157 point at constant storage, so make it a const pointer.
fd4ead52 1158 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1159 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1160 signedness issues.
f839df0c
PE
1161 (Fset_file_times, Finsert_file_contents, auto_save_error):
1162 Rename locals to avoid shadowing.
f14b7e14 1163
5716756e 1164 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1165 (Ftry_completion, Fall_completions): Rename or remove locals
1166 to avoid shadowing.
5716756e 1167
b4c3046a
PE
1168 * marker.c (bytepos_to_charpos): Remove; unused.
1169
b45db522
PE
1170 * lisp.h (verify_bytepos, count_markers): New decls,
1171 so that gcc does not warn that these functions aren't declared.
1172
85876d07
PE
1173 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1174 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1175 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1176 (copy_text): Remove unused local var.
85876d07 1177
03d78a21 1178 * filelock.c (within_one_second): Now static.
b3dd38ab 1179 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1180
5df8f01b
PE
1181 * buffer.c (fix_overlays_before): Mark locals as initialized.
1182 (fix_start_end_in_overlays): Likewise. This function should be
1183 simplified by using pointers-to-pointers, but that's a different
1184 matter.
b1d876f1 1185 (switch_to_buffer_1): Now static.
8f54f30a
PE
1186 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1187 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1188
a70072c9 1189 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1190 Fix pointer signedness issue.
edced198
PE
1191 (sys_subshell): Mark local as volatile if checking for lint,
1192 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1193 (MAXPATHLEN): Define only if needed.
a70072c9 1194
a0977c44
PE
1195 * process.c (serial_open, serial_configure): Move decls from here ...
1196 * systty.h: ... to here, so that they can be checked.
1197
a884fdcc
PE
1198 * fns.c (get_random, seed_random): Move extern decls from here ...
1199 * lisp.h: ... to here, so that they can be checked.
1200
604efe86 1201 * sysdep.c (reset_io): Now static.
b8950c94 1202 (wait_for_termination_signal): Remove; unused.
604efe86 1203
38fc62d9
PE
1204 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1205 (copy_keymap_item, append_key, push_text_char_description):
1206 Now static.
1004a21a 1207 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1208 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1209 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1210 (describe_map_tree):
1211 Rename locals to avoid shadowing.
38fc62d9 1212
2f2650da
PE
1213 * keyboard.c: Declare functions static if they are not used elsewhere.
1214 (echo_char, echo_dash, cmd_error, top_level_2):
1215 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1216 (read_char, kbd_buffer_get_event, make_lispy_position):
1217 (make_lispy_event, make_lispy_movement, apply_modifiers):
1218 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1219 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1220 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1221 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1222 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1223
a053e86c 1224 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1225 (mark_kboards): Move decl here ...
1226 * alloc.c (mark_kboards): ... from here.
a053e86c 1227
4752793e
PE
1228 * lisp.h (force_auto_save_soon): New decl.
1229
74f10ca7 1230 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1231 (DEFINE_DUMMY_FUNCTION): New macro.
1232 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1233 Use it.
c03cd23f
PE
1234 (main): Add casts to avoid warnings
1235 if GCC considers string literals to be constants.
74f10ca7 1236
022e70d4
PE
1237 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1238
59d6fe83
PE
1239 * dbusbind.c: Pointer signedness fixes.
1240 (xd_signature, xd_append_arg, xd_initialize):
1241 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1242 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1243 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1244 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1245
78320123
PE
1246 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1247 if GCC considers string literals to be constants.
49cebcca 1248 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1249
35ac2a97
SM
12502011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1251
fb103ca9
SM
1252 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1253 (print_preprocess, print_object): New macro to fix last change.
1254
35ac2a97
SM
1255 * print.c (print_preprocess): Don't forget font objects.
1256
62973b41
JB
12572011-03-16 Juanma Barranquero <lekktu@gmail.com>
1258
1259 * emacs.c (USAGE3): Doc fixes.
1260
0e48bb22
AS
12612011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1262
1263 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1264 structure.
1265
7684e57b
JB
12662011-03-14 Juanma Barranquero <lekktu@gmail.com>
1267
1268 * lisp.h (VWindow_system, Qfile_name_history):
1269 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1270 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1271 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1272
1273 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1274 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1275
1276 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1277 * w32console.c (detect_input_pending, read_input_pending)
1278 (encode_terminal_code):
1279 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1280 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1281 (w32_system_caret_y, Qfile_name_history):
1282 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1283 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1284 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1285 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1286 * w32proc.c (Qlocal, report_file_error):
1287 * w32term.c (Vwindow_system, updating_frame):
1288 * w32uniscribe.c (initialized, uniscribe_font_driver):
1289 Remove unneeded extern declarations.
1290
2aa46d6c
CY
12912011-03-14 Chong Yidong <cyd@stupidchicken.com>
1292
c96bbc66 1293 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1294
cffc6f3b
CY
12952011-03-13 Chong Yidong <cyd@stupidchicken.com>
1296
1297 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1298 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1299 These macros can no longer be used for assignment.
1300
44f230aa
SM
1301 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1302 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1303 (record_buffer_markers, fetch_buffer_markers): New functions for
1304 recording and fetching special buffer markers.
1305 (set_buffer_internal_1, set_buffer_temp): Use them.
1306
1307 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1308
1309 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1310
1311 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1312 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1313
1314 * xdisp.c (hscroll_window_tree):
1315 (reconsider_clip_changes): Use PT instead of BUF_PT.
1316
d251f04b
EZ
13172011-03-13 Eli Zaretskii <eliz@gnu.org>
1318
1319 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1320 $(EMACS_ROOT)/lib/intprops.h.
1321
f0c77cd1
PE
13222011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1323
3eca4629
PE
1324 Fix more problems found by GCC 4.5.2's static checks.
1325
7c86ee98
PE
1326 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1327 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1328 (xg_free_frame_widgets): Make it clear that a local variable is
1329 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1330 (gdk_window_get_screen): Make it clear that this macro is needed
1331 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1332 (int_gtk_range_get_value): New function, which avoids a diagnostic
1333 from gcc -Wbad-function-cast.
1334 (xg_set_toolkit_scroll_bar_thumb): Use it.
1335 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1336 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1337 (get_utf8_string, xg_get_file_with_chooser):
1338 Rename locals to avoid shadowing.
1339 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1340
41729b81
PE
1341 * xgselect.c (xg_select): Remove unused var.
1342
f0c77cd1
PE
1343 * image.c (four_corners_best): Mark locals as initialized.
1344 (gif_load): Initialize transparent_p to zero (Bug#8238).
1345 Mark another local as initialized.
ec6cf4c6 1346 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1347
ce0ad53d 1348 * image.c (clear_image_cache): Now static.
d5d5a617 1349 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1350 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1351 (x_edge_detection): Remove unnecessary cast that
1352 gcc -Wbad-function-cast diagnoses.
2037898d 1353 (gif_load): Fix pointer signedness.
6ae141d6
PE
1354 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1355 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1356
33383987 13572011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1358
d32df629
PE
1359 Improve quality of tests for time stamp overflow.
1360 For example, without this patch (encode-time 0 0 0 1 1
1361 1152921504606846976) returns the obviously-bogus value (-948597
1362 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1363 reports time overflow. See
1364 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1365 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1366 * editfns.c: Include limits.h and intprops.h.
1367 (TIME_T_MIN, TIME_T_MAX): New macros.
1368 (time_overflow): Move earlier, to before first use.
1369 (hi_time, lo_time): New functions, for an accurate test for
1370 out-of-range times.
1371 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1372 (Fget_internal_run_time): Don't assume time_t fits in int.
1373 (make_time): Use list2 instead of Fcons twice.
1374 (Fdecode_time): More accurate test for out-of-range times.
1375 (check_tm_member): New function.
1376 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1377 (lisp_time_argument): Don't rely on undefined left-shift and
1378 right-shift behavior when checking for time stamp overflow.
8be6f318 1379
fe31d94c
PE
1380 * editfns.c (time_overflow): New function, refactoring common code.
1381 (Fformat_time_string, Fdecode_time, Fencode_time):
1382 (Fcurrent_time_string): Use it.
1383
8be6f318
PE
1384 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1385 * dired.c (make_time): Move to ...
1386 * editfns.c (make_time): ... here.
1387 * systime.h: Note the move.
1388
09d9db2c 13892011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1390
126bc0dc
YM
1391 * fringe.c (update_window_fringes): Remove unused variables.
1392
c47cbdfd
YM
1393 * unexmacosx.c (copy_data_segment): Also copy __got section.
1394 (Bug#8223)
1395
7ac80be9
EZ
13962011-03-12 Eli Zaretskii <eliz@gnu.org>
1397
c96bbc66 1398 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1399 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1400 Constify `char *' arguments and their references according to
1401 prototypes in tparam.h.
1402
ecb0f94d 1403 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1404
7ac80be9
EZ
1405 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1406 Adapt all references accordingly.
1407
1408 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1409
ef1fd07e
TT
14102011-03-11 Tom Tromey <tromey@redhat.com>
1411
1412 * buffer.c (syms_of_buffer): Remove obsolete comment.
1413
7ef4b50c
EZ
14142011-03-11 Eli Zaretskii <eliz@gnu.org>
1415
1416 * termhooks.h (encode_terminal_code): Declare prototype.
1417
1418 * msdos.c (encode_terminal_code): Don't declare prototype.
1419
1420 * term.c (encode_terminal_code): Now external again, used by
1421 w32console.c and msdos.c.
1422
44f230aa
SM
1423 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1424 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1425
4b1ec863 14262011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1427
1714f52b 1428 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1429
4b1ec863
PE
1430 * fringe.c (update_window_fringes): Mark locals as initialized
1431 (Bug#8227).
1432 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1433
524c7aa6
PE
1434 * alloc.c (mark_fringe_data): Move decl from here ...
1435 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1436 to check its interface.
1437 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1438
a5c0af81 1439 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1440 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1441 (fontset_font): Mark local as initialized.
a9a06e0b 1442 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1443
b4716021
PE
1444 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1445
811e9bac 1446 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1447 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1448 (x_own_selection, Fx_disown_selection_internal): Rename locals
1449 to avoid shadowing.
1450 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1451
7e3ab302
PE
1452 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1453 so that the caller can use some name other than gcpro1.
1454 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1455 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1456 (Fx_backspace_delete_keys_p):
1457 Use them to avoid shadowing, and rename vars to avoid shadowing.
1458 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1459 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1460 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1461 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1462 Remove unused locals.
7e3ab302
PE
1463 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1464 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1465 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1466 macros.
f78faa98 1467
e2b13473
PE
1468 * xterm.h (x_mouse_leave): New decl.
1469
77f23912
PE
1470 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1471 Remove unused functions.
cdf4ba58
PE
1472 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1473 (x_calc_absolute_position): Now static.
7411c686 1474 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1475 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1476 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1477 unless they are used.
38d0b34a
PE
1478 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1479 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1480 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1481 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1482 (x_error_catcher, x_connection_closed, x_error_handler):
1483 (x_error_quitter, xembed_send_message, x_iconify_frame):
1484 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1485 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1486 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1487
44f230aa
SM
1488 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1489 Rename or move locals to avoid shadowing.
6b463e58 1490 (tty_defined_color, merge_face_heights): Now static.
5967d051 1491 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1492 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1493 does not deduce is never used uninitialized.
73719eba
PE
1494 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1495 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1496
426994c3 1497 * terminal.c (store_terminal_param): Now static.
5489860b 1498
032f1620 1499 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1500 (set_frame_menubar): Remove unused local.
d4323972 1501 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1502 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1503 since they might point to immutable storage.
281585b0
PE
1504 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1505 since it's unused otherwise.
032f1620 1506
367c19e5 1507 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1508 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1509 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1510 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1511 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1512 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1513 does not deduce are never used uninitialized.
70739cbe 1514
07b48fa9
PE
1515 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1516
8868a238 1517 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1518 * window.c (window_loop, size_window):
1519 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1520
7e5cf297 1521 * window.c (display_buffer): Now static.
d6550a9f
PE
1522 (size_window): Mark variables that gcc -Wuninitialized
1523 does not deduce are never used uninitialized.
a586633d
PE
1524 * window.h (check_all_windows): New decl, to forestall
1525 gcc -Wmissing-prototypes diagnostic.
5b555da1 1526 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1527
f6095868
PE
1528 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1529 shadowing.
1530 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1531 Include <limits.h>.
1532 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1533 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1534 (load_charset_map): Mark variables that gcc -Wuninitialized
1535 does not deduce are never used uninitialized.
53df7c11 1536 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1537
f38b440c
PE
1538 * coding.c (coding_set_source, coding_set_destination):
1539 Use "else { /* comment */ }" rather than "else /* comment */;"
1540 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1541 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1542 a block, when the outer 'i' will do.
1543 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1544 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1545 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1546 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1547 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1548 Rename locals to avoid shadowing.
1549 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1550 * coding.c (emacs_mule_char, encode_invocation_designation):
1551 Now static, since they're not used elsewhere.
413bb2db 1552 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1553 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1554 (decode_coding_emacs_mule): Mark variables that gcc
1555 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1556 (detect_coding_iso_2022): Initialize a local variable that might
1557 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1558 this initialization is needed. (Bug#8211)
5f58e762
PE
1559 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1560 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1561 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1562 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1563 Remove unused macros.
f38b440c 1564
232b38b9 1565 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1566 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1567 * character.c (string_count_byte8): Likewise.
232b38b9 1568
fb90da1b
PE
1569 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1570 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1571
fb93dbc2
PE
1572 * chartab.c (copy_sub_char_table): Now static, since it's not used
1573 elsewhere.
5c156ace
PE
1574 (sub_char_table_ref_and_range, char_table_ref_and_range):
1575 Rename locals to avoid shadowing.
bbcd0949 1576 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1577
7d3b3862 1578 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1579 (BIDI_BOB): Remove unused macro.
7d3b3862 1580
6be7d3da
PE
1581 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1582 deduce are never used uninitialized.
c2ed9c8b 1583 * term.c (encode_terminal_code): Likewise.
6be7d3da 1584
75f8807f 1585 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1586
50938595
PE
1587 * tparam.h: New file.
1588 * term.c, tparam.h: Include it.
1589 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1590 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1591 Move these decls to tparam.h, and make them agree with what
1592 is actually in tparam.c. The previous trick of using incompatible
1593 decls in different modules does not conform to the C standard.
1594 All callers of tparam changed to use tparam's actual API.
1595 * tparam.c (tparam1, tparam, tgoto):
1596 Use const pointers where appropriate.
1597
fbceeba2
PE
1598 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1599 * cm.h (struct cm): Likewise.
1600 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1601 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1602 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1603 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1604 (turn_on_face, init_tty): Likewise.
1605 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1606
7f3f1250
PE
1607 * term.c (term_mouse_position): Rename local to avoid shadowing.
1608
e6ca6543
PE
1609 * alloc.c (mark_ttys): Move decl from here ...
1610 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1611
c40f8d15
AS
16122011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1613
1614 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1615
cfe0661d
JB
16162011-03-09 Juanma Barranquero <lekktu@gmail.com>
1617
1618 * search.c (compile_pattern_1): Remove argument regp, unused since
1619 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1620 (compile_pattern): Don't pass it.
1621
0afb4571
J
16222011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1623
1624 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1625 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1626 for ! HAVE_GTK3.
1627 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1628
1629 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1630
1631 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1632 gdk_window_get_screen, gdk_window_get_geometry,
1633 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1634 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1635 (xg_get_pixbuf_from_pixmap): New function.
1636 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1637 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1638 Call xg_get_pixbuf_from_pixmap instead of
1639 gdk_pixbuf_get_from_drawable.
1640 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1641 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1642 (xg_check_special_colors): Use GtkStyleContext and its functions
1643 for HAVE_GTK3.
1644 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1645 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1646 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1647 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1648 Call gtk_widget_get_preferred_size.
0afb4571
J
1649 (xg_frame_resized): gdk_window_get_geometry only takes 5
1650 parameters.
44f230aa
SM
1651 (xg_win_to_widget, xg_event_is_for_menubar):
1652 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1653 (xg_set_widget_bg): New function.
1654 (delete_cb): New function.
1655 (xg_create_frame_widgets): connect delete-event to delete_cb.
1656 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1657 (xg_set_background_color): Call xg_set_widget_bg.
1658 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1659 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1660 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1661 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1662 if ! HAVE_GTK3.
1663 (update_frame_tool_bar): Call gtk_widget_hide.
1664 (xg_initialize): Use GDK_KEY_g.
1665
1666 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1667 if ! HAVE_GTK3
1668 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1669
1670 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1671 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1672 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1673
1c2cc4ef
JB
16742011-03-08 Juanma Barranquero <lekktu@gmail.com>
1675
1676 * w32xfns.c (select_palette): Check success of RealizePalette against
1677 GDI_ERROR, not zero.
1678
33383987 1679See ChangeLog.11 for earlier changes.
aac0c6e3
MR
1680
1681;; Local Variables:
1682;; coding: utf-8
aac0c6e3
MR
1683;; End:
1684
33383987 1685 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
1686
1687 This file is part of GNU Emacs.
1688
1689 GNU Emacs is free software: you can redistribute it and/or modify
1690 it under the terms of the GNU General Public License as published by
1691 the Free Software Foundation, either version 3 of the License, or
1692 (at your option) any later version.
1693
1694 GNU Emacs is distributed in the hope that it will be useful,
1695 but WITHOUT ANY WARRANTY; without even the implied warranty of
1696 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1697 GNU General Public License for more details.
1698
1699 You should have received a copy of the GNU General Public License
1700 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.