* editfns.c: Tune. Don't use wider integers than needed. Don't use alloca.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
28177add
PE
12011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2
2e6813b0 3 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4 Tune. Don't use wider integers than needed. Don't use alloca.
5 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 6
599a9e4f
PE
7 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8
99561444
PE
9 * insdel.c, lisp.h (buffer_overflow): New function.
10 (insert_from_buffer_1, replace_range, replace_range_2):
11 * insdel.c (make_gap_larger):
12 * editfns.c (Finsert_char):
13 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
14
28177add
PE
15 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
16
e69dafad
PE
172011-06-15 Paul Eggert <eggert@cs.ucla.edu>
18
a7af7fde 19 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 20
b1c46f02
PE
21 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
22 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
23
e69dafad
PE
24 * fileio.c: Don't assume EMACS_INT fits in off_t.
25 (emacs_lseek): New static function.
26 (Finsert_file_contents, Fwrite_region): Use it.
27 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
28
566684ea
PE
29 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
30
e6966cd6
PE
31 * fns.c: Don't overflow int when computing a list length.
32 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
33 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
34 truncation on 64-bit hosts. Check for QUIT every
35 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
36 faster and is responsive enough.
37 (Flength): Report an error instead of overflowing an integer.
38 (Fsafe_length): Return a float if the value is not representable
39 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 40 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 41 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 42
dd0b0efb
PE
43 * alloc.c: Check that resized vectors' lengths fit in fixnums.
44 (header_size, word_size): New constants.
45 (allocate_vectorlike): Don't check size overflow here.
46 (allocate_vector): Check it here instead, since this is the only
47 caller of allocate_vectorlike that could cause overflow.
48 Check that the new vector's length is representable as a fixnum.
49
86fe5cfe
PE
50 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
51 The previous code was bogus. For example, next_almost_prime (32)
52 returned 39, which is undesirable as it is a multiple of 3; and
53 next_almost_prime (24) returned 25, which is a multiple of 5 so
54 why was the code bothering to check for multiples of 7?
55
80e88859
PE
56 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
57
4a2f0ad6
PE
58 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
59
f66c7cf8
PE
60 Variadic C functions now count arguments with ptrdiff_t.
61 This partly undoes my 2011-03-30 change, which replaced int with size_t.
62 Back then I didn't know that the Emacs coding style prefers signed int.
63 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
64 were being counted with int, which may truncate counts on 64-bit
65 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
66 * lisp.h (struct Lisp_Subr.function.aMANY)
67 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
68 Arg counts are now ptrdiff_t, not size_t.
69 All variadic functions and their callers changed accordingly.
70 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
71 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
72 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
73 * callint.c (Fcall_interactively): Check arg count for overflow,
74 to avoid potential buffer overrun. Use signed char, not 'int',
75 for 'varies' array, so that we needn't bother to check its size
76 calculation for overflow.
77 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
78 * eval.c (apply_lambda):
79 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
80 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
81 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
82
a1759b76
PE
83 * callint.c (Fcall_interactively): Don't use index var as event count.
84
d96be9fc
PE
85 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
86 * mem-limits.h (SIZE): Remove; no longer used.
87
a690a978 88 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 89
578c21e6
PE
90 Remove unnecessary casts.
91 * xterm.c (x_term_init):
92 * xfns.c (x_set_border_pixel):
93 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
94 These aren't needed now that we assume ANSI C.
95
96f53c6c
PE
96 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
97 It's more likely to cause problems (due to unsigned overflow)
98 than to cure them.
99
83c77d31
PE
100 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
101
ee2079f1
PE
102 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
103
6da65536
PE
104 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
105
7147c4a4
PE
106 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
107
193e32d9
PE
108 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
109
e5533da6
PE
110 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
111
9910e595
PE
112 GLYPH_CODE_FACE returns EMACS_INT, not int.
113 * dispextern.h (merge_faces):
114 * xfaces.c (merge_faces):
01103c44
PE
115 * xdisp.c (get_next_display_element, next_element_from_display_vector):
116 Don't assume EMACS_INT fits in int.
9910e595 117
2638320e
PE
118 * character.h (CHAR_VALID_P): Remove unused parameter.
119 * fontset.c, lisp.h, xdisp.c: All uses changed.
120
045eb8d9
PE
121 * editfns.c (Ftranslate_region_internal): Omit redundant test.
122
c1f134b5
PE
123 * fns.c (concat): Minor tuning based on overflow analysis.
124 This doesn't fix any bugs. Use int to hold character, instead
125 of constantly refetching from Emacs object. Use XFASTINT, not
126 XINT, for value known to be a character. Don't bother comparing
127 a single byte to 0400, as it's always less.
128
395fcb93 129 * floatfns.c (Fexpt):
327eeec8
PE
130 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
131
abbd3d23
PE
132 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
133 for characters.
134
684a03ef
PE
135 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
136
0fed43f3
PE
137 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
138 Without this fix, on a 64-bit host (aset S 0 4294967386) would
139 incorrectly succeed when S was a string, because 4294967386 was
140 truncated before it was used.
141
8fd02eb7
PE
142 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
143 Otherwise, an out-of-range integer could cause undefined behavior
144 on a 64-bit host.
145
f8c86b69
PE
146 * composite.c: Use int, not EMACS_INT, for characters.
147 (fill_gstring_body, composition_compute_stop_pos): Use int, not
148 EMACS_INT, for values that are known to be in character range.
149 This doesn't fix any bugs but is the usual style inside Emacs and
150 may generate better code on 32-bit machines.
151
34206dd2
PE
152 Make sure a 64-bit char is never passed to ENCODE_CHAR.
153 This is for reasons similar to the recent CHAR_STRING fix.
154 * charset.c (Fencode_char): Check that character arg is actually
155 a character. Pass an int to ENCODE_CHAR.
156 * charset.h (ENCODE_CHAR): Verify that the character argument is no
157 wider than 'int', as a compile-time check to prevent future regressions
158 in this area.
159
c5958d4c 160 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
161
162 Make sure a 64-bit char is never passed to CHAR_STRING.
163 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
164 by silently ignoring the top 32 bits, allowing some values
165 that were far too large to be valid characters.
166 * character.h: Include <verify.h>.
167 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
168 arguments are no wider than unsigned, as a compile-time check
169 to prevent future regressions in this area.
170 * data.c (Faset):
01103c44 171 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
172 (Fsubst_char_in_region):
173 * fns.c (concat):
174 * xdisp.c (decode_mode_spec_coding):
175 Adjust to CHAR_STRING's new requirement.
176 * editfns.c (Finsert_char, Fsubst_char_in_region):
177 * fns.c (concat): Check that character args are actually
178 characters. Without this test, these functions did the wrong
179 thing with wildly out-of-range values on 64-bit hosts.
180
d37ca623
PE
181 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
182 These casts should not be needed on 32-bit hosts, either.
183 * keyboard.c (read_char):
184 * lread.c (Fload): Remove casts to unsigned.
185
ea204efb
PE
186 * lisp.h (UNSIGNED_CMP): New macro.
187 This fixes comparison bugs on 64-bit hosts.
188 (ASCII_CHAR_P): Use it.
189 * casefiddle.c (casify_object):
01103c44 190 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
191 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
192 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
193 * dispextern.h (FACE_FROM_ID):
194 * keyboard.c (read_char): Use UNSIGNED_CMP.
195
41cb286c
PE
196 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
197 not to EMACS_INT, to avoid GCC warning.
198
4a1b9832
PE
199 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
200
55daad71
PE
201 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
202 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
203 isn't needed on 32-bit machines.
8f95c75c 204
01103c44
PE
205 * buffer.c (Fgenerate_new_buffer_name):
206 Use EMACS_INT for count, not int.
0ceccced 207 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
208
209 * data.c (Qcompiled_function): Now static.
210
c6f072e7
PE
211 * window.c (window_body_lines): Now static.
212
20ce5912
PE
213 * image.c (gif_load): Rename local to avoid shadowing.
214
9c4c5f81
PE
215 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
216 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
217 * alloc.c (make_save_value): Integer argument is now of type
218 ptrdiff_t, not int.
219 (mark_object): Use ptrdiff_t, not int.
220 * lisp.h (pD): New macro.
221 * print.c (print_object): Use it.
222
c0c5c8ae
PE
223 * alloc.c: Use EMACS_INT, not int, to count objects.
224 (total_conses, total_markers, total_symbols, total_vector_size)
225 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
226 (total_free_floats, total_floats, total_free_intervals)
227 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
228 Now EMACS_INT, not int. All uses changed.
229 (Fgarbage_collect): Compute overall total using a double, so that
230 integer overflow is less likely to be a problem. Check for overflow
231 when converting back to an integer.
5a25e253
PE
232 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
233 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
234 These were 'int' variables that could overflow on 64-bit hosts;
235 they were never used, so remove them instead of repairing them.
211a0b2a 236 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
237 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
238 Previously, this ceilinged at INT_MAX, but that doesn't work on
239 64-bit machines.
e46bb31a 240 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 241
c78baabf 242 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 243 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
244 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
245 when a (possibly-narrower) signed value would do just as well.
246 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 247
c9d624c6
PE
248 * alloc.c: Catch some string size overflows that we were missing.
249 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
250 for convenience in STRING_BYTES_MAX.
251 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
252 The definition here is exact; the one in lisp.h was approximate.
253 (allocate_string_data): Check for string overflow. This catches
254 some instances we weren't catching before. Also, it catches
255 size_t overflow on (unusual) hosts where SIZE_MAX <= min
256 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
257 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 258
c9d624c6
PE
259 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
260 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
261 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
262
353032ce
PE
263 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
264
2bccce07
PE
265 * alloc.c (Fmake_string): Check for out-of-range init.
266
0ac30604
SM
2672011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
268
269 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
270
c195f2de
JD
2712011-06-14 Jan Djärv <jan.h.d@swipnet.se>
272
273 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
274 xg_get_default_scrollbar_width.
275
276 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
277 (int_gtk_range_get_value): Move to the scroll bar part of the file.
278 (style_changed_cb): Call update_theme_scrollbar_width and call
279 x_set_scroll_bar_default_width and xg_frame_set_char_size for
280 all frames (Bug#8505).
281 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
282 Call gtk_window_set_resizable if HAVE_GTK3.
283 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
284 and height if HAVE_GTK3 (Bug#8505).
285 (scroll_bar_width_for_theme): New variable.
286 (update_theme_scrollbar_width): New function.
287 (xg_get_default_scrollbar_width): Move code to
288 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
289 (xg_initialize): Call update_theme_scrollbar_width.
290
291 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
292
293 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
294
e10ac9f1
MR
2952011-06-12 Martin Rudalics <rudalics@gmx.at>
296
297 * frame.c (make_frame): Call other_buffer_safely instead of
298 other_buffer.
299
300 * window.c (temp_output_buffer_show): Call display_buffer with
301 second argument Vtemp_buffer_show_specifiers and reset latter
302 immediately after the call.
303 (Vtemp_buffer_show_specifiers): New variable.
304 (auto_window_vscroll_p, next_screen_context_lines)
305 (Vscroll_preserve_screen_position): Remove leading asterisks from
306 doc-strings.
307
2d3c217e 3082011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 309
7b7f97e8 310 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
311 * buffer.c (Qclone_number): Remove for now, as it's unused.
312 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
313 (record_buffer): Remove unused local.
314 * frame.c (other_visible_frames, frame_buffer_list): Now static.
315 (set_frame_buffer_list): Remove; unused.
316 * frame.h (other_visible_frames): Remove decl.
317 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
318 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
319 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
320 if HAVE_GPM.
321 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
322 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
323 Define only if HAVE_GPM.
324 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
325 (update_hints_inhibit): Remove; never set. All uses removed.
326 * widgetprv.h (emacsFrameClassRec): Remove decl.
327 * window.c (delete_deletable_window): Now returns void, since it
328 wasn't returning anything.
329 (compare_window_configurations): Remove unused locals.
330 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
331 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
332 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
333 the same widths as pointers. This follows up on the 2011-05-06 patch.
334 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
335 * xterm.h: Likewise.
336 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
337
1384b89e
JB
3382011-06-12 Juanma Barranquero <lekktu@gmail.com>
339
340 * makefile.w32-in: Update dependencies.
341 (LISP_H): Add lib/intprops.h.
342
1100a63c
CY
3432011-06-11 Chong Yidong <cyd@stupidchicken.com>
344
345 * image.c (gif_load): Add animation frame delay to the metadata.
346 (syms_of_image): Use DEFSYM. New symbol `delay'.
347
6198ccd0
MR
3482011-06-11 Martin Rudalics <rudalics@gmx.at>
349
350 * window.c (delete_deletable_window): Re-add.
351 (Fset_window_configuration): Rewrite to handle dead buffers and
352 consequently deletable windows.
353 (window_tree, Fwindow_tree): Remove. Supply functionality in
354 window.el.
355 (compare_window_configurations): Simplify code.
356
b6e3633c
AS
3572011-06-11 Andreas Schwab <schwab@linux-m68k.org>
358
1ab0dee5
AS
359 * image.c (imagemagick_load_image): Fix type mismatch.
360 (Fimagemagick_types): Likewise.
361
b6e3633c
AS
362 * window.h (replace_buffer_in_windows): Declare.
363
9397e56f
MR
3642011-06-11 Martin Rudalics <rudalics@gmx.at>
365
366 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
367 Qclone_number. Remove external declaration of Qdelete_window.
368 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
369 code.
370 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
371 Qbuffer_list_update_hook if allowed.
372 (Fother_buffer): Rewrite doc-string. Major rewrite for new
373 buffer list implementation.
374 (other_buffer_safely): New function.
375 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
376 calls to replace_buffer_in_windows and
377 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
378 if allowed.
379 (record_buffer): Inhibit quitting and rewrite using quittable
380 functions. Run Qbuffer_list_update_hook if allowed.
381 (Frecord_buffer, Funrecord_buffer): New functions.
382 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
383 switch-to-buffer to window.el.
384 (bury-buffer): Move to window.el.
385 (Vbuffer_list_update_hook): New variable.
386
387 * lisp.h (other_buffer_safely): Add prototype in buffer.c
388 section.
389
390 * window.h (resize_frame_windows): Move up in code.
391 (Fwindow_frame): Remove EXFUN.
392 (replace_buffer_in_all_windows): Remove prototype.
393 (replace_buffer_in_windows_safely): Add prototype.
394
395 * window.c: Declare Qdelete_window static again. Move down
396 declaration of select_count.
397 (Fnext_window, Fprevious_window): Rewrite doc-strings.
398 (Fother_window): Move to window.el.
399 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
400 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
401 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
402 window.el.
403 (replace_buffer_in_windows): Implement by calling
404 Qreplace_buffer_in_windows.
405 (replace_buffer_in_all_windows): Remove with some functionality
406 moved into replace_buffer_in_windows_safely.
407 (replace_buffer_in_windows_safely): New function.
408 (select_window_norecord, select_frame_norecord): Move in front
409 of run_window_configuration_change_hook. Remove now obsolete
410 declarations.
411 (Fset_window_buffer): Rewrite doc-string. Call
412 Qrecord_window_buffer.
413 (keys_of_window): Move binding for other-window to window.el.
414
b50691aa
CY
4152011-06-11 Chong Yidong <cyd@stupidchicken.com>
416
417 * dispextern.h (struct image): Replace data member, whose int_val
418 and ptr_val fields were not used by anything, with a single
419 lisp_val object.
420
421 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
422 (gif_clear_image, gif_load, imagemagick_load_image)
423 (gs_clear_image, gs_load): Callers changed.
424
3f754b86
PE
4252011-06-10 Paul Eggert <eggert@cs.ucla.edu>
426
cca69397
PE
427 * buffer.h: Include <time.h>, for time_t.
428 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
429
109e28d0
PE
430 Fix minor problems found by static checking.
431
60737f02
PE
432 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
433
4b66faf3
PE
434 Make identifiers static if they are not used in other modules.
435 * data.c (Qcompiled_function, Qframe, Qvector):
436 * image.c (QimageMagick, Qsvg):
437 * minibuf.c (Qmetadata):
438 * window.c (resize_window_check, resize_root_window): Now static.
439 * window.h (resize_window_check, resize_root_window): Remove decls.
440
109e28d0
PE
441 * window.c (window_deletion_count, delete_deletable_window):
442 Remove; unused.
46a4ce9e
PE
443 (window_body_lines): Now static.
444 (Fdelete_other_windows_internal): Mark vars as initialized.
445 Make sure 'resize_failed' is initialized.
446 (run_window_configuration_change_hook): Rename local to avoid shadowing.
447 (resize_window_apply): Remove unused local.
448 * window.h (delete_deletable_window): Remove decl.
449
109e28d0 450 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
451 (imagemagick_load_image): Fix pointer signedness problem by changing
452 last arg from unsigned char * to char *. All uses changed.
453 Also, fix a local for similar reasons.
454 Remove unused locals. Remove locals to avoid shadowing.
455 (fn_rsvg_handle_free): Remove; unused.
456 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 457 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 458
3f754b86
PE
459 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
460
2547adb1
CY
4612011-06-10 Chong Yidong <cyd@stupidchicken.com>
462
463 * image.c (gif_load): Fix omitted cast error introduced by
464 2011-06-06 change.
465
2c8e37d4
MR
4662011-06-10 Martin Rudalics <rudalics@gmx.at>
467
468 * window.h (resize_proportionally, orig_total_lines)
469 (orig_top_line): Remove from window structure.
470 (set_window_height, set_window_width, change_window_heights)
471 (Fdelete_window): Remove prototypes.
472 (resize_frame_windows): Remove duplicate declaration.
473
440a42e3
EZ
4742011-06-10 Eli Zaretskii <eliz@gnu.org>
475
476 * window.h (resize_frame_windows, resize_window_check)
477 (delete_deletable_window, resize_root_window)
478 (resize_frame_windows): Declare prototypes.
479
480 * window.c (resize_window_apply): Make definition be "static" to
481 match the prototype.
482
562dd5e9
MR
4832011-06-10 Martin Rudalics <rudalics@gmx.at>
484
485 * window.c: Remove declarations of Qwindow_size_fixed,
486 window_min_size_1, window_min_size_2, window_min_size,
487 size_window, window_fixed_size_p, enlarge_window, delete_window.
488 Remove static from declaration of Qdelete_window, it's
489 temporarily needed by Fbury_buffer.
490 (replace_window): Don't assign orig_top_line and
491 orig_total_lines.
492 (Fdelete_window, delete_window): Remove. Window deletion is
493 handled by window.el.
494 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
495 Fdelete_window calls with calls to Qdelete_window.
496 (Fdelete_other_windows): Remove. Deleting other windows is
497 handled by window.el.
498 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
499 handled in window.el.
500 (window_min_size_2, window_min_size_1, window_min_size): Remove.
501 Window minimum sizes are handled in window.el.
502 (shrink_windows, size_window, set_window_height)
503 (set_window_width, change_window_heights, window_height)
504 (window_width, CURBEG, CURSIZE, enlarge_window)
505 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
506 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
507 handled in window.el.
508 (make_dummy_parent): Rename to make_parent_window and give it a
509 second argument horflag.
510 (make_window): Don't set resize_proportionally any more.
511 (Fsplit_window): Remove. Windows are split in window.el.
512 (save_restore_action, save_restore_orig_size)
513 (shrink_window_lowest_first, save_restore_orig_size): Remove.
514 Resize mini windows in window.el.
515 (grow_mini_window, shrink_mini_window): Implement by calling
516 Qresize_root_window_vertically, resize_window_check and
517 resize_window_apply.
518 (saved_window, Fset_window_configuration, save_window_save): Do
519 not handle orig_top_line, orig_total_lines, and
520 resize_proportionally.
521 (window_min_height, window_min_width): Move to window.el.
522 (keys_of_window): Move bindings for delete-other-windows,
523 split-window, delete-window and enlarge-window to window.el.
524
525 * buffer.c: Temporarily extern Qdelete_window.
526 (Fbury_buffer): Temporarily call Qdelete_window instead of
527 Fdelete_window (Fbury_buffer will move to window.el soon).
528
529 * frame.c (set_menu_bar_lines_1): Remove code handling
530 orig_top_line and orig_total_lines.
531
532 * dispnew.c (adjust_frame_glyphs_initially): Don't use
533 set_window_height but set heights directly.
534 (change_frame_size_1): Use resize_frame_windows.
535
536 * xdisp.c (init_xdisp): Don't use set_window_height but set
537 heights directly.
538
539 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
540 resize_frame_windows instead of change_window_heights and run
541 run_window_configuration_change_hook.
542
543 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
544 instead of change_window_heights and run
545 run_window_configuration_change_hook.
546
1a13852e
MR
5472011-06-09 Martin Rudalics <rudalics@gmx.at>
548
549 * window.c (replace_window): Rename second argument REPLACEMENT to
550 NEW. New third argument SETFLAG. Rewrite.
551 (delete_window, make_dummy_parent): Call replace_window with
552 third argument 1.
553 (window_list_1): Move down in code.
554 (run_window_configuration_change_hook): Move set_buffer part
555 before select_frame_norecord part in order to unwind correctly.
556 Rename count1 to count.
557 (recombine_windows, delete_deletable_window, resize_root_window)
558 (Fdelete_other_windows_internal)
559 (Frun_window_configuration_change_hook, make_parent_window)
560 (resize_window_check, resize_window_apply, Fresize_window_apply)
561 (resize_frame_windows, Fsplit_window_internal)
562 (Fdelete_window_internal, Fresize_mini_window_internal): New
563 functions.
564 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
565
f3d1777e
MR
5662011-06-08 Martin Rudalics <rudalics@gmx.at>
567
496e208e
MR
568 * window.h (window): Add some new members to window structure -
569 normal_lines, normal_cols, new_total, new_normal, clone_number,
570 splits, nest, prev_buffers, next_buffers.
571 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 572 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 573
f3d1777e
MR
574 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
575 Remove.
496e208e
MR
576 (make_dummy_parent): Set new members of windows structure.
577 (make_window): Move down in code. Handle new members of window
578 structure.
579 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
580 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
581 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
582 (Fset_window_prev_buffers, Fwindow_next_buffers)
583 (Fset_window_next_buffers, Fset_window_clone_number): New
584 functions.
585 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
586 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
587 Doc-string fixes.
588 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
589 Argument WINDOW can be now internal window too.
590 (Fwindow_use_time): Move up in code.
591 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
592 Rewrite doc-string.
593 (Fset_window_configuration, saved_window)
594 (Fcurrent_window_configuration, save_window_save): Handle new
595 members of window structure.
b9e809c2
MR
596 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
597 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
598 (syms_of_window): New Lisp objects Qrecord_window_buffer,
599 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
600 Qget_mru_window, Qresize_root_window,
601 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
602 Qauto_buffer_name; staticpro them.
f3d1777e 603
abde8f8c
MR
6042011-06-07 Martin Rudalics <rudalics@gmx.at>
605
606 * window.c (Fwindow_total_size, Fwindow_left_column)
607 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
608 (Fwindow_list_1): New functions.
609 (window_box_text_cols): Replace with window_body_cols.
610 (Fwindow_width, Fscroll_left, Fscroll_right): Use
611 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
612 (delete_window, Fset_window_configuration): Call
613 delete_all_subwindows with window as argument.
614 (delete_all_subwindows): Take a window as argument and not a
615 structure. Rewrite.
190b47e6
MR
616 (window_loop): Remove handling of GET_LRU_WINDOW and
617 GET_LARGEST_WINDOW.
618 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
619
620 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
621 window_box_text_cols. delete_all_subwindows now takes a
622 Lisp_Object as argument.
abde8f8c
MR
623
624 * indent.c (compute_motion, Fcompute_motion): Use
625 window_body_cols instead of window_box_text_cols.
626
fa8a67e6
MR
627 * frame.c (delete_frame): Call delete_all_subwindows with root
628 window as argument.
629
a54e3482
DC
6302011-06-07 Daniel Colascione <dan.colascione@gmail.com>
631
632 * fns.c (Fputhash): Document return value.
633
60002bf5
CY
6342011-06-06 Chong Yidong <cyd@stupidchicken.com>
635
636 * image.c (gif_load): Implement gif89a spec "no disposal" method.
637
0c671da6 6382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 639
b862a52a 640 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 641
be44ca6c
PE
642 Check for overflow when converting integer to cons and back.
643 * charset.c (Fdefine_charset_internal, Fdecode_char):
644 Use cons_to_unsigned to catch overflow.
645 (Fencode_char): Use INTEGER_TO_CONS.
646 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
647 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
648 * data.c (long_to_cons, cons_to_long): Remove.
649 (cons_to_unsigned, cons_to_signed): New functions.
650 These signal an error for invalid or out-of-range values.
651 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
652 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
653 * font.c (Ffont_variation_glyphs):
654 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
655 * lisp.h: Include <intprops.h>.
656 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
657 (cons_to_signed, cons_to_unsigned): New decls.
658 (long_to_cons, cons_to_long): Remove decls.
659 * undo.c (record_first_change): Use INTEGER_TO_CONS.
660 (Fprimitive_undo): Use CONS_TO_INTEGER.
661 * xfns.c (Fx_window_property): Likewise.
662 * xselect.c: Include <limits.h>.
663 (x_own_selection, selection_data_to_lisp_data):
664 Use INTEGER_TO_CONS.
665 (x_handle_selection_request, x_handle_selection_clear)
666 (x_get_foreign_selection, Fx_disown_selection_internal)
667 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
668 (lisp_data_to_selection_data): Use cons_to_unsigned.
669 (x_fill_property_data): Use cons_to_signed.
670 Report values out of range.
671
d1f3d2af
PE
672 Check for buffer and string overflow more precisely.
673 * buffer.h (BUF_BYTES_MAX): New macro.
674 * lisp.h (STRING_BYTES_MAX): New macro.
675 * alloc.c (Fmake_string):
676 * character.c (string_escape_byte8):
677 * coding.c (coding_alloc_by_realloc):
678 * doprnt.c (doprnt):
679 * editfns.c (Fformat):
680 * eval.c (verror):
681 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
682 since they may not be the same number.
683 * editfns.c (Finsert_char):
684 * fileio.c (Finsert_file_contents):
685 Likewise for BUF_BYTES_MAX.
686
dd52fcea
PE
687 * image.c: Use ptrdiff_t, not int, for sizes.
688 (slurp_file): Switch from int to ptrdiff_t.
689 All uses changed.
690 (slurp_file): Check that file size fits in both size_t (for
691 malloc) and ptrdiff_t (for sanity and safety).
692
7f9bbdbb
PE
693 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
694 if b->modtime has its maximal value.
695
dfe18f82
PE
696 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
697
84acfcf0
PE
698 Don't assume time_t can fit into int.
699 * buffer.h (struct buffer.modtime): Now time_t, not int.
700 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
701 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
702
ccd9a01a
PE
703 Minor fixes for signed vs unsigned integers.
704 * character.h (MAYBE_UNIFY_CHAR):
705 * charset.c (maybe_unify_char):
706 * keyboard.c (read_char, reorder_modifiers):
707 XINT -> XFASTINT, since the integer must be nonnegative.
708 * ftfont.c (ftfont_spec_pattern):
709 * keymap.c (access_keymap, silly_event_symbol_error):
710 XUINT -> XFASTINT, since the integer must be nonnegative.
711 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
712 since it makes no difference and we prefer signed.
713 * keyboard.c (record_char): Use XUINT when all the neighbors do.
714 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
715 nonnegative.
716
d6d100dd
SM
7172011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
718
719 * window.h (Fwindow_frame): Declare.
720
2b6148e4
PE
7212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
722
723 * alloc.c: Simplify handling of large-request failures (Bug#8800).
724 (SPARE_MEMORY): Always define.
725 (LARGE_REQUEST): Remove.
726 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
727
f230ecc9
MR
7282011-06-06 Martin Rudalics <rudalics@gmx.at>
729
727e958e
MR
730 * lisp.h: Move EXFUNS for Fframe_root_window,
731 Fframe_first_window and Fset_frame_selected_window to window.h.
732
733 * window.h: Move EXFUNS for Fframe_root_window,
734 Fframe_first_window and Fset_frame_selected_window here from
735 lisp.h.
736
737 * frame.c (Fwindow_frame, Fframe_first_window)
738 (Fframe_root_window, Fframe_selected_window)
739 (Fset_frame_selected_window): Move to window.c.
740 (Factive_minibuffer_window): Move to minibuf.c.
741 (Fother_visible_frames_p): New function.
742
743 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
744
f230ecc9
MR
745 * window.c (decode_window, decode_any_window): Move up in code.
746 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
747 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
748 (Fwindow_buffer): Move up and rewrite doc-string.
749 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
750 (Fwindow_prev): New functions.
727e958e
MR
751 (Fwindow_frame): Move here from frame.c. Accept any window as
752 argument.
753 (Fframe_root_window, Fframe_first_window)
754 (Fframe_selected_window): Move here from frame.c. Accept frame
755 or arbitrary window as argument. Update doc-strings.
756 (Fminibuffer_window): Move up in code.
757 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
758 (Fset_frame_selected_window): Move here from frame.c.
759 Marginal rewrite.
727e958e
MR
760 (Fselected_window, select_window, Fselect_window): Move up in
761 code. Minor doc-string fixes.
f230ecc9 762
4d09bcf6
PE
7632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
764
765 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
766 Do not assume that spare memory exists; that assumption is valid
767 only if SYSTEM_MALLOC.
768 (LARGE_REQUEST): New macro, so that the issue of large requests
769 is separated from the issue of spare memory.
770
810928a2
AS
7712011-06-05 Andreas Schwab <schwab@linux-m68k.org>
772
172418ad
AS
773 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
774 format. (Bug#8806)
775
43f862f7
AS
776 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
777
810928a2
AS
778 * xfns.c (x_set_scroll_bar_default_width): Move declarations
779 before statements.
780
a059fe24
JD
7812011-06-05 Jan Djärv <jan.h.d@swipnet.se>
782
783 * gtkutil.c (xg_get_default_scrollbar_width): New function.
784
785 * gtkutil.h: Declare xg_get_default_scrollbar_width.
786
787 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
788 min width by calling x_set_scroll_bar_default_width (Bug#8505).
789
989bf368
JB
7902011-06-05 Juanma Barranquero <lekktu@gmail.com>
791
792 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
793
4b80f674
CY
7942011-06-04 Chong Yidong <cyd@stupidchicken.com>
795
796 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
797 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
798 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
799 New error handlers.
4b80f674
CY
800 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
801 Obey Vx_select_enable_clipboard_manager. Catch errors in
802 x_clipboard_manager_save (Bug#8779).
803 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 804 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 805
99a33b77 8062011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
807
808 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
809
99a33b77 8102011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
811
812 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
813 in the current matrix if keep_current_p is non-zero.
814
8264569d
EZ
8152011-06-04 Eli Zaretskii <eliz@gnu.org>
816
817 * bidi.c (bidi_level_of_next_char): Fix last change.
818
57f97249
EZ
8192011-06-03 Eli Zaretskii <eliz@gnu.org>
820
fec2107c 821 Support bidi reordering of text covered by display properties.
57f97249 822
fec2107c
EZ
823 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
824 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
825 (bidi_cache_search, bidi_cache_iterator_state)
826 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
827 (bidi_level_of_next_char, bidi_move_to_visually_next):
828 Support character positions inside a run of characters covered by a
fec2107c
EZ
829 display string.
830 (bidi_paragraph_init, bidi_resolve_explicit_1)
831 (bidi_level_of_next_char): Call bidi_fetch_char and
832 bidi_fetch_char_advance instead of FETCH_CHAR and
833 FETCH_CHAR_ADVANCE.
834 (bidi_init_it): Initialize new members.
835 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
836 definitions.
837 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
838 instead of using explicit *_CHAR codes.
d6d100dd
SM
839 (bidi_resolve_explicit, bidi_resolve_weak):
840 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
841 bidirectional text is supported only in multibyte buffers.
842 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
843 it to initialize the frame_window_p member of struct bidi_it.
844 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
845 (bidi_resolve_explicit, bidi_resolve_weak)
846 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
847 bidi_it->nchars is non-positive.
848 (bidi_level_of_next_char): Don't try to lookup the cache for the
849 next/previous character if nothing is cached there yet, or if we
850 were just reseat()'ed to a new position.
c40e2fb2 851
0e14fe90
EZ
852 * xdisp.c (set_cursor_from_row): Set start and stop points
853 according to the row's direction when priming the loop that looks
854 for the glyph on which to display cursor.
855 (single_display_spec_intangible_p): Function deleted.
856 (display_prop_intangible_p): Reimplement to call
857 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
858 Accept 3 additional arguments needed by handle_display_spec.
859 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
860 values: lists, `(when COND...)' forms, etc.
861 (single_display_spec_string_p): Support property values that are
862 lists with the argument STRING its top-level element.
863 (display_prop_string_p): Fix the condition for processing a
864 property that is a list to be consistent with handle_display_spec.
fec2107c 865 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
866 last portion of handle_display_prop.
867 (compute_display_string_pos): Accept additional argument
868 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
869 value of a `display' property is a "replacing spec".
870 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
871 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
872 the display property, but just return a value indicating whether
873 the display property will replace the characters it covers.
874 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
875 frame_window_p members of struct bidi_it.
d6d100dd
SM
876 (compute_display_string_pos, compute_display_string_end):
877 New functions.
fec2107c
EZ
878 (push_it): Accept second argument POSITION, where pop_it should
879 jump to continue iteration.
880 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 881
fec2107c
EZ
882 * keyboard.c (adjust_point_for_property): Adjust the call to
883 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
884
885 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
886 (bidi_init_it): Update prototypes.
887 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
888 (compute_display_string_pos, compute_display_string_end):
889 Declare prototypes.
fec2107c
EZ
890 (struct bidi_it): New members nchars and disp_pos. ch_len is now
891 EMACS_INT.
fc6f18ce 892
40087514 8932011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 894
57f53182
PE
895 Malloc failure behavior now depends on size of allocation.
896 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
897 * lisp.h: Change signatures accordingly.
898 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
899 All callers changed. (Bug#8762)
900
901 * gnutls.c: Use Emacs's memory allocators.
902 Without this change, the gnutls library would invoke malloc etc.
903 directly, which causes problems on non-SYNC_INPUT hosts, and which
904 runs afoul of improving memory_full behavior. (Bug#8761)
905 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
906 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
907 xfree instead of the default malloc, realloc, free.
908 (Fgnutls_boot): No need to check for memory allocation failure,
909 since xmalloc does that for us.
910
ac32cd99 911 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
912 * category.c (hash_get_category_set):
913 * ccl.c (ccl_driver):
914 * charset.c (Fdefine_charset_internal):
915 * charset.h (struct charset.hash_index):
916 * composite.c (get_composition_id, gstring_lookup_cache)
917 (composition_gstring_put_cache):
918 * composite.h (struct composition.hash_index):
919 * dispextern.h (struct image.hash):
920 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
921 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
922 (hashfn_equal, hashfn_user_defined, make_hash_table)
923 (maybe_resize_hash_table, hash_lookup, hash_put)
924 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
925 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
926 (Fsxhash, Fgethash, Fputhash, Fmaphash):
927 * image.c (make_image, search_image_cache, lookup_image)
928 (xpm_put_color_table_h):
929 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 930 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
931 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
932 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
933 * alloc.c (allocate_vectorlike):
934 Check for overflow in vector size calculations.
935 * ccl.c (ccl_driver):
936 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
937 * fns.c, image.c: Remove unnecessary static decls that would otherwise
938 need to be updated by these changes.
40087514
PE
939 * fns.c (make_hash_table, maybe_resize_hash_table):
940 Check for integer overflow with large hash tables.
0de4bb68
PE
941 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
942 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
943 (SXHASH_REDUCE): New macro.
944 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
945 Use it instead of discarding useful hash info with large hash values.
946 (sxhash_float): New function.
947 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
948 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
949 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
950 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
951 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
952 Adjust signatures to match updated version of code.
953 (consing_since_gc): Now EMACS_INT, since a single hash table can
954 use more than INT_MAX bytes.
955
698d32e2
DN
9562011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
957
958 Make it possible to build with GCC-4.6+ -O2 -flto.
959
960 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
961
fd6fa53f
SM
9622011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
963
964 * minibuf.c (get_minibuffer, read_minibuf_unwind):
965 Call minibuffer-inactive-mode.
966
864db017
JB
9672011-05-31 Juanma Barranquero <lekktu@gmail.com>
968
969 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
970 Update dependencies.
971
2ad0baf4
DN
9722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
973
974 * data.c (init_data): Remove code for UTS, this system is not
975 supported anymore.
976
4fcc2638
DN
9772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
978
979 Don't force ./temacs to start in terminal mode.
980
981 * frame.c (make_initial_frame): Initialize faces in all cases, not
982 only when CANNOT_DUMP is defined.
983 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
984
c56e0fd5
DN
9852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
986
987 * dispnew.c (add_window_display_history): Use const for the string
988 pointer. Remove declaration, not needed.
989
333d54da 9902011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 991
55d4c1b2 992 Use 'inline', not 'INLINE'.
333d54da 993 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
994 * alloc.c, fontset.c (INLINE): Remove.
995 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
996 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
997 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
998 * gmalloc.c (register_heapinfo): Use inline unconditionally.
999 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1000
738db178
DN
10012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1002
1003 Make it possible to run ./temacs.
1004
1005 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1006 syms_of_callproc does the same thing. Remove test for
1007 "initialized", do it in the caller.
1008 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1009
620c53a6
SM
10102011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1011
1012 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1013 (read_minibuf): Use get_minibuffer.
1014 (syms_of_minibuf): Use DEFSYM.
1015 (Qmetadata): New var.
1016 * data.c (Qbuffer): Don't make it static.
1017 (syms_of_data): Use DEFSYM.
1018
e003a292
PE
10192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1020
1021 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1022 (CCL_CODE_MIN): New macro.
1023
ed008a6d
PE
10242011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1025
3687c2ef
PE
1026 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1027
ed008a6d
PE
1028 * eval.c (Qdebug): Now static.
1029 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1030 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1031 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1032
d66c4c7c
CY
10332011-05-29 Chong Yidong <cyd@stupidchicken.com>
1034
1035 * image.c: Various fixes to ImageMagick code comments.
1036 (Fimagemagick_types): Doc fix.
1037
5fbc2025
PE
10382011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1039
0196f88a
PE
1040 Minor fixes prompted by GCC 4.6.0 warnings.
1041
1042 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1043
5fbc2025
PE
1044 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1045 (x_clipboard_manager_save_all): Move extern decl to ...
1046 * xterm.h: ... here, so that it can be checked for consistency.
1047
1dd3c2d9
CY
10482011-05-29 Chong Yidong <cyd@stupidchicken.com>
1049
1050 * xselect.c (x_clipboard_manager_save_frame)
1051 (x_clipboard_manager_save_all): New functions.
1052 (Fx_clipboard_manager_save): Lisp function deleted.
1053
1054 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1055 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1056
1057 * xterm.h: Update prototype.
1058
5ba6571d
WX
10592011-05-28 William Xu <william.xwl@gmail.com>
1060
1061 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1062 exiting (Bug#8239).
1063
3eaff834
JM
10642011-05-28 Jim Meyering <meyering@redhat.com>
1065
e1900994 1066 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1067 * fns.c (to_uchar): Define.
1068 (crypto_hash_function): Use it to convert some newly-signed
1069 variables to unsigned, to avoid sign-extension bugs. For example,
1070 without this change, (md5 "truc") would evaluate to
1071 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1072 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1073 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1074
0f6990a7
PE
10752011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1076
1077 Integer overflow fixes.
c8a9ca5a 1078
08686060
PE
1079 * dbusbind.c: Serial number integer overflow fixes.
1080 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1081 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1082 to hold a serial number that is too large for a fixnum.
1083 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1084 Check for serial numbers out of range. Decode any serial number
59568bf0 1085 that was so large that it became a float. (Bug#8722)
08686060 1086
2d1fc3c7
PE
1087 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1088 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1089 Use XFASTINT rather than XUINT when numbers are nonnegative.
1090 (xd_append_arg, Fdbus_method_return_internal):
1091 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1092 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1093 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1094 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1095 (Bug#8722)
2d1fc3c7 1096
c8a9ca5a
PE
1097 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1098
519e1d69
PE
1099 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1100
30569699
PE
1101 ccl: add integer overflow checks
1102 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1103 (IN_INT_RANGE): New macros.
1104 (ccl_driver): Use them to check for integer overflow when
1105 decoding a CCL program. Many of the new checks are whether XINT (x)
1106 fits in int; it doesn't always, on 64-bit hosts. The new version
1107 doesn't catch all possible integer overflows, but it's an
847044ea 1108 improvement. (Bug#8719)
30569699 1109
c11285dc
PE
1110 * alloc.c (make_event_array): Use XINT, not XUINT.
1111 There's no need for unsigned here.
1112
fdccd48e
PE
1113 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1114 This follows up to the 2011-05-06 change that substituted uintptr_t
1115 for EMACS_INT. This case wasn't caught back then.
1116
37910ab2
PE
1117 Rework Fformat to avoid integer overflow issues.
1118 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1119 now (part of C89). Include <verify.h>.
1120 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1121 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1122 (Fformat): Avoid the prepass trying to compute sizes; it was only
1123 approximate and thus did not catch overflow reliably. Instead, walk
1124 through the format just once, formatting and computing sizes as we go,
1125 checking for integer overflow at every step, and allocating a larger
1126 buffer as needed. Keep track separately whether the format is
1127 multibyte. Keep only the most-recently calculated precision, rather
1128 than them all. Record whether each argument has been converted to
1129 string. Use EMACS_INT, not int, for byte and char and arg counts.
1130 Support field widths and precisions larger than INT_MAX. Avoid
1131 sprintf's undefined behavior with conversion specifications such as %#d
1132 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1133 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1134 formatting out-of-range floating point numbers with int
1135 formats. (Bug#8668)
1136
2e6578fb
PE
1137 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1138
0ae6bdee
PE
1139 * data.c: Avoid integer truncation in expressions involving floats.
1140 * data.c: Include <intprops.h>.
1141 (arith_driver): When there's an integer overflow in an expression
1142 involving floating point, convert the integers to floating point
1143 so that the resulting value does not suffer from catastrophic
1144 integer truncation. For example, on a 64-bit host (* 4
1145 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1146 Do not rely on undefined behavior after integer overflow.
1147
de883a70
PE
1148 merge count_size_as_multibyte, parse_str_to_multibyte
1149 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1150 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1151 Check for integer overflow.
1152 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1153 since it's now a duplicate of the other. This is more of
1154 a character than a buffer op, so better that it's in character.c.
1155 * fns.c, print.c: Adjust to above changes.
1156
2ff916cb
PE
11572011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1158
1159 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1160
f1b54466
PE
11612011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1162
fb1ac845
PE
1163 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1164 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1165 (x_clipboard_manager_save): Now static.
1166 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1167
f1b54466
PE
1168 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1169 (crypto_hash_function): Now static.
1170 Fix pointer signedness problems. Avoid unnecessary initializations.
1171
a9f737ee
CY
11722011-05-27 Chong Yidong <cyd@stupidchicken.com>
1173
1174 * termhooks.h (Vselection_alist): Make it terminal-local.
1175
1176 * terminal.c (create_terminal): Initialize it.
1177
1178 * xselect.c: Support for clipboard managers.
1179 (Vselection_alist): Move to termhooks.h as terminal-local var.
1180 (LOCAL_SELECTION): New macro.
1181 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1182 (symbol_to_x_atom): Remove gratuitous arg.
1183 (x_handle_selection_request, lisp_data_to_selection_data)
1184 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1185 (x_own_selection, x_get_local_selection, x_convert_selection):
1186 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1187 (some_frame_on_display): Delete unused function.
1188 (Fx_own_selection_internal, Fx_get_selection_internal)
1189 (Fx_disown_selection_internal, Fx_selection_owner_p)
1190 (Fx_selection_exists_p): New optional frame arg.
1191 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1192 (x_handle_selection_clear): Don't treat other terminals with the
1193 same keyboard specially. Use the terminal-local Vselection_alist.
1194 (x_clear_frame_selections): Use Frun_hook_with_args.
1195
1196 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1197
1198 * xterm.h: Add support for those atoms.
1199
e067f0c1
CY
12002011-05-26 Chong Yidong <cyd@stupidchicken.com>
1201
1202 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1203 (converted_selections, conversion_fail_tag): New global variables.
1204 (x_selection_request_lisp_error): Free the above.
1205 (x_get_local_selection): Remove unnecessary code.
1206 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1207 of converted selections stored in converted_selections.
1208 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1209 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1210 (x_convert_selection): New function.
1211 (x_handle_selection_event): Simplify.
1212 (x_get_foreign_selection): Don't ignore incoming requests while
1213 waiting for an answer; this will fail when we implement
1214 SAVE_TARGETS, and seems unnecessary anyway.
1215 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1216 (Vx_sent_selection_functions): Doc fix.
1217
0f4aebc0
LL
12182011-05-26 Leo Liu <sdl.web@gmail.com>
1219
1220 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1221
e61124cd
YM
12222011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1223
1224 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1225
1226 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1227 for fringe update if it has periodic bitmap.
1228 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1229 and fringe_bitmap_periodic_p.
1230
1231 * fringe.c (get_fringe_bitmap_data): New function.
1232 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1233 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1234 row. Mark glyph row for fringe update if periodicity changed.
1235
1236 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1237 for fringe update unless it has periodic bitmap.
1238
f16d9837
KH
12392011-05-25 Kenichi Handa <handa@m17n.org>
1240
1241 * xdisp.c (get_next_display_element): Set correct it->face_id for
1242 a static composition.
1243
e1b90ef6
LL
12442011-05-24 Leo Liu <sdl.web@gmail.com>
1245
1246 * deps.mk (fns.o):
1247 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1248
1249 * fns.c (crypto_hash_function, Fsha1): New function.
1250 (Fmd5): Use crypto_hash_function.
1251 (syms_of_fns): Add Ssha1.
1252
7400048f
PE
12532011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1254
1255 * gnutls.c: Remove unused macros.
1256 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1257 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1258 Remove macros that are defined and never used.
1259 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1260
abb71cf4
CY
12612011-05-22 Chong Yidong <cyd@stupidchicken.com>
1262
1263 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1264 (Fx_get_selection_internal): Minor cleanup.
1265 (Fx_own_selection_internal): Rename arguments for consistency with
1266 select.el.
1267
6307db39
PE
12682011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1269
1270 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1271
f3d4e0a4
CY
12722011-05-22 Chong Yidong <cyd@stupidchicken.com>
1273
1274 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1275
4d8ade89
YM
12762011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1277
1278 * dispnew.c (scrolling_window): Don't exclude the case that the
1279 last enabled row in the desired matrix touches the bottom boundary.
1280
32078c8d
GM
12812011-05-21 Glenn Morris <rgm@gnu.org>
1282
1283 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1284 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1285 and add some more files.
32078c8d 1286
7285dc67
EZ
12872011-05-20 Eli Zaretskii <eliz@gnu.org>
1288
1289 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1290 report_file_error introduced by the change from 2011-05-07.
1291
89d1bd22
PE
12922011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 * systime.h (Time): Define only if emacs is defined.
1295 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1296 where the include path doesn't have X11/X.h by default. See
1297 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1298
e23640bb 12992011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1300
1301 * composite.c (find_automatic_composition): Fix previous change.
1302
b9704ad9
GM
13032011-05-20 Glenn Morris <rgm@gnu.org>
1304
1305 * lisp.mk: New file, split from Makefile.in.
1306 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1307 (shortlisp): Remove.
1308 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1309
4a720484
GM
13102011-05-19 Glenn Morris <rgm@gnu.org>
1311
1312 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1313 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1314 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1315 (lisp): Set the order to that of loadup.el.
1316 (shortlisp): Make it a copy of $lisp.
1317 (SOME_MACHINE_LISP): Remove.
1318 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1319 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1320
a28d4396
KH
13212011-05-18 Kenichi Handa <handa@m17n.org>
1322
1323 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1324 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1325 (find_automatic_composition): Mostly rewrite for efficiency.
1326
a2b1fa8e
JB
13272011-05-18 Juanma Barranquero <lekktu@gmail.com>
1328
1329 * makefile.w32-in: Update dependencies.
1330
8e1f5610
CS
13312011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1332
1333 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1334 revision 104625).
1335
7025ee00 13362011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1337
cdfa6eab
PE
1338 Fix some integer overflow issues, such as string length overflow.
1339
06d6db33
PE
1340 * insdel.c (count_size_as_multibyte): Check for string overflow.
1341
2b4560a8
PE
1342 * character.c (lisp_string_width): Check for string overflow.
1343 Use EMACS_INT, not int, for string indexes and lengths; in
1344 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1345 the resulting string length overflows an EMACS_INT; instead,
1346 report a string overflow if no precision given. When checking for
1347 precision exhaustion, use a check that cannot possibly have
1348 integer overflow. (Bug#8675)
1349 * character.h (lisp_string_width): Adjust to new signature.
1350
cb93f9be
PE
1351 * alloc.c (string_overflow): New function.
1352 (Fmake_string): Use it. This doesn't change behavior, but saves
1353 a few bytes and will simplify future changes.
1354 * character.c (string_escape_byte8): Likewise.
1355 * lisp.h (string_overflow): New decl.
1356
1a1f3366
PE
1357 Fixups, following up to the user-interface timestamp change.
1358 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1359 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1360 * msdos.c (mouse_get_pos): Likewise.
1361 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1362 * w32gui.h (Time): Define by including "systime.h" rather than by
1363 declaring it ourselves. (Bug#8664)
1364
d4e3e4d3
PE
1365 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1366 * image.c (clear_image_cache): Likewise.
1367
f6a24d19
PE
1368 * term.c (term_mouse_position): Don't assume time_t wraparound.
1369
08dc5ae6
PE
1370 Be more systematic about user-interface timestamps.
1371 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1372 and sometimes 'EMACS_UINT', to represent these timestamps.
1373 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1374 This makes the code easier to follow, and makes it easier to catch
1375 integer overflow bugs such as Bug#8664.
1376 * frame.c (Fmouse_position, Fmouse_pixel_position):
1377 Use Time, not unsigned long, for user-interface timestamps.
1378 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1379 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1380 * keyboard.h (last_event_timestamp): Likewise.
1381 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1382 * menu.h (xmenu_show): Likewise.
1383 * term.c (term_mouse_position): Likewise.
1384 * termhooks.h (struct input_event.timestamp): Likewise.
1385 (struct terminal.mouse_position_hook): Likewise.
1386 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1387 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1388 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1389 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1390 what it was before.
1391 * menu.h, termhooks.h: Include "systime.h", for Time.
1392
8e55734a
PE
1393 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1394 Don't assume that the difference between two unsigned long values
1395 can fit into an integer. At this point, we know button_down_time
1396 <= event->timestamp, so the difference must be nonnegative, so
1397 there's no need to cast the result if double-click-time is
1398 nonnegative, as it should be; check that it's nonnegative, just in
1399 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1400 apart (about 25 days). (Bug#8664)
8e55734a 1401
841f1b75 1402 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1403 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1404
3e26f69c
PE
1405 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1406 that always fit in int. Use a sentinel instead of a counter, to
1407 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1408 * frame.h (struct frame): Use int for menu_bar_items_used
1409 instead of EMACS_INT, since it always fits in int.
3e26f69c 1410
5cc152c0
PE
1411 * menu.c (grow_menu_items): Check for int overflow.
1412
d89eb65e
PE
1413 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1414
5235bd3e
PE
1415 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1416 Before, the code was not consistent. These values cannot exceed
1417 2**31 - 1 so there's no need to make them unsigned.
1418 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1419 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1420 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1421 as modifiers.
1422 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1423
bc827e23
PE
1424 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1425 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1426 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1427 presumably because the widths might not match.
1428
78eb494e
PE
1429 * window.c (size_window): Avoid needless test at loop start.
1430
04f2d78b
CB
14312011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1432
1433 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1434
d2fc7e3d 14352011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1436
1437 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1438
d2fc7e3d 14392011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1440
1441 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1442 `width' to `bar_area_x' and `bar_area_width', respectively.
1443 (x_scroll_run): Take account of fringe background extension.
1444
04f2d78b
CB
1445 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1446 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1447 `bar_area_width', respectively.
1448 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1449 background extension.
1450
79b70037
GM
14512011-05-10 Jim Meyering <meyering@redhat.com>
1452
1453 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1454
2f142cc5
JB
14552011-05-10 Juanma Barranquero <lekktu@gmail.com>
1456
1457 * image.c (Finit_image_library): Return t for built-in image types,
1458 like pbm and xbm. (Bug#8640)
1459
57679c86
AS
14602011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1461
1462 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1463
888c9e86
EZ
14642011-05-07 Eli Zaretskii <eliz@gnu.org>
1465
b0512a1d
EZ
1466 * w32console.c (Fset_screen_color): Doc fix.
1467 (Fget_screen_color): New function.
1468 (syms_of_ntterm): Defsubr it.
1469
7285dc67
EZ
1470 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1471 unlink the temporary file if Fcall_process didn't create it in the
1472 first place.
1473 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1474 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1475 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1476 cue to call_process_cleanup not to close that handle.
1477
4d3fcc8e
BK
14782011-05-07 Ben Key <bkey76@gmail.com>
1479
1480 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1481 one of two shell specific rules, either bootstrap-temacs-CMD or
1482 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1483 to the previous implementation of the bootstrap-temacs rule.
1484 The bootstrap-temacs-CMD rule is similar to the previous
1485 implementation of the bootstrap-temacs rule except that it
1486 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1487 variable.
1488
1489 These changes, along with some changes to nt/configure.bat,
1490 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1491 earlier fix to add support for --cflags and --ldflags options
1492 that include quotes so that it works whether make uses cmd or
1493 sh as the shell.
1494
b4289b64
MA
14952011-05-06 Michael Albinus <michael.albinus@gmx.de>
1496
1497 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1498 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1499 is a constant.
1500 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1501 a string. Handle both cases.
1502 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1503 (Fdbus_register_method): Use Qinvalid_function.
1504
af4c0e28
JB
15052011-05-06 Juanma Barranquero <lekktu@gmail.com>
1506
1507 * makefile.w32-in: Update dependencies.
1508 (LISP_H): Add inttypes.h and stdin.h.
1509 (PROCESS_H): Add unistd.h.
1510
c51453d9
EZ
15112011-05-06 Eli Zaretskii <eliz@gnu.org>
1512
1513 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1514 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1515
8ff0ac3c 15162011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1517
4c4b566b
PE
1518 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1519
aab2b9b5
PE
1520 * term.c (vfatal): Remove stray call to va_end.
1521 It's not needed and the C Standard doesn't allow it here anyway.
1522
c378da0b
PE
1523 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1524 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1525
288b08c7
PE
1526 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1527 bytes.
1528
e3601888
PE
1529 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1530
db6c0e74
PE
1531 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1532
dd5963ea
PE
1533 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1534
88c9450f
PE
1535 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1536
2f9442b8
PE
1537 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1538
c032b5f8
PE
1539 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1540 * charset.c (Fdefine_charset_internal): Don't initialize
1541 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1542 32-bit int (Bug#8600).
a108c10b
PE
1543
1544 * lread.c (read_integer): Be more consistent with string-to-number.
1545 Use string_to_number to do the actual conversion; this avoids
1546 rounding errors and fixes some other screwups. Without this fix,
1547 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1548 (digit_to_number): Move earlier, for benefit of read_integer.
1549 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1550 not a digit in any supported base. (Bug#8602)
a108c10b 1551
ad5f9eea
PE
1552 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1553
aec1708a
PE
1554 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1555 to match comment at start of function. This also removes a
1556 GCC warning about overflow in a 32+64-bit port.
1557
47be4ab5
PE
1558 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1559
371cac43
PE
1560 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1561 Reported by Stefan Monnier in
1562 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1563 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1564 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1565
d01a7826
PE
1566 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1567 (EMACS_UINTPTR): Likewise, with uintptr_t.
1568
7fd47d5c
PE
1569 * lisp.h: Prefer 64-bit EMACS_INT if available.
1570 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1571 on 32-bit hosts that have 64-bit int, so that they can access
1572 large files.
122b0c86
PE
1573 However, temporarily disable this change unless the temporary
1574 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1575
8727937b
PE
1576 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1577
8ac068ac
PE
1578 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1579 This removes an assumption that EMACS_INT and long are the same
1580 width as pointers. The assumption is true for Emacs porting targets
1581 now, but we want to make other targets possible.
1582 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1583 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1584 In the rest of the code, change types of integers that hold casted
1585 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1586 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1587 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1588 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1589 No need to cast type when ORing.
1590 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1591 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1592 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1593 assume EMACS_INT is the same width as char *.
1594 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1595 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1596 Remove no-longer-needed casts.
1597 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1598 (xg_tool_bar_help_callback, xg_make_tool_item):
1599 Use EMACS_INTPTR to hold an integer
1600 that will be cast to void *; this can avoid a GCC warning
1601 if EMACS_INT is not the same width as void *.
1602 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1603 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1604 (current_message_1, set_message_1):
1605 Use a local to convert to proper width without a cast.
1606 * xmenu.c (dialog_selection_callback): Likewise.
1607
ede49d71
PE
1608 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1609 Also, don't assume VALBITS / RAND_BITS is less than 5,
1610 and don't rely on undefined behavior when shifting a 1 left into
1611 the sign bit.
1612 * lisp.h (get_random): Change signature to match.
1613
2f30ecd0
PE
1614 * lread.c (hash_string): Use size_t, not int, for hash computation.
1615 Normally we prefer signed values; but hashing is special, because
1616 it's better to use unsigned division on hash table sizes so that
1617 the remainder is nonnegative. Also, size_t is the natural width
1618 for hashing into memory. The previous code used 'int', which doesn't
1619 retain enough info to hash well into very large tables.
1620 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1621
2a866e7b
PE
1622 * dbusbind.c: Don't possibly lose pointer info when converting.
1623 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1624 Use XPNTR rather than XHASH, so that the high-order bits of
1625 the pointer aren't lost when converting through void *.
1626
51639eac
PE
1627 * eval.c (Fautoload): Don't double-shift a pointer.
1628
92394119
PE
1629 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1630
dbdb9a7c
JB
16312011-05-06 Juanma Barranquero <lekktu@gmail.com>
1632
1633 * gnutls.c (DEF_GNUTLS_FN):
1634 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1635
db7a0b4f
AS
16362011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1637
1638 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1639 marker. (Bug#8610)
1640
f7ff1b0f 16412011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1642
1643 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1644 New version that can reserve upto 2GB of heap space.
1645
f7ff1b0f 16462011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1647
1648 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1649
639c109b
TZ
16502011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1651
1652 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1653 `gnutls_certificate_set_x509_key_file'.
1654
d2127135
JB
16552011-05-05 Juanma Barranquero <lekktu@gmail.com>
1656
1657 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1658 Update dependencies.
1659
e968f4f3
JB
16602011-05-04 Juanma Barranquero <lekktu@gmail.com>
1661
1662 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1663 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1664 Remove unused parameter `fildes'.
1665 * process.c (read_process_output, send_process): Don't pass it.
1666
84d358f0
JB
16672011-05-04 Juanma Barranquero <lekktu@gmail.com>
1668
1669 Fix previous change: the library cache is defined in w32.c.
1670 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1671 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1672
0898ca10
JB
16732011-05-04 Juanma Barranquero <lekktu@gmail.com>
1674
1675 Implement dynamic loading of GnuTLS on Windows.
1676
1677 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1678 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1679 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1680 Declare.
1681
1682 * gnutls.c (Qgnutls_dll): Define.
1683 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1684 (gnutls_*): Declare function pointers.
1685 (init_gnutls_functions): New function to initialize function pointers.
1686 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1687 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1688 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1689 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1690 (emacs_gnutls_write, emacs_gnutls_read)
1691 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1692 (Fgnutls_available_p): New function.
1693 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1694 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1695 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1696
1697 * image.c: Include w32.h.
1698 (Vimage_type_cache): Delete.
1699 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1700 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1701 (w32_delayed_load): Move to w32.c.
1702
1703 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1704
1705 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1706 (w32_delayed_load): Move from image.c. When loading a library, record
1707 its filename in the :loaded-from property of the library id.
1708 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1709 Initialize and staticpro them.
1710 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1711
1712 * process.c: Include lisp.h before w32.h, not after.
1713 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1714 instead of gnutls_record_check_pending.
1715
1716 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1717
ff4de4aa
TZ
17182011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1719
1720 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1721 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1722 as passed in.
1723
abe95abb
JD
17242011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1725
1726 * xterm.c (x_set_frame_alpha): Do not set property on anything
1727 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1728
e16e55d4
JB
17292011-05-02 Juanma Barranquero <lekktu@gmail.com>
1730
1731 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1732
bafcf6a5
JB
17332011-05-02 Juanma Barranquero <lekktu@gmail.com>
1734
1735 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1736 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1737 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1738 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1739 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1740 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1741 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1742 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1743 (Qgnutls_bootprop_callbacks_verify): Make static.
1744
e7a6747f
AS
17452011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1746
19ed11ba
AS
1747 * callproc.c: Indentation fixup.
1748
e7a6747f 1749 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1750 (wait_for_termination, interruptible_wait_for_termination):
1751 Move after wait_for_termination_1.
e7a6747f 1752
1ef14cb4
LMI
17532011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1754
1755 * sysdep.c (interruptible_wait_for_termination): New function
1756 which is like wait_for_termination, but allows keyboard
1757 interruptions.
1758
1759 * callproc.c (Fcall_process): Add (:file "file") as an option for
1760 the STDOUT buffer.
1761 (Fcall_process_region): Ditto.
1762
330d880c
EZ
17632011-04-30 Eli Zaretskii <eliz@gnu.org>
1764
8db90b73
EZ
1765 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1766 rather than `XVECTOR (FOO)->size'.
1767
330d880c
EZ
1768 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1769 inttypes.h, as a gnulib replacement is used if it not available in
1770 system headers.
1771
15cbd324
EZ
17722011-04-21 Eli Zaretskii <eliz@gnu.org>
1773
1774 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1775 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1776 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1777
1778 * coding.c (coding_alloc_by_realloc): Error out if destination
1779 will grow beyond MOST_POSITIVE_FIXNUM.
1780 (decode_coding_emacs_mule): Abort if there isn't enough place in
1781 charbuf for the composition carryover bytes. Reserve an extra
1782 space for up to 2 characters produced in a loop.
1783 (decode_coding_iso_2022): Abort if there isn't enough place in
1784 charbuf for the composition carryover bytes.
1785
17862011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1787
ae940cca
EZ
1788 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1789 aborting when %lld or %lll format is passed.
1790 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1791 %llo or %llx format is passed. (Bug#8545)
1792
03ab8921
EZ
1793 * window.c (window_scroll_line_based): Use a marker instead of
1794 simple variables to record original value of point. (Bug#7952)
1795
afda1437
EZ
1796 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1797 produced by %s or %c overflows available buffer space. (Bug#8545)
1798
f76dee0c
PE
17992011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1800
1801 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1802 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1803
fdc5744d
JB
18042011-04-28 Juanma Barranquero <lekktu@gmail.com>
1805
1806 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1807
638f053a
JB
18082011-04-28 Juanma Barranquero <lekktu@gmail.com>
1809
1810 * keyboard.c (Qdelayed_warnings_hook): Define.
1811 (command_loop_1): Run `delayed-warnings-hook'
1812 if Vdelayed_warnings_list is non-nil.
1813 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1814 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1815
d178f871
EZ
18162011-04-28 Eli Zaretskii <eliz@gnu.org>
1817
1818 * doprnt.c (doprnt): Don't return value smaller than the buffer
1819 size if the message was truncated. (Bug#8545).
1820
b124fd93
JB
18212011-04-28 Juanma Barranquero <lekktu@gmail.com>
1822
1823 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1824 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1825
e810457d
PE
18262011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1827
1828 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1829
ea51cceb
JB
18302011-04-27 Juanma Barranquero <lekktu@gmail.com>
1831
1832 * makefile.w32-in: Update dependencies.
1833
94dcfacf
EZ
18342011-04-27 Eli Zaretskii <eliz@gnu.org>
1835
1836 Improve `doprnt' and its usage. (Bug#8545)
1837 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1838 `format_end'. Remove support for %l as a conversion specifier.
1839 Don't use xrealloc. Improve diagnostics when the %l size modifier
1840 is used. Update the commentary.
1841
1842 * eval.c (verror): Simplify calculation of size_t.
1843
1844 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1845 messages.
1846
f61f41d7
PE
18472011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1848
1849 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1850 change.
1851
96fb4434
PE
18522011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1853
1854 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1855 This makes this file independent of the recent pseudovector change.
1856
671875da 18572011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1858
69e9b5a3
PE
1859 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1860
b5f869a7 1861 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1862 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1863 Remove unused local.
c8926152 1864 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1865
841a1577 1866 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1867 GCC 4.6.0 optimizes based on type-based alias analysis.
1868 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1869 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1870 != &v->size, and therefore "v->size = 1; b->size = 2; return
1871 v->size;" must therefore return 1. This assumption is incorrect
1872 for Emacs, since it type-puns struct Lisp_Vector * with many other
1873 types. To fix this problem, this patch adds a new type struct
f904488f 1874 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1875 and pseudovectors, and helps optimizing compilers not get fooled
1876 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1877 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1878 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1879 the size member.
eab3844f
PE
1880 (XSETPVECTYPE): Rewrite in terms of new macro.
1881 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1882 This is a bit clearer, and further avoids the possibility of
1883 undesirable aliasing.
1884 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1885 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1886 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1887 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1888 (ASIZE): Now uses header.size rather than size.
1889 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1890 to avoid the hassle of writing XVECTOR (foo)->header.size.
1891 (struct vectorlike_header): New type.
eab3844f
PE
1892 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1893 object, to help avoid aliasing.
1894 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1895 (SUBRP): Likewise, since Lisp_Subr is a special case.
1896 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1897 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1898 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1899 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1900 changed to be "header.size" and "header.next".
1901 * buffer.h (struct buffer): Likewise.
1902 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1903 * frame.h (struct frame): Likewise.
1904 * process.h (struct Lisp_Process): Likewise.
1905 * termhooks.h (struct terminal): Likewise.
1906 * window.c (struct save_window_data, struct saved_window): Likewise.
1907 * window.h (struct window): Likewise.
1908 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1909 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1910 * buffer.c (init_buffer_once): Likewise.
1911 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1912 special case.
1913 * process.c (Fformat_network_address): Use local var for size,
1914 for brevity.
1915
0df1eac5
PE
1916 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1917
847ab9d1 1918 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1919 * data.c (atof): Remove decl; no longer used or needed.
1920 (digit_to_number): Move to lread.c.
1921 (Fstring_to_number): Use new string_to_number function, to be
1922 consistent with how the Lisp reader treats infinities and NaNs.
1923 Do not assume that floating-point numbers represent EMACS_INT
1924 without losing information; this is not true on most 64-bit hosts.
1925 Avoid double-rounding errors, by insisting on integers when
1926 parsing non-base-10 numbers, as the documentation specifies.
1927 * lisp.h (string_to_number): New decl, replacing ...
1928 (isfloat_string): Remove.
bc0a5c13 1929 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1930 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1931 appears to have been a coding error. Similarly, do not accept
1932 strings like +-1e0 as floating point numbers. Do not report
1933 overflow for integer overflows unless the base is not 10 which
1934 means we have no simple and reliable way to continue.
1935 Break out the floating-point parsing into a new
1936 function string_to_number, so that Fstring_to_number parses
1937 floating point numbers consistently with the Lisp reader.
04f2d78b 1938 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1939 (E_CHAR, EXP_INT): Remove, replacing with ...
1940 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1941 (string_to_number): New function, replacing isfloat_string.
1942 This function checks for valid syntax and produces the resulting
1943 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1944 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1945 so that overflow for non-base-10 numbers is reported only when
1946 there's no portable and simple way to convert to floating point.
452f4150 1947
67769ffc
PE
1948 * textprop.c (set_text_properties_1): Rewrite for clarity,
1949 and to avoid GCC warning about integer overflow.
1950
c20db43f
PE
1951 * intervals.h (struct interval): Use EMACS_INT for members
1952 where EMACS_UINT might cause problems. See
1953 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1954 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1955 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1956 All uses changed.
37aa2f85
PE
1957 (offset_intervals): Tell GCC not to worry about length overflow
1958 when negating a negative length.
c20db43f 1959
2538aa2f
PE
1960 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1961 (overrun_check_free): Likewise.
1962
f2d3008d
PE
1963 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1964 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1965 word size.
1966
ec8df744
PE
1967 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1968 (gnutls_make_error): Rename local to avoid shadowing.
1969 (gnutls_emacs_global_deinit): ifdef out; not used.
1970 (Fgnutls_boot): Use const for pointer to readonly storage.
1971 Comment out unused local. Fix pointer signedness problems.
1972
640ee02d
PE
1973 * lread.c (openp): Don't stuff size_t into an 'int'.
1974 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1975 about possible signed overflow.
1976
6048fb2a
PE
1977 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1978 (GDK_KEY_g): Don't define if already defined.
1979 (xg_prepare_tooltip): Avoid pointer signedness problem.
1980 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1981
fa3c87e1
PE
1982 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1983 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1984
2172544b
PE
1985 * xfns.c (Fx_window_property): Simplify a bit,
1986 to make a bit faster and to avoid GCC 4.6.0 warning.
1987 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1988
9b821a21
PE
1989 * fns.c (internal_equal): Don't assume size_t fits in int.
1990
3c616cfa
PE
1991 * alloc.c (compact_small_strings): Tighten assertion a little.
1992
c2982e87
PE
1993 Replace pEd with more-general pI, and fix some printf arg casts.
1994 * lisp.h (pI): New macro, generalizing old pEd macro to other
1995 conversion specifiers. For example, use "...%"pI"d..." rather
1996 than "...%"pEd"...".
1997 (pEd): Remove. All uses replaced with similar uses of pI.
1998 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1999 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2000 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2001 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2002 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2003 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2004 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2005 64-bit hosts.
2006 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2007 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2008 * print.c (safe_debug_print, print_object): Likewise.
2009 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2010 to int.
6f04d126
PE
2011 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2012 avoiding the 0 flag, which is not portable.
c2982e87
PE
2013 * process.c (Fmake_network_process): Use pI to avoid cast.
2014 * region-cache.c (pp_cache): Likewise.
2015 * xdisp.c (decode_mode_spec): Likewise.
2016 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2017 behavior on 64-bit hosts with printf arg.
6f04d126 2018 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2019 (x_stop_queuing_selection_requests): Likewise.
2020 (x_get_window_property): Don't truncate byte count to an 'int'
2021 when tracing.
0b432f21 2022
5e073ec7
PE
2023 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2024 here, since it parses constructs like leading '-' and spaces,
2025 which are not wanted; and it overflows with large numbers.
2026 Instead, simply match F[0-9]+, which is what is wanted anyway.
2027
36372bf9
PE
2028 * alloc.c: Remove unportable assumptions about struct layout.
2029 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2030 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2031 (allocate_vectorlike, make_pure_vector): Use the new macros,
2032 plus offsetof, to remove unportable assumptions about struct layout.
2033 These assumptions hold on all porting targets that I know of, but
2034 they are not guaranteed, they're easy to remove, and removing them
2035 makes further changes easier.
2036
0b432f21
PE
2037 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2038 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2039 (string_overrun_cookie): Now const. Use initializers that
2040 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2041 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2042 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2043 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2044 multiple of sizeof (EMACS_INT); it need not be, if
2045 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2046 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2047
895009e1
JB
20482011-04-26 Juanma Barranquero <lekktu@gmail.com>
2049
2050 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2051
6a7a1b0b
TZ
20522011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2053
2054 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2055 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2056 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2057
841a1577 20582011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2059
2060 * lisp.h (Qdebug): List symbol.
895009e1 2061 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2062 * keyboard.c (debug-on-event): New variable.
2063 (handle_user_signal): Break into debugger when debug-on-event
2064 matches the current signal symbol.
2065
f2d3ba6f
DN
20662011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2067
2068 * alloc.c (check_sblock, check_string_bytes)
2069 (check_string_free_list): Convert to standard C.
2070
42ce4c63
TZ
20712011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2072
2073 * w32.c (emacs_gnutls_push): Fix typo.
2074
825cd63c
EZ
20752011-04-25 Eli Zaretskii <eliz@gnu.org>
2076
fb11d64d
EZ
2077 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2078 "cast to pointer from integer of different size".
2079
825cd63c
EZ
2080 Improve doprnt and its use in verror. (Bug#8545)
2081 * doprnt.c (doprnt): Document the set of format control sequences
2082 supported by the function. Use SAFE_ALLOCA instead of always
2083 using `alloca'.
2084
2085 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2086 is one byte too soon. Don't use xrealloc; instead xfree and
2087 xmalloc anew.
2088
e061a11b
TZ
20892011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2090
2091 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2092 callbacks stage.
2093
2094 * gnutls.c: Renamed global_initialized to
2095 gnutls_global_initialized. Added internals for the
2096 :verify-hostname-error, :verify-error, and :verify-flags
2097 parameters of `gnutls-boot' and documented those parameters in the
2098 docstring. Start callback support.
2099 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2100 unless a fatal error occured. Call gnutls_alert_send_appropriate
2101 on error. Return error code.
2102 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2103 (emacs_gnutls_read): Likewise.
2104 (Fgnutls_boot): Return handshake error code.
2105 (emacs_gnutls_handle_error): New function.
2106 (wsaerror_to_errno): Likewise.
2107
2108 * w32.h (emacs_gnutls_pull): Add prototype.
2109 (emacs_gnutls_push): Likewise.
2110
2111 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2112 (emacs_gnutls_push): Likewise.
2113
21142011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2115
2116 * process.c (wait_reading_process_output): Check if GnuTLS
2117 buffered some data internally if no FDs are set for TLS
2118 connections.
2119
2120 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2121 (LIBS): Link to USER_LIBS.
2122 ($(BLD)/gnutls.$(0)): New target.
2123
fa6996bc
EZ
21242011-04-24 Eli Zaretskii <eliz@gnu.org>
2125
eb35682e
EZ
2126 * xdisp.c (handle_single_display_spec): Rename the
2127 display_replaced_before_p argument into display_replaced_p, to
2128 make it consistent with the commentary. Fix typos in the
2129 commentary.
2130
e2ad650c
EZ
2131 * textprop.c (syms_of_textprop): Remove dead code.
2132 (copy_text_properties): Delete obsolete commentary about an
2133 interface that was deleted long ago. Fix typos in the description
2134 of arguments.
2135
1b2de274
EZ
2136 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2137 to changes in oldXMenu/XMenu.h from 2011-04-16.
2138 <menu_help_message, prev_menu_help_message>: Constify.
2139 (IT_menu_make_room): menu->help_text is now `const char **';
2140 adjust.
2141
2142 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2143 to changes in oldXMenu/XMenu.h from 2011-04-16.
2144 (struct XMenu): Declare `help_text' `const char **'.
2145
2146 * xfaces.c <Qunspecified>: Make extern again.
2147
2148 * syntax.c: Include sys/types.h before including regex.h, as
2149 required by Posix.
2150
762b15be
EZ
2151 * doc.c (get_doc_string): Improve the format passed to `error'.
2152
2153 * doprnt.c (doprnt): Improve commentary.
2154
2155 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2156
2157 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2158 them with etags.
2159
f1052e5d
EZ
2160 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2161 changes in globals.h immediately force recompilation.
762b15be
EZ
2162 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2163 $(CURDIR)/s/ms-w32.h.
2164 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2165
fa6996bc
EZ
2166 * character.c (Fchar_direction): Function deleted.
2167 (syms_of_character): Don't defsubr it.
2168 <char-direction-table>: Deleted.
2169
e6c3da20
EZ
21702011-04-23 Eli Zaretskii <eliz@gnu.org>
2171
2172 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2173 * doprnt.c: Include limits.h.
2174 (SIZE_MAX): New macro.
04f2d78b
CB
2175 (doprnt): Return a size_t value. 2nd arg is now size_t.
2176 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2177 Improve overflow protection. Support `l' modifier for integer
2178 conversions. Support %l conversion. Don't assume an EMACS_INT
2179 argument for integer conversions and for %c.
2180
2181 * lisp.h (doprnt): Restore prototype.
2182
2183 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2184 $(SRC)/character.h.
2185
2186 * Makefile.in (base_obj): Add back doprnt.o.
2187
2188 * deps.mk (doprnt.o): Add back prerequisites.
2189 (callint.o): Depend on character.h.
2190
2191 * eval.c (internal_lisp_condition_case): Include the handler
2192 representation in the error message.
2193 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2194 when breaking from the loop.
2195
2196 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2197
2198 * callint.c (Fcall_interactively): When displaying error message
2199 about invalid control letter, pass the character's codepoint, not
2200 a pointer to its multibyte form. Improve display of the character
2201 in octal and display also its hex code.
2202
2203 * character.c (char_string): Use %x to display the (unsigned)
2204 codepoint of an invalid character, to avoid displaying a bogus
2205 negative value.
2206
2207 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2208 `error', not SYMBOL_NAME itself.
2209
2210 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2211 character arguments to `error'.
2212
2213 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2214 to `error' in error message about FINAL_CHAR argument. Make sure
2215 FINAL_CHAR is a character, and use %c when it is passed as
2216 argument to `error'.
2217
4ffd0d6b 22182011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2219
2220 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2221
2222 * w32.c: Include <time.h>.
2223 (sys_localtime): New function.
2224
4ffd0d6b 22252011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2226
2227 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2228
4ffd0d6b 2229 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2230
4ffd0d6b 22312011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2232
4ffd0d6b
GM
2233 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2234 zombies (Bug#8467).
aac0c6e3 2235
04c56954
EZ
22362011-04-19 Eli Zaretskii <eliz@gnu.org>
2237
2238 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2239 gl_state.e_property when gl_state.object is Qt.
2240
2241 * insdel.c (make_gap_larger): Remove limitation of buffer size
2242 to <= INT_MAX.
2243
16a43933
CY
22442011-04-18 Chong Yidong <cyd@stupidchicken.com>
2245
2246 * xdisp.c (lookup_glyphless_char_display)
2247 (produce_glyphless_glyph): Handle cons cell entry in
2248 glyphless-char-display.
2249 (Vglyphless_char_display): Document it.
2250
2251 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2252 glyphless-char-display.
2253
4581706e
CY
22542011-04-17 Chong Yidong <cyd@stupidchicken.com>
2255
2256 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2257
2258 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2259
2260 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2261 definition for no-X builds.
2262
4887c6e2 22632011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2264
fd35b6f9
PE
2265 Static checks with GCC 4.6.0 and non-default toolkits.
2266
5c1ccb01
PE
2267 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2268
006c5daa
PE
2269 * process.c (keyboard_bit_set): Define only if SIGIO.
2270 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2271 (send_process): Repair possible setjmp clobbering.
2272
efc736d3
PE
2273 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2274
4e2fe2e6
PE
2275 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2276
f97334a2
PE
2277 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2278
4e75f29d
PE
2279 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2280 Define only if needed.
2281
90efadd1
PE
2282 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2283 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2284 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2285
3c647824
PE
2286 * dispextern.h (struct redisplay_interface): Rename param
2287 to avoid shadowing.
e264f262 2288 * termhooks.h (struct terminal): Likewise.
761383f4 2289 * xterm.c (xembed_send_message): Likewise.
3c647824 2290
b58c5c4a
PE
2291 * insdel.c (make_gap_smaller): Define only if
2292 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2293
cad59032
PE
2294 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2295 it.
2296
c339dc2e
PE
2297 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2298 so that we aren't warned about unused symbols.
2299
91a3e27b
PE
2300 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2301
399c71d3 2302 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2303
8ffc96f5
PE
2304 * xfns.c (x_real_positions): Mark locals as initialized.
2305
eef9bc79
PE
2306 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2307
098db9dd
PE
2308 * xterm.c: Fix problems found by static analysis with other toolkits.
2309 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2310 (x_dispatch_event): Declare static if USE_GTK, and
2311 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2312 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2313 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2314 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2315 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2316
eb18f6cc
PE
2317 * xmenu.c (menu_help_callback): Pointer type fixes.
2318 Use const pointers when pointing at readonly data. Avoid pointer
2319 signedness clashes.
2320 (FALSE): Remove unused macro.
2321 (update_frame_menubar): Remove unused decl.
2322
1fe72bf8
PE
2323 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2324
60d9e1db
PE
2325 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2326 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2327 (single_menu_item): Rename local to avoid shadowing.
2328
39261c26
PE
2329 * keyboard.c (make_lispy_event): Remove unused local var.
2330
018c5e19
PE
2331 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2332 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2333
63d2b86e
PE
2334 * bitmaps: Change bitmaps from unsigned char back to the X11
2335 compatible char. Avoid the old compiler warnings about
2336 out-of-range initializers by using, for example, '\xab' rather
2337 than 0xab.
2338
aefd87e1
PE
2339 * xgselect.c (xgselect_initialize): Check vs interface
2340 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2341
bf501fb9
PE
2342 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2343
e9829fdf
PE
2344 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2345 to read-only memory.
2346
1086c095
PE
2347 * fns.c (vector): Remove; this old hack is no longer needed.
2348
2baccd04 2349 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2350 Remove unused var.
dde42981 2351 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2352
72391843 2353 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2354
436c16df 2355 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2356 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2357 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2358
92bb796d 2359 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2360 (x_term_init): Remove local to avoid shadowing.
92bb796d 2361
764430a3 2362 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2363
2364 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2365 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2366
d1dfb56c
EZ
23672011-04-16 Eli Zaretskii <eliz@gnu.org>
2368
c4354cb4
EZ
2369 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2370
d1dfb56c
EZ
2371 Fix regex.c, syntax.c and friends for buffers > 2GB.
2372 * syntax.h (struct gl_state_s): Declare character position members
2373 EMACS_INT.
2374
2375 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2376
04f2d78b
CB
2377 * textprop.c (verify_interval_modification, interval_of):
2378 Declare arguments EMACS_INT.
d1dfb56c
EZ
2379
2380 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2381 EMACS_INT.
2382
2383 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2384
2385 * indent.c (Fvertical_motion): Local variable it_start is now
2386 EMACS_INT.
2387
2388 * regex.c (re_match, re_match_2, re_match_2_internal)
2389 (bcmp_translate, regcomp, regexec, print_double_string)
2390 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2391 (re_compile_pattern, re_exec): Declare arguments and local
2392 variables `size_t' and `ssize_t' and return values `regoff_t', as
2393 appropriate.
2394 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2395 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2396 <compile_stack_type>: `size' and `avail' are now `size_t'.
2397
2398 * regex.h <regoff_t>: Use ssize_t, not int.
2399 (re_search, re_search_2, re_match, re_match_2): Arguments that
2400 specify buffer/string position and length are now ssize_t and
2401 size_t. Return type is regoff_t.
2402
613052cd
BK
24032011-04-16 Ben Key <bkey76@gmail.com>
2404
2405 * nsfont.m: Fixed bugs in ns_get_family and
2406 ns_descriptor_to_entity that were caused by using free to
2407 deallocate memory blocks that were allocated by xmalloc (via
2408 xstrdup). This caused Emacs to crash when compiled with
2409 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2410 --enable-checking=xmallocoverrun). xfree is now used to
2411 deallocate these memory blocks.
2412
4170f62f 24132011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2414
71b41406
PE
2415 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2416
9587a89d
PE
2417 emacs_write: Accept and return EMACS_INT for sizes.
2418 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2419 et seq.
2420 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2421 Accept and return EMACS_INT.
2422 (emacs_gnutls_write): Return the number of bytes written on
2423 partial writes.
2424 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2425 (emacs_read, emacs_write): Remove check for negative size, as the
2426 Emacs source code has been audited now.
9587a89d
PE
2427 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2428 (emacs_read, emacs_write): Use it.
273a5f82
PE
2429 * process.c (send_process): Adjust to the new signatures of
2430 emacs_write and emacs_gnutls_write. Do not attempt to store
2431 a byte offset into an 'int'; it might overflow.
9587a89d 2432 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2433
3e047f51
PE
2434 * sound.c: Don't assume sizes fit in 'int'.
2435 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2436 Return EMACS_INT, not int.
3e047f51 2437 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2438 Accept EMACS_INT, not int.
2439 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2440 record read return values.
2441
cc39a9db
BK
24422011-04-15 Ben Key <bkey76@gmail.com>
2443
c9d0ec6d
JB
2444 * keyboard.c (Qundefined): Don't declare static since it is used
2445 in nsfns.m.
2446 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2447 static since they are used in nsfont.m.
cc39a9db 2448
6c60eb9f
SM
24492011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2450
2451 * process.c (Qprocessp): Don't declare static.
2452 * lisp.h (Qprocessp): Declare again.
2453
7990b61a
JB
24542011-04-15 Juanma Barranquero <lekktu@gmail.com>
2455
2456 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2457
5d4cb038
PE
24582011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2459
8bd7b830 2460 Improve C-level modularity by making more things 'static'.
cd64ea1d 2461
e3b27b31
PE
2462 Don't publish debugger-only interfaces to other modules.
2463 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2464 (verify_bytepos, count_markers): Move decls to the only modules
2465 that need them.
2466 * region-cache.h (pp_cache): Likewise.
2467 * window.h (check_all_windows): Likewise.
2468 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2469
5d4cb038
PE
2470 * sysdep.c (croak): Now static, if
2471 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2472 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2473
2474 * alloc.c (refill_memory_reserve): Now static if
2475 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2476 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2477
e87b6180
PE
2478 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2479 Define only if USE_LUCID.
2480
ac64929e
PE
2481 * xrdb.c (x_customization_string, x_rm_string): Now static.
2482
6f37259d
PE
2483 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2484 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2485
1683e3ab
PE
2486 * xdisp.c (draw_row_with_mouse_face): Now static.
2487 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2488
de9c2632
PE
2489 * window.h (check_all_windows): Mark externally visible.
2490
2b96acb7
PE
2491 * window.c (window_deletion_count): Now static.
2492
2493 * undo.c: Make symbols static if they're not exported.
2494 (last_undo_buffer, last_boundary_position, pending_boundary):
2495 Now static.
2496
50436f33
PE
2497 * textprop.c (interval_insert_behind_hooks): Now static.
2498 (interval_insert_in_front_hooks): Likewise.
2499
64520e5c
PE
2500 * term.c: Make symbols static if they're not exported.
2501 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2502 (max_frame_lines, tty_set_terminal_modes):
2503 (tty_reset_terminal_modes, tty_turn_off_highlight):
2504 (get_tty_terminal): Now static.
2505 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2506 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2507 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2508 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2509 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2510
1fa53021
PE
2511 * sysdep.c: Make symbols static if they're not exported.
2512 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2513 Now static.
2514 (sigprocmask_set, full_mask): Remove; unused.
2515 (wait_debugging): Mark as visible.
2516 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2517 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2518
d4b43b22
PE
2519 * syntax.c (syntax_temp): Define only if !__GNUC__.
2520
b7c513d0
PE
2521 * sound.c (current_sound_device, current_sound): Now static.
2522
989b29ad
PE
2523 * search.c (searchbufs, searchbuf_head): Now static.
2524
13a55a78
PE
2525 * scroll.c (scroll_cost): Remove; unused.
2526 * dispextern.h (scroll_cost): Remove decl.
2527
de68a1fc
PE
2528 * region-cache.h (pp_cache): Mark as externally visible.
2529
40ccffa6
PE
2530 * process.c: Make symbols static if they're not exported.
2531 (process_tick, update_tick, create_process, chan_process):
2532 (Vprocess_alist, proc_buffered_char, datagram_access):
2533 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2534 (deactivate_process): Mark defn as static, as well as decl.
2535 * lisp.h (create_process): Remove decl.
2536 * process.h (chan_process, Vprocess_alist): Remove decls.
2537
ad64fc97
PE
2538 * print.c: Make symbols static if they're not exported.
2539 (print_depth, new_backquote_output, being_printed, print_buffer):
2540 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2541 (print_interval, print_number_index, initial_stderr_stream):
2542 Now static.
2543 * lisp.h (Fprinc): Remove decl.
2544 (debug_output_compilation_hack): Mark as externally visible.
2545
adddb265
PE
2546 * sysdep.c (croak): Move decl from here to syssignal.h.
2547 * syssignal.h (croak): Put it here, so the API can be checked when
2548 'croak' is called from dissociate_if_controlling_tty.
2549
1717ede2
PE
2550 * minibuf.c: Make symbols static if they're not exported.
2551 (minibuf_save_list, choose_minibuf_frame): Now static.
2552 * lisp.h (choose_minibuf_frame): Remove decl.
2553
fa5fb2bc
PE
2554 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2555
1e3890d1
PE
2556 * lread.c: Make symbols static if they're not exported.
2557 (read_objects, initial_obarray, oblookup_last_bucket_number):
2558 Now static.
2559 (make_symbol): Remove; unused.
2560 * lisp.h (initial_obarray, make_symbol): Remove decls.
2561
8a1414fa
PE
2562 * keyboard.c: Make symbols static if they're not exported.
2563 (single_kboard, recent_keys_index, total_keys, recent_keys):
2564 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2565 (this_single_command_key_start, echoing, last_auto_save):
2566 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2567 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2568 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2569 (Vlispy_mouse_stem, double_click_count):
2570 Now static.
2571 (force_auto_save_soon): Define only if SIGDANGER.
2572 (ignore_mouse_drag_p): Now static if
2573 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2574 (print_help): Remove; unused.
2575 (stop_character, last_timer_event): Mark as externally visible.
2576 * keyboard.h (ignore_mouse_drag_p): Declare only if
2577 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2578 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2579 * lisp.h (echoing): Remove decl.
2580 (force_auto_save_soon): Declare only if SIGDANGER.
2581 * xdisp.c (redisplay_window): Simplify code, to make it more
2582 obvious that ignore_mouse_drag_p is not accessed if !defined
2583 USE_GTK && !defined HAVE_NS.
2584
93ea6e8f
PE
2585 * intervals.c: Make symbols static if they're not exported.
2586 (merge_properties_sticky, merge_interval_right, delete_interval):
2587 Now static.
2588 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2589
77382fcc
PE
2590 * insdel.c: Make symbols static if they're not exported.
2591 However, leave prepare_to_modify_buffer alone. It's never
2592 called from outside this function, but that appears to be a bug.
2593 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2594 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2595 (adjust_after_replace_noundo): Remove; unused.
2596 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2597 (signal_before_change): Remove decls.
77382fcc 2598
9306c32e
PE
2599 * indent.c (val_compute_motion, val_vmotion): Now static.
2600
cd44d2eb
PE
2601 * image.c: Make symbols static if they're not exported.
2602 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2603 if USE_GTK.
2604 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2605 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2606
ad9a7a06
PE
2607 * fringe.c (standard_bitmaps): Now static.
2608 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2609
81626931
PE
2610 * frame.c: Make symbols static if they're not exported.
2611 (x_report_frame_params, make_terminal_frame): Now static.
2612 (get_frame_param): Now static, unless HAVE_NS.
2613 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2614 (x_get_resource_string): Remove; not used.
2615 * frame.h (make_terminal_frame, x_report_frame_params):
2616 (x_get_resource_string); Remove decls.
2617 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2618 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2619
239f9db9
PE
2620 * font.c, fontset.c: Make symbols static if they're not exported.
2621 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2622 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2623 * font.c (font_close_object): Now static.
2624 * font.h (font_close_object): Remove.
2625 * fontset.c (FONTSET_OBJLIST): Remove.
2626 (free_realized_fontset) #if-0 the body, which does nothing.
2627 (face_suitable_for_char_p): #if-0, as it's never called.
2628 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2629 * xfaces.c (face_at_string_position):
2630 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2631 since 0 is always ASCII.
2632
dfcf3579
PE
2633 * fns.c (weak_hash_tables): Now static.
2634
5045092b
PE
2635 * fileio.c: Make symbols static if they're not exported.
2636 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2637 (Vwrite_region_annotation_buffers): Now static.
2638
57a96f5c
PE
2639 * eval.c: Make symbols static if they're not exported.
2640 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2641 * lisp.h (backtrace_list): Remove decl.
2642
35f08c38
PE
2643 * emacs.c: Make symbols static if they're not exported.
2644 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2645 (fatal_error_code, fatal_error_signal_hook, standard_args):
2646 Now static.
2647 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2648 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2649 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2650 * lisp.h (fatal_error_signal_hook): Remove decl.
2651 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2652
f44bd759
PE
2653 * editfns.c: Move a (normally-unused) function to its only use.
2654 * editfns.c, lisp.h (get_operating_system_release): Remove.
2655 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2656 worth the hassle of breaking this out.
2657
b532497d
PE
2658 * xterm.c: Make symbols static if they're not exported.
2659 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2660 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2661 (x_destroy_window, x_delete_display):
2662 Now static.
2663 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2664 (x_mouse_leave): Remove; unused.
2665 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2666 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2667 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2668 Remove decls.
2669 (x_mouse_leave): Declare only if WINDOWSNT.
2670 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2671 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2672 USE_X_TOOLKIT.
2673
1675728f
PE
2674 * ftxfont.c: Make symbols static if they're not exported.
2675 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2676 HAVE_FREETYPE.
2677 * font.h (ftxfont_driver): Likewise.
2678
e4cebfca
PE
2679 * xfns.c: Make symbols static if they're not exported.
2680 (x_last_font_name, x_display_info_for_name):
2681 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2682 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2683 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2684 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2685 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2686 (last_show_tip_args): Now static.
2687 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2688 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2689 (x_screen_planes): Remove; unused.
2690 * dispextern.h (x_screen_planes): Remove decl.
2691
5bf46f05
PE
2692 * dispnew.c: Make symbols static if they're not exported.
2693 * dispextern.h (redraw_garbaged_frames, scrolling):
2694 (increment_row_positions): Remove.
2695 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2696 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2697 Now static.
2698 (redraw_garbaged_frames): Remove; unused.
2699
435f4c28
PE
2700 * xfaces.c: Make symbols static if they're not exported.
2701 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2702 Remove decls.
2703 * xterm.h (defined_color): Remove decls.
2704 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2705 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2706 (menu_face_changed_default, defined_color, free_realized_face):
2707 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2708 (ascii_face_of_lisp_face): Remove; unused.
2709
8524aef3
PE
2710 * xdisp.c: Make symbols static if they're not exported.
2711 * dispextern.h (scratch_glyph_row, window_box_edges):
2712 (glyph_to_pixel_coords, set_cursor_from_row):
2713 (get_next_display_element, set_iterator_to_next):
2714 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2715 (show_mouse_face): Remove decls
2716 * frame.h (message_buf_print): Likewise.
2717 * lisp.h (pop_message, set_message, check_point_in_composition):
2718 Likewise.
2719 * xterm.h (set_vertical_scroll_bar): Likewise.
2720 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2721 (message_buf_print, scratch_glyph_row, displayed_buffer):
2722 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2723 (get_next_display_element, show_mouse_face, window_box_edges):
2724 (frame_to_window_pixel_xy, check_point_in_composition):
2725 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2726 (glyph_to_pixel_coords): Remove; unused.
2727
16390cd2
PE
2728 * dired.c (file_name_completion): Now static.
2729
2730 * dbusbind.c (xd_in_read_queued_messages): Now static.
2731
a25f4dfa
PE
2732 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2733 * data.c (circular_list_error): Remove.
2734
14a9c8df
PE
2735 * commands.h (last_point_position, last_point_position_buffer):
2736 (last_point_position_window): Remove decls.
2737 * keyboard.c: Make these variables static.
2738
04f2d78b
CB
2739 * coding.h (coding, code_convert_region, encode_coding_gap):
2740 Remove decls.
74ab6df5
PE
2741 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2742 (iso_code_class, detect_coding, code_convert_region): Now static.
2743 (encode_coding_gap): Remove; unused.
2744
38dfbee1
PE
2745 * chartab.c (chartab_chars, chartab_bits): Now static.
2746
a2cb4e63
PE
2747 * charset.h (charset_iso_8859_1): Remove decl.
2748 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2749 Now static.
2750
127198fd
PE
2751 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2752 * ccl.c (Vccl_program_table): Now static.
2753 (check_ccl_update): Remove; unused.
2754
d85b608f
PE
2755 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2756 * category.h: ... from here.
2757 * category.c (check_category_table, set_category_set): Now static.
2758
31cd66f3
PE
2759 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2760 * lisp.h: Remove these decls.
2761
c358e587
PE
2762 * buffer.c (buffer_count): Remove unused var.
2763
e78aecca
PE
2764 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2765 so that it's not optimized away.
2766 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2767 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2768 exported only to the debugger.
2769
e192d7d3 2770 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2771 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2772
92470028
PE
2773 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2774 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2775 was inaccessible from Lisp.
2776 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2777 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2778
244ed907
PE
2779 alloc.c: Import and export fewer symbols, and remove unused items.
2780 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2781 is defined.
2782 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2783 it's not optimized away by whole-program optimization.
2784 (message_enable_multibyte, free_misc): Remove.
2785 (catchlist, handlerlist, mark_backtrace):
2786 Declare only if BYTE_MARK_STACK.
2787 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2788 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2789 (message_enable_multibyte): Remove decl.
2790 (free_misc, interval_free_list, float_block, float_block_index):
2791 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2792 (cons_free_list, last_marked_index):
2793 Now static.
2794 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2795 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2796 (mark_backtrace): Define only if BYTE_MARK_STACK.
2797 * xdisp.c (message_enable_multibyte): Now static.
2798
61c2b50e 2799 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2800 This makes it easier for human readers (and static analyzers)
2801 to see whether these variables are used from other modules.
2802 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2803 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2804 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2805 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2806 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2807 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2808 * xmenu.c, xselect.c:
2809 Declare Q* vars static if they are not used in other modules.
2810 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2811 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2812 Remove decls of unexported vars.
2813 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2814
95c82688
PE
2815 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2816
16a97296
PE
2817 Make Emacs functions such as Fatom 'static' by default.
2818 This makes it easier for human readers (and static analyzers)
2819 to see whether these functions can be called from other modules.
2820 DEFUN now defines a static function. To make the function external
2821 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2822 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2823 (Finit_image_library):
16a97296
PE
2824 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2825 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2826 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2827 Remove decls, since these functions are now static.
2828 (Funintern, Fget_internal_run_time): New decls, since these functions
2829 were already external.
95c82688 2830
16a97296
PE
2831 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2832 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2833 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2834 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2835 * keyboard.c, keymap.c, lread.c:
2836 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2837 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2838 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2839 Mark functions with DEFUE instead of DEFUN,
2840 if they are used in other modules.
2841 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2842 decls for now-static functions.
2843 * buffer.h (Fdelete_overlay): Remove decl.
2844 * callproc.c (Fgetenv_internal): Mark as internal.
2845 * composite.c (Fremove_list_of_text_properties): Remove decl.
2846 (Fcomposition_get_gstring): New forward static decl.
2847 * composite.h (Fcomposite_get_gstring): Remove decl.
2848 * dired.c (Ffile_attributes): New forward static decl.
2849 * doc.c (Fdocumntation_property): New forward static decl.
2850 * eval.c (Ffetch_bytecode): New forward static decl.
2851 (Funintern): Remove extern decl; now in .h file where it belongs.
2852 * fileio.c (Fmake_symbolic_link): New forward static decl.
2853 * image.c (Finit_image_library): New forward static decl.
2854 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2855 * intervals.h (Fprevious_property_change):
2856 (Fremove_list_of_text_properties): Remove decls.
2857 * keyboard.c (Fthis_command_keys): Remove decl.
2858 (Fcommand_execute): New forward static decl.
2859 * keymap.c (Flookup_key): New forward static decl.
2860 (Fcopy_keymap): Now static.
2861 * keymap.h (Flookup_key): Remove decl.
2862 * process.c (Fget_process): New forward static decl.
2863 (Fprocess_datagram_address): Mark as internal.
2864 * syntax.c (Fsyntax_table_p): New forward static decl.
2865 (skip_chars): Remove duplicate decl.
2866 * textprop.c (Fprevious_property_change): New forward static decl.
2867 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2868 Now internal.
2869 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2870 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2871
785bbd42
PE
2872 * editfns.c (Fformat): Remove unreachable code.
2873
8b913b57
AS
28742011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2875
2876 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2877 change. (Bug#8496)
2878
a6744a35
EZ
28792011-04-13 Eli Zaretskii <eliz@gnu.org>
2880
2881 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2882 when at ZV. (Bug#8487)
2883
e7974947
AS
28842011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2885
baad03f0
AS
2886 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2887 (Bug#8437)
2888 * keyboard.c (parse_tool_bar_item): Likewise.
2889 * sound.c (sound_cleanup, alsa_close): Likewise.
2890 * termcap.c (tgetent): Likewise.
2891 * xfns.c (x_default_font_parameter): Likewise.
2892 * xsettings.c (read_and_apply_settings): Likewise.
2893
e7974947
AS
2894 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2895 (overrun_check_free): Protoize.
2896
28272684
PE
28972011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2898
2899 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2900 since callers should never pass a negative size.
2901 Change the signature to match that of plain 'read' and 'write'; see
2902 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2903 * lisp.h: Update prototypes of emacs_write and emacs_read.
2904
11997c76
EZ
29052011-04-11 Eli Zaretskii <eliz@gnu.org>
2906
2907 * xdisp.c (redisplay_window): Don't try to determine the character
2908 position of the scroll margin if the window start point w->startp
e896f03c 2909 is outside the buffer's accessible region. (Bug#8468)
11997c76 2910
8a2cbd72
EZ
29112011-04-10 Eli Zaretskii <eliz@gnu.org>
2912
2913 Fix write-region and its subroutines for buffers > 2GB.
2914 * fileio.c (a_write, e_write): Modify declaration of arguments and
2915 local variables to support buffers larger than 2GB.
2916 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2917
2918 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2919 argument, local variables, and return value.
2920
2921 * lisp.h: Update prototypes of emacs_write and emacs_read.
2922
2923 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2924
4073e537 29252011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2926
1ebfdcb6
PE
2927 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2928
b2ded58d
PE
2929 Fix more problems found by GCC 4.6.0's static checks.
2930
7d66342c
PE
2931 * xdisp.c (vmessage): Use a better test for character truncation.
2932
bbf47d44
PE
2933 * charset.c (load_charset_map): <, not <=, for optimization,
2934 and to avoid potential problems with integer overflow.
9248994d 2935 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2936 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2937 * editfns.c (Fformat): Likewise.
1e69125e 2938 * syntax.c (skip_chars): Likewise.
3befa583 2939
e3019616
PE
2940 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2941 This also lets GCC 4.6.0 generate slightly better loop code.
2942
becfa255
PE
2943 * callint.c (Fcall_interactively): <, not <=, for optimization.
2944 (Fcall_interactively): Count the number of arguments produced,
2945 not the number of arguments given. This is simpler and lets GCC
2946 4.6.0 generate slightly better code.
2947
dae0cd48
PE
2948 * ftfont.c: Distingish more carefully between FcChar8 and char.
2949 The previous code passed unsigned char * to a functions like
2950 strlen and xstrcasecmp that expect char *, which does not
2951 conform to the C standard.
2952 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2953 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2954 char * when the C standard requires it.
2955
76032d70
PE
2956 * keyboard.c (read_char): Remove unused var.
2957
eb3f1cc8
PE
2958 * eval.c: Port to Windows vsnprintf (Bug#8435).
2959 Include <limits.h>.
2960 (SIZE_MAX): Define if the headers do not.
2961 (verror): Do not give up if vsnprintf returns a negative count.
2962 Instead, grow the buffer. This ports to Windows vsnprintf, which
2963 does not conform to C99. Problem reported by Eli Zaretskii.
2964 Also, simplify the allocation scheme, by avoiding the need for
2965 calling realloc, and removing the ALLOCATED variable.
2966
70476b54
PE
2967 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2968
12020a9e
PE
2969 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2970 But keep the doprint source code for now, as we might revamp it
2971 and use it again (Bug#8435).
ea6c7ae6
PE
2972 * lisp.h (doprnt): Remove.
2973 * Makefile.in (base_obj): Remove doprnt.o.
2974 * deps.mk (doprnt.o): Remove.
2975
5fdb398c
PE
2976 error: Print 32- and 64-bit integers portably (Bug#8435).
2977 Without this change, on typical 64-bit hosts error ("...%d...", N)
2978 was used to print both 32- and 64-bit integers N, which relied on
2979 undefined behavior.
2980 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2981 New macro.
2982 * lisp.h (error, verror): Mark as printf-like functions.
2983 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2984 Report overflow in size calculations when allocating printf buffer.
2985 Do not truncate output string at its first null byte.
2986 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2987 Truncate the output at a character boundary, since vsnprintf does not
2988 do that.
2989 * charset.c (check_iso_charset_parameter): Convert internal
2990 character to string before calling 'error', since %c now has the
2991 printf meaning.
2992 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2993 overflow when computing char to be passed to 'error'. Do not
2994 pass Lisp_Object to 'error'; pass the integer instead.
2995 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2996 formatted with plain %d.
2997
b189fa66
PE
2998 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2999
bff87ef0
PE
3000 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3001
7e2cac20
PE
3002 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3003
ce4d90b5
PE
3004 * xterm.c (x_catch_errors): Remove duplicate declaration.
3005
266c9547
PE
3006 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3007
79c49ad2
PE
3008 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3009
368f4090
JM
30102011-04-10 Jim Meyering <meyering@redhat.com>
3011
3012 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3013 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3014 return ssize_t not "int", and use size_t as the buffer length.
3015 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3016 * gnutls.h: Update declarations.
3017 * process.c (read_process_output): Use ssize_t, to match.
3018 (send_process): Likewise.
3019
a32d4040
CY
30202011-04-09 Chong Yidong <cyd@stupidchicken.com>
3021
3022 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3023
8546720e 30242011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3025
04f2d78b
CB
3026 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3027 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3028
8546720e
GM
3029 * xterm.c (handle_one_xevent):
3030 * xmenu.c (create_and_show_popup_menu):
3031 * xselect.c (x_decline_selection_request)
3032 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3033
0a2f5c1a 30342011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3035
3036 Fix some uses of `int' instead of EMACS_INT.
3037 * search.c (string_match_1, fast_string_match)
3038 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3039 (scan_buffer, find_next_newline_no_quit)
3040 (find_before_next_newline, search_command, Freplace_match)
3041 (Fmatch_data): Make some `int' variables be EMACS_INT.
3042
3043 * xdisp.c (display_count_lines): 3rd argument and return value now
3044 EMACS_INT. All callers changed.
3045 (pint2hrstr): Last argument is now EMACS_INT.
3046
3047 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3048 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3049 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3050 (decode_coding_utf_16, decode_coding_emacs_mule)
3051 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3052 (decode_coding_ccl, decode_coding_charset)
3053 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3054 (decode_coding_iso_2022, decode_coding_emacs_mule)
3055 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3056 <char_offset, last_offset>: Declare EMACS_INT.
3057 (encode_coding_utf_8, encode_coding_utf_16)
3058 (encode_coding_emacs_mule, encode_invocation_designation)
3059 (encode_designation_at_bol, encode_coding_iso_2022)
3060 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3061 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3062 Declare EMACS_INT.
3063 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3064 (encode_invocation_designation): Last argument P_NCHARS is now
3065 EMACS_INT.
3066 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3067 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3068
3069 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3070 All users changed.
3071
3072 * ccl.c (Fccl_execute_on_string): Declare some variables
3073 EMACS_INT.
3074
8546720e 30752011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3076
3077 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3078
4e19a977
CS
30792011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3080
3081 * process.c (Fformat_network_address): Doc fix.
3082
87302331
R
30832011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3084
3085 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3086
cbb59342
CY
30872011-04-08 Chong Yidong <cyd@stupidchicken.com>
3088
3089 * keyboard.c (read_char): Call Lisp function help-form-show,
3090 instead of using internal_with_output_to_temp_buffer.
3091 (Qhelp_form_show): New var.
e0d38eeb 3092 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3093
3094 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3095
3096 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3097
e67a13ab
CY
30982011-04-06 Chong Yidong <cyd@stupidchicken.com>
3099
04f2d78b
CB
3100 * process.c (Flist_processes): Remove to Lisp.
3101 (list_processes_1): Delete.
e67a13ab 3102
973f782d
EZ
31032011-04-06 Eli Zaretskii <eliz@gnu.org>
3104
7c106b1e
EZ
3105 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3106
973f782d
EZ
3107 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3108
41cf7d1a 31092011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3110
ca23cc88
PE
3111 Fix more problems found by GCC 4.6.0's static checks.
3112
f390e2d5
PE
3113 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3114
42eea0d0
PE
3115 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3116
b69769da 3117 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3118
f9541e84
PE
3119 * xdisp.c (vmessage): Mark as a printf-like function.
3120
13841b55
PE
3121 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3122
c136c10f
PE
3123 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3124
5e2d4a30
PE
3125 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3126 printf-like functions.
3127 (tiff_load): Add casts to remove these marks before passing them
3128 to system-supplied API.
3129
583f48b9
PE
3130 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3131
b25d760e
PE
3132 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3133 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3134 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3135 directly, rather than having caller test rule sign. This avoids
3136 some unnecessary tests.
3137 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3138 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3139 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3140
bc7b6697 3141 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3142 (xfont_open): Avoid unnecessary tests.
bc7b6697 3143
27ccc379
PE
3144 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3145
dcd5c89a
PE
3146 * composite.h, composite.c (composition_gstring_put_cache):
3147 Use EMACS_INT, not int, for length.
3148
b13a45c6
PE
3149 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3150 breaking out part of COMPOSITION_DECODE_RULE.
3151 (COMPOSITION_DECODE_RULE): Use it.
3152 * composite.c (get_composition_id): Remove unused local vars,
3153 by using the new macro.
3154
1e792e4d
PE
3155 * textprop.c (set_text_properties_1): Change while to do-while,
3156 since the condition is always true at first.
3157
dc6c6455 3158 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3159 (interval_deletion_adjustment): Return unsigned value.
3160 All uses changed.
dc6c6455 3161
aba7731a
PE
3162 * process.c (list_processes_1, create_pty, read_process_output):
3163 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3164 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3165 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3166 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3167 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3168
fdfc4bf3
PE
3169 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3170
fca8fe46 3171 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3172 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3173
06a0259a 3174 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3175 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3176 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3177
e7b9e80f
PE
3178 * print.c (print_error_message): Avoid int overflow.
3179
56201685
PE
3180 * font.c (font_list_entities): Redo for clarity,
3181 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3182
78834453 3183 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3184 (font_score): Avoid potential overflow in diff calculation.
78834453 3185
0bc0b309 3186 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3187 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3188
e610eaca
PE
3189 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3190
b895abce
PE
3191 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3192 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3193 can always succeed if overflow has undefined behavior.
3194
1f1d9321 3195 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3196 (wordify): Omit three unnecessary tests.
1f1d9321 3197
c59478bc
PE
3198 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3199 All callers changed. This avoids the need for an unused var.
3200
79b73827
PE
3201 * casefiddle.c (casify_region): Remove var that is set but not used.
3202
a4db5dfe
PE
3203 * dired.c (file_name_completion): Remove var that is set but not used.
3204
43aae36e
PE
3205 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3206
2a47c44d 3207 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3208 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3209
a37c69bf
PE
3210 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3211 Check for integer overflow on size calculations.
3212
328ab8e7
PE
3213 * buffer.c (Fprevious_overlay_change): Remove var that is set
3214 but not used.
3215
e5a2a5cb
PE
3216 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3217 Remove vars that are set but not used.
8d84a6eb 3218 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3219 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3220
a60e5f68
PE
3221 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3222
f661cb61 3223 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3224 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3225
f0397f5a
PE
3226 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3227 that are set but not used.
3228
8664db06 3229 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3230 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3231
6abdaa4a
PE
3232 * xselect.c (x_get_local_selection, x_handle_property_notify):
3233 Remove vars that are set but not used.
3234
0ce7538d 3235 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3236 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3237
9ae848fc
PE
3238 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3239 Remove var that is set but not used.
0b918413
PE
3240 (scroll_bar_windows_size): Now size_t, not int.
3241 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3242 Check for overflow.
9ae848fc 3243
a5a62657
PE
3244 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3245 (map_tty_color) [!defined MSDOS]: Likewise.
3246
5c5cdd39
PE
3247 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3248
66ebf983
PE
3249 * coding.c: Remove vars that are set but not used.
3250 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3251 All callers changed.
3252 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3253 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3254 (decode_coding_charset): Remove vars that are set but not used.
3255
1be4d761
PE
3256 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3257 that is set but not used.
3258
47553fa8
PE
3259 * print.c (print_object): Remove var that is set but not used.
3260
1f7196bf 3261 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3262 The gnulib version avoids calling malloc in the usual case,
3263 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3264 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3265 * filelock.c (current_lock_owner): Likewise.
3266 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3267 * sysdep.c: Include allocator.h, careadlinkat.h.
3268 (emacs_no_realloc_allocator): New static constant.
3269 (emacs_readlink): New function.
fdb61804
PE
3270 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3271 ../lib/careadlinkat.h.
d1fdcab7 3272
f84c17c7
SM
32732011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3274
3275 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3276 first non-nil return value).
3277
ef3862ad
JD
32782011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3279
3280 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3281 if not defined (Bug#8403).
3282
376a7006
JB
32832011-04-02 Juanma Barranquero <lekktu@gmail.com>
3284
3285 * xdisp.c (display_count_lines): Remove parameter `start',
3286 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3287 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3288 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3289 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3290 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3291 and thereabouts. All callers changed.
3292 (get_per_char_metric): Remove parameter `f', unused since
3293 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3294
6ca3801d
JM
32952011-04-02 Jim Meyering <meyering@redhat.com>
3296
3297 do not dereference NULL upon failed strdup
3298 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3299 (ns_get_family): Likewise.
3300
d8e2b5ba
JB
33012011-04-02 Juanma Barranquero <lekktu@gmail.com>
3302
3303 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3304
8c74fcbd
JD
33052011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3306
3307 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3308 later (Bug#8403).
3309
7200d79c
SM
33102011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3311
03408648 3312 Add lexical binding.
7200d79c 3313
03408648
SM
3314 * window.c (Ftemp_output_buffer_show): New fun.
3315 (Fsave_window_excursion):
3316 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3317
3318 * lread.c (lisp_file_lexically_bound_p): New function.
3319 (Fload): Bind Qlexical_binding.
3320 (readevalloop): Remove `evalfun' arg.
3321 Bind Qinternal_interpreter_environment.
3322 (Feval_buffer): Bind Qlexical_binding.
3323 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3324 Mark as dynamic.
3325 (syms_of_lread): Declare `lexical-binding'.
3326
3327 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3328
3329 * keyboard.c (eval_dyn): New fun.
3330 (menu_item_eval_property): Use it.
ca105506
SM
3331
3332 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3333
03408648
SM
3334 * fns.c (concat, mapcar1): Accept byte-code-functions.
3335
3336 * eval.c (Fsetq): Handle lexical vars.
3337 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3338 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3339 (FletX, Flet): Obey lexical binding.
3340 (Fcommandp): Handle closures.
3341 (Feval): New `lexical' arg.
3342 (eval_sub): New function extracted from Feval. Use it almost
3343 everywhere where Feval was used. Look up vars in lexical env.
3344 Handle closures.
3345 (Ffunctionp): Move from subr.el.
3346 (Ffuncall): Handle closures.
3347 (apply_lambda): Remove `eval_flags'.
3348 (funcall_lambda): Handle closures and new byte-code-functions.
3349 (Fspecial_variable_p): New function.
3350 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3351 but without exporting it to Lisp.
23aba0ea 3352
23aba0ea 3353 * doc.c (Fdocumentation, store_function_docstring):
03408648 3354 * data.c (Finteractive_form): Handle closures.
23aba0ea 3355
03408648
SM
3356 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3357 interactive spec.
ba83908c 3358
04f2d78b
CB
3359 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3360 New byte-codes.
03408648
SM
3361 (exec_byte_code): New function extracted from Fbyte_code to handle new
3362 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3363
03408648 3364 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3365
03408648 3366 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3367
e2abce01
JB
33682011-03-31 Juanma Barranquero <lekktu@gmail.com>
3369
3370 * xdisp.c (redisplay_internal): Fix prototype.
3371
63696a73 33722011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3373
63696a73 3374 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3375 (try_scrolling): Use it when setting scroll_limit.
3376 Limit scrolling to 100 screen lines.
63696a73
EZ
3377 (redisplay_window): Even when falling back on "recentering",
3378 position point in the window according to scroll-conservatively,
3379 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3380
3381 (try_scrolling): When point is above the window, allow searching
3382 as far as scroll_max, or one screenful, to compute vertical
3383 distance from PT to the scroll margin position. This prevents
3384 try_scrolling from unnecessarily failing when
3385 scroll-conservatively is set to a value slightly larger than the
3386 window height. Clean up the case of PT below the margin at bottom
3387 of window: scroll_max can no longer be INT_MAX. When aggressive
3388 scrolling is in use, don't let point enter the opposite scroll
3389 margin as result of the scroll.
3390 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3391 threshold of 100 lines for never-recentering scrolling.
3392
e4cc2dfc
JB
33932011-03-31 Juanma Barranquero <lekktu@gmail.com>
3394
3395 * dispextern.h (move_it_by_lines):
3396 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3397 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3398 (message_log_check_duplicate): Remove parameters `prev_bol' and
3399 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3400 (redisplay_internal): Remove parameter `preserve_echo_area',
3401 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3402
3403 * indent.c (Fvertical_motion):
3404 * window.c (window_scroll_pixel_based, Frecenter):
3405 Don't pass `need_y_p' to `move_it_by_lines'.
3406
1c470562
SM
34072011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3408
44f230aa
SM
3409 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3410 steal a few bits to be more compact.
3411 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3412 Remove unneeded casts.
3413
1c470562
SM
3414 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3415
888adce9
ZK
34162011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3417
3418 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3419 binding" message (bug#7967).
3420
f838ed7b
PE
34212011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3422
77861b95
PE
3423 Fix more problems found by GCC 4.6.0's static checks.
3424
de6dbc14
PE
3425 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3426 Remove unused local var.
3427
f838ed7b
PE
3428 * editfns.c (Fmessage_box): Remove unused local var.
3429
792c7b2b
PE
3430 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3431 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3432 Omit unused local vars.
c499e557 3433 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3434 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3435 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3436 Omit unused local var.
3437
ba0165e1
PE
3438 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3439 Don't assume string length fits in int.
32ad8845 3440 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3441 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3442
3c59b4c9
PE
3443 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3444 instead of alloca (Bug#8344).
3445
a3eed478 3446 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3447 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3448
eb4d412d
PE
3449 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3450
1658b401
PE
3451 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3452 concerns.
3453
3454 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3455
3456 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3457
9a2c6e05
PE
3458 * keyboard.c (syms_of_keyboard): Use the same style as later
3459 in this function when indexing through an array. This also
3460 works around GCC bug 48267.
3461
03d0a109
PE
3462 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3463
44f730c8
PE
3464 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3465
fe75f926
PE
3466 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3467 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3468
ffa8c828
PE
3469 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3470 This avoids undefined behavior on integer overflow, and is a bit
3471 more convenient anyway since it is compared to a size_t variable.
3472
c5101a77
PE
3473 Variadic C functions now count arguments with size_t, not int.
3474 This avoids an unnecessary limitation on 64-bit machines, which
3475 caused (substring ...) to crash on large vectors (Bug#8344).
3476 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3477 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3478 All variadic functions and their callers changed accordingly.
c5101a77
PE
3479 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3480 * data.c (arith_driver, float_arith_driver): Likewise.
3481 * editfns.c (general_insert_function): Likewise.
3482 * eval.c (struct backtrace.nargs, interactive_p)
3483 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3484 (funcall_lambda, mark_backtrace): Likewise.
3485 * fns.c (concat): Likewise.
3486 * frame.c (x_set_frame_parameters): Likewise.
3487 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3488 0 if not found, not -1. All callers changed.
3489
dd3f25f7
PE
3490 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3491 (stack_copy_size): Now size_t, not int.
3492 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3493
461c2ab9
JB
34942011-03-28 Juanma Barranquero <lekktu@gmail.com>
3495
3496 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3497 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3498 All callers changed.
3499
3500 * lisp.h (multibyte_char_to_unibyte):
3501 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3502 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3503 * character.h (CHAR_TO_BYTE8):
3504 * cmds.c (internal_self_insert):
3505 * editfns.c (general_insert_function):
3506 * keymap.c (push_key_description):
3507 * search.c (Freplace_match):
3508 * xdisp.c (message_dolog, set_message_1): All callers changed.
3509
f6d62986
SM
35102011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3511
3512 * keyboard.c (safe_run_hook_funcall): New function.
3513 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3514 don't set the hook to nil, but remove the offending function instead.
3515 (Qcommand_hook_internal): Remove, unused.
3516 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3517 Vcommand_hook_internal.
3518
3519 * eval.c (enum run_hooks_condition): Remove.
3520 (funcall_nil, funcall_not): New functions.
3521 (run_hook_with_args): Call each function through a `funcall' argument.
3522 Remove `cond' argument, now redundant.
3523 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3524 (Frun_hook_with_args_until_failure): Adjust accordingly.
3525 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3526
1db5b1ad
JB
35272011-03-28 Juanma Barranquero <lekktu@gmail.com>
3528
3529 * dispextern.h (string_buffer_position): Remove declaration.
3530
3531 * print.c (strout): Remove parameter `multibyte', unused since
3532 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3533
3534 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3535 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3536 All callers changed.
3537
3538 * w32.c (_wsa_errlist): Use braces for struct initializers.
3539
3540 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3541 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3542 All callers changed.
3543 (string_buffer_position): Likewise. Also, make static (it's never
3544 used outside xdisp.c).
3545 (cursor_row_p): Remove parameter `w', unused since
3546 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3547 (decode_mode_spec): Remove parameter `precision', introduced during
3548 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3549 All callers changed.
3550
5ffb62aa
JD
35512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3552
3553 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3554
461c2ab9 35552011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3556
3557 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3558 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3559 (ns_update_auto_hide_menu_bar): New functions.
3560 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3561 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3562 ns_constrain_all_frames.
3563 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3564 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3565
5c380ffb
JD
35662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3567
3568 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3569
9af30bdf
GM
35702011-03-27 Glenn Morris <rgm@gnu.org>
3571
3572 * syssignal.h: Replace RETSIGTYPE with void.
3573 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3574 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3575 Replace SIGTYPE with void everywhere.
3576 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3577 * s/template.h (SIGTYPE): Remove commented out definition.
3578
e2abce01
JB
35792011-03-26 Eli Zaretskii <eliz@gnu.org>
3580
3581 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3582 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3583
f868cd8a
JB
35842011-03-26 Juanma Barranquero <lekktu@gmail.com>
3585
59eb0929
JB
3586 * w32.c (read_unc_volume): Use parameter `henum', instead of
3587 global variable `wget_enum_handle'.
3588
3589 * keymap.c (describe_vector): Remove parameters `indices' and
3590 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3591 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3592
f868cd8a
JB
3593 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3594
3595 * keyboard.c (timer_check): Remove parameter `do_it_now',
3596 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3597 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3598 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3599
3600 * keyboard.c (read_char):
3601 * w32menu.c (w32_menu_display_help):
3602 * xmenu.c (show_help_event, menu_help_callback):
3603 Adjust calls to `show_help_echo'.
3604
3605 * gtkutil.c (xg_maybe_add_timer):
3606 * keyboard.c (readable_events):
3607 * process.c (wait_reading_process_output):
3608 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3609
3610 * insdel.c (adjust_markers_gap_motion):
3611 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3612 (gap_left, gap_right): Don't call it.
3613
2ecf6fdb
CY
36142011-03-25 Chong Yidong <cyd@stupidchicken.com>
3615
3616 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3617 incurred during fontification.
3618
6b1f9ba4
JB
36192011-03-25 Juanma Barranquero <lekktu@gmail.com>
3620
3621 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3622 (DEFVAR_PER_BUFFER): Don't pass it.
3623
3624 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3625 (scrolling_window): Don't pass it.
3626
0f4a96b5
JB
36272011-03-25 Juanma Barranquero <lekktu@gmail.com>
3628
3629 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3630
3631 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3632 and `suffix'.
3633 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3634 of variables specific to SELinux and computation of `encoded_absname'.
3635
3636 * image.c (XPutPixel): Remove unused variable `height'.
3637
3638 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3639
3640 * unexw32.c (get_section_info): Remove unused variable `section'.
3641
3642 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3643 (system_process_attributes): Remove unused variable `sess'.
3644 (sys_read): Remove unused variable `err'.
3645
3646 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3647 (w32_wnd_proc): Remove unused variable `isdead'.
3648 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3649 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3650 (x_create_tip_frame): Remove unused variable `tem'.
3651
3652 * w32inevt.c (w32_console_read_socket):
3653 Remove unused variable `no_events'.
3654
3655 * w32term.c (x_draw_composite_glyph_string_foreground):
3656 Remove unused variable `width'.
3657
1149507c
JB
36582011-03-24 Juanma Barranquero <lekktu@gmail.com>
3659
3660 * w32term.c (x_set_glyph_string_clipping):
3661 Don't pass uninitialized region to CombineRgn.
3662
9c88f339
JB
36632011-03-23 Juanma Barranquero <lekktu@gmail.com>
3664
3665 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3666 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3667 (Fx_close_connection): Remove unused variable `i'.
3668
3669 * w32font.c (w32font_draw): Return number of glyphs.
3670 (w32font_open_internal): Remove unused variable `i'.
3671 (w32font_driver): Add missing initializer.
3672
3673 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3674 (fill_in_menu): Remove unused variable `items_added'.
3675
3676 * w32term.c (last_mouse_press_frame): Remove static global variable.
3677 (w32_clip_to_row): Remove unused variable `f'.
3678 (x_delete_terminal): Remove unused variable `i'.
3679
3680 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3681 (NOTHING): Remove unused static global variable.
3682 (uniscribe_check_otf): Remove unused variable `table'.
3683 (uniscribe_font_driver): Add missing initializers.
3684
dee091a3
JD
36852011-03-23 Julien Danjou <julien@danjou.info>
3686
3687 * term.c (Fsuspend_tty, Fresume_tty):
3688 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3689 * window.c (temp_output_buffer_show):
3690 * insdel.c (signal_before_change):
3691 * frame.c (Fhandle_switch_frame):
3692 * fileio.c (Fdo_auto_save):
3693 * emacs.c (Fkill_emacs):
3694 * editfns.c (save_excursion_restore):
3695 * cmds.c (internal_self_insert):
3696 * callint.c (Fcall_interactively):
3697 * buffer.c (Fkill_all_local_variables):
3698 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3699 Use Frun_hooks.
0f4a96b5 3700 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3701 unconditionnaly since it does the check itself.
3702
2c520ab5 37032011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3704
c9c49752
PE
3705 Fix more problems found by GCC 4.5.2's static checks.
3706
8abc3f12
PE
3707 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3708 the first time through the loop, since we know p0 < p1 then.
3709 This also avoids a gcc -Wstrict-overflow warning.
3710
a2d26660
PE
3711 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3712 leading to a memory leak, possible in functions like
3713 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3714 of objects (Bug#8318).
a2d26660 3715
916c72e9
PE
3716 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3717 that could (at least in theory) be that large.
3718
19ab8a18
PE
3719 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3720 This is less likely to overflow, and avoids undefined behavior if
3721 overflow does occur. All callers changed. Use strtoul to scan
3722 for the unsigned long integer.
b7cbbd6f
PE
3723 (pint2hrstr): Simplify and tune code slightly.
3724 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3725
f0641eff
PE
3726 * scroll.c (do_scrolling): Work around GCC bug 48228.
3727 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3728
7f650bb9
PE
3729 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3730 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3731 (validate_x_resource_name): Simplify count usage.
3732 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3733
37dd57d1
PE
3734 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3735 fail (Bug#8306).
81e56e61 3736
699979fc 3737 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3738
401bf9b4
PE
3739 * process.c (Fmake_network_process): Use socklen_t, not int,
3740 where POSIX says socklen_t is required in portable programs.
3741 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3742 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3743 (Fmake_network_process, server_accept_connection):
3744 (wait_reading_process_output, read_process_output):
3745 Likewise.
3746
b93aacde
PE
3747 * process.c: Rename or move locals to avoid shadowing.
3748 (list_processes_1, Fmake_network_process):
3749 (read_process_output_error_handler, exec_sentinel_error_handler):
3750 Rename or move locals.
4dc343ee 3751 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3752 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3753 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3754 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3755 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3756
af8a867c 3757 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3758 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3759 Include tparam.h instead, since it declares them.
af8a867c
PE
3760 * cm.h (PC): Remove extern decl; tparam.h now does this.
3761 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3762 * terminfo.c: Include tparam.h, to check interfaces.
3763 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3764 (tparam): Adjust signature to match interface in tparam.h;
3765 this removes some undefined behavior. Check that outstring and len
3766 are zero, which they always are with Emacs.
3767 * tparam.h (PC, BC, UP): New extern decls.
3768
0248044d 3769 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3770 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3771
8ff096c1 3772 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3773 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3774 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3775 (ftfont_list): Remove unused local.
49eaafba
PE
3776 (get_adstyle_property, ftfont_pattern_entity):
3777 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3778 Rename locals to avoid shadowing.
8ff096c1 3779
e2be39f6
PE
3780 * xfont.c (xfont_list_family): Mark var as initialized.
3781
c9735e30
PE
3782 * xml.c (make_dom): Now static.
3783
8f5201ae
PE
3784 * composite.c (composition_compute_stop_pos): Rename local to
3785 avoid shadowing.
b246f932
PE
3786 (composition_reseat_it): Remove unused locals.
3787 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3788 (composition_update_it): Mark var as initialized.
11b61122
PE
3789 (find_automatic_composition): Mark vars as initialized,
3790 with a FIXME (Bug#8290).
8f5201ae 3791
760fbc2c
PE
3792 character.h: Rename locals to avoid shadowing.
3793 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3794 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3795 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3796 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3797 to avoid shadowing.
3798
ff08eb85
PE
3799 * textprop.c (property_change_between_p): Remove; unused.
3800
fc7bf025
PE
3801 * intervals.c (interval_start_pos): Now static.
3802
235d7abc
PE
3803 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3804
44f230aa
SM
3805 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3806 Rename locals to avoid shadowing.
3e7d6594 3807
50060332
PE
3808 * sound.c (wav_play, au_play, Fplay_sound_internal):
3809 Fix pointer signedness.
d01f234b 3810 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3811 (wav_play): Initialize a variable to 0, to prevent undefined
3812 behavior (Bug#8278).
50060332 3813
c4fc4e30
PE
3814 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3815
918436ed
PE
3816 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3817
c939f91b
PE
3818 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3819 clobbering (Bug#8298).
b9c7f648
PE
3820 * sysdep.c (sys_subshell): Likewise.
3821 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3822
6bd8c144
PE
3823 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3824 This should get cleaned up, so that child_setup has the
3825 same signature on all platforms.
3826
7710357c 3827 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3828 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3829
c59da222
CY
38302011-03-22 Chong Yidong <cyd@stupidchicken.com>
3831
3832 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3833 not to be necessary, and produces flickering.
3834
66b87493
GM
38352011-03-20 Glenn Morris <rgm@gnu.org>
3836
3837 * config.in: Remove file.
3838
45b6f6d5
JB
38392011-03-20 Juanma Barranquero <lekktu@gmail.com>
3840
3841 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3842 are now in src/globals.h.
3843 (syms_of_minibuf): Remove spurious & from previous change.
3844
3ec03f7e
LL
38452011-03-20 Leo <sdl.web@gmail.com>
3846
3847 * minibuf.c (completing-read-function): New variable.
3848 (completing-read-default): Rename from completing-read.
3849 (completing-read): Call completing-read-function.
3850
b14e3e21
CY
38512011-03-19 Juanma Barranquero <lekktu@gmail.com>
3852
3853 * xfaces.c (Fx_load_color_file):
3854 Read color file from absolute filename (bug#8250).
3855
f2b726e6
JB
38562011-03-19 Juanma Barranquero <lekktu@gmail.com>
3857
3858 * makefile.w32-in: Update dependencies.
3859
09f6ff02
EZ
38602011-03-17 Eli Zaretskii <eliz@gnu.org>
3861
3862 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3863
29a6015a
PE
38642011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3865
a3a6c54e
PE
3866 Fix more problems found by GCC 4.5.2's static checks.
3867
b766f867
PE
3868 * process.c (make_serial_process_unwind, send_process_trap):
3869 (sigchld_handler): Now static.
3870
be02381c
PE
3871 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3872 That way, the code declares only the vars that it needs.
3873 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3874 * s/cygwin.h (PTY_ITERATION): Likewise.
3875 * s/darwin.h (PTY_ITERATION): Likewise.
3876 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3877
57048744
PE
3878 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3879 * process.c (allocate_pty): Don't declare stb unless it's needed.
3880
7914961c 3881 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3882 (CONSTANTLIM): Remove; unused.
3883 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3884 Define only if needed.
7914961c 3885
b3967b18
PE
3886 * unexelf.c (unexec): Name an expression,
3887 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3888 Use a different way to cause a compilation error if anyone uses
3889 n rather than nn, a way that does not involve shadowing.
73366a00 3890 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3891
29a6015a
PE
3892 * deps.mk (unexalpha.o): Remove; unused.
3893
43cfc33e 3894 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3895 * unexec.h: New file.
ce701a33
PE
3896 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3897 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3898 Depend on unexec.h.
3899 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3900 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3901 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3902 Change as necessary to match prototype in unexec.h.
ce701a33 3903
01f44d5a
PE
3904 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3905 shadowing.
4f63c6bb 3906 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3907
a6670b0b
PE
3908 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3909 Rename locals to avoid shadowing.
3910
cef2010d 3911 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3912 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3913
d4d7173a
PE
3914 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3915
f08b802a
PE
3916 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3917 warning when compiling print.c.
3918
3ddb0639
PE
3919 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3920 instead of using an uninitialized var.
5ad03b97 3921 (font_sort_entities): Mark var as initialized.
3ddb0639 3922
170a2692
PE
3923 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3924
e663c700
PE
3925 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3926 pointers to constants.
89bc529a 3927 (font_parse_fcname): Remove unused vars.
7b81e2d0 3928 (font_delete_unmatched): Now static.
ea838e10 3929 (font_get_spec): Remove; unused.
13a547c6
PE
3930 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3931 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3932 Rename or move locals to avoid shadowing.
e663c700 3933
2a80c887 3934 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3935 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3936
1384fa33 3937 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3938 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3939
8b2c52e9
PE
3940 * alloc.c (mark_backtrace): Move decl from here ...
3941 * lisp.h: ... to here, so that it can be checked.
3942
475545b5 3943 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3944 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3945 (lisp_indirect_variable): Name an expression,
3946 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3947 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3948
b1349114 3949 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3950 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3951 Use const pointer when appropriate.
b1349114 3952
a2928364
PE
3953 * lisp.h (get_system_name, get_operating_system_release):
3954 Move decls here, to check interfaces.
3955 * process.c (get_operating_system_release): Move decl to lisp.h.
3956 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3957 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3958 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3959 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3960 (Fformat_time_string, Fencode_time, Finsert_char):
3961 (Ftranslate_region_internal, Fformat):
3962 Rename or remove local vars to avoid shadowing.
9710023e 3963 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3964
a415e694
PE
3965 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3966 avoid shadowing.
3967
8ef4622d
PE
3968 * lisp.h (eassert): Check that the argument compiles, even if
3969 ENABLE_CHECKING is not defined.
3970
946f9a5b
PE
3971 * data.c (Findirect_variable): Name an expression, to avoid
3972 gcc -Wbad-function-cast warning.
112396d6 3973 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3974 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3975 (Fmake_variable_buffer_local, Fmake_local_variable):
3976 Mark variables as initialized.
52746918 3977 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3978
e5aab7e7 3979 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3980 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3981 Rename locals to avoid shadowing.
dff45157
PE
3982 (mark_stack): Move local variables into the #ifdef region where
3983 they're used.
7bc26fdb
PE
3984 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3985 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3986 needed otherwise.
3987 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3988 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3989 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3990
e5aab7e7
PE
3991 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3992 avoids undefined behavior in theory.
3993
4da60324
PE
3994 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3995
88043301
PE
3996 Use functions, not macros, for up- and down-casing (Bug#8254).
3997 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3998 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3999 to use the following functions instead of these macros.
4000 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4001 EMACS_INT, since callers assume the returned value fits in int.
4002 (upcase1): Likewise, for UPCASE_TABLE.
4003 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4004 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4005 the race-condition problem in the old DOWNCASE.
88043301 4006
19ed5445
PE
4007 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4008 Rename locals to avoid shadowing.
4009 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4010 (regex_compile, re_search_2, re_match_2_internal):
4011 Remove unused local vars.
952db0d7
PE
4012 (FREE_VAR): Rewrite so as not to use empty "else",
4013 which gcc can warn about.
da053e48 4014 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4015 (RETALLOC_IF): Define only if needed.
4016 (WORDCHAR_P): Likewise. This one is never needed, but is used
4017 only in a comment talking about a compiler bug, so put inside
4018 the #if 0 of that comment.
4019 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4020 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4021 Remove; unused.
19ed5445 4022
1f3561e4 4023 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4024 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4025 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4026
ded6f8f7
PE
4027 * search.c (simple_search): Remove unused var.
4028
dbd37a95
PE
4029 * dired.c (compile_pattern): Move decl from here ...
4030 * lisp.h: ... to here, so that it can be checked.
4031 (struct re_registers): New forward decl.
4032
7e47afad
PE
4033 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4034
85f24f61
PE
4035 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4036 All uses changed.
4037 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4038 Rename locals to avoid shadowing.
5671df8f 4039 (Fvertical_motion): Mark locals as initialized.
85f24f61 4040
181aa2be 4041 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4042 (casify_region): Mark local as initialized.
181aa2be 4043
930d429c
PE
4044 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4045
7082eac6
PE
4046 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4047 New macros, so that the caller can use some names other than
4048 gcpro1, gcpro2, etc.
4049 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4050 of the new macros.
4051 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4052 argument, for consistency with GCPRO2_VAR, etc: it is now the
4053 prefix of the variable, not the variable itself. All uses
4054 changed.
38b2c076
PE
4055 * dired.c (directory_files_internal, file_name_completion):
4056 Rename locals to avoid shadowing.
4057
15206ed9
PE
4058 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4059 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4060 dired.c's scmp function, had undefined behavior.
4061 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4062 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4063 * buffer.h: ... to here, because these macros use current_buffer,
4064 and the new implementation with inline functions needs to have
4065 current_buffer in scope now, rather than later when the macros
4066 are used.
4067 (downcase, upcase1): New static inline functions.
4068 (DOWNCASE, UPCASE1): Reimplement using these functions.
4069 This avoids undefined behavior in expressions like
4070 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4071 from race conditions in accessing the global variables
4072 case_temp1 and case_temp2.
4073 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4074 * lisp.h (case_temp1, case_temp2): Remove their decls.
4075 * character.h (ASCII_CHAR_P): Move from here ...
4076 * lisp.h: ... to here, so that the inline functions mentioned
4077 above can use them.
4078
4a6bea26
PE
4079 * dired.c (directory_files_internal_unwind): Now static.
4080
f14b7e14
PE
4081 * fileio.c (file_name_as_directory, directory_file_name):
4082 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4083 Now static.
2893f146
PE
4084 (file_name_as_directory): Use const pointers when appropriate.
4085 (Fexpand_file_name): Likewise. In particular, newdir might
4086 point at constant storage, so make it a const pointer.
fd4ead52 4087 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4088 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4089 signedness issues.
f839df0c
PE
4090 (Fset_file_times, Finsert_file_contents, auto_save_error):
4091 Rename locals to avoid shadowing.
f14b7e14 4092
5716756e 4093 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4094 (Ftry_completion, Fall_completions): Rename or remove locals
4095 to avoid shadowing.
5716756e 4096
b4c3046a
PE
4097 * marker.c (bytepos_to_charpos): Remove; unused.
4098
b45db522
PE
4099 * lisp.h (verify_bytepos, count_markers): New decls,
4100 so that gcc does not warn that these functions aren't declared.
4101
85876d07
PE
4102 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4103 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4104 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4105 (copy_text): Remove unused local var.
85876d07 4106
03d78a21 4107 * filelock.c (within_one_second): Now static.
b3dd38ab 4108 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4109
5df8f01b
PE
4110 * buffer.c (fix_overlays_before): Mark locals as initialized.
4111 (fix_start_end_in_overlays): Likewise. This function should be
4112 simplified by using pointers-to-pointers, but that's a different
4113 matter.
b1d876f1 4114 (switch_to_buffer_1): Now static.
8f54f30a
PE
4115 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4116 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4117
a70072c9 4118 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4119 Fix pointer signedness issue.
edced198
PE
4120 (sys_subshell): Mark local as volatile if checking for lint,
4121 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4122 (MAXPATHLEN): Define only if needed.
a70072c9 4123
a0977c44
PE
4124 * process.c (serial_open, serial_configure): Move decls from here ...
4125 * systty.h: ... to here, so that they can be checked.
4126
a884fdcc
PE
4127 * fns.c (get_random, seed_random): Move extern decls from here ...
4128 * lisp.h: ... to here, so that they can be checked.
4129
604efe86 4130 * sysdep.c (reset_io): Now static.
b8950c94 4131 (wait_for_termination_signal): Remove; unused.
604efe86 4132
38fc62d9
PE
4133 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4134 (copy_keymap_item, append_key, push_text_char_description):
4135 Now static.
1004a21a 4136 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4137 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4138 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4139 (describe_map_tree):
4140 Rename locals to avoid shadowing.
38fc62d9 4141
2f2650da
PE
4142 * keyboard.c: Declare functions static if they are not used elsewhere.
4143 (echo_char, echo_dash, cmd_error, top_level_2):
4144 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4145 (read_char, kbd_buffer_get_event, make_lispy_position):
4146 (make_lispy_event, make_lispy_movement, apply_modifiers):
4147 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4148 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4149 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4150 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4151 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4152
a053e86c 4153 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4154 (mark_kboards): Move decl here ...
4155 * alloc.c (mark_kboards): ... from here.
a053e86c 4156
4752793e
PE
4157 * lisp.h (force_auto_save_soon): New decl.
4158
74f10ca7 4159 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4160 (DEFINE_DUMMY_FUNCTION): New macro.
4161 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4162 Use it.
c03cd23f
PE
4163 (main): Add casts to avoid warnings
4164 if GCC considers string literals to be constants.
74f10ca7 4165
022e70d4
PE
4166 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4167
59d6fe83
PE
4168 * dbusbind.c: Pointer signedness fixes.
4169 (xd_signature, xd_append_arg, xd_initialize):
4170 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4171 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4172 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4173 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4174
78320123
PE
4175 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4176 if GCC considers string literals to be constants.
49cebcca 4177 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4178
35ac2a97
SM
41792011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4180
fb103ca9
SM
4181 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4182 (print_preprocess, print_object): New macro to fix last change.
4183
35ac2a97
SM
4184 * print.c (print_preprocess): Don't forget font objects.
4185
62973b41
JB
41862011-03-16 Juanma Barranquero <lekktu@gmail.com>
4187
4188 * emacs.c (USAGE3): Doc fixes.
4189
0e48bb22
AS
41902011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4191
4192 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4193 structure.
4194
7684e57b
JB
41952011-03-14 Juanma Barranquero <lekktu@gmail.com>
4196
4197 * lisp.h (VWindow_system, Qfile_name_history):
4198 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4199 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4200 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4201
4202 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4203 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4204
4205 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4206 * w32console.c (detect_input_pending, read_input_pending)
4207 (encode_terminal_code):
4208 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4209 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4210 (w32_system_caret_y, Qfile_name_history):
4211 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4212 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4213 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4214 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4215 * w32proc.c (Qlocal, report_file_error):
4216 * w32term.c (Vwindow_system, updating_frame):
4217 * w32uniscribe.c (initialized, uniscribe_font_driver):
4218 Remove unneeded extern declarations.
4219
2aa46d6c
CY
42202011-03-14 Chong Yidong <cyd@stupidchicken.com>
4221
c96bbc66 4222 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4223
cffc6f3b
CY
42242011-03-13 Chong Yidong <cyd@stupidchicken.com>
4225
4226 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4227 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4228 These macros can no longer be used for assignment.
4229
44f230aa
SM
4230 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4231 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4232 (record_buffer_markers, fetch_buffer_markers): New functions for
4233 recording and fetching special buffer markers.
4234 (set_buffer_internal_1, set_buffer_temp): Use them.
4235
4236 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4237
4238 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4239
4240 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4241 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4242
4243 * xdisp.c (hscroll_window_tree):
4244 (reconsider_clip_changes): Use PT instead of BUF_PT.
4245
d251f04b
EZ
42462011-03-13 Eli Zaretskii <eliz@gnu.org>
4247
4248 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4249 $(EMACS_ROOT)/lib/intprops.h.
4250
f0c77cd1
PE
42512011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4252
3eca4629
PE
4253 Fix more problems found by GCC 4.5.2's static checks.
4254
7c86ee98
PE
4255 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4256 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4257 (xg_free_frame_widgets): Make it clear that a local variable is
4258 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4259 (gdk_window_get_screen): Make it clear that this macro is needed
4260 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4261 (int_gtk_range_get_value): New function, which avoids a diagnostic
4262 from gcc -Wbad-function-cast.
4263 (xg_set_toolkit_scroll_bar_thumb): Use it.
4264 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4265 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4266 (get_utf8_string, xg_get_file_with_chooser):
4267 Rename locals to avoid shadowing.
4268 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4269
41729b81
PE
4270 * xgselect.c (xg_select): Remove unused var.
4271
f0c77cd1
PE
4272 * image.c (four_corners_best): Mark locals as initialized.
4273 (gif_load): Initialize transparent_p to zero (Bug#8238).
4274 Mark another local as initialized.
ec6cf4c6 4275 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4276
ce0ad53d 4277 * image.c (clear_image_cache): Now static.
d5d5a617 4278 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4279 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4280 (x_edge_detection): Remove unnecessary cast that
4281 gcc -Wbad-function-cast diagnoses.
2037898d 4282 (gif_load): Fix pointer signedness.
6ae141d6
PE
4283 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4284 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4285
33383987 42862011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4287
d32df629
PE
4288 Improve quality of tests for time stamp overflow.
4289 For example, without this patch (encode-time 0 0 0 1 1
4290 1152921504606846976) returns the obviously-bogus value (-948597
4291 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4292 reports time overflow. See
4293 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4294 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4295 * editfns.c: Include limits.h and intprops.h.
4296 (TIME_T_MIN, TIME_T_MAX): New macros.
4297 (time_overflow): Move earlier, to before first use.
4298 (hi_time, lo_time): New functions, for an accurate test for
4299 out-of-range times.
4300 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4301 (Fget_internal_run_time): Don't assume time_t fits in int.
4302 (make_time): Use list2 instead of Fcons twice.
4303 (Fdecode_time): More accurate test for out-of-range times.
4304 (check_tm_member): New function.
4305 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4306 (lisp_time_argument): Don't rely on undefined left-shift and
4307 right-shift behavior when checking for time stamp overflow.
8be6f318 4308
fe31d94c
PE
4309 * editfns.c (time_overflow): New function, refactoring common code.
4310 (Fformat_time_string, Fdecode_time, Fencode_time):
4311 (Fcurrent_time_string): Use it.
4312
8be6f318
PE
4313 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4314 * dired.c (make_time): Move to ...
4315 * editfns.c (make_time): ... here.
4316 * systime.h: Note the move.
4317
09d9db2c 43182011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4319
126bc0dc
YM
4320 * fringe.c (update_window_fringes): Remove unused variables.
4321
c47cbdfd
YM
4322 * unexmacosx.c (copy_data_segment): Also copy __got section.
4323 (Bug#8223)
4324
7ac80be9
EZ
43252011-03-12 Eli Zaretskii <eliz@gnu.org>
4326
c96bbc66 4327 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4328 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4329 Constify `char *' arguments and their references according to
4330 prototypes in tparam.h.
4331
ecb0f94d 4332 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4333
7ac80be9
EZ
4334 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4335 Adapt all references accordingly.
4336
4337 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4338
ef1fd07e
TT
43392011-03-11 Tom Tromey <tromey@redhat.com>
4340
4341 * buffer.c (syms_of_buffer): Remove obsolete comment.
4342
7ef4b50c
EZ
43432011-03-11 Eli Zaretskii <eliz@gnu.org>
4344
4345 * termhooks.h (encode_terminal_code): Declare prototype.
4346
4347 * msdos.c (encode_terminal_code): Don't declare prototype.
4348
4349 * term.c (encode_terminal_code): Now external again, used by
4350 w32console.c and msdos.c.
4351
44f230aa
SM
4352 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4353 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4354
4b1ec863 43552011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4356
1714f52b 4357 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4358
4b1ec863
PE
4359 * fringe.c (update_window_fringes): Mark locals as initialized
4360 (Bug#8227).
4361 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4362
524c7aa6
PE
4363 * alloc.c (mark_fringe_data): Move decl from here ...
4364 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4365 to check its interface.
4366 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4367
a5c0af81 4368 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4369 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4370 (fontset_font): Mark local as initialized.
a9a06e0b 4371 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4372
b4716021
PE
4373 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4374
811e9bac 4375 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4376 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4377 (x_own_selection, Fx_disown_selection_internal): Rename locals
4378 to avoid shadowing.
4379 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4380
7e3ab302
PE
4381 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4382 so that the caller can use some name other than gcpro1.
4383 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4384 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4385 (Fx_backspace_delete_keys_p):
4386 Use them to avoid shadowing, and rename vars to avoid shadowing.
4387 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4388 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4389 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4390 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4391 Remove unused locals.
7e3ab302
PE
4392 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4393 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4394 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4395 macros.
f78faa98 4396
e2b13473
PE
4397 * xterm.h (x_mouse_leave): New decl.
4398
77f23912
PE
4399 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4400 Remove unused functions.
cdf4ba58
PE
4401 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4402 (x_calc_absolute_position): Now static.
7411c686 4403 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4404 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4405 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4406 unless they are used.
38d0b34a
PE
4407 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4408 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4409 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4410 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4411 (x_error_catcher, x_connection_closed, x_error_handler):
4412 (x_error_quitter, xembed_send_message, x_iconify_frame):
4413 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4414 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4415 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4416
44f230aa
SM
4417 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4418 Rename or move locals to avoid shadowing.
6b463e58 4419 (tty_defined_color, merge_face_heights): Now static.
5967d051 4420 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4421 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4422 does not deduce is never used uninitialized.
73719eba
PE
4423 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4424 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4425
426994c3 4426 * terminal.c (store_terminal_param): Now static.
5489860b 4427
032f1620 4428 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4429 (set_frame_menubar): Remove unused local.
d4323972 4430 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4431 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4432 since they might point to immutable storage.
281585b0
PE
4433 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4434 since it's unused otherwise.
032f1620 4435
367c19e5 4436 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4437 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4438 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4439 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4440 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4441 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4442 does not deduce are never used uninitialized.
70739cbe 4443
07b48fa9
PE
4444 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4445
8868a238 4446 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4447 * window.c (window_loop, size_window):
4448 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4449
7e5cf297 4450 * window.c (display_buffer): Now static.
d6550a9f
PE
4451 (size_window): Mark variables that gcc -Wuninitialized
4452 does not deduce are never used uninitialized.
a586633d
PE
4453 * window.h (check_all_windows): New decl, to forestall
4454 gcc -Wmissing-prototypes diagnostic.
5b555da1 4455 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4456
f6095868
PE
4457 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4458 shadowing.
4459 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4460 Include <limits.h>.
4461 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4462 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4463 (load_charset_map): Mark variables that gcc -Wuninitialized
4464 does not deduce are never used uninitialized.
53df7c11 4465 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4466
f38b440c
PE
4467 * coding.c (coding_set_source, coding_set_destination):
4468 Use "else { /* comment */ }" rather than "else /* comment */;"
4469 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4470 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4471 a block, when the outer 'i' will do.
4472 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4473 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4474 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4475 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4476 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4477 Rename locals to avoid shadowing.
4478 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4479 * coding.c (emacs_mule_char, encode_invocation_designation):
4480 Now static, since they're not used elsewhere.
413bb2db 4481 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4482 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4483 (decode_coding_emacs_mule): Mark variables that gcc
4484 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4485 (detect_coding_iso_2022): Initialize a local variable that might
4486 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4487 this initialization is needed. (Bug#8211)
5f58e762
PE
4488 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4489 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4490 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4491 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4492 Remove unused macros.
f38b440c 4493
232b38b9 4494 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4495 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4496 * character.c (string_count_byte8): Likewise.
232b38b9 4497
fb90da1b
PE
4498 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4499 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4500
fb93dbc2
PE
4501 * chartab.c (copy_sub_char_table): Now static, since it's not used
4502 elsewhere.
5c156ace
PE
4503 (sub_char_table_ref_and_range, char_table_ref_and_range):
4504 Rename locals to avoid shadowing.
bbcd0949 4505 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4506
7d3b3862 4507 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4508 (BIDI_BOB): Remove unused macro.
7d3b3862 4509
6be7d3da
PE
4510 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4511 deduce are never used uninitialized.
c2ed9c8b 4512 * term.c (encode_terminal_code): Likewise.
6be7d3da 4513
75f8807f 4514 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4515
50938595
PE
4516 * tparam.h: New file.
4517 * term.c, tparam.h: Include it.
4518 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4519 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4520 Move these decls to tparam.h, and make them agree with what
4521 is actually in tparam.c. The previous trick of using incompatible
4522 decls in different modules does not conform to the C standard.
4523 All callers of tparam changed to use tparam's actual API.
4524 * tparam.c (tparam1, tparam, tgoto):
4525 Use const pointers where appropriate.
4526
fbceeba2
PE
4527 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4528 * cm.h (struct cm): Likewise.
4529 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4530 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4531 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4532 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4533 (turn_on_face, init_tty): Likewise.
4534 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4535
7f3f1250
PE
4536 * term.c (term_mouse_position): Rename local to avoid shadowing.
4537
e6ca6543
PE
4538 * alloc.c (mark_ttys): Move decl from here ...
4539 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4540
c40f8d15
AS
45412011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4542
4543 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4544
cfe0661d
JB
45452011-03-09 Juanma Barranquero <lekktu@gmail.com>
4546
4547 * search.c (compile_pattern_1): Remove argument regp, unused since
4548 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4549 (compile_pattern): Don't pass it.
4550
0afb4571
J
45512011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4552
4553 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4554 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4555 for ! HAVE_GTK3.
4556 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4557
4558 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4559
4560 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4561 gdk_window_get_screen, gdk_window_get_geometry,
4562 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4563 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4564 (xg_get_pixbuf_from_pixmap): New function.
4565 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4566 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4567 Call xg_get_pixbuf_from_pixmap instead of
4568 gdk_pixbuf_get_from_drawable.
4569 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4570 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4571 (xg_check_special_colors): Use GtkStyleContext and its functions
4572 for HAVE_GTK3.
4573 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4574 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4575 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4576 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4577 Call gtk_widget_get_preferred_size.
0afb4571
J
4578 (xg_frame_resized): gdk_window_get_geometry only takes 5
4579 parameters.
44f230aa
SM
4580 (xg_win_to_widget, xg_event_is_for_menubar):
4581 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4582 (xg_set_widget_bg): New function.
4583 (delete_cb): New function.
895009e1 4584 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4585 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4586 (xg_set_background_color): Call xg_set_widget_bg.
4587 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4588 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4589 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4590 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4591 if ! HAVE_GTK3.
4592 (update_frame_tool_bar): Call gtk_widget_hide.
4593 (xg_initialize): Use GDK_KEY_g.
4594
4595 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4596 if ! HAVE_GTK3
4597 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4598
4599 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4600 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4601 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4602
1c2cc4ef
JB
46032011-03-08 Juanma Barranquero <lekktu@gmail.com>
4604
4605 * w32xfns.c (select_palette): Check success of RealizePalette against
4606 GDI_ERROR, not zero.
4607
33383987 4608See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4609
4610;; Local Variables:
4611;; coding: utf-8
aac0c6e3
MR
4612;; End:
4613
33383987 4614 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4615
4616 This file is part of GNU Emacs.
4617
4618 GNU Emacs is free software: you can redistribute it and/or modify
4619 it under the terms of the GNU General Public License as published by
4620 the Free Software Foundation, either version 3 of the License, or
4621 (at your option) any later version.
4622
4623 GNU Emacs is distributed in the hope that it will be useful,
4624 but WITHOUT ANY WARRANTY; without even the implied warranty of
4625 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4626 GNU General Public License for more details.
4627
4628 You should have received a copy of the GNU General Public License
4629 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.