Let configure set DEFAULT_SOUND_DEVICE
[bpt/emacs.git] / src / ChangeLog
CommitLineData
20e94fdd
GM
12012-07-11 Glenn Morris <rgm@gnu.org>
2
3 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
4 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
5
e99a530f
PE
62012-07-10 Paul Eggert <eggert@cs.ucla.edu>
7
22ffb973
PE
8 Remove "#define unix" that is no longer needed (Bug#11905).
9 * s/aix4-2.h (unix): Remove; no longer needed.
10
e9a9ae03
PE
11 EMACS_TIME simplification (Bug#11875).
12 This replaces macros (which typically do not work in GDB)
13 with functions, typedefs and enums, making the code easier to debug.
14 The functional style also makes code easier to read and maintain.
15 * systime.h: Include <sys/time.h> on all hosts, not just if
16 WINDOWSNT, since 'struct timeval' is needed in general.
17 (EMACS_TIME): Now a typedef, not a macro.
18 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
19 not macros.
20 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
21 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
22 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
23 (EMACS_TIME_LE): Now functions, not macros.
24 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
25 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
26 which are not functions. All uses rewritten to use:
27 (make_emacs_time): New function.
28 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
29 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
30 not functions. All uses rewritten to use the following, respectively:
31 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
32 (add_emacs_time, sub_emacs_time): New functions.
33 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
34 * fileio.c (Fcopy_file):
35 * xterm.c (XTflash): Get the current time closer to when it's used.
36 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
37
ffacb126
PE
38 * bytecode.c (targets): Suppress -Woverride-init warnings.
39
e99a530f
PE
40 Simplify by avoiding confusing use of strncpy etc.
41 * doc.c (Fsnarf_documentation):
42 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
43 * frame.c (Fmake_terminal_frame):
44 * gtkutil.c (get_utf8_string):
45 * lread.c (openp):
46 * nsmenu.m (ns_update_menubar):
47 * regex.c (regerror):
48 Prefer memcpy to strncpy and strncat when either will do.
49 * fileio.c (Fsubstitute_in_file_name):
50 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
51 (menu_separator_name_p):
52 * nsmenu.m (ns_update_menubar):
53 Prefer memcmp to strncmp when either will do.
54 * nsterm.m: Include <ftoastr.h>.
55 (ns_get_color):
56 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
57 Prefer snprintf to strncpy.
58 * nsterm.m (ns_term_init):
59 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
60 * nsterm.m (ns_term_init):
61 Avoid the need for strncpy, by using build_string or
62 make_unibyte_string directly. Use dtoastr, not snprintf.
63 * process.c (Fmake_network_process): Diagnose service names that
64 are too long, rather than silently truncating them or creating
65 non-null-terminated names.
66 (Fnetwork_interface_info): Likewise, for interface names.
67 * sysdep.c (system_process_attributes) [GNU_LINUX]:
68 Prefer sprintf to strncat.
69 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
70 Prefer vsnprintf to vsprintf + strncpy.
71
c59592b3
GM
722012-07-10 Glenn Morris <rgm@gnu.org>
73
74 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
75 Clarify fallback case.
76
7d7bbefd
DA
772012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
78
79 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
80 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
81 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
82 * w32menu.c, window.c, xmenu.c: Changed to use XCAR and XCDR
83 where argument type is known to be a Lisp_Cons.
84
3a4c8000
TT
852012-07-10 Tom Tromey <tromey@redhat.com>
86
87 * bytecode.c (BYTE_CODE_THREADED): New macro.
88 (BYTE_CODES): New macro. Replaces all old byte-code defines.
89 (enum byte_code_op): New type.
90 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
91 (exec_byte_code): Use them. Use token threading when applicable.
92
2a0213a6
DA
932012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
94
95 Optimize pure C strings initialization.
96 * lisp.h (make_pure_string): Fix prototype.
97 (build_pure_c_string): New function, defined as static inline. This
98 provides a better opportunity to optimize away calls to strlen when
99 the function is called with compile-time constant argument.
100 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
101 argument, adjust users accordingly. Use build_pure_c_string where
102 appropriate.
103 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
104 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
105 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
106
cb1caeaf
DA
1072012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
108
109 Avoid calls to strlen in miscellaneous functions.
110 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
111 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
112 * lread.c (openp): Likewise.
113
c293e30c
DA
1142012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
115
116 Avoid calls to strlen in path processing functions.
117 * fileio.c (file_name_as_directory): Add comment. Change to add
118 srclen argument and return the length of result. Adjust users
119 accordingly.
120 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 121 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
122 users accordingly.
123 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
124
9e059e3f
GM
1252012-07-10 Glenn Morris <rgm@gnu.org>
126
d02eb359
GM
127 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
128 Move PENDING_OUTPUT_COUNT definition to configure.
129
882cf227
GM
130 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
131 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
132 * s/gnu.h (DATA_START): Move definitions to configure.
133
af6e839f
GM
134 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
135 We include usg5-4-common.h, which defines them both.
136
40289a12
GM
137 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
138 O_RDONLY already includes it).
139
9e059e3f
GM
140 Stop ns builds setting the EMACSLOADPATH environment variable.
141 * nsterm.m (ns_load_path): Rename from ns_init_paths.
142 Now it does not set EMACSLOADPATH, just returns the load-path string.
143 * nsterm.h: Update accordingly.
144 * lread.c [HAVE_NS]: Include nsterm.h.
145 (init_lread) [HAVE_NS]: Use ns_load_path.
146 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
147
7c4e8ec0
GM
1482012-07-09 Glenn Morris <rgm@gnu.org>
149
d4f600ff
GM
150 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
151 since the included bsd-common.h does so.
152
cbb31951
GM
153 Stop ns builds setting the EMACSPATH environment variable.
154 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
155 (ns_init_paths): Do not set EMACSPATH.
156 * nsterm.h (ns_exec_path): Add it.
157 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
158 Use ns_exec_path.
159
7c4e8ec0
GM
160 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
161
26bccfae
PE
1622012-07-09 Paul Eggert <eggert@cs.ucla.edu>
163
a0bee46f
PE
164 * process.c (wait_reading_process_output): 'waitchannels' was unset
165 when read_kbd || !NILP (wait_for_cell); fix this.
166
5994c183
PE
167 Add GCC-style 'const' attribute to functions that can use it.
168 * character.h (char_resolve_modifier_mask):
169 * keyboard.h (make_ctrl_char):
170 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
171 (init_character_once, next_almost_prime, init_fns, init_image)
172 (flush_pending_output, init_sound):
173 * mem-limits.h (start_of_data):
174 * menu.h (finish_menu_items):
175 Add ATTRIBUTE_CONST.
176 * emacs.c (DEFINE_DUMMY_FUNCTION):
177 Declare the dummy function with ATTRIBUTE_CONST.
178 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
179 Add decls with ATTRIBUTE_CONST.
180
26bccfae
PE
181 Minor improvements to make_formatted_string.
182 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
183 where int is good enough, as vsprintf returns an int.
184 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
185
a8290ec3
DA
1862012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
187
188 Use make_formatted_string to avoid double length calculation.
189 * lisp.h (make_formatted_string): New prototype.
190 * alloc.c (make_formatted_string): New function.
191 * buffer.c (Fgenerate_new_buffer_name): Use it.
192 * dbus.c (syms_of_dbusbind): Likewise.
193 * editfns.c (Fcurrent_time_zone): Likewise.
194 * filelock.c (get_boot_time): Likewise.
195 * frame.c (make_terminal_frame, set_term_frame_name)
196 (x_report_frame_params): Likewise.
197 * image.c (gs_load): Likewise.
198 * minibuf.c (get_minibuffer): Likewise.
199 * msdos.c (dos_set_window_size): Likewise.
200 * process.c (make_process): Likewise.
201 * xdisp.c (ensure_echo_area_buffers): Likewise.
202 * xsettings.c (apply_xft_settings): Likewise.
203
d01ba2f1
GM
2042012-07-09 Glenn Morris <rgm@gnu.org>
205
206 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
207 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
208 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
209 * nsterm.h (ns_etc_directory): Add it.
210 * callproc.c [HAVE_NS]: Include nsterm.h.
211 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
212
f1f924b6
DA
2132012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
214
215 Move marker debugging code under MARKER_DEBUG.
216 * marker.c (MARKER_DEBUG): Move marker debugging code under
217 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
218 for bootstrap with --enable-checking (~3x slowdown reported
219 by Juanma Barranquero <lekktu@gmail.com>).
220 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
221
ab531b66
PE
2222012-07-08 Paul Eggert <eggert@cs.ucla.edu>
223
224 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
225 See <http://bugs.gnu.org/11825#29>.
226
c4b3bc8a
EZ
2272012-07-08 Eli Zaretskii <eliz@gnu.org>
228
229 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
230 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
231 (display_line): Add commentary about displaying truncation glyphs
232 on GUI frames.
233 (produce_special_glyphs): Move here from term.c.
234
235 * term.c (produce_special_glyphs): Move to xdisp.c.
236
237 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
238 section.
c4b3bc8a 239
b676b881
AS
2402012-07-07 Andreas Schwab <schwab@linux-m68k.org>
241
f17c5273
AS
242 * xdisp.c (display_line): Avoid warning about implicit declaration
243 of FRAME_FONT.
244
298819b9
AS
245 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
246
b676b881
AS
247 * lisp.h: Remove empty conditional.
248
6045c4fd
PE
2492012-07-07 Paul Eggert <eggert@cs.ucla.edu>
250
b3350bf9
PE
251 * lread.c (load_path_check): Now static.
252
6045c4fd
PE
253 Fix some minor --with-ns problems found by static checking.
254 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
255 (x_set_font) [!HAVE_X_WINDOWS]:
256 * image.c (xpm_load_image) [HAVE_NS]:
257 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
258 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
259 Remove unused local.
260 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
261 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
262 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
263 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
264 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
265 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
266 Fix pointer signedness problem.
267 * xfaces.c (FRAME_X_FONT_TABLE):
268 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
269
929e7845
GM
2702012-07-07 Glenn Morris <rgm@gnu.org>
271
272 * lread.c (load_path_check): New function, split from init_lread.
273 (init_lread): Reorganize. Motivation:
274 If EMACSLOADPATH is set, check/warn about that rather than the
275 defaults, which we are not going to use. Hence we can remove
276 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
277 Don't warn if site-lisp directories are missing.
278 If not installed, start from a blank load-path, since
279 PATH_LOADSEARCH refers to the eventual installation directories.
280
58dd0aa4
EZ
2812012-07-07 Eli Zaretskii <eliz@gnu.org>
282
283 Support truncation and continuation glyphs on GUI frames, when
284 fringes are disabled. (Bug#11832)
285 * xdisp.c (init_iterator): Get dimensions of truncation and
286 continuation glyphs even if on GUI frames. Adjust
287 it->last_visible_x on GUI frames when the left or right fringes,
288 or both, are absent.
289 (start_display, move_it_in_display_line_to): Handle the case of a
290 GUI frame without a fringe to display continuation or truncation
291 glyphs.
292 (insert_left_trunc_glyphs): Support GUI frames: make sure
293 truncation glyphs overwrite enough glyphs from the current line to
294 have sufficient space in pixels.
295 (display_line): Support truncation and continuation glyphs on GUI
296 frames. If some spare pixels are left on the line after inserting
297 the truncation glyphs, fill that space with a stretch glyph of a
298 suitably computed width.
299
300 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
301 produce_glyphs, to support GUI sessions.
302
31571fd7
PE
3032012-07-07 Paul Eggert <eggert@cs.ucla.edu>
304
5a16b9bc
PE
305 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
306
f3047c75
PE
307 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
308
31571fd7
PE
309 Do not require float-time's arg to fit in time_t (Bug#11825).
310 This works better on hosts where time_t is unsigned, and where
311 float-time is applied to the (negative) difference between two times.
312 * editfns.c (decode_time_components): Last arg is now double *,
313 not int *, and means to store all the result as a double, without
314 worrying about whether the seconds part fits in time_t.
315 All callers changed.
316 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
317 All callers changed.
318 (Ffloat_time): Do not fail merely because the specified time falls
319 outside of time_t range.
320
4516fbef
GM
3212012-07-07 Glenn Morris <rgm@gnu.org>
322
323 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
324 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
325 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
326
07adc2c6
JB
3272012-07-07 Juanma Barranquero <lekktu@gmail.com>
328
329 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
330 Update dependencies.
331
332 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
333
fd573f31
PE
3342012-07-06 Paul Eggert <eggert@cs.ucla.edu>
335
fee5959d
PE
336 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
337 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
338 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
339 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
340 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
341 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
342
fd573f31
PE
343 * xfont.c (compare_font_names): Redo to omit the need for casts.
344
ddadbc0e
AS
3452012-07-06 Andreas Schwab <schwab@linux-m68k.org>
346
fca8d6b6
AS
347 * xfns.c (Fx_change_window_property): Doc fix.
348 * w32fns.c (Fx_change_window_property): Doc fix.
349
ddadbc0e
AS
350 * w32fns.c (Fx_window_property): Accept the same arguments as the
351 X Windows version. Doc fix.
352 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
353
f247498e
JB
3542012-07-06 Juanma Barranquero <lekktu@gmail.com>
355 Eli Zaretskii <eliz@gnu.org>
356
357 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
358 Windows-specific code from nt/config.nt moved here.
359 Obsolete settings removed.
360
216ee680
PE
3612012-07-06 Paul Eggert <eggert@cs.ucla.edu>
362
363 * process.c: Avoid unnecessary calls to gettime.
364 (wait_reading_process_output): Don't get the time of day
365 when gobbling data immediately and not waiting, as there's no need
366 for it in that case. This removes a FIXME.
367
bdd091e4
JD
3682012-07-06 Jan Djärv <jan.h.d@swipnet.se>
369
370 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
371 is defined (Bug#11768).
372
9d44f8ce
DA
3732012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
374
375 Fix marker debugging code.
376 * marker.c (byte_char_debug_check): Do not perform the check
377 if buffer is not multibyte.
090bd7cb
JB
378 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
379 Call byte_char_debug_check with correct arguments.
9d44f8ce 380
90fc4786
DA
3812012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
382
383 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
384 * marker.c (byte_char_debug_check, count_markers):
385 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
386 (byte_debug_flag): Remove.
387 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
388 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
389
7b7ae965
DA
3902012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
391
4e57b342
DA
392 Avoid code repetition in marker-related functions.
393 * marker.c (attach_marker): New function.
394 (Fset_marker, set_marker_restricted, set_marker_both)
395 (set_marker_restricted_both): Use it.
396 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
397 Consistently rename charno to charpos.
398 (marker_position): Add eassert.
399 (marker_byte_position): Convert to eassert.
400
4012012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
402
403 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 404 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 405 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 406
657924ff
DA
4072012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
408
409 Introduce fast path for the widely used marker operation.
410 * alloc.c (build_marker): New function.
411 * lisp.h (build_marker): New prototype.
412 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
413 * composite.c (autocmp_chars): Likewise.
414 * editfns.c (buildmark): Remove.
415 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
416 (save_restriction_save): Use build_marker.
417 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
418 * window.c (save_window_save): Likewise.
419
041a49a6
DA
4202012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
421
422 Do not use Fdelete_overlay in delete_all_overlays
423 to avoid redundant calls to unchain_overlay.
424 * buffer.c (drop_overlay): New function.
425 (delete_all_overlays, Fdelete_overlay): Use it.
426 * minibuf.c (get_minibuffer): Fix comment.
427
7dca65a4
PE
4282012-07-06 Paul Eggert <eggert@cs.ucla.edu>
429
430 Port to OpenBSD 5.1 amd64.
431 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
432 This is needed for OpenBSD, and should be harmless on all BSD systems.
433 Also, include <sys/sysctl.h>, as it should be available on all
434 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
435 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
436 use p_pid member, not kp_proc.pid.
437
8eb876e2
GM
4382012-07-06 Glenn Morris <rgm@gnu.org>
439
440 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
441
38182d90
PE
4422012-07-05 Paul Eggert <eggert@cs.ucla.edu>
443
444 More xmalloc and related cleanup.
445 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
446 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
447 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
448 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
449 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
450 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
451 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
452 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
453 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
454 * xterm.c:
455 Omit needless casts involving void * pointers and allocation.
456 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
457 as the former is more robust if P's type is changed.
458 Prefer xzalloc to xmalloc + memset 0.
459 Simplify malloc-or-realloc to realloc.
460 Don't worry about xmalloc returning a null pointer.
461 Prefer xstrdup to xmalloc + strcpy.
462 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
463 growing it.
464 * keyboard.c (apply_modifiers_uncached): Prefer local array to
465 alloca of a constant.
466
6dd5a677
EZ
4672012-07-05 Eli Zaretskii <eliz@gnu.org>
468
469 * xdisp.c (display_line): Fix horizontal pixel coordinates when
470 hscroll is larger than the line width. Fixes long and futile
471 looping inside extend_face_to_end_of_line (on a TTY) producing
472 glyphs that are not needed and thrown away.
473
6b312f0f
DA
4742012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
475
476 * marker.c (set_marker_restricted_both): Simplify by using
477 clip_to_bounds.
478
f520ef9b
PE
4792012-07-05 Paul Eggert <eggert@cs.ucla.edu>
480
481 * editfns.c (region_limit): Simplify by using clip_to_bounds.
482
383b7c95
JD
4832012-07-05 Jan Djärv <jan.h.d@swipnet.se>
484
485 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
486 not defined (Bug#11768).
487 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
488 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
489 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
490 followed by gtk_box_set_homogeneous (Bug#11768).
491 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
492 (update_theme_scrollbar_width, xg_create_scroll_bar):
493 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
494 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
495 (is_box_type): New function (Bug#11768).
496 (xg_tool_item_stale_p): Call is_box_type.
5293d758 497 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
498 with default display (Bug#11768).
499
d6e7bf45
EZ
5002012-07-05 Eli Zaretskii <eliz@gnu.org>
501
502 * xdisp.c (window_hscroll_limited): New function.
503 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
504 coordinates when window's hscroll is set to insanely large
505 values. (Bug#11857)
506
431391ec
JB
5072012-07-05 Juanma Barranquero <lekktu@gmail.com>
508
509 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
510 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
511
23f86fce
DA
5122012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
513
514 Cleanup xmalloc.
515 * lisp.h (xzalloc): New prototype. Omit needless casts.
516 * alloc.c (xzalloc): New function. Omit needless casts.
517 * charset.c: Omit needless casts. Convert all calls to
518 xmalloc with following memset to xzalloc.
519 * dispnew.c: Likewise.
520 * fringe.c: Likewise.
521 * image.c: Likewise.
522 * sound.c: Likewise.
523 * term.c: Likewise.
524 * w32fns.c: Likewise.
525 * w32font.c: Likewise.
526 * w32term.c: Likewise.
527 * xfaces.c: Likewise.
528 * xfns.c: Likewise.
529 * xterm.c: Likewise.
530 * atimer.c: Omit needless casts.
531 * buffer.c: Likewise.
532 * callproc.c: Likewise.
533 * ccl.c: Likewise.
534 * coding.c: Likewise.
535 * composite.c: Likewise.
536 * doc.c: Likewise.
537 * doprnt.c: Likewise.
538 * editfns.c: Likewise.
539 * emacs.c: Likewise.
540 * eval.c: Likewise.
541 * filelock.c: Likewise.
542 * fns.c: Likewise.
543 * gtkutil.c: Likewise.
544 * keyboard.c: Likewise.
545 * lisp.h: Likewise.
546 * lread.c: Likewise.
547 * minibuf.c: Likewise.
548 * msdos.c: Likewise.
549 * print.c: Likewise.
550 * process.c: Likewise.
551 * region-cache.c: Likewise.
552 * search.c: Likewise.
553 * sysdep.c: Likewise.
554 * termcap.c: Likewise.
555 * terminal.c: Likewise.
556 * tparam.c: Likewise.
557 * w16select.c: Likewise.
558 * w32.c: Likewise.
559 * w32reg.c: Likewise.
560 * w32select.c: Likewise.
561 * w32uniscribe.c: Likewise.
562 * widget.c: Likewise.
563 * xdisp.c: Likewise.
564 * xmenu.c: Likewise.
565 * xrdb.c: Likewise.
566 * xselect.c: Likewise.
567
0497dc44
PE
5682012-07-05 Paul Eggert <eggert@cs.ucla.edu>
569
570 * fileio.c (time_error_value): Check the right error number.
571 Problem reported by Troels Nielsen in
572 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
573
356e7178
PE
5742012-07-04 Paul Eggert <eggert@cs.ucla.edu>
575
4e71fd89
PE
576 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
577 This should be fixed in a better way; see Eli Zaretskii in
578 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
579 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
580
f0941253
PE
581 * fileio.c (time_error_value): Rename from special_mtime.
582 The old name's problems were noted by Eli Zaretskii in
583 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
584
065c9eb4
PE
585 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
586 This variable's comment says Emacs needs at least one GDB-visible
587 symbol of type enum pvec_type, to work around GDB problems.
588 The symbol's value doesn't matter.
589
356e7178
PE
590 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
591 that causes compilation to fail on pre-C99 compilers.
592
95f61aa2
JB
5932012-07-04 Juanma Barranquero <lekktu@gmail.com>
594
595 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
596 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
597
3884d954
DA
5982012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
599
d209e2fb 600 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
601 headers for buffer_defaults and buffer_local_symbols.
602 Reported by Juanma Barranquero <lekktu@gmail.com>.
603
ee28be33
SM
6042012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
605
606 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
607 * lisp.h (enum pvec_type): Use fewer bits.
608 (PSEUDOVECTOR_SIZE_BITS): New constant.
609 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
610 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
611 change in pvec_type.
612 (PSEUDOVECTOR_TYPEP): New macro.
613 (TYPED_PSEUDOVECTORP): Use it.
614 * fns.c (internal_equal): Adapt code to extract pvectype.
615 * emacs.c (gdb_pvec_type): Update type.
616 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
617 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
618 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
619 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
620 (sweep_vectors): Use it. Use local var `total_bytes' instead of
621 abusing vector->header.next.nbytes.
622 (live_vector_p): Use PVEC_TYPE.
623 (mark_object): Adapt code to extract pvectype. Use switch.
624
c7f2cd7f
PE
6252012-07-04 Paul Eggert <eggert@cs.ucla.edu>
626
627 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
628 Tighten new eassert a bit.
629
8ce70ed2
DA
6302012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
631
632 Fix compilation with --enable-gcc-warnings and -O1
633 optimization level.
634 * doprnt.c (doprnt): Change type of tem to int, initialize
635 to avoid compiler warning. Add eassert.
636 * search.c (simple_search): Initialize match_byte to avoid
637 compiler warning. Add eassert.
638
dea7f1e5
PE
6392012-07-04 Paul Eggert <eggert@cs.ucla.edu>
640
24a212eb
PE
641 Avoid weird behavior with large horizontal scrolls.
642 Without this change, for example, large hscroll values would
643 mess up Emacs's display on Fedora 15 x86, presumably due to
644 overflows in int calculations in the display code.
645 Also, if buffers had long lines, Emacs would freeze.
646 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
647 (set_window_hscroll): New function, containing the old guts of
648 Fset_window_hscroll. Return the clipped value.
649 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
650 This avoids the need to check against PTRDIFF_MAX.
651
dea7f1e5
PE
652 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
653
76046526
DA
6542012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
655
656 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
657
39adff0d
PE
6582012-07-04 Paul Eggert <eggert@cs.ucla.edu>
659
63807d47
PE
660 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
661 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
662 since GCC 4.4.6 issues a bogus warning for them.
663
39adff0d
PE
664 Fix bugs in file timestamp newness comparisons.
665 * fileio.c (Ffile_newer_than_file_p):
666 * lread.c (Fload): Use full timestamp resolution of files,
667 not just the 1-second resolution, so that files that are only
668 slightly newer still count as newer.
669 * fileio.c (Ffile_newer_than_file_p): Don't assume file
670 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
671
dbeed9a6
PE
6722012-07-03 Paul Eggert <eggert@cs.ucla.edu>
673
674 * fileio.c: Improve handling of file time marker. (Bug#11852)
675 (special_mtime): New function.
676 (Finsert_file_contents, Fverify_visited_file_modtime):
677 Use it to set special mtime values consistently.
678
636334d6
AS
6792012-07-03 Andreas Schwab <schwab@linux-m68k.org>
680
681 * fileio.c (Finsert_file_contents): Properly handle st_mtime
682 marker for non-existing file. (Bug#11852)
683
e2017fe2
GM
6842012-07-03 Glenn Morris <rgm@gnu.org>
685
686 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
687 and did not make it into globals.h).
688
404dbd37
TT
6892012-07-03 Tom Tromey <tromey@redhat.com>
690
691 * window.c (Fset_window_margins, Fset_window_fringes)
692 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
693 * textprop.c (Fprevious_property_change): No longer static.
694 * syntax.c (Fsyntax_table_p): No longer static.
695 * process.c (Fget_process, Fprocess_datagram_address): No longer
696 static.
697 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
698 * keyboard.c (Fcommand_execute): No longer static.
699 Remove EXFUN.
700 * insdel.c (Fcombine_after_change_execute): No longer static.
701 * image.c (Finit_image_library): No longer static.
702 * fileio.c (Fmake_symbolic_link): No longer static.
703 * eval.c (Ffetch_bytecode): No longer static.
704 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
705 * doc.c (Fdocumentation_property, Fsnarf_documentation):
706 No longer static.
404dbd37
TT
707 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
708 static.
709 * dired.c (Ffile_attributes): No longer static.
710 * composite.c (Fcomposition_get_gstring): No longer static.
711 * callproc.c (Fgetenv_internal): No longer static.
712
713 * ccl.h: Remove EXFUNs.
714 * buffer.h: Remove EXFUNs.
715 * dispextern.h: Remove EXFUNs.
716 * intervals.h: Remove EXFUNs.
717 * fontset.h: Remove EXFUN.
718 * font.h: Remove EXFUNs.
719 * dosfns.c (system_process_attributes): Remove EXFUN.
720 * keymap.h: Remove EXFUNs.
721 * lisp.h: Remove EXFUNs.
722 * w32term.h: Remove EXFUNs.
723 * window.h: Remove EXFUNs.
724 * xsettings.h: Remove EXFUN.
725 * xterm.h: Remove EXFUN.
726
8e4fd1e1
GM
7272012-07-03 Glenn Morris <rgm@gnu.org>
728
729 * lisp.h (Frandom): Make it visible to C.
730 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
731 buffer for invisible buffers. (Bug#1229)
732
ca95b3eb
DA
7332012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
734
735 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
736 values which aren't power of 2.
737 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
738 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
739 accordingly.
740
7555c33f
SM
7412012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
742
743 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
744
745 * alloc.c (mark_object): Revert part of last patch to use `switch'.
746
d12e8f5a
DA
7472012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
748
749 * alloc.c (allocate_vector_block): Remove redundant
750 calls to mallopt if DOUG_LEA_MALLOC is defined.
751 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
752 avoid calls to mallopt if zero_vector is returned.
753
296094c3
DA
7542012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
755
756 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
757 is enabled, avoid dereferencing NULL current_sblock if
758 running undumped.
759
36429c89
DA
7602012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
761
762 Cleanup basic buffer management.
763 * buffer.h (struct buffer): Change layout to use generic vector
764 marking code. Fix some comments. Change type of 'clip_changed'
765 to bitfield. Remove unused #ifndef old.
766 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
767 (GET_OVERLAYS_AT): Fix indentation.
768 (for_each_per_buffer_object_at): New macro.
769 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
770 (Fbuffer_local_variables): Use it.
771 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
772 * alloc.c (allocate_buffer): Adjust to match new layout of
773 struct buffer. Fix comment.
774 (mark_overlay): New function.
775 (mark_buffer): Use it. Use mark_vectorlike to mark normal
776 Lisp area of struct buffer.
777 (mark_object): Use it. Adjust marking of misc objects
778 and related comments.
779
3b3e4cac
PE
7802012-07-02 Paul Eggert <eggert@cs.ucla.edu>
781
782 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
783 wrapper that is not needed because the wrapped code is a no-op (zero
784 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
785 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
786
cf5c0175
DA
7872012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
788
789 * alloc.c (mark_buffer): Simplify. Remove prototype.
790 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 791 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
792 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
793 redundant calls to mark_vectorlike for bool vectors.
794
ca26824c
GM
7952012-06-30 Glenn Morris <rgm@gnu.org>
796
2e4c5312
GM
797 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
798
ca26824c
GM
799 * epaths.in (PATH_SITELOADSEARCH): New.
800 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
801 This is rather than relying on --enable-locallisppath elements
802 having "site-lisp" in their names. (Bug#10208#25, 11658)
803
0d23c240
EZ
8042012-06-30 Eli Zaretskii <eliz@gnu.org>
805
c9240d7a
EZ
806 * w32proc.c (sys_select): Accept and ignore one more argument.
807
808 * w32.c (emacs_gnutls_pull): Call select with one more argument.
809
0d23c240 810 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 811 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
812
813 * sysdep.c: Don't include dos.h and dosfns.h.
814
815 * process.c (sys_select):
816 * msdos.c (sys_select): Accept one more argument and ignore it.
817
818 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
819 adapt data types and code to that.
820
821 * dosfns.c:
822 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
823 which clashes with the gnulib function of the same name.
824
af5a5a98
AS
8252012-06-30 Andreas Schwab <schwab@linux-m68k.org>
826
c5e4379c
AS
827 * font.c (font_style_to_value, font_style_symbolic)
828 (font_prop_validate_style): Add type checks for values in
829 font_style_table.
830
af5a5a98
AS
831 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
832 argument.
833 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
834 uses.
835
8d38f461
EZ
8362012-06-29 Eli Zaretskii <eliz@gnu.org>
837
2e5a6631
EZ
838 * xdisp.c (try_window_id): Undo last change.
839
8d38f461
EZ
840 * w32.c (getwd): Adjust commentary about startup_dir.
841 (init_environment): Always call sys_access, even in non-MSVC
842 builds. Don't chdir to the directory of the Emacs executable.
843 This undoes code from 1997 which was justified by the need to
844 "avoid conflicts when removing and renaming directories". But its
845 downside was that every relative file name was being interpreted
846 relative to the directory of the Emacs executable, which can never
847 be TRT. In particular, it broke sys_access when called with
848 relative file names.
849 (sys_access): Map GetLastError to errno.
850
2af3565e
DA
8512012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
852
853 * window.h (struct window): Change type of 'fringes_outside_margins'
854 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 855 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
856 Adjust comment.
857 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
858 to ptrdiff_t.
859
c8d3a25c 8602012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 861
c8d3a25c
GM
862 * gnutls.c (emacs_gnutls_handshake):
863 Add QUIT to make the loop interruptible.
57570cd3 864
c8d3a25c 8652012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 866
c8d3a25c
GM
867 * charset.c (init_charset): Make lack of etc/charsets fatal.
868
3e984ee8
DA
8692012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
870
871 * editfns.c (region_limit): Fix type mismatch.
872
ef884f23
DA
8732012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
874
875 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
876 undefined. Convert from xassert to eassert.
877 * nsmenu.m: Convert from xassert to eassert.
878 * nsterm.m: Likewise.
879
7d7e0027
SM
8802012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
881
882 * editfns.c (region_limit): Clip to narrowing (bug#11770).
883
aa754e6a
PE
8842012-06-28 Paul Eggert <eggert@cs.ucla.edu>
885
886 Avoid integer overflow on scroll-left and scroll-right.
887 * window.c (HSCROLL_MAX): New macro.
888 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
889 overflow when requested scroll falls outside ptrdiff_t range.
890
80b00b08
DA
8912012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
892
893 * window.h (struct window): Change type of 'hscroll',
894 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
895 'last_modified' and 'last_overlay_modified' to EMACS_INT.
896 Adjust users accordingly.
897 * xdisp.c (try_cursor_movement): Replace type check with eassert.
898 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
899 from EMACS_INT to ptrdiff_t.
900 (make_window): Omit redundant initialization.
901
62b2bcf6
JB
9022012-06-28 Juanma Barranquero <lekktu@gmail.com>
903
904 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
905
45942c7d
DA
9062012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
907
908 * window.h (struct window): Change type of 'use_time' and
909 'sequence_number' from Lisp_Object to int.
910 * frame.c (make_frame): Adjust users accordingly.
911 * print.c (print_object): Likewise.
912 * window.c (select_window, Fwindow_use_time, make_parent_window)
913 (make_window): Likewise.
914
e509cfa6
DA
9152012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
916
917 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
918 enabled with --enable-checking=[all,glyphs] configure option.
919 Fix GLYPH_DEBUG usage assuming that it may be undefined,
920 adjust comments accordingly.
921 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
922 undefined, adjust comments accordingly.
923 * image.c: Likewise.
924 * scroll.c: Likewise.
925 * w32fns.c: Likewise.
926 * w32term.c: Likewise.
927 * xdisp.c: Likewise.
928 * xfaces.c: Likewise.
929 * xfns.c: Likewise.
930 * xterm.c: Likewise.
931
a54e2c05
DA
9322012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
933
934 Generalize run-time debugging checks.
935 * dispextern.h (XASSERTS): Remove.
936 * fontset.c (xassert): Remove.
937 Convert from xassert to eassert.
938 * alloc.c: Convert from xassert to eassert.
939 * bidi.c: Likewise.
940 * dispnew.c: Likewise.
941 * fns.c: Likewise.
942 * fringe.c: Likewise.
943 * ftfont.c: Likewise.
944 * gtkutil.c: Likewise.
945 * image.c: Likewise.
946 * keyboard.c: Likewise.
947 * menu.c: Likewise.
948 * process.c: Likewise.
949 * scroll.c: Likewise.
950 * sound.c: Likewise.
951 * term.c: Likewise.
952 * w32console.c: Likewise.
953 * w32fns.c: Likewise.
954 * w32term.c: Likewise.
955 * window.c: Likewise.
956 * xdisp.c: Likewise.
957 * xfaces.c: Likewise.
958 * xfns.c: Likewise.
959 * xselect.c: Likewise.
960 * xterm.c: Likewise.
961
1ec4b7b2
SM
9622012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
963
964 * fns.c (maybe_resize_hash_table): Output message when growing the
965 purify-hashtable.
966
2014308a
DA
9672012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
968
969 * alloc.c (allocate_string_data): Remove dead code.
970 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
971 avoid GCC warning about unused macro.
972
246155eb
DA
9732012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
974
975 * alloc.c (allocate_string): Omit intervals initialization.
976 * alloc.c (make_uninit_multibyte_string): Initialize intervals
977 as in make_pure_string and make_pure_c_string.
978
43184b7b
DA
9792012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
980
d209e2fb 981 * alloc.c (allocate_string): Fix last change.
43184b7b 982
3fe6dd74
DA
9832012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
984
d209e2fb 985 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
986 to memset, add explicit initialization where appropriate.
987
1ba6038a
GM
9882012-06-27 Glenn Morris <rgm@gnu.org>
989
990 * lisp.mk (lisp): Remove paths.elc.
991
c89926a5
CY
9922012-06-27 Chong Yidong <cyd@gnu.org>
993
994 * doc.c (Fsubstitute_command_keys): Fix punctuation.
995
ed6b3510
JW
9962012-06-26 John Wiegley <johnw@newartisans.com>
997
1ec4b7b2 998 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
999 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1000
ed6b3510
JW
1001 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1002 when building with Clang.
1003
8edd4a2b
SM
10042012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1005
1006 * eval.c (Fapply): Allow calling it with a single argument.
1007
f6f62d1b
EZ
10082012-06-26 Eli Zaretskii <eliz@gnu.org>
1009
1010 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1011 _stricmp and _strnicmp.
1012 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1013
62efea5e
DA
10142012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1015
1016 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1017 allocated window.
1018 (allocate_process): Likewise for new process.
8edd4a2b 1019 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1020 (allocate_frame): Likewise.
1021 * frame.c (make_frame): Omit redundant initialization.
1022 * window.c (make_parent_window): Use memset.
1023 (make_window): Omit redundant initialization.
1024 * process.c (make_process): Omit redundant initialization.
1025 * terminal.c (create_terminal): Likewise.
1026
42997f4d
DA
10272012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1028
1029 * term.c (delete_tty): Remove redundant call to memset.
1030
1130ecfc
DA
10312012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1032
1033 * alloc.c: Remove build_string.
1034 * lisp.h: Define build_string as static inline. This provides
1035 a better opportunity to optimize away calls to strlen when the
1036 function is called with compile-time constant argument.
1037 * image.c (imagemagick_error): Convert to build_string.
1038 * w32proc.c (sys_spawnve): Likewise.
1039 * xterm.c (x_term_init): Likewise.
1040
cf38a720
PE
10412012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1042
99027bdd
PE
1043 Use sprintf return value instead of invoking strlen on result.
1044 In the old days this wasn't portable, since some sprintf
1045 implementations returned char *. But they died out years ago and
1046 Emacs already assumes sprintf returns int.
1047 Similarly for float_to_string.
1048 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1049 * ccl.c (ccl_driver):
1050 * character.c (string_escape_byte8):
1051 * data.c (Fnumber_to_string):
1052 * doprnt.c (doprnt):
1053 * print.c (print_object):
1054 * xdisp.c (message_dolog):
1055 * xfns.c (syms_of_xfns):
1056 Use sprintf or float_to_string result to avoid need to call strlen.
1057 * data.c (Fnumber_to_string):
1058 Use make_unibyte_string, since the string must be ASCII.
1059 * lisp.h, print.c (float_to_string): Now returns int length.
1060 * term.c (produce_glyphless_glyph):
1061 Use sprintf result rather than recomputing it.
1062
cf38a720
PE
1063 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1064 * Makefile.in (ALL_CFLAGS):
1065 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1066 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1067
3511c784
DA
10682012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1069
0a08eb21 1070 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1071 strcasecmp if available.
1072 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1073
fb7da12e
AS
10742012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1075
1076 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1077 Avoid comma operator.
1078 * menu.c (push_submenu_start, push_submenu_end)
1079 (push_left_right_boundary, push_menu_pane): Likewise.
1080 * msdos.c (dos_rawgetc): Likewise.
1081
afa2ffd8
DA
10822012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1083
1084 * xfns.c (xic_create_fontsetname): Remove redundant calls
1085 to memset.
1086
b3b4476b
PE
10872012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1088
4495ff38
PE
1089 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1090 sprintf already null-terminates its output.
1091
b3b4476b
PE
1092 * xfns.c (x_window): Remove redundant cast.
1093
b00876c9
DA
10942012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1095
1096 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1097 `const char *' to `char *' to avoid compiler warning.
1098
d188e26b
PE
10992012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1100
885d1d74
PE
1101 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1102 instead of truncating it to 63 (admittedly a generous limit).
1103
d188e26b
PE
1104 * process.c: Fix spelling and caps in comments.
1105
e2f560b1
DN
11062012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1107
e86db54b 1108 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1109 * sysdep.c (setpgrp): Remove definition, not used in this file.
1110
7583a3a1
JB
11112012-06-24 Juanma Barranquero <lekktu@gmail.com>
1112
1113 * makefile.w32-in: Update dependencies.
1114
696056c2
EZ
11152012-06-24 Eli Zaretskii <eliz@gnu.org>
1116
1117 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1118 (SYSTIME_H): Add nt/inc/sys/time.h.
1119
1120 * systime.h [WINDOWSNT]: Include sys/time.h.
1121
1122 * s/ms-w32.h (struct timespec): Definition moved from
1123 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1124
845ca893
PE
11252012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1126
1127 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1128 * buffer.h (buffer_slot_type_mismatch):
1129 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1130 * eval.c (unwind_to_catch):
1131 * image.c (my_png_error, my_error_exit):
1132 * keyboard.c (quit_throw_to_read_char, user_error)
1133 (Fexit_recursive_edit, Fabort_recursive_edit):
1134 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1135 (wrong_type_argument, buffer_overflow, __executable_start)
1136 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1137 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1138 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1139 (fatal):
1140 (child_setup) [!DOS_NT]:
1141 * lread.c (end_of_file_error, invalid_syntax):
1142 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1143 * puresize.h (pure_write_error):
1144 * search.c (matcher_overflow):
1145 * sound.c (sound_perror, alsa_sound_perror):
1146 * sysdep.c, syssignal.h (croak):
1147 * term.c (maybe_fatal, vfatal):
1148 * textprop.c (text_read_only):
1149 * undo.c (user_error):
1150 * unexmacosx.c (unexec_error):
1151 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1152 Use _Noreturn rather than NO_RETURN.
1153 No need for separate decl merely because of _Noreturn.
1154 * sound.c (sound_warning, parse_sound):
1155 Remove unnecessary forward decls.
1156
f1dd8073
PE
11572012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1158
1159 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1160 * lisp.h (WAIT_READING_MAX): New macro.
1161 * dispnew.c (Fsleep_for, sit_for):
1162 * keyboard.c (kbd_buffer_get_event):
1163 * process.c (Faccept_process_output):
1164 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1165 This improves on the previous patch, which introduced a bug
1166 when time_t is unsigned and as wide as intmax_t.
1167 See <http://bugs.gnu.org/9000#51>.
1168
b82c1755
EZ
11692012-06-23 Eli Zaretskii <eliz@gnu.org>
1170
1171 * dispnew.c (sit_for, Fsleep_for):
1172 * keyboard.c (kbd_buffer_get_event):
1173 * process.c (Faccept_process_output): Avoid compiler warnings when
1174 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1175
ca300656
JB
11762012-06-23 Juanma Barranquero <lekktu@gmail.com>
1177
049ec95b
JB
1178 * makefile.w32-in: Update dependencies.
1179
ca300656
JB
1180 * w32.c (ltime): Add return type and declare static.
1181 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1182
db7b8d06
PE
11832012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1184
1185 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1186 Privately reported by Herbert J. Skuhra.
1187 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1188 All uses changed.
1189 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1190 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1191
0bd8297f
EZ
11922012-06-23 Eli Zaretskii <eliz@gnu.org>
1193
96512555
EZ
1194 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1195 last argument of make_unibyte_string.
1196
0bd8297f
EZ
1197 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1198 language ID in the event parameters.
1199
1200 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1201 event.code, not the obscure "character set ID".
1202
63def6b6
CY
12032012-06-23 Chong Yidong <cyd@gnu.org>
1204
1205 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1206
e8a02204
EZ
12072012-06-23 Eli Zaretskii <eliz@gnu.org>
1208
388cdec0
EZ
1209 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1210 * w32.c (fdutimens): New function.
1211
1212 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1213
1214 * s/ms-w32.h (pselect): Redirect to sys_select.
1215
1216 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1217
e8a02204
EZ
1218 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1219 in the logic of incrementing and decrementing the value of
1220 use_relocatable_buffers.
1221
d054f3fb
PE
12222012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1223
1224 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1225 Privately reported by Herbert J. Skuhra.
1226 [__FreeBSD__]: Remove "*/" typo after "#include".
1227 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1228 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1229 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1230 Don't assume EMACS_TIME and struct timeval are the same type.
1231
d35af63c
PE
12322012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1233
1234 Support higher-resolution time stamps (Bug#9000).
1235 The time stamps are only nanosecond-resolution at the C level,
1236 since that's the best that any real-world system supports now.
1237 But they are picosecond-resolution at the Lisp level, as that's
1238 easy, and leaves room for future OS improvements.
1239
1240 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1241 (LIBES): Use it.
1242
1243 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1244 Don't get current time unless it's needed.
1245
1246 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1247 now provides it if it's absent.
1248 (start_atimer): Port to higher-res time stamps.
1249 Check for time stamp overflow. Don't get current time more
1250 often than is needed.
1251
1252 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1253 Include systime.h, not time.h.
1254 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1255
1256 * dired.c: Include stat-time.h.
1257 (Ffile-attributes): File times now have higher resolution.
1258
1259 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1260 (struct image): Timestamp now has higher resolution.
1261
1262 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1263 has at least microseconds now. All uses removed.
1264 (update_frame, update_single_window, update_window, update_frame_1)
1265 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1266
1267 * editfns.c (time_overflow): Now extern.
1268 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1269 (float-time, Fformat_time_string, Fcurrent_time_string)
1270 (Fcurrent_time_zone): Accept and generate higher-resolution
1271 time stamps.
1272 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1273 (decode_time_components, lisp_seconds_argument): New functions.
1274 (make_time): Now static.
1275 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1276 Report an error if the time is invalid, rather than having the caller
1277 do that.
1278
1279 * fileio.c: Include <stat-time.h>
1280 (Fcopy_file): Copy higher-resolution time stamps.
1281 Prefer to set the time stamp via a file descriptor if that works.
1282 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1283 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1284 (Fvisited_file_modtime, Fset_visited_file_modtime):
1285 Support higher-resolution time stamps.
1286
1287 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1288
1289 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1290
1291 * image.c (prepare_image_for_display, clear_image_cache)
1292 (lookup_image): Port to higer-resolution time stamps.
1293
1294 * keyboard.c (start_polling, bind_polling_period):
1295 Check for time stamp overflow.
1296 (read_char, kbd_buffer_get_event, timer_start_idle)
1297 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1298 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1299 Port to higher-resolution time stamps. Do not assume time_t is signed.
1300 (decode_timer): New function. Timers are now vectors of length 9,
1301 not 8, to accommodate the picosecond component.
1302 (timer_check_2): Use it.
1303
1304 * nsterm.m (select_timeout, timeval_subtract): Remove.
1305 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1306 as they're a bit more accurate and handle overflow better.
1307 (ns_select): Change prototype to be compatible with pselect.
1308 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1309 * nsterm.h (ns_select): Adjust prototype.
1310
1311 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1312 us-resolution time stamps.
1313 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1314
1315 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1316
1317 * lisp.h (time_overflow): New decl.
1318 (wait_reading_process_output): First arg is now intmax_t, not int,
1319 to accommodate larger waits.
1320
1321 * process.h (struct Lisp_Process.read_output_delay):
1322 Now counts nanoseconds, not microseconds.
1323 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1324 EMACS_HAS_USECS.
1325 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1326 (wait_reading_process_output):
1327 Port to ns-resolution time stamps.
1328 (Faccept_process_output, wait_reading_process_output):
1329 Check for time stamp overflow. Do not assume time_t is signed.
1330 (select_wrapper): Remove; we now use pselect.
1331 (Fprocess_attributes): Now generates ns-resolution time stamps.
1332
1333 * sysdep.c: Include utimens.h. Don't include utime.h
1334 or worry about struct utimbuf; gnulib does that for us now.
1335 (gettimeofday): Remove; gnulib provides a substitute.
1336 (make_timeval): New function.
1337 (set_file_times): Now sets ns-resolution time stamps.
1338 New arg FD; all uses changed.
1339 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1340 (system_process_attributes):
1341 Now returns ns-resolution time stamp. All uses changed.
1342 Check for time stamp overflow.
1343
1344 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1345 provides a substitute now.
1346
1347 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1348 since it guarantees struct timespec.
1349 (EMACS_TIME): Now struct timespec, so that we can support
1350 ns-resolution time stamps.
1351 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1352 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1353 (EMACS_USECS): Remove.
1354 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1355 so multiply the arg by 1000 before storing it.
1356 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1357 New macros.
1358 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1359 Port to ns-resolution time stamps.
1360 (EMACS_TIME_NEG_P): Remove; replaced by....
1361 (EMACS_TIME_SIGN): New macro.
1362 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1363 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1364 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1365 (make_timeval, make_lisp_time, decode_time_components): New decls.
1366 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1367 that it mishandled time_t overflow. You can't compare by subtracting!
1368 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1369 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1370
1371 * term.c: Include <sys/time.h>.
1372 (timeval_to_Time): New function, for proper overflow wraparound.
1373 (term_mouse_position, term_mouse_click): Use it.
1374
1375 * undo.c (record_first_change): Support higher-resolution time stamps
1376 in the undo buffer.
1377 (Fprimitive_undo): Use them when restoring time stamps.
1378
1379 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1380 (w32_get_internal_run_time):
1381 Port to higher-resolution Emacs time stamps.
1382 (ltime): Now accepts single 64-bit integer, as that's more convenient
1383 for callers.
1384
1385 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1386
1387 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1388 for compatibility with pselect. Support ns-resolution time stamps.
1389
1390 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1391
1392 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1393 Check for time stamp overflow, and support ns-resolution time stamps.
1394
1395 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1396 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1397 (timeval_subtract): Remove; no longer needed.
1398 (XTflash, XTring_bell, x_wait_for_event):
1399 Port to ns-resolution time stamps. Don't assume time_t is signed.
1400
b6a92dfe
CY
14012012-06-22 Chong Yidong <cyd@gnu.org>
1402
1403 * xdisp.c (x_consider_frame_title): Revert last change.
1404
d251c37c
EZ
14052012-06-22 Eli Zaretskii <eliz@gnu.org>
1406
1407 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1408 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1409 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1410 staticidx goes up to 1597 out of 1600 = 0x640.)
1411
f10deafb
PE
14122012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1413
1414 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1415 Otherwise, the umask might be mistakenly 0 while handling input signals.
1416
ec6de1e2
SM
14172012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1418
1419 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1420
28be1ada
DA
14212012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1422
1423 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1424 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1425 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1426 access to `contents' member of Lisp_Vector objects with AREF and ASET
1427 where appropriate.
1428
c6bf3022
CY
14292012-06-19 Chong Yidong <cyd@gnu.org>
1430
1431 * frame.c (delete_frame): When selecting a frame on a different
1432 text terminal, do not alter the terminal's top-frame.
1433
1434 * xdisp.c (format_mode_line_unwind_data): Record the target
1435 frame's selected window and its terminal's top-frame.
1436 (unwind_format_mode_line): Restore them.
1437 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1438 Callers changed.
1439 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1440 since tty frames can be explicitly named.
1441 (prepare_menu_bars): Likewise.
1442
1443 * term.c (Ftty_top_frame): New function.
1444
defd4196
PE
14452012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1446
1447 Port byte-code-meter to modern targets.
1448 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1449 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1450 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1451 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1452 (METER_1, METER_2): Simplify.
1453
1053a871
SM
14542012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1455
1456 * data.c (Fdefalias): Return `symbol' (bug#11686).
1457
b7e8d081
MR
14582012-06-18 Martin Rudalics <rudalics@gmx.at>
1459
1460 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1461 gets killed during executing of this function (Bug#11665).
1462 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1463 (Vkill_buffer_query_functions): In doc-string say that functions
1464 run by this hook should not change the current buffer.
1465
7ea2b339
PE
14662012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1467
1468 Fix recently-introduced process.c problems found by static checking.
1469 * process.c (write_queue_push, write_queue_pop, send_process):
1470 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1471 (write_queue_pop): Fix pointer signedness problem.
1472 (send_process): Remove unused local.
1473
96a313a1
CY
14742012-06-17 Chong Yidong <cyd@gnu.org>
1475
1476 * xdisp.c (redisplay_internal): No need to redisplay terminal
1477 frames that are not on top.
1478
20ca2e94
TN
14792012-06-17 Troels Nielsen <bn.troels@gmail.com>
1480
1481 * process.c (make_process): Initialize write_queue.
1482 (write_queue_push, write_queue_pop): New functions.
1483 (send_process): Use them to maintain correct ordering of process
1484 writes (Bug#10815).
1485
9a900ca9
PE
14862012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1487
310fbfa8
PE
1488 * lisp.h (eassert): Assume C89 or later.
1489 This removes the need for CHECK.
1490 (CHECK): Remove. Its comments about always evaluating its
1491 argument were confusing, as 'eassert' typically does not evaluate
1492 its argument.
1493
27bb1ca4
PE
1494 * coding.c (produce_chars): Use ptrdiff_t, not int.
1495
9a900ca9
PE
1496 * xterm.c (x_draw_underwave): Check for integer overflow.
1497 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1498
41b7f8bc 14992012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1500
1501 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1502 referenced (Bug#11583).
1503
9b0e3eba
AA
15042012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1505
1506 Implement wave-style variant of underlining.
1507 * dispextern.h (face_underline_type): New enum.
1508 (face): Add field for underline type.
1509 * nsterm.m (ns_draw_underwave): New function.
1510 (ns_draw_text_decoration): Use it.
1511 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1512 New functions.
1513 (x_draw_glyph_string): Use them.
1514 * xfaces.c (Qline, Qwave): New Lisp objects.
1515 (check_lface_attrs, merge_face_ref)
1053a871
SM
1516 (Finternal_set_lisp_face_attribute, realize_x_face):
1517 Handle wave-style underline face attributes.
9b0e3eba
AA
1518 * xterm.c (x_draw_underwave): New function.
1519 (x_draw_glyph_string): Use it.
1520
0fb52f11
JB
15212012-06-16 Juanma Barranquero <lekktu@gmail.com>
1522
1523 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1524 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1525 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1526 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1527 ($(BLD)/w32select.$(O)): Update dependencies.
1528
e5560ff7
AS
15292012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1530
1531 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1532 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1533 * character.c (_fetch_multibyte_char_p): Remove.
1534 * alloc.c: Include "character.h" before "buffer.h".
1535 * bidi.c: Likewise.
1536 * buffer.c: Likewise.
1537 * bytecode.c: Likewise.
1538 * callint.c: Likewise.
1539 * callproc.c: Likewise.
1540 * casefiddle.c: Likewise.
1541 * casetab.c: Likewise.
1542 * category.c: Likewise.
1543 * cmds.c: Likewise.
1544 * coding.c: Likewise.
1545 * composite.c: Likewise.
1546 * dired.c: Likewise.
1547 * dispnew.c: Likewise.
1548 * doc.c: Likewise.
1549 * dosfns.c: Likewise.
1550 * editfns.c: Likewise.
1551 * emacs.c: Likewise.
1552 * fileio.c: Likewise.
1553 * filelock.c: Likewise.
1554 * font.c: Likewise.
1555 * fontset.c: Likewise.
1556 * fringe.c: Likewise.
1557 * indent.c: Likewise.
1558 * insdel.c: Likewise.
1559 * intervals.c: Likewise.
1560 * keyboard.c: Likewise.
1561 * keymap.c: Likewise.
1562 * lread.c: Likewise.
1563 * macros.c: Likewise.
1564 * marker.c: Likewise.
1565 * minibuf.c: Likewise.
1566 * nsfns.m: Likewise.
1567 * nsmenu.m: Likewise.
1568 * print.c: Likewise.
1569 * process.c: Likewise.
1570 * regex.c: Likewise.
1571 * region-cache.c: Likewise.
1572 * search.c: Likewise.
1573 * syntax.c: Likewise.
1574 * term.c: Likewise.
1575 * textprop.c: Likewise.
1576 * undo.c: Likewise.
1577 * unexsol.c: Likewise.
1578 * w16select.c: Likewise.
1579 * w32fns.c: Likewise.
1580 * w32menu.c: Likewise.
1581 * window.c: Likewise.
1582 * xdisp.c: Likewise.
1583 * xfns.c: Likewise.
1584 * xmenu.c: Likewise.
1585 * xml.c: Likewise.
1586 * xselect.c: Likewise.
1587
2f07e6af
EZ
15882012-06-16 Eli Zaretskii <eliz@gnu.org>
1589
1053a871
SM
1590 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1591 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1592 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1593 row.
1594 (handle_face_prop): Use chunk-relative overlay string index when
1595 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1596 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1597 the rightmost. (Bug#11720)
2f07e6af 1598
29b83cec
AS
15992012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1600
1601 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1602 (CATEGORY_MEMBER): Enforce 1/0 value.
1603 * category.c (_temp_category_set): Remove.
1604
4c5501e9
EZ
16052012-06-16 Eli Zaretskii <eliz@gnu.org>
1606
1607 * window.c (Fdelete_other_windows_internal)
1608 (Fdelete_window_internal): Don't access frame's mouse highlight
1609 info of the initial frame. (Bug#11677)
1610
2b570124
PE
16112012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1612
e93864f9
PE
1613 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1614 Assume USE_2_TAGS_FOR_INTS.
1615 (xreload): Adjust $tagmask width to match recent lisp.h change.
1616
2b570124
PE
1617 Simplify lisp.h in minor ways that should not affect code.
1618 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1619 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1620 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1621 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1622 (INTTYPEBITS): New macro, for clarity.
1623 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1624 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1625 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1626 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1627 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1628
81755f69
JB
16292012-06-13 Juanma Barranquero <lekktu@gmail.com>
1630
1631 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1632
16192a57
GM
16332012-06-13 Glenn Morris <rgm@gnu.org>
1634
1635 * s/bsd-common.h (BSD4_3):
1636 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1637
646b5f55
AS
16382012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1639
1640 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1641 instead of union.
1642 (XLI, XIL): Define.
1053a871
SM
1643 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1644 Use them.
1645 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1646 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1647 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1648 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1649 * frame.c (delete_frame): Remove outdated comment.
1650 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1651 USE_LISP_UNION_TYPE.
1652 (Fw32_unregister_hot_key): Likewise.
1653 (Fw32_toggle_lock_key): Likewise.
1654 * w32menu.c (add_menu_item): Likewise.
1655 (w32_menu_display_help): Use XIL instead of checking
1656 USE_LISP_UNION_TYPE.
1657 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1658 (init_heap): Likewise.
1659 * w32term.c (w32_read_socket): Update comment.
1660
1d3823c9
GM
16612012-06-13 Glenn Morris <rgm@gnu.org>
1662
c62ff706
GM
1663 * s/usg5-4-common.h, src/s/unixware.h:
1664 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1665
1d3823c9
GM
1666 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1667
bfe3e0a2
PE
16682012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1669
1670 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1671 * alloc.c (make_number) [!defined make_number]:
1672 Remove, as lisp.h always defines this now.
1673 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1674 (roundup_size): Verify that it is a power of 2.
1675 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1676 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1677 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1678 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1679 USE_LSB_TAG now is always defined to be either 0 or 1.
1680 All uses changed.
1681 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1682 code works fine either way, and efficiency is not a concern here,
1683 as the union type is for debugging, not for production.
1684 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1685 Use an inline function on all platforms when using the union type,
1686 since this is simpler and 'static inline' can be used portably
1687 within Emacs now.
1688 (LISP_INITIALLY_ZERO): New macro.
1689 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1690 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1691
45fa9c0f
GM
16922012-06-12 Glenn Morris <rgm@gnu.org>
1693
b4492cba
GM
1694 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1695
1696 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1697
45fa9c0f
GM
1698 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1699 Move BROKEN_SIGIO to configure.
1700
1701 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1702 Move NO_TERMIO to configure.
1703
0e25d334
CY
17042012-06-12 Chong Yidong <cyd@gnu.org>
1705
1706 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1707 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1708 MagickExportImagePixels is undefined.
1709
43682bb6
PE
17102012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1711
1712 * image.c (imagemagick_load_image): Remove unused label.
1713
a9be7d2b
GM
17142012-06-11 Glenn Morris <rgm@gnu.org>
1715
1716 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1717 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1718 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1719 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1720
3017f87f
SM
17212012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1722
1723 * alloc.c (make_byte_code): New function.
1724 (Fmake_byte_code): Use it. Don't purify here.
1725 * lread.c (read1): Use it as well to avoid extra allocation.
1726
1b9b4cf4
CY
17272012-06-11 Chong Yidong <cyd@gnu.org>
1728
1729 * image.c (imagemagick_load_image): Implement transparency.
1730
95988fcf
AS
17312012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1732
1733 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1734 account for preceding backslashes. (Bug#11663)
1735
cd4eb164
CY
17362012-06-09 Chong Yidong <cyd@gnu.org>
1737
1738 * term.c: Support italics in capable terminals (Bug#9652).
1739 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1740 (turn_on_face): Output using TS_enter_italic_mode if available.
1741 Don't handle unused blinking and alt-charset cases.
1742 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1743 and tty_alt_charset_p cases.
1744 (tty_capable_p, init_tty): Support italics.
1745
1746 * termchar.h (struct tty_display_info): Add field for italics.
1747 Remove unused blink field.
1748
1749 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1750 Handle slant.
1751
1752 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1753 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1754 tty_alt_charset_p. Add tty_italic_p.
1755
ff88beb8
MA
17562012-06-09 Michael Albinus <michael.albinus@gmx.de>
1757
1758 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1759 dbus_type_is_basic if available.
1760 (xd_extract_signed, xd_extract_unsigned): Rename from
1761 extract_signed and extract_unsigned, respectively. Adapt callers.
1762
44286096
CY
17632012-06-09 Chong Yidong <cyd@gnu.org>
1764
1682701f
CY
1765 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1766
44286096
CY
1767 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1768 case (Bug#9752).
1769
d86feb17
PE
17702012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1771
1772 * xdisp.c (vmessage): Treat frame message as multibyte.
1773 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1774 would generate the diagnostic "Making \302\247 buffer-local while
1775 let-bound!".
1776
d5c20fe8
EZ
17772012-06-08 Eli Zaretskii <eliz@gnu.org>
1778
1779 * dispnew.c (showing_window_margins_p): Undo last change, which
1780 was done due to an inadvertent commit.
1781 (adjust_frame_glyphs_for_frame_redisplay): Do call
1782 showing_window_margins_p.
1783
513749ee
SM
17842012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1785
1786 * eval.c (Fmake_var_non_special): New primitive.
1787 (syms_of_eval): Defsubr it.
1788 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1789
d4a8f5c1
JB
17902012-06-08 Juanma Barranquero <lekktu@gmail.com>
1791
1792 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1793 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1794
8bbbc977
EZ
17952012-06-08 Eli Zaretskii <eliz@gnu.org>
1796
1797 * alloc.c (allocate_vectorlike): Fix last change.
1798
f3372c87
DA
17992012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1800
1801 Block-based vector allocation of small vectors.
1802 * lisp.h (struct vectorlike_header): New field `nbytes',
1803 adjust comment accordingly.
1804 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1805 to denote vector blocks. Adjust users (live_vector_p,
1806 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1807 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1808 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1809 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1810 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1811 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1812 (roundup_size): New constant.
1813 (struct vector_block): New data type.
1814 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1815 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1816 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1817 (sweep_vectors): New functions.
1818 (allocate_vectorlike): Return `zero_vector' as the only vector of
1819 0 items. Allocate new vector from block if vector size is less than
1820 or equal to VBLOCK_BYTES_MAX.
1821 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1822 (init_alloc_once): Add call to init_vectors.
1823
4f18a4ed
SM
18242012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1825
1826 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1827
86f158bc
PE
18282012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1829
1830 * doprnt.c (doprnt): Truncate multibyte char correctly.
1831 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1832 would mishandle a string argument "Xc" if X was a multibyte
1833 character of length 2: it would truncate after X's first byte
1834 rather than including all of X.
1835
c5cfcbe0
CY
18362012-06-06 Chong Yidong <cyd@gnu.org>
1837
1838 * buffer.c (word_wrap): Doc fix.
1839
c05cf390
PE
18402012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1841
1842 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1843
0c3461de
GM
18442012-06-03 Glenn Morris <rgm@gnu.org>
1845
1846 * xdisp.c (tool-bar-style): Doc fix.
1847
c71232db
UM
18482012-06-03 Ulrich Müller <ulm@gentoo.org>
1849
1850 * Makefile.in (PAXCTL): Define.
1851 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1852 binary via PaX flags if the paxctl utility is available.
1853 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1854 Restore PaX flags to their default. (Bug#11398)
1855
383f7350
CY
18562012-06-03 Chong Yidong <cyd@gnu.org>
1857
1858 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1859 buffer (Bug#11226).
1860
5f2c76c6
CY
18612012-06-03 Chong Yidong <cyd@gnu.org>
1862
1863 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1864 (note_mode_line_or_margin_highlight): If there is no help echo,
1865 use mode-line-default-help-echo. Handle the case where the mouse
1866 position is past the end of the mode line string.
1867
1868 * buffer.c (buffer_local_value_1): New function, split from
1869 Fbuffer_local_value; can return Qunbound.
1870 (Fbuffer_local_value): Use it.
1871 (Vmode_line_format): Docstring tweaks.
1872
773d47f6
PE
18732012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 * sysdep.c (system_process_attributes): Improve comment.
1876
f2d6a3df
SM
18772012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1878
1879 * keyboard.c: Export real-this-command to Elisp.
1880 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1881 and DEFVAR it. Update all users.
1882
63810350
PE
18832012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1884
7bd5c1f4
PE
1885 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1886
63810350
PE
1887 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1888 Convert pctcpu and pctmem to Lisp float properly.
1889 Let the compiler fold better, as 100.0/0x8000 is exact.
1890
a2821611
AS
18912012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1892
1893 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1894 cons_block.
1895
5fceba1d
PE
18962012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1897
1898 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1899
c98ff5dd
DA
19002012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1901
1902 For a 'struct window', replace some Lisp_Object fields to
1903 bitfields where appropriate, remove unused fields.
1904 * window.h (struct window): Remove unused 'last_mark_x' and
1905 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1906 change it's type from Lisp_Object to bitfield.
1907 Change type of 'force_start', 'optional_new_start',
1908 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1909 fields from Lisp_Object to bitfield. Adjust users accordingly.
1910
ca34e0be
PE
19112012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1912
1913 Pacify gcc -Wdouble-precision when using Xaw.
1914 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1915 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1916 Use 'float' consistently, rather than 'float' in most places
1917 and 'double' in a couple of places.
1918
efc00ab1 19192012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1920
1921 * xdisp.c (handle_stop): Detect whether we have overlay strings
1922 loaded by testing it->current.overlay_string_index to be
1923 non-negative, instead of checking whether n_overlay_strings is
1924 positive. (Bug#11587)
1925
efc00ab1 19262012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1927
1928 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1929
1930 * doc.c (Fsubstitute_command_keys): Doc fix.
1931
efc00ab1 19322012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1933
1934 * search.c (search_buffer): Remove calls to
1935 r_alloc_inhibit_buffer_relocation, as it is now called by
1936 maybe_unify_char, which was the cause of relocation of buffer text
1937 in bug#11519.
1938
efc00ab1 19392012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1940
1941 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1942 for the duration of call to load_charset, to avoid problems with
1943 callers of maybe_unify_char that access buffer text through C
1944 pointers.
1945
1946 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1947 decrement the inhibition flag, instead of just setting or
1948 resetting it.
1949
ba93a187
PE
19502012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1951
1952 Remove obsolete '#define static' cruft.
1953 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1954 This #undef was "temporary" in 2000; it is no longer needed
1955 now that '#define static' has gone away.
1956 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1957 (gray_bitmap_bits): Remove; no longer needed.
1958 All uses replaced with definiens.
1959 * xterm.c: Include "bitmaps/gray.xbm".
1960
9e4bf381
PE
19612012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1962
1963 Clean up __executable_start, monstartup when --enable-profiling.
1964 The following changes affect the code only when profiling.
1965 * dispnew.c (__executable_start): Rename from safe_bcopy.
1966 Define only on platforms that need it.
1967 * emacs.c: Include <sys/gmon.h> when profiling.
1968 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1969 (__executable_start): Remove decl, since lisp.h does it now.
1970 (safe_bcopy): Remove decl; no longer has that name.
1971 (main): Coalesce #if into single bit of code, for simplicity.
1972 Cast pointers to uintptr_t, since standard libraries want integers
1973 and not pointers.
1974 * lisp.h (__executable_start): New decl.
1975
32d72c2f
GM
19762012-05-31 Glenn Morris <rgm@gnu.org>
1977
1978 * image.c (Fimagemagick_types): Doc fix.
1979
baac5bc7
JM
19802012-05-30 Jim Meyering <meyering@redhat.com>
1981
1982 * callproc.c (Fcall_process_region): Include directory component
1983 in mkstemp error message (Bug#11586).
1984
72cb32cf
PE
19852012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1986
1987 * alloc.c, lisp.h (make_pure_vector): Now static.
1988
61b108cc
SM
19892012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1990
1991 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1992 Move to byte-run.el.
1993 (Fautoload): Do the hash-doc more carefully.
1994 * data.c (Fdefalias): Purify definition, except for keymaps.
1995 (Qdefun): Move from eval.c.
1996 * lisp.h (Qdefun): Remove.
1997 * lread.c (read1): Tiny simplification.
1998
471fe23d
TN
19992012-05-29 Troels Nielsen <bn.troels@gmail.com>
2000
934f3f58 2001 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2002 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2003 Bug#9642, but explicitly check that the buffer the overlay would
2004 be moved to is live and rearrange lines to make sure that errors
2005 will not put the overlay in an inconsistent state.
2006 (Fdelete_overlay): Cosmetics.
2007
85d0efd1
EZ
20082012-05-28 Eli Zaretskii <eliz@gnu.org>
2009
2010 * w32term.c (my_bring_window_to_top): New function.
2011 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2012 could be different from the original one.
2013 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2014 (Bug#11513)
2015
2016 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2017 by calling BringWindowToTop.
2018
2019 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2020 (WM_EMACS_END): Increase by one.
2021
da92a98c
PE
20222012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2023
2024 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2025 This avoids undefined behavior that might cause the eassert
2026 to not catch an out-of-range value.
2027
74d1f848
JB
20282012-05-28 Juanma Barranquero <lekktu@gmail.com>
2029
2030 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2031 Update dependencies.
2032
9e1a06fc
EZ
20332012-05-27 Eli Zaretskii <eliz@gnu.org>
2034
2035 * bidi.c (bidi_mirror_char): Fix last change.
2036
f3dd7312
AS
20372012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2038
2039 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2040 when referring to sectname field in printf format.
2041
81899c91
PE
20422012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2043
57b81a9f
PE
2044 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2045 Only r_alloc_inhibit_buffer_relocation needed to be added;
2046 the others were already declared.
2047
81899c91
PE
2048 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2049 before checking whether it's out of range. Put the check inside
2050 eassert. See
2051 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2052
33017faf 20532012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2054
2055 * callproc.c (Fcall_process): Restore a line that was accidentally
2056 commented out in the 2011-02-13 change (bug#11547).
2057
33017faf 20582012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2059
2060 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2061 defined on ralloc.c.
2062
2063 * buffer.c [REL_ALLOC]: Remove prototypes of
2064 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2065 they are now on lisp.h.
2066
2067 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2068
2069 * search.c (search_buffer): Use it to inhibit relocation of buffer
2070 text while re_search_2 is doing its job, because re_search_2 is
2071 passed C pointers to buffer text. (Bug#11519)
2072
23415acf
EZ
2073 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2074 Update value to 24.
2075
44e27368
EZ
2076 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2077 state after an additional call to move_it_in_display_line_to, keep
2078 the values of it->max_ascent and it->max_descent found for the
2079 entire line.
2080 (pos_visible_p): Revert the comparison against bottom_y to what it
2081 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2082 (Bug#11464)
2083
c1892f11
PE
20842012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2085
2086 Fix coding-related core dumps with gcc -ftrapv.
2087 The code was computing A - B, where A and B are pointers, and B is
2088 random garbage. This can lead to core dumps on platforms that
2089 have special pointer registers, and it also leads to core dumps on
2090 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2091 A - B only when B is initialized properly.
2092 * coding.c (coding_set_source, coding_set_destination): Return void.
2093 (coding_change_source, coding_change_destinations): New functions,
2094 with the old behaviors of coding_set_source and coding_set_destination.
2095 All callers that need an offset changed to use these new functions.
2096
eb7afdad
GM
20972012-05-26 Glenn Morris <rgm@gnu.org>
2098
2099 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2100
f12fdf02
EZ
21012012-05-26 Eli Zaretskii <eliz@gnu.org>
2102
53a63be6 2103 Extend mouse support on W32 text-mode console.
61b108cc
SM
2104 * xdisp.c (draw_row_with_mouse_face):
2105 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2106
eb3f6f01 2107 * w32console.c: Include window.h.
61b108cc
SM
2108 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2109 New functions.
eb3f6f01
EZ
2110 (initialize_w32_display): Initialize mouse-highlight data.
2111
53a63be6
EZ
2112 * w32inevt.c: Include termchar.h and window.h.
2113 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2114 moves, call note_mouse_highlight. If help_echo changed, call
2115 gen_help_event to produce help-echo message in the echo area.
2116 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2117 highlight info.
2118
4cfd81f6
PE
21192012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2120
2121 * lread.c (read1): Simplify slightly to avoid an overflow warning
2122 with GCC 4.7.0 on x86-64.
2123
4446092a
EZ
21242012-05-26 Eli Zaretskii <eliz@gnu.org>
2125
2126 * bidi.c (bidi_mirror_char): Revert last change: an int is
2127 definitely wide enough here.
2128
42b2a986 21292012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2130
42b2a986 2131 Fix integer width and related bugs (Bug#9874).
eb106a49 2132 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2133 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2134 (string_bytes, check_sblock, allocate_string_data):
2135 (compact_small_strings, Fmake_bool_vector, make_string)
2136 (make_unibyte_string, make_multibyte_string)
2137 (make_string_from_bytes, make_specified_string)
2138 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2139 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2140 (mark_vectorlike):
2141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2142 (allocate_pseudovector):
2143 Use int, not EMACS_INT, where int is wide enough.
2144 (inhibit_garbage_collection, Fgarbage_collect):
2145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2146 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2147 int might not be wide enough.
2148 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2149 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2150 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2151 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2152 (bidi_level_of_next_char, bidi_move_to_visually_next):
2153 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2154 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2155 (Fkill_buffer, Fset_buffer_major_mode)
2156 (advance_to_char_boundary, Fbuffer_swap_text)
2157 (Fset_buffer_multibyte, overlays_at, overlays_in)
2158 (overlay_touches_p, struct sortvec, record_overlay_string)
2159 (overlay_strings, recenter_overlay_lists)
2160 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2161 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2162 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2163 (Foverlay_recenter, last_overlay_modification_hooks_used)
2164 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2166 (validate_region): Omit unnecessary test for b <= e,
2167 since that's guaranteed by the previous test.
d311d28c
PE
2168 (adjust_overlays_for_delete): Avoid pos + length overflow.
2169 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2170 (report_overlay_modification):
2171 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2172 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2173 Omit pointer cast, which isn't needed anyway, and doesn't work
2174 after the EMACS_INT -> ptrdiff_t change.
02481186 2175 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2176 * buffer.h: Adjust decls to match defn changes elsewhere.
2177 (struct buffer_text, struct buffer):
2178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2179 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2180 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2181 not int, to avoid needless 32-bit limit on 64-bit hosts.
2182 (exec_byte_code): Use tighter memory-full test, one that checks
2183 for alloca overflow. Don't compute the address of the object just
2184 before an array, as that's not portable. Use EMACS_INT, not
2185 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2186 * callint.c (Fcall_interactively):
2187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2188 * callproc.c (call_process_kill, Fcall_process):
2189 Don't assume pid_t fits into an Emacs fixnum.
2190 (call_process_cleanup, Fcall_process, child_setup):
2191 Don't assume pid_t fits into int.
2192 (call_process_cleanup, Fcall_process, delete_temp_file)
2193 (Fcall_process_region):
2194 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2195 (Fcall_process): Simplify handling of volatile integers.
2196 Use int, not EMACS_INT, where int will do.
2197 * casefiddle.c (casify_object, casify_region, operate_on_word)
2198 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2199 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2200 (casify_object): Avoid integer overflow when overallocating buffer.
2201 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2202 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2203 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2204 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2205 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2206 integers are now checked earlier. All uses replaced with XINT.
2207 (ccl_driver):
2208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2209 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2210 (ccl_driver, Fregister_code_conversion_map):
2211 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2212 (resolve_symbol_ccl_program): Check that vector header is in range.
2213 Always copy the vector, so that we can check its contents reliably
2214 now rather than having to recheck each instruction as it's being
2215 executed. Check that vector words fit in 'int'.
2216 (ccl_get_compiled_code, Fregister_ccl_program)
2217 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2218 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2219 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2220 contents are in range.
2221 (Fccl_execute_on_string): Check that status is in range.
2222 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2223 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2224 Accept and return EMACS_INT, not int, because callers can pass values
2225 out of 'int' range.
2226 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2227 (multibyte_chars_in_text, parse_str_as_multibyte)
2228 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2229 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2230 (string_escape_byte8, Fget_byte):
2231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2232 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2233 avoid mishandling large integers.
2234 * character.h: Adjust decls to match defn changes elsewhere.
2235 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2236 (Ffind_charset_region):
2237 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2238 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2239 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2240 Don't assume fixnum fits in int.
d311d28c
PE
2241 (load_charset_map_from_vector, Fmap_charset_chars):
2242 Remove now-unnecessary CHECK_NATNUMs.
2243 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2244 Don't rely on undefined behavior with signed left shift overflow.
2245 Don't assume unsigned int fits into fixnum, or that fixnum fits
2246 into unsigned int. Don't require max_code to be a valid fixnum;
2247 that's not true for gb10830 4-byte on a 32-bit host. Allow
2248 invalid_code to be a cons, for the same reason. Require code_offset
2249 to be a character. Avoid int overflow if max_char is close
2250 to INT_MAX.
2251 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2252 this is intended anyway and avoids some undefined behavior.
2253 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2254 INDEX_TO_CODE_POINT, as that's what it expects.
2255 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2256 * charset.h (DECODE_CHAR): Return int, not unsigned;
2257 this is what was intended anyway, and it avoids undefined behavior.
2258 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2259 integer-overflow issues.
2260 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2261 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2262 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2263 * chartab.c (Fmake_char_table, Fset_char_table_range)
2264 (uniprop_get_decoder, uniprop_get_encoder):
2265 Don't assume fixnum fits in int.
2266 * cmds.c (move_point): New function, that does the gist of
2267 Fforward_char and Fbackward_char, but does so while checking
2268 for integer overflow more accurately.
c96e5d6a 2269 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2270 (Fforward_line, Fend_of_line, internal_self_insert)
2271 (internal_self_insert):
2272 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2273 Fix a FIXME, by checking for integer overflow when calculating
2274 target_clm and actual_clm.
2275 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2276 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2277 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2278 (coding_alloc_by_making_gap, alloc_destination)
2279 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2280 (encode_coding_utf_16, detect_coding_emacs_mule)
2281 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2282 (detect_coding_iso_2022, decode_coding_iso_2022)
2283 (encode_invocation_designation, encode_designation_at_bol)
2284 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2285 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2286 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2287 (encode_coding_ccl, encode_coding_raw_text)
2288 (detect_coding_charset, decode_coding_charset)
2289 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2290 (produce_composition, produce_charset, produce_annotation)
2291 (decode_coding, handle_composition_annotation)
2292 (handle_charset_annotation, consume_chars, decode_coding_gap)
2293 (decode_coding_object, encode_coding_object, detect_coding_system)
2294 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2295 (code_convert_region, code_convert_string)
8f50130c
PE
2296 (Fdefine_coding_system_internal)
2297 (coding_set_source, coding_set_destination):
d311d28c
PE
2298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2299 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2300 (Fdefine_coding_system_internal):
2301 Don't assume fixnums fit in int.
2302 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2303 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2304 (Funencodable_char_position, Fcheck_coding_systems_region)
2305 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2306 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2307 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2308 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2309 Don't access memory outside of the args array.
d311d28c 2310 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2311 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2312 result of ENCODE_CHAR.
d311d28c
PE
2313 * coding.h: Adjust decls to match defn changes elsewhere.
2314 (struct coding_system):
2315 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2316 * composite.c (get_composition_id, find_composition)
2317 (run_composition_function, update_compositions)
2318 (compose_text, composition_gstring_put_cache)
2319 (composition_gstring_p, composition_gstring_width)
2320 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2321 (composition_compute_stop_pos, composition_reseat_it)
2322 (composition_update_it, struct position_record)
2323 (find_automatic_composition, composition_adjust_point)
2324 (Fcomposition_get_gstring, Ffind_composition_internal):
2325 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2326 (update_compositions):
2327 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2328 * composite.h: Adjust decls to match defn changes elsewhere.
2329 (struct composition):
2330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2331 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2332 Do not attempt to compute the address of the object just before a
2333 buffer; this is not portable.
2334 (Faref, Faset):
2335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2336 (Faset): Use int, not EMACS_INT, where int is wide enough.
2337 (Fstring_to_number): Don't assume fixnums fit in int.
2338 (Frem): Don't assume arg is nonnegative.
2339 * dbusbind.c (xd_append_arg): Check for integers out of range.
2340 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2341 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2342 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2343 (xd_get_connection_references): Return ptrdiff_t, not int.
2344 All uses changed.
2345 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2346 (xd_read_message_1):
2347 Use int, not unsigned, where the dbus API uses int.
2348 (Fdbus_message_internal): Don't overflow mtype.
2349 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2350 * dired.c (directory_files_internal, file_name_completion, scmp)
2351 (file_name_completion_stat):
2352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2353 (file_name_completion): Don't overflow matchcount.
2354 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2355 * dispextern.h: Adjust decls to match defn changes elsewhere.
2356 (struct text_pos, struct glyph, struct bidi_saved_info)
2357 (struct bidi_string_data, struct bidi_it, struct composition_it)
2358 (struct it):
2359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2360 (struct display_pos, struct composition_it, struct it):
2361 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2362 * dispnew.c (increment_matrix_positions)
2363 (increment_row_positions, mode_line_string)
2364 (marginal_area_string):
2365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2366 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2367 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2368 (duration_to_sec_usec): New function, to check for overflow better.
2369 (Fsleep_for, sit_for): Use it.
2370 * doc.c (get_doc_string, store_function_docstring):
2371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2372 (get_doc_string, Fsnarf_documentation):
2373 Use int, not EMACS_INT, where int is wide enough.
2374 (get_doc_string):
2375 Use SAFE_ALLOCA, not alloca.
2376 Check for overflow when converting EMACS_INT to off_t.
2377 * doprnt.c (doprnt):
2378 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2379 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2380 Don't assume uid_t fits into fixnum.
2381 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2382 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2383 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2384 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2385 (general_insert_function)
2386 (Finsert_char, make_buffer_string, make_buffer_string_both)
2387 (update_buffer_properties, Fbuffer_substring)
2388 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2389 (Fsubst_char_in_region, check_translation)
2390 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2391 (transpose_markers, Ftranspose_regions):
2392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2393 (clip_to_bounds): Move to lisp.h as an inline function).
2394 (Fconstrain_to_field): Don't assume integers are nonnegative.
2395 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2396 (Fsubst_char_in_region, Fsave_restriction):
2397 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2398 (Femacs_pid): Don't assume pid_t fits into fixnum.
2399 (lo_time): Use int, not EMACS_INT, when int suffices.
2400 (lisp_time_argument): Check for usec out of range.
2401 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2402 (Fuser_login_name, Fuser_full_name): Signal an error
2403 if a uid argument is out of range, rather than relying on
2404 undefined behavior.
c8d5c857
PE
2405 (Fformat_time_string): Remove now-unnecessary check.
2406 lisp_time_argument checks for out-of-range usec now.
243e0530 2407 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2408 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2409 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2410 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2411 (init_cmdargs, Fdump_emacs):
2412 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2413 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2414 the bottom (typically) 32 bits of the fixnum.
2415 * eval.c (specpdl_size, call_debugger):
2416 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2417 (when_entered_debugger, Fbacktrace_debug):
2418 Don't assume fixnum can fit in int.
2419 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2420 the object just before a buffer; this is not portable.
2421 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2422 (grow_specpdl, unbind_to):
2423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2424 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2425 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2426 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2427 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2428 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2429 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2430 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2431 (a_write, e_write):
2432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2433 (Fcopy_file, non_regular_nbytes, read_non_regular)
2434 (Finsert_file_contents):
2435 Use int, not EMACS_INT, where int is wide enough.
2436 (READ_BUF_SIZE): Verify that it fits in int.
2437 (Finsert_file_contents): Check that counts are in proper range,
2438 rather than assuming fixnums fit into ptrdiff_t etc.
2439 Don't assume fixnums fit into int.
125b3835 2440 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2441 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2442 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2443 (string_char_to_byte, string_byte_to_char)
2444 (string_make_multibyte, string_to_multibyte)
2445 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2446 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2447 (substring_both, Fdelete, internal_equal, Ffillarray)
2448 (Fclear_string, mapcar1)
2449 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2450 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2451 (larger_vector, make_hash_table, maybe_resize_hash_table)
2452 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2453 (Fmaphash, secure_hash):
2454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2455 (concat): Check for string index and length overflow.
2456 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2457 (Frequire):
2458 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2459 (larger_vector): New API (vec, incr_min, size_max) replaces old
2460 one (vec, new_size, init). This catches size overflow.
2461 INIT was removed because it was always Qnil.
2462 All callers changed.
2463 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2464 the upper bound on a hash table index size.
2465 (make_hash_table, maybe_resize_hash_table): Use it.
2466 (secure_hash): Computer start_byte and end_byte only after
2467 they're known to be in ptrdiff_t range.
2468 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2469 (Ffont_get_glyphs, Ffont_at):
2470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2471 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2472 (Flist_fonts, Fopen_font):
2473 Don't assume fixnum can fit in int.
2474 (check_gstring): Don't assume index can fit in int.
2475 (font_match_p): Check that fixnum is a character, not a nonnegative
2476 fixnum, since the later code needs to stuff it into an int.
2477 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2478 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2479 conversion overflow issues.
2480 (Fopen_font): Check for integer out of range.
2481 (Ffont_get_glyphs): Don't assume index can fit in int.
2482 * font.h: Adjust decls to match defn changes elsewhere.
2483 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2484 integer overflow.
2485 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2486 printmax_t, where ptrdiff_t is wide enough.
2487 (Finternal_char_font):
2488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2489 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2490 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2491 (Fset_frame_position, x_set_frame_parameters)
2492 (x_set_line_spacing, x_set_border_width)
2493 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2494 Check that fixnums are in proper range for system types.
2495 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2497 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2498 Use SAFE_ALLOCA_LISP, not alloca.
2499 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2500 intptr_t is wide enough.
2501 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2502 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2503 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2504 Check for fixnum out of range.
2505 * ftfont.c (ftfont_list): Don't assume index fits in int.
2506 Check that fixnums are in proper range for system types.
2507 (ftfont_shape_by_flt):
2508 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2509 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2511 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2512 Check that fixnums are in proper range for system types.
2513 * gnutls.h: Adjust decls to match defn changes elsewhere.
2514 * gtkutil.c (xg_dialog_run):
2515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2516 (update_frame_tool_bar):
2517 Check that fixnums are in proper range for system types.
2518 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2519 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2520 * indent.c (last_known_column, last_known_column_point):
2521 (current_column_bol_cache):
2522 (skip_invisible, current_column, check_display_width):
2523 (check_display_width, scan_for_column, current_column_1)
2524 (Findent_to, Fcurrent_indentation, position_indentation)
2525 (indented_beyond_p, Fmove_to_column, compute_motion):
2526 (Fcompute_motion, Fvertical_motion):
2527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2528 (last_known_column_modified): Use EMACS_INT, not int.
2529 (check_display_width):
2530 (Fcompute_motion):
2531 Check that fixnums and floats are in proper range for system types.
2532 (compute_motion): Don't assume index or fixnum fits in int.
2533 (compute_motion, Fcompute_motion):
2534 Use int, not EMACS_INT, when it is wide enough.
2535 (vmotion): Omit local var start_hpos that is always 0; that way
2536 we don't need to worry about overflow in expressions involving it.
2537 * indent.h: Adjust decls to match defn changes elsewhere.
2538 (struct position):
2539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2540 Use int, not EMACS_INT, where int is wide enough.
2541 Remove unused members ovstring_chars_done and tab_offset;
2542 all uses removed.
2543 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2544 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2545 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2546 (make_gap, copy_text, insert, insert_and_inherit)
2547 (insert_before_markers, insert_before_markers_and_inherit)
2548 (insert_1, count_combining_before, count_combining_after)
2549 (insert_1_both, insert_from_string)
2550 (insert_from_string_before_markers, insert_from_string_1)
2551 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2552 (adjust_after_replace, adjust_after_insert, replace_range)
2553 (replace_range_2, del_range, del_range_1, del_range_byte)
2554 (del_range_both, del_range_2, modify_region)
2555 (prepare_to_modify_buffer, signal_before_change)
2556 (signal_after_change, Fcombine_after_change_execute):
2557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2558 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2559 (balance_an_interval, split_interval_right, split_interval_left)
2560 (find_interval, next_interval, update_interval)
2561 (adjust_intervals_for_insertion, delete_node, delete_interval)
2562 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2563 (static_offset_intervals, offset_intervals)
2564 (merge_interval_right, merge_interval_left, make_new_interval)
2565 (graft_intervals_into_buffer, temp_set_point_both)
2566 (temp_set_point, set_point, adjust_for_invis_intang)
2567 (set_point_both, move_if_not_intangible, get_property_and_range)
2568 (get_local_map, copy_intervals, copy_intervals_to_string)
2569 (compare_string_intervals, set_intervals_multibyte_1):
2570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2571 * intervals.h: Adjust decls to match defn changes elsewhere.
2572 (struct interval):
2573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2574 * keyboard.c (this_command_key_count, this_single_command_key_start)
2575 (before_command_key_count, before_command_echo_length, echo_now)
2576 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2577 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2578 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2579 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2580 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2581 (last_non_minibuf_size, last_point_position, echo_truncate)
2582 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2583 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2584 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2585 (stuff_buffered_input):
2586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2587 (last_auto_save, command_loop_1, read_char):
2588 Use EMACS_INT, not int, to avoid integer overflow.
2589 (record_char): Avoid overflow in total_keys computation.
2590 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2591 * keyboard.h: Adjust decls to match defn changes elsewhere.
2592 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2593 (Fkey_description, Fdescribe_vector, Flookup_key):
2594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2595 (click_position): New function, to check that positions are in range.
2596 (Fcurrent_active_maps):
2597 (describe_command):
2598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2599 (Faccessible_keymaps, Fkey_description):
2600 (preferred_sequence_p):
2601 Don't assume fixnum can fit into int.
2602 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2603 Check for integer overflow in size calculations.
2604 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2605 avoid mishandling large integers.
2606 * lisp.h: Adjust decls to match defn changes elsewhere.
2607 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2608 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2609 (struct Lisp_Marker):
2610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2611 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2612 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2613 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2614 All callers changed.
2615 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2616 Assume the arg has valid form, since it always does.
2617 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2618 unsigned integer system type.
2619 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2620 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2622 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2623 (duration_to_sec_usec): New decl.
2624 * lread.c (read_from_string_index, read_from_string_index_byte)
2625 (read_from_string_limit, readchar, unreadchar, openp)
2626 (read_internal_start, read1, oblookup):
2627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2628 (Fload, readevalloop, Feval_buffer, Feval_region):
2629 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2630 (openp): Check for out-of-range argument to 'access'.
2631 (read1): Use int, not EMACS_INT, where int is wide enough.
2632 Don't assume fixnum fits into int.
6efdadfd 2633 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2634 (read_filtered_event): Use duration_to_sec_usec
2635 to do proper overflow checking on durations.
d311d28c
PE
2636 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2637 in size calculation.
2638 (Fexecute_kbd_macro):
2639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2640 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2641 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2642 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2643 (set_marker_both, set_marker_restricted_both, marker_position)
2644 (marker_byte_position, Fbuffer_has_markers_at):
2645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2646 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2647 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2648 It now merely ensures that the menu is large enough, without
2649 necessarily growing it, as this avoids some integer overflow issues.
2650 All callers changed.
2651 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2653 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2654 Use SAFE_ALLOCA_LISP, not alloca.
2655 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2656 to EMACS_INT. Check that fixnums are in proper range for system types.
2657 * minibuf.c (minibuf_prompt_width, string_to_object)
2658 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2659 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2661 (get_minibuffer, read_minibuf_unwind):
2662 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2663 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2664 this simplifies overflow checking. All callers changed.
2665 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2666 (Ftest_completion):
2667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2668 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2669 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2670 Check that fixnums are in proper range for system types.
2671 (Fx_create_frame, Fx_show_tip):
2672 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2673 * nsfont.m (ns_findfonts, nsfont_list_family):
2674 Don't assume fixnum fits in long.
2675 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2677 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2678 wide enough.
17fdb222 2679 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2680 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2681 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2682 (PRINTDECLARE, PRINTPREPARE):
2683 (strout, print_string):
2684 (print, print_preprocess, print_check_string_charset_prop)
2685 (print_object):
2686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2687 (PRINTDECLARE):
2688 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2690 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2691 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2692 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2693 (print_error_message): Use SAFE_ALLOCA, not alloca.
2694 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2695 (print_depth, new_backquote_output, print_number_index):
2696 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2697 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2698 (Fset_process_window_size, Fformat_network_address)
2699 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2700 (sigchld_handler):
d311d28c 2701 Check that fixnums are in proper range for system types.
d44287d4 2702 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2703 Check for process-ids out of pid_t range rather than relying on
2704 undefined behavior.
e4d81efc 2705 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2706 (Fformat_network_address, read_process_output, send_process)
2707 (Fprocess_send_region, status_notify):
2708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2709 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2710 (wait_reading_process_output, read_process_output, exec_sentinel):
2711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2712 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2713 (Faccept_process_output): Use duration_to_sec_usec to do proper
2714 overflow checking on durations.
dde14581
PE
2715 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2716 Don't assume pid_t fits in int.
02481186
PE
2717 * process.h (struct Lisp_Process): Members tick and update_tick
2718 are now of type EMACS_INT, not int.
b62b53e8
PE
2719 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2720 configured --with-wide-int.
d311d28c
PE
2721 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2722 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2723 * search.c (looking_at_1, string_match_1):
2724 (fast_string_match, fast_c_string_match_ignore_case)
2725 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2726 (scan_newline, find_before_next_newline, search_command)
2727 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2728 (set_search_regs, wordify):
2729 (Freplace_match):
2730 (Fmatch_data):
2731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2732 (string_match_1, search_buffer, set_search_regs):
2733 (Fmatch_data):
2734 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2735 (wordify): Check for overflow in size calculation.
2736 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2737 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2738 Check that fixnums are in proper range for system types.
2739 * sound.c (struct sound_device)
2740 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2742 (Fplay_sound_internal):
2743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2744 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2745 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2746 (Fparse_partial_sexp):
2747 Don't assume fixnums can fit in int.
2748 (struct lisp_parse_state, find_start_pos, find_start_value)
2749 (find_start_value_byte, find_start_begv)
2750 (update_syntax_table, char_quoted, dec_bytepos)
2751 (find_defun_start, prev_char_comend_first, back_comment):
2752 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2753 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2755 (Finternal_describe_syntax_value): Check that match_lisp is a
2756 character, not an integer, since the code stuffs it into int.
2757 (scan_words, scan_sexps_forward):
2758 Check that fixnums are in proper range for system types.
2759 (Fforward_word):
2760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2761 (scan_sexps_forward):
2762 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2763 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2764 * syntax.h: Adjust decls to match defn changes elsewhere.
2765 (struct gl_state_s):
2766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2767 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2768 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2769 * sysdep.c (wait_for_termination_1, wait_for_termination)
2770 (interruptible_wait_for_termination, mkdir):
2771 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2772 (emacs_read, emacs_write):
2773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2774 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2775 and double all fit in int.
d311d28c
PE
2776 * term.c (set_tty_color_mode):
2777 Check that fixnums are in proper range for system types.
2778 * termhooks.h (struct input_event):
2779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2780 * textprop.c (validate_interval_range, interval_of)
2781 (Fadd_text_properties, set_text_properties_1)
2782 (Fremove_text_properties, Fremove_list_of_text_properties)
2783 (Ftext_property_any, Ftext_property_not_all)
2784 (copy_text_properties, text_property_list, extend_property_ranges)
2785 (verify_interval_modification):
2786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2787 (Fnext_single_char_property_change)
2788 (Fprevious_single_char_property_change):
2789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2790 (copy_text_properties):
2791 Check for integer overflow in index calculation.
d311d28c
PE
2792 * undo.c (last_boundary_position, record_point, record_insert)
2793 (record_delete, record_marker_adjustment, record_change)
2794 (record_property_change):
2795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2796 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2798 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2799 (Fx_hide_tip, Fx_file_dialog):
2800 * w32menu.c (set_frame_menubar):
2801 Use ptrdiff_t, not int, for consistency with rest of code.
2802 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2803 (select_window, Fdelete_other_windows_internal)
2804 (window_scroll_pixel_based, window_scroll_line_based)
2805 (Frecenter, Fset_window_configuration):
2806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2807 (Fset_window_hscroll, run_window_configuration_change_hook)
2808 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2809 (Fscroll_other_window, Frecenter):
d311d28c
PE
2810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2811 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2812 Don't assume fixnum fits in int.
2813 (Fset_window_scroll_bars):
2814 Check that fixnums are in proper range for system types.
2815 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2816 (string_pos, c_string_pos, number_of_chars, init_iterator)
2817 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2818 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2819 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2820 (face_before_or_after_it_pos, handle_invisible_prop)
2821 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2822 (display_prop_intangible_p, string_buffer_position_lim)
2823 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2824 (get_overlay_strings_1, get_overlay_strings)
2825 (iterate_out_of_display_property, forward_to_next_line_start)
2826 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2827 (get_next_display_element, set_iterator_to_next)
2828 (get_visually_first_element, compute_stop_pos_backwards)
2829 (handle_stop_backwards, next_element_from_buffer)
2830 (move_it_in_display_line_to, move_it_in_display_line)
2831 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2832 (add_to_log, message_dolog, message_log_check_duplicate)
2833 (message2, message2_nolog, message3, message3_nolog
2834 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2835 (current_message_1, truncate_echo_area, truncate_message_1)
2836 (set_message, set_message_1, store_mode_line_noprop)
2837 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2838 (text_outside_line_unchanged_p, check_point_in_composition)
2839 (reconsider_clip_changes)
2840 (redisplay_internal, set_cursor_from_row, try_scrolling)
2841 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2842 (redisplay_window, find_last_unchanged_at_beg_row)
2843 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2844 (trailing_whitespace_p, find_row_edges, display_line)
2845 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2846 (display_mode_element, store_mode_line_string)
2847 (pint2str, pint2hrstr, decode_mode_spec)
2848 (display_count_lines, display_string, draw_glyphs)
2849 (x_produce_glyphs, x_insert_glyphs)
2850 (rows_from_pos_range, mouse_face_from_buffer_pos)
2851 (fast_find_string_pos, mouse_face_from_string_pos)
2852 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2853 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2854 (safe_call, init_from_display_pos, handle_fontified_prop)
2855 (handle_single_display_spec, load_overlay_strings)
2856 (with_echo_area_buffer, setup_echo_area_for_printing)
2857 (display_echo_area, echo_area_display)
2858 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2859 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2860 (redisplay_window, dump_glyph_row, display_mode_line)
2861 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2862 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2864 (handle_single_display_spec, build_desired_tool_bar_string)
2865 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2866 (get_specified_cursor_type):
2867 Check that fixnums are in proper range for system types.
2868 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2869 (Flookup_image_map):
2870 Don't assume fixnums fit in int.
2871 (compare_overlay_entries):
2872 Avoid mishandling comparisons due to subtraction overflow.
2873 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2874 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2875 (handle_tool_bar_click):
2876 Use int, not unsigned, since we prefer signed and the signedness
2877 doesn't matter here.
2878 (get_next_display_element, next_element_from_display_vector):
2879 Use int, not EMACS_INT, when int is wide enough.
2880 (start_hourglass): Use duration_to_sec_usec to do proper
2881 overflow checking on durations.
2882 * xfaces.c (Fbitmap_spec_p):
2883 Check that fixnums are in proper range for system types.
2884 (compare_fonts_by_sort_order):
2885 Avoid mishandling comparisons due to subtraction overflow.
2886 (Fx_family_fonts, realize_basic_faces):
2887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2888 (Fx_family_fonts):
2889 Don't assume fixnum fits in int.
2890 Use SAFE_ALLOCA_LISP, not alloca.
2891 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2892 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2893 (face_at_buffer_position, face_for_overlay_string)
2894 (face_at_string_position):
2895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2896 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2897 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2898 (Fx_show_tip):
2899 Check that fixnums are in proper range for system types.
2900 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2901 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2902 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2903 (Fx_change_window_property): Don't assume fixnums fit in int.
2904 * xfont.c (xfont_chars_supported):
2905 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2906 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2907 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2909 * xml.c (parse_region):
2910 * xrdb.c (magic_file_p):
2911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2912 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2913 (x_get_local_selection, x_reply_selection_request)
2914 (x_handle_selection_request, wait_for_property_change):
2915 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2916 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2917 short is wide enough.
2918 (x_send_client_event): Don't assume fixnum fits in int.
2919 * xterm.c (x_x_to_emacs_modifiers):
2920 Don't assume EMACS_INT overflows nicely into int.
2921 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2922 may come from Lisp.
2923 (handle_one_xevent): NATNUMP can eval its arg twice.
2924 (x_connection_closed):
2925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2926 * xterm.h: Adjust decls to match defn changes elsewhere.
2927 (struct scroll_bar): Use struct vectorlike_header
2928 rather than rolling our own approximation.
2929 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2930
c6574eb5
GM
29312012-05-25 Glenn Morris <rgm@gnu.org>
2932
2933 * lisp.mk (lisp): Update for more files being compiled now.
2934
e8d32c7e
SM
29352012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2936
48def666
SM
2937 * lread.c: Remove `read_pure' which makes no difference.
2938 (read_pure): Remove var.
2939 (unreadpure): Remove function.
2940 (readevalloop): Don't call read_list with -1 flag.
2941 (read1, read_vector): Don't test read_pure any more.
2942 (read_list): Simplify.
2943
e8d32c7e
SM
2944 * fileio.c, character.h: Minor style tweaks.
2945
4b2addb7
DA
29462012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2947
2948 * window.h (clip_changed): Remove useless declaration.
2949
584461b2
JB
29502012-05-22 Juanma Barranquero <lekktu@gmail.com>
2951
2952 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2953 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2954
34374650
PE
29552012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2956
2957 Remove src/m/*.
2958 This directory predates autoconf and is no longer needed nowadays.
2959 Move its few remaining bits of functionality to where they're needed.
2960 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2961 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2962 * m/template.h: Remove.
2963 * Makefile.in (M_FILE): Remove. All uses removed.
2964 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2965 * lisp.h (USE_LSB_TAG):
2966 * mem-limits.h (EXCEEDS_LISP_PTR):
2967 Use VAL_MAX, not VALBITS, in #if.
2968 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2969 (EMACS_UINT): Define unconditionally now.
2970 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2971 (BITS_PER_EMACS_INT): New constants, replacing
2972 what used to be in config.h, but not useful in #if.
2973 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2974 define them any more.
2975 (VAL_MAX): New macro.
2976 (VALMASK): Use it.
2977 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2978 BITS_PER_EMACS_INT, in #if.
2979 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2980 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2981 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2982 * s/ms-w32.h (DATA_START):
2983 Move here from removed file m/intel386.h.
2984 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2985 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2986
261cb4bb
PE
29872012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2988
2989 Assume C89 or later.
2990 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2991 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2992 (xrealloc):
2993 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2994 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2995 * textprop.c, tparam.c (NULL): Remove.
2996 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2997 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2998 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2999 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3000 * xterm.c (input_signal_count): Assume volatile works.
3001
ff23cd9f
KB
30022012-05-21 Ken Brown <kbrown@cornell.edu>
3003
3004 * xgselect.c (xg_select): Fix first argument in call to 'select'
3005 (bug#11508).
3006
1b170bc6
KB
30072012-05-20 Ken Brown <kbrown@cornell.edu>
3008
3009 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3010 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3011
b2f4d39f
KB
30122012-05-19 Ken Brown <kbrown@cornell.edu>
3013
3014 * xfns.c (x_in_use): Remove `static' qualifier.
3015 * xterm.h (x_in_use): Declare.
3016 * xgselect.c: Include xterm.h.
3017 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3018 and `display_arg' (bug#9754).
3019
003fdae2
PE
30202012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3021
9232a6d9
PE
3022 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3023
003fdae2
PE
3024 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3025 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3026
784b56e2
EZ
30272012-05-18 Eli Zaretskii <eliz@gnu.org>
3028
3029 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3030
3031 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3032 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3033
3034 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3035 reference to image_cache->refcount.
3036 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3037
a0a79cde
JL
30382012-05-17 Juri Linkov <juri@jurta.org>
3039
3040 * search.c (Fword_search_regexp, Fword_search_backward)
3041 (Fword_search_forward, Fword_search_backward_lax)
3042 (Fword_search_forward_lax): Move functions to isearch.el
3043 (bug#10145, bug#11381).
3044
b0572523
PE
30452012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3046
3047 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3048
9660f5fc
SM
30492012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3050
3051 * lread.c (init_obarray): Declare Qt and Qnil as special.
3052
4374de83
GM
30532012-05-14 Glenn Morris <rgm@gnu.org>
3054
3055 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3056 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3057
dc44c39a
PE
30582012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3059
078c97cb
PE
3060 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3061
dc44c39a
PE
3062 * unexaix.c: Port to more-recent AIX compilers.
3063 (report_error, report_error_1, make_hdr, copy_sym)
3064 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3065 Make arguments const char *, not char *, to avoid violations of C
3066 standard and to fix some AIX warnings reported by Gilles Pion.
3067
e18afed7 30682012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3069
3070 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3071 already have overlays loaded.
3072 (handle_single_display_spec): Before returning without displaying
3073 fringe bitmap, synchronize the bidi iterator with the main display
3074 iterator, by calling iterate_out_of_display_property.
3075 (iterate_out_of_display_property): Detect buffer iteration by
3076 testing that it->string is a Lisp string.
3077 (get_next_display_element): When the current object is exhausted,
3078 and there's something on it->stack, call set_iterator_to_next to
3079 proceed with what's on the stack, instead of returning zero.
3080 (set_iterator_to_next): If called at the end of a Lisp string,
3081 proceed to consider_string_end without incrementing string
3082 position. Don't increment display vector index past the end of
3083 the display vector. (Bug#11417)
c8fb9dc6
EZ
3084 (pos_visible_p): Don't report a position visible when move_it_to
3085 stopped at the last line of window, which happens to be scanned
3086 backwards by the bidi iteration. (Bug#11464)
ac268e67 3087
e18afed7 30882012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3089
3090 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3091 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3092 are on a TTY, and thus unable to display on the fringes.
3093 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3094 so we need to signal to the caller that this is a "replacing"
3095 display spec. This fixes display when the spec is invalid or we
3096 are on a TTY.
3097
e18afed7 30982012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3099
3100 * unexaix.c (make_hdr): Fix typo in prototype.
3101 This bug broke the build on AIX. Problem reported by Gilles Pion.
3102
9d0a235a
MA
31032012-05-14 Michael Albinus <michael.albinus@gmx.de>
3104
3105 * keyboard.c (kbd_buffer_get_event): Read special events also in
3106 batch mode. (Bug#11415)
3107
9e6b06ed
GM
31082012-05-12 Glenn Morris <rgm@gnu.org>
3109
3110 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3111
c1a1d7a3
EZ
31122012-05-12 Eli Zaretskii <eliz@gnu.org>
3113
3114 * lisp.mk (lisp): Add newcomment.elc.
3115
3fe7cdc8
GM
31162012-05-12 Glenn Morris <rgm@gnu.org>
3117
3118 * Makefile.in (MKDIR_P): New, set by configure.
3119 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3120
53f7d2c0
PE
31212012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3122
3123 Remove unused function hourglass_started.
3124 * dispextern.h (hourglass_started):
3125 * w32fns.c (hourglass_started):
3126 * xdisp.c (hourglass_started): Remove.
3127
75aafb17
JB
31282012-05-10 Juanma Barranquero <lekktu@gmail.com>
3129
3130 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3131 Update dependencies.
3132
12959e8e
PE
31332012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3134
97107e2e
PE
3135 * xgselect.c (xg_select): Put maxfds+1 into a var.
3136 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3137
12959e8e
PE
3138 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3139
836d29b3
DA
31402012-05-10 Dave Abrahams <dave@boostpro.com>
3141
3142 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3143 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3144
5cb67954
MA
31452012-05-09 Michael Albinus <michael.albinus@gmx.de>
3146
3147 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3148 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3149 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3150 Initialize xd_registered_buses.
3151
3478ec45
PE
31522012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3153
b263a6b0
PE
3154 Untag more efficiently if USE_LSB_TAG.
3155 This is based on a proposal by YAMAMOTO Mitsuharu in
3156 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3157 For an admittedly artificial (nth 8000 longlist) benchmark on
3158 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3159 Emacs's overall text size by 1%.
3160 * lisp.h (XUNTAG): New macro.
3161 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3162 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3163 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3164 * eval.c (Fautoload):
3165 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3166 * frame.h (XFRAME): Use XUNTAG.
3167
3478ec45
PE
3168 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3169 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3170 Remove unportable assumptions about print widths of types like
3171 dbus_uint32_t.
3172 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3173 intptr_t when converting between pointer and integer, to avoid GCC
3174 warnings about wrong width.
3175
666b903b 31762012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3177
3178 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3179 stack for each reader_thread, instead of defaulting to 8MB
3180 determined by the linker. This avoids failures in creating
3181 subprocesses on Windows 7, see the discussion in this thread:
3182 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3183
b120cc17
JC
31842012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3185
3186 Fix up display of the *Minibuf-0* buffer in the mini window.
3187 * keyboard.c (read_char): Don't clear the echo area if there's no
3188 message to clear.
3189 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3190 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3191
9a4b36f8
MA
31922012-05-07 Michael Albinus <michael.albinus@gmx.de>
3193
3194 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3195 batch mode.
3196
e5f9458f
CY
31972012-05-06 Chong Yidong <cyd@gnu.org>
3198
3199 * lisp.mk (lisp): Update.
3200
eceeb5fc 32012012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3202
3203 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3204
71873e2b
SM
32052012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3206
3207 * data.c (PUT_ERROR): New macro.
3208 (syms_of_data): Use it. Add new error type `user-error'.
3209 * undo.c (user_error): New function.
3210 (Fprimitive_undo): Use it.
3211 * print.c (print_error_message): Adjust print style for `user-error'.
3212 * keyboard.c (user_error): New function.
3213 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3214
ab0fa4e4
PE
32152012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3216
3217 Do not limit current-time-string to years 1000..9999.
3218 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3219 (Fcurrent_time_string): Support any year that is supported by the
3220 underlying localtime representation. Don't use asctime, as it
3221 has undefined behavior for years outside the range -999..9999.
3222
7ed806a7
PE
32232012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3224
3225 Fix race conditions involving setenv, gmtime, localtime, asctime.
3226 Without this fix, interrupts could mess up code that uses these
3227 nonreentrant functions, since setting TZ invalidates existing
3228 tm_zone or tzname values, and since most of these functions return
3229 pointers to static storage.
3230 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3231 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3232 Grow the critical sections to include not just invoking
3233 localtime/gmtime, but also accessing these functions' results
3234 including their tm_zone values if any, and any related TZ setting.
3235 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3236 so that the struct tm is saved in the critical section.
3237 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3238 motivated by the fact that memory allocation needs to be outside
3239 the critical section.
3240
0c16dfed
DA
32412012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3242
3243 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3244 with RESET_INTERVAL.
3245
3246 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3247 Remove duplicated buffer name initialization.
3248
3f83ace8
JM
32492012-05-02 Jim Meyering <jim@meyering.net>
3250
3251 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3252
c7b8541e
JM
3253 * xfns.c (x_window): Use xstrdup (Bug#11375).
3254
90207a15 32552012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3256
3257 * xdisp.c (pos_visible_p): If already at a newline from the
3258 display string before the 'while' loop, don't walk back the glyphs
3259 from it3.glyph_row. Solves assertion violation when the display
3260 string begins with a newline (egg.el). (Bug#11367)
3261
b593d6a9
AH
32622012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3263
3264 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3265 Move to simple.el.
3266
4737362e
GM
32672012-05-01 Glenn Morris <rgm@gnu.org>
3268
99cf43f9
GM
3269 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3270 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3271 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3272 All were removed before 23.1.
3273
9311dcff
GM
3274 * dispnew.c: Remove HAVE_LIBNCURSES test;
3275 it is always true on relevant platforms.
3276
4d5c6349
GM
3277 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3278 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3279
4737362e
GM
3280 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3281
74dd3a6b
AS
32822012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3283
3284 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3285 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3286 Remove.
3287
13c379ee
PE
32882012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3289
3290 Do not avoid creating empty evaporating overlays (Bug#9642).
3291 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3292 That is, do not delete an evaporating overlay if it becomes
3293 empty after its bounds are adjusted to fit within its buffer.
3294 This fix caused other problems, and I'm reverting it until we get
3295 to the bottom of them.
3296
a8e7d6d7 32972012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3298
3299 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3300
a8e7d6d7 33012012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3302
3303 * xdisp.c (pos_visible_p): If the window start position is beyond
3304 ZV, start the display from buffer beginning. Prevents assertion
3305 violation in init_iterator when the minibuffer window is scrolled
3306 via the scroll bar.
3307
3308 * window.c (window_scroll_pixel_based): Likewise.
3309
a8e7d6d7 33102012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3311
3312 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3313
a8e7d6d7 33142012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3315
3316 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3317 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3318
a8e7d6d7 33192012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3320
b593d6a9
AH
3321 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3322 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3323
1c6900d9
EZ
33242012-04-26 Eli Zaretskii <eliz@gnu.org>
3325
4c3fa1d9
EZ
3326 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3327 display element, check also the underlying string or buffer
3328 character. (Bug#11341)
3329
1c6900d9
EZ
3330 * w32menu.c: Include w32heap.h.
3331 (add_menu_item): If the call to AppendMenuW (via
3332 unicode_append_menu) fails, disable Unicode menus only if we are
3333 running on Windows 9X/Me.
3334
42bf8205
AS
33352012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3336
3337 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3338 (xgetint): Add missing shift for LSB tags.
3339
b1bac16e
MR
33402012-04-24 Martin Rudalics <rudalics@gmx.at>
3341
3342 * keyboard.c (read_char): Don't wipe echo area for select window
3343 events: These might get delayed via `mouse-autoselect-window'
3344 (Bug#11304).
3345
d69621cc
JB
33462012-04-24 Juanma Barranquero <lekktu@gmail.com>
3347
3348 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3349 manipulation of :loaded-from data.
3350
02fd101b
JB
33512012-04-23 Juanma Barranquero <lekktu@gmail.com>
3352
3353 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3354 now a cons (bug#11311).
3355
888bec30
PE
33562012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3357
89a438bd
PE
3358 Do not create empty overlays with the evaporate property (Bug#9642).
3359 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3360 if it becomes empty after its bounds are adjusted to fit within
3361 its buffer. Without this fix, in a nonempty buffer (let ((o
3362 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3363 yields an empty overlay that has the evaporate property, which is
3364 not supposed to happen.
3365
1068fe4d
PE
3366 Fix minor GTK3 problems found by static checking.
3367 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3368 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3369 (struct _EmacsFixedClass, emacs_fixed_get_type):
3370 Move decls here from emacsgtkfixed.h, since they needn't be public.
3371 (emacs_fixed_get_type): Now static.
3372 (emacs_fixed_class_init): Omit unused local.
3373 (emacs_fixed_child_type): Remove; unused.
3374 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3375 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3376 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3377 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3378 (EMACS_FIXED_GET_CLASS): Remove; unused.
3379 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3380
888bec30
PE
3381 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3382 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3383
de85e130
PE
33842012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3385
d0baac98 3386 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3387 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3388 (__malloc_size_t, __malloc_ptrdiff_t):
3389 Remove. All uses removed, replaced by the definiens if needed,
3390 since we can assume C89 or better now.
3391 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3392 (protect_malloc_state, align, get_contiguous_space)
3393 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3394 (malloc_atfork_handler_child, malloc_enable_thread)
3395 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3396 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3397 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3398 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3399 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3400 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3401 Define using prototypes, not old style.
3402 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3403 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3404 (align): Don't assume that signed integer overflow wraps around.
3405 Omit unused local var.
3406 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3407 (_free_internal_nolock, memalign, mallochook, reallochook):
3408 Omit no-longer-needed casts.
3409 (valloc): Use getpagesize, not __getpagesize.
3410 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3411 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3412
de85e130
PE
3413 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3414
dcbf5805
MA
34152012-04-22 Michael Albinus <michael.albinus@gmx.de>
3416
3417 Move functions from C to Lisp. Make non-blocking method calls
3418 the default. Implement further D-Bus standard interfaces.
3419
3420 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3421 (QCdbus_request_name_allow_replacement)
3422 (QCdbus_request_name_replace_existing)
3423 (QCdbus_request_name_do_not_queue)
3424 (QCdbus_request_name_reply_primary_owner)
3425 (QCdbus_request_name_reply_in_queue)
3426 (QCdbus_request_name_reply_exists)
3427 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3428 (QCdbus_registered_serial, QCdbus_registered_method)
3429 (QCdbus_registered_signal): New Lisp objects.
3430 (XD_DEBUG_MESSAGE): Use sizeof.
3431 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3432 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3433 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3434 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3435 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3436 (xd_signature, xd_append_arg): Allow float for integer types.
3437 (xd_get_connection_references): New function.
b593d6a9
AH
3438 (xd_get_connection_address): Rename from xd_initialize.
3439 Return cached address.
dcbf5805
MA
3440 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3441 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3442 level.
3443 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3444 Return number of refcounts.
dcbf5805
MA
3445 (Fdbus_get_unique_name): Make stronger parameter check.
3446 (Fdbus_message_internal): New defun.
3447 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3448 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3449 (Fdbus_send_signal, Fdbus_register_service)
3450 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3451 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3452 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3453 (Vdbus_compiled_version, Vdbus_runtime_version)
3454 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3455 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3456 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3457 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3458 Adapt docstring.
dcbf5805 3459
52828e02
PE
34602012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3461
da05bc4c
PE
3462 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3463 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3464 Do not assume ptrdiff_t is the same width as 'int'.
3465
52828e02
PE
3466 * alloc.c: Handle unusual debugging option combinations.
3467 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3468 since the two debugging options are incompatible.
3469 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3470 is defined.
3471 (mem_init, mem_insert, mem_insert_fixup):
3472 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3473 (NEED_MEM_INSERT): Remove; no longer needed.
3474
f01769f9
LL
34752012-04-22 Leo Liu <sdl.web@gmail.com>
3476
3477 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3478
5790543d
PE
34792012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3480
3481 * sysdep.c [__FreeBSD__]: Minor cleanups.
3482 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3483 Use Emacs indenting style more consistently. Avoid some casts.
3484 Use 'double' consistently rather than mixing 'float' and 'double'.
3485
b91b7e4d
EW
34862012-04-21 Eduard Wiebe <usenet@pusto.de>
3487
b593d6a9
AH
3488 * sysdep.c (list_system_processes, system_process_attributes):
3489 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3490
6114eb15
AS
34912012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3492
3493 * lisp.mk (lisp): Update.
3494
2f38dff7
PE
34952012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3496
3497 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3498 It is never used otherwise.
3499
4ae29f89
SM
35002012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3501
3502 * print.c (print_preprocess): Only check print_depth if print-circle
3503 is nil.
3504 (print_object): Check for cycles even when print-circle is nil and
3505 print-gensym is t, but only check print_depth if print-circle is nil.
3506
f30d612a
CY
35072012-04-20 Chong Yidong <cyd@gnu.org>
3508
3509 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3510 set the status to "failed" and ensure that sentinel is run.
3511
c07a4c0b 35122012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3513
3514 * process.c (Fset_process_inherit_coding_system_flag)
3515 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3516 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3517
c07a4c0b 35182012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3519
3520 * xdisp.c (string_buffer_position_lim): Limit starting position to
3521 BEGV.
3522 (set_cursor_from_row): If called for a mode-line or header-line
3523 row, return zero immediately.
3524 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3525 farther than the first row after the header line, if any.
3526 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3527 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3528
c07a4c0b 35292012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3530
4ae29f89
SM
3531 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3532 (bug#11238).
ad3a2b41 3533
c07a4c0b 35342012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 35352012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3536
3537 configure: new option --enable-gcc-warnings (Bug#11207)
3538 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3539 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3540 (ALL_CFLAGS): Use new macros rather than old.
3541 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3542 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3543 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3544 -Wunused-result, -Wunused-variable. This should go away once
3545 the Emacs and Gnulib regex code is merged.
3546 (xmalloc, xrealloc): Now static.
3547
aba027e8
PE
35482012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3549
3550 * dired.c (Fsystem_groups): Remove unused local.
3551
e5a36063
GM
35522012-04-17 Glenn Morris <rgm@gnu.org>
3553
3554 * dired.c (Fsystem_users): Doc fix.
3555
316411f0
DA
35562012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3557
3558 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3559 (syms_of_dired): Add them.
3560
9426aba4
PE
35612012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3562
b62a57be
PE
3563 Fix minor alloc.c problems found by static checking.
3564 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3565 New extern decls, to avoid calling undeclared functions.
3566 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3567 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3568 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3569 (NEED_MEM_INSERT): New macro.
3570 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3571 Remove one incorrect comment and fix another.
b62a57be 3572
3539f31f
PE
3573 Fix minor ralloc.c problems found by static checking.
3574 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3575 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3576 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3577 (r_alloc_sbrk): Now static.
3578
a041960a
PE
3579 Improve ralloc.c interface checking.
3580 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3581 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3582 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3583 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3584 [REL_ALLOC]: ... to here, to check interface.
3585 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3586 Remove decls. This fixes an "It stinks!".
3587
9426aba4
PE
3588 * alloc.c (which_symbols): Fix alignment issue / type clash.
3589
d55c12ed
AS
35902012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3591
3592 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3593 (struct Lisp_Misc_Any): Likewise.
3594 (struct Lisp_Free): Likewise.
3595 * alloc.c (union aligned_Lisp_Symbol): Define.
3596 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3597 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3598 (union aligned_Lisp_Misc): Define.
3599 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3600 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3601 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3602
b948ce8b
PE
36032012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3604
3605 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3606 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3607 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3608 * s/netbsd.h, s/sol2-6.h:
3609 Remove definition of GC_MARK_STACK, since the default now works.
3610 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3611 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3612 no longer the default.
3613 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3614
35dc09a1 36152012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3616
35dc09a1
GM
3617 * lread.c (lisp_file_lexically_bound_p):
3618 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3619
35dc09a1
GM
36202012-04-14 Eli Zaretskii <eliz@gnu.org>
3621
3622 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3623 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3624
36252012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3626
3627 * nsterm.m (constrainFrameRect): Always constrain when there is only
3628 one screen (Bug#10962).
3629
bcd86815
KB
36302012-04-13 Ken Brown <kbrown@cornell.edu>
3631
3632 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3633
c25df26e
RT
36342012-04-13 Reuben Thomas <rrt@sc3d.org>
3635
3636 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3637
0fc59f1e
DC
36382012-04-11 Daniel Colascione <dancol@dancol.org>
3639
3640 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3641 against is gone. It's better to use vfork now so that when Cygwin
3642 gains a new, working vfork, we use it automatically (bug#10398).
3643
de8c03dc
SM
36442012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3645
3646 * window.c (save_window_save): Obey window-point-insertion-type.
3647
2f097256
GM
36482012-04-11 Glenn Morris <rgm@gnu.org>
3649
3650 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3651
453b951e
SM
36522012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3653
3654 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3655
75f1671a 36562012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3657
3658 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3659 (force_quit_count): New var.
3660 (handle_interrupt): Use it.
3661
2a8ce227
JB
36622012-04-10 Juanma Barranquero <lekktu@gmail.com>
3663
3664 * w32.c (w32_delayed_load): Record the full path of the library
3665 being loaded (bug#10424).
3666
935396c0
GM
36672012-04-09 Glenn Morris <rgm@gnu.org>
3668
05920a43
GM
3669 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3670 not just in the obarray, before snarfing them. (Bug#11036)
3671
935396c0
GM
3672 * Makefile.in ($(leimdir)/leim-list.el):
3673 Pass EMACS rather than BUILT_EMACS.
3674
a18ecafa
TZ
36752012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3676
3677 * process.c (make_process):
3678 * process.h: Add integer `gnutls_handshakes_tried' member to
3679 process struct.
3680
6bbef4e5
JC
3681 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3682 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3683
3684 * gnutls.c (gnutls_log_function2i): Convenience log function.
3685 (emacs_gnutls_read): Use new log functions,
3686 `gnutls_handshakes_tried' process member, and
3687 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3688 attempts per process (connection).
3689
b4d3bc10
CY
36902012-04-09 Chong Yidong <cyd@gnu.org>
3691
3692 * eval.c (Fuser_variable_p, user_variable_p_eh)
3693 (lisp_indirect_variable): Functions deleted.
3694 (Fdefvar): Caller changed.
3695
3696 * callint.c (Finteractive, Fcall_interactively):
3697 * minibuf.c (Fread_variable): Callers changed.
3698
70f4d973
EZ
36992012-04-09 Eli Zaretskii <eliz@gnu.org>
3700
3701 * xdisp.c (set_cursor_from_row): If the display string appears in
3702 the buffer at position that is closer to point than the position
3703 after the display string, display the cursor on the first glyph of
3704 the display string. Fixes cursor display when a 'display' text
3705 property immediately follows invisible text. (Bug#11094)
3706
cb3c2e3e
PE
37072012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3708
3709 composite.c: use 'double' consistently
3710 * composite.c (get_composition_id): Use 'double' consistently
3711 instead of converting 'float' to 'double' and vice versa; this is
3712 easier to understand and avoids a GCC warning.
3713
fd06db5d
GM
37142012-04-09 Glenn Morris <rgm@gnu.org>
3715
50fe702a
GM
3716 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3717 preparation for dumping it with emacs. (Bug#4789)
3718 (leimdir): New variable.
3719 ($(leimdir)/leim-list.el): New rule.
3720 (emacs$(EXEEXT)): Depend on leim-list.el.
3721
fd06db5d
GM
3722 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3723 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3724 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3725
55c131ee
AS
37262012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3727
3728 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3729 proper alignment.
3730
9209588f
JB
37312012-04-07 Juanma Barranquero <lekktu@gmail.com>
3732
3733 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3734 Remove unused local variable.
3735
e3fb2efb
PE
37362012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3737
3738 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3739 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3740 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3741 objects, as mark_maybe_pointer will catch them otherwise.
3742 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3743 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3744
b5385551
PE
37452012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3746
3747 Fix typo that broke non-Windows builds.
3748 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3749
9078ead6
EZ
37502012-04-07 Eli Zaretskii <eliz@gnu.org>
3751
3752 Support building on MS-Windows with libxml2.
3753
3754 * makefile.w32-in (OBJ2): Add xml.$(O).
3755 (GLOBAL_SOURCES): Add xml.c.
3756 ($(BLD)/xml.$(O)): New dependency list.
3757
3758 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3759 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3760 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3761 [!WINDOWSNT]: New macros.
3762 (init_libxml2_functions, libxml2_loaded_p): New functions.
3763 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3764 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3765 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3766 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3767 linked in).
6bbef4e5
JC
3768 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3769 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3770 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3771
3772 * emacs.c: Don't include libxml/parser.h.
3773 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3774 xmlCleanupParser directly.
3775
3776 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3777
3811fdf3
EZ
37782012-04-07 Eli Zaretskii <eliz@gnu.org>
3779
3780 * indent.c (Fvertical_motion): If there is a display string at
3781 point, use it.vpos to compute how many lines to backtrack after
3782 move_it_to point. (Bug#11133)
3783
2f8e16b2
EZ
37842012-04-06 Eli Zaretskii <eliz@gnu.org>
3785
3786 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3787 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3788 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3789 macros related to unification of CJK characters. For the details,
3790 see the discussion following the message here:
3791 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3792
3d439cd1
CY
37932012-04-04 Chong Yidong <cyd@gnu.org>
3794
3795 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3796
8bc53d00
EZ
37972012-04-01 Eli Zaretskii <eliz@gnu.org>
3798
3799 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3800 instead of alloca. (Bug#11138)
3801
3b0512a3
AS
38022012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3803
3804 * w32menu.c (is_simple_dialog): Properly check lisp types.
3805 (Bug#11141)
3806
8427ddd2
EZ
38072012-03-31 Eli Zaretskii <eliz@gnu.org>
3808
979022ef
EZ
3809 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3810 position we get to after a call to move_it_to fails the
3811 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3812 only if we wind up in a string from display property. (Bug#11063)
3813
a6b1c7cc
EZ
3814 * window.c (Fdelete_other_windows_internal): Invalidate the row
3815 and column information about mouse highlight, so that redisplay
3816 restores it after reallocating the glyph matrices. (Bug#7464)
3817
8427ddd2
EZ
3818 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3819 string comes from a `display' text property, use the buffer
3820 position of that property as if we actually saw that position in
3821 the row's glyphs.
697ba24b
EZ
3822 (move_it_by_lines): Remove the assertion that
3823 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3824 violated when there's a before-string at the beginning of a line.
3825 (Bug#11063)
8427ddd2 3826
65a0a738
EZ
38272012-03-30 Eli Zaretskii <eliz@gnu.org>
3828
3829 * xdisp.c (append_space_for_newline): If the default face was
3830 remapped, use the remapped face for the appended newline.
3831 (extend_face_to_end_of_line): Use the remapped default face for
3832 extending the face to the end of the line.
3833 (display_line): Call extend_face_to_end_of_line when the default
3834 face was remapped. (Bug#11068)
3835
581355cc
EZ
38362012-03-29 Eli Zaretskii <eliz@gnu.org>
3837
3838 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3839
e8fc049f
SM
38402012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3841
3842 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3843
4fb9a543
GM
38442012-03-27 Glenn Morris <rgm@gnu.org>
3845
3846 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3847 Doc fixes.
3848
679910f1
KH
38492012-03-26 Kenichi Handa <handa@m17n.org>
3850
3851 * dispextern.h (struct glyph): Fix previous change. Change the
3852 bit length of glyphless.ch to 25 (Bug#11082).
3853
90d49b7f
CY
38542012-03-26 Chong Yidong <cyd@gnu.org>
3855
3856 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3857 (command_loop_1): Use it; inhibit selection update for
3858 handle-select-window too (Bug#8996).
3859
f514f6f0
FP
38602012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3861
e8fc049f 3862 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3863
bf43fa51
KH
38642012-03-25 Kenichi Handa <handa@m17n.org>
3865
3866 * dispextern.h (struct glyph): Change the bit length of
3867 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3868
8a0c01dd
EZ
38692012-03-24 Eli Zaretskii <eliz@gnu.org>
3870
3871 * s/ms-w32.h (tzname): Include time.h before redirecting to
3872 _tzname. Fixes the MSVC build. (Bug#9960)
3873
7d1c3a76
AS
38742012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3875
8ed79523
AS
3876 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3877 characters.
3878
7d1c3a76
AS
3879 * xterm.c (XTread_socket): Only modify handling_signal if
3880 !SYNC_INPUT. (Bug#11080)
3881
e99a9b8b
EZ
38822012-03-23 Eli Zaretskii <eliz@gnu.org>
3883
3884 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3885 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3886 when fetching a multibyte character consumes more bytes than
3887 CHAR_BYTES returns, due to unification of CJK characters in
3888 string_char. (Bug#11073)
3889
5063c0e1
TN
38902012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3891
3892 * process.c (wait_reading_process_output): Handle pty disconnect
3893 by refraining from sending oneself a SIGCHLD (bug#10933).
3894
9f851fbd
CY
38952012-03-22 Chong Yidong <cyd@gnu.org>
3896
3897 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3898
5063c0e1 3899 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3900 Mark string as coming from a prefix property.
3901 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3902 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3903
fb5b8aca
CY
39042012-03-21 Chong Yidong <cyd@gnu.org>
3905
3906 * xfaces.c (Vface_remapping_alist): Doc fix.
3907
62356a1b
EZ
39082012-03-20 Eli Zaretskii <eliz@gnu.org>
3909
3910 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3911 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3912 Doc fixes.
62356a1b 3913
025de85b
CY
39142012-03-20 Chong Yidong <cyd@gnu.org>
3915
3916 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3917 to reflect default non-nil value of redisplay-dont-pause.
3918
4827f94e
KH
39192012-03-19 Kenichi Handa <handa@m17n.org>
3920
3921 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3922 it fit in a valid range (Bug#11003).
3923
e50a24a2
EZ
39242012-03-18 Eli Zaretskii <eliz@gnu.org>
3925
3926 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3927 that is not from display property, accept the row as a "cursor
3928 row" if one of the string's character has a non-nil `cursor'
3929 property. Fixes cursor positioning when there are newlines in
3930 overlay strings, e.g. in icomplete.el. (Bug#11035)
3931
9af5ed87
PE
39322012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3933
3934 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3935
d1f55f16
CY
39362012-03-12 Chong Yidong <cyd@gnu.org>
3937
3938 * eval.c (inhibit_lisp_code): Rename from
3939 inhibit_window_configuration_change_hook; move from window.c.
3940
3941 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3942 * window.c (run_window_configuration_change_hook)
3943 (syms_of_window): Callers changed.
3944
66c5eebd
CY
39452012-03-11 Chong Yidong <cyd@gnu.org>
3946
413df973
CY
3947 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3948
66c5eebd
CY
3949 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3950
1de11f56
CY
39512012-03-10 Chong Yidong <cyd@gnu.org>
3952
3953 * frame.c (other_visible_frames): Don't assume the selected frame
3954 is visible (Bug#10955).
3955
cae07000
SM
39562012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3957
3958 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3959
89c94350
JD
39602012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3961
3962 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3963 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3964 zero (Bug#10954).
3965
999dd333
GM
39662012-03-03 Glenn Morris <rgm@gnu.org>
3967
01a6dcc8 3968 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3969
de0100f2
EZ
39702012-03-02 Eli Zaretskii <eliz@gnu.org>
3971
3972 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3973 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3974 (redisplay_window, next_element_from_string): Fix typos in
3975 comments.
3e441275
EZ
3976 (redisplay_window): Pass to move_it_vertically the margin in
3977 pixels, not in screen lines.
de0100f2 3978
96a72ee9
GM
39792012-03-02 Glenn Morris <rgm@gnu.org>
3980
3981 * buffer.c (buffer-list-update-hook): Doc fix.
3982
312508d7
EZ
39832012-02-29 Eli Zaretskii <eliz@gnu.org>
3984
3985 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3986 push_it before setting up the iterator for the first overlay
3987 string, even if we have an empty string loaded.
3988 (next_overlay_string): If there's an empty string on the iterator
3989 stack, pop the stack. (Bug#10903)
3990
27f3c637
PE
39912012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3992
3993 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3994 Suggested by Stefan Monnier in
3995 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3996 * alloc.c (widen_to_Lisp_Object): New static function.
3997 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3998 and widening them to Lisp_Objects. This would work even if
3999 USE_LSB_TAG is defined and wide integers are used, which might
4000 happen in a future version of Emacs.
4001
3c9dfce6
CY
40022012-02-25 Chong Yidong <cyd@gnu.org>
4003
fa74b241
CY
4004 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4005 Doc fix.
4006
3c9dfce6
CY
4007 * xselect.c (Fx_selection_exists_p): Doc fix.
4008 (x_clipboard_manager_save_all): Print an informative message
4009 before saving to clipboard manager.
4010
9486df08
CY
40112012-02-24 Chong Yidong <cyd@gnu.org>
4012
4013 * keyboard.c (process_special_events): Handle all X selection
4014 requests in kbd_buffer, not just the next one (Bug#8869).
4015
f01d3321
CY
40162012-02-23 Chong Yidong <cyd@gnu.org>
4017
4018 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4019 call when setting menu-bar-lines and tool-bar-lines parameters.
4020 (unwind_create_frame_1): New helper function.
4021
4022 * window.c (inhibit_window_configuration_change_hook): New var.
4023 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4024 (syms_of_window): Initialize it.
f01d3321 4025
86b847b6
CY
40262012-02-22 Chong Yidong <cyd@gnu.org>
4027
4028 * xterm.c (x_draw_image_relief): Add missing type check for
4029 Vtool_bar_button_margin (Bug#10743).
4030
a59225b1
CY
40312012-02-21 Chong Yidong <cyd@gnu.org>
4032
4033 * fileio.c (Vfile_name_handler_alist): Doc fix.
4034
4035 * buffer.c (Fget_file_buffer): Protect against invalid file
4036 handler return value.
4037
310f5bd4
PE
40382012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4039
cb3a28cc
PE
4040 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4041 when computing $valmask.
4042
310f5bd4
PE
4043 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4044 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4045 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4046 It's useless in that case, and it can cause problems on hosts
4047 that allocate halves of EMACS_INT values separately.
4048 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4049 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4050 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4051 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4052 it avoids undefined behavior on hosts where shifting right by more
4053 than the word width has undefined behavior.
4054
2375c96a
CY
40552012-02-19 Chong Yidong <cyd@gnu.org>
4056
4057 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4058 (Funhandled_file_name_directory, Ffile_name_as_directory)
4059 (Fdirectory_file_name, Fexpand_file_name)
4060 (Fsubstitute_in_file_name): Protect against invalid file handler
4061 return values (Bug#10845).
4062
3eb49e71
EZ
40632012-02-18 Eli Zaretskii <eliz@gnu.org>
4064
4065 * .gdbinit (pitx): Fix incorrect references to fields of the
4066 iterator stack.
4067
7b926f3f
CY
40682012-02-17 Chong Yidong <cyd@gnu.org>
4069
4070 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4071
11273115
PE
40722012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4073
4074 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4075 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4076
c3a70e2b
CY
40772012-02-15 Chong Yidong <cyd@gnu.org>
4078
4079 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4080 marked as special. Also, starting docstrings with * is obsolete.
4081
0ca43699
AS
40822012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4083
4084 * gnutls.c (emacs_gnutls_write): Fix last change.
4085
2e8f3c56
LI
40862012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4087
4088 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4089 send_process.
4090
af70074f
SM
40912012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4092
4093 * keymap.c (Fsingle_key_description): Handle char ranges.
4094
95986d52
CY
40952012-02-12 Chong Yidong <cyd@gnu.org>
4096
afd83bd1
CY
4097 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4098 as that creates a dangerous corner case.
4099
95986d52
CY
4100 * window.c (Fdelete_window_internal): Invalidate the mouse
4101 highlight (Bug#9904).
4102
bd7da63e
GM
41032012-02-12 Glenn Morris <rgm@gnu.org>
4104
4105 * xselect.c (Fx_own_selection_internal)
4106 (Fx_get_selection_internal, Fx_disown_selection_internal)
4107 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4108 * nsselect.m (Fx_own_selection_internal)
4109 (Fx_disown_selection_internal, Fx_selection_exists_p)
4110 (Fx_selection_owner_p, Fx_get_selection_internal):
4111 Sync docs and argument specs with the xselect.c versions.
4112
77abcbc2
LI
41132012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4114
4115 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4116
90b671e2
EZ
41172012-02-11 Eli Zaretskii <eliz@gnu.org>
4118
1c0ca0b7
EZ
4119 * w32select.c (Fx_selection_exists_p): Sync doc string and
4120 argument list with xselect.c. (Bug#10783)
4121
4122 * w16select.c (Fx_selection_exists_p): Sync doc string and
4123 argument list with xselect.c. (Bug#10783)
90b671e2 4124
49241268
GM
41252012-02-10 Glenn Morris <rgm@gnu.org>
4126
4127 * fns.c (Fsecure_hash): Doc fix.
4128
f998bbe7 41292012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4130
4131 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4132
0992bd9c
CY
41332012-02-07 Chong Yidong <cyd@gnu.org>
4134
4135 * buffer.c (Fbuffer_local_variables)
4136 (buffer_lisp_local_variables): Handle unbound vars correctly;
4137 don't let Qunbound leak into Lisp.
4138
af008560
GM
41392012-02-07 Glenn Morris <rgm@gnu.org>
4140
dd605cc4
GM
4141 * image.c (Fimagemagick_types): Doc fix.
4142
af008560
GM
4143 * image.c (imagemagick-render-type): Change it from a lisp object
4144 to an integer. Move the doc here from the lisp manual.
4145 Treat all values not equal to 0 the same.
4146
1449fa1d
CY
41472012-02-06 Chong Yidong <cyd@gnu.org>
4148
4149 * doc.c (store_function_docstring): Avoid applying docstring of
4150 alias to base function (Bug#2603).
4151
3723ec07
AS
41522012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4153
4154 * .gdbinit (pp1, pv1): Remove redundant defines.
4155 (pr): Use pp.
4156
79c1cc1e
CY
41572012-02-04 Chong Yidong <cyd@gnu.org>
4158
4159 * nsterm.m: Declare a global (Bug#10694).
4160
d7f29f8e
EZ
41612012-02-04 Eli Zaretskii <eliz@gnu.org>
4162
cae07000
SM
4163 * w32.c (get_emacs_configuration_options):
4164 Include --enable-checking, if specified, in the return value.
d7f29f8e 4165
3b95a6f9
MR
41662012-02-04 Martin Rudalics <rudalics@gmx.at>
4167
4168 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4169 after rounding frame sizes. (Bug#9723)
4170
d6fa96a6
EZ
41712012-02-04 Eli Zaretskii <eliz@gnu.org>
4172
4173 * keyboard.c (adjust_point_for_property): Don't position point
4174 before BEGV. (Bug#10696)
4175
df0b2940
PE
41762012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4177
4178 Handle overflow when computing char display width (Bug#9496).
4179 * character.c (char_width): Return EMACS_INT, not int.
4180 (char_width, c_string_width): Check for overflow when
4181 computing the width; this is possible now that individual
4182 characters can have unbounded width. Problem introduced
4183 by merge from Emacs 23 on 2012-01-19.
4184
6bee44d6
MA
41852012-02-02 Michael Albinus <michael.albinus@gmx.de>
4186
4187 * dbusbind.c (Fdbus_register_method): Mention the return value
4188 :ignore in the docstring.
4189
44f92739
GM
41902012-02-02 Glenn Morris <rgm@gnu.org>
4191
1b9f60cc
GM
4192 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4193
44f92739
GM
4194 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4195 Unconditionally set to t. (Bug#10673)
4196 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4197 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4198 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4199
c5d3843c
KH
42002012-02-02 Kenichi Handa <handa@m17n.org>
4201
4202 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4203 0, do not call append_composite_glyph.
4204
159462d4 42052012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4206
4207 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4208 NULL (Bug#6988).
4209 (x_produce_glyphs): If the component of a composition is a null
4210 string, set it->pixel_width to 1 to avoid zero-width glyph.
4211
78cef877
EZ
42122012-02-01 Eli Zaretskii <eliz@gnu.org>
4213
4214 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4215 first 2 arguments are identical. This makes inserting large
4216 output from a subprocess an order of magnitude faster on
4217 MS-Windows, where all sbrk'ed memory is always contiguous.
4218
97897668
GM
42192012-01-31 Glenn Morris <rgm@gnu.org>
4220
4221 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4222 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4223 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4224
31fd3586
GM
42252012-01-29 Glenn Morris <rgm@gnu.org>
4226
4227 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4228
0e24a8b2
CY
42292012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4230
4231 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4232
cc0adcb0
CY
42332012-01-28 Chong Yidong <cyd@gnu.org>
4234
4235 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4236
acc28cb9
CY
42372012-01-26 Chong Yidong <cyd@gnu.org>
4238
9c69cfb7
CY
4239 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4240
acc28cb9
CY
4241 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4242 repeat counts (Bug#10507).
4243
48da7392
GM
42442012-01-26 Glenn Morris <rgm@gnu.org>
4245
4246 * lread.c (syms_of_lread): Doc fix.
4247
14af5f7f
CY
42482012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4249
4250 * coding.c (encode_designation_at_bol): Change return value to
4251 EMACS_INT.
4252
0b21c100
CY
42532012-01-25 Chong Yidong <cyd@gnu.org>
4254
4255 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4256
3c2907f7
CY
42572012-01-21 Chong Yidong <cyd@gnu.org>
4258
4259 * floatfns.c (Fcopysign): Make the second argument non-optional,
4260 since nil is not allowed anyway.
4261
959ad23f
AS
42622012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4263
4264 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4265 (send_process): Likewise.
4266
34a02f46
MR
42672012-01-19 Martin Rudalics <rudalics@gmx.at>
4268
4269 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4270 (Vwindow_persistent_parameters): Do not use Qstate.
4271 Rewrite doc-strings.
34a02f46 4272
1259009a 42732012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4274
4275 * character.c (char_width): New function.
70d4fdf6
GM
4276 (Fchar_width, c_string_width, lisp_string_width):
4277 Use char_width (Bug#9496).
25ed9e61 4278
6a6ee00d
MR
42792012-01-16 Martin Rudalics <rudalics@gmx.at>
4280
4281 * window.c (Vwindow_persistent_parameters): New variable.
4282 (Fset_window_configuration, save_window_save): Handle persistent
4283 window parameters.
4284
c85efaf7
EZ
42852012-01-14 Eli Zaretskii <eliz@gnu.org>
4286
4287 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4288 thrashing the stack of the thread. (Bug#9087)
4289
5944709e
PE
42902012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4291
4292 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4293
e71f5d99
EZ
42942012-01-11 Eli Zaretskii <eliz@gnu.org>
4295
4296 * xdisp.c (rows_from_pos_range): Handle the case where the
4297 highlight ends on a newline. (Bug#10464)
4298 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4299 he end column for display of highlight that ends on a newline
4300 before a R2L line.
4301
ce316182
GM
43022012-01-11 Glenn Morris <rgm@gnu.org>
4303
4304 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4305 from load-path also when installation-directory is nil. (Bug#10208)
4306
5b43da69
GM
43072012-01-10 Glenn Morris <rgm@gnu.org>
4308
74cc8ff9
GM
4309 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4310
7d8d6e4e
GM
4311 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4312 Update template values to be closer to their typical values these days.
5b43da69 4313
a0db8d43
EZ
43142012-01-09 Eli Zaretskii <eliz@gnu.org>
4315
4316 * xdisp.c (rows_from_pos_range): Accept additional argument
4317 DISP_STRING, and accept any glyph in a row whose object is that
4318 string as eligible for mouse highlight. Fixes mouse highlight of
4319 display strings from overlays. (Bug#10464)
4320
9a0115ab 43212012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4322
b9110d6a 4323 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4324 * fileio.c (auto_saving_dir_umask): New static var.
4325 (Fmake_directory_internal): Use it.
4326 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4327 creating the directory. The old code temporarily assigns
4328 too-generous permissions to the directory.
4329 (do_auto_save_eh): Clear it.
b9110d6a 4330 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4331 that the var is always cleared.
4332
6c1bd3f3
EZ
43332012-01-07 Eli Zaretskii <eliz@gnu.org>
4334
4335 * search.c (scan_buffer): Pass character positions to
4336 know_region_cache, not byte positions. (Bug#6540)
4337
069d2b50
L
43382012-01-07 LynX <_LynX@bk.ru> (tiny change)
4339
4340 * w32.c (sys_rename): Report EXDEV when rename of a directory
4341 fails because the target is on another logical disk. (Bug#10284)
4342
75bf0d33
DB
43432012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4344
4345 * xterm.c (x_embed_request_focus): New function.
4346
4347 * xterm.h: Add prototype.
4348
4349 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4350
1c6e5a32
GM
43512012-01-05 Glenn Morris <rgm@gnu.org>
4352
4353 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4354
651e947e
EZ
43552012-01-01 Eli Zaretskii <eliz@gnu.org>
4356
4357 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4358 Load gnutls_transport_set_lowat only if GnuTLS version is below
4359 2.11.1.
4360 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4361 GnuTLS versions below 2.11.1.
4362
3778cdd8
AL
43632011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4364
4365 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4366 to the doc string advising against its use for altering the way
4367 windows are scrolled.
4368
0e5317f7
KH
43692011-12-28 Kenichi Handa <handa@m17n.org>
4370
4371 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4372 coding-system ASCII compatible only when it does not produce BOM
4373 on encoding (Bug#10383).
4374
93d5ca1f
JD
43752011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4376
4377 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4378 can scroll.
4379 (create_and_show_popup_menu): Always use menu_position_func for
4380 Gtk3 (Bug#10361).
4381
ca22b785
AS
43822011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4383
4384 * callint.c (Fcall_interactively): Don't truncate prompt string.
4385
d048e1e6
EZ
43862011-12-23 Eli Zaretskii <eliz@gnu.org>
4387
4388 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4389 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4390 resumed from there (after widening). (Bug#10360)
d048e1e6 4391
5ccaba1f
JD
43922011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4393
4394 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4395
204ee57f
JD
43962011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4397
b81d40f0
JB
4398 * nsterm.m (x_free_frame_resources):
4399 Release f->output_data.ns->miniimage.
204ee57f
JD
4400 (ns_index_color): Fix indentation. Do not retain
4401 color_table->colors[i].
4402
4403 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4404 before returning.
4405
4406 * nsfns.m (x_set_background_color): Assign return value from
4407 ns_index_color to face-background instead of NSColor*.
4408 (ns_implicitly_set_icon_type): Fix indentation.
4409 Change assignment in for loop to comparison.
4410
4411 * emacs.c (ns_pool): New variable.
4412 (main): Assign ns_pool.
4413 (Fkill_emacs): Call ns_release_autorelease_pool.
4414
4415 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4416 autorelease fdesc, release fdAttrs and tdict.
4417 (ns_get_covering_families): Release charset.
4418 (ns_findfonts): Release NSFontDescriptor created with new.
4419 (ns_uni_to_glyphs): Fix indentation.
4420 (setString): Release attrStr before assigning new value.
4421
c803b2b7
JD
44222011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4423
678f4426
JD
4424 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4425 and NS_IMPL_COCOA.
4426 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4427 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4428
cd394be1 44292011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4430
5fecd5fc
JD
4431 * nsterm.m (ns_term_init): Subscribe for notifications
4432 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4433 to method trackingNotification in EmacsMenu.
4434
4435 * nsmenu.m (trackingMenu): New variable.
3771cb17 4436 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4437 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4438 from Aquamacs (Bug#7030).
678f4426
JD
4439
44402011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4441
c803b2b7
JD
4442 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4443 (symbol_to_nsstring): Fix indentation.
4444 (ns_symbol_to_pb): New function.
cae07000
SM
4445 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4446 (Fns_rotate_cut_buffers_internal): Remove.
4447 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4448 Fns_store_cut_buffer_internal.
4449 (ns_get_foreign_selection, Fx_own_selection_internal)
4450 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4451 (Fns_get_selection_internal, Fns_store_selection_internal):
4452 Use ns_symbol_to_pb and check if return value is nil.
4453 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4454 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4455 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4456 renamed to Sns_store_selection_internal.
4457 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4458 and remove this function.
4459 (ns_handle_selection_clear): Remove, never used.
4460 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4461 here.
4462
e1b01a3a
KB
44632011-12-17 Ken Brown <kbrown@cornell.edu>
4464
4465 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4466 GID is unknown (Bug#10257).
4467
2adb6e85
PE
44682011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4469
4470 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4471 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4472 which caused a build failure on GNU/Linux IA-64. This problem was
4473 introduced by my 2011-10-07 patch.
4474
d1d7b339
JL
44752011-12-15 Juri Linkov <juri@jurta.org>
4476
4477 * image.c (imagemagick_error): New function. (Bug#10112)
4478 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4479 Use `imagemagick_error' where ImageMagick functions return
4480 `MagickFalse'.
4481 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4482 proper order.
4483
100d5755
KH
44842011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4485
4486 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4487 fill background (Bug#8992).
4488
454592a6
MR
44892011-12-13 Martin Rudalics <rudalics@gmx.at>
4490
4491 * window.c (Vwindow_combination_resize)
4492 (Vwindow_combination_limit): Use t instead of non-nil in
4493 doc-strings.
61d4b438
MR
4494 (Vrecenter_redisplay): Add first sentence of doc-string on
4495 separate line.
53524d93 4496 (Frecenter): Fix doc-string typo.
454592a6 4497
3633e3aa
KH
44982011-12-11 Kenichi Handa <handa@m17n.org>
4499
4500 * coding.c (Funencodable_char_position): Pay attention to the
4501 buffer text relocation (Bug#9389).
4502
7b9d523a 45032011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4504
7b9d523a
JD
4505 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4506 gtk_init (Bug#10100).
4507
b73189c6
EZ
45082011-12-10 Eli Zaretskii <eliz@gnu.org>
4509
4510 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4511 IT->string is nil. (Bug#10263)
4512
f7dfe5d6
JD
45132011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4514
83faebb4
JD
4515 * nsterm.h (x_free_frame_resources): Declare.
4516
f7dfe5d6
JD
4517 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4518 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4519
4520 * nsterm.h (ns_get_defaults_value): Declare.
4521
4522 * nsterm.m (ns_default): Call ns_get_defaults_value.
4523
7cd4e72c
EZ
45242011-12-09 Eli Zaretskii <eliz@gnu.org>
4525
4526 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4527 (Bug#10170)
4528
b34d7317
YM
45292011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4530
4531 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4532 that where the value of an _OBJC_* symbol points to is in the .bss
4533 section (Bug#10240).
4534
76470ad1
KH
45352011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4536
4537 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4538 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4539
745fff94
KH
45402011-12-08 Kenichi Handa <handa@m17n.org>
4541
4542 * ftfont.c (get_adstyle_property): Fix previous change
4543 (Bug#10233).
4544
6e44397c
JB
45452011-12-07 Juanma Barranquero <lekktu@gmail.com>
4546
4547 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4548 dirs from the default value of EMACSLOADPATH (bug#10208).
4549
7efa6272
GM
45502011-12-07 Glenn Morris <rgm@gnu.org>
4551
4552 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4553 installation and source directories as well. (Bug#10208)
4554
f6fc4d87
CY
45552011-12-06 Chong Yidong <cyd@gnu.org>
4556
4557 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4558
2bf26180
GM
45592011-12-06 Glenn Morris <rgm@gnu.org>
4560
4561 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4562 as an error, not just -1. (Bug#10217)
4563
3a6ad4f0
CY
45642011-12-05 Chong Yidong <cyd@gnu.org>
4565
4566 * keyboard.c (process_special_events): New function.
4567 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4568
75a3b399
PE
45692011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4570
4571 * coding.c (encode_designation_at_bol): Don't use uninitialized
4572 local variable (Bug#9318).
4573
c3c9e25e
KH
45742011-12-05 Kenichi Handa <handa@m17n.org>
4575
4576 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4577 return Qnil (Bug#8046, Bug#10193).
4578
5eb05ea3
KH
45792011-12-05 Kenichi Handa <handa@m17n.org>
4580
4581 * coding.c (encode_designation_at_bol): New args charbuf_end and
4582 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4583 (coding_set_source): Return how many bytes coding->source was
4584 relocated.
4585 (coding_set_destination): Return how many bytes
4586 coding->destination was relocated.
4587 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4588 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4589
45902011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4591
4592 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4593 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4594 macro (Bug#9318).
4595
45962011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4597
4598 The following changes are to fix Bug#9318.
4599
a79703f5 4600 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4601 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4602 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4603 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4604
7dbda6df
JB
46052011-12-05 Juanma Barranquero <lekktu@gmail.com>
4606
4607 * lisp.h (process_quit_flag): Fix external declaration.
4608
6d5eb5b0
SM
46092011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4610
4611 Don't macro-inline non-performance-critical code.
4612 * eval.c (process_quit_flag): New function.
4613 * lisp.h (QUIT): Use it.
4614
a0c3fad0
JD
46152011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4616
4617 * nsfns.m (get_geometry_from_preferences): New function.
4618 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4619
6c07aac2
AS
46202011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4621
4622 * emacs.c (Qkill_emacs): Define.
4623 (syms_of_emacs): Initialize it.
4624 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4625 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4626 (quit_throw_to_read_char): Add parameter `from_signal'.
4627 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4628 * lisp.h (QUIT): Call Fkill_emacs if requested.
4629
c052ead4
JD
46302011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4631
4632 * widget.c (update_wm_hints): Return if wmshell is null.
4633 (widget_update_wm_size_hints): New function.
4634
4635 * widget.h (widget_update_wm_size_hints): Declare.
4636
4637 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4638 widget_update_wm_size_hints (Bug#10104).
4639
9e49252b
EZ
46402011-12-03 Eli Zaretskii <eliz@gnu.org>
4641
4642 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4643 before a newline, prepare the bidi iterator for consuming the
4644 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4645 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4646
02b16839
JL
46472011-12-02 Juri Linkov <juri@jurta.org>
4648
4649 * search.c (Fword_search_regexp): New Lisp function created from
4650 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4651 (Fword_search_backward, Fword_search_forward)
4652 (Fword_search_backward_lax, Fword_search_forward_lax):
4653 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4654 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4655
0068070e
SM
46562011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4657
4658 * fileio.c (Finsert_file_contents): Move after-change-function call
4659 to before the "handled:" label, since all "goto handled" appear in
4660 cases where the *-change-functions have already been properly called
4661 (bug#10117).
4662
3360a3fc
AS
46632011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4664
4665 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4666 waiting for input. (Bug#10169)
4667
73d6c093
EZ
46682011-11-30 Eli Zaretskii <eliz@gnu.org>
4669
4670 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4671 verifies glyph row's hash code--we have just reallocated the
4672 glyphs, so their contents can be complete garbage. (Bug#10164)
4673
febe6bea
JB
46742011-11-30 Juanma Barranquero <lekktu@gmail.com>
4675
4676 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4677
801a4313
EZ
46782011-11-30 Eli Zaretskii <eliz@gnu.org>
4679
4680 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4681 attributes are tested _before_ calling verify_row_hash, to protect
4682 against GCC re-ordering of the tests. (Bug#10164)
4683
2b56b87e
JD
46842011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4685
4686 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4687
4688 * xterm.c (handle_one_xevent): Only set async_visible and friends
4689 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4690 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4691 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4692
dbf31225
PE
46932011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4694
4695 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4696 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4697 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4698 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4699 All uses changed to use GCPRO1 etc.
4700 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4701 Revert to old implementation (i.e., before 2011-03-11).
4702
1305621b
YM
47032011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4704
4705 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4706 of scroll runs so as to avoid assigning disabled bogus rows and
4707 unnecessary graphics copy operations.
4708
8c9afb46
EZ
47092011-11-27 Eli Zaretskii <eliz@gnu.org>
4710
4711 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4712 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4713 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4714 (malloc, free, realloc, calloc): Redirect to e_* only when
4715 compiling Emacs.
4716
4717 * lisp.h (GCTYPEBITS): Move before first use.
4718 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4719 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4720 this macro definition.
4721
4722 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4723 _MSC_VER.
4724
54e9e3bf
JD
47252011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4726
6d5eb5b0
SM
4727 * gtkutil.c (xg_create_frame_widgets):
4728 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4729 present with Gtk+ 2.0.
4730
83aca1cb
PE
47312011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4732
4733 * fileio.c (Finsert_file_contents): Undo previous change; see
4734 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4735
5b76caa4
PE
47362011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4737
4738 Rename locals to avoid shadowing.
4739 * fileio.c (Finsert_file_contents):
4740 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4741 * process.c (wait_reading_process_output):
4742 Rename inner 'proc' to 'p' to avoid shadowing.
4743 Indent for consistency with usual Emacs style.
4744
8c535114
EZ
47452011-11-25 Eli Zaretskii <eliz@gnu.org>
4746
4747 * xdisp.c (redisplay_window): If cursor row is not fully visible
4748 after recentering, and scroll-conservatively is set to a large
4749 number, scroll window by a few more lines to make the cursor fully
4750 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4751 (start_display): Don't move to the next line if the display should
4752 start at a newline that is part of a display vector or an overlay
4753 string. (Bug#10119)
8c535114 4754
fa4fdb5c
JL
47552011-11-24 Juri Linkov <juri@jurta.org>
4756
4757 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4758 after the `MagickPingImage' call. (Bug#10112)
4759
90ec88df
CY
47602011-11-23 Chong Yidong <cyd@gnu.org>
4761
4762 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4763
56e2e794
MR
47642011-11-23 Martin Rudalics <rudalics@gmx.at>
4765
4766 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4767 making another buffer current. (Bug#10114)
4768
b6e64c41
GM
47692011-11-23 Glenn Morris <rgm@gnu.org>
4770
4771 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4772
6b21de18
CY
47732011-11-23 Chong Yidong <cyd@gnu.org>
4774
4775 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4776 using it (Bug#5984).
4777
b12cd789
EZ
47782011-11-22 Eli Zaretskii <eliz@gnu.org>
4779
4780 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4781 and header-lines, as they don't have one computed for them.
4782 (Bug#10098)
4783
4784 * .gdbinit (prow): Make displayed values more self-explaining.
4785 Add row's hash code.
4786
261b6fd4
LMI
47872011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4788
4789 * process.c (wait_reading_process_output): Fix asynchrounous
4790 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4791 (wait_reading_process_output): Add comment and URL.
261b6fd4 4792
e7cfd277
JD
47932011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4794
4795 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4796
a9b9b7f5
CY
47972011-11-21 Chong Yidong <cyd@gnu.org>
4798
4799 * window.c (Fnext_window, Fprevious_window): Doc fix.
4800
b0d15b4f
SM
48012011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4802
4803 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4804
fe7a3057
JB
48052011-11-20 Juanma Barranquero <lekktu@gmail.com>
4806
4807 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4808
d2999b1a
MR
48092011-11-20 Martin Rudalics <rudalics@gmx.at>
4810
4811 * window.c (Fset_window_combination_limit): Rename argument
4812 STATUS to LIMIT.
4813 (Vwindow_combination_limit): Remove "status" from doc-string.
4814
d5ff9cd0
AS
48152011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4816
4817 * m/ibms390.h: Remove.
4818 * m/ibms390x.h: Don't include "ibms390.h".
4819
a5bb9bd3
SM
48202011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4821
4822 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4823 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4824
cd1181db
JB
48252011-11-20 Juanma Barranquero <lekktu@gmail.com>
4826
4827 * casetab.c (Fset_case_table):
4828 * charset.c (Fcharset_after): Fix typos.
4829
615a3b8d 48302011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4831
17e845af
PE
4832 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4833 Otherwise, valgrind does not work on some platforms.
4834 Problem reported by Andreas Schwab in
6a0bf43d
PE
4835 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4836 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4837 is set, removing the need for VIRT_ADDRESS_VARIES.
4838 (PURE_P): Use a more-efficient implementation that needs just one
4839 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4840 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4841 to 4 (xorl, subq, cmpq, setbe).
4842 * alloc.c (pure): Always extern now, since that's the
4843 VIRT_ADDR_VARIES behavior.
4844 (PURE_POINTER_P): Use a single comparison, not two, for
4845 consistency with the new puresize.h.
4846 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4847 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4848 Remove VIRT_ADDR_VARIES no longer needed.
4849
f8fe6f96
EZ
48502011-11-19 Eli Zaretskii <eliz@gnu.org>
4851
4852 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4853 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4854 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4855 behave as if the cursor position were at the window margin.
4856
4857 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4858 and the cursor position is out of bounds, behave as if the cursor
4859 position were at the window margin. (Bug#10075)
4860
df05a53c
CY
48612011-11-18 Chong Yidong <cyd@gnu.org>
4862
4863 * window.c (Fwindow_combination_limit): Make first argument
4864 non-optional, since it is meaningless for live windows like the
4865 selected window.
61ccba97 4866
2071918e
DA
48672011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4868
4869 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4870
b50a28de
SM
48712011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4872
4873 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4874 (graft_intervals_into_buffer): Simplify.
4875
015137db
EZ
48762011-11-18 Eli Zaretskii <eliz@gnu.org>
4877
4878 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4879 hash values of the two rows.
4880 (copy_row_except_pointers): Preserve the used[] arrays and the
4881 hash values of the two rows. (Bug#10035)
68c95424 4882 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4883
4884 * xdisp.c (row_hash): New function, body extracted from
4885 compute_line_metrics.
4886 (compute_line_metrics): Call row_hash, instead of computing the
4887 hash code inline.
4888
4889 * dispnew.c (verify_row_hash): Call row_hash for computing the
4890 hash code of a row, instead of duplicating code from xdisp.c.
4891
4892 * dispextern.h (row_hash): Add prototype.
4893
a2addb04
TH
48942011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4895
4896 * frame.c (delete_frame): Don't delete the terminal when the last
4897 X frame is closed if emacs is built with GTK toolkit.
4898
df85d315
JB
48992011-11-17 Juanma Barranquero <lekktu@gmail.com>
4900
4901 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4902
a0c2d0ae
MR
49032011-11-17 Martin Rudalics <rudalics@gmx.at>
4904
4905 * window.c (Vwindow_splits): Rename to
4906 Vwindow_combination_resize. Suggested by Juri Linkov.
4907 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4908 of Vwindow_splits.
4909
58179cce
JB
49102011-11-16 Juanma Barranquero <lekktu@gmail.com>
4911
7877f373
JB
4912 * nsfns.m (Fns_font_name):
4913 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4914
b6f67890
MR
49152011-11-16 Martin Rudalics <rudalics@gmx.at>
4916
4917 * window.h (window): Rename slot "nest" to "combination_limit".
4918 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4919 (Fset_window_nest): Rename to Fset_window_combination_limit.
4920 (Vwindow_nest): Rename to Vwindow_combination_limit.
4921 (recombine_windows, make_parent_window, make_window)
4922 (Fsplit_window_internal, saved_window)
4923 (Fset_window_configuration, save_window_save): Rename all
4924 occurrences of window_nest to window_combination_limit.
4925
c7015153
JB
49262011-11-15 Juanma Barranquero <lekktu@gmail.com>
4927
4928 * image.c (imagemagick_load_image): Fix typo.
4929
322ad6ec
EZ
49302011-11-14 Eli Zaretskii <eliz@gnu.org>
4931
4932 * xdisp.c (display_line): Move the call to
4933 highlight_trailing_whitespace before the call to
4934 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4935 faces of all the glyphs to compute ROW's hash value.
4936 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4937
f067b8ec
JB
49382011-11-14 Juanma Barranquero <lekktu@gmail.com>
4939
4940 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4941 just return (bug#10044).
4942
1e5b2111
EZ
49432011-11-12 Eli Zaretskii <eliz@gnu.org>
4944
7ef3cbd5
EZ
4945 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4946 with user-defined heap size. Bump the default size of the temacs
4947 heap to 27MB, to avoid memory warning when running temacs.
4948 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4949
1e5b2111
EZ
4950 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4951 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4952 (verify_row_hash) [XASSERTS]: New function.
4953 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4954 that the hash value of glyph rows is correct.
1e5b2111 4955
89d61221
MR
49562011-11-12 Martin Rudalics <rudalics@gmx.at>
4957
4958 * window.h (window): Remove splits slot.
4959 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4960 (Fdelete_other_windows_internal, make_parent_window)
4961 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4962 (Fset_window_configuration, save_window_save): Don't deal with
4963 split status of windows.
4964 (saved_window): Remove splits slot.
4965 (Vwindow_splits): Rewrite doc-string.
4966
97f18cc8
JD
49672011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4968
4969 * xfns.c (unwind_create_frame):
4970 * nsfns.m (unwind_create_frame):
4971 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4972 Vframe_list (Bug#9999).
4973
22a648b4
DA
49742011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4975
0b381c7e 4976 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4977
659afede
KH
49782011-11-11 Kenichi Handa <handa@m17n.org>
4979
4980 * callproc.c (Fcall_process): Set the member dst_multibyte of
4981 process_coding.
4982
9ac0394b
KH
49832011-11-11 Johan Bockgård <bojohan@gnu.org>
4984
4985 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4986 avoid a crash (bug#9496).
4987
2fbdc249
CY
49882011-11-09 Chong Yidong <cyd@gnu.org>
4989
4990 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4991 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4992
ac6b1f81
PE
49932011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4994
4995 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4996
09db192c
PE
49972011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4998
4999 Avoid some portability problems by eschewing 'extern inline' functions.
5000 The trivial performance wins aren't worth the portability hassles; see
5001 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5002 et seq.
5003 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5004 (window_box_width, window_box_left, window_box_left_offset)
5005 (window_box_right, window_box_right_offset): Undo previous change,
5006 by removing the "extern"s.
5007 * intervals.c (adjust_intervals_for_insertion)
5008 (adjust_intervals_for_deletion): Undo previous change,
5009 making these static again.
5010 (offset_intervals, temp_set_point_both, temp_set_point)
5011 (copy_intervals_to_string): No longer inline.
5012 * xdisp.c (window_text_bottom_y, window_box_width)
5013 (window_box_height, window_box_left_offset)
5014 (window_box_right_offset, window_box_left, window_box_right)
5015 (window_box): No longer inline.
5016
105216ed
CY
50172011-11-08 Chong Yidong <cyd@gnu.org>
5018
5019 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5020 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5021 Signal an error if not a live window.
105216ed
CY
5022 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5023 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5024
ae9e237f
JB
50252011-11-07 Juanma Barranquero <lekktu@gmail.com>
5026
5027 * lisp.h (syms_of_abbrev): Remove declaration.
5028 Reported by CHENG Gao <chenggao@royau.me>.
5029
c7aa8333
EZ
50302011-11-07 Eli Zaretskii <eliz@gnu.org>
5031
5032 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5033 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5034 of temacs in GUI mode.
5035
be7f5545
MR
50362011-11-07 Martin Rudalics <rudalics@gmx.at>
5037
5038 * window.h: Declare delete_all_child_windows instead of
5039 delete_all_subwindows.
5040 * window.c (Fwindow_nest, Fset_window_nest)
5041 (Fset_window_new_total, Fset_window_new_normal)
5042 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5043 (delete_all_subwindows): Rename to delete_all_child_windows.
5044 (Fdelete_other_windows_internal, Fset_window_configuration):
5045 Call delete_all_child_windows instead of delete_all_subwindows.
5046 * frame.c (delete_frame): Call delete_all_child_windows instead
5047 of delete_all_subwindows.
5048
ca78dc43
PE
50492011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5050
5051 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5052 This is also needed for porting to any host where GC_MARK_STACK is
5053 not GC_MAKE_GCPROS_NOOPS.
5054 (which_symbols): Use it.
5055
a0241d01
KH
50562011-11-07 Kenichi Handa <handa@m17n.org>
5057
5058 * coding.c (coding_set_destination): Check coding->src_pos only
5059 when coding->src_object is a buffer (bug#9910).
5060
5061 * process.c (send_process): Set the member src_multibyte of coding
5062 to 0 (bug#9911) when sending a unibyte text.
5063
5064 * callproc.c (Fcall_process): Set the member src_multibyte of
5065 process_coding to 0 (bug#9912).
5066
a64bfdfa 50672011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5068
5069 * xmenu.c (cleanup_widget_value_tree): New function.
5070 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5071 calling free_menubar_widget_value_tree directly (Bug#9830).
5072
cb41b32a
PE
50732011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5074
5075 Fix some portability problems with 'inline'.
5076 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5077 (window_box_width, window_box_left, window_box_left_offset)
5078 (window_box_right, window_box_right_offset): Declare extern.
5079 Otherwise, these inline functions do not conform to C99 and
5080 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5081 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5082 * intervals.c (adjust_intervals_for_insertion)
5083 (adjust_intervals_for_deletion): Now extern, because otherwise the
5084 extern inline functions 'offset_intervals' couldn't refer to it.
5085 (static_offset_intervals): Remove.
5086 (offset_intervals): Rewrite using the old contents of
5087 static_offset_intervals. The old version didn't conform to C99
5088 because an extern inline function contained a reference to an
5089 identifier with static linkage.
5090
b7041366
AS
50912011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5092
5093 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5094 GC.
5095
88a37c4d
EZ
50962011-11-06 Eli Zaretskii <eliz@gnu.org>
5097
5098 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5099 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5100 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5101 return Qleft_to_right.
5102
49745b39
CY
51032011-11-06 Chong Yidong <cyd@gnu.org>
5104
5105 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5106 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5107 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5108 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5109 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5110 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5111 (Fwindow_vscroll): Doc fix.
5112 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5113 argument, since it makes no sense to pass a live window and for
5114 consistency with window-child.
5115
1f05cd82
CS
51162011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5117
5118 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5119 support MSVC.
5120
22610910
JR
51212011-11-05 Jason Rumney <jasonr@gnu.org>
5122
5123 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5124 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5125 fonts (Bug#6029).
5126 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5127 bitwise arithmetic preventing use of unicode-sip and non-truetype
5128 opentype fonts.
5129
a06776b2
EZ
51302011-11-05 Eli Zaretskii <eliz@gnu.org>
5131
3ad924ba
EZ
5132 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5133 "emacs"-only part.
5134
a06776b2
EZ
5135 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5136 initialization code to keep similarity to xfns.c after changes
5137 from 2011-11-05.
5138
c9e7db78
JD
51392011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5140
a97f8f3f
JD
5141 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5142 (unwind_create_frame): New function (Bug#9943).
5143 (Fx_create_frame): Restructure code to be more similar to the one in
5144 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5145 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5146 Move terminal->reference_count++ just before making the frame official
5147 (Bug#9943).
5148
5149 * nsterm.m (x_free_frame_resources): New function.
5150 (x_destroy_window): Move code to x_free_frame_resources.
5151
c9e7db78 5152 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5153 (Fx_create_frame, x_create_tip_frame):
5154 Move terminal->reference_count++ just before making the frame
75f1671a 5155 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5156 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5157
a6fc3b5c
EZ
51582011-11-05 Eli Zaretskii <eliz@gnu.org>
5159
5160 Support MSVC build with newer versions of Visual Studio.
5161 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5162 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5163 nt/gmake.defs.
5164
5165 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5166 which are not supported by MSVC.
5167 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5168 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5169 bitfields.
5170 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5171 types in bitfields.
5172 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5173
5174 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5175
58179cce 51762011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5177
5178 Support MSVC build with newer versions of Visual Studio.
5179 * w32.c: Don't include w32api.h for MSVC.
5180 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5181
5182 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5183 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5184 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5185 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5186 e_* cousins.
5187 (alloca) [_MSC_VER]: Define to _alloca.
5188
5189 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5190
5191 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5192
a58c13ed
EZ
51932011-11-04 Eli Zaretskii <eliz@gnu.org>
5194
5195 * xdisp.c (note_mouse_highlight): If either of
5196 previous/next-single-property-change returns nil, treat that as
5197 the beginning or the end of the buffer. (Bug#9955)
5198
fe0b6370
JD
51992011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5200
a58c13ed 5201 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5202 label is not null (Bug#9951).
5203 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5204 may be NULL.
5205
89bd5ee1
EZ
52062011-11-04 Eli Zaretskii <eliz@gnu.org>
5207
5208 * window.c (Fwindow_body_size): Mention in the doc string that the
5209 return value is in frame's canonical units. (Bug#9949)
5210
84c3edb9
EZ
52112011-11-03 Eli Zaretskii <eliz@gnu.org>
5212
4e2fb5c7
EZ
5213 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5214
84c3edb9 5215 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5216 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5217 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5218
bc17a887
EZ
52192011-11-01 Eli Zaretskii <eliz@gnu.org>
5220
5221 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5222 Don't stop backward scan on the continuation glyph, even though
5223 its CHARPOS is positive.
6d5eb5b0
SM
5224 (mouse_face_from_buffer_pos, note_mouse_highlight):
5225 Rename cover_string to disp_string.
bc17a887 5226
4ee88440
MR
52272011-11-01 Martin Rudalics <rudalics@gmx.at>
5228
5229 * window.c (temp_output_buffer_show): Don't use
5230 Vtemp_buffer_show_specifiers.
5231 (Vtemp_buffer_show_specifiers): Remove unused variable.
5232
c2ff3c02
EZ
52332011-10-30 Eli Zaretskii <eliz@gnu.org>
5234
5235 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5236 past the beginning of the current glyph matrix.
5237
58179cce 52382011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5239
5240 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5241 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5242 HAVE_GTK3 (Bug#9869).
b77a6a7f 5243
3b574623
JD
5244 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5245 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5246
b77a6a7f
JD
5247 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5248
5249 * xterm.c: Declare x_handle_net_wm_state to return int.
5250 (handle_one_xevent): Check if we are iconified but don't have
5251 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5252 (get_current_wm_state): Return non-zero if not hidden,
5253 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5254 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5255 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5256 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5257
196e41e4
PE
52582011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5259
5260 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5261 so that this new function doesn't get optimized away by a
5262 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5263
021f2e1a
AS
52642011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5265
5266 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5267
8b058d44
EZ
52682011-10-29 Eli Zaretskii <eliz@gnu.org>
5269
5270 Fix the `xbytecode' command.
5271 * .gdbinit (xprintbytestr): New command.
b50a28de 5272 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5273 (xbytecode): Print the byte-code string as well.
5274
4452fb80
EZ
52752011-10-29 Kim Storm <storm@cua.dk>
5276
8b058d44
EZ
5277 * alloc.c (which_symbols): New function.
5278
21b72067
AS
52792011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5280
5281 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5282 line. (Bug#9903)
5283
83ed7b5c
GM
52842011-10-29 Glenn Morris <rgm@gnu.org>
5285
5286 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5287 Not clear what it was for, and it causes various bugs. (Bug#9839)
5288
5a7a728b
EZ
52892011-10-28 Eli Zaretskii <eliz@gnu.org>
5290
5291 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5292 possible random value that matches one of those tested as
5293 condition to clear the mouse face.
5294
d3d0842f
CY
52952011-10-28 Chong Yidong <cyd@gnu.org>
5296
5297 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5298
31b39d13
DN
52992011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5300
5301 * window.c (make_window): Initialize phys_cursor_on_p.
5302
9aba6043
SM
53032011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5304
5305 * lisp.h (struct Lisp_Symbol): Update comments.
5306
c20992f4
JB
53072011-10-28 Juanma Barranquero <lekktu@gmail.com>
5308
5309 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5310
db4f02f2
EZ
53112011-10-28 Eli Zaretskii <eliz@gnu.org>
5312
5313 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5314 <oslsachem@gmail.com> for helping to debug this.
5315
5316 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5317 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5318 (g_b_init_get_glyph_outline_w): New static variables.
5319 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5320 (GetGlyphOutlineW_Proc): New typedefs.
5321 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5322 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5323 New functions.
5324 (w32font_open_internal, compute_metrics):
5325 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5326 instead of calling the "wide" APIs directly.
5327
5328 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5329
5330 * w32.h (syms_of_w32font): Add prototype.
5331
87e68db4
JB
53322011-10-27 Juanma Barranquero <lekktu@gmail.com>
5333
5334 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5335 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5336 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5337 (Fmove_to_window_line): Doc fix.
5338
435c1d67
CY
53392011-10-27 Chong Yidong <cyd@gnu.org>
5340
5341 * process.c (make_process): Set gnutls_state to NULL.
5342
5343 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5344 non-NULL, regardless of GNUTLS_INITSTAGE.
5345 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5346 an error. Set process slots as soon as we allocate them.
5347
5348 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5349
9c6c6f49
CY
53502011-10-27 Chong Yidong <cyd@gnu.org>
5351
9aba6043
SM
5352 * gnutls.c (emacs_gnutls_deinit): New function.
5353 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5354 (Fgnutls_deinit, Fgnutls_boot): Use it.
5355
5356 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5357 (deactivate_process): Call emacs_gnutls_deinit.
5358
657d08d3
JB
53592011-10-27 Juanma Barranquero <lekktu@gmail.com>
5360
5361 * image.c (x_create_x_image_and_pixmap):
5362 * w32.c (sys_rename, w32_delayed_load):
5363 * w32font.c (fill_in_logfont):
5364 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5365
5430d399
JB
53662011-10-26 Juanma Barranquero <lekktu@gmail.com>
5367
5368 * w32fns.c (w32_default_color_map): New function,
5369 extracted from Fw32_default_color_map.
a7ef684b 5370 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5371
fe0055fa
PE
53722011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5373
5374 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5375
e6346438
SM
53762011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5377
5378 * keyboard.c (test_undefined): New function (bug#9751).
5379 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5380
e112cc37
ET
53812011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5382
5383 * sysdep.c (init_sys_modes): Fix the check for the controlling
5384 terminal (Bug#6649).
5385
7b5d6677
EZ
53862011-10-20 Eli Zaretskii <eliz@gnu.org>
5387
5388 * dispextern.h (struct bidi_it): New member next_en_type.
5389
5390 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5391 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5392 current character, check also for next_en_type being WEAK_EN.
5393 (bidi_resolve_weak): Don't enter the expensive loop if the current
5394 position is before next_en_pos. Record the bidi type of the first
5395 non-ET, non-BN character we find, in addition to its position.
5396 (bidi_level_of_next_char): Invalidate next_en_type when
5397 next_en_pos is over-stepped.
5398
7da0b018
PE
53992011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5400
5401 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5402 * editfns.c: Rewrite current-time-zone so that it invokes
5403 the equivalent of (format-time-string "%Z") to get the time zone name.
5404 This fixes a bug when the time zone name contains characters that
5405 need converting from the system time locale to Emacs internal format.
5406 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5407 that patch fixed format-time-string to do the conversion, but
5408 I forgot to fix current-time-zone.
5409 (format_time_string): New function, containing most of
5410 what Fformat_time_string used to contain.
5411 (Fformat_time_string): Rewrite in terms of format_time_string.
5412 This doesn't change this function's behavior.
5413 (current-time-zone): Rewrite to use format_time_string.
5414 This fixes the bug reported by Michael Schierl in
5415 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5416 Jason Rumney's 2007-06-07 change worked around this bug, but
5417 didn't fix it.
5418 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5419
8547b010
EZ
54202011-10-19 Eli Zaretskii <eliz@gnu.org>
5421
5422 * xdisp.c (start_display): If the character at POS is displayed
5423 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5424 (try_window_reusing_current_matrix): If a line ends in a display
5425 vector or the next line starts in a display vector, continue
5426 redrawing the window even though the character position of
5427 start_row was reached.
8547b010
EZ
5428 (Bug#9771, part 2)
5429
4e948d15
CY
54302011-10-18 Chong Yidong <cyd@gnu.org>
5431
5432 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5433 with nobreak-char-display too.
5434
4787455f
EZ
54352011-10-18 Eli Zaretskii <eliz@gnu.org>
5436
5437 Fix part 3 of bug#9771.
5438 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5439 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5440 non-neutral characters if the current character is a paragraph
5441 separator (a.k.a. Newline). This avoids running the same
5442 expensive loop twice, once when we consume the preceding newline
5443 and the other time when the line actually needs to be displayed.
5444 Avoid the loop when we see neutrals on the base embedding level
5445 following a character whose directionality is the same as the
5446 paragraph's. This avoids running the expensive loop when a line
5447 ends in a long sequence of neutrals, like control characters.
5448 Add assertion against STRONG_AL type. Slightly rearrange code
5449 that determines the type of a neutral given the first non-neutral
5450 that follows it.
5451 (bidi_level_of_next_char): Set next_en_pos to zero when
5452 invalidating its info.
5453
2c91f553
EZ
54542011-10-17 Eli Zaretskii <eliz@gnu.org>
5455
5456 * xdisp.c (push_display_prop): Determine whether to record string
5457 or buffer position by IT->string, not by IT->method. Allow
5458 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5459 (move_it_vertically_backward): Don't look for character position
5460 immediately after the newline when in a continuation line.
5461 (Bug#9771, part 1)
2c91f553 5462
c7b08b0d
MR
54632011-10-15 Martin Rudalics <rudalics@gmx.at>
5464
5465 * window.c (coordinates_in_window): Rewrite and delabelize
5466 vertical border check. (Bug#5357) (Bug#9618)
5467
6b02f655
SM
54682011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5469
5470 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5471 errors in XSetWindowBorder (bug#9310).
5472
81d40c92
DA
54732011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5474
5475 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5476 avoid crash when xmalloc overrun checking is enabled.
5477
d4172c3b
EZ
54782011-10-13 Eli Zaretskii <eliz@gnu.org>
5479
5480 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5481 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5482 cursor motion with <left> and <right> arrow keys.
5483
5484 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5485 some callers set that themselves.
5486
b00eea75
EZ
54872011-10-12 Eli Zaretskii <eliz@gnu.org>
5488
5489 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5490 display string and the previous row comes from the same string and
5491 is empty. (Bug#9739) (Bug#9738)
5492
8fe012c4
SM
54932011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5494
5495 * doc.c (get_doc_string): Encode file name (bug#9735).
5496
0074aef2
EZ
54972011-10-12 Eli Zaretskii <eliz@gnu.org>
5498
79beb178
EZ
5499 * bidi.c (bidi_level_of_next_char):
5500 * xdisp.c (get_visually_first_element): Remove old incorrect
5501 comments regarding the Unicode Line Separator character.
5502
0074aef2
EZ
5503 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5504
6e4b3fbe
DA
55052011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5506
5507 * alloc.c (Fgc_status): Do not access beyond zombies array
5508 boundary if nzombies > MAX_ZOMBIES.
5509 * alloc.c (dump_zombies): Add missing format specifier.
5510
0324f3af
PE
55112011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5512
b5525cac
PE
5513 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5514 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5515
0324f3af
PE
5516 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5517 Some packages use them to denote characters with modifiers.
5518
e9b5f888
AS
55192011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5520
5521 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5522 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5523 matching a pp-number. Rename parameter var to var1.
5524
127827c0
SM
55252011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5526
5527 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5528
c8fd3bd0
GM
55292011-10-08 Glenn Morris <rgm@gnu.org>
5530
5531 * callint.c (Fcall_interactively): Give a more explicit error for the
5532 'c' case with a non-character input. (Bug#8479)
5533
352ec8ff
EZ
55342011-10-08 Eli Zaretskii <eliz@gnu.org>
5535
03669ccb
EZ
5536 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5537 lines.
7061c986
EZ
5538 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5539 lines that are hscrolled on the left.
03669ccb 5540
352ec8ff
EZ
5541 * dispnew.c (buffer_posn_from_coords): Account for a possible
5542 presence of header-line. (Bug#4426)
5543
a66cfb1c
SM
55442011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5545
6b02f655
SM
5546 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5547 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5548
7c5ee88e
PE
55492011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5550
5551 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5552 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5553 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5554 this makes Emacs dump core during garbage collection on rare
5555 occasions. sizeof is obviously inferior to offsetof here, so
5556 stick with offsetof.
5557 (GC_POINTER_ALIGNMENT): New macro.
5558 (mark_memory): Omit 3rd (offset) arg; caller changed.
5559 Don't assume EMACS_INT alignment is the same as pointer alignment.
5560
df1bbe5b
SM
55612011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5562
5563 * keyboard.c (read_key_sequence_remapped): New var.
5564 (read_key_sequence): Compute remapping in the right buffer.
5565 (command_loop_1): Use read_key_sequence's remapping directly.
5566
51553db6
SM
55672011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5568
32c1fffd
SM
5569 * dired.c (file_name_completion): Don't expand file name.
5570 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5571 before checking file name handler.
5572
51553db6
SM
5573 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5574 they've been requested explicitly (bug#9591).
5575
b6bd1599 55762011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5577
5578 * keymap.c (Fsingle_key_description): Use make_specified_string
5579 instead of build_string to build string from push_key_description.
5580 (Bug#5193)
5581
f701dc2a
PE
55822011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5583
4222c55d
PE
5584 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5585 This fixes a Y2038 bug on 64-bit hosts.
5586 * buffer.c (reset_buffer):
5587 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5588 (Fclear_buffer_auto_save_failure):
5589 Use 0, not -1, to represent an unset failure time, since time_t
5590 might not be signed.
5591
f701dc2a
PE
5592 Remove dependency on glibc malloc internals.
5593 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5594 Move back here from lisp.h, but with their new implementations.
5595 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5596 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5597 * charset.c (charset_table_init): New static var.
5598 (syms_of_charset): Use it instead of xmalloc. This removes a
5599 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5600 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5601 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5602 Move back to alloc.c.
5603 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5604 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5605
9ceebf39
JD
56062011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5607
5608 * nsterm.m (windowDidResize): Call x_set_window_size only when
5609 ns_in_resize is true. Otherwise set pixelwidth/height and
5610 call change_frame_size (Bug#9628).
5611
cb993c58
PE
56122011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5613
3930c88b
PE
5614 Port --enable-checking=all to Fedora 14 x86-64.
5615 * charset.c (syms_of_charset): Also account for glibc malloc's
5616 internal overhead when calculating the initial malloc maximum.
5617
cb993c58
PE
5618 Port --enable-checking=all to Fedora 14 x86.
5619 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5620 Move to lisp.h.
5621 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5622 (overrun_check_realloc, overrun_check_free):
5623 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5624 That way, xmalloc returns a properly-aligned pointer even if
5625 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5626 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5627 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5628 into account when calculating the initial malloc maximum.
5629 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5630 Move here from alloc.c, so that charset.c can use it too.
5631 Properly align; the old code wasn't right for common 32-bit hosts
5632 when configured with --enable-checking=all.
5633 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5634 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5635
31bed486
EZ
56362011-09-29 Eli Zaretskii <eliz@gnu.org>
5637
04c70788 5638 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5639 use EDOM.
5640
fbcaa2f3
EZ
56412011-09-28 Eli Zaretskii <eliz@gnu.org>
5642
5643 * xdisp.c (compute_display_string_end): If there's no display
5644 string at CHARPOS, return -1.
5645
5646 * bidi.c (bidi_fetch_char): When compute_display_string_end
5647 returns a negative value, treat the character as a normal
5648 character not covered by a display string. (Bug#9624)
5649
a239d4e9
JB
56502011-09-28 Juanma Barranquero <lekktu@gmail.com>
5651
5652 * lread.c (Fread_from_string): Fix typo in docstring.
5653
88652fd5
EZ
56542011-09-27 Eli Zaretskii <eliz@gnu.org>
5655
5656 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5657 newline, reseat the iterator instead of bidi-iterating there one
5658 character at a time. (Bug#9610)
32c1fffd
SM
5659 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5660 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5661
ed497dd4
AS
56622011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5663
5664 * lread.c (readevalloop): Use correct code for NBSP.
5665 (read1): Likewise. (Bug#9608)
5666
b2bf61aa
MA
56672011-09-25 Michael Albinus <michael.albinus@gmx.de>
5668
5669 * dbusbind.c (Fdbus_register_signal): When service is not
5670 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5671
32bbb17c
GM
56722011-09-25 Glenn Morris <rgm@gnu.org>
5673
5674 * buffer.c (truncate-lines): Doc fix.
5675
94e0933e
CY
56762011-09-24 Chong Yidong <cyd@stupidchicken.com>
5677
5678 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5679 (Fset_window_next_buffers): Doc fix.
5680
cddde921
GM
56812011-09-24 Glenn Morris <rgm@gnu.org>
5682
5683 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5684
1260aef1
PE
56852011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5686
25b4bfa0
PE
5687 Fix minor problems found by static checking.
5688 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5689 * indent.c (Fvertical_motion): Fix == vs = typo.
5690
e3cbd34b
EZ
56912011-09-24 Eli Zaretskii <eliz@gnu.org>
5692
a66cfb1c
SM
5693 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5694 Default value is now t. Doc fix.
6bf7006f 5695
e3cbd34b 5696 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5697 logic when moving up, not only when moving down. Fix the
e3cbd34b 5698 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5699 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5700
5701 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5702 CHARPOS is covered by a display string which includes newlines.
5703 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5704 is covered by a display string with embedded newlines.
5705
a3de0cbd
MA
57062011-09-24 Michael Albinus <michael.albinus@gmx.de>
5707
5708 * dbusbind.c (Fdbus_register_signal): Add match rule to
5709 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5710 (Fdbus_register_method, Vdbus_registered_objects_table):
5711 Fix docstring.
a3de0cbd 5712
b260039d
JM
57132011-09-24 Jim Meyering <meyering@redhat.com>
5714
32c1fffd 5715 do not ignore write error for any output size
b260039d
JM
5716 The previous change was incomplete.
5717 While it makes emacs --batch detect the vast majority of stdout
5718 write failures, errors were still ignored whenever the output size is
5719 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5720 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5721 && echo FAIL: ignored write error
5722 FAIL: ignored write error
5723 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5724 && echo FAIL: ignored write error
5725 FAIL: ignored write error
5726 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5727
8eca8a7c
AS
57282011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5729
5730 * emacs.c (Fkill_emacs): In noninteractive mode exit
5731 non-successfully if a write error occurred on stdout. (Bug#9574)
5732
3341db62
EZ
57332011-09-21 Eli Zaretskii <eliz@gnu.org>
5734
5735 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5736 the xassert test.
5737
5738 * dispextern.h (struct it): Update the comment documenting what
5739 can it->OBJECT be.
5740
8c203dbf
EZ
57412011-09-20 Eli Zaretskii <eliz@gnu.org>
5742
5743 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5744 a display string, extend search for cursor position to end of row.
5745 (find_row_edges): If the row ends in a newline from a display
5746 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5747 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5748 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5749 non-empty line. Fixes confusing cursor motion with arrow keys at
5750 the beginning of a line that starts with whitespace.
8c203dbf 5751
a4824228
LMI
57522011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5753
5754 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5755 (bug#9493).
5756
33ed493b
CY
57572011-09-18 Chong Yidong <cyd@stupidchicken.com>
5758
5759 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5760 boolean (Bug#9154).
5761
56cd55c8
EZ
57622011-09-18 Eli Zaretskii <eliz@gnu.org>
5763
5764 * xdisp.c (display_line): Record maximum and minimum buffer
5765 positions even if no glyphs were produced (e.g., by a zero-width
5766 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5767 buffer positions that will be removed from the glyph row because
5768 they don't fit.
c02dcedf
EZ
5769 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5770 column is beyond frame width: don't subtract 1 "pixel" when
5771 computing width of the stretch.
3e62b7e0
EZ
5772 (reseat_at_next_visible_line_start): Undo the change made on
5773 2011-09-17 that saved paragraph information and restored it after
5774 the call to `reseat'. (Bug#9545)
56cd55c8 5775
5ed99d36 57762011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5777
5778 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5779 and turn window cursor on if cleared (Bug#9415).
5780
5ed99d36 57812011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5782
5783 * search.c (boyer_moore): Take unibyte characters from pattern
5784 literally. (Bug#9458)
5785
9bade7b2
EZ
57862011-09-18 Eli Zaretskii <eliz@gnu.org>
5787
5788 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5789
e5e9d610
PE
57902011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5791
87e4427a
PE
5792 Fix minor problem found by static checking.
5793 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5794 initialized, to pacify gcc -Wuninitialized.
5795
e5e9d610
PE
5796 * fileio.c: Report proper errno when syscall falls.
5797 (Finsert_file_contents): Save and restore errno,
5798 so that report_file_error outputs the correct diagnostic.
5799 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5800
a1674f0b
EZ
58012011-09-18 Eli Zaretskii <eliz@gnu.org>
5802
5803 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5804
fbfb6dd4
EZ
58052011-09-17 Eli Zaretskii <eliz@gnu.org>
5806
5807 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5808 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5809
bb187662
EZ
58102011-09-17 Eli Zaretskii <eliz@gnu.org>
5811
1137e8b8 5812 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5813 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5814
5815 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5816 (bidi_find_paragraph_start): Search back for paragraph beginning
5817 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5818 (bidi_move_to_visually_next): Only trigger paragraph-related
5819 computations when the last character is a newline or at EOB, not
5820 just any NEUTRAL_B. (Bug#9470)
5821
bb187662
EZ
5822 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5823 truncated lines if point is covered by a display string. (Bug#9524)
5824
2e621251
PE
58252011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5826
5827 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5828 (cons_to_x_long): New function.
5829 (lisp_data_to_selection_data): Use it. Correct the test for
5830 short-versus-long data; it was negated. Break out of vector
5831 loop, for efficiency, when a long datum is discovered.
5832
91a15bc6
SM
58332011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5834
5835 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5836
b41c3a35
EZ
58372011-09-16 Eli Zaretskii <eliz@gnu.org>
5838
5839 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5840 GCC PR/17406) by declaring this function with external scope.
5841
7812ba2d
PE
58422011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5843
5844 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5845 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5846
cf7edc2a
AS
58472011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5848
5849 * editfns.c (Fformat): Correctly handle text properties on "%%".
5850
bd01620e
EZ
58512011-09-15 Eli Zaretskii <eliz@gnu.org>
5852
5853 * xterm.c (x_draw_composite_glyph_string_foreground):
5854 * w32term.c (x_draw_composite_glyph_string_foreground):
5855 * term.c (encode_terminal_code):
5856 * composite.c (composition_update_it, get_composition_id):
5857 * xdisp.c (get_next_display_element)
5858 (fill_composite_glyph_string): Add comments about special meaning
5859 of TAB characters in a composition.
5860
a02719a3
PE
58612011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5862
5863 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5864 This occurs when processing a multibyte format.
5865 Problem reported by Wolfgang Jenker.
a02719a3 5866
72589a3c
JB
58672011-09-15 Johan Bockgård <bojohan@gnu.org>
5868
5869 * xdisp.c (try_cursor_movement): Only check for exact match if
5870 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5871
1c14176c
PE
58722011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5873
5874 Remove unused external symbols.
5875 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5876 * xdisp.c (calc_pixel_width_or_height): Now static.
5877 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5878 * indent.c (check_display_width):
5879 * w32term.c: Fix comment to match code.
5880 * xterm.c, xterm.h (x_catching_errors): Remove.
5881
d2eea5b5
PE
58822011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5883
5884 * xselect.c: Use signed conversions more consistently (Bug#9498).
5885 (selection_data_to_lisp_data): Assume incoming selection data are
5886 signed integers, not unsigned. This is to be consistent with
5887 outgoing selection data, which was modified to use signed integers
5888 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5889 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5890 expects long, not unsigned long.
5891
46888499
EZ
58922011-09-14 Eli Zaretskii <eliz@gnu.org>
5893
5894 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5895 computation of loop end. Reported by Johan Bockgård
5896 <bojohan@gnu.org>.
5897
ef8ef9fb
CY
58982011-09-13 Chong Yidong <cyd@stupidchicken.com>
5899
5900 * frame.c (Fother_visible_frames_p): Function deleted.
5901
fa819fed
EZ
59022011-09-12 Eli Zaretskii <eliz@gnu.org>
5903
5904 * indent.c (compute_motion): Process display vector front to back
5905 rather than the other way around. (Bug#2496)
5906
2ba8e008
SM
59072011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5908
5909 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5910
20f53c69
CY
59112011-09-11 Chong Yidong <cyd@stupidchicken.com>
5912
5913 * minibuf.c (Fread_from_minibuffer): Doc fix.
5914
d562d7a4
EZ
59152011-09-11 Eli Zaretskii <eliz@gnu.org>
5916
5917 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5918 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5919
1c4d7f3d
LMI
59202011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5921
5922 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5923 value for non-existent files.
5924
b885bf36
EZ
59252011-09-11 Eli Zaretskii <eliz@gnu.org>
5926
5927 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5928 set its "size" to -1. This will set the modtime_size field of
5929 the corresponding buffer to -1, which is what
5930 verify-visited-file-modtime expects for files that do not exist.
5931 (Bug#9139)
5932
6612f0bf
PE
59332011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5934
5935 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5936 here ...
5937 * lisp.h: ... from here. push_key_description is no longer
5938 defined in keyboard.c, so its declaration should not be in
5939 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5940 logically belongs with push_key_description.
5941
dfb3f755
PE
59422011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5943
5944 * buffer.h: Include <sys/types.h> instead of <time.h>.
5945 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5946 Problem reported by Herbert J. Skuhra.
5947
3134906c
LMI
59482011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5949
5950 * xml.c (parse_region): Make the parsing work for
5951 non-comment-starting XML files again (bug#9144).
5952
8d903f4e
AS
59532011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5954
5955 * image.c (gif_load): Fix calculation of bottom and right corner.
5956 (Bug#9468)
5957
80ad64f4
EZ
59582011-09-10 Eli Zaretskii <eliz@gnu.org>
5959
5960 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5961 redisplay in small windows.
5962
208a048d
EZ
59632011-09-09 Eli Zaretskii <eliz@gnu.org>
5964
5965 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5966
9b1c252e
MR
59672011-09-08 Martin Rudalics <rudalics@gmx.at>
5968
5969 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5970 Operate on live windows only.
5971
2949f33b
JB
59722011-09-08 Juanma Barranquero <lekktu@gmail.com>
5973
5974 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5975
e08dcafd
EZ
59762011-09-07 Eli Zaretskii <eliz@gnu.org>
5977
5978 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5979 only under bidi iteration.
5980
115b96bd
JD
59812011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5982
5983 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5984
c8199d0f
PE
59852011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5986
5987 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5988 Without this fix, the command to link temacs failed due to an
5989 undefined symbol __builtin_isnan. This is because
5990 /usr/include/iso/math_c99.h #defines isnan(x) to
5991 __builtin_isnan(x), but the bundled gcc, which identifies itself
5992 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5993 a __builtin_isnan.
5994 * floatfns.c (isnan): #undef, and then #define to a clone of
5995 what's in data.c.
5996 (Fisnan): Always define, since it's always available now.
5997 (syms_of_floatfns): Always define isnan at the Lisp level.
5998
e39b275c 59992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6000
6001 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6002
b2db44d9 60032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6004
f4af5137 6005 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6006 The previous code assumed that file offsets (off_t values) fit in
6007 EMACS_INT variables, which is not true on typical 32-bit hosts.
6008 The code messed up by falsely reporting buffer overflow in cases
6009 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6010 when "big" contains more than 2**29 bytes, even though this
6011 inserts just one byte and does not overflow the buffer.
6012 (Finsert_file_contents): Store file offsets as off_t
6013 values, not as EMACS_INT values. Check for overflow when
6014 converting between EMACS_INT and off_t. When checking for
6015 buffer overflow or for overlap, take the offsets into account.
6016 Don't use EMACS_INT for small values where int suffices.
6017 When checking for overlap, fix a typo: ZV was used where
6018 ZV_BYTE was intended.
6019 (Fwrite_region): Don't assume off_t fits into 'long'.
6020 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6021
ecfc0a49
MA
60222011-09-05 Michael Albinus <michael.albinus@gmx.de>
6023
6024 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6025
6511acf2 60262011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6027
0999621a 6028 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6029
6030 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6031 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6032 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6033 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6034 (modify_event_symbol): Do not assume that the length of
6035 name_alist_or_stem is safe to alloca and fits in int.
6036 (Fexecute_extended_command): Likewise for function name and binding.
6037 (Frecursion_depth): Wrap around reliably on integer overflow.
6038 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6039 since some callers pass EMACS_INT values.
6040 (Fsingle_key_description): Don't crash if symbol name contains more
6041 than MAX_ALLOCA bytes.
6042 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6043 (get_minibuffer): Arg is now EMACS_INT, not int.
6044 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6045 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6046 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6047
2be7d702
PE
6048 * dbusbind.c (signature_cat): New function.
6049 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6050 Do not overrun buffer; instead, report string overflow.
6051
9d1df220
PE
6052 * dispnew.c (add_window_display_history): Don't overrun buffer.
6053 Truncate instead; this is OK since it's just a log.
6054
33ef5c64
PE
6055 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6056 even if the time zone offset is outlandishly large.
6057 Don't mishandle offset == INT_MIN.
6058
66c6fdd5
PE
6059 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6060 when creating daemon; the previous buffer-overflow check was incorrect.
6061
d749b01b
PE
6062 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6063 which has the guts of the old verror function.
6064
b5cd1905
PE
6065 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6066 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6067
6e1a67fb
PE
6068 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6069 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6070 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6071 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6072 length of string rather than counting it via multiple sprintfs;
6073 that's simpler and more reliable.
c21721cc
PE
6074 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6075 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6076 sprintf, in case result does not fit in int.
6077
c57b67fc
PE
6078 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6079 (fontset_from_font): Print it.
6080
8a401434
PE
6081 * frame.c (tty_frame_count): Now printmax_t, not int.
6082 (make_terminal_frame, set_term_frame_name): Print it.
6083 (x_report_frame_params): In X, window IDs are unsigned long,
6084 not signed long, so print them as unsigned.
6085 (validate_x_resource_name): Check for implausibly long names,
6086 and don't assume name length fits in 'int'.
6087 (x_get_resource_string): Don't blindly alloca invocation name;
6088 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6089 not fit in int.
6090
6e1a67fb
PE
6091 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6092 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6093 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6094
0df02bf3
PE
6095 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6096 Use esprintf, not sprintf, in case result does not fit in int.
6097
48e30793
PE
6098 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6099 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6100 it as a large positive number.
6101 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6102 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6103
a66ff6d8
PE
6104 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6105 in case result does not fit in int.
6106
aca216ff
PE
6107 * print.c (float_to_string): Detect width overflow more reliably.
6108 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6109 buffer overrun. Don't assume list length fits in 'int'. Treat
6110 print length of 0 as 0, not as infinity; to be consistent with other
6111 uses of print length in this function. Don't overflow print length
6112 index. Don't assume hash table size fits in 'long', or that
6113 vectorlike size fits in 'unsigned long'.
6114
31c286f7
PE
6115 * process.c (make_process): Use printmax_t, not int, to format
6116 process-name gensyms.
6117
55e5faa1
PE
6118 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6119
80f2e268
PE
6120 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6121 to avoid potential buffer overrun.
6122
670741ab
PE
6123 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6124 if X resource line is longer than 512 bytes.
6125
b7163a50
PE
6126 * xfns.c (x_window): Make sprintf buffer a bit bigger
6127 to avoid potential buffer overrun.
6128
ae58ff1f
PE
6129 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6130
c43c8a6a
PE
6131 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6132
3f8236f4
PE
61332011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6134
53e9fe90 6135 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6136 Without these, Emacs silently mishandles large integers sometimes.
6137 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6138 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6139
6511acf2
PE
6140 * xdisp.c (try_window_id): Check Emacs fixnum range before
6141 converting to 'int'.
806add1d 6142
6511acf2 6143 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6144 Check that an Emacs fixnum is in range before assigning it to 'int'.
6145 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6146 values converted from Emacs fixnums.
6147 (Frecenter): Don't wrap around a line count if it is out of 'int'
6148 range; instead, treat it as an extreme value.
6149 (Fset_window_configuration, compare_window_configurations):
6150 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6151
6511acf2
PE
6152 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6153 that can exceed INT_MAX. Check that EMACS_INT value is in range
6154 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6155 (match_limit): Don't assume that a fixnum can fit in 'int'.
6156
6511acf2 6157 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6158 exceed INT_MAX.
6159
6511acf2 6160 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6161 (Fvertical_motion): Don't wrap around LINES values that don't fit
6162 in 'int'. Instead, treat them as extreme values. This is good
6163 enough for windows, which can't have more than INT_MAX lines anyway.
6164
fcb901a7
LMI
61652011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6166
0f2f6b6d
LMI
6167 * Require libxml/parser.h to avoid compilation warning.
6168
fcb901a7
LMI
6169 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6170
6171 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6172 since this reportedly can destroy thread storage.
6173
6e20a0d4
CY
61742011-08-30 Chong Yidong <cyd@stupidchicken.com>
6175
6176 * syntax.c (find_defun_start): Update all cache variables if
6177 exiting early (Bug#9401).
6178
148ae00e
EZ
61792011-08-30 Eli Zaretskii <eliz@gnu.org>
6180
f6cfbd8f
EZ
6181 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6182
148ae00e
EZ
6183 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6184 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6185 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6186
6187 * term.c (tty_append_glyph): New function.
6188 (produce_stretch_glyph): Static function and its prototype deleted.
6189
a66cfb1c
SM
6190 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6191 Add prototypes.
148ae00e 6192
c4a07a4c
PE
61932011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6194
6195 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6196 when checking :margin (Bug#9390).
6197 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6198 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6199 so that the name doesn't mislead. All uses changed.
6200
6bc8cd65
JB
62012011-08-28 Johan Bockgård <bojohan@gnu.org>
6202
6203 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6204 set_tty_hooks.
6205
dca4927e
EZ
62062011-08-27 Eli Zaretskii <eliz@gnu.org>
6207
6208 * xdisp.c (move_it_to): Don't bail out early when reaching
6209 position beyond to_charpos, if we are scanning backwards.
6210 (move_it_vertically_backward): When DY == 0, make sure we get to
6211 the first character in the line after the newline.
6212
f2cad773
PE
62132011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6214
6215 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6216 (ccl_driver): Do not generate an out-of-range pointer.
6217 (Fccl_execute_on_string): Remove unnecessary check for
6218 integer overflow, noted by Stefan Monnier in
6219 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6220 Remove a FIXME that didn't need fixing.
6221 Simplify the newly-introduced buffer reallocation code.
6222
0cae2cdb
JB
62232011-08-27 Juanma Barranquero <lekktu@gmail.com>
6224
6225 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6226
5fc295a4 62272011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6228
70c60eb2 6229 Integer and memory overflow issues (Bug#9196).
726e0ab1 6230
d31850da
PE
6231 * doc.c (get_doc_string): Rework so that
6232 get_doc_string_buffer_size is the actual buffer size, rather than
6233 being 1 less than the actual buffer size; this makes xpalloc more
6234 convenient.
6235
a69fbedb
PE
6236 * image.c (x_allocate_bitmap_record, cache_image):
6237 * xselect.c (Fx_register_dnd_atom):
6238 Simplify previous changes by using xpalloc.
6239
fe5c5d37
PE
6240 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6241 since either will do and ptrdiff_t is convenient with xpalloc.
6242
0065d054
PE
6243 * charset.c (charset_table_size)
6244 (struct charset_sort_data.priority): Now ptrdiff_t.
6245 (charset_compare): Don't overflow if priorities differ greatly.
6246 (Fsort_charsets): Don't assume list length fits in int.
6247 Check for size-calculation overflow when allocating sort data.
6248 (syms_of_charset): Allocate an initial charset table that is
6249 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6250
6251 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6252
6253 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6254 The actual value is always <= INT_MAX, and leaving it unsigned made
6255 overflow checking harder.
6256
6257 * dispextern.h (struct glyph_matrix.rows_allocated)
6258 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6259 with xpalloc. The values are still always <= INT_MAX.
6260
6261 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6262
6263 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6264 (SAFE_NALLOCA): New macro.
6265
6266 * region-cache.c (struct boundary.pos, find_cache_boundary)
6267 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6268 (set_cache_region, invalidate_region_cache)
6269 (revalidate_region_cache, know_region_cache, region_cache_forward)
6270 (region_cache_backward, pp_cache):
6271 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6272 so that ptrdiff_t * can be passed to xpalloc.
6273 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6274 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6275 (pp_cache): Don't assume cache_len fits in int.
6276 * region-cache.h: Adjust extern decls to match.
6277
6278 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6279 EMACS_INT, since either will do, for xpalloc.
6280
6281 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6282 (xnmalloc, xnrealloc, xpalloc): New functions.
6283
726e0ab1
PE
6284 * bidi.c (bidi_shelve_header_size): New constant.
6285 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6286 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6287
51f30bc5 6288 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6289 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6290 (overlay_strings):
6291 Don't update size of array until after memory allocation succeeds,
6292 because xmalloc/xrealloc may not return.
0065d054
PE
6293 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6294 now that we have proper integer overflow checking.
6295 (record_overlay_string, overlay_strings): Catch overflows when
6296 calculating size of overlay_str_buf.
726e0ab1 6297
0065d054
PE
6298 * callproc.c (Fcall_process): Check for size overflow when
6299 calculating size of args2.
6300 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6301 Normally we prefer signed values, but sticking with ptrdiff_t would
6302 require adding more-complicated checks.
726e0ab1
PE
6303
6304 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6305 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6306 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6307 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6308
6309 * character.c (Fstring): Check for size-calculation overflow.
6310
6311 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6312 unnecessary integer overflow. Check for size overflow.
6313 (encode_coding_object): Don't update size until xmalloc succeeds.
6314
6315 * composite.c (get_composition_id): Check for overflow in glyph
6316 length calculations.
6317
6318 Integer and memory overflow fixes for display code.
6319 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6320 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6321 (scrolling_window): Check for overflow in size calculations.
6322 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6323 Don't assume glyph table len fits in int.
6324 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6325 (row_table_size): Now ptrdiff_t, not int.
6326 (scrolling_window): Avoid overflow in size calculations.
6327 Don't update size until allocation succeeds.
6328 * fns.c (concat): Check for overflow in size calculations.
6329 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6330 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6331 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6332
6333 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6334 (get_doc_string): Check for size calculation overflow.
6335 Don't update size until allocation succeeds.
6336 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6337 EMACS_INT, where ptrdiff_t will do.
6338 (Fsubstitute_command_keys): Check for string overflow.
6339
6340 * editfns.c (set_time_zone_rule): Don't assume environment length
6341 fits in int.
6342 (message_length): Now ptrdiff_t, not int.
6343 (Fmessage_box): Don't update size until allocation succeeds.
6344 Don't assume message length fits in int.
6345 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6346
0065d054
PE
6347 * emacs.c (main): Do not reallocate argv, since there is a null at
6348 the end that can be overwritten, and this way there's no need to
6349 worry about size-calculation overflow.
6350 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6351
6352 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6353 alloc succeeds.
6354 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6355
6356 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6357 (x_set_scroll_bar_width, x_figure_window_size):
6358 Check for integer overflow.
6359 (x_set_alpha): Do not assume XINT fits in int.
6360
6361 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6362 This is for the members text_lines, text_cols, total_lines, total_cols,
6363 where the system imposes an 'int' limit.
6364
6365 * fringe.c (Fdefine_fringe_bitmap):
6366 Don't update size until alloc works.
6367
6368 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6369 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6370
6371 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6372 Check for size-calculation overflow.
6373 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6374 do, as we prefer signed integers.
6375 (id_to_widget.max_size, id_to_widget.used)
6376 (xg_store_widget_in_map, xg_remove_widget_from_map)
6377 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6378 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6379 Use and return ptrdiff_t, not int.
6380 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6381 * gtkutil.h: Change prototypes to match the above.
6382
6383 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6384 are duplicate now that they've been promoted to lisp.h.
6385 (x_allocate_bitmap_record, x_alloc_image_color)
6386 (make_image_cache, cache_image, xpm_load):
6387 Don't update size until alloc is done.
6388 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6389 (x_detect_edges):
3256efce 6390 Check for size calculation overflow.
726e0ab1
PE
6391 (ct_colors_allocated_max): New constant.
6392 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6393 overflow.
3256efce 6394
726e0ab1
PE
6395 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6396 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6397 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6398 Use ptrdiff_t, not int, to count maps.
6399 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6400 calculations. Don't update size until allocation succeeds.
6401 Redo calculations to avoid overflow.
726e0ab1
PE
6402 * keyboard.h: Change prototypes to match the above.
6403
6404 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6405 to count maps.
6406 (current_minor_maps): Check for size calculation overflow.
6407 * keymap.h: Change prototypes to match the above.
6408
6409 * lread.c (read1, init_obarray): Don't update size until alloc done.
6410
6411 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6412 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6413
726e0ab1
PE
6414 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6415 Now ptrdiff_t, not int.
6416 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6417 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6418
6419 * process.c (Fnetwork_interface_list): Check for overflow
6420 in size calculation.
6421
6422 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6423
6424 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6425 overflow. Don't bother calling xmalloc when xrealloc will do.
6426
6427 * search.c (Freplace_match): Check for size calculation overflow.
6428 (Fset_match_data): Don't assume list lengths fit in 'int'.
6429
6430 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6431 for command line length. Do not attempt to address one before the
6432 beginning of an array, as that's not portable.
6433
6434 * term.c (max_frame_lines): Remove; unused.
6435 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6436 not int.
6437 (encode_terminal_code, calculate_costs): Check for size
6438 calculation overflow.
6439 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6440 table lengths and related sizes. Don't update size until alloc
6441 done. Redo calculations to avoid overflow.
6442 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6443
6444 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6445 subtracting pointers.
6446 (gobble_line): Check for overflow more carefully. Don't update size
6447 until alloc done.
6448
6449 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6450 Don't update size until alloc done.
6451 Redo size calculations to avoid overflow.
6452 Check for size calculation overflow.
0065d054 6453 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6454
6455 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6456 Use ptrdiff_t, not int, for sizes.
6457 (store_mode_line_noprop_char): Don't update size until alloc done.
6458
0065d054
PE
6459 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6460 Use ptrdiff_t, not int, for sizes.
6461 (Finternal_make_lisp_face, cache_face):
6462 Check for size calculation overflow.
6463 (cache_face): Treat size calculation overflows as if they were
6464 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6465
6466 * xfns.c (x_encode_text, x_set_name_internal)
6467 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6468 sizes, since they can exceed INT_MAX in size. Check for size
6469 calculation overflow.
6470
0065d054
PE
6471 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6472 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6473 Don't update size until alloc done.
6474
0065d054 6475 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6476 as sprintf is limited to int lengths.
1d526e2f 6477
252c5ee1
PE
6478 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6479 (X_LONG_MIN): New macros.
864d7ce7
PE
6480 Use them to make the following changes clearer.
6481 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6482 This change doesn't affect the value now, but it may help remind
6483 future maintainers not to raise the value too much later.
6484 (SELECTION_QUANTUM): Remove, replacing with ...
6485 (selection_quantum): ... new function, which avoids overflow.
6486 All uses changed.
6487 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6488 assumption that selection length fits in 'int'.
6489 (x_reply_selection_request, x_handle_selection_request)
6490 (x_get_window_property, receive_incremental_selection)
6491 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6492 (lisp_data_to_selection_data, clean_local_selection_data):
6493 Use ptrdiff_t, not int, to record length of selection.
6494 (x_reply_selection_request, x_get_window_property)
6495 (receive_incremental_selection, x_property_data_to_lisp):
6496 Redo calculations to avoid overflow.
6497 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6498 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6499 something.
6500 (x_get_window_property, receive_incremental_selection)
6501 (lisp_data_to_selection_data, x_property_data_to_lisp):
6502 Check for size-calculation overflow.
6503 (x_get_window_property, receive_incremental_selection)
6504 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6505 Don't store size until memory allocation succeeds.
6506 (x_get_window_property): Plug memory leak on memory exhaustion.
6507 Don't double-block input; malloc is safe here. Don't assume 2**34
6508 - 4 fits in unsigned long. Add an xassert to check
6509 XGetWindowProperty overflow. Be more careful about overflow
6510 calculations, and distinguish size from memory overflow better.
6511 (receive_incremental_selection): When tracing, don't assume
6512 unsigned int is less than INT_MAX.
6513 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6514 harmful) conversions of unsigned short to int.
6515 (lisp_data_to_selection_data): Don't assume that integers
6516 in the range -65535 through -1 fit in an X unsigned short.
6517 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6518 result parameters unless successful. Rely on cons_to_unsigned
6519 to report problems with elements; the old code wasn't right anyway.
6520 (x_check_property_data): Check for int overflow; we cannot use
6521 a wider type due to X limits.
6522 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6523
726e0ab1 6524 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6525
0065d054
PE
6526 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6527 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6528 (x_color_cells): Don't store size until memory allocation succeeds.
6529 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6530 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6531 (x_term_init): Don't assume length fits in int (sprintf is limited
6532 to int size).
bc18e09d 6533
ebfa62c0
PE
6534 Use ptrdiff_t for composition IDs.
6535 * character.c (lisp_string_width):
6536 * composite.c (composition_table_size, n_compositions)
6537 (get_composition_id, composition_gstring_from_id):
6538 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6539 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6540 * window.c (Frecenter):
6541 Use ptrdiff_t, not int, for composition IDs.
6542 * composite.c (get_composition_id): Check for integer overflow.
6543 * composite.h: Adjust prototypes to match the above changes.
6544
d3411f89
PE
6545 Use ptrdiff_t for hash table indexes.
6546 * category.c (hash_get_category_set):
6547 * ccl.c (ccl_driver):
6548 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6549 * coding.c (coding_system_charset_list, detect_coding_system):
6550 * coding.h (struct coding_system.id):
6551 * composite.c (get_composition_id, gstring_lookup_cache):
6552 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6553 * image.c (xpm_get_color_table_h):
6554 * lisp.h (hash_lookup, hash_put):
6555 * minibuf.c (Ftest_completion):
6556 Use ptrdiff_t for hash table indexes, not int (which is too
6557 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6558 32-bit --with-wide-int hosts).
6559
e097a6fa
PE
6560 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6561 Add a FIXME comment about memory leaks.
6562 (syms_of_charset): Don't assume xmalloc returns.
6563
5637687f
PE
6564 Don't assume that stated character widths fit in int.
6565 * character.c (Fchar_width, c_string_width, lisp_string_width):
6566 * character.h (CHAR_WIDTH):
6567 * indent.c (MULTIBYTE_BYTES_WIDTH):
6568 Use sanitize_char_width to avoid undefined and/or bad behavior
6569 with outlandish widths.
a66cfb1c 6570 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6571 now that we have two such functions. All uses changed.
6572 (sanitize_char_width): New inline function.
6573
a2271ba2
PE
6574 Don't assume that tab-width fits in int.
6575 * character.h (sanitize_width): New inline function.
6576 (SANE_TAB_WIDTH): New macro.
6577 (ASCII_CHAR_WIDTH): Use it.
6578 * indent.c (sane_tab_width): Remove. All uses replaced by
6579 SANE_TAB_WIDTH (current_buffer).
6580 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6581
18c52557
PE
6582 * fileio.c: Integer overflow issues with file modes.
6583 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6584
caeeedc1
PE
6585 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6586 Remove unreachable code.
6587 (read_hex, load_charset_map_from_file): Check for integer overflow.
6588
6df6ae42 6589 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6590 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6591 (x_send_scroll_bar_event): Likewise. Check that the size does not
6592 exceed limits imposed by XClientMessageEvent, as well as the usual
6593 ptrdiff_t and size_t limits.
6594
b13995db
PE
6595 * keyboard.c: Overflow, signedness and related fixes.
6596 (make_lispy_movement): Use same integer type in forward decl
6597 that is used in the definition.
6598 (read_key_sequence, keyremap_step):
6599 Change bufsize argument back to int, undoing my 2011-03-30 change.
6600 We prefer signed types, and int is wide enough here.
6601 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6602 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6603 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6604 length, not size_t. Use ptrdiff_t for index, not int.
6605 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6606 possibility of integer overflow.
6607
13464394
PE
6608 Overflow, signedness and related fixes for images.
6609
6610 * dispextern.h (struct it.stack[0].u.image.image_id)
6611 (struct_it.image_id, struct image.id, struct image_cache.size)
6612 (struct image_cache.used, struct image_cache.ref_count):
6613 * gtkutil.c (update_frame_tool_bar):
6614 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6615 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6616 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6617 * nsmenu.m (update_frame_tool_bar):
6618 * xdisp.c (calc_pixel_width_or_height):
6619 * xfns.c (image_cache_refcount):
6620 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6621 on typical 64-bit hosts.
6622
6623 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6624 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6625 Omit unnecessary casts to int.
6626 (parse_image_spec): Check that integers fall into 'int' range
6627 when the callers expect that.
6628 (image_ascent): Redo ascent calculation to avoid int overflow.
6629 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6630 (lookup_image): Remove unnecessary tests.
6631 (xbm_image_p): Locals are now of int, not EMACS_INT,
6632 since parse_image_check makes sure they fit into int.
6633 (png_load, gif_load, svg_load_image):
6634 Prefer int to unsigned where either will do.
6635 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6636 old tiff_error_handler and tiff_warning_handler.
6637 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6638 stack buffer overflows. It uses only the features of vsnprintf
6639 that are common to both POSIX and native Microsoft.
6640 (tiff_error_handler, tiff_warning_handler): Use it.
6641 (tiff_load, gif_load, imagemagick_load_image):
6642 Don't assume :index value fits in 'int'.
6643 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6644 (imagemagick_load_image): Check that crop parameters fit into
6645 the integer types that MagickCropImage accepts. Don't assume
6646 Vimagemagick_render_type has a nonnegative value. Don't assume
6647 size_t fits in 'long'.
6648 (gs_load): Use printmax_t to print the widest integers possible.
6649 Check for integer overflow when computing image height and width.
6650
c11821d4
EZ
66512011-08-26 Eli Zaretskii <eliz@gnu.org>
6652
6653 * xdisp.c (redisplay_window): Don't force window start if point
6654 will be invisible in the resulting window. (Bug#9324)
6655
0c95fcf7
EZ
66562011-08-25 Eli Zaretskii <eliz@gnu.org>
6657
6658 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6659 the display spec is of the form `(space ...)'.
6660 (handle_display_spec): Return the value returned by
6661 handle_single_display_spec, not just 1 or zero.
6662 (handle_single_display_spec): If the display spec is of the form
6663 `(space ...)', and specifies display in the text area, return 2
6664 rather than 1.
fee65a97 6665 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6666 accurately, and prefer exact match for point under bidi.
6667 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6668
6669 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6670 into disp_prop; all users changed.
6671
6672 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6673 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6674 for the text covered by the display property.
6675
e4ed06f1
CY
66762011-08-25 Chong Yidong <cyd@stupidchicken.com>
6677
6678 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6679 Change return value to nil.
6680 (Frecord_buffer): Delete unused function.
6681
f67cdd7f
EZ
66822011-08-24 Eli Zaretskii <eliz@gnu.org>
6683
5980d4c6
EZ
6684 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6685 buffers, return left-to-right.
8610fe8b
EZ
6686 (set_cursor_from_row): Consider candidate row a win if its glyph
6687 represents a newline and point is on that newline. Fixes cursor
6688 positioning on the newline at EOL of R2L text within L2R
6689 paragraph, and vice versa.
6690 (try_cursor_movement): Check continued rows, in addition to
6691 continuation rows. Fixes unwarranted scroll when point enters a
6692 continued line of R2L text within an L2R paragraph, or vice versa.
6693 (cursor_row_p): Consider the case of point being equal to
6694 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6695 from the end of a short line to the beginning of a continued line
6696 of R2L text within L2R paragraph.
6697 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6698 composed characters.
5980d4c6 6699
f67cdd7f
EZ
6700 * bidi.c (bidi_check_type): Use xassert.
6701 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6702 members.
6703
bca633fb
EZ
67042011-08-23 Eli Zaretskii <eliz@gnu.org>
6705
6706 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6707 a character.
6708
4a5885a7
CY
67092011-08-23 Chong Yidong <cyd@stupidchicken.com>
6710
6711 * nsfont.m (ns_otf_to_script): Fix typo.
6712
0902a04e
KH
67132011-08-22 Kenichi Handa <handa@m17n.org>
6714
6715 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6716 extra slot even if the purpose is char-code-property-table.
6717
1a2e6670
EZ
67182011-08-23 Eli Zaretskii <eliz@gnu.org>
6719
8ddde651
EZ
6720 * xdisp.c (redisplay_window): When computing centering_position,
6721 account for the height of the header line. (Bug#8874)
6722
425cc014
EZ
6723 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6724 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6725 candidate is selected by the mouse, and that candidate has a
6726 composed character under the mouse.
6727
1a2e6670
EZ
6728 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6729 coordinates reported by pos-visible-in-window-p for a composed
6730 character in column zero.
6731
8b76d6f8
SM
67322011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6733
6734 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6735
dac347dd
EZ
67362011-08-22 Eli Zaretskii <eliz@gnu.org>
6737
6738 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6739 consider it a hit if to_charpos is anywhere in the range of the
6740 composed buffer positions.
6741
e013fb34
CY
67422011-08-22 Chong Yidong <cyd@stupidchicken.com>
6743
6744 * image.c (gif_load): Don't assume that each subimage has the same
6745 dimensions as the base image. Handle disposal method that is
6746 "undefined" by the gif spec (Bug#9335).
6747
bd1ba3e8
CY
67482011-08-20 Chong Yidong <cyd@stupidchicken.com>
6749
6750 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6751 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6752
54a1215b
EZ
67532011-08-19 Eli Zaretskii <eliz@gnu.org>
6754
823564e5
EZ
6755 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6756 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6757 from an Org mode buffer to a Speedbar frame.
6758
54a1215b
EZ
6759 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6760 a composition, take its buffer position from IT->cmp_it.charpos.
6761 Fixes cursor positioning at the beginning of a line that begins
6762 with a composed character.
6763
9778ebcc
EZ
67642011-08-18 Eli Zaretskii <eliz@gnu.org>
6765
0be6ee06
EZ
6766 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6767 character bidirectional type, use STRONG_L instead. Fixes crashes
6768 in a buffer produced by `describe-categories'.
6769
9778ebcc
EZ
6770 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6771 members before the level stack, so they would be saved and
6772 restored when copying iterator state. Fixes incorrect reordering
6773 around TABs covered by display properties.
6774
156bffbe
AS
67752011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6776
6b02f655 6777 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6778
72ad093b
CY
67792011-08-17 Chong Yidong <cyd@stupidchicken.com>
6780
6781 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6782 (internal_condition_case_2, internal_condition_case_n):
6783 Remove unnecessary aborts (Bug#9081).
72ad093b 6784
35774242
EZ
67852011-08-17 Eli Zaretskii <eliz@gnu.org>
6786
6787 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6788 has no `load' handler, try opening the file locally. (Bug#9311)
6789
db76dd85
KB
67902011-08-16 Ken Brown <kbrown@cornell.edu>
6791
6792 * gmalloc.c: Expand comment.
6793
b215eee5
EZ
67942011-08-16 Eli Zaretskii <eliz@gnu.org>
6795
6796 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6797 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6798
a4579d33
KB
67992011-08-16 Ken Brown <kbrown@cornell.edu>
6800
6801 Fix memory allocation problems in Cygwin build (Bug#9273).
6802
6803 * unexcw.c ( __malloc_initialized): Declare external variable.
6804 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6805
8b76d6f8
SM
6806 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6807 New variables.
a4579d33
KB
6808 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6809 dumped emacs.
6810 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6811 in the static heap.
6812 [CYGWIN] (special_realloc): New function.
6813 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6814 requests to realloc storage in the static heap.
6815
3ebec551
PE
68162011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6817
6818 * bidi.c (bidi_initialize): Remove unused local.
6819
9fd8be00
EZ
68202011-08-15 Eli Zaretskii <eliz@gnu.org>
6821
6b02f655
SM
6822 * bidimirror.h:
6823 * biditype.h: Remove file.
6824 * makefile.w32-in ($(BLD)/bidi.$(O)):
6825 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6826
6827 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6828
6829 * chartab.c: Improve commentary for the uniprop_table API.
6830
32413314
EZ
6831 * bidi.c (bidi_paragraph_init): Support zero value of
6832 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6833 (bidi_initialize): Use uniprop_table instead of including
6834 biditype.h and bidimirror.h.
32413314 6835
9fd8be00
EZ
6836 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6837 coordinates of the iterator when restoring from ppos_it.
6838 (Bug#9296)
6839
5cf2b69b
KH
68402011-08-14 Kenichi Handa <handa@m17n.org>
6841
6842 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6843 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6844
daf17d00
EZ
68452011-08-14 Eli Zaretskii <eliz@gnu.org>
6846
6847 * xdisp.c (move_it_in_display_line_to): Don't invoke
6848 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6849 ppos_it. Fixes vertical cursor motion when line beginning is
6850 covered by an image. (Bug#9296)
6851
08e3161a
JD
68522011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6853
6854 * nsterm.h (ns_run_ascript): Declare.
6855 (NSAPP_DATA2_RUNASSCRIPT): Define.
6856
6857 * nsfns.m (as_script, as_result, as_status): New static variables.
6858 (ns_run_ascript): New function.
5e617bc2 6859 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6860 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6861 the event loop. Get status from as_status (Bug#7276).
6862
6863 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6864 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6865 the event loop (Bug#7276).
6866
a3720aa2
AS
68672011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6868
6869 * gnutls.c (QCgnutls_bootprop_priority)
6870 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6871 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6872 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6873 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6874 (QCgnutls_bootprop_verify_hostname_error)
6875 (QCgnutls_bootprop_callbacks_verify): Rename from
6876 Qgnutls_bootprop_..., all uses changed.
6877
6878 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6879 uses changed.
6880
0a0d27fb
PE
68812011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6882
19d5c50c
PE
6883 * xfaces.c (Qframe_set_background_mode): Now static.
6884 * dispextern.h (Qframe_set_background_mode): Remove decl.
6885
0a0d27fb
PE
6886 * process.c (Fnetwork_interface_info): Declare local only if needed.
6887
377538cb
JD
68882011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6889
6890 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6891 (Fnetwork_interface_list): Allocate in increments of bytes instead
6892 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6893 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6894 sockaddr.
6895 (struct ifflag_def): notrailers is smart on OSX.
6896 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6897 Get hardware address with getifaddrs if available.
6898
08fff70c
EZ
68992011-08-12 Eli Zaretskii <eliz@gnu.org>
6900
6901 * xdisp.c (iterate_out_of_display_property): xassert that
6902 IT->position is set to within IT->object's boundaries. Break from
6903 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6904 when IT->position is set up wrongly due to some bug.
6905 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6906 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6907 entry. Force push_it to save on the stack the current
6908 buffer/string position, to be restored by pop_it. Fix flags in
6909 the iterator structure wrt the object coming from a display
6910 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6911 properties. (Bug#9284)
6912
7be1c708 69132011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6914
7be1c708
CY
6915 * fontset.c (fontset_get_font_group): Add proper type checks.
6916 (Bug#9172)
aac0c6e3 6917
7be1c708 69182011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6919
7be1c708
CY
6920 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6921 and LC_VERSION_MIN_MACOSX.
6922 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6923 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6924
97bb72a6
EZ
69252011-08-08 Eli Zaretskii <eliz@gnu.org>
6926
6927 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6928 no-display-properties-and-no-overlays under bidi display.
6929 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6930 properties and overlays.
97bb72a6 6931
d5617611
CY
69322011-08-08 Chong Yidong <cyd@stupidchicken.com>
6933
37e11a63
CY
6934 * editfns.c (Fset_time_zone_rule): Document relationship with the
6935 setenv function.
6936
d5617611
CY
6937 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6938 the font entity extracted from the cache (Bug#8109).
6939
58872834
CY
69402011-08-07 Chong Yidong <cyd@stupidchicken.com>
6941
6942 * composite.c (autocmp_chars): Don't reset point. That is done by
6943 restore_point_unwind (Bug#5984).
6944
75bfc667
JL
69452011-08-07 Juri Linkov <juri@jurta.org>
6946
6947 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6948 to show the arg `TIME' instead of `TIMEVAL'.
6949
d1410150
EZ
69502011-08-06 Eli Zaretskii <eliz@gnu.org>
6951
6952 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6953 display property strides EOL and includes a newline, as in
6954 longlines-mode. (Bug#9254)
75b771e4
EZ
6955 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6956 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6957
6958 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6959 is non-zero, even if the data buffer is NULL. Fixes a crash in
6960 vertical-motion with longlines-mode. (Bug#9254)
6961
35928349
EZ
69622011-08-05 Eli Zaretskii <eliz@gnu.org>
6963
ec7cc85b
EZ
6964 * bidi.c <bidi_cache_total_alloc>: Now static.
6965 (bidi_initialize): Initialize bidi_cache_total_alloc.
6966
8b76d6f8 6967 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6968 cache. (Bug#9221)
6969
6970 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6971 amount allocated this far in `bidi_cache_total_alloc'.
6972 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6973 non-zero, only free the data buffer without restoring the cache
6974 contents. All callers changed.
6975
6976 * dispextern.h (bidi_unshelve_cache): Update prototype.
6977
6978 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6979 (move_it_in_display_line, move_it_to)
6980 (move_it_vertically_backward, move_it_by_lines): Replace the call
6981 to xfree to an equivalent call to bidi_unshelve_cache.
6982 (move_it_in_display_line_to): Fix logic of returning
412b6358 6983 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6984
e2e2423b
EZ
69852011-08-05 Eli Zaretskii <eliz@gnu.org>
6986
6987 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6988 came from a string character with a `cursor' property. (Bug#9229)
6989
ae9e757a
JD
69902011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6991
6992 * Makefile.in (LIB_PTHREAD): New variable.
6993 (LIBES): Add LIB_PTHREAD (Bug#9216).
6994
6995 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6996 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6997
213bd7f2
AS
69982011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6999
6b02f655 7000 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7001
99aaf75f
JD
70022011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7003
7004 * xterm.c (x_find_topmost_parent): New function.
7005 (x_set_frame_alpha): Find topmost parent window with
7006 x_find_topmost_parent and set the property there also (bug#9181).
7007 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7008
c74e9d86
PE
70092011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7010
7011 * callproc.c (Fcall_process): Avoid vfork clobbering
7012 the local vars buffer, coding_systems, current_dir.
7013
640c8776
SM
70142011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7015
7016 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7017
f26d0e4c
PE
70182011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7019
8a10d76c
PE
7020 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7021 so that it is not optimized away.
7022
f26d0e4c
PE
7023 * xdisp.c (compute_display_string_pos): Remove unused local.
7024
55439c61
EZ
70252011-08-02 Eli Zaretskii <eliz@gnu.org>
7026
7027 Fix slow cursor motion and scrolling in large buffers with
7028 selective display, like Org Mode buffers. (Bug#9218)
7029
7030 * dispextern.h (struct bidi_it): New member disp_prop_p.
7031
7032 * xdisp.c: Remove one-slot cache of display string positions.
7033 (compute_display_string_pos): Accept an additional argument
5e617bc2 7034 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7035 for a display string or property. If found, set DISP_PROP_P
7036 non-zero.
7037
7038 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7039 DISP_PROP_P, and pass it to compute_display_string_pos.
7040 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7041 non-zero. All callers of bidi_fetch_char changed.
7042
fb33fa43
SM
70432011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7044
7045 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7046
b099e063
DM
70472010-12-03 Don March <don@ohspite.net>
7048
7049 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7050 last character M-[char] is translated to ESC [char] (bug#7541).
7051
5cc7f7af
KH
70522011-08-02 Kenichi Handa <handa@m17n.org>
7053
d0fffa3f 7054 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7055
7056 * chartab.c (uniprop_table): Make it non-static.
7057
525d5e6e
EZ
70582011-08-01 Eli Zaretskii <eliz@gnu.org>
7059
7060 * xdisp.c (forward_to_next_line_start): Accept additional argument
7061 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7062 on the newline.
7063 (reseat_at_next_visible_line_start): Use the bidi iterator state
7064 returned by forward_to_next_line_start to restore the state of
7065 it->bidi_it after backing up to previous newline. (Bug#9212)
7066
31011111
AS
70672011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7068
7069 * regex.c (re_comp): Protoize.
7070 (re_exec): Fix return type.
7071 (regexec): Fix type of `ret'. (Bug#9203)
7072
476371c4
PE
70732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7074
e5d76069
PE
7075 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7076 This is needed if max-image-size is a floating-point number.
7077
9a79b20c
AS
70782011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7079
7080 * print.c (print_object): Print empty symbol as ##.
7081
7082 * lread.c (read1): Read ## as empty symbol.
7083
d8c2fa78
AA
70842011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7085
7086 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7087 setting frame foreground color (Bug#9175).
7088 (x_set_background_color): Likewise.
7089
ffe57a7a
AA
7090 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7091 contents (Bug#9176).
7092 (EmacsTooltip -init): Remove bezels and add shadows to
7093 tooltip windows.
7094
bf3492a5
AA
7095 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7096 or scroll bar (Bug#8470).
7097
d55e9c53
AA
7098 * nsfont.m (nsfont_open): Remove assignment to voffset and
7099 unnecessary vars hshink, expand, hd, full_height, min_height.
7100 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7101
7102 * nsterm.h (nsfont_info): Remove voffset field.
7103
d8c2fa78 71042011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7105
7106 Implement strike-through and overline on NextStep (Bug#8863).
7107
7108 * nsfont.m (nsfont_open): Use underline position provided by font,
7109 instead of hard-coded value of 2.
7110 (nsfont_draw): Call ns_draw_text_decoration instead.
7111
7112 * nsterm.h: Add declaration for ns_draw_text_decoration.
7113
7114 * nsterm.m (ns_draw_text_decoration): New function for drawing
7115 underline, overline, and strike-through.
7116 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7117 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7118 accommodate underlining, etc.
4843aac3 7119
4cc60b9b
EZ
71202011-07-28 Eli Zaretskii <eliz@gnu.org>
7121
bc7ece87
EZ
7122 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7123 default.
4cc60b9b 7124
476371c4
PE
71252011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7126
66606eea
PE
7127 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7128 Without this fix, if a signal arrives just after memory fills up,
7129 'malloc' might be invoked reentrantly.
7130
476371c4
PE
7131 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7132 In other words, assume that every image size is allowed, on non-X
7133 hosts. This assumption is probably wrong, but it lets Emacs compile.
7134
f3fcc40d
AS
71352011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7136
7137 * regex.c (re_iswctype): Convert return values to boolean.
7138
350c992f
EZ
71392011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7140
7141 * xdisp.c (compute_display_string_pos): Don't use cached display
7142 string position if the buffer had its restriction changed.
7143 (Bug#9184)
7144
5266b4bb
PE
71452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7146
7147 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7148
2573a837 71492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7150
41f55ccd 7151 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7152
39e378da
PE
7153 * bidi.c: Integer size and overflow fixes.
7154 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7155 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7156 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7157 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7158 (bidi_find_other_level_edge):
7159 Use ptrdiff_t instead of EMACS_INT where either will do.
7160 This works better on 32-bit hosts configured --with-wide-int.
7161 (bidi_cache_ensure_space): Check for size-calculation overflow.
7162 Use % rather than repeated addition, for better worst-case speed.
7163 Don't set bidi_cache_size until after xrealloc returns, because it
7164 might not return.
7165 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7166 (bidi_cache_ensure_space): Also check that the bidi cache size
7167 does not exceed that of the largest Lisp string or buffer. See Eli
7168 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7169
5e927815
PE
7170 * alloc.c (__malloc_size_t): Remove.
7171 All uses replaced by size_t. See Andreas Schwab's note
7172 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7173
ca4aa935
PE
7174 * image.c: Improve checking for integer overflow.
7175 (check_image_size): Assume that f is nonnull, since
7176 it is always nonnull in practice. This is one less thing to
7177 worry about when checking for integer overflow later.
7178 (x_check_image_size): New function, which checks for integer
7179 overflow issues inside X.
7180 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7181 This removes the need for a memory_full check.
7182 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7183 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7184 (xbm_read_bitmap_data): Change locals back to 'int', since
7185 their values must fit in 'int'.
7186 (xpm_load_image, png_load, tiff_load):
7187 Invoke x_create_x_image_and_pixmap earlier,
7188 to avoid much needless work if the image is too large.
7189 (tiff_load): Treat overly large images as if
7190 x_create_x_image_and_pixmap failed, not as malloc failures.
7191 (gs_load): Use x_check_image_size.
7192
5f8f9cc2
PE
7193 * gtkutil.c: Omit integer casts.
7194 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7195 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7196
5adf60bc
PE
7197 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7198
c8907a93
PE
7199 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7200 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7201 would wrongly return t on a 64-bit host.
7202
e3c25c68
PE
7203 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7204 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7205 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7206 and therefore cause GCC to emit a bogus diagnostic in some cases.
7207
3f791afe
PE
7208 * image.c: Integer signedness and overflow and related fixes.
7209 This is not an exhaustive set of fixes, but it's time to
7210 record what I've got.
7211 (lookup_pixel_color, check_image_size): Remove redundant decls.
7212 (check_image_size): Don't assume that arbitrary EMACS_INT values
7213 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7214 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7215 (tiff_load, imagemagick_load_image):
7216 Check for overflow in size calculations.
7217 (x_create_x_image_and_pixmap): Remove unnecessary test for
7218 xmalloc returning NULL; that can't happen.
7219 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7220 (xpm_color_bucket): Use better integer hashing function.
7221 (xpm_cache_color): Don't possibly over-allocate memory.
7222 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7223 (gif_memory_source):
7224 Use ptrdiff_t, not int or size_t, to record sizes.
7225 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7226 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7227 either works, as we prefer signed integers.
7228 (tiff_read_from_memory, tiff_write_from_memory):
7229 Return tsize_t, not size_t, since that's what the TIFF API wants.
7230 (tiff_read_from_memory): Don't fail simply because the read would
7231 go past EOF; instead, return a short read.
7232 (tiff_load): Omit no-longer-needed casts.
7233 (Fimagemagick_types): Don't assume size fits into 'int'.
7234
3cc5a532
PE
7235 Improve hashing quality when configured --with-wide-int.
7236 * fns.c (hash_string): New function, taken from sxhash_string.
7237 Do not discard information about ASCII character case; this
7238 discarding is no longer needed.
7239 (sxhash-string): Use it. Change sig to match it. Caller changed.
7240 * lisp.h: Declare it.
7241 * lread.c (hash_string): Remove, since we now use fns.c's version.
7242 The fns.c version returns a wider integer if --with-wide-int is
7243 specified, so this should help the quality of the hashing a bit.
7244
b312a492
PE
7245 * emacs.c: Integer overflow minor fix.
7246 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7247 Define only if GNU_LINUX.
7248 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7249
dfd153ae
PE
7250 * dispnew.c: Integer signedness and overflow fixes.
7251 Remove unnecessary forward decls, that were a maintenance hassle.
7252 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7253 All uses changed.
7254 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7255 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7256 (prepare_desired_row, line_draw_cost):
7257 Use int, not unsigned, where either works.
7258 (save_current_matrix, restore_current_matrix):
7259 Use ptrdiff_t, not size_t, where either works.
7260 (init_display): Check for overflow more accurately, and without
7261 relying on undefined behavior.
7262
a81d11a3
PE
7263 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7264 Remove, replacing with the new symbols in lisp.h. All uses changed.
7265 * fileio.c (make_temp_name):
7266 * filelock.c (lock_file_1, lock_file):
7267 * xdisp.c (message_dolog):
7268 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7269 Use pMd etc. instead.
7270 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7271 replacing the pWIDE etc. symbols removed from editfns.c.
7272
3300e6fd
PE
7273 * keyboard.h (num_input_events): Now uintmax_t.
7274 This is (very slightly) less likely to mess up due to wraparound.
7275 All uses changed.
7276
fd05c7e9
PE
7277 * buffer.c: Integer signedness fixes.
7278 (alloc_buffer_text, enlarge_buffer_text):
7279 Use ptrdiff_t rather than size_t when either will do, as we prefer
7280 signed integers.
7281
903fe15d
PE
7282 * alloc.c: Integer signedness and overflow fixes.
7283 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7284 (__malloc_size_t): Default to size_t, not to int.
7285 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7286 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7287 Prefer ptrdiff_t to size_t when either would do, as we prefer
7288 signed integers.
7289 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7290 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7291 Now const. Initialize with values that are in range even if char
7292 is signed.
7293 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7294 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7295 These functions do the right thing with sizes > 2**32.
7296 (check_depth): Now ptrdiff_t, not int.
7297 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7298 Adjust to new way of storing sizes. Check for size overflow bugs
7299 in rest of code.
7300 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7301 slightly wrong anyway, as it missed one instance of
7302 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7303 (refill_memory_reserve): Omit needless cast to size_t.
7304 (mark_object_loop_halt): Mark as externally visible.
7305
ac82cc6a
PE
7306 * xselect.c: Integer signedness and overflow fixes.
7307 (Fx_register_dnd_atom, x_handle_dnd_message):
7308 Use ptrdiff_t, not size_t, since we prefer signed.
7309 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7310 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7311 x_dnd_atoms_size and x_dnd_atoms_length.
7312
c2d1e36d
PE
7313 * doprnt.c: Prefer signed to unsigned when either works.
7314 * eval.c (verror):
7315 * doprnt.c (doprnt):
7316 * lisp.h (doprnt):
7317 * xdisp.c (vmessage):
7318 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7319 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7320 prefer signed arithmetic to avoid comparison confusion.
7321 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7322 but is a bit tricky.
7323
0e926e56
PE
7324 Assume freestanding C89 headers, string.h, stdlib.h.
7325 * data.c, doprnt.c, floatfns.c, print.c:
7326 Include float.h unconditionally.
7327 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7328 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7329 * regex.c: Likewise for stddef.h, string.h.
7330 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7331 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7332 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7333 (STDC_HEADERS): Remove obsolete defines.
7334 * sysdep.c: Include limits.h unconditionally.
7335
9cfdb3ec
PE
7336 Assume support for memcmp, memcpy, memmove, memset.
7337 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7338 * regex.c (memcmp, memcpy):
7339 Remove; we assume C89 now.
7340
7341 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7342 (__malloc_safe_bcopy): Remove; no longer needed.
7343
cf950e6b 7344 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7345 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7346 well either way, and we prefer signed to unsigned.
7347
dbf38e02
LMI
73482011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7349
7350 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7351 closes the connection while we're reading (bug#9182).
7352
d6f0886c 73532011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7354
d6f0886c
JD
7355 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7356 are specified (Bug#9168).
24e0f6b1 7357
2eb1f9e6
PE
73582011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7359
7360 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7361 Found by GCC static checking and --with-wide-int on a 32-bit host.
7362
22381272 73632011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7364
7365 * xdisp.c (compute_display_string_pos): Fix logic of caching
7366 previous display string position. Initialize cached_prev_pos to
7367 -1. Fixes slow-down at the beginning of a buffer.
7368
f25e39b4
EZ
73692011-07-24 Eli Zaretskii <eliz@gnu.org>
7370
7371 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7372 for attrs[LFACE_FONTSET_INDEX].
7373
04c4b52e
PE
73742011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7375
7376 * xml.c (parse_region): Remove unused local
7377 that was recently introduced.
7378
c1734fbd
EZ
73792011-07-23 Eli Zaretskii <eliz@gnu.org>
7380
be18c5a5
EZ
7381 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7382 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7383
c1734fbd
EZ
7384 * xdisp.c (move_it_in_display_line_to): Record the best matching
7385 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7386 exit if none of the characters scanned was an exact match.
7387 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7388 when exact match is impossible due to invisible text, and the
7389 lines are truncated.
7390
a258d627
JD
73912011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7392
7393 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7394 for OSX >= 10.7.
7395
b6d5a689
EZ
73962011-07-22 Eli Zaretskii <eliz@gnu.org>
7397
0f74f785
EZ
7398 Fix a significant slow-down of cursor motion with C-n, C-p,
7399 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7400 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7401 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7402 (next_element_from_buffer): Call compute_stop_pos_backwards to
7403 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7404 base_level_stop.
7405 (reseat): Don't look for prev_stop, as that could mean a very long
7406 run.
7407 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7408 <cached_disp_overlay_modiff>: Cache for last found display string
7409 position.
551918c1 7410 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7411 about the same buffer in the same area of character positions, and
7412 the buffer wasn't changed since the time the display string
7413 position was cached.
551918c1 7414
b2d0c91a
EZ
74152011-07-22 Eli Zaretskii <eliz@gnu.org>
7416
7417 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7418 is an integer, which is important for empty lines. (Bug#9149)
7419
043604ee
CY
74202011-07-22 Chong Yidong <cyd@stupidchicken.com>
7421
7422 * frame.c (Fmodify_frame_parameters): In tty case, update the
7423 default face if necessary (Bug#4238).
7424
da4adb04
CY
74252011-07-21 Chong Yidong <cyd@stupidchicken.com>
7426
7427 * editfns.c (Fstring_to_char): No need to explain what a character
7428 is in the docstring (Bug#6576).
7429
9abd0532
LMI
74302011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7431
7432 * xml.c (parse_region): Make sure we always return a tree.
7433
36881d16
HK
74342011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7435
7436 * xml.c (parse_region): If a document contains only comments,
7437 return that, too.
7438
1e98674d
LMI
74392011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7440
7441 * xml.c (make_dom): Return comments, too.
7442
590bd467
PE
74432011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7444
7445 Port to OpenBSD.
7446 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7447 and the surrounding thread.
7448 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7449 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7450 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7451 timer goes off.
7452 * s/openbsd.h (BROKEN_SIGIO): Define.
7453 * unexelf.c (unexec) [__OpenBSD__]:
7454 Don't update the .mdebug section of the Alpha COFF symbol table.
7455
f41628b2
LMI
74562011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7457
7458 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7459 (bug#8460).
7460
b59b67c5
PE
74612011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7462
15e3a074
PE
7463 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7464 This fixes some race conditions on the permissions of any newly
7465 created file.
7466
41bed37d
PE
7467 * alloc.c (valid_pointer_p): Use pipe, not open.
7468 This fixes some permissions issues when debugging.
7469
b59b67c5
PE
7470 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7471 If fchown fails to set both uid and gid, try to set just gid,
7472 as that is sometimes allowed. Adjust the file's mode to eliminate
7473 setuid or setgid bits that are inappropriate if fchown fails.
7474
925a6be7
SM
74752011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7476
7477 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7478 to compare Lisp_Objects.
7479 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7480 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7481 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7482
52968808
AS
74832011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7484
0a6a104b
AS
7485 * lread.c (read_integer): Unread even EOF character.
7486 (read1): Likewise. Properly record start position of symbol.
7487
52968808
AS
7488 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7489 symbol character follows.
7490
9e381cdd
PE
74912011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7492
7493 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7494 This works around a problem with the previous change to Fcopy_file.
7495 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7496 and without this change, GCC might complain about discarding
7497 fchown's return value.
7498
b5641435
JB
74992011-07-16 Juanma Barranquero <lekktu@gmail.com>
7500
7501 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7502
a8031457
PE
75032011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7504
7505 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7506
dd889327
LMI
75072011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7508
750c33f7
LMI
7509 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7510 it's used from the C level.
7511
dd889327
LMI
7512 * process.c: Use the same condition for POLL_FOR_INPUT in both
7513 keyboard.c and process.c (bug#1858).
7514
87e86684
LM
75152011-07-09 Lawrence Mitchell <wence@gmx.li>
7516
7517 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7518 (Fgnutls_boot): Use it.
7519
64348f40
AS
75202011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7521
7522 * doc.c (Fsubstitute_command_keys): Revert last change.
7523
1d698799
LMI
75242011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7525
f863868c
LMI
7526 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7527 quotes the next character, and doesn't affect other longer
7528 sequences (bug#8935).
7529
1d698799
LMI
7530 * lread.c (syms_of_lread): Clarify that is isn't only
7531 `eval-buffer' and `eval-defun' that's affected by
7532 `lexical-binding' (bug#8460).
7533
aa4b6df6
EZ
75342011-07-15 Eli Zaretskii <eliz@gnu.org>
7535
7536 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7537 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7538
5d856da6
PE
75392011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7540
ad6042bb
PE
7541 Fix minor problems found by static checking.
7542 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7543 (elsz): Now a signed constant, not a size_t var. We prefer signed
7544 types to unsigned, to avoid integer comparison confusion. Without
7545 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7546 "cannot optimize loop, the loop counter may overflow", a symptom
7547 of the confusion.
f00bbb22 7548 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7549 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7550
6468f31c
LMI
75512011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7552
49080b10
LMI
7553 * search.c (Fre_search_backward): Mention `case-fold-search' in
7554 all the re_search_* functions (bug#8138).
7555
6468f31c
LMI
7556 * keyboard.c (Fopen_dribble_file): Document when the file is
7557 closed (bug#8056).
7558
c965adc5
EZ
75592011-07-14 Eli Zaretskii <eliz@gnu.org>
7560
df9733bf
EZ
7561 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7562 bidi_cache_idx.
7563
0bb23927
EZ
7564 Support bidi reordering of display and overlay strings.
7565 * xdisp.c (compute_display_string_pos)
7566 (compute_display_string_end): Accept additional argument STRING.
7567 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7568 (reseat_to_string): Initialize bidi_it->string.s and
7569 bidi_it->string.schars.
7570 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7571 NULL (avoids a crash in bidi_paragraph_init).
7572 Initialize itb.string.lstring.
0bb23927
EZ
7573 (init_iterator): Call bidi_init_it only of a valid
7574 buffer position was specified. Initialize paragraph_embedding to
7575 L2R.
7576 (reseat_to_string): Initialize the bidi iterator.
7577 (display_string): If we need to ignore text properties of
7578 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7579 original value of -1 will not work with bidi.)
7580 (compute_display_string_pos): First arg is now struct
7581 `text_pos *'; all callers changed. Support display properties on
7582 Lisp strings.
7583 (compute_display_string_end): Support display properties on Lisp
7584 strings.
7585 (init_iterator, reseat_1, reseat_to_string): Initialize the
7586 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7587 when iterating on a string not from display properties).
640c8776
SM
7588 (compute_display_string_pos, compute_display_string_end):
7589 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7590 arrow keys.
7591 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7592 base_level_stop; instead, set base_level_stop to BEGV.
7593 Fixes crashes in vertical-motion.
0bb23927
EZ
7594 (next_element_from_buffer): Improve commentary for when
7595 the iterator is before prev_stop.
7596 (init_iterator): Initialize bidi_p from the default value of
7597 bidi-display-reordering, not from buffer-local value. Use the
7598 buffer-local value only if initializing for buffer iteration.
7599 (handle_invisible_prop): Support invisible properties on strings
7600 that are being bidi-reordered.
7601 (set_iterator_to_next): Support bidi reordering of C strings and
7602 Lisp strings.
7603 (next_element_from_string): Support bidi reordering of Lisp
7604 strings.
7605 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7606 (display_string): Support display of R2L glyph rows.
7607 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7608 (init_iterator): Don't initialize it->bidi_p for strings
7609 here.
7610 (reseat_to_string): Initialize it->bidi_p for strings here.
7611 (next_element_from_string, next_element_from_c_string)
7612 (next_element_from_buffer): Add xassert's for correspondence
7613 between IT's object being iterated and it->bidi_it.string
7614 structure.
7615 (face_before_or_after_it_pos): Support bidi iteration.
7616 (next_element_from_c_string): Handle the case of the first string
7617 character that is not the first one in the visual order.
7618 (get_visually_first_element): New function, refactored from common
7619 parts of next_element_from_buffer, next_element_from_string, and
7620 next_element_from_c_string.
7621 (tool_bar_lines_needed, redisplay_tool_bar)
7622 (display_menu_bar): Force left-to-right direction. Add a FIXME
7623 comment for making that be controlled by a user option.
7624 (push_it, pop_it): Save and restore the state of the
7625 bidi iterator. Save and restore the bidi_p flag.
7626 (pop_it): Iterate out of display property for string iteration as
7627 well.
7628 (iterate_out_of_display_property): Support iteration over strings.
7629 (handle_single_display_spec): Set up it->bidi_it for iteration
7630 over a display string, and call bidi_init_it.
7631 (handle_single_display_spec, next_overlay_string)
7632 (get_overlay_strings_1, push_display_prop): Set up the bidi
7633 iterator for displaying display or overlay strings.
7634 (forward_to_next_line_start): Don't use the shortcut if
7635 bidi-iterating.
7636 (back_to_previous_visible_line_start): If handle_display_prop
7637 pushed the iterator stack, restore the internal state of the bidi
7638 iterator by calling bidi_pop_it same number of times.
7639 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7640 and we are bidi-iterating, don't decrement the iterator position;
7641 instead, set the first_elt flag in the bidi iterator, to produce
7642 the same effect.
7643 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7644 (push_display_prop): xassert that we are iterating a buffer.
7645 (push_it, pop_it): Save and restore paragraph_embedding member.
7646 (handle_single_display_spec, next_overlay_string)
7647 (get_overlay_strings_1, reseat_1, reseat_to_string)
7648 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7649 correctly. Don't assume unibyte strings are not bidi-reordered.
7650 (compute_display_string_pos)
7651 (compute_display_string_end): Fix handling the case of C string.
7652 (push_it, pop_it): Save and restore from_disp_prop_p.
7653 (handle_single_display_spec, push_display_prop): Set the
7654 from_disp_prop_p flag.
7655 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7656 (pop_it): Call iterate_out_of_display_property only if we are
7657 popping after iteration over a string that came from a display
7658 property. Fix a typo in popping stretch info. Add an assertion
7659 for verifying that the iterator position is in sync with the bidi
7660 iterator.
7661 (handle_single_display_spec, get_overlay_strings_1)
7662 (push_display_prop): Fix initialization of paragraph direction for
7663 string when that of the parent object is not yet determined.
7664 (reseat_1): Call bidi_init_it to resync the bidi
7665 iterator with IT's position. (Bug#7616)
7666 (find_row_edges): If ROW->start.pos gives position
7667 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7668 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7669 Reset the from_disp_prop_p flag.
7670 (SAVE_IT, RESTORE_IT): New macros.
7671 (pos_visible_p, face_before_or_after_it_pos)
7672 (back_to_previous_visible_line_start)
7673 (move_it_in_display_line_to, move_it_in_display_line)
7674 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7675 (try_scrolling, redisplay_window, display_line): Use them when
7676 saving a temporary copy of the iterator and restoring it back.
7677 (back_to_previous_visible_line_start, reseat_1)
7678 (init_iterator): Empty the bidi cache "stack".
7679 (move_it_in_display_line_to): If iterator ended up at
7680 EOL, but we never saw any buffer positions smaller than
7681 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7682 motion in bidi-reordered lines.
7683 (move_it_in_display_line_to): Record prev_method and prev_pos
7684 immediately before the call to set_iterator_to_next. Fixes cursor
7685 motion in bidi-reordered lines with stretch glyphs and strings
7686 displayed in margins. (Bug#8133) (Bug#8867)
7687 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7688 TO_CHARPOS.
640c8776
SM
7689 (pos_visible_p): Support positions in bidi-reordered lines.
7690 Save and restore bidi cache.
0bb23927
EZ
7691
7692 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7693 (bidi_paragraph_info): Delete unused struct.
7694 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7695 (bidi_cache_start): New variable.
7696 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7697 to zero.
7698 (bidi_cache_fetch_state, bidi_cache_search)
7699 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7700 (bidi_cache_find, bidi_peek_at_next_level)
7701 (bidi_level_of_next_char, bidi_find_other_level_edge)
7702 (bidi_move_to_visually_next): Compare cache index with
7703 bidi_cache_start rather than with zero.
7704 (bidi_fetch_char): Accept new argument STRING; all callers
7705 changed. Support iteration over a string. Support strings with
7706 display properties. Support unibyte strings. Fix the type of
7707 `len' according to what STRING_CHAR_AND_LENGTH expects.
7708 (bidi_paragraph_init, bidi_resolve_explicit_1)
7709 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7710 (bidi_level_of_next_char, bidi_move_to_visually_next):
7711 Support iteration over a string.
0bb23927
EZ
7712 (bidi_set_sor_type, bidi_resolve_explicit_1)
7713 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7714 can now be zero (for strings); special values 0 and -1 were
7715 changed to -1 and -2, respectively.
7716 (bidi_char_at_pos): New function.
7717 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7718 Call it instead of FETCH_MULTIBYTE_CHAR.
7719 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7720 initialized to valid values.
7721 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7722 values.
7723 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7724 the test for valid cached positions. Fix the logic for looking up
7725 the sentinel state in the cache. GCPRO the Lisp string we are
7726 iterating.
7727 (bidi_push_it, bidi_pop_it): New functions.
7728 (bidi_initialize): Initialize the bidi cache start stack pointer.
7729 (bidi_cache_ensure_space): New function, refactored from part of
7730 bidi_cache_iterator_state. Don't assume the required size is just
7731 one BIDI_CACHE_CHUNK away.
7732 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7733 (bidi_count_bytes, bidi_char_at_pos): New functions.
7734 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7735 always valid if bidi_cache_idx is valid.
7736 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7737 is valid if it's going to be used.
7738 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7739 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7740 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7741 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7742 (bidi_find_other_level_edge, bidi_cache_start_stack):
7743 All variables related to cache indices are now EMACS_INT.
c965adc5 7744
0bb23927
EZ
7745 * dispextern.h (struct bidi_string_data): New structure.
7746 (struct bidi_it): New member `string'. Make flag members be 1-bit
7747 fields, and put them last in the struct.
640c8776
SM
7748 (compute_display_string_pos, compute_display_string_end):
7749 Update prototypes.
0bb23927
EZ
7750 (bidi_push_it, bidi_pop_it): Add prototypes.
7751 (struct iterator_stack_entry): New members bidi_p,
7752 paragraph_embedding, and from_disp_prop_p.
7753 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7754 (bidi_shelve_cache, bidi_unshelve_cache):
7755 Declare prototypes.
0bb23927
EZ
7756
7757 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7758 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7759 and vector-like objects.
7760
7761 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7762 cache around display iteration.
7763
7764 * window.c (Fwindow_end, window_scroll_pixel_based)
7765 (displayed_window_lines, Frecenter): Save and restore the bidi
7766 cache around display iteration.
7767
3bbd2265
LMI
77682011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7769
7770 * editfns.c (Fdelete_region): Clarify the use of the named
7771 parameters (bug#6788).
7772
adc47434
MR
77732011-07-14 Martin Rudalics <rudalics@gmx.at>
7774
7775 * indent.c (Fvertical_motion): Set and restore w->pointm when
7776 saving and restoring the window's buffer (Bug#9006).
7777
837c31f8
LMI
77782011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7779
7780 * editfns.c (Fstring_to_char): Clarify just what is returned
7781 (bug#6576). Text by Eli Zaretskii.
7782
ac389d0c
JB
77832011-07-13 Juanma Barranquero <lekktu@gmail.com>
7784
7785 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7786
0be0ce47
EZ
77872011-07-13 Eli Zaretskii <eliz@gnu.org>
7788
7789 * buffer.c (mmap_find): Fix a typo.
7790
cd18e7e3
JB
77912011-07-13 Johan Bockgård <bojohan@gnu.org>
7792
7793 Fix execution of x selection hooks.
7794 * xselect.c (Qx_lost_selection_functions)
7795 (Qx_sent_selection_functions): New vars.
7796 (syms_of_xselect): DEFSYM them.
7797 (x_handle_selection_request): Pass Qx_sent_selection_functions
7798 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7799 (x_handle_selection_clear,x_clear_frame_selections):
7800 Pass Qx_lost_selection_functions rather than
7801 Vx_lost_selection_functions to Frun_hook_with_args.
7802
47ea7f44
PE
78032011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7804
ac389d0c 7805 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7806 The old code sometimes used this field without initializing it.
7807
47ea7f44
PE
7808 * alloc.c (gc_sweep): Don't read past end of array.
7809 In theory, the old code could also have corrupted Emacs internals,
7810 though it'd be very unlikely.
7811
bc985c87
AS
78122011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7813
7814 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7815 argument. (Bug#4026)
bc985c87 7816
0cf34688
LMI
78172011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7818
b3dadd76
LMI
7819 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7820 key" (bug#4257).
7821
0cf34688
LMI
7822 * window.c (Fset_window_start): Doc fix (bug#4199).
7823 (Fset_window_hscroll): Ditto.
7824
270768cd
PE
78252011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7826
077e3dda 7827 Fix minor new problems caught by GCC 4.6.1.
270768cd 7828 * term.c (init_tty): Remove unused local.
490011a6 7829 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7830 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7831 not used otherwise.
270768cd 7832
b1f58454
CY
78332011-07-12 Chong Yidong <cyd@stupidchicken.com>
7834
7835 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7836
22b9578d
LMI
78372011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7838
6e70ab07
LMI
7839 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7840 are the mini-buffer and the echo area (bug#3320).
7841
22b9578d
LMI
7842 * term.c (init_tty): Remove support for supdup, c10 and perq
7843 terminals, which are no longer supported (bug#1482).
7844
8974cc9f
JB
78452011-07-10 Johan Bockgård <bojohan@gnu.org>
7846
7847 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7848
a560d974
JD
78492011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7850
7851 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7852 for non-popups (Bug#3642).
7853
1dae0f0a
AS
78542011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7855
268c2c36 7856 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7857 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7858 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7859 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7860 * data.c (fmod): Likewise.
7861 * dispnew.c (swap_glyphs_in_rows): Likewise.
7862 * emacs.c (memory_warning_signal): Likewise.
7863 * floatfns.c (float_error): Likewise.
7864 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7865 (otf_open, font_otf_capability, generate_otf_features)
7866 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7867 Likewise.
7868 * image.c (pbm_read_file): Likewise.
7869 * indent.c (string_display_width): Likewise.
7870 * intervals.c (check_for_interval, search_for_interval)
7871 (inc_interval_count, count_intervals, root_interval)
7872 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7873 * lread.c (defalias): Likewise.
268c2c36 7874 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7875 * regex.c (set_image_of_range_1, set_image_of_range)
7876 (regex_grow_registers): Likewise.
7877 * sysdep.c (strerror): Likewise.
7878 * termcap.c (valid_filename_p, tprint, main): Likewise.
7879 * tparam.c (main): Likewise.
7880 * unexhp9k800.c (run_time_remap, save_data_space)
7881 (update_file_ptrs, read_header, write_header, calculate_checksum)
7882 (copy_file, copy_rest, display_header): Likewise.
7883 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7884 Likewise.
7885 * xdisp.c (check_it): Likewise.
7886 * xfaces.c (register_color, unregister_color, unregister_colors):
7887 Likewise.
7888 * xfns.c (print_fontset_result): Likewise.
7889 * xrdb.c (member, fatal, main): Likewise.
7890
99033785
PE
78912011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7892
7893 Fix minor problems found by static checking (Bug#9031).
7894 * chartab.c (char_table_set_range, map_sub_char_table):
7895 Remove unused locals.
7896 (uniprop_table): Now static.
7897 * composite.c (_work_char): Remove unused static var.
7898
9cb2ac56
JB
78992011-07-09 Juanma Barranquero <lekktu@gmail.com>
7900
7901 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7902
f25661f0
JD
79032011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7904
7905 * gtkutil.c (qttip_cb): Remove code without function.
7906
8278c4fe
EZ
79072011-07-09 Eli Zaretskii <eliz@gnu.org>
7908
7909 * w32.c (pthread_sigmask): New stub.
7910
1692ae2d 79112011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7912
8a6ebd58 7913 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7914 sigprocmask is portable only for single-threaded applications, and
7915 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7916 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7917 (LIBES): Use it.
7918 * callproc.c (Fcall_process):
7919 * process.c (create_process):
7920 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7921 Use pthread_sigmask, not sigprocmask.
123403e4 7922
1b854618
JD
79232011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7924
7925 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7926 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7927 wrong (Bug#8591).
7928
3fe4b549
JD
79292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7930
0ce7e563
JD
7931 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7932 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7933 (xg_hide_tooltip): Fix comment.
7934
3fe4b549
JD
7935 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7936 in registerServicesMenuSendTypes.
7937 (validRequestorForSendType): Don't check ns_return_types.
7938
7939 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7940 ns_return_type.
7941
5df75e47
JR
79422011-07-08 Jason Rumney <jasonr@gnu.org>
7943
22610910
JR
7944 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7945 SH_SHOW for hidden windows (Bug#5482).
7946
5df75e47
JR
7947 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7948 frame struct members of non-existent frames (Bug#6284).
7949
699c10bd
JD
79502011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7951
4393663b
JD
7952 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7953 variable firstTime not needed on OSX >= 10.6.
7954 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7955 >= 10.5. Use setKnobProportion, setDoubleValue.
7956
7957 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7958 (MAC_OS_X_VERSION_10_5): Define if not defined.
7959 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7960 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7961 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7962
7963 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 7964 cString and lossyCString on OSX >= 10.4.
4393663b 7965
58179cce 7966 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7967 sizeToFit on OSX >= 10.2.
7968
7969 * nsimage.m (allocInitFromFile): Don't use deprecated method
7970 bestRepresentationForDevice on OSX >= 10.6.
7971
7972 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7973 to avoid warning.
7974
7975 * emacs.c: Declare unexec_init_emacs_zone.
7976
a63e0781
JD
7977 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7978
699c10bd
JD
7979 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7980
7981 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7982 on svcsMenu (Bug#8842).
7983
7984 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7985 ns_return_types.
7986 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7987
7988 * nsterm.m (QUTF8_STRING): Declare.
7989 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7990 (validRequestorForSendType): Return type is (id).
7991 Change indexOfObjectIdenticalTo to indexOfObject.
7992 Check if we have local selection before returning self (Bug#8842).
7993 (writeSelectionToPasteboard): Put local selection into paste board
7994 if we have a local selection (Bug#8842).
7995 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7996
7997 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7998 (ns_get_local_selection): Declare.
7999
54e10184
LMI
80002011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8001
9888ff71
LMI
8002 * keymap.c (describe_map_tree): Don't insert a double newline at
8003 the end of the buffer (bug#1169) and return whether we inserted
8004 something.
8005
54e10184
LMI
8006 * callint.c (Fcall_interactively): Change "reading args" to
8007 "providing args" to try to clarify what it does (bug#1010).
8008
15fa4783
KH
80092011-07-07 Kenichi Handa <handa@m17n.org>
8010
8011 * composite.c (composition_compute_stop_pos): Ignore a static
8012 composition starting before CHARPOS (Bug#8915).
8013
8014 * xdisp.c (handle_composition_prop): Likewise.
8015
a8815b00
EZ
80162011-07-07 Eli Zaretskii <eliz@gnu.org>
8017
8018 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8019 (Bug#9015)
8020
ef7b981d 80212011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8022
8023 * character.h (unicode_category_t): New enum type.
8024
8025 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8026 (Qchar_code_property_table): New variable.
8027 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8028 (UNIPROP_COMPRESSED_FORM_P): New macros.
8029 (char_table_ascii): Uncompress the compressed values.
8030 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8031 Uncompress the compressed values.
ac389d0c 8032 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8033 (char_table_ref_and_range): Uncompress the compressed values.
8034 (sub_char_table_set): New arg is_uniprop. Callers changed.
8035 Uncompress the compressed values.
8036 (sub_char_table_set_range): Args changed. Callers changed.
8037 (char_table_set_range): Adjuted for the above change.
8038 (map_sub_char_table): Delete args default_val and parent. Add arg
8039 top. Give decoded values to a Lisp function.
640c8776 8040 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8041 values to a Lisp function. Gcpro more variables.
8042 (uniprop_table_uncompress)
8043 (uniprop_decode_value_run_length): New functions.
8044 (uniprop_decoder, uniprop_decoder_count): New variables.
8045 (uniprop_get_decoder, uniprop_encode_value_character)
8046 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8047 New functions.
8048 (uniprop_encoder, uniprop_encoder_count): New variables.
8049 (uniprop_get_encoder, uniprop_table)
8050 (Funicode_property_table_internal, Fget_unicode_property_internal)
8051 (Fput_unicode_property_internal): New functions.
8052 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8053 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8054 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8055 char-code-property-alist.
8056
640c8776 8057 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8058 Vunicode_category_table.
8059
640c8776 8060 * font.c (font_range): Adjust for the change of
c805dec0
KH
8061 Vunicode_category_table.
8062
76b397fb
DN
80632011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8064
8065 * m/iris4d.h: Remove file, move contents ...
8066 * s/irix6-5.h: ... here.
8067
22b4128e
PE
80682011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8069
8070 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8071 * alloc.c (mark_buffer):
8072 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8073 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8074 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8075 This isn't true in general, and it's particularly not true
8076 if Emacs is configured with --with-wide-int.
8077 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8078 New macros, used in the buffer.c change.
8079
869795d6
JD
80802011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8081
8082 * xsettings.c: Use both GConf and GSettings if both are available.
8083 (store_config_changed_event): Add comment.
8084 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8085 (store_tool_bar_style_changed): New functions.
5e617bc2 8086 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8087 (struct xsettings): Move font inside HAVE_XFT.
8088 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8089 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8090 Move inside HAVE_XFT.
640c8776 8091 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8092 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8093 also.
8094 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8095 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8096 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8097 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8098 (parse_settings): Move check for font inside HAVE_XFT.
8099 (read_settings, apply_xft_settings): Add comment.
8100 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8101 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8102 call store_font_name_changed.
8103 (xft_settings_event): Add comment.
8104 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8105 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8106 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8107 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8108 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8109 (xsettings_get_system_font, xsettings_get_system_normal_font):
8110 Add comment.
869795d6 8111
d8ed26bd
PE
81122011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8113
8114 Random fixes. E.g., (random) never returned negative values.
8115 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8116 subseconds part to the entropy, as that's a bit more random.
8117 Prefer signed to unsigned, since the signedness doesn't matter and
8118 in general we prefer signed. When given a limit, use a
8119 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8120 latter isn't right if USE_2_TAGS_FOR_INTS.
8121 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8122 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8123
cabf1cac
SM
81242011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8125
8126 * textprop.c (text_property_stickiness):
8127 Obey Vtext_property_default_nonsticky.
8128 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8129 * w32fns.c (syms_of_w32fns):
8130 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8131
6e9b2be9
PE
81322011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8133
8134 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8135 This is more efficient than Ffile_directory_p and avoids a minor race.
8136
90186c68
LMI
81372011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8138
7c301272
LMI
8139 * buffer.c (Foverlay_put): Say what the return value is
8140 (bug#7835).
8141
c4f2d8d4
LMI
8142 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8143 is a directory before asking whether to use the file name
8144 (bug#7564).
ad637907
LMI
8145 (barf_or_query_if_file_exists): Make the "File is a directory"
8146 error be more correct.
c4f2d8d4 8147
90186c68
LMI
8148 * fns.c (Frequire): Remove the mention of the .gz files, since
8149 that's installation-specific, but keep the mention of
8150 `get-load-suffixes'.
8151
da64016e
PE
81522011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8153
8154 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8155 Report string overflow if the output is too long.
8156
7d47b580
JB
81572011-07-04 Juanma Barranquero <lekktu@gmail.com>
8158
a555cb87
JB
8159 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8160 (syms_of_gnutls): Remove duplicate DEFSYM for
8161 Qgnutls_bootprop_verify_hostname_error, an error for
8162 Qgnutls_bootprop_verify_error (which is no longer used).
8163
7d47b580
JB
8164 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8165 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8166 Also (re)move comments that are misplaced or no longer relevant.
8167
1e49bfab
LMI
81682011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8169
8170 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8171
1485f4c0
CY
81722011-07-03 Chong Yidong <cyd@stupidchicken.com>
8173
8174 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8175 and background color parameters if they have been changed.
8176
a9ab721e
LMI
81772011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8178
8179 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8180
cf7cff57
PE
81812011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8182
2e13213d
PE
8183 * xsettings.c (SYSTEM_FONT): Define only when used.
8184 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8185
cf7cff57
PE
8186 * keymap.c (access_keymap_1): Now static.
8187
7a8e04f7
CY
81882011-07-02 Chong Yidong <cyd@stupidchicken.com>
8189
8190 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8191 leave any prefix arg for the up event (Bug#1586).
8192
61352f62
LMI
81932011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8194
69bb1ef7
LMI
8195 * lread.c (syms_of_lread): Mention single symbols defined by
8196 `defvar' or `defconst' (bug#7154).
8197
61352f62 8198 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8199 (Frequire): Mention get-load-suffixes.
61352f62 8200
28545e04
MR
82012011-07-02 Martin Rudalics <rudalics@gmx.at>
8202
8203 * window.h (window): Remove clone_number slot.
8204 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8205 Remove.
8206 (make_parent_window, make_window, saved_window)
8207 (Fset_window_configuration, save_window_save): Don't deal with
8208 clone numbers.
8209 * buffer.c (Qclone_number): Remove declaration.
8210 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8211
3349e122
SM
82122011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8213
8214 Add multiple inheritance to keymaps.
8215 * keymap.c (Fmake_composed_keymap): New function.
8216 (Fset_keymap_parent): Simplify.
8217 (fix_submap_inheritance): Remove.
8218 (access_keymap_1): New function extracted from access_keymap to handle
8219 embedded parents and handle lists of maps.
8220 (access_keymap): Use it.
8221 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8222 (Fcopy_keymap): Handle embedded parents.
8223 (Fcommand_remapping, define_as_prefix): Simplify.
8224 (Fkey_binding): Simplify.
8225 (syms_of_keymap): Move minibuffer-local-completion-map,
8226 minibuffer-local-filename-completion-map,
8227 minibuffer-local-must-match-map, and
8228 minibuffer-local-filename-must-match-map to Elisp.
8229 (syms_of_keymap): Defsubr make-composed-keymap.
8230 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8231 (parse_menu_item): Trivial simplification.
8232
3279eb87
GM
82332011-07-01 Glenn Morris <rgm@gnu.org>
8234
8235 * Makefile.in (SETTINGS_LIBS): Fix typo.
8236
4550efdf
KI
82372011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8238
8239 * coding.c (Fencode_coding_string): Record the last coding system
8240 used, as the function doc string says (bug#8738).
8241
0949d2b6
JD
82422011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8243
8244 * xsettings.c (store_monospaced_changed): Take new font as arg and
8245 check for change against current_mono_font.
8246 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8247 (emacs_settings_constructor, emacs_settings_get_property)
8248 (emacs_settings_set_property, emacs_settings_class_init)
8249 (emacs_settings_init, gsettings_obj): Remove.
8250 (something_changedCB): New function for HAVE_GSETTINGS.
8251 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8252 with value as argument.
8253 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8254 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8255 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8256 "changed".
8257
8258 * xgselect.c: Add defined (HAVE_GSETTINGS).
8259 (xgselect_initialize): Ditto.
8260
8261 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8262 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8263 xg_select.
8264
bbc6b304
PE
82652011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8266
8267 * eval.c (struct backtrace): Simplify and port the data structure.
8268 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8269 signed bit field, as this assumption is not portable and it makes
8270 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8271 "char debug_on_exit : 1" as this is not portable either; instead,
8272 use the portable "unsigned int debug_on_exit : 1". Remove unused
8273 member evalargs. Remove obsolete comments about cc bombing out.
8274
9851bfc5
JD
82752011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8276
51bb811f 8277 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8278 Let HAVE_GSETTINGS override HAVE_GCONF.
8279 (store_monospaced_changed): New function.
8280 (EMACS_SETTINGS): A new type derived from GObject to handle
8281 GSettings notifications.
8282 (emacs_settings_constructor, emacs_settings_get_property)
8283 (emacs_settings_set_property, emacs_settings_class_init):
8284 New functions.
8285 (gsettings_client, gsettings_obj): New variables.
8286 (GSETTINGS_SCHEMA): New define.
8287 (something_changedCB): Call store_monospaced_changed.
8288 (init_gsettings): New function.
8289 (xsettings_initialize): Call init_gsettings.
8290 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8291 to NULL.
8292
640c8776 8293 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8294 GCONF_CFLAGS/LIBS.
8295
5386012d
MR
82962011-06-29 Martin Rudalics <rudalics@gmx.at>
8297
8298 * window.c (resize_root_window, grow_mini_window)
8299 (shrink_mini_window): Rename Qresize_root_window to
8300 Qwindow_resize_root_window and Qresize_root_window_vertically to
8301 Qwindow_resize_root_window_vertically.
8302
f13e0b08
PE
83032011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8304
8305 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8306
94515237
JB
83072011-06-27 Juanma Barranquero <lekktu@gmail.com>
8308
8309 * makefile.w32-in: Redesign dependencies so they reflect more
8310 clearly which files are directly included by each source file,
8311 and not through other includes.
8312
e43b6e43
MR
83132011-06-27 Martin Rudalics <rudalics@gmx.at>
8314
8315 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8316 (sort_overlays, overlay_strings): When an overlay's clone number
8317 matches the window's clone number process the overlay even if
8318 the overlay's window property doesn't match the current window.
8319
d68443dc
MR
8320 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8321 (Fwindow_hchild): Rename to Fwindow_left_child.
8322 (Fwindow_next): Rename to Fwindow_next_sibling.
8323 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8324 (resize_window_check): Rename to window_resize_check.
8325 (resize_window_apply): Rename to window_resize_apply.
8326 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8327 (Fdelete_other_windows_internal, resize_frame_windows)
8328 (Fsplit_window_internal, Fdelete_window_internal)
8329 (grow_mini_window, shrink_mini_window)
8330 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8331
c7e73be5
JD
83322011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8333
8334 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8335 (emacs_fixed_set_min_size): Remove.
8336 (emacs_fixed_new): Take frame as argument.
8337
8338 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8339 (_EmacsFixedPrivate): Remove minwidth/height.
8340 Add struct frame *f.
8341 (emacs_fixed_init): Initialize priv->f.
8342 (get_parent_class, emacs_fixed_set_min_size): Remove.
8343 (emacs_fixed_new): Set priv->f to argument.
8344 (emacs_fixed_get_preferred_width)
8345 (emacs_fixed_get_preferred_height): Use min_width/height from
8346 frames size_hint to set minimum and natural (Bug#8919).
8347 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8348 and use min_width/height from frames size_hint to set
8349 min_width/height (Bug#8919).
8350
8351 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8352 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8353 Fix indentation.
c7e73be5 8354
cf99dcf8
EZ
83552011-06-26 Eli Zaretskii <eliz@gnu.org>
8356
8357 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8358 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8359 called at ZV.
8360
029529ac
CY
83612011-06-26 Chong Yidong <cyd@stupidchicken.com>
8362
8363 * process.c (wait_reading_process_output): Bypass select if
8364 waiting for a cell while ignoring keyboard input, and input is
8365 pending. Suggested by Jan Djärv (Bug#8869).
8366
7a7ef429
PE
83672011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8368
8369 Use gnulib's dup2 module instead of rolling our own.
8370 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8371
11fdef7d 83722011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8373
8374 * dispnew.c (scrolling_window): Before scrolling, turn off a
8375 mouse-highlight in the window being scrolled.
8376
cd3520a4
JB
83772011-06-24 Juanma Barranquero <lekktu@gmail.com>
8378
8379 Move DEFSYM to lisp.h and use everywhere.
8380
8381 * character.h (DEFSYM): Move declaration...
8382 * lisp.h (DEFSYM): ...here.
8383
8384 * gnutls.c:
8385 * minibuf.c:
8386 * w32menu.c:
8387 * w32proc.c:
8388 * w32select.c: Don't include character.h.
8389
8390 * alloc.c (syms_of_alloc):
8391 * buffer.c (syms_of_buffer):
8392 * bytecode.c (syms_of_bytecode):
8393 * callint.c (syms_of_callint):
8394 * casefiddle.c (syms_of_casefiddle):
8395 * casetab.c (init_casetab_once):
8396 * category.c (init_category_once, syms_of_category):
8397 * ccl.c (syms_of_ccl):
8398 * cmds.c (syms_of_cmds):
8399 * composite.c (syms_of_composite):
8400 * dbusbind.c (syms_of_dbusbind):
8401 * dired.c (syms_of_dired):
8402 * dispnew.c (syms_of_display):
8403 * doc.c (syms_of_doc):
8404 * editfns.c (syms_of_editfns):
8405 * emacs.c (syms_of_emacs):
8406 * eval.c (syms_of_eval):
8407 * fileio.c (syms_of_fileio):
8408 * fns.c (syms_of_fns):
8409 * frame.c (syms_of_frame):
8410 * fringe.c (syms_of_fringe):
8411 * insdel.c (syms_of_insdel):
8412 * keymap.c (syms_of_keymap):
8413 * lread.c (init_obarray, syms_of_lread):
8414 * macros.c (syms_of_macros):
8415 * msdos.c (syms_of_msdos):
8416 * print.c (syms_of_print):
8417 * process.c (syms_of_process):
8418 * search.c (syms_of_search):
8419 * sound.c (syms_of_sound):
8420 * syntax.c (init_syntax_once, syms_of_syntax):
8421 * terminal.c (syms_of_terminal):
8422 * textprop.c (syms_of_textprop):
8423 * undo.c (syms_of_undo):
8424 * w32.c (globals_of_w32):
8425 * window.c (syms_of_window):
8426 * xdisp.c (syms_of_xdisp):
8427 * xfaces.c (syms_of_xfaces):
8428 * xfns.c (syms_of_xfns):
8429 * xmenu.c (syms_of_xmenu):
8430 * xsettings.c (syms_of_xsettings):
8431 * xterm.c (syms_of_xterm): Use DEFSYM.
8432
4228cf16
TZ
84332011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8434
cd3520a4 8435 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8436
7fcccf1e
PE
84372011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8438
7efb4e0e
PE
8439 Integer and buffer overflow fixes (Bug#8873).
8440
ff5844ad
PE
8441 * print.c (printchar, strout): Check for string overflow.
8442 (PRINTPREPARE, printchar, strout):
8443 Don't set size unless allocation succeeds.
8444
90532f02
PE
8445 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8446 for sizes. Check for string overflow more accurately.
8447 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8448
6d84508d
PE
8449 * macros.c: Integer and buffer overflow fixes.
8450 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8451 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8452 Use ptrdiff_t, not int, for sizes.
8453 Don't increment bufsize until after realloc succeeds.
8454 Check for size-calculation overflow.
8455 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8456
437b2cb4
PE
8457 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8458
8b9ac8b4
PE
8459 * lread.c: Integer overflow fixes.
8460 (read_integer): Radix is now EMACS_INT, not int,
8461 to improve quality of diagnostics for out-of-range radices.
8462 Calculate buffer size correctly for out-of-range radices.
8463 (read1): Check for integer overflow in radices, and in
8464 read-circle numbers.
82cb60d3
PE
8465 (read_escape): Avoid int overflow.
8466 (Fload, openp, read_buffer_size, read1)
8467 (substitute_object_recurse, read_vector, read_list, map_obarray):
8468 Use ptrdiff_t, not int, for sizes.
8469 (read1): Use EMACS_INT, not int, for sizes.
20270765 8470 Check for size overflow.
8b9ac8b4 8471
7fcccf1e
PE
8472 * image.c (cache_image): Check for size arithmetic overflow.
8473
bfbbd7e7
PE
8474 * lread.c: Integer overflow issues.
8475 (saved_doc_string_size, saved_doc_string_length)
8476 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8477 Now ptrdiff_t, not int.
8478 (read1): Don't assume doc string length fits in int. Check for
8479 out-of-range doc string lengths.
8480 (read_list): Don't assume file position fits in int.
39019e54 8481 (read_escape): Check for hex character overflow.
bfbbd7e7 8482
4e323265
LL
84832011-06-22 Leo Liu <sdl.web@gmail.com>
8484
8485 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8486 Move to minibuffer.el.
8487
85fece3e
PE
84882011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8489
20b84ce9 8490 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8491 The following patches are for when GLYPH_DEBUG && !XASSERT.
8492 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8493 * dispnew.c (flush_stdout):
8494 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8495 Mark as externally visible.
8496 * dispnew.c (check_window_matrix_pointers): Now static.
8497 * dispnew.c (window_to_frame_vpos):
8498 * xfns.c (unwind_create_frame):
8499 * xterm.c (x_check_font): Remove unused local.
8500 * scroll.c (CHECK_BOUNDS):
8501 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8502 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8503 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8504 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8505 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8506 Now static.
8507 (debug_method_add): Use va_list and vsprintf rather than relying
8508 on undefined behavior with wrong number of arguments.
8509 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8510 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8511 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8512 since we're not interested in debugging glyphs with old libraries.
8513 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8514 GCC 4.6.0's static checking.
8515
0766b489
PE
85162011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8517
31fd4b32
PE
8518 Integer overflow and signedness fixes (Bug#8873).
8519 A few related buffer overrun fixes, too.
8520
b79e8648
PE
8521 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8522
0766b489
PE
8523 * dispextern.h (struct face.stipple):
8524 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8525 (x_bitmap_mask, x_allocate_bitmap_record)
8526 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8527 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8528 (x_create_bitmap_from_xpm_data):
8529 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8530 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8531 (.bitmaps_last):
8532 * xfaces.c (load_pixmap):
8533 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8534 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8535 (.bitmaps_last, struct x_output.icon_bitmap):
8536 Use ptrdiff_t, not int, for bitmap indexes.
8537 (x_allocate_bitmap_record): Check for size overflow.
8538 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8539
b081724f
PE
8540 Use ptrdiff_t, not int, for overlay counts.
8541 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8542 * editfns.c (overlays_around, get_pos_property):
8543 * textprop.c (get_char_property_and_overlay):
8544 * xdisp.c (next_overlay_change, note_mouse_highlight):
8545 * xfaces.c (face_at_buffer_position):
21514da7
PE
8546 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8547 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8548 (Fnext_overlay_change, Fprevious_overlay_change)
8549 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8550 Use ptrdiff_t, not int, for sizes.
21514da7 8551 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8552
3de73e5e
PE
8553 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8554
2606c57b
PE
8555 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8556 (x_session_initialize): Do not assume string length fits in int.
8557
aaafe47a
PE
8558 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8559 This is unlikely, but can occur if DPI is outlandish.
8560
2674ddc8 8561 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8562 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8563
28154962
PE
8564 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8565 * xrdb.c (magic_file_p, search_magic_path):
8566 Omit last arg SUFFIX; it was always 0. All callers changed.
8567 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8568
7de51af5
PE
8569 * xfont.c (xfont_match): Avoid need for strlen.
8570
25ed6cc3
PE
8571 * xfns.c: Don't assume strlen fits in int.
8572 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8573
4eab31dd
PE
8574 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8575 not unsigned long, as we prefer signed integers. All callers changed.
8576 Detect integer overflow in repeat count.
8577 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8578 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8579
171e2a58
PE
8580 * termcap.c: Don't assume sizes fit in int and never overflow.
8581 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8582 (gobble_line): Check for size-calculation overflow.
8583
ad39faca 8584 * minibuf.c (Fread_buffer):
6e5bb2dc 8585 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8586 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8587 Don't assume string length fits in int.
8588
52c61c22 8589 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8590 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8591
b5b8c9e5
PE
8592 * font.c: Don't assume string length fits in int.
8593 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8594 Use ptrdiff_t, not int.
ccd6111c
PE
8595 (font_intern_prop): Don't assume string length fits in int.
8596 Don't assume integer property fits in fixnum.
8597 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8598
882f0d81 8599 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8600 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8601 Reformulate so as not to need the command string.
8602 Invoke gzip -cd rather than gunzip, as it's more portable.
8603 (lock_info_type, lock_file_1, lock_file):
8604 Don't assume pid_t and time_t fit in unsigned long.
8605 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8606 (current_lock_owner): Prefer signed type for sizes.
8607 Use memcpy, not strncpy, where memcpy is what is really wanted.
8608 Don't assume (via atoi) that time_t and pid_t fit in int.
8609 Check for time_t and/or pid_t out of range, e.g., via a network share.
8610 Don't alloca where an auto var works fine.
8611
93f4cf88
PE
8612 * fileio.c: Fix some integer overflow issues.
8613 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8614 Don't assume string length fits in int.
8615 (directory_file_name): Don't assume string length fits in long.
8616 (make_temp_name): Don't assume pid fits in int, or that its print
8617 length is less than 20.
8618
f3e92b69
PE
8619 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8620
1bfdaf10
PE
8621 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8622
35016e9a
PE
8623 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8624
3d1e65a1
PE
8625 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8626 We prefer signed integers, even for size calculations.
8627
0b963a93
PE
8628 * emacs.c: Don't assume string length fits in 'int'.
8629 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8630 (main): Don't invoke strlen when not needed.
8631
573f4b54
PE
8632 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8633 (XD_DEBUG_MESSAGE): Don't waste a byte.
8634
989f33ba
PE
8635 * callproc.c (getenv_internal_1, getenv_internal)
8636 (Fgetenv_internal):
965d34eb
PE
8637 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8638
e4d29b33
PE
8639 * lread.c (invalid_syntax): Omit length argument.
8640 All uses changed. This doesn't fix a bug, but it simplifies the
8641 code away from its former Hollerith-constant appearance, and it's
8642 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8643 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8644
eb49b136
PE
8645 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8646 This didn't break anything, but it didn't help either.
8647 It's confusing to put a bogus integer in a place where the actual
8648 value does not matter.
9f62aeb1 8649 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8650 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8651
15375a22
PE
8652 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8653 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8654 implementation.
b61cc01c
PE
8655 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8656 We prefer signed types, and the value cannot exceed the EMACS_INT
8657 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8658 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8659 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8660 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8661
53b2623d
PE
8662 * indent.c (sane_tab_width): New function.
8663 (current_column, scan_for_column, Findent_to, position_indentation)
8664 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8665 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8666
51cab52b 8667 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8668
f2ed8a70
PE
8669 * lisp.h (lint_assume): New macro.
8670 * composite.c (composition_gstring_put_cache):
8671 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8672
abe80cc6
PE
8673 * editfns.c, insdel.c:
8674 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8675
b02c740e
PE
8676 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8677
ebc96716
PE
8678 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8679
b4e50fa0 8680 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8681 Use much-faster test for byte-length change.
311d5d7c 8682 Don't assume string byte-length fits in 'int'.
a4cf38e4 8683 Check that character arg fits in 'int'.
85461888 8684 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8685
c0c1ee9f
PE
8686 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8687
a498d7f4
PE
8688 * fns.c (concat): Catch string overflow earlier.
8689 Do not rely on integer wraparound.
8690
51cab52b
PE
8691 * dispextern.h (struct it.overlay_strings_charpos)
8692 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8693 * xdisp.c (forward_to_next_line_start)
8694 (back_to_previous_visible_line_start)
8695 (reseat_at_next_visible_line_start, next_element_from_buffer):
8696 Don't arbitrarily truncate the value of 'selective' to int.
8697
76031fad
PE
8698 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8699
5eb55db9
PE
8700 * composite.c: Don't truncate sizes to 'int'.
8701 (composition_gstring_p, composition_reseat_it)
8702 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8703 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8704 not EMACS_UINT, for indexes.
5eb55db9 8705
0703a717
PE
8706 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8707
d6202519
PE
8708 * buffer.c: Include <verify.h>.
8709 (struct sortvec.priority, struct sortstr.priority):
8961a454 8710 Now EMACS_INT, not int.
c20998a7 8711 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8712 (struct sortstr.size, record_overlay_string)
8713 (struct sortstrlist.size, struct sortlist.used):
8714 Don't truncate size to int.
8715 (record_overlay_string): Check for size-calculation overflow.
d6202519 8716 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8717
d5a19415
JM
87182011-06-22 Jim Meyering <meyering@redhat.com>
8719
029529ac 8720 Don't leak an XBM-image-sized buffer
d5a19415
JM
8721 * image.c (xbm_load): Free the image buffer after using it.
8722
a9041e6c
PE
87232011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8724
8725 Port to Sun C.
8726 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8727 that Sun C diagnosed.
8728 * fns.c (secure_hash): Fix pointer signedness issue.
8729 * intervals.c (static_offset_intervals): New function.
8730 (offset_intervals): Use it.
8731
7f3f739f
LL
87322011-06-21 Leo Liu <sdl.web@gmail.com>
8733
8734 * deps.mk (fns.o):
8735 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8736 sha512.h.
8737
8738 * fns.c (secure_hash): Rename from crypto_hash_function and change
8739 the first arg to accept symbols.
5b66d427 8740 (Fsecure_hash): New primitive.
7f3f739f
LL
8741 (syms_of_fns): New symbols.
8742
76147d94
DD
87432011-06-20 Deniz Dogan <deniz@dogan.se>
8744
8745 * process.c (Fset_process_buffer): Clarify return value in
8746 docstring.
8747
7d7d0045
CY
87482011-06-18 Chong Yidong <cyd@stupidchicken.com>
8749
8750 * dispnew.c (add_window_display_history): Use BVAR.
8751
8752 * xdisp.c (debug_method_add): Use BVAR.
8753 (check_window_end, dump_glyph_matrix, dump_glyph)
8754 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8755
8756 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8757 Likewise.
8758
8759 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8760 check till after the cache is created in init_frame_faces.
8761
ff2bc410
SM
87622011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8763
8764 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8765
28177add
PE
87662011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8767
dd3482fe
PE
8768 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8769 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8770 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8771
393d71f3 8772 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8773 * fileio.c (Finsert_file_contents):
8774 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8775 Remove the old (too-loose) buffer overflow checks.
8776 They weren't needed, since make_gap checks for buffer overflow.
8777 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8778 The old code merely checked for Emacs fixnum overflow, and relied
8779 on undefined (wraparound) behavior. The new code avoids undefined
8780 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8781
2e6813b0 8782 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8783 Tune. Don't use wider integers than needed. Don't use alloca.
8784 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8785
599a9e4f
PE
8786 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8787
99561444
PE
8788 * insdel.c, lisp.h (buffer_overflow): New function.
8789 (insert_from_buffer_1, replace_range, replace_range_2):
8790 * insdel.c (make_gap_larger):
8791 * editfns.c (Finsert_char):
8792 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8793
28177add
PE
8794 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8795
e69dafad
PE
87962011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8797
4baa020d 8798 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8799
b1c46f02
PE
8800 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8801 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8802
e69dafad
PE
8803 * fileio.c: Don't assume EMACS_INT fits in off_t.
8804 (emacs_lseek): New static function.
8805 (Finsert_file_contents, Fwrite_region): Use it.
8806 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8807
566684ea
PE
8808 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8809
e6966cd6
PE
8810 * fns.c: Don't overflow int when computing a list length.
8811 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8812 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8813 truncation on 64-bit hosts. Check for QUIT every
8814 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8815 faster and is responsive enough.
8816 (Flength): Report an error instead of overflowing an integer.
8817 (Fsafe_length): Return a float if the value is not representable
8818 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8819 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8820 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8821
dd0b0efb
PE
8822 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8823 (header_size, word_size): New constants.
8824 (allocate_vectorlike): Don't check size overflow here.
8825 (allocate_vector): Check it here instead, since this is the only
8826 caller of allocate_vectorlike that could cause overflow.
8827 Check that the new vector's length is representable as a fixnum.
8828
86fe5cfe
PE
8829 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8830 The previous code was bogus. For example, next_almost_prime (32)
8831 returned 39, which is undesirable as it is a multiple of 3; and
8832 next_almost_prime (24) returned 25, which is a multiple of 5 so
8833 why was the code bothering to check for multiples of 7?
8834
80e88859
PE
8835 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8836
4a2f0ad6
PE
8837 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8838
f66c7cf8
PE
8839 Variadic C functions now count arguments with ptrdiff_t.
8840 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8841 Back then I didn't know that the Emacs coding style prefers signed int.
8842 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8843 were being counted with int, which may truncate counts on 64-bit
8844 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8845 * lisp.h (struct Lisp_Subr.function.aMANY)
8846 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8847 Arg counts are now ptrdiff_t, not size_t.
8848 All variadic functions and their callers changed accordingly.
8849 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8850 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8851 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8852 * callint.c (Fcall_interactively): Check arg count for overflow,
8853 to avoid potential buffer overrun. Use signed char, not 'int',
8854 for 'varies' array, so that we needn't bother to check its size
8855 calculation for overflow.
8856 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8857 * eval.c (apply_lambda):
8858 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8859 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8860 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8861
a1759b76
PE
8862 * callint.c (Fcall_interactively): Don't use index var as event count.
8863
d96be9fc
PE
8864 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8865 * mem-limits.h (SIZE): Remove; no longer used.
8866
a690a978 8867 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8868
578c21e6
PE
8869 Remove unnecessary casts.
8870 * xterm.c (x_term_init):
8871 * xfns.c (x_set_border_pixel):
8872 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8873 These aren't needed now that we assume ANSI C.
8874
96f53c6c
PE
8875 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8876 It's more likely to cause problems (due to unsigned overflow)
8877 than to cure them.
8878
83c77d31
PE
8879 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8880
ee2079f1
PE
8881 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8882
6da65536
PE
8883 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8884
7147c4a4
PE
8885 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8886
193e32d9
PE
8887 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8888
e5533da6
PE
8889 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8890
9910e595
PE
8891 GLYPH_CODE_FACE returns EMACS_INT, not int.
8892 * dispextern.h (merge_faces):
8893 * xfaces.c (merge_faces):
01103c44
PE
8894 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8895 Don't assume EMACS_INT fits in int.
9910e595 8896
2638320e
PE
8897 * character.h (CHAR_VALID_P): Remove unused parameter.
8898 * fontset.c, lisp.h, xdisp.c: All uses changed.
8899
045eb8d9
PE
8900 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8901
c1f134b5
PE
8902 * fns.c (concat): Minor tuning based on overflow analysis.
8903 This doesn't fix any bugs. Use int to hold character, instead
8904 of constantly refetching from Emacs object. Use XFASTINT, not
8905 XINT, for value known to be a character. Don't bother comparing
8906 a single byte to 0400, as it's always less.
8907
395fcb93 8908 * floatfns.c (Fexpt):
327eeec8
PE
8909 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8910
abbd3d23
PE
8911 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8912 for characters.
8913
684a03ef
PE
8914 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8915
0fed43f3
PE
8916 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8917 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8918 incorrectly succeed when S was a string, because 4294967386 was
8919 truncated before it was used.
8920
8fd02eb7
PE
8921 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8922 Otherwise, an out-of-range integer could cause undefined behavior
8923 on a 64-bit host.
8924
f8c86b69
PE
8925 * composite.c: Use int, not EMACS_INT, for characters.
8926 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8927 EMACS_INT, for values that are known to be in character range.
8928 This doesn't fix any bugs but is the usual style inside Emacs and
8929 may generate better code on 32-bit machines.
8930
34206dd2
PE
8931 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8932 This is for reasons similar to the recent CHAR_STRING fix.
8933 * charset.c (Fencode_char): Check that character arg is actually
8934 a character. Pass an int to ENCODE_CHAR.
8935 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8936 wider than 'int', as a compile-time check to prevent future regressions
8937 in this area.
8938
c5958d4c 8939 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8940
8941 Make sure a 64-bit char is never passed to CHAR_STRING.
8942 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8943 by silently ignoring the top 32 bits, allowing some values
8944 that were far too large to be valid characters.
8945 * character.h: Include <verify.h>.
8946 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8947 arguments are no wider than unsigned, as a compile-time check
8948 to prevent future regressions in this area.
8949 * data.c (Faset):
01103c44 8950 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8951 (Fsubst_char_in_region):
8952 * fns.c (concat):
8953 * xdisp.c (decode_mode_spec_coding):
8954 Adjust to CHAR_STRING's new requirement.
8955 * editfns.c (Finsert_char, Fsubst_char_in_region):
8956 * fns.c (concat): Check that character args are actually
8957 characters. Without this test, these functions did the wrong
8958 thing with wildly out-of-range values on 64-bit hosts.
8959
d37ca623
PE
8960 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8961 These casts should not be needed on 32-bit hosts, either.
8962 * keyboard.c (read_char):
8963 * lread.c (Fload): Remove casts to unsigned.
8964
ea204efb
PE
8965 * lisp.h (UNSIGNED_CMP): New macro.
8966 This fixes comparison bugs on 64-bit hosts.
8967 (ASCII_CHAR_P): Use it.
8968 * casefiddle.c (casify_object):
01103c44 8969 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8970 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8971 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8972 * dispextern.h (FACE_FROM_ID):
8973 * keyboard.c (read_char): Use UNSIGNED_CMP.
8974
41cb286c
PE
8975 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8976 not to EMACS_INT, to avoid GCC warning.
8977
4a1b9832
PE
8978 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8979
55daad71
PE
8980 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8981 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8982 isn't needed on 32-bit machines.
8f95c75c 8983
01103c44
PE
8984 * buffer.c (Fgenerate_new_buffer_name):
8985 Use EMACS_INT for count, not int.
0ceccced 8986 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8987
8988 * data.c (Qcompiled_function): Now static.
8989
c6f072e7
PE
8990 * window.c (window_body_lines): Now static.
8991
20ce5912
PE
8992 * image.c (gif_load): Rename local to avoid shadowing.
8993
9c4c5f81
PE
8994 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8995 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8996 * alloc.c (make_save_value): Integer argument is now of type
8997 ptrdiff_t, not int.
8998 (mark_object): Use ptrdiff_t, not int.
8999 * lisp.h (pD): New macro.
9000 * print.c (print_object): Use it.
9001
c0c5c8ae
PE
9002 * alloc.c: Use EMACS_INT, not int, to count objects.
9003 (total_conses, total_markers, total_symbols, total_vector_size)
9004 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9005 (total_free_floats, total_floats, total_free_intervals)
9006 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9007 Now EMACS_INT, not int. All uses changed.
9008 (Fgarbage_collect): Compute overall total using a double, so that
9009 integer overflow is less likely to be a problem. Check for overflow
9010 when converting back to an integer.
5a25e253
PE
9011 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9012 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9013 These were 'int' variables that could overflow on 64-bit hosts;
9014 they were never used, so remove them instead of repairing them.
211a0b2a 9015 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9016 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9017 Previously, this ceilinged at INT_MAX, but that doesn't work on
9018 64-bit machines.
e46bb31a 9019 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9020
c78baabf 9021 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9022 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9023 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9024 when a (possibly-narrower) signed value would do just as well.
9025 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9026
c9d624c6
PE
9027 * alloc.c: Catch some string size overflows that we were missing.
9028 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9029 for convenience in STRING_BYTES_MAX.
9030 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9031 The definition here is exact; the one in lisp.h was approximate.
9032 (allocate_string_data): Check for string overflow. This catches
9033 some instances we weren't catching before. Also, it catches
9034 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9035 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9036 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9037
c9d624c6
PE
9038 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9039 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9040 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9041
353032ce
PE
9042 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9043
2bccce07
PE
9044 * alloc.c (Fmake_string): Check for out-of-range init.
9045
0ac30604
SM
90462011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9047
9048 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9049
c195f2de
JD
90502011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9051
9052 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9053 xg_get_default_scrollbar_width.
9054
9055 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9056 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9057 (style_changed_cb): Call update_theme_scrollbar_width and call
9058 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9059 all frames (Bug#8505).
9060 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9061 Call gtk_window_set_resizable if HAVE_GTK3.
9062 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9063 and height if HAVE_GTK3 (Bug#8505).
9064 (scroll_bar_width_for_theme): New variable.
9065 (update_theme_scrollbar_width): New function.
9066 (xg_get_default_scrollbar_width): Move code to
9067 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9068 (xg_initialize): Call update_theme_scrollbar_width.
9069
9070 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9071
9072 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9073
e10ac9f1
MR
90742011-06-12 Martin Rudalics <rudalics@gmx.at>
9075
9076 * frame.c (make_frame): Call other_buffer_safely instead of
9077 other_buffer.
9078
9079 * window.c (temp_output_buffer_show): Call display_buffer with
9080 second argument Vtemp_buffer_show_specifiers and reset latter
9081 immediately after the call.
9082 (Vtemp_buffer_show_specifiers): New variable.
9083 (auto_window_vscroll_p, next_screen_context_lines)
9084 (Vscroll_preserve_screen_position): Remove leading asterisks from
9085 doc-strings.
9086
2d3c217e 90872011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9088
7b7f97e8 9089 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9090 * buffer.c (Qclone_number): Remove for now, as it's unused.
9091 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9092 (record_buffer): Remove unused local.
9093 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9094 (set_frame_buffer_list): Remove; unused.
9095 * frame.h (other_visible_frames): Remove decl.
9096 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9097 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9098 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9099 if HAVE_GPM.
9100 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9101 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9102 Define only if HAVE_GPM.
9103 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9104 (update_hints_inhibit): Remove; never set. All uses removed.
9105 * widgetprv.h (emacsFrameClassRec): Remove decl.
9106 * window.c (delete_deletable_window): Now returns void, since it
9107 wasn't returning anything.
9108 (compare_window_configurations): Remove unused locals.
9109 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9110 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9111 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9112 the same widths as pointers. This follows up on the 2011-05-06 patch.
9113 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9114 * xterm.h: Likewise.
9115 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9116
1384b89e
JB
91172011-06-12 Juanma Barranquero <lekktu@gmail.com>
9118
9119 * makefile.w32-in: Update dependencies.
9120 (LISP_H): Add lib/intprops.h.
9121
1100a63c
CY
91222011-06-11 Chong Yidong <cyd@stupidchicken.com>
9123
9124 * image.c (gif_load): Add animation frame delay to the metadata.
9125 (syms_of_image): Use DEFSYM. New symbol `delay'.
9126
6198ccd0
MR
91272011-06-11 Martin Rudalics <rudalics@gmx.at>
9128
9129 * window.c (delete_deletable_window): Re-add.
9130 (Fset_window_configuration): Rewrite to handle dead buffers and
9131 consequently deletable windows.
9132 (window_tree, Fwindow_tree): Remove. Supply functionality in
9133 window.el.
9134 (compare_window_configurations): Simplify code.
9135
b6e3633c
AS
91362011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9137
1ab0dee5
AS
9138 * image.c (imagemagick_load_image): Fix type mismatch.
9139 (Fimagemagick_types): Likewise.
9140
b6e3633c
AS
9141 * window.h (replace_buffer_in_windows): Declare.
9142
9397e56f
MR
91432011-06-11 Martin Rudalics <rudalics@gmx.at>
9144
9145 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9146 Qclone_number. Remove external declaration of Qdelete_window.
9147 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9148 code.
640c8776
SM
9149 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9150 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9151 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9152 buffer list implementation.
9153 (other_buffer_safely): New function.
9154 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9155 calls to replace_buffer_in_windows and
9156 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9157 if allowed.
9158 (record_buffer): Inhibit quitting and rewrite using quittable
9159 functions. Run Qbuffer_list_update_hook if allowed.
9160 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9161 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9162 Move switch-to-buffer to window.el.
9397e56f
MR
9163 (bury-buffer): Move to window.el.
9164 (Vbuffer_list_update_hook): New variable.
9165
9166 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9167 section.
9168
9169 * window.h (resize_frame_windows): Move up in code.
9170 (Fwindow_frame): Remove EXFUN.
9171 (replace_buffer_in_all_windows): Remove prototype.
9172 (replace_buffer_in_windows_safely): Add prototype.
9173
9174 * window.c: Declare Qdelete_window static again. Move down
9175 declaration of select_count.
9176 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9177 (Fother_window): Move to window.el.
9178 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9179 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9180 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9181 window.el.
9182 (replace_buffer_in_windows): Implement by calling
9183 Qreplace_buffer_in_windows.
9184 (replace_buffer_in_all_windows): Remove with some functionality
9185 moved into replace_buffer_in_windows_safely.
9186 (replace_buffer_in_windows_safely): New function.
9187 (select_window_norecord, select_frame_norecord): Move in front
9188 of run_window_configuration_change_hook. Remove now obsolete
9189 declarations.
640c8776
SM
9190 (Fset_window_buffer): Rewrite doc-string.
9191 Call Qrecord_window_buffer.
9397e56f
MR
9192 (keys_of_window): Move binding for other-window to window.el.
9193
b50691aa
CY
91942011-06-11 Chong Yidong <cyd@stupidchicken.com>
9195
9196 * dispextern.h (struct image): Replace data member, whose int_val
9197 and ptr_val fields were not used by anything, with a single
9198 lisp_val object.
9199
9200 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9201 (gif_clear_image, gif_load, imagemagick_load_image)
9202 (gs_clear_image, gs_load): Callers changed.
9203
3f754b86
PE
92042011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9205
cca69397
PE
9206 * buffer.h: Include <time.h>, for time_t.
9207 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9208
109e28d0
PE
9209 Fix minor problems found by static checking.
9210
60737f02
PE
9211 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9212
4b66faf3
PE
9213 Make identifiers static if they are not used in other modules.
9214 * data.c (Qcompiled_function, Qframe, Qvector):
9215 * image.c (QimageMagick, Qsvg):
9216 * minibuf.c (Qmetadata):
9217 * window.c (resize_window_check, resize_root_window): Now static.
9218 * window.h (resize_window_check, resize_root_window): Remove decls.
9219
109e28d0
PE
9220 * window.c (window_deletion_count, delete_deletable_window):
9221 Remove; unused.
46a4ce9e
PE
9222 (window_body_lines): Now static.
9223 (Fdelete_other_windows_internal): Mark vars as initialized.
9224 Make sure 'resize_failed' is initialized.
9225 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9226 (resize_window_apply): Remove unused local.
9227 * window.h (delete_deletable_window): Remove decl.
9228
109e28d0 9229 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9230 (imagemagick_load_image): Fix pointer signedness problem by changing
9231 last arg from unsigned char * to char *. All uses changed.
9232 Also, fix a local for similar reasons.
9233 Remove unused locals. Remove locals to avoid shadowing.
9234 (fn_rsvg_handle_free): Remove; unused.
9235 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9236 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9237
3f754b86
PE
9238 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9239
2547adb1
CY
92402011-06-10 Chong Yidong <cyd@stupidchicken.com>
9241
9242 * image.c (gif_load): Fix omitted cast error introduced by
9243 2011-06-06 change.
9244
2c8e37d4
MR
92452011-06-10 Martin Rudalics <rudalics@gmx.at>
9246
9247 * window.h (resize_proportionally, orig_total_lines)
9248 (orig_top_line): Remove from window structure.
9249 (set_window_height, set_window_width, change_window_heights)
9250 (Fdelete_window): Remove prototypes.
9251 (resize_frame_windows): Remove duplicate declaration.
9252
440a42e3
EZ
92532011-06-10 Eli Zaretskii <eliz@gnu.org>
9254
9255 * window.h (resize_frame_windows, resize_window_check)
9256 (delete_deletable_window, resize_root_window)
9257 (resize_frame_windows): Declare prototypes.
9258
9259 * window.c (resize_window_apply): Make definition be "static" to
9260 match the prototype.
9261
562dd5e9
MR
92622011-06-10 Martin Rudalics <rudalics@gmx.at>
9263
9264 * window.c: Remove declarations of Qwindow_size_fixed,
9265 window_min_size_1, window_min_size_2, window_min_size,
9266 size_window, window_fixed_size_p, enlarge_window, delete_window.
9267 Remove static from declaration of Qdelete_window, it's
9268 temporarily needed by Fbury_buffer.
9269 (replace_window): Don't assign orig_top_line and
9270 orig_total_lines.
9271 (Fdelete_window, delete_window): Remove. Window deletion is
9272 handled by window.el.
640c8776
SM
9273 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9274 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9275 (Fdelete_other_windows): Remove. Deleting other windows is
9276 handled by window.el.
9277 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9278 handled in window.el.
9279 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9280 Window minimum sizes are handled in window.el.
9281 (shrink_windows, size_window, set_window_height)
9282 (set_window_width, change_window_heights, window_height)
9283 (window_width, CURBEG, CURSIZE, enlarge_window)
9284 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9285 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9286 handled in window.el.
9287 (make_dummy_parent): Rename to make_parent_window and give it a
9288 second argument horflag.
9289 (make_window): Don't set resize_proportionally any more.
9290 (Fsplit_window): Remove. Windows are split in window.el.
9291 (save_restore_action, save_restore_orig_size)
9292 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9293 Resize mini windows in window.el.
9294 (grow_mini_window, shrink_mini_window): Implement by calling
9295 Qresize_root_window_vertically, resize_window_check and
9296 resize_window_apply.
640c8776
SM
9297 (saved_window, Fset_window_configuration, save_window_save):
9298 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9299 resize_proportionally.
9300 (window_min_height, window_min_width): Move to window.el.
9301 (keys_of_window): Move bindings for delete-other-windows,
9302 split-window, delete-window and enlarge-window to window.el.
9303
9304 * buffer.c: Temporarily extern Qdelete_window.
9305 (Fbury_buffer): Temporarily call Qdelete_window instead of
9306 Fdelete_window (Fbury_buffer will move to window.el soon).
9307
9308 * frame.c (set_menu_bar_lines_1): Remove code handling
9309 orig_top_line and orig_total_lines.
9310
9311 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9312 set_window_height but set heights directly.
9313 (change_frame_size_1): Use resize_frame_windows.
9314
9315 * xdisp.c (init_xdisp): Don't use set_window_height but set
9316 heights directly.
9317
640c8776
SM
9318 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9319 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9320 run_window_configuration_change_hook.
9321
9322 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9323 instead of change_window_heights and run
9324 run_window_configuration_change_hook.
9325
1a13852e
MR
93262011-06-09 Martin Rudalics <rudalics@gmx.at>
9327
9328 * window.c (replace_window): Rename second argument REPLACEMENT to
9329 NEW. New third argument SETFLAG. Rewrite.
9330 (delete_window, make_dummy_parent): Call replace_window with
9331 third argument 1.
9332 (window_list_1): Move down in code.
9333 (run_window_configuration_change_hook): Move set_buffer part
9334 before select_frame_norecord part in order to unwind correctly.
9335 Rename count1 to count.
9336 (recombine_windows, delete_deletable_window, resize_root_window)
9337 (Fdelete_other_windows_internal)
9338 (Frun_window_configuration_change_hook, make_parent_window)
9339 (resize_window_check, resize_window_apply, Fresize_window_apply)
9340 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9341 (Fdelete_window_internal, Fresize_mini_window_internal):
9342 New functions.
1a13852e
MR
9343 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9344
f3d1777e
MR
93452011-06-08 Martin Rudalics <rudalics@gmx.at>
9346
496e208e
MR
9347 * window.h (window): Add some new members to window structure -
9348 normal_lines, normal_cols, new_total, new_normal, clone_number,
9349 splits, nest, prev_buffers, next_buffers.
9350 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9351 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9352
f3d1777e
MR
9353 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9354 Remove.
496e208e
MR
9355 (make_dummy_parent): Set new members of windows structure.
9356 (make_window): Move down in code. Handle new members of window
9357 structure.
9358 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9359 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9360 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9361 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9362 (Fset_window_next_buffers, Fset_window_clone_number):
9363 New functions.
496e208e
MR
9364 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9365 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9366 Doc-string fixes.
9367 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9368 Argument WINDOW can be now internal window too.
9369 (Fwindow_use_time): Move up in code.
9370 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9371 Rewrite doc-string.
9372 (Fset_window_configuration, saved_window)
9373 (Fcurrent_window_configuration, save_window_save): Handle new
9374 members of window structure.
b9e809c2
MR
9375 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9376 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9377 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9378 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9379 Qget_mru_window, Qresize_root_window,
9380 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9381 Qauto_buffer_name; staticpro them.
f3d1777e 9382
abde8f8c
MR
93832011-06-07 Martin Rudalics <rudalics@gmx.at>
9384
9385 * window.c (Fwindow_total_size, Fwindow_left_column)
9386 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9387 (Fwindow_list_1): New functions.
9388 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9389 (Fwindow_width, Fscroll_left, Fscroll_right):
9390 Use window_body_cols instead of window_box_text_cols.
9391 (delete_window, Fset_window_configuration):
9392 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9393 (delete_all_subwindows): Take a window as argument and not a
9394 structure. Rewrite.
190b47e6
MR
9395 (window_loop): Remove handling of GET_LRU_WINDOW and
9396 GET_LARGEST_WINDOW.
9397 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9398
9399 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9400 window_box_text_cols. delete_all_subwindows now takes a
9401 Lisp_Object as argument.
abde8f8c 9402
640c8776
SM
9403 * indent.c (compute_motion, Fcompute_motion):
9404 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9405
fa8a67e6
MR
9406 * frame.c (delete_frame): Call delete_all_subwindows with root
9407 window as argument.
9408
a54e3482
DC
94092011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9410
9411 * fns.c (Fputhash): Document return value.
9412
60002bf5
CY
94132011-06-06 Chong Yidong <cyd@stupidchicken.com>
9414
9415 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9416
0c671da6 94172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9418
b862a52a 9419 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9420
be44ca6c
PE
9421 Check for overflow when converting integer to cons and back.
9422 * charset.c (Fdefine_charset_internal, Fdecode_char):
9423 Use cons_to_unsigned to catch overflow.
9424 (Fencode_char): Use INTEGER_TO_CONS.
9425 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9426 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9427 * data.c (long_to_cons, cons_to_long): Remove.
9428 (cons_to_unsigned, cons_to_signed): New functions.
9429 These signal an error for invalid or out-of-range values.
9430 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9431 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9432 * font.c (Ffont_variation_glyphs):
9433 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9434 * lisp.h: Include <intprops.h>.
9435 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9436 (cons_to_signed, cons_to_unsigned): New decls.
9437 (long_to_cons, cons_to_long): Remove decls.
9438 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9439 (Fprimitive_undo): Use CONS_TO_INTEGER.
9440 * xfns.c (Fx_window_property): Likewise.
9441 * xselect.c: Include <limits.h>.
9442 (x_own_selection, selection_data_to_lisp_data):
9443 Use INTEGER_TO_CONS.
9444 (x_handle_selection_request, x_handle_selection_clear)
9445 (x_get_foreign_selection, Fx_disown_selection_internal)
9446 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9447 (lisp_data_to_selection_data): Use cons_to_unsigned.
9448 (x_fill_property_data): Use cons_to_signed.
9449 Report values out of range.
9450
d1f3d2af
PE
9451 Check for buffer and string overflow more precisely.
9452 * buffer.h (BUF_BYTES_MAX): New macro.
9453 * lisp.h (STRING_BYTES_MAX): New macro.
9454 * alloc.c (Fmake_string):
9455 * character.c (string_escape_byte8):
9456 * coding.c (coding_alloc_by_realloc):
9457 * doprnt.c (doprnt):
9458 * editfns.c (Fformat):
9459 * eval.c (verror):
9460 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9461 since they may not be the same number.
9462 * editfns.c (Finsert_char):
9463 * fileio.c (Finsert_file_contents):
9464 Likewise for BUF_BYTES_MAX.
9465
dd52fcea
PE
9466 * image.c: Use ptrdiff_t, not int, for sizes.
9467 (slurp_file): Switch from int to ptrdiff_t.
9468 All uses changed.
9469 (slurp_file): Check that file size fits in both size_t (for
9470 malloc) and ptrdiff_t (for sanity and safety).
9471
7f9bbdbb
PE
9472 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9473 if b->modtime has its maximal value.
9474
dfe18f82
PE
9475 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9476
84acfcf0
PE
9477 Don't assume time_t can fit into int.
9478 * buffer.h (struct buffer.modtime): Now time_t, not int.
9479 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9480 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9481
ccd9a01a
PE
9482 Minor fixes for signed vs unsigned integers.
9483 * character.h (MAYBE_UNIFY_CHAR):
9484 * charset.c (maybe_unify_char):
9485 * keyboard.c (read_char, reorder_modifiers):
9486 XINT -> XFASTINT, since the integer must be nonnegative.
9487 * ftfont.c (ftfont_spec_pattern):
9488 * keymap.c (access_keymap, silly_event_symbol_error):
9489 XUINT -> XFASTINT, since the integer must be nonnegative.
9490 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9491 since it makes no difference and we prefer signed.
9492 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9493 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9494 nonnegative.
9495
d6d100dd
SM
94962011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9497
9498 * window.h (Fwindow_frame): Declare.
9499
2b6148e4
PE
95002011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9501
9502 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9503 (SPARE_MEMORY): Always define.
9504 (LARGE_REQUEST): Remove.
9505 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9506
f230ecc9
MR
95072011-06-06 Martin Rudalics <rudalics@gmx.at>
9508
727e958e
MR
9509 * lisp.h: Move EXFUNS for Fframe_root_window,
9510 Fframe_first_window and Fset_frame_selected_window to window.h.
9511
9512 * window.h: Move EXFUNS for Fframe_root_window,
9513 Fframe_first_window and Fset_frame_selected_window here from
9514 lisp.h.
9515
9516 * frame.c (Fwindow_frame, Fframe_first_window)
9517 (Fframe_root_window, Fframe_selected_window)
9518 (Fset_frame_selected_window): Move to window.c.
9519 (Factive_minibuffer_window): Move to minibuf.c.
9520 (Fother_visible_frames_p): New function.
9521
9522 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9523
f230ecc9
MR
9524 * window.c (decode_window, decode_any_window): Move up in code.
9525 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9526 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9527 (Fwindow_buffer): Move up and rewrite doc-string.
9528 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9529 (Fwindow_prev): New functions.
727e958e
MR
9530 (Fwindow_frame): Move here from frame.c. Accept any window as
9531 argument.
9532 (Fframe_root_window, Fframe_first_window)
9533 (Fframe_selected_window): Move here from frame.c. Accept frame
9534 or arbitrary window as argument. Update doc-strings.
9535 (Fminibuffer_window): Move up in code.
9536 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9537 (Fset_frame_selected_window): Move here from frame.c.
9538 Marginal rewrite.
727e958e
MR
9539 (Fselected_window, select_window, Fselect_window): Move up in
9540 code. Minor doc-string fixes.
f230ecc9 9541
4d09bcf6
PE
95422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9543
9544 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9545 Do not assume that spare memory exists; that assumption is valid
9546 only if SYSTEM_MALLOC.
9547 (LARGE_REQUEST): New macro, so that the issue of large requests
9548 is separated from the issue of spare memory.
9549
810928a2
AS
95502011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9551
172418ad
AS
9552 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9553 format. (Bug#8806)
9554
43f862f7
AS
9555 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9556
810928a2
AS
9557 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9558 before statements.
9559
a059fe24
JD
95602011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9561
9562 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9563
9564 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9565
9566 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9567 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9568
989bf368
JB
95692011-06-05 Juanma Barranquero <lekktu@gmail.com>
9570
9571 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9572
4b80f674
CY
95732011-06-04 Chong Yidong <cyd@stupidchicken.com>
9574
9575 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9576 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9577 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9578 New error handlers.
4b80f674
CY
9579 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9580 Obey Vx_select_enable_clipboard_manager. Catch errors in
9581 x_clipboard_manager_save (Bug#8779).
9582 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9583 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9584
99a33b77 95852011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9586
9587 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9588
99a33b77 95892011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9590
9591 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9592 in the current matrix if keep_current_p is non-zero.
9593
8264569d
EZ
95942011-06-04 Eli Zaretskii <eliz@gnu.org>
9595
9596 * bidi.c (bidi_level_of_next_char): Fix last change.
9597
57f97249
EZ
95982011-06-03 Eli Zaretskii <eliz@gnu.org>
9599
fec2107c 9600 Support bidi reordering of text covered by display properties.
57f97249 9601
fec2107c
EZ
9602 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9603 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9604 (bidi_cache_search, bidi_cache_iterator_state)
9605 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9606 (bidi_level_of_next_char, bidi_move_to_visually_next):
9607 Support character positions inside a run of characters covered by a
fec2107c
EZ
9608 display string.
9609 (bidi_paragraph_init, bidi_resolve_explicit_1)
9610 (bidi_level_of_next_char): Call bidi_fetch_char and
9611 bidi_fetch_char_advance instead of FETCH_CHAR and
9612 FETCH_CHAR_ADVANCE.
9613 (bidi_init_it): Initialize new members.
9614 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9615 definitions.
9616 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9617 instead of using explicit *_CHAR codes.
d6d100dd
SM
9618 (bidi_resolve_explicit, bidi_resolve_weak):
9619 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9620 bidirectional text is supported only in multibyte buffers.
9621 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9622 it to initialize the frame_window_p member of struct bidi_it.
9623 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9624 (bidi_resolve_explicit, bidi_resolve_weak)
9625 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9626 bidi_it->nchars is non-positive.
9627 (bidi_level_of_next_char): Don't try to lookup the cache for the
9628 next/previous character if nothing is cached there yet, or if we
9629 were just reseat()'ed to a new position.
c40e2fb2 9630
0e14fe90
EZ
9631 * xdisp.c (set_cursor_from_row): Set start and stop points
9632 according to the row's direction when priming the loop that looks
9633 for the glyph on which to display cursor.
9634 (single_display_spec_intangible_p): Function deleted.
9635 (display_prop_intangible_p): Reimplement to call
9636 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9637 Accept 3 additional arguments needed by handle_display_spec.
9638 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9639 values: lists, `(when COND...)' forms, etc.
9640 (single_display_spec_string_p): Support property values that are
9641 lists with the argument STRING its top-level element.
9642 (display_prop_string_p): Fix the condition for processing a
9643 property that is a list to be consistent with handle_display_spec.
fec2107c 9644 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9645 last portion of handle_display_prop.
9646 (compute_display_string_pos): Accept additional argument
9647 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9648 value of a `display' property is a "replacing spec".
9649 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9650 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9651 the display property, but just return a value indicating whether
9652 the display property will replace the characters it covers.
9653 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9654 frame_window_p members of struct bidi_it.
d6d100dd
SM
9655 (compute_display_string_pos, compute_display_string_end):
9656 New functions.
fec2107c
EZ
9657 (push_it): Accept second argument POSITION, where pop_it should
9658 jump to continue iteration.
9659 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9660
fec2107c
EZ
9661 * keyboard.c (adjust_point_for_property): Adjust the call to
9662 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9663
9664 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9665 (bidi_init_it): Update prototypes.
9666 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9667 (compute_display_string_pos, compute_display_string_end):
9668 Declare prototypes.
fec2107c
EZ
9669 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9670 EMACS_INT.
fc6f18ce 9671
40087514 96722011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9673
57f53182
PE
9674 Malloc failure behavior now depends on size of allocation.
9675 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9676 * lisp.h: Change signatures accordingly.
9677 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9678 All callers changed. (Bug#8762)
9679
9680 * gnutls.c: Use Emacs's memory allocators.
9681 Without this change, the gnutls library would invoke malloc etc.
9682 directly, which causes problems on non-SYNC_INPUT hosts, and which
9683 runs afoul of improving memory_full behavior. (Bug#8761)
9684 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9685 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9686 xfree instead of the default malloc, realloc, free.
9687 (Fgnutls_boot): No need to check for memory allocation failure,
9688 since xmalloc does that for us.
9689
ac32cd99 9690 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9691 * category.c (hash_get_category_set):
9692 * ccl.c (ccl_driver):
9693 * charset.c (Fdefine_charset_internal):
9694 * charset.h (struct charset.hash_index):
9695 * composite.c (get_composition_id, gstring_lookup_cache)
9696 (composition_gstring_put_cache):
9697 * composite.h (struct composition.hash_index):
9698 * dispextern.h (struct image.hash):
9699 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9700 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9701 (hashfn_equal, hashfn_user_defined, make_hash_table)
9702 (maybe_resize_hash_table, hash_lookup, hash_put)
9703 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9704 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9705 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9706 * image.c (make_image, search_image_cache, lookup_image)
9707 (xpm_put_color_table_h):
9708 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9709 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9710 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9711 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9712 * alloc.c (allocate_vectorlike):
9713 Check for overflow in vector size calculations.
9714 * ccl.c (ccl_driver):
9715 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9716 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9717 need to be updated by these changes.
40087514
PE
9718 * fns.c (make_hash_table, maybe_resize_hash_table):
9719 Check for integer overflow with large hash tables.
0de4bb68
PE
9720 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9721 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9722 (SXHASH_REDUCE): New macro.
9723 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9724 Use it instead of discarding useful hash info with large hash values.
9725 (sxhash_float): New function.
9726 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9727 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9728 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9729 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9730 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9731 Adjust signatures to match updated version of code.
9732 (consing_since_gc): Now EMACS_INT, since a single hash table can
9733 use more than INT_MAX bytes.
9734
698d32e2
DN
97352011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9736
9737 Make it possible to build with GCC-4.6+ -O2 -flto.
9738
9739 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9740
fd6fa53f
SM
97412011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9742
9743 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9744 Call minibuffer-inactive-mode.
9745
864db017
JB
97462011-05-31 Juanma Barranquero <lekktu@gmail.com>
9747
9748 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9749 Update dependencies.
9750
2ad0baf4
DN
97512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9752
9753 * data.c (init_data): Remove code for UTS, this system is not
9754 supported anymore.
9755
4fcc2638
DN
97562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9757
9758 Don't force ./temacs to start in terminal mode.
9759
9760 * frame.c (make_initial_frame): Initialize faces in all cases, not
9761 only when CANNOT_DUMP is defined.
9762 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9763
c56e0fd5
DN
97642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9765
9766 * dispnew.c (add_window_display_history): Use const for the string
9767 pointer. Remove declaration, not needed.
9768
333d54da 97692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9770
55d4c1b2 9771 Use 'inline', not 'INLINE'.
333d54da 9772 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9773 * alloc.c, fontset.c (INLINE): Remove.
9774 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9775 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9776 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9777 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9778 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9779
738db178
DN
97802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9781
9782 Make it possible to run ./temacs.
9783
9784 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9785 syms_of_callproc does the same thing. Remove test for
9786 "initialized", do it in the caller.
9787 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9788
620c53a6
SM
97892011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9790
9791 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9792 (read_minibuf): Use get_minibuffer.
9793 (syms_of_minibuf): Use DEFSYM.
9794 (Qmetadata): New var.
9795 * data.c (Qbuffer): Don't make it static.
9796 (syms_of_data): Use DEFSYM.
9797
e003a292
PE
97982011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9799
9800 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9801 (CCL_CODE_MIN): New macro.
9802
ed008a6d
PE
98032011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9804
3687c2ef
PE
9805 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9806
ed008a6d
PE
9807 * eval.c (Qdebug): Now static.
9808 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9809 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9810 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9811
d66c4c7c
CY
98122011-05-29 Chong Yidong <cyd@stupidchicken.com>
9813
9814 * image.c: Various fixes to ImageMagick code comments.
9815 (Fimagemagick_types): Doc fix.
9816
5fbc2025
PE
98172011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9818
0196f88a
PE
9819 Minor fixes prompted by GCC 4.6.0 warnings.
9820
9821 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9822
5fbc2025
PE
9823 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9824 (x_clipboard_manager_save_all): Move extern decl to ...
9825 * xterm.h: ... here, so that it can be checked for consistency.
9826
1dd3c2d9
CY
98272011-05-29 Chong Yidong <cyd@stupidchicken.com>
9828
9829 * xselect.c (x_clipboard_manager_save_frame)
9830 (x_clipboard_manager_save_all): New functions.
9831 (Fx_clipboard_manager_save): Lisp function deleted.
9832
9833 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9834 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9835
9836 * xterm.h: Update prototype.
9837
5ba6571d
WX
98382011-05-28 William Xu <william.xwl@gmail.com>
9839
9840 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9841 exiting (Bug#8239).
9842
3eaff834
JM
98432011-05-28 Jim Meyering <meyering@redhat.com>
9844
e1900994 9845 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9846 * fns.c (to_uchar): Define.
9847 (crypto_hash_function): Use it to convert some newly-signed
9848 variables to unsigned, to avoid sign-extension bugs. For example,
9849 without this change, (md5 "truc") would evaluate to
9850 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9851 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9852 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9853
0f6990a7
PE
98542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9855
9856 Integer overflow fixes.
c8a9ca5a 9857
08686060
PE
9858 * dbusbind.c: Serial number integer overflow fixes.
9859 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9860 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9861 to hold a serial number that is too large for a fixnum.
9862 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9863 Check for serial numbers out of range. Decode any serial number
59568bf0 9864 that was so large that it became a float. (Bug#8722)
08686060 9865
2d1fc3c7
PE
9866 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9867 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9868 Use XFASTINT rather than XUINT when numbers are nonnegative.
9869 (xd_append_arg, Fdbus_method_return_internal):
9870 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9871 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9872 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9873 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9874 (Bug#8722)
2d1fc3c7 9875
c8a9ca5a
PE
9876 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9877
519e1d69
PE
9878 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9879
6df6ae42 9880 ccl: Add integer overflow checks.
30569699
PE
9881 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9882 (IN_INT_RANGE): New macros.
9883 (ccl_driver): Use them to check for integer overflow when
9884 decoding a CCL program. Many of the new checks are whether XINT (x)
9885 fits in int; it doesn't always, on 64-bit hosts. The new version
9886 doesn't catch all possible integer overflows, but it's an
847044ea 9887 improvement. (Bug#8719)
30569699 9888
c11285dc
PE
9889 * alloc.c (make_event_array): Use XINT, not XUINT.
9890 There's no need for unsigned here.
9891
fdccd48e
PE
9892 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9893 This follows up to the 2011-05-06 change that substituted uintptr_t
9894 for EMACS_INT. This case wasn't caught back then.
9895
37910ab2
PE
9896 Rework Fformat to avoid integer overflow issues.
9897 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9898 now (part of C89). Include <verify.h>.
9899 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9900 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9901 (Fformat): Avoid the prepass trying to compute sizes; it was only
9902 approximate and thus did not catch overflow reliably. Instead, walk
9903 through the format just once, formatting and computing sizes as we go,
9904 checking for integer overflow at every step, and allocating a larger
9905 buffer as needed. Keep track separately whether the format is
9906 multibyte. Keep only the most-recently calculated precision, rather
9907 than them all. Record whether each argument has been converted to
9908 string. Use EMACS_INT, not int, for byte and char and arg counts.
9909 Support field widths and precisions larger than INT_MAX. Avoid
9910 sprintf's undefined behavior with conversion specifications such as %#d
9911 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9912 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9913 formatting out-of-range floating point numbers with int
9173deec 9914 formats. (Bug#8668)
37910ab2 9915
2e6578fb
PE
9916 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9917
0ae6bdee
PE
9918 * data.c: Avoid integer truncation in expressions involving floats.
9919 * data.c: Include <intprops.h>.
9920 (arith_driver): When there's an integer overflow in an expression
9921 involving floating point, convert the integers to floating point
9922 so that the resulting value does not suffer from catastrophic
9923 integer truncation. For example, on a 64-bit host (* 4
9924 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9925 Do not rely on undefined behavior after integer overflow.
9926
de883a70
PE
9927 merge count_size_as_multibyte, parse_str_to_multibyte
9928 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9929 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9930 Check for integer overflow.
9931 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9932 since it's now a duplicate of the other. This is more of
9933 a character than a buffer op, so better that it's in character.c.
9934 * fns.c, print.c: Adjust to above changes.
9935
2ff916cb
PE
99362011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9937
9938 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9939
f1b54466
PE
99402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9941
fb1ac845
PE
9942 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9943 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9944 (x_clipboard_manager_save): Now static.
9945 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9946
f1b54466
PE
9947 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9948 (crypto_hash_function): Now static.
9949 Fix pointer signedness problems. Avoid unnecessary initializations.
9950
a9f737ee
CY
99512011-05-27 Chong Yidong <cyd@stupidchicken.com>
9952
9953 * termhooks.h (Vselection_alist): Make it terminal-local.
9954
9955 * terminal.c (create_terminal): Initialize it.
9956
9957 * xselect.c: Support for clipboard managers.
9958 (Vselection_alist): Move to termhooks.h as terminal-local var.
9959 (LOCAL_SELECTION): New macro.
9960 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9961 (symbol_to_x_atom): Remove gratuitous arg.
9962 (x_handle_selection_request, lisp_data_to_selection_data)
9963 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9964 (x_own_selection, x_get_local_selection, x_convert_selection):
9965 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9966 (some_frame_on_display): Delete unused function.
9967 (Fx_own_selection_internal, Fx_get_selection_internal)
9968 (Fx_disown_selection_internal, Fx_selection_owner_p)
9969 (Fx_selection_exists_p): New optional frame arg.
9970 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9971 (x_handle_selection_clear): Don't treat other terminals with the
9972 same keyboard specially. Use the terminal-local Vselection_alist.
9973 (x_clear_frame_selections): Use Frun_hook_with_args.
9974
9975 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9976
9977 * xterm.h: Add support for those atoms.
9978
e067f0c1
CY
99792011-05-26 Chong Yidong <cyd@stupidchicken.com>
9980
9981 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9982 (converted_selections, conversion_fail_tag): New global variables.
9983 (x_selection_request_lisp_error): Free the above.
9984 (x_get_local_selection): Remove unnecessary code.
9985 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9986 of converted selections stored in converted_selections.
9987 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9988 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9989 (x_convert_selection): New function.
9990 (x_handle_selection_event): Simplify.
9991 (x_get_foreign_selection): Don't ignore incoming requests while
9992 waiting for an answer; this will fail when we implement
9993 SAVE_TARGETS, and seems unnecessary anyway.
9994 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9995 (Vx_sent_selection_functions): Doc fix.
9996
0f4aebc0
LL
99972011-05-26 Leo Liu <sdl.web@gmail.com>
9998
9999 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10000
e61124cd
YM
100012011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10002
10003 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10004
10005 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10006 for fringe update if it has periodic bitmap.
ac389d0c 10007 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10008 and fringe_bitmap_periodic_p.
10009
10010 * fringe.c (get_fringe_bitmap_data): New function.
10011 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10012 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10013 row. Mark glyph row for fringe update if periodicity changed.
10014
10015 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10016 for fringe update unless it has periodic bitmap.
10017
f16d9837
KH
100182011-05-25 Kenichi Handa <handa@m17n.org>
10019
10020 * xdisp.c (get_next_display_element): Set correct it->face_id for
10021 a static composition.
10022
e1b90ef6
LL
100232011-05-24 Leo Liu <sdl.web@gmail.com>
10024
10025 * deps.mk (fns.o):
10026 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10027
10028 * fns.c (crypto_hash_function, Fsha1): New function.
10029 (Fmd5): Use crypto_hash_function.
10030 (syms_of_fns): Add Ssha1.
10031
7400048f
PE
100322011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10033
10034 * gnutls.c: Remove unused macros.
10035 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10036 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10037 Remove macros that are defined and never used.
10038 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10039
abb71cf4
CY
100402011-05-22 Chong Yidong <cyd@stupidchicken.com>
10041
10042 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10043 (Fx_get_selection_internal): Minor cleanup.
10044 (Fx_own_selection_internal): Rename arguments for consistency with
10045 select.el.
10046
6307db39
PE
100472011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10048
10049 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10050
f3d4e0a4
CY
100512011-05-22 Chong Yidong <cyd@stupidchicken.com>
10052
10053 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10054
4d8ade89
YM
100552011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10056
10057 * dispnew.c (scrolling_window): Don't exclude the case that the
10058 last enabled row in the desired matrix touches the bottom boundary.
10059
32078c8d
GM
100602011-05-21 Glenn Morris <rgm@gnu.org>
10061
10062 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10063 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10064 and add some more files.
32078c8d 10065
7285dc67
EZ
100662011-05-20 Eli Zaretskii <eliz@gnu.org>
10067
10068 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10069 report_file_error introduced by the change from 2011-05-07.
10070
89d1bd22
PE
100712011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10072
10073 * systime.h (Time): Define only if emacs is defined.
10074 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10075 where the include path doesn't have X11/X.h by default. See
10076 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10077
cd394be1 100782011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10079
10080 * composite.c (find_automatic_composition): Fix previous change.
10081
b9704ad9
GM
100822011-05-20 Glenn Morris <rgm@gnu.org>
10083
10084 * lisp.mk: New file, split from Makefile.in.
10085 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10086 (shortlisp): Remove.
10087 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10088
4a720484
GM
100892011-05-19 Glenn Morris <rgm@gnu.org>
10090
10091 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10092 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10093 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10094 (lisp): Set the order to that of loadup.el.
10095 (shortlisp): Make it a copy of $lisp.
10096 (SOME_MACHINE_LISP): Remove.
10097 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10098 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10099
a28d4396
KH
101002011-05-18 Kenichi Handa <handa@m17n.org>
10101
10102 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10103 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10104 (find_automatic_composition): Mostly rewrite for efficiency.
10105
a2b1fa8e
JB
101062011-05-18 Juanma Barranquero <lekktu@gmail.com>
10107
10108 * makefile.w32-in: Update dependencies.
10109
8e1f5610
CS
101102011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10111
10112 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10113 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10114
7025ee00 101152011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10116
cdfa6eab
PE
10117 Fix some integer overflow issues, such as string length overflow.
10118
06d6db33
PE
10119 * insdel.c (count_size_as_multibyte): Check for string overflow.
10120
2b4560a8
PE
10121 * character.c (lisp_string_width): Check for string overflow.
10122 Use EMACS_INT, not int, for string indexes and lengths; in
10123 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10124 the resulting string length overflows an EMACS_INT; instead,
10125 report a string overflow if no precision given. When checking for
10126 precision exhaustion, use a check that cannot possibly have
10127 integer overflow. (Bug#8675)
10128 * character.h (lisp_string_width): Adjust to new signature.
10129
cb93f9be
PE
10130 * alloc.c (string_overflow): New function.
10131 (Fmake_string): Use it. This doesn't change behavior, but saves
10132 a few bytes and will simplify future changes.
10133 * character.c (string_escape_byte8): Likewise.
10134 * lisp.h (string_overflow): New decl.
10135
1a1f3366
PE
10136 Fixups, following up to the user-interface timestamp change.
10137 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10138 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10139 * msdos.c (mouse_get_pos): Likewise.
10140 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10141 * w32gui.h (Time): Define by including "systime.h" rather than by
10142 declaring it ourselves. (Bug#8664)
10143
d4e3e4d3
PE
10144 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10145 * image.c (clear_image_cache): Likewise.
10146
f6a24d19
PE
10147 * term.c (term_mouse_position): Don't assume time_t wraparound.
10148
08dc5ae6
PE
10149 Be more systematic about user-interface timestamps.
10150 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10151 and sometimes 'EMACS_UINT', to represent these timestamps.
10152 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10153 This makes the code easier to follow, and makes it easier to catch
10154 integer overflow bugs such as Bug#8664.
10155 * frame.c (Fmouse_position, Fmouse_pixel_position):
10156 Use Time, not unsigned long, for user-interface timestamps.
10157 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10158 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10159 * keyboard.h (last_event_timestamp): Likewise.
10160 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10161 * menu.h (xmenu_show): Likewise.
10162 * term.c (term_mouse_position): Likewise.
10163 * termhooks.h (struct input_event.timestamp): Likewise.
10164 (struct terminal.mouse_position_hook): Likewise.
10165 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10166 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10167 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10168 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10169 what it was before.
10170 * menu.h, termhooks.h: Include "systime.h", for Time.
10171
8e55734a
PE
10172 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10173 Don't assume that the difference between two unsigned long values
10174 can fit into an integer. At this point, we know button_down_time
10175 <= event->timestamp, so the difference must be nonnegative, so
10176 there's no need to cast the result if double-click-time is
10177 nonnegative, as it should be; check that it's nonnegative, just in
10178 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10179 apart (about 25 days). (Bug#8664)
8e55734a 10180
841f1b75 10181 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10182 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10183
3e26f69c
PE
10184 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10185 that always fit in int. Use a sentinel instead of a counter, to
10186 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10187 * frame.h (struct frame): Use int for menu_bar_items_used
10188 instead of EMACS_INT, since it always fits in int.
3e26f69c 10189
5cc152c0
PE
10190 * menu.c (grow_menu_items): Check for int overflow.
10191
d89eb65e
PE
10192 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10193
5235bd3e
PE
10194 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10195 Before, the code was not consistent. These values cannot exceed
10196 2**31 - 1 so there's no need to make them unsigned.
10197 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10198 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10199 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10200 as modifiers.
10201 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10202
bc827e23
PE
10203 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10204 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10205 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10206 presumably because the widths might not match.
10207
78eb494e
PE
10208 * window.c (size_window): Avoid needless test at loop start.
10209
04f2d78b
CB
102102011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10211
10212 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10213
d2fc7e3d 102142011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10215
10216 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10217
d2fc7e3d 102182011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10219
10220 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10221 `width' to `bar_area_x' and `bar_area_width', respectively.
10222 (x_scroll_run): Take account of fringe background extension.
10223
04f2d78b
CB
10224 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10225 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10226 `bar_area_width', respectively.
10227 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10228 background extension.
10229
79b70037
GM
102302011-05-10 Jim Meyering <meyering@redhat.com>
10231
10232 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10233
2f142cc5
JB
102342011-05-10 Juanma Barranquero <lekktu@gmail.com>
10235
10236 * image.c (Finit_image_library): Return t for built-in image types,
10237 like pbm and xbm. (Bug#8640)
10238
57679c86
AS
102392011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10240
10241 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10242
888c9e86
EZ
102432011-05-07 Eli Zaretskii <eliz@gnu.org>
10244
b0512a1d
EZ
10245 * w32console.c (Fset_screen_color): Doc fix.
10246 (Fget_screen_color): New function.
10247 (syms_of_ntterm): Defsubr it.
10248
7285dc67
EZ
10249 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10250 unlink the temporary file if Fcall_process didn't create it in the
10251 first place.
10252 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10253 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10254 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10255 cue to call_process_cleanup not to close that handle.
10256
4d3fcc8e
BK
102572011-05-07 Ben Key <bkey76@gmail.com>
10258
10259 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10260 one of two shell specific rules, either bootstrap-temacs-CMD or
10261 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10262 to the previous implementation of the bootstrap-temacs rule.
10263 The bootstrap-temacs-CMD rule is similar to the previous
10264 implementation of the bootstrap-temacs rule except that it
10265 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10266 variable.
10267
10268 These changes, along with some changes to nt/configure.bat,
10269 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10270 earlier fix to add support for --cflags and --ldflags options
10271 that include quotes so that it works whether make uses cmd or
10272 sh as the shell.
10273
b4289b64
MA
102742011-05-06 Michael Albinus <michael.albinus@gmx.de>
10275
10276 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10277 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10278 is a constant.
10279 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10280 a string. Handle both cases.
10281 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10282 (Fdbus_register_method): Use Qinvalid_function.
10283
af4c0e28
JB
102842011-05-06 Juanma Barranquero <lekktu@gmail.com>
10285
10286 * makefile.w32-in: Update dependencies.
10287 (LISP_H): Add inttypes.h and stdin.h.
10288 (PROCESS_H): Add unistd.h.
10289
c51453d9
EZ
102902011-05-06 Eli Zaretskii <eliz@gnu.org>
10291
10292 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10293 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10294
8ff0ac3c 102952011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10296
4c4b566b
PE
10297 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10298
aab2b9b5
PE
10299 * term.c (vfatal): Remove stray call to va_end.
10300 It's not needed and the C Standard doesn't allow it here anyway.
10301
c378da0b
PE
10302 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10303 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10304
288b08c7
PE
10305 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10306 bytes.
10307
e3601888
PE
10308 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10309
db6c0e74
PE
10310 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10311
dd5963ea
PE
10312 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10313
88c9450f
PE
10314 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10315
2f9442b8
PE
10316 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10317
c032b5f8
PE
10318 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10319 * charset.c (Fdefine_charset_internal): Don't initialize
10320 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10321 32-bit int (Bug#8600).
a108c10b
PE
10322
10323 * lread.c (read_integer): Be more consistent with string-to-number.
10324 Use string_to_number to do the actual conversion; this avoids
10325 rounding errors and fixes some other screwups. Without this fix,
10326 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10327 (digit_to_number): Move earlier, for benefit of read_integer.
10328 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10329 not a digit in any supported base. (Bug#8602)
a108c10b 10330
ad5f9eea
PE
10331 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10332
aec1708a
PE
10333 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10334 to match comment at start of function. This also removes a
10335 GCC warning about overflow in a 32+64-bit port.
10336
47be4ab5
PE
10337 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10338
371cac43
PE
10339 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10340 Reported by Stefan Monnier in
10341 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10342 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10343 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10344
d01a7826
PE
10345 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10346 (EMACS_UINTPTR): Likewise, with uintptr_t.
10347
7fd47d5c
PE
10348 * lisp.h: Prefer 64-bit EMACS_INT if available.
10349 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10350 on 32-bit hosts that have 64-bit int, so that they can access
10351 large files.
122b0c86
PE
10352 However, temporarily disable this change unless the temporary
10353 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10354
8727937b
PE
10355 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10356
8ac068ac
PE
10357 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10358 This removes an assumption that EMACS_INT and long are the same
10359 width as pointers. The assumption is true for Emacs porting targets
10360 now, but we want to make other targets possible.
10361 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10362 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10363 In the rest of the code, change types of integers that hold casted
10364 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10365 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10366 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10367 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10368 No need to cast type when ORing.
10369 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10370 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10371 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10372 assume EMACS_INT is the same width as char *.
10373 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10374 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10375 Remove no-longer-needed casts.
10376 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10377 (xg_tool_bar_help_callback, xg_make_tool_item):
10378 Use EMACS_INTPTR to hold an integer
10379 that will be cast to void *; this can avoid a GCC warning
10380 if EMACS_INT is not the same width as void *.
10381 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10382 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10383 (current_message_1, set_message_1):
10384 Use a local to convert to proper width without a cast.
10385 * xmenu.c (dialog_selection_callback): Likewise.
10386
ede49d71
PE
10387 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10388 Also, don't assume VALBITS / RAND_BITS is less than 5,
10389 and don't rely on undefined behavior when shifting a 1 left into
10390 the sign bit.
10391 * lisp.h (get_random): Change signature to match.
10392
2f30ecd0
PE
10393 * lread.c (hash_string): Use size_t, not int, for hash computation.
10394 Normally we prefer signed values; but hashing is special, because
10395 it's better to use unsigned division on hash table sizes so that
10396 the remainder is nonnegative. Also, size_t is the natural width
10397 for hashing into memory. The previous code used 'int', which doesn't
10398 retain enough info to hash well into very large tables.
10399 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10400
2a866e7b
PE
10401 * dbusbind.c: Don't possibly lose pointer info when converting.
10402 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10403 Use XPNTR rather than XHASH, so that the high-order bits of
10404 the pointer aren't lost when converting through void *.
10405
51639eac
PE
10406 * eval.c (Fautoload): Don't double-shift a pointer.
10407
92394119
PE
10408 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10409
dbdb9a7c
JB
104102011-05-06 Juanma Barranquero <lekktu@gmail.com>
10411
10412 * gnutls.c (DEF_GNUTLS_FN):
10413 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10414
db7a0b4f
AS
104152011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10416
10417 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10418 marker. (Bug#8610)
10419
cd394be1 104202011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10421
10422 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10423 New version that can reserve upto 2GB of heap space.
10424
f7ff1b0f 104252011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10426
10427 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10428
639c109b
TZ
104292011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10430
10431 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10432 `gnutls_certificate_set_x509_key_file'.
10433
d2127135
JB
104342011-05-05 Juanma Barranquero <lekktu@gmail.com>
10435
10436 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10437 Update dependencies.
10438
e968f4f3
JB
104392011-05-04 Juanma Barranquero <lekktu@gmail.com>
10440
10441 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10442 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10443 Remove unused parameter `fildes'.
10444 * process.c (read_process_output, send_process): Don't pass it.
10445
84d358f0
JB
104462011-05-04 Juanma Barranquero <lekktu@gmail.com>
10447
10448 Fix previous change: the library cache is defined in w32.c.
10449 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10450 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10451
0898ca10
JB
104522011-05-04 Juanma Barranquero <lekktu@gmail.com>
10453
10454 Implement dynamic loading of GnuTLS on Windows.
10455
10456 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10457 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10458 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10459 Declare.
10460
10461 * gnutls.c (Qgnutls_dll): Define.
10462 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10463 (gnutls_*): Declare function pointers.
10464 (init_gnutls_functions): New function to initialize function pointers.
10465 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10466 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10467 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10468 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10469 (emacs_gnutls_write, emacs_gnutls_read)
10470 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10471 (Fgnutls_available_p): New function.
10472 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10473 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10474 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10475
10476 * image.c: Include w32.h.
10477 (Vimage_type_cache): Delete.
10478 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10479 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10480 (w32_delayed_load): Move to w32.c.
10481
10482 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10483
10484 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10485 (w32_delayed_load): Move from image.c. When loading a library, record
10486 its filename in the :loaded-from property of the library id.
10487 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10488 Initialize and staticpro them.
10489 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10490
10491 * process.c: Include lisp.h before w32.h, not after.
10492 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10493 instead of gnutls_record_check_pending.
10494
10495 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10496
ff4de4aa
TZ
104972011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10498
10499 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10500 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10501 as passed in.
10502
abe95abb
JD
105032011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10504
10505 * xterm.c (x_set_frame_alpha): Do not set property on anything
10506 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10507
e16e55d4
JB
105082011-05-02 Juanma Barranquero <lekktu@gmail.com>
10509
10510 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10511
bafcf6a5
JB
105122011-05-02 Juanma Barranquero <lekktu@gmail.com>
10513
10514 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10515 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10516 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10517 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10518 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10519 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10520 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10521 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10522 (Qgnutls_bootprop_callbacks_verify): Make static.
10523
e7a6747f
AS
105242011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10525
19ed11ba
AS
10526 * callproc.c: Indentation fixup.
10527
e7a6747f 10528 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10529 (wait_for_termination, interruptible_wait_for_termination):
10530 Move after wait_for_termination_1.
e7a6747f 10531
1ef14cb4
LMI
105322011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10533
10534 * sysdep.c (interruptible_wait_for_termination): New function
10535 which is like wait_for_termination, but allows keyboard
10536 interruptions.
10537
10538 * callproc.c (Fcall_process): Add (:file "file") as an option for
10539 the STDOUT buffer.
10540 (Fcall_process_region): Ditto.
10541
330d880c
EZ
105422011-04-30 Eli Zaretskii <eliz@gnu.org>
10543
8db90b73
EZ
10544 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10545 rather than `XVECTOR (FOO)->size'.
10546
330d880c
EZ
10547 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10548 inttypes.h, as a gnulib replacement is used if it not available in
10549 system headers.
10550
15cbd324
EZ
105512011-04-21 Eli Zaretskii <eliz@gnu.org>
10552
10553 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10554 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10555 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10556
10557 * coding.c (coding_alloc_by_realloc): Error out if destination
10558 will grow beyond MOST_POSITIVE_FIXNUM.
10559 (decode_coding_emacs_mule): Abort if there isn't enough place in
10560 charbuf for the composition carryover bytes. Reserve an extra
10561 space for up to 2 characters produced in a loop.
10562 (decode_coding_iso_2022): Abort if there isn't enough place in
10563 charbuf for the composition carryover bytes.
10564
105652011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10566
ae940cca
EZ
10567 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10568 aborting when %lld or %lll format is passed.
10569 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10570 %llo or %llx format is passed. (Bug#8545)
10571
03ab8921
EZ
10572 * window.c (window_scroll_line_based): Use a marker instead of
10573 simple variables to record original value of point. (Bug#7952)
10574
afda1437
EZ
10575 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10576 produced by %s or %c overflows available buffer space. (Bug#8545)
10577
f76dee0c
PE
105782011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10579
10580 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10581 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10582
fdc5744d
JB
105832011-04-28 Juanma Barranquero <lekktu@gmail.com>
10584
10585 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10586
638f053a
JB
105872011-04-28 Juanma Barranquero <lekktu@gmail.com>
10588
10589 * keyboard.c (Qdelayed_warnings_hook): Define.
10590 (command_loop_1): Run `delayed-warnings-hook'
10591 if Vdelayed_warnings_list is non-nil.
10592 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10593 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10594
d178f871
EZ
105952011-04-28 Eli Zaretskii <eliz@gnu.org>
10596
10597 * doprnt.c (doprnt): Don't return value smaller than the buffer
10598 size if the message was truncated. (Bug#8545).
10599
b124fd93
JB
106002011-04-28 Juanma Barranquero <lekktu@gmail.com>
10601
10602 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10603 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10604
e810457d
PE
106052011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10606
10607 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10608
ea51cceb
JB
106092011-04-27 Juanma Barranquero <lekktu@gmail.com>
10610
10611 * makefile.w32-in: Update dependencies.
10612
94dcfacf
EZ
106132011-04-27 Eli Zaretskii <eliz@gnu.org>
10614
10615 Improve `doprnt' and its usage. (Bug#8545)
10616 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10617 `format_end'. Remove support for %l as a conversion specifier.
10618 Don't use xrealloc. Improve diagnostics when the %l size modifier
10619 is used. Update the commentary.
10620
10621 * eval.c (verror): Simplify calculation of size_t.
10622
10623 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10624 messages.
10625
f61f41d7
PE
106262011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10627
10628 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10629 change.
10630
96fb4434
PE
106312011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10632
10633 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10634 This makes this file independent of the recent pseudovector change.
10635
671875da 106362011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10637
69e9b5a3
PE
10638 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10639
b5f869a7 10640 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10641 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10642 Remove unused local.
c8926152 10643 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10644
841a1577 10645 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10646 GCC 4.6.0 optimizes based on type-based alias analysis.
10647 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10648 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10649 != &v->size, and therefore "v->size = 1; b->size = 2; return
10650 v->size;" must therefore return 1. This assumption is incorrect
10651 for Emacs, since it type-puns struct Lisp_Vector * with many other
10652 types. To fix this problem, this patch adds a new type struct
f904488f 10653 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10654 and pseudovectors, and helps optimizing compilers not get fooled
10655 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10656 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10657 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10658 the size member.
eab3844f
PE
10659 (XSETPVECTYPE): Rewrite in terms of new macro.
10660 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10661 This is a bit clearer, and further avoids the possibility of
10662 undesirable aliasing.
10663 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10664 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10665 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10666 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10667 (ASIZE): Now uses header.size rather than size.
10668 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10669 to avoid the hassle of writing XVECTOR (foo)->header.size.
10670 (struct vectorlike_header): New type.
eab3844f
PE
10671 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10672 object, to help avoid aliasing.
10673 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10674 (SUBRP): Likewise, since Lisp_Subr is a special case.
10675 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10676 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10677 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10678 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10679 changed to be "header.size" and "header.next".
10680 * buffer.h (struct buffer): Likewise.
10681 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10682 * frame.h (struct frame): Likewise.
10683 * process.h (struct Lisp_Process): Likewise.
10684 * termhooks.h (struct terminal): Likewise.
10685 * window.c (struct save_window_data, struct saved_window): Likewise.
10686 * window.h (struct window): Likewise.
10687 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10688 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10689 * buffer.c (init_buffer_once): Likewise.
10690 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10691 special case.
10692 * process.c (Fformat_network_address): Use local var for size,
10693 for brevity.
10694
0df1eac5
PE
10695 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10696
847ab9d1 10697 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10698 * data.c (atof): Remove decl; no longer used or needed.
10699 (digit_to_number): Move to lread.c.
10700 (Fstring_to_number): Use new string_to_number function, to be
10701 consistent with how the Lisp reader treats infinities and NaNs.
10702 Do not assume that floating-point numbers represent EMACS_INT
10703 without losing information; this is not true on most 64-bit hosts.
10704 Avoid double-rounding errors, by insisting on integers when
10705 parsing non-base-10 numbers, as the documentation specifies.
10706 * lisp.h (string_to_number): New decl, replacing ...
10707 (isfloat_string): Remove.
bc0a5c13 10708 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10709 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10710 appears to have been a coding error. Similarly, do not accept
10711 strings like +-1e0 as floating point numbers. Do not report
10712 overflow for integer overflows unless the base is not 10 which
10713 means we have no simple and reliable way to continue.
10714 Break out the floating-point parsing into a new
10715 function string_to_number, so that Fstring_to_number parses
10716 floating point numbers consistently with the Lisp reader.
04f2d78b 10717 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10718 (E_CHAR, EXP_INT): Remove, replacing with ...
10719 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10720 (string_to_number): New function, replacing isfloat_string.
10721 This function checks for valid syntax and produces the resulting
10722 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10723 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10724 so that overflow for non-base-10 numbers is reported only when
10725 there's no portable and simple way to convert to floating point.
452f4150 10726
67769ffc
PE
10727 * textprop.c (set_text_properties_1): Rewrite for clarity,
10728 and to avoid GCC warning about integer overflow.
10729
c20db43f
PE
10730 * intervals.h (struct interval): Use EMACS_INT for members
10731 where EMACS_UINT might cause problems. See
10732 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10733 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10734 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10735 All uses changed.
37aa2f85
PE
10736 (offset_intervals): Tell GCC not to worry about length overflow
10737 when negating a negative length.
c20db43f 10738
2538aa2f
PE
10739 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10740 (overrun_check_free): Likewise.
10741
f2d3008d
PE
10742 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10743 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10744 word size.
10745
ec8df744
PE
10746 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10747 (gnutls_make_error): Rename local to avoid shadowing.
10748 (gnutls_emacs_global_deinit): ifdef out; not used.
10749 (Fgnutls_boot): Use const for pointer to readonly storage.
10750 Comment out unused local. Fix pointer signedness problems.
10751
640ee02d
PE
10752 * lread.c (openp): Don't stuff size_t into an 'int'.
10753 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10754 about possible signed overflow.
10755
6048fb2a
PE
10756 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10757 (GDK_KEY_g): Don't define if already defined.
10758 (xg_prepare_tooltip): Avoid pointer signedness problem.
10759 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10760
fa3c87e1
PE
10761 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10762 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10763
2172544b
PE
10764 * xfns.c (Fx_window_property): Simplify a bit,
10765 to make a bit faster and to avoid GCC 4.6.0 warning.
10766 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10767
9b821a21
PE
10768 * fns.c (internal_equal): Don't assume size_t fits in int.
10769
3c616cfa
PE
10770 * alloc.c (compact_small_strings): Tighten assertion a little.
10771
c2982e87
PE
10772 Replace pEd with more-general pI, and fix some printf arg casts.
10773 * lisp.h (pI): New macro, generalizing old pEd macro to other
10774 conversion specifiers. For example, use "...%"pI"d..." rather
10775 than "...%"pEd"...".
10776 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10777 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10778 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10779 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10780 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10781 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10782 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10783 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10784 64-bit hosts.
10785 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10786 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10787 * print.c (safe_debug_print, print_object): Likewise.
10788 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10789 to int.
6f04d126
PE
10790 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10791 avoiding the 0 flag, which is not portable.
c2982e87
PE
10792 * process.c (Fmake_network_process): Use pI to avoid cast.
10793 * region-cache.c (pp_cache): Likewise.
10794 * xdisp.c (decode_mode_spec): Likewise.
10795 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10796 behavior on 64-bit hosts with printf arg.
6f04d126 10797 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10798 (x_stop_queuing_selection_requests): Likewise.
10799 (x_get_window_property): Don't truncate byte count to an 'int'
10800 when tracing.
0b432f21 10801
5e073ec7
PE
10802 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10803 here, since it parses constructs like leading '-' and spaces,
10804 which are not wanted; and it overflows with large numbers.
10805 Instead, simply match F[0-9]+, which is what is wanted anyway.
10806
36372bf9
PE
10807 * alloc.c: Remove unportable assumptions about struct layout.
10808 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10809 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10810 (allocate_vectorlike, make_pure_vector): Use the new macros,
10811 plus offsetof, to remove unportable assumptions about struct layout.
10812 These assumptions hold on all porting targets that I know of, but
10813 they are not guaranteed, they're easy to remove, and removing them
10814 makes further changes easier.
10815
0b432f21
PE
10816 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10817 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10818 (string_overrun_cookie): Now const. Use initializers that
10819 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10820 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10821 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10822 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10823 multiple of sizeof (EMACS_INT); it need not be, if
10824 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10825 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10826
895009e1
JB
108272011-04-26 Juanma Barranquero <lekktu@gmail.com>
10828
10829 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10830
6a7a1b0b
TZ
108312011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10832
10833 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10834 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10835 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10836
841a1577 108372011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10838
10839 * lisp.h (Qdebug): List symbol.
895009e1 10840 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10841 * keyboard.c (debug-on-event): New variable.
10842 (handle_user_signal): Break into debugger when debug-on-event
10843 matches the current signal symbol.
10844
f2d3ba6f
DN
108452011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10846
10847 * alloc.c (check_sblock, check_string_bytes)
10848 (check_string_free_list): Convert to standard C.
10849
42ce4c63
TZ
108502011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10851
10852 * w32.c (emacs_gnutls_push): Fix typo.
10853
825cd63c
EZ
108542011-04-25 Eli Zaretskii <eliz@gnu.org>
10855
fb11d64d
EZ
10856 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10857 "cast to pointer from integer of different size".
10858
825cd63c
EZ
10859 Improve doprnt and its use in verror. (Bug#8545)
10860 * doprnt.c (doprnt): Document the set of format control sequences
10861 supported by the function. Use SAFE_ALLOCA instead of always
10862 using `alloca'.
10863
10864 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10865 is one byte too soon. Don't use xrealloc; instead xfree and
10866 xmalloc anew.
10867
e061a11b
TZ
108682011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10869
10870 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10871 callbacks stage.
10872
10873 * gnutls.c: Renamed global_initialized to
10874 gnutls_global_initialized. Added internals for the
10875 :verify-hostname-error, :verify-error, and :verify-flags
10876 parameters of `gnutls-boot' and documented those parameters in the
10877 docstring. Start callback support.
9173deec
JB
10878 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10879 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10880 on error. Return error code.
e061a11b
TZ
10881 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10882 (emacs_gnutls_read): Likewise.
10883 (Fgnutls_boot): Return handshake error code.
10884 (emacs_gnutls_handle_error): New function.
10885 (wsaerror_to_errno): Likewise.
10886
10887 * w32.h (emacs_gnutls_pull): Add prototype.
10888 (emacs_gnutls_push): Likewise.
10889
10890 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10891 (emacs_gnutls_push): Likewise.
10892
108932011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10894
10895 * process.c (wait_reading_process_output): Check if GnuTLS
10896 buffered some data internally if no FDs are set for TLS
10897 connections.
10898
10899 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10900 (LIBS): Link to USER_LIBS.
10901 ($(BLD)/gnutls.$(0)): New target.
10902
fa6996bc
EZ
109032011-04-24 Eli Zaretskii <eliz@gnu.org>
10904
eb35682e
EZ
10905 * xdisp.c (handle_single_display_spec): Rename the
10906 display_replaced_before_p argument into display_replaced_p, to
10907 make it consistent with the commentary. Fix typos in the
10908 commentary.
10909
e2ad650c
EZ
10910 * textprop.c (syms_of_textprop): Remove dead code.
10911 (copy_text_properties): Delete obsolete commentary about an
10912 interface that was deleted long ago. Fix typos in the description
10913 of arguments.
10914
1b2de274
EZ
10915 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10916 to changes in oldXMenu/XMenu.h from 2011-04-16.
10917 <menu_help_message, prev_menu_help_message>: Constify.
10918 (IT_menu_make_room): menu->help_text is now `const char **';
10919 adjust.
10920
10921 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10922 to changes in oldXMenu/XMenu.h from 2011-04-16.
10923 (struct XMenu): Declare `help_text' `const char **'.
10924
10925 * xfaces.c <Qunspecified>: Make extern again.
10926
10927 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10928 required by POSIX.
1b2de274 10929
762b15be
EZ
10930 * doc.c (get_doc_string): Improve the format passed to `error'.
10931
10932 * doprnt.c (doprnt): Improve commentary.
10933
10934 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10935
10936 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10937 them with etags.
10938
f1052e5d
EZ
10939 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10940 changes in globals.h immediately force recompilation.
762b15be
EZ
10941 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10942 $(CURDIR)/s/ms-w32.h.
10943 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10944
fa6996bc
EZ
10945 * character.c (Fchar_direction): Function deleted.
10946 (syms_of_character): Don't defsubr it.
10947 <char-direction-table>: Deleted.
10948
e6c3da20
EZ
109492011-04-23 Eli Zaretskii <eliz@gnu.org>
10950
10951 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10952 * doprnt.c: Include limits.h.
10953 (SIZE_MAX): New macro.
04f2d78b
CB
10954 (doprnt): Return a size_t value. 2nd arg is now size_t.
10955 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10956 Improve overflow protection. Support `l' modifier for integer
10957 conversions. Support %l conversion. Don't assume an EMACS_INT
10958 argument for integer conversions and for %c.
10959
10960 * lisp.h (doprnt): Restore prototype.
10961
10962 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10963 $(SRC)/character.h.
10964
10965 * Makefile.in (base_obj): Add back doprnt.o.
10966
10967 * deps.mk (doprnt.o): Add back prerequisites.
10968 (callint.o): Depend on character.h.
10969
10970 * eval.c (internal_lisp_condition_case): Include the handler
10971 representation in the error message.
10972 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10973 when breaking from the loop.
10974
10975 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10976
10977 * callint.c (Fcall_interactively): When displaying error message
10978 about invalid control letter, pass the character's codepoint, not
10979 a pointer to its multibyte form. Improve display of the character
10980 in octal and display also its hex code.
10981
10982 * character.c (char_string): Use %x to display the (unsigned)
10983 codepoint of an invalid character, to avoid displaying a bogus
10984 negative value.
10985
10986 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10987 `error', not SYMBOL_NAME itself.
10988
10989 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10990 character arguments to `error'.
10991
10992 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10993 to `error' in error message about FINAL_CHAR argument. Make sure
10994 FINAL_CHAR is a character, and use %c when it is passed as
10995 argument to `error'.
10996
4ffd0d6b 109972011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10998
10999 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11000
11001 * w32.c: Include <time.h>.
11002 (sys_localtime): New function.
11003
4ffd0d6b 110042011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11005
11006 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11007
4ffd0d6b 11008 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11009
4ffd0d6b 110102011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11011
4ffd0d6b
GM
11012 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11013 zombies (Bug#8467).
aac0c6e3 11014
04c56954
EZ
110152011-04-19 Eli Zaretskii <eliz@gnu.org>
11016
11017 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11018 gl_state.e_property when gl_state.object is Qt.
11019
11020 * insdel.c (make_gap_larger): Remove limitation of buffer size
11021 to <= INT_MAX.
11022
16a43933
CY
110232011-04-18 Chong Yidong <cyd@stupidchicken.com>
11024
11025 * xdisp.c (lookup_glyphless_char_display)
11026 (produce_glyphless_glyph): Handle cons cell entry in
11027 glyphless-char-display.
11028 (Vglyphless_char_display): Document it.
11029
11030 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11031 glyphless-char-display.
11032
4581706e
CY
110332011-04-17 Chong Yidong <cyd@stupidchicken.com>
11034
11035 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11036
11037 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11038
11039 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11040 definition for no-X builds.
11041
4887c6e2 110422011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11043
fd35b6f9
PE
11044 Static checks with GCC 4.6.0 and non-default toolkits.
11045
5c1ccb01
PE
11046 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11047
006c5daa
PE
11048 * process.c (keyboard_bit_set): Define only if SIGIO.
11049 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11050 (send_process): Repair possible setjmp clobbering.
11051
efc736d3
PE
11052 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11053
4e2fe2e6
PE
11054 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11055
f97334a2
PE
11056 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11057
4e75f29d
PE
11058 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11059 Define only if needed.
11060
90efadd1
PE
11061 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11062 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11063 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11064
3c647824
PE
11065 * dispextern.h (struct redisplay_interface): Rename param
11066 to avoid shadowing.
e264f262 11067 * termhooks.h (struct terminal): Likewise.
761383f4 11068 * xterm.c (xembed_send_message): Likewise.
3c647824 11069
b58c5c4a
PE
11070 * insdel.c (make_gap_smaller): Define only if
11071 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11072
cad59032
PE
11073 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11074 it.
11075
c339dc2e
PE
11076 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11077 so that we aren't warned about unused symbols.
11078
91a3e27b
PE
11079 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11080
399c71d3 11081 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11082
8ffc96f5
PE
11083 * xfns.c (x_real_positions): Mark locals as initialized.
11084
eef9bc79
PE
11085 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11086
098db9dd
PE
11087 * xterm.c: Fix problems found by static analysis with other toolkits.
11088 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11089 (x_dispatch_event): Declare static if USE_GTK, and
11090 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11091 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11092 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11093 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11094 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11095
eb18f6cc
PE
11096 * xmenu.c (menu_help_callback): Pointer type fixes.
11097 Use const pointers when pointing at readonly data. Avoid pointer
11098 signedness clashes.
11099 (FALSE): Remove unused macro.
11100 (update_frame_menubar): Remove unused decl.
11101
1fe72bf8
PE
11102 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11103
60d9e1db
PE
11104 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11105 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11106 (single_menu_item): Rename local to avoid shadowing.
11107
39261c26
PE
11108 * keyboard.c (make_lispy_event): Remove unused local var.
11109
018c5e19
PE
11110 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11111 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11112
63d2b86e
PE
11113 * bitmaps: Change bitmaps from unsigned char back to the X11
11114 compatible char. Avoid the old compiler warnings about
11115 out-of-range initializers by using, for example, '\xab' rather
11116 than 0xab.
11117
aefd87e1
PE
11118 * xgselect.c (xgselect_initialize): Check vs interface
11119 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11120
bf501fb9
PE
11121 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11122
e9829fdf
PE
11123 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11124 to read-only memory.
11125
1086c095
PE
11126 * fns.c (vector): Remove; this old hack is no longer needed.
11127
2baccd04 11128 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11129 Remove unused var.
dde42981 11130 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11131
72391843 11132 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11133
436c16df 11134 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11135 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11136 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11137
92bb796d 11138 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11139 (x_term_init): Remove local to avoid shadowing.
92bb796d 11140
764430a3 11141 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11142
11143 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11144 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11145
d1dfb56c
EZ
111462011-04-16 Eli Zaretskii <eliz@gnu.org>
11147
c4354cb4
EZ
11148 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11149
d1dfb56c
EZ
11150 Fix regex.c, syntax.c and friends for buffers > 2GB.
11151 * syntax.h (struct gl_state_s): Declare character position members
11152 EMACS_INT.
11153
11154 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11155
04f2d78b
CB
11156 * textprop.c (verify_interval_modification, interval_of):
11157 Declare arguments EMACS_INT.
d1dfb56c
EZ
11158
11159 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11160 EMACS_INT.
11161
11162 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11163
11164 * indent.c (Fvertical_motion): Local variable it_start is now
11165 EMACS_INT.
11166
11167 * regex.c (re_match, re_match_2, re_match_2_internal)
11168 (bcmp_translate, regcomp, regexec, print_double_string)
11169 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11170 (re_compile_pattern, re_exec): Declare arguments and local
11171 variables `size_t' and `ssize_t' and return values `regoff_t', as
11172 appropriate.
11173 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11174 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11175 <compile_stack_type>: `size' and `avail' are now `size_t'.
11176
11177 * regex.h <regoff_t>: Use ssize_t, not int.
11178 (re_search, re_search_2, re_match, re_match_2): Arguments that
11179 specify buffer/string position and length are now ssize_t and
11180 size_t. Return type is regoff_t.
11181
613052cd
BK
111822011-04-16 Ben Key <bkey76@gmail.com>
11183
11184 * nsfont.m: Fixed bugs in ns_get_family and
11185 ns_descriptor_to_entity that were caused by using free to
11186 deallocate memory blocks that were allocated by xmalloc (via
11187 xstrdup). This caused Emacs to crash when compiled with
11188 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11189 --enable-checking=xmallocoverrun). xfree is now used to
11190 deallocate these memory blocks.
11191
4170f62f 111922011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11193
71b41406
PE
11194 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11195
9587a89d
PE
11196 emacs_write: Accept and return EMACS_INT for sizes.
11197 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11198 et seq.
11199 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11200 Accept and return EMACS_INT.
11201 (emacs_gnutls_write): Return the number of bytes written on
11202 partial writes.
11203 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11204 (emacs_read, emacs_write): Remove check for negative size, as the
11205 Emacs source code has been audited now.
9587a89d
PE
11206 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11207 (emacs_read, emacs_write): Use it.
273a5f82
PE
11208 * process.c (send_process): Adjust to the new signatures of
11209 emacs_write and emacs_gnutls_write. Do not attempt to store
11210 a byte offset into an 'int'; it might overflow.
9587a89d 11211 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11212
3e047f51
PE
11213 * sound.c: Don't assume sizes fit in 'int'.
11214 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11215 Return EMACS_INT, not int.
3e047f51 11216 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11217 Accept EMACS_INT, not int.
11218 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11219 record read return values.
11220
cc39a9db
BK
112212011-04-15 Ben Key <bkey76@gmail.com>
11222
c9d0ec6d
JB
11223 * keyboard.c (Qundefined): Don't declare static since it is used
11224 in nsfns.m.
11225 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11226 static since they are used in nsfont.m.
cc39a9db 11227
6c60eb9f
SM
112282011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11229
11230 * process.c (Qprocessp): Don't declare static.
11231 * lisp.h (Qprocessp): Declare again.
11232
7990b61a
JB
112332011-04-15 Juanma Barranquero <lekktu@gmail.com>
11234
11235 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11236
5d4cb038
PE
112372011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11238
8bd7b830 11239 Improve C-level modularity by making more things 'static'.
cd64ea1d 11240
e3b27b31
PE
11241 Don't publish debugger-only interfaces to other modules.
11242 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11243 (verify_bytepos, count_markers): Move decls to the only modules
11244 that need them.
11245 * region-cache.h (pp_cache): Likewise.
11246 * window.h (check_all_windows): Likewise.
11247 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11248
5d4cb038
PE
11249 * sysdep.c (croak): Now static, if
11250 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11251 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11252
11253 * alloc.c (refill_memory_reserve): Now static if
11254 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11255 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11256
e87b6180
PE
11257 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11258 Define only if USE_LUCID.
11259
ac64929e
PE
11260 * xrdb.c (x_customization_string, x_rm_string): Now static.
11261
6f37259d
PE
11262 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11263 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11264
1683e3ab
PE
11265 * xdisp.c (draw_row_with_mouse_face): Now static.
11266 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11267
de9c2632
PE
11268 * window.h (check_all_windows): Mark externally visible.
11269
2b96acb7
PE
11270 * window.c (window_deletion_count): Now static.
11271
11272 * undo.c: Make symbols static if they're not exported.
11273 (last_undo_buffer, last_boundary_position, pending_boundary):
11274 Now static.
11275
50436f33
PE
11276 * textprop.c (interval_insert_behind_hooks): Now static.
11277 (interval_insert_in_front_hooks): Likewise.
11278
64520e5c
PE
11279 * term.c: Make symbols static if they're not exported.
11280 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11281 (max_frame_lines, tty_set_terminal_modes):
11282 (tty_reset_terminal_modes, tty_turn_off_highlight):
11283 (get_tty_terminal): Now static.
11284 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11285 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11286 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11287 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11288 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11289
1fa53021
PE
11290 * sysdep.c: Make symbols static if they're not exported.
11291 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11292 Now static.
11293 (sigprocmask_set, full_mask): Remove; unused.
11294 (wait_debugging): Mark as visible.
11295 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11296 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11297
d4b43b22
PE
11298 * syntax.c (syntax_temp): Define only if !__GNUC__.
11299
b7c513d0
PE
11300 * sound.c (current_sound_device, current_sound): Now static.
11301
989b29ad
PE
11302 * search.c (searchbufs, searchbuf_head): Now static.
11303
13a55a78
PE
11304 * scroll.c (scroll_cost): Remove; unused.
11305 * dispextern.h (scroll_cost): Remove decl.
11306
de68a1fc
PE
11307 * region-cache.h (pp_cache): Mark as externally visible.
11308
40ccffa6
PE
11309 * process.c: Make symbols static if they're not exported.
11310 (process_tick, update_tick, create_process, chan_process):
11311 (Vprocess_alist, proc_buffered_char, datagram_access):
11312 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11313 (deactivate_process): Mark defn as static, as well as decl.
11314 * lisp.h (create_process): Remove decl.
11315 * process.h (chan_process, Vprocess_alist): Remove decls.
11316
ad64fc97
PE
11317 * print.c: Make symbols static if they're not exported.
11318 (print_depth, new_backquote_output, being_printed, print_buffer):
11319 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11320 (print_interval, print_number_index, initial_stderr_stream):
11321 Now static.
11322 * lisp.h (Fprinc): Remove decl.
11323 (debug_output_compilation_hack): Mark as externally visible.
11324
adddb265
PE
11325 * sysdep.c (croak): Move decl from here to syssignal.h.
11326 * syssignal.h (croak): Put it here, so the API can be checked when
11327 'croak' is called from dissociate_if_controlling_tty.
11328
1717ede2
PE
11329 * minibuf.c: Make symbols static if they're not exported.
11330 (minibuf_save_list, choose_minibuf_frame): Now static.
11331 * lisp.h (choose_minibuf_frame): Remove decl.
11332
fa5fb2bc
PE
11333 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11334
1e3890d1
PE
11335 * lread.c: Make symbols static if they're not exported.
11336 (read_objects, initial_obarray, oblookup_last_bucket_number):
11337 Now static.
11338 (make_symbol): Remove; unused.
11339 * lisp.h (initial_obarray, make_symbol): Remove decls.
11340
8a1414fa
PE
11341 * keyboard.c: Make symbols static if they're not exported.
11342 (single_kboard, recent_keys_index, total_keys, recent_keys):
11343 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11344 (this_single_command_key_start, echoing, last_auto_save):
11345 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11346 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11347 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11348 (Vlispy_mouse_stem, double_click_count):
11349 Now static.
11350 (force_auto_save_soon): Define only if SIGDANGER.
11351 (ignore_mouse_drag_p): Now static if
11352 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11353 (print_help): Remove; unused.
11354 (stop_character, last_timer_event): Mark as externally visible.
11355 * keyboard.h (ignore_mouse_drag_p): Declare only if
11356 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11357 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11358 * lisp.h (echoing): Remove decl.
11359 (force_auto_save_soon): Declare only if SIGDANGER.
11360 * xdisp.c (redisplay_window): Simplify code, to make it more
11361 obvious that ignore_mouse_drag_p is not accessed if !defined
11362 USE_GTK && !defined HAVE_NS.
11363
93ea6e8f
PE
11364 * intervals.c: Make symbols static if they're not exported.
11365 (merge_properties_sticky, merge_interval_right, delete_interval):
11366 Now static.
11367 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11368
77382fcc
PE
11369 * insdel.c: Make symbols static if they're not exported.
11370 However, leave prepare_to_modify_buffer alone. It's never
11371 called from outside this function, but that appears to be a bug.
11372 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11373 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11374 (adjust_after_replace_noundo): Remove; unused.
11375 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11376 (signal_before_change): Remove decls.
77382fcc 11377
9306c32e
PE
11378 * indent.c (val_compute_motion, val_vmotion): Now static.
11379
cd44d2eb
PE
11380 * image.c: Make symbols static if they're not exported.
11381 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11382 if USE_GTK.
11383 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11384 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11385
ad9a7a06
PE
11386 * fringe.c (standard_bitmaps): Now static.
11387 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11388
81626931
PE
11389 * frame.c: Make symbols static if they're not exported.
11390 (x_report_frame_params, make_terminal_frame): Now static.
11391 (get_frame_param): Now static, unless HAVE_NS.
11392 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11393 (x_get_resource_string): Remove; not used.
11394 * frame.h (make_terminal_frame, x_report_frame_params):
11395 (x_get_resource_string); Remove decls.
11396 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11397 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11398
239f9db9
PE
11399 * font.c, fontset.c: Make symbols static if they're not exported.
11400 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11401 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11402 * font.c (font_close_object): Now static.
11403 * font.h (font_close_object): Remove.
11404 * fontset.c (FONTSET_OBJLIST): Remove.
11405 (free_realized_fontset) #if-0 the body, which does nothing.
11406 (face_suitable_for_char_p): #if-0, as it's never called.
11407 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11408 * xfaces.c (face_at_string_position):
11409 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11410 since 0 is always ASCII.
11411
dfcf3579
PE
11412 * fns.c (weak_hash_tables): Now static.
11413
5045092b
PE
11414 * fileio.c: Make symbols static if they're not exported.
11415 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11416 (Vwrite_region_annotation_buffers): Now static.
11417
57a96f5c
PE
11418 * eval.c: Make symbols static if they're not exported.
11419 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11420 * lisp.h (backtrace_list): Remove decl.
11421
35f08c38
PE
11422 * emacs.c: Make symbols static if they're not exported.
11423 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11424 (fatal_error_code, fatal_error_signal_hook, standard_args):
11425 Now static.
11426 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11427 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11428 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11429 * lisp.h (fatal_error_signal_hook): Remove decl.
11430 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11431
f44bd759
PE
11432 * editfns.c: Move a (normally-unused) function to its only use.
11433 * editfns.c, lisp.h (get_operating_system_release): Remove.
11434 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11435 worth the hassle of breaking this out.
11436
b532497d
PE
11437 * xterm.c: Make symbols static if they're not exported.
11438 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11439 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11440 (x_destroy_window, x_delete_display):
11441 Now static.
11442 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11443 (x_mouse_leave): Remove; unused.
11444 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11445 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11446 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11447 Remove decls.
11448 (x_mouse_leave): Declare only if WINDOWSNT.
11449 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11450 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11451 USE_X_TOOLKIT.
11452
1675728f
PE
11453 * ftxfont.c: Make symbols static if they're not exported.
11454 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11455 HAVE_FREETYPE.
11456 * font.h (ftxfont_driver): Likewise.
11457
e4cebfca
PE
11458 * xfns.c: Make symbols static if they're not exported.
11459 (x_last_font_name, x_display_info_for_name):
11460 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11461 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11462 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11463 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11464 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11465 (last_show_tip_args): Now static.
11466 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11467 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11468 (x_screen_planes): Remove; unused.
11469 * dispextern.h (x_screen_planes): Remove decl.
11470
5bf46f05
PE
11471 * dispnew.c: Make symbols static if they're not exported.
11472 * dispextern.h (redraw_garbaged_frames, scrolling):
11473 (increment_row_positions): Remove.
11474 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11475 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11476 Now static.
11477 (redraw_garbaged_frames): Remove; unused.
11478
435f4c28
PE
11479 * xfaces.c: Make symbols static if they're not exported.
11480 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11481 Remove decls.
11482 * xterm.h (defined_color): Remove decls.
11483 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11484 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11485 (menu_face_changed_default, defined_color, free_realized_face):
11486 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11487 (ascii_face_of_lisp_face): Remove; unused.
11488
8524aef3
PE
11489 * xdisp.c: Make symbols static if they're not exported.
11490 * dispextern.h (scratch_glyph_row, window_box_edges):
11491 (glyph_to_pixel_coords, set_cursor_from_row):
11492 (get_next_display_element, set_iterator_to_next):
11493 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11494 (show_mouse_face): Remove decls
11495 * frame.h (message_buf_print): Likewise.
11496 * lisp.h (pop_message, set_message, check_point_in_composition):
11497 Likewise.
11498 * xterm.h (set_vertical_scroll_bar): Likewise.
11499 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11500 (message_buf_print, scratch_glyph_row, displayed_buffer):
11501 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11502 (get_next_display_element, show_mouse_face, window_box_edges):
11503 (frame_to_window_pixel_xy, check_point_in_composition):
11504 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11505 (glyph_to_pixel_coords): Remove; unused.
11506
16390cd2
PE
11507 * dired.c (file_name_completion): Now static.
11508
11509 * dbusbind.c (xd_in_read_queued_messages): Now static.
11510
a25f4dfa
PE
11511 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11512 * data.c (circular_list_error): Remove.
11513
14a9c8df
PE
11514 * commands.h (last_point_position, last_point_position_buffer):
11515 (last_point_position_window): Remove decls.
11516 * keyboard.c: Make these variables static.
11517
04f2d78b
CB
11518 * coding.h (coding, code_convert_region, encode_coding_gap):
11519 Remove decls.
74ab6df5
PE
11520 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11521 (iso_code_class, detect_coding, code_convert_region): Now static.
11522 (encode_coding_gap): Remove; unused.
11523
38dfbee1
PE
11524 * chartab.c (chartab_chars, chartab_bits): Now static.
11525
a2cb4e63
PE
11526 * charset.h (charset_iso_8859_1): Remove decl.
11527 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11528 Now static.
11529
127198fd
PE
11530 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11531 * ccl.c (Vccl_program_table): Now static.
11532 (check_ccl_update): Remove; unused.
11533
d85b608f
PE
11534 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11535 * category.h: ... from here.
11536 * category.c (check_category_table, set_category_set): Now static.
11537
31cd66f3
PE
11538 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11539 * lisp.h: Remove these decls.
11540
c358e587
PE
11541 * buffer.c (buffer_count): Remove unused var.
11542
e78aecca
PE
11543 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11544 so that it's not optimized away.
11545 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11546 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11547 exported only to the debugger.
11548
e192d7d3 11549 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11550 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11551
92470028
PE
11552 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11553 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11554 was inaccessible from Lisp.
11555 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11556 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11557
244ed907
PE
11558 alloc.c: Import and export fewer symbols, and remove unused items.
11559 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11560 is defined.
11561 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11562 it's not optimized away by whole-program optimization.
11563 (message_enable_multibyte, free_misc): Remove.
11564 (catchlist, handlerlist, mark_backtrace):
11565 Declare only if BYTE_MARK_STACK.
11566 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11567 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11568 (message_enable_multibyte): Remove decl.
11569 (free_misc, interval_free_list, float_block, float_block_index):
11570 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11571 (cons_free_list, last_marked_index):
11572 Now static.
11573 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11574 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11575 (mark_backtrace): Define only if BYTE_MARK_STACK.
11576 * xdisp.c (message_enable_multibyte): Now static.
11577
61c2b50e 11578 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11579 This makes it easier for human readers (and static analyzers)
11580 to see whether these variables are used from other modules.
11581 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11582 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11583 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11584 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11585 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11586 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11587 * xmenu.c, xselect.c:
11588 Declare Q* vars static if they are not used in other modules.
11589 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11590 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11591 Remove decls of unexported vars.
11592 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11593
95c82688
PE
11594 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11595
16a97296
PE
11596 Make Emacs functions such as Fatom 'static' by default.
11597 This makes it easier for human readers (and static analyzers)
11598 to see whether these functions can be called from other modules.
11599 DEFUN now defines a static function. To make the function external
11600 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11601 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11602 (Finit_image_library):
16a97296
PE
11603 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11604 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11605 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11606 Remove decls, since these functions are now static.
11607 (Funintern, Fget_internal_run_time): New decls, since these functions
11608 were already external.
95c82688 11609
16a97296
PE
11610 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11611 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11612 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11613 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11614 * keyboard.c, keymap.c, lread.c:
11615 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11616 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11617 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11618 Mark functions with DEFUE instead of DEFUN,
11619 if they are used in other modules.
11620 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11621 decls for now-static functions.
11622 * buffer.h (Fdelete_overlay): Remove decl.
11623 * callproc.c (Fgetenv_internal): Mark as internal.
11624 * composite.c (Fremove_list_of_text_properties): Remove decl.
11625 (Fcomposition_get_gstring): New forward static decl.
11626 * composite.h (Fcomposite_get_gstring): Remove decl.
11627 * dired.c (Ffile_attributes): New forward static decl.
11628 * doc.c (Fdocumntation_property): New forward static decl.
11629 * eval.c (Ffetch_bytecode): New forward static decl.
11630 (Funintern): Remove extern decl; now in .h file where it belongs.
11631 * fileio.c (Fmake_symbolic_link): New forward static decl.
11632 * image.c (Finit_image_library): New forward static decl.
11633 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11634 * intervals.h (Fprevious_property_change):
11635 (Fremove_list_of_text_properties): Remove decls.
11636 * keyboard.c (Fthis_command_keys): Remove decl.
11637 (Fcommand_execute): New forward static decl.
11638 * keymap.c (Flookup_key): New forward static decl.
11639 (Fcopy_keymap): Now static.
11640 * keymap.h (Flookup_key): Remove decl.
11641 * process.c (Fget_process): New forward static decl.
11642 (Fprocess_datagram_address): Mark as internal.
11643 * syntax.c (Fsyntax_table_p): New forward static decl.
11644 (skip_chars): Remove duplicate decl.
11645 * textprop.c (Fprevious_property_change): New forward static decl.
11646 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11647 Now internal.
11648 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11649 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11650
785bbd42
PE
11651 * editfns.c (Fformat): Remove unreachable code.
11652
8b913b57
AS
116532011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11654
11655 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11656 change. (Bug#8496)
11657
a6744a35
EZ
116582011-04-13 Eli Zaretskii <eliz@gnu.org>
11659
11660 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11661 when at ZV. (Bug#8487)
11662
e7974947
AS
116632011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11664
baad03f0
AS
11665 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11666 (Bug#8437)
11667 * keyboard.c (parse_tool_bar_item): Likewise.
11668 * sound.c (sound_cleanup, alsa_close): Likewise.
11669 * termcap.c (tgetent): Likewise.
11670 * xfns.c (x_default_font_parameter): Likewise.
11671 * xsettings.c (read_and_apply_settings): Likewise.
11672
e7974947
AS
11673 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11674 (overrun_check_free): Protoize.
11675
28272684
PE
116762011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11677
11678 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11679 since callers should never pass a negative size.
11680 Change the signature to match that of plain 'read' and 'write'; see
11681 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11682 * lisp.h: Update prototypes of emacs_write and emacs_read.
11683
11997c76
EZ
116842011-04-11 Eli Zaretskii <eliz@gnu.org>
11685
11686 * xdisp.c (redisplay_window): Don't try to determine the character
11687 position of the scroll margin if the window start point w->startp
e896f03c 11688 is outside the buffer's accessible region. (Bug#8468)
11997c76 11689
8a2cbd72
EZ
116902011-04-10 Eli Zaretskii <eliz@gnu.org>
11691
11692 Fix write-region and its subroutines for buffers > 2GB.
11693 * fileio.c (a_write, e_write): Modify declaration of arguments and
11694 local variables to support buffers larger than 2GB.
11695 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11696
11697 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11698 argument, local variables, and return value.
11699
11700 * lisp.h: Update prototypes of emacs_write and emacs_read.
11701
11702 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11703
4073e537 117042011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11705
1ebfdcb6
PE
11706 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11707
b2ded58d
PE
11708 Fix more problems found by GCC 4.6.0's static checks.
11709
7d66342c
PE
11710 * xdisp.c (vmessage): Use a better test for character truncation.
11711
bbf47d44
PE
11712 * charset.c (load_charset_map): <, not <=, for optimization,
11713 and to avoid potential problems with integer overflow.
9248994d 11714 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11715 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11716 * editfns.c (Fformat): Likewise.
1e69125e 11717 * syntax.c (skip_chars): Likewise.
3befa583 11718
e3019616
PE
11719 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11720 This also lets GCC 4.6.0 generate slightly better loop code.
11721
becfa255
PE
11722 * callint.c (Fcall_interactively): <, not <=, for optimization.
11723 (Fcall_interactively): Count the number of arguments produced,
11724 not the number of arguments given. This is simpler and lets GCC
11725 4.6.0 generate slightly better code.
11726
dae0cd48
PE
11727 * ftfont.c: Distingish more carefully between FcChar8 and char.
11728 The previous code passed unsigned char * to a functions like
11729 strlen and xstrcasecmp that expect char *, which does not
11730 conform to the C standard.
11731 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11732 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11733 char * when the C standard requires it.
11734
76032d70
PE
11735 * keyboard.c (read_char): Remove unused var.
11736
eb3f1cc8
PE
11737 * eval.c: Port to Windows vsnprintf (Bug#8435).
11738 Include <limits.h>.
11739 (SIZE_MAX): Define if the headers do not.
11740 (verror): Do not give up if vsnprintf returns a negative count.
11741 Instead, grow the buffer. This ports to Windows vsnprintf, which
11742 does not conform to C99. Problem reported by Eli Zaretskii.
11743 Also, simplify the allocation scheme, by avoiding the need for
11744 calling realloc, and removing the ALLOCATED variable.
11745
70476b54
PE
11746 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11747
12020a9e
PE
11748 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11749 But keep the doprint source code for now, as we might revamp it
11750 and use it again (Bug#8435).
ea6c7ae6
PE
11751 * lisp.h (doprnt): Remove.
11752 * Makefile.in (base_obj): Remove doprnt.o.
11753 * deps.mk (doprnt.o): Remove.
11754
5fdb398c
PE
11755 error: Print 32- and 64-bit integers portably (Bug#8435).
11756 Without this change, on typical 64-bit hosts error ("...%d...", N)
11757 was used to print both 32- and 64-bit integers N, which relied on
11758 undefined behavior.
61bdb816 11759 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11760 * lisp.h (error, verror): Mark as printf-like functions.
11761 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11762 Report overflow in size calculations when allocating printf buffer.
11763 Do not truncate output string at its first null byte.
11764 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11765 Truncate the output at a character boundary, since vsnprintf does not
11766 do that.
11767 * charset.c (check_iso_charset_parameter): Convert internal
11768 character to string before calling 'error', since %c now has the
11769 printf meaning.
11770 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11771 overflow when computing char to be passed to 'error'. Do not
11772 pass Lisp_Object to 'error'; pass the integer instead.
11773 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11774 formatted with plain %d.
11775
b189fa66
PE
11776 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11777
bff87ef0
PE
11778 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11779
7e2cac20
PE
11780 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11781
ce4d90b5
PE
11782 * xterm.c (x_catch_errors): Remove duplicate declaration.
11783
266c9547
PE
11784 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11785
79c49ad2
PE
11786 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11787
368f4090
JM
117882011-04-10 Jim Meyering <meyering@redhat.com>
11789
11790 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11791 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11792 return ssize_t not "int", and use size_t as the buffer length.
11793 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11794 * gnutls.h: Update declarations.
11795 * process.c (read_process_output): Use ssize_t, to match.
11796 (send_process): Likewise.
11797
a32d4040
CY
117982011-04-09 Chong Yidong <cyd@stupidchicken.com>
11799
11800 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11801
8546720e 118022011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11803
04f2d78b
CB
11804 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11805 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11806
8546720e
GM
11807 * xterm.c (handle_one_xevent):
11808 * xmenu.c (create_and_show_popup_menu):
11809 * xselect.c (x_decline_selection_request)
11810 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11811
0a2f5c1a 118122011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11813
11814 Fix some uses of `int' instead of EMACS_INT.
11815 * search.c (string_match_1, fast_string_match)
11816 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11817 (scan_buffer, find_next_newline_no_quit)
11818 (find_before_next_newline, search_command, Freplace_match)
11819 (Fmatch_data): Make some `int' variables be EMACS_INT.
11820
11821 * xdisp.c (display_count_lines): 3rd argument and return value now
11822 EMACS_INT. All callers changed.
11823 (pint2hrstr): Last argument is now EMACS_INT.
11824
11825 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11826 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11827 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11828 (decode_coding_utf_16, decode_coding_emacs_mule)
11829 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11830 (decode_coding_ccl, decode_coding_charset)
11831 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11832 (decode_coding_iso_2022, decode_coding_emacs_mule)
11833 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11834 <char_offset, last_offset>: Declare EMACS_INT.
11835 (encode_coding_utf_8, encode_coding_utf_16)
11836 (encode_coding_emacs_mule, encode_invocation_designation)
11837 (encode_designation_at_bol, encode_coding_iso_2022)
11838 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11839 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11840 Declare EMACS_INT.
11841 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11842 (encode_invocation_designation): Last argument P_NCHARS is now
11843 EMACS_INT.
11844 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11845 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11846
11847 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11848 All users changed.
11849
11850 * ccl.c (Fccl_execute_on_string): Declare some variables
11851 EMACS_INT.
11852
8546720e 118532011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11854
11855 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11856
4e19a977
CS
118572011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11858
11859 * process.c (Fformat_network_address): Doc fix.
11860
87302331
R
118612011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11862
ee7683eb 11863 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11864
cbb59342
CY
118652011-04-08 Chong Yidong <cyd@stupidchicken.com>
11866
11867 * keyboard.c (read_char): Call Lisp function help-form-show,
11868 instead of using internal_with_output_to_temp_buffer.
11869 (Qhelp_form_show): New var.
e0d38eeb 11870 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11871
11872 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11873
11874 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11875
e67a13ab
CY
118762011-04-06 Chong Yidong <cyd@stupidchicken.com>
11877
04f2d78b
CB
11878 * process.c (Flist_processes): Remove to Lisp.
11879 (list_processes_1): Delete.
e67a13ab 11880
973f782d
EZ
118812011-04-06 Eli Zaretskii <eliz@gnu.org>
11882
7c106b1e
EZ
11883 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11884
973f782d
EZ
11885 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11886
41cf7d1a 118872011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11888
ca23cc88
PE
11889 Fix more problems found by GCC 4.6.0's static checks.
11890
f390e2d5
PE
11891 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11892
42eea0d0
PE
11893 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11894
b69769da 11895 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11896
f9541e84
PE
11897 * xdisp.c (vmessage): Mark as a printf-like function.
11898
13841b55
PE
11899 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11900
c136c10f
PE
11901 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11902
5e2d4a30
PE
11903 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11904 printf-like functions.
11905 (tiff_load): Add casts to remove these marks before passing them
11906 to system-supplied API.
11907
583f48b9
PE
11908 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11909
b25d760e
PE
11910 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11911 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11912 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11913 directly, rather than having caller test rule sign. This avoids
11914 some unnecessary tests.
11915 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11916 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11917 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11918
bc7b6697 11919 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11920 (xfont_open): Avoid unnecessary tests.
bc7b6697 11921
27ccc379
PE
11922 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11923
dcd5c89a
PE
11924 * composite.h, composite.c (composition_gstring_put_cache):
11925 Use EMACS_INT, not int, for length.
11926
b13a45c6
PE
11927 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11928 breaking out part of COMPOSITION_DECODE_RULE.
11929 (COMPOSITION_DECODE_RULE): Use it.
11930 * composite.c (get_composition_id): Remove unused local vars,
11931 by using the new macro.
11932
1e792e4d
PE
11933 * textprop.c (set_text_properties_1): Change while to do-while,
11934 since the condition is always true at first.
11935
dc6c6455 11936 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11937 (interval_deletion_adjustment): Return unsigned value.
11938 All uses changed.
dc6c6455 11939
aba7731a
PE
11940 * process.c (list_processes_1, create_pty, read_process_output):
11941 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11942 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11943 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11944 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11945 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11946
fdfc4bf3
PE
11947 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11948
fca8fe46 11949 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11950 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11951
06a0259a 11952 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11953 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11954 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11955
e7b9e80f
PE
11956 * print.c (print_error_message): Avoid int overflow.
11957
56201685
PE
11958 * font.c (font_list_entities): Redo for clarity,
11959 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11960
78834453 11961 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11962 (font_score): Avoid potential overflow in diff calculation.
78834453 11963
0bc0b309 11964 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11965 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11966
e610eaca
PE
11967 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11968
b895abce
PE
11969 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11970 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11971 can always succeed if overflow has undefined behavior.
11972
1f1d9321 11973 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11974 (wordify): Omit three unnecessary tests.
1f1d9321 11975
c59478bc
PE
11976 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11977 All callers changed. This avoids the need for an unused var.
11978
79b73827
PE
11979 * casefiddle.c (casify_region): Remove var that is set but not used.
11980
a4db5dfe
PE
11981 * dired.c (file_name_completion): Remove var that is set but not used.
11982
43aae36e
PE
11983 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11984
2a47c44d 11985 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11986 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11987
a37c69bf
PE
11988 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11989 Check for integer overflow on size calculations.
11990
328ab8e7
PE
11991 * buffer.c (Fprevious_overlay_change): Remove var that is set
11992 but not used.
11993
e5a2a5cb
PE
11994 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11995 Remove vars that are set but not used.
8d84a6eb 11996 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11997 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11998
a60e5f68
PE
11999 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12000
f661cb61 12001 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12002 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12003
f0397f5a
PE
12004 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12005 that are set but not used.
12006
8664db06 12007 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12008 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12009
6abdaa4a
PE
12010 * xselect.c (x_get_local_selection, x_handle_property_notify):
12011 Remove vars that are set but not used.
12012
0ce7538d 12013 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12014 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12015
9ae848fc
PE
12016 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12017 Remove var that is set but not used.
0b918413
PE
12018 (scroll_bar_windows_size): Now size_t, not int.
12019 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12020 Check for overflow.
9ae848fc 12021
a5a62657
PE
12022 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12023 (map_tty_color) [!defined MSDOS]: Likewise.
12024
5c5cdd39
PE
12025 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12026
66ebf983
PE
12027 * coding.c: Remove vars that are set but not used.
12028 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12029 All callers changed.
12030 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12031 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12032 (decode_coding_charset): Remove vars that are set but not used.
12033
1be4d761
PE
12034 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12035 that is set but not used.
12036
47553fa8
PE
12037 * print.c (print_object): Remove var that is set but not used.
12038
1f7196bf 12039 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12040 The gnulib version avoids calling malloc in the usual case,
12041 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12042 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12043 * filelock.c (current_lock_owner): Likewise.
12044 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12045 * sysdep.c: Include allocator.h, careadlinkat.h.
12046 (emacs_no_realloc_allocator): New static constant.
12047 (emacs_readlink): New function.
fdb61804
PE
12048 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12049 ../lib/careadlinkat.h.
d1fdcab7 12050
f84c17c7
SM
120512011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12052
12053 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12054 first non-nil return value).
12055
ef3862ad
JD
120562011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12057
12058 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12059 if not defined (Bug#8403).
12060
376a7006
JB
120612011-04-02 Juanma Barranquero <lekktu@gmail.com>
12062
12063 * xdisp.c (display_count_lines): Remove parameter `start',
12064 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12065 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12066 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12067 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12068 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12069 and thereabouts. All callers changed.
12070 (get_per_char_metric): Remove parameter `f', unused since
12071 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12072
6ca3801d
JM
120732011-04-02 Jim Meyering <meyering@redhat.com>
12074
12075 do not dereference NULL upon failed strdup
12076 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12077 (ns_get_family): Likewise.
12078
d8e2b5ba
JB
120792011-04-02 Juanma Barranquero <lekktu@gmail.com>
12080
12081 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12082
8c74fcbd
JD
120832011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12084
12085 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12086 later (Bug#8403).
12087
7200d79c
SM
120882011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12089
03408648 12090 Add lexical binding.
7200d79c 12091
03408648
SM
12092 * window.c (Ftemp_output_buffer_show): New fun.
12093 (Fsave_window_excursion):
12094 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12095
12096 * lread.c (lisp_file_lexically_bound_p): New function.
12097 (Fload): Bind Qlexical_binding.
12098 (readevalloop): Remove `evalfun' arg.
12099 Bind Qinternal_interpreter_environment.
12100 (Feval_buffer): Bind Qlexical_binding.
12101 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12102 Mark as dynamic.
12103 (syms_of_lread): Declare `lexical-binding'.
12104
12105 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12106
12107 * keyboard.c (eval_dyn): New fun.
12108 (menu_item_eval_property): Use it.
ca105506
SM
12109
12110 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12111
03408648
SM
12112 * fns.c (concat, mapcar1): Accept byte-code-functions.
12113
12114 * eval.c (Fsetq): Handle lexical vars.
12115 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12116 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12117 (FletX, Flet): Obey lexical binding.
12118 (Fcommandp): Handle closures.
12119 (Feval): New `lexical' arg.
12120 (eval_sub): New function extracted from Feval. Use it almost
12121 everywhere where Feval was used. Look up vars in lexical env.
12122 Handle closures.
12123 (Ffunctionp): Move from subr.el.
12124 (Ffuncall): Handle closures.
12125 (apply_lambda): Remove `eval_flags'.
12126 (funcall_lambda): Handle closures and new byte-code-functions.
12127 (Fspecial_variable_p): New function.
12128 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12129 but without exporting it to Lisp.
23aba0ea 12130
23aba0ea 12131 * doc.c (Fdocumentation, store_function_docstring):
03408648 12132 * data.c (Finteractive_form): Handle closures.
23aba0ea 12133
03408648
SM
12134 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12135 interactive spec.
ba83908c 12136
04f2d78b
CB
12137 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12138 New byte-codes.
03408648
SM
12139 (exec_byte_code): New function extracted from Fbyte_code to handle new
12140 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12141
03408648 12142 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12143
03408648 12144 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12145
e2abce01
JB
121462011-03-31 Juanma Barranquero <lekktu@gmail.com>
12147
12148 * xdisp.c (redisplay_internal): Fix prototype.
12149
63696a73 121502011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12151
63696a73 12152 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12153 (try_scrolling): Use it when setting scroll_limit.
12154 Limit scrolling to 100 screen lines.
63696a73
EZ
12155 (redisplay_window): Even when falling back on "recentering",
12156 position point in the window according to scroll-conservatively,
12157 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12158
12159 (try_scrolling): When point is above the window, allow searching
12160 as far as scroll_max, or one screenful, to compute vertical
12161 distance from PT to the scroll margin position. This prevents
12162 try_scrolling from unnecessarily failing when
12163 scroll-conservatively is set to a value slightly larger than the
12164 window height. Clean up the case of PT below the margin at bottom
12165 of window: scroll_max can no longer be INT_MAX. When aggressive
12166 scrolling is in use, don't let point enter the opposite scroll
12167 margin as result of the scroll.
12168 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12169 threshold of 100 lines for never-recentering scrolling.
12170
e4cc2dfc
JB
121712011-03-31 Juanma Barranquero <lekktu@gmail.com>
12172
12173 * dispextern.h (move_it_by_lines):
12174 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12175 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12176 (message_log_check_duplicate): Remove parameters `prev_bol' and
12177 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12178 (redisplay_internal): Remove parameter `preserve_echo_area',
12179 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12180
12181 * indent.c (Fvertical_motion):
12182 * window.c (window_scroll_pixel_based, Frecenter):
12183 Don't pass `need_y_p' to `move_it_by_lines'.
12184
1c470562
SM
121852011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12186
44f230aa
SM
12187 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12188 steal a few bits to be more compact.
12189 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12190 Remove unneeded casts.
12191
1c470562
SM
12192 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12193
888adce9
ZK
121942011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12195
12196 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12197 binding" message (bug#7967).
12198
f838ed7b
PE
121992011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12200
77861b95
PE
12201 Fix more problems found by GCC 4.6.0's static checks.
12202
de6dbc14
PE
12203 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12204 Remove unused local var.
12205
f838ed7b
PE
12206 * editfns.c (Fmessage_box): Remove unused local var.
12207
792c7b2b
PE
12208 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12209 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12210 Omit unused local vars.
c499e557 12211 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12212 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12213 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12214 Omit unused local var.
12215
ba0165e1
PE
12216 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12217 Don't assume string length fits in int.
32ad8845 12218 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12219 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12220
3c59b4c9
PE
12221 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12222 instead of alloca (Bug#8344).
12223
a3eed478 12224 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12225 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12226
eb4d412d
PE
12227 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12228
1658b401
PE
12229 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12230 concerns.
12231
12232 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12233
12234 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12235
9a2c6e05
PE
12236 * keyboard.c (syms_of_keyboard): Use the same style as later
12237 in this function when indexing through an array. This also
12238 works around GCC bug 48267.
12239
03d0a109
PE
12240 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12241
44f730c8
PE
12242 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12243
fe75f926
PE
12244 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12245 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12246
ffa8c828
PE
12247 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12248 This avoids undefined behavior on integer overflow, and is a bit
12249 more convenient anyway since it is compared to a size_t variable.
12250
c5101a77
PE
12251 Variadic C functions now count arguments with size_t, not int.
12252 This avoids an unnecessary limitation on 64-bit machines, which
12253 caused (substring ...) to crash on large vectors (Bug#8344).
12254 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12255 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12256 All variadic functions and their callers changed accordingly.
c5101a77
PE
12257 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12258 * data.c (arith_driver, float_arith_driver): Likewise.
12259 * editfns.c (general_insert_function): Likewise.
12260 * eval.c (struct backtrace.nargs, interactive_p)
12261 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12262 (funcall_lambda, mark_backtrace): Likewise.
12263 * fns.c (concat): Likewise.
12264 * frame.c (x_set_frame_parameters): Likewise.
12265 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12266 0 if not found, not -1. All callers changed.
12267
dd3f25f7
PE
12268 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12269 (stack_copy_size): Now size_t, not int.
12270 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12271
461c2ab9
JB
122722011-03-28 Juanma Barranquero <lekktu@gmail.com>
12273
12274 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12275 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12276 All callers changed.
12277
12278 * lisp.h (multibyte_char_to_unibyte):
12279 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12280 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12281 * character.h (CHAR_TO_BYTE8):
12282 * cmds.c (internal_self_insert):
12283 * editfns.c (general_insert_function):
12284 * keymap.c (push_key_description):
12285 * search.c (Freplace_match):
12286 * xdisp.c (message_dolog, set_message_1): All callers changed.
12287
f6d62986
SM
122882011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12289
12290 * keyboard.c (safe_run_hook_funcall): New function.
12291 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12292 don't set the hook to nil, but remove the offending function instead.
12293 (Qcommand_hook_internal): Remove, unused.
12294 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12295 Vcommand_hook_internal.
12296
12297 * eval.c (enum run_hooks_condition): Remove.
12298 (funcall_nil, funcall_not): New functions.
12299 (run_hook_with_args): Call each function through a `funcall' argument.
12300 Remove `cond' argument, now redundant.
12301 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12302 (Frun_hook_with_args_until_failure): Adjust accordingly.
12303 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12304
1db5b1ad
JB
123052011-03-28 Juanma Barranquero <lekktu@gmail.com>
12306
12307 * dispextern.h (string_buffer_position): Remove declaration.
12308
12309 * print.c (strout): Remove parameter `multibyte', unused since
12310 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12311
12312 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12313 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12314 All callers changed.
12315
12316 * w32.c (_wsa_errlist): Use braces for struct initializers.
12317
12318 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12319 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12320 All callers changed.
12321 (string_buffer_position): Likewise. Also, make static (it's never
12322 used outside xdisp.c).
12323 (cursor_row_p): Remove parameter `w', unused since
12324 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12325 (decode_mode_spec): Remove parameter `precision', introduced during
12326 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12327 All callers changed.
12328
5ffb62aa
JD
123292011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12330
12331 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12332
461c2ab9 123332011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12334
12335 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12336 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12337 (ns_update_auto_hide_menu_bar): New functions.
12338 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12339 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12340 ns_constrain_all_frames.
12341 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12342 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12343
5c380ffb
JD
123442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12345
12346 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12347
9af30bdf
GM
123482011-03-27 Glenn Morris <rgm@gnu.org>
12349
12350 * syssignal.h: Replace RETSIGTYPE with void.
12351 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12352 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12353 Replace SIGTYPE with void everywhere.
12354 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12355 * s/template.h (SIGTYPE): Remove commented out definition.
12356
e2abce01
JB
123572011-03-26 Eli Zaretskii <eliz@gnu.org>
12358
12359 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12360 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12361
f868cd8a
JB
123622011-03-26 Juanma Barranquero <lekktu@gmail.com>
12363
59eb0929
JB
12364 * w32.c (read_unc_volume): Use parameter `henum', instead of
12365 global variable `wget_enum_handle'.
12366
12367 * keymap.c (describe_vector): Remove parameters `indices' and
12368 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12369 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12370
f868cd8a
JB
12371 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12372
12373 * keyboard.c (timer_check): Remove parameter `do_it_now',
12374 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12375 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12376 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12377
12378 * keyboard.c (read_char):
12379 * w32menu.c (w32_menu_display_help):
12380 * xmenu.c (show_help_event, menu_help_callback):
12381 Adjust calls to `show_help_echo'.
12382
12383 * gtkutil.c (xg_maybe_add_timer):
12384 * keyboard.c (readable_events):
12385 * process.c (wait_reading_process_output):
12386 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12387
12388 * insdel.c (adjust_markers_gap_motion):
12389 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12390 (gap_left, gap_right): Don't call it.
12391
2ecf6fdb
CY
123922011-03-25 Chong Yidong <cyd@stupidchicken.com>
12393
12394 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12395 incurred during fontification.
12396
6b1f9ba4
JB
123972011-03-25 Juanma Barranquero <lekktu@gmail.com>
12398
12399 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12400 (DEFVAR_PER_BUFFER): Don't pass it.
12401
12402 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12403 (scrolling_window): Don't pass it.
12404
0f4a96b5
JB
124052011-03-25 Juanma Barranquero <lekktu@gmail.com>
12406
12407 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12408
12409 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12410 and `suffix'.
12411 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12412 of variables specific to SELinux and computation of `encoded_absname'.
12413
12414 * image.c (XPutPixel): Remove unused variable `height'.
12415
12416 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12417
12418 * unexw32.c (get_section_info): Remove unused variable `section'.
12419
12420 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12421 (system_process_attributes): Remove unused variable `sess'.
12422 (sys_read): Remove unused variable `err'.
12423
12424 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12425 (w32_wnd_proc): Remove unused variable `isdead'.
12426 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12427 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12428 (x_create_tip_frame): Remove unused variable `tem'.
12429
12430 * w32inevt.c (w32_console_read_socket):
12431 Remove unused variable `no_events'.
12432
12433 * w32term.c (x_draw_composite_glyph_string_foreground):
12434 Remove unused variable `width'.
12435
1149507c
JB
124362011-03-24 Juanma Barranquero <lekktu@gmail.com>
12437
12438 * w32term.c (x_set_glyph_string_clipping):
12439 Don't pass uninitialized region to CombineRgn.
12440
9c88f339
JB
124412011-03-23 Juanma Barranquero <lekktu@gmail.com>
12442
12443 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12444 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12445 (Fx_close_connection): Remove unused variable `i'.
12446
12447 * w32font.c (w32font_draw): Return number of glyphs.
12448 (w32font_open_internal): Remove unused variable `i'.
12449 (w32font_driver): Add missing initializer.
12450
12451 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12452 (fill_in_menu): Remove unused variable `items_added'.
12453
12454 * w32term.c (last_mouse_press_frame): Remove static global variable.
12455 (w32_clip_to_row): Remove unused variable `f'.
12456 (x_delete_terminal): Remove unused variable `i'.
12457
12458 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12459 (NOTHING): Remove unused static global variable.
12460 (uniscribe_check_otf): Remove unused variable `table'.
12461 (uniscribe_font_driver): Add missing initializers.
12462
dee091a3
JD
124632011-03-23 Julien Danjou <julien@danjou.info>
12464
12465 * term.c (Fsuspend_tty, Fresume_tty):
12466 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12467 * window.c (temp_output_buffer_show):
12468 * insdel.c (signal_before_change):
12469 * frame.c (Fhandle_switch_frame):
12470 * fileio.c (Fdo_auto_save):
12471 * emacs.c (Fkill_emacs):
12472 * editfns.c (save_excursion_restore):
12473 * cmds.c (internal_self_insert):
12474 * callint.c (Fcall_interactively):
12475 * buffer.c (Fkill_all_local_variables):
12476 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12477 Use Frun_hooks.
0f4a96b5 12478 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12479 unconditionally since it does the check itself.
dee091a3 12480
2c520ab5 124812011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12482
c9c49752
PE
12483 Fix more problems found by GCC 4.5.2's static checks.
12484
8abc3f12
PE
12485 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12486 the first time through the loop, since we know p0 < p1 then.
12487 This also avoids a gcc -Wstrict-overflow warning.
12488
a2d26660
PE
12489 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12490 leading to a memory leak, possible in functions like
12491 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12492 of objects (Bug#8318).
a2d26660 12493
916c72e9
PE
12494 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12495 that could (at least in theory) be that large.
12496
19ab8a18
PE
12497 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12498 This is less likely to overflow, and avoids undefined behavior if
12499 overflow does occur. All callers changed. Use strtoul to scan
12500 for the unsigned long integer.
b7cbbd6f
PE
12501 (pint2hrstr): Simplify and tune code slightly.
12502 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12503
f0641eff
PE
12504 * scroll.c (do_scrolling): Work around GCC bug 48228.
12505 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12506
7f650bb9
PE
12507 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12508 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12509 (validate_x_resource_name): Simplify count usage.
12510 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12511
37dd57d1
PE
12512 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12513 fail (Bug#8306).
81e56e61 12514
699979fc 12515 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12516
401bf9b4
PE
12517 * process.c (Fmake_network_process): Use socklen_t, not int,
12518 where POSIX says socklen_t is required in portable programs.
12519 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12520 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12521 (Fmake_network_process, server_accept_connection):
12522 (wait_reading_process_output, read_process_output):
12523 Likewise.
12524
b93aacde
PE
12525 * process.c: Rename or move locals to avoid shadowing.
12526 (list_processes_1, Fmake_network_process):
12527 (read_process_output_error_handler, exec_sentinel_error_handler):
12528 Rename or move locals.
4dc343ee 12529 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12530 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12531 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12532 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12533 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12534
af8a867c 12535 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12536 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12537 Include tparam.h instead, since it declares them.
af8a867c
PE
12538 * cm.h (PC): Remove extern decl; tparam.h now does this.
12539 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12540 * terminfo.c: Include tparam.h, to check interfaces.
12541 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12542 (tparam): Adjust signature to match interface in tparam.h;
12543 this removes some undefined behavior. Check that outstring and len
12544 are zero, which they always are with Emacs.
12545 * tparam.h (PC, BC, UP): New extern decls.
12546
0248044d 12547 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12548 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12549
8ff096c1 12550 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12551 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12552 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12553 (ftfont_list): Remove unused local.
49eaafba
PE
12554 (get_adstyle_property, ftfont_pattern_entity):
12555 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12556 Rename locals to avoid shadowing.
8ff096c1 12557
e2be39f6
PE
12558 * xfont.c (xfont_list_family): Mark var as initialized.
12559
c9735e30
PE
12560 * xml.c (make_dom): Now static.
12561
8f5201ae
PE
12562 * composite.c (composition_compute_stop_pos): Rename local to
12563 avoid shadowing.
b246f932
PE
12564 (composition_reseat_it): Remove unused locals.
12565 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12566 (composition_update_it): Mark var as initialized.
11b61122
PE
12567 (find_automatic_composition): Mark vars as initialized,
12568 with a FIXME (Bug#8290).
8f5201ae 12569
760fbc2c
PE
12570 character.h: Rename locals to avoid shadowing.
12571 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12572 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12573 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12574 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12575 to avoid shadowing.
12576
ff08eb85
PE
12577 * textprop.c (property_change_between_p): Remove; unused.
12578
fc7bf025
PE
12579 * intervals.c (interval_start_pos): Now static.
12580
235d7abc
PE
12581 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12582
44f230aa
SM
12583 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12584 Rename locals to avoid shadowing.
3e7d6594 12585
50060332
PE
12586 * sound.c (wav_play, au_play, Fplay_sound_internal):
12587 Fix pointer signedness.
d01f234b 12588 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12589 (wav_play): Initialize a variable to 0, to prevent undefined
12590 behavior (Bug#8278).
50060332 12591
c4fc4e30
PE
12592 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12593
918436ed
PE
12594 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12595
c939f91b
PE
12596 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12597 clobbering (Bug#8298).
b9c7f648
PE
12598 * sysdep.c (sys_subshell): Likewise.
12599 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12600
6bd8c144
PE
12601 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12602 This should get cleaned up, so that child_setup has the
12603 same signature on all platforms.
12604
7710357c 12605 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12606 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12607
c59da222
CY
126082011-03-22 Chong Yidong <cyd@stupidchicken.com>
12609
12610 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12611 not to be necessary, and produces flickering.
12612
66b87493
GM
126132011-03-20 Glenn Morris <rgm@gnu.org>
12614
12615 * config.in: Remove file.
12616
45b6f6d5
JB
126172011-03-20 Juanma Barranquero <lekktu@gmail.com>
12618
12619 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12620 are now in src/globals.h.
12621 (syms_of_minibuf): Remove spurious & from previous change.
12622
cd394be1 126232011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12624
12625 * minibuf.c (completing-read-function): New variable.
12626 (completing-read-default): Rename from completing-read.
12627 (completing-read): Call completing-read-function.
12628
b14e3e21
CY
126292011-03-19 Juanma Barranquero <lekktu@gmail.com>
12630
12631 * xfaces.c (Fx_load_color_file):
12632 Read color file from absolute filename (bug#8250).
12633
f2b726e6
JB
126342011-03-19 Juanma Barranquero <lekktu@gmail.com>
12635
12636 * makefile.w32-in: Update dependencies.
12637
09f6ff02
EZ
126382011-03-17 Eli Zaretskii <eliz@gnu.org>
12639
12640 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12641
29a6015a
PE
126422011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12643
a3a6c54e
PE
12644 Fix more problems found by GCC 4.5.2's static checks.
12645
b766f867
PE
12646 * process.c (make_serial_process_unwind, send_process_trap):
12647 (sigchld_handler): Now static.
12648
be02381c
PE
12649 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12650 That way, the code declares only the vars that it needs.
12651 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12652 * s/cygwin.h (PTY_ITERATION): Likewise.
12653 * s/darwin.h (PTY_ITERATION): Likewise.
12654 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12655
57048744
PE
12656 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12657 * process.c (allocate_pty): Don't declare stb unless it's needed.
12658
7914961c 12659 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12660 (CONSTANTLIM): Remove; unused.
12661 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12662 Define only if needed.
7914961c 12663
b3967b18
PE
12664 * unexelf.c (unexec): Name an expression,
12665 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12666 Use a different way to cause a compilation error if anyone uses
12667 n rather than nn, a way that does not involve shadowing.
73366a00 12668 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12669
29a6015a
PE
12670 * deps.mk (unexalpha.o): Remove; unused.
12671
43cfc33e 12672 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12673 * unexec.h: New file.
ce701a33
PE
12674 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12675 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12676 Depend on unexec.h.
12677 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12678 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12679 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12680 Change as necessary to match prototype in unexec.h.
ce701a33 12681
01f44d5a
PE
12682 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12683 shadowing.
4f63c6bb 12684 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12685
a6670b0b
PE
12686 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12687 Rename locals to avoid shadowing.
12688
cef2010d 12689 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12690 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12691
d4d7173a
PE
12692 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12693
f08b802a
PE
12694 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12695 warning when compiling print.c.
12696
3ddb0639
PE
12697 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12698 instead of using an uninitialized var.
5ad03b97 12699 (font_sort_entities): Mark var as initialized.
3ddb0639 12700
170a2692
PE
12701 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12702
e663c700
PE
12703 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12704 pointers to constants.
89bc529a 12705 (font_parse_fcname): Remove unused vars.
7b81e2d0 12706 (font_delete_unmatched): Now static.
ea838e10 12707 (font_get_spec): Remove; unused.
13a547c6
PE
12708 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12709 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12710 Rename or move locals to avoid shadowing.
e663c700 12711
2a80c887 12712 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12713 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12714
1384fa33 12715 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12716 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12717
8b2c52e9
PE
12718 * alloc.c (mark_backtrace): Move decl from here ...
12719 * lisp.h: ... to here, so that it can be checked.
12720
475545b5 12721 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12722 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12723 (lisp_indirect_variable): Name an expression,
12724 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12725 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12726
b1349114 12727 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12728 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12729 Use const pointer when appropriate.
b1349114 12730
a2928364
PE
12731 * lisp.h (get_system_name, get_operating_system_release):
12732 Move decls here, to check interfaces.
12733 * process.c (get_operating_system_release): Move decl to lisp.h.
12734 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12735 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12736 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12737 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12738 (Fformat_time_string, Fencode_time, Finsert_char):
12739 (Ftranslate_region_internal, Fformat):
12740 Rename or remove local vars to avoid shadowing.
9710023e 12741 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12742
a415e694
PE
12743 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12744 avoid shadowing.
12745
8ef4622d
PE
12746 * lisp.h (eassert): Check that the argument compiles, even if
12747 ENABLE_CHECKING is not defined.
12748
946f9a5b
PE
12749 * data.c (Findirect_variable): Name an expression, to avoid
12750 gcc -Wbad-function-cast warning.
112396d6 12751 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12752 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12753 (Fmake_variable_buffer_local, Fmake_local_variable):
12754 Mark variables as initialized.
52746918 12755 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12756
e5aab7e7 12757 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12758 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12759 Rename locals to avoid shadowing.
dff45157
PE
12760 (mark_stack): Move local variables into the #ifdef region where
12761 they're used.
7bc26fdb
PE
12762 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12763 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12764 needed otherwise.
12765 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12766 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12767 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12768
e5aab7e7
PE
12769 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12770 avoids undefined behavior in theory.
12771
4da60324
PE
12772 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12773
88043301
PE
12774 Use functions, not macros, for up- and down-casing (Bug#8254).
12775 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12776 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12777 to use the following functions instead of these macros.
12778 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12779 EMACS_INT, since callers assume the returned value fits in int.
12780 (upcase1): Likewise, for UPCASE_TABLE.
12781 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12782 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12783 the race-condition problem in the old DOWNCASE.
88043301 12784
19ed5445
PE
12785 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12786 Rename locals to avoid shadowing.
12787 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12788 (regex_compile, re_search_2, re_match_2_internal):
12789 Remove unused local vars.
952db0d7
PE
12790 (FREE_VAR): Rewrite so as not to use empty "else",
12791 which gcc can warn about.
da053e48 12792 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12793 (RETALLOC_IF): Define only if needed.
12794 (WORDCHAR_P): Likewise. This one is never needed, but is used
12795 only in a comment talking about a compiler bug, so put inside
12796 the #if 0 of that comment.
12797 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12798 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12799 Remove; unused.
19ed5445 12800
1f3561e4 12801 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12802 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12803 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12804
ded6f8f7
PE
12805 * search.c (simple_search): Remove unused var.
12806
dbd37a95
PE
12807 * dired.c (compile_pattern): Move decl from here ...
12808 * lisp.h: ... to here, so that it can be checked.
12809 (struct re_registers): New forward decl.
12810
7e47afad
PE
12811 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12812
85f24f61
PE
12813 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12814 All uses changed.
12815 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12816 Rename locals to avoid shadowing.
5671df8f 12817 (Fvertical_motion): Mark locals as initialized.
85f24f61 12818
181aa2be 12819 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12820 (casify_region): Mark local as initialized.
181aa2be 12821
930d429c
PE
12822 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12823
7082eac6
PE
12824 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12825 New macros, so that the caller can use some names other than
12826 gcpro1, gcpro2, etc.
12827 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12828 of the new macros.
12829 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12830 argument, for consistency with GCPRO2_VAR, etc: it is now the
12831 prefix of the variable, not the variable itself. All uses
12832 changed.
38b2c076
PE
12833 * dired.c (directory_files_internal, file_name_completion):
12834 Rename locals to avoid shadowing.
12835
15206ed9
PE
12836 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12837 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12838 dired.c's scmp function, had undefined behavior.
12839 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12840 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12841 * buffer.h: ... to here, because these macros use current_buffer,
12842 and the new implementation with inline functions needs to have
12843 current_buffer in scope now, rather than later when the macros
12844 are used.
12845 (downcase, upcase1): New static inline functions.
12846 (DOWNCASE, UPCASE1): Reimplement using these functions.
12847 This avoids undefined behavior in expressions like
12848 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12849 from race conditions in accessing the global variables
12850 case_temp1 and case_temp2.
12851 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12852 * lisp.h (case_temp1, case_temp2): Remove their decls.
12853 * character.h (ASCII_CHAR_P): Move from here ...
12854 * lisp.h: ... to here, so that the inline functions mentioned
12855 above can use them.
12856
4a6bea26
PE
12857 * dired.c (directory_files_internal_unwind): Now static.
12858
f14b7e14
PE
12859 * fileio.c (file_name_as_directory, directory_file_name):
12860 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12861 Now static.
2893f146
PE
12862 (file_name_as_directory): Use const pointers when appropriate.
12863 (Fexpand_file_name): Likewise. In particular, newdir might
12864 point at constant storage, so make it a const pointer.
fd4ead52 12865 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12866 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12867 signedness issues.
f839df0c
PE
12868 (Fset_file_times, Finsert_file_contents, auto_save_error):
12869 Rename locals to avoid shadowing.
f14b7e14 12870
5716756e 12871 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12872 (Ftry_completion, Fall_completions): Rename or remove locals
12873 to avoid shadowing.
5716756e 12874
b4c3046a
PE
12875 * marker.c (bytepos_to_charpos): Remove; unused.
12876
b45db522
PE
12877 * lisp.h (verify_bytepos, count_markers): New decls,
12878 so that gcc does not warn that these functions aren't declared.
12879
85876d07
PE
12880 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12881 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12882 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12883 (copy_text): Remove unused local var.
85876d07 12884
03d78a21 12885 * filelock.c (within_one_second): Now static.
b3dd38ab 12886 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12887
5df8f01b
PE
12888 * buffer.c (fix_overlays_before): Mark locals as initialized.
12889 (fix_start_end_in_overlays): Likewise. This function should be
12890 simplified by using pointers-to-pointers, but that's a different
12891 matter.
b1d876f1 12892 (switch_to_buffer_1): Now static.
8f54f30a
PE
12893 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12894 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12895
a70072c9 12896 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12897 Fix pointer signedness issue.
edced198
PE
12898 (sys_subshell): Mark local as volatile if checking for lint,
12899 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12900 (MAXPATHLEN): Define only if needed.
a70072c9 12901
a0977c44
PE
12902 * process.c (serial_open, serial_configure): Move decls from here ...
12903 * systty.h: ... to here, so that they can be checked.
12904
a884fdcc
PE
12905 * fns.c (get_random, seed_random): Move extern decls from here ...
12906 * lisp.h: ... to here, so that they can be checked.
12907
604efe86 12908 * sysdep.c (reset_io): Now static.
b8950c94 12909 (wait_for_termination_signal): Remove; unused.
604efe86 12910
38fc62d9
PE
12911 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12912 (copy_keymap_item, append_key, push_text_char_description):
12913 Now static.
1004a21a 12914 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12915 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12916 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12917 (describe_map_tree):
12918 Rename locals to avoid shadowing.
38fc62d9 12919
2f2650da
PE
12920 * keyboard.c: Declare functions static if they are not used elsewhere.
12921 (echo_char, echo_dash, cmd_error, top_level_2):
12922 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12923 (read_char, kbd_buffer_get_event, make_lispy_position):
12924 (make_lispy_event, make_lispy_movement, apply_modifiers):
12925 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12926 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12927 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12928 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12929 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12930
a053e86c 12931 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12932 (mark_kboards): Move decl here ...
12933 * alloc.c (mark_kboards): ... from here.
a053e86c 12934
4752793e
PE
12935 * lisp.h (force_auto_save_soon): New decl.
12936
74f10ca7 12937 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12938 (DEFINE_DUMMY_FUNCTION): New macro.
12939 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12940 Use it.
c03cd23f
PE
12941 (main): Add casts to avoid warnings
12942 if GCC considers string literals to be constants.
74f10ca7 12943
022e70d4
PE
12944 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12945
59d6fe83
PE
12946 * dbusbind.c: Pointer signedness fixes.
12947 (xd_signature, xd_append_arg, xd_initialize):
12948 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12949 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12950 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12951 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12952
78320123
PE
12953 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12954 if GCC considers string literals to be constants.
49cebcca 12955 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12956
35ac2a97
SM
129572011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12958
fb103ca9
SM
12959 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12960 (print_preprocess, print_object): New macro to fix last change.
12961
35ac2a97
SM
12962 * print.c (print_preprocess): Don't forget font objects.
12963
62973b41
JB
129642011-03-16 Juanma Barranquero <lekktu@gmail.com>
12965
12966 * emacs.c (USAGE3): Doc fixes.
12967
0e48bb22
AS
129682011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12969
12970 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12971 structure.
12972
7684e57b
JB
129732011-03-14 Juanma Barranquero <lekktu@gmail.com>
12974
12975 * lisp.h (VWindow_system, Qfile_name_history):
12976 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12977 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12978 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12979
12980 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12981 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12982
12983 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12984 * w32console.c (detect_input_pending, read_input_pending)
12985 (encode_terminal_code):
12986 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12987 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12988 (w32_system_caret_y, Qfile_name_history):
12989 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12990 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12991 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12992 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12993 * w32proc.c (Qlocal, report_file_error):
12994 * w32term.c (Vwindow_system, updating_frame):
12995 * w32uniscribe.c (initialized, uniscribe_font_driver):
12996 Remove unneeded extern declarations.
12997
2aa46d6c
CY
129982011-03-14 Chong Yidong <cyd@stupidchicken.com>
12999
c96bbc66 13000 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13001
cffc6f3b
CY
130022011-03-13 Chong Yidong <cyd@stupidchicken.com>
13003
13004 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13005 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13006 These macros can no longer be used for assignment.
13007
44f230aa
SM
13008 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13009 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13010 (record_buffer_markers, fetch_buffer_markers): New functions for
13011 recording and fetching special buffer markers.
13012 (set_buffer_internal_1, set_buffer_temp): Use them.
13013
13014 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13015
13016 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13017
13018 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13019 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13020
13021 * xdisp.c (hscroll_window_tree):
13022 (reconsider_clip_changes): Use PT instead of BUF_PT.
13023
d251f04b
EZ
130242011-03-13 Eli Zaretskii <eliz@gnu.org>
13025
13026 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13027 $(EMACS_ROOT)/lib/intprops.h.
13028
f0c77cd1
PE
130292011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13030
3eca4629
PE
13031 Fix more problems found by GCC 4.5.2's static checks.
13032
7c86ee98
PE
13033 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13034 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13035 (xg_free_frame_widgets): Make it clear that a local variable is
13036 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13037 (gdk_window_get_screen): Make it clear that this macro is needed
13038 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13039 (int_gtk_range_get_value): New function, which avoids a diagnostic
13040 from gcc -Wbad-function-cast.
13041 (xg_set_toolkit_scroll_bar_thumb): Use it.
13042 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13043 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13044 (get_utf8_string, xg_get_file_with_chooser):
13045 Rename locals to avoid shadowing.
13046 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13047
41729b81
PE
13048 * xgselect.c (xg_select): Remove unused var.
13049
f0c77cd1
PE
13050 * image.c (four_corners_best): Mark locals as initialized.
13051 (gif_load): Initialize transparent_p to zero (Bug#8238).
13052 Mark another local as initialized.
ec6cf4c6 13053 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13054
ce0ad53d 13055 * image.c (clear_image_cache): Now static.
d5d5a617 13056 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13057 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13058 (x_edge_detection): Remove unnecessary cast that
13059 gcc -Wbad-function-cast diagnoses.
2037898d 13060 (gif_load): Fix pointer signedness.
6ae141d6
PE
13061 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13062 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13063
33383987 130642011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13065
d32df629
PE
13066 Improve quality of tests for time stamp overflow.
13067 For example, without this patch (encode-time 0 0 0 1 1
13068 1152921504606846976) returns the obviously-bogus value (-948597
13069 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13070 reports time overflow. See
13071 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13072 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13073 * editfns.c: Include limits.h and intprops.h.
13074 (TIME_T_MIN, TIME_T_MAX): New macros.
13075 (time_overflow): Move earlier, to before first use.
13076 (hi_time, lo_time): New functions, for an accurate test for
13077 out-of-range times.
13078 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13079 (Fget_internal_run_time): Don't assume time_t fits in int.
13080 (make_time): Use list2 instead of Fcons twice.
13081 (Fdecode_time): More accurate test for out-of-range times.
13082 (check_tm_member): New function.
13083 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13084 (lisp_time_argument): Don't rely on undefined left-shift and
13085 right-shift behavior when checking for time stamp overflow.
8be6f318 13086
fe31d94c
PE
13087 * editfns.c (time_overflow): New function, refactoring common code.
13088 (Fformat_time_string, Fdecode_time, Fencode_time):
13089 (Fcurrent_time_string): Use it.
13090
8be6f318
PE
13091 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13092 * dired.c (make_time): Move to ...
13093 * editfns.c (make_time): ... here.
13094 * systime.h: Note the move.
13095
09d9db2c 130962011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13097
126bc0dc
YM
13098 * fringe.c (update_window_fringes): Remove unused variables.
13099
c47cbdfd
YM
13100 * unexmacosx.c (copy_data_segment): Also copy __got section.
13101 (Bug#8223)
13102
7ac80be9
EZ
131032011-03-12 Eli Zaretskii <eliz@gnu.org>
13104
c96bbc66 13105 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13106 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13107 Constify `char *' arguments and their references according to
13108 prototypes in tparam.h.
13109
ecb0f94d 13110 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13111
7ac80be9
EZ
13112 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13113 Adapt all references accordingly.
13114
13115 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13116
ef1fd07e
TT
131172011-03-11 Tom Tromey <tromey@redhat.com>
13118
13119 * buffer.c (syms_of_buffer): Remove obsolete comment.
13120
7ef4b50c
EZ
131212011-03-11 Eli Zaretskii <eliz@gnu.org>
13122
13123 * termhooks.h (encode_terminal_code): Declare prototype.
13124
13125 * msdos.c (encode_terminal_code): Don't declare prototype.
13126
13127 * term.c (encode_terminal_code): Now external again, used by
13128 w32console.c and msdos.c.
13129
44f230aa
SM
13130 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13131 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13132
4b1ec863 131332011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13134
1714f52b 13135 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13136
4b1ec863
PE
13137 * fringe.c (update_window_fringes): Mark locals as initialized
13138 (Bug#8227).
13139 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13140
524c7aa6
PE
13141 * alloc.c (mark_fringe_data): Move decl from here ...
13142 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13143 to check its interface.
13144 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13145
a5c0af81 13146 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13147 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13148 (fontset_font): Mark local as initialized.
a9a06e0b 13149 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13150
b4716021
PE
13151 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13152
811e9bac 13153 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13154 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13155 (x_own_selection, Fx_disown_selection_internal): Rename locals
13156 to avoid shadowing.
13157 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13158
7e3ab302
PE
13159 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13160 so that the caller can use some name other than gcpro1.
13161 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13162 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13163 (Fx_backspace_delete_keys_p):
13164 Use them to avoid shadowing, and rename vars to avoid shadowing.
13165 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13166 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13167 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13168 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13169 Remove unused locals.
7e3ab302
PE
13170 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13171 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13172 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13173 macros.
f78faa98 13174
e2b13473
PE
13175 * xterm.h (x_mouse_leave): New decl.
13176
77f23912
PE
13177 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13178 Remove unused functions.
cdf4ba58
PE
13179 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13180 (x_calc_absolute_position): Now static.
7411c686 13181 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13182 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13183 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13184 unless they are used.
38d0b34a
PE
13185 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13186 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13187 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13188 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13189 (x_error_catcher, x_connection_closed, x_error_handler):
13190 (x_error_quitter, xembed_send_message, x_iconify_frame):
13191 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13192 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13193 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13194
44f230aa
SM
13195 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13196 Rename or move locals to avoid shadowing.
6b463e58 13197 (tty_defined_color, merge_face_heights): Now static.
5967d051 13198 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13199 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13200 does not deduce is never used uninitialized.
73719eba
PE
13201 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13202 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13203
426994c3 13204 * terminal.c (store_terminal_param): Now static.
5489860b 13205
032f1620 13206 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13207 (set_frame_menubar): Remove unused local.
d4323972 13208 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13209 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13210 since they might point to immutable storage.
281585b0
PE
13211 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13212 since it's unused otherwise.
032f1620 13213
367c19e5 13214 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13215 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13216 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13217 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13218 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13219 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13220 does not deduce are never used uninitialized.
70739cbe 13221
07b48fa9
PE
13222 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13223
8868a238 13224 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13225 * window.c (window_loop, size_window):
13226 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13227
7e5cf297 13228 * window.c (display_buffer): Now static.
d6550a9f
PE
13229 (size_window): Mark variables that gcc -Wuninitialized
13230 does not deduce are never used uninitialized.
a586633d
PE
13231 * window.h (check_all_windows): New decl, to forestall
13232 gcc -Wmissing-prototypes diagnostic.
5b555da1 13233 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13234
f6095868
PE
13235 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13236 shadowing.
13237 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13238 Include <limits.h>.
13239 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13240 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13241 (load_charset_map): Mark variables that gcc -Wuninitialized
13242 does not deduce are never used uninitialized.
53df7c11 13243 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13244
f38b440c
PE
13245 * coding.c (coding_set_source, coding_set_destination):
13246 Use "else { /* comment */ }" rather than "else /* comment */;"
13247 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13248 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13249 a block, when the outer 'i' will do.
13250 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13251 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13252 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13253 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13254 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13255 Rename locals to avoid shadowing.
13256 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13257 * coding.c (emacs_mule_char, encode_invocation_designation):
13258 Now static, since they're not used elsewhere.
413bb2db 13259 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13260 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13261 (decode_coding_emacs_mule): Mark variables that gcc
13262 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13263 (detect_coding_iso_2022): Initialize a local variable that might
13264 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13265 this initialization is needed. (Bug#8211)
5f58e762
PE
13266 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13267 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13268 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13269 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13270 Remove unused macros.
f38b440c 13271
232b38b9 13272 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13273 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13274 * character.c (string_count_byte8): Likewise.
232b38b9 13275
fb90da1b
PE
13276 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13277 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13278
fb93dbc2
PE
13279 * chartab.c (copy_sub_char_table): Now static, since it's not used
13280 elsewhere.
5c156ace
PE
13281 (sub_char_table_ref_and_range, char_table_ref_and_range):
13282 Rename locals to avoid shadowing.
bbcd0949 13283 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13284
7d3b3862 13285 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13286 (BIDI_BOB): Remove unused macro.
7d3b3862 13287
6be7d3da
PE
13288 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13289 deduce are never used uninitialized.
c2ed9c8b 13290 * term.c (encode_terminal_code): Likewise.
6be7d3da 13291
75f8807f 13292 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13293
50938595
PE
13294 * tparam.h: New file.
13295 * term.c, tparam.h: Include it.
13296 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13297 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13298 Move these decls to tparam.h, and make them agree with what
13299 is actually in tparam.c. The previous trick of using incompatible
13300 decls in different modules does not conform to the C standard.
13301 All callers of tparam changed to use tparam's actual API.
13302 * tparam.c (tparam1, tparam, tgoto):
13303 Use const pointers where appropriate.
13304
fbceeba2
PE
13305 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13306 * cm.h (struct cm): Likewise.
13307 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13308 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13309 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13310 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13311 (turn_on_face, init_tty): Likewise.
13312 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13313
7f3f1250
PE
13314 * term.c (term_mouse_position): Rename local to avoid shadowing.
13315
e6ca6543
PE
13316 * alloc.c (mark_ttys): Move decl from here ...
13317 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13318
c40f8d15
AS
133192011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13320
13321 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13322
cfe0661d
JB
133232011-03-09 Juanma Barranquero <lekktu@gmail.com>
13324
13325 * search.c (compile_pattern_1): Remove argument regp, unused since
13326 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13327 (compile_pattern): Don't pass it.
13328
0afb4571
J
133292011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13330
13331 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13332 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13333 for ! HAVE_GTK3.
13334 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13335
13336 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13337
13338 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13339 gdk_window_get_screen, gdk_window_get_geometry,
13340 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13341 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13342 (xg_get_pixbuf_from_pixmap): New function.
13343 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13344 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13345 Call xg_get_pixbuf_from_pixmap instead of
13346 gdk_pixbuf_get_from_drawable.
13347 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13348 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13349 (xg_check_special_colors): Use GtkStyleContext and its functions
13350 for HAVE_GTK3.
13351 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13352 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13353 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13354 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13355 Call gtk_widget_get_preferred_size.
0afb4571
J
13356 (xg_frame_resized): gdk_window_get_geometry only takes 5
13357 parameters.
44f230aa
SM
13358 (xg_win_to_widget, xg_event_is_for_menubar):
13359 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13360 (xg_set_widget_bg): New function.
13361 (delete_cb): New function.
895009e1 13362 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13363 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13364 (xg_set_background_color): Call xg_set_widget_bg.
13365 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13366 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13367 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13368 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13369 if ! HAVE_GTK3.
13370 (update_frame_tool_bar): Call gtk_widget_hide.
13371 (xg_initialize): Use GDK_KEY_g.
13372
13373 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13374 if ! HAVE_GTK3
13375 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13376
13377 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13378 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13379 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13380
1c2cc4ef
JB
133812011-03-08 Juanma Barranquero <lekktu@gmail.com>
13382
13383 * w32xfns.c (select_palette): Check success of RealizePalette against
13384 GDI_ERROR, not zero.
13385
33383987 13386See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13387
13388;; Local Variables:
13389;; coding: utf-8
aac0c6e3
MR
13390;; End:
13391
2f097256 13392 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13393
13394 This file is part of GNU Emacs.
13395
13396 GNU Emacs is free software: you can redistribute it and/or modify
13397 it under the terms of the GNU General Public License as published by
13398 the Free Software Foundation, either version 3 of the License, or
13399 (at your option) any later version.
13400
13401 GNU Emacs is distributed in the hope that it will be useful,
13402 but WITHOUT ANY WARRANTY; without even the implied warranty of
13403 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13404 GNU General Public License for more details.
13405
13406 You should have received a copy of the GNU General Public License
13407 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.